Update AudioSession route sharing policy
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2
3         Update AudioSession route sharing policy
4         https://bugs.webkit.org/show_bug.cgi?id=196776
5         <rdar://problem/46501611>
6
7         Reviewed by Jer Noble.
8
9         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
10         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
11         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
12         (TestWebKitAPI::TEST):
13
14 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
15
16         [iOS] Software keyboard is shown too frequently on some websites
17         https://bugs.webkit.org/show_bug.cgi?id=195856
18         <rdar://problem/49191395>
19
20         Reviewed by Darin Adler.
21
22         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
23
24         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
25         (WTR::UIScriptController::setHardwareKeyboardAttached):
26         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
27         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
28         (WTR::UIScriptController::setHardwareKeyboardAttached):
29         * TestRunnerShared/UIScriptContext/UIScriptController.h:
30         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
31
32         Additionally link against GraphicsServices in WebKitTestRunner.
33
34         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
35         (WTR::TestController::platformResetStateToConsistentValues):
36         (WTR::UIScriptController::setHardwareKeyboardAttached):
37
38 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
39
40         [GTK][WPE] Fix pacman install-dependencies packages
41         https://bugs.webkit.org/show_bug.cgi?id=196817
42
43         Reviewed by Žan Doberšek.
44         
45         python3-setuptools is called python-setuptools
46         ruby-highline is only available on AUR
47         libv4l-devel is incorporated in v4l-utils
48
49         * gtk/install-dependencies:
50         * wpe/install-dependencies:
51
52 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
53
54         [GTK] REGRESSION(r243860): Many tests failing
55         https://bugs.webkit.org/show_bug.cgi?id=196791
56
57         Reviewed by Joanmarie Diggs.
58
59         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
60         multiple documents and check that accessibility hierarchy is updated after a navigation.
61
62         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
63         (loadChangedCallback):
64         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
65         (AccessibilityTest::AccessibilityTest):
66         (AccessibilityTest::~AccessibilityTest):
67         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
68         (AccessibilityTest::findTestServerApplication):
69         (AccessibilityTest::findDocumentWeb):
70         (AccessibilityTest::findRootObject):
71         (AccessibilityTest::waitUntilChildrenRemoved):
72         (AccessibilityTest::ensureProxy):
73         (testAtspiBasicHierarchy):
74         (beforeAll):
75         (afterAll):
76
77 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
78
79         [ews-build] Handle bug titles with unicode characters
80         https://bugs.webkit.org/show_bug.cgi?id=196802
81
82         Reviewed by Dewei Zhu.
83
84         * BuildSlaveSupport/ews-build/steps.py:
85         (ValidatePatch._is_bug_closed):
86
87 2019-04-11  Michael Saboff  <msaboff@apple.com>
88
89         Improve the Inline Cache Stats code
90         https://bugs.webkit.org/show_bug.cgi?id=196836
91
92         Reviewed by Saam Barati.
93
94         Added a new script to consolidate and arrange the output of --useICStats option.
95
96         This script merges the output from every group into one large table and sorts it from most common to
97         least common.  It also counts the slow path GetById and PutById variants and then calculates the
98         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
99         Put together, this is useful to see what property accesses are not getting cached.
100
101         * Scripts/ic-stats.py: Added.
102         (ICStats):
103         (ICStats.__init__):
104         (ICStats.parse):
105         (ICStats.dumpStats):
106         (usage):
107
108 2019-04-10  Alex Christensen  <achristensen@webkit.org>
109
110         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
111         https://bugs.webkit.org/show_bug.cgi?id=196809
112         <rdar://49800762>
113
114         Reviewed by Brady Eidson.
115
116         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
117         (TEST):
118
119 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
120
121         requestAnimationFrame should execute before the next frame
122         https://bugs.webkit.org/show_bug.cgi?id=177484
123
124         Reviewed by Simon Fraser.
125
126         Add trace points for the page RenderingUpdate.
127
128         * Tracing/SystemTracePoints.plist:
129
130 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
131
132         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
133         https://bugs.webkit.org/show_bug.cgi?id=196760
134
135         Reviewed by Don Olmstead.
136
137         vswhere.exe has been bundled since Visual Studio 2017 version
138         15.2. We shouldn't download vswhere.exe.
139
140         * Scripts/build-jsc: Do not call update-vswhere.py.
141         * Scripts/build-webkit: Ditto.
142         * Scripts/update-vswhere.py: Removed.
143         * Scripts/webkitdirs.pm:
144         (requireModulesForVSWhere): Deleted.
145         (pickCurrentVisualStudioInstallation): Deleted.
146         (visualStudioInstallDirVSWhere): Return the latest installed VS
147         installation path by using the bundled vswhere.exe.
148         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
149         (visualStudioInstallDirFallback): Removed.
150
151 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
154         https://bugs.webkit.org/show_bug.cgi?id=196780
155
156         Reviewed by Alexey Proskuryakov.
157
158         * BuildSlaveSupport/ews-build/steps.py:
159         * BuildSlaveSupport/ews-build/steps_unittest.py:
160
161 2019-04-10  Alex Christensen  <achristensen@webkit.org>
162
163         Add SPI WKNavigationResponse._downloadAttribute
164         https://bugs.webkit.org/show_bug.cgi?id=196755
165         <rdar://49587365>
166
167         Reviewed by Brady Eidson.
168
169         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
170         (-[NavigationResponseTestDelegate navigationResponse]):
171         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
172         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
173         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
174         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
175         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
176         (readRequest):
177         (writeResponse):
178         (TEST):
179
180 2019-04-10  Tim Horton  <timothy_horton@apple.com>
181
182         Add modern API for overriding the page's specified viewport configuration
183         https://bugs.webkit.org/show_bug.cgi?id=167734
184         <rdar://problem/30331795>
185
186         Reviewed by Simon Fraser.
187
188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
189         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
190
191 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
192
193         Add support for incremental bytecode cache updates
194         https://bugs.webkit.org/show_bug.cgi?id=195000
195
196         Reviewed by Filip Pizlo.
197
198         Exit when the initial run to generate bytecode fails.
199
200         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
201
202 2019-04-10  Alex Christensen  <achristensen@webkit.org>
203
204         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
205         https://bugs.webkit.org/show_bug.cgi?id=196744
206         <rdar://49415309>
207
208         Reviewed by Chris Dumez.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
211         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
212
213 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
214
215         Add a way to opt into modern compatibility mode in layout tests
216         https://bugs.webkit.org/show_bug.cgi?id=196770
217         <rdar://problem/49777550>
218
219         Reviewed by Antoine Quint.
220
221         Add a new test option to enable modern compatibility mode in layout tests.
222
223         * WebKitTestRunner/TestController.cpp:
224         (WTR::updateTestOptionsFromTestHeader):
225         * WebKitTestRunner/TestController.h:
226         * WebKitTestRunner/TestOptions.h:
227         (WTR::TestOptions::hasSameInitializationOptions const):
228         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
229         (WTR::TestController::platformCreateWebView):
230         (WTR::TestController::enableModernCompatibilityMode):
231
232 2019-04-10  Andy Estes  <aestes@apple.com>
233
234         Try to fix the 32-bit watchOS build.
235
236         * TestWebKitAPI/cocoa/TestWKWebView.mm:
237         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
238
239 2019-04-10  Antoine Quint  <graouts@apple.com>
240
241         Enable Pointer Events on watchOS
242         https://bugs.webkit.org/show_bug.cgi?id=196771
243         <rdar://problem/49040909>
244
245         Reviewed by Dean Jackson.
246
247         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
248
249 2019-04-10  Philippe Normand  <pnormand@igalia.com>
250
251         Unreviewed. Fix WPE accessibility tests after r244059.
252
253         We are failing to load the injected bundle due to undefined symbol
254         AccessibilityUIElement::replaceTextInRange().
255
256         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
257         (WTR::AccessibilityUIElement::replaceTextInRange):
258
259 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
260
261         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
262         https://bugs.webkit.org/show_bug.cgi?id=196727
263
264         Reviewed by Fujii Hironori.
265
266         * MiniBrowser/win/WebKitBrowserWindow.cpp:
267         (WebKitBrowserWindow::create):
268
269 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
270
271         [ews-build] Add unit tests for PrintConfiguration
272         https://bugs.webkit.org/show_bug.cgi?id=196752
273
274         Reviewed by Dewei Zhu.
275
276         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
277
278 2019-04-09  Keith Rollin  <krollin@apple.com>
279
280         Unreviewed build maintenance -- update .xcfilelists.
281
282         * DumpRenderTree/DerivedSources-input.xcfilelist:
283         * DumpRenderTree/DerivedSources-output.xcfilelist:
284
285 2019-04-09  Zalan Bujtas  <zalan@apple.com>
286
287         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
288         https://bugs.webkit.org/show_bug.cgi?id=196743
289         <rdar://problem/43897551>
290
291         Reviewed by Tim Horton.
292
293         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
294         (TEST):
295
296 2019-04-09  Youenn Fablet  <youenn@apple.com>
297
298         Close service worker database on network process suspension
299         https://bugs.webkit.org/show_bug.cgi?id=196623
300         <rdar://problem/48930869>
301
302         Reviewed by Alex Christensen.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
305
306 2019-04-09  Daniel Bates  <dabates@apple.com>
307
308         [iPad] Should open popover when the spacebar is pressed
309         https://bugs.webkit.org/show_bug.cgi?id=196360
310         <rdar://problem/49389129>
311
312         Reviewed by Brent Fulgham.
313
314         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
315
316         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
317         (WTR::UIScriptController::isShowingPopover const): Added.
318         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
319         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
320         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
321         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
322         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
323         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
324         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
325         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
326         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
327         (WTR::UIScriptController::isShowingPopover const): Added.
328         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
329         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
330         * TestRunnerShared/UIScriptContext/UIScriptController.h:
331         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
332         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
333         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
334         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
335         (-[TestRunnerWKWebView _willPresentPopover]): Added.
336         (-[TestRunnerWKWebView _didDismissPopover]): Added.
337         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
338         (WTR::UIScriptController::isShowingPopover const): Added.
339         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
340         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
341
342 2019-04-09  Alex Christensen  <achristensen@webkit.org>
343
344         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
345         https://bugs.webkit.org/show_bug.cgi?id=196665
346         <rdar://45115669>
347
348         Reviewed by Geoff Garen.
349
350         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
351         (goBack):
352         (+[SimpleLookupContext sharedLookupContext]):
353         (-[SimpleLookupContext lookUpURL:completionHandler:]):
354         (TEST):
355         (+[Simple3LookupContext sharedLookupContext]): Deleted.
356         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
357
358 2019-04-09  John Wilander  <wilander@apple.com>
359
360         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
361         https://bugs.webkit.org/show_bug.cgi?id=196558
362         <rdar://problem/47650245>
363
364         Reviewed by Youenn Fablet.
365
366         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
367         (TestWebKitAPI::TEST):
368             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
369
370 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
371
372         [CMake] Apple builds should use ICU_INCLUDE_DIRS
373         https://bugs.webkit.org/show_bug.cgi?id=196720
374
375         Reviewed by Konstantin Tokarev.
376
377         * TestWebKitAPI/PlatformMac.cmake:
378
379 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
380
381         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
382         https://bugs.webkit.org/show_bug.cgi?id=196694
383         <rdar://problem/48388734>
384
385         Rubber-stamped by Aakash Jain.
386
387         * Scripts/webkitpy/port/image_diff.py:
388         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
389         * Scripts/webkitpy/port/server_process.py:
390         (ServerProcess.has_available_stdout): Check if stdout has data in it.
391         (ServerProcess._wait_for_data_and_update_buffers_using_select):
392         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
393         * Scripts/webkitpy/port/server_process_mock.py:
394         (MockServerProcess.has_available_stdout):
395         * Scripts/webkitpy/port/server_process_unittest.py:
396         (TestServerProcess.serial_test_basic):
397
398 2019-04-09  Jer Noble  <jer.noble@apple.com>
399
400         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
401         https://bugs.webkit.org/show_bug.cgi?id=196097
402
403         Reviewed by Eric Carlson.
404
405         Drive-by bug fix: allow tests to play audio without a user gesture by default.
406
407         * DumpRenderTree/mac/DumpRenderTree.mm:
408         (resetWebPreferencesToConsistentValues):
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::resetPreferencesToConsistentValues):
411
412 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
413
414         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
415         https://bugs.webkit.org/show_bug.cgi?id=196690
416
417         Reviewed by Michael Catanzaro.
418
419         * QueueStatusServer/config/queues.py:
420         * Scripts/webkitpy/common/config/ews.json:
421         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
422         (test_ews_name):
423
424 2019-04-09  Chris Dumez  <cdumez@apple.com>
425
426         Loads using loadHTMLString() cause flashing when process-swapping
427         https://bugs.webkit.org/show_bug.cgi?id=196714
428         <rdar://problem/49637354>
429
430         Reviewed by Antti Koivisto.
431
432         Add API test coverage.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
435
436 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
437
438         Unreviewed. Fix ATK accessibility tests after r244059.
439
440         We are failing to load the injected bundle due to undefined symbol
441         AccessibilityUIElement::replaceTextInRange().
442
443         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
444         (WTR::AccessibilityUIElement::replaceTextInRange):
445
446 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
447
448         AX: Support API: accessibilityReplaceRange:withText
449         https://bugs.webkit.org/show_bug.cgi?id=196636
450
451         Unreviewed build fix for Windows port.
452
453         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
454         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
455
456 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
457
458         [CMake][WinCairo] Separate copied headers into different directories
459         https://bugs.webkit.org/show_bug.cgi?id=196655
460
461         Reviewed by Michael Catanzaro.
462
463         * DumpRenderTree/CMakeLists.txt:
464         * MiniBrowser/win/CMakeLists.txt:
465         * TestWebKitAPI/CMakeLists.txt:
466         * TestWebKitAPI/PlatformWin.cmake:
467
468 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
469
470         Log stack-trace for run-webkit-tests when interrupted
471         https://bugs.webkit.org/show_bug.cgi?id=176393
472         <rdar://problem/34262310>
473
474         Reviewed by Lucas Forschler.
475
476         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
477         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
478         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
479         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
480         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
481         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
482         (main): Set handlers to log stack trace on interruption.
483
484 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
485
486         AX: Support API: accessibilityReplaceRange:withText
487         https://bugs.webkit.org/show_bug.cgi?id=196636
488
489         Unreviewed build fix for Windows port.
490
491         * DumpRenderTree/AccessibilityUIElement.cpp:
492         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
493
494 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
495
496         [ews-build] Scripts using Buildbot API have CORS error
497         https://bugs.webkit.org/show_bug.cgi?id=196709
498
499         Reviewed by Alexey Proskuryakov.
500
501         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
502
503 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
504
505         AX: Support API: accessibilityReplaceRange:withText
506         https://bugs.webkit.org/show_bug.cgi?id=196636
507
508         Reviewed by Daniel Bates.
509
510         * DumpRenderTree/AccessibilityUIElement.cpp:
511         (replaceTextInRangeCallback):
512         (AccessibilityUIElement::replaceTextInRange):
513         (AccessibilityUIElement::getJSClass):
514         * DumpRenderTree/AccessibilityUIElement.h:
515         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
516         (AccessibilityUIElement::replaceTextInRange):
517         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
518         (AccessibilityUIElement::replaceTextInRange):
519         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
520         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
521         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
522         (WTR::AccessibilityUIElement::replaceTextInRange):
523         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
524         (WTR::AccessibilityUIElement::replaceTextInRange):
525
526 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
527
528         [iOS] Do not allow starting selection drags when selection views are not visible
529         https://bugs.webkit.org/show_bug.cgi?id=196686
530         <rdar://problem/49399192>
531
532         Reviewed by Tim Horton.
533
534         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
535         also add some new API tests to cover scenarios where the web view is not first responder.
536
537         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
538         (TestWebKitAPI::TEST):
539         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
540
541         Add a switch to optionally make the web view first responder when starting the simulated drag.
542
543         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
544         (-[DragAndDropSimulator initWithWebView:]):
545         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
546
547 2019-04-08  Justin Fan  <justin_fan@apple.com>
548
549         [Web GPU] Fix Web GPU experimental feature on iOS
550         https://bugs.webkit.org/show_bug.cgi?id=196632
551
552         Reviewed by Myles C. Maxfield.
553
554         Properly make Web GPU available on iOS 11+.
555
556         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
557
558 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
559
560         [ews-build] Do not upload archive when Compile Fails
561         https://bugs.webkit.org/show_bug.cgi?id=196674
562
563         Reviewed by Alexey Proskuryakov.
564
565         * BuildSlaveSupport/ews-build/factories.py:
566         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
567         * BuildSlaveSupport/ews-build/steps.py:
568         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
569         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
570         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
571
572 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
573
574         Enable DFG on MIPS
575         https://bugs.webkit.org/show_bug.cgi?id=196689
576
577         Reviewed by Žan Doberšek.
578
579         Since the bytecode change, we enabled the baseline JIT on mips in
580         r240432, but DFG is still missing. With this change, all tests are
581         passing on a ci20 board.
582
583         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
584
585 2019-04-08  Philippe Normand  <pnormand@igalia.com>
586
587         [Flatpak] Second run update-webkitwpe-flatpak fails
588         https://bugs.webkit.org/show_bug.cgi?id=192702
589
590         Reviewed by Carlos Garcia Campos.
591
592         * flatpak/flatpakutils.py:
593         (FlatpakObject.flatpak): Fix typo.
594         (FlatpakPackage.install): When installing, also update to the configured remote commit.
595         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
596
597 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
598
599         [GTK][WPE] outlook.live.com displays old-fashioned UI
600         https://bugs.webkit.org/show_bug.cgi?id=196642
601
602         Reviewed by Carlos Garcia Campos.
603
604         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
605         (TestWebKitAPI::TEST): New Mac platform quirk test.
606
607 2019-04-07  Commit Queue  <commit-queue@webkit.org>
608
609         Unreviewed, rolling out r243956.
610         https://bugs.webkit.org/show_bug.cgi?id=196688
611
612         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
613         by aakashjain on #webkit).
614
615         Reverted changeset:
616
617         "Clicking "Go Back" from a safe browsing warning from an
618         iframe should navigate the WKWebView back to the previous
619         page"
620         https://bugs.webkit.org/show_bug.cgi?id=196665
621         https://trac.webkit.org/changeset/243956
622
623 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
624
625         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
626         https://bugs.webkit.org/show_bug.cgi?id=196669
627
628         Reviewed by Geoffrey Garen.
629
630         Added three new unit tests for WeakHashSet.
631
632         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
633         (WTF_WeakPtr.WeakHashSetConstObjects):
634         (WTF_WeakPtr.WeakHashSetComputesEmpty):
635         (WTF_WeakPtr.WeakHashSetComputeSize):
636
637 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
638
639         Hide next and previous form control buttons when WKWebView is editable
640         https://bugs.webkit.org/show_bug.cgi?id=196672
641         <rdar://problem/35625321>
642
643         Reviewed by Tim Horton.
644
645         Add a new API test.
646
647         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
648         (-[TestWKWebView lastTrailingBarButtonGroup]):
649         (TestWebKitAPI::TEST):
650         * TestWebKitAPI/ios/UIKitSPI.h:
651
652 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
653
654         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
655         https://bugs.webkit.org/show_bug.cgi?id=196077
656         <rdar://problem/49108202>
657
658         Reviewed by Chris Dumez.
659
660         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
661         on new web view.
662
663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
664
665 2019-04-05  Saam Barati  <sbarati@apple.com>
666
667         Make compare-results understand MotionMark
668         https://bugs.webkit.org/show_bug.cgi?id=196666
669
670         Reviewed by Yusuke Suzuki.
671
672         * Scripts/compare-results:
673         (PLT5Results):
674         (detectMotionMark):
675         (detectMotionMark1_1):
676         (motionMarkResults):
677         (motionMark1_1Results):
678         (detectBenchmark):
679         (biggerIsBetter):
680         (main):
681
682 2019-04-05  Alex Christensen  <achristensen@webkit.org>
683
684         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
685         https://bugs.webkit.org/show_bug.cgi?id=196665
686         <rdar://45115669>
687
688         Reviewed by Geoff Garen.
689
690         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
691         (goBack):
692         (+[SimpleLookupContext sharedLookupContext]):
693         (-[SimpleLookupContext lookUpURL:completionHandler:]):
694         (TEST):
695         (+[Simple3LookupContext sharedLookupContext]): Deleted.
696         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
697
698 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
699
700         [ews-build] Add configuration and architecture for windows builders
701         https://bugs.webkit.org/show_bug.cgi?id=196660
702
703         Reviewed by Lucas Forschler.
704
705         * BuildSlaveSupport/ews-build/config.json:
706
707 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
708
709         webkitpy: Don't run subsequent rounds if interrupted
710         https://bugs.webkit.org/show_bug.cgi?id=196646
711
712         Reviewed by Aakash Jain.
713
714         * Scripts/webkitpy/layout_tests/controllers/manager.py:
715         (Manager.run): Bail out if interrupted.
716
717 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
718
719         Test sessionStorage in PSON private browsing mode
720         https://bugs.webkit.org/show_bug.cgi?id=196561
721
722         Reviewed by Alex Christensen.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
725
726 2019-04-05  Commit Queue  <commit-queue@webkit.org>
727
728         Unreviewed, rolling out r243833.
729         https://bugs.webkit.org/show_bug.cgi?id=196645
730
731         This change breaks build of WPE and GTK ports (Requested by
732         annulen on #webkit).
733
734         Reverted changeset:
735
736         "[CMake][WTF] Mirror XCode header directories"
737         https://bugs.webkit.org/show_bug.cgi?id=191662
738         https://trac.webkit.org/changeset/243833
739
740 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
741
742         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
743         https://bugs.webkit.org/show_bug.cgi?id=196635
744
745         Reviewed by Antti Koivisto.
746         
747         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
748         for a test to enable async frame scrolling via:
749             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
750         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
751         
752         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
753
754         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
755         (WTR::InjectedBundle::beginTesting):
756         * WebKitTestRunner/TestController.cpp:
757         (WTR::TestController::resetPreferencesToConsistentValues):
758
759 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
760
761         Use a correct LC_RPATH when building with ASan
762         https://bugs.webkit.org/show_bug.cgi?id=196576
763
764         Reviewed by David Kilzer.
765
766         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
767         so that ../Frameworks is checked. This is simpler and more reliable than updating
768         each SPC service xcconfig.
769
770 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
771
772         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
773         https://bugs.webkit.org/show_bug.cgi?id=196629
774
775         Reviewed by Lucas Forschler.
776
777         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
778
779 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
782         https://bugs.webkit.org/show_bug.cgi?id=196618
783
784         Reviewed by Lucas Forschler.
785
786         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
787         (StatusBubble): Added QUEUE_TRIGGERS.
788         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
789         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
790         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
791         its parent(builder).
792
793 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
794
795         [ews-app] Status-bubble steps are sometimes displayed in reverse order
796         https://bugs.webkit.org/show_bug.cgi?id=196625
797
798         Reviewed by Lucas Forschler.
799
800         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
801         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
802
803 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
804
805         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
806         https://bugs.webkit.org/show_bug.cgi?id=196630
807
808         Reviewed by Wenson Hsieh.
809
810         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
811
812 2019-04-04  Youenn Fablet  <youenn@apple.com>
813
814         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
815         https://bugs.webkit.org/show_bug.cgi?id=196543
816
817         Reviewed by Alex Christensen.
818
819         * WebKitTestRunner/TestController.cpp:
820         (WTR::TestController::generatePageConfiguration):
821
822 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-app] Status bubble should not display skipped buildbot steps
825         https://bugs.webkit.org/show_bug.cgi?id=196584
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
830
831 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
832
833         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
834         https://bugs.webkit.org/show_bug.cgi?id=196620
835
836         Reviewed by Lucas Forschler.
837
838         * BuildSlaveSupport/ews-app/ews/config.py:
839
840 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
841
842         [Win] DumpRenderTreeWatchDog.py is not checked into source
843         https://bugs.webkit.org/show_bug.cgi?id=196567
844         <rdar://problem/49525901>
845
846         Reviewed by Lucas Forschler.
847
848         This script is used on Win EWS bots to terminate hanging DRT processes.
849
850         * EWSTools/dumprendertreewatchdog.py: Added.
851
852 2019-04-04  Chris Dumez  <cdumez@apple.com>
853
854         Unreviewed, roll out r243858 which made tests time out.
855
856         Disable new API tests on Windows instead.
857
858         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
859         (TestWebKitAPI::TEST):
860
861 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         [ATK] Cleanup WebPageAccessibilityObjectAtk
864         https://bugs.webkit.org/show_bug.cgi?id=196537
865
866         Reviewed by Michael Catanzaro.
867
868         Also consider files under atk directories as exceptions for GObject conventions.
869
870         * Scripts/webkitpy/style/checkers/cpp.py:
871         (check_identifier_name_in_declaration):
872
873 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
874
875         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
876         https://bugs.webkit.org/show_bug.cgi?id=196588
877         <rdar://problem/49365787>
878
879         Unreviewed build fix for Windows port.
880
881         error C3861: 'kill': identifier not found
882
883         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
884         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
885
886 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
887
888         [ews-build] Cancel build and similar operations should have authentication
889         https://bugs.webkit.org/show_bug.cgi?id=196520
890
891         Reviewed by Dewei Zhu.
892
893         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
894         environment variables.
895
896 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
897
898         [ews-build] Do not trigger queues which are not in production yet
899         https://bugs.webkit.org/show_bug.cgi?id=196581
900
901         Reviewed by Dewei Zhu.
902
903         * BuildSlaveSupport/ews-build/config.json:
904
905 2019-04-03  Chris Dumez  <cdumez@apple.com>
906
907         Unreviewed, fix typo in the name of API test added in r243848.
908
909         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
910         (TestWebKitAPI::TEST):
911
912 2019-04-03  Chris Dumez  <cdumez@apple.com>
913
914         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
915         https://bugs.webkit.org/show_bug.cgi?id=196588
916         <rdar://problem/49365787>
917
918         Reviewed by Ryosuke Niwa.
919
920         Add API test coverage.
921
922         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
923         (TestWebKitAPI::nullJavaScriptCallback):
924         (TestWebKitAPI::didCrashCheckFrames):
925         (TestWebKitAPI::TEST):
926
927 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
928
929         run-webkit-tests: Upload test results (new results database)
930         https://bugs.webkit.org/show_bug.cgi?id=196577
931         <rdar://problem/34841155>
932
933         Reviewed by Lucas Forschler.
934
935         * Scripts/webkitpy/layout_tests/controllers/manager.py:
936         (Manager.run): Upload results after each device shard, since the configuration will be
937         different for each device.
938         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
939         uploaded to a results database.
940         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
941         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
942
943 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
944
945         -apple-trailing-word is needed for browser detection
946         https://bugs.webkit.org/show_bug.cgi?id=196575
947
948         Unreviewed.
949
950         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
951
952 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
953
954         [CMake][WTF] Mirror XCode header directories
955         https://bugs.webkit.org/show_bug.cgi?id=191662
956
957         Reviewed by Konstantin Tokarev.
958
959         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
960         builds.
961
962         * CMakeLists.txt:
963         * DumpRenderTree/CMakeLists.txt:
964         * DumpRenderTree/PlatformWin.cmake:
965         * MiniBrowser/win/CMakeLists.txt:
966         * TestWebKitAPI/CMakeLists.txt:
967         * TestWebKitAPI/PlatformWin.cmake:
968         * WebKitTestRunner/PlatformGTK.cmake:
969         * WebKitTestRunner/PlatformWin.cmake:
970
971 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
972
973         [ews-app] Status bubble should not display certain infrastructure status messages
974         https://bugs.webkit.org/show_bug.cgi?id=196550
975
976         Reviewed by Lucas Forschler.
977
978         Do not display the steps which are un-needed for end-user. This information is still avaiable
979         if the user click on the bubble and look at the Buildbot build.
980         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
981         (StatusBubble._steps_messages):
982         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
983
984 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
985
986         [ews-build] Use https for sending data to ews-app
987         https://bugs.webkit.org/show_bug.cgi?id=196492
988
989         Reviewed by Lucas Forschler.
990
991         * BuildSlaveSupport/ews-build/events.py:
992
993 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
994
995         Remove support for -apple-trailing-word
996         https://bugs.webkit.org/show_bug.cgi?id=196525
997
998         Reviewed by Zalan Bujtas.
999
1000         This CSS property is nonstandard and not used.
1001
1002         * Scripts/webkitperl/FeatureList.pm:
1003         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1004
1005 2019-04-03  Youenn Fablet  <youenn@apple.com>
1006
1007         Add a test for DOMCache on multiple browsing in case of private browsing
1008         https://bugs.webkit.org/show_bug.cgi?id=196524
1009
1010         Reviewed by Alex Christensen.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1013         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1014
1015 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1016
1017         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1018         https://bugs.webkit.org/show_bug.cgi?id=196540
1019
1020         Reviewed by Aakash Jain.
1021
1022         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1023
1024 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1025
1026         Add plumbing for a compatibility mode preference in WebKit
1027         https://bugs.webkit.org/show_bug.cgi?id=196005
1028
1029         Reviewed by Tim Horton.
1030
1031         Add new API tests.
1032
1033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1034         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1035
1036 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1037
1038         [WPE][GTK] Update libsrtp dependency package for Debian
1039         https://bugs.webkit.org/show_bug.cgi?id=196528
1040
1041         Reviewed by Frédéric Wang.
1042
1043         * gtk/install-dependencies:
1044         * wpe/install-dependencies:
1045
1046 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1047
1048         [WK2] Add support for Window's beforeprint / afterprint events
1049         https://bugs.webkit.org/show_bug.cgi?id=196478
1050         <rdar://problem/49535124>
1051
1052         Unreviewed build fix for MSVC.
1053
1054         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1055
1056         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1057
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::printFrame): Use int and float literals.
1060
1061 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1062
1063         [ews-build] Reassign bots to queues
1064
1065         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1066
1067 2019-04-02  Chris Dumez  <cdumez@apple.com>
1068
1069         [WK2] Add support for Window's beforeprint / afterprint events
1070         https://bugs.webkit.org/show_bug.cgi?id=196478
1071
1072         Reviewed by Alex Christensen.
1073
1074         Add minimal implementation for printFrame in WebKitTestRunner.
1075
1076         * WebKitTestRunner/TestController.cpp:
1077         (WTR::printFrame):
1078         (WTR::TestController::createOtherPage):
1079         (WTR::TestController::createWebViewWithOptions):
1080
1081 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1082
1083         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1084         https://bugs.webkit.org/show_bug.cgi?id=196491
1085
1086         Reviewed by Lucas Forschler.
1087
1088         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1089
1090 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews-build] Configure buildbot try credentials in environment variables
1093         https://bugs.webkit.org/show_bug.cgi?id=196501
1094
1095         Reviewed by Lucas Forschler.
1096
1097         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1098         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1099         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1100
1101 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1104         https://bugs.webkit.org/show_bug.cgi?id=196496
1105         <rdar://problem/49521634>
1106
1107         Reviewed by Chris Dumez.
1108
1109         Add new API tests (see WebKit ChangeLog for more detail).
1110
1111         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1112         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1113         (TEST):
1114
1115 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1116
1117         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1118         <https://webkit.org/b/196499>
1119
1120         Reviewed by Alexey Proskuryakov.
1121
1122         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1123         ENABLE_ADDRESS_SANITIZER.
1124
1125 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1126
1127         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1128         https://bugs.webkit.org/show_bug.cgi?id=182757
1129
1130         Reviewed by Don Olmstead.
1131
1132         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1133         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1134
1135 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1136
1137         run-api-tests: Upload test results
1138         https://bugs.webkit.org/show_bug.cgi?id=196323
1139         <rdar://problem/49356714>
1140
1141         Reviewed by Lucas Forschler.
1142
1143         * Scripts/webkitpy/api_tests/manager.py:
1144         (Manager):
1145         (Manager.run): Upload results to a results database.
1146         * Scripts/webkitpy/api_tests/run_api_tests.py:
1147         (parse_args): Add upload arguments.
1148         * Scripts/webkitpy/port/base.py:
1149         (Port):
1150         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1151         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1152         with commits from any other associated repositories.
1153         * Scripts/webkitpy/port/device.py:
1154         (Device):
1155         (Device.build_version): Access build_versoin of underlying platform device.
1156         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1157         (IOSSimulatorTest):
1158         (IOSSimulatorTest.test_configuration_for_upload):
1159         * Scripts/webkitpy/port/device_port.py:
1160         (DevicePort):
1161         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1162         the same as the machine uploading results.
1163         * Scripts/webkitpy/port/mac.py:
1164         (MacPort):
1165         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1166         * Scripts/webkitpy/port/mac_unittest.py:
1167         (MacTest):
1168         (MacTest.test_configuration_for_upload):
1169         * Scripts/webkitpy/xcode/simulated_device.py:
1170         (SimulatedDeviceManager._create_device_with_runtime):
1171         (SimulatedDevice.__init__): Create simulated device with a build_version.
1172         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1173         (test_existing_simulator):
1174
1175 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1176
1177         Remove extra newline characters (Follow-up fix to r243707)
1178
1179         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1180
1181 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1182
1183         [ews-app] Use API_KEY to accept results data
1184         https://bugs.webkit.org/show_bug.cgi?id=196461
1185
1186         Reviewed by Dewei Zhu.
1187
1188         * BuildSlaveSupport/ews-app/ews/views/results.py:
1189         (Results.post): Validate EWS_API_KEY before accepting any data.
1190         * BuildSlaveSupport/ews-build/events.py:
1191         (Events.sendData): Send EWS_API_KEY if available along with event data.
1192
1193 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1194
1195         Unable to copy and paste a PDF from Notes into Mail compose body
1196         https://bugs.webkit.org/show_bug.cgi?id=196442
1197         <rdar://problem/48573098>
1198
1199         Reviewed by Tim Horton.
1200
1201         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1202         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1203         to be specified on the item providers.
1204
1205         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1206         (TestWebKitAPI::mapItemForTesting):
1207         (TestWebKitAPI::contactItemForTesting):
1208
1209 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1210
1211         Make UIWKDocumentContext rects per-character instead of per-word
1212         https://bugs.webkit.org/show_bug.cgi?id=196459
1213
1214         Reviewed by Wenson Hsieh.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1217         (TEST):
1218         Adjust test results due to switching to per-character rects.
1219
1220 2019-04-01  Chris Dumez  <cdumez@apple.com>
1221
1222         UIProcess crash when a prewarmed process is terminated
1223         https://bugs.webkit.org/show_bug.cgi?id=196451
1224         <rdar://problem/49245471>
1225
1226         Reviewed by Geoffrey Garen.
1227
1228         Add API test coverage.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1231         (TEST):
1232
1233 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1234
1235         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1236         https://bugs.webkit.org/show_bug.cgi?id=196449
1237
1238         Reviewed by Lucas Forschler.
1239
1240         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1241         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1242         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1243         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1244
1245 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1246
1247         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1248         https://bugs.webkit.org/show_bug.cgi?id=196444
1249
1250         Reviewed by Lucas Forschler.
1251
1252         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1253
1254 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1255
1256         Add SPI to canonicalize NSURLs with WTF::URL
1257         https://bugs.webkit.org/show_bug.cgi?id=196415
1258         <rdar://problem/44980271>
1259
1260         Reviewed by Darin Adler.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1264         (TestWebKitAPI::TEST):
1265
1266 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1267
1268         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1269         https://bugs.webkit.org/show_bug.cgi?id=196441
1270
1271         Reviewed by Carlos Garcia Campos.
1272
1273         Don't cache the wpe_view_backend object that might not exist yet at the
1274         time of EventSenderProxy constructor invocation, but instead retrieve
1275         that object whenever it's required for event dispatching. This should
1276         avoid crashes in this constructor now that it's invoked before any
1277         PlatformWindow has been set up (as changed in r243496).
1278
1279         * WebKitTestRunner/EventSenderProxy.h:
1280         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1281         (WTR::viewBackend):
1282         (WTR::EventSenderProxy::EventSenderProxy):
1283         (WTR::EventSenderProxy::mouseDown):
1284         (WTR::EventSenderProxy::mouseUp):
1285         (WTR::EventSenderProxy::mouseMoveTo):
1286         (WTR::EventSenderProxy::mouseScrollBy):
1287         (WTR::EventSenderProxy::keyDown):
1288         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1289
1290 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1291
1292         [Win][WebKit] MiniBrowser should support high DPI display
1293         https://bugs.webkit.org/show_bug.cgi?id=196391
1294
1295         Reviewed by Alex Christensen.
1296
1297         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1298         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1299         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1300         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1301
1302 2019-03-31  Sam Weinig  <weinig@apple.com>
1303
1304         Remove more i386 specific configurations
1305         https://bugs.webkit.org/show_bug.cgi?id=196430
1306
1307         Reviewed by Alexey Proskuryakov.
1308
1309         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1310         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1311
1312 2019-03-31  Andy Estes  <aestes@apple.com>
1313
1314         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1315         https://bugs.webkit.org/show_bug.cgi?id=196433
1316         <rdar://problem/49293305>
1317
1318         Reviewed by Tim Horton.
1319
1320         Enhanced API test coverage to include all navigation response policy decisions in both
1321         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1322
1323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1324         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1325         (TestWebKitAPI::TEST):
1326         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1327         (readFile):
1328         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1329         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1330         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1331         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1332         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1333         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1334         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1335         (-[QuickLookDelegate _downloadDidStart:]):
1336         (-[QuickLookDelegate _download:didReceiveResponse:]):
1337         (-[QuickLookDelegate _download:didReceiveData:]):
1338         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1339         (-[QuickLookDelegate _downloadDidFinish:]):
1340         (-[QuickLookDelegate _download:didFailWithError:]):
1341         (-[QuickLookDelegate _downloadDidCancel:]):
1342         (-[QuickLookDelegate verifyDownload]):
1343         (runTest):
1344         (runTestDecideBeforeLoading):
1345         (runTestDecideAfterLoading):
1346         (TEST):
1347         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1348         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1349         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1350         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1351         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1352         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1353         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1354         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1355         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1356         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1357         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1358         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1359         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1360         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1361
1362 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1363
1364         [CMake] add testdfg as target with build-jsc
1365         https://bugs.webkit.org/show_bug.cgi?id=196393
1366
1367         Reviewed by Saam Barati.
1368
1369         Added testdfg as one of the targets to build when
1370         using CMake.
1371
1372         * Scripts/build-jsc:
1373
1374 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1375
1376         Delete WebMetal implementation in favor of WebGPU
1377         https://bugs.webkit.org/show_bug.cgi?id=195418
1378
1379         Reviewed by Dean Jackson.
1380
1381         * DumpRenderTree/mac/DumpRenderTree.mm:
1382         (enableExperimentalFeatures):
1383         (resetWebPreferencesToConsistentValues):
1384         * Scripts/webkitperl/FeatureList.pm:
1385         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1388         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1389         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1390         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1391         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1392         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1393         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1395         (WTR::InjectedBundle::beginTesting):
1396         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1397         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1399
1400 2019-03-29  Chris Dumez  <cdumez@apple.com>
1401
1402         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1403         https://bugs.webkit.org/show_bug.cgi?id=196405
1404         <rdar://problem/49428130>
1405
1406         Reviewed by Wenson Hsieh.
1407
1408         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1409         the popover presentation methods to be no-ops. Use this in the new test added in
1410         r243523 so that we do not swizzle those methods for all tests. This is needed because
1411         those WatchOS tests rely on the popover getting presented and interactive.
1412
1413         * WebKitTestRunner/TestController.cpp:
1414         (WTR::updateTestOptionsFromTestHeader):
1415         * WebKitTestRunner/TestController.h:
1416         * WebKitTestRunner/TestOptions.h:
1417         (WTR::TestOptions::hasSameInitializationOptions const):
1418         * WebKitTestRunner/ios/TestControllerIOS.mm:
1419         (WTR::TestController::platformInitialize):
1420         (WTR::TestController::platformResetStateToConsistentValues):
1421
1422 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1423
1424         [Curl] Add Server Trust Evaluation Support.
1425         https://bugs.webkit.org/show_bug.cgi?id=191646
1426
1427         Reviewed by Fujii Hironori.
1428
1429         Implemented MiniBrowser UI for asking if user trusts the server.
1430
1431         * MiniBrowser/win/Common.cpp:
1432         (askServerTrustEvaluation):
1433         (replaceString):
1434         * MiniBrowser/win/Common.h:
1435         * MiniBrowser/win/MiniBrowserLib.rc:
1436         * MiniBrowser/win/MiniBrowserLibResource.h:
1437         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1438         (createPEMString):
1439         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1440         (WebKitBrowserWindow::canTrustServerCertificate):
1441         * MiniBrowser/win/WebKitBrowserWindow.h:
1442
1443 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1444
1445         Implement ResizeObserver.
1446         https://bugs.webkit.org/show_bug.cgi?id=157743
1447
1448         Reviewed by Simon Fraser.
1449
1450         Support resizeObserverEnabled webPreferences.
1451
1452         * DumpRenderTree/TestOptions.cpp:
1453         (TestOptions::TestOptions):
1454         * DumpRenderTree/TestOptions.h:
1455         * DumpRenderTree/mac/DumpRenderTree.mm:
1456         (setWebPreferencesForTestOptions):
1457         * DumpRenderTree/win/DumpRenderTree.cpp:
1458         (enableExperimentalFeatures):
1459         * Scripts/webkitperl/FeatureList.pm:
1460         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1461
1462 2019-03-28  John Wilander  <wilander@apple.com>
1463
1464         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1465         https://bugs.webkit.org/show_bug.cgi?id=196281
1466         <rdar://problem/48938748>
1467
1468         Reviewed by Alex Christensen.
1469
1470         This patch adds the function isStatisticsHasLocalStorage() to the
1471         TestRunner. With it, the page can query the WebsiteDataStore in the
1472         UI process to make sure that it sees LocalStorage.
1473
1474         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1475         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1476         (WTR::TestRunner::isStatisticsHasLocalStorage):
1477         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1478         * WebKitTestRunner/TestController.cpp:
1479         (WTR::TestController::isStatisticsHasLocalStorage):
1480         * WebKitTestRunner/TestController.h:
1481         * WebKitTestRunner/TestInvocation.cpp:
1482         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1483
1484 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1485
1486         API::Data::createWithoutCopying should do a null check before calling CFRelease
1487         https://bugs.webkit.org/show_bug.cgi?id=196276
1488         <rdar://problem/48059859>
1489
1490         Reviewed by Alex Christensen.
1491
1492         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1493
1494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1495         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1496         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1497         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1498         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1499         (TestWebKitAPI::TEST):
1500
1501 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1502
1503         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1504         https://bugs.webkit.org/show_bug.cgi?id=186276
1505
1506         Reviewed by Carlos Garcia Campos.
1507
1508         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1509         (webViewLoadChanged):
1510         (testWebResourceGetDataError):
1511         (testWebResourceGetDataEmpty):
1512         (beforeAll):
1513         (webViewloadChanged): Deleted.
1514
1515 2019-03-27  Andy Estes  <aestes@apple.com>
1516
1517         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1518         https://bugs.webkit.org/show_bug.cgi?id=196317
1519
1520         Reviewed by Dan Bernstein.
1521
1522         package-root copies built products into a staging directory using ditto(1), which does not
1523         follow symbolic links as it traverses a directory. Now that the files in
1524         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1525         itself, these become broken links when ditto'd into the staging directory.
1526
1527         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1528
1529         * Scripts/package-root:
1530
1531 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1532
1533         [ews-app] Update display text of Submit for ews analysis
1534         https://bugs.webkit.org/show_bug.cgi?id=196309
1535
1536         Reviewed by Dewei Zhu.
1537
1538         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1539
1540 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1541
1542         run-webkit-tests should check for leaks in WebKit processes
1543         <https://webkit.org/b/193772>
1544         <rdar://problem/46526680>
1545
1546         Reviewed by Ryosuke Niwa.
1547
1548         This works by doing the following:
1549         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1550           The list of child processes are returned one per line:
1551           process.name: pid
1552         - Run the "#LIST CHILD PROCESSES" command just before the
1553           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1554           processes on the ServerProcess object.
1555         - When the `--leaks` switch is handled, run check_for_leaks() on
1556           each child process after the main test harness.
1557
1558         * DumpRenderTree/mac/DumpRenderTree.mm:
1559         (handleControlCommand):
1560         - Use strncmp() instead of strcmp().
1561         - Add support for handling "#LIST CHILD PROCESSES" command.
1562
1563         * Scripts/webkitpy/port/base.py:
1564         (Port.check_for_leaks):
1565         * Scripts/webkitpy/port/darwin.py:
1566         (DarwinPort.check_for_leaks):
1567         - Rename redundant 'process_pid' argument to 'process_id'.
1568
1569         * Scripts/webkitpy/port/driver.py:
1570         (Driver.do_post_tests_work):
1571         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1572           longer the only command this sends to WebKitTestRunner.
1573         - If the `--leaks` switch is present, send the
1574           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1575           result using Port.set_webkit_processes().
1576         (Driver._parse_child_processes_output):
1577         - Add helper method to parse list of child process names and
1578           process IDs returned from WebKitTestRunner.
1579
1580         * Scripts/webkitpy/port/ios_device.py:
1581         (IOSDevicePort.check_for_leaks):
1582         - Rename redundant 'process_pid' argument to 'process_id'.
1583
1584         * Scripts/webkitpy/port/leakdetector.py:
1585         (LeakDetector._parse_leaks_output):
1586         - Return early if there is no leaks_output.
1587         (LeakDetector.check_for_leaks):
1588         - Rename redundant 'process_pid' argument to 'process_id'.
1589
1590         * Scripts/webkitpy/port/server_process.py:
1591         (ServerProcess.__init__):
1592         (ServerProcess.child_processes):
1593         (ServerProcess.set_child_processes):
1594         - Add instance variable to Port to store list of child process
1595           names and process IDs returned from WebKitTestRunner.
1596         (ServerProcess._start):
1597         - Clear self._child_processes.
1598         (ServerProcess.stop):
1599         - If self._child_processes is set, call
1600           self._port.check_for_leaks() for each child process.
1601
1602         * Scripts/webkitpy/port/server_process_unittest.py:
1603         (TrivialMockPort.check_for_leaks):
1604         - Rename redundant 'process_pid' argument to 'process_id'.
1605
1606         * Scripts/webkitpy/port/simulator_process.py:
1607         (SimulatorProcess.stop):
1608         - If self._child_processes is set, call
1609           self._port.check_for_leaks() for each child process.
1610
1611         * Scripts/webkitpy/port/watch_device.py:
1612         (WatchDevicePort.check_for_leaks):
1613         - Rename redundant 'process_pid' argument to 'process_id'.
1614
1615         * WebKitTestRunner/TestController.cpp:
1616         (WTR::TestController::dumpResponse):
1617         - Extract method from findAndDumpWorldLeaks() so that it may be
1618           reused by findAndDumpWebKitProcessIdentifiers().
1619         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1620         - Add method to output process name and process ID of both the
1621           WebContent and Networking processes.
1622         (WTR::TestController::findAndDumpWorldLeaks):
1623         - Fix missing newline in output when there were no abandoned
1624           documents.
1625         - Call dumpResponse() for extracted code.
1626         (WTR::TestController::handleControlCommand):
1627         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1628         - Use strncmp() instead of strcmp().
1629         - Call findAndDumpWebKitProcessIdentifiers() when
1630           "#LIST CHILD PROCESSES" command is sent.
1631         * WebKitTestRunner/TestController.h:
1632         (WTR::TestController::dumpResponse):
1633         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1634         - Declare methods.
1635
1636 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1637
1638         Unreviewed. Add GLib API test cases after r243434.
1639
1640         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1641         (testWebViewActiveURI):
1642         (serverCallback):
1643         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1644         (sendRequestCallback):
1645
1646 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1647
1648         Geolocation request not complete when watch request was started in a different web process
1649         https://bugs.webkit.org/show_bug.cgi?id=195996
1650
1651         Reviewed by Alex Christensen.
1652
1653         Add a test case.
1654
1655         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1656         (TestWebKitAPI::runJavaScriptAlert):
1657         (TestWebKitAPI::TEST):
1658
1659 2019-03-26  Keith Rollin  <krollin@apple.com>
1660
1661         Update the way generate-xcfilelists returns strings from functions
1662         https://bugs.webkit.org/show_bug.cgi?id=195975
1663         <rdar://problem/49040807>
1664
1665         Reviewed by Dean Jackson.
1666
1667         There are places where generate-xcfilelists executes assignments with
1668         statements like:
1669
1670             FOO=$(some_function)
1671
1672         where "some_function" return a string by echoing it. E.g.
1673
1674             some_function()
1675             {
1676                 echo "Hello, World"
1677             }
1678
1679         This is a common idiom, but it has a problem if "some_function" needs
1680         to call "exit" in an attempt to halt the entire script right then and
1681         there. Since "some_function" is called inside of $(), it's being
1682         executed in a sub-shell. Calling exit in that sub-shell simply exits
1683         that shell; it doesn't not exit the outer shell in which the main part
1684         of the script is still running. As such, the main script keeps
1685         executing when the intent was for the script to halt.
1686
1687         The solution to this is to use a different idiom for returning
1688         strings. The one we now is to pass in the name of the variable to
1689         receive the string result:
1690
1691             some_function()
1692             {
1693                 variable_name=$1
1694                 eval $variable_name ="Hello, World"
1695             }
1696
1697         The call site now looks like
1698
1699             some_function FOO
1700
1701         Because there's no invocation of a sub-shell, some_function can now
1702         call "exit" if it wants to, and the entire script will exit at that
1703         point.
1704
1705         * Scripts/generate-xcfilelists:
1706
1707 2019-03-26  Chris Dumez  <cdumez@apple.com>
1708
1709         Add basic layout test coverage for File Picker on iOS
1710         https://bugs.webkit.org/show_bug.cgi?id=196265
1711
1712         Reviewed by Wenson Hsieh.
1713
1714         Add layout test infrastructure to test the file picker on iOS.
1715
1716         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1717         (WTR::UIScriptController::dismissFilePicker):
1718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1719         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1720         (WTR::UIScriptController::dismissFilePicker):
1721         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1722         * WebKitTestRunner/TestController.cpp:
1723         (WTR::TestController::createWebViewWithOptions):
1724         (WTR::updateTestOptionsFromTestHeader):
1725         * WebKitTestRunner/TestOptions.h:
1726         (WTR::TestOptions::hasSameInitializationOptions const):
1727         * WebKitTestRunner/ios/TestControllerIOS.mm:
1728         (overridePresentViewController):
1729         (WTR::TestController::platformInitialize):
1730         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1731         (WTR::UIScriptController::dismissFilePicker):
1732
1733 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1734
1735         Implement async paste method on UIWKInteractionViewProtocol
1736         https://bugs.webkit.org/show_bug.cgi?id=196267
1737         <rdar://problem/49236346>
1738
1739         Reviewed by Tim Horton.
1740
1741         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1742         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1743         are now a part of all iOS 12 internal SDKs.
1744
1745         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1746
1747         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1748         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1749
1750         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1751         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1752         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1753         * TestWebKitAPI/ios/UIKitSPI.h:
1754
1755 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1756
1757         [ews-build] Use PostgreSQL for ews.webkit.org database
1758         https://bugs.webkit.org/show_bug.cgi?id=196270
1759
1760         Reviewed by Lucas Forschler.
1761
1762         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1763
1764 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1765
1766         [ews] Reset simctl states on reboot
1767         https://bugs.webkit.org/show_bug.cgi?id=196260
1768
1769         Rubber-stamped by Aakash Jain.
1770
1771         * EWSTools/start-queue-mac.sh:
1772
1773 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1774
1775         [ews-build] Use PostgreSQL for ews-build database
1776         https://bugs.webkit.org/show_bug.cgi?id=196229
1777
1778         Reviewed by Lucas Forschler.
1779
1780         * BuildSlaveSupport/ews-build/master.cfg:
1781
1782 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1783
1784         [ews-build] Get master_hostname dynamically in master.cfg
1785         https://bugs.webkit.org/show_bug.cgi?id=196255
1786
1787         Reviewed by Lucas Forschler.
1788
1789         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1790         send events data in test mode.
1791
1792 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1793
1794         [ews-app] Set db_constraint to False for Foreign Keys
1795         https://bugs.webkit.org/show_bug.cgi?id=196252
1796
1797         Reviewed by Lucas Forschler.
1798
1799         * BuildSlaveSupport/ews-app/ews/models/build.py:
1800         * BuildSlaveSupport/ews-app/ews/models/step.py:
1801
1802 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1803
1804         [ews-build] is_test_mode_enabled should default to True
1805         https://bugs.webkit.org/show_bug.cgi?id=196248
1806
1807         Reviewed by Lucas Forschler.
1808
1809         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1810
1811 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1812
1813         [ews-app] Add webkitperl to ENABLED_QUEUES
1814         https://bugs.webkit.org/show_bug.cgi?id=196253
1815
1816         Reviewed by Lucas Forschler.
1817
1818         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1819
1820 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1821
1822         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1823         https://bugs.webkit.org/show_bug.cgi?id=196211
1824         rdar://problem/49110552
1825
1826         Reviewed by Tim Horton.
1827
1828         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1829         Make sure that EventSenderProxy always exists when running tests. We used to create
1830         it when resetting before the first test, which is a bit too late.
1831
1832         * WebKitTestRunner/TestController.h:
1833         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1834         (WTR::TestController::platformCreateWebView):
1835         (WTR::TestController::platformCreateOtherPage):
1836         (WTR::TestController::finishCreatingPlatformWebView):
1837         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1838         (WTR::PlatformWebView::PlatformWebView):
1839         Moved some code that made NSWindow use NSEvent during web view creation. We may
1840         need to move more if some other case us found, but this is enough for now.
1841
1842 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1843
1844         Unreviewed. Fix typo in GLib geolocation API after r243285.
1845
1846         gelocation -> geolocation.
1847
1848         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1849         (testGeolocationManagerWatchPosition):
1850
1851 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1852
1853         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1854         https://bugs.webkit.org/show_bug.cgi?id=196213
1855
1856         Reviewed by Geoff Garen.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1860         (credentialWithIdentityAndKeychainPath):
1861         (-[ChallengeDelegate webView:didFinishNavigation:]):
1862         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1863         (TestWebKitAPI::TEST):
1864
1865 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1866
1867         Expected shouldn't assume its contained types are copyable
1868         https://bugs.webkit.org/show_bug.cgi?id=195986
1869
1870         Reviewed by JF Bastien.
1871
1872         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1873         (TestWebKitAPI::NonCopyable::operator== const):
1874         (TestWebKitAPI::NonCopyable::operator!= const):
1875         (TestWebKitAPI::TEST):
1876
1877 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1878
1879         Remove some now-unnecessary dynamic class lookup
1880         https://bugs.webkit.org/show_bug.cgi?id=196237
1881
1882         Reviewed by Simon Fraser.
1883
1884         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1885         (makeRequest):
1886         (TEST):
1887
1888 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1889
1890         Unreviewed, rolling out r243450.
1891
1892         AppleWin and WinCairo port builds get broken.
1893
1894         Reverted changeset:
1895
1896         "Add test for fix of #196095"
1897         https://bugs.webkit.org/show_bug.cgi?id=196097
1898         https://trac.webkit.org/changeset/243450
1899
1900 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1901
1902         Unreviewed, rolling out r243465.
1903         https://bugs.webkit.org/show_bug.cgi?id=196226
1904
1905         the test doesn't build (Requested by thorton on #webkit).
1906
1907         Reverted changeset:
1908
1909         "Do not terminate the NetworkProcess if a third party
1910         application sends a NSCredential with a SecIdentityRef"
1911         https://bugs.webkit.org/show_bug.cgi?id=196213
1912         https://trac.webkit.org/changeset/243465
1913
1914 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1915
1916         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1917         https://bugs.webkit.org/show_bug.cgi?id=196213
1918
1919         Reviewed by Geoff Garen.
1920
1921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1922         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1923         (credentialWithIdentityAndKeychainPath):
1924         (-[ChallengeDelegate webView:didFinishNavigation:]):
1925         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1926         (TestWebKitAPI::TEST):
1927
1928 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1929
1930         [ews-build] Gracefully handle missing patch_id in events
1931         https://bugs.webkit.org/show_bug.cgi?id=196216
1932
1933         Reviewed by Lucas Forschler.
1934
1935         * BuildSlaveSupport/ews-build/events.py:
1936
1937 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-build] use lz4 compression for improving buildbot performance
1940         https://bugs.webkit.org/show_bug.cgi?id=196155
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * BuildSlaveSupport/ews-build/master.cfg:
1945
1946 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1947
1948         Pull some API testing helper methods out of TestWKWebView
1949         https://bugs.webkit.org/show_bug.cgi?id=196212
1950
1951         Reviewed by Tim Horton.
1952
1953         Refactor some more API testing utility methods, so that they can be used in
1954         tests that do not use TestWKWebView.
1955
1956         * TestWebKitAPI/cocoa/TestWKWebView.h:
1957         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1958         (-[WKWebView loadTestPageNamed:]):
1959         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1960         (-[WKWebView synchronouslyLoadHTMLString:]):
1961         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1962         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1963         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1964         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1965         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1966
1967 2019-03-25  Jer Noble  <jer.noble@apple.com>
1968
1969         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1970         https://bugs.webkit.org/show_bug.cgi?id=196097
1971
1972         Reviewed by Eric Carlson.
1973
1974         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1975
1976         * DumpRenderTree/mac/DumpRenderTree.mm:
1977         (resetWebPreferencesToConsistentValues):
1978         * WebKitTestRunner/TestController.cpp:
1979         (WTR::TestController::resetPreferencesToConsistentValues):
1980
1981 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1982
1983         Pull IPadUserInterfaceSwizzler out into a separate header file
1984         https://bugs.webkit.org/show_bug.cgi?id=196193
1985
1986         Reviewed by Anders Carlsson.
1987
1988         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1989         be used in other API tests.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1993         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1994         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1995         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1996         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1997         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1998
1999 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2000
2001         Remove NavigatorContentUtils in WebCore/Modules
2002         https://bugs.webkit.org/show_bug.cgi?id=196070
2003
2004         Reviewed by Alex Christensen.
2005
2006         NavigatorContentUtils was to support the custom scheme spec [1].
2007         However, in WebKit side, no port has supported the feature in
2008         WebKit layer after EFL port was removed. So there has been the
2009         only IDL implementation of the NavigatorContentUtils in WebCore.
2010         So we don't need to keep the implementation in WebCore anymore.
2011
2012         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2013
2014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2015
2016 2019-03-24  Andy Estes  <aestes@apple.com>
2017
2018         [watchOS] Remove unused Proximity Networking code
2019         https://bugs.webkit.org/show_bug.cgi?id=196188
2020
2021         Reviewed by Tim Horton.
2022
2023         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2024         (TEST):
2025
2026 2019-03-23  Keith Miller  <keith_miller@apple.com>
2027
2028         Refactor clz/ctz and fix getLSBSet.
2029         https://bugs.webkit.org/show_bug.cgi?id=196162
2030
2031         Reviewed by Saam Barati.
2032
2033         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2034
2035         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2036         (TestWebKitAPI::TEST):
2037
2038 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2039
2040         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2041         https://bugs.webkit.org/show_bug.cgi?id=196143
2042
2043         Reviewed by Michael Catanzaro.
2044
2045         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2046         directories.
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py:
2049         (check_identifier_name_in_declaration):
2050         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2051         (WebKitStyleTest.test_names):
2052
2053 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2054
2055         [Flatpak] Manifest expanding fails for qt WPE extension
2056         https://bugs.webkit.org/show_bug.cgi?id=196148
2057
2058         Reviewed by Alex Christensen.
2059
2060         * flatpak/flatpakutils.py:
2061         (expand_submodules_recurse): The last recurse manifest expand
2062         iteration might lead to a single module so take it into account
2063         and don't try to recurse further.
2064
2065 2019-03-22  Chris Dumez  <cdumez@apple.com>
2066
2067         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2068         https://bugs.webkit.org/show_bug.cgi?id=195348
2069         <rdar://problem/48622090>
2070
2071         Reviewed by Alex Christensen.
2072
2073         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2074         to NO when test.options().shouldIgnoreMetaViewport is false.
2075
2076         * WebKitTestRunner/ios/TestControllerIOS.mm:
2077         (WTR::TestController::platformConfigureViewForTest):
2078
2079 2019-03-22  Chris Dumez  <cdumez@apple.com>
2080
2081         Prewarmed processes should be usable with any website data store
2082         https://bugs.webkit.org/show_bug.cgi?id=196104
2083
2084         Reviewed by Alex Christensen.
2085
2086         Add API test coverage.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2089         (runInitialWarmedProcessUsedTest):
2090         (TEST):
2091
2092 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2093
2094         Back out local changes to Alex's Subversion working directory
2095
2096         They were accidentally committed.
2097
2098         * Scripts/webkitpy/common/system/abstractexecutive.py:
2099         (AbstractExecutive.wait_newest):
2100         * Scripts/webkitpy/common/system/executive.py:
2101         (Executive.running_pids):
2102         * Scripts/webkitpy/common/system/executive_mock.py:
2103         (MockExecutive.running_pids):
2104         * Scripts/webkitpy/common/system/executive_unittest.py:
2105         (ExecutiveTest.serial_test_running_pids):
2106         * Scripts/webkitpy/port/darwin.py:
2107         (DarwinPort.check_for_leaks):
2108         * Scripts/webkitpy/port/leakdetector.py:
2109         (LeakDetector.check_for_leaks):
2110         - This was the hack attached to Bug 193772.
2111
2112         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2113         (+[WebKitTestRunnerEvent mouseLocation]):
2114         - This works around a crash on an internal build.
2115
2116 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2117
2118         Fix the build after r243354
2119         https://bugs.webkit.org/show_bug.cgi?id=196138
2120         <rdar://problem/49145951>
2121
2122         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2123         (TEST):
2124         * TestWebKitAPI/ios/UIKitSPI.h:
2125
2126 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2127
2128         Adopt UIWKDocumentContext
2129         https://bugs.webkit.org/show_bug.cgi?id=196040
2130         <rdar://problem/48642440>
2131
2132         Reviewed by Ryosuke Niwa.
2133
2134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2135         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2136         (makeRequest):
2137         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2138         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2139         (applyStyle):
2140         (TEST):
2141         Add tests for UIWKDocumentContext.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2144         (TEST):
2145         (recursiveFindWKContentView): Deleted.
2146         * TestWebKitAPI/cocoa/TestWKWebView.h:
2147         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2148         (recursiveFindWKContentView):
2149         (-[TestWKWebView wkContentView]):
2150         * TestWebKitAPI/ios/UIKitSPI.h:
2151         Share the WKContentView finding code between tests.
2152
2153 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2154
2155         [iOS WK2] Turn on async overflow scrolling by default
2156         https://bugs.webkit.org/show_bug.cgi?id=196011
2157         rdar://problem/48453859
2158
2159         Reviewed by Antti Koivisto.
2160         
2161         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2162         since so many basic layout tests have different results when compositing is triggered for
2163         overflow.
2164         
2165         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2166
2167         * WebKitTestRunner/TestController.cpp:
2168         (WTR::TestController::resetPreferencesToConsistentValues):
2169
2170 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2171
2172         [ews-build] Retry API test in case of failures
2173         https://bugs.webkit.org/show_bug.cgi?id=196004
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-build/steps.py:
2178         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2179         (CompileWebKitToT.doStepIf): Ditto.
2180         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2181         (ReRunAPITests): Re-run API tests.
2182         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2183         (RunAPITestsWithoutPatch): Run API tests without patch.
2184         (RunAPITestsWithoutPatch.doStepIf):
2185         (RunAPITestsWithoutPatch.hideStepIf):
2186         (RunAPITestsWithoutPatch.evaluateCommand):
2187         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2188         (AnalyzeAPITestsResults.start):
2189         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2190         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2191         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2192         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2193
2194 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2195
2196         [ews-build] Update queues configurations
2197         https://bugs.webkit.org/show_bug.cgi?id=196074
2198
2199         Reviewed by Dewei Zhu.
2200
2201         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2202         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2203
2204 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2205
2206         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2207         https://bugs.webkit.org/show_bug.cgi?id=195680
2208         <rdar://problem/48903534>
2209
2210         Unreviewed infrastructure fix.
2211
2212         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2213         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2214
2215 2019-03-21  Andy Estes  <aestes@apple.com>
2216
2217         [iOS] Apple Pay should be available in documents with no user agent scripts
2218         https://bugs.webkit.org/show_bug.cgi?id=196061
2219         <rdar://problem/48649391>
2220
2221         Reviewed by Brady Eidson.
2222
2223         Added API tests and related infrastructure.
2224
2225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2226         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2227         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2228         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2229         (TestWebKitAPI::TEST):
2230         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2231         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2232         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2233         * TestWebKitAPI/cocoa/TestProtocol.mm:
2234         (-[TestProtocol startLoading]):
2235         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2236         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2237         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2238         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2239
2240 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2241
2242         REGRESSSION (r243297): webkitpy tests broken
2243         https://bugs.webkit.org/show_bug.cgi?id=196108
2244
2245         Reviewed by Aakash Jain.
2246
2247         r243297 updated contributors.json, which broke a few unit tests.
2248
2249         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2250         (IRCCommandTest.test_whois):
2251         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2252
2253 2019-03-21  Chris Dumez  <cdumez@apple.com>
2254
2255         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2256         https://bugs.webkit.org/show_bug.cgi?id=196041
2257         <rdar://problem/49083230>
2258
2259         Reviewed by Alex Christensen.
2260
2261         Add API test coverage.
2262
2263         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2264         (TEST):
2265
2266 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2267
2268         Add SPI to inform applications of WKContentRuleList actions
2269         https://bugs.webkit.org/show_bug.cgi?id=195965
2270         <rdar://problem/42664365>
2271
2272         Reviewed by Geoff Garen.
2273
2274         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2275         (TestWebKitAPI::allActionsForResourceLoad):
2276         (TestWebKitAPI::testRequest):
2277         (TestWebKitAPI::TEST_F):
2278         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2279         (Notification::description):
2280         (Notification::operator== const):
2281         (toVector):
2282         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2283         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2284         (makeContentRuleList):
2285         (TEST):
2286         (makeWarnContentRuleList): Deleted.
2287
2288 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2289
2290         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2291         https://bugs.webkit.org/show_bug.cgi?id=196088
2292
2293         Reviewed by Brian Burg.
2294
2295         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2296         Support checks when only one platform is specified. Also deprecate macosx() and
2297         force the use of macos() instead.
2298
2299         * Scripts/webkitpy/style/checkers/cpp.py:
2300         (check_min_versions_of_wk_api_available):
2301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2302         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2303
2304 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2305
2306         Update status inactive committers' status to 'contributor'.
2307
2308         * Scripts/webkitpy/common/config/contributors.json:
2309
2310 2019-03-21  Xan Lopez  <xan@igalia.com>
2311
2312         [JSC][x86] Drop support for x87 floating point
2313         https://bugs.webkit.org/show_bug.cgi?id=194853
2314
2315         Reviewed by Don Olmstead.
2316
2317         Force SSE2 on x86/32bit builds.
2318
2319         * Scripts/webkitdirs.pm:
2320         (generateBuildSystemFromCMakeProject):
2321
2322 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2325         https://bugs.webkit.org/show_bug.cgi?id=196073
2326
2327         Reviewed by Michael Catanzaro.
2328
2329         Add test cases to check functions and constructors with no arguments but receiving user data.
2330
2331         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2332         (checkUserData):
2333         (testJSCFunction):
2334         (fooCreateWithUserData):
2335         (testJSCClass):
2336
2337 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2340
2341         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2342
2343         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2344
2345 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         [GTK][WPE] Add API to provide geolocation information
2348         https://bugs.webkit.org/show_bug.cgi?id=195940
2349
2350         Reviewed by Michael Catanzaro.
2351
2352         Add a new test to check the new API.
2353
2354         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2355         (testGeolocationManagerCurrentPosition):
2356         (testGeolocationManagerWatchPosition):
2357         (beforeAll):
2358         (afterAll):
2359         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2360         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2361         (beforeAll): Ditto.
2362         * TestWebKitAPI/glib/CMakeLists.txt:
2363
2364 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2365
2366         [GLib] Returning G_TYPE_OBJECT from a method does not work
2367         https://bugs.webkit.org/show_bug.cgi?id=195574
2368
2369         Reviewed by Michael Catanzaro.
2370
2371         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2372
2373         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2374         (getGFile):
2375         (getParent):
2376         (createGString):
2377         (getGString):
2378         (getGStringCopyWillRaise):
2379         (getGStringCopy):
2380         (getGStringStr):
2381         (getGStringLen):
2382         (freeGString):
2383         (testJSCClass):
2384
2385 2019-03-20  Saam Barati  <sbarati@apple.com>
2386
2387         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2388         https://bugs.webkit.org/show_bug.cgi?id=195721
2389
2390         Reviewed by Filip Pizlo.
2391
2392         * Scripts/run-javascriptcore-tests:
2393
2394 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2395
2396         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2397         https://bugs.webkit.org/show_bug.cgi?id=196049
2398
2399         Reviewed by Tim Horton.
2400
2401         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2402         overflow scrolling in general, so rename it.
2403
2404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2405
2406 2019-03-20  Daniel Bates  <dabates@apple.com>
2407
2408         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2409         https://bugs.webkit.org/show_bug.cgi?id=196031
2410         <rdar://problem/49078172>
2411
2412         Reviewed by Tim Horton.
2413
2414         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2415         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2416         same code path used when the Done button is pressed to dismiss the <select> picker.
2417
2418         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2419         (TestWebKitAPI::TEST):
2420
2421 2019-03-20  Chris Dumez  <cdumez@apple.com>
2422
2423         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2424         https://bugs.webkit.org/show_bug.cgi?id=196029
2425         <rdar://problem/48954651>
2426
2427         Reviewed by Tim Horton.
2428
2429         Add API test coverage.
2430
2431         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2432
2433 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2434
2435         [ews-build] Improve failure summary string for ApplyPatch step
2436         https://bugs.webkit.org/show_bug.cgi?id=195995
2437
2438         Reviewed by Alexey Proskuryakov.
2439
2440         * BuildSlaveSupport/ews-build/steps.py:
2441         (ApplyPatch.getResultSummary): Override getResultSummary.
2442
2443 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2444
2445         AX: Implement support for new meter ARIA role
2446         https://bugs.webkit.org/show_bug.cgi?id=195966
2447
2448         Reviewed by Chris Fleizach.
2449
2450         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2451         to AXLevelIndicator.
2452
2453         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2454
2455 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2456
2457         [WebAuthN] Implement FIDO AppID extension
2458         https://bugs.webkit.org/show_bug.cgi?id=143491
2459         <rdar://problem/48298273>
2460
2461         Reviewed by Brent Fulgham.
2462
2463         Add a test that covers the new flag of convertToU2fSignCommand.
2464
2465         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2468         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2469         (TestWebKitAPI::TEST):
2470
2471 2019-03-19  Keith Rollin  <krollin@apple.com>
2472
2473         Add support for more platforms to generate-xcfilelists
2474         https://bugs.webkit.org/show_bug.cgi?id=195977
2475
2476         Reviewed by Alexey Proskuryakov.
2477
2478         generate-xcfilelists incorrectly complains when involved with building
2479         WebKit for iphonesimulator:
2480
2481             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2482             …
2483             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2484
2485         Address this by teaching generate-xcfilelists about more platforms.
2486
2487         * Scripts/generate-xcfilelists:
2488
2489 2019-03-19  John Wilander  <wilander@apple.com>
2490
2491         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2492         https://bugs.webkit.org/show_bug.cgi?id=195923
2493         <rdar://problem/49001272>
2494
2495         Reviewed by Alex Christensen.
2496
2497         This patch does the following to the TestRunner:
2498         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2499         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2500         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2501
2502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2503         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2504         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2505         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2506         * WebKitTestRunner/TestController.cpp:
2507         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2508         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2509         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2510         * WebKitTestRunner/TestController.h:
2511         * WebKitTestRunner/TestInvocation.cpp:
2512         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2513
2514 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2515
2516         [CMake] Support more clang and gcc sanitizers
2517         https://bugs.webkit.org/show_bug.cgi?id=195956
2518
2519         Reviewed by Michael Catanzaro.
2520
2521         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2522
2523 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2524
2525         [ews-build] Improve summary for PrintConfiguration step
2526         https://bugs.webkit.org/show_bug.cgi?id=195945
2527
2528         Reviewed by Lucas Forschler.
2529
2530         * BuildSlaveSupport/ews-build/steps.py:
2531         (PrintConfiguration.getResultSummary): Override getResultSummary.
2532
2533 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2534
2535         [ews-build] Improve summary for CheckOutSource step
2536         https://bugs.webkit.org/show_bug.cgi?id=195963
2537
2538         Reviewed by Lucas Forschler.
2539
2540         * BuildSlaveSupport/ews-build/steps.py:
2541         (CheckOutSource.getResultSummary):
2542
2543 2019-03-19  Daniel Bates  <dabates@apple.com>
2544
2545         [iOS] Focus not preserved when switching between tabs
2546         https://bugs.webkit.org/show_bug.cgi?id=195820
2547         <rdar://problem/43614450>
2548
2549         Reviewed by Brent Fulgham.
2550
2551         Add tests to ensure that we restore focus when resigning and becoming first responder.
2552
2553         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2554         (TestWebKitAPI::TEST):
2555
2556 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2557
2558         Make WTFLogChannelState and WTFLogLevel enum classes
2559         https://bugs.webkit.org/show_bug.cgi?id=195904
2560
2561         Reviewed by Eric Carlson.
2562
2563         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2564         (TestWebKitAPI::TEST_F):
2565
2566 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2567
2568         [GStreamer][EME] Backported mssdemux protection data crash fix
2569         https://bugs.webkit.org/show_bug.cgi?id=195918
2570
2571         Reviewed by Philippe Normand.
2572
2573         * gstreamer/jhbuild.modules:
2574         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2575
2576 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2577
2578         Unreviewed, rolling out r243132.
2579
2580         Broke GTK build
2581
2582         Reverted changeset:
2583
2584         "Make WTFLogChannelState and WTFLogLevel enum classes"
2585         https://bugs.webkit.org/show_bug.cgi?id=195904
2586         https://trac.webkit.org/changeset/243132
2587
2588 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2589
2590         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2591
2592         * Scripts/webkitdirs.pm:
2593         (builtDylibPathForName): Adjust the shared library name that's changed
2594         with the API version bump in r243073.
2595
2596 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2597
2598         Make WTFLogChannelState and WTFLogLevel enum classes
2599         https://bugs.webkit.org/show_bug.cgi?id=195904
2600
2601         Reviewed by Eric Carlson.
2602
2603         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2604         (TestWebKitAPI::TEST_F):
2605
2606 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2607
2608         Disable flaky test added in r2431100
2609         https://webkit.org/b/195785
2610
2611         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2612         (TestWebKitAPI::TEST):
2613         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2614
2615 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2616
2617         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2618         https://bugs.webkit.org/show_bug.cgi?id=195916
2619
2620         Reviewed by Tim Horton.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2623         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2624
2625 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2626
2627         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2628
2629         * Scripts/webkitpy/common/config/contributors.json:
2630
2631 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2632
2633         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2634         https://bugs.webkit.org/show_bug.cgi?id=195785
2635
2636         Reviewed by Geoffrey Garen.
2637
2638         * TestWebKitAPI/TCPServer.cpp: Added.
2639         (TestWebKitAPI::TCPServer::TCPServer):
2640         (TestWebKitAPI::TCPServer::~TCPServer):
2641         (TestWebKitAPI::TCPServer::socketBindListen):
2642         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2643         * TestWebKitAPI/TCPServer.h: Added.
2644         (TestWebKitAPI::TCPServer::port const):
2645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2646         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2647         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2648         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2649         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2650         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2651         (TestWebKitAPI::respondSlowly):
2652         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2653         (TestWebKitAPI::downloadAtRate):
2654         (TestWebKitAPI::TEST):
2655
2656 2019-03-18  Saam Barati  <sbarati@apple.com>
2657
2658         Add a plan file for JetStream 2
2659         https://bugs.webkit.org/show_bug.cgi?id=190734
2660
2661         Reviewed by Mark Lam.
2662
2663         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2664
2665 2019-03-18  Chris Dumez  <cdumez@apple.com>
2666
2667         Delay WebProcess launch until a load is triggered in a Web view
2668         https://bugs.webkit.org/show_bug.cgi?id=195758
2669         <rdar://problem/48126013>
2670
2671         Reviewed by Geoff Garen.
2672
2673         Add API test coverage. Also update some existing API tests to not expect
2674         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2675
2676         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2677         (TestWebKitAPI::TEST):
2678         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2679         (TestWebKitAPI::TEST):
2680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2681         (TEST):
2682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2683         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2684         (TEST):
2685         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2686         (TEST):
2687         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2688
2689 2019-03-18  Xan Lopez  <xan@igalia.com>
2690
2691         [CMake] Prevent potential warning when determining $architecture
2692         https://bugs.webkit.org/show_bug.cgi?id=195891
2693
2694         Reviewed by Michael Catanzaro.
2695
2696         It's possible for generateBuildSystemForCMakeProject to be called
2697         before determineArchitecture() is ever called. This will make the
2698         first eq check with $architecture to be bogus (and print a
2699         warning). Change that to an eq check with architecture(), which
2700         implicitly calls determineArchitecture() if needed, and change all
2701         the other similar cases in the method in the same way to prevent
2702         future bugs like this one.
2703
2704         * Scripts/webkitdirs.pm:
2705         (generateBuildSystemFromCMakeProject):
2706
2707 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2708
2709         [WPE] Tarballs generated with “make dist” cannot build documentation
2710         https://bugs.webkit.org/show_bug.cgi?id=195885
2711
2712         Reviewed by Carlos Garcia Campos.
2713
2714         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2715
2716 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2717
2718         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2719         https://bugs.webkit.org/show_bug.cgi?id=195883
2720
2721         Reviewed by Carlos Garcia Campos.
2722
2723         * gtkdoc/gtkdoc.py:
2724         (GTKDoc._run_command): When commands fail to run, include the full command line for
2725         the program invocation and the output it has generated on the standard error stream.
2726
2727 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2728
2729         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2730         https://bugs.webkit.org/show_bug.cgi?id=195786
2731
2732         Reviewed by Philippe Normand.
2733
2734         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2735         * wpe/jhbuild.modules: Ditto.
2736
2737 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2738
2739         [ews-build] Don't run clean builds on EWS builders
2740         https://bugs.webkit.org/show_bug.cgi?id=195851
2741
2742         Reviewed by Geoffrey Garen.
2743
2744         * BuildSlaveSupport/ews-build/factories.py:
2745
2746 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2747
2748         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2749         https://bugs.webkit.org/show_bug.cgi?id=195849
2750
2751         Reviewed by Chris Dumez.
2752
2753         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2754
2755         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2756         (runWebsiteDataStoreCustomPaths):
2757
2758 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2759
2760         webkitpy: Upload test results
2761         https://bugs.webkit.org/show_bug.cgi?id=195755
2762         <rdar://problem/48896182>
2763
2764         Reviewed by Aakash Jain.
2765
2766         Establish a new format for uploading results that is not tied to layout tests, apply
2767         that format to webkitpy tests.
2768
2769         * Scripts/webkitpy/common/checkout/scm/git.py:
2770         (Git.native_branch): Return what branch the current checkout is on.
2771         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2772         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2773         * Scripts/webkitpy/common/checkout/scm/svn.py:
2774         (SVN.native_branch): Ditto.
2775         * Scripts/webkitpy/common/system/platforminfo.py:
2776         (PlatformInfo.build_version): Return a build version for Mac.
2777         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2778         (MockPlatformInfo.__init__):
2779         (MockPlatformInfo.build_version):
2780         * Scripts/webkitpy/results: Added.
2781         * Scripts/webkitpy/results/__init__.py: Added.
2782         * Scripts/webkitpy/results/options.py: Added.
2783         (upload_options): OptParse list for upload options.
2784         * Scripts/webkitpy/results/upload.py: Added.
2785         (Upload): Class which enforces the upload format expected by the results server.
2786         (Upload.Expectations):
2787         (Upload.create_configuration):
2788         (Upload.create_commit):
2789         (Upload.create_details):
2790         (Upload.create_run_stats):
2791         (Upload.create_test_result):
2792         (Upload.__init__):
2793         (Upload.Encoder): Encode Upload object as json.
2794         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2795         * Scripts/webkitpy/results/upload_unittest.py: Added.
2796         * Scripts/webkitpy/test/main.py:
2797         (Tester._parse_args): Add upload arguments.
2798         (Tester._run_tests): Allow results to be uploaded.
2799         * Scripts/webkitpy/test/runner.py:
2800         (Runner.__init__): Record which tests were run, rather than just counting them.
2801         (Runner.handle):
2802         * Scripts/webkitpy/test/runner_unittest.py:
2803         (RunnerTest.test_run):
2804         * Scripts/webkitpy/thirdparty/__init__.py:
2805         (AutoinstallImportHook.find_module): Add requests auto-install.
2806         (AutoinstallImportHook._install_requests):
2807         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2808         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2809
2810 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2811
2812         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2813         https://bugs.webkit.org/show_bug.cgi?id=195810
2814
2815         Reviewed by Tim Horton.
2816
2817         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2818         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2819         ending certain layout tests.
2820
2821         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2822         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2823         (-[TestRunnerWKWebView dealloc]):
2824         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2825
2826         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2827         helper method when destroying the web view, and when resetting state between tests.
2828
2829         * WebKitTestRunner/ios/TestControllerIOS.mm:
2830         (WTR::TestController::platformResetStateToConsistentValues):
2831
2832         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2833
2834 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2835
2836         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2837         https://bugs.webkit.org/show_bug.cgi?id=190350
2838         <rdar://problem/45089503>
2839
2840         Reviewed by Geoffrey Garen.
2841
2842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2843         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2844         (TEST):
2845         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2846         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2847         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2848         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2849         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2850         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2851         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2852         (runTest):
2853         (createDirectories):
2854         (TEST):
2855         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2856         (TEST):
2857         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2858         (TEST):
2859
2860 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2861
2862         Add support to WebPage for getting the contents as an attributed string.
2863         https://bugs.webkit.org/show_bug.cgi?id=195636
2864         rdar://problem/45055697
2865
2866         Reviewed by Tim Horton.
2867
2868         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2869         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2870
2871 2019-03-15  Chris Dumez  <cdumez@apple.com>
2872
2873         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2874         https://bugs.webkit.org/show_bug.cgi?id=195747
2875
2876         Reviewed by Geoff Garen.
2877
2878         Add API test coverage.
2879
2880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2881
2882 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2883
2884         Unreviewed, rolling out r242952.
2885
2886         Causing API failures on iOS Simulator
2887
2888         Reverted changeset:
2889
2890         "[PSON] Make sure the WebProcessCache is leverage when
2891         relaunching a process after termination"
2892         https://bugs.webkit.org/show_bug.cgi?id=195747
2893         https://trac.webkit.org/changeset/242952
2894
2895 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2896
2897         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2898         https://bugs.webkit.org/show_bug.cgi?id=195740
2899
2900         Reviewed by Ross Kirsling.
2901
2902         window.open doesn't work for WebKitBrowserWindow because it is not
2903         implemented yet.
2904
2905         1. Implemented createNewPage callback of WKPageUIClient.
2906         2. Changed MainWindow to take a BrowserWindow factory function
2907           instead of BrowserWindowType to be flexible to create
2908           BrowserWindow with extra settings.
2909         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2910           because it is not relevant with MainWindow anymore.
2911
2912         * MiniBrowser/win/Common.cpp:
2913         (parseCommandLine):
2914         * MiniBrowser/win/Common.h:
2915         (CommandLineOptions::CommandLineOptions):
2916         * MiniBrowser/win/MainWindow.cpp:
2917         (MainWindow::MainWindow):
2918         (MainWindow::create):
2919         (MainWindow::init):
2920         (MainWindow::WndProc):
2921         * MiniBrowser/win/MainWindow.h:
2922         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2923         (PrintWebUIDelegate::createWebViewWithRequest):
2924         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2925         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2926         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2927         (WebKitBrowserWindow::updateProxySettings):
2928         (WebKitBrowserWindow::createNewPage):
2929         * MiniBrowser/win/WebKitBrowserWindow.h:
2930         * MiniBrowser/win/WinMain.cpp:
2931         (wWinMain):
2932
2933 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2934
2935         Make it possible to test scrolling tree layer manipulation more easily
2936         https://bugs.webkit.org/show_bug.cgi?id=195780
2937
2938         Reviewed by Tim Horton.
2939         
2940         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2941         cuts off communication of scrolling tree scrolls back to the web process
2942         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2943         allows tests to trigger scrolls which run the scrolling tree layer positioning
2944         logic, but never get another commit from the web process that might mask
2945         scrolling tree bugs.
2946         
2947         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2948         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2949         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2950
2951         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2952         (WTR::UIScriptController::scrollUpdatesDisabled const):
2953         (WTR::UIScriptController::setScrollUpdatesDisabled):
2954         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2955         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2956         (WTR::UIScriptController::scrollUpdatesDisabled const):
2957         (WTR::UIScriptController::setScrollUpdatesDisabled):
2958         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2959         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2960         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2961         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2962         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2963         * WebKitTestRunner/ios/TestControllerIOS.mm:
2964         (WTR::TestController::platformResetStateToConsistentValues):
2965         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2966         (WTR::UIScriptController::scrollUpdatesDisabled const):
2967         (WTR::UIScriptController::setScrollUpdatesDisabled):
2968
2969 2019-03-14  Youenn Fablet  <youenn@apple.com>
2970
2971         Move IDB storage in private browsing mode to NetworkProcess
2972         https://bugs.webkit.org/show_bug.cgi?id=195602
2973
2974         Reviewed by Brady Eidson.
2975
2976         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2977         (TEST):
2978
2979 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2980
2981         [ews-build] Make descriptionDone messages more readable
2982         https://bugs.webkit.org/show_bug.cgi?id=195760
2983
2984         Reviewed by Lucas Forschler.
2985
2986         * BuildSlaveSupport/ews-build/steps.py:
2987         * BuildSlaveSupport/ews-build/steps_unittest.py:
2988
2989 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2990
2991         [ews-build] Generate status-bubble hover-over messages
2992         https://bugs.webkit.org/show_bug.cgi?id=195680
2993
2994         Reviewed by Lucas Forschler.
2995
2996         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2997         (StatusBubble):
2998         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2999         on hover-over.
3000         (StatusBubble._iso_time):
3001         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3002         hover-over message.
3003         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3004
3005 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-app] Gracefully handle the case when state_string is None
3008         https://bugs.webkit.org/show_bug.cgi?id=195753
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-app/ews/models/build.py:
3013         * BuildSlaveSupport/ews-app/ews/models/step.py:
3014
3015 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3016
3017         [ews-app] Status bubble display pending for currently running build step
3018         https://bugs.webkit.org/show_bug.cgi?id=195744
3019
3020         Reviewed by Lucas Forschler.
3021
3022         * BuildSlaveSupport/ews-build/events.py:
3023         (Events.stepStarted): If state_string is pending, replace it with step name.
3024
3025 2019-03-14  Chris Dumez  <cdumez@apple.com>
3026
3027         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3028         https://bugs.webkit.org/show_bug.cgi?id=195750
3029
3030         Reviewed by Geoffrey Garen.
3031
3032         Add API test coverage.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3035         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3036         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3037         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3038
3039 2019-03-14  Chris Dumez  <cdumez@apple.com>
3040
3041         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3042         https://bugs.webkit.org/show_bug.cgi?id=195747
3043
3044         Reviewed by Geoff Garen.
3045
3046         Add API test coverage.
3047
3048         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3049
3050 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3051
3052         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3053         https://bugs.webkit.org/show_bug.cgi?id=195725
3054         <rdar://problem/48545062>
3055
3056         Reviewed by Tim Horton.
3057
3058         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3059         handler is nil.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3062         (TestWebKitAPI::TEST):
3063
3064 2019-03-13  Sam Weinig  <sam@webkit.org>
3065
3066         Add utility function to allow easy reverse range-based iteration of a container
3067         https://bugs.webkit.org/show_bug.cgi?id=195542
3068
3069         Reviewed by Antti Koivisto.
3070
3071         * TestWebKitAPI/CMakeLists.txt:
3072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3073         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3074         (TestWebKitAPI::TEST):
3075         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3076
3077 2019-03-13  Chris Dumez  <cdumez@apple.com>
3078
3079         Use a ServiceWorker process per registrable domain
3080         https://bugs.webkit.org/show_bug.cgi?id=195649
3081
3082         Reviewed by Youenn Fablet.
3083
3084         Update API test coverage.
3085
3086         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3087
3088 2019-03-13  Chris Dumez  <cdumez@apple.com>
3089
3090         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3091         https://bugs.webkit.org/show_bug.cgi?id=195684
3092         <rdar://problem/48294714>
3093
3094         Reviewed by Antti Koivisto.
3095
3096         Add API test coverage.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3099
3100 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3101
3102         [ews-app] Remove unused patch view
3103         https://bugs.webkit.org/show_bug.cgi?id=195669
3104
3105         Reviewed by Lucas Forschler.
3106
3107         * BuildSlaveSupport/ews-app/ews/urls.py:
3108         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3109
3110 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3111
3112         [ews-app] Use Buildbot result code variables
3113         https://bugs.webkit.org/show_bug.cgi?id=195668
3114
3115         Reviewed by Alexey Proskuryakov.
3116
3117         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3118         (Buildbot): Added Buildbot result code variables.
3119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3120         (StatusBubble._build_bubble): Used Buildbot result code variables.
3121
3122 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3123
3124         [Flatpak] Expand submodule recursively
3125         https://bugs.webkit.org/show_bug.cgi?id=195672
3126
3127         Building WPE with flatpak was impossible without that as it was raising an exception.
3128         Also update wpebackend-fdo to match what is built in jhbuild
3129
3130         Reviewed by Philippe Normand.
3131
3132         * flatpak/flatpakutils.py:
3133         (expand_submodules_recurse):
3134         (expand_manifest):
3135         * flatpak/org.webkit.WPEModules.yaml:
3136
3137 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3138
3139         [ews-app] status bubble should be hidden for certain builds
3140         https://bugs.webkit.org/show_bug.cgi?id=194597
3141
3142         Reviewed by Dewei Zhu.
3143
3144         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3145         (StatusBubble._build_bubble):
3146         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3147         because the patch didn't have relevant changes.
3148         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3149         in production yet.
3150
3151 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3152
3153         [Win] Fix a slew of simple clang-cl warnings.
3154         https://bugs.webkit.org/show_bug.cgi?id=195652
3155
3156         Reviewed by Don Olmstead.
3157
3158         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3159         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3160
3161 2019-03-12  Justin Fan  <justin_fan@apple.com>
3162
3163         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3164         https://bugs.webkit.org/show_bug.cgi?id=195518
3165         <rdar://problem/46322356>
3166
3167         Reviewed by Myles C. Maxfield.
3168
3169         * DumpRenderTree/DerivedSources-input.xcfilelist:
3170         * DumpRenderTree/DerivedSources-output.xcfilelist:
3171
3172 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3173
3174         Unreviewed, rolling out r242825.
3175         https://bugs.webkit.org/show_bug.cgi?id=195648
3176
3177         "Broke webkitpy tests with my change to
3178         lldb_dump_class_layout.py" (Requested by rmorisset on
3179         #webkit).
3180
3181         Reverted changeset:
3182
3183         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3184         classes with suspicious padding"
3185         https://bugs.webkit.org/show_bug.cgi?id=195573
3186         https://trac.webkit.org/changeset/242825
3187
3188 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3189
3190         [ews-build] Show status bubbles while the patch is waiting in queue
3191         https://bugs.webkit.org/show_bug.cgi?id=195618
3192
3193         Reviewed by Lucas Forschler.
3194
3195         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3196         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3197         enabled in initial deployment.
3198         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3199         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3200         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3201         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3202         (StatusBubble._build_bubbles_for_patch):
3203
3204 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3205
3206         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3207         https://bugs.webkit.org/show_bug.cgi?id=195573
3208
3209         Reviewed by Simon Fraser.
3210
3211         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3212
3213         * Scripts/dump-class-layout:
3214         (main):
3215         * lldb/lldb_dump_class_layout.py:
3216         (ClassLayout.__init__):
3217         (ClassLayout._compute_padding_recursive):
3218         (LLDBDebuggerInstance.dump_layout_for_classname):
3219         (LLDBDebuggerInstance):
3220         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3221         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3222
3223 2019-03-12  Chris Dumez  <cdumez@apple.com>
3224
3225         Device Orientation access permission should be denied unless explicitly granted by the client
3226         https://bugs.webkit.org/show_bug.cgi?id=195625
3227
3228         Reviewed by Youenn Fablet.
3229
3230         add API test coverage.
3231
3232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3233         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3234         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3235         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3236         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3237         (runDeviceOrientationTest):
3238         (TEST):
3239         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3240         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3241
3242 2019-03-12  Jer Noble  <jer.noble@apple.com>
3243
3244         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3245         https://bugs.webkit.org/show_bug.cgi?id=195137
3246         <rdar://problem/48810307>
3247
3248         Reviewed by Eric Carlson.
3249
3250         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3251         (TestWebKitAPI::TEST):
3252
3253 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3254
3255         [ews-build] Change urls from uat to production
3256         https://bugs.webkit.org/show_bug.cgi?id=195566
3257
3258         Reviewed by Lucas Forschler.
3259
3260         * BuildSlaveSupport/ews-app/ews/config.py:
3261         * BuildSlaveSupport/ews-build/events.py:
3262         * BuildSlaveSupport/ews-build/steps.py:
3263
3264 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-build] change max_builds for local-worker to 1
3267         https://bugs.webkit.org/show_bug.cgi?id=195568
3268
3269         Reviewed by Lucas Forschler.
3270
3271         * BuildSlaveSupport/ews-build/loadConfig.py:
3272
3273 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3274
3275         Fix the build
3276
3277         * TestRunnerShared/spi/PencilKitTestSPI.h:
3278         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3279
3280 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3281
3282         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3283         https://bugs.webkit.org/show_bug.cgi?id=194131
3284
3285         Reviewed by Michael Catanzaro.
3286
3287         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3288         (uriChanged):
3289         (testUnfinishedSubresourceLoad):
3290         (serverCallback):
3291         (beforeAll):
3292
3293 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3294
3295         WTF::Expected should use std::addressof instead of operator&
3296         https://bugs.webkit.org/show_bug.cgi?id=195604
3297
3298         Reviewed by Myles Maxfield.
3299
3300         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3301         (TestWebKitAPI::Unique::Unique):
3302         (TestWebKitAPI::Unique::operator&):
3303         (TestWebKitAPI::TEST):
3304
3305 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3306
3307         Add Optional to Forward.h.
3308         https://bugs.webkit.org/show_bug.cgi?id=195586
3309
3310         Reviewed by Darin Adler.
3311
3312         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3313         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3314         Remove unnecessary includes from headers.
3315
3316 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3317
3318         Add testing API to hit-test and scroll overflow scrollers
3319         https://bugs.webkit.org/show_bug.cgi?id=195278
3320
3321         Reviewed by Antti Koivisto.
3322         
3323         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3324         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3325         
3326         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3327
3328         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3329         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3330         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3331         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3332         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3333         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3334         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3335         (WTR::enclosingScrollViewIncludingSelf):
3336         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3337
3338 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3339
3340         API test WebKit.RequestTextInputContext fails on iOS
3341         https://bugs.webkit.org/show_bug.cgi?id=195585
3342
3343         Reviewed by Wenson Hsieh and Simon Fraser.
3344
3345         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3346         (applyStyle):
3347         (TEST):
3348         Add a viewport, so that the coordinates match up on iOS.
3349         Scroll by moving the UIScrollView's contentOffset.
3350
3351 2019-03-11  Chris Dumez  <cdumez@apple.com>
3352
3353         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3354         https://bugs.webkit.org/show_bug.cgi?id=195506
3355         <rdar://problem/48733477>
3356
3357         Reviewed by Alex Christensen.
3358
3359         Add API test coverage.
3360
3361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3362
3363 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3364
3365         Adding myself to contributors.json
3366
3367         Unreviewed, addming myself to contributors.json .
3368
3369         * Scripts/webkitpy/common/config/contributors.json:
3370
3371 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3372
3373         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3374         https://bugs.webkit.org/show_bug.cgi?id=195511
3375         <rdar://problem/44873269>
3376
3377         Reviewed by Darin Adler.
3378
3379         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3380         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3381         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3382         (TEST_F):
3383
3384 2019-03-11  Chris Dumez  <cdumez@apple.com>
3385
3386         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3387         https://bugs.webkit.org/show_bug.cgi?id=195561
3388
3389         Reviewed by Youenn Fablet.
3390
3391         Make sure the JS in the test requests for permission to receive device orientation events.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3394
3395 2019-03-11  Youenn Fablet  <youenn@apple.com>
3396
3397         Allow storage quota increase by default in WTR
3398         https://bugs.webkit.org/show_bug.cgi?id=195541
3399
3400         Reviewed by Geoffrey Garen.
3401
3402         Allow storage quota increase by default in WTR.
3403         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3404         Use this for tests that explicitly need cache increase.
3405
3406         Instead of increasing quota by 2, make sure the next request is
3407         granted by adding all given parameters.
3408
3409         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3410         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3411         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3412         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3413         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3414         * WebKitTestRunner/TestController.cpp:
3415         (WTR::TestController::setAllowStorageQuotaIncrease):
3416         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3417         * WebKitTestRunner/TestController.h:
3418         * WebKitTestRunner/TestInvocation.cpp:
3419         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3420         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3421         (WTR::TestController::cocoaResetStateToConsistentValues):
3422         (WTR::TestController::setAllowStorageQuotaIncrease):
3423         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3424         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3425         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3426
3427 2019-03-11  Xan Lopez  <xan@igalia.com>
3428
3429         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3430         https://bugs.webkit.org/show_bug.cgi?id=194147
3431
3432         Reviewed by Michael Saboff.
3433
3434         To make --32-bit work correctly on Linux/64bit we need to:
3435
3436         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3437         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3438         unfortunately CMake only allows us to do this during
3439         crosscompilation, which is overkill here.
3440         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3441         pkg-config detection module uses the x86 .pc files instead of the
3442         x86_64 ones.
3443         - Set the -m32 flags for the compiler.
3444
3445         * Scripts/webkitdirs.pm:
3446         (generateBuildSystemFromCMakeProject):
3447
3448 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3449
3450         Add MotionMark-1.1 plan file for run-benchmark script.
3451         https://bugs.webkit.org/show_bug.cgi?id=195481
3452
3453         Rubber-stamped by Darin Adler.
3454
3455         Run-benchmark script should support MontionMark-1.1.
3456
3457         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3458
3459 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3460
3461         [ews-app] Add support for submit-to-ews url
3462         https://bugs.webkit.org/show_bug.cgi?id=195477
3463
3464         Reviewed by Lucas Forschler.
3465
3466         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3467         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3468         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3469         * BuildSlaveSupport/ews-app/ews/urls.py:
3470         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3471
3472 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3473
3474         Unreviewed, rolling out r242688, r242643, r242624.
3475
3476         Caused multiple layout test failures and crashes on iOS and macOS.
3477
3478         Reverted changeset:
3479
3480         "requestAnimationFrame should execute before the next frame"
3481         https://bugs.webkit.org/show_bug.cgi?id=177484
3482         https://trac.webkit.org/changeset/242624/webkit
3483
3484         * Tracing/SystemTracePoints.plist:
3485
3486 2019-03-11  John Wilander  <wilander@apple.com>
3487
3488         Resource Load Statistics: Make it possible exclude localhost from classification
3489         https://bugs.webkit.org/show_bug.cgi?id=195474
3490         <rdar://problem/47520577>
3491
3492         Reviewed by Brent Fulgham.
3493
3494         This patch allows for localhost to be excluded from classification and
3495         treatment as a prevalent resource.
3496
3497         The WebKit Tools change adds a new function called
3498         testRunner.setStatisticsIsRunningTest() which can be used to control this
3499         behavior.
3500
3501         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3502         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3503         (WTR::TestRunner::setStatisticsIsRunningTest):
3504         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3505         * WebKitTestRunner/TestController.cpp:
3506         (WTR::TestController::setStatisticsIsRunningTest):
3507         * WebKitTestRunner/TestController.h:
3508         * WebKitTestRunner/TestInvocation.cpp:
3509         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3510
3511 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3512
3513         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3514         https://bugs.webkit.org/show_bug.cgi?id=195560
3515
3516         Reviewed by Lucas Forschler.
3517
3518         * BuildSlaveSupport/ews-build/master.cfg:
3519
3520 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3521
3522         Unreviewed, rolling out r242698.
3523
3524         API test crashes on bots.
3525
3526         Reverted changeset:
3527
3528         "Add a WKContentRuleList variant that uses copied memory
3529         instead of mmap'd shared memory for class A containerized
3530         apps"
3531         https://bugs.webkit.org/show_bug.cgi?id=195511
3532         https://trac.webkit.org/changeset/242698
3533
3534 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3535
3536         [WPE] Enable web process sandbox
3537         https://bugs.webkit.org/show_bug.cgi?id=195169
3538
3539         Reviewed by Daniel Bates.
3540
3541         * wpe/install-dependencies:
3542         * wpe/jhbuild.modules:
3543
3544 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3545
3546         [ews-app] Use port 17000 for worker communication
3547         https://bugs.webkit.org/show_bug.cgi?id=195558
3548
3549         Reviewed by Lucas Forschler.
3550
3551         * BuildSlaveSupport/ews-build/master.cfg:
3552
3553 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3554
3555         [ews-build] unit-tests fail when passwords.json is missing
3556         https://bugs.webkit.org/show_bug.cgi?id=195557
3557
3558         Reviewed by Lucas Forschler.
3559
3560         * BuildSlaveSupport/ews-build/loadConfig.py:
3561         (loadBuilderConfig):
3562         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3563         (ConfigDotJSONTest.test_configuration):
3564         * BuildSlaveSupport/ews-build/master.cfg:
3565
3566 2019-03-11  Truitt Savell  <tsavell@apple.com>
3567
3568         Unreviewed, rolling out r242702.
3569
3570         Broke High Sierra builders.
3571
3572         Reverted changeset:
3573
3574         "Add utility function to allow easy reverse range-based
3575         iteration of a container"
3576         https://bugs.webkit.org/show_bug.cgi?id=195542
3577         https://trac.webkit.org/changeset/242702
3578
3579 2019-03-11  Sam Weinig  <sam@webkit.org>
3580
3581         Add utility function to allow easy reverse range-based iteration of a container
3582         https://bugs.webkit.org/show_bug.cgi?id=195542
3583
3584         Reviewed by Antti Koivisto.
3585
3586         * TestWebKitAPI/CMakeLists.txt:
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3589         (TestWebKitAPI::TEST):
3590         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3591
3592 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3593
3594         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3595         https://bugs.webkit.org/show_bug.cgi?id=195511
3596         <rdar://problem/44873269>
3597
3598         Reviewed by Darin Adler.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3601         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3602         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3603         (TEST_F):
3604
3605 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3606
3607         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3608         https://bugs.webkit.org/show_bug.cgi?id=195499
3609
3610         Reviewed by Darin Adler.
3611
3612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3613         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3614         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3615         (-[WKWebView synchronouslyFocusTextInputContext:]):
3616         (applyStyle):
3617         (applyIframe):
3618         (TEST):
3619         Add some tests for this SPI.
3620
3621 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3622
3623         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3624         https://bugs.webkit.org/show_bug.cgi?id=181151
3625
3626         Reviewed by Don Olmstead.
3627
3628         * TestWebKitAPI/CMakeLists.txt:
3629         * TestWebKitAPI/PlatformWin.cmake:
3630         Enable TestWTF RunLoop tests in all platforms.
3631
3632         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3633         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3634         (TestWebKitAPI::DerivedOneShotTimer::fired):
3635         (TestWebKitAPI::TEST):
3636         Only a few platforms support nested RunLoop.
3637
3638         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3639         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3640
3641 2019-03-10  David Quesada  <david_quesada@apple.com>
3642
3643         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3644         https://bugs.webkit.org/show_bug.cgi?id=152480
3645
3646         Reviewed by Chris Dumez.
3647
3648         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3649         there are no additional references to the process pool besides the one held by
3650         the download, waits for the download to finish (in the sense that the
3651         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3652         measure, also check that the process pool has been deallocated at the end of the
3653         test. The test wouldn't be meaningful if the process pool were still alive.
3654
3655         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3656         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3657         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3658             The download will be canceled because the delegate does not implement the
3659             method to decide the download's destination, so this is where we know the
3660             DownloadProxyMap is done with the DownloadProxy.
3661         (TEST):
3662
3663 2019-03-08  Chris Dumez  <cdumez@apple.com>
3664
3665         Add support for Device Orientation / Motion permission API
3666         https://bugs.webkit.org/show_bug.cgi?id=195329
3667         <rdar://problem/47645367>
3668
3669         Reviewed by Geoffrey Garen.
3670
3671         Add test infrastructure to help test the Device Orientation / Motion permission API.
3672
3673         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3675         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3676         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3677         * WebKitTestRunner/TestController.cpp:
3678         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3679         (WTR::TestController::createWebViewWithOptions):
3680         (WTR::TestController::resetStateToConsistentValues):
3681         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3682         * WebKitTestRunner/TestController.h:
3683         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3684         * WebKitTestRunner/TestInvocation.cpp:
3685         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3686
3687 2019-03-08  Saam barati  <sbarati@apple.com>
3688
3689         Add a compare-results script to compare benchmark results
3690         https://bugs.webkit.org/show_bug.cgi?id=195486
3691         <rdar://problem/48723397>
3692
3693         Reviewed by Geoffrey Garen.
3694
3695         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3696         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3697         to extend it to learn about our other benchmarks.
3698
3699         * Scripts/compare-results: Added.
3700         (readJSONFile):
3701         (detectJetStream2):
3702         (JetStream2Results):
3703         (detectSpeedometer2):
3704         (Speedometer2Results):
3705         (detectPLT5):
3706         (PLT5Results):
3707         (detectBenchmark):
3708         (biggerIsBetter):
3709         (ttest):
3710         (getOptions):
3711         (main):
3712
3713 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3714
3715         Ensure old tab state is cleared between iterations of run-benchmark
3716         https://bugs.webkit.org/show_bug.cgi?id=195393
3717         <rdar://problem/46885583>
3718
3719         Reviewed by Dewei Zhu.
3720
3721         a) ensure the default to restore state is not set
3722         b) terminate Safari correctly
3723         c) Set the system default to ignore Persistent State in Safari
3724
3725         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3726         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3727         (OSXBrowserDriver.prepare_env): 
3728         (OSXBrowserDriver.restore_env):
3729         (OSXBrowserDriver.close_browsers):
3730         (OSXBrowserDriver._terminate_processes):
3731         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3732         (OSXChromeDriver):
3733         (OSXChromeCanaryDriver):
3734         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3735         (OSXFirefoxDriver):
3736         (OSXFirefoxNightlyDriver):
3737         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3738         (OSXSafariDriver):
3739         (OSXSafariDriver.prepare_env):
3740
3741 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3742
3743         [GTK] Several InputMethodFilter tests are failing
3744         https://bugs.webkit.org/show_bug.cgi?id=195408
3745
3746         Reviewed by Carlos Garcia Campos.
3747
3748         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3749         Regressed in r241751.
3750         Hexadecimal values of keycodes are expressed now in upper letters.
3751         Composited characters should be cast to UTF8 strings.
3752
3753         (TestWebKitAPI::TEST):
3754
3755 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3756
3757         [GTK] Make Tools/gtkdoc python3 compatible
3758         https://bugs.webkit.org/show_bug.cgi?id=195359
3759
3760         Reviewed by Carlos Garcia Campos.
3761
3762         * gtkdoc/generate-gtkdoc:
3763         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3764         work with Python 2 and 3.
3765         (get_gtkdoc_module_paths):
3766         The iteritems() was removed in Python 3, so let's use items() that's
3767         available in Python 2 and 3.
3768         (get_generator_for_config):
3769         * gtkdoc/gtkdoc.py:
3770         (GTKDoc._run_command):
3771         The sys.stdout.write() is expecting str in Python 3 and not bytes
3772         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3773         for passing the bytes there.
3774
3775 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3776
3777         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3778         https://bugs.webkit.org/show_bug.cgi?id=195346
3779         <rdar://problem/48667048>
3780
3781         Unreviewed build fix for clang-cl.
3782
3783         * DumpRenderTree/win/DumpRenderTree.cpp:
3784         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3785
3786 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3787
3788         requestAnimationFrame should execute before the next frame
3789         https://bugs.webkit.org/show_bug.cgi?id=177484
3790
3791         Reviewed by Simon Fraser.
3792
3793         Add trace points for the page RenderingUpdate.
3794
3795         * Tracing/SystemTracePoints.plist:
3796
3797 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3798
3799         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3800         https://bugs.webkit.org/show_bug.cgi?id=195353
3801         <rdar://problem/48626394>
3802
3803         Reviewed by Simon Fraser.
3804
3805         * WebKitTestRunner/ios/TestControllerIOS.mm:
3806         (WTR::TestController::platformResetPreferencesToConsistentValues):
3807
3808 2019-03-07  John Wilander  <wilander@apple.com>
3809
3810         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3811         https://bugs.webkit.org/show_bug.cgi?id=195383
3812         <rdar://problem/48570136>
3813
3814         Reviewed by Brent Fulgham.
3815
3816         This patch adds test infrastructure to purge only script-accessible cookies,
3817         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3818
3819         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3821         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3822         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3823         * WebKitTestRunner/TestController.cpp:
3824         (WTR::TestController::statisticsDeleteCookiesForHost):
3825         * WebKitTestRunner/TestController.h:
3826         * WebKitTestRunner/TestInvocation.cpp:
3827         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3828
3829 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3830
3831         Unreviewed, rolling out r242354.
3832         https://bugs.webkit.org/show_bug.cgi?id=195402
3833
3834         breaks layout tests in all configurations (Requested by
3835         zdobersek on #webkit).
3836
3837         Reverted changeset:
3838
3839         "[WPE] Enable web process sandbox"
3840         https://bugs.webkit.org/show_bug.cgi?id=195169
3841         https://trac.webkit.org/changeset/242354
3842
3843 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3844
3845         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3846         https://bugs.webkit.org/show_bug.cgi?id=195346
3847
3848         Reviewed by Fujii Hironori.
3849
3850         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3851         (TestWebKitAPI::TEST):
3852         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3853
3854         * DumpRenderTree/win/DumpRenderTree.cpp:
3855         (findFontFallback):
3856         (addFontFallbackIfPresent):
3857         (removeFontFallbackIfPresent):
3858         (main):
3859         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3860         (TestWebKitAPI::Util::moduleDirectory):
3861         (TestWebKitAPI::Util::createInjectedBundlePath):
3862         Use wchar helpers as needed.
3863
3864 2019-03-06  Rob Buis  <rbuis@igalia.com>
3865
3866         Consider supporting the `referrerpolicy` attribute.
3867         https://bugs.webkit.org/show_bug.cgi?id=179053
3868
3869         Reviewed by Darin Adler.
3870
3871         Add a runtime flag for referrerpolicy attribute.
3872
3873         * DumpRenderTree/mac/DumpRenderTree.mm:
3874         (enableExperimentalFeatures):
3875
3876 2019-03-05  Daniel Bates  <dabates@apple.com>
3877
3878         Update expected API test result following r242379
3879         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3880
3881         Update expected x-coordinate of selection rect now that the left padding of
3882         a textarea is sized in ems (so dependent on the font size) just like the left
3883         padding of a text field.
3884
3885         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3886         (TestWebKitAPI::TEST):
3887
3888 2019-03-05  David Quesada  <david_quesada@apple.com>
3889
3890         [WK2] It should be possible to follow links with 'download' attributes
3891         https://bugs.webkit.org/show_bug.cgi?id=195145
3892         rdar://problem/48462642
3893
3894         Reviewed by Alex Christensen.
3895
3896         Add a unit test to verify that activating links with 'download' attributes now
3897         navigates to the linked resource, rather than starts downloading it. Add another
3898         to verify that it is still possible to explicitly download the link via the
3899         'Download' navigation action policy.
3900
3901         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3902         (-[DownloadAttributeTestDelegate init]):
3903         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3904         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3905         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3906         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3907         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3908         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3909         (TEST):
3910         * WebKitTestRunner/TestController.cpp:
3911         (WTR::TestController::decidePolicyForNavigationAction):
3912         * WebKitTestRunner/TestController.h:
3913
3914 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3915
3916         [Curl] Implement Cookie Accept Policy.
3917         https://bugs.webkit.org/show_bug.cgi?id=191645
3918
3919         Reviewed by Fujii Hironori.
3920
3921         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3922         (TestWebKitAPI::Curl::TEST_F):
3923
3924 2019-03-05  Youenn Fablet  <youenn@apple.com>
3925
3926         Rename requestCacheStorageSpace to requestStorageSpace
3927         https://bugs.webkit.org/show_bug.cgi?id=195282
3928
3929         Reviewed by Chris Dumez.
3930
3931         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3932         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3933         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3934
3935 2019-03-05  Brady Eidson  <beidson@apple.com>
3936
3937         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3938         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3939
3940         Reviewed by Tim Horton.
3941
3942         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3943         different directory into that same WKWebView should work.
3944
3945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3946         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3947
3948 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3949
3950         Add WeakHashSet
3951         https://bugs.webkit.org/show_bug.cgi?id=195152
3952
3953         Reviewed by Antti Koivisto.
3954
3955         Added tests for WeakHashSet.
3956
3957         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3958         (TestWebKitAPI::Base::Base): Moved.
3959         (TestWebKitAPI::Derived::foo): Moved.
3960         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3961         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3962         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3963         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3964
3965 2019-03-04  Chris Dumez  <cdumez@apple.com>
3966
3967         Do not share WebProcesses between private and regular sessions
3968         https://bugs.webkit.org/show_bug.cgi?id=195189
3969         <rdar://problem/48421064>
3970
3971         Reviewed by Alex Christensen.
3972
3973         Add API test coverage.
3974
3975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3976         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3977
3978 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3979
3980         [WPE] Enable web process sandbox
3981         https://bugs.webkit.org/show_bug.cgi?id=195169
3982
3983         Reviewed by Daniel Bates.
3984
3985         * wpe/install-dependencies:
3986         * wpe/jhbuild.modules:
3987
3988 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3989
3990         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3991         https://bugs.webkit.org/show_bug.cgi?id=195206
3992
3993         Reviewed by Žan Doberšek.
3994
3995         Add a new test case.
3996
3997         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3998         (testJSCClass):
3999
4000 2019-03-04  Charlie Turner  <cturner@igalia.com>
4001
4002         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4003         https://bugs.webkit.org/show_bug.cgi?id=194898
4004
4005         Reviewed by Žan Doberšek.
4006
4007         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4008         a GCC extension that permits arithmetic on void* pointer. Inline
4009         the macro until this issue is fixed upstream.
4010
4011 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4012
4013         Rid the world of WK_API_ENABLED
4014         https://bugs.webkit.org/show_bug.cgi?id=195263
4015
4016         Reviewed by Dan Bernstein.
4017
4018         List of changed files elided because it's useless.
4019
4020 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4021
4022         Unreviewed follow-up to r242292.
4023
4024         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4025
4026         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4027         (TestWebKitAPI::testStrip): Renamed from strip.
4028         (TestWebKitAPI::TEST):
4029
4030 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4031
4032         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4033
4034         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4035         and bug #194272 for details.
4036
4037         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4038
4039 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4040
4041         Remove some more unused 32-bit code
4042         https://bugs.webkit.org/show_bug.cgi?id=195255
4043
4044         Reviewed by Darin Adler.
4045
4046         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4047         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4048         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4049         (NPP_New):
4050         (NPP_HandleEvent):
4051         (handleEventCarbon): Deleted.
4052
4053 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4054
4055         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4056
4057         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4058         (TestWebKitAPI::TEST):
4059
4060 2019-03-01  Darin Adler  <darin@apple.com>
4061
4062         Finish removing String::format
4063         https://bugs.webkit.org/show_bug.cgi?id=194893
4064
4065         Reviewed by Daniel Bates.
4066 '
4067         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4068
4069 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4070
4071         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4072         https://bugs.webkit.org/show_bug.cgi?id=195229
4073         <rdar://problem/48520362>
4074
4075         Reviewed by Chris Dumez.
4076
4077         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4078         (TEST):
4079
4080 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4081
4082         Add a system trace scope for event region building
4083         https://bugs.webkit.org/show_bug.cgi?id=195226
4084
4085         Reviewed by Jon Lee.
4086
4087         This trace scope measures the time spend converting element rects into Region objects,
4088         which can be large on some pages.
4089
4090         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4091
4092         * Tracing/SystemTracePoints.plist:
4093
4094 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4095
4096         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4097         https://bugs.webkit.org/show_bug.cgi?id=194612
4098
4099         Reviewed by Alex Christensen.
4100
4101         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4102         Just test the new string-processing function and don't touch the actual environment.
4103         (Test cases are all as before, but based on operator== instead of strcmp.)
4104
4105 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4106
4107         [ews-app] Update primary keys for handling multiple Buildbot instances
4108         https://bugs.webkit.org/show_bug.cgi?id=195120
4109
4110         Reviewed by Stephanie Lewis.
4111
4112         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4113         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4114         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4115
4116         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4117         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4118         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4119         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4120         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4121         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4122
4123 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4124
4125         [WinCairo] Enable service worker
4126         https://bugs.webkit.org/show_bug.cgi?id=188318
4127
4128         Reviewed by Youenn Fablet.
4129
4130         * DumpRenderTree/DumpRenderTreePrefix.h:
4131         * TestWebKitAPI/PlatformWin.cmake:
4132         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4133         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4134         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4135
4136 2019-03-01  Justin Fan  <justin_fan@apple.com>
4137
4138         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4139         https://bugs.webkit.org/show_bug.cgi?id=195191
4140
4141         Rubber-stamped by Dean Jackson.
4142
4143         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4144
4145         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4146
4147 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4148
4149         Unreviewed, fix lldb webkitpy tests
4150         https://bugs.webkit.org/show_bug.cgi?id=194375
4151
4152         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4153
4154         * lldb/lldb_webkit.py:
4155         (WTFStringImplProvider.is_8bit):
4156
4157 2019-02-28  David Quesada  <david_quesada@apple.com>
4158
4159         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4160         https://bugs.webkit.org/show_bug.cgi?id=195121
4161         rdar://problem/48450302
4162
4163         Reviewed by Alex Christensen.
4164
4165         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4166         configurations where the 'download' attribute is absent, blank, or populated
4167         with a filename, and where the anchor element is same-origin or cross-origin
4168         (meaning the 'download' attribute shouldn't be honored).
4169
4170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4171         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4172         (-[NavigationActionTestDelegate init]):
4173         (-[NavigationActionTestDelegate navigationAction]):
4174         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4175         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4176         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4177         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4178         (TEST):
4179
4180 2019-02-28  Antoine Quint  <graouts@apple.com>
4181
4182         Enable the Pointer Events runtime flag by default
4183         https://bugs.webkit.org/show_bug.cgi?id=195156
4184
4185         Reviewed by Dean Jackson.
4186
4187         * DumpRenderTree/mac/DumpRenderTree.mm:
4188         (enableExperimentalFeatures):
4189
4190 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4191
4192         Several PasteImage API tests are flaky
4193         https://bugs.webkit.org/show_bug.cgi?id=195160
4194
4195         Reviewed by Tim Horton.
4196
4197         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4198         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4199         listening for a "load" event after image load is already complete.
4200
4201         To address this, make these tests first register a "load" event handler, then run script to insert an image
4202         element into the document, and finally wait until the load event is observed before checking image size.
4203
4204         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4205
4206 2019-02-28  Chris Dumez  <cdumez@apple.com>
4207
4208         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4209         https://bugs.webkit.org/show_bug.cgi?id=195107
4210
4211         Reviewed by Alex Christensen.
4212
4213         Give some time for the zoom level to get restored.
4214
4215         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4216
4217 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4218
4219         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4220         https://bugs.webkit.org/show_bug.cgi?id=194958
4221
4222         Reviewed by Geoffrey Garen.
4223
4224         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4225         (TEST):
4226
4227 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4228
4229         [ews-app] Update method to save build to handle builder_display_name
4230         https://bugs.webkit.org/show_bug.cgi?id=195047
4231
4232         Reviewed by Dewei Zhu.
4233
4234         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4235         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4236
4237 2019-02-28  Justin Fan  <justin_fan@apple.com>
4238
4239         [Web GPU] Enable Web GPU only on 64-bit
4240         https://bugs.webkit.org/show_bug.cgi?id=195139
4241
4242         Because Metal is only supported on 64 bit apps.
4243
4244         Unreviewed build fix.
4245
4246         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4247
4248 2019-02-27  Youenn Fablet  <youenn@apple.com>
4249
4250         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4251         https://bugs.webkit.org/show_bug.cgi?id=194959
4252
4253         Reviewed by Chris Dumez.
4254
4255         Spin loop until getting the condition to remove flakiness.
4256
4257         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4258
4259 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4260
4261         [ews-build] Buildbot should include builder_display_name in the build events
4262         https://bugs.webkit.org/show_bug.cgi?id=195045
4263
4264         Reviewed by Dewei Zhu.
4265
4266         * BuildSlaveSupport/ews-build/events.py:
4267         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4268         buildername to builder_name to be consistent in naming style.
4269         (Events.buildFinished): Ditto.
4270
4271 2019-02-27  Chris Dumez  <cdumez@apple.com>
4272
4273         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4274         https://bugs.webkit.org/show_bug.cgi?id=194480
4275
4276         Reviewed by Brady Eidson.
4277
4278         Update existing API test to make it more likely to reproduce the issue.
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4281
4282 2019-02-27  Brady Eidson  <beidson@apple.com>
4283
4284         Universal links from Google search results pages don't open the app.
4285         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4286
4287         Reviewed by Geoffrey Garen.
4288
4289         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4290         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4291         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4292         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4293
4294 2019-02-27  Chris Dumez  <cdumez@apple.com>
4295
4296         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4297         https://bugs.webkit.org/show_bug.cgi?id=195102
4298
4299         Reviewed by Geoffrey Garen.
4300
4301         If the number of processes is not yet what we expect, wait a bit and check again to give
4302         processes some time to exit.
4303
4304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4305
4306 2019-02-27  Chris Dumez  <cdumez@apple.com>
4307
4308         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4309         https://bugs.webkit.org/show_bug.cgi?id=194545
4310
4311         Reviewed by Brady Eidson.
4312
4313         Make sure the test navigates forward and then back only once. Previously, navigating
4314         back would trigger a navigation again in a timer.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4317
4318 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4319
4320         High Sierra Debug JSC test queue should use faster hardware
4321         https://bugs.webkit.org/show_bug.cgi?id=194603
4322
4323         Rubber-stamped by Alexey Proskuryakov.
4324
4325         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4326
4327         * BuildSlaveSupport/build.webkit.org-config/config.json:
4328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4329         (BubbleQueueServer):
4330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4331         (WebKitBuildbot):
4332         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4333         * QueueStatusServer/config/queues.py:
4334         * Scripts/webkitpy/common/config/ews.json:
4335         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4336         (test_ews_name):
4337
4338 2019-02-27  John Wilander  <wilander@apple.com>
4339
4340         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4341         https://bugs.webkit.org/show_bug.cgi?id=195071
4342         <rdar://problem/48417690>
4343
4344         Reviewed by Alex Christensen and Brent Fulgham.
4345
4346         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4347         (TestWebKitAPI::createURL):
4348             Convenience function.
4349         (TestWebKitAPI::TEST):
4350             WebCore::AdClickAttribution now takes a URL when creating Source and
4351             Destination.
4352         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4353         (TestWebKitAPI::TEST):
4354             WebCore::AdClickAttribution now takes a URL when creating Source and
4355             Destination.
4356
4357 2019-02-27  Antoine Quint  <graouts@apple.com>
4358
4359         Support Pointer Events on macOS
4360         https://bugs.webkit.org/show_bug.cgi?id=195008
4361         <rdar://problem/47454419>
4362
4363         Reviewed by Dean Jackson.
4364
4365         * DumpRenderTree/mac/DumpRenderTree.mm:
4366         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4368
4369 2019-02-26  Mark Lam  <mark.lam@apple.com>
4370
4371         Remove remaining poisoning code.