The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4         https://bugs.webkit.org/show_bug.cgi?id=196588
5         <rdar://problem/49365787>
6
7         Unreviewed build fix for Windows port.
8
9         error C3861: 'kill': identifier not found
10
11         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
12         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
13
14 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
15
16         [ews-build] Cancel build and similar operations should have authentication
17         https://bugs.webkit.org/show_bug.cgi?id=196520
18
19         Reviewed by Dewei Zhu.
20
21         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
22         environment variables.
23
24 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
25
26         [ews-build] Do not trigger queues which are not in production yet
27         https://bugs.webkit.org/show_bug.cgi?id=196581
28
29         Reviewed by Dewei Zhu.
30
31         * BuildSlaveSupport/ews-build/config.json:
32
33 2019-04-03  Chris Dumez  <cdumez@apple.com>
34
35         Unreviewed, fix typo in the name of API test added in r243848.
36
37         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
38         (TestWebKitAPI::TEST):
39
40 2019-04-03  Chris Dumez  <cdumez@apple.com>
41
42         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
43         https://bugs.webkit.org/show_bug.cgi?id=196588
44         <rdar://problem/49365787>
45
46         Reviewed by Ryosuke Niwa.
47
48         Add API test coverage.
49
50         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
51         (TestWebKitAPI::nullJavaScriptCallback):
52         (TestWebKitAPI::didCrashCheckFrames):
53         (TestWebKitAPI::TEST):
54
55 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
56
57         run-webkit-tests: Upload test results (new results database)
58         https://bugs.webkit.org/show_bug.cgi?id=196577
59         <rdar://problem/34841155>
60
61         Reviewed by Lucas Forschler.
62
63         * Scripts/webkitpy/layout_tests/controllers/manager.py:
64         (Manager.run): Upload results after each device shard, since the configuration will be
65         different for each device.
66         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
67         uploaded to a results database.
68         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
69         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
70
71 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
72
73         -apple-trailing-word is needed for browser detection
74         https://bugs.webkit.org/show_bug.cgi?id=196575
75
76         Unreviewed.
77
78         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
79
80 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
81
82         [CMake][WTF] Mirror XCode header directories
83         https://bugs.webkit.org/show_bug.cgi?id=191662
84
85         Reviewed by Konstantin Tokarev.
86
87         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
88         builds.
89
90         * CMakeLists.txt:
91         * DumpRenderTree/CMakeLists.txt:
92         * DumpRenderTree/PlatformWin.cmake:
93         * MiniBrowser/win/CMakeLists.txt:
94         * TestWebKitAPI/CMakeLists.txt:
95         * TestWebKitAPI/PlatformWin.cmake:
96         * WebKitTestRunner/PlatformGTK.cmake:
97         * WebKitTestRunner/PlatformWin.cmake:
98
99 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
100
101         [ews-app] Status bubble should not display certain infrastructure status messages
102         https://bugs.webkit.org/show_bug.cgi?id=196550
103
104         Reviewed by Lucas Forschler.
105
106         Do not display the steps which are un-needed for end-user. This information is still avaiable
107         if the user click on the bubble and look at the Buildbot build.
108         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
109         (StatusBubble._steps_messages):
110         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
111
112 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
113
114         [ews-build] Use https for sending data to ews-app
115         https://bugs.webkit.org/show_bug.cgi?id=196492
116
117         Reviewed by Lucas Forschler.
118
119         * BuildSlaveSupport/ews-build/events.py:
120
121 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
122
123         Remove support for -apple-trailing-word
124         https://bugs.webkit.org/show_bug.cgi?id=196525
125
126         Reviewed by Zalan Bujtas.
127
128         This CSS property is nonstandard and not used.
129
130         * Scripts/webkitperl/FeatureList.pm:
131         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
132
133 2019-04-03  Youenn Fablet  <youenn@apple.com>
134
135         Add a test for DOMCache on multiple browsing in case of private browsing
136         https://bugs.webkit.org/show_bug.cgi?id=196524
137
138         Reviewed by Alex Christensen.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
141         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
142
143 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
144
145         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
146         https://bugs.webkit.org/show_bug.cgi?id=196540
147
148         Reviewed by Aakash Jain.
149
150         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
151
152 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
153
154         Add plumbing for a compatibility mode preference in WebKit
155         https://bugs.webkit.org/show_bug.cgi?id=196005
156
157         Reviewed by Tim Horton.
158
159         Add new API tests.
160
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
163
164 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
165
166         [WPE][GTK] Update libsrtp dependency package for Debian
167         https://bugs.webkit.org/show_bug.cgi?id=196528
168
169         Reviewed by Frédéric Wang.
170
171         * gtk/install-dependencies:
172         * wpe/install-dependencies:
173
174 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
175
176         [WK2] Add support for Window's beforeprint / afterprint events
177         https://bugs.webkit.org/show_bug.cgi?id=196478
178         <rdar://problem/49535124>
179
180         Unreviewed build fix for MSVC.
181
182         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
183
184         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
185
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::printFrame): Use int and float literals.
188
189 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews-build] Reassign bots to queues
192
193         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
194
195 2019-04-02  Chris Dumez  <cdumez@apple.com>
196
197         [WK2] Add support for Window's beforeprint / afterprint events
198         https://bugs.webkit.org/show_bug.cgi?id=196478
199
200         Reviewed by Alex Christensen.
201
202         Add minimal implementation for printFrame in WebKitTestRunner.
203
204         * WebKitTestRunner/TestController.cpp:
205         (WTR::printFrame):
206         (WTR::TestController::createOtherPage):
207         (WTR::TestController::createWebViewWithOptions):
208
209 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
210
211         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
212         https://bugs.webkit.org/show_bug.cgi?id=196491
213
214         Reviewed by Lucas Forschler.
215
216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
217
218 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
219
220         [ews-build] Configure buildbot try credentials in environment variables
221         https://bugs.webkit.org/show_bug.cgi?id=196501
222
223         Reviewed by Lucas Forschler.
224
225         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
226         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
227         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
228
229 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
230
231         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
232         https://bugs.webkit.org/show_bug.cgi?id=196496
233         <rdar://problem/49521634>
234
235         Reviewed by Chris Dumez.
236
237         Add new API tests (see WebKit ChangeLog for more detail).
238
239         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
240         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
241         (TEST):
242
243 2019-04-02  David Kilzer  <ddkilzer@apple.com>
244
245         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
246         <https://webkit.org/b/196499>
247
248         Reviewed by Alexey Proskuryakov.
249
250         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
251         ENABLE_ADDRESS_SANITIZER.
252
253 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
254
255         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
256         https://bugs.webkit.org/show_bug.cgi?id=182757
257
258         Reviewed by Don Olmstead.
259
260         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
261         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
262
263 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
264
265         run-api-tests: Upload test results
266         https://bugs.webkit.org/show_bug.cgi?id=196323
267         <rdar://problem/49356714>
268
269         Reviewed by Lucas Forschler.
270
271         * Scripts/webkitpy/api_tests/manager.py:
272         (Manager):
273         (Manager.run): Upload results to a results database.
274         * Scripts/webkitpy/api_tests/run_api_tests.py:
275         (parse_args): Add upload arguments.
276         * Scripts/webkitpy/port/base.py:
277         (Port):
278         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
279         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
280         with commits from any other associated repositories.
281         * Scripts/webkitpy/port/device.py:
282         (Device):
283         (Device.build_version): Access build_versoin of underlying platform device.
284         * Scripts/webkitpy/port/ios_simulator_unittest.py:
285         (IOSSimulatorTest):
286         (IOSSimulatorTest.test_configuration_for_upload):
287         * Scripts/webkitpy/port/device_port.py:
288         (DevicePort):
289         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
290         the same as the machine uploading results.
291         * Scripts/webkitpy/port/mac.py:
292         (MacPort):
293         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
294         * Scripts/webkitpy/port/mac_unittest.py:
295         (MacTest):
296         (MacTest.test_configuration_for_upload):
297         * Scripts/webkitpy/xcode/simulated_device.py:
298         (SimulatedDeviceManager._create_device_with_runtime):
299         (SimulatedDevice.__init__): Create simulated device with a build_version.
300         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
301         (test_existing_simulator):
302
303 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
304
305         Remove extra newline characters (Follow-up fix to r243707)
306
307         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
308
309 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
310
311         [ews-app] Use API_KEY to accept results data
312         https://bugs.webkit.org/show_bug.cgi?id=196461
313
314         Reviewed by Dewei Zhu.
315
316         * BuildSlaveSupport/ews-app/ews/views/results.py:
317         (Results.post): Validate EWS_API_KEY before accepting any data.
318         * BuildSlaveSupport/ews-build/events.py:
319         (Events.sendData): Send EWS_API_KEY if available along with event data.
320
321 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
322
323         Unable to copy and paste a PDF from Notes into Mail compose body
324         https://bugs.webkit.org/show_bug.cgi?id=196442
325         <rdar://problem/48573098>
326
327         Reviewed by Tim Horton.
328
329         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
330         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
331         to be specified on the item providers.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
334         (TestWebKitAPI::mapItemForTesting):
335         (TestWebKitAPI::contactItemForTesting):
336
337 2019-04-01  Tim Horton  <timothy_horton@apple.com>
338
339         Make UIWKDocumentContext rects per-character instead of per-word
340         https://bugs.webkit.org/show_bug.cgi?id=196459
341
342         Reviewed by Wenson Hsieh.
343
344         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
345         (TEST):
346         Adjust test results due to switching to per-character rects.
347
348 2019-04-01  Chris Dumez  <cdumez@apple.com>
349
350         UIProcess crash when a prewarmed process is terminated
351         https://bugs.webkit.org/show_bug.cgi?id=196451
352         <rdar://problem/49245471>
353
354         Reviewed by Geoffrey Garen.
355
356         Add API test coverage.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
359         (TEST):
360
361 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
362
363         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
364         https://bugs.webkit.org/show_bug.cgi?id=196449
365
366         Reviewed by Lucas Forschler.
367
368         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
369         (StatusBubble.get_os_details): Method to get OS and Xcode details.
370         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
371         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
372
373 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
374
375         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
376         https://bugs.webkit.org/show_bug.cgi?id=196444
377
378         Reviewed by Lucas Forschler.
379
380         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
381
382 2019-04-01  Alex Christensen  <achristensen@webkit.org>
383
384         Add SPI to canonicalize NSURLs with WTF::URL
385         https://bugs.webkit.org/show_bug.cgi?id=196415
386         <rdar://problem/44980271>
387
388         Reviewed by Darin Adler.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
392         (TestWebKitAPI::TEST):
393
394 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
395
396         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
397         https://bugs.webkit.org/show_bug.cgi?id=196441
398
399         Reviewed by Carlos Garcia Campos.
400
401         Don't cache the wpe_view_backend object that might not exist yet at the
402         time of EventSenderProxy constructor invocation, but instead retrieve
403         that object whenever it's required for event dispatching. This should
404         avoid crashes in this constructor now that it's invoked before any
405         PlatformWindow has been set up (as changed in r243496).
406
407         * WebKitTestRunner/EventSenderProxy.h:
408         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
409         (WTR::viewBackend):
410         (WTR::EventSenderProxy::EventSenderProxy):
411         (WTR::EventSenderProxy::mouseDown):
412         (WTR::EventSenderProxy::mouseUp):
413         (WTR::EventSenderProxy::mouseMoveTo):
414         (WTR::EventSenderProxy::mouseScrollBy):
415         (WTR::EventSenderProxy::keyDown):
416         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
417
418 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
419
420         [Win][WebKit] MiniBrowser should support high DPI display
421         https://bugs.webkit.org/show_bug.cgi?id=196391
422
423         Reviewed by Alex Christensen.
424
425         * MiniBrowser/win/WebKitBrowserWindow.cpp:
426         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
427         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
428         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
429
430 2019-03-31  Sam Weinig  <weinig@apple.com>
431
432         Remove more i386 specific configurations
433         https://bugs.webkit.org/show_bug.cgi?id=196430
434
435         Reviewed by Alexey Proskuryakov.
436
437         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
438         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
439
440 2019-03-31  Andy Estes  <aestes@apple.com>
441
442         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
443         https://bugs.webkit.org/show_bug.cgi?id=196433
444         <rdar://problem/49293305>
445
446         Reviewed by Tim Horton.
447
448         Enhanced API test coverage to include all navigation response policy decisions in both
449         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
450
451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
452         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
455         (readFile):
456         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
457         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
458         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
459         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
460         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
461         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
462         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
463         (-[QuickLookDelegate _downloadDidStart:]):
464         (-[QuickLookDelegate _download:didReceiveResponse:]):
465         (-[QuickLookDelegate _download:didReceiveData:]):
466         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
467         (-[QuickLookDelegate _downloadDidFinish:]):
468         (-[QuickLookDelegate _download:didFailWithError:]):
469         (-[QuickLookDelegate _downloadDidCancel:]):
470         (-[QuickLookDelegate verifyDownload]):
471         (runTest):
472         (runTestDecideBeforeLoading):
473         (runTestDecideAfterLoading):
474         (TEST):
475         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
476         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
477         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
478         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
479         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
480         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
481         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
482         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
483         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
484         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
485         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
486         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
487         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
488         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
489
490 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
491
492         [CMake] add testdfg as target with build-jsc
493         https://bugs.webkit.org/show_bug.cgi?id=196393
494
495         Reviewed by Saam Barati.
496
497         Added testdfg as one of the targets to build when
498         using CMake.
499
500         * Scripts/build-jsc:
501
502 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
503
504         Delete WebMetal implementation in favor of WebGPU
505         https://bugs.webkit.org/show_bug.cgi?id=195418
506
507         Reviewed by Dean Jackson.
508
509         * DumpRenderTree/mac/DumpRenderTree.mm:
510         (enableExperimentalFeatures):
511         (resetWebPreferencesToConsistentValues):
512         * Scripts/webkitperl/FeatureList.pm:
513         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
515         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
516         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
517         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
518         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
519         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
520         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
521         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
522         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
523         (WTR::InjectedBundle::beginTesting):
524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
525         (WTR::TestRunner::setWebMetalEnabled): Deleted.
526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
527
528 2019-03-29  Chris Dumez  <cdumez@apple.com>
529
530         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
531         https://bugs.webkit.org/show_bug.cgi?id=196405
532         <rdar://problem/49428130>
533
534         Reviewed by Wenson Hsieh.
535
536         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
537         the popover presentation methods to be no-ops. Use this in the new test added in
538         r243523 so that we do not swizzle those methods for all tests. This is needed because
539         those WatchOS tests rely on the popover getting presented and interactive.
540
541         * WebKitTestRunner/TestController.cpp:
542         (WTR::updateTestOptionsFromTestHeader):
543         * WebKitTestRunner/TestController.h:
544         * WebKitTestRunner/TestOptions.h:
545         (WTR::TestOptions::hasSameInitializationOptions const):
546         * WebKitTestRunner/ios/TestControllerIOS.mm:
547         (WTR::TestController::platformInitialize):
548         (WTR::TestController::platformResetStateToConsistentValues):
549
550 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
551
552         [Curl] Add Server Trust Evaluation Support.
553         https://bugs.webkit.org/show_bug.cgi?id=191646
554
555         Reviewed by Fujii Hironori.
556
557         Implemented MiniBrowser UI for asking if user trusts the server.
558
559         * MiniBrowser/win/Common.cpp:
560         (askServerTrustEvaluation):
561         (replaceString):
562         * MiniBrowser/win/Common.h:
563         * MiniBrowser/win/MiniBrowserLib.rc:
564         * MiniBrowser/win/MiniBrowserLibResource.h:
565         * MiniBrowser/win/WebKitBrowserWindow.cpp:
566         (createPEMString):
567         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
568         (WebKitBrowserWindow::canTrustServerCertificate):
569         * MiniBrowser/win/WebKitBrowserWindow.h:
570
571 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
572
573         Implement ResizeObserver.
574         https://bugs.webkit.org/show_bug.cgi?id=157743
575
576         Reviewed by Simon Fraser.
577
578         Support resizeObserverEnabled webPreferences.
579
580         * DumpRenderTree/TestOptions.cpp:
581         (TestOptions::TestOptions):
582         * DumpRenderTree/TestOptions.h:
583         * DumpRenderTree/mac/DumpRenderTree.mm:
584         (setWebPreferencesForTestOptions):
585         * DumpRenderTree/win/DumpRenderTree.cpp:
586         (enableExperimentalFeatures):
587         * Scripts/webkitperl/FeatureList.pm:
588         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
589
590 2019-03-28  John Wilander  <wilander@apple.com>
591
592         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
593         https://bugs.webkit.org/show_bug.cgi?id=196281
594         <rdar://problem/48938748>
595
596         Reviewed by Alex Christensen.
597
598         This patch adds the function isStatisticsHasLocalStorage() to the
599         TestRunner. With it, the page can query the WebsiteDataStore in the
600         UI process to make sure that it sees LocalStorage.
601
602         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
604         (WTR::TestRunner::isStatisticsHasLocalStorage):
605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
606         * WebKitTestRunner/TestController.cpp:
607         (WTR::TestController::isStatisticsHasLocalStorage):
608         * WebKitTestRunner/TestController.h:
609         * WebKitTestRunner/TestInvocation.cpp:
610         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
611
612 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
613
614         API::Data::createWithoutCopying should do a null check before calling CFRelease
615         https://bugs.webkit.org/show_bug.cgi?id=196276
616         <rdar://problem/48059859>
617
618         Reviewed by Alex Christensen.
619
620         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
621
622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
623         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
624         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
625         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
626         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
627         (TestWebKitAPI::TEST):
628
629 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
630
631         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
632         https://bugs.webkit.org/show_bug.cgi?id=186276
633
634         Reviewed by Carlos Garcia Campos.
635
636         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
637         (webViewLoadChanged):
638         (testWebResourceGetDataError):
639         (testWebResourceGetDataEmpty):
640         (beforeAll):
641         (webViewloadChanged): Deleted.
642
643 2019-03-27  Andy Estes  <aestes@apple.com>
644
645         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
646         https://bugs.webkit.org/show_bug.cgi?id=196317
647
648         Reviewed by Dan Bernstein.
649
650         package-root copies built products into a staging directory using ditto(1), which does not
651         follow symbolic links as it traverses a directory. Now that the files in
652         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
653         itself, these become broken links when ditto'd into the staging directory.
654
655         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
656
657         * Scripts/package-root:
658
659 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews-app] Update display text of Submit for ews analysis
662         https://bugs.webkit.org/show_bug.cgi?id=196309
663
664         Reviewed by Dewei Zhu.
665
666         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
667
668 2019-03-27  David Kilzer  <ddkilzer@apple.com>
669
670         run-webkit-tests should check for leaks in WebKit processes
671         <https://webkit.org/b/193772>
672         <rdar://problem/46526680>
673
674         Reviewed by Ryosuke Niwa.
675
676         This works by doing the following:
677         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
678           The list of child processes are returned one per line:
679           process.name: pid
680         - Run the "#LIST CHILD PROCESSES" command just before the
681           "#CHECK FOR WORLD LEAKS" command, and store the list of child
682           processes on the ServerProcess object.
683         - When the `--leaks` switch is handled, run check_for_leaks() on
684           each child process after the main test harness.
685
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         (handleControlCommand):
688         - Use strncmp() instead of strcmp().
689         - Add support for handling "#LIST CHILD PROCESSES" command.
690
691         * Scripts/webkitpy/port/base.py:
692         (Port.check_for_leaks):
693         * Scripts/webkitpy/port/darwin.py:
694         (DarwinPort.check_for_leaks):
695         - Rename redundant 'process_pid' argument to 'process_id'.
696
697         * Scripts/webkitpy/port/driver.py:
698         (Driver.do_post_tests_work):
699         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
700           longer the only command this sends to WebKitTestRunner.
701         - If the `--leaks` switch is present, send the
702           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
703           result using Port.set_webkit_processes().
704         (Driver._parse_child_processes_output):
705         - Add helper method to parse list of child process names and
706           process IDs returned from WebKitTestRunner.
707
708         * Scripts/webkitpy/port/ios_device.py:
709         (IOSDevicePort.check_for_leaks):
710         - Rename redundant 'process_pid' argument to 'process_id'.
711
712         * Scripts/webkitpy/port/leakdetector.py:
713         (LeakDetector._parse_leaks_output):
714         - Return early if there is no leaks_output.
715         (LeakDetector.check_for_leaks):
716         - Rename redundant 'process_pid' argument to 'process_id'.
717
718         * Scripts/webkitpy/port/server_process.py:
719         (ServerProcess.__init__):
720         (ServerProcess.child_processes):
721         (ServerProcess.set_child_processes):
722         - Add instance variable to Port to store list of child process
723           names and process IDs returned from WebKitTestRunner.
724         (ServerProcess._start):
725         - Clear self._child_processes.
726         (ServerProcess.stop):
727         - If self._child_processes is set, call
728           self._port.check_for_leaks() for each child process.
729
730         * Scripts/webkitpy/port/server_process_unittest.py:
731         (TrivialMockPort.check_for_leaks):
732         - Rename redundant 'process_pid' argument to 'process_id'.
733
734         * Scripts/webkitpy/port/simulator_process.py:
735         (SimulatorProcess.stop):
736         - If self._child_processes is set, call
737           self._port.check_for_leaks() for each child process.
738
739         * Scripts/webkitpy/port/watch_device.py:
740         (WatchDevicePort.check_for_leaks):
741         - Rename redundant 'process_pid' argument to 'process_id'.
742
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::TestController::dumpResponse):
745         - Extract method from findAndDumpWorldLeaks() so that it may be
746           reused by findAndDumpWebKitProcessIdentifiers().
747         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
748         - Add method to output process name and process ID of both the
749           WebContent and Networking processes.
750         (WTR::TestController::findAndDumpWorldLeaks):
751         - Fix missing newline in output when there were no abandoned
752           documents.
753         - Call dumpResponse() for extracted code.
754         (WTR::TestController::handleControlCommand):
755         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
756         - Use strncmp() instead of strcmp().
757         - Call findAndDumpWebKitProcessIdentifiers() when
758           "#LIST CHILD PROCESSES" command is sent.
759         * WebKitTestRunner/TestController.h:
760         (WTR::TestController::dumpResponse):
761         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
762         - Declare methods.
763
764 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
765
766         Unreviewed. Add GLib API test cases after r243434.
767
768         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
769         (testWebViewActiveURI):
770         (serverCallback):
771         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
772         (sendRequestCallback):
773
774 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         Geolocation request not complete when watch request was started in a different web process
777         https://bugs.webkit.org/show_bug.cgi?id=195996
778
779         Reviewed by Alex Christensen.
780
781         Add a test case.
782
783         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
784         (TestWebKitAPI::runJavaScriptAlert):
785         (TestWebKitAPI::TEST):
786
787 2019-03-26  Keith Rollin  <krollin@apple.com>
788
789         Update the way generate-xcfilelists returns strings from functions
790         https://bugs.webkit.org/show_bug.cgi?id=195975
791         <rdar://problem/49040807>
792
793         Reviewed by Dean Jackson.
794
795         There are places where generate-xcfilelists executes assignments with
796         statements like:
797
798             FOO=$(some_function)
799
800         where "some_function" return a string by echoing it. E.g.
801
802             some_function()
803             {
804                 echo "Hello, World"
805             }
806
807         This is a common idiom, but it has a problem if "some_function" needs
808         to call "exit" in an attempt to halt the entire script right then and
809         there. Since "some_function" is called inside of $(), it's being
810         executed in a sub-shell. Calling exit in that sub-shell simply exits
811         that shell; it doesn't not exit the outer shell in which the main part
812         of the script is still running. As such, the main script keeps
813         executing when the intent was for the script to halt.
814
815         The solution to this is to use a different idiom for returning
816         strings. The one we now is to pass in the name of the variable to
817         receive the string result:
818
819             some_function()
820             {
821                 variable_name=$1
822                 eval $variable_name ="Hello, World"
823             }
824
825         The call site now looks like
826
827             some_function FOO
828
829         Because there's no invocation of a sub-shell, some_function can now
830         call "exit" if it wants to, and the entire script will exit at that
831         point.
832
833         * Scripts/generate-xcfilelists:
834
835 2019-03-26  Chris Dumez  <cdumez@apple.com>
836
837         Add basic layout test coverage for File Picker on iOS
838         https://bugs.webkit.org/show_bug.cgi?id=196265
839
840         Reviewed by Wenson Hsieh.
841
842         Add layout test infrastructure to test the file picker on iOS.
843
844         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
845         (WTR::UIScriptController::dismissFilePicker):
846         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
847         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
848         (WTR::UIScriptController::dismissFilePicker):
849         * TestRunnerShared/UIScriptContext/UIScriptController.h:
850         * WebKitTestRunner/TestController.cpp:
851         (WTR::TestController::createWebViewWithOptions):
852         (WTR::updateTestOptionsFromTestHeader):
853         * WebKitTestRunner/TestOptions.h:
854         (WTR::TestOptions::hasSameInitializationOptions const):
855         * WebKitTestRunner/ios/TestControllerIOS.mm:
856         (overridePresentViewController):
857         (WTR::TestController::platformInitialize):
858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
859         (WTR::UIScriptController::dismissFilePicker):
860
861 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
862
863         Implement async paste method on UIWKInteractionViewProtocol
864         https://bugs.webkit.org/show_bug.cgi?id=196267
865         <rdar://problem/49236346>
866
867         Reviewed by Tim Horton.
868
869         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
870         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
871         are now a part of all iOS 12 internal SDKs.
872
873         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
874
875         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
876         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
877
878         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
879         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
880         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
881         * TestWebKitAPI/ios/UIKitSPI.h:
882
883 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-build] Use PostgreSQL for ews.webkit.org database
886         https://bugs.webkit.org/show_bug.cgi?id=196270
887
888         Reviewed by Lucas Forschler.
889
890         * BuildSlaveSupport/ews-app/ews-app/settings.py:
891
892 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
893
894         [ews] Reset simctl states on reboot
895         https://bugs.webkit.org/show_bug.cgi?id=196260
896
897         Rubber-stamped by Aakash Jain.
898
899         * EWSTools/start-queue-mac.sh:
900
901 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
902
903         [ews-build] Use PostgreSQL for ews-build database
904         https://bugs.webkit.org/show_bug.cgi?id=196229
905
906         Reviewed by Lucas Forschler.
907
908         * BuildSlaveSupport/ews-build/master.cfg:
909
910 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
911
912         [ews-build] Get master_hostname dynamically in master.cfg
913         https://bugs.webkit.org/show_bug.cgi?id=196255
914
915         Reviewed by Lucas Forschler.
916
917         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
918         send events data in test mode.
919
920 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-app] Set db_constraint to False for Foreign Keys
923         https://bugs.webkit.org/show_bug.cgi?id=196252
924
925         Reviewed by Lucas Forschler.
926
927         * BuildSlaveSupport/ews-app/ews/models/build.py:
928         * BuildSlaveSupport/ews-app/ews/models/step.py:
929
930 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
931
932         [ews-build] is_test_mode_enabled should default to True
933         https://bugs.webkit.org/show_bug.cgi?id=196248
934
935         Reviewed by Lucas Forschler.
936
937         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
938
939 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-app] Add webkitperl to ENABLED_QUEUES
942         https://bugs.webkit.org/show_bug.cgi?id=196253
943
944         Reviewed by Lucas Forschler.
945
946         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
947
948 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
949
950         Address NSWindow sometimes using WebKitTestRunnerEvent too early
951         https://bugs.webkit.org/show_bug.cgi?id=196211
952         rdar://problem/49110552
953
954         Reviewed by Tim Horton.
955
956         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
957         Make sure that EventSenderProxy always exists when running tests. We used to create
958         it when resetting before the first test, which is a bit too late.
959
960         * WebKitTestRunner/TestController.h:
961         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
962         (WTR::TestController::platformCreateWebView):
963         (WTR::TestController::platformCreateOtherPage):
964         (WTR::TestController::finishCreatingPlatformWebView):
965         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
966         (WTR::PlatformWebView::PlatformWebView):
967         Moved some code that made NSWindow use NSEvent during web view creation. We may
968         need to move more if some other case us found, but this is enough for now.
969
970 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
971
972         Unreviewed. Fix typo in GLib geolocation API after r243285.
973
974         gelocation -> geolocation.
975
976         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
977         (testGeolocationManagerWatchPosition):
978
979 2019-03-25  Alex Christensen  <achristensen@webkit.org>
980
981         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
982         https://bugs.webkit.org/show_bug.cgi?id=196213
983
984         Reviewed by Geoff Garen.
985
986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
987         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
988         (credentialWithIdentityAndKeychainPath):
989         (-[ChallengeDelegate webView:didFinishNavigation:]):
990         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
991         (TestWebKitAPI::TEST):
992
993 2019-03-25  Alex Christensen  <achristensen@webkit.org>
994
995         Expected shouldn't assume its contained types are copyable
996         https://bugs.webkit.org/show_bug.cgi?id=195986
997
998         Reviewed by JF Bastien.
999
1000         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1001         (TestWebKitAPI::NonCopyable::operator== const):
1002         (TestWebKitAPI::NonCopyable::operator!= const):
1003         (TestWebKitAPI::TEST):
1004
1005 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1006
1007         Remove some now-unnecessary dynamic class lookup
1008         https://bugs.webkit.org/show_bug.cgi?id=196237
1009
1010         Reviewed by Simon Fraser.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1013         (makeRequest):
1014         (TEST):
1015
1016 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1017
1018         Unreviewed, rolling out r243450.
1019
1020         AppleWin and WinCairo port builds get broken.
1021
1022         Reverted changeset:
1023
1024         "Add test for fix of #196095"
1025         https://bugs.webkit.org/show_bug.cgi?id=196097
1026         https://trac.webkit.org/changeset/243450
1027
1028 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1029
1030         Unreviewed, rolling out r243465.
1031         https://bugs.webkit.org/show_bug.cgi?id=196226
1032
1033         the test doesn't build (Requested by thorton on #webkit).
1034
1035         Reverted changeset:
1036
1037         "Do not terminate the NetworkProcess if a third party
1038         application sends a NSCredential with a SecIdentityRef"
1039         https://bugs.webkit.org/show_bug.cgi?id=196213
1040         https://trac.webkit.org/changeset/243465
1041
1042 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1043
1044         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1045         https://bugs.webkit.org/show_bug.cgi?id=196213
1046
1047         Reviewed by Geoff Garen.
1048
1049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1050         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1051         (credentialWithIdentityAndKeychainPath):
1052         (-[ChallengeDelegate webView:didFinishNavigation:]):
1053         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1054         (TestWebKitAPI::TEST):
1055
1056 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1057
1058         [ews-build] Gracefully handle missing patch_id in events
1059         https://bugs.webkit.org/show_bug.cgi?id=196216
1060
1061         Reviewed by Lucas Forschler.
1062
1063         * BuildSlaveSupport/ews-build/events.py:
1064
1065 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1066
1067         [ews-build] use lz4 compression for improving buildbot performance
1068         https://bugs.webkit.org/show_bug.cgi?id=196155
1069
1070         Reviewed by Lucas Forschler.
1071
1072         * BuildSlaveSupport/ews-build/master.cfg:
1073
1074 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1075
1076         Pull some API testing helper methods out of TestWKWebView
1077         https://bugs.webkit.org/show_bug.cgi?id=196212
1078
1079         Reviewed by Tim Horton.
1080
1081         Refactor some more API testing utility methods, so that they can be used in
1082         tests that do not use TestWKWebView.
1083
1084         * TestWebKitAPI/cocoa/TestWKWebView.h:
1085         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1086         (-[WKWebView loadTestPageNamed:]):
1087         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1088         (-[WKWebView synchronouslyLoadHTMLString:]):
1089         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1090         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1091         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1092         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1093         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1094
1095 2019-03-25  Jer Noble  <jer.noble@apple.com>
1096
1097         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1098         https://bugs.webkit.org/show_bug.cgi?id=196097
1099
1100         Reviewed by Eric Carlson.
1101
1102         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1103
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         (resetWebPreferencesToConsistentValues):
1106         * WebKitTestRunner/TestController.cpp:
1107         (WTR::TestController::resetPreferencesToConsistentValues):
1108
1109 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         Pull IPadUserInterfaceSwizzler out into a separate header file
1112         https://bugs.webkit.org/show_bug.cgi?id=196193
1113
1114         Reviewed by Anders Carlsson.
1115
1116         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1117         be used in other API tests.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1121         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1122         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1123         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1124         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1125         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1126
1127 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1128
1129         Remove NavigatorContentUtils in WebCore/Modules
1130         https://bugs.webkit.org/show_bug.cgi?id=196070
1131
1132         Reviewed by Alex Christensen.
1133
1134         NavigatorContentUtils was to support the custom scheme spec [1].
1135         However, in WebKit side, no port has supported the feature in
1136         WebKit layer after EFL port was removed. So there has been the
1137         only IDL implementation of the NavigatorContentUtils in WebCore.
1138         So we don't need to keep the implementation in WebCore anymore.
1139
1140         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1141
1142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1143
1144 2019-03-24  Andy Estes  <aestes@apple.com>
1145
1146         [watchOS] Remove unused Proximity Networking code
1147         https://bugs.webkit.org/show_bug.cgi?id=196188
1148
1149         Reviewed by Tim Horton.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1152         (TEST):
1153
1154 2019-03-23  Keith Miller  <keith_miller@apple.com>
1155
1156         Refactor clz/ctz and fix getLSBSet.
1157         https://bugs.webkit.org/show_bug.cgi?id=196162
1158
1159         Reviewed by Saam Barati.
1160
1161         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1162
1163         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1164         (TestWebKitAPI::TEST):
1165
1166 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1167
1168         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1169         https://bugs.webkit.org/show_bug.cgi?id=196143
1170
1171         Reviewed by Michael Catanzaro.
1172
1173         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1174         directories.
1175
1176         * Scripts/webkitpy/style/checkers/cpp.py:
1177         (check_identifier_name_in_declaration):
1178         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1179         (WebKitStyleTest.test_names):
1180
1181 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1182
1183         [Flatpak] Manifest expanding fails for qt WPE extension
1184         https://bugs.webkit.org/show_bug.cgi?id=196148
1185
1186         Reviewed by Alex Christensen.
1187
1188         * flatpak/flatpakutils.py:
1189         (expand_submodules_recurse): The last recurse manifest expand
1190         iteration might lead to a single module so take it into account
1191         and don't try to recurse further.
1192
1193 2019-03-22  Chris Dumez  <cdumez@apple.com>
1194
1195         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1196         https://bugs.webkit.org/show_bug.cgi?id=195348
1197         <rdar://problem/48622090>
1198
1199         Reviewed by Alex Christensen.
1200
1201         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1202         to NO when test.options().shouldIgnoreMetaViewport is false.
1203
1204         * WebKitTestRunner/ios/TestControllerIOS.mm:
1205         (WTR::TestController::platformConfigureViewForTest):
1206
1207 2019-03-22  Chris Dumez  <cdumez@apple.com>
1208
1209         Prewarmed processes should be usable with any website data store
1210         https://bugs.webkit.org/show_bug.cgi?id=196104
1211
1212         Reviewed by Alex Christensen.
1213
1214         Add API test coverage.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1217         (runInitialWarmedProcessUsedTest):
1218         (TEST):
1219
1220 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1221
1222         Back out local changes to Alex's Subversion working directory
1223
1224         They were accidentally committed.
1225
1226         * Scripts/webkitpy/common/system/abstractexecutive.py:
1227         (AbstractExecutive.wait_newest):
1228         * Scripts/webkitpy/common/system/executive.py:
1229         (Executive.running_pids):
1230         * Scripts/webkitpy/common/system/executive_mock.py:
1231         (MockExecutive.running_pids):
1232         * Scripts/webkitpy/common/system/executive_unittest.py:
1233         (ExecutiveTest.serial_test_running_pids):
1234         * Scripts/webkitpy/port/darwin.py:
1235         (DarwinPort.check_for_leaks):
1236         * Scripts/webkitpy/port/leakdetector.py:
1237         (LeakDetector.check_for_leaks):
1238         - This was the hack attached to Bug 193772.
1239
1240         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1241         (+[WebKitTestRunnerEvent mouseLocation]):
1242         - This works around a crash on an internal build.
1243
1244 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1245
1246         Fix the build after r243354
1247         https://bugs.webkit.org/show_bug.cgi?id=196138
1248         <rdar://problem/49145951>
1249
1250         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1251         (TEST):
1252         * TestWebKitAPI/ios/UIKitSPI.h:
1253
1254 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1255
1256         Adopt UIWKDocumentContext
1257         https://bugs.webkit.org/show_bug.cgi?id=196040
1258         <rdar://problem/48642440>
1259
1260         Reviewed by Ryosuke Niwa.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1264         (makeRequest):
1265         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1266         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1267         (applyStyle):
1268         (TEST):
1269         Add tests for UIWKDocumentContext.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1272         (TEST):
1273         (recursiveFindWKContentView): Deleted.
1274         * TestWebKitAPI/cocoa/TestWKWebView.h:
1275         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1276         (recursiveFindWKContentView):
1277         (-[TestWKWebView wkContentView]):
1278         * TestWebKitAPI/ios/UIKitSPI.h:
1279         Share the WKContentView finding code between tests.
1280
1281 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1282
1283         [iOS WK2] Turn on async overflow scrolling by default
1284         https://bugs.webkit.org/show_bug.cgi?id=196011
1285         rdar://problem/48453859
1286
1287         Reviewed by Antti Koivisto.
1288         
1289         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1290         since so many basic layout tests have different results when compositing is triggered for
1291         overflow.
1292         
1293         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1294
1295         * WebKitTestRunner/TestController.cpp:
1296         (WTR::TestController::resetPreferencesToConsistentValues):
1297
1298 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-build] Retry API test in case of failures
1301         https://bugs.webkit.org/show_bug.cgi?id=196004
1302
1303         Reviewed by Lucas Forschler.
1304
1305         * BuildSlaveSupport/ews-build/steps.py:
1306         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1307         (CompileWebKitToT.doStepIf): Ditto.
1308         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1309         (ReRunAPITests): Re-run API tests.
1310         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1311         (RunAPITestsWithoutPatch): Run API tests without patch.
1312         (RunAPITestsWithoutPatch.doStepIf):
1313         (RunAPITestsWithoutPatch.hideStepIf):
1314         (RunAPITestsWithoutPatch.evaluateCommand):
1315         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1316         (AnalyzeAPITestsResults.start):
1317         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1318         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1319         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1320         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1321
1322 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-build] Update queues configurations
1325         https://bugs.webkit.org/show_bug.cgi?id=196074
1326
1327         Reviewed by Dewei Zhu.
1328
1329         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1330         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1331
1332 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1333
1334         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1335         https://bugs.webkit.org/show_bug.cgi?id=195680
1336         <rdar://problem/48903534>
1337
1338         Unreviewed infrastructure fix.
1339
1340         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1341         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1342
1343 2019-03-21  Andy Estes  <aestes@apple.com>
1344
1345         [iOS] Apple Pay should be available in documents with no user agent scripts
1346         https://bugs.webkit.org/show_bug.cgi?id=196061
1347         <rdar://problem/48649391>
1348
1349         Reviewed by Brady Eidson.
1350
1351         Added API tests and related infrastructure.
1352
1353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1354         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1355         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1356         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1357         (TestWebKitAPI::TEST):
1358         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1359         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1360         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1361         * TestWebKitAPI/cocoa/TestProtocol.mm:
1362         (-[TestProtocol startLoading]):
1363         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1364         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1365         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1366         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1367
1368 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1369
1370         REGRESSSION (r243297): webkitpy tests broken
1371         https://bugs.webkit.org/show_bug.cgi?id=196108
1372
1373         Reviewed by Aakash Jain.
1374
1375         r243297 updated contributors.json, which broke a few unit tests.
1376
1377         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1378         (IRCCommandTest.test_whois):
1379         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1380
1381 2019-03-21  Chris Dumez  <cdumez@apple.com>
1382
1383         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1384         https://bugs.webkit.org/show_bug.cgi?id=196041
1385         <rdar://problem/49083230>
1386
1387         Reviewed by Alex Christensen.
1388
1389         Add API test coverage.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1392         (TEST):
1393
1394 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1395
1396         Add SPI to inform applications of WKContentRuleList actions
1397         https://bugs.webkit.org/show_bug.cgi?id=195965
1398         <rdar://problem/42664365>
1399
1400         Reviewed by Geoff Garen.
1401
1402         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1403         (TestWebKitAPI::allActionsForResourceLoad):
1404         (TestWebKitAPI::testRequest):
1405         (TestWebKitAPI::TEST_F):
1406         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1407         (Notification::description):
1408         (Notification::operator== const):
1409         (toVector):
1410         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1411         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1412         (makeContentRuleList):
1413         (TEST):
1414         (makeWarnContentRuleList): Deleted.
1415
1416 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1417
1418         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1419         https://bugs.webkit.org/show_bug.cgi?id=196088
1420
1421         Reviewed by Brian Burg.
1422
1423         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1424         Support checks when only one platform is specified. Also deprecate macosx() and
1425         force the use of macos() instead.
1426
1427         * Scripts/webkitpy/style/checkers/cpp.py:
1428         (check_min_versions_of_wk_api_available):
1429         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1430         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1431
1432 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1433
1434         Update status inactive committers' status to 'contributor'.
1435
1436         * Scripts/webkitpy/common/config/contributors.json:
1437
1438 2019-03-21  Xan Lopez  <xan@igalia.com>
1439
1440         [JSC][x86] Drop support for x87 floating point
1441         https://bugs.webkit.org/show_bug.cgi?id=194853
1442
1443         Reviewed by Don Olmstead.
1444
1445         Force SSE2 on x86/32bit builds.
1446
1447         * Scripts/webkitdirs.pm:
1448         (generateBuildSystemFromCMakeProject):
1449
1450 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1451
1452         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1453         https://bugs.webkit.org/show_bug.cgi?id=196073
1454
1455         Reviewed by Michael Catanzaro.
1456
1457         Add test cases to check functions and constructors with no arguments but receiving user data.
1458
1459         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1460         (checkUserData):
1461         (testJSCFunction):
1462         (fooCreateWithUserData):
1463         (testJSCClass):
1464
1465 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1468
1469         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1470
1471         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1472
1473 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1474
1475         [GTK][WPE] Add API to provide geolocation information
1476         https://bugs.webkit.org/show_bug.cgi?id=195940
1477
1478         Reviewed by Michael Catanzaro.
1479
1480         Add a new test to check the new API.
1481
1482         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1483         (testGeolocationManagerCurrentPosition):
1484         (testGeolocationManagerWatchPosition):
1485         (beforeAll):
1486         (afterAll):
1487         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1488         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1489         (beforeAll): Ditto.
1490         * TestWebKitAPI/glib/CMakeLists.txt:
1491
1492 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1493
1494         [GLib] Returning G_TYPE_OBJECT from a method does not work
1495         https://bugs.webkit.org/show_bug.cgi?id=195574
1496
1497         Reviewed by Michael Catanzaro.
1498
1499         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1500
1501         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1502         (getGFile):
1503         (getParent):
1504         (createGString):
1505         (getGString):
1506         (getGStringCopyWillRaise):
1507         (getGStringCopy):
1508         (getGStringStr):
1509         (getGStringLen):
1510         (freeGString):
1511         (testJSCClass):
1512
1513 2019-03-20  Saam Barati  <sbarati@apple.com>
1514
1515         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1516         https://bugs.webkit.org/show_bug.cgi?id=195721
1517
1518         Reviewed by Filip Pizlo.
1519
1520         * Scripts/run-javascriptcore-tests:
1521
1522 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1523
1524         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1525         https://bugs.webkit.org/show_bug.cgi?id=196049
1526
1527         Reviewed by Tim Horton.
1528
1529         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1530         overflow scrolling in general, so rename it.
1531
1532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1533
1534 2019-03-20  Daniel Bates  <dabates@apple.com>
1535
1536         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1537         https://bugs.webkit.org/show_bug.cgi?id=196031
1538         <rdar://problem/49078172>
1539
1540         Reviewed by Tim Horton.
1541
1542         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1543         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1544         same code path used when the Done button is pressed to dismiss the <select> picker.
1545
1546         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1547         (TestWebKitAPI::TEST):
1548
1549 2019-03-20  Chris Dumez  <cdumez@apple.com>
1550
1551         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1552         https://bugs.webkit.org/show_bug.cgi?id=196029
1553         <rdar://problem/48954651>
1554
1555         Reviewed by Tim Horton.
1556
1557         Add API test coverage.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1560
1561 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1562
1563         [ews-build] Improve failure summary string for ApplyPatch step
1564         https://bugs.webkit.org/show_bug.cgi?id=195995
1565
1566         Reviewed by Alexey Proskuryakov.
1567
1568         * BuildSlaveSupport/ews-build/steps.py:
1569         (ApplyPatch.getResultSummary): Override getResultSummary.
1570
1571 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1572
1573         AX: Implement support for new meter ARIA role
1574         https://bugs.webkit.org/show_bug.cgi?id=195966
1575
1576         Reviewed by Chris Fleizach.
1577
1578         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1579         to AXLevelIndicator.
1580
1581         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1582
1583 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1584
1585         [WebAuthN] Implement FIDO AppID extension
1586         https://bugs.webkit.org/show_bug.cgi?id=143491
1587         <rdar://problem/48298273>
1588
1589         Reviewed by Brent Fulgham.
1590
1591         Add a test that covers the new flag of convertToU2fSignCommand.
1592
1593         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1594         (TestWebKitAPI::TEST):
1595         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1596         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1597         (TestWebKitAPI::TEST):
1598
1599 2019-03-19  Keith Rollin  <krollin@apple.com>
1600
1601         Add support for more platforms to generate-xcfilelists
1602         https://bugs.webkit.org/show_bug.cgi?id=195977
1603
1604         Reviewed by Alexey Proskuryakov.
1605
1606         generate-xcfilelists incorrectly complains when involved with building
1607         WebKit for iphonesimulator:
1608
1609             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1610             …
1611             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1612
1613         Address this by teaching generate-xcfilelists about more platforms.
1614
1615         * Scripts/generate-xcfilelists:
1616
1617 2019-03-19  John Wilander  <wilander@apple.com>
1618
1619         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1620         https://bugs.webkit.org/show_bug.cgi?id=195923
1621         <rdar://problem/49001272>
1622
1623         Reviewed by Alex Christensen.
1624
1625         This patch does the following to the TestRunner:
1626         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1627         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1628         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1629
1630         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1631         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1632         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1633         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1634         * WebKitTestRunner/TestController.cpp:
1635         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1636         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1637         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1638         * WebKitTestRunner/TestController.h:
1639         * WebKitTestRunner/TestInvocation.cpp:
1640         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1641
1642 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1643
1644         [CMake] Support more clang and gcc sanitizers
1645         https://bugs.webkit.org/show_bug.cgi?id=195956
1646
1647         Reviewed by Michael Catanzaro.
1648
1649         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1650
1651 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1652
1653         [ews-build] Improve summary for PrintConfiguration step
1654         https://bugs.webkit.org/show_bug.cgi?id=195945
1655
1656         Reviewed by Lucas Forschler.
1657
1658         * BuildSlaveSupport/ews-build/steps.py:
1659         (PrintConfiguration.getResultSummary): Override getResultSummary.
1660
1661 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1662
1663         [ews-build] Improve summary for CheckOutSource step
1664         https://bugs.webkit.org/show_bug.cgi?id=195963
1665
1666         Reviewed by Lucas Forschler.
1667
1668         * BuildSlaveSupport/ews-build/steps.py:
1669         (CheckOutSource.getResultSummary):
1670
1671 2019-03-19  Daniel Bates  <dabates@apple.com>
1672
1673         [iOS] Focus not preserved when switching between tabs
1674         https://bugs.webkit.org/show_bug.cgi?id=195820
1675         <rdar://problem/43614450>
1676
1677         Reviewed by Brent Fulgham.
1678
1679         Add tests to ensure that we restore focus when resigning and becoming first responder.
1680
1681         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1682         (TestWebKitAPI::TEST):
1683
1684 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1685
1686         Make WTFLogChannelState and WTFLogLevel enum classes
1687         https://bugs.webkit.org/show_bug.cgi?id=195904
1688
1689         Reviewed by Eric Carlson.
1690
1691         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1692         (TestWebKitAPI::TEST_F):
1693
1694 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1695
1696         [GStreamer][EME] Backported mssdemux protection data crash fix
1697         https://bugs.webkit.org/show_bug.cgi?id=195918
1698
1699         Reviewed by Philippe Normand.
1700
1701         * gstreamer/jhbuild.modules:
1702         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1703
1704 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1705
1706         Unreviewed, rolling out r243132.
1707
1708         Broke GTK build
1709
1710         Reverted changeset:
1711
1712         "Make WTFLogChannelState and WTFLogLevel enum classes"
1713         https://bugs.webkit.org/show_bug.cgi?id=195904
1714         https://trac.webkit.org/changeset/243132
1715
1716 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1717
1718         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1719
1720         * Scripts/webkitdirs.pm:
1721         (builtDylibPathForName): Adjust the shared library name that's changed
1722         with the API version bump in r243073.
1723
1724 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1725
1726         Make WTFLogChannelState and WTFLogLevel enum classes
1727         https://bugs.webkit.org/show_bug.cgi?id=195904
1728
1729         Reviewed by Eric Carlson.
1730
1731         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1732         (TestWebKitAPI::TEST_F):
1733
1734 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1735
1736         Disable flaky test added in r2431100
1737         https://webkit.org/b/195785
1738
1739         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1740         (TestWebKitAPI::TEST):
1741         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1742
1743 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1744
1745         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1746         https://bugs.webkit.org/show_bug.cgi?id=195916
1747
1748         Reviewed by Tim Horton.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1751         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1752
1753 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1754
1755         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1756
1757         * Scripts/webkitpy/common/config/contributors.json:
1758
1759 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1760
1761         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1762         https://bugs.webkit.org/show_bug.cgi?id=195785
1763
1764         Reviewed by Geoffrey Garen.
1765
1766         * TestWebKitAPI/TCPServer.cpp: Added.
1767         (TestWebKitAPI::TCPServer::TCPServer):
1768         (TestWebKitAPI::TCPServer::~TCPServer):
1769         (TestWebKitAPI::TCPServer::socketBindListen):
1770         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1771         * TestWebKitAPI/TCPServer.h: Added.
1772         (TestWebKitAPI::TCPServer::port const):
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1774         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1775         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1776         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1777         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1778         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1779         (TestWebKitAPI::respondSlowly):
1780         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1781         (TestWebKitAPI::downloadAtRate):
1782         (TestWebKitAPI::TEST):
1783
1784 2019-03-18  Saam Barati  <sbarati@apple.com>
1785
1786         Add a plan file for JetStream 2
1787         https://bugs.webkit.org/show_bug.cgi?id=190734
1788
1789         Reviewed by Mark Lam.
1790
1791         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1792
1793 2019-03-18  Chris Dumez  <cdumez@apple.com>
1794
1795         Delay WebProcess launch until a load is triggered in a Web view
1796         https://bugs.webkit.org/show_bug.cgi?id=195758
1797         <rdar://problem/48126013>
1798
1799         Reviewed by Geoff Garen.
1800
1801         Add API test coverage. Also update some existing API tests to not expect
1802         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1803
1804         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1805         (TestWebKitAPI::TEST):
1806         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1809         (TEST):
1810         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1811         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1812         (TEST):
1813         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1814         (TEST):
1815         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1816
1817 2019-03-18  Xan Lopez  <xan@igalia.com>
1818
1819         [CMake] Prevent potential warning when determining $architecture
1820         https://bugs.webkit.org/show_bug.cgi?id=195891
1821
1822         Reviewed by Michael Catanzaro.
1823
1824         It's possible for generateBuildSystemForCMakeProject to be called
1825         before determineArchitecture() is ever called. This will make the
1826         first eq check with $architecture to be bogus (and print a
1827         warning). Change that to an eq check with architecture(), which
1828         implicitly calls determineArchitecture() if needed, and change all
1829         the other similar cases in the method in the same way to prevent
1830         future bugs like this one.
1831
1832         * Scripts/webkitdirs.pm:
1833         (generateBuildSystemFromCMakeProject):
1834
1835 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1836
1837         [WPE] Tarballs generated with “make dist” cannot build documentation
1838         https://bugs.webkit.org/show_bug.cgi?id=195885
1839
1840         Reviewed by Carlos Garcia Campos.
1841
1842         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1843
1844 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1845
1846         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1847         https://bugs.webkit.org/show_bug.cgi?id=195883
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         * gtkdoc/gtkdoc.py:
1852         (GTKDoc._run_command): When commands fail to run, include the full command line for
1853         the program invocation and the output it has generated on the standard error stream.
1854
1855 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1856
1857         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1858         https://bugs.webkit.org/show_bug.cgi?id=195786
1859
1860         Reviewed by Philippe Normand.
1861
1862         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1863         * wpe/jhbuild.modules: Ditto.
1864
1865 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1866
1867         [ews-build] Don't run clean builds on EWS builders
1868         https://bugs.webkit.org/show_bug.cgi?id=195851
1869
1870         Reviewed by Geoffrey Garen.
1871
1872         * BuildSlaveSupport/ews-build/factories.py:
1873
1874 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1875
1876         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1877         https://bugs.webkit.org/show_bug.cgi?id=195849
1878
1879         Reviewed by Chris Dumez.
1880
1881         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1882
1883         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1884         (runWebsiteDataStoreCustomPaths):
1885
1886 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1887
1888         webkitpy: Upload test results
1889         https://bugs.webkit.org/show_bug.cgi?id=195755
1890         <rdar://problem/48896182>
1891
1892         Reviewed by Aakash Jain.
1893
1894         Establish a new format for uploading results that is not tied to layout tests, apply
1895         that format to webkitpy tests.
1896
1897         * Scripts/webkitpy/common/checkout/scm/git.py:
1898         (Git.native_branch): Return what branch the current checkout is on.
1899         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1900         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1901         * Scripts/webkitpy/common/checkout/scm/svn.py:
1902         (SVN.native_branch): Ditto.
1903         * Scripts/webkitpy/common/system/platforminfo.py:
1904         (PlatformInfo.build_version): Return a build version for Mac.
1905         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1906         (MockPlatformInfo.__init__):
1907         (MockPlatformInfo.build_version):
1908         * Scripts/webkitpy/results: Added.
1909         * Scripts/webkitpy/results/__init__.py: Added.
1910         * Scripts/webkitpy/results/options.py: Added.
1911         (upload_options): OptParse list for upload options.
1912         * Scripts/webkitpy/results/upload.py: Added.
1913         (Upload): Class which enforces the upload format expected by the results server.
1914         (Upload.Expectations):
1915         (Upload.create_configuration):
1916         (Upload.create_commit):
1917         (Upload.create_details):
1918         (Upload.create_run_stats):
1919         (Upload.create_test_result):
1920         (Upload.__init__):
1921         (Upload.Encoder): Encode Upload object as json.
1922         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1923         * Scripts/webkitpy/results/upload_unittest.py: Added.
1924         * Scripts/webkitpy/test/main.py:
1925         (Tester._parse_args): Add upload arguments.
1926         (Tester._run_tests): Allow results to be uploaded.
1927         * Scripts/webkitpy/test/runner.py:
1928         (Runner.__init__): Record which tests were run, rather than just counting them.
1929         (Runner.handle):
1930         * Scripts/webkitpy/test/runner_unittest.py:
1931         (RunnerTest.test_run):
1932         * Scripts/webkitpy/thirdparty/__init__.py:
1933         (AutoinstallImportHook.find_module): Add requests auto-install.
1934         (AutoinstallImportHook._install_requests):
1935         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1936         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1937
1938 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1939
1940         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1941         https://bugs.webkit.org/show_bug.cgi?id=195810
1942
1943         Reviewed by Tim Horton.
1944
1945         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1946         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1947         ending certain layout tests.
1948
1949         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1950         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1951         (-[TestRunnerWKWebView dealloc]):
1952         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1953
1954         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1955         helper method when destroying the web view, and when resetting state between tests.
1956
1957         * WebKitTestRunner/ios/TestControllerIOS.mm:
1958         (WTR::TestController::platformResetStateToConsistentValues):
1959
1960         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1961
1962 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1963
1964         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1965         https://bugs.webkit.org/show_bug.cgi?id=190350
1966         <rdar://problem/45089503>
1967
1968         Reviewed by Geoffrey Garen.
1969
1970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1971         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1972         (TEST):
1973         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1974         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1975         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1976         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1977         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1978         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1979         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1980         (runTest):
1981         (createDirectories):
1982         (TEST):
1983         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1984         (TEST):
1985         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1986         (TEST):
1987
1988 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1989
1990         Add support to WebPage for getting the contents as an attributed string.
1991         https://bugs.webkit.org/show_bug.cgi?id=195636
1992         rdar://problem/45055697
1993
1994         Reviewed by Tim Horton.
1995
1996         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1997         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1998
1999 2019-03-15  Chris Dumez  <cdumez@apple.com>
2000
2001         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2002         https://bugs.webkit.org/show_bug.cgi?id=195747
2003
2004         Reviewed by Geoff Garen.
2005
2006         Add API test coverage.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2009
2010 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2011
2012         Unreviewed, rolling out r242952.
2013
2014         Causing API failures on iOS Simulator
2015
2016         Reverted changeset:
2017
2018         "[PSON] Make sure the WebProcessCache is leverage when
2019         relaunching a process after termination"
2020         https://bugs.webkit.org/show_bug.cgi?id=195747
2021         https://trac.webkit.org/changeset/242952
2022
2023 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2024
2025         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2026         https://bugs.webkit.org/show_bug.cgi?id=195740
2027
2028         Reviewed by Ross Kirsling.
2029
2030         window.open doesn't work for WebKitBrowserWindow because it is not
2031         implemented yet.
2032
2033         1. Implemented createNewPage callback of WKPageUIClient.
2034         2. Changed MainWindow to take a BrowserWindow factory function
2035           instead of BrowserWindowType to be flexible to create
2036           BrowserWindow with extra settings.
2037         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2038           because it is not relevant with MainWindow anymore.
2039
2040         * MiniBrowser/win/Common.cpp:
2041         (parseCommandLine):
2042         * MiniBrowser/win/Common.h:
2043         (CommandLineOptions::CommandLineOptions):
2044         * MiniBrowser/win/MainWindow.cpp:
2045         (MainWindow::MainWindow):
2046         (MainWindow::create):
2047         (MainWindow::init):
2048         (MainWindow::WndProc):
2049         * MiniBrowser/win/MainWindow.h:
2050         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2051         (PrintWebUIDelegate::createWebViewWithRequest):
2052         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2053         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2054         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2055         (WebKitBrowserWindow::updateProxySettings):
2056         (WebKitBrowserWindow::createNewPage):
2057         * MiniBrowser/win/WebKitBrowserWindow.h:
2058         * MiniBrowser/win/WinMain.cpp:
2059         (wWinMain):
2060
2061 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2062
2063         Make it possible to test scrolling tree layer manipulation more easily
2064         https://bugs.webkit.org/show_bug.cgi?id=195780
2065
2066         Reviewed by Tim Horton.
2067         
2068         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2069         cuts off communication of scrolling tree scrolls back to the web process
2070         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2071         allows tests to trigger scrolls which run the scrolling tree layer positioning
2072         logic, but never get another commit from the web process that might mask
2073         scrolling tree bugs.
2074         
2075         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2076         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2077         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2078
2079         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2080         (WTR::UIScriptController::scrollUpdatesDisabled const):
2081         (WTR::UIScriptController::setScrollUpdatesDisabled):
2082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2083         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2084         (WTR::UIScriptController::scrollUpdatesDisabled const):
2085         (WTR::UIScriptController::setScrollUpdatesDisabled):
2086         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2087         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2088         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2089         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2090         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2091         * WebKitTestRunner/ios/TestControllerIOS.mm:
2092         (WTR::TestController::platformResetStateToConsistentValues):
2093         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2094         (WTR::UIScriptController::scrollUpdatesDisabled const):
2095         (WTR::UIScriptController::setScrollUpdatesDisabled):
2096
2097 2019-03-14  Youenn Fablet  <youenn@apple.com>
2098
2099         Move IDB storage in private browsing mode to NetworkProcess
2100         https://bugs.webkit.org/show_bug.cgi?id=195602
2101
2102         Reviewed by Brady Eidson.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2105         (TEST):
2106
2107 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2108
2109         [ews-build] Make descriptionDone messages more readable
2110         https://bugs.webkit.org/show_bug.cgi?id=195760
2111
2112         Reviewed by Lucas Forschler.
2113
2114         * BuildSlaveSupport/ews-build/steps.py:
2115         * BuildSlaveSupport/ews-build/steps_unittest.py:
2116
2117 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2118
2119         [ews-build] Generate status-bubble hover-over messages
2120         https://bugs.webkit.org/show_bug.cgi?id=195680
2121
2122         Reviewed by Lucas Forschler.
2123
2124         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2125         (StatusBubble):
2126         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2127         on hover-over.
2128         (StatusBubble._iso_time):
2129         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2130         hover-over message.
2131         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2132
2133 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2134
2135         [ews-app] Gracefully handle the case when state_string is None
2136         https://bugs.webkit.org/show_bug.cgi?id=195753
2137
2138         Reviewed by Lucas Forschler.
2139
2140         * BuildSlaveSupport/ews-app/ews/models/build.py:
2141         * BuildSlaveSupport/ews-app/ews/models/step.py:
2142
2143 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2144
2145         [ews-app] Status bubble display pending for currently running build step
2146         https://bugs.webkit.org/show_bug.cgi?id=195744
2147
2148         Reviewed by Lucas Forschler.
2149
2150         * BuildSlaveSupport/ews-build/events.py:
2151         (Events.stepStarted): If state_string is pending, replace it with step name.
2152
2153 2019-03-14  Chris Dumez  <cdumez@apple.com>
2154
2155         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2156         https://bugs.webkit.org/show_bug.cgi?id=195750
2157
2158         Reviewed by Geoffrey Garen.
2159
2160         Add API test coverage.
2161
2162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2163         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2164         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2165         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2166
2167 2019-03-14  Chris Dumez  <cdumez@apple.com>
2168
2169         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2170         https://bugs.webkit.org/show_bug.cgi?id=195747
2171
2172         Reviewed by Geoff Garen.
2173
2174         Add API test coverage.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2177
2178 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2179
2180         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2181         https://bugs.webkit.org/show_bug.cgi?id=195725
2182         <rdar://problem/48545062>
2183
2184         Reviewed by Tim Horton.
2185
2186         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2187         handler is nil.
2188
2189         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2190         (TestWebKitAPI::TEST):
2191
2192 2019-03-13  Sam Weinig  <sam@webkit.org>
2193
2194         Add utility function to allow easy reverse range-based iteration of a container
2195         https://bugs.webkit.org/show_bug.cgi?id=195542
2196
2197         Reviewed by Antti Koivisto.
2198
2199         * TestWebKitAPI/CMakeLists.txt:
2200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2201         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2202         (TestWebKitAPI::TEST):
2203         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2204
2205 2019-03-13  Chris Dumez  <cdumez@apple.com>
2206
2207         Use a ServiceWorker process per registrable domain
2208         https://bugs.webkit.org/show_bug.cgi?id=195649
2209
2210         Reviewed by Youenn Fablet.
2211
2212         Update API test coverage.
2213
2214         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2215
2216 2019-03-13  Chris Dumez  <cdumez@apple.com>
2217
2218         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2219         https://bugs.webkit.org/show_bug.cgi?id=195684
2220         <rdar://problem/48294714>
2221
2222         Reviewed by Antti Koivisto.
2223
2224         Add API test coverage.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2227
2228 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2229
2230         [ews-app] Remove unused patch view
2231         https://bugs.webkit.org/show_bug.cgi?id=195669
2232
2233         Reviewed by Lucas Forschler.
2234
2235         * BuildSlaveSupport/ews-app/ews/urls.py:
2236         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2237
2238 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-app] Use Buildbot result code variables
2241         https://bugs.webkit.org/show_bug.cgi?id=195668
2242
2243         Reviewed by Alexey Proskuryakov.
2244
2245         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2246         (Buildbot): Added Buildbot result code variables.
2247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2248         (StatusBubble._build_bubble): Used Buildbot result code variables.
2249
2250 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2251
2252         [Flatpak] Expand submodule recursively
2253         https://bugs.webkit.org/show_bug.cgi?id=195672
2254
2255         Building WPE with flatpak was impossible without that as it was raising an exception.
2256         Also update wpebackend-fdo to match what is built in jhbuild
2257
2258         Reviewed by Philippe Normand.
2259
2260         * flatpak/flatpakutils.py:
2261         (expand_submodules_recurse):
2262         (expand_manifest):
2263         * flatpak/org.webkit.WPEModules.yaml:
2264
2265 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [ews-app] status bubble should be hidden for certain builds
2268         https://bugs.webkit.org/show_bug.cgi?id=194597
2269
2270         Reviewed by Dewei Zhu.
2271
2272         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2273         (StatusBubble._build_bubble):
2274         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2275         because the patch didn't have relevant changes.
2276         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2277         in production yet.
2278
2279 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2280
2281         [Win] Fix a slew of simple clang-cl warnings.
2282         https://bugs.webkit.org/show_bug.cgi?id=195652
2283
2284         Reviewed by Don Olmstead.
2285
2286         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2287         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2288
2289 2019-03-12  Justin Fan  <justin_fan@apple.com>
2290
2291         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2292         https://bugs.webkit.org/show_bug.cgi?id=195518
2293         <rdar://problem/46322356>
2294
2295         Reviewed by Myles C. Maxfield.
2296
2297         * DumpRenderTree/DerivedSources-input.xcfilelist:
2298         * DumpRenderTree/DerivedSources-output.xcfilelist:
2299
2300 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2301
2302         Unreviewed, rolling out r242825.
2303         https://bugs.webkit.org/show_bug.cgi?id=195648
2304
2305         "Broke webkitpy tests with my change to
2306         lldb_dump_class_layout.py" (Requested by rmorisset on
2307         #webkit).
2308
2309         Reverted changeset:
2310
2311         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2312         classes with suspicious padding"
2313         https://bugs.webkit.org/show_bug.cgi?id=195573
2314         https://trac.webkit.org/changeset/242825
2315
2316 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2317
2318         [ews-build] Show status bubbles while the patch is waiting in queue
2319         https://bugs.webkit.org/show_bug.cgi?id=195618
2320
2321         Reviewed by Lucas Forschler.
2322
2323         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2324         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2325         enabled in initial deployment.
2326         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2327         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2328         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2329         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2330         (StatusBubble._build_bubbles_for_patch):
2331
2332 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2333
2334         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2335         https://bugs.webkit.org/show_bug.cgi?id=195573
2336
2337         Reviewed by Simon Fraser.
2338
2339         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2340
2341         * Scripts/dump-class-layout:
2342         (main):
2343         * lldb/lldb_dump_class_layout.py:
2344         (ClassLayout.__init__):
2345         (ClassLayout._compute_padding_recursive):
2346         (LLDBDebuggerInstance.dump_layout_for_classname):
2347         (LLDBDebuggerInstance):
2348         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2349         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2350
2351 2019-03-12  Chris Dumez  <cdumez@apple.com>
2352
2353         Device Orientation access permission should be denied unless explicitly granted by the client
2354         https://bugs.webkit.org/show_bug.cgi?id=195625
2355
2356         Reviewed by Youenn Fablet.
2357
2358         add API test coverage.
2359
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2362         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2363         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2364         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2365         (runDeviceOrientationTest):
2366         (TEST):
2367         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2368         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2369
2370 2019-03-12  Jer Noble  <jer.noble@apple.com>
2371
2372         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2373         https://bugs.webkit.org/show_bug.cgi?id=195137
2374         <rdar://problem/48810307>
2375
2376         Reviewed by Eric Carlson.
2377
2378         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2379         (TestWebKitAPI::TEST):
2380
2381 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2382
2383         [ews-build] Change urls from uat to production
2384         https://bugs.webkit.org/show_bug.cgi?id=195566
2385
2386         Reviewed by Lucas Forschler.
2387
2388         * BuildSlaveSupport/ews-app/ews/config.py:
2389         * BuildSlaveSupport/ews-build/events.py:
2390         * BuildSlaveSupport/ews-build/steps.py:
2391
2392 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-build] change max_builds for local-worker to 1
2395         https://bugs.webkit.org/show_bug.cgi?id=195568
2396
2397         Reviewed by Lucas Forschler.
2398
2399         * BuildSlaveSupport/ews-build/loadConfig.py:
2400
2401 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2402
2403         Fix the build
2404
2405         * TestRunnerShared/spi/PencilKitTestSPI.h:
2406         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2407
2408 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2409
2410         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2411         https://bugs.webkit.org/show_bug.cgi?id=194131
2412
2413         Reviewed by Michael Catanzaro.
2414
2415         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2416         (uriChanged):
2417         (testUnfinishedSubresourceLoad):
2418         (serverCallback):
2419         (beforeAll):
2420
2421 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2422
2423         WTF::Expected should use std::addressof instead of operator&
2424         https://bugs.webkit.org/show_bug.cgi?id=195604
2425
2426         Reviewed by Myles Maxfield.
2427
2428         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2429         (TestWebKitAPI::Unique::Unique):
2430         (TestWebKitAPI::Unique::operator&):
2431         (TestWebKitAPI::TEST):
2432
2433 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2434
2435         Add Optional to Forward.h.
2436         https://bugs.webkit.org/show_bug.cgi?id=195586
2437
2438         Reviewed by Darin Adler.
2439
2440         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2441         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2442         Remove unnecessary includes from headers.
2443
2444 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2445
2446         Add testing API to hit-test and scroll overflow scrollers
2447         https://bugs.webkit.org/show_bug.cgi?id=195278
2448
2449         Reviewed by Antti Koivisto.
2450         
2451         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2452         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2453         
2454         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2455
2456         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2457         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2458         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2459         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2460         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2461         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2462         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2463         (WTR::enclosingScrollViewIncludingSelf):
2464         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2465
2466 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2467
2468         API test WebKit.RequestTextInputContext fails on iOS
2469         https://bugs.webkit.org/show_bug.cgi?id=195585
2470
2471         Reviewed by Wenson Hsieh and Simon Fraser.
2472
2473         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2474         (applyStyle):
2475         (TEST):
2476         Add a viewport, so that the coordinates match up on iOS.
2477         Scroll by moving the UIScrollView's contentOffset.
2478
2479 2019-03-11  Chris Dumez  <cdumez@apple.com>
2480
2481         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2482         https://bugs.webkit.org/show_bug.cgi?id=195506
2483         <rdar://problem/48733477>
2484
2485         Reviewed by Alex Christensen.
2486
2487         Add API test coverage.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2490
2491 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2492
2493         Adding myself to contributors.json
2494
2495         Unreviewed, addming myself to contributors.json .
2496
2497         * Scripts/webkitpy/common/config/contributors.json:
2498
2499 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2500
2501         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2502         https://bugs.webkit.org/show_bug.cgi?id=195511
2503         <rdar://problem/44873269>
2504
2505         Reviewed by Darin Adler.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2508         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2509         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2510         (TEST_F):
2511
2512 2019-03-11  Chris Dumez  <cdumez@apple.com>
2513
2514         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2515         https://bugs.webkit.org/show_bug.cgi?id=195561
2516
2517         Reviewed by Youenn Fablet.
2518
2519         Make sure the JS in the test requests for permission to receive device orientation events.
2520
2521         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2522
2523 2019-03-11  Youenn Fablet  <youenn@apple.com>
2524
2525         Allow storage quota increase by default in WTR
2526         https://bugs.webkit.org/show_bug.cgi?id=195541
2527
2528         Reviewed by Geoffrey Garen.
2529
2530         Allow storage quota increase by default in WTR.
2531         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2532         Use this for tests that explicitly need cache increase.
2533
2534         Instead of increasing quota by 2, make sure the next request is
2535         granted by adding all given parameters.
2536
2537         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2539         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2540         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2542         * WebKitTestRunner/TestController.cpp:
2543         (WTR::TestController::setAllowStorageQuotaIncrease):
2544         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2545         * WebKitTestRunner/TestController.h:
2546         * WebKitTestRunner/TestInvocation.cpp:
2547         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2548         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2549         (WTR::TestController::cocoaResetStateToConsistentValues):
2550         (WTR::TestController::setAllowStorageQuotaIncrease):
2551         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2552         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2553         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2554
2555 2019-03-11  Xan Lopez  <xan@igalia.com>
2556
2557         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2558         https://bugs.webkit.org/show_bug.cgi?id=194147
2559
2560         Reviewed by Michael Saboff.
2561
2562         To make --32-bit work correctly on Linux/64bit we need to:
2563
2564         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2565         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2566         unfortunately CMake only allows us to do this during
2567         crosscompilation, which is overkill here.
2568         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2569         pkg-config detection module uses the x86 .pc files instead of the
2570         x86_64 ones.
2571         - Set the -m32 flags for the compiler.
2572
2573         * Scripts/webkitdirs.pm:
2574         (generateBuildSystemFromCMakeProject):
2575
2576 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2577
2578         Add MotionMark-1.1 plan file for run-benchmark script.
2579         https://bugs.webkit.org/show_bug.cgi?id=195481
2580
2581         Rubber-stamped by Darin Adler.
2582
2583         Run-benchmark script should support MontionMark-1.1.
2584
2585         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2586
2587 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews-app] Add support for submit-to-ews url
2590         https://bugs.webkit.org/show_bug.cgi?id=195477
2591
2592         Reviewed by Lucas Forschler.
2593
2594         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2595         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2596         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2597         * BuildSlaveSupport/ews-app/ews/urls.py:
2598         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2599
2600 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2601
2602         Unreviewed, rolling out r242688, r242643, r242624.
2603
2604         Caused multiple layout test failures and crashes on iOS and macOS.
2605
2606         Reverted changeset:
2607
2608         "requestAnimationFrame should execute before the next frame"
2609         https://bugs.webkit.org/show_bug.cgi?id=177484
2610         https://trac.webkit.org/changeset/242624/webkit
2611
2612         * Tracing/SystemTracePoints.plist:
2613
2614 2019-03-11  John Wilander  <wilander@apple.com>
2615
2616         Resource Load Statistics: Make it possible exclude localhost from classification
2617         https://bugs.webkit.org/show_bug.cgi?id=195474
2618         <rdar://problem/47520577>
2619
2620         Reviewed by Brent Fulgham.
2621
2622         This patch allows for localhost to be excluded from classification and
2623         treatment as a prevalent resource.
2624
2625         The WebKit Tools change adds a new function called
2626         testRunner.setStatisticsIsRunningTest() which can be used to control this
2627         behavior.
2628
2629         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2630         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2631         (WTR::TestRunner::setStatisticsIsRunningTest):
2632         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2633         * WebKitTestRunner/TestController.cpp:
2634         (WTR::TestController::setStatisticsIsRunningTest):
2635         * WebKitTestRunner/TestController.h:
2636         * WebKitTestRunner/TestInvocation.cpp:
2637         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2638
2639 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2642         https://bugs.webkit.org/show_bug.cgi?id=195560
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/master.cfg:
2647
2648 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2649
2650         Unreviewed, rolling out r242698.
2651
2652         API test crashes on bots.
2653
2654         Reverted changeset:
2655
2656         "Add a WKContentRuleList variant that uses copied memory
2657         instead of mmap'd shared memory for class A containerized
2658         apps"
2659         https://bugs.webkit.org/show_bug.cgi?id=195511
2660         https://trac.webkit.org/changeset/242698
2661
2662 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2663
2664         [WPE] Enable web process sandbox
2665         https://bugs.webkit.org/show_bug.cgi?id=195169
2666
2667         Reviewed by Daniel Bates.
2668
2669         * wpe/install-dependencies:
2670         * wpe/jhbuild.modules:
2671
2672 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2673
2674         [ews-app] Use port 17000 for worker communication
2675         https://bugs.webkit.org/show_bug.cgi?id=195558
2676
2677         Reviewed by Lucas Forschler.
2678
2679         * BuildSlaveSupport/ews-build/master.cfg:
2680
2681 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-build] unit-tests fail when passwords.json is missing
2684         https://bugs.webkit.org/show_bug.cgi?id=195557
2685
2686         Reviewed by Lucas Forschler.
2687
2688         * BuildSlaveSupport/ews-build/loadConfig.py:
2689         (loadBuilderConfig):
2690         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2691         (ConfigDotJSONTest.test_configuration):
2692         * BuildSlaveSupport/ews-build/master.cfg:
2693
2694 2019-03-11  Truitt Savell  <tsavell@apple.com>
2695
2696         Unreviewed, rolling out r242702.
2697
2698         Broke High Sierra builders.
2699
2700         Reverted changeset:
2701
2702         "Add utility function to allow easy reverse range-based
2703         iteration of a container"
2704         https://bugs.webkit.org/show_bug.cgi?id=195542
2705         https://trac.webkit.org/changeset/242702
2706
2707 2019-03-11  Sam Weinig  <sam@webkit.org>
2708
2709         Add utility function to allow easy reverse range-based iteration of a container
2710         https://bugs.webkit.org/show_bug.cgi?id=195542
2711
2712         Reviewed by Antti Koivisto.
2713
2714         * TestWebKitAPI/CMakeLists.txt:
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2716         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2717         (TestWebKitAPI::TEST):
2718         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2719
2720 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2721
2722         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2723         https://bugs.webkit.org/show_bug.cgi?id=195511
2724         <rdar://problem/44873269>
2725
2726         Reviewed by Darin Adler.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2729         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2730         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2731         (TEST_F):
2732
2733 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2734
2735         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2736         https://bugs.webkit.org/show_bug.cgi?id=195499
2737
2738         Reviewed by Darin Adler.
2739
2740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2741         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2742         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2743         (-[WKWebView synchronouslyFocusTextInputContext:]):
2744         (applyStyle):
2745         (applyIframe):
2746         (TEST):
2747         Add some tests for this SPI.
2748
2749 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2750
2751         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2752         https://bugs.webkit.org/show_bug.cgi?id=181151
2753
2754         Reviewed by Don Olmstead.
2755
2756         * TestWebKitAPI/CMakeLists.txt:
2757         * TestWebKitAPI/PlatformWin.cmake:
2758         Enable TestWTF RunLoop tests in all platforms.
2759
2760         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2761         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2762         (TestWebKitAPI::DerivedOneShotTimer::fired):
2763         (TestWebKitAPI::TEST):
2764         Only a few platforms support nested RunLoop.
2765
2766         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2767         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2768
2769 2019-03-10  David Quesada  <david_quesada@apple.com>
2770
2771         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2772         https://bugs.webkit.org/show_bug.cgi?id=152480
2773
2774         Reviewed by Chris Dumez.
2775
2776         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2777         there are no additional references to the process pool besides the one held by
2778         the download, waits for the download to finish (in the sense that the
2779         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2780         measure, also check that the process pool has been deallocated at the end of the
2781         test. The test wouldn't be meaningful if the process pool were still alive.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2784         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2785         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2786             The download will be canceled because the delegate does not implement the
2787             method to decide the download's destination, so this is where we know the
2788             DownloadProxyMap is done with the DownloadProxy.
2789         (TEST):
2790
2791 2019-03-08  Chris Dumez  <cdumez@apple.com>
2792
2793         Add support for Device Orientation / Motion permission API
2794         https://bugs.webkit.org/show_bug.cgi?id=195329
2795         <rdar://problem/47645367>
2796
2797         Reviewed by Geoffrey Garen.
2798
2799         Add test infrastructure to help test the Device Orientation / Motion permission API.
2800
2801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2803         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2804         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2805         * WebKitTestRunner/TestController.cpp:
2806         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2807         (WTR::TestController::createWebViewWithOptions):
2808         (WTR::TestController::resetStateToConsistentValues):
2809         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2810         * WebKitTestRunner/TestController.h:
2811         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2812         * WebKitTestRunner/TestInvocation.cpp:
2813         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2814
2815 2019-03-08  Saam barati  <sbarati@apple.com>
2816
2817         Add a compare-results script to compare benchmark results
2818         https://bugs.webkit.org/show_bug.cgi?id=195486
2819         <rdar://problem/48723397>
2820
2821         Reviewed by Geoffrey Garen.
2822
2823         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2824         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2825         to extend it to learn about our other benchmarks.
2826
2827         * Scripts/compare-results: Added.
2828         (readJSONFile):
2829         (detectJetStream2):
2830         (JetStream2Results):
2831         (detectSpeedometer2):
2832         (Speedometer2Results):
2833         (detectPLT5):
2834         (PLT5Results):
2835         (detectBenchmark):
2836         (biggerIsBetter):
2837         (ttest):
2838         (getOptions):
2839         (main):
2840
2841 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2842
2843         Ensure old tab state is cleared between iterations of run-benchmark
2844         https://bugs.webkit.org/show_bug.cgi?id=195393
2845         <rdar://problem/46885583>
2846
2847         Reviewed by Dewei Zhu.
2848
2849         a) ensure the default to restore state is not set
2850         b) terminate Safari correctly
2851         c) Set the system default to ignore Persistent State in Safari
2852
2853         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2854         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2855         (OSXBrowserDriver.prepare_env): 
2856         (OSXBrowserDriver.restore_env):
2857         (OSXBrowserDriver.close_browsers):
2858         (OSXBrowserDriver._terminate_processes):
2859         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2860         (OSXChromeDriver):
2861         (OSXChromeCanaryDriver):
2862         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2863         (OSXFirefoxDriver):
2864         (OSXFirefoxNightlyDriver):
2865         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2866         (OSXSafariDriver):
2867         (OSXSafariDriver.prepare_env):
2868
2869 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2870
2871         [GTK] Several InputMethodFilter tests are failing
2872         https://bugs.webkit.org/show_bug.cgi?id=195408
2873
2874         Reviewed by Carlos Garcia Campos.
2875
2876         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2877         Regressed in r241751.
2878         Hexadecimal values of keycodes are expressed now in upper letters.
2879         Composited characters should be cast to UTF8 strings.
2880
2881         (TestWebKitAPI::TEST):
2882
2883 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2884
2885         [GTK] Make Tools/gtkdoc python3 compatible
2886         https://bugs.webkit.org/show_bug.cgi?id=195359
2887
2888         Reviewed by Carlos Garcia Campos.
2889
2890         * gtkdoc/generate-gtkdoc:
2891         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2892         work with Python 2 and 3.
2893         (get_gtkdoc_module_paths):
2894         The iteritems() was removed in Python 3, so let's use items() that's
2895         available in Python 2 and 3.
2896         (get_generator_for_config):
2897         * gtkdoc/gtkdoc.py:
2898         (GTKDoc._run_command):
2899         The sys.stdout.write() is expecting str in Python 3 and not bytes
2900         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2901         for passing the bytes there.
2902
2903 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2904
2905         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2906         https://bugs.webkit.org/show_bug.cgi?id=195346
2907         <rdar://problem/48667048>
2908
2909         Unreviewed build fix for clang-cl.
2910
2911         * DumpRenderTree/win/DumpRenderTree.cpp:
2912         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2913
2914 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2915
2916         requestAnimationFrame should execute before the next frame
2917         https://bugs.webkit.org/show_bug.cgi?id=177484
2918
2919         Reviewed by Simon Fraser.
2920
2921         Add trace points for the page RenderingUpdate.
2922
2923         * Tracing/SystemTracePoints.plist:
2924
2925 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2926
2927         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2928         https://bugs.webkit.org/show_bug.cgi?id=195353
2929         <rdar://problem/48626394>
2930
2931         Reviewed by Simon Fraser.
2932
2933         * WebKitTestRunner/ios/TestControllerIOS.mm:
2934         (WTR::TestController::platformResetPreferencesToConsistentValues):
2935
2936 2019-03-07  John Wilander  <wilander@apple.com>
2937
2938         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2939         https://bugs.webkit.org/show_bug.cgi?id=195383
2940         <rdar://problem/48570136>
2941
2942         Reviewed by Brent Fulgham.
2943
2944         This patch adds test infrastructure to purge only script-accessible cookies,
2945         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2946
2947         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2948         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2949         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2950         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2951         * WebKitTestRunner/TestController.cpp:
2952         (WTR::TestController::statisticsDeleteCookiesForHost):
2953         * WebKitTestRunner/TestController.h:
2954         * WebKitTestRunner/TestInvocation.cpp:
2955         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2956
2957 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2958
2959         Unreviewed, rolling out r242354.
2960         https://bugs.webkit.org/show_bug.cgi?id=195402
2961
2962         breaks layout tests in all configurations (Requested by
2963         zdobersek on #webkit).
2964
2965         Reverted changeset:
2966
2967         "[WPE] Enable web process sandbox"
2968         https://bugs.webkit.org/show_bug.cgi?id=195169
2969         https://trac.webkit.org/changeset/242354
2970
2971 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2972
2973         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2974         https://bugs.webkit.org/show_bug.cgi?id=195346
2975
2976         Reviewed by Fujii Hironori.
2977
2978         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2979         (TestWebKitAPI::TEST):
2980         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2981
2982         * DumpRenderTree/win/DumpRenderTree.cpp:
2983         (findFontFallback):
2984         (addFontFallbackIfPresent):
2985         (removeFontFallbackIfPresent):
2986         (main):
2987         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2988         (TestWebKitAPI::Util::moduleDirectory):
2989         (TestWebKitAPI::Util::createInjectedBundlePath):
2990         Use wchar helpers as needed.
2991
2992 2019-03-06  Rob Buis  <rbuis@igalia.com>
2993
2994         Consider supporting the `referrerpolicy` attribute.
2995         https://bugs.webkit.org/show_bug.cgi?id=179053
2996
2997         Reviewed by Darin Adler.
2998
2999         Add a runtime flag for referrerpolicy attribute.
3000
3001         * DumpRenderTree/mac/DumpRenderTree.mm:
3002         (enableExperimentalFeatures):
3003
3004 2019-03-05  Daniel Bates  <dabates@apple.com>
3005
3006         Update expected API test result following r242379
3007         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3008
3009         Update expected x-coordinate of selection rect now that the left padding of
3010         a textarea is sized in ems (so dependent on the font size) just like the left
3011         padding of a text field.
3012
3013         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3014         (TestWebKitAPI::TEST):
3015
3016 2019-03-05  David Quesada  <david_quesada@apple.com>
3017
3018         [WK2] It should be possible to follow links with 'download' attributes
3019         https://bugs.webkit.org/show_bug.cgi?id=195145
3020         rdar://problem/48462642
3021
3022         Reviewed by Alex Christensen.
3023
3024         Add a unit test to verify that activating links with 'download' attributes now
3025         navigates to the linked resource, rather than starts downloading it. Add another
3026         to verify that it is still possible to explicitly download the link via the
3027         'Download' navigation action policy.
3028
3029         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3030         (-[DownloadAttributeTestDelegate init]):
3031         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3032         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3033         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3034         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3035         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3036         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3037         (TEST):
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::TestController::decidePolicyForNavigationAction):
3040         * WebKitTestRunner/TestController.h:
3041
3042 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3043
3044         [Curl] Implement Cookie Accept Policy.
3045         https://bugs.webkit.org/show_bug.cgi?id=191645
3046
3047         Reviewed by Fujii Hironori.
3048
3049         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3050         (TestWebKitAPI::Curl::TEST_F):
3051
3052 2019-03-05  Youenn Fablet  <youenn@apple.com>
3053
3054         Rename requestCacheStorageSpace to requestStorageSpace
3055         https://bugs.webkit.org/show_bug.cgi?id=195282
3056
3057         Reviewed by Chris Dumez.
3058
3059         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3060         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3061         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3062
3063 2019-03-05  Brady Eidson  <beidson@apple.com>
3064
3065         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3066         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3067
3068         Reviewed by Tim Horton.
3069
3070         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3071         different directory into that same WKWebView should work.
3072
3073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3074         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3075
3076 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3077
3078         Add WeakHashSet
3079         https://bugs.webkit.org/show_bug.cgi?id=195152
3080
3081         Reviewed by Antti Koivisto.
3082
3083         Added tests for WeakHashSet.
3084
3085         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3086         (TestWebKitAPI::Base::Base): Moved.
3087         (TestWebKitAPI::Derived::foo): Moved.
3088         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3089         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3090         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3091         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3092
3093 2019-03-04  Chris Dumez  <cdumez@apple.com>
3094
3095         Do not share WebProcesses between private and regular sessions
3096         https://bugs.webkit.org/show_bug.cgi?id=195189
3097         <rdar://problem/48421064>
3098
3099         Reviewed by Alex Christensen.
3100
3101         Add API test coverage.
3102
3103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3104         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3105
3106 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3107
3108         [WPE] Enable web process sandbox
3109         https://bugs.webkit.org/show_bug.cgi?id=195169
3110
3111         Reviewed by Daniel Bates.
3112
3113         * wpe/install-dependencies:
3114         * wpe/jhbuild.modules:
3115
3116 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3119         https://bugs.webkit.org/show_bug.cgi?id=195206
3120
3121         Reviewed by Žan Doberšek.
3122
3123         Add a new test case.
3124
3125         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3126         (testJSCClass):
3127
3128 2019-03-04  Charlie Turner  <cturner@igalia.com>
3129
3130         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3131         https://bugs.webkit.org/show_bug.cgi?id=194898
3132
3133         Reviewed by Žan Doberšek.
3134
3135         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3136         a GCC extension that permits arithmetic on void* pointer. Inline
3137         the macro until this issue is fixed upstream.
3138
3139 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3140
3141         Rid the world of WK_API_ENABLED
3142         https://bugs.webkit.org/show_bug.cgi?id=195263
3143
3144         Reviewed by Dan Bernstein.
3145
3146         List of changed files elided because it's useless.
3147
3148 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3149
3150         Unreviewed follow-up to r242292.
3151
3152         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3153
3154         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3155         (TestWebKitAPI::testStrip): Renamed from strip.
3156         (TestWebKitAPI::TEST):
3157
3158 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3159
3160         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3161
3162         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3163         and bug #194272 for details.
3164
3165         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3166
3167 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3168
3169         Remove some more unused 32-bit code
3170         https://bugs.webkit.org/show_bug.cgi?id=195255
3171
3172         Reviewed by Darin Adler.
3173
3174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3175         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3176         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3177         (NPP_New):
3178         (NPP_HandleEvent):
3179         (handleEventCarbon): Deleted.
3180
3181 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3182
3183         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3184
3185         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3186         (TestWebKitAPI::TEST):
3187
3188 2019-03-01  Darin Adler  <darin@apple.com>
3189
3190         Finish removing String::format
3191         https://bugs.webkit.org/show_bug.cgi?id=194893
3192
3193         Reviewed by Daniel Bates.
3194 '
3195         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3196
3197 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3198
3199         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3200         https://bugs.webkit.org/show_bug.cgi?id=195229
3201         <rdar://problem/48520362>
3202
3203         Reviewed by Chris Dumez.
3204
3205         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3206         (TEST):
3207
3208 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3209
3210         Add a system trace scope for event region building
3211         https://bugs.webkit.org/show_bug.cgi?id=195226
3212
3213         Reviewed by Jon Lee.
3214
3215         This trace scope measures the time spend converting element rects into Region objects,
3216         which can be large on some pages.
3217
3218         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3219
3220         * Tracing/SystemTracePoints.plist:
3221
3222 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3223
3224         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3225         https://bugs.webkit.org/show_bug.cgi?id=194612
3226
3227         Reviewed by Alex Christensen.
3228
3229         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3230         Just test the new string-processing function and don't touch the actual environment.
3231         (Test cases are all as before, but based on operator== instead of strcmp.)
3232
3233 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3234
3235         [ews-app] Update primary keys for handling multiple Buildbot instances
3236         https://bugs.webkit.org/show_bug.cgi?id=195120
3237
3238         Reviewed by Stephanie Lewis.
3239
3240         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3241         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3242         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3243
3244         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3245         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3246         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3247         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3248         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3249         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3250
3251 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3252
3253         [WinCairo] Enable service worker
3254         https://bugs.webkit.org/show_bug.cgi?id=188318
3255
3256         Reviewed by Youenn Fablet.
3257
3258         * DumpRenderTree/DumpRenderTreePrefix.h:
3259         * TestWebKitAPI/PlatformWin.cmake:
3260         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3261         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3262         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3263
3264 2019-03-01  Justin Fan  <justin_fan@apple.com>
3265
3266         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3267         https://bugs.webkit.org/show_bug.cgi?id=195191
3268
3269         Rubber-stamped by Dean Jackson.
3270
3271         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3272
3273         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3274
3275 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3276
3277         Unreviewed, fix lldb webkitpy tests
3278         https://bugs.webkit.org/show_bug.cgi?id=194375
3279
3280         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3281
3282         * lldb/lldb_webkit.py:
3283         (WTFStringImplProvider.is_8bit):
3284
3285 2019-02-28  David Quesada  <david_quesada@apple.com>
3286
3287         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3288         https://bugs.webkit.org/show_bug.cgi?id=195121
3289         rdar://problem/48450302
3290
3291         Reviewed by Alex Christensen.
3292
3293         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3294         configurations where the 'download' attribute is absent, blank, or populated
3295         with a filename, and where the anchor element is same-origin or cross-origin
3296         (meaning the 'download' attribute shouldn't be honored).
3297
3298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3299         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3300         (-[NavigationActionTestDelegate init]):
3301         (-[NavigationActionTestDelegate navigationAction]):
3302         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3303         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3304         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3305         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3306         (TEST):
3307
3308 2019-02-28  Antoine Quint  <graouts@apple.com>
3309
3310         Enable the Pointer Events runtime flag by default
3311         https://bugs.webkit.org/show_bug.cgi?id=195156
3312
3313         Reviewed by Dean Jackson.
3314
3315         * DumpRenderTree/mac/DumpRenderTree.mm:
3316         (enableExperimentalFeatures):
3317
3318 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3319
3320         Several PasteImage API tests are flaky
3321         https://bugs.webkit.org/show_bug.cgi?id=195160
3322
3323         Reviewed by Tim Horton.
3324
3325         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3326         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3327         listening for a "load" event after image load is already complete.
3328
3329         To address this, make these tests first register a "load" event handler, then run script to insert an image
3330         element into the document, and finally wait until the load event is observed before checking image size.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3333
3334 2019-02-28  Chris Dumez  <cdumez@apple.com>
3335
3336         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3337         https://bugs.webkit.org/show_bug.cgi?id=195107
3338
3339         Reviewed by Alex Christensen.
3340
3341         Give some time for the zoom level to get restored.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3344
3345 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3346
3347         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3348         https://bugs.webkit.org/show_bug.cgi?id=194958
3349
3350         Reviewed by Geoffrey Garen.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3353         (TEST):
3354
3355 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3356
3357         [ews-app] Update method to save build to handle builder_display_name
3358         https://bugs.webkit.org/show_bug.cgi?id=195047
3359
3360         Reviewed by Dewei Zhu.
3361
3362         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3363         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3364
3365 2019-02-28  Justin Fan  <justin_fan@apple.com>
3366
3367         [Web GPU] Enable Web GPU only on 64-bit
3368         https://bugs.webkit.org/show_bug.cgi?id=195139
3369
3370         Because Metal is only supported on 64 bit apps.
3371
3372         Unreviewed build fix.
3373
3374         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3375
3376 2019-02-27  Youenn Fablet  <youenn@apple.com>
3377
3378         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3379         https://bugs.webkit.org/show_bug.cgi?id=194959
3380
3381         Reviewed by Chris Dumez.
3382
3383         Spin loop until getting the condition to remove flakiness.
3384
3385         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3386
3387 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3388
3389         [ews-build] Buildbot should include builder_display_name in the build events
3390         https://bugs.webkit.org/show_bug.cgi?id=195045
3391
3392         Reviewed by Dewei Zhu.
3393
3394         * BuildSlaveSupport/ews-build/events.py:
3395         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3396         buildername to builder_name to be consistent in naming style.
3397         (Events.buildFinished): Ditto.
3398
3399 2019-02-27  Chris Dumez  <cdumez@apple.com>
3400
3401         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3402         https://bugs.webkit.org/show_bug.cgi?id=194480
3403
3404         Reviewed by Brady Eidson.
3405
3406         Update existing API test to make it more likely to reproduce the issue.
3407
3408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3409
3410 2019-02-27  Brady Eidson  <beidson@apple.com>
3411
3412         Universal links from Google search results pages don't open the app.
3413         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3414
3415         Reviewed by Geoffrey Garen.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3418         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3419         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3420         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3421
3422 2019-02-27  Chris Dumez  <cdumez@apple.com>
3423
3424         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3425         https://bugs.webkit.org/show_bug.cgi?id=195102
3426
3427         Reviewed by Geoffrey Garen.
3428
3429         If the number of processes is not yet what we expect, wait a bit and check again to give
3430         processes some time to exit.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3433
3434 2019-02-27  Chris Dumez  <cdumez@apple.com>
3435
3436         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3437         https://bugs.webkit.org/show_bug.cgi?id=194545
3438
3439         Reviewed by Brady Eidson.
3440
3441         Make sure the test navigates forward and then back only once. Previously, navigating
3442         back would trigger a navigation again in a timer.
3443
3444         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3445
3446 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3447
3448         High Sierra Debug JSC test queue should use faster hardware
3449         https://bugs.webkit.org/show_bug.cgi?id=194603
3450
3451         Rubber-stamped by Alexey Proskuryakov.
3452
3453         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/config.json:
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3457         (BubbleQueueServer):
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3459         (WebKitBuildbot):
3460         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3461         * QueueStatusServer/config/queues.py:
3462         * Scripts/webkitpy/common/config/ews.json:
3463         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3464         (test_ews_name):
3465
3466 2019-02-27  John Wilander  <wilander@apple.com>
3467
3468         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3469         https://bugs.webkit.org/show_bug.cgi?id=195071
3470         <rdar://problem/48417690>
3471
3472         Reviewed by Alex Christensen and Brent Fulgham.
3473
3474         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3475         (TestWebKitAPI::createURL):
3476             Convenience function.
3477         (TestWebKitAPI::TEST):
3478             WebCore::AdClickAttribution now takes a URL when creating Source and
3479             Destination.
3480         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3481         (TestWebKitAPI::TEST):
3482             WebCore::AdClickAttribution now takes a URL when creating Source and
3483             Destination.
3484
3485 2019-02-27  Antoine Quint  <graouts@apple.com>
3486
3487         Support Pointer Events on macOS
3488         https://bugs.webkit.org/show_bug.cgi?id=195008
3489         <rdar://problem/47454419>
3490
3491         Reviewed by Dean Jackson.
3492
3493         * DumpRenderTree/mac/DumpRenderTree.mm:
3494         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3496
3497 2019-02-26  Mark Lam  <mark.lam@apple.com>
3498
3499         Remove remaining poisoning code.
3500         https://bugs.webkit.org/show_bug.cgi?id=194138
3501
3502         Reviewed by Saam Barati.
3503
3504         * TestWebKitAPI/CMakeLists.txt:
3505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3506         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3507         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3508         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3509         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3510         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3511         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3512
3513 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3514
3515         Move ephemeral local storage from WebProcess to UIProcess
3516         https://bugs.webkit.org/show_bug.cgi?id=195074
3517         <rdar://problem/47937975>
3518
3519         Reviewed by Geoff Garen.
3520
3521         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3522
3523 2019-02-20  Jer Noble  <jer.noble@apple.com>
3524
3525         [Cocoa] Media elements will restart network buffering just before suspending
3526         https://bugs.webkit.org/show_bug.cgi?id=193691
3527
3528         Reviewed by Eric Carlson.
3529
3530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3531         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3532         (TEST):
3533
3534 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3535
3536         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3537         https://bugs.webkit.org/show_bug.cgi?id=191652
3538
3539         Reviewed by Alex Christensen.
3540
3541         Fix WinCairo MiniBrowser behavior of authentication dialog.
3542
3543         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3544         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3545
3546 2019-02-26  Youenn Fablet  <youenn@apple.com>
3547
3548         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3549         https://bugs.webkit.org/show_bug.cgi?id=195028
3550         <rdar://problem/48243733>
3551
3552         Reviewed by Eric Carlson.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3555
3556 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3557
3558         [WPE] Add API for webview background color configuration
3559         https://bugs.webkit.org/show_bug.cgi?id=192305
3560
3561         Reviewed by Michael Catanzaro.
3562
3563         * MiniBrowser/wpe/main.cpp:
3564         (main): Add a new option to configure the webview background
3565         color. Example: --bg-color=transparent.
3566         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3567         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3568         (beforeAll): Ditto.
3569
3570 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3571
3572         scalableNativeWebpageParameters() is not preserved on new page navigation.
3573         https://bugs.webkit.org/show_bug.cgi?id=194892
3574         <rdar://problem/47538280>
3575
3576         Reviewed by Wenson Hsieh.
3577         
3578         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3579
3580         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3581         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3582         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3583         (WTR::UIScriptController::allowsViewportShrinkToFit):
3584         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3585         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3586         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3587         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3588         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3589         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3590
3591 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3592
3593         [ews-app] Add model for handling multiple Buildbot instances
3594         https://bugs.webkit.org/show_bug.cgi?id=194863
3595
3596         Reviewed by Stephanie Lewis.
3597
3598         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3599
3600 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3601
3602         [ews-app] Remove BuilderMapping table
3603         https://bugs.webkit.org/show_bug.cgi?id=194961
3604
3605         Reviewed by Stephanie Lewis.
3606
3607         Store builder name directly in build table, instead of having a separate
3608         table for it.
3609
3610         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3611         * BuildSlaveSupport/ews-app/ews/models/build.py:
3612         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3613         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3614
3615 2019-02-25  John Wilander  <wilander@apple.com>
3616
3617         Introduce and adopt new class RegistrableDomain for eTLD+1
3618         https://bugs.webkit.org/show_bug.cgi?id=194791
3619         <rdar://problem/48179240>
3620
3621         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3622
3623         This patch adds an API test and replaces two instances of
3624         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3625
3626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3627         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3628         (TestWebKitAPI::TEST):
3629             Changed two strings to make sure the registrable domains are still considered
3630             invalid and pass the test.
3631         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3632         (TestWebKitAPI::TEST):
3633         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3634         (WTR::InjectedBundle::didReceiveMessageToPage):
3635
3636 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3637
3638         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3639         https://bugs.webkit.org/show_bug.cgi?id=195001
3640
3641         Reviewed by Carlos Garcia Campos.
3642
3643         API version 1.0 always includes the functionality previously guarded with
3644         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3645         unconditionally.
3646
3647         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3648         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3649         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3650         (WebViewTest::showInWindow): Ditto.
3651         (WebViewTest::hideView): Ditto.
3652         * wpe/backends/HeadlessViewBackend.cpp:
3653         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3654         * wpe/backends/ViewBackend.cpp:
3655         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3656         * wpe/backends/WindowViewBackend.cpp:
3657         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3658         WPE_BACKEND_CHECK_VERSION().
3659         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3660
3661 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3662
3663         [Flatpak] Add support for flatpak > 1.1.2
3664         https://bugs.webkit.org/show_bug.cgi?id=194088
3665
3666         Flatpak 1.2 is now out so we need to support that
3667         version now.
3668
3669         Reviewed by Michael Catanzaro.
3670
3671         * flatpak/flatpakutils.py:
3672         (check_flatpak):
3673         (FlatpakPackages.__init__):
3674         (FlatpakPackages.__detect_packages):
3675         (FlatpakPackages.__detect_packages.in):
3676         (FlatpakRepos.update):
3677
3678 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3679
3680         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3681         https://bugs.webkit.org/show_bug.cgi?id=194998
3682
3683         Reviewed by Carlos Garcia Campos.
3684
3685         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3686         to a Git checkout and using the latest commit containing various fixes
3687         and improvements.
3688
3689 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3690
3691         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3692         https://bugs.webkit.org/show_bug.cgi?id=194981
3693
3694         Reviewed by Žan Doberšek.
3695
3696         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3697         (TestWebKitAPI::TEST):
3698
3699 2019-02-23  Keith Miller  <keith_miller@apple.com>
3700
3701         Add new mac target numbers
3702         https://bugs.webkit.org/show_bug.cgi?id=194955
3703
3704         Reviewed by Tim Horton.
3705
3706         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3707         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3708         * MiniBrowser/Configurations/Base.xcconfig:
3709         * TestWebKitAPI/Configurations/Base.xcconfig:
3710         * WebKitTestRunner/Configurations/Base.xcconfig:
3711
3712 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3713
3714         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3715         https://bugs.webkit.org/show_bug.cgi?id=194846
3716
3717         Reviewed by Don Olmstead.
3718
3719         Added _search_paths() and _port_specific_expectations_files() for
3720         WinCairoPort.
3721
3722         * Scripts/webkitpy/port/win.py:
3723         (WinCairoPort.default_baseline_search_path):
3724         (WinCairoPort):
3725         (WinCairoPort._port_specific_expectations_files):
3726         (WinCairoPort._search_paths):
3727
3728 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3729
3730         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3731         https://bugs.webkit.org/show_bug.cgi?id=194963
3732
3733         Reviewed by Dean Jackson.
3734
3735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3736         Do a `contains` check instead of `equals`, because in debug builds we
3737         put the GraphicsLayer pointer in a prefix.
3738
3739 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3740
3741         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3742         https://bugs.webkit.org/show_bug.cgi?id=194873
3743         <rdar://problem/46701974>
3744
3745         Reviewed by Tim Horton.
3746
3747         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3748
3749         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3750         (WTR::UIScriptController::menuRect const):
3751         (WTR::UIScriptController::isShowingMenu const):
3752         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3753         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3754         (WTR::UIScriptController::menuRect const):
3755
3756         Add a function to query the bounds of the callout menu in content coordinates.
3757
3758         (WTR::UIScriptController::isShowingMenu const):
3759
3760         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3761
3762         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3763         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3764         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3765         (WTR::UIScriptController::rectForMenuAction const):
3766         (WTR::UIScriptController::menuRect const):
3767         (WTR::UIScriptController::isShowingMenu const):
3768         (WTR::findViewInHierarchyOfType): Deleted.
3769
3770 2019-02-22  Chris Dumez  <cdumez@apple.com>
3771
3772         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3773         https://bugs.webkit.org/show_bug.cgi?id=194954
3774         <rdar://problem/48127957>
3775
3776         Reviewed by Alex Christensen.
3777
3778         Add API test coverage.
3779
3780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3781         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3782         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3783         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3784
3785 2019-02-22  Chris Dumez  <cdumez@apple.com>
3786
3787         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3788         https://bugs.webkit.org/show_bug.cgi?id=194924
3789         <rdar://problem/48216125>
3790
3791         Reviewed by Geoffrey Garen.
3792
3793         Add API test coverage.
3794
3795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3796
3797 2019-02-22  Chris Dumez  <cdumez@apple.com>
3798
3799         Unreviewed, disable API test added in r241928 on iOS.
3800
3801         The cache is not enabled on devices with less than 3GB of RAM.
3802
3803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3804
3805 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3806
3807         Hardcode Visual Viewports on everywhere except iOS WK1
3808         https://bugs.webkit.org/show_bug.cgi?id=194928
3809
3810         Reviewed by Zalan Bujtas.
3811
3812         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3813         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3814         set it to false. The setting has shipped for several years and there's no need to turn
3815         it off now.
3816
3817         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3818         Visual Viewports are not enabled.
3819         
3820         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3821         that only runs in WK2
3822
3823         * MiniBrowser/mac/SettingsController.h:
3824         * MiniBrowser/mac/SettingsController.m:
3825         (-[SettingsController init]):
3826         (-[SettingsController _populateMenu]):
3827         (-[SettingsController validateMenuItem:]):
3828         (-[SettingsController visualViewportEnabled]): Deleted.
3829         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3830         * MiniBrowser/mac/WK1BrowserWindowController.m:
3831         (-[WK1BrowserWindowController didChangeSettings]):
3832         * MiniBrowser/mac/WK2BrowserWindowController.m:
3833         (-[WK2BrowserWindowController didChangeSettings]):
3834
3835 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3836
3837         Discard cached processes when clearing website data store
3838         https://bugs.webkit.org/show_bug.cgi?id=194894
3839
3840         Reviewed by Chris Dumez.
3841
3842         Added a test case.
3843
3844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3845         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3846
3847 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3848
3849         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3850         https://bugs.webkit.org/show_bug.cgi?id=194914
3851         <rdar://problem/47586889>
3852
3853         Reviewed by Geoffrey Garen.
3854
3855         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3856         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3857         (TEST):
3858         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3859
3860 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3861
3862         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3863         <https://webkit.org/b/194761>
3864
3865         Reviewed by Myles Maxfield.
3866
3867         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3868         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3869         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3870         to use ARC-compliant cast.
3871         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3872         ARC-compliant cast.
3873         (WTR::installFakeHelvetica): Log `error` to console if
3874         CTFontManagerRegisterFontsForURL() fails, but only on supported
3875         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3876         Call CFRelease() on `error` to fix the leak.  Update to use
3877         ARC-compliant cast.
3878         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3879         cast.
3880
3881 2019-02-21  Chris Dumez  <cdumez@apple.com>
3882
3883         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3884         https://bugs.webkit.org/show_bug.cgi?id=194481
3885
3886         Reviewed by Alex Christensen.
3887
3888         Give the processes a chance to shutdown and wait until we reached the expected number
3889         of processes.
3890
3891         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3892
3893 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3894
3895         Fix the macOS build
3896
3897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3898
3899 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3900
3901         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3902
3903         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3904         I am a backwards.
3905
3906 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3907
3908         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3912         We could force on UI-side compositing, but I feel like the test might be more
3913         valuable exercising the normal path on each platform (though the original
3914         bug was also UI-side specific). Though we can't validate that the overlay
3915         layer was installed successfully, there are layout tests that do that.
3916
3917 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3918
3919         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3920         https://bugs.webkit.org/show_bug.cgi?id=194845
3921         <rdar://problem/47944579>
3922
3923         Reviewed by Antti Koivisto.
3924
3925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3927
3928 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3929
3930         [LFC][Floats] Add support for placing formatting roots in-between floats.
3931         https://bugs.webkit.org/show_bug.cgi?id=194902
3932
3933         Reviewed by Antti Koivisto.
3934
3935         * LayoutReloaded/misc/LFC-passing-tests.txt:
3936
3937 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3938
3939         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3940         https://bugs.webkit.org/show_bug.cgi?id=194901
3941
3942         Unreviewed build fix.
3943
3944         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3945         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3946         WPEBackend-fdo-0.1 as library name.
3947
3948 2019-02-21  Rob Buis  <rbuis@igalia.com>
3949
3950         Update MIME type parser
3951         https://bugs.webkit.org/show_bug.cgi?id=180526
3952
3953         Reviewed by Darin Adler.
3954
3955         Add tests involving leading and trailing whitespace, non-token
3956         characters and quoted strings.
3957
3958         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3959         (TestWebKitAPI::TEST):
3960
3961 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3962
3963         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3964         https://bugs.webkit.org/show_bug.cgi?id=194884
3965
3966         Reviewed by Michael Catanzaro.
3967
3968         * PlatformWin.cmake:
3969
3970 2019-02-20  Chris Dumez  <cdumez@apple.com>
3971
3972         Add API test for <rdar://problem/47471222>
3973         https://bugs.webkit.org/show_bug.cgi?id=194847
3974
3975         Reviewed by Alex Christensen.
3976
3977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3978
3979 2019-02-20  Chris Dumez  <cdumez@apple.com>
3980
3981         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3982         https://bugs.webkit.org/show_bug.cgi?id=194872
3983         <rdar://problem/47924500>
3984
3985         Reviewed by Alex Christensen.
3986
3987         Add API test coverage.
3988
3989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3990
3991 2019-02-20  Jer Noble  <jer.noble@apple.com>
3992
3993         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3994         https://bugs.webkit.org/show_bug.cgi?id=191332
3995
3996         Reviewed by Dean Jackson.
3997
3998         * Scripts/git-is-in-range: Added.
3999
4000 2019-02-20  Andy Estes  <aestes@apple.com>
4001
4002         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4003         https://bugs.webkit.org/show_bug.cgi?id=194869
4004
4005         Rubber-stamped by Jer Noble.
4006
4007         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4008         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4009         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4010         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4012         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4013
4014 2019-02-20  Chris Dumez  <cdumez@apple.com>
4015
4016         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4017         https://bugs.webkit.org/show_bug.cgi?id=194857
4018         <rdar://problem/47759323>
4019
4020         Reviewed by Alex Christensen.
4021
4022         Add API test coverage.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4025
4026 2019-02-20  Chris Dumez  <cdumez@apple.com>
4027
4028         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4029         https://bugs.webkit.org/show_bug.cgi?id=194829
4030         <rdar://problem/47889906>
4031
4032         Reviewed by Alexey Proskuryakov.
4033
4034         Every time the TestOptions were changing we were creating both a new Web view and
4035         a new WKContext, which would start a new Network process. In most cases, we only
4036         need to contruct a new Web view and we do can keep reusing the same WKContext.
4037         This patch implements this optimization and thus avoids spinning a lot of new
4038         Network processes while running the layout tests.
4039
4040         * WebKitTestRunner/TestController.cpp:
4041         (WTR::TestController::generateContextConfiguration const):
4042         (WTR::TestController::generatePageConfiguration):
4043         (WTR::TestController::createWebViewWithOptions):
4044         (WTR::TestController::resetPreferencesToConsistentValues):
4045         (WTR::updateTestOptionsFromTestHeader):
4046         * WebKitTestRunner/TestController.h:
4047         * WebKitTestRunner/TestOptions.h:
4048         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4049         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4050         (WTR::TestOptions::hasSameInitializationOptions const):
4051         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4052         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4053         (WTR::TestController::platformAddTestOptions const):
4054
4055 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4056
4057         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4058         https://bugs.webkit.org/show_bug.cgi?id=167941
4059
4060         Reviewed by Carlos Garcia Campos.
4061
4062         * MiniBrowser/gtk/main.c:
4063         (filterSavedCallback): Added.
4064         (main): Support loading a JSON rule set file for content filtering.
4065         * MiniBrowser/wpe/main.cpp:
4066         (filterSavedCallback): Added.
4067         (main): Support loading a JSON rule set file for content filtering.
4068         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4069         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4070         (WTF::derefGPtr): Ditto.
4071         (testEmptyStore):
4072         (testSaveInvalidFilter):
4073         (testSaveLoadFilter):
4074         (testSavedFilterIdentifierMatch):
4075         (testRemoveFilter):
4076         (testSaveMultipleFilters):
4077         (testSaveFilterFromFile):
4078         (testFilterPersistence):
4079         (beforeAll):
4080         (afterAll):
4081         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4082         (removeOldInjectedContentAndResetLists): Also reset content filters.
4083         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4084         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4085         the element affected by the style sheet.
4086         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4087         and returns it to be used by tests.
4088         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4089         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4090         (serverCallback): Add support for serving a CSS style sheet for testing.
4091         (beforeAll): Add call to testUserContentManagerContentFilter().
4092         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4093
4094 2019-02-19  Keith Rollin  <krollin@apple.com>
4095
4096         Add timing information to build output
4097         https://bugs.webkit.org/show_bug.cgi?id=194839
4098         <rdar://problem/48219609>
4099
4100         Reviewed by Alexey Proskuryakov.
4101
4102         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4103         emit each project's build time to its output. E.g.,
4104
4105             ** BUILD SUCCEEDED ** [0.132 sec]
4106
4107         * Scripts/webkitdirs.pm:
4108         (XcodeOptions):
4109
4110 2019-02-19  Truitt Savell  <tsavell@apple.com>
4111
4112         Unreviewed, rolling out r241784.
4113
4114         Broke all OpenSource builds.
4115
4116         Reverted changeset:
4117
4118         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4119         instances view"
4120         https://bugs.webkit.org/show_bug.cgi?id=172848
4121         https://trac.webkit.org/changeset/241784
4122
4123 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4124
4125         [LFC][Floats] Remove redundant intersecting logic
4126         https://bugs.webkit.org/show_bug.cgi?id=194804
4127
4128         Reviewed by Antti Koivisto.
4129
4130         * LayoutReloaded/misc/LFC-passing-tests.txt:
4131
4132 2019-02-19  Dean Jackson  <dino@apple.com>
4133
4134         Clean-up output from generate-xcfilelists so it can be filtered
4135         https://bugs.webkit.org/show_bug.cgi?id=194795
4136
4137         Reviewed by Joseph Pecoraro (and Keith Rollin).
4138
4139         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4140         make a slight tweak to filter-build-webkit so such lines are marked
4141         as plain.
4142
4143         * Scripts/filter-build-webkit:
4144         * Scripts/generate-xcfilelists:
4145
4146 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4147
4148         pytest is not correctly auto-installed
4149         https://bugs.webkit.org/show_bug.cgi?id=194707
4150
4151         Reviewed by Carlos Garcia Campos.
4152
4153         * Scripts/webkitpy/thirdparty/__init__.py:
4154         (AutoinstallImportHook._install_pytest):
4155
4156 2019-02-18  Chris Dumez  <cdumez@apple.com>
4157
4158         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4159         https://bugs.webkit.org/show_bug.cgi?id=194797
4160         <rdar://problem/48055151>
4161
4162         Reviewed by Geoffrey Garen.
4163
4164         Add API test coverage.
4165
4166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4167
4168 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4169
4170         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4171         https://bugs.webkit.org/show_bug.cgi?id=194670
4172         <rdar://problem/39066529>
4173
4174         Reviewed by Tim Horton.
4175
4176         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4177         pasted in an editable area as attachment elements.
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4180         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4181         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4182         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4183         (TestWebKitAPI::TEST):
4184         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4185         (WTR::InjectedBundlePage::InjectedBundlePage):
4186
4187 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4188
4189         Fix API test after r241728
4190        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4191
4192         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4193         (TEST):
4194         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4195
4196 2019-02-18  Daniel Bates  <dabates@apple.com>
4197
4198         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4199         https://bugs.webkit.org/show_bug.cgi?id=192824
4200         <rdar://problem/47100332>
4201
4202         Reviewed by Wenson Hsieh.
4203
4204         Fix a bug where the wrong usage code was used for F13 thru F24.
4205
4206         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4207         (keyCodeForDOMFunctionKey):
4208
4209 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4210
4211         Bytecode cache should a have a boot-specific validation
4212         https://bugs.webkit.org/show_bug.cgi?id=194769
4213         <rdar://problem/48149509>
4214
4215         Reviewed by Keith Miller.
4216
4217         Add test for WTF::bootSessionUUIDString()
4218
4219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4220         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4221         (TEST):
4222
4223 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4224
4225         Disable safe browsing in WKWebView and remove its WKPreferences API
4226         https://bugs.webkit.org/show_bug.cgi?id=194723
4227         <rdar://problem/48122993>
4228
4229         Reviewed by Geoffrey Garen.
4230
4231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4232         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4233         (TEST):
4234         (safeBrowsingView):
4235         Make tests use SPI instead of API.
4236
4237 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4238
4239         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4240         https://bugs.webkit.org/show_bug.cgi?id=194586
4241
4242         Reviewed by Ross Kirsling.
4243
4244         * DumpRenderTree/win/DumpRenderTree.cpp:
4245         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4246         * Scripts/webkitpy/port/driver.py:
4247         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4248
4249 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4250
4251         Unreviewed, rolling out r241620.
4252
4253         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4254         (Requested by ddkilzer on #webkit.)
4255
4256         Reverted changeset:
4257
4258         "[WTF] Add environment variable helpers"
4259         https://bugs.webkit.org/show_bug.cgi?id=192405
4260         https://trac.webkit.org/changeset/241620
4261
4262 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4263
4264         [LFC] RenderImage's default intrinsic size is 0.
4265         https://bugs.webkit.org/show_bug.cgi?id=194745
4266
4267         Reviewed by Antti Koivisto.
4268
4269         * LayoutReloaded/misc/LFC-passing-tests.txt:
4270
4271 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4272
4273         [LFC][BFC] Add support for block replaced intrinsic width.
4274         https://bugs.webkit.org/show_bug.cgi?id=194705
4275
4276         Reviewed by Simon Fraser.
4277
4278         * LayoutReloaded/misc/LFC-passing-tests.txt:
4279
4280 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4281
4282         [LFC] Apply min/max width constraints to preferred width computation
4283         https://bugs.webkit.org/show_bug.cgi?id=194739
4284
4285         Reviewed by Simon Fraser.
4286
4287         * LayoutReloaded/misc/LFC-passing-tests.txt:
4288
4289 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4290
4291         [WTF] Add environment variable helpers
4292         https://bugs.webkit.org/show_bug.cgi?id=192405
4293
4294         Reviewed by Michael Catanzaro.
4295
4296         * DumpRenderTree/mac/DumpRenderTree.mm:
4297         (libraryPathForDumpRenderTree):
4298         * DumpRenderTree/win/DumpRenderTree.cpp:
4299         (libraryPathForDumpRenderTree):
4300         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4301         (setUpIOSLayoutTestCommunication):
4302         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4303         (beforeAll):
4304         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4305         (main):
4306         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4307         (WebKitTestBus::run):
4308         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4309         (WTR::getOutputDir):
4310         (WTR::initializeFontConfigSetting):
4311         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4312         (WTR::InjectedBundle::platformInitialize):
4313         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4314         (WTR::topLevelPath):
4315         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4316         (WTR::topLevelPath):
4317         (WTR::getOutputDir):
4318         (WTR::activateFonts):
4319         * WebKitTestRunner/TestController.cpp:
4320         (WTR::TestController::libraryPathForTesting):
4321         (WTR::TestController::generateContextConfiguration const):
4322         (WTR::TestController::generatePageConfiguration):
4323         (WTR::TestController::decideDestinationWithSuggestedFilename):
4324         (WTR::TestController::platformAdjustContext):
4325         * WebKitTestRunner/TestController.h:
4326         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4327         (WTR::TestController::cocoaPlatformInitialize):
4328         (WTR::TestController::platformAdjustContext):
4329         * WebKitTestRunner/gtk/main.cpp:
4330         (main):
4331         * WebKitTestRunner/mac/TestControllerMac.mm:
4332         (WTR::TestController::configureContentExtensionForTest):
4333         * WebKitTestRunner/wpe/main.cpp:
4334         (main):
4335         Utilize WTF::Environment where possible.
4336
4337 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4338
4339         [iOS] WKWebView callout bar is missing Change Writing Direction item
4340         https://bugs.webkit.org/show_bug.cgi?id=190015
4341         <rdar://problem/44810366>
4342
4343         Reviewed by Tim Horton.
4344
4345         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4346         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4347
4348         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4349         (TestWebKitAPI::TEST):
4350
4351 2019-02-15  Chris Dumez  <cdumez@apple.com>
4352
4353         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4354         https://bugs.webkit.org/show_bug.cgi?id=194717
4355         <rdar://problem/47884404>
4356
4357         Reviewed by Brady Eidson.
4358
4359         Add API test coverage.
4360
4361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: