Unreviewed. Fix ATK accessibility tests after r244059.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Fix ATK accessibility tests after r244059.
4
5         We are failing to load the injected bundle due to undefined symbol
6         AccessibilityUIElement::replaceTextInRange().
7
8         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9         (WTR::AccessibilityUIElement::replaceTextInRange):
10
11 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
12
13         AX: Support API: accessibilityReplaceRange:withText
14         https://bugs.webkit.org/show_bug.cgi?id=196636
15
16         Unreviewed build fix for Windows port.
17
18         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
19         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
20
21 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
22
23         [CMake][WinCairo] Separate copied headers into different directories
24         https://bugs.webkit.org/show_bug.cgi?id=196655
25
26         Reviewed by Michael Catanzaro.
27
28         * DumpRenderTree/CMakeLists.txt:
29         * MiniBrowser/win/CMakeLists.txt:
30         * TestWebKitAPI/CMakeLists.txt:
31         * TestWebKitAPI/PlatformWin.cmake:
32
33 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
34
35         Log stack-trace for run-webkit-tests when interrupted
36         https://bugs.webkit.org/show_bug.cgi?id=176393
37         <rdar://problem/34262310>
38
39         Reviewed by Lucas Forschler.
40
41         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
42         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
43         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
44         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
45         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
46         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
47         (main): Set handlers to log stack trace on interruption.
48
49 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
50
51         AX: Support API: accessibilityReplaceRange:withText
52         https://bugs.webkit.org/show_bug.cgi?id=196636
53
54         Unreviewed build fix for Windows port.
55
56         * DumpRenderTree/AccessibilityUIElement.cpp:
57         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
58
59 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
60
61         [ews-build] Scripts using Buildbot API have CORS error
62         https://bugs.webkit.org/show_bug.cgi?id=196709
63
64         Reviewed by Alexey Proskuryakov.
65
66         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
67
68 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
69
70         AX: Support API: accessibilityReplaceRange:withText
71         https://bugs.webkit.org/show_bug.cgi?id=196636
72
73         Reviewed by Daniel Bates.
74
75         * DumpRenderTree/AccessibilityUIElement.cpp:
76         (replaceTextInRangeCallback):
77         (AccessibilityUIElement::replaceTextInRange):
78         (AccessibilityUIElement::getJSClass):
79         * DumpRenderTree/AccessibilityUIElement.h:
80         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
81         (AccessibilityUIElement::replaceTextInRange):
82         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
83         (AccessibilityUIElement::replaceTextInRange):
84         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
85         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
86         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
87         (WTR::AccessibilityUIElement::replaceTextInRange):
88         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
89         (WTR::AccessibilityUIElement::replaceTextInRange):
90
91 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
92
93         [iOS] Do not allow starting selection drags when selection views are not visible
94         https://bugs.webkit.org/show_bug.cgi?id=196686
95         <rdar://problem/49399192>
96
97         Reviewed by Tim Horton.
98
99         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
100         also add some new API tests to cover scenarios where the web view is not first responder.
101
102         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
105
106         Add a switch to optionally make the web view first responder when starting the simulated drag.
107
108         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
109         (-[DragAndDropSimulator initWithWebView:]):
110         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
111
112 2019-04-08  Justin Fan  <justin_fan@apple.com>
113
114         [Web GPU] Fix Web GPU experimental feature on iOS
115         https://bugs.webkit.org/show_bug.cgi?id=196632
116
117         Reviewed by Myles C. Maxfield.
118
119         Properly make Web GPU available on iOS 11+.
120
121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
122
123 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
124
125         [ews-build] Do not upload archive when Compile Fails
126         https://bugs.webkit.org/show_bug.cgi?id=196674
127
128         Reviewed by Alexey Proskuryakov.
129
130         * BuildSlaveSupport/ews-build/factories.py:
131         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
132         * BuildSlaveSupport/ews-build/steps.py:
133         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
134         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
135         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
136
137 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
138
139         Enable DFG on MIPS
140         https://bugs.webkit.org/show_bug.cgi?id=196689
141
142         Reviewed by Žan Doberšek.
143
144         Since the bytecode change, we enabled the baseline JIT on mips in
145         r240432, but DFG is still missing. With this change, all tests are
146         passing on a ci20 board.
147
148         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
149
150 2019-04-08  Philippe Normand  <pnormand@igalia.com>
151
152         [Flatpak] Second run update-webkitwpe-flatpak fails
153         https://bugs.webkit.org/show_bug.cgi?id=192702
154
155         Reviewed by Carlos Garcia Campos.
156
157         * flatpak/flatpakutils.py:
158         (FlatpakObject.flatpak): Fix typo.
159         (FlatpakPackage.install): When installing, also update to the configured remote commit.
160         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
161
162 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
163
164         [GTK][WPE] outlook.live.com displays old-fashioned UI
165         https://bugs.webkit.org/show_bug.cgi?id=196642
166
167         Reviewed by Carlos Garcia Campos.
168
169         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
170         (TestWebKitAPI::TEST): New Mac platform quirk test.
171
172 2019-04-07  Commit Queue  <commit-queue@webkit.org>
173
174         Unreviewed, rolling out r243956.
175         https://bugs.webkit.org/show_bug.cgi?id=196688
176
177         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
178         by aakashjain on #webkit).
179
180         Reverted changeset:
181
182         "Clicking "Go Back" from a safe browsing warning from an
183         iframe should navigate the WKWebView back to the previous
184         page"
185         https://bugs.webkit.org/show_bug.cgi?id=196665
186         https://trac.webkit.org/changeset/243956
187
188 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
189
190         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
191         https://bugs.webkit.org/show_bug.cgi?id=196669
192
193         Reviewed by Geoffrey Garen.
194
195         Added three new unit tests for WeakHashSet.
196
197         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
198         (WTF_WeakPtr.WeakHashSetConstObjects):
199         (WTF_WeakPtr.WeakHashSetComputesEmpty):
200         (WTF_WeakPtr.WeakHashSetComputeSize):
201
202 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
203
204         Hide next and previous form control buttons when WKWebView is editable
205         https://bugs.webkit.org/show_bug.cgi?id=196672
206         <rdar://problem/35625321>
207
208         Reviewed by Tim Horton.
209
210         Add a new API test.
211
212         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
213         (-[TestWKWebView lastTrailingBarButtonGroup]):
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/ios/UIKitSPI.h:
216
217 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
218
219         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
220         https://bugs.webkit.org/show_bug.cgi?id=196077
221         <rdar://problem/49108202>
222
223         Reviewed by Chris Dumez.
224
225         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
226         on new web view.
227
228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
229
230 2019-04-05  Saam Barati  <sbarati@apple.com>
231
232         Make compare-results understand MotionMark
233         https://bugs.webkit.org/show_bug.cgi?id=196666
234
235         Reviewed by Yusuke Suzuki.
236
237         * Scripts/compare-results:
238         (PLT5Results):
239         (detectMotionMark):
240         (detectMotionMark1_1):
241         (motionMarkResults):
242         (motionMark1_1Results):
243         (detectBenchmark):
244         (biggerIsBetter):
245         (main):
246
247 2019-04-05  Alex Christensen  <achristensen@webkit.org>
248
249         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
250         https://bugs.webkit.org/show_bug.cgi?id=196665
251         <rdar://45115669>
252
253         Reviewed by Geoff Garen.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
256         (goBack):
257         (+[SimpleLookupContext sharedLookupContext]):
258         (-[SimpleLookupContext lookUpURL:completionHandler:]):
259         (TEST):
260         (+[Simple3LookupContext sharedLookupContext]): Deleted.
261         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
262
263 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
264
265         [ews-build] Add configuration and architecture for windows builders
266         https://bugs.webkit.org/show_bug.cgi?id=196660
267
268         Reviewed by Lucas Forschler.
269
270         * BuildSlaveSupport/ews-build/config.json:
271
272 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
273
274         webkitpy: Don't run subsequent rounds if interrupted
275         https://bugs.webkit.org/show_bug.cgi?id=196646
276
277         Reviewed by Aakash Jain.
278
279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
280         (Manager.run): Bail out if interrupted.
281
282 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
283
284         Test sessionStorage in PSON private browsing mode
285         https://bugs.webkit.org/show_bug.cgi?id=196561
286
287         Reviewed by Alex Christensen.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290
291 2019-04-05  Commit Queue  <commit-queue@webkit.org>
292
293         Unreviewed, rolling out r243833.
294         https://bugs.webkit.org/show_bug.cgi?id=196645
295
296         This change breaks build of WPE and GTK ports (Requested by
297         annulen on #webkit).
298
299         Reverted changeset:
300
301         "[CMake][WTF] Mirror XCode header directories"
302         https://bugs.webkit.org/show_bug.cgi?id=191662
303         https://trac.webkit.org/changeset/243833
304
305 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
306
307         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
308         https://bugs.webkit.org/show_bug.cgi?id=196635
309
310         Reviewed by Antti Koivisto.
311         
312         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
313         for a test to enable async frame scrolling via:
314             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
315         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
316         
317         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
318
319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
320         (WTR::InjectedBundle::beginTesting):
321         * WebKitTestRunner/TestController.cpp:
322         (WTR::TestController::resetPreferencesToConsistentValues):
323
324 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
325
326         Use a correct LC_RPATH when building with ASan
327         https://bugs.webkit.org/show_bug.cgi?id=196576
328
329         Reviewed by David Kilzer.
330
331         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
332         so that ../Frameworks is checked. This is simpler and more reliable than updating
333         each SPC service xcconfig.
334
335 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
336
337         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
338         https://bugs.webkit.org/show_bug.cgi?id=196629
339
340         Reviewed by Lucas Forschler.
341
342         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
343
344 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
347         https://bugs.webkit.org/show_bug.cgi?id=196618
348
349         Reviewed by Lucas Forschler.
350
351         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
352         (StatusBubble): Added QUEUE_TRIGGERS.
353         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
354         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
355         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
356         its parent(builder).
357
358 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
359
360         [ews-app] Status-bubble steps are sometimes displayed in reverse order
361         https://bugs.webkit.org/show_bug.cgi?id=196625
362
363         Reviewed by Lucas Forschler.
364
365         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
366         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
367
368 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
369
370         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
371         https://bugs.webkit.org/show_bug.cgi?id=196630
372
373         Reviewed by Wenson Hsieh.
374
375         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
376
377 2019-04-04  Youenn Fablet  <youenn@apple.com>
378
379         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
380         https://bugs.webkit.org/show_bug.cgi?id=196543
381
382         Reviewed by Alex Christensen.
383
384         * WebKitTestRunner/TestController.cpp:
385         (WTR::TestController::generatePageConfiguration):
386
387 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
388
389         [ews-app] Status bubble should not display skipped buildbot steps
390         https://bugs.webkit.org/show_bug.cgi?id=196584
391
392         Reviewed by Lucas Forschler.
393
394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
395
396 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
397
398         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
399         https://bugs.webkit.org/show_bug.cgi?id=196620
400
401         Reviewed by Lucas Forschler.
402
403         * BuildSlaveSupport/ews-app/ews/config.py:
404
405 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
406
407         [Win] DumpRenderTreeWatchDog.py is not checked into source
408         https://bugs.webkit.org/show_bug.cgi?id=196567
409         <rdar://problem/49525901>
410
411         Reviewed by Lucas Forschler.
412
413         This script is used on Win EWS bots to terminate hanging DRT processes.
414
415         * EWSTools/dumprendertreewatchdog.py: Added.
416
417 2019-04-04  Chris Dumez  <cdumez@apple.com>
418
419         Unreviewed, roll out r243858 which made tests time out.
420
421         Disable new API tests on Windows instead.
422
423         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
424         (TestWebKitAPI::TEST):
425
426 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         [ATK] Cleanup WebPageAccessibilityObjectAtk
429         https://bugs.webkit.org/show_bug.cgi?id=196537
430
431         Reviewed by Michael Catanzaro.
432
433         Also consider files under atk directories as exceptions for GObject conventions.
434
435         * Scripts/webkitpy/style/checkers/cpp.py:
436         (check_identifier_name_in_declaration):
437
438 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
439
440         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
441         https://bugs.webkit.org/show_bug.cgi?id=196588
442         <rdar://problem/49365787>
443
444         Unreviewed build fix for Windows port.
445
446         error C3861: 'kill': identifier not found
447
448         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
449         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
450
451 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Cancel build and similar operations should have authentication
454         https://bugs.webkit.org/show_bug.cgi?id=196520
455
456         Reviewed by Dewei Zhu.
457
458         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
459         environment variables.
460
461 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
462
463         [ews-build] Do not trigger queues which are not in production yet
464         https://bugs.webkit.org/show_bug.cgi?id=196581
465
466         Reviewed by Dewei Zhu.
467
468         * BuildSlaveSupport/ews-build/config.json:
469
470 2019-04-03  Chris Dumez  <cdumez@apple.com>
471
472         Unreviewed, fix typo in the name of API test added in r243848.
473
474         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
475         (TestWebKitAPI::TEST):
476
477 2019-04-03  Chris Dumez  <cdumez@apple.com>
478
479         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
480         https://bugs.webkit.org/show_bug.cgi?id=196588
481         <rdar://problem/49365787>
482
483         Reviewed by Ryosuke Niwa.
484
485         Add API test coverage.
486
487         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
488         (TestWebKitAPI::nullJavaScriptCallback):
489         (TestWebKitAPI::didCrashCheckFrames):
490         (TestWebKitAPI::TEST):
491
492 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
493
494         run-webkit-tests: Upload test results (new results database)
495         https://bugs.webkit.org/show_bug.cgi?id=196577
496         <rdar://problem/34841155>
497
498         Reviewed by Lucas Forschler.
499
500         * Scripts/webkitpy/layout_tests/controllers/manager.py:
501         (Manager.run): Upload results after each device shard, since the configuration will be
502         different for each device.
503         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
504         uploaded to a results database.
505         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
506         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
507
508 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
509
510         -apple-trailing-word is needed for browser detection
511         https://bugs.webkit.org/show_bug.cgi?id=196575
512
513         Unreviewed.
514
515         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
516
517 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
518
519         [CMake][WTF] Mirror XCode header directories
520         https://bugs.webkit.org/show_bug.cgi?id=191662
521
522         Reviewed by Konstantin Tokarev.
523
524         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
525         builds.
526
527         * CMakeLists.txt:
528         * DumpRenderTree/CMakeLists.txt:
529         * DumpRenderTree/PlatformWin.cmake:
530         * MiniBrowser/win/CMakeLists.txt:
531         * TestWebKitAPI/CMakeLists.txt:
532         * TestWebKitAPI/PlatformWin.cmake:
533         * WebKitTestRunner/PlatformGTK.cmake:
534         * WebKitTestRunner/PlatformWin.cmake:
535
536 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-app] Status bubble should not display certain infrastructure status messages
539         https://bugs.webkit.org/show_bug.cgi?id=196550
540
541         Reviewed by Lucas Forschler.
542
543         Do not display the steps which are un-needed for end-user. This information is still avaiable
544         if the user click on the bubble and look at the Buildbot build.
545         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
546         (StatusBubble._steps_messages):
547         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
548
549 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
550
551         [ews-build] Use https for sending data to ews-app
552         https://bugs.webkit.org/show_bug.cgi?id=196492
553
554         Reviewed by Lucas Forschler.
555
556         * BuildSlaveSupport/ews-build/events.py:
557
558 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
559
560         Remove support for -apple-trailing-word
561         https://bugs.webkit.org/show_bug.cgi?id=196525
562
563         Reviewed by Zalan Bujtas.
564
565         This CSS property is nonstandard and not used.
566
567         * Scripts/webkitperl/FeatureList.pm:
568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
569
570 2019-04-03  Youenn Fablet  <youenn@apple.com>
571
572         Add a test for DOMCache on multiple browsing in case of private browsing
573         https://bugs.webkit.org/show_bug.cgi?id=196524
574
575         Reviewed by Alex Christensen.
576
577         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
578         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
579
580 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
581
582         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
583         https://bugs.webkit.org/show_bug.cgi?id=196540
584
585         Reviewed by Aakash Jain.
586
587         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
588
589 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
590
591         Add plumbing for a compatibility mode preference in WebKit
592         https://bugs.webkit.org/show_bug.cgi?id=196005
593
594         Reviewed by Tim Horton.
595
596         Add new API tests.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
600
601 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
602
603         [WPE][GTK] Update libsrtp dependency package for Debian
604         https://bugs.webkit.org/show_bug.cgi?id=196528
605
606         Reviewed by Frédéric Wang.
607
608         * gtk/install-dependencies:
609         * wpe/install-dependencies:
610
611 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
612
613         [WK2] Add support for Window's beforeprint / afterprint events
614         https://bugs.webkit.org/show_bug.cgi?id=196478
615         <rdar://problem/49535124>
616
617         Unreviewed build fix for MSVC.
618
619         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
620
621         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
622
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::printFrame): Use int and float literals.
625
626 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
627
628         [ews-build] Reassign bots to queues
629
630         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
631
632 2019-04-02  Chris Dumez  <cdumez@apple.com>
633
634         [WK2] Add support for Window's beforeprint / afterprint events
635         https://bugs.webkit.org/show_bug.cgi?id=196478
636
637         Reviewed by Alex Christensen.
638
639         Add minimal implementation for printFrame in WebKitTestRunner.
640
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::printFrame):
643         (WTR::TestController::createOtherPage):
644         (WTR::TestController::createWebViewWithOptions):
645
646 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
647
648         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
649         https://bugs.webkit.org/show_bug.cgi?id=196491
650
651         Reviewed by Lucas Forschler.
652
653         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
654
655 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
656
657         [ews-build] Configure buildbot try credentials in environment variables
658         https://bugs.webkit.org/show_bug.cgi?id=196501
659
660         Reviewed by Lucas Forschler.
661
662         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
663         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
664         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
665
666 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
667
668         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
669         https://bugs.webkit.org/show_bug.cgi?id=196496
670         <rdar://problem/49521634>
671
672         Reviewed by Chris Dumez.
673
674         Add new API tests (see WebKit ChangeLog for more detail).
675
676         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
677         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
678         (TEST):
679
680 2019-04-02  David Kilzer  <ddkilzer@apple.com>
681
682         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
683         <https://webkit.org/b/196499>
684
685         Reviewed by Alexey Proskuryakov.
686
687         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
688         ENABLE_ADDRESS_SANITIZER.
689
690 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
691
692         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
693         https://bugs.webkit.org/show_bug.cgi?id=182757
694
695         Reviewed by Don Olmstead.
696
697         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
698         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
699
700 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
701
702         run-api-tests: Upload test results
703         https://bugs.webkit.org/show_bug.cgi?id=196323
704         <rdar://problem/49356714>
705
706         Reviewed by Lucas Forschler.
707
708         * Scripts/webkitpy/api_tests/manager.py:
709         (Manager):
710         (Manager.run): Upload results to a results database.
711         * Scripts/webkitpy/api_tests/run_api_tests.py:
712         (parse_args): Add upload arguments.
713         * Scripts/webkitpy/port/base.py:
714         (Port):
715         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
716         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
717         with commits from any other associated repositories.
718         * Scripts/webkitpy/port/device.py:
719         (Device):
720         (Device.build_version): Access build_versoin of underlying platform device.
721         * Scripts/webkitpy/port/ios_simulator_unittest.py:
722         (IOSSimulatorTest):
723         (IOSSimulatorTest.test_configuration_for_upload):
724         * Scripts/webkitpy/port/device_port.py:
725         (DevicePort):
726         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
727         the same as the machine uploading results.
728         * Scripts/webkitpy/port/mac.py:
729         (MacPort):
730         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
731         * Scripts/webkitpy/port/mac_unittest.py:
732         (MacTest):
733         (MacTest.test_configuration_for_upload):
734         * Scripts/webkitpy/xcode/simulated_device.py:
735         (SimulatedDeviceManager._create_device_with_runtime):
736         (SimulatedDevice.__init__): Create simulated device with a build_version.
737         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
738         (test_existing_simulator):
739
740 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
741
742         Remove extra newline characters (Follow-up fix to r243707)
743
744         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
745
746 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
747
748         [ews-app] Use API_KEY to accept results data
749         https://bugs.webkit.org/show_bug.cgi?id=196461
750
751         Reviewed by Dewei Zhu.
752
753         * BuildSlaveSupport/ews-app/ews/views/results.py:
754         (Results.post): Validate EWS_API_KEY before accepting any data.
755         * BuildSlaveSupport/ews-build/events.py:
756         (Events.sendData): Send EWS_API_KEY if available along with event data.
757
758 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
759
760         Unable to copy and paste a PDF from Notes into Mail compose body
761         https://bugs.webkit.org/show_bug.cgi?id=196442
762         <rdar://problem/48573098>
763
764         Reviewed by Tim Horton.
765
766         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
767         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
768         to be specified on the item providers.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
771         (TestWebKitAPI::mapItemForTesting):
772         (TestWebKitAPI::contactItemForTesting):
773
774 2019-04-01  Tim Horton  <timothy_horton@apple.com>
775
776         Make UIWKDocumentContext rects per-character instead of per-word
777         https://bugs.webkit.org/show_bug.cgi?id=196459
778
779         Reviewed by Wenson Hsieh.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
782         (TEST):
783         Adjust test results due to switching to per-character rects.
784
785 2019-04-01  Chris Dumez  <cdumez@apple.com>
786
787         UIProcess crash when a prewarmed process is terminated
788         https://bugs.webkit.org/show_bug.cgi?id=196451
789         <rdar://problem/49245471>
790
791         Reviewed by Geoffrey Garen.
792
793         Add API test coverage.
794
795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
796         (TEST):
797
798 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
799
800         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
801         https://bugs.webkit.org/show_bug.cgi?id=196449
802
803         Reviewed by Lucas Forschler.
804
805         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
806         (StatusBubble.get_os_details): Method to get OS and Xcode details.
807         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
808         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
809
810 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
813         https://bugs.webkit.org/show_bug.cgi?id=196444
814
815         Reviewed by Lucas Forschler.
816
817         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
818
819 2019-04-01  Alex Christensen  <achristensen@webkit.org>
820
821         Add SPI to canonicalize NSURLs with WTF::URL
822         https://bugs.webkit.org/show_bug.cgi?id=196415
823         <rdar://problem/44980271>
824
825         Reviewed by Darin Adler.
826
827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
828         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
829         (TestWebKitAPI::TEST):
830
831 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
832
833         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
834         https://bugs.webkit.org/show_bug.cgi?id=196441
835
836         Reviewed by Carlos Garcia Campos.
837
838         Don't cache the wpe_view_backend object that might not exist yet at the
839         time of EventSenderProxy constructor invocation, but instead retrieve
840         that object whenever it's required for event dispatching. This should
841         avoid crashes in this constructor now that it's invoked before any
842         PlatformWindow has been set up (as changed in r243496).
843
844         * WebKitTestRunner/EventSenderProxy.h:
845         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
846         (WTR::viewBackend):
847         (WTR::EventSenderProxy::EventSenderProxy):
848         (WTR::EventSenderProxy::mouseDown):
849         (WTR::EventSenderProxy::mouseUp):
850         (WTR::EventSenderProxy::mouseMoveTo):
851         (WTR::EventSenderProxy::mouseScrollBy):
852         (WTR::EventSenderProxy::keyDown):
853         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
854
855 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
856
857         [Win][WebKit] MiniBrowser should support high DPI display
858         https://bugs.webkit.org/show_bug.cgi?id=196391
859
860         Reviewed by Alex Christensen.
861
862         * MiniBrowser/win/WebKitBrowserWindow.cpp:
863         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
864         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
865         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
866
867 2019-03-31  Sam Weinig  <weinig@apple.com>
868
869         Remove more i386 specific configurations
870         https://bugs.webkit.org/show_bug.cgi?id=196430
871
872         Reviewed by Alexey Proskuryakov.
873
874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
875         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
876
877 2019-03-31  Andy Estes  <aestes@apple.com>
878
879         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
880         https://bugs.webkit.org/show_bug.cgi?id=196433
881         <rdar://problem/49293305>
882
883         Reviewed by Tim Horton.
884
885         Enhanced API test coverage to include all navigation response policy decisions in both
886         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
890         (TestWebKitAPI::TEST):
891         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
892         (readFile):
893         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
894         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
895         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
896         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
897         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
898         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
899         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
900         (-[QuickLookDelegate _downloadDidStart:]):
901         (-[QuickLookDelegate _download:didReceiveResponse:]):
902         (-[QuickLookDelegate _download:didReceiveData:]):
903         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
904         (-[QuickLookDelegate _downloadDidFinish:]):
905         (-[QuickLookDelegate _download:didFailWithError:]):
906         (-[QuickLookDelegate _downloadDidCancel:]):
907         (-[QuickLookDelegate verifyDownload]):
908         (runTest):
909         (runTestDecideBeforeLoading):
910         (runTestDecideAfterLoading):
911         (TEST):
912         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
913         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
914         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
915         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
916         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
917         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
918         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
919         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
920         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
921         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
922         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
923         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
924         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
925         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
926
927 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
928
929         [CMake] add testdfg as target with build-jsc
930         https://bugs.webkit.org/show_bug.cgi?id=196393
931
932         Reviewed by Saam Barati.
933
934         Added testdfg as one of the targets to build when
935         using CMake.
936
937         * Scripts/build-jsc:
938
939 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
940
941         Delete WebMetal implementation in favor of WebGPU
942         https://bugs.webkit.org/show_bug.cgi?id=195418
943
944         Reviewed by Dean Jackson.
945
946         * DumpRenderTree/mac/DumpRenderTree.mm:
947         (enableExperimentalFeatures):
948         (resetWebPreferencesToConsistentValues):
949         * Scripts/webkitperl/FeatureList.pm:
950         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
952         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
953         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
954         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
955         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
956         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
957         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
958         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
959         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
960         (WTR::InjectedBundle::beginTesting):
961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
962         (WTR::TestRunner::setWebMetalEnabled): Deleted.
963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
964
965 2019-03-29  Chris Dumez  <cdumez@apple.com>
966
967         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
968         https://bugs.webkit.org/show_bug.cgi?id=196405
969         <rdar://problem/49428130>
970
971         Reviewed by Wenson Hsieh.
972
973         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
974         the popover presentation methods to be no-ops. Use this in the new test added in
975         r243523 so that we do not swizzle those methods for all tests. This is needed because
976         those WatchOS tests rely on the popover getting presented and interactive.
977
978         * WebKitTestRunner/TestController.cpp:
979         (WTR::updateTestOptionsFromTestHeader):
980         * WebKitTestRunner/TestController.h:
981         * WebKitTestRunner/TestOptions.h:
982         (WTR::TestOptions::hasSameInitializationOptions const):
983         * WebKitTestRunner/ios/TestControllerIOS.mm:
984         (WTR::TestController::platformInitialize):
985         (WTR::TestController::platformResetStateToConsistentValues):
986
987 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
988
989         [Curl] Add Server Trust Evaluation Support.
990         https://bugs.webkit.org/show_bug.cgi?id=191646
991
992         Reviewed by Fujii Hironori.
993
994         Implemented MiniBrowser UI for asking if user trusts the server.
995
996         * MiniBrowser/win/Common.cpp:
997         (askServerTrustEvaluation):
998         (replaceString):
999         * MiniBrowser/win/Common.h:
1000         * MiniBrowser/win/MiniBrowserLib.rc:
1001         * MiniBrowser/win/MiniBrowserLibResource.h:
1002         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1003         (createPEMString):
1004         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1005         (WebKitBrowserWindow::canTrustServerCertificate):
1006         * MiniBrowser/win/WebKitBrowserWindow.h:
1007
1008 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1009
1010         Implement ResizeObserver.
1011         https://bugs.webkit.org/show_bug.cgi?id=157743
1012
1013         Reviewed by Simon Fraser.
1014
1015         Support resizeObserverEnabled webPreferences.
1016
1017         * DumpRenderTree/TestOptions.cpp:
1018         (TestOptions::TestOptions):
1019         * DumpRenderTree/TestOptions.h:
1020         * DumpRenderTree/mac/DumpRenderTree.mm:
1021         (setWebPreferencesForTestOptions):
1022         * DumpRenderTree/win/DumpRenderTree.cpp:
1023         (enableExperimentalFeatures):
1024         * Scripts/webkitperl/FeatureList.pm:
1025         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1026
1027 2019-03-28  John Wilander  <wilander@apple.com>
1028
1029         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1030         https://bugs.webkit.org/show_bug.cgi?id=196281
1031         <rdar://problem/48938748>
1032
1033         Reviewed by Alex Christensen.
1034
1035         This patch adds the function isStatisticsHasLocalStorage() to the
1036         TestRunner. With it, the page can query the WebsiteDataStore in the
1037         UI process to make sure that it sees LocalStorage.
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1041         (WTR::TestRunner::isStatisticsHasLocalStorage):
1042         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::isStatisticsHasLocalStorage):
1045         * WebKitTestRunner/TestController.h:
1046         * WebKitTestRunner/TestInvocation.cpp:
1047         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1048
1049 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1050
1051         API::Data::createWithoutCopying should do a null check before calling CFRelease
1052         https://bugs.webkit.org/show_bug.cgi?id=196276
1053         <rdar://problem/48059859>
1054
1055         Reviewed by Alex Christensen.
1056
1057         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1061         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1062         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1063         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1064         (TestWebKitAPI::TEST):
1065
1066 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1067
1068         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1069         https://bugs.webkit.org/show_bug.cgi?id=186276
1070
1071         Reviewed by Carlos Garcia Campos.
1072
1073         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1074         (webViewLoadChanged):
1075         (testWebResourceGetDataError):
1076         (testWebResourceGetDataEmpty):
1077         (beforeAll):
1078         (webViewloadChanged): Deleted.
1079
1080 2019-03-27  Andy Estes  <aestes@apple.com>
1081
1082         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1083         https://bugs.webkit.org/show_bug.cgi?id=196317
1084
1085         Reviewed by Dan Bernstein.
1086
1087         package-root copies built products into a staging directory using ditto(1), which does not
1088         follow symbolic links as it traverses a directory. Now that the files in
1089         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1090         itself, these become broken links when ditto'd into the staging directory.
1091
1092         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1093
1094         * Scripts/package-root:
1095
1096 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1097
1098         [ews-app] Update display text of Submit for ews analysis
1099         https://bugs.webkit.org/show_bug.cgi?id=196309
1100
1101         Reviewed by Dewei Zhu.
1102
1103         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1104
1105 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1106
1107         run-webkit-tests should check for leaks in WebKit processes
1108         <https://webkit.org/b/193772>
1109         <rdar://problem/46526680>
1110
1111         Reviewed by Ryosuke Niwa.
1112
1113         This works by doing the following:
1114         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1115           The list of child processes are returned one per line:
1116           process.name: pid
1117         - Run the "#LIST CHILD PROCESSES" command just before the
1118           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1119           processes on the ServerProcess object.
1120         - When the `--leaks` switch is handled, run check_for_leaks() on
1121           each child process after the main test harness.
1122
1123         * DumpRenderTree/mac/DumpRenderTree.mm:
1124         (handleControlCommand):
1125         - Use strncmp() instead of strcmp().
1126         - Add support for handling "#LIST CHILD PROCESSES" command.
1127
1128         * Scripts/webkitpy/port/base.py:
1129         (Port.check_for_leaks):
1130         * Scripts/webkitpy/port/darwin.py:
1131         (DarwinPort.check_for_leaks):
1132         - Rename redundant 'process_pid' argument to 'process_id'.
1133
1134         * Scripts/webkitpy/port/driver.py:
1135         (Driver.do_post_tests_work):
1136         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1137           longer the only command this sends to WebKitTestRunner.
1138         - If the `--leaks` switch is present, send the
1139           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1140           result using Port.set_webkit_processes().
1141         (Driver._parse_child_processes_output):
1142         - Add helper method to parse list of child process names and
1143           process IDs returned from WebKitTestRunner.
1144
1145         * Scripts/webkitpy/port/ios_device.py:
1146         (IOSDevicePort.check_for_leaks):
1147         - Rename redundant 'process_pid' argument to 'process_id'.
1148
1149         * Scripts/webkitpy/port/leakdetector.py:
1150         (LeakDetector._parse_leaks_output):
1151         - Return early if there is no leaks_output.
1152         (LeakDetector.check_for_leaks):
1153         - Rename redundant 'process_pid' argument to 'process_id'.
1154
1155         * Scripts/webkitpy/port/server_process.py:
1156         (ServerProcess.__init__):
1157         (ServerProcess.child_processes):
1158         (ServerProcess.set_child_processes):
1159         - Add instance variable to Port to store list of child process
1160           names and process IDs returned from WebKitTestRunner.
1161         (ServerProcess._start):
1162         - Clear self._child_processes.
1163         (ServerProcess.stop):
1164         - If self._child_processes is set, call
1165           self._port.check_for_leaks() for each child process.
1166
1167         * Scripts/webkitpy/port/server_process_unittest.py:
1168         (TrivialMockPort.check_for_leaks):
1169         - Rename redundant 'process_pid' argument to 'process_id'.
1170
1171         * Scripts/webkitpy/port/simulator_process.py:
1172         (SimulatorProcess.stop):
1173         - If self._child_processes is set, call
1174           self._port.check_for_leaks() for each child process.
1175
1176         * Scripts/webkitpy/port/watch_device.py:
1177         (WatchDevicePort.check_for_leaks):
1178         - Rename redundant 'process_pid' argument to 'process_id'.
1179
1180         * WebKitTestRunner/TestController.cpp:
1181         (WTR::TestController::dumpResponse):
1182         - Extract method from findAndDumpWorldLeaks() so that it may be
1183           reused by findAndDumpWebKitProcessIdentifiers().
1184         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1185         - Add method to output process name and process ID of both the
1186           WebContent and Networking processes.
1187         (WTR::TestController::findAndDumpWorldLeaks):
1188         - Fix missing newline in output when there were no abandoned
1189           documents.
1190         - Call dumpResponse() for extracted code.
1191         (WTR::TestController::handleControlCommand):
1192         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1193         - Use strncmp() instead of strcmp().
1194         - Call findAndDumpWebKitProcessIdentifiers() when
1195           "#LIST CHILD PROCESSES" command is sent.
1196         * WebKitTestRunner/TestController.h:
1197         (WTR::TestController::dumpResponse):
1198         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1199         - Declare methods.
1200
1201 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Unreviewed. Add GLib API test cases after r243434.
1204
1205         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1206         (testWebViewActiveURI):
1207         (serverCallback):
1208         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1209         (sendRequestCallback):
1210
1211 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1212
1213         Geolocation request not complete when watch request was started in a different web process
1214         https://bugs.webkit.org/show_bug.cgi?id=195996
1215
1216         Reviewed by Alex Christensen.
1217
1218         Add a test case.
1219
1220         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1221         (TestWebKitAPI::runJavaScriptAlert):
1222         (TestWebKitAPI::TEST):
1223
1224 2019-03-26  Keith Rollin  <krollin@apple.com>
1225
1226         Update the way generate-xcfilelists returns strings from functions
1227         https://bugs.webkit.org/show_bug.cgi?id=195975
1228         <rdar://problem/49040807>
1229
1230         Reviewed by Dean Jackson.
1231
1232         There are places where generate-xcfilelists executes assignments with
1233         statements like:
1234
1235             FOO=$(some_function)
1236
1237         where "some_function" return a string by echoing it. E.g.
1238
1239             some_function()
1240             {
1241                 echo "Hello, World"
1242             }
1243
1244         This is a common idiom, but it has a problem if "some_function" needs
1245         to call "exit" in an attempt to halt the entire script right then and
1246         there. Since "some_function" is called inside of $(), it's being
1247         executed in a sub-shell. Calling exit in that sub-shell simply exits
1248         that shell; it doesn't not exit the outer shell in which the main part
1249         of the script is still running. As such, the main script keeps
1250         executing when the intent was for the script to halt.
1251
1252         The solution to this is to use a different idiom for returning
1253         strings. The one we now is to pass in the name of the variable to
1254         receive the string result:
1255
1256             some_function()
1257             {
1258                 variable_name=$1
1259                 eval $variable_name ="Hello, World"
1260             }
1261
1262         The call site now looks like
1263
1264             some_function FOO
1265
1266         Because there's no invocation of a sub-shell, some_function can now
1267         call "exit" if it wants to, and the entire script will exit at that
1268         point.
1269
1270         * Scripts/generate-xcfilelists:
1271
1272 2019-03-26  Chris Dumez  <cdumez@apple.com>
1273
1274         Add basic layout test coverage for File Picker on iOS
1275         https://bugs.webkit.org/show_bug.cgi?id=196265
1276
1277         Reviewed by Wenson Hsieh.
1278
1279         Add layout test infrastructure to test the file picker on iOS.
1280
1281         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1282         (WTR::UIScriptController::dismissFilePicker):
1283         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1284         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1285         (WTR::UIScriptController::dismissFilePicker):
1286         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1287         * WebKitTestRunner/TestController.cpp:
1288         (WTR::TestController::createWebViewWithOptions):
1289         (WTR::updateTestOptionsFromTestHeader):
1290         * WebKitTestRunner/TestOptions.h:
1291         (WTR::TestOptions::hasSameInitializationOptions const):
1292         * WebKitTestRunner/ios/TestControllerIOS.mm:
1293         (overridePresentViewController):
1294         (WTR::TestController::platformInitialize):
1295         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1296         (WTR::UIScriptController::dismissFilePicker):
1297
1298 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1299
1300         Implement async paste method on UIWKInteractionViewProtocol
1301         https://bugs.webkit.org/show_bug.cgi?id=196267
1302         <rdar://problem/49236346>
1303
1304         Reviewed by Tim Horton.
1305
1306         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1307         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1308         are now a part of all iOS 12 internal SDKs.
1309
1310         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1311
1312         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1313         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1314
1315         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1316         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1317         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1318         * TestWebKitAPI/ios/UIKitSPI.h:
1319
1320 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1321
1322         [ews-build] Use PostgreSQL for ews.webkit.org database
1323         https://bugs.webkit.org/show_bug.cgi?id=196270
1324
1325         Reviewed by Lucas Forschler.
1326
1327         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1328
1329 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1330
1331         [ews] Reset simctl states on reboot
1332         https://bugs.webkit.org/show_bug.cgi?id=196260
1333
1334         Rubber-stamped by Aakash Jain.
1335
1336         * EWSTools/start-queue-mac.sh:
1337
1338 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1339
1340         [ews-build] Use PostgreSQL for ews-build database
1341         https://bugs.webkit.org/show_bug.cgi?id=196229
1342
1343         Reviewed by Lucas Forschler.
1344
1345         * BuildSlaveSupport/ews-build/master.cfg:
1346
1347 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-build] Get master_hostname dynamically in master.cfg
1350         https://bugs.webkit.org/show_bug.cgi?id=196255
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1355         send events data in test mode.
1356
1357 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-app] Set db_constraint to False for Foreign Keys
1360         https://bugs.webkit.org/show_bug.cgi?id=196252
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-app/ews/models/build.py:
1365         * BuildSlaveSupport/ews-app/ews/models/step.py:
1366
1367 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1368
1369         [ews-build] is_test_mode_enabled should default to True
1370         https://bugs.webkit.org/show_bug.cgi?id=196248
1371
1372         Reviewed by Lucas Forschler.
1373
1374         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1375
1376 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1377
1378         [ews-app] Add webkitperl to ENABLED_QUEUES
1379         https://bugs.webkit.org/show_bug.cgi?id=196253
1380
1381         Reviewed by Lucas Forschler.
1382
1383         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1384
1385 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1386
1387         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1388         https://bugs.webkit.org/show_bug.cgi?id=196211
1389         rdar://problem/49110552
1390
1391         Reviewed by Tim Horton.
1392
1393         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1394         Make sure that EventSenderProxy always exists when running tests. We used to create
1395         it when resetting before the first test, which is a bit too late.
1396
1397         * WebKitTestRunner/TestController.h:
1398         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1399         (WTR::TestController::platformCreateWebView):
1400         (WTR::TestController::platformCreateOtherPage):
1401         (WTR::TestController::finishCreatingPlatformWebView):
1402         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1403         (WTR::PlatformWebView::PlatformWebView):
1404         Moved some code that made NSWindow use NSEvent during web view creation. We may
1405         need to move more if some other case us found, but this is enough for now.
1406
1407 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1408
1409         Unreviewed. Fix typo in GLib geolocation API after r243285.
1410
1411         gelocation -> geolocation.
1412
1413         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1414         (testGeolocationManagerWatchPosition):
1415
1416 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1417
1418         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1419         https://bugs.webkit.org/show_bug.cgi?id=196213
1420
1421         Reviewed by Geoff Garen.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1425         (credentialWithIdentityAndKeychainPath):
1426         (-[ChallengeDelegate webView:didFinishNavigation:]):
1427         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1428         (TestWebKitAPI::TEST):
1429
1430 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1431
1432         Expected shouldn't assume its contained types are copyable
1433         https://bugs.webkit.org/show_bug.cgi?id=195986
1434
1435         Reviewed by JF Bastien.
1436
1437         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1438         (TestWebKitAPI::NonCopyable::operator== const):
1439         (TestWebKitAPI::NonCopyable::operator!= const):
1440         (TestWebKitAPI::TEST):
1441
1442 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1443
1444         Remove some now-unnecessary dynamic class lookup
1445         https://bugs.webkit.org/show_bug.cgi?id=196237
1446
1447         Reviewed by Simon Fraser.
1448
1449         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1450         (makeRequest):
1451         (TEST):
1452
1453 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1454
1455         Unreviewed, rolling out r243450.
1456
1457         AppleWin and WinCairo port builds get broken.
1458
1459         Reverted changeset:
1460
1461         "Add test for fix of #196095"
1462         https://bugs.webkit.org/show_bug.cgi?id=196097
1463         https://trac.webkit.org/changeset/243450
1464
1465 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1466
1467         Unreviewed, rolling out r243465.
1468         https://bugs.webkit.org/show_bug.cgi?id=196226
1469
1470         the test doesn't build (Requested by thorton on #webkit).
1471
1472         Reverted changeset:
1473
1474         "Do not terminate the NetworkProcess if a third party
1475         application sends a NSCredential with a SecIdentityRef"
1476         https://bugs.webkit.org/show_bug.cgi?id=196213
1477         https://trac.webkit.org/changeset/243465
1478
1479 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1480
1481         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1482         https://bugs.webkit.org/show_bug.cgi?id=196213
1483
1484         Reviewed by Geoff Garen.
1485
1486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1487         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1488         (credentialWithIdentityAndKeychainPath):
1489         (-[ChallengeDelegate webView:didFinishNavigation:]):
1490         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1491         (TestWebKitAPI::TEST):
1492
1493 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1494
1495         [ews-build] Gracefully handle missing patch_id in events
1496         https://bugs.webkit.org/show_bug.cgi?id=196216
1497
1498         Reviewed by Lucas Forschler.
1499
1500         * BuildSlaveSupport/ews-build/events.py:
1501
1502 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1503
1504         [ews-build] use lz4 compression for improving buildbot performance
1505         https://bugs.webkit.org/show_bug.cgi?id=196155
1506
1507         Reviewed by Lucas Forschler.
1508
1509         * BuildSlaveSupport/ews-build/master.cfg:
1510
1511 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1512
1513         Pull some API testing helper methods out of TestWKWebView
1514         https://bugs.webkit.org/show_bug.cgi?id=196212
1515
1516         Reviewed by Tim Horton.
1517
1518         Refactor some more API testing utility methods, so that they can be used in
1519         tests that do not use TestWKWebView.
1520
1521         * TestWebKitAPI/cocoa/TestWKWebView.h:
1522         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1523         (-[WKWebView loadTestPageNamed:]):
1524         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1525         (-[WKWebView synchronouslyLoadHTMLString:]):
1526         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1527         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1528         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1529         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1530         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1531
1532 2019-03-25  Jer Noble  <jer.noble@apple.com>
1533
1534         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1535         https://bugs.webkit.org/show_bug.cgi?id=196097
1536
1537         Reviewed by Eric Carlson.
1538
1539         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1540
1541         * DumpRenderTree/mac/DumpRenderTree.mm:
1542         (resetWebPreferencesToConsistentValues):
1543         * WebKitTestRunner/TestController.cpp:
1544         (WTR::TestController::resetPreferencesToConsistentValues):
1545
1546 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1547
1548         Pull IPadUserInterfaceSwizzler out into a separate header file
1549         https://bugs.webkit.org/show_bug.cgi?id=196193
1550
1551         Reviewed by Anders Carlsson.
1552
1553         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1554         be used in other API tests.
1555
1556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1557         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1558         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1559         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1560         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1561         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1562         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1563
1564 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1565
1566         Remove NavigatorContentUtils in WebCore/Modules
1567         https://bugs.webkit.org/show_bug.cgi?id=196070
1568
1569         Reviewed by Alex Christensen.
1570
1571         NavigatorContentUtils was to support the custom scheme spec [1].
1572         However, in WebKit side, no port has supported the feature in
1573         WebKit layer after EFL port was removed. So there has been the
1574         only IDL implementation of the NavigatorContentUtils in WebCore.
1575         So we don't need to keep the implementation in WebCore anymore.
1576
1577         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1578
1579         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1580
1581 2019-03-24  Andy Estes  <aestes@apple.com>
1582
1583         [watchOS] Remove unused Proximity Networking code
1584         https://bugs.webkit.org/show_bug.cgi?id=196188
1585
1586         Reviewed by Tim Horton.
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1589         (TEST):
1590
1591 2019-03-23  Keith Miller  <keith_miller@apple.com>
1592
1593         Refactor clz/ctz and fix getLSBSet.
1594         https://bugs.webkit.org/show_bug.cgi?id=196162
1595
1596         Reviewed by Saam Barati.
1597
1598         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1599
1600         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1601         (TestWebKitAPI::TEST):
1602
1603 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1604
1605         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1606         https://bugs.webkit.org/show_bug.cgi?id=196143
1607
1608         Reviewed by Michael Catanzaro.
1609
1610         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1611         directories.
1612
1613         * Scripts/webkitpy/style/checkers/cpp.py:
1614         (check_identifier_name_in_declaration):
1615         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1616         (WebKitStyleTest.test_names):
1617
1618 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1619
1620         [Flatpak] Manifest expanding fails for qt WPE extension
1621         https://bugs.webkit.org/show_bug.cgi?id=196148
1622
1623         Reviewed by Alex Christensen.
1624
1625         * flatpak/flatpakutils.py:
1626         (expand_submodules_recurse): The last recurse manifest expand
1627         iteration might lead to a single module so take it into account
1628         and don't try to recurse further.
1629
1630 2019-03-22  Chris Dumez  <cdumez@apple.com>
1631
1632         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1633         https://bugs.webkit.org/show_bug.cgi?id=195348
1634         <rdar://problem/48622090>
1635
1636         Reviewed by Alex Christensen.
1637
1638         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1639         to NO when test.options().shouldIgnoreMetaViewport is false.
1640
1641         * WebKitTestRunner/ios/TestControllerIOS.mm:
1642         (WTR::TestController::platformConfigureViewForTest):
1643
1644 2019-03-22  Chris Dumez  <cdumez@apple.com>
1645
1646         Prewarmed processes should be usable with any website data store
1647         https://bugs.webkit.org/show_bug.cgi?id=196104
1648
1649         Reviewed by Alex Christensen.
1650
1651         Add API test coverage.
1652
1653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1654         (runInitialWarmedProcessUsedTest):
1655         (TEST):
1656
1657 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1658
1659         Back out local changes to Alex's Subversion working directory
1660
1661         They were accidentally committed.
1662
1663         * Scripts/webkitpy/common/system/abstractexecutive.py:
1664         (AbstractExecutive.wait_newest):
1665         * Scripts/webkitpy/common/system/executive.py:
1666         (Executive.running_pids):
1667         * Scripts/webkitpy/common/system/executive_mock.py:
1668         (MockExecutive.running_pids):
1669         * Scripts/webkitpy/common/system/executive_unittest.py:
1670         (ExecutiveTest.serial_test_running_pids):
1671         * Scripts/webkitpy/port/darwin.py:
1672         (DarwinPort.check_for_leaks):
1673         * Scripts/webkitpy/port/leakdetector.py:
1674         (LeakDetector.check_for_leaks):
1675         - This was the hack attached to Bug 193772.
1676
1677         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1678         (+[WebKitTestRunnerEvent mouseLocation]):
1679         - This works around a crash on an internal build.
1680
1681 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1682
1683         Fix the build after r243354
1684         https://bugs.webkit.org/show_bug.cgi?id=196138
1685         <rdar://problem/49145951>
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1688         (TEST):
1689         * TestWebKitAPI/ios/UIKitSPI.h:
1690
1691 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1692
1693         Adopt UIWKDocumentContext
1694         https://bugs.webkit.org/show_bug.cgi?id=196040
1695         <rdar://problem/48642440>
1696
1697         Reviewed by Ryosuke Niwa.
1698
1699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1700         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1701         (makeRequest):
1702         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1703         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1704         (applyStyle):
1705         (TEST):
1706         Add tests for UIWKDocumentContext.
1707
1708         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1709         (TEST):
1710         (recursiveFindWKContentView): Deleted.
1711         * TestWebKitAPI/cocoa/TestWKWebView.h:
1712         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1713         (recursiveFindWKContentView):
1714         (-[TestWKWebView wkContentView]):
1715         * TestWebKitAPI/ios/UIKitSPI.h:
1716         Share the WKContentView finding code between tests.
1717
1718 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1719
1720         [iOS WK2] Turn on async overflow scrolling by default
1721         https://bugs.webkit.org/show_bug.cgi?id=196011
1722         rdar://problem/48453859
1723
1724         Reviewed by Antti Koivisto.
1725         
1726         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1727         since so many basic layout tests have different results when compositing is triggered for
1728         overflow.
1729         
1730         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1731
1732         * WebKitTestRunner/TestController.cpp:
1733         (WTR::TestController::resetPreferencesToConsistentValues):
1734
1735 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1736
1737         [ews-build] Retry API test in case of failures
1738         https://bugs.webkit.org/show_bug.cgi?id=196004
1739
1740         Reviewed by Lucas Forschler.
1741
1742         * BuildSlaveSupport/ews-build/steps.py:
1743         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1744         (CompileWebKitToT.doStepIf): Ditto.
1745         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1746         (ReRunAPITests): Re-run API tests.
1747         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1748         (RunAPITestsWithoutPatch): Run API tests without patch.
1749         (RunAPITestsWithoutPatch.doStepIf):
1750         (RunAPITestsWithoutPatch.hideStepIf):
1751         (RunAPITestsWithoutPatch.evaluateCommand):
1752         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1753         (AnalyzeAPITestsResults.start):
1754         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1755         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1756         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1757         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1758
1759 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1760
1761         [ews-build] Update queues configurations
1762         https://bugs.webkit.org/show_bug.cgi?id=196074
1763
1764         Reviewed by Dewei Zhu.
1765
1766         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1767         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1768
1769 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1770
1771         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1772         https://bugs.webkit.org/show_bug.cgi?id=195680
1773         <rdar://problem/48903534>
1774
1775         Unreviewed infrastructure fix.
1776
1777         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1778         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1779
1780 2019-03-21  Andy Estes  <aestes@apple.com>
1781
1782         [iOS] Apple Pay should be available in documents with no user agent scripts
1783         https://bugs.webkit.org/show_bug.cgi?id=196061
1784         <rdar://problem/48649391>
1785
1786         Reviewed by Brady Eidson.
1787
1788         Added API tests and related infrastructure.
1789
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1792         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1793         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1794         (TestWebKitAPI::TEST):
1795         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1796         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1797         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1798         * TestWebKitAPI/cocoa/TestProtocol.mm:
1799         (-[TestProtocol startLoading]):
1800         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1801         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1802         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1803         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1804
1805 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1806
1807         REGRESSSION (r243297): webkitpy tests broken
1808         https://bugs.webkit.org/show_bug.cgi?id=196108
1809
1810         Reviewed by Aakash Jain.
1811
1812         r243297 updated contributors.json, which broke a few unit tests.
1813
1814         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1815         (IRCCommandTest.test_whois):
1816         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1817
1818 2019-03-21  Chris Dumez  <cdumez@apple.com>
1819
1820         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1821         https://bugs.webkit.org/show_bug.cgi?id=196041
1822         <rdar://problem/49083230>
1823
1824         Reviewed by Alex Christensen.
1825
1826         Add API test coverage.
1827
1828         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1829         (TEST):
1830
1831 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1832
1833         Add SPI to inform applications of WKContentRuleList actions
1834         https://bugs.webkit.org/show_bug.cgi?id=195965
1835         <rdar://problem/42664365>
1836
1837         Reviewed by Geoff Garen.
1838
1839         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1840         (TestWebKitAPI::allActionsForResourceLoad):
1841         (TestWebKitAPI::testRequest):
1842         (TestWebKitAPI::TEST_F):
1843         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1844         (Notification::description):
1845         (Notification::operator== const):
1846         (toVector):
1847         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1848         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1849         (makeContentRuleList):
1850         (TEST):
1851         (makeWarnContentRuleList): Deleted.
1852
1853 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1854
1855         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1856         https://bugs.webkit.org/show_bug.cgi?id=196088
1857
1858         Reviewed by Brian Burg.
1859
1860         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1861         Support checks when only one platform is specified. Also deprecate macosx() and
1862         force the use of macos() instead.
1863
1864         * Scripts/webkitpy/style/checkers/cpp.py:
1865         (check_min_versions_of_wk_api_available):
1866         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1867         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1868
1869 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1870
1871         Update status inactive committers' status to 'contributor'.
1872
1873         * Scripts/webkitpy/common/config/contributors.json:
1874
1875 2019-03-21  Xan Lopez  <xan@igalia.com>
1876
1877         [JSC][x86] Drop support for x87 floating point
1878         https://bugs.webkit.org/show_bug.cgi?id=194853
1879
1880         Reviewed by Don Olmstead.
1881
1882         Force SSE2 on x86/32bit builds.
1883
1884         * Scripts/webkitdirs.pm:
1885         (generateBuildSystemFromCMakeProject):
1886
1887 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1890         https://bugs.webkit.org/show_bug.cgi?id=196073
1891
1892         Reviewed by Michael Catanzaro.
1893
1894         Add test cases to check functions and constructors with no arguments but receiving user data.
1895
1896         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1897         (checkUserData):
1898         (testJSCFunction):
1899         (fooCreateWithUserData):
1900         (testJSCClass):
1901
1902 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1903
1904         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1905
1906         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1907
1908         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1909
1910 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1911
1912         [GTK][WPE] Add API to provide geolocation information
1913         https://bugs.webkit.org/show_bug.cgi?id=195940
1914
1915         Reviewed by Michael Catanzaro.
1916
1917         Add a new test to check the new API.
1918
1919         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1920         (testGeolocationManagerCurrentPosition):
1921         (testGeolocationManagerWatchPosition):
1922         (beforeAll):
1923         (afterAll):
1924         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1925         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1926         (beforeAll): Ditto.
1927         * TestWebKitAPI/glib/CMakeLists.txt:
1928
1929 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1930
1931         [GLib] Returning G_TYPE_OBJECT from a method does not work
1932         https://bugs.webkit.org/show_bug.cgi?id=195574
1933
1934         Reviewed by Michael Catanzaro.
1935
1936         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1937
1938         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1939         (getGFile):
1940         (getParent):
1941         (createGString):
1942         (getGString):
1943         (getGStringCopyWillRaise):
1944         (getGStringCopy):
1945         (getGStringStr):
1946         (getGStringLen):
1947         (freeGString):
1948         (testJSCClass):
1949
1950 2019-03-20  Saam Barati  <sbarati@apple.com>
1951
1952         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1953         https://bugs.webkit.org/show_bug.cgi?id=195721
1954
1955         Reviewed by Filip Pizlo.
1956
1957         * Scripts/run-javascriptcore-tests:
1958
1959 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1960
1961         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1962         https://bugs.webkit.org/show_bug.cgi?id=196049
1963
1964         Reviewed by Tim Horton.
1965
1966         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1967         overflow scrolling in general, so rename it.
1968
1969         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1970
1971 2019-03-20  Daniel Bates  <dabates@apple.com>
1972
1973         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1974         https://bugs.webkit.org/show_bug.cgi?id=196031
1975         <rdar://problem/49078172>
1976
1977         Reviewed by Tim Horton.
1978
1979         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1980         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1981         same code path used when the Done button is pressed to dismiss the <select> picker.
1982
1983         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1984         (TestWebKitAPI::TEST):
1985
1986 2019-03-20  Chris Dumez  <cdumez@apple.com>
1987
1988         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1989         https://bugs.webkit.org/show_bug.cgi?id=196029
1990         <rdar://problem/48954651>
1991
1992         Reviewed by Tim Horton.
1993
1994         Add API test coverage.
1995
1996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1997
1998 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Improve failure summary string for ApplyPatch step
2001         https://bugs.webkit.org/show_bug.cgi?id=195995
2002
2003         Reviewed by Alexey Proskuryakov.
2004
2005         * BuildSlaveSupport/ews-build/steps.py:
2006         (ApplyPatch.getResultSummary): Override getResultSummary.
2007
2008 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2009
2010         AX: Implement support for new meter ARIA role
2011         https://bugs.webkit.org/show_bug.cgi?id=195966
2012
2013         Reviewed by Chris Fleizach.
2014
2015         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2016         to AXLevelIndicator.
2017
2018         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2019
2020 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2021
2022         [WebAuthN] Implement FIDO AppID extension
2023         https://bugs.webkit.org/show_bug.cgi?id=143491
2024         <rdar://problem/48298273>
2025
2026         Reviewed by Brent Fulgham.
2027
2028         Add a test that covers the new flag of convertToU2fSignCommand.
2029
2030         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2031         (TestWebKitAPI::TEST):
2032         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2033         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2034         (TestWebKitAPI::TEST):
2035
2036 2019-03-19  Keith Rollin  <krollin@apple.com>
2037
2038         Add support for more platforms to generate-xcfilelists
2039         https://bugs.webkit.org/show_bug.cgi?id=195977
2040
2041         Reviewed by Alexey Proskuryakov.
2042
2043         generate-xcfilelists incorrectly complains when involved with building
2044         WebKit for iphonesimulator:
2045
2046             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2047             …
2048             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2049
2050         Address this by teaching generate-xcfilelists about more platforms.
2051
2052         * Scripts/generate-xcfilelists:
2053
2054 2019-03-19  John Wilander  <wilander@apple.com>
2055
2056         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2057         https://bugs.webkit.org/show_bug.cgi?id=195923
2058         <rdar://problem/49001272>
2059
2060         Reviewed by Alex Christensen.
2061
2062         This patch does the following to the TestRunner:
2063         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2064         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2065         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2066
2067         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2069         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2070         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2073         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2074         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2075         * WebKitTestRunner/TestController.h:
2076         * WebKitTestRunner/TestInvocation.cpp:
2077         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2078
2079 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2080
2081         [CMake] Support more clang and gcc sanitizers
2082         https://bugs.webkit.org/show_bug.cgi?id=195956
2083
2084         Reviewed by Michael Catanzaro.
2085
2086         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2087
2088 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2089
2090         [ews-build] Improve summary for PrintConfiguration step
2091         https://bugs.webkit.org/show_bug.cgi?id=195945
2092
2093         Reviewed by Lucas Forschler.
2094
2095         * BuildSlaveSupport/ews-build/steps.py:
2096         (PrintConfiguration.getResultSummary): Override getResultSummary.
2097
2098 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2099
2100         [ews-build] Improve summary for CheckOutSource step
2101         https://bugs.webkit.org/show_bug.cgi?id=195963
2102
2103         Reviewed by Lucas Forschler.
2104
2105         * BuildSlaveSupport/ews-build/steps.py:
2106         (CheckOutSource.getResultSummary):
2107
2108 2019-03-19  Daniel Bates  <dabates@apple.com>
2109
2110         [iOS] Focus not preserved when switching between tabs
2111         https://bugs.webkit.org/show_bug.cgi?id=195820
2112         <rdar://problem/43614450>
2113
2114         Reviewed by Brent Fulgham.
2115
2116         Add tests to ensure that we restore focus when resigning and becoming first responder.
2117
2118         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2119         (TestWebKitAPI::TEST):
2120
2121 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2122
2123         Make WTFLogChannelState and WTFLogLevel enum classes
2124         https://bugs.webkit.org/show_bug.cgi?id=195904
2125
2126         Reviewed by Eric Carlson.
2127
2128         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2129         (TestWebKitAPI::TEST_F):
2130
2131 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2132
2133         [GStreamer][EME] Backported mssdemux protection data crash fix
2134         https://bugs.webkit.org/show_bug.cgi?id=195918
2135
2136         Reviewed by Philippe Normand.
2137
2138         * gstreamer/jhbuild.modules:
2139         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2140
2141 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2142
2143         Unreviewed, rolling out r243132.
2144
2145         Broke GTK build
2146
2147         Reverted changeset:
2148
2149         "Make WTFLogChannelState and WTFLogLevel enum classes"
2150         https://bugs.webkit.org/show_bug.cgi?id=195904
2151         https://trac.webkit.org/changeset/243132
2152
2153 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2154
2155         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2156
2157         * Scripts/webkitdirs.pm:
2158         (builtDylibPathForName): Adjust the shared library name that's changed
2159         with the API version bump in r243073.
2160
2161 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2162
2163         Make WTFLogChannelState and WTFLogLevel enum classes
2164         https://bugs.webkit.org/show_bug.cgi?id=195904
2165
2166         Reviewed by Eric Carlson.
2167
2168         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2169         (TestWebKitAPI::TEST_F):
2170
2171 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2172
2173         Disable flaky test added in r2431100
2174         https://webkit.org/b/195785
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2177         (TestWebKitAPI::TEST):
2178         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2179
2180 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2181
2182         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2183         https://bugs.webkit.org/show_bug.cgi?id=195916
2184
2185         Reviewed by Tim Horton.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2188         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2189
2190 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2191
2192         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2193
2194         * Scripts/webkitpy/common/config/contributors.json:
2195
2196 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2197
2198         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2199         https://bugs.webkit.org/show_bug.cgi?id=195785
2200
2201         Reviewed by Geoffrey Garen.
2202
2203         * TestWebKitAPI/TCPServer.cpp: Added.
2204         (TestWebKitAPI::TCPServer::TCPServer):
2205         (TestWebKitAPI::TCPServer::~TCPServer):
2206         (TestWebKitAPI::TCPServer::socketBindListen):
2207         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2208         * TestWebKitAPI/TCPServer.h: Added.
2209         (TestWebKitAPI::TCPServer::port const):
2210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2211         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2212         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2213         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2214         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2215         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2216         (TestWebKitAPI::respondSlowly):
2217         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2218         (TestWebKitAPI::downloadAtRate):
2219         (TestWebKitAPI::TEST):
2220
2221 2019-03-18  Saam Barati  <sbarati@apple.com>
2222
2223         Add a plan file for JetStream 2
2224         https://bugs.webkit.org/show_bug.cgi?id=190734
2225
2226         Reviewed by Mark Lam.
2227
2228         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2229
2230 2019-03-18  Chris Dumez  <cdumez@apple.com>
2231
2232         Delay WebProcess launch until a load is triggered in a Web view
2233         https://bugs.webkit.org/show_bug.cgi?id=195758
2234         <rdar://problem/48126013>
2235
2236         Reviewed by Geoff Garen.
2237
2238         Add API test coverage. Also update some existing API tests to not expect
2239         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2240
2241         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2242         (TestWebKitAPI::TEST):
2243         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2244         (TestWebKitAPI::TEST):
2245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2246         (TEST):
2247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2248         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2249         (TEST):
2250         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2251         (TEST):
2252         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2253
2254 2019-03-18  Xan Lopez  <xan@igalia.com>
2255
2256         [CMake] Prevent potential warning when determining $architecture
2257         https://bugs.webkit.org/show_bug.cgi?id=195891
2258
2259         Reviewed by Michael Catanzaro.
2260
2261         It's possible for generateBuildSystemForCMakeProject to be called
2262         before determineArchitecture() is ever called. This will make the
2263         first eq check with $architecture to be bogus (and print a
2264         warning). Change that to an eq check with architecture(), which
2265         implicitly calls determineArchitecture() if needed, and change all
2266         the other similar cases in the method in the same way to prevent
2267         future bugs like this one.
2268
2269         * Scripts/webkitdirs.pm:
2270         (generateBuildSystemFromCMakeProject):
2271
2272 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2273
2274         [WPE] Tarballs generated with “make dist” cannot build documentation
2275         https://bugs.webkit.org/show_bug.cgi?id=195885
2276
2277         Reviewed by Carlos Garcia Campos.
2278
2279         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2280
2281 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2282
2283         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2284         https://bugs.webkit.org/show_bug.cgi?id=195883
2285
2286         Reviewed by Carlos Garcia Campos.
2287
2288         * gtkdoc/gtkdoc.py:
2289         (GTKDoc._run_command): When commands fail to run, include the full command line for
2290         the program invocation and the output it has generated on the standard error stream.
2291
2292 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2293
2294         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2295         https://bugs.webkit.org/show_bug.cgi?id=195786
2296
2297         Reviewed by Philippe Normand.
2298
2299         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2300         * wpe/jhbuild.modules: Ditto.
2301
2302 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [ews-build] Don't run clean builds on EWS builders
2305         https://bugs.webkit.org/show_bug.cgi?id=195851
2306
2307         Reviewed by Geoffrey Garen.
2308
2309         * BuildSlaveSupport/ews-build/factories.py:
2310
2311 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2312
2313         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2314         https://bugs.webkit.org/show_bug.cgi?id=195849
2315
2316         Reviewed by Chris Dumez.
2317
2318         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2319
2320         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2321         (runWebsiteDataStoreCustomPaths):
2322
2323 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2324
2325         webkitpy: Upload test results
2326         https://bugs.webkit.org/show_bug.cgi?id=195755
2327         <rdar://problem/48896182>
2328
2329         Reviewed by Aakash Jain.
2330
2331         Establish a new format for uploading results that is not tied to layout tests, apply
2332         that format to webkitpy tests.
2333
2334         * Scripts/webkitpy/common/checkout/scm/git.py:
2335         (Git.native_branch): Return what branch the current checkout is on.
2336         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2337         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2338         * Scripts/webkitpy/common/checkout/scm/svn.py:
2339         (SVN.native_branch): Ditto.
2340         * Scripts/webkitpy/common/system/platforminfo.py:
2341         (PlatformInfo.build_version): Return a build version for Mac.
2342         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2343         (MockPlatformInfo.__init__):
2344         (MockPlatformInfo.build_version):
2345         * Scripts/webkitpy/results: Added.
2346         * Scripts/webkitpy/results/__init__.py: Added.
2347         * Scripts/webkitpy/results/options.py: Added.
2348         (upload_options): OptParse list for upload options.
2349         * Scripts/webkitpy/results/upload.py: Added.
2350         (Upload): Class which enforces the upload format expected by the results server.
2351         (Upload.Expectations):
2352         (Upload.create_configuration):
2353         (Upload.create_commit):
2354         (Upload.create_details):
2355         (Upload.create_run_stats):
2356         (Upload.create_test_result):
2357         (Upload.__init__):
2358         (Upload.Encoder): Encode Upload object as json.
2359         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2360         * Scripts/webkitpy/results/upload_unittest.py: Added.
2361         * Scripts/webkitpy/test/main.py:
2362         (Tester._parse_args): Add upload arguments.
2363         (Tester._run_tests): Allow results to be uploaded.
2364         * Scripts/webkitpy/test/runner.py:
2365         (Runner.__init__): Record which tests were run, rather than just counting them.
2366         (Runner.handle):
2367         * Scripts/webkitpy/test/runner_unittest.py:
2368         (RunnerTest.test_run):
2369         * Scripts/webkitpy/thirdparty/__init__.py:
2370         (AutoinstallImportHook.find_module): Add requests auto-install.
2371         (AutoinstallImportHook._install_requests):
2372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2373         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2374
2375 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2376
2377         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2378         https://bugs.webkit.org/show_bug.cgi?id=195810
2379
2380         Reviewed by Tim Horton.
2381
2382         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2383         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2384         ending certain layout tests.
2385
2386         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2387         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2388         (-[TestRunnerWKWebView dealloc]):
2389         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2390
2391         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2392         helper method when destroying the web view, and when resetting state between tests.
2393
2394         * WebKitTestRunner/ios/TestControllerIOS.mm:
2395         (WTR::TestController::platformResetStateToConsistentValues):
2396
2397         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2398
2399 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2400
2401         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2402         https://bugs.webkit.org/show_bug.cgi?id=190350
2403         <rdar://problem/45089503>
2404
2405         Reviewed by Geoffrey Garen.
2406
2407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2408         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2409         (TEST):
2410         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2411         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2412         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2413         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2414         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2415         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2416         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2417         (runTest):
2418         (createDirectories):
2419         (TEST):
2420         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2421         (TEST):
2422         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2423         (TEST):
2424
2425 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2426
2427         Add support to WebPage for getting the contents as an attributed string.
2428         https://bugs.webkit.org/show_bug.cgi?id=195636
2429         rdar://problem/45055697
2430
2431         Reviewed by Tim Horton.
2432
2433         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2434         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2435
2436 2019-03-15  Chris Dumez  <cdumez@apple.com>
2437
2438         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2439         https://bugs.webkit.org/show_bug.cgi?id=195747
2440
2441         Reviewed by Geoff Garen.
2442
2443         Add API test coverage.
2444
2445         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2446
2447 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2448
2449         Unreviewed, rolling out r242952.
2450
2451         Causing API failures on iOS Simulator
2452
2453         Reverted changeset:
2454
2455         "[PSON] Make sure the WebProcessCache is leverage when
2456         relaunching a process after termination"
2457         https://bugs.webkit.org/show_bug.cgi?id=195747
2458         https://trac.webkit.org/changeset/242952
2459
2460 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2461
2462         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2463         https://bugs.webkit.org/show_bug.cgi?id=195740
2464
2465         Reviewed by Ross Kirsling.
2466
2467         window.open doesn't work for WebKitBrowserWindow because it is not
2468         implemented yet.
2469
2470         1. Implemented createNewPage callback of WKPageUIClient.
2471         2. Changed MainWindow to take a BrowserWindow factory function
2472           instead of BrowserWindowType to be flexible to create
2473           BrowserWindow with extra settings.
2474         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2475           because it is not relevant with MainWindow anymore.
2476
2477         * MiniBrowser/win/Common.cpp:
2478         (parseCommandLine):
2479         * MiniBrowser/win/Common.h:
2480         (CommandLineOptions::CommandLineOptions):
2481         * MiniBrowser/win/MainWindow.cpp:
2482         (MainWindow::MainWindow):
2483         (MainWindow::create):
2484         (MainWindow::init):
2485         (MainWindow::WndProc):
2486         * MiniBrowser/win/MainWindow.h:
2487         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2488         (PrintWebUIDelegate::createWebViewWithRequest):
2489         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2490         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2491         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2492         (WebKitBrowserWindow::updateProxySettings):
2493         (WebKitBrowserWindow::createNewPage):
2494         * MiniBrowser/win/WebKitBrowserWindow.h:
2495         * MiniBrowser/win/WinMain.cpp:
2496         (wWinMain):
2497
2498 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2499
2500         Make it possible to test scrolling tree layer manipulation more easily
2501         https://bugs.webkit.org/show_bug.cgi?id=195780
2502
2503         Reviewed by Tim Horton.
2504         
2505         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2506         cuts off communication of scrolling tree scrolls back to the web process
2507         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2508         allows tests to trigger scrolls which run the scrolling tree layer positioning
2509         logic, but never get another commit from the web process that might mask
2510         scrolling tree bugs.
2511         
2512         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2513         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2514         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2515
2516         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2517         (WTR::UIScriptController::scrollUpdatesDisabled const):
2518         (WTR::UIScriptController::setScrollUpdatesDisabled):
2519         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2520         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2521         (WTR::UIScriptController::scrollUpdatesDisabled const):
2522         (WTR::UIScriptController::setScrollUpdatesDisabled):
2523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2524         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2525         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2526         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2527         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2528         * WebKitTestRunner/ios/TestControllerIOS.mm:
2529         (WTR::TestController::platformResetStateToConsistentValues):
2530         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2531         (WTR::UIScriptController::scrollUpdatesDisabled const):
2532         (WTR::UIScriptController::setScrollUpdatesDisabled):
2533
2534 2019-03-14  Youenn Fablet  <youenn@apple.com>
2535
2536         Move IDB storage in private browsing mode to NetworkProcess
2537         https://bugs.webkit.org/show_bug.cgi?id=195602
2538
2539         Reviewed by Brady Eidson.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2542         (TEST):
2543
2544 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2545
2546         [ews-build] Make descriptionDone messages more readable
2547         https://bugs.webkit.org/show_bug.cgi?id=195760
2548
2549         Reviewed by Lucas Forschler.
2550
2551         * BuildSlaveSupport/ews-build/steps.py:
2552         * BuildSlaveSupport/ews-build/steps_unittest.py:
2553
2554 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-build] Generate status-bubble hover-over messages
2557         https://bugs.webkit.org/show_bug.cgi?id=195680
2558
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2562         (StatusBubble):
2563         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2564         on hover-over.
2565         (StatusBubble._iso_time):
2566         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2567         hover-over message.
2568         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2569
2570 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2571
2572         [ews-app] Gracefully handle the case when state_string is None
2573         https://bugs.webkit.org/show_bug.cgi?id=195753
2574
2575         Reviewed by Lucas Forschler.
2576
2577         * BuildSlaveSupport/ews-app/ews/models/build.py:
2578         * BuildSlaveSupport/ews-app/ews/models/step.py:
2579
2580 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews-app] Status bubble display pending for currently running build step
2583         https://bugs.webkit.org/show_bug.cgi?id=195744
2584
2585         Reviewed by Lucas Forschler.
2586
2587         * BuildSlaveSupport/ews-build/events.py:
2588         (Events.stepStarted): If state_string is pending, replace it with step name.
2589
2590 2019-03-14  Chris Dumez  <cdumez@apple.com>
2591
2592         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2593         https://bugs.webkit.org/show_bug.cgi?id=195750
2594
2595         Reviewed by Geoffrey Garen.
2596
2597         Add API test coverage.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2600         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2601         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2602         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2603
2604 2019-03-14  Chris Dumez  <cdumez@apple.com>
2605
2606         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2607         https://bugs.webkit.org/show_bug.cgi?id=195747
2608
2609         Reviewed by Geoff Garen.
2610
2611         Add API test coverage.
2612
2613         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2614
2615 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2616
2617         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2618         https://bugs.webkit.org/show_bug.cgi?id=195725
2619         <rdar://problem/48545062>
2620
2621         Reviewed by Tim Horton.
2622
2623         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2624         handler is nil.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2627         (TestWebKitAPI::TEST):
2628
2629 2019-03-13  Sam Weinig  <sam@webkit.org>
2630
2631         Add utility function to allow easy reverse range-based iteration of a container
2632         https://bugs.webkit.org/show_bug.cgi?id=195542
2633
2634         Reviewed by Antti Koivisto.
2635
2636         * TestWebKitAPI/CMakeLists.txt:
2637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2638         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2639         (TestWebKitAPI::TEST):
2640         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2641
2642 2019-03-13  Chris Dumez  <cdumez@apple.com>
2643
2644         Use a ServiceWorker process per registrable domain
2645         https://bugs.webkit.org/show_bug.cgi?id=195649
2646
2647         Reviewed by Youenn Fablet.
2648
2649         Update API test coverage.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2652
2653 2019-03-13  Chris Dumez  <cdumez@apple.com>
2654
2655         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2656         https://bugs.webkit.org/show_bug.cgi?id=195684
2657         <rdar://problem/48294714>
2658
2659         Reviewed by Antti Koivisto.
2660
2661         Add API test coverage.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2664
2665 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2666
2667         [ews-app] Remove unused patch view
2668         https://bugs.webkit.org/show_bug.cgi?id=195669
2669
2670         Reviewed by Lucas Forschler.
2671
2672         * BuildSlaveSupport/ews-app/ews/urls.py:
2673         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2674
2675 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-app] Use Buildbot result code variables
2678         https://bugs.webkit.org/show_bug.cgi?id=195668
2679
2680         Reviewed by Alexey Proskuryakov.
2681
2682         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2683         (Buildbot): Added Buildbot result code variables.
2684         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2685         (StatusBubble._build_bubble): Used Buildbot result code variables.
2686
2687 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2688
2689         [Flatpak] Expand submodule recursively
2690         https://bugs.webkit.org/show_bug.cgi?id=195672
2691
2692         Building WPE with flatpak was impossible without that as it was raising an exception.
2693         Also update wpebackend-fdo to match what is built in jhbuild
2694
2695         Reviewed by Philippe Normand.
2696
2697         * flatpak/flatpakutils.py:
2698         (expand_submodules_recurse):
2699         (expand_manifest):
2700         * flatpak/org.webkit.WPEModules.yaml:
2701
2702 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-app] status bubble should be hidden for certain builds
2705         https://bugs.webkit.org/show_bug.cgi?id=194597
2706
2707         Reviewed by Dewei Zhu.
2708
2709         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2710         (StatusBubble._build_bubble):
2711         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2712         because the patch didn't have relevant changes.
2713         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2714         in production yet.
2715
2716 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2717
2718         [Win] Fix a slew of simple clang-cl warnings.
2719         https://bugs.webkit.org/show_bug.cgi?id=195652
2720
2721         Reviewed by Don Olmstead.
2722
2723         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2724         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2725
2726 2019-03-12  Justin Fan  <justin_fan@apple.com>
2727
2728         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2729         https://bugs.webkit.org/show_bug.cgi?id=195518
2730         <rdar://problem/46322356>
2731
2732         Reviewed by Myles C. Maxfield.
2733
2734         * DumpRenderTree/DerivedSources-input.xcfilelist:
2735         * DumpRenderTree/DerivedSources-output.xcfilelist:
2736
2737 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2738
2739         Unreviewed, rolling out r242825.
2740         https://bugs.webkit.org/show_bug.cgi?id=195648
2741
2742         "Broke webkitpy tests with my change to
2743         lldb_dump_class_layout.py" (Requested by rmorisset on
2744         #webkit).
2745
2746         Reverted changeset:
2747
2748         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2749         classes with suspicious padding"
2750         https://bugs.webkit.org/show_bug.cgi?id=195573
2751         https://trac.webkit.org/changeset/242825
2752
2753 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2754
2755         [ews-build] Show status bubbles while the patch is waiting in queue
2756         https://bugs.webkit.org/show_bug.cgi?id=195618
2757
2758         Reviewed by Lucas Forschler.
2759
2760         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2761         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2762         enabled in initial deployment.
2763         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2764         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2765         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2766         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2767         (StatusBubble._build_bubbles_for_patch):
2768
2769 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2770
2771         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2772         https://bugs.webkit.org/show_bug.cgi?id=195573
2773
2774         Reviewed by Simon Fraser.
2775
2776         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2777
2778         * Scripts/dump-class-layout:
2779         (main):
2780         * lldb/lldb_dump_class_layout.py:
2781         (ClassLayout.__init__):
2782         (ClassLayout._compute_padding_recursive):
2783         (LLDBDebuggerInstance.dump_layout_for_classname):
2784         (LLDBDebuggerInstance):
2785         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2786         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2787
2788 2019-03-12  Chris Dumez  <cdumez@apple.com>
2789
2790         Device Orientation access permission should be denied unless explicitly granted by the client
2791         https://bugs.webkit.org/show_bug.cgi?id=195625
2792
2793         Reviewed by Youenn Fablet.
2794
2795         add API test coverage.
2796
2797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2798         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2799         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2800         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2801         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2802         (runDeviceOrientationTest):
2803         (TEST):
2804         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2805         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2806
2807 2019-03-12  Jer Noble  <jer.noble@apple.com>
2808
2809         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2810         https://bugs.webkit.org/show_bug.cgi?id=195137
2811         <rdar://problem/48810307>
2812
2813         Reviewed by Eric Carlson.
2814
2815         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2816         (TestWebKitAPI::TEST):
2817
2818 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2819
2820         [ews-build] Change urls from uat to production
2821         https://bugs.webkit.org/show_bug.cgi?id=195566
2822
2823         Reviewed by Lucas Forschler.
2824
2825         * BuildSlaveSupport/ews-app/ews/config.py:
2826         * BuildSlaveSupport/ews-build/events.py:
2827         * BuildSlaveSupport/ews-build/steps.py:
2828
2829 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2830
2831         [ews-build] change max_builds for local-worker to 1
2832         https://bugs.webkit.org/show_bug.cgi?id=195568
2833
2834         Reviewed by Lucas Forschler.
2835
2836         * BuildSlaveSupport/ews-build/loadConfig.py:
2837
2838 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2839
2840         Fix the build
2841
2842         * TestRunnerShared/spi/PencilKitTestSPI.h:
2843         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2844
2845 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2846
2847         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2848         https://bugs.webkit.org/show_bug.cgi?id=194131
2849
2850         Reviewed by Michael Catanzaro.
2851
2852         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2853         (uriChanged):
2854         (testUnfinishedSubresourceLoad):
2855         (serverCallback):
2856         (beforeAll):
2857
2858 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2859
2860         WTF::Expected should use std::addressof instead of operator&
2861         https://bugs.webkit.org/show_bug.cgi?id=195604
2862
2863         Reviewed by Myles Maxfield.
2864
2865         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2866         (TestWebKitAPI::Unique::Unique):
2867         (TestWebKitAPI::Unique::operator&):
2868         (TestWebKitAPI::TEST):
2869
2870 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2871
2872         Add Optional to Forward.h.
2873         https://bugs.webkit.org/show_bug.cgi?id=195586
2874
2875         Reviewed by Darin Adler.
2876
2877         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2878         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2879         Remove unnecessary includes from headers.
2880
2881 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2882
2883         Add testing API to hit-test and scroll overflow scrollers
2884         https://bugs.webkit.org/show_bug.cgi?id=195278
2885
2886         Reviewed by Antti Koivisto.
2887         
2888         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2889         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2890         
2891         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2892
2893         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2894         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2895         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2896         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2897         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2898         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2899         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2900         (WTR::enclosingScrollViewIncludingSelf):
2901         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2902
2903 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2904
2905         API test WebKit.RequestTextInputContext fails on iOS
2906         https://bugs.webkit.org/show_bug.cgi?id=195585
2907
2908         Reviewed by Wenson Hsieh and Simon Fraser.
2909
2910         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2911         (applyStyle):
2912         (TEST):
2913         Add a viewport, so that the coordinates match up on iOS.
2914         Scroll by moving the UIScrollView's contentOffset.
2915
2916 2019-03-11  Chris Dumez  <cdumez@apple.com>
2917
2918         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2919         https://bugs.webkit.org/show_bug.cgi?id=195506
2920         <rdar://problem/48733477>
2921
2922         Reviewed by Alex Christensen.
2923
2924         Add API test coverage.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2927
2928 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2929
2930         Adding myself to contributors.json
2931
2932         Unreviewed, addming myself to contributors.json .
2933
2934         * Scripts/webkitpy/common/config/contributors.json:
2935
2936 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2937
2938         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2939         https://bugs.webkit.org/show_bug.cgi?id=195511
2940         <rdar://problem/44873269>
2941
2942         Reviewed by Darin Adler.
2943
2944         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2945         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2946         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2947         (TEST_F):
2948
2949 2019-03-11  Chris Dumez  <cdumez@apple.com>
2950
2951         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2952         https://bugs.webkit.org/show_bug.cgi?id=195561
2953
2954         Reviewed by Youenn Fablet.
2955
2956         Make sure the JS in the test requests for permission to receive device orientation events.
2957
2958         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2959
2960 2019-03-11  Youenn Fablet  <youenn@apple.com>
2961
2962         Allow storage quota increase by default in WTR
2963         https://bugs.webkit.org/show_bug.cgi?id=195541
2964
2965         Reviewed by Geoffrey Garen.
2966
2967         Allow storage quota increase by default in WTR.
2968         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2969         Use this for tests that explicitly need cache increase.
2970
2971         Instead of increasing quota by 2, make sure the next request is
2972         granted by adding all given parameters.
2973
2974         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2975         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2976         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2977         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2979         * WebKitTestRunner/TestController.cpp:
2980         (WTR::TestController::setAllowStorageQuotaIncrease):
2981         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2982         * WebKitTestRunner/TestController.h:
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2985         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2986         (WTR::TestController::cocoaResetStateToConsistentValues):
2987         (WTR::TestController::setAllowStorageQuotaIncrease):
2988         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2989         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2990         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2991
2992 2019-03-11  Xan Lopez  <xan@igalia.com>
2993
2994         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2995         https://bugs.webkit.org/show_bug.cgi?id=194147
2996
2997         Reviewed by Michael Saboff.
2998
2999         To make --32-bit work correctly on Linux/64bit we need to:
3000
3001         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3002         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3003         unfortunately CMake only allows us to do this during
3004         crosscompilation, which is overkill here.
3005         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3006         pkg-config detection module uses the x86 .pc files instead of the
3007         x86_64 ones.
3008         - Set the -m32 flags for the compiler.
3009
3010         * Scripts/webkitdirs.pm:
3011         (generateBuildSystemFromCMakeProject):
3012
3013 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3014
3015         Add MotionMark-1.1 plan file for run-benchmark script.
3016         https://bugs.webkit.org/show_bug.cgi?id=195481
3017
3018         Rubber-stamped by Darin Adler.
3019
3020         Run-benchmark script should support MontionMark-1.1.
3021
3022         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3023
3024 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3025
3026         [ews-app] Add support for submit-to-ews url
3027         https://bugs.webkit.org/show_bug.cgi?id=195477
3028
3029         Reviewed by Lucas Forschler.
3030
3031         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3032         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3033         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3034         * BuildSlaveSupport/ews-app/ews/urls.py:
3035         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3036
3037 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3038
3039         Unreviewed, rolling out r242688, r242643, r242624.
3040
3041         Caused multiple layout test failures and crashes on iOS and macOS.
3042
3043         Reverted changeset:
3044
3045         "requestAnimationFrame should execute before the next frame"
3046         https://bugs.webkit.org/show_bug.cgi?id=177484
3047         https://trac.webkit.org/changeset/242624/webkit
3048
3049         * Tracing/SystemTracePoints.plist:
3050
3051 2019-03-11  John Wilander  <wilander@apple.com>
3052
3053         Resource Load Statistics: Make it possible exclude localhost from classification
3054         https://bugs.webkit.org/show_bug.cgi?id=195474
3055         <rdar://problem/47520577>
3056
3057         Reviewed by Brent Fulgham.
3058
3059         This patch allows for localhost to be excluded from classification and
3060         treatment as a prevalent resource.
3061
3062         The WebKit Tools change adds a new function called
3063         testRunner.setStatisticsIsRunningTest() which can be used to control this
3064         behavior.
3065
3066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3067         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3068         (WTR::TestRunner::setStatisticsIsRunningTest):
3069         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3070         * WebKitTestRunner/TestController.cpp:
3071         (WTR::TestController::setStatisticsIsRunningTest):
3072         * WebKitTestRunner/TestController.h:
3073         * WebKitTestRunner/TestInvocation.cpp:
3074         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3075
3076 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3077
3078         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3079         https://bugs.webkit.org/show_bug.cgi?id=195560
3080
3081         Reviewed by Lucas Forschler.
3082
3083         * BuildSlaveSupport/ews-build/master.cfg:
3084
3085 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3086
3087         Unreviewed, rolling out r242698.
3088
3089         API test crashes on bots.
3090
3091         Reverted changeset:
3092
3093         "Add a WKContentRuleList variant that uses copied memory
3094         instead of mmap'd shared memory for class A containerized
3095         apps"
3096         https://bugs.webkit.org/show_bug.cgi?id=195511
3097         https://trac.webkit.org/changeset/242698
3098
3099 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3100
3101         [WPE] Enable web process sandbox
3102         https://bugs.webkit.org/show_bug.cgi?id=195169
3103
3104         Reviewed by Daniel Bates.
3105
3106         * wpe/install-dependencies:
3107         * wpe/jhbuild.modules:
3108
3109 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3110
3111         [ews-app] Use port 17000 for worker communication
3112         https://bugs.webkit.org/show_bug.cgi?id=195558
3113
3114         Reviewed by Lucas Forschler.
3115
3116         * BuildSlaveSupport/ews-build/master.cfg:
3117
3118 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-build] unit-tests fail when passwords.json is missing
3121         https://bugs.webkit.org/show_bug.cgi?id=195557
3122
3123         Reviewed by Lucas Forschler.
3124
3125         * BuildSlaveSupport/ews-build/loadConfig.py:
3126         (loadBuilderConfig):
3127         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3128         (ConfigDotJSONTest.test_configuration):
3129         * BuildSlaveSupport/ews-build/master.cfg:
3130
3131 2019-03-11  Truitt Savell  <tsavell@apple.com>
3132
3133         Unreviewed, rolling out r242702.
3134
3135         Broke High Sierra builders.
3136
3137         Reverted changeset:
3138
3139         "Add utility function to allow easy reverse range-based
3140         iteration of a container"
3141         https://bugs.webkit.org/show_bug.cgi?id=195542
3142         https://trac.webkit.org/changeset/242702
3143
3144 2019-03-11  Sam Weinig  <sam@webkit.org>
3145
3146         Add utility function to allow easy reverse range-based iteration of a container
3147         https://bugs.webkit.org/show_bug.cgi?id=195542
3148
3149         Reviewed by Antti Koivisto.
3150
3151         * TestWebKitAPI/CMakeLists.txt:
3152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3153         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3154         (TestWebKitAPI::TEST):
3155         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3156
3157 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3158
3159         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3160         https://bugs.webkit.org/show_bug.cgi?id=195511
3161         <rdar://problem/44873269>
3162
3163         Reviewed by Darin Adler.
3164
3165         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3166         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3167         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3168         (TEST_F):
3169
3170 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3171
3172         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3173         https://bugs.webkit.org/show_bug.cgi?id=195499
3174
3175         Reviewed by Darin Adler.
3176
3177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3178         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3179         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3180         (-[WKWebView synchronouslyFocusTextInputContext:]):
3181         (applyStyle):
3182         (applyIframe):
3183         (TEST):
3184         Add some tests for this SPI.
3185
3186 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3187
3188         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3189         https://bugs.webkit.org/show_bug.cgi?id=181151
3190
3191         Reviewed by Don Olmstead.
3192
3193         * TestWebKitAPI/CMakeLists.txt:
3194         * TestWebKitAPI/PlatformWin.cmake:
3195         Enable TestWTF RunLoop tests in all platforms.
3196
3197         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3198         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3199         (TestWebKitAPI::DerivedOneShotTimer::fired):
3200         (TestWebKitAPI::TEST):
3201         Only a few platforms support nested RunLoop.
3202
3203         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3204         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3205
3206 2019-03-10  David Quesada  <david_quesada@apple.com>
3207
3208         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3209         https://bugs.webkit.org/show_bug.cgi?id=152480
3210
3211         Reviewed by Chris Dumez.
3212
3213         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3214         there are no additional references to the process pool besides the one held by
3215         the download, waits for the download to finish (in the sense that the
3216         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3217         measure, also check that the process pool has been deallocated at the end of the
3218         test. The test wouldn't be meaningful if the process pool were still alive.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3221         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3222         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3223             The download will be canceled because the delegate does not implement the
3224             method to decide the download's destination, so this is where we know the
3225             DownloadProxyMap is done with the DownloadProxy.
3226         (TEST):
3227
3228 2019-03-08  Chris Dumez  <cdumez@apple.com>
3229
3230         Add support for Device Orientation / Motion permission API
3231         https://bugs.webkit.org/show_bug.cgi?id=195329
3232         <rdar://problem/47645367>
3233
3234         Reviewed by Geoffrey Garen.
3235
3236         Add test infrastructure to help test the Device Orientation / Motion permission API.
3237
3238         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3240         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3242         * WebKitTestRunner/TestController.cpp:
3243         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3244         (WTR::TestController::createWebViewWithOptions):
3245         (WTR::TestController::resetStateToConsistentValues):
3246         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3247         * WebKitTestRunner/TestController.h:
3248         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3249         * WebKitTestRunner/TestInvocation.cpp:
3250         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3251
3252 2019-03-08  Saam barati  <sbarati@apple.com>
3253
3254         Add a compare-results script to compare benchmark results
3255         https://bugs.webkit.org/show_bug.cgi?id=195486
3256         <rdar://problem/48723397>
3257
3258         Reviewed by Geoffrey Garen.
3259
3260         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3261         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3262         to extend it to learn about our other benchmarks.
3263
3264         * Scripts/compare-results: Added.
3265         (readJSONFile):
3266         (detectJetStream2):
3267         (JetStream2Results):
3268         (detectSpeedometer2):
3269         (Speedometer2Results):
3270         (detectPLT5):
3271         (PLT5Results):
3272         (detectBenchmark):
3273         (biggerIsBetter):
3274         (ttest):
3275         (getOptions):
3276         (main):
3277
3278 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3279
3280         Ensure old tab state is cleared between iterations of run-benchmark
3281         https://bugs.webkit.org/show_bug.cgi?id=195393
3282         <rdar://problem/46885583>
3283
3284         Reviewed by Dewei Zhu.
3285
3286         a) ensure the default to restore state is not set
3287         b) terminate Safari correctly
3288         c) Set the system default to ignore Persistent State in Safari
3289
3290         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3291         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3292         (OSXBrowserDriver.prepare_env): 
3293         (OSXBrowserDriver.restore_env):
3294         (OSXBrowserDriver.close_browsers):
3295         (OSXBrowserDriver._terminate_processes):
3296         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3297         (OSXChromeDriver):
3298         (OSXChromeCanaryDriver):
3299         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3300         (OSXFirefoxDriver):
3301         (OSXFirefoxNightlyDriver):
3302         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3303         (OSXSafariDriver):
3304         (OSXSafariDriver.prepare_env):
3305
3306 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3307
3308         [GTK] Several InputMethodFilter tests are failing
3309         https://bugs.webkit.org/show_bug.cgi?id=195408
3310
3311         Reviewed by Carlos Garcia Campos.
3312
3313         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3314         Regressed in r241751.
3315         Hexadecimal values of keycodes are expressed now in upper letters.
3316         Composited characters should be cast to UTF8 strings.
3317
3318         (TestWebKitAPI::TEST):
3319
3320 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3321
3322         [GTK] Make Tools/gtkdoc python3 compatible
3323         https://bugs.webkit.org/show_bug.cgi?id=195359
3324
3325         Reviewed by Carlos Garcia Campos.
3326
3327         * gtkdoc/generate-gtkdoc:
3328         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3329         work with Python 2 and 3.
3330         (get_gtkdoc_module_paths):
3331         The iteritems() was removed in Python 3, so let's use items() that's
3332         available in Python 2 and 3.
3333         (get_generator_for_config):
3334         * gtkdoc/gtkdoc.py:
3335         (GTKDoc._run_command):
3336         The sys.stdout.write() is expecting str in Python 3 and not bytes
3337         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3338         for passing the bytes there.
3339
3340 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3341
3342         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3343         https://bugs.webkit.org/show_bug.cgi?id=195346
3344         <rdar://problem/48667048>
3345
3346         Unreviewed build fix for clang-cl.
3347
3348         * DumpRenderTree/win/DumpRenderTree.cpp:
3349         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3350
3351 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3352
3353         requestAnimationFrame should execute before the next frame
3354         https://bugs.webkit.org/show_bug.cgi?id=177484
3355
3356         Reviewed by Simon Fraser.
3357
3358         Add trace points for the page RenderingUpdate.
3359
3360         * Tracing/SystemTracePoints.plist:
3361
3362 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3363
3364         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3365         https://bugs.webkit.org/show_bug.cgi?id=195353
3366         <rdar://problem/48626394>
3367
3368         Reviewed by Simon Fraser.
3369
3370         * WebKitTestRunner/ios/TestControllerIOS.mm:
3371         (WTR::TestController::platformResetPreferencesToConsistentValues):
3372
3373 2019-03-07  John Wilander  <wilander@apple.com>
3374
3375         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3376         https://bugs.webkit.org/show_bug.cgi?id=195383
3377         <rdar://problem/48570136>
3378
3379         Reviewed by Brent Fulgham.
3380
3381         This patch adds test infrastructure to purge only script-accessible cookies,
3382         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3383
3384         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3386         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3388         * WebKitTestRunner/TestController.cpp:
3389         (WTR::TestController::statisticsDeleteCookiesForHost):
3390         * WebKitTestRunner/TestController.h:
3391         * WebKitTestRunner/TestInvocation.cpp:
3392         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3393
3394 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3395
3396         Unreviewed, rolling out r242354.
3397         https://bugs.webkit.org/show_bug.cgi?id=195402
3398
3399         breaks layout tests in all configurations (Requested by
3400         zdobersek on #webkit).
3401
3402         Reverted changeset:
3403
3404         "[WPE] Enable web process sandbox"
3405         https://bugs.webkit.org/show_bug.cgi?id=195169
3406         https://trac.webkit.org/changeset/242354
3407
3408 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3409
3410         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3411         https://bugs.webkit.org/show_bug.cgi?id=195346
3412
3413         Reviewed by Fujii Hironori.
3414
3415         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3416         (TestWebKitAPI::TEST):
3417         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3418
3419         * DumpRenderTree/win/DumpRenderTree.cpp:
3420         (findFontFallback):
3421         (addFontFallbackIfPresent):
3422         (removeFontFallbackIfPresent):
3423         (main):
3424         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3425         (TestWebKitAPI::Util::moduleDirectory):
3426         (TestWebKitAPI::Util::createInjectedBundlePath):
3427         Use wchar helpers as needed.
3428
3429 2019-03-06  Rob Buis  <rbuis@igalia.com>
3430
3431         Consider supporting the `referrerpolicy` attribute.
3432         https://bugs.webkit.org/show_bug.cgi?id=179053
3433
3434         Reviewed by Darin Adler.
3435
3436         Add a runtime flag for referrerpolicy attribute.
3437
3438         * DumpRenderTree/mac/DumpRenderTree.mm:
3439         (enableExperimentalFeatures):
3440
3441 2019-03-05  Daniel Bates  <dabates@apple.com>
3442
3443         Update expected API test result following r242379
3444         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3445
3446         Update expected x-coordinate of selection rect now that the left padding of
3447         a textarea is sized in ems (so dependent on the font size) just like the left
3448         padding of a text field.
3449
3450         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3451         (TestWebKitAPI::TEST):
3452
3453 2019-03-05  David Quesada  <david_quesada@apple.com>
3454
3455         [WK2] It should be possible to follow links with 'download' attributes
3456         https://bugs.webkit.org/show_bug.cgi?id=195145
3457         rdar://problem/48462642
3458
3459         Reviewed by Alex Christensen.
3460
3461         Add a unit test to verify that activating links with 'download' attributes now
3462         navigates to the linked resource, rather than starts downloading it. Add another
3463         to verify that it is still possible to explicitly download the link via the
3464         'Download' navigation action policy.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3467         (-[DownloadAttributeTestDelegate init]):
3468         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3469         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3470         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3471         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3472         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3473         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3474         (TEST):
3475         * WebKitTestRunner/TestController.cpp:
3476         (WTR::TestController::decidePolicyForNavigationAction):
3477         * WebKitTestRunner/TestController.h:
3478
3479 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3480
3481         [Curl] Implement Cookie Accept Policy.
3482         https://bugs.webkit.org/show_bug.cgi?id=191645
3483
3484         Reviewed by Fujii Hironori.
3485
3486         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3487         (TestWebKitAPI::Curl::TEST_F):
3488
3489 2019-03-05  Youenn Fablet  <youenn@apple.com>
3490
3491         Rename requestCacheStorageSpace to requestStorageSpace
3492         https://bugs.webkit.org/show_bug.cgi?id=195282
3493
3494         Reviewed by Chris Dumez.
3495
3496         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3497         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3498         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3499
3500 2019-03-05  Brady Eidson  <beidson@apple.com>
3501
3502         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3503         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3504
3505         Reviewed by Tim Horton.
3506
3507         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3508         different directory into that same WKWebView should work.
3509
3510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3511         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3512
3513 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3514
3515         Add WeakHashSet
3516         https://bugs.webkit.org/show_bug.cgi?id=195152
3517
3518         Reviewed by Antti Koivisto.
3519
3520         Added tests for WeakHashSet.
3521
3522         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3523         (TestWebKitAPI::Base::Base): Moved.
3524         (TestWebKitAPI::Derived::foo): Moved.
3525         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3526         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3527         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3528         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3529
3530 2019-03-04  Chris Dumez  <cdumez@apple.com>
3531
3532         Do not share WebProcesses between private and regular sessions
3533         https://bugs.webkit.org/show_bug.cgi?id=195189
3534         <rdar://problem/48421064>
3535
3536         Reviewed by Alex Christensen.
3537
3538         Add API test coverage.
3539
3540         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3541         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3542
3543 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3544
3545         [WPE] Enable web process sandbox
3546         https://bugs.webkit.org/show_bug.cgi?id=195169
3547
3548         Reviewed by Daniel Bates.
3549
3550         * wpe/install-dependencies:
3551         * wpe/jhbuild.modules:
3552
3553 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3554
3555         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3556         https://bugs.webkit.org/show_bug.cgi?id=195206
3557
3558         Reviewed by Žan Doberšek.
3559
3560         Add a new test case.
3561
3562         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3563         (testJSCClass):
3564
3565 2019-03-04  Charlie Turner  <cturner@igalia.com>
3566
3567         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3568         https://bugs.webkit.org/show_bug.cgi?id=194898
3569
3570         Reviewed by Žan Doberšek.
3571
3572         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3573         a GCC extension that permits arithmetic on void* pointer. Inline
3574         the macro until this issue is fixed upstream.
3575
3576 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3577
3578         Rid the world of WK_API_ENABLED
3579         https://bugs.webkit.org/show_bug.cgi?id=195263
3580
3581         Reviewed by Dan Bernstein.
3582
3583         List of changed files elided because it's useless.
3584
3585 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3586
3587         Unreviewed follow-up to r242292.
3588
3589         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3590
3591         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3592         (TestWebKitAPI::testStrip): Renamed from strip.
3593         (TestWebKitAPI::TEST):
3594
3595 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3596
3597         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3598
3599         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3600         and bug #194272 for details.
3601
3602         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3603
3604 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3605
3606         Remove some more unused 32-bit code
3607         https://bugs.webkit.org/show_bug.cgi?id=195255
3608
3609         Reviewed by Darin Adler.
3610
3611         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3612         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3613         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3614         (NPP_New):
3615         (NPP_HandleEvent):
3616         (handleEventCarbon): Deleted.
3617
3618 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3619
3620         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3621
3622         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3623         (TestWebKitAPI::TEST):
3624
3625 2019-03-01  Darin Adler  <darin@apple.com>
3626
3627         Finish removing String::format
3628         https://bugs.webkit.org/show_bug.cgi?id=194893
3629
3630         Reviewed by Daniel Bates.
3631 '
3632         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3633
3634 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3635
3636         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3637         https://bugs.webkit.org/show_bug.cgi?id=195229
3638         <rdar://problem/48520362>
3639
3640         Reviewed by Chris Dumez.
3641
3642         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3643         (TEST):
3644
3645 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3646
3647         Add a system trace scope for event region building
3648         https://bugs.webkit.org/show_bug.cgi?id=195226
3649
3650         Reviewed by Jon Lee.
3651
3652         This trace scope measures the time spend converting element rects into Region objects,
3653         which can be large on some pages.
3654
3655         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3656
3657         * Tracing/SystemTracePoints.plist:
3658
3659 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3660
3661         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3662         https://bugs.webkit.org/show_bug.cgi?id=194612
3663
3664         Reviewed by Alex Christensen.
3665
3666         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3667         Just test the new string-processing function and don't touch the actual environment.
3668         (Test cases are all as before, but based on operator== instead of strcmp.)
3669
3670 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3671
3672         [ews-app] Update primary keys for handling multiple Buildbot instances
3673         https://bugs.webkit.org/show_bug.cgi?id=195120
3674
3675         Reviewed by Stephanie Lewis.
3676
3677         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3678         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3679         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3680
3681         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3682         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3683         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3684         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3685         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3686         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3687
3688 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3689
3690         [WinCairo] Enable service worker
3691         https://bugs.webkit.org/show_bug.cgi?id=188318
3692
3693         Reviewed by Youenn Fablet.
3694
3695         * DumpRenderTree/DumpRenderTreePrefix.h:
3696         * TestWebKitAPI/PlatformWin.cmake:
3697         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3698         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3699         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3700
3701 2019-03-01  Justin Fan  <justin_fan@apple.com>
3702
3703         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3704         https://bugs.webkit.org/show_bug.cgi?id=195191
3705
3706         Rubber-stamped by Dean Jackson.
3707
3708         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3709
3710         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3711
3712 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3713
3714         Unreviewed, fix lldb webkitpy tests
3715         https://bugs.webkit.org/show_bug.cgi?id=194375
3716
3717         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3718
3719         * lldb/lldb_webkit.py:
3720         (WTFStringImplProvider.is_8bit):
3721
3722 2019-02-28  David Quesada  <david_quesada@apple.com>
3723
3724         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3725         https://bugs.webkit.org/show_bug.cgi?id=195121
3726         rdar://problem/48450302
3727
3728         Reviewed by Alex Christensen.
3729
3730         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3731         configurations where the 'download' attribute is absent, blank, or populated
3732         with a filename, and where the anchor element is same-origin or cross-origin
3733         (meaning the 'download' attribute shouldn't be honored).
3734
3735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3736         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3737         (-[NavigationActionTestDelegate init]):
3738         (-[NavigationActionTestDelegate navigationAction]):
3739         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3740         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3741         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3742         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3743         (TEST):
3744
3745 2019-02-28  Antoine Quint  <graouts@apple.com>
3746
3747         Enable the Pointer Events runtime flag by default
3748         https://bugs.webkit.org/show_bug.cgi?id=195156
3749
3750         Reviewed by Dean Jackson.
3751
3752         * DumpRenderTree/mac/DumpRenderTree.mm:
3753         (enableExperimentalFeatures):
3754
3755 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3756
3757         Several PasteImage API tests are flaky
3758         https://bugs.webkit.org/show_bug.cgi?id=195160
3759
3760         Reviewed by Tim Horton.
3761
3762         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3763         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3764         listening for a "load" event after image load is already complete.
3765
3766         To address this, make these tests first register a "load" event handler, then run script to insert an image
3767         element into the document, and finally wait until the load event is observed before checking image size.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3770
3771 2019-02-28  Chris Dumez  <cdumez@apple.com>
3772
3773         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3774         https://bugs.webkit.org/show_bug.cgi?id=195107
3775
3776         Reviewed by Alex Christensen.
3777
3778         Give some time for the zoom level to get restored.
3779
3780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3781
3782 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3783
3784         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3785         https://bugs.webkit.org/show_bug.cgi?id=194958
3786
3787         Reviewed by Geoffrey Garen.
3788
3789         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3790         (TEST):
3791
3792 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3793
3794         [ews-app] Update method to save build to handle builder_display_name
3795         https://bugs.webkit.org/show_bug.cgi?id=195047
3796
3797         Reviewed by Dewei Zhu.
3798
3799         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3800         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3801
3802 2019-02-28  Justin Fan  <justin_fan@apple.com>
3803
3804         [Web GPU] Enable Web GPU only on 64-bit
3805         https://bugs.webkit.org/show_bug.cgi?id=195139
3806
3807         Because Metal is only supported on 64 bit apps.
3808
3809         Unreviewed build fix.
3810
3811         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3812
3813 2019-02-27  Youenn Fablet  <youenn@apple.com>
3814
3815         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3816         https://bugs.webkit.org/show_bug.cgi?id=194959
3817
3818         Reviewed by Chris Dumez.
3819
3820         Spin loop until getting the condition to remove flakiness.
3821
3822         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3823
3824 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3825
3826         [ews-build] Buildbot should include builder_display_name in the build events
3827         https://bugs.webkit.org/show_bug.cgi?id=195045
3828
3829         Reviewed by Dewei Zhu.
3830
3831         * BuildSlaveSupport/ews-build/events.py:
3832         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3833         buildername to builder_name to be consistent in naming style.
3834         (Events.buildFinished): Ditto.
3835
3836 2019-02-27  Chris Dumez  <cdumez@apple.com>
3837
3838         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3839         https://bugs.webkit.org/show_bug.cgi?id=194480
3840
3841         Reviewed by Brady Eidson.
3842
3843         Update existing API test to make it more likely to reproduce the issue.
3844
3845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3846
3847 2019-02-27  Brady Eidson  <beidson@apple.com>
3848
3849         Universal links from Google search results pages don't open the app.
3850         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3851
3852         Reviewed by Geoffrey Garen.
3853
3854         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3855         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3856         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3857         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3858
3859 2019-02-27  Chris Dumez  <cdumez@apple.com>
3860
3861         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3862         https://bugs.webkit.org/show_bug.cgi?id=195102
3863
3864         Reviewed by Geoffrey Garen.
3865
3866         If the number of processes is not yet what we expect, wait a bit and check again to give
3867         processes some time to exit.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3870
3871 2019-02-27  Chris Dumez  <cdumez@apple.com>
3872
3873         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3874         https://bugs.webkit.org/show_bug.cgi?id=194545
3875
3876         Reviewed by Brady Eidson.
3877
3878         Make sure the test navigates forward and then back only once. Previously, navigating
3879         back would trigger a navigation again in a timer.
3880
3881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3882
3883 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3884
3885         High Sierra Debug JSC test queue should use faster hardware
3886         https://bugs.webkit.org/show_bug.cgi?id=194603
3887
3888         Rubber-stamped by Alexey Proskuryakov.
3889
3890         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3891
3892         * BuildSlaveSupport/build.webkit.org-config/config.json:
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3894         (BubbleQueueServer):
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3896         (WebKitBuildbot):
3897         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3898         * QueueStatusServer/config/queues.py:
3899         * Scripts/webkitpy/common/config/ews.json:
3900         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3901         (test_ews_name):
3902
3903 2019-02-27  John Wilander  <wilander@apple.com>
3904
3905         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3906         https://bugs.webkit.org/show_bug.cgi?id=195071
3907         <rdar://problem/48417690>
3908
3909         Reviewed by Alex Christensen and Brent Fulgham.
3910
3911         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3912         (TestWebKitAPI::createURL):
3913             Convenience function.
3914         (TestWebKitAPI::TEST):
3915             WebCore::AdClickAttribution now takes a URL when creating Source and
3916             Destination.
3917         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3918         (TestWebKitAPI::TEST):
3919             WebCore::AdClickAttribution now takes a URL when creating Source and
3920             Destination.
3921
3922 2019-02-27  Antoine Quint  <graouts@apple.com>
3923
3924         Support Pointer Events on macOS
3925         https://bugs.webkit.org/show_bug.cgi?id=195008
3926         <rdar://problem/47454419>
3927
3928         Reviewed by Dean Jackson.
3929
3930         * DumpRenderTree/mac/DumpRenderTree.mm:
3931         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3933
3934 2019-02-26  Mark Lam  <mark.lam@apple.com>
3935
3936         Remove remaining poisoning code.
3937         https://bugs.webkit.org/show_bug.cgi?id=194138
3938
3939         Reviewed by Saam Barati.
3940
3941         * TestWebKitAPI/CMakeLists.txt:
3942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3943         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3944         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3945         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3946         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3947         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3948         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3949
3950 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3951
3952         Move ephemeral local storage from WebProcess to UIProcess
3953         https://bugs.webkit.org/show_bug.cgi?id=195074
3954         <rdar://problem/47937975>
3955
3956         Reviewed by Geoff Garen.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3959
3960 2019-02-20  Jer Noble  <jer.noble@apple.com>
3961
3962         [Cocoa] Media elements will restart network buffering just before suspending
3963         https://bugs.webkit.org/show_bug.cgi?id=193691
3964
3965         Reviewed by Eric Carlson.
3966
3967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3969         (TEST):
3970
3971 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3972
3973         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3974         https://bugs.webkit.org/show_bug.cgi?id=191652
3975
3976         Reviewed by Alex Christensen.
3977
3978         Fix WinCairo MiniBrowser behavior of authentication dialog.
3979
3980         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3981         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3982
3983 2019-02-26  Youenn Fablet  <youenn@apple.com>
3984
3985         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3986         https://bugs.webkit.org/show_bug.cgi?id=195028
3987         <rdar://problem/48243733>
3988
3989         Reviewed by Eric Carlson.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3992
3993 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3994
3995         [WPE] Add API for webview background color configuration
3996         https://bugs.webkit.org/show_bug.cgi?id=192305
3997
3998         Reviewed by Michael Catanzaro.
3999
4000         * MiniBrowser/wpe/main.cpp:
4001         (main): Add a new option to configure the webview background
4002         color. Example: --bg-color=transparent.
4003         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4004         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4005         (beforeAll): Ditto.
4006
4007 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4008
4009         scalableNativeWebpageParameters() is not preserved on new page navigation.
4010         https://bugs.webkit.org/show_bug.cgi?id=194892
4011         <rdar://problem/47538280>
4012
4013         Reviewed by Wenson Hsieh.
4014         
4015         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4016
4017         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4018         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4019         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4020         (WTR::UIScriptController::allowsViewportShrinkToFit):
4021         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4022         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4023         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4024         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4025         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4026         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4027
4028 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4029
4030         [ews-app] Add model for handling multiple Buildbot instances
4031         https://bugs.webkit.org/show_bug.cgi?id=194863
4032
4033         Reviewed by Stephanie Lewis.
4034
4035         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4036
4037 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4038
4039         [ews-app] Remove BuilderMapping table
4040         https://bugs.webkit.org/show_bug.cgi?id=194961
4041
4042         Reviewed by Stephanie Lewis.
4043
4044         Store builder name directly in build table, instead of having a separate
4045         table for it.
4046
4047         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4048         * BuildSlaveSupport/ews-app/ews/models/build.py:
4049         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4050         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4051
4052 2019-02-25  John Wilander  <wilander@apple.com>
4053
4054         Introduce and adopt new class RegistrableDomain for eTLD+1
4055         https://bugs.webkit.org/show_bug.cgi?id=194791
4056         <rdar://problem/48179240>
4057
4058         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4059
4060         This patch adds an API test and replaces two instances of
4061         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4062
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4065         (TestWebKitAPI::TEST):
4066             Changed two strings to make sure the registrable domains are still considered
4067             invalid and pass the test.
4068         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4069         (TestWebKitAPI::TEST):
4070         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4071         (WTR::InjectedBundle::didReceiveMessageToPage):
4072
4073 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4074
4075         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4076         https://bugs.webkit.org/show_bug.cgi?id=195001
4077
4078         Reviewed by Carlos Garcia Campos.
4079
4080         API version 1.0 always includes the functionality previously guarded with
4081         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4082         unconditionally.
4083
4084         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4085         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4086         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4087         (WebViewTest::showInWindow): Ditto.
4088         (WebViewTest::hideView): Ditto.
4089         * wpe/backends/HeadlessViewBackend.cpp:
4090         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4091         * wpe/backends/ViewBackend.cpp:
4092         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4093         * wpe/backends/WindowViewBackend.cpp:
4094         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4095         WPE_BACKEND_CHECK_VERSION().
4096         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4097
4098 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4099
4100         [Flatpak] Add support for flatpak > 1.1.2
4101         https://bugs.webkit.org/show_bug.cgi?id=194088
4102
4103         Flatpak 1.2 is now out so we need to support that
4104         version now.
4105
4106         Reviewed by Michael Catanzaro.
4107
4108         * flatpak/flatpakutils.py:
4109         (check_flatpak):
4110         (FlatpakPackages.__init__):
4111         (FlatpakPackages.__detect_packages):
4112         (FlatpakPackages.__detect_packages.in):
4113         (FlatpakRepos.update):
4114
4115 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4116
4117         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4118         https://bugs.webkit.org/show_bug.cgi?id=194998
4119
4120         Reviewed by Carlos Garcia Campos.
4121
4122         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4123         to a Git checkout and using the latest commit containing various fixes
4124         and improvements.
4125
4126 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4127
4128         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4129         https://bugs.webkit.org/show_bug.cgi?id=194981
4130
4131         Reviewed by Žan Doberšek.
4132
4133         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4134         (TestWebKitAPI::TEST):
4135
4136 2019-02-23  Keith Miller  <keith_miller@apple.com>
4137
4138         Add new mac target numbers
4139         https://bugs.webkit.org/show_bug.cgi?id=194955
4140
4141         Reviewed by Tim Horton.
4142
4143         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4144         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4145         * MiniBrowser/Configurations/Base.xcconfig:
4146         * TestWebKitAPI/Configurations/Base.xcconfig:
4147         * WebKitTestRunner/Configurations/Base.xcconfig:
4148
4149 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4150
4151         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4152         https://bugs.webkit.org/show_bug.cgi?id=194846
4153
4154         Reviewed by Don Olmstead.
4155
4156         Added _search_paths() and _port_specific_expectations_files() for
4157         WinCairoPort.
4158
4159         * Scripts/webkitpy/port/win.py:
4160         (WinCairoPort.default_baseline_search_path):
4161         (WinCairoPort):
4162         (WinCairoPort._port_specific_expectations_files):
4163         (WinCairoPort._search_paths):
4164
4165 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4166
4167         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4168         https://bugs.webkit.org/show_bug.cgi?id=194963
4169
4170         Reviewed by Dean Jackson.
4171
4172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4173         Do a `contains` check instead of `equals`, because in debug builds we
4174         put the GraphicsLayer pointer in a prefix.
4175
4176 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4177
4178         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4179         https://bugs.webkit.org/show_bug.cgi?id=194873
4180         <rdar://problem/46701974>
4181
4182         Reviewed by Tim Horton.
4183
4184         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4185
4186         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4187         (WTR::UIScriptController::menuRect const):
4188         (WTR::UIScriptController::isShowingMenu const):
4189         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4190         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4191         (WTR::UIScriptController::menuRect const):
4192
4193         Add a function to query the bounds of the callout menu in content coordinates.
4194
4195         (WTR::UIScriptController::isShowingMenu const):
4196
4197         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4198
4199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4200         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4201         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4202         (WTR::UIScriptController::rectForMenuAction const):
4203         (WTR::UIScriptController::menuRect const):
4204         (WTR::UIScriptController::isShowingMenu const):
4205         (WTR::findViewInHierarchyOfType): Deleted.
4206
4207 2019-02-22  Chris Dumez  <cdumez@apple.com>
4208
4209         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4210         https://bugs.webkit.org/show_bug.cgi?id=194954
4211         <rdar://problem/48127957>
4212
4213         Reviewed by Alex Christensen.
4214
4215         Add API test coverage.
4216
4217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4218         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4219         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4220         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4221
4222 2019-02-22  Chris Dumez  <cdumez@apple.com>
4223
4224         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4225         https://bugs.webkit.org/show_bug.cgi?id=194924
4226         <rdar://problem/48216125>
4227
4228         Reviewed by Geoffrey Garen.
4229
4230         Add API test coverage.
4231
4232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4233
4234 2019-02-22  Chris Dumez  <cdumez@apple.com>
4235
4236         Unreviewed, disable API test added in r241928 on iOS.
4237
4238         The cache is not enabled on devices with less than 3GB of RAM.
4239
4240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4241
4242 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4243
4244         Hardcode Visual Viewports on everywhere except iOS WK1
4245         https://bugs.webkit.org/show_bug.cgi?id=194928
4246
4247         Reviewed by Zalan Bujtas.
4248
4249         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4250         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4251         set it to false. The setting has shipped for several years and there's no need to turn
4252         it off now.
4253
4254         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4255         Visual Viewports are not enabled.
4256         
4257         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4258         that only runs in WK2
4259
4260         * MiniBrowser/mac/SettingsController.h:
4261         * MiniBrowser/mac/SettingsController.m:
4262         (-[SettingsController init]):
4263         (-[SettingsController _populateMenu]):
4264         (-[SettingsController validateMenuItem:]):
4265         (-[SettingsController visualViewportEnabled]): Deleted.
4266         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4267         * MiniBrowser/mac/WK1BrowserWindowController.m:
4268         (-[WK1BrowserWindowController didChangeSettings]):
4269         * MiniBrowser/mac/WK2BrowserWindowController.m:
4270         (-[WK2BrowserWindowController didChangeSettings]):
4271
4272 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4273
4274         Discard cached processes when clearing website data store
4275         https://bugs.webkit.org/show_bug.cgi?id=194894
4276
4277         Reviewed by Chris Dumez.
4278
4279         Added a test case.
4280
4281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4282         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4283
4284 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4285
4286         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4287         https://bugs.webkit.org/show_bug.cgi?id=194914
4288         <rdar://problem/47586889>
4289
4290         Reviewed by Geoffrey Garen.
4291
4292         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4293         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4294         (TEST):
4295         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4296
4297 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4298
4299         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4300         <https://webkit.org/b/194761>
4301
4302         Reviewed by Myles Maxfield.
4303
4304         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4305         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4306         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4307         to use ARC-compliant cast.
4308         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4309         ARC-compliant cast.
4310         (WTR::installFakeHelvetica): Log `error` to console if
4311         CTFontManagerRegisterFontsForURL() fails, but only on supported
4312         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4313         Call CFRelease() on `error` to fix the leak.  Update to use
4314         ARC-compliant cast.
4315         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4316         cast.
4317
4318 2019-02-21  Chris Dumez  <cdumez@apple.com>
4319
4320         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4321         https://bugs.webkit.org/show_bug.cgi?id=194481
4322
4323         Reviewed by Alex Christensen.
4324
4325         Give the processes a chance to shutdown and wait until we reached the expected number
4326         of processes.
4327
4328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4329
4330 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4331
4332         Fix the macOS build
4333
4334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4335
4336 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4337
4338         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4339
4340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4341         I am a backwards.
4342
4343 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4344
4345         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4348         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4349         We could force on UI-side compositing, but I feel like the test might be more
4350         valuable exercising the normal path on each platform (though the original
4351         bug was also UI-side specific). Though we can't validate that the overlay
4352         layer was installed successfully, there are layout tests that do that.
4353
4354 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4355
4356         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4357         https://bugs.webkit.org/show_bug.cgi?id=194845
4358         <rdar://problem/47944579>
4359
4360         Reviewed by Antti Koivisto.
4361
4362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4364
4365 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4366