Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-17  Zalan Bujtas  <zalan@apple.com>
2
3         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
4         https://bugs.webkit.org/show_bug.cgi?id=133029
5
6         Reviewed by Simon Fraser.
7
8         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
9         toggling it on a WK2 window needs restart.
10         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
11         the WebPreferences just to support this temporary toggle.
12
13         * MiniBrowser/mac/BrowserWindowController.h:
14         * MiniBrowser/mac/MainMenu.xib:
15         * MiniBrowser/mac/WK1BrowserWindowController.m:
16         (-[WK1BrowserWindowController validateMenuItem:]):
17         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
18         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
19         * MiniBrowser/mac/WK2BrowserWindowController.m:
20         (-[WK2BrowserWindowController validateMenuItem:]):
21         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
22         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
23
24 2014-05-17  Anders Carlsson  <andersca@apple.com>
25
26         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
27         https://bugs.webkit.org/show_bug.cgi?id=133033
28         <rdar://problem/16830143>
29
30         Reviewed by Sam Weinig.
31
32         Set up the WebSQL and IndexedDB directories.
33
34         * WebKitTestRunner/TestController.cpp:
35         (WTR::TestController::initialize):
36
37 2014-05-16  Martin Hock  <mhock@apple.com>
38
39         MemoryCache::addImageToCache should return the result of add().
40         https://bugs.webkit.org/show_bug.cgi?id=132928
41         <rdar://problem/16651547>
42
43         Reviewed by Alexey Proskuryakov.
44
45         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
46         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
47         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
48         (TestWebKitAPI::TEST):
49
50 2014-05-15  David Farler  <dfarler@apple.com>
51
52         old-run-webkit-tests: allow specifying a simulator app path
53         https://bugs.webkit.org/show_bug.cgi?id=132975
54
55         Reviewed by Anders Carlsson.
56
57         * Scripts/old-run-webkit-tests:
58         (openIPhoneSimulator):
59         Add new --simulator-app command line parameter for specifying the
60         absolute path to the simulator app to launch before starting a
61         session.
62
63 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
64
65         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
66         https://bugs.webkit.org/show_bug.cgi?id=131363
67
68         Reviewed by Csaba Osztrogonác.
69
70         * Scripts/webkitpy/common/checkout/checkout_mock.py:
71         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
72         (MockBugzilla):
73         * Scripts/webkitpy/tool/commands/download_unittest.py:
74         (test_create_rollout_multiple_revision_with_one_resolved):
75         (test_create_rollout_multiple_resolved):
76         (test_rollout_two_revisions):
77         (test_rollout_multiple_revisions):
78         (test_rollout_multiple_revisions_with_a_missing_bug_id):
79         * Scripts/webkitpy/tool/steps/createbug.py:
80         (CreateBug.run):
81         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
82         (ReopenBugAfterRollout.run):
83
84 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
85
86         [WK2] Change the remaining framework includes from WebKit2 to WebKit
87         https://bugs.webkit.org/show_bug.cgi?id=132956
88
89         Reviewed by Sam Weinig.
90
91         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
92         * MiniBrowser/mac/AppDelegate.m:
93         * MiniBrowser/mac/WK2BrowserWindowController.m:
94         * TestWebKitAPI/InjectedBundleController.h:
95         * TestWebKitAPI/InjectedBundleMain.cpp:
96         * TestWebKitAPI/JavaScriptTest.cpp:
97         * TestWebKitAPI/PlatformUtilities.h:
98         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
99         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
100         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
101         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
102         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
105         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
106         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
107         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
108         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
109         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
110         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
111         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
112         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
113         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
114         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
115         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
116         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
117         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
118         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
119         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
120         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
121         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
122         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
123         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
124         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
125         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
126         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
127         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
128         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
129         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
130         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
131         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
132         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
133         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
134         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
135         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
136         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
137         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
138         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
139         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
140         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
141         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
142         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
143         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
144         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
145         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
146         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
147         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
148         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
149         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
150         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
151         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
152         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
153         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
154         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
155         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
156         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
157         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
158         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
159         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
160         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
161         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
162         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
163         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
164         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
165         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
166         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
167         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
168         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
169         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
170         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
171         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
172         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
173         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
174         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
175         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
176         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
177         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
178         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
179         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
180         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
181         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
182         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
183         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
184         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
185         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
186         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
187         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
188         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
189         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
190         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
191         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
192         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
193         * TestWebKitAPI/config.h:
194         * TestWebKitAPI/efl/PlatformWebView.cpp:
195         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
196         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
197         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
198         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
199         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
200         * WebKitTestRunner/EventSenderProxy.h:
201         * WebKitTestRunner/GeolocationProviderMock.cpp:
202         * WebKitTestRunner/GeolocationProviderMock.h:
203         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
204         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
205         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
206         * WebKitTestRunner/InjectedBundle/GCController.cpp:
207         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
208         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
209         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
214         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
216         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
217         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
218         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
219         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
220         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
221         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
222         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
223         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
224         * WebKitTestRunner/PlatformWebView.h:
225         * WebKitTestRunner/StringFunctions.h:
226         * WebKitTestRunner/TestController.cpp:
227         * WebKitTestRunner/TestController.h:
228         * WebKitTestRunner/TestInvocation.cpp:
229         * WebKitTestRunner/TestInvocation.h:
230         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
231         * WebKitTestRunner/WebNotificationProvider.cpp:
232         * WebKitTestRunner/WebNotificationProvider.h:
233         * WebKitTestRunner/WorkQueueManager.cpp:
234         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
235         * WebKitTestRunner/cg/TestInvocationCG.cpp:
236         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
237         * WebKitTestRunner/config.h:
238         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
239         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
240         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
241         * WebKitTestRunner/ios/TestControllerIOS.mm:
242         * WebKitTestRunner/mac/EventSenderProxy.mm:
243         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
244         * WebKitTestRunner/mac/TestControllerMac.mm:
245
246 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
247
248         [EFL][WK2] Skip failing unit tests
249         https://bugs.webkit.org/show_bug.cgi?id=132979
250
251         Reviewed by Daniel Bates.
252
253         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
254
255 2014-05-15  David Kilzer  <ddkilzer@apple.com>
256
257         [iOS] Support TestWebKitAPI in the iOS Simulator
258         <http://webkit.org/b/129535>
259         <rdar://problem/16203529>
260
261         Reviewed by Daniel Bates.
262
263         * Scripts/run-api-tests:
264         (runTest):
265         (listAllTests):
266         - Extract common arguments into local variable.
267         - Use xcrun to find the sim tool in order to invoke
268         TestWebKitAPI properly in the iOS Simulator. 
269
270         * Scripts/webkitdirs.pm:
271         (argumentsForConfiguration): Set --device or --sim as
272         appropriate to fix buildTestTool() in run-api-tests.
273
274 2014-05-15  Tim Horton  <timothy_horton@apple.com>
275
276         Fix a logging typo in copy-webkitlibraries-to-product-directory
277
278         Reviewed by Dean Jackson.
279
280         * Scripts/copy-webkitlibraries-to-product-directory:
281
282 2014-05-15  David Kilzer  <ddkilzer@apple.com>
283
284         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
285         <http://webkit.org/b/132959>
286
287         Reviewed by Dan Bernstein.
288
289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
290         Cocoa directory to project and move URLExtras.mm into it.
291         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
292
293 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         [GTK] Compile all installed resources as GResources
296         https://bugs.webkit.org/show_bug.cgi?id=131099
297
298         Reviewed by Philippe Normand.
299
300         * Scripts/webkitpy/port/gtk.py:
301         (GtkPort.setup_environ_for_server): Removed now unneeded
302         AUDIO_RESOURCES_PATH env var.
303
304 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
305
306         Remove CSS_STICKY_POSITION guards
307         https://bugs.webkit.org/show_bug.cgi?id=132676
308
309         Reviewed by Simon Fraser.
310
311         * Scripts/webkitperl/FeatureList.pm:
312
313 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
314
315         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
316         https://bugs.webkit.org/show_bug.cgi?id=132686
317
318         Reviewed by Philippe Normand.
319
320         Bring back InputMethodFilter test to the build and compile it into
321         a single binary TestWebCore with the other WebCore tests. Also
322         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
323
324         * Scripts/run-gtk-tests:
325         (TestRunner): Remove WebCoreGtk from the list of test directories.
326         * TestWebKitAPI/PlatformGTK.cmake:
327         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
328
329 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
330
331         [EFL] Make XVFBDriver optional
332         https://bugs.webkit.org/show_bug.cgi?id=131036
333
334         Reviewed by Gyuyoung Kim.
335
336         * Scripts/webkitpy/port/efl.py:
337         (EflPort._driver_class):
338
339 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
340
341         Flakiness dashboard contains outdated list of bots on builders.jsonp
342         https://bugs.webkit.org/show_bug.cgi?id=132874
343
344         Reviewed by Darin Adler.
345
346         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
347         file by changing to the directory Tools/TestResultServer and executing
348         the script generate_builders_json.py
349
350 2014-05-11  Anders Carlsson  <andersca@apple.com>
351
352         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
353         https://bugs.webkit.org/show_bug.cgi?id=132809
354
355         Reviewed by Dan Bernstein.
356
357         * WebKitTestRunner/TestController.cpp:
358         (WTR::TestController::initialize):
359         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
360
361 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
362
363         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
364         https://bugs.webkit.org/show_bug.cgi?id=132739
365
366         Reviewed Anders Carlsson.
367
368         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
369         the JSC unit tests.
370         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
371
372 2014-05-11  Anders Carlsson  <andersca@apple.com>
373
374         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
375         https://bugs.webkit.org/show_bug.cgi?id=132806
376
377         Reviewed by Beth Dakin.
378
379         Migrate to WKContextConfiguration.
380
381         * WebKitTestRunner/TestController.cpp:
382         (WTR::TestController::initialize):
383
384 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
385
386         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
387         https://bugs.webkit.org/show_bug.cgi?id=132685
388
389         Reviewed by Martin Robinson.
390
391         Use a single TestWebKit2 binary for all WebKit2 C API tests.
392
393         * TestWebKitAPI/PlatformGTK.cmake:
394
395 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
396
397         [iOS] Switch geolocation to an explicit authorization query model
398         https://bugs.webkit.org/show_bug.cgi?id=132717
399
400         Reviewed by Sam Weinig.
401
402         * DumpRenderTree/mac/MockGeolocationProvider.mm:
403         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
404         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
405
406 2014-05-09  David Farler  <dfarler@apple.com>
407
408         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
409         https://bugs.webkit.org/show_bug.cgi?id=132718
410
411         Reviewed by David Kilzer.
412
413         The simulator may not be able to look up runtimes by SDK paths
414         and instead will map SDK versions to runtimes instead. In
415         com.apple.iphonesimulator.startSession notifications,
416         'runtimeIdentifier' (SDK version string) is preferred over
417         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
418         when creating a new DRT or WKTR simulator session.
419
420         IPhoneSimulatorNotification.pm filters out keys for this
421         notification's userInfo with a hard-coded list. There's no harm
422         in including extra key-value pairs in an NSNotification userInfo
423         dictionary anyway and the simulator may again change its
424         userInfo schema for this notification.
425
426         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
427         (postStartSessionNotification):
428         * Scripts/old-run-webkit-tests:
429         (installAndLaunchDumpToolAppUsingNotification):
430
431 2014-05-09  Anders Carlsson  <andersca@apple.com>
432
433         Another build fix.
434
435         * Scripts/build-webkit:
436         WebKit2 should always be built for OS X and iOS.
437
438 2014-05-09  Anders Carlsson  <andersca@apple.com>
439
440         Follow-up build fix.
441
442         * Scripts/build-webkit:
443         WebKit2 should no longer be built before WebKit.
444
445 2014-05-09  Anders Carlsson  <andersca@apple.com>
446
447         Rename WebKit2.framework to WebKit.framework
448         https://bugs.webkit.org/show_bug.cgi?id=132743
449         <rdar://problem/15920046>
450
451         Reviewed by Dan Bernstein.
452
453         * Scripts/check-for-inappropriate-files-in-framework:
454         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
455         Change WebKit2 to WebKit.
456
457         * Scripts/check-for-webkit-framework-include-consistency:
458         Change WebKit to WebKitLegacy.
459
460 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
461
462         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
463         https://bugs.webkit.org/show_bug.cgi?id=132732
464
465         Reviewed by Alexey Proskuryakov.
466
467         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
468
469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
470         (EWS): Remove GTK+ WK1 EWS.
471
472 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
473
474         Add new u-szeged contributors.
475
476         Reviewed by Csaba Osztrogonác.
477
478         * Scripts/webkitpy/common/config/contributors.json:
479
480 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
481
482         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
483         https://bugs.webkit.org/show_bug.cgi?id=132736
484
485         Reviewed by Philippe Normand.
486
487         There are two problems, the path returned by common.library_build_path() is wrong when
488         common.binary_build_path() has previously been called, and the test is still looking for
489         the .la instead of .so
490
491         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
492         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
493         of .la as extension of the injected bundle library.
494         * gtk/common.py:
495         (binary_build_path): Remove unused global variable and add a new
496         one for binary_build_dir instead of sharing the same global
497         variable for library_build_path and binary_build_path.
498
499 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
500
501         [EFL] Enable MEDIA_STREAM for EFL port
502         https://bugs.webkit.org/show_bug.cgi?id=132648
503
504         Reviewed by Gyuyoung Kim.
505
506         Script modified to enable MEDIA_STREAM for EFL build.
507
508         * Scripts/webkitperl/FeatureList.pm: 
509
510 2014-05-08  David Farler  <dfarler@apple.com>
511
512         old-run-webkit-tests: update strings for simulator devices and app name
513         https://bugs.webkit.org/show_bug.cgi?id=132687
514
515         Reviewed by Darin Adler.
516
517         iPhone Retina (4-inch) -> iPhone 5
518         iPhone Retina (4-inch 64-bit) -> iPhone 5s
519
520         * Scripts/old-run-webkit-tests:
521         (installAndLaunchDumpToolAppUsingNotification):
522         (openIPhoneSimulator):
523         (quitIPhoneSimulator):
524         quit iOS Simulator, not iPhone Simulator.
525
526 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
527
528         REGRESSION(r168471): Update the builder names on the scheduler list.
529         https://bugs.webkit.org/show_bug.cgi?id=132699
530
531         Reviewed by Martin Robinson.
532
533         On r168471 I missed to update the builder names for the GTK build
534         bots on the AnyBranchScheduler type scheduler list of bots.
535
536         * BuildSlaveSupport/build.webkit.org-config/config.json:
537
538 2014-05-08  Brady Eidson  <beidson@apple.com>
539
540         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
541         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
542
543         Reviewed by Tim Horton.
544
545         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
546         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
547
548 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
549
550         REGRESSION(r168471): Duplicate builddirs broke the build master.
551         https://bugs.webkit.org/show_bug.cgi?id=132688
552
553         Reviewed by Carlos Garcia Campos.
554
555         Rename the builddirs of the new GTK bots introduced on r168471 to
556         be unique. Otherwise the master will break.
557
558         * BuildSlaveSupport/build.webkit.org-config/config.json:
559
560 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
561
562         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
563         https://bugs.webkit.org/show_bug.cgi?id=132674
564
565         Reviewed by Philippe Normand.
566
567         Only ignore mkdir failure when exception is raised because the
568         file already exists and it's a directory.
569
570         * gtk/webkitdom.py:
571         (write_doc_files):
572
573 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
574
575         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
576         https://bugs.webkit.org/show_bug.cgi?id=131358
577
578         Reviewed by Carlos Garcia Campos.
579
580         Current 64-bit GTK build bots (Release and Debug) not only test
581         the build, but run all tests. Split each one of the bots in
582         BuildOnly and TestWebKit2.
583
584         This will allow us to have a better overview of the status of
585         the GTK port.
586
587         Original patch from Sergio Villar Senin <svillar@igalia.com>
588
589         * BuildSlaveSupport/build.webkit.org-config/config.json:
590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
592         (WebKitBuildbot):
593         * Scripts/webkitpy/port/builders.py:
594         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
595         (TestRebaselineTest.test_baseline_directory):
596         * TestResultServer/static-dashboards/builders.jsonp:
597         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
598         (resetGlobals):
599         * TestResultServer/static-dashboards/loader_unittests.js:
600
601 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
602
603         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
604         https://bugs.webkit.org/show_bug.cgi?id=126022
605
606         Reviewed by Benjamin Poulain.
607
608         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
609
610         Added an unit test case to check if scroll position and scale are restored properly.
611
612         * TestWebKitAPI/PlatformEfl.cmake:
613         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
614         (TestWebKitAPI::didFinishLoadForFrame):
615         (TestWebKitAPI::didChangeContentsPosition):
616         (TestWebKitAPI::TEST):
617         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
618         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
619
620 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
621
622         WebKit1 is flashy when compositing layers come and go
623         https://bugs.webkit.org/show_bug.cgi?id=132655
624         <rdar://problem/16830981&16788846>
625
626         Reviewed by Sam Weinig.
627         
628         Revert the change from r166117.
629
630         * DumpRenderTree/mac/DumpRenderTree.mm:
631         (updateDisplay):
632
633 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
634
635         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
636         https://bugs.webkit.org/show_bug.cgi?id=132622
637
638         Reviewed by Mario Sanchez Prada.
639
640         * DumpRenderTree/AccessibilityUIElement.cpp:
641         (selectTextWithCriteriaCallback):
642         (isEqualCallback):
643         * DumpRenderTree/AccessibilityUIElement.h:
644         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
645         (AccessibilityUIElement::selectTextWithCriteria):
646         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
647         (AccessibilityUIElement::selectTextWithCriteria):
648         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
649         (selectTextParameterizedAttributeForCriteria):
650         (AccessibilityUIElement::selectTextWithCriteria):
651         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
652         (AccessibilityUIElement::selectTextWithCriteria):
653         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
654         (WTR::AccessibilityUIElement::selectTextWithCriteria):
655         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
656         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
657         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
658         (WTR::AccessibilityUIElement::selectTextWithCriteria):
659         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
660         (WTR::AccessibilityUIElement::selectTextWithCriteria):
661         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
662         (WTR::selectTextParameterizedAttributeForCriteria):
663         (WTR::AccessibilityUIElement::selectTextWithCriteria):
664
665 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
666
667         [SOUP] TLSErrors do not cause page load to fail when not ignored
668         https://bugs.webkit.org/show_bug.cgi?id=121548
669
670         Reviewed by Sergio Villar Senin.
671
672         Add unit tests to check that the load fails with TLS errors in
673         case of a redirection.
674
675         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
676         (testTLSErrorsRedirect):
677         (httpsServerCallback):
678         (beforeAll):
679
680 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
681
682         [CSS Grid Layout] Remove runtime feature
683         https://bugs.webkit.org/show_bug.cgi?id=132382
684
685         Reviewed by Benjamin Poulain.
686
687         Remove cssGridLayoutEnabled setting usage.
688
689         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
690         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
691         * DumpRenderTree/efl/TestRunnerEfl.cpp:
692         (TestRunner::overridePreference):
693         * DumpRenderTree/mac/DumpRenderTree.mm:
694         (resetWebPreferencesToConsistentValues):
695
696 2014-05-06  David Kilzer  <ddkilzer@apple.com>
697
698         Add Makefile targets for copying static libraries (LLVM and WKSI)
699         <http://webkit.org/b/132619>
700
701         Reviewed by Mark Rowe.
702
703         * Scripts/copy-webkitlibraries-to-product-directory: Set a
704         sensible default for product directory if not specified on
705         either the command-line or in the environment (by Xcode) by
706         calling productDir() in webkitdirs.pm.
707
708 2014-05-06  Brady Eidson  <beidson@apple.com>
709
710         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
711         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
712
713         Reviewed by Sam Weinig.
714
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716
717         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
718         (TestWebKitAPI::itemURLLastComponentIsString):
719         (TestWebKitAPI::didFinishLoadForFrame):
720         (TestWebKitAPI::willGoToBackForwardListItem):
721         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
722         (TestWebKitAPI::setPageLoaderClient):
723         (TestWebKitAPI::TEST):
724         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
725         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
726
727         * WebKitTestRunner/TestController.cpp:
728         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
729
730 2014-05-06  Darin Adler  <darin@apple.com>
731
732         Try to fix iOS build.
733
734         * DumpRenderTree/mac/TestRunnerMac.mm:
735         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
736         Updated since I changed testRunner into a pointer instead of a reference.
737         Updated argument names to avoid conflict with field names.
738         (-[APITestDelegateIPhone run]): Ditto.
739         (-[APITestDelegateIPhone _cleanUp]): Ditto.
740
741 2014-05-06  Commit Queue  <commit-queue@webkit.org>
742
743         Unreviewed, rolling out r168304.
744         https://bugs.webkit.org/show_bug.cgi?id=132607
745
746         Broke the build (Requested by KaL on #webkit).
747
748         Reverted changeset:
749
750         "[GTK][CMake] Unable to do make install"
751         https://bugs.webkit.org/show_bug.cgi?id=130188
752         http://trac.webkit.org/changeset/168304
753
754 2014-05-04  Darin Adler  <darin@apple.com>
755
756         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
757         https://bugs.webkit.org/show_bug.cgi?id=80222
758
759         Reviewed by Alexey Proskuryakov.
760
761         * DumpRenderTree/mac/TestRunnerMac.mm:
762         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
763         do more work here so we don't use RetainPtr local variables.
764         (-[APITestDelegateIPhone dealloc]): Added.
765         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
766         created. Updated for changes to member names and types.
767         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
768         updated for changes to member names and types. Changed to two word spelling.
769         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
770         name of _cleanUp method.
771         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
772         Ditto.
773         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
774
775 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
776
777         Clean up Image Document and tweak the layout and viewport
778         https://bugs.webkit.org/show_bug.cgi?id=132552
779
780         Reviewed by Anders Carlsson.
781
782         * DumpRenderTree/mac/DumpRenderTree.mm:
783         (resetWebPreferencesToConsistentValues):
784         Update the default settings to have something consistent with WebKit2.
785
786 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
787
788         [GTK][CMake] Unable to do make install
789         https://bugs.webkit.org/show_bug.cgi?id=130188
790
791         Reviewed by Carlos Garcia Campos.
792
793         * Scripts/webkitdirs.pm:
794         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
795         will give an early signal that a change has broken the documentation.
796
797 2014-05-05  Pratik Solanki  <psolanki@apple.com>
798
799         Update framework locations in package-root
800         https://bugs.webkit.org/show_bug.cgi?id=132571
801
802         Reviewed by Simon Fraser.
803
804         * Scripts/package-root:
805
806 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
807
808         [EFL][WK2] Refactor favicon database APIs
809         https://bugs.webkit.org/show_bug.cgi?id=132519
810
811         Reviewed by Gyuyoung Kim.
812
813         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
814         (update_view_favicon):
815         (on_icon_changed_cb):
816         (window_free):
817         (on_url_changed):
818         (window_create):
819         (on_view_favicon_changed): Deleted.
820
821 2014-05-02  Mark Rowe  <mrowe@apple.com>
822
823         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
824
825         Reviewed by Dan Bernstein.
826
827         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
828         when determining which LLVM archive to extract.
829
830 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
831
832         Add Jeremy as a committer.
833         https://bugs.webkit.org/show_bug.cgi?id=132492
834
835         Reviewed by Jer Noble.
836
837         Add myself as a committer.
838
839         * Scripts/webkitpy/common/config/contributors.json:
840
841 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
842
843         Add Jeremy as a committer.
844         https://bugs.webkit.org/show_bug.cgi?id=132492
845
846         Reviewed by Jer Noble.
847
848         Add Jeremy Jones to the committers file.
849
850         * Scripts/webkitpy/common/config/contributors.json:
851
852 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
853
854         Hard to figure out how to run a single test with run-api-tests
855         https://bugs.webkit.org/show_bug.cgi?id=116332
856
857         Reviewed by Alexey Proskuryakov.
858
859         * Scripts/run-api-tests: add two examples to the help message.
860
861 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
862
863         Fix several memory leaks found by code inspection
864         https://bugs.webkit.org/show_bug.cgi?id=132472
865
866         Reviewed by Geoffrey Garen.
867         
868         Fix memory leaks.
869
870         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
871         (TestWebKitAPI::TEST):
872         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
873         (WTR::InjectedBundlePage::willSendRequestForFrame):
874         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
875         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
876
877 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
878
879         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
880         https://bugs.webkit.org/show_bug.cgi?id=132446
881
882         Reviewed by Mark Hahnenberg.
883         
884         Test the FTL by default now that it's enabled by default.
885
886         * Scripts/run-javascriptcore-tests:
887
888 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
889
890         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
891         https://bugs.webkit.org/show_bug.cgi?id=132240
892
893         Reviewed by Anders Carlsson.
894
895         Removed ewk_view_setting_tiled_backingstore related code.
896
897         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
898         (DumpRenderTreeChrome::createView):
899         (shouldUseTiledBackingStore): Deleted.
900         * EWebLauncher/main.c:
901         (windowCreate):
902         (parseUserArguments):
903
904 2014-05-01  Anders Carlsson  <andersca@apple.com>
905
906         window.testRunner.keepWebHistory() should update the UI process state
907         https://bugs.webkit.org/show_bug.cgi?id=132440
908
909         Reviewed by Dan Bernstein.
910
911         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
912         (WTR::InjectedBundle::postSetAddsVisitedLinks):
913         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
914         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
915         (WTR::TestRunner::keepWebHistory):
916         * WebKitTestRunner/TestInvocation.cpp:
917         (WTR::TestInvocation::invoke):
918         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
919
920 2014-05-01  David Kilzer  <ddkilzer@apple.com>
921
922         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
923         <http://webkit.org/b/132432>
924
925         Reviewed by Tim Horton.
926
927         * Scripts/webkitperl/FeatureList.pm: Remove support for
928         --plugin-proxy-for-video switch.
929
930 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
931
932         Kernel sysctl interface hw.activecpu don't exists on Linux.
933         https://bugs.webkit.org/show_bug.cgi?id=132286
934
935         Reviewed by Filip Pizlo.
936
937         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
938         calling sysctl over hw.activecpu
939
940 2014-04-30  Anders Carlsson  <andersca@apple.com>
941
942         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
943         https://bugs.webkit.org/show_bug.cgi?id=132399
944         <rdar://problem/15920046>
945
946         Reviewed by Dan Bernstein.
947
948         * Scripts/check-for-webkit-framework-include-consistency:
949         Allos WAK headers in WebKitLegacy as well as WebKit.
950
951         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
952         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
953         Update header imports.
954
955 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
956
957         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
958         https://bugs.webkit.org/show_bug.cgi?id=131954
959
960         Reviewed by Darin Adler.
961         
962         WebKitTestRunner was adding application-specific information to crash reports
963         to log the test path, but only in the web process. Fix it to also do this
964         for the UI process, for both iOS and OS X.
965         
966         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
967         both iOS and OS X.
968         
969         Factored crash reprorter-related code into CrashReporterInfo, and call it from
970         a new TestController::platformWillRunTest() function on Mac and iOS.
971         
972         Also remove Xcode-added unit test junk from the project.
973
974         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
975         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
976         * WebKitTestRunner/TestController.cpp:
977         (WTR::TestController::runTest):
978         * WebKitTestRunner/TestController.h:
979         * WebKitTestRunner/TestInvocation.cpp:
980         (WTR::TestInvocation::url):
981         * WebKitTestRunner/TestInvocation.h:
982         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
983         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
984         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
985         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
986         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
987         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
988         (WTR::testPathFromURL):
989         (WTR::setCrashReportApplicationSpecificInformationToURL):
990         * WebKitTestRunner/efl/TestControllerEfl.cpp:
991         (WTR::TestController::platformWillRunTest):
992         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
993         (WTR::TestController::platformWillRunTest):
994         * WebKitTestRunner/ios/TestControllerIOS.mm:
995         (WTR::TestController::platformWillRunTest):
996         (WTR::TestController::setHidden):
997         * WebKitTestRunner/mac/TestControllerMac.mm:
998         (WTR::TestController::platformWillRunTest):
999
1000 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1001
1002         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1003
1004         Reviewed by Tim Horton.
1005
1006         * DumpRenderTree/mac/DumpRenderTree.mm:
1007         (resetWebPreferencesToConsistentValues):
1008         (prepareConsistentTestingEnvironment):
1009
1010 2014-04-30  Anders Carlsson  <andersca@apple.com>
1011
1012         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1013         https://bugs.webkit.org/show_bug.cgi?id=132397
1014
1015         Reviewed by Dan Bernstein.
1016
1017         * Scripts/check-for-inappropriate-macros-in-external-headers:
1018
1019 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1020
1021         [GTK] Make it easier to run CMake for downstreams
1022         https://bugs.webkit.org/show_bug.cgi?id=132370
1023
1024         Reviewed by Carlos Garcia Campos.
1025
1026         * Scripts/webkitdirs.pm:
1027         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1028         the GTK+ port.
1029
1030 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1031
1032         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1033         
1034         Rubber stamped by Jessie Berlin.
1035
1036         JSON.pm was removed from our tools setup.
1037
1038         * Scripts/generate-coverage-data:
1039
1040 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1041
1042         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1043         https://bugs.webkit.org/show_bug.cgi?id=112840
1044
1045         Rubber stamped by Geoffrey Garen.
1046
1047         * Scripts/build-jsc: Enable it on Mac.
1048         * Scripts/build-webkit: Enable it on Mac.
1049         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1050
1051 2014-04-28  Sam Weinig  <sam@webkit.org>
1052
1053         REGRESSION (r167751): svn-create-patch is very slow
1054         https://bugs.webkit.org/show_bug.cgi?id=132300
1055
1056         Reviewed by Alexey Proskuryakov.
1057
1058         * Scripts/svn-create-patch:
1059         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1060         by calling `svn-create-patch --style`.
1061
1062 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1063
1064         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1065         https://bugs.webkit.org/show_bug.cgi?id=132190
1066
1067         Reviewed by Gustavo Noronha Silva.
1068
1069         * Scripts/webkitdirs.pm:
1070         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1071             if ninja is in the path.
1072         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1073             to the previous ninja generator if not.
1074
1075 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1076
1077         check-webkit-style should understand --git-index
1078         https://bugs.webkit.org/show_bug.cgi?id=125364
1079
1080         Reviewed by Csaba Osztrogonác.
1081
1082         * Scripts/webkitpy/common/checkout/scm/git.py:
1083         (Git.create_patch): The command now supports the --cached option.
1084         * Scripts/webkitpy/style/main.py:
1085         (CheckWebKitStyle.main): Passing the --git-index option.
1086         * Scripts/webkitpy/style/optparser.py:
1087         (CommandOptionValues.__init__): The git-index option is switched off by default.
1088         (CommandOptionValues.__eq__): Equality check for the new option.
1089         (ArgumentParser._create_option_parser):Adding the --git-index option
1090         (ArgumentParser.parse):
1091         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1092         (CommandOptionValuesTest.test_init): 
1093         (CommandOptionValuesTest.test_eq):
1094
1095 2014-04-28  Michael Saboff  <msaboff@apple.com>
1096
1097         Crash in platform/mac/accessibility/table-visible-rows.html
1098         https://bugs.webkit.org/show_bug.cgi?id=132146
1099
1100         Reviewed by Filip Pizlo.
1101
1102         Instead of creating a local JSValueRef array on the stack and passing that to
1103         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1104         values using the JSObjectSetPropertyAtIndex() API.
1105
1106         * DumpRenderTree/AccessibilityUIElement.cpp:
1107         (elementsForRangeCallback):
1108         (convertElementsToObjectArray):
1109         * DumpRenderTree/mac/TestRunnerMac.mm:
1110         (originsArrayToJS):
1111         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1112         (WTR::EventSendingController::contextClick):
1113         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1114         (WTR::stringArrayToJS):
1115         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1116         (WTR::convertElementsToObjectArray):
1117
1118 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1119
1120         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1121         "no-cjit" runs force the old-school threshold.
1122
1123         Rubber stamped by Mark Hahnenberg.
1124
1125         * Scripts/run-jsc-stress-tests:
1126
1127 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1128
1129         [GTK] install-dependencies should also install ruby-json and ruby-highline
1130         https://bugs.webkit.org/show_bug.cgi?id=132292
1131
1132         Reviewed by Philippe Normand.
1133
1134         * gtk/install-dependencies: Install ruby json and highline packages.
1135
1136 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1137
1138         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1139         https://bugs.webkit.org/show_bug.cgi?id=132176
1140
1141         Reviewed by Gyuyoung Kim.
1142
1143         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1144         and turn off indexedDB feature until the sqlite implementation is introduced.
1145
1146         * Scripts/webkitperl/FeatureList.pm:
1147
1148 2014-04-25  James Craig  <jcraig@apple.com>
1149
1150         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1151         https://bugs.webkit.org/show_bug.cgi?id=132209
1152
1153         Reviewed by Daniel Bates.
1154
1155         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1156         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1157
1158         * Scripts/prepare-ChangeLog:
1159         (main): 
1160
1161 2014-04-25  Michael Saboff  <msaboff@apple.com>
1162
1163         Crash in platform/mac/accessibility/table-visible-rows.html
1164         https://bugs.webkit.org/show_bug.cgi?id=132146
1165
1166         Reviewed by Mark Lam.
1167
1168         Changed to use a local JSValueRef array temporary instead of a
1169         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1170         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1171         the temporary values could be collected.
1172
1173         * DumpRenderTree/AccessibilityUIElement.cpp:
1174         (convertElementsToObjectArray):
1175         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1176         (WTR::EventSendingController::contextClick):
1177         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1178         (WTR::convertElementsToObjectArray):
1179
1180 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1181
1182         Unreviewed GTK gardening
1183
1184         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1185         (TestRunner):
1186
1187 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1188
1189         prepare-ChangeLog reports as deleted methods that has not been removed.
1190         https://bugs.webkit.org/show_bug.cgi?id=131733
1191
1192         Reviewed by Ryosuke Niwa.
1193
1194         * Scripts/prepare-ChangeLog:
1195         (originalFile): Set merge base to origin/master by default.
1196
1197 2014-04-23  James Craig  <jcraig@apple.com>
1198
1199         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1200         https://bugs.webkit.org/show_bug.cgi?id=131115
1201
1202         Reviewed by Daniel Bates.
1203
1204         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1205
1206         * Scripts/commit-log-editor: Added --no-style.
1207         * Scripts/prepare-ChangeLog: Primary patch.
1208         (main): Primary patch.
1209         (createPatchCommand): Added --no-style.
1210         * Scripts/svn-create-patch: Primary patch.
1211         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1212         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1213         (SVN.create_patch): Added --no-style.
1214
1215 2014-04-23  Anders Carlsson  <andersca@apple.com>
1216
1217         Try to fix iOS build.
1218
1219         * DumpRenderTree/mac/DumpRenderTree.mm:
1220
1221 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
1222
1223         Eliminate internals.setMockScrollbarsEnabled()
1224         https://bugs.webkit.org/show_bug.cgi?id=132085
1225
1226         Reviewed by Tim Horton.
1227
1228         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
1229         No need to reset the preference, there is no way it can change.
1230
1231 2014-04-23  James Craig  <jcraig@apple.com>
1232
1233         Unreviewed. Moving myself from Contributors to Committers list.
1234
1235         * Scripts/webkitpy/common/config/contributors.json:
1236
1237 2014-04-23  Tim Horton  <timothy_horton@apple.com>
1238
1239         Mock scrollbars don't always work in DumpRenderTree
1240         https://bugs.webkit.org/show_bug.cgi?id=132082
1241
1242         Reviewed by Alexey Proskuryakov.
1243
1244         * DumpRenderTree/mac/DumpRenderTree.mm:
1245         (prepareConsistentTestingEnvironment):
1246         Set the mock scrollbar setting before creating the WebView, as this setting
1247         cannot be dynamically changed, so any scrollbars that are created during
1248         WebView initialization and are not replaced before snapshotting will end
1249         up being platform scrollbars instead of mock ones.
1250         WebKitTestRunner already sets this preference before creating WKViews,
1251         so we're just matching its behavior.
1252
1253 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1254
1255         [GTK] ShadowRoot API was removed in r164131
1256         https://bugs.webkit.org/show_bug.cgi?id=132059
1257
1258         Reviewed by Gustavo Noronha Silva.
1259
1260         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1261         the API docs.
1262
1263         * gtk/webkitdom.py:
1264         (WebKitDOMDocGenerator):
1265
1266 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1267
1268         [GTK] run-webkit-tests script is failing to invoke run-launcher
1269         https://bugs.webkit.org/show_bug.cgi?id=132051
1270
1271         Reviewed by Philippe Normand.
1272
1273         After the WK1 support was dropped, if run-webkit-tests is executed
1274         without --no-show-results parameter, the launcher is being called
1275         using a -2 parameter that is it causing the run-launcher to break.
1276
1277         * Scripts/webkitpy/port/gtk.py:
1278         (GtkPort.show_results_html_file):
1279
1280 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1281
1282         DumpRenderTree generates black snapshots on some platforms
1283         https://bugs.webkit.org/show_bug.cgi?id=132029
1284         <rdar://problem/16679363>
1285
1286         Reviewed by Simon Fraser.
1287
1288         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1289         (createBitmapContextFromWebView):
1290         DRT checks with the WebView to determine whether it can use the window's
1291         backing store directly or (because of compositing) needs to take a WindowServer
1292         snapshot. However, on some platforms and in some situations, the window can
1293         be layer backed without the WebView necessarily currently being composited.
1294         We should check with the window in addition to the WebView before going
1295         ahead and using its backing store.
1296
1297 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1298
1299         DumpRenderTree generates white snapshots on some platforms
1300         https://bugs.webkit.org/show_bug.cgi?id=132026
1301         <rdar://problem/16679363>
1302
1303         Reviewed by Simon Fraser.
1304
1305         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1306         Link DRT against QuartzCore.
1307
1308         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1309         (createBitmapContextFromWebView):
1310         Force CoreAnimation to synchronously update layers in a more explicit
1311         way that doesn't depend on AppKit behavior. This is very similar to what
1312         WebKitTestRunner does (indirectly) during its force repaint.
1313
1314 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1315
1316         [Win] Support Python 2.7 in Cygwin
1317         https://bugs.webkit.org/show_bug.cgi?id=132023
1318
1319         Reviewed by Michael Saboff.
1320
1321         * Scripts/webkitdirs.pm:
1322         (checkInstalledTools): Remove check for Python 2.7, since
1323         it now works properly.
1324
1325 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1326
1327         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1328         https://bugs.webkit.org/show_bug.cgi?id=130867
1329         <rdar://problem/16432456> 
1330
1331         Reviewed by Mark Hahnenberg.
1332
1333         * Scripts/build-webkit:
1334         * Scripts/copy-webkitlibraries-to-product-directory:
1335
1336 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1337
1338         [GTK] Fails to build documentation when output is redirected
1339         https://bugs.webkit.org/show_bug.cgi?id=131178
1340
1341         Reviewed by Martin Robinson.
1342
1343         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1344         explicitly to avoid encoding issues when they are redirected.
1345
1346 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1347
1348         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1349         https://bugs.webkit.org/show_bug.cgi?id=131911
1350
1351         Reviewed by Martin Robinson.
1352
1353         common.get_build_path returns release path even though Debug configuration
1354         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1355
1356         * gtk/ycm_extra_conf.py:
1357         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1358         (FlagsForFile):
1359
1360 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1361
1362         Unreviewed build fix.
1363
1364         * DumpRenderTree/mac/EventSendingController.mm:
1365         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1366         Correct a typo that prevented tests from working properly.
1367
1368 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1369
1370         [GTK] Should have the ability to output composited contents during layout testing
1371         https://bugs.webkit.org/show_bug.cgi?id=131864
1372
1373         Reviewed by Philippe Normand.
1374
1375         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1376         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1377         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1378         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1379         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1380
1381 2014-04-21  Sam Weinig  <sam@webkit.org>
1382
1383         Attempt to fix the tests.
1384
1385         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1386         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1387         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1388
1389 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1390
1391         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1392         being the same as a "quick run", which is meant for genuinely slow tests).
1393
1394         * Scripts/run-jsc-stress-tests:
1395
1396 2014-04-21  Darin Adler  <darin@apple.com>
1397
1398         Add HashSet::takeAny
1399         https://bugs.webkit.org/show_bug.cgi?id=131928
1400
1401         Reviewed by Benjamin Poulain.
1402
1403         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1404
1405 2014-04-20  Dan Bernstein  <mitz@apple.com>
1406
1407         Fixed a test timing out after r167572.
1408
1409         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1410         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1411         -webView:didFinishLoadingNavigation:.
1412
1413 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1414
1415         Unreviewed, rolling out r167510.
1416         https://bugs.webkit.org/show_bug.cgi?id=131915
1417
1418         broke GTK Debug bot (Requested by philn on #webkit).
1419
1420         Reverted changeset:
1421
1422         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1423         it when running layout tests"
1424         https://bugs.webkit.org/show_bug.cgi?id=131472
1425         http://trac.webkit.org/changeset/167510
1426
1427 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1428
1429         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1430         https://bugs.webkit.org/show_bug.cgi?id=131472
1431
1432         Reviewed by Philippe Normand.
1433
1434         * Scripts/webkitpy/port/gtk.py:
1435         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1436         when running WebKitTestRunner with run-webkit-tests.
1437         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1438         installed.
1439         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1440         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1441         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1442         deal.
1443
1444 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1445
1446         DownloadDecideDestinationCrash API test uses an incorrect value for path
1447         https://bugs.webkit.org/show_bug.cgi?id=131845
1448         <rdar://problem/15925560>
1449
1450         Reviewed by Enrica Casucci.
1451
1452         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1453         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1454
1455 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1456
1457         [Mac] AttributedStringTest API tests fail with async text input
1458         https://bugs.webkit.org/show_bug.cgi?id=131833
1459
1460         Reviewed by Enrica Casucci.
1461
1462         Don't run sync NSTextInputClient tests where we don't implement these calls.
1463
1464         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1465         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1466         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1467         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1468         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1469         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1470         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1471
1472 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1473
1474         Remove NETWORK_INFO support
1475         https://bugs.webkit.org/show_bug.cgi?id=131841
1476
1477         Reviewed by Gyuyoung Kim.
1478
1479         * Scripts/webkitperl/FeatureList.pm:
1480
1481 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1482
1483         [GTK] YouCompleteMe doesn't work for cmake build system.
1484         https://bugs.webkit.org/show_bug.cgi?id=131591
1485
1486         Reviewed by Martin Robinson.
1487
1488         Add cmake build system support for YouCompleteMe. It should work regardless of
1489         using make or ninja. In addition, autotools related code is removed since it's
1490         not used anymore in WebKit.
1491
1492         * Scripts/webkitdirs.pm:
1493         (generateBuildSystemFromCMakeProject):
1494         * gtk/ycm_extra_conf.py:
1495         (transform_relative_paths_to_absolute_paths):
1496         (FlagsForFile):
1497
1498 2014-04-17  Anders Carlsson  <andersca@apple.com>
1499
1500         Fix build.
1501
1502         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1503         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1504         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1505
1506 2014-04-17  Anders Carlsson  <andersca@apple.com>
1507
1508         Remove unused API enums
1509         https://bugs.webkit.org/show_bug.cgi?id=131836
1510
1511         Reviewed by Tim Horton.
1512
1513         * MiniBrowser/mac/WK2BrowserWindowController.m:
1514         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1515
1516 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1517
1518         [Win] A few final cleanups to the DataObject classes.
1519         https://bugs.webkit.org/show_bug.cgi?id=131784
1520
1521         Reviewed by Anders Carlsson.
1522
1523         * DumpRenderTree/win/DRTDataObject.cpp:
1524         (DRTDataObject::clearData): Use 'last()' method.
1525         * DumpRenderTree/win/UIDelegate.cpp:
1526         (DRTUndoStack::pop): Use 'takeLast()' method.
1527
1528 2014-04-17  Andres Gomez  <agomez@igalia.com>
1529
1530         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1531         https://bugs.webkit.org/show_bug.cgi?id=131365
1532
1533         Reviewed by Brent Fulgham.
1534
1535         The cygwin installer is now downloading the wanted versions for
1536         the local installation given to the setup wizard.
1537
1538         * CygwinDownloader/cygwin-downloader.py:
1539         * CygwinDownloader/cygwin-downloader.zip:
1540
1541 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1542
1543         [GTK] Make run-webkit-tests always use WKTR
1544         https://bugs.webkit.org/show_bug.cgi?id=131737
1545
1546         Reviewed by Darin Adler.
1547
1548         Now that the GTK+ port only has support for WebKit2, instruct
1549         run-webkit-tests to always use WKTR. This avoids needing to pass
1550         flag "-2" every time.
1551
1552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1553         (_set_up_derived_options): Always set webkit_test_runner when
1554         the platform is GTK+.
1555
1556 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1557
1558         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1559         https://bugs.webkit.org/show_bug.cgi?id=131760
1560
1561         Reviewed by Philippe Normand.
1562
1563         * gtk/install-dependencies: Install ninja-build when it's available.
1564
1565 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1566
1567         [Win] run-javascriptcore-tests fails to run.
1568         https://bugs.webkit.org/show_bug.cgi?id=131761
1569
1570         Reviewed by Brent Fulgham.
1571
1572         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1573
1574 2014-04-16  Andres Gomez  <agomez@igalia.com>
1575
1576         [Win] Pass default parameters to cygwin setup wizard
1577         https://bugs.webkit.org/show_bug.cgi?id=131361
1578
1579         Reviewed by Brent Fulgham.
1580
1581         Added some parameters to the cygwin setup wizard so the user
1582         doesn't really have to do any interaction.
1583
1584         * CygwinDownloader/cygwin-downloader.py:
1585         * CygwinDownloader/cygwin-downloader.zip:
1586
1587 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1588
1589         [Win] Eliminate use of deleteAllValues in Windows Files
1590         https://bugs.webkit.org/show_bug.cgi?id=131631
1591
1592         Reviewed by Darin Adler.
1593
1594         Switch to std::unique_ptr for memory lifetime. Get rid of
1595         deleteAllValues now that it is no longer needed. Use ranged
1596         for loops where possible.
1597
1598         * DumpRenderTree/win/DRTDataObject.cpp:
1599         (WCEnumFormatEtc::WCEnumFormatEtc):
1600         (DRTDataObject::~DRTDataObject):
1601         (DRTDataObject::GetData):
1602         (DRTDataObject::QueryGetData):
1603         (DRTDataObject::SetData):
1604         (DRTDataObject::clearData):
1605         * DumpRenderTree/win/DRTDataObject.h:
1606         * DumpRenderTree/win/UIDelegate.cpp:
1607         (DRTUndoObject::DRTUndoObject):
1608         (DRTUndoObject::~DRTUndoObject):
1609         (DRTUndoStack::~DRTUndoStack):
1610         (DRTUndoStack::clear):
1611         (DRTUndoStack::pop):
1612         (DRTUndoManager::DRTUndoManager):
1613         (DRTUndoManager::redo):
1614         (DRTUndoManager::undo):
1615         (UIDelegate::UIDelegate):
1616         (UIDelegate::resetUndoManager):
1617         * DumpRenderTree/win/UIDelegate.h:
1618
1619 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1620
1621         [GTK] Unreviewed GTK gardening.
1622
1623         Update list of skipped unit tests:
1624
1625           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1626
1627           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1628           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1629
1630         * Scripts/run-gtk-tests:
1631         (TestRunner):
1632
1633 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1634
1635         check-webkit-style doesn't check code style in .mm or .m files
1636         https://bugs.webkit.org/show_bug.cgi?id=131708
1637
1638         Reviewed by Darin Adler.
1639
1640         * Scripts/webkitpy/style/checker.py:
1641         * Scripts/webkitpy/style/checker_unittest.py:
1642         (CheckerDispatcherDispatchTest.test_cpp_paths):
1643         (CheckerDispatcherDispatchTest.test_text_paths):
1644         Check .mm and .m files as C++.
1645
1646         * Scripts/webkitpy/style/checkers/cpp.py:
1647         (check_spacing):
1648         Add an override for our ordinary "missing spaces around =" for @synthesize,
1649         which should look like "@synthesize propertyName=_varName;"
1650
1651         Add an override for "missing space before {" for blocks' "^{".
1652
1653         Don't follow the "extra space before [" rule for Objective-C, because
1654         it breaks this rule in a multitude of ways because of method calls.
1655
1656         (check_braces):
1657         Don't complain about { not being on the end of the previous line if
1658         the previous line starts with "- (" or "+ (", which would indicate a
1659         Objective-C method definition.
1660
1661 2014-04-16  Darin Adler  <darin@apple.com>
1662
1663         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1664         https://bugs.webkit.org/show_bug.cgi?id=131735
1665
1666         Reviewed by Alexey Proskuryakov.
1667
1668         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1669         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1670         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1671         way, but gtest works better this way.
1672
1673 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1674
1675         [EFL] Fix problems with the pixel dump.
1676         https://bugs.webkit.org/show_bug.cgi?id=131265
1677
1678         Reviewed by Gyuyoung Kim.
1679
1680         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1681         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1682         which causes that nothing is drawn.
1683
1684         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1685         One of new functions is AcceleratedCompositingContext::extractImageData(),
1686         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1687         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1688
1689         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1690         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1691
1692 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1693
1694         Update LLVM export scrpt to handle the build directory being different from the
1695         source directory.
1696
1697         Rubber stamped by Geoffrey Garen.
1698
1699         * Scripts/export-llvm-build:
1700
1701 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1702
1703         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1704         https://bugs.webkit.org/show_bug.cgi?id=131695
1705
1706         Reviewed by Antti Koivisto.
1707
1708         Updated.
1709
1710         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1711
1712 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1713
1714         [GTK] Reduce the binary size by compressing the text based web inspector resources
1715         https://bugs.webkit.org/show_bug.cgi?id=121545
1716
1717         Reviewed by Gustavo Noronha Silva.
1718
1719         Compress text based files when compiling inspector resources. It
1720         reduces the binary size in 3MB.
1721
1722         * gtk/generate-inspector-gresource-manifest.py:
1723         (find_all_files_in_directory):
1724         (is_compressible):
1725
1726 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1727
1728         Remove Gtk WebKit1 tester.
1729
1730         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1731         results over and over as fast as it could.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1734         (WebKitBuildbot):
1735
1736 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1737
1738         Wrong link for webkitpy tests results in dashboard popover
1739         https://bugs.webkit.org/show_bug.cgi?id=131664
1740
1741         Reviewed by Timothy Hatcher.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1744         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1745         Use a correct link.
1746
1747 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1748
1749         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1750
1751         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1752
1753         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1754         (CommitMessageForThisCommitTest):
1755
1756 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1757
1758         Fix commit-log-editor bug revealed by r165447
1759         https://bugs.webkit.org/show_bug.cgi?id=130676
1760
1761         Reviewed by Csaba Osztrogonác.
1762
1763         * Scripts/commit-log-editor:
1764         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1765         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1766         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1767         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1768
1769 2014-04-13  Darin Adler  <darin@apple.com>
1770
1771         userVisibleString should not try to "encode" host names
1772         https://bugs.webkit.org/show_bug.cgi?id=131587
1773         rdar://problem/14686849
1774
1775         Reviewed by Alexey Proskuryakov.
1776
1777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1778
1779         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1780         Coverage is tiny at this point; we could add a lot more cases!
1781
1782 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1783
1784         Use #include instead of #import
1785         https://bugs.webkit.org/show_bug.cgi?id=131604
1786
1787         Reviewed by Darin Adler.
1788
1789         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1790
1791         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1792
1793 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1794
1795         Make slow-stress tests run faster by running fewer VM variants.
1796
1797         Rubber stamped by Geoffrey Garen.
1798
1799         * Scripts/run-javascriptcore-tests:
1800         * Scripts/run-jsc-stress-tests:
1801
1802 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1803
1804         [CMake] Add missing WTF unit tests
1805         https://bugs.webkit.org/show_bug.cgi?id=131459
1806
1807         Reviewed by Martin Robinson.
1808
1809         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1810         that should be compiled into the TestWTF binary.
1811
1812 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1813
1814         [Gtk] run-launcher doesn't work by default
1815         https://bugs.webkit.org/show_bug.cgi?id=131494
1816
1817         Reviewed by Philippe Normand.
1818
1819         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1820         * Scripts/webkitdirs.pm:
1821         (launcherName): Same.
1822         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1823         * gtk/common.py:
1824         (get_build_path.is_valid_build_directory): Same.
1825         * gtk/manifest.txt: Same.
1826
1827 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1828
1829         Unreviewed, rolling out r167046.
1830         https://bugs.webkit.org/show_bug.cgi?id=131479
1831
1832         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1833         on #webkit).
1834
1835         Reverted changeset:
1836
1837         "Remove "System Font" from whitelisted DRT fonts and char
1838         width calculations"
1839         https://bugs.webkit.org/show_bug.cgi?id=131411
1840         http://trac.webkit.org/changeset/167046
1841
1842 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1843
1844         Remove "System Font" from whitelisted DRT fonts and char width calculations
1845         https://bugs.webkit.org/show_bug.cgi?id=131411
1846
1847         Reviewed by Tim Horton.
1848
1849         Covered by existing tests.
1850
1851         * DumpRenderTree/mac/DumpRenderTree.mm:
1852         (allowedFontFamilySet):
1853
1854 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1855
1856         systemHiddenFontFamilySet in DRT is unnecessary
1857         https://bugs.webkit.org/show_bug.cgi?id=131414
1858
1859         Reviewed by Tim Horton.
1860
1861         It doesn't seem to affect test results on my machine.
1862
1863         * DumpRenderTree/mac/DumpRenderTree.mm:
1864         (drt_NSFontManager_availableFonts):
1865         (systemHiddenFontFamilySet): Deleted.
1866
1867 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1868
1869         [Win] Unreviewed test fix: Don't double-release BSTR.
1870
1871         * DumpRenderTree/win/DumpRenderTree.cpp:
1872         (dump): Remove unneeded call to SysFreeString now that we are
1873         using _bstr_t for this variable.
1874
1875 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1876
1877         [Win] Various DumpRenderTree Fixes.
1878         https://bugs.webkit.org/show_bug.cgi?id=131446.
1879
1880         Reviewed by Tim Horton.
1881
1882         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1883         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1884         (AccessibilityUIElement::description): Ditto.
1885         (AccessibilityUIElement::helpText): Ditto.
1886         (AccessibilityUIElement::intValue): Ditto.
1887         (AccessibilityUIElement::isPressActionSupported): Ditto.
1888         (AccessibilityUIElement::accessibilityValue): Ditto.
1889         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1890         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1891         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1892         (DRTDesktopNotificationPresenter::Release): Ditto.
1893         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1894         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1895         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1896         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1897         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1898         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1899         * DumpRenderTree/win/DumpRenderTree.cpp:
1900         (dumpFrameScrollPosition): Ditto.
1901         (dumpFramesAsText): Ditto.
1902         (compareHistoryItems): Ditto.
1903         (dumpHistoryItem): Ditto.
1904         (dump): Ditto.
1905         (resetDefaultsToConsistentValues): Ditto.
1906         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1907         (runTest): Ditto.
1908         (createWebViewAndOffscreenWindow): Ditto.
1909         * DumpRenderTree/win/EditingDelegate.cpp:
1910         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1911         (EditingDelegate::AddRef): Ditto.
1912         (EditingDelegate::Release): Ditto.
1913         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1914         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1915         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1916         (EditingDelegate::shouldInsertNode): Ditto.
1917         (EditingDelegate::shouldInsertText): Ditto.
1918         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1919         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1920         (EditingDelegate::shouldApplyStyle): Ditto.
1921         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1922         (EditingDelegate::doPlatformCommand): Ditto.
1923         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1924         (EditingDelegate::webViewDidChange): Ditto.
1925         (EditingDelegate::webViewDidEndEditing): Ditto.
1926         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1927         (EditingDelegate::webViewDidChangeSelection): Ditto.
1928         (EditingDelegate::checkSpellingOfString): Ditto.
1929         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1930         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1931         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1932         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1933         (FrameLoadDelegate::AddRef): Ditto.
1934         (FrameLoadDelegate::Release): Ditto.
1935         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1936         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1937         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1938         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1939         (FrameLoadDelegate::didReceiveTitle): Ditto.
1940         (FrameLoadDelegate::didChangeIcons): Ditto.
1941         (delegatesWithDelayedWork): Ditto.
1942         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1943         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1944         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1945         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1946         (FrameLoadDelegate::willCloseFrame): Ditto.
1947         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1948         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1949         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1950         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1951         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1952         * DumpRenderTree/win/FrameLoadDelegate.h:
1953         * DumpRenderTree/win/HistoryDelegate.cpp:
1954         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1955         (HistoryDelegate::updateHistoryTitle): Ditto.
1956         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1957         * DumpRenderTree/win/PolicyDelegate.cpp:
1958         (dumpPath):
1959         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1960         (PolicyDelegate::AddRef): Ditto.
1961         (PolicyDelegate::Release): Ditto.
1962         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1963         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1964         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1965         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1966         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1967         (ResourceLoadDelegate::AddRef): Ditto.
1968         (ResourceLoadDelegate::Release): Ditto.
1969         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1970         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1971         (ResourceLoadDelegate::willSendRequest): Ditto.
1972         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1973         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1974         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1975         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1976         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1977         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1978         (TestRunner::setUserStyleSheetLocation): Ditto.
1979         (TestRunner::execCommand): Ditto.
1980         (TestRunner::overridePreference): Ditto.
1981         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1982         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1983         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1984         (TextInputController::insertText): Ditto.
1985         * DumpRenderTree/win/UIDelegate.cpp:
1986         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1987         (UIDelegate::AddRef): Ditto.
1988         (UIDelegate::Release): Ditto.
1989         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1990         (UIDelegate::trackCustomPopupMenu): Ditto.
1991         (UIDelegate::registerUndoWithTarget): Ditto.
1992         (UIDelegate::removeAllActionsWithTarget): Ditto.
1993         (UIDelegate::setActionTitle): Ditto.
1994         (UIDelegate::undo): Ditto.
1995         (UIDelegate::redo): Ditto.
1996         (UIDelegate::canUndo): Ditto.
1997         (UIDelegate::canRedo): Ditto.
1998         (UIDelegate::printFrame): Ditto.
1999         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2000         (UIDelegate::webViewHeaderHeight): Ditto.
2001         (UIDelegate::webViewFooterHeight): Ditto.
2002         (UIDelegate::drawHeaderInRect): Ditto.
2003         (UIDelegate::drawFooterInRect): Ditto.
2004         (UIDelegate::webViewPrintingMarginRect): Ditto.
2005         (UIDelegate::canRunModal): Ditto.
2006         (UIDelegate::createModalDialog): Ditto.
2007         (UIDelegate::runModal): Ditto.
2008         (UIDelegate::isMenuBarVisible): Ditto.
2009         (UIDelegate::setMenuBarVisible): Ditto.
2010         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2011         (UIDelegate::paintCustomScrollbar): Ditto.
2012         (UIDelegate::paintCustomScrollCorner): Ditto.
2013         (UIDelegate::setFrame): Ditto.
2014         (UIDelegate::webViewFrame): Ditto.
2015         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2016         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2017         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2018         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2019         (UIDelegate::webViewAddMessageToConsole): Ditto.
2020         (UIDelegate::doDragDrop): Ditto.
2021         (UIDelegate::webViewGetDlgCode): Ditto.
2022         (UIDelegate::createWebViewWithRequest): Ditto.
2023         (UIDelegate::webViewClose): Ditto.
2024         (UIDelegate::webViewFocus): Ditto.
2025         (UIDelegate::webViewUnfocus): Ditto.
2026         (UIDelegate::webViewPainted): Ditto.
2027         (UIDelegate::exceededDatabaseQuota): Ditto.
2028         (UIDelegate::embeddedViewWithArguments): Ditto.
2029         (UIDelegate::webViewClosing): Ditto.
2030         (UIDelegate::webViewSetCursor): Ditto.
2031         (UIDelegate::webViewDidInvalidate): Ditto.
2032         (UIDelegate::setStatusText): Ditto.
2033         (UIDelegate::desktopNotificationsDelegate): Ditto.
2034         (UIDelegate::drawBackground): Ditto.
2035         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2036         (UIDelegate::didPressMissingPluginButton): Ditto.
2037         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2038         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2039         (LoadHTMLStringItem::invoke): Ditto.
2040         (ScriptItem::invoke): Ditto.
2041
2042 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2043
2044         Stylechecker: False positive on inline asm code.
2045         https://bugs.webkit.org/show_bug.cgi?id=130570
2046
2047         Reviewed by Csaba Osztrogonác.
2048
2049         Disable stylechecking in asm blocks.
2050
2051         * Scripts/webkitpy/style/checkers/cpp.py:
2052         (process_line):
2053         (_InlineASMState):
2054         (_InlineASMState.__init__):
2055         (_InlineASMState.process_line):
2056         (_InlineASMState.isInside):
2057         (_process_lines):
2058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2059         (WebKitStyleTest.test_member_initialization_list):
2060
2061 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2064         https://bugs.webkit.org/show_bug.cgi?id=131029
2065
2066         Reviewed by Philippe Normand.
2067
2068         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2069         tests and remove the getWebKit1TestResoucesDir() method.
2070
2071         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2072         (testDownloadLocalFile): Use Test::getResourcesDir().
2073         (testDownloadLocalFileError): Ditto.
2074         (serverCallback): Ditto.
2075         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2076         (serverCallback): Ditto.
2077         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2078         (httpServerCallback): Ditto.
2079         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2080         (serverCallback): Ditto.
2081         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2082         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2083         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2084         (Test::getWebKit1TestResoucesDir): Deleted.
2085
2086 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2087
2088         [WK2] HTTP authentication regression tests fail
2089         https://bugs.webkit.org/show_bug.cgi?id=81627
2090         <rdar://problem/11079296>
2091
2092         Reviewed by Anders Carlsson.
2093
2094         * WebKitTestRunner/TestController.h:
2095         * WebKitTestRunner/TestController.cpp:
2096         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2097         to pageLoaderClient structure.
2098         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2099         for password based authentication (we do get server trust challenges on some tests,
2100         which WKTR can't handle).
2101         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2102         calls won't be made, at least on CFNetwork based platforms.
2103         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2104         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2105         make sense to associate auth requests with individual resources - there can be
2106         multiple resources loading at once from the same protection space, so WebKit1 API
2107         that had a resource identifier was inherently racy.
2108
2109 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2110
2111         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2112         https://bugs.webkit.org/show_bug.cgi?id=131427
2113
2114         Reviewed by Gyuyoung Kim.
2115
2116         Since r166973, font path was changed.
2117
2118         * DumpRenderTree/PlatformEfl.cmake:
2119         * WebKitTestRunner/PlatformEfl.cmake:
2120
2121 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2122
2123         Fix the build-jsc build
2124         https://bugs.webkit.org/show_bug.cgi?id=131410
2125
2126         Reviewed by Michael Saboff.
2127
2128         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2129         WTF depends on it.
2130
2131 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2132
2133         [GTK] Remove WebKit1 unit tests
2134         https://bugs.webkit.org/show_bug.cgi?id=131359
2135
2136         Reviewed by Anders Carlsson.
2137
2138         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2139         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2140         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2141
2142         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2143         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2144         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2145         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2146         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2147         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2148         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2149         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2150         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2151         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2152         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2153         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2154         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2155         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2156         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2157         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2158         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2159         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2160         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2161         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2162         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2163         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2164         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2165         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2166         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2167         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2168         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2169         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2170         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2171         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2172         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2173         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2174         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2175         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2176         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2177         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2178         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2179         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2180
2181 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2182
2183         Unreviewed gardening (Take 2): Prevent users from attempting
2184         to build with known invalid cURL. 
2185
2186         * Scripts/webkitdirs.pm:
2187         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2188         7.33.0 (the known good version).
2189
2190 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2191
2192         [GTK] Remove DumpRenderTree and GtkLauncher
2193         https://bugs.webkit.org/show_bug.cgi?id=131373
2194
2195         Reviewed by Andreas Kling.
2196
2197         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2198         no longer necessary now that WebKit1 GTK+ will be removed.
2199
2200         * CMakeLists.txt:
2201         * DumpRenderTree/PlatformGTK.cmake: Removed.
2202         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2203         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2204         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2205         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2206         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2207         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2208         * DumpRenderTree/gtk/EventSender.h: Removed.
2209         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2210         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2211         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2212         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2213         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2214         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2215         * DumpRenderTree/gtk/TextInputController.h: Removed.
2216         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2217         * GtkLauncher/CMakeLists.txt: Removed.
2218         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2219         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2220         * GtkLauncher/main.c: Removed.
2221         * GtkLauncher/simple.svg: Removed.
2222         * GtkLauncher/text.html: Removed.
2223         * WebKitTestRunner/PlatformGTK.cmake:
2224         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
2225         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
2226         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
2227
2228 2014-04-08  Mark Rowe  <mrowe@apple.com>
2229
2230         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
2231         <https://webkit.org/b/131388> / <rdar://problem/16291687>
2232
2233         Reviewed by Alexey Proskuryakov.
2234
2235         * Scripts/webkitdirs.pm:
2236         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
2237         (execMacWebKitAppForDebugging): Ditto.
2238
2239 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2240
2241         Build bmalloc on iOS too
2242         https://bugs.webkit.org/show_bug.cgi?id=131381
2243
2244         Reviewed by Andreas Kling.
2245
2246         * Scripts/build-webkit:
2247
2248 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2249
2250         Unreviewed gardening: Prevent users from attempting
2251         to build with known invalid cURL.
2252
2253         * Scripts/webkitdirs.pm:
2254         (checkInstalledTools): Block build attempts with bad
2255         Cygwin tool set.
2256
2257 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2258
2259         Build bmalloc on Mac
2260         https://bugs.webkit.org/show_bug.cgi?id=131333
2261
2262         Reviewed by Mark Rowe.
2263
2264         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2265         (Note: Just testing Mac is not good enough because in this
2266         script 'Mac' means 'Mac or iOS'.)
2267
2268 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2269
2270         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2271         https://bugs.webkit.org/show_bug.cgi?id=130951
2272
2273         Reviewed by Geoffrey Garen.
2274
2275         * Scripts/run-javascriptcore-tests:
2276
2277 2014-04-06  Darin Adler  <darin@apple.com>
2278
2279         Rework CSS calc logic, fixing some reference count mistakes in Length
2280         https://bugs.webkit.org/show_bug.cgi?id=131280
2281
2282         Reviewed by Andreas Kling.
2283
2284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2285         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2286
2287 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2288
2289         Enable WEB_REPLAY for PLATFORM(MAC)
2290         https://bugs.webkit.org/show_bug.cgi?id=130700
2291
2292         Reviewed by Timothy Hatcher.
2293
2294         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2295
2296 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2297
2298         [CMake] Include X11's include dirs in TestNetscapePlugin
2299         https://bugs.webkit.org/show_bug.cgi?id=131270
2300
2301         Reviewed by Martin Robinson.
2302
2303         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2304         TestNetscapePlugin includes WebCore code that includes X headers.
2305
2306 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2307
2308         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2309         <http://webkit.org/b/130986>
2310
2311         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2312         prefix to TileCache class names in exception list.
2313
2314 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2315
2316         [GTK] kill-old-processes should kill dbus-daemon processes
2317         https://bugs.webkit.org/show_bug.cgi?id=127352
2318
2319         Reviewed by Martin Robinson.
2320
2321         * BuildSlaveSupport/kill-old-processes:
2322         (main):
2323
2324 2014-04-04  Andres Gomez  <agomez@igalia.com>
2325
2326         [Win] Update obsolete packages in cygwin
2327         https://bugs.webkit.org/show_bug.cgi?id=126264
2328
2329         Reviewed by Brent Fulgham.
2330
2331         Removed "apache" and "minires" as the first has been replaced by
2332         "lighttpd" and the second is now integrated into
2333         "cygwin". Replaced the transitional and now obsolete "gcc" package
2334         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2335         since the newer version available is "2.7.3" which breaks the
2336         build due to some funniness with environment variable handling.
2337
2338         * CygwinDownloader/cygwin-downloader.py:
2339         * CygwinDownloader/cygwin-downloader.zip:
2340
2341 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2342
2343         check-webkit-style: Improve warnings on Objective-C @property syntax
2344         https://bugs.webkit.org/show_bug.cgi?id=131200
2345
2346         Reviewed by Dan Bernstein.
2347
2348         * Scripts/webkitpy/style/checkers/cpp.py:
2349         (check_spacing):
2350         (CppChecker):
2351         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2352         (CppStyleTest.test_spacing_in_objective_c_properties):
2353
2354 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2355
2356         Unreviewed. Moving my name to commiter section
2357
2358         * Scripts/webkitpy/common/config/contributors.json:
2359
2360 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2361
2362         Unreviewed. Add myself as a committer.
2363
2364         * Scripts/webkitpy/common/config/contributors.json:
2365
2366 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2367
2368         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2369         https://bugs.webkit.org/show_bug.cgi?id=130391
2370
2371         Reviewed by Gyuyoung Kim.
2372
2373         Change the implementation of the zoom functionality from ewk_view_scale_set
2374         to ewk_view_page_zoom_set.
2375
2376         * MiniBrowser/efl/main.c:
2377
2378 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2379
2380         [webkitpy] perf profiler does not understand --call-graph argument
2381         https://bugs.webkit.org/show_bug.cgi?id=131132
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         New versions of perf profiler have changed the argument from --call-graph to -g.
2386
2387         * Scripts/webkitpy/common/system/profiler.py:
2388         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2389         * Scripts/webkitpy/port/driver_unittest.py:
2390         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2391
2392 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2393
2394         Add EFL WK2 performance bot to build.webkit.org
2395         https://bugs.webkit.org/show_bug.cgi?id=131034
2396
2397         Fix after r166707, use "Perf" instead of "perf" for consistency.
2398
2399         Reviewed by Csaba Osztrogonác.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/config.json:
2402
2403 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2404
2405         Add EFL WK2 performance bot to build.webkit.org
2406         https://bugs.webkit.org/show_bug.cgi?id=131034
2407
2408         Reviewed by Csaba Osztrogonác.
2409
2410         * BuildSlaveSupport/build.webkit.org-config/config.json:
2411
2412 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2413
2414         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2415         https://bugs.webkit.org/show_bug.cgi?id=131151
2416
2417         Reviewed by Gyuyoung Kim.
2418
2419         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2420         (TouchEventInfo::TouchEventInfo):
2421         (sendTouchEvent):
2422         (addTouchPointCallback):
2423         (updateTouchPointCallback):
2424         (cancelTouchPointCallback):
2425         (releaseTouchPointCallback):
2426
2427 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2428
2429         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2430         <http://webkit.org/b/131045>
2431
2432         Reviewed by Daniel Bates.
2433
2434         * Scripts/filter-build-webkit:
2435         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2436         of clang, plus debug data for all DVTAssertions.
2437
2438 2014-04-01  Dean Jackson  <dino@apple.com>
2439
2440         Load Media Controls js/css from bundle
2441         https://bugs.webkit.org/show_bug.cgi?id=131086
2442
2443         Reviewed by Eric Carlson.
2444
2445         We're now putting CSS files into the bundle, so remove the test for them.
2446
2447         * Scripts/check-for-inappropriate-files-in-framework:
2448
2449 2014-04-02  Martin Hock  <mhock@apple.com>
2450
2451         Unify private browsing with sessions.
2452         https://bugs.webkit.org/show_bug.cgi?id=130099
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2459         (TestWebKitAPI::didNavigateWithNavigationData):
2460         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2461         (TestWebKitAPI::TEST):
2462
2463         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2464         (TestWebKitAPI::didNavigateWithoutNavigationData):
2465         (TestWebKitAPI::didNavigateWithNavigationData):
2466         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2467         (TestWebKitAPI::TEST):
2468
2469 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2470
2471         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2472         https://bugs.webkit.org/show_bug.cgi?id=130343
2473
2474         Reviewed by Gustavo Noronha Silva.
2475
2476         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2477         of directories on the command line and look for all appropriate files in those directories for the
2478         GResource archive. Also make archive paths relative to those directories.
2479         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2480         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2481
2482 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2483
2484         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2485         https://bugs.webkit.org/show_bug.cgi?id=131106
2486
2487         Reviewed by Csaba Osztrogonác.
2488
2489         * Scripts/webkitpy/tool/commands/download.py:
2490         (AbstractRolloutPrepCommand._prepare_state):
2491         * Scripts/webkitpy/tool/commands/download_unittest.py:
2492         (test_prepare_rollout):
2493         (test_create_rollout):
2494         (test_create_rollout_resolved):
2495         (test_rollout):
2496
2497 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2498
2499         [EFL] Add option to use separate web process for new window in MiniBrowser
2500         https://bugs.webkit.org/show_bug.cgi?id=130190
2501
2502         Reviewed by Gyuyoung Kim.
2503
2504         New created window (CTRL + n) will be open in separated web process.
2505         This option is enabled by adding a flag (S/separate-process) with launching
2506         MiniBrowser.
2507
2508         * MiniBrowser/efl/main.c:
2509         (elm_main):
2510
2511 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2512
2513         [GTK] Move NEWS file to a new location
2514         https://bugs.webkit.org/show_bug.cgi?id=130901
2515
2516         Reviewed by Brent Fulgham.
2517
2518         * gtk/manifest.txt: Update the NEWS file path.
2519
2520 2014-04-01  Anders Carlsson  <andersca@apple.com>
2521
2522         Fix build.
2523
2524         * MiniBrowser/mac/WK2BrowserWindowController.m:
2525         (-[WK2BrowserWindowController awakeFromNib]):
2526         (-[WK2BrowserWindowController dealloc]):
2527         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2528
2529 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2530
2531         Unreviewed test gardening.
2532
2533         * Scripts/webkitpy/port/base_unittest.py:
2534         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2535
2536 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2537
2538         [CSS Exclusions] Remove exclusions parsing support
2539         https://bugs.webkit.org/show_bug.cgi?id=131046
2540
2541         Reviewed by David Hyatt.
2542
2543         * Scripts/webkitperl/FeatureList.pm:
2544
2545 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2546
2547         [GTK] Remove last reference to GTK+ WK1 EWS
2548         https://bugs.webkit.org/show_bug.cgi?id=131058
2549
2550         Reviewed by Martin Robinson.
2551
2552         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2553
2554         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2555
2556 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2557
2558         Add a 32bit JSC builder/tester.
2559         https://bugs.webkit.org/show_bug.cgi?id=131054
2560         
2561         Reviewed by Michael Saboff.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/config.json:
2564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2565         (Compile32bitJSC):
2566         (Run32bitJSCTests):
2567         (Run32bitJSCTests.countFailures):
2568         (BuildAndTest32bitJSCFactory):
2569         (BuildAndTest32bitJSCFactory.__init__):
2570
2571 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2572
2573         [GTK] No longer build WebKit1 gtkdoc
2574         https://bugs.webkit.org/show_bug.cgi?id=130970
2575
2576         Reviewed by Anders Carlsson.
2577
2578         * gtk/common.py:
2579         (gtk_version_of_pkg_config_file): Deleted.
2580         * gtk/generate-gtkdoc:
2581         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2582         was only applicable for WebKit1.
2583         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2584
2585 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2586
2587         [GTK] Running minibrowser with url crashes in debug build
2588         https://bugs.webkit.org/show_bug.cgi?id=130492
2589
2590         Reviewed by Martin Robinson.
2591
2592         Update "uri-scheme" test not to use invalid URIs in it, so we
2593         don't get a mistmatch when comparing the original URI stored in
2594         the test class with the one returned by the WebKitWebView.
2595
2596         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2597         (testWebContextURIScheme): Update the test.
2598
2599 2014-04-01  Mihai Tica  <mitica@adobe.com>
2600
2601         Unreviewed: Add myself as a commiter to the contributors list.
2602
2603         * Scripts/webkitpy/common/config/contributors.json:
2604
2605 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2606
2607         [EFL][WK2] Extract the control of page background out of color_set
2608         https://bugs.webkit.org/show_bug.cgi?id=127539
2609
2610         Reviewed by Gyuyoung Kim.
2611
2612         Added an option(C) to change background color.
2613
2614         * MiniBrowser/efl/main.c:
2615         (window_create):
2616         (elm_main):
2617
2618 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2619
2620         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2621
2622         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2623
2624 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2625
2626         Unreviewed test correction after r166530.
2627
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2630         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2631
2632 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2633
2634         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2635         https://bugs.webkit.org/show_bug.cgi?id=130987
2636
2637         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2638         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2639
2640         Reviewed by Martin Robinson.
2641
2642         * BuildSlaveSupport/build.webkit.org-config/config.json:
2643
2644 2014-03-31  Dean Jackson  <dino@apple.com>
2645
2646         Remove WEB_ANIMATIONS
2647         https://bugs.webkit.org/show_bug.cgi?id=130989
2648
2649         Reviewed by Simon Fraser.
2650
2651         Remove this feature flag until we plan to implement.
2652
2653         * Scripts/webkitperl/FeatureList.pm:
2654
2655 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2656
2657         Reduced Latched Scroll Test Flakiness
2658         https://bugs.webkit.org/show_bug.cgi?id=130983
2659
2660         Reviewed by Darin Adler.
2661
2662         * DumpRenderTree/mac/DumpRenderTree.mm:
2663         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2664         * DumpRenderTree/mac/EventSendingController.mm:
2665         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2666         with high resolution flags turned on.
2667         * WebKitTestRunner/mac/EventSenderProxy.mm:
2668         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2669
2670 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2671
2672         run-webkit-tests should have a --no-timeout option
2673         https://bugs.webkit.org/show_bug.cgi?id=128286
2674
2675         Reviewed by Joseph Pecoraro.
2676
2677         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2678         (Worker._run_test): Renaming _run_test_with_timeout()
2679         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2680         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2681         (Worker._run_test_in_this_thread):
2682         (Worker._run_test_with_timeout): Deleted.
2683         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2684         (parse_args): Added the --no-timeout option
2685
2686 2014-03-31  Samuel White  <samuel_white@apple.com>
2687
2688         AX: Need ability to get line range for text marker.
2689         https://bugs.webkit.org/show_bug.cgi?id=130906
2690
2691         Reviewed by Chris Fleizach.
2692
2693         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2694
2695         * DumpRenderTree/AccessibilityUIElement.cpp:
2696         (lineTextMarkerRangeForTextMarkerCallback):
2697         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2698         (AccessibilityUIElement::getJSClass):
2699         * DumpRenderTree/AccessibilityUIElement.h:
2700         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2701         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2702         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2703         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2704         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2705         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2706         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2707         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2708         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2709         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2710         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2711         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2712
2713 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2714
2715         More validation for FTL inline caches
2716         https://bugs.webkit.org/show_bug.cgi?id=130948
2717
2718         Reviewed by Geoffrey Garen.
2719
2720         * Scripts/run-jsc-stress-tests:
2721
2722 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2723
2724         [GTK] Do not run WebKit1 unit tests by default
2725         https://bugs.webkit.org/show_bug.cgi?id=130968
2726
2727         Reviewed by Martin Robinson.
2728
2729         * Scripts/run-gtk-tests:
2730         (TestRunner):
2731
2732 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2733
2734         [GTK] Remove scripts code only applicable to autotools
2735         https://bugs.webkit.org/show_bug.cgi?id=130841
2736
2737         Reviewed by Anders Carlsson.
2738
2739         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2740         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2741         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2742         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2743         * gtk/find-make-dist-errors: Removed.
2744         * gtk/generate-feature-defines-files: Removed.
2745         * gtk/manifest.txt: No longer need to consider autotools files.
2746
2747 2014-03-30  Andy Estes  <aestes@apple.com>
2748
2749         Fix two failing layout tests on Mountain Lion after r166466.
2750
2751         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2752         (-[DownloadDelegate _downloadDidStart:]):
2753
2754 2014-03-30  Andy Estes  <aestes@apple.com>
2755
2756         [Cocoa] Add an originatingWebView property to _WKDownload
2757         https://bugs.webkit.org/show_bug.cgi?id=130945
2758
2759         Reviewed by Anders Carlsson.
2760
2761         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2762         (-[DownloadDelegate _downloadDidStart:]):
2763         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2764         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2765         (TEST):
2766
2767 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2768
2769         Land the stackmap register liveness glue with the uses of the liveness disabled
2770         https://bugs.webkit.org/show_bug.cgi?id=130924
2771
2772         Reviewed by Oliver Hunt.
2773
2774         * Scripts/run-jsc-stress-tests:
2775
2776 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2777
2778         Update WebKit1.StringTruncator for Mountain Lion.
2779
2780         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2781         due to different font metrics on 10.8.
2782
2783 2014-03-28  Darin Adler  <darin@apple.com>
2784
2785         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2786         https://bugs.webkit.org/show_bug.cgi?id=130889
2787
2788         Reviewed by Alexey Proskuryakov.
2789
2790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2791         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2792         WebStringTruncator methods; should be good for a start. These are dependent on the
2793         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2794
2795 2014-03-28  Martin Hock  <mhock@apple.com>
2796
2797         Unreviewed. Add myself as a committer.
2798
2799         * Scripts/webkitpy/common/config/contributors.json:
2800
2801 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2802
2803         Remove WebKit1 GTK+ bots
2804         https://bugs.webkit.org/show_bug.cgi?id=130904
2805
2806         Reviewed by Anders Carlsson.
2807
2808         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2809         all bots are testing WebKit2 only.
2810         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2811         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2812         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2813         * Scripts/webkitpy/port/builders.py: Ditto.
2814         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2815         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2816
2817 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2818
2819         Remove Brian Burg's apple.com email address.
2820
2821         * Scripts/webkitpy/common/config/contributors.json:
2822
2823 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2824
2825         bisect-builds should print Trac 'changeset' URL if only one build is detected
2826         <http://webkit.org/b/130903>
2827
2828         Reviewed by Dan Bernstein.
2829
2830         * Scripts/bisect-builds:
2831         (printTracLink): Print a direct link to the Trac 'changeset'
2832         URL if there is only one revision in the range.
2833
2834 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2835
2836         [EFL] Bump glib version from 2.36 to 2.38 
2837         https://bugs.webkit.org/show_bug.cgi?id=130886
2838
2839         Reviewed by Csaba Osztrogonác.
2840
2841         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2842         we need to bump glib version up to 2.38 as gtk port.
2843
2844         * efl/jhbuild.modules:
2845
2846 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2847
2848         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2849
2850         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2851         the globalhistory directory.
2852
2853         Reviewed by Sam Weinig.
2854
2855         * WebKitTestRunner/TestController.cpp:
2856         (WTR::TestController::TestController):
2857         (WTR::TestController::initialize): Set the history client.
2858         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2859         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2860         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2861         and we don't yet have API to access the data in question.
2862         (WTR::TestController::didPerformClientRedirect):
2863         (WTR::TestController::didPerformServerRedirect):
2864         (WTR::TestController::didUpdateHistoryTitle):
2865         * WebKitTestRunner/TestController.h:
2866         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2867         * WebKitTestRunner/TestInvocation.cpp:
2868         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2869         (WTR::TestInvocation::invoke):
2870
2871 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2872
2873         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2874
2875         * Scripts/build-webkit:
2876         * Scripts/copy-webkitlibraries-to-product-directory:
2877
2878 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2879
2880         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2881         https://bugs.webkit.org/show_bug.cgi?id=130867
2882         <rdar://problem/16432456> 
2883
2884         Reviewed by Mark Hahnenberg.
2885
2886         * Scripts/build-webkit:
2887         * Scripts/copy-webkitlibraries-to-product-directory:
2888
2889 2014-03-26  Andy Estes  <aestes@apple.com>
2890
2891         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2892         https://bugs.webkit.org/show_bug.cgi?id=130805
2893
2894         Reviewed by Dan Bernstein.
2895
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2897         (-[DownloadDelegate _download:didReceiveResponse:]):
2898         (-[DownloadDelegate _downloadDidFinish:]):
2899         (runTest):
2900         (TEST):
2901         (-[FailingDownloadDelegate _downloadDidFinish:]):
2902         (-[FailingDownloadDelegate _download:didFailWithError:]):
2903         (-[FailingDownloadDelegate _downloadDidCancel:]):
2904         (-[CancelledDownloadDelegate _downloadDidStart:]):
2905         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2906         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2907         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2908         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2909         (-[DownloadDelegate sourceURL]): Deleted.
2910         (runTestWithNavigationDelegate): Deleted.
2911
2912 2014-03-26  Anders Carlsson  <andersca@apple.com>
2913
2914         Change MiniBrowser to hold on to window controllers instead of windows
2915         https://bugs.webkit.org/show_bug.cgi?id=130797
2916
2917         Reviewed by Oliver Hunt.
2918
2919         * MiniBrowser/mac/AppDelegate.h:
2920         * MiniBrowser/mac/AppDelegate.m:
2921         (-[BrowserAppDelegate init]):
2922         (-[BrowserAppDelegate newWindow:]):
2923         (-[BrowserAppDelegate browserWindowWillClose:]):
2924         (-[BrowserAppDelegate applicationWillTerminate:]):
2925         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2926
2927 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2928
2929         Unreviewed, rolling out r166264.
2930         https://bugs.webkit.org/show_bug.cgi?id=130785
2931
2932         Broke some window.opener tests for WK2 Mavericks (Requested by
2933         brrian__ on #webkit).
2934
2935         Reverted changeset:
2936
2937         "Web Replay: resource unique identifiers should be unique-per-
2938         frame, not globally"
2939         https://bugs.webkit.org/show_bug.cgi?id=130632
2940         http://trac.webkit.org/changeset/166264
2941
2942 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2943
2944         [CSS Shapes] Remove shape-inside support
2945         https://bugs.webkit.org/show_bug.cgi?id=130698
2946
2947         Reviewed by David Hyatt.
2948
2949         * Scripts/webkitperl/FeatureList.pm:
2950
2951 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2952
2953         Unreviewed. Add myself as a committer.
2954
2955         * Scripts/webkitpy/common/config/contributors.json:
2956
2957 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2958
2959         run-launcher is Perl script so use elsif and not elif
2960         https://bugs.webkit.org/show_bug.cgi?id=130771
2961
2962         Reviewed by Carlos Garcia Campos.
2963
2964         * Scripts/run-launcher:
2965
2966 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2967
2968         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2969         https://bugs.webkit.org/show_bug.cgi?id=130575
2970
2971         Reviewed by Mario Sanchez Prada.
2972
2973         Change ATK version to 2.11.92. Adjust current implementation.
2974
2975         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2976         (AccessibilityUIElement::intValue):
2977         (AccessibilityUIElement::minValue):
2978         (AccessibilityUIElement::maxValue):
2979         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2980         (WTR::AccessibilityUIElement::intValue):
2981         (WTR::AccessibilityUIElement::minValue):
2982         (WTR::AccessibilityUIElement::maxValue):
2983         * efl/jhbuild.modules:
2984         * gtk/jhbuild.modules:
2985
2986 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2987
2988         [GTK] The gnumake package is no longer needed in jhbuild
2989         https://bugs.webkit.org/show_bug.cgi?id=130121
2990
2991         Reviewed by Martin Robinson.
2992
2993         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2994         for a debug build cmake/system-gnumake worked just fine for me.
2995
2996         * gtk/jhbuild.modules: Removed gnumake.
2997         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2998         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2999
3000 2014-03-25  Andy Estes  <aestes@apple.com>
3001
3002         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3003
3004         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3005         (-[DownloadDelegate _download:didReceiveData:]):
3006         (-[DownloadDelegate _downloadDidFinish:]):
3007
3008 2014-03-25  Brian Burg  <bburg@apple.com>
3009
3010         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3011         https://bugs.webkit.org/show_bug.cgi?id=130623
3012
3013         Reviewed by Timothy Hatcher.
3014
3015         The resource loader callback dumping routines assumed that resource identifiers
3016         were globally unique. Its map of resource identifiers to URLs must also track the
3017         frame associated with the resource.
3018
3019         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3020         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3021         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3022         stable as long as the frame is valid.
3023         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3024         (WTR::InjectedBundlePage::willSendRequestForFrame):
3025         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3026         (WTR::InjectedBundlePage::didFinishLoadForResource):
3027         (WTR::InjectedBundlePage::didFailLoadForResource):
3028
3029 2014-03-25  Andy Estes  <aestes@apple.com>
3030
3031         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3032
3033         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3034         (-[DownloadDelegate _download:didReceiveResponse:]):
3035         (-[DownloadDelegate _download:didReceiveData:]):
3036
3037 2014-03-25  Andy Estes  <aestes@apple.com>
3038
3039         Add some debug logging to an API test that's failing on Mountain Lion.
3040
3041         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3042         (-[DownloadDelegate _download:didReceiveResponse:]):
3043         (-[DownloadDelegate _downloadDidFinish:]):
3044
3045 2014-03-25  Anders Carlsson  <andersca@apple.com>
3046
3047         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3048         https://bugs.webkit.org/show_bug.cgi?id=130732
3049
3050         Reviewed by Tim Horton.
3051
3052         * MiniBrowser/mac/WK2BrowserWindowController.m:
3053         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3054
3055 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3056
3057         [GTK] Remove the autotools build
3058         https://bugs.webkit.org/show_bug.cgi?id=130717
3059
3060         Reviewed by Anders Carlsson.
3061
3062         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3063         * GNUmakefile.am: Removed.
3064         * GtkLauncher/GNUmakefile.am: Removed.
3065         * GtkLauncher/main.c: Remove references to the autotools configure file.
3066         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3067         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3068         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3069         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3070         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3071         * Scripts/build-webkit: No longer handle autotools.
3072         * Scripts/run-gtk-tests: Ditto.
3073         (TestRunner._setup_testing_environment):
3074         * Scripts/run-launcher: Ditto.
3075         * Scripts/webkitdirs.pm: Ditto.
3076         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3077         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3078         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3079         * Scripts/webkitpy/style/checker.py:
3080         * TestWebKitAPI/GNUmakefile.am: Removed.
3081         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3082         * WebKitTestRunner/GNUmakefile.am: Removed.
3083         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3084         * gtk/GNUmakefile.am: Removed.
3085         * gtk/common.py: Remove checks for the autotools build.
3086         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3087
3088 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3089
3090         prepare-ChangeLog throws false positive warnings for modified files.
3091         https://bugs.webkit.org/show_bug.cgi?id=130687
3092
3093         Reviewed by Darin Adler.
3094
3095         * Scripts/prepare-ChangeLog:
3096         (originalFile): Ignore git commit paremeter.
3097         We don't need this to get the unmodified file.
3098         (extractLineRangeBeforeChange):
3099         Simplify the if statement. Follow-up after r166189.
3100
3101 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3102
3103         [EFL] Add ARM64 build support
3104         https://bugs.webkit.org/show_bug.cgi?id=130506
3105
3106         Rubber stamped by Gyuyoung Kim.
3107
3108         * Scripts/webkitdirs.pm:
3109         (isARM): Detect aarch64 as ARM.
3110
3111 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3112
3113         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3114         https://bugs.webkit.org/show_bug.cgi?id=130137
3115
3116         Reviewed by Csaba Osztrogonác.
3117
3118         * Scripts/webkitpy/common/checkout/changelog.py:
3119         (ChangeLogEntry._parse_bug_description):
3120         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3121         (test_parse_log_entries_from_changelog):
3122         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3123         (CheckoutTest.test_commit_info_for_revision):
3124
3125 2014-03-24  Andy Estes  <aestes@apple.com>
3126
3127         Fix the iOS build of TestWebKitAPI.
3128
3129         * TestWebKitAPI/Configurations/Base.xcconfig:
3130         * TestWebKitAPI/PlatformUtilities.h:
3131
3132 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3133
3134         Fix prepare-ChangeLog after r166156.
3135         https://bugs.webkit.org/show_bug.cgi?id=130674
3136
3137         Reviewed by Darin Adler.
3138
3139         * Scripts/prepare-ChangeLog:
3140         (generateFunctionLists):
3141         (extractLineRangeBeforeChange):
3142
3143 2014-03-24  Andy Estes  <aestes@apple.com>
3144
3145         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3146         https://bugs.webkit.org/show_bug.cgi?id=129322
3147
3148         Reviewed by Anders Carlsson.
3149
3150         Add an API test suite for _WKDownload.
3151
3152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3153         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3154         (-[DownloadDelegate initWithSourceURL:]):
3155         (-[DownloadDelegate sourceURL]):
3156         (-[DownloadDelegate _downloadDidStart:]):
3157         (-[DownloadDelegate _download:didReceiveResponse:]):
3158         (-[DownloadDelegate _download:didReceiveData:]):
3159         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3160         (-[DownloadDelegate _downloadDidFinish:]):
3161         (TEST):
3162         (runTestWithNavigationDelegate):
3163         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3164         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3165
3166 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3167
3168         filter-build-webkit: reduce unfiltered output
3169         https://bugs.webkit.org/show_bug.cgi?id=130485
3170
3171         Reviewed by Brent Fulgham.
3172
3173         * Scripts/filter-build-webkit:
3174         (shouldIgnoreLine):
3175
3176 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3177
3178         prepare-ChangeLog should list functions that have been removed too.
3179         https://bugs.webkit.org/show_bug.cgi?id=130508
3180
3181         Reviewed by Darin Adler.
3182
3183         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3184         We have to read the functions and the line ranges of them from the source
3185         before the change, then search for overlaps between them and the changed
3186         line ranges from diff.
3187
3188         * Scripts/prepare-ChangeLog:
3189         (originalFile): Get original source command.
3190         (generateFunctionLists): Collect deleted functions too.
3191         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3192         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3193         deleted functions ranges too.
3194         (extractLineRange): Renamed to extractLineRangeAfterChange.
3195
3196 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3197
3198         Move all EFL typedefs into EflTypedefs.h.
3199         https://bugs.webkit.org/show_bug.cgi?id=130511
3200
3201         Reviewed by Gyuyoung Kim.
3202
3203         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3204         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3205         * WebKitTestRunner/PlatformWebView.h: Ditto.
3206
3207 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3208
3209         Don't flush compositing layers within FrameView::willPaintContents()
3210         https://bugs.webkit.org/show_bug.cgi?id=130627
3211         <rdar://problem/16368869>
3212
3213         Reviewed by Sam Weinig.
3214         
3215         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3216         does not flush.
3217         
3218         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3219         into an explicit function called before dumping. 
3220         
3221         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
3222         are flushed to CA. They will be pushed to the window by snapshotting.
3223
3224         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3225         Fix weird path to IOKit.framework.
3226         * DumpRenderTree/mac/DumpRenderTree.mm:
3227         (updateDisplay):
3228         (dump):
3229         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3230         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
3231         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
3232
3233 2014-03-21  David Kilzer  <ddkilzer@apple.com>
3234
3235         fix-blink-patch: tool to fix up renamed directory paths in Blink
3236         <http://webkit.org/b/130609>
3237
3238         Reviewed by Ryosuke Niwa.
3239
3240         Usage: cat blink.patch | fix-blink-patch | svn-apply
3241
3242         * Scripts/fix-blink-patch: Added.
3243
3244 2014-03-21  Darin Adler  <darin@apple.com>
3245
3246         Remove use of deprecatedCharacters in WebKit API tests
3247         https://bugs.webkit.org/show_bug.cgi?id=130602
3248
3249         Reviewed by Antti Koivisto.
3250
3251         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3252         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3253         (TestWebKitAPI::expectEmpty): Use characters8.
3254         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3255
3256         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3257         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3258         the deprecatedCharacters function itself, which we are about to delete.
3259
3260 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3261
3262         [webkitpy] Fix has_valid_reviewer()
3263         https://bugs.webkit.org/show_bug.cgi?id=130589
3264
3265         Reviewed by Csaba Osztrogonác.
3266
3267         * Scripts/webkitpy/common/checkout/changelog.py:
3268         (ChangeLogEntry.has_valid_reviewer):
3269         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3270         (test_has_valid_reviewer):
3271         * Scripts/webkitpy/common/config/committers.py:
3272         (CommitterList._reviewer_only):
3273         (CommitterList.committer_by_name):
3274         (CommitterList.reviewer_by_email):
3275         (CommitterList):
3276         (CommitterList.reviewer_by_name):
3277
3278 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3279
3280         Add cache support for jhbuild
3281         https://bugs.webkit.org/show_bug.cgi?id=130588
3282
3283         Reviewed by Csaba Osztrogonác.
3284
3285         * jhbuild/jhbuildrc_common.py:
3286         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3287
3288 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3289
3290         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3291         https://bugs.webkit.org/show_bug.cgi?id=130504
3292
3293         Reviewed by Martin Robinson.
3294
3295         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3296         CMake if not specified.
3297         * Scripts/webkitdirs.pm:
3298         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3299         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3300
3301 2014-03-21  Andreas Kling  <akling@apple.com>
3302
3303         RetainPtr API test should use CFArray instead of CFString for testing.
3304         <rdar://problem/16384899>
3305
3306         Unreviewed bot fix.
3307
3308         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3309         (TestWebKitAPI::TEST):
3310         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3311         (TestWebKitAPI::TEST):
3312
3313 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3314
3315         Move to using std::unique_ptr for EFL objects.
3316         https://bugs.webkit.org/show_bug.cgi?id=129853
3317
3318         Reviewed by Gyuyoung Kim.
3319
3320         EflUniquePtr is a template alias of std::unique_ptr
3321         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3322         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3323
3324         * DumpRenderTree/efl/DumpRenderTree.cpp:
3325         (main):
3326         * ImageDiff/efl/ImageDiff.cpp:
3327         (initEfl):
3328         (main):
3329
3330 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3331
3332         Unreviewed buildfix after r165983 for non Cocoa platforms
3333
3334         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3335
3336         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3337         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3338         * WebKitTestRunner/TestController.cpp:
3339
3340 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3341
3342         [GTK][CMake] Add support for building with Clang
3343         https://bugs.webkit.org/show_bug.cgi?id=130260
3344
3345         Reviewed by Martin Robinson.
3346
3347         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3348         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3349         included GTest framework headers.
3350         * gtk/generate-gtkdoc:
3351         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3352         in case of using Clang since that is now set by the CMake rule.
3353
3354 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3355
3356         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3357         https://bugs.webkit.org/show_bug.cgi?id=130476
3358
3359         Reviewed by Anders Carlsson.
3360         
3361         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3362
3363         * MiniBrowser/mac/WK1BrowserWindowController.m:
3364         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3365         Remove log.
3366         * MiniBrowser/mac/WK2BrowserWindowController.m:
3367         (-[WK2BrowserWindowController awakeFromNib]):
3368         (-[WK2BrowserWindowController validateMenuItem:]):
3369         (-[WK2BrowserWindowController reload:]):
3370         Hook up reload.
3371         (-[WK2BrowserWindowController toggleZoomMode:]):
3372         (-[WK2BrowserWindowController resetZoom:]):
3373         (-[WK2BrowserWindowController canResetZoom]):
3374         (-[WK2BrowserWindowController currentZoomFactor]):
3375         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3376         (-[WK2BrowserWindowController canZoomIn]):
3377         (-[WK2BrowserWindowController canZoomOut]):
3378
3379 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3380
3381         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3382         https://bugs.webkit.org/show_bug.cgi?id=130463
3383
3384         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3385
3386 2014-03-18  Samuel White  <samuel_white@apple.com>
3387
3388         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3389         https://bugs.webkit.org/show_bug.cgi?id=130250
3390
3391         Reviewed by Chris Fleizach.
3392
3393         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3394
3395         * DumpRenderTree/AccessibilityController.cpp:
3396         (enableEnhancedAccessibilityCallback):
3397         (getEnhancedAccessibilityEnabledCallback):
3398         (AccessibilityController::getJSClass):
3399         * DumpRenderTree/AccessibilityController.h:
3400         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3401         (AccessibilityController::enableEnhancedAccessibility):
3402         (AccessibilityController::enhancedAccessibilityEnabled):
3403         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3404         (AccessibilityController::enableEnhancedAccessibility):
3405         (AccessibilityController::enhancedAccessibilityEnabled):
3406         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3407         (AccessibilityController::enableEnhancedAccessibility):
3408         (AccessibilityController::enhancedAccessibilityEnabled):
3409         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3410         (AccessibilityController::enableEnhancedAccessibility):
3411         (AccessibilityController::enhancedAccessibilityEnabled):
3412         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3413         (WTR::AccessibilityController::enableEnhancedAccessibility):
3414         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3415         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3416         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3417
3418 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3419
3420         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3421         yet).
3422
3423         * Scripts/webkitpy/common/config/contributors.json:
3424
3425 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3426
3427         Web Inspector: Remove stale ReportMemoryUsagePlugin
3428         https://bugs.webkit.org/show_bug.cgi?id=130405
3429
3430         Reviewed by Andreas Kling.
3431
3432         This clang plugin looks like it was used for the old Inspector memory
3433         instrumentation that was removed. So the tool can be removed.
3434
3435         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3436         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3437         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3438         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3439
3440 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3441
3442         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3443         https://bugs.webkit.org/show_bug.cgi?id=130220
3444
3445         Reviewed by Csaba Osztrogonác.
3446
3447         * Scripts/webkitpy/common/checkout/changelog.py:
3448         (ChangeLog.set_reviewer):
3449         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3450         (test_set_reviewer):
3451
3452 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3453
3454         More FTL enabling.
3455
3456         Rubber stamped by Dan Bernstein.
3457
3458         * Tools/Scripts/build-webkit:
3459
3460 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3461
3462         Renable pagination mode in WK2 MiniBrowser
3463         https://bugs.webkit.org/show_bug.cgi?id=130374
3464
3465         Reviewed by Anders Carlsson.
3466         
3467         Put the implementation of togglePaginationMode: back, and correctly
3468         enable the menu item.
3469
3470         * MiniBrowser/mac/WK2BrowserWindowController.m:
3471         (-[WK2BrowserWindowController validateMenuItem:]):
3472         (-[WK2BrowserWindowController isPaginated]):
3473         (-[WK2BrowserWindowController togglePaginationMode:]):
3474
3475 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3476
3477         Add --reset option to Tools/Scripts/set-webkit-configuration script
3478         https://bugs.webkit.org/show_bug.cgi?id=130401
3479
3480         Reviewed by Csaba Osztrogonác.
3481
3482         * Scripts/set-webkit-configuration:
3483
3484 2014-03-18  Alberto Garcia  <berto@igalia.com>
3485
3486         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3487         https://bugs.webkit.org/show_bug.cgi?id=130388
3488
3489         Reviewed by Sergio Villar Senin.
3490
3491         * Scripts/webkitdirs.pm:
3492         (shouldRemoveCMakeCache): make sure that the build directory
3493         exists before attempting to create a file in it.
3494
3495 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3496
3497         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3498         https://bugs.webkit.org/show_bug.cgi?id=130336
3499
3500         Reviewed by Gyuyoung Kim.
3501
3502         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3503         requires a space between literal and string macro [-Wliteral-suffix]'
3504         warning treated as error.
3505
3506         This patch applies a solution from r162448 to the EFL port.
3507
3508         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3509         * efl/jhbuild.modules: Added appropriate patch section.
3510
3511 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3512
3513         webkitpy test rebaseline.
3514
3515         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3516         (MainTest.test_default_args):
3517
3518 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3519
3520         --profile should imply --test-runner-count=1 in run-perf-tests
3521         https://bugs.webkit.org/show_bug.cgi?id=130375
3522
3523         Reviewed by Benjamin Poulain.
3524
3525         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3526
3527         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3528         (PerfTestsRunner._parse_args): Use -1 as the default value.
3529         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3530         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3531         should be 1.
3532
3533 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3534
3535         Address some style nits.
3536
3537         * MiniBrowser/mac/WK2BrowserWindowController.m:
3538
3539 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3540
3541         Add transparent window support back into MiniBrowser
3542         https://bugs.webkit.org/show_bug.cgi?id=130363
3543
3544         Reviewed by Anders Carlsson.
3545         
3546         Re-enable transparent window support for WK2.
3547
3548         * MiniBrowser/mac/WK2BrowserWindowController.m:
3549         (-[WK2BrowserWindowController validateMenuItem:]):
3550         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3551
3552 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3553
3554         Fix the 32-bit build; make the open panel make a WK1 window.
3555
3556         * MiniBrowser/mac/AppDelegate.m:
3557         (-[BrowserAppDelegate openDocument:]):
3558
3559 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3560
3561         Convert MiniBrowser to use WKWebView API
3562         https://bugs.webkit.org/show_bug.cgi?id=130061
3563
3564         Reviewed by Anders Carlsson.
3565         
3566         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3567         as possible.
3568         
3569         Some functionality was removed temporarily:
3570             - text zoom, page zoom
3571             - reload
3572             - pagination mode
3573             - transparent window
3574             - dumping source
3575             - window.open support
3576             - beforeUnload panel
3577             - find in page
3578
3579         * MiniBrowser/mac/AppDelegate.h:
3580         * MiniBrowser/mac/AppDelegate.m:
3581         (-[BrowserAppDelegate init]):
3582         (-[BrowserAppDelegate newWindow:]):
3583         (-[BrowserAppDelegate applicationWillTerminate:]):
3584         (-[BrowserAppDelegate openDocument:]):
3585         * MiniBrowser/mac/WK2BrowserWindowController.h:
3586         * MiniBrowser/mac/WK2BrowserWindowController.m:
3587         (-[WK2BrowserWindowController awakeFromNib]):
3588         (-[WK2BrowserWindowController dealloc]):
3589         (-[WK2BrowserWindowController fetch:]):
3590         (-[WK2BrowserWindowController validateMenuItem:]):
3591         (-[WK2BrowserWindowController reload:]):
3592         (-[WK2BrowserWindowController goBack:]):
3593         (-[WK2BrowserWindowController goForward:]):
3594         (-[WK2BrowserWindowController toggleZoomMode:]):
3595         (-[WK2BrowserWindowController resetZoom:]):
3596         (-[WK2BrowserWindowController canResetZoom]):
3597         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3598         (-[WK2BrowserWindowController togglePaginationMode:]):
3599         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3600         (-[WK2BrowserWindowController windowShouldClose:]):
3601         (-[WK2BrowserWindowController applicationTerminating]):
3602         (-[WK2BrowserWindowController currentZoomFactor]):
3603         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3604         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3605         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3606         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3607         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3608         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3609         (-[WK2BrowserWindowController find:]):
3610         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3611         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3612         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3613         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3614         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3615         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3616         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3617         * WebKitTestRunner/PlatformWebView.h:
3618         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3619         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3620
3621 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3622
3623         Use RunLoop objects through references instead of pointers
3624         https://bugs.webkit.org/show_bug.cgi?id=130313
3625
3626         Reviewed by Andreas Kling.
3627
3628         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3629         return RunLoop reference instead of a pointer.
3630
3631         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3632         (loadedCallback):
3633         (clickedCallback):
3634
3635 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3636
3637         sort-export-file --help doesn't work (missing 'use')
3638         https://bugs.webkit.org/show_bug.cgi?id=130338
3639
3640         Reviewed by Anders Carlsson.
3641
3642         * Scripts/sort-export-file:
3643         Add a missing 'use', and fix a typo in an error message.
3644
3645 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3646
3647         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3648         https://bugs.webkit.org/show_bug.cgi?id=130155
3649
3650         Reviewed by Philippe Normand.
3651
3652         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3653
3654 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3655
3656         [GTK] MiniBrowser fails to load injected bundle lib
3657         https://bugs.webkit.org/show_bug.cgi?id=130332
3658
3659         Reviewed by Anders Carlsson.
3660
3661         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3662
3663         * MiniBrowser/gtk/main.c:
3664         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3665         process is spawn.
3666
3667 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3668
3669         [EFL] Enable TOUCH_SLIDER macro
3670         https://bugs.webkit.org/show_bug.cgi?id=130185
3671
3672         Reviewed by Gyuyoung Kim.
3673
3674         * Scripts/webkitperl/FeatureList.pm:
3675
3676 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3677
3678         [GTK][CMake] Build with -fno-rtti
3679         https://bugs.webkit.org/show_bug.cgi?id=130261
3680
3681         Reviewed by Martin Robinson.
3682
3683         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3684         defined to 0 to prevent typeid use in included GTest headers.
3685
3686 2014-03-16  Brian Burg  <bburg@apple.com>
3687
3688         Web Inspector: vended backend commands file should be generated as part of the build
3689         https://bugs.webkit.org/show_bug.cgi?id=130110
3690
3691         Reviewed by Timothy Hatcher.
3692
3693         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3694
3695 2014-03-16  Diego Pino García  <dpino@igalia.com>
3696
3697         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3698         https://bugs.webkit.org/show_bug.cgi?id=128999
3699
3700         Reviewed by Philippe Normand.
3701
3702         * MiniBrowser/gtk/BrowserWindow.c:
3703         (reloadPage):
3704         (reloadPageIgnoringCache):
3705         (browser_window_init):
3706
3707 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3708
3709         [GTK] Improve ninja detection in webkitdirs.pm
3710         https://bugs.webkit.org/show_bug.cgi?id=129902
3711
3712         Reviewed by Daniel Bates.
3713
3714         * Scripts/webkitdirs.pm:
3715         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3716         us to look for ninja-build as well.
3717
3718 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3719
3720         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3721         https://bugs.webkit.org/show_bug.cgi?id=130276
3722         <rdar://problem/16266927>
3723         
3724         Reviewed by Simon Fraser.
3725
3726         * BuildSlaveSupport/build-launcher-app:
3727         * BuildSlaveSupport/build-launcher-dmg:
3728         * DumpRenderTree/DumpRenderTree.h:
3729         * DumpRenderTree/DumpRenderTreePrefix.h:
3730         * DumpRenderTree/GCController.cpp:
3731         * DumpRenderTree/GCController.h:
3732         * DumpRenderTree/JavaScriptThreading.cpp:
3733         * DumpRenderTree/JavaScriptThreading.h:
3734         * DumpRenderTree/PixelDumpSupport.cpp:
3735         * DumpRenderTree/PixelDumpSupport.h:
3736         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3737         * DumpRenderTree/TestRunner.cpp:
3738         * DumpRenderTree/TestRunner.h:
3739         * DumpRenderTree/WorkQueue.cpp:
3740         * DumpRenderTree/WorkQueue.h:
3741         * DumpRenderTree/WorkQueueItem.h:
3742         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3743         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3744         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3745         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3746         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3747         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3748         * DumpRenderTree/efl/EditingCallbacks.cpp:
3749         * DumpRenderTree/efl/EditingCallbacks.h:
3750         * DumpRenderTree/efl/EventSender.cpp:
3751         * DumpRenderTree/efl/EventSender.h:
3752         * DumpRenderTree/efl/GCControllerEfl.cpp:
3753         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3754         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3755         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3756         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3757         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3758         * DumpRenderTree/gtk/EditingCallbacks.h:
3759         * DumpRenderTree/gtk/EventSender.cpp:
3760         * DumpRenderTree/gtk/EventSender.h:
3761         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3762         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3763         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3764         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3765         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3766         * DumpRenderTree/gtk/TextInputController.cpp:
3767         * DumpRenderTree/gtk/TextInputController.h:
3768         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3769         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3770         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3771         * DumpRenderTree/mac/AppleScriptController.h:
3772         * DumpRenderTree/mac/AppleScriptController.m:
3773         * DumpRenderTree/mac/CheckedMalloc.cpp:
3774         * DumpRenderTree/mac/CheckedMalloc.h:
3775         * DumpRenderTree/mac/DumpRenderTree.mm:
3776         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3777         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3778         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3779         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3780         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3781         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3782         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3783         * DumpRenderTree/mac/EditingDelegate.h:
3784         * DumpRenderTree/mac/EditingDelegate.mm:
3785         * DumpRenderTree/mac/EventSendingController.h:
3786         * DumpRenderTree/mac/EventSendingController.mm:
3787         * DumpRenderTree/mac/FrameLoadDelegate.h:
3788         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3789         * DumpRenderTree/mac/GCControllerMac.mm:
3790         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3791         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3792         * DumpRenderTree/mac/NavigationController.h:
3793         * DumpRenderTree/mac/NavigationController.m:
3794         * DumpRenderTree/mac/ObjCController.h:
3795         * DumpRenderTree/mac/ObjCController.m:
3796         * DumpRenderTree/mac/ObjCPlugin.h:
3797         * DumpRenderTree/mac/ObjCPlugin.m:
3798         * DumpRenderTree/mac/ObjCPluginFunction.h:
3799         * DumpRenderTree/mac/ObjCPluginFunction.m:
3800         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3801         * DumpRenderTree/mac/PolicyDelegate.h:
3802         * DumpRenderTree/mac/PolicyDelegate.mm:
3803         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3804         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3805         * DumpRenderTree/mac/TestRunnerMac.mm:
3806         * DumpRenderTree/mac/TextInputController.h:
3807         * DumpRenderTree/mac/TextInputController.m:
3808         * DumpRenderTree/mac/UIDelegate.h:
3809         * DumpRenderTree/mac/UIDelegate.mm:
3810         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3811         * DumpRenderTree/win/DRTDataObject.cpp:
3812         * DumpRenderTree/win/DRTDataObject.h:
3813         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3814         * DumpRenderTree/win/DRTDropSource.cpp:
3815         * DumpRenderTree/win/DRTDropSource.h:
3816         * DumpRenderTree/win/DraggingInfo.h:
3817         * DumpRenderTree/win/DumpRenderTree.cpp:
3818         * DumpRenderTree/win/DumpRenderTreeWin.h:
3819         * DumpRenderTree/win/EditingDelegate.cpp:
3820         * DumpRenderTree/win/EditingDelegate.h:
3821         * DumpRenderTree/win/EventSender.cpp:
3822         * DumpRenderTree/win/EventSender.h:
3823         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3824         * DumpRenderTree/win/FrameLoadDelegate.h:
3825         * DumpRenderTree/win/GCControllerWin.cpp:
3826         * DumpRenderTree/win/HistoryDelegate.cpp:
3827         * DumpRenderTree/win/HistoryDelegate.h:
3828         * DumpRenderTree/win/MD5.cpp:
3829         * DumpRenderTree/win/MD5.h:
3830         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3831         * DumpRenderTree/win/PolicyDelegate.cpp:
3832         * DumpRenderTree/win/PolicyDelegate.h:
3833         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3834         * DumpRenderTree/win/ResourceLoadDelegate.h:
3835         * DumpRenderTree/win/TestRunnerWin.cpp:
3836         * DumpRenderTree/win/TextInputController.cpp:
3837         * DumpRenderTree/win/TextInputController.h:
3838         * DumpRenderTree/win/TextInputControllerWin.cpp:
3839         * DumpRenderTree/win/UIDelegate.cpp:
3840         * DumpRenderTree/win/UIDelegate.h:
3841         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3842         * EWebLauncher/main.c:
3843         * GtkLauncher/main.c:
3844         * ImageDiff/efl/ImageDiff.cpp:
3845         * ImageDiff/gtk/ImageDiff.cpp:
3846         * MiniBrowser/gtk/main.c:
3847         * Scripts/SpacingHeuristics.pm:
3848         * Scripts/VCSUtils.pm:
3849         * Scripts/bisect-builds:
3850         * Scripts/build-dumprendertree:
3851         * Scripts/build-jsc:
3852         * Scripts/build-webkit:
3853         * Scripts/check-dom-results:
3854         * Scripts/check-for-exit-time-destructors:
3855         * Scripts/check-for-global-initializers:
3856         * Scripts/commit-log-editor:
3857         * Scripts/compare-timing-files:
3858         * Scripts/debug-minibrowser:
3859         * Scripts/debug-safari:
3860         * Scripts/do-file-rename:
3861         * Scripts/find-extra-includes:
3862         * Scripts/generate-coverage-data:
3863         * Scripts/make-script-test-wrappers:
3864         * Scripts/malloc-tree:
3865         * Scripts/old-run-webkit-tests:
3866         * Scripts/parse-malloc-history:
3867         * Scripts/report-include-statistics:
3868         * Scripts/resolve-ChangeLogs:
3869         * Scripts/run-bindings-tests:
3870         * Scripts/run-iexploder-tests:
3871         * Scripts/run-javascriptcore-tests:
3872         * Scripts/run-jsc:
3873         * Scripts/run-launcher:
3874         * Scripts/run-leaks:
3875         * Scripts/run-mangleme-tests:
3876         * Scripts/run-minibrowser:
3877         * Scripts/run-pageloadtest:
3878         * Scripts/run-regexp-tests:
3879         * Scripts/run-safari:
3880         * Scripts/run-sunspider:
3881         * Scripts/run-webkit-app:
3882         * Scripts/sampstat:
3883         * Scripts/set-webkit-configuration:
3884         * Scripts/sort-Xcode-project-file:
3885         * Scripts/sort-export-file:
3886         * Scripts/split-file-by-class:
3887         * Scripts/sunspider-compare-results:
3888         * Scripts/svn-apply:
3889         * Scripts/svn-create-patch:
3890         * Scripts/svn-unapply:
3891         * Scripts/test-webkit-scripts:
3892         * Scripts/update-javascriptcore-test-results:
3893         * Scripts/update-webkit:
3894         * Scripts/update-webkit-auxiliary-libs:
3895         * Scripts/update-webkit-dependency:
3896         * Scripts/update-webkit-localizable-strings:
3897         * Scripts/update-webkit-support-libs:
3898         * Scripts/update-webkit-wincairo-libs:
3899         * Scripts/webkit-build-directory:
3900         * Scripts/webkitdirs.pm:
3901         (installedSafariPath):
3902         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3903         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3904         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3905         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3906         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3907         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3908         * Scripts/webkitperl/features.pm:
3909         * Scripts/webkitperl/httpd.pm:
3910         * Scripts/webkitpy/bindings/main.py:
3911         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3912         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3913         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3914         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3915         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3916         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3917         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3918         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3919         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3920         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3921         * WebKitTestRunner/PixelDumpSupport.cpp:
3922         * WebKitTestRunner/PixelDumpSupport.h:
3923         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3924         * WinLauncher/WinLauncher.cpp:
3925         * WinLauncher/WinLauncher.h:
3926         * WinLauncher/stdafx.cpp:
3927         * WinLauncher/stdafx.h:
3928
3929 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3930
3931         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3932         https://bugs.webkit.org/show_bug.cgi?id=130265
3933
3934         Reviewed by Michael Saboff.
3935
3936         * Scripts/build-webkit:
3937         * Scripts/copy-webkitlibraries-to-product-directory:
3938
3939 2014-03-14  Landry Breuil  <landry@openbsd.org>
3940
3941         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3942         Also allow to set MAKE in the environment.
3943         https://bugs.webkit.org/show_bug.cgi?id=129991
3944
3945         Reviewed by Andreas Kling.
3946
3947         * Scripts/webkitdirs.pm:
3948         (determineArchitecture):
3949         (determineNumberOfCPUs):
3950         (isBSD):
3951         (buildAutotoolsProject):
3952         * Scripts/webkitpy/common/system/platforminfo.py:
3953         (PlatformInfo.__init__):
3954         (PlatformInfo.is_openbsd):
3955         (PlatformInfo):
3956         (PlatformInfo.is_netbsd):
3957         (PlatformInfo._determine_os_name):
3958
3959 2014-03-14  Dean Jackson  <dino@apple.com>
3960
3961         Remove libWebKitSystemInterfaceLion.a
3962         https://bugs.webkit.org/show_bug.cgi?id=130254
3963
3964         Reviewed by Geoffrey Garen and Andreas Kling.
3965
3966         No need to copy the Lion libraries into the build.
3967
3968         * Scripts/copy-webkitlibraries-to-product-directory:
3969
3970 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3971
3972         [EFL][MiniBrowser] Revise help messages of command line parameters
3973         https://bugs.webkit.org/show_bug.cgi?id=130222
3974
3975         Reviewed by Csaba Osztrogonác.
3976
3977         Correct the default value description and make help messages to be consistent.
3978
3979         * MiniBrowser/efl/main.c:
3980
3981 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3982
3983         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3984         https://bugs.webkit.org/show_bug.cgi?id=129612
3985
3986         Reviewed by Darin Adler.
3987
3988         For new code use static NeverDestroyed<T> instead.
3989
3990         * DumpRenderTree/JavaScriptThreading.cpp:
3991         (javaScriptThreadsMutex):
3992         (javaScriptThreads):
3993         * DumpRenderTree/efl/EventSender.cpp:
3994         (touchPointList):
3995         (delayedEventQueue):
3996         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3997         (delegatesWithDelayedWork):
3998         * Scripts/check-for-exit-time-destructors:
3999         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
4000         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
4001         (testsMap):
4002
4003 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
4004
4005         [EFL][WK2] Fix compilation warning in Minibrowser
4006         https://bugs.webkit.org/show_bug.cgi?id=130132
4007
4008         Reviewed by Csaba Osztrogonác.
4009
4010         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
4011
4012         * MiniBrowser/efl/main.c:
4013         (on_download_request):
4014
4015 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
4016
4017         FTL should support IsBlah
4018         https://bugs.webkit.org/show_bug.cgi?id=130202
4019
4020         Reviewed by Geoffrey Garen.
4021         
4022         Running existing JSRegress tests with noInline gives us coverage for these
4023         changes. Chances are, this will also give coverage for other interesting things
4024         as well.
4025
4026         * Scripts/run-jsc-stress-tests:
4027
4028 2014-03-12  Brian Burg  <bburg@apple.com>
4029
4030         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
4031         https://bugs.webkit.org/show_bug.cgi?id=129744
4032
4033         Reviewed by Timothy Hatcher.
4034
4035         * DumpRenderTree/TestRunner.cpp:
4036         (evaluateInWebInspectorCallback):
4037         * DumpRenderTree/TestRunner.h:
4038         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4039         (TestRunner::evaluateInWebInspector):
4040         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4041         (TestRunner::evaluateInWebInspector):
4042         * DumpRenderTree/mac/TestRunnerMac.mm:
4043         (TestRunner::evaluateInWebInspector):
4044         * DumpRenderTree/win/TestRunnerWin.cpp:
4045         (TestRunner::evaluateInWebInspector):
4046         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4048         (WTR::TestRunner::evaluateInWebInspector):
4049         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4050
4051 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4052
4053         [GTK] build-webkit shouldn't show error message when ninja isn't installed
4054         https://bugs.webkit.org/show_bug.cgi?id=130129
4055
4056         Reviewed by Csaba Osztrogonác.
4057
4058         * Scripts/webkitdirs.pm:
4059         (canUseNinja): Redirecting stderr to /dev/null
4060
4061 2014-03-13  Andres Gomez  <agomez@igalia.com>
4062
4063         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
4064         https://bugs.webkit.org/show_bug.cgi?id=130092
4065
4066         Reviewed by Csaba Osztrogonác.
4067
4068         Added "python-dev" as dependency for deb based distros. It is
4069         already present for rpm based distros. This dependency will allow
4070         libxml2 to generate its python bindings, needed by gtk-doc.
4071
4072         * gtk/install-dependencies:
4073
4074 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4075
4076         Unreviewed. Fix GTK+ cmake build after r165488.
4077
4078         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
4079
4080 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4081
4082         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
4083         https://bugs.webkit.org/show_bug.cgi?id=130014
4084
4085         Reviewed by Martin Robinson.
4086
4087         Include cmake or autotools config header.
4088
4089         * MiniBrowser/gtk/BrowserDownloadsBar.c:
4090         * MiniBrowser/gtk/BrowserSearchBar.c:
4091         * MiniBrowser/gtk/BrowserWindow.c:
4092         * MiniBrowser/gtk/main.c:
4093
4094 2014-03-12  Commit Queue  <commit-queue@webkit.org>
4095
4096         Unreviewed, rolling out r165471.
4097         https://bugs.webkit.org/show_bug.cgi?id=130139
4098
4099         Didn't really fix the issue and broke another bot (Requested
4100         by mrobinson on #webkit).
4101
4102         Reverted changeset:
4103
4104         "[CMake] Newer versions of CMake cannot find older versions of
4105         Freetype"
4106         https://bugs.webkit.org/show_bug.cgi?id=130107
4107         http://trac.webkit.org/changeset/165471
4108
4109 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
4110
4111         It should be possible to build WebKit with FTL on iOS
4112         https://bugs.webkit.org/show_bug.cgi?id=130116
4113
4114         Reviewed by Dan Bernstein.
4115
4116         * Scripts/build-webkit:
4117         * Scripts/copy-webkitlibraries-to-product-directory:
4118
4119 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
4120
4121         [Win] Remove use of QTSDK
4122         https://bugs.webkit.org/show_bug.cgi?id=130049
4123
4124         Reviewed by Darin Adler.
4125
4126         * DumpRenderTree/win/DumpRenderTree.cpp:
4127         (initialize): Remove QuickTime code.
4128         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
4129         building QTMovieWin.
4130
4131 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
4132
4133         [GTK][CMAKE] Too verbose build output
4134         https://bugs.webkit.org/show_bug.cgi?id=130076
4135
4136         Reviewed by Carlos Garcia Campos.
4137
4138         Instead of building with cmake --build which isn't smart about pretty printing and
4139         colors, we build with a script which calls the proper build command.
4140
4141         * Scripts/webkitdirs.pm:
4142         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
4143         the CMake configuration pass.
4144
4145 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
4146
4147         [CMake] Newer versions of CMake cannot find older versions of Freetype
4148         https://bugs.webkit.org/show_bug.cgi?id=130107
4149
4150         Reviewed by Gustavo Noronha Silva.
4151
4152         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
4153         to CMake during jhbuild initialization.
4154
4155 2014-03-12  Zalan Bujtas  <zalan@apple.com>
4156
4157         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
4158         https://bugs.webkit.org/show_bug.cgi?id=129961
4159
4160         Reviewed by Simon Fraser.
4161
4162         Now scaled content can go through the window capturing mechanism too for compositing content.
4163         AppleMagnifiedMode is redundant.
4164
4165         * DumpRenderTree/mac/DumpRenderTree.mm:
4166         (setDefaultsToConsistentValuesForTesting):
4167         (runTest):
4168         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4169         (createBitmapContextFromWebView):
4170         * WebKitTestRunner/PlatformWebView.h:
4171         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4172         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4173         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4174         (WTR::PlatformWebView::didInitializeClients):
4175         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4176         (WTR::PlatformWebView::forceWindowFramesChanged):
4177         * WebKitTestRunner/mac/main.mm:
4178         (setDefaultsToConsistentValuesForTesting):
4179
4180 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
4181
4182         Unreviewed. Add myself as a committer.
4183
4184         * Scripts/webkitpy/common/config/contributors.json:
4185
4186 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
4187
4188         Unreviewed build fix on the EFL port when used lower version of ATK
4189
4190         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4191         (WTR::AccessibilityUIElement::y): Fixed typo.
4192
4193 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
4194
4195         Some images are blank in the rebaseline server UI
4196         https://bugs.webkit.org/show_bug.cgi?id=130104
4197
4198         Reviewed by Tim Horton.
4199
4200         Let the server check for images in the 'retries' directory
4201         if it can't find an image otherwise.
4202
4203         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4204         (RebaselineHTTPRequestHandler.test_result):
4205
4206 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4207
4208         [GTK][CMake] --update-gtk has no effect
4209         https://bugs.webkit.org/show_bug.cgi?id=130088
4210
4211         Reviewed by Philippe Normand.
4212
4213         * Scripts/webkitdirs.pm:
4214         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
4215         as an argument.
4216
4217 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
4218
4219         Add "System Font" to the list of whitelisted DRT fonts
4220         https://bugs.webkit.org/show_bug.cgi?id=130046
4221
4222         Reviewed by Darin Adler.
4223
4224         * DumpRenderTree/mac/DumpRenderTree.mm:
4225         (allowedFontFamilySet):
4226         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4227
4228 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
4229
4230         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
4231         https://bugs.webkit.org/show_bug.cgi?id=130064
4232
4233         Reviewed by Philippe Normand.
4234
4235         * efl/jhbuildrc: Remove duplicated code.
4236         * gtk/jhbuildrc: Remove duplicated code.
4237         * jhbuild/jhbuildrc_common.py:
4238         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
4239         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
4240         and is apparently necessary for GTK+.
4241
4242 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
4243
4244         check-webkit-style failed to complain about missing braces
4245         https://bugs.webkit.org/show_bug.cgi?id=34189
4246
4247         Reviewed by Ryosuke Niwa.
4248
4249         * Scripts/webkitpy/style/checkers/cpp.py:
4250         (check_braces):
4251         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4252         (WebKitStyleTest.test_braces):
4253
4254 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
4255
4256         Remove Qt cruft from style checker.
4257         https://bugs.webkit.org/show_bug.cgi?id=130085
4258
4259         Reviewed by Csaba Osztrogonác.
4260
4261         There is no 'foreach' keyword in c++. That was a Qt feature
4262         added in: http://trac.webkit.org/changeset/46113
4263         Qt was removed from WebKit, so we should remove the checks
4264         of this keyword from check-webkit-style scripts.
4265
4266         * Scripts/webkitpy/style/checkers/cpp.py:
4267         (check_spacing_for_function_call):
4268         (check_spacing):
4269         (check_braces):
4270         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4271         (CppStyleTest.test_mismatching_spaces_in_parens):
4272         (CppStyleTest.test_spacing_for_fncall):
4273         (WebKitStyleTest.test_braces):
4274
4275 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
4276
4277         [GTK] update-webkitgtk-libs needs itstool
4278         https://bugs.webkit.org/show_bug.cgi?id=130082
4279
4280         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
4281         itstool is a dependency of building gtk-doc from version 1.19, so it should
4282         be added to Tools/gtk/install-dependencies script, too.
4283
4284         Reviewed by Philippe Normand.
4285
4286         * gtk/install-dependencies:
4287
4288 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4289
4290         webkitbot rollout ChangeLogs should be nicer
4291         https://bugs.webkit.org/show_bug.cgi?id=122654
4292
4293         Reviewed by Csaba Osztrogonác.
4294
4295         Added bug urls and descriptions of rolled out patches to the rollout changelog
4296         if they are present in the original changelog. Additionally removed the list of
4297         changed files and functions.
4298
4299         * Scripts/webkitpy/common/checkout/changelog.py:
4300         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
4301         * Scripts/webkitpy/common/checkout/checkout.py:
4302         (Checkout._changelog_data_for_revision): Store bug description.
4303         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4304         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4305         (CheckoutTest.test_commit_info_for_revision):
4306         * Scripts/webkitpy/common/checkout/commitinfo.py:
4307         (CommitInfo.bug_description): Added.
4308         (CommitInfo.to_json):
4309         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4310         (CommitInfoTest.test_commit_info_creation):
4311         * Scripts/webkitpy/tool/commands/download.py:
4312         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
4313         out patches for creating rollout changelog.
4314         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that