[Flatpak] Second run update-webkitwpe-flatpak fails
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2
3         [Flatpak] Second run update-webkitwpe-flatpak fails
4         https://bugs.webkit.org/show_bug.cgi?id=192702
5
6         Reviewed by Carlos Garcia Campos.
7
8         * flatpak/flatpakutils.py:
9         (FlatpakObject.flatpak): Fix typo.
10         (FlatpakPackage.install): When installing, also update to the configured remote commit.
11         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
12
13 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
14
15         [GTK][WPE] outlook.live.com displays old-fashioned UI
16         https://bugs.webkit.org/show_bug.cgi?id=196642
17
18         Reviewed by Carlos Garcia Campos.
19
20         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
21         (TestWebKitAPI::TEST): New Mac platform quirk test.
22
23 2019-04-07  Commit Queue  <commit-queue@webkit.org>
24
25         Unreviewed, rolling out r243956.
26         https://bugs.webkit.org/show_bug.cgi?id=196688
27
28         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
29         by aakashjain on #webkit).
30
31         Reverted changeset:
32
33         "Clicking "Go Back" from a safe browsing warning from an
34         iframe should navigate the WKWebView back to the previous
35         page"
36         https://bugs.webkit.org/show_bug.cgi?id=196665
37         https://trac.webkit.org/changeset/243956
38
39 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
40
41         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
42         https://bugs.webkit.org/show_bug.cgi?id=196669
43
44         Reviewed by Geoffrey Garen.
45
46         Added three new unit tests for WeakHashSet.
47
48         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
49         (WTF_WeakPtr.WeakHashSetConstObjects):
50         (WTF_WeakPtr.WeakHashSetComputesEmpty):
51         (WTF_WeakPtr.WeakHashSetComputeSize):
52
53 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
54
55         Hide next and previous form control buttons when WKWebView is editable
56         https://bugs.webkit.org/show_bug.cgi?id=196672
57         <rdar://problem/35625321>
58
59         Reviewed by Tim Horton.
60
61         Add a new API test.
62
63         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
64         (-[TestWKWebView lastTrailingBarButtonGroup]):
65         (TestWebKitAPI::TEST):
66         * TestWebKitAPI/ios/UIKitSPI.h:
67
68 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
69
70         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
71         https://bugs.webkit.org/show_bug.cgi?id=196077
72         <rdar://problem/49108202>
73
74         Reviewed by Chris Dumez.
75
76         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
77         on new web view.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
80
81 2019-04-05  Saam Barati  <sbarati@apple.com>
82
83         Make compare-results understand MotionMark
84         https://bugs.webkit.org/show_bug.cgi?id=196666
85
86         Reviewed by Yusuke Suzuki.
87
88         * Scripts/compare-results:
89         (PLT5Results):
90         (detectMotionMark):
91         (detectMotionMark1_1):
92         (motionMarkResults):
93         (motionMark1_1Results):
94         (detectBenchmark):
95         (biggerIsBetter):
96         (main):
97
98 2019-04-05  Alex Christensen  <achristensen@webkit.org>
99
100         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
101         https://bugs.webkit.org/show_bug.cgi?id=196665
102         <rdar://45115669>
103
104         Reviewed by Geoff Garen.
105
106         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
107         (goBack):
108         (+[SimpleLookupContext sharedLookupContext]):
109         (-[SimpleLookupContext lookUpURL:completionHandler:]):
110         (TEST):
111         (+[Simple3LookupContext sharedLookupContext]): Deleted.
112         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
113
114 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
115
116         [ews-build] Add configuration and architecture for windows builders
117         https://bugs.webkit.org/show_bug.cgi?id=196660
118
119         Reviewed by Lucas Forschler.
120
121         * BuildSlaveSupport/ews-build/config.json:
122
123 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
124
125         webkitpy: Don't run subsequent rounds if interrupted
126         https://bugs.webkit.org/show_bug.cgi?id=196646
127
128         Reviewed by Aakash Jain.
129
130         * Scripts/webkitpy/layout_tests/controllers/manager.py:
131         (Manager.run): Bail out if interrupted.
132
133 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
134
135         Test sessionStorage in PSON private browsing mode
136         https://bugs.webkit.org/show_bug.cgi?id=196561
137
138         Reviewed by Alex Christensen.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
141
142 2019-04-05  Commit Queue  <commit-queue@webkit.org>
143
144         Unreviewed, rolling out r243833.
145         https://bugs.webkit.org/show_bug.cgi?id=196645
146
147         This change breaks build of WPE and GTK ports (Requested by
148         annulen on #webkit).
149
150         Reverted changeset:
151
152         "[CMake][WTF] Mirror XCode header directories"
153         https://bugs.webkit.org/show_bug.cgi?id=191662
154         https://trac.webkit.org/changeset/243833
155
156 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
157
158         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
159         https://bugs.webkit.org/show_bug.cgi?id=196635
160
161         Reviewed by Antti Koivisto.
162         
163         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
164         for a test to enable async frame scrolling via:
165             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
166         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
167         
168         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
169
170         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
171         (WTR::InjectedBundle::beginTesting):
172         * WebKitTestRunner/TestController.cpp:
173         (WTR::TestController::resetPreferencesToConsistentValues):
174
175 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
176
177         Use a correct LC_RPATH when building with ASan
178         https://bugs.webkit.org/show_bug.cgi?id=196576
179
180         Reviewed by David Kilzer.
181
182         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
183         so that ../Frameworks is checked. This is simpler and more reliable than updating
184         each SPC service xcconfig.
185
186 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
187
188         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
189         https://bugs.webkit.org/show_bug.cgi?id=196629
190
191         Reviewed by Lucas Forschler.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
194
195 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
196
197         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
198         https://bugs.webkit.org/show_bug.cgi?id=196618
199
200         Reviewed by Lucas Forschler.
201
202         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
203         (StatusBubble): Added QUEUE_TRIGGERS.
204         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
205         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
206         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
207         its parent(builder).
208
209 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
210
211         [ews-app] Status-bubble steps are sometimes displayed in reverse order
212         https://bugs.webkit.org/show_bug.cgi?id=196625
213
214         Reviewed by Lucas Forschler.
215
216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
217         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
218
219 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
220
221         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
222         https://bugs.webkit.org/show_bug.cgi?id=196630
223
224         Reviewed by Wenson Hsieh.
225
226         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
227
228 2019-04-04  Youenn Fablet  <youenn@apple.com>
229
230         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
231         https://bugs.webkit.org/show_bug.cgi?id=196543
232
233         Reviewed by Alex Christensen.
234
235         * WebKitTestRunner/TestController.cpp:
236         (WTR::TestController::generatePageConfiguration):
237
238 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
239
240         [ews-app] Status bubble should not display skipped buildbot steps
241         https://bugs.webkit.org/show_bug.cgi?id=196584
242
243         Reviewed by Lucas Forschler.
244
245         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
246
247 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
248
249         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
250         https://bugs.webkit.org/show_bug.cgi?id=196620
251
252         Reviewed by Lucas Forschler.
253
254         * BuildSlaveSupport/ews-app/ews/config.py:
255
256 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
257
258         [Win] DumpRenderTreeWatchDog.py is not checked into source
259         https://bugs.webkit.org/show_bug.cgi?id=196567
260         <rdar://problem/49525901>
261
262         Reviewed by Lucas Forschler.
263
264         This script is used on Win EWS bots to terminate hanging DRT processes.
265
266         * EWSTools/dumprendertreewatchdog.py: Added.
267
268 2019-04-04  Chris Dumez  <cdumez@apple.com>
269
270         Unreviewed, roll out r243858 which made tests time out.
271
272         Disable new API tests on Windows instead.
273
274         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
275         (TestWebKitAPI::TEST):
276
277 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
278
279         [ATK] Cleanup WebPageAccessibilityObjectAtk
280         https://bugs.webkit.org/show_bug.cgi?id=196537
281
282         Reviewed by Michael Catanzaro.
283
284         Also consider files under atk directories as exceptions for GObject conventions.
285
286         * Scripts/webkitpy/style/checkers/cpp.py:
287         (check_identifier_name_in_declaration):
288
289 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
290
291         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
292         https://bugs.webkit.org/show_bug.cgi?id=196588
293         <rdar://problem/49365787>
294
295         Unreviewed build fix for Windows port.
296
297         error C3861: 'kill': identifier not found
298
299         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
300         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
301
302 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
303
304         [ews-build] Cancel build and similar operations should have authentication
305         https://bugs.webkit.org/show_bug.cgi?id=196520
306
307         Reviewed by Dewei Zhu.
308
309         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
310         environment variables.
311
312 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-build] Do not trigger queues which are not in production yet
315         https://bugs.webkit.org/show_bug.cgi?id=196581
316
317         Reviewed by Dewei Zhu.
318
319         * BuildSlaveSupport/ews-build/config.json:
320
321 2019-04-03  Chris Dumez  <cdumez@apple.com>
322
323         Unreviewed, fix typo in the name of API test added in r243848.
324
325         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
326         (TestWebKitAPI::TEST):
327
328 2019-04-03  Chris Dumez  <cdumez@apple.com>
329
330         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
331         https://bugs.webkit.org/show_bug.cgi?id=196588
332         <rdar://problem/49365787>
333
334         Reviewed by Ryosuke Niwa.
335
336         Add API test coverage.
337
338         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
339         (TestWebKitAPI::nullJavaScriptCallback):
340         (TestWebKitAPI::didCrashCheckFrames):
341         (TestWebKitAPI::TEST):
342
343 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
344
345         run-webkit-tests: Upload test results (new results database)
346         https://bugs.webkit.org/show_bug.cgi?id=196577
347         <rdar://problem/34841155>
348
349         Reviewed by Lucas Forschler.
350
351         * Scripts/webkitpy/layout_tests/controllers/manager.py:
352         (Manager.run): Upload results after each device shard, since the configuration will be
353         different for each device.
354         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
355         uploaded to a results database.
356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
357         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
358
359 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
360
361         -apple-trailing-word is needed for browser detection
362         https://bugs.webkit.org/show_bug.cgi?id=196575
363
364         Unreviewed.
365
366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
367
368 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
369
370         [CMake][WTF] Mirror XCode header directories
371         https://bugs.webkit.org/show_bug.cgi?id=191662
372
373         Reviewed by Konstantin Tokarev.
374
375         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
376         builds.
377
378         * CMakeLists.txt:
379         * DumpRenderTree/CMakeLists.txt:
380         * DumpRenderTree/PlatformWin.cmake:
381         * MiniBrowser/win/CMakeLists.txt:
382         * TestWebKitAPI/CMakeLists.txt:
383         * TestWebKitAPI/PlatformWin.cmake:
384         * WebKitTestRunner/PlatformGTK.cmake:
385         * WebKitTestRunner/PlatformWin.cmake:
386
387 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
388
389         [ews-app] Status bubble should not display certain infrastructure status messages
390         https://bugs.webkit.org/show_bug.cgi?id=196550
391
392         Reviewed by Lucas Forschler.
393
394         Do not display the steps which are un-needed for end-user. This information is still avaiable
395         if the user click on the bubble and look at the Buildbot build.
396         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
397         (StatusBubble._steps_messages):
398         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
399
400 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
401
402         [ews-build] Use https for sending data to ews-app
403         https://bugs.webkit.org/show_bug.cgi?id=196492
404
405         Reviewed by Lucas Forschler.
406
407         * BuildSlaveSupport/ews-build/events.py:
408
409 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
410
411         Remove support for -apple-trailing-word
412         https://bugs.webkit.org/show_bug.cgi?id=196525
413
414         Reviewed by Zalan Bujtas.
415
416         This CSS property is nonstandard and not used.
417
418         * Scripts/webkitperl/FeatureList.pm:
419         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
420
421 2019-04-03  Youenn Fablet  <youenn@apple.com>
422
423         Add a test for DOMCache on multiple browsing in case of private browsing
424         https://bugs.webkit.org/show_bug.cgi?id=196524
425
426         Reviewed by Alex Christensen.
427
428         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
429         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
430
431 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
432
433         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
434         https://bugs.webkit.org/show_bug.cgi?id=196540
435
436         Reviewed by Aakash Jain.
437
438         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
439
440 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
441
442         Add plumbing for a compatibility mode preference in WebKit
443         https://bugs.webkit.org/show_bug.cgi?id=196005
444
445         Reviewed by Tim Horton.
446
447         Add new API tests.
448
449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
450         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
451
452 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
453
454         [WPE][GTK] Update libsrtp dependency package for Debian
455         https://bugs.webkit.org/show_bug.cgi?id=196528
456
457         Reviewed by Frédéric Wang.
458
459         * gtk/install-dependencies:
460         * wpe/install-dependencies:
461
462 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
463
464         [WK2] Add support for Window's beforeprint / afterprint events
465         https://bugs.webkit.org/show_bug.cgi?id=196478
466         <rdar://problem/49535124>
467
468         Unreviewed build fix for MSVC.
469
470         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
471
472         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
473
474         * WebKitTestRunner/TestController.cpp:
475         (WTR::printFrame): Use int and float literals.
476
477 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
478
479         [ews-build] Reassign bots to queues
480
481         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
482
483 2019-04-02  Chris Dumez  <cdumez@apple.com>
484
485         [WK2] Add support for Window's beforeprint / afterprint events
486         https://bugs.webkit.org/show_bug.cgi?id=196478
487
488         Reviewed by Alex Christensen.
489
490         Add minimal implementation for printFrame in WebKitTestRunner.
491
492         * WebKitTestRunner/TestController.cpp:
493         (WTR::printFrame):
494         (WTR::TestController::createOtherPage):
495         (WTR::TestController::createWebViewWithOptions):
496
497 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
498
499         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
500         https://bugs.webkit.org/show_bug.cgi?id=196491
501
502         Reviewed by Lucas Forschler.
503
504         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
505
506 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
507
508         [ews-build] Configure buildbot try credentials in environment variables
509         https://bugs.webkit.org/show_bug.cgi?id=196501
510
511         Reviewed by Lucas Forschler.
512
513         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
514         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
515         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
516
517 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
518
519         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
520         https://bugs.webkit.org/show_bug.cgi?id=196496
521         <rdar://problem/49521634>
522
523         Reviewed by Chris Dumez.
524
525         Add new API tests (see WebKit ChangeLog for more detail).
526
527         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
528         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
529         (TEST):
530
531 2019-04-02  David Kilzer  <ddkilzer@apple.com>
532
533         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
534         <https://webkit.org/b/196499>
535
536         Reviewed by Alexey Proskuryakov.
537
538         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
539         ENABLE_ADDRESS_SANITIZER.
540
541 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
542
543         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
544         https://bugs.webkit.org/show_bug.cgi?id=182757
545
546         Reviewed by Don Olmstead.
547
548         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
549         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
550
551 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
552
553         run-api-tests: Upload test results
554         https://bugs.webkit.org/show_bug.cgi?id=196323
555         <rdar://problem/49356714>
556
557         Reviewed by Lucas Forschler.
558
559         * Scripts/webkitpy/api_tests/manager.py:
560         (Manager):
561         (Manager.run): Upload results to a results database.
562         * Scripts/webkitpy/api_tests/run_api_tests.py:
563         (parse_args): Add upload arguments.
564         * Scripts/webkitpy/port/base.py:
565         (Port):
566         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
567         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
568         with commits from any other associated repositories.
569         * Scripts/webkitpy/port/device.py:
570         (Device):
571         (Device.build_version): Access build_versoin of underlying platform device.
572         * Scripts/webkitpy/port/ios_simulator_unittest.py:
573         (IOSSimulatorTest):
574         (IOSSimulatorTest.test_configuration_for_upload):
575         * Scripts/webkitpy/port/device_port.py:
576         (DevicePort):
577         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
578         the same as the machine uploading results.
579         * Scripts/webkitpy/port/mac.py:
580         (MacPort):
581         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
582         * Scripts/webkitpy/port/mac_unittest.py:
583         (MacTest):
584         (MacTest.test_configuration_for_upload):
585         * Scripts/webkitpy/xcode/simulated_device.py:
586         (SimulatedDeviceManager._create_device_with_runtime):
587         (SimulatedDevice.__init__): Create simulated device with a build_version.
588         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
589         (test_existing_simulator):
590
591 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
592
593         Remove extra newline characters (Follow-up fix to r243707)
594
595         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
596
597 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-app] Use API_KEY to accept results data
600         https://bugs.webkit.org/show_bug.cgi?id=196461
601
602         Reviewed by Dewei Zhu.
603
604         * BuildSlaveSupport/ews-app/ews/views/results.py:
605         (Results.post): Validate EWS_API_KEY before accepting any data.
606         * BuildSlaveSupport/ews-build/events.py:
607         (Events.sendData): Send EWS_API_KEY if available along with event data.
608
609 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
610
611         Unable to copy and paste a PDF from Notes into Mail compose body
612         https://bugs.webkit.org/show_bug.cgi?id=196442
613         <rdar://problem/48573098>
614
615         Reviewed by Tim Horton.
616
617         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
618         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
619         to be specified on the item providers.
620
621         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
622         (TestWebKitAPI::mapItemForTesting):
623         (TestWebKitAPI::contactItemForTesting):
624
625 2019-04-01  Tim Horton  <timothy_horton@apple.com>
626
627         Make UIWKDocumentContext rects per-character instead of per-word
628         https://bugs.webkit.org/show_bug.cgi?id=196459
629
630         Reviewed by Wenson Hsieh.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
633         (TEST):
634         Adjust test results due to switching to per-character rects.
635
636 2019-04-01  Chris Dumez  <cdumez@apple.com>
637
638         UIProcess crash when a prewarmed process is terminated
639         https://bugs.webkit.org/show_bug.cgi?id=196451
640         <rdar://problem/49245471>
641
642         Reviewed by Geoffrey Garen.
643
644         Add API test coverage.
645
646         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
647         (TEST):
648
649 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
650
651         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
652         https://bugs.webkit.org/show_bug.cgi?id=196449
653
654         Reviewed by Lucas Forschler.
655
656         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
657         (StatusBubble.get_os_details): Method to get OS and Xcode details.
658         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
659         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
660
661 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
662
663         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
664         https://bugs.webkit.org/show_bug.cgi?id=196444
665
666         Reviewed by Lucas Forschler.
667
668         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
669
670 2019-04-01  Alex Christensen  <achristensen@webkit.org>
671
672         Add SPI to canonicalize NSURLs with WTF::URL
673         https://bugs.webkit.org/show_bug.cgi?id=196415
674         <rdar://problem/44980271>
675
676         Reviewed by Darin Adler.
677
678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
680         (TestWebKitAPI::TEST):
681
682 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
683
684         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
685         https://bugs.webkit.org/show_bug.cgi?id=196441
686
687         Reviewed by Carlos Garcia Campos.
688
689         Don't cache the wpe_view_backend object that might not exist yet at the
690         time of EventSenderProxy constructor invocation, but instead retrieve
691         that object whenever it's required for event dispatching. This should
692         avoid crashes in this constructor now that it's invoked before any
693         PlatformWindow has been set up (as changed in r243496).
694
695         * WebKitTestRunner/EventSenderProxy.h:
696         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
697         (WTR::viewBackend):
698         (WTR::EventSenderProxy::EventSenderProxy):
699         (WTR::EventSenderProxy::mouseDown):
700         (WTR::EventSenderProxy::mouseUp):
701         (WTR::EventSenderProxy::mouseMoveTo):
702         (WTR::EventSenderProxy::mouseScrollBy):
703         (WTR::EventSenderProxy::keyDown):
704         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
705
706 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
707
708         [Win][WebKit] MiniBrowser should support high DPI display
709         https://bugs.webkit.org/show_bug.cgi?id=196391
710
711         Reviewed by Alex Christensen.
712
713         * MiniBrowser/win/WebKitBrowserWindow.cpp:
714         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
715         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
716         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
717
718 2019-03-31  Sam Weinig  <weinig@apple.com>
719
720         Remove more i386 specific configurations
721         https://bugs.webkit.org/show_bug.cgi?id=196430
722
723         Reviewed by Alexey Proskuryakov.
724
725         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
726         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
727
728 2019-03-31  Andy Estes  <aestes@apple.com>
729
730         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
731         https://bugs.webkit.org/show_bug.cgi?id=196433
732         <rdar://problem/49293305>
733
734         Reviewed by Tim Horton.
735
736         Enhanced API test coverage to include all navigation response policy decisions in both
737         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
738
739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
740         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
741         (TestWebKitAPI::TEST):
742         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
743         (readFile):
744         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
745         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
746         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
747         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
748         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
749         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
750         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
751         (-[QuickLookDelegate _downloadDidStart:]):
752         (-[QuickLookDelegate _download:didReceiveResponse:]):
753         (-[QuickLookDelegate _download:didReceiveData:]):
754         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
755         (-[QuickLookDelegate _downloadDidFinish:]):
756         (-[QuickLookDelegate _download:didFailWithError:]):
757         (-[QuickLookDelegate _downloadDidCancel:]):
758         (-[QuickLookDelegate verifyDownload]):
759         (runTest):
760         (runTestDecideBeforeLoading):
761         (runTestDecideAfterLoading):
762         (TEST):
763         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
764         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
765         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
766         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
767         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
768         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
769         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
770         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
771         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
772         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
773         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
774         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
775         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
776         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
777
778 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
779
780         [CMake] add testdfg as target with build-jsc
781         https://bugs.webkit.org/show_bug.cgi?id=196393
782
783         Reviewed by Saam Barati.
784
785         Added testdfg as one of the targets to build when
786         using CMake.
787
788         * Scripts/build-jsc:
789
790 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
791
792         Delete WebMetal implementation in favor of WebGPU
793         https://bugs.webkit.org/show_bug.cgi?id=195418
794
795         Reviewed by Dean Jackson.
796
797         * DumpRenderTree/mac/DumpRenderTree.mm:
798         (enableExperimentalFeatures):
799         (resetWebPreferencesToConsistentValues):
800         * Scripts/webkitperl/FeatureList.pm:
801         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
803         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
804         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
805         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
806         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
807         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
808         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
809         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
811         (WTR::InjectedBundle::beginTesting):
812         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
813         (WTR::TestRunner::setWebMetalEnabled): Deleted.
814         * WebKitTestRunner/InjectedBundle/TestRunner.h:
815
816 2019-03-29  Chris Dumez  <cdumez@apple.com>
817
818         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
819         https://bugs.webkit.org/show_bug.cgi?id=196405
820         <rdar://problem/49428130>
821
822         Reviewed by Wenson Hsieh.
823
824         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
825         the popover presentation methods to be no-ops. Use this in the new test added in
826         r243523 so that we do not swizzle those methods for all tests. This is needed because
827         those WatchOS tests rely on the popover getting presented and interactive.
828
829         * WebKitTestRunner/TestController.cpp:
830         (WTR::updateTestOptionsFromTestHeader):
831         * WebKitTestRunner/TestController.h:
832         * WebKitTestRunner/TestOptions.h:
833         (WTR::TestOptions::hasSameInitializationOptions const):
834         * WebKitTestRunner/ios/TestControllerIOS.mm:
835         (WTR::TestController::platformInitialize):
836         (WTR::TestController::platformResetStateToConsistentValues):
837
838 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
839
840         [Curl] Add Server Trust Evaluation Support.
841         https://bugs.webkit.org/show_bug.cgi?id=191646
842
843         Reviewed by Fujii Hironori.
844
845         Implemented MiniBrowser UI for asking if user trusts the server.
846
847         * MiniBrowser/win/Common.cpp:
848         (askServerTrustEvaluation):
849         (replaceString):
850         * MiniBrowser/win/Common.h:
851         * MiniBrowser/win/MiniBrowserLib.rc:
852         * MiniBrowser/win/MiniBrowserLibResource.h:
853         * MiniBrowser/win/WebKitBrowserWindow.cpp:
854         (createPEMString):
855         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
856         (WebKitBrowserWindow::canTrustServerCertificate):
857         * MiniBrowser/win/WebKitBrowserWindow.h:
858
859 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
860
861         Implement ResizeObserver.
862         https://bugs.webkit.org/show_bug.cgi?id=157743
863
864         Reviewed by Simon Fraser.
865
866         Support resizeObserverEnabled webPreferences.
867
868         * DumpRenderTree/TestOptions.cpp:
869         (TestOptions::TestOptions):
870         * DumpRenderTree/TestOptions.h:
871         * DumpRenderTree/mac/DumpRenderTree.mm:
872         (setWebPreferencesForTestOptions):
873         * DumpRenderTree/win/DumpRenderTree.cpp:
874         (enableExperimentalFeatures):
875         * Scripts/webkitperl/FeatureList.pm:
876         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
877
878 2019-03-28  John Wilander  <wilander@apple.com>
879
880         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
881         https://bugs.webkit.org/show_bug.cgi?id=196281
882         <rdar://problem/48938748>
883
884         Reviewed by Alex Christensen.
885
886         This patch adds the function isStatisticsHasLocalStorage() to the
887         TestRunner. With it, the page can query the WebsiteDataStore in the
888         UI process to make sure that it sees LocalStorage.
889
890         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
892         (WTR::TestRunner::isStatisticsHasLocalStorage):
893         * WebKitTestRunner/InjectedBundle/TestRunner.h:
894         * WebKitTestRunner/TestController.cpp:
895         (WTR::TestController::isStatisticsHasLocalStorage):
896         * WebKitTestRunner/TestController.h:
897         * WebKitTestRunner/TestInvocation.cpp:
898         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
899
900 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
901
902         API::Data::createWithoutCopying should do a null check before calling CFRelease
903         https://bugs.webkit.org/show_bug.cgi?id=196276
904         <rdar://problem/48059859>
905
906         Reviewed by Alex Christensen.
907
908         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
909
910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
911         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
912         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
913         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
914         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
915         (TestWebKitAPI::TEST):
916
917 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
918
919         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
920         https://bugs.webkit.org/show_bug.cgi?id=186276
921
922         Reviewed by Carlos Garcia Campos.
923
924         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
925         (webViewLoadChanged):
926         (testWebResourceGetDataError):
927         (testWebResourceGetDataEmpty):
928         (beforeAll):
929         (webViewloadChanged): Deleted.
930
931 2019-03-27  Andy Estes  <aestes@apple.com>
932
933         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
934         https://bugs.webkit.org/show_bug.cgi?id=196317
935
936         Reviewed by Dan Bernstein.
937
938         package-root copies built products into a staging directory using ditto(1), which does not
939         follow symbolic links as it traverses a directory. Now that the files in
940         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
941         itself, these become broken links when ditto'd into the staging directory.
942
943         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
944
945         * Scripts/package-root:
946
947 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
948
949         [ews-app] Update display text of Submit for ews analysis
950         https://bugs.webkit.org/show_bug.cgi?id=196309
951
952         Reviewed by Dewei Zhu.
953
954         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
955
956 2019-03-27  David Kilzer  <ddkilzer@apple.com>
957
958         run-webkit-tests should check for leaks in WebKit processes
959         <https://webkit.org/b/193772>
960         <rdar://problem/46526680>
961
962         Reviewed by Ryosuke Niwa.
963
964         This works by doing the following:
965         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
966           The list of child processes are returned one per line:
967           process.name: pid
968         - Run the "#LIST CHILD PROCESSES" command just before the
969           "#CHECK FOR WORLD LEAKS" command, and store the list of child
970           processes on the ServerProcess object.
971         - When the `--leaks` switch is handled, run check_for_leaks() on
972           each child process after the main test harness.
973
974         * DumpRenderTree/mac/DumpRenderTree.mm:
975         (handleControlCommand):
976         - Use strncmp() instead of strcmp().
977         - Add support for handling "#LIST CHILD PROCESSES" command.
978
979         * Scripts/webkitpy/port/base.py:
980         (Port.check_for_leaks):
981         * Scripts/webkitpy/port/darwin.py:
982         (DarwinPort.check_for_leaks):
983         - Rename redundant 'process_pid' argument to 'process_id'.
984
985         * Scripts/webkitpy/port/driver.py:
986         (Driver.do_post_tests_work):
987         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
988           longer the only command this sends to WebKitTestRunner.
989         - If the `--leaks` switch is present, send the
990           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
991           result using Port.set_webkit_processes().
992         (Driver._parse_child_processes_output):
993         - Add helper method to parse list of child process names and
994           process IDs returned from WebKitTestRunner.
995
996         * Scripts/webkitpy/port/ios_device.py:
997         (IOSDevicePort.check_for_leaks):
998         - Rename redundant 'process_pid' argument to 'process_id'.
999
1000         * Scripts/webkitpy/port/leakdetector.py:
1001         (LeakDetector._parse_leaks_output):
1002         - Return early if there is no leaks_output.
1003         (LeakDetector.check_for_leaks):
1004         - Rename redundant 'process_pid' argument to 'process_id'.
1005
1006         * Scripts/webkitpy/port/server_process.py:
1007         (ServerProcess.__init__):
1008         (ServerProcess.child_processes):
1009         (ServerProcess.set_child_processes):
1010         - Add instance variable to Port to store list of child process
1011           names and process IDs returned from WebKitTestRunner.
1012         (ServerProcess._start):
1013         - Clear self._child_processes.
1014         (ServerProcess.stop):
1015         - If self._child_processes is set, call
1016           self._port.check_for_leaks() for each child process.
1017
1018         * Scripts/webkitpy/port/server_process_unittest.py:
1019         (TrivialMockPort.check_for_leaks):
1020         - Rename redundant 'process_pid' argument to 'process_id'.
1021
1022         * Scripts/webkitpy/port/simulator_process.py:
1023         (SimulatorProcess.stop):
1024         - If self._child_processes is set, call
1025           self._port.check_for_leaks() for each child process.
1026
1027         * Scripts/webkitpy/port/watch_device.py:
1028         (WatchDevicePort.check_for_leaks):
1029         - Rename redundant 'process_pid' argument to 'process_id'.
1030
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::TestController::dumpResponse):
1033         - Extract method from findAndDumpWorldLeaks() so that it may be
1034           reused by findAndDumpWebKitProcessIdentifiers().
1035         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1036         - Add method to output process name and process ID of both the
1037           WebContent and Networking processes.
1038         (WTR::TestController::findAndDumpWorldLeaks):
1039         - Fix missing newline in output when there were no abandoned
1040           documents.
1041         - Call dumpResponse() for extracted code.
1042         (WTR::TestController::handleControlCommand):
1043         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1044         - Use strncmp() instead of strcmp().
1045         - Call findAndDumpWebKitProcessIdentifiers() when
1046           "#LIST CHILD PROCESSES" command is sent.
1047         * WebKitTestRunner/TestController.h:
1048         (WTR::TestController::dumpResponse):
1049         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1050         - Declare methods.
1051
1052 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1053
1054         Unreviewed. Add GLib API test cases after r243434.
1055
1056         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1057         (testWebViewActiveURI):
1058         (serverCallback):
1059         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1060         (sendRequestCallback):
1061
1062 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1063
1064         Geolocation request not complete when watch request was started in a different web process
1065         https://bugs.webkit.org/show_bug.cgi?id=195996
1066
1067         Reviewed by Alex Christensen.
1068
1069         Add a test case.
1070
1071         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1072         (TestWebKitAPI::runJavaScriptAlert):
1073         (TestWebKitAPI::TEST):
1074
1075 2019-03-26  Keith Rollin  <krollin@apple.com>
1076
1077         Update the way generate-xcfilelists returns strings from functions
1078         https://bugs.webkit.org/show_bug.cgi?id=195975
1079         <rdar://problem/49040807>
1080
1081         Reviewed by Dean Jackson.
1082
1083         There are places where generate-xcfilelists executes assignments with
1084         statements like:
1085
1086             FOO=$(some_function)
1087
1088         where "some_function" return a string by echoing it. E.g.
1089
1090             some_function()
1091             {
1092                 echo "Hello, World"
1093             }
1094
1095         This is a common idiom, but it has a problem if "some_function" needs
1096         to call "exit" in an attempt to halt the entire script right then and
1097         there. Since "some_function" is called inside of $(), it's being
1098         executed in a sub-shell. Calling exit in that sub-shell simply exits
1099         that shell; it doesn't not exit the outer shell in which the main part
1100         of the script is still running. As such, the main script keeps
1101         executing when the intent was for the script to halt.
1102
1103         The solution to this is to use a different idiom for returning
1104         strings. The one we now is to pass in the name of the variable to
1105         receive the string result:
1106
1107             some_function()
1108             {
1109                 variable_name=$1
1110                 eval $variable_name ="Hello, World"
1111             }
1112
1113         The call site now looks like
1114
1115             some_function FOO
1116
1117         Because there's no invocation of a sub-shell, some_function can now
1118         call "exit" if it wants to, and the entire script will exit at that
1119         point.
1120
1121         * Scripts/generate-xcfilelists:
1122
1123 2019-03-26  Chris Dumez  <cdumez@apple.com>
1124
1125         Add basic layout test coverage for File Picker on iOS
1126         https://bugs.webkit.org/show_bug.cgi?id=196265
1127
1128         Reviewed by Wenson Hsieh.
1129
1130         Add layout test infrastructure to test the file picker on iOS.
1131
1132         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1133         (WTR::UIScriptController::dismissFilePicker):
1134         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1135         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1136         (WTR::UIScriptController::dismissFilePicker):
1137         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::TestController::createWebViewWithOptions):
1140         (WTR::updateTestOptionsFromTestHeader):
1141         * WebKitTestRunner/TestOptions.h:
1142         (WTR::TestOptions::hasSameInitializationOptions const):
1143         * WebKitTestRunner/ios/TestControllerIOS.mm:
1144         (overridePresentViewController):
1145         (WTR::TestController::platformInitialize):
1146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1147         (WTR::UIScriptController::dismissFilePicker):
1148
1149 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1150
1151         Implement async paste method on UIWKInteractionViewProtocol
1152         https://bugs.webkit.org/show_bug.cgi?id=196267
1153         <rdar://problem/49236346>
1154
1155         Reviewed by Tim Horton.
1156
1157         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1158         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1159         are now a part of all iOS 12 internal SDKs.
1160
1161         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1162
1163         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1164         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1165
1166         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1167         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1168         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1169         * TestWebKitAPI/ios/UIKitSPI.h:
1170
1171 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1172
1173         [ews-build] Use PostgreSQL for ews.webkit.org database
1174         https://bugs.webkit.org/show_bug.cgi?id=196270
1175
1176         Reviewed by Lucas Forschler.
1177
1178         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1179
1180 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1181
1182         [ews] Reset simctl states on reboot
1183         https://bugs.webkit.org/show_bug.cgi?id=196260
1184
1185         Rubber-stamped by Aakash Jain.
1186
1187         * EWSTools/start-queue-mac.sh:
1188
1189 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-build] Use PostgreSQL for ews-build database
1192         https://bugs.webkit.org/show_bug.cgi?id=196229
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-build/master.cfg:
1197
1198 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-build] Get master_hostname dynamically in master.cfg
1201         https://bugs.webkit.org/show_bug.cgi?id=196255
1202
1203         Reviewed by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1206         send events data in test mode.
1207
1208 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1209
1210         [ews-app] Set db_constraint to False for Foreign Keys
1211         https://bugs.webkit.org/show_bug.cgi?id=196252
1212
1213         Reviewed by Lucas Forschler.
1214
1215         * BuildSlaveSupport/ews-app/ews/models/build.py:
1216         * BuildSlaveSupport/ews-app/ews/models/step.py:
1217
1218 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1219
1220         [ews-build] is_test_mode_enabled should default to True
1221         https://bugs.webkit.org/show_bug.cgi?id=196248
1222
1223         Reviewed by Lucas Forschler.
1224
1225         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1226
1227 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1228
1229         [ews-app] Add webkitperl to ENABLED_QUEUES
1230         https://bugs.webkit.org/show_bug.cgi?id=196253
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1235
1236 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1237
1238         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1239         https://bugs.webkit.org/show_bug.cgi?id=196211
1240         rdar://problem/49110552
1241
1242         Reviewed by Tim Horton.
1243
1244         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1245         Make sure that EventSenderProxy always exists when running tests. We used to create
1246         it when resetting before the first test, which is a bit too late.
1247
1248         * WebKitTestRunner/TestController.h:
1249         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1250         (WTR::TestController::platformCreateWebView):
1251         (WTR::TestController::platformCreateOtherPage):
1252         (WTR::TestController::finishCreatingPlatformWebView):
1253         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1254         (WTR::PlatformWebView::PlatformWebView):
1255         Moved some code that made NSWindow use NSEvent during web view creation. We may
1256         need to move more if some other case us found, but this is enough for now.
1257
1258 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1259
1260         Unreviewed. Fix typo in GLib geolocation API after r243285.
1261
1262         gelocation -> geolocation.
1263
1264         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1265         (testGeolocationManagerWatchPosition):
1266
1267 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1268
1269         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1270         https://bugs.webkit.org/show_bug.cgi?id=196213
1271
1272         Reviewed by Geoff Garen.
1273
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1276         (credentialWithIdentityAndKeychainPath):
1277         (-[ChallengeDelegate webView:didFinishNavigation:]):
1278         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1279         (TestWebKitAPI::TEST):
1280
1281 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1282
1283         Expected shouldn't assume its contained types are copyable
1284         https://bugs.webkit.org/show_bug.cgi?id=195986
1285
1286         Reviewed by JF Bastien.
1287
1288         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1289         (TestWebKitAPI::NonCopyable::operator== const):
1290         (TestWebKitAPI::NonCopyable::operator!= const):
1291         (TestWebKitAPI::TEST):
1292
1293 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1294
1295         Remove some now-unnecessary dynamic class lookup
1296         https://bugs.webkit.org/show_bug.cgi?id=196237
1297
1298         Reviewed by Simon Fraser.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1301         (makeRequest):
1302         (TEST):
1303
1304 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1305
1306         Unreviewed, rolling out r243450.
1307
1308         AppleWin and WinCairo port builds get broken.
1309
1310         Reverted changeset:
1311
1312         "Add test for fix of #196095"
1313         https://bugs.webkit.org/show_bug.cgi?id=196097
1314         https://trac.webkit.org/changeset/243450
1315
1316 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1317
1318         Unreviewed, rolling out r243465.
1319         https://bugs.webkit.org/show_bug.cgi?id=196226
1320
1321         the test doesn't build (Requested by thorton on #webkit).
1322
1323         Reverted changeset:
1324
1325         "Do not terminate the NetworkProcess if a third party
1326         application sends a NSCredential with a SecIdentityRef"
1327         https://bugs.webkit.org/show_bug.cgi?id=196213
1328         https://trac.webkit.org/changeset/243465
1329
1330 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1331
1332         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1333         https://bugs.webkit.org/show_bug.cgi?id=196213
1334
1335         Reviewed by Geoff Garen.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1339         (credentialWithIdentityAndKeychainPath):
1340         (-[ChallengeDelegate webView:didFinishNavigation:]):
1341         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1342         (TestWebKitAPI::TEST):
1343
1344 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-build] Gracefully handle missing patch_id in events
1347         https://bugs.webkit.org/show_bug.cgi?id=196216
1348
1349         Reviewed by Lucas Forschler.
1350
1351         * BuildSlaveSupport/ews-build/events.py:
1352
1353 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1354
1355         [ews-build] use lz4 compression for improving buildbot performance
1356         https://bugs.webkit.org/show_bug.cgi?id=196155
1357
1358         Reviewed by Lucas Forschler.
1359
1360         * BuildSlaveSupport/ews-build/master.cfg:
1361
1362 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1363
1364         Pull some API testing helper methods out of TestWKWebView
1365         https://bugs.webkit.org/show_bug.cgi?id=196212
1366
1367         Reviewed by Tim Horton.
1368
1369         Refactor some more API testing utility methods, so that they can be used in
1370         tests that do not use TestWKWebView.
1371
1372         * TestWebKitAPI/cocoa/TestWKWebView.h:
1373         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1374         (-[WKWebView loadTestPageNamed:]):
1375         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1376         (-[WKWebView synchronouslyLoadHTMLString:]):
1377         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1378         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1379         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1380         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1381         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1382
1383 2019-03-25  Jer Noble  <jer.noble@apple.com>
1384
1385         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1386         https://bugs.webkit.org/show_bug.cgi?id=196097
1387
1388         Reviewed by Eric Carlson.
1389
1390         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1391
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (resetWebPreferencesToConsistentValues):
1394         * WebKitTestRunner/TestController.cpp:
1395         (WTR::TestController::resetPreferencesToConsistentValues):
1396
1397 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1398
1399         Pull IPadUserInterfaceSwizzler out into a separate header file
1400         https://bugs.webkit.org/show_bug.cgi?id=196193
1401
1402         Reviewed by Anders Carlsson.
1403
1404         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1405         be used in other API tests.
1406
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1409         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1410         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1411         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1412         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1413         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1414
1415 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1416
1417         Remove NavigatorContentUtils in WebCore/Modules
1418         https://bugs.webkit.org/show_bug.cgi?id=196070
1419
1420         Reviewed by Alex Christensen.
1421
1422         NavigatorContentUtils was to support the custom scheme spec [1].
1423         However, in WebKit side, no port has supported the feature in
1424         WebKit layer after EFL port was removed. So there has been the
1425         only IDL implementation of the NavigatorContentUtils in WebCore.
1426         So we don't need to keep the implementation in WebCore anymore.
1427
1428         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1429
1430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1431
1432 2019-03-24  Andy Estes  <aestes@apple.com>
1433
1434         [watchOS] Remove unused Proximity Networking code
1435         https://bugs.webkit.org/show_bug.cgi?id=196188
1436
1437         Reviewed by Tim Horton.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1440         (TEST):
1441
1442 2019-03-23  Keith Miller  <keith_miller@apple.com>
1443
1444         Refactor clz/ctz and fix getLSBSet.
1445         https://bugs.webkit.org/show_bug.cgi?id=196162
1446
1447         Reviewed by Saam Barati.
1448
1449         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1450
1451         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1452         (TestWebKitAPI::TEST):
1453
1454 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1455
1456         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1457         https://bugs.webkit.org/show_bug.cgi?id=196143
1458
1459         Reviewed by Michael Catanzaro.
1460
1461         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1462         directories.
1463
1464         * Scripts/webkitpy/style/checkers/cpp.py:
1465         (check_identifier_name_in_declaration):
1466         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1467         (WebKitStyleTest.test_names):
1468
1469 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1470
1471         [Flatpak] Manifest expanding fails for qt WPE extension
1472         https://bugs.webkit.org/show_bug.cgi?id=196148
1473
1474         Reviewed by Alex Christensen.
1475
1476         * flatpak/flatpakutils.py:
1477         (expand_submodules_recurse): The last recurse manifest expand
1478         iteration might lead to a single module so take it into account
1479         and don't try to recurse further.
1480
1481 2019-03-22  Chris Dumez  <cdumez@apple.com>
1482
1483         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1484         https://bugs.webkit.org/show_bug.cgi?id=195348
1485         <rdar://problem/48622090>
1486
1487         Reviewed by Alex Christensen.
1488
1489         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1490         to NO when test.options().shouldIgnoreMetaViewport is false.
1491
1492         * WebKitTestRunner/ios/TestControllerIOS.mm:
1493         (WTR::TestController::platformConfigureViewForTest):
1494
1495 2019-03-22  Chris Dumez  <cdumez@apple.com>
1496
1497         Prewarmed processes should be usable with any website data store
1498         https://bugs.webkit.org/show_bug.cgi?id=196104
1499
1500         Reviewed by Alex Christensen.
1501
1502         Add API test coverage.
1503
1504         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1505         (runInitialWarmedProcessUsedTest):
1506         (TEST):
1507
1508 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1509
1510         Back out local changes to Alex's Subversion working directory
1511
1512         They were accidentally committed.
1513
1514         * Scripts/webkitpy/common/system/abstractexecutive.py:
1515         (AbstractExecutive.wait_newest):
1516         * Scripts/webkitpy/common/system/executive.py:
1517         (Executive.running_pids):
1518         * Scripts/webkitpy/common/system/executive_mock.py:
1519         (MockExecutive.running_pids):
1520         * Scripts/webkitpy/common/system/executive_unittest.py:
1521         (ExecutiveTest.serial_test_running_pids):
1522         * Scripts/webkitpy/port/darwin.py:
1523         (DarwinPort.check_for_leaks):
1524         * Scripts/webkitpy/port/leakdetector.py:
1525         (LeakDetector.check_for_leaks):
1526         - This was the hack attached to Bug 193772.
1527
1528         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1529         (+[WebKitTestRunnerEvent mouseLocation]):
1530         - This works around a crash on an internal build.
1531
1532 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1533
1534         Fix the build after r243354
1535         https://bugs.webkit.org/show_bug.cgi?id=196138
1536         <rdar://problem/49145951>
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1539         (TEST):
1540         * TestWebKitAPI/ios/UIKitSPI.h:
1541
1542 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1543
1544         Adopt UIWKDocumentContext
1545         https://bugs.webkit.org/show_bug.cgi?id=196040
1546         <rdar://problem/48642440>
1547
1548         Reviewed by Ryosuke Niwa.
1549
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1552         (makeRequest):
1553         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1554         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1555         (applyStyle):
1556         (TEST):
1557         Add tests for UIWKDocumentContext.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1560         (TEST):
1561         (recursiveFindWKContentView): Deleted.
1562         * TestWebKitAPI/cocoa/TestWKWebView.h:
1563         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1564         (recursiveFindWKContentView):
1565         (-[TestWKWebView wkContentView]):
1566         * TestWebKitAPI/ios/UIKitSPI.h:
1567         Share the WKContentView finding code between tests.
1568
1569 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1570
1571         [iOS WK2] Turn on async overflow scrolling by default
1572         https://bugs.webkit.org/show_bug.cgi?id=196011
1573         rdar://problem/48453859
1574
1575         Reviewed by Antti Koivisto.
1576         
1577         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1578         since so many basic layout tests have different results when compositing is triggered for
1579         overflow.
1580         
1581         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1582
1583         * WebKitTestRunner/TestController.cpp:
1584         (WTR::TestController::resetPreferencesToConsistentValues):
1585
1586 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1587
1588         [ews-build] Retry API test in case of failures
1589         https://bugs.webkit.org/show_bug.cgi?id=196004
1590
1591         Reviewed by Lucas Forschler.
1592
1593         * BuildSlaveSupport/ews-build/steps.py:
1594         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1595         (CompileWebKitToT.doStepIf): Ditto.
1596         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1597         (ReRunAPITests): Re-run API tests.
1598         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1599         (RunAPITestsWithoutPatch): Run API tests without patch.
1600         (RunAPITestsWithoutPatch.doStepIf):
1601         (RunAPITestsWithoutPatch.hideStepIf):
1602         (RunAPITestsWithoutPatch.evaluateCommand):
1603         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1604         (AnalyzeAPITestsResults.start):
1605         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1606         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1607         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1608         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1609
1610 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1611
1612         [ews-build] Update queues configurations
1613         https://bugs.webkit.org/show_bug.cgi?id=196074
1614
1615         Reviewed by Dewei Zhu.
1616
1617         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1618         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1619
1620 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1621
1622         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1623         https://bugs.webkit.org/show_bug.cgi?id=195680
1624         <rdar://problem/48903534>
1625
1626         Unreviewed infrastructure fix.
1627
1628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1629         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1630
1631 2019-03-21  Andy Estes  <aestes@apple.com>
1632
1633         [iOS] Apple Pay should be available in documents with no user agent scripts
1634         https://bugs.webkit.org/show_bug.cgi?id=196061
1635         <rdar://problem/48649391>
1636
1637         Reviewed by Brady Eidson.
1638
1639         Added API tests and related infrastructure.
1640
1641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1642         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1643         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1644         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1647         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1648         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1649         * TestWebKitAPI/cocoa/TestProtocol.mm:
1650         (-[TestProtocol startLoading]):
1651         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1652         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1653         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1654         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1655
1656 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1657
1658         REGRESSSION (r243297): webkitpy tests broken
1659         https://bugs.webkit.org/show_bug.cgi?id=196108
1660
1661         Reviewed by Aakash Jain.
1662
1663         r243297 updated contributors.json, which broke a few unit tests.
1664
1665         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1666         (IRCCommandTest.test_whois):
1667         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1668
1669 2019-03-21  Chris Dumez  <cdumez@apple.com>
1670
1671         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1672         https://bugs.webkit.org/show_bug.cgi?id=196041
1673         <rdar://problem/49083230>
1674
1675         Reviewed by Alex Christensen.
1676
1677         Add API test coverage.
1678
1679         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1680         (TEST):
1681
1682 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1683
1684         Add SPI to inform applications of WKContentRuleList actions
1685         https://bugs.webkit.org/show_bug.cgi?id=195965
1686         <rdar://problem/42664365>
1687
1688         Reviewed by Geoff Garen.
1689
1690         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1691         (TestWebKitAPI::allActionsForResourceLoad):
1692         (TestWebKitAPI::testRequest):
1693         (TestWebKitAPI::TEST_F):
1694         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1695         (Notification::description):
1696         (Notification::operator== const):
1697         (toVector):
1698         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1699         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1700         (makeContentRuleList):
1701         (TEST):
1702         (makeWarnContentRuleList): Deleted.
1703
1704 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1705
1706         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1707         https://bugs.webkit.org/show_bug.cgi?id=196088
1708
1709         Reviewed by Brian Burg.
1710
1711         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1712         Support checks when only one platform is specified. Also deprecate macosx() and
1713         force the use of macos() instead.
1714
1715         * Scripts/webkitpy/style/checkers/cpp.py:
1716         (check_min_versions_of_wk_api_available):
1717         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1718         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1719
1720 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1721
1722         Update status inactive committers' status to 'contributor'.
1723
1724         * Scripts/webkitpy/common/config/contributors.json:
1725
1726 2019-03-21  Xan Lopez  <xan@igalia.com>
1727
1728         [JSC][x86] Drop support for x87 floating point
1729         https://bugs.webkit.org/show_bug.cgi?id=194853
1730
1731         Reviewed by Don Olmstead.
1732
1733         Force SSE2 on x86/32bit builds.
1734
1735         * Scripts/webkitdirs.pm:
1736         (generateBuildSystemFromCMakeProject):
1737
1738 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1739
1740         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1741         https://bugs.webkit.org/show_bug.cgi?id=196073
1742
1743         Reviewed by Michael Catanzaro.
1744
1745         Add test cases to check functions and constructors with no arguments but receiving user data.
1746
1747         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1748         (checkUserData):
1749         (testJSCFunction):
1750         (fooCreateWithUserData):
1751         (testJSCClass):
1752
1753 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1754
1755         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1756
1757         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1758
1759         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1760
1761 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1762
1763         [GTK][WPE] Add API to provide geolocation information
1764         https://bugs.webkit.org/show_bug.cgi?id=195940
1765
1766         Reviewed by Michael Catanzaro.
1767
1768         Add a new test to check the new API.
1769
1770         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1771         (testGeolocationManagerCurrentPosition):
1772         (testGeolocationManagerWatchPosition):
1773         (beforeAll):
1774         (afterAll):
1775         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1776         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1777         (beforeAll): Ditto.
1778         * TestWebKitAPI/glib/CMakeLists.txt:
1779
1780 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GLib] Returning G_TYPE_OBJECT from a method does not work
1783         https://bugs.webkit.org/show_bug.cgi?id=195574
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1788
1789         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1790         (getGFile):
1791         (getParent):
1792         (createGString):
1793         (getGString):
1794         (getGStringCopyWillRaise):
1795         (getGStringCopy):
1796         (getGStringStr):
1797         (getGStringLen):
1798         (freeGString):
1799         (testJSCClass):
1800
1801 2019-03-20  Saam Barati  <sbarati@apple.com>
1802
1803         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1804         https://bugs.webkit.org/show_bug.cgi?id=195721
1805
1806         Reviewed by Filip Pizlo.
1807
1808         * Scripts/run-javascriptcore-tests:
1809
1810 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1811
1812         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1813         https://bugs.webkit.org/show_bug.cgi?id=196049
1814
1815         Reviewed by Tim Horton.
1816
1817         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1818         overflow scrolling in general, so rename it.
1819
1820         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1821
1822 2019-03-20  Daniel Bates  <dabates@apple.com>
1823
1824         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1825         https://bugs.webkit.org/show_bug.cgi?id=196031
1826         <rdar://problem/49078172>
1827
1828         Reviewed by Tim Horton.
1829
1830         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1831         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1832         same code path used when the Done button is pressed to dismiss the <select> picker.
1833
1834         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1835         (TestWebKitAPI::TEST):
1836
1837 2019-03-20  Chris Dumez  <cdumez@apple.com>
1838
1839         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1840         https://bugs.webkit.org/show_bug.cgi?id=196029
1841         <rdar://problem/48954651>
1842
1843         Reviewed by Tim Horton.
1844
1845         Add API test coverage.
1846
1847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1848
1849 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1850
1851         [ews-build] Improve failure summary string for ApplyPatch step
1852         https://bugs.webkit.org/show_bug.cgi?id=195995
1853
1854         Reviewed by Alexey Proskuryakov.
1855
1856         * BuildSlaveSupport/ews-build/steps.py:
1857         (ApplyPatch.getResultSummary): Override getResultSummary.
1858
1859 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1860
1861         AX: Implement support for new meter ARIA role
1862         https://bugs.webkit.org/show_bug.cgi?id=195966
1863
1864         Reviewed by Chris Fleizach.
1865
1866         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1867         to AXLevelIndicator.
1868
1869         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1870
1871 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1872
1873         [WebAuthN] Implement FIDO AppID extension
1874         https://bugs.webkit.org/show_bug.cgi?id=143491
1875         <rdar://problem/48298273>
1876
1877         Reviewed by Brent Fulgham.
1878
1879         Add a test that covers the new flag of convertToU2fSignCommand.
1880
1881         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1882         (TestWebKitAPI::TEST):
1883         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1884         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1885         (TestWebKitAPI::TEST):
1886
1887 2019-03-19  Keith Rollin  <krollin@apple.com>
1888
1889         Add support for more platforms to generate-xcfilelists
1890         https://bugs.webkit.org/show_bug.cgi?id=195977
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         generate-xcfilelists incorrectly complains when involved with building
1895         WebKit for iphonesimulator:
1896
1897             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1898             …
1899             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1900
1901         Address this by teaching generate-xcfilelists about more platforms.
1902
1903         * Scripts/generate-xcfilelists:
1904
1905 2019-03-19  John Wilander  <wilander@apple.com>
1906
1907         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1908         https://bugs.webkit.org/show_bug.cgi?id=195923
1909         <rdar://problem/49001272>
1910
1911         Reviewed by Alex Christensen.
1912
1913         This patch does the following to the TestRunner:
1914         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1915         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1916         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1917
1918         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1919         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1920         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1921         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1924         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1925         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1926         * WebKitTestRunner/TestController.h:
1927         * WebKitTestRunner/TestInvocation.cpp:
1928         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1929
1930 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1931
1932         [CMake] Support more clang and gcc sanitizers
1933         https://bugs.webkit.org/show_bug.cgi?id=195956
1934
1935         Reviewed by Michael Catanzaro.
1936
1937         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1938
1939 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1940
1941         [ews-build] Improve summary for PrintConfiguration step
1942         https://bugs.webkit.org/show_bug.cgi?id=195945
1943
1944         Reviewed by Lucas Forschler.
1945
1946         * BuildSlaveSupport/ews-build/steps.py:
1947         (PrintConfiguration.getResultSummary): Override getResultSummary.
1948
1949 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1950
1951         [ews-build] Improve summary for CheckOutSource step
1952         https://bugs.webkit.org/show_bug.cgi?id=195963
1953
1954         Reviewed by Lucas Forschler.
1955
1956         * BuildSlaveSupport/ews-build/steps.py:
1957         (CheckOutSource.getResultSummary):
1958
1959 2019-03-19  Daniel Bates  <dabates@apple.com>
1960
1961         [iOS] Focus not preserved when switching between tabs
1962         https://bugs.webkit.org/show_bug.cgi?id=195820
1963         <rdar://problem/43614450>
1964
1965         Reviewed by Brent Fulgham.
1966
1967         Add tests to ensure that we restore focus when resigning and becoming first responder.
1968
1969         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1970         (TestWebKitAPI::TEST):
1971
1972 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1973
1974         Make WTFLogChannelState and WTFLogLevel enum classes
1975         https://bugs.webkit.org/show_bug.cgi?id=195904
1976
1977         Reviewed by Eric Carlson.
1978
1979         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1980         (TestWebKitAPI::TEST_F):
1981
1982 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1983
1984         [GStreamer][EME] Backported mssdemux protection data crash fix
1985         https://bugs.webkit.org/show_bug.cgi?id=195918
1986
1987         Reviewed by Philippe Normand.
1988
1989         * gstreamer/jhbuild.modules:
1990         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1991
1992 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1993
1994         Unreviewed, rolling out r243132.
1995
1996         Broke GTK build
1997
1998         Reverted changeset:
1999
2000         "Make WTFLogChannelState and WTFLogLevel enum classes"
2001         https://bugs.webkit.org/show_bug.cgi?id=195904
2002         https://trac.webkit.org/changeset/243132
2003
2004 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2005
2006         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2007
2008         * Scripts/webkitdirs.pm:
2009         (builtDylibPathForName): Adjust the shared library name that's changed
2010         with the API version bump in r243073.
2011
2012 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2013
2014         Make WTFLogChannelState and WTFLogLevel enum classes
2015         https://bugs.webkit.org/show_bug.cgi?id=195904
2016
2017         Reviewed by Eric Carlson.
2018
2019         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2020         (TestWebKitAPI::TEST_F):
2021
2022 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2023
2024         Disable flaky test added in r2431100
2025         https://webkit.org/b/195785
2026
2027         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2028         (TestWebKitAPI::TEST):
2029         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2030
2031 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2032
2033         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2034         https://bugs.webkit.org/show_bug.cgi?id=195916
2035
2036         Reviewed by Tim Horton.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2039         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2040
2041 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2042
2043         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2044
2045         * Scripts/webkitpy/common/config/contributors.json:
2046
2047 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2048
2049         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2050         https://bugs.webkit.org/show_bug.cgi?id=195785
2051
2052         Reviewed by Geoffrey Garen.
2053
2054         * TestWebKitAPI/TCPServer.cpp: Added.
2055         (TestWebKitAPI::TCPServer::TCPServer):
2056         (TestWebKitAPI::TCPServer::~TCPServer):
2057         (TestWebKitAPI::TCPServer::socketBindListen):
2058         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2059         * TestWebKitAPI/TCPServer.h: Added.
2060         (TestWebKitAPI::TCPServer::port const):
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2063         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2064         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2065         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2066         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2067         (TestWebKitAPI::respondSlowly):
2068         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2069         (TestWebKitAPI::downloadAtRate):
2070         (TestWebKitAPI::TEST):
2071
2072 2019-03-18  Saam Barati  <sbarati@apple.com>
2073
2074         Add a plan file for JetStream 2
2075         https://bugs.webkit.org/show_bug.cgi?id=190734
2076
2077         Reviewed by Mark Lam.
2078
2079         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2080
2081 2019-03-18  Chris Dumez  <cdumez@apple.com>
2082
2083         Delay WebProcess launch until a load is triggered in a Web view
2084         https://bugs.webkit.org/show_bug.cgi?id=195758
2085         <rdar://problem/48126013>
2086
2087         Reviewed by Geoff Garen.
2088
2089         Add API test coverage. Also update some existing API tests to not expect
2090         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2091
2092         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2093         (TestWebKitAPI::TEST):
2094         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2095         (TestWebKitAPI::TEST):
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2097         (TEST):
2098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2099         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2100         (TEST):
2101         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2102         (TEST):
2103         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2104
2105 2019-03-18  Xan Lopez  <xan@igalia.com>
2106
2107         [CMake] Prevent potential warning when determining $architecture
2108         https://bugs.webkit.org/show_bug.cgi?id=195891
2109
2110         Reviewed by Michael Catanzaro.
2111
2112         It's possible for generateBuildSystemForCMakeProject to be called
2113         before determineArchitecture() is ever called. This will make the
2114         first eq check with $architecture to be bogus (and print a
2115         warning). Change that to an eq check with architecture(), which
2116         implicitly calls determineArchitecture() if needed, and change all
2117         the other similar cases in the method in the same way to prevent
2118         future bugs like this one.
2119
2120         * Scripts/webkitdirs.pm:
2121         (generateBuildSystemFromCMakeProject):
2122
2123 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2124
2125         [WPE] Tarballs generated with “make dist” cannot build documentation
2126         https://bugs.webkit.org/show_bug.cgi?id=195885
2127
2128         Reviewed by Carlos Garcia Campos.
2129
2130         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2131
2132 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2133
2134         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2135         https://bugs.webkit.org/show_bug.cgi?id=195883
2136
2137         Reviewed by Carlos Garcia Campos.
2138
2139         * gtkdoc/gtkdoc.py:
2140         (GTKDoc._run_command): When commands fail to run, include the full command line for
2141         the program invocation and the output it has generated on the standard error stream.
2142
2143 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2144
2145         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2146         https://bugs.webkit.org/show_bug.cgi?id=195786
2147
2148         Reviewed by Philippe Normand.
2149
2150         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2151         * wpe/jhbuild.modules: Ditto.
2152
2153 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2154
2155         [ews-build] Don't run clean builds on EWS builders
2156         https://bugs.webkit.org/show_bug.cgi?id=195851
2157
2158         Reviewed by Geoffrey Garen.
2159
2160         * BuildSlaveSupport/ews-build/factories.py:
2161
2162 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2163
2164         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2165         https://bugs.webkit.org/show_bug.cgi?id=195849
2166
2167         Reviewed by Chris Dumez.
2168
2169         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2172         (runWebsiteDataStoreCustomPaths):
2173
2174 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2175
2176         webkitpy: Upload test results
2177         https://bugs.webkit.org/show_bug.cgi?id=195755
2178         <rdar://problem/48896182>
2179
2180         Reviewed by Aakash Jain.
2181
2182         Establish a new format for uploading results that is not tied to layout tests, apply
2183         that format to webkitpy tests.
2184
2185         * Scripts/webkitpy/common/checkout/scm/git.py:
2186         (Git.native_branch): Return what branch the current checkout is on.
2187         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2188         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2189         * Scripts/webkitpy/common/checkout/scm/svn.py:
2190         (SVN.native_branch): Ditto.
2191         * Scripts/webkitpy/common/system/platforminfo.py:
2192         (PlatformInfo.build_version): Return a build version for Mac.
2193         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2194         (MockPlatformInfo.__init__):
2195         (MockPlatformInfo.build_version):
2196         * Scripts/webkitpy/results: Added.
2197         * Scripts/webkitpy/results/__init__.py: Added.
2198         * Scripts/webkitpy/results/options.py: Added.
2199         (upload_options): OptParse list for upload options.
2200         * Scripts/webkitpy/results/upload.py: Added.
2201         (Upload): Class which enforces the upload format expected by the results server.
2202         (Upload.Expectations):
2203         (Upload.create_configuration):
2204         (Upload.create_commit):
2205         (Upload.create_details):
2206         (Upload.create_run_stats):
2207         (Upload.create_test_result):
2208         (Upload.__init__):
2209         (Upload.Encoder): Encode Upload object as json.
2210         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2211         * Scripts/webkitpy/results/upload_unittest.py: Added.
2212         * Scripts/webkitpy/test/main.py:
2213         (Tester._parse_args): Add upload arguments.
2214         (Tester._run_tests): Allow results to be uploaded.
2215         * Scripts/webkitpy/test/runner.py:
2216         (Runner.__init__): Record which tests were run, rather than just counting them.
2217         (Runner.handle):
2218         * Scripts/webkitpy/test/runner_unittest.py:
2219         (RunnerTest.test_run):
2220         * Scripts/webkitpy/thirdparty/__init__.py:
2221         (AutoinstallImportHook.find_module): Add requests auto-install.
2222         (AutoinstallImportHook._install_requests):
2223         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2224         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2225
2226 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2227
2228         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2229         https://bugs.webkit.org/show_bug.cgi?id=195810
2230
2231         Reviewed by Tim Horton.
2232
2233         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2234         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2235         ending certain layout tests.
2236
2237         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2238         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2239         (-[TestRunnerWKWebView dealloc]):
2240         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2241
2242         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2243         helper method when destroying the web view, and when resetting state between tests.
2244
2245         * WebKitTestRunner/ios/TestControllerIOS.mm:
2246         (WTR::TestController::platformResetStateToConsistentValues):
2247
2248         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2249
2250 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2251
2252         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2253         https://bugs.webkit.org/show_bug.cgi?id=190350
2254         <rdar://problem/45089503>
2255
2256         Reviewed by Geoffrey Garen.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2260         (TEST):
2261         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2262         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2263         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2264         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2265         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2266         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2267         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2268         (runTest):
2269         (createDirectories):
2270         (TEST):
2271         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2272         (TEST):
2273         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2274         (TEST):
2275
2276 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2277
2278         Add support to WebPage for getting the contents as an attributed string.
2279         https://bugs.webkit.org/show_bug.cgi?id=195636
2280         rdar://problem/45055697
2281
2282         Reviewed by Tim Horton.
2283
2284         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2285         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2286
2287 2019-03-15  Chris Dumez  <cdumez@apple.com>
2288
2289         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2290         https://bugs.webkit.org/show_bug.cgi?id=195747
2291
2292         Reviewed by Geoff Garen.
2293
2294         Add API test coverage.
2295
2296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2297
2298 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2299
2300         Unreviewed, rolling out r242952.
2301
2302         Causing API failures on iOS Simulator
2303
2304         Reverted changeset:
2305
2306         "[PSON] Make sure the WebProcessCache is leverage when
2307         relaunching a process after termination"
2308         https://bugs.webkit.org/show_bug.cgi?id=195747
2309         https://trac.webkit.org/changeset/242952
2310
2311 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2312
2313         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2314         https://bugs.webkit.org/show_bug.cgi?id=195740
2315
2316         Reviewed by Ross Kirsling.
2317
2318         window.open doesn't work for WebKitBrowserWindow because it is not
2319         implemented yet.
2320
2321         1. Implemented createNewPage callback of WKPageUIClient.
2322         2. Changed MainWindow to take a BrowserWindow factory function
2323           instead of BrowserWindowType to be flexible to create
2324           BrowserWindow with extra settings.
2325         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2326           because it is not relevant with MainWindow anymore.
2327
2328         * MiniBrowser/win/Common.cpp:
2329         (parseCommandLine):
2330         * MiniBrowser/win/Common.h:
2331         (CommandLineOptions::CommandLineOptions):
2332         * MiniBrowser/win/MainWindow.cpp:
2333         (MainWindow::MainWindow):
2334         (MainWindow::create):
2335         (MainWindow::init):
2336         (MainWindow::WndProc):
2337         * MiniBrowser/win/MainWindow.h:
2338         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2339         (PrintWebUIDelegate::createWebViewWithRequest):
2340         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2341         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2342         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2343         (WebKitBrowserWindow::updateProxySettings):
2344         (WebKitBrowserWindow::createNewPage):
2345         * MiniBrowser/win/WebKitBrowserWindow.h:
2346         * MiniBrowser/win/WinMain.cpp:
2347         (wWinMain):
2348
2349 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2350
2351         Make it possible to test scrolling tree layer manipulation more easily
2352         https://bugs.webkit.org/show_bug.cgi?id=195780
2353
2354         Reviewed by Tim Horton.
2355         
2356         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2357         cuts off communication of scrolling tree scrolls back to the web process
2358         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2359         allows tests to trigger scrolls which run the scrolling tree layer positioning
2360         logic, but never get another commit from the web process that might mask
2361         scrolling tree bugs.
2362         
2363         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2364         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2365         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2366
2367         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2368         (WTR::UIScriptController::scrollUpdatesDisabled const):
2369         (WTR::UIScriptController::setScrollUpdatesDisabled):
2370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2372         (WTR::UIScriptController::scrollUpdatesDisabled const):
2373         (WTR::UIScriptController::setScrollUpdatesDisabled):
2374         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2375         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2376         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2377         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2378         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2379         * WebKitTestRunner/ios/TestControllerIOS.mm:
2380         (WTR::TestController::platformResetStateToConsistentValues):
2381         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2382         (WTR::UIScriptController::scrollUpdatesDisabled const):
2383         (WTR::UIScriptController::setScrollUpdatesDisabled):
2384
2385 2019-03-14  Youenn Fablet  <youenn@apple.com>
2386
2387         Move IDB storage in private browsing mode to NetworkProcess
2388         https://bugs.webkit.org/show_bug.cgi?id=195602
2389
2390         Reviewed by Brady Eidson.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2393         (TEST):
2394
2395 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2396
2397         [ews-build] Make descriptionDone messages more readable
2398         https://bugs.webkit.org/show_bug.cgi?id=195760
2399
2400         Reviewed by Lucas Forschler.
2401
2402         * BuildSlaveSupport/ews-build/steps.py:
2403         * BuildSlaveSupport/ews-build/steps_unittest.py:
2404
2405 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2406
2407         [ews-build] Generate status-bubble hover-over messages
2408         https://bugs.webkit.org/show_bug.cgi?id=195680
2409
2410         Reviewed by Lucas Forschler.
2411
2412         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2413         (StatusBubble):
2414         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2415         on hover-over.
2416         (StatusBubble._iso_time):
2417         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2418         hover-over message.
2419         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2420
2421 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2422
2423         [ews-app] Gracefully handle the case when state_string is None
2424         https://bugs.webkit.org/show_bug.cgi?id=195753
2425
2426         Reviewed by Lucas Forschler.
2427
2428         * BuildSlaveSupport/ews-app/ews/models/build.py:
2429         * BuildSlaveSupport/ews-app/ews/models/step.py:
2430
2431 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews-app] Status bubble display pending for currently running build step
2434         https://bugs.webkit.org/show_bug.cgi?id=195744
2435
2436         Reviewed by Lucas Forschler.
2437
2438         * BuildSlaveSupport/ews-build/events.py:
2439         (Events.stepStarted): If state_string is pending, replace it with step name.
2440
2441 2019-03-14  Chris Dumez  <cdumez@apple.com>
2442
2443         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2444         https://bugs.webkit.org/show_bug.cgi?id=195750
2445
2446         Reviewed by Geoffrey Garen.
2447
2448         Add API test coverage.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2451         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2452         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2453         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2454
2455 2019-03-14  Chris Dumez  <cdumez@apple.com>
2456
2457         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2458         https://bugs.webkit.org/show_bug.cgi?id=195747
2459
2460         Reviewed by Geoff Garen.
2461
2462         Add API test coverage.
2463
2464         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2465
2466 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2467
2468         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2469         https://bugs.webkit.org/show_bug.cgi?id=195725
2470         <rdar://problem/48545062>
2471
2472         Reviewed by Tim Horton.
2473
2474         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2475         handler is nil.
2476
2477         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2478         (TestWebKitAPI::TEST):
2479
2480 2019-03-13  Sam Weinig  <sam@webkit.org>
2481
2482         Add utility function to allow easy reverse range-based iteration of a container
2483         https://bugs.webkit.org/show_bug.cgi?id=195542
2484
2485         Reviewed by Antti Koivisto.
2486
2487         * TestWebKitAPI/CMakeLists.txt:
2488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2489         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2490         (TestWebKitAPI::TEST):
2491         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2492
2493 2019-03-13  Chris Dumez  <cdumez@apple.com>
2494
2495         Use a ServiceWorker process per registrable domain
2496         https://bugs.webkit.org/show_bug.cgi?id=195649
2497
2498         Reviewed by Youenn Fablet.
2499
2500         Update API test coverage.
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2503
2504 2019-03-13  Chris Dumez  <cdumez@apple.com>
2505
2506         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2507         https://bugs.webkit.org/show_bug.cgi?id=195684
2508         <rdar://problem/48294714>
2509
2510         Reviewed by Antti Koivisto.
2511
2512         Add API test coverage.
2513
2514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2515
2516 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2517
2518         [ews-app] Remove unused patch view
2519         https://bugs.webkit.org/show_bug.cgi?id=195669
2520
2521         Reviewed by Lucas Forschler.
2522
2523         * BuildSlaveSupport/ews-app/ews/urls.py:
2524         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2525
2526 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2527
2528         [ews-app] Use Buildbot result code variables
2529         https://bugs.webkit.org/show_bug.cgi?id=195668
2530
2531         Reviewed by Alexey Proskuryakov.
2532
2533         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2534         (Buildbot): Added Buildbot result code variables.
2535         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2536         (StatusBubble._build_bubble): Used Buildbot result code variables.
2537
2538 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2539
2540         [Flatpak] Expand submodule recursively
2541         https://bugs.webkit.org/show_bug.cgi?id=195672
2542
2543         Building WPE with flatpak was impossible without that as it was raising an exception.
2544         Also update wpebackend-fdo to match what is built in jhbuild
2545
2546         Reviewed by Philippe Normand.
2547
2548         * flatpak/flatpakutils.py:
2549         (expand_submodules_recurse):
2550         (expand_manifest):
2551         * flatpak/org.webkit.WPEModules.yaml:
2552
2553 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2554
2555         [ews-app] status bubble should be hidden for certain builds
2556         https://bugs.webkit.org/show_bug.cgi?id=194597
2557
2558         Reviewed by Dewei Zhu.
2559
2560         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2561         (StatusBubble._build_bubble):
2562         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2563         because the patch didn't have relevant changes.
2564         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2565         in production yet.
2566
2567 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2568
2569         [Win] Fix a slew of simple clang-cl warnings.
2570         https://bugs.webkit.org/show_bug.cgi?id=195652
2571
2572         Reviewed by Don Olmstead.
2573
2574         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2575         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2576
2577 2019-03-12  Justin Fan  <justin_fan@apple.com>
2578
2579         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2580         https://bugs.webkit.org/show_bug.cgi?id=195518
2581         <rdar://problem/46322356>
2582
2583         Reviewed by Myles C. Maxfield.
2584
2585         * DumpRenderTree/DerivedSources-input.xcfilelist:
2586         * DumpRenderTree/DerivedSources-output.xcfilelist:
2587
2588 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2589
2590         Unreviewed, rolling out r242825.
2591         https://bugs.webkit.org/show_bug.cgi?id=195648
2592
2593         "Broke webkitpy tests with my change to
2594         lldb_dump_class_layout.py" (Requested by rmorisset on
2595         #webkit).
2596
2597         Reverted changeset:
2598
2599         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2600         classes with suspicious padding"
2601         https://bugs.webkit.org/show_bug.cgi?id=195573
2602         https://trac.webkit.org/changeset/242825
2603
2604 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2605
2606         [ews-build] Show status bubbles while the patch is waiting in queue
2607         https://bugs.webkit.org/show_bug.cgi?id=195618
2608
2609         Reviewed by Lucas Forschler.
2610
2611         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2612         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2613         enabled in initial deployment.
2614         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2615         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2616         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2617         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2618         (StatusBubble._build_bubbles_for_patch):
2619
2620 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2621
2622         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2623         https://bugs.webkit.org/show_bug.cgi?id=195573
2624
2625         Reviewed by Simon Fraser.
2626
2627         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2628
2629         * Scripts/dump-class-layout:
2630         (main):
2631         * lldb/lldb_dump_class_layout.py:
2632         (ClassLayout.__init__):
2633         (ClassLayout._compute_padding_recursive):
2634         (LLDBDebuggerInstance.dump_layout_for_classname):
2635         (LLDBDebuggerInstance):
2636         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2637         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2638
2639 2019-03-12  Chris Dumez  <cdumez@apple.com>
2640
2641         Device Orientation access permission should be denied unless explicitly granted by the client
2642         https://bugs.webkit.org/show_bug.cgi?id=195625
2643
2644         Reviewed by Youenn Fablet.
2645
2646         add API test coverage.
2647
2648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2649         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2650         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2651         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2652         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2653         (runDeviceOrientationTest):
2654         (TEST):
2655         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2656         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2657
2658 2019-03-12  Jer Noble  <jer.noble@apple.com>
2659
2660         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2661         https://bugs.webkit.org/show_bug.cgi?id=195137
2662         <rdar://problem/48810307>
2663
2664         Reviewed by Eric Carlson.
2665
2666         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2667         (TestWebKitAPI::TEST):
2668
2669 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2670
2671         [ews-build] Change urls from uat to production
2672         https://bugs.webkit.org/show_bug.cgi?id=195566
2673
2674         Reviewed by Lucas Forschler.
2675
2676         * BuildSlaveSupport/ews-app/ews/config.py:
2677         * BuildSlaveSupport/ews-build/events.py:
2678         * BuildSlaveSupport/ews-build/steps.py:
2679
2680 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2681
2682         [ews-build] change max_builds for local-worker to 1
2683         https://bugs.webkit.org/show_bug.cgi?id=195568
2684
2685         Reviewed by Lucas Forschler.
2686
2687         * BuildSlaveSupport/ews-build/loadConfig.py:
2688
2689 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2690
2691         Fix the build
2692
2693         * TestRunnerShared/spi/PencilKitTestSPI.h:
2694         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2695
2696 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2697
2698         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2699         https://bugs.webkit.org/show_bug.cgi?id=194131
2700
2701         Reviewed by Michael Catanzaro.
2702
2703         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2704         (uriChanged):
2705         (testUnfinishedSubresourceLoad):
2706         (serverCallback):
2707         (beforeAll):
2708
2709 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2710
2711         WTF::Expected should use std::addressof instead of operator&
2712         https://bugs.webkit.org/show_bug.cgi?id=195604
2713
2714         Reviewed by Myles Maxfield.
2715
2716         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2717         (TestWebKitAPI::Unique::Unique):
2718         (TestWebKitAPI::Unique::operator&):
2719         (TestWebKitAPI::TEST):
2720
2721 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2722
2723         Add Optional to Forward.h.
2724         https://bugs.webkit.org/show_bug.cgi?id=195586
2725
2726         Reviewed by Darin Adler.
2727
2728         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2729         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2730         Remove unnecessary includes from headers.
2731
2732 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2733
2734         Add testing API to hit-test and scroll overflow scrollers
2735         https://bugs.webkit.org/show_bug.cgi?id=195278
2736
2737         Reviewed by Antti Koivisto.
2738         
2739         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2740         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2741         
2742         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2743
2744         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2745         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2746         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2747         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2748         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2749         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2750         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2751         (WTR::enclosingScrollViewIncludingSelf):
2752         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2753
2754 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2755
2756         API test WebKit.RequestTextInputContext fails on iOS
2757         https://bugs.webkit.org/show_bug.cgi?id=195585
2758
2759         Reviewed by Wenson Hsieh and Simon Fraser.
2760
2761         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2762         (applyStyle):
2763         (TEST):
2764         Add a viewport, so that the coordinates match up on iOS.
2765         Scroll by moving the UIScrollView's contentOffset.
2766
2767 2019-03-11  Chris Dumez  <cdumez@apple.com>
2768
2769         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2770         https://bugs.webkit.org/show_bug.cgi?id=195506
2771         <rdar://problem/48733477>
2772
2773         Reviewed by Alex Christensen.
2774
2775         Add API test coverage.
2776
2777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2778
2779 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2780
2781         Adding myself to contributors.json
2782
2783         Unreviewed, addming myself to contributors.json .
2784
2785         * Scripts/webkitpy/common/config/contributors.json:
2786
2787 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2788
2789         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2790         https://bugs.webkit.org/show_bug.cgi?id=195511
2791         <rdar://problem/44873269>
2792
2793         Reviewed by Darin Adler.
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2796         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2797         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2798         (TEST_F):
2799
2800 2019-03-11  Chris Dumez  <cdumez@apple.com>
2801
2802         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2803         https://bugs.webkit.org/show_bug.cgi?id=195561
2804
2805         Reviewed by Youenn Fablet.
2806
2807         Make sure the JS in the test requests for permission to receive device orientation events.
2808
2809         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2810
2811 2019-03-11  Youenn Fablet  <youenn@apple.com>
2812
2813         Allow storage quota increase by default in WTR
2814         https://bugs.webkit.org/show_bug.cgi?id=195541
2815
2816         Reviewed by Geoffrey Garen.
2817
2818         Allow storage quota increase by default in WTR.
2819         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2820         Use this for tests that explicitly need cache increase.
2821
2822         Instead of increasing quota by 2, make sure the next request is
2823         granted by adding all given parameters.
2824
2825         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2826         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2827         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2828         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2829         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2830         * WebKitTestRunner/TestController.cpp:
2831         (WTR::TestController::setAllowStorageQuotaIncrease):
2832         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2833         * WebKitTestRunner/TestController.h:
2834         * WebKitTestRunner/TestInvocation.cpp:
2835         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2836         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2837         (WTR::TestController::cocoaResetStateToConsistentValues):
2838         (WTR::TestController::setAllowStorageQuotaIncrease):
2839         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2840         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2841         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2842
2843 2019-03-11  Xan Lopez  <xan@igalia.com>
2844
2845         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2846         https://bugs.webkit.org/show_bug.cgi?id=194147
2847
2848         Reviewed by Michael Saboff.
2849
2850         To make --32-bit work correctly on Linux/64bit we need to:
2851
2852         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2853         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2854         unfortunately CMake only allows us to do this during
2855         crosscompilation, which is overkill here.
2856         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2857         pkg-config detection module uses the x86 .pc files instead of the
2858         x86_64 ones.
2859         - Set the -m32 flags for the compiler.
2860
2861         * Scripts/webkitdirs.pm:
2862         (generateBuildSystemFromCMakeProject):
2863
2864 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2865
2866         Add MotionMark-1.1 plan file for run-benchmark script.
2867         https://bugs.webkit.org/show_bug.cgi?id=195481
2868
2869         Rubber-stamped by Darin Adler.
2870
2871         Run-benchmark script should support MontionMark-1.1.
2872
2873         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2874
2875 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2876
2877         [ews-app] Add support for submit-to-ews url
2878         https://bugs.webkit.org/show_bug.cgi?id=195477
2879
2880         Reviewed by Lucas Forschler.
2881
2882         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2883         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2884         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2885         * BuildSlaveSupport/ews-app/ews/urls.py:
2886         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2887
2888 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2889
2890         Unreviewed, rolling out r242688, r242643, r242624.
2891
2892         Caused multiple layout test failures and crashes on iOS and macOS.
2893
2894         Reverted changeset:
2895
2896         "requestAnimationFrame should execute before the next frame"
2897         https://bugs.webkit.org/show_bug.cgi?id=177484
2898         https://trac.webkit.org/changeset/242624/webkit
2899
2900         * Tracing/SystemTracePoints.plist:
2901
2902 2019-03-11  John Wilander  <wilander@apple.com>
2903
2904         Resource Load Statistics: Make it possible exclude localhost from classification
2905         https://bugs.webkit.org/show_bug.cgi?id=195474
2906         <rdar://problem/47520577>
2907
2908         Reviewed by Brent Fulgham.
2909
2910         This patch allows for localhost to be excluded from classification and
2911         treatment as a prevalent resource.
2912
2913         The WebKit Tools change adds a new function called
2914         testRunner.setStatisticsIsRunningTest() which can be used to control this
2915         behavior.
2916
2917         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2919         (WTR::TestRunner::setStatisticsIsRunningTest):
2920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::setStatisticsIsRunningTest):
2923         * WebKitTestRunner/TestController.h:
2924         * WebKitTestRunner/TestInvocation.cpp:
2925         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2926
2927 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2928
2929         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2930         https://bugs.webkit.org/show_bug.cgi?id=195560
2931
2932         Reviewed by Lucas Forschler.
2933
2934         * BuildSlaveSupport/ews-build/master.cfg:
2935
2936 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2937
2938         Unreviewed, rolling out r242698.
2939
2940         API test crashes on bots.
2941
2942         Reverted changeset:
2943
2944         "Add a WKContentRuleList variant that uses copied memory
2945         instead of mmap'd shared memory for class A containerized
2946         apps"
2947         https://bugs.webkit.org/show_bug.cgi?id=195511
2948         https://trac.webkit.org/changeset/242698
2949
2950 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         [WPE] Enable web process sandbox
2953         https://bugs.webkit.org/show_bug.cgi?id=195169
2954
2955         Reviewed by Daniel Bates.
2956
2957         * wpe/install-dependencies:
2958         * wpe/jhbuild.modules:
2959
2960 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2961
2962         [ews-app] Use port 17000 for worker communication
2963         https://bugs.webkit.org/show_bug.cgi?id=195558
2964
2965         Reviewed by Lucas Forschler.
2966
2967         * BuildSlaveSupport/ews-build/master.cfg:
2968
2969 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2970
2971         [ews-build] unit-tests fail when passwords.json is missing
2972         https://bugs.webkit.org/show_bug.cgi?id=195557
2973
2974         Reviewed by Lucas Forschler.
2975
2976         * BuildSlaveSupport/ews-build/loadConfig.py:
2977         (loadBuilderConfig):
2978         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2979         (ConfigDotJSONTest.test_configuration):
2980         * BuildSlaveSupport/ews-build/master.cfg:
2981
2982 2019-03-11  Truitt Savell  <tsavell@apple.com>
2983
2984         Unreviewed, rolling out r242702.
2985
2986         Broke High Sierra builders.
2987
2988         Reverted changeset:
2989
2990         "Add utility function to allow easy reverse range-based
2991         iteration of a container"
2992         https://bugs.webkit.org/show_bug.cgi?id=195542
2993         https://trac.webkit.org/changeset/242702
2994
2995 2019-03-11  Sam Weinig  <sam@webkit.org>
2996
2997         Add utility function to allow easy reverse range-based iteration of a container
2998         https://bugs.webkit.org/show_bug.cgi?id=195542
2999
3000         Reviewed by Antti Koivisto.
3001
3002         * TestWebKitAPI/CMakeLists.txt:
3003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3004         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3005         (TestWebKitAPI::TEST):
3006         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3007
3008 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3009
3010         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3011         https://bugs.webkit.org/show_bug.cgi?id=195511
3012         <rdar://problem/44873269>
3013
3014         Reviewed by Darin Adler.
3015
3016         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3017         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3018         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3019         (TEST_F):
3020
3021 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3022
3023         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3024         https://bugs.webkit.org/show_bug.cgi?id=195499
3025
3026         Reviewed by Darin Adler.
3027
3028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3029         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3030         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3031         (-[WKWebView synchronouslyFocusTextInputContext:]):
3032         (applyStyle):
3033         (applyIframe):
3034         (TEST):
3035         Add some tests for this SPI.
3036
3037 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3038
3039         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3040         https://bugs.webkit.org/show_bug.cgi?id=181151
3041
3042         Reviewed by Don Olmstead.
3043
3044         * TestWebKitAPI/CMakeLists.txt:
3045         * TestWebKitAPI/PlatformWin.cmake:
3046         Enable TestWTF RunLoop tests in all platforms.
3047
3048         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3049         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3050         (TestWebKitAPI::DerivedOneShotTimer::fired):
3051         (TestWebKitAPI::TEST):
3052         Only a few platforms support nested RunLoop.
3053
3054         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3055         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3056
3057 2019-03-10  David Quesada  <david_quesada@apple.com>
3058
3059         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3060         https://bugs.webkit.org/show_bug.cgi?id=152480
3061
3062         Reviewed by Chris Dumez.
3063
3064         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3065         there are no additional references to the process pool besides the one held by
3066         the download, waits for the download to finish (in the sense that the
3067         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3068         measure, also check that the process pool has been deallocated at the end of the
3069         test. The test wouldn't be meaningful if the process pool were still alive.
3070
3071         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3072         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3073         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3074             The download will be canceled because the delegate does not implement the
3075             method to decide the download's destination, so this is where we know the
3076             DownloadProxyMap is done with the DownloadProxy.
3077         (TEST):
3078
3079 2019-03-08  Chris Dumez  <cdumez@apple.com>
3080
3081         Add support for Device Orientation / Motion permission API
3082         https://bugs.webkit.org/show_bug.cgi?id=195329
3083         <rdar://problem/47645367>
3084
3085         Reviewed by Geoffrey Garen.
3086
3087         Add test infrastructure to help test the Device Orientation / Motion permission API.
3088
3089         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3090         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3091         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3092         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3095         (WTR::TestController::createWebViewWithOptions):
3096         (WTR::TestController::resetStateToConsistentValues):
3097         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3098         * WebKitTestRunner/TestController.h:
3099         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3100         * WebKitTestRunner/TestInvocation.cpp:
3101         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3102
3103 2019-03-08  Saam barati  <sbarati@apple.com>
3104
3105         Add a compare-results script to compare benchmark results
3106         https://bugs.webkit.org/show_bug.cgi?id=195486
3107         <rdar://problem/48723397>
3108
3109         Reviewed by Geoffrey Garen.
3110
3111         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3112         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3113         to extend it to learn about our other benchmarks.
3114
3115         * Scripts/compare-results: Added.
3116         (readJSONFile):
3117         (detectJetStream2):
3118         (JetStream2Results):
3119         (detectSpeedometer2):
3120         (Speedometer2Results):
3121         (detectPLT5):
3122         (PLT5Results):
3123         (detectBenchmark):
3124         (biggerIsBetter):
3125         (ttest):
3126         (getOptions):
3127         (main):
3128
3129 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3130
3131         Ensure old tab state is cleared between iterations of run-benchmark
3132         https://bugs.webkit.org/show_bug.cgi?id=195393
3133         <rdar://problem/46885583>
3134
3135         Reviewed by Dewei Zhu.
3136
3137         a) ensure the default to restore state is not set
3138         b) terminate Safari correctly
3139         c) Set the system default to ignore Persistent State in Safari
3140
3141         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3142         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3143         (OSXBrowserDriver.prepare_env): 
3144         (OSXBrowserDriver.restore_env):
3145         (OSXBrowserDriver.close_browsers):
3146         (OSXBrowserDriver._terminate_processes):
3147         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3148         (OSXChromeDriver):
3149         (OSXChromeCanaryDriver):
3150         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3151         (OSXFirefoxDriver):
3152         (OSXFirefoxNightlyDriver):
3153         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3154         (OSXSafariDriver):
3155         (OSXSafariDriver.prepare_env):
3156
3157 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3158
3159         [GTK] Several InputMethodFilter tests are failing
3160         https://bugs.webkit.org/show_bug.cgi?id=195408
3161
3162         Reviewed by Carlos Garcia Campos.
3163
3164         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3165         Regressed in r241751.
3166         Hexadecimal values of keycodes are expressed now in upper letters.
3167         Composited characters should be cast to UTF8 strings.
3168
3169         (TestWebKitAPI::TEST):
3170
3171 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3172
3173         [GTK] Make Tools/gtkdoc python3 compatible
3174         https://bugs.webkit.org/show_bug.cgi?id=195359
3175
3176         Reviewed by Carlos Garcia Campos.
3177
3178         * gtkdoc/generate-gtkdoc:
3179         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3180         work with Python 2 and 3.
3181         (get_gtkdoc_module_paths):
3182         The iteritems() was removed in Python 3, so let's use items() that's
3183         available in Python 2 and 3.
3184         (get_generator_for_config):
3185         * gtkdoc/gtkdoc.py:
3186         (GTKDoc._run_command):
3187         The sys.stdout.write() is expecting str in Python 3 and not bytes
3188         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3189         for passing the bytes there.
3190
3191 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3192
3193         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3194         https://bugs.webkit.org/show_bug.cgi?id=195346
3195         <rdar://problem/48667048>
3196
3197         Unreviewed build fix for clang-cl.
3198
3199         * DumpRenderTree/win/DumpRenderTree.cpp:
3200         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3201
3202 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3203
3204         requestAnimationFrame should execute before the next frame
3205         https://bugs.webkit.org/show_bug.cgi?id=177484
3206
3207         Reviewed by Simon Fraser.
3208
3209         Add trace points for the page RenderingUpdate.
3210
3211         * Tracing/SystemTracePoints.plist:
3212
3213 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3214
3215         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3216         https://bugs.webkit.org/show_bug.cgi?id=195353
3217         <rdar://problem/48626394>
3218
3219         Reviewed by Simon Fraser.
3220
3221         * WebKitTestRunner/ios/TestControllerIOS.mm:
3222         (WTR::TestController::platformResetPreferencesToConsistentValues):
3223
3224 2019-03-07  John Wilander  <wilander@apple.com>
3225
3226         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3227         https://bugs.webkit.org/show_bug.cgi?id=195383
3228         <rdar://problem/48570136>
3229
3230         Reviewed by Brent Fulgham.
3231
3232         This patch adds test infrastructure to purge only script-accessible cookies,
3233         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3234
3235         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3237         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3238         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3239         * WebKitTestRunner/TestController.cpp:
3240         (WTR::TestController::statisticsDeleteCookiesForHost):
3241         * WebKitTestRunner/TestController.h:
3242         * WebKitTestRunner/TestInvocation.cpp:
3243         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3244
3245 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3246
3247         Unreviewed, rolling out r242354.
3248         https://bugs.webkit.org/show_bug.cgi?id=195402
3249
3250         breaks layout tests in all configurations (Requested by
3251         zdobersek on #webkit).
3252
3253         Reverted changeset:
3254
3255         "[WPE] Enable web process sandbox"
3256         https://bugs.webkit.org/show_bug.cgi?id=195169
3257         https://trac.webkit.org/changeset/242354
3258
3259 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3260
3261         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3262         https://bugs.webkit.org/show_bug.cgi?id=195346
3263
3264         Reviewed by Fujii Hironori.
3265
3266         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3267         (TestWebKitAPI::TEST):
3268         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3269
3270         * DumpRenderTree/win/DumpRenderTree.cpp:
3271         (findFontFallback):
3272         (addFontFallbackIfPresent):
3273         (removeFontFallbackIfPresent):
3274         (main):
3275         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3276         (TestWebKitAPI::Util::moduleDirectory):
3277         (TestWebKitAPI::Util::createInjectedBundlePath):
3278         Use wchar helpers as needed.
3279
3280 2019-03-06  Rob Buis  <rbuis@igalia.com>
3281
3282         Consider supporting the `referrerpolicy` attribute.
3283         https://bugs.webkit.org/show_bug.cgi?id=179053
3284
3285         Reviewed by Darin Adler.
3286
3287         Add a runtime flag for referrerpolicy attribute.
3288
3289         * DumpRenderTree/mac/DumpRenderTree.mm:
3290         (enableExperimentalFeatures):
3291
3292 2019-03-05  Daniel Bates  <dabates@apple.com>
3293
3294         Update expected API test result following r242379
3295         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3296
3297         Update expected x-coordinate of selection rect now that the left padding of
3298         a textarea is sized in ems (so dependent on the font size) just like the left
3299         padding of a text field.
3300
3301         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3302         (TestWebKitAPI::TEST):
3303
3304 2019-03-05  David Quesada  <david_quesada@apple.com>
3305
3306         [WK2] It should be possible to follow links with 'download' attributes
3307         https://bugs.webkit.org/show_bug.cgi?id=195145
3308         rdar://problem/48462642
3309
3310         Reviewed by Alex Christensen.
3311
3312         Add a unit test to verify that activating links with 'download' attributes now
3313         navigates to the linked resource, rather than starts downloading it. Add another
3314         to verify that it is still possible to explicitly download the link via the
3315         'Download' navigation action policy.
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3318         (-[DownloadAttributeTestDelegate init]):
3319         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3320         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3321         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3322         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3323         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3324         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3325         (TEST):
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::TestController::decidePolicyForNavigationAction):
3328         * WebKitTestRunner/TestController.h:
3329
3330 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3331
3332         [Curl] Implement Cookie Accept Policy.
3333         https://bugs.webkit.org/show_bug.cgi?id=191645
3334
3335         Reviewed by Fujii Hironori.
3336
3337         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3338         (TestWebKitAPI::Curl::TEST_F):
3339
3340 2019-03-05  Youenn Fablet  <youenn@apple.com>
3341
3342         Rename requestCacheStorageSpace to requestStorageSpace
3343         https://bugs.webkit.org/show_bug.cgi?id=195282
3344
3345         Reviewed by Chris Dumez.
3346
3347         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3348         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3349         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3350
3351 2019-03-05  Brady Eidson  <beidson@apple.com>
3352
3353         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3354         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3355
3356         Reviewed by Tim Horton.
3357
3358         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3359         different directory into that same WKWebView should work.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3363
3364 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3365
3366         Add WeakHashSet
3367         https://bugs.webkit.org/show_bug.cgi?id=195152
3368
3369         Reviewed by Antti Koivisto.
3370
3371         Added tests for WeakHashSet.
3372
3373         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3374         (TestWebKitAPI::Base::Base): Moved.
3375         (TestWebKitAPI::Derived::foo): Moved.
3376         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3377         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3378         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3379         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3380
3381 2019-03-04  Chris Dumez  <cdumez@apple.com>
3382
3383         Do not share WebProcesses between private and regular sessions
3384         https://bugs.webkit.org/show_bug.cgi?id=195189
3385         <rdar://problem/48421064>
3386
3387         Reviewed by Alex Christensen.
3388
3389         Add API test coverage.
3390
3391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3392         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3393
3394 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3395
3396         [WPE] Enable web process sandbox
3397         https://bugs.webkit.org/show_bug.cgi?id=195169
3398
3399         Reviewed by Daniel Bates.
3400
3401         * wpe/install-dependencies:
3402         * wpe/jhbuild.modules:
3403
3404 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3405
3406         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3407         https://bugs.webkit.org/show_bug.cgi?id=195206
3408
3409         Reviewed by Žan Doberšek.
3410
3411         Add a new test case.
3412
3413         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3414         (testJSCClass):
3415
3416 2019-03-04  Charlie Turner  <cturner@igalia.com>
3417
3418         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3419         https://bugs.webkit.org/show_bug.cgi?id=194898
3420
3421         Reviewed by Žan Doberšek.
3422
3423         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3424         a GCC extension that permits arithmetic on void* pointer. Inline
3425         the macro until this issue is fixed upstream.
3426
3427 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3428
3429         Rid the world of WK_API_ENABLED
3430         https://bugs.webkit.org/show_bug.cgi?id=195263
3431
3432         Reviewed by Dan Bernstein.
3433
3434         List of changed files elided because it's useless.
3435
3436 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3437
3438         Unreviewed follow-up to r242292.
3439
3440         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3441
3442         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3443         (TestWebKitAPI::testStrip): Renamed from strip.
3444         (TestWebKitAPI::TEST):
3445
3446 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3447
3448         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3449
3450         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3451         and bug #194272 for details.
3452
3453         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3454
3455 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3456
3457         Remove some more unused 32-bit code
3458         https://bugs.webkit.org/show_bug.cgi?id=195255
3459
3460         Reviewed by Darin Adler.
3461
3462         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3463         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3464         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3465         (NPP_New):
3466         (NPP_HandleEvent):
3467         (handleEventCarbon): Deleted.
3468
3469 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3470
3471         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3472
3473         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3474         (TestWebKitAPI::TEST):
3475
3476 2019-03-01  Darin Adler  <darin@apple.com>
3477
3478         Finish removing String::format
3479         https://bugs.webkit.org/show_bug.cgi?id=194893
3480
3481         Reviewed by Daniel Bates.
3482 '
3483         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3484
3485 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3486
3487         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3488         https://bugs.webkit.org/show_bug.cgi?id=195229
3489         <rdar://problem/48520362>
3490
3491         Reviewed by Chris Dumez.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3494         (TEST):
3495
3496 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3497
3498         Add a system trace scope for event region building
3499         https://bugs.webkit.org/show_bug.cgi?id=195226
3500
3501         Reviewed by Jon Lee.
3502
3503         This trace scope measures the time spend converting element rects into Region objects,
3504         which can be large on some pages.
3505
3506         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3507
3508         * Tracing/SystemTracePoints.plist:
3509
3510 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3511
3512         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3513         https://bugs.webkit.org/show_bug.cgi?id=194612
3514
3515         Reviewed by Alex Christensen.
3516
3517         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3518         Just test the new string-processing function and don't touch the actual environment.
3519         (Test cases are all as before, but based on operator== instead of strcmp.)
3520
3521 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [ews-app] Update primary keys for handling multiple Buildbot instances
3524         https://bugs.webkit.org/show_bug.cgi?id=195120
3525
3526         Reviewed by Stephanie Lewis.
3527
3528         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3529         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3530         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3531
3532         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3533         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3534         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3535         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3536         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3537         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3538
3539 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3540
3541         [WinCairo] Enable service worker
3542         https://bugs.webkit.org/show_bug.cgi?id=188318
3543
3544         Reviewed by Youenn Fablet.
3545
3546         * DumpRenderTree/DumpRenderTreePrefix.h:
3547         * TestWebKitAPI/PlatformWin.cmake:
3548         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3549         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3550         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3551
3552 2019-03-01  Justin Fan  <justin_fan@apple.com>
3553
3554         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3555         https://bugs.webkit.org/show_bug.cgi?id=195191
3556
3557         Rubber-stamped by Dean Jackson.
3558
3559         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3560
3561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3562
3563 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3564
3565         Unreviewed, fix lldb webkitpy tests
3566         https://bugs.webkit.org/show_bug.cgi?id=194375
3567
3568         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3569
3570         * lldb/lldb_webkit.py:
3571         (WTFStringImplProvider.is_8bit):
3572
3573 2019-02-28  David Quesada  <david_quesada@apple.com>
3574
3575         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3576         https://bugs.webkit.org/show_bug.cgi?id=195121
3577         rdar://problem/48450302
3578
3579         Reviewed by Alex Christensen.
3580
3581         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3582         configurations where the 'download' attribute is absent, blank, or populated
3583         with a filename, and where the anchor element is same-origin or cross-origin
3584         (meaning the 'download' attribute shouldn't be honored).
3585
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3588         (-[NavigationActionTestDelegate init]):
3589         (-[NavigationActionTestDelegate navigationAction]):
3590         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3591         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3592         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3593         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3594         (TEST):
3595
3596 2019-02-28  Antoine Quint  <graouts@apple.com>
3597
3598         Enable the Pointer Events runtime flag by default
3599         https://bugs.webkit.org/show_bug.cgi?id=195156
3600
3601         Reviewed by Dean Jackson.
3602
3603         * DumpRenderTree/mac/DumpRenderTree.mm:
3604         (enableExperimentalFeatures):
3605
3606 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3607
3608         Several PasteImage API tests are flaky
3609         https://bugs.webkit.org/show_bug.cgi?id=195160
3610
3611         Reviewed by Tim Horton.
3612
3613         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3614         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3615         listening for a "load" event after image load is already complete.
3616
3617         To address this, make these tests first register a "load" event handler, then run script to insert an image
3618         element into the document, and finally wait until the load event is observed before checking image size.
3619
3620         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3621
3622 2019-02-28  Chris Dumez  <cdumez@apple.com>
3623
3624         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3625         https://bugs.webkit.org/show_bug.cgi?id=195107
3626
3627         Reviewed by Alex Christensen.
3628
3629         Give some time for the zoom level to get restored.
3630
3631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3632
3633 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3634
3635         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3636         https://bugs.webkit.org/show_bug.cgi?id=194958
3637
3638         Reviewed by Geoffrey Garen.
3639
3640         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3641         (TEST):
3642
3643 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3644
3645         [ews-app] Update method to save build to handle builder_display_name
3646         https://bugs.webkit.org/show_bug.cgi?id=195047
3647
3648         Reviewed by Dewei Zhu.
3649
3650         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3651         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3652
3653 2019-02-28  Justin Fan  <justin_fan@apple.com>
3654
3655         [Web GPU] Enable Web GPU only on 64-bit
3656         https://bugs.webkit.org/show_bug.cgi?id=195139
3657
3658         Because Metal is only supported on 64 bit apps.
3659
3660         Unreviewed build fix.
3661
3662         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3663
3664 2019-02-27  Youenn Fablet  <youenn@apple.com>
3665
3666         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3667         https://bugs.webkit.org/show_bug.cgi?id=194959
3668
3669         Reviewed by Chris Dumez.
3670
3671         Spin loop until getting the condition to remove flakiness.
3672
3673         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3674
3675 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3676
3677         [ews-build] Buildbot should include builder_display_name in the build events
3678         https://bugs.webkit.org/show_bug.cgi?id=195045
3679
3680         Reviewed by Dewei Zhu.
3681
3682         * BuildSlaveSupport/ews-build/events.py:
3683         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3684         buildername to builder_name to be consistent in naming style.
3685         (Events.buildFinished): Ditto.
3686
3687 2019-02-27  Chris Dumez  <cdumez@apple.com>
3688
3689         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3690         https://bugs.webkit.org/show_bug.cgi?id=194480
3691
3692         Reviewed by Brady Eidson.
3693
3694         Update existing API test to make it more likely to reproduce the issue.
3695
3696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3697
3698 2019-02-27  Brady Eidson  <beidson@apple.com>
3699
3700         Universal links from Google search results pages don't open the app.
3701         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3702
3703         Reviewed by Geoffrey Garen.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3706         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3707         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3708         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3709
3710 2019-02-27  Chris Dumez  <cdumez@apple.com>
3711
3712         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3713         https://bugs.webkit.org/show_bug.cgi?id=195102
3714
3715         Reviewed by Geoffrey Garen.
3716
3717         If the number of processes is not yet what we expect, wait a bit and check again to give
3718         processes some time to exit.
3719
3720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3721
3722 2019-02-27  Chris Dumez  <cdumez@apple.com>
3723
3724         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3725         https://bugs.webkit.org/show_bug.cgi?id=194545
3726
3727         Reviewed by Brady Eidson.
3728
3729         Make sure the test navigates forward and then back only once. Previously, navigating
3730         back would trigger a navigation again in a timer.
3731
3732         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3733
3734 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3735
3736         High Sierra Debug JSC test queue should use faster hardware
3737         https://bugs.webkit.org/show_bug.cgi?id=194603
3738
3739         Rubber-stamped by Alexey Proskuryakov.
3740
3741         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3742
3743         * BuildSlaveSupport/build.webkit.org-config/config.json:
3744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3745         (BubbleQueueServer):
3746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3747         (WebKitBuildbot):
3748         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3749         * QueueStatusServer/config/queues.py:
3750         * Scripts/webkitpy/common/config/ews.json:
3751         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3752         (test_ews_name):
3753
3754 2019-02-27  John Wilander  <wilander@apple.com>
3755
3756         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3757         https://bugs.webkit.org/show_bug.cgi?id=195071
3758         <rdar://problem/48417690>
3759
3760         Reviewed by Alex Christensen and Brent Fulgham.
3761
3762         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3763         (TestWebKitAPI::createURL):
3764             Convenience function.
3765         (TestWebKitAPI::TEST):
3766             WebCore::AdClickAttribution now takes a URL when creating Source and
3767             Destination.
3768         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3769         (TestWebKitAPI::TEST):
3770             WebCore::AdClickAttribution now takes a URL when creating Source and
3771             Destination.
3772
3773 2019-02-27  Antoine Quint  <graouts@apple.com>
3774
3775         Support Pointer Events on macOS
3776         https://bugs.webkit.org/show_bug.cgi?id=195008
3777         <rdar://problem/47454419>
3778
3779         Reviewed by Dean Jackson.
3780
3781         * DumpRenderTree/mac/DumpRenderTree.mm:
3782         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3784
3785 2019-02-26  Mark Lam  <mark.lam@apple.com>
3786
3787         Remove remaining poisoning code.
3788         https://bugs.webkit.org/show_bug.cgi?id=194138
3789
3790         Reviewed by Saam Barati.
3791
3792         * TestWebKitAPI/CMakeLists.txt:
3793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3794         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3795         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3796         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3797         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3798         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3799         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3800
3801 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3802
3803         Move ephemeral local storage from WebProcess to UIProcess
3804         https://bugs.webkit.org/show_bug.cgi?id=195074
3805         <rdar://problem/47937975>
3806
3807         Reviewed by Geoff Garen.
3808
3809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3810
3811 2019-02-20  Jer Noble  <jer.noble@apple.com>
3812
3813         [Cocoa] Media elements will restart network buffering just before suspending
3814         https://bugs.webkit.org/show_bug.cgi?id=193691
3815
3816         Reviewed by Eric Carlson.
3817
3818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3819         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3820         (TEST):
3821
3822 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3823
3824         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3825         https://bugs.webkit.org/show_bug.cgi?id=191652
3826
3827         Reviewed by Alex Christensen.
3828
3829         Fix WinCairo MiniBrowser behavior of authentication dialog.
3830
3831         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3832         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3833
3834 2019-02-26  Youenn Fablet  <youenn@apple.com>
3835
3836         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3837         https://bugs.webkit.org/show_bug.cgi?id=195028
3838         <rdar://problem/48243733>
3839
3840         Reviewed by Eric Carlson.
3841
3842         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3843
3844 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3845
3846         [WPE] Add API for webview background color configuration
3847         https://bugs.webkit.org/show_bug.cgi?id=192305
3848
3849         Reviewed by Michael Catanzaro.
3850
3851         * MiniBrowser/wpe/main.cpp:
3852         (main): Add a new option to configure the webview background
3853         color. Example: --bg-color=transparent.
3854         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3855         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3856         (beforeAll): Ditto.
3857
3858 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3859
3860         scalableNativeWebpageParameters() is not preserved on new page navigation.
3861         https://bugs.webkit.org/show_bug.cgi?id=194892
3862         <rdar://problem/47538280>
3863
3864         Reviewed by Wenson Hsieh.
3865         
3866         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3867
3868         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3869         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3870         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3871         (WTR::UIScriptController::allowsViewportShrinkToFit):
3872         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3873         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3874         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3875         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3876         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3877         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3878
3879 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3880
3881         [ews-app] Add model for handling multiple Buildbot instances
3882         https://bugs.webkit.org/show_bug.cgi?id=194863
3883
3884         Reviewed by Stephanie Lewis.
3885
3886         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3887
3888 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3889
3890         [ews-app] Remove BuilderMapping table
3891         https://bugs.webkit.org/show_bug.cgi?id=194961
3892
3893         Reviewed by Stephanie Lewis.
3894
3895         Store builder name directly in build table, instead of having a separate
3896         table for it.
3897
3898         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3899         * BuildSlaveSupport/ews-app/ews/models/build.py:
3900         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3901         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3902
3903 2019-02-25  John Wilander  <wilander@apple.com>
3904
3905         Introduce and adopt new class RegistrableDomain for eTLD+1
3906         https://bugs.webkit.org/show_bug.cgi?id=194791
3907         <rdar://problem/48179240>
3908
3909         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3910
3911         This patch adds an API test and replaces two instances of
3912         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3913
3914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3915         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3916         (TestWebKitAPI::TEST):
3917             Changed two strings to make sure the registrable domains are still considered
3918             invalid and pass the test.
3919         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3920         (TestWebKitAPI::TEST):
3921         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3922         (WTR::InjectedBundle::didReceiveMessageToPage):
3923
3924 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3925
3926         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3927         https://bugs.webkit.org/show_bug.cgi?id=195001
3928
3929         Reviewed by Carlos Garcia Campos.
3930
3931         API version 1.0 always includes the functionality previously guarded with
3932         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3933         unconditionally.
3934
3935         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3936         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3937         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3938         (WebViewTest::showInWindow): Ditto.
3939         (WebViewTest::hideView): Ditto.
3940         * wpe/backends/HeadlessViewBackend.cpp:
3941         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3942         * wpe/backends/ViewBackend.cpp:
3943         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3944         * wpe/backends/WindowViewBackend.cpp:
3945         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3946         WPE_BACKEND_CHECK_VERSION().
3947         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3948
3949 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3950
3951         [Flatpak] Add support for flatpak > 1.1.2
3952         https://bugs.webkit.org/show_bug.cgi?id=194088
3953
3954         Flatpak 1.2 is now out so we need to support that
3955         version now.
3956
3957         Reviewed by Michael Catanzaro.
3958
3959         * flatpak/flatpakutils.py:
3960         (check_flatpak):
3961         (FlatpakPackages.__init__):
3962         (FlatpakPackages.__detect_packages):
3963         (FlatpakPackages.__detect_packages.in):
3964         (FlatpakRepos.update):
3965
3966 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3967
3968         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3969         https://bugs.webkit.org/show_bug.cgi?id=194998
3970
3971         Reviewed by Carlos Garcia Campos.
3972
3973         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3974         to a Git checkout and using the latest commit containing various fixes
3975         and improvements.
3976
3977 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3978
3979         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3980         https://bugs.webkit.org/show_bug.cgi?id=194981
3981
3982         Reviewed by Žan Doberšek.
3983
3984         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3985         (TestWebKitAPI::TEST):
3986
3987 2019-02-23  Keith Miller  <keith_miller@apple.com>
3988
3989         Add new mac target numbers
3990         https://bugs.webkit.org/show_bug.cgi?id=194955
3991
3992         Reviewed by Tim Horton.
3993
3994         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3995         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3996         * MiniBrowser/Configurations/Base.xcconfig:
3997         * TestWebKitAPI/Configurations/Base.xcconfig:
3998         * WebKitTestRunner/Configurations/Base.xcconfig:
3999
4000 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4001
4002         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4003         https://bugs.webkit.org/show_bug.cgi?id=194846
4004
4005         Reviewed by Don Olmstead.
4006
4007         Added _search_paths() and _port_specific_expectations_files() for
4008         WinCairoPort.
4009
4010         * Scripts/webkitpy/port/win.py:
4011         (WinCairoPort.default_baseline_search_path):
4012         (WinCairoPort):
4013         (WinCairoPort._port_specific_expectations_files):
4014         (WinCairoPort._search_paths):
4015
4016 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4017
4018         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4019         https://bugs.webkit.org/show_bug.cgi?id=194963
4020
4021         Reviewed by Dean Jackson.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4024         Do a `contains` check instead of `equals`, because in debug builds we
4025         put the GraphicsLayer pointer in a prefix.
4026
4027 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4028
4029         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4030         https://bugs.webkit.org/show_bug.cgi?id=194873
4031         <rdar://problem/46701974>
4032
4033         Reviewed by Tim Horton.
4034
4035         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4036
4037         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4038         (WTR::UIScriptController::menuRect const):
4039         (WTR::UIScriptController::isShowingMenu const):
4040         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4041         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4042         (WTR::UIScriptController::menuRect const):
4043
4044         Add a function to query the bounds of the callout menu in content coordinates.
4045
4046         (WTR::UIScriptController::isShowingMenu const):
4047
4048         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4049
4050         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4051         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4052         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4053         (WTR::UIScriptController::rectForMenuAction const):
4054         (WTR::UIScriptController::menuRect const):
4055         (WTR::UIScriptController::isShowingMenu const):
4056         (WTR::findViewInHierarchyOfType): Deleted.
4057
4058 2019-02-22  Chris Dumez  <cdumez@apple.com>
4059
4060         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4061         https://bugs.webkit.org/show_bug.cgi?id=194954
4062         <rdar://problem/48127957>
4063
4064         Reviewed by Alex Christensen.
4065
4066         Add API test coverage.
4067
4068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4069         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4070         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4071         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4072
4073 2019-02-22  Chris Dumez  <cdumez@apple.com>
4074
4075         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4076         https://bugs.webkit.org/show_bug.cgi?id=194924
4077         <rdar://problem/48216125>
4078
4079         Reviewed by Geoffrey Garen.
4080
4081         Add API test coverage.
4082
4083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4084
4085 2019-02-22  Chris Dumez  <cdumez@apple.com>
4086
4087         Unreviewed, disable API test added in r241928 on iOS.
4088
4089         The cache is not enabled on devices with less than 3GB of RAM.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4092
4093 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4094
4095         Hardcode Visual Viewports on everywhere except iOS WK1
4096         https://bugs.webkit.org/show_bug.cgi?id=194928
4097
4098         Reviewed by Zalan Bujtas.
4099
4100         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4101         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4102         set it to false. The setting has shipped for several years and there's no need to turn
4103         it off now.
4104
4105         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4106         Visual Viewports are not enabled.
4107         
4108         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4109         that only runs in WK2
4110
4111         * MiniBrowser/mac/SettingsController.h:
4112         * MiniBrowser/mac/SettingsController.m:
4113         (-[SettingsController init]):
4114         (-[SettingsController _populateMenu]):
4115         (-[SettingsController validateMenuItem:]):
4116         (-[SettingsController visualViewportEnabled]): Deleted.
4117         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4118         * MiniBrowser/mac/WK1BrowserWindowController.m:
4119         (-[WK1BrowserWindowController didChangeSettings]):
4120         * MiniBrowser/mac/WK2BrowserWindowController.m:
4121         (-[WK2BrowserWindowController didChangeSettings]):
4122
4123 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4124
4125         Discard cached processes when clearing website data store
4126         https://bugs.webkit.org/show_bug.cgi?id=194894
4127
4128         Reviewed by Chris Dumez.
4129
4130         Added a test case.
4131
4132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4133         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4134
4135 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4136
4137         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4138         https://bugs.webkit.org/show_bug.cgi?id=194914
4139         <rdar://problem/47586889>
4140
4141         Reviewed by Geoffrey Garen.
4142
4143         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4144         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4145         (TEST):
4146         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4147
4148 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4149
4150         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4151         <https://webkit.org/b/194761>
4152
4153         Reviewed by Myles Maxfield.
4154
4155         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4156         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4157         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4158         to use ARC-compliant cast.
4159         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4160         ARC-compliant cast.
4161         (WTR::installFakeHelvetica): Log `error` to console if
4162         CTFontManagerRegisterFontsForURL() fails, but only on supported
4163         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4164         Call CFRelease() on `error` to fix the leak.  Update to use
4165         ARC-compliant cast.
4166         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4167         cast.
4168
4169 2019-02-21  Chris Dumez  <cdumez@apple.com>
4170
4171         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4172         https://bugs.webkit.org/show_bug.cgi?id=194481
4173
4174         Reviewed by Alex Christensen.
4175
4176         Give the processes a chance to shutdown and wait until we reached the expected number
4177         of processes.
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4180
4181 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4182
4183         Fix the macOS build
4184
4185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4186
4187 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4188
4189         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4192         I am a backwards.
4193
4194 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4195
4196         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4199         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4200         We could force on UI-side compositing, but I feel like the test might be more
4201         valuable exercising the normal path on each platform (though the original
4202         bug was also UI-side specific). Though we can't validate that the overlay
4203         layer was installed successfully, there are layout tests that do that.
4204
4205 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4206
4207         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4208         https://bugs.webkit.org/show_bug.cgi?id=194845
4209         <rdar://problem/47944579>
4210
4211         Reviewed by Antti Koivisto.
4212
4213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4215
4216 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4217
4218         [LFC][Floats] Add support for placing formatting roots in-between floats.
4219         https://bugs.webkit.org/show_bug.cgi?id=194902
4220
4221         Reviewed by Antti Koivisto.
4222
4223         * LayoutReloaded/misc/LFC-passing-tests.txt:
4224
4225 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4226
4227         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4228         https://bugs.webkit.org/show_bug.cgi?id=194901
4229
4230         Unreviewed build fix.
4231
4232         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4233         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4234         WPEBackend-fdo-0.1 as library name.
4235
4236 2019-02-21  Rob Buis  <rbuis@igalia.com>
4237
4238         Update MIME type parser
4239         https://bugs.webkit.org/show_bug.cgi?id=180526
4240
4241         Reviewed by Darin Adler.
4242
4243         Add tests involving leading and trailing whitespace, non-token
4244         characters and quoted strings.
4245
4246         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4247         (TestWebKitAPI::TEST):
4248
4249 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4250
4251         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4252         https://bugs.webkit.org/show_bug.cgi?id=194884
4253
4254         Reviewed by Michael Catanzaro.
4255
4256         * PlatformWin.cmake:
4257
4258 2019-02-20  Chris Dumez  <cdumez@apple.com>
4259
4260         Add API test for <rdar://problem/47471222>
4261         https://bugs.webkit.org/show_bug.cgi?id=194847
4262
4263         Reviewed by Alex Christensen.
4264
4265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4266
4267 2019-02-20  Chris Dumez  <cdumez@apple.com>
4268
4269         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4270         https://bugs.webkit.org/show_bug.cgi?id=194872
4271         <rdar://problem/47924500>
4272
4273         Reviewed by Alex Christensen.
4274
4275         Add API test coverage.
4276
4277         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4278
4279 2019-02-20  Jer Noble  <jer.noble@apple.com>
4280
4281         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4282         https://bugs.webkit.org/show_bug.cgi?id=191332
4283
4284         Reviewed by Dean Jackson.
4285
4286         * Scripts/git-is-in-range: Added.
4287
4288 2019-02-20  Andy Estes  <aestes@apple.com>
4289
4290         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4291         https://bugs.webkit.org/show_bug.cgi?id=194869
4292
4293         Rubber-stamped by Jer Noble.
4294
4295         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4296         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4297         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4298         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4300         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4301
4302 2019-02-20  Chris Dumez  <cdumez@apple.com>
4303
4304         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4305         https://bugs.webkit.org/show_bug.cgi?id=194857
4306         <rdar://problem/47759323>
4307
4308         Reviewed by Alex Christensen.
4309
4310         Add API test coverage.
4311
4312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4313
4314 2019-02-20  Chris Dumez  <cdumez@apple.com>
4315
4316         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4317         https://bugs.webkit.org/show_bug.cgi?id=194829
4318         <rdar://problem/47889906>
4319
4320         Reviewed by Alexey Proskuryakov.
4321
4322         Every time the TestOptions were changing we were creating both a new Web view and
4323         a new WKContext, which would start a new Network process. In most cases, we only
4324         need to contruct a new Web view and we do can keep reusing the same WKContext.
4325         This patch implements this optimization and thus avoids spinning a lot of new
4326         Network processes while running the layout tests.
4327
4328         * WebKitTestRunner/TestController.cpp:
4329         (WTR::TestController::generateContextConfiguration const):
4330         (WTR::TestController::generatePageConfiguration):
4331         (WTR::TestController::createWebViewWithOptions):
4332         (WTR::TestController::resetPreferencesToConsistentValues):
4333         (WTR::updateTestOptionsFromTestHeader):
4334         * WebKitTestRunner/TestController.h:
4335         * WebKitTestRunner/TestOptions.h:
4336         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4337         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4338         (WTR::TestOptions::hasSameInitializationOptions const):
4339         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4340         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4341         (WTR::TestController::platformAddTestOptions const):
4342
4343 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4344
4345         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4346         https://bugs.webkit.org/show_bug.cgi?id=167941
4347
4348         Reviewed by Carlos Garcia Campos.
4349
4350         * MiniBrowser/gtk/main.c:
4351         (filterSavedCallback): Added.
4352         (main): Support loading a JSON rule set file for content filtering.
4353         * MiniBrowser/wpe/main.cpp:
4354         (filterSavedCallback): Added.
4355         (main): Support loading a JSON rule set file for content filtering.
4356         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4357         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4358         (WTF::derefGPtr): Ditto.
4359         (testEmptyStore):
4360         (testSaveInvalidFilter):
4361         (testSaveLoadFilter):
4362         (testSavedFilterIdentifierMatch):
4363         (testRemoveFilter):
4364         (testSaveMultipleFilters):
4365         (testSaveFilterFromFile):
4366         (testFilterPersistence):
4367         (beforeAll):
4368         (afterAll):
4369