Nixed the defunct chromium folder from DumpRenderTree
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2
3         Nixed the defunct chromium folder from DumpRenderTree
4         https://bugs.webkit.org/show_bug.cgi?id=113993
5
6         Reviewed by Ryosuke Niwa.
7
8         * DumpRenderTree/chromium: Removed.
9         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
10         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
11         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
12         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
13         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
14         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
15         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
16         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
17         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
18         * DumpRenderTree/chromium/MockPlatform.h: Removed.
19         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
20         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
21         * DumpRenderTree/chromium/Task.cpp: Removed.
22         * DumpRenderTree/chromium/Task.h: Removed.
23         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
24         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
25         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
26         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
27         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
28         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
29         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
30         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
31         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
32         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
33         * DumpRenderTree/chromium/TestRunner: Removed.
34         * DumpRenderTree/chromium/TestRunner/public: Removed.
35         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
36         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
37         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
38         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
39         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
40         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
41         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
42         * DumpRenderTree/chromium/TestRunner/src: Removed.
43         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
44         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
45         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
46         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
47         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
48         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
49         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
50         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
51         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
52         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
53         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
54         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
55         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
56         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
57         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
58         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
59         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
60         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
61         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
62         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
63         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
64         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
65         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
66         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
67         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
68         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
69         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
70         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
71         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
72         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
73         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
74         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
75         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
76         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
77         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
78         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
79         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
80         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
81         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
82         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
83         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
84         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
85         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
86         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
87         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
88         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
89         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
90         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
91         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
92         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
93         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
94         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
95         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
96         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
97         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
98         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
99         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
100         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
101         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
102         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
103         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
104         * DumpRenderTree/chromium/TestShell.cpp: Removed.
105         * DumpRenderTree/chromium/TestShell.h: Removed.
106         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
107         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
108         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
109         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
110         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
111         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
112         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
113         * DumpRenderTree/chromium/WebViewHost.h: Removed.
114         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
115         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
116         * DumpRenderTree/chromium/config.h: Removed.
117         * DumpRenderTree/chromium/fonts.conf: Removed.
118
119 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
120
121         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
122
123         Rubber stamped by Benjamin Poulain.
124
125         * RebaselineQueueServer: Removed.
126         * RebaselineQueueServer/app.yaml: Removed.
127         * RebaselineQueueServer/handlers: Removed.
128         * RebaselineQueueServer/handlers/__init__.py: Removed.
129         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
130         * RebaselineQueueServer/handlers/pages.py: Removed.
131         * RebaselineQueueServer/index.yaml: Removed.
132         * RebaselineQueueServer/main.py: Removed.
133         * RebaselineQueueServer/model: Removed.
134         * RebaselineQueueServer/model/__init__.py: Removed.
135         * RebaselineQueueServer/model/queueentry.py: Removed.
136         * RebaselineQueueServer/static: Removed.
137         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
138         * RebaselineQueueServer/static/styles.css: Removed.
139         * RebaselineQueueServer/templates: Removed.
140         * RebaselineQueueServer/templates/builder-picker.html: Removed.
141         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
142         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
143         * RebaselineQueueServer/templates/home.html: Removed.
144
145 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
146
147         Fix setup-commit-queue and temporarily disable testing on commit-queue
148         https://bugs.webkit.org/show_bug.cgi?id=113979
149
150         Reviewed by Benjamin Poulain.
151
152         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
153         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
154
155         * EWSTools/setup-commit-queue.sh:
156         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
157         (CommitQueueTask.run):
158
159 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
160
161         temporarily make flakiness dashboard work again webkit.org bots
162         https://bugs.webkit.org/show_bug.cgi?id=113972
163
164         Reviewed by Ojan Vafai.
165
166         This patch disables the chromium.org layout test bots TestExpectations
167         parsing temporarily until we can work out the right way to split into
168         two instances for webkit.org and chromium.org and figure out which
169         code to delete where :).
170
171         * TestResultServer/static-dashboards/flakiness_dashboard.js:
172
173 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
174
175         Fix webkitpy tests after r147678.
176
177         * Scripts/webkitpy/tool/commands/queues_unittest.py:
178         (CommitQueueTest.test_commit_queue):
179         (test_manual_reject_during_processing):
180
181 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
182
183         The commit queue should use Mac MountainLion port
184         https://bugs.webkit.org/show_bug.cgi?id=113971
185
186         Reviewed by Lucas Forschler.
187
188         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
189         * Scripts/webkitpy/tool/commands/queues.py:
190         (CommitQueue):
191
192 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
193
194         turn off running tests on chromium linux EWS bots
195         https://bugs.webkit.org/show_bug.cgi?id=113959
196
197         Reviewed by Geoffrey Garen.
198
199         Now that the Chromium port is no longer being maintained
200         there's little point in running the tests. Soon we should
201         just shut this bot off altogether.
202
203         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
204         (ChromiumLinuxEWS):
205
206 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
207
208         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
209
210         * Scripts/webkitpy/common/config/watchlist:
211
212 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
213
214         Indentation fix to get webkit-patch working again after r147625
215
216         Unreviewed.
217
218         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
219         (MacEWS):
220         (MacWK2EWS):
221
222 2013-04-04  Lucas Forschler  <lforschler@apple.com>
223
224         Turn tests back on for Mac WK1/WK2 EWS.
225         
226         Unreviewed.
227         
228         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
229         (MacEWS):
230         (MacWK2EWS):
231
232 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
233
234         [GTK][WK2] MiniBrowser custom URI scheme support
235         https://bugs.webkit.org/show_bug.cgi?id=112419
236
237         Reviewed by Carlos Garcia Campos.
238
239         Add support for about URIs in MiniBrowser. An example about page is show
240         with URI "about:minibrowser", the rest of the cases it will show a
241         proper message explaining that the about page didn't exist.
242
243         Internally it uses "minibrowser-about" prefix instead of "about", but
244         from the user point of view it works with "about" prefix.
245
246         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
247         (getInternalURI): Method to convert URIs from "about" prefix to
248         "minibrowser-about".
249         (getExternalURI): Opposite method.
250         (webViewURIChanged): Use "about" prefix to show the URI to users.
251         (webViewEnterFullScreen): Ditto.
252         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
253         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
254         (aboutURISchemeRequestCallback): Callback to manage about calls.
255         (main): Register the URI scheme to manage about URIs.
256
257 2013-04-03  Roger Fong  <roger_fong@apple.com>
258
259         Re-enable WinEWS tests.
260
261         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
262         (WinEWS):
263
264 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
265
266         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
267         https://bugs.webkit.org/show_bug.cgi?id=113883
268
269         Reviewed by Martin Robinson.
270
271         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
272         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
273         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
274
275 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
276
277         [GTK] Include Pango in jhbuild-optional.modules
278         https://bugs.webkit.org/show_bug.cgi?id=113878
279
280         Reviewed by Martin Robinson.
281
282         Since r147547 Pango 1.32.0 is required. Including the module in the
283         JHBuild optional moduleset.
284
285         * gtk/jhbuild-optional.modules: Add Pango module.
286
287 2013-04-03  Zeno Albisser  <zeno@webkit.org>
288
289         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
290         https://bugs.webkit.org/show_bug.cgi?id=113864
291
292         Moving setDefersLoading from TestRunnerQt to TestRunner
293         requires access to the non-Qt TestRunner.
294         As long as we instantiate both TestRunner and TestRunnerQt,
295         we need a separate getter for the non-Qt TestRunner instance.
296
297         Reviewed by Simon Hausmann.
298
299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
300         (WebPage::resetSettings):
301         * DumpRenderTree/qt/DumpRenderTreeQt.h:
302         (DumpRenderTree::jscTestRunner):
303         * DumpRenderTree/qt/TestRunnerQt.cpp:
304         (TestRunner::setDefersLoading):
305             Moving setDefersLoading from TestRunnerQt
306             to TestRunner.
307         * DumpRenderTree/qt/TestRunnerQt.h:
308         (TestRunnerQt):
309
310 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
311
312         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
313         https://bugs.webkit.org/show_bug.cgi?id=104779
314
315         Reviewed by Carlos Garcia Campos.
316
317         * Scripts/run-gtk-tests:
318         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
319         passing in current trunk.
320
321 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
322
323         Fix HAVE(QTTESTSUPPORT) logic
324
325         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
326         resulting in HAVE(QTTESTSUPPORT) never being true.
327         Move that logic down in sanitizeFeatures.
328
329         Rubber-stamped by Tor Arne Vestbø.
330
331         * qmake/mkspecs/features/features.prf:
332
333 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
334
335         [GTK] Bump required versions of some dependencies
336         https://bugs.webkit.org/show_bug.cgi?id=113282
337
338         Reviewed by Martin Robinson.
339
340         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
341
342 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
343
344         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
345         https://bugs.webkit.org/show_bug.cgi?id=113809
346
347         Reviewed by Philippe Normand.
348
349         Newer Linux kernels have removed some deprecated macros from v4l2
350         headers, causing gst-plugins-good's build to break. We don't need it
351         right now, so just disable it.
352
353         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
354
355 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
356
357         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
358         https://bugs.webkit.org/show_bug.cgi?id=113535
359
360         Reviewed by Simon Hausmann.
361
362         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
363
364         * qmake/mkspecs/features/features.prf:
365
366 2013-04-03  Zeno Albisser  <zeno@webkit.org>
367
368         [Qt] Move logic of simple forwarding functions to TestRunner.
369         https://bugs.webkit.org/show_bug.cgi?id=113863
370
371         Reviewed by Simon Hausmann.
372
373         * DumpRenderTree/qt/TestRunnerQt.cpp:
374         (TestRunner::setTextDirection):
375         (TestRunner::goBack):
376         (TestRunner::evaluateScriptInIsolatedWorld):
377         (TestRunner::addUserStyleSheet):
378         * DumpRenderTree/qt/TestRunnerQt.h:
379         (TestRunnerQt):
380
381 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
382
383         [Qt] Disable media support using QuickTime if deployment target != SDK
384
385         We link to a single libWebKitSystemInterface static lib, so unless the
386         deployment target matches the SDK let's not pretend like we'll be able
387         to run on anything lower than the SDK version.
388
389         Reviewed by Simon Hausmann.
390
391         * qmake/mkspecs/features/features.prf:
392
393 2013-04-02  James Craig  <james@cookiecrook.com>
394
395         AXRoleDescripton for DL is "list"; should be "description list"
396         https://bugs.webkit.org/show_bug.cgi?id=111665
397
398         Reviewed by Chris Fleizach.
399
400         Defining the role and description strings.
401
402         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
403
404 2013-04-02  Roger Fong  <roger_fong@apple.com>
405
406         Unreviewed. Disable running tests on Win EWS queue.
407
408         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
409         (WinEWS):
410
411 2013-04-02  Lucas Forschler  <lforschler@apple.com>
412
413         Disable running tests on the MAC WK2 EWS queue.
414         
415         Unreviewed.
416         
417         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
418         (MacWK2EWS):
419
420 2013-04-02  Julie Parent  <jparent@chromium.org>
421
422         Dashboard refactor: Move dashboard specific history related features to History.
423         https://bugs.webkit.org/show_bug.cgi?id=113717
424
425         Reviewed by Ojan Vafai.
426         
427         Each dashboard now creates its own History object, with a custom
428         configuration. This changes from just overriding global functions
429         to passing in callbacks for generatePage, handleValidHashParameter,
430         and handleQueryParameterChange. Same with passing in defaultStateValues
431         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
432         variables.
433         
434         All functions related to these features are now (mostly) private
435         function on History. 
436         
437         Loader no longer needs a loadingComplete callback, since it can just
438         initialize the history object itself.
439
440         * TestResultServer/static-dashboards/aggregate_results.js:
441         (handleValidHashParameter):
442         * TestResultServer/static-dashboards/dashboard_base.js:
443         * TestResultServer/static-dashboards/flakiness_dashboard.js:
444         (generatePage):
445         (.switch.return):
446         (handleQueryParameterChange):
447         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
448         (resetGlobals):
449         * TestResultServer/static-dashboards/history.js:
450         (.):
451         * TestResultServer/static-dashboards/loader.js:
452         (.):
453         * TestResultServer/static-dashboards/loader_unittests.js:
454         * TestResultServer/static-dashboards/timeline_explorer.js:
455         (generatePage):
456         (initCurrentBuilderTestResults):
457         * TestResultServer/static-dashboards/treemap.js:
458         (generatePage):
459         (.switch.return):
460         (handleQueryParameterChange):
461
462 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
463
464         Unreviewed, rolling out r147401.
465         http://trac.webkit.org/changeset/147401
466         https://bugs.webkit.org/show_bug.cgi?id=113767
467
468         The patch makes it extremely hard to set up the dependencies
469         properly on the GTK builders (Requested by zdobersek on
470         #webkit).
471
472         * gtk/jhbuild.modules:
473
474 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
475
476         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
477         https://bugs.webkit.org/show_bug.cgi?id=113382
478
479         Reviewed by Gyuyoung Kim.
480
481         Do not show the empty tooltip box if the text is null.
482
483         * MiniBrowser/efl/main.c:
484         (popup_menu_populate):
485
486 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
487
488         [GTK] Bump required versions of some dependencies
489         https://bugs.webkit.org/show_bug.cgi?id=113282
490
491         Reviewed by Martin Robinson.
492
493         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
494
495 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
496
497         Unreviewed, rolling out r147319.
498         http://trac.webkit.org/changeset/147319
499         https://bugs.webkit.org/show_bug.cgi?id=113707
500
501         The unit test is still failing on the buildbot (Requested by
502         zdobersek on #webkit).
503
504         * Scripts/run-gtk-tests:
505         (TestRunner):
506
507 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
508
509         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
510         https://bugs.webkit.org/show_bug.cgi?id=104779
511
512         Reviewed by Carlos Garcia Campos.
513
514         * Scripts/run-gtk-tests:
515         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
516         passing in current trunk.
517
518 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
519
520         Unreviewed, rolling out r147289.
521         http://trac.webkit.org/changeset/147289
522         https://bugs.webkit.org/show_bug.cgi?id=113678
523
524         broke Win7 (dbg) build (Requested by shinyak|gardener on
525         #webkit).
526
527         * DumpRenderTree/DumpRenderTree.gypi:
528         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
529         (WebTestRunner):
530         (WebUserMediaClientMock):
531         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
532         (WebTestRunner::WebUserMediaClientMock::taskList):
533         * Scripts/webkitpy/style/checkers/cpp.py:
534         (check_function_definition):
535
536 2013-03-31  Adam Barth  <abarth@webkit.org>
537
538         configure-svn-config.sh fails
539         https://codereview.chromium.org/13392007/
540
541         Reviewed by Eric Seidel.
542
543         This script was trying to use "svn checkout" to dowload a file from
544         svn.webkit.org, but "svn checkout" only works with directories.
545         Instead, we should use "svn export".
546
547         * EWSTools/configure-svn-config.sh:
548
549 2013-03-31  Wei Jia  <wjia@chromium.org>
550
551         Allow WebUserMediaClientMock to be used by client
552         https://bugs.webkit.org/show_bug.cgi?id=113633
553
554         Reviewed by Adam Barth.
555
556         Export WebUserMediaClientMock.
557         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
558
559         * DumpRenderTree/DumpRenderTree.gypi:
560         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
561         (WebUserMediaClientMock):
562         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
563         * Scripts/webkitpy/style/checkers/cpp.py:
564         (check_function_definition):
565
566 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
567
568         Expose FeatureObserver data to WebKit clients
569         https://bugs.webkit.org/show_bug.cgi?id=113613
570
571         Reviewed by Sam Weinig.
572
573         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
574         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
575
576 2013-03-29  Greg Hughes  <ghughes@apple.com>
577
578         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
579         https://bugs.webkit.org/show_bug.cgi?id=112276
580
581         Reviewed by Chris Fleizach.
582
583         Added support to test accessibility search predicates with multiple keys.  
584
585         * DumpRenderTree/AccessibilityUIElement.cpp:
586         (uiElementForSearchPredicateCallback):
587         * DumpRenderTree/AccessibilityUIElement.h:
588         (AccessibilityUIElement):
589         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
590         (AccessibilityUIElement::uiElementForSearchPredicate):
591         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
592         (AccessibilityUIElement::uiElementForSearchPredicate):
593         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
594         (AccessibilityUIElement::uiElementForSearchPredicate):
595         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
596         (AccessibilityUIElement::uiElementForSearchPredicate):
597         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
598         (AccessibilityUIElement::uiElementForSearchPredicate):
599         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
600         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
601         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
602         (AccessibilityUIElement):
603         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
604         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
605         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
606         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
607         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
608
609 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
610
611         Fix a typo in r147147 to fix Mac EWS.
612
613         * Scripts/webkitpy/tool/commands/queues.py:
614         (PatchProcessingQueue._new_port_name_from_old):
615
616 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
617
618         [EFL] Build break with latest EFL libraries after r146265
619         https://bugs.webkit.org/show_bug.cgi?id=113558
620
621         Unreviewed build fix.
622
623         * TestWebKitAPI/PlatformWebView.h:
624         * WebKitTestRunner/PlatformWebView.h:
625
626 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
627
628         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
629
630         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
631         in libgcrypt build.
632
633 2013-03-28  Lucas Forschler  <lforschler@apple.com>
634
635         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
636
637         Unreviewed.
638
639         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
640         (MacEWS):
641
642 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
643
644         Use the right OS name on Mac EWS instead of mac-future.
645
646         Rubber-stamped by Dirk Pranke.
647
648         * Scripts/webkitpy/tool/commands/queues.py:
649         (PatchProcessingQueue._new_port_name_from_old):
650         (PatchProcessingQueue.begin_work_queue):
651         (PatchProcessingQueue._upload_results_archive_for_patch):
652
653 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
654
655         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
656         https://bugs.webkit.org/show_bug.cgi?id=112546
657
658         Reviewed by Martin Robinson.
659
660         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
661         moved back to Source/WebCore/platform. Fix an indentation issue as well.
662
663 2013-03-28  Ming Xie  <mxie@blackberry.com>
664
665         [BlackBerry] Committer Email Updates
666         https://bugs.webkit.org/show_bug.cgi?id=113435
667
668         Reviewed by Rob Buis.
669
670         Add the @blackberry.com email address for all our BlackBerry
671         WebKit committers. This is the first step for our email address
672         migration.
673
674         * Scripts/webkitpy/common/config/committers.py:
675
676 2013-03-28  Philippe Normand  <pnormand@igalia.com>
677
678         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
679         https://bugs.webkit.org/show_bug.cgi?id=113508
680
681         Reviewed by Martin Robinson.
682
683         Prevent the GStreamer plugin scanner to load system-wide
684         plugins. Only the ones built in JHBuild should be loaded and used
685         at runtime.
686
687         * efl/jhbuildrc:
688         * gtk/jhbuildrc:
689
690 2013-03-27  Philippe Normand  <pnormand@igalia.com>
691
692         [GTK] run-launcher --gtk -2 fails on a WK2-only build
693         https://bugs.webkit.org/show_bug.cgi?id=113386
694
695         Reviewed by Carlos Garcia Campos.
696
697         * Scripts/webkitdirs.pm:
698         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
699         version to 3.0. Reflect this change so the builtDylibPathForName
700         function doesn't fail to report the library as found.
701
702 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
703
704         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
705         https://bugs.webkit.org/show_bug.cgi?id=113484
706
707         Unreviewed build fix.
708
709         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
710
711         * TestWebKitAPI/CMakeLists.txt:
712         * WebKitTestRunner/CMakeLists.txt:
713
714 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
715
716         Revision for the internal jhbuild is too old
717         https://bugs.webkit.org/show_bug.cgi?id=113324
718
719         Reviewed by Martin Robinson.
720
721         Update the minimum required version to a point where jhbuild won't
722         fail installing packages when trying to remove a symlink to a directory.
723
724         * jhbuild/jhbuild-wrapper: Updated revision.
725
726 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
727
728         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
729         https://bugs.webkit.org/show_bug.cgi?id=113203
730
731         Reviewed by Philippe Normand.
732
733         We build our libsoup without GNOME support. gst-plugins-good does separate
734         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
735         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
736         build failures as the headers of those diverge. We do not use souphttpsrc, so
737         disable it when building gst-plugins-good.
738
739         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
740
741 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
742
743         Build fix after r146852. Please another reference to the Lion leaks builder.
744
745         * BuildSlaveSupport/build.webkit.org-config/config.json:
746
747 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
748
749         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
750         https://bugs.webkit.org/show_bug.cgi?id=113421
751
752         Reviewed by Dirk Pranke.
753
754         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
755         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
756         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
757         in the GTK-specific TestExpectations files.
758
759         To avoid this only enable the warnings only when not using WKTR.
760
761         * Scripts/webkitpy/layout_tests/port/gtk.py:
762         (GtkPort.warn_if_bug_missing_in_test_expectations):
763
764 2013-03-27  Antti Koivisto  <antti@apple.com>
765
766         Fix Zalan's email.
767
768         * Scripts/webkitpy/common/config/committers.py:
769
770 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
771
772         master.cfg cleanup
773         https://bugs.webkit.org/show_bug.cgi?id=113195
774
775         Reviewed by Ryosuke Niwa.
776
777         * BuildSlaveSupport/build.webkit.org-config/config.json:
778         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
779
780 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
781
782         master.cfg fine-tuning for Qt Mountain Lion Release bot
783         https://bugs.webkit.org/show_bug.cgi?id=113191
784
785         Reviewed by Ryosuke Niwa.
786
787         * BuildSlaveSupport/build.webkit.org-config/config.json:
788           - Rename the slave due to its location change.
789           - Update the platform of the slave.
790         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
791         (RunQtAPITests): Enable running WK2 API tests on Qt.
792         (RunQtAPITests.start):
793         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
794         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
795
796 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
797
798         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
799         https://bugs.webkit.org/show_bug.cgi?id=113403
800
801         Reviewed by Kenneth Rohde Christiansen.
802
803         As of Evas 1.7.5, when Wayland is detected on the system, support for
804         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
805         The code, however, seems to depend on a few other flags which must be
806         explicitly enabled.
807
808         If those additional GL-related options are passed, we end up
809         having issues on the WebKit side, so disable Wayland support for
810         now.
811
812         * efl/jhbuild.modules:
813
814 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
815
816         Unreviewed, rolling out r146864.
817         http://trac.webkit.org/changeset/146864
818         https://bugs.webkit.org/show_bug.cgi?id=113391
819
820         causes crashes on Wk2 EFL release bot (Requested by drott on
821         #webkit).
822
823         * Scripts/webkitperl/FeatureList.pm:
824
825 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
826
827         [jhbuild] Correctly specify an alternate number of make jobs.
828         https://bugs.webkit.org/show_bug.cgi?id=113396
829
830         Reviewed by Philippe Normand.
831
832         So far, we were using the `MAKEFLAGS' environment variable to pass the
833         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
834         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
835
836         We now behave more closely to the rest of the WebKit tools by first
837         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
838         not set, just letting jhbuild itself figure out how many jobs to use.
839
840         * efl/jhbuildrc:
841         * gtk/jhbuildrc:
842
843 2013-03-27  Zeno Albisser  <zeno@webkit.org>
844
845         [Qt] Remove Qt specific WorkQueueItem definitions.
846         https://bugs.webkit.org/show_bug.cgi?id=112891
847
848         This patch is preparation work for removing
849         WorkQueue related code from TestRunnerQt and
850         replacing it with generic TestRunner code.
851
852         Reviewed by Benjamin Poulain.
853
854         * DumpRenderTree/qt/TestRunnerQt.cpp:
855         (TestRunnerQt::queueBackNavigation):
856         (TestRunnerQt::queueForwardNavigation):
857         (TestRunnerQt::queueLoadHTMLString):
858         (TestRunnerQt::queueReload):
859         (TestRunnerQt::queueLoadingScript):
860         (TestRunnerQt::queueNonLoadingScript):
861         (TestRunner::queueLoad):
862         * DumpRenderTree/qt/TestRunnerQt.h:
863         (TestRunnerQt):
864         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
865         (LoadItem::invoke):
866         (LoadHTMLStringItem::invoke):
867         (LoadAlternateHTMLStringItem::invoke):
868         (ReloadItem::invoke):
869         (ScriptItem::invoke):
870         (BackForwardItem::invoke):
871         * DumpRenderTree/qt/WorkQueueItemQt.h:
872         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
873         (LoadAlternateHTMLStringItem):
874
875 2013-03-26  Julie Parent  <jparent@chromium.org>
876
877         Flakiness dashboard: simplify logic around which tests to show.
878         https://bugs.webkit.org/show_bug.cgi?id=113250
879
880         Reviewed by Ojan Vafai.
881         
882         The different filters for showing results are only used for layout
883         tests, otherwise, we show everything.
884         
885         Change the defaults to false (what layout tests used), and only
886         look at the values when viewing layout tests.
887
888         * TestResultServer/static-dashboards/flakiness_dashboard.js:
889         (htmlForTestsWithExpectationsButNoFailures):
890         (shouldHideTest):
891
892 2013-03-26  Isaac Levy  <ilevy@google.com>
893
894         Update bots on test-results.appspot
895         https://bugs.webkit.org/show_bug.cgi?id=113333
896
897         Reviewed by Ojan Vafai.
898
899         * TestResultServer/static-dashboards/builders.jsonp:
900
901 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
902
903         Unreviewed GTK gardening.
904
905         * Scripts/run-gtk-tests:
906         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
907
908 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
909
910         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
911         https://bugs.webkit.org/show_bug.cgi?id=113287
912
913         Reviewed by Jocelyn Turcotte.
914
915         * Scripts/run-qtwebkit-tests:
916         (Options.__init__):
917
918 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
919
920         [EFL] Enable IndexedDB by default
921         https://bugs.webkit.org/show_bug.cgi?id=107248
922
923         Reviewed by Laszlo Gombos.
924
925         * Scripts/webkitperl/FeatureList.pm:
926         Enable IndexedDB by default on EFL.
927
928 2013-03-26  Alan Cutter  <alancutter@chromium.org>
929
930         Sheriffbot should explain rollout failures in a human readable form.
931         https://bugs.webkit.org/show_bug.cgi?id=107092
932
933         Reviewed by Ryosuke Niwa.
934
935         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
936
937         * Scripts/webkitpy/tool/bot/irc_command.py:
938         (Rollout._check_diff_failure):
939         (Rollout.execute):
940         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
941         (IRCCommandTest.test_rollout):
942
943 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
944
945         Unreviewed GTK gardening.
946
947         * Scripts/run-gtk-tests:
948         (TestRunner): Skipping a failing unit test after r146518.
949
950 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
951
952         Remove Lion leaks builder
953         https://bugs.webkit.org/show_bug.cgi?id=113252
954
955         Reviewed by Andreas Kling.
956
957         Removed.
958
959         * BuildSlaveSupport/build.webkit.org-config/config.json:
960
961 2013-03-25  Kent Tamura  <tkent@chromium.org>
962
963         Rename ENABLE_INPUT_TYPE_DATETIME
964         https://bugs.webkit.org/show_bug.cgi?id=113254
965
966         Reviewed by Kentaro Hara.
967
968         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
969         Actually I'd like to remove the code, but we shouldn't remove it yet
970         because we shipped products with it on some platforms.
971
972         * Scripts/webkitperl/FeatureList.pm:
973         * qmake/mkspecs/features/features.pri:
974
975 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
976
977         Remove one more line that was intended to be removed in r146657.
978
979         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
980         (summarize_results):
981
982 2013-03-25  Roger Fong  <roger_fong@apple.com>
983
984         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
985         Re-enable WinEWS tests.
986
987         * Scripts/webkitpy/common/config/ports.py:
988         (WinPort.run_bindings_tests_command):
989         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
990         (WinEWS):
991
992 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
993
994         Unreviewed, rolling out r146793.
995         http://trac.webkit.org/changeset/146793
996         https://bugs.webkit.org/show_bug.cgi?id=113248
997
998         Fix did not work (Requested by rfong on #webkit).
999
1000         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1001         (WinEWS):
1002
1003 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1004
1005         REGRESSION(r146657): Test failures reported incorrectly
1006         https://bugs.webkit.org/show_bug.cgi?id=113223
1007
1008         Reviewed by Dirk Pranke.
1009
1010         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1011
1012         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1013         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1014
1015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1016         (Manager.run):
1017
1018         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1019         (RunDetails.__init__):
1020         (summarize_results): Remove the line I intended to remove in r146657.
1021
1022         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1023         (logging_run): Return details instead of the exit code.
1024         (run_and_capture): Ditto.
1025
1026         (RunTest.test_full_results_html):
1027         (RunTest.test_hung_thread):
1028         (RunTest.test_no_tests_found):
1029         (RunTest.test_no_tests_found_2):
1030         (RunTest.test_repeat_each_iterations_num_tests):
1031         (RunTest.test_run_singly_actually_runs_tests):
1032         (RunTest.test_test_list):
1033         (RunTest.test_missing_and_unexpected_results):
1034         (RunTest.test_pixel_test_directories):
1035         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1036         (RunTest.test_crash_with_stderr):
1037         (RunTest.test_no_image_failure_with_image_diff):
1038         (RunTest.test_crash_log):
1039         (RunTest.test_exit_after_n_failures_upload):
1040         (RunTest.test_results_directory_absolute):
1041         (RunTest.test_results_directory_relative):
1042         (RunTest.test_retrying_and_flaky_tests):
1043         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1044         (RunTest.test_retrying_uses_retries_directory):
1045         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1046         (RunTest.test_output_diffs):
1047         (EndToEndTest.test_reftest_with_two_notrefs):
1048         (RebaselineTest.test_reset_results):
1049         (RebaselineTest.test_missing_results):
1050         (RebaselineTest.test_new_baseline):
1051
1052         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1053         (BuildBotPrinter.print_results):
1054         (BuildBotPrinter.print_unexpected_results):
1055         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1056         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1057
1058 2013-03-25  Julie Parent  <jparent@chromium.org>
1059
1060         Dashboard refactor: Move cross dashboard history related code into history.js.
1061         https://bugs.webkit.org/show_bug.cgi?id=113104
1062
1063         Reviewed by Ojan Vafai.
1064
1065         All functions relating to cross dashboard behavior move from being
1066         globals to methods on the history.History object. Names stay the same,
1067         except many are made private, ones that should have been constants now
1068         are, and the long standing TODO to change "currentState" to 
1069         dashboardSpecificState is done.
1070         
1071         We now create a global history object in dashboard_base, as an 
1072         intermediate measure.  Once the dashboard specific code is
1073         added to history, each DB will need to create its own, and this
1074         global will be eliminated.
1075         
1076         * TestResultServer/static-dashboards/aggregate_results.js:
1077         (handleValidHashParameter):
1078         (htmlForBuilder):
1079         (rawValuesHTML):
1080         * TestResultServer/static-dashboards/dashboard_base.js:
1081         (parseDashboardSpecificParameters):
1082         (defaultValue):
1083         (currentBuilderGroupCategory):
1084         (currentBuilderGroupName):
1085         (handleLocationChange):
1086         (expectationsMap):
1087         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1088         (generatePage):
1089         (.switch.return):
1090         (platformAndBuildType):
1091         (individualTests):
1092         (substringList):
1093         (processMissingAndExtraExpectations):
1094         (pathToFailureLog):
1095         (showPopupForBuild):
1096         (htmlForTestsWithExpectationsButNoFailures):
1097         (shouldHideTest):
1098         (isCrossBuilderView):
1099         (tableHeaders):
1100         (htmlForSingleTestRow):
1101         (htmlForTableColumnHeader):
1102         (generatePageForExpectationsUpdate):
1103         (handleUpdate):
1104         (nextUpdate):
1105         (setUpdateIndex):
1106         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1107         (.appendExpectationsItem):
1108         (loadExpectations):
1109         (.dummyNode.onload):
1110         (loadExpectationsLayoutTests):
1111         (appendExpectations):
1112         (htmlForNavBar):
1113         (checkBoxToToggleState):
1114         (linkHTMLToToggleState):
1115         (generatePageForBuilder):
1116         (isInvalidKeyForCrossBuilderView):
1117         (handleQueryParameterChange):
1118         (showLegend):
1119         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1120         (resetGlobals):
1121         (test):
1122         * TestResultServer/static-dashboards/history.js:
1123         (.):
1124         * TestResultServer/static-dashboards/history_unittests.js:
1125         * TestResultServer/static-dashboards/loader.js:
1126         (.):
1127         * TestResultServer/static-dashboards/loader_unittests.js:
1128         * TestResultServer/static-dashboards/timeline_explorer.js:
1129         (generatePage):
1130         (initCurrentBuilderTestResults):
1131         (selectBuild):
1132         (showResultsDelta):
1133         * TestResultServer/static-dashboards/treemap.js:
1134         (generatePage):
1135         (.switch.return):
1136         (handleFocus):
1137         * TestResultServer/static-dashboards/ui.js:
1138
1139 2013-03-25  Roger Fong  <roger_fong@apple.com>
1140
1141         Unreviewed. Enable WinEWS tests again.
1142
1143         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1144         (WinEWS):
1145
1146 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1147
1148         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1149         https://bugs.webkit.org/show_bug.cgi?id=112166
1150
1151         HarfBuzz 0.9.14 merged my patch for icu detection without
1152         pkg-config files, as needed by for example Ubuntu 12.04.
1153         This obsoletes our local workaround. Removed it for GTK and EFL.
1154
1155         Reviewed by Martin Robinson.
1156
1157         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1158         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1159         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1160         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1161
1162 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1163
1164         Unreviewed.  Move self from contributor to committer list.
1165
1166         * Scripts/webkitpy/common/config/committers.py:
1167
1168 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1169
1170         EWS should use a human readable port name when uploading layout test archives
1171         https://bugs.webkit.org/show_bug.cgi?id=113099
1172
1173         Reviewed by Dirk Pranke.
1174
1175         Use new port's object's name() method to report human readable port names.
1176         This will also help us resolving the bug to apply layout test results posted by EWS.
1177
1178         * Scripts/webkitpy/tool/bot/botinfo.py:
1179         (BotInfo.__init__): Take port's name.
1180         (BotInfo.summary_text):
1181
1182         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1183         (BotInfoTest.test_summary_text):
1184
1185         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1186         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1187
1188         * Scripts/webkitpy/tool/commands/queues.py:
1189         (PatchProcessingQueue.__init__): Initialize self._port.
1190         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1191         and use that for the attachment filename and the comment posted.
1192
1193         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1194         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1195         "mac-snowleopard" as expected for TestPort.
1196
1197 2013-03-22  Roger Fong  <roger_fong@apple.com>
1198
1199         Unreviewed. Turn off EWS test on Win again.
1200         The battle continues.
1201
1202         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1203         (WinEWS):
1204
1205 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1206
1207         NRWT: Enable pixel tests when retrying tests
1208         https://bugs.webkit.org/show_bug.cgi?id=112898
1209
1210         Reviewed by Dirk Pranke.
1211
1212         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1213         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1214         if we've forced pixel tests in the retry.
1215         (Manager._run_tests):
1216         (Manager._clean_up_run): Fixed the capitalizations.
1217         (Manager._force_pixel_tests_if_needed): Added.
1218
1219         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1220         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1221         'image_diff_percent' if it doesn't already exist.
1222
1223         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1224         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1225         treat this as a regular regression instead of a flakiness.
1226
1227         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1228         run had image diffs.
1229
1230         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1231         (summarized_results):
1232
1233         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1234         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1235         Also removed some dead code.
1236
1237         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1238         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1239         is set and pixel_tests_enabled is set to false.
1240         (EndToEndTest.test_reftest_with_two_notrefs):
1241
1242 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1243
1244         Make it possible to run layout tests on Retina MBP
1245         https://bugs.webkit.org/show_bug.cgi?id=93673
1246
1247         Reviewed by Ryosuke Niwa.
1248
1249         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1250         windows on 2x machines still run at 1x.
1251
1252         * DumpRenderTree/mac/DumpRenderTree.mm:
1253         (createWebViewAndOffscreenWindow):
1254         Reset the window resolution to 1x on creation.
1255         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1256         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1257         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1258         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1259         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1260         (WTR::PlatformWebView::PlatformWebView):
1261         Add NSWindow details, reset the window resolution to 1x on creation.
1262
1263 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Leak bots shouldn't build
1266         https://bugs.webkit.org/show_bug.cgi?id=112774
1267
1268         Reviewed by Simon Fraser.
1269
1270         Since leak bots use regular debug builds, there is no need to build on these bots.
1271         Simply downloading builds will dramatically improve the cycle time of these bots.
1272
1273         * BuildSlaveSupport/build.webkit.org-config/config.json:
1274         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1275         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1276         TestFactory instead of BuildAndTestFactory.
1277
1278 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1279
1280         [Qt] Fix the TestWebKitAPI build
1281         https://bugs.webkit.org/show_bug.cgi?id=113044
1282
1283         Reviewed by Tor Arne Vestbø.
1284
1285         The generate-forwarding-headers script would only be run
1286         after the targets in InjectedBundle.pri since the second
1287         addStrictSubdirOrderBetween call in
1288         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1289         the derived_sources -> injected_bundle order in SUBDIRS.
1290
1291         Fix it by only moving the dependent target at the end of
1292         SUBDIRS, don't touch its dependency.
1293
1294         * qmake/mkspecs/features/functions.prf:
1295
1296 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1297
1298         [EFL][WK2] View is not focused when fullscreen mode toggled
1299         https://bugs.webkit.org/show_bug.cgi?id=113009
1300
1301         Reviewed by Laszlo Gombos.
1302
1303         Set focus on view when fullscreen mode enabled/disabled
1304         by FullScreen API.
1305
1306         * MiniBrowser/efl/main.c:
1307         (on_fullscreen_accept):
1308         (on_fullscreen_deny):
1309
1310 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1311
1312         nrwt is no longer saving retry results in the retries/ subdirectory
1313         https://bugs.webkit.org/show_bug.cgi?id=112995
1314
1315         Reviewed by Ojan Vafai.
1316
1317         I think this has been broken a long time, unfortunately. This
1318         patch should fix that.
1319
1320         In order to do so, I had to pass the directory to use from
1321         the Worker object through the SingleTestWriter to the
1322         TestResultWriter. While I was plumbing that through, I rationalized
1323         the order of the parameter arguments a bit ...
1324
1325         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1326         (Worker._run_single_test):
1327         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1328         (run_single_test):
1329         (SingleTestRunner.__init__):
1330         (SingleTestRunner._run_compare_test):
1331         (SingleTestRunner._run_rebaseline):
1332         (SingleTestRunner._run_reftest):
1333         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1334         (write_test_result):
1335         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1336         (TestResultWriterTest.test_reftest_diff_image):
1337         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1338         (RunTest.test_retrying_uses_retries_directory):
1339
1340 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1341
1342         JSC profiler should have an at-a-glance report of the success of DFG optimization
1343         https://bugs.webkit.org/show_bug.cgi?id=112988
1344
1345         Reviewed by Geoffrey Garen.
1346
1347         * Scripts/display-profiler-output:
1348
1349 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1350
1351         [chromium] Linux ASAN WebKit canary is running out of memory
1352         https://bugs.webkit.org/show_bug.cgi?id=112978
1353
1354         Reviewed by Tony Chang.
1355
1356         Running the AddressSanitizer on a crash takes a lot of
1357         memory, so we should serialize access to it to avoid running
1358         out of memory on a machine.
1359
1360         * Scripts/webkitpy/layout_tests/port/chromium.py:
1361         (ChromiumPort._get_crash_log):
1362         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1363         (HttpLock.__init__):
1364         (HttpLock.wait_for_httpd_lock):
1365
1366 2013-03-21  Min Qin  <qinmin@chromium.org>
1367
1368         Cleanup android media layout test code
1369         https://bugs.webkit.org/show_bug.cgi?id=112944
1370
1371         Reviewed by Adam Barth.
1372
1373         Chromium change: https://codereview.chromium.org/12892010/
1374         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1375         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1376         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1377         Instead, we should switch to use content shell for layout tests.
1378
1379         * DumpRenderTree/chromium/TestShell.cpp:
1380         (TestShell::resetTestController):
1381
1382 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1383
1384         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1385         https://bugs.webkit.org/show_bug.cgi?id=112953
1386
1387         Reviewed by Tony Chang.
1388
1389         When I created the DumpRenderTree_resources target in r144863 I
1390         forgot to declare the needed dependencies on the other resource
1391         targets. Due to a quirk of ordering, this appears to have been fine
1392         w/ ninja but not w/ Xcode (which is still being used on the chromium
1393         mac valgrind bots). Declaring the dependencies fixes the build
1394         failures.
1395
1396         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1397
1398 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1399
1400         [WinCairo] Correct assert in Empty BitmapImage Test.
1401         https://bugs.webkit.org/show_bug.cgi?id=112934
1402
1403         Reviewed by Tim Horton.
1404
1405         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1406         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1407         to avoid ref counting assertion when leaving test scope.
1408
1409 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1410
1411         [GTK] generate-feature-defines-files is incompatible with Python3
1412         https://bugs.webkit.org/show_bug.cgi?id=112956
1413
1414         Reviewed by Martin Robinson.
1415
1416         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1417         method on the dictionary objects when iterating through said dictionaries.
1418
1419         * gtk/generate-feature-defines-files:
1420         (write_feature_defines_header):
1421         (write_flattened_feature_defines_file):
1422
1423 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         kill-old-processes spits out error messages on Mac
1426         https://bugs.webkit.org/show_bug.cgi?id=112878
1427
1428         Reviewed by Jessie Berlin.
1429
1430         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1431         included in the list of options grep --help shows.
1432
1433         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1434
1435         * BuildSlaveSupport/kill-old-processes:
1436         (main):
1437
1438 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1439
1440         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1441         https://bugs.webkit.org/show_bug.cgi?id=112597
1442
1443         Reviewed by Xan Lopez.
1444
1445         These were introduced for the Chromium port in r105295. We need
1446         dummy implementations in order to compile the BlackBerry port.
1447
1448         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1449         (AccessibilityUIElement::scrollToMakeVisible):
1450         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1451         (AccessibilityUIElement::scrollToGlobalPoint):
1452
1453 2013-03-21  Roger Fong  <roger_fong@apple.com>
1454
1455         Re-enable WinEWS tests following r146376.
1456
1457         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1458         (WinEWS):
1459
1460 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1461
1462         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1463
1464         * Scripts/webkitpy/common/config/committers.py:
1465
1466 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1467
1468         [GTK] Missing atk in install-dependencies script
1469         https://bugs.webkit.org/show_bug.cgi?id=112272
1470
1471         Reviewed by Gustavo Noronha Silva.
1472
1473         * gtk/install-dependencies: Add missing atk dependency.
1474
1475 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1476
1477         [GTK] Missing backslash in install-dependencies script
1478         https://bugs.webkit.org/show_bug.cgi?id=112907
1479
1480         Reviewed by Philippe Normand.
1481
1482         * gtk/install-dependencies: Add missing backslash to dependencies
1483         list.
1484
1485 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1486
1487         EWS bots have stopped uploading results to bugzilla
1488         https://bugs.webkit.org/show_bug.cgi?id=101091
1489
1490         Reviewed by Adam Barth.
1491
1492         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1493         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1494         this relative file path resoled to a file inside a non-existent directory for "zip".
1495
1496         Fixed the bug by resolving both test results directory and zip archive paths in
1497         LayoutTestResultsReader.archive.
1498
1499         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1500         in the future.
1501
1502         * Scripts/webkitpy/common/system/filesystem_mock.py:
1503         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1504
1505         * Scripts/webkitpy/common/system/workspace.py:
1506         (Workspace.create_zip): Log the source path when "zip" failed.
1507
1508         * Scripts/webkitpy/common/system/workspace_mock.py:
1509         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1510
1511         * Scripts/webkitpy/common/system/workspace_unittest.py:
1512         (WorkspaceTest.test_create_zip_exception): Test that.
1513
1514         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1515         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1516         This is the actual bug fix.
1517
1518         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1519         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1520
1521 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1522
1523         [chromium] move WebThemeEngine implementations to TestRunner library
1524         https://bugs.webkit.org/show_bug.cgi?id=112751
1525
1526         Reviewed by Adam Barth.
1527
1528         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1529         * DumpRenderTree/DumpRenderTree.gypi:
1530         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1531         (WebKit):
1532         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1533         (WebTestRunner::TestInterfaces::themeEngine):
1534         (WebTestRunner):
1535         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1536         (WebKit):
1537         (TestInterfaces):
1538         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1539         (WebTestRunner::WebTestInterfaces::themeEngine):
1540         (WebTestRunner):
1541         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1542         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1543         (WebTestRunner):
1544         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1545         (WebTestRunner::WebTestThemeControlWin::box):
1546         (WebTestRunner::WebTestThemeControlWin::line):
1547         (WebTestRunner::WebTestThemeControlWin::triangle):
1548         (WebTestRunner::WebTestThemeControlWin::roundRect):
1549         (WebTestRunner::WebTestThemeControlWin::oval):
1550         (WebTestRunner::WebTestThemeControlWin::circle):
1551         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1552         (WebTestRunner::WebTestThemeControlWin::markState):
1553         (WebTestRunner::WebTestThemeControlWin::draw):
1554         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1555         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1556         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1557         (WebTestRunner):
1558         (WebTestThemeControlWin):
1559         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1560         (WebTestRunner):
1561         (WebTestThemeEngineMac):
1562         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1563         (+[FakeActiveWindow alwaysActiveWindow]):
1564         (+[FakeActiveWindow alwaysInactiveWindow]):
1565         (-[FakeActiveWindow initWithActiveControls:]):
1566         (-[FakeActiveWindow _hasActiveControls]):
1567         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1568         (WebTestRunner):
1569         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1570         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1571         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1572         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1573         (WebTestRunner):
1574         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1575         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1576         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1577         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1578         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1579         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1580         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1581         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1582         (WebTestRunner::WebTestThemeEngineWin::getSize):
1583         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1584         (WebTestRunner):
1585         (WebTestThemeEngineWin):
1586         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1587         * DumpRenderTree/chromium/TestShell.cpp:
1588         (TestShell::initialize):
1589         * DumpRenderTree/chromium/TestShell.h:
1590         (WebKit):
1591         * DumpRenderTree/chromium/TestShellMac.mm:
1592         (platformInit):
1593         * DumpRenderTree/chromium/TestShellWin.cpp:
1594         (platformInit):
1595         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1596
1597 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1598
1599         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1600
1601         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1602         New property sheet that does not link against CoreFoundation and
1603         CFNetwork.
1604         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1605         Use new TestWebKitAPICommonWinCairo property sheet.
1606         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1607         Ditto.
1608
1609 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1610
1611         [WinCairo] Unreviewed build fix for VS2010.
1612
1613         Had to add WinCairo-specific property sheets to deal with some
1614         library and path differences with the main Apple port.
1615
1616         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1617         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1618         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1619         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1620         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1621         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1622
1623 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1624
1625         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1626         https://bugs.webkit.org/show_bug.cgi?id=112849
1627
1628         Reviewed by Sam Weinig.
1629
1630         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1631         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1632         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1633
1634 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1635
1636         [WinCairo] Build WebKit Tools under VS2010
1637         https://bugs.webkit.org/show_bug.cgi?id=112821
1638
1639         Reviewed by Tim Horton.
1640
1641         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1642         Add WinCairo-specific build target.
1643         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1644         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1645         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1646         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1647         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1648         Add WinCairo-specific build target.
1649         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1650         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1651         Add WinCairo-specific build target.
1652         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1653         WinCairo-specific build target.
1654         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1655         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1656         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1657         specific build target.
1658         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1659         WinCairo-specific build target.
1660         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1661         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1662         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1663
1664 2013-03-20  Roger Fong  <roger_fong@apple.com>
1665
1666         API test gardening AppleWin port.
1667
1668         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1669
1670         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1671         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1672
1673 2013-03-20  Roger Fong  <roger_fong@apple.com>
1674
1675         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1676
1677         * EWSTools/start-queue-win.sh:
1678
1679 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1680
1681         Unreviewed, add myself to committers.py.
1682
1683 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1684
1685         Unreviewed. Adding another email for me.
1686
1687         * Scripts/webkitpy/common/config/committers.py:
1688
1689 2013-03-20  Justin Novosad  <junov@google.com>
1690
1691         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1692         https://bugs.webkit.org/show_bug.cgi?id=112605
1693
1694         Reviewed by James Robinson.
1695
1696         Deleting all the code that was used for propagating and supporting
1697         the Chromium setting for disabling deferred 2d canvas rendering.
1698
1699         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1700         (main):
1701         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1702         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1703         (WebTestRunner::WebPreferences::reset):
1704         (WebTestRunner::WebPreferences::applyTo):
1705         * DumpRenderTree/chromium/TestShell.cpp:
1706         (TestShell::TestShell):
1707         (TestShell::resetWebSettings):
1708         (TestShell::runFileTest):
1709         * DumpRenderTree/chromium/TestShell.h:
1710         (TestShell):
1711
1712 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1713
1714         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1715         https://bugs.webkit.org/show_bug.cgi?id=112699.
1716
1717         Reviewed by Adam Barth.
1718
1719         * Scripts/webkitpy/layout_tests/port/qt.py:
1720         (QtPort._search_paths):
1721         (QtPort._port_specific_expectations_files):
1722         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1723         (QtPortTest):
1724         (QtPortTest._assert_search_path):
1725         (QtPortTest._assert_expectations_files):
1726
1727 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1728
1729         [Qt] Enable kerning by default
1730         https://bugs.webkit.org/show_bug.cgi?id=112704
1731
1732         Reviewed by Jocelyn Turcotte.
1733
1734         Disable kerning by default, since some reference test expectations
1735         expect kerning to be default off.
1736
1737         * DumpRenderTree/qt/TestRunnerQt.cpp:
1738         (TestRunnerQt::reset):
1739         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1740         (WTR::activateFonts):
1741
1742 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1743
1744         [Qt] Remove empty function stubs from TestRunnerQt.
1745         https://bugs.webkit.org/show_bug.cgi?id=112799
1746
1747         We are reducing the code in TestRunnerQt step by step,
1748         in order to finally replace all of it with the generic
1749         TestRunner implementation.
1750         This patch removes several simple function stubs that
1751         currently do not implement any actual functionality.
1752
1753         Reviewed by Kenneth Rohde Christiansen.
1754
1755         * DumpRenderTree/qt/TestRunnerQt.cpp:
1756         * DumpRenderTree/qt/TestRunnerQt.h:
1757         (TestRunnerQt):
1758
1759 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1760
1761         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1762         https://bugs.webkit.org/show_bug.cgi?id=112687
1763
1764         Reviewed by Kenneth Rohde Christiansen.
1765
1766         Hide the SearchBar by default on window creation.
1767
1768         * MiniBrowser/efl/main.c:
1769         (window_create):
1770
1771 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1772
1773         Unreviewed, rolling out r146304.
1774         http://trac.webkit.org/changeset/146304
1775         https://bugs.webkit.org/show_bug.cgi?id=112788
1776
1777         to many expectations to update (Requested by antonm on
1778         #webkit).
1779
1780         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1781         * DumpRenderTree/DumpRenderTree.gypi:
1782         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1783         (WebKit):
1784         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1785         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1786         (TestInterfaces):
1787         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1788         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1789         * DumpRenderTree/chromium/TestShell.cpp:
1790         (TestShell::initialize):
1791         * DumpRenderTree/chromium/TestShell.h:
1792         (WebKit):
1793         * DumpRenderTree/chromium/TestShellMac.mm:
1794         (platformInit):
1795         * DumpRenderTree/chromium/TestShellWin.cpp:
1796         (platformInit):
1797         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1798         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1799         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1800         (WebThemeControlDRTWin::box):
1801         (WebThemeControlDRTWin::line):
1802         (WebThemeControlDRTWin::triangle):
1803         (WebThemeControlDRTWin::roundRect):
1804         (WebThemeControlDRTWin::oval):
1805         (WebThemeControlDRTWin::circle):
1806         (WebThemeControlDRTWin::nestedBoxes):
1807         (WebThemeControlDRTWin::markState):
1808         (WebThemeControlDRTWin::draw):
1809         (WebThemeControlDRTWin::drawTextField):
1810         (WebThemeControlDRTWin::drawProgressBar):
1811         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1812         (WebThemeControlDRTWin):
1813         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1814         (WebThemeEngineDRTMac):
1815         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1816         (+[FakeActiveWindow alwaysActiveWindow]):
1817         (+[FakeActiveWindow alwaysInactiveWindow]):
1818         (-[FakeActiveWindow initWithActiveControls:]):
1819         (-[FakeActiveWindow _hasActiveControls]):
1820         (WebThemeEngineDRTMac::paintScrollbarThumb):
1821         (stateToHIEnableState):
1822         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1823         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1824         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1825         (webRectToSkIRect):
1826         (drawControl):
1827         (drawTextField):
1828         (drawProgressBar):
1829         (WebThemeEngineDRTWin::paintButton):
1830         (WebThemeEngineDRTWin::paintMenuList):
1831         (WebThemeEngineDRTWin::paintScrollbarArrow):
1832         (WebThemeEngineDRTWin::paintScrollbarThumb):
1833         (WebThemeEngineDRTWin::paintScrollbarTrack):
1834         (WebThemeEngineDRTWin::paintSpinButton):
1835         (WebThemeEngineDRTWin::paintTextField):
1836         (WebThemeEngineDRTWin::paintTrackbar):
1837         (WebThemeEngineDRTWin::paintProgressBar):
1838         (WebThemeEngineDRTWin::getSize):
1839         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1840         (WebThemeEngineDRTWin):
1841         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1842
1843 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1844
1845         [Qt] Support -webkit-font-smoothing
1846         https://bugs.webkit.org/show_bug.cgi?id=106009
1847
1848         Reviewed by Jocelyn Turcotte.
1849
1850         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1851
1852         * DumpRenderTree/qt/TestRunnerQt.cpp:
1853         (TestRunnerQt::reset):
1854
1855 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1856
1857         [GTK] accessibility/aria-scrollbar-role.html is failing
1858         https://bugs.webkit.org/show_bug.cgi?id=98358
1859
1860         Reviewed by Martin Robinson.
1861
1862         Adds support for checking accessibility object's orientation.
1863         Orientation is checked by retrieving proper state of accessibility object.
1864
1865         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1866         (checkElementState):
1867         (AccessibilityUIElement::orientation):
1868         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1869         (WTR::AccessibilityUIElement::orientation):
1870
1871 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1872
1873         [chromium] move WebThemeEngine implementations to TestRunner library
1874         https://bugs.webkit.org/show_bug.cgi?id=112751
1875
1876         Reviewed by Adam Barth.
1877
1878         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1879         * DumpRenderTree/DumpRenderTree.gypi:
1880         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1881         (WebKit):
1882         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1883         (WebTestRunner::TestInterfaces::themeEngine):
1884         (WebTestRunner):
1885         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1886         (WebKit):
1887         (TestInterfaces):
1888         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1889         (WebTestRunner::WebTestInterfaces::themeEngine):
1890         (WebTestRunner):
1891         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1892         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1893         (WebTestRunner):
1894         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1895         (WebTestRunner::WebTestThemeControlWin::box):
1896         (WebTestRunner::WebTestThemeControlWin::line):
1897         (WebTestRunner::WebTestThemeControlWin::triangle):
1898         (WebTestRunner::WebTestThemeControlWin::roundRect):
1899         (WebTestRunner::WebTestThemeControlWin::oval):
1900         (WebTestRunner::WebTestThemeControlWin::circle):
1901         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1902         (WebTestRunner::WebTestThemeControlWin::markState):
1903         (WebTestRunner::WebTestThemeControlWin::draw):
1904         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1905         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1906         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1907         (WebTestRunner):
1908         (WebTestThemeControlWin):
1909         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1910         (WebTestRunner):
1911         (WebTestThemeEngineMac):
1912         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1913         (+[FakeActiveWindow alwaysActiveWindow]):
1914         (+[FakeActiveWindow alwaysInactiveWindow]):
1915         (-[FakeActiveWindow initWithActiveControls:]):
1916         (-[FakeActiveWindow _hasActiveControls]):
1917         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1918         (WebTestRunner):
1919         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1920         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1921         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1922         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1923         (WebTestRunner):
1924         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1925         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1926         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1927         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1928         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1929         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1930         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1931         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1932         (WebTestRunner::WebTestThemeEngineWin::getSize):
1933         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1934         (WebTestRunner):
1935         (WebTestThemeEngineWin):
1936         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1937         * DumpRenderTree/chromium/TestShell.cpp:
1938         (TestShell::initialize):
1939         * DumpRenderTree/chromium/TestShell.h:
1940         (WebKit):
1941         * DumpRenderTree/chromium/TestShellMac.mm:
1942         (platformInit):
1943         * DumpRenderTree/chromium/TestShellWin.cpp:
1944         (platformInit):
1945         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1946
1947 2013-03-19  Tony Chang  <tony@chromium.org>
1948
1949         Move testRunner.setTouchDragDropEnabled to internals.settings
1950         https://bugs.webkit.org/show_bug.cgi?id=112739
1951
1952         Reviewed by Adam Barth.
1953
1954         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1955         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1956         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1957         (TestRunner): Remove unnecessary code.
1958         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1959         (WebTestRunner::WebPreferences::reset):
1960         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1961
1962 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1963
1964         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1965         https://bugs.webkit.org/show_bug.cgi?id=112754
1966
1967         Reviewed by Darin Fisher.
1968
1969         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1970         now that it's always defined.
1971
1972         * DumpRenderTree/chromium/WebViewHost.cpp:
1973         * DumpRenderTree/chromium/WebViewHost.h:
1974         (WebViewHost):
1975
1976 2013-03-19  Kenneth Russell  <kbr@google.com>
1977
1978         Unreviewed, rolling out r146290.
1979         http://trac.webkit.org/changeset/146290
1980         https://bugs.webkit.org/show_bug.cgi?id=112751
1981
1982         Broke Chromium Mac build.
1983
1984         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1985         * DumpRenderTree/DumpRenderTree.gypi:
1986         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1987         (WebKit):
1988         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1989         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1990         (TestInterfaces):
1991         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1992         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1993         * DumpRenderTree/chromium/TestShell.cpp:
1994         (TestShell::initialize):
1995         * DumpRenderTree/chromium/TestShell.h:
1996         (WebKit):
1997         * DumpRenderTree/chromium/TestShellMac.mm:
1998         (platformInit):
1999         * DumpRenderTree/chromium/TestShellWin.cpp:
2000         (platformInit):
2001         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2002         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2003         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2004         (WebThemeControlDRTWin::box):
2005         (WebThemeControlDRTWin::line):
2006         (WebThemeControlDRTWin::triangle):
2007         (WebThemeControlDRTWin::roundRect):
2008         (WebThemeControlDRTWin::oval):
2009         (WebThemeControlDRTWin::circle):
2010         (WebThemeControlDRTWin::nestedBoxes):
2011         (WebThemeControlDRTWin::markState):
2012         (WebThemeControlDRTWin::draw):
2013         (WebThemeControlDRTWin::drawTextField):
2014         (WebThemeControlDRTWin::drawProgressBar):
2015         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2016         (WebThemeControlDRTWin):
2017         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2018         (WebThemeEngineDRTMac):
2019         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2020         (+[FakeActiveWindow alwaysActiveWindow]):
2021         (+[FakeActiveWindow alwaysInactiveWindow]):
2022         (-[FakeActiveWindow initWithActiveControls:]):
2023         (-[FakeActiveWindow _hasActiveControls]):
2024         (WebThemeEngineDRTMac::paintScrollbarThumb):
2025         (stateToHIEnableState):
2026         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2027         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2028         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2029         (webRectToSkIRect):
2030         (drawControl):
2031         (drawTextField):
2032         (drawProgressBar):
2033         (WebThemeEngineDRTWin::paintButton):
2034         (WebThemeEngineDRTWin::paintMenuList):
2035         (WebThemeEngineDRTWin::paintScrollbarArrow):
2036         (WebThemeEngineDRTWin::paintScrollbarThumb):
2037         (WebThemeEngineDRTWin::paintScrollbarTrack):
2038         (WebThemeEngineDRTWin::paintSpinButton):
2039         (WebThemeEngineDRTWin::paintTextField):
2040         (WebThemeEngineDRTWin::paintTrackbar):
2041         (WebThemeEngineDRTWin::paintProgressBar):
2042         (WebThemeEngineDRTWin::getSize):
2043         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2044         (WebThemeEngineDRTWin):
2045         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2046
2047 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2048
2049         [EFL] canvas-fallback-content.html is failing
2050         https://bugs.webkit.org/show_bug.cgi?id=111998
2051
2052         Reviewed by Chris Fleizach.
2053
2054         Adds support for getting platform name.
2055
2056         * DumpRenderTree/TestRunner.cpp:
2057         (TestRunner::staticValues):
2058         * DumpRenderTree/TestRunner.h:
2059         (TestRunner):
2060         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2061         (TestRunner::platformName):
2062
2063 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2064
2065         [chromium] move WebThemeEngine implementations to TestRunner library
2066         https://bugs.webkit.org/show_bug.cgi?id=112751
2067
2068         Reviewed by Adam Barth.
2069
2070         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2071         * DumpRenderTree/DumpRenderTree.gypi:
2072         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2073         (WebKit):
2074         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2075         (WebTestRunner::TestInterfaces::themeEngine):
2076         (WebTestRunner):
2077         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2078         (WebKit):
2079         (TestInterfaces):
2080         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2081         (WebTestRunner::WebTestInterfaces::themeEngine):
2082         (WebTestRunner):
2083         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2084         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2085         (WebTestRunner):
2086         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2087         (WebTestRunner::WebTestThemeControlWin::box):
2088         (WebTestRunner::WebTestThemeControlWin::line):
2089         (WebTestRunner::WebTestThemeControlWin::triangle):
2090         (WebTestRunner::WebTestThemeControlWin::roundRect):
2091         (WebTestRunner::WebTestThemeControlWin::oval):
2092         (WebTestRunner::WebTestThemeControlWin::circle):
2093         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2094         (WebTestRunner::WebTestThemeControlWin::markState):
2095         (WebTestRunner::WebTestThemeControlWin::draw):
2096         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2097         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2098         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2099         (WebTestRunner):
2100         (WebTestThemeControlWin):
2101         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2102         (WebTestRunner):
2103         (WebTestThemeEngineMac):
2104         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2105         (+[FakeActiveWindow alwaysActiveWindow]):
2106         (+[FakeActiveWindow alwaysInactiveWindow]):
2107         (-[FakeActiveWindow initWithActiveControls:]):
2108         (-[FakeActiveWindow _hasActiveControls]):
2109         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2110         (WebTestRunner):
2111         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2112         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2113         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2114         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2115         (WebTestRunner):
2116         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2117         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2118         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2119         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2120         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2121         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2122         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2123         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2124         (WebTestRunner::WebTestThemeEngineWin::getSize):
2125         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2126         (WebTestRunner):
2127         (WebTestThemeEngineWin):
2128         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2129         * DumpRenderTree/chromium/TestShell.cpp:
2130         (TestShell::initialize):
2131         * DumpRenderTree/chromium/TestShell.h:
2132         (WebKit):
2133         * DumpRenderTree/chromium/TestShellMac.mm:
2134         (platformInit):
2135         * DumpRenderTree/chromium/TestShellWin.cpp:
2136         (platformInit):
2137         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2138
2139 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2140
2141         [EFL][WK2] Separate WebView further from EwkView
2142         https://bugs.webkit.org/show_bug.cgi?id=111591
2143
2144         Reviewed by Caio Marcelo de Oliveira Filho.
2145
2146         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2147         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2148         since we can afford it having EWKViewGetWKView() private API to access WKView.
2149
2150         * TestWebKitAPI/PlatformWebView.h:
2151         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/efl/PlatformWebView.cpp:
2154         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2155         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2156         (TestWebKitAPI::PlatformWebView::resizeTo):
2157         (TestWebKitAPI::PlatformWebView::page):
2158         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2159         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2160         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2161         * WebKitTestRunner/PlatformWebView.h:
2162         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2163         (WTR::EventSenderProxy::dispatchEvent):
2164         (WTR::EventSenderProxy::keyDown):
2165         (WTR::EventSenderProxy::sendTouchEvent):
2166         (WTR::EventSenderProxy::setTouchModifier):
2167         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2168         (WTR::PlatformWebView::PlatformWebView):
2169         (WTR::PlatformWebView::~PlatformWebView):
2170         (WTR::PlatformWebView::resizeTo):
2171         (WTR::PlatformWebView::page):
2172         (WTR::PlatformWebView::focus):
2173         (WTR::PlatformWebView::windowSnapshotImage):
2174
2175 2013-03-19  Roger Fong  <roger_fong@apple.com>
2176
2177         Changes to VS2010 project files should only trigger builds on Windows bots.
2178         https://bugs.webkit.org/show_bug.cgi?id=112731
2179
2180         Reviewed by Timothy Horton.
2181
2182         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2183         (_should_file_trigger_build):
2184
2185 2013-03-19  Roger Fong  <roger_fong@apple.com>
2186
2187         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2188
2189         * Scripts/webkitpy/tool/steps/runtests.py:
2190         (RunTests.run):
2191         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2192         (RunTestsTest.test_webkit_run_unit_tests):
2193
2194 2013-03-19  Julie Parent  <jparent@chromium.org>
2195
2196         Dashboards: Introduce history namespace and unit tests.
2197         https://bugs.webkit.org/show_bug.cgi?id=112645
2198
2199         Reviewed by Ojan Vafai.
2200         
2201         Laying the framework for introducing the new history object and
2202         namespace.  This moves only static functions into the history
2203         namespace, and moves corresponding unit tests into seperate
2204         unit test file.
2205
2206         * TestResultServer/static-dashboards/aggregate_results.html:
2207         * TestResultServer/static-dashboards/dashboard_base.js:
2208         (parseCrossDashboardParameters):
2209         (parseDashboardSpecificParameters):
2210         (parseParameters):
2211         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2212         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2213         (.switch.return):
2214         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2215         * TestResultServer/static-dashboards/history.js: Added.
2216         * TestResultServer/static-dashboards/history_unittests.js: Added.
2217         * TestResultServer/static-dashboards/loader.js:
2218         (.):
2219         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2220         * TestResultServer/static-dashboards/run-unittests.html:
2221         * TestResultServer/static-dashboards/timeline_explorer.html:
2222         * TestResultServer/static-dashboards/timeline_explorer.js:
2223         * TestResultServer/static-dashboards/treemap.html:
2224         * TestResultServer/static-dashboards/treemap.js:
2225         (.switch.return):
2226         * TestResultServer/static-dashboards/ui.js:
2227
2228 2013-03-19  Daniel Bates  <dbates@webkit.org>
2229
2230         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2231         https://bugs.webkit.org/show_bug.cgi?id=112732
2232
2233         Reviewed by Eric Seidel.
2234
2235         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2236         of an existing file cannot be applied.
2237
2238         In particular, svn-{apply, unapply} compensate for differences in line endings
2239         by converting the line endings in a diff to match the line endings in the target
2240         file. The diff(1) command precedes the last line of a diff that adds a newline
2241         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2242         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2243         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2244         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2245         the newline characters in this special character sequence to match the line endings
2246         in the target file.
2247
2248         * Scripts/VCSUtils.pm:
2249         (parseDiff):
2250         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2251         Added tests:
2252             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2253             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2254             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2255             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2256         (escapeNewLineCharacters): Added.
2257         (toMacLineEndings): Added.
2258
2259 2013-03-19  James Robinson  <jamesr@chromium.org>
2260
2261         [chromium] Remove compositor settings that don't go through WebKit
2262         https://bugs.webkit.org/show_bug.cgi?id=112718
2263
2264         Reviewed by Adam Barth.
2265
2266         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2267         (main):
2268         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2269         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2270         (WebTestRunner::WebPreferences::reset):
2271         (WebTestRunner::WebPreferences::applyTo):
2272         * DumpRenderTree/chromium/TestShell.cpp:
2273         (TestShell::TestShell):
2274         (TestShell::resetWebSettings):
2275         * DumpRenderTree/chromium/TestShell.h:
2276         (TestShell):
2277
2278 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2279
2280         Unreviewed, rolling out r146101.
2281         https://bugs.webkit.org/show_bug.cgi?id=111884
2282
2283         re-enable custom freetype on asan; this needs to be on
2284         now that the bot is running lucid.
2285
2286         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2287
2288 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2289
2290         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2291         https://bugs.webkit.org/show_bug.cgi?id=112365
2292
2293         Reviewed by Benjamin Poulain.
2294
2295         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2296         harcoding it in wtf/Platform.h
2297
2298         * Scripts/webkitperl/FeatureList.pm:
2299
2300 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2301
2302         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2303         https://bugs.webkit.org/show_bug.cgi?id=94782
2304
2305         Based on patch by Csaba Osztrogonác.
2306         Reviewed by Jocelyn Turcotte.
2307
2308         The diff image is generated with bright red indicating errors, but letting the base image
2309         shine through so the context of the error-pixel can be identified.
2310
2311         * DumpRenderTree/qt/ImageDiff.cpp:
2312         (main):
2313
2314 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2315
2316         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2317
2318         Rubber-stamped by Csaba Osztrogonác.
2319
2320         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2321         since the latter might not cover the former.
2322
2323         * QtTestBrowser/launcherwindow.cpp:
2324         (LauncherWindow::print):
2325
2326 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2327
2328         Style tweeks to default.css.
2329         
2330         Rubber-stamped by David Kilzer.
2331         
2332         Give visited links a different color to other links, so you can
2333         see which builds you've viewed.
2334         
2335         Make the <small> text less tiny.
2336
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2338         (small):
2339         (a:link,a:visited,a:active):
2340         (a:visited):
2341
2342 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2343
2344         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2345         https://bugs.webkit.org/show_bug.cgi?id=112494
2346
2347         Reviewed by Dirk Pranke.
2348
2349         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2350         Also merged two pairs of methods to cleanup the code.
2351
2352         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2353         (PerfTestsRunner.run): Merged _upload_and_show_results.
2354         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2355
2356 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2357
2358         [chromium] build xdisplaycheck when building DRT
2359         https://bugs.webkit.org/show_bug.cgi?id=112636
2360
2361         Reviewed by Tony Chang.
2362
2363         It appears that we need xdisplaycheck to be built in order for
2364         Xvfb to be started correctly on the bots, and DRT was missing
2365         a dependency on it. This may be the cause of the ASAN bot not
2366         starting up properly (it only builds DRT).
2367
2368         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2369
2370 2013-03-18  David Levin  <levin@chromium.org>
2371
2372         Implement icon change notification dump for Chromium's test shell.
2373         https://bugs.webkit.org/show_bug.cgi?id=112614
2374
2375         This was previously implemented for some other platforms in r58111
2376         and r116547.
2377
2378         In r122806, fast/dom/icon-url-property.html stopped using it, but
2379         it is useful for tests, so I plan to re-add it to that test again.
2380
2381         Reviewed by Jochen Eisinger.
2382
2383         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2384         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2385          icon change notifications from WebKit may be logged in test output.
2386         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2387         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2388         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2389         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2390         (WebTestRunner):
2391         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2392         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2393         (TestRunner):
2394         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2395         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2396         (WebTestRunner):
2397         * DumpRenderTree/chromium/WebViewHost.cpp:
2398         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2399         * DumpRenderTree/chromium/WebViewHost.h:
2400         (WebViewHost):
2401
2402 2013-03-18  Julie Parent  <jparent@chromium.org>
2403
2404         Cleanup: Move js for treemap and aggregate_results into own js files.
2405         https://bugs.webkit.org/show_bug.cgi?id=112618
2406
2407         Reviewed by Dirk Pranke.
2408         
2409         No functional changes, just moving the code into separate js file
2410         rather than inlined in the html, so we can test it, make it more
2411         modular, etc.  Other dashboard types are already done this way.
2412
2413         * TestResultServer/static-dashboards/aggregate_results.html:
2414         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2415         (generatePage):
2416         (handleValidHashParameter):
2417         (htmlForBuilder):
2418         (rawValuesHTML):
2419         (chartHTML):
2420         (filteredValues):
2421         (chart):
2422         (htmlForRevisionRows):
2423         (wrapHTMLInTable):
2424         (htmlForSummaryTable):
2425         (valuesPerExpectation):
2426         (htmlForTestType):
2427         (htmlForTableRow):
2428         (extendedEncode):
2429         * TestResultServer/static-dashboards/treemap.html:
2430         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2431         (humanReadableTime):
2432         (convertToWebTreemapFormat):
2433         (reverseSortByAverage):
2434         (generatePage):
2435         (focusPath):
2436         (.switch.return):
2437         (handleQueryParameterChange):
2438         (extractName):
2439         (fullName):
2440         (handleFocus.):
2441         (handleFocus):
2442
2443 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2444
2445         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2446         https://bugs.webkit.org/show_bug.cgi?id=112622
2447
2448         Reviewed by Dirk Pranke.
2449
2450         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2451         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2452
2453 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2454
2455         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2456         https://bugs.webkit.org/show_bug.cgi?id=112619
2457
2458         Reviewed by Dirk Pranke.
2459
2460         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2461         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2462
2463         * Scripts/webkitpy/layout_tests/port/gtk.py:
2464         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2465         Port._webkit_baseline_path method.
2466         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2467         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2468         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2469         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2470         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2471         that are expected based on the builder name.
2472
2473 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2474
2475         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2476         https://bugs.webkit.org/show_bug.cgi?id=112571
2477
2478         Reviewed by Adam Barth.
2479
2480         Update function declarations for new WebFileSystemType enum. (All
2481         changes are behind an #ifdef so we can sync required changes in embedders.)
2482
2483         * DumpRenderTree/chromium/WebViewHost.cpp:
2484         (WebViewHost::openFileSystem):
2485         (WebViewHost::deleteFileSystem):
2486         * DumpRenderTree/chromium/WebViewHost.h:
2487         (WebViewHost):
2488
2489 2013-03-18  Julie Parent  <jparent@chromium.org>
2490
2491         Cleanup: Move timeline_exporer js out of html file into js.
2492         https://bugs.webkit.org/show_bug.cgi?id=112188
2493
2494         Reviewed by Dirk Pranke.
2495         
2496         Moves the javascript out of the html file and into a new js file.
2497         This follows the format of flakiness_dashboard.{html|js}.
2498         
2499         Also moves code from dashboard_base that is used only by this one
2500         dashboard, and makes it private to the dashboard.
2501
2502         * TestResultServer/static-dashboards/dashboard_base.js:
2503         * TestResultServer/static-dashboards/timeline_explorer.html:
2504         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2505         (generatePage):
2506         (initCurrentBuilderTestResults):
2507         (shouldShowWebKitRevisionsOnly):
2508         (updateTimelineForBuilder.):
2509         (updateTimelineForBuilder):
2510         (selectBuild):
2511         (updateBuildIndicator):
2512         (.addRow):
2513         (.addNumberRow):
2514         (.inspectorNode.getElementsByTagName.0.onclick):
2515         (.inspectorNode.getElementsByTagName.1.onclick):
2516         (.inspectorNode.getElementsByTagName.2.onclick):
2517         (updateBuildInspector):
2518         (showResultsDelta):
2519         (decompressResults.addFlakyDelta):
2520         (decompressResults):
2521
2522 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2523
2524         Unreviewed, rolling out r145272.
2525         http://trac.webkit.org/changeset/145272
2526         https://bugs.webkit.org/show_bug.cgi?id=111884
2527
2528         Turns out the ASAN build is still broken; possibly there's
2529         something still setting LD_LIBRARY_PATH, or possibly there's
2530         something else wrong. In the meantime, we need it to work again.
2531
2532         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2533
2534 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2535
2536         delete-stale-build-files is too aggressive
2537         https://bugs.webkit.org/show_bug.cgi?id=112595
2538
2539         Reviewed by Tim Horton.
2540
2541         It appears that whitelisting file extensions to keep is not a good idea.
2542         Blacklist files to delete instead, and only delete .o files for now.
2543         We can add more file extensions as needed.
2544
2545         * BuildSlaveSupport/delete-stale-build-files:
2546
2547 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2548
2549         Disable accessibility notifications after each test
2550         https://bugs.webkit.org/show_bug.cgi?id=112579
2551
2552         Reviewed by Tim Horton.
2553         
2554         In WebKitTestRunner, if any tests triggered accessibility notifications,
2555         the global notification handler would thereafter be active, and fire
2556         notifications for all subsequent tests.
2557         
2558         Fix by implementing AccessibilityController::resetToConsistentState() for
2559         Mac, and using it to clear the global notification handler.
2560
2561         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2562         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2563         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2564         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2565         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2566         (e.g. because of -autorelease).
2567         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2568         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2569         if there is one.
2570         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2571         Add -stopObserving
2572         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2573         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2574         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2575         center.
2576
2577 2013-03-18  Dana Jansens  <danakj@chromium.org>
2578
2579         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2580         https://bugs.webkit.org/show_bug.cgi?id=112392
2581
2582         Reviewed by James Robinson.
2583
2584         Removes the command line flag option from DRT.
2585
2586         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2587         (main):
2588
2589 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2590
2591         [GTK] plugins/plugin-clip-subframe.html is failing
2592         https://bugs.webkit.org/show_bug.cgi?id=112570
2593
2594         Reviewed by Martin Robinson.
2595
2596         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2597
2598 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2599
2600         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2601         https://bugs.webkit.org/show_bug.cgi?id=112442
2602
2603         Reviewed by Gustavo Noronha Silva.
2604
2605         * GtkLauncher/main.c:
2606         (reloadCb):
2607         (createToolbar):
2608         (createWindow):
2609
2610 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2611
2612         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2613         https://bugs.webkit.org/show_bug.cgi?id=112205
2614
2615         Disable this API test until Geoff can fix it.
2616
2617         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2618         (TestWebKitAPI::TEST):
2619
2620 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2621
2622         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2623         https://bugs.webkit.org/show_bug.cgi?id=112478
2624
2625         Reviewed by Tony Chang.
2626
2627         There is nothing that ensures that the log messages from the plugin
2628         come in before the layout test finished loading.
2629
2630         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2631         (PassDifferentNPPStruct::NPP_SetWindow):
2632         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2633         (NPP_SetWindow):
2634
2635 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2636
2637         Have the mac port support per_test_timeout in webkitpy
2638         https://bugs.webkit.org/show_bug.cgi?id=112466
2639
2640         Reviewed by Dirk Pranke.
2641         
2642         Both WTR and DRT handle --timeout arguments, so we can
2643         have the scripts pass the timeout values down to the tools.
2644
2645         * Scripts/webkitpy/layout_tests/port/mac.py:
2646         (MacPort.supports_per_test_timeout):
2647
2648 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2649
2650         Remove setAsynchronousSpellCheckingEnabled from test runners
2651         https://bugs.webkit.org/show_bug.cgi?id=112362
2652
2653         Reviewed by Tony Chang.
2654
2655         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2656         in internals.settings, so all ports can share it.
2657
2658         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2659         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2660         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2661         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2662         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2663         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2664         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2665         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2666         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2667         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2668         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2669         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2670
2671 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2672
2673         Fix the stupid unit tests.
2674
2675         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2676         (test_sample_process):
2677
2678 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2679
2680         Collect samples for unresponsive web processes
2681         https://bugs.webkit.org/show_bug.cgi?id=112409
2682
2683         Reviewed by Tim Horton.
2684         
2685         When we detect that a subprocess was unresponsive, run the 'sample'
2686         tool on that process, for the Mac port.
2687         
2688         The sample will be linked to from the results.html page, next
2689         to the crash log link.
2690
2691         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2692         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2693         look for samples on disk.
2694         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2695         (TestResultWriter):
2696         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2697         -sample.txt files, and have it copy their contents to a new file
2698         next to the test that spawned them (as we do for crash logs).
2699         * Scripts/webkitpy/layout_tests/port/base.py:
2700         (Port.look_for_new_samples): Base class does nothing for sampling.
2701         * Scripts/webkitpy/layout_tests/port/driver.py:
2702         (Driver._check_for_driver_crash): Kick off a sample if we detected
2703         that the subprocess was unresponsive.
2704         * Scripts/webkitpy/layout_tests/port/mac.py:
2705         (MacPort.sample_file_path): Utility to generate the file path
2706         to the generated sample files at the top level of layout-test-results.
2707         (MacPort.look_for_new_crash_logs): Fix typo
2708         (MacPort.look_for_new_samples): New function to find sample files.
2709         (MacPort.sample_process): Use the utility function to get the file path.
2710
2711 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2712
2713         [Qt] Remove simple getters and setters from TestRunnerQt
2714         https://bugs.webkit.org/show_bug.cgi?id=112343
2715
2716         Reviewed by Benjamin Poulain.
2717
2718         The removed functions and boolean members
2719         are being replaced by the implementations in the
2720         generic TestRunner.h.
2721
2722         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2723         (DumpRenderTree::dumpFrameScrollPosition):
2724         (DumpRenderTree::dumpFramesAsText):
2725         (DumpRenderTree::dump):
2726         (DumpRenderTree::titleChanged):
2727         (DumpRenderTree::dumpDatabaseQuota):
2728         (DumpRenderTree::dumpApplicationCacheQuota):
2729         (DumpRenderTree::statusBarMessage):
2730         (DumpRenderTree::createWindow):
2731         * DumpRenderTree/qt/TestRunnerQt.cpp:
2732         (TestRunnerQt::reset):
2733         * DumpRenderTree/qt/TestRunnerQt.h:
2734         (TestRunnerQt):
2735
2736 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2737
2738         Update the link on build.webkit.org to refer to perf.webkit.org
2739         https://bugs.webkit.org/show_bug.cgi?id=112416
2740
2741         Reviewed by Philip Rogers.
2742
2743         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2746
2747 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2748
2749         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2750         https://bugs.webkit.org/show_bug.cgi?id=112394
2751
2752         Reviewed by Philippe Normand.
2753
2754         * GtkLauncher/main.c:
2755         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2756
2757 2013-03-14  Andreas Kling  <akling@apple.com>
2758
2759         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2760         <http://webkit.org/b/111815>
2761         <rdar://problem/13380145>
2762
2763         Reviewed by Anders Carlsson.
2764
2765         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2766         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2767         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2768
2769         * WebKitTestRunner/PlatformWebView.h:
2770         (PlatformWebView):
2771         * WebKitTestRunner/TestController.cpp:
2772         (WTR::TestController::createOtherPage):
2773         (WTR::TestController::createWebViewWithOptions):
2774         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2775         (WTR::PlatformWebView::didInitializeClients):
2776
2777 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2778
2779         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2780         https://bugs.webkit.org/show_bug.cgi?id=112122
2781
2782         Reviewed by Kenneth Rohde Christiansen.
2783
2784         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2785
2786         * MiniBrowser/efl/main.c:
2787         (_Browser_Window):
2788         (search_box_show):
2789         (search_box_hide):
2790         (on_key_down):
2791         (on_url_changed):
2792         (on_search_field_aborted):
2793         (on_search_field_activated):
2794         (on_search_field_clicked):
2795         (on_search_backward_button_clicked):
2796         (on_search_forward_button_clicked):
2797         (window_create):
2798
2799 2013-03-14  Julie Parent  <jparent@chromium.org>
2800
2801         Cleanup: Remove g_resourceLoader.
2802         https://bugs.webkit.org/show_bug.cgi?id=112305
2803
2804         Reviewed by Dirk Pranke.
2805         
2806         Removing another global.
2807         
2808         Now, each dashboard creates its own loader, rather than having
2809         a general global one.
2810         
2811         Remove usage of g_resourceLoader.isLoadingComplete from 
2812         handleLocationChange by ensuring that handleLocationChange is
2813         never called before the loader is done.  It was called in two
2814         places before: 1 was from the callback when the loader is done,
2815         so that was obviously true, and the other was from onhashchange,
2816         where it would just return rather than running.  Instead, lets
2817         only register the onhashchange handler once the loader is
2818         setup, so the check is no longer necessary.
2819         
2820         Remove isLoadingComplete since it is now unused.
2821         
2822         Callback for loader is now initializeHistory, rather than just
2823         handleLocationChange which will set up the hashchange handler now.
2824         This will all eventually be moving to a new History object.
2825
2826         * TestResultServer/static-dashboards/aggregate_results.html:
2827         * TestResultServer/static-dashboards/dashboard_base.js:
2828         (handleLocationChange):
2829         (intializeHistory):
2830         (decompressResults):
2831         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2832         (generatePage):
2833         * TestResultServer/static-dashboards/loader.js:
2834         (.):
2835         * TestResultServer/static-dashboards/loader_unittests.js:
2836         * TestResultServer/static-dashboards/timeline_explorer.html:
2837         * TestResultServer/static-dashboards/treemap.html:
2838
2839 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2840
2841         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2842         https://bugs.webkit.org/show_bug.cgi?id=109404
2843
2844         Reviewed by Tony Chang.
2845
2846         Removes all the code related to smartInsertDeleteEnabled and
2847         selectTrailingWhitespaceEnabled settings as they will be managed from
2848         internals from now on.
2849
2850         * DumpRenderTree/TestRunner.cpp:
2851         (TestRunner::staticFunctions):
2852         * DumpRenderTree/TestRunner.h:
2853         (TestRunner):
2854         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2855         (WebKit):
2856         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2857         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2858         (DumpRenderTree):
2859         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2860         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2861         (WebTestRunner::WebTestProxy::didStopLoading):
2862         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2863         (WebTestRunner::TestRunner::TestRunner):
2864         (WebTestRunner::TestRunner::reset):
2865         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2866         (TestRunner):
2867         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2868         (WebTestRunner::WebPreferences::applyTo): Set default values for
2869         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2870         Chromium DRT default values are different from Chromium browser.
2871         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2872         * DumpRenderTree/chromium/WebViewHost.cpp:
2873         * DumpRenderTree/chromium/WebViewHost.h:
2874         (WebViewHost):
2875         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2876         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2877         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2878         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2879         (resetDefaultsToConsistentValues):
2880         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2881         * DumpRenderTree/mac/DumpRenderTree.mm:
2882         (resetWebViewToConsistentStateBeforeTesting):
2883         * DumpRenderTree/mac/TestRunnerMac.mm:
2884         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2885         (WebCore::WebPage::resetSettings):
2886         * DumpRenderTree/qt/TestRunnerQt.cpp:
2887         * DumpRenderTree/qt/TestRunnerQt.h:
2888         (TestRunnerQt):
2889         * DumpRenderTree/win/DumpRenderTree.cpp:
2890         (resetWebViewToConsistentStateBeforeTesting):
2891         * DumpRenderTree/win/TestRunnerWin.cpp:
2892         * DumpRenderTree/wx/TestRunnerWx.cpp:
2893
2894 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2895
2896         [Qt] Disable DRT on Windows
2897
2898         Reviewed by Jocelyn Turcotte.
2899
2900         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2901
2902         * qmake/mkspecs/features/configure.prf:
2903
2904 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2905
2906         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2907         https://bugs.webkit.org/show_bug.cgi?id=110728
2908
2909         Reviewed by Gyuyoung Kim.
2910
2911         Use the page group to create the view object.
2912
2913         * MiniBrowser/efl/main.c:
2914         (window_create):
2915
2916 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2917
2918         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2919
2920         Reviewed by Tor Arne Vestbø.
2921
2922         The mock versions of these web facing features should be instantiated when
2923         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2924         such as QtLocation are actually needed.
2925
2926         This patch decouples enabling device orientation/motion and geolocation from
2927         the underlying Qt modules and makes them available in developer builds
2928         (!production_build) and backed by mock backends when running in drt.
2929
2930         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2931         developers the web facing features are always enabled (although requests will
2932         time out) and the mock backends are enabled inside DRT, allowing for the layout
2933         tests to run with less dependencies.
2934
2935         In addition this also enables the mock device motion client, which was
2936         previously never instantiated.
2937
2938         * qmake/mkspecs/features/features.prf:
2939
2940 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2941
2942         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2943         https://bugs.webkit.org/show_bug.cgi?id=112340
2944
2945         Reviewed by Simon Hausmann.
2946
2947         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2948         (DumpRenderTree::dump):
2949             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2950         (DumpRenderTree::dumpApplicationCacheQuota):
2951         * DumpRenderTree/qt/TestRunnerQt.cpp:
2952         (TestRunnerQt::reset):
2953         * DumpRenderTree/qt/TestRunnerQt.h:
2954         (TestRunnerQt):
2955
2956 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2957
2958         [Qt] Port DRT to use TestRunner::dumpAsText()
2959         https://bugs.webkit.org/show_bug.cgi?id=112260
2960
2961         Reviewed by Benjamin Poulain.
2962
2963         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2964         (WebCore::DumpRenderTree::open):
2965         (WebCore::methodNameStringForFailedTest):
2966             Change parameter from type TestRunnerQt* to TestRunner*.
2967         (WebCore::DumpRenderTree::dump):
2968             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2969             Instead we should rely on TestRunner::generatePixelResults().
2970         * DumpRenderTree/qt/TestRunnerQt.cpp:
2971         (TestRunnerQt::reset):
2972         * DumpRenderTree/qt/TestRunnerQt.h:
2973         (TestRunnerQt):
2974
2975 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2976
2977         Implement FontLoader interface
2978         https://bugs.webkit.org/show_bug.cgi?id=98395
2979
2980         Reviewed by Eric Seidel.
2981
2982         Enable FontLoadEvents runtime flag for TestShell.
2983
2984         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2985         (WebTestRunner::TestInterfaces::TestInterfaces):
2986
2987 2013-03-13  Julie Parent  <jparent@chromium.org>
2988
2989         CLeanup: remove unnecessary call to parseParameters.
2990         https://bugs.webkit.org/show_bug.cgi?id=112309
2991
2992         Reviewed by Ojan Vafai.
2993         
2994         We call parseCrossDashboardParameters when the dashboard initially
2995         loads to set the state required for loadBuildersList, and then we
2996         call it again once we are fully done with loading, so there is no
2997         reason to call it in the middle of the loading process here.
2998
2999         * TestResultServer/static-dashboards/loader.js:
3000         (.):
3001
3002 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3003
3004         Unreviewed. Now I'm a reviewer :)
3005
3006         * Scripts/webkitpy/common/config/committers.py:
3007
3008 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3009
3010         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3011         https://bugs.webkit.org/show_bug.cgi?id=112277
3012
3013         Reviewed by Adam Barth.
3014
3015         * Scripts/webkitperl/FeatureList.pm:
3016         * qmake/mkspecs/features/features.pri:
3017
3018 2013-03-13  Adam Barth  <abarth@webkit.org>
3019
3020         run-perf-tests should support content_shell
3021         https://bugs.webkit.org/show_bug.cgi?id=112291
3022
3023         Reviewed by Eric Seidel.
3024
3025         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3026         (PerfTestsRunner._parse_args):
3027
3028 2013-03-13  Oliver Hunt  <oliver@apple.com>
3029
3030         Simplify Checked<> multiplication
3031         https://bugs.webkit.org/show_bug.cgi?id=112286
3032
3033         Reviewed by James Robinson.
3034
3035         Add tests for multiplication by zero and max to ensure we don't
3036         mess them up should we ever make changes to Checked<> in future.
3037
3038         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3039         (TestWebKitAPI):
3040
3041 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3042
3043         [Qt] Unreviewed prospective Windows build fix
3044
3045         Do the usual thing, include the moc generated code in the .cpp file instead
3046         of compiling it standalone, to ensure that config.h is included, too, and
3047         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3048
3049         * DumpRenderTree/qt/EventSenderQt.cpp:
3050
3051 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3052
3053         [Qt] Port TestRunner::findString to shared interface
3054         https://bugs.webkit.org/show_bug.cgi?id=112147
3055
3056         Reviewed by Jocelyn Turcotte.
3057
3058         This patch also removes DumpRenderTree and some other helper classes from
3059         the WebCore namespace, to which they do not really belong.
3060
3061         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3062         (main):
3063         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3064         (DumpRenderTree::DumpRenderTree):
3065         (DumpRenderTree::~DumpRenderTree):
3066         (DumpRenderTree::instance):
3067         (DumpRenderTree::setShouldTimeout):
3068         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3069         (DumpRenderTree):
3070         * DumpRenderTree/qt/EventSenderQt.cpp:
3071         (EventSender::contextClick):
3072         (EventSender::sendEvent):
3073         (EventSender::postEvent):
3074         * DumpRenderTree/qt/EventSenderQt.h:
3075         (EventSender::isGraphicsBased):
3076         * DumpRenderTree/qt/TestRunnerQt.cpp:
3077         (TestRunnerQt::TestRunnerQt):
3078         (TestRunner::findString):
3079         (TestRunnerQt::setMockDeviceOrientation):
3080         (TestRunnerQt::setGeolocationPermission):
3081         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3082         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3083         (TestRunnerQt::setMockGeolocationPosition):
3084         * DumpRenderTree/qt/TestRunnerQt.h:
3085         (TestRunnerQt):
3086
3087 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3088
3089         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3090         https://bugs.webkit.org/show_bug.cgi?id=112129
3091
3092         Reviewed by Adam Barth.
3093
3094         Following Chromium
3095         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3096         this is being renamed to better explain what it does.
3097
3098         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3099
3100 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3101
3102         [Qt] Unreviewed trivial typo fix
3103
3104         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3105         TextRunner.h. Thanks Zeno :)
3106
3107 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3108
3109         [Qt] Prepare DRT for transition to shared TestRunner interface
3110         https://bugs.webkit.org/show_bug.cgi?id=112144
3111
3112         Reviewed by Benjamin Poulain.
3113
3114         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3115         the JSC C API based one.
3116
3117         This is impplemented by instantiating the QObject based testRunner in
3118         the global object, then instantiating the JSC C based TestRunner
3119         separately and placing it "behind" the QObject based testRunner through
3120         injection of the individual functions through proxies. (prototype
3121         chaining doesn't work due to the this object and Function.prototype.bind
3122         doesn't work due to the native function)
3123
3124         This allows for porting over method by method by removing the method
3125         from the QObject TestRunnerQt and implementing it in the JSC C based
3126         TestRunner.
3127
3128         In order for this to link and run dummy implementations of all the
3129         necessary TestRunner functions are provided.
3130
3131         * DumpRenderTree/qt/DumpRenderTree.pro:
3132         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3133         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3134         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3135         (WebCore::DumpRenderTree::initJSObjects):
3136         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3137         (DumpRenderTree):
3138         * DumpRenderTree/qt/TestRunnerQt.cpp:
3139         (TestRunner::~TestRunner):
3140         (TestRunner::addDisallowedURL):
3141         (TestRunner::queueLoad):
3142         (TestRunner::removeAllVisitedLinks):
3143         (TestRunner::setAcceptsEditing):
3144         (TestRunner::simulateLegacyWebNotificationClick):
3145         (TestRunner::setWindowIsKey):
3146         (TestRunner::setAlwaysAcceptCookies):
3147         (TestRunner::addOriginAccessWhitelistEntry):
3148         (TestRunner::setWebViewEditable):
3149         (TestRunner::clearAllApplicationCaches):
3150         (TestRunner::setTextDirection):
3151         (TestRunner::notifyDone):
3152         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3153         (TestRunner::overridePreference):
3154         (TestRunner::pathToLocalResource):
3155         (TestRunner::removeAllWebNotificationPermissions):
3156         (TestRunner::simulateWebNotificationClick):
3157         (TestRunner::closeIdleLocalStorageDatabases):
3158         (TestRunner::focusWebView):
3159         (TestRunner::setBackingScaleFactor):
3160         (TestRunner::removeChromeInputField):
3161         (TestRunner::addChromeInputField):
3162         (TestRunner::originsWithLocalStorage):
3163         (TestRunner::deleteAllLocalStorage):
3164         (TestRunner::deleteLocalStorageForOrigin):
3165         (TestRunner::observeStorageTrackerNotifications):
3166         (TestRunner::syncLocalStorage):
3167         (TestRunner::windowCount):
3168         (TestRunner::setWaitToDump):
3169         (TestRunner::waitForPolicyDelegate):
3170         (TestRunner::webHistoryItemCount):
3171         (TestRunner::showWebInspector):
3172         (TestRunner::closeWebInspector):
3173         (TestRunner::evaluateInWebInspector):
3174         (TestRunner::setSerializeHTTPLoads):
3175         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3176         (TestRunner::setCustomPolicyDelegate):
3177         (TestRunner::setDatabaseQuota):
3178         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3179         (TestRunner::resetPageVisibility):
3180         (TestRunner::keepWebHistory):
3181         (TestRunner::goBack):
3182         (TestRunner::originsWithApplicationCache):
3183         (TestRunner::applicationCacheDiskUsageForOrigin):
3184         (TestRunner::display):
3185         (TestRunner::dispatchPendingLoadRequests):
3186         (TestRunner::clearPersistentUserStyleSheet):
3187         (TestRunner::callShouldCloseOnWebView):
3188         (TestRunner::copyDecodedHostName):
3189         (TestRunner::clearBackForwardList):
3190         (TestRunner::clearAllDatabases):
3191         (TestRunner::clearApplicationCacheForOrigin):
3192         (TestRunner::apiTestGoToCurrentBackForwardItem):
3193         (TestRunner::authenticateSession):
3194         (TestRunner::abortModal):
3195         (TestRunner::setStorageDatabaseIdleInterval):
3196         (TestRunner::setAsynchronousSpellCheckingEnabled):
3197         (TestRunner::setXSSAuditorEnabled):
3198         (TestRunner::setSpatialNavigationEnabled):
3199         (TestRunner::setScrollbarPolicy):
3200         (TestRunner::setJavaScriptCanAccessClipboard):
3201         (TestRunner::setAutomaticLinkDetectionEnabled):
3202         (TestRunner::setUserStyleSheetEnabled):
3203         (TestRunner::setUserStyleSheetLocation):
3204         (TestRunner::setUseDashboardCompatibilityMode):
3205         (TestRunner::setTabKeyCyclesThroughElements):
3206         (TestRunner::setSmartInsertDeleteEnabled):
3207         (TestRunner::setSelectTrailingWhitespaceEnabled):
3208         (TestRunner::setPrivateBrowsingEnabled):
3209         (TestRunner::setPluginsEnabled):
3210         (TestRunner::setPopupBlockingEnabled):
3211         (TestRunner::setMockSpeechInputDumpRect):
3212         (TestRunner::setPersistentUserStyleSheetLocation):
3213         (TestRunner::setMockGeolocationPosition):
3214         (TestRunner::setMockGeolocationPositionUnavailableError):
3215         (TestRunner::setMockDeviceOrientation):
3216         (TestRunner::setMainFrameIsFirstResponder):
3217         (TestRunner::setIconDatabaseEnabled):
3218         (TestRunner::setGeolocationPermission):
3219         (TestRunner::setDefersLoading):
3220         (TestRunner::setCacheModel):
3221         (TestRunner::setAuthorAndUserStylesEnabled):
3222         (TestRunner::setAllowFileAccessFromFileURLs):
3223         (TestRunner::setAppCacheMaximumSize):
3224         (TestRunner::setAllowUniversalAccessFromFileURLs):
3225         (TestRunner::setApplicationCacheOriginQuota):
3226         (TestRunner::denyWebNotificationPermission):
3227         (TestRunner::grantWebNotificationPermission):
3228         (TestRunner::setValueForUser):
3229         (TestRunner::setViewModeMediaFeature):
3230         (TestRunner::setPageVisibility):
3231         (TestRunner::addMockSpeechInputResult):
3232         (TestRunner::removeOriginAccessWhitelistEntry):
3233         (TestRunner::addUserScript):
3234         (TestRunner::isCommandEnabled):
3235         (TestRunner::evaluateScriptInIsolatedWorld):
3236         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3237         (TestRunner::copyEncodedHostName):
3238         (TestRunner::addUserStyleSheet):
3239         (TestRunner::findString):
3240         (TestRunner::execCommand):
3241         (TestRunner::localStorageDiskUsageForOrigin):
3242
3243 2013-03-12  Julie Parent  <jparent@chromium.org>
3244
3245         Cleanup: Move flatten-trie to loader.
3246         https://bugs.webkit.org/show_bug.cgi?id=112196
3247
3248         Reviewed by Dirk Pranke.
3249
3250         flatten-trie is used only by the loader, so move it there and make it
3251         private, rather than global in dashbaord_base. Moved the corresponding
3252         unit test from flakiness_dashboard_unittests to loader_unittests.
3253         
3254         * TestResultServer/static-dashboards/dashboard_base.js:
3255         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3256         * TestResultServer/static-dashboards/loader.js:
3257         (.):
3258         * TestResultServer/static-dashboards/loader_unittests.js:
3259
3260 2013-03-12  Oliver Hunt  <oliver@apple.com>
3261
3262         Unbreak api tests
3263
3264         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3265         (TestWebKitAPI):
3266
3267 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3268
3269         Unreviewed, disabling tests for Win EWS.
3270
3271         win-ews obviously cannot keep up with running tests, it's >300 behind.
3272         Probably doesn't help that its (likely) running tests serially.
3273
3274         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3275         (WinEWS):
3276
3277 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3278
3279         Add a --build-directory argument to delete-stale-build-files
3280         https://bugs.webkit.org/show_bug.cgi?id=112198
3281
3282         Reviewed by Ryosuke Niwa.
3283
3284         * BuildSlaveSupport/delete-stale-build-files:
3285         (main): Add --build-directory argument.
3286
3287 2013-03-12  Oliver Hunt  <oliver@apple.com>
3288
3289         Appease MSVC
3290
3291         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3292         (TestWebKitAPI):
3293
3294 2013-03-12  Oliver Hunt  <oliver@apple.com>
3295
3296         Add more Checked<> tests
3297         https://bugs.webkit.org/show_bug.cgi?id=112190
3298
3299         Reviewed by Geoffrey Garen.
3300
3301         Tests!
3302
3303         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3304         (TestWebKitAPI):
3305
3306 2013-03-12  Julie Parent  <jparent@chromium.org>
3307
3308         Cleanup: Move loading complete function into callback, rather than global.
3309         https://bugs.webkit.org/show_bug.cgi?id=112167
3310
3311         Reviewed by Dirk Pranke.
3312         
3313         Stop calling global functions, pass in proper handler to Loader
3314         constructor. Note that the callback is optional, as tests, and
3315         some potential dashboards, do not need one.
3316
3317         * TestResultServer/static-dashboards/dashboard_base.js:
3318         * TestResultServer/static-dashboards/loader.js:
3319         (.):
3320         * TestResultServer/static-dashboards/loader_unittests.js:
3321
3322 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3323
3324         [EFL][WK2] Add popup menu support to MiniBrowser
3325         https://bugs.webkit.org/show_bug.cgi?id=108934
3326
3327         Reviewed by Kenneth Rohde Christiansen.
3328
3329         Implement popup menu support in MiniBrowser by handling popup_menu_show
3330         and popup_menu_hide smart functions on the view and using the Ewk popup
3331         menu API.
3332
3333         * MiniBrowser/efl/main.c:
3334         (_Browser_Window):
3335         (on_popup_menu_discarded):
3336         (on_popup_menu_item_clicked):
3337         (popup_menu_populate):
3338         (on_popup_menu_show):
3339         (on_popup_menu_hide):
3340         (window_create): Use calloc() instead of malloc() to allocate memory for
3341         Browser_Window. This makes sure all the structs members are initialized
3342         to 0 (such as the new elm_popup_menu pointer).
3343
3344 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3345
3346         [GTK] Set up the libPlatformGtk.la library
3347         https://bugs.webkit.org/show_bug.cgi?id=111738
3348
3349         Reviewed by Martin Robinson.
3350
3351         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3352         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3353         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3354
3355 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3356
3357         [GTK] Enable Web Audio in development builds
3358         https://bugs.webkit.org/show_bug.cgi?id=111831
3359
3360         Reviewed by Philippe Normand.
3361
3362         Web Audio is already quite well supported on the GTK port but still has a few issues
3363         that must be addressed before it is enabled by default. Despite that it should be enabled
3364         in development builds just so we are up-to-date with future feature infrastructure changes.
3365         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3366         that's an obvious goal before enabling the feature in release builds.
3367
3368         * Scripts/webkitperl/FeatureList.pm:
3369
3370 2013-03-11  Andreas Kling  <akling@apple.com>
3371
3372         [Mac][WK1] Add support for alert() in MiniBrowser.
3373         <http://webkit.org/b/112090>
3374
3375         Reviewed by Anders Carlsson.
3376
3377         * MiniBrowser/mac/WK1BrowserWindowController.m:
3378         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3379
3380 2013-03-11  Julie Parent  <jparent@chromium.org>
3381
3382         Dashboard cleanup: Create ui.Errors
3383         https://bugs.webkit.org/show_bug.cgi?id=111785
3384
3385         Reviewed by Ojan Vafai.
3386         
3387         Create ui.Errors for handling errors the dashboards
3388         encounter. Loader now has a Error object that it can add to,
3389         and individual dashboards can show errors when desired.
3390         Currently, only flakiness_db shows errors, but this is 
3391         generic and there is no reason why other dbs wouldn't want to
3392         show errors.
3393
3394         * TestResultServer/static-dashboards/dashboard_base.js:
3395         (resourceLoadingComplete):
3396         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3397         (generatePage):
3398         * TestResultServer/static-dashboards/loader.js:
3399         (.):
3400         * TestResultServer/static-dashboards/ui.js:
3401         (.):
3402
3403 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3404
3405         Some StringHasher tests are broken because of missing null termination
3406         https://bugs.webkit.org/show_bug.cgi?id=111284
3407
3408         Reviewed by Darin Adler.
3409
3410         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3411         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3412         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3413         the bug caught by it is now fixed.
3414
3415 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3416
3417         Unreviewed, rolling out r145200.
3418         http://trac.webkit.org/changeset/145200
3419         https://bugs.webkit.org/show_bug.cgi?id=112063
3420
3421         Broke a couple of unit tests (Requested by zdobersek on
3422         #webkit).
3423
3424         * Scripts/webkitperl/FeatureList.pm:
3425
3426 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3427
3428         [GTK] WebKit2-only build fails
3429         https://bugs.webkit.org/show_bug.cgi?id=112033
3430
3431         Reviewed by Gustavo Noronha Silva.
3432
3433         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3434         generic part, WebKit1-specific part and WebKit2-specific part.
3435         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3436         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3437         directly.
3438
3439 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3440
3441         Adding myself to the committers list.
3442
3443         Unreviewed.
3444
3445         * Scripts/webkitpy/common/config/committers.py:
3446
3447 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3448
3449         [BlackBerry] Disable MathML support
3450         https://bugs.webkit.org/show_bug.cgi?id=111929
3451
3452         Reviewed by Rob Buis.
3453
3454         * Scripts/webkitperl/FeatureList.pm:
3455
3456 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3457
3458         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3459         https://bugs.webkit.org/show_bug.cgi?id=111970
3460
3461         Reviewed by Chris Fleizach.
3462
3463         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3464         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3465         undefined symbol.
3466
3467         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3468         (WTR::AccessibilityUIElement::supportedActions):
3469         (WTR):
3470
3471 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3472
3473         [chromium] Android apk targets should depend directly on Java library targets
3474         https://bugs.webkit.org/show_bug.cgi?id=111746
3475
3476         Reviewed by Eric Seidel.
3477
3478         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3479         Make DumpRenderTree_apk depend directly on base_java and net_java.
3480         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3481         Make TestWebKitAPI_apk depend directly on base_java.
3482
3483 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3484
3485         [chromium] remove obsolete user gesture methods from WebFrame
3486         https://bugs.webkit.org/show_bug.cgi?id=111696
3487
3488         Reviewed by Adam Barth.
3489
3490         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3491         (WebTestRunner::TestPlugin::handleInputEvent):
3492         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3493
3494 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3495
3496         Unreviewed, add myself to commiters.py.
3497
3498         * Scripts/webkitpy/common/config/committers.py:
3499
3500 2013-03-08  Julie Parent  <jparent@chromium.org>
3501
3502         Cleanup: Remove dead code.
3503         https://bugs.webkit.org/show_bug.cgi?id=111900
3504
3505         Reviewed by Dirk Pranke.
3506         
3507         Treemap overrides a global function that used to be in 
3508         dashboard_base, but was removed months ago in
3509         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3510         no caller. 
3511
3512         * TestResultServer/static-dashboards/treemap.html:
3513
3514 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3515
3516         Implemented new API for RTCStatsReport object.
3517         https://bugs.webkit.org/show_bug.cgi?id=110333
3518
3519         Reviewed by Adam Barth.
3520
3521         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3522         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3523
3524 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3525
3526         [chromium] use custom freetype on linux asan builds again
3527         https://bugs.webkit.org/show_bug.cgi?id=111884
3528
3529         Reviewed by Tony Chang.
3530
3531         We no longer need the workaround after chromium r186540.
3532
3533         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3534
3535 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3536
3537         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3538         https://bugs.webkit.org/show_bug.cgi?id=111798
3539
3540         Reviewed by Dirk Pranke.
3541
3542         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3543
3544         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3545
3546 2013-03-08  James Robinson  <jamesr@chromium.org>
3547
3548         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3549         https://bugs.webkit.org/show_bug.cgi?id=111632
3550
3551         Reviewed by Adrienne Walker.
3552
3553         * DumpRenderTree/chromium/WebViewHost.cpp:
3554         (WebViewHost::initializeLayerTreeView):
3555         * DumpRenderTree/chromium/WebViewHost.h:
3556         (WebViewHost):
3557
3558 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3559
3560         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3561         https://bugs.webkit.org/show_bug.cgi?id=111297
3562
3563         Reviewed by Kenneth Rohde Christiansen.
3564
3565         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3566         (WTR::TestRunner::setViewModeMediaFeature):
3567
3568 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3569
3570         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3571         https://bugs.webkit.org/show_bug.cgi?id=111814
3572
3573         Reviewed by Ryosuke Niwa.
3574
3575         Add the needed supportedActions() attribute to WKTestRunner.
3576
3577         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3578         (WTR::AccessibilityUIElement::supportedActions):
3579         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3580         (AccessibilityUIElement):
3581         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3582         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3583         (WTR::AccessibilityUIElement::supportedActions):
3584
3585 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3586
3587         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3588         https://bugs.webkit.org/show_bug.cgi?id=111851
3589
3590         Reviewed by Kenneth Rohde Christiansen.
3591
3592         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3593         (TestWebKitAPI::TEST):
3594
3595             Fixed WKURLRef instance leaking.
3596
3597 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3598
3599         [EFL] [WK2] Some authentication tests fail in WebKit2
3600         https://bugs.webkit.org/show_bug.cgi?id=106407
3601
3602         Reviewed by Kenneth Rohde Christiansen.
3603
3604         Add patch from upstream for libsoup 2.40 to fix several authentication
3605         test cases.
3606
3607         * efl/jhbuild.modules:
3608         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3609
3610 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3611
3612         [GTK] Enable Web Audio in development builds
3613         https://bugs.webkit.org/show_bug.cgi?id=111831
3614
3615         Reviewed by Philippe Normand.
3616
3617         Web Audio is already quite well supported on the GTK port but still has a few issues
3618         that must be addressed before it is enabled by default. Despite that it should be enabled
3619         in development builds just so we are up-to-date with future feature infrastructure changes.
3620         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3621         that's an obvious goal before enabling the feature in release builds.
3622
3623         * Scripts/webkitperl/FeatureList.pm:
3624
3625 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3626
3627         [chromium] delay clearing the TestRunners until the main view was deleted
3628         https://bugs.webkit.org/show_bug.cgi?id=111823
3629
3630         Reviewed by Eric Seidel.
3631
3632         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3633         This may call into the test runners which assume that the delegate is
3634         always non-NULL.
3635
3636         * DumpRenderTree/chromium/TestShell.cpp:
3637         (TestShell::~TestShell):
3638
3639 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3640
3641         Sheriffbot whois command can't search by full name
3642         https://bugs.webkit.org/show_bug.cgi?id=111825
3643
3644         Reviewed by Eric Seidel.
3645
3646         Allowed multiple arguments to Sheriffbot's whois command.
3647         Updated test expectations.
3648
3649         * Scripts/webkitpy/tool/bot/irc_command.py:
3650         (Whois.execute):
3651         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3652         (IRCCommandTest.test_whois):
3653
3654 2013-03-07  Nils Barth  <nbarth@chromium.org>
3655
3656         Add Nils Barth and Koji Hara to committers.py
3657         https://bugs.webkit.org/show_bug.cgi?id=111806
3658
3659         Reviewed by Eric Seidel.
3660
3661         * Scripts/webkitpy/common/config/committers.py:
3662
3663 2013-03-07  Glenn Adams  <glenn@skynav.com>
3664
3665         run-pert-tests should have a --test-runner-count option
3666         https://bugs.webkit.org/show_bug.cgi?id=111726
3667
3668         Reviewed by Ryosuke Niwa.
3669
3670         Add --test-runner-count option to run-perf-tests, with default value of 4.
3671         This option allows command line configuration of the number of times to invoke
3672         the test runner (serially, not in parallel) when running a specific test in
3673         a test set.
3674
3675         * Scripts/webkitpy/performance_tests/perftest.py:
3676         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3677         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3678         (PerfTest.run): Rename process_run_count to test_runner_count.
3679         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3680         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3681         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3682         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3683         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3684         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3685         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3686         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3687         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3688         (MainTest.test_run_with_repeat):
3689         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3690         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3691         (MainTest.test_default_args): Add test for default option argument values.
3692         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3693
3694 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3695
3696         Add myself to reviewers.py
3697         https://bugs.webkit.org/show_bug.cgi?id=111757
3698
3699         Reviewed by Eric Seidel.
3700
3701         * Scripts/webkitpy/common/config/committers.py:
3702
3703 2013-03-07  Glenn Adams  <glenn@skynav.com>
3704
3705         run-perf-tests should have a --repeat option
3706         https://bugs.webkit.org/show_bug.cgi?id=100030
3707
3708         Reviewed by Ryosuke Niwa.
3709
3710         Add --repeat option to run-perf-tests, with default value of 1. When greater
3711         than 1, runs test set specified number of times. Note that multiple runs are
3712         not aggregated for statistical purposes.
3713
3714         Incidentally fixed typo: s/suceeds/succeeds/.
3715
3716         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3717         (PerfTestsRunner._parse_args): Add repeat option.
3718         (PerfTestsRunner.run): Add outer repeat loop.
3719         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3720         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3721         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3722         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3723         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3724         (MainTest.test_run_with_json_output): Fix typo.
3725         (MainTest.test_run_with_description): Fix typo.
3726         (MainTest.test_run_respects_no_results): Fix typo.
3727         (MainTest.test_run_with_slave_config_json): Fix typo.
3728         (MainTest.test_run_with_multiple_repositories): Fix typo.
3729         (MainTest.test_run_with_upload_json): Fix typo.
3730         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3731         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3732         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3733         (MainTest.test_parse_args): Add test for repeat option parsing.
3734
3735 2013-03-07  Julie Parent  <jparent@chromium.org>
3736
3737         showAllRuns checkbox no longer works on the stats dashboard
3738         https://bugs.webkit.org/show_bug.cgi?id=111673
3739
3740         Reviewed by Ojan Vafai.
3741
3742         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3743         so we were trying to index into an undefined object.
3744         
3745         * TestResultServer/static-dashboards/dashboard_base.js:
3746         (invalidateQueryParameters):
3747
3748 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3749
3750         [Chromium] Update #include for WebStorageNamespace.h
3751         https://bugs.webkit.org/show_bug.cgi?id=111748
3752
3753         Reviewed by Adam Barth.
3754
3755         In anticipation of removing
3756         WK/chromium/public/WebStorageNamespace.h (once downstream
3757         references have been updated)
3758
3759         * DumpRenderTree/chromium/WebViewHost.cpp:
3760
3761 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3762
3763         run-perf-tests fails due to svn_revision not working on a pure git clone
3764         https://bugs.webkit.org/show_bug.cgi?id=110839
3765
3766         Reviewed by Ryosuke Niwa.
3767
3768         Previously we would call git svn find-rev to look up the commit for
3769         a given revision, and that'll hang in a pure git checkout.
3770
3771         This patch changes the way we look up svn revisions in a git
3772         repository to use git log --grep 'git-svn-id', which is much faster
3773         than grepping ourselves. It also renames timestamp_of_latest_commit()
3774         to timestamp_of_revision() in order to accurately reflect what
3775         the method is doing. Note that this patch only changes the logic
3776         inside latest_revision() and svn_revision(). I'll file a separate
3777         bug to change git_commit_from_svn_revision().
3778
3779         This patch also contains some fixes to unit tests that had bit-rotted
3780         or were otherwise fragile, so that test-webkitpy --all would pass
3781         cleanly, and a fix to outputcapture so that
3782         test-webkitpy -p would work correctly again.
3783
3784         * Scripts/webkitpy/common/checkout/scm/git.py:
3785         (Git.svn_revision):
3786         (Git.timestamp_of_revision):
3787         * Scripts/webkitpy/common/checkout/scm/scm.py:
3788         (SCM.svn_revision):
3789         (SCM.timestamp_of_revision):
3790         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3791         (MockSCM.timestamp_of_revision):
3792         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3793         (_shared_test_commit_with_message):
3794         (test_commit_without_authorization):
3795         (test_timestamp_of_revision):
3796         * Scripts/webkitpy/common/checkout/scm/svn.py:
3797         (SVN.timestamp_of_revision):
3798         * Scripts/webkitpy/common/system/outputcapture.py:
3799           Importing unittest2 directly may not be safe if this module is
3800           imported before the autoinstaller gets a chance to set things up
3801           properly. We don't actually need unittest2 here.
3802         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3803         (PerfTestsRunner._generate_results_dict):
3804
3805 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3806
3807         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3808         https://bugs.webkit.org/show_bug.cgi?id=111756
3809
3810         Reviewed by Kenneth Rohde Christiansen.
3811
3812         Bump libsoup to v2.40.3 to fix the regressions introduced by
3813         previous v2.40.0 bump.
3814
3815         * efl/jhbuild.modules:
3816
3817 2013-03-07  Roger Fong  <roger_fong@apple.com>
3818
3819         Re-enable Win EWS tests.
3820
3821         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3822         (WinEWS):
3823
3824 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3825
3826         [nrwt] handle corrupt http server pid files cleanly
3827         https://bugs.webkit.org/show_bug.cgi?id=111628
3828
3829         Reviewed by Eric Seidel.
3830
3831         If the pid file from a previous http server is corrupt for some
3832         reason, NRWT will just raise errors and not clean it up or recover.
3833         This patch fixes that to at least delete the pid file and
3834         not throw; not that we may still have stale http servers left on
3835         the system, since there's no way to know which pid to kill if
3836         the file was corrupted.
3837
3838         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3839         (HttpServerBase.start):
3840         (HttpServerBase.stop):
3841         (HttpServerBase._remove_pid_file):
3842         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3843         (TestHttpServerBase):
3844         (TestHttpServerBase.test_corrupt_pid_file):
3845
3846 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3847
3848         AX: Can't activate links with VoiceOver in Safari
3849         https://bugs.webkit.org/show_bug.cgi?id=111755
3850
3851         Reviewed by Tim Horton.
3852
3853         * DumpRenderTree/AccessibilityUIElement.cpp:
3854         (supportedActionsCallback):
3855         (AccessibilityUIElement::getJSClass):
3856         * DumpRenderTree/AccessibilityUIElement.h:
3857         (AccessibilityUIElement):
3858         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3859         (AccessibilityUIElement::supportedActions):
3860
3861 2013-03-07  Roger Fong  <roger_fong@apple.com>
3862
3863         Windows debug layout tests are crashing like crazy again.
3864         Disable tests on Win EWS bots temporarily.
3865
3866         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3867         (WinEWS):
3868
3869 2013-03-07  Roger Fong  <roger_fong@apple.com>
3870
3871         Make EWS bots build and test in release.
3872
3873         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3874         (WinEWS):
3875         * Scripts/webkitpy/tool/steps/runtests.py:
3876         (RunTests.run):
3877
3878 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3879
3880         [chromium] don't track the top loading frame if no layout test is currently running
3881         https://bugs.webkit.org/show_bug.cgi?id=111716
3882
3883         Reviewed by Kentaro Hara.
3884
3885         In DRT, we synchronously stop the test and start loading the next test
3886         URL. However, in content_shell, this happens asynchronously. It's
3887         important that the top loading frame is not changed due to stray
3888         navigation events before the next test starts.
3889
3890         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3891         (WebTestRunner::TestRunner::setTopLoadingFrame):
3892
3893 2013-03-06  Julie Parent  <jparent@chromium.org>
3894
3895         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3896         https://bugs.webkit.org/show_bug.cgi?id=111621
3897
3898         Reviewed by Ojan Vafai.
3899         
3900         Creates ui.js, a package for the common UI code the various
3901         dashboards use. HTML generation is now in the ui.html namespace
3902         and popup handling is in ui.popup.
3903         Also moves the event listening for popups to ui.popup.show and
3904         removes it on ui.popup.hid rather than having listener always
3905         around.
3906
3907         * TestResultServer/static-dashboards/aggregate_results.html:
3908         * TestResultServer/static-dashboards/dashboard_base.js:
3909         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3910         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3911         (showPopupForBuild):
3912         (htmlForNavBar):
3913         (generatePageForIndividualTests.if):
3914         (generatePageForIndividualTests):
3915         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3916         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3917         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3918         * TestResultServer/static-dashboards/run-unittests.html:
3919         * TestResultServer/static-dashboards/timeline_explorer.html:
3920         * TestResultServer/static-dashboards/treemap.html:
3921         * TestResultServer/static-dashboards/ui.js: Added.
3922         (.):
3923
3924 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3925
3926         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3927         https://bugs.webkit.org/show_bug.cgi?id=110584
3928
3929         Reviewed by Gyuyoung Kim.
3930
3931         Adds missing implementation of AccessibilityControllerEfl
3932         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3933         so that it can make accessibilityController as a js object.
3934
3935         * DumpRenderTree/AccessibilityController.h:
3936         (AccessibilityController):
3937         * DumpRenderTree/AccessibilityUIElement.h:
3938         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3939         (AccessibilityController::childElementById): Moved declaration to base class.
3940         Implementation can be shared among other ports.
3941         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3942         (AccessibilityController::focusedElement):
3943         (AccessibilityController::rootElement):
3944         (AccessibilityController::accessibleElementById):
3945         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3946         (AccessibilityUIElement::helpText):
3947         * DumpRenderTree/efl/CMakeLists.txt:
3948         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3949         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3950         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3951         (DumpRenderTreeChrome::onWindowObjectCleared):
3952         (DumpRenderTreeChrome::accessibilityController):
3953         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3954         (DumpRenderTreeChrome):
3955         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3956
3957 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3958
3959         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3960         https://bugs.webkit.org/show_bug.cgi?id=42696
3961
3962         Reviewed by Andreas Kling.
3963
3964         * DumpRenderTree/TestRunner.cpp:
3965         (TestRunner::staticFunctions):
3966         * DumpRenderTree/TestRunner.h:
3967         (TestRunner):
3968         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3969         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3970         (WebTestRunner::TestRunner::TestRunner):
3971         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3972         (TestRunner):
3973         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3974         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3975         * DumpRenderTree/mac/TestRunnerMac.mm:
3976         * DumpRenderTree/qt/TestRunnerQt.cpp:
3977         * DumpRenderTree/qt/TestRunnerQt.h:
3978         (TestRunnerQt):
3979         * DumpRenderTree/win/TestRunnerWin.cpp:
3980         * DumpRenderTree/wx/TestRunnerWx.cpp:
3981
3982 2013-03-06  Roger Fong  <roger_fong@apple.com>
3983
3984         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3985
3986         * EWSTools/start-queue-win.sh:
3987         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3988         (WinEWS):
3989
3990 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3991
3992         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3993         https://bugs.webkit.org/show_bug.cgi?id=82866
3994
3995         Reviewed by Martin Robinson.
3996
3997         * Scripts/run-gtk-tests:
3998         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3999         it is passing now.
4000
4001 2013-03-06  Julie Parent  <jparent@chromium.org>
4002
4003         Dashboard cleanup: remove dashboard time logging.
4004         https://bugs.webkit.org/show_bug.cgi?id=111608
4005
4006         Reviewed by Dirk Pranke.
4007
4008         Remove logTime.  It was never accurate, and the dev tools
4009         have better ways to measure this if anyone cares to look
4010         into dashboard perf.
4011         
4012         * TestResultServer/static-dashboards/dashboard_base.js:
4013         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4014         (processTestRunsForBuilder):
4015         (appendHTML):
4016
4017 2013-03-06  Tony Chang  <tony@chromium.org>
4018
4019         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4020         https://bugs.webkit.org/show_bug.cgi?id=111509
4021
4022         Reviewed by Dirk Pranke.
4023
4024         Add DumpRenderTree.pak to DumpRenderTree.app again.
4025
4026         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4027
4028 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4029
4030         [chromium] introduce WebUserGestureIndicator
4031         https://bugs.webkit.org/show_bug.cgi?id=111531
4032
4033         Reviewed by Adam Barth.
4034
4035         * DumpRenderTree/chromium/WebViewHost.cpp:
4036         (WebViewHost::createView):
4037
4038 2013-03-06  Alan Cutter  <alancutter@chromium.org>
4039
4040         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
4041         https://bugs.webkit.org/show_bug.cgi?id=73482
4042
4043         Reviewed by Ryosuke Niwa.
4044
4045         Added input checking to the UpdateChromiumDEPS step.
4046         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
4047
4048         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
4049         (RollChromiumDEPS):
4050         (RollChromiumDEPS._parse_args):
4051         (RollChromiumDEPS.execute):
4052         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
4053         (IRCCommandTest.test_roll_chromium_deps):
4054         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
4055         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
4056         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
4057         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
4058         (UpdateChromiumDEPS._fetch_last_known_good_revision):
4059         (UpdateChromiumDEPS):
4060         (UpdateChromiumDEPS._parse_revision_number):
4061         (UpdateChromiumDEPS._validate_revisions):
4062         (UpdateChromiumDEPS.run):
4063         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
4064         (UpdateChromiumDEPSTest):
4065         (UpdateChromiumDEPSTest.test_parse_revision_number):
4066         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
4067         (RollChromiumDEPS):
4068         (PostChromiumDEPSRoll):
4069
4070 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
4071
4072         [Qt][MiniBrowser] Touch mocking broken for chained getures
4073         https://bugs.webkit.org/show_bug.cgi?id=111430
4074
4075         Reviewed by Jocelyn Turcotte.
4076
4077         Make it possible again to use touch mocking to test gesture chains
4078         like pan->pinch->pan->pinch without lifting the primary "finger".
4079         For this to work we need to track the pressed mouse buttons and
4080         only synthesize touch release events when the ctrl key is released
4081         if no mouse button is pressed. Else the pressed mouse button(s)
4082         should result in a stationary touch point in a touch update event.
4083         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
4084         to check for the state of the ctrl key modifier instead of getting
4085         it from the mouse events.
4086
4087         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4088         (MiniBrowserApplication::MiniBrowserApplication):
4089         (MiniBrowserApplication::notify):
4090
4091 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4092
4093         [chromium] don't use custom freetype on linux asan for now
4094         https://bugs.webkit.org/show_bug.cgi?id=111516
4095
4096         Unreviewed, build fix.
4097
4098         Turns out the custom lib is getting picked up by other binaries
4099         on our bot, which is bad.
4100
4101         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4102
4103 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4104
4105         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4106         https://bugs.webkit.org/show_bug.cgi?id=111509
4107
4108         Unreviewed, build fix.
4109
4110         Actually comment out the flag :(.
4111
4112         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4113
4114 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4115
4116         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4117         https://bugs.webkit.org/show_bug.cgi?id=111509
4118
4119         Unreviewed, build fix.
4120
4121         r144863 appears to have broken the xcode build; I'm temporarily
4122         trying this instead, and if this doesn't work, I'll revert the
4123         other changes.
4124
4125         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4126
4127 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4128
4129         [chromium] build a DumpRenderTree.pak even on windows
4130         https://bugs.webkit.org/show_bug.cgi?id=111504
4131
4132         Reviewed by Tony Chang.
4133
4134         The Chromium Aura build uses the default theme to draw
4135         controls, and that theme requires the ui ResourceBundle
4136         to be initialized. On every other platform, we build
4137         a DumpRenderTree.pak that works for this, but on Windows we
4138         still compile the resources directly into DRT. As a first step,
4139         let's build the pak file. I will then need to land a patch
4140         in Chromium to actually load it. Then I can go back and move
4141         the resources over to just use the .pak file and no longer need
4142         the .rc's.
4143
4144         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4145
4146 2013-03-05  Julie Parent  <jparent@chromium.org>
4147         Dashboard cleanup: move string utilities into their own namespace.
4148         
4149         https://bugs.webkit.org/show_bug.cgi?id=111485
4150
4151         Reviewed by Ojan Vafai.
4152         
4153         One of many pieces to clean up dashboard_base.
4154         
4155         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
4156
4157         * TestResultServer/static-dashboards/aggregate_results.html:
4158         * TestResultServer/static-dashboards/dashboard_base.js:
4159         (isTreeMap):
4160         (isFlakinessDashboard):
4161         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4162         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4163         (determineWKPlatform):
4164         (chromiumPlatform):
4165         (platformAndBuildType):
4166         (substringList):
4167         (individualTestsForSubstringList):
4168         (filterBugs):
4169         (populateExpectationsData):
4170         (processMissingTestsWithExpectations):
4171         (processMissingAndExtraExpectations):
4172         (htmlForSingleTestRow):
4173         (.dummyNode.onload):
4174         (expectationsTitle):
4175         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4176         * TestResultServer/static-dashboards/run-unittests.html:
4177         * TestResultServer/static-dashboards/string.js: Added.
4178         * TestResultServer/static-dashboards/timeline_explorer.html:
4179         * TestResultServer/static-dashboards/treemap.html:
4180
4181 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
4182
4183         [EFL] Build break with latest EFL libraries
4184         https://bugs.webkit.org/show_bug.cgi?id=111028
4185
4186         Reviewed by Dirk Pranke.
4187
4188         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
4189         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
4190         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
4191
4192 2013-03-05  Roger Fong  <roger_fong@apple.com>
4193
4194         Increase number of WinEWS iterations to 20.
4195         Don't reboot after each iteration set.
4196         Make EWS bots just build temporarily so that the queue catches up again.
4197
4198         * EWSTools/start-queue-win.sh:
4199         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4200         (WinEWS):
4201
4202 2013-03-04  James Robinson  <jamesr@chromium.org>
4203
4204         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
4205         https://bugs.webkit.org/show_bug.cgi?id=111386
4206
4207         Reviewed by Adrienne Walker.
4208
4209         * DumpRenderTree/chromium/TestShell.cpp:
4210         (TestShell::initialize):
4211
4212 2013-03-05  Min Qin  <qinmin@chromium.org>
4213
4214         Copy dictionary to the external storage before running layout test on android
4215         https://bugs.webkit.org/show_bug.cgi?id=111480
4216
4217         Reviewed by Adam Barth.
4218
4219         TestWebKitPlatformSupport now needs to read an external dictionary file.
4220         This file does not exist on the device. We need to copy it before running layout tests.
4221
4222         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4223         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
4224         (ChromiumAndroidDriver._push_platform_resources):
4225
4226 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4227
4228         [chromium] DRT crashes in an Aura/Win build
4229         https://bugs.webkit.org/show_bug.cgi?id=111394
4230
4231         Reviewed by Tony Chang.
4232
4233         When building (and running) with use_aura=1, we assume that
4234         we're using the default theme engine, but DRT creates the
4235         DRTWin theme engine and overwrites the default, leading to crashes
4236         in basically every test from the mismatch.
4237
4238         This fix gets us down to at least "lots of crashes" :).
4239
4240         * DumpRenderTree/chromium/TestShellWin.cpp:
4241         (platformInit):
4242
4243 2013-03-05  Eric Seidel  <eric@webkit.org>
4244
4245         Add html-parser-threaded perf test now that the threaded parser is enabled by default
4246         https://bugs.webkit.org/show_bug.cgi?id=111200
4247
4248         Reviewed by Ryosuke Niwa.
4249
4250         Had to teach run-perf-tests to ignore one more warning.
4251
4252         * Scripts/webkitpy/performance_tests/perftest.py:
4253         (PerfTest):
4254
4255 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
4256
4257         Update list of builders for test results server
4258         https://bugs.webkit.org/show_bug.cgi?id=111166
4259
4260         Reviewed by Ojan Vafai.
4261
4262         * TestResultServer/static-dashboards/builders.jsonp:
4263
4264 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
4265
4266         [GTK] Move basic dependency installation to a script
4267         https://bugs.webkit.org/show_bug.cgi?id=110692
4268
4269         Reviewed by Gustavo Noronha Silva.
4270
4271    &n