[LFC][BFC] Add support for block replaced intrinsic width.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][BFC] Add support for block replaced intrinsic width.
4         https://bugs.webkit.org/show_bug.cgi?id=194705
5
6         Reviewed by Simon Fraser.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-02-16  Zalan Bujtas  <zalan@apple.com>
11
12         [LFC] Apply min/max width constraints to preferred width computation
13         https://bugs.webkit.org/show_bug.cgi?id=194739
14
15         Reviewed by Simon Fraser.
16
17         * LayoutReloaded/misc/LFC-passing-tests.txt:
18
19 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
20
21         [WTF] Add environment variable helpers
22         https://bugs.webkit.org/show_bug.cgi?id=192405
23
24         Reviewed by Michael Catanzaro.
25
26         * DumpRenderTree/mac/DumpRenderTree.mm:
27         (libraryPathForDumpRenderTree):
28         * DumpRenderTree/win/DumpRenderTree.cpp:
29         (libraryPathForDumpRenderTree):
30         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
31         (setUpIOSLayoutTestCommunication):
32         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
33         (beforeAll):
34         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
35         (main):
36         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
37         (WebKitTestBus::run):
38         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
39         (WTR::getOutputDir):
40         (WTR::initializeFontConfigSetting):
41         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
42         (WTR::InjectedBundle::platformInitialize):
43         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
44         (WTR::topLevelPath):
45         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
46         (WTR::topLevelPath):
47         (WTR::getOutputDir):
48         (WTR::activateFonts):
49         * WebKitTestRunner/TestController.cpp:
50         (WTR::TestController::libraryPathForTesting):
51         (WTR::TestController::generateContextConfiguration const):
52         (WTR::TestController::generatePageConfiguration):
53         (WTR::TestController::decideDestinationWithSuggestedFilename):
54         (WTR::TestController::platformAdjustContext):
55         * WebKitTestRunner/TestController.h:
56         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
57         (WTR::TestController::cocoaPlatformInitialize):
58         (WTR::TestController::platformAdjustContext):
59         * WebKitTestRunner/gtk/main.cpp:
60         (main):
61         * WebKitTestRunner/mac/TestControllerMac.mm:
62         (WTR::TestController::configureContentExtensionForTest):
63         * WebKitTestRunner/wpe/main.cpp:
64         (main):
65         Utilize WTF::Environment where possible.
66
67 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
68
69         [iOS] WKWebView callout bar is missing Change Writing Direction item
70         https://bugs.webkit.org/show_bug.cgi?id=190015
71         <rdar://problem/44810366>
72
73         Reviewed by Tim Horton.
74
75         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
76         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
77
78         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
79         (TestWebKitAPI::TEST):
80
81 2019-02-15  Chris Dumez  <cdumez@apple.com>
82
83         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
84         https://bugs.webkit.org/show_bug.cgi?id=194717
85         <rdar://problem/47884404>
86
87         Reviewed by Brady Eidson.
88
89         Add API test coverage.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
92
93 2019-02-15  Youenn Fablet  <youenn@apple.com>
94
95         Make navigator.mediaDevices SecureContext
96         https://bugs.webkit.org/show_bug.cgi?id=194666
97
98         Reviewed by Eric Carlson.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
101         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
102         (TEST_F):
103
104 2019-02-15  Brian Burg  <bburg@apple.com>
105
106         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
107         https://bugs.webkit.org/show_bug.cgi?id=194411
108         <rdar://problem/47787614>
109
110         Reviewed by Joseph Pecoraro.
111
112         Remove unnecessary soft linking macro usage.
113
114         * DumpRenderTree/mac/TestRunnerMac.mm:
115         (TestRunner::inspectorTestStubURL):
116         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
117         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
118         (WTR::TestRunner::inspectorTestStubURL):
119
120 2019-02-15  Commit Queue  <commit-queue@webkit.org>
121
122         Unreviewed, rolling out r241559 and r241566.
123         https://bugs.webkit.org/show_bug.cgi?id=194710
124
125         Causes layout test crashes under GuardMalloc (Requested by
126         ryanhaddad on #webkit).
127
128         Reverted changesets:
129
130         "[WTF] Add environment variable helpers"
131         https://bugs.webkit.org/show_bug.cgi?id=192405
132         https://trac.webkit.org/changeset/241559
133
134         "Unreviewed build fix for WinCairo Debug after r241559."
135         https://trac.webkit.org/changeset/241566
136
137 2019-02-15  Zalan Bujtas  <zalan@apple.com>
138
139         [LFC] Out-of-flow box is never a float box
140         https://bugs.webkit.org/show_bug.cgi?id=194704
141
142         Reviewed by Antti Koivisto.
143
144         * LayoutReloaded/misc/LFC-passing-tests.txt:
145
146 2019-02-10  Darin Adler  <darin@apple.com>
147
148         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
149         https://bugs.webkit.org/show_bug.cgi?id=194487
150
151         Reviewed by Daniel Bates.
152
153         * DumpRenderTree/win/DumpRenderTree.cpp:
154         (applicationId): Use makeString instead of String::format.
155         (main): Ditto.
156         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
157         (TestWebKitAPI::Util::createURLForResource): Ditto.
158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
159         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
160
161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
162         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
163         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
164         (WTR::createStringWithAttributes): Use appendLiteral.
165         (WTR::AccessibilityUIElement::helpText const): Ditto.
166         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
167         directly instead of using String::format.
168         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
169         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
170
171 2019-02-15  Truitt Savell  <tsavell@apple.com>
172
173         Unreviewed, rolling out r241564.
174
175         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
176
177         Reverted changeset:
178
179         "[Mac] WebInspectorUI.framework does not need to be soft-
180         linked anymore"
181         https://bugs.webkit.org/show_bug.cgi?id=194411
182         https://trac.webkit.org/changeset/241564
183
184 2019-02-15  Saam barati  <sbarati@apple.com>
185
186         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
187         https://bugs.webkit.org/show_bug.cgi?id=194036
188
189         Reviewed by Yusuke Suzuki.
190
191         * Scripts/run-jsc-stress-tests:
192
193 2019-02-14  Tim Horton  <timothy_horton@apple.com>
194
195         Fix the build.
196
197         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
198         (WTR::UIScriptController::drawSquareInEditableImage):
199         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
200         (TestWebKitAPI::drawSquareInEditableImage):
201
202 2019-02-14  Tim Horton  <timothy_horton@apple.com>
203
204         Fix the build.
205
206         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
207         (WTR::UIScriptController::drawSquareInEditableImage):
208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
209         (TestWebKitAPI::drawSquareInEditableImage):
210
211 2019-02-14  Brian Burg  <bburg@apple.com>
212
213         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
214         https://bugs.webkit.org/show_bug.cgi?id=194411
215         <rdar://problem/47787614>
216
217         Reviewed by Joseph Pecoraro.
218
219         Remove unnecessary soft linking macro usage.
220
221         * DumpRenderTree/mac/TestRunnerMac.mm:
222         (TestRunner::inspectorTestStubURL):
223         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
224         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
225         (WTR::TestRunner::inspectorTestStubURL):
226
227 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
228
229         [ews-app] status bubble should fetch builder name info from BuilderMapping table
230         https://bugs.webkit.org/show_bug.cgi?id=194599
231
232         Reviewed by Lucas Forschler.
233
234         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
235         (StatusBubble._build_bubble):
236
237 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
238
239         [ews-app] Set Foreign Key in Django build model
240         https://bugs.webkit.org/show_bug.cgi?id=194667
241
242         Reviewed by Lucas Forschler.
243
244         * BuildSlaveSupport/ews-app/ews/models/build.py:
245         (Build):
246
247 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
248
249         [WTF] Add environment variable helpers
250         https://bugs.webkit.org/show_bug.cgi?id=192405
251
252         Reviewed by Michael Catanzaro.
253
254         * DumpRenderTree/mac/DumpRenderTree.mm:
255         (libraryPathForDumpRenderTree):
256         * DumpRenderTree/win/DumpRenderTree.cpp:
257         (libraryPathForDumpRenderTree):
258         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
259         (setUpIOSLayoutTestCommunication):
260         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
261         (TestWebKitAPI::strip):
262         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
263         (beforeAll):
264         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
265         (main):
266         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
267         (WebKitTestBus::run):
268         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
269         (WTR::getOutputDir):
270         (WTR::initializeFontConfigSetting):
271         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
272         (WTR::InjectedBundle::platformInitialize):
273         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
274         (WTR::topLevelPath):
275         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
276         (WTR::topLevelPath):
277         (WTR::getOutputDir):
278         (WTR::activateFonts):
279         * WebKitTestRunner/TestController.cpp:
280         (WTR::TestController::libraryPathForTesting):
281         (WTR::TestController::generateContextConfiguration const):
282         (WTR::TestController::generatePageConfiguration):
283         (WTR::TestController::decideDestinationWithSuggestedFilename):
284         (WTR::TestController::platformAdjustContext):
285         * WebKitTestRunner/TestController.h:
286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
287         (WTR::TestController::cocoaPlatformInitialize):
288         (WTR::TestController::platformAdjustContext):
289         * WebKitTestRunner/gtk/main.cpp:
290         (main):
291         * WebKitTestRunner/mac/TestControllerMac.mm:
292         (WTR::TestController::configureContentExtensionForTest):
293         * WebKitTestRunner/wpe/main.cpp:
294         (main):
295         Utilize WTF::Environment where possible.
296
297 2019-02-14  Chris Dumez  <cdumez@apple.com>
298
299         [PSON] Introduce a WebContent Process cache
300         https://bugs.webkit.org/show_bug.cgi?id=194594
301         <rdar://problem/46793397>
302
303         Reviewed by Geoff Garen.
304
305         Update API tests to turn on the WebContent Process cache.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
308
309 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
310
311         Unreviewed, build fix after r241480
312
313         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
314         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
315         (-[DragAndDropSimulator initWithWebView:]):
316
317 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
318
319         AX: ARIA Reflection was disabled in error
320         https://bugs.webkit.org/show_bug.cgi?id=194647
321         <rdar://problem/48068336>
322
323         Reviewed by Ryosuke Niwa.
324
325         Remove test override now that this feature should be enabled by default.
326
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::resetPreferencesToConsistentValues):
329
330 2019-02-14  Commit Queue  <commit-queue@webkit.org>
331
332         Unreviewed, rolling out r241486.
333         https://bugs.webkit.org/show_bug.cgi?id=194655
334
335         causing API failures in builds (Requested by ShawnRoberts on
336         #webkit).
337
338         Reverted changeset:
339
340         "[Cocoa] Media elements will restart network buffering just
341         before suspending"
342         https://bugs.webkit.org/show_bug.cgi?id=193691
343         https://trac.webkit.org/changeset/241486
344
345 2019-02-14  Zalan Bujtas  <zalan@apple.com>
346
347         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
348         https://bugs.webkit.org/show_bug.cgi?id=194622
349
350         Reviewed by Antti Koivisto.
351
352         * LayoutReloaded/misc/LFC-passing-tests.txt:
353
354 2019-02-14  Zalan Bujtas  <zalan@apple.com>
355
356         [LFC] Shrink-to-fit-width should be constrained by min/max width
357         https://bugs.webkit.org/show_bug.cgi?id=194653
358
359         Reviewed by Antti Koivisto.
360
361         * LayoutReloaded/misc/LFC-passing-tests.txt:
362
363 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
364
365         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
366         https://bugs.webkit.org/show_bug.cgi?id=194641
367
368         Reviewed by Geoffrey Garen.
369
370         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
371         so that the test would fail without this fix.
372
373         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
374         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
375
376 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews-app] Change log level for a log statement
379
380         Unreviewed minor fix.
381
382         * BuildSlaveSupport/ews-app/ews/models/patch.py:
383         (Patch.save_patch):
384
385 2019-02-13  Jer Noble  <jer.noble@apple.com>
386
387         [Cocoa] Media elements will restart network buffering just before suspending
388         https://bugs.webkit.org/show_bug.cgi?id=193691
389
390         Reviewed by Eric Carlson.
391
392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
394         (TEST):
395
396 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
397
398         [ews-app] Fetch builder id to name mapping
399         https://bugs.webkit.org/show_bug.cgi?id=194355
400
401         Reviewed by Lucas Forschler.
402
403         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
404         (Buildbot.get_builder_id_to_name_mapping):
405         (Buildbot._get_display_name_from_builder_name):
406
407 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
408
409         Further restricting webarchive loads
410         https://bugs.webkit.org/show_bug.cgi?id=194567
411         <rdar://problem/47610130>
412
413         Reviewed by Youenn Fablet.
414
415         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
416         navigations on drop.
417
418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
419         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
420         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
421         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
422         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
423         (TestWebKitAPI::TEST):
424         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
425         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
426         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
427         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
428         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
429         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
430         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
431
432 2019-02-13  John Wilander  <wilander@apple.com>
433
434         Store Ad Click Attribution requests in the network process
435         https://bugs.webkit.org/show_bug.cgi?id=194510
436         <rdar://problem/47650118>
437
438         Reviewed by Alex Christensen and Daniel Bates.
439
440         This patch adds two TestRunner functions:
441         - dumpAdClickAttribution()
442         - clearAdClickAttribution()
443
444         They call into the network process to dump and clear Ad Click
445         Attribution state, respectively.
446
447         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
448         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
449         (WTR::TestRunner::dumpAdClickAttribution):
450         (WTR::TestRunner::clearAdClickAttribution):
451         * WebKitTestRunner/InjectedBundle/TestRunner.h:
452         * WebKitTestRunner/TestController.cpp:
453         (WTR::TestController::resetStateToConsistentValues):
454         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
455         (WTR::adClickAttributionStringResultCallback):
456         (WTR::TestController::dumpAdClickAttribution):
457         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
458         (WTR::adClickAttributionVoidCallback):
459         (WTR::TestController::clearAdClickAttribution):
460         * WebKitTestRunner/TestController.h:
461         * WebKitTestRunner/TestInvocation.cpp:
462         (WTR::TestInvocation::dumpResults):
463         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
464         (WTR::TestInvocation::dumpAdClickAttribution):
465         * WebKitTestRunner/TestInvocation.h:
466
467 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
468
469         [ews-app] Generate status-bubble
470         https://bugs.webkit.org/show_bug.cgi?id=194572
471
472         Reviewed by Lucas Forschler.
473
474         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
475         (StatusBubble._build_bubble):
476         (StatusBubble._should_show_bubble_for):
477         (StatusBubble._build_bubbles_for_patch):
478
479 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
480
481         [ews-app] Add status bubble html template
482         https://bugs.webkit.org/show_bug.cgi?id=194571
483
484         Reviewed by Lucas Forschler.
485
486         * BuildSlaveSupport/ews-app/ews/templates: Added.
487         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
488
489 2019-02-12  Chris Dumez  <cdumez@apple.com>
490
491         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
492         https://bugs.webkit.org/show_bug.cgi?id=194568
493         <rdar://problem/47944490>
494
495         Reviewed by Ryosuke Niwa.
496
497         Add API test coverage.
498
499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
500         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
501
502 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
503
504         webkitpy: Remove bug_dummy from parsed test expectations
505         https://bugs.webkit.org/show_bug.cgi?id=194562
506         <rdar://problem/47853999>
507
508         Reviewed by Lucas Forschler.
509
510         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
511         (TestExpectationParser):
512         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
513         skipped tests.
514         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
515
516 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-app] Add method to fetch patch
519         https://bugs.webkit.org/show_bug.cgi?id=194518
520
521         Reviewed by Lucas Forschler.
522
523         * BuildSlaveSupport/ews-app/ews/models/patch.py:
524         (Patch.get_patch):
525
526 2019-02-12  Zalan Bujtas  <zalan@apple.com>
527
528         [LFC] Expand tests coverage (60 new tests -> 860)
529
530         Unreviewed test gardening (run-singly, --child-processes=1).
531
532         * LayoutReloaded/misc/LFC-passing-tests.txt:
533
534 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
535
536         Allow pages to trigger programmatic paste from script on iOS
537         https://bugs.webkit.org/show_bug.cgi?id=194271
538         <rdar://problem/47808810>
539
540         Reviewed by Tim Horton.
541
542         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
543
544         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
545         (WTR::UIScriptController::platformSetDidShowMenuCallback):
546         (WTR::UIScriptController::platformSetDidHideMenuCallback):
547         (WTR::UIScriptController::rectForMenuAction const):
548
549         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
550         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
551         for when the menu is shown or hidden.
552
553         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
554         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
555         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
556         (WTR::UIScriptController::setDidShowMenuCallback):
557         (WTR::UIScriptController::didShowMenuCallback const):
558         (WTR::UIScriptController::setDidHideMenuCallback):
559         (WTR::UIScriptController::didHideMenuCallback const):
560         (WTR::UIScriptController::platformSetDidShowMenuCallback):
561         (WTR::UIScriptController::platformSetDidHideMenuCallback):
562         (WTR::UIScriptController::rectForMenuAction const):
563         * TestRunnerShared/UIScriptContext/UIScriptController.h:
564         * WebKitTestRunner/TestController.cpp:
565         (WTR::TestController::resetPreferencesToConsistentValues):
566         (WTR::updateTestOptionsFromTestHeader):
567         * WebKitTestRunner/TestOptions.h:
568
569         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
570         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
571
572         (WTR::TestOptions::hasSameInitializationOptions const):
573         * WebKitTestRunner/UIScriptControllerCocoa.mm:
574         (WTR::UIScriptController::calendarType const):
575         (WTR::UIScriptController::platformUndoManager const):
576         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
577         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
578         (-[TestRunnerWKWebView initWithFrame:configuration:]):
579         (-[TestRunnerWKWebView dealloc]):
580         (-[TestRunnerWKWebView _didShowMenu]):
581         (-[TestRunnerWKWebView _didHideMenu]):
582
583         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
584
585         * WebKitTestRunner/ios/TestControllerIOS.mm:
586         (WTR::handleMenuWillHideNotification):
587         (WTR::handleMenuDidHideNotification):
588         (WTR::TestController::platformInitialize):
589         (WTR::TestController::platformDestroy):
590         (WTR::TestController::platformResetStateToConsistentValues):
591
592         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
593         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
594
595         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
596         (WTR::forEachViewInHierarchy):
597         (WTR::findViewInHierarchyOfType):
598
599         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
600         functions that dig through a given view's hierarchy in search of a view of a given class.
601
602         (WTR::UIScriptController::selectionStartGrabberViewRect const):
603         (WTR::UIScriptController::selectionEndGrabberViewRect const):
604         (WTR::UIScriptController::selectionCaretViewRect const):
605         (WTR::UIScriptController::selectionRangeViewRects const):
606         (WTR::UIScriptController::platformSetDidShowMenuCallback):
607         (WTR::UIScriptController::platformSetDidHideMenuCallback):
608
609         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
610
611         (WTR::UIScriptController::rectForMenuAction const):
612
613         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
614         callout bar) whose label matches the given string.
615
616         (WTR::UIScriptController::platformContentView const):
617
618         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
619         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
620         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
621
622         (WTR::UIScriptController::platformUndoManager const): Deleted.
623         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
624         (WTR::UIScriptController::platformContentView const):
625         (WTR::UIScriptController::platformUndoManager const): Deleted.
626
627 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
628
629         webkitpy: No option to only show unexpected failures in results.html for iPad
630         https://bugs.webkit.org/show_bug.cgi?id=194554
631         <rdar://problem/47922442>
632
633         Rubber-stamped by Aakash Jain.
634
635         Just because a TestExpecations file does not exist for a specific platform does not mean that
636         TestExpecations are not being used, given that platforms inherit test expectations.
637
638         * Scripts/webkitpy/port/base.py:
639         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
640         * Scripts/webkitpy/port/base_unittest.py:
641         (PortTest.test_uses_test_expectations_file):
642
643 2019-02-12  Alex Christensen  <achristensen@webkit.org>
644
645         Remove setDefersLoading infrastructure from WebKit2
646         https://bugs.webkit.org/show_bug.cgi?id=194506
647
648         Reviewed by Brady Eidson.
649
650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
652         (WTR::TestRunner::setDefersLoading): Deleted.
653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
654
655 2019-02-12  Alex Christensen  <achristensen@webkit.org>
656
657         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
658         https://bugs.webkit.org/show_bug.cgi?id=194522
659         <rdar://problem/47789393>
660
661         Reviewed by Chris Dumez.
662
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
665         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
666         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
667
668 2019-02-12  Andy Estes  <aestes@apple.com>
669
670         [iOSMac] Enable Parental Controls Content Filtering
671         https://bugs.webkit.org/show_bug.cgi?id=194521
672         <rdar://39732376>
673
674         Reviewed by Tim Horton.
675
676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
677
678 2019-02-12  Zalan Bujtas  <zalan@apple.com>
679
680         [LFC][IFC] Add intrinsic width support for float boxes.
681         https://bugs.webkit.org/show_bug.cgi?id=194528
682
683         Reviewed by Antti Koivisto.
684
685         Expand tests coverage (2 new tests -> 800).
686         (This is the correct test ordering --runs-singly --child-processes=1)
687
688         * LayoutReloaded/misc/LFC-passing-tests.txt:
689
690 2019-02-12  Rob Buis  <rbuis@igalia.com>
691
692         Implement serializing in MIME type parser
693         https://bugs.webkit.org/show_bug.cgi?id=193909
694
695         Reviewed by Darin Adler.
696
697         Add various tests involving upper case, non-ASCII, control/null characters,
698         various HTTP whitespace, single quotes and an unpaired surrogate.
699
700         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
701         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
702         (TestWebKitAPI::serializeIfValid):
703         (TestWebKitAPI::TEST):
704
705 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
706
707         [Cocoa] Ask platform for generic font family mappings
708         https://bugs.webkit.org/show_bug.cgi?id=187723
709         <rdar://problem/41892438>
710
711         Reviewed by Brent Fulgham.
712
713         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
714
715         * DumpRenderTree/mac/DumpRenderTree.mm:
716         (allowedFontFamilySet):
717         * WebKitTestRunner/mac/TestControllerMac.mm:
718         (WTR::allowedFontFamilySet):
719
720 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
721
722         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
723         https://bugs.webkit.org/show_bug.cgi?id=193622
724
725         Reviewed by Michael Catanzaro.
726
727         This adds support for loading content extension rule sets from the JSON files which
728         accompany the corresponding layout test, using the C API. The Cocoa specific parts
729         of WKTR for this could be removed, but that is left for a follow-up patch with
730         cleanups.
731
732         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
733         * WebKitTestRunner/TestController.cpp:
734         (WTR::testPath): Subtract one from the length when constructing the result std::string to
735         avoid having the null-terminator copied into the result.
736         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
737         part of the preparations to run a test.
738         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
739         (WTR::contentExtensionStoreCallback): Added.
740         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
741         used for content extensions test.
742         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
743         extensions and compiling the JSON rule set for tests involving content extensions.
744         (WTR::TestController::resetContentExtensions): Removes the content extension built for
745         testing and disables content extensions.
746         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
747         resetContentExtensions().
748         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
749         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
750         configureContentExtensionForTest(), and userContentController().
751
752 2019-02-11  Daniel Bates  <dabates@apple.com>
753
754         [iOS] Mouse/Touch/Pointer events are missing modifier keys
755         https://bugs.webkit.org/show_bug.cgi?id=191446
756         <rdar://problem/45929460>
757
758         Reviewed by Tim Horton.
759
760         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
761
762         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
763         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
764         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
765         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
766         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
767         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
768         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
769         * TestRunnerShared/UIScriptContext/UIScriptController.h:
770         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
771         (WTR::arrayLength):
772         (WTR::parseModifierArray):
773         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
774         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
775         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
776         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
777
778 2019-02-11  Commit Queue  <commit-queue@webkit.org>
779
780         Unreviewed, rolling out r241272 and r241276.
781         https://bugs.webkit.org/show_bug.cgi?id=194514
782
783         Broke the Apple Internal build and the fix requires human
784         intervention :( (Requested by dydz on #webkit).
785
786         Reverted changesets:
787
788         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
789         https://bugs.webkit.org/show_bug.cgi?id=191446
790         https://trac.webkit.org/changeset/241272
791
792         "Fix internal iOS build after r241272"
793         https://bugs.webkit.org/show_bug.cgi?id=191446
794         https://trac.webkit.org/changeset/241276
795
796 2019-02-11  Truitt Savell  <tsavell@apple.com>
797
798         Unreviewed, rolling out r241269.
799
800         Caused 5 layout tests crashes on Mac WK1
801
802         Reverted changeset:
803
804         "DumpRenderTree should report unknown options"
805         https://bugs.webkit.org/show_bug.cgi?id=191303
806         https://trac.webkit.org/changeset/241269
807
808 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
809
810         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
811         https://bugs.webkit.org/show_bug.cgi?id=194313
812
813         Reviewed by Tim Horton.
814
815         Add a helper to determine whether the web view is presenting modal UI.
816
817         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
818         (WTR::UIScriptController::isPresentingModally const):
819         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
820         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
821         (WTR::UIScriptController::isPresentingModally const):
822         * TestRunnerShared/UIScriptContext/UIScriptController.h:
823         * WebKitTestRunner/UIScriptControllerCocoa.mm:
824         (WTR::UIScriptController::calendarType const): Deleted.
825         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
826         (WTR::UIScriptController::isPresentingModally const):
827         (WTR::UIScriptController::calendarType const):
828         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
829         (WTR::UIScriptController::calendarType const):
830
831 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
832
833         GCHeapInspector: Show the retained sizes in more places
834         https://bugs.webkit.org/show_bug.cgi?id=194464
835
836         Reviewed by Simon Fraser.
837
838         * GCHeapInspector/gc-heap-inspector.html:
839         * GCHeapInspector/script/interface.js:
840         (HeapInspectorUtils.humanReadableSize):
841         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
842         (HeapInspectorUtils.spanForNode.span.span):
843         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
844         (HeapSnapshotInspector.prototype.buildRoots):
845
846 2019-02-11  Daniel Bates  <dabates@apple.com>
847
848         [iOS] Mouse/Touch/Pointer events are missing modifier keys
849         https://bugs.webkit.org/show_bug.cgi?id=191446
850         <rdar://problem/45929460>
851
852         Reviewed by Tim Horton.
853
854         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
855
856         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
857         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
858         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
859         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
860         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
861         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
862         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
863         * TestRunnerShared/UIScriptContext/UIScriptController.h:
864         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
865         (WTR::arrayLength):
866         (WTR::parseModifierArray):
867         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
868         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
869         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
870         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
871
872 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
873
874         DumpRenderTree should report unknown options
875         https://bugs.webkit.org/show_bug.cgi?id=191303
876
877         Reviewed by Frédéric Wang.
878
879         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
880         to report unknown options.
881         Added and assigned test options which are currently used in tests.
882
883         * DumpRenderTree/TestOptions.cpp:
884         (TestOptions::TestOptions):
885
886 2019-02-11  Truitt Savell  <tsavell@apple.com>
887
888         Unreviewed, rolling out r241229.
889
890         Revision broke internal builds for watchOS.
891
892         Reverted changeset:
893
894         "[Cocoa] Ask platform for generic font family mappings"
895         https://bugs.webkit.org/show_bug.cgi?id=187723
896         https://trac.webkit.org/changeset/241229
897
898 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
899
900         [WinCairo][MiniBrowser] Basic authentication always fails.
901         https://bugs.webkit.org/show_bug.cgi?id=194496
902
903         Reviewed by Don Olmstead.
904
905         * MiniBrowser/win/DialogHelper.h:
906         (Dialog::getText):
907
908 2019-02-11  Philippe Normand  <pnormand@igalia.com>
909
910         [GStreamer] GstMappedBuffer testsuite build fails
911         https://bugs.webkit.org/show_bug.cgi?id=194495
912
913         Reviewed by Carlos Garcia Campos.
914
915         Fix the build by explicitely adding the gstreamer1.0-audio include
916         directories to the include path.
917
918         * TestWebKitAPI/PlatformGTK.cmake:
919         * TestWebKitAPI/PlatformWPE.cmake:
920
921 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         [GTK][WPE] Add enable-javascript-markup setting
924         https://bugs.webkit.org/show_bug.cgi?id=193439
925
926         Reviewed by Michael Catanzaro.
927
928         Add test cases to check the new setting.
929
930         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
931         (testWebKitSettings):
932         (testWebKitSettingsJavaScriptMarkup):
933         (beforeAll):
934
935 2019-02-10  Darin Adler  <darin@apple.com>
936
937         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
938         https://bugs.webkit.org/show_bug.cgi?id=194485
939
940         Reviewed by Daniel Bates.
941
942         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
943
944 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
945
946         Add more tests for clampTo<>()
947         https://bugs.webkit.org/show_bug.cgi?id=194462
948
949         Reviewed by Geoffrey Garen.
950
951         Darin suggested to test the very last floating point number
952         at the boundaries when truncating to integer.
953         I added test for max/min and max-1/min-1.
954
955         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
956         (TestWebKitAPI::TEST):
957
958 2019-02-09  Darin Adler  <darin@apple.com>
959
960         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
961         https://bugs.webkit.org/show_bug.cgi?id=194021
962
963         Reviewed by Geoffrey Garen.
964
965         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
966         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
967         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
968
969 2019-02-09  Zalan Bujtas  <zalan@apple.com>
970
971         [LFC][IFC] Add intrinsic width support for basic inline containers
972         https://bugs.webkit.org/show_bug.cgi?id=194473
973
974         Reviewed by Antti Koivisto.
975
976         Expand tests coverage (11 new tests -> 798)
977
978         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
979
980 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
981
982         Fix MiniBrowser's entitlements
983         https://bugs.webkit.org/show_bug.cgi?id=192431
984
985         Reviewed by Joseph Pecoraro.
986
987         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
988         files, making it impossible to load any extension.
989
990         * MiniBrowser/MiniBrowser.entitlements:
991
992 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
993
994         [Cocoa] Ask platform for generic font family mappings
995         https://bugs.webkit.org/show_bug.cgi?id=187723
996         <rdar://problem/41892438>
997
998         Reviewed by Brent Fulgham.
999
1000         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1001
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (allowedFontFamilySet):
1004         * WebKitTestRunner/mac/TestControllerMac.mm:
1005         (WTR::allowedFontFamilySet):
1006
1007 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1008
1009         [GTK] Implement back/forward touchpad gesture
1010         https://bugs.webkit.org/show_bug.cgi?id=193919
1011
1012         Reviewed by Michael Catanzaro.
1013
1014         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1015         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1016
1017 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1018
1019         Add SPI to use networking daemon instead of XPC service
1020         https://bugs.webkit.org/show_bug.cgi?id=194427
1021
1022         Reviewed by Geoffrey Garen
1023
1024         * MiniBrowser/MiniBrowser.entitlements:
1025
1026 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1027
1028         [ews-build] Ensure that every builder in config.json has short name
1029         https://bugs.webkit.org/show_bug.cgi?id=194461
1030
1031         Reviewed by Lucas Forschler.
1032
1033         * BuildSlaveSupport/ews-build/loadConfig.py:
1034         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1035
1036 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1037
1038         [ews-build] Add short name to config.json
1039         https://bugs.webkit.org/show_bug.cgi?id=194456
1040
1041         Reviewed by Lucas Forschler.
1042
1043         * BuildSlaveSupport/ews-build/config.json: Added short name.
1044         * BuildSlaveSupport/ews-build/loadConfig.py:
1045         (loadBuilderConfig): Set the short name as the builder description.
1046
1047 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1048
1049         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1050         https://bugs.webkit.org/show_bug.cgi?id=194418
1051
1052         Reviewed by Lucas Forschler.
1053
1054         Do not include errors trying when finding crashlogs at the end of
1055         a run-webkit-tests run since we don't process those errors.
1056
1057         * Scripts/webkitpy/port/darwin.py:
1058         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1059         * Scripts/webkitpy/port/ios_device.py:
1060         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1061         * Scripts/webkitpy/port/watch_device.py:
1062         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1063
1064 2019-02-08  Beth Dakin  <bdakin@apple.com>
1065
1066         Add afterScreenUpdates to WKSnapshotConfiguration
1067         https://bugs.webkit.org/show_bug.cgi?id=194362
1068         -and corresponding-
1069         <rdar://problem/40655528> Please add an "after screen updates" property to 
1070         WKSnapshotConfiguration (to solve blank snapshots)
1071
1072         Reviewed by Tim Horton.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1075         (TEST):
1076
1077 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1078
1079         clampTo(): do not convert the input to double when dealing with integers
1080         https://bugs.webkit.org/show_bug.cgi?id=194263
1081         <rdar://problem/47692312>
1082
1083         Reviewed by Darin Adler.
1084
1085         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1086         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1087         (TestWebKitAPI::testClampFloatingPointToInteger):
1088         (TestWebKitAPI::testClampSameSignIntegers):
1089         (TestWebKitAPI::testClampUnsignedToSigned):
1090         (TestWebKitAPI::testClampSignedToUnsigned):
1091
1092 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1093
1094         webkitpy: Respect --dedicated-simulators flag
1095         https://bugs.webkit.org/show_bug.cgi?id=194416
1096         <rdar://problem/47894722>
1097
1098         Reviewed by Lucas Forschler.
1099
1100         * Scripts/webkitpy/port/device_port.py:
1101         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1102         available devices can be safely ignored.
1103
1104 2019-02-07  Keith Rollin  <krollin@apple.com>
1105
1106         Remove extra copy of 100x100-red.tga
1107         https://bugs.webkit.org/show_bug.cgi?id=194371
1108         <rdar://problem/47873465>
1109
1110         Reviewed by Said Abou-Hallawa.
1111
1112         In order to help it pass its tests, Bug 194190 added a second copy of
1113         the file 100x100-red.tga. However, it turns out that this additional
1114         file wasn't actually needed, and that that sole previous copy was
1115         sufficient. At the same time, this second copy -- which was copied to
1116         the same location in the build output as the first copy -- now caused
1117         XCBuild to complain because there were two production rules for the
1118         same output file. Address this by removing the newly-added extra copy.
1119
1120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1121         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1122
1123 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1124
1125         Deprecate WKBundlePageSetDefersLoading
1126         https://bugs.webkit.org/show_bug.cgi?id=191394
1127
1128         Reviewed by Dean Jackson.
1129
1130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1131         (WTR::TestRunner::setDefersLoading):
1132
1133 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1134
1135         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1136         https://bugs.webkit.org/show_bug.cgi?id=194391
1137
1138         Reviewed by Antti Koivisto.
1139
1140         * LayoutReloaded/misc/LFC-passing-tests.txt:
1141
1142 2019-02-06  Keith Rollin  <krollin@apple.com>
1143
1144         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1145         https://bugs.webkit.org/show_bug.cgi?id=193975
1146         <rdar://problem/47643306>
1147
1148         Reviewed by Tim Horton.
1149
1150         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1151         the Info.plist file into the bundle. This step is not necessary as the
1152         implicit "bundle up all the build products into a framework" build
1153         phase does this already. Having the Copy Bundle Resources phase do
1154         this causes a conflict under XCBuild, which objects to two build
1155         phases producing the same file (Info.plist). Address this by removing
1156         Info.plist from the Copy Bundle Resources phase.
1157
1158         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1159
1160 2019-02-06  Keith Rollin  <krollin@apple.com>
1161
1162         Really enable the automatic checking and regenerations of .xcfilelists during builds
1163         https://bugs.webkit.org/show_bug.cgi?id=194357
1164         <rdar://problem/47861231>
1165
1166         Reviewed by Chris Dumez.
1167
1168         Bug 194124 was supposed to enable the automatic checking and
1169         regenerating of .xcfilelist files during the build. While related
1170         changes were included in that patch, the change to actually enable the
1171         operation somehow was omitted. This patch actually enables the
1172         operation. The check-xcfilelist.sh scripts now check
1173         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1174         from the checking.
1175
1176         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1177         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1178
1179 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1180
1181         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1182         <https://webkit.org/b/194286>
1183         <rdar://problem/47815558>
1184
1185         Reviewed by Alexey Proskuryakov.
1186
1187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1188         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1189         WKRetainPtr<> to avoid leaking the WKDataRef.
1190
1191 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1192
1193         Unreviewed, fix a typo
1194
1195         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1196
1197 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1198
1199         [GTK][WPE] force libpsl build to use ICU in jhbuild
1200         https://bugs.webkit.org/show_bug.cgi?id=194288
1201
1202         Reviewed by Carlos Garcia Campos.
1203
1204         * gtk/jhbuild.modules:
1205         Require ICU for libpsl build in jhbuild, like done in WPE.
1206
1207 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1208
1209         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1210         https://bugs.webkit.org/show_bug.cgi?id=194209
1211
1212         Reviewed by Carlos Garcia Campos.
1213
1214         Enhance TestCookieManager to ensure this doesn't happen again.
1215
1216         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1217         (testCookieManagerPersistentStorage):
1218         (beforeAll):
1219
1220 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1221
1222         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1223         https://bugs.webkit.org/show_bug.cgi?id=194324
1224
1225         Reviewed by Andy Estes.
1226
1227         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1228         part of the name is already implicit, since this is in testing code in TestOptions.
1229
1230         * WebKitTestRunner/TestController.cpp:
1231         (WTR::TestController::generateContextConfiguration const):
1232         (WTR::updateTestOptionsFromTestHeader):
1233         * WebKitTestRunner/TestOptions.h:
1234         (WTR::TestOptions::hasSameInitializationOptions const):
1235
1236 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-build] Allow * as platform for builders and workers
1239         https://bugs.webkit.org/show_bug.cgi?id=188533
1240
1241         Reviewed by Lucas Forschler.
1242
1243         * BuildSlaveSupport/ews-build/loadConfig.py:
1244         (checkWorkersAndBuildersForConsistency):
1245
1246 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1247
1248         [ews-build] Add few bots to config.json
1249         https://bugs.webkit.org/show_bug.cgi?id=194304
1250
1251         Reviewed by Lucas Forschler.
1252
1253         * BuildSlaveSupport/ews-build/config.json:
1254
1255 2019-02-05  Keith Rollin  <krollin@apple.com>
1256
1257         Enable the automatic checking and regenerations of .xcfilelists during builds
1258         https://bugs.webkit.org/show_bug.cgi?id=194124
1259         <rdar://problem/47721277>
1260
1261         Reviewed by Tim Horton.
1262
1263         Bug 193790 add a facility for checking -- during build time -- that
1264         any needed .xcfilelist files are up-to-date and for updating them if
1265         they are not. This facility was initially opt-in by setting
1266         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1267         the process seemed robust. Its now time to enable this facility and
1268         make it opt-out. If there is a need to disable this facility, set and
1269         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1270         running `make` or `build-webkit`, or before running Xcode from the
1271         command line.
1272
1273         Additionally, remove the step that generates a list of source files
1274         going into the UnifiedSources build step. It's only necessarily to
1275         specify Sources.txt and SourcesCocoa.txt as inputs.
1276
1277         * Scripts/generate-xcfilelists:
1278
1279 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1280
1281         [GTK][WPE] force libpsl build to use ICU in jhbuild
1282         https://bugs.webkit.org/show_bug.cgi?id=194288
1283
1284         Reviewed by Philippe Normand.
1285
1286         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1287         This can cause build failures if libidn is detected but libunistring is not available.
1288
1289         Make sure that ICU is used for runtime and builtin PSL data.
1290
1291         * gtk/jhbuild.modules:
1292         * wpe/jhbuild.modules:
1293
1294 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1295
1296         [ews-app] Modified timestamp should be updated on updating data
1297         https://bugs.webkit.org/show_bug.cgi?id=194295
1298
1299         Reviewed by Lucas Forschler.
1300
1301         * BuildSlaveSupport/ews-app/ews/models/build.py:
1302         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1303         * BuildSlaveSupport/ews-app/ews/models/step.py:
1304
1305 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1306
1307         Unreviewed, rolling out r240742.
1308
1309         Causes crashes on iOS simulator.
1310
1311         Reverted changeset:
1312
1313         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1314         not focused in a content-editable element"
1315         https://bugs.webkit.org/show_bug.cgi?id=192824
1316         https://trac.webkit.org/changeset/240742
1317
1318 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1319
1320         run-webkit-tests emits message "...running None" when running tests
1321         https://bugs.webkit.org/show_bug.cgi?id=194133
1322         <rdar://problem/47724738>
1323
1324         Reviewed by Lucas Forschler.
1325
1326         * Scripts/webkitpy/xcode/device_type.py:
1327         (DeviceType.__str__): Use both version mapping tables and use just the variant
1328         name if no version name is available.
1329         * Scripts/webkitpy/xcode/device_type_unittest.py:
1330         (DeviceTypeTest):
1331         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1332         an associated named.
1333
1334 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1335
1336         [WPE] require python3-setuptools for meson build in jhbuild
1337         https://bugs.webkit.org/show_bug.cgi?id=194287
1338
1339         Reviewed by Philippe Normand.
1340
1341         python3-setuptools is needed to build meson in jhbuild.
1342         It is already required by the GTK port.
1343
1344         * wpe/install-dependencies:
1345
1346 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1347
1348         [ews-app] Add method to save BuilderMapping to database
1349         https://bugs.webkit.org/show_bug.cgi?id=194264
1350
1351         Reviewed by Lucas Forschler.
1352
1353         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1354         (BuilderMapping.__str__):
1355         (BuilderMapping):
1356         (BuilderMapping.save_mapping):
1357         (BuilderMapping.update_mapping):
1358         (BuilderMapping.get_existing_mapping):
1359         (BuilderMapping.is_valid_mapping):
1360
1361 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1362
1363         [ews-app] Add timestamp fields for BuilderMappings
1364         https://bugs.webkit.org/show_bug.cgi?id=194266
1365
1366         Reviewed by Lucas Forschler.
1367
1368         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1369         (BuilderMapping):
1370
1371 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1372
1373         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1374         https://bugs.webkit.org/show_bug.cgi?id=174816
1375
1376         Reviewed by Michael Catanzaro.
1377
1378         Add tests for webkit_uri_for_display().
1379
1380         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1381         (testURIForDisplayUnaffected):
1382         (testURIForDisplayAffected):
1383         (beforeAll):
1384         (afterAll):
1385         * TestWebKitAPI/glib/CMakeLists.txt:
1386
1387 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1388
1389         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1390         https://bugs.webkit.org/show_bug.cgi?id=194158
1391         <rdar://problem/47737268>
1392
1393         Rubber-stamped by Aakash Jain.
1394
1395         * Scripts/webkitpy/port/device_port.py:
1396         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1397
1398 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1399
1400         [CG] Enable setAdditionalSupportedImageTypes for WK1
1401         https://bugs.webkit.org/show_bug.cgi?id=194190
1402
1403         Reviewed by Tim Horton.
1404
1405         Add a test similar to the one under WebKit Cocoa but make it create a
1406         WebView instead of a WKWebView.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1410         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1411         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1412         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1413         (TestWebKitAPI::runTest):
1414         (TestWebKitAPI::TEST):
1415
1416 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1417
1418         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1419         https://bugs.webkit.org/show_bug.cgi?id=194168
1420
1421         Reviewed by Simon Fraser.
1422
1423         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1424
1425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1426         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1427         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1428         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1429         (TEST):
1430         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1431         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1432
1433 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1434
1435         REGRESSION (r237269): webkit-patch what-broke is broken 
1436         https://bugs.webkit.org/show_bug.cgi?id=193025
1437
1438         Reviewed by Aakash Jain.
1439
1440         * Scripts/webkitpy/common/host.py:
1441         (Host.buildbot):
1442         (Host.bugzilla): Renamed to 'buildbot'.
1443
1444 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1445
1446         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1447         https://bugs.webkit.org/show_bug.cgi?id=194207
1448
1449         Reviewed by Tim Horton.
1450
1451         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1452         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1453         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1454         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1455         start and delete forwards to remove the original attachment.
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1458         (TestWebKitAPI::TEST):
1459
1460 2019-02-04  Youenn Fablet  <youenn@apple.com>
1461
1462         Capture state should be managed consistently when doing process swapping
1463         https://bugs.webkit.org/show_bug.cgi?id=194122
1464         <rdar://problem/47609293>
1465
1466         Reviewed by Eric Carlson.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1469         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1470         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1471         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1472         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1473         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1474         (WTR::TestRunner::isDoingMediaCapture const):
1475         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::isDoingMediaCapture const):
1478         * WebKitTestRunner/TestController.h:
1479         * WebKitTestRunner/TestInvocation.cpp:
1480         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1482         (WTR::TestController::isDoingMediaCapture const):
1483
1484 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1485
1486         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1487         https://bugs.webkit.org/show_bug.cgi?id=194142
1488
1489         Reviewed by Ross Kirsling.
1490
1491         There three 'separator' variables in TestController.cpp. Renamed
1492         it 'pathSeparator', and unified them.
1493
1494         * WebKitTestRunner/TestController.cpp:
1495         (WTR::TestController::generateContextConfiguration const):
1496         (WTR::createTestURL):
1497         (WTR::TestController::platformAdjustContext):
1498
1499 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1500
1501         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1502         https://bugs.webkit.org/show_bug.cgi?id=194198
1503
1504         Reviewed by Antti Koivisto.
1505
1506         No need to set the banner heights on navigation now, since Page stores them.
1507
1508         * MiniBrowser/mac/WK2BrowserWindowController.m:
1509         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1510
1511 2019-02-03  John Wilander  <wilander@apple.com>
1512
1513         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1514         https://bugs.webkit.org/show_bug.cgi?id=194104
1515         <rdar://problem/47649991>
1516
1517         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1518
1519         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1520         (TestWebKitAPI::TEST):
1521             Changed numeric types from unsigned short to uint32_t.
1522
1523 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1524
1525         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1526         <https://webkit.org/b/194178>
1527         <rdar://problem/47753473>
1528
1529         Reviewed by Alexey Proskuryakov.
1530
1531         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1532         (WTR::uninstallFakeHelvetica): Pass nullptr into
1533         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1534
1535 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1536
1537         [LFC] Initialize ICB's style with fixed width/height.
1538         https://bugs.webkit.org/show_bug.cgi?id=194188
1539
1540         Reviewed by Antti Koivisto.
1541
1542         * LayoutReloaded/misc/LFC-passing-tests.txt:
1543
1544 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1545
1546         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1547         https://bugs.webkit.org/show_bug.cgi?id=194185
1548
1549         Reviewed by Antti Koivisto.
1550
1551         * LayoutReloaded/misc/LFC-passing-tests.txt:
1552
1553 2018-12-16  Darin Adler  <darin@apple.com>
1554
1555         Convert additional String::format clients to alternative approaches
1556         https://bugs.webkit.org/show_bug.cgi?id=192746
1557
1558         Reviewed by Alexey Proskuryakov.
1559
1560         * WebKitTestRunner/TestController.cpp:
1561         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1562         as an intermediate in code that ultimately constructs a WTF::String.
1563         (WTR::userMediaOriginHash): Use makeString.
1564         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1565         (WTR::TestController::didPerformClientRedirect): Ditto.
1566         (WTR::TestController::didPerformServerRedirect): Ditto.
1567         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1568
1569 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1570
1571         [ews-build] Add unit test to verify builder keys
1572         https://bugs.webkit.org/show_bug.cgi?id=194152
1573
1574         Reviewed by Lucas Forschler.
1575
1576         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1577         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1578
1579 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1580
1581         [LFC] Expand tests coverage (12 new tests -> 787)
1582
1583         Unreviewed test gardening.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1588
1589         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1590         https://bugs.webkit.org/show_bug.cgi?id=194163
1591
1592         Reviewed by Simon Fraser.
1593
1594         775
1595
1596         * LayoutReloaded/misc/LFC-passing-tests.txt:
1597
1598 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1599
1600         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1601         https://bugs.webkit.org/show_bug.cgi?id=194140
1602         <rdar://problem/47728098>
1603
1604         Reviewed by Tim Horton.
1605
1606         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1608         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1609
1610         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1611         test to induce an IPC deadlock when presenting a modal alert during touch start.
1612
1613         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1614         * WebKitTestRunner/TestController.cpp:
1615         (WTR::runJavaScriptAlert):
1616
1617         Add a client callback function for running JavaScript alerts.
1618
1619         (WTR::TestController::createOtherPage):
1620         (WTR::TestController::generateContextConfiguration const):
1621
1622         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1623         the fix in this patch.
1624
1625         (WTR::TestController::createWebViewWithOptions):
1626
1627         Plumb TestOptions to generateContextConfiguration.
1628
1629         (WTR::TestController::resetPreferencesToConsistentValues):
1630         (WTR::TestController::resetStateToConsistentValues):
1631         (WTR::updateTestOptionsFromTestHeader):
1632         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1633         (WTR::TestController::handleJavaScriptAlert):
1634         * WebKitTestRunner/TestController.h:
1635         * WebKitTestRunner/TestInvocation.cpp:
1636         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1637         * WebKitTestRunner/TestOptions.h:
1638         (WTR::TestOptions::hasSameInitializationOptions const):
1639
1640 2019-02-01  Chris Dumez  <cdumez@apple.com>
1641
1642         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1643         https://bugs.webkit.org/show_bug.cgi?id=193740
1644         <rdar://problem/47527267>
1645
1646         Reviewed by Alex Christensen.
1647
1648         Add API test coverage.
1649
1650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1651
1652 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1653
1654         [ews-app] Add display name field to BuilderMapping model
1655         https://bugs.webkit.org/show_bug.cgi?id=194153
1656
1657         Reviewed by Lucas Forschler.
1658
1659         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1660         (BuilderMapping):
1661
1662 2019-02-01  Youenn Fablet  <youenn@apple.com>
1663
1664         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1665         https://bugs.webkit.org/show_bug.cgi?id=194155
1666
1667         Reviewed by Eric Carlson.
1668
1669         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1670         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1671         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1672
1673 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1674
1675         [LFC] Adjust replaced element's intrinsic ratio
1676         https://bugs.webkit.org/show_bug.cgi?id=194154
1677
1678         Reviewed by Antti Koivisto.
1679
1680         761
1681
1682         * LayoutReloaded/misc/LFC-passing-tests.txt:
1683
1684 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         [WPE] Show test results in minibrowser
1687         https://bugs.webkit.org/show_bug.cgi?id=194150
1688
1689         Reviewed by Žan Doberšek.
1690
1691         * Scripts/webkitpy/port/wpe.py:
1692         (WPEPort.show_results_html_file):
1693
1694 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1695
1696         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1697         https://bugs.webkit.org/show_bug.cgi?id=194151
1698
1699         Reviewed by Žan Doberšek.
1700
1701         ALT + <- go back
1702         ALT + -> go forward
1703
1704         * MiniBrowser/wpe/main.cpp:
1705         (main):
1706
1707 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1708
1709         [LFC] Set intrinsic size on Layout::Replaced
1710         https://bugs.webkit.org/show_bug.cgi?id=194139
1711
1712         Reviewed by Antti Koivisto.
1713
1714         744
1715
1716         * LayoutReloaded/misc/LFC-passing-tests.txt:
1717
1718 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1719
1720         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1721         https://bugs.webkit.org/show_bug.cgi?id=194146
1722
1723         Reviewed by Xabier Rodriguez-Calvar.
1724
1725         It allows to open relative paths.
1726
1727         * MiniBrowser/wpe/main.cpp:
1728         (main):
1729
1730 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1731
1732         Update flakiness dashboard configuration after recent queue changes
1733         https://bugs.webkit.org/show_bug.cgi?id=194127
1734
1735         Rubber-stamped by Aakash Jain.
1736
1737         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1738
1739         * TestResultServer/static-dashboards/builders.jsonp:
1740
1741 2019-01-31  Youenn Fablet  <youenn@apple.com>
1742
1743         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1744         https://bugs.webkit.org/show_bug.cgi?id=194106
1745         <rdar://problem/47676333>
1746
1747         Reviewed by Ryosuke Niwa.
1748
1749         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1750         (TestWebKitAPI::didFinishNavigation):
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1753
1754 2019-01-31  Chris Dumez  <cdumez@apple.com>
1755
1756         Page zoom level is lost after a process swap or a crash
1757         https://bugs.webkit.org/show_bug.cgi?id=194105
1758         <rdar://problem/47610781>
1759
1760         Reviewed by Alex Christensen.
1761
1762         Add API test coverage.
1763
1764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1765         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1766
1767 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1768
1769         Revert r238819 which is unneeded and caused a performance regression.
1770         https://bugs.webkit.org/show_bug.cgi?id=192272
1771         <rdar://problem/46664625>
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1774         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1775         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1776
1777 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1778
1779         Formalize WebKitAdditions mechanism of LoadOptimizer
1780         https://bugs.webkit.org/show_bug.cgi?id=193886
1781         <rdar://problem/47696809>
1782
1783         Reviewed by Brent Fulgham.
1784
1785         * MiniBrowser/MiniBrowser.entitlements:
1786         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1787
1788 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1789
1790         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1791         https://bugs.webkit.org/show_bug.cgi?id=194090
1792
1793         Reviewed by Antti Koivisto.
1794
1795         * LayoutReloaded/misc/LFC-passing-tests.txt:
1796
1797 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1798
1799         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1800         https://bugs.webkit.org/show_bug.cgi?id=194074
1801
1802         Reviewed by Antti Koivisto.
1803
1804         * LayoutReloaded/misc/LFC-passing-tests.txt:
1805
1806 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1807
1808         [LFC][BFC] Add support for block level replaced box.
1809         https://bugs.webkit.org/show_bug.cgi?id=194071
1810
1811         Reviewed by Antti Koivisto.
1812
1813         * LayoutReloaded/misc/LFC-passing-tests.txt:
1814
1815 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1816
1817         Fix WebKitTestRunner's testPath with Windows full paths
1818         https://bugs.webkit.org/show_bug.cgi?id=194012
1819
1820         Reviewed by Alex Christensen.
1821
1822         updateTestOptionsFromTestHeader failed to open test files because
1823         testPath returned wrong file paths. It returned a path "/C:/..."
1824         if a URL "file:///C:/..." was given.
1825
1826         * WebKitTestRunner/TestController.cpp:
1827         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1828
1829 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         [WPE] Bump font related dependencies to match the GTK+ port
1832         https://bugs.webkit.org/show_bug.cgi?id=194017
1833
1834         Reviewed by Žan Doberšek.
1835
1836         * wpe/jhbuild.modules:
1837         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1838         * wpe/patches/icudata-stdlibs.patch: Added.
1839
1840 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1841
1842         Enable swipe tests on iOS
1843         https://bugs.webkit.org/show_bug.cgi?id=194076
1844
1845         Reviewed by Geoffrey Garen.
1846
1847         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1848         it causes a debug assertion failure in runUIScript.
1849
1850         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1851         (WTR::UIScriptController::beginBackSwipe):
1852         (WTR::UIScriptController::completeBackSwipe):
1853
1854 2019-01-30  Keith Rollin  <krollin@apple.com>
1855
1856         Use correct printf format specifier
1857         https://bugs.webkit.org/show_bug.cgi?id=194062
1858         <rdar://problem/47686167>
1859
1860         Reviewed by Alexey Proskuryakov.
1861
1862         LayoutTestSpellChecker.mm is trying to format a variable of type
1863         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1864         actually an unsigned long long. Fix this by formatting with %llu.
1865
1866         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1867         (-[LayoutTestTextCheckingResult description]):
1868
1869 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1870
1871         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1872         https://bugs.webkit.org/show_bug.cgi?id=193979
1873
1874         Reviewed by Wenson Hsieh.
1875
1876         Fix the test for iOS. Make the test work with iOS UA string.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1879
1880 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1881
1882         Replace High Sierra LLINT CLoop bot due to hardware failure
1883         https://bugs.webkit.org/show_bug.cgi?id=194066
1884
1885         Reviewed by Aakash Jain.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/config.json:
1888
1889 2019-01-30  Keith Rollin  <krollin@apple.com>
1890
1891         [NSDragItem init] is unavailable
1892         https://bugs.webkit.org/show_bug.cgi?id=194059
1893         <rdar://problem/47685715>
1894
1895         Reviewed by Wenson Hsieh.
1896
1897         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1898         DumpRenderTree and TestWebKitAPI, which both try to create an
1899         NSDragItem in a manner that invokes this method. Address this by using
1900         -initWithPasteboardWriter instead.
1901
1902         Note that the parameter passed to initWithPasteboardWriter is likely
1903         incorrect. In both cases, the object passed does not conform to
1904         NSPasteboardWriting. However, with this fix, we're no worse off than
1905         before, and can now perform builds with newer compilers and SDKs until
1906         a real fix can be crafted. That work is tracked in
1907         https://bugs.webkit.org/show_bug.cgi?id=194060
1908
1909         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1910         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1911         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1912         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1913
1914 2019-01-30  Daniel Bates  <dabates@apple.com>
1915
1916         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1917         https://bugs.webkit.org/show_bug.cgi?id=192824
1918         <rdar://problem/47100332>
1919
1920         Reviewed by Wenson Hsieh.
1921
1922         Fix a bug where the wrong usage code was used for F13 thru F24.
1923
1924         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1925         (keyCodeForDOMFunctionKey):
1926
1927 2019-01-30  Chris Dumez  <cdumez@apple.com>
1928
1929         Regression(PSON) Load hang can occur on history navigation
1930         https://bugs.webkit.org/show_bug.cgi?id=194030
1931         <rdar://problem/47656939>
1932
1933         Reviewed by Antti Koivisto.
1934
1935         Add API test coverage.
1936
1937         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1938
1939 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1940
1941         [LFC] Expand tests coverage.
1942
1943         Unreviewed test gardening.
1944
1945         * LayoutReloaded/misc/LFC-passing-tests.txt:
1946
1947 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1948
1949         [Flatpak] Add openjpeg support
1950         https://bugs.webkit.org/show_bug.cgi?id=194019
1951
1952         Reviewed by Michael Catanzaro.
1953
1954         * flatpak/org.webkit.CommonModules.yaml:
1955
1956 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1957
1958         Unreviewed, rolling out r240708.
1959         https://bugs.webkit.org/show_bug.cgi?id=194022
1960
1961         It broke WPE build (Requested by KaL on #webkit).
1962
1963         Reverted changeset:
1964
1965         "[WPE] Bump font related dependencies to match the GTK+ port"
1966         https://bugs.webkit.org/show_bug.cgi?id=194017
1967         https://trac.webkit.org/changeset/240708
1968
1969 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1970
1971         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1972         https://bugs.webkit.org/show_bug.cgi?id=194001
1973
1974         Reviewed by Antti Koivisto.
1975
1976         * LayoutReloaded/misc/LFC-passing-tests.txt:
1977
1978 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1979
1980         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1981         https://bugs.webkit.org/show_bug.cgi?id=194020
1982
1983         Reviewed by Antti Koivisto.
1984
1985         * LayoutReloaded/misc/LFC-passing-tests.txt:
1986
1987 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1988
1989         AX: Support color well on iOS
1990         https://bugs.webkit.org/show_bug.cgi?id=194010
1991
1992         Reviewed by Joanmarie Diggs.
1993
1994         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1995         (WTR::AccessibilityUIElement::stringAttributeValue):
1996
1997 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1998
1999         [WPE] Bump font related dependencies to match the GTK+ port
2000         https://bugs.webkit.org/show_bug.cgi?id=194017
2001
2002         Reviewed by Žan Doberšek.
2003
2004         * wpe/jhbuild.modules:
2005         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2006         * wpe/patches/icudata-stdlibs.patch: Added.
2007
2008 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2009
2010         [Mac] Update window scale API usage
2011         https://bugs.webkit.org/show_bug.cgi?id=193991
2012         rdar://problem/47614795
2013
2014         Reviewed by Tim Horton.
2015
2016         * DumpRenderTree/mac/DumpRenderTree.mm:
2017         (changeWindowScaleIfNeeded):
2018         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2019         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2020         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2021
2022 2019-01-29  Chris Dumez  <cdumez@apple.com>
2023
2024         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2025         https://bugs.webkit.org/show_bug.cgi?id=193977
2026         <rdar://problem/47643716>
2027
2028         Reviewed by Geoff Garen.
2029
2030         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2031         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2032         to the previous provisional committing *before* we make the last load. 
2033
2034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2035
2036 2019-01-29  Youenn Fablet  <youenn@apple.com>
2037
2038         Adopt new SPI to evaluate server certificate trust
2039         https://bugs.webkit.org/show_bug.cgi?id=193355
2040
2041         Reviewed by Alex Christensen.
2042
2043         Add infrastructure to handle HTTPS server trust evaluation testing.
2044
2045         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2046         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2047         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2048         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2049         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::resetPreferencesToConsistentValues):
2053         (WTR::TestController::didReceiveAuthenticationChallenge):
2054         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2055         * WebKitTestRunner/TestController.h:
2056         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2057         * WebKitTestRunner/TestInvocation.cpp:
2058         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2059         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2060         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2061
2062 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [ews-build] Add build step to print bot Configuration
2065         https://bugs.webkit.org/show_bug.cgi?id=193887
2066
2067         Reviewed by Lucas Forschler.
2068
2069         * BuildSlaveSupport/ews-build/steps.py:
2070         (PrintConfiguration): Build step to print configuration.
2071         * BuildSlaveSupport/ews-build/factories.py:
2072
2073 2019-01-29  Chris Dumez  <cdumez@apple.com>
2074
2075         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2076         https://bugs.webkit.org/show_bug.cgi?id=193967
2077         <rdar://problem/47635348>
2078
2079         Reviewed by Alex Christensen.
2080
2081         Add API test coverage.
2082
2083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2084         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2085
2086 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-app] Handle incoming results data
2089         https://bugs.webkit.org/show_bug.cgi?id=193973
2090
2091         Reviewed by Lucas Forschler.
2092
2093         * BuildSlaveSupport/ews-app/ews/views/results.py:
2094
2095 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-app] Make the results url generic
2098         https://bugs.webkit.org/show_bug.cgi?id=193928
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-app/ews/urls.py:
2103
2104 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-build] Configure buildbot to send events to ews-app
2107         https://bugs.webkit.org/show_bug.cgi?id=193968
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * BuildSlaveSupport/ews-build/events.py: Added.
2112         * BuildSlaveSupport/ews-build/master.cfg:
2113
2114 2019-01-29  Keith Rollin  <krollin@apple.com>
2115
2116         Add .xcfilelists to Run Script build phases
2117         https://bugs.webkit.org/show_bug.cgi?id=193792
2118         <rdar://problem/47201785>
2119
2120         Reviewed by Alex Christensen.
2121
2122         As part of supporting XCBuild, update the necessary Run Script build
2123         phases in their Xcode projects to refer to their associated
2124         .xcfilelist files.
2125
2126         Note that the addition of these files bumps the Xcode project version
2127         number to something that's Xcode 10 compatible. This change means that
2128         older versions of the Xcode IDE can't read these projects. Nor can it
2129         fully load workspaces that refer to these projects (the updated
2130         projects are shown as non-expandable placeholders). `xcodebuild` can
2131         still build these projects; it's just that the IDE can't open them.
2132
2133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2134         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2135
2136 2019-01-29  John Wilander  <wilander@apple.com>
2137
2138         Add data abstraction and validation for Ad Click Attribution
2139         https://bugs.webkit.org/show_bug.cgi?id=193916
2140         <rdar://problem/47603481>
2141
2142         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2143
2144         Ad click attribution has two steps. First, the storage of an ad
2145         campaign ID for a click that takes the user to a destination
2146         site. Second, a conversion on the destination site that can be
2147         attributed to the ad click.
2148
2149         This patch adds a class that represents a request for ad click
2150         attribution. Validation makes sure that the bits of entropy
2151         reported through this mechanism is limited.
2152
2153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2154         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2155         (TestWebKitAPI::TEST):
2156
2157 2019-01-29  Chris Dumez  <cdumez@apple.com>
2158
2159         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2160         https://bugs.webkit.org/show_bug.cgi?id=193932
2161         <rdar://problem/47598947>
2162
2163         Reviewed by Brady Eidson.
2164
2165         Add API test coverage.
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2168
2169 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2170
2171         Adding new passing LFC tests.
2172
2173         Unreviewed test gardening.
2174
2175         * LayoutReloaded/misc/LFC-passing-tests.txt:
2176
2177 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2178
2179         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2180         https://bugs.webkit.org/show_bug.cgi?id=193964
2181
2182         Reviewed by Antti Koivisto.
2183
2184         * LayoutReloaded/misc/LFC-passing-tests.txt:
2185
2186 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2187
2188         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2189         https://bugs.webkit.org/show_bug.cgi?id=193954
2190
2191         Reviewed by Antti Koivisto.
2192
2193         * LayoutReloaded/misc/LFC-passing-tests.txt:
2194
2195 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         WebDriver: add support for running subtests
2198         https://bugs.webkit.org/show_bug.cgi?id=193904
2199
2200         Reviewed by Michael Catanzaro.
2201
2202         pytest already supports it by passing test.py::subtest, so we can do the same.
2203
2204         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2205         (get_item_name): Made this global.
2206         (CollectRecorder.__init__): Receive the parameter to ignore.
2207         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2208         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2209         (collect): Add parameter to ignore.
2210         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2211         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2212         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2213         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2214         (WebDriverTestRunnerSelenium.run): Ditto.
2215         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2216         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2217         (WebDriverTestRunnerW3C.run): Ditto.
2218
2219 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2220
2221         User agent string override for navigator.userAgent should be site specific quirks
2222         https://bugs.webkit.org/show_bug.cgi?id=193950
2223
2224         Reviewed by Brent Fulgham.
2225
2226         Updated per the _WKWebsitePolicies rename.
2227
2228         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2229         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2230
2231 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2232
2233         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2234         https://bugs.webkit.org/show_bug.cgi?id=193941
2235
2236         Reviewed by Alex Christensen.
2237
2238         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2239         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2240         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2241         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2242         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2243         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2244         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2245         * TestWebKitAPI/Tests/WTF/Time.cpp:
2246         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2247         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2248         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2249         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2250
2251 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2252
2253         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2254
2255         * Scripts/webkitpy/common/config/contributors.json:
2256
2257 2019-01-28  Andy Estes  <aestes@apple.com>
2258
2259         [watchOS] Enable Parental Controls content filtering
2260         https://bugs.webkit.org/show_bug.cgi?id=193939
2261         <rdar://problem/46641912>
2262
2263         Reviewed by Ryosuke Niwa.
2264
2265         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2266
2267 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2268
2269         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2270         <https://webkit.org/b/193884>
2271
2272         Reviewed by Jiewen Tan.
2273
2274         * Scripts/webkitpy/style/checkers/cpp.py:
2275         (check_language): Add LocalAuthentication to
2276         `frameworks_with_soft_links`.
2277
2278 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2279
2280         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2281         https://bugs.webkit.org/show_bug.cgi?id=193891
2282
2283         Reviewed by Ross Kirsling.
2284
2285         There were three problems in window sizes of WebView and the host window.
2286         1. The sizes of pixel image output were incorrect.
2287         2. The host window is going to appear after window.resize was invoked.
2288         3. window.resize resized only the host window, not WebView.
2289
2290         This change solves them with a following approach.
2291         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2292         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2293            as well as DumpRenderTree in order to match the client area and the window area.
2294         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2295         d. PlatformWebView::setWindowFrame changes both window sizes.
2296         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2297
2298         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2299         (WTR::PlatformWebView::PlatformWebView): Create the host window
2300         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2301         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2302         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2303
2304 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2305
2306         [ews-app] Add method to save Step data to database
2307         https://bugs.webkit.org/show_bug.cgi?id=193890
2308
2309         Reviewed by Lucas Forschler.
2310
2311         * BuildSlaveSupport/ews-app/ews/models/step.py:
2312         (Step.save_step): Method to save step data.
2313         (Step.update_step): Method to update step data.
2314         (Step.get_existing_step): Method to fetch existing step from database.
2315         (Step.is_valid_result): Method to validate valid step result.
2316
2317 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews-app] Add method to save Build data to database
2320         https://bugs.webkit.org/show_bug.cgi?id=193735
2321
2322         Reviewed by Lucas Forschler.
2323
2324         * BuildSlaveSupport/ews-app/ews/models/build.py:
2325         (Build.save_build): Method to save build information to database.
2326         (Build.get_existing_build): Method to fetch existing build from database.
2327         (Build.is_valid_result): Method to validate build result.
2328         * BuildSlaveSupport/ews-app/ews/common/util.py:
2329         (is_valid_int_id): Method to validate valid id.
2330
2331 2019-01-28  Chris Dumez  <cdumez@apple.com>
2332
2333         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2334         https://bugs.webkit.org/show_bug.cgi?id=193915
2335         <rdar://problem/47560907>
2336
2337         Reviewed by Alex Christensen.
2338
2339         Add API test coverage.
2340
2341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2342
2343 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-app] Rename id variables
2346         https://bugs.webkit.org/show_bug.cgi?id=193883
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-app/ews/models/build.py:
2351         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2352         * BuildSlaveSupport/ews-app/ews/models/step.py:
2353         * BuildSlaveSupport/ews-app/ews/urls.py:
2354         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2355         * BuildSlaveSupport/ews-app/ews/views/results.py:
2356         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2357
2358 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews-app] Allow certain fields to be empty
2361         https://bugs.webkit.org/show_bug.cgi?id=193892
2362
2363         Reviewed by Lucas Forschler.
2364
2365         * BuildSlaveSupport/ews-app/ews/models/build.py:
2366         * BuildSlaveSupport/ews-app/ews/models/step.py:
2367
2368 2019-01-28  Rob Buis  <rbuis@igalia.com>
2369
2370         Update MIME type parser
2371         https://bugs.webkit.org/show_bug.cgi?id=180526
2372
2373         Reviewed by Frédéric Wang.
2374
2375         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2376         (TestWebKitAPI::TEST):
2377
2378 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2379
2380         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2381         https://bugs.webkit.org/show_bug.cgi?id=193896
2382
2383         Reviewed by Antti Koivisto.
2384
2385         * LayoutReloaded/misc/LFC-passing-tests.txt:
2386
2387 2018-12-15  Darin Adler  <darin@apple.com>
2388
2389         Replace many uses of String::format with more type-safe alternatives
2390         https://bugs.webkit.org/show_bug.cgi?id=192742
2391
2392         Reviewed by Mark Lam.
2393
2394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2395         (WTR::cacheTestRunnerCallback): Use makeString.
2396         * WebKitTestRunner/TestController.cpp:
2397         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2398         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2399
2400 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2401
2402         Use a load optimizer for some sites
2403         https://bugs.webkit.org/show_bug.cgi?id=193881
2404         <rdar://problem/46325455>
2405
2406         Reviewed by Brent Fulgham.
2407
2408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2409         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2410
2411 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2412
2413         AX: Introduce a static accessibility tree
2414         https://bugs.webkit.org/show_bug.cgi?id=193348
2415         <rdar://problem/47203295>
2416
2417         Reviewed by Ryosuke Niwa.
2418
2419         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2420
2421 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2422
2423         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2424         https://bugs.webkit.org/show_bug.cgi?id=193867
2425
2426         Reviewed by Antti Koivisto.
2427
2428         * LayoutReloaded/misc/LFC-passing-tests.txt:
2429
2430 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2431
2432         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2433         https://bugs.webkit.org/show_bug.cgi?id=193865
2434
2435         Reviewed by Antti Koivisto.
2436
2437         * LayoutReloaded/misc/LFC-passing-tests.txt:
2438
2439 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2440
2441         Need a mechanism to override navigator.userAgent
2442         https://bugs.webkit.org/show_bug.cgi?id=193762
2443         <rdar://problem/47504939>
2444
2445         Reviewed by Brent Fulgham.
2446
2447         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2448
2449         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2450         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2451         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2452
2453 2019-01-25  Dean Jackson  <dino@apple.com>
2454
2455         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2456         https://bugs.webkit.org/show_bug.cgi?id=193831
2457         <rdar://problem/47399263>
2458
2459         Reviewed by Chris Dumez.
2460
2461         Two new tests that exercise cross-origin and same-origin System
2462         Previews.
2463
2464         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2465
2466 2019-01-25  Keith Rollin  <krollin@apple.com>
2467
2468         Update Xcode projects with "Check .xcfilelists" build phase
2469         https://bugs.webkit.org/show_bug.cgi?id=193790
2470         <rdar://problem/47201374>
2471
2472         Reviewed by Alex Christensen.
2473
2474         Support for XCBuild includes specifying inputs and outputs to various
2475         Run Script build phases. These inputs and outputs are specified as
2476         .xcfilelist files. Once created, these .xcfilelist files need to be
2477         kept up-to-date. In order to check that they are up-to-date or not,
2478         add an Xcode build step that invokes an external script that performs
2479         the checking. If the .xcfilelists are found to be out-of-date, update
2480         them, halt the build, and instruct the developer to restart the build
2481         with up-to-date files.
2482
2483         At this time, the checking and regenerating is performed only if the
2484         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2485         who want to use this facility can set this variable and test out the
2486         checking/regenerating. Once it seems like there are no egregious
2487         issues that upset a developer's workflow, we'll unconditionally enable
2488         this facility.
2489
2490         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2491         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2492         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2493         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2494
2495 2019-01-25  Keith Rollin  <krollin@apple.com>
2496
2497         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2498         https://bugs.webkit.org/show_bug.cgi?id=193781
2499         <rdar://problem/47201153>
2500
2501         Reviewed by Alex Christensen.
2502
2503         Part of generating the .xcfilelists used as part of adopting XCBuild
2504         includes running `make DerivedSources.make` from a standalone script.
2505         It’s important for this invocation to have the same environment as
2506         when the actual build invokes `make DerivedSources.make`. If the
2507         environments are different, then the two invocations will provide
2508         different results. In order to get the same environment in the
2509         standalone script, have the script launch xcodebuild targeting the
2510         "Apply Configuration to XCFileLists" build target, which will then
2511         re-invoke our standalone script. The script is now running again, this
2512         time in an environment with all workspace, project, target, xcconfig
2513         and other environment variables established.
2514
2515         The "Apply Configuration to XCFileLists" build target accomplishes
2516         this task via a small embedded shell script that consists only of:
2517
2518             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2519
2520         The process that invokes "Apply Configuration to XCFileLists" first
2521         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2522         evaluated and exports it into the shell environment. When xcodebuild
2523         is invoked, it inherits the value of this variable and can `eval` the
2524         contents of that variable. Our external standalone script can then set
2525         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2526         of command-line parameters needed to restart itself in the appropriate
2527         state.
2528
2529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2530         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2531
2532 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2533
2534         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2535         https://bugs.webkit.org/show_bug.cgi?id=193802
2536         <rdar://problem/46010580>
2537
2538         Reviewed by Andy Estes.
2539
2540         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2541         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2542         (TEST):
2543
2544 2019-01-25  Daniel Bates  <dabates@apple.com>
2545
2546         [iOS] uiController.keyDown() does not translate Control modified key
2547         https://bugs.webkit.org/show_bug.cgi?id=192898
2548
2549         Reviewed by Wenson Hsieh.
2550
2551         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2552         key translation, as applicable. Among other cases, key translation occurs when performing
2553         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2554         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2555         human pressing down and releasing key(s) using a hardware keyboard.
2556
2557         * WebKitTestRunner/ios/HIDEventGenerator.h:
2558         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2559         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2560
2561         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2562         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2563         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2564         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2565         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2566         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2567         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2568         (-[HIDEventGenerator longPress:completionBlock:]):
2569         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2570         Update code for above renaming.
2571
2572         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2573         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2574
2575         (-[HIDEventGenerator keyDown:]): Added.
2576         (-[HIDEventGenerator keyUp:]): Added.
2577         (-[HIDEventGenerator keyPress:completionBlock:]):
2578         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2579         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2580         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2581         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2582         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2583         (WTR::parseModifier): Deleted.
2584
2585 2019-01-25  Keith Rollin  <krollin@apple.com>
2586
2587         Complete the implementation of generate-xcfilelists
2588         https://bugs.webkit.org/show_bug.cgi?id=193782
2589
2590         Reviewed by Alex Christensen.
2591
2592         A preliminary version of generate-xcfilelists was added in r238008.
2593         This patch updates that script in order to:
2594
2595         - Support checking of .xcfilelists
2596         - Perform better execution of `make DerivedSources.make` by
2597           relaunching generate-xcfilelists under xcodebuild
2598         - Support incremental generation and checking of .xcfilelists
2599         - Support supplementary .xcfilelists files from WebKitAdditions
2600         - Support being wrapped by parallel version of generate-xcfilelists in
2601           Internal that adds support for (re)generating WebKit projects in
2602           that repo.
2603         - Support builds that have been performed in WebKitBuild as well as
2604           ~/Library/Developer/code/DerivedData
2605         - Increase robustness and debugging facilities.
2606
2607         * Scripts/generate-xcfilelists:
2608
2609 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2610
2611         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2612         https://bugs.webkit.org/show_bug.cgi?id=193297
2613         <rdar://problem/47158841>
2614
2615         Unreviewed test case fix.
2616
2617         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2618         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2621         (TEST):
2622
2623 2019-01-25  Keith Rollin  <krollin@apple.com>
2624
2625         Update existing .xcfilelists
2626         https://bugs.webkit.org/show_bug.cgi?id=193791
2627         <rdar://problem/47201706>
2628
2629         Reviewed by Alex Christensen.
2630
2631         Many .xcfilelist files were added in r238824 in order to support
2632         XCBuild. Update these with recent changes to the set of build files
2633         and with the current generate-xcfilelist script.
2634
2635         * DumpRenderTree/DerivedSources-input.xcfilelist:
2636         * DumpRenderTree/DerivedSources-output.xcfilelist:
2637         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2638         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2639
2640 2019-01-25  Keith Rollin  <krollin@apple.com>
2641
2642         Fix missing dependencies in extract-dependencies-from-makefile
2643         https://bugs.webkit.org/show_bug.cgi?id=193783
2644         <rdar://problem/47201571>
2645
2646         Reviewed by Alex Christensen.
2647
2648         The extract-dependencies-from-makefile script generates .xcfilelists
2649         for XCBuild by invoking a makefile in --debug mode, parsing the
2650         dependency information in the output, and extracting information
2651         regarding targets and dependents. However, the way `make` emits this
2652         dependency information is not rigorous, and so we need to determine
2653         what lines to look for and parse by trial and error. This approach
2654         didn't coriginally atch all the information we needed to collect, so
2655         update the script to look for the additional lines we now know to look
2656         for.
2657
2658         * Scripts/extract-dependencies-from-makefile:
2659         (Parser):
2660         (Parser.addTarget):
2661         (Parser.addPrereq):
2662         (Parser.doParse):
2663
2664 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2665
2666         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2667         https://bugs.webkit.org/show_bug.cgi?id=193297
2668         <rdar://problem/47158841>
2669
2670         Reviewed by Alex Christensen.
2671
2672         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2673             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2675         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2676         activating the message used to trigger the callback when it is set.
2677
2678 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2679
2680         WKWebView.goBack should reload if there is a safe browsing warning
2681         https://bugs.webkit.org/show_bug.cgi?id=193805
2682         <rdar://problem/46908216>
2683
2684         Reviewed by Geoff Garen.
2685
2686         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2687         (+[Simple3LookupContext sharedLookupContext]):
2688         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2689         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2690         (TEST):
2691
2692 2019-01-25  Chris Dumez  <cdumez@apple.com>
2693
2694         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2695         https://bugs.webkit.org/show_bug.cgi?id=193788
2696         <rdar://problem/47531231>
2697
2698         Reviewed by Alex Christensen.
2699
2700         Add API test coverage.
2701
2702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2703         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2704
2705 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2706
2707         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2708         https://bugs.webkit.org/show_bug.cgi?id=193771
2709
2710         Unreviewed infrastructure fix.
2711
2712         * Scripts/webkitpy/port/darwin.py:
2713         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2714
2715 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2716
2717         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2718
2719 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2720
2721         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2722
2723         * Scripts/webkitpy/common/config/contributors.json:
2724
2725 2019-01-25  Chris Dumez  <cdumez@apple.com>
2726
2727         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2728         https://bugs.webkit.org/show_bug.cgi?id=193779
2729         <rdar://problem/46170903>
2730
2731         Reviewed by Antti Koivisto.
2732
2733         Add API test that quickly navigates forward to a previous process without waiting for it to
2734         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2735         the process' previous page when reconnecting the it for the forward navigation.
2736
2737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2738
2739 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2740
2741         Need a way for JavaScript (or bundle) code to participate in undo
2742         https://bugs.webkit.org/show_bug.cgi?id=190009
2743         <rdar://problem/44807048>
2744
2745         Reviewed by Ryosuke Niwa.
2746
2747         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2748         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2749
2750         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2751         (WTR::UIScriptController::lastUndoLabel const):
2752         (WTR::UIScriptController::firstRedoLabel const):
2753         (WTR::UIScriptController::platformUndoManager const):
2754         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2755         (WTR::UIScriptController::lastUndoLabel const):
2756         (WTR::UIScriptController::firstRedoLabel const):
2757         (WTR::UIScriptController::platformUndoManager const):
2758         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2759         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2760         (WTR::UIScriptController::lastUndoLabel const):
2761         (WTR::UIScriptController::firstRedoLabel const):
2762         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2763         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2764         (WTR::UIScriptController::lastUndoLabel const):
2765         (WTR::UIScriptController::firstRedoLabel const):
2766         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2767         (WTR::UIScriptController::platformUndoManager const):
2768         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2769         (WTR::UIScriptController::platformUndoManager const):
2770
2771 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2772
2773         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2774         https://bugs.webkit.org/show_bug.cgi?id=193824
2775
2776         Reviewed by Antti Koivisto.
2777
2778         * LayoutReloaded/misc/LFC-passing-tests.txt:
2779
2780 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2781
2782         Update macOS JSC bot configurations
2783         https://bugs.webkit.org/show_bug.cgi?id=193739
2784
2785         Reviewed by Alexey Proskuryakov.
2786
2787         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2789         (BubbleQueueServer): Move JSC EWS to Mojave section.
2790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2791         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2792         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2793
2794 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2795
2796         [Win][WebKitTestRunner] Implement EventSenderProxy
2797         https://bugs.webkit.org/show_bug.cgi?id=193755
2798
2799         Reviewed by Don Olmstead.
2800
2801         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2802         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2803         (WTR::EventSenderProxy::dispatchMessage):
2804         (WTR::EventSenderProxy::EventSenderProxy):
2805         (WTR::EventSenderProxy::mouseDown):
2806         (WTR::EventSenderProxy::mouseUp):
2807         (WTR::EventSenderProxy::mouseMoveTo):
2808         (WTR::EventSenderProxy::mouseScrollBy):
2809         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2810
2811 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2812
2813         Unreviewed fix for API test failure after r240437.
2814
2815         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2816
2817         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2818
2819 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2820
2821         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2822         https://bugs.webkit.org/show_bug.cgi?id=193787
2823         <rdar://problem/47497634>
2824
2825         Reviewed by Alexey Proskuryakov.
2826
2827         * Scripts/webkitdirs.pm:
2828         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2829
2830 2019-01-24  Truitt Savell  <tsavell@apple.com>
2831
2832         Unreviewed, rolling out r240446.
2833
2834         Casued 5 API failures
2835
2836         Reverted changeset:
2837
2838         "Activate the WebResourceLoadStatisticsStore in the
2839         NetworkProcess and deactivate it in the UIProcess."
2840         https://bugs.webkit.org/show_bug.cgi?id=193297
2841         https://trac.webkit.org/changeset/240446
2842
2843 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2844
2845         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2846         https://bugs.webkit.org/show_bug.cgi?id=193741
2847         <rdar://problem/47135030>
2848
2849         Reviewed by Antti Koivisto and Simon Fraser.
2850
2851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2852         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2853         (TestWebKitAPI::TEST):
2854
2855 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2856
2857         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2858         https://bugs.webkit.org/show_bug.cgi?id=193297
2859         <rdar://problem/47158841>
2860
2861         Reviewed by Alex Christensen.
2862
2863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2864         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2865         activating the message used to trigger the callback when it is set.
2866
2867 2019-01-24  John Wilander  <wilander@apple.com>
2868
2869         Add Ad Click Attribution as an internal/experimental feature
2870         https://bugs.webkit.org/show_bug.cgi?id=193685
2871         <rdar://problem/47450399>
2872
2873         Reviewed by Brent Fulgham.
2874
2875         Added test option adClickAttributionEnabled.
2876
2877         * DumpRenderTree/TestOptions.cpp:
2878         (TestOptions::TestOptions):
2879         * DumpRenderTree/TestOptions.h:
2880         * DumpRenderTree/mac/DumpRenderTree.mm:
2881         (setWebPreferencesForTestOptions):
2882
2883 2019-01-24  Antti Koivisto  <antti@apple.com>
2884
2885         [PSON] Flash on back navigation on Mac
2886         https://bugs.webkit.org/show_bug.cgi?id=193716
2887         <rdar://problem/47148458>
2888
2889         Reviewed by Chris Dumez.
2890
2891         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2892
2893         Closing of the previous page is delayed so waiting for didFinishNavigation is
2894         not sufficient to guarantee we have received all the messages. Wait for them.
2895
2896 2019-01-24  Chris Dumez  <cdumez@apple.com>
2897
2898         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2899         https://bugs.webkit.org/show_bug.cgi?id=193761
2900         <rdar://problem/47456405>
2901
2902         Reviewed by Alex Christensen.
2903
2904         Add API test coverage.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2907
2908 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2909
2910         webkitpy: Missing PID in crashlog name should not be fatal
2911         https://bugs.webkit.org/show_bug.cgi?id=193771
2912
2913         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2914         of raising an exception.
2915
2916         Reviewed by Lucas Forschler.
2917
2918         * Scripts/webkitpy/port/darwin.py:
2919         (DarwinPort._merge_crash_logs):
2920
2921 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2922
2923         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2924         https://bugs.webkit.org/show_bug.cgi?id=193746
2925
2926         Reviewed by Youenn Fablet.
2927
2928         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2929         so we'd best just not call it.
2930
2931         * Scripts/webkitpy/w3c/test_exporter.py:
2932         (WebPlatformTestExporter.create_branch_with_patch):
2933
2934 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2935
2936         Move FileSystem to WTF
2937         https://bugs.webkit.org/show_bug.cgi?id=193602
2938
2939         Reviewed by Yusuke Suzuki.
2940
2941         * DumpRenderTree/win/DumpRenderTree.cpp:
2942         * TestWebKitAPI/CMakeLists.txt:
2943         * TestWebKitAPI/PlatformGTK.cmake:
2944         * TestWebKitAPI/PlatformJSCOnly.cmake:
2945         * TestWebKitAPI/PlatformPlayStation.cmake:
2946         * TestWebKitAPI/PlatformWPE.cmake:
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2949         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2950         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2951         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2952         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2953         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2954         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2955         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2956         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2957
2958 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2959
2960         [WPE] Remove hard dependency on subprocess32 for the API tests
2961
2962         Rubber-stamped by Carlos Garcia Campos.
2963
2964         * glib/api_test_runner.py:
2965         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2966         its presence only when running WPEQt tests.
2967
2968 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2969
2970         [GLIB] Expose JavaScriptCore options in GLib public API
2971         https://bugs.webkit.org/show_bug.cgi?id=188742
2972
2973         Reviewed by Michael Catanzaro.
2974
2975         Add a test for the new API.
2976
2977         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2978         (testsJSCOptions):
2979         (main):
2980
2981 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2982
2983         [GTK][WPE] Support JPEG 2000 images
2984         https://bugs.webkit.org/show_bug.cgi?id=186272
2985
2986         Reviewed by Žan Doberšek.
2987
2988         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2989
2990         * gtk/jhbuild.modules:
2991         * wpe/jhbuild.modules:
2992
2993 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2994
2995         check-webkit-style should warn when using soft-linking macros in a header
2996         <https://webkit.org/b/193750>
2997
2998         Reviewed by Darin Adler.
2999
3000         * Scripts/webkitpy/style/checkers/cpp.py:
3001         (check_language): Add softlink/header check by refactoring the
3002         softlink/framework check.
3003         (CppChecker): Enable softlink/header check by default.
3004         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3005         (CppStyleTest.test_softlink_framework): Rename from
3006         CppStyleTest.test_softlink() and change test framework name in
3007         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3008         files. Set file_name for macros that only appear in headers.
3009         (CppStyleTest.test_softlink_header): Add tests for using
3010         soft-link macros in headers.
3011
3012 2019-01-23  Chris Dumez  <cdumez@apple.com>
3013
3014         Deprecate API to limit the maximum number of WebProcesses
3015         https://bugs.webkit.org/show_bug.cgi?id=193725
3016         <rdar://problem/47464879>
3017
3018         Reviewed by Geoff Garen.
3019
3020         Update existing API tests to stop using deprecated API.
3021
3022         * MiniBrowser/mac/AppDelegate.m:
3023         (defaultConfiguration):
3024         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3025         (TestWebKitAPI::TEST):
3026         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3029         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3030         (TEST):
3031         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3032         (TEST):
3033
3034 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3035
3036         [ews-app] Rename ews model buildermappings to buildermapping
3037         https://bugs.webkit.org/show_bug.cgi?id=193729
3038
3039         Reviewed by Lucas Forschler.
3040
3041         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3042         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3043         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3044
3045 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3046
3047         [ews-app] Rename ews model steps to step
3048         https://bugs.webkit.org/show_bug.cgi?id=193697
3049
3050         Reviewed by Lucas Forschler.
3051
3052         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3053         (Step): Renamed Steps to Step.
3054
3055 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3056
3057         Clean up IndexedDB files between tests
3058         https://bugs.webkit.org/show_bug.cgi?id=192796
3059         <rdar://problem/46824999>
3060
3061         Reviewed by Geoffrey Garen.
3062
3063         * DumpRenderTree/mac/DumpRenderTree.mm:
3064         (runTest):
3065         * WebKitTestRunner/TestController.cpp:
3066         (WTR::TestController::resetStateToConsistentValues):
3067         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3068         (WTR::RemoveAllIndexedDatabasesCallback):
3069         (WTR::TestController::ClearIndexedDatabases):
3070         * WebKitTestRunner/TestController.h:
3071         * WebKitTestRunner/TestInvocation.cpp:
3072         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3073
3074 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3075
3076         [ews-app] Rename ews model Builds to Build
3077         https://bugs.webkit.org/show_bug.cgi?id=193695
3078
3079         Reviewed by Lucas Forschler.
3080
3081         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3082         (Build): Renamed Builds to Build.
3083
3084 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3085
3086         webkitpy: Wait longer when launching WebKitTestRunner
3087         https://bugs.webkit.org/show_bug.cgi?id=193734
3088
3089         Reviewed by Aakash Jain.
3090
3091         * Scripts/webkitpy/port/simulator_process.py:
3092         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3093
3094 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3095
3096         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3097         https://bugs.webkit.org/show_bug.cgi?id=193182
3098         <rdar://problem/47452154>
3099
3100         Reviewed by Tim Horton.
3101
3102         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3103         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3104         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3105
3106         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3107         preventing later tests from recognizing gestures.
3108
3109         * WebKitTestRunner/ios/TestControllerIOS.mm:
3110         (WTR::TestController::platformResetStateToConsistentValues):
3111
3112         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3113
3114 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3115
3116         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3117         https://bugs.webkit.org/show_bug.cgi?id=193722
3118         <rdar://problem/47481475>
3119
3120         Reviewed by Lucas Forschler.
3121
3122         iPhone and iPad ports should both use the iOS config.
3123
3124         * Scripts/webkitpy/port/ios_simulator.py:
3125         (IPhoneSimulatorPort.__init__):
3126         (IPadSimulatorPort.__init__):
3127
3128 2019-01-23  Rob Buis  <rbuis@igalia.com>
3129
3130         Update MIME type parser
3131         https://bugs.webkit.org/show_bug.cgi?id=180526
3132
3133         Reviewed by Frédéric Wang.
3134
3135         Add unit tests for both parse modes of ParsedContentType.
3136
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3139         (TestWebKitAPI::TEST):
3140
3141 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3142
3143         [ews-app] fetch loop should not stop on network issues
3144         https://bugs.webkit.org/show_bug.cgi?id=193666
3145
3146         Reviewed by Lucas Forschler.
3147
3148         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3149         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3150
3151 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3152
3153         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3154         https://bugs.webkit.org/show_bug.cgi?id=189165
3155         <rdar://problem/47433765>
3156
3157         Reviewed by Tim Horton.
3158
3159         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3160         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3161         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3162         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3163         would make its way to the UI process by the time the layer tree commit is finished.
3164
3165         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3166         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3167         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3168         will fail because it asks for -_autofillContext too early.
3169
3170         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3171         is handled in the UI process.
3172
3173         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3174
3175         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3176         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3177         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3178         input session.
3179
3180         (-[AutofillTestView textInputHasAutofillContext]):
3181
3182         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3183
3184         * TestWebKitAPI/cocoa/TestWKWebView.h:
3185         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3186         (nextInputSessionChangeCount):
3187
3188         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3189         This includes changing the focused element from one to another.
3190
3191         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3192         (-[TestWKWebView didStartFormControlInteraction]):
3193         (-[TestWKWebView didEndFormControlInteraction]):
3194         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3195
3196         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3197         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3198         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3199         that doesn't require an input session to one that doesn't.
3200
3201 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3202
3203         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3204         <https://webkit.org/b/193676>
3205
3206         Reviewed by Alexey Proskuryakov.
3207
3208         * Scripts/webkitpy/style/checkers/cpp.py:
3209         (check_member_initialization_list):
3210         - Don't report missing whitespace around colon if the colon at
3211           the start of the line is formatted correctly.
3212         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3213         (WebKitStyleTest.test_member_initialization_list):
3214         - Add a test for a missing permutation of existing tests.
3215         - Add a test this false-positive.
3216         - Add blank lines between subtests to make them easier to read.
3217
3218 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3219
3220         [build.webkit.org] Unit-test failure after r237113
3221         https://bugs.webkit.org/show_bug.cgi?id=193669
3222
3223         Reviewed by Michael Catanzaro.
3224
3225         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3226         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3227         multiple or zero flags.
3228
3229 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3230
3231         Cache bytecode to disk
3232         https://bugs.webkit.org/show_bug.cgi?id=192782
3233         <rdar://problem/46084932>
3234
3235         Reviewed by Keith Miller.
3236
3237         Add test helper to execute bytecode-cache tests: it executes each test
3238         twice, the first with JSC_diskCachePath set to a temporary directory
3239         and second with JSC_forceDiskCache=true (in addition to the cache path)
3240         to guarantee that only the disk cache is being used and no new
3241         UnlinkedCodeBlocks are being created.
3242
3243         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3244         * Scripts/run-jsc-stress-tests:
3245
3246 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3247
3248         [css-logical] Implement flow-relative margin, padding and border shorthands
3249         https://bugs.webkit.org/show_bug.cgi?id=188697
3250
3251         Reviewed by Simon Fraser and Antti Koivisto.
3252
3253         * DumpRenderTree/TestOptions.cpp:
3254         (TestOptions::TestOptions):
3255         * DumpRenderTree/TestOptions.h:
3256         * DumpRenderTree/mac/DumpRenderTree.mm:
3257         (setWebPreferencesForTestOptions):
3258         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3259
3260         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3261         (JSONCSSPropertiesChecker.check_codegen_properties):
3262         Allow CSS property definitions to have a 'runtime-flag' parameter which
3263         disables the property when the specified runtime flag is disabled.
3264
3265 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3266
3267         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3268         https://bugs.webkit.org/show_bug.cgi?id=193643
3269
3270         Reviewed by Michael Catanzaro.
3271
3272         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3273         * wpe/jhbuild.modules: Ditto.
3274
3275 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3276
3277         [LFC][Floats] Take float top position into account when computing containing block height.
3278         https://bugs.webkit.org/show_bug.cgi?id=193655
3279
3280         Reviewed by Antti Koivisto.
3281
3282         * LayoutReloaded/misc/LFC-passing-tests.txt:
3283
3284 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3285
3286         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3287         <https://webkit.org/b/193645>
3288         <rdar://problem/47421574>
3289
3290         Reviewed by Alex Christensen.
3291
3292         - Now checks for local soft-linking of all frameworks that have
3293           their own *SoftLinking.{cpp,h,mm} files.
3294         - Changes softlink/uikit warning to softlink/framework.
3295
3296         * Scripts/webkitpy/style/checkers/cpp.py:
3297         (check_language):
3298         (CppChecker):
3299         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3300         (CppStyleTest):
3301
3302 2019-01-20  Saam Barati  <sbarati@apple.com>
3303
3304         Rollout r240210: It broke tests on iOS
3305         https://bugs.webkit.org/show_bug.cgi?id=193640
3306
3307         Unreviewed.
3308
3309         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3310         * Scripts/run-jsc-stress-tests:
3311
3312 2019-01-20  chris fleizach  <cfleizach@apple.com>
3313
3314         AX: Support returning relative frames for accessibility
3315         https://bugs.webkit.org/show_bug.cgi?id=193414
3316         <rdar://problem/47268501>
3317
3318         Reviewed by Zalan Bujtas.
3319
3320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3321         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3322         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3323         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3324         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3325         (WTR::attributesOfElement):
3326         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3327
3328 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3329
3330         Unreviewed, add my new email address
3331
3332         * Scripts/webkitpy/common/config/contributors.json:
3333
3334 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3335
3336         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3337         https://bugs.webkit.org/show_bug.cgi?id=193617
3338
3339         Reviewed by Antti Koivisto.
3340
3341         * LayoutReloaded/misc/LFC-passing-tests.txt:
3342
3343 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3344
3345         Unreviewed, rolling out r240209.
3346
3347         Broke GTK/WPE injected bundle
3348
3349         Reverted changeset:
3350
3351         "AX: Support returning relative frames for accessibility"
3352         https://bugs.webkit.org/show_bug.cgi?id=193414
3353         https://trac.webkit.org/changeset/240209
3354
3355 2019-01-12  Dan Bernstein  <mitz@apple.com>
3356
3357         [Cocoa] Avoid importing directly from subumbrella frameworks
3358         https://bugs.webkit.org/show_bug.cgi?id=186016
3359         <rdar://problem/40591038>
3360
3361         Reviewed by Sam Weinig.
3362
3363         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3364           LaunchServices header.
3365         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3366           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3367         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3368           when using SDKs earlier than 10.13.
3369         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3370           and OTHER_CPLUSPLUSFLAGS.
3371         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3372           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3373         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3374           LaunchServices header.
3375
3376 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3377
3378         Cache bytecode to disk
3379         https://bugs.webkit.org/show_bug.cgi?id=192782
3380         <rdar://problem/46084932>
3381
3382         Reviewed by Keith Miller.
3383
3384         Add test helper to execute bytecode-cache tests: it executes each test
3385         twice, the first with JSC_diskCachePath set to a temporary directory
3386         and second with JSC_forceDiskCache=true (in addition to the cache path)
3387         to guarantee that only the disk cache is being used and no new
3388         UnlinkedCodeBlocks are being created.
3389
3390         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3391         * Scripts/run-jsc-stress-tests:
3392
3393 2019-01-20  chris fleizach  <cfleizach@apple.com>
3394
3395         AX: Support returning relative frames for accessibility
3396         https://bugs.webkit.org/show_bug.cgi?id=193414
3397         <rdar://problem/47268501>
3398
3399         Reviewed by Zalan Bujtas.
3400
3401         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3402         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3403         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3404         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3405         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3406         (WTR::attributesOfElement):
3407         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3408
3409 2019-01-20  Antoine Quint  <graouts@apple.com>
3410
3411         Add a POINTER_EVENTS feature flag
3412         https://bugs.webkit.org/show_bug.cgi?id=193577
3413         <rdar://problem/47408511>
3414
3415         Unreviewed. Also enable Pointer Events for iosmac.
3416
3417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3418
3419 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3420
3421         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3422         https://bugs.webkit.org/show_bug.cgi?id=193613
3423
3424         Reviewed by Antti Koivisto.
3425
3426         * LayoutReloaded/misc/LFC-passing-tests.txt:
3427
3428 2019-01-19  Antoine Quint  <graouts@apple.com>
3429
3430         Add a POINTER_EVENTS feature flag
3431         https://bugs.webkit.org/show_bug.cgi?id=193577
3432
3433         Reviewed by Dean Jackson.
3434
3435         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3436
3437 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3438
3439         Disable the run-jsc-stress-test remote host key check [second round].
3440         https://bugs.webkit.org/show_bug.cgi?id=192988
3441
3442         Reviewed by Dewei Zhu.
3443
3444         * Scripts/run-jsc-stress-tests:
3445
3446 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3449         https://bugs.webkit.org/show_bug.cgi?id=193597
3450
3451         Reviewed by Lucas Forschler.
3452
3453         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3454
3455 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3456
3457         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3458         https://bugs.webkit.org/show_bug.cgi?id=193595
3459
3460         Reviewed by Lucas Forschler.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3463         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3464         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3465
3466 2019-01-18  Chris Dumez  <cdumez@apple.com>
3467
3468         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3469         https://bugs.webkit.org/show_bug.cgi?id=193588
3470         <rdar://problem/47131566>
3471
3472         Reviewed by Alex Christensen.
3473
3474         Add layout test coverage.
3475
3476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3477
3478 2019-01-18  Jer Noble  <jer.noble@apple.com>
3479
3480         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3481         https://bugs.webkit.org/show_bug.cgi?id=189553
3482
3483         Reviewed by Tim Horton.
3484
3485         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3486
3487         * ContentExtensionTester/Configurations/Base.xcconfig:
3488         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3489         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3490         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3491         * ImageDiff/cg/Configurations/Base.xcconfig:
3492         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3493         * MiniBrowser/Configurations/Base.xcconfig:
3494         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3495         * MobileMiniBrowser/Configurations/Base.xcconfig:
3496         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3497         * Scripts/webkitpy/style/checker.py:
3498         (_all_categories):
3499         (FileType):
3500         (CheckerDispatcher._file_type):
3501         (CheckerDispatcher._create_checker):
3502         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3503         (SDKVariantChecker):
3504         (SDKVariantChecker.__init__):
3505         (SDKVariantChecker.check):
3506         * TestWebKitAPI/Configurations/Base.xcconfig:
3507         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3508         * WebEditingTester/Configurations/Base.xcconfig:
3509         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3510         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3511         * WebKitTestRunner/Configurations/Base.xcconfig:
3512         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3513         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3514         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3515
3516 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3517
3518         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3519         <https://webkit.org/b/193568>
3520         <rdar://problem/47381130>
3521
3522         Reviewed by Alex Christensen.
3523
3524         Make sure no one re-introduces UIKit soft-linking by adding a
3525         style rule.
3526
3527         * Scripts/webkitpy/style/checkers/cpp.py:
3528         (check_language): Add softlink/uikit check.
3529         (CppChecker): Enable softlink/uikit check.
3530         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3531         (CppStyleTest): Add test for softlink/uikit.
3532
3533 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3534
3535         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3536         https://bugs.webkit.org/show_bug.cgi?id=193584
3537
3538         Change "-dev" to "-devel".
3539
3540         Reviewed by Michael Catanzaro.
3541
3542         * gtk/install-dependencies:
3543
3544 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3545
3546         webkitpy: Add iPhone and iPad ports
3547         https://bugs.webkit.org/show_bug.cgi?id=193537
3548         <rdar://problem/47353390>
3549
3550         Reviewed by Lucas Forschler.
3551
3552         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3553         ports. Note that this separation is optional, the --ios-simulator command remains.
3554
3555         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3556         (RunTest.test_device_type_test_division): Drive-by fix.
3557         (RunTest.test_device_type_specific_listing): Ditto.
3558         (RunTest.test_ipad_test_division):
3559         (RunTest):
3560         (RunTest.test_ipad_listing):
3561         * Scripts/webkitpy/port/factory.py:
3562         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3563         (PortFactory):
3564         * Scripts/webkitpy/port/ios_simulator.py:
3565         (IPhoneSimulatorPort):
3566         (IPadSimulatorPort):
3567
3568 2019-01-18  Chris Dumez  <cdumez@apple.com>
3569
3570         Regression(PSON) Scroll position is not always restored properly when navigating back
3571         https://bugs.webkit.org/show_bug.cgi?id=193578
3572         <rdar://problem/47386331>
3573
3574         Reviewed by Tim Horton.
3575
3576         Add API test coverage.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3579
3580 2019-01-18  Youenn Fablet  <youenn@apple.com>
3581
3582         Add a new SPI to request for cache storage quota increase
3583         https://bugs.webkit.org/show_bug.cgi?id=193323
3584
3585         Reviewed by Alex Christensen.
3586
3587         Implement WebsiteDataStore quota delegate to handle quota requests.
3588         By default, do not update quota.
3589         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3590
3591         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3593         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3595         * WebKitTestRunner/TestController.cpp:
3596         (WTR::TestController::allowCacheStorageQuotaIncrease):
3597         * WebKitTestRunner/TestController.h:
3598         * WebKitTestRunner/TestInvocation.cpp:
3599         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3600         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3601         (-[CacheStorageQuotaManager init]):
3602         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3603         (WTR::initializeWebViewConfiguration):
3604         (WTR::TestController::cocoaResetStateToConsistentValues):
3605         (WTR::TestController::allowCacheStorageQuotaIncrease):
3606
3607 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3608
3609         [ews-build] Pass owner to the triggered builds
3610         https://bugs.webkit.org/show_bug.cgi?id=193574
3611
3612         Reviewed by Lucas Forschler.
3613
3614         * BuildSlaveSupport/ews-build/factories.py:
3615         (BuildFactory.propertiesToPassToTriggers):
3616
3617 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-app] Send patch author as a build property
3620         https://bugs.webkit.org/show_bug.cgi?id=193560
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3625         (BugzillaPatchFetcher.fetch):
3626
3627 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3628
3629         webkitpy: Implement device type specific expected results (Follow-up fix)
3630         https://bugs.webkit.org/show_bug.cgi?id=192162
3631         <rdar://problem/46345449>
3632
3633         Unreviewed infrastructure fix.
3634
3635         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3636         (Manager.run): Don't boot a device if no tests are available to run on it.
3637
3638 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3639
3640         webkitpy: Implement device type specific expected results (Follow-up fix)
3641         https://bugs.webkit.org/show_bug.cgi?id=192162
3642         <rdar://problem/46345449>
3643
3644         Unreviewed infrastructure fix.
3645
3646         * Scripts/webkitpy/api_tests/manager.py:
3647         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3648
3649 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3650
3651         webkitpy: Implement device type specific expected results (Part 2)
3652         https://bugs.webkit.org/show_bug.cgi?id=192162
3653         <rdar://problem/46345449>
3654
3655         Rubber-stamped by Aakash Jain.
3656
3657         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3658         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3659         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3660
3661         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3662         (LayoutTestFinder.find_tests): Pass device_type through.
3663         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3664         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3665         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3666         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3667         (Manager._collect_tests): Pass device type to test finder.
3668         (Manager._needs_web_platform_test):
3669         (Manager._prepare_lists): Index _expectations by device type.
3670         (Manager._test_input_for_file):
3671         (Manager._test_is_slow): Ditto.
3672         (Manager._test_should_dump_jsconsolelog_in_stderr):
3673         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3674         (Manager._get_test_inputs):
3675         (Manager._update_worker_count):
3676         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3677         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3678         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3679         the one which runs the test.
3680         (Manager._run_test_subset):
3681         (Manager._run_tests): Index _expectations by current_device_type.
3682         (Manager._print_expectation_line_for_test): Ditto.
3683         (Manager._print_expectations_for_subset): Ditto.
3684         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3685         Unlike run, this function will behave the same regardless of what devices are available.
3686         (Manager._custom_device_for_test): Deleted.
3687         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3688         (ManagerTest.test_uses_custom_device): Deleted.
3689         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3690         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3691         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3692         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3693         all of the expectations.
3694         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3695         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3696         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3697         (TestExpectations.__init__): Allow device_type to be passed through.
3698         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3699         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3700         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3701         (summarize_results):
3702         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3703         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3704         a test ran with, one must check all expectations to find the first non-skip expectation.
3705         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3706         (RunTest.test_device_type_test_division):
3707         (RunTest):
3708         (RunTest.test_device_type_specific_listing):
3709         * Scripts/webkitpy/port/base.py:
3710         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3711         (Port.supported_device_types): The result of this function will change based on what devices are available.
3712         * Scripts/webkitpy/port/device_port.py:
3713         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3714         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3715         can be used.
3716         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3717         any, or the DEFAULT_DEVICE_TYPES of the port.
3718         * Scripts/webkitpy/port/ios.py:
3719         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3720         * Scripts/webkitpy/port/ios_simulator.py:
3721         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3722         * Scripts/webkitpy/port/watch.py:
3723         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3724         * Scripts/webkitpy/port/watch_simulator.py:
3725         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3726         * Scripts/webkitpy/xcode/device_type.py:
3727         (DeviceType):
3728         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3729
3730 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3731
3732         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3733         https://bugs.webkit.org/show_bug.cgi?id=193575
3734
3735         Reviewed by Michael Catanzaro.
3736
3737         Allow the script to run without explicit port argument because
3738         it's specific to the WPE port anyway.
3739
3740         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3741         and simplify the rest of the code accordingly.
3742
3743 2019-01-18  Charlie Turner  <cturner@igalia.com>
3744
3745         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3746         https://bugs.webkit.org/show_bug.cgi?id=192229
3747
3748         Reviewed by Xabier Rodriguez-Calvar.
3749
3750         * MiniBrowser/wpe/main.cpp:
3751         (main): Enable encrypted-media by default.
3752
3753 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3754
3755         [Flatpak] Missing KeyboardInterrupt exception handler
3756         https://bugs.webkit.org/show_bug.cgi?id=193570
3757
3758         Reviewed by Michael Catanzaro.
3759
3760         * flatpak/flatpakutils.py:
3761         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3762
3763 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3764
3765         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3766         https://bugs.webkit.org/show_bug.cgi?id=193564
3767
3768         Reviewed by Antti Koivisto.
3769
3770         * LayoutReloaded/misc/LFC-passing-tests.txt:
3771
3772 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3773
3774         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3775         https://bugs.webkit.org/show_bug.cgi?id=193562
3776
3777         Reviewed by Antti Koivisto.
3778
3779         * LayoutReloaded/misc/LFC-passing-tests.txt:
3780
3781 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3782
3783         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3784         https://bugs.webkit.org/show_bug.cgi?id=193555
3785
3786         Reviewed by Antti Koivisto.
3787
3788         * LayoutReloaded/misc/LFC-passing-tests.txt:
3789
3790 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3791
3792         [WPE] Add Qt extension
3793         https://bugs.webkit.org/show_bug.cgi?id=191464
3794
3795         Reviewed by Carlos Garcia Campos.
3796
3797         MiniBrowser and API tests for the WPE Qt API. To run the
3798         MiniBrowser a new script is introduced. Example invocation:
3799
3800         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3801
3802         Also note-worthy is the introduction of the python2-subprocess32
3803         dependency to run the GLib API tests.
3804
3805         * MiniBrowser/wpe/CMakeLists.txt:
3806         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3807         * MiniBrowser/wpe/qt/main.cpp: Added.
3808         (main):
3809         * MiniBrowser/wpe/qt/main.qml: Added.
3810         * MiniBrowser/wpe/qt/qml.qrc: Added.
3811         * Scripts/run-gtk-tests:
3812         (GtkTestRunner.is_google_test):
3813         (GtkTestRunner):
3814         (GtkTestRunner.is_qt_test):
3815         * Scripts/run-qt-wpe-minibrowser: Added.
3816         * Scripts/run-wpe-tests:
3817         (WPETestRunner):
3818         (WPETestRunner.is_google_test):
3819         (WPETestRunner.is_qt_test):
3820         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3821         (TestLoad::main):
3822         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3823         (TestLoadHtml::main):
3824         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3825         (TestLoadRequest::main):
3826         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3827         (TestRunJavaScript::main):
3828         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3829         (waitForSignal):
3830         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3831         (LoadSpy::LoadSpy):
3832         (LoadSpy::~LoadSpy):
3833         (LoadSpy::onLoadingChanged):
3834         (LoadStartedCatcher::LoadStartedCatcher):
3835         (LoadStartedCatcher::~LoadStartedCatcher):
3836         (LoadStartedCatcher::onLoadingChanged):
3837         (waitForLoadSucceeded):
3838         (waitForLoadFailed):
3839         * TestWebKitAPI/glib/CMakeLists.txt:
3840         * flatpak/flatpakutils.py:
3841         (WebkitFlatpak.load_from_args):
3842         (WebkitFlatpak.__init__):
3843         (WebkitFlatpak.clean_args):
3844         (WebkitFlatpak.run_in_sandbox):
3845         * flatpak/org.webkit.CommonModules.yaml:
3846         * flatpak/org.webkit.WPE.yaml:
3847         * flatpak/org.webkit.WPEModules.yaml:
3848         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3849         * flatpak/org.webkit.WebKit.yaml:
3850         * glib/api_test_runner.py:
3851         (TestRunner._run_test_qt):
3852         (TestRunner.is_qt_test):
3853         (TestRunner._run_test):
3854
3855 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3856
3857         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3858         https://bugs.webkit.org/show_bug.cgi?id=193494
3859         <rdar://problem/46859627>
3860
3861         Reviewed by Simon Fraser and Tim Horton.
3862
3863         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3864         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3865
3866         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3867         (WTR::UIScriptController::contentOffsetX const):
3868         (WTR::UIScriptController::contentOffsetY const):
3869         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3870         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3871         (WTR::UIScriptController::contentOffsetX const):
3872         (WTR::UIScriptController::contentOffsetY const):
3873         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3874
3875         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3876
3877         * WebKitTestRunner/TestController.cpp:
3878         (WTR::updateTestOptionsFromTestHeader):
3879         * WebKitTestRunner/TestOptions.h:
3880         (WTR::TestOptions::hasSameInitializationOptions const):
3881         * WebKitTestRunner/ios/TestControllerIOS.mm:
3882         (WTR::TestController::platformResetStateToConsistentValues):
3883         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3884         (WTR::UIScriptController::contentOffsetX const):
3885         (WTR::UIScriptController::contentOffsetY const):
3886
3887 2019-01-17  Truitt Savell  <tsavell@apple.com>
3888
3889         Unreviewed, rolling out r240124.
3890
3891         This commit broke an internal build.
3892
3893         Reverted changeset:
3894
3895         "SDK_VARIANT build destinations should be separate from non-
3896         SDK_VARIANT builds"
3897         https://bugs.webkit.org/show_bug.cgi?id=189553
3898         https://trac.webkit.org/changeset/240124
3899
3900 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3901
3902         Fix string concatenation API test after r239920
3903         https://bugs.webkit.org/show_bug.cgi?id=193551
3904         <rdar://problem/47359304>
3905
3906         Reviewed by Youenn Fablet.
3907
3908         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3909         (TestWebKitAPI::TEST):
3910         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3911         in WebKit's build configuration like it apparently is on Linux.
3912
3913 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3914
3915         [ews-build] validate-patch should handle the case when bug_id is None
3916         https://bugs.webkit.org/show_bug.cgi?id=193547
3917
3918         Reviewed by Lucas Forschler.
3919
3920         * BuildSlaveSupport/ews-build/steps.py:
3921         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3922         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3923
3924 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3925
3926         [ews-build] Add patch author information in build
3927         https://bugs.webkit.org/show_bug.cgi?id=193465
3928
3929         Reviewed by Lucas Forschler.
3930
3931         * BuildSlaveSupport/ews-build/steps.py:
3932         (ValidatePatch._is_patch_obsolete):
3933
3934 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3935
3936         [ews-build] Pass bug_id to the triggered builds
3937         https://bugs.webkit.org/show_bug.cgi?id=193548
3938
3939         Reviewed by Lucas Forschler.
3940
3941         * BuildSlaveSupport/ews-build/factories.py:
3942         (BuildFactory.propertiesToPassToTriggers):
3943
3944 2019-01-17  Jer Noble  <jer.noble@apple.com>
3945
3946         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3947         https://bugs.webkit.org/show_bug.cgi?id=189553
3948
3949         Reviewed by Tim Horton.
3950
3951         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3952
3953         * ContentExtensionTester/Configurations/Base.xcconfig:
3954         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3955         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3956         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3957         * ImageDiff/cg/Configurations/Base.xcconfig:
3958         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3959         * MiniBrowser/Configurations/Base.xcconfig:
3960         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3961         * MobileMiniBrowser/Configurations/Base.xcconfig:
3962         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3963         * Scripts/webkitpy/style/checker.py:
3964         (_all_categories):
3965         (FileType):
3966         (CheckerDispatcher._file_type):
3967         (CheckerDispatcher._create_checker):
3968         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3969         (SDKVariantChecker):
3970         (SDKVariantChecker.__init__):
3971         (SDKVariantChecker.check):
3972         * TestWebKitAPI/Configurations/Base.xcconfig:
3973         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3974         * WebEditingTester/Configurations/Base.xcconfig:
3975         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3976         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3977         * WebKitTestRunner/Configurations/Base.xcconfig:
3978         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3979         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3980         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3981
3982 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3983
3984         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3985         https://bugs.webkit.org/show_bug.cgi?id=193534
3986
3987         Reviewed by Antti Koivisto.
3988
3989         * LayoutReloaded/misc/LFC-passing-tests.txt:
3990
3991 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3992
3993         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3994         https://bugs.webkit.org/show_bug.cgi?id=193528
3995
3996         Reviewed by Antti Koivisto.
3997
3998         * LayoutReloaded/misc/LFC-passing-tests.txt:
3999
4000 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4001
4002         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4003         https://bugs.webkit.org/show_bug.cgi?id=193520
4004
4005         Reviewed by Antti Koivisto.
4006
4007         * LayoutReloaded/misc/LFC-passing-tests.txt:
4008
4009 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4010
4011         [ews-build] unapply-patch step should not update source
4012         https://bugs.webkit.org/show_bug.cgi?id=193234
4013
4014         Reviewed by Lucas Forschler.
4015
4016         * BuildSlaveSupport/ews-build/steps.py:
4017         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4018         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4019
4020 2019-01-16  Youenn Fablet  <youenn@apple.com>
4021
4022         Add a new SPI for controlling getUserMedia
4023         https://bugs.webkit.org/show_bug.cgi?id=192793
4024
4025         Reviewed by Eric Carlson.
4026
4027         * MiniBrowser/mac/WK2BrowserWindowController.m:
4028         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4029         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4030         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4031         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4032         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4033         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4034         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4035         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4036         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4037         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4038         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4039         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4040         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4041         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4042
4043 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4044
4045         [LFC][BFC] Inflow non-replaced used width should not be negative.
4046         https://bugs.webkit.org/show_bug.cgi?id=193495
4047
4048         Reviewed by Antti Koivisto.
4049
4050         * LayoutReloaded/misc/LFC-passing-tests.txt:
4051
4052 2019-01-16  Chris Dumez  <cdumez@apple.com>
4053
4054         Regression(PSON) View becomes blank after click a cross-site download link
4055         https://bugs.webkit.org/show_bug.cgi?id=193361
4056         <rdar://problem/47099573>
4057
4058         Reviewed by Geoffrey Garen.
4059
4060         Add API test coverage.
4061
4062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4063         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4064
4065 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4066
4067         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4068         https://bugs.webkit.org/show_bug.cgi?id=193470
4069
4070         Reviewed by Antti Koivisto.
4071
4072         * LayoutReloaded/misc/LFC-passing-tests.txt:
4073
4074 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4075
4076         [LFC] Adjust margin box verification.
4077         https://bugs.webkit.org/show_bug.cgi?id=193482
4078
4079         Reviewed by Antti Koivisto.
4080
4081         * LayoutReloaded/misc/LFC-passing-tests.txt:
4082
4083 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4084
4085         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4086         https://bugs.webkit.org/show_bug.cgi?id=193451
4087
4088         Reviewed by Geoffrey Garen.
4089
4090         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4091         (TEST):
4092         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4093         (runWebsiteDataStoreCustomPaths):
4094
4095 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4096
4097         webkitpy: Support boolean simctl isAvailable
4098         https://bugs.webkit.org/show_bug.cgi?id=193472
4099         <rdar://problem/47296150>
4100
4101         Reviewed by Ryosuke Niwa.
4102
4103         * Scripts/webkitpy/xcode/simulated_device.py:
4104         (SimulatedDeviceManager._create_runtimes):
4105         (SimulatedDeviceManager._create_device_with_runtime):
4106
4107 2019-01-15  Chris Dumez  <cdumez@apple.com>
4108
4109         Unreviewed, rolling out r239993, r239995, r239997, and
4110         r239999.
4111
4112         Caused assertions under
4113         ViewGestureController::disconnectFromProcess()
4114
4115         Reverted changesets:
4116
4117         "Regression(PSON) View becomes blank after click a cross-site
4118         download link"
4119         https://bugs.webkit.org/show_bug.cgi?id=193361
4120         https://trac.webkit.org/changeset/239993
4121
4122         "Unreviewed iOS build fix after r239993."
4123         https://trac.webkit.org/changeset/239995
4124
4125         "Fix iOS build after r239993"
4126         https://bugs.webkit.org/show_bug.cgi?id=193361
4127         https://trac.webkit.org/changeset/239997
4128
4129         "Unreviewed, revert part of r239997 as it is not needed to fix
4130         the build."
4131         https://trac.webkit.org/changeset/239999
4132
4133 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4134
4135         Cannot tab out of WKWebView on macOS
4136         https://bugs.webkit.org/show_bug.cgi?id=161448
4137         <rdar://problem/28100085>
4138
4139         Reviewed by Dean Jackson.
4140
4141         Add a test that tabbing into and out of WKWebView works correctly.
4142
4143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4144         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4145         (WebKit2_CommandBackForwardTest::SetUp):
4146         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4147         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4148         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4149         (-[FocusableView canBecomeKeyView]):
4150         (TEST):
4151         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4152         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4153         (-[OffscreenWindow initWithSize:]):
4154         (-[OffscreenWindow isKeyWindow]):
4155         (-[OffscreenWindow isVisible]):
4156         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4157         (TestWebKitAPI::PlatformWebView::initialize):
4158         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4159         (-[ActiveOffscreenWindow isVisible]): Deleted.
4160         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4161
4162 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4163
4164         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4165         https://bugs.webkit.org/show_bug.cgi?id=193459
4166
4167         Reviewed by Mark Lam.
4168
4169         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4170         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4171
4172 2019-01-15  Chris Dumez  <cdumez@apple.com>
4173
4174         Regression(PSON) View becomes blank after click a cross-site download link
4175         https://bugs.webkit.org/show_bug.cgi?id=193361
4176         <rdar://problem/47099573>
4177
4178         Reviewed by Geoff Garen.
4179
4180         Add API test coverage.
4181
4182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4183         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4184
4185 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4186
4187         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4188         https://bugs.webkit.org/show_bug.cgi?id=193448
4189
4190         Reviewed by Antti Koivisto.
4191
4192         * LayoutReloaded/misc/LFC-passing-tests.txt:
4193
4194 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4195
4196         webkitpy: Implement device type specific expected results (Part 1)
4197         https://bugs.webkit.org/show_bug.cgi?id=192162
4198
4199         Reviewed by Lucas Forschler.
4200
4201         Device type specific expected results covers two related ideas. The first (covered by this change)
4202         is where to search for -expected.* files. The second is which tests to run based on the
4203         TestExpectations.txt file.
4204
4205         After this change, the baseline search path will be determined by the type of device running a
4206         test. Device type will be passed into any function which picks a file based on the baseline search
4207         path.
4208
4209         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4210         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4211         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4212         (Manager.run): Print baseline search path for each round of devices.
4213         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4214         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4215         (SingleTestRunner._expected_driver_output): Ditto.
4216         (SingleTestRunner._driver_input): Ditto.
4217         * Scripts/webkitpy/layout_tests/views/printing.py:
4218         (Printer.print_config): Move printing of baseline search path to a separate function.
4219         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4220         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4221         (Testprinter.test_print_config):
4222         (Testprinter.test_print_baseline_search_path):
4223         * Scripts/webkitpy/port/base.py:
4224         (Port.baseline_search_path): Pass device_type through.
4225         (Port._expected_baselines_for_suffixes): Ditto.
4226         (Port.expected_baselines): Ditto.
4227         (Port.expected_filename): Ditto.
4228         (Port.expected_checksum): Ditto.
4229         (Port.expected_image): Ditto.
4230         (Port.expected_audio): Ditto.
4231         (Port.expected_text): Ditto.
4232         (Port.reference_files): Ditto.
4233         (Port.tests): Ditto.
4234         (Port._expanded_paths): Ditto.
4235         (Port.skipped_layout_tests): Ditto.
4236         (Port.expectations_dict): Ditto.
4237         (Port._port_specific_expectations_files): Ditto.
4238         (Port.expectations_files): Ditto.
4239         (Port.test_search_path): Ditto.
4240         (Port._tests_for_other_platforms): Ditto.
4241         * Scripts/webkitpy/port/base_unittest.py:
4242         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4243         (PortTest.test_nonexistant_expectations): Ditto.
4244         (test_ref_tests_platform_directory): Ditto.
4245         * Scripts/webkitpy/port/darwin.py:
4246         (DarwinPort._port_specific_expectations_files): Accept device_type.
4247         * Scripts/webkitpy/port/driver.py:
4248         (DriverProxy):
4249         (DriverProxy.host): Expose _target_host for device_type information.
4250         * Scripts/webkitpy/port/gtk.py:
4251         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4252         * Scripts/webkitpy/port/ios.py:
4253         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4254         * Scripts/webkitpy/port/mac.py:
4255         (MacPort. default_baseline_search_path): Ditto.
4256         * Scripts/webkitpy/port/port_testcase.py:
4257         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4258         * Scripts/webkitpy/port/test.py:
4259         * Scripts/webkitpy/port/watch.py:
4260         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4261         * Scripts/webkitpy/port/win.py:
4262         (WinPort.test_search_path): Accept, but do not use, device_type.
4263         * Scripts/webkitpy/port/wpe.py:
4264         (WPEPort._port_specific_expectations_files): Ditto.
4265         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4266         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4267
4268 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4269
4270         [LFC] Use the containing block's padding box to position out-of-flow elements.
4271         https://bugs.webkit.org/show_bug.cgi?id=193431
4272
4273         Reviewed by Antti Koivisto.
4274
4275         * LayoutReloaded/misc/LFC-passing-tests.txt:
4276
4277 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4278
4279         Move a test implementation file that got misplaced in the Xcode project
4280
4281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4282
4283 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4284
4285         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4286         r239913, and r239914.
4287         https://bugs.webkit.org/show_bug.cgi?id=193407
4288
4289         These revisions caused an internal failure (Requested by
4290         Truitt on #webkit).
4291
4292         Reverted changesets:
4293
4294         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4295         https://bugs.webkit.org/show_bug.cgi?id=186016
4296         https://trac.webkit.org/changeset/239901
4297
4298         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4299         https://trac.webkit.org/changeset/239909
4300
4301         "Tried to fix the build."
4302         https://trac.webkit.org/changeset/239910
4303
4304         "Fixed iOS builds after r239910."
4305         https://trac.webkit.org/changeset/239912
4306
4307         "More build fixing."
4308         https://trac.webkit.org/changeset/239913
4309
4310         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4311         https://trac.webkit.org/changeset/239914
4312
4313 2019-01-14  Mark Lam  <mark.lam@apple.com>
4314
4315         Re-enable ability to build --cloop builds.
4316         https://bugs.webkit.org/show_bug.cgi?id=192955
4317         <rdar://problem/46882363>
4318
4319         Reviewed by Saam barati and Keith Miller.
4320
4321         The --cloop build option was being ignored this whole time since r236381.
4322         This patch makes it possible to build CLoop builds again.
4323
4324         * Scripts/build-jsc:
4325         * Scripts/webkitperl/FeatureList.pm:
4326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4327
4328 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4329
4330         webkitpy: Expose device_type from host-like objects
4331         https://bugs.webkit.org/show_bug.cgi?id=193406
4332         <rdar://problem/47262305>
4333
4334         Reviewed by Lucas Forschler.
4335
4336      &n