[ews-build] unapply-patch step should not update source
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] unapply-patch step should not update source
4         https://bugs.webkit.org/show_bug.cgi?id=193234
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
10         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
11
12 2019-01-16  Youenn Fablet  <youenn@apple.com>
13
14         Add a new SPI for controlling getUserMedia
15         https://bugs.webkit.org/show_bug.cgi?id=192793
16
17         Reviewed by Eric Carlson.
18
19         * MiniBrowser/mac/WK2BrowserWindowController.m:
20         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
21         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
22         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
23         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
24         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
25         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
26         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
27         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
28         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
29         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
30         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
31         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
32         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
33         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
34
35 2019-01-16  Zalan Bujtas  <zalan@apple.com>
36
37         [LFC][BFC] Inflow non-replaced used width should not be negative.
38         https://bugs.webkit.org/show_bug.cgi?id=193495
39
40         Reviewed by Antti Koivisto.
41
42         * LayoutReloaded/misc/LFC-passing-tests.txt:
43
44 2019-01-16  Chris Dumez  <cdumez@apple.com>
45
46         Regression(PSON) View becomes blank after click a cross-site download link
47         https://bugs.webkit.org/show_bug.cgi?id=193361
48         <rdar://problem/47099573>
49
50         Reviewed by Geoffrey Garen.
51
52         Add API test coverage.
53
54         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
55         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
56
57 2019-01-16  Zalan Bujtas  <zalan@apple.com>
58
59         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
60         https://bugs.webkit.org/show_bug.cgi?id=193470
61
62         Reviewed by Antti Koivisto.
63
64         * LayoutReloaded/misc/LFC-passing-tests.txt:
65
66 2019-01-16  Zalan Bujtas  <zalan@apple.com>
67
68         [LFC] Adjust margin box verification.
69         https://bugs.webkit.org/show_bug.cgi?id=193482
70
71         Reviewed by Antti Koivisto.
72
73         * LayoutReloaded/misc/LFC-passing-tests.txt:
74
75 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
76
77         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
78         https://bugs.webkit.org/show_bug.cgi?id=193451
79
80         Reviewed by Geoffrey Garen.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
83         (TEST):
84         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
85         (runWebsiteDataStoreCustomPaths):
86
87 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
88
89         webkitpy: Support boolean simctl isAvailable
90         https://bugs.webkit.org/show_bug.cgi?id=193472
91         <rdar://problem/47296150>
92
93         Reviewed by Ryosuke Niwa.
94
95         * Scripts/webkitpy/xcode/simulated_device.py:
96         (SimulatedDeviceManager._create_runtimes):
97         (SimulatedDeviceManager._create_device_with_runtime):
98
99 2019-01-15  Chris Dumez  <cdumez@apple.com>
100
101         Unreviewed, rolling out r239993, r239995, r239997, and
102         r239999.
103
104         Caused assertions under
105         ViewGestureController::disconnectFromProcess()
106
107         Reverted changesets:
108
109         "Regression(PSON) View becomes blank after click a cross-site
110         download link"
111         https://bugs.webkit.org/show_bug.cgi?id=193361
112         https://trac.webkit.org/changeset/239993
113
114         "Unreviewed iOS build fix after r239993."
115         https://trac.webkit.org/changeset/239995
116
117         "Fix iOS build after r239993"
118         https://bugs.webkit.org/show_bug.cgi?id=193361
119         https://trac.webkit.org/changeset/239997
120
121         "Unreviewed, revert part of r239997 as it is not needed to fix
122         the build."
123         https://trac.webkit.org/changeset/239999
124
125 2019-01-15  Tim Horton  <timothy_horton@apple.com>
126
127         Cannot tab out of WKWebView on macOS
128         https://bugs.webkit.org/show_bug.cgi?id=161448
129         <rdar://problem/28100085>
130
131         Reviewed by Dean Jackson.
132
133         Add a test that tabbing into and out of WKWebView works correctly.
134
135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
136         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
137         (WebKit2_CommandBackForwardTest::SetUp):
138         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
139         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
140         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
141         (-[FocusableView canBecomeKeyView]):
142         (TEST):
143         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
144         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
145         (-[OffscreenWindow initWithSize:]):
146         (-[OffscreenWindow isKeyWindow]):
147         (-[OffscreenWindow isVisible]):
148         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
149         (TestWebKitAPI::PlatformWebView::initialize):
150         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
151         (-[ActiveOffscreenWindow isVisible]): Deleted.
152         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
153
154 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
155
156         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
157         https://bugs.webkit.org/show_bug.cgi?id=193459
158
159         Reviewed by Mark Lam.
160
161         * BuildSlaveSupport/build.webkit.org-config/steps.py:
162         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
163
164 2019-01-15  Chris Dumez  <cdumez@apple.com>
165
166         Regression(PSON) View becomes blank after click a cross-site download link
167         https://bugs.webkit.org/show_bug.cgi?id=193361
168         <rdar://problem/47099573>
169
170         Reviewed by Geoff Garen.
171
172         Add API test coverage.
173
174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
175         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
176
177 2019-01-15  Zalan Bujtas  <zalan@apple.com>
178
179         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
180         https://bugs.webkit.org/show_bug.cgi?id=193448
181
182         Reviewed by Antti Koivisto.
183
184         * LayoutReloaded/misc/LFC-passing-tests.txt:
185
186 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
187
188         webkitpy: Implement device type specific expected results (Part 1)
189         https://bugs.webkit.org/show_bug.cgi?id=192162
190
191         Reviewed by Lucas Forschler.
192
193         Device type specific expected results covers two related ideas. The first (covered by this change)
194         is where to search for -expected.* files. The second is which tests to run based on the
195         TestExpectations.txt file.
196
197         After this change, the baseline search path will be determined by the type of device running a
198         test. Device type will be passed into any function which picks a file based on the baseline search
199         path.
200
201         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
202         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
203         * Scripts/webkitpy/layout_tests/controllers/manager.py:
204         (Manager.run): Print baseline search path for each round of devices.
205         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
206         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
207         (SingleTestRunner._expected_driver_output): Ditto.
208         (SingleTestRunner._driver_input): Ditto.
209         * Scripts/webkitpy/layout_tests/views/printing.py:
210         (Printer.print_config): Move printing of baseline search path to a separate function.
211         (Printer.print_baseline_search_path): Moved from Printer.print_config.
212         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
213         (Testprinter.test_print_config):
214         (Testprinter.test_print_baseline_search_path):
215         * Scripts/webkitpy/port/base.py:
216         (Port.baseline_search_path): Pass device_type through.
217         (Port._expected_baselines_for_suffixes): Ditto.
218         (Port.expected_baselines): Ditto.
219         (Port.expected_filename): Ditto.
220         (Port.expected_checksum): Ditto.
221         (Port.expected_image): Ditto.
222         (Port.expected_audio): Ditto.
223         (Port.expected_text): Ditto.
224         (Port.reference_files): Ditto.
225         (Port.tests): Ditto.
226         (Port._expanded_paths): Ditto.
227         (Port.skipped_layout_tests): Ditto.
228         (Port.expectations_dict): Ditto.
229         (Port._port_specific_expectations_files): Ditto.
230         (Port.expectations_files): Ditto.
231         (Port.test_search_path): Ditto.
232         (Port._tests_for_other_platforms): Ditto.
233         * Scripts/webkitpy/port/base_unittest.py:
234         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
235         (PortTest.test_nonexistant_expectations): Ditto.
236         (test_ref_tests_platform_directory): Ditto.
237         * Scripts/webkitpy/port/darwin.py:
238         (DarwinPort._port_specific_expectations_files): Accept device_type.
239         * Scripts/webkitpy/port/driver.py:
240         (DriverProxy):
241         (DriverProxy.host): Expose _target_host for device_type information.
242         * Scripts/webkitpy/port/gtk.py:
243         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
244         * Scripts/webkitpy/port/ios.py:
245         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
246         * Scripts/webkitpy/port/mac.py:
247         (MacPort. default_baseline_search_path): Ditto.
248         * Scripts/webkitpy/port/port_testcase.py:
249         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
250         * Scripts/webkitpy/port/test.py:
251         * Scripts/webkitpy/port/watch.py:
252         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
253         * Scripts/webkitpy/port/win.py:
254         (WinPort.test_search_path): Accept, but do not use, device_type.
255         * Scripts/webkitpy/port/wpe.py:
256         (WPEPort._port_specific_expectations_files): Ditto.
257         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
258         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
259
260 2019-01-15  Zalan Bujtas  <zalan@apple.com>
261
262         [LFC] Use the containing block's padding box to position out-of-flow elements.
263         https://bugs.webkit.org/show_bug.cgi?id=193431
264
265         Reviewed by Antti Koivisto.
266
267         * LayoutReloaded/misc/LFC-passing-tests.txt:
268
269 2019-01-14  Tim Horton  <timothy_horton@apple.com>
270
271         Move a test implementation file that got misplaced in the Xcode project
272
273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274
275 2019-01-14  Commit Queue  <commit-queue@webkit.org>
276
277         Unreviewed, rolling out r239901, r239909, r239910, r239912,
278         r239913, and r239914.
279         https://bugs.webkit.org/show_bug.cgi?id=193407
280
281         These revisions caused an internal failure (Requested by
282         Truitt on #webkit).
283
284         Reverted changesets:
285
286         "[Cocoa] Avoid importing directly from subumbrella frameworks"
287         https://bugs.webkit.org/show_bug.cgi?id=186016
288         https://trac.webkit.org/changeset/239901
289
290         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
291         https://trac.webkit.org/changeset/239909
292
293         "Tried to fix the build."
294         https://trac.webkit.org/changeset/239910
295
296         "Fixed iOS builds after r239910."
297         https://trac.webkit.org/changeset/239912
298
299         "More build fixing."
300         https://trac.webkit.org/changeset/239913
301
302         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
303         https://trac.webkit.org/changeset/239914
304
305 2019-01-14  Mark Lam  <mark.lam@apple.com>
306
307         Re-enable ability to build --cloop builds.
308         https://bugs.webkit.org/show_bug.cgi?id=192955
309         <rdar://problem/46882363>
310
311         Reviewed by Saam barati and Keith Miller.
312
313         The --cloop build option was being ignored this whole time since r236381.
314         This patch makes it possible to build CLoop builds again.
315
316         * Scripts/build-jsc:
317         * Scripts/webkitperl/FeatureList.pm:
318         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
319
320 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
321
322         webkitpy: Expose device_type from host-like objects
323         https://bugs.webkit.org/show_bug.cgi?id=193406
324         <rdar://problem/47262305>
325
326         Reviewed by Lucas Forschler.
327
328         Devices should expose device_type. As a result, all host objects should
329         provide a device_type property, even if they do not yet define a device_type.
330
331         * Scripts/webkitpy/common/system/systemhost.py:
332         (SystemHost):
333         (SystemHost.device_type):
334         * Scripts/webkitpy/common/system/systemhost_mock.py:
335         (MockSystemHost):
336         (MockSystemHost.device_type):
337         * Scripts/webkitpy/port/device.py:
338         (Device):
339         (Device.device_type):
340         * Scripts/webkitpy/xcode/simulated_device.py:
341         (SimulatedDeviceManager._find_exisiting_device_for_request):
342         (SimulatedDeviceManager._disambiguate_device_type):
343         (SimulatedDeviceManager._does_fulfill_request):
344         (SimulatedDeviceManager.device_count_for_type):
345         (SimulatedDeviceManager.initialize_devices):
346         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
347         (test_available_devices):
348         (test_swapping_devices):
349
350 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
351
352         webkitpy: Support alternate simctl device list output (Follow-up fix)
353         https://bugs.webkit.org/show_bug.cgi?id=193362
354         <rdar://problem/47122965>
355
356         Rubber-stamped by Lucas Forschler.
357
358         * Scripts/webkitpy/xcode/simulated_device.py:
359         (SimulatedDeviceManager.populate_available_devices):
360
361 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
362
363         [iOS] Expose SPI to access the current sentence boundary and selection state
364         https://bugs.webkit.org/show_bug.cgi?id=193398
365         <rdar://problem/45893108>
366
367         Reviewed by Dean Jackson.
368
369         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
370         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
371         expected.
372
373         * TestWebKitAPI/EditingTestHarness.h:
374         * TestWebKitAPI/EditingTestHarness.mm:
375         (-[EditingTestHarness moveBackward]):
376         (-[EditingTestHarness moveForward]):
377         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
378
379         Add a couple of new helper methods on EditingTestHarness.
380
381         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
382         (-[SelectionChangeObserver initWithWebView:]):
383         (-[SelectionChangeObserver webView]):
384         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
385         (-[SelectionChangeObserver currentSelectionAttributes]):
386
387 2019-01-14  Zalan Bujtas  <zalan@apple.com>
388
389         [LFC][BFC] Add basic box-sizing support.
390         https://bugs.webkit.org/show_bug.cgi?id=193392
391
392         Reviewed by Antti Koivisto.
393
394         * LayoutReloaded/misc/LFC-passing-tests.txt:
395
396 2019-01-14  Charlie Turner  <cturner@igalia.com>
397
398         [WPE] API test gardening
399         https://bugs.webkit.org/show_bug.cgi?id=193319
400
401         Reviewed by Michael Catanzaro.
402
403         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
404         passing tests.
405
406 2019-01-14  Charlie Turner  <cturner@igalia.com>
407
408         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
409         https://bugs.webkit.org/show_bug.cgi?id=192977
410
411         Reviewed by Carlos Garcia Campos.
412
413         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
414         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
415         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
416         (TestWebKitAPI::GStreamerTest::SetUp):
417         (TestWebKitAPI::GStreamerTest::TearDown):
418         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
419         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
420         (TestWebKitAPI::TEST_F):
421
422 2019-01-14  Charlie Turner  <cturner@igalia.com>
423
424         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
425         https://bugs.webkit.org/show_bug.cgi?id=193332
426
427         Reviewed by Michael Catanzaro.
428
429         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
430         defined as a char16_t, which changed in ICU 59, the
431         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
432         unsigned short. This test is relying on the behaviour that
433         UChar=unsigned short, which doesn't hold across platforms and ICU
434         library versions. The full fix would be a special syntax for
435         literal characters so that these ambiguities do not arise. That
436         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
437         (TestWebKitAPI::TEST):
438
439 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
440
441         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
442
443         * Scripts/make-dist:
444         (Distcheck.configure):
445
446 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
447
448         [ews-build] Update macOS queue configurations
449         https://bugs.webkit.org/show_bug.cgi?id=193365
450         <rdar://problem/47221073>
451
452         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
453
454         * BuildSlaveSupport/ews-build/config.json:
455
456 2019-01-13  Zalan Bujtas  <zalan@apple.com>
457
458         [LFC] Adjust assert for statically positioned fixed elements
459         https://bugs.webkit.org/show_bug.cgi?id=193385
460
461         Reviewed by Antti Koivisto.
462
463         * LayoutReloaded/misc/LFC-passing-tests.txt:
464
465 2019-01-13  Philippe Normand  <pnormand@igalia.com>
466
467         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
468         https://bugs.webkit.org/show_bug.cgi?id=193387
469
470         Reviewed by Carlos Garcia Campos.
471
472         * MiniBrowser/wpe/main.cpp:
473         (main):
474
475 2019-01-12  Timothy Hatcher  <timothy@apple.com>
476
477         Have prefers-color-scheme: light always match on macOS versions before Mojave.
478         https://bugs.webkit.org/show_bug.cgi?id=191655
479         rdar://problem/46074680
480
481         Reviewed by Megan Gardner.
482
483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
484         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
485
486 2019-01-12  Dan Bernstein  <mitz@apple.com>
487
488         [Cocoa] Avoid importing directly from subumbrella frameworks
489         https://bugs.webkit.org/show_bug.cgi?id=186016
490         <rdar://problem/40591038>
491
492         Reviewed by Sam Weinig.
493
494         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
495           LaunchServices header.
496         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
497           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
498         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
499           when using SDKs earlier than 10.13.
500         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
501           and OTHER_CPLUSPLUSFLAGS.
502         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
503           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
504         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
505           LaunchServices header.
506
507 2019-01-11  John Wilander  <wilander@apple.com>
508
509         Compile out Web API Statistics Collection
510         https://bugs.webkit.org/show_bug.cgi?id=193370
511         <rdar://problem/45388584>
512
513         Reviewed by Brent Fulgham.
514
515         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
516             Defined ENABLE_WEB_API_STATISTICS, off by default.
517
518 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
519
520         [WPE] Add gtk-doc
521         https://bugs.webkit.org/show_bug.cgi?id=178900
522
523         Reviewed by Michael Catanzaro.
524
525         Add Tools/gtkdoc to manifest.txt.in files.
526         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
527
528         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
529         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
530
531 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
532
533         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
534         https://bugs.webkit.org/show_bug.cgi?id=193364
535         <rdar://problem/47214117>
536
537         Reviewed by Tim Horton.
538
539         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
540         precise, whereas dragging near the middle of the textarea does.
541
542         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
543         (TestWebKitAPI::TEST):
544
545 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
546
547         webkitpy: Support alternate simctl device list output
548         https://bugs.webkit.org/show_bug.cgi?id=193362
549         <rdar://problem/47122965>
550
551         Reviewed by Lucas Forschler.
552
553         * Scripts/webkitpy/xcode/simulated_device.py:
554         (SimulatedDeviceManager.populate_available_devices):
555
556 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
557
558         [ews-build] Update macOS queue configurations
559         https://bugs.webkit.org/show_bug.cgi?id=193365
560
561         Reviewed by Lucas Forschler.
562
563         * BuildSlaveSupport/ews-build/config.json:
564
565 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
566
567         webkitpy: Incorporate device type into baseline search path
568         https://bugs.webkit.org/show_bug.cgi?id=193356
569         <rdar://problem/47215515>
570
571         Reviewed by Lucas Forschler.
572
573         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
574
575         * Scripts/webkitpy/port/base.py:
576         (Port.default_baseline_search_path): Allow device type to be passed in.
577         * Scripts/webkitpy/port/gtk.py:
578         (GtkPort.default_baseline_search_path): Ignore device type.
579         * Scripts/webkitpy/port/ios.py:
580         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
581         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
582         * Scripts/webkitpy/port/ios_device_unittest.py:
583         (IOSDeviceTest):
584         * Scripts/webkitpy/port/ios_simulator_unittest.py:
585         (IOSSimulatorTest):
586         * Scripts/webkitpy/port/mac.py:
587         (MacPort.default_baseline_search_path): Ignore device type.
588         * Scripts/webkitpy/port/watch.py:
589         (WatchPort.default_baseline_search_path): Ditto.
590         * Scripts/webkitpy/port/win.py:
591         (WinPort.default_baseline_search_path): Ditto.
592         (WinCairoPort.default_baseline_search_path): Ditto.
593         * Scripts/webkitpy/port/wpe.py:
594         (WPEPort.default_baseline_search_path): Ditto.
595
596 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
597
598         webkitpy: Print abbreviated baseline search path that includes only folders that exist
599         https://bugs.webkit.org/show_bug.cgi?id=193352
600         <rdar://problem/47210736>
601
602         Reviewed by Lucas Forschler.
603
604         * Scripts/webkitpy/layout_tests/views/printing.py:
605         (Printer.print_config): Print list on only baseline search paths which exist. 
606         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
607         (Testprinter.test_print_config):
608
609 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
610
611         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
612         https://bugs.webkit.org/show_bug.cgi?id=193340
613
614         Reviewed by David Kilzer.
615
616         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
617         (WTR::InjectedBundle::didReceiveMessageToPage):
618         Pull the strings out into a WKRetainPtr.
619
620         * WebKitTestRunner/WebNotificationProvider.cpp:
621         (WTR::WebNotificationProvider::closeWebNotification):
622         Adopt the created value into the WKRetainPtr.
623
624         * WebKitTestRunner/mac/TestControllerMac.mm:
625         (WTR::generateWhitelist):
626         Immediately adopt a created value to avoid potential mistakes.
627
628 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
629
630         Enable DFG on ARM/Linux again
631         https://bugs.webkit.org/show_bug.cgi?id=192496
632
633         Reviewed by Yusuke Suzuki.
634
635         After changing the bytecode format DFG was disabled on all 32-bit
636         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
637         on ARM by default.
638
639         * Scripts/run-jsc-stress-tests:
640
641 2019-01-11  Timothy Hatcher  <timothy@apple.com>
642
643         Unreviewed, fix #ifdef in API test added in r239851.
644         https://bugs.webkit.org/show_bug.cgi?id=193327
645         rdar://problem/47093222
646
647         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
648
649 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
650
651         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
652         https://bugs.webkit.org/show_bug.cgi?id=193109
653         <rdar://problem/44807048>
654
655         Reviewed by Ryosuke Niwa.
656
657         Introduce and respect a test option to enable the UndoManager API.
658
659         * WebKitTestRunner/TestController.cpp:
660         (WTR::updateTestOptionsFromTestHeader):
661         * WebKitTestRunner/TestOptions.h:
662         (WTR::TestOptions::hasSameInitializationOptions const):
663         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
664         (WTR::TestController::platformCreateWebView):
665
666 2019-01-11  Zalan Bujtas  <zalan@apple.com>
667
668         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
669         https://bugs.webkit.org/show_bug.cgi?id=193346
670
671         Reviewed by Antti Koivisto.
672
673         * LayoutReloaded/misc/LFC-passing-tests.txt:
674
675 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
676
677         Unreviewed, fix typo that breaks dashboard link.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
680         (WebKitBuildbot):
681
682 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
683
684         Update macOS queue configurations
685         https://bugs.webkit.org/show_bug.cgi?id=193329
686
687         Reviewed by Alexey Proskuryakov.
688
689         * BuildSlaveSupport/build.webkit.org-config/config.json:
690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
691         (BubbleQueueServer):
692         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
694         (WebKitBuildbot):
695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
696         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
697         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
698
699 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
700
701         MiniBrowser should be able to navigate to about:blank
702         https://bugs.webkit.org/show_bug.cgi?id=193345
703
704         Reviewed by Simon Fraser.
705
706         * MiniBrowser/mac/BrowserWindowController.m:
707         (-[BrowserWindowController addProtocolIfNecessary:]):
708         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
709
710         * MiniBrowser/mac/WK1BrowserWindowController.m:
711         (-[WK1BrowserWindowController fetch:]):
712         * MiniBrowser/mac/WK2BrowserWindowController.m:
713         (-[WK2BrowserWindowController fetch:]):
714         Clean up the code that uses this to match style.
715
716 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
717
718         Remove MiniBrowser custom "Process Swap" menu item which does not work
719         https://bugs.webkit.org/show_bug.cgi?id=193344
720
721         Reviewed by Simon Fraser.
722
723         There is a menu item under the Experimental menu that does work.
724
725         * MiniBrowser/mac/AppDelegate.m:
726         (defaultConfiguration):
727         * MiniBrowser/mac/SettingsController.h:
728         * MiniBrowser/mac/SettingsController.m:
729         (-[SettingsController _populateMenu]):
730         (-[SettingsController validateMenuItem:]):
731         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
732         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
733
734 2019-01-10  Timothy Hatcher  <timothy@apple.com>
735
736         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
737         https://bugs.webkit.org/show_bug.cgi?id=193327
738         rdar://problem/47093222
739
740         Reviewed by Tim Horton.
741
742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
743         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
744         (TestWebKitAPI::didFinishNavigation):
745         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
746         (TestWebKitAPI::TEST):
747         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
748         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
749         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
750         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
751         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
752
753 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
754
755         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
756         https://bugs.webkit.org/show_bug.cgi?id=193338
757         <rdar://problem/46664774>
758
759         Reviewed by David Kilzer.
760
761         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
762         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
763
764 2019-01-10  Commit Queue  <commit-queue@webkit.org>
765
766         Unreviewed, rolling out r239825.
767         https://bugs.webkit.org/show_bug.cgi?id=193330
768
769         Broke tests on armv7/linux bots (Requested by guijemont on
770         #webkit).
771
772         Reverted changeset:
773
774         "Enable DFG on ARM/Linux again"
775         https://bugs.webkit.org/show_bug.cgi?id=192496
776         https://trac.webkit.org/changeset/239825
777
778 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
779
780         Disable the run-jsc-stress-test remote host key check.
781         https://bugs.webkit.org/show_bug.cgi?id=192988
782
783         Reviewed by Alexey Proskuryakov.
784
785         * Scripts/run-jsc-stress-tests:
786
787 2019-01-10  John Wilander  <wilander@apple.com>
788
789         Override the session configuration for cookieAcceptPolicy
790         https://bugs.webkit.org/show_bug.cgi?id=190925
791         <rdar://problem/45497382>
792
793         Reviewed by Alexey Proskuryakov and Alex Christensen.
794
795         Test infrastructure for setting a first-party-only cookie policy.
796
797         * DumpRenderTree/TestRunner.cpp:
798         (setOnlyAcceptFirstPartyCookiesCallback):
799         (TestRunner::staticFunctions):
800         * DumpRenderTree/TestRunner.h:
801         * DumpRenderTree/mac/TestRunnerMac.mm:
802         (TestRunner::setOnlyAcceptFirstPartyCookies):
803         * DumpRenderTree/win/TestRunnerWin.cpp:
804         (TestRunner::setOnlyAcceptFirstPartyCookies):
805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
806         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
807         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
809         * WebKitTestRunner/TestInvocation.cpp:
810         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
811
812 2019-01-09  Matt Rajca  <mrajca@apple.com>
813
814         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
815         https://bugs.webkit.org/show_bug.cgi?id=193301
816
817         Reviewed by Jer Noble.
818         
819         Added API tests.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
823         (TEST):
824         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
825
826 2019-01-10  Zalan Bujtas  <zalan@apple.com>
827
828         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
829         https://bugs.webkit.org/show_bug.cgi?id=193310
830
831         Reviewed by Antti Koivisto.
832
833         * LayoutReloaded/misc/LFC-passing-tests.txt:
834
835 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
836
837         Enable DFG on ARM/Linux again
838         https://bugs.webkit.org/show_bug.cgi?id=192496
839
840         Reviewed by Yusuke Suzuki.
841
842         After changing the bytecode format DFG was disabled on all 32-bit
843         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
844         on ARM by default.
845
846         * Scripts/run-jsc-stress-tests:
847
848 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
849
850         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
851         https://bugs.webkit.org/show_bug.cgi?id=193271
852
853         Reviewed by Brent Fulgham.
854
855         BSTR is a special data structure created by SysAllocString, not a
856         wchar_t null-terminated string.
857
858         * DumpRenderTree/win/TestRunnerWin.cpp:
859         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
860         * MiniBrowser/win/MiniBrowserWebHost.cpp:
861         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
862         BSTR from wide string literals.
863
864 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
865
866         Tweak wording for build/version_check style checker error
867         https://bugs.webkit.org/show_bug.cgi?id=193256
868
869         Reviewed by Tim Horton.
870
871         * Scripts/webkitpy/style/checkers/cpp.py:
872         (check_os_version_checks):
873         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
874         (WebKitStyleTest.test_os_version_checks):
875
876 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
877
878         [ews-build] Add link to bug along with bug title
879         https://bugs.webkit.org/show_bug.cgi?id=193293
880
881         Reviewed by Lucas Forschler.
882
883         * BuildSlaveSupport/ews-build/steps.py:
884         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
885         (ConfigureBuild.add_bug_id_url): Deleted.
886         (ConfigureBuild.getBugURL): Deleted.
887
888 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
889
890         [ews-build] Use https for ews-build server
891         https://bugs.webkit.org/show_bug.cgi?id=193193
892
893         Reviewed by Lucas Forschler.
894
895         * BuildSlaveSupport/ews-build/steps.py:
896
897 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
898
899         [ews-build] Parse and display number of style failures
900         https://bugs.webkit.org/show_bug.cgi?id=193280
901
902         Reviewed by Lucas Forschler.
903
904         * BuildSlaveSupport/ews-build/steps.py:
905         (CheckStyle): Use TestWithFailureCount as base class.
906         (CheckStyle.countFailures): Count the number of style failures.
907
908 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
909
910         [ews-build] use patch_id instead of ewspatchid
911         https://bugs.webkit.org/show_bug.cgi?id=193235
912
913         Reviewed by Lucas Forschler.
914
915         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
916         * BuildSlaveSupport/ews-build/steps.py: Ditto.
917         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
918
919 2019-01-09  Zalan Bujtas  <zalan@apple.com>
920
921         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
922         https://bugs.webkit.org/show_bug.cgi?id=192625
923
924         Reviewed by Antti Koivisto.
925
926         * LayoutReloaded/misc/LFC-passing-tests.txt:
927
928 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
929
930         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
931         https://bugs.webkit.org/show_bug.cgi?id=192841
932
933         Reviewed by Carlos Garcia Campos.
934
935         There are separate g_assert_*() macros for use in tests, which we use inconsistently
936         currently. Use them always. We'll get nicer error messages now when tests fail, and the
937         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
938
939         Note that the documentation of g_assert() says that it is not to be used when writing tests.
940
941         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
942         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
943         (WebKitWebEditorTest::testSelectionChanged):
944         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
945         (WebKitFrameTest::testMainFrame):
946         (WebKitFrameTest::testURI):
947         (WebKitFrameTest::testJavaScriptContext):
948         (WebKitFrameTest::testJavaScriptValues):
949         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
950         (testWebViewAuthenticationRequest):
951         (testWebViewAuthenticationLoadCancelled):
952         (testWebViewAuthenticationFailure):
953         (testWebViewAuthenticationStorage):
954         (ProxyAuthenticationTest::ProxyAuthenticationTest):
955         (testWebViewAuthenticationProxy):
956         (testWebViewAuthenticationProxyHTTPS):
957         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
958         (testAutomationSessionRequestSession):
959         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
960         (testBackForwardListNavigation):
961         (testWebKitWebViewSessionState):
962         (testWebKitWebViewSessionStateWithFormData):
963         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
964         (ConsoleMessageTest::consoleMessageReceivedCallback):
965         (testWebKitConsoleMessageConsoleAPI):
966         (testWebKitConsoleMessageJavaScriptException):
967         (testWebKitConsoleMessageNetworkError):
968         (testWebKitConsoleMessageSecurityError):
969         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
970         (testCookieManagerAcceptPolicy):
971         (testCookieManagerCookiesChanged):
972         (testCookieManagerPersistentStorage):
973         (testCookieManagerPersistentStorageDeleteAll):
974         (testCookieManagerEphemeral):
975         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
976         (testWebKitDOMElementAutoFill):
977         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
978         (downloadLocalFileSuccessfully):
979         (createFileAtDestination):
980         (testDownloadOverwriteDestinationDisallowed):
981         (testDownloadLocalFileError):
982         (testDownloadRemoteFile):
983         (testDownloadRemoteFileError):
984         (testWebViewDownloadURI):
985         (testPolicyResponseDownload):
986         (testPolicyResponseDownloadCancel):
987         (testDownloadMIMEType):
988         (contextMenuCallback):
989         (testContextMenuDownloadActions):
990         (testBlobDownload):
991         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
992         (testWebKitWebEditorSelectionChanged):
993         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
994         (testWebKitFrameMainFrame):
995         (testWebKitFrameURI):
996         (testWebKitFrameJavaScriptContext):
997         (testWebKitFrameJavaScriptValues):
998         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
999         (LoadStopTrackingTest::loadFailed):
1000         (testWebViewTitle):
1001         (testURIRequestHTTPHeaders):
1002         (testURIRequestHTTPMethod):
1003         (testURIResponseHTTPHeaders):
1004         (testRedirectToDataURI):
1005         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1006         (testProcessPerWebView):
1007         (testWebProcessLimit):
1008         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1009         (testWebViewResources):
1010         (testWebResourceLoading):
1011         (testWebResourceSuggestedFilename):
1012         (testWebResourceGetData):
1013         (testWebResourceGetDataError):
1014         (testWebViewResourcesHistoryCache):
1015         (testWebResourceSendRequest):
1016         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1017         (testSSL):
1018         (testInsecureContent):
1019         (testTLSErrorsPolicy):
1020         (testTLSErrorsRedirect):
1021         (testTLSErrorsHTTPAuth):
1022         (testLoadFailedWithTLSErrors):
1023         (testSubresourceLoadFailedWithTLSErrors):
1024         (httpsServerCallback):
1025         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1026         (testWebViewCreateNavigationData):
1027         (testWebViewJavaScriptDialogs):
1028         (testWebViewWindowProperties):
1029         (testWebViewMouseTarget):
1030         (testWebViewFileChooserRequest):
1031         (testWebViewColorChooserRequest):
1032         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1033         (testWebExtensionGetTitle):
1034         (testDocumentLoadedSignal):
1035         (testWebKitWebViewProcessCrashed):
1036         (testWebExtensionWindowObjectCleared):
1037         (testWebExtensionIsolatedWorld):
1038         (permissionRequestCallback):
1039         (didAssociateFormControlsCallback):
1040         (testWebExtensionFormControlsAssociated):
1041         (FormSubmissionTest::FormSubmissionTest):
1042         (FormSubmissionTest::testFormSubmissionResult):
1043         (testWebExtensionFormSubmissionSteps):
1044         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1045         (testNotInitialized):
1046         (testClearDatabase):
1047         (testPrivateBrowsing):
1048         (testGetFavicon):
1049         (testWebViewFavicon):
1050         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1051         (testFindControllerTextFound):
1052         (testFindControllerTextNotFound):
1053         (testFindControllerMatchCount):
1054         (testFindControllerMaxMatchCount):
1055         (testFindControllerNext):
1056         (testFindControllerPrevious):
1057         (testFindControllerCountedMatches):
1058         (testFindControllerOptions):
1059         (testFindControllerHide):
1060         (testFindControllerInstance):
1061         (testFindControllerGetters):
1062         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1063         (testNavigationPolicy):
1064         (testResponsePolicy):
1065         (testNewWindowPolicy):
1066         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1067         (testSecurityOriginBasicConstructor):
1068         (testSecurityOriginURIConstructor):
1069         (testSecurityOriginDefaultPort):
1070         (testSecurityOriginFileURI):
1071         (testOpaqueSecurityOrigin):
1072         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1073         (testWebKitSettings):
1074         (testWebKitSettingsNewWithSettings):
1075         (testWebKitSettingsUserAgent):
1076         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1077         (testWebViewNewWithUserContentManager):
1078         (isStyleSheetInjectedForURLAtPath):
1079         (isScriptInjectedForURLAtPath):
1080         (testUserContentManagerInjectedStyleSheet):
1081         (testUserContentManagerInjectedScript):
1082         (UserScriptMessageTest::scriptMessageReceived):
1083         (UserScriptMessageTest::waitUntilMessageReceived):
1084         (UserScriptMessageTest::runJavaScriptFinished):
1085         (testUserContentManagerScriptMessageReceived):
1086         (testUserContentManagerScriptMessageInWorldReceived):
1087         (testUserContentManagerScriptMessageFromDOMBindings):
1088         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1089         (testWebContextDefault):
1090         (testWebContextEphemeral):
1091         (testWebContextGetPlugins):
1092         (testWebContextURIScheme):
1093         (testWebContextSpellChecker):
1094         (testWebContextLanguages):
1095         (consoleMessageReceivedCallback):
1096         (testWebContextSecurityFileXHR):
1097         (ProxyTest::ProxyTest):
1098         (testWebContextProxySettings):
1099         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1100         (testWebViewWebContext):
1101         (testWebViewWebBackend):
1102         (testWebViewEphemeral):
1103         (testWebViewCustomCharset):
1104         (testWebViewSettings):
1105         (testWebViewRunJavaScript):
1106         (testWebViewCanShowMIMEType):
1107         (testWebViewSubmitForm):
1108         (testWebViewSave):
1109         (testWebViewPageVisibility):
1110         (testWebViewSnapshot):
1111         (testWebViewNotification):
1112         (testWebViewNotificationInitialPermissionAllowed):
1113         (testWebViewNotificationInitialPermissionDisallowed):
1114         (testWebViewIsPlayingAudio):
1115         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1116         (WebsiteDataTest::WebsiteDataTest):
1117         (WebsiteDataTest::remove):
1118         (WebsiteDataTest::clear):
1119         (testWebsiteDataConfiguration):
1120         (testWebsiteDataEphemeral):
1121         (testWebsiteDataCache):
1122         (testWebsiteDataStorage):
1123         (testWebsiteDataDatabases):
1124         (testWebsiteDataAppcache):
1125         (testWebsiteDataCookies):
1126         (testWebsiteDataDeviceIdHashSalt):
1127         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1128         (emitDocumentLoaded):
1129         (emitURIChanged):
1130         (sendRequestCallback):
1131         (contextMenuCallback):
1132         (consoleMessageSentCallback):
1133         (emitFormControlsAssociated):
1134         (formControlsAssociatedCallback):
1135         (emitFormSubmissionEvent):
1136         (willSubmitFormCallback):
1137         (windowObjectCleared):
1138         (methodCallCallback):
1139         (registerGResource):
1140         (webkit_web_extension_initialize_with_user_data):
1141         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1142         (checkLeaks):
1143         (WebProcessTest::create):
1144         (runTest):
1145         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1146         (AutocleanupsTest::testWebProcessAutocleanups):
1147         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1148         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1149         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1150         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1151         (WebKitDOMDOMWindowTest::testSignals):
1152         (WebKitDOMDOMWindowTest::testDispatchEvent):
1153         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1154         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1155         (WebKitDOMNodeFilterTest::testTreeWalker):
1156         (WebKitDOMNodeFilterTest::testNodeIterator):
1157         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1158         (WebKitDOMNodeTest::testHierarchyNavigation):
1159         (WebKitDOMNodeTest::testInsertion):
1160         (WebKitDOMNodeTest::testTagNamesNodeList):
1161         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1162         (WebKitDOMNodeTest::testDOMCache):
1163         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1164         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1165         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1166         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1167         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1168         (testUIProcessAutocleanups):
1169         (testWebProcessAutocleanups):
1170         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1171         (testContextMenuPopulateMenu):
1172         (testContextMenuDismissed):
1173         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1174         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1175         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1176         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1177         (testWebKitDOMDOMWindowSignals):
1178         (testWebKitDOMDOMWindowDispatchEvent):
1179         (testWebKitDOMDOMWindowGetComputedStyle):
1180         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1181         (testWebKitDOMNodeHierarchyNavigation):
1182         (testWebKitDOMNodeInsertion):
1183         (testWebKitDOMNodeTagNamesNodeList):
1184         (testWebKitDOMNodeTagNamesHTMLCollection):
1185         (testWebKitDOMObjectCache):
1186         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1187         (testWebKitDOMNodeFilterTreeWalker):
1188         (testWebKitDOMNodeFilterNodeIterator):
1189         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1190         (testWebKitDOMXPathNSResolverNative):
1191         (testWebKitDOMXPathNSResolverCustom):
1192         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1193         (testInspectorDefault):
1194         (testInspectorManualAttachDetach):
1195         (testInspectorCustomContainerDestroyed):
1196         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1197         (startTestServer):
1198         (testInspectorServerPageList):
1199         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1200         (OptionMenuTest::showOptionMenuCallback):
1201         (OptionMenuTest::menuCloseCallback):
1202         (OptionMenuTest::close):
1203         (OptionMenuTest::activateItem):
1204         (OptionMenuTest::selectItem):
1205         (testOptionMenuSimple):
1206         (testOptionMenuGroups):
1207         (testOptionMenuActivate):
1208         (testOptionMenuSelect):
1209         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1210         (testPrintOperationPrintSettings):
1211         (webViewPrintCallback):
1212         (testPrintOperationPrint):
1213         (testPrintCustomWidget):
1214         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1215         (checkAtspiAccessible):
1216         (testAtspiBasicHierarchy):
1217         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1218         (testWebKitCheckVersion):
1219         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1220         (testWebViewEditorCutCopyPasteNonEditable):
1221         (testWebViewEditorCutCopyPasteEditable):
1222         (testWebViewEditorSelectAllNonEditable):
1223         (testWebViewEditorSelectAllEditable):
1224         (loadContentsAndTryToCutSelection):
1225         (testWebViewEditorNonEditable):
1226         (testWebViewEditorEditable):
1227         (testWebViewEditorEditorStateTypingAttributes):
1228         (testWebViewEditorInsertImage):
1229         (testWebViewEditorCreateLink):
1230         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1231         (loadChangedCallback):
1232         (loadFailedCallback):
1233         (loadFailedWithTLSErrorsCallback):
1234         (LoadTrackingTest::LoadTrackingTest):
1235         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1236         (registerGResource):
1237         (removeNonEmptyDirectory):
1238         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1239         (Test::adoptView):
1240         (Test::~Test):
1241         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1242         (WebKitTestBus::getOrCreateConnection):
1243         (WebKitTestBus::createProxy):
1244         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1245         (WebKitTestServer::getWebSocketURIForPath const):
1246         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1247         (WebViewTest::initializeWebView):
1248         (WebViewTest::loadURI):
1249         (WebViewTest::loadHtml):
1250         (WebViewTest::loadPlainText):
1251         (WebViewTest::loadBytes):
1252         (WebViewTest::loadRequest):
1253         (WebViewTest::loadAlternateHTML):
1254         (WebViewTest::goBack):
1255         (WebViewTest::goForward):
1256         (WebViewTest::goToBackForwardListItem):
1257         (resourceGetDataCallback):
1258         (WebViewTest::mainResourceData):
1259         (WebViewTest::javascriptResultToCString):
1260         (WebViewTest::javascriptResultToNumber):
1261         (WebViewTest::javascriptResultToBoolean):
1262         (WebViewTest::javascriptResultIsNull):
1263         (WebViewTest::javascriptResultIsUndefined):
1264         (onSnapshotReady):
1265         (WebViewTest::runWebProcessTest):
1266         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1267         (WebViewTest::platformInitializeWebView):
1268         (WebViewTest::showInWindow):
1269         (WebViewTest::showInWindowAndWaitUntilMapped):
1270         (WebViewTest::mouseMoveTo):
1271         (WebViewTest::emitPopupMenuSignal):
1272         (WebViewTest::keyStroke):
1273         (WebViewTest::doMouseButtonEvent):
1274
1275 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1276
1277         [WPE] API tests can't run in flatpak environment
1278         https://bugs.webkit.org/show_bug.cgi?id=193242
1279
1280         Reviewed by Michael Catanzaro.
1281
1282         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1283         flatpakutils so that it knows which port it's dealing with.
1284         * glib/common.py: Remove build_dir globals so that subsequent
1285         calls actually take args into account.
1286         (library_build_path):
1287         (binary_build_path):
1288
1289 2019-01-08  Dean Jackson  <dino@apple.com>
1290
1291         Blob references for System Previews don't get a correct file extension
1292         https://bugs.webkit.org/show_bug.cgi?id=193268
1293         <rdar://problem/47133037>
1294
1295         Reviewed by Tim Horton.
1296
1297         New test that a Blob download of a USDZ file gets named correctly.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1301         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1302         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1303         (TEST):
1304         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1305
1306 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1307
1308         [WebAuthN] Support U2F HID Authenticators on macOS
1309         https://bugs.webkit.org/show_bug.cgi?id=191535
1310         <rdar://problem/47102027>
1311
1312         Reviewed by Brent Fulgham.
1313
1314         This patch:
1315         1) adds support for U2F mocking mechanism;
1316         2) updates tests to reflect U2fCommandConstructor changes.
1317
1318         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1319         (TestWebKitAPI::TEST):
1320         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1322         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1323
1324 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1325
1326         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1327         https://bugs.webkit.org/show_bug.cgi?id=193229
1328         <rdar://problem/46717097>
1329
1330         Reviewed by Tim Horton.
1331
1332         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1333         prevents a drag from starting.
1334
1335         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1336         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
1337
1338         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
1339
1340 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
1341   
1342         Layout test will generate a perf metric file to results dir.
1343         https://bugs.webkit.org/show_bug.cgi?id=192030
1344         <rdar://problem/32779516>
1345
1346         Reviewed by Aakash Jain.
1347
1348         Layout test running time will be collected to a perf metric file.
1349         For now, instead of outputing running time of all tests (which is huge),
1350         we aggregate them by test directories which are at most two level deep. 
1351
1352         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1353         (Manager._end_test_run):
1354         (Manager._output_perf_metrics):
1355         (Manager._print_expectation_line_for_test):
1356         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1357         (add_test_perf_metric):
1358         (test_perf_metrics):
1359         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1360         (JSONGeneratorTest.test_test_timings_trie):
1361         (JSONGeneratorTest):
1362         (JSONGeneratorTest.test_test_perf_metrics):
1363         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1364         (RebaselineTest.test_reset_results):
1365         (RebaselineTest.test_missing_results):
1366         (RebaselineTest.test_new_baseline):
1367
1368 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
1369
1370         [WPE][GTK] Add php-json to install-dependencies
1371         https://bugs.webkit.org/show_bug.cgi?id=193233
1372
1373         Reviewed by Michael Catanzaro.
1374
1375         * gtk/install-dependencies:
1376         * wpe/install-dependencies:
1377
1378 2019-01-08  Chris Dumez  <cdumez@apple.com>
1379
1380         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
1381         https://bugs.webkit.org/show_bug.cgi?id=193224
1382         <rdar://problem/47097726>
1383
1384         Reviewed by Alex Christensen.
1385
1386         Add API test coverage.
1387
1388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1389
1390 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1391
1392         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
1393         <https://webkit.org/b/193222>
1394         <rdar://problem/46862309>
1395
1396         Reviewed by Joseph Pecoraro.
1397
1398         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1399         (WTR::executeCallback): Fix camel case of variable name.
1400         (WTR::EventSendingController::callAfterScrollingCompletes): If
1401         WKBundlePageRegisterScrollOperationCompletionCallback() returns
1402         false, make sure to release the ScrollCompletionCallbackData
1403         object.  This fixes the leak.
1404
1405 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1406
1407         [Win] EWS: wincairo-ews cannot apply a patch with *.png
1408         https://bugs.webkit.org/show_bug.cgi?id=193044
1409
1410         Reviewed by Daniel Bates.
1411
1412         WinCairo EWS bots are using Windows Perl. Binary files should be
1413         opened as binary mode.
1414
1415         * Scripts/svn-apply:
1416         (handleGitBinaryChange): Use 'binmode' for binary file handles.
1417
1418 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
1419
1420         [CMake] Add ENABLE_CSS_TYPED_OM option
1421         https://bugs.webkit.org/show_bug.cgi?id=193216
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         * Scripts/webkitperl/FeatureList.pm:
1426
1427 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1428
1429         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1430         <https://webkit.org/b/193056>
1431
1432         Reviewed by Alex Christensen.
1433
1434         * Scripts/webkitpy/style/checker.py:
1435         - Ignore use of new runtime/retainptr check in
1436           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
1437           contains tests to ensure RetainPtr<NSObject *> is compatible
1438           with RetainPtr<NSObject>.
1439
1440         * Scripts/webkitpy/style/checkers/cpp.py:
1441         (check_language):
1442         (CppChecker):
1443         - Add checker for use of '*' in RetainPtr<> type.  A for loop
1444           was used instead of a single regex so that angle brackets
1445           could be matched up when checking the type contained within
1446           the RetainPtr<> type.
1447
1448         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1449         (CppStyleTest):
1450         - Add unit test for new runtime/retainptr check.
1451
1452         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
1453         * TestWebKitAPI/EditingTestHarness.h:
1454         - Remove '*' from RetainPtr<> type.
1455
1456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1457         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
1458           regressed in r201938.
1459
1460         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1461         (TestWebKitAPI::TEST):
1462         - Update tests to match RetainPtr.mm tests (except for the
1463           `*SimilarNSType` tests since there is no CF equivalent of
1464           RetainPtr<NSString> and RetainPtr<NSString *>).
1465
1466         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1467         (TestWebKitAPI::TEST):
1468         - Update tests to:
1469           - Not conflict by name with equivalent CF tests in
1470             RetainPtr.cpp.
1471           - Add test cases for RetainPtr<NSObject>,
1472             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
1473           - Add `*SimilarNSType` tests for converting between
1474             RetainPtr<NSObject> and RetainPtr<NSObject *>.
1475           - Change `0` to `nil` as appropriate.
1476           - Re-alphabetize the tests by name.
1477           - Add Optional<RetainPtr<>> tests.
1478           - Add retainPtr() tests.
1479
1480         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1481         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1482         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
1483         (TEST):
1484         - Remove '*' from RetainPtr<> type.
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
1487         (TEST(WebKit, JITEnabled)):
1488         - Add missing WTFMove().  Apparently a temporary was being
1489           created before in the argument list due to mismatched
1490           RetainPtr<> types.
1491
1492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1493         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1494         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1495         (TestWebKitAPI::TEST):
1496         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1497         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1498         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1499         (WTR::resourcesDirectoryURL):
1500         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1501         (WTR::InjectedBundle::platformInitialize):
1502         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1503         - Remove '*' from RetainPtr<> type.
1504
1505 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
1506
1507         A MediaTime timescale must never be zero
1508         https://bugs.webkit.org/show_bug.cgi?id=193156
1509         <rdar://problem/32504501>
1510
1511         Reviewed by Jer Noble.
1512
1513         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1514         (TestWebKitAPI::TEST): Add tests for zero timescale.
1515
1516 2019-01-07  Youenn Fablet  <youenn@apple.com>
1517
1518         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
1519         https://bugs.webkit.org/show_bug.cgi?id=193175
1520
1521         Reviewed by Chris Dumez.
1522
1523         Updated API test as we bumped the SW schema to version 4.
1524
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1526         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
1527         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1528         (TEST):
1529
1530 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1531
1532         [Win][Clang] Fix compilation warnings of MiniBrowser
1533         https://bugs.webkit.org/show_bug.cgi?id=193029
1534
1535         Reviewed by Ross Kirsling.
1536
1537         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
1538         and m_URLBarFont. Reorder member variables to fix -Wreorder
1539         warning.
1540         * MiniBrowser/win/PageLoadTestClient.cpp:
1541         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
1542         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
1543         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
1544         m_currentURLIndex.
1545         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1546         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
1547         navigationClient with '{ }' to fix the missing field warning.
1548         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1549         (initDocStruct): Changed the argument type docname to const.
1550
1551 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
1552
1553         [WebAuthN] Import U2F command/response converters from Chromium
1554         https://bugs.webkit.org/show_bug.cgi?id=193150
1555         <rdar://problem/47054028>
1556
1557         Reviewed by Brent Fulgham.
1558
1559         Adds API tests.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1563         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
1564         (TestWebKitAPI::getTestAuthenticatorDataBytes):
1565         (TestWebKitAPI::getTestAttestationObjectBytes):
1566         (TestWebKitAPI::getTestSignResponse):
1567         (TestWebKitAPI::getTestU2fRegisterResponse):
1568         (TestWebKitAPI::TEST):
1569         (TestWebKitAPI::convertToVector): Deleted.
1570         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1571         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
1572         (TestWebKitAPI::constructMakeCredentialRequest):
1573         (TestWebKitAPI::constructGetAssertionRequest):
1574         (TestWebKitAPI::TEST):
1575
1576 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
1577
1578         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
1579         https://bugs.webkit.org/show_bug.cgi?id=193136
1580
1581         Reviewed by Michael Catanzaro.
1582
1583         * gtk/install-dependencies:
1584         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
1585         they are needed by update-webkitgtk-libs.
1586
1587 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
1588
1589         Unreviewed follow-up fix to r239650
1590         https://bugs.webkit.org/show_bug.cgi?id=193140
1591         <rdar://problem/47063037>
1592
1593         Typecast patch_id to string.
1594
1595         * BuildSlaveSupport/ews-build/steps.py:
1596         (ValidatePatch._is_patch_obsolete):
1597
1598 2019-01-04  Daniel Bates  <dabates@apple.com>
1599
1600         [lldb-webkit]: Add support for pretty-printing raw bitmask types
1601         https://bugs.webkit.org/show_bug.cgi?id=193024
1602
1603         Reviewed by Jer Noble.
1604
1605         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
1606         for the bitmask type WebEventFlags as an example.
1607
1608         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
1609         that can be used to register summary and synthetic child formatters for a bitmask type.
1610         For example, consider the following enum and bitmask typedefs:
1611
1612         typedef enum {
1613             A = 1 << 0,
1614             B = 1 << 1,
1615             C = 1 << 2,
1616         } SpecialFlagValues;
1617         typedef unsigned SpecialFlags;
1618
1619         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
1620         __lldb_init_module():
1621
1622             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
1623                     1 << 0: "A",
1624                     1 << 1: "B",
1625                     1 << 2: "C",
1626             })
1627
1628         * lldb/lldb_webkit.py:
1629         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1630         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
1631         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
1632         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
1633         A convenience function to dynamically creaste a synthetic formatter class and summary
1634         string function for the specified bitmask type and enumerator value to name map. This
1635         function register the dynamically created class and function with LLDB.
1636
1637         (__lldb_init_module):
1638         (FlagEnumerationProvider):
1639         (FlagEnumerationProvider._enumerator_value_to_name_map):
1640         (FlagEnumerationProvider._bitmask):
1641         (FlagEnumerationProvider._update):
1642         (FlagEnumerationProvider.has_children):
1643         (FlagEnumerationProvider.num_children):
1644         (FlagEnumerationProvider.get_child_index):
1645         (FlagEnumerationProvider.get_child_at_index):
1646         (FlagEnumerationProvider.update):
1647         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
1648
1649         (WTFOptionSetProvider):
1650         (WTFOptionSetProvider._enumerator_value_to_name_map):
1651         (WTFOptionSetProvider._bitmask):
1652         (WTFOptionSetProvider._update):
1653         Write in terms of the base class.
1654
1655         (RawBitmaskProviderBase):
1656         (RawBitmaskProviderBase._enumerator_value_to_name_map):
1657         (RawBitmaskProviderBase._bitmask):
1658         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
1659         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
1660         {
1661             1 << 0: "A",
1662             1 << 1: "B",
1663             1 << 2: "C",
1664         }
1665         It is not necessary to instantiate such a derived class directory. Instead use the convenience
1666         function addSummaryAndSyntheticFormattersForRawBitmaskType.
1667
1668         (WTFOptionSetProvider.has_children): Deleted.
1669         (WTFOptionSetProvider.num_children): Deleted.
1670         (WTFOptionSetProvider.get_child_index): Deleted.
1671         (WTFOptionSetProvider.get_child_at_index): Deleted.
1672         (WTFOptionSetProvider.update): Deleted.
1673
1674 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1675
1676         [ews-build] Add build step to validate the patch before processing it
1677         https://bugs.webkit.org/show_bug.cgi?id=193140
1678
1679         Reviewed by Lucas Forschler.
1680
1681         * BuildSlaveSupport/ews-build/factories.py:
1682         (Factory.__init__): Added ValidatePatch step.
1683         * BuildSlaveSupport/ews-build/steps.py:
1684         (ValidatePatch):
1685         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
1686         (ValidatePatch.get_patch_json): Get patch json data.
1687         (ValidatePatch.get_bug_json): Get bug json data.
1688         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
1689         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
1690         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
1691         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
1692         (ValidatePatch.skip_build): Skip the build.
1693         (ValidatePatch.start):
1694
1695 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1696
1697         Progress towards fixing Mac CMake build
1698         https://bugs.webkit.org/show_bug.cgi?id=193105
1699
1700         Reviewed by Don Olmstead.
1701
1702         * TestWebKitAPI/PlatformMac.cmake:
1703
1704 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1705
1706         Fix API test after r239631
1707         https://bugs.webkit.org/show_bug.cgi?id=193118
1708
1709         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1710         (TestWebKitAPI::TEST):
1711         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
1712         Do the same thing via the API to fix the test.
1713
1714 2019-01-04  Jer Noble  <jer.noble@apple.com>
1715
1716         [WebKitLegacy] Media playback pauses on scroll
1717         https://bugs.webkit.org/show_bug.cgi?id=192829
1718
1719         Reviewed by Eric Carlson.
1720
1721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1722         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
1723         (TestWebKitAPI::TEST):
1724         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
1725         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
1726         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
1727         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
1728         (TestWebKitAPI::TEST):
1729
1730 2019-01-04  Chris Dumez  <cdumez@apple.com>
1731
1732         Add support for toggling device orientation API support per site
1733         https://bugs.webkit.org/show_bug.cgi?id=193143
1734         <rdar://problem/46605724>
1735
1736         Reviewed by Alex Christensen.
1737
1738         Add API test coverage.
1739
1740         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1741         (-[DataMappingSchemeHandler setTaskHandler:]):
1742         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
1743         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
1744         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1745         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
1746
1747 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-build] use svn-apply script to apply the patches
1750         https://bugs.webkit.org/show_bug.cgi?id=193138
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * BuildSlaveSupport/ews-build/factories.py:
1755         (Factory.__init__): Add the ApplyPatch step.
1756         * BuildSlaveSupport/ews-build/steps.py:
1757         (CheckOutSource): Added step name.
1758         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
1759         (ApplyPatch): Build step to apply patch using svn-apply script.
1760         (UnApplyPatchIfRequired):
1761         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
1762
1763 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1764
1765         Deprecate WKContextCreate
1766         https://bugs.webkit.org/show_bug.cgi?id=193118
1767
1768         Reviewed by Brady Eidson.
1769
1770         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1771         (WebKitBrowserWindow::WebKitBrowserWindow):
1772         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1779         (TestWebKitAPI::TEST):
1780         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
1781         (TestWebKitAPI::TEST):
1782         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1783         (TestWebKitAPI::TEST):
1784         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1801         (TestWebKitAPI::TEST):
1802         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1805         (TestWebKitAPI::TEST):
1806         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1809         (TestWebKitAPI::loadAlternateHTMLString):
1810         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1811         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1812         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1813         (TestWebKitAPI::buildAndPerformTest):
1814         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
1817         (TestWebKitAPI::TEST):
1818         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
1819         (TestWebKitAPI::TEST):
1820         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1821         (TestWebKitAPI::TEST):
1822         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1823         (TestWebKitAPI::TEST):
1824         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1825         (TestWebKitAPI::TEST):
1826         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1827         (TestWebKitAPI::TEST):
1828         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1829         (TestWebKitAPI::TEST):
1830         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1831         (TestWebKitAPI::TEST):
1832         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1833         (TestWebKitAPI::TEST):
1834         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1837         (TestWebKitAPI::TEST):
1838         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1839         (TestWebKitAPI::TEST):
1840         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1841         (TestWebKitAPI::TEST):
1842         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1843         (TestWebKitAPI::TEST):
1844         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1845         (TestWebKitAPI::TEST):
1846         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1847         (TestWebKitAPI::TEST):
1848         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1853         (TestWebKitAPI::TEST):
1854         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1855         (TestWebKitAPI::TEST):
1856         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1857         (TestWebKitAPI::TEST):
1858         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1859         (TestWebKitAPI::TEST):
1860         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
1861         (TestWebKitAPI::TEST):
1862         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1863         (TestWebKitAPI::TEST):
1864         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1865         (TestWebKitAPI::TEST):
1866         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1867         (WebKit2_CommandBackForwardTestWKView::SetUp):
1868         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1869         (TestWebKitAPI::TEST):
1870         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1871         (TestWebKitAPI::TEST):
1872         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
1873         (TestWebKitAPI::TEST):
1874         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1875         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1876
1877 2019-01-03  Matt Rajca  <mrajca@apple.com>
1878
1879         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
1880         https://bugs.webkit.org/show_bug.cgi?id=193128
1881         rdar://34554231
1882
1883         Reviewed by Jer Noble.
1884
1885         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
1886         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
1887         event along with a flag that indicates whether or not autoplay was actually prevented.
1888
1889         Tests: existing API tests were updated to reflect the new names. New API tests
1890         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
1891
1892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1893         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
1894         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1895         (TEST):
1896         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
1897         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
1898
1899 2019-01-04  Chris Dumez  <cdumez@apple.com>
1900
1901         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
1902         https://bugs.webkit.org/show_bug.cgi?id=193120
1903
1904         Reviewed by Alex Christensen.
1905
1906         Add API test coverage.
1907
1908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1909
1910 2019-01-04  Chris Dumez  <cdumez@apple.com>
1911
1912         Crash under WebProcessPool::addSuspendedPage()
1913         https://bugs.webkit.org/show_bug.cgi?id=193110
1914
1915         Reviewed by Youenn Fablet.
1916
1917         Add API test coverage.
1918
1919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1920
1921 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1922
1923         [ews-build] Check patch relevance before applying the patch
1924         https://bugs.webkit.org/show_bug.cgi?id=193102
1925
1926         Reviewed by Lucas Forschler.
1927
1928         * BuildSlaveSupport/ews-build/factories.py:
1929         (Factory.__init__): Moved CheckPatchRelevance step to base class.
1930
1931 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-build] Check patch relevance step should print patch id
1934         https://bugs.webkit.org/show_bug.cgi?id=193137
1935
1936         Reviewed by Lucas Forschler.
1937
1938         * BuildSlaveSupport/ews-build/steps.py:
1939         (CheckPatchRelevance.start): Update the status to include patch id.
1940
1941 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
1942
1943         webkitpy: Increase simulator teardown timeout
1944         https://bugs.webkit.org/show_bug.cgi?id=193141
1945         <rdar://problem/46174217>
1946
1947         Rubber-stamped by Aakash Jain.
1948
1949         * Scripts/webkitpy/xcode/simulated_device.py:
1950         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
1951
1952 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
1953
1954         test262-runner misbehaves when test file YAML has a trailing space
1955         https://bugs.webkit.org/show_bug.cgi?id=193053
1956
1957         Reviewed by Yusuke Suzuki.
1958
1959         * Scripts/test262/Runner.pm:
1960         (parseData):
1961         Accept trailing space when parsing a test file's YAML block.
1962
1963 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1964
1965         UserMedia test should use WKPageNavigationClient
1966         https://bugs.webkit.org/show_bug.cgi?id=192913
1967
1968         Reviewed by Youenn Fablet.
1969
1970         The test currently uses the deprecated WKPageLoaderClient. It should use
1971         WKPageNavigationClient instead, which provides the same callback under a similar name.
1972
1973         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1974         (TestWebKitAPI::TEST):
1975
1976 2019-01-02  Alex Christensen  <achristensen@webkit.org>
1977
1978         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
1979         https://bugs.webkit.org/show_bug.cgi?id=192944
1980
1981         Reviewed by Tim Horton.
1982
1983         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1984         (TestWebKitAPI::TEST):
1985
1986 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1987
1988         Add support for using the current text selection as the find string on iOS
1989         https://bugs.webkit.org/show_bug.cgi?id=193034
1990         <rdar://problem/45138739>
1991
1992         Reviewed by Tim Horton.
1993
1994         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
1995         _setStringForFind) works as expected.
1996
1997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1998         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
1999
2000 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [ews-build] Use git on OpenSource EWS bots
2003         https://bugs.webkit.org/show_bug.cgi?id=193092
2004
2005         Reviewed by Lucas Forschler.
2006
2007         * BuildSlaveSupport/ews-build/steps.py:
2008         (CheckOutSource): Use git instead of svn.
2009         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2010
2011 2019-01-02  Daniel Bates  <dabates@apple.com>
2012
2013         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2014         https://bugs.webkit.org/show_bug.cgi?id=193023
2015
2016         Reviewed by Simon Fraser.
2017
2018         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2019         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2020         enumerator values. We should just remove this code.
2021
2022         * lldb/lldb_webkit.py:
2023         (WTFOptionSetProvider.has_children):
2024         (WTFOptionSetProvider.num_children):
2025         (WTFOptionSetProvider.get_child_index):
2026         (WTFOptionSetProvider.get_child_at_index):
2027
2028 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2029
2030         .ycm_extra_conf.py should handle XXXInlines.h
2031         https://bugs.webkit.org/show_bug.cgi?id=193055
2032
2033         Reviewed by Carlos Garcia Campos.
2034
2035         compile_commands.json database only records flags and options for cpp source files.
2036         So, when we open headers, this database does not have any information for that.
2037         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2038         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2039         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2040         we attempt to find XXX.cpp and use the configuration if it exists.
2041
2042         * gtk/ycm_extra_conf.py:
2043         (getImplementationFilename):
2044         (FlagsForFile):
2045
2046 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2047
2048         Unreviewed. Support PHP 7.3 in Debian.
2049
2050         Add 7.3 to the list of php versions supported in Debian.
2051
2052         * Scripts/webkitpy/port/base.py:
2053         (Port._debian_php_version):
2054
2055 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2056
2057         Resurrect Mac CMake build
2058         https://bugs.webkit.org/show_bug.cgi?id=192658
2059
2060         Reviewed by Yusuke Suzuki.
2061
2062         * DumpRenderTree/PlatformMac.cmake:
2063         * MiniBrowser/mac/CMakeLists.txt:
2064         * TestWebKitAPI/PlatformMac.cmake:
2065
2066 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2067
2068         [Tools] Remove references to Bison and Flex
2069         https://bugs.webkit.org/show_bug.cgi?id=193033
2070
2071         Reviewed by Michael Catanzaro.
2072
2073         The Bison and Flex tools are not needed anymore since r209883.
2074
2075         * CygwinDownloader/cygwin-downloader.py:
2076         * EWSTools/ubuntu-ews-packages:
2077         * Scripts/filter-build-webkit:
2078         (shouldIgnoreLine):
2079         * gtk/install-dependencies:
2080         * wpe/install-dependencies:
2081
2082 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2083
2084         WebDriver: warn about non existing tests when parsing expectations
2085         https://bugs.webkit.org/show_bug.cgi?id=192979
2086
2087         Reviewed by Michael Catanzaro.
2088
2089         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2090         renamed.
2091
2092         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2093         (WebDriverTestRunner.__init__):
2094
2095 2018-12-21  Chris Dumez  <cdumez@apple.com>
2096
2097         navigator.userAgent in service workers does not reflect customUserAgent set by client
2098         https://bugs.webkit.org/show_bug.cgi?id=192951
2099
2100         Reviewed by Youenn Fablet.
2101
2102         Extend API test coverage.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2105         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2106         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2107         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2108         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2109
2110 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2111
2112         [WebAuthN] userPresence should always be true
2113         https://bugs.webkit.org/show_bug.cgi?id=192835
2114         <rdar://problem/46538788>
2115
2116         Reviewed by Brent Fulgham.
2117
2118         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2119         (TestWebKitAPI::TEST):
2120
2121 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2122
2123         Add support to run-benchmark to use non-default copies of the browser apps
2124         https://bugs.webkit.org/show_bug.cgi?id=192905
2125         rdar://problem/46845840
2126
2127         Reviewed by Dewei Zhu.
2128         
2129         Add support for a --browser-path argument to run-benchmark, which allows you to use
2130         a custom app bundle for a given browser (only implemented for Safari at present).
2131
2132         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2133         (BenchmarkRunner.__init__):
2134         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2135         (BrowserDriver.__init__):
2136         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2137         (BrowserDriverFactory.create):
2138         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2139         (OSXBrowserDriver._launch_process):
2140         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2141         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2142         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2143         (OSXChromeCanaryDriver.launch_url):
2144         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2145         (OSXFirefoxNightlyDriver.launch_url):
2146         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2147         (OSXSafariDriver.__init__):
2148         (OSXSafariDriver.launch_url):
2149         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2150         (parse_args):
2151         (run_benchmark_plan):
2152         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2153         (WebServerBenchmarkRunner.__init__):
2154         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2155         (FakeBenchmarkRunner.__init__):
2156
2157 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2158
2159         [WebAuthN] Import an APDU coder from Chromium
2160         https://bugs.webkit.org/show_bug.cgi?id=192949
2161         <rdar://problem/46879933>
2162
2163         Reviewed by Brent Fulgham.
2164
2165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2166         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2167         (TestWebKitAPI::TEST):
2168
2169 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2170
2171         Setting the file wrapper and content type of an attachment to a PDF should update its image
2172         https://bugs.webkit.org/show_bug.cgi?id=192984
2173         <rdar://problem/46798028>
2174
2175         Reviewed by Tim Horton.
2176
2177         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2178         PDF data correctly updates the image element.
2179
2180         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2181
2182 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2183
2184         Add JSCOnly to bot dashboard
2185         https://bugs.webkit.org/show_bug.cgi?id=192964
2186
2187         Reviewed by Alexey Proskuryakov.
2188
2189         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2190         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2191         useful if they were not so secret, so add them.
2192
2193         There appear to be no build-only bots, so the first column is blank. And of course there are
2194         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2195         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2196         and there's plenty of room in the final column for all the bots.
2197
2198         I had a hard time picking a logo to use, because the JavaScript language does not have an
2199         official logo. But I believe I've found one that will be satisfactory.
2200
2201         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2202
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2206         (BubbleQueueServer):
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2209         (WebKitBuildbot):
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2211         (table.queue-grid tr.platform.linux-jsconly img.logo):
2212
2213 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2214
2215         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2216         https://bugs.webkit.org/show_bug.cgi?id=192821
2217
2218         Reviewed by Chris Dumez.
2219
2220         * DumpRenderTree/mac/DumpRenderTree.mm:
2221         (createWebViewAndOffscreenWindow):
2222         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2223
2224 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2225
2226         [Win][Clang] Fix compilation warnings of DumpRenderTree
2227         https://bugs.webkit.org/show_bug.cgi?id=192924
2228
2229         Reviewed by Alex Christensen.
2230
2231         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2232         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2233         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2234         * DumpRenderTree/win/DumpRenderTree.cpp:
2235         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2236         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2237         object to the argument of setDefaultTextEncodingName instead of a
2238         const string literal.
2239         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2240         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2241         (setCacheFolder): Deleted.
2242         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2243         * DumpRenderTree/win/EditingDelegate.cpp:
2244         (dump): Use %d for int.
2245         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2246         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2247         (BSTRFromString): Deleted unused function.
2248         * DumpRenderTree/win/TestRunnerWin.cpp:
2249         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2250         the arguemnt of setQuota instead of const string literal.
2251         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2252         (jsStringRefToWString): Deleted unused function.
2253
2254 2018-12-20  Chris Dumez  <cdumez@apple.com>
2255
2256         Add API test coverage for customUserAgent client setting and service workers
2257         https://bugs.webkit.org/show_bug.cgi?id=192952
2258
2259         Reviewed by Alex Christensen.
2260
2261         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2262         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2263         (-[SWSchemes webView:startURLSchemeTask:]):
2264         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2265         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2266
2267 2018-12-20  Chris Dumez  <cdumez@apple.com>
2268
2269         Use Optional::hasValue() instead of Optional::has_value()
2270         https://bugs.webkit.org/show_bug.cgi?id=192948
2271
2272         Reviewed by Tim Horton.
2273
2274         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2275         (TestWebKitAPI::TEST):
2276         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2277         (TestWebKitAPI::TEST):
2278         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2279         (TestWebKitAPI::TEST_F):
2280
2281 2018-12-20  Chris Dumez  <cdumez@apple.com>
2282
2283         Add style script rule to check for uses of std::optional<>
2284         https://bugs.webkit.org/show_bug.cgi?id=192931
2285
2286         Reviewed by Tim Horton.
2287
2288         * Scripts/webkitpy/style/checkers/cpp.py:
2289         (check_wtf_optional):
2290         (check_style):
2291
2292 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2293
2294         [WebAuthN] Add a runtime flag for local authenticator
2295         https://bugs.webkit.org/show_bug.cgi?id=192792
2296         <rdar://problem/46798738>
2297
2298         Reviewed by Brent Fulgham.
2299
2300         * DumpRenderTree/TestOptions.cpp:
2301         (TestOptions::TestOptions):
2302         * DumpRenderTree/TestOptions.h:
2303         * DumpRenderTree/mac/DumpRenderTree.mm:
2304         (enableExperimentalFeatures):
2305         (setWebPreferencesForTestOptions):
2306         * WebKitTestRunner/TestController.cpp:
2307         (WTR::TestController::resetPreferencesToConsistentValues):
2308         (WTR::updateTestOptionsFromTestHeader):
2309         * WebKitTestRunner/TestOptions.h:
2310         (WTR::TestOptions::hasSameInitializationOptions const):
2311
2312 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2313
2314         webkitpy: Autoinstall package URLs have changed
2315         https://bugs.webkit.org/show_bug.cgi?id=192909
2316         <rdar://problem/46860359>
2317
2318         Rubber-stamped by Alexey Proskuryakov.
2319
2320         PyPi urls have been moved around, we need to update our auto-installed packages.
2321
2322         We should check for Selenium before asking PyPi for the latest version.
2323
2324         * Scripts/webkitpy/thirdparty/__init__.py:
2325         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2326         (AutoinstallImportHook._install_keyring): Ditto.
2327         (AutoinstallImportHook._install_pep8): Ditto.
2328         (AutoinstallImportHook._install_mozlog): Ditto.
2329         (AutoinstallImportHook._install_mozprocess): Ditto.
2330         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2331         (AutoinstallImportHook._install_pytest): Ditto.
2332         (AutoinstallImportHook._install_pylint): Ditto.
2333         (AutoinstallImportHook._install_buildbot): Ditto.
2334         (AutoinstallImportHook._install_coverage): Ditto.
2335         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
2336         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
2337         for new Selenium if the installed version isn't sufficient.
2338         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
2339
2340 2018-12-20  Chris Dumez  <cdumez@apple.com>
2341
2342         Use Optional::valueOr() instead of Optional::value_or()
2343         https://bugs.webkit.org/show_bug.cgi?id=192933
2344
2345         Reviewed by Geoffrey Garen.
2346
2347         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2348         (TestWebKitAPI::checkURL):
2349         (TestWebKitAPI::checkRelativeURL):
2350         (TestWebKitAPI::checkURLDifferences):
2351         (TestWebKitAPI::checkRelativeURLDifferences):
2352         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2353         (TestWebKitAPI::checkURL):
2354
2355 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
2356
2357         Unreviewed, rolling out r239417.
2358
2359         Introduced two API test failures on macOS.
2360
2361         Reverted changeset:
2362
2363         "<rdar://problem/46194315> macOS: WebKit1 does not handle
2364         occlusion changes"
2365         https://bugs.webkit.org/show_bug.cgi?id=192821
2366         https://trac.webkit.org/changeset/239417
2367
2368 2018-12-20  Devin Rousso  <drousso@apple.com>
2369
2370         Web Inspector: UIString should take an optional key and description to aid localization
2371         https://bugs.webkit.org/show_bug.cgi?id=153962
2372         <rdar://problem/24542505>
2373
2374         Reviewed by Brian Burg.
2375
2376         * Scripts/extract-localizable-js-strings:
2377
2378 2018-12-20  Tim Horton  <timothy_horton@apple.com>
2379
2380         Unparented WKWebView can't retrieve main resource data for a main frame plugin
2381         https://bugs.webkit.org/show_bug.cgi?id=192923
2382         <rdar://problem/46859068>
2383
2384         Reviewed by Wenson Hsieh.
2385
2386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2387         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
2388         Add a test ensuring that both parented and unparented WKWebViews can
2389         retrieve main resource data when loading a PDF.
2390
2391 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2392
2393         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
2394         https://bugs.webkit.org/show_bug.cgi?id=192852
2395
2396         Reviewed by Michael Catanzaro.
2397
2398         EmojiOne font was replaced by Noto Color Emoji.
2399
2400         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
2401         * gtk/jhbuild.modules:
2402         * wpe/jhbuild.modules:
2403
2404 2018-12-19  Chris Dumez  <cdumez@apple.com>
2405
2406         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
2407         https://bugs.webkit.org/show_bug.cgi?id=192728
2408         <rdar://problem/46746779>
2409
2410         Reviewed by Geoff Garen.
2411
2412         * DumpRenderTree/*:
2413         * MiniBrowser/*:
2414         * TestRunnerShared/*:
2415         * TestWebKitAPI/*:
2416         * WebGPUAPIStructure/*:
2417         * WebKitTestRunner/*:
2418
2419 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
2420
2421         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2422         https://bugs.webkit.org/show_bug.cgi?id=192821
2423
2424         Reviewed by Chris Dumez.
2425
2426         * DumpRenderTree/mac/DumpRenderTree.mm:
2427         (createWebViewAndOffscreenWindow):
2428
2429 2018-12-19  Alex Christensen  <achristensen@webkit.org>
2430
2431         Navigations away from the SafeBrowsing interstitial show a flash of old content
2432         https://bugs.webkit.org/show_bug.cgi?id=192676
2433
2434         Reviewed by Chris Dumez.
2435
2436         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2437         (safeBrowsingView):
2438         (TEST):
2439         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2440
2441 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
2442
2443         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
2444         https://bugs.webkit.org/show_bug.cgi?id=192855
2445
2446         Reviewed by Michael Catanzaro.
2447
2448         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2449         (WTR::TestController::notifyDone): Use the WPE implementation.
2450         (WTR::TestController::platformRunUntil): Use the WPE implementation.
2451         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2452         (WTR::TestController::platformRunUntil): Honor the condition flag.
2453
2454 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
2455
2456         Allow clients to set the navigator platform
2457         https://bugs.webkit.org/show_bug.cgi?id=192735
2458
2459         Reviewed by Tim Horton.
2460
2461         Add a test for setting a custom navigator platform.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2464         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2465         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
2466
2467 2018-12-19  Truitt Savell  <tsavell@apple.com>
2468
2469         Unreviewed, rolling out r239358.
2470
2471         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
2472         crash on Debug bots
2473
2474         Reverted changeset:
2475
2476         "Clean up IndexedDB files between tests"
2477         https://bugs.webkit.org/show_bug.cgi?id=192796
2478         https://trac.webkit.org/changeset/239358
2479
2480 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2481
2482         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
2483         https://bugs.webkit.org/show_bug.cgi?id=192842
2484         <rdar://problem/46823586>
2485
2486         Reviewed by Tim Horton.
2487
2488         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
2489         item provider when dragging a rich text selection.
2490
2491         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2492
2493 2018-12-18  David Quesada  <david_quesada@apple.com>
2494
2495         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
2496         https://bugs.webkit.org/show_bug.cgi?id=192810
2497         <rdar://problem/46812536>
2498
2499         Reviewed by Alex Christensen.
2500
2501         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2502         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2503             After releasing our reference to the web view, wait until the next turn of the runloop
2504             before checking that the originatingWebView has been zeroed, since the web view might
2505             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
2506             testing general memory management of WKWebViews, only that _WKDownload does not retain
2507             its web view via the 'originatingWebView' property.
2508
2509 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
2510
2511         Clean up IndexedDB files between tests
2512         https://bugs.webkit.org/show_bug.cgi?id=192796
2513
2514         Reviewed by Geoffrey Garen.
2515
2516         * DumpRenderTree/mac/DumpRenderTree.mm:
2517         (runTest):
2518         * WebKitTestRunner/TestController.cpp:
2519         (WTR::TestController::resetStateToConsistentValues):
2520         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2521         (WTR::RemoveAllIndexedDatabasesCallback):
2522         (WTR::TestController::ClearIndexedDatabases):
2523         * WebKitTestRunner/TestController.h:
2524
2525 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2526
2527         Fix API test introduced in r239339 on iOS.
2528         https://bugs.webkit.org/show_bug.cgi?id=192675
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2531         (TEST):
2532         The iOS implementation of the safe browsing warning is a little different.
2533         It does some element creation when it is added to the window so it knows how big it is.
2534         To test these elements, we need to simulate adding it to the window.
2535         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
2536
2537 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
2538
2539         webkitpy: Ignore device type for test when using --force
2540         https://bugs.webkit.org/show_bug.cgi?id=192786
2541         <rdar://problem/46794894>
2542
2543         Reviewed by Daniel Bates.
2544
2545         It is sometimes the case that a contributor will wish to run a test on a specific device,
2546         despite expectations which indicate a test should not be run on that device.
2547
2548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2549         (parse_args):
2550         * Scripts/webkitpy/port/device_port.py:
2551         (DevicePort.default_child_processes): Strip device type information when using --force.
2552         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
2553
2554 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2555
2556         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
2557         https://bugs.webkit.org/show_bug.cgi?id=192675
2558
2559         Reviewed by Geoffrey Garen.
2560
2561         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2562         (goBack):
2563         (TEST):
2564         (visitUnsafeSite):
2565         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
2566         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2567
2568 2018-12-18  Chris Dumez  <cdumez@apple.com>
2569
2570         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
2571         https://bugs.webkit.org/show_bug.cgi?id=192772
2572
2573         Reviewed by Antti Koivisto.
2574
2575         Add API test coverage.
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2578
2579 2018-12-18  Philippe Normand  <pnormand@igalia.com>
2580
2581         Unreviewed, JHBuild GTK build fix attempt
2582
2583         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
2584         There's no ninja module either, it should be provided by the
2585         host system.
2586
2587 2018-12-17  Chris Dumez  <cdumez@apple.com>
2588
2589         Allow passing nil as session state to [WKWebView _restoreSessionState:]
2590         https://bugs.webkit.org/show_bug.cgi?id=192789
2591         <rdar://problem/46755277>
2592
2593         Reviewed by Alex Christensen.
2594
2595         Add API test coverage.
2596
2597         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2598         (TEST):
2599
2600 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
2601
2602         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
2603         https://bugs.webkit.org/show_bug.cgi?id=192780
2604         rdar://problem/43394387
2605
2606         Reviewed by Tim Horton.
2607
2608         No need to set "AppleFontSmoothing" defaults for WK2.
2609
2610         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2611         (WTR::InjectedBundle::platformInitialize):
2612
2613 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
2614
2615         webkitpy: Handle case where stdout and stderr don't accept unicode
2616         https://bugs.webkit.org/show_bug.cgi?id=192775
2617         <rdar://problem/46497303>
2618
2619         Reviewed by Stephanie Lewis.
2620
2621         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2622         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
2623         characters with '?'.
2624         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2625         (RegularTest.test_stream_with_encoding):
2626
2627 2018-12-17  Daniel Bates  <dabates@apple.com>
2628
2629         Support concatenating StringView with other string types
2630         https://bugs.webkit.org/show_bug.cgi?id=177566
2631
2632         Reviewed by Darin Adler.
2633
2634         Add some tests to ensure we do not regress the number of allocations needed when performing
2635         string concatenation with string views.
2636
2637         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2638         (TestWebKitAPI::TEST):
2639
2640 2018-12-17  Commit Queue  <commit-queue@webkit.org>
2641
2642         Unreviewed, rolling out r239265 and r239274.
2643         https://bugs.webkit.org/show_bug.cgi?id=192765
2644
2645         unorm_normalize is deprecated, and broke an internal build
2646         (Requested by Truitt on #webkit).
2647
2648         Reverted changesets:
2649
2650         "[GTK][WPE] Need a function to convert internal URI to display
2651         ("pretty") URI"
2652         https://bugs.webkit.org/show_bug.cgi?id=174816
2653         https://trac.webkit.org/changeset/239265
2654
2655         "Fix the Apple Internal Mac build with a newer SDK"
2656         https://trac.webkit.org/changeset/239274
2657
2658 2018-12-17  Daniel Bates  <dabates@apple.com>
2659
2660         Implement UIScriptController::toggleCapsLock() for iOS
2661         https://bugs.webkit.org/show_bug.cgi?id=191815
2662
2663         Reviewed by Andy Estes.
2664
2665         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
2666
2667         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2668         * WebKitTestRunner/TestController.cpp:
2669         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
2670         before running a test. This ensures that the caps lock state does not persist between
2671         tests should a test enable caps lock and not disable it.
2672         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2673         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
2674         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2675         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
2676         create the event. Also substituted NSString* for const String& as the data type for the first
2677         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
2678         below.
2679         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
2680         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
2681
2682 2018-12-17  Daniel Bates  <dabates@apple.com>
2683
2684         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
2685         https://bugs.webkit.org/show_bug.cgi?id=192633
2686
2687         Reviewed by Wenson Hsieh.
2688
2689         Update code to use the modern initializer.
2690
2691         * DumpRenderTree/mac/EventSendingController.mm:
2692         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2693
2694 2018-12-17  Matt Lewis  <jlewis3@apple.com>
2695
2696         Unreviewed, rolling out r239254.
2697
2698         This broke the Windows 10 Debug build
2699
2700         Reverted changeset:
2701
2702         "Replace many uses of String::format with more type-safe
2703         alternatives"
2704         https://bugs.webkit.org/show_bug.cgi?id=192742
2705         https://trac.webkit.org/changeset/239254
2706
2707 2018-12-17  David Kilzer  <ddkilzer@apple.com>
2708
2709         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
2710         <https://webkit.org/b/192751>
2711         <rdar://problem/46771623>
2712
2713         Reviewed by Daniel Bates.
2714
2715         Change loop variables to const references to avoid unnecessary
2716         copies.
2717
2718         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2719         (-[LocalPasteboard pasteboardItems]):
2720
2721 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
2722
2723         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2724         https://bugs.webkit.org/show_bug.cgi?id=174816
2725
2726         Reviewed by Michael Catanzaro.
2727
2728         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
2729
2730         * TestWebKitAPI/CMakeLists.txt:
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2735         (testURIForDisplayUnaffected):
2736         (testURIForDisplayAffected):
2737         (beforeAll):
2738         (afterAll):
2739         * TestWebKitAPI/glib/CMakeLists.txt:
2740
2741 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2742
2743         [WPE] Add API to notify about frame displayed view backend callback
2744         https://bugs.webkit.org/show_bug.cgi?id=192224
2745
2746         Reviewed by Michael Catanzaro.
2747
2748         Add a test case to check the new API.
2749
2750         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2751         (testWebViewFrameDisplayed):
2752         (beforeAll):
2753         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
2754
2755 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
2756
2757         Unreviewed build fix after r239253
2758
2759         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
2760
2761 2018-12-15  Darin Adler  <darin@apple.com>
2762
2763         Use warning-ignoring macros more consistently and simply
2764         https://bugs.webkit.org/show_bug.cgi?id=192743
2765
2766         Reviewed by Mark Lam.
2767
2768         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2769         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
2770         * DumpRenderTree/mac/TextInputControllerMac.m:
2771         (-[TextInputController interpretKeyEvents:withSender:]): Use
2772         IGNORE_WARNINGS_BEGIN/END.
2773         * WebKitTestRunner/mac/EventSenderProxy.mm:
2774         (WTR::EventSenderProxy::mouseForceClick): Use
2775         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
2776         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
2777         (WTR::EventSenderProxy::mouseForceDown): Ditto.
2778         (WTR::EventSenderProxy::mouseForceUp): Ditto.
2779         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
2780
2781 2018-12-15  Darin Adler  <darin@apple.com>
2782
2783         Replace many uses of String::format with more type-safe alternatives
2784         https://bugs.webkit.org/show_bug.cgi?id=192742
2785
2786         Reviewed by Mark Lam.
2787
2788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2789         (WTR::cacheTestRunnerCallback): Use makeString.
2790         * WebKitTestRunner/TestController.cpp:
2791         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2792         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2793
2794 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
2795
2796         [WPE][GTK] Add libpsl to JHBuild module sets
2797         https://bugs.webkit.org/show_bug.cgi?id=192740
2798
2799         Reviewed by Michael Catanzaro.
2800
2801         * gtk/jhbuild.modules: Add libpsl module.
2802         * wpe/jhbuild.modules: Ditto.
2803
2804 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
2805
2806         Add a style checker rule for Xcode version macros use
2807         https://bugs.webkit.org/show_bug.cgi?id=192703
2808
2809         Reviewed by Alex Christensen.
2810
2811         * Scripts/webkitpy/style/checkers/cpp.py:
2812         (check_os_version_checks):
2813         (process_line):
2814         (CppChecker):
2815         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2816         (WebKitStyleTest.test_os_version_checks):
2817
2818 2018-12-14  Chris Dumez  <cdumez@apple.com>
2819
2820         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
2821         https://bugs.webkit.org/show_bug.cgi?id=192704
2822
2823         Reviewed by Geoffrey Garen.
2824
2825         Extend existing API test to reproduce the problem.
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2828
2829 2018-12-14  Chris Dumez  <cdumez@apple.com>
2830
2831         [PSON] WebsitePolicies are lost on process-swap
2832         https://bugs.webkit.org/show_bug.cgi?id=192694
2833         <rdar://problem/46715748>
2834
2835         Reviewed by Brady Eidson.
2836
2837         Extend existing API test to reproduce the issue.
2838
2839         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2840
2841 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2842
2843         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
2844         https://bugs.webkit.org/show_bug.cgi?id=192678
2845
2846         Reviewed by Carlos Garcia Campos.
2847
2848         Update our ancient versions of libsoup and glib-networking.
2849
2850         * gtk/install-dependencies:
2851         * gtk/jhbuild.modules:
2852         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
2853         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
2854         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
2855         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2856         * wpe/install-dependencies:
2857         * wpe/jhbuild.modules:
2858         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2859
2860 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         [WPE] Use new view state API from libwpe
2863         https://bugs.webkit.org/show_bug.cgi?id=191906
2864
2865         Reviewed by Žan Doberšek.
2866
2867         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2868         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
2869         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2870         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
2871         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2872         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2873         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
2874         wpe_view_activity_state_focused state flags.
2875         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
2876         * wpe/backends/HeadlessViewBackend.cpp:
2877         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
2878         * wpe/backends/WindowViewBackend.cpp:
2879         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
2880         received in configure callback.
2881         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
2882
2883 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2884
2885         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
2886         https://bugs.webkit.org/show_bug.cgi?id=192688
2887
2888         Reviewed by Ross Kirsling.
2889
2890         * win/DLLLauncher/DLLLauncherMain.cpp:
2891         (copyEnvironmentVariable): Moved.
2892         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
2893         (applePathFromRegistry): Ditto.
2894         (appleApplicationSupportDirectory): Ditto.
2895         (prependPath): Ditto.
2896
2897 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
2898
2899         Unreviewed. Changed my status to a reviewer.
2900
2901         * Scripts/webkitpy/common/config/contributors.json:
2902
2903 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2904
2905         [iOS] Support dropping contact card data (public.vcard) in editable content
2906         https://bugs.webkit.org/show_bug.cgi?id=192570
2907         <rdar://problem/35626913>
2908
2909         Reviewed by Tim Horton.
2910
2911         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2912
2913         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
2914         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
2915         additionally inserts a link).
2916
2917         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2918         (TestWebKitAPI::createMapItemForTesting):
2919         (TestWebKitAPI::createContactItemForTesting):
2920
2921         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
2922         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
2923         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
2924         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
2925         files.
2926
2927 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
2928
2929         Unreviewed -- update my status to "reviewer".
2930
2931         * Scripts/webkitpy/common/config/contributors.json:
2932
2933 2018-12-13  Youenn Fablet  <youenn@apple.com>
2934
2935         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
2936         https://bugs.webkit.org/show_bug.cgi?id=192657
2937
2938         Reviewed by Eric Carlson.
2939
2940         Add a test that loads a page registering ondevicechange,
2941         load another page in the same process, closes the first page.
2942         Ensure that the process does not crash in that case.
2943
2944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2945         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2946         (TestWebKitAPI::TEST):
2947         (TestWebKitAPI::didCrashCallback):
2948         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
2949
2950 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2951
2952         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
2953         https://bugs.webkit.org/show_bug.cgi?id=192643
2954
2955         Reviewed by Philippe Normand.
2956
2957         This problem happens with Arch Linux users which have libfdk-2.0.0
2958         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
2959
2960         The problem has already been solved upstream at
2961         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
2962
2963         Adding patches while this problem is not in a release yet.
2964
2965         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
2966         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
2967         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
2968
2969 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         [FreeType] Add initial implementation of variation fonts
2972         https://bugs.webkit.org/show_bug.cgi?id=192151
2973
2974         Reviewed by Michael Catanzaro.
2975
2976         Add cairo patch to avoid crashes.
2977
2978         * gtk/jhbuild.modules:
2979         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2980
2981 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2982
2983         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
2984         https://bugs.webkit.org/show_bug.cgi?id=192618
2985
2986         Reviewed by Alex Christensen.
2987
2988         * DumpRenderTree/win/DRTDataObject.cpp:
2989         * DumpRenderTree/win/DRTDataObject.h:
2990         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2991         * DumpRenderTree/win/DRTDropSource.h:
2992         * DumpRenderTree/win/EditingDelegate.h:
2993         * DumpRenderTree/win/PolicyDelegate.h:
2994         * DumpRenderTree/win/UIDelegate.h:
2995
2996 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
2997
2998         Make TextInputController.legacyAttributedString take DOM nodes and offsets
2999         https://bugs.webkit.org/show_bug.cgi?id=192653
3000
3001         Reviewed by Wenson Hsieh.
3002
3003         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3004         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3005         shadow boundaries.
3006
3007         * DumpRenderTree/mac/TextInputControllerMac.m:
3008         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3009         (+[TextInputController webScriptNameForSelector:]): Ditto.
3010         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3011         start node and offset then end node and offset pairs.
3012
3013 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3014
3015         Implement safe browsing in WebKit on WatchOS
3016         https://bugs.webkit.org/show_bug.cgi?id=192641
3017         <rdar://problem/46376188>
3018
3019         Reviewed by Geoff Garen.
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3022         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3023         (safeBrowsingView):
3024         Add a test that the new delegate callback is called.
3025
3026 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3027
3028         Unreviewed manual rollout of r239100-r239102 and r239116
3029         https://bugs.webkit.org/show_bug.cgi?id=192151
3030         <rdar://problem/46655586>
3031
3032         * gtk/jhbuild.modules:
3033         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3034
3035 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3036
3037         Unreviewed, rolling out r239103.
3038         https://bugs.webkit.org/show_bug.cgi?id=192627
3039
3040         It broke the built because it depends on another patch that
3041         didn't land yet (Requested by KaL on #webkit).
3042
3043         Reverted changeset:
3044
3045         "[WPE] Add API to notify about frame displayed view backend
3046         callback"
3047         https://bugs.webkit.org/show_bug.cgi?id=192224
3048         https://trac.webkit.org/changeset/239103
3049
3050 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3051
3052         [WPE] Add API to notify about frame displayed view backend callback
3053         https://bugs.webkit.org/show_bug.cgi?id=192224
3054
3055         Reviewed by Michael Catanzaro.
3056
3057         Add a test case to check the new API.
3058
3059         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3060         (testWebViewFrameDisplayed):
3061         (beforeAll):
3062
3063 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         [FreeType] Add initial implementation of variation fonts
3066         https://bugs.webkit.org/show_bug.cgi?id=192151
3067
3068         Reviewed by Michael Catanzaro.
3069
3070         Add cairo patch to avoid crashes.
3071
3072         * gtk/jhbuild.modules:
3073         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3074
3075 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3076
3077         Implement feature flag for CSS Typed OM
3078         https://bugs.webkit.org/show_bug.cgi?id=192610
3079
3080         Reviewed by Ryosuke Niwa.
3081
3082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3083
3084 2018-12-11  Chris Dumez  <cdumez@apple.com>
3085
3086         Unreviewed, fix bad check in API test added in r239080.
3087
3088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3089
3090 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3091
3092         [Win][Clang] Fix warning -Wmissing-field-initializers
3093         https://bugs.webkit.org/show_bug.cgi?id=192584
3094
3095         Reviewed by Yusuke Suzuki.
3096
3097         Initialize a struct with '{ }' instead of '= {0}'.
3098
3099         * DumpRenderTree/win/DumpRenderTree.cpp:
3100         (runTest):
3101         * DumpRenderTree/win/EventSender.cpp:
3102         (makeMsg):
3103         (replaySavedEvents):
3104         (beginDragWithFilesCallback):
3105         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3106         (createBitmapContextFromWebView):
3107         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3108         (updateMenuItemForHistoryItem):
3109         * MiniBrowser/win/WinMain.cpp:
3110         (wWinMain):
3111         * TestWebKitAPI/win/HostWindow.cpp:
3112         (TestWebKitAPI::HostWindow::clientRect const):
3113         (TestWebKitAPI::HostWindow::registerWindowClass):
3114         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3115         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3116         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3117         (WTR::registerWindowClass):
3118         (WTR::PlatformWebView::windowFrame):
3119         (WTR::PlatformWebView::windowSnapshotImage):
3120
3121 2018-12-11  Chris Dumez  <cdumez@apple.com>
3122
3123         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3124         https://bugs.webkit.org/show_bug.cgi?id=192482
3125         <rdar://problem/46470145>
3126
3127         Reviewed by Antti Koivisto.
3128
3129         Add API test coverage.
3130
3131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3132
3133 2018-12-11  Andy Estes  <aestes@apple.com>
3134
3135         Introduce makeBlockPtr for lambdas
3136         https://bugs.webkit.org/show_bug.cgi?id=192594
3137
3138         Reviewed by Alex Christensen.
3139
3140         Adopted makeBlockPtr and added API tests.
3141
3142         * DumpRenderTree/TestRunner.cpp:
3143         (TestRunner::callUIScriptCallback):
3144         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3145         (TestWebKitAPI::TEST):
3146         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3147         (-[DownloadProgressTestRunner init]):
3148         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3149
3150 2018-12-11  Chris Dumez  <cdumez@apple.com>
3151
3152         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3153         https://bugs.webkit.org/show_bug.cgi?id=192361
3154         <rdar://problem/46524903>
3155
3156         Reviewed by Alex Christensen.
3157
3158         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3159         fixes the failures for me locally.
3160
3161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3162
3163 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3164
3165         Unreviewed, WPE build fix after r239028
3166
3167         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3168
3169         Traceback (most recent call last):
3170         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3171           sys.exit(WebkitFlatpak.load_from_args().run())
3172         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3173           if not self.clean_args():
3174         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3175           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3176         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3177           raise KeyError(key)
3178         KeyError: 'FLATPAK_USER_DIR'
3179
3180         * flatpak/flatpakutils.py:
3181         (WebkitFlatpak.clean_args):
3182
3183 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3184
3185         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3186         https://bugs.webkit.org/show_bug.cgi?id=192573
3187
3188         Reviewed by Simon Fraser.
3189
3190         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3191
3192 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3193
3194         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3195         https://bugs.webkit.org/show_bug.cgi?id=192574
3196
3197         Reviewed by Michael Catanzaro.
3198
3199         * Scripts/webkitperl/FeatureList.pm:
3200
3201 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3202
3203         Sync FeatureList.pm
3204         https://bugs.webkit.org/show_bug.cgi?id=192565
3205
3206         Reviewed by Michael Catanzaro.
3207
3208         * Scripts/webkitperl/FeatureList.pm:
3209
3210 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3211
3212         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3213         https://bugs.webkit.org/show_bug.cgi?id=192555
3214         <rdar://problem/35204990>
3215
3216         Reviewed by Tim Horton.
3217
3218         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3219         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3220         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3221         inputs, or be exposed as files on DataTransfer.
3222
3223         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3224         (TestWebKitAPI::TEST):
3225
3226 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3227
3228         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3229         <https://webkit.org/b/192481>
3230         <rdar://problem/46539059>
3231
3232         Follow-up to address Darin's feedback.
3233
3234         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3235         (WTR::TestRunner::shouldDumpPixels const):
3236         (WTR::TestRunner::whatToDump const):
3237         (WTR::TestRunner::shouldWaitUntilDone const):
3238         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3239         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3240         (WTR::TestRunner::secureEventInputIsEnabled const):
3241         (WTR::TestRunner::isStatisticsPrevalentResource):
3242         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3243         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3244         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3245         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3246         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3247         (WTR::TestRunner::isStatisticsGrandfathered):
3248         (WTR::TestRunner::hasDOMCache):
3249         (WTR::TestRunner::keyExistsInKeychain):
3250
3251 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3252
3253         webkitpy: Ref tests don't respect platform specific expectations
3254         https://bugs.webkit.org/show_bug.cgi?id=192515
3255         <rdar://problem/46564839>
3256
3257         Reviewed by Lucas Forschler.
3258
3259         * Scripts/webkitpy/port/base.py:
3260         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3261         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3262         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3263         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3264         search all platform expectations as well.
3265         * Scripts/webkitpy/port/base_unittest.py:
3266         (test_ref_tests_platform_directory):
3267
3268 2018-12-10  Chris Dumez  <cdumez@apple.com>
3269
3270         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
3271         https://bugs.webkit.org/show_bug.cgi?id=192509
3272         <rdar://problem/46500832>
3273
3274         Reviewed by Alex Christensen.
3275
3276         Add API test coverage.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3279         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
3280         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3281         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
3282         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3283         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
3284
3285 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3286
3287         [iOS] Caret is obscured by finger when dragging over an editable element
3288         https://bugs.webkit.org/show_bug.cgi?id=192499
3289         <rdar://problem/46570101>
3290
3291         Reviewed by Tim Horton.
3292
3293         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
3294
3295         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3296         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3297         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3298         (-[DragAndDropSimulator _resetSimulatedState]):
3299         (-[DragAndDropSimulator lastKnownDropProposal]):
3300
3301         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
3302
3303         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3304         (-[DragAndDropSimulator _advanceProgress]):
3305         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
3306         (-[DragAndDropSimulator showCustomActionSheetBlock]):
3307         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
3308         (-[DragAndDropSimulator convertItemProvidersBlock]):
3309         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
3310         (-[DragAndDropSimulator overridePerformDropBlock]):
3311         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
3312         (-[DragAndDropSimulator overrideDragUpdateBlock]):
3313         (-[DragAndDropSimulator setDropCompletionBlock:]):
3314         (-[DragAndDropSimulator dropCompletionBlock]):
3315
3316         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
3317         `BlockPtr` instance variables to manage the lifetimes of these blocks.
3318
3319         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
3320         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
3321
3322         Update this to use the new WebKit delegate hook for overriding the drop proposal.
3323
3324 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3325
3326         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
3327         https://bugs.webkit.org/show_bug.cgi?id=190241
3328
3329         Reviewed by Carlos Garcia Campos.
3330
3331         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
3332         Currently this actually creates the directories needed for the flatpak environment. Fix it.
3333
3334         * flatpak/flatpakutils.py:
3335         (WebkitFlatpak.clean_args):
3336         (WebkitFlatpak.run):
3337
3338 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3339
3340         [GTK] Don't use the slice allocator
3341         https://bugs.webkit.org/show_bug.cgi?id=192360
3342
3343         Reviewed by Carlos Garcia Campos.
3344
3345         * MiniBrowser/gtk/main.c:
3346         (aboutDataRequestFree):
3347         (aboutDataRequestNew):
3348
3349 2018-12-10  Tim Horton  <timothy_horton@apple.com>
3350
3351         WKWebView should support custom tintColor
3352         https://bugs.webkit.org/show_bug.cgi?id=192518
3353         <rdar://problem/37243261>
3354
3355         Reviewed by Wenson Hsieh.
3356
3357         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
3358         (TestWebKitAPI::TEST):
3359         Add a test that tintColor affects UITextInputTraits' interaction colors.
3360
3361 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3362
3363         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
3364         https://bugs.webkit.org/show_bug.cgi?id=192524
3365
3366         Reviewed by Ryosuke Niwa.
3367
3368         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
3369         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
3370         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
3371         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
3372         wide selection rect and increases the width of the document; revealing this selection causes the web view to
3373         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
3374         these window coordinates no longer correspond to the drop destination element in the document.
3375
3376         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
3377         scroll horizontally after the first drop.
3378
3379         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
3380
3381 2018-12-08  Daniel Bates  <dabates@apple.com>
3382
3383         Fix lldb_webkit.py following r238771
3384         (https://bugs.webkit.org/show_bug.cgi?id=190234)
3385
3386         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
3387         missed in r238771.
3388
3389         * lldb/lldb_webkit.py:
3390         (WebCoreDocumentProvider.url):
3391
3392 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3393
3394         [ews-build] check-patch-relevance failure should not mark the overall build as failure
3395         https://bugs.webkit.org/show_bug.cgi?id=192510
3396
3397         Reviewed by Lucas Forschler.
3398
3399         * BuildSlaveSupport/ews-build/steps.py:
3400         (CheckPatchRelevance.start):
3401
3402 2018-12-07  Chris Dumez  <cdumez@apple.com>
3403
3404         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3405         https://bugs.webkit.org/show_bug.cgi?id=192362
3406         <rdar://problem/46460360>
3407
3408         Reviewed by Ryosuke Niwa.
3409
3410         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
3411         *after* we know for sure we have a network process to communicate the policy to.
3412         This should address the failures on iOS.
3413
3414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3415
3416 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
3417
3418         Add keychain access entitlement to WebKitTestRunnerApp
3419         https://bugs.webkit.org/show_bug.cgi?id=192489
3420         <rdar://problem/45057952>
3421
3422         Reviewed by Alexey Proskuryakov.
3423
3424         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
3425
3426 2018-12-07  Saam Barati  <sbarati@apple.com>
3427
3428         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
3429         https://bugs.webkit.org/show_bug.cgi?id=192473
3430
3431         Reviewed by Andy Estes.
3432
3433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3434         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
3435         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
3436         (TEST):
3437         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
3438         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3439         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
3440         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
3441         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
3442
3443 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
3444
3445         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
3446         https://bugs.webkit.org/show_bug.cgi?id=192470
3447         <rdar://problem/46532001>
3448
3449         Unreviewed infrastructure fix.
3450
3451         * Scripts/webkitpy/port/device_port.py:
3452         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
3453         number of child processes.
3454
3455 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3456
3457         [ews-app] Send bug id as a build property
3458         https://bugs.webkit.org/show_bug.cgi?id=192494
3459
3460         Reviewed by Lucas Forschler.
3461
3462         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3463         (BugzillaPatchFetcher.fetch):
3464
3465 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3466
3467         [ews-build] Builds should have a link to patch and bug
3468         https://bugs.webkit.org/show_bug.cgi?id=192492
3469
3470         Reviewed by Lucas Forschler.
3471
3472         * BuildSlaveSupport/ews-build/steps.py:
3473         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
3474         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
3475         (ConfigureBuild.getPatchURL): Method to get Patch URL.
3476         (ConfigureBuild.getBugURL): Method to get Bug URL.
3477
3478 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3479
3480         [ews-app] Configure logfile for ews-app logs
3481         https://bugs.webkit.org/show_bug.cgi?id=192493
3482
3483         Reviewed by Lucas Forschler.
3484
3485         * BuildSlaveSupport/ews-app/ews/__init__.py:
3486
3487 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3488
3489         Style queue exception on some security bugs
3490         https://bugs.webkit.org/show_bug.cgi?id=190793
3491
3492         Reviewed by Lucas Forschler.
3493
3494         * Scripts/webkitpy/tool/steps/applywatchlist.py:
3495         (ApplyWatchList.run):
3496
3497 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3498
3499         [Attachment Support] Cloned attachment elements lose their unique identifiers
3500         https://bugs.webkit.org/show_bug.cgi?id=192483
3501
3502         Reviewed by Tim Horton.
3503
3504         Introduce a new API test.
3505
3506         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3507         (TestWebKitAPI::TEST):
3508
3509 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3510
3511         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
3512         https://bugs.webkit.org/show_bug.cgi?id=192486
3513
3514         Unreviewed infrastructure fix.
3515
3516         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
3517
3518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3519         (_set_up_derived_options):
3520
3521 2018-12-06  David Kilzer  <ddkilzer@apple.com>
3522
3523         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3524         <https://webkit.org/b/192481>
3525         <rdar://problem/46539059>
3526
3527         Reviewed by Simon Fraser.
3528
3529         This patch:
3530         - Fixes leaks in various injected bundle methods that return +1
3531           retained WKTypeRef objects via pointer.
3532         - Asserts the returned object is the expected WKTypeRef.
3533         - Replaces 0 with nullptr in many places.
3534
3535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3536         (WTR::InjectedBundle::didCreatePage):
3537         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3538         (WTR::TestRunner::shouldDumpPixels const):
3539         (WTR::TestRunner::whatToDump const):
3540         (WTR::TestRunner::shouldWaitUntilDone const):
3541         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3542         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3543         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3544         (WTR::TestRunner::secureEventInputIsEnabled const):
3545         (WTR::TestRunner::isStatisticsPrevalentResource):
3546         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3547         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3548         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3549         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3550         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3551         (WTR::TestRunner::isStatisticsGrandfathered):
3552         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3553         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3554         (WTR::TestRunner::statisticsSubmitTelemetry):
3555         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3556         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3557         (WTR::TestRunner::statisticsResetToConsistentState):
3558         (WTR::TestRunner::getAllStorageAccessEntries):
3559         (WTR::TestRunner::hasDOMCache):
3560         (WTR::TestRunner::domCacheSize):
3561         (WTR::TestRunner::injectUserScript):
3562         (WTR::TestRunner::keyExistsInKeychain):
3563
3564 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3565
3566         REGRESSION: run-webkit-tests may fail when using booted simulators
3567         https://bugs.webkit.org/show_bug.cgi?id=192470
3568         <rdar://problem/46532001>
3569
3570         Reviewed by Lucas Forschler.
3571
3572         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3573         (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
3574         were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
3575         * Scripts/webkitpy/port/base.py:
3576         (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
3577         * Scripts/webkitpy/port/device_port.py:
3578         (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
3579         child processes are being used, check the device manager every time. Regardless of which devices are attached or
3580         available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
3581         device_count_for_type, use use_booted_simulator instead.
3582         (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
3583         but, if no devices are available, then max_child_processes should return 0 even for simulators.
3584         * Scripts/webkitpy/port/ios_device_unittest.py:
3585         (IOSDeviceTest):
3586         (IOSDeviceTest.test_max_child_processes):
3587         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3588         (IOSSimulatorTest):
3589         (IOSSimulatorTest.test_max_child_processes):
3590         * Scripts/webkitpy/port/port_testcase.py:
3591         (PortTestCase):
3592         (PortTestCase.test_max_child_processes):
3593         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3594         (WatchSimulatorTest):
3595         (WatchSimulatorTest.test_max_child_processes):
3596
3597 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3598
3599         webkitpy: Ignore case when comparing device types (Follow-up fix)
3600         https://bugs.webkit.org/show_bug.cgi?id=192409
3601         <rdar://problem/46491558>
3602
3603         Unreviewed typo fix.
3604
3605         * Scripts/webkitpy/xcode/device_type_unittest.py:
3606         (DeviceTypeTest.test_comparison_lower_case):
3607         (DeviceTypeTest.test_comparsion_lower_case): Deleted.
3608
3609 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3610
3611         webkitpy: Create device given lower-case DeviceType
3612         <https://bugs.webkit.org/show_bug.cgi?id=192472>
3613         <rdar://problem/46532650>
3614
3615         Reviewed by Lucas Forschler.
3616
3617         * Scripts/webkitpy/xcode/simulated_device.py:
3618         (SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
3619         should be letter-case agnostic.
3620         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3621         (test_lower_case_device_type):
3622
3623 2018-12-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3624
3625         [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
3626         https://bugs.webkit.org/show_bug.cgi?id=187554
3627         <rdar://problem/42075638>
3628
3629         Reviewed by Tim Horton.
3630
3631         Add support for simulating the keyboard input mode in layout tests using UIScriptController, as well as a new
3632         `TestOption` to make the web view editable.
3633
3634         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3635         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3636         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3637         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3638         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3639         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3640         * WebKitTestRunner/PlatformWebView.h:
3641         * WebKitTestRunner/TestController.cpp:
3642         (WTR::updateTestOptionsFromTestHeader):
3643         * WebKitTestRunner/TestController.h:
3644         (WTR::TestController::overriddenKeyboardInputMode const):
3645         * WebKitTestRunner/TestOptions.h:
3646         (WTR::TestOptions::hasSameInitializationOptions const):
3647         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3648         (WTR::TestController::platformCreateWebView):
3649         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3650         (WTR::PlatformWebView::setEditable):
3651         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3652         (WTR::PlatformWebView::setEditable):
3653         * WebKitTestRunner/ios/TestControllerIOS.mm:
3654         (WTR::TestController::platformResetStateToConsistentValues):
3655         (WTR::swizzleCurrentInputMode):
3656         (WTR::TestController::setKeyboardInputModeIdentifier):
3657
3658         Swizzle out several `UIKeyboardInputModeController` methods in order to convince UIKit that the user has
3659         selected a `UIKeyboardInputMode` corresponding to the given identifier. The call to
3660         `-prepareKeyboardInputModeFromPreferences:` is also necessary on iOS 12 in order to update cached writing
3661         direction state in UIKit.
3662
3663         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3664         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3665         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3666         (WTR::PlatformWebView::setEditable):
3667         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3668         (WTR::PlatformWebView::setEditable):
3669         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3670         (WTR::PlatformWebView::setEditable):
3671
3672 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3673
3674         [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
3675         https://bugs.webkit.org/show_bug.cgi?id=192437
3676
3677         Reviewed by Tim Horton.
3678
3679         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3680         * TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
3681         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
3682         (ClassMethodSwizzler::ClassMethodSwizzler):
3683         (ClassMethodSwizzler::~ClassMethodSwizzler):
3684         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
3685         * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
3686         (InstanceMethodSwizzler::InstanceMethodSwizzler):
3687         (InstanceMethodSwizzler::~InstanceMethodSwizzler):
3688
3689         Move these swizzling helper classes into TestRunnerShared.
3690
3691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3692         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3693         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3694         (safeBrowsingView):
3695         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
3696         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3697         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3698
3699         Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.
3700
3701         * TestWebKitAPI/mac/TestFontOptions.mm:
3702         * WebKitTestRunner/TestController.h:
3703         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3704         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3705         (WTR::ClassMethodSwizzler::ClassMethodSwizzler): Deleted.
3706         (WTR::ClassMethodSwizzler::~ClassMethodSwizzler): Deleted.
3707
3708         Remove this duplicate implementation of ClassMethodSwizzler in WebKitTestRunner.
3709
3710 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3711
3712         webkitpy: Clean-up apple_additions
3713         https://bugs.webkit.org/show_bug.cgi?id=192413
3714         <rdar://problem/46493491>
3715
3716         Reviewed by Lucas Forschler.
3717
3718         After the addition of watchOS, some functions which were originally iOS specific were
3719         generalized to include all devices.
3720
3721         * Scripts/webkitpy/port/ios_device.py:
3722         (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
3723         (IOSDevicePort.path_to_crash_logs): Ditto.
3724         (IOSDevicePort.clean_up_test_run): Ditto.
3725
3726 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3727
3728         webkitpy: Ignore case when comparing device types
3729         https://bugs.webkit.org/show_bug.cgi?id=192409
3730         <rdar://problem/46491558>
3731
3732         Reviewed by Lucas Forschler.
3733
3734         This allows DeviceTypes constructed with lowercase strings to correctly compare
3735         against DeviceTypes coming from the simulator runtime.
3736
3737         * Scripts/webkitpy/xcode/device_type.py:
3738         (DeviceType.__eq__):
3739         (DeviceType.__contains__):
3740         * Scripts/webkitpy/xcode/device_type_unittest.py:
3741         (DeviceTypeTest):
3742         (DeviceTypeTest.test_comparsion_lower_case):
3743
3744 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3745
3746         webkitpy: Sort tests by associated device type
3747         https://bugs.webkit.org/show_bug.cgi?id=192161
3748         <rdar://problem/46345392>
3749
3750         Reviewed by Lucas Forschler.
3751
3752         Sort tests by device type and make an effort to run each specified device type.
3753         Do not run tests if their specified device is not available.
3754
3755         * Scripts/webkitpy/common/system/platforminfo.py:
3756         (PlatformInfo.is_watchos): Add watchos bits to platform info.
3757         (PlatformInfo._determine_os_name): Ditto.
3758         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3759         (Manager.run): Assign each test a device type. Then, generate a list of
3760         device types to sequentially iterate through. Note that a test will run
3761         on the first device which matches.
3762         (Manager._end_test_run): Handle the case where no devices are available and no
3763         tests are run.
3764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3765         (_set_up_derived_options): Manage child processes in manager.
3766         * Scripts/webkitpy/port/base.py:
3767         (Port):
3768         (Port.default_child_processes): Accept additional arguments.
3769         (Port.max_child_processes): Add upper limit for number of child processes.
3770         * Scripts/webkitpy/port/device_port.py:
3771         (DevicePort):
3772         (DevicePort._device_type_with_version): Adds version to the DeviceType.
3773         (DevicePort.default_child_processes): Allows default_child_processes to be
3774         attached to a device type.
3775         (DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
3776         (DevicePort.setup_test_run): Use _device_type_with_version.
3777         * Scripts/webkitpy/port/ios_device.py:
3778         (IOSDevicePort):
3779         (IOSDevicePort.default_child_processes): Deleted.
3780         * Scripts/webkitpy/port/ios_simulator.py:
3781         (IOSSimulatorPort.default_child_processes): Deleted.
3782         (IOSSimulatorPort.check_sys_deps): Deleted.
3783         * Scripts/webkitpy/port/mac.py:
3784         (MacPort.default_child_processes): Accept additional arguments.
3785         * Scripts/webkitpy/port/test.py:
3786         * Scripts/webkitpy/port/watch_device.py:
3787         (WatchDevicePort):
3788         (WatchDevicePort.default_child_processes): Deleted.
3789         * Scripts/webkitpy/port/watch_simulator.py:
3790         (WatchSimulatorPort.default_child_processes): Deleted.
3791         (WatchSimulatorPort.check_sys_deps): Deleted.
3792         * Scripts/webkitpy/xcode/simulated_device.py:
3793         (SimulatedDeviceManager):
3794         (SimulatedDeviceManager.device_count_for_type): Count the number of devices
3795         available for a specific device type.
3796
3797 2018-12-05  Devin Rousso  <drousso@apple.com>
3798
3799         Unreviewed, add myself to some watch lists.
3800
3801         * Scripts/webkitpy/common/config/watchlist:
3802
3803 2018-12-05  Alicia Boya García  <aboya@igalia.com>
3804
3805         [MSE][GStreamer] Remove the AppendPipeline state machine
3806         https://bugs.webkit.org/show_bug.cgi?id=192204
3807
3808         Reviewed by Xabier Rodriguez-Calvar.
3809
3810         Updated AbortableTaskQueue tests:
3811
3812         Added test: AbortedBySyncTaskHandler.
3813
3814         Renamed test: AbortDuringSyncTask -> AbortBeforeSyncTaskRun (in
3815         order to avoid confusion with the new test).
3816
3817         Added checks for the correct destruction of response objects.
3818
3819         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
3820         (TestWebKitAPI::FancyResponse::FancyResponse):
3821         (TestWebKitAPI::FancyResponse::~FancyResponse):
3822         (TestWebKitAPI::TEST):
3823
3824 2018-12-04  Chris Dumez  <cdumez@apple.com>
3825
3826         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3827         https://bugs.webkit.org/show_bug.cgi?id=192362
3828
3829         Reviewed by Alex Christensen.
3830
3831         Set the cookie policy to Accept to make sure the cookies are saved.
3832
3833         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3834
3835 2018-12-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3836
3837         [WPE][GTK] Update GLib
3838         https://bugs.webkit.org/show_bug.cgi?id=191222
3839
3840         Reviewed by Žan Doberšek.
3841
3842         When I try running API tests locally, they crash with:
3843
3844         GLib-GIO-WARNING **: unknown schema extension 'd'
3845
3846         We need to update our old glib to support the 'd' value type, otherwise schemas that may
3847         exist on the host using this type will cause instant crashes.
3848
3849         Also, switch the GLib build to use meson. This requires updating meson as well.
3850
3851         * gtk/jhbuild.modules:
3852         * gtk/patches/glib-cast-function-type.patch: Removed.
3853         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Removed.
3854         * wpe/jhbuild.modules:
3855         * wpe/patches/glib-cast-function-type.patch: Removed.
3856         * wpe/patches/glib-revert-wakeup-changes.patch: Removed.
3857
3858 2018-12-04  Aakash Jain  <aakash_jain@apple.com>
3859
3860         [ews-app] Run BugzillaPatchFetcher periodically
3861         https://bugs.webkit.org/show_bug.cgi?id=192241
3862
3863         Reviewed by Lucas Forschler.
3864
3865         * BuildSlaveSupport/ews-app/ews/__init__.py:
3866         * BuildSlaveSupport/ews-app/ews/apps.py:
3867         (EwsConfig.ready): This method is called by Django on startup.
3868         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3869         (FetchLoop): Class which invokes BugzillaPatchFetcher every 60s.
3870
3871 2018-12-04  Jonathan Bedard  <jbedard@apple.com>
3872
3873         webkitpy: Support unicode in MeteredStream
3874         https://bugs.webkit.org/show_bug.cgi?id=192260
3875
3876         Reviewed by Aakash Jain.
3877
3878         It's possible that the test runner returns unicode characters to be logged when
3879         running layout tests.
3880
3881         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3882         (MeteredStream.write): Print message without attempting to encode/decode it.
3883         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3884         (RegularTest.test_unicode):
3885
3886 2018-12-04  Keith Rollin  <krollin@apple.com>
3887
3888         Update scripts for generating .xcfilelist files
3889         https://bugs.webkit.org/show_bug.cgi?id=192081
3890         <rdar://problem/46312290>
3891
3892         Reviewed by Brent Fulgham.
3893
3894         The initial pass at generate-xcfilelists (a script for
3895         creating/updating the .xcfilelist files needed for various Generate
3896         Foo Source build phases in Xcode) only generated the .xcfilelist files
3897         that held the output files; it did not generate the list of input
3898         files. As well, for the sources generated by DerivedSources.make
3899         makefiles, the script accomplished this via the implementation of a
3900         convention in the makefile that allowed the printing of these output
3901         files when invoked with the 'print_all_generated_files' target. Use of
3902         this convention is inconvenient and error-prone.
3903
3904         The script is now updated to address both of these issues. First, it
3905         generates for the input and output sets of files. Second, it does away
3906         with the convention in the DerivedSources.make makefiles and instead
3907         works from the dependency output information printed when `make` is
3908         invoked with --debug. This second part is implemented in the new
3909         script extract-dependencies-from-makefile.
3910
3911         * Scripts/extract-dependencies-from-makefile: Added.
3912         (Parser):
3913         (Parser.__init__):
3914         (Parser.nextLine):
3915         (Parser.addTarget):
3916         (Parser.addPrereq):
3917         (Parser.doParse):
3918         (Parser.printInputs):
3919         (Parser.printOutputs):
3920         (parseArgs):
3921         (main):
3922         * Scripts/generate-xcfilelists:
3923
3924 2018-12-04  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3925
3926         [WPE] Add gtk-doc
3927         https://bugs.webkit.org/show_bug.cgi?id=178900
3928
3929         Reviewed by Michael Catanzaro.
3930
3931         Add gtk-doc to WPE port. This patch tries to reuse as much code from
3932         WebKitGTK+ as possible.
3933
3934         * gtkdoc/generate-gtkdoc: Renamed from Tools/gtk/generate-gtkdoc.
3935         (get_gtkdoc_module_paths): Add GDK and GTK only if building for GTK.
3936         (prepare_environment_for_gtkdoc_generation):
3937         (build_gtkdoc_for_wpe): Code to generate doc for WPE.
3938         (build_gtkdoc_for_wkgtk): Code to generate doc for WebKitGTK+. Moved from main.
3939         * gtkdoc/gtkdoc.py: Renamed from Tools/gtk/gtkdoc.py.
3940         (GTKDoc.__init__): Initialized required variables according to pylint.
3941         (GTKDoc.api_missing_documentation):
3942         * wpe/install-dependencies: Add gtkdoc dependency.
3943
3944 2018-12-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3945
3946         [SOUP] Move URLSoup back to WebCore after r238771
3947         https://bugs.webkit.org/show_bug.cgi?id=192306
3948
3949         Reviewed by Michael Catanzaro.
3950
3951         Include GUniquePtrSoup from WebCore again.
3952
3953         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3954
3955 2018-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3956
3957         [GTK] Bump freetype, fontconfig, harfbuzz, cairo and icu in jhbuild
3958         https://bugs.webkit.org/show_bug.cgi?id=192310
3959
3960         Reviewed by Michael Catanzaro.
3961
3962         Update those dependencies to their latest stable versions.
3963
3964         * gtk/jhbuild.modules:
3965
3966 2018-12-03  Tomas Popela  <tpopela@redhat.com>
3967
3968         [GTK] Can't run MiniBrowser due to missing python2-yaml
3969         https://bugs.webkit.org/show_bug.cgi?id=192308
3970
3971         Reviewed by Michael Catanzaro.
3972
3973         * gtk/install-dependencies:
3974
3975 2018-12-03  Chris Dumez  <cdumez@apple.com>
3976
3977         Regression(PSON) Google OAuth is broken in private sessions
3978         https://bugs.webkit.org/show_bug.cgi?id=192337
3979         <rdar://problem/46353558>
3980
3981         Reviewed by Alex Christensen.
3982
3983         Add API test coverage.
3984
3985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3986         * TestWebKitAPI/Tests/WebKitCocoa/GetSessionCookie.html: Added.
3987         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3988         * TestWebKitAPI/Tests/WebKitCocoa/SetSessionCookie.html: Added.
3989
3990 2018-12-03  Chris Dumez  <cdumez@apple.com>
3991
3992         [PSON] Request by the client to process-swap is ignored if the window has an opener
3993         https://bugs.webkit.org/show_bug.cgi?id=192267
3994         <rdar://problem/46386886>
3995
3996         Reviewed by Brady Eidson.
3997
3998         Add API test coverage.
3999
4000         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4001
4002 2018-12-03  Keith Rollin  <krollin@apple.com>
4003
4004         Add .xcfilelist files
4005         https://bugs.webkit.org/show_bug.cgi?id=192082
4006         <rdar://problem/46312533>
4007
4008         Reviewed by Brent Fulgham.
4009
4010         Add .xcfilelist files for Generate Derived Sources and Generate
4011         Unified Sources build phases in Xcode. These are just being staged for
4012         now; they'll be added to the Xcode projects later.
4013
4014         * DumpRenderTree/DerivedSources-input.xcfilelist: Added.
4015         * DumpRenderTree/DerivedSources-output.xcfilelist: Added.
4016         * WebKitTestRunner/DerivedSources-input.xcfilelist: Added.
4017         * WebKitTestRunner/DerivedSources-output.xcfilelist: Added.
4018
4019 2018-12-03  Alex Christensen  <achristensen@webkit.org>
4020
4021         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
4022         https://bugs.webkit.org/show_bug.cgi?id=192272
4023
4024         Reviewed by Brady Eidson.
4025
4026         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
4027         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]):
4028         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
4029
4030 2018-12-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4031
4032         [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
4033         https://bugs.webkit.org/show_bug.cgi?id=192283
4034         <rdar://problem/46399461>
4035
4036         Reviewed by Ryosuke Niwa.
4037
4038         Add a new API test to check that an item provider which contains plain text data and a file URL (but is not
4039         marked as an attachment) is still treated as an attachment upon drop. Furthermore, verify that "text/uri-list"
4040         does not expose the actual file URL written to the item provider.
4041
4042         Additionally, rebaseline an existing API test to remove an extraneous "text/uri-list" type that appears in
4043         `DataTransfer.types`, but whose data is inaccessible via `getData` anyways.
4044
4045         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4046
4047 2018-12-01  Don Olmstead  <don.olmstead@sony.com>
4048
4049         Cleanup WebKit Features
4050         https://bugs.webkit.org/show_bug.cgi?id=192262
4051
4052         Reviewed by Michael Catanzaro.
4053
4054         Removes obsolete ENABLE options and variable names. Syncs the option's
4055         descriptions with what is present in WebKitFeatures.cmake. Sorts the
4056         options based on the associated define.
4057
4058         * Scripts/webkitperl/FeatureList.pm:
4059
4060 2018-12-01  Chris Dumez  <cdumez@apple.com>
4061
4062         [PSON] process-swapping may occur even though opener has handle to openee
4063         https://bugs.webkit.org/show_bug.cgi?id=192277
4064
4065         Reviewed by Antti Koivisto.
4066
4067         Add API test coverage.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4070
4071 2018-12-01  Jonathan Bedard  <jbedard@apple.com>
4072
4073         Unreviewed, rolling out r238764.
4074
4075         Breaks existing layout tests
4076
4077         Reverted changeset:
4078
4079         "webkitpy: Support unicode in MeteredStream"
4080         https://bugs.webkit.org/show_bug.cgi?id=192260
4081         https://trac.webkit.org/changeset/238764
4082
4083 2018-12-01  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
4084
4085         Move URL tests from TestWebKitAPI to TestWTF
4086         https://bugs.webkit.org/show_bug.cgi?id=192275
4087
4088         Reviewed by Keith Miller.
4089
4090         Since URL is moved from WebCore to WTF, we also move tests for them from TestWebKitAPI (TestWebCore) to TestWTF.
4091         But we still have some tests in TestWebCore since only WebCore implements TextEncoding. That part is now decoupled
4092         from URLParser tests and new URLParserTextEncoding.cpp is created.
4093
4094         * TestWebKitAPI/CMakeLists.txt:
4095         * TestWebKitAPI/PlatformGTK.cmake:
4096         * TestWebKitAPI/PlatformWPE.cmake:
4097         * TestWebKitAPI/PlatformWin.cmake:
4098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4099         * TestWebKitAPI/Tests/WTF/URL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URL.cpp.
4100         (TestWebKitAPI::TEST_F):
4101         * TestWebKitAPI/Tests/WTF/URLParser.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp.
4102         (TestWebKitAPI::TEST_F):
4103         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm.
4104         (TestWebKitAPI::TEST):
4105         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: Added.
4106         (TestWebKitAPI::ExpectedParts::isInvalid const):
4107         (TestWebKitAPI::eq):
4108         (TestWebKitAPI::insertTabAtLocation):
4109         (TestWebKitAPI::invalidParts):
4110         (TestWebKitAPI::checkURL):
4111         (TestWebKitAPI::TEST_F):
4112
4113 2018-11-30  Zalan Bujtas  <zalan@apple.com>
4114
4115         Unreviewed LFC passing test list update.
4116
4117         * LayoutReloaded/misc/LFC-passing-tests.txt:
4118
4119 2018-11-30  Alex Christensen  <achristensen@webkit.org>
4120
4121         Move URL from WebCore to WTF
4122         https://bugs.webkit.org/show_bug.cgi?id=190234
4123
4124         Reviewed by Keith Miller.
4125
4126         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4127         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4128         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4129         (TestWebKitAPI::createURL):
4130         (TestWebKitAPI::TEST_F):
4131         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4132         (TestWebKitAPI::checkURL):
4133         (TestWebKitAPI::checkRelativeURL):
4134         (TestWebKitAPI::checkURLDifferences):
4135         (TestWebKitAPI::checkRelativeURLDifferences):
4136         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4137         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
4138         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4139         (TestWebKitAPI::originalDataAsString):
4140         (TestWebKitAPI::userVisibleString):
4141         (TestWebKitAPI::literalURL):
4142         (TestWebKitAPI::TEST):
4143         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
4144         (TEST):
4145         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
4146         (literalURL):
4147         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4148         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
4149         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4150         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
4151         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4152         (TestWebKitAPI::Util::createURLForResource):
4153         * lldb/lldb_webkit.py:
4154         (__lldb_init_module):
4155         (WTFURL_SummaryProvider):
4156         (WTFURLProvider):
4157         (WebCoreURL_SummaryProvider): Deleted.
4158         (WebCoreURLProvider): Deleted.
4159         (WebCoreURLProvider.__init__): Deleted.
4160         (WebCoreURLProvider.to_string): Deleted.
4161
4162 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4163
4164         webkitpy: Support unicode in MeteredStream
4165         https://bugs.webkit.org/show_bug.cgi?id=192260
4166
4167         Reviewed by Stephanie Lewis.
4168
4169         It's possible that the test runner returns unicode characters to be logged when
4170         running layout tests.
4171
4172         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4173         (MeteredStream.write): Message written to metered stream should be unicode.
4174         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4175         (RegularTest.test_unicode):
4176
4177 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4178
4179         REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
4180         https://bugs.webkit.org/show_bug.cgi?id=192257
4181         <rdar://problem/46384671>
4182
4183         Reviewed by Stephanie Lewis.
4184
4185         Follow-up fix for r238749.
4186
4187         * Scripts/webkitpy/api_tests/manager.py:
4188         (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
4189
4190 2018-11-30  Chris Dumez  <cdumez@apple.com>
4191
4192         [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
4193         https://bugs.webkit.org/show_bug.cgi?id=192242
4194
4195         Reviewed by Geoffrey Garen.
4196
4197         Add API test coverage.
4198
4199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4200
4201 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
4202
4203         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
4204         https://bugs.webkit.org/show_bug.cgi?id=192197
4205
4206         Reviewed by Jiewen Tan.
4207
4208         * Scripts/webkitperl/FeatureList.pm:
4209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4210
4211 2018-11-30  Dean Jackson  <dino@apple.com>
4212
4213         Add first-class support for .mjs files in jsc binary
4214         https://bugs.webkit.org/show_bug.cgi?id=192190
4215         <rdar://problem/46375715>
4216
4217         Reviewed by Keith Miller.
4218
4219         Add .mjs files to the regexp looking for all JS files.
4220
4221         * Scripts/run-jsc-stress-tests:
4222
4223 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4224
4225         webkitpy: Use DeviceType instead of str to represent device class
4226         https://bugs.webkit.org/show_bug.cgi?id=192160
4227         <rdar://problem/46344845>
4228
4229         Rubber-stamped by Aakash Jain.
4230
4231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4232         (Manager._custom_device_for_test): Use DeviceTypes instead of strings to represent device type.
4233         (Manager._set_up_run): Do not set _options.device_class, use device_type instead of device_class.
4234         (Manager.run): Use device_type instead of device_class.
4235         (Manager._print_expectations_for_subset): Ditto.
4236         (Manager.print_expectations): Ditto.
4237         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4238         (ManagerTest.test_uses_custom_device): Use DeviceType and actual device definition.
4239         * Scripts/webkitpy/layout_tests/views/printing.py:
4240         (Printer.print_workers_and_shards): Outputting the device suffix doesn't really help, and means
4241         device type needs to be passed around.
4242         * Scripts/webkitpy/port/apple.py:
4243         (ApplePort.setup_test_run): Use device_type instead of device_class.
4244         * Scripts/webkitpy/port/base.py:
4245         (Port):
4246         (Port.setup_test_run): Use device_type instead of device_class.
4247         * Scripts/webkitpy/port/device_port.py:
4248         (DevicePort):
4249         (DevicePort.setup_test_run): Receive device_type as DeviceType object.
4250         (DevicePort._create_devices): Deleted.
4251         * Scripts/webkitpy/port/gtk.py:
4252         (GtkPort.setup_test_run): Use device_type instead of device_class.
4253         * Scripts/webkitpy/port/ios.py:
4254         (IOSPort):
4255         * Scripts/webkitpy/port/ios_simulator.py:
4256         (IOSSimulatorPort):
4257         (IOSSimulatorPort.__init__): Deleted.
4258         (IOSSimulatorPort._set_device_class): Deleted.
4259         * Scripts/webkitpy/port/test.py:
4260         * Scripts/webkitpy/port/watch.py:
4261         (WatchPort):
4262         * Scripts/webkitpy/port/watch_simulator.py:
4263         (WatchSimulatorPort):
4264         (WatchSimulatorPort.__init__): Deleted.
4265         (WatchSimulatorPort._set_device_class): Deleted.
4266         * Scripts/webkitpy/port/win.py:
4267         (WinPort.setup_test_run): Use device_type instead of device_class.
4268         * Scripts/webkitpy/xcode/simulated_device.py:
4269         (SimulatedDeviceManager._disambiguate_device_type): Using the existing devices for this is
4270         a problem if no such device exists yet. Use the _device_identifier_to_name dictionary instead
4271         since this should have hardware types in the device names.
4272
4273 2018-11-30  David Quesada  <david_quesada@apple.com>
4274
4275         -[WKProcessPool _downloadURLRequest:] should allow specifying the initiating web view
4276         https://bugs.webkit.org/show_bug.cgi?id=192212
4277         rdar://problem/46363706
4278
4279         Reviewed by Alex Christensen.
4280
4281         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4282         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
4283
4284 2018-11-30  Zalan Bujtas  <zalan@apple.com>
4285
4286         [LFC][BFC] Compute min/maxHeight margins only when they are needed.
4287         https://bugs.webkit.org/show_bug.cgi?id=192223
4288
4289         Reviewed by Antti Koivisto.
4290
4291         * LayoutReloaded/misc/LFC-passing-tests.txt:
4292
4293 2018-11-30  Zalan Bujtas  <zalan@apple.com>
4294
4295         [LFC][BFC][MarginCollapsing] Do not use computed display box values for border and padding
4296         ht