Allow a port to run tests with a custom device setup
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2
3         Allow a port to run tests with a custom device setup
4         https://bugs.webkit.org/show_bug.cgi?id=160833
5
6         Reviewed by Daniel Bates.
7
8         These changes allow the IOSSimulator port to run tests in iPad mode.
9
10         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
11         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
12         a custom device will be collected into a set, and run in that device's environment after
13         the other tests have run.
14
15         * Scripts/webkitpy/layout_tests/controllers/manager.py:
16         (Manager._custom_device_for_test): If the test contains a directory matching a
17         custom device suffix, return that custom device.
18         (Manager._set_up_run): Push the custom device class, if any, into options so
19         that the Worker can get to it.
20         (Manager.run): Go through the list of tests, and break it down into device-generic
21         tests, and tests for each device class. _run_test_subset is then called for
22         each collection of tests, and the results merged.
23         (Manager._run_test_subset): Some lines unwrapped.
24         (Manager._end_test_run):
25         (Manager._run_tests):
26         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
27         (SingleTestRunner.__init__): Unwrapped a line.
28         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
29         (TestRunResults.merge): Add this function to merge TestRunResults
30         * Scripts/webkitpy/layout_tests/views/printing.py:
31         (Printer.print_workers_and_shards): Print the custom device, if any.
32         * Scripts/webkitpy/port/base.py:
33         (Port): Base port has empty array of custom devices.
34         (Port.setup_test_run): Add device_class argument.
35         * Scripts/webkitpy/port/driver.py:
36         (DriverInput.__repr__):
37         (Driver.check_driver.implementation):
38         * Scripts/webkitpy/port/efl.py:
39         (EflPort.setup_test_run):
40         * Scripts/webkitpy/port/gtk.py:
41         (GtkPort.setup_test_run):
42         * Scripts/webkitpy/port/ios.py:
43         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
44         (IOSSimulatorPort.__init__):
45         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
46         based on the custom device class.
47         (IOSSimulatorPort._set_device_class):
48         (IOSSimulatorPort._create_simulators): Factor some code into this function.
49         (IOSSimulatorPort.setup_test_run):
50         (IOSSimulatorPort.testing_device):
51         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
52         seemed wrong for this function. That was moved to setup_test_run().
53         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
54         but this happened too early, before we knew which kind of devices to create. Devices
55         are now created in setup_test_run().
56         * Scripts/webkitpy/port/win.py:
57         (WinPort.setup_test_run):
58
59 2016-08-15  Daniel Bates  <dabates@apple.com>
60
61         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
62         private frameworks and libraries
63         https://bugs.webkit.org/show_bug.cgi?id=155931
64         <rdar://problem/25807989>
65
66         Reviewed by Dan Bernstein.
67
68         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
69         where X is the major version of the active iOS SDK.
70
71         * DumpRenderTree/mac/Configurations/Base.xcconfig:
72         * WebKitTestRunner/Configurations/Base.xcconfig:
73
74 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
75
76         Add a setting and preferences to enable visual viewport mode
77         https://bugs.webkit.org/show_bug.cgi?id=160843
78
79         Reviewed by Sam Weinig.
80         
81         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
82
83         * MiniBrowser/mac/SettingsController.h:
84         * MiniBrowser/mac/SettingsController.m:
85         (-[SettingsController _populateMenu]):
86         (-[SettingsController validateMenuItem:]):
87         (-[SettingsController visualViewportEnabled]):
88         (-[SettingsController toggleVisualViewportEnabled:]):
89         * MiniBrowser/mac/WK1BrowserWindowController.m:
90         (-[WK1BrowserWindowController didChangeSettings]):
91         * MiniBrowser/mac/WK2BrowserWindowController.m:
92         (-[WK2BrowserWindowController didChangeSettings]):
93
94 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
95
96         Allow using make-dist with non-GTK ports
97         https://bugs.webkit.org/show_bug.cgi?id=160842
98
99         Reviewed by Michael Catanzaro.
100
101         This patch adds support for setting base name of tarball and argument
102         passed to cmake's -DPORT= via command line arguments.
103
104         * gtk/make-dist.py:
105         (Distcheck.configure):
106         (Distcheck.check):
107         (get_tarball_root_and_output_filename_from_arguments):
108
109 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
110
111         [GTK] Install script lacks gstreamer related dependencies
112         https://bugs.webkit.org/show_bug.cgi?id=160814
113
114         Reviewed by Carlos Garcia Campos.
115
116         * gtk/install-dependencies: Fedora case had already listed this dependencies,
117         but both Arch and Debian/Ubuntu were missing them.
118
119 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
120
121         make-dist.py should not allow unknown rules in manifest
122         https://bugs.webkit.org/show_bug.cgi?id=160841
123
124         Reviewed by Carlos Garcia Campos.
125
126         * gtk/make-dist.py:
127         (Manifest.process_line):
128
129 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
130
131         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
132         https://bugs.webkit.org/show_bug.cgi?id=160809
133
134         Reviewed by Carlos Garcia Campos.
135
136         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
137         case, and use it also for the new package names of libpng and libgeoclue.
138         * gtk/install-dependencies: Ditto.
139
140 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
141
142         Skip to check directories existence in build-webkit
143         https://bugs.webkit.org/show_bug.cgi?id=160691
144
145         Reviewed by Alex Christensen.
146
147         CMake checks if directories are there itself. So CMake ports
148         don't need to check it in the build-webkit script.
149
150         * Scripts/build-webkit:
151         * Scripts/webkitdirs.pm:
152         (determineSourceDir):
153         (isCMakeBuild):
154
155 2016-08-12  Alex Christensen  <achristensen@webkit.org>
156
157         Make URLParser work with URLs missing URL parts
158         https://bugs.webkit.org/show_bug.cgi?id=160824
159
160         Reviewed by Brady Eidson.
161
162         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
163         (TestWebKitAPI::s):
164         (TestWebKitAPI::checkURL):
165         (TestWebKitAPI::TEST_F):
166         (TestWebKitAPI::eq): Deleted.
167
168 2016-08-12  John Wilander  <wilander@apple.com>
169
170         Add HashCountedSet API tests to TestWTFLibrary target
171         https://bugs.webkit.org/show_bug.cgi?id=160815
172
173         Reviewed by Alex Christensen.
174
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
176             Added HashCountedSet.cpp and sorted the file reference section
177             according to UNIX sort.
178
179 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
180
181         run-benchmark should run JetStream 1.1 instead of 1.0.1
182         https://bugs.webkit.org/show_bug.cgi?id=160816
183
184         Reviewed by Filip Pizlo.
185
186         Use the latest JetStream 1.1 in run-benchmark.
187
188         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
189         (BenchmarkBuilder.__exit__):
190         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
191         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
192         change to JetStream directory.
193
194 2016-08-12  Alex Christensen  <achristensen@webkit.org>
195
196         Initial URLParser implementation
197         https://bugs.webkit.org/show_bug.cgi?id=160811
198
199         Reviewed by Brady Eidson.
200
201         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
202         (TestWebKitAPI::eq):
203         (TestWebKitAPI::checkURL):
204         (TestWebKitAPI::TEST_F):
205
206 2016-08-12  Brady Eidson  <beidson@apple.com>
207
208         Fix the 32-bit Mac build after:
209         Add WK2 ExperimentalFeature support to MiniBrowser
210         https://bugs.webkit.org/show_bug.cgi?id=160788
211
212         Unreviewed.
213
214         Sprinkle "#if WK_API_ENABLED"s liberally.
215         
216         * MiniBrowser/mac/AppDelegate.m:
217         (defaultConfiguration):
218         * MiniBrowser/mac/SettingsController.m:
219         (-[SettingsController _populateMenu]):
220         (-[SettingsController validateMenuItem:]):
221
222 2016-08-12  Philippe Normand  <pnormand@igalia.com>
223
224         [GStreamer][OWR] Video rendering fixes
225         https://bugs.webkit.org/show_bug.cgi?id=160764
226
227         Reviewed by Xabier Rodriguez-Calvar.
228
229         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
230
231 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
232
233         Add missing return statement in convertFast function added in r204376.
234
235         Unreviewed.
236
237         * Scripts/webkitpy/common/system/path.py:
238         (_CygPath.convertFast):
239
240 2016-08-11  Brady Eidson  <beidson@apple.com>
241
242         Add WK2 ExperimentalFeature support to MiniBrowser.
243         https://bugs.webkit.org/show_bug.cgi?id=160788
244
245         Reviewed by Alex Christensen.
246
247         * MiniBrowser/mac/AppDelegate.h:
248         * MiniBrowser/mac/AppDelegate.m:
249         (defaultConfiguration):
250         (defaultPreferences):
251         
252         * MiniBrowser/mac/SettingsController.m:
253         (-[SettingsController _populateMenu]):
254         (-[SettingsController validateMenuItem:]):
255         (-[SettingsController toggleExperimentalFeature:]):
256
257 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
258
259         Keep EWS logs for longer
260         https://bugs.webkit.org/show_bug.cgi?id=160776
261
262         Reviewed by Daniel Bates.
263
264         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
265
266 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
267
268         iOS DRT/WTR project cleanup
269         https://bugs.webkit.org/show_bug.cgi?id=160778
270
271         Reviewed by Tim Horton.
272
273         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
274
275         Remove AppDelegate.* which were unused.
276
277         Exclude ios/Launch.storyboard on more platforms.
278
279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
280         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
281         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
282         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
283         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
284         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
285         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
286
287 2016-08-11  Alex Christensen  <achristensen@webkit.org>
288
289         Fix Yosemite bots' cookie accept policies after r204365.
290         https://bugs.webkit.org/show_bug.cgi?id=160758
291
292         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
293         (TEST):
294         This makes the test fully clean up after itself.
295
296 2016-08-11  Alex Christensen  <achristensen@webkit.org>
297
298         Fix Yosemite bots' cookie accept policies after r204365.
299         https://bugs.webkit.org/show_bug.cgi?id=160758
300
301         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
302         (TEST):
303         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
304         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
305         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
306         causing any problems because there are no other API tests that do anything with cookies.
307         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
308         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
309         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
310
311 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
312
313         EWS should check if the patch is still valid before executing every major step
314         https://bugs.webkit.org/show_bug.cgi?id=160739
315         rdar://problem/27768813
316
317         Reviewed by Alexey Proskuryakov.
318
319         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
320         (CommitQueueTask.run): validate method is now executed in base class.
321         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
322         (EarlyWarningSystemTask.run): validate method is now executed in base class.
323         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
324         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
325         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
326         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
327         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
328         * Scripts/webkitpy/tool/commands/perfalizer.py:
329         (PerfalizerTask.validate): Added.
330         * Scripts/webkitpy/tool/commands/queues_unittest.py:
331         (test_manual_reject_during_processing): Updated test case.
332
333 2016-08-11  Alex Christensen  <achristensen@webkit.org>
334
335         Add URLParser stub
336         https://bugs.webkit.org/show_bug.cgi?id=160770
337
338         Reviewed by Sam Weinig.
339
340         * TestWebKitAPI/PlatformGTK.cmake:
341         * TestWebKitAPI/PlatformWin.cmake:
342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
343         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
344         (TestWebKitAPI::TEST_F):
345
346 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
347
348         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
349         https://bugs.webkit.org/show_bug.cgi?id=160761
350
351         Reviewed by Tim Horton.
352
353         Give iOS DRT a Launch storyboard.
354
355         Have it use a UIViewController so future forms testing works correctly.
356
357         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
358         can run in iPad mode.
359
360         Remove empty InfoPlist.strings files.
361
362         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
363         * DumpRenderTree/ios/Info.plist:
364         * DumpRenderTree/ios/Launch.storyboard: Added.
365         * DumpRenderTree/mac/DumpRenderTree.mm:
366         (createWebViewAndOffscreenWindow):
367         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
368         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
369         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
370         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
371
372 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
373
374         [Win] Unable to reliably run tests in parallel
375         https://bugs.webkit.org/show_bug.cgi?id=140914
376
377         Reviewed by Brent Fulgham.
378
379         The cygpath utility function can fail badly when running with multiple DumpRenderTree
380         processes. We can use string replacement to convert the Cygwin path to a Windows path
381         instead.
382
383         * Scripts/webkitpy/common/system/path.py:
384         (cygpathFast):
385         * Scripts/webkitpy/port/driver.py:
386         (Driver._command_from_driver_input):
387
388 2016-08-10  Alex Christensen  <achristensen@webkit.org>
389
390         Fix crash when changing cookie accept policy after r204327
391         https://bugs.webkit.org/show_bug.cgi?id=160758
392
393         Reviewed by Simon Fraser.
394
395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
396         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
397         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
398         (TEST):
399         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
400
401 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
402
403         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
404         https://bugs.webkit.org/show_bug.cgi?id=160757
405
406         Reviewed by Tim Horton.
407
408         When programmatically creating the test UIWindow, make a root UIViewController and parent
409         the WKWebView in its view. This makes the app more like a normal UIKit application.
410         
411         Move the WKWebView down 20px to avoid the status bar.
412         
413         Give the UIWindow a gray background so it's obvious where the window and view positioned.
414
415         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
416         
417         Remove duplicate references to Launch.storyboard.
418
419         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
420         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
421         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
422         (-[AppDelegate applicationWillResignActive:]): Deleted.
423         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
424         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
425         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
426         (-[AppDelegate applicationWillTerminate:]): Deleted.
427         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
428         (WTR::viewRectForWindowRect):
429         (WTR::PlatformWebView::PlatformWebView):
430         (WTR::PlatformWebView::setWindowFrame):
431
432 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
433
434         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
435         https://bugs.webkit.org/show_bug.cgi?id=160748
436
437         Reviewed by Tim Horton.
438         
439         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
440         opens the door for tests using other device sizes.
441
442         * WebKitTestRunner/ios/TestControllerIOS.mm:
443         (WTR::TestController::platformConfigureViewForTest):
444
445 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
446
447         Sort the feature flags in the FEATURE_DEFINES lines
448         https://bugs.webkit.org/show_bug.cgi?id=160742
449
450         Reviewed by Anders Carlsson.
451         
452         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
453
454 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
455
456         Logging and other minor improvements to iOS webkitpy
457         https://bugs.webkit.org/show_bug.cgi?id=160722
458
459         Reviewed by Dan Bates.
460
461         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
462         to make it easier to debug launching issues.
463
464         Have reset_preferences() reset the device, rather than just nuking the data
465         directory (which broke some versions of the simulator).
466
467         Make the Simulator.app launch in the background with open -g.
468
469         Wait for the simulator device to be in a known state in some more places.
470
471         * Scripts/webkitpy/port/ios.py:
472         (IOSSimulatorPort.setup_test_run):
473         (IOSSimulatorPort._quit_ios_simulator):
474         (IOSSimulatorPort.clean_up_test_run):
475         (IOSSimulatorPort.setup_environ_for_server):
476         (IOSSimulatorPort.reset_preferences):
477         * Scripts/webkitpy/xcode/simulator.py:
478         (Device.create):
479         (Device.delete):
480         (Device):
481         (Device.reset):
482         (Simulator.wait_until_device_is_booted):
483         (Simulator.wait_until_device_is_in_state):
484         (Simulator):
485         (Simulator.delete_device):
486         (Simulator.reset_device):
487         (Simulator.lookup_or_create_device):
488
489 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
490
491         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
492         https://bugs.webkit.org/show_bug.cgi?id=160697
493
494         Reviewed by Antonio Gomes.
495
496         * Scripts/webkitpy/port/base.py:
497         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
498         list of environment variables to copy.
499
500 2016-08-09  George Ruan  <gruan@apple.com>
501
502         Implement functionality of media capture on iOS
503         https://bugs.webkit.org/show_bug.cgi?id=158945
504         <rdar://problem/26893343>
505
506         Reviewed by Tim Horton.
507
508         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
509         Capture feature on iOS.
510
511 2016-08-09  Saam Barati  <sbarati@apple.com>
512
513         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
514         https://bugs.webkit.org/show_bug.cgi?id=160671
515         <rdar://problem/27756112>
516
517         Reviewed by Mark Lam.
518
519         * Scripts/run-jsc-stress-tests:
520
521 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
522
523         Make directory reading code in iOSSimulatorDevices() more strict
524         https://bugs.webkit.org/show_bug.cgi?id=160702
525
526         Reviewed by Tim Horton.
527
528         * Scripts/webkitdirs.pm:
529         (iOSSimulatorDevices):
530
531 2016-08-06  Sam Weinig  <sam@webkit.org>
532
533         Replace NodeOrString with std::variant<RefPtr<Node>, String>
534         https://bugs.webkit.org/show_bug.cgi?id=160638
535
536         Reviewed by Anders Carlsson.
537
538         * TestWebKitAPI/CMakeLists.txt:
539         * TestWebKitAPI/Tests/WTF/Variant.cpp:
540         Add additional tests for the initial state of std::variant and using
541         makeVisitor for visiting.
542
543 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
544
545         EWS logging should ensure the logging to file is stopped on queue termination
546         https://bugs.webkit.org/show_bug.cgi?id=160698
547         rdar://problem/24464570
548
549         Reviewed by Daniel Bates.
550
551         * Scripts/webkitpy/tool/bot/queueengine.py:
552         (QueueEngine._stopping): Stop logging to file on queue termination.
553         (QueueEngine._begin_logging): Configure the Python logger to log to file.
554         * Scripts/webkitpy/common/system/logutils.py:
555         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
556         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
557         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
558         * Scripts/webkitpy/tool/commands/queues.py:
559         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
560         (AbstractQueue.queue_log_path): Same.
561         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
562         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
563         which moved to QueueEngine now.
564         (PatchProcessingQueue.__init__): Same.
565         (CommitQueue.__init__): Same.
566         (AbstractReviewQueue.__init__): Same.
567         (StyleQueue.__init__): Same.
568         * Scripts/webkitpy/tool/commands/queues_unittest.py:
569         (TestCommitQueue): Removed host parameter.
570         (TestCommitQueue.__init__): Same.
571         (AbstractPatchQueueTest.test_next_patch): Same.
572         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
573         (test_commit_queue_failure): Same.
574         (mock_run_webkit_patch):
575         (MockCommitQueueTask.results_from_patch_test_run): Same.
576         (test_rollout_lands): Same.
577         (test_non_valid_patch): Same.
578         (test_auto_retry): Same.
579         (test_style_queue_with_watch_list_exception): Same.
580         (TestQueue.__init__): Deleted.
581         (TestReviewQueue.__init__): Deleted.
582         (TestFeederQueue.__init__): Deleted.
583
584 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
585
586         webkit-gtk tarball fails to build due to missing files
587         https://bugs.webkit.org/show_bug.cgi?id=160684
588
589         Reviewed by Alex Christensen.
590
591         * gtk/manifest.txt.in: Added back spi directories.
592
593 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
594
595         [GTK] Build the jhbuild with -O2 optimization level by default
596         https://bugs.webkit.org/show_bug.cgi?id=160544
597
598         Reviewed by Michael Catanzaro.
599
600         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
601         which don't increases the required disk space significatively and
602         provides better debug information than no passing it.
603
604 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
605
606         Allow more --cmakeargs option in build-jsc and build-webkit
607         https://bugs.webkit.org/show_bug.cgi?id=160340
608
609         Reviewed by Michael Catanzaro.
610
611         * Scripts/build-jsc:
612         * Scripts/build-webkit:
613
614 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
615
616         Do not check if WebKitLibraries folder exists on EFL and GTK
617         https://bugs.webkit.org/show_bug.cgi?id=160659
618
619         Reviewed by Csaba Osztrogonác.
620
621         Though WebKitLibraries is only needed by mac and win ports,
622         EFL and GTK ports have checked whether it exists.
623
624         * Scripts/build-webkit:
625
626 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
627
628         Some EWS console logs doesn't go to log file
629         https://bugs.webkit.org/show_bug.cgi?id=160585
630         rdar://problem/24464570
631
632         Reviewed by Daniel Bates.
633
634         * Scripts/webkitpy/common/system/logutils.py:
635         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
636         any possible overwriting.
637         * Scripts/webkitpy/common/system/filesystem.py:
638         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
639         * Scripts/webkitpy/common/system/filesystem_mock.py:
640         (MockFileSystem.open_text_file_for_writing): Same.
641         * Scripts/webkitpy/common/system/filesystem_unittest.py:
642         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
643         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
644         * Scripts/webkitpy/tool/commands/queues.py:
645         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
646         This will ensure that all the sub-modules inside webkitpy will log to file.
647
648 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
649
650         Have the iOS platform interit from the Apple platform in webkitpy
651         https://bugs.webkit.org/show_bug.cgi?id=160672
652
653         Reviewed by Dan Bates.
654         
655         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
656         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
657         ApplePort.
658         
659         Since WinPort also inherits from ApplePort, it needs to stub out some things
660         that are unavailable on Windows (leaks, sampling).
661         
662         Some SnowLeopard-related code and the associated test were removed.
663
664         * Scripts/webkitpy/port/apple.py:
665         (ApplePort.__init__):
666         (ApplePort):
667         (ApplePort._make_leak_detector):
668         (ApplePort.default_timeout_ms):
669         (ApplePort.supports_per_test_timeout):
670         (ApplePort.should_retry_crashes):
671         (ApplePort._generate_all_test_configurations):
672         (ApplePort.check_for_leaks):
673         (ApplePort.print_leaks_summary):
674         (ApplePort._path_to_webcore_library):
675         (ApplePort.show_results_html_file):
676         (ApplePort._merge_crash_logs):
677         (ApplePort._look_for_all_crash_logs_in_log_dir):
678         (ApplePort._get_crash_log):
679         (ApplePort.look_for_new_crash_logs):
680         (ApplePort.sample_process):
681         (ApplePort.sample_file_path):
682         (ApplePort.look_for_new_samples):
683         (ApplePort._path_to_helper):
684         (ApplePort.determine_full_port_name): Deleted.
685         * Scripts/webkitpy/port/ios.py:
686         (IOSSimulatorPort):
687         (IOSSimulatorPort.__init__):
688         (IOSSimulatorPort.default_timeout_ms): Deleted.
689         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
690         (IOSSimulatorPort.should_retry_crashes): Deleted.
691         (IOSSimulatorPort.check_for_leaks): Deleted.
692         (IOSSimulatorPort.print_leaks_summary): Deleted.
693         (IOSSimulatorPort._path_to_webcore_library): Deleted.
694         (IOSSimulatorPort.show_results_html_file): Deleted.
695         (IOSSimulatorPort.sample_file_path): Deleted.
696         (IOSSimulatorPort._merge_crash_logs): Deleted.
697         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
698         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
699         (IOSSimulatorPort.look_for_new_samples): Deleted.
700         (IOSSimulatorPort.sample_process): Deleted.
701         (IOSSimulatorPort._path_to_helper): Deleted.
702         (IOSSimulatorPort.make_command): Deleted.
703         * Scripts/webkitpy/port/mac.py:
704         (MacPort.__init__):
705         (MacPort.make_command):
706         (MacPort._build_java_test_support):
707         (MacPort): Deleted.
708         (MacPort.default_timeout_ms): Deleted.
709         (MacPort.supports_per_test_timeout): Deleted.
710         (MacPort.should_retry_crashes): Deleted.
711         (MacPort.default_child_processes): Deleted.
712         (MacPort.check_for_leaks): Deleted.
713         (MacPort.print_leaks_summary): Deleted.
714         (MacPort._path_to_webcore_library): Deleted.
715         (MacPort.show_results_html_file): Deleted.
716         (MacPort.sample_file_path): Deleted.
717         (MacPort._merge_crash_logs): Deleted.
718         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
719         (MacPort.look_for_new_crash_logs): Deleted.
720         (MacPort.look_for_new_samples): Deleted.
721         (MacPort.sample_process): Deleted.
722         (MacPort._path_to_helper): Deleted.
723         * Scripts/webkitpy/port/mac_unittest.py:
724         (MacTest.test_default_child_processes): Deleted.
725         * Scripts/webkitpy/port/win.py:
726         (WinPort.look_for_new_samples):
727         (WinPort):
728         (WinPort.sample_process):
729         (WinPort._make_leak_detector):
730         (WinPort.check_for_leaks):
731         (WinPort.print_leaks_summary):
732         (WinPort._path_to_webcore_library):
733
734 2016-08-08  Matt Baker  <mattbaker@apple.com>
735
736         Unreviewed: moved myself to the reviewers list.
737
738         * Scripts/webkitpy/common/config/contributors.json:
739
740 2016-08-08  Chris Dumez  <cdumez@apple.com>
741
742         Update API tests in mac/SetDocumentURI.mm after r204247
743         https://bugs.webkit.org/show_bug.cgi?id=160660
744
745         Reviewed by Alex Christensen.
746
747         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
748         (TestWebKitAPI::TEST):
749
750 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
751
752         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
753         https://bugs.webkit.org/show_bug.cgi?id=159827
754
755         Reviewed by Daniel Bates.
756
757         This change was spurred by a process hang which occurred between tests and did
758         not produce a meaningful crashlog.
759
760         * Scripts/webkitpy/port/driver.py:
761         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
762
763          * Scripts/webkitpy/port/ios.py:
764         (IOSSimulatorPort):
765         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
766         * Scripts/webkitpy/port/mac.py:
767         (MacPort):
768         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
769
770         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
771         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
772
773         * WebKitTestRunner/TestController.h:
774         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
775         * WebKitTestRunner/TestInvocation.cpp:
776         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
777
778 2016-08-07  Dan Bernstein  <mitz@apple.com>
779
780         [Cocoa] Reply block leaks if the remote object doesn’t call it
781         https://bugs.webkit.org/show_bug.cgi?id=160642
782
783         Reviewed by Sam Weinig.
784
785         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
786         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
787         (TEST): Added a test case that checks that the reply block is released even when it’s not
788           called.
789         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
790         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
791           calling the completion handler.
792
793 2016-08-07  Chris Dumez  <cdumez@apple.com>
794
795         Write API test to cover crash fix in r204135
796         https://bugs.webkit.org/show_bug.cgi?id=160587
797
798         Reviewed by Darin Adler.
799
800         Add API test to cover crash fix in r204135. This reproduces the crash
801         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
802         callback.
803
804         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
805         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
806         (TEST):
807
808 2016-08-06  Chris Dumez  <cdumez@apple.com>
809
810         Unreviewed, rolling out r204226.
811
812         Broke some API tests
813
814         Reverted changeset:
815
816         "Write API test to cover crash fix in r204135"
817         https://bugs.webkit.org/show_bug.cgi?id=160587
818         http://trac.webkit.org/changeset/204226
819
820 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
821
822         EWS Style Queue fails to process patches which fails validation
823         https://bugs.webkit.org/show_bug.cgi?id=160632
824
825         Reviewed by Alexey Proskuryakov.
826
827         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
828         (StyleQueueTask.validate): Add more information about validation failure.
829         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
830         * Scripts/webkitpy/tool/commands/queues_unittest.py:
831         (test_non_valid_patch): Add a unit test to test the above code path.
832
833 2016-08-06  Sam Weinig  <sam@webkit.org>
834
835         WTF needs a variant implementation
836         https://bugs.webkit.org/show_bug.cgi?id=160618
837
838         Reviewed by Darin Adler.
839
840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
841         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
842         Add tests for the variant implementation.
843
844 2016-08-06  Chris Dumez  <cdumez@apple.com>
845
846         Write API test to cover crash fix in r204135
847         https://bugs.webkit.org/show_bug.cgi?id=160587
848
849         Reviewed by Darin Adler.
850
851         Add API test to cover crash fix in r204135. This reproduces the crash
852         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
853         callback.
854
855         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
856         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
857         (TEST):
858
859 2016-08-05  Tim Horton  <timothy_horton@apple.com>
860
861         run-api-tests should use a headed simulator
862         https://bugs.webkit.org/show_bug.cgi?id=160611
863
864         Reviewed by Sam Weinig.
865
866         CADisplayLink doesn't work in a headless simulator, but is
867         vital for the proper functioning of WebKit2 painting on iOS.
868         So, we should not use a headless simulator.
869
870         * Scripts/run-api-tests:
871         Launch a simulator app, don't just boot the simulator.
872
873         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
874         Re-enable a test that works now.
875
876 2016-08-05  Dan Bernstein  <mitz@apple.com>
877
878         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
879         https://bugs.webkit.org/show_bug.cgi?id=160589
880
881         Reviewed by Tim Horton.
882
883         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
884         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
885           blocks, which wasn’t caught because the test wasn’t run correctly.
886         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
887         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
888           added a test that sends over an NSRange.
889         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
890         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
891           handler with the range‘s location and length.
892
893 2016-08-05  Enrica Casucci  <enrica@apple.com>
894
895         Fixing tests failing after r204175.
896
897         Unreviewed.
898
899         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
900
901 2016-08-05  Enrica Casucci  <enrica@apple.com>
902
903         Build fix after 204053.
904
905         Unreviewed.
906
907         * TestWebKitAPI/Configurations/Base.xcconfig:
908         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
909         (-[MockContentFilterEnabler initWithCoder:]):
910         (-[MockContentFilterEnabler dealloc]):
911
912 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
913
914         Print test name in "Last character read from DRT..." error message.
915         https://bugs.webkit.org/show_bug.cgi?id=160559
916
917         Reviewed by Michael Catanzaro.
918
919         * Scripts/webkitpy/port/driver.py:
920         (Driver.run_test):
921         (Driver._read_first_block):
922         (Driver._read_optional_image_block):
923         (Driver._read_block):
924         * Scripts/webkitpy/port/driver_unittest.py:
925         (DriverTest.test_read_block):
926         (DriverTest.test_read_binary_block):
927         (DriverTest.test_read_base64_block):
928
929 2016-08-05  Commit Queue  <commit-queue@webkit.org>
930
931         Unreviewed, rolling out r204123.
932         https://bugs.webkit.org/show_bug.cgi?id=160597
933
934         Caused layout test timeouts on Windows. (Requested by perarne
935         on #webkit).
936
937         Reverted changeset:
938
939         "[Win] Unable to reliably run tests in parallel"
940         https://bugs.webkit.org/show_bug.cgi?id=140914
941         http://trac.webkit.org/changeset/204123
942
943 2016-08-04  Saam Barati  <sbarati@apple.com>
944
945         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
946         https://bugs.webkit.org/show_bug.cgi?id=151241
947
948         Reviewed by Benjamin Poulain.
949
950         * Scripts/run-jsc-stress-tests:
951
952 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
953
954         UI improvements to Flakiness Dashboard.
955         https://bugs.webkit.org/show_bug.cgi?id=153295
956
957         Reviewed by Alexey Proskuryakov.
958
959         * TestResultServer/static-dashboards/flakiness_dashboard.css:
960         (td.options-container): Center text in most fields.
961         * TestResultServer/static-dashboards/flakiness_dashboard.js:
962         (createBugHTML): Text/Grammar updates.
963         (tableHeaders): Ditto.
964         (htmlForSingleTestRow): Ditto.
965         (headerForTestTableHtml): Ditto.
966         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
967         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
968
969 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
970
971         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
972         https://bugs.webkit.org/show_bug.cgi?id=160518
973
974         Reviewed by Michael Catanzaro.
975
976         * Scripts/webkitpy/thirdparty/__init__.py:
977         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
978         * gtk/install-dependencies:
979
980 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
981
982         Optimize bot watcher's dashboard a little
983         https://bugs.webkit.org/show_bug.cgi?id=160515
984         rdar://problem/26096900
985
986         Reviewed by Lucas Forschler.
987
988         Made re-sorting after loading an iteration more efficient.
989
990         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
991         (BuildbotIteration.prototype._updateWithData):
992         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
993         (BuildbotQueue.prototype.updateIterationPosition):
994
995 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
996
997         [Win] Unable to reliably run tests in parallel
998         https://bugs.webkit.org/show_bug.cgi?id=140914
999
1000         Reviewed by Brent Fulgham.
1001
1002         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1003         processes. We can use string replacement to convert the Cygwin path to a Windows path
1004         instead.
1005  
1006         * Scripts/webkitpy/common/system/path.py:
1007         (cygpathFast):
1008         * Scripts/webkitpy/port/driver.py:
1009         (Driver._command_from_driver_input):
1010
1011 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1012
1013         Document instructions for increasing process and file limits
1014         https://bugs.webkit.org/show_bug.cgi?id=160528
1015         rdar://problem/24777576
1016
1017         Reviewed by Alexey Proskuryakov.
1018
1019         * Scripts/webkitpy/port/ios.py:
1020         (IOSSimulatorPort.default_child_processes):
1021
1022 2016-08-03  Anders Carlsson  <andersca@apple.com>
1023
1024         Remove the Objective-C bindings generator
1025         https://bugs.webkit.org/show_bug.cgi?id=160526
1026
1027         Reviewed by Sam Weinig.
1028
1029         * Scripts/run-bindings-tests:
1030         Update test.
1031
1032 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1033
1034         Revise a TestWebKitAPI comment to mention the actual underlying problem
1035
1036         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1037         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1038
1039 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1040
1041         Benchmark test content-animation timeouts always
1042         https://bugs.webkit.org/show_bug.cgi?id=160057
1043
1044         Reviewed by Simon Fraser.
1045
1046         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1047         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1048         (start):
1049
1050 2016-08-02  Nan Wang  <n_wang@apple.com>
1051
1052         AX: Simulated touch events are not working on iOS
1053         https://bugs.webkit.org/show_bug.cgi?id=160395
1054         <rdar://problem/27633597>
1055
1056         Reviewed by Chris Fleizach.
1057
1058         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1059         (WTR::AccessibilityUIElement::press):
1060         (WTR::AccessibilityUIElement::setSelectedChild):
1061
1062 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1063
1064         run-javascriptcore-tests should accept multiple --extra-tests
1065         https://bugs.webkit.org/show_bug.cgi?id=160486
1066
1067         Reviewed by Saam Barati.
1068         
1069         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1070         test suites. This does it by using GetOpt::Long's array support.
1071
1072         * Scripts/run-javascriptcore-tests:
1073         (runJSCStressTests):
1074
1075 2016-08-02  Enrica Casucci  <enrica@apple.com>
1076
1077         Allow building with content filtering disabled.
1078         https://bugs.webkit.org/show_bug.cgi?id=160454
1079
1080         Reviewed by Simon Fraser.
1081
1082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1083
1084 2016-08-02  Brady Eidson  <beidson@apple.com>
1085
1086         Removing IndexedDB WebsiteData can fail for some users.
1087         https://bugs.webkit.org/show_bug.cgi?id=160463
1088
1089         Reviewed by Alex Christensen.
1090
1091         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1092
1093 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1094
1095         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1096         https://bugs.webkit.org/show_bug.cgi?id=160437
1097         <rdar://problem/27578272>
1098
1099         Reviewed by Brady Eidson.
1100
1101         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1102         (-[DownloadDelegate _download:didReceiveResponse:]):
1103         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1104         (runTest):
1105         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1106
1107 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1108
1109         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1110         https://bugs.webkit.org/show_bug.cgi?id=160414
1111
1112         Reviewed by Michael Catanzaro.
1113
1114         * Scripts/webkitpy/port/linux_get_crash_log.py:
1115         (GDBCrashLogGenerator._wait_for_corefile):
1116
1117 2016-08-01  Youenn Fablet  <youenn@apple.com>
1118
1119         Make wpt server generate its certificates in layout test results folder
1120         https://bugs.webkit.org/show_bug.cgi?id=160422
1121
1122         Reviewed by Chris Dumez.
1123
1124         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1125         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1126
1127 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1128
1129         Function Call on NULL Object
1130         https://bugs.webkit.org/show_bug.cgi?id=160325
1131
1132         Reviewed by Darin Adler.
1133
1134         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1135         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1136         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1137
1138 2016-08-01  Keith Miller  <keith_miller@apple.com>
1139
1140         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1141         https://bugs.webkit.org/show_bug.cgi?id=160372
1142
1143         Rubber stamped by Geoffrey Garen.
1144
1145         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1146         a new top level directory, JSTests. Having the tests in the Source directory
1147         was both confusing an inconvenient for people that just want to checkout the
1148         source code of WebKit. Since there is no other obvious place to put all the
1149         JavaScript tests a new top level directory seemed the most sensible.
1150
1151         * Scripts/import-test262-tests:
1152         * Scripts/run-javascriptcore-tests:
1153         * Scripts/update-javascriptcore-test-res:
1154
1155 2016-07-31  Nan Wang  <n_wang@apple.com>
1156
1157         AX: Add a check for touch event listener on iOS accessibility object
1158         https://bugs.webkit.org/show_bug.cgi?id=160388
1159
1160         Reviewed by Chris Fleizach.
1161
1162         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1163         (AccessibilityUIElement::boolAttributeValue):
1164         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1165         (WTR::AccessibilityUIElement::boolAttributeValue):
1166
1167 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1168
1169         Unreviewed: add myself to the reviewers list.
1170
1171         * Scripts/webkitpy/common/config/contributors.json:
1172
1173 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Undo r203939, and copy over a rule that clips the logos.
1176
1177         Sierra wasn't the only logo without transparency.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1182
1183 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1184
1185         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1186         https://bugs.webkit.org/show_bug.cgi?id=160377
1187
1188         Reviewed by Brian Weinstein.
1189
1190         Update assets to remove the white background and use a transparent background instead.
1191
1192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1194
1195 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1196
1197         Ignore most check-webkit-style checks for ANGLE project
1198         <https://webkit.org/b/160333>
1199
1200         Reviewed by Daniel Bates.
1201
1202         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1203         - No tabs.
1204         - No spaces at the end of lines.
1205         - No carriage returns (DOS line endings).
1206
1207 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1208
1209         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1210         https://bugs.webkit.org/show_bug.cgi?id=160360
1211         <rdar://problem/27179484>
1212
1213         Reviewed by Myles C. Maxfield.
1214
1215         Adds two tests verifying that videos may be considered main content as long as they
1216         are large enough and cover a majority of the mainframe's viewport.
1217
1218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1219         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1220         (TestWebKitAPI::TEST):
1221         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1222         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1223
1224 2016-07-29  Mark Lam  <mark.lam@apple.com>
1225
1226         Gardening: removed unused variable.
1227
1228         Not reviewed.
1229
1230         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1231         (TestWebKitAPI::TEST):
1232
1233 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1234
1235         Add TestWebKitAPI support for interacting with media controls
1236         https://bugs.webkit.org/show_bug.cgi?id=160342
1237         <rdar://problem/27610246>
1238
1239         Reviewed by Beth Dakin.
1240
1241         Adds support for testing interaction with some media controls, as well as a basic test
1242         verifying that media control teardown after interaction does not result in a crash.
1243
1244         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1245         (-[WKWebView mouseDownAtPoint:]):
1246         (-[WKWebView performAfterLoading:]):
1247         (TestWebKitAPI::TEST):
1248
1249 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1250
1251         Crash Log Clobbering on Unbound Crashes
1252         https://bugs.webkit.org/show_bug.cgi?id=160198
1253         <rdar://problem/27472618>
1254
1255         Reviewed by Alexey Proskuryakov.
1256
1257         * Scripts/webkitpy/common/system/crashlogs.py:
1258         (CrashLogs): Fix header order.
1259         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1260         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1261
1262 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1263
1264         Update for contributors.json
1265         https://bugs.webkit.org/show_bug.cgi?id=160294
1266
1267         * Scripts/webkitpy/common/config/contributors.json:
1268
1269 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1270
1271         Remove deprecated SPI for video inline / fullscreen controls
1272         https://bugs.webkit.org/show_bug.cgi?id=160318
1273
1274         Reviewed by Tim Horton.
1275
1276         * DumpRenderTree/mac/DumpRenderTree.mm:
1277         (setDefaultsToConsistentValuesForTesting): Deleted.
1278         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1279         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1282         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1283         (WTR::initializeWebViewConfiguration): Deleted.
1284
1285 2016-07-28  Daniel Bates  <dabates@apple.com>
1286
1287         [iOS] TestWebKitAPI bundle targets are not code signed
1288         https://bugs.webkit.org/show_bug.cgi?id=160328
1289         <rdar://problem/27409246>
1290
1291         Reviewed by Andy Estes.
1292
1293         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1294         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1295         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1296
1297         * TestWebKitAPI/Configurations/Base.xcconfig:
1298
1299 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1300
1301         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1302
1303         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1304         (animatedResizeWebView):
1305         (TEST):
1306         This test times out only when run in the WebKit Testing simulator environment,
1307         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1308
1309 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1310
1311         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1312         https://bugs.webkit.org/show_bug.cgi?id=160289
1313         <rdar://problem/27553464>
1314
1315         Reviewed by Simon Fraser.
1316
1317         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1320         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1321         (-[AnimatedResizeWebView _endAnimatedResize]):
1322         (animatedResizeWebView):
1323         (TEST):
1324         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1325         Add two tests that ensure that hidden-content and animated resizes
1326         don't cause unnecessary synchronous waits. Only the hidden-content
1327         one fails before my patch, but it seemed reasonable to add both anyway.
1328
1329 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1330
1331         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1332         <https://webkit.org/b/83342>
1333
1334         Reviewed by Ryosuke Niwa.
1335
1336         * Scripts/webkitpy/common/checkout/scm/git.py:
1337         (Git.revisions_changing_file): Remove code to raise an exception
1338         when the file doesn't exist.  If a file was moved or renamed,
1339         then this caused the script to terminate, which was very
1340         frustrating when you wanted a list of reviewers.
1341         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1342         (SCMTest._shared_test_revisions_changing_file): Update test
1343         expectation to return an empty list of revisions.
1344         (test_create_patch_is_full_patch): Drive-by fix when running all
1345         webkitpy tests (including scm tests).
1346         * Scripts/webkitpy/common/checkout/scm/svn.py:
1347         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1348         return an empty array of revisions if this occurs.
1349
1350 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1351
1352         EWS error message "Error: * did not process patch" should include explanation
1353         https://bugs.webkit.org/show_bug.cgi?id=159903
1354         <rdar://problem/27410788>
1355
1356         Reviewed by Alexey Proskuryakov.
1357
1358         * QueueStatusServer/handlers/statusbubble.py:
1359         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1360         is not processed.
1361         * QueueStatusServer/handlers/processingtimesjson.py:
1362         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1363         of the code.
1364         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1365         (CommitQueueTask.validate): Add more information about validation failure.
1366         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1367         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1368         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1369         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1370         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1371         (PatchIsNotValid.__init__): Add the failure_message argument.
1372         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1373         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1374         failure details.
1375         * Scripts/webkitpy/tool/commands/queues.py:
1376         (CommitQueue.process_work_item): Same.
1377         (StyleQueue.review_patch): Same.
1378         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1379         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1380
1381 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1382
1383         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1384         https://bugs.webkit.org/show_bug.cgi?id=160262
1385
1386         Reviewed by Daniel Bates.
1387
1388         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1389         (-[LTRelayController installApp]):
1390
1391 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1392
1393         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1394         https://bugs.webkit.org/show_bug.cgi?id=160225
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1399
1400 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1401
1402         [GTK] Fix some video/canvas tests that should be passing
1403         https://bugs.webkit.org/show_bug.cgi?id=160023
1404
1405         Reviewed by Carlos Garcia Campos.
1406
1407         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1408         EFL or GTK platforms.
1409
1410         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1411         (WTR::TestController::platformConfigureViewForTest):
1412         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1413         (WTR::TestController::platformConfigureViewForTest):
1414
1415 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1416
1417         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1418         https://bugs.webkit.org/show_bug.cgi?id=160247
1419
1420         Reviewed by Michael Catanzaro.
1421
1422         * BuildSlaveSupport/built-product-archive:
1423         (createZip):
1424         (dirContainsdwo):
1425         (archiveBuiltProduct):
1426
1427 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1428
1429         Fix tests after r203743.
1430         https://bugs.webkit.org/show_bug.cgi?id=156947
1431
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::TestController::resetStateToConsistentValues):
1434         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1435
1436 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1437
1438         [iPhone] Playing a video on tudou.com plays only sound, no video
1439         https://bugs.webkit.org/show_bug.cgi?id=160178
1440         <rdar://problem/27535468>
1441
1442         Reviewed by Dan Bernstein.
1443
1444         * DumpRenderTree/mac/DumpRenderTree.mm:
1445         (setDefaultsToConsistentValuesForTesting):
1446         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1447         (RequiresUserActionForPlaybackTest::SetUp):
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::resetPreferencesToConsistentValues):
1450         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1451         (WTR::initializeWebViewConfiguration):
1452
1453 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1454
1455         Allow LOG macros to be used outside the namespace, and other logging cleanup
1456         https://bugs.webkit.org/show_bug.cgi?id=160216
1457
1458         Reviewed by Anders Carlsson.
1459         
1460         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1461
1462         * DumpRenderTree/TestRunner.cpp:
1463         * DumpRenderTree/mac/DumpRenderTree.mm:
1464         (resetWebViewToConsistentStateBeforeTesting):
1465
1466 2016-07-26  David Kilzer <ddkilzer@apple.com>
1467
1468         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1469         https://bugs.webkit.org/show_bug.cgi?id=156947
1470         <rdar://problem/23325160>
1471
1472         Reviewed by Alex Christensen.
1473
1474         * DumpRenderTree/TestRunner.cpp:
1475         (TestRunner::TestRunner):
1476         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1477         * DumpRenderTree/TestRunner.h:
1478         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1479         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1480         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1481         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1483         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1484         (WTR::TestRunner::queueNonLoadingScript):
1485         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1486         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1487         * WebKitTestRunner/TestController.cpp:
1488         (WTR::TestController::didReceiveAuthenticationChallenge):
1489         * WebKitTestRunner/TestController.h:
1490         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1491         * WebKitTestRunner/TestInvocation.cpp:
1492         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1493         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1494
1495 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1496
1497         check-for-exit-time-destructors should be usable outside Xcode
1498         <https://webkit.org/b/160195>
1499
1500         Reviewed by Darin Adler.
1501
1502         * Scripts/check-for-exit-time-destructors: Update to parse
1503         -h|--help switch, or to take one argument to a binary to check
1504         for exit time destructors on the command-line.  The clang
1505         compiler will find these at compile-time with the
1506         -Wexit-time-destructors switch, but this script will check for
1507         them after-the-fact.
1508
1509 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1510
1511         Test svn.webkit.org functionality after maintenance.
1512
1513 2016-07-25  Brady Eidson  <beidson@apple.com>
1514
1515         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1516         https://bugs.webkit.org/show_bug.cgi?id=153783
1517
1518         Reviewed by Alex Christensen.
1519
1520         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1521         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1522         
1523         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1524         
1525         Change the relevant API tests to make sure this continues to be no longer required.
1526
1527         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1528         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1529         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1530         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1531         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1532         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1533
1534 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1535
1536         Media controls should not be displayed for a video until it starts playing
1537         https://bugs.webkit.org/show_bug.cgi?id=160092
1538         <rdar://problem/26986673>
1539
1540         Reviewed by Beth Dakin.
1541
1542         Verify that multiple videos do or don't show the media controller depending on whether videos
1543         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1544         passing because we were always showing media controls for large videos with audio, even if they
1545         had not played back yet. This change ensures that large videos with audio show media controls
1546         only after they begin to play back, and not by virtue of being large enough for main content.
1547
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1549         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1550         (TestWebKitAPI::TEST):
1551         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1552         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1553         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1554
1555 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1556
1557         Media controls on apple.com don't disappear when movie finishes playing
1558         https://bugs.webkit.org/show_bug.cgi?id=160068
1559         <rdar://problem/26668526>
1560
1561         Reviewed by Darin Adler.
1562
1563         Adds new API tests. Please see WebCore ChangeLog for more details.
1564
1565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1567         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1568         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1569         (TestWebKitAPI::TEST):
1570         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1571         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1572         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1573         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1574         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1575
1576 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1577
1578         Unreviewed, fix test-webkitpy after r203674.
1579
1580         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1581         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1582
1583 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1584
1585         Unreviewed, forgot to commit this file in r203674.
1586
1587         * Scripts/process-linux-coredump: Added.
1588         (main):
1589
1590 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1591
1592         Improve GDB backtrace generation for GTK/EFL
1593         https://bugs.webkit.org/show_bug.cgi?id=128928
1594
1595         Reviewed by Carlos Garcia Campos.
1596
1597         The PID of the crashed process is now correctly supplied to the
1598         crash log reporter. The kernel core_pattern needs to be updated
1599         after this change to something like:
1600
1601         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1602
1603         * Scripts/process-linux-coredump: Added.
1604         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1605         * Scripts/webkitpy/port/efl.py:
1606         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1607         * Scripts/webkitpy/port/gtk.py:
1608         (GtkPort._get_crash_log): Ditto.
1609         * Scripts/webkitpy/port/linux_get_crash_log.py:
1610         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1611         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1612         (GDBCrashLogGenerator): Deleted.
1613         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1614         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1615         * WebKitTestRunner/TestController.cpp:
1616         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1617         (WTR::TestController::databaseProcessDidCrash): Ditto.
1618         (WTR::TestController::processDidCrash): Ditto.
1619
1620 2016-07-23  Youenn Fablet  <youenn@apple.com>
1621
1622         WPT stash server should be kept running when launching wpt server
1623         https://bugs.webkit.org/show_bug.cgi?id=160052
1624
1625         Reviewed by Sam Weinig.
1626
1627         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1628         (main): waiting to read stdin while stash server is started.
1629
1630 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1631
1632         Media controls should be displayed for media in media documents
1633         https://bugs.webkit.org/show_bug.cgi?id=160104
1634         <rdar://problem/27438936>
1635
1636         Reviewed by Myles C. Maxfield.
1637
1638         Verifies that even a small video with audio in a media document gets media controls.
1639
1640         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1641         (TestWebKitAPI::TEST):
1642
1643 2016-07-22  Michael Saboff  <msaboff@apple.com>
1644
1645         REGRESSION(203616): no FTL testing was inadvertently removed
1646         https://bugs.webkit.org/show_bug.cgi?id=160100
1647
1648         Rubber-stamped by Filip Pizlo.
1649
1650         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1651         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1652         logic for the runLayout and runNoisy variants to match the run test logic,
1653         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1654         enabled platforms.
1655
1656         * Scripts/run-jsc-stress-tests:
1657
1658 2016-07-22  Brady Eidson  <beidson@apple.com>
1659
1660         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1661         https://bugs.webkit.org/show_bug.cgi?id=160089
1662
1663         Reviewed by Darin Adler.
1664
1665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1666         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1667         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1668
1669 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1670
1671         [GTK] Improved exclusion patterns in make-dist.py manifest.
1672         https://bugs.webkit.org/show_bug.cgi?id=160094
1673
1674         Reviewed by Michael Catanzaro.
1675
1676         * gtk/manifest.txt.in:
1677         Exclude Platform*.cmake files for more ports.
1678         Removed obsolete .gyp and .pro.user patterns.
1679         Exclude 'Configurations' and 'spi' directories.
1680         Exclude CMakeLists.txt.user (Qt Creator IDE).
1681
1682 2016-07-22  Michael Saboff  <msaboff@apple.com>
1683
1684         Don't run FTL related JSC stress tests on non-FTL platforms
1685         https://bugs.webkit.org/show_bug.cgi?id=160033
1686
1687         Reviewed by Mark Lam.
1688
1689         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1690         Refactored several of the runXXX test methods to always runXXXDefault and made those
1691         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1692         doesn't cause a problem.
1693
1694         * Scripts/run-jsc-stress-tests:
1695
1696 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1697
1698         IWebView::mainFrame crashes if called after IWebView::close
1699         https://bugs.webkit.org/show_bug.cgi?id=32868
1700
1701         Reviewed by Brent Fulgham.
1702
1703         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1704         (TestWebKitAPI::TEST_F): Added test.
1705
1706 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         [GTK] Enable threaded compositor by default
1709         https://bugs.webkit.org/show_bug.cgi?id=160079
1710
1711         Reviewed by Žan Doberšek.
1712
1713         * Scripts/webkitperl/FeatureList.pm:
1714
1715 2016-07-22  Youenn Fablet  <youenn@apple.com>
1716
1717         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1718         https://bugs.webkit.org/show_bug.cgi?id=159921
1719
1720         Reviewed by Brian Burg.
1721
1722         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1723
1724         * Scripts/webkitpy/codegen/main.py:
1725         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1726         (BuiltinsGeneratorTests):
1727         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1728         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1729         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1730         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1731
1732 2016-07-21  Dan Bernstein  <mitz@apple.com>
1733
1734         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1735         https://bugs.webkit.org/show_bug.cgi?id=160072
1736
1737         Reviewed by Andy Estes.
1738
1739         * Scripts/webkitdirs.pm:
1740         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1741           for old Xcode versions.
1742         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1743           to readXcodeUserDefault.
1744         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1745           debugger.
1746         (determineDebugger): Ditto.
1747         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1748           7.0.
1749         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1750           switches.
1751         (execMacWebKitAppForDebugging): Removed support for GDB.
1752
1753 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1754
1755         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1756         https://bugs.webkit.org/show_bug.cgi?id=160066
1757
1758         Reviewed by Dean Jackson.
1759
1760         * DumpRenderTree/mac/DumpRenderTree.mm:
1761         (setDefaultsToConsistentValuesForTesting): Deleted.
1762         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1763         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1766         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1767         (WTR::initializeWebViewConfiguration): Deleted.
1768
1769 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1770
1771         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1772         https://bugs.webkit.org/show_bug.cgi?id=159980
1773         rdar://problem/27450825
1774
1775         Reviewed by Dan Bernstein.
1776
1777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1778         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1779         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1780         when our delegate has hit -dealloc.
1781         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1782         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1783         will not be messaged.
1784
1785 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1786
1787         Follow-up patch to r203520
1788         https://bugs.webkit.org/show_bug.cgi?id=159967
1789         <rdar://problem/26964090>
1790
1791         Unreviewed.
1792
1793         * DumpRenderTree/mac/DumpRenderTree.mm:
1794         (setDefaultsToConsistentValuesForTesting):
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::TestController::resetPreferencesToConsistentValues):
1797
1798 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1799
1800         [iPhone] Playing a video on tudou.com plays only sound, no video
1801         https://bugs.webkit.org/show_bug.cgi?id=159967
1802         <rdar://problem/26964090>
1803
1804         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1805
1806         Migrate tests to use new SPI.
1807
1808         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1809         (RequiresUserActionForPlaybackTest::SetUp):
1810         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1811         (WTR::initializeWebViewConfiguration):
1812
1813 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1814
1815         Clarify testing mode names in run-jsc-stress-tests
1816         https://bugs.webkit.org/show_bug.cgi?id=160021
1817
1818         Reviewed by Mark Lam.
1819
1820         Default should mean really default, not default with disabled FTL, renamed
1821         - runMozillaTestDefault to runMozillaTestNoFTL
1822         - runMozillaTestDefaultFTL to runMozillaTestDefault
1823         - runDefault to runNoFTL
1824         - runDefaultFTL to runDefault
1825         - runLayoutTestDefault to runLayoutTestNoFTL
1826         - runLayoutTestDefaultFTL to runLayoutTestDefault
1827         - runNoisyTestDefault to runNoisyTestNoFTL
1828         - runNoisyTestDefaultFTL to runNoisyTestDefault
1829
1830         * Scripts/run-jsc-stress-tests:
1831
1832 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1833
1834         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1835         https://bugs.webkit.org/show_bug.cgi?id=159986
1836
1837         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1838         to 0.
1839
1840         Reviewed by Dan Bernstein.
1841
1842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1843         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1844         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1845         (TEST):
1846
1847 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1848
1849         [GTK] Web view background colors don't work in accelerated compositing mode
1850         https://bugs.webkit.org/show_bug.cgi?id=159455
1851
1852         Reviewed by Michael Catanzaro.
1853
1854         Set always RGBA visual to the view widget when setting a background color.
1855
1856         * MiniBrowser/gtk/BrowserWindow.c:
1857         (browser_window_set_background_color):
1858
1859 2016-07-20  Youenn Fablet  <youenn@apple.com>
1860
1861         Bots should run built-ins generator tests
1862         https://bugs.webkit.org/show_bug.cgi?id=159971
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1867         (RunBuiltinsTests): New step to run built-in generator tests.
1868         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1869         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1871
1872 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1873
1874         Revert temporary fix r203417
1875         https://bugs.webkit.org/show_bug.cgi?id=160001
1876
1877         Reviewed by Alexey Proskuryakov.
1878
1879         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1880
1881 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1882
1883         REGRESSION(r148588): ews classes might get garbage collected
1884         https://bugs.webkit.org/show_bug.cgi?id=159990
1885
1886         Reviewed by Ryosuke Niwa.
1887
1888         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1889         in a variable so that they do not get garbage collected.
1890
1891 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1892
1893         Add API test for layout constraints after exit fullscreen
1894         https://bugs.webkit.org/show_bug.cgi?id=159900
1895
1896         Reviewed by Jon Lee.
1897
1898         Added Fullscreen.LaytoutConstraints API test. 
1899         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1900
1901         This test compares layout constraints on the web view before and after fullscreen to make sure 
1902         they are preserved.
1903
1904         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1905         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1906         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1907         (TestWebKitAPI::TEST):
1908
1909 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1910
1911         Disable two failing API tests.
1912
1913         Unreviewed test gardening.
1914
1915         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1916         (TestWebKitAPI::TEST):
1917
1918 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1919
1920         Unreviewed iOS build fix.
1921
1922         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1923
1924 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1925
1926         Media controls don't appear when pausing a small autoplaying video
1927         https://bugs.webkit.org/show_bug.cgi?id=159972
1928         <rdar://problem/27180657>
1929
1930         Reviewed by Beth Dakin.
1931
1932         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1933         for simulating basic user interaction in VideoControlsManager.
1934
1935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1936         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1937         (-[WKWebView mouseDownAtPoint:]):
1938         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1939         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1940         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1943
1944 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1945
1946         [Win] MathML fonts are not found.
1947         https://bugs.webkit.org/show_bug.cgi?id=159920
1948
1949         Reviewed by Alex Christensen.
1950
1951         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1952         for a specific registry key value.
1953
1954         * Scripts/webkitdirs.pm:
1955         (fontExists):
1956
1957 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1958
1959         Improve prepare-ChangeLog for @media blocks
1960         https://bugs.webkit.org/show_bug.cgi?id=159907
1961
1962         Reviewed by Timothy Hatcher.
1963
1964         * Scripts/prepare-ChangeLog:
1965         (get_selector_line_ranges_for_css):
1966         Get a range for @media blocks just like a selector.
1967             Start Line = line with '{'
1968             End line = line with '}'
1969             Name = "@media ..."
1970
1971         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1972         Improved error messages for unbalanced portions.
1973
1974         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1975         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1976         (.media-query::before):
1977         (@media only screen and (max-width: 980px)):
1978         (.media-query a):
1979         (@media (-webkit-min-device-pixel-ratio: 2)):
1980         (.both a):
1981         (.both b):
1982         (.media-query b):
1983         (.media-query::after):
1984
1985 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1986
1987         Fix expectedFailErrorHandler in run-jsc-stress-tests
1988         https://bugs.webkit.org/show_bug.cgi?id=159811
1989
1990         Reviewed by Yusuke Suzuki.
1991
1992         * Scripts/run-jsc-stress-tests:
1993
1994 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1995
1996         Unreviewed Mac cmake buildfix after r203426. Just for fun.
1997
1998         * TestWebKitAPI/PlatformMac.cmake:
1999
2000 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2001
2002         The default testing mode should not involve disabling the FTL JIT
2003         https://bugs.webkit.org/show_bug.cgi?id=159929
2004
2005         Rubber stamped by Mark Lam and Saam Barati.
2006         
2007         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2008         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2009         FTL was not the default. You had to enable it with an option.
2010         
2011         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2012         all of the major ports. This has become a serious pain. For example, it's useful to be able
2013         to say that a test should only run in the default config that is representative of what a
2014         normal user would see if they ran JSC. Clearly, this would be a config that does not
2015         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2016         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2017         
2018         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2019         try to fix it, because:
2020         
2021         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2022           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2023           doesn't do anything. The code is not really structured to allow this.
2024         
2025         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2026           disabled in testing. On the other hand there are already build bots that do FTL tests
2027           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2028           preserving this broken feature, we should create something that (a) acknowledges the fact
2029           that the FTL is the default on those platforms that support it and (b) avoids running
2030           no-ftl tests on precisely those platforms that don't have FTL.
2031         
2032         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2033           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2034           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2035           pretending that the FTL JIT is not the default just because some bots used that as an
2036           optimization.
2037         
2038         This change allows me to speed up some debug tests and paint some bots green.
2039
2040         * Scripts/run-javascriptcore-tests:
2041         (runJSCStressTests):
2042         * Scripts/run-jsc-stress-tests:
2043
2044 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2045
2046         Fix API test after r203426.
2047         https://bugs.webkit.org/show_bug.cgi?id=159949
2048
2049         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2050         (TEST):
2051         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2052         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2053
2054 2016-07-19  Andy Estes  <aestes@apple.com>
2055
2056         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2057         https://bugs.webkit.org/show_bug.cgi?id=159956
2058
2059         Reviewed by Dan Bernstein.
2060
2061         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2062         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2063         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2064         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2065
2066 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2067
2068         Add regression test for r203392
2069         https://bugs.webkit.org/show_bug.cgi?id=159949
2070
2071         Reviewed by Brady Eidson.
2072
2073         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2074         (fileSize):
2075         (swizzledBundleIdentifierWebBookmarksD):
2076         (defaultApplicationCacheDirectory):
2077         (TEST):
2078         (swizzledBundleIdentifierMobileSafari): Deleted.
2079         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2080         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2081         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2082
2083 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2084
2085         Add regression test for r203392
2086         https://bugs.webkit.org/show_bug.cgi?id=159949
2087
2088         Reviewed by Brady Eidson.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2092         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2093         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2094         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2095         (TEST):
2096         (fileSize):
2097         (swizzledBundleIdentifierMobileSafari):
2098         (swizzledBundleIdentifierWebBookmarksD):
2099         (defaultApplicationCacheDirectory):
2100         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2101         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2102         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2103         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2104
2105 2016-07-19  Keith Miller  <keith_miller@apple.com>
2106
2107         Test262 should have a file with the revision and url
2108         https://bugs.webkit.org/show_bug.cgi?id=159937
2109
2110         Reviewed by Mark Lam.
2111
2112         The import script should update the information from
2113         the path to the test262 repository it gets.
2114
2115         * Scripts/import-test262-tests:
2116
2117 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2118
2119         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2120         To be deleted once the root cause is found and addressed.
2121
2122         * EWSTools/start-queue-mac.sh:
2123
2124 2016-07-19  Frederic Wang  <fwang@igalia.com>
2125
2126         [win] Fixup the register name for STIX Math and Latin Modern Math
2127
2128         Unreviewed follow-up of r203406
2129
2130         * Scripts/webkitdirs.pm:
2131         (checkInstalledTools):
2132
2133 2016-07-19  Frederic Wang  <fwang@igalia.com>
2134
2135         [win] Update the list of MathML fonts
2136         https://bugs.webkit.org/show_bug.cgi?id=156838
2137
2138         The set of recommended math fonts is now described at
2139         https://trac.webkit.org/wiki/MathML/Fonts
2140         We update the Perl script to use the latest list of fonts.
2141
2142         Reviewed by Brent Fulgham.
2143
2144         * Scripts/webkitdirs.pm:
2145         (checkInstalledTools):
2146
2147 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2148
2149         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2150         https://bugs.webkit.org/show_bug.cgi?id=159342
2151
2152         Reviewed by Darin Adler.
2153
2154         Implement required functions in event sender.
2155
2156         * DumpRenderTree/PlatformWin.cmake:
2157         * DumpRenderTree/win/EventSender.cpp:
2158         (monitorWheelEvents): Added.
2159         (callAfterScrollingCompletes): Added.
2160
2161 2016-07-19  Youenn Fablet  <youenn@apple.com>
2162
2163         Add new aliases to http test server
2164         https://bugs.webkit.org/show_bug.cgi?id=159878
2165
2166         Reviewed by Darin Adler.
2167
2168         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2169         Adding explicitly these links to perl script.
2170         Extracting default alias in an aliases.json file.
2171         Reading that file from python scripts to initialize aliases from that file.
2172
2173         Python script changes covered by unit tests and changed layout test.
2174
2175         * Scripts/webkitperl/httpd.pm:
2176         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2177         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2178         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2179         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2180         Adding -c directives for each alias.
2181         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2182         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2183         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2184         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2185         Adding alias directive for each alias.
2186         (Lighttpd._prepare_config):
2187         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2188         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2189         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2190         layout tests directory.
2191         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2192         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2193         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2194
2195 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2196
2197         EWS console logs doesn't go to log file
2198         https://bugs.webkit.org/show_bug.cgi?id=159539
2199         <rdar://problem/24464570>
2200
2201         Reviewed by David Kilzer.
2202
2203         * Scripts/webkitpy/common/system/logutils.py:
2204         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2205         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2206         to filesystem. It also supports passing MockFilesystem.
2207         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2208         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2209         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2210         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2211         (_test_ews): Same.
2212         * Scripts/webkitpy/tool/commands/queues.py:
2213         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2214         (AbstractQueue._log_directory): Using filesystem object instead of os.
2215         (AbstractQueue.queue_log_path): Same.
2216         (AbstractQueue.__init__): Passed host parameter.
2217         (PatchProcessingQueue.__init__): Same.
2218         (CommitQueue.__init__): Same.
2219         (AbstractReviewQueue.__init__): Same.
2220         (StyleQueue.__init__): Same.
2221         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2222         (TestCommitQueue): Passed MockHost() as host.
2223         (TestCommitQueue.__init__): Same.
2224         (TestQueue.__init__): Same.
2225         (TestReviewQueue.__init__): Same.
2226         (TestFeederQueue.__init__): Same.
2227         (AbstractPatchQueueTest.test_next_patch): Same.
2228         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2229         (test_commit_queue_failure): Same.
2230         (MockCommitQueueTask.results_from_patch_test_run): Same.
2231         (test_rollout_lands): Same.
2232         (test_non_valid_patch): Same.
2233         (test_auto_retry): Same.
2234         (test_style_queue_with_watch_list_exception): Same.
2235
2236 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2237
2238         WTF::Lock should be fair eventually
2239         https://bugs.webkit.org/show_bug.cgi?id=159384
2240
2241         Reviewed by Geoffrey Garen.
2242
2243         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2244
2245 2016-07-17  Sam Weinig  <sam@webkit.org>
2246
2247         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2248         <rdar://problem/26554137>
2249         https://bugs.webkit.org/show_bug.cgi?id=159856
2250
2251         Reviewed by Dan Bernstein.
2252
2253         * MiniBrowser/mac/WK2BrowserWindowController.m:
2254         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2255         Add basic window.open implementation.
2256
2257         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2258         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2259         to open a single non-web URL, all others are dropped.
2260
2261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2262         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2263         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2264         Add API for the new SPI.
2265
2266 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2267
2268         [JSC] Enable test262 module tests
2269         https://bugs.webkit.org/show_bug.cgi?id=159854
2270
2271         Reviewed by Saam Barati.
2272
2273         Use --module-file instead.
2274
2275         * Scripts/run-jsc-stress-tests:
2276
2277 2016-07-16  Chris Dumez  <cdumez@apple.com>
2278
2279         Unreviewed, rolling out r203318.
2280
2281         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2282         SunSpider)
2283
2284         Reverted changeset:
2285
2286         "[JSC] Change some parameters based on a random search"
2287         https://bugs.webkit.org/show_bug.cgi?id=158514
2288         http://trac.webkit.org/changeset/203318
2289
2290 2016-07-16  Chris Dumez  <cdumez@apple.com>
2291
2292         Add move constructor / assignment operator to ListHashSet
2293         https://bugs.webkit.org/show_bug.cgi?id=159837
2294
2295         Reviewed by Darin Adler.
2296
2297         Add API tests.
2298
2299         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2300         (TestWebKitAPI::TEST):
2301
2302 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2303
2304         [JSC] Change some parameters based on a random search
2305         https://bugs.webkit.org/show_bug.cgi?id=158514
2306
2307         Reviewed by Saam Barati.
2308
2309         * Scripts/run-jsc-stress-tests:
2310
2311 2016-07-15  Jon Davis  <jond@apple.com>
2312
2313         Changed the start page URL for WebKit Nightly builds.
2314         https://bugs.webkit.org/show_bug.cgi?id=159816
2315
2316         Reviewed by Timothy Hatcher.
2317
2318         * WebKitLauncher/start.html:
2319
2320 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2321
2322         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2323         https://bugs.webkit.org/show_bug.cgi?id=159414
2324
2325         Reviewed by Brent Fulgham.
2326
2327         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2328         when the HDC parameter is invalid.
2329
2330         * TestWebKitAPI/PlatformWin.cmake:
2331         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2332         (TestWebKitAPI::TEST):
2333
2334 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2335
2336         [GTK] Add basic tabs support to MiniBrowser
2337         https://bugs.webkit.org/show_bug.cgi?id=159803
2338
2339         Reviewed by Sergio Villar Senin.
2340
2341         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2342         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2343
2344         * MiniBrowser/gtk/BrowserTab.c: Added.
2345         (titleChanged):
2346         (isLoadingChanged):
2347         (decidePolicy):
2348         (removeChildIfInfoBar):
2349         (loadChanged):
2350         (createInfoBarQuestionMessage):
2351         (tlsErrorsDialogResponse):
2352         (loadFailedWithTLSerrors):
2353         (permissionRequestDialogResponse):
2354         (decidePermissionRequest):
2355         (colorChooserRGBAChanged):
2356         (popoverColorClosed):
2357         (colorChooserRequestFinished):
2358         (runColorChooserCallback):
2359         (inspectorOpenedInWindow):
2360         (inspectorClosed):
2361         (browserTabSetProperty):
2362         (browserTabFinalize):
2363         (browser_tab_init):
2364         (browserTabConstructed):
2365         (browser_tab_class_init):
2366         (getInternalURI):
2367         (browser_tab_new):
2368         (browser_tab_get_web_view):
2369         (browser_tab_load_uri):
2370         (browser_tab_get_title_widget):
2371         (browser_tab_set_status_text):
2372         (browser_tab_toggle_inspector):
2373         (browser_tab_start_search):
2374         (browser_tab_stop_search):
2375         (browser_tab_add_accelerators):
2376         (fullScreenMessageTimeoutCallback):
2377         (browser_tab_enter_fullscreen):
2378         (browser_tab_leave_fullscreen):
2379         * MiniBrowser/gtk/BrowserTab.h: Added.
2380         * MiniBrowser/gtk/BrowserWindow.c:
2381         (getExternalURI):
2382         (browserWindowSetStatusText):
2383         (reloadOrStopCallback):
2384         (goBackCallback):
2385         (goForwardCallback):
2386         (settingsCallback):
2387         (webViewURIChanged):
2388         (browserWindowHistoryItemActivated):
2389         (browserWindowUpdateNavigationActions):
2390         (webViewCreate):
2391         (webViewEnterFullScreen):
2392         (webViewLeaveFullScreen):
2393         (webViewDecidePolicy):
2394         (browserWindowCanZoomIn):
2395         (browserWindowCanZoomOut):
2396         (browserWindowZoomIn):
2397         (browserWindowZoomOut):
2398         (scrollEventCallback):
2399         (faviconChanged):
2400         (webViewIsLoadingChanged):
2401         (defaultZoomCallback):
2402         (searchCallback):
2403         (newTabCallback):
2404         (toggleWebInspector):
2405         (reloadPage):
2406         (reloadPageIgnoringCache):
2407         (stopPageLoad):
2408         (loadHomePage):
2409         (editingCommandCallback):
2410         (insertImageCommandCallback):
2411         (insertLinkCommandCallback):
2412         (browserWindowSetupEditorToolbar):
2413         (browserWindowSwitchTab):
2414         (browserWindowTabAddedOrRemoved):
2415         (browser_window_init):
2416         (browserWindowConstructed):
2417         (browserWindowSaveSession):
2418         (browserWindowDeleteEvent):
2419         (browser_window_new):
2420         (browser_window_append_view):
2421         (browser_window_load_uri):
2422         (browser_window_load_session):
2423         (browser_window_set_background_color):
2424         (resetStatusText): Deleted.
2425         (activateUriEntryCallback): Deleted.
2426         (webViewTitleChanged): Deleted.
2427         (resetEntryProgress): Deleted.
2428         (browserWindowCreateBackForwardMenu): Deleted.
2429         (webViewReadyToShow): Deleted.
2430         (webViewLoadFailed): Deleted.
2431         (webViewMouseTargetChanged): Deleted.
2432         (browserWindowUpdateZoomActions): Deleted.
2433         (webViewZoomLevelChanged): Deleted.
2434         (updateUriEntryIcon): Deleted.
2435         (zoomInCallback): Deleted.
2436         (zoomOutCallback): Deleted.
2437         (toggleFullScreen): Deleted.
2438         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2439         (browserWindowFinalize): Deleted.
2440         (browser_window_class_init): Deleted.
2441         * MiniBrowser/gtk/BrowserWindow.h:
2442         * MiniBrowser/gtk/CMakeLists.txt:
2443         * MiniBrowser/gtk/main.c:
2444         (createBrowserTab):
2445         (aboutURISchemeRequestCallback):
2446         (main):
2447         (parseBackgroundColor): Deleted.
2448
2449 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2450
2451         Allow RefPtrs of const RefCounted types
2452         https://bugs.webkit.org/show_bug.cgi?id=158269
2453
2454         Reviewed by Anders Carlsson.
2455
2456         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2457         (TestWebKitAPI::TEST):
2458         (TestWebKitAPI::ConstRefCounted::create):
2459         (TestWebKitAPI::returnConstRefCountedRef):
2460         (TestWebKitAPI::returnRefCountedRef):
2461
2462 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2463
2464         Test WTF.StringViewIterators is crashing since r203119
2465         https://bugs.webkit.org/show_bug.cgi?id=159710
2466
2467         Reviewed by Darin Adler.
2468
2469         There are two problems in the test case added in r203119. First is that it's testing
2470         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2471         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2472         const reference to the string view member of the deleted CodePoints object.
2473
2474         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2475         (TestWebKitAPI::TEST):
2476
2477 2016-07-13  Daniel Bates  <dabates@apple.com>
2478
2479         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2480         https://bugs.webkit.org/show_bug.cgi?id=159738
2481         <rdar://problem/27304649>
2482
2483         Reviewed by Dan Bernstein.
2484
2485         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2486         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2487         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2488         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2489
2490         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2491         * WebKitTestRunner/ios/TestControllerIOS.mm:
2492         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2493         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2494
2495 2016-07-13  Beth Dakin  <bdakin@apple.com>
2496
2497         Attempted build fix.
2498
2499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2500
2501 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2504         https://bugs.webkit.org/show_bug.cgi?id=159686
2505
2506         Reviewed by Chris Dumez.
2507
2508         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2509
2510         * WebKitTestRunner/TestController.cpp:
2511         (WTR::runOpenPanel):
2512         (WTR::TestController::createOtherPage):
2513         (WTR::TestController::createWebViewWithOptions):
2514
2515 2016-07-13  Beth Dakin  <bdakin@apple.com>
2516
2517         Add more candidate tests
2518         https://bugs.webkit.org/show_bug.cgi?id=159730
2519
2520         Reviewed by Tim Horton.
2521
2522         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2523         two new tests to that file.
2524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2525         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2526         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2527         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2528         (TestWebKitAPI::TEST):
2529         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2530
2531 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2532
2533         AX: [ATK] spinbutton-crash.html fails
2534         https://bugs.webkit.org/show_bug.cgi?id=159723
2535
2536         Reviewed by Chris Fleizach.
2537
2538         Implement support for AXDecrementButton and AXIncrementButton in
2539         ATK's AccessibilityUIElement::uiElementAttributeValue().
2540
2541         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2542         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2543
2544 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2545
2546         [EFL] [GTK] Enable back crypto subtle on development builds.
2547         https://bugs.webkit.org/show_bug.cgi?id=159260
2548
2549         Reviewed by Carlos Garcia Campos.
2550
2551         * Scripts/webkitperl/FeatureList.pm:
2552
2553 2016-07-12  Mark Lam  <mark.lam@apple.com>
2554
2555         We should use different stack limits for stack checks from JS and host code.
2556         https://bugs.webkit.org/show_bug.cgi?id=159442
2557         <rdar://problem/26889188>
2558
2559         Reviewed by Geoffrey Garen.
2560
2561         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2562         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2563         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2564         order to keep the js/regress-139548.html test happy with this patch.
2565
2566         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2567         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2568
2569         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2570         (-[LTRelayController _environmentVariables]):
2571         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2572         (main):
2573
2574 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2575
2576         platformUserPreferredLanguages on Mac should not try to put the region into the language
2577         https://bugs.webkit.org/show_bug.cgi?id=159693
2578
2579         Rubber stamped by Alexey Proskuryakov.
2580         
2581         Revert the test change in r200105.
2582
2583         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2584         (TestWebKitAPI::languageForSystemLanguage):
2585
2586 2016-07-12  Chris Dumez  <cdumez@apple.com>
2587
2588         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2589         https://bugs.webkit.org/show_bug.cgi?id=159663
2590         <rdar://problem/18995873>
2591
2592         Reviewed by Benjamin Poulain.
2593
2594         Add API test coverage.
2595
2596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2597         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2598         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2599         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2600         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2601         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2602         (TEST):
2603
2604 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2605
2606         Relax ordering requirements on StringView::CodePoints iterator
2607         https://bugs.webkit.org/show_bug.cgi?id=159609
2608
2609         Reviewed by Darin Adler.
2610
2611         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2612         (TestWebKitAPI::TEST):
2613
2614 2016-07-12  Youenn Fablet  <youenn@apple.com>
2615
2616         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2617         https://bugs.webkit.org/show_bug.cgi?id=159564
2618
2619         Reviewed by Brian Burg.
2620
2621         * Scripts/webkitpy/codegen/main.py:
2622         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2623
2624 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2625
2626         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2627         https://bugs.webkit.org/show_bug.cgi?id=159671
2628
2629         Reviewed by Csaba Osztrogonác.
2630
2631         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2632         https://bugs.webkit.org/show_bug.cgi?id=89235
2633
2634         So this guard can be removed in build scripts.
2635
2636         * Scripts/webkitperl/FeatureList.pm:
2637         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2638
2639 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2640
2641         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2642         https://bugs.webkit.org/show_bug.cgi?id=159652
2643
2644         Reviewed by Daniel Bates.
2645
2646         * Scripts/webkitpy/common/checkout/scm/svn.py:
2647         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2648
2649 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2650
2651         Implement grapheme cluster iterator on StringView
2652         https://bugs.webkit.org/show_bug.cgi?id=159598
2653
2654         Reviewed by Anders Carlsson.
2655
2656         This is in preparation for honoring the second argument to FontFaceSet.load().
2657
2658         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2659         (TestWebKitAPI::compareLoopIterations):
2660         (TestWebKitAPI::TEST):
2661
2662 2016-07-11  Nan Wang  <n_wang@apple.com>
2663
2664         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2665         https://bugs.webkit.org/show_bug.cgi?id=158364
2666
2667         Reviewed by Anders Carlsson.
2668
2669         Added a function in TestRunner so that we can toggle the ignoring viewport
2670         scale limits setting. Also added a test option for that in order to change the 
2671         configuration of the webview in test.
2672
2673         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2675         (WTR::TestRunner::setNavigationGesturesEnabled):
2676         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2677         (WTR::nextUIScriptCallbackID):
2678         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2679         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2680         * WebKitTestRunner/TestController.cpp:
2681         (WTR::TestController::resetStateToConsistentValues):
2682         (WTR::updateTestOptionsFromTestHeader):
2683         (WTR::TestController::setNavigationGesturesEnabled):
2684         (WTR::TestController::setIgnoresViewportScaleLimits):
2685         (WTR::TestController::platformWillRunTest):
2686         * WebKitTestRunner/TestController.h:
2687         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2688         * WebKitTestRunner/TestInvocation.cpp:
2689         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2690         * WebKitTestRunner/TestOptions.h:
2691         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2692         (WTR::TestController::platformCreateWebView):
2693
2694 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2695
2696         [GTK] install-dependencies should not install packages built by jhbuild.
2697         https://bugs.webkit.org/show_bug.cgi?id=159628
2698
2699         Reviewed by Michael Catanzaro.
2700
2701         * gtk/install-dependencies:
2702         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2703
2704 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2705
2706         System proxy settings not used when building deps with jhbuild
2707         https://bugs.webkit.org/show_bug.cgi?id=159567
2708
2709         Reviewed by Michael Catanzaro.
2710
2711         This adds the gsettings-desktop-schemas-devel build dep to enable
2712         the libgiognomeproxy.so gio module in glib-networking, which uses
2713         GSettings on org.gnome.system.proxy.
2714         This is needed to query system proxy settings for Gnome desktops.
2715
2716         dconf can be manually added to jhbuild to build the
2717         libdconfsettings.so gio module for GSettings, so that
2718         libgiognomeproxy.so can access system settings.
2719           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2720
2721         As an alternative to dconf settings, this commit also adds the
2722         libproxy-devel build dep to enable the libgiolibproxy.so module in
2723         glib-networking (suggested by Fujii Hironori).
2724
2725         It is useful to read proxy settings from environment variables.
2726         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2727         environment variable to force using the envvar module in libproxy.
2728
2729         * gtk/install-dependencies:
2730
2731 2016-07-11  Mark Lam  <mark.lam@apple.com>
2732
2733         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2734         https://bugs.webkit.org/show_bug.cgi?id=159524
2735
2736         Reviewed by Michael Saboff.
2737
2738         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2739         Also fixed up some tests to behave better to work with this new limit.  This
2740         should make stack overflow tests complete sooner.
2741
2742         * Scripts/run-jsc-stress-tests:
2743         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2744         (main):
2745
2746 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2747
2748         [GTK] Whitespace fixes in install-dependencies script
2749
2750         Unreviewed.
2751
2752         * gtk/install-dependencies:
2753
2754 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2755
2756         [GTK] Install missing Fedora dependencies
2757
2758         Unreviewed.
2759
2760         * gtk/install-dependencies:
2761
2762 2016-07-09  Dan Bernstein  <mitz@apple.com>
2763
2764         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2765         https://bugs.webkit.org/show_bug.cgi?id=159600
2766
2767         Reviewed by Daniel Bates.
2768
2769         * Scripts/git-add-reviewer:
2770         Added the -s|--rubber-stamp option.
2771         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2772           new option.
2773
2774 2016-07-08  Andy Estes  <aestes@apple.com>
2775
2776         [Content Filtering] Load blocked pages more like other error pages are loaded
2777         https://bugs.webkit.org/show_bug.cgi?id=159485
2778         <rdar://problem/26014076>
2779
2780         Reviewed by Brady Eidson.
2781
2782         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2783         to a content filtering provisional navigation failure is ignored in preference of
2784         ContentFilter's own error page.
2785
2786         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2789         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2790         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2791         (loadAlternateTest):
2792         (TEST):
2793         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2794         (-[MockContentFilterEnabler initWithCoder:]):
2795         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2796         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2797         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2798         (TestWebKitAPI::loadAlternateTest):
2799         (TestWebKitAPI::TEST):
2800
2801 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2802
2803         Unreviewed, rolling out r202944.
2804         https://bugs.webkit.org/show_bug.cgi?id=159570
2805
2806         caused some tests to crash under GuardMalloc (Requested by
2807         estes on #webkit).
2808
2809         Reverted changeset:
2810
2811         "[Content Filtering] Load blocked pages more like other error
2812         pages are loaded"
2813         https://bugs.webkit.org/show_bug.cgi?id=159485
2814         http://trac.webkit.org/changeset/202944
2815
2816 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2817
2818         Remove mrobinson from the MathML watchlist
2819         https://bugs.webkit.org/show_bug.cgi?id=159559
2820
2821         Reviewed by Philippe Normand.
2822
2823         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2824
2825 2016-07-08  Brady Eidson  <beidson@apple.com>
2826
2827         Clearing LocalStorage doesn't also delete -wal and -shm files.
2828         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2829
2830         Reviewed by Brent Fulgham.
2831         Also helpfully picked over by Andy "Never Forgets" Estes.
2832
2833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2834         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2835         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2836
2837 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2838
2839         Removed Qt leftovers from Tools.
2840         https://bugs.webkit.org/show_bug.cgi?id=159557
2841
2842         Reviewed by Csaba Osztrogonác.
2843
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2845         Removed 'qt' platform config.
2846         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2847         Deleted non-functional e-mail address.
2848
2849 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2850
2851         Unreviewed, rolling out r202967.
2852         https://bugs.webkit.org/show_bug.cgi?id=159556
2853
2854         This patch caused crashes in https tests on Windows (Requested
2855         by perarne on #webkit).
2856
2857         Reverted changeset:
2858
2859         "[Win] The test http/tests/security/contentSecurityPolicy
2860         /upgrade-insecure-requests/basic-upgrade.https.html is
2861         failing."
2862         https://bugs.webkit.org/show_bug.cgi?id=159510
2863         http://trac.webkit.org/changeset/202967
2864
2865 2016-07-08  Youenn Fablet  <youenn@apple.com>
2866
2867         Generate WebCore builtin wrapper files
2868         https://bugs.webkit.org/show_bug.cgi?id=159461
2869
2870         Reviewed by Brian Burg.
2871
2872         * Scripts/webkitpy/codegen/main.py:
2873         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2874         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2875
2876 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2877
2878         [EFL] Fix build when media-stream is enabled.
2879         https://bugs.webkit.org/show_bug.cgi?id=159206
2880
2881         Bump up the openwebrtc to find the correct package.
2882
2883         Reviewed by Gyuyoung Kim.
2884
2885         * efl/jhbuild.modules:
2886         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2887
2888 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2889
2890         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2891         https://bugs.webkit.org/show_bug.cgi?id=159510
2892
2893         Reviewed by Brent Fulgham.
2894
2895         Allow any https certificate when running tests.
2896
2897         * DumpRenderTree/win/DumpRenderTree.cpp:
2898         (runTest):
2899
2900 2016-07-07  Beth Dakin  <bdakin@apple.com>
2901
2902         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2903         https://bugs.webkit.org/show_bug.cgi?id=159532
2904         -and corresponding-
2905         rdar://problem/27177179
2906
2907         Reviewed by Tim Horton.
2908
2909         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2910         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2911
2912 2016-07-07  Andy Estes  <aestes@apple.com>
2913
2914         [Content Filtering] Load blocked pages more like other error pages are loaded
2915         https://bugs.webkit.org/show_bug.cgi?id=159485
2916         <rdar://problem/26014076>
2917
2918         Reviewed by Brady Eidson.
2919
2920         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2921         to a content filtering provisional navigation failure is ignored in preference of
2922         ContentFilter's own error page.
2923
2924         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2927         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2928         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2929         (loadAlternateTest):
2930         (TEST):
2931         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2932         (-[MockContentFilterEnabler initWithCoder:]):
2933         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2934         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2935         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2936         (TestWebKitAPI::loadAlternateTest):
2937         (TestWebKitAPI::TEST):
2938
2939 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2940
2941         Unreviewed: add myself to the reviewers list.
2942
2943         * Scripts/webkitpy/common/config/contributors.json:
2944
2945 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2946
2947         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2948         https://bugs.webkit.org/show_bug.cgi?id=159509
2949
2950         Reviewed by Alex Christensen.
2951
2952         We should always insert the url in the url map when identifierForInitialRequest
2953         is called. Otherwise we can end up with identifiers not having an entry in the
2954         url map when urls are written to the test output file. 
2955
2956         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2957         (ResourceLoadDelegate::identifierForInitialRequest):
2958
2959 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2960
2961         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2962         https://bugs.webkit.org/show_bug.cgi?id=159498
2963         <rdar://problem/26719903>
2964
2965         Reviewed by Sam Weinig.
2966
2967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2968         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2969         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2970         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2971         (expectLinkCount):
2972         (TEST):
2973         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2974         when deciding what to linkify.
2975
2976 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2977
2978         Build fix - work around rdar://problem/27196668.
2979
2980         * LayoutTestRelay/Configurations/Base.xcconfig:
2981
2982 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2983
2984         Enhance Windows DRT implementation to support platform scroll wheel events.
2985         https://bugs.webkit.org/show_bug.cgi?id=36002
2986
2987         Reviewed by Brent Fulgham.
2988
2989         Implement function continuousMouseScrollBy in Windows event sender.
2990
2991         * DumpRenderTree/win/EventSender.cpp:
2992         (mouseScrollBy):
2993         (continuousMouseScrollBy):
2994
2995 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
2996
2997         [Sierra] Rebaseline tests to use un-mocked system font metrics
2998         https://bugs.webkit.org/show_bug.cgi?id=159311
2999         <rdar://problem/24138411>
3000
3001         Reviewed in person by Alexey Proskuryakov.
3002
3003         Stop mocking the system font on Sierra.
3004
3005         * DumpRenderTree/mac/DumpRenderTree.mm:
3006         (setDefaultsToConsistentValuesForTesting):
3007         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3008         (WTR::InjectedBundle::platformInitialize):
3009
3010 2016-07-05  Brady Eidson  <beidson@apple.com>
3011
3012         Database process crashes deleting a corrupt SQLite database file (null deref).
3013         https://bugs.webkit.org/show_bug.cgi?id=155506.
3014
3015         Reviewed by Alex Christensen.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3019         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3020         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3021         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3022         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3023
3024 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3025
3026         run-webkit-tests should print more complete baseline search paths
3027         https://bugs.webkit.org/show_bug.cgi?id=159354
3028
3029         Reviewed by Daniel Bates.
3030
3031         run-webkit-tests used to only print directory names in baseline search paths.
3032         This was ok in basic usage, but quickly got confusing when using
3033         --additional-platform-directory flags.
3034
3035         * Scripts/webkitpy/layout_tests/views/printing.py:
3036         (Printer.print_config):
3037         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3038         (Testprinter.test_print_config):
3039         (Testprinter.test_print_one_line_summary):
3040
3041 2016-07-04  Brady Eidson  <beidson@apple.com>
3042
3043         WebProcesses don't handle DatabaseProcess going away uncleanly..
3044         https://bugs.webkit.org/show_bug.cgi?id=159371
3045
3046         Reviewed by Alex Christensen.
3047
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3050         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3051         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3052         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3053
3054 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3055
3056         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3057         https://bugs.webkit.org/show_bug.cgi?id=158141
3058
3059         Rubber-stamped by Michael Catanzaro.
3060
3061         Instead of checking for an specific Ubuntu version, query the apt
3062         database to see which version of PHP is available.
3063
3064         * efl/install-dependencies:
3065         * gtk/install-dependencies:
3066
3067 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3068
3069         webkit-patch failure-reason always raises TypeError
3070         https://bugs.webkit.org/show_bug.cgi?id=159394
3071
3072         Reviewed by Benjamin Poulain.
3073
3074         In r170637 (Bug 133067), the first and second arguments of
3075         pluralize were swapped.
3076
3077         * Scripts/webkitpy/tool/commands/queries.py:
3078         (FailureReason._builder_to_explain): Swap the first and second
3079         arguments of pluralize.
3080
3081 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3082
3083         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3084         https://bugs.webkit.org/show_bug.cgi?id=152486
3085
3086         Reviewed by Daniel Bates.
3087
3088         Add launch of web-platform-tests server by run-webkit-httpd.
3089         Add two options to disable starting httpd and web-platform-tests servers.
3090
3091         * Scripts/run-webkit-httpd:
3092         (parse_args):
3093         (main):
3094
3095 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3096
3097         REGRESSION(r189668): Notification tests are flakey
3098         https://bugs.webkit.org/show_bug.cgi?id=159375
3099         <rdar://problem/22760990>
3100
3101         Reviewed by Alexey Proskuryakov.
3102
3103         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3104         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3105         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3106         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3107
3108         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3109         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3110         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3111         global notification ID mapping, causing the wrong notification to be investigated.
3112
3113         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3114         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3115         notification is created or destroyed. However, because this object is implemented outside WebKit,
3116         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3117         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3118         WebNotificationProvider can properly map between the different IDs.
3119
3120         * WebKitTestRunner/TestController.cpp:
3121         (WTR::TestController::runTestingServerLoop):
3122         (WTR::TestController::simulateWebNotificationClick):
3123         * WebKitTestRunner/WebNotificationProvider.cpp:
3124         (WTR::WebNotificationProvider::showWebNotification):
3125         (WTR::removeGlobalIDFromIDMap):
3126         (WTR::WebNotificationProvider::closeWebNotification):
3127         (WTR::WebNotificationProvider::removeNotificationManager):
3128         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3129         (WTR::WebNotificationProvider::reset):
3130         * WebKitTestRunner/WebNotificationProvider.h:
3131
3132 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3133
3134         Simplify LayoutTestRelay
3135         https://bugs.webkit.org/show_bug.cgi?id=159353
3136
3137         Reviewed by Daniel Bates.
3138
3139         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3140         by name and runtime makes no sense.
3141         2. Removed code to create devices, webkitpy always does this in advance.
3142         3. Don't create copies of testing apps - we can install the same one into
3143         each simulator, now that we don't run multiple tester processes in a single simulator.
3144         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3145         5. Removed code that kept testing apps alive in the background.
3146         6. Slightly updated coding style in functions that I touched.
3147
3148         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3149         Updated for what we acually use at this point.
3150
3151         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3152         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3153         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3154         (-[LTRelayController ipcIdentifier]):
3155         (-[LTRelayController processName]):
3156         (-[LTRelayController didReceiveStdoutData:]):
3157         (-[LTRelayController didCrashWithMessage:]):
3158         (-[LTRelayController installApp]):
3159         (-[LTRelayController _environmentVariables]):
3160         (-[LTRelayController launchApp]):
3161         (-[LTRelayController start]):
3162         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3163         (-[LTRelayController uniqueAppPath]): Deleted.
3164         (-[LTRelayController uniqueAppURL]): Deleted.
3165         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3166         (-[LTRelayController createUniqueApp]): Deleted.
3167         * LayoutTestRelay/LayoutTestRelay/main.m:
3168         (usage):
3169         (getRequiredStringArgument):
3170         (main):
3171         (getTestingSimDevice): Deleted.
3172         * Scripts/webkitpy/port/driver.py:
3173         (IOSSimulatorDriver.cmd_line):
3174         * WebKitTestRunner/ios/TestControllerIOS.mm:
3175         (WTR::TestController::platformInitialize):
3176         * WebKitTestRunner/ios/mainIOS.mm:
3177         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3178         * DumpRenderTree/mac/DumpRenderTree.mm:
3179         (dumpRenderTree):
3180         (-[DumpRenderTree applicationDidEnterBackground:]):
3181
3182 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3183
3184         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3185         https://bugs.webkit.org/show_bug.cgi?id=159344
3186
3187         Reviewed by Alex Christensen.
3188
3189         * DumpRenderTree/CMakeLists.txt:
3190
3191 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3192
3193         Add a runtime flag for DOM iterators
3194         https://bugs.webkit.org/show_bug.cgi?id=159300
3195
3196         Reviewed by Alex Christensen.
3197
3198         * DumpRenderTree/mac/DumpRenderTree.mm:
3199         (resetWebPreferencesToConsistentValues):
3200         * DumpRenderTree/win/DumpRenderTree.cpp:
3201         (resetWebPreferencesToConsistentValues):
3202         * Scripts/webkitperl/FeatureList.pm:
3203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3204         (WTR::InjectedBundle::beginTesting):
3205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3206         (WTR::TestRunner::setDOMIteratorEnabled):
3207         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3208
3209 2016-06-30  Tina Liu  <iting_liu@apple.com>
3210
3211         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3212         https://bugs.webkit.org/show_bug.cgi?id=159326
3213
3214         Reviewed by Brady Eidson.
3215
3216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3217         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3218         (TestWebKitAPI::didFinishLoadForFrame):
3219         (TestWebKitAPI::didChangeBackForwardListForPage):
3220         (TestWebKitAPI::setPageLoaderClient):
3221         Set the page loader client and register for didFinishLoadForFrame and
3222         didChangeBackForwardList callbacks.
3223         (TestWebKitAPI::createSessionStateData):
3224         Load a webpage ("simple.html") and return the session state for this page.
3225         (TestWebKitAPI::TEST):
3226         Restore the page session state with that of "simple.html" without navigation.
3227         Verify that the committed URL is NULL since there's no navigation involved.
3228         Verify that the current item in the back forward list, which should be what
3229         we restored from the session state, has the expected URL.
3230
3231 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3232
3233         Generators violate bytecode liveness validation
3234         https://bugs.webkit.org/show_bug.cgi?id=159279
3235
3236         Reviewed by Yusuke Suzuki.
3237         
3238         Add Basic to our test harness.
3239
3240         * Scripts/run-javascriptcore-tests:
3241         (runJSCStressTests):
3242
3243 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3244
3245         [Win][Debug] Assertion fails in TestWTF.
3246         https://bugs.webkit.org/show_bug.cgi?id=159299
3247
3248         Reviewed by Alex Christensen.
3249
3250         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3251         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3252         the assertion failure. Since the variable is actually used, there is no need to use the
3253         UNUSED_PARAM macro.
3254
3255         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3256         (TestWebKitAPI::TEST):
3257
3258 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3259
3260         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3261         https://bugs.webkit.org/show_bug.cgi?id=159166
3262         <rdar://problem/27051759>
3263
3264         Reviewed by Alexey Proskuryakov.
3265
3266         Setting the certificate directory to the copied config.json.
3267
3268         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3269         (WebPlatformTestServer._copy_webkit_test_files):
3270
3271 2016-06-29  Mark Lam  <mark.lam@apple.com>
3272
3273         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3274         https://bugs.webkit.org/show_bug.cgi?id=159274
3275
3276         Reviewed by Keith Miller.
3277
3278         * DumpRenderTree/mac/DumpRenderTree.mm:
3279         (DumpRenderTreeMain):
3280
3281 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3282
3283         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3284         https://bugs.webkit.org/show_bug.cgi?id=159176
3285
3286         Reviewed by Sam Weinig.
3287
3288         * MiniBrowser/mac/WK2BrowserWindowController.m:
3289         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3290         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3291         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3292
3293 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3294
3295         [GTK] Add missing install dependency after r202619
3296         https://bugs.webkit.org/show_bug.cgi?id=156716
3297
3298         Unreviewed.
3299
3300         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3301
3302 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3303
3304         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3305         https://bugs.webkit.org/show_bug.cgi?id=156716
3306
3307         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3308
3309         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3310         (parse_args):
3311         * Scripts/webkitpy/port/gtk.py:
3312         (GtkPort.__init__):
3313         (GtkPort._driver_class):
3314         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3315         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3316         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3317         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3318         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3319         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3320         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3321         (WestonDriver.check_driver):
3322         (WestonDriver.__init__):
3323         (WestonDriver._start):
3324         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3325         (WestonXvfbDriverDisplayTest):
3326         (WestonXvfbDriverDisplayTest.__init__):
3327         (WestonXvfbDriverDisplayTest._xvfb_run):
3328         (WestonDriverTest.make_driver):
3329         (WestonDriverTest.test_start):
3330         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3331         or to satisfy the pkg-config check of the new added modules in JHBuild.
3332         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3333         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3334         provided by the system are already new enough.
3335         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3336         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3337         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3338         feature to avoid building libdrm when the one provided by the system is new enough.
3339         * gtk/jhbuildrc:
3340         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3341         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3342         This patch implements support for that reusing the same variable that we use with Mesa to set the
3343         custom path for the DRI drivers path.
3344
3345 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3346
3347         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3348         https://bugs.webkit.org/show_bug.cgi?id=159256
3349
3350         Reviewed by Philippe Normand.
3351
3352         We need the last fixes in the repository to make the scream queue
3353         work with apprtc.
3354
3355         * gtk/jhbuild.modules:
3356
3357 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3358
3359         Unreviewed, rolling out r202580.
3360         https://bugs.webkit.org/show_bug.cgi?id=159245
3361
3362         Caused all WKTR tests to fail on GuardMalloc and Production
3363         only for unknown reasons, investigating offline. (Requested by
3364         brrian on #webkit).
3365
3366         Reverted changeset:
3367
3368         "RunLoop::Timer should use constructor templates instead of
3369         class templates"
3370         https://bugs.webkit.org/show_bug.cgi?id=159153
3371         http://trac.webkit.org/changeset/202580
3372
3373 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3374
3375         Use a regex to check if a test step is for JavaScriptCore
3376         https://bugs.webkit.org/show_bug.cgi?id=159224
3377
3378         Reviewed by Geoffrey Garen.
3379
3380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3381         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3383         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3385         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3386
3387 2016-06-28  Michael Saboff  <msaboff@apple.com>
3388
3389         btjs no longer accepts optional frame count argument
3390         https://bugs.webkit.org/show_bug.cgi?id=159235
3391
3392         Reviewed by Saam Barati.
3393
3394         Fix the detection of optional backtrace-depth parameter to use the length
3395         of the command.
3396
3397         * lldb/lldb_webkit.py:
3398         (btjs):
3399
3400 2016-06-28  Jon Lee  <jonlee@apple.com>
3401
3402         Update animometer.plan
3403
3404         Rubber-stamped by Said Abou-Hallawa.
3405
3406         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3407
3408 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3409
3410         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3411
3412         * Scripts/run-javascriptcore-tests:
3413         (runJSCStressTests):
3414
3415 2016-06-28  Brian Burg  <bburg@apple.com>
3416
3417         RunLoop::Timer should use constructor templates instead of class templates
3418         https://bugs.webkit.org/show_bug.cgi?id=159153
3419
3420         Reviewed by Alex Christensen.
3421
3422         Remove the RunLoop::Timer class template argument, and pass its constructor
3423         a reference to `this` instead of a pointer to `this`.
3424
3425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3426         (WTR::TestRunner::TestRunner):
3427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3428         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3429         (TestWebKitAPI::TEST):
3430
3431 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3432
3433         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3434         https://bugs.webkit.org/show_bug.cgi?id=159199
3435
3436         Reviewed by Alexey Proskuryakov.
3437
3438         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3439
3440         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3441         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3442         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3443         an input element getting automatically focused on Mac.
3444
3445 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3446
3447         [Win] Custom elements tests are failing.
3448         https://bugs.webkit.org/show_bug.cgi?id=159139
3449
3450         Reviewed by Alex Christensen.
3451
3452         Enable custom element API when running tests.
3453
3454         * DumpRenderTree/win/DumpRenderTree.cpp:
3455         (resetWebPreferencesToConsistentValues):
3456
3457 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3458
3459         Test commit. Please ignore.
3460         
3461 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3462
3463         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3464         https://bugs.webkit.org/show_bug.cgi?id=155073
3465
3466         Reviewed by Daniel Bates.
3467
3468         * Scripts/webkitperl/FeatureList.pm:
3469
3470 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3471
3472         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3473         https://bugs.webkit.org/show_bug.cgi?id=159077
3474
3475         Reviewed by Tim Horton.
3476
3477         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3478
3479         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3480         which is necessary for UI-side compositing.
3481
3482         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3483         seems to happen for some tests that call window.resizeTo().
3484
3485         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3486         (WTR::InjectedBundlePage::dump): Deleted.
3487         * WebKitTestRunner/TestInvocation.cpp:
3488         (WTR::TestInvocation::dumpResults):
3489         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3490         (WTR::createCGContextFromImage):
3491         (WTR::computeMD5HashStringForContext):
3492         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3493         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3494         (WTR::PlatformWebView::windowSnapshotImage):
3495
3496 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3497
3498         [EFL] Support to build on Debian linux
3499         https://bugs.webkit.org/show_bug.cgi?id=159123
3500
3501         Reviewed by Antonio Gomes.
3502
3503         * efl/install-dependencies: Install libgnutls28-dev.
3504
3505 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3506
3507         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3508         https://bugs.webkit.org/show_bug.cgi?id=159071
3509
3510         Reviewed by Brady Eidson.
3511
3512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3514         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3515         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3516         (WTR::TestRunner::setAuthenticationUsername):
3517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3518         * WebKitTestRunner/TestController.cpp:
3519         (WTR::TestController::TestController):
3520         (WTR::TestController::resetStateToConsistentValues):
3521         (WTR::TestController::didFinishNavigation):
3522         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3523         (WTR::TestController::didReceiveAuthenticationChallenge):
3524         (WTR::TestController::didCommitNavigation):
3525         * WebKitTestRunner/TestController.h:
3526         (WTR::TestController::setBlockAllPlugins):
3527         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3528         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3529         (WTR::TestController::isCurrentInvocation):
3530         * WebKitTestRunner/TestInvocation.cpp:
3531         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3532         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3533
3534 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3535
3536         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3537         https://bugs.webkit.org/show_bug.cgi?id=159129
3538
3539         Reviewed by Alex Christensen.
3540
3541         Implement the function mouseScrollBy in the Windows event sender.
3542
3543         * DumpRenderTree/win/EventSender.cpp:
3544         (mouseScrollBy):
3545         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3546
3547 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3548
3549         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3550         https://bugs.webkit.org/show_bug.cgi?id=159104
3551
3552         Reviewed by Dan Bernstein.
3553         
3554         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3555         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3556
3557         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3558         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3560
3561 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3562
3563         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3564         https://bugs.webkit.org/show_bug.cgi?id=159086
3565
3566         Reviewed by Alex Christensen.
3567
3568         Implement required wheel event function in event sender.
3569  
3570         * DumpRenderTree/win/EventSender.cpp:
3571         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3572
3573 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3574
3575         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3576         https://bugs.webkit.org/show_bug.cgi?id=159104
3577
3578         Reviewed by Mark Lam.
3579         
3580         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3581         WK.
3582
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584
3585 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3586
3587         parser_unittests.pl should not hardcode list of tests
3588         <https://webkit.org/b/159074>
3589
3590         Reviewed by Daniel Bates.
3591
3592         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3593         Update to read the list of tests from the 'resources' directory,
3594         and instead map file extensions to subroutine names.  Switch to
3595         use File::Basename::fileparse() to get basename and file
3596         extension for each test.
3597         (readTestFiles): Added.  Reads files from the directory passed
3598         in and ignores: hidden files, anything that isn't a plain file,
3599         and expected test results files.
3600
3601 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3602
3603         Fix Windows build.
3604
3605         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3606         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3607
3608 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3609
3610         [EFL] Change download path of libxslt
3611
3612         Unreviewed EFL build fix.
3613
3614         In Korea current download path can't be accessed. Change it.
3615
3616         * efl/jhbuild.modules:
3617
3618 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3619
3620         https://bugs.webkit.org/show_bug.cgi?id=159077
3621
3622         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3623         snapshot the final state of the test in release builds. 
3624
3625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3626         (WTR::InjectedBundlePage::dump):
3627
3628 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3629
3630         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3631
3632         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3633         (createBitmapContextFromWebView):
3634         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3635         (WTR::PlatformWebView::windowSnapshotImage):
3636
3637 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3638
3639         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3640         https://bugs.webkit.org/show_bug.cgi?id=159077
3641
3642         Reviewed by Tim Horton.
3643
3644         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3645         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3646         thus enabling testing of more things.
3647
3648         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3649         (createBitmapContext): Moved to this file to share it.
3650         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3651         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3652         (createBitmapContextFromWebView):
3653         (BitmapContext::createFromUIImage): Deleted.
3654         (BitmapContext::pixelData): Deleted.
3655         (BitmapContext::BitmapContext): Deleted.
3656         (computeMD5HashStringForBitmapContext): Deleted.
3657         (dumpBitmap): Deleted.
3658         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3659         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3660         (createPagedBitmapContext):
3661         (createBitmapContext): Deleted.
3662         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3664         (WTR::InjectedBundlePage::dump): Deleted.
3665         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3666         (WTR::PlatformWebView::windowSnapshotImage):
3667
3668 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3669
3670         [jhbuild] Added libxslt module.
3671         https://bugs.webkit.org/show_bug.cgi?id=159034
3672
3673         Unreviewed, followup for r202373.
3674
3675         * efl/install-dependencies: Removed libxslt 
3676         * gtk/install-dependencies: Ditto.
3677
3678 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3679
3680         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3681         https://bugs.webkit.org/show_bug.cgi?id=159050
3682
3683         Reviewed by Antonio Gomes.
3684
3685         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3686
3687         * efl/jhbuild.modules:
3688         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3689         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3690
3691 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3692
3693         [jhbuild] Added libxslt module.
3694         https://bugs.webkit.org/show_bug.cgi?id=159034
3695
3696         Reviewed by Michael Catanzaro.
3697
3698         * efl/jhbuild.modules:
3699         * gtk/jhbuild.modules:
3700
3701 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3702
3703         [Win] Use Windows api function to find top level parent.
3704         https://bugs.webkit.org/show_bug.cgi?id=159021
3705
3706         Reviewed by Brent Fulgham.
3707
3708         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3709  
3710         * DumpRenderTree/win/UIDelegate.cpp:
3711         (UIDelegate::runModal):
3712         (findTopLevelParent): Deleted.
3713         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3714         (PrintWebUIDelegate::runModal):
3715         (findTopLevelParent): Deleted.
3716
3717 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3718
3719         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3720         https://bugs.webkit.org/show_bug.cgi?id=158934
3721
3722         Reviewed by Brent Fulgham.
3723
3724         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3725
3726         * DumpRenderTree/win/TestRunnerWin.cpp:
3727         (TestRunner::clearAllDatabases):
3728
3729 2016-06-22  Saam Barati  <sbarati@apple.com>
3730
3731         run-javascriptcore-tests should have some environment variables for commonly used settings
3732         https://bugs.webkit.org/show_bug.cgi?id=159047
3733
3734         Reviewed by Keith Miller.
3735
3736         This patch adds three environment variables that run-javascriptcore-tests
3737         consults:
3738         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3739           determines if we should run the api tests or not.
3740         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3741           determines if we will perform a build or not before running the tests.
3742           to set the default should-build setting.
3743         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3744           a yaml file. If set, we will run the extra tests it refers to.
3745
3746         All the values in these environment variables will be overridden if an
3747         option is explicitly passed in. For example, the following will run
3748         the api tests:
3749         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3750
3751         * Scripts/run-javascriptcore-tests:
3752
3753 2016-06-22  Saam barati  <sbarati@apple.com>
3754
3755         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3756         https://bugs.webkit.org/show_bug.cgi?id=159037
3757         <rdar://problem/26935349>
3758
3759         Reviewed by Benjamin Poulain.
3760
3761         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3762
3763         * Scripts/run-jsc-stress-tests:
3764
3765 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3766
3767         Fix style issues in webkitpy
3768         https://bugs.webkit.org/show_bug.cgi?id=159019
3769
3770         Reviewed by Daniel Bates.
3771
3772         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3773         There is no functionality change.
3774         Only affected file names retained below for brevity.
3775
3776         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3777         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3778         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3779         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3780         * Scripts/webkitpy/benchmark_runner/utils.py:
3781         * Scripts/webkitpy/common/checkout/changelog.py:
3782         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3783         * Scripts/webkitpy/common/checkout/checkout.py:
3784         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3785         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3786         * Scripts/webkitpy/common/checkout/commitinfo.py:
3787         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3788         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3789         * Scripts/webkitpy/common/checkout/scm/scm.py:
3790         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3791         * Scripts/webkitpy/common/config/committers_unittest.py:
3792         * Scripts/webkitpy/common/config/irc.py:
3793         * Scripts/webkitpy/common/config/ports.py:
3794         * Scripts/webkitpy/common/config/ports_unittest.py:
3795         * Scripts/webkitpy/common/config/urls.py:
3796         * Scripts/webkitpy/common/host_mock.py:
3797         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3798         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3799         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3800         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3801         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3802         * Scripts/webkitpy/common/net/credentials_unittest.py:
3803         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3804         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3805         * Scripts/webkitpy/common/net/statusserver.py:
3806         * Scripts/webkitpy/common/system/autoinstall.py:
3807         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3808         * Scripts/webkitpy/common/system/executive.py:
3809         * Scripts/webkitpy/common/system/executive_mock.py:
3810         * Scripts/webkitpy/common/system/executive_unittest.py:
3811         * Scripts/webkitpy/common/system/filesystem_mock.py:
3812         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3813         * Scripts/webkitpy/common/system/logutils_unittest.py:
3814         * Scripts/webkitpy/common/system/path.py:
3815         * Scripts/webkitpy/common/system/path_unittest.py:
3816         * Scripts/webkitpy/common/system/platforminfo.py:
3817         * Scripts/webkitpy/common/system/user.py:
3818         * Scripts/webkitpy/common/system/user_unittest.py:
3819         * Scripts/webkitpy/common/system/workspace_unittest.py:
3820         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3821         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3822         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3823         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3824         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3825         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3826         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3827         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3828         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3829         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3830         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3831         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3832         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3833         * Scripts/webkitpy/layout_tests/views/printing.py:
3834         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3835         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3836         * Scripts/webkitpy/port/base_unittest.py:
3837         * Scripts/webkitpy/port/driver.py:
3838         * Scripts/webkitpy/port/driver_unittest.py:
3839         * Scripts/webkitpy/port/factory.py:
3840         * Scripts/webkitpy/port/gtk.py:
3841         * Scripts/webkitpy/port/server_process_unittest.py:
3842         * Scripts/webkitpy/port/test.py:
3843         * Scripts/webkitpy/port/win.py:
3844         * Scripts/webkitpy/style/checker.py:
3845         * Scripts/webkitpy/style/checkers/common_unittest.py:
3846         * Scripts/webkitpy/style/checkers/cpp.py:
3847         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3848         * Scripts/webkitpy/style/checkers/js.py:
3849         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3850         * Scripts/webkitpy/style/checkers/png.py:
3851         * Scripts/webkitpy/style/checkers/text.py:
3852         * Scripts/webkitpy/style/checkers/text_unittest.py:
3853         * Scripts/webkitpy/style/error_handlers.py:
3854         * Scripts/webkitpy/style/filter.py:
3855         * Scripts/webkitpy/style/filter_unittest.py:
3856         * Scripts/webkitpy/style/optparser.py:
3857         * Scripts/webkitpy/style/optparser_unittest.py:
3858         * Scripts/webkitpy/test/main.py:
3859         * Scripts/webkitpy/w3c/test_converter.py:
3860         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3861         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3862         * Scripts/webkitpy/xcode/simulator.py:
3863
3864 2016-06-22  Brady Eidson  <beidson@apple.com>
3865
3866         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3867         https://bugs.webkit.org/show_bug.cgi?id=158894
3868
3869         Reviewed by Alex Christensen.
3870
3871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3872         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3873         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3874         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3875
3876 2016-06-22  Jon Lee  <jonlee@apple.com>
3877
3878         Update animometer.plan
3879         https://bugs.webkit.org/show_bug.cgi?id=159012
3880
3881         Reviewed by Ryosuke Niwa.
3882
3883         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3884
3885 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3886
3887         W3C test importer should generate files to ignore by WebKit SCM
3888         https://bugs.webkit.org/show_bug.cgi?id=142743
3889
3890         Reviewed by Darin Adler.
3891
3892         TestDownloader generates the .gitignore file according submodules git repository information.
3893         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3894
3895         * Scripts/webkitpy/w3c/test_downloader.py:
3896         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3897         * Scripts/webkitpy/w3c/test_importer.py:
3898         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3899         (TestImporter):
3900         (TestImporter.write_init_py): Writing not empty __init__.py files.
3901         (TestImporter.import_tests): Using  of write_init_py. 
3902         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3903         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3904         (TestImporterTest):
3905         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3906
3907 2016-06-21  Sam Weinig  <sam@webkit.org>
3908
3909         WKWebView with no WKNavigationDelegate does not follow universal links
3910         <rdar://problem/24374110>
3911         https://bugs.webkit.org/show_bug.cgi?id=158997
3912
3913         Reviewed by Dan Bernstein.
3914
3915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3916         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3917         Add a new test that shows that we have a default navigation delegate by swizzling
3918         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3919
3920 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3921
3922         [Win] Implement modal dialog support in MiniBrowser.
3923         https://bugs.webkit.org/show_bug.cgi?id=158976
3924
3925         Reviewed by Brent Fulgham.
3926
3927         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3928         (PrintWebUIDelegate::createWebViewWithRequest):
3929         (getHandleFromWebView):
3930         (PrintWebUIDelegate::webViewClose):
3931         (PrintWebUIDelegate::setFrame):
3932         (PrintWebUIDelegate::webViewFrame):
3933         (PrintWebUIDelegate::canRunModal):
3934         (findTopLevelParent):
3935         (PrintWebUIDelegate::runModal):
3936         (PrintWebUIDelegate::createModalDialog):
3937         * MiniBrowser/win/PrintWebUIDelegate.h:
3938         (PrintWebUIDelegate::webViewClose):
3939         (PrintWebUIDelegate::setFrame):
3940         (PrintWebUIDelegate::webViewFrame):
3941         (PrintWebUIDelegate::canRunModal):
3942         (PrintWebUIDelegate::runModal):
3943
3944 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3945
3946         window.showModalDialog doesn't work in DumpRenderTree on Windows
3947         https://bugs.webkit.org/show_bug.cgi?id=53675
3948
3949         Reviewed by Brent Fulgham.
3950
3951         Implement modal dialog support in DumpRenderTree.
3952
3953         * DumpRenderTree/win/UIDelegate.cpp:
3954         (UIDelegate::canRunModal):
3955         (getHandleFromWebView):
3956         (UIDelegate::createModalDialog):
3957         (findTopLevelParent):
3958         (UIDelegate::runModal):
3959         (UIDelegate::webViewClose):
3960         * DumpRenderTree/win/UIDelegate.h:
3961
3962 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3963
3964         Fix formatting issues reported by check-webkit-style
3965         https://bugs.webkit.org/show_bug.cgi?id=159008
3966
3967         Reviewed by Alexey Proskuryakov.
3968
3969         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3970         There is no functionality change.
3971
3972         * Scripts/webkitpy/tool/bot/irc_command.py:
3973         (Restart.execute):
3974         (Rollout):
3975         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3976         (IRCBotTest.test_exception_during_command):
3977         (IRCBotTest.test_exception_during_command.CommandWithException):
3978         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3979         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3980         (test_missing_unit_test_results_path):
3981         (test_layout_test_results):
3982         * Scripts/webkitpy/tool/bot/queueengine.py:
3983         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3984         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3985         (AbstractSequencedCommand):
3986         (AbstractSequencedCommand.__init__):
3987         * Scripts/webkitpy/tool/commands/download.py:
3988         (Land):
3989         * Scripts/webkitpy/tool/commands/openbugs.py:
3990         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3991         (OpenBugsTest):
3992         * Scripts/webkitpy/tool/commands/queries.py:
3993         (PatchesToCommitQueue):
3994         (PatchesToCommitQueue.__init__):
3995         (PatchesToCommitQueue._needs_commit_queue):
3996         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3997         (PrintExpectationsTest.test_platform):
3998         (PrintBaselinesTest):
3999         (PrintBaselinesTest.setUp):
4000         * Scripts/webkitpy/tool/commands/queues.py:
4001         (AbstractQueue):
4002         (AbstractQueue.__init__):
4003         (AbstractQueue.execute):
4004         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4005         (test_auto_retry):
4006         * Scripts/webkitpy/tool/commands/rebaseline.py:
4007         (AbstractParallelRebaselineCommand._files_to_add):
4008         (AbstractParallelRebaselineCommand):
4009         (AbstractParallelRebaselineCommand._rebaseline):
4010         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4011         (SetupGitClone):
4012         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4013         * Scripts/webkitpy/tool/commands/stepsequence.py:
4014         * Scripts/webkitpy/tool/commands/upload.py:
4015         (PostCommits._comment_text_for_commit):
4016         (PostCommits):
4017         (PostCommits.execute):
4018         (MarkBugFixed):
4019         (MarkBugFixed.__init__):
4020         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4021         (UploadCommandsTest):
4022         (UploadCommandsTest.test_commit_message_for_current_diff):
4023         * Scripts/webkitpy/tool/grammar_unittest.py:
4024         (GrammarTest):
4025         (GrammarTest.test_join_with_separators):
4026         * Scripts/webkitpy/tool/multicommandtool.py:
4027         (HelpCommand.__init__):
4028         (HelpCommand):
4029         (HelpCommand._help_epilog):
4030         (HelpCommand._remove_help_options):
4031         (MultiCommandTool):
4032         (MultiCommandTool.__init__):
4033         (MultiCommandTool.main):
4034         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4035         (TrivialCommand):
4036         (TrivialCommand.__init__):
4037         (MultiCommandToolTest):
4038         (MultiCommandToolTest._assert_tool_main_outputs):
4039         (MultiCommandToolTest.test_retry):
4040         (test_command_help):
4041         * Scripts/webkitpy/tool/steps/__init__.py:
4042         * Scripts/webkitpy/tool/steps/abstractstep.py:
4043         * Scripts/webkitpy/tool/steps/applypatch.py:
4044         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4045         (ApplyPatchWithLocalCommit):
4046         (ApplyPatchWithLocalCommit.options):
4047         * Scripts/webkitpy/tool/steps/build.py:
4048         * Scripts/webkitpy/tool/steps/checkstyle.py:
4049         (CheckStyle):
4050         (CheckStyle.options):
4051         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4052         * Scripts/webkitpy/tool/steps/closebug.py:
4053         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4054         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4055         (CloseBugForLandDiffTest):
4056         (CloseBugForLandDiffTest.test_empty_state):
4057         * Scripts/webkitpy/tool/steps/closepatch.py:
4058         * Scripts/webkitpy/tool/steps/commit.py:
4059         (Commit.run):
4060         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4061         * Scripts/webkitpy/tool/steps/editchangelog.py:
4062         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4063         * Scripts/webkitpy/tool/steps/metastep.py:
4064         (MetaStep):
4065         (MetaStep.__init__):
4066         (MetaStep.run):
4067         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4068         * Scripts/webkitpy/tool/steps/options.py:
4069         (Options):
4070         * Scripts/webkitpy/tool/steps/postdiff.py:
4071         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4072         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
4073         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4074         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4075         (PrepareChangeLogTest):
4076         (PrepareChangeLogTest.test_resolve_existing_entry):
4077         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4078         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
4079         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4080         * Scripts/webkitpy/tool/steps/revertrevision.py:
4081         * Scripts/webkitpy/tool/steps/runtests.py:
4082         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4083         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4084         (StepsTest):
4085         (StepsTest._step_options):
4086         * Scripts/webkitpy/tool/steps/update.py:
4087         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4088         (UpdateChangeLogsWithReviewerTest):
4089         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4090         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4091         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4092
4093 2016-06-21  Chris Dumez  <cdumez@apple.com>
4094
4095         Unreviewed, rolling out r202296.
4096
4097         Broke basic browsing in Safari
4098
4099         Reverted changeset:
4100
4101         "WKWebView with no WKNavigationDelegate does not follow
4102         universal links"
4103         https://bugs.webkit.org/show_bug.cgi?id=158997
4104         http://trac.webkit.org/changeset/202296
4105
4106 2016-06-21  Anders Carlsson  <andersca@apple.com>
4107
4108         Fix build.
4109
4110         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4111
4112 2016-06-21  Anders Carlsson  <andersca@apple.com>
4113
4114         Begin moving the Apple Pay code to the open source repository
4115         https://bugs.webkit.org/show_bug.cgi?id=158998
4116
4117         Reviewed by Tim Horton.
4118
4119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4120         Add ENABLE_APPLE_PAY.
4121
4122 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
4123
4124         Add system tracing points for requestAnimationFrame() workflow
4125         https://bugs.webkit.org/show_bug.cgi?id=158723
4126
4127         Reviewed by Simon Fraser.
4128
4129         Add new plist entries to be used by kdebug_trace() viewing tools.
4130
4131         * Tracing/SystemTracePoints.plist:
4132
4133 2016-06-21  Sam Weinig  <sam@webkit.org>
4134
4135         WKWebView with no WKNavigationDelegate does not follow universal links
4136         <rdar://problem/24374110>
4137         https://bugs.webkit.org/show_bug.cgi?id=158997
4138
4139         Reviewed by Dan Bernstein.
4140
4141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4142         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4143         Add a new test that shows that we have a default navigation delegate by swizzling
4144         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4145
4146 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4147
4148         run-javascriptcore-tests should have flag to skip mozilla tests
4149         https://bugs.webkit.org/show_bug.cgi?id=158963
4150         rdar://problem/25838924
4151
4152         Reviewed by Alexey Proskuryakov.
4153
4154         * Scripts/run-javascriptcore-tests:
4155         (runJSCStressTests): Added flag to skip mozilla tests.
4156
4157 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4158
4159         Unreviewed, rolling out r202136.
4160         https://bugs.webkit.org/show_bug.cgi?id=158932
4161
4162         JSBench wasn't regressed by r202002 and r202111 on iOS after
4163         all (Requested by rniwa_ on #webkit).
4164
4165         Reverted changeset:
4166
4167         "Unreviewed, rolling out r202002 and r202111."
4168         https://bugs.webkit.org/show_bug.cgi?id=158638
4169         http://trac.webkit.org/changeset/202136
4170
4171 2016-06-20  Keith Rollin  <krollin@apple.com>
4172
4173         Remove RefPtr::release() and change calls sites to use WTFMove()
4174         https://bugs.webkit.org/show_bug.cgi?id=158369
4175
4176         Reviewed by Chris Dumez.
4177
4178         RefPtr::release() releases its managed pointer awkwardly. It's more
4179         direct and clearer to use WTFMove to transfer ownership of the managed
4180         pointer.
4181
4182         As part of this cleanup, also change a lot of explicit data types to
4183         'auto'.
4184
4185         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4186         (createBitmapContextFromWebView):
4187         (createPagedBitmapContext):
4188         * DumpRenderTree/mac/TestRunnerMac.mm:
4189         (TestRunner::setMockGeolocationPosition):
4190         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4191         (TestWebKitAPI::TEST):
4192         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4193         (TestWebKitAPI::TEST):
4194
4195 2016-06-20  Tim Horton  <timothy_horton@apple.com>
4196
4197         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
4198         https://bugs.webkit.org/show_bug.cgi?id=158947
4199
4200         Reviewed by Simon Fraser.
4201
4202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4203         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
4204         (TestWebKitAPI::didFinishLoadForFrame):
4205         (TestWebKitAPI::setPageLoaderClient):
4206         (TestWebKitAPI::TEST):
4207         Add a test ensuring that in-window state changes are deferred when using
4208         the SPI for deferring them, as fixed in r202230.
4209
4210 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4211
4212         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
4213         https://bugs.webkit.org/show_bug.cgi?id=158931
4214
4215         Reviewed by Alexey Proskuryakov.
4216
4217         * WebKitTestRunner/TestInvocation.cpp:
4218         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
4219
4220 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
4221
4222         Add test expectations for macOS Sierra
4223         https://bugs.webkit.org/show_bug.cgi?id=158903
4224
4225         Reviewed by Alex Christensen.
4226
4227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
4228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
4229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4231         Added dashboard support.
4232
4233         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4234         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
4235         Trigger the right build queues on check-in.
4236
4237         * Scripts/webkitpy/common/system/platforminfo.py:
4238         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
4239         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4240         * Scripts/webkitpy/port/mac.py:
4241         * Scripts/webkitpy/port/mac_unittest.py:
4242         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4243         Added cases for Sierra, and updated tests for new baseline search paths.
4244
4245 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4246
4247         Another buid fix for master.cfg.
4248
4249         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4250         (CompileWebKit.start):
4251
4252 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4253
4254         Another buid fix for master.cfg.
4255
4256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4257         (CompileWebKit.start):
4258
4259 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4260
4261         Fix master.cfg
4262         
4263         Unreviewed build fix.
4264
4265         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4266         (CompileWebKit.start):
4267
4268 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4269
4270         Test another commit.
4271         
4272         Unreviewed.
4273
4274 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4275
4276         Testing fix for trac-mirror.
4277         
4278         Unreviewed.
4279
4280 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4281
4282