Unreviewed, rolling out r242354.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r242354.
4         https://bugs.webkit.org/show_bug.cgi?id=195402
5
6         breaks layout tests in all configurations (Requested by
7         zdobersek on #webkit).
8
9         Reverted changeset:
10
11         "[WPE] Enable web process sandbox"
12         https://bugs.webkit.org/show_bug.cgi?id=195169
13         https://trac.webkit.org/changeset/242354
14
15 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
16
17         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
18         https://bugs.webkit.org/show_bug.cgi?id=195346
19
20         Reviewed by Fujii Hironori.
21
22         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
23         (TestWebKitAPI::TEST):
24         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
25
26         * DumpRenderTree/win/DumpRenderTree.cpp:
27         (findFontFallback):
28         (addFontFallbackIfPresent):
29         (removeFontFallbackIfPresent):
30         (main):
31         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
32         (TestWebKitAPI::Util::moduleDirectory):
33         (TestWebKitAPI::Util::createInjectedBundlePath):
34         Use wchar helpers as needed.
35
36 2019-03-06  Rob Buis  <rbuis@igalia.com>
37
38         Consider supporting the `referrerpolicy` attribute.
39         https://bugs.webkit.org/show_bug.cgi?id=179053
40
41         Reviewed by Darin Adler.
42
43         Add a runtime flag for referrerpolicy attribute.
44
45         * DumpRenderTree/mac/DumpRenderTree.mm:
46         (enableExperimentalFeatures):
47
48 2019-03-05  Daniel Bates  <dabates@apple.com>
49
50         Update expected API test result following r242379
51         (https://bugs.webkit.org/show_bug.cgi?id=195125)
52
53         Update expected x-coordinate of selection rect now that the left padding of
54         a textarea is sized in ems (so dependent on the font size) just like the left
55         padding of a text field.
56
57         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
58         (TestWebKitAPI::TEST):
59
60 2019-03-05  David Quesada  <david_quesada@apple.com>
61
62         [WK2] It should be possible to follow links with 'download' attributes
63         https://bugs.webkit.org/show_bug.cgi?id=195145
64         rdar://problem/48462642
65
66         Reviewed by Alex Christensen.
67
68         Add a unit test to verify that activating links with 'download' attributes now
69         navigates to the linked resource, rather than starts downloading it. Add another
70         to verify that it is still possible to explicitly download the link via the
71         'Download' navigation action policy.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
74         (-[DownloadAttributeTestDelegate init]):
75         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
76         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
77         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
78         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
79         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
80         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
81         (TEST):
82         * WebKitTestRunner/TestController.cpp:
83         (WTR::TestController::decidePolicyForNavigationAction):
84         * WebKitTestRunner/TestController.h:
85
86 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
87
88         [Curl] Implement Cookie Accept Policy.
89         https://bugs.webkit.org/show_bug.cgi?id=191645
90
91         Reviewed by Fujii Hironori.
92
93         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
94         (TestWebKitAPI::Curl::TEST_F):
95
96 2019-03-05  Youenn Fablet  <youenn@apple.com>
97
98         Rename requestCacheStorageSpace to requestStorageSpace
99         https://bugs.webkit.org/show_bug.cgi?id=195282
100
101         Reviewed by Chris Dumez.
102
103         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
104         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
105         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
106
107 2019-03-05  Brady Eidson  <beidson@apple.com>
108
109         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
110         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
111
112         Reviewed by Tim Horton.
113
114         Loading a file: URL into a WKWebView and then loading another file: url from a completely
115         different directory into that same WKWebView should work.
116
117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
118         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
119
120 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Add WeakHashSet
123         https://bugs.webkit.org/show_bug.cgi?id=195152
124
125         Reviewed by Antti Koivisto.
126
127         Added tests for WeakHashSet.
128
129         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
130         (TestWebKitAPI::Base::Base): Moved.
131         (TestWebKitAPI::Derived::foo): Moved.
132         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
133         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
134         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
135         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
136
137 2019-03-04  Chris Dumez  <cdumez@apple.com>
138
139         Do not share WebProcesses between private and regular sessions
140         https://bugs.webkit.org/show_bug.cgi?id=195189
141         <rdar://problem/48421064>
142
143         Reviewed by Alex Christensen.
144
145         Add API test coverage.
146
147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
148         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
149
150 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
151
152         [WPE] Enable web process sandbox
153         https://bugs.webkit.org/show_bug.cgi?id=195169
154
155         Reviewed by Daniel Bates.
156
157         * wpe/install-dependencies:
158         * wpe/jhbuild.modules:
159
160 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
161
162         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
163         https://bugs.webkit.org/show_bug.cgi?id=195206
164
165         Reviewed by Žan Doberšek.
166
167         Add a new test case.
168
169         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
170         (testJSCClass):
171
172 2019-03-04  Charlie Turner  <cturner@igalia.com>
173
174         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
175         https://bugs.webkit.org/show_bug.cgi?id=194898
176
177         Reviewed by Žan Doberšek.
178
179         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
180         a GCC extension that permits arithmetic on void* pointer. Inline
181         the macro until this issue is fixed upstream.
182
183 2019-03-03  Tim Horton  <timothy_horton@apple.com>
184
185         Rid the world of WK_API_ENABLED
186         https://bugs.webkit.org/show_bug.cgi?id=195263
187
188         Reviewed by Dan Bernstein.
189
190         List of changed files elided because it's useless.
191
192 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
193
194         Unreviewed follow-up to r242292.
195
196         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
197
198         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
199         (TestWebKitAPI::testStrip): Renamed from strip.
200         (TestWebKitAPI::TEST):
201
202 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
203
204         Unreviewed, remove accidentally-committed URLHelpers.cpp test
205
206         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
207         and bug #194272 for details.
208
209         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
210
211 2019-03-03  Tim Horton  <timothy_horton@apple.com>
212
213         Remove some more unused 32-bit code
214         https://bugs.webkit.org/show_bug.cgi?id=195255
215
216         Reviewed by Darin Adler.
217
218         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
219         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
220         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
221         (NPP_New):
222         (NPP_HandleEvent):
223         (handleEventCarbon): Deleted.
224
225 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
226
227         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
228
229         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
230         (TestWebKitAPI::TEST):
231
232 2019-03-01  Darin Adler  <darin@apple.com>
233
234         Finish removing String::format
235         https://bugs.webkit.org/show_bug.cgi?id=194893
236
237         Reviewed by Daniel Bates.
238 '
239         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
240
241 2019-03-01  Alex Christensen  <achristensen@webkit.org>
242
243         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
244         https://bugs.webkit.org/show_bug.cgi?id=195229
245         <rdar://problem/48520362>
246
247         Reviewed by Chris Dumez.
248
249         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
250         (TEST):
251
252 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
253
254         Add a system trace scope for event region building
255         https://bugs.webkit.org/show_bug.cgi?id=195226
256
257         Reviewed by Jon Lee.
258
259         This trace scope measures the time spend converting element rects into Region objects,
260         which can be large on some pages.
261
262         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
263
264         * Tracing/SystemTracePoints.plist:
265
266 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
267
268         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
269         https://bugs.webkit.org/show_bug.cgi?id=194612
270
271         Reviewed by Alex Christensen.
272
273         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
274         Just test the new string-processing function and don't touch the actual environment.
275         (Test cases are all as before, but based on operator== instead of strcmp.)
276
277 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
278
279         [ews-app] Update primary keys for handling multiple Buildbot instances
280         https://bugs.webkit.org/show_bug.cgi?id=195120
281
282         Reviewed by Stephanie Lewis.
283
284         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
285         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
286         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
287
288         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
289         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
290         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
291         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
292         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
293         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
294
295 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
296
297         [WinCairo] Enable service worker
298         https://bugs.webkit.org/show_bug.cgi?id=188318
299
300         Reviewed by Youenn Fablet.
301
302         * DumpRenderTree/DumpRenderTreePrefix.h:
303         * TestWebKitAPI/PlatformWin.cmake:
304         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
305         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
306         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
307
308 2019-03-01  Justin Fan  <justin_fan@apple.com>
309
310         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
311         https://bugs.webkit.org/show_bug.cgi?id=195191
312
313         Rubber-stamped by Dean Jackson.
314
315         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
316
317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
318
319 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
320
321         Unreviewed, fix lldb webkitpy tests
322         https://bugs.webkit.org/show_bug.cgi?id=194375
323
324         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
325
326         * lldb/lldb_webkit.py:
327         (WTFStringImplProvider.is_8bit):
328
329 2019-02-28  David Quesada  <david_quesada@apple.com>
330
331         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
332         https://bugs.webkit.org/show_bug.cgi?id=195121
333         rdar://problem/48450302
334
335         Reviewed by Alex Christensen.
336
337         Add API tests for -WKNavigationAction._shouldPerformDownload in various
338         configurations where the 'download' attribute is absent, blank, or populated
339         with a filename, and where the anchor element is same-origin or cross-origin
340         (meaning the 'download' attribute shouldn't be honored).
341
342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
343         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
344         (-[NavigationActionTestDelegate init]):
345         (-[NavigationActionTestDelegate navigationAction]):
346         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
347         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
348         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
349         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
350         (TEST):
351
352 2019-02-28  Antoine Quint  <graouts@apple.com>
353
354         Enable the Pointer Events runtime flag by default
355         https://bugs.webkit.org/show_bug.cgi?id=195156
356
357         Reviewed by Dean Jackson.
358
359         * DumpRenderTree/mac/DumpRenderTree.mm:
360         (enableExperimentalFeatures):
361
362 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
363
364         Several PasteImage API tests are flaky
365         https://bugs.webkit.org/show_bug.cgi?id=195160
366
367         Reviewed by Tim Horton.
368
369         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
370         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
371         listening for a "load" event after image load is already complete.
372
373         To address this, make these tests first register a "load" event handler, then run script to insert an image
374         element into the document, and finally wait until the load event is observed before checking image size.
375
376         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
377
378 2019-02-28  Chris Dumez  <cdumez@apple.com>
379
380         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
381         https://bugs.webkit.org/show_bug.cgi?id=195107
382
383         Reviewed by Alex Christensen.
384
385         Give some time for the zoom level to get restored.
386
387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
388
389 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
390
391         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
392         https://bugs.webkit.org/show_bug.cgi?id=194958
393
394         Reviewed by Geoffrey Garen.
395
396         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
397         (TEST):
398
399 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
400
401         [ews-app] Update method to save build to handle builder_display_name
402         https://bugs.webkit.org/show_bug.cgi?id=195047
403
404         Reviewed by Dewei Zhu.
405
406         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
407         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
408
409 2019-02-28  Justin Fan  <justin_fan@apple.com>
410
411         [Web GPU] Enable Web GPU only on 64-bit
412         https://bugs.webkit.org/show_bug.cgi?id=195139
413
414         Because Metal is only supported on 64 bit apps.
415
416         Unreviewed build fix.
417
418         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
419
420 2019-02-27  Youenn Fablet  <youenn@apple.com>
421
422         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
423         https://bugs.webkit.org/show_bug.cgi?id=194959
424
425         Reviewed by Chris Dumez.
426
427         Spin loop until getting the condition to remove flakiness.
428
429         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
430
431 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-build] Buildbot should include builder_display_name in the build events
434         https://bugs.webkit.org/show_bug.cgi?id=195045
435
436         Reviewed by Dewei Zhu.
437
438         * BuildSlaveSupport/ews-build/events.py:
439         (Events.buildStarted): Included builder_display_name in event data. Also renamed
440         buildername to builder_name to be consistent in naming style.
441         (Events.buildFinished): Ditto.
442
443 2019-02-27  Chris Dumez  <cdumez@apple.com>
444
445         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
446         https://bugs.webkit.org/show_bug.cgi?id=194480
447
448         Reviewed by Brady Eidson.
449
450         Update existing API test to make it more likely to reproduce the issue.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
453
454 2019-02-27  Brady Eidson  <beidson@apple.com>
455
456         Universal links from Google search results pages don't open the app.
457         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
458
459         Reviewed by Geoffrey Garen.
460
461         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
462         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
463         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
464         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
465
466 2019-02-27  Chris Dumez  <cdumez@apple.com>
467
468         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
469         https://bugs.webkit.org/show_bug.cgi?id=195102
470
471         Reviewed by Geoffrey Garen.
472
473         If the number of processes is not yet what we expect, wait a bit and check again to give
474         processes some time to exit.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
477
478 2019-02-27  Chris Dumez  <cdumez@apple.com>
479
480         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
481         https://bugs.webkit.org/show_bug.cgi?id=194545
482
483         Reviewed by Brady Eidson.
484
485         Make sure the test navigates forward and then back only once. Previously, navigating
486         back would trigger a navigation again in a timer.
487
488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
489
490 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
491
492         High Sierra Debug JSC test queue should use faster hardware
493         https://bugs.webkit.org/show_bug.cgi?id=194603
494
495         Rubber-stamped by Alexey Proskuryakov.
496
497         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
498
499         * BuildSlaveSupport/build.webkit.org-config/config.json:
500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
501         (BubbleQueueServer):
502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
503         (WebKitBuildbot):
504         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
505         * QueueStatusServer/config/queues.py:
506         * Scripts/webkitpy/common/config/ews.json:
507         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
508         (test_ews_name):
509
510 2019-02-27  John Wilander  <wilander@apple.com>
511
512         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
513         https://bugs.webkit.org/show_bug.cgi?id=195071
514         <rdar://problem/48417690>
515
516         Reviewed by Alex Christensen and Brent Fulgham.
517
518         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
519         (TestWebKitAPI::createURL):
520             Convenience function.
521         (TestWebKitAPI::TEST):
522             WebCore::AdClickAttribution now takes a URL when creating Source and
523             Destination.
524         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
525         (TestWebKitAPI::TEST):
526             WebCore::AdClickAttribution now takes a URL when creating Source and
527             Destination.
528
529 2019-02-27  Antoine Quint  <graouts@apple.com>
530
531         Support Pointer Events on macOS
532         https://bugs.webkit.org/show_bug.cgi?id=195008
533         <rdar://problem/47454419>
534
535         Reviewed by Dean Jackson.
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
540
541 2019-02-26  Mark Lam  <mark.lam@apple.com>
542
543         Remove remaining poisoning code.
544         https://bugs.webkit.org/show_bug.cgi?id=194138
545
546         Reviewed by Saam Barati.
547
548         * TestWebKitAPI/CMakeLists.txt:
549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
550         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
551         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
552         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
553         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
554         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
555         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
556
557 2019-02-26  Alex Christensen  <achristensen@webkit.org>
558
559         Move ephemeral local storage from WebProcess to UIProcess
560         https://bugs.webkit.org/show_bug.cgi?id=195074
561         <rdar://problem/47937975>
562
563         Reviewed by Geoff Garen.
564
565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
566
567 2019-02-20  Jer Noble  <jer.noble@apple.com>
568
569         [Cocoa] Media elements will restart network buffering just before suspending
570         https://bugs.webkit.org/show_bug.cgi?id=193691
571
572         Reviewed by Eric Carlson.
573
574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
576         (TEST):
577
578 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
579
580         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
581         https://bugs.webkit.org/show_bug.cgi?id=191652
582
583         Reviewed by Alex Christensen.
584
585         Fix WinCairo MiniBrowser behavior of authentication dialog.
586
587         * MiniBrowser/win/WebKitBrowserWindow.cpp:
588         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
589
590 2019-02-26  Youenn Fablet  <youenn@apple.com>
591
592         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
593         https://bugs.webkit.org/show_bug.cgi?id=195028
594         <rdar://problem/48243733>
595
596         Reviewed by Eric Carlson.
597
598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
599
600 2019-02-26  Philippe Normand  <pnormand@igalia.com>
601
602         [WPE] Add API for webview background color configuration
603         https://bugs.webkit.org/show_bug.cgi?id=192305
604
605         Reviewed by Michael Catanzaro.
606
607         * MiniBrowser/wpe/main.cpp:
608         (main): Add a new option to configure the webview background
609         color. Example: --bg-color=transparent.
610         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
611         (testWebViewBackgroundColor): Enable background color API tests for WPE.
612         (beforeAll): Ditto.
613
614 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
615
616         scalableNativeWebpageParameters() is not preserved on new page navigation.
617         https://bugs.webkit.org/show_bug.cgi?id=194892
618         <rdar://problem/47538280>
619
620         Reviewed by Wenson Hsieh.
621         
622         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
623
624         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
625         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
626         * DumpRenderTree/mac/UIScriptControllerMac.mm:
627         (WTR::UIScriptController::allowsViewportShrinkToFit):
628         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
629         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
630         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
631         * TestRunnerShared/UIScriptContext/UIScriptController.h:
632         * WebKitTestRunner/UIScriptControllerCocoa.mm:
633         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
634
635 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
636
637         [ews-app] Add model for handling multiple Buildbot instances
638         https://bugs.webkit.org/show_bug.cgi?id=194863
639
640         Reviewed by Stephanie Lewis.
641
642         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
643
644 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
645
646         [ews-app] Remove BuilderMapping table
647         https://bugs.webkit.org/show_bug.cgi?id=194961
648
649         Reviewed by Stephanie Lewis.
650
651         Store builder name directly in build table, instead of having a separate
652         table for it.
653
654         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
655         * BuildSlaveSupport/ews-app/ews/models/build.py:
656         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
657         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
658
659 2019-02-25  John Wilander  <wilander@apple.com>
660
661         Introduce and adopt new class RegistrableDomain for eTLD+1
662         https://bugs.webkit.org/show_bug.cgi?id=194791
663         <rdar://problem/48179240>
664
665         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
666
667         This patch adds an API test and replaces two instances of
668         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
669
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
672         (TestWebKitAPI::TEST):
673             Changed two strings to make sure the registrable domains are still considered
674             invalid and pass the test.
675         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
676         (TestWebKitAPI::TEST):
677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
678         (WTR::InjectedBundle::didReceiveMessageToPage):
679
680 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
681
682         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
683         https://bugs.webkit.org/show_bug.cgi?id=195001
684
685         Reviewed by Carlos Garcia Campos.
686
687         API version 1.0 always includes the functionality previously guarded with
688         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
689         unconditionally.
690
691         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
692         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
693         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
694         (WebViewTest::showInWindow): Ditto.
695         (WebViewTest::hideView): Ditto.
696         * wpe/backends/HeadlessViewBackend.cpp:
697         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
698         * wpe/backends/ViewBackend.cpp:
699         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
700         * wpe/backends/WindowViewBackend.cpp:
701         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
702         WPE_BACKEND_CHECK_VERSION().
703         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
704
705 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
706
707         [Flatpak] Add support for flatpak > 1.1.2
708         https://bugs.webkit.org/show_bug.cgi?id=194088
709
710         Flatpak 1.2 is now out so we need to support that
711         version now.
712
713         Reviewed by Michael Catanzaro.
714
715         * flatpak/flatpakutils.py:
716         (check_flatpak):
717         (FlatpakPackages.__init__):
718         (FlatpakPackages.__detect_packages):
719         (FlatpakPackages.__detect_packages.in):
720         (FlatpakRepos.update):
721
722 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
723
724         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
725         https://bugs.webkit.org/show_bug.cgi?id=194998
726
727         Reviewed by Carlos Garcia Campos.
728
729         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
730         to a Git checkout and using the latest commit containing various fixes
731         and improvements.
732
733 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
734
735         [WPE][GTK] Remove user agent quirk for washingtonpost.com
736         https://bugs.webkit.org/show_bug.cgi?id=194981
737
738         Reviewed by Žan Doberšek.
739
740         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
741         (TestWebKitAPI::TEST):
742
743 2019-02-23  Keith Miller  <keith_miller@apple.com>
744
745         Add new mac target numbers
746         https://bugs.webkit.org/show_bug.cgi?id=194955
747
748         Reviewed by Tim Horton.
749
750         * DumpRenderTree/mac/Configurations/Base.xcconfig:
751         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
752         * MiniBrowser/Configurations/Base.xcconfig:
753         * TestWebKitAPI/Configurations/Base.xcconfig:
754         * WebKitTestRunner/Configurations/Base.xcconfig:
755
756 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
757
758         [WinCairo] Enable wk1/wk2 suffix for platform search path.
759         https://bugs.webkit.org/show_bug.cgi?id=194846
760
761         Reviewed by Don Olmstead.
762
763         Added _search_paths() and _port_specific_expectations_files() for
764         WinCairoPort.
765
766         * Scripts/webkitpy/port/win.py:
767         (WinCairoPort.default_baseline_search_path):
768         (WinCairoPort):
769         (WinCairoPort._port_specific_expectations_files):
770         (WinCairoPort._search_paths):
771
772 2019-02-22  Tim Horton  <timothy_horton@apple.com>
773
774         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
775         https://bugs.webkit.org/show_bug.cgi?id=194963
776
777         Reviewed by Dean Jackson.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
780         Do a `contains` check instead of `equals`, because in debug builds we
781         put the GraphicsLayer pointer in a prefix.
782
783 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
784
785         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
786         https://bugs.webkit.org/show_bug.cgi?id=194873
787         <rdar://problem/46701974>
788
789         Reviewed by Tim Horton.
790
791         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
792
793         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
794         (WTR::UIScriptController::menuRect const):
795         (WTR::UIScriptController::isShowingMenu const):
796         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
797         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
798         (WTR::UIScriptController::menuRect const):
799
800         Add a function to query the bounds of the callout menu in content coordinates.
801
802         (WTR::UIScriptController::isShowingMenu const):
803
804         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
805
806         * TestRunnerShared/UIScriptContext/UIScriptController.h:
807         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
808         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
809         (WTR::UIScriptController::rectForMenuAction const):
810         (WTR::UIScriptController::menuRect const):
811         (WTR::UIScriptController::isShowingMenu const):
812         (WTR::findViewInHierarchyOfType): Deleted.
813
814 2019-02-22  Chris Dumez  <cdumez@apple.com>
815
816         Regression(PSON) Unable to preview password-protected documents on iCloud.com
817         https://bugs.webkit.org/show_bug.cgi?id=194954
818         <rdar://problem/48127957>
819
820         Reviewed by Alex Christensen.
821
822         Add API test coverage.
823
824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
825         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
826         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
827         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
828
829 2019-02-22  Chris Dumez  <cdumez@apple.com>
830
831         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
832         https://bugs.webkit.org/show_bug.cgi?id=194924
833         <rdar://problem/48216125>
834
835         Reviewed by Geoffrey Garen.
836
837         Add API test coverage.
838
839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
840
841 2019-02-22  Chris Dumez  <cdumez@apple.com>
842
843         Unreviewed, disable API test added in r241928 on iOS.
844
845         The cache is not enabled on devices with less than 3GB of RAM.
846
847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
848
849 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
850
851         Hardcode Visual Viewports on everywhere except iOS WK1
852         https://bugs.webkit.org/show_bug.cgi?id=194928
853
854         Reviewed by Zalan Bujtas.
855
856         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
857         change the default value of the Setting to 'true', and hardcode WebView on iOS to
858         set it to false. The setting has shipped for several years and there's no need to turn
859         it off now.
860
861         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
862         Visual Viewports are not enabled.
863         
864         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
865         that only runs in WK2
866
867         * MiniBrowser/mac/SettingsController.h:
868         * MiniBrowser/mac/SettingsController.m:
869         (-[SettingsController init]):
870         (-[SettingsController _populateMenu]):
871         (-[SettingsController validateMenuItem:]):
872         (-[SettingsController visualViewportEnabled]): Deleted.
873         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
874         * MiniBrowser/mac/WK1BrowserWindowController.m:
875         (-[WK1BrowserWindowController didChangeSettings]):
876         * MiniBrowser/mac/WK2BrowserWindowController.m:
877         (-[WK2BrowserWindowController didChangeSettings]):
878
879 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
880
881         Discard cached processes when clearing website data store
882         https://bugs.webkit.org/show_bug.cgi?id=194894
883
884         Reviewed by Chris Dumez.
885
886         Added a test case.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
889         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
890
891 2019-02-21  Alex Christensen  <achristensen@webkit.org>
892
893         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
894         https://bugs.webkit.org/show_bug.cgi?id=194914
895         <rdar://problem/47586889>
896
897         Reviewed by Geoffrey Garen.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
900         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
901         (TEST):
902         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
903
904 2019-02-21  David Kilzer  <ddkilzer@apple.com>
905
906         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
907         <https://webkit.org/b/194761>
908
909         Reviewed by Myles Maxfield.
910
911         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
912         (WTR::activateSystemCoreWebFonts): Log `error` to console if
913         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
914         to use ARC-compliant cast.
915         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
916         ARC-compliant cast.
917         (WTR::installFakeHelvetica): Log `error` to console if
918         CTFontManagerRegisterFontsForURL() fails, but only on supported
919         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
920         Call CFRelease() on `error` to fix the leak.  Update to use
921         ARC-compliant cast.
922         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
923         cast.
924
925 2019-02-21  Chris Dumez  <cdumez@apple.com>
926
927         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
928         https://bugs.webkit.org/show_bug.cgi?id=194481
929
930         Reviewed by Alex Christensen.
931
932         Give the processes a chance to shutdown and wait until we reached the expected number
933         of processes.
934
935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
936
937 2019-02-21  Tim Horton  <timothy_horton@apple.com>
938
939         Fix the macOS build
940
941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
942
943 2019-02-21  Tim Horton  <timothy_horton@apple.com>
944
945         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
946
947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
948         I am a backwards.
949
950 2019-02-21  Tim Horton  <timothy_horton@apple.com>
951
952         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
953
954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
955         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
956         We could force on UI-side compositing, but I feel like the test might be more
957         valuable exercising the normal path on each platform (though the original
958         bug was also UI-side specific). Though we can't validate that the overlay
959         layer was installed successfully, there are layout tests that do that.
960
961 2019-02-21  Tim Horton  <timothy_horton@apple.com>
962
963         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
964         https://bugs.webkit.org/show_bug.cgi?id=194845
965         <rdar://problem/47944579>
966
967         Reviewed by Antti Koivisto.
968
969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
971
972 2019-02-21  Zalan Bujtas  <zalan@apple.com>
973
974         [LFC][Floats] Add support for placing formatting roots in-between floats.
975         https://bugs.webkit.org/show_bug.cgi?id=194902
976
977         Reviewed by Antti Koivisto.
978
979         * LayoutReloaded/misc/LFC-passing-tests.txt:
980
981 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
982
983         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
984         https://bugs.webkit.org/show_bug.cgi?id=194901
985
986         Unreviewed build fix.
987
988         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
989         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
990         WPEBackend-fdo-0.1 as library name.
991
992 2019-02-21  Rob Buis  <rbuis@igalia.com>
993
994         Update MIME type parser
995         https://bugs.webkit.org/show_bug.cgi?id=180526
996
997         Reviewed by Darin Adler.
998
999         Add tests involving leading and trailing whitespace, non-token
1000         characters and quoted strings.
1001
1002         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1003         (TestWebKitAPI::TEST):
1004
1005 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1006
1007         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1008         https://bugs.webkit.org/show_bug.cgi?id=194884
1009
1010         Reviewed by Michael Catanzaro.
1011
1012         * PlatformWin.cmake:
1013
1014 2019-02-20  Chris Dumez  <cdumez@apple.com>
1015
1016         Add API test for <rdar://problem/47471222>
1017         https://bugs.webkit.org/show_bug.cgi?id=194847
1018
1019         Reviewed by Alex Christensen.
1020
1021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1022
1023 2019-02-20  Chris Dumez  <cdumez@apple.com>
1024
1025         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1026         https://bugs.webkit.org/show_bug.cgi?id=194872
1027         <rdar://problem/47924500>
1028
1029         Reviewed by Alex Christensen.
1030
1031         Add API test coverage.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1034
1035 2019-02-20  Jer Noble  <jer.noble@apple.com>
1036
1037         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1038         https://bugs.webkit.org/show_bug.cgi?id=191332
1039
1040         Reviewed by Dean Jackson.
1041
1042         * Scripts/git-is-in-range: Added.
1043
1044 2019-02-20  Andy Estes  <aestes@apple.com>
1045
1046         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1047         https://bugs.webkit.org/show_bug.cgi?id=194869
1048
1049         Rubber-stamped by Jer Noble.
1050
1051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1052         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1053         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1054         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1057
1058 2019-02-20  Chris Dumez  <cdumez@apple.com>
1059
1060         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1061         https://bugs.webkit.org/show_bug.cgi?id=194857
1062         <rdar://problem/47759323>
1063
1064         Reviewed by Alex Christensen.
1065
1066         Add API test coverage.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1069
1070 2019-02-20  Chris Dumez  <cdumez@apple.com>
1071
1072         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1073         https://bugs.webkit.org/show_bug.cgi?id=194829
1074         <rdar://problem/47889906>
1075
1076         Reviewed by Alexey Proskuryakov.
1077
1078         Every time the TestOptions were changing we were creating both a new Web view and
1079         a new WKContext, which would start a new Network process. In most cases, we only
1080         need to contruct a new Web view and we do can keep reusing the same WKContext.
1081         This patch implements this optimization and thus avoids spinning a lot of new
1082         Network processes while running the layout tests.
1083
1084         * WebKitTestRunner/TestController.cpp:
1085         (WTR::TestController::generateContextConfiguration const):
1086         (WTR::TestController::generatePageConfiguration):
1087         (WTR::TestController::createWebViewWithOptions):
1088         (WTR::TestController::resetPreferencesToConsistentValues):
1089         (WTR::updateTestOptionsFromTestHeader):
1090         * WebKitTestRunner/TestController.h:
1091         * WebKitTestRunner/TestOptions.h:
1092         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1093         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1094         (WTR::TestOptions::hasSameInitializationOptions const):
1095         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1096         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1097         (WTR::TestController::platformAddTestOptions const):
1098
1099 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1100
1101         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1102         https://bugs.webkit.org/show_bug.cgi?id=167941
1103
1104         Reviewed by Carlos Garcia Campos.
1105
1106         * MiniBrowser/gtk/main.c:
1107         (filterSavedCallback): Added.
1108         (main): Support loading a JSON rule set file for content filtering.
1109         * MiniBrowser/wpe/main.cpp:
1110         (filterSavedCallback): Added.
1111         (main): Support loading a JSON rule set file for content filtering.
1112         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1113         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1114         (WTF::derefGPtr): Ditto.
1115         (testEmptyStore):
1116         (testSaveInvalidFilter):
1117         (testSaveLoadFilter):
1118         (testSavedFilterIdentifierMatch):
1119         (testRemoveFilter):
1120         (testSaveMultipleFilters):
1121         (testSaveFilterFromFile):
1122         (testFilterPersistence):
1123         (beforeAll):
1124         (afterAll):
1125         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1126         (removeOldInjectedContentAndResetLists): Also reset content filters.
1127         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1128         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1129         the element affected by the style sheet.
1130         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1131         and returns it to be used by tests.
1132         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1133         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1134         (serverCallback): Add support for serving a CSS style sheet for testing.
1135         (beforeAll): Add call to testUserContentManagerContentFilter().
1136         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1137
1138 2019-02-19  Keith Rollin  <krollin@apple.com>
1139
1140         Add timing information to build output
1141         https://bugs.webkit.org/show_bug.cgi?id=194839
1142         <rdar://problem/48219609>
1143
1144         Reviewed by Alexey Proskuryakov.
1145
1146         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1147         emit each project's build time to its output. E.g.,
1148
1149             ** BUILD SUCCEEDED ** [0.132 sec]
1150
1151         * Scripts/webkitdirs.pm:
1152         (XcodeOptions):
1153
1154 2019-02-19  Truitt Savell  <tsavell@apple.com>
1155
1156         Unreviewed, rolling out r241784.
1157
1158         Broke all OpenSource builds.
1159
1160         Reverted changeset:
1161
1162         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1163         instances view"
1164         https://bugs.webkit.org/show_bug.cgi?id=172848
1165         https://trac.webkit.org/changeset/241784
1166
1167 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1168
1169         [LFC][Floats] Remove redundant intersecting logic
1170         https://bugs.webkit.org/show_bug.cgi?id=194804
1171
1172         Reviewed by Antti Koivisto.
1173
1174         * LayoutReloaded/misc/LFC-passing-tests.txt:
1175
1176 2019-02-19  Dean Jackson  <dino@apple.com>
1177
1178         Clean-up output from generate-xcfilelists so it can be filtered
1179         https://bugs.webkit.org/show_bug.cgi?id=194795
1180
1181         Reviewed by Joseph Pecoraro (and Keith Rollin).
1182
1183         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1184         make a slight tweak to filter-build-webkit so such lines are marked
1185         as plain.
1186
1187         * Scripts/filter-build-webkit:
1188         * Scripts/generate-xcfilelists:
1189
1190 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1191
1192         pytest is not correctly auto-installed
1193         https://bugs.webkit.org/show_bug.cgi?id=194707
1194
1195         Reviewed by Carlos Garcia Campos.
1196
1197         * Scripts/webkitpy/thirdparty/__init__.py:
1198         (AutoinstallImportHook._install_pytest):
1199
1200 2019-02-18  Chris Dumez  <cdumez@apple.com>
1201
1202         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1203         https://bugs.webkit.org/show_bug.cgi?id=194797
1204         <rdar://problem/48055151>
1205
1206         Reviewed by Geoffrey Garen.
1207
1208         Add API test coverage.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1211
1212 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1213
1214         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1215         https://bugs.webkit.org/show_bug.cgi?id=194670
1216         <rdar://problem/39066529>
1217
1218         Reviewed by Tim Horton.
1219
1220         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1221         pasted in an editable area as attachment elements.
1222
1223         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1224         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1225         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1226         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1227         (TestWebKitAPI::TEST):
1228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1229         (WTR::InjectedBundlePage::InjectedBundlePage):
1230
1231 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1232
1233         Fix API test after r241728
1234        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1235
1236         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1237         (TEST):
1238         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1239
1240 2019-02-18  Daniel Bates  <dabates@apple.com>
1241
1242         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1243         https://bugs.webkit.org/show_bug.cgi?id=192824
1244         <rdar://problem/47100332>
1245
1246         Reviewed by Wenson Hsieh.
1247
1248         Fix a bug where the wrong usage code was used for F13 thru F24.
1249
1250         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1251         (keyCodeForDOMFunctionKey):
1252
1253 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1254
1255         Bytecode cache should a have a boot-specific validation
1256         https://bugs.webkit.org/show_bug.cgi?id=194769
1257         <rdar://problem/48149509>
1258
1259         Reviewed by Keith Miller.
1260
1261         Add test for WTF::bootSessionUUIDString()
1262
1263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1264         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1265         (TEST):
1266
1267 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1268
1269         Disable safe browsing in WKWebView and remove its WKPreferences API
1270         https://bugs.webkit.org/show_bug.cgi?id=194723
1271         <rdar://problem/48122993>
1272
1273         Reviewed by Geoffrey Garen.
1274
1275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1276         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1277         (TEST):
1278         (safeBrowsingView):
1279         Make tests use SPI instead of API.
1280
1281 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1282
1283         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1284         https://bugs.webkit.org/show_bug.cgi?id=194586
1285
1286         Reviewed by Ross Kirsling.
1287
1288         * DumpRenderTree/win/DumpRenderTree.cpp:
1289         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1290         * Scripts/webkitpy/port/driver.py:
1291         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1292
1293 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1294
1295         Unreviewed, rolling out r241620.
1296
1297         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1298         (Requested by ddkilzer on #webkit.)
1299
1300         Reverted changeset:
1301
1302         "[WTF] Add environment variable helpers"
1303         https://bugs.webkit.org/show_bug.cgi?id=192405
1304         https://trac.webkit.org/changeset/241620
1305
1306 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1307
1308         [LFC] RenderImage's default intrinsic size is 0.
1309         https://bugs.webkit.org/show_bug.cgi?id=194745
1310
1311         Reviewed by Antti Koivisto.
1312
1313         * LayoutReloaded/misc/LFC-passing-tests.txt:
1314
1315 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1316
1317         [LFC][BFC] Add support for block replaced intrinsic width.
1318         https://bugs.webkit.org/show_bug.cgi?id=194705
1319
1320         Reviewed by Simon Fraser.
1321
1322         * LayoutReloaded/misc/LFC-passing-tests.txt:
1323
1324 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1325
1326         [LFC] Apply min/max width constraints to preferred width computation
1327         https://bugs.webkit.org/show_bug.cgi?id=194739
1328
1329         Reviewed by Simon Fraser.
1330
1331         * LayoutReloaded/misc/LFC-passing-tests.txt:
1332
1333 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1334
1335         [WTF] Add environment variable helpers
1336         https://bugs.webkit.org/show_bug.cgi?id=192405
1337
1338         Reviewed by Michael Catanzaro.
1339
1340         * DumpRenderTree/mac/DumpRenderTree.mm:
1341         (libraryPathForDumpRenderTree):
1342         * DumpRenderTree/win/DumpRenderTree.cpp:
1343         (libraryPathForDumpRenderTree):
1344         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1345         (setUpIOSLayoutTestCommunication):
1346         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1347         (beforeAll):
1348         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1349         (main):
1350         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1351         (WebKitTestBus::run):
1352         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1353         (WTR::getOutputDir):
1354         (WTR::initializeFontConfigSetting):
1355         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1356         (WTR::InjectedBundle::platformInitialize):
1357         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1358         (WTR::topLevelPath):
1359         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1360         (WTR::topLevelPath):
1361         (WTR::getOutputDir):
1362         (WTR::activateFonts):
1363         * WebKitTestRunner/TestController.cpp:
1364         (WTR::TestController::libraryPathForTesting):
1365         (WTR::TestController::generateContextConfiguration const):
1366         (WTR::TestController::generatePageConfiguration):
1367         (WTR::TestController::decideDestinationWithSuggestedFilename):
1368         (WTR::TestController::platformAdjustContext):
1369         * WebKitTestRunner/TestController.h:
1370         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1371         (WTR::TestController::cocoaPlatformInitialize):
1372         (WTR::TestController::platformAdjustContext):
1373         * WebKitTestRunner/gtk/main.cpp:
1374         (main):
1375         * WebKitTestRunner/mac/TestControllerMac.mm:
1376         (WTR::TestController::configureContentExtensionForTest):
1377         * WebKitTestRunner/wpe/main.cpp:
1378         (main):
1379         Utilize WTF::Environment where possible.
1380
1381 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1382
1383         [iOS] WKWebView callout bar is missing Change Writing Direction item
1384         https://bugs.webkit.org/show_bug.cgi?id=190015
1385         <rdar://problem/44810366>
1386
1387         Reviewed by Tim Horton.
1388
1389         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1390         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1391
1392         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1393         (TestWebKitAPI::TEST):
1394
1395 2019-02-15  Chris Dumez  <cdumez@apple.com>
1396
1397         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1398         https://bugs.webkit.org/show_bug.cgi?id=194717
1399         <rdar://problem/47884404>
1400
1401         Reviewed by Brady Eidson.
1402
1403         Add API test coverage.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1406
1407 2019-02-15  Youenn Fablet  <youenn@apple.com>
1408
1409         Make navigator.mediaDevices SecureContext
1410         https://bugs.webkit.org/show_bug.cgi?id=194666
1411
1412         Reviewed by Eric Carlson.
1413
1414         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1415         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1416         (TEST_F):
1417
1418 2019-02-15  Brian Burg  <bburg@apple.com>
1419
1420         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1421         https://bugs.webkit.org/show_bug.cgi?id=194411
1422         <rdar://problem/47787614>
1423
1424         Reviewed by Joseph Pecoraro.
1425
1426         Remove unnecessary soft linking macro usage.
1427
1428         * DumpRenderTree/mac/TestRunnerMac.mm:
1429         (TestRunner::inspectorTestStubURL):
1430         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1431         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1432         (WTR::TestRunner::inspectorTestStubURL):
1433
1434 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1435
1436         Unreviewed, rolling out r241559 and r241566.
1437         https://bugs.webkit.org/show_bug.cgi?id=194710
1438
1439         Causes layout test crashes under GuardMalloc (Requested by
1440         ryanhaddad on #webkit).
1441
1442         Reverted changesets:
1443
1444         "[WTF] Add environment variable helpers"
1445         https://bugs.webkit.org/show_bug.cgi?id=192405
1446         https://trac.webkit.org/changeset/241559
1447
1448         "Unreviewed build fix for WinCairo Debug after r241559."
1449         https://trac.webkit.org/changeset/241566
1450
1451 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1452
1453         [LFC] Out-of-flow box is never a float box
1454         https://bugs.webkit.org/show_bug.cgi?id=194704
1455
1456         Reviewed by Antti Koivisto.
1457
1458         * LayoutReloaded/misc/LFC-passing-tests.txt:
1459
1460 2019-02-10  Darin Adler  <darin@apple.com>
1461
1462         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1463         https://bugs.webkit.org/show_bug.cgi?id=194487
1464
1465         Reviewed by Daniel Bates.
1466
1467         * DumpRenderTree/win/DumpRenderTree.cpp:
1468         (applicationId): Use makeString instead of String::format.
1469         (main): Ditto.
1470         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1471         (TestWebKitAPI::Util::createURLForResource): Ditto.
1472         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1473         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1474
1475         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1476         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1477         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1478         (WTR::createStringWithAttributes): Use appendLiteral.
1479         (WTR::AccessibilityUIElement::helpText const): Ditto.
1480         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1481         directly instead of using String::format.
1482         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1483         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1484
1485 2019-02-15  Truitt Savell  <tsavell@apple.com>
1486
1487         Unreviewed, rolling out r241564.
1488
1489         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1490
1491         Reverted changeset:
1492
1493         "[Mac] WebInspectorUI.framework does not need to be soft-
1494         linked anymore"
1495         https://bugs.webkit.org/show_bug.cgi?id=194411
1496         https://trac.webkit.org/changeset/241564
1497
1498 2019-02-15  Saam barati  <sbarati@apple.com>
1499
1500         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1501         https://bugs.webkit.org/show_bug.cgi?id=194036
1502
1503         Reviewed by Yusuke Suzuki.
1504
1505         * Scripts/run-jsc-stress-tests:
1506
1507 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1508
1509         Fix the build.
1510
1511         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1512         (WTR::UIScriptController::drawSquareInEditableImage):
1513         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1514         (TestWebKitAPI::drawSquareInEditableImage):
1515
1516 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1517
1518         Fix the build.
1519
1520         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1521         (WTR::UIScriptController::drawSquareInEditableImage):
1522         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1523         (TestWebKitAPI::drawSquareInEditableImage):
1524
1525 2019-02-14  Brian Burg  <bburg@apple.com>
1526
1527         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1528         https://bugs.webkit.org/show_bug.cgi?id=194411
1529         <rdar://problem/47787614>
1530
1531         Reviewed by Joseph Pecoraro.
1532
1533         Remove unnecessary soft linking macro usage.
1534
1535         * DumpRenderTree/mac/TestRunnerMac.mm:
1536         (TestRunner::inspectorTestStubURL):
1537         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1538         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1539         (WTR::TestRunner::inspectorTestStubURL):
1540
1541 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1542
1543         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1544         https://bugs.webkit.org/show_bug.cgi?id=194599
1545
1546         Reviewed by Lucas Forschler.
1547
1548         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1549         (StatusBubble._build_bubble):
1550
1551 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-app] Set Foreign Key in Django build model
1554         https://bugs.webkit.org/show_bug.cgi?id=194667
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-app/ews/models/build.py:
1559         (Build):
1560
1561 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1562
1563         [WTF] Add environment variable helpers
1564         https://bugs.webkit.org/show_bug.cgi?id=192405
1565
1566         Reviewed by Michael Catanzaro.
1567
1568         * DumpRenderTree/mac/DumpRenderTree.mm:
1569         (libraryPathForDumpRenderTree):
1570         * DumpRenderTree/win/DumpRenderTree.cpp:
1571         (libraryPathForDumpRenderTree):
1572         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1573         (setUpIOSLayoutTestCommunication):
1574         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1575         (TestWebKitAPI::strip):
1576         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1577         (beforeAll):
1578         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1579         (main):
1580         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1581         (WebKitTestBus::run):
1582         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1583         (WTR::getOutputDir):
1584         (WTR::initializeFontConfigSetting):
1585         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1586         (WTR::InjectedBundle::platformInitialize):
1587         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1588         (WTR::topLevelPath):
1589         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1590         (WTR::topLevelPath):
1591         (WTR::getOutputDir):
1592         (WTR::activateFonts):
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::libraryPathForTesting):
1595         (WTR::TestController::generateContextConfiguration const):
1596         (WTR::TestController::generatePageConfiguration):
1597         (WTR::TestController::decideDestinationWithSuggestedFilename):
1598         (WTR::TestController::platformAdjustContext):
1599         * WebKitTestRunner/TestController.h:
1600         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1601         (WTR::TestController::cocoaPlatformInitialize):
1602         (WTR::TestController::platformAdjustContext):
1603         * WebKitTestRunner/gtk/main.cpp:
1604         (main):
1605         * WebKitTestRunner/mac/TestControllerMac.mm:
1606         (WTR::TestController::configureContentExtensionForTest):
1607         * WebKitTestRunner/wpe/main.cpp:
1608         (main):
1609         Utilize WTF::Environment where possible.
1610
1611 2019-02-14  Chris Dumez  <cdumez@apple.com>
1612
1613         [PSON] Introduce a WebContent Process cache
1614         https://bugs.webkit.org/show_bug.cgi?id=194594
1615         <rdar://problem/46793397>
1616
1617         Reviewed by Geoff Garen.
1618
1619         Update API tests to turn on the WebContent Process cache.
1620
1621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1622
1623 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1624
1625         Unreviewed, build fix after r241480
1626
1627         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1628         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1629         (-[DragAndDropSimulator initWithWebView:]):
1630
1631 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1632
1633         AX: ARIA Reflection was disabled in error
1634         https://bugs.webkit.org/show_bug.cgi?id=194647
1635         <rdar://problem/48068336>
1636
1637         Reviewed by Ryosuke Niwa.
1638
1639         Remove test override now that this feature should be enabled by default.
1640
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::resetPreferencesToConsistentValues):
1643
1644 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1645
1646         Unreviewed, rolling out r241486.
1647         https://bugs.webkit.org/show_bug.cgi?id=194655
1648
1649         causing API failures in builds (Requested by ShawnRoberts on
1650         #webkit).
1651
1652         Reverted changeset:
1653
1654         "[Cocoa] Media elements will restart network buffering just
1655         before suspending"
1656         https://bugs.webkit.org/show_bug.cgi?id=193691
1657         https://trac.webkit.org/changeset/241486
1658
1659 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1660
1661         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1662         https://bugs.webkit.org/show_bug.cgi?id=194622
1663
1664         Reviewed by Antti Koivisto.
1665
1666         * LayoutReloaded/misc/LFC-passing-tests.txt:
1667
1668 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1669
1670         [LFC] Shrink-to-fit-width should be constrained by min/max width
1671         https://bugs.webkit.org/show_bug.cgi?id=194653
1672
1673         Reviewed by Antti Koivisto.
1674
1675         * LayoutReloaded/misc/LFC-passing-tests.txt:
1676
1677 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1678
1679         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1680         https://bugs.webkit.org/show_bug.cgi?id=194641
1681
1682         Reviewed by Geoffrey Garen.
1683
1684         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1685         so that the test would fail without this fix.
1686
1687         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1688         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1689
1690 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1691
1692         [ews-app] Change log level for a log statement
1693
1694         Unreviewed minor fix.
1695
1696         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1697         (Patch.save_patch):
1698
1699 2019-02-13  Jer Noble  <jer.noble@apple.com>
1700
1701         [Cocoa] Media elements will restart network buffering just before suspending
1702         https://bugs.webkit.org/show_bug.cgi?id=193691
1703
1704         Reviewed by Eric Carlson.
1705
1706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1708         (TEST):
1709
1710 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1711
1712         [ews-app] Fetch builder id to name mapping
1713         https://bugs.webkit.org/show_bug.cgi?id=194355
1714
1715         Reviewed by Lucas Forschler.
1716
1717         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1718         (Buildbot.get_builder_id_to_name_mapping):
1719         (Buildbot._get_display_name_from_builder_name):
1720
1721 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1722
1723         Further restricting webarchive loads
1724         https://bugs.webkit.org/show_bug.cgi?id=194567
1725         <rdar://problem/47610130>
1726
1727         Reviewed by Youenn Fablet.
1728
1729         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1730         navigations on drop.
1731
1732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1733         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1734         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1735         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1736         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1737         (TestWebKitAPI::TEST):
1738         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1739         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1740         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1741         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1742         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1743         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1744         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1745
1746 2019-02-13  John Wilander  <wilander@apple.com>
1747
1748         Store Ad Click Attribution requests in the network process
1749         https://bugs.webkit.org/show_bug.cgi?id=194510
1750         <rdar://problem/47650118>
1751
1752         Reviewed by Alex Christensen and Daniel Bates.
1753
1754         This patch adds two TestRunner functions:
1755         - dumpAdClickAttribution()
1756         - clearAdClickAttribution()
1757
1758         They call into the network process to dump and clear Ad Click
1759         Attribution state, respectively.
1760
1761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1763         (WTR::TestRunner::dumpAdClickAttribution):
1764         (WTR::TestRunner::clearAdClickAttribution):
1765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1766         * WebKitTestRunner/TestController.cpp:
1767         (WTR::TestController::resetStateToConsistentValues):
1768         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1769         (WTR::adClickAttributionStringResultCallback):
1770         (WTR::TestController::dumpAdClickAttribution):
1771         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1772         (WTR::adClickAttributionVoidCallback):
1773         (WTR::TestController::clearAdClickAttribution):
1774         * WebKitTestRunner/TestController.h:
1775         * WebKitTestRunner/TestInvocation.cpp:
1776         (WTR::TestInvocation::dumpResults):
1777         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1778         (WTR::TestInvocation::dumpAdClickAttribution):
1779         * WebKitTestRunner/TestInvocation.h:
1780
1781 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-app] Generate status-bubble
1784         https://bugs.webkit.org/show_bug.cgi?id=194572
1785
1786         Reviewed by Lucas Forschler.
1787
1788         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1789         (StatusBubble._build_bubble):
1790         (StatusBubble._should_show_bubble_for):
1791         (StatusBubble._build_bubbles_for_patch):
1792
1793 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1794
1795         [ews-app] Add status bubble html template
1796         https://bugs.webkit.org/show_bug.cgi?id=194571
1797
1798         Reviewed by Lucas Forschler.
1799
1800         * BuildSlaveSupport/ews-app/ews/templates: Added.
1801         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1802
1803 2019-02-12  Chris Dumez  <cdumez@apple.com>
1804
1805         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1806         https://bugs.webkit.org/show_bug.cgi?id=194568
1807         <rdar://problem/47944490>
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         Add API test coverage.
1812
1813         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1814         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1815
1816 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1817
1818         webkitpy: Remove bug_dummy from parsed test expectations
1819         https://bugs.webkit.org/show_bug.cgi?id=194562
1820         <rdar://problem/47853999>
1821
1822         Reviewed by Lucas Forschler.
1823
1824         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1825         (TestExpectationParser):
1826         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1827         skipped tests.
1828         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1829
1830 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1831
1832         [ews-app] Add method to fetch patch
1833         https://bugs.webkit.org/show_bug.cgi?id=194518
1834
1835         Reviewed by Lucas Forschler.
1836
1837         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1838         (Patch.get_patch):
1839
1840 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1841
1842         [LFC] Expand tests coverage (60 new tests -> 860)
1843
1844         Unreviewed test gardening (run-singly, --child-processes=1).
1845
1846         * LayoutReloaded/misc/LFC-passing-tests.txt:
1847
1848 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1849
1850         Allow pages to trigger programmatic paste from script on iOS
1851         https://bugs.webkit.org/show_bug.cgi?id=194271
1852         <rdar://problem/47808810>
1853
1854         Reviewed by Tim Horton.
1855
1856         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1857
1858         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1859         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1860         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1861         (WTR::UIScriptController::rectForMenuAction const):
1862
1863         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1864         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1865         for when the menu is shown or hidden.
1866
1867         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1868         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1869         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1870         (WTR::UIScriptController::setDidShowMenuCallback):
1871         (WTR::UIScriptController::didShowMenuCallback const):
1872         (WTR::UIScriptController::setDidHideMenuCallback):
1873         (WTR::UIScriptController::didHideMenuCallback const):
1874         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1875         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1876         (WTR::UIScriptController::rectForMenuAction const):
1877         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1878         * WebKitTestRunner/TestController.cpp:
1879         (WTR::TestController::resetPreferencesToConsistentValues):
1880         (WTR::updateTestOptionsFromTestHeader):
1881         * WebKitTestRunner/TestOptions.h:
1882
1883         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1884         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1885
1886         (WTR::TestOptions::hasSameInitializationOptions const):
1887         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1888         (WTR::UIScriptController::calendarType const):
1889         (WTR::UIScriptController::platformUndoManager const):
1890         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1891         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1892         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1893         (-[TestRunnerWKWebView dealloc]):
1894         (-[TestRunnerWKWebView _didShowMenu]):
1895         (-[TestRunnerWKWebView _didHideMenu]):
1896
1897         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1898
1899         * WebKitTestRunner/ios/TestControllerIOS.mm:
1900         (WTR::handleMenuWillHideNotification):
1901         (WTR::handleMenuDidHideNotification):
1902         (WTR::TestController::platformInitialize):
1903         (WTR::TestController::platformDestroy):
1904         (WTR::TestController::platformResetStateToConsistentValues):
1905
1906         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1907         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1908
1909         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1910         (WTR::forEachViewInHierarchy):
1911         (WTR::findViewInHierarchyOfType):
1912
1913         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1914         functions that dig through a given view's hierarchy in search of a view of a given class.
1915
1916         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1917         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1918         (WTR::UIScriptController::selectionCaretViewRect const):
1919         (WTR::UIScriptController::selectionRangeViewRects const):
1920         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1921         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1922
1923         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1924
1925         (WTR::UIScriptController::rectForMenuAction const):
1926
1927         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1928         callout bar) whose label matches the given string.
1929
1930         (WTR::UIScriptController::platformContentView const):
1931
1932         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1933         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1934         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1935
1936         (WTR::UIScriptController::platformUndoManager const): Deleted.
1937         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1938         (WTR::UIScriptController::platformContentView const):
1939         (WTR::UIScriptController::platformUndoManager const): Deleted.
1940
1941 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1942
1943         webkitpy: No option to only show unexpected failures in results.html for iPad
1944         https://bugs.webkit.org/show_bug.cgi?id=194554
1945         <rdar://problem/47922442>
1946
1947         Rubber-stamped by Aakash Jain.
1948
1949         Just because a TestExpecations file does not exist for a specific platform does not mean that
1950         TestExpecations are not being used, given that platforms inherit test expectations.
1951
1952         * Scripts/webkitpy/port/base.py:
1953         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1954         * Scripts/webkitpy/port/base_unittest.py:
1955         (PortTest.test_uses_test_expectations_file):
1956
1957 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1958
1959         Remove setDefersLoading infrastructure from WebKit2
1960         https://bugs.webkit.org/show_bug.cgi?id=194506
1961
1962         Reviewed by Brady Eidson.
1963
1964         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1966         (WTR::TestRunner::setDefersLoading): Deleted.
1967         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1968
1969 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1970
1971         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1972         https://bugs.webkit.org/show_bug.cgi?id=194522
1973         <rdar://problem/47789393>
1974
1975         Reviewed by Chris Dumez.
1976
1977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1978         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1979         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1981
1982 2019-02-12  Andy Estes  <aestes@apple.com>
1983
1984         [iOSMac] Enable Parental Controls Content Filtering
1985         https://bugs.webkit.org/show_bug.cgi?id=194521
1986         <rdar://39732376>
1987
1988         Reviewed by Tim Horton.
1989
1990         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1991
1992 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1993
1994         [LFC][IFC] Add intrinsic width support for float boxes.
1995         https://bugs.webkit.org/show_bug.cgi?id=194528
1996
1997         Reviewed by Antti Koivisto.
1998
1999         Expand tests coverage (2 new tests -> 800).
2000         (This is the correct test ordering --runs-singly --child-processes=1)
2001
2002         * LayoutReloaded/misc/LFC-passing-tests.txt:
2003
2004 2019-02-12  Rob Buis  <rbuis@igalia.com>
2005
2006         Implement serializing in MIME type parser
2007         https://bugs.webkit.org/show_bug.cgi?id=193909
2008
2009         Reviewed by Darin Adler.
2010
2011         Add various tests involving upper case, non-ASCII, control/null characters,
2012         various HTTP whitespace, single quotes and an unpaired surrogate.
2013
2014         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2015         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2016         (TestWebKitAPI::serializeIfValid):
2017         (TestWebKitAPI::TEST):
2018
2019 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2020
2021         [Cocoa] Ask platform for generic font family mappings
2022         https://bugs.webkit.org/show_bug.cgi?id=187723
2023         <rdar://problem/41892438>
2024
2025         Reviewed by Brent Fulgham.
2026
2027         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2028
2029         * DumpRenderTree/mac/DumpRenderTree.mm:
2030         (allowedFontFamilySet):
2031         * WebKitTestRunner/mac/TestControllerMac.mm:
2032         (WTR::allowedFontFamilySet):
2033
2034 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2035
2036         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2037         https://bugs.webkit.org/show_bug.cgi?id=193622
2038
2039         Reviewed by Michael Catanzaro.
2040
2041         This adds support for loading content extension rule sets from the JSON files which
2042         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2043         of WKTR for this could be removed, but that is left for a follow-up patch with
2044         cleanups.
2045
2046         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2047         * WebKitTestRunner/TestController.cpp:
2048         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2049         avoid having the null-terminator copied into the result.
2050         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2051         part of the preparations to run a test.
2052         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2053         (WTR::contentExtensionStoreCallback): Added.
2054         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2055         used for content extensions test.
2056         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2057         extensions and compiling the JSON rule set for tests involving content extensions.
2058         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2059         testing and disables content extensions.
2060         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2061         resetContentExtensions().
2062         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2063         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2064         configureContentExtensionForTest(), and userContentController().
2065
2066 2019-02-11  Daniel Bates  <dabates@apple.com>
2067
2068         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2069         https://bugs.webkit.org/show_bug.cgi?id=191446
2070         <rdar://problem/45929460>
2071
2072         Reviewed by Tim Horton.
2073
2074         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2075
2076         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2077         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2078         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2079         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2080         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2081         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2082         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2083         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2084         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2085         (WTR::arrayLength):
2086         (WTR::parseModifierArray):
2087         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2088         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2089         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2090         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2091
2092 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2093
2094         Unreviewed, rolling out r241272 and r241276.
2095         https://bugs.webkit.org/show_bug.cgi?id=194514
2096
2097         Broke the Apple Internal build and the fix requires human
2098         intervention :( (Requested by dydz on #webkit).
2099
2100         Reverted changesets:
2101
2102         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2103         https://bugs.webkit.org/show_bug.cgi?id=191446
2104         https://trac.webkit.org/changeset/241272
2105
2106         "Fix internal iOS build after r241272"
2107         https://bugs.webkit.org/show_bug.cgi?id=191446
2108         https://trac.webkit.org/changeset/241276
2109
2110 2019-02-11  Truitt Savell  <tsavell@apple.com>
2111
2112         Unreviewed, rolling out r241269.
2113
2114         Caused 5 layout tests crashes on Mac WK1
2115
2116         Reverted changeset:
2117
2118         "DumpRenderTree should report unknown options"
2119         https://bugs.webkit.org/show_bug.cgi?id=191303
2120         https://trac.webkit.org/changeset/241269
2121
2122 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2123
2124         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2125         https://bugs.webkit.org/show_bug.cgi?id=194313
2126
2127         Reviewed by Tim Horton.
2128
2129         Add a helper to determine whether the web view is presenting modal UI.
2130
2131         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2132         (WTR::UIScriptController::isPresentingModally const):
2133         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2134         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2135         (WTR::UIScriptController::isPresentingModally const):
2136         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2137         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2138         (WTR::UIScriptController::calendarType const): Deleted.
2139         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2140         (WTR::UIScriptController::isPresentingModally const):
2141         (WTR::UIScriptController::calendarType const):
2142         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2143         (WTR::UIScriptController::calendarType const):
2144
2145 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2146
2147         GCHeapInspector: Show the retained sizes in more places
2148         https://bugs.webkit.org/show_bug.cgi?id=194464
2149
2150         Reviewed by Simon Fraser.
2151
2152         * GCHeapInspector/gc-heap-inspector.html:
2153         * GCHeapInspector/script/interface.js:
2154         (HeapInspectorUtils.humanReadableSize):
2155         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2156         (HeapInspectorUtils.spanForNode.span.span):
2157         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2158         (HeapSnapshotInspector.prototype.buildRoots):
2159
2160 2019-02-11  Daniel Bates  <dabates@apple.com>
2161
2162         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2163         https://bugs.webkit.org/show_bug.cgi?id=191446
2164         <rdar://problem/45929460>
2165
2166         Reviewed by Tim Horton.
2167
2168         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2169
2170         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2171         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2172         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2173         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2174         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2175         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2176         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2177         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2178         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2179         (WTR::arrayLength):
2180         (WTR::parseModifierArray):
2181         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2182         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2183         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2184         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2185
2186 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2187
2188         DumpRenderTree should report unknown options
2189         https://bugs.webkit.org/show_bug.cgi?id=191303
2190
2191         Reviewed by Frédéric Wang.
2192
2193         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2194         to report unknown options.
2195         Added and assigned test options which are currently used in tests.
2196
2197         * DumpRenderTree/TestOptions.cpp:
2198         (TestOptions::TestOptions):
2199
2200 2019-02-11  Truitt Savell  <tsavell@apple.com>
2201
2202         Unreviewed, rolling out r241229.
2203
2204         Revision broke internal builds for watchOS.
2205
2206         Reverted changeset:
2207
2208         "[Cocoa] Ask platform for generic font family mappings"
2209         https://bugs.webkit.org/show_bug.cgi?id=187723
2210         https://trac.webkit.org/changeset/241229
2211
2212 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2213
2214         [WinCairo][MiniBrowser] Basic authentication always fails.
2215         https://bugs.webkit.org/show_bug.cgi?id=194496
2216
2217         Reviewed by Don Olmstead.
2218
2219         * MiniBrowser/win/DialogHelper.h:
2220         (Dialog::getText):
2221
2222 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2223
2224         [GStreamer] GstMappedBuffer testsuite build fails
2225         https://bugs.webkit.org/show_bug.cgi?id=194495
2226
2227         Reviewed by Carlos Garcia Campos.
2228
2229         Fix the build by explicitely adding the gstreamer1.0-audio include
2230         directories to the include path.
2231
2232         * TestWebKitAPI/PlatformGTK.cmake:
2233         * TestWebKitAPI/PlatformWPE.cmake:
2234
2235 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2236
2237         [GTK][WPE] Add enable-javascript-markup setting
2238         https://bugs.webkit.org/show_bug.cgi?id=193439
2239
2240         Reviewed by Michael Catanzaro.
2241
2242         Add test cases to check the new setting.
2243
2244         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2245         (testWebKitSettings):
2246         (testWebKitSettingsJavaScriptMarkup):
2247         (beforeAll):
2248
2249 2019-02-10  Darin Adler  <darin@apple.com>
2250
2251         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2252         https://bugs.webkit.org/show_bug.cgi?id=194485
2253
2254         Reviewed by Daniel Bates.
2255
2256         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2257
2258 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2259
2260         Add more tests for clampTo<>()
2261         https://bugs.webkit.org/show_bug.cgi?id=194462
2262
2263         Reviewed by Geoffrey Garen.
2264
2265         Darin suggested to test the very last floating point number
2266         at the boundaries when truncating to integer.
2267         I added test for max/min and max-1/min-1.
2268
2269         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2270         (TestWebKitAPI::TEST):
2271
2272 2019-02-09  Darin Adler  <darin@apple.com>
2273
2274         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2275         https://bugs.webkit.org/show_bug.cgi?id=194021
2276
2277         Reviewed by Geoffrey Garen.
2278
2279         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2280         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2281         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2282
2283 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2284
2285         [LFC][IFC] Add intrinsic width support for basic inline containers
2286         https://bugs.webkit.org/show_bug.cgi?id=194473
2287
2288         Reviewed by Antti Koivisto.
2289
2290         Expand tests coverage (11 new tests -> 798)
2291
2292         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2293
2294 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2295
2296         Fix MiniBrowser's entitlements
2297         https://bugs.webkit.org/show_bug.cgi?id=192431
2298
2299         Reviewed by Joseph Pecoraro.
2300
2301         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2302         files, making it impossible to load any extension.
2303
2304         * MiniBrowser/MiniBrowser.entitlements:
2305
2306 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2307
2308         [Cocoa] Ask platform for generic font family mappings
2309         https://bugs.webkit.org/show_bug.cgi?id=187723
2310         <rdar://problem/41892438>
2311
2312         Reviewed by Brent Fulgham.
2313
2314         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (allowedFontFamilySet):
2318         * WebKitTestRunner/mac/TestControllerMac.mm:
2319         (WTR::allowedFontFamilySet):
2320
2321 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2322
2323         [GTK] Implement back/forward touchpad gesture
2324         https://bugs.webkit.org/show_bug.cgi?id=193919
2325
2326         Reviewed by Michael Catanzaro.
2327
2328         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2329         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2330
2331 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2332
2333         Add SPI to use networking daemon instead of XPC service
2334         https://bugs.webkit.org/show_bug.cgi?id=194427
2335
2336         Reviewed by Geoffrey Garen
2337
2338         * MiniBrowser/MiniBrowser.entitlements:
2339
2340 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2341
2342         [ews-build] Ensure that every builder in config.json has short name
2343         https://bugs.webkit.org/show_bug.cgi?id=194461
2344
2345         Reviewed by Lucas Forschler.
2346
2347         * BuildSlaveSupport/ews-build/loadConfig.py:
2348         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2349
2350 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2351
2352         [ews-build] Add short name to config.json
2353         https://bugs.webkit.org/show_bug.cgi?id=194456
2354
2355         Reviewed by Lucas Forschler.
2356
2357         * BuildSlaveSupport/ews-build/config.json: Added short name.
2358         * BuildSlaveSupport/ews-build/loadConfig.py:
2359         (loadBuilderConfig): Set the short name as the builder description.
2360
2361 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2362
2363         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2364         https://bugs.webkit.org/show_bug.cgi?id=194418
2365
2366         Reviewed by Lucas Forschler.
2367
2368         Do not include errors trying when finding crashlogs at the end of
2369         a run-webkit-tests run since we don't process those errors.
2370
2371         * Scripts/webkitpy/port/darwin.py:
2372         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2373         * Scripts/webkitpy/port/ios_device.py:
2374         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2375         * Scripts/webkitpy/port/watch_device.py:
2376         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2377
2378 2019-02-08  Beth Dakin  <bdakin@apple.com>
2379
2380         Add afterScreenUpdates to WKSnapshotConfiguration
2381         https://bugs.webkit.org/show_bug.cgi?id=194362
2382         -and corresponding-
2383         <rdar://problem/40655528> Please add an "after screen updates" property to 
2384         WKSnapshotConfiguration (to solve blank snapshots)
2385
2386         Reviewed by Tim Horton.
2387
2388         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2389         (TEST):
2390
2391 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2392
2393         clampTo(): do not convert the input to double when dealing with integers
2394         https://bugs.webkit.org/show_bug.cgi?id=194263
2395         <rdar://problem/47692312>
2396
2397         Reviewed by Darin Adler.
2398
2399         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2400         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2401         (TestWebKitAPI::testClampFloatingPointToInteger):
2402         (TestWebKitAPI::testClampSameSignIntegers):
2403         (TestWebKitAPI::testClampUnsignedToSigned):
2404         (TestWebKitAPI::testClampSignedToUnsigned):
2405
2406 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2407
2408         webkitpy: Respect --dedicated-simulators flag
2409         https://bugs.webkit.org/show_bug.cgi?id=194416
2410         <rdar://problem/47894722>
2411
2412         Reviewed by Lucas Forschler.
2413
2414         * Scripts/webkitpy/port/device_port.py:
2415         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2416         available devices can be safely ignored.
2417
2418 2019-02-07  Keith Rollin  <krollin@apple.com>
2419
2420         Remove extra copy of 100x100-red.tga
2421         https://bugs.webkit.org/show_bug.cgi?id=194371
2422         <rdar://problem/47873465>
2423
2424         Reviewed by Said Abou-Hallawa.
2425
2426         In order to help it pass its tests, Bug 194190 added a second copy of
2427         the file 100x100-red.tga. However, it turns out that this additional
2428         file wasn't actually needed, and that that sole previous copy was
2429         sufficient. At the same time, this second copy -- which was copied to
2430         the same location in the build output as the first copy -- now caused
2431         XCBuild to complain because there were two production rules for the
2432         same output file. Address this by removing the newly-added extra copy.
2433
2434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2435         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2436
2437 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2438
2439         Deprecate WKBundlePageSetDefersLoading
2440         https://bugs.webkit.org/show_bug.cgi?id=191394
2441
2442         Reviewed by Dean Jackson.
2443
2444         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2445         (WTR::TestRunner::setDefersLoading):
2446
2447 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2448
2449         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2450         https://bugs.webkit.org/show_bug.cgi?id=194391
2451
2452         Reviewed by Antti Koivisto.
2453
2454         * LayoutReloaded/misc/LFC-passing-tests.txt:
2455
2456 2019-02-06  Keith Rollin  <krollin@apple.com>
2457
2458         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2459         https://bugs.webkit.org/show_bug.cgi?id=193975
2460         <rdar://problem/47643306>
2461
2462         Reviewed by Tim Horton.
2463
2464         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2465         the Info.plist file into the bundle. This step is not necessary as the
2466         implicit "bundle up all the build products into a framework" build
2467         phase does this already. Having the Copy Bundle Resources phase do
2468         this causes a conflict under XCBuild, which objects to two build
2469         phases producing the same file (Info.plist). Address this by removing
2470         Info.plist from the Copy Bundle Resources phase.
2471
2472         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2473
2474 2019-02-06  Keith Rollin  <krollin@apple.com>
2475
2476         Really enable the automatic checking and regenerations of .xcfilelists during builds
2477         https://bugs.webkit.org/show_bug.cgi?id=194357
2478         <rdar://problem/47861231>
2479
2480         Reviewed by Chris Dumez.
2481
2482         Bug 194124 was supposed to enable the automatic checking and
2483         regenerating of .xcfilelist files during the build. While related
2484         changes were included in that patch, the change to actually enable the
2485         operation somehow was omitted. This patch actually enables the
2486         operation. The check-xcfilelist.sh scripts now check
2487         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2488         from the checking.
2489
2490         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2491         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2492
2493 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2494
2495         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2496         <https://webkit.org/b/194286>
2497         <rdar://problem/47815558>
2498
2499         Reviewed by Alexey Proskuryakov.
2500
2501         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2502         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2503         WKRetainPtr<> to avoid leaking the WKDataRef.
2504
2505 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2506
2507         Unreviewed, fix a typo
2508
2509         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2510
2511 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2512
2513         [GTK][WPE] force libpsl build to use ICU in jhbuild
2514         https://bugs.webkit.org/show_bug.cgi?id=194288
2515
2516         Reviewed by Carlos Garcia Campos.
2517
2518         * gtk/jhbuild.modules:
2519         Require ICU for libpsl build in jhbuild, like done in WPE.
2520
2521 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2522
2523         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2524         https://bugs.webkit.org/show_bug.cgi?id=194209
2525
2526         Reviewed by Carlos Garcia Campos.
2527
2528         Enhance TestCookieManager to ensure this doesn't happen again.
2529
2530         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2531         (testCookieManagerPersistentStorage):
2532         (beforeAll):
2533
2534 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2535
2536         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2537         https://bugs.webkit.org/show_bug.cgi?id=194324
2538
2539         Reviewed by Andy Estes.
2540
2541         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2542         part of the name is already implicit, since this is in testing code in TestOptions.
2543
2544         * WebKitTestRunner/TestController.cpp:
2545         (WTR::TestController::generateContextConfiguration const):
2546         (WTR::updateTestOptionsFromTestHeader):
2547         * WebKitTestRunner/TestOptions.h:
2548         (WTR::TestOptions::hasSameInitializationOptions const):
2549
2550 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2551
2552         [ews-build] Allow * as platform for builders and workers
2553         https://bugs.webkit.org/show_bug.cgi?id=188533
2554
2555         Reviewed by Lucas Forschler.
2556
2557         * BuildSlaveSupport/ews-build/loadConfig.py:
2558         (checkWorkersAndBuildersForConsistency):
2559
2560 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2561
2562         [ews-build] Add few bots to config.json
2563         https://bugs.webkit.org/show_bug.cgi?id=194304
2564
2565         Reviewed by Lucas Forschler.
2566
2567         * BuildSlaveSupport/ews-build/config.json:
2568
2569 2019-02-05  Keith Rollin  <krollin@apple.com>
2570
2571         Enable the automatic checking and regenerations of .xcfilelists during builds
2572         https://bugs.webkit.org/show_bug.cgi?id=194124
2573         <rdar://problem/47721277>
2574
2575         Reviewed by Tim Horton.
2576
2577         Bug 193790 add a facility for checking -- during build time -- that
2578         any needed .xcfilelist files are up-to-date and for updating them if
2579         they are not. This facility was initially opt-in by setting
2580         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2581         the process seemed robust. Its now time to enable this facility and
2582         make it opt-out. If there is a need to disable this facility, set and
2583         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2584         running `make` or `build-webkit`, or before running Xcode from the
2585         command line.
2586
2587         Additionally, remove the step that generates a list of source files
2588         going into the UnifiedSources build step. It's only necessarily to
2589         specify Sources.txt and SourcesCocoa.txt as inputs.
2590
2591         * Scripts/generate-xcfilelists:
2592
2593 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2594
2595         [GTK][WPE] force libpsl build to use ICU in jhbuild
2596         https://bugs.webkit.org/show_bug.cgi?id=194288
2597
2598         Reviewed by Philippe Normand.
2599
2600         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2601         This can cause build failures if libidn is detected but libunistring is not available.
2602
2603         Make sure that ICU is used for runtime and builtin PSL data.
2604
2605         * gtk/jhbuild.modules:
2606         * wpe/jhbuild.modules:
2607
2608 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-app] Modified timestamp should be updated on updating data
2611         https://bugs.webkit.org/show_bug.cgi?id=194295
2612
2613         Reviewed by Lucas Forschler.
2614
2615         * BuildSlaveSupport/ews-app/ews/models/build.py:
2616         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2617         * BuildSlaveSupport/ews-app/ews/models/step.py:
2618
2619 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2620
2621         Unreviewed, rolling out r240742.
2622
2623         Causes crashes on iOS simulator.
2624
2625         Reverted changeset:
2626
2627         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2628         not focused in a content-editable element"
2629         https://bugs.webkit.org/show_bug.cgi?id=192824
2630         https://trac.webkit.org/changeset/240742
2631
2632 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2633
2634         run-webkit-tests emits message "...running None" when running tests
2635         https://bugs.webkit.org/show_bug.cgi?id=194133
2636         <rdar://problem/47724738>
2637
2638         Reviewed by Lucas Forschler.
2639
2640         * Scripts/webkitpy/xcode/device_type.py:
2641         (DeviceType.__str__): Use both version mapping tables and use just the variant
2642         name if no version name is available.
2643         * Scripts/webkitpy/xcode/device_type_unittest.py:
2644         (DeviceTypeTest):
2645         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2646         an associated named.
2647
2648 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2649
2650         [WPE] require python3-setuptools for meson build in jhbuild
2651         https://bugs.webkit.org/show_bug.cgi?id=194287
2652
2653         Reviewed by Philippe Normand.
2654
2655         python3-setuptools is needed to build meson in jhbuild.
2656         It is already required by the GTK port.
2657
2658         * wpe/install-dependencies:
2659
2660 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2661
2662         [ews-app] Add method to save BuilderMapping to database
2663         https://bugs.webkit.org/show_bug.cgi?id=194264
2664
2665         Reviewed by Lucas Forschler.
2666
2667         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2668         (BuilderMapping.__str__):
2669         (BuilderMapping):
2670         (BuilderMapping.save_mapping):
2671         (BuilderMapping.update_mapping):
2672         (BuilderMapping.get_existing_mapping):
2673         (BuilderMapping.is_valid_mapping):
2674
2675 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-app] Add timestamp fields for BuilderMappings
2678         https://bugs.webkit.org/show_bug.cgi?id=194266
2679
2680         Reviewed by Lucas Forschler.
2681
2682         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2683         (BuilderMapping):
2684
2685 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2686
2687         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2688         https://bugs.webkit.org/show_bug.cgi?id=174816
2689
2690         Reviewed by Michael Catanzaro.
2691
2692         Add tests for webkit_uri_for_display().
2693
2694         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2695         (testURIForDisplayUnaffected):
2696         (testURIForDisplayAffected):
2697         (beforeAll):
2698         (afterAll):
2699         * TestWebKitAPI/glib/CMakeLists.txt:
2700
2701 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2702
2703         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2704         https://bugs.webkit.org/show_bug.cgi?id=194158
2705         <rdar://problem/47737268>
2706
2707         Rubber-stamped by Aakash Jain.
2708
2709         * Scripts/webkitpy/port/device_port.py:
2710         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2711
2712 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2713
2714         [CG] Enable setAdditionalSupportedImageTypes for WK1
2715         https://bugs.webkit.org/show_bug.cgi?id=194190
2716
2717         Reviewed by Tim Horton.
2718
2719         Add a test similar to the one under WebKit Cocoa but make it create a
2720         WebView instead of a WKWebView.
2721
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2723         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2724         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2725         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2726         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2727         (TestWebKitAPI::runTest):
2728         (TestWebKitAPI::TEST):
2729
2730 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2731
2732         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2733         https://bugs.webkit.org/show_bug.cgi?id=194168
2734
2735         Reviewed by Simon Fraser.
2736
2737         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2738
2739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2741         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2742         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2743         (TEST):
2744         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2745         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2746
2747 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2748
2749         REGRESSION (r237269): webkit-patch what-broke is broken 
2750         https://bugs.webkit.org/show_bug.cgi?id=193025
2751
2752         Reviewed by Aakash Jain.
2753
2754         * Scripts/webkitpy/common/host.py:
2755         (Host.buildbot):
2756         (Host.bugzilla): Renamed to 'buildbot'.
2757
2758 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2759
2760         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2761         https://bugs.webkit.org/show_bug.cgi?id=194207
2762
2763         Reviewed by Tim Horton.
2764
2765         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2766         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2767         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2768         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2769         start and delete forwards to remove the original attachment.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2772         (TestWebKitAPI::TEST):
2773
2774 2019-02-04  Youenn Fablet  <youenn@apple.com>
2775
2776         Capture state should be managed consistently when doing process swapping
2777         https://bugs.webkit.org/show_bug.cgi?id=194122
2778         <rdar://problem/47609293>
2779
2780         Reviewed by Eric Carlson.
2781
2782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2783         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2784         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2785         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2786         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2788         (WTR::TestRunner::isDoingMediaCapture const):
2789         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2790         * WebKitTestRunner/TestController.cpp:
2791         (WTR::TestController::isDoingMediaCapture const):
2792         * WebKitTestRunner/TestController.h:
2793         * WebKitTestRunner/TestInvocation.cpp:
2794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2795         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2796         (WTR::TestController::isDoingMediaCapture const):
2797
2798 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2799
2800         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2801         https://bugs.webkit.org/show_bug.cgi?id=194142
2802
2803         Reviewed by Ross Kirsling.
2804
2805         There three 'separator' variables in TestController.cpp. Renamed
2806         it 'pathSeparator', and unified them.
2807
2808         * WebKitTestRunner/TestController.cpp:
2809         (WTR::TestController::generateContextConfiguration const):
2810         (WTR::createTestURL):
2811         (WTR::TestController::platformAdjustContext):
2812
2813 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2814
2815         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2816         https://bugs.webkit.org/show_bug.cgi?id=194198
2817
2818         Reviewed by Antti Koivisto.
2819
2820         No need to set the banner heights on navigation now, since Page stores them.
2821
2822         * MiniBrowser/mac/WK2BrowserWindowController.m:
2823         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2824
2825 2019-02-03  John Wilander  <wilander@apple.com>
2826
2827         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2828         https://bugs.webkit.org/show_bug.cgi?id=194104
2829         <rdar://problem/47649991>
2830
2831         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2832
2833         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2834         (TestWebKitAPI::TEST):
2835             Changed numeric types from unsigned short to uint32_t.
2836
2837 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2838
2839         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2840         <https://webkit.org/b/194178>
2841         <rdar://problem/47753473>
2842
2843         Reviewed by Alexey Proskuryakov.
2844
2845         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2846         (WTR::uninstallFakeHelvetica): Pass nullptr into
2847         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2848
2849 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2850
2851         [LFC] Initialize ICB's style with fixed width/height.
2852         https://bugs.webkit.org/show_bug.cgi?id=194188
2853
2854         Reviewed by Antti Koivisto.
2855
2856         * LayoutReloaded/misc/LFC-passing-tests.txt:
2857
2858 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2859
2860         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2861         https://bugs.webkit.org/show_bug.cgi?id=194185
2862
2863         Reviewed by Antti Koivisto.
2864
2865         * LayoutReloaded/misc/LFC-passing-tests.txt:
2866
2867 2018-12-16  Darin Adler  <darin@apple.com>
2868
2869         Convert additional String::format clients to alternative approaches
2870         https://bugs.webkit.org/show_bug.cgi?id=192746
2871
2872         Reviewed by Alexey Proskuryakov.
2873
2874         * WebKitTestRunner/TestController.cpp:
2875         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2876         as an intermediate in code that ultimately constructs a WTF::String.
2877         (WTR::userMediaOriginHash): Use makeString.
2878         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2879         (WTR::TestController::didPerformClientRedirect): Ditto.
2880         (WTR::TestController::didPerformServerRedirect): Ditto.
2881         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2882
2883 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2884
2885         [ews-build] Add unit test to verify builder keys
2886         https://bugs.webkit.org/show_bug.cgi?id=194152
2887
2888         Reviewed by Lucas Forschler.
2889
2890         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2891         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2892
2893 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2894
2895         [LFC] Expand tests coverage (12 new tests -> 787)
2896
2897         Unreviewed test gardening.
2898
2899         * LayoutReloaded/misc/LFC-passing-tests.txt:
2900
2901 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2902
2903         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2904         https://bugs.webkit.org/show_bug.cgi?id=194163
2905
2906         Reviewed by Simon Fraser.
2907
2908         775
2909
2910         * LayoutReloaded/misc/LFC-passing-tests.txt:
2911
2912 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2913
2914         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2915         https://bugs.webkit.org/show_bug.cgi?id=194140
2916         <rdar://problem/47728098>
2917
2918         Reviewed by Tim Horton.
2919
2920         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2921         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2922         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2923
2924         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2925         test to induce an IPC deadlock when presenting a modal alert during touch start.
2926
2927         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::runJavaScriptAlert):
2930
2931         Add a client callback function for running JavaScript alerts.
2932
2933         (WTR::TestController::createOtherPage):
2934         (WTR::TestController::generateContextConfiguration const):
2935
2936         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2937         the fix in this patch.
2938
2939         (WTR::TestController::createWebViewWithOptions):
2940
2941         Plumb TestOptions to generateContextConfiguration.
2942
2943         (WTR::TestController::resetPreferencesToConsistentValues):
2944         (WTR::TestController::resetStateToConsistentValues):
2945         (WTR::updateTestOptionsFromTestHeader):
2946         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2947         (WTR::TestController::handleJavaScriptAlert):
2948         * WebKitTestRunner/TestController.h:
2949         * WebKitTestRunner/TestInvocation.cpp:
2950         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2951         * WebKitTestRunner/TestOptions.h:
2952         (WTR::TestOptions::hasSameInitializationOptions const):
2953
2954 2019-02-01  Chris Dumez  <cdumez@apple.com>
2955
2956         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2957         https://bugs.webkit.org/show_bug.cgi?id=193740
2958         <rdar://problem/47527267>
2959
2960         Reviewed by Alex Christensen.
2961
2962         Add API test coverage.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2965
2966 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-app] Add display name field to BuilderMapping model
2969         https://bugs.webkit.org/show_bug.cgi?id=194153
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2974         (BuilderMapping):
2975
2976 2019-02-01  Youenn Fablet  <youenn@apple.com>
2977
2978         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2979         https://bugs.webkit.org/show_bug.cgi?id=194155
2980
2981         Reviewed by Eric Carlson.
2982
2983         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2984         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2985         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2986
2987 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2988
2989         [LFC] Adjust replaced element's intrinsic ratio
2990         https://bugs.webkit.org/show_bug.cgi?id=194154
2991
2992         Reviewed by Antti Koivisto.
2993
2994         761
2995
2996         * LayoutReloaded/misc/LFC-passing-tests.txt:
2997
2998 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2999
3000         [WPE] Show test results in minibrowser
3001         https://bugs.webkit.org/show_bug.cgi?id=194150
3002
3003         Reviewed by Žan Doberšek.
3004
3005         * Scripts/webkitpy/port/wpe.py:
3006         (WPEPort.show_results_html_file):
3007
3008 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3009
3010         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3011         https://bugs.webkit.org/show_bug.cgi?id=194151
3012
3013         Reviewed by Žan Doberšek.
3014
3015         ALT + <- go back
3016         ALT + -> go forward
3017
3018         * MiniBrowser/wpe/main.cpp:
3019         (main):
3020
3021 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3022
3023         [LFC] Set intrinsic size on Layout::Replaced
3024         https://bugs.webkit.org/show_bug.cgi?id=194139
3025
3026         Reviewed by Antti Koivisto.
3027
3028         744
3029
3030         * LayoutReloaded/misc/LFC-passing-tests.txt:
3031
3032 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3033
3034         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3035         https://bugs.webkit.org/show_bug.cgi?id=194146
3036
3037         Reviewed by Xabier Rodriguez-Calvar.
3038
3039         It allows to open relative paths.
3040
3041         * MiniBrowser/wpe/main.cpp:
3042         (main):
3043
3044 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3045
3046         Update flakiness dashboard configuration after recent queue changes
3047         https://bugs.webkit.org/show_bug.cgi?id=194127
3048
3049         Rubber-stamped by Aakash Jain.
3050
3051         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3052
3053         * TestResultServer/static-dashboards/builders.jsonp:
3054
3055 2019-01-31  Youenn Fablet  <youenn@apple.com>
3056
3057         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3058         https://bugs.webkit.org/show_bug.cgi?id=194106
3059         <rdar://problem/47676333>
3060
3061         Reviewed by Ryosuke Niwa.
3062
3063         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3064         (TestWebKitAPI::didFinishNavigation):
3065         (TestWebKitAPI::TEST):
3066         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3067
3068 2019-01-31  Chris Dumez  <cdumez@apple.com>
3069
3070         Page zoom level is lost after a process swap or a crash
3071         https://bugs.webkit.org/show_bug.cgi?id=194105
3072         <rdar://problem/47610781>
3073
3074         Reviewed by Alex Christensen.
3075
3076         Add API test coverage.
3077
3078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3079         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3080
3081 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3082
3083         Revert r238819 which is unneeded and caused a performance regression.
3084         https://bugs.webkit.org/show_bug.cgi?id=192272
3085         <rdar://problem/46664625>
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3088         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3089         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3090
3091 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3092
3093         Formalize WebKitAdditions mechanism of LoadOptimizer
3094         https://bugs.webkit.org/show_bug.cgi?id=193886
3095         <rdar://problem/47696809>
3096
3097         Reviewed by Brent Fulgham.
3098
3099         * MiniBrowser/MiniBrowser.entitlements:
3100         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3101
3102 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3103
3104         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3105         https://bugs.webkit.org/show_bug.cgi?id=194090
3106
3107         Reviewed by Antti Koivisto.
3108
3109         * LayoutReloaded/misc/LFC-passing-tests.txt:
3110
3111 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3112
3113         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3114         https://bugs.webkit.org/show_bug.cgi?id=194074
3115
3116         Reviewed by Antti Koivisto.
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3121
3122         [LFC][BFC] Add support for block level replaced box.
3123         https://bugs.webkit.org/show_bug.cgi?id=194071
3124
3125         Reviewed by Antti Koivisto.
3126
3127         * LayoutReloaded/misc/LFC-passing-tests.txt:
3128
3129 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3130
3131         Fix WebKitTestRunner's testPath with Windows full paths
3132         https://bugs.webkit.org/show_bug.cgi?id=194012
3133
3134         Reviewed by Alex Christensen.
3135
3136         updateTestOptionsFromTestHeader failed to open test files because
3137         testPath returned wrong file paths. It returned a path "/C:/..."
3138         if a URL "file:///C:/..." was given.
3139
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3142
3143 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3144
3145         [WPE] Bump font related dependencies to match the GTK+ port
3146         https://bugs.webkit.org/show_bug.cgi?id=194017
3147
3148         Reviewed by Žan Doberšek.
3149
3150         * wpe/jhbuild.modules:
3151         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3152         * wpe/patches/icudata-stdlibs.patch: Added.
3153
3154 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         Enable swipe tests on iOS
3157         https://bugs.webkit.org/show_bug.cgi?id=194076
3158
3159         Reviewed by Geoffrey Garen.
3160
3161         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3162         it causes a debug assertion failure in runUIScript.
3163
3164         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3165         (WTR::UIScriptController::beginBackSwipe):
3166         (WTR::UIScriptController::completeBackSwipe):
3167
3168 2019-01-30  Keith Rollin  <krollin@apple.com>
3169
3170         Use correct printf format specifier
3171         https://bugs.webkit.org/show_bug.cgi?id=194062
3172         <rdar://problem/47686167>
3173
3174         Reviewed by Alexey Proskuryakov.
3175
3176         LayoutTestSpellChecker.mm is trying to format a variable of type
3177         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3178         actually an unsigned long long. Fix this by formatting with %llu.
3179
3180         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3181         (-[LayoutTestTextCheckingResult description]):
3182
3183 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3184
3185         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3186         https://bugs.webkit.org/show_bug.cgi?id=193979
3187
3188         Reviewed by Wenson Hsieh.
3189
3190         Fix the test for iOS. Make the test work with iOS UA string.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3193
3194 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3195
3196         Replace High Sierra LLINT CLoop bot due to hardware failure
3197         https://bugs.webkit.org/show_bug.cgi?id=194066
3198
3199         Reviewed by Aakash Jain.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/config.json:
3202
3203 2019-01-30  Keith Rollin  <krollin@apple.com>
3204
3205         [NSDragItem init] is unavailable
3206         https://bugs.webkit.org/show_bug.cgi?id=194059
3207         <rdar://problem/47685715>
3208
3209         Reviewed by Wenson Hsieh.
3210
3211         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3212         DumpRenderTree and TestWebKitAPI, which both try to create an
3213         NSDragItem in a manner that invokes this method. Address this by using
3214         -initWithPasteboardWriter instead.
3215
3216         Note that the parameter passed to initWithPasteboardWriter is likely
3217         incorrect. In both cases, the object passed does not conform to
3218         NSPasteboardWriting. However, with this fix, we're no worse off than
3219         before, and can now perform builds with newer compilers and SDKs until
3220         a real fix can be crafted. That work is tracked in
3221         https://bugs.webkit.org/show_bug.cgi?id=194060
3222
3223         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3224         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3225         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3226         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3227
3228 2019-01-30  Daniel Bates  <dabates@apple.com>
3229
3230         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3231         https://bugs.webkit.org/show_bug.cgi?id=192824
3232         <rdar://problem/47100332>
3233
3234         Reviewed by Wenson Hsieh.
3235
3236         Fix a bug where the wrong usage code was used for F13 thru F24.
3237
3238         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3239         (keyCodeForDOMFunctionKey):
3240
3241 2019-01-30  Chris Dumez  <cdumez@apple.com>
3242
3243         Regression(PSON) Load hang can occur on history navigation
3244         https://bugs.webkit.org/show_bug.cgi?id=194030
3245         <rdar://problem/47656939>
3246
3247         Reviewed by Antti Koivisto.
3248
3249         Add API test coverage.
3250
3251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3252
3253 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3254
3255         [LFC] Expand tests coverage.
3256
3257         Unreviewed test gardening.
3258
3259         * LayoutReloaded/misc/LFC-passing-tests.txt:
3260
3261 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3262
3263         [Flatpak] Add openjpeg support
3264         https://bugs.webkit.org/show_bug.cgi?id=194019
3265
3266         Reviewed by Michael Catanzaro.
3267
3268         * flatpak/org.webkit.CommonModules.yaml:
3269
3270 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3271
3272         Unreviewed, rolling out r240708.
3273         https://bugs.webkit.org/show_bug.cgi?id=194022
3274
3275         It broke WPE build (Requested by KaL on #webkit).
3276
3277         Reverted changeset:
3278
3279         "[WPE] Bump font related dependencies to match the GTK+ port"
3280         https://bugs.webkit.org/show_bug.cgi?id=194017
3281         https://trac.webkit.org/changeset/240708
3282
3283 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3284
3285         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3286         https://bugs.webkit.org/show_bug.cgi?id=194001
3287
3288         Reviewed by Antti Koivisto.
3289
3290         * LayoutReloaded/misc/LFC-passing-tests.txt:
3291
3292 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3293
3294         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3295         https://bugs.webkit.org/show_bug.cgi?id=194020
3296
3297         Reviewed by Antti Koivisto.
3298
3299         * LayoutReloaded/misc/LFC-passing-tests.txt:
3300
3301 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3302
3303         AX: Support color well on iOS
3304         https://bugs.webkit.org/show_bug.cgi?id=194010
3305
3306         Reviewed by Joanmarie Diggs.
3307
3308         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3309         (WTR::AccessibilityUIElement::stringAttributeValue):
3310
3311 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [WPE] Bump font related dependencies to match the GTK+ port
3314         https://bugs.webkit.org/show_bug.cgi?id=194017
3315
3316         Reviewed by Žan Doberšek.
3317
3318         * wpe/jhbuild.modules:
3319         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3320         * wpe/patches/icudata-stdlibs.patch: Added.
3321
3322 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3323
3324         [Mac] Update window scale API usage
3325         https://bugs.webkit.org/show_bug.cgi?id=193991
3326         rdar://problem/47614795
3327
3328         Reviewed by Tim Horton.
3329
3330         * DumpRenderTree/mac/DumpRenderTree.mm:
3331         (changeWindowScaleIfNeeded):
3332         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3333         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3334         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3335
3336 2019-01-29  Chris Dumez  <cdumez@apple.com>
3337
3338         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3339         https://bugs.webkit.org/show_bug.cgi?id=193977
3340         <rdar://problem/47643716>
3341
3342         Reviewed by Geoff Garen.
3343
3344         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3345         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3346         to the previous provisional committing *before* we make the last load. 
3347
3348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3349
3350 2019-01-29  Youenn Fablet  <youenn@apple.com>
3351
3352         Adopt new SPI to evaluate server certificate trust
3353         https://bugs.webkit.org/show_bug.cgi?id=193355
3354
3355         Reviewed by Alex Christensen.
3356
3357         Add infrastructure to handle HTTPS server trust evaluation testing.
3358
3359         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3361         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3362         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3363         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3364         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3365         * WebKitTestRunner/TestController.cpp:
3366         (WTR::TestController::resetPreferencesToConsistentValues):
3367         (WTR::TestController::didReceiveAuthenticationChallenge):
3368         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3369         * WebKitTestRunner/TestController.h:
3370         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3371         * WebKitTestRunner/TestInvocation.cpp:
3372         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3373         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3374         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3375
3376 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3377
3378         [ews-build] Add build step to print bot Configuration
3379         https://bugs.webkit.org/show_bug.cgi?id=193887
3380
3381         Reviewed by Lucas Forschler.
3382
3383         * BuildSlaveSupport/ews-build/steps.py:
3384         (PrintConfiguration): Build step to print configuration.
3385         * BuildSlaveSupport/ews-build/factories.py:
3386
3387 2019-01-29  Chris Dumez  <cdumez@apple.com>
3388
3389         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3390         https://bugs.webkit.org/show_bug.cgi?id=193967
3391         <rdar://problem/47635348>
3392
3393         Reviewed by Alex Christensen.
3394
3395         Add API test coverage.
3396
3397         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3398         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3399
3400 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3401
3402         [ews-app] Handle incoming results data
3403         https://bugs.webkit.org/show_bug.cgi?id=193973
3404
3405         Reviewed by Lucas Forschler.
3406
3407         * BuildSlaveSupport/ews-app/ews/views/results.py:
3408
3409 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3410
3411         [ews-app] Make the results url generic
3412         https://bugs.webkit.org/show_bug.cgi?id=193928
3413
3414         Reviewed by Lucas Forschler.
3415
3416         * BuildSlaveSupport/ews-app/ews/urls.py:
3417
3418 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3419
3420         [ews-build] Configure buildbot to send events to ews-app
3421         https://bugs.webkit.org/show_bug.cgi?id=193968
3422
3423         Reviewed by Lucas Forschler.
3424
3425         * BuildSlaveSupport/ews-build/events.py: Added.
3426         * BuildSlaveSupport/ews-build/master.cfg:
3427
3428 2019-01-29  Keith Rollin  <krollin@apple.com>
3429
3430         Add .xcfilelists to Run Script build phases
3431         https://bugs.webkit.org/show_bug.cgi?id=193792
3432         <rdar://problem/47201785>
3433
3434         Reviewed by Alex Christensen.
3435
3436         As part of supporting XCBuild, update the necessary Run Script build
3437         phases in their Xcode projects to refer to their associated
3438         .xcfilelist files.
3439
3440         Note that the addition of these files bumps the Xcode project version
3441         number to something that's Xcode 10 compatible. This change means that
3442         older versions of the Xcode IDE can't read these projects. Nor can it
3443         fully load workspaces that refer to these projects (the updated
3444         projects are shown as non-expandable placeholders). `xcodebuild` can
3445         still build these projects; it's just that the IDE can't open them.
3446
3447         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3448         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3449
3450 2019-01-29  John Wilander  <wilander@apple.com>
3451
3452         Add data abstraction and validation for Ad Click Attribution
3453         https://bugs.webkit.org/show_bug.cgi?id=193916
3454         <rdar://problem/47603481>
3455
3456         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3457
3458         Ad click attribution has two steps. First, the storage of an ad
3459         campaign ID for a click that takes the user to a destination
3460         site. Second, a conversion on the destination site that can be
3461         attributed to the ad click.
3462
3463         This patch adds a class that represents a request for ad click
3464         attribution. Validation makes sure that the bits of entropy
3465         reported through this mechanism is limited.
3466
3467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3468         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3469         (TestWebKitAPI::TEST):
3470
3471 2019-01-29  Chris Dumez  <cdumez@apple.com>
3472
3473         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3474         https://bugs.webkit.org/show_bug.cgi?id=193932
3475         <rdar://problem/47598947>
3476
3477         Reviewed by Brady Eidson.
3478
3479         Add API test coverage.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3482
3483 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3484
3485         Adding new passing LFC tests.
3486
3487         Unreviewed test gardening.
3488
3489         * LayoutReloaded/misc/LFC-passing-tests.txt:
3490
3491 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3492
3493         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3494         https://bugs.webkit.org/show_bug.cgi?id=193964
3495
3496         Reviewed by Antti Koivisto.
3497
3498         * LayoutReloaded/misc/LFC-passing-tests.txt:
3499
3500 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3501
3502         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3503         https://bugs.webkit.org/show_bug.cgi?id=193954
3504
3505         Reviewed by Antti Koivisto.
3506
3507         * LayoutReloaded/misc/LFC-passing-tests.txt:
3508
3509 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3510
3511         WebDriver: add support for running subtests
3512         https://bugs.webkit.org/show_bug.cgi?id=193904
3513
3514         Reviewed by Michael Catanzaro.
3515
3516         pytest already supports it by passing test.py::subtest, so we can do the same.
3517
3518         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3519         (get_item_name): Made this global.
3520         (CollectRecorder.__init__): Receive the parameter to ignore.
3521         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3522         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3523         (collect): Add parameter to ignore.
3524         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3525         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3526         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3527         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3528         (WebDriverTestRunnerSelenium.run): Ditto.
3529         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3530         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3531         (WebDriverTestRunnerW3C.run): Ditto.
3532
3533 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3534
3535         User agent string override for navigator.userAgent should be site specific quirks
3536         https://bugs.webkit.org/show_bug.cgi?id=193950
3537
3538         Reviewed by Brent Fulgham.
3539
3540         Updated per the _WKWebsitePolicies rename.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3543         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3544
3545 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3546
3547         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3548         https://bugs.webkit.org/show_bug.cgi?id=193941
3549
3550         Reviewed by Alex Christensen.
3551
3552         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3553         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3554         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3555         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3556         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3557         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3558         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3559         * TestWebKitAPI/Tests/WTF/Time.cpp:
3560         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3561         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3562         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3563         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3564
3565 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3566
3567         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3568
3569         * Scripts/webkitpy/common/config/contributors.json:
3570
3571 2019-01-28  Andy Estes  <aestes@apple.com>
3572
3573         [watchOS] Enable Parental Controls content filtering
3574         https://bugs.webkit.org/show_bug.cgi?id=193939
3575         <rdar://problem/46641912>
3576
3577         Reviewed by Ryosuke Niwa.
3578
3579         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3580
3581 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3582
3583         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3584         <https://webkit.org/b/193884>
3585
3586         Reviewed by Jiewen Tan.
3587
3588         * Scripts/webkitpy/style/checkers/cpp.py:
3589         (check_language): Add LocalAuthentication to
3590         `frameworks_with_soft_links`.
3591
3592 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3593
3594         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3595         https://bugs.webkit.org/show_bug.cgi?id=193891
3596
3597         Reviewed by Ross Kirsling.
3598
3599         There were three problems in window sizes of WebView and the host window.
3600         1. The sizes of pixel image output were incorrect.
3601         2. The host window is going to appear after window.resize was invoked.
3602         3. window.resize resized only the host window, not WebView.
3603
3604         This change solves them with a following approach.
3605         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3606         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3607            as well as DumpRenderTree in order to match the client area and the window area.
3608         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3609         d. PlatformWebView::setWindowFrame changes both window sizes.
3610         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3611
3612         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3613         (WTR::PlatformWebView::PlatformWebView): Create the host window
3614         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3615         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3616         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3617
3618 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3619
3620         [ews-app] Add method to save Step data to database
3621         https://bugs.webkit.org/show_bug.cgi?id=193890
3622
3623         Reviewed by Lucas Forschler.
3624
3625         * BuildSlaveSupport/ews-app/ews/models/step.py:
3626         (Step.save_step): Method to save step data.
3627         (Step.update_step): Method to update step data.
3628         (Step.get_existing_step): Method to fetch existing step from database.
3629         (Step.is_valid_result): Method to validate valid step result.
3630
3631 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3632
3633         [ews-app] Add method to save Build data to database
3634         https://bugs.webkit.org/show_bug.cgi?id=193735
3635
3636         Reviewed by Lucas Forschler.
3637
3638         * BuildSlaveSupport/ews-app/ews/models/build.py:
3639         (Build.save_build): Method to save build information to database.
3640         (Build.get_existing_build): Method to fetch existing build from database.
3641         (Build.is_valid_result): Method to validate build result.
3642         * BuildSlaveSupport/ews-app/ews/common/util.py:
3643         (is_valid_int_id): Method to validate valid id.
3644
3645 2019-01-28  Chris Dumez  <cdumez@apple.com>
3646
3647         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3648         https://bugs.webkit.org/show_bug.cgi?id=193915
3649         <rdar://problem/47560907>
3650
3651         Reviewed by Alex Christensen.
3652
3653         Add API test coverage.
3654
3655         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3656
3657 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3658
3659         [ews-app] Rename id variables
3660         https://bugs.webkit.org/show_bug.cgi?id=193883
3661
3662         Reviewed by Lucas Forschler.
3663
3664         * BuildSlaveSupport/ews-app/ews/models/build.py:
3665         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3666         * BuildSlaveSupport/ews-app/ews/models/step.py:
3667         * BuildSlaveSupport/ews-app/ews/urls.py:
3668         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3669         * BuildSlaveSupport/ews-app/ews/views/results.py:
3670         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3671
3672 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3673
3674         [ews-app] Allow certain fields to be empty
3675         https://bugs.webkit.org/show_bug.cgi?id=193892
3676
3677         Reviewed by Lucas Forschler.
3678
3679         * BuildSlaveSupport/ews-app/ews/models/build.py:
3680         * BuildSlaveSupport/ews-app/ews/models/step.py:
3681
3682 2019-01-28  Rob Buis  <rbuis@igalia.com>
3683
3684         Update MIME type parser
3685         https://bugs.webkit.org/show_bug.cgi?id=180526
3686
3687         Reviewed by Frédéric Wang.
3688
3689         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3690         (TestWebKitAPI::TEST):
3691
3692 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3693
3694         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3695         https://bugs.webkit.org/show_bug.cgi?id=193896
3696
3697         Reviewed by Antti Koivisto.
3698
3699         * LayoutReloaded/misc/LFC-passing-tests.txt:
3700
3701 2018-12-15  Darin Adler  <darin@apple.com>
3702
3703         Replace many uses of String::format with more type-safe alternatives
3704         https://bugs.webkit.org/show_bug.cgi?id=192742
3705
3706         Reviewed by Mark Lam.
3707
3708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3709         (WTR::cacheTestRunnerCallback): Use makeString.
3710         * WebKitTestRunner/TestController.cpp:
3711         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3712         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3713
3714 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3715
3716         Use a load optimizer for some sites
3717         https://bugs.webkit.org/show_bug.cgi?id=193881
3718         <rdar://problem/46325455>
3719
3720         Reviewed by Brent Fulgham.
3721
3722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3723         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3724
3725 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3726
3727         AX: Introduce a static accessibility tree
3728         https://bugs.webkit.org/show_bug.cgi?id=193348
3729         <rdar://problem/47203295>
3730
3731         Reviewed by Ryosuke Niwa.
3732
3733         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3734
3735 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3736
3737         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3738         https://bugs.webkit.org/show_bug.cgi?id=193867
3739
3740         Reviewed by Antti Koivisto.
3741
3742         * LayoutReloaded/misc/LFC-passing-tests.txt:
3743
3744 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3745
3746         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3747         https://bugs.webkit.org/show_bug.cgi?id=193865
3748
3749         Reviewed by Antti Koivisto.
3750
3751         * LayoutReloaded/misc/LFC-passing-tests.txt:
3752
3753 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3754
3755         Need a mechanism to override navigator.userAgent
3756         https://bugs.webkit.org/show_bug.cgi?id=193762
3757         <rdar://problem/47504939>
3758
3759         Reviewed by Brent Fulgham.
3760
3761         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3762
3763         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3764         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3765         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3766
3767 2019-01-25  Dean Jackson  <dino@apple.com>
3768
3769         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3770         https://bugs.webkit.org/show_bug.cgi?id=193831
3771         <rdar://problem/47399263>
3772
3773         Reviewed by Chris Dumez.
3774
3775         Two new tests that exercise cross-origin and same-origin System
3776         Previews.
3777
3778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3779
3780 2019-01-25  Keith Rollin  <krollin@apple.com>
3781
3782         Update Xcode projects with "Check .xcfilelists" build phase
3783         https://bugs.webkit.org/show_bug.cgi?id=193790
3784         <rdar://problem/47201374>
3785
3786         Reviewed by Alex Christensen.
3787
3788         Support for XCBuild includes specifying inputs and outputs to various
3789         Run Script build phases. These inputs and outputs are specified as
3790         .xcfilelist files. Once created, these .xcfilelist files need to be
3791         kept up-to-date. In order to check that they are up-to-date or not,
3792         add an Xcode build step that invokes an external script that performs
3793         the checking. If the .xcfilelists are found to be out-of-date, update
3794         them, halt the build, and instruct the developer to restart the build
3795         with up-to-date files.
3796
3797         At this time, the checking and regenerating is performed only if the
3798         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3799         who want to use this facility can set this variable and test out the
3800         checking/regenerating. Once it seems like there are no egregious
3801         issues that upset a developer's workflow, we'll unconditionally enable
3802         this facility.
3803
3804         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3805         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3806         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3807         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3808
3809 2019-01-25  Keith Rollin  <krollin@apple.com>
3810
3811         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3812         https://bugs.webkit.org/show_bug.cgi?id=193781
3813         <rdar://problem/47201153>
3814
3815         Reviewed by Alex Christensen.
3816
3817         Part of generating the .xcfilelists used as part of adopting XCBuild
3818         includes running `make DerivedSources.make` from a standalone script.
3819         It’s important for this invocation to have the same environment as
3820         when the actual build invokes `make DerivedSources.make`. If the
3821         environments are different, then the two invocations will provide
3822         different results. In order to get the same environment in the
3823         standalone script, have the script launch xcodebuild targeting the
3824         "Apply Configuration to XCFileLists" build target, which will then
3825         re-invoke our standalone script. The script is now running again, this
3826         time in an environment with all workspace, project, target, xcconfig
3827         and other environment variables established.
3828
3829         The "Apply Configuration to XCFileLists" build target accomplishes
3830         this task via a small embedded shell script that consists only of:
3831
3832             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3833
3834         The process that invokes "Apply Configuration to XCFileLists" first
3835         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3836         evaluated and exports it into the shell environment. When xcodebuild
3837         is invoked, it inherits the value of this variable and can `eval` the
3838         contents of that variable. Our external standalone script can then set
3839         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3840         of command-line parameters needed to restart itself in the appropriate
3841         state.
3842
3843         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3844         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3845
3846 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3847
3848         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3849         https://bugs.webkit.org/show_bug.cgi?id=193802
3850         <rdar://problem/46010580>
3851
3852         Reviewed by Andy Estes.
3853
3854         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3855         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3856         (TEST):
3857
3858 2019-01-25  Daniel Bates  <dabates@apple.com>
3859
3860         [iOS] uiController.keyDown() does not translate Control modified key
3861         https://bugs.webkit.org/show_bug.cgi?id=192898
3862
3863         Reviewed by Wenson Hsieh.
3864
3865         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3866         key translation, as applicable. Among other cases, key translation occurs when performing
3867         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3868         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3869         human pressing down and releasing key(s) using a hardware keyboard.
3870
3871         * WebKitTestRunner/ios/HIDEventGenerator.h:
3872         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3873         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3874
3875         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3876         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3877         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3878         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3879         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3880         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3881         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3882         (-[HIDEventGenerator longPress:completionBlock:]):
3883         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3884         Update code for above renaming.
3885
3886         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3887         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3888
3889         (-[HIDEventGenerator keyDown:]): Added.
3890         (-[HIDEventGenerator keyUp:]): Added.
3891         (-[HIDEventGenerator keyPress:completionBlock:]):
3892         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3893         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3894         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3895         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3896         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3897         (WTR::parseModifier): Deleted.
3898
3899 2019-01-25  Keith Rollin  <krollin@apple.com>
3900
3901         Complete the implementation of generate-xcfilelists
3902         https://bugs.webkit.org/show_bug.cgi?id=193782
3903
3904         Reviewed by Alex Christensen.
3905
3906         A preliminary version of generate-xcfilelists was added in r238008.
3907         This patch updates that script in order to:
3908
3909         - Support checking of .xcfilelists
3910         - Perform better execution of `make DerivedSources.make` by
3911           relaunching generate-xcfilelists under xcodebuild
3912         - Support incremental generation and checking of .xcfilelists
3913         - Support supplementary .xcfilelists files from WebKitAdditions
3914         - Support being wrapped by parallel version of generate-xcfilelists in
3915           Internal that adds support for (re)generating WebKit projects in
3916           that repo.
3917         - Support builds that have been performed in WebKitBuild as well as
3918           ~/Library/Developer/code/DerivedData
3919         - Increase robustness and debugging facilities.
3920
3921         * Scripts/generate-xcfilelists:
3922
3923 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3924
3925         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3926         https://bugs.webkit.org/show_bug.cgi?id=193297
3927         <rdar://problem/47158841>
3928
3929         Unreviewed test case fix.
3930
3931         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3932         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3933
3934         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3935         (TEST):
3936
3937 2019-01-25  Keith Rollin  <krollin@apple.com>
3938
3939         Update existing .xcfilelists
3940         https://bugs.webkit.org/show_bug.cgi?id=193791
3941         <rdar://problem/47201706>
3942
3943         Reviewed by Alex Christensen.
3944
3945         Many .xcfilelist files were added in r238824 in order to support
3946         XCBuild. Update these with recent changes to the set of build files
3947         and with the current generate-xcfilelist script.
3948
3949         * DumpRenderTree/DerivedSources-input.xcfilelist:
3950         * DumpRenderTree/DerivedSources-output.xcfilelist:
3951         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3952         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3953
3954 2019-01-25  Keith Rollin  <krollin@apple.com>
3955
3956         Fix missing dependencies in extract-dependencies-from-makefile
3957         https://bugs.webkit.org/show_bug.cgi?id=193783
3958         <rdar://problem/47201571>
3959
3960         Reviewed by Alex Christensen.
3961
3962         The extract-dependencies-from-makefile script generates .xcfilelists
3963         for XCBuild by invoking a makefile in --debug mode, parsing the
3964         dependency information in the output, and extracting information
3965         regarding targets and dependents. However, the way `make` emits this
3966         dependency information is not rigorous, and so we need to determine
3967         what lines to look for and parse by trial and error. This approach
3968         didn't coriginally atch all the information we needed to collect, so
3969         update the script to look for the additional lines we now know to look
3970         for.
3971
3972         * Scripts/extract-dependencies-from-makefile:
3973         (Parser):
3974         (Parser.addTarget):
3975         (Parser.addPrereq):
3976         (Parser.doParse):
3977
3978 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3979
3980         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3981         https://bugs.webkit.org/show_bug.cgi?id=193297
3982         <rdar://problem/47158841>
3983
3984         Reviewed by Alex Christensen.
3985
3986         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3987             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3989         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3990         activating the message used to trigger the callback when it is set.
3991
3992 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3993
3994         WKWebView.goBack should reload if there is a safe browsing warning
3995         https://bugs.webkit.org/show_bug.cgi?id=193805
3996         <rdar://problem/46908216>
3997
3998         Reviewed by Geoff Garen.
3999
4000         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4001         (+[Simple3LookupContext sharedLookupContext]):
4002         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4003         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4004         (TEST):
4005
4006 2019-01-25  Chris Dumez  <cdumez@apple.com>
4007
4008         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4009         https://bugs.webkit.org/show_bug.cgi?id=193788
4010         <rdar://problem/47531231>
4011
4012         Reviewed by Alex Christensen.
4013
4014         Add API test coverage.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4017         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4018
4019 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4020
4021         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4022         https://bugs.webkit.org/show_bug.cgi?id=193771
4023
4024         Unreviewed infrastructure fix.
4025
4026         * Scripts/webkitpy/port/darwin.py:
4027         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4028
4029 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4030
4031         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4032
4033 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4034
4035         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4036
4037         * Scripts/webkitpy/common/config/contributors.json:
4038
4039 2019-01-25  Chris Dumez  <cdumez@apple.com>
4040
4041         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4042         https://bugs.webkit.org/show_bug.cgi?id=193779
4043         <rdar://problem/46170903>
4044
4045         Reviewed by Antti Koivisto.
4046
4047         Add API test that quickly navigates forward to a previous process without waiting for it to
4048         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4049         the process' previous page when reconnecting the it for the forward navigation.
4050
4051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4052
4053 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4054
4055         Need a way for JavaScript (or bundle) code to participate in undo
4056         https://bugs.webkit.org/show_bug.cgi?id=190009
4057         <rdar://problem/44807048>
4058
4059         Reviewed by Ryosuke Niwa.
4060
4061         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4062         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4063
4064         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4065         (WTR::UIScriptController::lastUndoLabel const):
4066         (WTR::UIScriptController::firstRedoLabel const):
4067         (WTR::UIScriptController::platformUndoManager const):
4068         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4069         (WTR::UIScriptController::lastUndoLabel const):
4070         (WTR::UIScriptController::firstRedoLabel const):
4071         (WTR::UIScriptController::platformUndoManager const):
4072         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4073         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4074         (WTR::UIScriptController::lastUndoLabel const):
4075         (WTR::UIScriptController::firstRedoLabel const):
4076         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4077         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4078         (WTR::UIScriptController::lastUndoLabel const):
4079         (WTR::UIScriptController::firstRedoLabel const):
4080         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4081         (WTR::UIScriptController::platformUndoManager const):
4082         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4083         (WTR::UIScriptController::platformUndoManager const):
4084
4085 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4086
4087         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4088         https://bugs.webkit.org/show_bug.cgi?id=193824
4089
4090         Reviewed by Antti Koivisto.
4091
4092         * LayoutReloaded/misc/LFC-passing-tests.txt:
4093
4094 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4095
4096         Update macOS JSC bot configurations
4097         https://bugs.webkit.org/show_bug.cgi?id=193739
4098
4099         Reviewed by Alexey Proskuryakov.
4100
4101         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4103         (BubbleQueueServer): Move JSC EWS to Mojave section.
4104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4105         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4106         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4107
4108 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4109
4110         [Win][WebKitTestRunner] Implement EventSenderProxy
4111         https://bugs.webkit.org/show_bug.cgi?id=193755
4112
4113         Reviewed by Don Olmstead.
4114
4115         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4116         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4117         (WTR::EventSenderProxy::dispatchMessage):
4118         (WTR::EventSenderProxy::EventSenderProxy):
4119         (WTR::EventSenderProxy::mouseDown):
4120         (WTR::EventSenderProxy::mouseUp):
4121         (WTR::EventSenderProxy::mouseMoveTo):
4122         (WTR::EventSenderProxy::mouseScrollBy):
4123         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4124
4125 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4126
4127         Unreviewed fix for API test failure after r240437.
4128
4129         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4130
4131         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4132
4133 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4134
4135         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4136         https://bugs.webkit.org/show_bug.cgi?id=193787
4137         <rdar://problem/47497634>
4138
4139         Reviewed by Alexey Proskuryakov.
4140
4141         * Scripts/webkitdirs.pm:
4142         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4143
4144 2019-01-24  Truitt Savell  <tsavell@apple.com>
4145
4146         Unreviewed, rolling out r240446.
4147
4148         Casued 5 API failures
4149
4150         Reverted changeset:
4151
4152         "Activate the WebResourceLoadStatisticsStore in the
4153         NetworkProcess and deactivate it in the UIProcess."
4154         https://bugs.webkit.org/show_bug.cgi?id=193297
4155         https://trac.webkit.org/changeset/240446
4156
4157 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4158
4159         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4160         https://bugs.webkit.org/show_bug.cgi?id=193741
4161         <rdar://problem/47135030>
4162
4163         Reviewed by Antti Koivisto and Simon Fraser.
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4167         (TestWebKitAPI::TEST):
4168
4169 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4170
4171         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4172         https://bugs.webkit.org/show_bug.cgi?id=193297
4173         <rdar://problem/47158841>
4174
4175         Reviewed by Alex Christensen.
4176
4177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4178         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4179         activating the message used to trigger the callback when it is set.
4180
4181 2019-01-24  John Wilander  <wilander@apple.com>
4182
4183         Add Ad Click Attribution as an internal/experimental feature
4184         https://bugs.webkit.org/show_bug.cgi?id=193685
4185         <rdar://problem/47450399>
4186
4187         Reviewed by Brent Fulgham.
4188
4189         Added test option adClickAttributionEnabled.
4190
4191         * DumpRenderTree/TestOptions.cpp:
4192         (TestOptions::TestOptions):
4193         * DumpRenderTree/TestOptions.h:
4194         * DumpRenderTree/mac/DumpRenderTree.mm:
4195         (setWebPreferencesForTestOptions):
4196
4197 2019-01-24  Antti Koivisto  <antti@apple.com>
4198
4199         [PSON] Flash on back navigation on Mac
4200         https://bugs.webkit.org/show_bug.cgi?id=193716
4201         <rdar://problem/47148458>
4202
4203         Reviewed by Chris Dumez.
4204
4205         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4206
4207         Closing of the previous page is delayed so waiting for didFinishNavigation is
4208         not sufficient to guarantee we have received all the messages. Wait for them.
4209
4210 2019-01-24  Chris Dumez  <cdumez@apple.com>
4211
4212         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4213         https://bugs.webkit.org/show_bug.cgi?id=193761
4214         <rdar://problem/47456405>
4215
4216         Reviewed by Alex Christensen.
4217
4218         Add API test coverage.
4219
4220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4221
4222 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4223
4224         webkitpy: Missing PID in crashlog name should not be fatal
4225         https://bugs.webkit.org/show_bug.cgi?id=193771
4226
4227         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4228         of raising an exception.
4229
4230         Reviewed by Lucas Forschler.
4231
4232         * Scripts/webkitpy/port/darwin.py:
4233         (DarwinPort._merge_crash_logs):
4234
4235 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4236
4237         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4238         https://bugs.webkit.org/show_bug.cgi?id=193746
4239
4240         Reviewed by Youenn Fablet.
4241
4242         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4243         so we'd best just not call it.
4244
4245         * Scripts/webkitpy/w3c/test_exporter.py:
4246         (WebPlatformTestExporter.create_branch_with_patch):
4247
4248 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4249
4250         Move FileSystem to WTF
4251         https://bugs.webkit.org/show_bug.cgi?id=193602
4252
4253         Reviewed by Yusuke Suzuki.
4254
4255         * DumpRenderTree/win/DumpRenderTree.cpp:
4256         * TestWebKitAPI/CMakeLists.txt:
4257         * TestWebKitAPI/PlatformGTK.cmake:
4258         * TestWebKitAPI/PlatformJSCOnly.cmake:
4259         * TestWebKitAPI/PlatformPlayStation.cmake:
4260         * TestWebKitAPI/PlatformWPE.cmake:
4261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4262         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4263         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4264         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4265         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4266         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4267         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4268         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4269         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4270         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4271
4272 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4273
4274         [WPE] Remove hard dependency on subprocess32 for the API tests
4275
4276         Rubber-stamped by Carlos Garcia Campos.
4277
4278         * glib/api_test_runner.py:
4279         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4280         its presence only when running WPEQt tests.
4281
4282 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4283
4284         [GLIB] Expose JavaScriptCore options in GLib public API
4285         https://bugs.webkit.org/show_bug.cgi?id=188742
4286
4287         Reviewed by Michael Catanzaro.
4288
4289         Add a test for the new API.
4290
4291         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4292         (testsJSCOptions):
4293         (main):
4294
4295 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4296
4297         [GTK][WPE] Support JPEG 2000 images
4298         https://bugs.webkit.org/show_bug.cgi?id=186272
4299
4300         Reviewed by Žan Doberšek.
4301
4302         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4303
4304         * gtk/jhbuild.modules:
4305         * wpe/jhbuild.modules:
4306
4307 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4308
4309         check-webkit-style should warn when using soft-linking macros in a header
4310         <https://webkit.org/b/193750>
4311
4312         Reviewed by Darin Adler.
4313
4314         * Scripts/webkitpy/style/checkers/cpp.py:
4315         (check_language): Add softlink/header check by refactoring the
4316         softlink/framework check.
4317         (CppChecker): Enable softlink/header check by default.
4318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4319         (CppStyleTest.test_softlink_framework): Rename from
4320         CppStyleTest.test_softlink() and change test framework name in
4321         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4322         files. Set file_name for macros that only appear in headers.
4323         (CppStyleTest.test_softlink_header): Add tests for using
4324         soft-link macros in headers.
4325
4326 2019-01-23  Chris Dumez  <cdumez@apple.com>
4327
4328         Deprecate API to limit the maximum number of WebProcesses
4329         https://bugs.webkit.org/show_bug.cgi?id=193725
4330         <rdar://problem/47464879>
4331
4332         Reviewed by Geoff Garen.
4333
4334         Update existing API tests to stop using deprecated API.
4335
4336         * MiniBrowser/mac/AppDelegate.m:
4337         (defaultConfiguration):
4338         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4339         (TestWebKitAPI::TEST):
4340         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4341         (TestWebKitAPI::TEST):
4342         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4343         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4344         (TEST):
4345         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4346         (TEST):
4347
4348 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4349
4350         [ews-app] Rename ews model buildermappings to buildermapping
4351         https://bugs.webkit.org/show_bug.cgi?id=193729
4352
4353         Reviewed by Lucas Forschler.
4354
4355         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4356         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4357         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4358
4359 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4360
4361         [ews-app] Rename ews model steps to step
4362         https://bugs.webkit.org/show_bug.cgi?id=193697
4363
4364         Reviewed by Lucas Forschler.
4365
4366         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4367         (Step): Renamed Steps to Step.
4368
4369 2019-01-23  Sihui Liu  <sihui_liu@apple.com>