Regression(PSON) URL scheme handlers can no longer respond asynchronously
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-30  Chris Dumez  <cdumez@apple.com>
2
3         Regression(PSON) URL scheme handlers can no longer respond asynchronously
4         https://bugs.webkit.org/show_bug.cgi?id=197426
5         <rdar://problem/50256169>
6
7         Reviewed by Brady Eidson.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12         (-[PSONScheme setShouldRespondAsynchronously:]):
13         (-[PSONScheme webView:startURLSchemeTask:]):
14         (-[PSONScheme webView:stopURLSchemeTask:]):
15
16 2019-04-30  Chris Dumez  <cdumez@apple.com>
17
18         Unreviewed, rolling out r244802.
19
20         Caused an API test failure
21
22         Reverted changeset:
23
24         "Regression(PSON) URL scheme handlers can no longer respond
25         asynchronously"
26         https://bugs.webkit.org/show_bug.cgi?id=197426
27         https://trac.webkit.org/changeset/244802
28
29 2019-04-30  Chris Dumez  <cdumez@apple.com>
30
31         Regression(PSON) URL scheme handlers can no longer respond asynchronously
32         https://bugs.webkit.org/show_bug.cgi?id=197426
33         <rdar://problem/50256169>
34
35         Reviewed by Brady Eidson.
36
37         Add API test coverage.
38
39         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
40         (-[PSONScheme setShouldRespondAsynchronously:]):
41         (-[PSONScheme webView:startURLSchemeTask:]):
42         (-[PSONScheme webView:stopURLSchemeTask:]):
43
44 2019-04-30  Chris Dumez  <cdumez@apple.com>
45
46         Only use a related page's process if that page has not been closed yet
47         https://bugs.webkit.org/show_bug.cgi?id=197393
48         <rdar://problem/50302423>
49
50         Reviewed by Tim Horton.
51
52         Add API test coverage.
53
54         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
55
56 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
57
58         [ews-build] Enable Bindings tests queue on new EWS
59         https://bugs.webkit.org/show_bug.cgi?id=197424
60
61         Reviewed by Lucas Forschler.
62
63         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
64         (StatusBubble):
65         * BuildSlaveSupport/ews-build/config.json:
66
67 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
68
69         [ews-build] Configure ews151 for running various tests
70         https://bugs.webkit.org/show_bug.cgi?id=197419
71
72         Reviewed by Lucas Forschler.
73
74         * BuildSlaveSupport/ews-build/config.json:
75
76 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
77
78         [ews-build] Parse and display bindings test failures
79         https://bugs.webkit.org/show_bug.cgi?id=197423
80
81         Reviewed by Lucas Forschler.
82
83         * BuildSlaveSupport/ews-build/steps.py:
84         (RunBindingsTests.__init__): Set timeout of 5 minutes.
85         (RunBindingsTests.start): Initialize log_observer for json output.
86         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
87         (RunBindingsTests._addToLog): Method to add message to log.
88         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
89
90 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
91
92         Unreviewed. Add myself as a committer.
93
94         * Scripts/webkitpy/common/config/contributors.json:
95
96 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
97
98         [ews-build] Enable webkitpy queue on new EWS
99         https://bugs.webkit.org/show_bug.cgi?id=197396
100
101         Reviewed by Lucas Forschler.
102
103         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
104         (StatusBubble):
105         * BuildSlaveSupport/ews-build/config.json:
106
107 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
108
109         [ews-build] Parse and display webkitpy failures
110         https://bugs.webkit.org/show_bug.cgi?id=197395
111
112         Reviewed by Lucas Forschler.
113
114         * BuildSlaveSupport/ews-build/steps.py:
115         (RunWebKitPyTests.start): Initialize log_observer for json output.
116         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
117         (RunWebKitPyTests._addToLog): Method to add message to log.
118         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
119
120 2019-04-29  Alex Christensen  <achristensen@webkit.org>
121
122         <rdar://problem/50299396> Fix internal High Sierra build
123         https://bugs.webkit.org/show_bug.cgi?id=197388
124
125         * DumpRenderTree/mac/Configurations/Base.xcconfig:
126         * MiniBrowser/Configurations/Base.xcconfig:
127         * MobileMiniBrowser/Configurations/Base.xcconfig:
128         * TestWebKitAPI/Configurations/Base.xcconfig:
129         * WebKitTestRunner/Configurations/Base.xcconfig:
130
131 2019-04-29  Youenn Fablet  <youenn@apple.com>
132
133         Remove spurious GVA printf logging
134         https://bugs.webkit.org/show_bug.cgi?id=197368
135         <rdar://problem/35975256>
136
137         Reviewed by Alexey Proskuryakov.
138
139         * Scripts/webkitpy/port/mac.py:
140         (MacPort.logging_patterns_to_strip):
141
142 2019-04-29  Youenn Fablet  <youenn@apple.com>
143
144         getDisplayMedia should be called on user gesture
145         https://bugs.webkit.org/show_bug.cgi?id=197356
146         <rdar://problem/50296074>
147
148         Reviewed by Eric Carlson.
149
150         Update test configuration to inject internals
151         so that we can use it to simulate a user click to call getDisplayMedia.
152
153         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
154         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
155         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
156
157 2019-04-26  Stephanie Lewis  <slewis@apple.com>
158
159         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
160         https://bugs.webkit.org/show_bug.cgi?id=197339
161
162         Reviewed by Dewei Zhu.
163
164         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
165         test run for setup steps that are too expensive to do every iteration.
166
167         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
168         (BenchmarkRunner._run_benchmark):
169         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
170         (BrowserDriver):
171         (BrowserDriver.prepare_initial_env):
172         (BrowserDriver.restore_env_after_all_testing):
173         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
174         (LinuxBrowserDriver.prepare_initial_env):
175         (LinuxBrowserDriver.restore_env_after_all_testing):
176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
177         (OSXBrowserDriver.prepare_initial_env):
178         (OSXBrowserDriver.restore_env_after_all_testing):
179
180 2019-04-28  Andy Estes  <aestes@apple.com>
181
182         Fix the watchOS engineering build.
183
184         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
185         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
186
187 2019-04-27  Chris Dumez  <cdumez@apple.com>
188
189         [WKTR] Move test timeout handling to the UIProcess
190         https://bugs.webkit.org/show_bug.cgi?id=197333
191
192         Reviewed by Darin Adler.
193
194         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
195         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
196         every WebContent process in the case of swapping.
197
198         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
199         would lead to crashes when firing the timer.
200
201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
202         (WTR::InjectedBundle::didReceiveMessageToPage):
203         (WTR::InjectedBundle::done):
204         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
205         (WTR::InjectedBundle::shouldDumpPixels const):
206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
207         (WTR::TestRunner::TestRunner):
208         (WTR::TestRunner::waitUntilDone):
209         (WTR::TestRunner::setWaitUntilDone):
210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
211         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
212         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
213         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
214         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
215         * WebKitTestRunner/TestInvocation.cpp:
216         (WTR::TestInvocation::TestInvocation):
217         (WTR::TestInvocation::createTestSettingsDictionary):
218         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
219         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
220         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
221         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
222         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
223         (WTR::TestInvocation::setWaitUntilDone):
224         (WTR::TestInvocation::done):
225         * WebKitTestRunner/TestInvocation.h:
226
227 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
228
229         [JSC] linkPolymorphicCall now does GC
230         https://bugs.webkit.org/show_bug.cgi?id=197306
231
232         Reviewed by Saam Barati.
233
234         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
235         To add this test, we add `runWithoutBaseOption`.
236
237         * Scripts/run-jsc-stress-tests:
238
239 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
240
241         Update inactive reviewers' status to 'contributor'.
242
243         Accidentally skipped one at first.
244
245         * Scripts/webkitpy/common/config/contributors.json:
246
247 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
248
249         Update inactive reviewers' status to 'contributor'.
250
251         * Scripts/webkitpy/common/config/contributors.json: The change.
252
253         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
254         * Scripts/webkitpy/common/checkout/checkout_mock.py:
255         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
256         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
257         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
258         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
259         * Scripts/webkitpy/tool/commands/queries_unittest.py:
260         * Scripts/webkitpy/tool/commands/upload_unittest.py:
261         Sadly, regression tests operate on a crazy mix of mock and live data for
262         contributors.json. It would be a substantial project to mock all code paths,
263         so changing the tests instead.
264
265 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
266
267         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
268         https://bugs.webkit.org/show_bug.cgi?id=197171
269         <rdar://problem/47454979>
270
271         Reviewed by Youenn Fablet.
272
273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
275         (TestWebKitAPI::TEST):
276
277 2019-04-26  David Kilzer  <ddkilzer@apple.com>
278
279         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
280         <https://webkit.org/b/197314>
281         <rdar://problem/50245252>
282
283         Reviewed by Simon Fraser.
284
285         * WebKitTestRunner/UIScriptControllerCocoa.mm:
286         (WTR::UIScriptController::lastUndoLabel const):
287         (WTR::UIScriptController::firstRedoLabel const):
288         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
289
290         * WebKitTestRunner/ios/HIDEventGenerator.mm:
291         (-[HIDEventGenerator sendEventStream:completionBlock:]):
292         - Call -autorelease to fix leak of NSDictionary.
293
294         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
295         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
296         (WTR::UIScriptController::selectFormPopoverTitle const):
297         (WTR::UIScriptController::textContentType const):
298         (WTR::UIScriptController::formInputLabel const):
299         (WTR::UIScriptController::scrollingTreeAsText const):
300         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
301
302 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
303
304         webkitpy: Running a single test will always use the default device
305         https://bugs.webkit.org/show_bug.cgi?id=195472
306         <rdar://problem/48724825>
307
308         Reviewed by Lucas Forschler.
309
310         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
311         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
312         requested will be run regardless of what shard they are in.
313
314         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
315         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
316         * Scripts/webkitpy/layout_tests/controllers/manager.py:
317         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
318         on the default device type.
319         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
320         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
321         (RunTest.test_run_part): Ditto.
322
323 2019-04-26  Alex Christensen  <achristensen@webkit.org>
324
325         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
326         https://bugs.webkit.org/show_bug.cgi?id=197165
327
328         Reviewed by Youenn Fablet.
329
330         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
331
332 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
333
334         Replace iOS build queue hardware
335         https://bugs.webkit.org/show_bug.cgi?id=197312
336
337         Reviewed by Aakash Jain.
338
339         * BuildSlaveSupport/build.webkit.org-config/config.json:
340         Use newer hardware that supports macOS Mojave.
341
342 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
343
344         check-webkit-style complains the first block in while loop.
345         https://bugs.webkit.org/show_bug.cgi?id=197307
346
347         The style checker shouldn't complain about an open brace on
348         its own line if the last non-whitespace character on the previous
349         non-blank line is another open brace, because it's likely to
350         indicate the begining of a nested code block.
351
352         Reviewed by Alex Christensen.
353
354         * Scripts/webkitpy/style/checkers/cpp.py:
355         (check_braces):
356         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
357         (WebKitStyleTest.test_braces):
358
359 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
360
361         Stop IDB transactions to release locked database files when network process is ready to suspend
362         https://bugs.webkit.org/show_bug.cgi?id=196372
363         <rdar://problem/48930116>
364
365         Reviewed by Brady Eidson.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
369         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
370         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
371         (runTestAndCheckResult):
372         (keepNetworkProcessActive):
373         (TEST):
374
375 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
376
377         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
378         https://bugs.webkit.org/show_bug.cgi?id=188357
379         <rdar://problem/42986633>
380
381         Reviewed by Dean Jackson.
382
383         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
384         tests would fall into low memory mode and have different behavior.
385         
386         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
387         to Internals, so it's shared by DRT and WTR.
388         
389         We no longer need the WK2 C SPI glue.
390
391         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
392         (WTR::InjectedBundlePage::prepare):
393
394 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
395
396         webkitpy: Including skipped tests in the final count
397         https://bugs.webkit.org/show_bug.cgi?id=197298
398         <rdar://problem/49705424>
399
400         Reviewed by Lucas Forschler.
401
402         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
403         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
404
405 2019-04-25  Timothy Hatcher  <timothy@apple.com>
406
407         Disable date and time inputs on iOSMac.
408         https://bugs.webkit.org/show_bug.cgi?id=197287
409         rdar://problem/46794376
410
411         Reviewed by Wenson Hsieh.
412
413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
414
415 2019-04-25  Alex Christensen  <achristensen@webkit.org>
416
417         Fix test-webkitpy after r244653
418         https://bugs.webkit.org/show_bug.cgi?id=197131
419
420         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
421         Also use C++17.
422
423 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
424
425         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
426         https://bugs.webkit.org/show_bug.cgi?id=196991
427         <rdar://problem/45507423>
428
429         Reviewed by Alex Christensen.
430
431         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
432         (-[NavigationTestDelegate init]):
433         (-[NavigationTestDelegate waitForDidFinishNavigation]):
434         (-[NavigationTestDelegate webView:didFinishNavigation:]):
435         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
436         (TestWebKitAPI::TEST):
437         (TEST): Deleted.
438
439 2019-04-25  Alex Christensen  <achristensen@webkit.org>
440
441         Revert some code accidentally committed with r244653
442         https://bugs.webkit.org/show_bug.cgi?id=197131
443
444         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
445         (TestWebKitAPI::TEST):
446
447 2019-04-25  Alex Christensen  <achristensen@webkit.org>
448
449         Start using C++17
450         https://bugs.webkit.org/show_bug.cgi?id=197131
451
452         Reviewed by Darin Adler.
453
454         * DumpRenderTree/mac/Configurations/Base.xcconfig:
455         * MiniBrowser/Configurations/Base.xcconfig:
456         * MobileMiniBrowser/Configurations/Base.xcconfig:
457         * TestWebKitAPI/Configurations/Base.xcconfig:
458         * WebKitTestRunner/Configurations/Base.xcconfig:
459
460 2019-04-25  Commit Queue  <commit-queue@webkit.org>
461
462         Unreviewed, rolling out r244627.
463         https://bugs.webkit.org/show_bug.cgi?id=197282
464
465         Causing internal build failures (Requested by ShawnRoberts on
466         #webkit).
467
468         Reverted changeset:
469
470         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
471         https://bugs.webkit.org/show_bug.cgi?id=197171
472         https://trac.webkit.org/changeset/244627
473
474 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
475
476         [GTK] Hardcoded text color in input fields
477         https://bugs.webkit.org/show_bug.cgi?id=126907
478
479         Reviewed by Michael Catanzaro.
480
481         Add dark-mode command line option to MiniBrowser.
482
483         * MiniBrowser/gtk/main.c:
484         (main):
485
486 2019-04-24  Zalan Bujtas  <zalan@apple.com>
487
488         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
489         https://bugs.webkit.org/show_bug.cgi?id=196948
490         <rdar://problem/49927131>
491
492         Reviewed by Tim Horton.
493
494         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
495         (TEST):
496         The expected order of incoming events is
497         1. didInvalidateIntrinsicContentSize
498         2. didFirstLayout
499         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
500         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
501         (and remember, all we care about is ordering).
502
503 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
504
505         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
506         https://bugs.webkit.org/show_bug.cgi?id=197171
507         <rdar://problem/47454979>
508
509         Reviewed by Youenn Fablet.
510
511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
512         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
513         (TestWebKitAPI::TEST):
514
515 2019-04-24  Brady Eidson  <beidson@apple.com>
516
517         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
518         https://bugs.webkit.org/show_bug.cgi?id=191362
519
520         Reviewed by Alex Christensen.
521
522         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
523           from an XHR to a custom protocol.
524
525 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
526
527         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
528         https://bugs.webkit.org/show_bug.cgi?id=197273
529
530         Reviewed by Dean Jackson.
531
532         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
533         so that WebCoreTestSupport::resetInternalsObject() is always run.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (resetWebViewToConsistentStateBeforeTesting):
537         (runTest):
538
539 2019-04-24  John Wilander  <wilander@apple.com>
540
541         Age out unconverted Ad Click Attributions after one week.
542         https://bugs.webkit.org/show_bug.cgi?id=197238
543         <rdar://problem/50177349>
544
545         Reviewed by Chris Dumez.
546
547         This patch adds infrastructure to allow tests to expire all unconverted
548         attributions early.
549
550         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
552         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
553         * WebKitTestRunner/InjectedBundle/TestRunner.h:
554         * WebKitTestRunner/TestController.cpp:
555         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
556         * WebKitTestRunner/TestController.h:
557         * WebKitTestRunner/TestInvocation.cpp:
558         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
559
560 2019-04-24  Chris Dumez  <cdumez@apple.com>
561
562         Fix flaky crashes in a couple of PSON API tests
563         https://bugs.webkit.org/show_bug.cgi?id=197239
564
565         Reviewed by Tim Horton.
566
567         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
568
569         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
570
571 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
572
573         Make it possible to control the renderTreeAsText output by setting options on testRunner
574         https://bugs.webkit.org/show_bug.cgi?id=197133
575
576         Reviewed by Sam Weinig.
577
578         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
579         that make sense in testing (those that don't dump unstable data like addresses), and plumb
580         these flags through the various framework layers.
581
582         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
583
584         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
585         and hand-code DumpRenderTree bindings.
586
587         Some cleanup of the TestRunners, using member initializers.
588
589         * DumpRenderTree/TestRunner.cpp:
590         (TestRunner::TestRunner):
591         (setRenderTreeDumpOptionsCallback):
592         (TestRunner::staticFunctions):
593         (TestRunner::setRenderTreeDumpOptions):
594         * DumpRenderTree/TestRunner.h:
595         (TestRunner::renderTreeDumpOptions const):
596         * DumpRenderTree/mac/DumpRenderTree.mm:
597         (dump):
598         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
600         (WTR::InjectedBundlePage::dump):
601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
602         (WTR::TestRunner::TestRunner):
603         (WTR::TestRunner::setRenderTreeDumpOptions):
604         * WebKitTestRunner/InjectedBundle/TestRunner.h:
605         (WTR::TestRunner::renderTreeDumpOptions const):
606
607 2019-04-24  Alex Christensen  <achristensen@webkit.org>
608
609         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
610         https://bugs.webkit.org/show_bug.cgi?id=197078
611         <rdar://problem/49564348>
612
613         Reviewed by Geoff Garen.
614
615         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
616         (TEST_F):
617         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
618         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
619         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
620
621 2019-04-24  Alex Christensen  <achristensen@webkit.org>
622
623         Add unit test for r239322
624         https://bugs.webkit.org/show_bug.cgi?id=197236
625
626         Reviewed by Chris Dumez.
627
628         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
629         May as well add the test infrastructure which was needed before and will be needed in the future.
630
631         * TestWebKitAPI/TCPServer.cpp:
632         (TestWebKitAPI::TCPServer::TCPServer):
633         * TestWebKitAPI/TCPServer.h:
634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
635         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
636         (TestWebKitAPI::TEST):
637         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
638         (TestWebKitAPI::downloadAtRate):
639         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
640         (TEST):
641         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
642         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
643         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
644         (TestWebKitAPI::TEST):
645         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
646         (TEST):
647
648 2019-04-24  Chris Dumez  <cdumez@apple.com>
649
650         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
651         https://bugs.webkit.org/show_bug.cgi?id=197214
652         <rdar://problem/49237544>
653
654         Reviewed by Alex Christensen.
655
656         Extend API test coverage.
657
658         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
659         (TEST):
660
661 2019-04-24  Philippe Normand  <pnormand@igalia.com>
662
663         [Build][GStreamer] Update to 1.16.0
664         https://bugs.webkit.org/show_bug.cgi?id=197157
665
666         Reviewed by Xabier Rodriguez-Calvar.
667
668         The upstreamed patches were removed and a new one was added for a
669         regression detected in the scaletempo GStreamer element. The GNOME
670         Flatpak was migrated to 3.32 and I switched a few modules to Meson
671         on the way, as it is the preferred build system now in GStreamer
672         1.16.
673
674         * flatpak/files/httpd-autogen.sh:
675         * flatpak/flatpakutils.py:
676         (FlatpakPackage.install):
677         (WebkitFlatpak.run_in_sandbox):
678         * flatpak/org.webkit.CommonModules.yaml:
679         * flatpak/org.webkit.WebKit.yaml:
680         * gstreamer/jhbuild.modules:
681         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
682         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
683         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
684         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
685         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
686         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
687         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
688         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
689         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
690         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
691         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
692         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
693         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
694         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
695         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
696         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
697         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
698         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
699         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
700         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
701         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
702         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
703
704 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
705
706         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
707         https://bugs.webkit.org/show_bug.cgi?id=197156
708
709         Reviewed by Michael Catanzaro.
710
711         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
712         support was added.
713
714         * MiniBrowser/gtk/BrowserTab.c:
715         (browser_tab_set_background_color): Set the passed in color as web view background color.
716         * MiniBrowser/gtk/BrowserTab.h:
717         * MiniBrowser/gtk/BrowserWindow.c:
718         (browser_window_init): Initialize backgroundColor.
719         (browser_window_append_view): Call browser_tab_set_background_color().
720         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
721         are added.
722         * MiniBrowser/gtk/main.c:
723         (main): Call browser_window_set_background_color() before creating the tabs.
724
725 2019-04-23  John Wilander  <wilander@apple.com>
726
727         Move Ad Click Attribution from internal feature to experimental feature
728         https://bugs.webkit.org/show_bug.cgi?id=197218
729         <rdar://problem/47651691>
730
731         Reviewed by Brent Fulgham.
732
733         * DumpRenderTree/TestOptions.cpp:
734         (TestOptions::TestOptions):
735
736 2019-04-23  Andy Estes  <aestes@apple.com>
737
738         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
739         https://bugs.webkit.org/show_bug.cgi?id=196749
740         <rdar://problem/35773454>
741
742         Reviewed by Daniel Bates.
743
744         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
745
746         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
747         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
748         (-[QuickLookDelegate webView:didFinishNavigation:]):
749         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
750         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
751         (runTest):
752         (runTestDecideBeforeLoading):
753         (runTestDecideAfterLoading):
754         (TEST):
755
756 2019-04-23  John Wilander  <wilander@apple.com>
757
758         Remove Ad Click Attribution data when removing website data
759         https://bugs.webkit.org/show_bug.cgi?id=197215
760         <rdar://problem/47668988>
761
762         Reviewed by Chris Dumez.
763
764         This patch adds test infrastructure to delete Ad Click Attribution data
765         through WebsiteDataStore::removeData().
766
767         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
769         (WTR::TestRunner::clearAdClickAttribution):
770         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
772         * WebKitTestRunner/TestController.cpp:
773         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
774         * WebKitTestRunner/TestController.h:
775         * WebKitTestRunner/TestInvocation.cpp:
776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
777
778 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
779
780         webkitpy: Kill unresponsive worker processes
781         https://bugs.webkit.org/show_bug.cgi?id=197205
782         <rdar://problem/50104388>
783
784         Reviewed by Lucas Forschler.
785
786         * Scripts/webkitpy/common/message_pool.py:
787         (_MessagePool.__init__): Add close timeout.
788         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
789
790 2019-04-23  Alex Christensen  <achristensen@webkit.org>
791
792         Add unit tests for WKWebView.serverTrust
793         https://bugs.webkit.org/show_bug.cgi?id=197202
794
795         Reviewed by Youenn Fablet
796
797         * TestWebKitAPI/TCPServer.cpp:
798         (TestWebKitAPI::deleter<BIO>::operator()):
799         (TestWebKitAPI::deleter<SSL>::operator()):
800         (TestWebKitAPI::deleter<X509>::operator()):
801         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
802         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
803         (TestWebKitAPI::TCPServer::TCPServer):
804         (TestWebKitAPI::TCPServer::listenForConnections):
805         * TestWebKitAPI/TCPServer.h:
806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
807         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
808         (TestWebKitAPI::TEST):
809         (verifyCertificateAndPublicKey):
810         (-[ServerTrustDelegate webView:didFinishNavigation:]):
811         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
812         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
813         (TestWebKitAPI::downloadAtRate):
814         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
815         (TEST):
816         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
817         (TEST):
818
819 2019-04-23  Commit Queue  <commit-queue@webkit.org>
820
821         Unreviewed, rolling out r244556.
822         https://bugs.webkit.org/show_bug.cgi?id=197212
823
824         Causing build failures on multiple builders (Requested by
825         ShawnRoberts on #webkit).
826
827         Reverted changeset:
828
829         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
830         https://bugs.webkit.org/show_bug.cgi?id=197171
831         https://trac.webkit.org/changeset/244556
832
833 2019-04-23  Alex Christensen  <achristensen@webkit.org>
834
835         Fix iOS build.
836         https://bugs.webkit.org/show_bug.cgi?id=195537
837
838         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
839         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
840         AdoptWK constructor is private now.  Use adoptWK instead.
841
842 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
843
844         Accessibility text search and selection API enhancements.
845         https://bugs.webkit.org/show_bug.cgi?id=197095
846         <rdar://problem/48181791>
847
848         Reviewed by Chris Fleizach.
849
850         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
851
852         * DumpRenderTree/AccessibilityTextMarker.h:
853         * DumpRenderTree/AccessibilityUIElement.cpp:
854         (searchTextWithCriteriaCallback):
855         (AccessibilityUIElement::getJSClass):
856         * DumpRenderTree/AccessibilityUIElement.h:
857         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
858         (convertVectorToObjectArray):
859         (convertNSArrayToVector):
860         (searchTextParameterizedAttributeForCriteria):
861         (AccessibilityUIElement::getLinkedUIElements):
862         (AccessibilityUIElement::getDocumentLinks):
863         (AccessibilityUIElement::getChildren):
864         (AccessibilityUIElement::getChildrenWithRange):
865         (AccessibilityUIElement::rowHeaders const):
866         (AccessibilityUIElement::columnHeaders const):
867         (AccessibilityUIElement::uiElementArrayAttributeValue const):
868         (AccessibilityUIElement::searchTextWithCriteria):
869         (AccessibilityUIElement::attributesOfColumnHeaders):
870         (AccessibilityUIElement::attributesOfRowHeaders):
871         (AccessibilityUIElement::attributesOfColumns):
872         (AccessibilityUIElement::attributesOfRows):
873         (AccessibilityUIElement::attributesOfVisibleCells):
874         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
875         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
876         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
877         (WTR::convertVectorToObjectArray):
878         (WTR::convertNSArrayToVector):
879         (WTR::searchTextParameterizedAttributeForCriteria):
880         (WTR::AccessibilityUIElement::getLinkedUIElements):
881         (WTR::AccessibilityUIElement::getDocumentLinks):
882         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
883         (WTR::AccessibilityUIElement::getChildren):
884         (WTR::AccessibilityUIElement::getChildrenWithRange):
885         (WTR::AccessibilityUIElement::rowHeaders const):
886         (WTR::AccessibilityUIElement::columnHeaders const):
887         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
888         (WTR::AccessibilityUIElement::searchTextWithCriteria):
889         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
890         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
891         (WTR::AccessibilityUIElement::attributesOfColumns):
892         (WTR::AccessibilityUIElement::attributesOfRows):
893         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
894         (WTR::convertElementsToObjectArray): Deleted.
895
896 2019-04-23  Guy Lewin  <guy@lewin.co.il>
897
898         Multiple File Input Icon Set Regardless of File List
899         https://bugs.webkit.org/show_bug.cgi?id=195537
900
901         Reviewed by Alexey Proskuryakov.
902
903         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
904         display string in iOS file inputs
905
906         * DumpRenderTree/TestRunner.cpp:
907         (SetOpenPanelFilesMediaIconCallback):
908         (TestRunner::staticFunctions):
909         (TestRunner::setOpenPanelFilesMediaIcon):
910         * DumpRenderTree/TestRunner.h:
911         (TestRunner::openPanelFilesMediaIcon const):
912         * DumpRenderTree/mac/UIDelegate.mm:
913         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
916         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
917         * WebKitTestRunner/InjectedBundle/TestRunner.h:
918         * WebKitTestRunner/TestController.cpp:
919         (WTR::runOpenPanel):
920         (WTR::TestController::resetStateToConsistentValues):
921         * WebKitTestRunner/TestController.h:
922         (WTR::TestController::openPanelFileURLsMediaIcon const):
923         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
924         * WebKitTestRunner/TestInvocation.cpp:
925         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
926
927 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
928
929         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
930         https://bugs.webkit.org/show_bug.cgi?id=197171
931         <rdar://problem/47454979>
932
933         Reviewed by Youenn Fablet.
934
935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
936         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
937         (TestWebKitAPI::TEST):
938
939 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-build] Add unit tests for UnApplyPatchIfRequired
942         https://bugs.webkit.org/show_bug.cgi?id=197197
943
944         Reviewed by Lucas Forschler.
945
946         * BuildSlaveSupport/ews-build/steps_unittest.py:
947         (TestUnApplyPatchIfRequired):
948         (TestUnApplyPatchIfRequired.test_success):
949         (TestUnApplyPatchIfRequired.test_failure):
950         (TestUnApplyPatchIfRequired.test_skip):
951
952 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
953
954         [ews-build] Add unit tests for CleanWorkingDirectory
955         https://bugs.webkit.org/show_bug.cgi?id=197195
956
957         Reviewed by Lucas Forschler.
958
959         * BuildSlaveSupport/ews-build/steps_unittest.py:
960         (TestCleanWorkingDirectory):
961         (TestCleanWorkingDirectory.test_success):
962         (TestCleanWorkingDirectory.test_failure):
963
964 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
965
966         [ews-build] Use explicit imports instead of wildcard imports
967         https://bugs.webkit.org/show_bug.cgi?id=197194
968
969         Reviewed by Lucas Forschler.
970
971         * BuildSlaveSupport/ews-build/factories.py:
972         * BuildSlaveSupport/ews-build/loadConfig.py:
973         * BuildSlaveSupport/ews-build/steps_unittest.py:
974
975 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews-build] Add unit tests for DownloadBuiltProduct
978         https://bugs.webkit.org/show_bug.cgi?id=197193
979
980         Reviewed by Lucas Forschler.
981
982         * BuildSlaveSupport/ews-build/steps_unittest.py:
983         (TestDownloadBuiltProduct):
984         (TestDownloadBuiltProduct.setUp):
985         (TestDownloadBuiltProduct.tearDown):
986         (TestDownloadBuiltProduct.test_success):
987         (TestDownloadBuiltProduct.test_failure):
988
989 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
990
991         [ews-app] Exception while loading status-bubble when no build step has started
992         https://bugs.webkit.org/show_bug.cgi?id=196676
993
994         Reviewed by Lucas Forschler.
995
996         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
997         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
998
999 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1000
1001         [PlayStation] Support running of JSC tests on remote playstation devices
1002         https://bugs.webkit.org/show_bug.cgi?id=197170
1003
1004         Reviewed by Ross Kirsling.
1005
1006         Script changes
1007
1008         * Scripts/run-javascriptcore-tests:
1009         (runJSCStressTests): Pass arguments for playstation to
1010         run-jsc-stress-tests
1011         * Scripts/run-jsc-stress-tests:
1012         Handle $hostOS=="playstation" for determineArchitecture, turning
1013         off $isFTLPlatform and runProfiler and defaulting test writer.
1014         * Scripts/webkitdirs.pm:
1015         (jscPath): PlayStation WebKit executables have .elf extension
1016         (executableProductDir): PlayStation builds on Windows hosts but
1017         uses bin directory rather than bin64/bin32 for executable output
1018         location.
1019         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1020
1021 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1022
1023         [CMake][Win] Use target oriented design for WebKit
1024         https://bugs.webkit.org/show_bug.cgi?id=197173
1025
1026         Reviewed by Alex Christensen.
1027
1028         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1029         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1030
1031 2019-04-23  Chris Dumez  <cdumez@apple.com>
1032
1033         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1034         https://bugs.webkit.org/show_bug.cgi?id=197097
1035         <rdar://problem/50048318>
1036
1037         Reviewed by Alex Christensen.
1038
1039         Add API test coverage.
1040
1041         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1042         (-[PSONScheme webView:startURLSchemeTask:]):
1043
1044 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1045
1046         [ATK] Implement AtkComponentIface scroll_to methods
1047         https://bugs.webkit.org/show_bug.cgi?id=196856
1048
1049         Reviewed by Michael Catanzaro.
1050
1051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1052         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1053         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1054         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1055
1056 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1057
1058         [ews-build] Improve summary for UploadBuiltProduct step
1059         https://bugs.webkit.org/show_bug.cgi?id=197182
1060
1061         Reviewed by Lucas Forschler.
1062
1063         * BuildSlaveSupport/ews-build/steps.py:
1064         (UploadBuiltProduct): Added descriptionDone.
1065         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1066         * BuildSlaveSupport/ews-build/steps_unittest.py:
1067         (TestUploadBuiltProduct.test_success): Updated unit-test.
1068         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1069
1070 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1071
1072         [ews-build] Trigger queues only after uploading the archive
1073         https://bugs.webkit.org/show_bug.cgi?id=197180
1074
1075         Reviewed by Lucas Forschler.
1076
1077         * BuildSlaveSupport/ews-build/factories.py:
1078         (Factory.__init__):
1079         (BuildFactory.__init__): Remove trigger step from factories.
1080         (BuildFactory.propertiesToPassToTriggers): Deleted.
1081         * BuildSlaveSupport/ews-build/steps.py:
1082         (ConfigureBuild.__init__): Confiure triggers property.
1083         (Trigger): Step to trigger other queues.
1084         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1085         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1086
1087 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1088
1089         Deprecate WKContextCreateWithInjectedBundlePath
1090         https://bugs.webkit.org/show_bug.cgi?id=197169
1091
1092         Reviewed by Youenn Fablet.
1093
1094         * TestWebKitAPI/PlatformUtilities.cpp:
1095         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1096         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1097
1098 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1099
1100         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1101         https://bugs.webkit.org/show_bug.cgi?id=197093
1102         <rdar://problem/49708268>
1103
1104         Reviewed by Chris Dumez.
1105
1106         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1107         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1108         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1109         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1110         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1111
1112         * TestWebKitAPI/TCPServer.cpp:
1113         (TestWebKitAPI::TCPServer::TCPServer):
1114         (TestWebKitAPI::TCPServer::~TCPServer):
1115         (TestWebKitAPI::TCPServer::socketBindListen):
1116         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1117         * TestWebKitAPI/TCPServer.h:
1118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1119         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1120         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1121         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1122         (respondWithChallengeThenOK):
1123         (TestWebKitAPI::TEST):
1124         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1125         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1126         (TEST):
1127
1128 2019-04-22  Chris Dumez  <cdumez@apple.com>
1129
1130         Delayed WebProcessLaunch may break the _relatedWebView SPI
1131         https://bugs.webkit.org/show_bug.cgi?id=197160
1132
1133         Reviewed by Alex Christensen.
1134
1135         Add API test coverage.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1138
1139 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1140
1141         Use curl to download packages for webkitpy autoinstaller
1142         https://bugs.webkit.org/show_bug.cgi?id=197164
1143
1144         Reviewed by Darin Adler.
1145
1146         * Scripts/webkitpy/common/system/autoinstall.py:
1147         (AutoInstaller._download): Use curl(1) to download packages necessary for
1148         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1149         errors which are not present when using curl(1).
1150
1151 2019-04-22  Chris Dumez  <cdumez@apple.com>
1152
1153         Unreviewed, rolling out r244502.
1154
1155         Caused crashes on the bots
1156
1157         Reverted changeset:
1158
1159         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1160         https://bugs.webkit.org/show_bug.cgi?id=197160
1161         https://trac.webkit.org/changeset/244502
1162
1163 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1164
1165         Unreviewed, rolling out r244437.
1166
1167         Still breaks internal tests.
1168
1169         Reverted changeset:
1170
1171         "InjectedBundle parameters often need initialization function
1172         called before unarchiving"
1173         https://bugs.webkit.org/show_bug.cgi?id=189709
1174         https://trac.webkit.org/changeset/244437
1175
1176 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1177
1178         [ews-build] Use singular verb in failure description in case of single api test failure
1179         https://bugs.webkit.org/show_bug.cgi?id=197013
1180
1181         Reviewed by Lucas Forschler.
1182
1183         * BuildSlaveSupport/ews-build/steps.py:
1184         (AnalyzeAPITestsResults.analyzeResults):
1185
1186 2019-04-22  Chris Dumez  <cdumez@apple.com>
1187
1188         Delayed WebProcessLaunch may break the _relatedWebView SPI
1189         https://bugs.webkit.org/show_bug.cgi?id=197160
1190
1191         Reviewed by Alex Christensen.
1192
1193         Add API test coverage.
1194
1195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1196
1197 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1198
1199         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1200         https://bugs.webkit.org/show_bug.cgi?id=194630
1201
1202         Reviewed by Michael Catanzaro.
1203
1204         Return early from getAttributeSet() is passed in accessible is nullptr.
1205
1206         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1207
1208 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1209
1210         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1211         https://bugs.webkit.org/show_bug.cgi?id=197145
1212         <rdar://problem/50078170>
1213
1214         Reviewed by Darin Adler.
1215
1216         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1217         focus, or showing the font manager.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1220         (TestWebKitAPI::TEST):
1221         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1222         (TEST):
1223         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1224         (TestWebKitAPI::TEST):
1225
1226 2019-04-21  Brian Burg  <bburg@apple.com>
1227
1228         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1229         https://bugs.webkit.org/show_bug.cgi?id=197125
1230         <rdar://problem/50061468>
1231
1232         Reviewed by Darin Adler.
1233
1234         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1235         using this class rather than making our own ./wpt serve invocation.
1236
1237         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1238         (WebDriverW3CWebServer):
1239         (WebDriverW3CWebServer.document_root): Expose this to clients.
1240         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1241
1242         (WebDriverW3CWebServer.__enter__):
1243         (WebDriverW3CWebServer.__exit__):
1244         Make it possible to use the web server with a 'with' statement.
1245
1246 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1247
1248         [CMake][Win] Use target oriented design for WebKitLegacy
1249         https://bugs.webkit.org/show_bug.cgi?id=197112
1250
1251         Reviewed by Konstantin Tokarev.
1252
1253         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1254
1255         * DumpRenderTree/CMakeLists.txt:
1256         * DumpRenderTree/PlatformWin.cmake:
1257         * DumpRenderTree/win/EventSender.cpp:
1258
1259 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1260
1261         Update text for old EWS submit button
1262         https://bugs.webkit.org/show_bug.cgi?id=197140
1263
1264         Reviewed by Alexey Proskuryakov.
1265
1266         * QueueStatusServer/templates/statusbubble.html:
1267
1268 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1269
1270         [ews-app] New EWS should poll bugzilla more frequently
1271         https://bugs.webkit.org/show_bug.cgi?id=197138
1272
1273         Reviewed by Alexey Proskuryakov.
1274
1275         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1276         (FetchLoop.__init__):
1277
1278 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1279
1280         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1281         https://bugs.webkit.org/show_bug.cgi?id=197139
1282
1283         Reviewed by Alexey Proskuryakov.
1284
1285         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1286         * QueueStatusServer/templates/statusbubble.html:
1287
1288 2019-04-20  Chris Dumez  <cdumez@apple.com>
1289
1290         Unreviewed, fix iOS build with recent SDKs.
1291
1292         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1293
1294 2019-04-19  Keith Miller  <keith_miller@apple.com>
1295
1296         Add script to merge run_benchmark jsons
1297         https://bugs.webkit.org/show_bug.cgi?id=197107
1298
1299         Reviewed by Michael Saboff.
1300
1301         The script basically recursively decends through all json objects until it gets
1302         to an array or JSON primitive and concats or takes the first value, respectively.
1303
1304         This patch also adds +x bits to the compare-results script so it
1305         can be run directly from the command line. I had to add a new line so that svn
1306         will accept the change... yay svn!
1307
1308         * Scripts/compare-results:
1309         * Scripts/merge-result-jsons: Added.
1310         (readJSONFile):
1311         (deepAppend):
1312         (mergeJSONs):
1313         (main):
1314
1315 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1316
1317         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1318         https://bugs.webkit.org/show_bug.cgi?id=197079
1319
1320         Reviewed by Darin Adler.
1321
1322         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1323
1324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1325         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1326
1327 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1328
1329         Unreviewed, rolling out r244434.
1330         https://bugs.webkit.org/show_bug.cgi?id=197089
1331
1332         caused 1 API test failure (Requested by zalan on #webkit).
1333
1334         Reverted changeset:
1335
1336         "Regression (r244291): Broken API Test
1337         AutoLayoutRenderingProgressRelativeOrdering"
1338         https://bugs.webkit.org/show_bug.cgi?id=196948
1339         https://trac.webkit.org/changeset/244434
1340
1341 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1342
1343         Add new compatibility mode API on WKNavigation
1344         https://bugs.webkit.org/show_bug.cgi?id=197069
1345         <rdar://problem/50025800>
1346
1347         Reviewed by Tim Horton.
1348
1349         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1350
1351         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1352         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1353         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1354
1355 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1356
1357         [CMake] Make WebCore headers copies
1358         https://bugs.webkit.org/show_bug.cgi?id=182512
1359         <rdar://problem/37510435>
1360
1361         Reviewed by Alex Christensen.
1362
1363         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1364         ports.
1365
1366         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1367         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1368
1369         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1370         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1371         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1372         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1373         * TestWebKitAPI/CMakeLists.txt:
1374         * TestWebKitAPI/PlatformWin.cmake:
1375         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1376         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1377         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1378
1379 2019-04-18  Jer Noble  <jer.noble@apple.com>
1380
1381         Add support for parsing FairPlayStreaming PSSH boxes.
1382         https://bugs.webkit.org/show_bug.cgi?id=197064
1383
1384         Reviewed by Eric Carlson.
1385
1386         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1387         (TestWebKitAPI::TEST):
1388
1389 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1390
1391         InjectedBundle parameters often need initialization function called before unarchiving
1392         https://bugs.webkit.org/show_bug.cgi?id=189709
1393         <rdar://problem/44573653>
1394
1395         Reviewed by Ryosuke Niwa.
1396
1397         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1398         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1399
1400 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1401
1402         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1403         https://bugs.webkit.org/show_bug.cgi?id=196948
1404         <rdar://problem/49927131>
1405
1406         Reviewed by Tim Horton.
1407
1408         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1409         (TEST): 
1410         The expected order of incoming events is
1411         1. didInvalidateIntrinsicContentSize
1412         2. didFirstLayout
1413         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1414         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1415         (and remember, all we care about is ordering).
1416
1417 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1418
1419         Unreviewed, rolling out r244299.
1420
1421         Breaks internal tests.
1422
1423         Reverted changeset:
1424
1425         "InjectedBundle parameters often need initialization function
1426         called before unarchiving"
1427         https://bugs.webkit.org/show_bug.cgi?id=189709
1428         https://trac.webkit.org/changeset/244299
1429
1430 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1431
1432         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1433         https://bugs.webkit.org/show_bug.cgi?id=197053
1434
1435         Reviewed by Saam Barati.
1436
1437         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1438         (TestWebKitAPI::TEST):
1439
1440 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1441
1442         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1443         https://bugs.webkit.org/show_bug.cgi?id=197028
1444         <rdar://problem/49985290>
1445
1446         Reviewed by Wenson Hsieh.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1449         (TEST):
1450         Liberal application of waitForNextPresentationUpdate works around a race
1451         where if the page rapidly changes its viewport arguments (or an API client
1452         rapidly changes its viewport arguments), we'd get stuck thinking that the
1453         user had intentionally zoomed the page, and stop resetting the initial scale.
1454         This deserves a separate bug, but no need to keep the test failing while
1455         we think about it.
1456
1457 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1458
1459         REGRESSION (r241988): Switching tabs is slow
1460         https://bugs.webkit.org/show_bug.cgi?id=197037
1461         <rdar://problem/49951473>
1462
1463         Reviewed by Simon Fraser.
1464
1465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1466         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1467         (TEST):
1468         * TestWebKitAPI/cocoa/TestWKWebView.h:
1469         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1470         (-[TestWKWebView addToTestWindow]):
1471         Add a test that hangs without this fix.
1472
1473 2019-04-17  Truitt Savell  <tsavell@apple.com>
1474
1475         Unreviewed, rolling out r244400.
1476
1477         Caused testing to exit early with assertionon Debug WK2
1478
1479         Reverted changeset:
1480
1481         "UI↔Web deadlock when printing with a JavaScript alert
1482         visible"
1483         https://bugs.webkit.org/show_bug.cgi?id=196839
1484         https://trac.webkit.org/changeset/244400
1485
1486 2019-04-17  Brady Eidson  <beidson@apple.com>
1487
1488         Link clicks in PDFs shouldn't send referrer headers.
1489         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1490
1491         Reviewed by Tim Horton.
1492
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1495         (putPDFBytesCallback):
1496         (emptyReleaseInfoCallback):
1497         (createPDFWithLinkToURL):
1498         (TEST):
1499
1500 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1501
1502         UI↔Web deadlock when printing with a JavaScript alert visible
1503         https://bugs.webkit.org/show_bug.cgi?id=196839
1504         <rdar://problem/49157642>
1505
1506         Reviewed by Andy Estes.
1507
1508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1509         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1510         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1511         (TEST):
1512
1513 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1514
1515         WKRetainPtr's adoption constructor should be private
1516         https://bugs.webkit.org/show_bug.cgi?id=197019
1517
1518         Reviewed by Tim Horton.
1519
1520         * DumpRenderTree/mac/DumpRenderTree.mm:
1521         (dumpFramesAsText):
1522         * TestWebKitAPI/InjectedBundleController.cpp:
1523         (TestWebKitAPI::InjectedBundleController::initialize):
1524         * TestWebKitAPI/PlatformUtilities.cpp:
1525         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1526         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1527         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1528         (TestWebKitAPI::Util::toWK):
1529         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1530         (TestWebKitAPI::TEST):
1531         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1532         (TestWebKitAPI::TEST):
1533         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1534         (TestWebKitAPI::TEST):
1535         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1536         (TestWebKitAPI::TEST):
1537         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1538         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1539         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1542         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1543         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1544         (TestWebKitAPI::TEST):
1545         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1548         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1549         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1550         (TestWebKitAPI::TEST):
1551         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1552         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1553         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1556         (TestWebKitAPI::TEST):
1557         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1558         (TestWebKitAPI::TEST):
1559         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1560         (TestWebKitAPI::TEST):
1561         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1562         (TestWebKitAPI::TEST):
1563         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1564         (TestWebKitAPI::TEST):
1565         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1568         (TestWebKitAPI::TEST):
1569         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1570         (TestWebKitAPI::TEST):
1571         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1572         (TestWebKitAPI::TEST):
1573         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1574         (TestWebKitAPI::TEST):
1575         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1580         (TestWebKitAPI::TEST):
1581         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1584         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1585         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1590         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1591         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1592         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1595         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1596         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1597         (TestWebKitAPI::TEST):
1598         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1599         (TestWebKitAPI::TEST):
1600         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1601         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1602         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1603         (TestWebKitAPI::TEST):
1604         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1605         (TestWebKitAPI::loadAlternateHTMLString):
1606         (TestWebKitAPI::TEST):
1607         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1608         (TestWebKitAPI::TEST):
1609         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1610         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1611         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1612         (TestWebKitAPI::buildAndPerformTest):
1613         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1616         (TestWebKitAPI::TEST):
1617         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1618         (TestWebKitAPI::TEST):
1619         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1620         (TestWebKitAPI::TEST):
1621         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1626         (TestWebKitAPI::TEST):
1627         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1628         (TestWebKitAPI::TEST):
1629         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1630         (TestWebKitAPI::TEST):
1631         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1632         (TestWebKitAPI::TEST):
1633         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1634         (TestWebKitAPI::TEST):
1635         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1638         (TestWebKitAPI::TEST):
1639         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1640         (TestWebKitAPI::TEST):
1641         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1642         (TestWebKitAPI::TEST):
1643         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1644         (TestWebKitAPI::TEST):
1645         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1646         (TestWebKitAPI::TEST):
1647         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1648         (TestWebKitAPI::TEST):
1649         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1652         (TestWebKitAPI::TEST):
1653         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1654         (TestWebKitAPI::TEST):
1655         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1658         (TestWebKitAPI::TEST):
1659         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1660         (TestWebKitAPI::TEST):
1661         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1662         (TestWebKitAPI::TEST):
1663         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1666         (TestWebKitAPI::TEST):
1667         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1668         (TestWebKitAPI::TEST):
1669         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1670         (TestWebKitAPI::TEST):
1671         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1672         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1673         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1674         (TestWebKitAPI::TEST):
1675         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1676         (TestWebKitAPI::TEST):
1677         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1678         (TestWebKitAPI::TEST):
1679         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1680         (TestWebKitAPI::TEST):
1681         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1682         (TestWebKitAPI::TEST):
1683         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1684         (TestWebKitAPI::TEST):
1685         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1686         (TestWebKitAPI::TEST):
1687         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1690         (TestWebKitAPI::TEST):
1691         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1692         (TestWebKitAPI::TEST):
1693         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1694         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1695         (TEST):
1696         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1697         (TEST):
1698         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1699         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1700         (TEST):
1701         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1702         (TestWebKitAPI::TEST):
1703         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1704         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1705         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1706         (WTR::getMenuItemTitleCallback):
1707         (WTR::createMouseMessageBody):
1708         (WTR::EventSendingController::mouseDown):
1709         (WTR::EventSendingController::mouseUp):
1710         (WTR::EventSendingController::mouseMoveTo):
1711         (WTR::EventSendingController::mouseForceClick):
1712         (WTR::EventSendingController::startAndCancelMouseForceClick):
1713         (WTR::EventSendingController::mouseForceDown):
1714         (WTR::EventSendingController::mouseForceUp):
1715         (WTR::EventSendingController::mouseForceChanged):
1716         (WTR::EventSendingController::leapForward):
1717         (WTR::EventSendingController::scheduleAsynchronousClick):
1718         (WTR::createKeyDownMessageBody):
1719         (WTR::EventSendingController::keyDown):
1720         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1721         (WTR::EventSendingController::mouseScrollBy):
1722         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1723         (WTR::EventSendingController::continuousMouseScrollBy):
1724         (WTR::EventSendingController::addTouchPoint):
1725         (WTR::EventSendingController::updateTouchPoint):
1726         (WTR::EventSendingController::setTouchModifier):
1727         (WTR::EventSendingController::setTouchPointRadius):
1728         (WTR::EventSendingController::touchStart):
1729         (WTR::EventSendingController::touchMove):
1730         (WTR::EventSendingController::touchEnd):
1731         (WTR::EventSendingController::touchCancel):
1732         (WTR::EventSendingController::clearTouchPoints):
1733         (WTR::EventSendingController::releaseTouchPoint):
1734         (WTR::EventSendingController::cancelTouchPoint):
1735         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1736         (WTR::InjectedBundle::didCreatePage):
1737         (WTR::InjectedBundle::didReceiveMessage):
1738         (WTR::InjectedBundle::didReceiveMessageToPage):
1739         (WTR::InjectedBundle::booleanForKey):
1740         (WTR::InjectedBundle::done):
1741         (WTR::InjectedBundle::dumpToStdErr):
1742         (WTR::InjectedBundle::outputText):
1743         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1744         (WTR::InjectedBundle::postAddChromeInputField):
1745         (WTR::InjectedBundle::postRemoveChromeInputField):
1746         (WTR::InjectedBundle::postFocusWebView):
1747         (WTR::InjectedBundle::postSetBackingScaleFactor):
1748         (WTR::InjectedBundle::postSetWindowIsKey):
1749         (WTR::InjectedBundle::postSetViewSize):
1750         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1751         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1752         (WTR::InjectedBundle::setGeolocationPermission):
1753         (WTR::InjectedBundle::setMockGeolocationPosition):
1754         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1755         (WTR::InjectedBundle::isGeolocationProviderActive const):
1756         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1757         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1758         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1759         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1760         (WTR::InjectedBundle::setCustomPolicyDelegate):
1761         (WTR::InjectedBundle::setHidden):
1762         (WTR::InjectedBundle::setCacheModel):
1763         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1764         (WTR::InjectedBundle::processWorkQueue):
1765         (WTR::InjectedBundle::queueBackNavigation):
1766         (WTR::InjectedBundle::queueForwardNavigation):
1767         (WTR::InjectedBundle::queueLoad):
1768         (WTR::InjectedBundle::queueLoadHTMLString):
1769         (WTR::InjectedBundle::queueReload):
1770         (WTR::InjectedBundle::queueLoadingScript):
1771         (WTR::InjectedBundle::queueNonLoadingScript):
1772         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1773         (WTR::frameToStr):
1774         (WTR::InjectedBundlePage::InjectedBundlePage):
1775         (WTR::dumpFrameDescriptionSuitableForTestResult):
1776         (WTR::dumpFrameScrollPosition):
1777         (WTR::dumpDescendantFrameScrollPositions):
1778         (WTR::dumpFrameText):
1779         (WTR::dumpDescendantFramesText):
1780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1781         (WTR::TestRunner::shouldDumpPixels const):
1782         (WTR::TestRunner::setDumpPixels):
1783         (WTR::TestRunner::whatToDump const):
1784         (WTR::TestRunner::setWhatToDump):
1785         (WTR::TestRunner::setWaitUntilDone):
1786         (WTR::TestRunner::shouldWaitUntilDone const):
1787         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1788         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1789         (WTR::TestRunner::clearAllDatabases):
1790         (WTR::TestRunner::setIDBPerOriginQuota):
1791         (WTR::TestRunner::originsWithApplicationCache):
1792         (WTR::TestRunner::setCanOpenWindows):
1793         (WTR::TestRunner::setXSSAuditorEnabled):
1794         (WTR::TestRunner::setMediaDevicesEnabled):
1795         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1796         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1797         (WTR::TestRunner::setCustomUserAgent):
1798         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1799         (WTR::TestRunner::setModernMediaControlsEnabled):
1800         (WTR::TestRunner::setWebGL2Enabled):
1801         (WTR::TestRunner::setWritableStreamAPIEnabled):
1802         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1803         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1804         (WTR::TestRunner::setAllowsAnySSLCertificate):
1805         (WTR::TestRunner::setPluginsEnabled):
1806         (WTR::TestRunner::setValueForUser):
1807         (WTR::TestRunner::setAudioResult):
1808         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1809         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1810         (WTR::TestRunner::setAlwaysAcceptCookies):
1811         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1812         (WTR::TestRunner::isDoingMediaCapture const):
1813         (WTR::TestRunner::queueLoad):
1814         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1815         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1816         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1817         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1818         (WTR::TestRunner::setAuthenticationUsername):
1819         (WTR::TestRunner::setAuthenticationPassword):
1820         (WTR::TestRunner::secureEventInputIsEnabled const):
1821         (WTR::TestRunner::setBlockAllPlugins):
1822         (WTR::TestRunner::setPluginSupportedMode):
1823         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1824         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1825         (WTR::TestRunner::setNavigationGesturesEnabled):
1826         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1827         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1828         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1829         (WTR::TestRunner::terminateNetworkProcess):
1830         (WTR::TestRunner::terminateServiceWorkerProcess):
1831         (WTR::TestRunner::runUIScript):
1832         (WTR::TestRunner::setStatisticsDebugMode):
1833         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1834         (WTR::TestRunner::setStatisticsLastSeen):
1835         (WTR::TestRunner::setStatisticsPrevalentResource):
1836         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1837         (WTR::TestRunner::dumpResourceLoadStatistics):
1838         (WTR::TestRunner::isStatisticsPrevalentResource):
1839         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1840         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1841         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1842         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1843         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1844         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1845         (WTR::TestRunner::setStatisticsGrandfathered):
1846         (WTR::TestRunner::isStatisticsGrandfathered):
1847         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1848         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1849         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1850         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1851         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1852         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1853         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1854         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1855         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1856         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1857         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1858         (WTR::TestRunner::statisticsSubmitTelemetry):
1859         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1860         (WTR::TestRunner::setStatisticsIsRunningTest):
1861         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1862         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1863         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1864         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1865         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1866         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1867         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1868         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1869         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1870         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1871         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1872         (WTR::TestRunner::statisticsResetToConsistentState):
1873         (WTR::TestRunner::setStorageAccessAPIEnabled):
1874         (WTR::TestRunner::getAllStorageAccessEntries):
1875         (WTR::TestRunner::addMockMediaDevice):
1876         (WTR::TestRunner::clearMockMediaDevices):
1877         (WTR::TestRunner::removeMockMediaDevice):
1878         (WTR::TestRunner::resetMockMediaDevices):
1879         (WTR::TestRunner::connectMockGamepad):
1880         (WTR::TestRunner::disconnectMockGamepad):
1881         (WTR::TestRunner::setMockGamepadDetails):
1882         (WTR::TestRunner::setMockGamepadAxisValue):
1883         (WTR::TestRunner::setMockGamepadButtonValue):
1884         (WTR::TestRunner::removeAllSessionCredentials):
1885         (WTR::TestRunner::clearDOMCache):
1886         (WTR::TestRunner::clearDOMCaches):
1887         (WTR::TestRunner::hasDOMCache):
1888         (WTR::TestRunner::domCacheSize):
1889         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1890         (WTR::TestRunner::getApplicationManifestThen):
1891         (WTR::TestRunner::injectUserScript):
1892         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1893         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1894         (WTR::TestRunner::addTestKeyToKeychain):
1895         (WTR::TestRunner::cleanUpKeychain):
1896         (WTR::TestRunner::keyExistsInKeychain):
1897         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1898         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1899         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1900         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1901         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1902         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1903         * WebKitTestRunner/TestController.cpp:
1904         (WTR::TestController::initialize):
1905         (WTR::parseStringTestHeaderValueAsRelativePath):
1906         (WTR::updateTestOptionsFromTestHeader):
1907         (WTR::TestController::runTest):
1908         (WTR::TestController::didReceiveLiveDocumentsList):
1909         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1910         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1911         (WTR::TestController::didFinishNavigation):
1912         (WTR::TestController::didReceiveAuthenticationChallenge):
1913         * WebKitTestRunner/TestInvocation.cpp:
1914         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1915         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1916         (WTR::TestInvocation::uiScriptDidComplete):
1917         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1918         * WebKitTestRunner/WebNotificationProvider.cpp:
1919         (WTR::WebNotificationProvider::closeWebNotification):
1920         * WebKitTestRunner/WorkQueueManager.cpp:
1921         (WTR::ScriptItem::ScriptItem):
1922         (WTR::WorkQueueManager::queueLoad):
1923         (WTR::WorkQueueManager::queueLoadHTMLString):
1924
1925 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1926
1927         Add a comment to make my test from r244139 less mysterious.
1928         https://bugs.webkit.org/show_bug.cgi?id=196744
1929
1930         As suggested by Darin Adler.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1933         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1934
1935 2019-04-17  Chris Dumez  <cdumez@apple.com>
1936
1937         Remember device orientation permission for the duration of the browsing session
1938         https://bugs.webkit.org/show_bug.cgi?id=196992
1939         <rdar://problem/49946067>
1940
1941         Reviewed by Alex Christensen.
1942
1943         Add API test coverage.
1944
1945         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1946         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1947         (TEST):
1948
1949 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1950
1951         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1952         https://bugs.webkit.org/show_bug.cgi?id=196675
1953
1954         Reviewed by Lucas Forschler.
1955
1956         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1957         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1958
1959 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1960
1961         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1962         https://bugs.webkit.org/show_bug.cgi?id=196919
1963         <rdar://problem/41630459>
1964
1965         Reviewed by Tim Horton.
1966
1967         Add iOS support for several new testing hooks. See below for more detail.
1968
1969         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1970         (WTR::UIScriptController::isDismissingMenu const):
1971
1972         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1973         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1974         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1975
1976         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1977         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1978         (WTR::UIScriptController::isDismissingMenu const):
1979         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1980         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1981         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1982         (WTR::InjectedBundle::didReceiveMessageToPage):
1983         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1984         (WTR::TestRunner::setAllowedMenuActions):
1985
1986         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1987         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1988         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1989         against the name of the custom action.
1990
1991         (WTR::TestRunner::installCustomMenuAction):
1992
1993         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1994         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1995         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1996         triggered.
1997
1998         (WTR::TestRunner::performCustomMenuAction):
1999
2000         Invoked when the custom menu action is triggered.
2001
2002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::installCustomMenuAction):
2005         (WTR::TestController::setAllowedMenuActions):
2006         * WebKitTestRunner/TestController.h:
2007         * WebKitTestRunner/TestInvocation.cpp:
2008         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2009         (WTR::TestInvocation::performCustomMenuAction):
2010
2011         Add plumbing to call back into the injected bundle when performing the custom action.
2012
2013         * WebKitTestRunner/TestInvocation.h:
2014         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2015         (WTR::TestController::installCustomMenuAction):
2016         (WTR::TestController::setAllowedMenuActions):
2017         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2018         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2019         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2020         (-[TestRunnerWKWebView becomeFirstResponder]):
2021         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2022
2023         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2024         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2025         in the Mail app on iOS.
2026
2027         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2028         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2029         (-[TestRunnerWKWebView resetCustomMenuAction]):
2030         (-[TestRunnerWKWebView performCustomAction:]):
2031         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2032         (-[TestRunnerWKWebView _willHideMenu]):
2033         (-[TestRunnerWKWebView _didHideMenu]):
2034         * WebKitTestRunner/ios/TestControllerIOS.mm:
2035         (WTR::TestController::platformResetStateToConsistentValues):
2036
2037         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2038         if specified.
2039
2040         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2041         (WTR::UIScriptController::isDismissingMenu const):
2042
2043 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2044
2045         Allow sharing from imageSheet on an image document
2046         https://bugs.webkit.org/show_bug.cgi?id=196891
2047         <rdar://problem/25377386>
2048
2049         Reviewed by Tim Horton.
2050
2051         Test to make sure that the correct imageURL is extracted from an image element.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2054         (TestWebKitAPI::TEST):
2055
2056 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2057
2058         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2059         https://bugs.webkit.org/show_bug.cgi?id=196995
2060
2061         Reviewed by Brady Eidson.
2062
2063         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2064         (TEST):
2065
2066 2019-04-16  Chris Dumez  <cdumez@apple.com>
2067
2068         URL set by document.open() is not communicated to the UIProcess
2069         https://bugs.webkit.org/show_bug.cgi?id=196941
2070         <rdar://problem/49237544>
2071
2072         Reviewed by Geoff Garen.
2073
2074         Add API test coverage.
2075
2076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2077         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2078         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2079         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2080         (TEST):
2081
2082 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2083
2084         Unreviewed, rolling out r244321.
2085         https://bugs.webkit.org/show_bug.cgi?id=196968
2086
2087         Causing all WK2 Debug builds to exit early after Assertion
2088         failures. (Requested by ShawnRoberts on #webkit).
2089
2090         Reverted changeset:
2091
2092         "URL set by document.open() is not communicated to the
2093         UIProcess"
2094         https://bugs.webkit.org/show_bug.cgi?id=196941
2095         https://trac.webkit.org/changeset/244321
2096
2097 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2098
2099         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2100         https://bugs.webkit.org/show_bug.cgi?id=196948
2101
2102         Reviewed by Zalan Bujtas.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2105         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2106
2107 2019-04-15  Chris Dumez  <cdumez@apple.com>
2108
2109         URL set by document.open() is not communicated to the UIProcess
2110         https://bugs.webkit.org/show_bug.cgi?id=196941
2111         <rdar://problem/49237544>
2112
2113         Reviewed by Geoffrey Garen.
2114
2115         Add API test coverage.
2116
2117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2118         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2119         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2120         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2121         (TEST):
2122
2123 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2124
2125         Using Tools/Scripts/clean-webkit should not install requests
2126         https://bugs.webkit.org/show_bug.cgi?id=196940
2127
2128         Reviewed by Lucas Forschler.
2129
2130         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2131         existing, depending on the path autoinstalled is run through.
2132         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2133         needed.
2134         (Port.configuration_for_upload):
2135         (Port.commits_for_upload):
2136
2137 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2138
2139         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2140         https://bugs.webkit.org/show_bug.cgi?id=196773
2141
2142         Reviewed by Jer Noble.
2143
2144         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2145         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2146         (TEST):
2147
2148 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2149
2150         ews-build should clearly indicate flaky test failures
2151         https://bugs.webkit.org/show_bug.cgi?id=196947
2152
2153         Reviewed by Lucas Forschler.
2154
2155         * BuildSlaveSupport/ews-build/steps.py:
2156         (AnalyzeAPITestsResults.analyzeResults):
2157
2158 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2159
2160         InjectedBundle parameters often need initialization function called before unarchiving
2161         https://bugs.webkit.org/show_bug.cgi?id=189709
2162         <rdar://problem/44573653>
2163
2164         Reviewed by Ryosuke Niwa.
2165
2166         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2167         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2168
2169 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2170
2171         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2172         https://bugs.webkit.org/show_bug.cgi?id=196681
2173
2174         Reviewed by Darin Adler.
2175
2176         Added tests.
2177
2178         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2179         (WTF_HashSet.RemoveIf):
2180         (WTF_HashSet.RemoveIfShrinkToBestSize):
2181
2182 2019-04-15  John Wilander  <wilander@apple.com>
2183
2184         Send delayed Ad Click Attribution conversion requests to the click source
2185         https://bugs.webkit.org/show_bug.cgi?id=196838
2186         <rdar://problem/47650157>
2187
2188         Reviewed by Chris Dumez and Youenn Fablet.
2189
2190         This patch adds test infrastructure to override the default behavior in
2191         WebKit::NetworkAdClickAttribution.
2192
2193         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2194         (TestWebKitAPI::TEST):
2195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2197         (WTR::TestRunner::dumpAdClickAttribution):
2198         (WTR::TestRunner::clearAdClickAttribution):
2199         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2200         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2201         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2202         * WebKitTestRunner/TestController.cpp:
2203         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2204         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2205         * WebKitTestRunner/TestController.h:
2206         * WebKitTestRunner/TestInvocation.cpp:
2207         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2208
2209 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews-app] status-bubble should display position in queue
2212         https://bugs.webkit.org/show_bug.cgi?id=196607
2213
2214         Reviewed by Lucas Forschler.
2215
2216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2217         (StatusBubble._build_bubble):
2218         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2219
2220 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-build] Do not run clean build by default on EWS builders
2223         https://bugs.webkit.org/show_bug.cgi?id=196897
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/ews-build/steps.py:
2228         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2229         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2230         untracked directories like WebKitBuild).
2231         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2232         untracked files/directories (like WebKitBuild).
2233
2234 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2235
2236         TestRunner::notifyDone() should be safely reentrant
2237         https://bugs.webkit.org/show_bug.cgi?id=196898
2238
2239         Reviewed by Darin Adler.
2240
2241         It is currently possible that TestRunner::notifyDone() will call itself, since
2242         notifyDone() will force a repaint, which can start executing JavaScript, which
2243         may call notifyDone() again. This can lead to test failures and flakiness.
2244         Fix this by setting the m_waitToDump flag before calling the dump() method.
2245
2246         * DumpRenderTree/mac/TestRunnerMac.mm:
2247         (TestRunner::notifyDone):
2248         (TestRunner::forceImmediateCompletion):
2249         * DumpRenderTree/win/TestRunnerWin.cpp:
2250         (TestRunner::notifyDone):
2251         (TestRunner::forceImmediateCompletion):
2252
2253 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2254
2255         [GTK][WPE] Add enable-media websetting
2256         https://bugs.webkit.org/show_bug.cgi?id=196863
2257
2258         Reviewed by Michael Catanzaro.
2259
2260         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2261         (testWebKitSettings): Add test for the enable-media web-setting.
2262
2263 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2264
2265         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2266         https://bugs.webkit.org/show_bug.cgi?id=196905
2267         <rdar://problem/49886096>
2268
2269         Reviewed by Tim Horton.
2270
2271         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2272         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2273         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2274         delay timer, we end up with this sequence of events in the problematic (failure) case:
2275
2276         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2277             ...IPC from UI to web process...
2278         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2279             ...IPC from web to UI process...
2280         (c) [UI]    Invoke completion handler for script #1
2281         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2282             ...IPC from UI to web process...
2283         (e) [Web]   Evaluate script #2 in the web process
2284         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2285
2286         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2287         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2288         #2 is run in step (e).
2289
2290         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2291         the UI process by waiting on a script message posted by the web process, after attachment updates are
2292         dispatched.
2293
2294         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2295         (TestWebKitAPI::TEST):
2296
2297 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2298
2299         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2300         https://bugs.webkit.org/show_bug.cgi?id=196909
2301
2302         Reviewed by Wenson Hsieh.
2303
2304         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2305         (TestWebKitAPI::TEST):
2306
2307 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2308
2309         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2310         https://bugs.webkit.org/show_bug.cgi?id=196880
2311
2312         Reviewed by Yusuke Suzuki.
2313
2314         Add a new function for bytecode cache tests that does not forceDiskCache
2315         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2316         test added in this patch, since the code is invalid and therefore won't be
2317         cached. It should also be useful for tests that evaluate dynamically
2318         generated code.
2319
2320         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2321         * Scripts/run-jsc-stress-tests:
2322
2323 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2324
2325         Update AudioSession route sharing policy
2326         https://bugs.webkit.org/show_bug.cgi?id=196776
2327         <rdar://problem/46501611>
2328
2329         Reviewed by Jer Noble.
2330
2331         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2332         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2333         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2334         (TestWebKitAPI::TEST):
2335
2336 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2337
2338         [iOS] Software keyboard is shown too frequently on some websites
2339         https://bugs.webkit.org/show_bug.cgi?id=195856
2340         <rdar://problem/49191395>
2341
2342         Reviewed by Darin Adler.
2343
2344         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2345
2346         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2347         (WTR::UIScriptController::setHardwareKeyboardAttached):
2348         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2349         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2350         (WTR::UIScriptController::setHardwareKeyboardAttached):
2351         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2352         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2353
2354         Additionally link against GraphicsServices in WebKitTestRunner.
2355
2356         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2357         (WTR::TestController::platformResetStateToConsistentValues):
2358         (WTR::UIScriptController::setHardwareKeyboardAttached):
2359
2360 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2361
2362         [GTK][WPE] Fix pacman install-dependencies packages
2363         https://bugs.webkit.org/show_bug.cgi?id=196817
2364
2365         Reviewed by Žan Doberšek.
2366         
2367         python3-setuptools is called python-setuptools
2368         ruby-highline is only available on AUR
2369         libv4l-devel is incorporated in v4l-utils
2370
2371         * gtk/install-dependencies:
2372         * wpe/install-dependencies:
2373
2374 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2375
2376         [GTK] REGRESSION(r243860): Many tests failing
2377         https://bugs.webkit.org/show_bug.cgi?id=196791
2378
2379         Reviewed by Joanmarie Diggs.
2380
2381         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2382         multiple documents and check that accessibility hierarchy is updated after a navigation.
2383
2384         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2385         (loadChangedCallback):
2386         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2387         (AccessibilityTest::AccessibilityTest):
2388         (AccessibilityTest::~AccessibilityTest):
2389         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2390         (AccessibilityTest::findTestServerApplication):
2391         (AccessibilityTest::findDocumentWeb):
2392         (AccessibilityTest::findRootObject):
2393         (AccessibilityTest::waitUntilChildrenRemoved):
2394         (AccessibilityTest::ensureProxy):
2395         (testAtspiBasicHierarchy):
2396         (beforeAll):
2397         (afterAll):
2398
2399 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2400
2401         [ews-build] Handle bug titles with unicode characters
2402         https://bugs.webkit.org/show_bug.cgi?id=196802
2403
2404         Reviewed by Dewei Zhu.
2405
2406         * BuildSlaveSupport/ews-build/steps.py:
2407         (ValidatePatch._is_bug_closed):
2408
2409 2019-04-11  Michael Saboff  <msaboff@apple.com>
2410
2411         Improve the Inline Cache Stats code
2412         https://bugs.webkit.org/show_bug.cgi?id=196836
2413
2414         Reviewed by Saam Barati.
2415
2416         Added a new script to consolidate and arrange the output of --useICStats option.
2417
2418         This script merges the output from every group into one large table and sorts it from most common to
2419         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2420         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2421         Put together, this is useful to see what property accesses are not getting cached.
2422
2423         * Scripts/ic-stats.py: Added.
2424         (ICStats):
2425         (ICStats.__init__):
2426         (ICStats.parse):
2427         (ICStats.dumpStats):
2428         (usage):
2429
2430 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2431
2432         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2433         https://bugs.webkit.org/show_bug.cgi?id=196809
2434         <rdar://49800762>
2435
2436         Reviewed by Brady Eidson.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2439         (TEST):
2440
2441 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2442
2443         requestAnimationFrame should execute before the next frame
2444         https://bugs.webkit.org/show_bug.cgi?id=177484
2445
2446         Reviewed by Simon Fraser.
2447
2448         Add trace points for the page RenderingUpdate.
2449
2450         * Tracing/SystemTracePoints.plist:
2451
2452 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2453
2454         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2455         https://bugs.webkit.org/show_bug.cgi?id=196760
2456
2457         Reviewed by Don Olmstead.
2458
2459         vswhere.exe has been bundled since Visual Studio 2017 version
2460         15.2. We shouldn't download vswhere.exe.
2461
2462         * Scripts/build-jsc: Do not call update-vswhere.py.
2463         * Scripts/build-webkit: Ditto.
2464         * Scripts/update-vswhere.py: Removed.
2465         * Scripts/webkitdirs.pm:
2466         (requireModulesForVSWhere): Deleted.
2467         (pickCurrentVisualStudioInstallation): Deleted.
2468         (visualStudioInstallDirVSWhere): Return the latest installed VS
2469         installation path by using the bundled vswhere.exe.
2470         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2471         (visualStudioInstallDirFallback): Removed.
2472
2473 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2476         https://bugs.webkit.org/show_bug.cgi?id=196780
2477
2478         Reviewed by Alexey Proskuryakov.
2479
2480         * BuildSlaveSupport/ews-build/steps.py:
2481         * BuildSlaveSupport/ews-build/steps_unittest.py:
2482
2483 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2484
2485         Add SPI WKNavigationResponse._downloadAttribute
2486         https://bugs.webkit.org/show_bug.cgi?id=196755
2487         <rdar://49587365>
2488
2489         Reviewed by Brady Eidson.
2490
2491         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2492         (-[NavigationResponseTestDelegate navigationResponse]):
2493         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2494         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2495         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2496         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2497         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2498         (readRequest):
2499         (writeResponse):
2500         (TEST):
2501
2502 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2503
2504         Add modern API for overriding the page's specified viewport configuration
2505         https://bugs.webkit.org/show_bug.cgi?id=167734
2506         <rdar://problem/30331795>
2507
2508         Reviewed by Simon Fraser.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2512
2513 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2514
2515         Add support for incremental bytecode cache updates
2516         https://bugs.webkit.org/show_bug.cgi?id=195000
2517
2518         Reviewed by Filip Pizlo.
2519
2520         Exit when the initial run to generate bytecode fails.
2521
2522         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2523
2524 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2525
2526         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2527         https://bugs.webkit.org/show_bug.cgi?id=196744
2528         <rdar://49415309>
2529
2530         Reviewed by Chris Dumez.
2531
2532         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2533         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2534
2535 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2536
2537         Add a way to opt into modern compatibility mode in layout tests
2538         https://bugs.webkit.org/show_bug.cgi?id=196770
2539         <rdar://problem/49777550>
2540
2541         Reviewed by Antoine Quint.
2542
2543         Add a new test option to enable modern compatibility mode in layout tests.
2544
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::updateTestOptionsFromTestHeader):
2547         * WebKitTestRunner/TestController.h:
2548         * WebKitTestRunner/TestOptions.h:
2549         (WTR::TestOptions::hasSameInitializationOptions const):
2550         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2551         (WTR::TestController::platformCreateWebView):
2552         (WTR::TestController::enableModernCompatibilityMode):
2553
2554 2019-04-10  Andy Estes  <aestes@apple.com>
2555
2556         Try to fix the 32-bit watchOS build.
2557
2558         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2559         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2560
2561 2019-04-10  Antoine Quint  <graouts@apple.com>
2562
2563         Enable Pointer Events on watchOS
2564         https://bugs.webkit.org/show_bug.cgi?id=196771
2565         <rdar://problem/49040909>
2566
2567         Reviewed by Dean Jackson.
2568
2569         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2570
2571 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2572
2573         Unreviewed. Fix WPE accessibility tests after r244059.
2574
2575         We are failing to load the injected bundle due to undefined symbol
2576         AccessibilityUIElement::replaceTextInRange().
2577
2578         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2579         (WTR::AccessibilityUIElement::replaceTextInRange):
2580
2581 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2582
2583         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2584         https://bugs.webkit.org/show_bug.cgi?id=196727
2585
2586         Reviewed by Fujii Hironori.
2587
2588         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2589         (WebKitBrowserWindow::create):
2590
2591 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2592
2593         [ews-build] Add unit tests for PrintConfiguration
2594         https://bugs.webkit.org/show_bug.cgi?id=196752
2595
2596         Reviewed by Dewei Zhu.
2597
2598         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2599
2600 2019-04-09  Keith Rollin  <krollin@apple.com>
2601
2602         Unreviewed build maintenance -- update .xcfilelists.
2603
2604         * DumpRenderTree/DerivedSources-input.xcfilelist:
2605         * DumpRenderTree/DerivedSources-output.xcfilelist:
2606
2607 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2608
2609         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2610         https://bugs.webkit.org/show_bug.cgi?id=196743
2611         <rdar://problem/43897551>
2612
2613         Reviewed by Tim Horton.
2614
2615         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2616         (TEST):
2617
2618 2019-04-09  Youenn Fablet  <youenn@apple.com>
2619
2620         Close service worker database on network process suspension
2621         https://bugs.webkit.org/show_bug.cgi?id=196623
2622         <rdar://problem/48930869>
2623
2624         Reviewed by Alex Christensen.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2627
2628 2019-04-09  Daniel Bates  <dabates@apple.com>
2629
2630         [iPad] Should open popover when the spacebar is pressed
2631         https://bugs.webkit.org/show_bug.cgi?id=196360
2632         <rdar://problem/49389129>
2633
2634         Reviewed by Brent Fulgham.
2635
2636         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2637
2638         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2639         (WTR::UIScriptController::isShowingPopover const): Added.
2640         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2641         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2642         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2643         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2644         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2645         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2646         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2647         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2648         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2649         (WTR::UIScriptController::isShowingPopover const): Added.
2650         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2651         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2652         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2653         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2654         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2655         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2656         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2657         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2658         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2659         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2660         (WTR::UIScriptController::isShowingPopover const): Added.
2661         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2662         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2663
2664 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2665
2666         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2667         https://bugs.webkit.org/show_bug.cgi?id=196665
2668         <rdar://45115669>
2669
2670         Reviewed by Geoff Garen.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2673         (goBack):
2674         (+[SimpleLookupContext sharedLookupContext]):
2675         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2676         (TEST):
2677         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2678         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2679
2680 2019-04-09  John Wilander  <wilander@apple.com>
2681
2682         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2683         https://bugs.webkit.org/show_bug.cgi?id=196558
2684         <rdar://problem/47650245>
2685
2686         Reviewed by Youenn Fablet.
2687
2688         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2689         (TestWebKitAPI::TEST):
2690             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2691
2692 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2693
2694         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2695         https://bugs.webkit.org/show_bug.cgi?id=196720
2696
2697         Reviewed by Konstantin Tokarev.
2698
2699         * TestWebKitAPI/PlatformMac.cmake:
2700
2701 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2702
2703         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2704         https://bugs.webkit.org/show_bug.cgi?id=196694
2705         <rdar://problem/48388734>
2706
2707         Rubber-stamped by Aakash Jain.
2708
2709         * Scripts/webkitpy/port/image_diff.py:
2710         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2711         * Scripts/webkitpy/port/server_process.py:
2712         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2713         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2714         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2715         * Scripts/webkitpy/port/server_process_mock.py:
2716         (MockServerProcess.has_available_stdout):
2717         * Scripts/webkitpy/port/server_process_unittest.py:
2718         (TestServerProcess.serial_test_basic):
2719
2720 2019-04-09  Jer Noble  <jer.noble@apple.com>
2721
2722         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2723         https://bugs.webkit.org/show_bug.cgi?id=196097
2724
2725         Reviewed by Eric Carlson.
2726
2727         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2728
2729         * DumpRenderTree/mac/DumpRenderTree.mm:
2730         (resetWebPreferencesToConsistentValues):
2731         * WebKitTestRunner/TestController.cpp:
2732         (WTR::TestController::resetPreferencesToConsistentValues):
2733
2734 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2735
2736         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2737         https://bugs.webkit.org/show_bug.cgi?id=196690
2738
2739         Reviewed by Michael Catanzaro.
2740
2741         * QueueStatusServer/config/queues.py:
2742         * Scripts/webkitpy/common/config/ews.json:
2743         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2744         (test_ews_name):
2745
2746 2019-04-09  Chris Dumez  <cdumez@apple.com>
2747
2748         Loads using loadHTMLString() cause flashing when process-swapping
2749         https://bugs.webkit.org/show_bug.cgi?id=196714
2750         <rdar://problem/49637354>
2751
2752         Reviewed by Antti Koivisto.
2753
2754         Add API test coverage.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2757
2758 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2759
2760         Unreviewed. Fix ATK accessibility tests after r244059.
2761
2762         We are failing to load the injected bundle due to undefined symbol
2763         AccessibilityUIElement::replaceTextInRange().
2764
2765         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2766         (WTR::AccessibilityUIElement::replaceTextInRange):
2767
2768 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2769
2770         AX: Support API: accessibilityReplaceRange:withText
2771         https://bugs.webkit.org/show_bug.cgi?id=196636
2772
2773         Unreviewed build fix for Windows port.
2774
2775         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2776         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2777
2778 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2779
2780         [CMake][WinCairo] Separate copied headers into different directories
2781         https://bugs.webkit.org/show_bug.cgi?id=196655
2782
2783         Reviewed by Michael Catanzaro.
2784
2785         * DumpRenderTree/CMakeLists.txt:
2786         * MiniBrowser/win/CMakeLists.txt:
2787         * TestWebKitAPI/CMakeLists.txt:
2788         * TestWebKitAPI/PlatformWin.cmake:
2789
2790 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2791
2792         Log stack-trace for run-webkit-tests when interrupted
2793         https://bugs.webkit.org/show_bug.cgi?id=176393
2794         <rdar://problem/34262310>
2795
2796         Reviewed by Lucas Forschler.
2797
2798         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2799         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2800         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2801         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2802         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2803         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2804         (main): Set handlers to log stack trace on interruption.
2805
2806 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2807
2808         AX: Support API: accessibilityReplaceRange:withText
2809         https://bugs.webkit.org/show_bug.cgi?id=196636
2810
2811         Unreviewed build fix for Windows port.
2812
2813         * DumpRenderTree/AccessibilityUIElement.cpp:
2814         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2815
2816 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2817
2818         [ews-build] Scripts using Buildbot API have CORS error
2819         https://bugs.webkit.org/show_bug.cgi?id=196709
2820
2821         Reviewed by Alexey Proskuryakov.
2822
2823         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2824
2825 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2826
2827         AX: Support API: accessibilityReplaceRange:withText
2828         https://bugs.webkit.org/show_bug.cgi?id=196636
2829
2830         Reviewed by Daniel Bates.
2831
2832         * DumpRenderTree/AccessibilityUIElement.cpp:
2833         (replaceTextInRangeCallback):
2834         (AccessibilityUIElement::replaceTextInRange):
2835         (AccessibilityUIElement::getJSClass):
2836         * DumpRenderTree/AccessibilityUIElement.h:
2837         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2838         (AccessibilityUIElement::replaceTextInRange):
2839         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2840         (AccessibilityUIElement::replaceTextInRange):
2841         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2842         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2843         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2844         (WTR::AccessibilityUIElement::replaceTextInRange):
2845         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2846         (WTR::AccessibilityUIElement::replaceTextInRange):
2847
2848 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2849
2850         [iOS] Do not allow starting selection drags when selection views are not visible
2851         https://bugs.webkit.org/show_bug.cgi?id=196686
2852         <rdar://problem/49399192>
2853
2854         Reviewed by Tim Horton.
2855
2856         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2857         also add some new API tests to cover scenarios where the web view is not first responder.
2858
2859         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2860         (TestWebKitAPI::TEST):
2861         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2862
2863         Add a switch to optionally make the web view first responder when starting the simulated drag.
2864
2865         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2866         (-[DragAndDropSimulator initWithWebView:]):
2867         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2868
2869 2019-04-08  Justin Fan  <justin_fan@apple.com>
2870
2871         [Web GPU] Fix Web GPU experimental feature on iOS
2872         https://bugs.webkit.org/show_bug.cgi?id=196632
2873
2874         Reviewed by Myles C. Maxfield.
2875
2876         Properly make Web GPU available on iOS 11+.
2877
2878         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2879
2880 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2881
2882         [ews-build] Do not upload archive when Compile Fails
2883         https://bugs.webkit.org/show_bug.cgi?id=196674
2884
2885         Reviewed by Alexey Proskuryakov.
2886
2887         * BuildSlaveSupport/ews-build/factories.py:
2888         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2889         * BuildSlaveSupport/ews-build/steps.py:
2890         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2891         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2892         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2893
2894 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2895
2896         Enable DFG on MIPS
2897         https://bugs.webkit.org/show_bug.cgi?id=196689
2898
2899         Reviewed by Žan Doberšek.
2900
2901         Since the bytecode change, we enabled the baseline JIT on mips in
2902         r240432, but DFG is still missing. With this change, all tests are
2903         passing on a ci20 board.
2904
2905         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2906
2907 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2908
2909         [Flatpak] Second run update-webkitwpe-flatpak fails
2910         https://bugs.webkit.org/show_bug.cgi?id=192702
2911
2912         Reviewed by Carlos Garcia Campos.
2913
2914         * flatpak/flatpakutils.py:
2915         (FlatpakObject.flatpak): Fix typo.
2916         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2917         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2918
2919 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2920
2921         [GTK][WPE] outlook.live.com displays old-fashioned UI
2922         https://bugs.webkit.org/show_bug.cgi?id=196642
2923
2924         Reviewed by Carlos Garcia Campos.
2925
2926         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2927         (TestWebKitAPI::TEST): New Mac platform quirk test.
2928
2929 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2930
2931         Unreviewed, rolling out r243956.
2932         https://bugs.webkit.org/show_bug.cgi?id=196688
2933
2934         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2935         by aakashjain on #webkit).
2936
2937         Reverted changeset:
2938
2939         "Clicking "Go Back" from a safe browsing warning from an
2940         iframe should navigate the WKWebView back to the previous
2941         page"
2942         https://bugs.webkit.org/show_bug.cgi?id=196665
2943         https://trac.webkit.org/changeset/243956
2944
2945 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2946
2947         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2948         https://bugs.webkit.org/show_bug.cgi?id=196669
2949
2950         Reviewed by Geoffrey Garen.
2951
2952         Added three new unit tests for WeakHashSet.
2953
2954         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2955         (WTF_WeakPtr.WeakHashSetConstObjects):
2956         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2957         (WTF_WeakPtr.WeakHashSetComputeSize):
2958
2959 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2960
2961         Hide next and previous form control buttons when WKWebView is editable
2962         https://bugs.webkit.org/show_bug.cgi?id=196672
2963         <rdar://problem/35625321>
2964
2965         Reviewed by Tim Horton.
2966
2967         Add a new API test.
2968
2969         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2970         (-[TestWKWebView lastTrailingBarButtonGroup]):
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/ios/UIKitSPI.h:
2973
2974 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2975
2976         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2977         https://bugs.webkit.org/show_bug.cgi?id=196077
2978         <rdar://problem/49108202>
2979
2980         Reviewed by Chris Dumez.
2981
2982         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2983         on new web view.
2984
2985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2986
2987 2019-04-05  Saam Barati  <sbarati@apple.com>
2988
2989         Make compare-results understand MotionMark
2990         https://bugs.webkit.org/show_bug.cgi?id=196666
2991
2992         Reviewed by Yusuke Suzuki.
2993
2994         * Scripts/compare-results:
2995         (PLT5Results):
2996         (detectMotionMark):
2997         (detectMotionMark1_1):
2998         (motionMarkResults):
2999         (motionMark1_1Results):
3000         (detectBenchmark):
3001         (biggerIsBetter):
3002         (main):
3003
3004 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3005
3006         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3007         https://bugs.webkit.org/show_bug.cgi?id=196665
3008         <rdar://45115669>
3009
3010         Reviewed by Geoff Garen.
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3013         (goBack):
3014         (+[SimpleLookupContext sharedLookupContext]):
3015         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3016         (TEST):
3017         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3018         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3019
3020 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3021
3022         [ews-build] Add configuration and architecture for windows builders
3023         https://bugs.webkit.org/show_bug.cgi?id=196660
3024
3025         Reviewed by Lucas Forschler.
3026
3027         * BuildSlaveSupport/ews-build/config.json:
3028
3029 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3030
3031         webkitpy: Don't run subsequent rounds if interrupted
3032         https://bugs.webkit.org/show_bug.cgi?id=196646
3033
3034         Reviewed by Aakash Jain.
3035
3036         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3037         (Manager.run): Bail out if interrupted.
3038
3039 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3040
3041         Test sessionStorage in PSON private browsing mode
3042         https://bugs.webkit.org/show_bug.cgi?id=196561
3043
3044         Reviewed by Alex Christensen.
3045
3046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3047
3048 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3049
3050         Unreviewed, rolling out r243833.
3051         https://bugs.webkit.org/show_bug.cgi?id=196645
3052
3053         This change breaks build of WPE and GTK ports (Requested by
3054         annulen on #webkit).
3055
3056         Reverted changeset:
3057
3058         "[CMake][WTF] Mirror XCode header directories"
3059         https://bugs.webkit.org/show_bug.cgi?id=191662
3060         https://trac.webkit.org/changeset/243833
3061
3062 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3065         https://bugs.webkit.org/show_bug.cgi?id=196635
3066
3067         Reviewed by Antti Koivisto.
3068         
3069         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3070         for a test to enable async frame scrolling via:
3071             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3072         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3073         
3074         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3075
3076         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3077         (WTR::InjectedBundle::beginTesting):
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::TestController::resetPreferencesToConsistentValues):
3080
3081 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3082
3083         Use a correct LC_RPATH when building with ASan
3084         https://bugs.webkit.org/show_bug.cgi?id=196576
3085
3086         Reviewed by David Kilzer.
3087
3088         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3089         so that ../Frameworks is checked. This is simpler and more reliable than updating
3090         each SPC service xcconfig.
3091
3092 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3093
3094         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3095         https://bugs.webkit.org/show_bug.cgi?id=196629
3096
3097         Reviewed by Lucas Forschler.
3098
3099         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3100
3101 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3102
3103         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3104         https://bugs.webkit.org/show_bug.cgi?id=196618
3105
3106         Reviewed by Lucas Forschler.
3107
3108         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3109         (StatusBubble): Added QUEUE_TRIGGERS.
3110         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3111         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3112         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3113         its parent(builder).
3114
3115 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3116
3117         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3118         https://bugs.webkit.org/show_bug.cgi?id=196625
3119
3120         Reviewed by Lucas Forschler.
3121
3122         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3123         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3124
3125 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3126
3127         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3128         https://bugs.webkit.org/show_bug.cgi?id=196630
3129
3130         Reviewed by Wenson Hsieh.
3131
3132         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3133
3134 2019-04-04  Youenn Fablet  <youenn@apple.com>
3135
3136         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3137         https://bugs.webkit.org/show_bug.cgi?id=196543
3138
3139         Reviewed by Alex Christensen.
3140
3141         * WebKitTestRunner/TestController.cpp:
3142         (WTR::TestController::generatePageConfiguration):
3143
3144 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3145
3146         [ews-app] Status bubble should not display skipped buildbot steps
3147         https://bugs.webkit.org/show_bug.cgi?id=196584
3148
3149         Reviewed by Lucas Forschler.
3150
3151         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3152
3153 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3154
3155         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3156         https://bugs.webkit.org/show_bug.cgi?id=196620
3157
3158         Reviewed by Lucas Forschler.
3159
3160         * BuildSlaveSupport/ews-app/ews/config.py:
3161
3162 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3163
3164         [Win] DumpRenderTreeWatchDog.py is not checked into source
3165         https://bugs.webkit.org/show_bug.cgi?id=196567
3166         <rdar://problem/49525901>
3167
3168         Reviewed by Lucas Forschler.
3169
3170         This script is used on Win EWS bots to terminate hanging DRT processes.
3171
3172         * EWSTools/dumprendertreewatchdog.py: Added.
3173
3174 2019-04-04  Chris Dumez  <cdumez@apple.com>
3175
3176         Unreviewed, roll out r243858 which made tests time out.
3177
3178         Disable new API tests on Windows instead.
3179
3180         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3181         (TestWebKitAPI::TEST):
3182
3183 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3184
3185         [ATK] Cleanup WebPageAccessibilityObjectAtk
3186         https://bugs.webkit.org/show_bug.cgi?id=196537
3187
3188         Reviewed by Michael Catanzaro.
3189
3190         Also consider files under atk directories as exceptions for GObject conventions.
3191
3192         * Scripts/webkitpy/style/checkers/cpp.py:
3193         (check_identifier_name_in_declaration):
3194
3195 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3196
3197         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3198         https://bugs.webkit.org/show_bug.cgi?id=196588
3199         <rdar://problem/49365787>
3200
3201         Unreviewed build fix for Windows port.
3202
3203         error C3861: 'kill': identifier not found
3204
3205         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3206         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3207
3208 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3209
3210         [ews-build] Cancel build and similar operations should have authentication
3211         https://bugs.webkit.org/show_bug.cgi?id=196520
3212
3213         Reviewed by Dewei Zhu.
3214
3215         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3216         environment variables.
3217
3218 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3219
3220         [ews-build] Do not trigger queues which are not in production yet
3221         https://bugs.webkit.org/show_bug.cgi?id=196581
3222
3223         Reviewed by Dewei Zhu.
3224
3225         * BuildSlaveSupport/ews-build/config.json:
3226
3227 2019-04-03  Chris Dumez  <cdumez@apple.com>
3228
3229         Unreviewed, fix typo in the name of API test added in r243848.
3230
3231         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3232         (TestWebKitAPI::TEST):
3233
3234 2019-04-03  Chris Dumez  <cdumez@apple.com>
3235
3236         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3237         https://bugs.webkit.org/show_bug.cgi?id=196588
3238         <rdar://problem/49365787>
3239
3240         Reviewed by Ryosuke Niwa.
3241
3242         Add API test coverage.
3243
3244         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3245         (TestWebKitAPI::nullJavaScriptCallback):
3246         (TestWebKitAPI::didCrashCheckFrames):
3247         (TestWebKitAPI::TEST):
3248
3249 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3250
3251         run-webkit-tests: Upload test results (new results database)
3252         https://bugs.webkit.org/show_bug.cgi?id=196577
3253         <rdar://problem/34841155>
3254
3255         Reviewed by Lucas Forschler.
3256
3257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3258         (Manager.run): Upload results after each device shard, since the configuration will be
3259         different for each device.
3260         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3261         uploaded to a results database.
3262         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3263         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3264
3265 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3266
3267         -apple-trailing-word is needed for browser detection
3268         https://bugs.webkit.org/show_bug.cgi?id=196575
3269
3270         Unreviewed.
3271
3272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3273
3274 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3275
3276         [CMake][WTF] Mirror XCode header directories
3277         https://bugs.webkit.org/show_bug.cgi?id=191662
3278
3279         Reviewed by Konstantin Tokarev.
3280
3281         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3282         builds.
3283
3284         * CMakeLists.txt:
3285         * DumpRenderTree/CMakeLists.txt:
3286         * DumpRenderTree/PlatformWin.cmake:
3287         * MiniBrowser/win/CMakeLists.txt:
3288         * TestWebKitAPI/CMakeLists.txt:
3289         * TestWebKitAPI/PlatformWin.cmake:
3290         * WebKitTestRunner/PlatformGTK.cmake:
3291         * WebKitTestRunner/PlatformWin.cmake:
3292
3293 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3294
3295         [ews-app] Status bubble should not display certain infrastructure status messages
3296         https://bugs.webkit.org/show_bug.cgi?id=196550
3297
3298         Reviewed by Lucas Forschler.
3299
3300         Do not display the steps which are un-needed for end-user. This information is still avaiable
3301         if the user click on the bubble and look at the Buildbot build.
3302         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3303         (StatusBubble._steps_messages):
3304         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3305
3306 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3307
3308         [ews-build] Use https for sending data to ews-app
3309         https://bugs.webkit.org/show_bug.cgi?id=196492
3310
3311         Reviewed by Lucas Forschler.
3312
3313         * BuildSlaveSupport/ews-build/events.py:
3314
3315 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3316
3317         Remove support for -apple-trailing-word
3318         https://bugs.webkit.org/show_bug.cgi?id=196525
3319
3320         Reviewed by Zalan Bujtas.
3321
3322         This CSS property is nonstandard and not used.
3323
3324         * Scripts/webkitperl/FeatureList.pm:
3325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3326
3327 2019-04-03  Youenn Fablet  <youenn@apple.com>
3328
3329         Add a test for DOMCache on multiple browsing in case of private browsing
3330         https://bugs.webkit.org/show_bug.cgi?id=196524
3331
3332         Reviewed by Alex Christensen.
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3335         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3336
3337 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3338
3339         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3340         https://bugs.webkit.org/show_bug.cgi?id=196540
3341
3342         Reviewed by Aakash Jain.
3343
3344         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3345
3346 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3347
3348         Add plumbing for a compatibility mode preference in WebKit
3349         https://bugs.webkit.org/show_bug.cgi?id=196005
3350
3351         Reviewed by Tim Horton.
3352
3353         Add new API tests.
3354
3355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3356         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3357
3358 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3359
3360         [WPE][GTK] Update libsrtp dependency package for Debian
3361         https://bugs.webkit.org/show_bug.cgi?id=196528
3362
3363         Reviewed by Frédéric Wang.
3364
3365         * gtk/install-dependencies:
3366         * wpe/install-dependencies:
3367
3368 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3369
3370         [WK2] Add support for Window's beforeprint / afterprint events
3371         https://bugs.webkit.org/show_bug.cgi?id=196478
3372         <rdar://problem/49535124>
3373
3374         Unreviewed build fix for MSVC.
3375
3376         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3377
3378         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3379
3380         * WebKitTestRunner/TestController.cpp:
3381         (WTR::printFrame): Use int and float literals.
3382
3383 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-build] Reassign bots to queues
3386
3387         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3388
3389 2019-04-02  Chris Dumez  <cdumez@apple.com>
3390
3391         [WK2] Add support for Window's beforeprint / afterprint events
3392         https://bugs.webkit.org/show_bug.cgi?id=196478
3393
3394         Reviewed by Alex Christensen.
3395
3396         Add minimal implementation for printFrame in WebKitTestRunner.
3397
3398         * WebKitTestRunner/TestController.cpp:
3399         (WTR::printFrame):
3400         (WTR::TestController::createOtherPage):
3401         (WTR::TestController::createWebViewWithOptions):
3402
3403 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3406         https://bugs.webkit.org/show_bug.cgi?id=196491
3407
3408         Reviewed by Lucas Forschler.
3409
3410         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3411
3412 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3413
3414         [ews-build] Configure buildbot try credentials in environment variables
3415         https://bugs.webkit.org/show_bug.cgi?id=196501
3416
3417         Reviewed by Lucas Forschler.
3418
3419         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3420         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3421         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3422
3423 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3424
3425         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3426         https://bugs.webkit.org/show_bug.cgi?id=196496
3427         <rdar://problem/49521634>
3428
3429         Reviewed by Chris Dumez.
3430
3431         Add new API tests (see WebKit ChangeLog for more detail).
3432
3433         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3434         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3435         (TEST):
3436
3437 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3438
3439         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3440         <https://webkit.org/b/196499>
3441
3442         Reviewed by Alexey Proskuryakov.
3443
3444         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3445         ENABLE_ADDRESS_SANITIZER.
3446
3447 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3448
3449         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3450         https://bugs.webkit.org/show_bug.cgi?id=182757
3451
3452         Reviewed by Don Olmstead.
3453
3454         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3455         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3456
3457 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3458
3459         run-api-tests: Upload test results
3460         https://bugs.webkit.org/show_bug.cgi?id=196323
3461         <rdar://problem/49356714>
3462
3463         Reviewed by Lucas Forschler.
3464
3465         * Scripts/webkitpy/api_tests/manager.py:
3466         (Manager):
3467         (Manager.run): Upload results to a results database.
3468         * Scripts/webkitpy/api_tests/run_api_tests.py:
3469         (parse_args): Add upload arguments.
3470         * Scripts/webkitpy/port/base.py:
3471         (Port):
3472         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3473         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3474         with commits from any other associated repositories.
3475         * Scripts/webkitpy/port/device.py:
3476         (Device):
3477         (Device.build_version): Access build_versoin of underlying platform device.
3478         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3479         (IOSSimulatorTest):
3480         (IOSSimulatorTest.test_configuration_for_upload):
3481         * Scripts/webkitpy/port/device_port.py:
3482         (DevicePort):
3483         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3484         the same as the machine uploading results.
3485         * Scripts/webkitpy/port/mac.py:
3486         (MacPort):
3487         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3488         * Scripts/webkitpy/port/mac_unittest.py:
3489         (MacTest):
3490         (MacTest.test_configuration_for_upload):
3491         * Scripts/webkitpy/xcode/simulated_device.py:
3492         (SimulatedDeviceManager._create_device_with_runtime):
3493         (SimulatedDevice.__init__): Create simulated device with a build_version.
3494         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3495         (test_existing_simulator):
3496
3497 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3498
3499         Remove extra newline characters (Follow-up fix to r243707)
3500
3501         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3502
3503 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3504
3505         [ews-app] Use API_KEY to accept results data
3506         https://bugs.webkit.org/show_bug.cgi?id=196461
3507
3508         Reviewed by Dewei Zhu.
3509
3510         * BuildSlaveSupport/ews-app/ews/views/results.py:
3511         (Results.post): Validate EWS_API_KEY before accepting any data.
3512         * BuildSlaveSupport/ews-build/events.py:
3513         (Events.sendData): Send EWS_API_KEY if available along with event data.
3514
3515 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3516
3517         Unable to copy and paste a PDF from Notes into Mail compose body
3518         https://bugs.webkit.org/show_bug.cgi?id=196442
3519         <rdar://problem/48573098>
3520
3521         Reviewed by Tim Horton.
3522
3523         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3524         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3525         to be specified on the item providers.
3526
3527         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3528         (TestWebKitAPI::mapItemForTesting):
3529         (TestWebKitAPI::contactItemForTesting):
3530
3531 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3532
3533         Make UIWKDocumentContext rects per-character instead of per-word
3534         https://bugs.webkit.org/show_bug.cgi?id=196459
3535
3536         Reviewed by Wenson Hsieh.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3539         (TEST):
3540         Adjust test results due to switching to per-character rects.
3541
3542 2019-04-01  Chris Dumez  <cdumez@apple.com>
3543
3544         UIProcess crash when a prewarmed process is terminated
3545         https://bugs.webkit.org/show_bug.cgi?id=196451
3546         <rdar://problem/49245471>
3547
3548         Reviewed by Geoffrey Garen.
3549
3550         Add API test coverage.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3553         (TEST):
3554
3555 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3556
3557         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3558         https://bugs.webkit.org/show_bug.cgi?id=196449
3559
3560         Reviewed by Lucas Forschler.
3561
3562         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3563         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3564         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3565         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3566
3567 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3568
3569         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3570         https://bugs.webkit.org/show_bug.cgi?id=196444
3571
3572         Reviewed by Lucas Forschler.
3573
3574         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3575
3576 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3577
3578         Add SPI to canonicalize NSURLs with WTF::URL
3579         https://bugs.webkit.org/show_bug.cgi?id=196415
3580         <rdar://problem/44980271>
3581
3582         Reviewed by Darin Adler.
3583
3584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3585         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3586         (TestWebKitAPI::TEST):
3587
3588 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3589
3590         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3591         https://bugs.webkit.org/show_bug.cgi?id=196441
3592
3593         Reviewed by Carlos Garcia Campos.
3594
3595         Don't cache the wpe_view_backend object that might not exist yet at the
3596         time of EventSenderProxy constructor invocation, but instead retrieve
3597         that object whenever it's required for event dispatching. This should
3598         avoid crashes in this constructor now that it's invoked before any
3599         PlatformWindow has been set up (as changed in r243496).
3600
3601         * WebKitTestRunner/EventSenderProxy.h:
3602         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3603         (WTR::viewBackend):
3604         (WTR::EventSenderProxy::EventSenderProxy):
3605         (WTR::EventSenderProxy::mouseDown):
3606         (WTR::EventSenderProxy::mouseUp):
3607         (WTR::EventSenderProxy::mouseMoveTo):
3608         (WTR::EventSenderProxy::mouseScrollBy):
3609         (WTR::EventSenderProxy::keyDown):
3610         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3611
3612 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3613
3614         [Win][WebKit] MiniBrowser should support high DPI display
3615         https://bugs.webkit.org/show_bug.cgi?id=196391
3616
3617         Reviewed by Alex Christensen.
3618
3619         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3620         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3621         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3622         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3623
3624 2019-03-31  Sam Weinig  <weinig@apple.com>
3625
3626         Remove more i386 specific configurations
3627         https://bugs.webkit.org/show_bug.cgi?id=196430
3628
3629         Reviewed by Alexey Proskuryakov.
3630
3631         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3632         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3633
3634 2019-03-31  Andy Estes  <aestes@apple.com>
3635
3636         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3637         https://bugs.webkit.org/show_bug.cgi?id=196433
3638         <rdar://problem/49293305>
3639
3640         Reviewed by Tim Horton.
3641
3642         Enhanced API test coverage to include all navigation response policy decisions in both
3643         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3644
3645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3646         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3647         (TestWebKitAPI::TEST):
3648         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3649         (readFile):
3650         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3651         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3652         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3653         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3654         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3655         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3656         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3657         (-[QuickLookDelegate _downloadDidStart:]):
3658         (-[QuickLookDelegate _download:didReceiveResponse:]):
3659         (-[QuickLookDelegate _download:didReceiveData:]):
3660         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3661         (-[QuickLookDelegate _downloadDidFinish:]):
3662         (-[QuickLookDelegate _download:didFailWithError:]):
3663         (-[QuickLookDelegate _downloadDidCancel:]):
3664         (-[QuickLookDelegate verifyDownload]):
3665         (runTest):
3666         (runTestDecideBeforeLoading):
3667         (runTestDecideAfterLoading):
3668         (TEST):
3669         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3670         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3671         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3672         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3673         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3674         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3675         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3676         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3677         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3678         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3679         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3680         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3681         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3682         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3683
3684 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3685
3686         [CMake] add testdfg as target with build-jsc
3687         https://bugs.webkit.org/show_bug.cgi?id=196393
3688
3689         Reviewed by Saam Barati.
3690
3691         Added testdfg as one of the targets to build when
3692         using CMake.
3693
3694         * Scripts/build-jsc:
3695
3696 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3697
3698         Delete WebMetal implementation in favor of WebGPU
3699         https://bugs.webkit.org/show_bug.cgi?id=195418
3700
3701         Reviewed by Dean Jackson.
3702
3703         * DumpRenderTree/mac/DumpRenderTree.mm:
3704         (enableExperimentalFeatures):
3705         (resetWebPreferencesToConsistentValues):
3706         * Scripts/webkitperl/FeatureList.pm:
3707         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3709         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3710         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3711         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3712         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3713         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3714         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3715         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3716         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3717         (WTR::InjectedBundle::beginTesting):
3718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3719         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3720         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3721
3722 2019-03-29  Chris Dumez  <cdumez@apple.com>
3723
3724         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3725         https://bugs.webkit.org/show_bug.cgi?id=196405
3726         <rdar://problem/49428130>
3727
3728         Reviewed by Wenson Hsieh.
3729
3730         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3731         the popover presentation methods to be no-ops. Use this in the new test added in
3732         r243523 so that we do not swizzle those methods for all tests. This is needed because
3733         those WatchOS tests rely on the popover getting presented and interactive.
3734
3735         * WebKitTestRunner/TestController.cpp:
3736         (WTR::updateTestOptionsFromTestHeader):
3737         * WebKitTestRunner/TestController.h:
3738         * WebKitTestRunner/TestOptions.h:
3739         (WTR::TestOptions::hasSameInitializationOptions const):
3740         * WebKitTestRunner/ios/TestControllerIOS.mm:
3741         (WTR::TestController::platformInitialize):
3742         (WTR::TestController::platformResetStateToConsistentValues):
3743
3744 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3745
3746         [Curl] Add Server Trust Evaluation Support.
3747         https://bugs.webkit.org/show_bug.cgi?id=191646
3748
3749         Reviewed by Fujii Hironori.
3750
3751         Implemented MiniBrowser UI for asking if user trusts the server.
3752
3753         * MiniBrowser/win/Common.cpp:
3754         (askServerTrustEvaluation):
3755         (replaceString):
3756         * MiniBrowser/win/Common.h:
3757         * MiniBrowser/win/MiniBrowserLib.rc:
3758         * MiniBrowser/win/MiniBrowserLibResource.h:
3759         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3760         (createPEMString):
3761         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3762         (WebKitBrowserWindow::canTrustServerCertificate):
3763         * MiniBrowser/win/WebKitBrowserWindow.h:
3764
3765 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3766
3767         Implement ResizeObserver.
3768         https://bugs.webkit.org/show_bug.cgi?id=157743
3769
3770         Reviewed by Simon Fraser.
3771
3772         Support resizeObserverEnabled webPreferences.
3773
3774         * DumpRenderTree/TestOptions.cpp:
3775         (TestOptions::TestOptions):
3776         * DumpRenderTree/TestOptions.h:
3777         * DumpRenderTree/mac/DumpRenderTree.mm:
3778         (setWebPreferencesForTestOptions):
3779         * DumpRenderTree/win/DumpRenderTree.cpp:
3780         (enableExperimentalFeatures):
3781         * Scripts/webkitperl/FeatureList.pm:
3782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3783
3784 2019-03-28  John Wilander  <wilander@apple.com>
3785
3786         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3787         https://bugs.webkit.org/show_bug.cgi?id=196281
3788         <rdar://problem/48938748>
3789
3790         Reviewed by Alex Christensen.
3791
3792         This patch adds the function isStatisticsHasLocalStorage() to the
3793         TestRunner. With it, the page can query the WebsiteDataStore in the
3794         UI process to make sure that it sees LocalStorage.
3795
3796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3798         (WTR::TestRunner::isStatisticsHasLocalStorage):
3799         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3800         * WebKitTestRunner/TestController.cpp:
3801         (WTR::TestController::isStatisticsHasLocalStorage):
3802         * WebKitTestRunner/TestController.h:
3803         * WebKitTestRunner/TestInvocation.cpp:
3804         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3805
3806 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3807
3808         API::Data::createWithoutCopying should do a null check before calling CFRelease
3809         https://bugs.webkit.org/show_bug.cgi?id=196276
3810         <rdar://problem/48059859>
3811
3812         Reviewed by Alex Christensen.
3813
3814         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3815
3816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3817         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3818         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3819         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3820         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3821         (TestWebKitAPI::TEST):
3822
3823 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3824
3825         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3826         https://bugs.webkit.org/show_bug.cgi?id=186276
3827
3828         Reviewed by Carlos Garcia Campos.
3829
3830         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3831         (webViewLoadChanged):
3832         (testWebResourceGetDataError):
3833         (testWebResourceGetDataEmpty):
3834         (beforeAll):
3835         (webViewloadChanged): Deleted.
3836
3837 2019-03-27  Andy Estes  <aestes@apple.com>
3838
3839         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3840         https://bugs.webkit.org/show_bug.cgi?id=196317
3841
3842         Reviewed by Dan Bernstein.
3843
3844         package-root copies built products into a staging directory using ditto(1), which does not
3845         follow symbolic links as it traverses a directory. Now that the files in
3846         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3847         itself, these become broken links when ditto'd into the staging directory.
3848
3849         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3850
3851         * Scripts/package-root:
3852
3853 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3854
3855         [ews-app] Update display text of Submit for ews analysis
3856         https://bugs.webkit.org/show_bug.cgi?id=196309
3857
3858         Reviewed by Dewei Zhu.
3859
3860         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3861
3862 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3863
3864         run-webkit-tests should check for leaks in WebKit processes
3865         <https://webkit.org/b/193772>
3866         <rdar://problem/46526680>
3867
3868         Reviewed by Ryosuke Niwa.
3869
3870         This works by doing the following:
3871         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3872           The list of child processes are returned one per line:
3873           process.name: pid
3874         - Run the "#LIST CHILD PROCESSES" command just before the
3875           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3876           processes on the ServerProcess object.
3877         - When the `--leaks` switch is handled, run check_for_leaks() on
3878           each child process after the main test harness.
3879
3880         * DumpRenderTree/mac/DumpRenderTree.mm:
3881         (handleControlCommand):
3882         - Use strncmp() instead of strcmp().
3883         - Add support for handling "#LIST CHILD PROCESSES" command.
3884
3885         * Scripts/webkitpy/port/base.py:
3886         (Port.check_for_leaks):
3887         * Scripts/webkitpy/port/darwin.py:
3888         (DarwinPort.check_for_leaks):
3889         - Rename redundant 'process_pid' argument to 'process_id'.
3890
3891         * Scripts/webkitpy/port/driver.py:
3892         (Driver.do_post_tests_work):
3893         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3894           longer the only command this sends to WebKitTestRunner.
3895         - If the `--leaks` switch is present, send the
3896           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3897           result using Port.set_webkit_processes().
3898         (Driver._parse_child_processes_output):
3899         - Add helper method to parse list of child process names and
3900           process IDs returned from WebKitTestRunner.
3901
3902         * Scripts/webkitpy/port/ios_device.py:
3903         (IOSDevicePort.check_for_leaks):
3904         - Rename redundant 'process_pid' argument to 'process_id'.
3905
3906         * Scripts/webkitpy/port/leakdetector.py:
3907         (LeakDetector._parse_leaks_output):
3908         - Return early if there is no leaks_output.
3909         (LeakDetector.check_for_leaks):
3910         - Rename redundant 'process_pid' argument to 'process_id'.
3911
3912         * Scripts/webkitpy/port/server_process.py:
3913         (ServerProcess.__init__):
3914         (ServerProcess.child_processes):
3915         (ServerProcess.set_child_processes):
3916         - Add instance variable to Port to store list of child process
3917           names and process IDs returned from WebKitTestRunner.
3918         (ServerProcess._start):
3919         - Clear self._child_processes.
3920         (ServerProcess.stop):
3921         - If self._child_processes is set, call
3922           self._port.check_for_leaks() for each child process.
3923
3924         * Scripts/webkitpy/port/server_process_unittest.py:
3925         (TrivialMockPort.check_for_leaks):
3926         - Rename redundant 'process_pid' argument to 'process_id'.
3927
3928         * Scripts/webkitpy/port/simulator_process.py:
3929         (SimulatorProcess.stop):
3930         - If self._child_processes is set, call
3931           self._port.check_for_leaks() for each child process.
3932
3933         * Scripts/webkitpy/port/watch_device.py:
3934         (WatchDevicePort.check_for_leaks):
3935         - Rename redundant 'process_pid' argument to 'process_id'.
3936
3937         * WebKitTestRunner/TestController.cpp:
3938         (WTR::TestController::dumpResponse):
3939         - Extract method from findAndDumpWorldLeaks() so that it may be
3940           reused by findAndDumpWebKitProcessIdentifiers().
3941         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3942         - Add method to output process name and process ID of both the
3943           WebContent and Networking processes.
3944         (WTR::TestController::findAndDumpWorldLeaks):
3945         - Fix missing newline in output when there were no abandoned
3946           documents.
3947         - Call dumpResponse() for extracted code.
3948         (WTR::TestController::handleControlCommand):
3949         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3950         - Use strncmp() instead of strcmp().
3951         - Call findAndDumpWebKitProcessIdentifiers() when
3952           "#LIST CHILD PROCESSES" command is sent.
3953         * WebKitTestRunner/TestController.h:
3954         (WTR::TestController::dumpResponse):
3955         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3956         - Declare methods.
3957
3958 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3959
3960         Unreviewed. Add GLib API test cases after r243434.
3961
3962         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3963         (testWebViewActiveURI):
3964         (serverCallback):
3965         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3966         (sendRequestCallback):
3967
3968 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3969
3970         Geolocation request not complete when watch request was started in a different web process
3971         https://bugs.webkit.org/show_bug.cgi?id=195996
3972
3973         Reviewed by Alex Christensen.
3974
3975         Add a test case.
3976
3977         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3978         (TestWebKitAPI::runJavaScriptAlert):
3979         (TestWebKitAPI::TEST):
3980
3981 2019-03-26  Keith Rollin  <krollin@apple.com>
3982
3983         Update the way generate-xcfilelists returns strings from functions
3984         https://bugs.webkit.org/show_bug.cgi?id=195975
3985         <rdar://problem/49040807>
3986
3987         Reviewed by Dean Jackson.
3988
3989         There are places where generate-xcfilelists executes assignments with
3990         statements like:
3991
3992             FOO=$(some_function)
3993
3994         where "some_function" return a string by echoing it. E.g.
3995
3996             some_function()
3997             {
3998                 echo "Hello, World"
3999             }
4000
4001         This is a common idiom, but it has a problem if "some_function" needs
4002         to call "exit" in an attempt to halt the entire script right then and
4003         there. Since "some_function" is called inside of $(), it's being
4004         executed in a sub-shell. Calling exit in that sub-shell simply exits
4005         that shell; it doesn't not exit the outer shell in which the main part
4006         of the script is still running. As such, the main script keeps
4007         executing when the intent was for the script to halt.
4008
4009         The solution to this is to use a different idiom for returning
4010         strings. The one we now is to pass in the name of the variable to
4011         receive the string result:
4012
4013             some_function()
4014             {
4015                 variable_name=$1
4016                 eval $variable_name ="Hello, World"
4017             }
4018
4019         The call site now looks like
4020
4021             some_function FOO
4022
4023         Because there's no invocation of a sub-shell, some_function can now
4024         call "exit" if it wants to, and the entire script will exit at that
4025         point.
4026
4027         * Scripts/generate-xcfilelists:
4028
4029 2019-03-26  Chris Dumez  <cdumez@apple.com>
4030
4031         Add basic layout test coverage for File Picker on iOS
4032         https://bugs.webkit.org/show_bug.cgi?id=196265
4033
4034         Reviewed by Wenson Hsieh.
4035
4036         Add layout test infrastructure to test the file picker on iOS.
4037
4038         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4039         (WTR::UIScriptController::dismissFilePicker):
4040         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4041         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4042         (WTR::UIScriptController::dismissFilePicker):
4043         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4044         * WebKitTestRunner/TestController.cpp:
4045         (WTR::TestController::createWebViewWithOptions):
4046         (WTR::updateTestOptionsFromTestHeader):
4047         * WebKitTestRunner/TestOptions.h:
4048         (WTR::TestOptions::hasSameInitializationOptions const):
4049         * WebKitTestRunner/ios/TestControllerIOS.mm:
4050         (overridePresentViewController):
4051         (WTR::TestController::platformInitialize):
4052         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4053         (WTR::UIScriptController::dismissFilePicker):
4054
4055 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4056
4057         Implement async paste method on UIWKInteractionViewProtocol
4058         https://bugs.webkit.org/show_bug.cgi?id=196267
4059         <rdar://problem/49236346>
4060
4061         Reviewed by Tim Horton.
4062
4063         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4064         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4065         are now a part of all iOS 12 internal SDKs.
4066
4067         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4068
4069         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4070         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4071
4072         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4073         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4074         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4075         * TestWebKitAPI/ios/UIKitSPI.h:
4076
4077 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4078
4079         [ews-build] Use PostgreSQL for ews.webkit.org database
4080         https://bugs.webkit.org/show_bug.cgi?id=196270
4081
4082         Reviewed by Lucas Forschler.
4083
4084         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4085
4086 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4087
4088         [ews] Reset simctl states on reboot
4089         https://bugs.webkit.org/show_bug.cgi?id=196260
4090
4091         Rubber-stamped by Aakash Jain.
4092
4093         * EWSTools/start-queue-mac.sh:
4094
4095 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4096
4097         [ews-build] Use PostgreSQL for ews-build database
4098         https://bugs.webkit.org/show_bug.cgi?id=196229
4099
4100         Reviewed by Lucas Forschler.
4101
4102         * BuildSlaveSupport/ews-build/master.cfg:
4103
4104 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4105
4106         [ews-build] Get master_hostname dynamically in master.cfg
4107         https://bugs.webkit.org/show_bug.cgi?id=196255
4108
4109         Reviewed by Lucas Forschler.
4110
4111         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4112         send events data in test mode.
4113
4114 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4115
4116         [ews-app] Set db_constraint to False for Foreign Keys
4117         https://bugs.webkit.org/show_bug.cgi?id=196252
4118
4119         Reviewed by Lucas Forschler.
4120
4121         * BuildSlaveSupport/ews-app/ews/models/build.py:
4122         * BuildSlaveSupport/ews-app/ews/models/step.py:
4123
4124 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4125
4126         [ews-build] is_test_mode_enabled should default to True
4127         https://bugs.webkit.org/show_bug.cgi?id=196248
4128
4129         Reviewed by Lucas Forschler.
4130
4131         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4132
4133 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4134
4135         [ews-app] Add webkitperl to ENABLED_QUEUES
4136         https://bugs.webkit.org/show_bug.cgi?id=196253
4137
4138         Reviewed by Lucas Forschler.
4139
4140         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4141
4142 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4143
4144         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4145         https://bugs.webkit.org/show_bug.cgi?id=196211
4146         rdar://problem/49110552
4147
4148         Reviewed by Tim Horton.
4149
4150         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4151         Make sure that EventSenderProxy always exists when running tests. We used to create
4152         it when resetting before the first test, which is a bit too late.
4153
4154         * WebKitTestRunner/TestController.h:
4155         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4156         (WTR::TestController::platformCreateWebView):
4157         (WTR::TestController::platformCreateOtherPage):
4158         (WTR::TestController::finishCreatingPlatformWebView):
4159         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4160         (WTR::PlatformWebView::PlatformWebView):
4161         Moved some code that made NSWindow use NSEvent during web view creation. We may
4162         need to move more if some other case us found, but this is enough for now.
4163
4164 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4165
4166         Unreviewed. Fix typo in GLib geolocation API after r243285.
4167
4168         gelocation -> geolocation.
4169
4170         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4171         (testGeolocationManagerWatchPosition):
4172
4173 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4174
4175         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4176         https://bugs.webkit.org/show_bug.cgi?id=196213
4177
4178         Reviewed by Geoff Garen.
4179
4180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4181         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4182         (credentialWithIdentityAndKeychainPath):
4183         (-[ChallengeDelegate webView:didFinishNavigation:]):
4184         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4185         (TestWebKitAPI::TEST):
4186
4187 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4188
4189         Expected shouldn't assume its contained types are copyable
4190         https://bugs.webkit.org/show_bug.cgi?id=195986
4191
4192         Reviewed by JF Bastien.
4193
4194         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4195         (TestWebKitAPI::NonCopyable::operator== const):
4196         (TestWebKitAPI::NonCopyable::operator!= const):
4197         (TestWebKitAPI::TEST):
4198
4199 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4200
4201         Remove some now-unnecessary dynamic class lookup
4202         https://bugs.webkit.org/show_bug.cgi?id=196237
4203
4204         Reviewed by Simon Fraser.
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4207         (makeRequest):
4208         (TEST):
4209
4210 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4211
4212         Unreviewed, rolling out r243450.
4213
4214         AppleWin and WinCairo port builds get broken.
4215
4216         Reverted changeset:
4217
4218         "Add test for fix of #196095"
4219         https://bugs.webkit.org/show_bug.cgi?id=196097
4220         https://trac.webkit.org/changeset/243450
4221
4222 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4223
4224         Unreviewed, rolling out r243465.
4225         https://bugs.webkit.org/show_bug.cgi?id=196226
4226
4227         the test doesn't build (Requested by thorton on #webkit).
4228
4229         Reverted changeset:
4230
4231         "Do not terminate the NetworkProcess if a third party
4232         application sends a NSCredential with a SecIdentityRef"
4233         https://bugs.webkit.org/show_bug.cgi?id=196213
4234         https://trac.webkit.org/changeset/243465
4235
4236 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4237
4238         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4239         https://bugs.webkit.org/show_bug.cgi?id=196213
4240
4241         Reviewed by Geoff Garen.
4242
4243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4244         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4245         (credentialWithIdentityAndKeychainPath):
4246         (-[ChallengeDelegate webView:didFinishNavigation:]):
4247         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4248         (TestWebKitAPI::TEST):
4249
4250 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4251
4252         [ews-build] Gracefully handle missing patch_id in events
4253         https://bugs.webkit.org/show_bug.cgi?id=196216
4254
4255         Reviewed by Lucas Forschler.
4256
4257         * BuildSlaveSupport/ews-build/events.py:
4258
4259 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4260
4261         [ews-build] use lz4 compression for improving buildbot performance
4262         https://bugs.webkit.org/show_bug.cgi?id=196155
4263
4264         Reviewed by Lucas Forschler.
4265
4266         * BuildSlaveSupport/ews-build/master.cfg:
4267
4268 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4269
4270         Pull some API testing helper methods out of TestWKWebView
4271         https://bugs.webkit.org/show_bug.cgi?id=196212
4272
4273         Reviewed by Tim Horton.
4274
4275         Refactor some more API testing utility methods, so that they can be used in
4276         tests that do not use TestWKWebView.
4277
4278         * TestWebKitAPI/cocoa/TestWKWebView.h:
4279         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4280         (-[WKWebView loadTestPageNamed:]):
4281         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4282         (-[WKWebView synchronouslyLoadHTMLString:]):
4283         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4284         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4285         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4286         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4287         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4288
4289 2019-03-25  Jer Noble  <jer.noble@apple.com>
4290
4291         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4292         https://bugs.webkit.org/show_bug.cgi?id=196097
4293
4294         Reviewed by Eric Carlson.
4295
4296         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4297
4298         * DumpRenderTree/mac/DumpRenderTree.mm:
4299         (resetWebPreferencesToConsistentValues):
4300         * WebKitTestRunner/TestController.cpp:
4301         (WTR::TestController::resetPreferencesToConsistentValues):
4302
4303 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4304
4305         Pull IPadUserInterfaceSwizzler out into a separate header file
4306         https://bugs.webkit.org/show_bug.cgi?id=196193
4307