REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_t...
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2
3         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
4         https://bugs.webkit.org/show_bug.cgi?id=87406
5
6         Reviewed by Dirk Pranke.
7
8         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
9         (TestExpectations.__init__):
10         * Scripts/webkitpy/tool/commands/rebaseline.py:
11         (RebaselineTest._update_expectations_file):
12         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13         (test_rebaseline_does_not_include_overrides):
14
15 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
16
17         webkitpy: perf tests unit tests fail on chromium win
18         https://bugs.webkit.org/show_bug.cgi?id=88279
19
20         Reviewed by Ryosuke Niwa.
21
22         I'm seeing weird failures running the unit tests in my win32
23         checkout, and we don't really expect webpagereplay to work on
24         win32 anyway, so I'm skipping the import of that module for now
25         and adding a warning.
26
27         * Scripts/run-perf-tests:
28         * Scripts/webkitpy/performance_tests/perftest.py:
29
30 2012-06-06  Yong Li <yoli@rim.com>
31
32         Unreviewed. Update my email address in committers.py.
33
34         * Scripts/webkitpy/common/config/committers.py:
35
36 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
37
38         Add Robert Kroeger  to commiters.py
39         https://bugs.webkit.org/show_bug.cgi?id=88415
40
41         Unreviewed.
42
43         * Scripts/webkitpy/common/config/committers.py:
44
45 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
46
47         [EFL][DRT] http/tests/globalhistory testcases do not pass
48         https://bugs.webkit.org/show_bug.cgi?id=82579
49
50         Reviewed by Csaba Osztrogonác.
51
52         DRT has provided callbacks for ewk_view "global history delegate" signals.
53
54         * DumpRenderTree/efl/DumpRenderTree.cpp:
55         (isGlobalHistoryTest): Aux function to ident global history testcase.
56         (createLayoutTestController):
57         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
58         (DumpRenderTreeChrome::createView):
59         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
60         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
61         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
62         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
63         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
64         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
65         (DumpRenderTreeChrome):
66
67 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
68
69         [Qt] run-qtwebkit-tests hangs with -j1
70         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
71         This could happen due to an uncancelled timer after results were returned. This timer was
72         started only if --timeout was set.
73         https://bugs.webkit.org/show_bug.cgi?id=85475
74
75         Reviewed by Csaba Osztrogonác.
76
77         * Scripts/run-qtwebkit-tests:
78         (run_test):
79
80 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
81
82         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
83         https://bugs.webkit.org/show_bug.cgi?id=88327
84
85         Reviewed by Kenneth Rohde Christiansen.
86
87         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
88         * MiniBrowser/qt/icons/contents_width.png: Added.
89         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
90         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
91
92 2012-06-05  Jon Lee  <jonlee@apple.com>
93
94         Buildbot fix.
95
96         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
97         in the function. Store in a local variable.
98         (loadBuilderConfig):
99
100 2012-06-05  Jon Lee  <jonlee@apple.com>
101
102         Buildbot fix.
103
104         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
105         (loadBuilderConfig):
106
107 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
108
109         webkitpy: clean up win-specific path handling and tests
110         https://bugs.webkit.org/show_bug.cgi?id=88281
111
112         Reviewed by Adam Barth.
113
114         There was a bunch of inconsistent logic for handling path
115         conversions for win32 and cygwin paths due to us sometimes
116         looking at sys.platform and sometimes using mock hosts. This
117         patch cleans everything up so that we are required to pass
118         PlatformInfo objects to the path module and stop trying to do
119         different things when running on cygwin or win32 hosts (except
120         in the path_unittest module itself).
121
122         This may slightly reduce test coverage for the win32 code paths
123         but will be a lot easier to follow and maintain.
124
125         * Scripts/webkitpy/common/system/path.py:
126         (abspath_to_uri):
127         (_convert_path):
128         * Scripts/webkitpy/common/system/path_unittest.py:
129         (AbspathTest.platforminfo):
130         (AbspathTest.test_abspath_to_uri_cygwin):
131         (AbspathTest.test_abspath_to_uri_unixy):
132         (AbspathTest.test_abspath_to_uri_win):
133         (AbspathTest.test_abspath_to_uri_escaping_unixy):
134         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
135         (AbspathTest.test_stop_cygpath_subprocess):
136         * Scripts/webkitpy/common/system/platforminfo.py:
137         (PlatformInfo.__init__):
138         (PlatformInfo.is_cygwin):
139         * Scripts/webkitpy/common/system/platforminfo_mock.py:
140         (MockPlatformInfo.is_cygwin):
141         * Scripts/webkitpy/layout_tests/port/base.py:
142         (Port.to.show_results_html_file):
143         * Scripts/webkitpy/layout_tests/port/driver.py:
144         (Driver.test_to_uri):
145         (Driver.uri_to_test):
146         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
147         (DriverTest.test_test_to_uri):
148         (DriverTest.test_uri_to_test):
149         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
150         (MockDRTPortTest.make_port):
151         (MockDRTTest.input_line):
152         (MockChromiumDRTTest.test_pixeltest__fails):
153         * Scripts/webkitpy/layout_tests/port/test.py:
154         * Scripts/webkitpy/layout_tests/port/win.py:
155         (WinPort.show_results_html_file):
156         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
157         (MainTest.test_unexpected_failures):
158         (MainTest.test_results_directory_absolute):
159         (MainTest.test_results_directory_default):
160         (MainTest.test_results_directory_relative):
161
162 2012-06-05  Jon Lee  <jonlee@apple.com>
163
164         Workaround buildbot bug when merging build requests.
165         https://bugs.webkit.org/show_bug.cgi?id=88158
166
167         Reviewed by Mark Rowe.
168
169         For expediency, we still want testers to pick the latest build to test, but to ensure
170         that the builders are reporting the correct revision number, we should let the building bots
171         run as they normally would. That is, the builder picks the oldest revision, and merges
172         subsequent requests. Because merged requests get appended to the list of changes for a given
173         build, the last change in that list is also the latest change. When we used pickLatestBuild
174         for the builders, this was not the case (it would always report the penultimate change).
175
176         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
177
178         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
179         for all Apple builders.
180         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
181         the latest build to run.
182         (loadBuilderConfig):
183
184 2012-06-05  Jessie Berlin  <jberlin@apple.com>
185
186         [Win] DumpRenderTree should call resetInternalsObject
187         https://bugs.webkit.org/show_bug.cgi?id=88346
188
189         Reviewed by Simon Fraser.
190
191         Invoke it on Windows in the same place it is invoked on Mac.
192
193         * DumpRenderTree/win/DumpRenderTree.cpp:
194         (resetWebViewToConsistentStateBeforeTesting):
195
196 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
197
198         [GTK] Fix two more memory leaks in DRT
199         https://bugs.webkit.org/show_bug.cgi?id=88255
200
201         Reviewed by Martin Robinson.
202
203         Fixed memory leaks in GTK's DRT code.
204
205         * DumpRenderTree/gtk/DumpRenderTree.cpp:
206         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
207         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
208         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
209         (createBitmapContextFromWebView): Free the cairo surface.
210
211 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
212
213         [Qt] Building when a top directory is named Source
214         https://bugs.webkit.org/show_bug.cgi?id=77727
215
216         Reviewed by Tor Arne Vestbø.
217
218         Change regex to only replace the last instance of OUT_PWD.
219
220         * qmake/mkspecs/features/default_pre.prf:
221
222 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
223
224         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
225         https://bugs.webkit.org/show_bug.cgi?id=73176
226
227         Reviewed by Adam Barth.
228
229         Two more APIs are added in Custom Scheme Handler specification.
230         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
231         One is 'isProtocolHandlerRegistered' to query whether the specific URL
232         is registered or not.
233         The other is 'unregisterProtocolHandler' to remove the registered URL.
234
235         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
236
237 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
238
239         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
240         https://bugs.webkit.org/show_bug.cgi?id=83879
241
242         Reviewed by Carlos Garcia Campos.
243
244         Make minibrowser connect to the new 'permission requests' signal
245         to allow users handle the Geolocation permission requests.
246
247         * MiniBrowser/gtk/BrowserWindow.c:
248         (geolocationRequestDialogCallback): Callback for the dialog asking
249         the user for allowing or not geolocation permission requests.
250         (webViewDecidePermissionRequest): Launch a dialog to ask the user
251         whether to allow or deny geolocation permission requests.
252         (browserWindowConstructed): Connect to 'permission-request' signal.
253
254 2012-06-04  Chase Phillips  <cmp@google.com>
255
256         Make a builder group support+expect multiple loads.
257         https://bugs.webkit.org/show_bug.cgi?id=88260
258
259         Change BuilderGroup to allow expecting multiple
260         loads.  This allows merging results for a given set
261         of builders into one group.
262
263         Add a test that verifies that the group count
264         increments correctly based on successful and failed
265         list loads.
266
267         Reviewed by Ojan Vafai.
268
269         * TestResultServer/static-dashboards/builders.js:
270         (BuilderGroup):
271         (BuilderGroup.prototype.setbuilder):
272         (BuilderGroup.prototype.append):
273         (BuilderGroup.prototype.loaded):
274         (requestBuilderList.xhr.onload):
275         (requestBuilderList.xhr.onerror):
276         (onErrorLoadingBuilderList):
277         (loadBuildersList):
278         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
279         (test):
280         * TestResultServer/static-dashboards/run-unittests.html:
281
282 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
283
284         Python test fix attempt for Chromium Windows.
285
286         * Scripts/webkitpy/layout_tests/port/driver.py:
287         (Driver.uri_to_test):
288
289 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
290
291         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
292         https://bugs.webkit.org/show_bug.cgi?id=88243
293
294         Reviewed by Adam Barth.
295
296         * qmake/mkspecs/features/features.prf:
297
298 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
299
300         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
301         https://bugs.webkit.org/show_bug.cgi?id=88280
302
303         Unreviewed, build fix.
304
305         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
306         (TestServerProcess.test_basic):
307
308 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
309
310         test-webkitpy is hanging under cygwin
311         https://bugs.webkit.org/show_bug.cgi?id=88269
312
313         Reviewed by Ryosuke Niwa.
314
315         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
316         so we need to skip any tests that use it.
317
318         * Scripts/webkitpy/common/system/executive.py:
319         (Executive.run_in_parallel):
320         * Scripts/webkitpy/common/system/executive_unittest.py:
321         (ExecutiveTest.test_run_in_parallel):
322
323 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
324
325         test-webkitpy is failing on win32 after r115054
326         https://bugs.webkit.org/show_bug.cgi?id=88264
327
328         Reviewed by Ryosuke Niwa.
329
330         The failing http_server test was improperly suppressed (the
331         tuple was missing a comma, and so wasn't a tuple at all, just a
332         string) and so we were skipping *all* tests on win32. The right
333         way to skip a single test is to disable it inside the test
334         itself.
335
336         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
337         (TestHttpServer.test_start_cmd):
338         * Scripts/webkitpy/test/test_finder.py:
339         (TestFinder._default_names):
340         * Scripts/webkitpy/test/main.py:
341         (Tester.run): Add error message if we don't find any tests to run.
342         * Scripts/webkitpy/test/main_unittest.py:
343             
344
345 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
346
347         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
348         https://bugs.webkit.org/show_bug.cgi?id=88215
349
350         Reviewed by Martin Robinson.
351
352         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
353         for newly allocated strings.
354
355         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
356         (attributeSetToString):
357         (AccessibilityUIElement::allAttributes):
358
359 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
360
361         [GTK] Memory leaks in DumpRenderTree.cpp
362         https://bugs.webkit.org/show_bug.cgi?id=88213
363
364         Reviewed by Martin Robinson.
365
366         Fixed memory leaks in DumpRenderTree.
367
368         * DumpRenderTree/gtk/DumpRenderTree.cpp:
369         (appendString): Accepts const gchar* as the second argument.
370         (dumpFramesAsText): Free the string returned by g_strdup_printf().
371         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
372
373 2012-06-04  David Dorwin  <ddorwin@chromium.org>
374
375         Enable Chromium media player to instantiate a plugin
376         https://bugs.webkit.org/show_bug.cgi?id=87399
377
378         Reviewed by Kent Tamura.
379
380         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
381
382         * DumpRenderTree/chromium/WebViewHost.cpp:
383         (WebViewHost::createPopupMenu):
384
385 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
386
387         [GTK][WK2] Implement geolocation provider for the GTK port
388         https://bugs.webkit.org/show_bug.cgi?id=83877
389
390         Reviewed by Carlos Garcia Campos.
391
392         * gtk/generate-gtkdoc:
393         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
394
395 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
396
397         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
398         https://bugs.webkit.org/show_bug.cgi?id=87668
399
400         Reviewed by Ryosuke Niwa.
401
402         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
403         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
404         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
405
406         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
407         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
408
409 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
410
411         [EFL] Refactor ewk_view_context_paint code.
412         https://bugs.webkit.org/show_bug.cgi?id=85588
413
414         Reviewed by Hajime Morita.
415
416         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
417
418 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
419
420         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
421         https://bugs.webkit.org/show_bug.cgi?id=87869
422
423         Reviewed by Andreas Kling.
424
425         Replace %lld by PRId64 macro to print an int64_t value and silent a
426         compilation warning on 64-Bit.
427
428         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
429         (onExceededApplicationCacheQuota):
430
431 2012-06-03  Varun Jain  <varunjain@google.com>
432
433         [chromium] Add new gesture type (two finger tap) that triggers context menu.
434         https://bugs.webkit.org/show_bug.cgi?id=88173
435
436         Reviewed by Adam Barth.
437
438         * DumpRenderTree/chromium/EventSender.cpp:
439         (EventSender::EventSender):
440         (EventSender::gestureTwoFingerTap):
441         (EventSender::gestureEvent):
442         * DumpRenderTree/chromium/EventSender.h:
443         (EventSender):
444
445 2012-06-02  Zeno Albisser  <zeno@webkit.org>
446
447         Fix and enable WebGL for WebKit2 on Qt.
448         https://bugs.webkit.org/show_bug.cgi?id=86214
449
450         Enable WebGL by default for Qt MiniBrowser.
451
452         Reviewed by Noam Rosenthal.
453
454         * MiniBrowser/qt/qml/BrowserWindow.qml:
455
456 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
457
458         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
459         https://bugs.webkit.org/show_bug.cgi?id=88164
460
461         Reviewed by Kentaro Hara.
462
463         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
464         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
465
466         * Scripts/VCSUtils.pm:
467         (adjustPathForRecentRenamings):
468         (fixChangeLogPatch):
469
470 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
471
472         Rename test_expectations.txt to TestExpectations
473         https://bugs.webkit.org/show_bug.cgi?id=86690
474
475         Reviewed by Dirk Pranke.
476
477         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
478         We can the code to read test_expectations.txt once we've successfully transitioned.
479
480         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
481         (TestExpectationParser._check_path_does_not_exist):
482         (TestExpectationParser._tokenize):
483         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
484         * Scripts/webkitpy/layout_tests/port/base.py:
485         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
486         test_expectations.txt if one exists and the path to TestExpectations otherwise.
487         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
488         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
489         virtual.
490         * Scripts/webkitpy/layout_tests/port/chromium.py:
491         (ChromiumPort.path_from_chromium_base):
492         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
493         (ChromiumAndroidPort.test_expectations):
494         * Scripts/webkitpy/layout_tests/port/test.py:
495         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
496         (TestPort.__init__):
497         * Scripts/webkitpy/layout_tests/port/webkit.py:
498         (WebKitPort.baseline_search_path):
499         (WebKitPort.test_expectations):
500         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
501         tests to base as a follow up.
502         (WebKitPortTest.test_path_to_test_expectations_file):
503         (test_test_expectations):
504         (test_legacy_test_expectations):
505         * Scripts/webkitpy/style/checker.py:
506         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
507         with one for TestExpectations.
508         * Scripts/webkitpy/style/checkers/test_expectations.py:
509         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
510         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
511         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
512         test_expectations.txt.
513         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
514         (TestExpectationsTestCase.assert_lines_lint):
515         * Scripts/webkitpy/tool/commands/queries.py:
516         (PrintExpectations.__init__):
517         * Scripts/webkitpy/tool/commands/rebaseline.py:
518         (RebaselineExpectations):
519         * Scripts/webkitpy/tool/steps/commit.py:
520         (Commit._check_test_expectations):
521         * Scripts/webkitpy/tool/steps/commit_unittest.py:
522         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
523         (CommitTest.test_check_test_expectations): For TestExpectations.
524         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
525         * TestResultServer/static-dashboards/dashboard_base.js:
526         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
527         Error only when neither exists.
528         * TestResultServer/static-dashboards/flakiness_dashboard.js:
529         (processMissingAndExtraExpectations):
530         (htmlForTestsWithExpectationsButNoFailures):
531         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
532
533 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
534
535         Remove dependency from ImageDiff to WTF
536         https://bugs.webkit.org/show_bug.cgi?id=88147
537
538         Reviewed by Adam Barth.
539
540         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
541
542 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
543
544         NRWT seems to leak (more?) temp dirs
545         https://bugs.webkit.org/show_bug.cgi?id=88126
546
547         Re-land r119297 with chromium fix (weren't calling the
548         super() method if not in --test-shell mode in start().
549         Add unit tests to chromium_unittest as well to check.
550
551         * Scripts/webkitpy/layout_tests/port/chromium.py:
552         (ChromiumDriver.start):
553         * Scripts/webkitpy/layout_tests/port/webkit.py:
554         (WebKitDriver.__del__):
555         (WebKitDriver._start):
556         (WebKitDriver.run_test):
557         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
558         (WebKitDriverTest.test_check_for_driver_crash):
559         (WebKitDriverTest.test_stop_cleans_up_properly):
560         (WebKitDriverTest):
561         (WebKitDriverTest.test_two_starts_cleans_up_properly):
562         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
563         (ChromiumDriverTest.test_stop_cleans_up_properly):
564         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
565
566 2012-06-01  Tim Horton  <timothy_horton@apple.com>
567
568         Lots of "failed download-built-product" on Apple bots
569         https://bugs.webkit.org/show_bug.cgi?id=88158
570
571         Reviewed by Jessie Berlin.
572         
573         Disable mergeRequests on all Apple builders. This is a speculative fix.
574
575         * BuildSlaveSupport/build.webkit.org-config/config.json:
576
577 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
578
579         Unreviewed, rolling out r119297.
580         http://trac.webkit.org/changeset/119297
581         https://bugs.webkit.org/show_bug.cgi?id=88156
582
583         May have broken Chromium bots (Requested by rniwa on #webkit).
584
585         * Scripts/webkitpy/layout_tests/port/webkit.py:
586         (WebKitDriver.__del__):
587         (WebKitDriver.run_test):
588         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
589         (WebKitDriverTest.test_check_for_driver_crash):
590         (WebKitDriverTest.test_stop_cleans_up_properly):
591
592 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
593
594         nrwt seems to leak tmpdirs
595         https://bugs.webkit.org/show_bug.cgi?id=88126
596
597         Reviewed by Ojan Vafai.
598
599         Fix leak possibly introduced in r118979 - we now will
600         make sure we clean up any stale temp directories during the
601         start routine and attempt to clean up again in __del__. It
602         turns out that asserting in __del__ logs a message but is
603         caught by the runtime, so it's mostly useless.
604
605         * Scripts/webkitpy/layout_tests/port/webkit.py:
606         (WebKitDriver.__del__):
607         (WebKitDriver._start):
608         (WebKitDriver.run_test):
609         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
610         (WebKitDriverTest.test_check_for_driver_crash):
611         (WebKitDriverTest.test_stop_cleans_up_properly):
612         (WebKitDriverTest):
613         (WebKitDriverTest.test_two_starts_cleans_up_properly):
614
615 2012-06-01  Michael Saboff  <msaboff@apple.com>
616
617         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
618         https://bugs.webkit.org/show_bug.cgi?id=88109
619
620         Reviewed by Geoffrey Garen.
621
622         Additional test case.
623
624         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
625         (TestWebKitAPI::TEST):
626
627 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
628
629         [Qt] Use -Werror only in developer builds
630
631         Rubber-stamped by Tor Arne Vestbø.
632
633         In production builds -Werror with custom toolchains and wierd system
634         headers, -Werror is of no use and just creates confusion. So use it
635         only if Qt is configured with -developer-build.
636
637         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
638         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
639         only if qt_developer_build is set.
640
641 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
642
643         [watchlist] Add myself to loader and v8 bindings changes
644         https://bugs.webkit.org/show_bug.cgi?id=88112
645
646         Reviewed by Adam Barth.
647
648         * Scripts/webkitpy/common/config/watchlist:
649
650 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
651
652         Adding Jacky Jiang to committers.py
653         https://bugs.webkit.org/show_bug.cgi?id=88122
654
655         Reviewed by Rob Buis.
656
657         Adding myself to committers.py as a Committer.
658
659         * Scripts/webkitpy/common/config/committers.py:
660
661 2012-06-01  Jessie Berlin  <jberlin@apple.com>
662
663         Fix Windows build.
664
665         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
666
667 2012-06-01  Jessie Berlin  <jberlin@apple.com>
668
669         Windows WK2 MouseMoveAfterCrash API test failing
670         https://bugs.webkit.org/show_bug.cgi?id=69982
671
672         Disable the test on Windows to get the bots greener.
673
674         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
675         (TestWebKitAPI::TEST):
676
677 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
678
679         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
680         https://bugs.webkit.org/show_bug.cgi?id=86866
681
682         Reviewed by Adam Barth.
683
684         Catch new "intent,service,register" signal on the frame and print out
685         information about the Web Intent service in EFL's DumpRenderTree.
686
687         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
688         (DumpRenderTreeChrome::createView):
689         (DumpRenderTreeChrome::onFrameCreated):
690         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
691         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
692         (DumpRenderTreeChrome):
693
694 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
695
696         The ChangeLog parser cannot handle reviewers with initials in their name
697         https://bugs.webkit.org/show_bug.cgi?id=87864
698
699         Reviewed by Ryosuke Niwa.
700
701         Add support in the ChangeLog parser for reviewer names that have
702         initials in them.
703
704         * Scripts/webkitpy/common/checkout/changelog.py:
705         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
706         in the replacement string. This allows for matching the word characters before a
707         period, without totally throwing them away.
708         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
709         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
710         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
711
712 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
713
714         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
715         https://bugs.webkit.org/show_bug.cgi?id=86865
716
717         Reviewed by Adam Barth.
718
719         Add deliverWebIntent method to LayoutTestController and provide
720         implementation for EFL port.
721
722         * DumpRenderTree/LayoutTestController.cpp:
723         (deliverWebIntentCallback):
724         (LayoutTestController::staticFunctions):
725         * DumpRenderTree/LayoutTestController.h:
726         (LayoutTestController):
727         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
728         (LayoutTestController::deliverWebIntent):
729         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
730         (LayoutTestController::deliverWebIntent):
731         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
732         (LayoutTestController::deliverWebIntent):
733         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
734         (LayoutTestController::deliverWebIntent):
735         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
736         (LayoutTestController::deliverWebIntent):
737         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
738         (LayoutTestController::deliverWebIntent):
739
740 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
741
742         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
743
744         Reviewed by Simon Hausmann.
745
746         * Tools.pro:
747
748 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
749
750         Add public page loading performance tests using web-page-replay
751         https://bugs.webkit.org/show_bug.cgi?id=84008
752
753         Reviewed by Dirk Pranke.
754
755         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
756         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
757         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
758
759         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
760         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
761         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
762         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
763
764         * Scripts/webkitpy/layout_tests/port/driver.py:
765         (Driver.is_external_http_test): Added.
766         * Scripts/webkitpy/layout_tests/port/webkit.py:
767         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
768         * Scripts/webkitpy/performance_tests/perftest.py:
769         (PerfTest.__init__): Takes port.
770         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
771         (PerfTest):
772         (PerfTest.run): Calls run_single.
773         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
774         (ChromiumStylePerfTest.__init__):
775         (PageLoadingPerfTest.__init__):
776         (PageLoadingPerfTest.run):
777         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
778         (ReplayServer.__init__):
779         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
780         but it caused a dead lock on some web pages.
781         (ReplayServer.stop):
782         (ReplayServer.__del__):
783         (ReplayPerfTest):
784         (ReplayPerfTest.__init__):
785         (ReplayPerfTest._start_replay_server):
786         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
787         The subsequent runs of the same test will just use test.wpr.
788         (ReplayPerfTest.run_single):
789         (PerfTestFactory):
790         (PerfTestFactory.create_perf_test):
791         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
792         (MainTest.test_parse_output):
793         (MainTest.test_parse_output_with_failing_line):
794         (TestPageLoadingPerfTest.test_run):
795         (TestPageLoadingPerfTest.test_run_with_bad_output):
796         (TestReplayPerfTest):
797         (TestReplayPerfTest.ReplayTestPort):
798         (TestReplayPerfTest.ReplayTestPort.__init__):
799         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
800         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
801         (TestReplayPerfTest.ReplayTestPort._driver_class):
802         (TestReplayPerfTest.MockReplayServer):
803         (TestReplayPerfTest.MockReplayServer.__init__):
804         (TestReplayPerfTest.MockReplayServer.stop):
805         (TestReplayPerfTest._add_file):
806         (TestReplayPerfTest._setup_test):
807         (TestReplayPerfTest.test_run_single):
808         (TestReplayPerfTest.test_run_single.run_test):
809         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
810         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
811         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
812         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
813         (TestReplayPerfTest.test_prepare):
814         (TestReplayPerfTest.test_prepare.run_test):
815         (TestReplayPerfTest.test_prepare_calls_run_single):
816         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
817         (TestPerfTestFactory.test_regular_test):
818         (TestPerfTestFactory.test_inspector_test):
819         (TestPerfTestFactory.test_page_loading_test):
820         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
821         (PerfTestsRunner):
822         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
823         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
824         (PerfTestsRunner._collect_tests._is_test_file):
825         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
826         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
827         (create_runner):
828         (run_test):
829         (_tests_for_runner):
830         (test_run_test_set):
831         (test_run_test_set_kills_drt_per_run):
832         (test_run_test_pause_before_testing):
833         (test_run_test_set_for_parser_tests):
834         (test_run_test_set_with_json_output):
835         (test_run_test_set_with_json_source):
836         (test_run_test_set_with_multiple_repositories):
837         (test_run_with_upload_json):
838         (test_upload_json):
839         (test_upload_json.MockFileUploader.upload_single_text_file):
840         (_add_file):
841         (test_collect_tests):
842         (test_collect_tests_with_multile_files):
843         (test_collect_tests_with_multile_files.add_file):
844         (test_collect_tests_with_skipped_list):
845         (test_collect_tests_with_page_load_svg):
846         (test_collect_tests_should_ignore_replay_tests_by_default):
847         (test_collect_tests_with_replay_tests):
848         (test_parse_args):
849         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
850         (AutoinstallImportHook.find_module):
851         (AutoinstallImportHook._install_webpagereplay):
852
853 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
854
855         Support building the Android port of chromium with Ninja
856         https://bugs.webkit.org/show_bug.cgi?id=87545
857
858         Reviewed by Adam Barth.
859
860         Ensures that shared libraries are looked up in a generator-agnostic
861         way and that output is placed in the correct directory.
862
863         Depends on http://codereview.chromium.org/10386188/
864
865         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
866
867 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
868
869         [Chromium] Chromium DRT should be able to load external resources
870         https://bugs.webkit.org/show_bug.cgi?id=87893
871
872         Reviewed by Dirk Pranke.
873
874         Allow external resources to be loaded when the main frame's URL is also an external resource.
875         This change is analogous to r118231 for Mac port.
876
877         * DumpRenderTree/chromium/WebViewHost.cpp:
878         (blockRequest):
879         (isLocalhost):
880         (hostIsUsedBySomeTestsToGenerateError):
881         (WebViewHost::willSendRequest):
882
883 2012-05-31  Anders Carlsson  <andersca@apple.com>
884
885         Build fixes.
886
887         Disable the C++11 extensions warning.
888
889         * DumpRenderTree/mac/Configurations/Base.xcconfig:
890         * TestWebKitAPI/Configurations/Base.xcconfig:
891         * WebKitTestRunner/Configurations/Base.xcconfig:
892
893 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
894
895         [WK2] window.internals settings are not reset between tests
896         https://bugs.webkit.org/show_bug.cgi?id=87783
897
898         Reviewed by Mihai Parparita.
899
900         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
901         (WTR::InjectedBundle::done): Call resetAfterTest().
902
903         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
904         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
905         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
906         This needs to be done after a tets, because the code assumes that there is an object
907         with this name in global scope.
908
909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
910
911 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
912
913         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
914         https://bugs.webkit.org/show_bug.cgi?id=85006
915
916         Reviewed by Tor Arne Vestbø.
917
918         Added navigation_policy_decision implementation for DumpRenderTreeView.
919         Added LayoutTestController::setCustomPolicyDelegate implementation.
920         Modified LayoutTestController::waitForPolicyDelegate.
921
922         * DumpRenderTree/efl/DumpRenderTree.cpp:
923         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
924         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
925         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
926         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
927         (navigationTypeToString): aux function
928         (onNavigationPolicyDecision): navigation_policy_decision implementation
929         (drtViewAdd):
930         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
931         (LayoutTestController::setCustomPolicyDelegate):
932         (LayoutTestController::waitForPolicyDelegate):
933
934 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
935
936         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
937         https://bugs.webkit.org/show_bug.cgi?id=86195
938
939         Reviewed by Gustavo Noronha Silva.
940
941         Implement clearApplicationCacheForOrigin in EFL
942         LayoutTestController.
943
944         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
945         (LayoutTestController::clearApplicationCacheForOrigin):
946
947 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
948
949         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
950         https://bugs.webkit.org/show_bug.cgi?id=87955
951
952         Reviewed by Simon Hausmann.
953
954         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
955         * DumpRenderTree/qt/EventSenderQt.cpp:
956         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
957         * DumpRenderTree/qt/main.cpp:
958         * QtTestBrowser/cookiejar.cpp:
959         * QtTestBrowser/launcherwindow.cpp:
960         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
961         * qmake/mkspecs/features/default_post.prf:
962
963 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
964
965         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
966
967         Rubber-stamped by Kenneth Rohde Christiansen.
968
969         * qmake/config.tests/libpng/libpng.pro:
970
971 2012-05-30  Peter Beverloo  <peter@chromium.org>
972
973         [Chromium] Automatically install 64-bit linker for Android
974         https://bugs.webkit.org/show_bug.cgi?id=79780
975
976         Reviewed by Adam Barth.
977
978         Change the update-webkit-chromium script to check whether the 64-bit
979         linker needs to be installed as part of the update process. The actual
980         code for doing these checks and "installing" it has been added to the
981         webkitdirs.pm script.
982
983         The linker itself is part of the third_party/aosp repository, which
984         will be pulled in through the DEPS change.
985
986         * Scripts/update-webkit-chromium:
987         * Scripts/webkitdirs.pm:
988         (chromiumInstall64BitAndroidLinkerIfNeeded):
989         (chromiumReplaceAndroidLinkerIfNeeded):
990
991 2012-05-30  Stephanie Lewis  <slewis@apple.com>
992
993         https://bugs.webkit.org/show_bug.cgi?id=87803
994         Layout tests often fail trying to stat nonexistent logs 
995
996         Reviewed by Dirk Pranke.
997
998         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
999         try/catch block around accessing the logs as a precaution.
1000
1001         * Scripts/webkitpy/common/system/crashlogs.py:
1002         (CrashLogs._find_newest_log_darwin):
1003
1004 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1005
1006         Add a LayoutTest for prerender remove after stop.
1007         https://bugs.webkit.org/show_bug.cgi?id=87860
1008
1009         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1010         can be tested by LayoutTests now.
1011
1012         Reviewed by Adam Barth.
1013
1014         * DumpRenderTree/DumpRenderTree.gypi:
1015         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1016         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1017         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1018         (MockWebPrerenderingSupport::add):
1019         (MockWebPrerenderingSupport::cancel):
1020         (MockWebPrerenderingSupport::abandon):
1021         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1022         (MockWebPrerenderingSupport):
1023         * DumpRenderTree/chromium/TestShell.cpp:
1024         (TestShell::initialize):
1025         * DumpRenderTree/chromium/TestShell.h:
1026         (TestShell):
1027         * DumpRenderTree/chromium/WebViewHost.cpp:
1028         (WebViewHost::willAddPrerender):
1029         (WebViewHost::setWebWidget):
1030         * DumpRenderTree/chromium/WebViewHost.h:
1031         (WebViewHost):
1032
1033 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=87717
1036         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1037
1038         Reviewed by Dirk Pranke.
1039
1040         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1041         If there isn't a crash log found for the process add a message saying
1042         the process was unresponsive.
1043
1044         * Scripts/webkitpy/layout_tests/port/webkit.py:
1045         (WebKitDriver.__init__):
1046         (WebKitDriver._check_for_driver_crash):
1047         (WebKitDriver.run_test):
1048         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1049         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1050         (WebKitDriverTest):
1051         (WebKitDriverTest.test_check_for_driver_crash):
1052         * WebKitTestRunner/TestController.cpp:
1053         (WTR):
1054         (WTR::TestController::runTest):
1055
1056 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1057
1058         https://bugs.webkit.org/show_bug.cgi?id=87714
1059         Mac crash logs can take a really long time to be written out.
1060
1061         Reviewed by Dirk Pranke.
1062
1063         Make a second pass looking for crash logs after the tests have completed running.
1064
1065         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1066         (use_trac_links_in_results_html):
1067         (Manager.run):
1068         * Scripts/webkitpy/layout_tests/port/base.py:
1069         (Port.repository_paths):
1070         (Port.look_for_new_crash_logs):
1071         * Scripts/webkitpy/layout_tests/port/mac.py:
1072         (MacPort.look_for_new_crash_logs):
1073         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1074         (test_get_crash_log):
1075         (test_look_for_new_crash_logs):
1076         (test_look_for_new_crash_logs.fake_time_cb):
1077
1078 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1079
1080         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1081
1082         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1083         (LayoutWebViewEventHandler::OnAlertEvent):
1084         (LayoutWebViewEventHandler::OnConfirmEvent):
1085         (LayoutWebViewEventHandler):
1086         (LayoutWebViewEventHandler::OnPromptEvent):
1087         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1088         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1089
1090 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1091
1092         Only give lint errors for -expected.png png files that lack a checksum
1093         https://bugs.webkit.org/show_bug.cgi?id=87875
1094
1095         Reviewed by Tony Chang.
1096
1097         We have other pngs in the tree, e.g. for the inspector, that legitimately
1098         lack a checksum.
1099
1100         * Scripts/webkitpy/style/checkers/png.py:
1101         (PNGChecker.check):
1102         * Scripts/webkitpy/style/checkers/png_unittest.py:
1103         (PNGCheckerTest.test_check):
1104
1105 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1106
1107         nrwt: seems to leak temp dirs
1108         https://bugs.webkit.org/show_bug.cgi?id=87795
1109
1110         Reviewed by Ojan Vafai.
1111
1112         There appears to be a bug where the chromium bots are creating
1113         temporary directories and not cleaning them up that started
1114         after the switch to WebKitDriver. It's possible that __del__
1115         wasn't getting called in a timely manner (or at all), and it's
1116         generally bad style to rely on __del__ being called, so this
1117         code changes things so that we create a temp dir in
1118         driver.start() and remove it in driver.stop(). We could be
1119         paranoid and leave the __del__ code in, but there doesn't seem
1120         to be much advantage to it. If there are bugs that result in
1121         drivers being started but not stopped, we have other problems.
1122
1123         * Scripts/webkitpy/common/system/filesystem_mock.py:
1124         (MockFileSystem.__init__):
1125         (MockFileSystem._mktemp):
1126         (MockFileSystem.mkdtemp):
1127         * Scripts/webkitpy/layout_tests/port/webkit.py:
1128         (WebKitDriver.__init__):
1129         (WebKitDriver._start):
1130         (WebKitDriver.stop):
1131         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1132         (WebKitDriverTest.test_check_for_driver_crash):
1133         (WebKitDriverTest):
1134         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1135         (WebKitDriverTest.test_stop_cleans_up_properly):
1136
1137 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1138
1139         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1140         https://bugs.webkit.org/show_bug.cgi?id=86841
1141
1142         Reviewed by Adam Barth.
1143
1144         Print the number of MessagePorts for each new intent in EFL's DRT.
1145         This output is expected by several Web Intents test cases.
1146
1147         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1148         (DumpRenderTreeChrome::onFrameIntentNew):
1149
1150 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1151
1152         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1153
1154         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1155
1156 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1157
1158         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1159         https://bugs.webkit.org/show_bug.cgi?id=87829
1160
1161         Reviewed by Adam Barth.
1162
1163         EFL's LayoutTestController now makes uses of the new helper method in
1164         DumpRenderTreeSupportEfl in order to send the intent response. This is
1165         now needed because the Ewk_Intent_Request postResult / postFailure
1166         methods were made private.
1167
1168         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1169         (LayoutTestController::sendWebIntentResponse):
1170
1171 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1172
1173         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1174         https://bugs.webkit.org/show_bug.cgi?id=86296
1175
1176         Reviewed by Tony Chang.
1177
1178         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1179         (cfHDropFormat):
1180         (cfFileNameWFormat):
1181         (cfUrlWFormat):
1182         (WCEnumFormatEtc):
1183         (WCEnumFormatEtc::WCEnumFormatEtc):
1184         (WCEnumFormatEtc::QueryInterface):
1185         (WCEnumFormatEtc::AddRef):
1186         (WCEnumFormatEtc::Release):
1187         (WCEnumFormatEtc::Next):
1188         (WCEnumFormatEtc::Skip):
1189         (WCEnumFormatEtc::Reset):
1190         (WCEnumFormatEtc::Clone):
1191         (DRTDataObject::createInstance):
1192         (DRTDataObject::DRTDataObject):
1193         (DRTDataObject::~DRTDataObject):
1194         (DRTDataObject::QueryInterface):
1195         (DRTDataObject::AddRef):
1196         (DRTDataObject::Release):
1197         (DRTDataObject::GetData):
1198         (DRTDataObject::GetDataHere):
1199         (DRTDataObject::QueryGetData):
1200         (DRTDataObject::GetCanonicalFormatEtc):
1201         (DRTDataObject::SetData):
1202         (DRTDataObject::CopyMedium):
1203         (DRTDataObject::EnumFormatEtc):
1204         (DRTDataObject::DAdvise):
1205         (DRTDataObject::DUnadvise):
1206         (DRTDataObject::EnumDAdvise):
1207         (DRTDataObject::clearData):
1208         * DumpRenderTree/win/DRTDataObject.h: Added.
1209         (DRTDataObject):
1210         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1211         (DRTDropSource::DRTDropSource):
1212         (DRTDropSource::~DRTDropSource):
1213         (DRTDropSource::QueryInterface):
1214         (DRTDropSource::AddRef):
1215         (DRTDropSource::Release):
1216         (DRTDropSource::createInstance):
1217         (DRTDropSource::QueryContinueDrag):
1218         (DRTDropSource::GiveFeedback):
1219         * DumpRenderTree/win/DRTDropSource.h: Added.
1220         (DRTDropSource):
1221         * DumpRenderTree/win/DumpRenderTree.vcproj:
1222         * DumpRenderTree/win/EventSender.cpp:
1223         (beginDragWithFilesCallback):
1224
1225 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1226
1227         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1228         https://bugs.webkit.org/show_bug.cgi?id=58593
1229
1230         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1231         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1232         public C API of the WebProcess.
1233
1234         Reviewed by Darin Adler.
1235
1236         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1237         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1238         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1239         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1240         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1241
1242 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1243
1244         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1245         https://bugs.webkit.org/show_bug.cgi?id=87848
1246
1247         Reviewed by Csaba Osztrogonác.
1248
1249         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1250         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1251         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1252
1253         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1254         (DumpRenderTreeChrome::extraViews):
1255         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1256         (DumpRenderTreeChrome):
1257
1258 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1259
1260         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1261         https://bugs.webkit.org/show_bug.cgi?id=87833
1262
1263         Reviewed by Tor Arne Vestbø.
1264
1265         Print "postProgressFinishedNotification" message if frame load finished 
1266         to unskip http/tests/loading/progress-finished-callback.html.
1267
1268         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1269         (DumpRenderTreeChrome::onFrameLoadFinished):
1270
1271 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1272
1273         [EFL][WK2] Fix WebKit2-EFL build
1274         https://bugs.webkit.org/show_bug.cgi?id=83693
1275
1276         Reviewed by Carlos Garcia Campos.
1277
1278         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1279
1280 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1281
1282         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1283         (They only used to check for Skipped in platform/qt-5.0-wk1)
1284         https://bugs.webkit.org/show_bug.cgi?id=87376
1285
1286         Reviewed by Csaba Osztrogonác.
1287
1288         * Scripts/old-run-webkit-tests:
1289         (buildPlatformResultHierarchy):
1290         * Scripts/webkitpy/layout_tests/port/qt.py:
1291         (QtPort.baseline_search_path):
1292
1293 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1294
1295         Add a linter error for pngs that lack an embedded checksum
1296         https://bugs.webkit.org/show_bug.cgi?id=87793
1297
1298         Reviewed by Dirk Pranke.
1299
1300         * Scripts/read-checksum-from-png:
1301         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1302         (read_checksum):
1303         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1304         (ReadChecksumFromPngTest):
1305         (ReadChecksumFromPngTest.test_read_checksum):
1306         * Scripts/webkitpy/layout_tests/port/base.py:
1307         * Scripts/webkitpy/style/checkers/png.py:
1308         (PNGChecker.check):
1309         * Scripts/webkitpy/style/checkers/png_unittest.py:
1310         (PNGCheckerTest.test_check):
1311
1312 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=87720
1315         WebProcess is often killed due to being unresponsive on the bots
1316
1317         Reviewed by Alexey Proskuryakov.
1318
1319         Blind attempt to improve flakiness on the bots by reducing the number
1320         of crashes due to an unresponsive process.  This helped on my personal machine
1321         under stress conditions.  I don't have enough cores to hit the problem
1322         under normal conditions.
1323
1324         * WebKitTestRunner/TestController.cpp:
1325         (WTR):
1326
1327 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1328
1329         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1330         https://bugs.webkit.org/show_bug.cgi?id=87779
1331
1332         Reviewed by Eric Seidel.
1333
1334         Update output to match the names in scm.py as per
1335         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1336
1337         * Scripts/webkitpy/tool/commands/rebaseline.py:
1338         (RebaselineTest.execute):
1339         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1340         (test_rebaseline_test_and_print_scm_changes):
1341         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1342         (GardeningServerTest.test_rebaselineall):
1343
1344 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=87711
1347
1348         Reviewed by Jessie Berlin.
1349
1350         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1351         are better maintained.
1352
1353         * BuildSlaveSupport/build.webkit.org-config/config.json:
1354
1355 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1356
1357         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1358         https://bugs.webkit.org/show_bug.cgi?id=87538
1359
1360         Reviewed by Ojan Vafai.
1361
1362         Invoking git and svn on one file at a time is kinda slow. We
1363         should batch the add and rm operations together.
1364
1365         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1366         (BaselineOptimizer._move_baselines):
1367
1368 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1369
1370         garden-o-matic should rebaseline baselines in parallel
1371         https://bugs.webkit.org/show_bug.cgi?id=87451
1372
1373         Reviewed by Ojan Vafai.
1374                                                                                
1375         This modifies garden-o-matic so that we will fetch all                  
1376         of the baselines in parallel from the bots, and then                    
1377         optimize the baselines serially (since that should be fairly            
1378         quick and we get into trouble if we optimize in parallel due            
1379         to concurrent access to the source control system).                     
1380
1381         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1382         so that the files that need to be modified in the SCM are returned to 
1383         garden-o-matic rather than actually added or removed. This is done so that
1384         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1385         concurrently). In order to safely return the files (as a JSON dict) I
1386         needed to shift all of the logging in rebaseline-test to use the logging
1387         module (and hence log to stderr).
1388
1389         I also had to stub out a line in chromium.py that would get confused if
1390         the skia overrides file didn't exist in a mock checkout.
1391
1392         * Scripts/webkitpy/common/system/executive.py:
1393         (Executive.popen):
1394         (Executive):
1395         (Executive.run_in_parallel):
1396         (_run_command_thunk):
1397         * Scripts/webkitpy/common/system/executive_mock.py:
1398         (MockExecutive.run_in_parallel):
1399         * Scripts/webkitpy/common/system/executive_unittest.py:
1400         (ExecutiveTest.test_run_in_parallel):
1401         * Scripts/webkitpy/layout_tests/port/chromium.py:
1402         (ChromiumPort._expectations_file_contents):
1403         * Scripts/webkitpy/tool/commands/rebaseline.py:
1404         (AbstractRebaseliningCommand.__init__):
1405         (RebaselineTest.__init__):
1406         (RebaselineTest._copy_existing_baseline):
1407         (RebaselineTest._save_baseline):
1408         (RebaselineTest):
1409         (RebaselineTest._add_to_scm):
1410         (RebaselineTest._rebaseline_test):
1411         (RebaselineTest.execute):
1412         (RebaselineExpectations._rebaseline_port):
1413         (RebaselineExpectations.execute):
1414         (Rebaseline._builder_to_pull_from):
1415         (Rebaseline.execute):
1416         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1417         (test_rebaseline_updates_expectations_file):
1418         (test_rebaseline_test):
1419         (test_rebaseline_test_and_print_scm_changes):
1420         (test_rebaseline_and_copy_test):
1421         (test_rebaseline_and_copy_test_no_existing_result):
1422         (test_rebaseline_and_copy_test_with_lion_result):
1423         (test_rebaseline_and_copy_no_overwrite_test):
1424         (test_rebaseline_expectations):
1425         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1426         (GardeningHTTPRequestHandler._rebaseline_commands):
1427         (GardeningHTTPRequestHandler):
1428         (GardeningHTTPRequestHandler._files_to_add):
1429         (GardeningHTTPRequestHandler._optimize_baselines):
1430         (GardeningHTTPRequestHandler.rebaselineall):
1431         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1432         (GardeningServerTest._post_to_path):
1433         (GardeningServerTest.test_rebaselineall):
1434         (GardeningServerTest.test_rebaselineall.run_command):
1435
1436 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1437
1438         Fix the type of dispatch_time() offset
1439
1440         Rubber-stamped by Joseph Pecoraro.
1441
1442         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1443
1444         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1445         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1446
1447 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1448
1449         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1450
1451         [BlackBerry] OpenGL content is not rendered on simulator
1452         https://bugs.webkit.org/show_bug.cgi?id=87721
1453
1454         Reviewed by George Staikos.
1455
1456         Fixed by enabling GLES2 support in simulator builds.
1457
1458         To experiment with building without OpenGL support, you can set the
1459         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1460
1461         PR #150695
1462
1463         * Scripts/webkitdirs.pm:
1464         (blackberryCMakeArguments):
1465
1466 2012-05-29  David Barr  <davidbarr@chromium.org>
1467
1468         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1469         https://bugs.webkit.org/show_bug.cgi?id=87685
1470
1471         Reviewed by Eric Seidel.
1472
1473         Add a configuration option for CSS image-resolution support, disabling it by default.
1474
1475         * Scripts/webkitperl/FeatureList.pm:
1476         * qmake/mkspecs/features/features.pri:
1477
1478 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1479
1480         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1481
1482         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1483             valid for C++/ObjC++ but not for C [enabled by default]"
1484
1485         Reviewed by Simon Hausmann.
1486
1487         * qmake/mkspecs/features/unix/default_post.prf:
1488
1489 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1490
1491         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1492
1493         https://bugs.webkit.org/show_bug.cgi?id=87133
1494
1495         We now base64-encode the page url in the image-provider url, so that any
1496         normalization done by QUrl will not mess up the page-url. The logic of
1497         creating and parsing the provider-url has been moved into the image
1498         provider, to keep it in one place.
1499
1500         We were also releasing icons (even ones we hadn't retained), which we can't
1501         do since we don't know when the icon url is no longer in use.
1502
1503         Reviewed-by Simon Hausmann.
1504
1505         * MiniBrowser/qt/icons/favicon.png:
1506         * MiniBrowser/qt/qml/BrowserWindow.qml:
1507
1508 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1509
1510         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1511         https://bugs.webkit.org/show_bug.cgi?id=87654
1512
1513         Reviewed by Csaba Osztrogonác.
1514
1515         Event sender provides strings for all the key events.
1516         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1517         a key event has empty string.
1518
1519         * DumpRenderTree/efl/EventSender.cpp:
1520         (KeyEventInfo::KeyEventInfo):
1521         (keyPadNameFromJSValue):
1522         (keyNameFromJSValue):
1523
1524 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1525
1526         [Qt] Cancel potential url-edit when going back/forward
1527
1528         Reviewed by Kenneth Rohde Christiansen.
1529
1530         * MiniBrowser/qt/qml/BrowserWindow.qml:
1531
1532 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1533
1534         [EFL] Compilation warning in DumpRenderTreeView.cpp
1535         https://bugs.webkit.org/show_bug.cgi?id=87636
1536
1537         Reviewed by Filip Pizlo.
1538
1539         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1540         specifier in printf. Also fix the return type for
1541         onExceededApplicationCacheQuota callback.
1542
1543         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1544         (onExceededApplicationCacheQuota):
1545
1546 2012-05-29  Hironori Bono  <hbono@chromium.org>
1547
1548         Adding Hironori Bono to committers.py.
1549         https://bugs.webkit.org/show_bug.cgi?id=87697
1550
1551         * Scripts/webkitpy/common/config/committers.py:
1552
1553 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1554
1555         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1556         https://bugs.webkit.org/show_bug.cgi?id=80135
1557
1558         Reviewed by Rob Buis.
1559
1560         Implemented interface function didReceiveAuthenticationChallenge in class
1561         DumpRenderTree.
1562
1563         Resubmit the patch reverted by r115104 after the digest infinite loop
1564         issue for BlackBerry porting get identified and fixed.
1565
1566         Internally reviewed by Joe Mason <jmason@rim.com>
1567
1568         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1569         (drtCredentialDescription):
1570         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1571         (WebKit):
1572         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1573         (WebCore):
1574         (DumpRenderTree):
1575
1576 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1577
1578         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1579         https://bugs.webkit.org/show_bug.cgi?id=42328
1580
1581         Reviewed by Eric Seidel.
1582
1583         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1584         move to windows.internals.settings.
1585
1586         * DumpRenderTree/LayoutTestController.cpp:
1587         (LayoutTestController::staticFunctions):
1588         * DumpRenderTree/LayoutTestController.h:
1589         (LayoutTestController):
1590         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1591         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1592         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1593         (DRTDevToolsAgent):
1594         * DumpRenderTree/chromium/LayoutTestController.cpp:
1595         (LayoutTestController::LayoutTestController):
1596         * DumpRenderTree/chromium/LayoutTestController.h:
1597         (LayoutTestController):
1598         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1599         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1600         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1601         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1602         * DumpRenderTree/mac/DumpRenderTree.mm:
1603         (resetWebViewToConsistentStateBeforeTesting):
1604         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1605         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1606         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1607         (LayoutTestController):
1608         * DumpRenderTree/win/DumpRenderTree.cpp:
1609         (resetWebViewToConsistentStateBeforeTesting):
1610         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1611         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1612         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1613         (LayoutTestController):
1614
1615 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1616
1617         Move allowRoundingHacks to Internals interface
1618         https://bugs.webkit.org/show_bug.cgi?id=87328
1619
1620         Reviewed by Hajime Morita.
1621
1622         Remove allowRoundingHacks functions, because it is able to work in the
1623         cross-port way through the Internals interface.
1624
1625         * DumpRenderTree/LayoutTestController.cpp:
1626         (LayoutTestController::staticFunctions):
1627         * DumpRenderTree/LayoutTestController.h:
1628         (LayoutTestController):
1629         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1630         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1631         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1634         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1635
1636 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1637
1638         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1639         https://bugs.webkit.org/show_bug.cgi?id=87616
1640
1641         Reviewed by Hajime Morita.
1642
1643         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1644         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1645         Patch just adds a #ifndef / #define check.
1646
1647         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1648         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1649
1650 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1651
1652         [EFL] Enable blob support for the EFL port
1653         https://bugs.webkit.org/show_bug.cgi?id=85363
1654
1655         Reviewed by Hajime Morita.
1656
1657         Enable Blob support by default for the EFL port.
1658
1659         * Scripts/webkitperl/FeatureList.pm:
1660
1661 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1662
1663         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1664         https://bugs.webkit.org/show_bug.cgi?id=87582
1665
1666         Reviewed by Darin Adler.
1667
1668         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1669         possible to test pages in a similar way as they are loaded in Browsers.
1670
1671         * DumpRenderTree/LayoutTestController.cpp:
1672         (LayoutTestController::LayoutTestController):
1673         (setUseDeferredFrameLoadingCallback):
1674         (LayoutTestController::staticFunctions):
1675         * DumpRenderTree/LayoutTestController.h:
1676         (LayoutTestController::useDeferredFrameLoading):
1677         (LayoutTestController::setUseDeferredFrameLoading):
1678         (LayoutTestController):
1679         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1680         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1681
1682 2012-05-27  David Barton  <dbarton@mathscribe.com>
1683
1684         [watchlist] Improve MathML rule
1685         https://bugs.webkit.org/show_bug.cgi?id=87592
1686
1687         Reviewed by Adam Barth.
1688
1689         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1690         but if this changed the rule would be slow. We protect against this, clarify the rule,
1691         and make it more similar to existing rules.
1692
1693         * Scripts/webkitpy/common/config/watchlist:
1694
1695 2012-05-27  David Barton  <dbarton@mathscribe.com>
1696
1697         [watchlist] Add myself & a rule for MathML
1698         https://bugs.webkit.org/show_bug.cgi?id=87586
1699
1700         Reviewed by Adam Barth.
1701
1702         * Scripts/webkitpy/common/config/watchlist:
1703
1704 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1705
1706         Use xcrun to find path to nm for Mac port
1707         <http://webkit.org/b/87588>
1708
1709         Reviewed by Dan Bernstein.
1710
1711         * Scripts/webkitpy/layout_tests/port/mac.py:
1712         (MacPort.nm_command): Add. Tries to find a path for the nm
1713         command using xcrun.  Falls back to returning 'nm'.
1714         * Scripts/webkitpy/layout_tests/port/webkit.py:
1715         (WebKitPort.nm_command): Add. Returns 'nm'.
1716         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1717
1718 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1719
1720         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1721
1722         Reviewed by Eric Seidel.
1723
1724         * DumpRenderTree/win/DumpRenderTree.vcproj:
1725         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1726         (FrameLoadDelegate::FrameLoadDelegate):
1727         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1728         * DumpRenderTree/win/FrameLoadDelegate.h:
1729         (FrameLoadDelegate):
1730         * DumpRenderTree/win/TextInputController.cpp: Added.
1731         (setMarkedTextCallback):
1732         (hasMarkedTextCallback):
1733         (unmarkTextCallback):
1734         (markedRangeCallback):
1735         (insertTextCallback):
1736         (firstRectForCharacterRangeCallback):
1737         (selectedRangeCallback):
1738         (TextInputController::makeWindowObject):
1739         (TextInputController::getJSClass):
1740         (TextInputController::staticValues):
1741         (TextInputController::staticFunctions):
1742         * DumpRenderTree/win/TextInputController.h: Added.
1743         (TextInputController):
1744         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1745         (TextInputController::setMarkedText):
1746         (TextInputController::hasMarkedText):
1747         (TextInputController::unmarkText):
1748         (TextInputController::markedRange):
1749         (TextInputController::insertText):
1750         (TextInputController::firstRectForCharacterRange):
1751         (TextInputController::selectedRange):
1752
1753 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1754
1755         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1756         https://bugs.webkit.org/show_bug.cgi?id=87528
1757
1758         Reviewed by Ojan Vafai.
1759
1760         launching git or svn for individual files can be slow; this
1761         change will hand multiple paths at once to git and svn so they
1762         can be added in a batch.
1763
1764         * Scripts/webkitpy/common/checkout/scm/git.py:
1765         (Git.add_list):
1766         (Git.delete_list):
1767         * Scripts/webkitpy/common/checkout/scm/scm.py:
1768         (SCM.add):
1769         (SCM):
1770         (SCM.add_list):
1771         (SCM.delete):
1772         (SCM.delete_list):
1773         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1774         (MockSCM.add):
1775         (MockSCM):
1776         (MockSCM.add_list):
1777         (MockSCM.delete):
1778         (MockSCM.delete_list):
1779         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1780         (_shared_test_exists):
1781         (_shared_test_added_files):
1782         (_test_delete_list):
1783         * Scripts/webkitpy/common/checkout/scm/svn.py:
1784         (SVN.add_list):
1785         (SVN.delete_list):
1786
1787 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1788
1789         [NRWT] Add unit testing for perf tests on locked shards
1790         https://bugs.webkit.org/show_bug.cgi?id=87489
1791
1792         Reviewed by Dirk Pranke.
1793
1794         Adding utests that makes sure that perf tests are running in locked
1795         shards and by passing --no-http won't break NRWT (r118421).
1796
1797         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1798         (ShardingTests):
1799         (ShardingTests.test_shard_by_dir):
1800         (ShardingTests.test_shard_every_file):
1801         (ShardingTests.test_shard_in_two):
1802         (ShardingTests.test_multiple_locked_shards):
1803         (LockCheckingManager):
1804         (LockCheckingManager.__init__):
1805         (LockCheckingManager.handle_finished_list):
1806         (ManagerTest.test_http_locking):
1807         (ManagerTest):
1808         (ManagerTest.test_perf_locking):
1809         * Scripts/webkitpy/layout_tests/port/test.py:
1810
1811 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1812
1813         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1814         https://bugs.webkit.org/show_bug.cgi?id=87511
1815
1816         Reviewed by Alexey Proskuryakov.
1817
1818         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1819
1820         * DumpRenderTree/win/EventSender.cpp:
1821         (keyDownCallback):
1822
1823 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1824
1825         Adding Ken Buchanan to committers.py
1826         https://bugs.webkit.org/show_bug.cgi?id=87443
1827
1828         Unreviewed.
1829
1830         Adding self to committers.py as a Committer.
1831
1832         * Scripts/webkitpy/common/config/committers.py:
1833
1834 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1835
1836         [Qt] Buildfix for newer Qt5
1837         https://bugs.webkit.org/show_bug.cgi?id=87257
1838
1839         Reviewed by Simon Hausmann.
1840
1841         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
1842
1843 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1844
1845         [Qt] Unreviewed fix after r118484.
1846
1847         Enable CSS_EXCLUSIONS and CSS_REGIONS.
1848         They were enabled uncoditinally before r118484.
1849
1850         * qmake/mkspecs/features/features.pri:
1851
1852 2012-05-24  Tim Horton  <timothy_horton@apple.com>
1853
1854         Add feature defines for web-facing parts of CSS Regions and Exclusions
1855         https://bugs.webkit.org/show_bug.cgi?id=87442
1856         <rdar://problem/10887709>
1857
1858         Reviewed by Dan Bernstein.
1859
1860         * Scripts/webkitperl/FeatureList.pm:
1861
1862 2012-05-24  Hironori Bono  <hbono@chromium.org>
1863
1864         Enable grammar checking on Chromium when we paste text (Take 2)
1865         https://bugs.webkit.org/show_bug.cgi?id=74393
1866
1867         Reviewed by Ryosuke Niwa.
1868
1869         This change enables grammar checking on Chromium and implements a mock grammar
1870         checker to fix a failing test.
1871
1872         * DumpRenderTree/DumpRenderTree.gypi:
1873         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1874         (MockGrammarCheck::checkGrammarOfString):
1875         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1876         (WebKit):
1877         (MockGrammarCheck):
1878         * DumpRenderTree/chromium/WebViewHost.cpp:
1879         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1880
1881 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1882
1883         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
1884         https://bugs.webkit.org/show_bug.cgi?id=86842
1885
1886         Reviewed by Antonio Gomes.
1887
1888         Add support for overriding the application cache support preference
1889         through EFL's LayoutTestController.
1890
1891         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1892         (LayoutTestController::overridePreference):
1893
1894 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1895
1896         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
1897         https://bugs.webkit.org/show_bug.cgi?id=85209
1898
1899         Reviewed by Antonio Gomes.
1900
1901         Set developer extras setting called twice on the test startup. Hence, removing
1902         an unnecessary extra call which set wrong value. 
1903
1904         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1905         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1906
1907 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1908
1909         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1910         https://bugs.webkit.org/show_bug.cgi?id=86916
1911
1912         Reviewed by Adam Barth.
1913
1914         Note that if release and debug are failing differently, debug
1915         will be ignored ...
1916
1917         Note: also change the use of a fake port name from
1918         "mock-port-name" to "test-mac-leopard" to make it more friendly
1919         to the port factory ("mock" actually is a real port).
1920
1921         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1922         (GardeningHTTPRequestHandler._builders_to_fetch_from):
1923         (GardeningHTTPRequestHandler.rebaselineall):
1924         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1925         (GardeningServerTest.test_rebaselineall):
1926         (GardeningServerTest.test_rebaseline_new_port):
1927
1928 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1929
1930         nrwt: fix baseline search path for official chrome builders
1931         https://bugs.webkit.org/show_bug.cgi?id=87432
1932
1933         Reviewed by Tony Chang.
1934
1935         The official chrome builders need to use the win7 and SL
1936         baseline paths, not the XP and Leopard paths. Linux is correct.
1937
1938         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1939         (GoogleChromeMacPort.determine_full_port_name):
1940         (GoogleChromeWinPort.determine_full_port_name):
1941         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1942         (TestGoogleChromePort._verify_baseline_search_path_startswith):
1943         (TestGoogleChromePort.test_get_google_chrome_port):
1944
1945 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1946
1947         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
1948         https://bugs.webkit.org/show_bug.cgi?id=86800
1949
1950         Reviewed by Dirk Pranke.
1951
1952         Don't launch a HTTP server with lock based only on the existence of
1953         locked shards since we now run perf on locked shards too.
1954
1955         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1956         (Manager._run_tests):
1957
1958 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
1959
1960         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1961         https://bugs.webkit.org/show_bug.cgi?id=87128
1962
1963         Reviewed by Dirk Pranke.
1964
1965         * Scripts/webkitpy/layout_tests/port/base.py:
1966         (Port.driver_name):
1967         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1968         (ChromiumLinuxPort._path_to_driver):
1969         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1970         (ChromiumPortTest.test_driver_name_option):
1971         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1972         (ChromiumWinPort._path_to_driver):
1973         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1974         (parse_args):
1975
1976 2012-05-24  John Mellor  <johnme@chromium.org>
1977
1978         Font Boosting: Add compile flag and runtime setting
1979         https://bugs.webkit.org/show_bug.cgi?id=87394
1980
1981         Reviewed by Adam Barth.
1982
1983         Add ENABLE_FONT_BOOSTING.
1984
1985         * Scripts/webkitperl/FeatureList.pm:
1986         * qmake/mkspecs/features/features.pri:
1987
1988 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1989
1990         [EFL] [DRT] keyboard-related tests do not pass
1991         https://bugs.webkit.org/show_bug.cgi?id=85369
1992
1993         Reviewed by Gustavo Noronha Silva.
1994
1995         Add SHIFT modifier for capital letters as VK_ 
1996         codes do not distinguish between lows and caps and also to be consistent
1997         with other ports which send caps as lowercase letters with the shift key down.
1998
1999         * DumpRenderTree/efl/EventSender.cpp:
2000         (keyNameFromJSValue): 
2001
2002 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2003
2004         [WK2] Let the client give local files universal access on a case by case basis
2005         https://bugs.webkit.org/show_bug.cgi?id=87174
2006         <rdar://problem/11024330>
2007
2008         Reviewed by Maciej Stachowiak.
2009
2010         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2011         Added initialization of a new structure member to prevent build failure.
2012
2013 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2014
2015         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2016         https://bugs.webkit.org/show_bug.cgi?id=87203
2017
2018         Reviewed by Andreas Kling.
2019
2020         Add the required changes to make
2021         fast/events/keydown-leftright-keys.html pass after r118001.
2022
2023         * DumpRenderTree/efl/EventSender.cpp:
2024         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2025         into the proper X11 keysym definitions.
2026
2027 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2028
2029         Unreviewed, rolling out r118352.
2030         http://trac.webkit.org/changeset/118352
2031         https://bugs.webkit.org/show_bug.cgi?id=87390
2032
2033         Caused 6 editing/spelling tests crash/fail on chromium in
2034         debug. (Requested by vsevik on #webkit).
2035
2036         * DumpRenderTree/DumpRenderTree.gypi:
2037         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2038         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2039         * DumpRenderTree/chromium/WebViewHost.cpp:
2040         (WebViewHost::finishLastTextCheck):
2041
2042 2012-05-24  Peter Beverloo  <peter@chromium.org>
2043
2044         Add John Mellor as a contributor
2045         https://bugs.webkit.org/show_bug.cgi?id=87389
2046
2047         Reviewed by Kenneth Rohde Christiansen.
2048
2049         John will be working on Font Boosting and is very involved with various
2050         web-facing subjects of Chrome for Android, such as viewport.
2051
2052         * Scripts/webkitpy/common/config/committers.py:
2053
2054 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2055
2056         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2057         https://bugs.webkit.org/show_bug.cgi?id=86840
2058
2059         Reviewed by Csaba Osztrogonác.
2060
2061         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2062         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2063         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2064         (LayoutTestController::setCacheModel): Implementation added.
2065
2066 2012-05-24  Hironori Bono  <hbono@chromium.org>
2067
2068         Enable grammar checking on Chromium when we paste text.
2069         https://bugs.webkit.org/show_bug.cgi?id=74393
2070
2071         Reviewed by Hajime Morita.
2072
2073         This change enables grammar checking on Chromium and implements a mock grammar
2074         checker to fix a failing test.
2075
2076         * DumpRenderTree/DumpRenderTree.gypi:
2077         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2078         (MockGrammarCheck::checkGrammarOfString):
2079         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2080         (WebKit):
2081         (MockGrammarCheck):
2082         * DumpRenderTree/chromium/WebViewHost.cpp:
2083         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2084
2085 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2086
2087         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2088
2089         * qmake/mkspecs/features/features.pri:
2090
2091 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2092
2093         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2094         https://bugs.webkit.org/show_bug.cgi?id=86867
2095
2096         Reviewed by Adam Barth.
2097
2098         Add implementation for sendWebIntentResponse() in EFL's
2099         LayoutTestController and add empty implementation for other ports.
2100
2101         * DumpRenderTree/LayoutTestController.cpp:
2102         (sendWebIntentResponseCallback):
2103         (LayoutTestController::staticFunctions):
2104         * DumpRenderTree/LayoutTestController.h:
2105         (LayoutTestController):
2106         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2107         (LayoutTestController::sendWebIntentResponse):
2108         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2109         (DumpRenderTreeChrome::currentIntentRequest):
2110         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2111         (DumpRenderTreeChrome::onFrameIntentNew):
2112         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2113         (DumpRenderTreeChrome):
2114         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2115         (LayoutTestController::sendWebIntentResponse):
2116         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2117         (LayoutTestController::sendWebIntentResponse):
2118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2119         (LayoutTestController::sendWebIntentResponse):
2120         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2121         (LayoutTestController::sendWebIntentResponse):
2122         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2123         (LayoutTestController::sendWebIntentResponse):
2124
2125 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2126
2127         [EFL] The EFL port has no support for title directionality
2128         https://bugs.webkit.org/show_bug.cgi?id=86462
2129
2130         Reviewed by Gustavo Noronha Silva.
2131
2132         Update "title,changed" signal handlers in DRT and EWebLauncher to
2133         reflect the change from const char* to Ewk_Text_With_Direction* type
2134         for the title.
2135
2136         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2137         (DumpRenderTreeChrome::onTitleChanged):
2138         * EWebLauncher/main.c:
2139         (title_set):
2140         (on_title_changed):
2141         (on_key_down):
2142
2143 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2144
2145         Change EFL debug build name with more detail one
2146         https://bugs.webkit.org/show_bug.cgi?id=87254
2147
2148         Reviewed by Ryosuke Niwa.
2149
2150         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2151         In addition, remove efl-linux-debug triggerable since nobody uses it.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/config.json:
2154
2155 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2156
2157         [EFL][DRT] Fix WebCore library path and rebaseline result
2158         https://bugs.webkit.org/show_bug.cgi?id=86355
2159
2160         Reviewed by Dirk Pranke.
2161
2162         Currently EFL DRT uses wrong WebCore library path when running DRT.
2163         Therefore, this patch adjusted the path correctly.
2164
2165         * Scripts/webkitpy/layout_tests/port/efl.py:
2166         (EflPort._path_to_webcore_library):
2167
2168 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2169
2170         add back the ability to disable flexbox
2171         https://bugs.webkit.org/show_bug.cgi?id=87147
2172
2173         Reviewed by Tony Chang.
2174
2175         * Scripts/webkitperl/FeatureList.pm:
2176
2177 2012-05-23  Tony Chang  <tony@chromium.org>
2178
2179         Remove the Chromium Grid Layout bot from the waterfall
2180         https://bugs.webkit.org/show_bug.cgi?id=87311
2181
2182         Reviewed by Ryosuke Niwa.
2183
2184         I removed the compiler define in r117613, so we don't need a separate
2185         bot to compile/test this code.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/config.json:
2188
2189 2012-05-23  Ian Vollick  <vollick@chromium.org>
2190
2191         Add vollick to list of contributors.
2192         https://bugs.webkit.org/show_bug.cgi?id=87305
2193
2194         Reviewed by Adam Barth.
2195
2196         * Scripts/webkitpy/common/config/committers.py:
2197
2198 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2199
2200         [Chromium-Android] Fix chromium_android_unittest
2201         https://bugs.webkit.org/show_bug.cgi?id=87196
2202
2203         Reviewed by Tony Chang.
2204
2205         Update unit tests after ChromiumAndroidPort supported apk based
2206         DumpRenderTree.
2207
2208         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2209         (ChromiumAndroidPortTest):
2210         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2211         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2212         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2213         (ChromiumAndroidDriverTest):
2214         (ChromiumAndroidDriverTest.setUp):
2215         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2216         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2217
2218 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2219
2220         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2221         https://bugs.webkit.org/show_bug.cgi?id=87303
2222
2223         Reviewed by Alexis Menard.
2224
2225         * Scripts/webkitpy/common/config/watchlist:
2226
2227 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2228
2229         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2230         https://bugs.webkit.org/show_bug.cgi?id=86916
2231
2232         Reviewed by Adam Barth.
2233
2234         This change pushes all of the logic for rebaselining a cluster
2235         of failures (a list of tests failing a list of suffixes on a
2236         list of bots) onto the server, so there is a single call from
2237         the web page; we will then be able to optimize the performance
2238         of the rebaselining better.
2239
2240         Also remove the 'optimizebaseline' entry point on garden-o-matic
2241         (and the client-side call) since we don't need it any more.
2242
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2245         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2246         (GardeningHTTPRequestHandler.rebaselineall):
2247         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2248
2249 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         Mac DRT should be able to load external URLs for replay performance tests
2252         https://bugs.webkit.org/show_bug.cgi?id=86191
2253
2254         Reviewed by Alexey Proskuryakov.
2255
2256         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2257         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2258         "DumpRenderTree http://localhost:8000/".
2259
2260         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2261         (isLocalhost):
2262         (hostIsUsedBySomeTestsToGenerateError):
2263         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2264
2265 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2266
2267         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2268         debug symbols for easier debugging.
2269         https://bugs.webkit.org/show_bug.cgi?id=87151
2270
2271         Reviewed by Kevin Ollivier.
2272
2273         * waf/build/settings.py:
2274         (common_configure):
2275
2276 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2277
2278         Unreviewed. Move myself to reviewers.
2279
2280         * Scripts/webkitpy/common/config/committers.py:
2281
2282 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2283
2284         [EFL] Implements the registerProtocolHandler method and option.
2285         https://bugs.webkit.org/show_bug.cgi?id=73638
2286
2287         Reviewed by Andreas Kling.
2288
2289         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2290
2291 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2292
2293         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2294         https://bugs.webkit.org/show_bug.cgi?id=87221
2295
2296         Reviewed by Martin Robinson.
2297
2298         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2299         rightShift key names into proper GDK key symbols.
2300
2301         * DumpRenderTree/gtk/EventSender.cpp:
2302         (createKeyPressEvent):
2303
2304 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2305
2306         [Qt] Make the web view's url property follow the active url
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=77554
2309
2310         Update  the location bar in the minibrowser to behave
2311         a bit more like normal browsers in terms of when the url will change
2312         and how active focus is handled.
2313
2314         Reviewed by Simon Hausmann.
2315
2316         * MiniBrowser/qt/qml/BrowserWindow.qml:
2317
2318 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2319
2320         [Qt] Remove references to $$QT_SOURCE_TREE
2321
2322         With a modularized Qt, it's ambigious. What we really want is qtbase,
2323         which qtcore is a proxy for (we assume it will always live in qtbase).
2324
2325         Reviewed by Tor Arne Vestbø.
2326
2327         * DumpRenderTree/qt/DumpRenderTree.pro:
2328
2329 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2330
2331         [Qt] Fix qmake conditional for c++-11 compat warnings
2332
2333         Reviewed by Tor Arne Vestbø.
2334
2335         * qmake/mkspecs/features/unix/default_post.prf:
2336
2337 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2338
2339         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2340         https://bugs.webkit.org/show_bug.cgi?id=85956
2341
2342         Reviewed by Gustavo Noronha Silva.
2343
2344         Catch new "load,provisional,failed" signal and print
2345         didFailProvisionalLoadWithError messages when LayoutTestController's
2346         dumpFrameLoadCallbacks() returns true. Also make sure the
2347         didFailLoadWithError message is not printed in case of provisional
2348         load failure.
2349
2350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2351         (DumpRenderTreeChrome::createView):
2352         (DumpRenderTreeChrome::onFrameCreated):
2353         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2354         (DumpRenderTreeChrome::onFrameLoadError):
2355         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2356         (DumpRenderTreeChrome):
2357
2358 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2359
2360         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2361         https://bugs.webkit.org/show_bug.cgi?id=86366
2362
2363         Reviewed by Antonio Gomes.
2364
2365         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2366
2367         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2368         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2369
2370 2012-05-22  Darin Adler  <darin@apple.com>
2371
2372         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2373         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2374
2375 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2376
2377         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2378         https://bugs.webkit.org/show_bug.cgi?id=86922
2379
2380         Because we have new platformInit() in TestShellAndroid.cpp, and
2381         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2382         is split into TestShellPosix.cpp and TestShellX11.cpp.
2383
2384         Reviewed by Kent Tamura.
2385
2386         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2387         * DumpRenderTree/DumpRenderTree.gypi:
2388         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2389         (platformInit):
2390         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2391         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2392         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2393         (AlarmHandler):
2394         (TestShell::waitTestFinished):
2395         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2396         (openStartupDialog): from TestShellGtk.cpp
2397         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2398         (setupFontconfig):
2399         (platformInit):
2400
2401 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2402
2403         [EFL][DRT] Implement touch event
2404         https://bugs.webkit.org/show_bug.cgi?id=86720
2405
2406         Reviewed by Hajime Morita.
2407
2408         Currently EFL DRT doesn't support touch event.
2409         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2410
2411         * DumpRenderTree/efl/EventSender.cpp:
2412         (TouchEventInfo::TouchEventInfo):
2413         (TouchEventInfo):
2414         (touchPointList):
2415         (sendTouchEvent):
2416         (addTouchPointCallback):
2417         (touchStartCallback):
2418         (updateTouchPointCallback):
2419         (touchMoveCallback):
2420         (cancelTouchPointCallback):
2421         (touchCancelCallback):
2422         (releaseTouchPointCallback):
2423         (touchEndCallback):
2424         (clearTouchPointsCallback):
2425         (setTouchModifierCallback):
2426         * Scripts/webkitperl/FeatureList.pm:
2427
2428 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2429
2430         [Chromium-Android] Fix chromium_android_unittest
2431         https://bugs.webkit.org/show_bug.cgi?id=87196
2432
2433         Not reviewed.
2434         Temporarily disable chromium_android_unittest.
2435
2436         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2437         (ChromiumAndroidPortTest):
2438         (ChromiumAndroidDriverTest):
2439
2440 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2441
2442         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2443         https://bugs.webkit.org/show_bug.cgi?id=64313
2444
2445         Reviewed by Jon Honeycutt.
2446
2447         Add it.
2448
2449         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2450         Make sure to generate the binding.
2451
2452         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2453         (WTR::LayoutTestController::setDefersLoading):
2454         Call WKBundlePageSetDefersLoading.
2455         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2456
2457 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2458
2459         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2460         https://bugs.webkit.org/show_bug.cgi?id=86923
2461
2462         chromium_android.py is modified to support running DumpRenderTree as
2463         an apk, so that we can run the tests (e.g. video) requiring features
2464         implemented in Java on Android.
2465
2466         Reviewed by Adam Barth.
2467
2468         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2469         (ChromiumAndroidPort.__init__):
2470         (ChromiumAndroidPort.default_child_processes):
2471         (ChromiumAndroidPort.check_wdiff):
2472         (ChromiumAndroidPort.check_build):
2473         (ChromiumAndroidPort.start_helper):
2474         (ChromiumAndroidPort.skipped_layout_tests):
2475         (ChromiumAndroidPort):
2476         (ChromiumAndroidPort._path_to_driver):
2477         (ChromiumAndroidPort._get_crash_log):
2478         (ChromiumAndroidPort._push_executable):
2479         (ChromiumAndroidPort._run_adb_command):
2480         (ChromiumAndroidPort._get_last_stacktrace):
2481         (ChromiumAndroidPort._get_logcat):
2482         (ChromiumAndroidPort._setup_performance):
2483         (ChromiumAndroidDriver):
2484         (ChromiumAndroidDriver.__init__):
2485         (ChromiumAndroidDriver._command_wrapper):
2486         (ChromiumAndroidDriver.cmd_line):
2487         (ChromiumAndroidDriver._file_exists_on_device):
2488         (ChromiumAndroidDriver._deadlock_detector):
2489         (ChromiumAndroidDriver._start):
2490         (ChromiumAndroidDriver.run_test):
2491         (ChromiumAndroidDriver.stop):
2492         (ChromiumAndroidDriver._write_command_and_read_line):
2493         (ChromiumAndroidDriver._output_image):
2494         (ChromiumAndroidDriver._get_stderr):
2495
2496 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2497
2498         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2499
2500         Unreviewed gardening.
2501
2502         * Scripts/webkitpy/layout_tests/port/base.py:
2503         (Port.driver_name):
2504         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2505         (ChromiumLinuxPort._path_to_driver):
2506         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2507         (ChromiumPortTest.test_overrides_and_builder_names):
2508         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2509         (ChromiumWinPort._path_to_driver):
2510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2511         (parse_args):
2512
2513 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2514
2515         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2516         https://bugs.webkit.org/show_bug.cgi?id=87176
2517
2518         Reviewed by Tony Chang.
2519
2520         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2521         * DumpRenderTree/DumpRenderTree.gypi:
2522
2523 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2524
2525         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2526         https://bugs.webkit.org/show_bug.cgi?id=87128
2527
2528         Reviewed by Dirk Pranke.
2529
2530         * Scripts/webkitpy/layout_tests/port/base.py:
2531         (Port.driver_name):
2532         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2533         (ChromiumLinuxPort._path_to_driver):
2534         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2535         (ChromiumPortTest.test_driver_name_option):
2536         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2537         (ChromiumWinPort._path_to_driver):
2538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2539         (parse_args):
2540
2541 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2542
2543         WTR fix after r118001.
2544
2545         Rubber-stamped by Alexey Proskuryakov.
2546
2547         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2548
2549         * WebKitTestRunner/mac/EventSenderProxy.mm:
2550         (WTR::EventSenderProxy::keyDown):
2551
2552 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2553
2554         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2555         https://bugs.webkit.org/show_bug.cgi?id=86684
2556
2557         Reviewed by Darin Fisher.
2558
2559         * DumpRenderTree/chromium/LayoutTestController.cpp:
2560         (LayoutTestController::numberOfPages):
2561         * DumpRenderTree/chromium/WebViewHost.cpp:
2562         (WebViewHost::printPage):
2563
2564 == Rolled over to ChangeLog-2012-05-22 ==