[Qt] Re-fix clean builds
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2
3         [Qt] Re-fix clean builds
4
5         Reviewed by Tor Arne Vestbø.
6
7         Re-introduce the sanitization for LIBS when creating a module to use
8         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
9         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
10         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
11         causes build issues when depending system libraries end up in LIBS before
12         LIBS_PRIVATE.
13
14         * qmake/mkspecs/features/default_post.prf:
15         * qmake/mkspecs/features/functions.prf:
16
17 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
18
19         Comment out a failing webkitpy unit test until Dirk can fix it.
20
21         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
22         (SemanticTests.test_skip_and_wontfix):
23
24 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
25
26         make Skip, WontFix be the only expectations on a line
27         https://bugs.webkit.org/show_bug.cgi?id=97225
28
29         Reviewed by Ojan Vafai.
30
31         It is now incorrect in the new syntax to have a line like:
32
33             foo.html [ WontFix Crash ]
34
35         This will generate a lint warning and be treated as an invalid
36         line. Fixing this caused a whole bunch of unit tests to need updating
37         to no longer be marked as WontFix :). Also, this patch adjusts
38         the warnings so that missing Bug() identifiers will cause lint
39         warnings but will *not* cause the line to be treated as invalid.
40         Fixing these issues also revealed that test_hung_thread was no
41         longer testing the right logic, so I adjusted the timeouts in
42         test.py to make that test work again.
43
44         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
45         (Worker._run_test_in_another_thread):
46         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
47         (ResultSummaryTest.test_summarized_results_wontfix):
48         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
49         (TestExpectationParser._parse_modifiers):
50         (TestExpectationParser._tokenize_line_using_new_format):
51         (TestExpectationLine.is_invalid):
52         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
53         (BasicTests.test_basic):
54         (test_get_test_set):
55         (test_parse_warning):
56         (test_pixel_tests_flag):
57         (SemanticTests.test_missing_bugid):
58         (SemanticTests):
59         (SemanticTests.test_skip_and_wontfix):
60         * Scripts/webkitpy/layout_tests/port/test.py:
61         (TestDriver.run_test):
62         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
63         (MainTest.test_hung_thread):
64         * Scripts/webkitpy/tool/commands/queries_unittest.py:
65         (PrintExpectationsTest.test_basic):
66         (PrintExpectationsTest.test_multiple):
67         (PrintExpectationsTest.test_full):
68         (PrintExpectationsTest.test_exclude):
69         (PrintExpectationsTest.test_csv):
70
71 2012-09-20  Lucas Forschler  <lforschler@apple.com>
72
73         Unreviewed.  Start running tests on the mac-ews.
74         
75         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
76         (MacEWS):
77
78 2012-09-20  Tony Chang  <tony@chromium.org>
79
80         [chromium] Enable more clang warnings
81         https://bugs.webkit.org/show_bug.cgi?id=97257
82
83         Reviewed by James Robinson.
84
85         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
86         there are lots of violations in these files.
87
88 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
89
90         run-perf-tests should record individual value instead of statistics
91         https://bugs.webkit.org/show_bug.cgi?id=97155
92
93         Reviewed by Hajime Morita.
94
95         Parse the list of individual value reported by tests and include them as "values".
96         We strip "values" from the output JSON when uploading it to the perf-o-matic
97         since it doesn't know how to parse "values" or ignore it.
98
99         * Scripts/webkitpy/performance_tests/perftest.py:
100         (PerfTest):
101         (PerfTest.parse_output): Parse and report "values".
102         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
103         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
104         (MainTest.test_parse_output):
105         (MainTest.test_parse_output_with_failing_line):
106         (TestPageLoadingPerfTest.test_run):
107         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
108         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
109         until we update perf-o-matic.
110         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
111         (test_run_memory_test):
112         (test_run_with_json_output):
113         (test_run_with_description):
114         (test_run_with_slave_config_json):
115         (test_run_with_multiple_repositories):
116
117 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
118
119         [Qt] Fix production builds
120
121         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
122
123         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
124
125         * qmake/mkspecs/features/functions.prf:
126
127 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
128
129         REGRESSION: layout test results doesn't show diffs
130         https://bugs.webkit.org/show_bug.cgi?id=97182
131
132         Reviewed by Ojan Vafai.
133
134         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
135         so that results.html (and hopefully garden-o-matic) can
136         determine which things actually failed. However, we keep mapping
137         these results to Failure so that we still only have a single
138         expectation type for them.
139
140         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
141         (JSONLayoutResultsGenerator):
142         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
143         (TestExpectationParser):
144         (TestExpectations):
145         (TestExpectations.result_was_expected):
146         * Scripts/webkitpy/layout_tests/models/test_failures.py:
147         (determine_result_type):
148         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
149         (MainTest.test_missing_and_unexpected_results):
150         (MainTest.test_retrying_and_flaky_tests):
151
152 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
153
154         MediaStream API: Extend UserMediaRequest with a ownerDocument method
155         https://bugs.webkit.org/show_bug.cgi?id=97095
156
157         Reviewed by Adam Barth.
158
159         Extending WebUserMediaClientMock to check that the owning document is valid,
160         and that the document has a frame.
161
162         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
163         (WebKit::WebUserMediaClientMock::requestUserMedia):
164
165 2012-09-20  Stephen Chenney  <schenney@chromium.org>
166
167         [Chromium] DRT does not support --dump-all-pixels flag
168         https://bugs.webkit.org/show_bug.cgi?id=95098
169
170         Reviewed by Dirk Pranke.
171
172         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
173         of this flag causes pixel results to be created for all tests, regardless of
174         individual test options. If an individual test provides a pixel hash it will be used,
175         otherwise the hash will be empty. This replaces a previously defined but unused option
176         --dump-all-pixels, and is useful primarily when debugging DRT instances.
177
178         * DumpRenderTree/chromium/DumpRenderTree.cpp:
179         (runTest): Add a parameter and code to force pixel results for the test.
180         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
181
182 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
183
184         [GTK] run-api-tests should not buffer test stdout
185         https://bugs.webkit.org/show_bug.cgi?id=88474
186
187         Reviewed by Philippe Normand.
188
189         * Scripts/run-gtk-tests:
190         (TestRunner._run_test_command): Use os.forkpty() instead of
191         subprocess.Popen() so that gtest sends the output with colors to
192         stdout. Use common.parse_output_lines() to parse the output and
193         write it to stdout while it's read.
194         (TestRunner._run_test_command.parse_line): Parse the line to get
195         the test pid and write the line to stdout.
196         (TestRunner._run_test_command.waitpid): Helper function to call
197         waitpid handling EINTR.
198         (TestRunner._run_test_command.return_code_from_exit_status):
199         Helper function to convert exit status of test commands to a
200         return code.
201         * gtk/common.py:
202         (parse_output_lines): Helper function that uses select to read
203         the given file descriptor and call the given callback for every
204         line read.
205
206 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
207
208         [Qt] Fix initial build
209
210         Reviewed by Tor Arne Vestbø.
211
212         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
213         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
214         causing incorrect linking for Makefile.api, etc.
215
216         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
217
218         * qmake/mkspecs/features/webkit_modules.prf:
219
220 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
221
222         Unreviewed, rolling out r129091.
223         http://trac.webkit.org/changeset/129091
224         https://bugs.webkit.org/show_bug.cgi?id=97205
225
226         It broke perf tests everywhere (Requested by Ossy on #webkit).
227
228         * Scripts/webkitpy/performance_tests/perftest.py:
229         (PerfTest):
230         (PerfTest.parse_output):
231         (PageLoadingPerfTest.run):
232         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
233         (MainTest.test_parse_output):
234         (MainTest.test_parse_output_with_failing_line):
235         (TestPageLoadingPerfTest.test_run):
236         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
237         (PerfTestsRunner._generate_and_show_results):
238         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
239         (test_run_memory_test):
240         (test_run_with_json_output):
241         (test_run_with_description):
242         (test_run_with_slave_config_json):
243         (test_run_with_multiple_repositories):
244
245 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
246
247         [Qt] QtWebKit module header includes private dependencies
248
249         Reviewed by Tor Arne Vestbø.
250
251         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
252         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
253         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
254         we can't do it in default_pre.
255         * qmake/mkspecs/features/webkit_modules.prf:
256
257 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
258
259         [Qt] Fix build with MingW
260
261         Reviewed by Tor Arne Vestbø.
262
263         Don't try to compile WebCore, etc. with debug symbols for production
264         builds, it's just too big.
265
266         * qmake/mkspecs/features/production_build.prf:
267
268 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
269
270         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
271         https://bugs.webkit.org/show_bug.cgi?id=97087
272
273         Reviewed by Gyuyoung Kim.
274
275         Add focusing a main frame on settings reset.
276         After editing/undo/undo-iframe-location-change was executed a frame
277         was left in unfocused state. This caused flakiness in two tests results.
278
279         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
280         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
281
282 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
283
284         [Qt] Add eventSender.gestureTap
285         https://bugs.webkit.org/show_bug.cgi?id=66173
286
287         Reviewed by Kenneth Rohde Christiansen.
288
289         Implement support for sending raw QGesture events.
290
291         * DumpRenderTree/qt/EventSenderQt.cpp:
292         (EventSender::EventSender):
293         (EventSender::gestureTap):
294         * DumpRenderTree/qt/EventSenderQt.h:
295         (EventSender):
296
297 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
298
299         Unreviewed, rolling out r129007.
300         http://trac.webkit.org/changeset/129007
301         https://bugs.webkit.org/show_bug.cgi?id=97172
302
303         It broke the build on the Qt bots (Requested by Ossy on
304         #webkit).
305
306         * qmake/config.tests/gccdepends/empty.cpp:
307         * qmake/config.tests/gccdepends/gccdepends.pro:
308         * qmake/mkspecs/features/default_pre.prf:
309
310 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
311
312         run-perf-tests should record indivisual value instead of statistics
313         https://bugs.webkit.org/show_bug.cgi?id=97155
314
315         Reviewed by Hajime Morita.
316
317         Parse the list of indivisual value reported by tests and include them as "values".
318         We strip "values" from the output JSON when uploading it to the perf-o-matic
319         since it doesn't know how to parse "values" or ignore it.
320
321         * Scripts/webkitpy/performance_tests/perftest.py:
322         (PerfTest):
323         (PerfTest.parse_output): Parse and report "values".
324         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
325         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
326         (MainTest.test_parse_output):
327         (MainTest.test_parse_output_with_failing_line):
328         (TestPageLoadingPerfTest.test_run):
329         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
330         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
331         until we update perf-o-matic.
332         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
333         (test_run_memory_test):
334         (test_run_with_json_output):
335         (test_run_with_description):
336         (test_run_with_slave_config_json):
337         (test_run_with_multiple_repositories):
338
339 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
340
341         Fix regex groups for bug matching in flakiness dashboard.
342         https://bugs.webkit.org/show_bug.cgi?id=97152
343
344         Unreviewed, build fix.
345
346         * TestResultServer/static-dashboards/flakiness_dashboard.js:
347         (htmlForBugs):
348
349 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
350
351         nrwt: print unexpected results using new TestExpectations syntax
352         https://bugs.webkit.org/show_bug.cgi?id=97159
353
354         Unreviewed, build fix.
355
356         Change new-run-webkit-tests to print out failures using the new
357         syntax when there are unexpected results, e.g.:
358
359         52 tests ran as expected, 19 didn't:
360
361
362         Regressions: Unexpected failures : (2)
363           failures/flaky/text.html [ Failure ]
364           failures/unexpected/text-image-checksum.html [ Failure ]
365
366         and so forth
367
368         * Scripts/webkitpy/layout_tests/views/printing.py:
369         (Printer._print_unexpected_results):
370
371 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
372
373         update flakiness dashboard after cutover to new test expectations syntax
374         https://bugs.webkit.org/show_bug.cgi?id=97152
375
376         Unreviewed, build fix.
377
378         Handle (??) the new Bug notations as well. Hopefully we don't
379         still need the old ones.
380
381         * TestResultServer/static-dashboards/flakiness_dashboard.js:
382         (filterBugs):
383         (htmlForBugs):
384         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
385
386 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
387
388         update flakiness dashboard after cutover to new test expectations syntax
389         https://bugs.webkit.org/show_bug.cgi?id=97152
390
391         Reviewed by Ryosuke Niwa.
392
393         This change clones the TestExpectation parsing state machine
394         from python into javascript.
395
396         * TestResultServer/static-dashboards/flakiness_dashboard.js:
397         (parsedExpectations.lines.forEach):
398         (parsedExpectations):
399         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
400
401 2012-09-19  Dana Jansens  <danakj@chromium.org>
402
403         Add backer@chromium.org as contributor
404         https://bugs.webkit.org/show_bug.cgi?id=97150
405
406         * Scripts/webkitpy/common/config/committers.py:
407
408 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
409
410         fix MISSING after TestExpectations conversion
411         https://bugs.webkit.org/show_bug.cgi?id=97148
412
413         Unreviewed, expectations change / build fix.
414
415         * Scripts/convert-test-expectations:
416         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
417         (TestExpectationParser):
418
419 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
420
421         nrwt: convert chromium TestExpectations to the new syntax
422         https://bugs.webkit.org/show_bug.cgi?id=97139
423
424         Reviewed by Ryosuke Niwa.
425     
426         Add in a file temporarily that does the conversion of
427         test expectations formats
428
429         * Tools/Scripts/convert-test-expectations: Added.
430
431 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
432
433         REGRESSION: run-perf-tests no longer reports the total test time
434         https://bugs.webkit.org/show_bug.cgi?id=97138
435
436         Reviewed by Tony Chang.
437
438         Report the finished time as a info-level log as opposed to a debug level log.
439
440         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
441         (PerfTestsRunner._run_single_test):
442         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
443         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
444         (test_run_test_pause_before_testing):
445         (test_run_test_set_for_parser_tests):
446         (test_run_memory_test):
447         (_test_run_with_json_output):
448
449 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
450
451         Support new TestExpectations format alongside old one
452         https://bugs.webkit.org/show_bug.cgi?id=96588
453
454         Reviewed by Ojan Vafai.
455
456         This patch adds support for actually reading in lines formatted
457         in the new style, and when we re-serialize/write out the file,
458         all lines will be written in the new style. Note that reading in
459         the old style is still supported, and no updates are being made
460         to the actual TestExpectations files as part of this change.
461
462         This change updates most but not all of the unit tests to use
463         the new syntax. I will update the rest when (or before where
464         possible) I drop support for the old format.
465
466         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
467         (TestExpectationParser):
468         (TestExpectationParser._tokenize_line):
469         (TestExpectationParser._tokenize_line_using_new_format):
470         (TestExpectationLine.to_string):
471         (TestExpectationLine._format_line):
472         (TestExpectations):
473         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
474         (test_parse_warning):
475         (SkippedTests.test_skipped_entry_dont_exist):
476         (NewExpectationSyntaxTests.test_warnings):
477         (RemoveConfigurationsTest.test_remove):
478         (test_remove_line):
479         (RebaseliningTest.test_remove):
480         (RebaseliningTest.test_no_get_rebaselining_failures):
481         (TestExpectationParserTests.test_tokenize_blank):
482         (TestExpectationParserTests.test_tokenize_extra_colon):
483         (TestExpectationParserTests.test_tokenize_missing_equal):
484         (TestExpectationParserTests.test_tokenize_extra_equal):
485         (TestExpectationSerializationTests.test_unparsed_to_string):
486         (TestExpectationSerializationTests.test_unparsed_list_to_string):
487         (TestExpectationSerializationTests.test_parsed_to_string):
488         (TestExpectationSerializationTests.test_format_line):
489         (TestExpectationSerializationTests.test_string_roundtrip):
490         (TestExpectationSerializationTests.test_list_roundtrip):
491         (TestExpectationSerializationTests.test_reconstitute_only_these):
492         (TestExpectationSerializationTests.test_string_whitespace_stripping):
493         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
494         (LintTest.test_lint_test_files__errors):
495         * Scripts/webkitpy/tool/commands/queries_unittest.py:
496         (PrintExpectationsTest.test_basic):
497         (PrintExpectationsTest.test_multiple):
498         (PrintExpectationsTest.test_full):
499         (PrintExpectationsTest.test_exclude):
500         * Scripts/webkitpy/tool/commands/rebaseline.py:
501         (RebaselineExpectations.execute):
502         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
503         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
504         (test_rebaseline_updates_expectations_file):
505         (test_rebaseline_does_not_include_overrides):
506         (test_rebaseline_expectations_noop):
507         (test_overrides_are_included_correctly):
508
509 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
510
511         implement first part of support for the new TestExpectations syntax
512         https://bugs.webkit.org/show_bug.cgi?id=96569
513
514         Reviewed by Ryosuke Niwa.
515
516         This patch implements support for parsing a line of the new
517         format for the TestExpectations file and converting it back into
518         the old format for compatibility. This routine is not yet used
519         by anything.
520
521         The new format is documented at:
522           http://trac.webkit.org/wiki/TestExpectations
523
524         but, in short:
525
526           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
527
528         - Comments are indicated with "#" instead of "//"
529         - If no expectations are specified we default to Skip for
530           compatibility with the Skipped files (these two changes make
531           Skipped files a subset of TestExpectations files)
532
533         - All of the tokens are now CamelCase instead of ALLCAPS.
534         - FAIL -> Failure
535         - IMAGE -> ImageOnlyFailure
536         - WONTFIX -> WontFix
537         - modifiers refer to just the platforms and configurations
538           (release/debug) that the line applies to.
539         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
540           expectations
541         - expectations will typically be written out in lexicographic order
542         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
543           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
544
545         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
546         (TestExpectationParser):
547         (TestExpectationParser._tokenize_line_using_new_format):
548         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
549         (NewExpectationSyntaxTests):
550         (NewExpectationSyntaxTests.assert_exp):
551         (NewExpectationSyntaxTests.test_bare_name):
552         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
553         (NewExpectationSyntaxTests.test_comments):
554         (NewExpectationSyntaxTests.test_config_modifiers):
555         (NewExpectationSyntaxTests.test_unknown_config):
556         (NewExpectationSyntaxTests.test_unknown_expectation):
557         (NewExpectationSyntaxTests.test_skip):
558         (NewExpectationSyntaxTests.test_slow):
559         (NewExpectationSyntaxTests.test_wontfix):
560         (NewExpectationSyntaxTests.test_blank_line):
561         (NewExpectationSyntaxTests.test_warnings):
562
563 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
564
565         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
566         https://bugs.webkit.org/show_bug.cgi?id=96845
567
568         Reviewed by Ojan Vafai.
569
570         In preparation for the new TestExpectations syntax, we replace
571         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
572         make switching to the new syntax lossless (i.e., we lose
573         information now, not then).
574
575         Note that we can still parse in results.json files that have the
576         old data for backwards compatibility.
577         
578
579         * Scripts/webkitpy/common/net/resultsjsonparser.py:
580         (JSONTestResult._failure_types_from_actual_result):
581         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
582         (ResultsJSONParserTest):
583         (test_basic):
584         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
585         (ResultSummaryTest.test_summarized_results_wontfix):
586         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
587         (JSONLayoutResultsGenerator):
588         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
589         (TestExpectations):
590         (TestExpectations.remove_pixel_failures):
591         (TestExpectations.has_pixel_failures):
592         (TestExpectations.suffixes_for_expectations):
593         (TestExpectations.get_rebaselining_failures):
594         (TestExpectations.remove_configuration_from_test):
595         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
596         (assert_bad_expectations):
597         (BasicTests):
598         (BasicTests.test_basic):
599         (MiscTests):
600         (MiscTests.test_multiple_results):
601         (MiscTests.test_result_was_expected):
602         (MiscTests.test_remove_pixel_failures):
603         (MiscTests.test_suffixes_for_expectations):
604         (test_get_expectations_string):
605         (test_parse_warning):
606         (test_error_on_different_platform):
607         (test_error_on_different_build_type):
608         (test_overrides):
609         (test_overrides__directory):
610         (test_overrides__duplicate):
611         (test_pixel_tests_flag):
612         (test_more_specific_override_resets_skip):
613         (SkippedTests.test_skipped_file_overrides_expectations):
614         (SkippedTests.test_skipped_dir_overrides_expectations):
615         (SkippedTests.test_skipped_file_overrides_overrides):
616         (SkippedTests.test_skipped_dir_overrides_overrides):
617         (ExpectationSyntaxTests.test_missing_colon):
618         (ExpectationSyntaxTests.test_too_many_equals_signs):
619         (SemanticTests.test_bug_format):
620         (SemanticTests.test_bad_bugid):
621         (SemanticTests.test_missing_bugid):
622         (SemanticTests.test_rebaseline):
623         (test_missing_file):
624         (test_more_modifiers):
625         (test_order_in_file):
626         (test_macro_overrides):
627         (RemoveConfigurationsTest.test_remove):
628         (test_remove_line):
629         (RebaseliningTest.test_remove):
630         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
631         * Scripts/webkitpy/layout_tests/models/test_failures.py:
632         (determine_result_type):
633         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
634         (test_test_expectations):
635         * Scripts/webkitpy/layout_tests/port/test.py:
636         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
637         (MainTest.test_missing_and_unexpected_results):
638         (MainTest.test_retrying_and_flaky_tests):
639         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
640         (TestExpectationsTestCase.test_valid_expectations):
641         * Scripts/webkitpy/tool/commands/queries_unittest.py:
642         (PrintExpectationsTest.test_basic):
643         (PrintExpectationsTest.test_multiple):
644         (PrintExpectationsTest.test_full):
645         (PrintExpectationsTest.test_exclude):
646         (PrintExpectationsTest.test_csv):
647         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
648         (test_rebaseline_does_not_include_overrides):
649         (test_overrides_are_included_correctly):
650
651 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
652
653         AX: A few control types are returning the wrong answer for isReadOnly
654         https://bugs.webkit.org/show_bug.cgi?id=96735
655
656         Reviewed by Chris Fleizach.
657
658         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
659
660         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
661         (AccessibilityUIElement::AccessibilityUIElement):
662         (AccessibilityUIElement::isReadOnlyGetterCallback):
663         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
664         (AccessibilityUIElement):
665
666 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
667
668         [WTR] Memory leaks in TestRunner::deliverWebIntent()
669         https://bugs.webkit.org/show_bug.cgi?id=97111
670
671         Reviewed by Kenneth Rohde Christiansen.
672
673         Fix memory leaks in deliverWebIntent() by adopting strings
674         created with WKStringCreateWithUTF8CString().
675
676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
677         (WTR::TestRunner::deliverWebIntent):
678
679 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
680
681         [Qt] Fix incremental builds with all-in-one-files and gccdepends
682
683         Reviewed by Tor Arne Vestbø.
684
685         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
686         are not only created for header files but also for .cpp files. AllInOne.cpp files
687         include other .cpp files, and when those are removed we need those dummy rules to
688         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
689
690         * qmake/config.tests/gccdepends/empty.cpp:
691         (main):
692         * qmake/config.tests/gccdepends/gccdepends.pro:
693         * qmake/mkspecs/features/default_pre.prf:
694
695 2012-09-19  Rick Byers  <rbyers@chromium.org>
696
697         Do touch adjustment on GestureTapDown
698         https://bugs.webkit.org/show_bug.cgi?id=96677
699
700         Reviewed by Antonio Gomes.
701
702         Allow radius to be set for GestureTapDown events.
703         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
704         (EventSender::gestureEvent):
705
706 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
707
708         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
709         https://bugs.webkit.org/show_bug.cgi?id=97100
710
711         Reviewed by Gyuyoung Kim.
712
713         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
714         preference, in order to match WebKitTestRunner functionality.
715
716         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
717         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
718         * DumpRenderTree/efl/TestRunnerEfl.cpp:
719         (TestRunner::overridePreference):
720
721 2012-09-18  Kangil Han  <kangil.han@samsung.com>
722
723         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
724         https://bugs.webkit.org/show_bug.cgi?id=96181
725
726         Reviewed by Daniel Bates.
727
728         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
729
730         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
731         (new):
732         (_parseLicenseBlock):
733         (_parseLicenseBlockFromFile):
734         (_defaultLicenseBlock):
735         (_licenseBlock):
736         (_generateHeaderFile):
737         (_generateImplementationFile):
738
739 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
740
741         Title string should be changed when document.title is set to ''.
742         https://bugs.webkit.org/show_bug.cgi?id=96793
743
744         Reviewed by Kenneth Rohde Christiansen.
745
746         Change dump format of dumpTitleChanges more understandable.
747         Uses single quotation marks for the title string.
748
749         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
750         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
751         * DumpRenderTree/chromium/WebViewHost.cpp:
752         (WebViewHost::didReceiveTitle):
753         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
754         (DumpRenderTreeChrome::onFrameTitleChanged):
755         * DumpRenderTree/gtk/DumpRenderTree.cpp:
756         (webViewTitleChanged):
757         * DumpRenderTree/mac/FrameLoadDelegate.mm:
758         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
759         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
760         (WebCore::DumpRenderTree::titleChanged):
761         * DumpRenderTree/win/FrameLoadDelegate.cpp:
762         (FrameLoadDelegate::didReceiveTitle):
763         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
764         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
765         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
766         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
767
768 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
769
770         EWS shouldn't sleep if there are new patches in its queue
771         https://bugs.webkit.org/show_bug.cgi?id=83038
772
773         Reviewed by Eric Seidel.
774
775         EWS tries to process a security patch. Of course it can't, because the EWS isn't
776         the member of the security group. But the problem is that after it can't process
777         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
778         and push the security patch to the end of the queue.
779         Now it stays in the loop until it finds a patch or the queue gets empty.
780
781         * Scripts/webkitpy/tool/commands/queues.py:
782         (AbstractPatchQueue._next_patch):
783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
784         (AbstractPatchQueueTest.test_next_patch):
785
786 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
787
788         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
789         https://bugs.webkit.org/show_bug.cgi?id=97014
790
791         Reviewed by Kenneth Rohde Christiansen.
792
793         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
794         be used for literals rather than WTF::StringBuilder::append().
795
796         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
797         (WTR::InjectedBundle::booleanForKey):
798
799 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
800
801         Update my e-mail address.
802
803         * Scripts/webkitpy/common/config/committers.py:
804
805 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
806
807         Update my e-mail address.
808
809         Unreviewed.
810
811         * Scripts/webkitpy/common/config/committers.py:
812
813 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
814
815         [Qt] qt_webkit.pri should not be listed in Tools.pro
816
817         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
818
819         Since r128751 the module pri file is auto-generated
820         but it was still listed in OTHER_FILES.
821
822         * Tools.pro: Remove unneeded line.
823
824 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
825
826         [Qt] Fix build with some versions of the gold linker
827
828         Reviewed by Tor Arne Vestbø.
829
830         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
831         Instead run a compile/link test first to see if it works.
832
833         * qmake/config.tests/gnuld/gnuld.pro: Added.
834         * qmake/config.tests/gnuld/main.cpp: Added.
835         (main):
836         * qmake/mkspecs/features/unix/default_post.prf:
837
838 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
839
840         [Qt] Remove forced use of gold.
841
842         Reviewed by Tor Arne Vestbø.
843
844         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
845         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
846         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
847
848         * qmake/mkspecs/features/unix/default_post.prf:
849
850 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
851
852         [Qt] Prospective Qt/Windows cross-compiling fix
853
854         Reviewed by Tor Arne Vestbø.
855
856         The win32 scope is not set when cross-compiling from Linux to Windows.
857
858         * qmake/mkspecs/features/functions.prf:
859
860 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
861
862         [EFL] Remove background view on EWebLauncher and MiniBrowser
863         https://bugs.webkit.org/show_bug.cgi?id=96905
864
865         Reviewed by Gyuyoung Kim.
866
867         The size of webview was changed after adding url bar.
868         And the background view is not necessary anymore, since it was used for debugging back in the day.
869
870         * EWebLauncher/main.c:
871         (_ELauncher):
872         (on_ecore_evas_resize):
873         (browserCreate):
874         * MiniBrowser/efl/main.c:
875         (_MiniBrowser):
876         (on_ecore_evas_resize):
877         (browserCreate):
878
879 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
880
881         [GTK] run-webkit-tests unable to find TestExpectations for WK2
882         https://bugs.webkit.org/show_bug.cgi?id=96998
883
884         Reviewed by Philippe Normand.
885
886         We should look for TestExpectations files in all the locations where
887         we currently look for Skipped files. This will allow
888         run-webkit-tests to look for TestExpectations files in
889         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
890
891         * Scripts/webkitpy/layout_tests/port/gtk.py:
892         (GtkPort.expectations_files):
893
894 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
895
896         [Qt] Fix build without the QtQuick module
897
898         Reviewed by Simon Hausmann.
899
900         * qmake/mkspecs/features/features.prf:
901
902 2012-09-18  Stephanie Lewis  <slewis@apple.com>
903
904         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
905
906         Unreviewed.
907
908         * DumpRenderTree/mac/DumpRenderTree.mm:
909         (poseAsClass):
910
911 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
912
913         Unreviewed update of email addresses for Berlin QtWebKit office.
914
915         * Scripts/webkitpy/common/config/committers.py:
916
917 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
918
919         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
920         https://bugs.webkit.org/show_bug.cgi?id=96899
921
922         Reviewed by Martin Robinson.
923
924         When overriding the 'WebKitDisplayImageKey' preference, use the
925         'auto-load-images' property of WebKitWebSettings as the property which
926         should be updated with the corresponding preference value.
927
928         * DumpRenderTree/gtk/DumpRenderTree.cpp:
929         (resetDefaultsToConsistentValues):
930         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
931         (TestRunner::overridePreference):
932
933 2012-09-17  Pratik Solanki  <psolanki@apple.com>
934
935         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
936         https://bugs.webkit.org/show_bug.cgi?id=96973
937
938         Reviewed by Dan Bernstein.
939
940         * DumpRenderTree/mac/Configurations/Base.xcconfig:
941         * WebKitTestRunner/Configurations/Base.xcconfig:
942         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
943
944 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
945
946         nrwt: remove "unexpected EOF" warnings
947         https://bugs.webkit.org/show_bug.cgi?id=96970
948
949         Reviewed by Ojan Vafai.
950
951         After debugging this a bit, it looks like there aren't any cases
952         that I can reproduce where a read() of zero indicates something
953         actually wrong; either it is a prelude to a crash, or a false
954         negative. So, I'm removing these warnings and adding a comment.
955
956         * Scripts/webkitpy/layout_tests/port/server_process.py:
957         (ServerProcess._wait_for_data_and_update_buffers_using_select):
958
959 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
960
961         [chromium] ASAN bot is crashing at the end of the run
962         https://bugs.webkit.org/show_bug.cgi?id=96967
963
964         Reviewed by Abhishek Arya.
965
966         The ASAN bot is crashing attempting to decode some output into
967         UTF-8; there's no reason to do this, so let's not do this and
968         see if something else is going on as well.
969
970         * Scripts/webkitpy/layout_tests/port/chromium.py:
971         (ChromiumPort._get_crash_log):
972
973 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
974
975         nrwt: --results-directory isn't getting printed properly
976         https://bugs.webkit.org/show_bug.cgi?id=96965
977
978         Reviewed by Ojan Vafai.
979
980         options.results_directory isn't actually initialized with the
981         default values until after we call print_config(), so this
982         changes things to print the value directly.
983
984         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
985         (run):
986         * Scripts/webkitpy/layout_tests/views/printing.py:
987         (Printer.print_config):
988         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
989         (Testprinter.test_print_config):
990
991 2012-09-17  Rob Buis  <rbuis@rim.com>
992
993         [BlackBerry] Enable VIDEO_TRACK
994         https://bugs.webkit.org/show_bug.cgi?id=96949
995
996         Reviewed by Antonio Gomes.
997
998         * Scripts/webkitperl/FeatureList.pm:
999
1000 2012-09-17  Rick Byers  <rbyers@chromium.org>
1001
1002         Add handling of new GestureTapCancel in DRT
1003
1004         https://bugs.webkit.org/show_bug.cgi?id=96183
1005
1006         Reviewed by Antonio Gomes.
1007
1008         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1009         (TestWebPlugin::handleInputEvent):
1010         * DumpRenderTree/chromium/EventSender.cpp:
1011         (EventSender::gestureTapCancel):
1012
1013 2012-09-17  Philip Rogers  <pdr@google.com>
1014
1015         Teach style checker about preprocessor directive indentation rules
1016         https://bugs.webkit.org/show_bug.cgi?id=96874
1017
1018         Reviewed by Adam Barth.
1019
1020         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
1021         This is not explicit in our style guide but is generally followed in our code.
1022         Searching for violations in our codebase shows these are rarely indented:
1023             #include - indented in 6 files
1024             #ifdef - indented in 0 files
1025             #ifndef - indented in 1 file
1026             #define - indented in 11 files
1027             #if - indented in 7 files
1028
1029         * Scripts/webkitpy/style/checkers/cpp.py:
1030         (check_directive_indentation):
1031
1032             This is the simple test where we look for spaces followed by a #.
1033
1034         (check_style):
1035         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1036
1037             A few tests needed to be modified because they had unintentionally indented
1038             preprocessor directives.
1039
1040         (CppStyleTest.test_build_class.Foo):
1041         (CppStyleTest.test_build_class):
1042         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
1043         (WebKitStyleTest.test_line_breaking):
1044         (WebKitStyleTest.test_directive_indentation):
1045
1046 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1047
1048         [Qt] Auto-generate the module pri file for QtWebKit
1049
1050         Reviewed by Simon Hausmann.
1051
1052         * qmake/qt_webkit.pri: Removed.
1053
1054 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
1055
1056         nrwt: --additional-platform-dir is broken on chromium ports
1057         https://bugs.webkit.org/show_bug.cgi?id=96840
1058
1059         Reviewed by Ojan Vafai.
1060
1061         Looks like I broke this when cleaning things up as part of
1062         adding ML support. Fixing and adding a test.
1063
1064         * Scripts/webkitpy/layout_tests/port/chromium.py:
1065         (ChromiumPort.default_baseline_search_path):
1066         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1067         (ChromiumAndroidPort.default_baseline_search_path):
1068         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1069         (ChromiumLinuxPort.default_baseline_search_path):
1070         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1071         (ChromiumMacPort.__init__):
1072         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1073         (ChromiumWinPort.setup_environ_for_server):
1074         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1075         (test_check_build):
1076         (test_additional_platform_directory):
1077
1078 2012-09-13  Stephanie Lewis  <slewis@apple.com>
1079
1080         mac-future ignores previous platform TestExpectations.
1081         https://bugs.webkit.org/show_bug.cgi?id=96718.
1082
1083         Reviewed by Dirk Pranke.
1084
1085         TestExpectations match an expectation's configuraton against a list of configurations that are 
1086         valid for that port.  That list does not contain mac-future so none of the expectations can be
1087         applied.
1088
1089         * Scripts/webkitpy/layout_tests/port/apple.py:
1090         (ApplePort._generate_all_test_configurations):
1091
1092 2012-09-14  Adam Barth  <abarth@webkit.org>
1093
1094         Remove webkitPostMessage
1095         https://bugs.webkit.org/show_bug.cgi?id=96577
1096
1097         Reviewed by Ojan Vafai.
1098
1099         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
1100
1101         * Scripts/webkitperl/FeatureList.pm:
1102         * qmake/mkspecs/features/features.pri:
1103
1104 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
1105
1106         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
1107         https://bugs.webkit.org/show_bug.cgi?id=96817
1108
1109         Reviewed by Kenneth Rohde Christiansen.
1110
1111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1112         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
1113         got overlooked when adding logging elsewhere.
1114
1115 2012-09-14  Peter Beverloo  <peter@chromium.org>
1116
1117         [Chromium] Build fix for DumpRenderTree following r128628
1118         https://bugs.webkit.org/show_bug.cgi?id=96808
1119
1120         Reviewed by Tony Chang.
1121
1122         When building DumpRenderTree from the Chromium project, a compile error
1123         shows up because including the header ForwardIOStreamsAndroid.h cannot
1124         be located. TestWebKitAPI does this correctly.
1125
1126         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1127
1128 2012-09-14  Dana Jansens  <danakj@chromium.org>
1129
1130         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
1131         https://bugs.webkit.org/show_bug.cgi?id=96805
1132
1133         Reviewed by Dirk Pranke.
1134
1135         * Scripts/webkitpy/common/config/committers.py:
1136         * Scripts/webkitpy/common/config/watchlist:
1137
1138 2012-09-14  Peter Beverloo  <peter@chromium.org>
1139
1140         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
1141         https://bugs.webkit.org/show_bug.cgi?id=96687
1142
1143         Reviewed by Tony Chang.
1144
1145         Android's DumpRenderTree currently supports these arguments, implemented
1146         as part of TestShellAndroid:
1147         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
1148
1149         They're used by the layout test runner to get the STDOUT and STDERR while
1150         a layout test run is in process, which is a safer alternative to parsing
1151         all the logcat output manually. The implementation can be seen here:
1152         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
1153
1154         This patch generalizes parsing of and applying the effects of these arguments
1155         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
1156         After this patch, this will make it possible to pull out the output-reading
1157         code from Android's layout test port and generalize it so it can be re-used
1158         in the new test-runner for the other two test suites.
1159
1160         This has no effect when compiling and running these tests as part of Chromium
1161         code, which has a much more advanced test-runner that does parse complete log
1162         output, but also directly depends on code licensed under Apache 2.
1163
1164         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1165         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1166         (platformInit):
1167         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1168
1169 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
1170
1171         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
1172         https://bugs.webkit.org/show_bug.cgi?id=96656
1173
1174         Reviewed by Adam Barth.
1175
1176         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
1177         macros in 1 line.
1178
1179         * Scripts/webkitpy/style/checkers/cpp.py:
1180         (check_style.definitions):
1181         (check_style): Add rule.
1182         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1183         (WebKitStyleTest.test_line_breaking): Add unittest.
1184
1185 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1186
1187         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
1188         https://bugs.webkit.org/show_bug.cgi?id=57570
1189
1190         Reviewed by Kenneth Rohde Christiansen.
1191
1192         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
1193         and dump the information expected by the test cases.
1194
1195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1196         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1197         (WTR::InjectedBundle::beginTesting): Explicitly set the default
1198         database quota.
1199         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1200         (WTR::securityOriginToStr): New convenience function to convert
1201         a security origin to the string expected in test results.
1202         (WTR):
1203         (WTR::InjectedBundlePage::InjectedBundlePage):
1204         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
1205         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
1206         refactoring to share code with didExceedDatabaseQuota.
1207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1208         (InjectedBundlePage):
1209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1210         (WTR::TestRunner::TestRunner):
1211         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1212         (WTR::TestRunner::dumpDatabaseCallbacks):
1213         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
1214         (TestRunner):
1215
1216 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1217
1218         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
1219
1220         Rubber-stamped by Simon Hausmann.
1221
1222         * qmake/mkspecs/features/default_post.prf:
1223
1224 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1225
1226         [Qt] Remove old cruft from the qmake build system
1227
1228         Rubber-stamped by Simon Hausmann.
1229
1230         * DumpRenderTree/qt/DumpRenderTree.pro:
1231         * qmake/mkspecs/features/default_post.prf:
1232
1233 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1234
1235         [Qt] Enable force_static_libs_as_shared for development
1236
1237         Not enabled for buildbots or production-builds (part of Qt5)
1238
1239         Reviewed by Simon Hausmann.
1240
1241         * qmake/mkspecs/features/default_post.prf:
1242
1243 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1244
1245         [Qt] Make force_static_libs_as_shared work on Mac OS
1246
1247         We had to move a few LIBS += around that were in the wrong place,
1248         and not caught when everything was just linked into the final
1249         QtWebKit library.
1250
1251         Reviewed by Simon Hausmann.
1252
1253         * qmake/mkspecs/features/default_post.prf:
1254         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1255
1256 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1257
1258         [Qt] Fix build of WTR on Windows
1259
1260         Reviewed by Tor Arne Vestbø.
1261
1262         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
1263         With qmake's unix makefile generator as well as with the MingW generator,
1264         the directory where the pro file lives (WTR/) is automatically added to
1265         the include search path, but not so with MSVC. Instead of relying on qmake's
1266         implicit feature here, add WTR/ explicitly to the include search path.
1267
1268         * WebKitTestRunner/Target.pri:
1269
1270 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1271
1272         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
1273         https://bugs.webkit.org/show_bug.cgi?id=42691
1274
1275         Reviewed by Kenneth Rohde Christiansen.
1276
1277         Add implementation for testrunner.setStopProvisionalFrameLoads()
1278         in WebKitTestRunner.
1279
1280         Original patch by Alexey Proskuryakov.
1281
1282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1283         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1284         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1285         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1286         (WTR::TestRunner::TestRunner):
1287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1288         (TestRunner):
1289         (WTR::TestRunner::setStopProvisionalFrameLoads):
1290         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1291
1292 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1293
1294         [Qt] Fix handling of debug/release/debug_and_release/build_all
1295
1296         We now pick up the defaults from Qt, in default_pre (CONFIG already
1297         contains the appropriate values for debug and release). We then let
1298         the command line arguments to qmake, or the project files themselves,
1299         override the configuration, and finally we sanitize the configuration
1300         in default_post.
1301
1302         Reviewed by Simon Hausmann.
1303
1304         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1305         * Scripts/webkitdirs.pm:
1306         (buildQMakeProjects):
1307         * qmake/mkspecs/features/default_post.prf:
1308         * qmake/mkspecs/features/default_pre.prf:
1309         * qmake/mkspecs/features/mac/default_pre.prf:
1310
1311 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1312
1313         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1314         https://bugs.webkit.org/show_bug.cgi?id=42687
1315
1316         Reviewed by Kenneth Rohde Christiansen.
1317
1318         Implement testRunner.setTabKeyCyclesThroughElements for
1319         WebKitTestRunner.
1320
1321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1322         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1323         (WTR::InjectedBundle::beginTesting):
1324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1325         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1326         (WTR):
1327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1328         (TestRunner):
1329
1330 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1331
1332         EventSendingController::keyDown does not support non-array modifier arguments
1333         https://bugs.webkit.org/show_bug.cgi?id=96727
1334
1335         Reviewed by Kenneth Rohde Christiansen.
1336
1337         Add support for handling a string as modifier argument to
1338         EventSendingController::keyDown.
1339
1340         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1341         (WTR::parseModifierArray):
1342
1343 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1344
1345         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1346         https://bugs.webkit.org/show_bug.cgi?id=42546
1347
1348         Reviewed by Kenneth Rohde Christiansen.
1349
1350         Exported TestRunner::setCustomPolicyDelegate() method.
1351         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1352
1353         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1355         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1356
1357 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1358
1359         [GTK] Clear application cache between tests in DumpRenderTree
1360         https://bugs.webkit.org/show_bug.cgi?id=96543
1361
1362         Reviewed by Philippe Normand.
1363
1364         Call the new DumpRenderTreeSupportGtk method to clear application cache
1365         after each test in DumpRenderTree.
1366
1367         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1368         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1369         a cache directory that's constructed out of the driver's name and its worker
1370         number. These directories are located in the layout tests results directory.
1371         At least on the builders this ensures a driver-specific empty cache directory
1372         with each test run.
1373
1374         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1375         (runTest):
1376         * Scripts/webkitpy/layout_tests/port/gtk.py:
1377         (GtkPort.setup_environ_for_server):
1378         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1379         (XvfbDriver._start):
1380
1381 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1382
1383         [Qt] Fix linking on Windows
1384
1385         Reviewed by Tor Arne Vestbø.
1386
1387         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1388         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1389         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1390         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1391
1392         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1393         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1394         after the module. Therefore QT did never contain webkit anymore and we always passed
1395         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1396
1397         This patch introduces a creating_module configuration that is used to
1398         scope the qt/pkgconfig sanitization.
1399
1400         * qmake/mkspecs/features/default_post.prf:
1401
1402 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1403
1404         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1405         https://bugs.webkit.org/show_bug.cgi?id=96740
1406
1407         Reviewed by Kenneth Rohde Christiansen.
1408
1409         Dump information expected by the test cases about the following
1410         frame load callbacks:
1411         "didDisplayInsecureContentForFrame"
1412         "didRunInsecureContentForFrame"
1413         "didDetectXSSForFrame"
1414
1415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1416         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1417         as expected by test results by calling pathSuitableForTestResult() instead
1418         of printing raw URL.
1419         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1420         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1421         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1422
1423 2012-09-14  Peter Beverloo  <peter@chromium.org>
1424
1425         The runtime/unsigned category should be valid in the cpp style-checker.
1426         https://bugs.webkit.org/show_bug.cgi?id=96748
1427
1428         Reviewed by Csaba Osztrogonác.
1429
1430         This is causing the webkitpy tests to fail because it's not listed in the
1431         category array. Furthermore, change an "int" to "long" because it's
1432         throwing a double error in one of the earlier asserts.
1433
1434         * Scripts/webkitpy/style/checkers/cpp.py:
1435         (CppChecker):
1436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1437         (WebKitStyleTest.test_names):
1438
1439 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1440
1441         Evas_Object* is a ref'ed structure, so tread it as such
1442         https://bugs.webkit.org/show_bug.cgi?id=96659
1443
1444         Reviewed by Adam Barth.
1445
1446         Replace OwnPtr<Evas_Object> with RefPtr.
1447
1448         * DumpRenderTree/efl/ImageDiff.cpp:
1449         (calculateDifference):
1450         (printImageDifferences):
1451         (readImageFromStdin):
1452         (main):
1453
1454 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1455
1456         Unreviewed, rolling out r128507.
1457         http://trac.webkit.org/changeset/128507
1458         https://bugs.webkit.org/show_bug.cgi?id=96659
1459
1460         Revert. r128507 makes too many crashes in EFL layout test bots.
1461
1462         * DumpRenderTree/efl/ImageDiff.cpp:
1463         (calculateDifference):
1464         (printImageDifferences):
1465         (readImageFromStdin):
1466         (main):
1467
1468 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1469
1470         Make compile with both OS(WINCE) and PLATFORM(QT) support
1471         https://bugs.webkit.org/show_bug.cgi?id=95536
1472
1473         Reviewed by Simon Hausmann.
1474
1475         Fix wince support in qmake files
1476
1477         * Tools.pro:
1478         * qmake/mkspecs/features/configure.prf:
1479         * qmake/mkspecs/features/default_post.prf:
1480         * qmake/mkspecs/features/features.prf:
1481         * qmake/mkspecs/features/functions.prf:
1482
1483 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1484
1485         [WK2] Add color picker API support for WebKit2
1486         https://bugs.webkit.org/show_bug.cgi?id=95058
1487
1488         Reviewed by Gyuyoung Kim.
1489
1490         Initialization code for color picker callbacks in UI client.
1491
1492         * MiniBrowser/mac/BrowserWindowController.m:
1493         (-[BrowserWindowController awakeFromNib]):
1494         * MiniBrowser/win/BrowserView.cpp:
1495         (BrowserView::create):
1496         * WebKitTestRunner/TestController.cpp:
1497         (WTR::TestController::createOtherPage):
1498         (WTR::TestController::initialize):
1499
1500 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1501
1502         Upgrade yutak to reviewer
1503         https://bugs.webkit.org/show_bug.cgi?id=96721
1504
1505         Reviewed by Kent Tamura.
1506
1507         * Scripts/webkitpy/common/config/committers.py:
1508
1509 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1510
1511         Make the style checker report usage of "unsigned int"
1512         https://bugs.webkit.org/show_bug.cgi?id=96693
1513
1514         Reviewed by Dirk Pranke.
1515
1516         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1517
1518         * Scripts/webkitpy/style/checkers/cpp.py:
1519         (check_language):
1520
1521 2012-09-13  Philip Rogers  <pdr@google.com>
1522
1523         Add gender-neutral form of webkit-patch land-cowboy
1524         https://bugs.webkit.org/show_bug.cgi?id=96709
1525
1526         Reviewed by Adam Barth.
1527
1528         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1529
1530         * Scripts/webkitpy/tool/commands/download.py:
1531         (LandCowhand):
1532
1533 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1534
1535         [EFL] Remove some parameters in browserCreate()
1536         https://bugs.webkit.org/show_bug.cgi?id=96499
1537
1538         Reviewed by Kenneth Rohde Christiansen.
1539
1540         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1541         And I have moved some parameters into User_Arguments.
1542
1543         * EWebLauncher/main.c:
1544         (_User_Arguments):
1545         (_ELauncher):
1546         (on_key_down):
1547         (browserCreate):
1548         (findThemePath):
1549         (parseUserArguments):
1550         (main):
1551
1552 2012-09-13  Mark Lam  <mark.lam@apple.com>
1553
1554         Unreviewed. Adding myself to the committers list.
1555
1556         * Scripts/webkitpy/common/config/committers.py:
1557
1558 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1559
1560         run-perf-tests output cryptic error when the config file is missing.
1561         https://bugs.webkit.org/show_bug.cgi?id=96453
1562
1563         Reviewed by Tony Chang.
1564
1565         Add a special error message when a configuration file is missing.
1566
1567         Also update the help message of --source-json-path to signify the fact it specifies
1568         the configuration file on performance tests bots.
1569
1570         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1571         (PerfTestsRunner._parse_args):
1572         (PerfTestsRunner._generate_and_show_results):
1573         (PerfTestsRunner._merge_slave_config_json):
1574         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1575         (_test_run_with_json_output): Make upload to fail by default and assert the result
1576         in the function so that we can return logs instead.
1577         (_test_run_with_json_output.mock_upload_json):
1578         (test_run_with_json_output):
1579         (test_run_with_description):
1580         (test_run_respects_no_results):
1581         (test_run_with_slave_config_json):
1582         (test_run_with_bad_slave_config_json):
1583         (test_run_with_multiple_repositories):
1584
1585 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1586
1587         Evas_Object* is a ref'ed structure, so tread it as such
1588         https://bugs.webkit.org/show_bug.cgi?id=96659
1589
1590         Reviewed by Adam Barth.
1591
1592         Replace OwnPtr<Evas_Object> with RefPtr.
1593
1594         * DumpRenderTree/efl/ImageDiff.cpp:
1595         (calculateDifference):
1596         (printImageDifferences):
1597         (readImageFromStdin):
1598         (main):
1599
1600 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1601
1602         One more unreviewed trivial fix after r128399.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1605
1606 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1607
1608         Unreviewed trivial fix after r128399.
1609
1610         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1611         (getLatestSVNRevision):
1612         (waitForSVNRevision):
1613
1614 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1615
1616         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1617         https://bugs.webkit.org/show_bug.cgi?id=96366
1618
1619         Reviewed by Anders Carlsson.
1620
1621         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1622         by calling shouldClose() on the FrameLoader.
1623
1624         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1625         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1626         (WTR::TestRunner::callShouldCloseOnWebView):
1627         (WTR):
1628         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1629         (TestRunner):
1630
1631 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1632
1633         Unreviewed, rolling out r128453.
1634         http://trac.webkit.org/changeset/128453
1635         https://bugs.webkit.org/show_bug.cgi?id=96681
1636
1637         Having tests use the same appcache directory leads to timeouts
1638         (Requested by zdobersek on #webkit).
1639
1640         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1641         (runTest):
1642         * Scripts/webkitpy/layout_tests/port/gtk.py:
1643         (GtkPort.setup_environ_for_server):
1644
1645 2012-09-13  James Robinson  <jamesr@chromium.org>
1646
1647         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1648         https://bugs.webkit.org/show_bug.cgi?id=96678
1649
1650         Reviewed by Dirk Pranke.
1651
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1653         (.):
1654
1655 2012-09-13  Rob Buis  <rbuis@rim.com>
1656
1657         Unreviewed changes to watchlist.
1658
1659         - Add myself to BlackBerry bugs
1660
1661         * Scripts/webkitpy/common/config/watchlist:
1662
1663 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1664
1665         Add an SVG entry to the watchlist
1666
1667         Unreviewed config change.
1668
1669         * Scripts/webkitpy/common/config/watchlist:
1670         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1671         - Added myself and pdr as watchers
1672
1673 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1674
1675         [Qt] Make WebKit2 work on Windows with Qt 5
1676         https://bugs.webkit.org/show_bug.cgi?id=76776
1677
1678         Reviewed by Tor Arne Vestbø.
1679
1680         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1681         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1682         that for the GL TextureMapper (it's only built when that feature is set).
1683
1684         * qmake/mkspecs/features/configure.prf:
1685
1686 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1687
1688         [Qt] Ensure that QT is finalized before loading qt_module.prf
1689
1690         As qt_module.prf does dependency tracking based on the content of the
1691         QT variable. The intermediate WebKit modules modify the variable in
1692         their .pri files, so we have to ensure we've loaded all the modules
1693         before loading qt_module.
1694
1695         Reviewed by Tor Arne Vestbø.
1696         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1697
1698         * qmake/mkspecs/features/default_post.prf:
1699         * qmake/mkspecs/features/webkit_modules.prf: Added.
1700
1701 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1702
1703         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1704         https://bugs.webkit.org/show_bug.cgi?id=96633
1705
1706         Reviewed by Csaba Osztrogonác.
1707
1708         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1709         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1710         It's the usual problem and the usual solution is to rename one of the conflicting files.
1711         This patch chooses to rename DRT instead of WTR and MBR.
1712
1713         Fixed include order at the same time to match style guide.
1714
1715         * DumpRenderTree/qt/DumpRenderTree.pro:
1716         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1717         (messageHandler):
1718         (isOption):
1719         (takeOptionValue):
1720         (printUsage):
1721         (main):
1722
1723 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1724
1725         The Script run-launcher should support -2 in combination with --efl
1726         https://bugs.webkit.org/show_bug.cgi?id=96639
1727
1728         Reviewed by Simon Hausmann.
1729
1730         Support running the MiniBrowser then supplied -2 as argument.
1731
1732         * Scripts/run-launcher:
1733
1734 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1735
1736         Unreviewed, add my Intel email address to the list.
1737
1738         * Scripts/webkitpy/common/config/committers.py:
1739
1740 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1741
1742         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1743
1744         Reviewed by Ossy.
1745
1746         * qmake/mkspecs/features/default_post.prf:
1747
1748 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1749
1750         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1751         https://bugs.webkit.org/show_bug.cgi?id=82294
1752
1753         Reviewed by Gyuyoung Kim.
1754
1755         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1756
1757         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1758         (TestRunner::layerTreeAsText):
1759
1760 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1761
1762         [GTK] Clear application cache between tests in DumpRenderTree
1763         https://bugs.webkit.org/show_bug.cgi?id=96543
1764
1765         Reviewed by Philippe Normand.
1766
1767         Call the new DumpRenderTreeSupportGtk method to clear application cache
1768         after each test.
1769
1770         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1771         as well. Currently it points to a subdirectory in the layout tests results
1772         directory. At least on the builders this ensures an empty cache directory
1773         with each test run.
1774
1775         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1776         (runTest):
1777         * Scripts/webkitpy/layout_tests/port/gtk.py:
1778         (GtkPort.setup_environ_for_server):
1779
1780 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1781
1782         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1783
1784         Unless it's actually a dependency of the public QtWebKit API.
1785
1786         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1787         files with their _PRIVATE equivivalent, but that's likely to break when
1788         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1789         clean up the variables in default_post.
1790
1791         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1792         longer needed, as it was a workaround for the intermediate libraries ending
1793         up in the prl file. And, since CONFIG -= staticlib was there to support
1794         the explicitlib option, we can remove that too (as well as the exception
1795         for gprof, since it would be empty). If gprof needs tweaks to always link
1796         statically they should go in gprof.prf.
1797
1798         Reviewed by Simon Hausmann.
1799
1800         * qmake/mkspecs/features/default_post.prf:
1801         * qmake/mkspecs/features/functions.prf:
1802
1803 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1804
1805         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1806         https://bugs.webkit.org/show_bug.cgi?id=96632
1807
1808         Reviewed by Carlos Garcia Campos.
1809
1810         Fix this by using atk_object_get_n_accessible_children instead of
1811         calling getChildren() from childCount.
1812
1813         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1814         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1815         loop by using atk_object_get_n_accessible_children().
1816
1817 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1818
1819         [Qt][Win] Enable USE(3D_GRAPHICS)
1820         https://bugs.webkit.org/show_bug.cgi?id=90879
1821
1822         Reviewed by Kenneth Rohde Christiansen.
1823
1824         Enable it on Windows as well as on QNX (bug fixed).
1825
1826         * qmake/mkspecs/features/features.prf:
1827
1828 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1829
1830         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1831         https://bugs.webkit.org/show_bug.cgi?id=96359
1832
1833         Reviewed by Tor Arne Vestbø.
1834
1835         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1836         lexer. The only viable alternative I could find on Windows that provides
1837         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1838         so let's use that one instead.
1839
1840         * Scripts/webkitdirs.pm:
1841         (checkRequiredSystemConfig):
1842         * qmake/mkspecs/features/default_pre.prf:
1843
1844 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1845
1846         [Qt] Add configuration for production builds
1847         https://bugs.webkit.org/show_bug.cgi?id=96607
1848
1849         Reviewed by Kenneth Rohde Christiansen.
1850
1851         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1852         and enable all-in-one-files optimizations.
1853
1854         * qmake/mkspecs/features/production_build.prf: Added.
1855
1856 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1857
1858         [Qt] GStreamer detection does not work when cross-compiling
1859         https://bugs.webkit.org/show_bug.cgi?id=96608
1860
1861         Reviewed by Kenneth Rohde Christiansen.
1862
1863         When cross-compiling it is not safe to just use system(pkg-config),
1864         because there is a high probability that it will find packages in the
1865         host system instead of in the target one. Instead use qmake's new
1866         packagesExist() function that takes care of this delicate aspect of
1867         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1868         PKG_CONFIG_LIBDIR accordingly.
1869
1870         * qmake/mkspecs/features/features.prf:
1871
1872 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1873
1874         [WK2][WTR] More efficient string handling in InjectedBundlePage
1875         https://bugs.webkit.org/show_bug.cgi?id=96609
1876
1877         Reviewed by Kenneth Rohde Christiansen.
1878
1879         Update StringBuilder usage in InjectedBundlePage to follow
1880         the latest recommandations for efficient string handling:
1881         http://trac.webkit.org/wiki/EfficientStrings
1882
1883         This involves using appendLiteral() or appendNumber()
1884         instead of append() whenever possible.
1885
1886         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1887         (WTR::dumpPath):
1888         (WTR::rangeToStr):
1889         (WTR::styleDecToStr):
1890         (WTR::frameToStr):
1891         (WTR::dumpResourceURL):
1892         (WTR):
1893         (WTR::dumpFrameDescriptionSuitableForTestResult):
1894         (WTR::dumpRequestDescriptionSuitableForTestResult):
1895         (WTR::dumpResponseDescriptionSuitableForTestResult):
1896         (WTR::dumpErrorDescriptionSuitableForTestResult):
1897         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1898         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1899         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1900         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1901         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1902         (WTR::InjectedBundlePage::didFinishProgress):
1903         (WTR::dumpFrameScrollPosition):
1904         (WTR::dumpFrameText):
1905         (WTR::dumpDescendantFramesText):
1906         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1907         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1908         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1909         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1910         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1911         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1912         (WTR::InjectedBundlePage::willSendRequestForFrame):
1913         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1914         (WTR::InjectedBundlePage::didFinishLoadForResource):
1915         (WTR::InjectedBundlePage::didFailLoadForResource):
1916         (WTR::InjectedBundlePage::shouldCacheResponse):
1917         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1918         (WTR::InjectedBundlePage::willAddMessageToConsole):
1919         (WTR::InjectedBundlePage::willSetStatusbarText):
1920         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1921         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1922         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1923         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1924         (WTR::InjectedBundlePage::shouldBeginEditing):
1925         (WTR::InjectedBundlePage::shouldEndEditing):
1926         (WTR::InjectedBundlePage::shouldInsertNode):
1927         (WTR::InjectedBundlePage::shouldInsertText):
1928         (WTR::InjectedBundlePage::shouldDeleteRange):
1929         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1930         (WTR::InjectedBundlePage::shouldApplyStyle):
1931         (WTR::InjectedBundlePage::didBeginEditing):
1932         (WTR::InjectedBundlePage::didEndEditing):
1933         (WTR::InjectedBundlePage::didChange):
1934         (WTR::InjectedBundlePage::didChangeSelection):
1935         (WTR::InjectedBundlePage::supportsFullScreen):
1936         (WTR::InjectedBundlePage::enterFullScreenForElement):
1937         (WTR::InjectedBundlePage::exitFullScreenForElement):
1938         (WTR::InjectedBundlePage::beganEnterFullScreen):
1939         (WTR::InjectedBundlePage::beganExitFullScreen):
1940         (WTR::InjectedBundlePage::closeFullScreen):
1941         (WTR::dumpBackForwardListItem):
1942         (WTR::InjectedBundlePage::dumpBackForwardList):
1943
1944 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1945
1946         [Qt][WK2] Memory leaks in Qt's TestRunner
1947         https://bugs.webkit.org/show_bug.cgi?id=96603
1948
1949         Reviewed by Csaba Osztrogonác.
1950
1951         Fix memory leaks in Qt's TestRunner code by adopting WKString
1952         created with WKStringCreateWithUTF8CString().
1953
1954         * WebKitTestRunner/qt/TestControllerQt.cpp:
1955         (WTR::TestController::initializeInjectedBundlePath):
1956         (WTR::TestController::initializeTestPluginDirectory):
1957
1958 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1959
1960         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1961         https://bugs.webkit.org/show_bug.cgi?id=96506
1962
1963         Reviewed by Dirk Pranke.
1964
1965         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1966         for debug configuration. These are the same values the Chromium port uses.
1967
1968         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1969         the layout tests under WebKit2 generally) requires more attention and gardening
1970         than what the current effort produces.
1971
1972         The unit test is updated as well to test these changes.
1973
1974         * Scripts/webkitpy/layout_tests/port/gtk.py:
1975         (GtkPort.default_timeout_ms):
1976         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1977         (GtkPortTest.test_default_timeout_ms):
1978         (GtkPortTest.assertLinesEqual):
1979
1980 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1981
1982         Add SVN mirror handling feature to build.webkit.org
1983         https://bugs.webkit.org/show_bug.cgi?id=85887
1984
1985         Reviewed by Dirk Pranke.
1986
1987         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1989         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1990         (ConfigureBuild.start):
1991         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1992         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1993         (Factory.__init__):
1994         (BuildFactory.__init__):
1995         (TestFactory.__init__):
1996         (BuildAndTestFactory.__init__):
1997         (BuildAndPerfTestFactory.__init__):
1998         (BuildAndPerfTestWebKit2Factory.__init__):
1999         (DownloadAndPerfTestFactory.__init__):
2000         (DownloadAndPerfTestWebKit2Factory.__init__):
2001         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
2002         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2003         (SVNMirrorTest):
2004         (SVNMirrorTest.setUp): Load config.json once at startup.
2005         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
2006         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
2007         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
2008         (getLatestSVNRevision): Get the latest SVN revison from the given server.
2009         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
2010                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
2011
2012 2012-09-12  Kangil Han  <kangil.han@samsung.com>
2013
2014         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
2015         https://bugs.webkit.org/show_bug.cgi?id=81606
2016
2017         Reviewed by Tim Horton.
2018
2019         6 seconds is harsh for some jquery test cases.
2020         Therefore, adjust the value to match DumpRenderTree.
2021
2022         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2023         (WTR):
2024
2025 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
2026
2027         [EFL] Support download attribute feature
2028         https://bugs.webkit.org/show_bug.cgi?id=96462
2029
2030         Reviewed by Gyuyoung Kim.
2031
2032         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
2033         and add "download,request" callback to the DumpRenderTree for EFL.
2034
2035         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2036         (DumpRenderTreeChrome::createView):
2037         (DumpRenderTreeChrome::onDownloadRequest):
2038         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2039         (DumpRenderTreeChrome):
2040         * Scripts/webkitperl/FeatureList.pm:
2041
2042 2012-09-12  Stephanie Lewis  <slewis@apple.com>
2043
2044         Reduce parallism on the wk2 testers.
2045         https://bugs.webkit.org/show_bug.cgi?id=95906
2046
2047         Reviewed by Dirk Pranke.
2048
2049         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
2050         resource contention.  Reducing the number of processes alleviates the issue.  
2051
2052         Starting by reducing 25%.
2053
2054         * Scripts/webkitpy/layout_tests/port/mac.py:
2055         (MacPort.default_child_processes):
2056
2057 2012-09-12  Brady Eidson  <beidson@apple.com>
2058
2059         Assert in NetscapePlugin::destroy() with async plugin init
2060         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
2061
2062         Reviewed by Anders Carlsson.
2063
2064         Expose NPN_Invoke to plug-in tests:
2065         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2066         (PluginTest::NPN_Invoke):
2067         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2068         (PluginTest):
2069
2070         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
2071         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
2072         (InvokeDestroysPluginWithinNPP_New):
2073         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
2074         (InvokeDestroysPluginWithinNPP_New::NPP_New):
2075         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2076
2077 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2078
2079         refactor TestExpectations tokenization slightly in preparation for the new syntax
2080         https://bugs.webkit.org/show_bug.cgi?id=96564
2081
2082         Reviewed by Ojan Vafai.
2083
2084         This change changes how we will tokenize/lex the
2085         TestExpectations files, in preparation for supporting both the
2086         old syntax and the new one. This change by itself should be a
2087         no-op.
2088
2089         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2090         (TestExpectationParser._tokenize_line):
2091         (TestExpectationParser):
2092         (TestExpectationParser._tokenize_line_using_old_format):
2093         (TestExpectationParser._tokenize_line_using_new_format):
2094
2095 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2096
2097         remove unused testexpectations editing code from webkitpy, garden-o-matic
2098         https://bugs.webkit.org/show_bug.cgi?id=96562
2099
2100         Reviewed by Adam Barth.
2101
2102         This code was prototyped but never fully realized. Removing
2103         until it reanimates :).
2104
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2107         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
2108         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
2109         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2110         (BuildCoverageExtrapolator.extrapolate_test_configurations):
2111         (GardeningHTTPRequestHandler._run_webkit_patch):
2112         (GardeningHTTPRequestHandler.ping):
2113         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2114         (BuildCoverageExtrapolatorTest.test_extrapolate):
2115         (GardeningServerTest.test_rebaseline_new_port):
2116
2117 2012-09-12  Lucas Forschler  <lforschler@apple.com>
2118
2119         Remove unused bot, apple-xserve-1.
2120         https://bugs.webkit.org/show_bug.cgi?id=96570
2121         
2122         Reviewed by Stephanie Lewis.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/config.json:
2125
2126 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2127
2128         [GTK] We attempt to rebase documentation even if it's not present
2129         https://bugs.webkit.org/show_bug.cgi?id=96553
2130
2131         Reviewed by Martin Robinson.
2132
2133         Do not make the documentation rebase step fatal. This allows make
2134         install to succeed when there's no documentation generated.
2135
2136         * gtk/generate-gtkdoc:
2137
2138 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2139
2140         Respect WEBKITOUTPUTDIR when running EFL tests
2141         https://bugs.webkit.org/show_bug.cgi?id=96528
2142
2143         Reviewed by Dirk Pranke.
2144
2145         Expose user set WEBKITOUTPUTDIR to the web process.
2146
2147         * Scripts/webkitpy/layout_tests/port/driver.py:
2148         (Driver._start): Add WEBKITOUTPUTDIR to the environment
2149         of the web process and its potential jhbuild wrapper.
2150
2151 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2152
2153         webkitdirs: fix uname version handling for cygwin
2154         https://bugs.webkit.org/show_bug.cgi?id=96436
2155
2156         Reviewed by Jon Honeycutt.
2157
2158         Newer versions of cygwin embed an additional version string
2159         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
2160         Update the code to handle that.
2161
2162         * Scripts/webkitdirs.pm:
2163         (setupAppleWinEnv):
2164
2165 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2166
2167         Regression(r128338): Broke Windows build
2168         https://bugs.webkit.org/show_bug.cgi?id=96537
2169
2170         Unreviewed build fix.
2171
2172         Fix Apple-Win build by allocating array dynamically
2173         since its size is not constant.
2174
2175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2176         (WTR::stringArrayToJS):
2177
2178 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
2179
2180         [chromium] Add a virtual test suite for fast/hidpi
2181         https://bugs.webkit.org/show_bug.cgi?id=90192
2182
2183         Reviewed by Dirk Pranke.
2184
2185         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
2186         on the hardware accelerated path as the software path.
2187
2188         * DumpRenderTree/chromium/WebPreferences.cpp:
2189         (WebPreferences::applyTo):
2190         * Scripts/webkitpy/layout_tests/port/chromium.py:
2191         (ChromiumPort.virtual_test_suites):
2192
2193 2012-09-12  Adam Klein  <adamk@chromium.org>
2194
2195         [chromium] Add content_browsertests to the flakiness dashboard
2196         https://bugs.webkit.org/show_bug.cgi?id=96535
2197
2198         Reviewed by Ojan Vafai.
2199
2200         * TestResultServer/static-dashboards/dashboard_base.js:
2201
2202 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2203
2204         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
2205         https://bugs.webkit.org/show_bug.cgi?id=96496
2206
2207         Reviewed by Kenneth Rohde Christiansen.
2208
2209         Add implementation for originsWithApplicationCache to
2210         WebKitTestRunner.
2211
2212         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2213         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2214         (WTR::stringArrayToJS):
2215         (WTR):
2216         (WTR::TestRunner::originsWithApplicationCache):
2217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2218         (TestRunner):
2219
2220 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2221
2222         Fix Qt/Windows build with Python3
2223         https://bugs.webkit.org/show_bug.cgi?id=96473
2224
2225         Reviewed by Csaba Osztrogonác.
2226
2227         In Python 3 print is a real function, so we must use parentheses around
2228         the function parameters. This is backwards compatible with Python 2.
2229
2230         * Scripts/generate-win32-export-forwards:
2231
2232 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2233
2234         Unreviewed trivial build fix for Qt/Windows after bug #96358.
2235
2236         As pointed out by Kevin, we should inject the "set PATH=..." statement
2237         to add the GnuWin32 directory only if that directory actually exists.
2238
2239         * qmake/mkspecs/features/default_post.prf:
2240
2241 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2242
2243         [EFL] [WK2] Memory leaks in TestControllerEfl
2244         https://bugs.webkit.org/show_bug.cgi?id=96525
2245
2246         Reviewed by Kenneth Rohde Christiansen.
2247
2248         Fix memory leaks in EFL's TestRunner code by adopting an allocation
2249         of WKString created with WKStringCreateWithUTF8CString().
2250
2251         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2252         (WTR::TestController::initializeInjectedBundlePath):
2253         (WTR::TestController::initializeTestPluginDirectory):
2254
2255 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2256
2257         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2258         https://bugs.webkit.org/show_bug.cgi?id=96374
2259
2260         Reviewed by Kenneth Rohde Christiansen.
2261
2262         Implement support for dumpApplicationCacheDelegateCallbacks
2263         and disallowIncreaseForApplicationCacheQuota in
2264         WebKitTestRunner and properly dump the information
2265         expected by the tests.
2266
2267         If the application cache quota is reached for a given
2268         security origin, WebKitTestRunner will reset the quota
2269         to its default value, unless intructed not to via
2270         disallowIncreaseForApplicationCacheQuota().
2271
2272         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2274         (WTR::InjectedBundlePage::InjectedBundlePage):
2275         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2276         (WTR):
2277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2278         (InjectedBundlePage):
2279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2280         (WTR::TestRunner::TestRunner):
2281         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2282         (WTR):
2283         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2284         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2285         (TestRunner):
2286         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2287         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2288
2289 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2290
2291         [chromium] remove deprecated and unused sets import from chromium_android driver
2292         https://bugs.webkit.org/show_bug.cgi?id=96485
2293
2294         Reviewed by Dirk Pranke.
2295
2296         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2297
2298 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2299
2300         Flakiness dashboard doesn't recognize new Chromium Android test builder
2301         https://bugs.webkit.org/show_bug.cgi?id=96523
2302
2303         Reviewed by Ojan Vafai.
2304
2305         Properly return 'ANDROID' as the Chromium platform for Android builders.
2306
2307         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2308         (chromiumPlatform):
2309         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2310         (test):
2311
2312 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2313
2314         [Qt] Build on Windows requires bison/flex in PATH
2315         https://bugs.webkit.org/show_bug.cgi?id=96358
2316
2317         Reviewed by Tor Arne Vestbø.
2318
2319         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2320         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2321         a separate installation of various GNU tools is required as the operating system doesn't come with
2322         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2323         the gnuwin32 directory of the qt5.git top-level repository.
2324
2325         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2326
2327         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2328         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2329         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2330         updated with the new tool.
2331
2332         * Scripts/webkitdirs.pm:
2333         (checkRequiredSystemConfig):
2334         * qmake/mkspecs/features/default_post.prf:
2335
2336 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2337
2338         [Qt] Update build-jsc after r128174
2339
2340         Reviewed by Ossy.
2341
2342         * Scripts/build-jsc:
2343
2344 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2345
2346         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2347
2348         By hard-coding the names of the targets we defined we ended up just
2349         redefining the previous target when using addStrictSubdirOrderBetween
2350         more than once in a single project file.
2351
2352         We now embed the two base targets into the target names.
2353
2354         Reviewed by Simon Hausmann.
2355
2356         * qmake/mkspecs/features/functions.prf:
2357
2358 2012-09-12  Philippe Liard  <pliard@google.com>
2359
2360         Depend on {base,net} GYP targets rather than {base,net}_java.
2361         https://bugs.webkit.org/show_bug.cgi?id=95690
2362
2363         Reviewed by Adam Barth.
2364
2365         {base,net}_java became 'private' targets on the Chromium side that
2366         clients should not depend on (see
2367         https://chromiumcodereview.appspot.com/10913083/).
2368         This removes a bunch of trailing white spaces additionally in
2369         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2370
2371         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2372         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2373
2374 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2375
2376         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2377         https://bugs.webkit.org/show_bug.cgi?id=96494
2378
2379         Reviewed by Tor Arne Vestbø.
2380
2381         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2382         plugin process feature if we don't have NPAPI.
2383
2384         * qmake/mkspecs/features/features.prf:
2385
2386 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2387
2388         Unreviewed, rolling out r128280.
2389         http://trac.webkit.org/changeset/128280
2390         https://bugs.webkit.org/show_bug.cgi?id=96498
2391
2392         it broke compilation on windows debug bot (Requested by loislo
2393         on #webkit).
2394
2395         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2397         (WTR::InjectedBundlePage::InjectedBundlePage):
2398         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2399         (InjectedBundlePage):
2400         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2401         (WTR::TestRunner::TestRunner):
2402         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2403         (TestRunner):
2404
2405 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2406
2407         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2408         https://bugs.webkit.org/show_bug.cgi?id=96488
2409
2410         Reviewed by Tor Arne Vestbø.
2411
2412         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2413         because there are no such targets. We want the generated sources to be independent from release
2414         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2415         redirect to the same general-purpose target (first) of creating the derived sources.
2416
2417         * qmake/mkspecs/features/default_post.prf:
2418
2419 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2420
2421         [EFL] Make DumpRenderTree smarter at finding the fonts
2422         http://webkit.org/b/96281
2423
2424         Reviewed by Gyuyoung Kim.
2425
2426         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2427         Use CString consistently.
2428
2429         * DumpRenderTree/efl/FontManagement.cpp:
2430         (buildPath):
2431         (getCoreFontFiles):
2432         (addFontDirectory):
2433         (addFontFiles):
2434         (getCustomBuildDir):
2435         (getPlatformFontsPath):
2436         (addFontsToEnvironment):
2437
2438 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2439
2440         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2441         https://bugs.webkit.org/show_bug.cgi?id=96374
2442
2443         Reviewed by Kenneth Rohde Christiansen.
2444
2445         Implement support for dumpApplicationCacheDelegateCallbacks
2446         and disallowIncreaseForApplicationCacheQuota in
2447         WebKitTestRunner and properly dump the information
2448         expected by the tests.
2449
2450         If the application cache quota is reached for a given
2451         security origin, WebKitTestRunner will reset the quota
2452         to its default value, unless intructed not to via
2453         disallowIncreaseForApplicationCacheQuota().
2454
2455         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2457         (WTR::InjectedBundlePage::InjectedBundlePage):
2458         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2459         (WTR):
2460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2461         (InjectedBundlePage):
2462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2463         (WTR::TestRunner::TestRunner):
2464         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2465         (WTR):
2466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2467         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2468         (TestRunner):
2469         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2470         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2471
2472 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2473
2474         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2475         https://bugs.webkit.org/show_bug.cgi?id=96388
2476
2477         Reviewed by Kenneth Rohde Christiansen.
2478
2479         Exported TestRunner.workerThreadCount as readonly attribute.
2480
2481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2483         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2484         (WTR):
2485         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2486         (TestRunner):
2487
2488 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2489
2490         [chromium] Consume a user gesture when creating a new view.
2491         https://bugs.webkit.org/show_bug.cgi?id=96373
2492
2493         Reviewed by Adam Barth.
2494
2495         * DumpRenderTree/chromium/WebViewHost.cpp:
2496         (WebViewHost::createView):
2497
2498 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2499
2500         [WK2][WTR] Some of TestRunner special options are not reset before testing
2501         https://bugs.webkit.org/show_bug.cgi?id=96384
2502
2503         Reviewed by Kenneth Rohde Christiansen.
2504
2505         Now values of the following special options are reset:
2506         void setAcceptsEditing(in boolean value);
2507         void setCloseRemainingWindowsWhenComplete(in boolean value);
2508         void setXSSAuditorEnabled(in boolean value);
2509         void setAllowFileAccessFromFileURLs(in boolean value);
2510         void setPluginsEnabled(in boolean value);
2511         void setPopupBlockingEnabled(in boolean value);
2512
2513         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2514         (WTR::InjectedBundle::beginTesting):
2515
2516 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2517
2518         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2519         https://bugs.webkit.org/show_bug.cgi?id=96273
2520
2521         Reviewed by Gyuyoung Kim.
2522
2523         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2524         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2525
2526         * WebKitTestRunner/CMakeLists.txt:
2527
2528 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2529
2530         [chromium] rename webkit_resources
2531         https://bugs.webkit.org/show_bug.cgi?id=95874
2532
2533         Reviewed by James Robinson.
2534
2535         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2536
2537 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2538
2539         [chromium] don't include content shell builders in the garden-o-matic view
2540         https://bugs.webkit.org/show_bug.cgi?id=96418
2541
2542         Reviewed by James Robinson.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2545
2546 2012-09-11  Adam Klein  <adamk@chromium.org>
2547
2548         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2549         https://bugs.webkit.org/show_bug.cgi?id=96411
2550
2551         Reviewed by Adam Barth.
2552
2553         Previously only the exact string "warning" was treated as a warning
2554         result. This patch treats any string with "warning" as a substring
2555         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2556
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2558         (.):
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2560
2561 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2562
2563         Restore original value of mock scrollbars enabled in InternalSettings
2564         https://bugs.webkit.org/show_bug.cgi?id=87680
2565
2566         Reviewed by Adam Barth.
2567
2568         Added backup support for mock scrollbars state in
2569         InternalSettings::Backup, and removed support for these
2570         from Qt's DumpRenderTree.
2571
2572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2573         (WebCore::WebPage::resetSettings):
2574         * DumpRenderTree/qt/TestRunnerQt.cpp:
2575         (TestRunner::setFrameFlatteningEnabled):
2576         * DumpRenderTree/qt/TestRunnerQt.h:
2577         (TestRunner):
2578
2579 2012-09-11  Dan Bernstein  <mitz@apple.com>
2580
2581         Fixed a bug where kill-old-processes failed to kill clang++.
2582
2583         Rubber-stamped by Alexey Proskuryakov.
2584
2585         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2586         where it is passed as a regular expression to killall.
2587
2588 2012-09-11  Philippe Liard  <pliard@google.com>
2589
2590         Make sure that md5sum is not setup on non-Chromium Android platforms.
2591         https://bugs.webkit.org/show_bug.cgi?id=96393
2592
2593         Reviewed by Adam Barth.
2594
2595         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2596         which is also invoked on non-Chromium Android platforms. The following patch
2597         moves this logic to _startup_test() which is guaranteed to be invoked
2598         only on Android.
2599
2600         This also updates the prompt unit test in chromium_android_unittest.py.
2601
2602         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2603         (ChromiumAndroidDriver.__init__):
2604         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2605         (ChromiumAndroidDriver._setup_test):
2606
2607 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2608
2609         [EFL] Rewrite the EFL-related Find modules
2610         https://bugs.webkit.org/show_bug.cgi?id=95237
2611
2612         Reviewed by Kenneth Rohde Christiansen.
2613
2614         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2615         property and include all the Enlightenment Foundation Libraries
2616         required by the target.
2617         * EWebLauncher/CMakeLists.txt: Ditto.
2618         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2619         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2620         now that they are not added implicitly.
2621         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2622         property.
2623         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2624         property and include all the Enlightenment Foundation Libraries
2625         required by the target.
2626
2627 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2628
2629         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2630         https://bugs.webkit.org/show_bug.cgi?id=96379
2631
2632         Reviewed by Kenneth Rohde Christiansen.
2633
2634         Add implementation for setApplicationCacheOriginQuota
2635         to WebKitTestRunner.
2636
2637         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2639         (WTR::TestRunner::setApplicationCacheOriginQuota):
2640         (WTR):
2641         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2642         (TestRunner):
2643
2644 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2645
2646         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2647         https://bugs.webkit.org/show_bug.cgi?id=91988
2648
2649         Reviewed by Kenneth Rohde Christiansen.
2650
2651         Regular key events generated by Qt for the tab key fill both
2652         keyCode and keyText, so we should do the same for our fake events.
2653
2654         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2655         (WTR::EventSenderProxy::keyDown):
2656
2657 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2658
2659         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2660         https://bugs.webkit.org/show_bug.cgi?id=96269
2661
2662         Reviewed by Kenneth Rohde Christiansen.
2663
2664         Exported missing testRunner.setSpatialNavigationEnabled() method.
2665
2666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2667         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2668         (WTR::InjectedBundle::beginTesting):
2669         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2670         (WTR::TestRunner::setSpatialNavigationEnabled):
2671         (WTR):
2672         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2673         (TestRunner):
2674
2675 2012-09-11  Philippe Liard  <pliard@chromium.org>
2676
2677         Support LayoutTests on non-rooted devices for Chromium Android.
2678         https://bugs.webkit.org/show_bug.cgi?id=95346
2679
2680         Reviewed by Dirk Pranke.
2681
2682         We were requiring root permissions to sync resource files with the
2683         device by comparing host and device files' timestamp after we
2684         synchronized the device and host clocks.
2685         We now rely on md5sum provided by Chromium to handle data files
2686         synchronization.
2687
2688         * Scripts/webkitpy/layout_tests/port/chromium.py:
2689         (ChromiumPort._check_driver_build_up_to_date):
2690         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2691         (ChromiumAndroidDriver.__init__):
2692         (ChromiumAndroidDriver._setup_test):
2693         (ChromiumAndroidDriver._push_executable):
2694         (ChromiumAndroidDriver._push_test_resources):
2695         (ChromiumAndroidDriver._read_prompt):
2696
2697 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2698
2699         [Qt] Fix output paths on Windows
2700
2701         Reviewed by Tor Arne Vestbø.
2702
2703         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2704         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2705         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2706         incorrect here and instead for the calculation we should use forward slashes.
2707
2708         * qmake/mkspecs/features/default_pre.prf:
2709
2710 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2711
2712         [Qt] Fix passing of defines from the build system
2713
2714         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2715         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2716         will add it's own defaults if the features are not defined.
2717
2718         At some point we might want to run a configure-test to inspect what
2719         Platform.h will do, so we can sync up the build system's view of
2720         the feature-defines with the compile-time situation.
2721
2722         Reviewed by Simon Hausmann.
2723
2724         * qmake/mkspecs/features/functions.prf:
2725
2726 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2727
2728         [Qt] Fix --qt option to build-webkit
2729
2730         Reviewed by Ossy.
2731
2732         * Scripts/webkitdirs.pm:
2733         (buildQMakeProjects):
2734
2735 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2736
2737         [Qt] Add a configure step to the Qt build system
2738
2739         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2740         the build-webkit script is still supported, and will add slightly more
2741         logic to the build, such as detecting the need for clean or incremental
2742         builds.
2743
2744         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2745         all things related to configuring the build, such as use/have/enable flags,
2746         and these are translated to defines in default_post. Project files should
2747         no longer check contains(DEFINES,...) to detect features, but use the new
2748         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2749         options have been translated into WEBKIT_CONFIG options as well, and can
2750         be checked using build?().
2751
2752         Reviewed by Simon Hausmann.
2753
2754         * DumpRenderTree/qt/DumpRenderTree.pro:
2755         * MiniBrowser/qt/MiniBrowser.pro:
2756         * QtTestBrowser/QtTestBrowser.pro:
2757         * Scripts/build-webkit:
2758         * Scripts/webkitdirs.pm:
2759         (qtFeatureDefaults):
2760         (buildQMakeProjects):
2761         * Tools.pro:
2762         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2763         * WebKitTestRunner/InjectedBundle/Target.pri:
2764         * WebKitTestRunner/Target.pri:
2765         * qmake/.qmake.cache: Added.
2766         * qmake/configure.pri: Removed.
2767         * qmake/configure.pro: Removed.
2768         * qmake/dump-features: Added.
2769         * qmake/mkspecs/features/configure.prf: Added.
2770         * qmake/mkspecs/features/default_post.prf:
2771         * qmake/mkspecs/features/default_pre.prf:
2772         * qmake/mkspecs/features/features.prf:
2773         * qmake/mkspecs/features/features.pri:
2774         * qmake/mkspecs/features/functions.prf:
2775         * qmake/mkspecs/features/gprof.prf:
2776         * qmake/mkspecs/features/mac/default_pre.prf:
2777         * qmake/mkspecs/features/win32/default_pre.prf:
2778
2779 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2780
2781         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2782         https://bugs.webkit.org/show_bug.cgi?id=96372
2783
2784         Reviewed by Kenneth Rohde Christiansen.
2785
2786         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2787
2788         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2790         (WTR::TestRunner::clearApplicationCacheForOrigin):
2791         (WTR):
2792         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2793         (TestRunner):
2794
2795 2012-09-11  Peter Beverloo  <peter@chromium.org>
2796
2797         Don't ignore .pak files when making an archive for Android
2798         https://bugs.webkit.org/show_bug.cgi?id=96375
2799
2800         Reviewed by Jochen Eisinger.
2801
2802         The .pak files do need to be pushed to the device, which is currently
2803         preventing the layout test runner from correctly pushing all files.
2804
2805         * BuildSlaveSupport/built-product-archive:
2806         (archiveBuiltProduct):
2807
2808 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2809
2810         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2811         https://bugs.webkit.org/show_bug.cgi?id=96256
2812
2813         Reviewed by Kenneth Rohde Christiansen.
2814
2815         Exported TestRunner::setMinimumTimerInterval() method.
2816
2817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2819         (WTR::InjectedBundle::beginTesting):
2820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2821         (WTR::TestRunner::setMinimumTimerInterval):
2822         (WTR):
2823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2824         (TestRunner):
2825
2826 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2827
2828         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2829         https://bugs.webkit.org/show_bug.cgi?id=96097
2830
2831         Reviewed by Adam Barth.
2832
2833         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2834         (MockWebRTCPeerConnectionHandler::addStream):
2835         (MockWebRTCPeerConnectionHandler::removeStream):
2836
2837 2012-09-11  Peter Beverloo  <peter@chromium.org>
2838
2839         Recognize the "--chromium-android" argument in run-webkit-tests
2840         https://bugs.webkit.org/show_bug.cgi?id=96369
2841
2842         Reviewed by Jochen Eisinger.
2843
2844         Chromium for the Android platform cannot determine the platform based on
2845         the host itself, so we'll use the --chromium-android argument as the build
2846         master passes to run-webkit-tests. Make sure the layout test runner
2847         can pick the right port when doing so.
2848
2849         * Scripts/run-webkit-tests:
2850         * Scripts/webkitpy/layout_tests/port/factory.py:
2851         (port_options):
2852
2853 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2854
2855         [QT] Fix build with newer qmake from Qt 5
2856
2857         Rubber-stamped by Tor Arne Vestbø.
2858
2859         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2860         it with the use of QT_HOST_DATA/mkspecs.
2861         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2862
2863         * Scripts/webkitdirs.pm:
2864         (builtDylibPathForName):
2865         (qtMakeCommand):
2866
2867 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2868
2869         [Qt] Remove Qt 4 syncqt, no longer needed
2870
2871         Reviewed by Simon Hausmann.
2872
2873         * qmake/syncqt-4.8: Removed.
2874
2875 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2876
2877         [Qt][WK2] Fix the build with recent Qt5
2878         https://bugs.webkit.org/show_bug.cgi?id=96283
2879
2880         Reviewed by Simon Hausmann.
2881
2882         We should not use deprecated Qt API because doing that results
2883         in build failure since all the deprecated API was disabled
2884         in qtbase (https://codereview.qt-project.org/#change,24890).
2885
2886         * DumpRenderTree/qt/main.cpp:
2887         (main):
2888         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2889         (MiniBrowserApplication::notify):
2890         * MiniBrowser/qt/raw/View.cpp:
2891         (View::exposeEvent):
2892         (main):
2893
2894 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2895
2896         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2897         https://bugs.webkit.org/show_bug.cgi?id=87188
2898
2899         Reviewed by Kenneth Rohde Christiansen.
2900
2901         Add implementation for applicationCacheDiskUsageForOrigin()
2902         in WebKitTestRunner.
2903
2904         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2906         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2907         (WTR):
2908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2909         (TestRunner):
2910
2911 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2912
2913         Properly expose <legend> elements to ATs
2914         https://bugs.webkit.org/show_bug.cgi?id=84137
2915
2916         Reviewed by Chris Fleizach.
2917
2918         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2919         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2920         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2921
2922         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2923         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2924
2925 2012-09-10  Jer Noble  <jer.noble@apple.com>
2926
2927         Unreviewed; rolling out r128081.
2928         http://trac.webkit.org/changeset/128081
2929         https://bugs.webkit.org/show_bug.cgi?id=96134
2930
2931         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2932
2933         * DumpRenderTree/TestRunner.cpp:
2934         (TestRunner::TestRunner):
2935         (TestRunner::staticFunctions):
2936         * DumpRenderTree/TestRunner.h:
2937         (TestRunner):
2938         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2939         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2941         (WTR::InjectedBundlePage::InjectedBundlePage):
2942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2943         (InjectedBundlePage):
2944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2945         (WTR::TestRunner::TestRunner):
2946         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2947         (TestRunner):
2948
2949 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2950
2951         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2952         https://bugs.webkit.org/show_bug.cgi?id=96205
2953
2954         Reviewed by Tony Chang.
2955
2956         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2957         internally, which means that it would support only 1 TestExpectations file per port. This
2958         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2959         and efl-wk1 -> efl).
2960
2961         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2962         instead so that all the ports TestExpectations are recognized. The ports are also
2963         constructed twice, with "webkit_test_runner" option set to True and False so that we
2964         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2965
2966         * Scripts/webkitpy/style/checkers/test_expectations.py:
2967         (TestExpectationsChecker._determine_port_from_expectations_path):
2968         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2969         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2970
2971 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2972
2973         [WTR] Generated source files should include config.h
2974         https://bugs.webkit.org/show_bug.cgi?id=96254
2975
2976         Reviewed by Benjamin Poulain.
2977
2978         Current coding style has encouraged to include config.h at the first position,
2979         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2980         this rule.
2981         Therefore, this patch added it.
2982
2983         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2984         (_generateImplementationFile):
2985
2986 2012-09-10  Rick Byers  <rbyers@chromium.org>
2987
2988         Add handling of new GestureTapCancel in DRT
2989         
2990         https://bugs.webkit.org/show_bug.cgi?id=96183
2991
2992         Reviewed by Adam Barth.
2993
2994         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2995         (TestWebPlugin::handleInputEvent):
2996
2997 2012-09-10  Brady Eidson  <beidson@apple.com>
2998
2999         Javascript in foreground tabs should not wait synchronously for plug-ins to load
3000         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
3001
3002         Reviewed by Geoff Garen.
3003
3004         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
3005
3006         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
3007         (PluginObject):
3008         (SlowNPPNew::PluginObject::PluginObject):
3009         (SlowNPPNew::PluginObject::~PluginObject):
3010         (SlowNPPNew::PluginObject::hasProperty):
3011         (SlowNPPNew::PluginObject::getProperty):
3012         (SlowNPPNew::NPP_GetValue):
3013         (SlowNPPNew):
3014
3015 2012-09-10  Tim Horton  <timothy_horton@apple.com>
3016
3017         WKTR often reports an unresponsive WebProcess on Mac bots
3018         https://bugs.webkit.org/show_bug.cgi?id=95906
3019
3020         Reviewed by Dan Bernstein.
3021
3022         Attempt to work around resource contention issues by increasing the NRWT
3023         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
3024
3025         * Scripts/webkitpy/layout_tests/port/base.py:
3026         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
3027         * WebKitTestRunner/TestController.cpp:
3028         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
3029
3030 2012-09-07  Jer Noble  <jer.noble@apple.com>
3031
3032         <audio> and <video> should send Do Not Track when appropriate
3033         https://bugs.webkit.org/show_bug.cgi?id=96134
3034
3035         Reviewed by Eric Carlson.
3036
3037         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
3038         WTR. Add FrameLoaderClient client methods for retrieving that value.
3039
3040         * DumpRenderTree/TestRunner.cpp:
3041         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
3042         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
3043         * DumpRenderTree/TestRunner.h:
3044         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
3045         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3046         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3047         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
3048             Pass the question on to the TestRunner.
3049         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3050         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3051         (WTR::InjectedBundlePage::InjectedBundlePage):
3052             Add the setShouldSendDoNotTrackHTTPHeader client function.
3053         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
3054             Pass the question on to the TestRunner.
3055         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3057         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3058         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3059         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
3060
3061 2012-09-10  Ojan Vafai  <ojan@chromium.org>
3062
3063         Make EFL bots work on the flakiness dashboard
3064         https://bugs.webkit.org/show_bug.cgi?id=96164
3065
3066         Reviewed by Tony Chang.
3067
3068         Also, update outdated unittests that had started failing.
3069
3070         * TestResultServer/static-dashboards/builders.js:
3071         (isWebkitTestRunner):
3072         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3073         (nonChromiumPlatform):
3074         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3075         (test):
3076
3077 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
3078
3079         [chromium] MediaStream API: Remove the Descriptor postfix
3080         https://bugs.webkit.org/show_bug.cgi?id=96268
3081
3082         Reviewed by Adam Barth.
3083
3084         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
3085         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
3086
3087         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3088         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3089         (MockWebRTCPeerConnectionHandler::createOffer):
3090         (MockWebRTCPeerConnectionHandler::createAnswer):
3091         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3092         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3093         (MockWebRTCPeerConnectionHandler::localDescription):
3094         (MockWebRTCPeerConnectionHandler::remoteDescription):
3095         (MockWebRTCPeerConnectionHandler::addICECandidate):
3096         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3097         (MockWebRTCPeerConnectionHandler):
3098
3099 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3100
3101         [Gtk] failure to build jhbuild dependencies with cups 1.6
3102         https://bugs.webkit.org/show_bug.cgi?id=95991
3103
3104         Reviewed by Gustavo Noronha Silva.
3105
3106         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
3107         building with cups >= 1.6 [GNOME #670373].
3108
3109         * gtk/jhbuild.modules:
3110
3111 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3112
3113         [EFL][DRT] Encoding issue in printed console messages
3114         https://bugs.webkit.org/show_bug.cgi?id=96263
3115
3116         Reviewed by Kenneth Rohde Christiansen.
3117
3118         Correctly handle CONSOLE messages that contain non-ascii
3119         characters in EFL's DRT. We need to use String::fromUTF8()
3120         to construct a WTF::String from a raw string.
3121
3122         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3123         (onConsoleMessage):
3124
3125 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3126
3127         [WK2][WTR] User style sheet location should be reset before each test
3128         https://bugs.webkit.org/show_bug.cgi?id=96262
3129
3130         Reviewed by Kenneth Rohde Christiansen.
3131
3132         User style sheet location is reset before each test now.
3133
3134         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3135         (WTR::InjectedBundle::beginTesting):
3136
3137 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
3138
3139         Fix build of WTR with Qt on Windows
3140         https://bugs.webkit.org/show_bug.cgi?id=96249
3141
3142         Reviewed by Kenneth Rohde Christiansen.
3143
3144         Windows loves to define min and max as macros, which beautifully
3145         clashes in many places where min and max are used as variable or method
3146         names. It can be convinced not to do this when min and max are already
3147         define as macros (expanding to themselves). We have this kind of
3148         workaround in config.h files all over WebKit and as it turns out when
3149         building WTR with Qt on Windows we do end up with such a clash. Therefore
3150         we need the same workaround.
3151
3152         * WebKitTestRunner/config.h:
3153
3154 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3155
3156         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
3157         https://bugs.webkit.org/show_bug.cgi?id=95936
3158
3159         Reviewed by Kenneth Rohde Christiansen.
3160
3161         Enable interactive form validation setting in WebKitTestRunner as
3162         we are currently doing in DumpRenderTree. This is needed for some
3163         tests to pass.
3164
3165         * WebKitTestRunner/TestController.cpp:
3166         (WTR::TestController::resetStateToConsistentValues):
3167
3168 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
3169
3170         Clean up the code in XvfbDriver
3171         https://bugs.webkit.org/show_bug.cgi?id=96202
3172
3173         Reviewed by Philippe Normand.
3174
3175         Changes:
3176         - Remove unneeded imports,
3177         - assign the _lock_file member variable when the display number is determined,
3178         - no need for parentheses around a single string format argument,
3179         - use FileSystem.exists method when checking if lock file is present as it
3180         makes the intention much more clearer.
3181
3182         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3183         (XvfbDriver._start):
3184         (XvfbDriver.stop):
3185
3186 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
3187
3188         Make the String initialization on the function side of String::number()
3189         https://bugs.webkit.org/show_bug.cgi?id=95940
3190
3191         Reviewed by Benjamin Poulain.
3192
3193         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
3194         (testBoundaries):
3195         (testNumbers):
3196
3197 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
3198
3199         [WK2] expose element rect for color input type
3200         https://bugs.webkit.org/show_bug.cgi?id=91664
3201
3202         Reviewed by Simon Hausmann.
3203
3204         Update the QML logic in MiniBrowser to take advantage of this.
3205         The picker size is now hardcoded and we try to place it below the
3206         input element if possible.
3207
3208         * MiniBrowser/qt/qml/ColorChooser.qml:
3209
3210 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
3211
3212         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
3213         https://bugs.webkit.org/show_bug.cgi?id=95329
3214
3215         Reviewed by Kenneth Rohde Christiansen.
3216
3217         Explicitely disable TabToLinks setting in WebKitTestRunner.
3218         Tests override the "WebKitTabToLinksPreferenceKey" preference
3219         to enable it.
3220
3221         * WebKitTestRunner/TestController.cpp:
3222         (WTR::TestController::resetStateToConsistentValues):
3223
3224 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
3225
3226         webkit.py gdb pretty printer can't print CString
3227         https://bugs.webkit.org/show_bug.cgi?id=96068
3228
3229         Reviewed by Tony Chang.
3230
3231         Update WTFCStringPrinter to follow r126191.
3232
3233         * gdb/webkit.py:
3234         (WTFCStringPrinter.to_string):
3235
3236 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
3237
3238         Rename the ustring() accessor to string()
3239         https://bugs.webkit.org/show_bug.cgi?id=95919
3240
3241         Reviewed by Geoffrey Garen.
3242
3243         Update EFL's DRT.
3244
3245         Fix some string conversion that have been made useless
3246         with recent changes.
3247
3248         * DumpRenderTree/efl/EventSender.cpp:
3249         (keyPadNameFromJSValue):
3250         (keyNameFromJSValue):
3251         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3252         (TestRunner::queueLoad):
3253         (TestRunner::addOriginAccessWhitelistEntry):
3254         (TestRunner::removeOriginAccessWhitelistEntry):
3255         (TestRunner::setUserStyleSheetLocation):
3256         (TestRunner::setValueForUser):
3257         (TestRunner::elementDoesAutoCompleteForElementWithId):
3258         (TestRunner::execCommand):
3259         (TestRunner::findString):
3260         (TestRunner::isCommandEnabled):
3261         (TestRunner::clearApplicationCacheForOrigin):
3262         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3263         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3264         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3265         (toInt):
3266         (TestRunner::overridePreference):
3267         (TestRunner::addUserScript):
3268         (TestRunner::addUserStyleSheet):
3269         (TestRunner::evaluateInWebInspector):
3270         (TestRunner::evaluateScriptInIsolatedWorld):
3271         (TestRunner::setTextDirection):
3272         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3273         (LoadItem::invoke):
3274         (LoadHTMLStringItem::invoke):
3275         (ScriptItem::invoke):
3276
3277 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
3278
3279         Extend third-party storage blocking API to optionally allow blocking all storage
3280         https://bugs.webkit.org/show_bug.cgi?id=95915
3281
3282         Reviewed by Brady Eidson.
3283
3284         Modified API test to use new revised API.
3285
3286         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3287         (TestWebKitAPI::TEST):
3288
3289 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3290
3291         AX: WebCore accessibility roles should be cross-platform
3292         https://bugs.webkit.org/show_bug.cgi?id=94870
3293
3294         Reviewed by Chris Fleizach.
3295
3296         Add debug strings to Chromium for new accessibility roles.
3297
3298         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3299         (roleToString):
3300
3301 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3302
3303         AX: Chromium needs access to canvasHasFallbackContent
3304         https://bugs.webkit.org/show_bug.cgi?id=96124
3305
3306         Reviewed by Chris Fleizach.
3307
3308         Distinguish between canvas roles with and without fallback
3309         content on Chromium.
3310
3311         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3312         (getRole):
3313
3314 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3315
3316         Handle non-existant TestExpectations files gracefully
3317         https://bugs.webkit.org/show_bug.cgi?id=96149
3318
3319         Reviewed by Eric Seidel.
3320
3321         Even when we get rid of Skipped files, we shouldn't have each port
3322         require a TestExpectations file for each platform if it doesn't
3323         need one.
3324
3325         * Scripts/webkitpy/layout_tests/port/base.py:
3326         (Port.expectations_dict):
3327         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3328         (PortTest.test_nonexistant_expectations):
3329
3330 2012-09-07  Tony Chang  <tony@chromium.org>
3331
3332         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3333         https://bugs.webkit.org/show_bug.cgi?id=96136
3334
3335         Reviewed by Ojan Vafai.
3336
3337         When we renamed the file to TestExpectations, it was no longer considered a text file so
3338         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3339         from the port object, so I've removed that from the check. I'm not sure what it was
3340         supposed to do.
3341
3342         * Scripts/webkitpy/style/checker.py:
3343         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3344         * Scripts/webkitpy/style/checkers/test_expectations.py:
3345         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3346         (TestExpectationsChecker.check): Remove overrides param.
3347         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3348         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3349
3350 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3351
3352         [EFL] Use same default minimum logical font size in DRT and WTR
3353         https://bugs.webkit.org/show_bug.cgi?id=96116
3354
3355         Reviewed by Martin Robinson.
3356
3357         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3358         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3359         logical font size to 9 to match the value used in WTR.
3360         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3361         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3362         logical font size to 9 (default value in WK2)
3363
3364 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3365
3366         MediaStream API: add RTCPeerConnection::createAnswer
3367         https://bugs.webkit.org/show_bug.cgi?id=96092
3368
3369         Reviewed by Adam Barth.
3370
3371         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3372
3373         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3374         (MockWebRTCPeerConnectionHandler::createOffer):
3375         (MockWebRTCPeerConnectionHandler::createAnswer):
3376         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3377         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3378         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3379         (MockWebRTCPeerConnectionHandler):
3380
3381 2012-09-07  Dean Jackson  <dino@apple.com>
3382
3383         Unreviewed changes to watchlist.
3384
3385         - Add new WebGL and Filters definitions
3386         - Add myself to OpenGL bugs
3387
3388         * Scripts/webkitpy/common/config/watchlist:
3389
3390 2012-09-07  Peter Beverloo  <peter@chromium.org>
3391
3392         Actually trigger the Android Tester
3393         https://bugs.webkit.org/show_bug.cgi?id=96118
3394
3395         Reviewed by Adam Barth.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/config.json:
3398
3399 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3400
3401         New time input needs accessibility
3402         https://bugs.webkit.org/show_bug.cgi?id=96032
3403
3404         Reviewed by Chris Fleizach.
3405
3406         Add support for valueDescription for testing.
3407
3408         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3409         (getValueDescription):
3410         (AccessibilityUIElement::AccessibilityUIElement):
3411         (AccessibilityUIElement::valueDescriptionGetterCallback):
3412         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3413         (AccessibilityUIElement):
3414
3415 2012-09-07  Peter Beverloo  <peter@chromium.org>
3416
3417         Add the google-android-tests build slave to the master's config
3418         https://bugs.webkit.org/show_bug.cgi?id=96113
3419
3420         Reviewed by Csaba Osztrogonác.
3421
3422         * BuildSlaveSupport/build.webkit.org-config/config.json:
3423
3424 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3425
3426         [WK2] [EFL] Set theme for WebKit2 API test runner
3427         https://bugs.webkit.org/show_bug.cgi?id=96100
3428
3429         Reviewed by Kenneth Rohde Christiansen.
3430
3431         Set the theme generated by the build for the WebKit2 API test runner.
3432
3433         * TestWebKitAPI/PlatformEfl.cmake:
3434         * TestWebKitAPI/efl/PlatformWebView.cpp:
3435         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3436
3437 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3438
3439         Unreviewed. Add Gábor Ballabás as contributor.
3440
3441         * Scripts/webkitpy/common/config/committers.py:
3442
3443 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3444
3445         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3446         https://bugs.webkit.org/show_bug.cgi?id=96078
3447
3448         Reviewed by Tor Arne Vestbø.
3449
3450         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3451
3452         * qmake/mkspecs/features/default_pre.prf:
3453
3454 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3455
3456         [EFL] Add TestExpectations file for efl-wk1
3457         https://bugs.webkit.org/show_bug.cgi?id=96019
3458
3459         Reviewed by Gyuyoung Kim.
3460
3461         Update TestExpectations cascading for EFL port
3462         so that we use efl-wk1 -> efl search paths
3463         for WebKit1 EFL.
3464
3465         * Scripts/webkitpy/layout_tests/port/efl.py:
3466         (EflPort._search_paths):
3467
3468 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3469
3470         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3471         https://bugs.webkit.org/show_bug.cgi?id=95097
3472
3473         Reviewed by Dirk Pranke.
3474
3475         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3476         terminating the process does not always work as expected, leading to timeouts
3477         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3478         as it's not removed by the killed Xvfb process.
3479
3480         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3481         is tested in different circumstances - whether pixel tests are enabled or not,
3482         with an arbitrary worker number or with an Xorg process already running on the system.
3483         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3484         and then set to None.
3485
3486         * BuildSlaveSupport/kill-old-processes:
3487         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3488         is left running, potentially clogging up a display at a certain position.
3489         * Scripts/webkitpy/common/system/executive_mock.py:
3490         (MockExecutive.__init__):
3491         The _running_pids is now a dictionary with process names as keys and pids
3492         as values.
3493         (MockExecutive.check_running_pid):
3494         Check whether the passed-in pid is in the _running_pids dictionary's values.
3495         (MockExecutive):
3496         (MockExecutive.running_pids):
3497         This method returns the list of all the process pids of which the name passes
3498         through the process_name_filter.
3499         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3500         Use the Executive object of the port's host to check for running pids and open
3501         new subprocesses or kill them throughout the class.
3502         (XvfbDriver._start):
3503         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3504         start the server process after it's created.
3505         (XvfbDriver.stop):
3506         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3507         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3508         (XvfbDriverTest):
3509         (XvfbDriverTest.make_driver):
3510         (XvfbDriverTest.assertDriverStartSuccessful):
3511         (XvfbDriverTest.test_start_no_pixel_tests):
3512         (XvfbDriverTest.test_start_pixel_tests):
3513         (XvfbDriverTest.test_start_arbitrary_worker_number):
3514         (XvfbDriverTest.test_start_existing_xorg_process):
3515         (XvfbDriverTest.test_stop):
3516         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3517
3518 2012-09-06  Peter Beverloo  <peter@chromium.org>
3519
3520         Introduce the Chromium Android Release (Tests) bot
3521         https://bugs.webkit.org/show_bug.cgi?id=95980
3522
3523         Reviewed by Adam Barth.
3524
3525         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3526         which will be running layout tests on actual Android devices. Right now,
3527         four Galaxy Nexus phones are attached.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/config.json:
3530
3531 2012-09-06  James Robinson  <jamesr@chromium.org>
3532
3533         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3534         https://bugs.webkit.org/show_bug.cgi?id=96007
3535
3536         Reviewed by Adrienne Walker.
3537
3538         Fixes initialization / settings code to use WebCompositorSupport.
3539
3540         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3541         (main):
3542         * DumpRenderTree/chromium/TestShell.cpp:
3543         (TestShell::initialize):
3544         (TestShell::setPerTilePaintingEnabled):
3545
3546 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3547
3548         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3549         https://bugs.webkit.org/show_bug.cgi?id=95995
3550
3551         Reviewed by Kenneth Rohde Christiansen.
3552
3553         Provide proper implementation for PlatformWebView::windowFrame()
3554         in EFL's WebKitTestRunner.
3555
3556         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3557         (WTR::PlatformWebView::windowFrame):
3558
3559 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3560
3561         Fix WTF.Lrint on 32-bit platforms
3562         https://bugs.webkit.org/show_bug.cgi?id=96003
3563
3564         Reviewed by Benjamin Poulain.
3565
3566         Fixed failing WTF.Lrint test on 32-bit platforms.
3567
3568         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3569         (TestWebKitAPI::TEST):
3570
3571 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3572
3573         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3574         https://bugs.webkit.org/show_bug.cgi?id=95839
3575
3576         Reviewed by Adam Barth.
3577
3578         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3579         up the task definitions a bit. There was no need to have them in the header file.
3580
3581         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3582         (RTCSessionDescriptionRequestSuccededTask):
3583         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3584         (RTCSessionDescriptionRequestFailedTask):
3585         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3586         (RTCVoidRequestTask):
3587         (RTCVoidRequestTask::RTCVoidRequestTask):
3588         (MockWebRTCPeerConnectionHandler::createOffer):
3589         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3590         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3591         (MockWebRTCPeerConnectionHandler::localDescription):
3592         (MockWebRTCPeerConnectionHandler::remoteDescription):
3593         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3594         (MockWebRTCPeerConnectionHandler):
3595
3596 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3597
3598         [Qt] Fix build on Mac OS X 10.6
3599         https://bugs.webkit.org/show_bug.cgi?id=95200
3600
3601         Reviewed by Tor Arne Vestbø.
3602
3603         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3604         10.7 and newer.
3605
3606         * qmake/mkspecs/features/features.prf:
3607
3608 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3609
3610         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3611         https://bugs.webkit.org/show_bug.cgi?id=95973
3612
3613         Reviewed by Kenneth Rohde Christiansen.
3614
3615         Correctly map "addSelectionKey" to "Control" modifier
3616         in WKTR's EventSender on other OSes than Mac OS X,
3617         instead of mapping it to the "Meta" modifier.
3618
3619         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3620         (WTR::parseModifier):
3621
3622 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3623
3624         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3625         https://bugs.webkit.org/show_bug.cgi?id=95710
3626
3627         Reviewed by Dirk Pranke.
3628
3629         The stdout / stderr output can be None so make sure
3630         we won't raise an exception in this case.
3631
3632         * Scripts/webkitpy/layout_tests/port/driver.py:
3633         (Driver.run_test):
3634
3635 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3636
3637         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3638         https://bugs.webkit.org/show_bug.cgi?id=95849
3639
3640         Reviewed by Kenneth Rohde Christiansen.
3641
3642         Sanitize URLs passed by the user as program
3643         argument or typed in the URL bar in order to
3644         be more tolerant.
3645
3646         * EWebLauncher/CMakeLists.txt:
3647         * EWebLauncher/main.c:
3648         (main):
3649         * EWebLauncher/url_bar.c:
3650         (_url_bar_url_get_with_protocol):
3651         (on_urlbar_key_down):
3652         * EWebLauncher/url_utils.c: Added.
3653         (has_scheme):
3654         (url_from_user_input): Add utility function to construct a
3655         URL from user input.
3656         * EWebLauncher/url_utils.h: Added.
3657         * MiniBrowser/efl/CMakeLists.txt:
3658         * MiniBrowser/efl/main.c:
3659         (main):
3660
3661 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3662
3663         [Qt] Various small Windows / MSVC build fixes
3664         https://bugs.webkit.org/show_bug.cgi?id=95934
3665
3666         Reviewed by Kenneth Rohde Christiansen.
3667
3668         setFocus takes a boolean as argument: Don't try to implicitly convert
3669         an enum to a boolean, MSVC doesn't like that. The intent here is to
3670         enable focus, so just pass true.
3671
3672         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3673         (WTR::PlatformWebView::focus):
3674
3675 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3676
3677         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3678         https://bugs.webkit.org/show_bug.cgi?id=95965
3679
3680         Reviewed by Tor Arne Vestbø.
3681
3682         Add ANGLE as a static library module to the Qt WebKit build system.
3683
3684         * qmake/mkspecs/features/default_post.prf:
3685         * qmake/mkspecs/modules/angle.prf: Added.
3686
3687 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3688
3689         [WK2] Make [Qt]ViewportHandler cross platform
3690         https://bugs.webkit.org/show_bug.cgi?id=91257
3691
3692         Reviewed by Kenneth Rohde Christiansen.
3693
3694         Remove initial scale from viewport info item since it is
3695         set to -1 after applied thus it does not hold any valuable
3696         information.
3697
3698         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3699
3700 2012-09-05  Tony Chang  <tony@chromium.org>
3701
3702         [chromium] Remove dependency on webkit_user_agent
3703         https://bugs.webkit.org/show_bug.cgi?id=95886
3704
3705         Reviewed by Adam Barth.
3706
3707         The code isn't used by DumpRenderTree.
3708
3709         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3710
3711 2012-09-05  Rick Byers  <rbyers@chromium.org>
3712
3713         Update chromium DumpRenderTree for new WebGestureEvent fields
3714         https://bugs.webkit.org/show_bug.cgi?id=95573
3715
3716         Reviewed by James Robinson.
3717
3718         Update EventSender to write gesture details into the appropriate
3719         type-specific WebGestureEvent fields.
3720         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3721         (EventSender::gestureEvent):
3722         (EventSender::gestureFlingStart):
3723
3724 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3725
3726         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3727         https://bugs.webkit.org/show_bug.cgi?id=95789
3728
3729         Reviewed by Ojan Vafai.
3730
3731         Fix miscalculation in log message.
3732
3733         * Scripts/webkitpy/layout_tests/views/printing.py:
3734         (Printer.print_found):
3735
3736 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3737
3738         Unreviewed, rolling out r127612, r127660, and r127664.
3739         http://trac.webkit.org/changeset/127612
3740         http://trac.webkit.org/changeset/127660
3741         http://trac.webkit.org/changeset/127664
3742         https://bugs.webkit.org/show_bug.cgi?id=95920
3743
3744         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3745         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3746         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3747         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3748         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3749         (MockWebRTCPeerConnectionHandler::createOffer):
3750         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3751         (MockWebRTCPeerConnectionHandler):
3752         (SuccessCallbackTask):
3753         (FailureCallbackTask):
3754
3755 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3756
3757         Ignore-metrics includes scroll offsets.
3758         https://bugs.webkit.org/show_bug.cgi?id=95845
3759
3760         Reviewed by Dirk Pranke.
3761
3762         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3763
3764         * Scripts/old-run-webkit-tests:
3765         (stripMetrics):
3766         * Scripts/webkitpy/layout_tests/port/driver.py:
3767         (DriverOutput):
3768
3769 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3770
3771         Unreviewed test fix.
3772
3773         Including a plugin source file into the build that was added in r127595.
3774
3775         * GNUmakefile.am:
3776
3777 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3778
3779         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3780         https://bugs.webkit.org/show_bug.cgi?id=95839
3781
3782         Reviewed by Adam Barth.
3783
3784         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3785         up the task definitions a bit. There was no need to have them in the header file.
3786
3787         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3788         (RTCSessionDescriptionRequestSuccededTask):
3789         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3790         (RTCSessionDescriptionRequestFailedTask):
3791         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3792         (RTCVoidRequestTask):
3793         (RTCVoidRequestTask::RTCVoidRequestTask):
3794         (MockWebRTCPeerConnectionHandler::createOffer):
3795         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3796         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3797         (MockWebRTCPeerConnectionHandler::localDescription):
3798         (MockWebRTCPeerConnectionHandler::remoteDescription):
3799         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3800         (MockWebRTCPeerConnectionHandler):
3801
3802 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3803
3804         [EFL] Remove '+=' usage in String
3805         https://bugs.webkit.org/show_bug.cgi?id=95808
3806
3807         Reviewed by Benjamin Poulain.
3808
3809         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3810
3811         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3812         (descriptionSuitableForTestResult):
3813
3814 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3815
3816         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3817         https://bugs.webkit.org/show_bug.cgi?id=95842
3818
3819         Reviewed by Kenneth Rohde Christiansen.
3820
3821         Provide proper implementation for TestRunner::pathToLocalResource()
3822         in EFL WKTR, identical to the one for DumpRenderTree.
3823
3824         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3825         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3826         are found my WebKitTestRunner.
3827
3828         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3829         (WTR::TestRunner::pathToLocalResource):
3830
3831 2012-09-05  Brady Eidson  <beidson@apple.com>
3832
3833         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3834         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3835
3836         Reviewed by Andy Estes.
3837
3838         Add a plug-in that always fails to initialize:
3839         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3840         (NPPNewFails):
3841         (NPPNewFails::NPPNewFails):
3842         (NPPNewFails::NPP_New):
3843
3844         Add it to all the project files:
3845         * DumpRenderTree/DumpRenderTree.gypi:
3846         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3847         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3848         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3849         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3850
3851 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3852
3853         [Qt] Fix makefile race condition between derived sources and target
3854
3855         r121966 removed too much of the old qmake logic, including the rule
3856         that ensured that qmake_all would not trigger dual runs of qmake --
3857         one of the derived sources -qmake-all rule, and one for making the
3858         derived sources.
3859
3860         We now follow a similar pattern as before, by introducing a custom
3861         target that explicitly depends on the derived sources' qmake-all before
3862         doing a manual run of make. That ensures a single qmake run for the derived
3863         sources.
3864
3865         https://bugs.webkit.org/show_bug.cgi?id=93847
3866
3867         Reviewed by Csaba Osztrogonác.
3868
3869         * qmake/mkspecs/features/functions.prf:
3870
3871 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3872
3873         WKTR doesn't implement dumpWillCacheResponse()
3874         https://bugs.webkit.org/show_bug.cgi?id=94607
3875
3876         Reviewed by Kenneth Rohde Christiansen.
3877
3878         Define shouldCacheResponse() callback in resource
3879         load client and provide implementation for
3880         dumpWillCacheResponse() in WebKitTestRunner.
3881
3882         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3884         (WTR::InjectedBundlePage::InjectedBundlePage):
3885         (WTR::InjectedBundlePage::shouldCacheResponse):
3886         (WTR):
3887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3888         (InjectedBundlePage):
3889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3890         (WTR::TestRunner::TestRunner):
3891         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3892         (WTR::TestRunner::dumpWillCacheResponse):
3893         (WTR::TestRunner::shouldDumpWillCacheResponse):
3894         (TestRunner):
3895
3896 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3897
3898         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3899         https://bugs.webkit.org/show_bug.cgi?id=92735
3900
3901         Reviewed by Hajime Morita.
3902
3903         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3904
3905         * DumpRenderTree/TestRunner.cpp:
3906         (TestRunner::staticFunctions):
3907         * DumpRenderTree/TestRunner.h:
3908         (TestRunner):
3909         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3910         (TestRunner::addUserStyleSheet):
3911         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3912         (DRTTestRunner::DRTTestRunner):
3913         (DRTTestRunner::hasCustomPageSizeStyle):
3914         * DumpRenderTree/chromium/DRTTestRunner.h:
3915         (DRTTestRunner):
3916         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3917         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3918         * DumpRenderTree/mac/TestRunnerMac.mm:
3919         * DumpRenderTree/qt/TestRunnerQt.cpp:
3920         (TestRunner::evaluateScriptInIsolatedWorld):
3921         * DumpRenderTree/qt/TestRunnerQt.h:
3922         (TestRunner):
3923         * DumpRenderTree/win/TestRunnerWin.cpp:
3924         * DumpRenderTree/wx/TestRunnerWx.cpp:
3925         (TestRunner::abortModal):
3926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3928         (WTR):
3929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3930         (TestRunner):
3931
3932 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3933
3934         [Qt] Automate the use of AllInOne files in the Qt build
3935         https://bugs.webkit.org/show_bug.cgi?id=95837
3936
3937         Reviewed by Tor Arne Vestbø.
3938
3939         New feature file that implements the all-in-one file automation by
3940         adding the requested all-in-one files to SOURCES and removing the files
3941         it includes from SOURCES.
3942
3943         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3944
3945 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3946
3947         Have NRWT log more output when crash logs are missing
3948         https://bugs.webkit.org/show_bug.cgi?id=95814
3949
3950         Reviewed by Dan Bernstein.
3951
3952         Log the stderr and stdout of the test, in order to provide slightly more
3953         context when the WebProcess times out while running tests.
3954
3955         * Scripts/webkitpy/layout_tests/port/driver.py:
3956         (Driver.run_test):
3957
3958 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3959
3960         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3961         https://bugs.webkit.org/show_bug.cgi?id=95770
3962
3963         Reviewed by Adam Barth.
3964
3965         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3966         (ChromiumAndroidDriver.__init__):
3967         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3968         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3969         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3970         (ChromiumAndroidDriver._push_executable):
3971         (ChromiumAndroidDriver._push_fonts):
3972         (ChromiumAndroidDriver._push_test_resources):
3973         (ChromiumAndroidDriver._run_adb_command):
3974         (ChromiumAndroidDriver._get_last_stacktrace):
3975         (ChromiumAndroidDriver._get_crash_log):
3976         (ChromiumAndroidDriver._start):
3977         (ChromiumAndroidDriver._start_once):
3978         (ChromiumAndroidDriver._start_once.deadlock_detector):
3979         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3980         (ChromiumAndroidDriverTest.test_get_crash_log):
3981
3982 2012-09-04  Satish Sampath  <satish@chromium.org>
3983
3984         Run git commands within the checkout directory
3985         https://bugs.webkit.org/show_bug.cgi?id=95742
3986
3987         Reviewed by Eric Seidel.
3988
3989         git commands run from scm/git.py are sometimes run with cwd set to the
3990         checkout_root and other times with whatever directory was the default cwd.
3991         Instead all these should run with the checkout root set as the cwd
3992         (except where we explicitly need a different path)
3993
3994         * Scripts/webkitpy/common/checkout/scm/git.py:
3995         (Git._run_git):
3996         (Git.find_checkout_root):
3997         (Git.discard_local_commits):
3998         (Git.local_commits):
3999         (Git.working_directory_is_clean):
4000         (Git.clean_working_directory):
4001         (Git.add_list):
4002         (Git.delete_list):
4003         (Git.exists):
4004         (Git._current_branch):
4005         (Git._changes_files_for_commit):
4006         (Git.revisions_changing_file):
4007         (Git.svn_revision):
4008         (Git._run_git_svn_find_rev):
4009         (Git.contents_at_revision):
4010         (Git.diff_for_file):
4011         (Git.show_head):
4012         (Git.committer_email_for_revision):
4013         (Git.apply_reverse_diff):
4014         (Git.revert_files):
4015         (Git.commit_with_message):
4016         (Git._commit_on_branch):
4017         (Git.svn_commit_log):
4018         (Git.last_svn_commit_log):
4019         (Git.svn_blame):
4020         (Git._branch_ref_exists):
4021         (Git.delete_branch):
4022         (Git.remote_merge_base):
4023         (Git.commit_locally_with_message):
4024         (Git.push_local_commits_to_server):
4025         (Git.commit_ids_from_commitish_arguments):
4026         (Git.commit_message_for_local_commit):
4027         (Git.files_changed_summary_for_commit):
4028
4029 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
4030
4031         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
4032         https://bugs.webkit.org/show_bug.cgi?id=95734
4033
4034         Reviewed by Adam Barth.
4035
4036         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4037         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
4038         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
4039         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
4040         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
4041         (MockWebRTCPeerConnectionHandler::createOffer):
4042         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4043         (MockWebRTCPeerConnectionHandler):
4044         (MockWebRTCPeerConnectionHandler::taskList):
4045         (SuccessCallbackTask):
4046         (FailureCallbackTask):
4047
4048 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
4049
4050         [Chromium-Android] Output time and thread info in crash log
4051         https://bugs.webkit.org/show_bug.cgi?id=95768
4052
4053         Reviewed by Adam Barth.
4054
4055         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4056         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
4057
4058 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
4059
4060         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
4061         https://bugs.webkit.org/show_bug.cgi?id=95721
4062
4063         Reviewed by Adam Barth.
4064
4065         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
4066         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
4067         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
4068         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
4069         (MockWebMediaStreamCenter):
4070
4071 2012-09-04  Tony Chang  <tony@chromium.org>
4072
4073         Elide test names when running new-run-webkit-tests
4074         https://bugs.webkit.org/show_bug.cgi?id=95626
4075
4076         Reviewed by Dirk Pranke.
4077
4078         When the test name exceeds the number of terminal columns, it leaves
4079         text on the screen. Avoid this by eliding the test name when running
4080         tests. This is similar to what ninja does when compiling.
4081
4082         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4083         (MeteredStream):
4084         (MeteredStream.number_of_columns): Helper method to get number of
4085         terminal columns. Won't work on Win32 python, but meh.
4086         * Scripts/webkitpy/layout_tests/views/printing.py:
4087         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
4088         because stderr appears to be ascii only.
4089         (Printer.print_started_test): Route through _test_status_line.
4090         (Printer.print_finished_test): Route through _test_status_line.
4091         (Printer._print_test_trace): Route through _test_status_line.
4092         (Printer._print_baseline): Route through _test_status_line.
4093         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4094         (test_test_status_line): Test for _test_status_line.
4095
4096 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
4097
4098         [GTK] Print API missing documentation when generating gtkdoc
4099         https://bugs.webkit.org/show_bug.cgi?id=95703
4100
4101         Reviewed by Carlos Garcia Campos.
4102
4103         Print out API missing documentation when generating gtkdoc. This makes it
4104         easier to fix documentation errors.
4105
4106         * gtk/generate-gtkdoc:
4107         (print_missing_api): Added.
4108         (generate_doc): Inline the rebase step, since it now reports an error
4109         when you try to rebase without generating documentation first.
4110         * gtk/gtkdoc.py:
4111         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
4112         generating documentation first to enable a small cleanup at the caller.
4113         (GTKDoc.api_missing_documentation): Added.
4114
4115 2012-09-04  Vincent Scheib  <scheib@chromium.org>
4116
4117         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
4118         https://bugs.webkit.org/show_bug.cgi?id=95628
4119
4120         Reviewed by James Robinson.
4121
4122         Future tests need the ability to respond asynchronously that
4123         pointer lock requests have been accepted or rejected. This patch
4124         adds the following:
4125             testRunner.setPointerLockWillRespondAsynchronously();
4126             testRunner.didAcquirePointerLock();
4127             testRunner.didNotAcquirePointerLock();
4128
4129         Tested in existing test:
4130             pointerlockchange-pointerlockerror-events.html
4131
4132         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4133         (DRTTestRunner::DRTTestRunner):
4134         (DRTTestRunner::didAcquirePointerLock):
4135         (DRTTestRunner::didNotAcquirePointerLock):
4136         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
4137         * DumpRenderTree/chromium/DRTTestRunner.h:
4138         (DRTTestRunner):
4139         * DumpRenderTree/chromium/WebViewHost.cpp:
4140         (WebViewHost::requestPointerLock):
4141         (WebViewHost::didAcquirePointerLock):
4142         (WebViewHost::didNotAcquirePointerLock):
4143         * DumpRenderTree/chromium/WebViewHost.h:
4144         (WebViewHost):
4145         (WebViewHost::setPointerLockWillRespondAsynchronously):
4146
4147 2012-09-04  Ojan Vafai  <ojan@chromium.org>
4148
4149         Move content shell bots to their own builder group
4150         https://bugs.webkit.org/show_bug.cgi?id=95765
4151
4152         Reviewed by Adam Barth.
4153
4154         In their current state of instability, they add too much noise. Once they get more stable,
4155         we can add them back to the regular group or just have them replace the other bots.
4156
4157         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
4158
4159         * TestResultServer/static-dashboards/builders.js:
4160         (isWebkitTestRunner):
4161         (isChromiumContentShellTestRunner):
4162         (isChromiumWebkitTipOfTreeTestRunner):
4163         (loadBuildersList):
4164
4165 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
4166
4167         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
4168         https://bugs.webkit.org/show_bug.cgi?id=95689
4169
4170         Reviewed by Kenneth Rohde Christiansen.
4171
4172         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
4173         So, there are bugs that key events are always generated in url bar although
4174         the user clicked the web view.
4175
4176         This patch recovers the focus of the web view when left button is pressed and
4177         adds for MiniBrowser to toggle the focus when middle button is pressed
4178         like EWebLauncher already did.
4179
4180         * EWebLauncher/main.c:
4181         (on_mouse_down):
4182         * MiniBrowser/efl/main.c:
4183         (on_mouse_down):
4184         (browserCreate):
4185
4186 2012-09-03  Tao Bai  <michaelbai@chromium.org>
4187
4188         Added ANDROID_GDBSERVER definition for Ant
4189         https://bugs.webkit.org/show_bug.cgi?id=95265
4190
4191         Reviewed by Adam Barth.
4192
4193         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
4194         is only used for finding the gdbserver.
4195
4196         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4197         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4198
4199 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
4200
4201         MediaStream API: Add Ice-related functionality to RTCPeerConnection
4202         https://bugs.webkit.org/show_bug.cgi?id=95565
4203
4204         Reviewed by Adam Barth.
4205
4206         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4207         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4208         (MockWebRTCPeerConnectionHandler::updateICE):
4209         (MockWebRTCPeerConnectionHandler::addICECandidate):
4210         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4211         (MockWebRTCPeerConnectionHandler):
4212
4213 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
4214
4215         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
4216         https://bugs.webkit.org/show_bug.cgi?id=95670
4217
4218         Reviewed by Kenneth Rohde Christiansen.
4219
4220         Fix layout issues related to the URL bar in Minibrowser
4221         and EWebLauncher when the window is resized.
4222
4223         The URL bar was not resized accordingly and the Web
4224         page was moved behing the URL bar, hiding part of it.
4225
4226         * EWebLauncher/main.c:
4227         (on_ecore_evas_resize):
4228         (closeWindow):
4229         * EWebLauncher/url_bar.c:
4230         (url_bar_width_set):
4231         (url_bar_add):
4232         * EWebLauncher/url_bar.h:
4233         * MiniBrowser/efl/main.c:
4234         (on_ecore_evas_resize):
4235         (main):
4236
4237 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
4238
4239         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
4240         https://bugs.webkit.org/show_bug.cgi?id=95605
4241
4242         Reviewed by Dirk Pranke.
4243
4244         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
4245
4246         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4247         (ChromiumAndroidPort.check_sys_deps):
4248         (ChromiumAndroidPort.expectations_files):
4249         (ChromiumAndroidPort.clean_up_test_run):
4250
4251 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
4252
4253         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
4254         https://bugs.webkit.org/show_bug.cgi?id=95180
4255
4256         Reviewed by Chris Fleizach.
4257
4258         The bug that was fixed stood in the way of fully implementing stringValue().
4259         Testing that the bug is fixed requires stringValue() to be fully implemented
4260         and object replacement characters to be printable.
4261
4262         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4263         (replaceCharactersForResults): New method which turns object replacement
4264         characters into "<obj>" so that the characters can be properly shown in
4265         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
4266         accessible text of a single object in the accessible tree doesn't mess up
4267         the readibility of the results.
4268         (AccessibilityUIElement::stringValue): Remove the code that immediately
4269         returned upon encountering an object of ATK_ROLE_PANEL and call the new
4270         replaceCharactersForResults() prior to returning the accessible string
4271         value.
4272
4273 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
4274
4275         MediaStream API: Add MediaStream management to RTCPeerConnection
4276         https://bugs.webkit.org/show_bug.cgi?id=95543
4277
4278         Reviewed by Adam Barth.
4279
4280         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
4281
4282         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4283         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4284         (MockWebRTCPeerConnectionHandler::addStream):
4285         (MockWebRTCPeerConnectionHandler::removeStream):
4286         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4287         (MockWebRTCPeerConnectionHandler):
4288
4289 2012-08-31  Tony Chang  <tony@chromium.org>
4290
4291         Remove ENABLE_CSS3_FLEXBOX compile time flag
4292         https://bugs.webkit.org/show_bug.cgi?id=95382
4293
4294         Reviewed by Ojan Vafai.
4295
4296         Everyone is already enabling this by default and the spec has stablized.
4297
4298         * Scripts/webkitperl/FeatureList.pm:
4299         * qmake/mkspecs/features/features.pri:
4300
4301 2012-08-31  Pratik Solanki  <psolanki@apple.com>
4302
4303         objc_msgSend and IMP should be cast appropriately before using
4304         https://bugs.webkit.org/show_bug.cgi?id=95242
4305
4306         Reviewed by Benjamin Poulain.
4307
4308         Fix for older compilers. Pass id as the return type to the template
4309         instead of relying on default type.
4310
4311         * DumpRenderTree/mac/DumpRenderTree.mm:
4312         (drt_NSFontManager_availableFontFamilies):
4313         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4314         (WTR::wtr_NSFontManager_availableFontFamilies):
4315
4316 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
4317
4318         nrwt: use scm instead of calling svn directly to get the revision in json results generator
4319         https://bugs.webkit.org/show_bug.cgi?id=89616
4320
4321         Reviewed by Eric Seidel.
4322
4323         Add the new 'executive' optional function argument to the SCM.in_working_directory
4324         class method. This way we get to reuse an