[GTK] run-perf-tests should run the tests inside the jhbuild shell.
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
4         https://bugs.webkit.org/show_bug.cgi?id=133533
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
9         (run): Remove the jhbuild-wrapper wrapper from here. It should be
10         on Scripts/webkitpy/port/gtk.py.
11         * Scripts/webkitpy/port/base.py:
12         (Port.set_option): Add a set_option(name, value) function to set
13         the optparse parameter "name" to the value "value", even if the
14         parameter "name" is already initialized.
15         * Scripts/webkitpy/port/gtk.py:
16         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
17         If another wrapper is specified via the option "-l --wrapper=x",
18         then prepend the jhbuild-wrapper to the one specified.
19
20 2014-06-04  David Farler  <dfarler@apple.com>
21
22         Build ASan WebKit for iOS Simulator
23         https://bugs.webkit.org/show_bug.cgi?id=133489
24
25         Reviewed by Darin Adler.
26
27         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
28         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
29         - Add missing ASan LDFLAGS.
30         * asan/asan.xcconfig:
31         - Split compiler-rt linker flags for OS X and iOS Simulator
32
33 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
34
35         Add myself (yoav@yoav.ws) to contributors.json
36         https://bugs.webkit.org/show_bug.cgi?id=133492
37
38         * Scripts/webkitpy/common/config/contributors.json:
39
40 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
41
42         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
43         https://bugs.webkit.org/show_bug.cgi?id=133149
44
45         Reviewed by Csaba Osztrogonác.
46
47         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
48
49 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
50
51         Add a verbose flag to binding tests
52         https://bugs.webkit.org/show_bug.cgi?id=122303
53
54         Reviewed by Csaba Osztrogonác.
55
56         This patch will:
57         - Add a verbose keyword argument to the BindingsTests constructor,
58         - Add --no-verbose option to the run-bindigs-test.
59         Verbose mode, which is on by default, prints positive results to stdout as before.
60         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
61
62         Original patch from Matthew Hanson <matthew_hanson@apple.com>
63
64         * Scripts/run-bindings-tests:
65         (main):
66         * Scripts/webkitpy/bindings/main.py:
67         (BindingsTests.__init__):
68         (BindingsTests.detect_changes):
69
70 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
71
72         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
73         https://bugs.webkit.org/show_bug.cgi?id=133455
74
75         Reviewed by Timothy Hatcher.
76
77         Since the perf. dashboard doesn't support following renamed benchmarks,
78         keep reporting Speedometer results as DoYouEvenBench results.
79
80         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
81         (_generate_results_dict):
82
83 2014-05-31  Darin Adler  <darin@apple.com>
84
85         Viewport percentage tests that resize the viewport are flaky
86         https://bugs.webkit.org/show_bug.cgi?id=133351
87
88         Reviewed by Anders Carlsson.
89
90         * DumpRenderTree/mac/DumpRenderTree.mm:
91         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
92         happens to be stored in the UI delegate object. This is part of resetting the
93         window position.
94
95         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
96         a frame rectangle. The size is stored in the size of the web view itself.
97         * DumpRenderTree/mac/UIDelegate.mm:
98         (-[UIDelegate resetWindowOrigin]): Added.
99         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
100         old version would store the frame, but not resize the web view!
101         (-[UIDelegate webViewFrame:]): Get the size from the web view.
102
103         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
104         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
105
106         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
107         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
108         the window.
109
110         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
111         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
112         window gets resized too, not just the web view.
113         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
114
115         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
116         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
117         window gets resized too, not just the web view.
118         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
119
120 2014-05-30  Michael Saboff  <msaboff@apple.com>
121
122         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
123         https://bugs.webkit.org/show_bug.cgi?id=133409
124
125         Reviewed by Filip Pizlo.
126
127         Handle creating a tarball the same way as running remote when processing
128         paths in prepareBundle.
129
130         * Scripts/run-jsc-stress-tests:
131
132 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
133
134         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
135         https://bugs.webkit.org/show_bug.cgi?id=132280
136
137         Reviewed by Chris Fleizach.
138
139         Remove implementation of logAccessibilityEvents() for ATK based
140         ports, as this has proved to be a flaky method of checking that
141         ATK events are being properly emitted. Instead, it's better to use
142         the addNotificationListener() functions and provide a JS callback
143         to check that the right events are being emmitted from the tests.
144
145         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
146         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
147         with dummy implementation.
148         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
149         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
150
151 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
152
153         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
154         https://bugs.webkit.org/show_bug.cgi?id=132280
155
156         Rubber stamped by Carlos Garcia Campos.
157
158         Fix two small issues with previous patch (r169483), that caused some tests to break.
159
160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
161         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
162         duplicated entry.
163         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
164         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
165
166 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
167
168         [ATK] Added new accessibility signal: text-caret-moved.
169         Make AccessibilityUIElement.setSelectedTextRange work
170         as atk_text_set_caret_offset when given offset == 0.
171         https://bugs.webkit.org/show_bug.cgi?id=132527
172
173         Reviewed by Mario Sanchez Prada.
174
175         text-caret-moved signal in accessibilityController is needed to
176         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
177         as LayoutTests. Add the signal to the controller.
178
179         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
180         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
181         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
182         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
183         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
184         (setSelectedTextRange): Change return type to bool.
185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
186         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
187         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
188         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
189         for extra arguments passed to handler and use it for text-caret-moved offset.
190         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
191         Connect callback to new listener for ATK:AtkText:text-caret-moved.
192         Refactor so that failures be reported.
193         Initialize atk interfaces before trying to connect to them, see
194         https://bugzilla.gnome.org/show_bug.cgi?id=729922
195         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
196         Simplify code by using a vector in place of dozen variables.
197         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
198         Comment about not synchronizing with accessibilityController.
199
200 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
201
202         [GTK] Add a WebKit2 Performance bot.
203         https://bugs.webkit.org/show_bug.cgi?id=132862
204
205         Reviewed by Csaba Osztrogonác.
206
207         This adds a GTK WebKit2 perf bot.
208
209         * BuildSlaveSupport/build.webkit.org-config/config.json:
210
211 2014-05-29  Dan Bernstein  <mitz@apple.com>
212
213         Fixed the WebKitTestRunner build after r169452.
214
215         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
216         (WTR::InjectedBundle::initialize):
217
218 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
219
220         Unreviewed. Update my email addresses in contributors.json.
221
222         * Scripts/webkitpy/common/config/contributors.json:
223
224 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
225
226         Need an API test for bug #133193 (r169315)
227         <https://bugs.webkit.org/show_bug.cgi?id=133324>
228
229         This adds an API test that ensures that calling "stop loading" during a
230         "did fail provisional load" callback doesn't crash.
231
232         Reviewed by Andy Estes.
233
234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
235         Add new files to project.
236
237         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
238         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
239         If the message is the "test done" message, record that.
240         (TestWebKitAPI::setInjectedBundleClient):
241         Register a function for the "did receive message from injected bundle"
242         callback.
243         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
244         Assert that we received the message from the injected bundle, and set
245         'done' to finish the test.
246         (TestWebKitAPI::TEST):
247         Create a WebView, register a page loader client for the "did fail
248         provisional load" callback, and load a non-existent resource.
249
250         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
251         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
252         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
253         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
254         provisional load failed.
255         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
256         Register a page loader client for the "did fail provisional load"
257         callback.
258         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
259         Call WKBundlePageStopLoading() during the callback. This not crashing
260         is what we're ensuring with this test.
261
262 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
263
264         [GTK] Make it possible to build with FTL enabled
265         https://bugs.webkit.org/show_bug.cgi?id=133219
266
267         Reviewed by Philippe Normand.
268
269         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
270         same revision than mac.
271
272 2014-05-27  Michael Saboff  <msaboff@apple.com>
273
274         REGRESSION(r169265): sh: line 0: cd: ../.vm
275         https://bugs.webkit.org/show_bug.cgi?id=133242
276
277         Rubber stamped by Oliver Hunt.
278
279         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
280         array since the command may contain character escapes that don't work with the
281         array form of system().
282
283         * Scripts/run-jsc-stress-tests:
284
285 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
286
287         [EFL] Change download url of freetype6
288         https://bugs.webkit.org/show_bug.cgi?id=133303
289
290         Reviewed by Csaba Osztrogonác.
291
292         freetype6 tarball isn't downloaded in Korea. So, we need to
293         change the url for now.
294
295         * efl/jhbuild.modules:
296
297 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
298
299         Remove BLOB guards
300         https://bugs.webkit.org/show_bug.cgi?id=132863
301
302         Reviewed by Csaba Osztrogonác.
303
304         * Scripts/webkitperl/FeatureList.pm:
305
306 2014-05-27  Alberto Garcia  <berto@igalia.com>
307
308         Remove leftover comment from r165182.
309
310         Rubber stamped by Carlos Garcia Campos.
311
312         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
313
314 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
315
316         [EFL] Add LLVM as optional jhbuild module for FTL developers
317         https://bugs.webkit.org/show_bug.cgi?id=133216
318
319         Reviewed by Gyuyoung Kim.
320
321         * efl/jhbuild.modules:
322
323 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
324
325         Fix test failures on python test
326         https://bugs.webkit.org/show_bug.cgi?id=133297
327
328         Reviewed by Dirk Schulze.
329
330         2 tests are failing because of unbounded local variable reference in test_importer.py.
331
332         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
333         (TestImporter.import_tests):
334
335 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
336
337         [GTK] GObject DOM bindings API break test fails in the tests bots
338         https://bugs.webkit.org/show_bug.cgi?id=133211
339
340         Reviewed by Martin Robinson.
341
342         When generating the built product archive on platform GTK, we need
343         to copy also the file gtkdoc-webkitdom.cfg and the directory
344         DerivedSources/webkitdom.
345
346         * BuildSlaveSupport/built-product-archive:
347         (archiveBuiltProduct):
348
349 2014-05-26  Commit Queue  <commit-queue@webkit.org>
350
351         Unreviewed, rolling out r169122.
352         https://bugs.webkit.org/show_bug.cgi?id=133288
353
354         Broke CJK font fallback (Requested by ap on #webkit).
355
356         Reverted changeset:
357
358         "[Mac] WebProcess doesn't follow localization of UI process
359         when run as a service"
360         https://bugs.webkit.org/show_bug.cgi?id=133126
361         http://trac.webkit.org/changeset/169122
362
363 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
364
365         [GTK] WebProcess leaked when closing pages with network process enabled
366         https://bugs.webkit.org/show_bug.cgi?id=129684
367
368         Reviewed by Anders Carlsson.
369
370         Enable the test to check that web processes finish when the web
371         view is destroyed.
372
373         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
374
375 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
376
377         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
378         https://bugs.webkit.org/show_bug.cgi?id=133279
379
380         Reviewed by Philippe Normand.
381
382         generator.saw_warnings is only set by GTKDoc::generate(), so it
383         should only be used after generate.
384
385         * gtk/generate-gtkdoc:
386         (generate_documentation_for_config): Do not check
387         generator.saw_warnings again, simply return the value returned by
388         generate_doc() which is generator.saw_warnings. When rebasing,
389         returns always False since there aren't warnings.
390
391 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
392
393         W3C test importer should catch exceptions coming from HTML/CSS conversion
394         https://bugs.webkit.org/show_bug.cgi?id=133176
395
396         Reviewed by Darin Adler.
397
398         Exceptions raised when converting HTML/CSS are caught.
399         Files for which conversion failed are still copied to the target directory.
400         Each individual conversion failure is logged.
401         Total conversion failure number is logged at the end of the import process.
402
403         * Scripts/webkitpy/w3c/test_importer.py:
404         (TestImporter.import_tests):
405
406 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
407
408         [GTK] Allow to run the tests on the native X display.
409         https://bugs.webkit.org/show_bug.cgi?id=133157
410
411         Reviewed by Benjamin Poulain.
412
413         This adds a new driver (xorgdriver) that runs the tests on the
414         X display referenced by the environment variable DISPLAY.
415
416         This new driver will be activated only if the environment variable
417         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
418         tests and performance tests.
419
420         This patch also makes the script run-perf-tests to check the
421         system dependencies before starting the tests. Previously this
422         was not checked, and if the system dependencies were not met,
423         the script tried to execute the tests anyway, causing massive
424         failures. For example, if you had Xvfb not installed and you
425         wanted to use the Xvfb driver (the default on GTK and EFL),
426         run-perf-tests would not abort.
427
428         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
429         (PerfTestsRunner._parse_args): Check the system dependencies of
430         the driver before starting the tests.
431         * Scripts/webkitpy/port/driver.py:
432         (Driver): Implement generic check_driver method.
433         (Driver.check_driver):
434         (Driver.check_driver.implementation):
435         * Scripts/webkitpy/port/gtk.py:
436         (GtkPort._driver_class): Check for environment variable
437         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
438         * Scripts/webkitpy/port/xorgdriver.py: Added.
439         (XorgDriver): Implement Xorg driver.
440         (XorgDriver.check_driver):
441         (XorgDriver._start):
442
443 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
444
445         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
446         https://bugs.webkit.org/show_bug.cgi?id=133215
447
448         Reviewed by Csaba Osztrogonác.
449
450         This reverts r166798.
451
452         * BuildSlaveSupport/kill-old-processes:
453         (main):
454
455 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
456
457         [EFL] Turn on ENABLE_CSS_FILTERS in build script
458         https://bugs.webkit.org/show_bug.cgi?id=133278
459
460         Reviewed by Gyuyoung Kim.
461
462         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
463
464 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
465
466         run-javascriptcore-tests warning fix on non Mac platforms
467         https://bugs.webkit.org/show_bug.cgi?id=133260
468
469         Reviewed by Darin Adler.
470
471         * Scripts/webkitdirs.pm:
472         (argumentsForConfiguration):
473
474 2014-05-23  Michael Saboff  <msaboff@apple.com>
475
476         REGRESSION(r169265): sh: line 0: cd: ../.vm
477         https://bugs.webkit.org/show_bug.cgi?id=133242
478
479         Rubber stamped by Geoffrey Garen.
480
481         Added missing shell escapes '\' required as part of previous fix.
482
483         * Scripts/run-jsc-stress-tests:
484
485 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
486
487         Revert the erroneous change committed in r169286.
488
489         * Scripts/webkitpy/performance_tests/perftest.py:
490         (PerfTest._run_with_driver):
491
492 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
493
494         run-perf-tests should ignore whitespace lines when snarfing test output
495         https://bugs.webkit.org/show_bug.cgi?id=133238
496
497         Reviewed by Ryosuke Niwa.
498
499         Required for PerformanceTests/Canvas/terrain.html.
500
501         * Scripts/webkitpy/performance_tests/perftest.py:
502         (PerfTest._run_with_driver):
503         (PerfTest):
504
505 2014-05-23  Michael Saboff  <msaboff@apple.com>
506
507         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
508         https://bugs.webkit.org/show_bug.cgi?id=133223
509
510         Reviewed by Geoffrey Garen.
511
512         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
513         string before calling IO.popen() to work with older versions of ruby.
514         Changed the remote path in runShellTestRunner to quote the command
515         string we want to run via ssh so that it will work correctly with array
516         to string conversion needed for popen.
517
518         * Scripts/run-jsc-stress-tests:
519
520 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
521
522         Remove 'css-shaders' option from the build-webkit
523         https://bugs.webkit.org/show_bug.cgi?id=133212
524
525         Reviewed by Daniel Bates.
526
527         Original CSS shaders removed in r162644.
528
529         * Scripts/webkitperl/FeatureList.pm:
530
531 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
532
533         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
534         https://bugs.webkit.org/show_bug.cgi?id=133209
535
536         Reviewed by Sergio Villar Senin.
537
538         Return FAILURE when the command failed to run.
539
540         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
541         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
542
543 2014-05-23  Alberto Garcia  <berto@igalia.com>
544
545         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
546         https://bugs.webkit.org/show_bug.cgi?id=133210
547
548         Reviewed by Carlos Garcia Campos.
549
550         * gtk/install-dependencies:
551
552 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
553
554         Add Yusuke Suzuki to the list of contributors (for real)
555
556         Wrong section...
557
558         * Scripts/webkitpy/common/config/contributors.json:
559
560 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
561
562         Add Yusuke Suzuki to the list of contributors
563
564         * Scripts/webkitpy/common/config/contributors.json:
565
566 2014-05-22  Michael Saboff  <msaboff@apple.com>
567
568         Eliminate n/total progress update from run-jsc-stress-tests output to file
569         https://bugs.webkit.org/show_bug.cgi?id=133191
570
571         Reviewed by Geoffrey Garen.
572
573         Changed progressMeter setting to be based on stdout being a tty instead of
574         stdin.  Unified the processing of output from the shell runner to match the
575         same processing as is used by the makefile runner.  As part of this, the 
576         shell runner script was simplified.  It now forwards the output of each
577         test_script just like the Makefile and doesn't provide its own progress.
578
579         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
580         * Scripts/run-jsc-stress-tests:
581
582 2014-05-22  Michael Saboff  <msaboff@apple.com>
583
584         Add option to run-jsc-stress-tests to use installed jsc
585         https://bugs.webkit.org/show_bug.cgi?id=133102
586
587         Reviewed by Geoffrey Garen.
588
589         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
590         provied with the --jsc option.
591
592         * Scripts/run-jsc-stress-tests:
593
594 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
595
596         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
597         https://bugs.webkit.org/show_bug.cgi?id=132907
598
599         Reviewed by Gyuyoung Kim.
600
601         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
602         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
603
604         * efl/install-dependencies:
605
606 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
607
608         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
609         https://bugs.webkit.org/show_bug.cgi?id=133145
610
611         Reviewed by Csaba Osztrogonác.
612
613         * Scripts/run-jsc-stress-tests:
614
615 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
616
617         [Mac] WebProcess doesn't follow localization of UI process when run as a service
618         https://bugs.webkit.org/show_bug.cgi?id=133126
619         <rdar://problem/13396515>
620         <rdar://problem/16561084>
621
622         Reviewed by Sam Weinig and Tim Horton.
623
624         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
625         (WTR::InjectedBundle::platformInitialize): It was too late to override language
626         here, and it's not necessary any more. Keeping the code for older OS versions in
627         case it did have effect in some code paths.
628
629 2014-05-19  David Farler  <dfarler@apple.com>
630
631         Move WebKitTestRunner to std::unique_ptr
632         https://bugs.webkit.org/show_bug.cgi?id=133081
633
634         Reviewed by Daniel Bates.
635
636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
637         (WTR::InjectedBundle::didCreatePage):
638         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
639         * WebKitTestRunner/TestController.cpp:
640         (WTR::TestController::initialize):
641         (WTR::TestController::createWebViewWithOptions):
642         (WTR::TestController::resetStateToConsistentValues):
643         (WTR::TestController::runTest):
644         * WebKitTestRunner/TestController.h:
645         * WebKitTestRunner/TestInvocation.cpp:
646         * WebKitTestRunner/TestInvocation.h:
647         * WebKitTestRunner/WorkQueueManager.cpp:
648         (WTR::WorkQueueManager::processWorkQueue):
649         (WTR::WorkQueueManager::enqueue):
650         * WebKitTestRunner/WorkQueueManager.h:
651
652 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
655         https://bugs.webkit.org/show_bug.cgi?id=133119
656
657         Reviewed by Sergio Villar Senin.
658
659         Check that redirect response parameter of
660         WebKitWebPage::send-request signal is NULL when not redirecting
661         and a valid WebKitURIResponse object when redirecting.
662
663         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
664         (testWebResourceSendRequest):
665         (serverCallback):
666         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
667         (sendRequestCallback):
668
669 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
670
671         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
672         https://bugs.webkit.org/show_bug.cgi?id=133117
673
674         Reviewed by Philippe Normand.
675
676         Bring back missing tests to the build.
677
678         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
679
680 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
681
682         Take care of some ARM64 test failures
683         https://bugs.webkit.org/show_bug.cgi?id=133090
684
685         Reviewed by Geoffrey Garen.
686
687         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
688
689 2014-05-19  David Kilzer  <ddkilzer@apple.com>
690
691         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
692         <http://webkit.org/b/133089>
693
694         Reviewed by Darin Adler.
695
696         * Scripts/webkitdirs.pm:
697         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
698         specified on the command line, we would remove the '--sdk'
699         arguments, but leave '--sim', potentially passing it along to
700         xcodebuild causing a build failure.  This happens when
701         'old-run-webkit-tests --release --sim' invokes
702         build-dumprendertree when DumpRenderTree hasn't been built yet.
703
704 2014-05-19  David Farler  <dfarler@apple.com>
705
706         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
707         https://bugs.webkit.org/show_bug.cgi?id=133086
708
709         Reviewed by Daniel Bates.
710
711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
712
713 2014-05-19  David Kilzer  <ddkilzer@apple.com>
714
715         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
716         <http://webkit.org/b/132954>
717
718         * Scripts/webkitdirs.pm:
719         (sharedCommandLineOptionsUsage): Remove the prototype for the
720         subroutine.  Older perls don't like the "+@" syntax.
721
722 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
723
724         run-javascriptcore-tests should sort the list of failing stress tests
725         https://bugs.webkit.org/show_bug.cgi?id=132989
726
727         Reviewed by Csaba Osztrogonác.
728
729         * Scripts/run-javascriptcore-tests:
730
731 2014-05-19  David Kilzer  <ddkilzer@apple.com>
732
733         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
734         <http://webkit.org/b/132954>
735
736         Reviewed by Darin Adler.
737
738         Extract code into setupMacWebKitEnvironment() for setting up
739         common environment variables so it may be shared.  Sets
740         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
741         using guardmalloc to some scripts.
742
743         Also adds support for parsing shared (common) command-line
744         switches, initially just -g|--guard-malloc.
745
746         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
747         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
748         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
749         local copy of %ENV when launching Safari so we don't have to
750         restore variables.
751
752         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
753         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
754         Check result of GetOptions() to catch invalid command-line
755         switches.
756         (runTest): Use a local copy of %ENV when running tests so we
757         don't have to restore variables.
758         (prepareEnvironmentForRunningTestTool): Call
759         setupMacWebKitEnvironment().
760
761         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
762         using sharedCommandLineOptions() and
763         sharedCommandLineOptionsUsage().  Call
764         setupMacWebKitEnvironment().
765
766         * Scripts/webkitdirs.pm:
767         (sharedCommandLineOptions): Return array of common switches to
768         pass to Getopt::Long::GetOptions().
769         (sharedCommandLineOptionsUsage): Return formatted string of
770         common switches for printing usage help text.
771         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
772         guardmalloc.
773         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
774         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
775         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
776         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
777         local copy of %ENV when launching Safari so we don't have to
778         restore variables.
779         (execMacWebKitAppForDebugging): Call
780         setupMacWebKitEnvironment().
781
782 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
783
784         support for navigator.hardwareConcurrency
785         https://bugs.webkit.org/show_bug.cgi?id=132588
786
787         Reviewed by Filip Pizlo.
788
789         * Scripts/webkitperl/FeatureList.pm:
790
791 2014-05-18  Anders Carlsson  <andersca@apple.com>
792
793         Implement Navigations for all methods declared returning one
794         https://bugs.webkit.org/show_bug.cgi?id=133048
795         <rdar://problem/16830064>
796
797         Reviewed by Sam Weinig.
798
799         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
800         Import WebKit.h.
801         
802         * MiniBrowser/mac/WK2BrowserWindowController.m:
803         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
804         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
805         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
806         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
807         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
808         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
809         Print out the navigations.
810
811 2014-05-17  Zalan Bujtas  <zalan@apple.com>
812
813         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
814         https://bugs.webkit.org/show_bug.cgi?id=133029
815
816         Reviewed by Simon Fraser.
817
818         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
819         toggling it on a WK2 window needs restart.
820         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
821         the WebPreferences just to support this temporary toggle.
822
823         * MiniBrowser/mac/BrowserWindowController.h:
824         * MiniBrowser/mac/MainMenu.xib:
825         * MiniBrowser/mac/WK1BrowserWindowController.m:
826         (-[WK1BrowserWindowController validateMenuItem:]):
827         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
828         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
829         * MiniBrowser/mac/WK2BrowserWindowController.m:
830         (-[WK2BrowserWindowController validateMenuItem:]):
831         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
832         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
833
834 2014-05-17  Anders Carlsson  <andersca@apple.com>
835
836         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
837         https://bugs.webkit.org/show_bug.cgi?id=133033
838         <rdar://problem/16830143>
839
840         Reviewed by Sam Weinig.
841
842         Set up the WebSQL and IndexedDB directories.
843
844         * WebKitTestRunner/TestController.cpp:
845         (WTR::TestController::initialize):
846
847 2014-05-16  Martin Hock  <mhock@apple.com>
848
849         MemoryCache::addImageToCache should return the result of add().
850         https://bugs.webkit.org/show_bug.cgi?id=132928
851         <rdar://problem/16651547>
852
853         Reviewed by Alexey Proskuryakov.
854
855         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
857         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
858         (TestWebKitAPI::TEST):
859
860 2014-05-15  David Farler  <dfarler@apple.com>
861
862         old-run-webkit-tests: allow specifying a simulator app path
863         https://bugs.webkit.org/show_bug.cgi?id=132975
864
865         Reviewed by Anders Carlsson.
866
867         * Scripts/old-run-webkit-tests:
868         (openIPhoneSimulator):
869         Add new --simulator-app command line parameter for specifying the
870         absolute path to the simulator app to launch before starting a
871         session.
872
873 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
874
875         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
876         https://bugs.webkit.org/show_bug.cgi?id=131363
877
878         Reviewed by Csaba Osztrogonác.
879
880         * Scripts/webkitpy/common/checkout/checkout_mock.py:
881         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
882         (MockBugzilla):
883         * Scripts/webkitpy/tool/commands/download_unittest.py:
884         (test_create_rollout_multiple_revision_with_one_resolved):
885         (test_create_rollout_multiple_resolved):
886         (test_rollout_two_revisions):
887         (test_rollout_multiple_revisions):
888         (test_rollout_multiple_revisions_with_a_missing_bug_id):
889         * Scripts/webkitpy/tool/steps/createbug.py:
890         (CreateBug.run):
891         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
892         (ReopenBugAfterRollout.run):
893
894 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
895
896         [WK2] Change the remaining framework includes from WebKit2 to WebKit
897         https://bugs.webkit.org/show_bug.cgi?id=132956
898
899         Reviewed by Sam Weinig.
900
901         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
902         * MiniBrowser/mac/AppDelegate.m:
903         * MiniBrowser/mac/WK2BrowserWindowController.m:
904         * TestWebKitAPI/InjectedBundleController.h:
905         * TestWebKitAPI/InjectedBundleMain.cpp:
906         * TestWebKitAPI/JavaScriptTest.cpp:
907         * TestWebKitAPI/PlatformUtilities.h:
908         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
909         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
910         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
911         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
912         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
913         (TestWebKitAPI::TEST):
914         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
915         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
916         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
917         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
918         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
919         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
920         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
921         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
922         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
923         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
924         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
925         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
926         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
927         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
928         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
929         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
930         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
931         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
932         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
933         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
934         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
935         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
936         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
937         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
938         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
939         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
940         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
941         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
942         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
943         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
944         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
945         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
946         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
947         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
948         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
949         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
950         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
951         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
952         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
953         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
954         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
955         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
956         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
957         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
958         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
959         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
960         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
961         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
962         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
963         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
964         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
965         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
966         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
967         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
968         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
969         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
970         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
971         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
972         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
973         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
974         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
975         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
976         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
977         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
978         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
979         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
980         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
981         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
982         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
983         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
984         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
985         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
986         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
987         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
988         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
989         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
990         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
991         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
992         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
993         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
994         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
995         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
996         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
997         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
998         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
999         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1000         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1001         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1002         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1003         * TestWebKitAPI/config.h:
1004         * TestWebKitAPI/efl/PlatformWebView.cpp:
1005         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1006         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1007         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1008         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1009         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1010         * WebKitTestRunner/EventSenderProxy.h:
1011         * WebKitTestRunner/GeolocationProviderMock.cpp:
1012         * WebKitTestRunner/GeolocationProviderMock.h:
1013         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1014         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1015         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1016         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1017         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1018         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1019         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1022         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1023         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1024         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1025         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1026         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1027         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1028         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1029         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1030         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1032         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1033         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1034         * WebKitTestRunner/PlatformWebView.h:
1035         * WebKitTestRunner/StringFunctions.h:
1036         * WebKitTestRunner/TestController.cpp:
1037         * WebKitTestRunner/TestController.h:
1038         * WebKitTestRunner/TestInvocation.cpp:
1039         * WebKitTestRunner/TestInvocation.h:
1040         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1041         * WebKitTestRunner/WebNotificationProvider.cpp:
1042         * WebKitTestRunner/WebNotificationProvider.h:
1043         * WebKitTestRunner/WorkQueueManager.cpp:
1044         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1045         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1046         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1047         * WebKitTestRunner/config.h:
1048         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1049         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1050         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1051         * WebKitTestRunner/ios/TestControllerIOS.mm:
1052         * WebKitTestRunner/mac/EventSenderProxy.mm:
1053         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1054         * WebKitTestRunner/mac/TestControllerMac.mm:
1055
1056 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1057
1058         [EFL][WK2] Skip failing unit tests
1059         https://bugs.webkit.org/show_bug.cgi?id=132979
1060
1061         Reviewed by Daniel Bates.
1062
1063         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1064
1065 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1066
1067         [iOS] Support TestWebKitAPI in the iOS Simulator
1068         <http://webkit.org/b/129535>
1069         <rdar://problem/16203529>
1070
1071         Reviewed by Daniel Bates.
1072
1073         * Scripts/run-api-tests:
1074         (runTest):
1075         (listAllTests):
1076         - Extract common arguments into local variable.
1077         - Use xcrun to find the sim tool in order to invoke
1078         TestWebKitAPI properly in the iOS Simulator. 
1079
1080         * Scripts/webkitdirs.pm:
1081         (argumentsForConfiguration): Set --device or --sim as
1082         appropriate to fix buildTestTool() in run-api-tests.
1083
1084 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1085
1086         Fix a logging typo in copy-webkitlibraries-to-product-directory
1087
1088         Reviewed by Dean Jackson.
1089
1090         * Scripts/copy-webkitlibraries-to-product-directory:
1091
1092 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1093
1094         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1095         <http://webkit.org/b/132959>
1096
1097         Reviewed by Dan Bernstein.
1098
1099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1100         Cocoa directory to project and move URLExtras.mm into it.
1101         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1102
1103 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1104
1105         [GTK] Compile all installed resources as GResources
1106         https://bugs.webkit.org/show_bug.cgi?id=131099
1107
1108         Reviewed by Philippe Normand.
1109
1110         * Scripts/webkitpy/port/gtk.py:
1111         (GtkPort.setup_environ_for_server): Removed now unneeded
1112         AUDIO_RESOURCES_PATH env var.
1113
1114 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1115
1116         Remove CSS_STICKY_POSITION guards
1117         https://bugs.webkit.org/show_bug.cgi?id=132676
1118
1119         Reviewed by Simon Fraser.
1120
1121         * Scripts/webkitperl/FeatureList.pm:
1122
1123 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1126         https://bugs.webkit.org/show_bug.cgi?id=132686
1127
1128         Reviewed by Philippe Normand.
1129
1130         Bring back InputMethodFilter test to the build and compile it into
1131         a single binary TestWebCore with the other WebCore tests. Also
1132         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1133
1134         * Scripts/run-gtk-tests:
1135         (TestRunner): Remove WebCoreGtk from the list of test directories.
1136         * TestWebKitAPI/PlatformGTK.cmake:
1137         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1138
1139 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1140
1141         [EFL] Make XVFBDriver optional
1142         https://bugs.webkit.org/show_bug.cgi?id=131036
1143
1144         Reviewed by Gyuyoung Kim.
1145
1146         * Scripts/webkitpy/port/efl.py:
1147         (EflPort._driver_class):
1148
1149 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1150
1151         Flakiness dashboard contains outdated list of bots on builders.jsonp
1152         https://bugs.webkit.org/show_bug.cgi?id=132874
1153
1154         Reviewed by Darin Adler.
1155
1156         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1157         file by changing to the directory Tools/TestResultServer and executing
1158         the script generate_builders_json.py
1159
1160 2014-05-11  Anders Carlsson  <andersca@apple.com>
1161
1162         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1163         https://bugs.webkit.org/show_bug.cgi?id=132809
1164
1165         Reviewed by Dan Bernstein.
1166
1167         * WebKitTestRunner/TestController.cpp:
1168         (WTR::TestController::initialize):
1169         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1170
1171 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1172
1173         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1174         https://bugs.webkit.org/show_bug.cgi?id=132739
1175
1176         Reviewed Anders Carlsson.
1177
1178         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1179         the JSC unit tests.
1180         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1181
1182 2014-05-11  Anders Carlsson  <andersca@apple.com>
1183
1184         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1185         https://bugs.webkit.org/show_bug.cgi?id=132806
1186
1187         Reviewed by Beth Dakin.
1188
1189         Migrate to WKContextConfiguration.
1190
1191         * WebKitTestRunner/TestController.cpp:
1192         (WTR::TestController::initialize):
1193
1194 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1195
1196         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1197         https://bugs.webkit.org/show_bug.cgi?id=132685
1198
1199         Reviewed by Martin Robinson.
1200
1201         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1202
1203         * TestWebKitAPI/PlatformGTK.cmake:
1204
1205 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1206
1207         [iOS] Switch geolocation to an explicit authorization query model
1208         https://bugs.webkit.org/show_bug.cgi?id=132717
1209
1210         Reviewed by Sam Weinig.
1211
1212         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1213         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1214         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1215
1216 2014-05-09  David Farler  <dfarler@apple.com>
1217
1218         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1219         https://bugs.webkit.org/show_bug.cgi?id=132718
1220
1221         Reviewed by David Kilzer.
1222
1223         The simulator may not be able to look up runtimes by SDK paths
1224         and instead will map SDK versions to runtimes instead. In
1225         com.apple.iphonesimulator.startSession notifications,
1226         'runtimeIdentifier' (SDK version string) is preferred over
1227         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1228         when creating a new DRT or WKTR simulator session.
1229
1230         IPhoneSimulatorNotification.pm filters out keys for this
1231         notification's userInfo with a hard-coded list. There's no harm
1232         in including extra key-value pairs in an NSNotification userInfo
1233         dictionary anyway and the simulator may again change its
1234         userInfo schema for this notification.
1235
1236         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1237         (postStartSessionNotification):
1238         * Scripts/old-run-webkit-tests:
1239         (installAndLaunchDumpToolAppUsingNotification):
1240
1241 2014-05-09  Anders Carlsson  <andersca@apple.com>
1242
1243         Another build fix.
1244
1245         * Scripts/build-webkit:
1246         WebKit2 should always be built for OS X and iOS.
1247
1248 2014-05-09  Anders Carlsson  <andersca@apple.com>
1249
1250         Follow-up build fix.
1251
1252         * Scripts/build-webkit:
1253         WebKit2 should no longer be built before WebKit.
1254
1255 2014-05-09  Anders Carlsson  <andersca@apple.com>
1256
1257         Rename WebKit2.framework to WebKit.framework
1258         https://bugs.webkit.org/show_bug.cgi?id=132743
1259         <rdar://problem/15920046>
1260
1261         Reviewed by Dan Bernstein.
1262
1263         * Scripts/check-for-inappropriate-files-in-framework:
1264         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1265         Change WebKit2 to WebKit.
1266
1267         * Scripts/check-for-webkit-framework-include-consistency:
1268         Change WebKit to WebKitLegacy.
1269
1270 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1271
1272         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1273         https://bugs.webkit.org/show_bug.cgi?id=132732
1274
1275         Reviewed by Alexey Proskuryakov.
1276
1277         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1278
1279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1280         (EWS): Remove GTK+ WK1 EWS.
1281
1282 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1283
1284         Add new u-szeged contributors.
1285
1286         Reviewed by Csaba Osztrogonác.
1287
1288         * Scripts/webkitpy/common/config/contributors.json:
1289
1290 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1291
1292         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1293         https://bugs.webkit.org/show_bug.cgi?id=132736
1294
1295         Reviewed by Philippe Normand.
1296
1297         There are two problems, the path returned by common.library_build_path() is wrong when
1298         common.binary_build_path() has previously been called, and the test is still looking for
1299         the .la instead of .so
1300
1301         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1302         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1303         of .la as extension of the injected bundle library.
1304         * gtk/common.py:
1305         (binary_build_path): Remove unused global variable and add a new
1306         one for binary_build_dir instead of sharing the same global
1307         variable for library_build_path and binary_build_path.
1308
1309 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1310
1311         [EFL] Enable MEDIA_STREAM for EFL port
1312         https://bugs.webkit.org/show_bug.cgi?id=132648
1313
1314         Reviewed by Gyuyoung Kim.
1315
1316         Script modified to enable MEDIA_STREAM for EFL build.
1317
1318         * Scripts/webkitperl/FeatureList.pm: 
1319
1320 2014-05-08  David Farler  <dfarler@apple.com>
1321
1322         old-run-webkit-tests: update strings for simulator devices and app name
1323         https://bugs.webkit.org/show_bug.cgi?id=132687
1324
1325         Reviewed by Darin Adler.
1326
1327         iPhone Retina (4-inch) -> iPhone 5
1328         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1329
1330         * Scripts/old-run-webkit-tests:
1331         (installAndLaunchDumpToolAppUsingNotification):
1332         (openIPhoneSimulator):
1333         (quitIPhoneSimulator):
1334         quit iOS Simulator, not iPhone Simulator.
1335
1336 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1337
1338         REGRESSION(r168471): Update the builder names on the scheduler list.
1339         https://bugs.webkit.org/show_bug.cgi?id=132699
1340
1341         Reviewed by Martin Robinson.
1342
1343         On r168471 I missed to update the builder names for the GTK build
1344         bots on the AnyBranchScheduler type scheduler list of bots.
1345
1346         * BuildSlaveSupport/build.webkit.org-config/config.json:
1347
1348 2014-05-08  Brady Eidson  <beidson@apple.com>
1349
1350         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1351         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1352
1353         Reviewed by Tim Horton.
1354
1355         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1356         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1357
1358 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1359
1360         REGRESSION(r168471): Duplicate builddirs broke the build master.
1361         https://bugs.webkit.org/show_bug.cgi?id=132688
1362
1363         Reviewed by Carlos Garcia Campos.
1364
1365         Rename the builddirs of the new GTK bots introduced on r168471 to
1366         be unique. Otherwise the master will break.
1367
1368         * BuildSlaveSupport/build.webkit.org-config/config.json:
1369
1370 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1371
1372         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1373         https://bugs.webkit.org/show_bug.cgi?id=132674
1374
1375         Reviewed by Philippe Normand.
1376
1377         Only ignore mkdir failure when exception is raised because the
1378         file already exists and it's a directory.
1379
1380         * gtk/webkitdom.py:
1381         (write_doc_files):
1382
1383 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1384
1385         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1386         https://bugs.webkit.org/show_bug.cgi?id=131358
1387
1388         Reviewed by Carlos Garcia Campos.
1389
1390         Current 64-bit GTK build bots (Release and Debug) not only test
1391         the build, but run all tests. Split each one of the bots in
1392         BuildOnly and TestWebKit2.
1393
1394         This will allow us to have a better overview of the status of
1395         the GTK port.
1396
1397         Original patch from Sergio Villar Senin <svillar@igalia.com>
1398
1399         * BuildSlaveSupport/build.webkit.org-config/config.json:
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1402         (WebKitBuildbot):
1403         * Scripts/webkitpy/port/builders.py:
1404         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1405         (TestRebaselineTest.test_baseline_directory):
1406         * TestResultServer/static-dashboards/builders.jsonp:
1407         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1408         (resetGlobals):
1409         * TestResultServer/static-dashboards/loader_unittests.js:
1410
1411 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1412
1413         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1414         https://bugs.webkit.org/show_bug.cgi?id=126022
1415
1416         Reviewed by Benjamin Poulain.
1417
1418         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1419
1420         Added an unit test case to check if scroll position and scale are restored properly.
1421
1422         * TestWebKitAPI/PlatformEfl.cmake:
1423         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1424         (TestWebKitAPI::didFinishLoadForFrame):
1425         (TestWebKitAPI::didChangeContentsPosition):
1426         (TestWebKitAPI::TEST):
1427         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1428         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1429
1430 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1431
1432         WebKit1 is flashy when compositing layers come and go
1433         https://bugs.webkit.org/show_bug.cgi?id=132655
1434         <rdar://problem/16830981&16788846>
1435
1436         Reviewed by Sam Weinig.
1437         
1438         Revert the change from r166117.
1439
1440         * DumpRenderTree/mac/DumpRenderTree.mm:
1441         (updateDisplay):
1442
1443 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1444
1445         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1446         https://bugs.webkit.org/show_bug.cgi?id=132622
1447
1448         Reviewed by Mario Sanchez Prada.
1449
1450         * DumpRenderTree/AccessibilityUIElement.cpp:
1451         (selectTextWithCriteriaCallback):
1452         (isEqualCallback):
1453         * DumpRenderTree/AccessibilityUIElement.h:
1454         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1455         (AccessibilityUIElement::selectTextWithCriteria):
1456         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1457         (AccessibilityUIElement::selectTextWithCriteria):
1458         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1459         (selectTextParameterizedAttributeForCriteria):
1460         (AccessibilityUIElement::selectTextWithCriteria):
1461         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1462         (AccessibilityUIElement::selectTextWithCriteria):
1463         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1464         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1465         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1466         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1467         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1468         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1469         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1470         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1471         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1472         (WTR::selectTextParameterizedAttributeForCriteria):
1473         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1474
1475 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1476
1477         [SOUP] TLSErrors do not cause page load to fail when not ignored
1478         https://bugs.webkit.org/show_bug.cgi?id=121548
1479
1480         Reviewed by Sergio Villar Senin.
1481
1482         Add unit tests to check that the load fails with TLS errors in
1483         case of a redirection.
1484
1485         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1486         (testTLSErrorsRedirect):
1487         (httpsServerCallback):
1488         (beforeAll):
1489
1490 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1491
1492         [CSS Grid Layout] Remove runtime feature
1493         https://bugs.webkit.org/show_bug.cgi?id=132382
1494
1495         Reviewed by Benjamin Poulain.
1496
1497         Remove cssGridLayoutEnabled setting usage.
1498
1499         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1500         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1501         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1502         (TestRunner::overridePreference):
1503         * DumpRenderTree/mac/DumpRenderTree.mm:
1504         (resetWebPreferencesToConsistentValues):
1505
1506 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1507
1508         Add Makefile targets for copying static libraries (LLVM and WKSI)
1509         <http://webkit.org/b/132619>
1510
1511         Reviewed by Mark Rowe.
1512
1513         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1514         sensible default for product directory if not specified on
1515         either the command-line or in the environment (by Xcode) by
1516         calling productDir() in webkitdirs.pm.
1517
1518 2014-05-06  Brady Eidson  <beidson@apple.com>
1519
1520         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1521         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1522
1523         Reviewed by Sam Weinig.
1524
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1526
1527         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1528         (TestWebKitAPI::itemURLLastComponentIsString):
1529         (TestWebKitAPI::didFinishLoadForFrame):
1530         (TestWebKitAPI::willGoToBackForwardListItem):
1531         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1532         (TestWebKitAPI::setPageLoaderClient):
1533         (TestWebKitAPI::TEST):
1534         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1535         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1536
1537         * WebKitTestRunner/TestController.cpp:
1538         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1539
1540 2014-05-06  Darin Adler  <darin@apple.com>
1541
1542         Try to fix iOS build.
1543
1544         * DumpRenderTree/mac/TestRunnerMac.mm:
1545         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1546         Updated since I changed testRunner into a pointer instead of a reference.
1547         Updated argument names to avoid conflict with field names.
1548         (-[APITestDelegateIPhone run]): Ditto.
1549         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1550
1551 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1552
1553         Unreviewed, rolling out r168304.
1554         https://bugs.webkit.org/show_bug.cgi?id=132607
1555
1556         Broke the build (Requested by KaL on #webkit).
1557
1558         Reverted changeset:
1559
1560         "[GTK][CMake] Unable to do make install"
1561         https://bugs.webkit.org/show_bug.cgi?id=130188
1562         http://trac.webkit.org/changeset/168304
1563
1564 2014-05-04  Darin Adler  <darin@apple.com>
1565
1566         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1567         https://bugs.webkit.org/show_bug.cgi?id=80222
1568
1569         Reviewed by Alexey Proskuryakov.
1570
1571         * DumpRenderTree/mac/TestRunnerMac.mm:
1572         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1573         do more work here so we don't use RetainPtr local variables.
1574         (-[APITestDelegateIPhone dealloc]): Added.
1575         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1576         created. Updated for changes to member names and types.
1577         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1578         updated for changes to member names and types. Changed to two word spelling.
1579         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1580         name of _cleanUp method.
1581         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1582         Ditto.
1583         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1584
1585 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1586
1587         Clean up Image Document and tweak the layout and viewport
1588         https://bugs.webkit.org/show_bug.cgi?id=132552
1589
1590         Reviewed by Anders Carlsson.
1591
1592         * DumpRenderTree/mac/DumpRenderTree.mm:
1593         (resetWebPreferencesToConsistentValues):
1594         Update the default settings to have something consistent with WebKit2.
1595
1596 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1597
1598         [GTK][CMake] Unable to do make install
1599         https://bugs.webkit.org/show_bug.cgi?id=130188
1600
1601         Reviewed by Carlos Garcia Campos.
1602
1603         * Scripts/webkitdirs.pm:
1604         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1605         will give an early signal that a change has broken the documentation.
1606
1607 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1608
1609         Update framework locations in package-root
1610         https://bugs.webkit.org/show_bug.cgi?id=132571
1611
1612         Reviewed by Simon Fraser.
1613
1614         * Scripts/package-root:
1615
1616 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1617
1618         [EFL][WK2] Refactor favicon database APIs
1619         https://bugs.webkit.org/show_bug.cgi?id=132519
1620
1621         Reviewed by Gyuyoung Kim.
1622
1623         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1624         (update_view_favicon):
1625         (on_icon_changed_cb):
1626         (window_free):
1627         (on_url_changed):
1628         (window_create):
1629         (on_view_favicon_changed): Deleted.
1630
1631 2014-05-02  Mark Rowe  <mrowe@apple.com>
1632
1633         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1634
1635         Reviewed by Dan Bernstein.
1636
1637         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1638         when determining which LLVM archive to extract.
1639
1640 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1641
1642         Add Jeremy as a committer.
1643         https://bugs.webkit.org/show_bug.cgi?id=132492
1644
1645         Reviewed by Jer Noble.
1646
1647         Add myself as a committer.
1648
1649         * Scripts/webkitpy/common/config/contributors.json:
1650
1651 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1652
1653         Add Jeremy as a committer.
1654         https://bugs.webkit.org/show_bug.cgi?id=132492
1655
1656         Reviewed by Jer Noble.
1657
1658         Add Jeremy Jones to the committers file.
1659
1660         * Scripts/webkitpy/common/config/contributors.json:
1661
1662 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1663
1664         Hard to figure out how to run a single test with run-api-tests
1665         https://bugs.webkit.org/show_bug.cgi?id=116332
1666
1667         Reviewed by Alexey Proskuryakov.
1668
1669         * Scripts/run-api-tests: add two examples to the help message.
1670
1671 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1672
1673         Fix several memory leaks found by code inspection
1674         https://bugs.webkit.org/show_bug.cgi?id=132472
1675
1676         Reviewed by Geoffrey Garen.
1677         
1678         Fix memory leaks.
1679
1680         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1681         (TestWebKitAPI::TEST):
1682         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1683         (WTR::InjectedBundlePage::willSendRequestForFrame):
1684         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1685         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1686
1687 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1688
1689         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1690         https://bugs.webkit.org/show_bug.cgi?id=132446
1691
1692         Reviewed by Mark Hahnenberg.
1693         
1694         Test the FTL by default now that it's enabled by default.
1695
1696         * Scripts/run-javascriptcore-tests:
1697
1698 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1699
1700         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1701         https://bugs.webkit.org/show_bug.cgi?id=132240
1702
1703         Reviewed by Anders Carlsson.
1704
1705         Removed ewk_view_setting_tiled_backingstore related code.
1706
1707         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1708         (DumpRenderTreeChrome::createView):
1709         (shouldUseTiledBackingStore): Deleted.
1710         * EWebLauncher/main.c:
1711         (windowCreate):
1712         (parseUserArguments):
1713
1714 2014-05-01  Anders Carlsson  <andersca@apple.com>
1715
1716         window.testRunner.keepWebHistory() should update the UI process state
1717         https://bugs.webkit.org/show_bug.cgi?id=132440
1718
1719         Reviewed by Dan Bernstein.
1720
1721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1722         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1723         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1725         (WTR::TestRunner::keepWebHistory):
1726         * WebKitTestRunner/TestInvocation.cpp:
1727         (WTR::TestInvocation::invoke):
1728         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1729
1730 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1731
1732         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1733         <http://webkit.org/b/132432>
1734
1735         Reviewed by Tim Horton.
1736
1737         * Scripts/webkitperl/FeatureList.pm: Remove support for
1738         --plugin-proxy-for-video switch.
1739
1740 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1741
1742         Kernel sysctl interface hw.activecpu don't exists on Linux.
1743         https://bugs.webkit.org/show_bug.cgi?id=132286
1744
1745         Reviewed by Filip Pizlo.
1746
1747         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1748         calling sysctl over hw.activecpu
1749
1750 2014-04-30  Anders Carlsson  <andersca@apple.com>
1751
1752         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1753         https://bugs.webkit.org/show_bug.cgi?id=132399
1754         <rdar://problem/15920046>
1755
1756         Reviewed by Dan Bernstein.
1757
1758         * Scripts/check-for-webkit-framework-include-consistency:
1759         Allos WAK headers in WebKitLegacy as well as WebKit.
1760
1761         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1762         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1763         Update header imports.
1764
1765 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1766
1767         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1768         https://bugs.webkit.org/show_bug.cgi?id=131954
1769
1770         Reviewed by Darin Adler.
1771         
1772         WebKitTestRunner was adding application-specific information to crash reports
1773         to log the test path, but only in the web process. Fix it to also do this
1774         for the UI process, for both iOS and OS X.
1775         
1776         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1777         both iOS and OS X.
1778         
1779         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1780         a new TestController::platformWillRunTest() function on Mac and iOS.
1781         
1782         Also remove Xcode-added unit test junk from the project.
1783
1784         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1785         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1786         * WebKitTestRunner/TestController.cpp:
1787         (WTR::TestController::runTest):
1788         * WebKitTestRunner/TestController.h:
1789         * WebKitTestRunner/TestInvocation.cpp:
1790         (WTR::TestInvocation::url):
1791         * WebKitTestRunner/TestInvocation.h:
1792         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1793         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1794         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1795         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1796         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1797         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1798         (WTR::testPathFromURL):
1799         (WTR::setCrashReportApplicationSpecificInformationToURL):
1800         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1801         (WTR::TestController::platformWillRunTest):
1802         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1803         (WTR::TestController::platformWillRunTest):
1804         * WebKitTestRunner/ios/TestControllerIOS.mm:
1805         (WTR::TestController::platformWillRunTest):
1806         (WTR::TestController::setHidden):
1807         * WebKitTestRunner/mac/TestControllerMac.mm:
1808         (WTR::TestController::platformWillRunTest):
1809
1810 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1811
1812         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1813
1814         Reviewed by Tim Horton.
1815
1816         * DumpRenderTree/mac/DumpRenderTree.mm:
1817         (resetWebPreferencesToConsistentValues):
1818         (prepareConsistentTestingEnvironment):
1819
1820 2014-04-30  Anders Carlsson  <andersca@apple.com>
1821
1822         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1823         https://bugs.webkit.org/show_bug.cgi?id=132397
1824
1825         Reviewed by Dan Bernstein.
1826
1827         * Scripts/check-for-inappropriate-macros-in-external-headers:
1828
1829 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1830
1831         [GTK] Make it easier to run CMake for downstreams
1832         https://bugs.webkit.org/show_bug.cgi?id=132370
1833
1834         Reviewed by Carlos Garcia Campos.
1835
1836         * Scripts/webkitdirs.pm:
1837         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1838         the GTK+ port.
1839
1840 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1841
1842         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1843         
1844         Rubber stamped by Jessie Berlin.
1845
1846         JSON.pm was removed from our tools setup.
1847
1848         * Scripts/generate-coverage-data:
1849
1850 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1851
1852         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1853         https://bugs.webkit.org/show_bug.cgi?id=112840
1854
1855         Rubber stamped by Geoffrey Garen.
1856
1857         * Scripts/build-jsc: Enable it on Mac.
1858         * Scripts/build-webkit: Enable it on Mac.
1859         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1860
1861 2014-04-28  Sam Weinig  <sam@webkit.org>
1862
1863         REGRESSION (r167751): svn-create-patch is very slow
1864         https://bugs.webkit.org/show_bug.cgi?id=132300
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         * Scripts/svn-create-patch:
1869         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1870         by calling `svn-create-patch --style`.
1871
1872 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1873
1874         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1875         https://bugs.webkit.org/show_bug.cgi?id=132190
1876
1877         Reviewed by Gustavo Noronha Silva.
1878
1879         * Scripts/webkitdirs.pm:
1880         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1881             if ninja is in the path.
1882         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1883             to the previous ninja generator if not.
1884
1885 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1886
1887         check-webkit-style should understand --git-index
1888         https://bugs.webkit.org/show_bug.cgi?id=125364
1889
1890         Reviewed by Csaba Osztrogonác.
1891
1892         * Scripts/webkitpy/common/checkout/scm/git.py:
1893         (Git.create_patch): The command now supports the --cached option.
1894         * Scripts/webkitpy/style/main.py:
1895         (CheckWebKitStyle.main): Passing the --git-index option.
1896         * Scripts/webkitpy/style/optparser.py:
1897         (CommandOptionValues.__init__): The git-index option is switched off by default.
1898         (CommandOptionValues.__eq__): Equality check for the new option.
1899         (ArgumentParser._create_option_parser):Adding the --git-index option
1900         (ArgumentParser.parse):
1901         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1902         (CommandOptionValuesTest.test_init): 
1903         (CommandOptionValuesTest.test_eq):
1904
1905 2014-04-28  Michael Saboff  <msaboff@apple.com>
1906
1907         Crash in platform/mac/accessibility/table-visible-rows.html
1908         https://bugs.webkit.org/show_bug.cgi?id=132146
1909
1910         Reviewed by Filip Pizlo.
1911
1912         Instead of creating a local JSValueRef array on the stack and passing that to
1913         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1914         values using the JSObjectSetPropertyAtIndex() API.
1915
1916         * DumpRenderTree/AccessibilityUIElement.cpp:
1917         (elementsForRangeCallback):
1918         (convertElementsToObjectArray):
1919         * DumpRenderTree/mac/TestRunnerMac.mm:
1920         (originsArrayToJS):
1921         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1922         (WTR::EventSendingController::contextClick):
1923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1924         (WTR::stringArrayToJS):
1925         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1926         (WTR::convertElementsToObjectArray):
1927
1928 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1929
1930         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1931         "no-cjit" runs force the old-school threshold.
1932
1933         Rubber stamped by Mark Hahnenberg.
1934
1935         * Scripts/run-jsc-stress-tests:
1936
1937 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1938
1939         [GTK] install-dependencies should also install ruby-json and ruby-highline
1940         https://bugs.webkit.org/show_bug.cgi?id=132292
1941
1942         Reviewed by Philippe Normand.
1943
1944         * gtk/install-dependencies: Install ruby json and highline packages.
1945
1946 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1947
1948         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1949         https://bugs.webkit.org/show_bug.cgi?id=132176
1950
1951         Reviewed by Gyuyoung Kim.
1952
1953         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1954         and turn off indexedDB feature until the sqlite implementation is introduced.
1955
1956         * Scripts/webkitperl/FeatureList.pm:
1957
1958 2014-04-25  James Craig  <jcraig@apple.com>
1959
1960         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1961         https://bugs.webkit.org/show_bug.cgi?id=132209
1962
1963         Reviewed by Daniel Bates.
1964
1965         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1966         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1967
1968         * Scripts/prepare-ChangeLog:
1969         (main): 
1970
1971 2014-04-25  Michael Saboff  <msaboff@apple.com>
1972
1973         Crash in platform/mac/accessibility/table-visible-rows.html
1974         https://bugs.webkit.org/show_bug.cgi?id=132146
1975
1976         Reviewed by Mark Lam.
1977
1978         Changed to use a local JSValueRef array temporary instead of a
1979         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1980         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1981         the temporary values could be collected.
1982
1983         * DumpRenderTree/AccessibilityUIElement.cpp:
1984         (convertElementsToObjectArray):
1985         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1986         (WTR::EventSendingController::contextClick):
1987         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1988         (WTR::convertElementsToObjectArray):
1989
1990 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1991
1992         Unreviewed GTK gardening
1993
1994         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1995         (TestRunner):
1996
1997 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1998
1999         prepare-ChangeLog reports as deleted methods that has not been removed.
2000         https://bugs.webkit.org/show_bug.cgi?id=131733
2001
2002         Reviewed by Ryosuke Niwa.
2003
2004         * Scripts/prepare-ChangeLog:
2005         (originalFile): Set merge base to origin/master by default.
2006
2007 2014-04-23  James Craig  <jcraig@apple.com>
2008
2009         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2010         https://bugs.webkit.org/show_bug.cgi?id=131115
2011
2012         Reviewed by Daniel Bates.
2013
2014         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2015
2016         * Scripts/commit-log-editor: Added --no-style.
2017         * Scripts/prepare-ChangeLog: Primary patch.
2018         (main): Primary patch.
2019         (createPatchCommand): Added --no-style.
2020         * Scripts/svn-create-patch: Primary patch.
2021         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2022         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2023         (SVN.create_patch): Added --no-style.
2024
2025 2014-04-23  Anders Carlsson  <andersca@apple.com>
2026
2027         Try to fix iOS build.
2028
2029         * DumpRenderTree/mac/DumpRenderTree.mm:
2030
2031 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2032
2033         Eliminate internals.setMockScrollbarsEnabled()
2034         https://bugs.webkit.org/show_bug.cgi?id=132085
2035
2036         Reviewed by Tim Horton.
2037
2038         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2039         No need to reset the preference, there is no way it can change.
2040
2041 2014-04-23  James Craig  <jcraig@apple.com>
2042
2043         Unreviewed. Moving myself from Contributors to Committers list.
2044
2045         * Scripts/webkitpy/common/config/contributors.json:
2046
2047 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2048
2049         Mock scrollbars don't always work in DumpRenderTree
2050         https://bugs.webkit.org/show_bug.cgi?id=132082
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         * DumpRenderTree/mac/DumpRenderTree.mm:
2055         (prepareConsistentTestingEnvironment):
2056         Set the mock scrollbar setting before creating the WebView, as this setting
2057         cannot be dynamically changed, so any scrollbars that are created during
2058         WebView initialization and are not replaced before snapshotting will end
2059         up being platform scrollbars instead of mock ones.
2060         WebKitTestRunner already sets this preference before creating WKViews,
2061         so we're just matching its behavior.
2062
2063 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2064
2065         [GTK] ShadowRoot API was removed in r164131
2066         https://bugs.webkit.org/show_bug.cgi?id=132059
2067
2068         Reviewed by Gustavo Noronha Silva.
2069
2070         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2071         the API docs.
2072
2073         * gtk/webkitdom.py:
2074         (WebKitDOMDocGenerator):
2075
2076 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2077
2078         [GTK] run-webkit-tests script is failing to invoke run-launcher
2079         https://bugs.webkit.org/show_bug.cgi?id=132051
2080
2081         Reviewed by Philippe Normand.
2082
2083         After the WK1 support was dropped, if run-webkit-tests is executed
2084         without --no-show-results parameter, the launcher is being called
2085         using a -2 parameter that is it causing the run-launcher to break.
2086
2087         * Scripts/webkitpy/port/gtk.py:
2088         (GtkPort.show_results_html_file):
2089
2090 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2091
2092         DumpRenderTree generates black snapshots on some platforms
2093         https://bugs.webkit.org/show_bug.cgi?id=132029
2094         <rdar://problem/16679363>
2095
2096         Reviewed by Simon Fraser.
2097
2098         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2099         (createBitmapContextFromWebView):
2100         DRT checks with the WebView to determine whether it can use the window's
2101         backing store directly or (because of compositing) needs to take a WindowServer
2102         snapshot. However, on some platforms and in some situations, the window can
2103         be layer backed without the WebView necessarily currently being composited.
2104         We should check with the window in addition to the WebView before going
2105         ahead and using its backing store.
2106
2107 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2108
2109         DumpRenderTree generates white snapshots on some platforms
2110         https://bugs.webkit.org/show_bug.cgi?id=132026
2111         <rdar://problem/16679363>
2112
2113         Reviewed by Simon Fraser.
2114
2115         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2116         Link DRT against QuartzCore.
2117
2118         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2119         (createBitmapContextFromWebView):
2120         Force CoreAnimation to synchronously update layers in a more explicit
2121         way that doesn't depend on AppKit behavior. This is very similar to what
2122         WebKitTestRunner does (indirectly) during its force repaint.
2123
2124 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2125
2126         [Win] Support Python 2.7 in Cygwin
2127         https://bugs.webkit.org/show_bug.cgi?id=132023
2128
2129         Reviewed by Michael Saboff.
2130
2131         * Scripts/webkitdirs.pm:
2132         (checkInstalledTools): Remove check for Python 2.7, since
2133         it now works properly.
2134
2135 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2136
2137         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2138         https://bugs.webkit.org/show_bug.cgi?id=130867
2139         <rdar://problem/16432456> 
2140
2141         Reviewed by Mark Hahnenberg.
2142
2143         * Scripts/build-webkit:
2144         * Scripts/copy-webkitlibraries-to-product-directory:
2145
2146 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2147
2148         [GTK] Fails to build documentation when output is redirected
2149         https://bugs.webkit.org/show_bug.cgi?id=131178
2150
2151         Reviewed by Martin Robinson.
2152
2153         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2154         explicitly to avoid encoding issues when they are redirected.
2155
2156 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2157
2158         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2159         https://bugs.webkit.org/show_bug.cgi?id=131911
2160
2161         Reviewed by Martin Robinson.
2162
2163         common.get_build_path returns release path even though Debug configuration
2164         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2165
2166         * gtk/ycm_extra_conf.py:
2167         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2168         (FlagsForFile):
2169
2170 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2171
2172         Unreviewed build fix.
2173
2174         * DumpRenderTree/mac/EventSendingController.mm:
2175         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2176         Correct a typo that prevented tests from working properly.
2177
2178 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2179
2180         [GTK] Should have the ability to output composited contents during layout testing
2181         https://bugs.webkit.org/show_bug.cgi?id=131864
2182
2183         Reviewed by Philippe Normand.
2184
2185         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2186         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2187         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2188         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2189         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2190
2191 2014-04-21  Sam Weinig  <sam@webkit.org>
2192
2193         Attempt to fix the tests.
2194
2195         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2196         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2197         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2198
2199 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2200
2201         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2202         being the same as a "quick run", which is meant for genuinely slow tests).
2203
2204         * Scripts/run-jsc-stress-tests:
2205
2206 2014-04-21  Darin Adler  <darin@apple.com>
2207
2208         Add HashSet::takeAny
2209         https://bugs.webkit.org/show_bug.cgi?id=131928
2210
2211         Reviewed by Benjamin Poulain.
2212
2213         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2214
2215 2014-04-20  Dan Bernstein  <mitz@apple.com>
2216
2217         Fixed a test timing out after r167572.
2218
2219         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2220         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2221         -webView:didFinishLoadingNavigation:.
2222
2223 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2224
2225         Unreviewed, rolling out r167510.
2226         https://bugs.webkit.org/show_bug.cgi?id=131915
2227
2228         broke GTK Debug bot (Requested by philn on #webkit).
2229
2230         Reverted changeset:
2231
2232         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2233         it when running layout tests"
2234         https://bugs.webkit.org/show_bug.cgi?id=131472
2235         http://trac.webkit.org/changeset/167510
2236
2237 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2238
2239         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2240         https://bugs.webkit.org/show_bug.cgi?id=131472
2241
2242         Reviewed by Philippe Normand.
2243
2244         * Scripts/webkitpy/port/gtk.py:
2245         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2246         when running WebKitTestRunner with run-webkit-tests.
2247         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2248         installed.
2249         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2250         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2251         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2252         deal.
2253
2254 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2255
2256         DownloadDecideDestinationCrash API test uses an incorrect value for path
2257         https://bugs.webkit.org/show_bug.cgi?id=131845
2258         <rdar://problem/15925560>
2259
2260         Reviewed by Enrica Casucci.
2261
2262         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2263         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2264
2265 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2266
2267         [Mac] AttributedStringTest API tests fail with async text input
2268         https://bugs.webkit.org/show_bug.cgi?id=131833
2269
2270         Reviewed by Enrica Casucci.
2271
2272         Don't run sync NSTextInputClient tests where we don't implement these calls.
2273
2274         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2275         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2276         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2277         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2278         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2279         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2280         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2281
2282 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2283
2284         Remove NETWORK_INFO support
2285         https://bugs.webkit.org/show_bug.cgi?id=131841
2286
2287         Reviewed by Gyuyoung Kim.
2288
2289         * Scripts/webkitperl/FeatureList.pm:
2290
2291 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2292
2293         [GTK] YouCompleteMe doesn't work for cmake build system.
2294         https://bugs.webkit.org/show_bug.cgi?id=131591
2295
2296         Reviewed by Martin Robinson.
2297
2298         Add cmake build system support for YouCompleteMe. It should work regardless of
2299         using make or ninja. In addition, autotools related code is removed since it's
2300         not used anymore in WebKit.
2301
2302         * Scripts/webkitdirs.pm:
2303         (generateBuildSystemFromCMakeProject):
2304         * gtk/ycm_extra_conf.py:
2305         (transform_relative_paths_to_absolute_paths):
2306         (FlagsForFile):
2307
2308 2014-04-17  Anders Carlsson  <andersca@apple.com>
2309
2310         Fix build.
2311
2312         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2313         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2314         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2315
2316 2014-04-17  Anders Carlsson  <andersca@apple.com>
2317
2318         Remove unused API enums
2319         https://bugs.webkit.org/show_bug.cgi?id=131836
2320
2321         Reviewed by Tim Horton.
2322
2323         * MiniBrowser/mac/WK2BrowserWindowController.m:
2324         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2325
2326 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2327
2328         [Win] A few final cleanups to the DataObject classes.
2329         https://bugs.webkit.org/show_bug.cgi?id=131784
2330
2331         Reviewed by Anders Carlsson.
2332
2333         * DumpRenderTree/win/DRTDataObject.cpp:
2334         (DRTDataObject::clearData): Use 'last()' method.
2335         * DumpRenderTree/win/UIDelegate.cpp:
2336         (DRTUndoStack::pop): Use 'takeLast()' method.
2337
2338 2014-04-17  Andres Gomez  <agomez@igalia.com>
2339
2340         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2341         https://bugs.webkit.org/show_bug.cgi?id=131365
2342
2343         Reviewed by Brent Fulgham.
2344
2345         The cygwin installer is now downloading the wanted versions for
2346         the local installation given to the setup wizard.
2347
2348         * CygwinDownloader/cygwin-downloader.py:
2349         * CygwinDownloader/cygwin-downloader.zip:
2350
2351 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2352
2353         [GTK] Make run-webkit-tests always use WKTR
2354         https://bugs.webkit.org/show_bug.cgi?id=131737
2355
2356         Reviewed by Darin Adler.
2357
2358         Now that the GTK+ port only has support for WebKit2, instruct
2359         run-webkit-tests to always use WKTR. This avoids needing to pass
2360         flag "-2" every time.
2361
2362         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2363         (_set_up_derived_options): Always set webkit_test_runner when
2364         the platform is GTK+.
2365
2366 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2367
2368         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2369         https://bugs.webkit.org/show_bug.cgi?id=131760
2370
2371         Reviewed by Philippe Normand.
2372
2373         * gtk/install-dependencies: Install ninja-build when it's available.
2374
2375 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2376
2377         [Win] run-javascriptcore-tests fails to run.
2378         https://bugs.webkit.org/show_bug.cgi?id=131761
2379
2380         Reviewed by Brent Fulgham.
2381
2382         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2383
2384 2014-04-16  Andres Gomez  <agomez@igalia.com>
2385
2386         [Win] Pass default parameters to cygwin setup wizard
2387         https://bugs.webkit.org/show_bug.cgi?id=131361
2388
2389         Reviewed by Brent Fulgham.
2390
2391         Added some parameters to the cygwin setup wizard so the user
2392         doesn't really have to do any interaction.
2393
2394         * CygwinDownloader/cygwin-downloader.py:
2395         * CygwinDownloader/cygwin-downloader.zip:
2396
2397 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2398
2399         [Win] Eliminate use of deleteAllValues in Windows Files
2400         https://bugs.webkit.org/show_bug.cgi?id=131631
2401
2402         Reviewed by Darin Adler.
2403
2404         Switch to std::unique_ptr for memory lifetime. Get rid of
2405         deleteAllValues now that it is no longer needed. Use ranged
2406         for loops where possible.
2407
2408         * DumpRenderTree/win/DRTDataObject.cpp:
2409         (WCEnumFormatEtc::WCEnumFormatEtc):
2410         (DRTDataObject::~DRTDataObject):
2411         (DRTDataObject::GetData):
2412         (DRTDataObject::QueryGetData):
2413         (DRTDataObject::SetData):
2414         (DRTDataObject::clearData):
2415         * DumpRenderTree/win/DRTDataObject.h:
2416         * DumpRenderTree/win/UIDelegate.cpp:
2417         (DRTUndoObject::DRTUndoObject):
2418         (DRTUndoObject::~DRTUndoObject):
2419         (DRTUndoStack::~DRTUndoStack):
2420         (DRTUndoStack::clear):
2421         (DRTUndoStack::pop):
2422         (DRTUndoManager::DRTUndoManager):
2423         (DRTUndoManager::redo):
2424         (DRTUndoManager::undo):
2425         (UIDelegate::UIDelegate):
2426         (UIDelegate::resetUndoManager):
2427         * DumpRenderTree/win/UIDelegate.h:
2428
2429 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2430
2431         [GTK] Unreviewed GTK gardening.
2432
2433         Update list of skipped unit tests:
2434
2435           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2436
2437           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2438           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2439
2440         * Scripts/run-gtk-tests:
2441         (TestRunner):
2442
2443 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2444
2445         check-webkit-style doesn't check code style in .mm or .m files
2446         https://bugs.webkit.org/show_bug.cgi?id=131708
2447
2448         Reviewed by Darin Adler.
2449
2450         * Scripts/webkitpy/style/checker.py:
2451         * Scripts/webkitpy/style/checker_unittest.py:
2452         (CheckerDispatcherDispatchTest.test_cpp_paths):
2453         (CheckerDispatcherDispatchTest.test_text_paths):
2454         Check .mm and .m files as C++.
2455
2456         * Scripts/webkitpy/style/checkers/cpp.py:
2457         (check_spacing):
2458         Add an override for our ordinary "missing spaces around =" for @synthesize,
2459         which should look like "@synthesize propertyName=_varName;"
2460
2461         Add an override for "missing space before {" for blocks' "^{".
2462
2463         Don't follow the "extra space before [" rule for Objective-C, because
2464         it breaks this rule in a multitude of ways because of method calls.
2465
2466         (check_braces):
2467         Don't complain about { not being on the end of the previous line if
2468         the previous line starts with "- (" or "+ (", which would indicate a
2469         Objective-C method definition.
2470
2471 2014-04-16  Darin Adler  <darin@apple.com>
2472
2473         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2474         https://bugs.webkit.org/show_bug.cgi?id=131735
2475
2476         Reviewed by Alexey Proskuryakov.
2477
2478         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2479         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2480         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2481         way, but gtest works better this way.
2482
2483 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2484
2485         [EFL] Fix problems with the pixel dump.
2486         https://bugs.webkit.org/show_bug.cgi?id=131265
2487
2488         Reviewed by Gyuyoung Kim.
2489
2490         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2491         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2492         which causes that nothing is drawn.
2493
2494         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2495         One of new functions is AcceleratedCompositingContext::extractImageData(),
2496         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2497         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2498
2499         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2500         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2501
2502 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2503
2504         Update LLVM export scrpt to handle the build directory being different from the
2505         source directory.
2506
2507         Rubber stamped by Geoffrey Garen.
2508
2509         * Scripts/export-llvm-build:
2510
2511 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2512
2513         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2514         https://bugs.webkit.org/show_bug.cgi?id=131695
2515
2516         Reviewed by Antti Koivisto.
2517
2518         Updated.
2519
2520         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2521
2522 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2523
2524         [GTK] Reduce the binary size by compressing the text based web inspector resources
2525         https://bugs.webkit.org/show_bug.cgi?id=121545
2526
2527         Reviewed by Gustavo Noronha Silva.
2528
2529         Compress text based files when compiling inspector resources. It
2530         reduces the binary size in 3MB.
2531
2532         * gtk/generate-inspector-gresource-manifest.py:
2533         (find_all_files_in_directory):
2534         (is_compressible):
2535
2536 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2537
2538         Remove Gtk WebKit1 tester.
2539
2540         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2541         results over and over as fast as it could.
2542
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2544         (WebKitBuildbot):
2545
2546 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2547
2548         Wrong link for webkitpy tests results in dashboard popover
2549         https://bugs.webkit.org/show_bug.cgi?id=131664
2550
2551         Reviewed by Timothy Hatcher.
2552
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2554         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2555         Use a correct link.
2556
2557 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2558
2559         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2560
2561         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2562
2563         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2564         (CommitMessageForThisCommitTest):
2565
2566 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2567
2568         Fix commit-log-editor bug revealed by r165447
2569         https://bugs.webkit.org/show_bug.cgi?id=130676
2570
2571         Reviewed by Csaba Osztrogonác.
2572
2573         * Scripts/commit-log-editor:
2574         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2575         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2576         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2577         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2578
2579 2014-04-13  Darin Adler  <darin@apple.com>
2580
2581         userVisibleString should not try to "encode" host names
2582         https://bugs.webkit.org/show_bug.cgi?id=131587
2583         rdar://problem/14686849
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2588
2589         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2590         Coverage is tiny at this point; we could add a lot more cases!
2591
2592 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2593
2594         Use #include instead of #import
2595         https://bugs.webkit.org/show_bug.cgi?id=131604
2596
2597         Reviewed by Darin Adler.
2598
2599         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2600
2601         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2602
2603 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2604
2605         Make slow-stress tests run faster by running fewer VM variants.
2606
2607         Rubber stamped by Geoffrey Garen.
2608
2609         * Scripts/run-javascriptcore-tests:
2610         * Scripts/run-jsc-stress-tests:
2611
2612 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2613
2614         [CMake] Add missing WTF unit tests
2615         https://bugs.webkit.org/show_bug.cgi?id=131459
2616
2617         Reviewed by Martin Robinson.
2618
2619         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2620         that should be compiled into the TestWTF binary.
2621
2622 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2623
2624         [Gtk] run-launcher doesn't work by default
2625         https://bugs.webkit.org/show_bug.cgi?id=131494
2626
2627         Reviewed by Philippe Normand.
2628
2629         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2630         * Scripts/webkitdirs.pm:
2631         (launcherName): Same.
2632         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2633         * gtk/common.py:
2634         (get_build_path.is_valid_build_directory): Same.
2635         * gtk/manifest.txt: Same.
2636
2637 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2638
2639         Unreviewed, rolling out r167046.
2640         https://bugs.webkit.org/show_bug.cgi?id=131479
2641
2642         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2643         on #webkit).
2644
2645         Reverted changeset:
2646
2647         "Remove "System Font" from whitelisted DRT fonts and char
2648         width calculations"
2649         https://bugs.webkit.org/show_bug.cgi?id=131411
2650         http://trac.webkit.org/changeset/167046
2651
2652 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2653
2654         Remove "System Font" from whitelisted DRT fonts and char width calculations
2655         https://bugs.webkit.org/show_bug.cgi?id=131411
2656
2657         Reviewed by Tim Horton.
2658
2659         Covered by existing tests.
2660
2661         * DumpRenderTree/mac/DumpRenderTree.mm:
2662         (allowedFontFamilySet):
2663
2664 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2665
2666         systemHiddenFontFamilySet in DRT is unnecessary
2667         https://bugs.webkit.org/show_bug.cgi?id=131414
2668
2669         Reviewed by Tim Horton.
2670
2671         It doesn't seem to affect test results on my machine.
2672
2673         * DumpRenderTree/mac/DumpRenderTree.mm:
2674         (drt_NSFontManager_availableFonts):
2675         (systemHiddenFontFamilySet): Deleted.
2676
2677 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2678
2679         [Win] Unreviewed test fix: Don't double-release BSTR.
2680
2681         * DumpRenderTree/win/DumpRenderTree.cpp:
2682         (dump): Remove unneeded call to SysFreeString now that we are
2683         using _bstr_t for this variable.
2684
2685 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2686
2687         [Win] Various DumpRenderTree Fixes.
2688         https://bugs.webkit.org/show_bug.cgi?id=131446.
2689
2690         Reviewed by Tim Horton.
2691
2692         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2693         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2694         (AccessibilityUIElement::description): Ditto.
2695         (AccessibilityUIElement::helpText): Ditto.
2696         (AccessibilityUIElement::intValue): Ditto.
2697         (AccessibilityUIElement::isPressActionSupported): Ditto.
2698         (AccessibilityUIElement::accessibilityValue): Ditto.
2699         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2700         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2701         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2702         (DRTDesktopNotificationPresenter::Release): Ditto.
2703         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2704         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2705         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2706         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2707         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2708         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2709         * DumpRenderTree/win/DumpRenderTree.cpp:
2710         (dumpFrameScrollPosition): Ditto.
2711         (dumpFramesAsText): Ditto.
2712         (compareHistoryItems): Ditto.
2713         (dumpHistoryItem): Ditto.
2714         (dump): Ditto.
2715         (resetDefaultsToConsistentValues): Ditto.
2716         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2717         (runTest): Ditto.
2718         (createWebViewAndOffscreenWindow): Ditto.
2719         * DumpRenderTree/win/EditingDelegate.cpp:
2720         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2721         (EditingDelegate::AddRef): Ditto.
2722         (EditingDelegate::Release): Ditto.
2723         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2724         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2725         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2726         (EditingDelegate::shouldInsertNode): Ditto.
2727         (EditingDelegate::shouldInsertText): Ditto.
2728         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2729         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2730         (EditingDelegate::shouldApplyStyle): Ditto.
2731         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2732         (EditingDelegate::doPlatformCommand): Ditto.
2733         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2734         (EditingDelegate::webViewDidChange): Ditto.
2735         (EditingDelegate::webViewDidEndEditing): Ditto.
2736         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2737         (EditingDelegate::webViewDidChangeSelection): Ditto.
2738         (EditingDelegate::checkSpellingOfString): Ditto.
2739         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2740         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2741         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2742         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2743         (FrameLoadDelegate::AddRef): Ditto.
2744         (FrameLoadDelegate::Release): Ditto.
2745         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2746         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2747         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2748         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2749         (FrameLoadDelegate::didReceiveTitle): Ditto.
2750         (FrameLoadDelegate::didChangeIcons): Ditto.
2751         (delegatesWithDelayedWork): Ditto.
2752         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2753         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2754         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2755         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2756         (FrameLoadDelegate::willCloseFrame): Ditto.
2757         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2758         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2759         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2760         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2761         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2762         * DumpRenderTree/win/FrameLoadDelegate.h:
2763         * DumpRenderTree/win/HistoryDelegate.cpp:
2764         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2765         (HistoryDelegate::updateHistoryTitle): Ditto.
2766         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2767         * DumpRenderTree/win/PolicyDelegate.cpp:
2768         (dumpPath):
2769         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2770         (PolicyDelegate::AddRef): Ditto.
2771         (PolicyDelegate::Release): Ditto.
2772         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2773         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2774         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2775         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2776         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2777         (ResourceLoadDelegate::AddRef): Ditto.
2778         (ResourceLoadDelegate::Release): Ditto.
2779         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2780         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2781         (ResourceLoadDelegate::willSendRequest): Ditto.
2782         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2783         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2784         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2785         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2786         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2787         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2788         (TestRunner::setUserStyleSheetLocation): Ditto.
2789         (TestRunner::execCommand): Ditto.
2790         (TestRunner::overridePreference): Ditto.
2791         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2792         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2793         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2794         (TextInputController::insertText): Ditto.
2795         * DumpRenderTree/win/UIDelegate.cpp:
2796         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2797         (UIDelegate::AddRef): Ditto.
2798         (UIDelegate::Release): Ditto.
2799         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2800         (UIDelegate::trackCustomPopupMenu): Ditto.
2801         (UIDelegate::registerUndoWithTarget): Ditto.
2802         (UIDelegate::removeAllActionsWithTarget): Ditto.
2803         (UIDelegate::setActionTitle): Ditto.
2804         (UIDelegate::undo): Ditto.
2805         (UIDelegate::redo): Ditto.
2806         (UIDelegate::canUndo): Ditto.
2807         (UIDelegate::canRedo): Ditto.
2808         (UIDelegate::printFrame): Ditto.
2809         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2810         (UIDelegate::webViewHeaderHeight): Ditto.
2811         (UIDelegate::webViewFooterHeight): Ditto.
2812         (UIDelegate::drawHeaderInRect): Ditto.
2813         (UIDelegate::drawFooterInRect): Ditto.
2814         (UIDelegate::webViewPrintingMarginRect): Ditto.
2815         (UIDelegate::canRunModal): Ditto.
2816         (UIDelegate::createModalDialog): Ditto.
2817         (UIDelegate::runModal): Ditto.
2818         (UIDelegate::isMenuBarVisible): Ditto.
2819         (UIDelegate::setMenuBarVisible): Ditto.
2820         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2821         (UIDelegate::paintCustomScrollbar): Ditto.
2822         (UIDelegate::paintCustomScrollCorner): Ditto.
2823         (UIDelegate::setFrame): Ditto.
2824         (UIDelegate::webViewFrame): Ditto.
2825         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2826         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2827         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2828         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2829         (UIDelegate::webViewAddMessageToConsole): Ditto.
2830         (UIDelegate::doDragDrop): Ditto.
2831         (UIDelegate::webViewGetDlgCode): Ditto.
2832         (UIDelegate::createWebViewWithRequest): Ditto.
2833         (UIDelegate::webViewClose): Ditto.
2834         (UIDelegate::webViewFocus): Ditto.
2835         (UIDelegate::webViewUnfocus): Ditto.
2836         (UIDelegate::webViewPainted): Ditto.
2837         (UIDelegate::exceededDatabaseQuota): Ditto.
2838         (UIDelegate::embeddedViewWithArguments): Ditto.
2839         (UIDelegate::webViewClosing): Ditto.
2840         (UIDelegate::webViewSetCursor): Ditto.
2841         (UIDelegate::webViewDidInvalidate): Ditto.
2842         (UIDelegate::setStatusText): Ditto.
2843         (UIDelegate::desktopNotificationsDelegate): Ditto.
2844         (UIDelegate::drawBackground): Ditto.
2845         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2846         (UIDelegate::didPressMissingPluginButton): Ditto.
2847         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2848         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2849         (LoadHTMLStringItem::invoke): Ditto.
2850         (ScriptItem::invoke): Ditto.
2851
2852 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2853
2854         Stylechecker: False positive on inline asm code.
2855         https://bugs.webkit.org/show_bug.cgi?id=130570
2856
2857         Reviewed by Csaba Osztrogonác.
2858
2859         Disable stylechecking in asm blocks.
2860
2861         * Scripts/webkitpy/style/checkers/cpp.py:
2862         (process_line):
2863         (_InlineASMState):
2864         (_InlineASMState.__init__):
2865         (_InlineASMState.process_line):
2866         (_InlineASMState.isInside):
2867         (_process_lines):
2868         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2869         (WebKitStyleTest.test_member_initialization_list):
2870
2871 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2872
2873         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2874         https://bugs.webkit.org/show_bug.cgi?id=131029
2875
2876         Reviewed by Philippe Normand.
2877
2878         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2879         tests and remove the getWebKit1TestResoucesDir() method.
2880
2881         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2882         (testDownloadLocalFile): Use Test::getResourcesDir().
2883         (testDownloadLocalFileError): Ditto.
2884         (serverCallback): Ditto.
2885         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2886         (serverCallback): Ditto.
2887         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2888         (httpServerCallback): Ditto.
2889         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2890         (serverCallback): Ditto.
2891         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2892         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2893         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2894         (Test::getWebKit1TestResoucesDir): Deleted.
2895
2896 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2897
2898         [WK2] HTTP authentication regression tests fail
2899         https://bugs.webkit.org/show_bug.cgi?id=81627
2900         <rdar://problem/11079296>
2901
2902         Reviewed by Anders Carlsson.
2903
2904         * WebKitTestRunner/TestController.h:
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2907         to pageLoaderClient structure.
2908         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2909         for password based authentication (we do get server trust challenges on some tests,
2910         which WKTR can't handle).
2911         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2912         calls won't be made, at least on CFNetwork based platforms.
2913         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2914         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2915         make sense to associate auth requests with individual resources - there can be
2916         multiple resources loading at once from the same protection space, so WebKit1 API
2917         that had a resource identifier was inherently racy.
2918
2919 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2920
2921         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2922         https://bugs.webkit.org/show_bug.cgi?id=131427
2923
2924         Reviewed by Gyuyoung Kim.
2925
2926         Since r166973, font path was changed.
2927
2928         * DumpRenderTree/PlatformEfl.cmake:
2929         * WebKitTestRunner/PlatformEfl.cmake:
2930
2931 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2932
2933         Fix the build-jsc build
2934         https://bugs.webkit.org/show_bug.cgi?id=131410
2935
2936         Reviewed by Michael Saboff.
2937
2938         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2939         WTF depends on it.
2940
2941 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2942
2943         [GTK] Remove WebKit1 unit tests
2944         https://bugs.webkit.org/show_bug.cgi?id=131359
2945
2946         Reviewed by Anders Carlsson.
2947
2948         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2949         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2950         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2951
2952         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2953         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2954         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2955         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2956         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2957         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2958         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2959         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2960         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2961         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2962         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2963         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2964         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2965         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2966         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2967         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2968         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2969         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2970         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2971         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2972         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2973         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2974         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2975         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2976         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2977         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2978         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2979         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2980         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2981         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2982         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2983         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2984         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2985         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2986         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2987         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2988         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2989         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2990
2991 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2992
2993         Unreviewed gardening (Take 2): Prevent users from attempting
2994         to build with known invalid cURL. 
2995
2996         * Scripts/webkitdirs.pm:
2997         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2998         7.33.0 (the known good version).
2999
3000 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3001
3002         [GTK] Remove DumpRenderTree and GtkLauncher
3003         https://bugs.webkit.org/show_bug.cgi?id=131373
3004
3005         Reviewed by Andreas Kling.
3006
3007         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3008         no longer necessary now that WebKit1 GTK+ will be removed.
3009
3010         * CMakeLists.txt:
3011         * DumpRenderTree/PlatformGTK.cmake: Removed.
3012         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3013         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3014         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3015         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3016         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3017         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3018         * DumpRenderTree/gtk/EventSender.h: Removed.
3019         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3020         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3021         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3022         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3023         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3024         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3025         * DumpRenderTree/gtk/TextInputController.h: Removed.
3026         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3027         * GtkLauncher/CMakeLists.txt: Removed.
3028         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3029         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3030         * GtkLauncher/main.c: Removed.
3031         * GtkLauncher/simple.svg: Removed.
3032         * GtkLauncher/text.html: Removed.
3033         * WebKitTestRunner/PlatformGTK.cmake:
3034         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3035         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3036         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3037
3038 2014-04-08  Mark Rowe  <mrowe@apple.com>
3039
3040         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3041         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3042
3043         Reviewed by Alexey Proskuryakov.
3044
3045         * Scripts/webkitdirs.pm:
3046         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3047         (execMacWebKitAppForDebugging): Ditto.
3048
3049 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3050
3051         Build bmalloc on iOS too
3052         https://bugs.webkit.org/show_bug.cgi?id=131381
3053
3054         Reviewed by Andreas Kling.
3055
3056         * Scripts/build-webkit:
3057
3058 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3059
3060         Unreviewed gardening: Prevent users from attempting
3061         to build with known invalid cURL.
3062
3063         * Scripts/webkitdirs.pm:
3064         (checkInstalledTools): Block build attempts with bad
3065         Cygwin tool set.
3066
3067 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3068
3069         Build bmalloc on Mac
3070         https://bugs.webkit.org/show_bug.cgi?id=131333
3071
3072         Reviewed by Mark Rowe.
3073
3074         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3075         (Note: Just testing Mac is not good enough because in this
3076         script 'Mac' means 'Mac or iOS'.)
3077
3078 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3079
3080         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3081         https://bugs.webkit.org/show_bug.cgi?id=130951
3082
3083         Reviewed by Geoffrey Garen.
3084
3085         * Scripts/run-javascriptcore-tests:
3086
3087 2014-04-06  Darin Adler  <darin@apple.com>
3088
3089         Rework CSS calc logic, fixing some reference count mistakes in Length
3090         https://bugs.webkit.org/show_bug.cgi?id=131280
3091
3092         Reviewed by Andreas Kling.
3093
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3095         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3096
3097 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3098
3099         Enable WEB_REPLAY for PLATFORM(MAC)
3100         https://bugs.webkit.org/show_bug.cgi?id=130700
3101
3102         Reviewed by Timothy Hatcher.
3103
3104         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3105
3106 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3107
3108         [CMake] Include X11's include dirs in TestNetscapePlugin
3109         https://bugs.webkit.org/show_bug.cgi?id=131270
3110
3111         Reviewed by Martin Robinson.
3112
3113         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3114         TestNetscapePlugin includes WebCore code that includes X headers.
3115
3116 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3117
3118         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3119         <http://webkit.org/b/130986>
3120
3121         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3122         prefix to TileCache class names in exception list.
3123
3124 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3125
3126         [GTK] kill-old-processes should kill dbus-daemon processes
3127         https://bugs.webkit.org/show_bug.cgi?id=127352
3128
3129         Reviewed by Martin Robinson.
3130
3131         * BuildSlaveSupport/kill-old-processes:
3132         (main):
3133
3134 2014-04-04  Andres Gomez  <agomez@igalia.com>
3135
3136         [Win] Update obsolete packages in cygwin
3137         https://bugs.webkit.org/show_bug.cgi?id=126264
3138
3139         Reviewed by Brent Fulgham.
3140
3141         Removed "apache" and "minires" as the first has been replaced by
3142         "lighttpd" and the second is now integrated into
3143         "cygwin". Replaced the transitional and now obsolete "gcc" package
3144         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3145         since the newer version available is "2.7.3" which breaks the
3146         build due to some funniness with environment variable handling.
3147
3148         * CygwinDownloader/cygwin-downloader.py:
3149         * CygwinDownloader/cygwin-downloader.zip:
3150
3151 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3152
3153         check-webkit-style: Improve warnings on Objective-C @property syntax
3154         https://bugs.webkit.org/show_bug.cgi?id=131200
3155
3156         Reviewed by Dan Bernstein.
3157
3158         * Scripts/webkitpy/style/checkers/cpp.py:
3159         (check_spacing):
3160         (CppChecker):
3161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3162         (CppStyleTest.test_spacing_in_objective_c_properties):
3163
3164 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3165
3166         Unreviewed. Moving my name to commiter section
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3171
3172         Unreviewed. Add myself as a committer.
3173
3174         * Scripts/webkitpy/common/config/contributors.json:
3175
3176 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3177
3178         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3179         https://bugs.webkit.org/show_bug.cgi?id=130391
3180
3181         Reviewed by Gyuyoung Kim.
3182
3183         Change the implementation of the zoom functionality from ewk_view_scale_set
3184         to ewk_view_page_zoom_set.
3185
3186         * MiniBrowser/efl/main.c:
3187
3188 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3189
3190         [webkitpy] perf profiler does not understand --call-graph argument
3191         https://bugs.webkit.org/show_bug.cgi?id=131132
3192
3193         Reviewed by Ryosuke Niwa.
3194
3195         New versions of perf profiler have changed the argument from --call-graph to -g.
3196
3197         * Scripts/webkitpy/common/system/profiler.py:
3198         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3199         * Scripts/webkitpy/port/driver_unittest.py:
3200         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3201
3202 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3203
3204         Add EFL WK2 performance bot to build.webkit.org
3205         https://bugs.webkit.org/show_bug.cgi?id=131034
3206
3207         Fix after r166707, use "Perf" instead of "perf" for consistency.
3208
3209         Reviewed by Csaba Osztrogonác.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/config.json:
3212
3213 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3214
3215         Add EFL WK2 performance bot to build.webkit.org
3216         https://bugs.webkit.org/show_bug.cgi?id=131034
3217
3218         Reviewed by Csaba Osztrogonác.
3219
3220         * BuildSlaveSupport/build.webkit.org-config/config.json:
3221
3222 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3223
3224         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3225         https://bugs.webkit.org/show_bug.cgi?id=131151
3226
3227         Reviewed by Gyuyoung Kim.
3228
3229         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3230         (TouchEventInfo::TouchEventInfo):
3231         (sendTouchEvent):
3232         (addTouchPointCallback):
3233         (updateTouchPointCallback):
3234         (cancelTouchPointCallback):
3235         (releaseTouchPointCallback):
3236
3237 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3238
3239         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3240         <http://webkit.org/b/131045>
3241
3242         Reviewed by Daniel Bates.
3243
3244         * Scripts/filter-build-webkit:
3245         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3246         of clang, plus debug data for all DVTAssertions.
3247
3248 2014-04-01  Dean Jackson  <dino@apple.com>
3249
3250         Load Media Controls js/css from bundle
3251         https://bugs.webkit.org/show_bug.cgi?id=131086
3252
3253         Reviewed by Eric Carlson.
3254
3255         We're now putting CSS files into the bundle, so remove the test for them.
3256
3257         * Scripts/check-for-inappropriate-files-in-framework:
3258
3259 2014-04-02  Martin Hock  <mhock@apple.com>
3260
3261         Unify private browsing with sessions.
3262         https://bugs.webkit.org/show_bug.cgi?id=130099
3263
3264         Reviewed by Alexey Proskuryakov.
3265
3266         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3269         (TestWebKitAPI::didNavigateWithNavigationData):
3270         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3271         (TestWebKitAPI::TEST):
3272
3273         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3274         (TestWebKitAPI::didNavigateWithoutNavigationData):
3275         (TestWebKitAPI::didNavigateWithNavigationData):
3276         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3277         (TestWebKitAPI::TEST):
3278
3279 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3280
3281         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3282         https://bugs.webkit.org/show_bug.cgi?id=130343
3283
3284         Reviewed by Gustavo Noronha Silva.
3285
3286         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3287         of directories on the command line and look for all appropriate files in those directories for the
3288         GResource archive. Also make archive paths relative to those directories.
3289         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3290         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3291
3292 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3293
3294         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3295         https://bugs.webkit.org/show_bug.cgi?id=131106
3296
3297         Reviewed by Csaba Osztrogonác.
3298
3299         * Scripts/webkitpy/tool/commands/download.py:
3300         (AbstractRolloutPrepCommand._prepare_state):
3301         * Scripts/webkitpy/tool/commands/download_unittest.py:
3302         (test_prepare_rollout):
3303         (test_create_rollout):
3304         (test_create_rollout_resolved):
3305         (test_rollout):
3306
3307 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3308
3309         [EFL] Add option to use separate web process for new window in MiniBrowser
3310         https://bugs.webkit.org/show_bug.cgi?id=130190
3311
3312         Reviewed by Gyuyoung Kim.
3313
3314         New created window (CTRL + n) will be open in separated web process.
3315         This option is enabled by adding a flag (S/separate-process) with launching
3316         MiniBrowser.
3317
3318         * MiniBrowser/efl/main.c:
3319         (elm_main):
3320
3321 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3322
3323         [GTK] Move NEWS file to a new location
3324         https://bugs.webkit.org/show_bug.cgi?id=130901
3325
3326         Reviewed by Brent Fulgham.
3327
3328         * gtk/manifest.txt: Update the NEWS file path.
3329
3330 2014-04-01  Anders Carlsson  <andersca@apple.com>
3331
3332         Fix build.
3333
3334         * MiniBrowser/mac/WK2BrowserWindowController.m:
3335         (-[WK2BrowserWindowController awakeFromNib]):
3336         (-[WK2BrowserWindowController dealloc]):
3337         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3338
3339 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3340
3341         Unreviewed test gardening.
3342
3343         * Scripts/webkitpy/port/base_unittest.py:
3344         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3345
3346 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3347
3348         [CSS Exclusions] Remove exclusions parsing support
3349         https://bugs.webkit.org/show_bug.cgi?id=131046
3350
3351         Reviewed by David Hyatt.
3352
3353         * Scripts/webkitperl/FeatureList.pm:
3354
3355 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3356
3357         [GTK] Remove last reference to GTK+ WK1 EWS
3358         https://bugs.webkit.org/show_bug.cgi?id=131058
3359
3360         Reviewed by Martin Robinson.
3361
3362         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3363
3364         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3365
3366 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3367
3368         Add a 32bit JSC builder/tester.
3369         https://bugs.webkit.org/show_bug.cgi?id=131054
3370         
3371         Reviewed by Michael Saboff.
3372
3373         * BuildSlaveSupport/build.webkit.org-config/config.json:
3374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3375         (Compile32bitJSC):
3376         (Run32bitJSCTests):
3377         (Run32bitJSCTests.countFailures):
3378         (BuildAndTest32bitJSCFactory):
3379         (BuildAndTest32bitJSCFactory.__init__):
3380
3381 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3382
3383         [GTK] No longer build WebKit1 gtkdoc
3384         https://bugs.webkit.org/show_bug.cgi?id=130970
3385
3386         Reviewed by Anders Carlsson.
3387
3388         * gtk/common.py:
3389         (gtk_version_of_pkg_config_file): Deleted.
3390         * gtk/generate-gtkdoc:
3391         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3392         was only applicable for WebKit1.
3393         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3394
3395 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3396
3397         [GTK] Running minibrowser with url crashes in debug build
3398         https://bugs.webkit.org/show_bug.cgi?id=130492
3399
3400         Reviewed by Martin Robinson.
3401
3402         Update "uri-scheme" test not to use invalid URIs in it, so we
3403         don't get a mistmatch when comparing the original URI stored in
3404         the test class with the one returned by the WebKitWebView.
3405
3406         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3407         (testWebContextURIScheme): Update the test.
3408
3409 2014-04-01  Mihai Tica  <mitica@adobe.com>
3410
3411         Unreviewed: Add myself as a commiter to the contributors list.
3412
3413         * Scripts/webkitpy/common/config/contributors.json:
3414
3415 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3416
3417         [EFL][WK2] Extract the control of page background out of color_set
3418         https://bugs.webkit.org/show_bug.cgi?id=127539
3419
3420         Reviewed by Gyuyoung Kim.
3421
3422         Added an option(C) to change background color.
3423
3424         * MiniBrowser/efl/main.c:
3425         (window_create):
3426         (elm_main):
3427
3428 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3429
3430         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3431
3432         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3433
3434 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3435
3436         Unreviewed test correction after r166530.
3437
3438         * DumpRenderTree/mac/DumpRenderTree.mm:
3439         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3440         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3441
3442 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3443
3444         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3445         https://bugs.webkit.org/show_bug.cgi?id=130987
3446
3447         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3448         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3449
3450         Reviewed by Martin Robinson.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/config.json:
3453
3454 2014-03-31  Dean Jackson  <dino@apple.com>
3455
3456         Remove WEB_ANIMATIONS
3457         https://bugs.webkit.org/show_bug.cgi?id=130989
3458
3459         Reviewed by Simon Fraser.
3460
3461         Remove this feature flag until we plan to implement.
3462
3463         * Scripts/webkitperl/FeatureList.pm:
3464
3465 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3466
3467         Reduced Latched Scroll Test Flakiness
3468         https://bugs.webkit.org/show_bug.cgi?id=130983
3469
3470         Reviewed by Darin Adler.
3471
3472         * DumpRenderTree/mac/DumpRenderTree.mm:
3473         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3474         * DumpRenderTree/mac/EventSendingController.mm:
3475         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3476         with high resolution flags turned on.
3477         * WebKitTestRunner/mac/EventSenderProxy.mm:
3478         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3479
3480 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3481
3482         run-webkit-tests should have a --no-timeout option
3483         https://bugs.webkit.org/show_bug.cgi?id=128286
3484
3485         Reviewed by Joseph Pecoraro.
3486
3487         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3488         (Worker._run_test): Renaming _run_test_with_timeout()
3489         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3490         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3491         (Worker._run_test_in_this_thread):
3492         (Worker._run_test_with_timeout): Deleted.
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3494         (parse_args): Added the --no-timeout option
3495
3496 2014-03-31  Samuel White  <samuel_white@apple.com>
3497
3498         AX: Need ability to get line range for text marker.
3499         https://bugs.webkit.org/show_bug.cgi?id=130906
3500
3501         Reviewed by Chris Fleizach.
3502
3503         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3504
3505         * DumpRenderTree/AccessibilityUIElement.cpp:
3506         (lineTextMarkerRangeForTextMarkerCallback):
3507         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3508         (AccessibilityUIElement::getJSClass):
3509         * DumpRenderTree/AccessibilityUIElement.h:
3510         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3511         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3512         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3513         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3514         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3515         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3517         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3518         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3519         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3521         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3522
3523 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3524
3525         More validation for FTL inline caches
3526         https://bugs.webkit.org/show_bug.cgi?id=130948
3527
3528         Reviewed by Geoffrey Garen.
3529
3530         * Scripts/run-jsc-stress-tests:
3531
3532 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         [GTK] Do not run WebKit1 unit tests by default
3535         https://bugs.webkit.org/show_bug.cgi?id=130968
3536
3537         Reviewed by Martin Robinson.
3538
3539         * Scripts/run-gtk-tests:
3540         (TestRunner):
3541
3542 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3543
3544         [GTK] Remove scripts code only applicable to autotools
3545         https://bugs.webkit.org/show_bug.cgi?id=130841
3546
3547         Reviewed by Anders Carlsson.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3550         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3551         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3552         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3553         * gtk/find-make-dist-errors: Removed.
3554         * gtk/generate-feature-defines-files: Removed.
3555         * gtk/manifest.txt: No longer need to consider autotools files.
3556
3557 2014-03-30  Andy Estes  <aestes@apple.com>
3558
3559         Fix two failing layout tests on Mountain Lion after r166466.
3560
3561         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3562         (-[DownloadDelegate _downloadDidStart:]):
3563
3564 2014-03-30  Andy Estes  <aestes@apple.com>
3565
3566         [Cocoa] Add an originatingWebView property to _WKDownload
3567         https://bugs.webkit.org/show_bug.cgi?id=130945
3568
3569         Reviewed by Anders Carlsson.
3570
3571         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3572         (-[DownloadDelegate _downloadDidStart:]):
3573         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3574         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3575         (TEST):
3576
3577 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3578
3579         Land the stackmap register liveness glue with the uses of the liveness disabled
3580         https://bugs.webkit.org/show_bug.cgi?id=130924
3581
3582         Reviewed by Oliver Hunt.
3583
3584         * Scripts/run-jsc-stress-tests:
3585
3586 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3587
3588         Update WebKit1.StringTruncator for Mountain Lion.
3589
3590         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3591         due to different font metrics on 10.8.
3592
3593 2014-03-28  Darin Adler  <darin@apple.com>
3594
3595         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3596         https://bugs.webkit.org/show_bug.cgi?id=130889
3597
3598         Reviewed by Alexey Proskuryakov.
3599
3600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3601         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3602         WebStringTruncator methods; should be good for a start. These are dependent on the
3603         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3604
3605 2014-03-28  Martin Hock  <mhock@apple.com>
3606
3607         Unreviewed. Add myself as a committer.
3608
3609         * Scripts/webkitpy/common/config/contributors.json:
3610
3611 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3612
3613         Remove WebKit1 GTK+ bots
3614         https://bugs.webkit.org/show_bug.cgi?id=130904
3615
3616         Reviewed by Anders Carlsson.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3619         all bots are testing WebKit2 only.
3620         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3621         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3622         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3623         * Scripts/webkitpy/port/builders.py: Ditto.
3624         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3625         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3626
3627 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3628
3629         Remove Brian Burg's apple.com email address.
3630
3631         * Scripts/webkitpy/common/config/contributors.json:
3632
3633 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3634
3635         bisect-builds should print Trac 'changeset' URL if only one build is detected
3636         <http://webkit.org/b/130903>
3637
3638         Reviewed by Dan Bernstein.
3639
3640         * Scripts/bisect-builds:
3641         (printTracLink): Print a direct link to the Trac 'changeset'
3642         URL if there is only one revision in the range.
3643
3644 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3645
3646         [EFL] Bump glib version from 2.36 to 2.38 
3647         https://bugs.webkit.org/show_bug.cgi?id=130886
3648
3649         Reviewed by Csaba Osztrogonác.
3650
3651         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3652         we need to bump glib version up to 2.38 as gtk port.
3653
3654         * efl/jhbuild.modules:
3655
3656 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3657
3658         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3659
3660         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3661         the globalhistory directory.
3662
3663         Reviewed by Sam Weinig.
3664
3665         * WebKitTestRunner/TestController.cpp:
3666         (WTR::TestController::TestController):
3667         (WTR::TestController::initialize): Set the history client.
3668         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3669         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3670         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3671         and we don't yet have API to access the data in question.
3672         (WTR::TestController::didPerformClientRedirect):
3673         (WTR::TestController::didPerformServerRedirect):
3674         (WTR::TestController::didUpdateHistoryTitle):
3675         * WebKitTestRunner/TestController.h:
3676         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3677         * WebKitTestRunner/TestInvocation.cpp:
3678         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3679         (WTR::TestInvocation::invoke):
3680
3681 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3682
3683         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
3684
3685         * Scripts/build-webkit:
3686         * Scripts/copy-webkitlibraries-to-product-directory:
3687
3688 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3689
3690         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3691         https://bugs.webkit.org/show_bug.cgi?id=130867
3692         <rdar://problem/16432456> 
3693
3694         Reviewed by Mark Hahnenberg.
3695
3696         * Scripts/build-webkit:
3697         * Scripts/copy-webkitlibraries-to-product-directory:
3698
3699 2014-03-26  Andy Estes  <aestes@apple.com>
3700
3701         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3702         https://bugs.webkit.org/show_bug.cgi?id=130805
3703
3704         Reviewed by Dan Bernstein.
3705
3706         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3707         (-[DownloadDelegate _download:didReceiveResponse:]):
3708         (-[DownloadDelegate _downloadDidFinish:]):
3709         (runTest):
3710         (TEST):
3711         (-[FailingDownloadDelegate _downloadDidFinish:]):
3712         (-[FailingDownloadDelegate _download:didFailWithError:]):
3713         (-[FailingDownloadDelegate _downloadDidCancel:]):
3714         (-[CancelledDownloadDelegate _downloadDidStart:]):
3715         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3716         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3717         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3718         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3719         (-[DownloadDelegate sourceURL]): Deleted.
3720         (runTestWithNavigationDelegate): Deleted.
3721
3722 2014-03-26  Anders Carlsson  <andersca@apple.com>
3723
3724         Change MiniBrowser to hold on to window controllers instead of windows
3725         https://bugs.webkit.org/show_bug.cgi?id=130797
3726
3727         Reviewed by Oliver Hunt.
3728
3729         * MiniBrowser/mac/AppDelegate.h:
3730         * MiniBrowser/mac/AppDelegate.m:
3731         (-[BrowserAppDelegate init]):
3732         (-[BrowserAppDelegate newWindow:]):
3733         (-[BrowserAppDelegate browserWindowWillClose:]):
3734         (-[BrowserAppDelegate applicationWillTerminate:]):
3735         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3736
3737 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3738
3739         Unreviewed, rolling out r166264.
3740         https://bugs.webkit.org/show_bug.cgi?id=130785
3741
3742         Broke some window.opener tests for WK2 Mavericks (Requested by
3743         brrian__ on #webkit).
3744
3745         Reverted changeset:
3746
3747         "Web Replay: resource unique identifiers should be unique-per-
3748         frame, not globally"
3749         https://bugs.webkit.org/show_bug.cgi?id=130632
3750         http://trac.webkit.org/changeset/166264
3751
3752 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3753
3754         [CSS Shapes] Remove shape-inside support
3755         https://bugs.webkit.org/show_bug.cgi?id=130698
3756
3757         Reviewed by David Hyatt.
3758
3759         * Scripts/webkitperl/FeatureList.pm:
3760
3761 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3762
3763         Unreviewed. Add myself as a committer.
3764
3765         * Scripts/webkitpy/common/config/contributors.json:
3766
3767 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3768
3769         run-launcher is Perl script so use elsif and not elif
3770         https://bugs.webkit.org/show_bug.cgi?id=130771
3771
3772         Reviewed by Carlos Garcia Campos.
3773
3774         * Scripts/run-launcher:
3775
3776 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3777
3778         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3779         https://bugs.webkit.org/show_bug.cgi?id=130575
3780
3781         Reviewed by Mario Sanchez Prada.
3782
3783         Change ATK version to 2.11.92. Adjust current implementation.
3784
3785         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3786         (AccessibilityUIElement::intValue):
3787         (AccessibilityUIElement::minValue):
3788         (AccessibilityUIElement::maxValue):
3789         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3790         (WTR::AccessibilityUIElement::intValue):
3791         (WTR::AccessibilityUIElement::minValue):
3792         (WTR::AccessibilityUIElement::maxValue):
3793         * efl/jhbuild.modules:
3794         * gtk/jhbuild.modules:
3795
3796 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3797
3798         [GTK] The gnumake package is no longer needed in jhbuild
3799         https://bugs.webkit.org/show_bug.cgi?id=130121
3800
3801         Reviewed by Martin Robinson.
3802
3803         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3804         for a debug build cmake/system-gnumake worked just fine for me.
3805
3806         * gtk/jhbuild.modules: Removed gnumake.
3807         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3808         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3809
3810 2014-03-25  Andy Estes  <aestes@apple.com>
3811
3812         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3813
3814         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3815         (-[DownloadDelegate _download:didReceiveData:]):
3816         (-[DownloadDelegate _downloadDidFinish:]):
3817
3818 2014-03-25  Brian Burg  <bburg@apple.com>
3819
3820         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3821         https://bugs.webkit.org/show_bug.cgi?id=130623
3822
3823         Reviewed by Timothy Hatcher.
3824
3825         The resource loader callback dumping routines assumed that resource identifiers
3826         were globally unique. Its map of resource identifiers to URLs must also track the
3827         frame associated with the resource.
3828
3829         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3830         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3831         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3832         stable as long as the frame is valid.
3833         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3834         (WTR::InjectedBundlePage::willSendRequestForFrame):
3835         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3836         (WTR::InjectedBundlePage::didFinishLoadForResource):
3837         (WTR::InjectedBundlePage::didFailLoadForResource):
3838
3839 2014-03-25  Andy Estes  <aestes@apple.com>
3840
3841         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3842
3843         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3844         (-[DownloadDelegate _download:didReceiveResponse:]):
3845         (-[DownloadDelegate _download:didReceiveData:]):
3846
3847 2014-03-25  Andy Estes  <aestes@apple.com>
3848
3849         Add some debug logging to an API test that's failing on Mountain Lion.
3850
3851         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3852         (-[DownloadDelegate _download:didReceiveResponse:]):
3853         (-[DownloadDelegate _downloadDidFinish:]):
3854
3855 2014-03-25  Anders Carlsson  <andersca@apple.com>
3856
3857         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3858         https://bugs.webkit.org/show_bug.cgi?id=130732
3859
3860         Reviewed by Tim Horton.
3861
3862         * MiniBrowser/mac/WK2BrowserWindowController.m:
3863         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3864
3865 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3866
3867         [GTK] Remove the autotools build
3868         https://bugs.webkit.org/show_bug.cgi?id=130717
3869
3870         Reviewed by Anders Carlsson.
3871
3872         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3873         * GNUmakefile.am: Removed.
3874         * GtkLauncher/GNUmakefile.am: Removed.
3875         * GtkLauncher/main.c: Remove references to the autotools configure file.
3876         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3877         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3878         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3879         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3880         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3881         * Scripts/build-webkit: No longer handle autotools.
3882         * Scripts/run-gtk-tests: Ditto.
3883         (TestRunner._setup_testing_environment):
3884         * Scripts/run-launcher: Ditto.
3885         * Scripts/webkitdirs.pm: Ditto.
3886         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3887         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3888         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3889         * Scripts/webkitpy/style/checker.py:
3890         * TestWebKitAPI/GNUmakefile.am: Removed.
3891         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3892         * WebKitTestRunner/GNUmakefile.am: Removed.
3893         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3894         * gtk/GNUmakefile.am: Removed.
3895         * gtk/common.py: Remove checks for the autotools build.
3896         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3897
3898 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3899
3900         prepare-ChangeLog throws false positive warnings for modified files.
3901         https://bugs.webkit.org/show_bug.cgi?id=130687
3902
3903         Reviewed by Darin Adler.
3904
3905         * Scripts/prepare-ChangeLog:
3906         (originalFile): Ignore git commit paremeter.
3907         We don't need this to get the unmodified file.
3908         (extractLineRangeBeforeChange):
3909         Simplify the if statement. Follow-up after r166189.
3910
3911 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3912
3913         [EFL] Add ARM64 build support
3914         https://bugs.webkit.org/show_bug.cgi?id=130506
3915
3916         Rubber stamped by Gyuyoung Kim.
3917
3918         * Scripts/webkitdirs.pm:
3919         (isARM): Detect aarch64 as ARM.
3920
3921 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3922
3923         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3924         https://bugs.webkit.org/show_bug.cgi?id=130137
3925
3926         Reviewed by Csaba Osztrogonác.
3927
3928         * Scripts/webkitpy/common/checkout/changelog.py:
3929         (ChangeLogEntry._parse_bug_description):
3930         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3931         (test_parse_log_entries_from_changelog):
3932         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3933         (CheckoutTest.test_commit_info_for_revision):
3934
3935 2014-03-24  Andy Estes  <aestes@apple.com>
3936
3937         Fix the iOS build of TestWebKitAPI.
3938
3939         * TestWebKitAPI/Configurations/Base.xcconfig:
3940         * TestWebKitAPI/PlatformUtilities.h:
3941
3942 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3943
3944         Fix prepare-ChangeLog after r166156.
3945         https://bugs.webkit.org/show_bug.cgi?id=130674
3946
3947         Reviewed by Darin Adler.
3948
3949         * Scripts/prepare-ChangeLog:
3950         (generateFunctionLists):
3951         (extractLineRangeBeforeChange):
3952
3953 2014-03-24  Andy Estes  <aestes@apple.com>
3954
3955         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3956         https://bugs.webkit.org/show_bug.cgi?id=129322
3957
3958         Reviewed by Anders Carlsson.
3959
3960         Add an API test suite for _WKDownload.
3961
3962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3963         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3964         (-[DownloadDelegate initWithSourceURL:]):
3965         (-[DownloadDelegate sourceURL]):
3966         (-[DownloadDelegate _downloadDidStart:]):
3967         (-[DownloadDelegate _download:didReceiveResponse:]):
3968         (-[DownloadDelegate _download:didReceiveData:]):
3969         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3970         (-[DownloadDelegate _downloadDidFinish:]):
3971         (TEST):
3972         (runTestWithNavigationDelegate):
3973         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3974         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3975
3976 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3977
3978         filter-build-webkit: reduce unfiltered output
3979         https://bugs.webkit.org/show_bug.cgi?id=130485
3980
3981         Reviewed by Brent Fulgham.
3982
3983         * Scripts/filter-build-webkit:
3984         (shouldIgnoreLine):
3985
3986 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3987
3988         prepare-ChangeLog should list functions that have been removed too.
3989         https://bugs.webkit.org/show_bug.cgi?id=130508
3990
3991         Reviewed by Darin Adler.
3992
3993         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3994         We have to read the functions and the line ranges of them from the source
3995         before the change, then search for overlaps between them and the changed
3996         line ranges from diff.
3997
3998         * Scripts/prepare-ChangeLog:
3999         (originalFile): Get original source command.
4000         (generateFunctionLists): Collect deleted functions too.
4001         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
4002         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
4003         deleted functions ranges too.
4004         (extractLineRange): Renamed to extractLineRangeAfterChange.
4005
4006 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
4007
4008         Move all EFL typedefs into EflTypedefs.h.
4009         https://bugs.webkit.org/show_bug.cgi?id=130511
4010
4011         Reviewed by Gyuyoung Kim.
4012
4013         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
4014         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
4015         * WebKitTestRunner/PlatformWebView.h: Ditto.
4016
4017 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
4018
4019         Don't flush compositing layers within FrameView::willPaintContents()
4020         https://bugs.webkit.org/show_bug.cgi?id=130627
4021         <rdar://problem/16368869>
4022
4023         Reviewed by Sam Weinig.
4024         
4025         Fix DRT to correctly render tests with layers now that FrameView::paintContents
4026         does not flush.
4027         
4028         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
4029         into an explicit function called before dumping. 
4030         
4031         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
4032         are flushed to CA. They will be pushed to the window by snapshotting.
4033
4034         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4035         Fix weird path to IOKit.framework.
4036         * DumpRenderTree/mac/DumpRenderTree.mm:
4037         (updateDisplay):
4038         (dump):
4039         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4040         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
4041         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
4042
4043 2014-03-21  David Kilzer  <ddkilzer@apple.com>
4044
4045         fix-blink-patch: tool to fix up renamed directory paths in Blink
4046         <http://webkit.org/b/130609>
4047
4048         Reviewed by Ryosuke Niwa.
4049
4050         Usage: cat blink.patch | fix-blink-patch | svn-apply
4051
4052         * Scripts/fix-blink-patch: Added.
4053
4054 2014-03-21  Darin Adler  <darin@apple.com>
4055
4056         Remove use of deprecatedCharacters in WebKit API tests
4057         https://bugs.webkit.org/show_bug.cgi?id=130602
4058
4059         Reviewed by Antti Koivisto.
4060
4061         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4062         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
4063         (TestWebKitAPI::expectEmpty): Use characters8.
4064         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
4065
4066         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4067         Removed the test that is entirely about 16-bit conversion since that's basically a test of
4068         the deprecatedCharacters function itself, which we are about to delete.
4069
4070 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4071
4072         [webkitpy] Fix has_valid_reviewer()
4073         https://bugs.webkit.org/show_bug.cgi?id=130589
4074
4075         Reviewed by Csaba Osztrogonác.
4076
4077         * Scripts/webkitpy/common/checkout/changelog.py:
4078         (ChangeLogEntry.has_valid_reviewer):
4079         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4080         (test_has_valid_reviewer):
4081         * Scripts/webkitpy/common/config/committers.py:
4082         (CommitterList._reviewer_only):
4083         (CommitterList.committer_by_name):
4084         (CommitterList.reviewer_by_email):
4085         (CommitterList):
4086         (CommitterList.reviewer_by_name):
4087
4088 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4089
4090         Add cache support for jhbuild
4091         https://bugs.webkit.org/show_bug.cgi?id=130588
4092
4093         Reviewed by Csaba Osztrogonác.
4094
4095         * jhbuild/jhbuildrc_common.py:
4096         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
4097
4098 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4099
4100         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
4101         https://bugs.webkit.org/show_bug.cgi?id=130504
4102
4103         Reviewed by Martin Robinson.
4104
4105         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
4106         CMake if not specified.
4107         * Scripts/webkitdirs.pm:
4108         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
4109         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
4110
4111 2014-03-21  Andreas Kling  <akling@apple.com>
4112
4113         RetainPtr API test should use CFArray instead of CFString for testing.
4114         <rdar://problem/16384899>
4115
4116         Unreviewed bot fix.
4117
4118         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4119         (TestWebKitAPI::TEST):
4120         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4121         (TestWebKitAPI::TEST):
4122
4123 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
4124
4125         Move to using std::unique_ptr for EFL objects.
4126         https://bugs.webkit.org/show_bug.cgi?id=129853
4127
4128         Reviewed by Gyuyoung Kim.
4129
4130         EflUniquePtr is a template alias of std::unique_ptr
4131         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
4132         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
4133
4134         * DumpRenderTree/efl/DumpRenderTree.cpp:
4135         (main):
4136         * ImageDiff/efl/ImageDiff.cpp:
4137         (initEfl):
4138         (main):
4139
4140 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
4141
4142         Unreviewed buildfix after r165983 for non Cocoa platforms
4143
4144         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
4145
4146         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
4147         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4148         * WebKitTestRunner/TestController.cpp:
4149
4150 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
4151
4152         [GTK][CMake] Add support for building with Clang
4153         https://bugs.webkit.org/show_bug.cgi?id=130260
4154
4155         Reviewed by Martin Robinson.
4156
4157         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
4158         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
4159         included GTest framework headers.
4160         * gtk/generate-gtkdoc:
4161         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
4162         in case of using Clang since that is now set by the CMake rule.
4163
4164 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
4165
4166         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4167         https://bugs.webkit.org/show_bug.cgi?id=130476
4168
4169         Reviewed by Anders Carlsson.
4170         
4171         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
4172
4173         * MiniBrowser/mac/WK1BrowserWindowController.m:
4174         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4175         Remove log.
4176         * MiniBrowser/mac/WK2BrowserWindowController.m:
4177         (-[WK2BrowserWindowController awakeFromNib]):
4178         (-[WK2BrowserWindowController validateMenuItem:]):
4179         (-[WK2BrowserWindowController reload:]):
4180         Hook up reload.
4181         (-[WK2BrowserWindowController toggleZoomMode:]):
4182         (-[WK2BrowserWindowController resetZoom:]):
4183         (-[WK2BrowserWindowController canResetZoom]):
4184         (-[WK2BrowserWindowController currentZoomFactor]):
4185         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
4186         (-[WK2BrowserWindowController canZoomIn]):
4187         (-[WK2BrowserWindowController canZoomOut]):
4188
4189 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
4190
4191         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
4192         https://bugs.webkit.org/show_bug.cgi?id=130463
4193
4194         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
4195
4196 2014-03-18  Samuel White  <samuel_white@apple.com>
4197
4198         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
4199         https://bugs.webkit.org/show_bug.cgi?id=130250
4200
4201         Reviewed by Chris Fleizach.
4202
4203         Added ability to toggle enhanced accessibility on and off to support tests that require it.
4204
4205         * DumpRenderTree/AccessibilityController.cpp:
4206         (enableEnhancedAccessibilityCallback):
4207         (getEnhancedAccessibilityEnabledCallback):
4208         (AccessibilityController::getJSClass):
4209         * DumpRenderTree/AccessibilityController.h:
4210         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4211         (AccessibilityController::enableEnhancedAccessibility):
4212         (AccessibilityController::enhancedAccessibilityEnabled):
4213         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
4214         (AccessibilityController::enableEnhancedAccessibility):
4215         (AccessibilityController::enhancedAccessibilityEnabled):
4216         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4217         (AccessibilityController::enableEnhancedAccessibility):
4218         (AccessibilityController::enhancedAccessibilityEnabled):
4219         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4220         (AccessibilityController::enableEnhancedAccessibility):
4221         (AccessibilityController::enhancedAccessibilityEnabled):
4222         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4223         (WTR::AccessibilityController::enableEnhancedAccessibility):
4224         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
4225         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4227
4228 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
4229
4230         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
4231         yet).
4232
4233         * Scripts/webkitpy/common/config/contributors.json:
4234
4235 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
4236
4237         Web Inspector: Remove stale ReportMemoryUsagePlugin
4238         https://bugs.webkit.org/show_bug.cgi?id=130405
4239
4240         Reviewed by Andreas Kling.
4241
4242         This clang plugin looks like it was used for the old Inspector memory
4243         instrumentation that was removed. So the tool can be removed.
4244
4245         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
4246         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
4247         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
4248         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
4249
4250 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4251
4252         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
4253         https://bugs.webkit.org/show_bug.cgi?id=130220
4254
4255         Reviewed by Csaba Osztrogonác.
4256
4257         * Scripts/webkitpy/common/checkout/changelog.py:
4258         (ChangeLog.set_reviewer):
4259         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4260         (test_set_reviewer):
4261
4262 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
4263
4264         More FTL enabling.
4265
4266         Rubber stamped by Dan Bernstein.
4267
4268         * Tools/Scripts/build-webkit:
4269
4270 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4271
4272         Renable pagination mode in WK2 MiniBrowser
4273         https://bugs.webkit.org/show_bug.cgi?id=130374
4274
4275         Reviewed by Anders Carlsson.
4276         
4277         Put the implementation of togglePaginationMode: back, and correctly
4278         enable the menu item.
4279
4280         * MiniBrowser/mac/WK2BrowserWindowController.m:
4281         (-[WK2BrowserWindowController validateMenuItem:]):
4282         (-[WK2BrowserWindowController isPaginated]):
4283         (-[WK2BrowserWindowController togglePaginationMode:]):
4284
4285 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4286
4287         Add --reset option to Tools/Scripts/set-webkit-configuration script
4288         https://bugs.webkit.org/show_bug.cgi?id=130401
4289
4290         Reviewed by Csaba Osztrogonác.
4291
4292         * Scripts/set-webkit-configuration:
4293
4294 2014-03-18  Alberto Garcia  <berto@igalia.com>
4295
4296         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
4297         https://bugs.webkit.org/show_bug.cgi?id=130388
4298
4299         Reviewed by Sergio Villar Senin.
4300
4301         * Scripts/webkitdirs.pm:
4302         (shouldRemoveCMakeCache): make sure that the build directory
4303         exists before attempting to create a file in it.
4304
4305 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
4306
4307         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
4308         https://bugs.webkit.org/show_bug.cgi?id=130336
4309
4310         Reviewed by Gyuyoung Kim.
4311
4312         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
4313         requires a space between literal and string macro [-Wliteral-suffix]'
4314         warning treated as error.