[Xcode] Add SDKVariant.xcconfig to various Xcode projects
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-20  Andy Estes  <aestes@apple.com>
2
3         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4         https://bugs.webkit.org/show_bug.cgi?id=194869
5
6         Rubber-stamped by Jer Noble.
7
8         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
10         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
11         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
14
15 2019-02-20  Chris Dumez  <cdumez@apple.com>
16
17         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
18         https://bugs.webkit.org/show_bug.cgi?id=194857
19         <rdar://problem/47759323>
20
21         Reviewed by Alex Christensen.
22
23         Add API test coverage.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
26
27 2019-02-20  Chris Dumez  <cdumez@apple.com>
28
29         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
30         https://bugs.webkit.org/show_bug.cgi?id=194829
31         <rdar://problem/47889906>
32
33         Reviewed by Alexey Proskuryakov.
34
35         Every time the TestOptions were changing we were creating both a new Web view and
36         a new WKContext, which would start a new Network process. In most cases, we only
37         need to contruct a new Web view and we do can keep reusing the same WKContext.
38         This patch implements this optimization and thus avoids spinning a lot of new
39         Network processes while running the layout tests.
40
41         * WebKitTestRunner/TestController.cpp:
42         (WTR::TestController::generateContextConfiguration const):
43         (WTR::TestController::generatePageConfiguration):
44         (WTR::TestController::createWebViewWithOptions):
45         (WTR::TestController::resetPreferencesToConsistentValues):
46         (WTR::updateTestOptionsFromTestHeader):
47         * WebKitTestRunner/TestController.h:
48         * WebKitTestRunner/TestOptions.h:
49         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
50         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
51         (WTR::TestOptions::hasSameInitializationOptions const):
52         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
53         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
54         (WTR::TestController::platformAddTestOptions const):
55
56 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
57
58         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
59         https://bugs.webkit.org/show_bug.cgi?id=167941
60
61         Reviewed by Carlos Garcia Campos.
62
63         * MiniBrowser/gtk/main.c:
64         (filterSavedCallback): Added.
65         (main): Support loading a JSON rule set file for content filtering.
66         * MiniBrowser/wpe/main.cpp:
67         (filterSavedCallback): Added.
68         (main): Support loading a JSON rule set file for content filtering.
69         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
70         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
71         (WTF::derefGPtr): Ditto.
72         (testEmptyStore):
73         (testSaveInvalidFilter):
74         (testSaveLoadFilter):
75         (testSavedFilterIdentifierMatch):
76         (testRemoveFilter):
77         (testSaveMultipleFilters):
78         (testSaveFilterFromFile):
79         (testFilterPersistence):
80         (beforeAll):
81         (afterAll):
82         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
83         (removeOldInjectedContentAndResetLists): Also reset content filters.
84         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
85         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
86         the element affected by the style sheet.
87         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
88         and returns it to be used by tests.
89         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
90         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
91         (serverCallback): Add support for serving a CSS style sheet for testing.
92         (beforeAll): Add call to testUserContentManagerContentFilter().
93         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
94
95 2019-02-19  Keith Rollin  <krollin@apple.com>
96
97         Add timing information to build output
98         https://bugs.webkit.org/show_bug.cgi?id=194839
99         <rdar://problem/48219609>
100
101         Reviewed by Alexey Proskuryakov.
102
103         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
104         emit each project's build time to its output. E.g.,
105
106             ** BUILD SUCCEEDED ** [0.132 sec]
107
108         * Scripts/webkitdirs.pm:
109         (XcodeOptions):
110
111 2019-02-19  Truitt Savell  <tsavell@apple.com>
112
113         Unreviewed, rolling out r241784.
114
115         Broke all OpenSource builds.
116
117         Reverted changeset:
118
119         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
120         instances view"
121         https://bugs.webkit.org/show_bug.cgi?id=172848
122         https://trac.webkit.org/changeset/241784
123
124 2019-02-19  Zalan Bujtas  <zalan@apple.com>
125
126         [LFC][Floats] Remove redundant intersecting logic
127         https://bugs.webkit.org/show_bug.cgi?id=194804
128
129         Reviewed by Antti Koivisto.
130
131         * LayoutReloaded/misc/LFC-passing-tests.txt:
132
133 2019-02-19  Dean Jackson  <dino@apple.com>
134
135         Clean-up output from generate-xcfilelists so it can be filtered
136         https://bugs.webkit.org/show_bug.cgi?id=194795
137
138         Reviewed by Joseph Pecoraro (and Keith Rollin).
139
140         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
141         make a slight tweak to filter-build-webkit so such lines are marked
142         as plain.
143
144         * Scripts/filter-build-webkit:
145         * Scripts/generate-xcfilelists:
146
147 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
148
149         pytest is not correctly auto-installed
150         https://bugs.webkit.org/show_bug.cgi?id=194707
151
152         Reviewed by Carlos Garcia Campos.
153
154         * Scripts/webkitpy/thirdparty/__init__.py:
155         (AutoinstallImportHook._install_pytest):
156
157 2019-02-18  Chris Dumez  <cdumez@apple.com>
158
159         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
160         https://bugs.webkit.org/show_bug.cgi?id=194797
161         <rdar://problem/48055151>
162
163         Reviewed by Geoffrey Garen.
164
165         Add API test coverage.
166
167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
168
169 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
170
171         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
172         https://bugs.webkit.org/show_bug.cgi?id=194670
173         <rdar://problem/39066529>
174
175         Reviewed by Tim Horton.
176
177         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
178         pasted in an editable area as attachment elements.
179
180         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
181         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
182         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
183         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
184         (TestWebKitAPI::TEST):
185         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
186         (WTR::InjectedBundlePage::InjectedBundlePage):
187
188 2019-02-18  Alex Christensen  <achristensen@webkit.org>
189
190         Fix API test after r241728
191        ​https://bugs.webkit.org/show_bug.cgi?id=194723
192
193         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
194         (TEST):
195         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
196
197 2019-02-18  Daniel Bates  <dabates@apple.com>
198
199         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
200         https://bugs.webkit.org/show_bug.cgi?id=192824
201         <rdar://problem/47100332>
202
203         Reviewed by Wenson Hsieh.
204
205         Fix a bug where the wrong usage code was used for F13 thru F24.
206
207         * WebKitTestRunner/ios/HIDEventGenerator.mm:
208         (keyCodeForDOMFunctionKey):
209
210 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
211
212         Bytecode cache should a have a boot-specific validation
213         https://bugs.webkit.org/show_bug.cgi?id=194769
214         <rdar://problem/48149509>
215
216         Reviewed by Keith Miller.
217
218         Add test for WTF::bootSessionUUIDString()
219
220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
221         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
222         (TEST):
223
224 2019-02-18  Alex Christensen  <achristensen@webkit.org>
225
226         Disable safe browsing in WKWebView and remove its WKPreferences API
227         https://bugs.webkit.org/show_bug.cgi?id=194723
228         <rdar://problem/48122993>
229
230         Reviewed by Geoffrey Garen.
231
232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
233         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
234         (TEST):
235         (safeBrowsingView):
236         Make tests use SPI instead of API.
237
238 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
239
240         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
241         https://bugs.webkit.org/show_bug.cgi?id=194586
242
243         Reviewed by Ross Kirsling.
244
245         * DumpRenderTree/win/DumpRenderTree.cpp:
246         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
247         * Scripts/webkitpy/port/driver.py:
248         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
249
250 2019-02-17  David Kilzer  <ddkilzer@apple.com>
251
252         Unreviewed, rolling out r241620.
253
254         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
255         (Requested by ddkilzer on #webkit.)
256
257         Reverted changeset:
258
259         "[WTF] Add environment variable helpers"
260         https://bugs.webkit.org/show_bug.cgi?id=192405
261         https://trac.webkit.org/changeset/241620
262
263 2019-02-16  Zalan Bujtas  <zalan@apple.com>
264
265         [LFC] RenderImage's default intrinsic size is 0.
266         https://bugs.webkit.org/show_bug.cgi?id=194745
267
268         Reviewed by Antti Koivisto.
269
270         * LayoutReloaded/misc/LFC-passing-tests.txt:
271
272 2019-02-16  Zalan Bujtas  <zalan@apple.com>
273
274         [LFC][BFC] Add support for block replaced intrinsic width.
275         https://bugs.webkit.org/show_bug.cgi?id=194705
276
277         Reviewed by Simon Fraser.
278
279         * LayoutReloaded/misc/LFC-passing-tests.txt:
280
281 2019-02-16  Zalan Bujtas  <zalan@apple.com>
282
283         [LFC] Apply min/max width constraints to preferred width computation
284         https://bugs.webkit.org/show_bug.cgi?id=194739
285
286         Reviewed by Simon Fraser.
287
288         * LayoutReloaded/misc/LFC-passing-tests.txt:
289
290 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
291
292         [WTF] Add environment variable helpers
293         https://bugs.webkit.org/show_bug.cgi?id=192405
294
295         Reviewed by Michael Catanzaro.
296
297         * DumpRenderTree/mac/DumpRenderTree.mm:
298         (libraryPathForDumpRenderTree):
299         * DumpRenderTree/win/DumpRenderTree.cpp:
300         (libraryPathForDumpRenderTree):
301         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
302         (setUpIOSLayoutTestCommunication):
303         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
304         (beforeAll):
305         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
306         (main):
307         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
308         (WebKitTestBus::run):
309         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
310         (WTR::getOutputDir):
311         (WTR::initializeFontConfigSetting):
312         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
313         (WTR::InjectedBundle::platformInitialize):
314         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
315         (WTR::topLevelPath):
316         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
317         (WTR::topLevelPath):
318         (WTR::getOutputDir):
319         (WTR::activateFonts):
320         * WebKitTestRunner/TestController.cpp:
321         (WTR::TestController::libraryPathForTesting):
322         (WTR::TestController::generateContextConfiguration const):
323         (WTR::TestController::generatePageConfiguration):
324         (WTR::TestController::decideDestinationWithSuggestedFilename):
325         (WTR::TestController::platformAdjustContext):
326         * WebKitTestRunner/TestController.h:
327         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
328         (WTR::TestController::cocoaPlatformInitialize):
329         (WTR::TestController::platformAdjustContext):
330         * WebKitTestRunner/gtk/main.cpp:
331         (main):
332         * WebKitTestRunner/mac/TestControllerMac.mm:
333         (WTR::TestController::configureContentExtensionForTest):
334         * WebKitTestRunner/wpe/main.cpp:
335         (main):
336         Utilize WTF::Environment where possible.
337
338 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
339
340         [iOS] WKWebView callout bar is missing Change Writing Direction item
341         https://bugs.webkit.org/show_bug.cgi?id=190015
342         <rdar://problem/44810366>
343
344         Reviewed by Tim Horton.
345
346         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
347         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
348
349         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
350         (TestWebKitAPI::TEST):
351
352 2019-02-15  Chris Dumez  <cdumez@apple.com>
353
354         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
355         https://bugs.webkit.org/show_bug.cgi?id=194717
356         <rdar://problem/47884404>
357
358         Reviewed by Brady Eidson.
359
360         Add API test coverage.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
363
364 2019-02-15  Youenn Fablet  <youenn@apple.com>
365
366         Make navigator.mediaDevices SecureContext
367         https://bugs.webkit.org/show_bug.cgi?id=194666
368
369         Reviewed by Eric Carlson.
370
371         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
372         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
373         (TEST_F):
374
375 2019-02-15  Brian Burg  <bburg@apple.com>
376
377         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
378         https://bugs.webkit.org/show_bug.cgi?id=194411
379         <rdar://problem/47787614>
380
381         Reviewed by Joseph Pecoraro.
382
383         Remove unnecessary soft linking macro usage.
384
385         * DumpRenderTree/mac/TestRunnerMac.mm:
386         (TestRunner::inspectorTestStubURL):
387         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
388         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
389         (WTR::TestRunner::inspectorTestStubURL):
390
391 2019-02-15  Commit Queue  <commit-queue@webkit.org>
392
393         Unreviewed, rolling out r241559 and r241566.
394         https://bugs.webkit.org/show_bug.cgi?id=194710
395
396         Causes layout test crashes under GuardMalloc (Requested by
397         ryanhaddad on #webkit).
398
399         Reverted changesets:
400
401         "[WTF] Add environment variable helpers"
402         https://bugs.webkit.org/show_bug.cgi?id=192405
403         https://trac.webkit.org/changeset/241559
404
405         "Unreviewed build fix for WinCairo Debug after r241559."
406         https://trac.webkit.org/changeset/241566
407
408 2019-02-15  Zalan Bujtas  <zalan@apple.com>
409
410         [LFC] Out-of-flow box is never a float box
411         https://bugs.webkit.org/show_bug.cgi?id=194704
412
413         Reviewed by Antti Koivisto.
414
415         * LayoutReloaded/misc/LFC-passing-tests.txt:
416
417 2019-02-10  Darin Adler  <darin@apple.com>
418
419         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
420         https://bugs.webkit.org/show_bug.cgi?id=194487
421
422         Reviewed by Daniel Bates.
423
424         * DumpRenderTree/win/DumpRenderTree.cpp:
425         (applicationId): Use makeString instead of String::format.
426         (main): Ditto.
427         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
428         (TestWebKitAPI::Util::createURLForResource): Ditto.
429         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
430         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
431
432         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
433         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
434         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
435         (WTR::createStringWithAttributes): Use appendLiteral.
436         (WTR::AccessibilityUIElement::helpText const): Ditto.
437         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
438         directly instead of using String::format.
439         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
440         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
441
442 2019-02-15  Truitt Savell  <tsavell@apple.com>
443
444         Unreviewed, rolling out r241564.
445
446         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
447
448         Reverted changeset:
449
450         "[Mac] WebInspectorUI.framework does not need to be soft-
451         linked anymore"
452         https://bugs.webkit.org/show_bug.cgi?id=194411
453         https://trac.webkit.org/changeset/241564
454
455 2019-02-15  Saam barati  <sbarati@apple.com>
456
457         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
458         https://bugs.webkit.org/show_bug.cgi?id=194036
459
460         Reviewed by Yusuke Suzuki.
461
462         * Scripts/run-jsc-stress-tests:
463
464 2019-02-14  Tim Horton  <timothy_horton@apple.com>
465
466         Fix the build.
467
468         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
469         (WTR::UIScriptController::drawSquareInEditableImage):
470         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
471         (TestWebKitAPI::drawSquareInEditableImage):
472
473 2019-02-14  Tim Horton  <timothy_horton@apple.com>
474
475         Fix the build.
476
477         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
478         (WTR::UIScriptController::drawSquareInEditableImage):
479         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
480         (TestWebKitAPI::drawSquareInEditableImage):
481
482 2019-02-14  Brian Burg  <bburg@apple.com>
483
484         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
485         https://bugs.webkit.org/show_bug.cgi?id=194411
486         <rdar://problem/47787614>
487
488         Reviewed by Joseph Pecoraro.
489
490         Remove unnecessary soft linking macro usage.
491
492         * DumpRenderTree/mac/TestRunnerMac.mm:
493         (TestRunner::inspectorTestStubURL):
494         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
495         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
496         (WTR::TestRunner::inspectorTestStubURL):
497
498 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
499
500         [ews-app] status bubble should fetch builder name info from BuilderMapping table
501         https://bugs.webkit.org/show_bug.cgi?id=194599
502
503         Reviewed by Lucas Forschler.
504
505         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
506         (StatusBubble._build_bubble):
507
508 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-app] Set Foreign Key in Django build model
511         https://bugs.webkit.org/show_bug.cgi?id=194667
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-app/ews/models/build.py:
516         (Build):
517
518 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
519
520         [WTF] Add environment variable helpers
521         https://bugs.webkit.org/show_bug.cgi?id=192405
522
523         Reviewed by Michael Catanzaro.
524
525         * DumpRenderTree/mac/DumpRenderTree.mm:
526         (libraryPathForDumpRenderTree):
527         * DumpRenderTree/win/DumpRenderTree.cpp:
528         (libraryPathForDumpRenderTree):
529         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
530         (setUpIOSLayoutTestCommunication):
531         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
532         (TestWebKitAPI::strip):
533         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
534         (beforeAll):
535         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
536         (main):
537         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
538         (WebKitTestBus::run):
539         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
540         (WTR::getOutputDir):
541         (WTR::initializeFontConfigSetting):
542         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
543         (WTR::InjectedBundle::platformInitialize):
544         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
545         (WTR::topLevelPath):
546         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
547         (WTR::topLevelPath):
548         (WTR::getOutputDir):
549         (WTR::activateFonts):
550         * WebKitTestRunner/TestController.cpp:
551         (WTR::TestController::libraryPathForTesting):
552         (WTR::TestController::generateContextConfiguration const):
553         (WTR::TestController::generatePageConfiguration):
554         (WTR::TestController::decideDestinationWithSuggestedFilename):
555         (WTR::TestController::platformAdjustContext):
556         * WebKitTestRunner/TestController.h:
557         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
558         (WTR::TestController::cocoaPlatformInitialize):
559         (WTR::TestController::platformAdjustContext):
560         * WebKitTestRunner/gtk/main.cpp:
561         (main):
562         * WebKitTestRunner/mac/TestControllerMac.mm:
563         (WTR::TestController::configureContentExtensionForTest):
564         * WebKitTestRunner/wpe/main.cpp:
565         (main):
566         Utilize WTF::Environment where possible.
567
568 2019-02-14  Chris Dumez  <cdumez@apple.com>
569
570         [PSON] Introduce a WebContent Process cache
571         https://bugs.webkit.org/show_bug.cgi?id=194594
572         <rdar://problem/46793397>
573
574         Reviewed by Geoff Garen.
575
576         Update API tests to turn on the WebContent Process cache.
577
578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
579
580 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
581
582         Unreviewed, build fix after r241480
583
584         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
585         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
586         (-[DragAndDropSimulator initWithWebView:]):
587
588 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
589
590         AX: ARIA Reflection was disabled in error
591         https://bugs.webkit.org/show_bug.cgi?id=194647
592         <rdar://problem/48068336>
593
594         Reviewed by Ryosuke Niwa.
595
596         Remove test override now that this feature should be enabled by default.
597
598         * WebKitTestRunner/TestController.cpp:
599         (WTR::TestController::resetPreferencesToConsistentValues):
600
601 2019-02-14  Commit Queue  <commit-queue@webkit.org>
602
603         Unreviewed, rolling out r241486.
604         https://bugs.webkit.org/show_bug.cgi?id=194655
605
606         causing API failures in builds (Requested by ShawnRoberts on
607         #webkit).
608
609         Reverted changeset:
610
611         "[Cocoa] Media elements will restart network buffering just
612         before suspending"
613         https://bugs.webkit.org/show_bug.cgi?id=193691
614         https://trac.webkit.org/changeset/241486
615
616 2019-02-14  Zalan Bujtas  <zalan@apple.com>
617
618         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
619         https://bugs.webkit.org/show_bug.cgi?id=194622
620
621         Reviewed by Antti Koivisto.
622
623         * LayoutReloaded/misc/LFC-passing-tests.txt:
624
625 2019-02-14  Zalan Bujtas  <zalan@apple.com>
626
627         [LFC] Shrink-to-fit-width should be constrained by min/max width
628         https://bugs.webkit.org/show_bug.cgi?id=194653
629
630         Reviewed by Antti Koivisto.
631
632         * LayoutReloaded/misc/LFC-passing-tests.txt:
633
634 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
635
636         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
637         https://bugs.webkit.org/show_bug.cgi?id=194641
638
639         Reviewed by Geoffrey Garen.
640
641         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
642         so that the test would fail without this fix.
643
644         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
645         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
646
647 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
648
649         [ews-app] Change log level for a log statement
650
651         Unreviewed minor fix.
652
653         * BuildSlaveSupport/ews-app/ews/models/patch.py:
654         (Patch.save_patch):
655
656 2019-02-13  Jer Noble  <jer.noble@apple.com>
657
658         [Cocoa] Media elements will restart network buffering just before suspending
659         https://bugs.webkit.org/show_bug.cgi?id=193691
660
661         Reviewed by Eric Carlson.
662
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
665         (TEST):
666
667 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
668
669         [ews-app] Fetch builder id to name mapping
670         https://bugs.webkit.org/show_bug.cgi?id=194355
671
672         Reviewed by Lucas Forschler.
673
674         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
675         (Buildbot.get_builder_id_to_name_mapping):
676         (Buildbot._get_display_name_from_builder_name):
677
678 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
679
680         Further restricting webarchive loads
681         https://bugs.webkit.org/show_bug.cgi?id=194567
682         <rdar://problem/47610130>
683
684         Reviewed by Youenn Fablet.
685
686         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
687         navigations on drop.
688
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
691         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
692         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
693         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
694         (TestWebKitAPI::TEST):
695         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
696         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
697         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
698         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
699         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
700         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
701         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
702
703 2019-02-13  John Wilander  <wilander@apple.com>
704
705         Store Ad Click Attribution requests in the network process
706         https://bugs.webkit.org/show_bug.cgi?id=194510
707         <rdar://problem/47650118>
708
709         Reviewed by Alex Christensen and Daniel Bates.
710
711         This patch adds two TestRunner functions:
712         - dumpAdClickAttribution()
713         - clearAdClickAttribution()
714
715         They call into the network process to dump and clear Ad Click
716         Attribution state, respectively.
717
718         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
719         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
720         (WTR::TestRunner::dumpAdClickAttribution):
721         (WTR::TestRunner::clearAdClickAttribution):
722         * WebKitTestRunner/InjectedBundle/TestRunner.h:
723         * WebKitTestRunner/TestController.cpp:
724         (WTR::TestController::resetStateToConsistentValues):
725         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
726         (WTR::adClickAttributionStringResultCallback):
727         (WTR::TestController::dumpAdClickAttribution):
728         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
729         (WTR::adClickAttributionVoidCallback):
730         (WTR::TestController::clearAdClickAttribution):
731         * WebKitTestRunner/TestController.h:
732         * WebKitTestRunner/TestInvocation.cpp:
733         (WTR::TestInvocation::dumpResults):
734         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
735         (WTR::TestInvocation::dumpAdClickAttribution):
736         * WebKitTestRunner/TestInvocation.h:
737
738 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
739
740         [ews-app] Generate status-bubble
741         https://bugs.webkit.org/show_bug.cgi?id=194572
742
743         Reviewed by Lucas Forschler.
744
745         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
746         (StatusBubble._build_bubble):
747         (StatusBubble._should_show_bubble_for):
748         (StatusBubble._build_bubbles_for_patch):
749
750 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
751
752         [ews-app] Add status bubble html template
753         https://bugs.webkit.org/show_bug.cgi?id=194571
754
755         Reviewed by Lucas Forschler.
756
757         * BuildSlaveSupport/ews-app/ews/templates: Added.
758         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
759
760 2019-02-12  Chris Dumez  <cdumez@apple.com>
761
762         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
763         https://bugs.webkit.org/show_bug.cgi?id=194568
764         <rdar://problem/47944490>
765
766         Reviewed by Ryosuke Niwa.
767
768         Add API test coverage.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
771         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
772
773 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
774
775         webkitpy: Remove bug_dummy from parsed test expectations
776         https://bugs.webkit.org/show_bug.cgi?id=194562
777         <rdar://problem/47853999>
778
779         Reviewed by Lucas Forschler.
780
781         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
782         (TestExpectationParser):
783         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
784         skipped tests.
785         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
786
787 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
788
789         [ews-app] Add method to fetch patch
790         https://bugs.webkit.org/show_bug.cgi?id=194518
791
792         Reviewed by Lucas Forschler.
793
794         * BuildSlaveSupport/ews-app/ews/models/patch.py:
795         (Patch.get_patch):
796
797 2019-02-12  Zalan Bujtas  <zalan@apple.com>
798
799         [LFC] Expand tests coverage (60 new tests -> 860)
800
801         Unreviewed test gardening (run-singly, --child-processes=1).
802
803         * LayoutReloaded/misc/LFC-passing-tests.txt:
804
805 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
806
807         Allow pages to trigger programmatic paste from script on iOS
808         https://bugs.webkit.org/show_bug.cgi?id=194271
809         <rdar://problem/47808810>
810
811         Reviewed by Tim Horton.
812
813         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
814
815         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
816         (WTR::UIScriptController::platformSetDidShowMenuCallback):
817         (WTR::UIScriptController::platformSetDidHideMenuCallback):
818         (WTR::UIScriptController::rectForMenuAction const):
819
820         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
821         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
822         for when the menu is shown or hidden.
823
824         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
825         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
826         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
827         (WTR::UIScriptController::setDidShowMenuCallback):
828         (WTR::UIScriptController::didShowMenuCallback const):
829         (WTR::UIScriptController::setDidHideMenuCallback):
830         (WTR::UIScriptController::didHideMenuCallback const):
831         (WTR::UIScriptController::platformSetDidShowMenuCallback):
832         (WTR::UIScriptController::platformSetDidHideMenuCallback):
833         (WTR::UIScriptController::rectForMenuAction const):
834         * TestRunnerShared/UIScriptContext/UIScriptController.h:
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::resetPreferencesToConsistentValues):
837         (WTR::updateTestOptionsFromTestHeader):
838         * WebKitTestRunner/TestOptions.h:
839
840         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
841         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
842
843         (WTR::TestOptions::hasSameInitializationOptions const):
844         * WebKitTestRunner/UIScriptControllerCocoa.mm:
845         (WTR::UIScriptController::calendarType const):
846         (WTR::UIScriptController::platformUndoManager const):
847         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
848         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
849         (-[TestRunnerWKWebView initWithFrame:configuration:]):
850         (-[TestRunnerWKWebView dealloc]):
851         (-[TestRunnerWKWebView _didShowMenu]):
852         (-[TestRunnerWKWebView _didHideMenu]):
853
854         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
855
856         * WebKitTestRunner/ios/TestControllerIOS.mm:
857         (WTR::handleMenuWillHideNotification):
858         (WTR::handleMenuDidHideNotification):
859         (WTR::TestController::platformInitialize):
860         (WTR::TestController::platformDestroy):
861         (WTR::TestController::platformResetStateToConsistentValues):
862
863         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
864         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
865
866         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
867         (WTR::forEachViewInHierarchy):
868         (WTR::findViewInHierarchyOfType):
869
870         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
871         functions that dig through a given view's hierarchy in search of a view of a given class.
872
873         (WTR::UIScriptController::selectionStartGrabberViewRect const):
874         (WTR::UIScriptController::selectionEndGrabberViewRect const):
875         (WTR::UIScriptController::selectionCaretViewRect const):
876         (WTR::UIScriptController::selectionRangeViewRects const):
877         (WTR::UIScriptController::platformSetDidShowMenuCallback):
878         (WTR::UIScriptController::platformSetDidHideMenuCallback):
879
880         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
881
882         (WTR::UIScriptController::rectForMenuAction const):
883
884         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
885         callout bar) whose label matches the given string.
886
887         (WTR::UIScriptController::platformContentView const):
888
889         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
890         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
891         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
892
893         (WTR::UIScriptController::platformUndoManager const): Deleted.
894         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
895         (WTR::UIScriptController::platformContentView const):
896         (WTR::UIScriptController::platformUndoManager const): Deleted.
897
898 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
899
900         webkitpy: No option to only show unexpected failures in results.html for iPad
901         https://bugs.webkit.org/show_bug.cgi?id=194554
902         <rdar://problem/47922442>
903
904         Rubber-stamped by Aakash Jain.
905
906         Just because a TestExpecations file does not exist for a specific platform does not mean that
907         TestExpecations are not being used, given that platforms inherit test expectations.
908
909         * Scripts/webkitpy/port/base.py:
910         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
911         * Scripts/webkitpy/port/base_unittest.py:
912         (PortTest.test_uses_test_expectations_file):
913
914 2019-02-12  Alex Christensen  <achristensen@webkit.org>
915
916         Remove setDefersLoading infrastructure from WebKit2
917         https://bugs.webkit.org/show_bug.cgi?id=194506
918
919         Reviewed by Brady Eidson.
920
921         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
922         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
923         (WTR::TestRunner::setDefersLoading): Deleted.
924         * WebKitTestRunner/InjectedBundle/TestRunner.h:
925
926 2019-02-12  Alex Christensen  <achristensen@webkit.org>
927
928         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
929         https://bugs.webkit.org/show_bug.cgi?id=194522
930         <rdar://problem/47789393>
931
932         Reviewed by Chris Dumez.
933
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
935         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
936         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
937         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
938
939 2019-02-12  Andy Estes  <aestes@apple.com>
940
941         [iOSMac] Enable Parental Controls Content Filtering
942         https://bugs.webkit.org/show_bug.cgi?id=194521
943         <rdar://39732376>
944
945         Reviewed by Tim Horton.
946
947         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
948
949 2019-02-12  Zalan Bujtas  <zalan@apple.com>
950
951         [LFC][IFC] Add intrinsic width support for float boxes.
952         https://bugs.webkit.org/show_bug.cgi?id=194528
953
954         Reviewed by Antti Koivisto.
955
956         Expand tests coverage (2 new tests -> 800).
957         (This is the correct test ordering --runs-singly --child-processes=1)
958
959         * LayoutReloaded/misc/LFC-passing-tests.txt:
960
961 2019-02-12  Rob Buis  <rbuis@igalia.com>
962
963         Implement serializing in MIME type parser
964         https://bugs.webkit.org/show_bug.cgi?id=193909
965
966         Reviewed by Darin Adler.
967
968         Add various tests involving upper case, non-ASCII, control/null characters,
969         various HTTP whitespace, single quotes and an unpaired surrogate.
970
971         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
972         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
973         (TestWebKitAPI::serializeIfValid):
974         (TestWebKitAPI::TEST):
975
976 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
977
978         [Cocoa] Ask platform for generic font family mappings
979         https://bugs.webkit.org/show_bug.cgi?id=187723
980         <rdar://problem/41892438>
981
982         Reviewed by Brent Fulgham.
983
984         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
985
986         * DumpRenderTree/mac/DumpRenderTree.mm:
987         (allowedFontFamilySet):
988         * WebKitTestRunner/mac/TestControllerMac.mm:
989         (WTR::allowedFontFamilySet):
990
991 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
992
993         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
994         https://bugs.webkit.org/show_bug.cgi?id=193622
995
996         Reviewed by Michael Catanzaro.
997
998         This adds support for loading content extension rule sets from the JSON files which
999         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1000         of WKTR for this could be removed, but that is left for a follow-up patch with
1001         cleanups.
1002
1003         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1006         avoid having the null-terminator copied into the result.
1007         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1008         part of the preparations to run a test.
1009         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1010         (WTR::contentExtensionStoreCallback): Added.
1011         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1012         used for content extensions test.
1013         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1014         extensions and compiling the JSON rule set for tests involving content extensions.
1015         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1016         testing and disables content extensions.
1017         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1018         resetContentExtensions().
1019         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1020         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1021         configureContentExtensionForTest(), and userContentController().
1022
1023 2019-02-11  Daniel Bates  <dabates@apple.com>
1024
1025         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1026         https://bugs.webkit.org/show_bug.cgi?id=191446
1027         <rdar://problem/45929460>
1028
1029         Reviewed by Tim Horton.
1030
1031         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1032
1033         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1034         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1035         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1036         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1037         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1038         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1039         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1040         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1041         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1042         (WTR::arrayLength):
1043         (WTR::parseModifierArray):
1044         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1045         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1046         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1047         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1048
1049 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1050
1051         Unreviewed, rolling out r241272 and r241276.
1052         https://bugs.webkit.org/show_bug.cgi?id=194514
1053
1054         Broke the Apple Internal build and the fix requires human
1055         intervention :( (Requested by dydz on #webkit).
1056
1057         Reverted changesets:
1058
1059         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1060         https://bugs.webkit.org/show_bug.cgi?id=191446
1061         https://trac.webkit.org/changeset/241272
1062
1063         "Fix internal iOS build after r241272"
1064         https://bugs.webkit.org/show_bug.cgi?id=191446
1065         https://trac.webkit.org/changeset/241276
1066
1067 2019-02-11  Truitt Savell  <tsavell@apple.com>
1068
1069         Unreviewed, rolling out r241269.
1070
1071         Caused 5 layout tests crashes on Mac WK1
1072
1073         Reverted changeset:
1074
1075         "DumpRenderTree should report unknown options"
1076         https://bugs.webkit.org/show_bug.cgi?id=191303
1077         https://trac.webkit.org/changeset/241269
1078
1079 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1080
1081         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1082         https://bugs.webkit.org/show_bug.cgi?id=194313
1083
1084         Reviewed by Tim Horton.
1085
1086         Add a helper to determine whether the web view is presenting modal UI.
1087
1088         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1089         (WTR::UIScriptController::isPresentingModally const):
1090         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1091         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1092         (WTR::UIScriptController::isPresentingModally const):
1093         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1094         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1095         (WTR::UIScriptController::calendarType const): Deleted.
1096         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1097         (WTR::UIScriptController::isPresentingModally const):
1098         (WTR::UIScriptController::calendarType const):
1099         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1100         (WTR::UIScriptController::calendarType const):
1101
1102 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1103
1104         GCHeapInspector: Show the retained sizes in more places
1105         https://bugs.webkit.org/show_bug.cgi?id=194464
1106
1107         Reviewed by Simon Fraser.
1108
1109         * GCHeapInspector/gc-heap-inspector.html:
1110         * GCHeapInspector/script/interface.js:
1111         (HeapInspectorUtils.humanReadableSize):
1112         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1113         (HeapInspectorUtils.spanForNode.span.span):
1114         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1115         (HeapSnapshotInspector.prototype.buildRoots):
1116
1117 2019-02-11  Daniel Bates  <dabates@apple.com>
1118
1119         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1120         https://bugs.webkit.org/show_bug.cgi?id=191446
1121         <rdar://problem/45929460>
1122
1123         Reviewed by Tim Horton.
1124
1125         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1126
1127         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1128         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1129         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1131         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1132         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1133         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1134         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1135         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1136         (WTR::arrayLength):
1137         (WTR::parseModifierArray):
1138         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1139         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1140         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1141         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1142
1143 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1144
1145         DumpRenderTree should report unknown options
1146         https://bugs.webkit.org/show_bug.cgi?id=191303
1147
1148         Reviewed by Frédéric Wang.
1149
1150         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1151         to report unknown options.
1152         Added and assigned test options which are currently used in tests.
1153
1154         * DumpRenderTree/TestOptions.cpp:
1155         (TestOptions::TestOptions):
1156
1157 2019-02-11  Truitt Savell  <tsavell@apple.com>
1158
1159         Unreviewed, rolling out r241229.
1160
1161         Revision broke internal builds for watchOS.
1162
1163         Reverted changeset:
1164
1165         "[Cocoa] Ask platform for generic font family mappings"
1166         https://bugs.webkit.org/show_bug.cgi?id=187723
1167         https://trac.webkit.org/changeset/241229
1168
1169 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1170
1171         [WinCairo][MiniBrowser] Basic authentication always fails.
1172         https://bugs.webkit.org/show_bug.cgi?id=194496
1173
1174         Reviewed by Don Olmstead.
1175
1176         * MiniBrowser/win/DialogHelper.h:
1177         (Dialog::getText):
1178
1179 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1180
1181         [GStreamer] GstMappedBuffer testsuite build fails
1182         https://bugs.webkit.org/show_bug.cgi?id=194495
1183
1184         Reviewed by Carlos Garcia Campos.
1185
1186         Fix the build by explicitely adding the gstreamer1.0-audio include
1187         directories to the include path.
1188
1189         * TestWebKitAPI/PlatformGTK.cmake:
1190         * TestWebKitAPI/PlatformWPE.cmake:
1191
1192 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1193
1194         [GTK][WPE] Add enable-javascript-markup setting
1195         https://bugs.webkit.org/show_bug.cgi?id=193439
1196
1197         Reviewed by Michael Catanzaro.
1198
1199         Add test cases to check the new setting.
1200
1201         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1202         (testWebKitSettings):
1203         (testWebKitSettingsJavaScriptMarkup):
1204         (beforeAll):
1205
1206 2019-02-10  Darin Adler  <darin@apple.com>
1207
1208         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1209         https://bugs.webkit.org/show_bug.cgi?id=194485
1210
1211         Reviewed by Daniel Bates.
1212
1213         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1214
1215 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1216
1217         Add more tests for clampTo<>()
1218         https://bugs.webkit.org/show_bug.cgi?id=194462
1219
1220         Reviewed by Geoffrey Garen.
1221
1222         Darin suggested to test the very last floating point number
1223         at the boundaries when truncating to integer.
1224         I added test for max/min and max-1/min-1.
1225
1226         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1227         (TestWebKitAPI::TEST):
1228
1229 2019-02-09  Darin Adler  <darin@apple.com>
1230
1231         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1232         https://bugs.webkit.org/show_bug.cgi?id=194021
1233
1234         Reviewed by Geoffrey Garen.
1235
1236         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1237         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1238         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1239
1240 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1241
1242         [LFC][IFC] Add intrinsic width support for basic inline containers
1243         https://bugs.webkit.org/show_bug.cgi?id=194473
1244
1245         Reviewed by Antti Koivisto.
1246
1247         Expand tests coverage (11 new tests -> 798)
1248
1249         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1250
1251 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1252
1253         Fix MiniBrowser's entitlements
1254         https://bugs.webkit.org/show_bug.cgi?id=192431
1255
1256         Reviewed by Joseph Pecoraro.
1257
1258         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1259         files, making it impossible to load any extension.
1260
1261         * MiniBrowser/MiniBrowser.entitlements:
1262
1263 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1264
1265         [Cocoa] Ask platform for generic font family mappings
1266         https://bugs.webkit.org/show_bug.cgi?id=187723
1267         <rdar://problem/41892438>
1268
1269         Reviewed by Brent Fulgham.
1270
1271         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1272
1273         * DumpRenderTree/mac/DumpRenderTree.mm:
1274         (allowedFontFamilySet):
1275         * WebKitTestRunner/mac/TestControllerMac.mm:
1276         (WTR::allowedFontFamilySet):
1277
1278 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1279
1280         [GTK] Implement back/forward touchpad gesture
1281         https://bugs.webkit.org/show_bug.cgi?id=193919
1282
1283         Reviewed by Michael Catanzaro.
1284
1285         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1286         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1287
1288 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1289
1290         Add SPI to use networking daemon instead of XPC service
1291         https://bugs.webkit.org/show_bug.cgi?id=194427
1292
1293         Reviewed by Geoffrey Garen
1294
1295         * MiniBrowser/MiniBrowser.entitlements:
1296
1297 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1298
1299         [ews-build] Ensure that every builder in config.json has short name
1300         https://bugs.webkit.org/show_bug.cgi?id=194461
1301
1302         Reviewed by Lucas Forschler.
1303
1304         * BuildSlaveSupport/ews-build/loadConfig.py:
1305         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1306
1307 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1308
1309         [ews-build] Add short name to config.json
1310         https://bugs.webkit.org/show_bug.cgi?id=194456
1311
1312         Reviewed by Lucas Forschler.
1313
1314         * BuildSlaveSupport/ews-build/config.json: Added short name.
1315         * BuildSlaveSupport/ews-build/loadConfig.py:
1316         (loadBuilderConfig): Set the short name as the builder description.
1317
1318 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1319
1320         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1321         https://bugs.webkit.org/show_bug.cgi?id=194418
1322
1323         Reviewed by Lucas Forschler.
1324
1325         Do not include errors trying when finding crashlogs at the end of
1326         a run-webkit-tests run since we don't process those errors.
1327
1328         * Scripts/webkitpy/port/darwin.py:
1329         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1330         * Scripts/webkitpy/port/ios_device.py:
1331         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1332         * Scripts/webkitpy/port/watch_device.py:
1333         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1334
1335 2019-02-08  Beth Dakin  <bdakin@apple.com>
1336
1337         Add afterScreenUpdates to WKSnapshotConfiguration
1338         https://bugs.webkit.org/show_bug.cgi?id=194362
1339         -and corresponding-
1340         <rdar://problem/40655528> Please add an "after screen updates" property to 
1341         WKSnapshotConfiguration (to solve blank snapshots)
1342
1343         Reviewed by Tim Horton.
1344
1345         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1346         (TEST):
1347
1348 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1349
1350         clampTo(): do not convert the input to double when dealing with integers
1351         https://bugs.webkit.org/show_bug.cgi?id=194263
1352         <rdar://problem/47692312>
1353
1354         Reviewed by Darin Adler.
1355
1356         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1357         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1358         (TestWebKitAPI::testClampFloatingPointToInteger):
1359         (TestWebKitAPI::testClampSameSignIntegers):
1360         (TestWebKitAPI::testClampUnsignedToSigned):
1361         (TestWebKitAPI::testClampSignedToUnsigned):
1362
1363 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1364
1365         webkitpy: Respect --dedicated-simulators flag
1366         https://bugs.webkit.org/show_bug.cgi?id=194416
1367         <rdar://problem/47894722>
1368
1369         Reviewed by Lucas Forschler.
1370
1371         * Scripts/webkitpy/port/device_port.py:
1372         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1373         available devices can be safely ignored.
1374
1375 2019-02-07  Keith Rollin  <krollin@apple.com>
1376
1377         Remove extra copy of 100x100-red.tga
1378         https://bugs.webkit.org/show_bug.cgi?id=194371
1379         <rdar://problem/47873465>
1380
1381         Reviewed by Said Abou-Hallawa.
1382
1383         In order to help it pass its tests, Bug 194190 added a second copy of
1384         the file 100x100-red.tga. However, it turns out that this additional
1385         file wasn't actually needed, and that that sole previous copy was
1386         sufficient. At the same time, this second copy -- which was copied to
1387         the same location in the build output as the first copy -- now caused
1388         XCBuild to complain because there were two production rules for the
1389         same output file. Address this by removing the newly-added extra copy.
1390
1391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1392         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1393
1394 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1395
1396         Deprecate WKBundlePageSetDefersLoading
1397         https://bugs.webkit.org/show_bug.cgi?id=191394
1398
1399         Reviewed by Dean Jackson.
1400
1401         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1402         (WTR::TestRunner::setDefersLoading):
1403
1404 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1405
1406         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1407         https://bugs.webkit.org/show_bug.cgi?id=194391
1408
1409         Reviewed by Antti Koivisto.
1410
1411         * LayoutReloaded/misc/LFC-passing-tests.txt:
1412
1413 2019-02-06  Keith Rollin  <krollin@apple.com>
1414
1415         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1416         https://bugs.webkit.org/show_bug.cgi?id=193975
1417         <rdar://problem/47643306>
1418
1419         Reviewed by Tim Horton.
1420
1421         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1422         the Info.plist file into the bundle. This step is not necessary as the
1423         implicit "bundle up all the build products into a framework" build
1424         phase does this already. Having the Copy Bundle Resources phase do
1425         this causes a conflict under XCBuild, which objects to two build
1426         phases producing the same file (Info.plist). Address this by removing
1427         Info.plist from the Copy Bundle Resources phase.
1428
1429         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1430
1431 2019-02-06  Keith Rollin  <krollin@apple.com>
1432
1433         Really enable the automatic checking and regenerations of .xcfilelists during builds
1434         https://bugs.webkit.org/show_bug.cgi?id=194357
1435         <rdar://problem/47861231>
1436
1437         Reviewed by Chris Dumez.
1438
1439         Bug 194124 was supposed to enable the automatic checking and
1440         regenerating of .xcfilelist files during the build. While related
1441         changes were included in that patch, the change to actually enable the
1442         operation somehow was omitted. This patch actually enables the
1443         operation. The check-xcfilelist.sh scripts now check
1444         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1445         from the checking.
1446
1447         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1448         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1449
1450 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1451
1452         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1453         <https://webkit.org/b/194286>
1454         <rdar://problem/47815558>
1455
1456         Reviewed by Alexey Proskuryakov.
1457
1458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1459         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1460         WKRetainPtr<> to avoid leaking the WKDataRef.
1461
1462 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1463
1464         Unreviewed, fix a typo
1465
1466         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1467
1468 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1469
1470         [GTK][WPE] force libpsl build to use ICU in jhbuild
1471         https://bugs.webkit.org/show_bug.cgi?id=194288
1472
1473         Reviewed by Carlos Garcia Campos.
1474
1475         * gtk/jhbuild.modules:
1476         Require ICU for libpsl build in jhbuild, like done in WPE.
1477
1478 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1479
1480         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1481         https://bugs.webkit.org/show_bug.cgi?id=194209
1482
1483         Reviewed by Carlos Garcia Campos.
1484
1485         Enhance TestCookieManager to ensure this doesn't happen again.
1486
1487         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1488         (testCookieManagerPersistentStorage):
1489         (beforeAll):
1490
1491 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1492
1493         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1494         https://bugs.webkit.org/show_bug.cgi?id=194324
1495
1496         Reviewed by Andy Estes.
1497
1498         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1499         part of the name is already implicit, since this is in testing code in TestOptions.
1500
1501         * WebKitTestRunner/TestController.cpp:
1502         (WTR::TestController::generateContextConfiguration const):
1503         (WTR::updateTestOptionsFromTestHeader):
1504         * WebKitTestRunner/TestOptions.h:
1505         (WTR::TestOptions::hasSameInitializationOptions const):
1506
1507 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1508
1509         [ews-build] Allow * as platform for builders and workers
1510         https://bugs.webkit.org/show_bug.cgi?id=188533
1511
1512         Reviewed by Lucas Forschler.
1513
1514         * BuildSlaveSupport/ews-build/loadConfig.py:
1515         (checkWorkersAndBuildersForConsistency):
1516
1517 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1518
1519         [ews-build] Add few bots to config.json
1520         https://bugs.webkit.org/show_bug.cgi?id=194304
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * BuildSlaveSupport/ews-build/config.json:
1525
1526 2019-02-05  Keith Rollin  <krollin@apple.com>
1527
1528         Enable the automatic checking and regenerations of .xcfilelists during builds
1529         https://bugs.webkit.org/show_bug.cgi?id=194124
1530         <rdar://problem/47721277>
1531
1532         Reviewed by Tim Horton.
1533
1534         Bug 193790 add a facility for checking -- during build time -- that
1535         any needed .xcfilelist files are up-to-date and for updating them if
1536         they are not. This facility was initially opt-in by setting
1537         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1538         the process seemed robust. Its now time to enable this facility and
1539         make it opt-out. If there is a need to disable this facility, set and
1540         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1541         running `make` or `build-webkit`, or before running Xcode from the
1542         command line.
1543
1544         Additionally, remove the step that generates a list of source files
1545         going into the UnifiedSources build step. It's only necessarily to
1546         specify Sources.txt and SourcesCocoa.txt as inputs.
1547
1548         * Scripts/generate-xcfilelists:
1549
1550 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1551
1552         [GTK][WPE] force libpsl build to use ICU in jhbuild
1553         https://bugs.webkit.org/show_bug.cgi?id=194288
1554
1555         Reviewed by Philippe Normand.
1556
1557         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1558         This can cause build failures if libidn is detected but libunistring is not available.
1559
1560         Make sure that ICU is used for runtime and builtin PSL data.
1561
1562         * gtk/jhbuild.modules:
1563         * wpe/jhbuild.modules:
1564
1565 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1566
1567         [ews-app] Modified timestamp should be updated on updating data
1568         https://bugs.webkit.org/show_bug.cgi?id=194295
1569
1570         Reviewed by Lucas Forschler.
1571
1572         * BuildSlaveSupport/ews-app/ews/models/build.py:
1573         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1574         * BuildSlaveSupport/ews-app/ews/models/step.py:
1575
1576 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1577
1578         Unreviewed, rolling out r240742.
1579
1580         Causes crashes on iOS simulator.
1581
1582         Reverted changeset:
1583
1584         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1585         not focused in a content-editable element"
1586         https://bugs.webkit.org/show_bug.cgi?id=192824
1587         https://trac.webkit.org/changeset/240742
1588
1589 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1590
1591         run-webkit-tests emits message "...running None" when running tests
1592         https://bugs.webkit.org/show_bug.cgi?id=194133
1593         <rdar://problem/47724738>
1594
1595         Reviewed by Lucas Forschler.
1596
1597         * Scripts/webkitpy/xcode/device_type.py:
1598         (DeviceType.__str__): Use both version mapping tables and use just the variant
1599         name if no version name is available.
1600         * Scripts/webkitpy/xcode/device_type_unittest.py:
1601         (DeviceTypeTest):
1602         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1603         an associated named.
1604
1605 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1606
1607         [WPE] require python3-setuptools for meson build in jhbuild
1608         https://bugs.webkit.org/show_bug.cgi?id=194287
1609
1610         Reviewed by Philippe Normand.
1611
1612         python3-setuptools is needed to build meson in jhbuild.
1613         It is already required by the GTK port.
1614
1615         * wpe/install-dependencies:
1616
1617 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1618
1619         [ews-app] Add method to save BuilderMapping to database
1620         https://bugs.webkit.org/show_bug.cgi?id=194264
1621
1622         Reviewed by Lucas Forschler.
1623
1624         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1625         (BuilderMapping.__str__):
1626         (BuilderMapping):
1627         (BuilderMapping.save_mapping):
1628         (BuilderMapping.update_mapping):
1629         (BuilderMapping.get_existing_mapping):
1630         (BuilderMapping.is_valid_mapping):
1631
1632 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-app] Add timestamp fields for BuilderMappings
1635         https://bugs.webkit.org/show_bug.cgi?id=194266
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1640         (BuilderMapping):
1641
1642 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1643
1644         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1645         https://bugs.webkit.org/show_bug.cgi?id=174816
1646
1647         Reviewed by Michael Catanzaro.
1648
1649         Add tests for webkit_uri_for_display().
1650
1651         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1652         (testURIForDisplayUnaffected):
1653         (testURIForDisplayAffected):
1654         (beforeAll):
1655         (afterAll):
1656         * TestWebKitAPI/glib/CMakeLists.txt:
1657
1658 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1659
1660         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1661         https://bugs.webkit.org/show_bug.cgi?id=194158
1662         <rdar://problem/47737268>
1663
1664         Rubber-stamped by Aakash Jain.
1665
1666         * Scripts/webkitpy/port/device_port.py:
1667         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1668
1669 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1670
1671         [CG] Enable setAdditionalSupportedImageTypes for WK1
1672         https://bugs.webkit.org/show_bug.cgi?id=194190
1673
1674         Reviewed by Tim Horton.
1675
1676         Add a test similar to the one under WebKit Cocoa but make it create a
1677         WebView instead of a WKWebView.
1678
1679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1680         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1681         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1682         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1683         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1684         (TestWebKitAPI::runTest):
1685         (TestWebKitAPI::TEST):
1686
1687 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1688
1689         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1690         https://bugs.webkit.org/show_bug.cgi?id=194168
1691
1692         Reviewed by Simon Fraser.
1693
1694         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1695
1696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1697         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1698         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1699         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1700         (TEST):
1701         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1702         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1703
1704 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1705
1706         REGRESSION (r237269): webkit-patch what-broke is broken 
1707         https://bugs.webkit.org/show_bug.cgi?id=193025
1708
1709         Reviewed by Aakash Jain.
1710
1711         * Scripts/webkitpy/common/host.py:
1712         (Host.buildbot):
1713         (Host.bugzilla): Renamed to 'buildbot'.
1714
1715 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1716
1717         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1718         https://bugs.webkit.org/show_bug.cgi?id=194207
1719
1720         Reviewed by Tim Horton.
1721
1722         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1723         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1724         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1725         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1726         start and delete forwards to remove the original attachment.
1727
1728         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1729         (TestWebKitAPI::TEST):
1730
1731 2019-02-04  Youenn Fablet  <youenn@apple.com>
1732
1733         Capture state should be managed consistently when doing process swapping
1734         https://bugs.webkit.org/show_bug.cgi?id=194122
1735         <rdar://problem/47609293>
1736
1737         Reviewed by Eric Carlson.
1738
1739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1740         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1741         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1742         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1743         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1744         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1745         (WTR::TestRunner::isDoingMediaCapture const):
1746         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1747         * WebKitTestRunner/TestController.cpp:
1748         (WTR::TestController::isDoingMediaCapture const):
1749         * WebKitTestRunner/TestController.h:
1750         * WebKitTestRunner/TestInvocation.cpp:
1751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1752         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1753         (WTR::TestController::isDoingMediaCapture const):
1754
1755 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1756
1757         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1758         https://bugs.webkit.org/show_bug.cgi?id=194142
1759
1760         Reviewed by Ross Kirsling.
1761
1762         There three 'separator' variables in TestController.cpp. Renamed
1763         it 'pathSeparator', and unified them.
1764
1765         * WebKitTestRunner/TestController.cpp:
1766         (WTR::TestController::generateContextConfiguration const):
1767         (WTR::createTestURL):
1768         (WTR::TestController::platformAdjustContext):
1769
1770 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1771
1772         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1773         https://bugs.webkit.org/show_bug.cgi?id=194198
1774
1775         Reviewed by Antti Koivisto.
1776
1777         No need to set the banner heights on navigation now, since Page stores them.
1778
1779         * MiniBrowser/mac/WK2BrowserWindowController.m:
1780         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1781
1782 2019-02-03  John Wilander  <wilander@apple.com>
1783
1784         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1785         https://bugs.webkit.org/show_bug.cgi?id=194104
1786         <rdar://problem/47649991>
1787
1788         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1789
1790         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1791         (TestWebKitAPI::TEST):
1792             Changed numeric types from unsigned short to uint32_t.
1793
1794 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1795
1796         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1797         <https://webkit.org/b/194178>
1798         <rdar://problem/47753473>
1799
1800         Reviewed by Alexey Proskuryakov.
1801
1802         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1803         (WTR::uninstallFakeHelvetica): Pass nullptr into
1804         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1805
1806 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1807
1808         [LFC] Initialize ICB's style with fixed width/height.
1809         https://bugs.webkit.org/show_bug.cgi?id=194188
1810
1811         Reviewed by Antti Koivisto.
1812
1813         * LayoutReloaded/misc/LFC-passing-tests.txt:
1814
1815 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1816
1817         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1818         https://bugs.webkit.org/show_bug.cgi?id=194185
1819
1820         Reviewed by Antti Koivisto.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2018-12-16  Darin Adler  <darin@apple.com>
1825
1826         Convert additional String::format clients to alternative approaches
1827         https://bugs.webkit.org/show_bug.cgi?id=192746
1828
1829         Reviewed by Alexey Proskuryakov.
1830
1831         * WebKitTestRunner/TestController.cpp:
1832         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1833         as an intermediate in code that ultimately constructs a WTF::String.
1834         (WTR::userMediaOriginHash): Use makeString.
1835         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1836         (WTR::TestController::didPerformClientRedirect): Ditto.
1837         (WTR::TestController::didPerformServerRedirect): Ditto.
1838         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1839
1840 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1841
1842         [ews-build] Add unit test to verify builder keys
1843         https://bugs.webkit.org/show_bug.cgi?id=194152
1844
1845         Reviewed by Lucas Forschler.
1846
1847         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1848         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1849
1850 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1851
1852         [LFC] Expand tests coverage (12 new tests -> 787)
1853
1854         Unreviewed test gardening.
1855
1856         * LayoutReloaded/misc/LFC-passing-tests.txt:
1857
1858 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1859
1860         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1861         https://bugs.webkit.org/show_bug.cgi?id=194163
1862
1863         Reviewed by Simon Fraser.
1864
1865         775
1866
1867         * LayoutReloaded/misc/LFC-passing-tests.txt:
1868
1869 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1870
1871         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1872         https://bugs.webkit.org/show_bug.cgi?id=194140
1873         <rdar://problem/47728098>
1874
1875         Reviewed by Tim Horton.
1876
1877         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1879         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1880
1881         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1882         test to induce an IPC deadlock when presenting a modal alert during touch start.
1883
1884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1885         * WebKitTestRunner/TestController.cpp:
1886         (WTR::runJavaScriptAlert):
1887
1888         Add a client callback function for running JavaScript alerts.
1889
1890         (WTR::TestController::createOtherPage):
1891         (WTR::TestController::generateContextConfiguration const):
1892
1893         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1894         the fix in this patch.
1895
1896         (WTR::TestController::createWebViewWithOptions):
1897
1898         Plumb TestOptions to generateContextConfiguration.
1899
1900         (WTR::TestController::resetPreferencesToConsistentValues):
1901         (WTR::TestController::resetStateToConsistentValues):
1902         (WTR::updateTestOptionsFromTestHeader):
1903         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1904         (WTR::TestController::handleJavaScriptAlert):
1905         * WebKitTestRunner/TestController.h:
1906         * WebKitTestRunner/TestInvocation.cpp:
1907         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1908         * WebKitTestRunner/TestOptions.h:
1909         (WTR::TestOptions::hasSameInitializationOptions const):
1910
1911 2019-02-01  Chris Dumez  <cdumez@apple.com>
1912
1913         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1914         https://bugs.webkit.org/show_bug.cgi?id=193740
1915         <rdar://problem/47527267>
1916
1917         Reviewed by Alex Christensen.
1918
1919         Add API test coverage.
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1922
1923 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews-app] Add display name field to BuilderMapping model
1926         https://bugs.webkit.org/show_bug.cgi?id=194153
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1931         (BuilderMapping):
1932
1933 2019-02-01  Youenn Fablet  <youenn@apple.com>
1934
1935         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1936         https://bugs.webkit.org/show_bug.cgi?id=194155
1937
1938         Reviewed by Eric Carlson.
1939
1940         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1941         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1942         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1943
1944 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1945
1946         [LFC] Adjust replaced element's intrinsic ratio
1947         https://bugs.webkit.org/show_bug.cgi?id=194154
1948
1949         Reviewed by Antti Koivisto.
1950
1951         761
1952
1953         * LayoutReloaded/misc/LFC-passing-tests.txt:
1954
1955 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1956
1957         [WPE] Show test results in minibrowser
1958         https://bugs.webkit.org/show_bug.cgi?id=194150
1959
1960         Reviewed by Žan Doberšek.
1961
1962         * Scripts/webkitpy/port/wpe.py:
1963         (WPEPort.show_results_html_file):
1964
1965 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1966
1967         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1968         https://bugs.webkit.org/show_bug.cgi?id=194151
1969
1970         Reviewed by Žan Doberšek.
1971
1972         ALT + <- go back
1973         ALT + -> go forward
1974
1975         * MiniBrowser/wpe/main.cpp:
1976         (main):
1977
1978 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1979
1980         [LFC] Set intrinsic size on Layout::Replaced
1981         https://bugs.webkit.org/show_bug.cgi?id=194139
1982
1983         Reviewed by Antti Koivisto.
1984
1985         744
1986
1987         * LayoutReloaded/misc/LFC-passing-tests.txt:
1988
1989 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1990
1991         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1992         https://bugs.webkit.org/show_bug.cgi?id=194146
1993
1994         Reviewed by Xabier Rodriguez-Calvar.
1995
1996         It allows to open relative paths.
1997
1998         * MiniBrowser/wpe/main.cpp:
1999         (main):
2000
2001 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2002
2003         Update flakiness dashboard configuration after recent queue changes
2004         https://bugs.webkit.org/show_bug.cgi?id=194127
2005
2006         Rubber-stamped by Aakash Jain.
2007
2008         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2009
2010         * TestResultServer/static-dashboards/builders.jsonp:
2011
2012 2019-01-31  Youenn Fablet  <youenn@apple.com>
2013
2014         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2015         https://bugs.webkit.org/show_bug.cgi?id=194106
2016         <rdar://problem/47676333>
2017
2018         Reviewed by Ryosuke Niwa.
2019
2020         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2021         (TestWebKitAPI::didFinishNavigation):
2022         (TestWebKitAPI::TEST):
2023         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2024
2025 2019-01-31  Chris Dumez  <cdumez@apple.com>
2026
2027         Page zoom level is lost after a process swap or a crash
2028         https://bugs.webkit.org/show_bug.cgi?id=194105
2029         <rdar://problem/47610781>
2030
2031         Reviewed by Alex Christensen.
2032
2033         Add API test coverage.
2034
2035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2036         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2037
2038 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2039
2040         Revert r238819 which is unneeded and caused a performance regression.
2041         https://bugs.webkit.org/show_bug.cgi?id=192272
2042         <rdar://problem/46664625>
2043
2044         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2045         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2046         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2047
2048 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2049
2050         Formalize WebKitAdditions mechanism of LoadOptimizer
2051         https://bugs.webkit.org/show_bug.cgi?id=193886
2052         <rdar://problem/47696809>
2053
2054         Reviewed by Brent Fulgham.
2055
2056         * MiniBrowser/MiniBrowser.entitlements:
2057         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2058
2059 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2060
2061         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2062         https://bugs.webkit.org/show_bug.cgi?id=194090
2063
2064         Reviewed by Antti Koivisto.
2065
2066         * LayoutReloaded/misc/LFC-passing-tests.txt:
2067
2068 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2069
2070         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2071         https://bugs.webkit.org/show_bug.cgi?id=194074
2072
2073         Reviewed by Antti Koivisto.
2074
2075         * LayoutReloaded/misc/LFC-passing-tests.txt:
2076
2077 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2078
2079         [LFC][BFC] Add support for block level replaced box.
2080         https://bugs.webkit.org/show_bug.cgi?id=194071
2081
2082         Reviewed by Antti Koivisto.
2083
2084         * LayoutReloaded/misc/LFC-passing-tests.txt:
2085
2086 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2087
2088         Fix WebKitTestRunner's testPath with Windows full paths
2089         https://bugs.webkit.org/show_bug.cgi?id=194012
2090
2091         Reviewed by Alex Christensen.
2092
2093         updateTestOptionsFromTestHeader failed to open test files because
2094         testPath returned wrong file paths. It returned a path "/C:/..."
2095         if a URL "file:///C:/..." was given.
2096
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2099
2100 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2101
2102         [WPE] Bump font related dependencies to match the GTK+ port
2103         https://bugs.webkit.org/show_bug.cgi?id=194017
2104
2105         Reviewed by Žan Doberšek.
2106
2107         * wpe/jhbuild.modules:
2108         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2109         * wpe/patches/icudata-stdlibs.patch: Added.
2110
2111 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2112
2113         Enable swipe tests on iOS
2114         https://bugs.webkit.org/show_bug.cgi?id=194076
2115
2116         Reviewed by Geoffrey Garen.
2117
2118         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2119         it causes a debug assertion failure in runUIScript.
2120
2121         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2122         (WTR::UIScriptController::beginBackSwipe):
2123         (WTR::UIScriptController::completeBackSwipe):
2124
2125 2019-01-30  Keith Rollin  <krollin@apple.com>
2126
2127         Use correct printf format specifier
2128         https://bugs.webkit.org/show_bug.cgi?id=194062
2129         <rdar://problem/47686167>
2130
2131         Reviewed by Alexey Proskuryakov.
2132
2133         LayoutTestSpellChecker.mm is trying to format a variable of type
2134         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2135         actually an unsigned long long. Fix this by formatting with %llu.
2136
2137         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2138         (-[LayoutTestTextCheckingResult description]):
2139
2140 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2141
2142         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2143         https://bugs.webkit.org/show_bug.cgi?id=193979
2144
2145         Reviewed by Wenson Hsieh.
2146
2147         Fix the test for iOS. Make the test work with iOS UA string.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2150
2151 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2152
2153         Replace High Sierra LLINT CLoop bot due to hardware failure
2154         https://bugs.webkit.org/show_bug.cgi?id=194066
2155
2156         Reviewed by Aakash Jain.
2157
2158         * BuildSlaveSupport/build.webkit.org-config/config.json:
2159
2160 2019-01-30  Keith Rollin  <krollin@apple.com>
2161
2162         [NSDragItem init] is unavailable
2163         https://bugs.webkit.org/show_bug.cgi?id=194059
2164         <rdar://problem/47685715>
2165
2166         Reviewed by Wenson Hsieh.
2167
2168         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2169         DumpRenderTree and TestWebKitAPI, which both try to create an
2170         NSDragItem in a manner that invokes this method. Address this by using
2171         -initWithPasteboardWriter instead.
2172
2173         Note that the parameter passed to initWithPasteboardWriter is likely
2174         incorrect. In both cases, the object passed does not conform to
2175         NSPasteboardWriting. However, with this fix, we're no worse off than
2176         before, and can now perform builds with newer compilers and SDKs until
2177         a real fix can be crafted. That work is tracked in
2178         https://bugs.webkit.org/show_bug.cgi?id=194060
2179
2180         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2181         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2182         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2183         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2184
2185 2019-01-30  Daniel Bates  <dabates@apple.com>
2186
2187         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2188         https://bugs.webkit.org/show_bug.cgi?id=192824
2189         <rdar://problem/47100332>
2190
2191         Reviewed by Wenson Hsieh.
2192
2193         Fix a bug where the wrong usage code was used for F13 thru F24.
2194
2195         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2196         (keyCodeForDOMFunctionKey):
2197
2198 2019-01-30  Chris Dumez  <cdumez@apple.com>
2199
2200         Regression(PSON) Load hang can occur on history navigation
2201         https://bugs.webkit.org/show_bug.cgi?id=194030
2202         <rdar://problem/47656939>
2203
2204         Reviewed by Antti Koivisto.
2205
2206         Add API test coverage.
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2209
2210 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2211
2212         [LFC] Expand tests coverage.
2213
2214         Unreviewed test gardening.
2215
2216         * LayoutReloaded/misc/LFC-passing-tests.txt:
2217
2218 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2219
2220         [Flatpak] Add openjpeg support
2221         https://bugs.webkit.org/show_bug.cgi?id=194019
2222
2223         Reviewed by Michael Catanzaro.
2224
2225         * flatpak/org.webkit.CommonModules.yaml:
2226
2227 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2228
2229         Unreviewed, rolling out r240708.
2230         https://bugs.webkit.org/show_bug.cgi?id=194022
2231
2232         It broke WPE build (Requested by KaL on #webkit).
2233
2234         Reverted changeset:
2235
2236         "[WPE] Bump font related dependencies to match the GTK+ port"
2237         https://bugs.webkit.org/show_bug.cgi?id=194017
2238         https://trac.webkit.org/changeset/240708
2239
2240 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2241
2242         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2243         https://bugs.webkit.org/show_bug.cgi?id=194001
2244
2245         Reviewed by Antti Koivisto.
2246
2247         * LayoutReloaded/misc/LFC-passing-tests.txt:
2248
2249 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2250
2251         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2252         https://bugs.webkit.org/show_bug.cgi?id=194020
2253
2254         Reviewed by Antti Koivisto.
2255
2256         * LayoutReloaded/misc/LFC-passing-tests.txt:
2257
2258 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2259
2260         AX: Support color well on iOS
2261         https://bugs.webkit.org/show_bug.cgi?id=194010
2262
2263         Reviewed by Joanmarie Diggs.
2264
2265         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2266         (WTR::AccessibilityUIElement::stringAttributeValue):
2267
2268 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2269
2270         [WPE] Bump font related dependencies to match the GTK+ port
2271         https://bugs.webkit.org/show_bug.cgi?id=194017
2272
2273         Reviewed by Žan Doberšek.
2274
2275         * wpe/jhbuild.modules:
2276         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2277         * wpe/patches/icudata-stdlibs.patch: Added.
2278
2279 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2280
2281         [Mac] Update window scale API usage
2282         https://bugs.webkit.org/show_bug.cgi?id=193991
2283         rdar://problem/47614795
2284
2285         Reviewed by Tim Horton.
2286
2287         * DumpRenderTree/mac/DumpRenderTree.mm:
2288         (changeWindowScaleIfNeeded):
2289         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2290         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2291         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2292
2293 2019-01-29  Chris Dumez  <cdumez@apple.com>
2294
2295         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2296         https://bugs.webkit.org/show_bug.cgi?id=193977
2297         <rdar://problem/47643716>
2298
2299         Reviewed by Geoff Garen.
2300
2301         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2302         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2303         to the previous provisional committing *before* we make the last load. 
2304
2305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2306
2307 2019-01-29  Youenn Fablet  <youenn@apple.com>
2308
2309         Adopt new SPI to evaluate server certificate trust
2310         https://bugs.webkit.org/show_bug.cgi?id=193355
2311
2312         Reviewed by Alex Christensen.
2313
2314         Add infrastructure to handle HTTPS server trust evaluation testing.
2315
2316         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2318         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2319         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2320         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR::TestController::resetPreferencesToConsistentValues):
2324         (WTR::TestController::didReceiveAuthenticationChallenge):
2325         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2326         * WebKitTestRunner/TestController.h:
2327         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2328         * WebKitTestRunner/TestInvocation.cpp:
2329         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2330         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2331         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2332
2333 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [ews-build] Add build step to print bot Configuration
2336         https://bugs.webkit.org/show_bug.cgi?id=193887
2337
2338         Reviewed by Lucas Forschler.
2339
2340         * BuildSlaveSupport/ews-build/steps.py:
2341         (PrintConfiguration): Build step to print configuration.
2342         * BuildSlaveSupport/ews-build/factories.py:
2343
2344 2019-01-29  Chris Dumez  <cdumez@apple.com>
2345
2346         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2347         https://bugs.webkit.org/show_bug.cgi?id=193967
2348         <rdar://problem/47635348>
2349
2350         Reviewed by Alex Christensen.
2351
2352         Add API test coverage.
2353
2354         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2355         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2356
2357 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2358
2359         [ews-app] Handle incoming results data
2360         https://bugs.webkit.org/show_bug.cgi?id=193973
2361
2362         Reviewed by Lucas Forschler.
2363
2364         * BuildSlaveSupport/ews-app/ews/views/results.py:
2365
2366 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2367
2368         [ews-app] Make the results url generic
2369         https://bugs.webkit.org/show_bug.cgi?id=193928
2370
2371         Reviewed by Lucas Forschler.
2372
2373         * BuildSlaveSupport/ews-app/ews/urls.py:
2374
2375 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2376
2377         [ews-build] Configure buildbot to send events to ews-app
2378         https://bugs.webkit.org/show_bug.cgi?id=193968
2379
2380         Reviewed by Lucas Forschler.
2381
2382         * BuildSlaveSupport/ews-build/events.py: Added.
2383         * BuildSlaveSupport/ews-build/master.cfg:
2384
2385 2019-01-29  Keith Rollin  <krollin@apple.com>
2386
2387         Add .xcfilelists to Run Script build phases
2388         https://bugs.webkit.org/show_bug.cgi?id=193792
2389         <rdar://problem/47201785>
2390
2391         Reviewed by Alex Christensen.
2392
2393         As part of supporting XCBuild, update the necessary Run Script build
2394         phases in their Xcode projects to refer to their associated
2395         .xcfilelist files.
2396
2397         Note that the addition of these files bumps the Xcode project version
2398         number to something that's Xcode 10 compatible. This change means that
2399         older versions of the Xcode IDE can't read these projects. Nor can it
2400         fully load workspaces that refer to these projects (the updated
2401         projects are shown as non-expandable placeholders). `xcodebuild` can
2402         still build these projects; it's just that the IDE can't open them.
2403
2404         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2405         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2406
2407 2019-01-29  John Wilander  <wilander@apple.com>
2408
2409         Add data abstraction and validation for Ad Click Attribution
2410         https://bugs.webkit.org/show_bug.cgi?id=193916
2411         <rdar://problem/47603481>
2412
2413         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2414
2415         Ad click attribution has two steps. First, the storage of an ad
2416         campaign ID for a click that takes the user to a destination
2417         site. Second, a conversion on the destination site that can be
2418         attributed to the ad click.
2419
2420         This patch adds a class that represents a request for ad click
2421         attribution. Validation makes sure that the bits of entropy
2422         reported through this mechanism is limited.
2423
2424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2425         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2426         (TestWebKitAPI::TEST):
2427
2428 2019-01-29  Chris Dumez  <cdumez@apple.com>
2429
2430         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2431         https://bugs.webkit.org/show_bug.cgi?id=193932
2432         <rdar://problem/47598947>
2433
2434         Reviewed by Brady Eidson.
2435
2436         Add API test coverage.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2439
2440 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2441
2442         Adding new passing LFC tests.
2443
2444         Unreviewed test gardening.
2445
2446         * LayoutReloaded/misc/LFC-passing-tests.txt:
2447
2448 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2449
2450         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2451         https://bugs.webkit.org/show_bug.cgi?id=193964
2452
2453         Reviewed by Antti Koivisto.
2454
2455         * LayoutReloaded/misc/LFC-passing-tests.txt:
2456
2457 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2458
2459         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2460         https://bugs.webkit.org/show_bug.cgi?id=193954
2461
2462         Reviewed by Antti Koivisto.
2463
2464         * LayoutReloaded/misc/LFC-passing-tests.txt:
2465
2466 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2467
2468         WebDriver: add support for running subtests
2469         https://bugs.webkit.org/show_bug.cgi?id=193904
2470
2471         Reviewed by Michael Catanzaro.
2472
2473         pytest already supports it by passing test.py::subtest, so we can do the same.
2474
2475         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2476         (get_item_name): Made this global.
2477         (CollectRecorder.__init__): Receive the parameter to ignore.
2478         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2479         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2480         (collect): Add parameter to ignore.
2481         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2482         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2483         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2484         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2485         (WebDriverTestRunnerSelenium.run): Ditto.
2486         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2487         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2488         (WebDriverTestRunnerW3C.run): Ditto.
2489
2490 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2491
2492         User agent string override for navigator.userAgent should be site specific quirks
2493         https://bugs.webkit.org/show_bug.cgi?id=193950
2494
2495         Reviewed by Brent Fulgham.
2496
2497         Updated per the _WKWebsitePolicies rename.
2498
2499         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2500         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2501
2502 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2503
2504         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2505         https://bugs.webkit.org/show_bug.cgi?id=193941
2506
2507         Reviewed by Alex Christensen.
2508
2509         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2510         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2511         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2512         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2513         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2514         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2515         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2516         * TestWebKitAPI/Tests/WTF/Time.cpp:
2517         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2518         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2519         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2520         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2521
2522 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2523
2524         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2525
2526         * Scripts/webkitpy/common/config/contributors.json:
2527
2528 2019-01-28  Andy Estes  <aestes@apple.com>
2529
2530         [watchOS] Enable Parental Controls content filtering
2531         https://bugs.webkit.org/show_bug.cgi?id=193939
2532         <rdar://problem/46641912>
2533
2534         Reviewed by Ryosuke Niwa.
2535
2536         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2537
2538 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2539
2540         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2541         <https://webkit.org/b/193884>
2542
2543         Reviewed by Jiewen Tan.
2544
2545         * Scripts/webkitpy/style/checkers/cpp.py:
2546         (check_language): Add LocalAuthentication to
2547         `frameworks_with_soft_links`.
2548
2549 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2550
2551         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2552         https://bugs.webkit.org/show_bug.cgi?id=193891
2553
2554         Reviewed by Ross Kirsling.
2555
2556         There were three problems in window sizes of WebView and the host window.
2557         1. The sizes of pixel image output were incorrect.
2558         2. The host window is going to appear after window.resize was invoked.
2559         3. window.resize resized only the host window, not WebView.
2560
2561         This change solves them with a following approach.
2562         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2563         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2564            as well as DumpRenderTree in order to match the client area and the window area.
2565         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2566         d. PlatformWebView::setWindowFrame changes both window sizes.
2567         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2568
2569         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2570         (WTR::PlatformWebView::PlatformWebView): Create the host window
2571         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2572         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2573         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2574
2575 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2576
2577         [ews-app] Add method to save Step data to database
2578         https://bugs.webkit.org/show_bug.cgi?id=193890
2579
2580         Reviewed by Lucas Forschler.
2581
2582         * BuildSlaveSupport/ews-app/ews/models/step.py:
2583         (Step.save_step): Method to save step data.
2584         (Step.update_step): Method to update step data.
2585         (Step.get_existing_step): Method to fetch existing step from database.
2586         (Step.is_valid_result): Method to validate valid step result.
2587
2588 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2589
2590         [ews-app] Add method to save Build data to database
2591         https://bugs.webkit.org/show_bug.cgi?id=193735
2592
2593         Reviewed by Lucas Forschler.
2594
2595         * BuildSlaveSupport/ews-app/ews/models/build.py:
2596         (Build.save_build): Method to save build information to database.
2597         (Build.get_existing_build): Method to fetch existing build from database.
2598         (Build.is_valid_result): Method to validate build result.
2599         * BuildSlaveSupport/ews-app/ews/common/util.py:
2600         (is_valid_int_id): Method to validate valid id.
2601
2602 2019-01-28  Chris Dumez  <cdumez@apple.com>
2603
2604         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2605         https://bugs.webkit.org/show_bug.cgi?id=193915
2606         <rdar://problem/47560907>
2607
2608         Reviewed by Alex Christensen.
2609
2610         Add API test coverage.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2613
2614 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2615
2616         [ews-app] Rename id variables
2617         https://bugs.webkit.org/show_bug.cgi?id=193883
2618
2619         Reviewed by Lucas Forschler.
2620
2621         * BuildSlaveSupport/ews-app/ews/models/build.py:
2622         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2623         * BuildSlaveSupport/ews-app/ews/models/step.py:
2624         * BuildSlaveSupport/ews-app/ews/urls.py:
2625         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2626         * BuildSlaveSupport/ews-app/ews/views/results.py:
2627         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2628
2629 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2630
2631         [ews-app] Allow certain fields to be empty
2632         https://bugs.webkit.org/show_bug.cgi?id=193892
2633
2634         Reviewed by Lucas Forschler.
2635
2636         * BuildSlaveSupport/ews-app/ews/models/build.py:
2637         * BuildSlaveSupport/ews-app/ews/models/step.py:
2638
2639 2019-01-28  Rob Buis  <rbuis@igalia.com>
2640
2641         Update MIME type parser
2642         https://bugs.webkit.org/show_bug.cgi?id=180526
2643
2644         Reviewed by Frédéric Wang.
2645
2646         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2647         (TestWebKitAPI::TEST):
2648
2649 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2650
2651         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2652         https://bugs.webkit.org/show_bug.cgi?id=193896
2653
2654         Reviewed by Antti Koivisto.
2655
2656         * LayoutReloaded/misc/LFC-passing-tests.txt:
2657
2658 2018-12-15  Darin Adler  <darin@apple.com>
2659
2660         Replace many uses of String::format with more type-safe alternatives
2661         https://bugs.webkit.org/show_bug.cgi?id=192742
2662
2663         Reviewed by Mark Lam.
2664
2665         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2666         (WTR::cacheTestRunnerCallback): Use makeString.
2667         * WebKitTestRunner/TestController.cpp:
2668         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2669         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2670
2671 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2672
2673         Use a load optimizer for some sites
2674         https://bugs.webkit.org/show_bug.cgi?id=193881
2675         <rdar://problem/46325455>
2676
2677         Reviewed by Brent Fulgham.
2678
2679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2680         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2681
2682 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2683
2684         AX: Introduce a static accessibility tree
2685         https://bugs.webkit.org/show_bug.cgi?id=193348
2686         <rdar://problem/47203295>
2687
2688         Reviewed by Ryosuke Niwa.
2689
2690         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2691
2692 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2693
2694         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2695         https://bugs.webkit.org/show_bug.cgi?id=193867
2696
2697         Reviewed by Antti Koivisto.
2698
2699         * LayoutReloaded/misc/LFC-passing-tests.txt:
2700
2701 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2702
2703         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2704         https://bugs.webkit.org/show_bug.cgi?id=193865
2705
2706         Reviewed by Antti Koivisto.
2707
2708         * LayoutReloaded/misc/LFC-passing-tests.txt:
2709
2710 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2711
2712         Need a mechanism to override navigator.userAgent
2713         https://bugs.webkit.org/show_bug.cgi?id=193762
2714         <rdar://problem/47504939>
2715
2716         Reviewed by Brent Fulgham.
2717
2718         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2721         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2722         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2723
2724 2019-01-25  Dean Jackson  <dino@apple.com>
2725
2726         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2727         https://bugs.webkit.org/show_bug.cgi?id=193831
2728         <rdar://problem/47399263>
2729
2730         Reviewed by Chris Dumez.
2731
2732         Two new tests that exercise cross-origin and same-origin System
2733         Previews.
2734
2735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2736
2737 2019-01-25  Keith Rollin  <krollin@apple.com>
2738
2739         Update Xcode projects with "Check .xcfilelists" build phase
2740         https://bugs.webkit.org/show_bug.cgi?id=193790
2741         <rdar://problem/47201374>
2742
2743         Reviewed by Alex Christensen.
2744
2745         Support for XCBuild includes specifying inputs and outputs to various
2746         Run Script build phases. These inputs and outputs are specified as
2747         .xcfilelist files. Once created, these .xcfilelist files need to be
2748         kept up-to-date. In order to check that they are up-to-date or not,
2749         add an Xcode build step that invokes an external script that performs
2750         the checking. If the .xcfilelists are found to be out-of-date, update
2751         them, halt the build, and instruct the developer to restart the build
2752         with up-to-date files.
2753
2754         At this time, the checking and regenerating is performed only if the
2755         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2756         who want to use this facility can set this variable and test out the
2757         checking/regenerating. Once it seems like there are no egregious
2758         issues that upset a developer's workflow, we'll unconditionally enable
2759         this facility.
2760
2761         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2762         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2763         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2764         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2765
2766 2019-01-25  Keith Rollin  <krollin@apple.com>
2767
2768         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2769         https://bugs.webkit.org/show_bug.cgi?id=193781
2770         <rdar://problem/47201153>
2771
2772         Reviewed by Alex Christensen.
2773
2774         Part of generating the .xcfilelists used as part of adopting XCBuild
2775         includes running `make DerivedSources.make` from a standalone script.
2776         It’s important for this invocation to have the same environment as
2777         when the actual build invokes `make DerivedSources.make`. If the
2778         environments are different, then the two invocations will provide
2779         different results. In order to get the same environment in the
2780         standalone script, have the script launch xcodebuild targeting the
2781         "Apply Configuration to XCFileLists" build target, which will then
2782         re-invoke our standalone script. The script is now running again, this
2783         time in an environment with all workspace, project, target, xcconfig
2784         and other environment variables established.
2785
2786         The "Apply Configuration to XCFileLists" build target accomplishes
2787         this task via a small embedded shell script that consists only of:
2788
2789             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2790
2791         The process that invokes "Apply Configuration to XCFileLists" first
2792         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2793         evaluated and exports it into the shell environment. When xcodebuild
2794         is invoked, it inherits the value of this variable and can `eval` the
2795         contents of that variable. Our external standalone script can then set
2796         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2797         of command-line parameters needed to restart itself in the appropriate
2798         state.
2799
2800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2801         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2802
2803 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2804
2805         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2806         https://bugs.webkit.org/show_bug.cgi?id=193802
2807         <rdar://problem/46010580>
2808
2809         Reviewed by Andy Estes.
2810
2811         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2812         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2813         (TEST):
2814
2815 2019-01-25  Daniel Bates  <dabates@apple.com>
2816
2817         [iOS] uiController.keyDown() does not translate Control modified key
2818         https://bugs.webkit.org/show_bug.cgi?id=192898
2819
2820         Reviewed by Wenson Hsieh.
2821
2822         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2823         key translation, as applicable. Among other cases, key translation occurs when performing
2824         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2825         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2826         human pressing down and releasing key(s) using a hardware keyboard.
2827
2828         * WebKitTestRunner/ios/HIDEventGenerator.h:
2829         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2830         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2831
2832         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2833         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2834         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2835         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2836         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2837         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2838         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2839         (-[HIDEventGenerator longPress:completionBlock:]):
2840         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2841         Update code for above renaming.
2842
2843         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2844         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2845
2846         (-[HIDEventGenerator keyDown:]): Added.
2847         (-[HIDEventGenerator keyUp:]): Added.
2848         (-[HIDEventGenerator keyPress:completionBlock:]):
2849         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2850         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2851         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2852         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2853         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2854         (WTR::parseModifier): Deleted.
2855
2856 2019-01-25  Keith Rollin  <krollin@apple.com>
2857
2858         Complete the implementation of generate-xcfilelists
2859         https://bugs.webkit.org/show_bug.cgi?id=193782
2860
2861         Reviewed by Alex Christensen.
2862
2863         A preliminary version of generate-xcfilelists was added in r238008.
2864         This patch updates that script in order to:
2865
2866         - Support checking of .xcfilelists
2867         - Perform better execution of `make DerivedSources.make` by
2868           relaunching generate-xcfilelists under xcodebuild
2869         - Support incremental generation and checking of .xcfilelists
2870         - Support supplementary .xcfilelists files from WebKitAdditions
2871         - Support being wrapped by parallel version of generate-xcfilelists in
2872           Internal that adds support for (re)generating WebKit projects in
2873           that repo.
2874         - Support builds that have been performed in WebKitBuild as well as
2875           ~/Library/Developer/code/DerivedData
2876         - Increase robustness and debugging facilities.
2877
2878         * Scripts/generate-xcfilelists:
2879
2880 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2881
2882         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2883         https://bugs.webkit.org/show_bug.cgi?id=193297
2884         <rdar://problem/47158841>
2885
2886         Unreviewed test case fix.
2887
2888         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2889         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2890
2891         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2892         (TEST):
2893
2894 2019-01-25  Keith Rollin  <krollin@apple.com>
2895
2896         Update existing .xcfilelists
2897         https://bugs.webkit.org/show_bug.cgi?id=193791
2898         <rdar://problem/47201706>
2899
2900         Reviewed by Alex Christensen.
2901
2902         Many .xcfilelist files were added in r238824 in order to support
2903         XCBuild. Update these with recent changes to the set of build files
2904         and with the current generate-xcfilelist script.
2905
2906         * DumpRenderTree/DerivedSources-input.xcfilelist:
2907         * DumpRenderTree/DerivedSources-output.xcfilelist:
2908         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2909         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2910
2911 2019-01-25  Keith Rollin  <krollin@apple.com>
2912
2913         Fix missing dependencies in extract-dependencies-from-makefile
2914         https://bugs.webkit.org/show_bug.cgi?id=193783
2915         <rdar://problem/47201571>
2916
2917         Reviewed by Alex Christensen.
2918
2919         The extract-dependencies-from-makefile script generates .xcfilelists
2920         for XCBuild by invoking a makefile in --debug mode, parsing the
2921         dependency information in the output, and extracting information
2922         regarding targets and dependents. However, the way `make` emits this
2923         dependency information is not rigorous, and so we need to determine
2924         what lines to look for and parse by trial and error. This approach
2925         didn't coriginally atch all the information we needed to collect, so
2926         update the script to look for the additional lines we now know to look
2927         for.
2928
2929         * Scripts/extract-dependencies-from-makefile:
2930         (Parser):
2931         (Parser.addTarget):
2932         (Parser.addPrereq):
2933         (Parser.doParse):
2934
2935 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2936
2937         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2938         https://bugs.webkit.org/show_bug.cgi?id=193297
2939         <rdar://problem/47158841>
2940
2941         Reviewed by Alex Christensen.
2942
2943         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2944             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2946         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2947         activating the message used to trigger the callback when it is set.
2948
2949 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2950
2951         WKWebView.goBack should reload if there is a safe browsing warning
2952         https://bugs.webkit.org/show_bug.cgi?id=193805
2953         <rdar://problem/46908216>
2954
2955         Reviewed by Geoff Garen.
2956
2957         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2958         (+[Simple3LookupContext sharedLookupContext]):
2959         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2960         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2961         (TEST):
2962
2963 2019-01-25  Chris Dumez  <cdumez@apple.com>
2964
2965         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2966         https://bugs.webkit.org/show_bug.cgi?id=193788
2967         <rdar://problem/47531231>
2968
2969         Reviewed by Alex Christensen.
2970
2971         Add API test coverage.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2974         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2975
2976 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2977
2978         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2979         https://bugs.webkit.org/show_bug.cgi?id=193771
2980
2981         Unreviewed infrastructure fix.
2982
2983         * Scripts/webkitpy/port/darwin.py:
2984         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2985
2986 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2987
2988         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2989
2990 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2991
2992         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2993
2994         * Scripts/webkitpy/common/config/contributors.json:
2995
2996 2019-01-25  Chris Dumez  <cdumez@apple.com>
2997
2998         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2999         https://bugs.webkit.org/show_bug.cgi?id=193779
3000         <rdar://problem/46170903>
3001
3002         Reviewed by Antti Koivisto.
3003
3004         Add API test that quickly navigates forward to a previous process without waiting for it to
3005         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3006         the process' previous page when reconnecting the it for the forward navigation.
3007
3008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3009
3010 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         Need a way for JavaScript (or bundle) code to participate in undo
3013         https://bugs.webkit.org/show_bug.cgi?id=190009
3014         <rdar://problem/44807048>
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3019         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3020
3021         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3022         (WTR::UIScriptController::lastUndoLabel const):
3023         (WTR::UIScriptController::firstRedoLabel const):
3024         (WTR::UIScriptController::platformUndoManager const):
3025         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3026         (WTR::UIScriptController::lastUndoLabel const):
3027         (WTR::UIScriptController::firstRedoLabel const):
3028         (WTR::UIScriptController::platformUndoManager const):
3029         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3030         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3031         (WTR::UIScriptController::lastUndoLabel const):
3032         (WTR::UIScriptController::firstRedoLabel const):
3033         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3034         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3035         (WTR::UIScriptController::lastUndoLabel const):
3036         (WTR::UIScriptController::firstRedoLabel const):
3037         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3038         (WTR::UIScriptController::platformUndoManager const):
3039         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3040         (WTR::UIScriptController::platformUndoManager const):
3041
3042 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3043
3044         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3045         https://bugs.webkit.org/show_bug.cgi?id=193824
3046
3047         Reviewed by Antti Koivisto.
3048
3049         * LayoutReloaded/misc/LFC-passing-tests.txt:
3050
3051 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3052
3053         Update macOS JSC bot configurations
3054         https://bugs.webkit.org/show_bug.cgi?id=193739
3055
3056         Reviewed by Alexey Proskuryakov.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3060         (BubbleQueueServer): Move JSC EWS to Mojave section.
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3062         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3063         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3064
3065 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3066
3067         [Win][WebKitTestRunner] Implement EventSenderProxy
3068         https://bugs.webkit.org/show_bug.cgi?id=193755
3069
3070         Reviewed by Don Olmstead.
3071
3072         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3073         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3074         (WTR::EventSenderProxy::dispatchMessage):
3075         (WTR::EventSenderProxy::EventSenderProxy):
3076         (WTR::EventSenderProxy::mouseDown):
3077         (WTR::EventSenderProxy::mouseUp):
3078         (WTR::EventSenderProxy::mouseMoveTo):
3079         (WTR::EventSenderProxy::mouseScrollBy):
3080         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3081
3082 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3083
3084         Unreviewed fix for API test failure after r240437.
3085
3086         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3087
3088         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3089
3090 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3091
3092         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3093         https://bugs.webkit.org/show_bug.cgi?id=193787
3094         <rdar://problem/47497634>
3095
3096         Reviewed by Alexey Proskuryakov.
3097
3098         * Scripts/webkitdirs.pm:
3099         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3100
3101 2019-01-24  Truitt Savell  <tsavell@apple.com>
3102
3103         Unreviewed, rolling out r240446.
3104
3105         Casued 5 API failures
3106
3107         Reverted changeset:
3108
3109         "Activate the WebResourceLoadStatisticsStore in the
3110         NetworkProcess and deactivate it in the UIProcess."
3111         https://bugs.webkit.org/show_bug.cgi?id=193297
3112         https://trac.webkit.org/changeset/240446
3113
3114 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3115
3116         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3117         https://bugs.webkit.org/show_bug.cgi?id=193741
3118         <rdar://problem/47135030>
3119
3120         Reviewed by Antti Koivisto and Simon Fraser.
3121
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3124         (TestWebKitAPI::TEST):
3125
3126 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3127
3128         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3129         https://bugs.webkit.org/show_bug.cgi?id=193297
3130         <rdar://problem/47158841>
3131
3132         Reviewed by Alex Christensen.
3133
3134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3135         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3136         activating the message used to trigger the callback when it is set.
3137
3138 2019-01-24  John Wilander  <wilander@apple.com>
3139
3140         Add Ad Click Attribution as an internal/experimental feature
3141         https://bugs.webkit.org/show_bug.cgi?id=193685
3142         <rdar://problem/47450399>
3143
3144         Reviewed by Brent Fulgham.
3145
3146         Added test option adClickAttributionEnabled.
3147
3148         * DumpRenderTree/TestOptions.cpp:
3149         (TestOptions::TestOptions):
3150         * DumpRenderTree/TestOptions.h:
3151         * DumpRenderTree/mac/DumpRenderTree.mm:
3152         (setWebPreferencesForTestOptions):
3153
3154 2019-01-24  Antti Koivisto  <antti@apple.com>
3155
3156         [PSON] Flash on back navigation on Mac
3157         https://bugs.webkit.org/show_bug.cgi?id=193716
3158         <rdar://problem/47148458>
3159
3160         Reviewed by Chris Dumez.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3163
3164         Closing of the previous page is delayed so waiting for didFinishNavigation is
3165         not sufficient to guarantee we have received all the messages. Wait for them.
3166
3167 2019-01-24  Chris Dumez  <cdumez@apple.com>
3168
3169         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3170         https://bugs.webkit.org/show_bug.cgi?id=193761
3171         <rdar://problem/47456405>
3172
3173         Reviewed by Alex Christensen.
3174
3175         Add API test coverage.
3176
3177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3178
3179 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3180
3181         webkitpy: Missing PID in crashlog name should not be fatal
3182         https://bugs.webkit.org/show_bug.cgi?id=193771
3183
3184         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3185         of raising an exception.
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * Scripts/webkitpy/port/darwin.py:
3190         (DarwinPort._merge_crash_logs):
3191
3192 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3193
3194         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3195         https://bugs.webkit.org/show_bug.cgi?id=193746
3196
3197         Reviewed by Youenn Fablet.
3198
3199         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3200         so we'd best just not call it.
3201
3202         * Scripts/webkitpy/w3c/test_exporter.py:
3203         (WebPlatformTestExporter.create_branch_with_patch):
3204
3205 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3206
3207         Move FileSystem to WTF
3208         https://bugs.webkit.org/show_bug.cgi?id=193602
3209
3210         Reviewed by Yusuke Suzuki.
3211
3212         * DumpRenderTree/win/DumpRenderTree.cpp:
3213         * TestWebKitAPI/CMakeLists.txt:
3214         * TestWebKitAPI/PlatformGTK.cmake:
3215         * TestWebKitAPI/PlatformJSCOnly.cmake:
3216         * TestWebKitAPI/PlatformPlayStation.cmake:
3217         * TestWebKitAPI/PlatformWPE.cmake:
3218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3219         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3220         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3221         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3222         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3223         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3224         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3225         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3226         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3227         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3228
3229 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3230
3231         [WPE] Remove hard dependency on subprocess32 for the API tests
3232
3233         Rubber-stamped by Carlos Garcia Campos.
3234
3235         * glib/api_test_runner.py:
3236         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3237         its presence only when running WPEQt tests.
3238
3239 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3240
3241         [GLIB] Expose JavaScriptCore options in GLib public API
3242         https://bugs.webkit.org/show_bug.cgi?id=188742
3243
3244         Reviewed by Michael Catanzaro.
3245
3246         Add a test for the new API.
3247
3248         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3249         (testsJSCOptions):
3250         (main):
3251
3252 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3253
3254         [GTK][WPE] Support JPEG 2000 images
3255         https://bugs.webkit.org/show_bug.cgi?id=186272
3256
3257         Reviewed by Žan Doberšek.
3258
3259         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3260
3261         * gtk/jhbuild.modules:
3262         * wpe/jhbuild.modules:
3263
3264 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3265
3266         check-webkit-style should warn when using soft-linking macros in a header
3267         <https://webkit.org/b/193750>
3268
3269         Reviewed by Darin Adler.
3270
3271         * Scripts/webkitpy/style/checkers/cpp.py:
3272         (check_language): Add softlink/header check by refactoring the
3273         softlink/framework check.
3274         (CppChecker): Enable softlink/header check by default.
3275         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3276         (CppStyleTest.test_softlink_framework): Rename from
3277         CppStyleTest.test_softlink() and change test framework name in
3278         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3279         files. Set file_name for macros that only appear in headers.
3280         (CppStyleTest.test_softlink_header): Add tests for using
3281         soft-link macros in headers.
3282
3283 2019-01-23  Chris Dumez  <cdumez@apple.com>
3284
3285         Deprecate API to limit the maximum number of WebProcesses
3286         https://bugs.webkit.org/show_bug.cgi?id=193725
3287         <rdar://problem/47464879>
3288
3289         Reviewed by Geoff Garen.
3290
3291         Update existing API tests to stop using deprecated API.
3292
3293         * MiniBrowser/mac/AppDelegate.m:
3294         (defaultConfiguration):
3295         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3296         (TestWebKitAPI::TEST):
3297         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3298         (TestWebKitAPI::TEST):
3299         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3300         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3301         (TEST):
3302         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3303         (TEST):
3304
3305 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [ews-app] Rename ews model buildermappings to buildermapping
3308         https://bugs.webkit.org/show_bug.cgi?id=193729
3309
3310         Reviewed by Lucas Forschler.
3311
3312         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3313         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3314         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3315
3316 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-app] Rename ews model steps to step
3319         https://bugs.webkit.org/show_bug.cgi?id=193697
3320
3321         Reviewed by Lucas Forschler.
3322
3323         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3324         (Step): Renamed Steps to Step.
3325
3326 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3327
3328         Clean up IndexedDB files between tests
3329         https://bugs.webkit.org/show_bug.cgi?id=192796
3330         <rdar://problem/46824999>
3331
3332         Reviewed by Geoffrey Garen.
3333
3334         * DumpRenderTree/mac/DumpRenderTree.mm:
3335         (runTest):
3336         * WebKitTestRunner/TestController.cpp:
3337         (WTR::TestController::resetStateToConsistentValues):
3338         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3339         (WTR::RemoveAllIndexedDatabasesCallback):
3340         (WTR::TestController::ClearIndexedDatabases):
3341         * WebKitTestRunner/TestController.h:
3342         * WebKitTestRunner/TestInvocation.cpp:
3343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3344
3345 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3346
3347         [ews-app] Rename ews model Builds to Build
3348         https://bugs.webkit.org/show_bug.cgi?id=193695
3349
3350         Reviewed by Lucas Forschler.
3351
3352         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3353         (Build): Renamed Builds to Build.
3354
3355 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3356
3357         webkitpy: Wait longer when launching WebKitTestRunner
3358         https://bugs.webkit.org/show_bug.cgi?id=193734
3359
3360         Reviewed by Aakash Jain.
3361
3362         * Scripts/webkitpy/port/simulator_process.py:
3363         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3364
3365 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3366
3367         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3368         https://bugs.webkit.org/show_bug.cgi?id=193182
3369         <rdar://problem/47452154>
3370
3371         Reviewed by Tim Horton.
3372
3373         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3374         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3375         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3376
3377         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3378         preventing later tests from recognizing gestures.
3379
3380         * WebKitTestRunner/ios/TestControllerIOS.mm:
3381         (WTR::TestController::platformResetStateToConsistentValues):
3382
3383         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3384
3385 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3386
3387         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3388         https://bugs.webkit.org/show_bug.cgi?id=193722
3389         <rdar://problem/47481475>
3390
3391         Reviewed by Lucas Forschler.
3392
3393         iPhone and iPad ports should both use the iOS config.
3394
3395         * Scripts/webkitpy/port/ios_simulator.py:
3396         (IPhoneSimulatorPort.__init__):
3397         (IPadSimulatorPort.__init__):
3398
3399 2019-01-23  Rob Buis  <rbuis@igalia.com>
3400
3401         Update MIME type parser
3402         https://bugs.webkit.org/show_bug.cgi?id=180526
3403
3404         Reviewed by Frédéric Wang.
3405
3406         Add unit tests for both parse modes of ParsedContentType.
3407
3408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3409         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3410         (TestWebKitAPI::TEST):
3411
3412 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3413
3414         [ews-app] fetch loop should not stop on network issues
3415         https://bugs.webkit.org/show_bug.cgi?id=193666
3416
3417         Reviewed by Lucas Forschler.
3418
3419         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3420         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3421
3422 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3423
3424         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3425         https://bugs.webkit.org/show_bug.cgi?id=189165
3426         <rdar://problem/47433765>
3427
3428         Reviewed by Tim Horton.
3429
3430         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3431         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3432         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3433         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3434         would make its way to the UI process by the time the layer tree commit is finished.
3435
3436         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3437         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3438         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3439         will fail because it asks for -_autofillContext too early.
3440
3441         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3442         is handled in the UI process.
3443
3444         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3445
3446         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3447         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3448         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3449         input session.
3450
3451         (-[AutofillTestView textInputHasAutofillContext]):
3452
3453         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3454
3455         * TestWebKitAPI/cocoa/TestWKWebView.h:
3456         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3457         (nextInputSessionChangeCount):
3458
3459         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3460         This includes changing the focused element from one to another.
3461
3462         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3463         (-[TestWKWebView didStartFormControlInteraction]):
3464         (-[TestWKWebView didEndFormControlInteraction]):
3465         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3466
3467         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3468         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3469         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3470         that doesn't require an input session to one that doesn't.
3471
3472 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3473
3474         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3475         <https://webkit.org/b/193676>
3476
3477         Reviewed by Alexey Proskuryakov.
3478
3479         * Scripts/webkitpy/style/checkers/cpp.py:
3480         (check_member_initialization_list):
3481         - Don't report missing whitespace around colon if the colon at
3482           the start of the line is formatted correctly.
3483         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3484         (WebKitStyleTest.test_member_initialization_list):
3485         - Add a test for a missing permutation of existing tests.
3486         - Add a test this false-positive.
3487         - Add blank lines between subtests to make them easier to read.
3488
3489 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [build.webkit.org] Unit-test failure after r237113
3492         https://bugs.webkit.org/show_bug.cgi?id=193669
3493
3494         Reviewed by Michael Catanzaro.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3497         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3498         multiple or zero flags.
3499
3500 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3501
3502         Cache bytecode to disk
3503         https://bugs.webkit.org/show_bug.cgi?id=192782
3504         <rdar://problem/46084932>
3505
3506         Reviewed by Keith Miller.
3507
3508         Add test helper to execute bytecode-cache tests: it executes each test
3509         twice, the first with JSC_diskCachePath set to a temporary directory
3510         and second with JSC_forceDiskCache=true (in addition to the cache path)
3511         to guarantee that only the disk cache is being used and no new
3512         UnlinkedCodeBlocks are being created.
3513
3514         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3515         * Scripts/run-jsc-stress-tests:
3516
3517 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3518
3519         [css-logical] Implement flow-relative margin, padding and border shorthands
3520         https://bugs.webkit.org/show_bug.cgi?id=188697
3521
3522         Reviewed by Simon Fraser and Antti Koivisto.
3523
3524         * DumpRenderTree/TestOptions.cpp:
3525         (TestOptions::TestOptions):
3526         * DumpRenderTree/TestOptions.h:
3527         * DumpRenderTree/mac/DumpRenderTree.mm:
3528         (setWebPreferencesForTestOptions):
3529         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3530
3531         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3532         (JSONCSSPropertiesChecker.check_codegen_properties):
3533         Allow CSS property definitions to have a 'runtime-flag' parameter which
3534         disables the property when the specified runtime flag is disabled.
3535
3536 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3537
3538         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3539         https://bugs.webkit.org/show_bug.cgi?id=193643
3540
3541         Reviewed by Michael Catanzaro.
3542
3543         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3544         * wpe/jhbuild.modules: Ditto.
3545
3546 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3547
3548         [LFC][Floats] Take float top position into account when computing containing block height.
3549         https://bugs.webkit.org/show_bug.cgi?id=193655
3550
3551         Reviewed by Antti Koivisto.
3552
3553         * LayoutReloaded/misc/LFC-passing-tests.txt:
3554
3555 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3556
3557         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3558         <https://webkit.org/b/193645>
3559         <rdar://problem/47421574>
3560
3561         Reviewed by Alex Christensen.
3562
3563         - Now checks for local soft-linking of all frameworks that have
3564           their own *SoftLinking.{cpp,h,mm} files.
3565         - Changes softlink/uikit warning to softlink/framework.
3566
3567         * Scripts/webkitpy/style/checkers/cpp.py:
3568         (check_language):
3569         (CppChecker):
3570         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3571         (CppStyleTest):
3572
3573 2019-01-20  Saam Barati  <sbarati@apple.com>
3574
3575         Rollout r240210: It broke tests on iOS
3576         https://bugs.webkit.org/show_bug.cgi?id=193640
3577
3578         Unreviewed.
3579
3580         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3581         * Scripts/run-jsc-stress-tests:
3582
3583 2019-01-20  chris fleizach  <cfleizach@apple.com>
3584
3585         AX: Support returning relative frames for accessibility
3586         https://bugs.webkit.org/show_bug.cgi?id=193414
3587         <rdar://problem/47268501>
3588
3589         Reviewed by Zalan Bujtas.
3590
3591         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3592         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3593         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3594         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3595         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3596         (WTR::attributesOfElement):
3597         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3598
3599 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3600
3601         Unreviewed, add my new email address
3602
3603         * Scripts/webkitpy/common/config/contributors.json:
3604
3605 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3606
3607         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3608         https://bugs.webkit.org/show_bug.cgi?id=193617
3609
3610         Reviewed by Antti Koivisto.
3611
3612         * LayoutReloaded/misc/LFC-passing-tests.txt:
3613
3614 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3615
3616         Unreviewed, rolling out r240209.
3617
3618         Broke GTK/WPE injected bundle
3619
3620         Reverted changeset:
3621
3622         "AX: Support returning relative frames for accessibility"
3623         https://bugs.webkit.org/show_bug.cgi?id=193414
3624         https://trac.webkit.org/changeset/240209
3625
3626 2019-01-12  Dan Bernstein  <mitz@apple.com>
3627
3628         [Cocoa] Avoid importing directly from subumbrella frameworks
3629         https://bugs.webkit.org/show_bug.cgi?id=186016
3630         <rdar://problem/40591038>
3631
3632         Reviewed by Sam Weinig.
3633
3634         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3635           LaunchServices header.
3636         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3637           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3638         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3639           when using SDKs earlier than 10.13.
3640         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3641           and OTHER_CPLUSPLUSFLAGS.
3642         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3643           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3644         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3645           LaunchServices header.
3646
3647 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3648
3649         Cache bytecode to disk
3650         https://bugs.webkit.org/show_bug.cgi?id=192782
3651         <rdar://problem/46084932>
3652
3653         Reviewed by Keith Miller.
3654
3655         Add test helper to execute bytecode-cache tests: it executes each test
3656         twice, the first with JSC_diskCachePath set to a temporary directory
3657         and second with JSC_forceDiskCache=true (in addition to the cache path)
3658         to guarantee that only the disk cache is being used and no new
3659         UnlinkedCodeBlocks are being created.
3660
3661         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3662         * Scripts/run-jsc-stress-tests:
3663
3664 2019-01-20  chris fleizach  <cfleizach@apple.com>
3665
3666         AX: Support returning relative frames for accessibility
3667         https://bugs.webkit.org/show_bug.cgi?id=193414
3668         <rdar://problem/47268501>
3669
3670         Reviewed by Zalan Bujtas.
3671
3672         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3673         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3674         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3675         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3676         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3677         (WTR::attributesOfElement):
3678         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3679
3680 2019-01-20  Antoine Quint  <graouts@apple.com>
3681
3682         Add a POINTER_EVENTS feature flag
3683         https://bugs.webkit.org/show_bug.cgi?id=193577
3684         <rdar://problem/47408511>
3685
3686         Unreviewed. Also enable Pointer Events for iosmac.
3687
3688         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3689
3690 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3691
3692         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3693         https://bugs.webkit.org/show_bug.cgi?id=193613
3694
3695         Reviewed by Antti Koivisto.
3696
3697         * LayoutReloaded/misc/LFC-passing-tests.txt:
3698
3699 2019-01-19  Antoine Quint  <graouts@apple.com>
3700
3701         Add a POINTER_EVENTS feature flag
3702         https://bugs.webkit.org/show_bug.cgi?id=193577
3703
3704         Reviewed by Dean Jackson.
3705
3706         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3707
3708 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3709
3710         Disable the run-jsc-stress-test remote host key check [second round].
3711         https://bugs.webkit.org/show_bug.cgi?id=192988
3712
3713         Reviewed by Dewei Zhu.
3714
3715         * Scripts/run-jsc-stress-tests:
3716
3717 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3718
3719         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3720         https://bugs.webkit.org/show_bug.cgi?id=193597
3721
3722         Reviewed by Lucas Forschler.
3723
3724         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3725
3726 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3727
3728         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3729         https://bugs.webkit.org/show_bug.cgi?id=193595
3730
3731         Reviewed by Lucas Forschler.
3732
3733         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3734         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3735         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3736
3737 2019-01-18  Chris Dumez  <cdumez@apple.com>
3738
3739         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3740         https://bugs.webkit.org/show_bug.cgi?id=193588
3741         <rdar://problem/47131566>
3742
3743         Reviewed by Alex Christensen.
3744
3745         Add layout test coverage.
3746
3747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3748
3749 2019-01-18  Jer Noble  <jer.noble@apple.com>
3750
3751         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3752         https://bugs.webkit.org/show_bug.cgi?id=189553
3753
3754         Reviewed by Tim Horton.
3755
3756         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3757
3758         * ContentExtensionTester/Configurations/Base.xcconfig:
3759         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3760         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3761         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3762         * ImageDiff/cg/Configurations/Base.xcconfig:
3763         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3764         * MiniBrowser/Configurations/Base.xcconfig:
3765         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3766         * MobileMiniBrowser/Configurations/Base.xcconfig:
3767         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3768         * Scripts/webkitpy/style/checker.py:
3769         (_all_categories):
3770         (FileType):
3771         (CheckerDispatcher._file_type):
3772         (CheckerDispatcher._create_checker):
3773         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3774         (SDKVariantChecker):
3775         (SDKVariantChecker.__init__):
3776         (SDKVariantChecker.check):
3777         * TestWebKitAPI/Configurations/Base.xcconfig:
3778         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3779         * WebEditingTester/Configurations/Base.xcconfig:
3780         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3781         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3782         * WebKitTestRunner/Configurations/Base.xcconfig:
3783         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3784         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3785         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3786
3787 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3788
3789         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3790         <https://webkit.org/b/193568>
3791         <rdar://problem/47381130>
3792
3793         Reviewed by Alex Christensen.
3794
3795         Make sure no one re-introduces UIKit soft-linking by adding a
3796         style rule.
3797
3798         * Scripts/webkitpy/style/checkers/cpp.py:
3799         (check_language): Add softlink/uikit check.
3800         (CppChecker): Enable softlink/uikit check.
3801         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3802         (CppStyleTest): Add test for softlink/uikit.
3803
3804 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3805
3806         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3807         https://bugs.webkit.org/show_bug.cgi?id=193584
3808
3809         Change "-dev" to "-devel".
3810
3811         Reviewed by Michael Catanzaro.
3812
3813         * gtk/install-dependencies:
3814
3815 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3816
3817         webkitpy: Add iPhone and iPad ports
3818         https://bugs.webkit.org/show_bug.cgi?id=193537
3819         <rdar://problem/47353390>
3820
3821         Reviewed by Lucas Forschler.
3822
3823         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3824         ports. Note that this separation is optional, the --ios-simulator command remains.
3825
3826         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3827         (RunTest.test_device_type_test_division): Drive-by fix.
3828         (RunTest.test_device_type_specific_listing): Ditto.
3829         (RunTest.test_ipad_test_division):
3830         (RunTest):
3831         (RunTest.test_ipad_listing):
3832         * Scripts/webkitpy/port/factory.py:
3833         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3834         (PortFactory):
3835         * Scripts/webkitpy/port/ios_simulator.py:
3836         (IPhoneSimulatorPort):
3837         (IPadSimulatorPort):
3838
3839 2019-01-18  Chris Dumez  <cdumez@apple.com>
3840
3841         Regression(PSON) Scroll position is not always restored properly when navigating back
3842         https://bugs.webkit.org/show_bug.cgi?id=193578
3843         <rdar://problem/47386331>
3844
3845         Reviewed by Tim Horton.
3846
3847         Add API test coverage.
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3850
3851 2019-01-18  Youenn Fablet  <youenn@apple.com>
3852
3853         Add a new SPI to request for cache storage quota increase
3854         https://bugs.webkit.org/show_bug.cgi?id=193323
3855
3856         Reviewed by Alex Christensen.
3857
3858         Implement WebsiteDataStore quota delegate to handle quota requests.
3859         By default, do not update quota.
3860         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3861
3862         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3864         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3865         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3866         * WebKitTestRunner/TestController.cpp:
3867         (WTR::TestController::allowCacheStorageQuotaIncrease):
3868         * WebKitTestRunner/TestController.h:
3869         * WebKitTestRunner/TestInvocation.cpp:
3870         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3871         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3872         (-[CacheStorageQuotaManager init]):
3873         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3874         (WTR::initializeWebViewConfiguration):
3875         (WTR::TestController::cocoaResetStateToConsistentValues):
3876         (WTR::TestController::allowCacheStorageQuotaIncrease):
3877
3878 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3879
3880         [ews-build] Pass owner to the triggered builds
3881         https://bugs.webkit.org/show_bug.cgi?id=193574
3882
3883         Reviewed by Lucas Forschler.
3884
3885         * BuildSlaveSupport/ews-build/factories.py:
3886         (BuildFactory.propertiesToPassToTriggers):
3887
3888 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3889
3890         [ews-app] Send patch author as a build property
3891         https://bugs.webkit.org/show_bug.cgi?id=193560
3892
3893         Reviewed by Lucas Forschler.
3894
3895         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3896         (BugzillaPatchFetcher.fetch):
3897
3898 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3899
3900         webkitpy: Implement device type specific expected results (Follow-up fix)
3901         https://bugs.webkit.org/show_bug.cgi?id=192162
3902         <rdar://problem/46345449>
3903
3904         Unreviewed infrastructure fix.
3905
3906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3907         (Manager.run): Don't boot a device if no tests are available to run on it.
3908
3909 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3910
3911         webkitpy: Implement device type specific expected results (Follow-up fix)
3912         https://bugs.webkit.org/show_bug.cgi?id=192162
3913         <rdar://problem/46345449>
3914
3915         Unreviewed infrastructure fix.
3916
3917         * Scripts/webkitpy/api_tests/manager.py:
3918         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3919
3920 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3921
3922         webkitpy: Implement device type specific expected results (Part 2)
3923         https://bugs.webkit.org/show_bug.cgi?id=192162
3924         <rdar://problem/46345449>
3925
3926         Rubber-stamped by Aakash Jain.
3927
3928         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3929         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3930         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3931
3932         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3933         (LayoutTestFinder.find_tests): Pass device_type through.
3934         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3935         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3936         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3937         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3938         (Manager._collect_tests): Pass device type to test finder.
3939         (Manager._needs_web_platform_test):
3940         (Manager._prepare_lists): Index _expectations by device type.
3941         (Manager._test_input_for_file):
3942         (Manager._test_is_slow): Ditto.
3943         (Manager._test_should_dump_jsconsolelog_in_stderr):
3944         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3945         (Manager._get_test_inputs):
3946         (Manager._update_worker_count):
3947         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3948         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3949         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3950         the one which runs the test.
3951         (Manager._run_test_subset):
3952         (Manager._run_tests): Index _expectations by current_device_type.
3953         (Manager._print_expectation_line_for_test): Ditto.
3954         (Manager._print_expectations_for_subset): Ditto.
3955         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3956         Unlike run, this function will behave the same regardless of what devices are available.
3957         (Manager._custom_device_for_test): Deleted.
3958         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3959         (ManagerTest.test_uses_custom_device): Deleted.
3960         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3961         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3962         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3963         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3964         all of the expectations.
3965         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3966         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3967         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3968         (TestExpectations.__init__): Allow device_type to be passed through.
3969         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3970         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3971         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3972         (summarize_results):
3973         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3974         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3975         a test ran with, one must check all expectations to find the first non-skip expectation.
3976         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3977         (RunTest.test_device_type_test_division):
3978         (RunTest):
3979         (RunTest.test_device_type_specific_listing):
3980         * Scripts/webkitpy/port/base.py:
3981         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3982         (Port.supported_device_types): The result of this function will change based on what devices are available.
3983         * Scripts/webkitpy/port/device_port.py:
3984         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3985         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3986         can be used.
3987         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3988         any, or the DEFAULT_DEVICE_TYPES of the port.
3989         * Scripts/webkitpy/port/ios.py:
3990         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3991         * Scripts/webkitpy/port/ios_simulator.py:
3992         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3993         * Scripts/webkitpy/port/watch.py:
3994         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3995         * Scripts/webkitpy/port/watch_simulator.py:
3996         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3997         * Scripts/webkitpy/xcode/device_type.py:
3998         (DeviceType):
3999         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
4000
4001 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4002
4003         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
4004         https://bugs.webkit.org/show_bug.cgi?id=193575
4005
4006         Reviewed by Michael Catanzaro.
4007
4008         Allow the script to run without explicit port argument because
4009         it's specific to the WPE port anyway.
4010
4011         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
4012         and simplify the rest of the code accordingly.
4013
4014 2019-01-18  Charlie Turner  <cturner@igalia.com>
4015
4016         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
4017         https://bugs.webkit.org/show_bug.cgi?id=192229
4018
4019         Reviewed by Xabier Rodriguez-Calvar.
4020
4021         * MiniBrowser/wpe/main.cpp:
4022         (main): Enable encrypted-media by default.
4023
4024 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4025
4026         [Flatpak] Missing KeyboardInterrupt exception handler
4027         https://bugs.webkit.org/show_bug.cgi?id=193570
4028
4029         Reviewed by Michael Catanzaro.
4030
4031         * flatpak/flatpakutils.py:
4032         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
4033
4034 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4035
4036         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
4037         https://bugs.webkit.org/show_bug.cgi?id=193564
4038
4039         Reviewed by Antti Koivisto.
4040
4041         * LayoutReloaded/misc/LFC-passing-tests.txt:
4042
4043 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4044
4045         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
4046         https://bugs.webkit.org/show_bug.cgi?id=193562
4047
4048         Reviewed by Antti Koivisto.
4049
4050         * LayoutReloaded/misc/LFC-passing-tests.txt:
4051
4052 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4053
4054         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
4055         https://bugs.webkit.org/show_bug.cgi?id=193555
4056
4057         Reviewed by Antti Koivisto.
4058
4059         * LayoutReloaded/misc/LFC-passing-tests.txt:
4060
4061 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4062
4063         [WPE] Add Qt extension
4064         https://bugs.webkit.org/show_bug.cgi?id=191464
4065
4066         Reviewed by Carlos Garcia Campos.
4067
4068         MiniBrowser and API tests for the WPE Qt API. To run the
4069         MiniBrowser a new script is introduced. Example invocation:
4070
4071         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
4072
4073         Also note-worthy is the introduction of the python2-subprocess32
4074         dependency to run the GLib API tests.
4075
4076         * MiniBrowser/wpe/CMakeLists.txt:
4077         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
4078         * MiniBrowser/wpe/qt/main.cpp: Added.
4079         (main):
4080         * MiniBrowser/wpe/qt/main.qml: Added.
4081         * MiniBrowser/wpe/qt/qml.qrc: Added.
4082         * Scripts/run-gtk-tests:
4083         (GtkTestRunner.is_google_test):
4084         (GtkTestRunner):
4085         (GtkTestRunner.is_qt_test):
4086         * Scripts/run-qt-wpe-minibrowser: Added.
4087         * Scripts/run-wpe-tests:
4088         (WPETestRunner):
4089         (WPETestRunner.is_google_test):
4090         (WPETestRunner.is_qt_test):
4091         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
4092         (TestLoad::main):
4093         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
4094         (TestLoadHtml::main):
4095         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
4096         (TestLoadRequest::main):
4097         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
4098         (TestRunJavaScript::main):
4099         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
4100         (waitForSignal):
4101         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
4102         (LoadSpy::LoadSpy):
4103         (LoadSpy::~LoadSpy):
4104         (LoadSpy::onLoadingChanged):
4105         (LoadStartedCatcher::LoadStartedCatcher):
4106         (LoadStartedCatcher::~LoadStartedCatcher):
4107         (LoadStartedCatcher::onLoadingChanged):
4108         (waitForLoadSucceeded):
4109         (waitForLoadFailed):
4110         * TestWebKitAPI/glib/CMakeLists.txt:
4111         * flatpak/flatpakutils.py:
4112         (WebkitFlatpak.load_from_args):
4113         (WebkitFlatpak.__init__):
4114         (WebkitFlatpak.clean_args):
4115         (WebkitFlatpak.run_in_sandbox):
4116         * flatpak/org.webkit.CommonModules.yaml:
4117         * flatpak/org.webkit.WPE.yaml:
4118         * flatpak/org.webkit.WPEModules.yaml:
4119         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
4120         * flatpak/org.webkit.WebKit.yaml:
4121         * glib/api_test_runner.py:
4122         (TestRunner._run_test_qt):
4123         (TestRunner.is_qt_test):
4124         (TestRunner._run_test):
4125
4126 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4127
4128         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
4129         https://bugs.webkit.org/show_bug.cgi?id=193494
4130         <rdar://problem/46859627>
4131
4132         Reviewed by Simon Fraser and Tim Horton.
4133
4134         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
4135         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
4136
4137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4138         (WTR::UIScriptController::contentOffsetX const):
4139         (WTR::UIScriptController::contentOffsetY const):
4140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4142         (WTR::UIScriptController::contentOffsetX const):
4143         (WTR::UIScriptController::contentOffsetY const):
4144         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4145
4146         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
4147
4148         * WebKitTestRunner/TestController.cpp:
4149         (WTR::updateTestOptionsFromTestHeader):
4150         * WebKitTestRunner/TestOptions.h:
4151         (WTR::TestOptions::hasSameInitializationOptions const):
4152         * WebKitTestRunner/ios/TestControllerIOS.mm:
4153         (WTR::TestController::platformResetStateToConsistentValues):
4154         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4155         (WTR::UIScriptController::contentOffsetX const):
4156         (WTR::UIScriptController::contentOffsetY const):
4157
4158 2019-01-17  Truitt Savell  <tsavell@apple.com>
4159
4160         Unreviewed, rolling out r240124.
4161
4162         This commit broke an internal build.
4163
4164         Reverted changeset:
4165
4166         "SDK_VARIANT build destinations should be separate from non-
4167         SDK_VARIANT builds"
4168         https://bugs.webkit.org/show_bug.cgi?id=189553
4169         https://trac.webkit.org/changeset/240124
4170
4171 2019-01-17  Alex Christensen  <achristensen@webkit.org>
4172
4173         Fix string concatenation API test after r239920
4174         https://bugs.webkit.org/show_bug.cgi?id=193551
4175         <rdar://problem/47359304>
4176
4177         Reviewed by Youenn Fablet.
4178
4179         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4180         (TestWebKitAPI::TEST):
4181         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
4182         in WebKit's build configuration like it apparently is on Linux.
4183
4184 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4185
4186         [ews-build] validate-patch should handle the case when bug_id is None
4187         https://bugs.webkit.org/show_bug.cgi?id=193547
4188
4189         Reviewed by Lucas Forschler.
4190
4191         * BuildSlaveSupport/ews-build/steps.py:
4192         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
4193         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
4194
4195 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4196
4197         [ews-build] Add patch author information in build
4198         https://bugs.webkit.org/show_bug.cgi?id=193465
4199
4200         Reviewed by Lucas Forschler.
4201
4202         * BuildSlaveSupport/ews-build/steps.py:
4203         (ValidatePatch._is_patch_obsolete):
4204
4205 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4206
4207         [ews-build] Pass bug_id to the triggered builds
4208         https://bugs.webkit.org/show_bug.cgi?id=193548
4209
4210         Reviewed by Lucas Forschler.
4211
4212         * BuildSlaveSupport/ews-build/factories.py:
4213         (BuildFactory.propertiesToPassToTriggers):
4214
4215 2019-01-17  Jer Noble  <jer.noble@apple.com>
4216
4217         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4218         https://bugs.webkit.org/show_bug.cgi?id=189553
4219
4220         Reviewed by Tim Horton.
4221
4222         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4223
4224         * ContentExtensionTester/Configurations/Base.xcconfig:
4225         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4226         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4227         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4228         * ImageDiff/cg/Configurations/Base.xcconfig:
4229         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4230         * MiniBrowser/Configurations/Base.xcconfig:
4231         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4232         * MobileMiniBrowser/Configurations/Base.xcconfig:
4233         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4234         * Scripts/webkitpy/style/checker.py:
4235         (_all_categories):
4236         (FileType):
4237         (CheckerDispatcher._file_type):
4238         (CheckerDispatcher._create_checker):
4239         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4240         (SDKVariantChecker):
4241         (SDKVariantChecker.__init__):
4242         (SDKVariantChecker.check):
4243         * TestWebKitAPI/Configurations/Base.xcconfig:
4244         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4245         * WebEditingTester/Configurations/Base.xcconfig:
4246         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4247         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4248         * WebKitTestRunner/Configurations/Base.xcconfig:
4249         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4250         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4251         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4252
4253 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4254
4255         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4256         https://bugs.webkit.org/show_bug.cgi?id=193534
4257
4258         Reviewed by Antti Koivisto.
4259
4260         * LayoutReloaded/misc/LFC-passing-tests.txt:
4261
4262 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4263
4264         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4265         https://bugs.webkit.org/show_bug.cgi?id=193528
4266
4267         Reviewed by Antti Koivisto.
4268
4269         * LayoutReloaded/misc/LFC-passing-tests.txt:
4270
4271 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4272
4273         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4274         https://bugs.webkit.org/show_bug.cgi?id=193520
4275
4276         Reviewed by Antti Koivisto.
4277
4278         * LayoutReloaded/misc/LFC-passing-tests.txt:
4279
4280 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4281
4282         [ews-build] unapply-patch step should not update source
4283         https://bugs.webkit.org/show_bug.cgi?id=193234
4284
4285         Reviewed by Lucas Forschler.
4286
4287         * BuildSlaveSupport/ews-build/steps.py:
4288         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4289         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4290
4291 2019-01-16  Youenn Fablet  <youenn@apple.com>
4292
4293         Add a new SPI for controlling getUserMedia
4294         https://bugs.webkit.org/show_bug.cgi?id=192793
4295
4296         Reviewed by Eric Carlson.
4297
4298         * MiniBrowser/mac/WK2BrowserWindowController.m:
4299         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4300         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4301         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4302         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4303         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4304         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4305         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4306         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4307         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4308         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4309         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4310         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4311         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4312         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4313
4314 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4315
4316         [LFC][BFC] Inflow non-replaced used width should not be negative.
4317         https://bugs.webkit.org/show_bug.cgi?id=193495
4318
4319         Reviewed by Antti Koivisto.
4320
4321         * LayoutReloaded/misc/LFC-passing-tests.txt:
4322
4323 2019-01-16  Chris Dumez  <cdumez@apple.com>
4324
4325         Regression(PSON) View becomes blank after click a cross-site download link
4326         https://bugs.webkit.org/show_bug.cgi?id=193361
4327         <rdar://problem/47099573>
4328
4329         Reviewed by Geoffrey Garen.
4330
4331         Add API test coverage.
4332
4333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4334         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4335
4336 2019-01-16  Zalan Bujtas  <zalan@apple.com>