[Mac] Update window scale API usage
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2
3         [Mac] Update window scale API usage
4         https://bugs.webkit.org/show_bug.cgi?id=193991
5         rdar://problem/47614795
6
7         Reviewed by Tim Horton.
8
9         * DumpRenderTree/mac/DumpRenderTree.mm:
10         (changeWindowScaleIfNeeded):
11         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
12         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
13         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
14
15 2019-01-29  Chris Dumez  <cdumez@apple.com>
16
17         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
18         https://bugs.webkit.org/show_bug.cgi?id=193977
19         <rdar://problem/47643716>
20
21         Reviewed by Geoff Garen.
22
23         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
24         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
25         to the previous provisional committing *before* we make the last load. 
26
27         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
28
29 2019-01-29  Youenn Fablet  <youenn@apple.com>
30
31         Adopt new SPI to evaluate server certificate trust
32         https://bugs.webkit.org/show_bug.cgi?id=193355
33
34         Reviewed by Alex Christensen.
35
36         Add infrastructure to handle HTTPS server trust evaluation testing.
37
38         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
39         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
40         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
41         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
42         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
43         * WebKitTestRunner/InjectedBundle/TestRunner.h:
44         * WebKitTestRunner/TestController.cpp:
45         (WTR::TestController::resetPreferencesToConsistentValues):
46         (WTR::TestController::didReceiveAuthenticationChallenge):
47         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
48         * WebKitTestRunner/TestController.h:
49         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
50         * WebKitTestRunner/TestInvocation.cpp:
51         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
52         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
53         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
54
55 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
56
57         [ews-build] Add build step to print bot Configuration
58         https://bugs.webkit.org/show_bug.cgi?id=193887
59
60         Reviewed by Lucas Forschler.
61
62         * BuildSlaveSupport/ews-build/steps.py:
63         (PrintConfiguration): Build step to print configuration.
64         * BuildSlaveSupport/ews-build/factories.py:
65
66 2019-01-29  Chris Dumez  <cdumez@apple.com>
67
68         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
69         https://bugs.webkit.org/show_bug.cgi?id=193967
70         <rdar://problem/47635348>
71
72         Reviewed by Alex Christensen.
73
74         Add API test coverage.
75
76         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
77         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
78
79 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-app] Handle incoming results data
82         https://bugs.webkit.org/show_bug.cgi?id=193973
83
84         Reviewed by Lucas Forschler.
85
86         * BuildSlaveSupport/ews-app/ews/views/results.py:
87
88 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
89
90         [ews-app] Make the results url generic
91         https://bugs.webkit.org/show_bug.cgi?id=193928
92
93         Reviewed by Lucas Forschler.
94
95         * BuildSlaveSupport/ews-app/ews/urls.py:
96
97 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
98
99         [ews-build] Configure buildbot to send events to ews-app
100         https://bugs.webkit.org/show_bug.cgi?id=193968
101
102         Reviewed by Lucas Forschler.
103
104         * BuildSlaveSupport/ews-build/events.py: Added.
105         * BuildSlaveSupport/ews-build/master.cfg:
106
107 2019-01-29  Keith Rollin  <krollin@apple.com>
108
109         Add .xcfilelists to Run Script build phases
110         https://bugs.webkit.org/show_bug.cgi?id=193792
111         <rdar://problem/47201785>
112
113         Reviewed by Alex Christensen.
114
115         As part of supporting XCBuild, update the necessary Run Script build
116         phases in their Xcode projects to refer to their associated
117         .xcfilelist files.
118
119         Note that the addition of these files bumps the Xcode project version
120         number to something that's Xcode 10 compatible. This change means that
121         older versions of the Xcode IDE can't read these projects. Nor can it
122         fully load workspaces that refer to these projects (the updated
123         projects are shown as non-expandable placeholders). `xcodebuild` can
124         still build these projects; it's just that the IDE can't open them.
125
126         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
127         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
128
129 2019-01-29  John Wilander  <wilander@apple.com>
130
131         Add data abstraction and validation for Ad Click Attribution
132         https://bugs.webkit.org/show_bug.cgi?id=193916
133         <rdar://problem/47603481>
134
135         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
136
137         Ad click attribution has two steps. First, the storage of an ad
138         campaign ID for a click that takes the user to a destination
139         site. Second, a conversion on the destination site that can be
140         attributed to the ad click.
141
142         This patch adds a class that represents a request for ad click
143         attribution. Validation makes sure that the bits of entropy
144         reported through this mechanism is limited.
145
146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
147         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
148         (TestWebKitAPI::TEST):
149
150 2019-01-29  Chris Dumez  <cdumez@apple.com>
151
152         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
153         https://bugs.webkit.org/show_bug.cgi?id=193932
154         <rdar://problem/47598947>
155
156         Reviewed by Brady Eidson.
157
158         Add API test coverage.
159
160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
161
162 2019-01-29  Zalan Bujtas  <zalan@apple.com>
163
164         Adding new passing LFC tests.
165
166         Unreviewed test gardening.
167
168         * LayoutReloaded/misc/LFC-passing-tests.txt:
169
170 2019-01-29  Zalan Bujtas  <zalan@apple.com>
171
172         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
173         https://bugs.webkit.org/show_bug.cgi?id=193964
174
175         Reviewed by Antti Koivisto.
176
177         * LayoutReloaded/misc/LFC-passing-tests.txt:
178
179 2019-01-29  Zalan Bujtas  <zalan@apple.com>
180
181         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
182         https://bugs.webkit.org/show_bug.cgi?id=193954
183
184         Reviewed by Antti Koivisto.
185
186         * LayoutReloaded/misc/LFC-passing-tests.txt:
187
188 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
189
190         WebDriver: add support for running subtests
191         https://bugs.webkit.org/show_bug.cgi?id=193904
192
193         Reviewed by Michael Catanzaro.
194
195         pytest already supports it by passing test.py::subtest, so we can do the same.
196
197         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
198         (get_item_name): Made this global.
199         (CollectRecorder.__init__): Receive the parameter to ignore.
200         (CollectRecorder.pytest_collectreport): Collect also the subtests.
201         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
202         (collect): Add parameter to ignore.
203         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
204         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
205         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
206         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
207         (WebDriverTestRunnerSelenium.run): Ditto.
208         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
209         (WebDriverTestRunnerW3C.collect_tests): Ditto.
210         (WebDriverTestRunnerW3C.run): Ditto.
211
212 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
213
214         User agent string override for navigator.userAgent should be site specific quirks
215         https://bugs.webkit.org/show_bug.cgi?id=193950
216
217         Reviewed by Brent Fulgham.
218
219         Updated per the _WKWebsitePolicies rename.
220
221         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
222         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
223
224 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
225
226         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
227         https://bugs.webkit.org/show_bug.cgi?id=193941
228
229         Reviewed by Alex Christensen.
230
231         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
232         * TestWebKitAPI/Tests/WTF/Condition.cpp:
233         * TestWebKitAPI/Tests/WTF/Lock.cpp:
234         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
235         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
236         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
237         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
238         * TestWebKitAPI/Tests/WTF/Time.cpp:
239         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
240         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
241         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
242         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
243
244 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
245
246         Unreviewed, reorder my emails to fix autocomplete in bugzilla
247
248         * Scripts/webkitpy/common/config/contributors.json:
249
250 2019-01-28  Andy Estes  <aestes@apple.com>
251
252         [watchOS] Enable Parental Controls content filtering
253         https://bugs.webkit.org/show_bug.cgi?id=193939
254         <rdar://problem/46641912>
255
256         Reviewed by Ryosuke Niwa.
257
258         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
259
260 2019-01-28  David Kilzer  <ddkilzer@apple.com>
261
262         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
263         <https://webkit.org/b/193884>
264
265         Reviewed by Jiewen Tan.
266
267         * Scripts/webkitpy/style/checkers/cpp.py:
268         (check_language): Add LocalAuthentication to
269         `frameworks_with_soft_links`.
270
271 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
272
273         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
274         https://bugs.webkit.org/show_bug.cgi?id=193891
275
276         Reviewed by Ross Kirsling.
277
278         There were three problems in window sizes of WebView and the host window.
279         1. The sizes of pixel image output were incorrect.
280         2. The host window is going to appear after window.resize was invoked.
281         3. window.resize resized only the host window, not WebView.
282
283         This change solves them with a following approach.
284         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
285         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
286            as well as DumpRenderTree in order to match the client area and the window area.
287         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
288         d. PlatformWebView::setWindowFrame changes both window sizes.
289         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
290
291         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
292         (WTR::PlatformWebView::PlatformWebView): Create the host window
293         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
294         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
295         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
296
297 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
298
299         [ews-app] Add method to save Step data to database
300         https://bugs.webkit.org/show_bug.cgi?id=193890
301
302         Reviewed by Lucas Forschler.
303
304         * BuildSlaveSupport/ews-app/ews/models/step.py:
305         (Step.save_step): Method to save step data.
306         (Step.update_step): Method to update step data.
307         (Step.get_existing_step): Method to fetch existing step from database.
308         (Step.is_valid_result): Method to validate valid step result.
309
310 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
311
312         [ews-app] Add method to save Build data to database
313         https://bugs.webkit.org/show_bug.cgi?id=193735
314
315         Reviewed by Lucas Forschler.
316
317         * BuildSlaveSupport/ews-app/ews/models/build.py:
318         (Build.save_build): Method to save build information to database.
319         (Build.get_existing_build): Method to fetch existing build from database.
320         (Build.is_valid_result): Method to validate build result.
321         * BuildSlaveSupport/ews-app/ews/common/util.py:
322         (is_valid_int_id): Method to validate valid id.
323
324 2019-01-28  Chris Dumez  <cdumez@apple.com>
325
326         Regression(PSON) Crash under WebPageProxy::didStartProgress()
327         https://bugs.webkit.org/show_bug.cgi?id=193915
328         <rdar://problem/47560907>
329
330         Reviewed by Alex Christensen.
331
332         Add API test coverage.
333
334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
335
336 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
337
338         [ews-app] Rename id variables
339         https://bugs.webkit.org/show_bug.cgi?id=193883
340
341         Reviewed by Lucas Forschler.
342
343         * BuildSlaveSupport/ews-app/ews/models/build.py:
344         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
345         * BuildSlaveSupport/ews-app/ews/models/step.py:
346         * BuildSlaveSupport/ews-app/ews/urls.py:
347         * BuildSlaveSupport/ews-app/ews/views/patch.py:
348         * BuildSlaveSupport/ews-app/ews/views/results.py:
349         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
350
351 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-app] Allow certain fields to be empty
354         https://bugs.webkit.org/show_bug.cgi?id=193892
355
356         Reviewed by Lucas Forschler.
357
358         * BuildSlaveSupport/ews-app/ews/models/build.py:
359         * BuildSlaveSupport/ews-app/ews/models/step.py:
360
361 2019-01-28  Rob Buis  <rbuis@igalia.com>
362
363         Update MIME type parser
364         https://bugs.webkit.org/show_bug.cgi?id=180526
365
366         Reviewed by Frédéric Wang.
367
368         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
369         (TestWebKitAPI::TEST):
370
371 2019-01-28  Zalan Bujtas  <zalan@apple.com>
372
373         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
374         https://bugs.webkit.org/show_bug.cgi?id=193896
375
376         Reviewed by Antti Koivisto.
377
378         * LayoutReloaded/misc/LFC-passing-tests.txt:
379
380 2018-12-15  Darin Adler  <darin@apple.com>
381
382         Replace many uses of String::format with more type-safe alternatives
383         https://bugs.webkit.org/show_bug.cgi?id=192742
384
385         Reviewed by Mark Lam.
386
387         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
388         (WTR::cacheTestRunnerCallback): Use makeString.
389         * WebKitTestRunner/TestController.cpp:
390         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
391         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
392
393 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
394
395         Use a load optimizer for some sites
396         https://bugs.webkit.org/show_bug.cgi?id=193881
397         <rdar://problem/46325455>
398
399         Reviewed by Brent Fulgham.
400
401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
402         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
403
404 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
405
406         AX: Introduce a static accessibility tree
407         https://bugs.webkit.org/show_bug.cgi?id=193348
408         <rdar://problem/47203295>
409
410         Reviewed by Ryosuke Niwa.
411
412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
413
414 2019-01-26  Zalan Bujtas  <zalan@apple.com>
415
416         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
417         https://bugs.webkit.org/show_bug.cgi?id=193867
418
419         Reviewed by Antti Koivisto.
420
421         * LayoutReloaded/misc/LFC-passing-tests.txt:
422
423 2019-01-26  Zalan Bujtas  <zalan@apple.com>
424
425         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
426         https://bugs.webkit.org/show_bug.cgi?id=193865
427
428         Reviewed by Antti Koivisto.
429
430         * LayoutReloaded/misc/LFC-passing-tests.txt:
431
432 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
433
434         Need a mechanism to override navigator.userAgent
435         https://bugs.webkit.org/show_bug.cgi?id=193762
436         <rdar://problem/47504939>
437
438         Reviewed by Brent Fulgham.
439
440         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
441
442         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
443         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
444         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
445
446 2019-01-25  Dean Jackson  <dino@apple.com>
447
448         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
449         https://bugs.webkit.org/show_bug.cgi?id=193831
450         <rdar://problem/47399263>
451
452         Reviewed by Chris Dumez.
453
454         Two new tests that exercise cross-origin and same-origin System
455         Previews.
456
457         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
458
459 2019-01-25  Keith Rollin  <krollin@apple.com>
460
461         Update Xcode projects with "Check .xcfilelists" build phase
462         https://bugs.webkit.org/show_bug.cgi?id=193790
463         <rdar://problem/47201374>
464
465         Reviewed by Alex Christensen.
466
467         Support for XCBuild includes specifying inputs and outputs to various
468         Run Script build phases. These inputs and outputs are specified as
469         .xcfilelist files. Once created, these .xcfilelist files need to be
470         kept up-to-date. In order to check that they are up-to-date or not,
471         add an Xcode build step that invokes an external script that performs
472         the checking. If the .xcfilelists are found to be out-of-date, update
473         them, halt the build, and instruct the developer to restart the build
474         with up-to-date files.
475
476         At this time, the checking and regenerating is performed only if the
477         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
478         who want to use this facility can set this variable and test out the
479         checking/regenerating. Once it seems like there are no egregious
480         issues that upset a developer's workflow, we'll unconditionally enable
481         this facility.
482
483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
484         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
485         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
486         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
487
488 2019-01-25  Keith Rollin  <krollin@apple.com>
489
490         Update Xcode projects with "Apply Configuration to XCFileLists" build target
491         https://bugs.webkit.org/show_bug.cgi?id=193781
492         <rdar://problem/47201153>
493
494         Reviewed by Alex Christensen.
495
496         Part of generating the .xcfilelists used as part of adopting XCBuild
497         includes running `make DerivedSources.make` from a standalone script.
498         It’s important for this invocation to have the same environment as
499         when the actual build invokes `make DerivedSources.make`. If the
500         environments are different, then the two invocations will provide
501         different results. In order to get the same environment in the
502         standalone script, have the script launch xcodebuild targeting the
503         "Apply Configuration to XCFileLists" build target, which will then
504         re-invoke our standalone script. The script is now running again, this
505         time in an environment with all workspace, project, target, xcconfig
506         and other environment variables established.
507
508         The "Apply Configuration to XCFileLists" build target accomplishes
509         this task via a small embedded shell script that consists only of:
510
511             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
512
513         The process that invokes "Apply Configuration to XCFileLists" first
514         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
515         evaluated and exports it into the shell environment. When xcodebuild
516         is invoked, it inherits the value of this variable and can `eval` the
517         contents of that variable. Our external standalone script can then set
518         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
519         of command-line parameters needed to restart itself in the appropriate
520         state.
521
522         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
523         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
524
525 2019-01-25  Alex Christensen  <achristensen@webkit.org>
526
527         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
528         https://bugs.webkit.org/show_bug.cgi?id=193802
529         <rdar://problem/46010580>
530
531         Reviewed by Andy Estes.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
534         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
535         (TEST):
536
537 2019-01-25  Daniel Bates  <dabates@apple.com>
538
539         [iOS] uiController.keyDown() does not translate Control modified key
540         https://bugs.webkit.org/show_bug.cgi?id=192898
541
542         Reviewed by Wenson Hsieh.
543
544         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
545         key translation, as applicable. Among other cases, key translation occurs when performing
546         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
547         also makes the behavior of uiController.keyDown() more closely match the behavior of a
548         human pressing down and releasing key(s) using a hardware keyboard.
549
550         * WebKitTestRunner/ios/HIDEventGenerator.h:
551         * WebKitTestRunner/ios/HIDEventGenerator.mm:
552         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
553
554         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
555         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
556         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
557         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
558         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
559         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
560         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
561         (-[HIDEventGenerator longPress:completionBlock:]):
562         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
563         Update code for above renaming.
564
565         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
566         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
567
568         (-[HIDEventGenerator keyDown:]): Added.
569         (-[HIDEventGenerator keyUp:]): Added.
570         (-[HIDEventGenerator keyPress:completionBlock:]):
571         (-[HIDEventGenerator eventDispatchThreadEntry:]):
572         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
573         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
574         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
575         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
576         (WTR::parseModifier): Deleted.
577
578 2019-01-25  Keith Rollin  <krollin@apple.com>
579
580         Complete the implementation of generate-xcfilelists
581         https://bugs.webkit.org/show_bug.cgi?id=193782
582
583         Reviewed by Alex Christensen.
584
585         A preliminary version of generate-xcfilelists was added in r238008.
586         This patch updates that script in order to:
587
588         - Support checking of .xcfilelists
589         - Perform better execution of `make DerivedSources.make` by
590           relaunching generate-xcfilelists under xcodebuild
591         - Support incremental generation and checking of .xcfilelists
592         - Support supplementary .xcfilelists files from WebKitAdditions
593         - Support being wrapped by parallel version of generate-xcfilelists in
594           Internal that adds support for (re)generating WebKit projects in
595           that repo.
596         - Support builds that have been performed in WebKitBuild as well as
597           ~/Library/Developer/code/DerivedData
598         - Increase robustness and debugging facilities.
599
600         * Scripts/generate-xcfilelists:
601
602 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
603
604         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
605         https://bugs.webkit.org/show_bug.cgi?id=193297
606         <rdar://problem/47158841>
607
608         Unreviewed test case fix.
609
610         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
611         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
614         (TEST):
615
616 2019-01-25  Keith Rollin  <krollin@apple.com>
617
618         Update existing .xcfilelists
619         https://bugs.webkit.org/show_bug.cgi?id=193791
620         <rdar://problem/47201706>
621
622         Reviewed by Alex Christensen.
623
624         Many .xcfilelist files were added in r238824 in order to support
625         XCBuild. Update these with recent changes to the set of build files
626         and with the current generate-xcfilelist script.
627
628         * DumpRenderTree/DerivedSources-input.xcfilelist:
629         * DumpRenderTree/DerivedSources-output.xcfilelist:
630         * WebKitTestRunner/DerivedSources-input.xcfilelist:
631         * WebKitTestRunner/DerivedSources-output.xcfilelist:
632
633 2019-01-25  Keith Rollin  <krollin@apple.com>
634
635         Fix missing dependencies in extract-dependencies-from-makefile
636         https://bugs.webkit.org/show_bug.cgi?id=193783
637         <rdar://problem/47201571>
638
639         Reviewed by Alex Christensen.
640
641         The extract-dependencies-from-makefile script generates .xcfilelists
642         for XCBuild by invoking a makefile in --debug mode, parsing the
643         dependency information in the output, and extracting information
644         regarding targets and dependents. However, the way `make` emits this
645         dependency information is not rigorous, and so we need to determine
646         what lines to look for and parse by trial and error. This approach
647         didn't coriginally atch all the information we needed to collect, so
648         update the script to look for the additional lines we now know to look
649         for.
650
651         * Scripts/extract-dependencies-from-makefile:
652         (Parser):
653         (Parser.addTarget):
654         (Parser.addPrereq):
655         (Parser.doParse):
656
657 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
658
659         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
660         https://bugs.webkit.org/show_bug.cgi?id=193297
661         <rdar://problem/47158841>
662
663         Reviewed by Alex Christensen.
664
665         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
666             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
668         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
669         activating the message used to trigger the callback when it is set.
670
671 2019-01-25  Alex Christensen  <achristensen@webkit.org>
672
673         WKWebView.goBack should reload if there is a safe browsing warning
674         https://bugs.webkit.org/show_bug.cgi?id=193805
675         <rdar://problem/46908216>
676
677         Reviewed by Geoff Garen.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
680         (+[Simple3LookupContext sharedLookupContext]):
681         (-[Simple3LookupContext lookUpURL:completionHandler:]):
682         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
683         (TEST):
684
685 2019-01-25  Chris Dumez  <cdumez@apple.com>
686
687         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
688         https://bugs.webkit.org/show_bug.cgi?id=193788
689         <rdar://problem/47531231>
690
691         Reviewed by Alex Christensen.
692
693         Add API test coverage.
694
695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
696         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
697
698 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
699
700         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
701         https://bugs.webkit.org/show_bug.cgi?id=193771
702
703         Unreviewed infrastructure fix.
704
705         * Scripts/webkitpy/port/darwin.py:
706         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
707
708 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
709
710         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
711
712 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
713
714         Add contributors.json entries for Ling Ho and for a new bot watchers group.
715
716         * Scripts/webkitpy/common/config/contributors.json:
717
718 2019-01-25  Chris Dumez  <cdumez@apple.com>
719
720         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
721         https://bugs.webkit.org/show_bug.cgi?id=193779
722         <rdar://problem/46170903>
723
724         Reviewed by Antti Koivisto.
725
726         Add API test that quickly navigates forward to a previous process without waiting for it to
727         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
728         the process' previous page when reconnecting the it for the forward navigation.
729
730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
731
732 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
733
734         Need a way for JavaScript (or bundle) code to participate in undo
735         https://bugs.webkit.org/show_bug.cgi?id=190009
736         <rdar://problem/44807048>
737
738         Reviewed by Ryosuke Niwa.
739
740         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
741         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
742
743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
744         (WTR::UIScriptController::lastUndoLabel const):
745         (WTR::UIScriptController::firstRedoLabel const):
746         (WTR::UIScriptController::platformUndoManager const):
747         * DumpRenderTree/mac/UIScriptControllerMac.mm:
748         (WTR::UIScriptController::lastUndoLabel const):
749         (WTR::UIScriptController::firstRedoLabel const):
750         (WTR::UIScriptController::platformUndoManager const):
751         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
752         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
753         (WTR::UIScriptController::lastUndoLabel const):
754         (WTR::UIScriptController::firstRedoLabel const):
755         * TestRunnerShared/UIScriptContext/UIScriptController.h:
756         * WebKitTestRunner/UIScriptControllerCocoa.mm:
757         (WTR::UIScriptController::lastUndoLabel const):
758         (WTR::UIScriptController::firstRedoLabel const):
759         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
760         (WTR::UIScriptController::platformUndoManager const):
761         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
762         (WTR::UIScriptController::platformUndoManager const):
763
764 2019-01-25  Zalan Bujtas  <zalan@apple.com>
765
766         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
767         https://bugs.webkit.org/show_bug.cgi?id=193824
768
769         Reviewed by Antti Koivisto.
770
771         * LayoutReloaded/misc/LFC-passing-tests.txt:
772
773 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
774
775         Update macOS JSC bot configurations
776         https://bugs.webkit.org/show_bug.cgi?id=193739
777
778         Reviewed by Alexey Proskuryakov.
779
780         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
782         (BubbleQueueServer): Move JSC EWS to Mojave section.
783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
784         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
785         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
786
787 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
788
789         [Win][WebKitTestRunner] Implement EventSenderProxy
790         https://bugs.webkit.org/show_bug.cgi?id=193755
791
792         Reviewed by Don Olmstead.
793
794         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
795         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
796         (WTR::EventSenderProxy::dispatchMessage):
797         (WTR::EventSenderProxy::EventSenderProxy):
798         (WTR::EventSenderProxy::mouseDown):
799         (WTR::EventSenderProxy::mouseUp):
800         (WTR::EventSenderProxy::mouseMoveTo):
801         (WTR::EventSenderProxy::mouseScrollBy):
802         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
803
804 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
805
806         Unreviewed fix for API test failure after r240437.
807
808         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
809
810         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
811
812 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
813
814         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
815         https://bugs.webkit.org/show_bug.cgi?id=193787
816         <rdar://problem/47497634>
817
818         Reviewed by Alexey Proskuryakov.
819
820         * Scripts/webkitdirs.pm:
821         (iosSimulatorApplicationsPath): Pick from available runtime directories.
822
823 2019-01-24  Truitt Savell  <tsavell@apple.com>
824
825         Unreviewed, rolling out r240446.
826
827         Casued 5 API failures
828
829         Reverted changeset:
830
831         "Activate the WebResourceLoadStatisticsStore in the
832         NetworkProcess and deactivate it in the UIProcess."
833         https://bugs.webkit.org/show_bug.cgi?id=193297
834         https://trac.webkit.org/changeset/240446
835
836 2019-01-24  Zalan Bujtas  <zalan@apple.com>
837
838         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
839         https://bugs.webkit.org/show_bug.cgi?id=193741
840         <rdar://problem/47135030>
841
842         Reviewed by Antti Koivisto and Simon Fraser.
843
844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
845         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
846         (TestWebKitAPI::TEST):
847
848 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
849
850         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
851         https://bugs.webkit.org/show_bug.cgi?id=193297
852         <rdar://problem/47158841>
853
854         Reviewed by Alex Christensen.
855
856         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
857         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
858         activating the message used to trigger the callback when it is set.
859
860 2019-01-24  John Wilander  <wilander@apple.com>
861
862         Add Ad Click Attribution as an internal/experimental feature
863         https://bugs.webkit.org/show_bug.cgi?id=193685
864         <rdar://problem/47450399>
865
866         Reviewed by Brent Fulgham.
867
868         Added test option adClickAttributionEnabled.
869
870         * DumpRenderTree/TestOptions.cpp:
871         (TestOptions::TestOptions):
872         * DumpRenderTree/TestOptions.h:
873         * DumpRenderTree/mac/DumpRenderTree.mm:
874         (setWebPreferencesForTestOptions):
875
876 2019-01-24  Antti Koivisto  <antti@apple.com>
877
878         [PSON] Flash on back navigation on Mac
879         https://bugs.webkit.org/show_bug.cgi?id=193716
880         <rdar://problem/47148458>
881
882         Reviewed by Chris Dumez.
883
884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
885
886         Closing of the previous page is delayed so waiting for didFinishNavigation is
887         not sufficient to guarantee we have received all the messages. Wait for them.
888
889 2019-01-24  Chris Dumez  <cdumez@apple.com>
890
891         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
892         https://bugs.webkit.org/show_bug.cgi?id=193761
893         <rdar://problem/47456405>
894
895         Reviewed by Alex Christensen.
896
897         Add API test coverage.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
900
901 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
902
903         webkitpy: Missing PID in crashlog name should not be fatal
904         https://bugs.webkit.org/show_bug.cgi?id=193771
905
906         If we can't determine the PID of a crashlog, just ignore the crashlog instead
907         of raising an exception.
908
909         Reviewed by Lucas Forschler.
910
911         * Scripts/webkitpy/port/darwin.py:
912         (DarwinPort._merge_crash_logs):
913
914 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
915
916         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
917         https://bugs.webkit.org/show_bug.cgi?id=193746
918
919         Reviewed by Youenn Fablet.
920
921         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
922         so we'd best just not call it.
923
924         * Scripts/webkitpy/w3c/test_exporter.py:
925         (WebPlatformTestExporter.create_branch_with_patch):
926
927 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
928
929         Move FileSystem to WTF
930         https://bugs.webkit.org/show_bug.cgi?id=193602
931
932         Reviewed by Yusuke Suzuki.
933
934         * DumpRenderTree/win/DumpRenderTree.cpp:
935         * TestWebKitAPI/CMakeLists.txt:
936         * TestWebKitAPI/PlatformGTK.cmake:
937         * TestWebKitAPI/PlatformJSCOnly.cmake:
938         * TestWebKitAPI/PlatformPlayStation.cmake:
939         * TestWebKitAPI/PlatformWPE.cmake:
940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
941         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
942         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
943         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
944         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
945         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
946         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
947         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
948         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
949         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
950
951 2019-01-24  Philippe Normand  <pnormand@igalia.com>
952
953         [WPE] Remove hard dependency on subprocess32 for the API tests
954
955         Rubber-stamped by Carlos Garcia Campos.
956
957         * glib/api_test_runner.py:
958         (TestRunner._run_test_qt): Lazily import subprocess32 and check
959         its presence only when running WPEQt tests.
960
961 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
962
963         [GLIB] Expose JavaScriptCore options in GLib public API
964         https://bugs.webkit.org/show_bug.cgi?id=188742
965
966         Reviewed by Michael Catanzaro.
967
968         Add a test for the new API.
969
970         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
971         (testsJSCOptions):
972         (main):
973
974 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
975
976         [GTK][WPE] Support JPEG 2000 images
977         https://bugs.webkit.org/show_bug.cgi?id=186272
978
979         Reviewed by Žan Doberšek.
980
981         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
982
983         * gtk/jhbuild.modules:
984         * wpe/jhbuild.modules:
985
986 2019-01-23  David Kilzer  <ddkilzer@apple.com>
987
988         check-webkit-style should warn when using soft-linking macros in a header
989         <https://webkit.org/b/193750>
990
991         Reviewed by Darin Adler.
992
993         * Scripts/webkitpy/style/checkers/cpp.py:
994         (check_language): Add softlink/header check by refactoring the
995         softlink/framework check.
996         (CppChecker): Enable softlink/header check by default.
997         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
998         (CppStyleTest.test_softlink_framework): Rename from
999         CppStyleTest.test_softlink() and change test framework name in
1000         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1001         files. Set file_name for macros that only appear in headers.
1002         (CppStyleTest.test_softlink_header): Add tests for using
1003         soft-link macros in headers.
1004
1005 2019-01-23  Chris Dumez  <cdumez@apple.com>
1006
1007         Deprecate API to limit the maximum number of WebProcesses
1008         https://bugs.webkit.org/show_bug.cgi?id=193725
1009         <rdar://problem/47464879>
1010
1011         Reviewed by Geoff Garen.
1012
1013         Update existing API tests to stop using deprecated API.
1014
1015         * MiniBrowser/mac/AppDelegate.m:
1016         (defaultConfiguration):
1017         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1022         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1023         (TEST):
1024         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1025         (TEST):
1026
1027 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1028
1029         [ews-app] Rename ews model buildermappings to buildermapping
1030         https://bugs.webkit.org/show_bug.cgi?id=193729
1031
1032         Reviewed by Lucas Forschler.
1033
1034         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1035         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1036         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1037
1038 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews-app] Rename ews model steps to step
1041         https://bugs.webkit.org/show_bug.cgi?id=193697
1042
1043         Reviewed by Lucas Forschler.
1044
1045         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1046         (Step): Renamed Steps to Step.
1047
1048 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1049
1050         Clean up IndexedDB files between tests
1051         https://bugs.webkit.org/show_bug.cgi?id=192796
1052         <rdar://problem/46824999>
1053
1054         Reviewed by Geoffrey Garen.
1055
1056         * DumpRenderTree/mac/DumpRenderTree.mm:
1057         (runTest):
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::TestController::resetStateToConsistentValues):
1060         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1061         (WTR::RemoveAllIndexedDatabasesCallback):
1062         (WTR::TestController::ClearIndexedDatabases):
1063         * WebKitTestRunner/TestController.h:
1064         * WebKitTestRunner/TestInvocation.cpp:
1065         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1066
1067 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1068
1069         [ews-app] Rename ews model Builds to Build
1070         https://bugs.webkit.org/show_bug.cgi?id=193695
1071
1072         Reviewed by Lucas Forschler.
1073
1074         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1075         (Build): Renamed Builds to Build.
1076
1077 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1078
1079         webkitpy: Wait longer when launching WebKitTestRunner
1080         https://bugs.webkit.org/show_bug.cgi?id=193734
1081
1082         Reviewed by Aakash Jain.
1083
1084         * Scripts/webkitpy/port/simulator_process.py:
1085         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1086
1087 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1088
1089         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1090         https://bugs.webkit.org/show_bug.cgi?id=193182
1091         <rdar://problem/47452154>
1092
1093         Reviewed by Tim Horton.
1094
1095         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1096         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1097         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1098
1099         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1100         preventing later tests from recognizing gestures.
1101
1102         * WebKitTestRunner/ios/TestControllerIOS.mm:
1103         (WTR::TestController::platformResetStateToConsistentValues):
1104
1105         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1106
1107 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1108
1109         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1110         https://bugs.webkit.org/show_bug.cgi?id=193722
1111         <rdar://problem/47481475>
1112
1113         Reviewed by Lucas Forschler.
1114
1115         iPhone and iPad ports should both use the iOS config.
1116
1117         * Scripts/webkitpy/port/ios_simulator.py:
1118         (IPhoneSimulatorPort.__init__):
1119         (IPadSimulatorPort.__init__):
1120
1121 2019-01-23  Rob Buis  <rbuis@igalia.com>
1122
1123         Update MIME type parser
1124         https://bugs.webkit.org/show_bug.cgi?id=180526
1125
1126         Reviewed by Frédéric Wang.
1127
1128         Add unit tests for both parse modes of ParsedContentType.
1129
1130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1131         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1132         (TestWebKitAPI::TEST):
1133
1134 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-app] fetch loop should not stop on network issues
1137         https://bugs.webkit.org/show_bug.cgi?id=193666
1138
1139         Reviewed by Lucas Forschler.
1140
1141         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1142         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1143
1144 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1145
1146         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1147         https://bugs.webkit.org/show_bug.cgi?id=189165
1148         <rdar://problem/47433765>
1149
1150         Reviewed by Tim Horton.
1151
1152         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1153         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1154         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1155         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1156         would make its way to the UI process by the time the layer tree commit is finished.
1157
1158         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1159         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1160         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1161         will fail because it asks for -_autofillContext too early.
1162
1163         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1164         is handled in the UI process.
1165
1166         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1167
1168         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1169         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1170         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1171         input session.
1172
1173         (-[AutofillTestView textInputHasAutofillContext]):
1174
1175         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1176
1177         * TestWebKitAPI/cocoa/TestWKWebView.h:
1178         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1179         (nextInputSessionChangeCount):
1180
1181         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1182         This includes changing the focused element from one to another.
1183
1184         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1185         (-[TestWKWebView didStartFormControlInteraction]):
1186         (-[TestWKWebView didEndFormControlInteraction]):
1187         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1188
1189         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1190         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1191         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1192         that doesn't require an input session to one that doesn't.
1193
1194 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1195
1196         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1197         <https://webkit.org/b/193676>
1198
1199         Reviewed by Alexey Proskuryakov.
1200
1201         * Scripts/webkitpy/style/checkers/cpp.py:
1202         (check_member_initialization_list):
1203         - Don't report missing whitespace around colon if the colon at
1204           the start of the line is formatted correctly.
1205         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1206         (WebKitStyleTest.test_member_initialization_list):
1207         - Add a test for a missing permutation of existing tests.
1208         - Add a test this false-positive.
1209         - Add blank lines between subtests to make them easier to read.
1210
1211 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [build.webkit.org] Unit-test failure after r237113
1214         https://bugs.webkit.org/show_bug.cgi?id=193669
1215
1216         Reviewed by Michael Catanzaro.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1219         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1220         multiple or zero flags.
1221
1222 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1223
1224         Cache bytecode to disk
1225         https://bugs.webkit.org/show_bug.cgi?id=192782
1226         <rdar://problem/46084932>
1227
1228         Reviewed by Keith Miller.
1229
1230         Add test helper to execute bytecode-cache tests: it executes each test
1231         twice, the first with JSC_diskCachePath set to a temporary directory
1232         and second with JSC_forceDiskCache=true (in addition to the cache path)
1233         to guarantee that only the disk cache is being used and no new
1234         UnlinkedCodeBlocks are being created.
1235
1236         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1237         * Scripts/run-jsc-stress-tests:
1238
1239 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1240
1241         [css-logical] Implement flow-relative margin, padding and border shorthands
1242         https://bugs.webkit.org/show_bug.cgi?id=188697
1243
1244         Reviewed by Simon Fraser and Antti Koivisto.
1245
1246         * DumpRenderTree/TestOptions.cpp:
1247         (TestOptions::TestOptions):
1248         * DumpRenderTree/TestOptions.h:
1249         * DumpRenderTree/mac/DumpRenderTree.mm:
1250         (setWebPreferencesForTestOptions):
1251         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1252
1253         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1254         (JSONCSSPropertiesChecker.check_codegen_properties):
1255         Allow CSS property definitions to have a 'runtime-flag' parameter which
1256         disables the property when the specified runtime flag is disabled.
1257
1258 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1259
1260         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1261         https://bugs.webkit.org/show_bug.cgi?id=193643
1262
1263         Reviewed by Michael Catanzaro.
1264
1265         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1266         * wpe/jhbuild.modules: Ditto.
1267
1268 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1269
1270         [LFC][Floats] Take float top position into account when computing containing block height.
1271         https://bugs.webkit.org/show_bug.cgi?id=193655
1272
1273         Reviewed by Antti Koivisto.
1274
1275         * LayoutReloaded/misc/LFC-passing-tests.txt:
1276
1277 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1278
1279         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1280         <https://webkit.org/b/193645>
1281         <rdar://problem/47421574>
1282
1283         Reviewed by Alex Christensen.
1284
1285         - Now checks for local soft-linking of all frameworks that have
1286           their own *SoftLinking.{cpp,h,mm} files.
1287         - Changes softlink/uikit warning to softlink/framework.
1288
1289         * Scripts/webkitpy/style/checkers/cpp.py:
1290         (check_language):
1291         (CppChecker):
1292         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1293         (CppStyleTest):
1294
1295 2019-01-20  Saam Barati  <sbarati@apple.com>
1296
1297         Rollout r240210: It broke tests on iOS
1298         https://bugs.webkit.org/show_bug.cgi?id=193640
1299
1300         Unreviewed.
1301
1302         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1303         * Scripts/run-jsc-stress-tests:
1304
1305 2019-01-20  chris fleizach  <cfleizach@apple.com>
1306
1307         AX: Support returning relative frames for accessibility
1308         https://bugs.webkit.org/show_bug.cgi?id=193414
1309         <rdar://problem/47268501>
1310
1311         Reviewed by Zalan Bujtas.
1312
1313         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1314         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1315         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1316         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1317         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1318         (WTR::attributesOfElement):
1319         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1320
1321 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1322
1323         Unreviewed, add my new email address
1324
1325         * Scripts/webkitpy/common/config/contributors.json:
1326
1327 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1328
1329         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1330         https://bugs.webkit.org/show_bug.cgi?id=193617
1331
1332         Reviewed by Antti Koivisto.
1333
1334         * LayoutReloaded/misc/LFC-passing-tests.txt:
1335
1336 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1337
1338         Unreviewed, rolling out r240209.
1339
1340         Broke GTK/WPE injected bundle
1341
1342         Reverted changeset:
1343
1344         "AX: Support returning relative frames for accessibility"
1345         https://bugs.webkit.org/show_bug.cgi?id=193414
1346         https://trac.webkit.org/changeset/240209
1347
1348 2019-01-12  Dan Bernstein  <mitz@apple.com>
1349
1350         [Cocoa] Avoid importing directly from subumbrella frameworks
1351         https://bugs.webkit.org/show_bug.cgi?id=186016
1352         <rdar://problem/40591038>
1353
1354         Reviewed by Sam Weinig.
1355
1356         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1357           LaunchServices header.
1358         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1359           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1360         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1361           when using SDKs earlier than 10.13.
1362         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1363           and OTHER_CPLUSPLUSFLAGS.
1364         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1365           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1366         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1367           LaunchServices header.
1368
1369 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1370
1371         Cache bytecode to disk
1372         https://bugs.webkit.org/show_bug.cgi?id=192782
1373         <rdar://problem/46084932>
1374
1375         Reviewed by Keith Miller.
1376
1377         Add test helper to execute bytecode-cache tests: it executes each test
1378         twice, the first with JSC_diskCachePath set to a temporary directory
1379         and second with JSC_forceDiskCache=true (in addition to the cache path)
1380         to guarantee that only the disk cache is being used and no new
1381         UnlinkedCodeBlocks are being created.
1382
1383         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1384         * Scripts/run-jsc-stress-tests:
1385
1386 2019-01-20  chris fleizach  <cfleizach@apple.com>
1387
1388         AX: Support returning relative frames for accessibility
1389         https://bugs.webkit.org/show_bug.cgi?id=193414
1390         <rdar://problem/47268501>
1391
1392         Reviewed by Zalan Bujtas.
1393
1394         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1395         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1396         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1397         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1398         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1399         (WTR::attributesOfElement):
1400         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1401
1402 2019-01-20  Antoine Quint  <graouts@apple.com>
1403
1404         Add a POINTER_EVENTS feature flag
1405         https://bugs.webkit.org/show_bug.cgi?id=193577
1406         <rdar://problem/47408511>
1407
1408         Unreviewed. Also enable Pointer Events for iosmac.
1409
1410         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1411
1412 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1413
1414         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1415         https://bugs.webkit.org/show_bug.cgi?id=193613
1416
1417         Reviewed by Antti Koivisto.
1418
1419         * LayoutReloaded/misc/LFC-passing-tests.txt:
1420
1421 2019-01-19  Antoine Quint  <graouts@apple.com>
1422
1423         Add a POINTER_EVENTS feature flag
1424         https://bugs.webkit.org/show_bug.cgi?id=193577
1425
1426         Reviewed by Dean Jackson.
1427
1428         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1429
1430 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1431
1432         Disable the run-jsc-stress-test remote host key check [second round].
1433         https://bugs.webkit.org/show_bug.cgi?id=192988
1434
1435         Reviewed by Dewei Zhu.
1436
1437         * Scripts/run-jsc-stress-tests:
1438
1439 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1440
1441         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1442         https://bugs.webkit.org/show_bug.cgi?id=193597
1443
1444         Reviewed by Lucas Forschler.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1447
1448 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1449
1450         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1451         https://bugs.webkit.org/show_bug.cgi?id=193595
1452
1453         Reviewed by Lucas Forschler.
1454
1455         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1456         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1457         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1458
1459 2019-01-18  Chris Dumez  <cdumez@apple.com>
1460
1461         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1462         https://bugs.webkit.org/show_bug.cgi?id=193588
1463         <rdar://problem/47131566>
1464
1465         Reviewed by Alex Christensen.
1466
1467         Add layout test coverage.
1468
1469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1470
1471 2019-01-18  Jer Noble  <jer.noble@apple.com>
1472
1473         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1474         https://bugs.webkit.org/show_bug.cgi?id=189553
1475
1476         Reviewed by Tim Horton.
1477
1478         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1479
1480         * ContentExtensionTester/Configurations/Base.xcconfig:
1481         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1482         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1483         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1484         * ImageDiff/cg/Configurations/Base.xcconfig:
1485         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1486         * MiniBrowser/Configurations/Base.xcconfig:
1487         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1488         * MobileMiniBrowser/Configurations/Base.xcconfig:
1489         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1490         * Scripts/webkitpy/style/checker.py:
1491         (_all_categories):
1492         (FileType):
1493         (CheckerDispatcher._file_type):
1494         (CheckerDispatcher._create_checker):
1495         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1496         (SDKVariantChecker):
1497         (SDKVariantChecker.__init__):
1498         (SDKVariantChecker.check):
1499         * TestWebKitAPI/Configurations/Base.xcconfig:
1500         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1501         * WebEditingTester/Configurations/Base.xcconfig:
1502         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1503         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1504         * WebKitTestRunner/Configurations/Base.xcconfig:
1505         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1506         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1507         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1508
1509 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1510
1511         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1512         <https://webkit.org/b/193568>
1513         <rdar://problem/47381130>
1514
1515         Reviewed by Alex Christensen.
1516
1517         Make sure no one re-introduces UIKit soft-linking by adding a
1518         style rule.
1519
1520         * Scripts/webkitpy/style/checkers/cpp.py:
1521         (check_language): Add softlink/uikit check.
1522         (CppChecker): Enable softlink/uikit check.
1523         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1524         (CppStyleTest): Add test for softlink/uikit.
1525
1526 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1527
1528         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1529         https://bugs.webkit.org/show_bug.cgi?id=193584
1530
1531         Change "-dev" to "-devel".
1532
1533         Reviewed by Michael Catanzaro.
1534
1535         * gtk/install-dependencies:
1536
1537 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1538
1539         webkitpy: Add iPhone and iPad ports
1540         https://bugs.webkit.org/show_bug.cgi?id=193537
1541         <rdar://problem/47353390>
1542
1543         Reviewed by Lucas Forschler.
1544
1545         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1546         ports. Note that this separation is optional, the --ios-simulator command remains.
1547
1548         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1549         (RunTest.test_device_type_test_division): Drive-by fix.
1550         (RunTest.test_device_type_specific_listing): Ditto.
1551         (RunTest.test_ipad_test_division):
1552         (RunTest):
1553         (RunTest.test_ipad_listing):
1554         * Scripts/webkitpy/port/factory.py:
1555         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1556         (PortFactory):
1557         * Scripts/webkitpy/port/ios_simulator.py:
1558         (IPhoneSimulatorPort):
1559         (IPadSimulatorPort):
1560
1561 2019-01-18  Chris Dumez  <cdumez@apple.com>
1562
1563         Regression(PSON) Scroll position is not always restored properly when navigating back
1564         https://bugs.webkit.org/show_bug.cgi?id=193578
1565         <rdar://problem/47386331>
1566
1567         Reviewed by Tim Horton.
1568
1569         Add API test coverage.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1572
1573 2019-01-18  Youenn Fablet  <youenn@apple.com>
1574
1575         Add a new SPI to request for cache storage quota increase
1576         https://bugs.webkit.org/show_bug.cgi?id=193323
1577
1578         Reviewed by Alex Christensen.
1579
1580         Implement WebsiteDataStore quota delegate to handle quota requests.
1581         By default, do not update quota.
1582         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1583
1584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1585         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1586         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1587         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1588         * WebKitTestRunner/TestController.cpp:
1589         (WTR::TestController::allowCacheStorageQuotaIncrease):
1590         * WebKitTestRunner/TestController.h:
1591         * WebKitTestRunner/TestInvocation.cpp:
1592         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1593         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1594         (-[CacheStorageQuotaManager init]):
1595         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1596         (WTR::initializeWebViewConfiguration):
1597         (WTR::TestController::cocoaResetStateToConsistentValues):
1598         (WTR::TestController::allowCacheStorageQuotaIncrease):
1599
1600 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-build] Pass owner to the triggered builds
1603         https://bugs.webkit.org/show_bug.cgi?id=193574
1604
1605         Reviewed by Lucas Forschler.
1606
1607         * BuildSlaveSupport/ews-build/factories.py:
1608         (BuildFactory.propertiesToPassToTriggers):
1609
1610 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1611
1612         [ews-app] Send patch author as a build property
1613         https://bugs.webkit.org/show_bug.cgi?id=193560
1614
1615         Reviewed by Lucas Forschler.
1616
1617         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1618         (BugzillaPatchFetcher.fetch):
1619
1620 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1621
1622         webkitpy: Implement device type specific expected results (Follow-up fix)
1623         https://bugs.webkit.org/show_bug.cgi?id=192162
1624         <rdar://problem/46345449>
1625
1626         Unreviewed infrastructure fix.
1627
1628         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1629         (Manager.run): Don't boot a device if no tests are available to run on it.
1630
1631 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1632
1633         webkitpy: Implement device type specific expected results (Follow-up fix)
1634         https://bugs.webkit.org/show_bug.cgi?id=192162
1635         <rdar://problem/46345449>
1636
1637         Unreviewed infrastructure fix.
1638
1639         * Scripts/webkitpy/api_tests/manager.py:
1640         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1641
1642 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1643
1644         webkitpy: Implement device type specific expected results (Part 2)
1645         https://bugs.webkit.org/show_bug.cgi?id=192162
1646         <rdar://problem/46345449>
1647
1648         Rubber-stamped by Aakash Jain.
1649
1650         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1651         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1652         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1653
1654         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1655         (LayoutTestFinder.find_tests): Pass device_type through.
1656         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1657         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1658         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1659         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1660         (Manager._collect_tests): Pass device type to test finder.
1661         (Manager._needs_web_platform_test):
1662         (Manager._prepare_lists): Index _expectations by device type.
1663         (Manager._test_input_for_file):
1664         (Manager._test_is_slow): Ditto.
1665         (Manager._test_should_dump_jsconsolelog_in_stderr):
1666         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1667         (Manager._get_test_inputs):
1668         (Manager._update_worker_count):
1669         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1670         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1671         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1672         the one which runs the test.
1673         (Manager._run_test_subset):
1674         (Manager._run_tests): Index _expectations by current_device_type.
1675         (Manager._print_expectation_line_for_test): Ditto.
1676         (Manager._print_expectations_for_subset): Ditto.
1677         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1678         Unlike run, this function will behave the same regardless of what devices are available.
1679         (Manager._custom_device_for_test): Deleted.
1680         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1681         (ManagerTest.test_uses_custom_device): Deleted.
1682         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1683         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1684         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1685         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1686         all of the expectations.
1687         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1688         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1689         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1690         (TestExpectations.__init__): Allow device_type to be passed through.
1691         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1692         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1693         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1694         (summarize_results):
1695         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1696         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1697         a test ran with, one must check all expectations to find the first non-skip expectation.
1698         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1699         (RunTest.test_device_type_test_division):
1700         (RunTest):
1701         (RunTest.test_device_type_specific_listing):
1702         * Scripts/webkitpy/port/base.py:
1703         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1704         (Port.supported_device_types): The result of this function will change based on what devices are available.
1705         * Scripts/webkitpy/port/device_port.py:
1706         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1707         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1708         can be used.
1709         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1710         any, or the DEFAULT_DEVICE_TYPES of the port.
1711         * Scripts/webkitpy/port/ios.py:
1712         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1713         * Scripts/webkitpy/port/ios_simulator.py:
1714         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1715         * Scripts/webkitpy/port/watch.py:
1716         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1717         * Scripts/webkitpy/port/watch_simulator.py:
1718         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1719         * Scripts/webkitpy/xcode/device_type.py:
1720         (DeviceType):
1721         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1722
1723 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1724
1725         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1726         https://bugs.webkit.org/show_bug.cgi?id=193575
1727
1728         Reviewed by Michael Catanzaro.
1729
1730         Allow the script to run without explicit port argument because
1731         it's specific to the WPE port anyway.
1732
1733         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1734         and simplify the rest of the code accordingly.
1735
1736 2019-01-18  Charlie Turner  <cturner@igalia.com>
1737
1738         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1739         https://bugs.webkit.org/show_bug.cgi?id=192229
1740
1741         Reviewed by Xabier Rodriguez-Calvar.
1742
1743         * MiniBrowser/wpe/main.cpp:
1744         (main): Enable encrypted-media by default.
1745
1746 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1747
1748         [Flatpak] Missing KeyboardInterrupt exception handler
1749         https://bugs.webkit.org/show_bug.cgi?id=193570
1750
1751         Reviewed by Michael Catanzaro.
1752
1753         * flatpak/flatpakutils.py:
1754         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1755
1756 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1757
1758         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1759         https://bugs.webkit.org/show_bug.cgi?id=193564
1760
1761         Reviewed by Antti Koivisto.
1762
1763         * LayoutReloaded/misc/LFC-passing-tests.txt:
1764
1765 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1766
1767         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1768         https://bugs.webkit.org/show_bug.cgi?id=193562
1769
1770         Reviewed by Antti Koivisto.
1771
1772         * LayoutReloaded/misc/LFC-passing-tests.txt:
1773
1774 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1775
1776         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1777         https://bugs.webkit.org/show_bug.cgi?id=193555
1778
1779         Reviewed by Antti Koivisto.
1780
1781         * LayoutReloaded/misc/LFC-passing-tests.txt:
1782
1783 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1784
1785         [WPE] Add Qt extension
1786         https://bugs.webkit.org/show_bug.cgi?id=191464
1787
1788         Reviewed by Carlos Garcia Campos.
1789
1790         MiniBrowser and API tests for the WPE Qt API. To run the
1791         MiniBrowser a new script is introduced. Example invocation:
1792
1793         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1794
1795         Also note-worthy is the introduction of the python2-subprocess32
1796         dependency to run the GLib API tests.
1797
1798         * MiniBrowser/wpe/CMakeLists.txt:
1799         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1800         * MiniBrowser/wpe/qt/main.cpp: Added.
1801         (main):
1802         * MiniBrowser/wpe/qt/main.qml: Added.
1803         * MiniBrowser/wpe/qt/qml.qrc: Added.
1804         * Scripts/run-gtk-tests:
1805         (GtkTestRunner.is_google_test):
1806         (GtkTestRunner):
1807         (GtkTestRunner.is_qt_test):
1808         * Scripts/run-qt-wpe-minibrowser: Added.
1809         * Scripts/run-wpe-tests:
1810         (WPETestRunner):
1811         (WPETestRunner.is_google_test):
1812         (WPETestRunner.is_qt_test):
1813         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1814         (TestLoad::main):
1815         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1816         (TestLoadHtml::main):
1817         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1818         (TestLoadRequest::main):
1819         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1820         (TestRunJavaScript::main):
1821         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1822         (waitForSignal):
1823         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1824         (LoadSpy::LoadSpy):
1825         (LoadSpy::~LoadSpy):
1826         (LoadSpy::onLoadingChanged):
1827         (LoadStartedCatcher::LoadStartedCatcher):
1828         (LoadStartedCatcher::~LoadStartedCatcher):
1829         (LoadStartedCatcher::onLoadingChanged):
1830         (waitForLoadSucceeded):
1831         (waitForLoadFailed):
1832         * TestWebKitAPI/glib/CMakeLists.txt:
1833         * flatpak/flatpakutils.py:
1834         (WebkitFlatpak.load_from_args):
1835         (WebkitFlatpak.__init__):
1836         (WebkitFlatpak.clean_args):
1837         (WebkitFlatpak.run_in_sandbox):
1838         * flatpak/org.webkit.CommonModules.yaml:
1839         * flatpak/org.webkit.WPE.yaml:
1840         * flatpak/org.webkit.WPEModules.yaml:
1841         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1842         * flatpak/org.webkit.WebKit.yaml:
1843         * glib/api_test_runner.py:
1844         (TestRunner._run_test_qt):
1845         (TestRunner.is_qt_test):
1846         (TestRunner._run_test):
1847
1848 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1849
1850         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1851         https://bugs.webkit.org/show_bug.cgi?id=193494
1852         <rdar://problem/46859627>
1853
1854         Reviewed by Simon Fraser and Tim Horton.
1855
1856         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1857         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1858
1859         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1860         (WTR::UIScriptController::contentOffsetX const):
1861         (WTR::UIScriptController::contentOffsetY const):
1862         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1863         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1864         (WTR::UIScriptController::contentOffsetX const):
1865         (WTR::UIScriptController::contentOffsetY const):
1866         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1867
1868         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1869
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::updateTestOptionsFromTestHeader):
1872         * WebKitTestRunner/TestOptions.h:
1873         (WTR::TestOptions::hasSameInitializationOptions const):
1874         * WebKitTestRunner/ios/TestControllerIOS.mm:
1875         (WTR::TestController::platformResetStateToConsistentValues):
1876         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1877         (WTR::UIScriptController::contentOffsetX const):
1878         (WTR::UIScriptController::contentOffsetY const):
1879
1880 2019-01-17  Truitt Savell  <tsavell@apple.com>
1881
1882         Unreviewed, rolling out r240124.
1883
1884         This commit broke an internal build.
1885
1886         Reverted changeset:
1887
1888         "SDK_VARIANT build destinations should be separate from non-
1889         SDK_VARIANT builds"
1890         https://bugs.webkit.org/show_bug.cgi?id=189553
1891         https://trac.webkit.org/changeset/240124
1892
1893 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1894
1895         Fix string concatenation API test after r239920
1896         https://bugs.webkit.org/show_bug.cgi?id=193551
1897         <rdar://problem/47359304>
1898
1899         Reviewed by Youenn Fablet.
1900
1901         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1902         (TestWebKitAPI::TEST):
1903         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1904         in WebKit's build configuration like it apparently is on Linux.
1905
1906 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1907
1908         [ews-build] validate-patch should handle the case when bug_id is None
1909         https://bugs.webkit.org/show_bug.cgi?id=193547
1910
1911         Reviewed by Lucas Forschler.
1912
1913         * BuildSlaveSupport/ews-build/steps.py:
1914         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1915         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1916
1917 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1918
1919         [ews-build] Add patch author information in build
1920         https://bugs.webkit.org/show_bug.cgi?id=193465
1921
1922         Reviewed by Lucas Forschler.
1923
1924         * BuildSlaveSupport/ews-build/steps.py:
1925         (ValidatePatch._is_patch_obsolete):
1926
1927 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Pass bug_id to the triggered builds
1930         https://bugs.webkit.org/show_bug.cgi?id=193548
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-build/factories.py:
1935         (BuildFactory.propertiesToPassToTriggers):
1936
1937 2019-01-17  Jer Noble  <jer.noble@apple.com>
1938
1939         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1940         https://bugs.webkit.org/show_bug.cgi?id=189553
1941
1942         Reviewed by Tim Horton.
1943
1944         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1945
1946         * ContentExtensionTester/Configurations/Base.xcconfig:
1947         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1948         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1949         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1950         * ImageDiff/cg/Configurations/Base.xcconfig:
1951         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1952         * MiniBrowser/Configurations/Base.xcconfig:
1953         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1954         * MobileMiniBrowser/Configurations/Base.xcconfig:
1955         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1956         * Scripts/webkitpy/style/checker.py:
1957         (_all_categories):
1958         (FileType):
1959         (CheckerDispatcher._file_type):
1960         (CheckerDispatcher._create_checker):
1961         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1962         (SDKVariantChecker):
1963         (SDKVariantChecker.__init__):
1964         (SDKVariantChecker.check):
1965         * TestWebKitAPI/Configurations/Base.xcconfig:
1966         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1967         * WebEditingTester/Configurations/Base.xcconfig:
1968         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1969         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1970         * WebKitTestRunner/Configurations/Base.xcconfig:
1971         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1972         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1973         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1974
1975 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1976
1977         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1978         https://bugs.webkit.org/show_bug.cgi?id=193534
1979
1980         Reviewed by Antti Koivisto.
1981
1982         * LayoutReloaded/misc/LFC-passing-tests.txt:
1983
1984 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1985
1986         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1987         https://bugs.webkit.org/show_bug.cgi?id=193528
1988
1989         Reviewed by Antti Koivisto.
1990
1991         * LayoutReloaded/misc/LFC-passing-tests.txt:
1992
1993 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1994
1995         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1996         https://bugs.webkit.org/show_bug.cgi?id=193520
1997
1998         Reviewed by Antti Koivisto.
1999
2000         * LayoutReloaded/misc/LFC-passing-tests.txt:
2001
2002 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2003
2004         [ews-build] unapply-patch step should not update source
2005         https://bugs.webkit.org/show_bug.cgi?id=193234
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * BuildSlaveSupport/ews-build/steps.py:
2010         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2011         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2012
2013 2019-01-16  Youenn Fablet  <youenn@apple.com>
2014
2015         Add a new SPI for controlling getUserMedia
2016         https://bugs.webkit.org/show_bug.cgi?id=192793
2017
2018         Reviewed by Eric Carlson.
2019
2020         * MiniBrowser/mac/WK2BrowserWindowController.m:
2021         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2022         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2023         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2024         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2025         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2026         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2027         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2028         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2029         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2030         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2031         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2032         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2033         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2034         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2035
2036 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2037
2038         [LFC][BFC] Inflow non-replaced used width should not be negative.
2039         https://bugs.webkit.org/show_bug.cgi?id=193495
2040
2041         Reviewed by Antti Koivisto.
2042
2043         * LayoutReloaded/misc/LFC-passing-tests.txt:
2044
2045 2019-01-16  Chris Dumez  <cdumez@apple.com>
2046
2047         Regression(PSON) View becomes blank after click a cross-site download link
2048         https://bugs.webkit.org/show_bug.cgi?id=193361
2049         <rdar://problem/47099573>
2050
2051         Reviewed by Geoffrey Garen.
2052
2053         Add API test coverage.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2056         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2057
2058 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2059
2060         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2061         https://bugs.webkit.org/show_bug.cgi?id=193470
2062
2063         Reviewed by Antti Koivisto.
2064
2065         * LayoutReloaded/misc/LFC-passing-tests.txt:
2066
2067 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2068
2069         [LFC] Adjust margin box verification.
2070         https://bugs.webkit.org/show_bug.cgi?id=193482
2071
2072         Reviewed by Antti Koivisto.
2073
2074         * LayoutReloaded/misc/LFC-passing-tests.txt:
2075
2076 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2077
2078         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2079         https://bugs.webkit.org/show_bug.cgi?id=193451
2080
2081         Reviewed by Geoffrey Garen.
2082
2083         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2084         (TEST):
2085         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2086         (runWebsiteDataStoreCustomPaths):
2087
2088 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2089
2090         webkitpy: Support boolean simctl isAvailable
2091         https://bugs.webkit.org/show_bug.cgi?id=193472
2092         <rdar://problem/47296150>
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         * Scripts/webkitpy/xcode/simulated_device.py:
2097         (SimulatedDeviceManager._create_runtimes):
2098         (SimulatedDeviceManager._create_device_with_runtime):
2099
2100 2019-01-15  Chris Dumez  <cdumez@apple.com>
2101
2102         Unreviewed, rolling out r239993, r239995, r239997, and
2103         r239999.
2104
2105         Caused assertions under
2106         ViewGestureController::disconnectFromProcess()
2107
2108         Reverted changesets:
2109
2110         "Regression(PSON) View becomes blank after click a cross-site
2111         download link"
2112         https://bugs.webkit.org/show_bug.cgi?id=193361
2113         https://trac.webkit.org/changeset/239993
2114
2115         "Unreviewed iOS build fix after r239993."
2116         https://trac.webkit.org/changeset/239995
2117
2118         "Fix iOS build after r239993"
2119         https://bugs.webkit.org/show_bug.cgi?id=193361
2120         https://trac.webkit.org/changeset/239997
2121
2122         "Unreviewed, revert part of r239997 as it is not needed to fix
2123         the build."
2124         https://trac.webkit.org/changeset/239999
2125
2126 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2127
2128         Cannot tab out of WKWebView on macOS
2129         https://bugs.webkit.org/show_bug.cgi?id=161448
2130         <rdar://problem/28100085>
2131
2132         Reviewed by Dean Jackson.
2133
2134         Add a test that tabbing into and out of WKWebView works correctly.
2135
2136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2137         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2138         (WebKit2_CommandBackForwardTest::SetUp):
2139         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2140         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2141         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2142         (-[FocusableView canBecomeKeyView]):
2143         (TEST):
2144         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2145         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2146         (-[OffscreenWindow initWithSize:]):
2147         (-[OffscreenWindow isKeyWindow]):
2148         (-[OffscreenWindow isVisible]):
2149         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2150         (TestWebKitAPI::PlatformWebView::initialize):
2151         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2152         (-[ActiveOffscreenWindow isVisible]): Deleted.
2153         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2154
2155 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2156
2157         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2158         https://bugs.webkit.org/show_bug.cgi?id=193459
2159
2160         Reviewed by Mark Lam.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2163         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2164
2165 2019-01-15  Chris Dumez  <cdumez@apple.com>
2166
2167         Regression(PSON) View becomes blank after click a cross-site download link
2168         https://bugs.webkit.org/show_bug.cgi?id=193361
2169         <rdar://problem/47099573>
2170
2171         Reviewed by Geoff Garen.
2172
2173         Add API test coverage.
2174
2175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2176         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2177
2178 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2179
2180         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2181         https://bugs.webkit.org/show_bug.cgi?id=193448
2182
2183         Reviewed by Antti Koivisto.
2184
2185         * LayoutReloaded/misc/LFC-passing-tests.txt:
2186
2187 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2188
2189         webkitpy: Implement device type specific expected results (Part 1)
2190         https://bugs.webkit.org/show_bug.cgi?id=192162
2191
2192         Reviewed by Lucas Forschler.
2193
2194         Device type specific expected results covers two related ideas. The first (covered by this change)
2195         is where to search for -expected.* files. The second is which tests to run based on the
2196         TestExpectations.txt file.
2197
2198         After this change, the baseline search path will be determined by the type of device running a
2199         test. Device type will be passed into any function which picks a file based on the baseline search
2200         path.
2201
2202         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2203         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2205         (Manager.run): Print baseline search path for each round of devices.
2206         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2207         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2208         (SingleTestRunner._expected_driver_output): Ditto.
2209         (SingleTestRunner._driver_input): Ditto.
2210         * Scripts/webkitpy/layout_tests/views/printing.py:
2211         (Printer.print_config): Move printing of baseline search path to a separate function.
2212         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2213         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2214         (Testprinter.test_print_config):
2215         (Testprinter.test_print_baseline_search_path):
2216         * Scripts/webkitpy/port/base.py:
2217         (Port.baseline_search_path): Pass device_type through.
2218         (Port._expected_baselines_for_suffixes): Ditto.
2219         (Port.expected_baselines): Ditto.
2220         (Port.expected_filename): Ditto.
2221         (Port.expected_checksum): Ditto.
2222         (Port.expected_image): Ditto.
2223         (Port.expected_audio): Ditto.
2224         (Port.expected_text): Ditto.
2225         (Port.reference_files): Ditto.
2226         (Port.tests): Ditto.
2227         (Port._expanded_paths): Ditto.
2228         (Port.skipped_layout_tests): Ditto.
2229         (Port.expectations_dict): Ditto.
2230         (Port._port_specific_expectations_files): Ditto.
2231         (Port.expectations_files): Ditto.
2232         (Port.test_search_path): Ditto.
2233         (Port._tests_for_other_platforms): Ditto.
2234         * Scripts/webkitpy/port/base_unittest.py:
2235         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2236         (PortTest.test_nonexistant_expectations): Ditto.
2237         (test_ref_tests_platform_directory): Ditto.
2238         * Scripts/webkitpy/port/darwin.py:
2239         (DarwinPort._port_specific_expectations_files): Accept device_type.
2240         * Scripts/webkitpy/port/driver.py:
2241         (DriverProxy):
2242         (DriverProxy.host): Expose _target_host for device_type information.
2243         * Scripts/webkitpy/port/gtk.py:
2244         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2245         * Scripts/webkitpy/port/ios.py:
2246         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2247         * Scripts/webkitpy/port/mac.py:
2248         (MacPort. default_baseline_search_path): Ditto.
2249         * Scripts/webkitpy/port/port_testcase.py:
2250         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2251         * Scripts/webkitpy/port/test.py:
2252         * Scripts/webkitpy/port/watch.py:
2253         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2254         * Scripts/webkitpy/port/win.py:
2255         (WinPort.test_search_path): Accept, but do not use, device_type.
2256         * Scripts/webkitpy/port/wpe.py:
2257         (WPEPort._port_specific_expectations_files): Ditto.
2258         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2259         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2260
2261 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2262
2263         [LFC] Use the containing block's padding box to position out-of-flow elements.
2264         https://bugs.webkit.org/show_bug.cgi?id=193431
2265
2266         Reviewed by Antti Koivisto.
2267
2268         * LayoutReloaded/misc/LFC-passing-tests.txt:
2269
2270 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2271
2272         Move a test implementation file that got misplaced in the Xcode project
2273
2274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2275
2276 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2277
2278         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2279         r239913, and r239914.
2280         https://bugs.webkit.org/show_bug.cgi?id=193407
2281
2282         These revisions caused an internal failure (Requested by
2283         Truitt on #webkit).
2284
2285         Reverted changesets:
2286
2287         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2288         https://bugs.webkit.org/show_bug.cgi?id=186016
2289         https://trac.webkit.org/changeset/239901
2290
2291         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2292         https://trac.webkit.org/changeset/239909
2293
2294         "Tried to fix the build."
2295         https://trac.webkit.org/changeset/239910
2296
2297         "Fixed iOS builds after r239910."
2298         https://trac.webkit.org/changeset/239912
2299
2300         "More build fixing."
2301         https://trac.webkit.org/changeset/239913
2302
2303         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2304         https://trac.webkit.org/changeset/239914
2305
2306 2019-01-14  Mark Lam  <mark.lam@apple.com>
2307
2308         Re-enable ability to build --cloop builds.
2309         https://bugs.webkit.org/show_bug.cgi?id=192955
2310         <rdar://problem/46882363>
2311
2312         Reviewed by Saam barati and Keith Miller.
2313
2314         The --cloop build option was being ignored this whole time since r236381.
2315         This patch makes it possible to build CLoop builds again.
2316
2317         * Scripts/build-jsc:
2318         * Scripts/webkitperl/FeatureList.pm:
2319         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2320
2321 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2322
2323         webkitpy: Expose device_type from host-like objects
2324         https://bugs.webkit.org/show_bug.cgi?id=193406
2325         <rdar://problem/47262305>
2326
2327         Reviewed by Lucas Forschler.
2328
2329         Devices should expose device_type. As a result, all host objects should
2330         provide a device_type property, even if they do not yet define a device_type.
2331
2332         * Scripts/webkitpy/common/system/systemhost.py:
2333         (SystemHost):
2334         (SystemHost.device_type):
2335         * Scripts/webkitpy/common/system/systemhost_mock.py:
2336         (MockSystemHost):
2337         (MockSystemHost.device_type):
2338         * Scripts/webkitpy/port/device.py:
2339         (Device):
2340         (Device.device_type):
2341         * Scripts/webkitpy/xcode/simulated_device.py:
2342         (SimulatedDeviceManager._find_exisiting_device_for_request):
2343         (SimulatedDeviceManager._disambiguate_device_type):
2344         (SimulatedDeviceManager._does_fulfill_request):
2345         (SimulatedDeviceManager.device_count_for_type):
2346         (SimulatedDeviceManager.initialize_devices):
2347         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2348         (test_available_devices):
2349         (test_swapping_devices):
2350
2351 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2352
2353         webkitpy: Support alternate simctl device list output (Follow-up fix)
2354         https://bugs.webkit.org/show_bug.cgi?id=193362
2355         <rdar://problem/47122965>
2356
2357         Rubber-stamped by Lucas Forschler.
2358
2359         * Scripts/webkitpy/xcode/simulated_device.py:
2360         (SimulatedDeviceManager.populate_available_devices):
2361
2362 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2363
2364         [iOS] Expose SPI to access the current sentence boundary and selection state
2365         https://bugs.webkit.org/show_bug.cgi?id=193398
2366         <rdar://problem/45893108>
2367
2368         Reviewed by Dean Jackson.
2369
2370         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2371         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2372         expected.
2373
2374         * TestWebKitAPI/EditingTestHarness.h:
2375         * TestWebKitAPI/EditingTestHarness.mm:
2376         (-[EditingTestHarness moveBackward]):
2377         (-[EditingTestHarness moveForward]):
2378         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2379
2380         Add a couple of new helper methods on EditingTestHarness.
2381
2382         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2383         (-[SelectionChangeObserver initWithWebView:]):
2384         (-[SelectionChangeObserver webView]):
2385         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2386         (-[SelectionChangeObserver currentSelectionAttributes]):
2387
2388 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2389
2390         [LFC][BFC] Add basic box-sizing support.
2391         https://bugs.webkit.org/show_bug.cgi?id=193392
2392
2393         Reviewed by Antti Koivisto.
2394
2395         * LayoutReloaded/misc/LFC-passing-tests.txt:
2396
2397 2019-01-14  Charlie Turner  <cturner@igalia.com>
2398
2399         [WPE] API test gardening
2400         https://bugs.webkit.org/show_bug.cgi?id=193319
2401
2402         Reviewed by Michael Catanzaro.
2403
2404         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2405         passing tests.
2406
2407 2019-01-14  Charlie Turner  <cturner@igalia.com>
2408
2409         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2410         https://bugs.webkit.org/show_bug.cgi?id=192977
2411
2412         Reviewed by Carlos Garcia Campos.
2413
2414         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2415         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2416         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2417         (TestWebKitAPI::GStreamerTest::SetUp):
2418         (TestWebKitAPI::GStreamerTest::TearDown):
2419         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2420         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2421         (TestWebKitAPI::TEST_F):
2422
2423 2019-01-14  Charlie Turner  <cturner@igalia.com>
2424
2425         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2426         https://bugs.webkit.org/show_bug.cgi?id=193332
2427
2428         Reviewed by Michael Catanzaro.
2429
2430         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2431         defined as a char16_t, which changed in ICU 59, the
2432         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2433         unsigned short. This test is relying on the behaviour that
2434         UChar=unsigned short, which doesn't hold across platforms and ICU
2435         library versions. The full fix would be a special syntax for
2436         literal characters so that these ambiguities do not arise. That
2437         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2438         (TestWebKitAPI::TEST):
2439
2440 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2441
2442         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2443
2444         * Scripts/make-dist:
2445         (Distcheck.configure):
2446
2447 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2448
2449         [ews-build] Update macOS queue configurations
2450         https://bugs.webkit.org/show_bug.cgi?id=193365
2451         <rdar://problem/47221073>
2452
2453         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2454
2455         * BuildSlaveSupport/ews-build/config.json:
2456
2457 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2458
2459         [LFC] Adjust assert for statically positioned fixed elements
2460         https://bugs.webkit.org/show_bug.cgi?id=193385
2461
2462         Reviewed by Antti Koivisto.
2463
2464         * LayoutReloaded/misc/LFC-passing-tests.txt:
2465
2466 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2467
2468         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2469         https://bugs.webkit.org/show_bug.cgi?id=193387
2470
2471         Reviewed by Carlos Garcia Campos.
2472
2473         * MiniBrowser/wpe/main.cpp:
2474         (main):
2475
2476 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2477
2478         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2479         https://bugs.webkit.org/show_bug.cgi?id=191655
2480         rdar://problem/46074680
2481
2482         Reviewed by Megan Gardner.
2483
2484         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2485         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2486
2487 2019-01-12  Dan Bernstein  <mitz@apple.com>
2488
2489         [Cocoa] Avoid importing directly from subumbrella frameworks
2490         https://bugs.webkit.org/show_bug.cgi?id=186016
2491         <rdar://problem/40591038>
2492
2493         Reviewed by Sam Weinig.
2494
2495         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2496           LaunchServices header.
2497         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2498           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2499         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2500           when using SDKs earlier than 10.13.
2501         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2502           and OTHER_CPLUSPLUSFLAGS.
2503         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2504           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2505         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2506           LaunchServices header.
2507
2508 2019-01-11  John Wilander  <wilander@apple.com>
2509
2510         Compile out Web API Statistics Collection
2511         https://bugs.webkit.org/show_bug.cgi?id=193370
2512         <rdar://problem/45388584>
2513
2514         Reviewed by Brent Fulgham.
2515
2516         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2517             Defined ENABLE_WEB_API_STATISTICS, off by default.
2518
2519 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2520
2521         [WPE] Add gtk-doc
2522         https://bugs.webkit.org/show_bug.cgi?id=178900
2523
2524         Reviewed by Michael Catanzaro.
2525
2526         Add Tools/gtkdoc to manifest.txt.in files.
2527         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2528
2529         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2530         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2531
2532 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2533
2534         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2535         https://bugs.webkit.org/show_bug.cgi?id=193364
2536         <rdar://problem/47214117>
2537
2538         Reviewed by Tim Horton.
2539
2540         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2541         precise, whereas dragging near the middle of the textarea does.
2542
2543         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2544         (TestWebKitAPI::TEST):
2545
2546 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2547
2548         webkitpy: Support alternate simctl device list output
2549         https://bugs.webkit.org/show_bug.cgi?id=193362
2550         <rdar://problem/47122965>
2551
2552         Reviewed by Lucas Forschler.
2553
2554         * Scripts/webkitpy/xcode/simulated_device.py:
2555         (SimulatedDeviceManager.populate_available_devices):
2556
2557 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2558
2559         [ews-build] Update macOS queue configurations
2560         https://bugs.webkit.org/show_bug.cgi?id=193365
2561
2562         Reviewed by Lucas Forschler.
2563
2564         * BuildSlaveSupport/ews-build/config.json:
2565
2566 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2567
2568         webkitpy: Incorporate device type into baseline search path
2569         https://bugs.webkit.org/show_bug.cgi?id=193356
2570         <rdar://problem/47215515>
2571
2572         Reviewed by Lucas Forschler.
2573
2574         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2575
2576         * Scripts/webkitpy/port/base.py:
2577         (Port.default_baseline_search_path): Allow device type to be passed in.
2578         * Scripts/webkitpy/port/gtk.py:
2579         (GtkPort.default_baseline_search_path): Ignore device type.
2580         * Scripts/webkitpy/port/ios.py:
2581         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2582         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2583         * Scripts/webkitpy/port/ios_device_unittest.py:
2584         (IOSDeviceTest):
2585         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2586         (IOSSimulatorTest):
2587         * Scripts/webkitpy/port/mac.py:
2588         (MacPort.default_baseline_search_path): Ignore device type.
2589         * Scripts/webkitpy/port/watch.py:
2590         (WatchPort.default_baseline_search_path): Ditto.
2591         * Scripts/webkitpy/port/win.py:
2592         (WinPort.default_baseline_search_path): Ditto.
2593         (WinCairoPort.default_baseline_search_path): Ditto.
2594         * Scripts/webkitpy/port/wpe.py:
2595         (WPEPort.default_baseline_search_path): Ditto.
2596
2597 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2598
2599         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2600         https://bugs.webkit.org/show_bug.cgi?id=193352
2601         <rdar://problem/47210736>
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * Scripts/webkitpy/layout_tests/views/printing.py:
2606         (Printer.print_config): Print list on only baseline search paths which exist. 
2607         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2608         (Testprinter.test_print_config):
2609
2610 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2611
2612         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2613         https://bugs.webkit.org/show_bug.cgi?id=193340
2614
2615         Reviewed by David Kilzer.
2616
2617         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2618         (WTR::InjectedBundle::didReceiveMessageToPage):
2619         Pull the strings out into a WKRetainPtr.
2620
2621         * WebKitTestRunner/WebNotificationProvider.cpp:
2622         (WTR::WebNotificationProvider::closeWebNotification):
2623         Adopt the created value into the WKRetainPtr.
2624
2625         * WebKitTestRunner/mac/TestControllerMac.mm:
2626         (WTR::generateWhitelist):
2627         Immediately adopt a created value to avoid potential mistakes.
2628
2629 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2630
2631         Enable DFG on ARM/Linux again
2632         https://bugs.webkit.org/show_bug.cgi?id=192496
2633
2634         Reviewed by Yusuke Suzuki.
2635
2636         After changing the bytecode format DFG was disabled on all 32-bit
2637         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2638         on ARM by default.
2639
2640         * Scripts/run-jsc-stress-tests:
2641
2642 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2643
2644         Unreviewed, fix #ifdef in API test added in r239851.
2645         https://bugs.webkit.org/show_bug.cgi?id=193327
2646         rdar://problem/47093222
2647
2648         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2649
2650 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2651
2652         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2653         https://bugs.webkit.org/show_bug.cgi?id=193109
2654         <rdar://problem/44807048>
2655
2656         Reviewed by Ryosuke Niwa.
2657
2658         Introduce and respect a test option to enable the UndoManager API.
2659
2660         * WebKitTestRunner/TestController.cpp:
2661         (WTR::updateTestOptionsFromTestHeader):
2662         * WebKitTestRunner/TestOptions.h:
2663         (WTR::TestOptions::hasSameInitializationOptions const):
2664         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2665         (WTR::TestController::platformCreateWebView):
2666
2667 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2668
2669         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2670         https://bugs.webkit.org/show_bug.cgi?id=193346
2671
2672         Reviewed by Antti Koivisto.
2673
2674         * LayoutReloaded/misc/LFC-passing-tests.txt:
2675
2676 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2677
2678         Unreviewed, fix typo that breaks dashboard link.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2681         (WebKitBuildbot):
2682
2683 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2684
2685         Update macOS queue configurations
2686         https://bugs.webkit.org/show_bug.cgi?id=193329
2687
2688         Reviewed by Alexey Proskuryakov.
2689
2690         * BuildSlaveSupport/build.webkit.org-config/config.json:
2691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2692         (BubbleQueueServer):
2693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2695         (WebKitBuildbot):
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2697         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2698         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2699
2700 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2701
2702         MiniBrowser should be able to navigate to about:blank
2703         https://bugs.webkit.org/show_bug.cgi?id=193345
2704
2705         Reviewed by Simon Fraser.
2706
2707         * MiniBrowser/mac/BrowserWindowController.m:
2708         (-[BrowserWindowController addProtocolIfNecessary:]):
2709         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2710
2711         * MiniBrowser/mac/WK1BrowserWindowController.m:
2712         (-[WK1BrowserWindowController fetch:]):
2713         * MiniBrowser/mac/WK2BrowserWindowController.m:
2714         (-[WK2BrowserWindowController fetch:]):
2715         Clean up the code that uses this to match style.
2716
2717 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2718
2719         Remove MiniBrowser custom "Process Swap" menu item which does not work
2720         https://bugs.webkit.org/show_bug.cgi?id=193344
2721
2722         Reviewed by Simon Fraser.
2723
2724         There is a menu item under the Experimental menu that does work.
2725
2726         * MiniBrowser/mac/AppDelegate.m:
2727         (defaultConfiguration):
2728         * MiniBrowser/mac/SettingsController.h:
2729         * MiniBrowser/mac/SettingsController.m:
2730         (-[SettingsController _populateMenu]):
2731         (-[SettingsController validateMenuItem:]):
2732         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2733         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2734
2735 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2736
2737         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2738         https://bugs.webkit.org/show_bug.cgi?id=193327
2739         rdar://problem/47093222
2740
2741         Reviewed by Tim Horton.
2742
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2745         (TestWebKitAPI::didFinishNavigation):
2746         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2749         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2750         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2751         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2752         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2753
2754 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2755
2756         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2757         https://bugs.webkit.org/show_bug.cgi?id=193338
2758         <rdar://problem/46664774>
2759
2760         Reviewed by David Kilzer.
2761
2762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2763         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2764
2765 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2766
2767         Unreviewed, rolling out r239825.
2768         https://bugs.webkit.org/show_bug.cgi?id=193330
2769
2770         Broke tests on armv7/linux bots (Requested by guijemont on
2771         #webkit).
2772
2773         Reverted changeset:
2774
2775         "Enable DFG on ARM/Linux again"
2776         https://bugs.webkit.org/show_bug.cgi?id=192496
2777         https://trac.webkit.org/changeset/239825
2778
2779 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2780
2781         Disable the run-jsc-stress-test remote host key check.
2782         https://bugs.webkit.org/show_bug.cgi?id=192988
2783
2784         Reviewed by Alexey Proskuryakov.
2785
2786         * Scripts/run-jsc-stress-tests:
2787
2788 2019-01-10  John Wilander  <wilander@apple.com>
2789
2790         Override the session configuration for cookieAcceptPolicy
2791         https://bugs.webkit.org/show_bug.cgi?id=190925
2792         <rdar://problem/45497382>
2793
2794         Reviewed by Alexey Proskuryakov and Alex Christensen.
2795
2796         Test infrastructure for setting a first-party-only cookie policy.
2797
2798         * DumpRenderTree/TestRunner.cpp:
2799         (setOnlyAcceptFirstPartyCookiesCallback):
2800         (TestRunner::staticFunctions):
2801         * DumpRenderTree/TestRunner.h:
2802         * DumpRenderTree/mac/TestRunnerMac.mm:
2803         (TestRunner::setOnlyAcceptFirstPartyCookies):
2804         * DumpRenderTree/win/TestRunnerWin.cpp:
2805         (TestRunner::setOnlyAcceptFirstPartyCookies):
2806         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2808         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2810         * WebKitTestRunner/TestInvocation.cpp:
2811         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2812
2813 2019-01-09  Matt Rajca  <mrajca@apple.com>
2814
2815         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2816         https://bugs.webkit.org/show_bug.cgi?id=193301
2817
2818         Reviewed by Jer Noble.
2819         
2820         Added API tests.
2821
2822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2823         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2824         (TEST):
2825         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2826
2827 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2828
2829         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2830         https://bugs.webkit.org/show_bug.cgi?id=193310
2831
2832         Reviewed by Antti Koivisto.
2833
2834         * LayoutReloaded/misc/LFC-passing-tests.txt:
2835
2836 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2837
2838         Enable DFG on ARM/Linux again
2839         https://bugs.webkit.org/show_bug.cgi?id=192496
2840
2841         Reviewed by Yusuke Suzuki.
2842
2843         After changing the bytecode format DFG was disabled on all 32-bit
2844         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2845         on ARM by default.
2846
2847         * Scripts/run-jsc-stress-tests:
2848
2849 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2850
2851         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2852         https://bugs.webkit.org/show_bug.cgi?id=193271
2853
2854         Reviewed by Brent Fulgham.
2855
2856         BSTR is a special data structure created by SysAllocString, not a
2857         wchar_t null-terminated string.
2858
2859         * DumpRenderTree/win/TestRunnerWin.cpp:
2860         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2861         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2862         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2863         BSTR from wide string literals.
2864
2865 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2866
2867         Tweak wording for build/version_check style checker error
2868         https://bugs.webkit.org/show_bug.cgi?id=193256
2869
2870         Reviewed by Tim Horton.
2871
2872         * Scripts/webkitpy/style/checkers/cpp.py:
2873         (check_os_version_checks):
2874         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2875         (WebKitStyleTest.test_os_version_checks):
2876
2877 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews-build] Add link to bug along with bug title
2880         https://bugs.webkit.org/show_bug.cgi?id=193293
2881
2882         Reviewed by Lucas Forschler.
2883
2884         * BuildSlaveSupport/ews-build/steps.py:
2885         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2886         (ConfigureBuild.add_bug_id_url): Deleted.
2887         (ConfigureBuild.getBugURL): Deleted.
2888
2889 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] Use https for ews-build server
2892         https://bugs.webkit.org/show_bug.cgi?id=193193
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-build/steps.py:
2897
2898 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2899
2900         [ews-build] Parse and display number of style failures
2901         https://bugs.webkit.org/show_bug.cgi?id=193280
2902
2903         Reviewed by Lucas Forschler.
2904
2905         * BuildSlaveSupport/ews-build/steps.py:
2906         (CheckStyle): Use TestWithFailureCount as base class.
2907         (CheckStyle.countFailures): Count the number of style failures.
2908
2909 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2910
2911         [ews-build] use patch_id instead of ewspatchid
2912         https://bugs.webkit.org/show_bug.cgi?id=193235
2913
2914         Reviewed by Lucas Forschler.
2915
2916         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2917         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2918         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2919
2920 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2921
2922         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2923         https://bugs.webkit.org/show_bug.cgi?id=192625
2924
2925         Reviewed by Antti Koivisto.
2926
2927         * LayoutReloaded/misc/LFC-passing-tests.txt:
2928
2929 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2930
2931         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2932         https://bugs.webkit.org/show_bug.cgi?id=192841
2933
2934         Reviewed by Carlos Garcia Campos.
2935
2936         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2937         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2938         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2939
2940         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2941
2942         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2943         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2944         (WebKitWebEditorTest::testSelectionChanged):
2945         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2946         (WebKitFrameTest::testMainFrame):
2947         (WebKitFrameTest::testURI):
2948         (WebKitFrameTest::testJavaScriptContext):
2949         (WebKitFrameTest::testJavaScriptValues):
2950         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2951         (testWebViewAuthenticationRequest):
2952         (testWebViewAuthenticationLoadCancelled):
2953         (testWebViewAuthenticationFailure):
2954         (testWebViewAuthenticationStorage):
2955         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2956         (testWebViewAuthenticationProxy):
2957         (testWebViewAuthenticationProxyHTTPS):
2958         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2959         (testAutomationSessionRequestSession):
2960         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2961         (testBackForwardListNavigation):
2962         (testWebKitWebViewSessionState):
2963         (testWebKitWebViewSessionStateWithFormData):
2964         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2965         (ConsoleMessageTest::consoleMessageReceivedCallback):
2966         (testWebKitConsoleMessageConsoleAPI):
2967         (testWebKitConsoleMessageJavaScriptException):
2968         (testWebKitConsoleMessageNetworkError):
2969         (testWebKitConsoleMessageSecurityError):
2970         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2971         (testCookieManagerAcceptPolicy):
2972         (testCookieManagerCookiesChanged):
2973         (testCookieManagerPersistentStorage):
2974         (testCookieManagerPersistentStorageDeleteAll):
2975         (testCookieManagerEphemeral):
2976         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2977         (testWebKitDOMElementAutoFill):
2978         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2979         (downloadLocalFileSuccessfully):
2980         (createFileAtDestination):
2981         (testDownloadOverwriteDestinationDisallowed):
2982         (testDownloadLocalFileError):
2983         (testDownloadRemoteFile):
2984         (testDownloadRemoteFileError):
2985         (testWebViewDownloadURI):
2986         (testPolicyResponseDownload):
2987         (testPolicyResponseDownloadCancel):
2988         (testDownloadMIMEType):
2989         (contextMenuCallback):
2990         (testContextMenuDownloadActions):
2991         (testBlobDownload):
2992         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2993         (testWebKitWebEditorSelectionChanged):
2994         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2995         (testWebKitFrameMainFrame):
2996         (testWebKitFrameURI):
2997         (testWebKitFrameJavaScriptContext):
2998         (testWebKitFrameJavaScriptValues):
2999         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3000         (LoadStopTrackingTest::loadFailed):
3001         (testWebViewTitle):
3002         (testURIRequestHTTPHeaders):
3003         (testURIRequestHTTPMethod):
3004         (testURIResponseHTTPHeaders):
3005         (testRedirectToDataURI):
3006         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3007         (testProcessPerWebView):
3008         (testWebProcessLimit):
3009         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3010         (testWebViewResources):
3011         (testWebResourceLoading):
3012         (testWebResourceSuggestedFilename):
3013         (testWebResourceGetData):
3014         (testWebResourceGetDataError):
3015         (testWebViewResourcesHistoryCache):
3016         (testWebResourceSendRequest):
3017         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3018         (testSSL):
3019         (testInsecureContent):
3020         (testTLSErrorsPolicy):
3021         (testTLSErrorsRedirect):
3022         (testTLSErrorsHTTPAuth):
3023         (testLoadFailedWithTLSErrors):
3024         (testSubresourceLoadFailedWithTLSErrors):
3025         (httpsServerCallback):
3026         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3027         (testWebViewCreateNavigationData):
3028         (testWebViewJavaScriptDialogs):
3029         (testWebViewWindowProperties):
3030         (testWebViewMouseTarget):
3031         (testWebViewFileChooserRequest):
3032         (testWebViewColorChooserRequest):
3033         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3034         (testWebExtensionGetTitle):
3035         (testDocumentLoadedSignal):
3036         (testWebKitWebViewProcessCrashed):
3037         (testWebExtensionWindowObjectCleared):
3038         (testWebExtensionIsolatedWorld):
3039         (permissionRequestCallback):
3040         (didAssociateFormControlsCallback):
3041         (testWebExtensionFormControlsAssociated):
3042         (FormSubmissionTest::FormSubmissionTest):
3043         (FormSubmissionTest::testFormSubmissionResult):
3044         (testWebExtensionFormSubmissionSteps):
3045         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3046         (testNotInitialized):
3047         (testClearDatabase):
3048         (testPrivateBrowsing):
3049         (testGetFavicon):
3050         (testWebViewFavicon):
3051         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3052         (testFindControllerTextFound):
3053         (testFindControllerTextNotFound):
3054         (testFindControllerMatchCount):
3055         (testFindControllerMaxMatchCount):
3056         (testFindControllerNext):
3057         (testFindControllerPrevious):
3058         (testFindControllerCountedMatches):
3059         (testFindControllerOptions):
3060         (testFindControllerHide):
3061         (testFindControllerInstance):
3062         (testFindControllerGetters):
3063         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3064         (testNavigationPolicy):
3065         (testResponsePolicy):
3066         (testNewWindowPolicy):
3067         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3068         (testSecurityOriginBasicConstructor):
3069         (testSecurityOriginURIConstructor):
3070         (testSecurityOriginDefaultPort):
3071         (testSecurityOriginFileURI):
3072         (testOpaqueSecurityOrigin):
3073         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3074         (testWebKitSettings):
3075         (testWebKitSettingsNewWithSettings):
3076         (testWebKitSettingsUserAgent):
3077         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3078         (testWebViewNewWithUserContentManager):
3079         (isStyleSheetInjectedForURLAtPath):
3080         (isScriptInjectedForURLAtPath):
3081         (testUserContentManagerInjectedStyleSheet):
3082         (testUserContentManagerInjectedScript):
3083         (UserScriptMessageTest::scriptMessageReceived):
3084         (UserScriptMessageTest::waitUntilMessageReceived):
3085         (UserScriptMessageTest::runJavaScriptFinished):
3086         (testUserContentManagerScriptMessageReceived):
3087         (testUserContentManagerScriptMessageInWorldReceived):
3088         (testUserContentManagerScriptMessageFromDOMBindings):
3089         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3090         (testWebContextDefault):
3091         (testWebContextEphemeral):
3092         (testWebContextGetPlugins):
3093         (testWebContextURIScheme):
3094         (testWebContextSpellChecker):
3095         (testWebContextLanguages):
3096         (consoleMessageReceivedCallback):
3097         (testWebContextSecurityFileXHR):
3098         (ProxyTest::ProxyTest):
3099         (testWebContextProxySettings):
3100         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3101         (testWebViewWebContext):
3102         (testWebViewWebBackend):
3103         (testWebViewEphemeral):
3104         (testWebViewCustomCharset):
3105         (testWebViewSettings):
3106         (testWebViewRunJavaScript):
3107         (testWebViewCanShowMIMEType):
3108         (testWebViewSubmitForm):
3109         (testWebViewSave):
3110         (testWebViewPageVisibility):
3111         (testWebViewSnapshot):
3112         (testWebViewNotification):
3113         (testWebViewNotificationInitialPermissionAllowed):
3114         (testWebViewNotificationInitialPermissionDisallowed):
3115         (testWebViewIsPlayingAudio):
3116         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3117         (WebsiteDataTest::WebsiteDataTest):
3118         (WebsiteDataTest::remove):
3119         (WebsiteDataTest::clear):
3120         (testWebsiteDataConfiguration):
3121         (testWebsiteDataEphemeral):
3122         (testWebsiteDataCache):
3123         (testWebsiteDataStorage):
3124         (testWebsiteDataDatabases):
3125         (testWebsiteDataAppcache):
3126         (testWebsiteDataCookies):
3127         (testWebsiteDataDeviceIdHashSalt):
3128         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3129         (emitDocumentLoaded):
3130         (emitURIChanged):
3131         (sendRequestCallback):
3132         (contextMenuCallback):
3133         (consoleMessageSentCallback):
3134         (emitFormControlsAssociated):
3135         (formControlsAssociatedCallback):
3136         (emitFormSubmissionEvent):
3137         (willSubmitFormCallback):
3138         (windowObjectCleared):
3139         (methodCallCallback):
3140         (registerGResource):
3141         (webkit_web_extension_initialize_with_user_data):
3142         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3143         (checkLeaks):
3144         (WebProcessTest::create):
3145         (runTest):
3146         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3147         (AutocleanupsTest::testWebProcessAutocleanups):
3148         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3149         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3150         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3151         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3152         (WebKitDOMDOMWindowTest::testSignals):
3153         (WebKitDOMDOMWindowTest::testDispatchEvent):
3154         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3155         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3156         (WebKitDOMNodeFilterTest::testTreeWalker):
3157         (WebKitDOMNodeFilterTest::testNodeIterator):
3158         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3159         (WebKitDOMNodeTest::testHierarchyNavigation):
3160         (WebKitDOMNodeTest::testInsertion):
3161         (WebKitDOMNodeTest::testTagNamesNodeList):
3162         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3163         (WebKitDOMNodeTest::testDOMCache):
3164         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3165         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3166         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3167         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3168         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3169         (testUIProcessAutocleanups):
3170         (testWebProcessAutocleanups):
3171         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3172         (testContextMenuPopulateMenu):
3173         (testContextMenuDismissed):
3174         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3175         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3176         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3177         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3178         (testWebKitDOMDOMWindowSignals):
3179         (testWebKitDOMDOMWindowDispatchEvent):
3180         (testWebKitDOMDOMWindowGetComputedStyle):
3181         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3182         (testWebKitDOMNodeHierarchyNavigation):
3183         (testWebKitDOMNodeInsertion):
3184         (testWebKitDOMNodeTagNamesNodeList):
3185         (testWebKitDOMNodeTagNamesHTMLCollection):
3186         (testWebKitDOMObjectCache):
3187         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3188         (testWebKitDOMNodeFilterTreeWalker):
3189         (testWebKitDOMNodeFilterNodeIterator):
3190         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3191         (testWebKitDOMXPathNSResolverNative):
3192         (testWebKitDOMXPathNSResolverCustom):
3193         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3194         (testInspectorDefault):
3195         (testInspectorManualAttachDetach):
3196         (testInspectorCustomContainerDestroyed):
3197         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3198         (startTestServer):
3199         (testInspectorServerPageList):
3200         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3201         (OptionMenuTest::showOptionMenuCallback):
3202         (OptionMenuTest::menuCloseCallback):
3203         (OptionMenuTest::close):
3204         (OptionMenuTest::activateItem):
3205         (OptionMenuTest::selectItem):
3206         (testOptionMenuSimple):
3207         (testOptionMenuGroups):
3208         (testOptionMenuActivate):
3209         (testOptionMenuSelect):
3210         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3211         (testPrintOperationPrintSettings):
3212         (webViewPrintCallback):
3213         (testPrintOperationPrint):
3214         (testPrintCustomWidget):
3215         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3216         (checkAtspiAccessible):
3217         (testAtspiBasicHierarchy):
3218         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3219         (testWebKitCheckVersion):
3220         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3221         (testWebViewEditorCutCopyPasteNonEditable):
3222         (testWebViewEditorCutCopyPasteEditable):
3223         (testWebViewEditorSelectAllNonEditable):
3224         (testWebViewEditorSelectAllEditable):
3225         (loadContentsAndTryToCutSelection):
3226         (testWebViewEditorNonEditable):
3227         (testWebViewEditorEditable):
3228         (testWebViewEditorEditorStateTypingAttributes):
3229         (testWebViewEditorInsertImage):
3230         (testWebViewEditorCreateLink):
3231         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3232         (loadChangedCallback):
3233         (loadFailedCallback):
3234         (loadFailedWithTLSErrorsCallback):
3235         (LoadTrackingTest::LoadTrackingTest):
3236         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3237         (registerGResource):
3238         (removeNonEmptyDirectory):
3239         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3240         (Test::adoptView):
3241         (Test::~Test):
3242         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3243         (WebKitTestBus::getOrCreateConnection):
3244         (WebKitTestBus::createProxy):
3245         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3246         (WebKitTestServer::getWebSocketURIForPath const):
3247         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3248         (WebViewTest::initializeWebView):
3249         (WebViewTest::loadURI):
3250         (WebViewTest::loadHtml):
3251         (WebViewTest::loadPlainText):
3252         (WebViewTest::loadBytes):
3253         (WebViewTest::loadRequest):
3254         (WebViewTest::loadAlternateHTML):
3255         (WebViewTest::goBack):
3256         (WebViewTest::goForward):
3257         (WebViewTest::goToBackForwardListItem):
3258         (resourceGetDataCallback):
3259         (WebViewTest::mainResourceData):
3260         (WebViewTest::javascriptResultToCString):
3261         (WebViewTest::javascriptResultToNumber):
3262         (WebViewTest::javascriptResultToBoolean):
3263         (WebViewTest::javascriptResultIsNull):
3264         (WebViewTest::javascriptResultIsUndefined):
3265         (onSnapshotReady):
3266         (WebViewTest::runWebProcessTest):
3267         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3268         (WebViewTest::platformInitializeWebView):
3269         (WebViewTest::showInWindow):
3270         (WebViewTest::showInWindowAndWaitUntilMapped):
3271         (WebViewTest::mouseMoveTo):
3272         (WebViewTest::emitPopupMenuSignal):
3273         (WebViewTest::keyStroke):
3274         (WebViewTest::doMouseButtonEvent):
3275
3276 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3277
3278         [WPE] API tests can't run in flatpak environment
3279         https://bugs.webkit.org/show_bug.cgi?id=193242
3280
3281         Reviewed by Michael Catanzaro.
3282
3283         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3284         flatpakutils so that it knows which port it's dealing with.
3285         * glib/common.py: Remove build_dir globals so that subsequent
3286         calls actually take args into account.
3287         (library_build_path):
3288         (binary_build_path):
3289
3290 2019-01-08  Dean Jackson  <dino@apple.com>
3291
3292         Blob references for System Previews don't get a correct file extension
3293         https://bugs.webkit.org/show_bug.cgi?id=193268
3294         <rdar://problem/47133037>
3295
3296         Reviewed by Tim Horton.
3297
3298         New test that a Blob download of a USDZ file gets named correctly.
3299
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3301         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3302         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3303         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3304         (TEST):
3305         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3306
3307 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3308
3309         [WebAuthN] Support U2F HID Authenticators on macOS
3310         https://bugs.webkit.org/show_bug.cgi?id=191535
3311         <rdar://problem/47102027>
3312
3313         Reviewed by Brent Fulgham.
3314
3315         This patch:
3316         1) adds support for U2F mocking mechanism;
3317         2) updates tests to reflect U2fCommandConstructor changes.
3318
3319         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3320         (TestWebKitAPI::TEST):
3321         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3323         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3324
3325 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3326
3327         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3328         https://bugs.webkit.org/show_bug.cgi?id=193229
3329         <rdar://problem/46717097>
3330
3331         Reviewed by Tim Horton.
3332
3333         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3334         prevents a drag from starting.
3335
3336         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3337         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3338
3339         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3340
3341 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3342   
3343         Layout test will generate a perf metric file to results dir.
3344         https://bugs.webkit.org/show_bug.cgi?id=192030
3345         <rdar://problem/32779516>
3346
3347         Reviewed by Aakash Jain.
3348
3349         Layout test running time will be collected to a perf metric file.
3350         For now, instead of outputing running time of all tests (which is huge),
3351         we aggregate them by test directories which are at most two level deep. 
3352
3353         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3354         (Manager._end_test_run):
3355         (Manager._output_perf_metrics):
3356         (Manager._print_expectation_line_for_test):
3357         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3358         (add_test_perf_metric):
3359         (test_perf_metrics):
3360         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3361         (JSONGeneratorTest.test_test_timings_trie):
3362         (JSONGeneratorTest):
3363         (JSONGeneratorTest.test_test_perf_metrics):
3364         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3365         (RebaselineTest.test_reset_results):
3366         (RebaselineTest.test_missing_results):
3367         (RebaselineTest.test_new_baseline):
3368
3369 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3370
3371         [WPE][GTK] Add php-json to install-dependencies
3372         https://bugs.webkit.org/show_bug.cgi?id=193233
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         * gtk/install-dependencies:
3377         * wpe/install-dependencies:
3378
3379 2019-01-08  Chris Dumez  <cdumez@apple.com>
3380
3381         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3382         https://bugs.webkit.org/show_bug.cgi?id=193224
3383         <rdar://problem/47097726>
3384
3385         Reviewed by Alex Christensen.
3386
3387         Add API test coverage.
3388
3389         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3390
3391 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3392
3393         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3394         <https://webkit.org/b/193222>
3395         <rdar://problem/46862309>
3396
3397         Reviewed by Joseph Pecoraro.
3398
3399         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3400         (WTR::executeCallback): Fix camel case of variable name.
3401         (WTR::EventSendingController::callAfterScrollingCompletes): If
3402         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3403         false, make sure to release the ScrollCompletionCallbackData
3404         object.  This fixes the leak.
3405
3406 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3407
3408         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3409         https://bugs.webkit.org/show_bug.cgi?id=193044
3410
3411         Reviewed by Daniel Bates.
3412
3413         WinCairo EWS bots are using Windows Perl. Binary files should be
3414         opened as binary mode.
3415
3416         * Scripts/svn-apply:
3417         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3418
3419 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3420
3421         [CMake] Add ENABLE_CSS_TYPED_OM option
3422         https://bugs.webkit.org/show_bug.cgi?id=193216
3423
3424         Reviewed by Michael Catanzaro.
3425
3426         * Scripts/webkitperl/FeatureList.pm:
3427
3428 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3429
3430         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3431         <https://webkit.org/b/193056>
3432
3433         Reviewed by Alex Christensen.
3434
3435         * Scripts/webkitpy/style/checker.py:
3436         - Ignore use of new runtime/retainptr check in
3437           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3438           contains tests to ensure RetainPtr<NSObject *> is compatible
3439           with RetainPtr<NSObject>.
3440
3441         * Scripts/webkitpy/style/checkers/cpp.py:
3442         (check_language):
3443         (CppChecker):
3444         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3445           was used instead of a single regex so that angle brackets
3446           could be matched up when checking the type contained within
3447           the RetainPtr<> type.
3448
3449         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3450         (CppStyleTest):
3451         - Add unit test for new runtime/retainptr check.
3452
3453         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3454         * TestWebKitAPI/EditingTestHarness.h:
3455         - Remove '*' from RetainPtr<> type.
3456
3457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3458         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3459           regressed in r201938.
3460
3461         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3462         (TestWebKitAPI::TEST):
3463         - Update tests to match RetainPtr.mm tests (except for the
3464           `*SimilarNSType` tests since there is no CF equivalent of
3465           RetainPtr<NSString> and RetainPtr<NSString *>).
3466
3467         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3468         (TestWebKitAPI::TEST):
3469         - Update tests to:
3470           - Not conflict by name with equivalent CF tests in
3471             RetainPtr.cpp.
3472           - Add test cases for RetainPtr<NSObject>,
3473             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3474           - Add `*SimilarNSType` tests for converting between
3475             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3476           - Change `0` to `nil` as appropriate.
3477           - Re-alphabetize the tests by name.
3478           - Add Optional<RetainPtr<>> tests.
3479           - Add retainPtr() tests.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3482         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3483         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3484         (TEST):
3485         - Remove '*' from RetainPtr<> type.
3486
3487         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3488         (TEST(WebKit, JITEnabled)):
3489         - Add missing WTFMove().  Apparently a temporary was being
3490           created before in the argument list due to mismatched
3491           RetainPtr<> types.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3494         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3495         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3496         (TestWebKitAPI::TEST):
3497         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3498         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3499         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3500         (WTR::resourcesDirectoryURL):
3501         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3502         (WTR::InjectedBundle::platformInitialize):
3503         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3504         - Remove '*' from RetainPtr<> type.
3505
3506 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3507
3508         A MediaTime timescale must never be zero
3509         https://bugs.webkit.org/show_bug.cgi?id=193156
3510         <rdar://problem/32504501>
3511
3512         Reviewed by Jer Noble.
3513
3514         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3515         (TestWebKitAPI::TEST): Add tests for zero timescale.
3516
3517 2019-01-07  Youenn Fablet  <youenn@apple.com>
3518
3519         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3520         https://bugs.webkit.org/show_bug.cgi?id=193175
3521
3522         Reviewed by Chris Dumez.
3523
3524         Updated API test as we bumped the SW schema to version 4.
3525
3526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3527         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3528         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3529         (TEST):
3530
3531 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3532
3533         [Win][Clang] Fix compilation warnings of MiniBrowser
3534         https://bugs.webkit.org/show_bug.cgi?id=193029
3535
3536         Reviewed by Ross Kirsling.
3537
3538         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3539         and m_URLBarFont. Reorder member variables to fix -Wreorder
3540         warning.
3541         * MiniBrowser/win/PageLoadTestClient.cpp:
3542         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3543         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3544         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3545         m_currentURLIndex.
3546         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3547         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3548         navigationClient with '{ }' to fix the missing field warning.
3549         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3550         (initDocStruct): Changed the argument type docname to const.
3551
3552 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3553
3554         [WebAuthN] Import U2F command/response converters from Chromium
3555         https://bugs.webkit.org/show_bug.cgi?id=193150
3556         <rdar://problem/47054028>
3557
3558         Reviewed by Brent Fulgham.
3559
3560         Adds API tests.
3561
3562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3563         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3564         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3565         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3566         (TestWebKitAPI::getTestAttestationObjectBytes):
3567         (TestWebKitAPI::getTestSignResponse):
3568         (TestWebKitAPI::getTestU2fRegisterResponse):
3569         (TestWebKitAPI::TEST):
3570         (TestWebKitAPI::convertToVector): Deleted.
3571         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3572         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3573         (TestWebKitAPI::constructMakeCredentialRequest):
3574         (TestWebKitAPI::constructGetAssertionRequest):
3575         (TestWebKitAPI::TEST):
3576
3577 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3578
3579         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3580         https://bugs.webkit.org/show_bug.cgi?id=193136
3581
3582         Reviewed by Michael Catanzaro.
3583
3584         * gtk/install-dependencies:
3585         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3586         they are needed by update-webkitgtk-libs.
3587
3588 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3589
3590         Unreviewed follow-up fix to r239650
3591         https://bugs.webkit.org/show_bug.cgi?id=193140
3592         <rdar://problem/47063037>
3593
3594         Typecast patch_id to string.
3595
3596         * BuildSlaveSupport/ews-build/steps.py:
3597         (ValidatePatch._is_patch_obsolete):
3598
3599 2019-01-04  Daniel Bates  <dabates@apple.com>
3600
3601         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3602         https://bugs.webkit.org/show_bug.cgi?id=193024
3603
3604         Reviewed by Jer Noble.
3605
3606         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3607         for the bitmask type WebEventFlags as an example.
3608
3609         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3610         that can be used to register summary and synthetic child formatters for a bitmask type.
3611         For example, consider the following enum and bitmask typedefs:
3612
3613         typedef enum {
3614             A = 1 << 0,
3615             B = 1 << 1,
3616             C = 1 << 2,
3617         } SpecialFlagValues;
3618         typedef unsigned SpecialFlags;
3619
3620         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3621         __lldb_init_module():
3622
3623             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3624                     1 << 0: "A",
3625                     1 << 1: "B",
3626                     1 << 2: "C",
3627             })
3628
3629         * lldb/lldb_webkit.py:
3630         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3631         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3632         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3633         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3634         A convenience function to dynamically creaste a synthetic formatter class and summary
3635         string function for the specified bitmask type and enumerator value to name map. This
3636         function register the dynamically created class and function with LLDB.
3637
3638         (__lldb_init_module):
3639         (FlagEnumerationProvider):
3640         (FlagEnumerationProvider._enumerator_value_to_name_map):
3641         (FlagEnumerationProvider._bitmask):
3642         (FlagEnumerationProvider._update):
3643         (FlagEnumerationProvider.has_children):
3644         (FlagEnumerationProvider.num_children):
3645         (FlagEnumerationProvider.get_child_index):
3646         (FlagEnumerationProvider.get_child_at_index):
3647         (FlagEnumerationProvider.update):
3648         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3649
3650         (WTFOptionSetProvider):
3651         (WTFOptionSetProvider._enumerator_value_to_name_map):
3652         (WTFOptionSetProvider._bitmask):
3653         (WTFOptionSetProvider._update):
3654         Write in terms of the base class.
3655
3656         (RawBitmaskProviderBase):
3657         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3658         (RawBitmaskProviderBase._bitmask):
3659         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3660         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3661         {
3662             1 << 0: "A",
3663             1 << 1: "B",
3664             1 << 2: "C",
3665         }
3666         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3667         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3668
3669         (WTFOptionSetProvider.has_children): Deleted.
3670         (WTFOptionSetProvider.num_children): Deleted.
3671         (WTFOptionSetProvider.get_child_index): Deleted.
3672         (WTFOptionSetProvider.get_child_at_index): Deleted.
3673         (WTFOptionSetProvider.update): Deleted.
3674
3675 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3676
3677         [ews-build] Add build step to validate the patch before processing it
3678         https://bugs.webkit.org/show_bug.cgi?id=193140
3679
3680         Reviewed by Lucas Forschler.
3681
3682         * BuildSlaveSupport/ews-build/factories.py:
3683         (Factory.__init__): Added ValidatePatch step.
3684         * BuildSlaveSupport/ews-build/steps.py:
3685         (ValidatePatch):
3686         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3687         (ValidatePatch.get_patch_json): Get patch json data.
3688         (ValidatePatch.get_bug_json): Get bug json data.
3689         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3690         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3691         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3692         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3693         (ValidatePatch.skip_build): Skip the build.
3694         (ValidatePatch.start):
3695
3696 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3697
3698         Progress towards fixing Mac CMake build
3699         https://bugs.webkit.org/show_bug.cgi?id=193105
3700
3701         Reviewed by Don Olmstead.
3702
3703         * TestWebKitAPI/PlatformMac.cmake:
3704
3705 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3706
3707         Fix API test after r239631
3708         https://bugs.webkit.org/show_bug.cgi?id=193118
3709
3710         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3711         (TestWebKitAPI::TEST):
3712         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3713         Do the same thing via the API to fix the test.
3714
3715 2019-01-04  Jer Noble  <jer.noble@apple.com>
3716
3717         [WebKitLegacy] Media playback pauses on scroll
3718         https://bugs.webkit.org/show_bug.cgi?id=192829
3719
3720         Reviewed by Eric Carlson.
3721
3722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3723         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3724         (TestWebKitAPI::TEST):
3725         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3726         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3727         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3728         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3729         (TestWebKitAPI::TEST):
3730
3731 2019-01-04  Chris Dumez  <cdumez@apple.com>
3732
3733         Add support for toggling device orientation API support per site
3734         https://bugs.webkit.org/show_bug.cgi?id=193143
3735         <rdar://problem/46605724>
3736
3737         Reviewed by Alex Christensen.
3738
3739         Add API test coverage.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3742         (-[DataMappingSchemeHandler setTaskHandler:]):
3743         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3744         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3745         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3746         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3747
3748 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3749
3750         [ews-build] use svn-apply script to apply the patches
3751         https://bugs.webkit.org/show_bug.cgi?id=193138
3752
3753         Reviewed by Lucas Forschler.
3754
3755         * BuildSlaveSupport/ews-build/factories.py:
3756         (Factory.__init__): Add the ApplyPatch step.
3757         * BuildSlaveSupport/ews-build/steps.py:
3758         (CheckOutSource): Added step name.
3759         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3760         (ApplyPatch): Build step to apply patch using svn-apply script.
3761         (UnApplyPatchIfRequired):
3762         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3763
3764 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3765
3766         Deprecate WKContextCreate
3767         https://bugs.webkit.org/show_bug.cgi?id=193118
3768
3769         Reviewed by Brady Eidson.
3770
3771         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3772         (WebKitBrowserWindow::WebKitBrowserWindow):
3773         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3774         (TestWebKitAPI::TEST):
3775         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3776         (TestWebKitAPI::TEST):
3777         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3778         (TestWebKitAPI::TEST):
3779         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3780         (TestWebKitAPI::TEST):
3781         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3782         (TestWebKitAPI::TEST):
3783         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3784         (TestWebKitAPI::TEST):
3785         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3786         (TestWebKitAPI::TEST):
3787         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3788         (TestWebKitAPI::TEST):
3789         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3790         (TestWebKitAPI::TEST):
3791         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3792         (TestWebKitAPI::TEST):
3793         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3794         (TestWebKitAPI::TEST):
3795         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3796         (TestWebKitAPI::TEST):
3797         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3798         (TestWebKitAPI::TEST):
3799         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3800         (TestWebKitAPI::TEST):
3801         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3802         (TestWebKitAPI::TEST):
3803         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3804         (TestWebKitAPI::TEST):
3805         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3806         (TestWebKitAPI::TEST):
3807         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3808         (TestWebKitAPI::TEST):
3809         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3810         (TestWebKitAPI::loadAlternateHTMLString):
3811         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3812         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3813         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3814         (TestWebKitAPI::buildAndPerformTest):
3815         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3816         (TestWebKitAPI::TEST):
3817         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3818         (TestWebKitAPI::TEST):
3819         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3820         (TestWebKitAPI::TEST):
3821         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3822         (TestWebKitAPI::TEST):
3823         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3824         (TestWebKitAPI::TEST):
3825         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3826         (TestWebKitAPI::TEST):
3827         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3828         (TestWebKitAPI::TEST):
3829         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3830         (TestWebKitAPI::TEST):
3831         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3832         (TestWebKitAPI::TEST):
3833         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3834         (TestWebKitAPI::TEST):
3835         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3836         (TestWebKitAPI::TEST):
3837         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3838         (TestWebKitAPI::TEST):
3839         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3840         (TestWebKitAPI::TEST):
3841         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3842         (TestWebKitAPI::TEST):
3843         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3844         (TestWebKitAPI::TEST):
3845         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3846         (TestWebKitAPI::TEST):
3847         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3848         (TestWebKitAPI::TEST):
3849         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3850         (TestWebKitAPI::TEST):
3851         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3852         (TestWebKitAPI::TEST):
3853         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3854         (TestWebKitAPI::TEST):
3855         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3856         (TestWebKitAPI::TEST):
3857         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3858         (TestWebKitAPI::TEST):
3859         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3860         (TestWebKitAPI::TEST):
3861         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3862         (TestWebKitAPI::TEST):
3863         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3864         (TestWebKitAPI::TEST):
3865         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3866         (TestWebKitAPI::TEST):
3867         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3868         (WebKit2_CommandBackForwardTestWKView::SetUp):
3869         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3870         (TestWebKitAPI::TEST):
3871         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3872         (TestWebKitAPI::TEST):
3873         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3874         (TestWebKitAPI::TEST):
3875         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3876         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3877
3878 2019-01-03  Matt Rajca  <mrajca@apple.com>
3879
3880         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3881         https://bugs.webkit.org/show_bug.cgi?id=193128
3882         rdar://34554231
3883
3884         Reviewed by Jer Noble.
3885
3886         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3887         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3888         event along with a flag that indicates whether or not autoplay was actually prevented.
3889
3890         Tests: existing API tests were updated to reflect the new names. New API tests
3891         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3892
3893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3894         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3895         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3896         (TEST):
3897         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3898         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3899
3900 2019-01-04  Chris Dumez  <cdumez@apple.com>
3901
3902         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3903         https://bugs.webkit.org/show_bug.cgi?id=193120
3904
3905         Reviewed by Alex Christensen.
3906
3907         Add API test coverage.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3910
3911 2019-01-04  Chris Dumez  <cdumez@apple.com>
3912
3913         Crash under WebProcessPool::addSuspendedPage()
3914         https://bugs.webkit.org/show_bug.cgi?id=193110
3915
3916         Reviewed by Youenn Fablet.
3917
3918         Add API test coverage.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3921
3922 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3923
3924         [ews-build] Check patch relevance before applying the patch
3925         https://bugs.webkit.org/show_bug.cgi?id=193102
3926
3927         Reviewed by Lucas Forschler.
3928
3929         * BuildSlaveSupport/ews-build/factories.py:
3930         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3931
3932 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3933
3934         [ews-build] Check patch relevance step should print patch id
3935         https://bugs.webkit.org/show_bug.cgi?id=193137
3936
3937         Reviewed by Lucas Forschler.
3938
3939         * BuildSlaveSupport/ews-build/steps.py:
3940         (CheckPatchRelevance.start): Update the status to include patch id.
3941
3942 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3943
3944         webkitpy: Increase simulator teardown timeout
3945         https://bugs.webkit.org/show_bug.cgi?id=193141
3946         <rdar://problem/46174217>
3947
3948         Rubber-stamped by Aakash Jain.
3949
3950         * Scripts/webkitpy/xcode/simulated_device.py:
3951         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3952
3953 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3954
3955         test262-runner misbehaves when test file YAML has a trailing space
3956         https://bugs.webkit.org/show_bug.cgi?id=193053
3957
3958         Reviewed by Yusuke Suzuki.
3959
3960         * Scripts/test262/Runner.pm:
3961         (parseData):
3962         Accept trailing space when parsing a test file's YAML block.
3963
3964 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3965
3966         UserMedia test should use WKPageNavigationClient
3967         https://bugs.webkit.org/show_bug.cgi?id=192913
3968
3969         Reviewed by Youenn Fablet.
3970
3971         The test currently uses the deprecated WKPageLoaderClient. It should use
3972         WKPageNavigationClient instead, which provides the same callback under a similar name.
3973
3974         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3975         (TestWebKitAPI::TEST):
3976
3977 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3978
3979         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3980         https://bugs.webkit.org/show_bug.cgi?id=192944
3981
3982         Reviewed by Tim Horton.
3983
3984         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3985         (TestWebKitAPI::TEST):
3986
3987 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3988
3989         Add support for using the current text selection as the find string on iOS
3990         https://bugs.webkit.org/show_bug.cgi?id=193034
3991         <rdar://problem/45138739>
3992
3993         Reviewed by Tim Horton.
3994
3995         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3996         _setStringForFind) works as expected.
3997
3998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3999         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
4000
4001 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
4002
4003         [ews-build] Use git on OpenSource EWS bots
4004         https://bugs.webkit.org/show_bug.cgi?id=193092
4005
4006         Reviewed by Lucas Forschler.
4007
4008         * BuildSlaveSupport/ews-build/steps.py:
4009         (CheckOutSource): Use git instead of svn.
4010         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
4011
4012 2019-01-02  Daniel Bates  <dabates@apple.com>
4013
4014         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
4015         https://bugs.webkit.org/show_bug.cgi?id=193023
4016
4017         Reviewed by Simon Fraser.
4018
4019         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
4020         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
4021         enumerator values. We should just remove this code.
4022
4023         * lldb/lldb_webkit.py:
4024         (WTFOptionSetProvider.has_children):
4025         (WTFOptionSetProvider.num_children):
4026         (WTFOptionSetProvider.get_child_index):
4027         (WTFOptionSetProvider.get_child_at_index):
4028
4029 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
4030
4031         .ycm_extra_conf.py should handle XXXInlines.h
4032         https://bugs.webkit.org/show_bug.cgi?id=193055
4033
4034         Reviewed by Carlos Garcia Campos.
4035
4036         compile_commands.json database only records flags and options for cpp source files.
4037         So, when we open headers, this database does not have any information for that.
4038         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
4039         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
4040         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
4041         we attempt to find XXX.cpp and use the configuration if it exists.
4042
4043         * gtk/ycm_extra_conf.py:
4044         (getImplementationFilename):
4045         (FlagsForFile):
4046
4047 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4048
4049         Unreviewed. Support PHP 7.3 in Debian.
4050
4051         Add 7.3 to the list of php versions supported in Debian.
4052
4053         * Scripts/webkitpy/port/base.py:
4054         (Port._debian_php_version):
4055
4056 2018-12-27  Alex Christensen  <achristensen@webkit.org>
4057
4058         Resurrect Mac CMake build
4059         https://bugs.webkit.org/show_bug.cgi?id=192658
4060
4061         Reviewed by Yusuke Suzuki.
4062
4063         * DumpRenderTree/PlatformMac.cmake:
4064         * MiniBrowser/mac/CMakeLists.txt:
4065         * TestWebKitAPI/PlatformMac.cmake:
4066
4067 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
4068
4069         [Tools] Remove references to Bison and Flex
4070         https://bugs.webkit.org/show_bug.cgi?id=193033
4071
4072         Reviewed by Michael Catanzaro.
4073
4074         The Bison and Flex tools are not needed anymore since r209883.
4075
4076         * CygwinDownloader/cygwin-downloader.py:
4077         * EWSTools/ubuntu-ews-packages:
4078         * Scripts/filter-build-webkit:
4079         (shouldIgnoreLine):
4080         * gtk/install-dependencies:
4081         * wpe/install-dependencies:
4082
4083 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4084
4085         WebDriver: warn about non existing tests when parsing expectations
4086         https://bugs.webkit.org/show_bug.cgi?id=192979
4087
4088         Reviewed by Michael Catanzaro.
4089
4090         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
4091         renamed.
4092
4093         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
4094         (WebDriverTestRunner.__init__):
4095
4096 2018-12-21  Chris Dumez  <cdumez@apple.com>
4097
4098         navigator.userAgent in service workers does not reflect customUserAgent set by client
4099         https://bugs.webkit.org/show_bug.cgi?id=192951
4100
4101         Reviewed by Youenn Fablet.
4102
4103         Extend API test coverage.
4104
4105         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4106         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
4107         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4108         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
4109         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4110
4111 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
4112
4113         [WebAuthN] userPresence should always be true
4114         https://bugs.webkit.org/show_bug.cgi?id=192835
4115         <rdar://problem/46538788>
4116
4117         Reviewed by Brent Fulgham.
4118
4119         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
4120         (TestWebKitAPI::TEST):
4121
4122 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
4123
4124         Add support to run-benchmark to use non-default copies of the browser apps
4125         https://bugs.webkit.org/show_bug.cgi?id=192905
4126         rdar://problem/46845840
4127
4128         Reviewed by Dewei Zhu.
4129         
4130         Add support for a --browser-path argument to run-benchmark, which allows you to use
4131         a custom app bundle for a given browser (only implemented for Safari at present).
4132
4133         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4134         (BenchmarkRunner.__init__):
4135         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4136         (BrowserDriver.__init__):
4137         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4138         (BrowserDriverFactory.create):
4139         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4140         (OSXBrowserDriver._launch_process):
4141         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
4142         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
4143         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
4144         (OSXChromeCanaryDriver.launch_url):
4145         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
4146         (OSXFirefoxNightlyDriver.launch_url):
4147         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4148         (OSXSafariDriver.__init__):
4149         (OSXSafariDriver.launch_url):
4150         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4151         (parse_args):
4152         (run_benchmark_plan):
4153         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
4154         (WebServerBenchmarkRunner.__init__):
4155         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
4156         (FakeBenchmarkRunner.__init__):
4157
4158 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
4159
4160         [WebAuthN] Import an APDU coder from Chromium
4161         https://bugs.webkit.org/show_bug.cgi?id=192949
4162         <rdar://problem/46879933>
4163
4164         Reviewed by Brent Fulgham.
4165
4166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4167         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
4168         (TestWebKitAPI::TEST):
4169
4170 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4171
4172         Setting the file wrapper and content type of an attachment to a PDF should update its image
4173         https://bugs.webkit.org/show_bug.cgi?id=192984
4174         <rdar://problem/46798028>
4175
4176         Reviewed by Tim Horton.
4177
4178         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
4179         PDF data correctly updates the image element.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4182
4183 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4184
4185         Add JSCOnly to bot dashboard
4186         https://bugs.webkit.org/show_bug.cgi?id=192964
4187
4188         Reviewed by Alexey Proskuryakov.
4189
4190         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
4191         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
4192         useful if they were not so secret, so add them.
4193
4194         There appear to be no build-only bots, so the first column is blank. And of course there are
4195         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
4196         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
4197         and there's plenty of room in the final column for all the bots.
4198
4199         I had a hard time picking a logo to use, because the JavaScript language does not have an
4200         official logo. But I believe I've found one that will be satisfactory.
4201
4202         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
4203
4204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
4205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
4206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4207         (BubbleQueueServer):
4208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4210         (WebKitBuildbot):
4211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4212         (table.queue-grid tr.platform.linux-jsconly img.logo):
4213
4214 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
4215
4216         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4217         https://bugs.webkit.org/show_bug.cgi?id=192821
4218
4219         Reviewed by Chris Dumez.
4220
4221         * DumpRenderTree/mac/DumpRenderTree.mm:
4222         (createWebViewAndOffscreenWindow):
4223         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4224
4225 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4226
4227         [Win][Clang] Fix compilation warnings of DumpRenderTree
4228         https://bugs.webkit.org/show_bug.cgi?id=192924
4229
4230         Reviewed by Alex Christensen.
4231
4232         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
4233         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4234         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
4235         * DumpRenderTree/win/DumpRenderTree.cpp:
4236         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
4237         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
4238         object to the argument of setDefaultTextEncodingName instead of a
4239         const string literal.
4240         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
4241         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
4242         (setCacheFolder): Deleted.
4243         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
4244         * DumpRenderTree/win/EditingDelegate.cpp:
4245         (dump): Use %d for int.
4246         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
4247         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4248         (BSTRFromString): Deleted unused function.
4249         * DumpRenderTree/win/TestRunnerWin.cpp:
4250         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4251         the arguemnt of setQuota instead of const string literal.
4252         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4253         (jsStringRefToWString): Deleted unused function.
4254
4255 2018-12-20  Chris Dumez  <cdumez@apple.com>
4256
4257         Add API test coverage for customUserAgent client setting and service workers
4258         https://bugs.webkit.org/show_bug.cgi?id=192952
4259
4260         Reviewed by Alex Christensen.
4261
4262         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4263         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4264         (-[SWSchemes webView:startURLSchemeTask:]):
4265         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4266         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4267
4268 2018-12-20  Chris Dumez  <cdumez@apple.com>
4269
4270         Use Optional::hasValue() instead of Optional::has_value()
4271         https://bugs.webkit.org/show_bug.cgi?id=192948
4272
4273         Reviewed by Tim Horton.
4274
4275         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4276         (TestWebKitAPI::TEST):
4277         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4278         (TestWebKitAPI::TEST):
4279         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4280         (TestWebKitAPI::TEST_F):
4281
4282 2018-12-20  Chris Dumez  <cdumez@apple.com>
4283
4284         Add style script rule to check for