[WPE][GTK] Load events may occur in unexpected order when JS redirects page before...
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4         https://bugs.webkit.org/show_bug.cgi?id=194131
5
6         Reviewed by Michael Catanzaro.
7
8         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
9         (uriChanged):
10         (testUnfinishedSubresourceLoad):
11         (serverCallback):
12         (beforeAll):
13
14 2019-03-11  Alex Christensen  <achristensen@webkit.org>
15
16         WTF::Expected should use std::addressof instead of operator&
17         https://bugs.webkit.org/show_bug.cgi?id=195604
18
19         Reviewed by Myles Maxfield.
20
21         * TestWebKitAPI/Tests/WTF/Expected.cpp:
22         (TestWebKitAPI::Unique::Unique):
23         (TestWebKitAPI::Unique::operator&):
24         (TestWebKitAPI::TEST):
25
26 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
27
28         Add Optional to Forward.h.
29         https://bugs.webkit.org/show_bug.cgi?id=195586
30
31         Reviewed by Darin Adler.
32
33         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
34         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
35         Remove unnecessary includes from headers.
36
37 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
38
39         Add testing API to hit-test and scroll overflow scrollers
40         https://bugs.webkit.org/show_bug.cgi?id=195278
41
42         Reviewed by Antti Koivisto.
43         
44         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
45         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
46         
47         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
48
49         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
50         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
51         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
52         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
53         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
54         * TestRunnerShared/UIScriptContext/UIScriptController.h:
55         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
56         (WTR::enclosingScrollViewIncludingSelf):
57         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
58
59 2019-03-11  Tim Horton  <timothy_horton@apple.com>
60
61         API test WebKit.RequestTextInputContext fails on iOS
62         https://bugs.webkit.org/show_bug.cgi?id=195585
63
64         Reviewed by Wenson Hsieh and Simon Fraser.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
67         (applyStyle):
68         (TEST):
69         Add a viewport, so that the coordinates match up on iOS.
70         Scroll by moving the UIScrollView's contentOffset.
71
72 2019-03-11  Chris Dumez  <cdumez@apple.com>
73
74         Assert in WebPageProxy::suspendCurrentPageIfPossible()
75         https://bugs.webkit.org/show_bug.cgi?id=195506
76         <rdar://problem/48733477>
77
78         Reviewed by Alex Christensen.
79
80         Add API test coverage.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
83
84 2019-03-11  Shawn Roberts  <sroberts@apple.com>
85
86         Adding myself to contributors.json
87
88         Unreviewed, addming myself to contributors.json .
89
90         * Scripts/webkitpy/common/config/contributors.json:
91
92 2019-03-11  Alex Christensen  <achristensen@webkit.org>
93
94         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
95         https://bugs.webkit.org/show_bug.cgi?id=195511
96         <rdar://problem/44873269>
97
98         Reviewed by Darin Adler.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
101         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
102         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
103         (TEST_F):
104
105 2019-03-11  Chris Dumez  <cdumez@apple.com>
106
107         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
108         https://bugs.webkit.org/show_bug.cgi?id=195561
109
110         Reviewed by Youenn Fablet.
111
112         Make sure the JS in the test requests for permission to receive device orientation events.
113
114         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
115
116 2019-03-11  Youenn Fablet  <youenn@apple.com>
117
118         Allow storage quota increase by default in WTR
119         https://bugs.webkit.org/show_bug.cgi?id=195541
120
121         Reviewed by Geoffrey Garen.
122
123         Allow storage quota increase by default in WTR.
124         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
125         Use this for tests that explicitly need cache increase.
126
127         Instead of increasing quota by 2, make sure the next request is
128         granted by adding all given parameters.
129
130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
132         (WTR::TestRunner::setAllowStorageQuotaIncrease):
133         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
135         * WebKitTestRunner/TestController.cpp:
136         (WTR::TestController::setAllowStorageQuotaIncrease):
137         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
138         * WebKitTestRunner/TestController.h:
139         * WebKitTestRunner/TestInvocation.cpp:
140         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
141         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
142         (WTR::TestController::cocoaResetStateToConsistentValues):
143         (WTR::TestController::setAllowStorageQuotaIncrease):
144         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
145         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
146         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
147
148 2019-03-11  Xan Lopez  <xan@igalia.com>
149
150         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
151         https://bugs.webkit.org/show_bug.cgi?id=194147
152
153         Reviewed by Michael Saboff.
154
155         To make --32-bit work correctly on Linux/64bit we need to:
156
157         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
158         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
159         unfortunately CMake only allows us to do this during
160         crosscompilation, which is overkill here.
161         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
162         pkg-config detection module uses the x86 .pc files instead of the
163         x86_64 ones.
164         - Set the -m32 flags for the compiler.
165
166         * Scripts/webkitdirs.pm:
167         (generateBuildSystemFromCMakeProject):
168
169 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
170
171         Add MotionMark-1.1 plan file for run-benchmark script.
172         https://bugs.webkit.org/show_bug.cgi?id=195481
173
174         Rubber-stamped by Darin Adler.
175
176         Run-benchmark script should support MontionMark-1.1.
177
178         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
179
180 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-app] Add support for submit-to-ews url
183         https://bugs.webkit.org/show_bug.cgi?id=195477
184
185         Reviewed by Lucas Forschler.
186
187         * BuildSlaveSupport/ews-app/ews/fetcher.py:
188         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
189         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
190         * BuildSlaveSupport/ews-app/ews/urls.py:
191         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
192
193 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
194
195         Unreviewed, rolling out r242688, r242643, r242624.
196
197         Caused multiple layout test failures and crashes on iOS and macOS.
198
199         Reverted changeset:
200
201         "requestAnimationFrame should execute before the next frame"
202         https://bugs.webkit.org/show_bug.cgi?id=177484
203         https://trac.webkit.org/changeset/242624/webkit
204
205         * Tracing/SystemTracePoints.plist:
206
207 2019-03-11  John Wilander  <wilander@apple.com>
208
209         Resource Load Statistics: Make it possible exclude localhost from classification
210         https://bugs.webkit.org/show_bug.cgi?id=195474
211         <rdar://problem/47520577>
212
213         Reviewed by Brent Fulgham.
214
215         This patch allows for localhost to be excluded from classification and
216         treatment as a prevalent resource.
217
218         The WebKit Tools change adds a new function called
219         testRunner.setStatisticsIsRunningTest() which can be used to control this
220         behavior.
221
222         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
223         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
224         (WTR::TestRunner::setStatisticsIsRunningTest):
225         * WebKitTestRunner/InjectedBundle/TestRunner.h:
226         * WebKitTestRunner/TestController.cpp:
227         (WTR::TestController::setStatisticsIsRunningTest):
228         * WebKitTestRunner/TestController.h:
229         * WebKitTestRunner/TestInvocation.cpp:
230         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
231
232 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
233
234         [ews-build] Disable waterfall and console view for ews-build.webkit.org
235         https://bugs.webkit.org/show_bug.cgi?id=195560
236
237         Reviewed by Lucas Forschler.
238
239         * BuildSlaveSupport/ews-build/master.cfg:
240
241 2019-03-11  Alex Christensen  <achristensen@webkit.org>
242
243         Unreviewed, rolling out r242698.
244
245         API test crashes on bots.
246
247         Reverted changeset:
248
249         "Add a WKContentRuleList variant that uses copied memory
250         instead of mmap'd shared memory for class A containerized
251         apps"
252         https://bugs.webkit.org/show_bug.cgi?id=195511
253         https://trac.webkit.org/changeset/242698
254
255 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
256
257         [WPE] Enable web process sandbox
258         https://bugs.webkit.org/show_bug.cgi?id=195169
259
260         Reviewed by Daniel Bates.
261
262         * wpe/install-dependencies:
263         * wpe/jhbuild.modules:
264
265 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
266
267         [ews-app] Use port 17000 for worker communication
268         https://bugs.webkit.org/show_bug.cgi?id=195558
269
270         Reviewed by Lucas Forschler.
271
272         * BuildSlaveSupport/ews-build/master.cfg:
273
274 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-build] unit-tests fail when passwords.json is missing
277         https://bugs.webkit.org/show_bug.cgi?id=195557
278
279         Reviewed by Lucas Forschler.
280
281         * BuildSlaveSupport/ews-build/loadConfig.py:
282         (loadBuilderConfig):
283         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
284         (ConfigDotJSONTest.test_configuration):
285         * BuildSlaveSupport/ews-build/master.cfg:
286
287 2019-03-11  Truitt Savell  <tsavell@apple.com>
288
289         Unreviewed, rolling out r242702.
290
291         Broke High Sierra builders.
292
293         Reverted changeset:
294
295         "Add utility function to allow easy reverse range-based
296         iteration of a container"
297         https://bugs.webkit.org/show_bug.cgi?id=195542
298         https://trac.webkit.org/changeset/242702
299
300 2019-03-11  Sam Weinig  <sam@webkit.org>
301
302         Add utility function to allow easy reverse range-based iteration of a container
303         https://bugs.webkit.org/show_bug.cgi?id=195542
304
305         Reviewed by Antti Koivisto.
306
307         * TestWebKitAPI/CMakeLists.txt:
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
310         (TestWebKitAPI::TEST):
311         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
312
313 2019-03-10  Alex Christensen  <achristensen@webkit.org>
314
315         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
316         https://bugs.webkit.org/show_bug.cgi?id=195511
317         <rdar://problem/44873269>
318
319         Reviewed by Darin Adler.
320
321         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
322         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
323         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
324         (TEST_F):
325
326 2019-03-10  Tim Horton  <timothy_horton@apple.com>
327
328         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
329         https://bugs.webkit.org/show_bug.cgi?id=195499
330
331         Reviewed by Darin Adler.
332
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
335         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
336         (-[WKWebView synchronouslyFocusTextInputContext:]):
337         (applyStyle):
338         (applyIframe):
339         (TEST):
340         Add some tests for this SPI.
341
342 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
343
344         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
345         https://bugs.webkit.org/show_bug.cgi?id=181151
346
347         Reviewed by Don Olmstead.
348
349         * TestWebKitAPI/CMakeLists.txt:
350         * TestWebKitAPI/PlatformWin.cmake:
351         Enable TestWTF RunLoop tests in all platforms.
352
353         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
354         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
355         (TestWebKitAPI::DerivedOneShotTimer::fired):
356         (TestWebKitAPI::TEST):
357         Only a few platforms support nested RunLoop.
358
359         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
360         (TestWebKitAPI::DerivedRepeatingTimer::fired):
361
362 2019-03-10  David Quesada  <david_quesada@apple.com>
363
364         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
365         https://bugs.webkit.org/show_bug.cgi?id=152480
366
367         Reviewed by Chris Dumez.
368
369         Add a unit test based on Daniel Bates's test case that starts a download, ensures
370         there are no additional references to the process pool besides the one held by
371         the download, waits for the download to finish (in the sense that the
372         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
373         measure, also check that the process pool has been deallocated at the end of the
374         test. The test wouldn't be meaningful if the process pool were still alive.
375
376         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
377         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
378         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
379             The download will be canceled because the delegate does not implement the
380             method to decide the download's destination, so this is where we know the
381             DownloadProxyMap is done with the DownloadProxy.
382         (TEST):
383
384 2019-03-08  Chris Dumez  <cdumez@apple.com>
385
386         Add support for Device Orientation / Motion permission API
387         https://bugs.webkit.org/show_bug.cgi?id=195329
388         <rdar://problem/47645367>
389
390         Reviewed by Geoffrey Garen.
391
392         Add test infrastructure to help test the Device Orientation / Motion permission API.
393
394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
396         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
398         * WebKitTestRunner/TestController.cpp:
399         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
400         (WTR::TestController::createWebViewWithOptions):
401         (WTR::TestController::resetStateToConsistentValues):
402         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
403         * WebKitTestRunner/TestController.h:
404         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
405         * WebKitTestRunner/TestInvocation.cpp:
406         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
407
408 2019-03-08  Saam barati  <sbarati@apple.com>
409
410         Add a compare-results script to compare benchmark results
411         https://bugs.webkit.org/show_bug.cgi?id=195486
412         <rdar://problem/48723397>
413
414         Reviewed by Geoffrey Garen.
415
416         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
417         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
418         to extend it to learn about our other benchmarks.
419
420         * Scripts/compare-results: Added.
421         (readJSONFile):
422         (detectJetStream2):
423         (JetStream2Results):
424         (detectSpeedometer2):
425         (Speedometer2Results):
426         (detectPLT5):
427         (PLT5Results):
428         (detectBenchmark):
429         (biggerIsBetter):
430         (ttest):
431         (getOptions):
432         (main):
433
434 2019-03-08  Stephanie Lewis  <slewis@apple.com>
435
436         Ensure old tab state is cleared between iterations of run-benchmark
437         https://bugs.webkit.org/show_bug.cgi?id=195393
438         <rdar://problem/46885583>
439
440         Reviewed by Dewei Zhu.
441
442         a) ensure the default to restore state is not set
443         b) terminate Safari correctly
444         c) Set the system default to ignore Persistent State in Safari
445
446         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
447         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
448         (OSXBrowserDriver.prepare_env): 
449         (OSXBrowserDriver.restore_env):
450         (OSXBrowserDriver.close_browsers):
451         (OSXBrowserDriver._terminate_processes):
452         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
453         (OSXChromeDriver):
454         (OSXChromeCanaryDriver):
455         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
456         (OSXFirefoxDriver):
457         (OSXFirefoxNightlyDriver):
458         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
459         (OSXSafariDriver):
460         (OSXSafariDriver.prepare_env):
461
462 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
463
464         [GTK] Several InputMethodFilter tests are failing
465         https://bugs.webkit.org/show_bug.cgi?id=195408
466
467         Reviewed by Carlos Garcia Campos.
468
469         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
470         Regressed in r241751.
471         Hexadecimal values of keycodes are expressed now in upper letters.
472         Composited characters should be cast to UTF8 strings.
473
474         (TestWebKitAPI::TEST):
475
476 2019-03-07  Tomas Popela  <tpopela@redhat.com>
477
478         [GTK] Make Tools/gtkdoc python3 compatible
479         https://bugs.webkit.org/show_bug.cgi?id=195359
480
481         Reviewed by Carlos Garcia Campos.
482
483         * gtkdoc/generate-gtkdoc:
484         ConfigParser was reworked in Python 3.2 so we have adapt the code to
485         work with Python 2 and 3.
486         (get_gtkdoc_module_paths):
487         The iteritems() was removed in Python 3, so let's use items() that's
488         available in Python 2 and 3.
489         (get_generator_for_config):
490         * gtkdoc/gtkdoc.py:
491         (GTKDoc._run_command):
492         The sys.stdout.write() is expecting str in Python 3 and not bytes
493         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
494         for passing the bytes there.
495
496 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
497
498         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
499         https://bugs.webkit.org/show_bug.cgi?id=195346
500         <rdar://problem/48667048>
501
502         Unreviewed build fix for clang-cl.
503
504         * DumpRenderTree/win/DumpRenderTree.cpp:
505         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
506
507 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
508
509         requestAnimationFrame should execute before the next frame
510         https://bugs.webkit.org/show_bug.cgi?id=177484
511
512         Reviewed by Simon Fraser.
513
514         Add trace points for the page RenderingUpdate.
515
516         * Tracing/SystemTracePoints.plist:
517
518 2019-03-07  Zalan Bujtas  <zalan@apple.com>
519
520         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
521         https://bugs.webkit.org/show_bug.cgi?id=195353
522         <rdar://problem/48626394>
523
524         Reviewed by Simon Fraser.
525
526         * WebKitTestRunner/ios/TestControllerIOS.mm:
527         (WTR::TestController::platformResetPreferencesToConsistentValues):
528
529 2019-03-07  John Wilander  <wilander@apple.com>
530
531         Resource Load Statistics: Make it possible to purge only script-accessible cookies
532         https://bugs.webkit.org/show_bug.cgi?id=195383
533         <rdar://problem/48570136>
534
535         Reviewed by Brent Fulgham.
536
537         This patch adds test infrastructure to purge only script-accessible cookies,
538         including a new testRunner function called statisticsDeleteCookiesForHost().git a
539
540         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
541         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
542         (WTR::TestRunner::statisticsDeleteCookiesForHost):
543         * WebKitTestRunner/InjectedBundle/TestRunner.h:
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::statisticsDeleteCookiesForHost):
546         * WebKitTestRunner/TestController.h:
547         * WebKitTestRunner/TestInvocation.cpp:
548         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
549
550 2019-03-07  Commit Queue  <commit-queue@webkit.org>
551
552         Unreviewed, rolling out r242354.
553         https://bugs.webkit.org/show_bug.cgi?id=195402
554
555         breaks layout tests in all configurations (Requested by
556         zdobersek on #webkit).
557
558         Reverted changeset:
559
560         "[WPE] Enable web process sandbox"
561         https://bugs.webkit.org/show_bug.cgi?id=195169
562         https://trac.webkit.org/changeset/242354
563
564 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
565
566         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
567         https://bugs.webkit.org/show_bug.cgi?id=195346
568
569         Reviewed by Fujii Hironori.
570
571         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
572         (TestWebKitAPI::TEST):
573         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
574
575         * DumpRenderTree/win/DumpRenderTree.cpp:
576         (findFontFallback):
577         (addFontFallbackIfPresent):
578         (removeFontFallbackIfPresent):
579         (main):
580         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
581         (TestWebKitAPI::Util::moduleDirectory):
582         (TestWebKitAPI::Util::createInjectedBundlePath):
583         Use wchar helpers as needed.
584
585 2019-03-06  Rob Buis  <rbuis@igalia.com>
586
587         Consider supporting the `referrerpolicy` attribute.
588         https://bugs.webkit.org/show_bug.cgi?id=179053
589
590         Reviewed by Darin Adler.
591
592         Add a runtime flag for referrerpolicy attribute.
593
594         * DumpRenderTree/mac/DumpRenderTree.mm:
595         (enableExperimentalFeatures):
596
597 2019-03-05  Daniel Bates  <dabates@apple.com>
598
599         Update expected API test result following r242379
600         (https://bugs.webkit.org/show_bug.cgi?id=195125)
601
602         Update expected x-coordinate of selection rect now that the left padding of
603         a textarea is sized in ems (so dependent on the font size) just like the left
604         padding of a text field.
605
606         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
607         (TestWebKitAPI::TEST):
608
609 2019-03-05  David Quesada  <david_quesada@apple.com>
610
611         [WK2] It should be possible to follow links with 'download' attributes
612         https://bugs.webkit.org/show_bug.cgi?id=195145
613         rdar://problem/48462642
614
615         Reviewed by Alex Christensen.
616
617         Add a unit test to verify that activating links with 'download' attributes now
618         navigates to the linked resource, rather than starts downloading it. Add another
619         to verify that it is still possible to explicitly download the link via the
620         'Download' navigation action policy.
621
622         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
623         (-[DownloadAttributeTestDelegate init]):
624         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
625         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
626         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
627         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
628         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
629         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
630         (TEST):
631         * WebKitTestRunner/TestController.cpp:
632         (WTR::TestController::decidePolicyForNavigationAction):
633         * WebKitTestRunner/TestController.h:
634
635 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
636
637         [Curl] Implement Cookie Accept Policy.
638         https://bugs.webkit.org/show_bug.cgi?id=191645
639
640         Reviewed by Fujii Hironori.
641
642         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
643         (TestWebKitAPI::Curl::TEST_F):
644
645 2019-03-05  Youenn Fablet  <youenn@apple.com>
646
647         Rename requestCacheStorageSpace to requestStorageSpace
648         https://bugs.webkit.org/show_bug.cgi?id=195282
649
650         Reviewed by Chris Dumez.
651
652         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
653         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
654         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
655
656 2019-03-05  Brady Eidson  <beidson@apple.com>
657
658         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
659         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
660
661         Reviewed by Tim Horton.
662
663         Loading a file: URL into a WKWebView and then loading another file: url from a completely
664         different directory into that same WKWebView should work.
665
666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
668
669 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
670
671         Add WeakHashSet
672         https://bugs.webkit.org/show_bug.cgi?id=195152
673
674         Reviewed by Antti Koivisto.
675
676         Added tests for WeakHashSet.
677
678         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
679         (TestWebKitAPI::Base::Base): Moved.
680         (TestWebKitAPI::Derived::foo): Moved.
681         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
682         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
683         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
684         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
685
686 2019-03-04  Chris Dumez  <cdumez@apple.com>
687
688         Do not share WebProcesses between private and regular sessions
689         https://bugs.webkit.org/show_bug.cgi?id=195189
690         <rdar://problem/48421064>
691
692         Reviewed by Alex Christensen.
693
694         Add API test coverage.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
697         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
698
699 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
700
701         [WPE] Enable web process sandbox
702         https://bugs.webkit.org/show_bug.cgi?id=195169
703
704         Reviewed by Daniel Bates.
705
706         * wpe/install-dependencies:
707         * wpe/jhbuild.modules:
708
709 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
710
711         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
712         https://bugs.webkit.org/show_bug.cgi?id=195206
713
714         Reviewed by Žan Doberšek.
715
716         Add a new test case.
717
718         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
719         (testJSCClass):
720
721 2019-03-04  Charlie Turner  <cturner@igalia.com>
722
723         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
724         https://bugs.webkit.org/show_bug.cgi?id=194898
725
726         Reviewed by Žan Doberšek.
727
728         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
729         a GCC extension that permits arithmetic on void* pointer. Inline
730         the macro until this issue is fixed upstream.
731
732 2019-03-03  Tim Horton  <timothy_horton@apple.com>
733
734         Rid the world of WK_API_ENABLED
735         https://bugs.webkit.org/show_bug.cgi?id=195263
736
737         Reviewed by Dan Bernstein.
738
739         List of changed files elided because it's useless.
740
741 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
742
743         Unreviewed follow-up to r242292.
744
745         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
746
747         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
748         (TestWebKitAPI::testStrip): Renamed from strip.
749         (TestWebKitAPI::TEST):
750
751 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
752
753         Unreviewed, remove accidentally-committed URLHelpers.cpp test
754
755         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
756         and bug #194272 for details.
757
758         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
759
760 2019-03-03  Tim Horton  <timothy_horton@apple.com>
761
762         Remove some more unused 32-bit code
763         https://bugs.webkit.org/show_bug.cgi?id=195255
764
765         Reviewed by Darin Adler.
766
767         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
768         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
769         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
770         (NPP_New):
771         (NPP_HandleEvent):
772         (handleEventCarbon): Deleted.
773
774 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
775
776         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
777
778         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
779         (TestWebKitAPI::TEST):
780
781 2019-03-01  Darin Adler  <darin@apple.com>
782
783         Finish removing String::format
784         https://bugs.webkit.org/show_bug.cgi?id=194893
785
786         Reviewed by Daniel Bates.
787 '
788         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
789
790 2019-03-01  Alex Christensen  <achristensen@webkit.org>
791
792         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
793         https://bugs.webkit.org/show_bug.cgi?id=195229
794         <rdar://problem/48520362>
795
796         Reviewed by Chris Dumez.
797
798         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
799         (TEST):
800
801 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
802
803         Add a system trace scope for event region building
804         https://bugs.webkit.org/show_bug.cgi?id=195226
805
806         Reviewed by Jon Lee.
807
808         This trace scope measures the time spend converting element rects into Region objects,
809         which can be large on some pages.
810
811         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
812
813         * Tracing/SystemTracePoints.plist:
814
815 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
816
817         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
818         https://bugs.webkit.org/show_bug.cgi?id=194612
819
820         Reviewed by Alex Christensen.
821
822         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
823         Just test the new string-processing function and don't touch the actual environment.
824         (Test cases are all as before, but based on operator== instead of strcmp.)
825
826 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
827
828         [ews-app] Update primary keys for handling multiple Buildbot instances
829         https://bugs.webkit.org/show_bug.cgi?id=195120
830
831         Reviewed by Stephanie Lewis.
832
833         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
834         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
835         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
836
837         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
838         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
839         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
840         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
841         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
842         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
843
844 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
845
846         [WinCairo] Enable service worker
847         https://bugs.webkit.org/show_bug.cgi?id=188318
848
849         Reviewed by Youenn Fablet.
850
851         * DumpRenderTree/DumpRenderTreePrefix.h:
852         * TestWebKitAPI/PlatformWin.cmake:
853         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
854         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
855         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
856
857 2019-03-01  Justin Fan  <justin_fan@apple.com>
858
859         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
860         https://bugs.webkit.org/show_bug.cgi?id=195191
861
862         Rubber-stamped by Dean Jackson.
863
864         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
865
866         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
867
868 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
869
870         Unreviewed, fix lldb webkitpy tests
871         https://bugs.webkit.org/show_bug.cgi?id=194375
872
873         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
874
875         * lldb/lldb_webkit.py:
876         (WTFStringImplProvider.is_8bit):
877
878 2019-02-28  David Quesada  <david_quesada@apple.com>
879
880         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
881         https://bugs.webkit.org/show_bug.cgi?id=195121
882         rdar://problem/48450302
883
884         Reviewed by Alex Christensen.
885
886         Add API tests for -WKNavigationAction._shouldPerformDownload in various
887         configurations where the 'download' attribute is absent, blank, or populated
888         with a filename, and where the anchor element is same-origin or cross-origin
889         (meaning the 'download' attribute shouldn't be honored).
890
891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
892         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
893         (-[NavigationActionTestDelegate init]):
894         (-[NavigationActionTestDelegate navigationAction]):
895         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
896         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
897         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
898         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
899         (TEST):
900
901 2019-02-28  Antoine Quint  <graouts@apple.com>
902
903         Enable the Pointer Events runtime flag by default
904         https://bugs.webkit.org/show_bug.cgi?id=195156
905
906         Reviewed by Dean Jackson.
907
908         * DumpRenderTree/mac/DumpRenderTree.mm:
909         (enableExperimentalFeatures):
910
911 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
912
913         Several PasteImage API tests are flaky
914         https://bugs.webkit.org/show_bug.cgi?id=195160
915
916         Reviewed by Tim Horton.
917
918         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
919         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
920         listening for a "load" event after image load is already complete.
921
922         To address this, make these tests first register a "load" event handler, then run script to insert an image
923         element into the document, and finally wait until the load event is observed before checking image size.
924
925         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
926
927 2019-02-28  Chris Dumez  <cdumez@apple.com>
928
929         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
930         https://bugs.webkit.org/show_bug.cgi?id=195107
931
932         Reviewed by Alex Christensen.
933
934         Give some time for the zoom level to get restored.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
937
938 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
939
940         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
941         https://bugs.webkit.org/show_bug.cgi?id=194958
942
943         Reviewed by Geoffrey Garen.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
946         (TEST):
947
948 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
949
950         [ews-app] Update method to save build to handle builder_display_name
951         https://bugs.webkit.org/show_bug.cgi?id=195047
952
953         Reviewed by Dewei Zhu.
954
955         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
956         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
957
958 2019-02-28  Justin Fan  <justin_fan@apple.com>
959
960         [Web GPU] Enable Web GPU only on 64-bit
961         https://bugs.webkit.org/show_bug.cgi?id=195139
962
963         Because Metal is only supported on 64 bit apps.
964
965         Unreviewed build fix.
966
967         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
968
969 2019-02-27  Youenn Fablet  <youenn@apple.com>
970
971         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
972         https://bugs.webkit.org/show_bug.cgi?id=194959
973
974         Reviewed by Chris Dumez.
975
976         Spin loop until getting the condition to remove flakiness.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
979
980 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
981
982         [ews-build] Buildbot should include builder_display_name in the build events
983         https://bugs.webkit.org/show_bug.cgi?id=195045
984
985         Reviewed by Dewei Zhu.
986
987         * BuildSlaveSupport/ews-build/events.py:
988         (Events.buildStarted): Included builder_display_name in event data. Also renamed
989         buildername to builder_name to be consistent in naming style.
990         (Events.buildFinished): Ditto.
991
992 2019-02-27  Chris Dumez  <cdumez@apple.com>
993
994         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
995         https://bugs.webkit.org/show_bug.cgi?id=194480
996
997         Reviewed by Brady Eidson.
998
999         Update existing API test to make it more likely to reproduce the issue.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1002
1003 2019-02-27  Brady Eidson  <beidson@apple.com>
1004
1005         Universal links from Google search results pages don't open the app.
1006         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1007
1008         Reviewed by Geoffrey Garen.
1009
1010         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1011         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1012         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1013         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1014
1015 2019-02-27  Chris Dumez  <cdumez@apple.com>
1016
1017         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1018         https://bugs.webkit.org/show_bug.cgi?id=195102
1019
1020         Reviewed by Geoffrey Garen.
1021
1022         If the number of processes is not yet what we expect, wait a bit and check again to give
1023         processes some time to exit.
1024
1025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1026
1027 2019-02-27  Chris Dumez  <cdumez@apple.com>
1028
1029         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1030         https://bugs.webkit.org/show_bug.cgi?id=194545
1031
1032         Reviewed by Brady Eidson.
1033
1034         Make sure the test navigates forward and then back only once. Previously, navigating
1035         back would trigger a navigation again in a timer.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1038
1039 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1040
1041         High Sierra Debug JSC test queue should use faster hardware
1042         https://bugs.webkit.org/show_bug.cgi?id=194603
1043
1044         Rubber-stamped by Alexey Proskuryakov.
1045
1046         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1047
1048         * BuildSlaveSupport/build.webkit.org-config/config.json:
1049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1050         (BubbleQueueServer):
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1052         (WebKitBuildbot):
1053         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1054         * QueueStatusServer/config/queues.py:
1055         * Scripts/webkitpy/common/config/ews.json:
1056         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1057         (test_ews_name):
1058
1059 2019-02-27  John Wilander  <wilander@apple.com>
1060
1061         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1062         https://bugs.webkit.org/show_bug.cgi?id=195071
1063         <rdar://problem/48417690>
1064
1065         Reviewed by Alex Christensen and Brent Fulgham.
1066
1067         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1068         (TestWebKitAPI::createURL):
1069             Convenience function.
1070         (TestWebKitAPI::TEST):
1071             WebCore::AdClickAttribution now takes a URL when creating Source and
1072             Destination.
1073         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1074         (TestWebKitAPI::TEST):
1075             WebCore::AdClickAttribution now takes a URL when creating Source and
1076             Destination.
1077
1078 2019-02-27  Antoine Quint  <graouts@apple.com>
1079
1080         Support Pointer Events on macOS
1081         https://bugs.webkit.org/show_bug.cgi?id=195008
1082         <rdar://problem/47454419>
1083
1084         Reviewed by Dean Jackson.
1085
1086         * DumpRenderTree/mac/DumpRenderTree.mm:
1087         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1088         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1089
1090 2019-02-26  Mark Lam  <mark.lam@apple.com>
1091
1092         Remove remaining poisoning code.
1093         https://bugs.webkit.org/show_bug.cgi?id=194138
1094
1095         Reviewed by Saam Barati.
1096
1097         * TestWebKitAPI/CMakeLists.txt:
1098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1099         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1100         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1101         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1102         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1103         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1104         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1105
1106 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1107
1108         Move ephemeral local storage from WebProcess to UIProcess
1109         https://bugs.webkit.org/show_bug.cgi?id=195074
1110         <rdar://problem/47937975>
1111
1112         Reviewed by Geoff Garen.
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1115
1116 2019-02-20  Jer Noble  <jer.noble@apple.com>
1117
1118         [Cocoa] Media elements will restart network buffering just before suspending
1119         https://bugs.webkit.org/show_bug.cgi?id=193691
1120
1121         Reviewed by Eric Carlson.
1122
1123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1125         (TEST):
1126
1127 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1128
1129         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1130         https://bugs.webkit.org/show_bug.cgi?id=191652
1131
1132         Reviewed by Alex Christensen.
1133
1134         Fix WinCairo MiniBrowser behavior of authentication dialog.
1135
1136         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1137         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1138
1139 2019-02-26  Youenn Fablet  <youenn@apple.com>
1140
1141         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1142         https://bugs.webkit.org/show_bug.cgi?id=195028
1143         <rdar://problem/48243733>
1144
1145         Reviewed by Eric Carlson.
1146
1147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1148
1149 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1150
1151         [WPE] Add API for webview background color configuration
1152         https://bugs.webkit.org/show_bug.cgi?id=192305
1153
1154         Reviewed by Michael Catanzaro.
1155
1156         * MiniBrowser/wpe/main.cpp:
1157         (main): Add a new option to configure the webview background
1158         color. Example: --bg-color=transparent.
1159         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1160         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1161         (beforeAll): Ditto.
1162
1163 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1164
1165         scalableNativeWebpageParameters() is not preserved on new page navigation.
1166         https://bugs.webkit.org/show_bug.cgi?id=194892
1167         <rdar://problem/47538280>
1168
1169         Reviewed by Wenson Hsieh.
1170         
1171         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1172
1173         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1174         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1175         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1176         (WTR::UIScriptController::allowsViewportShrinkToFit):
1177         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1178         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1179         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1180         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1181         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1182         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1183
1184 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-app] Add model for handling multiple Buildbot instances
1187         https://bugs.webkit.org/show_bug.cgi?id=194863
1188
1189         Reviewed by Stephanie Lewis.
1190
1191         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1192
1193 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1194
1195         [ews-app] Remove BuilderMapping table
1196         https://bugs.webkit.org/show_bug.cgi?id=194961
1197
1198         Reviewed by Stephanie Lewis.
1199
1200         Store builder name directly in build table, instead of having a separate
1201         table for it.
1202
1203         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1204         * BuildSlaveSupport/ews-app/ews/models/build.py:
1205         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1206         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1207
1208 2019-02-25  John Wilander  <wilander@apple.com>
1209
1210         Introduce and adopt new class RegistrableDomain for eTLD+1
1211         https://bugs.webkit.org/show_bug.cgi?id=194791
1212         <rdar://problem/48179240>
1213
1214         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1215
1216         This patch adds an API test and replaces two instances of
1217         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1218
1219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1220         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1221         (TestWebKitAPI::TEST):
1222             Changed two strings to make sure the registrable domains are still considered
1223             invalid and pass the test.
1224         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1225         (TestWebKitAPI::TEST):
1226         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1227         (WTR::InjectedBundle::didReceiveMessageToPage):
1228
1229 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1230
1231         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1232         https://bugs.webkit.org/show_bug.cgi?id=195001
1233
1234         Reviewed by Carlos Garcia Campos.
1235
1236         API version 1.0 always includes the functionality previously guarded with
1237         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1238         unconditionally.
1239
1240         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1241         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1242         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1243         (WebViewTest::showInWindow): Ditto.
1244         (WebViewTest::hideView): Ditto.
1245         * wpe/backends/HeadlessViewBackend.cpp:
1246         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1247         * wpe/backends/ViewBackend.cpp:
1248         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1249         * wpe/backends/WindowViewBackend.cpp:
1250         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1251         WPE_BACKEND_CHECK_VERSION().
1252         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1253
1254 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1255
1256         [Flatpak] Add support for flatpak > 1.1.2
1257         https://bugs.webkit.org/show_bug.cgi?id=194088
1258
1259         Flatpak 1.2 is now out so we need to support that
1260         version now.
1261
1262         Reviewed by Michael Catanzaro.
1263
1264         * flatpak/flatpakutils.py:
1265         (check_flatpak):
1266         (FlatpakPackages.__init__):
1267         (FlatpakPackages.__detect_packages):
1268         (FlatpakPackages.__detect_packages.in):
1269         (FlatpakRepos.update):
1270
1271 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1272
1273         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1274         https://bugs.webkit.org/show_bug.cgi?id=194998
1275
1276         Reviewed by Carlos Garcia Campos.
1277
1278         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1279         to a Git checkout and using the latest commit containing various fixes
1280         and improvements.
1281
1282 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1283
1284         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1285         https://bugs.webkit.org/show_bug.cgi?id=194981
1286
1287         Reviewed by Žan Doberšek.
1288
1289         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1290         (TestWebKitAPI::TEST):
1291
1292 2019-02-23  Keith Miller  <keith_miller@apple.com>
1293
1294         Add new mac target numbers
1295         https://bugs.webkit.org/show_bug.cgi?id=194955
1296
1297         Reviewed by Tim Horton.
1298
1299         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1300         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1301         * MiniBrowser/Configurations/Base.xcconfig:
1302         * TestWebKitAPI/Configurations/Base.xcconfig:
1303         * WebKitTestRunner/Configurations/Base.xcconfig:
1304
1305 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1306
1307         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1308         https://bugs.webkit.org/show_bug.cgi?id=194846
1309
1310         Reviewed by Don Olmstead.
1311
1312         Added _search_paths() and _port_specific_expectations_files() for
1313         WinCairoPort.
1314
1315         * Scripts/webkitpy/port/win.py:
1316         (WinCairoPort.default_baseline_search_path):
1317         (WinCairoPort):
1318         (WinCairoPort._port_specific_expectations_files):
1319         (WinCairoPort._search_paths):
1320
1321 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1322
1323         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1324         https://bugs.webkit.org/show_bug.cgi?id=194963
1325
1326         Reviewed by Dean Jackson.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1329         Do a `contains` check instead of `equals`, because in debug builds we
1330         put the GraphicsLayer pointer in a prefix.
1331
1332 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1333
1334         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1335         https://bugs.webkit.org/show_bug.cgi?id=194873
1336         <rdar://problem/46701974>
1337
1338         Reviewed by Tim Horton.
1339
1340         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1341
1342         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1343         (WTR::UIScriptController::menuRect const):
1344         (WTR::UIScriptController::isShowingMenu const):
1345         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1346         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1347         (WTR::UIScriptController::menuRect const):
1348
1349         Add a function to query the bounds of the callout menu in content coordinates.
1350
1351         (WTR::UIScriptController::isShowingMenu const):
1352
1353         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1354
1355         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1356         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1357         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1358         (WTR::UIScriptController::rectForMenuAction const):
1359         (WTR::UIScriptController::menuRect const):
1360         (WTR::UIScriptController::isShowingMenu const):
1361         (WTR::findViewInHierarchyOfType): Deleted.
1362
1363 2019-02-22  Chris Dumez  <cdumez@apple.com>
1364
1365         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1366         https://bugs.webkit.org/show_bug.cgi?id=194954
1367         <rdar://problem/48127957>
1368
1369         Reviewed by Alex Christensen.
1370
1371         Add API test coverage.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1374         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1375         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1376         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1377
1378 2019-02-22  Chris Dumez  <cdumez@apple.com>
1379
1380         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1381         https://bugs.webkit.org/show_bug.cgi?id=194924
1382         <rdar://problem/48216125>
1383
1384         Reviewed by Geoffrey Garen.
1385
1386         Add API test coverage.
1387
1388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1389
1390 2019-02-22  Chris Dumez  <cdumez@apple.com>
1391
1392         Unreviewed, disable API test added in r241928 on iOS.
1393
1394         The cache is not enabled on devices with less than 3GB of RAM.
1395
1396         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1397
1398 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1399
1400         Hardcode Visual Viewports on everywhere except iOS WK1
1401         https://bugs.webkit.org/show_bug.cgi?id=194928
1402
1403         Reviewed by Zalan Bujtas.
1404
1405         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1406         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1407         set it to false. The setting has shipped for several years and there's no need to turn
1408         it off now.
1409
1410         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1411         Visual Viewports are not enabled.
1412         
1413         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1414         that only runs in WK2
1415
1416         * MiniBrowser/mac/SettingsController.h:
1417         * MiniBrowser/mac/SettingsController.m:
1418         (-[SettingsController init]):
1419         (-[SettingsController _populateMenu]):
1420         (-[SettingsController validateMenuItem:]):
1421         (-[SettingsController visualViewportEnabled]): Deleted.
1422         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1423         * MiniBrowser/mac/WK1BrowserWindowController.m:
1424         (-[WK1BrowserWindowController didChangeSettings]):
1425         * MiniBrowser/mac/WK2BrowserWindowController.m:
1426         (-[WK2BrowserWindowController didChangeSettings]):
1427
1428 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1429
1430         Discard cached processes when clearing website data store
1431         https://bugs.webkit.org/show_bug.cgi?id=194894
1432
1433         Reviewed by Chris Dumez.
1434
1435         Added a test case.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1438         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1439
1440 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1441
1442         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1443         https://bugs.webkit.org/show_bug.cgi?id=194914
1444         <rdar://problem/47586889>
1445
1446         Reviewed by Geoffrey Garen.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1449         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1450         (TEST):
1451         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1452
1453 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1454
1455         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1456         <https://webkit.org/b/194761>
1457
1458         Reviewed by Myles Maxfield.
1459
1460         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1461         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1462         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1463         to use ARC-compliant cast.
1464         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1465         ARC-compliant cast.
1466         (WTR::installFakeHelvetica): Log `error` to console if
1467         CTFontManagerRegisterFontsForURL() fails, but only on supported
1468         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1469         Call CFRelease() on `error` to fix the leak.  Update to use
1470         ARC-compliant cast.
1471         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1472         cast.
1473
1474 2019-02-21  Chris Dumez  <cdumez@apple.com>
1475
1476         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1477         https://bugs.webkit.org/show_bug.cgi?id=194481
1478
1479         Reviewed by Alex Christensen.
1480
1481         Give the processes a chance to shutdown and wait until we reached the expected number
1482         of processes.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1485
1486 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1487
1488         Fix the macOS build
1489
1490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1491
1492 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1493
1494         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1495
1496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1497         I am a backwards.
1498
1499 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1500
1501         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1502
1503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1504         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1505         We could force on UI-side compositing, but I feel like the test might be more
1506         valuable exercising the normal path on each platform (though the original
1507         bug was also UI-side specific). Though we can't validate that the overlay
1508         layer was installed successfully, there are layout tests that do that.
1509
1510 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1511
1512         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1513         https://bugs.webkit.org/show_bug.cgi?id=194845
1514         <rdar://problem/47944579>
1515
1516         Reviewed by Antti Koivisto.
1517
1518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1520
1521 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1522
1523         [LFC][Floats] Add support for placing formatting roots in-between floats.
1524         https://bugs.webkit.org/show_bug.cgi?id=194902
1525
1526         Reviewed by Antti Koivisto.
1527
1528         * LayoutReloaded/misc/LFC-passing-tests.txt:
1529
1530 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1531
1532         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1533         https://bugs.webkit.org/show_bug.cgi?id=194901
1534
1535         Unreviewed build fix.
1536
1537         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1538         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1539         WPEBackend-fdo-0.1 as library name.
1540
1541 2019-02-21  Rob Buis  <rbuis@igalia.com>
1542
1543         Update MIME type parser
1544         https://bugs.webkit.org/show_bug.cgi?id=180526
1545
1546         Reviewed by Darin Adler.
1547
1548         Add tests involving leading and trailing whitespace, non-token
1549         characters and quoted strings.
1550
1551         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1552         (TestWebKitAPI::TEST):
1553
1554 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1555
1556         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1557         https://bugs.webkit.org/show_bug.cgi?id=194884
1558
1559         Reviewed by Michael Catanzaro.
1560
1561         * PlatformWin.cmake:
1562
1563 2019-02-20  Chris Dumez  <cdumez@apple.com>
1564
1565         Add API test for <rdar://problem/47471222>
1566         https://bugs.webkit.org/show_bug.cgi?id=194847
1567
1568         Reviewed by Alex Christensen.
1569
1570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1571
1572 2019-02-20  Chris Dumez  <cdumez@apple.com>
1573
1574         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1575         https://bugs.webkit.org/show_bug.cgi?id=194872
1576         <rdar://problem/47924500>
1577
1578         Reviewed by Alex Christensen.
1579
1580         Add API test coverage.
1581
1582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1583
1584 2019-02-20  Jer Noble  <jer.noble@apple.com>
1585
1586         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1587         https://bugs.webkit.org/show_bug.cgi?id=191332
1588
1589         Reviewed by Dean Jackson.
1590
1591         * Scripts/git-is-in-range: Added.
1592
1593 2019-02-20  Andy Estes  <aestes@apple.com>
1594
1595         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1596         https://bugs.webkit.org/show_bug.cgi?id=194869
1597
1598         Rubber-stamped by Jer Noble.
1599
1600         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1601         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1602         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1603         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1606
1607 2019-02-20  Chris Dumez  <cdumez@apple.com>
1608
1609         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1610         https://bugs.webkit.org/show_bug.cgi?id=194857
1611         <rdar://problem/47759323>
1612
1613         Reviewed by Alex Christensen.
1614
1615         Add API test coverage.
1616
1617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1618
1619 2019-02-20  Chris Dumez  <cdumez@apple.com>
1620
1621         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1622         https://bugs.webkit.org/show_bug.cgi?id=194829
1623         <rdar://problem/47889906>
1624
1625         Reviewed by Alexey Proskuryakov.
1626
1627         Every time the TestOptions were changing we were creating both a new Web view and
1628         a new WKContext, which would start a new Network process. In most cases, we only
1629         need to contruct a new Web view and we do can keep reusing the same WKContext.
1630         This patch implements this optimization and thus avoids spinning a lot of new
1631         Network processes while running the layout tests.
1632
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::TestController::generateContextConfiguration const):
1635         (WTR::TestController::generatePageConfiguration):
1636         (WTR::TestController::createWebViewWithOptions):
1637         (WTR::TestController::resetPreferencesToConsistentValues):
1638         (WTR::updateTestOptionsFromTestHeader):
1639         * WebKitTestRunner/TestController.h:
1640         * WebKitTestRunner/TestOptions.h:
1641         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1642         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1643         (WTR::TestOptions::hasSameInitializationOptions const):
1644         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1645         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1646         (WTR::TestController::platformAddTestOptions const):
1647
1648 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1649
1650         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1651         https://bugs.webkit.org/show_bug.cgi?id=167941
1652
1653         Reviewed by Carlos Garcia Campos.
1654
1655         * MiniBrowser/gtk/main.c:
1656         (filterSavedCallback): Added.
1657         (main): Support loading a JSON rule set file for content filtering.
1658         * MiniBrowser/wpe/main.cpp:
1659         (filterSavedCallback): Added.
1660         (main): Support loading a JSON rule set file for content filtering.
1661         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1662         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1663         (WTF::derefGPtr): Ditto.
1664         (testEmptyStore):
1665         (testSaveInvalidFilter):
1666         (testSaveLoadFilter):
1667         (testSavedFilterIdentifierMatch):
1668         (testRemoveFilter):
1669         (testSaveMultipleFilters):
1670         (testSaveFilterFromFile):
1671         (testFilterPersistence):
1672         (beforeAll):
1673         (afterAll):
1674         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1675         (removeOldInjectedContentAndResetLists): Also reset content filters.
1676         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1677         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1678         the element affected by the style sheet.
1679         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1680         and returns it to be used by tests.
1681         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1682         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1683         (serverCallback): Add support for serving a CSS style sheet for testing.
1684         (beforeAll): Add call to testUserContentManagerContentFilter().
1685         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1686
1687 2019-02-19  Keith Rollin  <krollin@apple.com>
1688
1689         Add timing information to build output
1690         https://bugs.webkit.org/show_bug.cgi?id=194839
1691         <rdar://problem/48219609>
1692
1693         Reviewed by Alexey Proskuryakov.
1694
1695         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1696         emit each project's build time to its output. E.g.,
1697
1698             ** BUILD SUCCEEDED ** [0.132 sec]
1699
1700         * Scripts/webkitdirs.pm:
1701         (XcodeOptions):
1702
1703 2019-02-19  Truitt Savell  <tsavell@apple.com>
1704
1705         Unreviewed, rolling out r241784.
1706
1707         Broke all OpenSource builds.
1708
1709         Reverted changeset:
1710
1711         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1712         instances view"
1713         https://bugs.webkit.org/show_bug.cgi?id=172848
1714         https://trac.webkit.org/changeset/241784
1715
1716 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1717
1718         [LFC][Floats] Remove redundant intersecting logic
1719         https://bugs.webkit.org/show_bug.cgi?id=194804
1720
1721         Reviewed by Antti Koivisto.
1722
1723         * LayoutReloaded/misc/LFC-passing-tests.txt:
1724
1725 2019-02-19  Dean Jackson  <dino@apple.com>
1726
1727         Clean-up output from generate-xcfilelists so it can be filtered
1728         https://bugs.webkit.org/show_bug.cgi?id=194795
1729
1730         Reviewed by Joseph Pecoraro (and Keith Rollin).
1731
1732         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1733         make a slight tweak to filter-build-webkit so such lines are marked
1734         as plain.
1735
1736         * Scripts/filter-build-webkit:
1737         * Scripts/generate-xcfilelists:
1738
1739 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1740
1741         pytest is not correctly auto-installed
1742         https://bugs.webkit.org/show_bug.cgi?id=194707
1743
1744         Reviewed by Carlos Garcia Campos.
1745
1746         * Scripts/webkitpy/thirdparty/__init__.py:
1747         (AutoinstallImportHook._install_pytest):
1748
1749 2019-02-18  Chris Dumez  <cdumez@apple.com>
1750
1751         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1752         https://bugs.webkit.org/show_bug.cgi?id=194797
1753         <rdar://problem/48055151>
1754
1755         Reviewed by Geoffrey Garen.
1756
1757         Add API test coverage.
1758
1759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1760
1761 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1762
1763         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1764         https://bugs.webkit.org/show_bug.cgi?id=194670
1765         <rdar://problem/39066529>
1766
1767         Reviewed by Tim Horton.
1768
1769         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1770         pasted in an editable area as attachment elements.
1771
1772         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1773         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1774         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1775         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1776         (TestWebKitAPI::TEST):
1777         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1778         (WTR::InjectedBundlePage::InjectedBundlePage):
1779
1780 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1781
1782         Fix API test after r241728
1783        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1786         (TEST):
1787         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1788
1789 2019-02-18  Daniel Bates  <dabates@apple.com>
1790
1791         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1792         https://bugs.webkit.org/show_bug.cgi?id=192824
1793         <rdar://problem/47100332>
1794
1795         Reviewed by Wenson Hsieh.
1796
1797         Fix a bug where the wrong usage code was used for F13 thru F24.
1798
1799         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1800         (keyCodeForDOMFunctionKey):
1801
1802 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1803
1804         Bytecode cache should a have a boot-specific validation
1805         https://bugs.webkit.org/show_bug.cgi?id=194769
1806         <rdar://problem/48149509>
1807
1808         Reviewed by Keith Miller.
1809
1810         Add test for WTF::bootSessionUUIDString()
1811
1812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1813         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1814         (TEST):
1815
1816 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1817
1818         Disable safe browsing in WKWebView and remove its WKPreferences API
1819         https://bugs.webkit.org/show_bug.cgi?id=194723
1820         <rdar://problem/48122993>
1821
1822         Reviewed by Geoffrey Garen.
1823
1824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1825         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1826         (TEST):
1827         (safeBrowsingView):
1828         Make tests use SPI instead of API.
1829
1830 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1831
1832         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1833         https://bugs.webkit.org/show_bug.cgi?id=194586
1834
1835         Reviewed by Ross Kirsling.
1836
1837         * DumpRenderTree/win/DumpRenderTree.cpp:
1838         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1839         * Scripts/webkitpy/port/driver.py:
1840         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1841
1842 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1843
1844         Unreviewed, rolling out r241620.
1845
1846         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1847         (Requested by ddkilzer on #webkit.)
1848
1849         Reverted changeset:
1850
1851         "[WTF] Add environment variable helpers"
1852         https://bugs.webkit.org/show_bug.cgi?id=192405
1853         https://trac.webkit.org/changeset/241620
1854
1855 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1856
1857         [LFC] RenderImage's default intrinsic size is 0.
1858         https://bugs.webkit.org/show_bug.cgi?id=194745
1859
1860         Reviewed by Antti Koivisto.
1861
1862         * LayoutReloaded/misc/LFC-passing-tests.txt:
1863
1864 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1865
1866         [LFC][BFC] Add support for block replaced intrinsic width.
1867         https://bugs.webkit.org/show_bug.cgi?id=194705
1868
1869         Reviewed by Simon Fraser.
1870
1871         * LayoutReloaded/misc/LFC-passing-tests.txt:
1872
1873 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1874
1875         [LFC] Apply min/max width constraints to preferred width computation
1876         https://bugs.webkit.org/show_bug.cgi?id=194739
1877
1878         Reviewed by Simon Fraser.
1879
1880         * LayoutReloaded/misc/LFC-passing-tests.txt:
1881
1882 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1883
1884         [WTF] Add environment variable helpers
1885         https://bugs.webkit.org/show_bug.cgi?id=192405
1886
1887         Reviewed by Michael Catanzaro.
1888
1889         * DumpRenderTree/mac/DumpRenderTree.mm:
1890         (libraryPathForDumpRenderTree):
1891         * DumpRenderTree/win/DumpRenderTree.cpp:
1892         (libraryPathForDumpRenderTree):
1893         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1894         (setUpIOSLayoutTestCommunication):
1895         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1896         (beforeAll):
1897         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1898         (main):
1899         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1900         (WebKitTestBus::run):
1901         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1902         (WTR::getOutputDir):
1903         (WTR::initializeFontConfigSetting):
1904         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1905         (WTR::InjectedBundle::platformInitialize):
1906         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1907         (WTR::topLevelPath):
1908         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1909         (WTR::topLevelPath):
1910         (WTR::getOutputDir):
1911         (WTR::activateFonts):
1912         * WebKitTestRunner/TestController.cpp:
1913         (WTR::TestController::libraryPathForTesting):
1914         (WTR::TestController::generateContextConfiguration const):
1915         (WTR::TestController::generatePageConfiguration):
1916         (WTR::TestController::decideDestinationWithSuggestedFilename):
1917         (WTR::TestController::platformAdjustContext):
1918         * WebKitTestRunner/TestController.h:
1919         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1920         (WTR::TestController::cocoaPlatformInitialize):
1921         (WTR::TestController::platformAdjustContext):
1922         * WebKitTestRunner/gtk/main.cpp:
1923         (main):
1924         * WebKitTestRunner/mac/TestControllerMac.mm:
1925         (WTR::TestController::configureContentExtensionForTest):
1926         * WebKitTestRunner/wpe/main.cpp:
1927         (main):
1928         Utilize WTF::Environment where possible.
1929
1930 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1931
1932         [iOS] WKWebView callout bar is missing Change Writing Direction item
1933         https://bugs.webkit.org/show_bug.cgi?id=190015
1934         <rdar://problem/44810366>
1935
1936         Reviewed by Tim Horton.
1937
1938         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1939         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1942         (TestWebKitAPI::TEST):
1943
1944 2019-02-15  Chris Dumez  <cdumez@apple.com>
1945
1946         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1947         https://bugs.webkit.org/show_bug.cgi?id=194717
1948         <rdar://problem/47884404>
1949
1950         Reviewed by Brady Eidson.
1951
1952         Add API test coverage.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1955
1956 2019-02-15  Youenn Fablet  <youenn@apple.com>
1957
1958         Make navigator.mediaDevices SecureContext
1959         https://bugs.webkit.org/show_bug.cgi?id=194666
1960
1961         Reviewed by Eric Carlson.
1962
1963         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1964         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1965         (TEST_F):
1966
1967 2019-02-15  Brian Burg  <bburg@apple.com>
1968
1969         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1970         https://bugs.webkit.org/show_bug.cgi?id=194411
1971         <rdar://problem/47787614>
1972
1973         Reviewed by Joseph Pecoraro.
1974
1975         Remove unnecessary soft linking macro usage.
1976
1977         * DumpRenderTree/mac/TestRunnerMac.mm:
1978         (TestRunner::inspectorTestStubURL):
1979         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1980         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1981         (WTR::TestRunner::inspectorTestStubURL):
1982
1983 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1984
1985         Unreviewed, rolling out r241559 and r241566.
1986         https://bugs.webkit.org/show_bug.cgi?id=194710
1987
1988         Causes layout test crashes under GuardMalloc (Requested by
1989         ryanhaddad on #webkit).
1990
1991         Reverted changesets:
1992
1993         "[WTF] Add environment variable helpers"
1994         https://bugs.webkit.org/show_bug.cgi?id=192405
1995         https://trac.webkit.org/changeset/241559
1996
1997         "Unreviewed build fix for WinCairo Debug after r241559."
1998         https://trac.webkit.org/changeset/241566
1999
2000 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2001
2002         [LFC] Out-of-flow box is never a float box
2003         https://bugs.webkit.org/show_bug.cgi?id=194704
2004
2005         Reviewed by Antti Koivisto.
2006
2007         * LayoutReloaded/misc/LFC-passing-tests.txt:
2008
2009 2019-02-10  Darin Adler  <darin@apple.com>
2010
2011         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2012         https://bugs.webkit.org/show_bug.cgi?id=194487
2013
2014         Reviewed by Daniel Bates.
2015
2016         * DumpRenderTree/win/DumpRenderTree.cpp:
2017         (applicationId): Use makeString instead of String::format.
2018         (main): Ditto.
2019         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2020         (TestWebKitAPI::Util::createURLForResource): Ditto.
2021         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2022         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2023
2024         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2025         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2026         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2027         (WTR::createStringWithAttributes): Use appendLiteral.
2028         (WTR::AccessibilityUIElement::helpText const): Ditto.
2029         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2030         directly instead of using String::format.
2031         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2032         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2033
2034 2019-02-15  Truitt Savell  <tsavell@apple.com>
2035
2036         Unreviewed, rolling out r241564.
2037
2038         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2039
2040         Reverted changeset:
2041
2042         "[Mac] WebInspectorUI.framework does not need to be soft-
2043         linked anymore"
2044         https://bugs.webkit.org/show_bug.cgi?id=194411
2045         https://trac.webkit.org/changeset/241564
2046
2047 2019-02-15  Saam barati  <sbarati@apple.com>
2048
2049         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2050         https://bugs.webkit.org/show_bug.cgi?id=194036
2051
2052         Reviewed by Yusuke Suzuki.
2053
2054         * Scripts/run-jsc-stress-tests:
2055
2056 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2057
2058         Fix the build.
2059
2060         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2061         (WTR::UIScriptController::drawSquareInEditableImage):
2062         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2063         (TestWebKitAPI::drawSquareInEditableImage):
2064
2065 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2066
2067         Fix the build.
2068
2069         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2070         (WTR::UIScriptController::drawSquareInEditableImage):
2071         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2072         (TestWebKitAPI::drawSquareInEditableImage):
2073
2074 2019-02-14  Brian Burg  <bburg@apple.com>
2075
2076         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2077         https://bugs.webkit.org/show_bug.cgi?id=194411
2078         <rdar://problem/47787614>
2079
2080         Reviewed by Joseph Pecoraro.
2081
2082         Remove unnecessary soft linking macro usage.
2083
2084         * DumpRenderTree/mac/TestRunnerMac.mm:
2085         (TestRunner::inspectorTestStubURL):
2086         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2087         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2088         (WTR::TestRunner::inspectorTestStubURL):
2089
2090 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2091
2092         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2093         https://bugs.webkit.org/show_bug.cgi?id=194599
2094
2095         Reviewed by Lucas Forschler.
2096
2097         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2098         (StatusBubble._build_bubble):
2099
2100 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2101
2102         [ews-app] Set Foreign Key in Django build model
2103         https://bugs.webkit.org/show_bug.cgi?id=194667
2104
2105         Reviewed by Lucas Forschler.
2106
2107         * BuildSlaveSupport/ews-app/ews/models/build.py:
2108         (Build):
2109
2110 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2111
2112         [WTF] Add environment variable helpers
2113         https://bugs.webkit.org/show_bug.cgi?id=192405
2114
2115         Reviewed by Michael Catanzaro.
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (libraryPathForDumpRenderTree):
2119         * DumpRenderTree/win/DumpRenderTree.cpp:
2120         (libraryPathForDumpRenderTree):
2121         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2122         (setUpIOSLayoutTestCommunication):
2123         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2124         (TestWebKitAPI::strip):
2125         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2126         (beforeAll):
2127         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2128         (main):
2129         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2130         (WebKitTestBus::run):
2131         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2132         (WTR::getOutputDir):
2133         (WTR::initializeFontConfigSetting):
2134         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2135         (WTR::InjectedBundle::platformInitialize):
2136         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2137         (WTR::topLevelPath):
2138         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2139         (WTR::topLevelPath):
2140         (WTR::getOutputDir):
2141         (WTR::activateFonts):
2142         * WebKitTestRunner/TestController.cpp:
2143         (WTR::TestController::libraryPathForTesting):
2144         (WTR::TestController::generateContextConfiguration const):
2145         (WTR::TestController::generatePageConfiguration):
2146         (WTR::TestController::decideDestinationWithSuggestedFilename):
2147         (WTR::TestController::platformAdjustContext):
2148         * WebKitTestRunner/TestController.h:
2149         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2150         (WTR::TestController::cocoaPlatformInitialize):
2151         (WTR::TestController::platformAdjustContext):
2152         * WebKitTestRunner/gtk/main.cpp:
2153         (main):
2154         * WebKitTestRunner/mac/TestControllerMac.mm:
2155         (WTR::TestController::configureContentExtensionForTest):
2156         * WebKitTestRunner/wpe/main.cpp:
2157         (main):
2158         Utilize WTF::Environment where possible.
2159
2160 2019-02-14  Chris Dumez  <cdumez@apple.com>
2161
2162         [PSON] Introduce a WebContent Process cache
2163         https://bugs.webkit.org/show_bug.cgi?id=194594
2164         <rdar://problem/46793397>
2165
2166         Reviewed by Geoff Garen.
2167
2168         Update API tests to turn on the WebContent Process cache.
2169
2170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2171
2172 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2173
2174         Unreviewed, build fix after r241480
2175
2176         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2177         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2178         (-[DragAndDropSimulator initWithWebView:]):
2179
2180 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2181
2182         AX: ARIA Reflection was disabled in error
2183         https://bugs.webkit.org/show_bug.cgi?id=194647
2184         <rdar://problem/48068336>
2185
2186         Reviewed by Ryosuke Niwa.
2187
2188         Remove test override now that this feature should be enabled by default.
2189
2190         * WebKitTestRunner/TestController.cpp:
2191         (WTR::TestController::resetPreferencesToConsistentValues):
2192
2193 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2194
2195         Unreviewed, rolling out r241486.
2196         https://bugs.webkit.org/show_bug.cgi?id=194655
2197
2198         causing API failures in builds (Requested by ShawnRoberts on
2199         #webkit).
2200
2201         Reverted changeset:
2202
2203         "[Cocoa] Media elements will restart network buffering just
2204         before suspending"
2205         https://bugs.webkit.org/show_bug.cgi?id=193691
2206         https://trac.webkit.org/changeset/241486
2207
2208 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2209
2210         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2211         https://bugs.webkit.org/show_bug.cgi?id=194622
2212
2213         Reviewed by Antti Koivisto.
2214
2215         * LayoutReloaded/misc/LFC-passing-tests.txt:
2216
2217 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2218
2219         [LFC] Shrink-to-fit-width should be constrained by min/max width
2220         https://bugs.webkit.org/show_bug.cgi?id=194653
2221
2222         Reviewed by Antti Koivisto.
2223
2224         * LayoutReloaded/misc/LFC-passing-tests.txt:
2225
2226 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2227
2228         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2229         https://bugs.webkit.org/show_bug.cgi?id=194641
2230
2231         Reviewed by Geoffrey Garen.
2232
2233         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2234         so that the test would fail without this fix.
2235
2236         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2237         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2238
2239 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2240
2241         [ews-app] Change log level for a log statement
2242
2243         Unreviewed minor fix.
2244
2245         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2246         (Patch.save_patch):
2247
2248 2019-02-13  Jer Noble  <jer.noble@apple.com>
2249
2250         [Cocoa] Media elements will restart network buffering just before suspending
2251         https://bugs.webkit.org/show_bug.cgi?id=193691
2252
2253         Reviewed by Eric Carlson.
2254
2255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2257         (TEST):
2258
2259 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2260
2261         [ews-app] Fetch builder id to name mapping
2262         https://bugs.webkit.org/show_bug.cgi?id=194355
2263
2264         Reviewed by Lucas Forschler.
2265
2266         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2267         (Buildbot.get_builder_id_to_name_mapping):
2268         (Buildbot._get_display_name_from_builder_name):
2269
2270 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2271
2272         Further restricting webarchive loads
2273         https://bugs.webkit.org/show_bug.cgi?id=194567
2274         <rdar://problem/47610130>
2275
2276         Reviewed by Youenn Fablet.
2277
2278         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2279         navigations on drop.
2280
2281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2282         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2283         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2284         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2285         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2286         (TestWebKitAPI::TEST):
2287         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2288         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2289         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2290         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2291         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2292         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2293         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2294
2295 2019-02-13  John Wilander  <wilander@apple.com>
2296
2297         Store Ad Click Attribution requests in the network process
2298         https://bugs.webkit.org/show_bug.cgi?id=194510
2299         <rdar://problem/47650118>
2300
2301         Reviewed by Alex Christensen and Daniel Bates.
2302
2303         This patch adds two TestRunner functions:
2304         - dumpAdClickAttribution()
2305         - clearAdClickAttribution()
2306
2307         They call into the network process to dump and clear Ad Click
2308         Attribution state, respectively.
2309
2310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2312         (WTR::TestRunner::dumpAdClickAttribution):
2313         (WTR::TestRunner::clearAdClickAttribution):
2314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::TestController::resetStateToConsistentValues):
2317         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2318         (WTR::adClickAttributionStringResultCallback):
2319         (WTR::TestController::dumpAdClickAttribution):
2320         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2321         (WTR::adClickAttributionVoidCallback):
2322         (WTR::TestController::clearAdClickAttribution):
2323         * WebKitTestRunner/TestController.h:
2324         * WebKitTestRunner/TestInvocation.cpp:
2325         (WTR::TestInvocation::dumpResults):
2326         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2327         (WTR::TestInvocation::dumpAdClickAttribution):
2328         * WebKitTestRunner/TestInvocation.h:
2329
2330 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2331
2332         [ews-app] Generate status-bubble
2333         https://bugs.webkit.org/show_bug.cgi?id=194572
2334
2335         Reviewed by Lucas Forschler.
2336
2337         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2338         (StatusBubble._build_bubble):
2339         (StatusBubble._should_show_bubble_for):
2340         (StatusBubble._build_bubbles_for_patch):
2341
2342 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2343
2344         [ews-app] Add status bubble html template
2345         https://bugs.webkit.org/show_bug.cgi?id=194571
2346
2347         Reviewed by Lucas Forschler.
2348
2349         * BuildSlaveSupport/ews-app/ews/templates: Added.
2350         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2351
2352 2019-02-12  Chris Dumez  <cdumez@apple.com>
2353
2354         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2355         https://bugs.webkit.org/show_bug.cgi?id=194568
2356         <rdar://problem/47944490>
2357
2358         Reviewed by Ryosuke Niwa.
2359
2360         Add API test coverage.
2361
2362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2363         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2364
2365 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2366
2367         webkitpy: Remove bug_dummy from parsed test expectations
2368         https://bugs.webkit.org/show_bug.cgi?id=194562
2369         <rdar://problem/47853999>
2370
2371         Reviewed by Lucas Forschler.
2372
2373         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2374         (TestExpectationParser):
2375         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2376         skipped tests.
2377         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2378
2379 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Add method to fetch patch
2382         https://bugs.webkit.org/show_bug.cgi?id=194518
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2387         (Patch.get_patch):
2388
2389 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2390
2391         [LFC] Expand tests coverage (60 new tests -> 860)
2392
2393         Unreviewed test gardening (run-singly, --child-processes=1).
2394
2395         * LayoutReloaded/misc/LFC-passing-tests.txt:
2396
2397 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2398
2399         Allow pages to trigger programmatic paste from script on iOS
2400         https://bugs.webkit.org/show_bug.cgi?id=194271
2401         <rdar://problem/47808810>
2402
2403         Reviewed by Tim Horton.
2404
2405         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2406
2407         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2408         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2409         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2410         (WTR::UIScriptController::rectForMenuAction const):
2411
2412         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2413         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2414         for when the menu is shown or hidden.
2415
2416         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2417         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2418         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2419         (WTR::UIScriptController::setDidShowMenuCallback):
2420         (WTR::UIScriptController::didShowMenuCallback const):
2421         (WTR::UIScriptController::setDidHideMenuCallback):
2422         (WTR::UIScriptController::didHideMenuCallback const):
2423         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2424         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2425         (WTR::UIScriptController::rectForMenuAction const):
2426         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2427         * WebKitTestRunner/TestController.cpp:
2428         (WTR::TestController::resetPreferencesToConsistentValues):
2429         (WTR::updateTestOptionsFromTestHeader):
2430         * WebKitTestRunner/TestOptions.h:
2431
2432         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2433         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2434
2435         (WTR::TestOptions::hasSameInitializationOptions const):
2436         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2437         (WTR::UIScriptController::calendarType const):
2438         (WTR::UIScriptController::platformUndoManager const):
2439         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2440         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2441         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2442         (-[TestRunnerWKWebView dealloc]):
2443         (-[TestRunnerWKWebView _didShowMenu]):
2444         (-[TestRunnerWKWebView _didHideMenu]):
2445
2446         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2447
2448         * WebKitTestRunner/ios/TestControllerIOS.mm:
2449         (WTR::handleMenuWillHideNotification):
2450         (WTR::handleMenuDidHideNotification):
2451         (WTR::TestController::platformInitialize):
2452         (WTR::TestController::platformDestroy):
2453         (WTR::TestController::platformResetStateToConsistentValues):
2454
2455         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2456         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2457
2458         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2459         (WTR::forEachViewInHierarchy):
2460         (WTR::findViewInHierarchyOfType):
2461
2462         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2463         functions that dig through a given view's hierarchy in search of a view of a given class.
2464
2465         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2466         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2467         (WTR::UIScriptController::selectionCaretViewRect const):
2468         (WTR::UIScriptController::selectionRangeViewRects const):
2469         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2470         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2471
2472         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2473
2474         (WTR::UIScriptController::rectForMenuAction const):
2475
2476         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2477         callout bar) whose label matches the given string.
2478
2479         (WTR::UIScriptController::platformContentView const):
2480
2481         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2482         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2483         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2484
2485         (WTR::UIScriptController::platformUndoManager const): Deleted.
2486         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2487         (WTR::UIScriptController::platformContentView const):
2488         (WTR::UIScriptController::platformUndoManager const): Deleted.
2489
2490 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2491
2492         webkitpy: No option to only show unexpected failures in results.html for iPad
2493         https://bugs.webkit.org/show_bug.cgi?id=194554
2494         <rdar://problem/47922442>
2495
2496         Rubber-stamped by Aakash Jain.
2497
2498         Just because a TestExpecations file does not exist for a specific platform does not mean that
2499         TestExpecations are not being used, given that platforms inherit test expectations.
2500
2501         * Scripts/webkitpy/port/base.py:
2502         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2503         * Scripts/webkitpy/port/base_unittest.py:
2504         (PortTest.test_uses_test_expectations_file):
2505
2506 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2507
2508         Remove setDefersLoading infrastructure from WebKit2
2509         https://bugs.webkit.org/show_bug.cgi?id=194506
2510
2511         Reviewed by Brady Eidson.
2512
2513         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2515         (WTR::TestRunner::setDefersLoading): Deleted.
2516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2517
2518 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2519
2520         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2521         https://bugs.webkit.org/show_bug.cgi?id=194522
2522         <rdar://problem/47789393>
2523
2524         Reviewed by Chris Dumez.
2525
2526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2528         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2529         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2530
2531 2019-02-12  Andy Estes  <aestes@apple.com>
2532
2533         [iOSMac] Enable Parental Controls Content Filtering
2534         https://bugs.webkit.org/show_bug.cgi?id=194521
2535         <rdar://39732376>
2536
2537         Reviewed by Tim Horton.
2538
2539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2540
2541 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2542
2543         [LFC][IFC] Add intrinsic width support for float boxes.
2544         https://bugs.webkit.org/show_bug.cgi?id=194528
2545
2546         Reviewed by Antti Koivisto.
2547
2548         Expand tests coverage (2 new tests -> 800).
2549         (This is the correct test ordering --runs-singly --child-processes=1)
2550
2551         * LayoutReloaded/misc/LFC-passing-tests.txt:
2552
2553 2019-02-12  Rob Buis  <rbuis@igalia.com>
2554
2555         Implement serializing in MIME type parser
2556         https://bugs.webkit.org/show_bug.cgi?id=193909
2557
2558         Reviewed by Darin Adler.
2559
2560         Add various tests involving upper case, non-ASCII, control/null characters,
2561         various HTTP whitespace, single quotes and an unpaired surrogate.
2562
2563         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2564         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2565         (TestWebKitAPI::serializeIfValid):
2566         (TestWebKitAPI::TEST):
2567
2568 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2569
2570         [Cocoa] Ask platform for generic font family mappings
2571         https://bugs.webkit.org/show_bug.cgi?id=187723
2572         <rdar://problem/41892438>
2573
2574         Reviewed by Brent Fulgham.
2575
2576         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2577
2578         * DumpRenderTree/mac/DumpRenderTree.mm:
2579         (allowedFontFamilySet):
2580         * WebKitTestRunner/mac/TestControllerMac.mm:
2581         (WTR::allowedFontFamilySet):
2582
2583 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2584
2585         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2586         https://bugs.webkit.org/show_bug.cgi?id=193622
2587
2588         Reviewed by Michael Catanzaro.
2589
2590         This adds support for loading content extension rule sets from the JSON files which
2591         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2592         of WKTR for this could be removed, but that is left for a follow-up patch with
2593         cleanups.
2594
2595         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2596         * WebKitTestRunner/TestController.cpp:
2597         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2598         avoid having the null-terminator copied into the result.
2599         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2600         part of the preparations to run a test.
2601         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2602         (WTR::contentExtensionStoreCallback): Added.
2603         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2604         used for content extensions test.
2605         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2606         extensions and compiling the JSON rule set for tests involving content extensions.
2607         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2608         testing and disables content extensions.
2609         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2610         resetContentExtensions().
2611         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2612         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2613         configureContentExtensionForTest(), and userContentController().
2614
2615 2019-02-11  Daniel Bates  <dabates@apple.com>
2616
2617         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2618         https://bugs.webkit.org/show_bug.cgi?id=191446
2619         <rdar://problem/45929460>
2620
2621         Reviewed by Tim Horton.
2622
2623         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2624
2625         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2626         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2627         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2628         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2629         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2630         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2631         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2632         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2633         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2634         (WTR::arrayLength):
2635         (WTR::parseModifierArray):
2636         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2637         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2638         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2639         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2640
2641 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2642
2643         Unreviewed, rolling out r241272 and r241276.
2644         https://bugs.webkit.org/show_bug.cgi?id=194514
2645
2646         Broke the Apple Internal build and the fix requires human
2647         intervention :( (Requested by dydz on #webkit).
2648
2649         Reverted changesets:
2650
2651         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2652         https://bugs.webkit.org/show_bug.cgi?id=191446
2653         https://trac.webkit.org/changeset/241272
2654
2655         "Fix internal iOS build after r241272"
2656         https://bugs.webkit.org/show_bug.cgi?id=191446
2657         https://trac.webkit.org/changeset/241276
2658
2659 2019-02-11  Truitt Savell  <tsavell@apple.com>
2660
2661         Unreviewed, rolling out r241269.
2662
2663         Caused 5 layout tests crashes on Mac WK1
2664
2665         Reverted changeset:
2666
2667         "DumpRenderTree should report unknown options"
2668         https://bugs.webkit.org/show_bug.cgi?id=191303
2669         https://trac.webkit.org/changeset/241269
2670
2671 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2672
2673         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2674         https://bugs.webkit.org/show_bug.cgi?id=194313
2675
2676         Reviewed by Tim Horton.
2677
2678         Add a helper to determine whether the web view is presenting modal UI.
2679
2680         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2681         (WTR::UIScriptController::isPresentingModally const):
2682         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2683         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2684         (WTR::UIScriptController::isPresentingModally const):
2685         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2686         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2687         (WTR::UIScriptController::calendarType const): Deleted.
2688         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2689         (WTR::UIScriptController::isPresentingModally const):
2690         (WTR::UIScriptController::calendarType const):
2691         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2692         (WTR::UIScriptController::calendarType const):
2693
2694 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2695
2696         GCHeapInspector: Show the retained sizes in more places
2697         https://bugs.webkit.org/show_bug.cgi?id=194464
2698
2699         Reviewed by Simon Fraser.
2700
2701         * GCHeapInspector/gc-heap-inspector.html:
2702         * GCHeapInspector/script/interface.js:
2703         (HeapInspectorUtils.humanReadableSize):
2704         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2705         (HeapInspectorUtils.spanForNode.span.span):
2706         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2707         (HeapSnapshotInspector.prototype.buildRoots):
2708
2709 2019-02-11  Daniel Bates  <dabates@apple.com>
2710
2711         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2712         https://bugs.webkit.org/show_bug.cgi?id=191446
2713         <rdar://problem/45929460>
2714
2715         Reviewed by Tim Horton.
2716
2717         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2718
2719         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2720         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2721         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2722         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2723         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2724         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2725         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2726         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2727         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2728         (WTR::arrayLength):
2729         (WTR::parseModifierArray):
2730         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2731         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2732         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2733         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2734
2735 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2736
2737         DumpRenderTree should report unknown options
2738         https://bugs.webkit.org/show_bug.cgi?id=191303
2739
2740         Reviewed by Frédéric Wang.
2741
2742         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2743         to report unknown options.
2744         Added and assigned test options which are currently used in tests.
2745
2746         * DumpRenderTree/TestOptions.cpp:
2747         (TestOptions::TestOptions):
2748
2749 2019-02-11  Truitt Savell  <tsavell@apple.com>
2750
2751         Unreviewed, rolling out r241229.
2752
2753         Revision broke internal builds for watchOS.
2754
2755         Reverted changeset:
2756
2757         "[Cocoa] Ask platform for generic font family mappings"
2758         https://bugs.webkit.org/show_bug.cgi?id=187723
2759         https://trac.webkit.org/changeset/241229
2760
2761 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2762
2763         [WinCairo][MiniBrowser] Basic authentication always fails.
2764         https://bugs.webkit.org/show_bug.cgi?id=194496
2765
2766         Reviewed by Don Olmstead.
2767
2768         * MiniBrowser/win/DialogHelper.h:
2769         (Dialog::getText):
2770
2771 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2772
2773         [GStreamer] GstMappedBuffer testsuite build fails
2774         https://bugs.webkit.org/show_bug.cgi?id=194495
2775
2776         Reviewed by Carlos Garcia Campos.
2777
2778         Fix the build by explicitely adding the gstreamer1.0-audio include
2779         directories to the include path.
2780
2781         * TestWebKitAPI/PlatformGTK.cmake:
2782         * TestWebKitAPI/PlatformWPE.cmake:
2783
2784 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2785
2786         [GTK][WPE] Add enable-javascript-markup setting
2787         https://bugs.webkit.org/show_bug.cgi?id=193439
2788
2789         Reviewed by Michael Catanzaro.
2790
2791         Add test cases to check the new setting.
2792
2793         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2794         (testWebKitSettings):
2795         (testWebKitSettingsJavaScriptMarkup):
2796         (beforeAll):
2797
2798 2019-02-10  Darin Adler  <darin@apple.com>
2799
2800         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2801         https://bugs.webkit.org/show_bug.cgi?id=194485
2802
2803         Reviewed by Daniel Bates.
2804
2805         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2806
2807 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2808
2809         Add more tests for clampTo<>()
2810         https://bugs.webkit.org/show_bug.cgi?id=194462
2811
2812         Reviewed by Geoffrey Garen.
2813
2814         Darin suggested to test the very last floating point number
2815         at the boundaries when truncating to integer.
2816         I added test for max/min and max-1/min-1.
2817
2818         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2819         (TestWebKitAPI::TEST):
2820
2821 2019-02-09  Darin Adler  <darin@apple.com>
2822
2823         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2824         https://bugs.webkit.org/show_bug.cgi?id=194021
2825
2826         Reviewed by Geoffrey Garen.
2827
2828         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2829         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2830         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2831
2832 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2833
2834         [LFC][IFC] Add intrinsic width support for basic inline containers
2835         https://bugs.webkit.org/show_bug.cgi?id=194473
2836
2837         Reviewed by Antti Koivisto.
2838
2839         Expand tests coverage (11 new tests -> 798)
2840
2841         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2842
2843 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2844
2845         Fix MiniBrowser's entitlements
2846         https://bugs.webkit.org/show_bug.cgi?id=192431
2847
2848         Reviewed by Joseph Pecoraro.
2849
2850         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2851         files, making it impossible to load any extension.
2852
2853         * MiniBrowser/MiniBrowser.entitlements:
2854
2855 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2856
2857         [Cocoa] Ask platform for generic font family mappings
2858         https://bugs.webkit.org/show_bug.cgi?id=187723
2859         <rdar://problem/41892438>
2860
2861         Reviewed by Brent Fulgham.
2862
2863         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2864
2865         * DumpRenderTree/mac/DumpRenderTree.mm:
2866         (allowedFontFamilySet):
2867         * WebKitTestRunner/mac/TestControllerMac.mm:
2868         (WTR::allowedFontFamilySet):
2869
2870 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2871
2872         [GTK] Implement back/forward touchpad gesture
2873         https://bugs.webkit.org/show_bug.cgi?id=193919
2874
2875         Reviewed by Michael Catanzaro.
2876
2877         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2878         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2879
2880 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2881
2882         Add SPI to use networking daemon instead of XPC service
2883         https://bugs.webkit.org/show_bug.cgi?id=194427
2884
2885         Reviewed by Geoffrey Garen
2886
2887         * MiniBrowser/MiniBrowser.entitlements:
2888
2889 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] Ensure that every builder in config.json has short name
2892         https://bugs.webkit.org/show_bug.cgi?id=194461
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-build/loadConfig.py:
2897         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2898
2899 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-build] Add short name to config.json
2902         https://bugs.webkit.org/show_bug.cgi?id=194456
2903
2904         Reviewed by Lucas Forschler.
2905
2906         * BuildSlaveSupport/ews-build/config.json: Added short name.
2907         * BuildSlaveSupport/ews-build/loadConfig.py:
2908         (loadBuilderConfig): Set the short name as the builder description.
2909
2910 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2911
2912         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2913         https://bugs.webkit.org/show_bug.cgi?id=194418
2914
2915         Reviewed by Lucas Forschler.
2916
2917         Do not include errors trying when finding crashlogs at the end of
2918         a run-webkit-tests run since we don't process those errors.
2919
2920         * Scripts/webkitpy/port/darwin.py:
2921         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2922         * Scripts/webkitpy/port/ios_device.py:
2923         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2924         * Scripts/webkitpy/port/watch_device.py:
2925         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2926
2927 2019-02-08  Beth Dakin  <bdakin@apple.com>
2928
2929         Add afterScreenUpdates to WKSnapshotConfiguration
2930         https://bugs.webkit.org/show_bug.cgi?id=194362
2931         -and corresponding-
2932         <rdar://problem/40655528> Please add an "after screen updates" property to 
2933         WKSnapshotConfiguration (to solve blank snapshots)
2934
2935         Reviewed by Tim Horton.
2936
2937         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2938         (TEST):
2939
2940 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2941
2942         clampTo(): do not convert the input to double when dealing with integers
2943         https://bugs.webkit.org/show_bug.cgi?id=194263
2944         <rdar://problem/47692312>
2945
2946         Reviewed by Darin Adler.
2947
2948         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2949         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2950         (TestWebKitAPI::testClampFloatingPointToInteger):
2951         (TestWebKitAPI::testClampSameSignIntegers):
2952         (TestWebKitAPI::testClampUnsignedToSigned):
2953         (TestWebKitAPI::testClampSignedToUnsigned):
2954
2955 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2956
2957         webkitpy: Respect --dedicated-simulators flag
2958         https://bugs.webkit.org/show_bug.cgi?id=194416
2959         <rdar://problem/47894722>
2960
2961         Reviewed by Lucas Forschler.
2962
2963         * Scripts/webkitpy/port/device_port.py:
2964         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2965         available devices can be safely ignored.
2966
2967 2019-02-07  Keith Rollin  <krollin@apple.com>
2968
2969         Remove extra copy of 100x100-red.tga
2970         https://bugs.webkit.org/show_bug.cgi?id=194371
2971         <rdar://problem/47873465>
2972
2973         Reviewed by Said Abou-Hallawa.
2974
2975         In order to help it pass its tests, Bug 194190 added a second copy of
2976         the file 100x100-red.tga. However, it turns out that this additional
2977         file wasn't actually needed, and that that sole previous copy was
2978         sufficient. At the same time, this second copy -- which was copied to
2979         the same location in the build output as the first copy -- now caused
2980         XCBuild to complain because there were two production rules for the
2981         same output file. Address this by removing the newly-added extra copy.
2982
2983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2984         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2985
2986 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2987
2988         Deprecate WKBundlePageSetDefersLoading
2989         https://bugs.webkit.org/show_bug.cgi?id=191394
2990
2991         Reviewed by Dean Jackson.
2992
2993         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2994         (WTR::TestRunner::setDefersLoading):
2995
2996 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2997
2998         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2999         https://bugs.webkit.org/show_bug.cgi?id=194391
3000
3001         Reviewed by Antti Koivisto.
3002
3003         * LayoutReloaded/misc/LFC-passing-tests.txt:
3004
3005 2019-02-06  Keith Rollin  <krollin@apple.com>
3006
3007         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3008         https://bugs.webkit.org/show_bug.cgi?id=193975
3009         <rdar://problem/47643306>
3010
3011         Reviewed by Tim Horton.
3012
3013         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3014         the Info.plist file into the bundle. This step is not necessary as the
3015         implicit "bundle up all the build products into a framework" build
3016         phase does this already. Having the Copy Bundle Resources phase do
3017         this causes a conflict under XCBuild, which objects to two build
3018         phases producing the same file (Info.plist). Address this by removing
3019         Info.plist from the Copy Bundle Resources phase.
3020
3021         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3022
3023 2019-02-06  Keith Rollin  <krollin@apple.com>
3024
3025         Really enable the automatic checking and regenerations of .xcfilelists during builds
3026         https://bugs.webkit.org/show_bug.cgi?id=194357
3027         <rdar://problem/47861231>
3028
3029         Reviewed by Chris Dumez.
3030
3031         Bug 194124 was supposed to enable the automatic checking and
3032         regenerating of .xcfilelist files during the build. While related
3033         changes were included in that patch, the change to actually enable the
3034         operation somehow was omitted. This patch actually enables the
3035         operation. The check-xcfilelist.sh scripts now check
3036         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3037         from the checking.
3038
3039         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3040         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3041
3042 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3043
3044         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3045         <https://webkit.org/b/194286>
3046         <rdar://problem/47815558>
3047
3048         Reviewed by Alexey Proskuryakov.
3049
3050         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3051         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3052         WKRetainPtr<> to avoid leaking the WKDataRef.
3053
3054 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3055
3056         Unreviewed, fix a typo
3057
3058         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3059
3060 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3061
3062         [GTK][WPE] force libpsl build to use ICU in jhbuild
3063         https://bugs.webkit.org/show_bug.cgi?id=194288
3064
3065         Reviewed by Carlos Garcia Campos.
3066
3067         * gtk/jhbuild.modules:
3068         Require ICU for libpsl build in jhbuild, like done in WPE.
3069
3070 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3071
3072         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3073         https://bugs.webkit.org/show_bug.cgi?id=194209
3074
3075         Reviewed by Carlos Garcia Campos.
3076
3077         Enhance TestCookieManager to ensure this doesn't happen again.
3078
3079         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3080         (testCookieManagerPersistentStorage):
3081         (beforeAll):
3082
3083 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3084
3085         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3086         https://bugs.webkit.org/show_bug.cgi?id=194324
3087
3088         Reviewed by Andy Estes.
3089
3090         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3091         part of the name is already implicit, since this is in testing code in TestOptions.
3092
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::TestController::generateContextConfiguration const):
3095         (WTR::updateTestOptionsFromTestHeader):
3096         * WebKitTestRunner/TestOptions.h:
3097         (WTR::TestOptions::hasSameInitializationOptions const):
3098
3099 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3100
3101         [ews-build] Allow * as platform for builders and workers
3102         https://bugs.webkit.org/show_bug.cgi?id=188533
3103
3104         Reviewed by Lucas Forschler.
3105
3106         * BuildSlaveSupport/ews-build/loadConfig.py:
3107         (checkWorkersAndBuildersForConsistency):
3108
3109 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3110
3111         [ews-build] Add few bots to config.json
3112         https://bugs.webkit.org/show_bug.cgi?id=194304
3113
3114         Reviewed by Lucas Forschler.
3115
3116         * BuildSlaveSupport/ews-build/config.json:
3117
3118 2019-02-05  Keith Rollin  <krollin@apple.com>
3119
3120         Enable the automatic checking and regenerations of .xcfilelists during builds
3121         https://bugs.webkit.org/show_bug.cgi?id=194124
3122         <rdar://problem/47721277>
3123
3124         Reviewed by Tim Horton.
3125
3126         Bug 193790 add a facility for checking -- during build time -- that
3127         any needed .xcfilelist files are up-to-date and for updating them if
3128         they are not. This facility was initially opt-in by setting
3129         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3130         the process seemed robust. Its now time to enable this facility and
3131         make it opt-out. If there is a need to disable this facility, set and
3132         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3133         running `make` or `build-webkit`, or before running Xcode from the
3134         command line.
3135
3136         Additionally, remove the step that generates a list of source files
3137         going into the UnifiedSources build step. It's only necessarily to
3138         specify Sources.txt and SourcesCocoa.txt as inputs.
3139
3140         * Scripts/generate-xcfilelists:
3141
3142 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3143
3144         [GTK][WPE] force libpsl build to use ICU in jhbuild
3145         https://bugs.webkit.org/show_bug.cgi?id=194288
3146
3147         Reviewed by Philippe Normand.
3148
3149         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3150         This can cause build failures if libidn is detected but libunistring is not available.
3151
3152         Make sure that ICU is used for runtime and builtin PSL data.
3153
3154         * gtk/jhbuild.modules:
3155         * wpe/jhbuild.modules:
3156
3157 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-app] Modified timestamp should be updated on updating data
3160         https://bugs.webkit.org/show_bug.cgi?id=194295
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * BuildSlaveSupport/ews-app/ews/models/build.py:
3165         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3166         * BuildSlaveSupport/ews-app/ews/models/step.py:
3167
3168 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3169
3170         Unreviewed, rolling out r240742.
3171
3172         Causes crashes on iOS simulator.
3173
3174         Reverted changeset:
3175
3176         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3177         not focused in a content-editable element"
3178         https://bugs.webkit.org/show_bug.cgi?id=192824
3179         https://trac.webkit.org/changeset/240742
3180
3181 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3182
3183         run-webkit-tests emits message "...running None" when running tests
3184         https://bugs.webkit.org/show_bug.cgi?id=194133
3185         <rdar://problem/47724738>
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * Scripts/webkitpy/xcode/device_type.py:
3190         (DeviceType.__str__): Use both version mapping tables and use just the variant
3191         name if no version name is available.
3192         * Scripts/webkitpy/xcode/device_type_unittest.py:
3193         (DeviceTypeTest):
3194         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3195         an associated named.
3196
3197 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3198
3199         [WPE] require python3-setuptools for meson build in jhbuild
3200         https://bugs.webkit.org/show_bug.cgi?id=194287
3201
3202         Reviewed by Philippe Normand.
3203
3204         python3-setuptools is needed to build meson in jhbuild.
3205         It is already required by the GTK port.
3206
3207         * wpe/install-dependencies:
3208
3209 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3210
3211         [ews-app] Add method to save BuilderMapping to database
3212         https://bugs.webkit.org/show_bug.cgi?id=194264
3213
3214         Reviewed by Lucas Forschler.
3215
3216         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3217         (BuilderMapping.__str__):
3218         (BuilderMapping):
3219         (BuilderMapping.save_mapping):
3220         (BuilderMapping.update_mapping):
3221         (BuilderMapping.get_existing_mapping):
3222         (BuilderMapping.is_valid_mapping):
3223
3224 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3225
3226         [ews-app] Add timestamp fields for BuilderMappings
3227         https://bugs.webkit.org/show_bug.cgi?id=194266
3228
3229         Reviewed by Lucas Forschler.
3230
3231         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3232         (BuilderMapping):
3233
3234 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3235
3236         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3237         https://bugs.webkit.org/show_bug.cgi?id=174816
3238
3239         Reviewed by Michael Catanzaro.
3240
3241         Add tests for webkit_uri_for_display().
3242
3243         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3244         (testURIForDisplayUnaffected):
3245         (testURIForDisplayAffected):
3246         (beforeAll):
3247         (afterAll):
3248         * TestWebKitAPI/glib/CMakeLists.txt:
3249
3250 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3251
3252         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3253         https://bugs.webkit.org/show_bug.cgi?id=194158
3254         <rdar://problem/47737268>
3255
3256         Rubber-stamped by Aakash Jain.
3257
3258         * Scripts/webkitpy/port/device_port.py:
3259         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3260
3261 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3262
3263         [CG] Enable setAdditionalSupportedImageTypes for WK1
3264         https://bugs.webkit.org/show_bug.cgi?id=194190
3265
3266         Reviewed by Tim Horton.
3267
3268         Add a test similar to the one under WebKit Cocoa but make it create a
3269         WebView instead of a WKWebView.
3270
3271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3272         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3273         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3274         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3275         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3276         (TestWebKitAPI::runTest):
3277         (TestWebKitAPI::TEST):
3278
3279 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3280
3281         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3282         https://bugs.webkit.org/show_bug.cgi?id=194168
3283
3284         Reviewed by Simon Fraser.
3285
3286         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3290         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3291         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3292         (TEST):
3293         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3294         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3295
3296 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3297
3298         REGRESSION (r237269): webkit-patch what-broke is broken 
3299         https://bugs.webkit.org/show_bug.cgi?id=193025
3300
3301         Reviewed by Aakash Jain.
3302
3303         * Scripts/webkitpy/common/host.py:
3304         (Host.buildbot):
3305         (Host.bugzilla): Renamed to 'buildbot'.
3306
3307 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3308
3309         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3310         https://bugs.webkit.org/show_bug.cgi?id=194207
3311
3312         Reviewed by Tim Horton.
3313
3314         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3315         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3316         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3317         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3318         start and delete forwards to remove the original attachment.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3321         (TestWebKitAPI::TEST):
3322
3323 2019-02-04  Youenn Fablet  <youenn@apple.com>
3324
3325         Capture state should be managed consistently when doing process swapping
3326         https://bugs.webkit.org/show_bug.cgi?id=194122
3327         <rdar://problem/47609293>
3328
3329         Reviewed by Eric Carlson.
3330
3331         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3332         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3333         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3334         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3335         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3337         (WTR::TestRunner::isDoingMediaCapture const):
3338         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3339         * WebKitTestRunner/TestController.cpp:
3340         (WTR::TestController::isDoingMediaCapture const):
3341         * WebKitTestRunner/TestController.h:
3342         * WebKitTestRunner/TestInvocation.cpp:
3343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3345         (WTR::TestController::isDoingMediaCapture const):
3346
3347 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3348
3349         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3350         https://bugs.webkit.org/show_bug.cgi?id=194142
3351
3352         Reviewed by Ross Kirsling.
3353
3354         There three 'separator' variables in TestController.cpp. Renamed
3355         it 'pathSeparator', and unified them.
3356
3357         * WebKitTestRunner/TestController.cpp:
3358         (WTR::TestController::generateContextConfiguration const):
3359         (WTR::createTestURL):
3360         (WTR::TestController::platformAdjustContext):
3361
3362 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3363
3364         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3365         https://bugs.webkit.org/show_bug.cgi?id=194198
3366
3367         Reviewed by Antti Koivisto.
3368
3369         No need to set the banner heights on navigation now, since Page stores them.
3370
3371         * MiniBrowser/mac/WK2BrowserWindowController.m:
3372         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3373
3374 2019-02-03  John Wilander  <wilander@apple.com>
3375
3376         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3377         https://bugs.webkit.org/show_bug.cgi?id=194104
3378         <rdar://problem/47649991>
3379
3380         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3381
3382         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3383         (TestWebKitAPI::TEST):
3384             Changed numeric types from unsigned short to uint32_t.
3385
3386 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3387
3388         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3389         <https://webkit.org/b/194178>
3390         <rdar://problem/47753473>
3391
3392         Reviewed by Alexey Proskuryakov.
3393
3394         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3395         (WTR::uninstallFakeHelvetica): Pass nullptr into
3396         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3397
3398 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3399
3400         [LFC] Initialize ICB's style with fixed width/height.
3401         https://bugs.webkit.org/show_bug.cgi?id=194188
3402
3403         Reviewed by Antti Koivisto.
3404
3405         * LayoutReloaded/misc/LFC-passing-tests.txt:
3406
3407 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3408
3409         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3410         https://bugs.webkit.org/show_bug.cgi?id=194185
3411
3412         Reviewed by Antti Koivisto.
3413
3414         * LayoutReloaded/misc/LFC-passing-tests.txt:
3415
3416 2018-12-16  Darin Adler  <darin@apple.com>
3417
3418         Convert additional String::format clients to alternative approaches
3419         https://bugs.webkit.org/show_bug.cgi?id=192746
3420
3421         Reviewed by Alexey Proskuryakov.
3422
3423         * WebKitTestRunner/TestController.cpp:
3424         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3425         as an intermediate in code that ultimately constructs a WTF::String.
3426         (WTR::userMediaOriginHash): Use makeString.
3427         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3428         (WTR::TestController::didPerformClientRedirect): Ditto.
3429         (WTR::TestController::didPerformServerRedirect): Ditto.
3430         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3431
3432 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3433
3434         [ews-build] Add unit test to verify builder keys
3435         https://bugs.webkit.org/show_bug.cgi?id=194152
3436
3437         Reviewed by Lucas Forschler.
3438
3439         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3440         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3441
3442 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3443
3444         [LFC] Expand tests coverage (12 new tests -> 787)
3445
3446         Unreviewed test gardening.
3447
3448         * LayoutReloaded/misc/LFC-passing-tests.txt:
3449
3450 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3451
3452         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3453         https://bugs.webkit.org/show_bug.cgi?id=194163
3454
3455         Reviewed by Simon Fraser.
3456
3457         775
3458
3459         * LayoutReloaded/misc/LFC-passing-tests.txt:
3460
3461 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3462
3463         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3464         https://bugs.webkit.org/show_bug.cgi?id=194140
3465         <rdar://problem/47728098>
3466
3467         Reviewed by Tim Horton.
3468
3469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3471         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3472
3473         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3474         test to induce an IPC deadlock when presenting a modal alert during touch start.
3475
3476         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3477         * WebKitTestRunner/TestController.cpp:
3478         (WTR::runJavaScriptAlert):
3479
3480         Add a client callback function for running JavaScript alerts.
3481
3482         (WTR::TestController::createOtherPage):
3483         (WTR::TestController::generateContextConfiguration const):
3484
3485         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3486         the fix in this patch.
3487
3488         (WTR::TestController::createWebViewWithOptions):
3489
3490         Plumb TestOptions to generateContextConfiguration.
3491
3492         (WTR::TestController::resetPreferencesToConsistentValues):
3493         (WTR::TestController::resetStateToConsistentValues):
3494         (WTR::updateTestOptionsFromTestHeader):
3495         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3496         (WTR::TestController::handleJavaScriptAlert):
3497         * WebKitTestRunner/TestController.h:
3498         * WebKitTestRunner/TestInvocation.cpp:
3499         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3500         * WebKitTestRunner/TestOptions.h:
3501         (WTR::TestOptions::hasSameInitializationOptions const):
3502
3503 2019-02-01  Chris Dumez  <cdumez@apple.com>
3504
3505         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3506         https://bugs.webkit.org/show_bug.cgi?id=193740
3507         <rdar://problem/47527267>
3508
3509         Reviewed by Alex Christensen.
3510
3511         Add API test coverage.
3512
3513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3514
3515 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3516
3517         [ews-app] Add display name field to BuilderMapping model
3518         https://bugs.webkit.org/show_bug.cgi?id=194153
3519
3520         Reviewed by Lucas Forschler.
3521
3522         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3523         (BuilderMapping):
3524
3525 2019-02-01  Youenn Fablet  <youenn@apple.com>
3526
3527         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3528         https://bugs.webkit.org/show_bug.cgi?id=194155
3529
3530         Reviewed by Eric Carlson.
3531
3532         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3533         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3534         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3535
3536 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3537
3538         [LFC] Adjust replaced element's intrinsic ratio
3539         https://bugs.webkit.org/show_bug.cgi?id=194154
3540
3541         Reviewed by Antti Koivisto.
3542
3543         761
3544
3545         * LayoutReloaded/misc/LFC-passing-tests.txt:
3546
3547 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3548
3549         [WPE] Show test results in minibrowser
3550         https://bugs.webkit.org/show_bug.cgi?id=194150
3551
3552         Reviewed by Žan Doberšek.
3553
3554         * Scripts/webkitpy/port/wpe.py:
3555         (WPEPort.show_results_html_file):
3556
3557 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3558
3559         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3560         https://bugs.webkit.org/show_bug.cgi?id=194151
3561
3562         Reviewed by Žan Doberšek.
3563
3564         ALT + <- go back
3565         ALT + -> go forward
3566
3567         * MiniBrowser/wpe/main.cpp:
3568         (main):
3569
3570 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3571
3572         [LFC] Set intrinsic size on Layout::Replaced
3573         https://bugs.webkit.org/show_bug.cgi?id=194139
3574
3575         Reviewed by Antti Koivisto.
3576
3577         744
3578
3579         * LayoutReloaded/misc/LFC-passing-tests.txt:
3580
3581 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3582
3583         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3584         https://bugs.webkit.org/show_bug.cgi?id=194146
3585
3586         Reviewed by Xabier Rodriguez-Calvar.
3587
3588         It allows to open relative paths.
3589
3590         * MiniBrowser/wpe/main.cpp:
3591         (main):
3592
3593 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3594
3595         Update flakiness dashboard configuration after recent queue changes
3596         https://bugs.webkit.org/show_bug.cgi?id=194127
3597
3598         Rubber-stamped by Aakash Jain.
3599
3600         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3601
3602         * TestResultServer/static-dashboards/builders.jsonp:
3603
3604 2019-01-31  Youenn Fablet  <youenn@apple.com>
3605
3606         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3607         https://bugs.webkit.org/show_bug.cgi?id=194106
3608         <rdar://problem/47676333>
3609
3610         Reviewed by Ryosuke Niwa.
3611
3612         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3613         (TestWebKitAPI::didFinishNavigation):
3614         (TestWebKitAPI::TEST):
3615         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3616
3617 2019-01-31  Chris Dumez  <cdumez@apple.com>
3618
3619         Page zoom level is lost after a process swap or a crash
3620         https://bugs.webkit.org/show_bug.cgi?id=194105
3621         <rdar://problem/47610781>
3622
3623         Reviewed by Alex Christensen.
3624
3625         Add API test coverage.
3626
3627         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3628         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3629
3630 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3631
3632         Revert r238819 which is unneeded and caused a performance regression.
3633         https://bugs.webkit.org/show_bug.cgi?id=192272
3634         <rdar://problem/46664625>
3635
3636         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3637         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3638         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3639
3640 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3641
3642         Formalize WebKitAdditions mechanism of LoadOptimizer
3643         https://bugs.webkit.org/show_bug.cgi?id=193886
3644         <rdar://problem/47696809>
3645
3646         Reviewed by Brent Fulgham.
3647
3648         * MiniBrowser/MiniBrowser.entitlements:
3649         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3650
3651 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3652
3653         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3654         https://bugs.webkit.org/show_bug.cgi?id=194090
3655
3656         Reviewed by Antti Koivisto.
3657
3658         * LayoutReloaded/misc/LFC-passing-tests.txt:
3659
3660 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3661
3662         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3663         https://bugs.webkit.org/show_bug.cgi?id=194074
3664
3665         Reviewed by Antti Koivisto.
3666
3667         * LayoutReloaded/misc/LFC-passing-tests.txt:
3668
3669 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3670
3671         [LFC][BFC] Add support for block level replaced box.
3672         https://bugs.webkit.org/show_bug.cgi?id=194071
3673
3674         Reviewed by Antti Koivisto.
3675
3676         * LayoutReloaded/misc/LFC-passing-tests.txt:
3677
3678 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3679
3680         Fix WebKitTestRunner's testPath with Windows full paths
3681         https://bugs.webkit.org/show_bug.cgi?id=194012
3682
3683         Reviewed by Alex Christensen.
3684
3685         updateTestOptionsFromTestHeader failed to open test files because
3686         testPath returned wrong file paths. It returned a path "/C:/..."
3687         if a URL "file:///C:/..." was given.
3688
3689         * WebKitTestRunner/TestController.cpp:
3690         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3691
3692 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3693
3694         [WPE] Bump font related dependencies to match the GTK+ port
3695         https://bugs.webkit.org/show_bug.cgi?id=194017
3696
3697         Reviewed by Žan Doberšek.
3698
3699         * wpe/jhbuild.modules:
3700         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3701         * wpe/patches/icudata-stdlibs.patch: Added.
3702
3703 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3704
3705         Enable swipe tests on iOS
3706         https://bugs.webkit.org/show_bug.cgi?id=194076
3707
3708         Reviewed by Geoffrey Garen.
3709
3710         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3711         it causes a debug assertion failure in runUIScript.
3712
3713         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3714         (WTR::UIScriptController::beginBackSwipe):
3715         (WTR::UIScriptController::completeBackSwipe):
3716
3717 2019-01-30  Keith Rollin  <krollin@apple.com>
3718
3719         Use correct printf format specifier
3720         https://bugs.webkit.org/show_bug.cgi?id=194062
3721         <rdar://problem/47686167>
3722
3723         Reviewed by Alexey Proskuryakov.
3724
3725         LayoutTestSpellChecker.mm is trying to format a variable of type
3726         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3727         actually an unsigned long long. Fix this by formatting with %llu.
3728
3729         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3730         (-[LayoutTestTextCheckingResult description]):
3731
3732 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3733
3734         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3735         https://bugs.webkit.org/show_bug.cgi?id=193979
3736
3737         Reviewed by Wenson Hsieh.
3738
3739         Fix the test for iOS. Make the test work with iOS UA string.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3742
3743 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3744
3745         Replace High Sierra LLINT CLoop bot due to hardware failure
3746         https://bugs.webkit.org/show_bug.cgi?id=194066
3747
3748         Reviewed by Aakash Jain.
3749
3750         * BuildSlaveSupport/build.webkit.org-config/config.json:
3751
3752 2019-01-30  Keith Rollin  <krollin@apple.com>
3753
3754         [NSDragItem init] is unavailable
3755         https://bugs.webkit.org/show_bug.cgi?id=194059
3756         <rdar://problem/47685715>
3757
3758         Reviewed by Wenson Hsieh.
3759
3760         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3761         DumpRenderTree and TestWebKitAPI, which both try to create an
3762         NSDragItem in a manner that invokes this method. Address this by using
3763         -initWithPasteboardWriter instead.
3764
3765         Note that the parameter passed to initWithPasteboardWriter is likely
3766         incorrect. In both cases, the object passed does not conform to
3767         NSPasteboardWriting. However, with this fix, we're no worse off than
3768         before, and can now perform builds with newer compilers and SDKs until
3769         a real fix can be crafted. That work is tracked in
3770         https://bugs.webkit.org/show_bug.cgi?id=194060
3771
3772         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3773         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3774         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3775         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3776
3777 2019-01-30  Daniel Bates  <dabates@apple.com>
3778
3779         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3780         https://bugs.webkit.org/show_bug.cgi?id=192824
3781         <rdar://problem/47100332>
3782
3783         Reviewed by Wenson Hsieh.
3784
3785         Fix a bug where the wrong usage code was used for F13 thru F24.
3786
3787         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3788         (keyCodeForDOMFunctionKey):
3789
3790 2019-01-30  Chris Dumez  <cdumez@apple.com>
3791
3792         Regression(PSON) Load hang can occur on history navigation
3793         https://bugs.webkit.org/show_bug.cgi?id=194030
3794         <rdar://problem/47656939>
3795
3796         Reviewed by Antti Koivisto.
3797
3798         Add API test coverage.
3799
3800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3801
3802 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3803
3804         [LFC] Expand tests coverage.
3805
3806         Unreviewed test gardening.
3807
3808         * LayoutReloaded/misc/LFC-passing-tests.txt:
3809
3810 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3811
3812         [Flatpak] Add openjpeg support
3813         https://bugs.webkit.org/show_bug.cgi?id=194019
3814
3815         Reviewed by Michael Catanzaro.
3816
3817         * flatpak/org.webkit.CommonModules.yaml:
3818
3819 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3820
3821         Unreviewed, rolling out r240708.
3822         https://bugs.webkit.org/show_bug.cgi?id=194022
3823
3824         It broke WPE build (Requested by KaL on #webkit).
3825
3826         Reverted changeset:
3827
3828         "[WPE] Bump font related dependencies to match the GTK+ port"
3829         https://bugs.webkit.org/show_bug.cgi?id=194017
3830         https://trac.webkit.org/changeset/240708
3831
3832 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3833
3834         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3835         https://bugs.webkit.org/show_bug.cgi?id=194001
3836
3837         Reviewed by Antti Koivisto.
3838
3839         * LayoutReloaded/misc/LFC-passing-tests.txt:
3840
3841 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3842
3843         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3844         https://bugs.webkit.org/show_bug.cgi?id=194020
3845
3846         Reviewed by Antti Koivisto.
3847
3848         * LayoutReloaded/misc/LFC-passing-tests.txt:
3849
3850 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3851
3852         AX: Support color well on iOS
3853         https://bugs.webkit.org/show_bug.cgi?id=194010
3854
3855         Reviewed by Joanmarie Diggs.
3856
3857         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3858         (WTR::AccessibilityUIElement::stringAttributeValue):
3859
3860 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3861
3862         [WPE] Bump font related dependencies to match the GTK+ port
3863         https://bugs.webkit.org/show_bug.cgi?id=194017
3864
3865         Reviewed by Žan Doberšek.
3866
3867         * wpe/jhbuild.modules:
3868         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3869         * wpe/patches/icudata-stdlibs.patch: Added.
3870
3871 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3872
3873         [Mac] Update window scale API usage
3874         https://bugs.webkit.org/show_bug.cgi?id=193991
3875         rdar://problem/47614795
3876
3877         Reviewed by Tim Horton.
3878
3879         * DumpRenderTree/mac/DumpRenderTree.mm:
3880         (changeWindowScaleIfNeeded):
3881         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3882         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3883         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3884
3885 2019-01-29  Chris Dumez  <cdumez@apple.com>
3886
3887         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3888         https://bugs.webkit.org/show_bug.cgi?id=193977
3889         <rdar://problem/47643716>
3890
3891         Reviewed by Geoff Garen.
3892
3893         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3894         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3895         to the previous provisional committing *before* we make the last load. 
3896
3897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3898
3899 2019-01-29  Youenn Fablet  <youenn@apple.com>
3900
3901         Adopt new SPI to evaluate server certificate trust
3902         https://bugs.webkit.org/show_bug.cgi?id=193355
3903
3904         Reviewed by Alex Christensen.
3905
3906         Add infrastructure to handle HTTPS server trust evaluation testing.
3907
3908         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3910         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3911         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3912         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3914         * WebKitTestRunner/TestController.cpp:
3915         (WTR::TestController::resetPreferencesToConsistentValues):
3916         (WTR::TestController::didReceiveAuthenticationChallenge):
3917         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3918         * WebKitTestRunner/TestController.h:
3919         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3920         * WebKitTestRunner/TestInvocation.cpp:
3921         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3922         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3923         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3924
3925 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3926
3927         [ews-build] Add build step to print bot Configuration
3928         https://bugs.webkit.org/show_bug.cgi?id=193887
3929
3930         Reviewed by Lucas Forschler.
3931
3932         * BuildSlaveSupport/ews-build/steps.py:
3933         (PrintConfiguration): Build step to print configuration.
3934         * BuildSlaveSupport/ews-build/factories.py:
3935
3936 2019-01-29  Chris Dumez  <cdumez@apple.com>
3937
3938         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3939         https://bugs.webkit.org/show_bug.cgi?id=193967
3940         <rdar://problem/47635348>
3941
3942         Reviewed by Alex Christensen.
3943
3944         Add API test coverage.
3945
3946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3947         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3948
3949 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3950
3951         [ews-app] Handle incoming results data
3952         https://bugs.webkit.org/show_bug.cgi?id=193973
3953
3954         Reviewed by Lucas Forschler.
3955
3956         * BuildSlaveSupport/ews-app/ews/views/results.py:
3957
3958 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3959
3960         [ews-app] Make the results url generic
3961         https://bugs.webkit.org/show_bug.cgi?id=193928
3962
3963         Reviewed by Lucas Forschler.
3964
3965         * BuildSlaveSupport/ews-app/ews/urls.py:
3966
3967 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3968
3969         [ews-build] Configure buildbot to send events to ews-app
3970         https://bugs.webkit.org/show_bug.cgi?id=193968
3971
3972         Reviewed by Lucas Forschler.
3973
3974         * BuildSlaveSupport/ews-build/events.py: Added.
3975         * BuildSlaveSupport/ews-build/master.cfg:
3976
3977 2019-01-29  Keith Rollin  <krollin@apple.com>
3978
3979         Add .xcfilelists to Run Script build phases
3980         https://bugs.webkit.org/show_bug.cgi?id=193792
3981         <rdar://problem/47201785>
3982
3983         Reviewed by Alex Christensen.
3984
3985         As part of supporting XCBuild, update the necessary Run Script build
3986         phases in their Xcode projects to refer to their associated
3987         .xcfilelist files.
3988
3989         Note that the addition of these files bumps the Xcode project version
3990         number to something that's Xcode 10 compatible. This change means that
3991         older versions of the Xcode IDE can't read these projects. Nor can it
3992         fully load workspaces that refer to these projects (the updated
3993         projects are shown as non-expandable placeholders). `xcodebuild` can
3994         still build these projects; it's just that the IDE can't open them.
3995
3996         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3997         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3998
3999 2019-01-29  John Wilander  <wilander@apple.com>
4000
4001         Add data abstraction and validation for Ad Click Attribution
4002         https://bugs.webkit.org/show_bug.cgi?id=193916
4003         <rdar://problem/47603481>
4004
4005         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
4006
4007         Ad click attribution has two steps. First, the storage of an ad
4008         campaign ID for a click that takes the user to a destination
4009         site. Second, a conversion on the destination site that can be
4010         attributed to the ad click.
4011
4012         This patch adds a class that represents a request for ad click
4013         attribution. Validation makes sure that the bits of entropy
4014         reported through this mechanism is limited.
4015
4016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4017         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
4018         (TestWebKitAPI::TEST):
4019
4020 2019-01-29  Chris Dumez  <cdumez@apple.com>
4021
4022         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
4023         https://bugs.webkit.org/show_bug.cgi?id=193932
4024         <rdar://problem/47598947>
4025
4026         Reviewed by Brady Eidson.
4027
4028         Add API test coverage.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4031
4032 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4033
4034         Adding new passing LFC tests.
4035
4036         Unreviewed test gardening.
4037
4038         * LayoutReloaded/misc/LFC-passing-tests.txt:
4039
4040 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4041
4042         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4043         https://bugs.webkit.org/show_bug.cgi?id=193964
4044
4045         Reviewed by Antti Koivisto.
4046
4047         * LayoutReloaded/misc/LFC-passing-tests.txt:
4048
4049 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4050
4051         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4052         https://bugs.webkit.org/show_bug.cgi?id=193954
4053
4054         Reviewed by Antti Koivisto.
4055
4056         * LayoutReloaded/misc/LFC-passing-tests.txt:
4057
4058 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4059
4060         WebDriver: add support for running subtests
4061         https://bugs.webkit.org/show_bug.cgi?id=193904
4062
4063         Reviewed by Michael Catanzaro.
4064
4065         pytest already supports it by passing test.py::subtest, so we can do the same.
4066
4067         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4068         (get_item_name): Made this global.
4069         (CollectRecorder.__init__): Receive the parameter to ignore.
4070         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4071         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4072         (collect): Add parameter to ignore.
4073         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4074         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4075         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4076         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4077         (WebDriverTestRunnerSelenium.run): Ditto.
4078         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4079         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4080         (WebDriverTestRunnerW3C.run): Ditto.
4081
4082 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4083
4084         User agent string override for navigator.userAgent should be site specific quirks
4085         https://bugs.webkit.org/show_bug.cgi?id=193950
4086
4087         Reviewed by Brent Fulgham.
4088
4089         Updated per the _WKWebsitePolicies rename.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4092         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4093
4094 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4095
4096         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4097         https://bugs.webkit.org/show_bug.cgi?id=193941
4098
4099         Reviewed by Alex Christensen.
4100
4101         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4102         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4103         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4104         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4105         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4106         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4107         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4108         * TestWebKitAPI/Tests/WTF/Time.cpp:
4109         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4110         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4111         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4112         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4113
4114 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4115
4116         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4117
4118         * Scripts/webkitpy/common/config/contributors.json:
4119
4120 2019-01-28  Andy Estes  <aestes@apple.com>
4121
4122         [watchOS] Enable Parental Controls content filtering
4123         https://bugs.webkit.org/show_bug.cgi?id=193939
4124         <rdar://problem/46641912>
4125
4126         Reviewed by Ryosuke Niwa.
4127
4128         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4129
4130 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4131
4132         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4133         <https://webkit.org/b/193884>
4134
4135         Reviewed by Jiewen Tan.
4136
4137         * Scripts/webkitpy/style/checkers/cpp.py:
4138         (check_language): Add LocalAuthentication to
4139         `frameworks_with_soft_links`.
4140
4141 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4142
4143         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4144         https://bugs.webkit.org/show_bug.cgi?id=193891
4145
4146         Reviewed by Ross Kirsling.
4147
4148         There were three problems in window sizes of WebView and the host window.
4149         1. The sizes of pixel image output were incorrect.
4150         2. The host window is going to appear after window.resize was invoked.
4151         3. window.resize resized only the host window, not WebView.
4152
4153         This change solves them with a following approach.
4154         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4155         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4156            as well as DumpRenderTree in order to match the client area and the window area.
4157         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4158         d. PlatformWebView::setWindowFrame changes both window sizes.
4159         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4160
4161         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4162         (WTR::PlatformWebView::PlatformWebView): Create the host window
4163         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4164         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4165         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4166
4167 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4168
4169         [ews-app] Add method to save Step data to database
4170         https://bugs.webkit.org/show_bug.cgi?id=193890
4171
4172         Reviewed by Lucas Forschler.
4173
4174         * BuildSlaveSupport/ews-app/ews/models/step.py:
4175         (Step.save_step): Method to save step data.
4176         (Step.update_step): Method to update step data.
4177         (Step.get_existing_step): Method to fetch existing step from database.
4178         (Step.is_valid_result): Method to validate valid step result.
4179
4180 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4181
4182         [ews-app] Add method to save Build data to database
4183         https://bugs.webkit.org/show_bug.cgi?id=193735
4184
4185         Reviewed by Lucas Forschler.
4186
4187         * BuildSlaveSupport/ews-app/ews/models/build.py:
4188         (Build.save_build): Method to save build information to database.
4189         (Build.get_existing_build): Method to fetch existing build from database.
4190         (Build.is_valid_result): Method to validate build result.
4191         * BuildSlaveSupport/ews-app/ews/common/util.py:
4192         (is_valid_int_id): Method to validate valid id.
4193
4194 2019-01-28  Chris Dumez  <cdumez@apple.com>
4195
4196         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4197         https://bugs.webkit.org/show_bug.cgi?id=193915
4198         <rdar://problem/47560907>
4199
4200         Reviewed by Alex Christensen.
4201
4202         Add API test coverage.
4203
4204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4205
4206 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4207
4208         [ews-app] Rename id variables
4209         https://bugs.webkit.org/show_bug.cgi?id=193883
4210
4211         Reviewed by Lucas Forschler.
4212
4213         * BuildSlaveSupport/ews-app/ews/models/build.py:
4214         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4215         * BuildSlaveSupport/ews-app/ews/models/step.py:
4216         * BuildSlaveSupport/ews-app/ews/urls.py:
4217         * BuildSlaveSupport/ews-app/ews/views/patch.py:
4218         * BuildSlaveSupport/ews-app/ews/views/results.py:
4219         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4220
4221 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4222
4223         [ews-app] Allow certain fields to be empty
4224         https://bugs.webkit.org/show_bug.cgi?id=193892
4225
4226         Reviewed by Lucas Forschler.
4227
4228         * BuildSlaveSupport/ews-app/ews/models/build.py:
4229         * BuildSlaveSupport/ews-app/ews/models/step.py:
4230
4231 2019-01-28  Rob Buis  <rbuis@igalia.com>
4232
4233         Update MIME type parser
4234         https://bugs.webkit.org/show_bug.cgi?id=180526
4235
4236         Reviewed by Frédéric Wang.
4237
4238         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4239         (TestWebKitAPI::TEST):
4240
4241 2019-01-28  Zalan Bujtas  <zalan@apple.com>
4242
4243         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
4244         https://bugs.webkit.org/show_bug.cgi?id=193896
4245
4246         Reviewed by Antti Koivisto.
4247
4248         * LayoutReloaded/misc/LFC-passing-tests.txt:
4249
4250 2018-12-15  Darin Adler  <darin@apple.com>
4251
4252         Replace many uses of String::format with more type-safe alternatives
4253         https://bugs.webkit.org/show_bug.cgi?id=192742
4254
4255         Reviewed by Mark Lam.
4256
4257         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4258         (WTR::cacheTestRunnerCallback): Use makeString.
4259         * WebKitTestRunner/TestController.cpp:
4260         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4261         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4262
4263 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
4264
4265         Use a load optimizer for some sites
4266         https://bugs.webkit.org/show_bug.cgi?id=193881
4267         <rdar://problem/46325455>
4268
4269         Reviewed by Brent Fulgham.
4270
4271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4272         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
4273
4274 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
4275
4276         AX: Introduce a static accessibility tree
4277         https://bugs.webkit.org/show_bug.cgi?id=193348
4278         <rdar://problem/47203295>
4279
4280         Reviewed by Ryosuke Niwa.
4281
4282         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4283
4284 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4285
4286         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
4287         https://bugs.webkit.org/show_bug.cgi?id=193867
4288
4289         Reviewed by Antti Koivisto.
4290
4291         * LayoutReloaded/misc/LFC-passing-tests.txt:
4292
4293 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4294
4295         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
4296         https://bugs.webkit.org/show_bug.cgi?id=193865
4297
4298         Reviewed by Antti Koivisto.
4299
4300         * LayoutReloaded/misc/LFC-passing-tests.txt:
4301
4302 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4303
4304         Need a mechanism to override navigator.userAgent
4305         https://bugs.webkit.org/show_bug.cgi?id=193762
4306         <rdar://problem/47504939>
4307
4308         Reviewed by Brent Fulgham.
4309
4310         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
4311
4312         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4313         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4314         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4315
4316 2019-01-25  Dean Jackson  <dino@apple.com>
4317
4318         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4319         https://bugs.webkit.org/show_bug.cgi?id=193831
4320         <rdar://problem/47399263>
4321
4322         Reviewed by Chris Dumez.
4323
4324         Two new tests that exercise cross-origin and same-origin System
4325         Previews.
4326
4327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4328
4329 2019-01-25  Keith Rollin  <krollin@apple.com>
4330
4331         Update Xcode projects with "Check .xcfilelists" build phase
4332         https://bugs.webkit.org/show_bug.cgi?id=193790
4333         <rdar://problem/47201374>
4334
4335         Reviewed by Alex Christensen.
4336
4337         Support for XCBuild includes specifying inputs and outputs to various
4338         Run Script build phases. These inputs and outputs are specified as
4339         .xcfilelist files. Once created, these .xcfilelist files need to be
4340         kept up-to-date. In order to check that they are up-to-date or not,
4341         add an Xcode build step that invokes an external script that performs
4342         the checking. If the .xcfilelists are found to be out-of-date, update
4343         them, halt the build, and instruct the developer to restart the build
4344         with up-to-date files.
4345
4346         At this time, the checking and regenerating is performed only if the
4347         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4348         who want to use this facility can set this variable and test out the
4349         checking/regenerating. Once it seems like there are no egregious
4350         issues that upset a developer's workflow, we'll unconditionally enable
4351         this facility.
4352
4353         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4354         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4355         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4356         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4357
4358 2019-01-25  Keith Rollin  <krollin@apple.com>
4359
4360         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4361         https://bugs.webkit.org/show_bug.cgi?id=193781
4362         <rdar://problem/47201153>
4363
4364         Reviewed by Alex Christensen.
4365
4366         Part of generating the .xcfilelists used as part of adopting XCBuild
4367         includes running `make DerivedSources.make` from a standalone script.
4368         It’s important for this invocation to have the same environment as
4369         when the actual build invokes `make DerivedSources.make`. If the
4370         environments are different, then the two invocations will provide
4371         different results. In order to get the same environment in the
4372         standalone script, have the script launch xcodebuild targeting the
4373         "Apply Configuration to XCFileLists" build target, which will then
4374         re-invoke our standalone script. The script is now running again, this
4375         time in an environment with all workspace, project, target, xcconfig
4376         and other environment variables established.
4377
4378         The "Apply Configuration to XCFileLists" build target accomplishes
4379         this task via a small embedded shell