[watchOS] Enable Parental Controls content filtering
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Andy Estes  <aestes@apple.com>
2
3         [watchOS] Enable Parental Controls content filtering
4         https://bugs.webkit.org/show_bug.cgi?id=193939
5         <rdar://problem/46641912>
6
7         Reviewed by Ryosuke Niwa.
8
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2019-01-28  David Kilzer  <ddkilzer@apple.com>
12
13         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
14         <https://webkit.org/b/193884>
15
16         Reviewed by Jiewen Tan.
17
18         * Scripts/webkitpy/style/checkers/cpp.py:
19         (check_language): Add LocalAuthentication to
20         `frameworks_with_soft_links`.
21
22 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
23
24         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
25         https://bugs.webkit.org/show_bug.cgi?id=193891
26
27         Reviewed by Ross Kirsling.
28
29         There were three problems in window sizes of WebView and the host window.
30         1. The sizes of pixel image output were incorrect.
31         2. The host window is going to appear after window.resize was invoked.
32         3. window.resize resized only the host window, not WebView.
33
34         This change solves them with a following approach.
35         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
36         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
37            as well as DumpRenderTree in order to match the client area and the window area.
38         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
39         d. PlatformWebView::setWindowFrame changes both window sizes.
40         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
41
42         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
43         (WTR::PlatformWebView::PlatformWebView): Create the host window
44         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
45         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
46         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
47
48 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
49
50         [ews-app] Add method to save Step data to database
51         https://bugs.webkit.org/show_bug.cgi?id=193890
52
53         Reviewed by Lucas Forschler.
54
55         * BuildSlaveSupport/ews-app/ews/models/step.py:
56         (Step.save_step): Method to save step data.
57         (Step.update_step): Method to update step data.
58         (Step.get_existing_step): Method to fetch existing step from database.
59         (Step.is_valid_result): Method to validate valid step result.
60
61 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
62
63         [ews-app] Add method to save Build data to database
64         https://bugs.webkit.org/show_bug.cgi?id=193735
65
66         Reviewed by Lucas Forschler.
67
68         * BuildSlaveSupport/ews-app/ews/models/build.py:
69         (Build.save_build): Method to save build information to database.
70         (Build.get_existing_build): Method to fetch existing build from database.
71         (Build.is_valid_result): Method to validate build result.
72         * BuildSlaveSupport/ews-app/ews/common/util.py:
73         (is_valid_int_id): Method to validate valid id.
74
75 2019-01-28  Chris Dumez  <cdumez@apple.com>
76
77         Regression(PSON) Crash under WebPageProxy::didStartProgress()
78         https://bugs.webkit.org/show_bug.cgi?id=193915
79         <rdar://problem/47560907>
80
81         Reviewed by Alex Christensen.
82
83         Add API test coverage.
84
85         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
86
87 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
88
89         [ews-app] Rename id variables
90         https://bugs.webkit.org/show_bug.cgi?id=193883
91
92         Reviewed by Lucas Forschler.
93
94         * BuildSlaveSupport/ews-app/ews/models/build.py:
95         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
96         * BuildSlaveSupport/ews-app/ews/models/step.py:
97         * BuildSlaveSupport/ews-app/ews/urls.py:
98         * BuildSlaveSupport/ews-app/ews/views/patch.py:
99         * BuildSlaveSupport/ews-app/ews/views/results.py:
100         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
101
102 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
103
104         [ews-app] Allow certain fields to be empty
105         https://bugs.webkit.org/show_bug.cgi?id=193892
106
107         Reviewed by Lucas Forschler.
108
109         * BuildSlaveSupport/ews-app/ews/models/build.py:
110         * BuildSlaveSupport/ews-app/ews/models/step.py:
111
112 2019-01-28  Rob Buis  <rbuis@igalia.com>
113
114         Update MIME type parser
115         https://bugs.webkit.org/show_bug.cgi?id=180526
116
117         Reviewed by Frédéric Wang.
118
119         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
120         (TestWebKitAPI::TEST):
121
122 2019-01-28  Zalan Bujtas  <zalan@apple.com>
123
124         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
125         https://bugs.webkit.org/show_bug.cgi?id=193896
126
127         Reviewed by Antti Koivisto.
128
129         * LayoutReloaded/misc/LFC-passing-tests.txt:
130
131 2018-12-15  Darin Adler  <darin@apple.com>
132
133         Replace many uses of String::format with more type-safe alternatives
134         https://bugs.webkit.org/show_bug.cgi?id=192742
135
136         Reviewed by Mark Lam.
137
138         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
139         (WTR::cacheTestRunnerCallback): Use makeString.
140         * WebKitTestRunner/TestController.cpp:
141         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
142         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
143
144 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
145
146         Use a load optimizer for some sites
147         https://bugs.webkit.org/show_bug.cgi?id=193881
148         <rdar://problem/46325455>
149
150         Reviewed by Brent Fulgham.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
154
155 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
156
157         AX: Introduce a static accessibility tree
158         https://bugs.webkit.org/show_bug.cgi?id=193348
159         <rdar://problem/47203295>
160
161         Reviewed by Ryosuke Niwa.
162
163         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
164
165 2019-01-26  Zalan Bujtas  <zalan@apple.com>
166
167         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
168         https://bugs.webkit.org/show_bug.cgi?id=193867
169
170         Reviewed by Antti Koivisto.
171
172         * LayoutReloaded/misc/LFC-passing-tests.txt:
173
174 2019-01-26  Zalan Bujtas  <zalan@apple.com>
175
176         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
177         https://bugs.webkit.org/show_bug.cgi?id=193865
178
179         Reviewed by Antti Koivisto.
180
181         * LayoutReloaded/misc/LFC-passing-tests.txt:
182
183 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
184
185         Need a mechanism to override navigator.userAgent
186         https://bugs.webkit.org/show_bug.cgi?id=193762
187         <rdar://problem/47504939>
188
189         Reviewed by Brent Fulgham.
190
191         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
194         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
195         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
196
197 2019-01-25  Dean Jackson  <dino@apple.com>
198
199         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
200         https://bugs.webkit.org/show_bug.cgi?id=193831
201         <rdar://problem/47399263>
202
203         Reviewed by Chris Dumez.
204
205         Two new tests that exercise cross-origin and same-origin System
206         Previews.
207
208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
209
210 2019-01-25  Keith Rollin  <krollin@apple.com>
211
212         Update Xcode projects with "Check .xcfilelists" build phase
213         https://bugs.webkit.org/show_bug.cgi?id=193790
214         <rdar://problem/47201374>
215
216         Reviewed by Alex Christensen.
217
218         Support for XCBuild includes specifying inputs and outputs to various
219         Run Script build phases. These inputs and outputs are specified as
220         .xcfilelist files. Once created, these .xcfilelist files need to be
221         kept up-to-date. In order to check that they are up-to-date or not,
222         add an Xcode build step that invokes an external script that performs
223         the checking. If the .xcfilelists are found to be out-of-date, update
224         them, halt the build, and instruct the developer to restart the build
225         with up-to-date files.
226
227         At this time, the checking and regenerating is performed only if the
228         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
229         who want to use this facility can set this variable and test out the
230         checking/regenerating. Once it seems like there are no egregious
231         issues that upset a developer's workflow, we'll unconditionally enable
232         this facility.
233
234         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
235         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
236         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
237         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
238
239 2019-01-25  Keith Rollin  <krollin@apple.com>
240
241         Update Xcode projects with "Apply Configuration to XCFileLists" build target
242         https://bugs.webkit.org/show_bug.cgi?id=193781
243         <rdar://problem/47201153>
244
245         Reviewed by Alex Christensen.
246
247         Part of generating the .xcfilelists used as part of adopting XCBuild
248         includes running `make DerivedSources.make` from a standalone script.
249         It’s important for this invocation to have the same environment as
250         when the actual build invokes `make DerivedSources.make`. If the
251         environments are different, then the two invocations will provide
252         different results. In order to get the same environment in the
253         standalone script, have the script launch xcodebuild targeting the
254         "Apply Configuration to XCFileLists" build target, which will then
255         re-invoke our standalone script. The script is now running again, this
256         time in an environment with all workspace, project, target, xcconfig
257         and other environment variables established.
258
259         The "Apply Configuration to XCFileLists" build target accomplishes
260         this task via a small embedded shell script that consists only of:
261
262             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
263
264         The process that invokes "Apply Configuration to XCFileLists" first
265         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
266         evaluated and exports it into the shell environment. When xcodebuild
267         is invoked, it inherits the value of this variable and can `eval` the
268         contents of that variable. Our external standalone script can then set
269         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
270         of command-line parameters needed to restart itself in the appropriate
271         state.
272
273         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
274         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
275
276 2019-01-25  Alex Christensen  <achristensen@webkit.org>
277
278         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
279         https://bugs.webkit.org/show_bug.cgi?id=193802
280         <rdar://problem/46010580>
281
282         Reviewed by Andy Estes.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
285         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
286         (TEST):
287
288 2019-01-25  Daniel Bates  <dabates@apple.com>
289
290         [iOS] uiController.keyDown() does not translate Control modified key
291         https://bugs.webkit.org/show_bug.cgi?id=192898
292
293         Reviewed by Wenson Hsieh.
294
295         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
296         key translation, as applicable. Among other cases, key translation occurs when performing
297         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
298         also makes the behavior of uiController.keyDown() more closely match the behavior of a
299         human pressing down and releasing key(s) using a hardware keyboard.
300
301         * WebKitTestRunner/ios/HIDEventGenerator.h:
302         * WebKitTestRunner/ios/HIDEventGenerator.mm:
303         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
304
305         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
306         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
307         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
308         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
309         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
310         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
311         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
312         (-[HIDEventGenerator longPress:completionBlock:]):
313         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
314         Update code for above renaming.
315
316         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
317         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
318
319         (-[HIDEventGenerator keyDown:]): Added.
320         (-[HIDEventGenerator keyUp:]): Added.
321         (-[HIDEventGenerator keyPress:completionBlock:]):
322         (-[HIDEventGenerator eventDispatchThreadEntry:]):
323         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
324         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
325         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
326         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
327         (WTR::parseModifier): Deleted.
328
329 2019-01-25  Keith Rollin  <krollin@apple.com>
330
331         Complete the implementation of generate-xcfilelists
332         https://bugs.webkit.org/show_bug.cgi?id=193782
333
334         Reviewed by Alex Christensen.
335
336         A preliminary version of generate-xcfilelists was added in r238008.
337         This patch updates that script in order to:
338
339         - Support checking of .xcfilelists
340         - Perform better execution of `make DerivedSources.make` by
341           relaunching generate-xcfilelists under xcodebuild
342         - Support incremental generation and checking of .xcfilelists
343         - Support supplementary .xcfilelists files from WebKitAdditions
344         - Support being wrapped by parallel version of generate-xcfilelists in
345           Internal that adds support for (re)generating WebKit projects in
346           that repo.
347         - Support builds that have been performed in WebKitBuild as well as
348           ~/Library/Developer/code/DerivedData
349         - Increase robustness and debugging facilities.
350
351         * Scripts/generate-xcfilelists:
352
353 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
354
355         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
356         https://bugs.webkit.org/show_bug.cgi?id=193297
357         <rdar://problem/47158841>
358
359         Unreviewed test case fix.
360
361         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
362         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
365         (TEST):
366
367 2019-01-25  Keith Rollin  <krollin@apple.com>
368
369         Update existing .xcfilelists
370         https://bugs.webkit.org/show_bug.cgi?id=193791
371         <rdar://problem/47201706>
372
373         Reviewed by Alex Christensen.
374
375         Many .xcfilelist files were added in r238824 in order to support
376         XCBuild. Update these with recent changes to the set of build files
377         and with the current generate-xcfilelist script.
378
379         * DumpRenderTree/DerivedSources-input.xcfilelist:
380         * DumpRenderTree/DerivedSources-output.xcfilelist:
381         * WebKitTestRunner/DerivedSources-input.xcfilelist:
382         * WebKitTestRunner/DerivedSources-output.xcfilelist:
383
384 2019-01-25  Keith Rollin  <krollin@apple.com>
385
386         Fix missing dependencies in extract-dependencies-from-makefile
387         https://bugs.webkit.org/show_bug.cgi?id=193783
388         <rdar://problem/47201571>
389
390         Reviewed by Alex Christensen.
391
392         The extract-dependencies-from-makefile script generates .xcfilelists
393         for XCBuild by invoking a makefile in --debug mode, parsing the
394         dependency information in the output, and extracting information
395         regarding targets and dependents. However, the way `make` emits this
396         dependency information is not rigorous, and so we need to determine
397         what lines to look for and parse by trial and error. This approach
398         didn't coriginally atch all the information we needed to collect, so
399         update the script to look for the additional lines we now know to look
400         for.
401
402         * Scripts/extract-dependencies-from-makefile:
403         (Parser):
404         (Parser.addTarget):
405         (Parser.addPrereq):
406         (Parser.doParse):
407
408 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
409
410         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
411         https://bugs.webkit.org/show_bug.cgi?id=193297
412         <rdar://problem/47158841>
413
414         Reviewed by Alex Christensen.
415
416         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
417             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
418         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
419         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
420         activating the message used to trigger the callback when it is set.
421
422 2019-01-25  Alex Christensen  <achristensen@webkit.org>
423
424         WKWebView.goBack should reload if there is a safe browsing warning
425         https://bugs.webkit.org/show_bug.cgi?id=193805
426         <rdar://problem/46908216>
427
428         Reviewed by Geoff Garen.
429
430         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
431         (+[Simple3LookupContext sharedLookupContext]):
432         (-[Simple3LookupContext lookUpURL:completionHandler:]):
433         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
434         (TEST):
435
436 2019-01-25  Chris Dumez  <cdumez@apple.com>
437
438         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
439         https://bugs.webkit.org/show_bug.cgi?id=193788
440         <rdar://problem/47531231>
441
442         Reviewed by Alex Christensen.
443
444         Add API test coverage.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
447         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
448
449 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
450
451         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
452         https://bugs.webkit.org/show_bug.cgi?id=193771
453
454         Unreviewed infrastructure fix.
455
456         * Scripts/webkitpy/port/darwin.py:
457         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
458
459 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
460
461         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
462
463 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
464
465         Add contributors.json entries for Ling Ho and for a new bot watchers group.
466
467         * Scripts/webkitpy/common/config/contributors.json:
468
469 2019-01-25  Chris Dumez  <cdumez@apple.com>
470
471         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
472         https://bugs.webkit.org/show_bug.cgi?id=193779
473         <rdar://problem/46170903>
474
475         Reviewed by Antti Koivisto.
476
477         Add API test that quickly navigates forward to a previous process without waiting for it to
478         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
479         the process' previous page when reconnecting the it for the forward navigation.
480
481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
482
483 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
484
485         Need a way for JavaScript (or bundle) code to participate in undo
486         https://bugs.webkit.org/show_bug.cgi?id=190009
487         <rdar://problem/44807048>
488
489         Reviewed by Ryosuke Niwa.
490
491         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
492         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
493
494         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
495         (WTR::UIScriptController::lastUndoLabel const):
496         (WTR::UIScriptController::firstRedoLabel const):
497         (WTR::UIScriptController::platformUndoManager const):
498         * DumpRenderTree/mac/UIScriptControllerMac.mm:
499         (WTR::UIScriptController::lastUndoLabel const):
500         (WTR::UIScriptController::firstRedoLabel const):
501         (WTR::UIScriptController::platformUndoManager const):
502         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
503         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
504         (WTR::UIScriptController::lastUndoLabel const):
505         (WTR::UIScriptController::firstRedoLabel const):
506         * TestRunnerShared/UIScriptContext/UIScriptController.h:
507         * WebKitTestRunner/UIScriptControllerCocoa.mm:
508         (WTR::UIScriptController::lastUndoLabel const):
509         (WTR::UIScriptController::firstRedoLabel const):
510         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
511         (WTR::UIScriptController::platformUndoManager const):
512         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
513         (WTR::UIScriptController::platformUndoManager const):
514
515 2019-01-25  Zalan Bujtas  <zalan@apple.com>
516
517         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
518         https://bugs.webkit.org/show_bug.cgi?id=193824
519
520         Reviewed by Antti Koivisto.
521
522         * LayoutReloaded/misc/LFC-passing-tests.txt:
523
524 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
525
526         Update macOS JSC bot configurations
527         https://bugs.webkit.org/show_bug.cgi?id=193739
528
529         Reviewed by Alexey Proskuryakov.
530
531         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
533         (BubbleQueueServer): Move JSC EWS to Mojave section.
534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
535         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
536         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
537
538 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
539
540         [Win][WebKitTestRunner] Implement EventSenderProxy
541         https://bugs.webkit.org/show_bug.cgi?id=193755
542
543         Reviewed by Don Olmstead.
544
545         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
546         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
547         (WTR::EventSenderProxy::dispatchMessage):
548         (WTR::EventSenderProxy::EventSenderProxy):
549         (WTR::EventSenderProxy::mouseDown):
550         (WTR::EventSenderProxy::mouseUp):
551         (WTR::EventSenderProxy::mouseMoveTo):
552         (WTR::EventSenderProxy::mouseScrollBy):
553         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
554
555 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
556
557         Unreviewed fix for API test failure after r240437.
558
559         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
560
561         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
562
563 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
564
565         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
566         https://bugs.webkit.org/show_bug.cgi?id=193787
567         <rdar://problem/47497634>
568
569         Reviewed by Alexey Proskuryakov.
570
571         * Scripts/webkitdirs.pm:
572         (iosSimulatorApplicationsPath): Pick from available runtime directories.
573
574 2019-01-24  Truitt Savell  <tsavell@apple.com>
575
576         Unreviewed, rolling out r240446.
577
578         Casued 5 API failures
579
580         Reverted changeset:
581
582         "Activate the WebResourceLoadStatisticsStore in the
583         NetworkProcess and deactivate it in the UIProcess."
584         https://bugs.webkit.org/show_bug.cgi?id=193297
585         https://trac.webkit.org/changeset/240446
586
587 2019-01-24  Zalan Bujtas  <zalan@apple.com>
588
589         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
590         https://bugs.webkit.org/show_bug.cgi?id=193741
591         <rdar://problem/47135030>
592
593         Reviewed by Antti Koivisto and Simon Fraser.
594
595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
596         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
597         (TestWebKitAPI::TEST):
598
599 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
600
601         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
602         https://bugs.webkit.org/show_bug.cgi?id=193297
603         <rdar://problem/47158841>
604
605         Reviewed by Alex Christensen.
606
607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
608         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
609         activating the message used to trigger the callback when it is set.
610
611 2019-01-24  John Wilander  <wilander@apple.com>
612
613         Add Ad Click Attribution as an internal/experimental feature
614         https://bugs.webkit.org/show_bug.cgi?id=193685
615         <rdar://problem/47450399>
616
617         Reviewed by Brent Fulgham.
618
619         Added test option adClickAttributionEnabled.
620
621         * DumpRenderTree/TestOptions.cpp:
622         (TestOptions::TestOptions):
623         * DumpRenderTree/TestOptions.h:
624         * DumpRenderTree/mac/DumpRenderTree.mm:
625         (setWebPreferencesForTestOptions):
626
627 2019-01-24  Antti Koivisto  <antti@apple.com>
628
629         [PSON] Flash on back navigation on Mac
630         https://bugs.webkit.org/show_bug.cgi?id=193716
631         <rdar://problem/47148458>
632
633         Reviewed by Chris Dumez.
634
635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
636
637         Closing of the previous page is delayed so waiting for didFinishNavigation is
638         not sufficient to guarantee we have received all the messages. Wait for them.
639
640 2019-01-24  Chris Dumez  <cdumez@apple.com>
641
642         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
643         https://bugs.webkit.org/show_bug.cgi?id=193761
644         <rdar://problem/47456405>
645
646         Reviewed by Alex Christensen.
647
648         Add API test coverage.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
653
654         webkitpy: Missing PID in crashlog name should not be fatal
655         https://bugs.webkit.org/show_bug.cgi?id=193771
656
657         If we can't determine the PID of a crashlog, just ignore the crashlog instead
658         of raising an exception.
659
660         Reviewed by Lucas Forschler.
661
662         * Scripts/webkitpy/port/darwin.py:
663         (DarwinPort._merge_crash_logs):
664
665 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
666
667         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
668         https://bugs.webkit.org/show_bug.cgi?id=193746
669
670         Reviewed by Youenn Fablet.
671
672         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
673         so we'd best just not call it.
674
675         * Scripts/webkitpy/w3c/test_exporter.py:
676         (WebPlatformTestExporter.create_branch_with_patch):
677
678 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
679
680         Move FileSystem to WTF
681         https://bugs.webkit.org/show_bug.cgi?id=193602
682
683         Reviewed by Yusuke Suzuki.
684
685         * DumpRenderTree/win/DumpRenderTree.cpp:
686         * TestWebKitAPI/CMakeLists.txt:
687         * TestWebKitAPI/PlatformGTK.cmake:
688         * TestWebKitAPI/PlatformJSCOnly.cmake:
689         * TestWebKitAPI/PlatformPlayStation.cmake:
690         * TestWebKitAPI/PlatformWPE.cmake:
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
693         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
694         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
695         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
696         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
697         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
698         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
699         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
700         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
701
702 2019-01-24  Philippe Normand  <pnormand@igalia.com>
703
704         [WPE] Remove hard dependency on subprocess32 for the API tests
705
706         Rubber-stamped by Carlos Garcia Campos.
707
708         * glib/api_test_runner.py:
709         (TestRunner._run_test_qt): Lazily import subprocess32 and check
710         its presence only when running WPEQt tests.
711
712 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
713
714         [GLIB] Expose JavaScriptCore options in GLib public API
715         https://bugs.webkit.org/show_bug.cgi?id=188742
716
717         Reviewed by Michael Catanzaro.
718
719         Add a test for the new API.
720
721         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
722         (testsJSCOptions):
723         (main):
724
725 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
726
727         [GTK][WPE] Support JPEG 2000 images
728         https://bugs.webkit.org/show_bug.cgi?id=186272
729
730         Reviewed by Žan Doberšek.
731
732         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
733
734         * gtk/jhbuild.modules:
735         * wpe/jhbuild.modules:
736
737 2019-01-23  David Kilzer  <ddkilzer@apple.com>
738
739         check-webkit-style should warn when using soft-linking macros in a header
740         <https://webkit.org/b/193750>
741
742         Reviewed by Darin Adler.
743
744         * Scripts/webkitpy/style/checkers/cpp.py:
745         (check_language): Add softlink/header check by refactoring the
746         softlink/framework check.
747         (CppChecker): Enable softlink/header check by default.
748         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
749         (CppStyleTest.test_softlink_framework): Rename from
750         CppStyleTest.test_softlink() and change test framework name in
751         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
752         files. Set file_name for macros that only appear in headers.
753         (CppStyleTest.test_softlink_header): Add tests for using
754         soft-link macros in headers.
755
756 2019-01-23  Chris Dumez  <cdumez@apple.com>
757
758         Deprecate API to limit the maximum number of WebProcesses
759         https://bugs.webkit.org/show_bug.cgi?id=193725
760         <rdar://problem/47464879>
761
762         Reviewed by Geoff Garen.
763
764         Update existing API tests to stop using deprecated API.
765
766         * MiniBrowser/mac/AppDelegate.m:
767         (defaultConfiguration):
768         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
769         (TestWebKitAPI::TEST):
770         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
771         (TestWebKitAPI::TEST):
772         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
773         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
774         (TEST):
775         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
776         (TEST):
777
778 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
779
780         [ews-app] Rename ews model buildermappings to buildermapping
781         https://bugs.webkit.org/show_bug.cgi?id=193729
782
783         Reviewed by Lucas Forschler.
784
785         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
786         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
787         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
788
789 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
790
791         [ews-app] Rename ews model steps to step
792         https://bugs.webkit.org/show_bug.cgi?id=193697
793
794         Reviewed by Lucas Forschler.
795
796         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
797         (Step): Renamed Steps to Step.
798
799 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
800
801         Clean up IndexedDB files between tests
802         https://bugs.webkit.org/show_bug.cgi?id=192796
803         <rdar://problem/46824999>
804
805         Reviewed by Geoffrey Garen.
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (runTest):
809         * WebKitTestRunner/TestController.cpp:
810         (WTR::TestController::resetStateToConsistentValues):
811         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
812         (WTR::RemoveAllIndexedDatabasesCallback):
813         (WTR::TestController::ClearIndexedDatabases):
814         * WebKitTestRunner/TestController.h:
815         * WebKitTestRunner/TestInvocation.cpp:
816         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
817
818 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
819
820         [ews-app] Rename ews model Builds to Build
821         https://bugs.webkit.org/show_bug.cgi?id=193695
822
823         Reviewed by Lucas Forschler.
824
825         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
826         (Build): Renamed Builds to Build.
827
828 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
829
830         webkitpy: Wait longer when launching WebKitTestRunner
831         https://bugs.webkit.org/show_bug.cgi?id=193734
832
833         Reviewed by Aakash Jain.
834
835         * Scripts/webkitpy/port/simulator_process.py:
836         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
837
838 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
839
840         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
841         https://bugs.webkit.org/show_bug.cgi?id=193182
842         <rdar://problem/47452154>
843
844         Reviewed by Tim Horton.
845
846         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
847         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
848         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
849
850         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
851         preventing later tests from recognizing gestures.
852
853         * WebKitTestRunner/ios/TestControllerIOS.mm:
854         (WTR::TestController::platformResetStateToConsistentValues):
855
856         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
857
858 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
859
860         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
861         https://bugs.webkit.org/show_bug.cgi?id=193722
862         <rdar://problem/47481475>
863
864         Reviewed by Lucas Forschler.
865
866         iPhone and iPad ports should both use the iOS config.
867
868         * Scripts/webkitpy/port/ios_simulator.py:
869         (IPhoneSimulatorPort.__init__):
870         (IPadSimulatorPort.__init__):
871
872 2019-01-23  Rob Buis  <rbuis@igalia.com>
873
874         Update MIME type parser
875         https://bugs.webkit.org/show_bug.cgi?id=180526
876
877         Reviewed by Frédéric Wang.
878
879         Add unit tests for both parse modes of ParsedContentType.
880
881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
882         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
883         (TestWebKitAPI::TEST):
884
885 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
886
887         [ews-app] fetch loop should not stop on network issues
888         https://bugs.webkit.org/show_bug.cgi?id=193666
889
890         Reviewed by Lucas Forschler.
891
892         * BuildSlaveSupport/ews-app/ews/fetcher.py:
893         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
894
895 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
896
897         [iOS] Multiple WKWebViewAutofillTests are flaky failures
898         https://bugs.webkit.org/show_bug.cgi?id=189165
899         <rdar://problem/47433765>
900
901         Reviewed by Tim Horton.
902
903         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
904         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
905         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
906         process in sufficient to ensure that any previous action that blurred the focused element in the web process
907         would make its way to the UI process by the time the layer tree commit is finished.
908
909         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
910         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
911         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
912         will fail because it asks for -_autofillContext too early.
913
914         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
915         is handled in the UI process.
916
917         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
918
919         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
920         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
921         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
922         input session.
923
924         (-[AutofillTestView textInputHasAutofillContext]):
925
926         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
927
928         * TestWebKitAPI/cocoa/TestWKWebView.h:
929         * TestWebKitAPI/cocoa/TestWKWebView.mm:
930         (nextInputSessionChangeCount):
931
932         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
933         This includes changing the focused element from one to another.
934
935         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
936         (-[TestWKWebView didStartFormControlInteraction]):
937         (-[TestWKWebView didEndFormControlInteraction]):
938         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
939
940         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
941         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
942         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
943         that doesn't require an input session to one that doesn't.
944
945 2019-01-22  David Kilzer  <ddkilzer@apple.com>
946
947         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
948         <https://webkit.org/b/193676>
949
950         Reviewed by Alexey Proskuryakov.
951
952         * Scripts/webkitpy/style/checkers/cpp.py:
953         (check_member_initialization_list):
954         - Don't report missing whitespace around colon if the colon at
955           the start of the line is formatted correctly.
956         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
957         (WebKitStyleTest.test_member_initialization_list):
958         - Add a test for a missing permutation of existing tests.
959         - Add a test this false-positive.
960         - Add blank lines between subtests to make them easier to read.
961
962 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
963
964         [build.webkit.org] Unit-test failure after r237113
965         https://bugs.webkit.org/show_bug.cgi?id=193669
966
967         Reviewed by Michael Catanzaro.
968
969         * BuildSlaveSupport/build.webkit.org-config/factories.py:
970         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
971         multiple or zero flags.
972
973 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
974
975         Cache bytecode to disk
976         https://bugs.webkit.org/show_bug.cgi?id=192782
977         <rdar://problem/46084932>
978
979         Reviewed by Keith Miller.
980
981         Add test helper to execute bytecode-cache tests: it executes each test
982         twice, the first with JSC_diskCachePath set to a temporary directory
983         and second with JSC_forceDiskCache=true (in addition to the cache path)
984         to guarantee that only the disk cache is being used and no new
985         UnlinkedCodeBlocks are being created.
986
987         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
988         * Scripts/run-jsc-stress-tests:
989
990 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
991
992         [css-logical] Implement flow-relative margin, padding and border shorthands
993         https://bugs.webkit.org/show_bug.cgi?id=188697
994
995         Reviewed by Simon Fraser and Antti Koivisto.
996
997         * DumpRenderTree/TestOptions.cpp:
998         (TestOptions::TestOptions):
999         * DumpRenderTree/TestOptions.h:
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (setWebPreferencesForTestOptions):
1002         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1003
1004         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1005         (JSONCSSPropertiesChecker.check_codegen_properties):
1006         Allow CSS property definitions to have a 'runtime-flag' parameter which
1007         disables the property when the specified runtime flag is disabled.
1008
1009 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1010
1011         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1012         https://bugs.webkit.org/show_bug.cgi?id=193643
1013
1014         Reviewed by Michael Catanzaro.
1015
1016         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1017         * wpe/jhbuild.modules: Ditto.
1018
1019 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1020
1021         [LFC][Floats] Take float top position into account when computing containing block height.
1022         https://bugs.webkit.org/show_bug.cgi?id=193655
1023
1024         Reviewed by Antti Koivisto.
1025
1026         * LayoutReloaded/misc/LFC-passing-tests.txt:
1027
1028 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1029
1030         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1031         <https://webkit.org/b/193645>
1032         <rdar://problem/47421574>
1033
1034         Reviewed by Alex Christensen.
1035
1036         - Now checks for local soft-linking of all frameworks that have
1037           their own *SoftLinking.{cpp,h,mm} files.
1038         - Changes softlink/uikit warning to softlink/framework.
1039
1040         * Scripts/webkitpy/style/checkers/cpp.py:
1041         (check_language):
1042         (CppChecker):
1043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1044         (CppStyleTest):
1045
1046 2019-01-20  Saam Barati  <sbarati@apple.com>
1047
1048         Rollout r240210: It broke tests on iOS
1049         https://bugs.webkit.org/show_bug.cgi?id=193640
1050
1051         Unreviewed.
1052
1053         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1054         * Scripts/run-jsc-stress-tests:
1055
1056 2019-01-20  chris fleizach  <cfleizach@apple.com>
1057
1058         AX: Support returning relative frames for accessibility
1059         https://bugs.webkit.org/show_bug.cgi?id=193414
1060         <rdar://problem/47268501>
1061
1062         Reviewed by Zalan Bujtas.
1063
1064         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1065         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1066         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1067         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1068         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1069         (WTR::attributesOfElement):
1070         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1071
1072 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1073
1074         Unreviewed, add my new email address
1075
1076         * Scripts/webkitpy/common/config/contributors.json:
1077
1078 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1079
1080         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1081         https://bugs.webkit.org/show_bug.cgi?id=193617
1082
1083         Reviewed by Antti Koivisto.
1084
1085         * LayoutReloaded/misc/LFC-passing-tests.txt:
1086
1087 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1088
1089         Unreviewed, rolling out r240209.
1090
1091         Broke GTK/WPE injected bundle
1092
1093         Reverted changeset:
1094
1095         "AX: Support returning relative frames for accessibility"
1096         https://bugs.webkit.org/show_bug.cgi?id=193414
1097         https://trac.webkit.org/changeset/240209
1098
1099 2019-01-12  Dan Bernstein  <mitz@apple.com>
1100
1101         [Cocoa] Avoid importing directly from subumbrella frameworks
1102         https://bugs.webkit.org/show_bug.cgi?id=186016
1103         <rdar://problem/40591038>
1104
1105         Reviewed by Sam Weinig.
1106
1107         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1108           LaunchServices header.
1109         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1110           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1111         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1112           when using SDKs earlier than 10.13.
1113         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1114           and OTHER_CPLUSPLUSFLAGS.
1115         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1116           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1117         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1118           LaunchServices header.
1119
1120 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1121
1122         Cache bytecode to disk
1123         https://bugs.webkit.org/show_bug.cgi?id=192782
1124         <rdar://problem/46084932>
1125
1126         Reviewed by Keith Miller.
1127
1128         Add test helper to execute bytecode-cache tests: it executes each test
1129         twice, the first with JSC_diskCachePath set to a temporary directory
1130         and second with JSC_forceDiskCache=true (in addition to the cache path)
1131         to guarantee that only the disk cache is being used and no new
1132         UnlinkedCodeBlocks are being created.
1133
1134         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1135         * Scripts/run-jsc-stress-tests:
1136
1137 2019-01-20  chris fleizach  <cfleizach@apple.com>
1138
1139         AX: Support returning relative frames for accessibility
1140         https://bugs.webkit.org/show_bug.cgi?id=193414
1141         <rdar://problem/47268501>
1142
1143         Reviewed by Zalan Bujtas.
1144
1145         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1146         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1147         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1148         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1149         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1150         (WTR::attributesOfElement):
1151         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1152
1153 2019-01-20  Antoine Quint  <graouts@apple.com>
1154
1155         Add a POINTER_EVENTS feature flag
1156         https://bugs.webkit.org/show_bug.cgi?id=193577
1157         <rdar://problem/47408511>
1158
1159         Unreviewed. Also enable Pointer Events for iosmac.
1160
1161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1162
1163 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1164
1165         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1166         https://bugs.webkit.org/show_bug.cgi?id=193613
1167
1168         Reviewed by Antti Koivisto.
1169
1170         * LayoutReloaded/misc/LFC-passing-tests.txt:
1171
1172 2019-01-19  Antoine Quint  <graouts@apple.com>
1173
1174         Add a POINTER_EVENTS feature flag
1175         https://bugs.webkit.org/show_bug.cgi?id=193577
1176
1177         Reviewed by Dean Jackson.
1178
1179         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1180
1181 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1182
1183         Disable the run-jsc-stress-test remote host key check [second round].
1184         https://bugs.webkit.org/show_bug.cgi?id=192988
1185
1186         Reviewed by Dewei Zhu.
1187
1188         * Scripts/run-jsc-stress-tests:
1189
1190 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1191
1192         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1193         https://bugs.webkit.org/show_bug.cgi?id=193597
1194
1195         Reviewed by Lucas Forschler.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1198
1199 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1200
1201         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1202         https://bugs.webkit.org/show_bug.cgi?id=193595
1203
1204         Reviewed by Lucas Forschler.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1207         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1208         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1209
1210 2019-01-18  Chris Dumez  <cdumez@apple.com>
1211
1212         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1213         https://bugs.webkit.org/show_bug.cgi?id=193588
1214         <rdar://problem/47131566>
1215
1216         Reviewed by Alex Christensen.
1217
1218         Add layout test coverage.
1219
1220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1221
1222 2019-01-18  Jer Noble  <jer.noble@apple.com>
1223
1224         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1225         https://bugs.webkit.org/show_bug.cgi?id=189553
1226
1227         Reviewed by Tim Horton.
1228
1229         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1230
1231         * ContentExtensionTester/Configurations/Base.xcconfig:
1232         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1233         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1234         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1235         * ImageDiff/cg/Configurations/Base.xcconfig:
1236         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1237         * MiniBrowser/Configurations/Base.xcconfig:
1238         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1239         * MobileMiniBrowser/Configurations/Base.xcconfig:
1240         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1241         * Scripts/webkitpy/style/checker.py:
1242         (_all_categories):
1243         (FileType):
1244         (CheckerDispatcher._file_type):
1245         (CheckerDispatcher._create_checker):
1246         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1247         (SDKVariantChecker):
1248         (SDKVariantChecker.__init__):
1249         (SDKVariantChecker.check):
1250         * TestWebKitAPI/Configurations/Base.xcconfig:
1251         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1252         * WebEditingTester/Configurations/Base.xcconfig:
1253         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1254         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1255         * WebKitTestRunner/Configurations/Base.xcconfig:
1256         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1257         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1258         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1259
1260 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1261
1262         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1263         <https://webkit.org/b/193568>
1264         <rdar://problem/47381130>
1265
1266         Reviewed by Alex Christensen.
1267
1268         Make sure no one re-introduces UIKit soft-linking by adding a
1269         style rule.
1270
1271         * Scripts/webkitpy/style/checkers/cpp.py:
1272         (check_language): Add softlink/uikit check.
1273         (CppChecker): Enable softlink/uikit check.
1274         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1275         (CppStyleTest): Add test for softlink/uikit.
1276
1277 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1278
1279         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1280         https://bugs.webkit.org/show_bug.cgi?id=193584
1281
1282         Change "-dev" to "-devel".
1283
1284         Reviewed by Michael Catanzaro.
1285
1286         * gtk/install-dependencies:
1287
1288 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1289
1290         webkitpy: Add iPhone and iPad ports
1291         https://bugs.webkit.org/show_bug.cgi?id=193537
1292         <rdar://problem/47353390>
1293
1294         Reviewed by Lucas Forschler.
1295
1296         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1297         ports. Note that this separation is optional, the --ios-simulator command remains.
1298
1299         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1300         (RunTest.test_device_type_test_division): Drive-by fix.
1301         (RunTest.test_device_type_specific_listing): Ditto.
1302         (RunTest.test_ipad_test_division):
1303         (RunTest):
1304         (RunTest.test_ipad_listing):
1305         * Scripts/webkitpy/port/factory.py:
1306         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1307         (PortFactory):
1308         * Scripts/webkitpy/port/ios_simulator.py:
1309         (IPhoneSimulatorPort):
1310         (IPadSimulatorPort):
1311
1312 2019-01-18  Chris Dumez  <cdumez@apple.com>
1313
1314         Regression(PSON) Scroll position is not always restored properly when navigating back
1315         https://bugs.webkit.org/show_bug.cgi?id=193578
1316         <rdar://problem/47386331>
1317
1318         Reviewed by Tim Horton.
1319
1320         Add API test coverage.
1321
1322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1323
1324 2019-01-18  Youenn Fablet  <youenn@apple.com>
1325
1326         Add a new SPI to request for cache storage quota increase
1327         https://bugs.webkit.org/show_bug.cgi?id=193323
1328
1329         Reviewed by Alex Christensen.
1330
1331         Implement WebsiteDataStore quota delegate to handle quota requests.
1332         By default, do not update quota.
1333         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1334
1335         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1337         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1338         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1339         * WebKitTestRunner/TestController.cpp:
1340         (WTR::TestController::allowCacheStorageQuotaIncrease):
1341         * WebKitTestRunner/TestController.h:
1342         * WebKitTestRunner/TestInvocation.cpp:
1343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1345         (-[CacheStorageQuotaManager init]):
1346         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1347         (WTR::initializeWebViewConfiguration):
1348         (WTR::TestController::cocoaResetStateToConsistentValues):
1349         (WTR::TestController::allowCacheStorageQuotaIncrease):
1350
1351 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1352
1353         [ews-build] Pass owner to the triggered builds
1354         https://bugs.webkit.org/show_bug.cgi?id=193574
1355
1356         Reviewed by Lucas Forschler.
1357
1358         * BuildSlaveSupport/ews-build/factories.py:
1359         (BuildFactory.propertiesToPassToTriggers):
1360
1361 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1362
1363         [ews-app] Send patch author as a build property
1364         https://bugs.webkit.org/show_bug.cgi?id=193560
1365
1366         Reviewed by Lucas Forschler.
1367
1368         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1369         (BugzillaPatchFetcher.fetch):
1370
1371 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1372
1373         webkitpy: Implement device type specific expected results (Follow-up fix)
1374         https://bugs.webkit.org/show_bug.cgi?id=192162
1375         <rdar://problem/46345449>
1376
1377         Unreviewed infrastructure fix.
1378
1379         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1380         (Manager.run): Don't boot a device if no tests are available to run on it.
1381
1382 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1383
1384         webkitpy: Implement device type specific expected results (Follow-up fix)
1385         https://bugs.webkit.org/show_bug.cgi?id=192162
1386         <rdar://problem/46345449>
1387
1388         Unreviewed infrastructure fix.
1389
1390         * Scripts/webkitpy/api_tests/manager.py:
1391         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1392
1393 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1394
1395         webkitpy: Implement device type specific expected results (Part 2)
1396         https://bugs.webkit.org/show_bug.cgi?id=192162
1397         <rdar://problem/46345449>
1398
1399         Rubber-stamped by Aakash Jain.
1400
1401         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1402         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1403         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1404
1405         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1406         (LayoutTestFinder.find_tests): Pass device_type through.
1407         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1408         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1409         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1410         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1411         (Manager._collect_tests): Pass device type to test finder.
1412         (Manager._needs_web_platform_test):
1413         (Manager._prepare_lists): Index _expectations by device type.
1414         (Manager._test_input_for_file):
1415         (Manager._test_is_slow): Ditto.
1416         (Manager._test_should_dump_jsconsolelog_in_stderr):
1417         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1418         (Manager._get_test_inputs):
1419         (Manager._update_worker_count):
1420         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1421         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1422         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1423         the one which runs the test.
1424         (Manager._run_test_subset):
1425         (Manager._run_tests): Index _expectations by current_device_type.
1426         (Manager._print_expectation_line_for_test): Ditto.
1427         (Manager._print_expectations_for_subset): Ditto.
1428         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1429         Unlike run, this function will behave the same regardless of what devices are available.
1430         (Manager._custom_device_for_test): Deleted.
1431         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1432         (ManagerTest.test_uses_custom_device): Deleted.
1433         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1434         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1435         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1436         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1437         all of the expectations.
1438         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1439         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1440         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1441         (TestExpectations.__init__): Allow device_type to be passed through.
1442         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1443         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1444         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1445         (summarize_results):
1446         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1447         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1448         a test ran with, one must check all expectations to find the first non-skip expectation.
1449         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1450         (RunTest.test_device_type_test_division):
1451         (RunTest):
1452         (RunTest.test_device_type_specific_listing):
1453         * Scripts/webkitpy/port/base.py:
1454         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1455         (Port.supported_device_types): The result of this function will change based on what devices are available.
1456         * Scripts/webkitpy/port/device_port.py:
1457         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1458         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1459         can be used.
1460         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1461         any, or the DEFAULT_DEVICE_TYPES of the port.
1462         * Scripts/webkitpy/port/ios.py:
1463         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1464         * Scripts/webkitpy/port/ios_simulator.py:
1465         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1466         * Scripts/webkitpy/port/watch.py:
1467         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1468         * Scripts/webkitpy/port/watch_simulator.py:
1469         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1470         * Scripts/webkitpy/xcode/device_type.py:
1471         (DeviceType):
1472         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1473
1474 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1475
1476         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1477         https://bugs.webkit.org/show_bug.cgi?id=193575
1478
1479         Reviewed by Michael Catanzaro.
1480
1481         Allow the script to run without explicit port argument because
1482         it's specific to the WPE port anyway.
1483
1484         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1485         and simplify the rest of the code accordingly.
1486
1487 2019-01-18  Charlie Turner  <cturner@igalia.com>
1488
1489         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1490         https://bugs.webkit.org/show_bug.cgi?id=192229
1491
1492         Reviewed by Xabier Rodriguez-Calvar.
1493
1494         * MiniBrowser/wpe/main.cpp:
1495         (main): Enable encrypted-media by default.
1496
1497 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1498
1499         [Flatpak] Missing KeyboardInterrupt exception handler
1500         https://bugs.webkit.org/show_bug.cgi?id=193570
1501
1502         Reviewed by Michael Catanzaro.
1503
1504         * flatpak/flatpakutils.py:
1505         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1506
1507 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1508
1509         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1510         https://bugs.webkit.org/show_bug.cgi?id=193564
1511
1512         Reviewed by Antti Koivisto.
1513
1514         * LayoutReloaded/misc/LFC-passing-tests.txt:
1515
1516 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1517
1518         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1519         https://bugs.webkit.org/show_bug.cgi?id=193562
1520
1521         Reviewed by Antti Koivisto.
1522
1523         * LayoutReloaded/misc/LFC-passing-tests.txt:
1524
1525 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1526
1527         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1528         https://bugs.webkit.org/show_bug.cgi?id=193555
1529
1530         Reviewed by Antti Koivisto.
1531
1532         * LayoutReloaded/misc/LFC-passing-tests.txt:
1533
1534 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1535
1536         [WPE] Add Qt extension
1537         https://bugs.webkit.org/show_bug.cgi?id=191464
1538
1539         Reviewed by Carlos Garcia Campos.
1540
1541         MiniBrowser and API tests for the WPE Qt API. To run the
1542         MiniBrowser a new script is introduced. Example invocation:
1543
1544         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1545
1546         Also note-worthy is the introduction of the python2-subprocess32
1547         dependency to run the GLib API tests.
1548
1549         * MiniBrowser/wpe/CMakeLists.txt:
1550         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1551         * MiniBrowser/wpe/qt/main.cpp: Added.
1552         (main):
1553         * MiniBrowser/wpe/qt/main.qml: Added.
1554         * MiniBrowser/wpe/qt/qml.qrc: Added.
1555         * Scripts/run-gtk-tests:
1556         (GtkTestRunner.is_google_test):
1557         (GtkTestRunner):
1558         (GtkTestRunner.is_qt_test):
1559         * Scripts/run-qt-wpe-minibrowser: Added.
1560         * Scripts/run-wpe-tests:
1561         (WPETestRunner):
1562         (WPETestRunner.is_google_test):
1563         (WPETestRunner.is_qt_test):
1564         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1565         (TestLoad::main):
1566         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1567         (TestLoadHtml::main):
1568         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1569         (TestLoadRequest::main):
1570         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1571         (TestRunJavaScript::main):
1572         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1573         (waitForSignal):
1574         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1575         (LoadSpy::LoadSpy):
1576         (LoadSpy::~LoadSpy):
1577         (LoadSpy::onLoadingChanged):
1578         (LoadStartedCatcher::LoadStartedCatcher):
1579         (LoadStartedCatcher::~LoadStartedCatcher):
1580         (LoadStartedCatcher::onLoadingChanged):
1581         (waitForLoadSucceeded):
1582         (waitForLoadFailed):
1583         * TestWebKitAPI/glib/CMakeLists.txt:
1584         * flatpak/flatpakutils.py:
1585         (WebkitFlatpak.load_from_args):
1586         (WebkitFlatpak.__init__):
1587         (WebkitFlatpak.clean_args):
1588         (WebkitFlatpak.run_in_sandbox):
1589         * flatpak/org.webkit.CommonModules.yaml:
1590         * flatpak/org.webkit.WPE.yaml:
1591         * flatpak/org.webkit.WPEModules.yaml:
1592         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1593         * flatpak/org.webkit.WebKit.yaml:
1594         * glib/api_test_runner.py:
1595         (TestRunner._run_test_qt):
1596         (TestRunner.is_qt_test):
1597         (TestRunner._run_test):
1598
1599 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1600
1601         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1602         https://bugs.webkit.org/show_bug.cgi?id=193494
1603         <rdar://problem/46859627>
1604
1605         Reviewed by Simon Fraser and Tim Horton.
1606
1607         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1608         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1609
1610         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1611         (WTR::UIScriptController::contentOffsetX const):
1612         (WTR::UIScriptController::contentOffsetY const):
1613         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1614         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1615         (WTR::UIScriptController::contentOffsetX const):
1616         (WTR::UIScriptController::contentOffsetY const):
1617         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1618
1619         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1620
1621         * WebKitTestRunner/TestController.cpp:
1622         (WTR::updateTestOptionsFromTestHeader):
1623         * WebKitTestRunner/TestOptions.h:
1624         (WTR::TestOptions::hasSameInitializationOptions const):
1625         * WebKitTestRunner/ios/TestControllerIOS.mm:
1626         (WTR::TestController::platformResetStateToConsistentValues):
1627         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1628         (WTR::UIScriptController::contentOffsetX const):
1629         (WTR::UIScriptController::contentOffsetY const):
1630
1631 2019-01-17  Truitt Savell  <tsavell@apple.com>
1632
1633         Unreviewed, rolling out r240124.
1634
1635         This commit broke an internal build.
1636
1637         Reverted changeset:
1638
1639         "SDK_VARIANT build destinations should be separate from non-
1640         SDK_VARIANT builds"
1641         https://bugs.webkit.org/show_bug.cgi?id=189553
1642         https://trac.webkit.org/changeset/240124
1643
1644 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1645
1646         Fix string concatenation API test after r239920
1647         https://bugs.webkit.org/show_bug.cgi?id=193551
1648         <rdar://problem/47359304>
1649
1650         Reviewed by Youenn Fablet.
1651
1652         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1653         (TestWebKitAPI::TEST):
1654         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1655         in WebKit's build configuration like it apparently is on Linux.
1656
1657 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] validate-patch should handle the case when bug_id is None
1660         https://bugs.webkit.org/show_bug.cgi?id=193547
1661
1662         Reviewed by Lucas Forschler.
1663
1664         * BuildSlaveSupport/ews-build/steps.py:
1665         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1666         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1667
1668 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1669
1670         [ews-build] Add patch author information in build
1671         https://bugs.webkit.org/show_bug.cgi?id=193465
1672
1673         Reviewed by Lucas Forschler.
1674
1675         * BuildSlaveSupport/ews-build/steps.py:
1676         (ValidatePatch._is_patch_obsolete):
1677
1678 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1679
1680         [ews-build] Pass bug_id to the triggered builds
1681         https://bugs.webkit.org/show_bug.cgi?id=193548
1682
1683         Reviewed by Lucas Forschler.
1684
1685         * BuildSlaveSupport/ews-build/factories.py:
1686         (BuildFactory.propertiesToPassToTriggers):
1687
1688 2019-01-17  Jer Noble  <jer.noble@apple.com>
1689
1690         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1691         https://bugs.webkit.org/show_bug.cgi?id=189553
1692
1693         Reviewed by Tim Horton.
1694
1695         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1696
1697         * ContentExtensionTester/Configurations/Base.xcconfig:
1698         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1699         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1700         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1701         * ImageDiff/cg/Configurations/Base.xcconfig:
1702         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1703         * MiniBrowser/Configurations/Base.xcconfig:
1704         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1705         * MobileMiniBrowser/Configurations/Base.xcconfig:
1706         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1707         * Scripts/webkitpy/style/checker.py:
1708         (_all_categories):
1709         (FileType):
1710         (CheckerDispatcher._file_type):
1711         (CheckerDispatcher._create_checker):
1712         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1713         (SDKVariantChecker):
1714         (SDKVariantChecker.__init__):
1715         (SDKVariantChecker.check):
1716         * TestWebKitAPI/Configurations/Base.xcconfig:
1717         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1718         * WebEditingTester/Configurations/Base.xcconfig:
1719         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1720         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1721         * WebKitTestRunner/Configurations/Base.xcconfig:
1722         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1723         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1724         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1725
1726 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1727
1728         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1729         https://bugs.webkit.org/show_bug.cgi?id=193534
1730
1731         Reviewed by Antti Koivisto.
1732
1733         * LayoutReloaded/misc/LFC-passing-tests.txt:
1734
1735 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1736
1737         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1738         https://bugs.webkit.org/show_bug.cgi?id=193528
1739
1740         Reviewed by Antti Koivisto.
1741
1742         * LayoutReloaded/misc/LFC-passing-tests.txt:
1743
1744 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1745
1746         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1747         https://bugs.webkit.org/show_bug.cgi?id=193520
1748
1749         Reviewed by Antti Koivisto.
1750
1751         * LayoutReloaded/misc/LFC-passing-tests.txt:
1752
1753 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1754
1755         [ews-build] unapply-patch step should not update source
1756         https://bugs.webkit.org/show_bug.cgi?id=193234
1757
1758         Reviewed by Lucas Forschler.
1759
1760         * BuildSlaveSupport/ews-build/steps.py:
1761         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1762         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1763
1764 2019-01-16  Youenn Fablet  <youenn@apple.com>
1765
1766         Add a new SPI for controlling getUserMedia
1767         https://bugs.webkit.org/show_bug.cgi?id=192793
1768
1769         Reviewed by Eric Carlson.
1770
1771         * MiniBrowser/mac/WK2BrowserWindowController.m:
1772         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1773         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1774         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1775         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1776         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1777         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1778         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1779         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1780         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1781         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1782         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1783         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1784         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1785         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1786
1787 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1788
1789         [LFC][BFC] Inflow non-replaced used width should not be negative.
1790         https://bugs.webkit.org/show_bug.cgi?id=193495
1791
1792         Reviewed by Antti Koivisto.
1793
1794         * LayoutReloaded/misc/LFC-passing-tests.txt:
1795
1796 2019-01-16  Chris Dumez  <cdumez@apple.com>
1797
1798         Regression(PSON) View becomes blank after click a cross-site download link
1799         https://bugs.webkit.org/show_bug.cgi?id=193361
1800         <rdar://problem/47099573>
1801
1802         Reviewed by Geoffrey Garen.
1803
1804         Add API test coverage.
1805
1806         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1807         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1808
1809 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1810
1811         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1812         https://bugs.webkit.org/show_bug.cgi?id=193470
1813
1814         Reviewed by Antti Koivisto.
1815
1816         * LayoutReloaded/misc/LFC-passing-tests.txt:
1817
1818 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1819
1820         [LFC] Adjust margin box verification.
1821         https://bugs.webkit.org/show_bug.cgi?id=193482
1822
1823         Reviewed by Antti Koivisto.
1824
1825         * LayoutReloaded/misc/LFC-passing-tests.txt:
1826
1827 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1828
1829         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1830         https://bugs.webkit.org/show_bug.cgi?id=193451
1831
1832         Reviewed by Geoffrey Garen.
1833
1834         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1835         (TEST):
1836         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1837         (runWebsiteDataStoreCustomPaths):
1838
1839 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1840
1841         webkitpy: Support boolean simctl isAvailable
1842         https://bugs.webkit.org/show_bug.cgi?id=193472
1843         <rdar://problem/47296150>
1844
1845         Reviewed by Ryosuke Niwa.
1846
1847         * Scripts/webkitpy/xcode/simulated_device.py:
1848         (SimulatedDeviceManager._create_runtimes):
1849         (SimulatedDeviceManager._create_device_with_runtime):
1850
1851 2019-01-15  Chris Dumez  <cdumez@apple.com>
1852
1853         Unreviewed, rolling out r239993, r239995, r239997, and
1854         r239999.
1855
1856         Caused assertions under
1857         ViewGestureController::disconnectFromProcess()
1858
1859         Reverted changesets:
1860
1861         "Regression(PSON) View becomes blank after click a cross-site
1862         download link"
1863         https://bugs.webkit.org/show_bug.cgi?id=193361
1864         https://trac.webkit.org/changeset/239993
1865
1866         "Unreviewed iOS build fix after r239993."
1867         https://trac.webkit.org/changeset/239995
1868
1869         "Fix iOS build after r239993"
1870         https://bugs.webkit.org/show_bug.cgi?id=193361
1871         https://trac.webkit.org/changeset/239997
1872
1873         "Unreviewed, revert part of r239997 as it is not needed to fix
1874         the build."
1875         https://trac.webkit.org/changeset/239999
1876
1877 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1878
1879         Cannot tab out of WKWebView on macOS
1880         https://bugs.webkit.org/show_bug.cgi?id=161448
1881         <rdar://problem/28100085>
1882
1883         Reviewed by Dean Jackson.
1884
1885         Add a test that tabbing into and out of WKWebView works correctly.
1886
1887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1888         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1889         (WebKit2_CommandBackForwardTest::SetUp):
1890         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1891         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1892         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1893         (-[FocusableView canBecomeKeyView]):
1894         (TEST):
1895         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1896         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1897         (-[OffscreenWindow initWithSize:]):
1898         (-[OffscreenWindow isKeyWindow]):
1899         (-[OffscreenWindow isVisible]):
1900         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1901         (TestWebKitAPI::PlatformWebView::initialize):
1902         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1903         (-[ActiveOffscreenWindow isVisible]): Deleted.
1904         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1905
1906 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1907
1908         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1909         https://bugs.webkit.org/show_bug.cgi?id=193459
1910
1911         Reviewed by Mark Lam.
1912
1913         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1914         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1915
1916 2019-01-15  Chris Dumez  <cdumez@apple.com>
1917
1918         Regression(PSON) View becomes blank after click a cross-site download link
1919         https://bugs.webkit.org/show_bug.cgi?id=193361
1920         <rdar://problem/47099573>
1921
1922         Reviewed by Geoff Garen.
1923
1924         Add API test coverage.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1927         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1928
1929 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1930
1931         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1932         https://bugs.webkit.org/show_bug.cgi?id=193448
1933
1934         Reviewed by Antti Koivisto.
1935
1936         * LayoutReloaded/misc/LFC-passing-tests.txt:
1937
1938 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1939
1940         webkitpy: Implement device type specific expected results (Part 1)
1941         https://bugs.webkit.org/show_bug.cgi?id=192162
1942
1943         Reviewed by Lucas Forschler.
1944
1945         Device type specific expected results covers two related ideas. The first (covered by this change)
1946         is where to search for -expected.* files. The second is which tests to run based on the
1947         TestExpectations.txt file.
1948
1949         After this change, the baseline search path will be determined by the type of device running a
1950         test. Device type will be passed into any function which picks a file based on the baseline search
1951         path.
1952
1953         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1954         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1955         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1956         (Manager.run): Print baseline search path for each round of devices.
1957         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1958         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1959         (SingleTestRunner._expected_driver_output): Ditto.
1960         (SingleTestRunner._driver_input): Ditto.
1961         * Scripts/webkitpy/layout_tests/views/printing.py:
1962         (Printer.print_config): Move printing of baseline search path to a separate function.
1963         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1964         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1965         (Testprinter.test_print_config):
1966         (Testprinter.test_print_baseline_search_path):
1967         * Scripts/webkitpy/port/base.py:
1968         (Port.baseline_search_path): Pass device_type through.
1969         (Port._expected_baselines_for_suffixes): Ditto.
1970         (Port.expected_baselines): Ditto.
1971         (Port.expected_filename): Ditto.
1972         (Port.expected_checksum): Ditto.
1973         (Port.expected_image): Ditto.
1974         (Port.expected_audio): Ditto.
1975         (Port.expected_text): Ditto.
1976         (Port.reference_files): Ditto.
1977         (Port.tests): Ditto.
1978         (Port._expanded_paths): Ditto.
1979         (Port.skipped_layout_tests): Ditto.
1980         (Port.expectations_dict): Ditto.
1981         (Port._port_specific_expectations_files): Ditto.
1982         (Port.expectations_files): Ditto.
1983         (Port.test_search_path): Ditto.
1984         (Port._tests_for_other_platforms): Ditto.
1985         * Scripts/webkitpy/port/base_unittest.py:
1986         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1987         (PortTest.test_nonexistant_expectations): Ditto.
1988         (test_ref_tests_platform_directory): Ditto.
1989         * Scripts/webkitpy/port/darwin.py:
1990         (DarwinPort._port_specific_expectations_files): Accept device_type.
1991         * Scripts/webkitpy/port/driver.py:
1992         (DriverProxy):
1993         (DriverProxy.host): Expose _target_host for device_type information.
1994         * Scripts/webkitpy/port/gtk.py:
1995         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1996         * Scripts/webkitpy/port/ios.py:
1997         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1998         * Scripts/webkitpy/port/mac.py:
1999         (MacPort. default_baseline_search_path): Ditto.
2000         * Scripts/webkitpy/port/port_testcase.py:
2001         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2002         * Scripts/webkitpy/port/test.py:
2003         * Scripts/webkitpy/port/watch.py:
2004         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2005         * Scripts/webkitpy/port/win.py:
2006         (WinPort.test_search_path): Accept, but do not use, device_type.
2007         * Scripts/webkitpy/port/wpe.py:
2008         (WPEPort._port_specific_expectations_files): Ditto.
2009         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2010         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2011
2012 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2013
2014         [LFC] Use the containing block's padding box to position out-of-flow elements.
2015         https://bugs.webkit.org/show_bug.cgi?id=193431
2016
2017         Reviewed by Antti Koivisto.
2018
2019         * LayoutReloaded/misc/LFC-passing-tests.txt:
2020
2021 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2022
2023         Move a test implementation file that got misplaced in the Xcode project
2024
2025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2026
2027 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2028
2029         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2030         r239913, and r239914.
2031         https://bugs.webkit.org/show_bug.cgi?id=193407
2032
2033         These revisions caused an internal failure (Requested by
2034         Truitt on #webkit).
2035
2036         Reverted changesets:
2037
2038         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2039         https://bugs.webkit.org/show_bug.cgi?id=186016
2040         https://trac.webkit.org/changeset/239901
2041
2042         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2043         https://trac.webkit.org/changeset/239909
2044
2045         "Tried to fix the build."
2046         https://trac.webkit.org/changeset/239910
2047
2048         "Fixed iOS builds after r239910."
2049         https://trac.webkit.org/changeset/239912
2050
2051         "More build fixing."
2052         https://trac.webkit.org/changeset/239913
2053
2054         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2055         https://trac.webkit.org/changeset/239914
2056
2057 2019-01-14  Mark Lam  <mark.lam@apple.com>
2058
2059         Re-enable ability to build --cloop builds.
2060         https://bugs.webkit.org/show_bug.cgi?id=192955
2061         <rdar://problem/46882363>
2062
2063         Reviewed by Saam barati and Keith Miller.
2064
2065         The --cloop build option was being ignored this whole time since r236381.
2066         This patch makes it possible to build CLoop builds again.
2067
2068         * Scripts/build-jsc:
2069         * Scripts/webkitperl/FeatureList.pm:
2070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2071
2072 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2073
2074         webkitpy: Expose device_type from host-like objects
2075         https://bugs.webkit.org/show_bug.cgi?id=193406
2076         <rdar://problem/47262305>
2077
2078         Reviewed by Lucas Forschler.
2079
2080         Devices should expose device_type. As a result, all host objects should
2081         provide a device_type property, even if they do not yet define a device_type.
2082
2083         * Scripts/webkitpy/common/system/systemhost.py:
2084         (SystemHost):
2085         (SystemHost.device_type):
2086         * Scripts/webkitpy/common/system/systemhost_mock.py:
2087         (MockSystemHost):
2088         (MockSystemHost.device_type):
2089         * Scripts/webkitpy/port/device.py:
2090         (Device):
2091         (Device.device_type):
2092         * Scripts/webkitpy/xcode/simulated_device.py:
2093         (SimulatedDeviceManager._find_exisiting_device_for_request):
2094         (SimulatedDeviceManager._disambiguate_device_type):
2095         (SimulatedDeviceManager._does_fulfill_request):
2096         (SimulatedDeviceManager.device_count_for_type):
2097         (SimulatedDeviceManager.initialize_devices):
2098         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2099         (test_available_devices):
2100         (test_swapping_devices):
2101
2102 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2103
2104         webkitpy: Support alternate simctl device list output (Follow-up fix)
2105         https://bugs.webkit.org/show_bug.cgi?id=193362
2106         <rdar://problem/47122965>
2107
2108         Rubber-stamped by Lucas Forschler.
2109
2110         * Scripts/webkitpy/xcode/simulated_device.py:
2111         (SimulatedDeviceManager.populate_available_devices):
2112
2113 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2114
2115         [iOS] Expose SPI to access the current sentence boundary and selection state
2116         https://bugs.webkit.org/show_bug.cgi?id=193398
2117         <rdar://problem/45893108>
2118
2119         Reviewed by Dean Jackson.
2120
2121         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2122         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2123         expected.
2124
2125         * TestWebKitAPI/EditingTestHarness.h:
2126         * TestWebKitAPI/EditingTestHarness.mm:
2127         (-[EditingTestHarness moveBackward]):
2128         (-[EditingTestHarness moveForward]):
2129         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2130
2131         Add a couple of new helper methods on EditingTestHarness.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2134         (-[SelectionChangeObserver initWithWebView:]):
2135         (-[SelectionChangeObserver webView]):
2136         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2137         (-[SelectionChangeObserver currentSelectionAttributes]):
2138
2139 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2140
2141         [LFC][BFC] Add basic box-sizing support.
2142         https://bugs.webkit.org/show_bug.cgi?id=193392
2143
2144         Reviewed by Antti Koivisto.
2145
2146         * LayoutReloaded/misc/LFC-passing-tests.txt:
2147
2148 2019-01-14  Charlie Turner  <cturner@igalia.com>
2149
2150         [WPE] API test gardening
2151         https://bugs.webkit.org/show_bug.cgi?id=193319
2152
2153         Reviewed by Michael Catanzaro.
2154
2155         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2156         passing tests.
2157
2158 2019-01-14  Charlie Turner  <cturner@igalia.com>
2159
2160         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2161         https://bugs.webkit.org/show_bug.cgi?id=192977
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2166         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2167         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2168         (TestWebKitAPI::GStreamerTest::SetUp):
2169         (TestWebKitAPI::GStreamerTest::TearDown):
2170         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2171         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2172         (TestWebKitAPI::TEST_F):
2173
2174 2019-01-14  Charlie Turner  <cturner@igalia.com>
2175
2176         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2177         https://bugs.webkit.org/show_bug.cgi?id=193332
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2182         defined as a char16_t, which changed in ICU 59, the
2183         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2184         unsigned short. This test is relying on the behaviour that
2185         UChar=unsigned short, which doesn't hold across platforms and ICU
2186         library versions. The full fix would be a special syntax for
2187         literal characters so that these ambiguities do not arise. That
2188         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2189         (TestWebKitAPI::TEST):
2190
2191 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2192
2193         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2194
2195         * Scripts/make-dist:
2196         (Distcheck.configure):
2197
2198 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2199
2200         [ews-build] Update macOS queue configurations
2201         https://bugs.webkit.org/show_bug.cgi?id=193365
2202         <rdar://problem/47221073>
2203
2204         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2205
2206         * BuildSlaveSupport/ews-build/config.json:
2207
2208 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2209
2210         [LFC] Adjust assert for statically positioned fixed elements
2211         https://bugs.webkit.org/show_bug.cgi?id=193385
2212
2213         Reviewed by Antti Koivisto.
2214
2215         * LayoutReloaded/misc/LFC-passing-tests.txt:
2216
2217 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2218
2219         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2220         https://bugs.webkit.org/show_bug.cgi?id=193387
2221
2222         Reviewed by Carlos Garcia Campos.
2223
2224         * MiniBrowser/wpe/main.cpp:
2225         (main):
2226
2227 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2228
2229         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2230         https://bugs.webkit.org/show_bug.cgi?id=191655
2231         rdar://problem/46074680
2232
2233         Reviewed by Megan Gardner.
2234
2235         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2236         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2237
2238 2019-01-12  Dan Bernstein  <mitz@apple.com>
2239
2240         [Cocoa] Avoid importing directly from subumbrella frameworks
2241         https://bugs.webkit.org/show_bug.cgi?id=186016
2242         <rdar://problem/40591038>
2243
2244         Reviewed by Sam Weinig.
2245
2246         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2247           LaunchServices header.
2248         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2249           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2250         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2251           when using SDKs earlier than 10.13.
2252         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2253           and OTHER_CPLUSPLUSFLAGS.
2254         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2255           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2256         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2257           LaunchServices header.
2258
2259 2019-01-11  John Wilander  <wilander@apple.com>
2260
2261         Compile out Web API Statistics Collection
2262         https://bugs.webkit.org/show_bug.cgi?id=193370
2263         <rdar://problem/45388584>
2264
2265         Reviewed by Brent Fulgham.
2266
2267         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2268             Defined ENABLE_WEB_API_STATISTICS, off by default.
2269
2270 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2271
2272         [WPE] Add gtk-doc
2273         https://bugs.webkit.org/show_bug.cgi?id=178900
2274
2275         Reviewed by Michael Catanzaro.
2276
2277         Add Tools/gtkdoc to manifest.txt.in files.
2278         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2279
2280         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2281         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2282
2283 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2284
2285         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2286         https://bugs.webkit.org/show_bug.cgi?id=193364
2287         <rdar://problem/47214117>
2288
2289         Reviewed by Tim Horton.
2290
2291         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2292         precise, whereas dragging near the middle of the textarea does.
2293
2294         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2295         (TestWebKitAPI::TEST):
2296
2297 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2298
2299         webkitpy: Support alternate simctl device list output
2300         https://bugs.webkit.org/show_bug.cgi?id=193362
2301         <rdar://problem/47122965>
2302
2303         Reviewed by Lucas Forschler.
2304
2305         * Scripts/webkitpy/xcode/simulated_device.py:
2306         (SimulatedDeviceManager.populate_available_devices):
2307
2308 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-build] Update macOS queue configurations
2311         https://bugs.webkit.org/show_bug.cgi?id=193365
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-build/config.json:
2316
2317 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2318
2319         webkitpy: Incorporate device type into baseline search path
2320         https://bugs.webkit.org/show_bug.cgi?id=193356
2321         <rdar://problem/47215515>
2322
2323         Reviewed by Lucas Forschler.
2324
2325         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2326
2327         * Scripts/webkitpy/port/base.py:
2328         (Port.default_baseline_search_path): Allow device type to be passed in.
2329         * Scripts/webkitpy/port/gtk.py:
2330         (GtkPort.default_baseline_search_path): Ignore device type.
2331         * Scripts/webkitpy/port/ios.py:
2332         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2333         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2334         * Scripts/webkitpy/port/ios_device_unittest.py:
2335         (IOSDeviceTest):
2336         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2337         (IOSSimulatorTest):
2338         * Scripts/webkitpy/port/mac.py:
2339         (MacPort.default_baseline_search_path): Ignore device type.
2340         * Scripts/webkitpy/port/watch.py:
2341         (WatchPort.default_baseline_search_path): Ditto.
2342         * Scripts/webkitpy/port/win.py:
2343         (WinPort.default_baseline_search_path): Ditto.
2344         (WinCairoPort.default_baseline_search_path): Ditto.
2345         * Scripts/webkitpy/port/wpe.py:
2346         (WPEPort.default_baseline_search_path): Ditto.
2347
2348 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2349
2350         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2351         https://bugs.webkit.org/show_bug.cgi?id=193352
2352         <rdar://problem/47210736>
2353
2354         Reviewed by Lucas Forschler.
2355
2356         * Scripts/webkitpy/layout_tests/views/printing.py:
2357         (Printer.print_config): Print list on only baseline search paths which exist. 
2358         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2359         (Testprinter.test_print_config):
2360
2361 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2362
2363         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2364         https://bugs.webkit.org/show_bug.cgi?id=193340
2365
2366         Reviewed by David Kilzer.
2367
2368         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2369         (WTR::InjectedBundle::didReceiveMessageToPage):
2370         Pull the strings out into a WKRetainPtr.
2371
2372         * WebKitTestRunner/WebNotificationProvider.cpp:
2373         (WTR::WebNotificationProvider::closeWebNotification):
2374         Adopt the created value into the WKRetainPtr.
2375
2376         * WebKitTestRunner/mac/TestControllerMac.mm:
2377         (WTR::generateWhitelist):
2378         Immediately adopt a created value to avoid potential mistakes.
2379
2380 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2381
2382         Enable DFG on ARM/Linux again
2383         https://bugs.webkit.org/show_bug.cgi?id=192496
2384
2385         Reviewed by Yusuke Suzuki.
2386
2387         After changing the bytecode format DFG was disabled on all 32-bit
2388         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2389         on ARM by default.
2390
2391         * Scripts/run-jsc-stress-tests:
2392
2393 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2394
2395         Unreviewed, fix #ifdef in API test added in r239851.
2396         https://bugs.webkit.org/show_bug.cgi?id=193327
2397         rdar://problem/47093222
2398
2399         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2400
2401 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2402
2403         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2404         https://bugs.webkit.org/show_bug.cgi?id=193109
2405         <rdar://problem/44807048>
2406
2407         Reviewed by Ryosuke Niwa.
2408
2409         Introduce and respect a test option to enable the UndoManager API.
2410
2411         * WebKitTestRunner/TestController.cpp:
2412         (WTR::updateTestOptionsFromTestHeader):
2413         * WebKitTestRunner/TestOptions.h:
2414         (WTR::TestOptions::hasSameInitializationOptions const):
2415         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2416         (WTR::TestController::platformCreateWebView):
2417
2418 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2419
2420         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2421         https://bugs.webkit.org/show_bug.cgi?id=193346
2422
2423         Reviewed by Antti Koivisto.
2424
2425         * LayoutReloaded/misc/LFC-passing-tests.txt:
2426
2427 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2428
2429         Unreviewed, fix typo that breaks dashboard link.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2432         (WebKitBuildbot):
2433
2434 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2435
2436         Update macOS queue configurations
2437         https://bugs.webkit.org/show_bug.cgi?id=193329
2438
2439         Reviewed by Alexey Proskuryakov.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/config.json:
2442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2443         (BubbleQueueServer):
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2446         (WebKitBuildbot):
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2448         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2449         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2450
2451 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2452
2453         MiniBrowser should be able to navigate to about:blank
2454         https://bugs.webkit.org/show_bug.cgi?id=193345
2455
2456         Reviewed by Simon Fraser.
2457
2458         * MiniBrowser/mac/BrowserWindowController.m:
2459         (-[BrowserWindowController addProtocolIfNecessary:]):
2460         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2461
2462         * MiniBrowser/mac/WK1BrowserWindowController.m:
2463         (-[WK1BrowserWindowController fetch:]):
2464         * MiniBrowser/mac/WK2BrowserWindowController.m:
2465         (-[WK2BrowserWindowController fetch:]):
2466         Clean up the code that uses this to match style.
2467
2468 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2469
2470         Remove MiniBrowser custom "Process Swap" menu item which does not work
2471         https://bugs.webkit.org/show_bug.cgi?id=193344
2472
2473         Reviewed by Simon Fraser.
2474
2475         There is a menu item under the Experimental menu that does work.
2476
2477         * MiniBrowser/mac/AppDelegate.m:
2478         (defaultConfiguration):
2479         * MiniBrowser/mac/SettingsController.h:
2480         * MiniBrowser/mac/SettingsController.m:
2481         (-[SettingsController _populateMenu]):
2482         (-[SettingsController validateMenuItem:]):
2483         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2484         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2485
2486 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2487
2488         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2489         https://bugs.webkit.org/show_bug.cgi?id=193327
2490         rdar://problem/47093222
2491
2492         Reviewed by Tim Horton.
2493
2494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2495         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2496         (TestWebKitAPI::didFinishNavigation):
2497         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2498         (TestWebKitAPI::TEST):
2499         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2500         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2501         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2502         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2503         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2504
2505 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2506
2507         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2508         https://bugs.webkit.org/show_bug.cgi?id=193338
2509         <rdar://problem/46664774>
2510
2511         Reviewed by David Kilzer.
2512
2513         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2514         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2515
2516 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2517
2518         Unreviewed, rolling out r239825.
2519         https://bugs.webkit.org/show_bug.cgi?id=193330
2520
2521         Broke tests on armv7/linux bots (Requested by guijemont on
2522         #webkit).
2523
2524         Reverted changeset:
2525
2526         "Enable DFG on ARM/Linux again"
2527         https://bugs.webkit.org/show_bug.cgi?id=192496
2528         https://trac.webkit.org/changeset/239825
2529
2530 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2531
2532         Disable the run-jsc-stress-test remote host key check.
2533         https://bugs.webkit.org/show_bug.cgi?id=192988
2534
2535         Reviewed by Alexey Proskuryakov.
2536
2537         * Scripts/run-jsc-stress-tests:
2538
2539 2019-01-10  John Wilander  <wilander@apple.com>
2540
2541         Override the session configuration for cookieAcceptPolicy
2542         https://bugs.webkit.org/show_bug.cgi?id=190925
2543         <rdar://problem/45497382>
2544
2545         Reviewed by Alexey Proskuryakov and Alex Christensen.
2546
2547         Test infrastructure for setting a first-party-only cookie policy.
2548
2549         * DumpRenderTree/TestRunner.cpp:
2550         (setOnlyAcceptFirstPartyCookiesCallback):
2551         (TestRunner::staticFunctions):
2552         * DumpRenderTree/TestRunner.h:
2553         * DumpRenderTree/mac/TestRunnerMac.mm:
2554         (TestRunner::setOnlyAcceptFirstPartyCookies):
2555         * DumpRenderTree/win/TestRunnerWin.cpp:
2556         (TestRunner::setOnlyAcceptFirstPartyCookies):
2557         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2558         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2559         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2560         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2561         * WebKitTestRunner/TestInvocation.cpp:
2562         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2563
2564 2019-01-09  Matt Rajca  <mrajca@apple.com>
2565
2566         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2567         https://bugs.webkit.org/show_bug.cgi?id=193301
2568
2569         Reviewed by Jer Noble.
2570         
2571         Added API tests.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2575         (TEST):
2576         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2577
2578 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2579
2580         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2581         https://bugs.webkit.org/show_bug.cgi?id=193310
2582
2583         Reviewed by Antti Koivisto.
2584
2585         * LayoutReloaded/misc/LFC-passing-tests.txt:
2586
2587 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2588
2589         Enable DFG on ARM/Linux again
2590         https://bugs.webkit.org/show_bug.cgi?id=192496
2591
2592         Reviewed by Yusuke Suzuki.
2593
2594         After changing the bytecode format DFG was disabled on all 32-bit
2595         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2596         on ARM by default.
2597
2598         * Scripts/run-jsc-stress-tests:
2599
2600 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2601
2602         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2603         https://bugs.webkit.org/show_bug.cgi?id=193271
2604
2605         Reviewed by Brent Fulgham.
2606
2607         BSTR is a special data structure created by SysAllocString, not a
2608         wchar_t null-terminated string.
2609
2610         * DumpRenderTree/win/TestRunnerWin.cpp:
2611         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2612         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2613         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2614         BSTR from wide string literals.
2615
2616 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2617
2618         Tweak wording for build/version_check style checker error
2619         https://bugs.webkit.org/show_bug.cgi?id=193256
2620
2621         Reviewed by Tim Horton.
2622
2623         * Scripts/webkitpy/style/checkers/cpp.py:
2624         (check_os_version_checks):
2625         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2626         (WebKitStyleTest.test_os_version_checks):
2627
2628 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-build] Add link to bug along with bug title
2631         https://bugs.webkit.org/show_bug.cgi?id=193293
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-build/steps.py:
2636         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2637         (ConfigureBuild.add_bug_id_url): Deleted.
2638         (ConfigureBuild.getBugURL): Deleted.
2639
2640 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2641
2642         [ews-build] Use https for ews-build server
2643         https://bugs.webkit.org/show_bug.cgi?id=193193
2644
2645         Reviewed by Lucas Forschler.
2646
2647         * BuildSlaveSupport/ews-build/steps.py:
2648
2649 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2650
2651         [ews-build] Parse and display number of style failures
2652         https://bugs.webkit.org/show_bug.cgi?id=193280
2653
2654         Reviewed by Lucas Forschler.
2655
2656         * BuildSlaveSupport/ews-build/steps.py:
2657         (CheckStyle): Use TestWithFailureCount as base class.
2658         (CheckStyle.countFailures): Count the number of style failures.
2659
2660 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2661
2662         [ews-build] use patch_id instead of ewspatchid
2663         https://bugs.webkit.org/show_bug.cgi?id=193235
2664
2665         Reviewed by Lucas Forschler.
2666
2667         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2668         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2669         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2670
2671 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2672
2673         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2674         https://bugs.webkit.org/show_bug.cgi?id=192625
2675
2676         Reviewed by Antti Koivisto.
2677
2678         * LayoutReloaded/misc/LFC-passing-tests.txt:
2679
2680 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2681
2682         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2683         https://bugs.webkit.org/show_bug.cgi?id=192841
2684
2685         Reviewed by Carlos Garcia Campos.
2686
2687         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2688         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2689         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2690
2691         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2692
2693         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2694         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2695         (WebKitWebEditorTest::testSelectionChanged):
2696         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2697         (WebKitFrameTest::testMainFrame):
2698         (WebKitFrameTest::testURI):
2699         (WebKitFrameTest::testJavaScriptContext):
2700         (WebKitFrameTest::testJavaScriptValues):
2701         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2702         (testWebViewAuthenticationRequest):
2703         (testWebViewAuthenticationLoadCancelled):
2704         (testWebViewAuthenticationFailure):
2705         (testWebViewAuthenticationStorage):
2706         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2707         (testWebViewAuthenticationProxy):
2708         (testWebViewAuthenticationProxyHTTPS):
2709         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2710         (testAutomationSessionRequestSession):
2711         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2712         (testBackForwardListNavigation):
2713         (testWebKitWebViewSessionState):
2714         (testWebKitWebViewSessionStateWithFormData):
2715         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2716         (ConsoleMessageTest::consoleMessageReceivedCallback):
2717         (testWebKitConsoleMessageConsoleAPI):
2718         (testWebKitConsoleMessageJavaScriptException):
2719         (testWebKitConsoleMessageNetworkError):
2720         (testWebKitConsoleMessageSecurityError):
2721         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2722         (testCookieManagerAcceptPolicy):
2723         (testCookieManagerCookiesChanged):
2724         (testCookieManagerPersistentStorage):
2725         (testCookieManagerPersistentStorageDeleteAll):
2726         (testCookieManagerEphemeral):
2727         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2728         (testWebKitDOMElementAutoFill):
2729         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2730         (downloadLocalFileSuccessfully):
2731         (createFileAtDestination):
2732         (testDownloadOverwriteDestinationDisallowed):
2733         (testDownloadLocalFileError):
2734         (testDownloadRemoteFile):
2735         (testDownloadRemoteFileError):
2736         (testWebViewDownloadURI):
2737         (testPolicyResponseDownload):
2738         (testPolicyResponseDownloadCancel):
2739         (testDownloadMIMEType):
2740         (contextMenuCallback):
2741         (testContextMenuDownloadActions):
2742         (testBlobDownload):
2743         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2744         (testWebKitWebEditorSelectionChanged):
2745         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2746         (testWebKitFrameMainFrame):
2747         (testWebKitFrameURI):
2748         (testWebKitFrameJavaScriptContext):
2749         (testWebKitFrameJavaScriptValues):
2750         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2751         (LoadStopTrackingTest::loadFailed):
2752         (testWebViewTitle):
2753         (testURIRequestHTTPHeaders):
2754         (testURIRequestHTTPMethod):
2755         (testURIResponseHTTPHeaders):
2756         (testRedirectToDataURI):
2757         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2758         (testProcessPerWebView):
2759         (testWebProcessLimit):
2760         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2761         (testWebViewResources):
2762         (testWebResourceLoading):
2763         (testWebResourceSuggestedFilename):
2764         (testWebResourceGetData):
2765         (testWebResourceGetDataError):
2766         (testWebViewResourcesHistoryCache):
2767         (testWebResourceSendRequest):
2768         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2769         (testSSL):
2770         (testInsecureContent):
2771         (testTLSErrorsPolicy):
2772         (testTLSErrorsRedirect):
2773         (testTLSErrorsHTTPAuth):
2774         (testLoadFailedWithTLSErrors):
2775         (testSubresourceLoadFailedWithTLSErrors):
2776         (httpsServerCallback):
2777         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2778         (testWebViewCreateNavigationData):
2779         (testWebViewJavaScriptDialogs):
2780         (testWebViewWindowProperties):
2781         (testWebViewMouseTarget):
2782         (testWebViewFileChooserRequest):
2783         (testWebViewColorChooserRequest):
2784         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2785         (testWebExtensionGetTitle):
2786         (testDocumentLoadedSignal):
2787         (testWebKitWebViewProcessCrashed):
2788         (testWebExtensionWindowObjectCleared):
2789         (testWebExtensionIsolatedWorld):
2790         (permissionRequestCallback):
2791         (didAssociateFormControlsCallback):
2792         (testWebExtensionFormControlsAssociated):
2793         (FormSubmissionTest::FormSubmissionTest):
2794         (FormSubmissionTest::testFormSubmissionResult):
2795         (testWebExtensionFormSubmissionSteps):
2796         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2797         (testNotInitialized):
2798         (testClearDatabase):
2799         (testPrivateBrowsing):
2800         (testGetFavicon):
2801         (testWebViewFavicon):
2802         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2803         (testFindControllerTextFound):
2804         (testFindControllerTextNotFound):
2805         (testFindControllerMatchCount):
2806         (testFindControllerMaxMatchCount):
2807         (testFindControllerNext):
2808         (testFindControllerPrevious):
2809         (testFindControllerCountedMatches):
2810         (testFindControllerOptions):
2811         (testFindControllerHide):
2812         (testFindControllerInstance):
2813         (testFindControllerGetters):
2814         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2815         (testNavigationPolicy):
2816         (testResponsePolicy):
2817         (testNewWindowPolicy):
2818         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2819         (testSecurityOriginBasicConstructor):
2820         (testSecurityOriginURIConstructor):
2821         (testSecurityOriginDefaultPort):
2822         (testSecurityOriginFileURI):
2823         (testOpaqueSecurityOrigin):
2824         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2825         (testWebKitSettings):
2826         (testWebKitSettingsNewWithSettings):
2827         (testWebKitSettingsUserAgent):
2828         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2829         (testWebViewNewWithUserContentManager):
2830         (isStyleSheetInjectedForURLAtPath):
2831         (isScriptInjectedForURLAtPath):
2832         (testUserContentManagerInjectedStyleSheet):
2833         (testUserContentManagerInjectedScript):
2834         (UserScriptMessageTest::scriptMessageReceived):
2835         (UserScriptMessageTest::waitUntilMessageReceived):
2836         (UserScriptMessageTest::runJavaScriptFinished):
2837         (testUserContentManagerScriptMessageReceived):
2838         (testUserContentManagerScriptMessageInWorldReceived):
2839         (testUserContentManagerScriptMessageFromDOMBindings):
2840         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2841         (testWebContextDefault):
2842         (testWebContextEphemeral):
2843         (testWebContextGetPlugins):
2844         (testWebContextURIScheme):
2845         (testWebContextSpellChecker):
2846         (testWebContextLanguages):
2847         (consoleMessageReceivedCallback):
2848         (testWebContextSecurityFileXHR):
2849         (ProxyTest::ProxyTest):
2850         (testWebContextProxySettings):
2851         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2852         (testWebViewWebContext):
2853         (testWebViewWebBackend):
2854         (testWebViewEphemeral):
2855         (testWebViewCustomCharset):
2856         (testWebViewSettings):
2857         (testWebViewRunJavaScript):
2858         (testWebViewCanShowMIMEType):
2859         (testWebViewSubmitForm):
2860         (testWebViewSave):
2861         (testWebViewPageVisibility):
2862         (testWebViewSnapshot):
2863         (testWebViewNotification):
2864         (testWebViewNotificationInitialPermissionAllowed):
2865         (testWebViewNotificationInitialPermissionDisallowed):
2866         (testWebViewIsPlayingAudio):
2867         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2868         (WebsiteDataTest::WebsiteDataTest):
2869         (WebsiteDataTest::remove):
2870         (WebsiteDataTest::clear):
2871         (testWebsiteDataConfiguration):
2872         (testWebsiteDataEphemeral):
2873         (testWebsiteDataCache):
2874         (testWebsiteDataStorage):
2875         (testWebsiteDataDatabases):
2876         (testWebsiteDataAppcache):
2877         (testWebsiteDataCookies):
2878         (testWebsiteDataDeviceIdHashSalt):
2879         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2880         (emitDocumentLoaded):
2881         (emitURIChanged):
2882         (sendRequestCallback):
2883         (contextMenuCallback):
2884         (consoleMessageSentCallback):
2885         (emitFormControlsAssociated):
2886         (formControlsAssociatedCallback):
2887         (emitFormSubmissionEvent):
2888         (willSubmitFormCallback):
2889         (windowObjectCleared):
2890         (methodCallCallback):
2891         (registerGResource):
2892         (webkit_web_extension_initialize_with_user_data):
2893         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2894         (checkLeaks):
2895         (WebProcessTest::create):
2896         (runTest):
2897         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2898         (AutocleanupsTest::testWebProcessAutocleanups):
2899         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2900         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2901         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2902         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2903         (WebKitDOMDOMWindowTest::testSignals):
2904         (WebKitDOMDOMWindowTest::testDispatchEvent):
2905         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2906         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2907         (WebKitDOMNodeFilterTest::testTreeWalker):
2908         (WebKitDOMNodeFilterTest::testNodeIterator):
2909         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2910         (WebKitDOMNodeTest::testHierarchyNavigation):
2911         (WebKitDOMNodeTest::testInsertion):
2912         (WebKitDOMNodeTest::testTagNamesNodeList):
2913         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2914         (WebKitDOMNodeTest::testDOMCache):
2915         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2916         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2917         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2918         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2919         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2920         (testUIProcessAutocleanups):
2921         (testWebProcessAutocleanups):
2922         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2923         (testContextMenuPopulateMenu):
2924         (testContextMenuDismissed):
2925         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2926         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2927         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2928         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2929         (testWebKitDOMDOMWindowSignals):
2930         (testWebKitDOMDOMWindowDispatchEvent):
2931         (testWebKitDOMDOMWindowGetComputedStyle):
2932         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2933         (testWebKitDOMNodeHierarchyNavigation):
2934         (testWebKitDOMNodeInsertion):
2935         (testWebKitDOMNodeTagNamesNodeList):
2936         (testWebKitDOMNodeTagNamesHTMLCollection):
2937         (testWebKitDOMObjectCache):
2938         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2939         (testWebKitDOMNodeFilterTreeWalker):
2940         (testWebKitDOMNodeFilterNodeIterator):
2941         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2942         (testWebKitDOMXPathNSResolverNative):
2943         (testWebKitDOMXPathNSResolverCustom):
2944         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2945         (testInspectorDefault):
2946         (testInspectorManualAttachDetach):
2947         (testInspectorCustomContainerDestroyed):
2948         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2949         (startTestServer):
2950         (testInspectorServerPageList):
2951         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2952         (OptionMenuTest::showOptionMenuCallback):
2953         (OptionMenuTest::menuCloseCallback):
2954         (OptionMenuTest::close):
2955         (OptionMenuTest::activateItem):
2956         (OptionMenuTest::selectItem):
2957         (testOptionMenuSimple):
2958         (testOptionMenuGroups):
2959         (testOptionMenuActivate):
2960         (testOptionMenuSelect):
2961         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2962         (testPrintOperationPrintSettings):
2963         (webViewPrintCallback):
2964         (testPrintOperationPrint):
2965         (testPrintCustomWidget):
2966         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2967         (checkAtspiAccessible):
2968         (testAtspiBasicHierarchy):
2969         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2970         (testWebKitCheckVersion):
2971         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2972         (testWebViewEditorCutCopyPasteNonEditable):
2973         (testWebViewEditorCutCopyPasteEditable):
2974         (testWebViewEditorSelectAllNonEditable):
2975         (testWebViewEditorSelectAllEditable):
2976         (loadContentsAndTryToCutSelection):
2977         (testWebViewEditorNonEditable):
2978         (testWebViewEditorEditable):
2979         (testWebViewEditorEditorStateTypingAttributes):
2980         (testWebViewEditorInsertImage):
2981         (testWebViewEditorCreateLink):
2982         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2983         (loadChangedCallback):
2984         (loadFailedCallback):
2985         (loadFailedWithTLSErrorsCallback):
2986         (LoadTrackingTest::LoadTrackingTest):
2987         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2988         (registerGResource):
2989         (removeNonEmptyDirectory):
2990         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2991         (Test::adoptView):
2992         (Test::~Test):
2993         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2994         (WebKitTestBus::getOrCreateConnection):
2995         (WebKitTestBus::createProxy):
2996         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2997         (WebKitTestServer::getWebSocketURIForPath const):
2998         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2999         (WebViewTest::initializeWebView):
3000         (WebViewTest::loadURI):
3001         (WebViewTest::loadHtml):
3002         (WebViewTest::loadPlainText):
3003         (WebViewTest::loadBytes):
3004         (WebViewTest::loadRequest):
3005         (WebViewTest::loadAlternateHTML):
3006         (WebViewTest::goBack):
3007         (WebViewTest::goForward):
3008         (WebViewTest::goToBackForwardListItem):
3009         (resourceGetDataCallback):
3010         (WebViewTest::mainResourceData):
3011         (WebViewTest::javascriptResultToCString):
3012         (WebViewTest::javascriptResultToNumber):
3013         (WebViewTest::javascriptResultToBoolean):
3014         (WebViewTest::javascriptResultIsNull):
3015         (WebViewTest::javascriptResultIsUndefined):
3016         (onSnapshotReady):
3017         (WebViewTest::runWebProcessTest):
3018         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3019         (WebViewTest::platformInitializeWebView):
3020         (WebViewTest::showInWindow):
3021         (WebViewTest::showInWindowAndWaitUntilMapped):
3022         (WebViewTest::mouseMoveTo):
3023         (WebViewTest::emitPopupMenuSignal):
3024         (WebViewTest::keyStroke):
3025         (WebViewTest::doMouseButtonEvent):
3026
3027 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3028
3029         [WPE] API tests can't run in flatpak environment
3030         https://bugs.webkit.org/show_bug.cgi?id=193242
3031
3032         Reviewed by Michael Catanzaro.
3033
3034         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3035         flatpakutils so that it knows which port it's dealing with.
3036         * glib/common.py: Remove build_dir globals so that subsequent
3037         calls actually take args into account.
3038         (library_build_path):
3039         (binary_build_path):
3040
3041 2019-01-08  Dean Jackson  <dino@apple.com>
3042
3043         Blob references for System Previews don't get a correct file extension
3044         https://bugs.webkit.org/show_bug.cgi?id=193268
3045         <rdar://problem/47133037>
3046
3047         Reviewed by Tim Horton.
3048
3049         New test that a Blob download of a USDZ file gets named correctly.
3050
3051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3052         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3053         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3054         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3055         (TEST):
3056         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3057
3058 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3059
3060         [WebAuthN] Support U2F HID Authenticators on macOS
3061         https://bugs.webkit.org/show_bug.cgi?id=191535
3062         <rdar://problem/47102027>
3063
3064         Reviewed by Brent Fulgham.
3065
3066         This patch:
3067         1) adds support for U2F mocking mechanism;
3068         2) updates tests to reflect U2fCommandConstructor changes.
3069
3070         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3073         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3074         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3075
3076 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3079         https://bugs.webkit.org/show_bug.cgi?id=193229
3080         <rdar://problem/46717097>
3081
3082         Reviewed by Tim Horton.
3083
3084         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3085         prevents a drag from starting.
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3088         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3089
3090         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3091
3092 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3093   
3094         Layout test will generate a perf metric file to results dir.
3095         https://bugs.webkit.org/show_bug.cgi?id=192030
3096         <rdar://problem/32779516>
3097
3098         Reviewed by Aakash Jain.
3099
3100         Layout test running time will be collected to a perf metric file.
3101         For now, instead of outputing running time of all tests (which is huge),
3102         we aggregate them by test directories which are at most two level deep. 
3103
3104         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3105         (Manager._end_test_run):
3106         (Manager._output_perf_metrics):
3107         (Manager._print_expectation_line_for_test):
3108         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3109         (add_test_perf_metric):
3110         (test_perf_metrics):
3111         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3112         (JSONGeneratorTest.test_test_timings_trie):
3113         (JSONGeneratorTest):
3114         (JSONGeneratorTest.test_test_perf_metrics):
3115         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3116         (RebaselineTest.test_reset_results):
3117         (RebaselineTest.test_missing_results):
3118         (RebaselineTest.test_new_baseline):
3119
3120 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3121
3122         [WPE][GTK] Add php-json to install-dependencies
3123         https://bugs.webkit.org/show_bug.cgi?id=193233
3124
3125         Reviewed by Michael Catanzaro.
3126
3127         * gtk/install-dependencies:
3128         * wpe/install-dependencies:
3129
3130 2019-01-08  Chris Dumez  <cdumez@apple.com>
3131
3132         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3133         https://bugs.webkit.org/show_bug.cgi?id=193224
3134         <rdar://problem/47097726>
3135
3136         Reviewed by Alex Christensen.
3137
3138         Add API test coverage.
3139
3140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3141
3142 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3143
3144         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3145         <https://webkit.org/b/193222>
3146         <rdar://problem/46862309>
3147
3148         Reviewed by Joseph Pecoraro.
3149
3150         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3151         (WTR::executeCallback): Fix camel case of variable name.
3152         (WTR::EventSendingController::callAfterScrollingCompletes): If
3153         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3154         false, make sure to release the ScrollCompletionCallbackData
3155         object.  This fixes the leak.
3156
3157 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3158
3159         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3160         https://bugs.webkit.org/show_bug.cgi?id=193044
3161
3162         Reviewed by Daniel Bates.
3163
3164         WinCairo EWS bots are using Windows Perl. Binary files should be
3165         opened as binary mode.
3166
3167         * Scripts/svn-apply:
3168         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3169
3170 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3171
3172         [CMake] Add ENABLE_CSS_TYPED_OM option
3173         https://bugs.webkit.org/show_bug.cgi?id=193216
3174
3175         Reviewed by Michael Catanzaro.
3176
3177         * Scripts/webkitperl/FeatureList.pm:
3178
3179 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3180
3181         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3182         <https://webkit.org/b/193056>
3183
3184         Reviewed by Alex Christensen.
3185
3186         * Scripts/webkitpy/style/checker.py:
3187         - Ignore use of new runtime/retainptr check in
3188           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3189           contains tests to ensure RetainPtr<NSObject *> is compatible
3190           with RetainPtr<NSObject>.
3191
3192         * Scripts/webkitpy/style/checkers/cpp.py:
3193         (check_language):
3194         (CppChecker):
3195         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3196           was used instead of a single regex so that angle brackets
3197           could be matched up when checking the type contained within
3198           the RetainPtr<> type.
3199
3200         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3201         (CppStyleTest):
3202         - Add unit test for new runtime/retainptr check.
3203
3204         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3205         * TestWebKitAPI/EditingTestHarness.h:
3206         - Remove '*' from RetainPtr<> type.
3207
3208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3209         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3210           regressed in r201938.
3211
3212         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3213         (TestWebKitAPI::TEST):
3214         - Update tests to match RetainPtr.mm tests (except for the
3215           `*SimilarNSType` tests since there is no CF equivalent of
3216           RetainPtr<NSString> and RetainPtr<NSString *>).
3217
3218         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3219         (TestWebKitAPI::TEST):
3220         - Update tests to:
3221           - Not conflict by name with equivalent CF tests in
3222             RetainPtr.cpp.
3223           - Add test cases for RetainPtr<NSObject>,
3224             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3225           - Add `*SimilarNSType` tests for converting between
3226             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3227           - Change `0` to `nil` as appropriate.
3228           - Re-alphabetize the tests by name.
3229           - Add Optional<RetainPtr<>> tests.
3230           - Add retainPtr() tests.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3233         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3234         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3235         (TEST):
3236         - Remove '*' from RetainPtr<> type.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3239         (TEST(WebKit, JITEnabled)):
3240         - Add missing WTFMove().  Apparently a temporary was being
3241           created before in the argument list due to mismatched
3242           RetainPtr<> types.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3245         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3246         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3247         (TestWebKitAPI::TEST):
3248         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3249         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3250         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3251         (WTR::resourcesDirectoryURL):
3252         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3253         (WTR::InjectedBundle::platformInitialize):
3254         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3255         - Remove '*' from RetainPtr<> type.
3256
3257 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3258
3259         A MediaTime timescale must never be zero
3260         https://bugs.webkit.org/show_bug.cgi?id=193156
3261         <rdar://problem/32504501>
3262
3263         Reviewed by Jer Noble.
3264
3265         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3266         (TestWebKitAPI::TEST): Add tests for zero timescale.
3267
3268 2019-01-07  Youenn Fablet  <youenn@apple.com>
3269
3270         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3271         https://bugs.webkit.org/show_bug.cgi?id=193175
3272
3273         Reviewed by Chris Dumez.
3274
3275         Updated API test as we bumped the SW schema to version 4.
3276
3277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3278         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3279         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3280         (TEST):
3281
3282 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3283
3284         [Win][Clang] Fix compilation warnings of MiniBrowser
3285         https://bugs.webkit.org/show_bug.cgi?id=193029
3286
3287         Reviewed by Ross Kirsling.
3288
3289         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3290         and m_URLBarFont. Reorder member variables to fix -Wreorder
3291         warning.
3292         * MiniBrowser/win/PageLoadTestClient.cpp:
3293         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3294         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3295         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3296         m_currentURLIndex.
3297         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3298         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3299         navigationClient with '{ }' to fix the missing field warning.
3300         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3301         (initDocStruct): Changed the argument type docname to const.
3302
3303 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3304
3305         [WebAuthN] Import U2F command/response converters from Chromium
3306         https://bugs.webkit.org/show_bug.cgi?id=193150
3307         <rdar://problem/47054028>
3308
3309         Reviewed by Brent Fulgham.
3310
3311         Adds API tests.
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3315         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3316         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3317         (TestWebKitAPI::getTestAttestationObjectBytes):
3318         (TestWebKitAPI::getTestSignResponse):
3319         (TestWebKitAPI::getTestU2fRegisterResponse):
3320         (TestWebKitAPI::TEST):
3321         (TestWebKitAPI::convertToVector): Deleted.
3322         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3323         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3324         (TestWebKitAPI::constructMakeCredentialRequest):
3325         (TestWebKitAPI::constructGetAssertionRequest):
3326         (TestWebKitAPI::TEST):
3327
3328 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3329
3330         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3331         https://bugs.webkit.org/show_bug.cgi?id=193136
3332
3333         Reviewed by Michael Catanzaro.
3334
3335         * gtk/install-dependencies:
3336         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3337         they are needed by update-webkitgtk-libs.
3338
3339 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3340
3341         Unreviewed follow-up fix to r239650
3342         https://bugs.webkit.org/show_bug.cgi?id=193140
3343         <rdar://problem/47063037>
3344
3345         Typecast patch_id to string.
3346
3347         * BuildSlaveSupport/ews-build/steps.py:
3348         (ValidatePatch._is_patch_obsolete):
3349
3350 2019-01-04  Daniel Bates  <dabates@apple.com>
3351
3352         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3353         https://bugs.webkit.org/show_bug.cgi?id=193024
3354
3355         Reviewed by Jer Noble.
3356
3357         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3358         for the bitmask type WebEventFlags as an example.
3359
3360         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3361         that can be used to register summary and synthetic child formatters for a bitmask type.
3362         For example, consider the following enum and bitmask typedefs:
3363
3364         typedef enum {
3365             A = 1 << 0,
3366             B = 1 << 1,
3367             C = 1 << 2,
3368         } SpecialFlagValues;
3369         typedef unsigned SpecialFlags;
3370
3371         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3372         __lldb_init_module():
3373
3374             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3375                     1 << 0: "A",
3376                     1 << 1: "B",
3377                     1 << 2: "C",
3378             })
3379
3380         * lldb/lldb_webkit.py:
3381         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3382         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3383         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3384         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3385         A convenience function to dynamically creaste a synthetic formatter class and summary
3386         string function for the specified bitmask type and enumerator value to name map. This
3387         function register the dynamically created class and function with LLDB.
3388
3389         (__lldb_init_module):
3390         (FlagEnumerationProvider):
3391         (FlagEnumerationProvider._enumerator_value_to_name_map):
3392         (FlagEnumerationProvider._bitmask):
3393         (FlagEnumerationProvider._update):
3394         (FlagEnumerationProvider.has_children):
3395         (FlagEnumerationProvider.num_children):
3396         (FlagEnumerationProvider.get_child_index):
3397         (FlagEnumerationProvider.get_child_at_index):
3398         (FlagEnumerationProvider.update):
3399         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3400
3401         (WTFOptionSetProvider):
3402         (WTFOptionSetProvider._enumerator_value_to_name_map):
3403         (WTFOptionSetProvider._bitmask):
3404         (WTFOptionSetProvider._update):
3405         Write in terms of the base class.
3406
3407         (RawBitmaskProviderBase):
3408         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3409         (RawBitmaskProviderBase._bitmask):
3410         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3411         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3412         {
3413             1 << 0: "A",
3414             1 << 1: "B",
3415             1 << 2: "C",
3416         }
3417         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3418         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3419
3420         (WTFOptionSetProvider.has_children): Deleted.
3421         (WTFOptionSetProvider.num_children): Deleted.
3422         (WTFOptionSetProvider.get_child_index): Deleted.
3423         (WTFOptionSetProvider.get_child_at_index): Deleted.
3424         (WTFOptionSetProvider.update): Deleted.
3425
3426 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3427
3428         [ews-build] Add build step to validate the patch before processing it
3429         https://bugs.webkit.org/show_bug.cgi?id=193140
3430
3431         Reviewed by Lucas Forschler.
3432
3433         * BuildSlaveSupport/ews-build/factories.py:
3434         (Factory.__init__): Added ValidatePatch step.
3435         * BuildSlaveSupport/ews-build/steps.py:
3436         (ValidatePatch):
3437         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3438         (ValidatePatch.get_patch_json): Get patch json data.
3439         (ValidatePatch.get_bug_json): Get bug json data.
3440         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3441         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3442         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3443         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3444         (ValidatePatch.skip_build): Skip the build.
3445         (ValidatePatch.start):
3446
3447 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3448
3449         Progress towards fixing Mac CMake build
3450         https://bugs.webkit.org/show_bug.cgi?id=193105
3451
3452         Reviewed by Don Olmstead.
3453
3454         * TestWebKitAPI/PlatformMac.cmake:
3455
3456 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3457
3458         Fix API test after r239631
3459         https://bugs.webkit.org/show_bug.cgi?id=193118
3460
3461         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3462         (TestWebKitAPI::TEST):
3463         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3464         Do the same thing via the API to fix the test.
3465
3466 2019-01-04  Jer Noble  <jer.noble@apple.com>
3467
3468         [WebKitLegacy] Media playback pauses on scroll
3469         https://bugs.webkit.org/show_bug.cgi?id=192829
3470
3471         Reviewed by Eric Carlson.
3472
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3474         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3475         (TestWebKitAPI::TEST):
3476         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3477         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3478         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3479         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3480         (TestWebKitAPI::TEST):
3481
3482 2019-01-04  Chris Dumez  <cdumez@apple.com>
3483
3484         Add support for toggling device orientation API support per site
3485         https://bugs.webkit.org/show_bug.cgi?id=193143
3486         <rdar://problem/46605724>
3487
3488         Reviewed by Alex Christensen.
3489
3490         Add API test coverage.
3491
3492         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3493         (-[DataMappingSchemeHandler setTaskHandler:]):
3494         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3495         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3496         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3497         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3498
3499 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3500
3501         [ews-build] use svn-apply script to apply the patches
3502         https://bugs.webkit.org/show_bug.cgi?id=193138
3503
3504         Reviewed by Lucas Forschler.
3505
3506         * BuildSlaveSupport/ews-build/factories.py:
3507         (Factory.__init__): Add the ApplyPatch step.
3508         * BuildSlaveSupport/ews-build/steps.py:
3509         (CheckOutSource): Added step name.
3510         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3511         (ApplyPatch): Build step to apply patch using svn-apply script.
3512         (UnApplyPatchIfRequired):
3513         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3514
3515 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3516
3517         Deprecate WKContextCreate
3518         https://bugs.webkit.org/show_bug.cgi?id=193118
3519
3520         Reviewed by Brady Eidson.
3521
3522         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3523         (WebKitBrowserWindow::WebKitBrowserWindow):
3524         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3525         (TestWebKitAPI::TEST):
3526         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3527         (TestWebKitAPI::TEST):
3528         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3529         (TestWebKitAPI::TEST):
3530         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3531         (TestWebKitAPI::TEST):
3532         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3533         (TestWebKitAPI::TEST):
3534         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3535         (TestWebKitAPI::TEST):
3536         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3537         (TestWebKitAPI::TEST):
3538         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3539         (TestWebKitAPI::TEST):
3540         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3541         (TestWebKitAPI::TEST):
3542         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3545         (TestWebKitAPI::TEST):
3546         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3547         (TestWebKitAPI::TEST):
3548         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3549         (TestWebKitAPI::TEST):
3550         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3551         (TestWebKitAPI::TEST):
3552         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3553         (TestWebKitAPI::TEST):
3554         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3559         (TestWebKitAPI::TEST):
3560         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3561         (TestWebKitAPI::loadAlternateHTMLString):
3562         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3563         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3564         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3565         (TestWebKitAPI::buildAndPerformTest):
3566         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3567         (TestWebKitAPI::TEST):
3568         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3569         (TestWebKitAPI::TEST):
3570         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3577         (TestWebKitAPI::TEST):
3578         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3579         (TestWebKitAPI::TEST):
3580         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3583         (TestWebKitAPI::TEST):
3584         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3587         (TestWebKitAPI::TEST):
3588         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3591         (TestWebKitAPI::TEST):
3592         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3595         (TestWebKitAPI::TEST):
3596         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3597         (TestWebKitAPI::TEST):
3598         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3601         (TestWebKitAPI::TEST):
3602         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3603         (TestWebKitAPI::TEST):
3604         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3607         (TestWebKitAPI::TEST):
3608         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3609         (TestWebKitAPI::TEST):
3610         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3611         (TestWebKitAPI::TEST):
3612         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3615         (TestWebKitAPI::TEST):
3616         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3617         (TestWebKitAPI::TEST):
3618         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3619         (WebKit2_CommandBackForwardTestWKView::SetUp):
3620         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3625         (TestWebKitAPI::TEST):
3626         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3627         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3628
3629 2019-01-03  Matt Rajca  <mrajca@apple.com>
3630
3631         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3632         https://bugs.webkit.org/show_bug.cgi?id=193128
3633         rdar://34554231
3634
3635         Reviewed by Jer Noble.
3636
3637         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3638         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3639         event along with a flag that indicates whether or not autoplay was actually prevented.
3640
3641         Tests: existing API tests were updated to reflect the new names. New API tests
3642         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3643
3644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3645         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3646         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3647         (TEST):
3648         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3649         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3650
3651 2019-01-04  Chris Dumez  <cdumez@apple.com>
3652
3653         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3654         https://bugs.webkit.org/show_bug.cgi?id=193120
3655
3656         Reviewed by Alex Christensen.
3657
3658         Add API test coverage.
3659
3660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3661
3662 2019-01-04  Chris Dumez  <cdumez@apple.com>
3663
3664         Crash under WebProcessPool::addSuspendedPage()
3665         https://bugs.webkit.org/show_bug.cgi?id=193110
3666
3667         Reviewed by Youenn Fablet.
3668
3669         Add API test coverage.
3670
3671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3672
3673 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3674
3675         [ews-build] Check patch relevance before applying the patch
3676         https://bugs.webkit.org/show_bug.cgi?id=193102
3677
3678         Reviewed by Lucas Forschler.
3679
3680         * BuildSlaveSupport/ews-build/factories.py:
3681         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3682
3683 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3684
3685         [ews-build] Check patch relevance step should print patch id
3686         https://bugs.webkit.org/show_bug.cgi?id=193137
3687
3688         Reviewed by Lucas Forschler.
3689
3690         * BuildSlaveSupport/ews-build/steps.py:
3691         (CheckPatchRelevance.start): Update the status to include patch id.
3692
3693 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3694
3695         webkitpy: Increase simulator teardown timeout
3696         https://bugs.webkit.org/show_bug.cgi?id=193141
3697         <rdar://problem/46174217>
3698
3699         Rubber-stamped by Aakash Jain.
3700
3701         * Scripts/webkitpy/xcode/simulated_device.py:
3702         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3703
3704 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3705
3706         test262-runner misbehaves when test file YAML has a trailing space
3707         https://bugs.webkit.org/show_bug.cgi?id=193053
3708
3709         Reviewed by Yusuke Suzuki.
3710
3711         * Scripts/test262/Runner.pm:
3712         (parseData):
3713         Accept trailing space when parsing a test file's YAML block.
3714
3715 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3716
3717         UserMedia test should use WKPageNavigationClient
3718         https://bugs.webkit.org/show_bug.cgi?id=192913
3719
3720         Reviewed by Youenn Fablet.
3721
3722         The test currently uses the deprecated WKPageLoaderClient. It should use
3723         WKPageNavigationClient instead, which provides the same callback under a similar name.
3724
3725         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3726         (TestWebKitAPI::TEST):
3727
3728 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3729
3730         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3731         https://bugs.webkit.org/show_bug.cgi?id=192944
3732
3733         Reviewed by Tim Horton.
3734
3735         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3736         (TestWebKitAPI::TEST):
3737
3738 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3739
3740         Add support for using the current text selection as the find string on iOS
3741         https://bugs.webkit.org/show_bug.cgi?id=193034
3742         <rdar://problem/45138739>
3743
3744         Reviewed by Tim Horton.
3745
3746         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3747         _setStringForFind) works as expected.
3748
3749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3750         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3751
3752 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3753
3754         [ews-build] Use git on OpenSource EWS bots
3755         https://bugs.webkit.org/show_bug.cgi?id=193092
3756
3757         Reviewed by Lucas Forschler.
3758
3759         * BuildSlaveSupport/ews-build/steps.py:
3760         (CheckOutSource): Use git instead of svn.
3761         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3762
3763 2019-01-02  Daniel Bates  <dabates@apple.com>
3764
3765         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3766         https://bugs.webkit.org/show_bug.cgi?id=193023
3767
3768         Reviewed by Simon Fraser.
3769
3770         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3771         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3772         enumerator values. We should just remove this code.
3773
3774         * lldb/lldb_webkit.py:
3775         (WTFOptionSetProvider.has_children):
3776         (WTFOptionSetProvider.num_children):
3777         (WTFOptionSetProvider.get_child_index):
3778         (WTFOptionSetProvider.get_child_at_index):
3779
3780 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3781
3782         .ycm_extra_conf.py should handle XXXInlines.h
3783         https://bugs.webkit.org/show_bug.cgi?id=193055
3784
3785         Reviewed by Carlos Garcia Campos.
3786
3787         compile_commands.json database only records flags and options for cpp source files.
3788         So, when we open headers, this database does not have any information for that.
3789         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3790         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3791         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3792         we attempt to find XXX.cpp and use the configuration if it exists.
3793
3794         * gtk/ycm_extra_conf.py:
3795         (getImplementationFilename):
3796         (FlagsForFile):
3797
3798 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3799
3800         Unreviewed. Support PHP 7.3 in Debian.
3801
3802         Add 7.3 to the list of php versions supported in Debian.
3803
3804         * Scripts/webkitpy/port/base.py:
3805         (Port._debian_php_version):
3806
3807 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3808
3809         Resurrect Mac CMake build
3810         https://bugs.webkit.org/show_bug.cgi?id=192658
3811
3812         Reviewed by Yusuke Suzuki.
3813
3814         * DumpRenderTree/PlatformMac.cmake:
3815         * MiniBrowser/mac/CMakeLists.txt:
3816         * TestWebKitAPI/PlatformMac.cmake:
3817
3818 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3819
3820         [Tools] Remove references to Bison and Flex
3821         https://bugs.webkit.org/show_bug.cgi?id=193033
3822
3823         Reviewed by Michael Catanzaro.
3824
3825         The Bison and Flex tools are not needed anymore since r209883.
3826
3827         * CygwinDownloader/cygwin-downloader.py:
3828         * EWSTools/ubuntu-ews-packages:
3829         * Scripts/filter-build-webkit:
3830         (shouldIgnoreLine):
3831         * gtk/install-dependencies:
3832         * wpe/install-dependencies:
3833
3834 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3835
3836         WebDriver: warn about non existing tests when parsing expectations
3837         https://bugs.webkit.org/show_bug.cgi?id=192979
3838
3839         Reviewed by Michael Catanzaro.
3840
3841         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3842         renamed.
3843
3844         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3845         (WebDriverTestRunner.__init__):
3846
3847 2018-12-21  Chris Dumez  <cdumez@apple.com>
3848
3849         navigator.userAgent in service workers does not reflect customUserAgent set by client
3850         https://bugs.webkit.org/show_bug.cgi?id=192951
3851
3852         Reviewed by Youenn Fablet.
3853
3854         Extend API test coverage.
3855
3856         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3857         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3858         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3859         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3860         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3861
3862 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3863
3864         [WebAuthN] userPresence should always be true
3865         https://bugs.webkit.org/show_bug.cgi?id=192835
3866         <rdar://problem/46538788>
3867
3868         Reviewed by Brent Fulgham.
3869
3870         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3871         (TestWebKitAPI::TEST):
3872
3873 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3874
3875         Add support to run-benchmark to use non-default copies of the browser apps
3876         https://bugs.webkit.org/show_bug.cgi?id=192905
3877         rdar://problem/46845840
3878
3879         Reviewed by Dewei Zhu.
3880         
3881         Add support for a --browser-path argument to run-benchmark, which allows you to use
3882         a custom app bundle for a given browser (only implemented for Safari at present).
3883
3884         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3885         (BenchmarkRunner.__init__):
3886         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3887         (BrowserDriver.__init__):
3888         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3889         (BrowserDriverFactory.create):
3890         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3891         (OSXBrowserDriver._launch_process):
3892         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3893         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3894         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3895         (OSXChromeCanaryDriver.launch_url):
3896         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3897         (OSXFirefoxNightlyDriver.launch_url):
3898         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3899         (OSXSafariDriver.__init__):
3900         (OSXSafariDriver.launch_url):
3901         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3902         (parse_args):
3903         (run_benchmark_plan):
3904         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3905         (WebServerBenchmarkRunner.__init__):
3906         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3907         (FakeBenchmarkRunner.__init__):
3908
3909 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3910
3911         [WebAuthN] Import an APDU coder from Chromium
3912         https://bugs.webkit.org/show_bug.cgi?id=192949
3913         <rdar://problem/46879933>
3914
3915         Reviewed by Brent Fulgham.
3916
3917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3918         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3919         (TestWebKitAPI::TEST):
3920
3921 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3922
3923         Setting the file wrapper and content type of an attachment to a PDF should update its image
3924         https://bugs.webkit.org/show_bug.cgi?id=192984
3925         <rdar://problem/46798028>
3926
3927         Reviewed by Tim Horton.
3928
3929         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3930         PDF data correctly updates the image element.
3931
3932         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3933
3934 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3935
3936         Add JSCOnly to bot dashboard
3937         https://bugs.webkit.org/show_bug.cgi?id=192964
3938
3939         Reviewed by Alexey Proskuryakov.
3940
3941         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3942         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3943         useful if they were not so secret, so add them.
3944
3945         There appear to be no build-only bots, so the first column is blank. And of course there are
3946         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3947         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3948         and there's plenty of room in the final column for all the bots.
3949
3950         I had a hard time picking a logo to use, because the JavaScript language does not have an
3951         official logo. But I believe I've found one that will be satisfactory.
3952
3953         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3954
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3958         (BubbleQueueServer):
3959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3961         (WebKitBuildbot):
3962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3963         (table.queue-grid tr.platform.linux-jsconly img.logo):
3964
3965 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3966
3967         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3968         https://bugs.webkit.org/show_bug.cgi?id=192821
3969
3970         Reviewed by Chris Dumez.
3971
3972         * DumpRenderTree/mac/DumpRenderTree.mm:
3973         (createWebViewAndOffscreenWindow):
3974         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3975
3976 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3977
3978         [Win][Clang] Fix compilation warnings of DumpRenderTree
3979         https://bugs.webkit.org/show_bug.cgi?id=192924
3980
3981         Reviewed by Alex Christensen.
3982
3983         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3984         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3985         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3986         * DumpRenderTree/win/DumpRenderTree.cpp:
3987         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3988         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3989         object to the argument of setDefaultTextEncodingName instead of a
3990         const string literal.
3991         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3992         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3993         (setCacheFolder): Deleted.
3994         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3995         * DumpRenderTree/win/EditingDelegate.cpp:
3996         (dump): Use %d for int.
3997         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3998         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3999         (BSTRFromString): Deleted unused function.
4000         * DumpRenderTree/win/TestRunnerWin.cpp:
4001         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4002         the arguemnt of setQuota instead of const string literal.
4003         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4004         (jsStringRefToWString): Deleted unused function.
4005
4006 2018-12-20  Chris Dumez  <cdumez@apple.com>
4007
4008         Add API test coverage for customUserAgent client setting and service workers
4009         https://bugs.webkit.org/show_bug.cgi?id=192952
4010
4011         Reviewed by Alex Christensen.
4012
4013         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4014         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4015         (-[SWSchemes webView:startURLSchemeTask:]):
4016         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4017         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4018
4019 2018-12-20  Chris Dumez  <cdumez@apple.com>
4020
4021         Use Optional::hasValue() instead of Optional::has_value()
4022         https://bugs.webkit.org/show_bug.cgi?id=192948
4023
4024         Reviewed by Tim Horton.
4025
4026         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4027         (TestWebKitAPI::TEST):
4028         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4029         (TestWebKitAPI::TEST):
4030         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4031         (TestWebKitAPI::TEST_F):
4032
4033 2018-12-20  Chris Dumez  <cdumez@apple.com>
4034
4035         Add style script rule to check for uses of std::optional<>
4036         https://bugs.webkit.org/show_bug.cgi?id=192931
4037
4038         Reviewed by Tim Horton.
4039
4040         * Scripts/webkitpy/style/checkers/cpp.py:
4041         (check_wtf_optional):
4042         (check_style):
4043
4044 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4045
4046         [WebAuthN] Add a runtime flag for local authenticator
4047         https://bugs.webkit.org/show_bug.cgi?id=192792
4048         <rdar://problem/46798738>
4049
4050         Reviewed by Brent Fulgham.
4051
4052         * DumpRenderTree/TestOptions.cpp:
4053         (TestOptions::TestOptions):
4054         * DumpRenderTree/TestOptions.h:
4055         * DumpRenderTree/mac/DumpRenderTree.mm:
4056         (enableExperimentalFeatures):
4057         (setWebPreferencesForTestOptions):
4058         * WebKitTestRunner/TestController.cpp:
4059         (WTR::TestController::resetPreferencesToConsistentValues):
4060         (WTR::updateTestOptionsFromTestHeader):
4061         * WebKitTestRunner/TestOptions.h:
4062         (WTR::TestOptions::hasSameInitializationOptions const):
4063
4064 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4065
4066         webkitpy: Autoinstall package URLs have changed
4067         https://bugs.webkit.org/show_bug.cgi?id=192909
4068         <rdar://problem/46860359>
4069
4070         Rubber-stamped by Alexey Proskuryakov.
4071
4072         PyPi urls have been moved around, we need to update our auto-installed packages.
4073
4074         We should check for Selenium before asking PyPi for the latest version.
4075
4076         * Scripts/webkitpy/thirdparty/__init__.py:
4077         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4078         (AutoinstallImportHook._install_keyring): Ditto.
4079         (AutoinstallImportHook._install_pep8): Ditto.
4080         (AutoinstallImportHook._install_mozlog): Ditto.
4081         (AutoinstallImportHook._install_mozprocess): Ditto.
4082         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4083         (AutoinstallImportHook._install_pytest): Ditto.
4084         (AutoinstallImportHook._install_pylint): Ditto.
4085         (AutoinstallImportHook._install_buildbot): Ditto.
4086         (AutoinstallImportHook._install_coverage): Ditto.
4087         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4088         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4089         for new Selenium if the installed version isn't sufficient.
4090         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4091
4092 2018-12-20  Chris Dumez  <cdumez@apple.com>
4093
4094         Use Optional::valueOr() instead of Optional::value_or()
4095         https://bugs.webkit.org/show_bug.cgi?id=192933
4096
4097         Reviewed by Geoffrey Garen.
4098
4099         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4100         (TestWebKitAPI::checkURL):
4101         (TestWebKitAPI::checkRelativeURL):
4102         (TestWebKitAPI::checkURLDifferences):
4103         (TestWebKitAPI::checkRelativeURLDifferences):
4104         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4105         (TestWebKitAPI::checkURL):
4106
4107 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4108
4109         Unreviewed, rolling out r239417.
4110
4111         Introduced two API test failures on macOS.
4112
4113         Reverted changeset:
4114
4115         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4116         occlusion changes"
4117         https://bugs.webkit.org/show_bug.cgi?id=192821
4118         https://trac.webkit.org/changeset/239417
4119
4120 2018-12-20  Devin Rousso  <drousso@apple.com>
4121
4122         Web Inspector: UIString should take an optional key and description to aid localization
4123         https://bugs.webkit.org/show_bug.cgi?id=153962
4124         <rdar://problem/24542505>
4125
4126         Reviewed by Brian Burg.
4127
4128         * Scripts/extract-localizable-js-strings:
4129
4130 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4131
4132         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4133         https://bugs.webkit.org/show_bug.cgi?id=192923
4134         <rdar://problem/46859068>
4135
4136         Reviewed by Wenson Hsieh.
4137
4138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4139         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4140         Add a test ensuring that both parented and unparented WKWebViews can
4141         retrieve main resource data when loading a PDF.
4142
4143 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4144
4145         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4146         https://bugs.webkit.org/show_bug.cgi?id=192852
4147
4148         Reviewed by Michael Catanzaro.
4149
4150         EmojiOne font was replaced by Noto Color Emoji.
4151
4152         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4153         * gtk/jhbuild.modules:
4154         * wpe/jhbuild.modules:
4155
4156 2018-12-19  Chris Dumez  <cdumez@apple.com>
4157
4158         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4159         https://bugs.webkit.org/show_bug.cgi?id=192728
4160         <rdar://problem/46746779>
4161
4162         Reviewed by Geoff Garen.
4163
4164         * DumpRenderTree/*:
4165         * MiniBrowser/*:
4166         * TestRunnerShared/*:
4167         * TestWebKitAPI/*:
4168         * WebGPUAPIStructure/*:
4169         * WebKitTestRunner/*:
4170
4171 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4172
4173         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4174         https://bugs.webkit.org/show_bug.cgi?id=192821
4175
4176         Reviewed by Chris Dumez.
4177
4178         * DumpRenderTree/mac/DumpRenderTree.mm:
4179         (createWebViewAndOffscreenWindow):
4180
4181 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4182
4183         Navigations away from the SafeBrowsing interstitial show a flash of old content
4184         https://bugs.webkit.org/show_bug.cgi?id=192676
4185
4186         Reviewed by Chris Dumez.
4187
4188         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4189         (safeBrowsingView):
4190         (TEST):
4191         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4192
4193 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4194
4195         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4196         https://bugs.webkit.org/show_bug.cgi?id=192855
4197
4198         Reviewed by Michael Catanzaro.
4199
4200         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4201         (WTR::TestController::notifyDone): Use the WPE implementation.
4202         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4203         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4204         (WTR::TestController::platformRunUntil): Honor the condition flag.
4205
4206 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4207
4208         Allow clients to set the navigator platform
4209         https://bugs.webkit.org/show_bug.cgi?id=192735
4210
4211         Reviewed by Tim Horton.
4212
4213         Add a test for setting a custom navigator platform.
4214
4215         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4216         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4217         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
4218
4219 2018-12-19  Truitt Savell  <tsavell@apple.com>
4220
4221         Unreviewed, rolling out r239358.
4222
4223         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
4224         crash on Debug bots
4225
4226         Reverted changeset:
4227
4228         "Clean up IndexedDB files between tests"
4229         https://bugs.webkit.org/show_bug.cgi?id=192796
4230         https://trac.webkit.org/changeset/239358
4231
4232 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4233
4234         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
4235         https://bugs.webkit.org/show_bug.cgi?id=192842
4236         <rdar://problem/46823586>
4237
4238         Reviewed by Tim Horton.
4239
4240         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
4241         item provider when dragging a rich text selection.
4242
4243         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4244
4245 2018-12-18  David Quesada  <david_quesada@apple.com>
4246
4247         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
4248         https://bugs.webkit.org/show_bug.cgi?id=192810
4249         <rdar://problem/46812536>
4250
4251         Reviewed by Alex Christensen.
4252
4253         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4254         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4255             After releasing our reference to the web view, wait until the next turn of the runloop
4256             before checking that the originatingWebView has been zeroed, since the web view might
4257             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
4258             testing general memory management of WKWebViews, only that _WKDownload does not retain
4259             its web view via the 'originatingWebView' property.
4260
4261 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
4262
4263         Clean up IndexedDB files between tests
4264         https://bugs.webkit.org/show_bug.cgi?id=192796
4265
4266         Reviewed by Geoffrey Garen.
4267
4268         * DumpRenderTree/mac/DumpRenderTree.mm:
4269         (runTest):
4270         * WebKitTestRunner/TestController.cpp:
4271         (WTR::TestController::resetStateToConsistentValues):
4272         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4273         (WTR::RemoveAllIndexedDatabasesCallback):
4274         (WTR::TestController::ClearIndexedDatabases):
4275         * WebKitTestRunner/TestController.h:
4276
4277 2018-12-18  Alex Christensen  <achristensen@webkit.org>
4278
4279         Fix API test introduced in r239339 on iOS.
4280         https://bugs.webkit.org/show_bug.cgi?id=192675
4281
4282         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4283         (TEST):
4284         The iOS implementation of the safe browsing warning is a little different.