We should pass minimumEffectiveDeviceWidth to web process on new page creation.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2
3         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
4         https://bugs.webkit.org/show_bug.cgi?id=196077
5         <rdar://problem/49108202>
6
7         Reviewed by Chris Dumez.
8
9         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
10         on new web view.
11
12         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13
14 2019-04-05  Saam Barati  <sbarati@apple.com>
15
16         Make compare-results understand MotionMark
17         https://bugs.webkit.org/show_bug.cgi?id=196666
18
19         Reviewed by Yusuke Suzuki.
20
21         * Scripts/compare-results:
22         (PLT5Results):
23         (detectMotionMark):
24         (detectMotionMark1_1):
25         (motionMarkResults):
26         (motionMark1_1Results):
27         (detectBenchmark):
28         (biggerIsBetter):
29         (main):
30
31 2019-04-05  Alex Christensen  <achristensen@webkit.org>
32
33         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
34         https://bugs.webkit.org/show_bug.cgi?id=196665
35         <rdar://45115669>
36
37         Reviewed by Geoff Garen.
38
39         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
40         (goBack):
41         (+[SimpleLookupContext sharedLookupContext]):
42         (-[SimpleLookupContext lookUpURL:completionHandler:]):
43         (TEST):
44         (+[Simple3LookupContext sharedLookupContext]): Deleted.
45         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
46
47 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
48
49         [ews-build] Add configuration and architecture for windows builders
50         https://bugs.webkit.org/show_bug.cgi?id=196660
51
52         Reviewed by Lucas Forschler.
53
54         * BuildSlaveSupport/ews-build/config.json:
55
56 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
57
58         webkitpy: Don't run subsequent rounds if interrupted
59         https://bugs.webkit.org/show_bug.cgi?id=196646
60
61         Reviewed by Aakash Jain.
62
63         * Scripts/webkitpy/layout_tests/controllers/manager.py:
64         (Manager.run): Bail out if interrupted.
65
66 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
67
68         Test sessionStorage in PSON private browsing mode
69         https://bugs.webkit.org/show_bug.cgi?id=196561
70
71         Reviewed by Alex Christensen.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
74
75 2019-04-05  Commit Queue  <commit-queue@webkit.org>
76
77         Unreviewed, rolling out r243833.
78         https://bugs.webkit.org/show_bug.cgi?id=196645
79
80         This change breaks build of WPE and GTK ports (Requested by
81         annulen on #webkit).
82
83         Reverted changeset:
84
85         "[CMake][WTF] Mirror XCode header directories"
86         https://bugs.webkit.org/show_bug.cgi?id=191662
87         https://trac.webkit.org/changeset/243833
88
89 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
90
91         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
92         https://bugs.webkit.org/show_bug.cgi?id=196635
93
94         Reviewed by Antti Koivisto.
95         
96         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
97         for a test to enable async frame scrolling via:
98             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
99         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
100         
101         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
102
103         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
104         (WTR::InjectedBundle::beginTesting):
105         * WebKitTestRunner/TestController.cpp:
106         (WTR::TestController::resetPreferencesToConsistentValues):
107
108 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
109
110         Use a correct LC_RPATH when building with ASan
111         https://bugs.webkit.org/show_bug.cgi?id=196576
112
113         Reviewed by David Kilzer.
114
115         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
116         so that ../Frameworks is checked. This is simpler and more reliable than updating
117         each SPC service xcconfig.
118
119 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
120
121         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
122         https://bugs.webkit.org/show_bug.cgi?id=196629
123
124         Reviewed by Lucas Forschler.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
127
128 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
129
130         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
131         https://bugs.webkit.org/show_bug.cgi?id=196618
132
133         Reviewed by Lucas Forschler.
134
135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
136         (StatusBubble): Added QUEUE_TRIGGERS.
137         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
138         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
139         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
140         its parent(builder).
141
142 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
143
144         [ews-app] Status-bubble steps are sometimes displayed in reverse order
145         https://bugs.webkit.org/show_bug.cgi?id=196625
146
147         Reviewed by Lucas Forschler.
148
149         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
150         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
151
152 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
153
154         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
155         https://bugs.webkit.org/show_bug.cgi?id=196630
156
157         Reviewed by Wenson Hsieh.
158
159         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
160
161 2019-04-04  Youenn Fablet  <youenn@apple.com>
162
163         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
164         https://bugs.webkit.org/show_bug.cgi?id=196543
165
166         Reviewed by Alex Christensen.
167
168         * WebKitTestRunner/TestController.cpp:
169         (WTR::TestController::generatePageConfiguration):
170
171 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Status bubble should not display skipped buildbot steps
174         https://bugs.webkit.org/show_bug.cgi?id=196584
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
179
180 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
183         https://bugs.webkit.org/show_bug.cgi?id=196620
184
185         Reviewed by Lucas Forschler.
186
187         * BuildSlaveSupport/ews-app/ews/config.py:
188
189 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
190
191         [Win] DumpRenderTreeWatchDog.py is not checked into source
192         https://bugs.webkit.org/show_bug.cgi?id=196567
193         <rdar://problem/49525901>
194
195         Reviewed by Lucas Forschler.
196
197         This script is used on Win EWS bots to terminate hanging DRT processes.
198
199         * EWSTools/dumprendertreewatchdog.py: Added.
200
201 2019-04-04  Chris Dumez  <cdumez@apple.com>
202
203         Unreviewed, roll out r243858 which made tests time out.
204
205         Disable new API tests on Windows instead.
206
207         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
208         (TestWebKitAPI::TEST):
209
210 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
211
212         [ATK] Cleanup WebPageAccessibilityObjectAtk
213         https://bugs.webkit.org/show_bug.cgi?id=196537
214
215         Reviewed by Michael Catanzaro.
216
217         Also consider files under atk directories as exceptions for GObject conventions.
218
219         * Scripts/webkitpy/style/checkers/cpp.py:
220         (check_identifier_name_in_declaration):
221
222 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
223
224         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
225         https://bugs.webkit.org/show_bug.cgi?id=196588
226         <rdar://problem/49365787>
227
228         Unreviewed build fix for Windows port.
229
230         error C3861: 'kill': identifier not found
231
232         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
233         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
234
235 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
236
237         [ews-build] Cancel build and similar operations should have authentication
238         https://bugs.webkit.org/show_bug.cgi?id=196520
239
240         Reviewed by Dewei Zhu.
241
242         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
243         environment variables.
244
245 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
246
247         [ews-build] Do not trigger queues which are not in production yet
248         https://bugs.webkit.org/show_bug.cgi?id=196581
249
250         Reviewed by Dewei Zhu.
251
252         * BuildSlaveSupport/ews-build/config.json:
253
254 2019-04-03  Chris Dumez  <cdumez@apple.com>
255
256         Unreviewed, fix typo in the name of API test added in r243848.
257
258         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
259         (TestWebKitAPI::TEST):
260
261 2019-04-03  Chris Dumez  <cdumez@apple.com>
262
263         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
264         https://bugs.webkit.org/show_bug.cgi?id=196588
265         <rdar://problem/49365787>
266
267         Reviewed by Ryosuke Niwa.
268
269         Add API test coverage.
270
271         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
272         (TestWebKitAPI::nullJavaScriptCallback):
273         (TestWebKitAPI::didCrashCheckFrames):
274         (TestWebKitAPI::TEST):
275
276 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
277
278         run-webkit-tests: Upload test results (new results database)
279         https://bugs.webkit.org/show_bug.cgi?id=196577
280         <rdar://problem/34841155>
281
282         Reviewed by Lucas Forschler.
283
284         * Scripts/webkitpy/layout_tests/controllers/manager.py:
285         (Manager.run): Upload results after each device shard, since the configuration will be
286         different for each device.
287         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
288         uploaded to a results database.
289         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
290         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
291
292 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
293
294         -apple-trailing-word is needed for browser detection
295         https://bugs.webkit.org/show_bug.cgi?id=196575
296
297         Unreviewed.
298
299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
300
301 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
302
303         [CMake][WTF] Mirror XCode header directories
304         https://bugs.webkit.org/show_bug.cgi?id=191662
305
306         Reviewed by Konstantin Tokarev.
307
308         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
309         builds.
310
311         * CMakeLists.txt:
312         * DumpRenderTree/CMakeLists.txt:
313         * DumpRenderTree/PlatformWin.cmake:
314         * MiniBrowser/win/CMakeLists.txt:
315         * TestWebKitAPI/CMakeLists.txt:
316         * TestWebKitAPI/PlatformWin.cmake:
317         * WebKitTestRunner/PlatformGTK.cmake:
318         * WebKitTestRunner/PlatformWin.cmake:
319
320 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-app] Status bubble should not display certain infrastructure status messages
323         https://bugs.webkit.org/show_bug.cgi?id=196550
324
325         Reviewed by Lucas Forschler.
326
327         Do not display the steps which are un-needed for end-user. This information is still avaiable
328         if the user click on the bubble and look at the Buildbot build.
329         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
330         (StatusBubble._steps_messages):
331         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
332
333 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
334
335         [ews-build] Use https for sending data to ews-app
336         https://bugs.webkit.org/show_bug.cgi?id=196492
337
338         Reviewed by Lucas Forschler.
339
340         * BuildSlaveSupport/ews-build/events.py:
341
342 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
343
344         Remove support for -apple-trailing-word
345         https://bugs.webkit.org/show_bug.cgi?id=196525
346
347         Reviewed by Zalan Bujtas.
348
349         This CSS property is nonstandard and not used.
350
351         * Scripts/webkitperl/FeatureList.pm:
352         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
353
354 2019-04-03  Youenn Fablet  <youenn@apple.com>
355
356         Add a test for DOMCache on multiple browsing in case of private browsing
357         https://bugs.webkit.org/show_bug.cgi?id=196524
358
359         Reviewed by Alex Christensen.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
362         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
363
364 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
365
366         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
367         https://bugs.webkit.org/show_bug.cgi?id=196540
368
369         Reviewed by Aakash Jain.
370
371         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
372
373 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
374
375         Add plumbing for a compatibility mode preference in WebKit
376         https://bugs.webkit.org/show_bug.cgi?id=196005
377
378         Reviewed by Tim Horton.
379
380         Add new API tests.
381
382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
383         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
384
385 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
386
387         [WPE][GTK] Update libsrtp dependency package for Debian
388         https://bugs.webkit.org/show_bug.cgi?id=196528
389
390         Reviewed by Frédéric Wang.
391
392         * gtk/install-dependencies:
393         * wpe/install-dependencies:
394
395 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
396
397         [WK2] Add support for Window's beforeprint / afterprint events
398         https://bugs.webkit.org/show_bug.cgi?id=196478
399         <rdar://problem/49535124>
400
401         Unreviewed build fix for MSVC.
402
403         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
404
405         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
406
407         * WebKitTestRunner/TestController.cpp:
408         (WTR::printFrame): Use int and float literals.
409
410 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
411
412         [ews-build] Reassign bots to queues
413
414         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
415
416 2019-04-02  Chris Dumez  <cdumez@apple.com>
417
418         [WK2] Add support for Window's beforeprint / afterprint events
419         https://bugs.webkit.org/show_bug.cgi?id=196478
420
421         Reviewed by Alex Christensen.
422
423         Add minimal implementation for printFrame in WebKitTestRunner.
424
425         * WebKitTestRunner/TestController.cpp:
426         (WTR::printFrame):
427         (WTR::TestController::createOtherPage):
428         (WTR::TestController::createWebViewWithOptions):
429
430 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
431
432         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
433         https://bugs.webkit.org/show_bug.cgi?id=196491
434
435         Reviewed by Lucas Forschler.
436
437         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
438
439 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
440
441         [ews-build] Configure buildbot try credentials in environment variables
442         https://bugs.webkit.org/show_bug.cgi?id=196501
443
444         Reviewed by Lucas Forschler.
445
446         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
447         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
448         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
449
450 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
451
452         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
453         https://bugs.webkit.org/show_bug.cgi?id=196496
454         <rdar://problem/49521634>
455
456         Reviewed by Chris Dumez.
457
458         Add new API tests (see WebKit ChangeLog for more detail).
459
460         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
461         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
462         (TEST):
463
464 2019-04-02  David Kilzer  <ddkilzer@apple.com>
465
466         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
467         <https://webkit.org/b/196499>
468
469         Reviewed by Alexey Proskuryakov.
470
471         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
472         ENABLE_ADDRESS_SANITIZER.
473
474 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
475
476         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
477         https://bugs.webkit.org/show_bug.cgi?id=182757
478
479         Reviewed by Don Olmstead.
480
481         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
482         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
483
484 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
485
486         run-api-tests: Upload test results
487         https://bugs.webkit.org/show_bug.cgi?id=196323
488         <rdar://problem/49356714>
489
490         Reviewed by Lucas Forschler.
491
492         * Scripts/webkitpy/api_tests/manager.py:
493         (Manager):
494         (Manager.run): Upload results to a results database.
495         * Scripts/webkitpy/api_tests/run_api_tests.py:
496         (parse_args): Add upload arguments.
497         * Scripts/webkitpy/port/base.py:
498         (Port):
499         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
500         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
501         with commits from any other associated repositories.
502         * Scripts/webkitpy/port/device.py:
503         (Device):
504         (Device.build_version): Access build_versoin of underlying platform device.
505         * Scripts/webkitpy/port/ios_simulator_unittest.py:
506         (IOSSimulatorTest):
507         (IOSSimulatorTest.test_configuration_for_upload):
508         * Scripts/webkitpy/port/device_port.py:
509         (DevicePort):
510         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
511         the same as the machine uploading results.
512         * Scripts/webkitpy/port/mac.py:
513         (MacPort):
514         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
515         * Scripts/webkitpy/port/mac_unittest.py:
516         (MacTest):
517         (MacTest.test_configuration_for_upload):
518         * Scripts/webkitpy/xcode/simulated_device.py:
519         (SimulatedDeviceManager._create_device_with_runtime):
520         (SimulatedDevice.__init__): Create simulated device with a build_version.
521         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
522         (test_existing_simulator):
523
524 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
525
526         Remove extra newline characters (Follow-up fix to r243707)
527
528         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
529
530 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
531
532         [ews-app] Use API_KEY to accept results data
533         https://bugs.webkit.org/show_bug.cgi?id=196461
534
535         Reviewed by Dewei Zhu.
536
537         * BuildSlaveSupport/ews-app/ews/views/results.py:
538         (Results.post): Validate EWS_API_KEY before accepting any data.
539         * BuildSlaveSupport/ews-build/events.py:
540         (Events.sendData): Send EWS_API_KEY if available along with event data.
541
542 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
543
544         Unable to copy and paste a PDF from Notes into Mail compose body
545         https://bugs.webkit.org/show_bug.cgi?id=196442
546         <rdar://problem/48573098>
547
548         Reviewed by Tim Horton.
549
550         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
551         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
552         to be specified on the item providers.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
555         (TestWebKitAPI::mapItemForTesting):
556         (TestWebKitAPI::contactItemForTesting):
557
558 2019-04-01  Tim Horton  <timothy_horton@apple.com>
559
560         Make UIWKDocumentContext rects per-character instead of per-word
561         https://bugs.webkit.org/show_bug.cgi?id=196459
562
563         Reviewed by Wenson Hsieh.
564
565         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
566         (TEST):
567         Adjust test results due to switching to per-character rects.
568
569 2019-04-01  Chris Dumez  <cdumez@apple.com>
570
571         UIProcess crash when a prewarmed process is terminated
572         https://bugs.webkit.org/show_bug.cgi?id=196451
573         <rdar://problem/49245471>
574
575         Reviewed by Geoffrey Garen.
576
577         Add API test coverage.
578
579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
580         (TEST):
581
582 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
583
584         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
585         https://bugs.webkit.org/show_bug.cgi?id=196449
586
587         Reviewed by Lucas Forschler.
588
589         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
590         (StatusBubble.get_os_details): Method to get OS and Xcode details.
591         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
592         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
593
594 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
595
596         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
597         https://bugs.webkit.org/show_bug.cgi?id=196444
598
599         Reviewed by Lucas Forschler.
600
601         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
602
603 2019-04-01  Alex Christensen  <achristensen@webkit.org>
604
605         Add SPI to canonicalize NSURLs with WTF::URL
606         https://bugs.webkit.org/show_bug.cgi?id=196415
607         <rdar://problem/44980271>
608
609         Reviewed by Darin Adler.
610
611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
612         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
613         (TestWebKitAPI::TEST):
614
615 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
616
617         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
618         https://bugs.webkit.org/show_bug.cgi?id=196441
619
620         Reviewed by Carlos Garcia Campos.
621
622         Don't cache the wpe_view_backend object that might not exist yet at the
623         time of EventSenderProxy constructor invocation, but instead retrieve
624         that object whenever it's required for event dispatching. This should
625         avoid crashes in this constructor now that it's invoked before any
626         PlatformWindow has been set up (as changed in r243496).
627
628         * WebKitTestRunner/EventSenderProxy.h:
629         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
630         (WTR::viewBackend):
631         (WTR::EventSenderProxy::EventSenderProxy):
632         (WTR::EventSenderProxy::mouseDown):
633         (WTR::EventSenderProxy::mouseUp):
634         (WTR::EventSenderProxy::mouseMoveTo):
635         (WTR::EventSenderProxy::mouseScrollBy):
636         (WTR::EventSenderProxy::keyDown):
637         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
638
639 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
640
641         [Win][WebKit] MiniBrowser should support high DPI display
642         https://bugs.webkit.org/show_bug.cgi?id=196391
643
644         Reviewed by Alex Christensen.
645
646         * MiniBrowser/win/WebKitBrowserWindow.cpp:
647         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
648         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
649         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
650
651 2019-03-31  Sam Weinig  <weinig@apple.com>
652
653         Remove more i386 specific configurations
654         https://bugs.webkit.org/show_bug.cgi?id=196430
655
656         Reviewed by Alexey Proskuryakov.
657
658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
659         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
660
661 2019-03-31  Andy Estes  <aestes@apple.com>
662
663         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
664         https://bugs.webkit.org/show_bug.cgi?id=196433
665         <rdar://problem/49293305>
666
667         Reviewed by Tim Horton.
668
669         Enhanced API test coverage to include all navigation response policy decisions in both
670         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
671
672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
673         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
674         (TestWebKitAPI::TEST):
675         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
676         (readFile):
677         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
678         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
679         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
680         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
681         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
682         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
683         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
684         (-[QuickLookDelegate _downloadDidStart:]):
685         (-[QuickLookDelegate _download:didReceiveResponse:]):
686         (-[QuickLookDelegate _download:didReceiveData:]):
687         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
688         (-[QuickLookDelegate _downloadDidFinish:]):
689         (-[QuickLookDelegate _download:didFailWithError:]):
690         (-[QuickLookDelegate _downloadDidCancel:]):
691         (-[QuickLookDelegate verifyDownload]):
692         (runTest):
693         (runTestDecideBeforeLoading):
694         (runTestDecideAfterLoading):
695         (TEST):
696         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
697         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
698         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
699         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
700         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
701         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
702         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
703         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
704         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
705         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
706         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
707         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
708         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
709         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
710
711 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
712
713         [CMake] add testdfg as target with build-jsc
714         https://bugs.webkit.org/show_bug.cgi?id=196393
715
716         Reviewed by Saam Barati.
717
718         Added testdfg as one of the targets to build when
719         using CMake.
720
721         * Scripts/build-jsc:
722
723 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
724
725         Delete WebMetal implementation in favor of WebGPU
726         https://bugs.webkit.org/show_bug.cgi?id=195418
727
728         Reviewed by Dean Jackson.
729
730         * DumpRenderTree/mac/DumpRenderTree.mm:
731         (enableExperimentalFeatures):
732         (resetWebPreferencesToConsistentValues):
733         * Scripts/webkitperl/FeatureList.pm:
734         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
736         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
737         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
738         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
739         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
740         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
741         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
742         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
744         (WTR::InjectedBundle::beginTesting):
745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
746         (WTR::TestRunner::setWebMetalEnabled): Deleted.
747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
748
749 2019-03-29  Chris Dumez  <cdumez@apple.com>
750
751         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
752         https://bugs.webkit.org/show_bug.cgi?id=196405
753         <rdar://problem/49428130>
754
755         Reviewed by Wenson Hsieh.
756
757         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
758         the popover presentation methods to be no-ops. Use this in the new test added in
759         r243523 so that we do not swizzle those methods for all tests. This is needed because
760         those WatchOS tests rely on the popover getting presented and interactive.
761
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::updateTestOptionsFromTestHeader):
764         * WebKitTestRunner/TestController.h:
765         * WebKitTestRunner/TestOptions.h:
766         (WTR::TestOptions::hasSameInitializationOptions const):
767         * WebKitTestRunner/ios/TestControllerIOS.mm:
768         (WTR::TestController::platformInitialize):
769         (WTR::TestController::platformResetStateToConsistentValues):
770
771 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
772
773         [Curl] Add Server Trust Evaluation Support.
774         https://bugs.webkit.org/show_bug.cgi?id=191646
775
776         Reviewed by Fujii Hironori.
777
778         Implemented MiniBrowser UI for asking if user trusts the server.
779
780         * MiniBrowser/win/Common.cpp:
781         (askServerTrustEvaluation):
782         (replaceString):
783         * MiniBrowser/win/Common.h:
784         * MiniBrowser/win/MiniBrowserLib.rc:
785         * MiniBrowser/win/MiniBrowserLibResource.h:
786         * MiniBrowser/win/WebKitBrowserWindow.cpp:
787         (createPEMString):
788         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
789         (WebKitBrowserWindow::canTrustServerCertificate):
790         * MiniBrowser/win/WebKitBrowserWindow.h:
791
792 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
793
794         Implement ResizeObserver.
795         https://bugs.webkit.org/show_bug.cgi?id=157743
796
797         Reviewed by Simon Fraser.
798
799         Support resizeObserverEnabled webPreferences.
800
801         * DumpRenderTree/TestOptions.cpp:
802         (TestOptions::TestOptions):
803         * DumpRenderTree/TestOptions.h:
804         * DumpRenderTree/mac/DumpRenderTree.mm:
805         (setWebPreferencesForTestOptions):
806         * DumpRenderTree/win/DumpRenderTree.cpp:
807         (enableExperimentalFeatures):
808         * Scripts/webkitperl/FeatureList.pm:
809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
810
811 2019-03-28  John Wilander  <wilander@apple.com>
812
813         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
814         https://bugs.webkit.org/show_bug.cgi?id=196281
815         <rdar://problem/48938748>
816
817         Reviewed by Alex Christensen.
818
819         This patch adds the function isStatisticsHasLocalStorage() to the
820         TestRunner. With it, the page can query the WebsiteDataStore in the
821         UI process to make sure that it sees LocalStorage.
822
823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
825         (WTR::TestRunner::isStatisticsHasLocalStorage):
826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
827         * WebKitTestRunner/TestController.cpp:
828         (WTR::TestController::isStatisticsHasLocalStorage):
829         * WebKitTestRunner/TestController.h:
830         * WebKitTestRunner/TestInvocation.cpp:
831         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
832
833 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
834
835         API::Data::createWithoutCopying should do a null check before calling CFRelease
836         https://bugs.webkit.org/show_bug.cgi?id=196276
837         <rdar://problem/48059859>
838
839         Reviewed by Alex Christensen.
840
841         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
842
843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
844         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
845         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
846         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
847         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
848         (TestWebKitAPI::TEST):
849
850 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
851
852         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
853         https://bugs.webkit.org/show_bug.cgi?id=186276
854
855         Reviewed by Carlos Garcia Campos.
856
857         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
858         (webViewLoadChanged):
859         (testWebResourceGetDataError):
860         (testWebResourceGetDataEmpty):
861         (beforeAll):
862         (webViewloadChanged): Deleted.
863
864 2019-03-27  Andy Estes  <aestes@apple.com>
865
866         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
867         https://bugs.webkit.org/show_bug.cgi?id=196317
868
869         Reviewed by Dan Bernstein.
870
871         package-root copies built products into a staging directory using ditto(1), which does not
872         follow symbolic links as it traverses a directory. Now that the files in
873         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
874         itself, these become broken links when ditto'd into the staging directory.
875
876         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
877
878         * Scripts/package-root:
879
880 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
881
882         [ews-app] Update display text of Submit for ews analysis
883         https://bugs.webkit.org/show_bug.cgi?id=196309
884
885         Reviewed by Dewei Zhu.
886
887         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
888
889 2019-03-27  David Kilzer  <ddkilzer@apple.com>
890
891         run-webkit-tests should check for leaks in WebKit processes
892         <https://webkit.org/b/193772>
893         <rdar://problem/46526680>
894
895         Reviewed by Ryosuke Niwa.
896
897         This works by doing the following:
898         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
899           The list of child processes are returned one per line:
900           process.name: pid
901         - Run the "#LIST CHILD PROCESSES" command just before the
902           "#CHECK FOR WORLD LEAKS" command, and store the list of child
903           processes on the ServerProcess object.
904         - When the `--leaks` switch is handled, run check_for_leaks() on
905           each child process after the main test harness.
906
907         * DumpRenderTree/mac/DumpRenderTree.mm:
908         (handleControlCommand):
909         - Use strncmp() instead of strcmp().
910         - Add support for handling "#LIST CHILD PROCESSES" command.
911
912         * Scripts/webkitpy/port/base.py:
913         (Port.check_for_leaks):
914         * Scripts/webkitpy/port/darwin.py:
915         (DarwinPort.check_for_leaks):
916         - Rename redundant 'process_pid' argument to 'process_id'.
917
918         * Scripts/webkitpy/port/driver.py:
919         (Driver.do_post_tests_work):
920         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
921           longer the only command this sends to WebKitTestRunner.
922         - If the `--leaks` switch is present, send the
923           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
924           result using Port.set_webkit_processes().
925         (Driver._parse_child_processes_output):
926         - Add helper method to parse list of child process names and
927           process IDs returned from WebKitTestRunner.
928
929         * Scripts/webkitpy/port/ios_device.py:
930         (IOSDevicePort.check_for_leaks):
931         - Rename redundant 'process_pid' argument to 'process_id'.
932
933         * Scripts/webkitpy/port/leakdetector.py:
934         (LeakDetector._parse_leaks_output):
935         - Return early if there is no leaks_output.
936         (LeakDetector.check_for_leaks):
937         - Rename redundant 'process_pid' argument to 'process_id'.
938
939         * Scripts/webkitpy/port/server_process.py:
940         (ServerProcess.__init__):
941         (ServerProcess.child_processes):
942         (ServerProcess.set_child_processes):
943         - Add instance variable to Port to store list of child process
944           names and process IDs returned from WebKitTestRunner.
945         (ServerProcess._start):
946         - Clear self._child_processes.
947         (ServerProcess.stop):
948         - If self._child_processes is set, call
949           self._port.check_for_leaks() for each child process.
950
951         * Scripts/webkitpy/port/server_process_unittest.py:
952         (TrivialMockPort.check_for_leaks):
953         - Rename redundant 'process_pid' argument to 'process_id'.
954
955         * Scripts/webkitpy/port/simulator_process.py:
956         (SimulatorProcess.stop):
957         - If self._child_processes is set, call
958           self._port.check_for_leaks() for each child process.
959
960         * Scripts/webkitpy/port/watch_device.py:
961         (WatchDevicePort.check_for_leaks):
962         - Rename redundant 'process_pid' argument to 'process_id'.
963
964         * WebKitTestRunner/TestController.cpp:
965         (WTR::TestController::dumpResponse):
966         - Extract method from findAndDumpWorldLeaks() so that it may be
967           reused by findAndDumpWebKitProcessIdentifiers().
968         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
969         - Add method to output process name and process ID of both the
970           WebContent and Networking processes.
971         (WTR::TestController::findAndDumpWorldLeaks):
972         - Fix missing newline in output when there were no abandoned
973           documents.
974         - Call dumpResponse() for extracted code.
975         (WTR::TestController::handleControlCommand):
976         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
977         - Use strncmp() instead of strcmp().
978         - Call findAndDumpWebKitProcessIdentifiers() when
979           "#LIST CHILD PROCESSES" command is sent.
980         * WebKitTestRunner/TestController.h:
981         (WTR::TestController::dumpResponse):
982         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
983         - Declare methods.
984
985 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
986
987         Unreviewed. Add GLib API test cases after r243434.
988
989         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
990         (testWebViewActiveURI):
991         (serverCallback):
992         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
993         (sendRequestCallback):
994
995 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
996
997         Geolocation request not complete when watch request was started in a different web process
998         https://bugs.webkit.org/show_bug.cgi?id=195996
999
1000         Reviewed by Alex Christensen.
1001
1002         Add a test case.
1003
1004         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1005         (TestWebKitAPI::runJavaScriptAlert):
1006         (TestWebKitAPI::TEST):
1007
1008 2019-03-26  Keith Rollin  <krollin@apple.com>
1009
1010         Update the way generate-xcfilelists returns strings from functions
1011         https://bugs.webkit.org/show_bug.cgi?id=195975
1012         <rdar://problem/49040807>
1013
1014         Reviewed by Dean Jackson.
1015
1016         There are places where generate-xcfilelists executes assignments with
1017         statements like:
1018
1019             FOO=$(some_function)
1020
1021         where "some_function" return a string by echoing it. E.g.
1022
1023             some_function()
1024             {
1025                 echo "Hello, World"
1026             }
1027
1028         This is a common idiom, but it has a problem if "some_function" needs
1029         to call "exit" in an attempt to halt the entire script right then and
1030         there. Since "some_function" is called inside of $(), it's being
1031         executed in a sub-shell. Calling exit in that sub-shell simply exits
1032         that shell; it doesn't not exit the outer shell in which the main part
1033         of the script is still running. As such, the main script keeps
1034         executing when the intent was for the script to halt.
1035
1036         The solution to this is to use a different idiom for returning
1037         strings. The one we now is to pass in the name of the variable to
1038         receive the string result:
1039
1040             some_function()
1041             {
1042                 variable_name=$1
1043                 eval $variable_name ="Hello, World"
1044             }
1045
1046         The call site now looks like
1047
1048             some_function FOO
1049
1050         Because there's no invocation of a sub-shell, some_function can now
1051         call "exit" if it wants to, and the entire script will exit at that
1052         point.
1053
1054         * Scripts/generate-xcfilelists:
1055
1056 2019-03-26  Chris Dumez  <cdumez@apple.com>
1057
1058         Add basic layout test coverage for File Picker on iOS
1059         https://bugs.webkit.org/show_bug.cgi?id=196265
1060
1061         Reviewed by Wenson Hsieh.
1062
1063         Add layout test infrastructure to test the file picker on iOS.
1064
1065         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1066         (WTR::UIScriptController::dismissFilePicker):
1067         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1068         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1069         (WTR::UIScriptController::dismissFilePicker):
1070         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1071         * WebKitTestRunner/TestController.cpp:
1072         (WTR::TestController::createWebViewWithOptions):
1073         (WTR::updateTestOptionsFromTestHeader):
1074         * WebKitTestRunner/TestOptions.h:
1075         (WTR::TestOptions::hasSameInitializationOptions const):
1076         * WebKitTestRunner/ios/TestControllerIOS.mm:
1077         (overridePresentViewController):
1078         (WTR::TestController::platformInitialize):
1079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1080         (WTR::UIScriptController::dismissFilePicker):
1081
1082 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1083
1084         Implement async paste method on UIWKInteractionViewProtocol
1085         https://bugs.webkit.org/show_bug.cgi?id=196267
1086         <rdar://problem/49236346>
1087
1088         Reviewed by Tim Horton.
1089
1090         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1091         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1092         are now a part of all iOS 12 internal SDKs.
1093
1094         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1095
1096         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1097         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1098
1099         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1100         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1101         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1102         * TestWebKitAPI/ios/UIKitSPI.h:
1103
1104 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1105
1106         [ews-build] Use PostgreSQL for ews.webkit.org database
1107         https://bugs.webkit.org/show_bug.cgi?id=196270
1108
1109         Reviewed by Lucas Forschler.
1110
1111         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1112
1113 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1114
1115         [ews] Reset simctl states on reboot
1116         https://bugs.webkit.org/show_bug.cgi?id=196260
1117
1118         Rubber-stamped by Aakash Jain.
1119
1120         * EWSTools/start-queue-mac.sh:
1121
1122 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1123
1124         [ews-build] Use PostgreSQL for ews-build database
1125         https://bugs.webkit.org/show_bug.cgi?id=196229
1126
1127         Reviewed by Lucas Forschler.
1128
1129         * BuildSlaveSupport/ews-build/master.cfg:
1130
1131 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1132
1133         [ews-build] Get master_hostname dynamically in master.cfg
1134         https://bugs.webkit.org/show_bug.cgi?id=196255
1135
1136         Reviewed by Lucas Forschler.
1137
1138         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1139         send events data in test mode.
1140
1141 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1142
1143         [ews-app] Set db_constraint to False for Foreign Keys
1144         https://bugs.webkit.org/show_bug.cgi?id=196252
1145
1146         Reviewed by Lucas Forschler.
1147
1148         * BuildSlaveSupport/ews-app/ews/models/build.py:
1149         * BuildSlaveSupport/ews-app/ews/models/step.py:
1150
1151 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1152
1153         [ews-build] is_test_mode_enabled should default to True
1154         https://bugs.webkit.org/show_bug.cgi?id=196248
1155
1156         Reviewed by Lucas Forschler.
1157
1158         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1159
1160 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1161
1162         [ews-app] Add webkitperl to ENABLED_QUEUES
1163         https://bugs.webkit.org/show_bug.cgi?id=196253
1164
1165         Reviewed by Lucas Forschler.
1166
1167         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1168
1169 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1170
1171         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1172         https://bugs.webkit.org/show_bug.cgi?id=196211
1173         rdar://problem/49110552
1174
1175         Reviewed by Tim Horton.
1176
1177         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1178         Make sure that EventSenderProxy always exists when running tests. We used to create
1179         it when resetting before the first test, which is a bit too late.
1180
1181         * WebKitTestRunner/TestController.h:
1182         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1183         (WTR::TestController::platformCreateWebView):
1184         (WTR::TestController::platformCreateOtherPage):
1185         (WTR::TestController::finishCreatingPlatformWebView):
1186         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1187         (WTR::PlatformWebView::PlatformWebView):
1188         Moved some code that made NSWindow use NSEvent during web view creation. We may
1189         need to move more if some other case us found, but this is enough for now.
1190
1191 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         Unreviewed. Fix typo in GLib geolocation API after r243285.
1194
1195         gelocation -> geolocation.
1196
1197         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1198         (testGeolocationManagerWatchPosition):
1199
1200 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1201
1202         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1203         https://bugs.webkit.org/show_bug.cgi?id=196213
1204
1205         Reviewed by Geoff Garen.
1206
1207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1208         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1209         (credentialWithIdentityAndKeychainPath):
1210         (-[ChallengeDelegate webView:didFinishNavigation:]):
1211         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1212         (TestWebKitAPI::TEST):
1213
1214 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1215
1216         Expected shouldn't assume its contained types are copyable
1217         https://bugs.webkit.org/show_bug.cgi?id=195986
1218
1219         Reviewed by JF Bastien.
1220
1221         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1222         (TestWebKitAPI::NonCopyable::operator== const):
1223         (TestWebKitAPI::NonCopyable::operator!= const):
1224         (TestWebKitAPI::TEST):
1225
1226 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1227
1228         Remove some now-unnecessary dynamic class lookup
1229         https://bugs.webkit.org/show_bug.cgi?id=196237
1230
1231         Reviewed by Simon Fraser.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1234         (makeRequest):
1235         (TEST):
1236
1237 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1238
1239         Unreviewed, rolling out r243450.
1240
1241         AppleWin and WinCairo port builds get broken.
1242
1243         Reverted changeset:
1244
1245         "Add test for fix of #196095"
1246         https://bugs.webkit.org/show_bug.cgi?id=196097
1247         https://trac.webkit.org/changeset/243450
1248
1249 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1250
1251         Unreviewed, rolling out r243465.
1252         https://bugs.webkit.org/show_bug.cgi?id=196226
1253
1254         the test doesn't build (Requested by thorton on #webkit).
1255
1256         Reverted changeset:
1257
1258         "Do not terminate the NetworkProcess if a third party
1259         application sends a NSCredential with a SecIdentityRef"
1260         https://bugs.webkit.org/show_bug.cgi?id=196213
1261         https://trac.webkit.org/changeset/243465
1262
1263 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1264
1265         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1266         https://bugs.webkit.org/show_bug.cgi?id=196213
1267
1268         Reviewed by Geoff Garen.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1272         (credentialWithIdentityAndKeychainPath):
1273         (-[ChallengeDelegate webView:didFinishNavigation:]):
1274         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1275         (TestWebKitAPI::TEST):
1276
1277 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews-build] Gracefully handle missing patch_id in events
1280         https://bugs.webkit.org/show_bug.cgi?id=196216
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * BuildSlaveSupport/ews-build/events.py:
1285
1286 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1287
1288         [ews-build] use lz4 compression for improving buildbot performance
1289         https://bugs.webkit.org/show_bug.cgi?id=196155
1290
1291         Reviewed by Lucas Forschler.
1292
1293         * BuildSlaveSupport/ews-build/master.cfg:
1294
1295 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1296
1297         Pull some API testing helper methods out of TestWKWebView
1298         https://bugs.webkit.org/show_bug.cgi?id=196212
1299
1300         Reviewed by Tim Horton.
1301
1302         Refactor some more API testing utility methods, so that they can be used in
1303         tests that do not use TestWKWebView.
1304
1305         * TestWebKitAPI/cocoa/TestWKWebView.h:
1306         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1307         (-[WKWebView loadTestPageNamed:]):
1308         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1309         (-[WKWebView synchronouslyLoadHTMLString:]):
1310         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1311         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1312         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1313         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1314         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1315
1316 2019-03-25  Jer Noble  <jer.noble@apple.com>
1317
1318         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1319         https://bugs.webkit.org/show_bug.cgi?id=196097
1320
1321         Reviewed by Eric Carlson.
1322
1323         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1324
1325         * DumpRenderTree/mac/DumpRenderTree.mm:
1326         (resetWebPreferencesToConsistentValues):
1327         * WebKitTestRunner/TestController.cpp:
1328         (WTR::TestController::resetPreferencesToConsistentValues):
1329
1330 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1331
1332         Pull IPadUserInterfaceSwizzler out into a separate header file
1333         https://bugs.webkit.org/show_bug.cgi?id=196193
1334
1335         Reviewed by Anders Carlsson.
1336
1337         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1338         be used in other API tests.
1339
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1341         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1342         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1343         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1344         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1345         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1346         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1347
1348 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1349
1350         Remove NavigatorContentUtils in WebCore/Modules
1351         https://bugs.webkit.org/show_bug.cgi?id=196070
1352
1353         Reviewed by Alex Christensen.
1354
1355         NavigatorContentUtils was to support the custom scheme spec [1].
1356         However, in WebKit side, no port has supported the feature in
1357         WebKit layer after EFL port was removed. So there has been the
1358         only IDL implementation of the NavigatorContentUtils in WebCore.
1359         So we don't need to keep the implementation in WebCore anymore.
1360
1361         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1362
1363         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1364
1365 2019-03-24  Andy Estes  <aestes@apple.com>
1366
1367         [watchOS] Remove unused Proximity Networking code
1368         https://bugs.webkit.org/show_bug.cgi?id=196188
1369
1370         Reviewed by Tim Horton.
1371
1372         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1373         (TEST):
1374
1375 2019-03-23  Keith Miller  <keith_miller@apple.com>
1376
1377         Refactor clz/ctz and fix getLSBSet.
1378         https://bugs.webkit.org/show_bug.cgi?id=196162
1379
1380         Reviewed by Saam Barati.
1381
1382         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1383
1384         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1385         (TestWebKitAPI::TEST):
1386
1387 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1388
1389         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1390         https://bugs.webkit.org/show_bug.cgi?id=196143
1391
1392         Reviewed by Michael Catanzaro.
1393
1394         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1395         directories.
1396
1397         * Scripts/webkitpy/style/checkers/cpp.py:
1398         (check_identifier_name_in_declaration):
1399         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1400         (WebKitStyleTest.test_names):
1401
1402 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1403
1404         [Flatpak] Manifest expanding fails for qt WPE extension
1405         https://bugs.webkit.org/show_bug.cgi?id=196148
1406
1407         Reviewed by Alex Christensen.
1408
1409         * flatpak/flatpakutils.py:
1410         (expand_submodules_recurse): The last recurse manifest expand
1411         iteration might lead to a single module so take it into account
1412         and don't try to recurse further.
1413
1414 2019-03-22  Chris Dumez  <cdumez@apple.com>
1415
1416         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1417         https://bugs.webkit.org/show_bug.cgi?id=195348
1418         <rdar://problem/48622090>
1419
1420         Reviewed by Alex Christensen.
1421
1422         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1423         to NO when test.options().shouldIgnoreMetaViewport is false.
1424
1425         * WebKitTestRunner/ios/TestControllerIOS.mm:
1426         (WTR::TestController::platformConfigureViewForTest):
1427
1428 2019-03-22  Chris Dumez  <cdumez@apple.com>
1429
1430         Prewarmed processes should be usable with any website data store
1431         https://bugs.webkit.org/show_bug.cgi?id=196104
1432
1433         Reviewed by Alex Christensen.
1434
1435         Add API test coverage.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1438         (runInitialWarmedProcessUsedTest):
1439         (TEST):
1440
1441 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1442
1443         Back out local changes to Alex's Subversion working directory
1444
1445         They were accidentally committed.
1446
1447         * Scripts/webkitpy/common/system/abstractexecutive.py:
1448         (AbstractExecutive.wait_newest):
1449         * Scripts/webkitpy/common/system/executive.py:
1450         (Executive.running_pids):
1451         * Scripts/webkitpy/common/system/executive_mock.py:
1452         (MockExecutive.running_pids):
1453         * Scripts/webkitpy/common/system/executive_unittest.py:
1454         (ExecutiveTest.serial_test_running_pids):
1455         * Scripts/webkitpy/port/darwin.py:
1456         (DarwinPort.check_for_leaks):
1457         * Scripts/webkitpy/port/leakdetector.py:
1458         (LeakDetector.check_for_leaks):
1459         - This was the hack attached to Bug 193772.
1460
1461         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1462         (+[WebKitTestRunnerEvent mouseLocation]):
1463         - This works around a crash on an internal build.
1464
1465 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1466
1467         Fix the build after r243354
1468         https://bugs.webkit.org/show_bug.cgi?id=196138
1469         <rdar://problem/49145951>
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1472         (TEST):
1473         * TestWebKitAPI/ios/UIKitSPI.h:
1474
1475 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1476
1477         Adopt UIWKDocumentContext
1478         https://bugs.webkit.org/show_bug.cgi?id=196040
1479         <rdar://problem/48642440>
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1484         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1485         (makeRequest):
1486         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1487         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1488         (applyStyle):
1489         (TEST):
1490         Add tests for UIWKDocumentContext.
1491
1492         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1493         (TEST):
1494         (recursiveFindWKContentView): Deleted.
1495         * TestWebKitAPI/cocoa/TestWKWebView.h:
1496         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1497         (recursiveFindWKContentView):
1498         (-[TestWKWebView wkContentView]):
1499         * TestWebKitAPI/ios/UIKitSPI.h:
1500         Share the WKContentView finding code between tests.
1501
1502 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1503
1504         [iOS WK2] Turn on async overflow scrolling by default
1505         https://bugs.webkit.org/show_bug.cgi?id=196011
1506         rdar://problem/48453859
1507
1508         Reviewed by Antti Koivisto.
1509         
1510         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1511         since so many basic layout tests have different results when compositing is triggered for
1512         overflow.
1513         
1514         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1515
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::TestController::resetPreferencesToConsistentValues):
1518
1519 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1520
1521         [ews-build] Retry API test in case of failures
1522         https://bugs.webkit.org/show_bug.cgi?id=196004
1523
1524         Reviewed by Lucas Forschler.
1525
1526         * BuildSlaveSupport/ews-build/steps.py:
1527         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1528         (CompileWebKitToT.doStepIf): Ditto.
1529         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1530         (ReRunAPITests): Re-run API tests.
1531         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1532         (RunAPITestsWithoutPatch): Run API tests without patch.
1533         (RunAPITestsWithoutPatch.doStepIf):
1534         (RunAPITestsWithoutPatch.hideStepIf):
1535         (RunAPITestsWithoutPatch.evaluateCommand):
1536         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1537         (AnalyzeAPITestsResults.start):
1538         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1539         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1540         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1541         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1542
1543 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1544
1545         [ews-build] Update queues configurations
1546         https://bugs.webkit.org/show_bug.cgi?id=196074
1547
1548         Reviewed by Dewei Zhu.
1549
1550         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1551         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1552
1553 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1554
1555         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1556         https://bugs.webkit.org/show_bug.cgi?id=195680
1557         <rdar://problem/48903534>
1558
1559         Unreviewed infrastructure fix.
1560
1561         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1562         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1563
1564 2019-03-21  Andy Estes  <aestes@apple.com>
1565
1566         [iOS] Apple Pay should be available in documents with no user agent scripts
1567         https://bugs.webkit.org/show_bug.cgi?id=196061
1568         <rdar://problem/48649391>
1569
1570         Reviewed by Brady Eidson.
1571
1572         Added API tests and related infrastructure.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1576         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1577         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1580         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1581         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1582         * TestWebKitAPI/cocoa/TestProtocol.mm:
1583         (-[TestProtocol startLoading]):
1584         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1585         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1586         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1587         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1588
1589 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1590
1591         REGRESSSION (r243297): webkitpy tests broken
1592         https://bugs.webkit.org/show_bug.cgi?id=196108
1593
1594         Reviewed by Aakash Jain.
1595
1596         r243297 updated contributors.json, which broke a few unit tests.
1597
1598         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1599         (IRCCommandTest.test_whois):
1600         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1601
1602 2019-03-21  Chris Dumez  <cdumez@apple.com>
1603
1604         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1605         https://bugs.webkit.org/show_bug.cgi?id=196041
1606         <rdar://problem/49083230>
1607
1608         Reviewed by Alex Christensen.
1609
1610         Add API test coverage.
1611
1612         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1613         (TEST):
1614
1615 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1616
1617         Add SPI to inform applications of WKContentRuleList actions
1618         https://bugs.webkit.org/show_bug.cgi?id=195965
1619         <rdar://problem/42664365>
1620
1621         Reviewed by Geoff Garen.
1622
1623         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1624         (TestWebKitAPI::allActionsForResourceLoad):
1625         (TestWebKitAPI::testRequest):
1626         (TestWebKitAPI::TEST_F):
1627         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1628         (Notification::description):
1629         (Notification::operator== const):
1630         (toVector):
1631         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1632         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1633         (makeContentRuleList):
1634         (TEST):
1635         (makeWarnContentRuleList): Deleted.
1636
1637 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1638
1639         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1640         https://bugs.webkit.org/show_bug.cgi?id=196088
1641
1642         Reviewed by Brian Burg.
1643
1644         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1645         Support checks when only one platform is specified. Also deprecate macosx() and
1646         force the use of macos() instead.
1647
1648         * Scripts/webkitpy/style/checkers/cpp.py:
1649         (check_min_versions_of_wk_api_available):
1650         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1651         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1652
1653 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1654
1655         Update status inactive committers' status to 'contributor'.
1656
1657         * Scripts/webkitpy/common/config/contributors.json:
1658
1659 2019-03-21  Xan Lopez  <xan@igalia.com>
1660
1661         [JSC][x86] Drop support for x87 floating point
1662         https://bugs.webkit.org/show_bug.cgi?id=194853
1663
1664         Reviewed by Don Olmstead.
1665
1666         Force SSE2 on x86/32bit builds.
1667
1668         * Scripts/webkitdirs.pm:
1669         (generateBuildSystemFromCMakeProject):
1670
1671 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1672
1673         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1674         https://bugs.webkit.org/show_bug.cgi?id=196073
1675
1676         Reviewed by Michael Catanzaro.
1677
1678         Add test cases to check functions and constructors with no arguments but receiving user data.
1679
1680         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1681         (checkUserData):
1682         (testJSCFunction):
1683         (fooCreateWithUserData):
1684         (testJSCClass):
1685
1686 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1687
1688         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1689
1690         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1691
1692         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1693
1694 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1695
1696         [GTK][WPE] Add API to provide geolocation information
1697         https://bugs.webkit.org/show_bug.cgi?id=195940
1698
1699         Reviewed by Michael Catanzaro.
1700
1701         Add a new test to check the new API.
1702
1703         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1704         (testGeolocationManagerCurrentPosition):
1705         (testGeolocationManagerWatchPosition):
1706         (beforeAll):
1707         (afterAll):
1708         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1709         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1710         (beforeAll): Ditto.
1711         * TestWebKitAPI/glib/CMakeLists.txt:
1712
1713 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1714
1715         [GLib] Returning G_TYPE_OBJECT from a method does not work
1716         https://bugs.webkit.org/show_bug.cgi?id=195574
1717
1718         Reviewed by Michael Catanzaro.
1719
1720         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1721
1722         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1723         (getGFile):
1724         (getParent):
1725         (createGString):
1726         (getGString):
1727         (getGStringCopyWillRaise):
1728         (getGStringCopy):
1729         (getGStringStr):
1730         (getGStringLen):
1731         (freeGString):
1732         (testJSCClass):
1733
1734 2019-03-20  Saam Barati  <sbarati@apple.com>
1735
1736         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1737         https://bugs.webkit.org/show_bug.cgi?id=195721
1738
1739         Reviewed by Filip Pizlo.
1740
1741         * Scripts/run-javascriptcore-tests:
1742
1743 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1744
1745         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1746         https://bugs.webkit.org/show_bug.cgi?id=196049
1747
1748         Reviewed by Tim Horton.
1749
1750         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1751         overflow scrolling in general, so rename it.
1752
1753         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1754
1755 2019-03-20  Daniel Bates  <dabates@apple.com>
1756
1757         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1758         https://bugs.webkit.org/show_bug.cgi?id=196031
1759         <rdar://problem/49078172>
1760
1761         Reviewed by Tim Horton.
1762
1763         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1764         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1765         same code path used when the Done button is pressed to dismiss the <select> picker.
1766
1767         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1768         (TestWebKitAPI::TEST):
1769
1770 2019-03-20  Chris Dumez  <cdumez@apple.com>
1771
1772         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1773         https://bugs.webkit.org/show_bug.cgi?id=196029
1774         <rdar://problem/48954651>
1775
1776         Reviewed by Tim Horton.
1777
1778         Add API test coverage.
1779
1780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1781
1782 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1783
1784         [ews-build] Improve failure summary string for ApplyPatch step
1785         https://bugs.webkit.org/show_bug.cgi?id=195995
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         * BuildSlaveSupport/ews-build/steps.py:
1790         (ApplyPatch.getResultSummary): Override getResultSummary.
1791
1792 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1793
1794         AX: Implement support for new meter ARIA role
1795         https://bugs.webkit.org/show_bug.cgi?id=195966
1796
1797         Reviewed by Chris Fleizach.
1798
1799         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1800         to AXLevelIndicator.
1801
1802         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1803
1804 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1805
1806         [WebAuthN] Implement FIDO AppID extension
1807         https://bugs.webkit.org/show_bug.cgi?id=143491
1808         <rdar://problem/48298273>
1809
1810         Reviewed by Brent Fulgham.
1811
1812         Add a test that covers the new flag of convertToU2fSignCommand.
1813
1814         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1817         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1818         (TestWebKitAPI::TEST):
1819
1820 2019-03-19  Keith Rollin  <krollin@apple.com>
1821
1822         Add support for more platforms to generate-xcfilelists
1823         https://bugs.webkit.org/show_bug.cgi?id=195977
1824
1825         Reviewed by Alexey Proskuryakov.
1826
1827         generate-xcfilelists incorrectly complains when involved with building
1828         WebKit for iphonesimulator:
1829
1830             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1831             …
1832             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1833
1834         Address this by teaching generate-xcfilelists about more platforms.
1835
1836         * Scripts/generate-xcfilelists:
1837
1838 2019-03-19  John Wilander  <wilander@apple.com>
1839
1840         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1841         https://bugs.webkit.org/show_bug.cgi?id=195923
1842         <rdar://problem/49001272>
1843
1844         Reviewed by Alex Christensen.
1845
1846         This patch does the following to the TestRunner:
1847         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1848         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1849         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1850
1851         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1852         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1853         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1854         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1855         * WebKitTestRunner/TestController.cpp:
1856         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1857         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1858         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1859         * WebKitTestRunner/TestController.h:
1860         * WebKitTestRunner/TestInvocation.cpp:
1861         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1862
1863 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1864
1865         [CMake] Support more clang and gcc sanitizers
1866         https://bugs.webkit.org/show_bug.cgi?id=195956
1867
1868         Reviewed by Michael Catanzaro.
1869
1870         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1871
1872 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1873
1874         [ews-build] Improve summary for PrintConfiguration step
1875         https://bugs.webkit.org/show_bug.cgi?id=195945
1876
1877         Reviewed by Lucas Forschler.
1878
1879         * BuildSlaveSupport/ews-build/steps.py:
1880         (PrintConfiguration.getResultSummary): Override getResultSummary.
1881
1882 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1883
1884         [ews-build] Improve summary for CheckOutSource step
1885         https://bugs.webkit.org/show_bug.cgi?id=195963
1886
1887         Reviewed by Lucas Forschler.
1888
1889         * BuildSlaveSupport/ews-build/steps.py:
1890         (CheckOutSource.getResultSummary):
1891
1892 2019-03-19  Daniel Bates  <dabates@apple.com>
1893
1894         [iOS] Focus not preserved when switching between tabs
1895         https://bugs.webkit.org/show_bug.cgi?id=195820
1896         <rdar://problem/43614450>
1897
1898         Reviewed by Brent Fulgham.
1899
1900         Add tests to ensure that we restore focus when resigning and becoming first responder.
1901
1902         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1903         (TestWebKitAPI::TEST):
1904
1905 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1906
1907         Make WTFLogChannelState and WTFLogLevel enum classes
1908         https://bugs.webkit.org/show_bug.cgi?id=195904
1909
1910         Reviewed by Eric Carlson.
1911
1912         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1913         (TestWebKitAPI::TEST_F):
1914
1915 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1916
1917         [GStreamer][EME] Backported mssdemux protection data crash fix
1918         https://bugs.webkit.org/show_bug.cgi?id=195918
1919
1920         Reviewed by Philippe Normand.
1921
1922         * gstreamer/jhbuild.modules:
1923         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1924
1925 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1926
1927         Unreviewed, rolling out r243132.
1928
1929         Broke GTK build
1930
1931         Reverted changeset:
1932
1933         "Make WTFLogChannelState and WTFLogLevel enum classes"
1934         https://bugs.webkit.org/show_bug.cgi?id=195904
1935         https://trac.webkit.org/changeset/243132
1936
1937 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1938
1939         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1940
1941         * Scripts/webkitdirs.pm:
1942         (builtDylibPathForName): Adjust the shared library name that's changed
1943         with the API version bump in r243073.
1944
1945 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1946
1947         Make WTFLogChannelState and WTFLogLevel enum classes
1948         https://bugs.webkit.org/show_bug.cgi?id=195904
1949
1950         Reviewed by Eric Carlson.
1951
1952         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1953         (TestWebKitAPI::TEST_F):
1954
1955 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1956
1957         Disable flaky test added in r2431100
1958         https://webkit.org/b/195785
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1961         (TestWebKitAPI::TEST):
1962         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1963
1964 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1965
1966         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1967         https://bugs.webkit.org/show_bug.cgi?id=195916
1968
1969         Reviewed by Tim Horton.
1970
1971         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1972         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1973
1974 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1975
1976         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1977
1978         * Scripts/webkitpy/common/config/contributors.json:
1979
1980 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1981
1982         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1983         https://bugs.webkit.org/show_bug.cgi?id=195785
1984
1985         Reviewed by Geoffrey Garen.
1986
1987         * TestWebKitAPI/TCPServer.cpp: Added.
1988         (TestWebKitAPI::TCPServer::TCPServer):
1989         (TestWebKitAPI::TCPServer::~TCPServer):
1990         (TestWebKitAPI::TCPServer::socketBindListen):
1991         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1992         * TestWebKitAPI/TCPServer.h: Added.
1993         (TestWebKitAPI::TCPServer::port const):
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1996         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1997         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1998         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1999         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2000         (TestWebKitAPI::respondSlowly):
2001         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2002         (TestWebKitAPI::downloadAtRate):
2003         (TestWebKitAPI::TEST):
2004
2005 2019-03-18  Saam Barati  <sbarati@apple.com>
2006
2007         Add a plan file for JetStream 2
2008         https://bugs.webkit.org/show_bug.cgi?id=190734
2009
2010         Reviewed by Mark Lam.
2011
2012         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2013
2014 2019-03-18  Chris Dumez  <cdumez@apple.com>
2015
2016         Delay WebProcess launch until a load is triggered in a Web view
2017         https://bugs.webkit.org/show_bug.cgi?id=195758
2018         <rdar://problem/48126013>
2019
2020         Reviewed by Geoff Garen.
2021
2022         Add API test coverage. Also update some existing API tests to not expect
2023         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2024
2025         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2026         (TestWebKitAPI::TEST):
2027         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2030         (TEST):
2031         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2032         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2033         (TEST):
2034         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2035         (TEST):
2036         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2037
2038 2019-03-18  Xan Lopez  <xan@igalia.com>
2039
2040         [CMake] Prevent potential warning when determining $architecture
2041         https://bugs.webkit.org/show_bug.cgi?id=195891
2042
2043         Reviewed by Michael Catanzaro.
2044
2045         It's possible for generateBuildSystemForCMakeProject to be called
2046         before determineArchitecture() is ever called. This will make the
2047         first eq check with $architecture to be bogus (and print a
2048         warning). Change that to an eq check with architecture(), which
2049         implicitly calls determineArchitecture() if needed, and change all
2050         the other similar cases in the method in the same way to prevent
2051         future bugs like this one.
2052
2053         * Scripts/webkitdirs.pm:
2054         (generateBuildSystemFromCMakeProject):
2055
2056 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2057
2058         [WPE] Tarballs generated with “make dist” cannot build documentation
2059         https://bugs.webkit.org/show_bug.cgi?id=195885
2060
2061         Reviewed by Carlos Garcia Campos.
2062
2063         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2064
2065 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2066
2067         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2068         https://bugs.webkit.org/show_bug.cgi?id=195883
2069
2070         Reviewed by Carlos Garcia Campos.
2071
2072         * gtkdoc/gtkdoc.py:
2073         (GTKDoc._run_command): When commands fail to run, include the full command line for
2074         the program invocation and the output it has generated on the standard error stream.
2075
2076 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2077
2078         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2079         https://bugs.webkit.org/show_bug.cgi?id=195786
2080
2081         Reviewed by Philippe Normand.
2082
2083         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2084         * wpe/jhbuild.modules: Ditto.
2085
2086 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-build] Don't run clean builds on EWS builders
2089         https://bugs.webkit.org/show_bug.cgi?id=195851
2090
2091         Reviewed by Geoffrey Garen.
2092
2093         * BuildSlaveSupport/ews-build/factories.py:
2094
2095 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2096
2097         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2098         https://bugs.webkit.org/show_bug.cgi?id=195849
2099
2100         Reviewed by Chris Dumez.
2101
2102         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2105         (runWebsiteDataStoreCustomPaths):
2106
2107 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2108
2109         webkitpy: Upload test results
2110         https://bugs.webkit.org/show_bug.cgi?id=195755
2111         <rdar://problem/48896182>
2112
2113         Reviewed by Aakash Jain.
2114
2115         Establish a new format for uploading results that is not tied to layout tests, apply
2116         that format to webkitpy tests.
2117
2118         * Scripts/webkitpy/common/checkout/scm/git.py:
2119         (Git.native_branch): Return what branch the current checkout is on.
2120         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2121         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2122         * Scripts/webkitpy/common/checkout/scm/svn.py:
2123         (SVN.native_branch): Ditto.
2124         * Scripts/webkitpy/common/system/platforminfo.py:
2125         (PlatformInfo.build_version): Return a build version for Mac.
2126         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2127         (MockPlatformInfo.__init__):
2128         (MockPlatformInfo.build_version):
2129         * Scripts/webkitpy/results: Added.
2130         * Scripts/webkitpy/results/__init__.py: Added.
2131         * Scripts/webkitpy/results/options.py: Added.
2132         (upload_options): OptParse list for upload options.
2133         * Scripts/webkitpy/results/upload.py: Added.
2134         (Upload): Class which enforces the upload format expected by the results server.
2135         (Upload.Expectations):
2136         (Upload.create_configuration):
2137         (Upload.create_commit):
2138         (Upload.create_details):
2139         (Upload.create_run_stats):
2140         (Upload.create_test_result):
2141         (Upload.__init__):
2142         (Upload.Encoder): Encode Upload object as json.
2143         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2144         * Scripts/webkitpy/results/upload_unittest.py: Added.
2145         * Scripts/webkitpy/test/main.py:
2146         (Tester._parse_args): Add upload arguments.
2147         (Tester._run_tests): Allow results to be uploaded.
2148         * Scripts/webkitpy/test/runner.py:
2149         (Runner.__init__): Record which tests were run, rather than just counting them.
2150         (Runner.handle):
2151         * Scripts/webkitpy/test/runner_unittest.py:
2152         (RunnerTest.test_run):
2153         * Scripts/webkitpy/thirdparty/__init__.py:
2154         (AutoinstallImportHook.find_module): Add requests auto-install.
2155         (AutoinstallImportHook._install_requests):
2156         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2157         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2158
2159 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2160
2161         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2162         https://bugs.webkit.org/show_bug.cgi?id=195810
2163
2164         Reviewed by Tim Horton.
2165
2166         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2167         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2168         ending certain layout tests.
2169
2170         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2171         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2172         (-[TestRunnerWKWebView dealloc]):
2173         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2174
2175         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2176         helper method when destroying the web view, and when resetting state between tests.
2177
2178         * WebKitTestRunner/ios/TestControllerIOS.mm:
2179         (WTR::TestController::platformResetStateToConsistentValues):
2180
2181         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2182
2183 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2184
2185         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2186         https://bugs.webkit.org/show_bug.cgi?id=190350
2187         <rdar://problem/45089503>
2188
2189         Reviewed by Geoffrey Garen.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2193         (TEST):
2194         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2195         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2196         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2197         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2198         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2199         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2200         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2201         (runTest):
2202         (createDirectories):
2203         (TEST):
2204         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2205         (TEST):
2206         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2207         (TEST):
2208
2209 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2210
2211         Add support to WebPage for getting the contents as an attributed string.
2212         https://bugs.webkit.org/show_bug.cgi?id=195636
2213         rdar://problem/45055697
2214
2215         Reviewed by Tim Horton.
2216
2217         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2218         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2219
2220 2019-03-15  Chris Dumez  <cdumez@apple.com>
2221
2222         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2223         https://bugs.webkit.org/show_bug.cgi?id=195747
2224
2225         Reviewed by Geoff Garen.
2226
2227         Add API test coverage.
2228
2229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2230
2231 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2232
2233         Unreviewed, rolling out r242952.
2234
2235         Causing API failures on iOS Simulator
2236
2237         Reverted changeset:
2238
2239         "[PSON] Make sure the WebProcessCache is leverage when
2240         relaunching a process after termination"
2241         https://bugs.webkit.org/show_bug.cgi?id=195747
2242         https://trac.webkit.org/changeset/242952
2243
2244 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2245
2246         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2247         https://bugs.webkit.org/show_bug.cgi?id=195740
2248
2249         Reviewed by Ross Kirsling.
2250
2251         window.open doesn't work for WebKitBrowserWindow because it is not
2252         implemented yet.
2253
2254         1. Implemented createNewPage callback of WKPageUIClient.
2255         2. Changed MainWindow to take a BrowserWindow factory function
2256           instead of BrowserWindowType to be flexible to create
2257           BrowserWindow with extra settings.
2258         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2259           because it is not relevant with MainWindow anymore.
2260
2261         * MiniBrowser/win/Common.cpp:
2262         (parseCommandLine):
2263         * MiniBrowser/win/Common.h:
2264         (CommandLineOptions::CommandLineOptions):
2265         * MiniBrowser/win/MainWindow.cpp:
2266         (MainWindow::MainWindow):
2267         (MainWindow::create):
2268         (MainWindow::init):
2269         (MainWindow::WndProc):
2270         * MiniBrowser/win/MainWindow.h:
2271         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2272         (PrintWebUIDelegate::createWebViewWithRequest):
2273         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2274         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2275         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2276         (WebKitBrowserWindow::updateProxySettings):
2277         (WebKitBrowserWindow::createNewPage):
2278         * MiniBrowser/win/WebKitBrowserWindow.h:
2279         * MiniBrowser/win/WinMain.cpp:
2280         (wWinMain):
2281
2282 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2283
2284         Make it possible to test scrolling tree layer manipulation more easily
2285         https://bugs.webkit.org/show_bug.cgi?id=195780
2286
2287         Reviewed by Tim Horton.
2288         
2289         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2290         cuts off communication of scrolling tree scrolls back to the web process
2291         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2292         allows tests to trigger scrolls which run the scrolling tree layer positioning
2293         logic, but never get another commit from the web process that might mask
2294         scrolling tree bugs.
2295         
2296         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2297         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2298         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2299
2300         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2301         (WTR::UIScriptController::scrollUpdatesDisabled const):
2302         (WTR::UIScriptController::setScrollUpdatesDisabled):
2303         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2304         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2305         (WTR::UIScriptController::scrollUpdatesDisabled const):
2306         (WTR::UIScriptController::setScrollUpdatesDisabled):
2307         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2308         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2309         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2310         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2311         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2312         * WebKitTestRunner/ios/TestControllerIOS.mm:
2313         (WTR::TestController::platformResetStateToConsistentValues):
2314         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2315         (WTR::UIScriptController::scrollUpdatesDisabled const):
2316         (WTR::UIScriptController::setScrollUpdatesDisabled):
2317
2318 2019-03-14  Youenn Fablet  <youenn@apple.com>
2319
2320         Move IDB storage in private browsing mode to NetworkProcess
2321         https://bugs.webkit.org/show_bug.cgi?id=195602
2322
2323         Reviewed by Brady Eidson.
2324
2325         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2326         (TEST):
2327
2328 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2329
2330         [ews-build] Make descriptionDone messages more readable
2331         https://bugs.webkit.org/show_bug.cgi?id=195760
2332
2333         Reviewed by Lucas Forschler.
2334
2335         * BuildSlaveSupport/ews-build/steps.py:
2336         * BuildSlaveSupport/ews-build/steps_unittest.py:
2337
2338 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2339
2340         [ews-build] Generate status-bubble hover-over messages
2341         https://bugs.webkit.org/show_bug.cgi?id=195680
2342
2343         Reviewed by Lucas Forschler.
2344
2345         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2346         (StatusBubble):
2347         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2348         on hover-over.
2349         (StatusBubble._iso_time):
2350         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2351         hover-over message.
2352         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2353
2354 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2355
2356         [ews-app] Gracefully handle the case when state_string is None
2357         https://bugs.webkit.org/show_bug.cgi?id=195753
2358
2359         Reviewed by Lucas Forschler.
2360
2361         * BuildSlaveSupport/ews-app/ews/models/build.py:
2362         * BuildSlaveSupport/ews-app/ews/models/step.py:
2363
2364 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2365
2366         [ews-app] Status bubble display pending for currently running build step
2367         https://bugs.webkit.org/show_bug.cgi?id=195744
2368
2369         Reviewed by Lucas Forschler.
2370
2371         * BuildSlaveSupport/ews-build/events.py:
2372         (Events.stepStarted): If state_string is pending, replace it with step name.
2373
2374 2019-03-14  Chris Dumez  <cdumez@apple.com>
2375
2376         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2377         https://bugs.webkit.org/show_bug.cgi?id=195750
2378
2379         Reviewed by Geoffrey Garen.
2380
2381         Add API test coverage.
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2384         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2385         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2386         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2387
2388 2019-03-14  Chris Dumez  <cdumez@apple.com>
2389
2390         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2391         https://bugs.webkit.org/show_bug.cgi?id=195747
2392
2393         Reviewed by Geoff Garen.
2394
2395         Add API test coverage.
2396
2397         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2398
2399 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2402         https://bugs.webkit.org/show_bug.cgi?id=195725
2403         <rdar://problem/48545062>
2404
2405         Reviewed by Tim Horton.
2406
2407         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2408         handler is nil.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2411         (TestWebKitAPI::TEST):
2412
2413 2019-03-13  Sam Weinig  <sam@webkit.org>
2414
2415         Add utility function to allow easy reverse range-based iteration of a container
2416         https://bugs.webkit.org/show_bug.cgi?id=195542
2417
2418         Reviewed by Antti Koivisto.
2419
2420         * TestWebKitAPI/CMakeLists.txt:
2421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2422         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2423         (TestWebKitAPI::TEST):
2424         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2425
2426 2019-03-13  Chris Dumez  <cdumez@apple.com>
2427
2428         Use a ServiceWorker process per registrable domain
2429         https://bugs.webkit.org/show_bug.cgi?id=195649
2430
2431         Reviewed by Youenn Fablet.
2432
2433         Update API test coverage.
2434
2435         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2436
2437 2019-03-13  Chris Dumez  <cdumez@apple.com>
2438
2439         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2440         https://bugs.webkit.org/show_bug.cgi?id=195684
2441         <rdar://problem/48294714>
2442
2443         Reviewed by Antti Koivisto.
2444
2445         Add API test coverage.
2446
2447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2448
2449 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-app] Remove unused patch view
2452         https://bugs.webkit.org/show_bug.cgi?id=195669
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/ews-app/ews/urls.py:
2457         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2458
2459 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2460
2461         [ews-app] Use Buildbot result code variables
2462         https://bugs.webkit.org/show_bug.cgi?id=195668
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2467         (Buildbot): Added Buildbot result code variables.
2468         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2469         (StatusBubble._build_bubble): Used Buildbot result code variables.
2470
2471 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2472
2473         [Flatpak] Expand submodule recursively
2474         https://bugs.webkit.org/show_bug.cgi?id=195672
2475
2476         Building WPE with flatpak was impossible without that as it was raising an exception.
2477         Also update wpebackend-fdo to match what is built in jhbuild
2478
2479         Reviewed by Philippe Normand.
2480
2481         * flatpak/flatpakutils.py:
2482         (expand_submodules_recurse):
2483         (expand_manifest):
2484         * flatpak/org.webkit.WPEModules.yaml:
2485
2486 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-app] status bubble should be hidden for certain builds
2489         https://bugs.webkit.org/show_bug.cgi?id=194597
2490
2491         Reviewed by Dewei Zhu.
2492
2493         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2494         (StatusBubble._build_bubble):
2495         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2496         because the patch didn't have relevant changes.
2497         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2498         in production yet.
2499
2500 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2501
2502         [Win] Fix a slew of simple clang-cl warnings.
2503         https://bugs.webkit.org/show_bug.cgi?id=195652
2504
2505         Reviewed by Don Olmstead.
2506
2507         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2508         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2509
2510 2019-03-12  Justin Fan  <justin_fan@apple.com>
2511
2512         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2513         https://bugs.webkit.org/show_bug.cgi?id=195518
2514         <rdar://problem/46322356>
2515
2516         Reviewed by Myles C. Maxfield.
2517
2518         * DumpRenderTree/DerivedSources-input.xcfilelist:
2519         * DumpRenderTree/DerivedSources-output.xcfilelist:
2520
2521 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2522
2523         Unreviewed, rolling out r242825.
2524         https://bugs.webkit.org/show_bug.cgi?id=195648
2525
2526         "Broke webkitpy tests with my change to
2527         lldb_dump_class_layout.py" (Requested by rmorisset on
2528         #webkit).
2529
2530         Reverted changeset:
2531
2532         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2533         classes with suspicious padding"
2534         https://bugs.webkit.org/show_bug.cgi?id=195573
2535         https://trac.webkit.org/changeset/242825
2536
2537 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2538
2539         [ews-build] Show status bubbles while the patch is waiting in queue
2540         https://bugs.webkit.org/show_bug.cgi?id=195618
2541
2542         Reviewed by Lucas Forschler.
2543
2544         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2545         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2546         enabled in initial deployment.
2547         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2548         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2549         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2550         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2551         (StatusBubble._build_bubbles_for_patch):
2552
2553 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2554
2555         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2556         https://bugs.webkit.org/show_bug.cgi?id=195573
2557
2558         Reviewed by Simon Fraser.
2559
2560         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2561
2562         * Scripts/dump-class-layout:
2563         (main):
2564         * lldb/lldb_dump_class_layout.py:
2565         (ClassLayout.__init__):
2566         (ClassLayout._compute_padding_recursive):
2567         (LLDBDebuggerInstance.dump_layout_for_classname):
2568         (LLDBDebuggerInstance):
2569         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2570         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2571
2572 2019-03-12  Chris Dumez  <cdumez@apple.com>
2573
2574         Device Orientation access permission should be denied unless explicitly granted by the client
2575         https://bugs.webkit.org/show_bug.cgi?id=195625
2576
2577         Reviewed by Youenn Fablet.
2578
2579         add API test coverage.
2580
2581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2582         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2583         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2584         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2585         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2586         (runDeviceOrientationTest):
2587         (TEST):
2588         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2589         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2590
2591 2019-03-12  Jer Noble  <jer.noble@apple.com>
2592
2593         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2594         https://bugs.webkit.org/show_bug.cgi?id=195137
2595         <rdar://problem/48810307>
2596
2597         Reviewed by Eric Carlson.
2598
2599         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2600         (TestWebKitAPI::TEST):
2601
2602 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-build] Change urls from uat to production
2605         https://bugs.webkit.org/show_bug.cgi?id=195566
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * BuildSlaveSupport/ews-app/ews/config.py:
2610         * BuildSlaveSupport/ews-build/events.py:
2611         * BuildSlaveSupport/ews-build/steps.py:
2612
2613 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2614
2615         [ews-build] change max_builds for local-worker to 1
2616         https://bugs.webkit.org/show_bug.cgi?id=195568
2617
2618         Reviewed by Lucas Forschler.
2619
2620         * BuildSlaveSupport/ews-build/loadConfig.py:
2621
2622 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2623
2624         Fix the build
2625
2626         * TestRunnerShared/spi/PencilKitTestSPI.h:
2627         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2628
2629 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2630
2631         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2632         https://bugs.webkit.org/show_bug.cgi?id=194131
2633
2634         Reviewed by Michael Catanzaro.
2635
2636         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2637         (uriChanged):
2638         (testUnfinishedSubresourceLoad):
2639         (serverCallback):
2640         (beforeAll):
2641
2642 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2643
2644         WTF::Expected should use std::addressof instead of operator&
2645         https://bugs.webkit.org/show_bug.cgi?id=195604
2646
2647         Reviewed by Myles Maxfield.
2648
2649         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2650         (TestWebKitAPI::Unique::Unique):
2651         (TestWebKitAPI::Unique::operator&):
2652         (TestWebKitAPI::TEST):
2653
2654 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2655
2656         Add Optional to Forward.h.
2657         https://bugs.webkit.org/show_bug.cgi?id=195586
2658
2659         Reviewed by Darin Adler.
2660
2661         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2662         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2663         Remove unnecessary includes from headers.
2664
2665 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2666
2667         Add testing API to hit-test and scroll overflow scrollers
2668         https://bugs.webkit.org/show_bug.cgi?id=195278
2669
2670         Reviewed by Antti Koivisto.
2671         
2672         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2673         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2674         
2675         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2676
2677         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2678         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2679         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2680         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2681         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2682         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2683         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2684         (WTR::enclosingScrollViewIncludingSelf):
2685         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2686
2687 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2688
2689         API test WebKit.RequestTextInputContext fails on iOS
2690         https://bugs.webkit.org/show_bug.cgi?id=195585
2691
2692         Reviewed by Wenson Hsieh and Simon Fraser.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2695         (applyStyle):
2696         (TEST):
2697         Add a viewport, so that the coordinates match up on iOS.
2698         Scroll by moving the UIScrollView's contentOffset.
2699
2700 2019-03-11  Chris Dumez  <cdumez@apple.com>
2701
2702         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2703         https://bugs.webkit.org/show_bug.cgi?id=195506
2704         <rdar://problem/48733477>
2705
2706         Reviewed by Alex Christensen.
2707
2708         Add API test coverage.
2709
2710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2711
2712 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2713
2714         Adding myself to contributors.json
2715
2716         Unreviewed, addming myself to contributors.json .
2717
2718         * Scripts/webkitpy/common/config/contributors.json:
2719
2720 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2721
2722         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2723         https://bugs.webkit.org/show_bug.cgi?id=195511
2724         <rdar://problem/44873269>
2725
2726         Reviewed by Darin Adler.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2729         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2730         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2731         (TEST_F):
2732
2733 2019-03-11  Chris Dumez  <cdumez@apple.com>
2734
2735         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2736         https://bugs.webkit.org/show_bug.cgi?id=195561
2737
2738         Reviewed by Youenn Fablet.
2739
2740         Make sure the JS in the test requests for permission to receive device orientation events.
2741
2742         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2743
2744 2019-03-11  Youenn Fablet  <youenn@apple.com>
2745
2746         Allow storage quota increase by default in WTR
2747         https://bugs.webkit.org/show_bug.cgi?id=195541
2748
2749         Reviewed by Geoffrey Garen.
2750
2751         Allow storage quota increase by default in WTR.
2752         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2753         Use this for tests that explicitly need cache increase.
2754
2755         Instead of increasing quota by 2, make sure the next request is
2756         granted by adding all given parameters.
2757
2758         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2759         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2760         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2761         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2763         * WebKitTestRunner/TestController.cpp:
2764         (WTR::TestController::setAllowStorageQuotaIncrease):
2765         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2766         * WebKitTestRunner/TestController.h:
2767         * WebKitTestRunner/TestInvocation.cpp:
2768         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2769         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2770         (WTR::TestController::cocoaResetStateToConsistentValues):
2771         (WTR::TestController::setAllowStorageQuotaIncrease):
2772         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2773         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2774         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2775
2776 2019-03-11  Xan Lopez  <xan@igalia.com>
2777
2778         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2779         https://bugs.webkit.org/show_bug.cgi?id=194147
2780
2781         Reviewed by Michael Saboff.
2782
2783         To make --32-bit work correctly on Linux/64bit we need to:
2784
2785         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2786         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2787         unfortunately CMake only allows us to do this during
2788         crosscompilation, which is overkill here.
2789         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2790         pkg-config detection module uses the x86 .pc files instead of the
2791         x86_64 ones.
2792         - Set the -m32 flags for the compiler.
2793
2794         * Scripts/webkitdirs.pm:
2795         (generateBuildSystemFromCMakeProject):
2796
2797 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2798
2799         Add MotionMark-1.1 plan file for run-benchmark script.
2800         https://bugs.webkit.org/show_bug.cgi?id=195481
2801
2802         Rubber-stamped by Darin Adler.
2803
2804         Run-benchmark script should support MontionMark-1.1.
2805
2806         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2807
2808 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2809
2810         [ews-app] Add support for submit-to-ews url
2811         https://bugs.webkit.org/show_bug.cgi?id=195477
2812
2813         Reviewed by Lucas Forschler.
2814
2815         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2816         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2817         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2818         * BuildSlaveSupport/ews-app/ews/urls.py:
2819         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2820
2821 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2822
2823         Unreviewed, rolling out r242688, r242643, r242624.
2824
2825         Caused multiple layout test failures and crashes on iOS and macOS.
2826
2827         Reverted changeset:
2828
2829         "requestAnimationFrame should execute before the next frame"
2830         https://bugs.webkit.org/show_bug.cgi?id=177484
2831         https://trac.webkit.org/changeset/242624/webkit
2832
2833         * Tracing/SystemTracePoints.plist:
2834
2835 2019-03-11  John Wilander  <wilander@apple.com>
2836
2837         Resource Load Statistics: Make it possible exclude localhost from classification
2838         https://bugs.webkit.org/show_bug.cgi?id=195474
2839         <rdar://problem/47520577>
2840
2841         Reviewed by Brent Fulgham.
2842
2843         This patch allows for localhost to be excluded from classification and
2844         treatment as a prevalent resource.
2845
2846         The WebKit Tools change adds a new function called
2847         testRunner.setStatisticsIsRunningTest() which can be used to control this
2848         behavior.
2849
2850         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2851         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2852         (WTR::TestRunner::setStatisticsIsRunningTest):
2853         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2854         * WebKitTestRunner/TestController.cpp:
2855         (WTR::TestController::setStatisticsIsRunningTest):
2856         * WebKitTestRunner/TestController.h:
2857         * WebKitTestRunner/TestInvocation.cpp:
2858         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2859
2860 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2863         https://bugs.webkit.org/show_bug.cgi?id=195560
2864
2865         Reviewed by Lucas Forschler.
2866
2867         * BuildSlaveSupport/ews-build/master.cfg:
2868
2869 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2870
2871         Unreviewed, rolling out r242698.
2872
2873         API test crashes on bots.
2874
2875         Reverted changeset:
2876
2877         "Add a WKContentRuleList variant that uses copied memory
2878         instead of mmap'd shared memory for class A containerized
2879         apps"
2880         https://bugs.webkit.org/show_bug.cgi?id=195511
2881         https://trac.webkit.org/changeset/242698
2882
2883 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2884
2885         [WPE] Enable web process sandbox
2886         https://bugs.webkit.org/show_bug.cgi?id=195169
2887
2888         Reviewed by Daniel Bates.
2889
2890         * wpe/install-dependencies:
2891         * wpe/jhbuild.modules:
2892
2893 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2894
2895         [ews-app] Use port 17000 for worker communication
2896         https://bugs.webkit.org/show_bug.cgi?id=195558
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * BuildSlaveSupport/ews-build/master.cfg:
2901
2902 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-build] unit-tests fail when passwords.json is missing
2905         https://bugs.webkit.org/show_bug.cgi?id=195557
2906
2907         Reviewed by Lucas Forschler.
2908
2909         * BuildSlaveSupport/ews-build/loadConfig.py:
2910         (loadBuilderConfig):
2911         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2912         (ConfigDotJSONTest.test_configuration):
2913         * BuildSlaveSupport/ews-build/master.cfg:
2914
2915 2019-03-11  Truitt Savell  <tsavell@apple.com>
2916
2917         Unreviewed, rolling out r242702.
2918
2919         Broke High Sierra builders.
2920
2921         Reverted changeset:
2922
2923         "Add utility function to allow easy reverse range-based
2924         iteration of a container"
2925         https://bugs.webkit.org/show_bug.cgi?id=195542
2926         https://trac.webkit.org/changeset/242702
2927
2928 2019-03-11  Sam Weinig  <sam@webkit.org>
2929
2930         Add utility function to allow easy reverse range-based iteration of a container
2931         https://bugs.webkit.org/show_bug.cgi?id=195542
2932
2933         Reviewed by Antti Koivisto.
2934
2935         * TestWebKitAPI/CMakeLists.txt:
2936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2937         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2938         (TestWebKitAPI::TEST):
2939         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2940
2941 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2942
2943         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2944         https://bugs.webkit.org/show_bug.cgi?id=195511
2945         <rdar://problem/44873269>
2946
2947         Reviewed by Darin Adler.
2948
2949         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2950         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2951         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2952         (TEST_F):
2953
2954 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2955
2956         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2957         https://bugs.webkit.org/show_bug.cgi?id=195499
2958
2959         Reviewed by Darin Adler.
2960
2961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2962         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2963         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2964         (-[WKWebView synchronouslyFocusTextInputContext:]):
2965         (applyStyle):
2966         (applyIframe):
2967         (TEST):
2968         Add some tests for this SPI.
2969
2970 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2971
2972         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2973         https://bugs.webkit.org/show_bug.cgi?id=181151
2974
2975         Reviewed by Don Olmstead.
2976
2977         * TestWebKitAPI/CMakeLists.txt:
2978         * TestWebKitAPI/PlatformWin.cmake:
2979         Enable TestWTF RunLoop tests in all platforms.
2980
2981         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2982         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2983         (TestWebKitAPI::DerivedOneShotTimer::fired):
2984         (TestWebKitAPI::TEST):
2985         Only a few platforms support nested RunLoop.
2986
2987         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2988         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2989
2990 2019-03-10  David Quesada  <david_quesada@apple.com>
2991
2992         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2993         https://bugs.webkit.org/show_bug.cgi?id=152480
2994
2995         Reviewed by Chris Dumez.
2996
2997         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2998         there are no additional references to the process pool besides the one held by
2999         the download, waits for the download to finish (in the sense that the
3000         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3001         measure, also check that the process pool has been deallocated at the end of the
3002         test. The test wouldn't be meaningful if the process pool were still alive.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3005         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3006         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3007             The download will be canceled because the delegate does not implement the
3008             method to decide the download's destination, so this is where we know the
3009             DownloadProxyMap is done with the DownloadProxy.
3010         (TEST):
3011
3012 2019-03-08  Chris Dumez  <cdumez@apple.com>
3013
3014         Add support for Device Orientation / Motion permission API
3015         https://bugs.webkit.org/show_bug.cgi?id=195329
3016         <rdar://problem/47645367>
3017
3018         Reviewed by Geoffrey Garen.
3019
3020         Add test infrastructure to help test the Device Orientation / Motion permission API.
3021
3022         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3023         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3024         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3025         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3026         * WebKitTestRunner/TestController.cpp:
3027         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3028         (WTR::TestController::createWebViewWithOptions):
3029         (WTR::TestController::resetStateToConsistentValues):
3030         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3031         * WebKitTestRunner/TestController.h:
3032         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3033         * WebKitTestRunner/TestInvocation.cpp:
3034         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3035
3036 2019-03-08  Saam barati  <sbarati@apple.com>
3037
3038         Add a compare-results script to compare benchmark results
3039         https://bugs.webkit.org/show_bug.cgi?id=195486
3040         <rdar://problem/48723397>
3041
3042         Reviewed by Geoffrey Garen.
3043
3044         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3045         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3046         to extend it to learn about our other benchmarks.
3047
3048         * Scripts/compare-results: Added.
3049         (readJSONFile):
3050         (detectJetStream2):
3051         (JetStream2Results):
3052         (detectSpeedometer2):
3053         (Speedometer2Results):
3054         (detectPLT5):
3055         (PLT5Results):
3056         (detectBenchmark):
3057         (biggerIsBetter):
3058         (ttest):
3059         (getOptions):
3060         (main):
3061
3062 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3063
3064         Ensure old tab state is cleared between iterations of run-benchmark
3065         https://bugs.webkit.org/show_bug.cgi?id=195393
3066         <rdar://problem/46885583>
3067
3068         Reviewed by Dewei Zhu.
3069
3070         a) ensure the default to restore state is not set
3071         b) terminate Safari correctly
3072         c) Set the system default to ignore Persistent State in Safari
3073
3074         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3075         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3076         (OSXBrowserDriver.prepare_env): 
3077         (OSXBrowserDriver.restore_env):
3078         (OSXBrowserDriver.close_browsers):
3079         (OSXBrowserDriver._terminate_processes):
3080         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3081         (OSXChromeDriver):
3082         (OSXChromeCanaryDriver):
3083         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3084         (OSXFirefoxDriver):
3085         (OSXFirefoxNightlyDriver):
3086         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3087         (OSXSafariDriver):
3088         (OSXSafariDriver.prepare_env):
3089
3090 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3091
3092         [GTK] Several InputMethodFilter tests are failing
3093         https://bugs.webkit.org/show_bug.cgi?id=195408
3094
3095         Reviewed by Carlos Garcia Campos.
3096
3097         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3098         Regressed in r241751.
3099         Hexadecimal values of keycodes are expressed now in upper letters.
3100         Composited characters should be cast to UTF8 strings.
3101
3102         (TestWebKitAPI::TEST):
3103
3104 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3105
3106         [GTK] Make Tools/gtkdoc python3 compatible
3107         https://bugs.webkit.org/show_bug.cgi?id=195359
3108
3109         Reviewed by Carlos Garcia Campos.
3110
3111         * gtkdoc/generate-gtkdoc:
3112         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3113         work with Python 2 and 3.
3114         (get_gtkdoc_module_paths):
3115         The iteritems() was removed in Python 3, so let's use items() that's
3116         available in Python 2 and 3.
3117         (get_generator_for_config):
3118         * gtkdoc/gtkdoc.py:
3119         (GTKDoc._run_command):
3120         The sys.stdout.write() is expecting str in Python 3 and not bytes
3121         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3122         for passing the bytes there.
3123
3124 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3125
3126         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3127         https://bugs.webkit.org/show_bug.cgi?id=195346
3128         <rdar://problem/48667048>
3129
3130         Unreviewed build fix for clang-cl.
3131
3132         * DumpRenderTree/win/DumpRenderTree.cpp:
3133         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3134
3135 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3136
3137         requestAnimationFrame should execute before the next frame
3138         https://bugs.webkit.org/show_bug.cgi?id=177484
3139
3140         Reviewed by Simon Fraser.
3141
3142         Add trace points for the page RenderingUpdate.
3143
3144         * Tracing/SystemTracePoints.plist:
3145
3146 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3147
3148         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3149         https://bugs.webkit.org/show_bug.cgi?id=195353
3150         <rdar://problem/48626394>
3151
3152         Reviewed by Simon Fraser.
3153
3154         * WebKitTestRunner/ios/TestControllerIOS.mm:
3155         (WTR::TestController::platformResetPreferencesToConsistentValues):
3156
3157 2019-03-07  John Wilander  <wilander@apple.com>
3158
3159         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3160         https://bugs.webkit.org/show_bug.cgi?id=195383
3161         <rdar://problem/48570136>
3162
3163         Reviewed by Brent Fulgham.
3164
3165         This patch adds test infrastructure to purge only script-accessible cookies,
3166         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3167
3168         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3170         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3171         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::TestController::statisticsDeleteCookiesForHost):
3174         * WebKitTestRunner/TestController.h:
3175         * WebKitTestRunner/TestInvocation.cpp:
3176         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3177
3178 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3179
3180         Unreviewed, rolling out r242354.
3181         https://bugs.webkit.org/show_bug.cgi?id=195402
3182
3183         breaks layout tests in all configurations (Requested by
3184         zdobersek on #webkit).
3185
3186         Reverted changeset:
3187
3188         "[WPE] Enable web process sandbox"
3189         https://bugs.webkit.org/show_bug.cgi?id=195169
3190         https://trac.webkit.org/changeset/242354
3191
3192 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3193
3194         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3195         https://bugs.webkit.org/show_bug.cgi?id=195346
3196
3197         Reviewed by Fujii Hironori.
3198
3199         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3200         (TestWebKitAPI::TEST):
3201         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3202
3203         * DumpRenderTree/win/DumpRenderTree.cpp:
3204         (findFontFallback):
3205         (addFontFallbackIfPresent):
3206         (removeFontFallbackIfPresent):
3207         (main):
3208         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3209         (TestWebKitAPI::Util::moduleDirectory):
3210         (TestWebKitAPI::Util::createInjectedBundlePath):
3211         Use wchar helpers as needed.
3212
3213 2019-03-06  Rob Buis  <rbuis@igalia.com>
3214
3215         Consider supporting the `referrerpolicy` attribute.
3216         https://bugs.webkit.org/show_bug.cgi?id=179053
3217
3218         Reviewed by Darin Adler.
3219
3220         Add a runtime flag for referrerpolicy attribute.
3221
3222         * DumpRenderTree/mac/DumpRenderTree.mm:
3223         (enableExperimentalFeatures):
3224
3225 2019-03-05  Daniel Bates  <dabates@apple.com>
3226
3227         Update expected API test result following r242379
3228         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3229
3230         Update expected x-coordinate of selection rect now that the left padding of
3231         a textarea is sized in ems (so dependent on the font size) just like the left
3232         padding of a text field.
3233
3234         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3235         (TestWebKitAPI::TEST):
3236
3237 2019-03-05  David Quesada  <david_quesada@apple.com>
3238
3239         [WK2] It should be possible to follow links with 'download' attributes
3240         https://bugs.webkit.org/show_bug.cgi?id=195145
3241         rdar://problem/48462642
3242
3243         Reviewed by Alex Christensen.
3244
3245         Add a unit test to verify that activating links with 'download' attributes now
3246         navigates to the linked resource, rather than starts downloading it. Add another
3247         to verify that it is still possible to explicitly download the link via the
3248         'Download' navigation action policy.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3251         (-[DownloadAttributeTestDelegate init]):
3252         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3253         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3254         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3255         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3256         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3257         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3258         (TEST):
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::TestController::decidePolicyForNavigationAction):
3261         * WebKitTestRunner/TestController.h:
3262
3263 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3264
3265         [Curl] Implement Cookie Accept Policy.
3266         https://bugs.webkit.org/show_bug.cgi?id=191645
3267
3268         Reviewed by Fujii Hironori.
3269
3270         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3271         (TestWebKitAPI::Curl::TEST_F):
3272
3273 2019-03-05  Youenn Fablet  <youenn@apple.com>
3274
3275         Rename requestCacheStorageSpace to requestStorageSpace
3276         https://bugs.webkit.org/show_bug.cgi?id=195282
3277
3278         Reviewed by Chris Dumez.
3279
3280         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3281         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3282         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3283
3284 2019-03-05  Brady Eidson  <beidson@apple.com>
3285
3286         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3287         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3288
3289         Reviewed by Tim Horton.
3290
3291         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3292         different directory into that same WKWebView should work.
3293
3294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3295         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3296
3297 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3298
3299         Add WeakHashSet
3300         https://bugs.webkit.org/show_bug.cgi?id=195152
3301
3302         Reviewed by Antti Koivisto.
3303
3304         Added tests for WeakHashSet.
3305
3306         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3307         (TestWebKitAPI::Base::Base): Moved.
3308         (TestWebKitAPI::Derived::foo): Moved.
3309         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3310         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3311         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3312         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3313
3314 2019-03-04  Chris Dumez  <cdumez@apple.com>
3315
3316         Do not share WebProcesses between private and regular sessions
3317         https://bugs.webkit.org/show_bug.cgi?id=195189
3318         <rdar://problem/48421064>
3319
3320         Reviewed by Alex Christensen.
3321
3322         Add API test coverage.
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3325         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3326
3327 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3328
3329         [WPE] Enable web process sandbox
3330         https://bugs.webkit.org/show_bug.cgi?id=195169
3331
3332         Reviewed by Daniel Bates.
3333
3334         * wpe/install-dependencies:
3335         * wpe/jhbuild.modules:
3336
3337 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3338
3339         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3340         https://bugs.webkit.org/show_bug.cgi?id=195206
3341
3342         Reviewed by Žan Doberšek.
3343
3344         Add a new test case.
3345
3346         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3347         (testJSCClass):
3348
3349 2019-03-04  Charlie Turner  <cturner@igalia.com>
3350
3351         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3352         https://bugs.webkit.org/show_bug.cgi?id=194898
3353
3354         Reviewed by Žan Doberšek.
3355
3356         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3357         a GCC extension that permits arithmetic on void* pointer. Inline
3358         the macro until this issue is fixed upstream.
3359
3360 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3361
3362         Rid the world of WK_API_ENABLED
3363         https://bugs.webkit.org/show_bug.cgi?id=195263
3364
3365         Reviewed by Dan Bernstein.
3366
3367         List of changed files elided because it's useless.
3368
3369 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3370
3371         Unreviewed follow-up to r242292.
3372
3373         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3374
3375         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3376         (TestWebKitAPI::testStrip): Renamed from strip.
3377         (TestWebKitAPI::TEST):
3378
3379 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3380
3381         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3382
3383         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3384         and bug #194272 for details.
3385
3386         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3387
3388 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3389
3390         Remove some more unused 32-bit code
3391         https://bugs.webkit.org/show_bug.cgi?id=195255
3392
3393         Reviewed by Darin Adler.
3394
3395         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3396         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3397         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3398         (NPP_New):
3399         (NPP_HandleEvent):
3400         (handleEventCarbon): Deleted.
3401
3402 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3403
3404         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3405
3406         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3407         (TestWebKitAPI::TEST):
3408
3409 2019-03-01  Darin Adler  <darin@apple.com>
3410
3411         Finish removing String::format
3412         https://bugs.webkit.org/show_bug.cgi?id=194893
3413
3414         Reviewed by Daniel Bates.
3415 '
3416         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3417
3418 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3419
3420         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3421         https://bugs.webkit.org/show_bug.cgi?id=195229
3422         <rdar://problem/48520362>
3423
3424         Reviewed by Chris Dumez.
3425
3426         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3427         (TEST):
3428
3429 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3430
3431         Add a system trace scope for event region building
3432         https://bugs.webkit.org/show_bug.cgi?id=195226
3433
3434         Reviewed by Jon Lee.
3435
3436         This trace scope measures the time spend converting element rects into Region objects,
3437         which can be large on some pages.
3438
3439         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3440
3441         * Tracing/SystemTracePoints.plist:
3442
3443 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3444
3445         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3446         https://bugs.webkit.org/show_bug.cgi?id=194612
3447
3448         Reviewed by Alex Christensen.
3449
3450         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3451         Just test the new string-processing function and don't touch the actual environment.
3452         (Test cases are all as before, but based on operator== instead of strcmp.)
3453
3454 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3455
3456         [ews-app] Update primary keys for handling multiple Buildbot instances
3457         https://bugs.webkit.org/show_bug.cgi?id=195120
3458
3459         Reviewed by Stephanie Lewis.
3460
3461         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3462         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3463         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3464
3465         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3466         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3467         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3468         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3469         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3470         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3471
3472 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3473
3474         [WinCairo] Enable service worker
3475         https://bugs.webkit.org/show_bug.cgi?id=188318
3476
3477         Reviewed by Youenn Fablet.
3478
3479         * DumpRenderTree/DumpRenderTreePrefix.h:
3480         * TestWebKitAPI/PlatformWin.cmake:
3481         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3482         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3483         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3484
3485 2019-03-01  Justin Fan  <justin_fan@apple.com>
3486
3487         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3488         https://bugs.webkit.org/show_bug.cgi?id=195191
3489
3490         Rubber-stamped by Dean Jackson.
3491
3492         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3493
3494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3495
3496 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3497
3498         Unreviewed, fix lldb webkitpy tests
3499         https://bugs.webkit.org/show_bug.cgi?id=194375
3500
3501         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3502
3503         * lldb/lldb_webkit.py:
3504         (WTFStringImplProvider.is_8bit):
3505
3506 2019-02-28  David Quesada  <david_quesada@apple.com>
3507
3508         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3509         https://bugs.webkit.org/show_bug.cgi?id=195121
3510         rdar://problem/48450302
3511
3512         Reviewed by Alex Christensen.
3513
3514         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3515         configurations where the 'download' attribute is absent, blank, or populated
3516         with a filename, and where the anchor element is same-origin or cross-origin
3517         (meaning the 'download' attribute shouldn't be honored).
3518
3519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3520         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3521         (-[NavigationActionTestDelegate init]):
3522         (-[NavigationActionTestDelegate navigationAction]):
3523         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3524         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3525         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3526         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3527         (TEST):
3528
3529 2019-02-28  Antoine Quint  <graouts@apple.com>
3530
3531         Enable the Pointer Events runtime flag by default
3532         https://bugs.webkit.org/show_bug.cgi?id=195156
3533
3534         Reviewed by Dean Jackson.
3535
3536         * DumpRenderTree/mac/DumpRenderTree.mm:
3537         (enableExperimentalFeatures):
3538
3539 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3540
3541         Several PasteImage API tests are flaky
3542         https://bugs.webkit.org/show_bug.cgi?id=195160
3543
3544         Reviewed by Tim Horton.
3545
3546         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3547         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3548         listening for a "load" event after image load is already complete.
3549
3550         To address this, make these tests first register a "load" event handler, then run script to insert an image
3551         element into the document, and finally wait until the load event is observed before checking image size.
3552
3553         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3554
3555 2019-02-28  Chris Dumez  <cdumez@apple.com>
3556
3557         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3558         https://bugs.webkit.org/show_bug.cgi?id=195107
3559
3560         Reviewed by Alex Christensen.
3561
3562         Give some time for the zoom level to get restored.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3565
3566 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3567
3568         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3569         https://bugs.webkit.org/show_bug.cgi?id=194958
3570
3571         Reviewed by Geoffrey Garen.
3572
3573         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3574         (TEST):
3575
3576 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3577
3578         [ews-app] Update method to save build to handle builder_display_name
3579         https://bugs.webkit.org/show_bug.cgi?id=195047
3580
3581         Reviewed by Dewei Zhu.
3582
3583         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3584         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3585
3586 2019-02-28  Justin Fan  <justin_fan@apple.com>
3587
3588         [Web GPU] Enable Web GPU only on 64-bit
3589         https://bugs.webkit.org/show_bug.cgi?id=195139
3590
3591         Because Metal is only supported on 64 bit apps.
3592
3593         Unreviewed build fix.
3594
3595         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3596
3597 2019-02-27  Youenn Fablet  <youenn@apple.com>
3598
3599         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3600         https://bugs.webkit.org/show_bug.cgi?id=194959
3601
3602         Reviewed by Chris Dumez.
3603
3604         Spin loop until getting the condition to remove flakiness.
3605
3606         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3607
3608 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews-build] Buildbot should include builder_display_name in the build events
3611         https://bugs.webkit.org/show_bug.cgi?id=195045
3612
3613         Reviewed by Dewei Zhu.
3614
3615         * BuildSlaveSupport/ews-build/events.py:
3616         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3617         buildername to builder_name to be consistent in naming style.
3618         (Events.buildFinished): Ditto.
3619
3620 2019-02-27  Chris Dumez  <cdumez@apple.com>
3621
3622         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3623         https://bugs.webkit.org/show_bug.cgi?id=194480
3624
3625         Reviewed by Brady Eidson.
3626
3627         Update existing API test to make it more likely to reproduce the issue.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3630
3631 2019-02-27  Brady Eidson  <beidson@apple.com>
3632
3633         Universal links from Google search results pages don't open the app.
3634         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3635
3636         Reviewed by Geoffrey Garen.
3637
3638         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3639         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3640         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3641         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3642
3643 2019-02-27  Chris Dumez  <cdumez@apple.com>
3644
3645         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3646         https://bugs.webkit.org/show_bug.cgi?id=195102
3647
3648         Reviewed by Geoffrey Garen.
3649
3650         If the number of processes is not yet what we expect, wait a bit and check again to give
3651         processes some time to exit.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3654
3655 2019-02-27  Chris Dumez  <cdumez@apple.com>
3656
3657         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3658         https://bugs.webkit.org/show_bug.cgi?id=194545
3659
3660         Reviewed by Brady Eidson.
3661
3662         Make sure the test navigates forward and then back only once. Previously, navigating
3663         back would trigger a navigation again in a timer.
3664
3665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3666
3667 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3668
3669         High Sierra Debug JSC test queue should use faster hardware
3670         https://bugs.webkit.org/show_bug.cgi?id=194603
3671
3672         Rubber-stamped by Alexey Proskuryakov.
3673
3674         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3675
3676         * BuildSlaveSupport/build.webkit.org-config/config.json:
3677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3678         (BubbleQueueServer):
3679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3680         (WebKitBuildbot):
3681         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3682         * QueueStatusServer/config/queues.py:
3683         * Scripts/webkitpy/common/config/ews.json:
3684         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3685         (test_ews_name):
3686
3687 2019-02-27  John Wilander  <wilander@apple.com>
3688
3689         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3690         https://bugs.webkit.org/show_bug.cgi?id=195071
3691         <rdar://problem/48417690>
3692
3693         Reviewed by Alex Christensen and Brent Fulgham.
3694
3695         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3696         (TestWebKitAPI::createURL):
3697             Convenience function.
3698         (TestWebKitAPI::TEST):
3699             WebCore::AdClickAttribution now takes a URL when creating Source and
3700             Destination.
3701         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3702         (TestWebKitAPI::TEST):
3703             WebCore::AdClickAttribution now takes a URL when creating Source and
3704             Destination.
3705
3706 2019-02-27  Antoine Quint  <graouts@apple.com>
3707
3708         Support Pointer Events on macOS
3709         https://bugs.webkit.org/show_bug.cgi?id=195008
3710         <rdar://problem/47454419>
3711
3712         Reviewed by Dean Jackson.
3713
3714         * DumpRenderTree/mac/DumpRenderTree.mm:
3715         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3716         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3717
3718 2019-02-26  Mark Lam  <mark.lam@apple.com>
3719
3720         Remove remaining poisoning code.
3721         https://bugs.webkit.org/show_bug.cgi?id=194138
3722
3723         Reviewed by Saam Barati.
3724
3725         * TestWebKitAPI/CMakeLists.txt:
3726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3727         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3728         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3729         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3730         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3731         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3732         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3733
3734 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3735
3736         Move ephemeral local storage from WebProcess to UIProcess
3737         https://bugs.webkit.org/show_bug.cgi?id=195074
3738         <rdar://problem/47937975>
3739
3740         Reviewed by Geoff Garen.
3741
3742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3743
3744 2019-02-20  Jer Noble  <jer.noble@apple.com>
3745
3746         [Cocoa] Media elements will restart network buffering just before suspending
3747         https://bugs.webkit.org/show_bug.cgi?id=193691
3748
3749         Reviewed by Eric Carlson.
3750
3751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3753         (TEST):
3754
3755 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3756
3757         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3758         https://bugs.webkit.org/show_bug.cgi?id=191652
3759
3760         Reviewed by Alex Christensen.
3761
3762         Fix WinCairo MiniBrowser behavior of authentication dialog.
3763
3764         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3765         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3766
3767 2019-02-26  Youenn Fablet  <youenn@apple.com>
3768
3769         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3770         https://bugs.webkit.org/show_bug.cgi?id=195028
3771         <rdar://problem/48243733>
3772
3773         Reviewed by Eric Carlson.
3774
3775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3776
3777 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3778
3779         [WPE] Add API for webview background color configuration
3780         https://bugs.webkit.org/show_bug.cgi?id=192305
3781
3782         Reviewed by Michael Catanzaro.
3783
3784         * MiniBrowser/wpe/main.cpp:
3785         (main): Add a new option to configure the webview background
3786         color. Example: --bg-color=transparent.
3787         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3788         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3789         (beforeAll): Ditto.
3790
3791 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3792
3793         scalableNativeWebpageParameters() is not preserved on new page navigation.
3794         https://bugs.webkit.org/show_bug.cgi?id=194892
3795         <rdar://problem/47538280>
3796
3797         Reviewed by Wenson Hsieh.
3798         
3799         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3800
3801         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3802         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3803         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3804         (WTR::UIScriptController::allowsViewportShrinkToFit):
3805         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3806         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3807         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3808         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3809         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3810         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3811
3812 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3813
3814         [ews-app] Add model for handling multiple Buildbot instances
3815         https://bugs.webkit.org/show_bug.cgi?id=194863
3816
3817         Reviewed by Stephanie Lewis.
3818
3819         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3820
3821 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3822
3823         [ews-app] Remove BuilderMapping table
3824         https://bugs.webkit.org/show_bug.cgi?id=194961
3825
3826         Reviewed by Stephanie Lewis.
3827
3828         Store builder name directly in build table, instead of having a separate
3829         table for it.
3830
3831         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3832         * BuildSlaveSupport/ews-app/ews/models/build.py:
3833         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3834         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3835
3836 2019-02-25  John Wilander  <wilander@apple.com>
3837
3838         Introduce and adopt new class RegistrableDomain for eTLD+1
3839         https://bugs.webkit.org/show_bug.cgi?id=194791
3840         <rdar://problem/48179240>
3841
3842         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3843
3844         This patch adds an API test and replaces two instances of
3845         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3846
3847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3848         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3849         (TestWebKitAPI::TEST):
3850             Changed two strings to make sure the registrable domains are still considered
3851             invalid and pass the test.
3852         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3853         (TestWebKitAPI::TEST):
3854         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3855         (WTR::InjectedBundle::didReceiveMessageToPage):
3856
3857 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3858
3859         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3860         https://bugs.webkit.org/show_bug.cgi?id=195001
3861
3862         Reviewed by Carlos Garcia Campos.
3863
3864         API version 1.0 always includes the functionality previously guarded with
3865         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3866         unconditionally.
3867
3868         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3869         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3870         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3871         (WebViewTest::showInWindow): Ditto.
3872         (WebViewTest::hideView): Ditto.
3873         * wpe/backends/HeadlessViewBackend.cpp:
3874         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3875         * wpe/backends/ViewBackend.cpp:
3876         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3877         * wpe/backends/WindowViewBackend.cpp:
3878         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3879         WPE_BACKEND_CHECK_VERSION().
3880         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3881
3882 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3883
3884         [Flatpak] Add support for flatpak > 1.1.2
3885         https://bugs.webkit.org/show_bug.cgi?id=194088
3886
3887         Flatpak 1.2 is now out so we need to support that
3888         version now.
3889
3890         Reviewed by Michael Catanzaro.
3891
3892         * flatpak/flatpakutils.py:
3893         (check_flatpak):
3894         (FlatpakPackages.__init__):
3895         (FlatpakPackages.__detect_packages):
3896         (FlatpakPackages.__detect_packages.in):
3897         (FlatpakRepos.update):
3898
3899 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3900
3901         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3902         https://bugs.webkit.org/show_bug.cgi?id=194998
3903
3904         Reviewed by Carlos Garcia Campos.
3905
3906         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3907         to a Git checkout and using the latest commit containing various fixes
3908         and improvements.
3909
3910 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3911
3912         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3913         https://bugs.webkit.org/show_bug.cgi?id=194981
3914
3915         Reviewed by Žan Doberšek.
3916
3917         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3918         (TestWebKitAPI::TEST):
3919
3920 2019-02-23  Keith Miller  <keith_miller@apple.com>
3921
3922         Add new mac target numbers
3923         https://bugs.webkit.org/show_bug.cgi?id=194955
3924
3925         Reviewed by Tim Horton.
3926
3927         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3928         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3929         * MiniBrowser/Configurations/Base.xcconfig:
3930         * TestWebKitAPI/Configurations/Base.xcconfig:
3931         * WebKitTestRunner/Configurations/Base.xcconfig:
3932
3933 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3934
3935         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3936         https://bugs.webkit.org/show_bug.cgi?id=194846
3937
3938         Reviewed by Don Olmstead.
3939
3940         Added _search_paths() and _port_specific_expectations_files() for
3941         WinCairoPort.
3942
3943         * Scripts/webkitpy/port/win.py:
3944         (WinCairoPort.default_baseline_search_path):
3945         (WinCairoPort):
3946         (WinCairoPort._port_specific_expectations_files):
3947         (WinCairoPort._search_paths):
3948
3949 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3950
3951         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3952         https://bugs.webkit.org/show_bug.cgi?id=194963
3953
3954         Reviewed by Dean Jackson.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3957         Do a `contains` check instead of `equals`, because in debug builds we
3958         put the GraphicsLayer pointer in a prefix.
3959
3960 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3961
3962         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3963         https://bugs.webkit.org/show_bug.cgi?id=194873
3964         <rdar://problem/46701974>
3965
3966         Reviewed by Tim Horton.
3967
3968         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3969
3970         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3971         (WTR::UIScriptController::menuRect const):
3972         (WTR::UIScriptController::isShowingMenu const):
3973         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3974         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3975         (WTR::UIScriptController::menuRect const):
3976
3977         Add a function to query the bounds of the callout menu in content coordinates.
3978
3979         (WTR::UIScriptController::isShowingMenu const):
3980
3981         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3982
3983         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3984         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3985         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3986         (WTR::UIScriptController::rectForMenuAction const):
3987         (WTR::UIScriptController::menuRect const):
3988         (WTR::UIScriptController::isShowingMenu const):
3989         (WTR::findViewInHierarchyOfType): Deleted.
3990
3991 2019-02-22  Chris Dumez  <cdumez@apple.com>
3992
3993         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3994         https://bugs.webkit.org/show_bug.cgi?id=194954
3995         <rdar://problem/48127957>
3996
3997         Reviewed by Alex Christensen.
3998
3999         Add API test coverage.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4002         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4003         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4004         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4005
4006 2019-02-22  Chris Dumez  <cdumez@apple.com>
4007
4008         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4009         https://bugs.webkit.org/show_bug.cgi?id=194924
4010         <rdar://problem/48216125>
4011
4012         Reviewed by Geoffrey Garen.
4013
4014         Add API test coverage.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4017
4018 2019-02-22  Chris Dumez  <cdumez@apple.com>
4019
4020         Unreviewed, disable API test added in r241928 on iOS.
4021
4022         The cache is not enabled on devices with less than 3GB of RAM.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4025
4026 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4027
4028         Hardcode Visual Viewports on everywhere except iOS WK1
4029         https://bugs.webkit.org/show_bug.cgi?id=194928
4030
4031         Reviewed by Zalan Bujtas.
4032
4033         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4034         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4035         set it to false. The setting has shipped for several years and there's no need to turn
4036         it off now.
4037
4038         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4039         Visual Viewports are not enabled.
4040         
4041         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4042         that only runs in WK2
4043
4044         * MiniBrowser/mac/SettingsController.h:
4045         * MiniBrowser/mac/SettingsController.m:
4046         (-[SettingsController init]):
4047         (-[SettingsController _populateMenu]):
4048         (-[SettingsController validateMenuItem:]):
4049         (-[SettingsController visualViewportEnabled]): Deleted.
4050         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4051         * MiniBrowser/mac/WK1BrowserWindowController.m:
4052         (-[WK1BrowserWindowController didChangeSettings]):
4053         * MiniBrowser/mac/WK2BrowserWindowController.m:
4054         (-[WK2BrowserWindowController didChangeSettings]):
4055
4056 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4057
4058         Discard cached processes when clearing website data store
4059         https://bugs.webkit.org/show_bug.cgi?id=194894
4060
4061         Reviewed by Chris Dumez.
4062
4063         Added a test case.
4064
4065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4066         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4067
4068 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4069
4070         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4071         https://bugs.webkit.org/show_bug.cgi?id=194914
4072         <rdar://problem/47586889>
4073
4074         Reviewed by Geoffrey Garen.
4075
4076         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4077         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4078         (TEST):
4079         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4080
4081 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4082
4083         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4084         <https://webkit.org/b/194761>
4085
4086         Reviewed by Myles Maxfield.
4087
4088         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4089         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4090         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4091         to use ARC-compliant cast.
4092         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4093         ARC-compliant cast.
4094         (WTR::installFakeHelvetica): Log `error` to console if
4095         CTFontManagerRegisterFontsForURL() fails, but only on supported
4096         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4097         Call CFRelease() on `error` to fix the leak.  Update to use
4098         ARC-compliant cast.
4099         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4100         cast.
4101
4102 2019-02-21  Chris Dumez  <cdumez@apple.com>
4103
4104         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4105         https://bugs.webkit.org/show_bug.cgi?id=194481
4106
4107         Reviewed by Alex Christensen.
4108
4109         Give the processes a chance to shutdown and wait until we reached the expected number
4110         of processes.
4111
4112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4113
4114 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4115
4116         Fix the macOS build
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4119
4120 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4121
4122         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4123
4124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4125         I am a backwards.
4126
4127 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4128
4129         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4132         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4133         We could force on UI-side compositing, but I feel like the test might be more
4134         valuable exercising the normal path on each platform (though the original
4135         bug was also UI-side specific). Though we can't validate that the overlay
4136         layer was installed successfully, there are layout tests that do that.
4137
4138 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4139
4140         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4141         https://bugs.webkit.org/show_bug.cgi?id=194845
4142         <rdar://problem/47944579>
4143
4144         Reviewed by Antti Koivisto.
4145
4146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4148
4149 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4150
4151         [LFC][Floats] Add support for placing formatting roots in-between floats.
4152         https://bugs.webkit.org/show_bug.cgi?id=194902
4153
4154         Reviewed by Antti Koivisto.
4155
4156         * LayoutReloaded/misc/LFC-passing-tests.txt:
4157
4158 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4159
4160         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4161         https://bugs.webkit.org/show_bug.cgi?id=194901
4162
4163         Unreviewed build fix.
4164
4165         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4166         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4167         WPEBackend-fdo-0.1 as library name.
4168
4169 2019-02-21  Rob Buis  <rbuis@igalia.com>
4170
4171         Update MIME type parser
4172         https://bugs.webkit.org/show_bug.cgi?id=180526
4173
4174         Reviewed by Darin Adler.
4175
4176         Add tests involving leading and trailing whitespace, non-token
4177         characters and quoted strings.
4178
4179         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4180         (TestWebKitAPI::TEST):
4181
4182 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4183
4184         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4185         https://bugs.webkit.org/show_bug.cgi?id=194884
4186
4187         Reviewed by Michael Catanzaro.
4188
4189         * PlatformWin.cmake:
4190
4191 2019-02-20  Chris Dumez  <cdumez@apple.com>
4192
4193         Add API test for <rdar://problem/47471222>
4194         https://bugs.webkit.org/show_bug.cgi?id=194847
4195
4196         Reviewed by Alex Christensen.
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4199
4200 2019-02-20  Chris Dumez  <cdumez@apple.com>
4201
4202         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4203         https://bugs.webkit.org/show_bug.cgi?id=194872
4204         <rdar://problem/47924500>
4205
4206         Reviewed by Alex Christensen.
4207
4208         Add API test coverage.
4209
4210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4211
4212 2019-02-20  Jer Noble  <jer.noble@apple.com>
4213
4214         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4215         https://bugs.webkit.org/show_bug.cgi?id=191332
4216
4217         Reviewed by Dean Jackson.
4218
4219         * Scripts/git-is-in-range: Added.
4220
4221 2019-02-20  Andy Estes  <aestes@apple.com>
4222
4223         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4224         https://bugs.webkit.org/show_bug.cgi?id=194869
4225
4226         Rubber-stamped by Jer Noble.
4227
4228         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4229         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4230         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4231         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4233         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4234
4235 2019-02-20  Chris Dumez  <cdumez@apple.com>
4236
4237         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4238         https://bugs.webkit.org/show_bug.cgi?id=194857
4239         <rdar://problem/47759323>
4240
4241         Reviewed by Alex Christensen.
4242
4243         Add API test coverage.
4244
4245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4246
4247 2019-02-20  Chris Dumez  <cdumez@apple.com>
4248
4249         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4250         https://bugs.webkit.org/show_bug.cgi?id=194829
4251         <rdar://problem/47889906>
4252
4253         Reviewed by Alexey Proskuryakov.
4254
4255         Every time the TestOptions were changing we were creating both a new Web view and
4256         a new WKContext, which would start a new Network process. In most cases, we only
4257         need to contruct a new Web view and we do can keep reusing the same WKContext.
4258         This patch implements this optimization and thus avoids spinning a lot of new
4259         Network processes while running the layout tests.
4260
4261         * WebKitTestRunner/TestController.cpp:
4262         (WTR::TestController::generateContextConfiguration const):
4263         (WTR::TestController::generatePageConfiguration):
4264         (WTR::TestController::createWebViewWithOptions):
4265         (WTR::TestController::resetPreferencesToConsistentValues):
4266         (WTR::updateTestOptionsFromTestHeader):
4267         * WebKitTestRunner/TestController.h:
4268         * WebKitTestRunner/TestOptions.h:
4269         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4270         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4271         (WTR::TestOptions::hasSameInitializationOptions const):
4272         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4273         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4274         (WTR::TestController::platformAddTestOptions const):
4275
4276 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4277
4278         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4279         https://bugs.webkit.org/show_bug.cgi?id=167941
4280
4281         Reviewed by Carlos Garcia Campos.
4282
4283         * MiniBrowser/gtk/main.c:
4284         (filterSavedCallback): Added.
4285         (main): Support loading a JSON rule set file for content filtering.
4286         * MiniBrowser/wpe/main.cpp:
4287         (filterSavedCallback): Added.
4288         (main): Support loading a JSON rule set file for content filtering.
4289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4290         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4291         (WTF::derefGPtr): Ditto.
4292         (testEmptyStore):
4293         (testSaveInvalidFilter):
4294         (testSaveLoadFilter):
4295         (testSavedFilterIdentifierMatch):
4296         (testRemoveFilter):
4297         (testSaveMultipleFilters):
4298         (testSaveFilterFromFile):
4299         (testFilterPersistence):
4300         (beforeAll):
4301         (afterAll):
4302         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4303         (removeOldInjectedContentAndResetLists): Also reset content filters.
4304         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4305         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4306         the element affected by the style sheet.
4307         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4308         and returns it to be used by tests.
4309         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4310         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4311         (serverCallback): Add support for serving a CSS style sheet for testing.
4312         (beforeAll): Add call to testUserContentManagerContentFilter().
4313         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4314
4315 2019-02-19  Keith Rollin  <krollin@apple.com>
4316
4317         Add timing information to build output
4318         https://bugs.webkit.org/show_bug.cgi?id=194839
4319         <rdar://problem/48219609>
4320
4321         Reviewed by Alexey Proskuryakov.
4322
4323         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4324         emit each project's build time to its output. E.g.,
4325
4326             ** BUILD SUCCEEDED ** [0.132 sec]
4327
4328         * Scripts/webkitdirs.pm:
4329         (XcodeOptions):
4330
4331 2019-02-19  Truitt Savell  <tsavell@apple.com>
4332
4333         Unreviewed, rolling out r241784.
4334
4335         Broke all OpenSource builds.
4336
4337         Reverted changeset:
4338
4339         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4340         instances view"
4341         https://bugs.webkit.org/show_bug.cgi?id=172848
4342         https://trac.webkit.org/changeset/241784
4343
4344 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4345
4346         [LFC][Floats] Remove redundant intersecting logic
4347         https://bugs.webkit.org/show_bug.cgi?id=194804
4348
4349         Reviewed by Antti Koivisto.
4350
4351         * LayoutReloaded/misc/LFC-passing-tests.txt:
4352
4353 2019-02-19  Dean Jackson  <dino@apple.com>
4354
4355         Clean-up output from generate-xcfilelists so it can be filtered
4356         https://bugs.webkit.org/show_bug.cgi?id=194795
4357
4358         Reviewed by Joseph Pecoraro (and Keith Rollin).
4359
4360         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4361         make a slight tweak to filter-build-webkit so such lines are marked
4362         as plain.
4363
4364         * Scripts/filter-build-webkit:
4365         * Scripts/generate-xcfilelists: