Remove unused coordinated graphics C API
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Remove unused coordinated graphics C API
4         https://bugs.webkit.org/show_bug.cgi?id=173706
5
6         Reviewed by Žan Doberšek.
7
8         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
9         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
10         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
11         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
12         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
13         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
14
15 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [WPE] Build glib API tests
18         https://bugs.webkit.org/show_bug.cgi?id=173702
19
20         Reviewed by Žan Doberšek.
21
22         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
23         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
24         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
25         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
26         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
27         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
28         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
29         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
30         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
31         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
32         and implement the missing features.
33
34         * CMakeLists.txt:
35         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
36         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
37         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
38         (testAutomationSessionRequestSession):
39         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
40         (testWebKitWebViewSessionState):
41         (testWebKitWebViewSessionStateWithFormData):
42         (testWebKitWebViewNavigationAfterSessionRestore):
43         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
44         (beforeAll):
45         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
46         (testCookieManagerEphemeral):
47         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
48         (testBlobDownload):
49         (beforeAll):
50         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
51         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
52         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
53         (testProcessPerWebView):
54         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
55         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
56         (testWebViewCreateNavigationData):
57         (testWebViewJavaScriptDialogs):
58         (testWebViewWindowProperties):
59         (testWebViewMouseTarget):
60         (testWebViewGeolocationPermissionRequests):
61         (testWebViewUserMediaPermissionRequests):
62         (testWebViewAudioOnlyUserMediaPermissionRequests):
63         (testWebViewFileChooserRequest):
64         (beforeAll):
65         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
66         (beforeAll):
67         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
68         (testPrivateBrowsing):
69         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
70         (testFindControllerHide):
71         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
72         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
73         (testWebKitSettings):
74         (beforeAll):
75         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
76         (testWebViewNewWithUserContentManager):
77         (beforeAll):
78         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
79         (testWebContextEphemeral):
80         (testWebContextProxySettings):
81         (beforeAll):
82         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
83         (testWebViewWebContext):
84         (testWebViewWebContextLifetime):
85         (testWebViewEphemeral):
86         (testWebViewSettings):
87         (testWebViewCanShowMIMEType):
88         (testWebViewPageVisibility):
89         (testWebViewIsPlayingAudio):
90         (beforeAll):
91         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
92         (testWebsiteDataEphemeral):
93         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
94         (documentLoadedCallback):
95         (pageCreatedCallback):
96         (methodCallCallback):
97         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
98         * TestWebKitAPI/glib/CMakeLists.txt:
99         * TestWebKitAPI/glib/PlatformGTK.cmake:
100         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
101         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
102         (main):
103         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
104         (Test::adoptView):
105         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
106         (WebKitTestBus::run):
107         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
108         (WebViewTest::~WebViewTest):
109         (WebViewTest::initializeWebView):
110         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
111         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
112         (WebViewTest::platformDestroy):
113         (WebViewTest::platformInitializeWebView):
114         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
115         (WebViewTest::resizeView):
116         (WebViewTest::hideView):
117         (parentWindowMapped):
118         (WebViewTest::showInWindow):
119         (WebViewTest::showInWindowAndWaitUntilMapped):
120         (WebViewTest::mouseMoveTo):
121         (WebViewTest::clickMouseButton):
122         (WebViewTest::emitPopupMenuSignal):
123         (WebViewTest::keyStroke):
124         (WebViewTest::doMouseButtonEvent):
125         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
126         (WebViewTest::platformDestroy):
127         (WebViewTest::platformInitializeWebView):
128         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
129         (WebViewTest::resizeView):
130         (WebViewTest::hideView):
131         (WebViewTest::mouseMoveTo):
132         (WebViewTest::clickMouseButton):
133         (WebViewTest::keyStroke):
134
135 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
136
137         [GTK] Move WebKit2 GLib API tests to glib directories
138         https://bugs.webkit.org/show_bug.cgi?id=173642
139
140         Reviewed by Žan Doberšek.
141
142         * CMakeLists.txt:
143         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
144         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
145         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
146         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
147         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
148         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
149         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
150         (testWebKitConsoleMessageNetworkError):
151         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
152         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
153         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
154         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
155         (testLoadFromGResource):
156         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
157         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
158         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
159         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
160         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
161         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
162         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
163         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
164         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
165         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
166         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
167         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
168         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
169         (testWebViewRunJavaScript):
170         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
171         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
172         (registerGResource):
173         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
174         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
175         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
176         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
177         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
178         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
179         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
180         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
181         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
182         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
183         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
184         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
185         * TestWebKitAPI/glib/CMakeLists.txt: Added.
186         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
187         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
188         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
189         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
190         (registerGResource):
191         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
192         (Test::getResourcesDir):
193         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
194         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
195         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
196         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
197         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
198         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
199
200 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
201
202         [WPE] Add initial web extensions API
203         https://bugs.webkit.org/show_bug.cgi?id=173640
204
205         Reviewed by Žan Doberšek.
206
207         Add style checker exceptions for WPE web extensions API files.
208
209         * Scripts/webkitpy/style/checker.py:
210
211 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
212
213         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
214         https://bugs.webkit.org/show_bug.cgi?id=173659
215         <rdar://problem/32879788>
216
217         Reviewed by Tim Horton.
218
219         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
220
221         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
222
223         Augment this test page to log dragend and dragstart events on the drag source as well.
224
225         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
226         (checkStringArraysAreEqual):
227         (TestWebKitAPI::TEST):
228
229 2017-06-21  Antoine Quint  <graouts@apple.com>
230
231         Ensure DRT always logs rAF suspension debugging code
232         https://bugs.webkit.org/show_bug.cgi?id=173681
233
234         Reviewed by Tim "Mr. T" Horton.
235
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (resetWebPreferencesToConsistentValues):
238
239 2017-06-21  Chris Dumez  <cdumez@apple.com>
240
241         Allow constructing a WTF:Function from a function pointer
242         https://bugs.webkit.org/show_bug.cgi?id=173660
243
244         Reviewed by Alex Christensen.
245
246         Add API test coverage.
247
248         * TestWebKitAPI/Tests/WTF/Function.cpp:
249         (TestWebKitAPI::returnThree):
250         (TestWebKitAPI::returnFour):
251         (TestWebKitAPI::returnPassedValue):
252         (TestWebKitAPI::TEST):
253
254 2017-06-21  Antoine Quint  <graouts@apple.com>
255
256         Add logging to identify when the Page suspends scripted animations
257         https://bugs.webkit.org/show_bug.cgi?id=173626
258
259         Reviewed by Tim Horton.
260
261         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
262
263         * DumpRenderTree/mac/DumpRenderTree.mm:
264         (resetWebPreferencesToConsistentValues):
265
266 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
267
268         AX: Cannot call setValue() on contenteditable or ARIA text controls
269         https://bugs.webkit.org/show_bug.cgi?id=173520
270
271         Reviewed by Ryosuke Niwa.
272
273         Add setValue() method to WKTR (already existed in DRT).
274
275         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
276         (WTR::AccessibilityUIElement::setValue):
277         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
278         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
279         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
280         (WTR::AccessibilityUIElement::setValue):
281
282 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
283
284         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
285         as one of the dependencies required to build the product.
286
287         Rubber-stamped by Carlos Garcia Campos.
288
289         * gtk/install-dependencies:
290         * wpe/install-dependencies:
291
292 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
293
294         Disable font variations on macOS Sierra and iOS 10
295         https://bugs.webkit.org/show_bug.cgi?id=173618
296         <rdar://problem/32879164>
297
298         Reviewed by Jon Lee.
299
300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
301
302 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
305         https://bugs.webkit.org/show_bug.cgi?id=173578
306         <rdar://problem/32825028>
307
308         Reviewed by Tim Horton.
309
310         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
311         a custom popover does not cause dragging to fail when the popover is presented.
312
313         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
314         (-[DataInteractionSimulator _advanceProgress]):
315
316 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
317
318         [WPE] Add initial implementation of glib API
319         https://bugs.webkit.org/show_bug.cgi?id=173546
320
321         Reviewed by Žan Doberšek.
322
323         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
324         include WPE glib API files.
325
326         * Scripts/webkitperl/FeatureList.pm:
327         * Scripts/webkitpy/style/checker.py:
328         * Scripts/webkitpy/style/checkers/cpp.py:
329         (check_identifier_name_in_declaration):
330
331 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
332
333         [GTK] Upgrade to ICU to version 57.1
334         https://bugs.webkit.org/show_bug.cgi?id=173538
335
336         Reviewed by Žan Doberšek.
337
338         * gtk/jhbuild.modules:
339
340 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
341
342         [GTK] Remove unneeded modules from the jhbuild
343         https://bugs.webkit.org/show_bug.cgi?id=170540
344
345         Reviewed by Michael Catanzaro.
346
347         We are building libxslt and libffi that we don't really need to build from sources.
348
349         * gtk/jhbuild.modules:
350
351 2017-06-19  Frederic Wang  <fwang@igalia.com>
352
353         [Mac] Add an experimental feature setting for async frame scrolling
354         https://bugs.webkit.org/show_bug.cgi?id=173359
355
356         Reviewed by Simon Fraser.
357
358         * DumpRenderTree/mac/DumpRenderTree.mm:
359         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
360         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
361         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
362         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
363
364 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
365
366         Unreviewed, adding myself to contributors.json
367
368         * Scripts/webkitpy/common/config/contributors.json:
369
370 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
371
372         test262: Completion values for control flow do not match the spec
373         https://bugs.webkit.org/show_bug.cgi?id=171265
374
375         Reviewed by Saam Barati.
376
377         * Scripts/run-jsc-stress-tests:
378         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
379
380 2017-06-19  Zalan Bujtas  <zalan@apple.com>
381
382         Opening certain mails brings up a mail that grows indefinitely.
383         https://bugs.webkit.org/show_bug.cgi?id=173562
384         <rdar://problem/32766579>
385
386         Reviewed by Tim Horton.
387
388         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
389         (TEST):
390
391 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
392
393         [iOS DnD] Support .zip archives for file uploads via drag and drop
394         https://bugs.webkit.org/show_bug.cgi?id=173511
395         <rdar://problem/32521025>
396
397         Reviewed by Tim Horton.
398
399         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
400         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
404         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
405         (testZIPArchive):
406         (TestWebKitAPI::TEST):
407
408 2017-06-18  Darin Adler  <darin@apple.com>
409
410         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
411         https://bugs.webkit.org/show_bug.cgi?id=173526
412
413         Reviewed by Sam Weinig.
414
415         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
417
418         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
419         tests for assignment before destruction ones.
420
421         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
422         as a function, so it can be used in WTF::Function tests.
423
424         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
425         Added tests for swap and for assignment before deref.
426
427         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
428         to inline everything. Also removed the unnecessary clearing of the log every time
429         the DerivedRefLogger constructor is called.
430         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
431
432         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
433         Added tests for assignment before deref and similar for releaseNonNull.
434
435 2017-06-19  Sam Weinig  <sam@webkit.org>
436
437         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
438         https://bugs.webkit.org/show_bug.cgi?id=173513
439
440         Reviewed by Alex Christensen.
441
442         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
443         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
444         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
445
446 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
447
448         [Win] fast/dom/assign-to-window-status.html is flaky.
449         https://bugs.webkit.org/show_bug.cgi?id=173512
450
451         Reviewed by Alex Christensen.
452
453         We should not dump status callbacks when test is done.
454
455         * DumpRenderTree/win/UIDelegate.cpp:
456         (UIDelegate::setStatusText):
457
458 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
459
460         [WPE][JHBuild] Update WPEBackend-mesa
461         https://bugs.webkit.org/show_bug.cgi?id=173433
462
463         Unreviewed.
464
465         Update WPEBackend-mesa back (like it was done originally in r218344)
466         after fixing the issue with the DISPLAY environment variables that
467         caused the crashes.
468
469         * wpe/jhbuild.modules:
470
471 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
472
473         Rename unit test file after r218482
474         https://bugs.webkit.org/show_bug.cgi?id=173483
475
476         Unreviewed.
477
478         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
479
480 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
481
482         Unreviewed. Fix wrong style checker condition added in r218487.
483
484         * Scripts/webkitpy/style/checkers/cpp.py:
485         (check_identifier_name_in_declaration):
486
487 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
488
489         Missing <functional> includes make builds fail with GCC 7.x
490         https://bugs.webkit.org/show_bug.cgi?id=173544
491
492         Unreviewed gardening.
493
494         Fix compilation with GCC 7.
495
496         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
497         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
498
499 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
500
501         [GTK] Move GTK+ API files that could be shared to glib dirs
502         https://bugs.webkit.org/show_bug.cgi?id=173545
503
504         Reviewed by Žan Doberšek.
505
506         Update paths of GTK+ API in watchlist and style checker.
507
508         * Scripts/webkitpy/common/config/watchlist:
509         * Scripts/webkitpy/style/checker.py:
510         * Scripts/webkitpy/style/checkers/cpp.py:
511         (check_identifier_name_in_declaration):
512
513 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
514
515         Port setup_environ_for_server should not set environment variables related with the driver.
516         https://bugs.webkit.org/show_bug.cgi?id=173483
517
518         Reviewed by Carlos Garcia Campos.
519
520         The port setup_environ_for_server() should not set environment variables
521         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
522         This varibles should be only set on the driver setup_environ_for_test().
523
524         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
525         into the test environment even when running the tests with a driver
526         that is not the Xorg or Xvfb one.
527
528         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
529         (Port.to.setup_environ_for_server):
530         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
531         (Driver._setup_environ_for_driver):
532         * Scripts/webkitpy/port/driver_unittest.py:
533         (DriverTest.test_setup_environ_for_test):
534         (DriverTest):
535         (DriverTest.test_setup_environ_base_vars):
536         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
537         (GtkPort.setup_environ_for_server):
538         * Scripts/webkitpy/port/wayland_unittest.py: Added.
539         (WaylandDriverTest):
540         (WaylandDriverTest.make_driver):
541         (WaylandDriverTest.make_environment):
542         (WaylandDriverTest.test_checkdriver):
543         (WaylandDriverTest.test_environment_needed_variables):
544         (WaylandDriverTest.test_environment_forbidden_variables):
545         (WaylandDriverTest.test_environment_optional_variables):
546         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
547         (WaylandDriver.check_driver):
548         (WaylandDriver._setup_environ_for_test):
549         * Scripts/webkitpy/port/xorgdriver.py:
550         (XorgDriver.check_driver):
551         (XorgDriver._setup_environ_for_test):
552         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
553         (XorgDriverTest):
554         (XorgDriverTest.make_driver):
555         (XorgDriverTest.make_environment):
556         (XorgDriverTest.test_checkdriver):
557         (XorgDriverTest.test_environment_needed_variables):
558         (XorgDriverTest.test_environment_forbidden_variables):
559         (XorgDriverTest.test_environment_optional_variables):
560         * Scripts/webkitpy/port/xvfbdriver.py:
561         (XvfbDriver._setup_environ_for_test):
562         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
563         (XvfbDriverTest.assertDriverStartSuccessful):
564
565
566 2017-05-14 Frederic Wang  <fwang@igalia.com>
567
568         Add heuristic to avoid flattening "fullscreen" iframes
569         https://bugs.webkit.org/show_bug.cgi?id=171914
570
571         Reviewed by Simon Fraser.
572
573         * DumpRenderTree/mac/DumpRenderTree.mm:
574         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
575
576 2017-06-18  Chris Dumez  <cdumez@apple.com>
577
578         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
579         https://bugs.webkit.org/show_bug.cgi?id=173522
580         <rdar://problem/31185739>
581
582         Reviewed by Darin Adler.
583
584         Add API test for re-entering Function's assignment operators.
585
586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
587         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
588         (TestWebKitAPI::TestObject::TestObject):
589         (TestWebKitAPI::TestObject::~TestObject):
590         (TestWebKitAPI::TestObject::operator()):
591         (TestWebKitAPI::TEST):
592
593 2017-06-16  Dan Bernstein  <mitz@apple.com>
594
595         [Cocoa] Some declarations have missing or incorrect availability attributes
596         https://bugs.webkit.org/show_bug.cgi?id=173508
597
598         Reviewed by Tim Horton.
599
600         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
601         (TestWebKitAPI::TEST): Updated for renames.
602
603 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
604
605         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
606         https://bugs.webkit.org/show_bug.cgi?id=173366
607         <rdar://problem/32767014>
608
609         Reviewed by Tim Horton.
610
611         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
612         change in behavior.
613
614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
616         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
617         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
618         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
619         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
620         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
621         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
622         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
623         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
624         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
625         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
626         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
627         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
628         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
629         (-[MockDragDropSession initWithItems:location:window:]):
630         (-[MockDragDropSession allowsMoveOperation]):
631         (-[MockDragDropSession isRestrictedToDraggingApplication]):
632         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
633         (-[MockDragDropSession canLoadObjectsOfClass:]):
634         (-[MockDragDropSession canLoadObjectsOfClasses:]):
635         (-[MockDragDropSession items]):
636         (-[MockDragDropSession setItems:]):
637         (-[MockDragDropSession locationInView:]):
638         (-[MockDataOperationSession initWithProviders:location:window:]):
639         (-[MockDataOperationSession session]):
640         (-[MockDataOperationSession isLocal]):
641         (-[MockDataOperationSession progress]):
642         (-[MockDataOperationSession setProgressIndicatorStyle:]):
643         (-[MockDataOperationSession progressIndicatorStyle]):
644         (-[MockDataOperationSession operationMask]):
645         (-[MockDataOperationSession localDragSession]):
646         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
647         (-[MockDataOperationSession canCreateItemsOfClass:]):
648         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
649         (-[MockDataInteractionSession initWithWindow:]):
650         (-[MockDataInteractionSession localOperationMask]):
651         (-[MockDataInteractionSession externalOperationMask]):
652         (-[MockDataInteractionSession session]):
653         (-[DataInteractionSimulator _advanceProgress]):
654
655 2017-06-16  Alex Christensen  <achristensen@webkit.org>
656
657         Show punycode to user if a URL has dotless i or j followed by diacritic dot
658         https://bugs.webkit.org/show_bug.cgi?id=173431
659
660         Reviewed by Darin Adler.
661
662         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
663         (TestWebKitAPI::TEST):
664
665 2017-06-16  Chris Dumez  <cdumez@apple.com>
666
667         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
668         https://bugs.webkit.org/show_bug.cgi?id=173472
669         <rdar://problem/28858817>
670
671         Reviewed by Brady Eidson.
672
673         Add API test coverage.
674
675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
676         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
677         (TEST):
678
679 2017-06-16  Brady Eidson  <beidson@apple.com>
680
681         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
682         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
683
684         Reviewed by Daniel Bates.
685
686         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
687
688 2017-06-16  Chris Dumez  <cdumez@apple.com>
689
690         DRT fails to reset page visibility between tests
691         https://bugs.webkit.org/show_bug.cgi?id=173485
692
693         Reviewed by Alexey Proskuryakov.
694
695         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
696         Fix this to address flakiness.
697
698         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
699         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
700         The test became flaky without the DRT change and was no longer flaky with the DRT
701         change.
702
703         WebKitTestRunner already does this.
704
705         * DumpRenderTree/mac/DumpRenderTree.mm:
706         (resetWebViewToConsistentStateBeforeTesting):
707
708 2017-06-16  Alex Christensen  <achristensen@webkit.org>
709
710         Implement basic authentication in MiniBrowser
711         https://bugs.webkit.org/show_bug.cgi?id=173443
712
713         Reviewed by Tim Horton.
714
715         * MiniBrowser/mac/WK2BrowserWindowController.m:
716         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
717
718 2017-06-16  Jer Noble  <jer.noble@apple.com>
719
720         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
721         https://bugs.webkit.org/show_bug.cgi?id=173398
722         <rdar://problem/32592961>
723
724         Reviewed by Eric Carlson.
725
726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
728         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
729         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
730         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
731         (TestWebKitAPI::TEST):
732         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
733
734 2017-06-16  Matt Lewis  <jlewis3@apple.com>
735
736         Unreviewed, rolling out r218375.
737
738         The API test MediaStreamTrackDetached is still timing out
739         after the patch
740
741         Reverted changeset:
742
743         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
744         reports no recording to WebKit clients"
745         https://bugs.webkit.org/show_bug.cgi?id=173398
746         http://trac.webkit.org/changeset/218375
747
748 2017-06-15  Jer Noble  <jer.noble@apple.com>
749
750         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
751         https://bugs.webkit.org/show_bug.cgi?id=173398
752         <rdar://problem/32592961>
753
754         Reviewed by Eric Carlson.
755
756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
757         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
758         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
759         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
760         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
761         (TestWebKitAPI::TEST):
762         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
763
764 2017-06-15  Matt Lewis  <jlewis3@apple.com>
765
766         Unreviewed, rolling out r218365.
767
768         The revision caused API timeouts on all builds.
769
770         Reverted changeset:
771
772         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
773         reports no recording to WebKit clients"
774         https://bugs.webkit.org/show_bug.cgi?id=173398
775         http://trac.webkit.org/changeset/218365
776
777 2017-06-15  Jer Noble  <jer.noble@apple.com>
778
779         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
780         https://bugs.webkit.org/show_bug.cgi?id=173398
781         <rdar://problem/32592961>
782
783         Reviewed by Eric Carlson.
784
785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
787         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
788         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
789         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
790         (TestWebKitAPI::TEST):
791         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
792
793 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
794
795         REGRESSION(r218344): [WPE] Thousands of layout test crashes
796         https://bugs.webkit.org/show_bug.cgi?id=173433
797
798         Unreviewed.
799
800         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
801
802 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
803
804         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
805         https://bugs.webkit.org/show_bug.cgi?id=173061
806
807         Reviewed by Žan Doberšek.
808
809         Launch dyz <https://github.com/Igalia/dyz> with the script
810         run-minibrowser for the wpe port. It is now built as part of the
811         WPE dependencies with JHBuild.
812
813         * Scripts/run-minibrowser:
814         * Scripts/webkitdirs.pm:
815         (launcherPath):
816         (launcherName):
817         * wpe/install-dependencies: Luajit is needed for building dyz.
818         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
819
820 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
821
822         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
823         https://bugs.webkit.org/show_bug.cgi?id=173338
824         <rdar://problem/32777720>
825
826         Reviewed by Tim Horton.
827
828         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
829         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
830         these remaining items on drop.
831
832         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
833         (TestWebKitAPI::TEST):
834         * TestWebKitAPI/ios/DataInteractionSimulator.h:
835         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
836
837         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
838
839         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
840
841 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
842
843         [Win] Crash in accessibility layout test.
844         https://bugs.webkit.org/show_bug.cgi?id=173401
845
846         Reviewed by Brent Fulgham.
847
848         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
849         member will be automatically released when the _variant_t object goes out of scope if the vt member
850         does not equal VT_UNKNOWN | VT_BYREF.
851         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
852
853         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
854         (AccessibilityUIElement::titleUIElement):
855
856 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
857
858         [GTK] Add API to allow overriding popup menus
859         https://bugs.webkit.org/show_bug.cgi?id=172905
860
861         Reviewed by Michael Catanzaro.
862
863         Add a unit test to check the new API.
864
865         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
866         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
867         (OptionMenuTest::OptionMenuTest):
868         (OptionMenuTest::~OptionMenuTest):
869         (OptionMenuTest::destroyMenu):
870         (OptionMenuTest::showOptionMenuCallback):
871         (OptionMenuTest::menuCloseCallback):
872         (OptionMenuTest::showOptionMenu):
873         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
874         (OptionMenuTest::close):
875         (OptionMenuTest::activateItem):
876         (OptionMenuTest::selectItem):
877         (testOptionMenuSimple):
878         (testOptionMenuGroups):
879         (testOptionMenuActivate):
880         (testOptionMenuSelect):
881         (beforeAll):
882         (afterAll):
883
884 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
885
886         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
887         https://bugs.webkit.org/show_bug.cgi?id=173399
888
889         Reviewed by Per Arne Vollan.
890
891         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
892         Curl port needs to do nothing because libcurl doesn't have disk cache.
893
894         * DumpRenderTree/win/DumpRenderTree.cpp:
895         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
896         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
897
898 2017-06-14  Tomas Popela  <tpopela@redhat.com>
899
900         [GTK] integer expression expected if running Tools/gtk/install-dependencies
901         https://bugs.webkit.org/show_bug.cgi?id=173356
902
903         Reviewed by Michael Catanzaro.
904
905         Use the correct operator to compare the strings.
906
907         * gtk/install-dependencies:
908
909 2017-06-14  Commit Queue  <commit-queue@webkit.org>
910
911         Unreviewed, rolling out r218285.
912         https://bugs.webkit.org/show_bug.cgi?id=173391
913
914         API test fails on iOS (Requested by alexchristensen on
915         #webkit).
916
917         Reverted changeset:
918
919         "Add SPI for immediate injection of user scripts"
920         https://bugs.webkit.org/show_bug.cgi?id=173342
921         http://trac.webkit.org/changeset/218285
922
923 2017-06-14  Chris Dumez  <cdumez@apple.com>
924
925         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
926         https://bugs.webkit.org/show_bug.cgi?id=173384
927         <rdar://problem/32723779>
928
929         Reviewed by Dan Bernstein.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
933         Add API test coverage.
934
935         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
936         (TestWebKitAPI::Util::sleep):
937         Update implementation of Util::sleep() so that we actually run the run loop.
938         Otherwise, we don't process events while sleeping.
939
940 2017-06-14  Alex Christensen  <achristensen@webkit.org>
941
942         Add SPI for immediate injection of user scripts
943         https://bugs.webkit.org/show_bug.cgi?id=173342
944         <rdar://problem/29202285>
945
946         Reviewed by Brady Eidson.
947
948         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
949         (waitForMessage):
950         (TEST):
951
952 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
953
954         Add WPE to the flakiness dashboard
955         https://bugs.webkit.org/show_bug.cgi?id=173365
956
957         Reviewed by Carlos Alberto Lopez Perez.
958
959         * TestResultServer/static-dashboards/builders.jsonp:
960         * TestResultServer/static-dashboards/flakiness_dashboard.js:
961         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
962         (resetGlobals):
963         * TestResultServer/static-dashboards/loader_unittests.js:
964
965 2017-06-14  Brady Eidson  <beidson@apple.com>
966
967         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
968         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
969
970         Reviewed by Alex Christensen.
971
972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
973         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
974         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
975         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
976         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
977         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
978         (TEST):
979
980 2017-06-14  Tim Horton  <timothy_horton@apple.com>
981
982         WKContentViewEditingActions API test always fails
983         https://bugs.webkit.org/show_bug.cgi?id=173374
984
985         Reviewed by Wenson Hsieh.
986
987         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
988         (TEST):
989         selectAll isn't working, because canPerformAction for selectAll returns NO
990         if selectionIsNone (which is true in the non-contenteditable case).
991         Instead, make use of r218180's test page, which knows how to select itself.
992         Also, reset the pasteboard at the beginning of the test to reduce confusion
993         (I landed the test broken because my simulator had the correct text
994         stuck in its pasteboard).
995
996 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
997
998         Configure screen scale for running layout tests on plus devices
999         https://bugs.webkit.org/show_bug.cgi?id=173319
1000
1001         Reviewed by Tim Horton.
1002
1003         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1004         * DumpRenderTree/mac/DumpRenderTree.mm:
1005         (dumpRenderTree): Set screen scale to 2.0.
1006         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1007         add _setScale for UIScreen.
1008         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1009         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1010         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1011         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1012         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1013         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1014         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1015         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1016         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1017         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1018
1019 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1020
1021         Add iOS 11 support to the bot watcher's dashboard
1022         https://bugs.webkit.org/show_bug.cgi?id=173369
1023
1024         Reviewed by Lucas Forschler.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1032
1033 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1034
1035         [GTK][WPE] Raise the timeout values for layout tests
1036         https://bugs.webkit.org/show_bug.cgi?id=173368
1037
1038         Reviewed by Carlos Garcia Campos.
1039
1040         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1041         When running under valgrind a 10x multiplier is applied.
1042
1043         * Scripts/webkitpy/port/gtk.py:
1044         (GtkPort.default_timeout_ms):
1045         * Scripts/webkitpy/port/gtk_unittest.py:
1046         (GtkPortTest.test_default_timeout_ms):
1047         * Scripts/webkitpy/port/wpe.py:
1048         (WPEPort.default_timeout_ms):
1049         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1050         (WPEPortTest):
1051         (WPEPortTest.make_port):
1052         (WPEPortTest.test_default_timeout_ms):
1053         (WPEPortTest.test_get_crash_log):
1054
1055 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1056
1057         Test persistent WKHTTPCookieStorages on iOS.
1058         https://bugs.webkit.org/show_bug.cgi?id=173284
1059
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1061         (TEST):
1062         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1063
1064 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1065
1066         [Win] DRT should not use disk cache.
1067         https://bugs.webkit.org/show_bug.cgi?id=173361
1068
1069         Reviewed by Darin Adler.
1070
1071         Like on macOS/iOS, DRT on Windows should only use memory cache.
1072
1073         * DumpRenderTree/win/DumpRenderTree.cpp:
1074         (setDefaultsToConsistentValuesForTesting):
1075         (prepareConsistentTestingEnvironment):
1076
1077 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1078
1079         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1080         https://bugs.webkit.org/show_bug.cgi?id=171668
1081
1082         Reviewed by Jer Noble.
1083
1084         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1085         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1086         Infinity when the double value passed as argument is greater than 2^64.
1087
1088         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1089         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1090         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1091         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1092         method. No behavior change for rational MediaTime.
1093
1094         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1095         (TestWebKitAPI::TEST):
1096
1097 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1098
1099         Test persistent WKHTTPCookieStorages on iOS
1100         https://bugs.webkit.org/show_bug.cgi?id=173284
1101         <rdar://problem/32260156>
1102
1103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1104         (TEST):
1105
1106 2017-06-13  Matt Rajca  <mrajca@apple.com>
1107
1108         WebsitePolicies: let clients select specific autoplay quirks
1109         https://bugs.webkit.org/show_bug.cgi?id=173343
1110
1111         Reviewed by Alex Christensen.
1112
1113         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1114         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1115         (TEST): Updated tests.
1116
1117 2017-06-13  Daniel Bates  <dabates@apple.com>
1118
1119         Implement W3C Secure Contexts Draft Specification
1120         https://bugs.webkit.org/show_bug.cgi?id=158121
1121         <rdar://problem/26012994>
1122
1123         Reviewed by Brent Fulgham.
1124
1125         Part 4
1126
1127         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1128         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1129         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1130
1131         * DumpRenderTree/TestOptions.h:
1132         * DumpRenderTree/TestOptions.mm:
1133         (TestOptions::TestOptions):
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (setWebPreferencesForTestOptions):
1136         * DumpRenderTree/win/DumpRenderTree.cpp:
1137         (enableExperimentalFeatures):
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::TestController::resetPreferencesToConsistentValues):
1140         (WTR::updateTestOptionsFromTestHeader):
1141         * WebKitTestRunner/TestOptions.h:
1142         (WTR::TestOptions::hasSameInitializationOptions):
1143
1144 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1145
1146         Test persistent WKHTTPCookieStorages on iOS
1147         https://bugs.webkit.org/show_bug.cgi?id=173284
1148         <rdar://problem/32260156>
1149
1150         Reviewed by Alexey Proskuryakov.
1151
1152         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1153         (TEST):
1154
1155 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1156
1157         [GTK] Blob download doesn't work
1158         https://bugs.webkit.org/show_bug.cgi?id=172442
1159
1160         Reviewed by Carlos Alberto Lopez Perez.
1161
1162         Add a unit test to check blob downloads.
1163
1164         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1165         (testBlobDownload):
1166         (beforeAll):
1167
1168 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1169
1170         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
1171         https://bugs.webkit.org/show_bug.cgi?id=173316
1172
1173         Reviewed by Alex Christensen.
1174
1175         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
1176
1177         * gtk/manifest.txt.in:
1178
1179 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1180
1181         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
1182         https://bugs.webkit.org/show_bug.cgi?id=173315
1183
1184         Reviewed by Darin Adler.
1185
1186         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
1187         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
1188         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
1189         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
1190         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
1191         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
1192         WKGeolocationManagerRef is not destroyed.
1193
1194         * WebKitTestRunner/GeolocationProviderMock.cpp:
1195         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1196         * WebKitTestRunner/GeolocationProviderMock.h:
1197
1198 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         Unable to paste text that was copied from a page into the universal search field
1201         https://bugs.webkit.org/show_bug.cgi?id=173293
1202         <rdar://problem/32440918>
1203
1204         Reviewed by Ryosuke Niwa.
1205
1206         Adds 2 new unit tests for copying plain and rich selected web content.
1207         See WebCore and WebKit ChangeLogs for more detail.
1208
1209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1210         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
1211         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
1212         (TestWebKitAPI::dataForPasteboardType):
1213         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1214         (TestWebKitAPI::TEST):
1215
1216 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
1217
1218         AX: [ATK] Implement missing AtkRelation types
1219         https://bugs.webkit.org/show_bug.cgi?id=155494
1220
1221         Reviewed by Darin Adler.
1222
1223         Add additional methods to test ARIA properties which are exposed via
1224         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
1225
1226         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1227         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1228         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1229         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1230         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1231         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1232         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1233         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1234         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1235         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1236         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1237         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1238         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1239         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1240         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1241         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1242         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1243         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1244
1245 2017-06-12  Daniel Bates  <dabates@apple.com>
1246
1247         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
1248         https://bugs.webkit.org/show_bug.cgi?id=173286
1249         <rdar://problem/32726102>
1250
1251         Reviewed by Brent Fulgham.
1252
1253         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1254         (TestWebKitAPI::TEST_F):
1255
1256 2017-06-12  Lucas Forschler  <lforschler@apple.com>
1257
1258         <rdar://problem/32683422>
1259         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
1260
1261         Reviewed by Conrad Schultz.
1262
1263         * Scripts/copy-webkitlibraries-to-product-directory:
1264
1265 2017-06-12  Tim Horton  <timothy_horton@apple.com>
1266
1267         [iOS] Cmd-C doesn't copy text from WKWebView
1268         https://bugs.webkit.org/show_bug.cgi?id=173277
1269         <rdar://problem/32396742>
1270
1271         Reviewed by Dan Bernstein.
1272
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1275         Add a test ensuring that -copy on WKContentView will cause text to be copied.
1276
1277 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1278
1279         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1280         https://bugs.webkit.org/show_bug.cgi?id=173197
1281         <rdar://problem/32688148>
1282
1283         Reviewed by Brent Fulgham.
1284
1285         * DumpRenderTree/mac/DumpRenderTree.mm:
1286         (enableExperimentalFeatures):
1287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1288         (WTR::InjectedBundle::beginTesting):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1290         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1291         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1292
1293 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1294
1295         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1296         https://bugs.webkit.org/show_bug.cgi?id=173238
1297         <rdar://problem/31943370>
1298
1299         Reviewed by Ryosuke Niwa and Tim Horton.
1300
1301         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1302         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1303         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1304
1305         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1306         (TestWebKitAPI::TEST):
1307         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1308         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1309         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1310         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1311
1312 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1313
1314         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1315         https://bugs.webkit.org/show_bug.cgi?id=173225
1316         <rdar://problem/32713144>
1317
1318         Reviewed by Tim Horton.
1319
1320         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1321         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1322
1323         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1324         (TestWebKitAPI::TEST):
1325
1326 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1327
1328         Return correct process names for iOS on-device testing
1329         https://bugs.webkit.org/show_bug.cgi?id=173263
1330
1331         Reviewed by Alex Christensen.
1332
1333         When running tests on iOS devices, process names do not end with '.Development'
1334         as they do on Mac and iOS simulator.
1335
1336         * WebKitTestRunner/TestController.cpp:
1337         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1338         for iOS on-device testing.
1339         (WTR::TestController::networkProcessName): Ditto.
1340         (WTR::TestController::databaseProcessName): Ditto.
1341
1342 2017-06-12  Chris Dumez  <cdumez@apple.com>
1343
1344         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1345         https://bugs.webkit.org/show_bug.cgi?id=173267
1346         <rdar://problem/32701257>
1347
1348         Reviewed by Simon Fraser.
1349
1350         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1351         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1352         though as this covers the crash that r217867 was fixing.
1353
1354         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1355         (TestWebKitAPI::createSessionStateData):
1356         (TestWebKitAPI::TEST):
1357         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1358
1359 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1360
1361         [GTK] Stop dismissing menus attached to the web view for every injected event
1362         https://bugs.webkit.org/show_bug.cgi?id=172708
1363
1364         Reviewed by Alex Christensen.
1365
1366         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1367         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1368         events while the menu is open.
1369
1370         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1371         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1372         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1373         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1374
1375 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1376
1377         [GTK][WPE] Enable GStreamer GL on development builds
1378         https://bugs.webkit.org/show_bug.cgi?id=173248
1379
1380         Enable GStreamer GL for GTK and WPE.
1381
1382         Reviewed by Carlos Garcia Campos.
1383
1384         * Scripts/webkitperl/FeatureList.pm:
1385
1386 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1389
1390         Notifications are no longer cleared on page navigation.
1391
1392         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1393         (testWebViewNotification):
1394
1395 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1396
1397         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1398
1399         DBus interface and object path names were updated in r217831.
1400
1401         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1402
1403 2017-06-10  Dan Bernstein  <mitz@apple.com>
1404
1405         Reverted r218056 because it made the IDE reindex constantly.
1406
1407         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1408         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1409         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1410         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1411         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1412         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1413         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1414         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1415
1416 2017-06-10  Dan Bernstein  <mitz@apple.com>
1417
1418         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1419         https://bugs.webkit.org/show_bug.cgi?id=173223
1420
1421         Reviewed by Sam Weinig.
1422
1423         The rebuilds were happening due to a difference in the compiler options that the IDE and
1424         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1425         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1426         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1427
1428         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1429         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1430         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1431         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1432         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1433         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1434         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1435         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1436
1437 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1438
1439         webkitpy: Reduce polling in ServerProcess
1440         https://bugs.webkit.org/show_bug.cgi?id=173116
1441
1442         Reviewed by Ryosuke Niwa.
1443
1444         We should be smarter about polling. We do not need to poll every time a line is read from
1445         stdout and stderr since lines are usually read from cached data. We should only poll
1446         when extracting that cached data from stdout and stderr.
1447
1448         * Scripts/webkitpy/port/driver.py:
1449         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1450         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1451         * Scripts/webkitpy/port/driver_unittest.py:
1452         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1453         ServerProcess.
1454         * Scripts/webkitpy/port/server_process.py:
1455         (ServerProcess._read): Allow for data to be read from _output even if the process has
1456         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1457         * Scripts/webkitpy/port/server_process_mock.py:
1458         (MockServerProcess): Add number_of_times_polled.
1459         (MockServerProcess.poll): Increment number_of_times_polled.
1460         (MockServerProcess.has_crashed): Poll before returning crash state.
1461         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1462         just like a ServerProcess would.
1463         (MockServerProcess.read_stdout): Ditto.
1464         * Scripts/webkitpy/port/server_process_unittest.py:
1465         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1466         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1467         (TestServerProcess):
1468         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1469         the processes is polled.
1470         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1471         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1472
1473 2017-06-10  Andy Estes  <aestes@apple.com>
1474
1475         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1476         https://bugs.webkit.org/show_bug.cgi?id=173190
1477         <rdar://problem/31360659>
1478
1479         Reviewed by Brady Eidson.
1480         
1481         Added a release assert that tries to create a proper test failure if the web process crashes.
1482
1483         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1484         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1485
1486 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1487
1488         [iOS DnD] Add a hook to perform two-step drops in editable content
1489         https://bugs.webkit.org/show_bug.cgi?id=172992
1490         <rdar://problem/32590174>
1491
1492         Reviewed by Tim Horton.
1493
1494         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
1495         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
1496                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
1497
1498         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1499         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1500         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
1501
1502         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
1503         be overridden. Currently, this is overridden to just return true.
1504
1505         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1506         (TestWebKitAPI::TEST):
1507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1508         (WTR::InjectedBundlePage::InjectedBundlePage):
1509
1510 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1511
1512         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
1513         https://bugs.webkit.org/show_bug.cgi?id=173103
1514
1515         Reviewed by Xabier Rodriguez-Calvar.
1516
1517         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
1518         when building the WPE port through build-webkit.
1519
1520 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1521
1522         [WPE] Enable MEDIA_SOURCE for build-webkit builds
1523         https://bugs.webkit.org/show_bug.cgi?id=173136
1524
1525         Reviewed by Xabier Rodriguez-Calvar.
1526
1527         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
1528
1529 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1530
1531         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
1532         https://bugs.webkit.org/show_bug.cgi?id=173098
1533
1534         Reviewed by Žan Doberšek.
1535
1536         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
1537         assuming that all tests containing forms define ids for the form elements like
1538         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
1539
1540         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1541         (formControlsAssociatedCallback):
1542
1543 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
1544
1545         webkitpy: Run sample/spindump on iOS devices
1546         https://bugs.webkit.org/show_bug.cgi?id=171881
1547         <rdar://problem/32084602>
1548
1549         Reviewed by Daniel Bates.
1550
1551         * Scripts/webkitpy/port/darwin.py:
1552         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
1553         requires sudo to run spindump.
1554         * Scripts/webkitpy/port/ios_device.py:
1555         (IOSDevicePort.look_for_new_samples): Deleted.
1556         (IOSDevicePort.sample_process): Deleted.
1557         * Scripts/webkitpy/port/ios_device_unittest.py:
1558         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
1559         (IOSDeviceTest.test_spindump):
1560         (IOSDeviceTest.test_sample_process):
1561         (IOSDeviceTest.test_sample_process_exception):
1562         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1563         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
1564
1565 2017-06-08  Keith Miller  <keith_miller@apple.com>
1566
1567         WebAssembly: We should only create wrappers for functions that can be exported
1568         https://bugs.webkit.org/show_bug.cgi?id=173088
1569
1570         Reviewed by Saam Barati.
1571
1572         Add quick mode for wasm tests.
1573
1574         * Scripts/run-jsc-stress-tests:
1575
1576 2017-06-08  Darin Adler  <darin@apple.com>
1577
1578         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
1579         https://bugs.webkit.org/show_bug.cgi?id=173106
1580
1581         Reviewed by Sam Weinig.
1582
1583         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
1584         destroyed last.
1585         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
1586         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1587
1588 2017-06-07  Dan Bernstein  <mitz@apple.com>
1589
1590         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
1591         https://bugs.webkit.org/show_bug.cgi?id=173086
1592
1593         Reviewed by Andy Estes.
1594
1595         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1596         (TEST):
1597
1598 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Add High Sierra support to WebKit tools
1601         https://bugs.webkit.org/show_bug.cgi?id=173080
1602
1603         Rubber-stamped by Daniel Bates.
1604
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1609         Added dashboard support.
1610
1611         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1612         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1613         Trigger the right build queues on check-in.
1614
1615         * Scripts/webkitpy/common/system/platforminfo.py:
1616         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1617         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1618         * Scripts/webkitpy/port/mac.py:
1619         * Scripts/webkitpy/port/mac_unittest.py:
1620         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1621         Added cases for Sierra, and updated tests for new baseline search paths.
1622
1623 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
1624
1625         Unreviewed, rolling out r217902.
1626
1627         This change appears to have caused imported/w3c/web-platform-
1628         tests/fetch/api/cors tests to fail on El Capitan.
1629
1630         Reverted changeset:
1631
1632         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
1633         https://bugs.webkit.org/show_bug.cgi?id=172930
1634         http://trac.webkit.org/changeset/217902
1635
1636 2017-06-07  Daniel Bates  <dabates@apple.com>
1637
1638         Teach run-webkit-tests how to run HTTPS Web Platform Tests
1639         https://bugs.webkit.org/show_bug.cgi?id=172930
1640         <rdar://problem/32570201>
1641
1642         Reviewed by Youenn Fablet.
1643
1644         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
1645         that is conditioned on the page being delivered over a secure protocol. One example of such
1646         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
1647
1648         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
1649         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
1650         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
1651
1652         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1653         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
1654         to the Web Platform Tests HTTPS server.
1655         * Scripts/webkitpy/port/base.py:
1656         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
1657         * Scripts/webkitpy/port/driver.py:
1658         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
1659         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
1660         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
1661         indicate that they should be considered private instance variables.
1662         (Driver.is_web_platform_test): Update code for renamed instance variables.
1663         (Driver):
1664         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
1665         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
1666         determine the base URL to use to access the test.
1667         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
1668         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
1669
1670 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
1671
1672         Support removal of authentication data through the Website data store API.
1673         https://bugs.webkit.org/show_bug.cgi?id=171217
1674
1675         Reviewed by Brady Eidson.
1676
1677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1679         (WTR::InjectedBundle::didReceiveMessageToPage):
1680         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1681         (WTR::TestRunner::removeAllSessionCredentials):
1682         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
1683         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1684         * WebKitTestRunner/TestController.h:
1685         * WebKitTestRunner/TestInvocation.cpp:
1686         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1687         (WTR::TestInvocation::didRemoveAllSessionCredentials):
1688         * WebKitTestRunner/TestInvocation.h:
1689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1690         (WTR::TestController::removeAllSessionCredentials):
1691
1692 2017-06-07  Charlie Turner  <cturner@igalia.com>
1693
1694         Add Charlie Turner as contributor
1695         https://bugs.webkit.org/show_bug.cgi?id=173055
1696
1697         Reviewed by Carlos Alberto Lopez Perez.
1698
1699         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
1700         of webkit-patch upload, which reordered some fields and removed a newline.
1701
1702         * Scripts/webkitpy/common/config/contributors.json:
1703
1704 2017-06-06  Chris Dumez  <cdumez@apple.com>
1705
1706         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
1707         https://bugs.webkit.org/show_bug.cgi?id=173033
1708         <rdar://problem/32591099>
1709
1710         Reviewed by Simon Fraser.
1711
1712         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
1713         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
1717         (TestWebKitAPI::didFinishLoadForFrame):
1718         (TestWebKitAPI::setPageLoaderClient):
1719         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
1720         (TestWebKitAPI::TEST):
1721
1722 2017-06-06  Andy Estes  <aestes@apple.com>
1723
1724         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
1725         https://bugs.webkit.org/show_bug.cgi?id=172849
1726         <rdar://problem/32567454>
1727
1728         Reviewed by Darin Adler.
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
1732         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1733         (TestWebKitAPI::TEST):
1734
1735 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
1736
1737         [preload] Conditional support for media preloading and align media `as` values.
1738         https://bugs.webkit.org/show_bug.cgi?id=172501
1739
1740         Reviewed by Dean Jackson.
1741
1742         Turn on media preloading preference for tests.
1743
1744         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
1745         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
1746         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
1747
1748 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1749
1750         webkitpy: Return correct process names from SimulatorProcess
1751         https://bugs.webkit.org/show_bug.cgi?id=172940
1752
1753         Reviewed by Aakash Jain.
1754
1755         * Scripts/webkitpy/port/darwin.py:
1756         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
1757         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
1758         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
1759         * Scripts/webkitpy/port/driver.py:
1760         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
1761         _server_process.name() will not return the correct process name for iOS.
1762         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
1763         (Driver._read_block): Ditto.
1764         * Scripts/webkitpy/port/driver_unittest.py:
1765         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
1766         process_name() instead of name().
1767         * Scripts/webkitpy/port/server_process.py:
1768         (ServerProcess._start): Use process_name() instead of name().
1769         (ServerProcess.stop): Ditto.
1770         (ServerProcess.name): Deleted.
1771         * Scripts/webkitpy/port/simulator_process.py:
1772         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1773
1774 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
1775
1776         test-webkitpy: stop forking unsafely from within a spawned process
1777         https://bugs.webkit.org/show_bug.cgi?id=172774
1778
1779         Reviewed by Darin Adler.
1780
1781         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1782         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
1783         it's going to be used.
1784         (Builder.force_build):
1785
1786 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1787
1788         webkitpy: Process crash-logs for iOS devices
1789         https://bugs.webkit.org/show_bug.cgi?id=171976
1790         <rdar://problem/32134551>
1791
1792         Reviewed by David Kilzer.
1793
1794         When running layout tests on an iOS device, crash logs should be processed.
1795         Implement crash log searching and parsing for iOS devices.
1796
1797         * Scripts/webkitpy/common/system/crashlogs.py:
1798         (CrashLogs): Moved process regular expression for Darwin to class variable.
1799         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
1800         (CrashLogs.find_newest_log): Add iOS as a potential platform.
1801         (CrashLogs.find_all_logs): Ditto.
1802         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
1803         Do not assume that a Darwin crash log starts with the process.
1804         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
1805         shared code for parsing Darwin crash logs.
1806         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
1807         object so that crash logs already on the system before testing are not parsed.
1808         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
1809         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
1810         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
1811         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1812         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
1813         * Scripts/webkitpy/common/system/systemhost.py:
1814         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1815         systems is just the crashlog, use this behavior by default.
1816         * Scripts/webkitpy/common/system/systemhost_mock.py:
1817         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1818         systems is just the crashlog, use this behavior by default.
1819         * Scripts/webkitpy/port/apple.py:
1820         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
1821         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
1822         the system before testing begins
1823         * Scripts/webkitpy/port/base.py:
1824         (Port._get_crash_log): Pass optional target host when getting crash logs.
1825         * Scripts/webkitpy/port/darwin.py:
1826         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
1827         CrashLogs object.
1828         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1829         logs to be skipped to CrashLogs object.
1830         * Scripts/webkitpy/port/darwin_testcase.py:
1831         (DarwinTest.test_get_crash_log): Removed unused local function.
1832         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
1833         * Scripts/webkitpy/port/device.py:
1834         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
1835         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
1836         * Scripts/webkitpy/port/driver.py:
1837         (Driver._get_crash_log): Pass optional target host when getting crash logs.
1838         * Scripts/webkitpy/port/gtk.py:
1839         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
1840         * Scripts/webkitpy/port/ios.py: Ditto.
1841         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
1842         to be skipped for each host.
1843         * Scripts/webkitpy/port/ios_device.py:
1844         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
1845         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
1846         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
1847         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
1848         host is specified. Else, search all connected devices for the specified crash-log.
1849         (IOSDevicePort.look_for_new_crash_logs): Deleted.
1850         * Scripts/webkitpy/port/ios_device_unittest.py:
1851         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
1852         (IOSDeviceTest.test_get_crash_log): Ditto.
1853         * Scripts/webkitpy/port/simulator_process.py:
1854         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1855         * Scripts/webkitpy/port/win.py:
1856         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1857         logs to be skipped to CrashLogs object.
1858         * Scripts/webkitpy/port/wpe.py:
1859         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
1860
1861 2017-06-06  David Kilzer  <ddkilzer@apple.com>
1862
1863         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
1864         <https://webkit.org/b/172804>
1865
1866         Reviewed by Darin Adler.
1867
1868         WTF_ATTRIBUTE_PRINTF() only works outside the current
1869         compilation unit if it's on the declaration, not the
1870         implementation, of a function or class method.
1871
1872         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1873         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1874         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1875         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1876         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
1877         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1878         - Remove redundant CRASH() macro definition.  Use the one from
1879           <wtf/Assertions.h> instead.
1880
1881 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1882
1883         Move Resource Timing / User Timing from experimental features into main preferences
1884         https://bugs.webkit.org/show_bug.cgi?id=172950
1885
1886         Reviewed by Darin Adler.
1887
1888         * DumpRenderTree/mac/DumpRenderTree.mm:
1889         (enableExperimentalFeatures):
1890         (resetWebPreferencesToConsistentValues):
1891         * DumpRenderTree/win/DumpRenderTree.cpp:
1892         (enableExperimentalFeatures):
1893         (resetWebPreferencesToConsistentValues):
1894         * WebKitTestRunner/TestController.cpp:
1895         (WTR::TestController::resetPreferencesToConsistentValues):
1896         Move out no longer experimental features to the main list.
1897
1898 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1899
1900         [WPE] Add an install-dependencies script
1901         https://bugs.webkit.org/show_bug.cgi?id=172948
1902
1903         Reviewed by Žan Doberšek.
1904
1905         It is based on the gtk/install-dependencies script.
1906         Includes support for Debian based distrubutions, Fedora and Arch.
1907         It has been tested on a minimal Debian 9 chroot.
1908
1909         * wpe/install-dependencies: Added.
1910
1911 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1912
1913         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
1914         https://bugs.webkit.org/show_bug.cgi?id=172891
1915         <rdar://problem/32204540>
1916
1917         Reviewed by Darin Adler.
1918
1919         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
1920         contenteditable. See WebCore ChangeLog for more details.
1921
1922         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1923         (TestWebKitAPI::TEST):
1924
1925 2017-06-05  Daniel Bates  <dabates@apple.com>
1926
1927         webkitpy: Abstract Executive class
1928         https://bugs.webkit.org/show_bug.cgi?id=172928
1929         <rdar://problem/32569531>
1930
1931         Reviewed by Ryosuke Niwa.
1932
1933         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
1934         This will make it straightforward to create additional derived classes that
1935         adhere to the same interface, say for iOS on-device testing.
1936
1937         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
1938         (AbstractExecutive):
1939         (AbstractExecutive.run_and_throw_if_fail):
1940         (AbstractExecutive.cpu_count):
1941         (AbstractExecutive.interpreter_for_script):
1942         (AbstractExecutive.shell_command_for_script):
1943         (AbstractExecutive.kill_process):
1944         (AbstractExecutive.check_running_pid):
1945         (AbstractExecutive.running_pids):
1946         (AbstractExecutive.wait_newest):
1947         (AbstractExecutive.wait_limited):
1948         (AbstractExecutive.interrupt):
1949         (AbstractExecutive.default_error_handler):
1950         (AbstractExecutive.ignore_error):
1951         (AbstractExecutive._stringify_args):
1952         (AbstractExecutive.command_for_printing):
1953         (AbstractExecutive.run_command):
1954         (AbstractExecutive.popen):
1955         (AbstractExecutive.run_in_parallel):
1956         * Scripts/webkitpy/common/system/executive.py:
1957         (Executive):
1958         (Executive.cpu_count):
1959         (Executive.running_pids):
1960         (Executive.kill_all):
1961         (Executive._compute_stdin):
1962         (Executive.interpreter_for_script): Deleted.
1963         (Executive.shell_command_for_script): Deleted.
1964         (Executive.wait_newest): Deleted.
1965         (Executive.wait_limited): Deleted.
1966         (Executive.default_error_handler): Deleted.
1967         (Executive.ignore_error): Deleted.
1968         (Executive.command_for_printing): Deleted.
1969
1970 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
1971
1972         webkitpy: Add iOS to platform
1973         https://bugs.webkit.org/show_bug.cgi?id=172931
1974
1975         Reviewed by Daniel Bates.
1976
1977         * Scripts/webkitpy/common/system/platforminfo.py:
1978         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
1979         (PlatformInfo.is_ios): Added.
1980         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
1981         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1982         (MockPlatformInfo.is_ios): Added.
1983
1984 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1985
1986         [WPE][JHBuild] Switch github repository from git:// to https://
1987         https://bugs.webkit.org/show_bug.cgi?id=172921
1988
1989         Reviewed by Alex Christensen.
1990
1991         * wpe/jhbuild.modules:
1992
1993 2017-06-05  Tim Horton  <timothy_horton@apple.com>
1994
1995         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
1996         https://bugs.webkit.org/show_bug.cgi?id=172887
1997         <rdar://problem/32546061>
1998
1999         Reviewed by Sam Weinig.
2000
2001         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2002         (WTR::UIScriptController::applyAutocorrection):
2003         applyAutocorrection can call its completion handler synchronously,
2004         which makes UIScriptController unhappy (see bug 172884).
2005
2006 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2007
2008         webkitpy: Add contextmanager to disable logging for a block
2009         https://bugs.webkit.org/show_bug.cgi?id=172876
2010
2011         Reviewed by Daniel Bates.
2012
2013         Add a context manager which will use an OutputCapture object to capture logging
2014         in a block and hold it in a variable.
2015
2016         * Scripts/webkitpy/common/system/outputcapture.py:
2017         (OutputCaptureScope):
2018         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2019         (OutputCaptureScope.__enter__): Begin capturing output. 
2020         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2021         output and retain the resulting log.
2022         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2023         (OutputCaptureTest.test_output_capture_scope): Added.
2024
2025 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2026
2027         Cleanup FrameView::autoSizeIfEnabled.
2028         https://bugs.webkit.org/show_bug.cgi?id=172889
2029         <rdar://problem/32550783>
2030
2031         Reviewed by Tim Horton.
2032
2033         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2034         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2035         (TEST):
2036
2037 2017-06-02  Chris Dumez  <cdumez@apple.com>
2038
2039         ResourceLoadStatistics are not using unique paths during test runs
2040         https://bugs.webkit.org/show_bug.cgi?id=172861
2041         <rdar://problem/32442251>
2042
2043         Reviewed by Darin Adler.
2044
2045         Make sure WebKitTestRunner sets a temporary path for saving resource
2046         load statistics.
2047
2048         * WebKitTestRunner/TestController.cpp:
2049         (WTR::TestController::generateContextConfiguration):
2050
2051 2017-06-02  Brady Eidson  <beidson@apple.com>
2052
2053         Prevent scheme handlers from handling all built-in URL schemes.
2054         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2055
2056         Reviewed by Andy Estes.
2057
2058         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2059
2060 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2061
2062         [JSCOnly] Build static jsc.exe on Windows
2063         https://bugs.webkit.org/show_bug.cgi?id=172833
2064
2065         Reviewed by Konstantin Tokarev.
2066
2067         * CMakeLists.txt:
2068         * Scripts/build-jsc:
2069
2070 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2071
2072         Disable ViewportSizeForViewportUnits tests on iOS.
2073         https://bugs.webkit.org/show_bug.cgi?id=172872
2074
2075         Reviewed by Tim Horton.
2076
2077         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2078
2079 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2080
2081         Allow clients to override viewport size for CSS viewport units.
2082         https://bugs.webkit.org/show_bug.cgi?id=172838
2083         <rdar://problem/32523441>
2084
2085         Reviewed by Tim Horton.
2086
2087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2088         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2089         (TEST):
2090
2091 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2092
2093         Get <chrono> out of StdLibExtras.h
2094         https://bugs.webkit.org/show_bug.cgi?id=172744
2095
2096         Reviewed by Zalan Bujtas.
2097
2098         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2099
2100 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2101
2102         [WPE] Enable SUBTLE_CRYPTO
2103         https://bugs.webkit.org/show_bug.cgi?id=172756
2104
2105         Reviewed by Michael Catanzaro.
2106
2107         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2108         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2109         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2110         exhausting entropy when running the crypto layout tests.
2111
2112 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2113
2114         [GTK] Bump GTK+ and its dependencies in jhbuild
2115         https://bugs.webkit.org/show_bug.cgi?id=171918
2116
2117         Reviewed by Carlos Alberto Lopez Perez.
2118
2119         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2120         (WTR::initializeGtkSettings):
2121         * gtk/jhbuild.modules:
2122         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2123         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2124
2125 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2126
2127         [GTK] Bump wayland and weston in jhbuild
2128         https://bugs.webkit.org/show_bug.cgi?id=171921
2129
2130         Reviewed by Carlos Alberto Lopez Perez.
2131
2132         * gtk/jhbuild.modules:
2133         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2134
2135 2017-06-01  Andy Estes  <aestes@apple.com>
2136
2137         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2138         https://bugs.webkit.org/show_bug.cgi?id=172828
2139
2140         Reviewed by Beth Dakin.
2141
2142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2143
2144 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2145
2146         webkitpy: Remove unneeded simulator teardown
2147         https://bugs.webkit.org/show_bug.cgi?id=171891
2148
2149         Reviewed by Aakash Jain.
2150
2151         * Scripts/webkitpy/port/ios_simulator.py:
2152         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
2153         for communication between Python and WebKitTestRunner/DumpRenderTree.
2154
2155 2017-06-01  Keith Miller  <keith_miller@apple.com>
2156
2157         Undo rollout in r217638 with bug fix
2158         https://bugs.webkit.org/show_bug.cgi?id=172824
2159
2160         Unreviewed, reland patch with unused set_state code removed.
2161
2162         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2163         (runThreadMessageTest):
2164         (TEST):
2165
2166 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2167
2168         webkitpy: Do not send 0 or -1 as a pid to kill_process
2169         https://bugs.webkit.org/show_bug.cgi?id=172818
2170
2171         Reviewed by Darin Adler.
2172
2173         Sending a signal to process 0 will result in all processes in the group receiving 
2174         the signal. Sending a signal to process -1 will result in all non-system processes
2175         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
2176         should consider these cases
2177
2178         * Scripts/webkitpy/common/system/executive.py:
2179         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
2180         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
2181         never be running, although os.kill may succeed.
2182         * Scripts/webkitpy/port/simulator_process.py:
2183         (SimulatorProcess.stop): Do not kill process if it is undefined.
2184
2185 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
2186
2187         JSC EWS bot does not run on WTF only patches
2188         https://bugs.webkit.org/show_bug.cgi?id=172777
2189         rdar://problem/32495975
2190
2191         Reviewed by Aakash Jain.
2192
2193         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2194         (CheckPatchRelevance): Add a missing comma.
2195
2196 2017-05-31  Commit Queue  <commit-queue@webkit.org>
2197
2198         Unreviewed, rolling out r217611 and r217631.
2199         https://bugs.webkit.org/show_bug.cgi?id=172785
2200
2201         "caused wasm-hashset-many.html to become flaky." (Requested by
2202         keith_miller on #webkit).
2203
2204         Reverted changesets:
2205
2206         "Reland r216808, underlying lldb bug has been fixed."
2207         https://bugs.webkit.org/show_bug.cgi?id=172759
2208         http://trac.webkit.org/changeset/217611
2209
2210         "Use dispatch queues for mach exceptions"
2211         https://bugs.webkit.org/show_bug.cgi?id=172775
2212         http://trac.webkit.org/changeset/217631
2213
2214 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2215
2216         EWS bots should reboot themselves more frequently
2217         https://bugs.webkit.org/show_bug.cgi?id=172402
2218
2219         Reviewed by Alexey Proskuryakov.
2220
2221         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
2222
2223         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
2224
2225 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2226
2227         Reallocate hardware for iOS bots.
2228         https://bugs.webkit.org/show_bug.cgi?id=172657
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         * BuildSlaveSupport/build.webkit.org-config/config.json:
2233
2234 2017-05-31  Andy Estes  <aestes@apple.com>
2235
2236         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2237         https://bugs.webkit.org/show_bug.cgi?id=172366
2238
2239         Reviewed by Daniel Bates.
2240
2241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2242
2243 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
2244
2245         Unreviewed, add Jiewen Tan as a reviewer
2246
2247         * Scripts/webkitpy/common/config/contributors.json:
2248
2249 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2250
2251         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
2252         https://bugs.webkit.org/show_bug.cgi?id=172770
2253
2254         Reviewed by Michael Catanzaro.
2255
2256         * MiniBrowser/gtk/BrowserWindow.c:
2257         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
2258         which caused the body of the if-clause to be accidentally empty.
2259
2260 2017-05-31  Keith Miller  <keith_miller@apple.com>
2261
2262         Reland r216808, underlying lldb bug has been fixed.
2263         https://bugs.webkit.org/show_bug.cgi?id=172759
2264
2265         Unreviewed, relanding old patch. See: rdar://problem/31183352
2266
2267         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2268         (runThreadMessageTest):
2269         (TEST):
2270
2271 2017-05-31  Matt Lewis  <jlewis3@apple.com>
2272
2273         Unreviewed, rolling out r217603.
2274
2275         This patch broke the internal builds.
2276
2277         Reverted changeset:
2278
2279         "Get <chrono> out of StdLibExtras.h"
2280         https://bugs.webkit.org/show_bug.cgi?id=172744
2281         http://trac.webkit.org/changeset/217603
2282
2283 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2284
2285         Make ResourceLoadStatistics testing more reliable
2286         https://bugs.webkit.org/show_bug.cgi?id=172730
2287         <rdar://problem/32028373>
2288
2289         Reviewed by Andy Estes.
2290
2291         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2292         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2293
2294         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2295         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2296
2297 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2298
2299         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2300         https://bugs.webkit.org/show_bug.cgi?id=172757
2301
2302         Reviewed by Xabier Rodriguez-Calvar.
2303
2304         When needed, add the jhbuild wrapper at the beginning of the array
2305         that will be invoked to execute the run-jsc-stress-test or testapi
2306         commands.
2307
2308         * Scripts/run-javascriptcore-tests:
2309         (runJSCStressTests):
2310         * Scripts/webkitdirs.pm:
2311         (shouldUseJhbuild):
2312
2313 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2314
2315         Get <chrono> out of StdLibExtras.h
2316         https://bugs.webkit.org/show_bug.cgi?id=172744
2317
2318         Reviewed by Saam Barati.
2319
2320         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2321
2322 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2323
2324         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2325         https://bugs.webkit.org/show_bug.cgi?id=172735
2326         <rdar://problem/32015977>
2327
2328         Reviewed by Enrica Casucci.
2329
2330         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2331         (WTR::UIScriptController::applyAutocorrection):
2332         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2333         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2334         (WTR::UIScriptController::applyAutocorrection):
2335         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2336         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2337         (WTR::UIScriptController::applyAutocorrection):
2338         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2339         because I don't know how to tap the button in the autocorrection bar from a test.
2340
2341 2017-05-30  Daniel Bates  <dabates@apple.com>
2342
2343         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2344         https://bugs.webkit.org/show_bug.cgi?id=172671
2345
2346         Reviewed by Alex Christensen.
2347
2348         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2349         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2350
2351         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2352         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2353         to trigger a navigation to test it.
2354         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2355         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2356
2357 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2358
2359         webkitpy: Start servers before setting-up for testing
2360         https://bugs.webkit.org/show_bug.cgi?id=172176
2361         <rdar://problem/32225538>
2362
2363         Reviewed by Alexey Proskuryakov.
2364
2365         On-device testing requires that servers are started before ports set-up their
2366         test environments.
2367
2368         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2369         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2370         Servers are unconditionally stopped on exit.
2371         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2372         Manager now stops servers.
2373         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2374         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2375         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2376         (Manager.__init__): Delay construction of the test runner until we can determine
2377         if servers need to be started.
2378         (Manager.run): Determine if servers need to be started and construct the test runner.
2379         Shut servers down when the test run is finished.
2380         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2381         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2382         (is_wpt_server_running): Server is not running if no config is found.
2383         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2384         (PyWebSocket.is_running): Check if this WebSocket server is running.
2385         * Scripts/webkitpy/port/base.py:
2386         (Port.__init__): Define secure WebSocket server.
2387         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2388
2389 2017-05-30  Daniel Bates  <dabates@apple.com>
2390
2391         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2392         https://bugs.webkit.org/show_bug.cgi?id=172603
2393         <rdar://problem/32471306>
2394
2395         Reviewed by Brady Eidson.
2396
2397         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2398         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2399         unloading is initiated for a page that registered a onbeforeunload handler.
2400
2401         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2402         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2403         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2404
2405         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2406         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2407         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2408         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2409
2410         * MiniBrowser/mac/WK2BrowserWindowController.m:
2411         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2412         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2414         (sawDialog):
2415         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2416         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2417         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2418
2419 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2420
2421         Update libwebrtc configuration
2422         https://bugs.webkit.org/show_bug.cgi?id=172727
2423
2424         Reviewed by Geoffrey Garen.
2425
2426         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2427
2428 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2429
2430         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2431         https://bugs.webkit.org/show_bug.cgi?id=172702
2432
2433         Reviewed by Alex Christensen.
2434
2435         EGL PlatformDisplay needs to be shut down before existing a
2436         program on Windows.
2437
2438         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2439         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2440         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2441         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2442
2443 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2444
2445         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2446         https://bugs.webkit.org/show_bug.cgi?id=172709
2447
2448         Reviewed by Brent Fulgham.
2449
2450         Exit fullscreen mode after a fullscreen test.
2451
2452         * DumpRenderTree/win/DumpRenderTree.cpp:
2453         (resetWebViewToConsistentStateBeforeTesting):
2454
2455 2017-05-30  Antti Koivisto  <antti@apple.com>
2456
2457         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2458         https://bugs.webkit.org/show_bug.cgi?id=172713
2459
2460         Reviewed by Zalan Bujtas.
2461
2462         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2463         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2464
2465             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2466             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2467             because on Mac WK1 it may get invoked from middle of a layout.
2468
2469             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2470
2471 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2472
2473         Add a WPE EWS queue
2474         https://bugs.webkit.org/show_bug.cgi?id=172693
2475
2476         Reviewed by Carlos Garcia Campos.
2477
2478         * QueueStatusServer/config/queues.py:
2479         * QueueStatusServer/model/queues.py: Capitalize the name of the
2480         port on the tooltip of the bubbles. Do the same for the GTK port.
2481         (Queue.display_name):
2482         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2483         for the GTK+ EWS also. Set for both ports as watcher the alias
2484         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2485         * Scripts/webkitpy/common/config/ports.py:
2486         (DeprecatedPort.port):
2487         (WpePort):
2488         (WpePort.build_webkit_command):
2489         (WpePort.run_webkit_tests_command):
2490         * Scripts/webkitpy/common/config/ports_unittest.py:
2491         (DeprecatedPortTest):
2492         (DeprecatedPortTest.test_wpe_port):
2493         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2494         (test_ews_name):
2495
2496 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
2497
2498         Unreviewed. Bumping the WPEBackend-mesa dependency version.
2499
2500         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
2501         priorities for IPC communication.
2502
2503 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
2504
2505         [JSC] Map and Set constructors should have fast path for cloning
2506         https://bugs.webkit.org/show_bug.cgi?id=172413
2507
2508         Reviewed by Saam Barati.
2509
2510         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2511         (TestWebKitAPI::TEST):
2512
2513 2017-05-27  Zalan Bujtas  <zalan@apple.com>
2514
2515         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
2516         https://bugs.webkit.org/show_bug.cgi?id=172676
2517
2518         Reviewed by Simon Fraser.
2519
2520         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2521         (TestWebKitAPI::TEST):
2522
2523 2017-05-26  Zalan Bujtas  <zalan@apple.com>
2524
2525         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
2526         https://bugs.webkit.org/show_bug.cgi?id=172674
2527
2528         Reviewed by Simon Fraser.
2529
2530         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2531         (TestWebKitAPI::TEST):
2532
2533 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         Add test resources back into TestWebKitAPI Copy Resources phase
2536
2537         Rubber-stamped by Beth Dakin.
2538
2539         Add two files back into the Copy Resources phase after they were unintentionally
2540         removed in r217447 and r217496.
2541
2542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2543
2544 2017-05-26  Beth Dakin  <bdakin@apple.com>
2545
2546         Media documents inside iframes should not get controls in the TouchBar unless the 
2547         video is playing
2548         https://bugs.webkit.org/show_bug.cgi?id=172620
2549         -and corresponding-
2550         rdar://problem/32165477
2551
2552         Reviewed by Jon Lee.
2553
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2556         (TestWebKitAPI::TEST):
2557         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
2558
2559 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
2560
2561         _WKUserStyleSheet and WKUserScript leak string data
2562         https://bugs.webkit.org/show_bug.cgi?id=172583
2563         <rdar://problem/32395209>
2564
2565         Reviewed by Sam Weinig.
2566
2567         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2568         We should not have been adopting an autoreleased object.
2569
2570 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
2571
2572         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
2573         https://bugs.webkit.org/show_bug.cgi?id=172554
2574         <rdar://problem/31247133>
2575
2576         Reviewed by Simon Fraser.
2577
2578         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
2579         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
2580         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
2581         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
2582         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
2583         codepath.
2584
2585         * DumpRenderTree/TestOptions.h:
2586         * DumpRenderTree/TestOptions.mm:
2587         (TestOptions::TestOptions):
2588         (TestOptions::webViewIsCompatibleWithOptions):
2589         * DumpRenderTree/mac/DumpRenderTree.mm:
2590         (shouldIgnoreWebCoreNodeLeaks):
2591         (allowedFontFamilySet):
2592         (-[DRTMockScroller rectForPart:]):
2593         (-[DRTMockScroller drawKnob]):
2594         (-[DRTMockScroller drawRect:]):
2595         (createWebViewAndOffscreenWindow):
2596         (initializeGlobalsFromCommandLineOptions):
2597         (prepareConsistentTestingEnvironment):
2598         (dumpRenderTree):
2599         (dumpAudio):
2600         (dumpHistoryItem):
2601         (dumpBackForwardListForWebView):
2602         (resetWebViewToConsistentStateBeforeTesting):
2603         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
2604         (runTest):
2605
2606 2017-05-25  Sam Weinig  <sam@webkit.org>
2607
2608         [WebIDL] Use the term 'operation' more consistently
2609         https://bugs.webkit.org/show_bug.cgi?id=172601
2610
2611         Reviewed by Chris Dumez.
2612
2613         We were using the term 'operation', a WebIDL term for function-like
2614         constructs, inconsistently in the code generator. Now, when we use
2615         'operation' when referring to the IDL concept (usually the object the
2616         parser produces) and 'function' when referring to code being generated.
2617
2618         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2619         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2620
2621 2017-05-25  Jer Noble  <jer.noble@apple.com>
2622
2623         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
2624
2625         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2626
2627 2017-05-25  Jer Noble  <jer.noble@apple.com>
2628
2629         System sleeps while playing to wireless target, ending stream.
2630         https://bugs.webkit.org/show_bug.cgi?id=172541
2631
2632         Reviewed by Eric Carlson.
2633
2634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2635         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
2636         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
2637         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2638         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2639         (TestWebKitAPI::simulateKeyDown):
2640         (TestWebKitAPI::hasAssertionType):
2641         (TestWebKitAPI::TEST):
2642
2643 2017-05-25  Commit Queue  <commit-queue@webkit.org>
2644
2645         Unreviewed, rolling out r217423 and r217424.
2646         https://bugs.webkit.org/show_bug.cgi?id=172607
2647
2648         These caused an api failure on all testers. (Requested by
2649         mlewis13 on #webkit).
2650
2651         Reverted changesets:
2652
2653         "REGRESSION (r216977): 4 leaks introduced in new
2654         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
2655         https://bugs.webkit.org/show_bug.cgi?id=172558
2656         http://trac.webkit.org/changeset/217423
2657
2658         "REGRESSION (r217423): Fix last-second typo in 'auto'"
2659         http://trac.webkit.org/changeset/217424
2660
2661 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
2662
2663         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
2664         https://bugs.webkit.org/show_bug.cgi?id=172355
2665
2666         Reviewed by Chris Fleizach.
2667
2668         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
2669         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
2670         releases which support the new platform footnote accessibility role.
2671
2672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2673         * gtk/jhbuild.modules:
2674
2675 2017-05-25  David Kilzer  <ddkilzer@apple.com>
2676
2677         REGRESSION (r217423): Fix last-second typo in 'auto'
2678
2679         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2680         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
2681
2682 2017-05-24  David Kilzer  <ddkilzer@apple.com>
2683
2684         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
2685         <https://webkit.org/b/172558>
2686
2687         Reviewed by Sam Weinig.
2688
2689         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2690         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
2691
2692 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2693
2694         [CMake] Consolidate CMake code related to Cairo
2695         https://bugs.webkit.org/show_bug.cgi?id=172568
2696
2697         Reviewed by Alex Christensen.
2698
2699         * DumpRenderTree/config.h:
2700         * TestWebKitAPI/config.h:
2701
2702 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2703
2704         Plumb additional image metadata to item providers when beginning data interaction on an image
2705         https://bugs.webkit.org/show_bug.cgi?id=172536
2706         <rdar://problem/32371300>
2707
2708         Reviewed by Beth Dakin.
2709
2710         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
2711         source item providers.
2712
2713         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2714         (checkSuggestedNameAndEstimatedSize):
2715         (TestWebKitAPI::TEST):
2716
2717 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2718
2719         [Win] Create unique network storage session for each DRT.
2720         https://bugs.webkit.org/show_bug.cgi?id=172540
2721
2722         Reviewed by Brent Fulgham.
2723
2724         During layout testing, each DRT instance should have its own network storage session.
2725
2726         * DumpRenderTree/win/DumpRenderTree.cpp:
2727         (prepareConsistentTestingEnvironment):
2728
2729 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2730
2731         Respect image UTIs when writing to item providers when beginning data interaction on an image
2732         https://bugs.webkit.org/show_bug.cgi?id=172436
2733         <rdar://problem/31786569>
2734
2735         Reviewed by Beth Dakin.
2736
2737         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
2738         details.
2739
2740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2741         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
2743
2744         Create a new test page containing a GIF and a file input.
2745
2746         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2747         (checkTypeIdentifierIsRegisteredAtIndex):
2748         (TestWebKitAPI::TEST):
2749
2750 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
2751
2752         [Win] Increase test timeout for slow tests.
2753         https://bugs.webkit.org/show_bug.cgi?id=172449
2754
2755         Reviewed by Alexey Proskuryakov.
2756
2757         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
2758         timeout member in the TestRunner class.
2759
2760         * DumpRenderTree/win/TestRunnerWin.cpp:
2761         (TestRunner::setWaitToDump):
2762
2763 2017-05-15  Matt Rajca  <mrajca@apple.com>
2764
2765         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
2766         https://bugs.webkit.org/show_bug.cgi?id=172138
2767
2768         Reviewed by Alex Christensen.
2769
2770         Added API tests.
2771
2772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2773         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
2774         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2775         (TEST):
2776         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
2777
2778 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2779
2780         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2781         https://bugs.webkit.org/show_bug.cgi?id=172522
2782         rdar://problem/31071812
2783
2784         Reviewed by Sam Weinig.
2785
2786         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
2787         We set this in the .xib file now.
2788
2789         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2790
2791 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2792
2793         Snapshotting via -renderInContext: should do synchronous image decodes
2794         https://bugs.webkit.org/show_bug.cgi?id=172485
2795         rdar://problem/32276146
2796
2797         Reviewed by Tim Horton.
2798
2799         New API test.
2800
2801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2802         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
2803         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2804         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2805         (TestWebKitAPI::getPixelIndex):
2806         (TestWebKitAPI::TEST):
2807
2808 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2809
2810         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2811         https://bugs.webkit.org/show_bug.cgi?id=172517
2812
2813         Rubber-stamped by Simon Fraser.
2814
2815         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2816
2817 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2818
2819         Multiple links should be inserted separately when performing data interaction
2820         https://bugs.webkit.org/show_bug.cgi?id=172489
2821         <rdar://problem/31510832>
2822
2823         Reviewed by Dan Bernstein.
2824
2825         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
2826
2827         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2828         (TestWebKitAPI::TEST):
2829
2830 2017-05-23  Tim Horton  <timothy_horton@apple.com>
2831
2832         REGRESSION: API test WebKit2.WKObject is failing
2833         https://bugs.webkit.org/show_bug.cgi?id=172497
2834         <rdar://problem/31694641>
2835
2836         Reviewed by Geoff Garen.
2837
2838         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2839         (TestWebKitAPI::TEST):
2840         Add a test that ensures that we pretend to at least be *some* kind of
2841         NSString, which my first fix would not have passed.
2842
2843 2017-05-23  youenn fablet  <youenn@apple.com>
2844
2845         There should be an easy way to run HTTP/WPT served tests on a browser
2846         https://bugs.webkit.org/show_bug.cgi?id=172068
2847
2848         Reviewed by Sam Weinig.
2849
2850         Adding a new script open-layout-test to open a layout-test in a
2851         browser and making sure it is served as done through run-webkit-tests.
2852         In case tests should be run using a server, detecting whether the
2853         server are running. If not, calling run-webkit-httpd to run the
2854         servers and open the URL in a browser.
2855         Otherwise, open directly the URL.
2856
2857         Adding an option in run-webkit-httpd to open an URL after having
2858         started the servers.
2859
2860         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
2861         This allows running run-webkit-httpd once and not having to restart
2862         servers everytime a test should be served.
2863
2864         Moving most of run-webkit-httpd logic in its own python file to reuse
2865         it in open-layout-test script.
2866
2867         Adding routines to check whether HTTP and WPT servers are running.
2868
2869         * Scripts/open-layout-test: Added.
2870         (parse_args):
2871         (main):
2872         * Scripts/run-webkit-httpd:
2873         (main):
2874         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2875         (LayoutTestFinder.find_tests):
2876         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2877         (LayoutTestRunner.run_tests):
2878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2879         (parse_args):
2880         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2881         (HttpServerBase._is_server_running_on_all_ports):
2882         (HttpServerBase):
2883         (HttpServerBase._is_running_on_port):
2884         (HttpServerBase._check_that_all_ports_are_available):
2885         (is_http_server_running):
2886         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
2887         (parse_args):
2888         (main):
2889         (run_server):
2890         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2891         (is_wpt_server_running):
2892         * Scripts/webkitpy/port/base.py:
2893         (Port.to.is_http_server_running):
2894         (Port.to):
2895         (Port.to.is_wpt_server_running):
2896         (Port.to.start_web_platform_test_server):
2897         * Scripts/webkitpy/port/driver.py:
2898         (DriverProxy.is_web_platform_test):
2899         (DriverProxy):
2900         (DriverProxy.is_webkit_specific_web_platform_test):
2901
2902 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2903
2904         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2905         https://bugs.webkit.org/show_bug.cgi?id=171984
2906
2907         Reviewed by Antti Koivisto.
2908
2909         * DumpRenderTree/mac/DumpRenderTree.mm:
2910         (enableExperimentalFeatures):
2911         * WebKitTestRunner/TestController.cpp:
2912         (WTR::TestController::resetPreferencesToConsistentValues):
2913
2914 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2915
2916         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
2917         https://bugs.webkit.org/show_bug.cgi?id=172406
2918         <rdar://32109532>
2919
2920         Reviewed by Brady Eidson.
2921
2922         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2923         (TestWebKitAPI::checkBuffer):
2924         (TestWebKitAPI::TEST_F):
2925
2926 2017-05-22  Jason Marcell  <jmarcell@apple.com>
2927
2928         Do not enter Subversion-specific logic when parsing Git-based Trac data.
2929         https://bugs.webkit.org/show_bug.cgi?id=172433
2930         <rdar://problem/32234188>
2931
2932         Reviewed by Alexey Proskuryakov.
2933
2934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2935         (Trac.prototype._convertCommitInfoElementToObject):
2936
2937 2017-05-22  Tim Horton  <timothy_horton@apple.com>
2938
2939         ExplicitSnapshotsChangeUponNavigation API test often fails
2940         https://bugs.webkit.org/show_bug.cgi?id=172475
2941         <rdar://problem/31688322>
2942
2943         Reviewed by Simon Fraser.
2944
2945         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2946         (-[TestWKWebView _setUpTestWindow:]):
2947         Make TestWKWebView's window layer-backed. This is now the default,
2948         and it's also easy to accidentally write a test that depends on it
2949         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
2950         which becomes layer backed, just like the WKWebView, but with no
2951         common layer-backed ancestor).
2952
2953 2017-05-22  youenn fablet  <youenn@apple.com>
2954
2955         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
2956         https://bugs.webkit.org/show_bug.cgi?id=172426
2957
2958         Reviewed by Chris Dumez.
2959
2960         * Scripts/webkitpy/w3c/test_importer.py:
2961         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
2962
2963 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
2964
2965         Unreviewed, change my status to reviewer and fill "expertise" field
2966
2967         * Scripts/webkitpy/common/config/contributors.json:
2968
2969 2017-05-22  Tomas Popela  <tpopela@redhat.com>
2970
2971         Remove some of the EFL port leftovers
2972         https://bugs.webkit.org/show_bug.cgi?id=172440
2973
2974         Reviewed by Carlos Garcia Campos.
2975
2976         * BuildSlaveSupport/built-product-archive:
2977         (archiveBuiltProduct):
2978         (extractBuiltProduct):
2979         * BuildSlaveSupport/test-result-archive:
2980         (archiveTestResults):
2981         * ImageDiff/PlatformEfl.cmake: Removed.
2982         * Scripts/run-efl-tests: Removed.
2983         * Scripts/webkit-build-directory:
2984         * Scripts/webkitpy/common/config/contributionareas.py:
2985         * Scripts/webkitpy/common/config/watchlist:
2986         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2987         (parse_args):
2988         (_set_up_derived_options):
2989         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2990         (PerfTestsRunner.__init__):
2991         * Scripts/webkitpy/style/checker.py:
2992         * Scripts/webkitpy/style/checker_unittest.py:
2993         (GlobalVariablesTest.test_path_rules_specifier):
2994         * gtk/manifest.txt.in:
2995         * jhbuild/jhbuild-wrapper:
2996
2997 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         Unreviewed. Do not include WPE files in GTK+ tarballs.
3000
3001         * gtk/manifest.txt.in:
3002
3003 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3004
3005         [GTK] Add webkit_context_menu_item_new_from_gaction
3006         https://bugs.webkit.org/show_bug.cgi?id=159631
3007
3008         Reviewed by Michael Catanzaro.
3009
3010         Update context menu tests to check the new GAction API.
3011
3012         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3013         (testContextMenuPopulateMenu):
3014
3015 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3016
3017         [GTK] Remove Firefox user agent quirk for Google domains
3018         https://bugs.webkit.org/show_bug.cgi?id=171941
3019
3020         Reviewed by Carlos Garcia Campos.
3021
3022         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3023         (TestWebKitAPI::TEST):
3024         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
3025
3026 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
3027
3028         [GTK] gtkdoc-fixxref needs --module argument to work
3029         https://bugs.webkit.org/show_bug.cgi?id=172415
3030
3031         Reviewed by Michael Catanzaro.
3032
3033         * gtk/gtkdoc.py:
3034         (GTKDoc._run_gtkdoc_fixxref):
3035
3036 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
3037
3038         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
3039         https://bugs.webkit.org/show_bug.cgi?id=172416
3040
3041         Reviewed by Daniel Bates.
3042
3043         * Scripts/make-new-script-test:
3044
3045 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3046
3047         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
3048         https://bugs.webkit.org/show_bug.cgi?id=172267
3049
3050         Reviewed by Per Arne Vollan.
3051
3052         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
3053         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
3054         should link only with WebKit.
3055
3056         Unfortunately, there is a layer violation at the moment.
3057         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
3058         in WebKit. This change contains a stub of loadResourceIntoBuffer
3059         in TestWebCoreLib for the workaround.
3060
3061         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
3062         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
3063         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
3064         (loadResourceIntoBuffer): Added a stub.
3065
3066 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
3067
3068         Fix dump-class-layout to handle different file architectures
3069         https://bugs.webkit.org/show_bug.cgi?id=172392
3070
3071         Reviewed by Zalan Bujtas.
3072
3073         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
3074         and use the first architecture reported. Also add a "--architecture" argument
3075         to allow the user to specify an architecture.
3076
3077         * Scripts/dump-class-layout:
3078         (import_lldb):
3079         (verify_type_recursive):
3080         (get_first_file_architecture):
3081         (dump_class):
3082         (main):
3083         (find_build_directory): Deleted.
3084
3085 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3086
3087         Unreviewed infrastructure fix.
3088
3089         * Scripts/webkitpy/port/ios_simulator.py:
3090         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
3091
3092 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3093
3094         webkitpy: Use simctl boot to run multiple simulators at once
3095         https://bugs.webkit.org/show_bug.cgi?id=172374
3096
3097         Reviewed by Alexey Proskuryakov.
3098
3099         * Scripts/webkitpy/common/system/platforminfo.py:
3100         (PlatformInfo.xcode_version): Return the current version of Xcode.
3101         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3102         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
3103         * Scripts/webkitpy/port/ios_simulator.py:
3104         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
3105         run multiple Simulator.app instances.
3106         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
3107         versions of Xcode.
3108         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
3109         an older version of Xcode.
3110
3111 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3112
3113         Unreviewed, fix the build on the latest internal SDK.
3114
3115         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3116         (TestWebKitAPI::TEST):
3117
3118 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
3119
3120         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
3121         https://bugs.webkit.org/show_bug.cgi?id=172369
3122
3123         Reviewed by Mark Lam.
3124         
3125         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
3126         would be a good idea to write this down.
3127
3128         * Scripts/run-jsc-stress-tests:
3129
3130 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3131
3132         webkitpy: Layout tests which have no output will succeed
3133         https://bugs.webkit.org/show_bug.cgi?id=172322
3134         <rdar://problem/32258350>
3135
3136         Reviewed by David Kilzer.
3137
3138         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3139         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
3140         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3141         (determine_result_type): FailureNotTested means that the test could not be loaded. This
3142         is classified as a MISSING failure.
3143         (FailureNotTested): Added.
3144         (FailureNotTested.message):
3145
3146 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3147
3148         Add SixSpeed benchmark to PerformanceTests
3149         https://bugs.webkit.org/show_bug.cgi?id=172326
3150
3151         Reviewed by Sam Weinig.
3152
3153         * Scripts/run-jsc-benchmarks:
3154
3155 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3156
3157         [WK1] MiniBrowser should navigate when handling a dropped URL
3158         https://bugs.webkit.org/show_bug.cgi?id=172350
3159
3160         Reviewed by Tim Horton.
3161
3162         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
3163
3164         * MiniBrowser/mac/WK1BrowserWindowController.m:
3165         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
3166
3167 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
3168
3169         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
3170         https://bugs.webkit.org/show_bug.cgi?id=172077
3171
3172         Reviewed by Chris Dumez.
3173
3174         Fixed perftest.py by updating the lines to ignore in Speedometer.
3175
3176         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
3177
3178         * Scripts/webkitpy/performance_tests/perftest.py:
3179         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
3180         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3181         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
3182         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
3183         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3184         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
3185
3186 2017-05-18  Andy Estes  <aestes@apple.com>
3187
3188         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3189         https://bugs.webkit.org/show_bug.cgi?id=172305
3190
3191         Reviewed by Anders Carlsson.
3192
3193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3194
3195 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3196
3197         Selection around attachment elements should not persist when beginning a drag
3198         https://bugs.webkit.org/show_bug.cgi?id=172319
3199         <rdar://problem/32283008>
3200
3201         Reviewed by Tim Horton.
3202
3203         Tests that temporary selection around an attachment does not persist longer than it needs to.
3204
3205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3206         (TestWebKitAPI::TEST):
3207
3208 2017-05-18  John Wilander  <wilander@apple.com>
3209
3210         Resource Load Statistics: Grandfather domains for existing data records
3211         https://bugs.webkit.org/show_bug.cgi?id=172155
3212         <rdar://problem/24913532>
3213
3214         Reviewed by Alex Christensen.
3215
3216         Adds test infrastructure needed for the added functionality.
3217
3218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3220         (WTR::InjectedBundle::didReceiveMessageToPage):
3221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3222         (WTR::TestRunner::setStatisticsGrandfathered):
3223         (WTR::TestRunner::isStatisticsGrandfathered):
3224         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3225         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3226         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::setStatisticsGrandfathered):
3230         (WTR::TestController::isStatisticsGrandfathered):
3231         (WTR::TestController::setStatisticsGrandfatheringTime):
3232         * WebKitTestRunner/TestController.h:
3233         * WebKitTestRunner/TestInvocation.cpp:
3234         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3235
3236 2017-05-18  Saam Barati  <sbarati@apple.com>
3237
3238         WebAssembly: perform stack checks
3239         https://bugs.webkit.org/show_bug.cgi?id=165546
3240         <rdar://problem/29760307>
3241
3242         Reviewed by Filip Pizlo.
3243
3244         Add some new testing modes for using and not using fast TLS wasm contexts.
3245
3246         * Scripts/run-jsc-stress-tests:
3247
3248 2017-05-18  Daniel Bates  <dabates@apple.com>
3249
3250         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
3251         window CSP when object-src 'none' is set
3252         https://bugs.webkit.org/show_bug.cgi?id=172038
3253         <rdar://problem/32258262>
3254
3255         Reviewed by Andy Estes.
3256
3257         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
3258         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
3259
3260         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3261         (NPP_New):
3262
3263 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
3264
3265         [Win] Many layout tests are failing.
3266         https://bugs.webkit.org/show_bug.cgi?id=172286
3267
3268         Reviewed by Brent Fulgham.
3269
3270         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
3271  
3272         * DumpRenderTree/win/TestRunnerWin.cpp:
3273         (TestRunner::grantWebNotificationPermission):
3274         (TestRunner::denyWebNotificationPermission):
3275         (TestRunner::removeAllWebNotificationPermissions):
3276         (TestRunner::simulateWebNotificationClick):
3277
3278 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
3279
3280         [Win] Remove usage of _snprintf
3281         https://bugs.webkit.org/show_bug.cgi?id=172251
3282
3283         Reviewed by Per Arne Vollan.
3284
3285         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3286         * MiniBrowser/win/PageLoadTestClient.cpp:
3287         (PageLoadTestClient::dumpRunStatistics):
3288
3289 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3290
3291         Unreviewed, rolling out r217014.
3292
3293         This change caused mac-wk2 LayoutTests to exit early due to
3294         crashes.
3295
3296         Reverted changeset:
3297
3298         "Resource Load Statistics: Grandfather domains for existing
3299         data records"
3300         https://bugs.webkit.org/show_bug.cgi?id=172155
3301         http://trac.webkit.org/changeset/217014
3302
3303 2017-05-17  John Wilander  <wilander@apple.com>
3304
3305         Resource Load Statistics: Grandfather domains for existing data records
3306         https://bugs.webkit.org/show_bug.cgi?id=172155
3307         <rdar://problem/24913532>
3308
3309         Reviewed by Alex Christensen.
3310
3311         Adds test infrastructure needed for the added functionality.
3312
3313         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3314         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3315         (WTR::InjectedBundle::didReceiveMessageToPage):
3316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3317         (WTR::TestRunner::setStatisticsGrandfathered):
3318         (WTR::TestRunner::isStatisticsGrandfathered):
3319         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3320         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3321         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3323         * WebKitTestRunner/TestController.cpp:
3324         (WTR::TestController::setStatisticsGrandfathered):
3325         (WTR::TestController::isStatisticsGrandfathered):
3326         (WTR::TestController::setStatisticsGrandfatheringTime):
3327         * WebKitTestRunner/TestController.h:
3328         * WebKitTestRunner/TestInvocation.cpp:
3329         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3330
3331 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3332
3333         Fix ios-simulator API test after r216977
3334         https://bugs.webkit.org/show_bug.cgi?id=171987
3335
3336         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3337         (TEST):
3338         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
3339         not as urgent as having the rest of this working. Notably the ephemeral part of the
3340         test works, so something is just wrong with the persistent part.
3341
3342 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3343
3344         Unreviewed, rolling out r216955.
3345
3346         This change caused strange behavior with web-platform-tests
3347         locally and on EWS.
3348
3349         Reverted changeset:
3350
3351         "webkitpy: Start servers before setting-up for testing"
3352         https://bugs.webkit.org/show_bug.cgi?id=172176
3353         http://trac.webkit.org/changeset/216955
3354
3355 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3356
3357         A URL type is vended for a non-URL plain text string when starting data interaction
3358         https://bugs.webkit.org/show_bug.cgi?id=172228
3359         <rdar://problem/32166729>
3360
3361         Reviewed by Andy Estes.
3362
3363         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
3364         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
3365         still vended when beginning data interaction on something that resembles a link.
3366
3367         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3368
3369 2017-05-17  David Kilzer  <ddkilzer@apple.com>
3370
3371         BlobDataFileReference::generateReplacementFile() should use mkstemp()
3372         <https://webkit.org/b/172192>
3373
3374         Reviewed by Brent Fulgham.
3375
3376         * Scripts/webkitpy/style/checkers/cpp.py:
3377         (check_language): Add check for mktemp.
3378         (CppChecker): Add 'security/temp_file' category.
3379         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3380         (CppStyleTest.test_insecure_temp_file): Add test.
3381
3382 2017-05-17  Devin Rousso  <drousso@apple.com>
3383
3384         Unreviewed, change my email.
3385
3386         * Scripts/webkitpy/common/config/contributors.json:
3387
3388 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3389
3390         Unreviewed, rolling out r216974.
3391
3392         Revision caused consistent timeouts on all platforms.
3393
3394         Reverted changeset:
3395
3396         "Add a RuntimeEnabledFeature for display: contents, defaulted
3397         to false."
3398         https://bugs.webkit.org/show_bug.cgi?id=171984
3399         http://trac.webkit.org/changeset/216974
3400
3401 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3402
3403         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
3404         https://bugs.webkit.org/show_bug.cgi?id=171987
3405
3406         Reviewed by Brady Eidson.
3407
3408         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3409         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3410         (TEST):
3411
3412 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3413
3414         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3415         https://bugs.webkit.org/show_bug.cgi?id=171984
3416
3417         Reviewed by Antti Koivisto.
3418
3419         * DumpRenderTree/mac/DumpRenderTree.mm:
3420         (enableExperimentalFeatures):
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::TestController::resetPreferencesToConsistentValues):
3423
3424 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
3425
3426         Fix the build
3427
3428         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3429         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3430
3431 2017-05-16  Tim Horton  <timothy_horton@apple.com>
3432
3433         PageVisibilityStateWithWindowChanges tests sometimes time out
3434         https://bugs.webkit.org/show_bug.cgi?id=172202
3435         <rdar://problem/29653266>
3436
3437         Reviewed by Dean Jackson.
3438
3439         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3440         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3441         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
3442
3443 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
3444
3445         webkitpy: Start servers before setting-up for testing
3446         https://bugs.webkit.org/show_bug.cgi?id=172176
3447         <rdar://problem/32225538>
3448
3449         Reviewed by Alexey Proskuryakov.
3450
3451         On-device testing requires that servers are started before ports set-up their
3452         test environments.
3453
3454         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3455         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3456         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
3457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3458         (Manager.__init__): Delay construction of the test runner until we can determine
3459         if servers need to be started.
3460         (Manager.run): Determine if servers need to be started and construct the test runner.
3461         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3462
3463 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
3464
3465         Unreviewed, adding myself to contributors.json
3466
3467         * Scripts/webkitpy/common/config/contributors.json:
3468
3469 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
3470
3471         [GTK] Tests that always pass when run alone, but fail in the bots
3472         https://bugs.webkit.org/show_bug.cgi?id=168572
3473
3474         Reviewed by Michael Catanzaro.
3475
3476         PlatformWebView::viewSupportsOptions() is basically a comparison
3477         that checks that the passed options are the ones supported by the
3478         web view. There is no reason for them to be implemented for each
3479         platform differently. In fact doing so causes issues each time a
3480         new option is added, if the corresponding platform implementation
3481         is not updated accordingly.
3482
3483         A consequence of not updating the viewSupportOptions()
3484         implementations when new options are added is that tests that need
3485         these options might fail if they are executed after a test that
3486         didn't need the option, as the webview will be reused even if the
3487         option is not supported. This cannot be spotted when running the
3488         tests individually. See bug #165133 for other example of the same
3489         problem.
3490
3491         Remove the platform implementations and make the comparison a
3492         method of the TestOptions structure, so that the check is in one
3493         place. For the time being, only include in the comparison the
3494         options that were checked in the mac platform, which seem to be
3495         the only ones relevant this far (unless newer ones have also been
3496         forgotten).
3497
3498         * WebKitTestRunner/PlatformWebView.h:
3499         (WTR::PlatformWebView::viewSupportsOptions): Use the method
3500         defined below.
3501         * WebKitTestRunner/TestOptions.h:
3502         (WTR::TestOptions::hasSameInitializationOptions): Added.
3503         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3504         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3505         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3506         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3507         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3508         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3509         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3510         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3511
3512 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
3513
3514         [JSC] Build testapi in non Apple ports
3515         https://bugs.webkit.org/show_bug.cgi?id=172103
3516
3517         Reviewed by Filip Pizlo.
3518
3519         Now testapi is drived in JSCOnly, GTK and WPE ports too.
3520
3521         * Scripts/build-jsc:
3522         * Scripts/run-javascriptcore-tests:
3523
3524 2017-05-15  Youenn Fablet  <youenn@apple.com>
3525
3526         WPT test importer should not account for slow manual tests
3527         https://bugs.webkit.org/show_bug.cgi?id=172127
3528
3529         Reviewed by Ryosuke Niwa.
3530
3531         Making sure manual tests are not triggering updating tests-options.json file.
3532
3533         * Scripts/webkitpy/w3c/test_importer.py:
3534         (TestImporter.find_importable_tests):
3535         (TestImporter._already_identified_as_resource_file):
3536         (TestImporter.update_tests_options):
3537         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3538         (test_manual_slow_test):
3539
3540 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
3541
3542         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
3543         https://bugs.webkit.org/show_bug.cgi?id=172142
3544
3545         Reviewed by Tim Horton.
3546
3547         * Scripts/webkitpy/xcode/simulator.py:
3548         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
3549         around runtime identifiers.
3550         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
3551
3552 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3553
3554         Update ARES-6 plan file to use the latest version
3555         https://bugs.webkit.org/show_bug.cgi?id=172139
3556
3557         Reviewed by Keith Miller.
3558
3559         Include r216538.
3560
3561         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3562
3563 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
3564
3565         Disable Picture In Picture API tests on unsupported platforms.
3566         https://bugs.webkit.org/show_bug.cgi?id=172125
3567         rdar://problem/32199477
3568
3569         Reviewed by Simon Fraser.
3570
3571         The callbacks and allowing picture-in-picture require new SPI.
3572
3573         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3574
3575 2017-05-15  Brady Eidson  <beidson@apple.com>
3576
3577         [ios-simulator] API test WKWebView.ClearAppCache is failing.
3578         https://bugs.webkit.org/show_bug.cgi?id=172120
3579
3580         Unreviewed test gardening.
3581
3582         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3583         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
3584           Restoring that code fixes this.
3585
3586 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
3587
3588         Null deref under WebContentReader::readURL when interacting with a file URL
3589         https://bugs.webkit.org/show_bug.cgi?id=172045
3590         <rdar://problem/25880647>
3591
3592         Reviewed by Wenson Hsieh.
3593
3594         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3595         (TestWebKitAPI::TEST):
3596         The text of the file URL is pasted because a textual version of it gets
3597         onto the pasteboard. However, this test would have crashed before. Also
3598         tests that we don't make an <a>.
3599
3600 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3601
3602         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3603         https://bugs.webkit.org/show_bug.cgi?id=172071
3604
3605         Reviewed by Alexey Proskuryakov.
3606
3607         * DumpRenderTree/win/DumpRenderTree.cpp:
3608         (resetWebPreferencesToConsistentValues):
3609
3610 2017-05-14  Chris Dumez  <cdumez@apple.com>
3611
3612         Drop PassRefPtr class from WTF
3613         https://bugs.webkit.org/show_bug.cgi?id=172091
3614
3615         Reviewed by Alex Christensen.
3616
3617         Drop API test coverage.
3618
3619         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3620         (TestWebKitAPI::TEST):
3621         (TestWebKitAPI::passWithPassRefPtr): Deleted.
3622
3623 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
3624
3625         [MediaStream] deviceId constraint doesn't work with getUserMedia
3626         https://bugs.webkit.org/show_bug.cgi?id=171877
3627         <rdar://problem/31899730>
3628
3629         Reviewed by Jer Noble.
3630
3631         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
3632         implement the "checkUserMediaPermission" callback.
3633         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3634         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3635         (TestWebKitAPI::checkUserMediaPermissionCallback):
3636         (TestWebKitAPI::TEST):
3637
3638         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
3639         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3640
3641 2017-05-13  Chris Dumez  <cdumez@apple.com>
3642
3643         Stop using RefPtr::release()
3644         https://bugs.webkit.org/show_bug.cgi?id=172074
3645
3646         Reviewed by Geoffrey Garen.
3647
3648         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3649         (TestWebKitAPI::TEST):
3650
3651 2017-05-13  Commit Queue  <commit-queue@webkit.org>
3652
3653         Unreviewed, rolling out r216808.
3654         https://bugs.webkit.org/show_bug.cgi?id=172075
3655
3656         caused lldb to hang when debugging (Requested by smfr on
3657         #webkit).
3658
3659         Reverted changeset:
3660
3661         "Use Mach exceptions instead of signals where possible"
3662         https://bugs.webkit.org/show_bug.cgi?id=171865
3663         http://trac.webkit.org/changeset/216808
3664
3665 2017-05-12  Alex Christensen  <achristensen@webkit.org>
3666
3667         Rename WKContentExtension to WKContentRuleList
3668         https://bugs.webkit.org/show_bug.cgi?id=172053
3669         <rdar://problem/32141005>
3670
3671         Reviewed by Geoffrey Garen.
3672
3673         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
3674         (WKContentRuleListStoreTest::SetUp):
3675         (TEST_F):
3676         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3677         (WKContentExtensionStoreTest::SetUp): Deleted.
3678         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3679
3680 2017-05-12  Keith Miller  <keith_miller@apple.com>
3681
3682         Use Mach exceptions instead of signals where possible
3683         https://bugs.webkit.org/show_bug.cgi?id=171865
3684
3685         Reviewed by Mark Lam.
3686
3687         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3688         (runThreadMessageTest):
3689         (TEST):
3690
3691 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3692
3693         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
3694         https://bugs.webkit.org/show_bug.cgi?id=172048
3695         rdar://problem/32163054
3696
3697         Reviewed by Simon Fraser.
3698
3699         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
3700
3701         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
3702         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3703         (hasVideoInPictureInPictureDidChange):
3704         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
3705         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
3706         (TestWebKitAPI::TEST):
3707
3708 2017-05-12  Brady Eidson  <beidson@apple.com>
3709
3710         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3711         https://bugs.webkit.org/show_bug.cgi?id=172030
3712
3713         Unreviewed - Test gardening
3714
3715         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
3716         before the test starts.
3717
3718         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3719         (defaultWebsiteCacheDirectory):
3720         (defaultApplicationCacheDirectory):
3721         (TEST):
3722         (defaultWebsiteDataDirectory): Deleted.
3723
3724 2017-05-12  David Quesada  <david_quesada@apple.com>
3725
3726         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
3727         https://bugs.webkit.org/show_bug.cgi?id=172000
3728         rdar://problem/32144756
3729
3730         Reviewed by Simon Fraser.
3731
3732         Added API tests to verify that WKWebView provides the expected value for
3733         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
3734         inside a scrollview but not clipped, clipped by an ancestor scrollview,
3735         clipped by the webview's _enclosingViewForExposedRectComputation)
3736
3737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3738         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
3739         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
3740         (TestWebKitAPI::TEST):
3741
3742 2017-05-12  Brady Eidson  <beidson@apple.com>
3743
3744         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3745         https://bugs.webkit.org/show_bug.cgi?id=172030
3746
3747         Unreviewed - Test gardening, in effect...
3748
3749         More exploration as to why this continues to fail on the bots.
3750         
3751         This change should give us a smoking gun.
3752         
3753         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3754         (TEST):
3755
3756 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3757
3758         [GTK] Fix compile warnings in PlatformImageCairo.cpp
3759         https://bugs.webkit.org/show_bug.cgi?id=171850
3760
3761         Reviewed by Michael Catanzaro.
3762
3763         * ImageDiff/cairo/PlatformImageCairo.cpp:
3764         (ImageDiff::PlatformImage::createFromStdin):
3765         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3766
3767 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3768
3769         Add UIClient callback for when picture-in-picture is activated.
3770         https://bugs.webkit.org/show_bug.cgi?id=172023
3771
3772         Reviewed by Simon Fraser.
3773
3774         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
3775
3776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3777         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
3778         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
3779         (onLoadedCompletedCallback):
3780         (waitUntilOnLoadIsCompleted):
3781         (didFinishLoadForFrame):
3782         (setHasVideoInPictureInPicture):
3783         (TestWebKitAPI::TEST):
3784
3785 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3786
3787         Unreviewed follow-up to r216776.
3788
3789         * Scripts/webkitpy/port/base.py:
3790         (Port.path_to_crash_logs): Raise not implemented.
3791         * Scripts/webkitpy/port/test.py:
3792         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
3793         * Scripts/webkitpy/port/win.py:
3794         (WinPort.path_to_crash_logs): Ditto.
3795
3796 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
3797
3798         Bot watcher's dashboard shows results links twice sometimes
3799         https://bugs.webkit.org/show_bug.cgi?id=172043
3800
3801         Reviewed by Tim Horton.
3802
3803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3804         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3805
3806 2017-05-12  Brady Eidson  <beidson@apple.com>
3807
3808         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3809         https://bugs.webkit.org/show_bug.cgi?id=172030
3810
3811         Unreviewed - Test gardening, in effect...
3812
3813         This failure is only being seen by the bots.
3814         
3815         I believe this test is utterly broken in the first place; when it checks the .wal file's
3816         size that is not actually an indicator that the records were deleted.
3817         
3818         But that isn't what's coming up as failure on the bots.
3819         
3820         This patch is an attempt to:
3821         1 - More forcefully clear the Website data directory of leftovers before the test starts.
3822         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
3823
3824         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3825         (defaultWebsiteDataDirectory):
3826         (defaultApplicationCacheDirectory):
3827         (TEST):
3828
3829 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3830
3831         webkitpy: Pass directory with crash logs into CrashLogs
3832         https://bugs.webkit.org/show_bug.cgi?id=172033
3833         <rdar://problem/32157616>
3834
3835         Reviewed by Daniel Bates.
3836
3837         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
3838         the location of crash logs.
3839
3840         * Scripts/webkitpy/common/system/crashlogs.py:
3841         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
3842         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
3843         generating one.
3844         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
3845         self._results_directory.
3846         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
3847         generating one.
3848         (CrashLogs._log_directory_darwin): Moved to port.
3849         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
3850         to the crash log is no longer owned by CrashLogs.
3851         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
3852         directory for uploading crash logs. Note that crash logs are only supported on Mac
3853         and Windows.
3854         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
3855         * Scripts/webkitpy/port/base.py:
3856         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
3857         to be in the results directory.
3858         * Scripts/webkitpy/port/darwin.py:
3859         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
3860         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
3861         (DarwinPort._get_crash_log): Ditto.
3862         * Scripts/webkitpy/port/darwin_testcase.py:
3863         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
3864         the path to crash logs.
3865         * Scripts/webkitpy/port/ios_device.py:
3866         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
3867         * Scripts/webkitpy/port/ios_device_unittest.py:
3868         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
3869         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
3870         * Scripts/webkitpy/port/mac.py: Ditto.
3871         * Scripts/webkitpy/port/test.py:
3872         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
3873         * Scripts/webkitpy/port/win.py:
3874         (WinPort._get_crash_log): Ditto.
3875         * Scripts/webkitpy/tool/commands/queries.py:
3876         (execute): Construct a port object since this is the object which owns the path to crash logs.
3877
3878 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3879
3880         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
3881
3882         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
3883         URL parameter using the default value "about:blank" when not provided.
3884
3885         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3886         (testWebViewCreateNavigationData):
3887
3888 2017-05-11  Youenn Fablet  <youenn@apple.com>
3889
3890         Allow WPT server to serve specific WebKit test
3891         https://bugs.webkit.org/show_bug.cgi?id=171479
3892
3893         Reviewed by Ryosuke Niwa.
3894
3895         Adding a new mount point to WPT server.
3896         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
3897
3898         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
3899
3900         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3901         (Manager.__init__):
3902         (Manager._is_http_test):
3903         (Manager._needs_web_platform_test):
3904         (Manager._run_tests):
3905         (Manager._is_web_platform_test): Deleted.
3906         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3907         (build_routes):
3908         (main):
3909         * Scripts/webkitpy/port/driver.py:
3910         (Driver):
3911         (Driver.is_webkit_specific_web_platform_test):
3912         (Driver.test_to_uri):
3913         (Driver._command_from_driver_input):
3914
3915 2017-05-11  Brady Eidson  <beidson@apple.com>
3916
3917         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
3918         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
3919
3920         Reviewed by Andy Estes.
3921         Informal review by Maureen Daum.
3922
3923         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3924         (TEST):
3925
3926 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3927
3928         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
3929         https://bugs.webkit.org/show_bug.cgi?id=171989
3930
3931         Reviewed by Brian Burg.
3932
3933         * lldb/lldb_webkit.py:
3934         (WTFStringImplProvider.get_data8):
3935         (WTFStringImplProvider.get_data16):
3936         m_data8 and m_data16 are now part of the superclass StringImplShape
3937         instead of directly in StringImpl. So first get the shape by getting
3938         index 0, and the data properties are the same offset within that.
3939
3940 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3941
3942         Remove Vibration API
3943         https://bugs.webkit.org/show_bug.cgi?id=171766
3944
3945         Rubber-stamped by Alexey Proskuryakov.
3946
3947         * Scripts/webkitperl/FeatureList.pm:
3948
3949 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3950
3951         Add WPE release bots
3952         https://bugs.webkit.org/show_bug.cgi?id=171973
3953
3954         Reviewed by Žan Doberšek.
3955
3956         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
3957         It also adds a new WPE buildbot category.
3958
3959         * BuildSlaveSupport/build.webkit.org-config/config.json:
3960         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3961         (InstallWpeDependencies):
3962         (appendCustomBuildFlags):
3963         (Factory.__init__):
3964         (loadBuilderConfig):
3965         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3966         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3967
3968 2017-05-09  Sam Weinig  <sam@webkit.org>
3969
3970         Remove support for legacy Notifications
3971         https://bugs.webkit.org/show_bug.cgi?id=171487
3972
3973         Reviewed by Jon Lee.
3974
3975         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3976         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3977         * Scripts/webkitperl/FeatureList.pm:
3978         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3979         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
3980
3981 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3982
3983         Remove user agent quirk for Slack
3984         https://bugs.webkit.org/show_bug.cgi?id=171869
3985
3986         Reviewed by Carlos Garcia Campos.
3987
3988         Remove the corresponding test.
3989
3990         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3991         (TestWebKitAPI::TEST):
3992
3993 2017-05-10  Commit Queue  <commit-queue@webkit.org>
3994
3995         Unreviewed, rolling out r216578.
3996         https://bugs.webkit.org/show_bug.cgi?id=171920
3997
3998         Broke the GTK+ build with Wayland enabled (Requested by KaL on
3999         #webkit).
4000
4001         Reverted changeset:
4002
4003         "[GTK] Bump GTK+ and its dependencies in jhbuild"
4004         https://bugs.webkit.org/show_bug.cgi?id=171918
4005         http://trac.webkit.org/changeset/216578
4006
4007 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
4008
4009         [GTK] Bump GTK+ and its dependencies in jhbuild
4010         https://bugs.webkit.org/show_bug.cgi?id=171918
4011
4012         Reviewed by Carlos Alberto Lopez Perez.
4013
4014         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4015         (WTR::initializeGtkSettings):
4016         * gtk/jhbuild.modules:
4017         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
4018         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
4019
4020 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
4021
4022         [Win] Set CMake args in build-webkit
4023         https://bugs.webkit.org/show_bug.cgi?id=171436
4024
4025         Reviewed by Per Arne Vollan.
4026
4027         * Scripts/build-webkit:
4028
4029 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
4030
4031         ImageDiff: Add CG implementation for new ImageDiff
4032         https://bugs.webkit.org/show_bug.cgi?id=170608
4033
4034         Reviewed Alex Christensen.
4035
4036         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4037         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
4038         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
4039         * ImageDiff/CMakeLists.txt:
4040         * ImageDiff/Cairo.cmake:
4041         * ImageDiff/ImageDiff.cpp:
4042         (main):
4043         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4044         * ImageDiff/PlatformImage.cpp:
4045         * ImageDiff/PlatformImage.h:
4046         * ImageDiff/cairo/PlatformImageCairo.cpp:
4047         * ImageDiff/cg/ImageDiff.cpp: Removed.
4048         * ImageDiff/cg/PlatformImageCG.cpp: Added.
4049         (ImageDiff::PlatformImage::createFromStdin):
4050         (ImageDiff::PlatformImage::createFromDiffData):
4051         (ImageDiff::PlatformImage::PlatformImage):
4052         (ImageDiff::PlatformImage::~PlatformImage):
4053         (ImageDiff::PlatformImage::width):
4054         (ImageDiff::PlatformImage::height):
4055         (ImageDiff::PlatformImage::rowBytes):
4056         (ImageDiff::PlatformImage::hasAlpha):
4057         (ImageDiff::PlatformImage::pixels):
4058         (ImageDiff::PlatformImage::writeAsPNGToStdout):
4059
4060 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
4061
4062         Enable FTL JIT by default on AArch64
4063         https://bugs.webkit.org/show_bug.cgi?id=144039
4064
4065         Reviewed by Yusuke Suzuki.
4066
4067         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
4068         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
4069         as an unsupported FTL platform.
4070         * Scripts/webkitdirs.pm:
4071         (isARM64): Returns 1 if the determined architecture is 'arm64'.
4072         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
4073
4074 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
4075
4076         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
4077         https://bugs.webkit.org/show_bug.cgi?id=170857
4078         <rdar://problem/31635373>
4079
4080         Reviewed by Aakash Jain.
4081
4082         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
4083         code to search for crash logs.
4084
4085         * Scripts/webkitpy/port/darwin.py:
4086         (DarwinPort._get_crash_log): Moved from MacPort.
4087         * Scripts/webkitpy/port/darwin_testcase.py:
4088         (DarwinTest.test_get_crash_log): Moved from MacTest.
4089         * Scripts/webkitpy/port/ios_device.py:
4090         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
4091         devices must search for crash-logs remotely.
4092         * Scripts/webkitpy/port/ios_simulator.py:
4093         (IOSSimulatorPort._get_crash_log): Deleted.
4094         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4095         (IOSSimulatorTest.test_get_crash_log): Deleted.
4096         * Scripts/webkitpy/port/mac.py:
4097         (MacPort._get_crash_log): Moved to DarwinPort
4098         * Scripts/webkitpy/port/mac_unittest.py:
4099         (MacTest.test_get_crash_log): Moved to DarwinTest.
4100
4101 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
4102
4103         build ImageDiff with host SDK from Make
4104         https://bugs.webkit.org/show_bug.cgi?id=171835
4105
4106         Reviewed by Alexey Proskuryakov.
4107
4108         ImageDiff should be built for the default SDK and default architecture when
4109         the SDKROOT is set to either iOS device or iOS simulator. Check the
4110         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
4111
4112         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
4113         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
4114
4115 2017-05-09  Matt Lewis  <jlewis3@apple.com>
4116
4117         Unreviewed, adding myself to contributors.json
4118
4119         * Scripts/webkitpy/common/config/contributors.json:
4120
4121 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
4122
4123         REGRESSION: ImageDiff not building with make
4124         https://bugs.webkit.org/show_bug.cgi?id=171788
4125
4126         Reviewed by Alex Christensen.
4127
4128         * Makefile: Build ImageDiff for all platforms.
4129
4130 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4131
4132         [Win] ImageDiff isn't built since Bug 168945
4133         https://bugs.webkit.org/show_bug.cgi?id=171847
4134
4135         Reviewed by Alex Christensen.
4136
4137         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
4138         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
4139         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
4140
4141 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
4142
4143         Upstream the WPE port
4144         https://bugs.webkit.org/show_bug.cgi?id=171110
4145
4146         Reviewed by Alex Christensen.
4147
4148         webkit-dev thread:
4149         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
4150
4151         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
4152         In-file changes removed from this ChangeLog entry for brevity.
4153
4154         * BuildSlaveSupport/built-product-archive:
4155         * BuildSlaveSupport/test-result-archive:
4156         * CMakeLists.txt:
4157         * ImageDiff/PlatformWPE.cmake: Added.
4158         * Scripts/build-dumprendertree:
4159         * Scripts/build-webkit:
4160         * Scripts/build-webkittestrunner:
4161         * Scripts/update-webkit-libs-jhbuild:
4162         * Scripts/update-webkitwpe-libs: Added.
4163         * Scripts/webkitdirs.pm:
4164         * Scripts/webkitperl/FeatureList.pm:
4165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4166         * Scripts/webkitpy/port/factory.py:
4167         * Scripts/webkitpy/port/wpe.py: Added.
4168         * TestWebKitAPI/PlatformWPE.cmake: Added.
4169         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
4170         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
4171         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
4172         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4173         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4174         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4175         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4177         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4178         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
4179         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
4180         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
4181         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
4182         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
4183         * WebKitTestRunner/PlatformWPE.cmake: Added.
4184         * WebKitTestRunner/PlatformWebView.h:
4185         * WebKitTestRunner/TestController.cpp:
4186         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
4187         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
4188         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
4189         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
4190         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
4191         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
4192         * jhbuild/jhbuild-wrapper:
4193         * wpe/generate-inspector-gresource-manifest.py: Added.
4194         * wpe/jhbuild.modules: Added.
4195         * wpe/jhbuildrc: Added.
4196         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
4197         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
4198         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
4199         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
4200         * wpe/patches/glib-warning-fix.patch: Added.
4201         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4202         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4203         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
4204         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
4205         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
4206
4207 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
4208
4209         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
4210         https://bugs.webkit.org/show_bug.cgi?id=169421
4211         <rdar://problem/30950171>
4212
4213         Reviewed by Tim Horton.
4214
4215         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4216         (createBitmapContextFromWebView): Implement for IOSurface.
4217         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4218         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
4219
4220 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
4221
4222         buildbot: Cleanup simulators after running tests
4223         https://bugs.webkit.org/show_bug.cgi?id=171679
4224
4225         Reviewed by Aakash Jain.
4226
4227         simctl is partitioned for each user. Since kill-old-processes
4228         is run as root, we need to specify the buildbot user when tearing
4229         down simulators between steps.
4230
4231         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4232         (KillOldProcesses): Pass buildbot user to kill-old-processes.
4233         * BuildSlaveSupport/kill-old-processes:
4234         (main): Specify the user for simctl if one has been provided.
4235
4236 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4237
4238         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
4239         https://bugs.webkit.org/show_bug.cgi?id=171681
4240
4241         Reviewed by Carlos Garcia Campos.
4242
4243         * gtk/install-dependencies:
4244
4245 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4246
4247         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
4248
4249         Glib uses now Unicode quotes in error messages.
4250
4251         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
4252         (testWebKitConsoleMessageNetworkError):
4253
4254 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4255
4256         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
4257
4258         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
4259         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send