Fix failure from r212579.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
2
3         Fix failure from r212579.
4
5         Unreviewed build-fix.
6
7         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
8         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
9
10 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
11
12         EWS should run JavaScriptCore tests
13         https://bugs.webkit.org/show_bug.cgi?id=162458
14
15         Reviewed by Alexey Proskuryakov.
16
17         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
18         * QueueStatusServer/model/queuestatus.py:
19         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
20         * QueueStatusServer/handlers/statusbubble.py:
21         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
22         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
23         (MockSCM.__init__): Add _mockChangedFiles variable.
24         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
25         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
26         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
27         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
28         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
29         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
30         (MacPort.run_webkit_tests_command): Check for JSC.
31         * Scripts/webkitpy/common/config/ports_mock.py:
32         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
33         * Scripts/webkitpy/common/config/ports_unittest.py:
34         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
35         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
36         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
37         (AbstractTestResults.test_results): Stub.
38         (AbstractTestResults.failing_tests): Stub.
39         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
40         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
41         (JSCTestResults): Added.
42         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
43         (JSCTestResults.results_from_string): Use json library to parse results.
44         (JSCTestResults.__init__): Initialize members.
45         (JSCTestResults.equals): This enables unit testing.
46         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
47         (JSCTestResults.all_passed): Getter.
48         (JSCTestResults.failing_tests): Getter.
49         (JSCTestResults.did_exceed_test_failure_limit): Getter.
50         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
51         (JSCTestResultsTest): Class to test JSCTestResults.
52         (JSCTestResultsTest.test_results_from_string): Tests parsing.
53         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
54         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
55         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
56         * Scripts/webkitpy/port/base.py:
57         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
58         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
59         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
60         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
61         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
62         (MockPatchAnalysisTask.__init__): Sets attributes.
63         (MockPatchAnalysisTask._test): Override to not run command.
64         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
65         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
66         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
67         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
68         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
69         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
70         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
71         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
72         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
73         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
74         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
75         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
76         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
77         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
78         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
79         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
80         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
81         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
82         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
83         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
84         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
85         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
86         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
87         (JSCTestResultsReader): Reads results file.
88         (JSCTestResultsReader.__init__): Sets attributes.
89         (JSCTestResultsReader._read_file_contents): Reads file.
90         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
91         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
92         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
93         (PatchAnalysisTask._check_patch_relevance): Added.
94         (PatchAnalysisTask._build): Check for JSC.
95         (PatchAnalysisTask._build_without_patch): Check for JSC.
96         (PatchAnalysisTask._test): Check for JSC.
97         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
98         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
99         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
100         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
101         * Scripts/webkitpy/tool/commands/download.py:
102         (CheckPatchRelevance): Add check-patch-relevance command.
103         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
104         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
105         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
106         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
107         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
108         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
109         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
110         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
111         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
112         (TestEWS): Sample layout test EWS class used for unit testing.
113         (TestJSCEWS): Sample JSC EWS class used for unit testing.
114         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
115         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
116         (AbstractEarlyWarningSystemTest): Add _group variable.
117         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
118         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
119         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
120         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
121         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
122         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
123         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
124         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
125         * Scripts/webkitpy/tool/steps/build.py:
126         (Build.options): Check for JSC.
127         (Build.build): Check for JSC.
128         (Build.run): Check for JSC.
129         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
130         (CheckPatchRelevance): Added.
131         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
132         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
133         * Scripts/webkitpy/tool/steps/options.py:
134         (Options): Add --group command line option.
135         * Scripts/webkitpy/tool/steps/runtests.py:
136         (RunTests.options): Add group.
137         (RunTests.run): Check for JSC.
138         (RunTests._run_webkit_tests): Check for JSC.
139         (RunTests): Add _group attribute.
140         (RunTests._run_javascriptcore_tests): New.
141         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
142
143 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
144
145         Fix tools that were broken by Efl removal
146         https://bugs.webkit.org/show_bug.cgi?id=168496
147
148         Reviewed by Alexey Proskuryakov.
149
150         * QueueStatusServer/config/queues.py:
151         * Scripts/webkitpy/common/config/ews.json:
152         * TestResultServer/static-dashboards/builders.jsonp:
153         * TestResultServer/static-dashboards/flakiness_dashboard.js:
154         * TestResultServer/static-dashboards/loader_unittests.js:
155
156 2017-02-16  Lucas Forschler  <lforschler@apple.com>
157
158         https://bugs.webkit.org/show_bug.cgi?id=168442
159         Move the SVN checkout from http -> https.
160         Update unit tests.
161
162         Reviewed by Alexey Proskuryakov.
163
164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
165         (CheckOutSource.__init__):
166         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
167         (SVNMirrorTest.get_SVNMirrorFromConfig):
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
169
170 2017-02-16  Commit Queue  <commit-queue@webkit.org>
171
172         Unreviewed, rolling out r212514.
173         https://bugs.webkit.org/show_bug.cgi?id=168489
174
175         broke test runner (Requested by alexchristensen on #webkit).
176
177         Reverted changeset:
178
179         "Remove EFL-specific files in Tools."
180         http://trac.webkit.org/changeset/212514
181
182 2017-02-16  Alex Christensen  <achristensen@webkit.org>
183
184         Remove EFL-specific files in Tools.
185
186         Rubber-stamped by Anders Carlsson.
187
188         * ImageDiff/efl: Removed.
189         * ImageDiff/efl/ImageDiff.cpp: Removed.
190         * MiniBrowser/efl: Removed.
191         * MiniBrowser/efl/CMakeLists.txt: Removed.
192         * MiniBrowser/efl/main.c: Removed.
193         * Scripts/run-efl-tests: Removed.
194         * Scripts/update-webkitefl-libs: Removed.
195         * Scripts/webkitpy/port/efl.py: Removed.
196         * Scripts/webkitpy/port/efl_unittest.py: Removed.
197         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
198         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
199         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
200         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
201         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
202         * TestWebKitAPI/efl: Removed.
203         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
204         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
205         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
206         * TestWebKitAPI/efl/main.cpp: Removed.
207         * WebKitTestRunner/InjectedBundle/efl: Removed.
208         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
209         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
210         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
211         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
212         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
213         * WebKitTestRunner/efl: Removed.
214         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
215         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
216         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
217         * WebKitTestRunner/efl/main.cpp: Removed.
218         * efl: Removed.
219         * efl/install-dependencies: Removed.
220         * efl/jhbuild-optional.modules: Removed.
221         * efl/jhbuild.modules: Removed.
222         * efl/jhbuildrc: Removed.
223         * efl/patches: Removed.
224         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
225         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
226         * efl/patches/gst-libav.patch: Removed.
227         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
228         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
229         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
230         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
231
232 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
233
234         font-weight in @font-face can cause a font to be downloaded even when it's not used
235         https://bugs.webkit.org/show_bug.cgi?id=168114
236         <rdar://problem/30301317>
237
238         Reviewed by Darin Adler.
239
240         LastResort needs to be usable in tests.
241
242         * DumpRenderTree/mac/DumpRenderTree.mm:
243         (allowedFontFamilySet):
244         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
245         (WTR::allowedFontFamilySet):
246         * WebKitTestRunner/mac/TestControllerMac.mm:
247         (WTR::allowedFontFamilySet):
248
249 2017-02-16  Alex Christensen  <achristensen@webkit.org>
250
251         Remove old URL parser
252         https://bugs.webkit.org/show_bug.cgi?id=168483
253
254         Reviewed by Tim Horton.
255
256         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
257         (TestWebKitAPI::checkURL):
258         (TestWebKitAPI::checkRelativeURL):
259         (TestWebKitAPI::checkURLDifferences):
260         (TestWebKitAPI::checkRelativeURLDifferences):
261
262 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
263
264         [WK2] Add additional test infrastructure and unit tests for data interaction
265         https://bugs.webkit.org/show_bug.cgi?id=168439
266         <rdar://problem/30557942>
267
268         Reviewed by Tim Horton.
269
270         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
271         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
272         support data interaction from  See per-method descriptions below for more details.
273
274         * Configurations/TestWebKitAPI.xcconfig:
275
276         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
277
278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
279
280         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
281         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
282
283         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
284         (-[TestWKWebView editorContainsImageElement]):
285         (-[TestWKWebView editorValue]):
286
287         New helper methods for querying information from the "editor" element in a test page.
288
289         (TestWebKitAPI::TEST):
290         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
291
292         Moves logic for capturing events during a simulated data interaction run from the test file to
293         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
294
295         * TestWebKitAPI/cocoa/TestWKWebView.h:
296         * TestWebKitAPI/cocoa/TestWKWebView.mm:
297         (-[TestMessageHandler removeMessage:]):
298         (-[TestWKWebView clearMessageHandlers:]):
299
300         Add the ability to clear message handlers from the TestWKWebView.
301
302         * TestWebKitAPI/ios/DataInteractionSimulator.h:
303         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
304         (dataInteractionEventNames):
305         (-[DataInteractionSimulator initWithWebView:]):
306         (-[DataInteractionSimulator _resetSimulatedState]):
307
308         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
309         simulating data interaction.
310
311         (-[DataInteractionSimulator observedEventNames]):
312
313         Returns a list of the names of events relevant to data interaction that were observed over the course of the
314         most recent run.
315
316         (-[DataInteractionSimulator runFrom:to:]):
317
318         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
319         to run the same data interaction for multiple simulated gestures.
320
321         (-[DataInteractionSimulator _advanceProgress]):
322         (-[DataInteractionSimulator _finishDataInteraction]):
323         (-[DataInteractionSimulator externalItemProvider]):
324         (-[DataInteractionSimulator setExternalItemProvider:]):
325
326         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
327         phase of a test run.
328
329         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
330         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
331         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
332         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
333
334         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
335         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
336         wherein the the web process might take longer than usual to process the request to start data interaction, and
337         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
338         the web process is received, which then causes no simulated delegate methods to be fired.
339
340         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
341         (-[DataInteractionSimulator run]): Deleted.
342
343 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
344
345         Remove unused test pages in TestWebKitAPI
346         https://bugs.webkit.org/show_bug.cgi?id=168462
347
348         Reviewed by Anders Carlsson.
349
350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
351         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
352         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
353         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
354         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
355         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
356
357 2017-02-16  Alex Christensen  <achristensen@webkit.org>
358
359         Special URLs without a host are invalid
360         https://bugs.webkit.org/show_bug.cgi?id=168461
361
362         Reviewed by Tim Horton.
363
364         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
365         (TestWebKitAPI::TEST_F):
366
367 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
368
369         The collector thread should only start when the mutator doesn't have heap access
370         https://bugs.webkit.org/show_bug.cgi?id=167737
371
372         Reviewed by Keith Miller.
373         
374         Make more tests collect continuously.
375
376         * Scripts/run-jsc-stress-tests:
377
378 2017-02-16  Tim Horton  <timothy_horton@apple.com>
379
380         WKWebView inside a UICollectionView flashes when items are inserted above it
381         https://bugs.webkit.org/show_bug.cgi?id=168376
382         <rdar://problem/29322051>
383
384         Reviewed by Simon Fraser.
385
386         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
387         (-[TestRunnerWKWebView _setStableStateOverride:]):
388         Update the one external caller of this internal method...
389
390         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
391         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
392         * DumpRenderTree/mac/UIScriptControllerMac.mm:
393         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
394         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
395         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
396         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
397         * TestRunnerShared/UIScriptContext/UIScriptController.h:
398         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
399         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
400         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
401         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
402         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
403         back after we dispatch a visible content rect update from the UI process
404         to the Web Content process, so any messages sent from the block will arrive
405         after the visible content rect update.
406
407 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
408
409         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
410         https://bugs.webkit.org/show_bug.cgi?id=168321
411
412         This bots should be added to the trunk build scheduler.
413         Unreviewed fix after r212429.
414
415         * BuildSlaveSupport/build.webkit.org-config/config.json:
416
417 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
418
419         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
420         https://bugs.webkit.org/show_bug.cgi?id=168321
421
422         Reviewed by Michael Catanzaro.
423
424         The additionalArgument --default-cmake-features is used both to
425         skip the JHBuild (InstallGtkDependencies) build step and to build
426         with the default features from the CMake config.
427
428         * BuildSlaveSupport/build.webkit.org-config/config.json:
429         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
430         (Factory.__init__):
431         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
432
433 2017-02-15  Lucas Forschler  <lforschler@apple.com>
434
435         https://bugs.webkit.org/show_bug.cgi?id=168386
436         Remove EFL from build.webkit.org
437
438         Reviewed by Alex Christensen
439
440         * BuildSlaveSupport/build.webkit.org-config/config.json:
441         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
442         (DeleteStaleBuildFiles.start):
443         (appendCustomBuildFlags):
444         (RunWebKitTests.start):
445         (RunBuiltinsTests):
446         (Factory.__init__):
447         (TestFactory.__init__):
448         (loadBuilderConfig):
449         (InstallEflDependencies): Deleted.
450         (RunEflAPITests): Deleted.
451         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
454         (BubbleQueueServer):
455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
457         (Analyzer.prototype._triggeringQueue):
458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
459         (WebKitBuildbot):
460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
461         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
462         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
463         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
464         (_should_file_trigger_build):
465
466 2017-02-15  Alex Christensen  <achristensen@webkit.org>
467
468         Unreviewed, rolling out r212169.
469
470         Broke iOS WebInspector
471
472         Reverted changeset:
473
474         "WebInspector: refactor RemoteInspector to move cocoa specific
475         code to their own files"
476         https://bugs.webkit.org/show_bug.cgi?id=166681
477         http://trac.webkit.org/changeset/212169
478
479 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
480
481         webkitpy: Fix DarwinPort._get_crash_log()
482         https://bugs.webkit.org/show_bug.cgi?id=168372
483         <rdar://problem/30535156>
484
485         Reviewed by Daniel Bates.
486
487         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
488         DarwinPort should return the expected return value for _get_crash_log.
489
490         * Scripts/webkitpy/port/darwin.py:
491         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
492
493 2017-02-15  Chris Dumez  <cdumez@apple.com>
494
495         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
496         https://bugs.webkit.org/show_bug.cgi?id=168291
497         <rdar://problem/30508593>
498
499         Reviewed by Tim Horton.
500
501         Drop overridePreference() implementation in iOS's UIScriptController
502         as it was only used for the minimum font size setting and this setting
503         is not exposed on iOS.
504
505         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
506         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
507         (WTR::UIScriptController::overridePreference):
508         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
509
510 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
511
512         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
513         https://bugs.webkit.org/show_bug.cgi?id=168329
514         <rdar://problem/30518832>
515
516         Reviewed by Daniel Bates.
517
518         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
519         never change given the same input arguments.  Memoize function for efficiency.
520
521         * Scripts/webkitpy/port/darwin.py: Add memoized import.
522         (DarwinPort):
523         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
524         
525
526 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
527
528         webkitpy: Remove unused import from darwin.py
529         https://bugs.webkit.org/show_bug.cgi?id=168371
530
531         Reviewed by Alex Christensen.
532
533         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
534
535 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
536
537         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
538         https://bugs.webkit.org/show_bug.cgi?id=168364
539
540         Reviewed by Michael Catanzaro.
541
542         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
543         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
544         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
545
546         Fixes: http/tests/security/credentials-from-different-domains.html
547                http/tests/xmlhttprequest/cross-origin-no-authorization.html
548
549         * gtk/jhbuild.modules:
550         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
551         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
552
553 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
554
555         [GTK] Update cookie manager API to properly work with ephemeral sessions
556         https://bugs.webkit.org/show_bug.cgi?id=168230
557
558         Reviewed by Michael Catanzaro.
559
560         Update unit tests and add new cases for the new API.
561
562         * MiniBrowser/gtk/main.c:
563         (gotWebsiteDataCallback):
564         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
565         (testCookieManagerEphemeral):
566         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
567         (testWebContextEphemeral):
568         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
569         (testWebViewEphemeral):
570         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
571         (serverCallback):
572         (testWebsiteDataEphemeral):
573         (testWebsiteDataCookies):
574         (beforeAll):
575
576 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
577
578         [WK2] Support data interaction on links
579         https://bugs.webkit.org/show_bug.cgi?id=168331
580         <rdar://problem/30200837>
581
582         Reviewed by Tim Horton.
583
584         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
585         editable area results in the link URL being inserted.
586
587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
588         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
589         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
590         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
591         (TestWebKitAPI::TEST):
592
593 2017-02-14  Jason Rinn  <jrinn@apple.com>
594
595         Add a test for new WebKit Cocoa API, _getContentsAsString.
596         https://bugs.webkit.org/show_bug.cgi?id=168147
597         <rdar://problem/30502539>
598
599         Reviewed by Tim Horton.
600
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
603         (TEST):
604
605 2017-02-14  Matt Rajca  <mrajca@apple.com>
606
607         Website policies: iframes should respect the autoplay policy of the top-level document
608         https://bugs.webkit.org/show_bug.cgi?id=168333
609
610         Reviewed by Alex Christensen.
611
612         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
613         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
614         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
615         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
616         (TEST):
617
618 2017-02-14  Chris Dumez  <cdumez@apple.com>
619
620         HTML Form Validation bubble should take minimum font size setting into consideration
621         https://bugs.webkit.org/show_bug.cgi?id=168271
622         <rdar://problem/29869869>
623
624         Reviewed by Simon Fraser.
625
626         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
627         font size of the validation bubble.
628
629         Add an overridePreference() method to UIScriptController. This is currently
630         used to override the value of the minimumFontSize setting. testRunner's
631         overridePreference() is not usable on WK2 because it does not update the
632         value of the preference on the UIProcess side.
633
634         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
635         (WTR::UIScriptController::overridePreference):
636         * DumpRenderTree/mac/UIScriptControllerMac.mm:
637         (WTR::UIScriptController::overridePreference):
638         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
639         * TestRunnerShared/UIScriptContext/UIScriptController.h:
640         * WebKitTestRunner/TestController.cpp:
641         (WTR::TestController::resetPreferencesToConsistentValues):
642         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
643         (WTR::UIScriptController::overridePreference):
644         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
645         (WTR::UIScriptController::contentsOfUserInterfaceItem):
646         (WTR::UIScriptController::overridePreference):
647
648 2017-02-14  Florian Bruhin  <git@the-compiler.org>
649
650         Use a set instead of a list for tests when parsing expectations
651         https://bugs.webkit.org/show_bug.cgi?id=168304
652
653         In _collect_matching_tests, a lot of membership tests are done on a giant list
654         of strings. By making it a set instead, we can make those much faster, and
655         there's no reason for it to be a list.
656
657         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
658         to 3s on my machine.
659
660         Reviewed by Ryosuke Niwa.
661
662         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
663         (TestExpectationParser.__init__):
664         (TestExpectationParser._collect_matching_tests):
665
666 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
667
668         Unreviewed build-fix after r212297.
669
670         * Scripts/webkitpy/port/simulator_process.py:
671         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
672
673 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
674
675         [CMake] build-webkit should allow building with the default cmake configuration
676         https://bugs.webkit.org/show_bug.cgi?id=168323
677
678         Reviewed by Michael Catanzaro.
679
680         Add a --default-cmake-features switch that makes the script pass
681         no value for any of the features defined by build-webkit, that
682         way the default values from the port cmake config will be used.
683
684         * Scripts/build-webkit:
685         (cMakeArgsFromFeatures):
686
687 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
688
689         Unreviewed build-fix after r212297.
690
691         * Scripts/webkitpy/port/simulator_process.py:
692         (SimulatorProcess.stop): Handle case where there is no process to kill.
693
694 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
695
696         [CMake] build-webkit should print the cmake command executed
697         https://bugs.webkit.org/show_bug.cgi?id=168318
698
699         Reviewed by Michael Catanzaro.
700
701         Run the cmake commands to configure or start the build through
702         a wrapper that prints the command before executing it.
703
704         * Scripts/webkitdirs.pm:
705         (systemVerbose):
706         (generateBuildSystemFromCMakeProject):
707         (buildCMakeGeneratedProject):
708         (cleanCMakeGeneratedProject):
709
710 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
711
712         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
713         https://bugs.webkit.org/show_bug.cgi?id=168150
714
715         Reviewed by Alexey Proskuryakov.
716
717         * Scripts/webkitpy/port/simulator_process.py:
718         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
719         (SimulatorProcess._kill): Move closing of app into stop().
720         * Scripts/webkitpy/xcode/simulator.py:
721         (Device.launch_app):
722         (Device.terminate_app): Deleted.
723
724 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         REGRESSION(r212192): [GTK] Broke downloads API tests
727         https://bugs.webkit.org/show_bug.cgi?id=168193
728
729         Unreviewed. Update test expectations after r212192.
730
731         The suggested filename now includes a file extensions if the MIME type is known.
732
733         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
734         (testDownloadRemoteFile):
735         (testDownloadMIMEType):
736
737 2017-02-14  Commit Queue  <commit-queue@webkit.org>
738
739         Unreviewed, rolling out r212237.
740         https://bugs.webkit.org/show_bug.cgi?id=168298
741
742         This was a wrong fix (Requested by rniwa on #webkit).
743
744         Reverted changeset:
745
746         "Nwtr unexpectedly passes mismatch ref test if the hashes
747         doesn't match but no diff"
748         https://bugs.webkit.org/show_bug.cgi?id=168221
749         http://trac.webkit.org/changeset/212237
750
751 2017-02-13  Alex Christensen  <achristensen@webkit.org>
752
753         URLs with an invalid IPv4 address should be invalid
754         https://bugs.webkit.org/show_bug.cgi?id=168260
755
756         Reviewed by Tim Horton.
757
758         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
759         (TestWebKitAPI::TEST_F):
760         Update tests to reflect new correct behavior.
761
762 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
763
764         [WinCairo] Add Build Slave
765         https://bugs.webkit.org/show_bug.cgi?id=168263
766
767         Reviewed by Lucas Forschler.
768
769         * BuildSlaveSupport/build.webkit.org-config/config.json:
770
771 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
772
773         Fix the build after r212254
774
775         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
776         (-[DataInteractionSimulator _currentLocation]):
777
778 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         [WK2] Add test infrastructure and unit tests for data interaction
781         https://bugs.webkit.org/show_bug.cgi?id=168159
782         <rdar://problem/30477634>
783
784         Reviewed by Tim Horton.
785
786         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
787         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
788         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
789         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
790         gesture has already been recognized) at regular intervals over the course of the test.
791
792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
793         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
794         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
795         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
796
797         New test pages for data interaction.
798
799         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
800         (TestWebKitAPI::runTestsExpectingToObserveEvents):
801         (TestWebKitAPI::TEST):
802         * TestWebKitAPI/cocoa/TestWKWebView.mm:
803         (-[TestWKWebView stringByEvaluatingJavaScript:]):
804         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
805         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
806         (-[MockLongPressGestureRecognizer initWithWindow:]):
807         (-[MockLongPressGestureRecognizer locationInView:]):
808         (-[MockLongPressGestureRecognizer state]):
809         (-[MockLongPressGestureRecognizer numberOfTouches]):
810         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
811         (-[DataInteractionSimulator dealloc]):
812         (-[DataInteractionSimulator run]):
813
814         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
815         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
816         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
817
818         (-[DataInteractionSimulator _advanceProgress]):
819
820         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
821         completed, and calls _finishDataInteraction when progress is at 1.
822
823         (-[DataInteractionSimulator _finishDataInteraction]):
824         (-[DataInteractionSimulator _currentLocation]):
825         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
826         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
827         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
828         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
829         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
830
831 2017-02-13  Alex Christensen  <achristensen@webkit.org>
832
833         Percent should be allowed in non-special URL hosts
834         https://bugs.webkit.org/show_bug.cgi?id=168255
835
836         Reviewed by Tim Horton.
837
838         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
839         (TestWebKitAPI::TEST_F):
840
841 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
842
843         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
844         https://bugs.webkit.org/show_bug.cgi?id=168221
845
846         Reviewed by Ryosuke Niwa.
847
848         There is a logic error in comparing mismatch ref test images. In
849         mismatch ref tests, it should be failed if two images has no diff.
850         But, if the hashes are different, nwtr unexpectedly pass the
851         mismatch ref test.
852
853         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
854         (SingleTestRunner._compare_output_with_reference): Fail the
855         mismatch ref test if hashes of two images are equal. Invoke
856         ImageDiff if the hashes don't match.
857
858 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
859
860         Update custom line breaking iterators to the latest version of Unicode
861         https://bugs.webkit.org/show_bug.cgi?id=168182
862
863         Reviewed by Zalan Bujtas.
864
865         Treat the system's ICU as the source of truth to compare breaking positions against.
866
867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
868         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
869         (generateJavaScriptForTest):
870         (breakingLocationsFromICU):
871         (testAFewStrings):
872         (TEST):
873         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
874         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
875
876 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
877
878         [GTK] Several failing WebViewEditor API tests
879         https://bugs.webkit.org/show_bug.cgi?id=161608
880
881         Reviewed by Carlos Garcia Campos.
882
883         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
884         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
885         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
886         except the first one, which is still broken due to unrelated bug #151654.
887
888         * Scripts/run-gtk-tests:
889         (TestRunner):
890         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
891
892 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
893
894         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
895
896         * Scripts/run-gtk-tests:
897         (TestRunner):
898
899 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         Unreviewed, skip flaky form-controls-associated-signal test
902
903         * Scripts/run-gtk-tests:
904         (TestRunner):
905
906 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
907
908         [GTK] Handle caps lock indicator in event modifiers
909         https://bugs.webkit.org/show_bug.cgi?id=168186
910
911         Reviewed by Michael Catanzaro.
912
913         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
914         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
915
916 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
917
918         MiniBrowser WK1 fails to update URL for within-page navigations
919         https://bugs.webkit.org/show_bug.cgi?id=168173
920
921         Reviewed by Tim Horton.
922         
923         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
924         anchors updates the URL field.
925
926         * MiniBrowser/mac/WK1BrowserWindowController.m:
927         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
928
929 2017-02-10  John Wilander  <wilander@apple.com>
930
931         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
932         https://bugs.webkit.org/show_bug.cgi?id=167474
933         <rdar://problem/24681808>
934         <rdar://problem/24703286>
935         <rdar://problem/30290270>
936
937         This patch adds test infrastructure to allow testing 
938         of the various rules in place for data records removal.
939
940         Reviewed by Andy Estes.
941
942         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
943         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
944         (WTR::InjectedBundle::didReceiveMessageToPage):
945             Callback mechanism to tell pages that a website data store
946             scan has happened.
947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
948         (WTR::TestRunner::setStatisticsPrevalentResource):
949         (WTR::TestRunner::isStatisticsPrevalentResource):
950         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
951         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
952         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
953         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
954         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
955         (WTR::TestRunner::statisticsFireDataModificationHandler):
956         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
957         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
958         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
959         (WTR::TestRunner::statisticsResetToConsistentState):
960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::setStatisticsPrevalentResource):
963         (WTR::TestController::isStatisticsPrevalentResource):
964         (WTR::TestController::setStatisticsHasHadUserInteraction):
965         (WTR::TestController::isStatisticsHasHadUserInteraction):
966         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
967         (WTR::TestController::statisticsFireDataModificationHandler):
968         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
969         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
970         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
971         (WTR::TestController::statisticsResetToConsistentState):
972         * WebKitTestRunner/TestController.h:
973             These are all configuration and test functions.
974         * WebKitTestRunner/TestInvocation.cpp:
975         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
976
977 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
978
979         REGRESSION(r182916) run-perf-tests never timeouts
980         https://bugs.webkit.org/show_bug.cgi?id=167626
981
982         Reviewed by Ryosuke Niwa.
983
984         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
985         was beeing ignored because the driver was created with no_timeout=True
986         unconditionally.
987         This adds a new parameter --no-timeout (disabled by default), that
988         allows to use the driver with the expected timeout values.
989         It also passes --no-timeout to DRT/WTR to ensure that timeouts
990         are always controlled by the Python Driver.
991
992         * Scripts/webkitpy/performance_tests/perftest.py:
993         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
994         (PerfTest.run): Disabling timeout should be done when the Driver is created.
995         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
996         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
997         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
998         (_run_tests_set): Pass the no-timeout parameter.
999         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1000         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1001         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1002         (MainTest.test_parse_args): Test that the argument no-timeout.
1003
1004 2017-02-10  Daniel Bates  <dabates@apple.com>
1005
1006         Detach frame from document when entering page cache
1007         https://bugs.webkit.org/show_bug.cgi?id=166774
1008         <rdar://problem/29904368>
1009
1010         Reviewed by Chris Dumez.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (resetWebPreferencesToConsistentValues):
1014         * DumpRenderTree/win/DumpRenderTree.cpp:
1015         (resetWebPreferencesToConsistentValues):
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::resetPreferencesToConsistentValues):
1018
1019 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1020
1021         Infinite UI process hang under ensurePositionInformationIsUpToDate
1022         https://bugs.webkit.org/show_bug.cgi?id=168154
1023         <rdar://problem/30428673>
1024
1025         Reviewed by Simon Fraser.
1026
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1029         (recursiveFindHighlightLongPressRecognizer):
1030         (TEST):
1031         Add a somewhat nasty test that does an async interaction information update, but
1032         kills the Web process before it arrives, and then does a sync interaction
1033         information update, which will wait for the oustanding async interaction
1034         information update if we still think it's coming. Before the patch, this
1035         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1036
1037 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1038
1039         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1040         https://bugs.webkit.org/show_bug.cgi?id=168127
1041         rdar://problem/30467120
1042
1043         Reviewed by Tim Horton.
1044
1045         Reparent the web view before we try to fetch it via:
1046             [[[window contentView] subviews] objectAtIndex:0];
1047         which would throw an exception if the test unparented it.
1048
1049         * DumpRenderTree/mac/DumpRenderTree.mm:
1050         (resetWebViewToConsistentStateBeforeTesting):
1051         (runTest):
1052
1053 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1054
1055         [Resource Timing] Enable Resource Timing by default in Tests
1056         https://bugs.webkit.org/show_bug.cgi?id=168145
1057
1058         Reviewed by Ryosuke Niwa.
1059
1060         * DumpRenderTree/mac/DumpRenderTree.mm:
1061         (resetWebPreferencesToConsistentValues):
1062         * DumpRenderTree/win/DumpRenderTree.cpp:
1063         (resetWebPreferencesToConsistentValues):
1064         * WebKitTestRunner/TestController.cpp:
1065         (WTR::TestController::resetPreferencesToConsistentValues):
1066
1067 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1068
1069         Removing LayoutTestRelay
1070         https://bugs.webkit.org/show_bug.cgi?id=165927
1071
1072         Reviewed by Daniel Bates.
1073         Part 2
1074
1075         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1076         simulators through simctl (iOS 10 and later), use this functionality instead.
1077
1078         * BuildSlaveSupport/built-product-archive:
1079         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1080         Added a FIXME that we will need to implement similar archiving machinery once we build
1081         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1082         * BuildSlaveSupport/kill-old-processes:
1083         (main): Remove LayoutTestRelay from list of processes.
1084         * LayoutTestRelay: Removed LayoutTestRelay.
1085         * Makefile:
1086         * Scripts/build-layouttestrelay: Removed.
1087         * Scripts/build-webkit: Removed LayoutTestRelay references.
1088
1089 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1090
1091         [WebCrypto] Add WebCryptoAPI to watchlist
1092         https://bugs.webkit.org/show_bug.cgi?id=168138
1093
1094         Reviewed by Youenn Fablet.
1095
1096         * Scripts/webkitpy/common/config/watchlist:
1097
1098 2017-02-10  Brady Eidson  <beidson@apple.com>
1099
1100         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1101         https://bugs.webkit.org/show_bug.cgi?id=168124
1102
1103         Reviewed by Geoffrey Garen.
1104
1105         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1106         
1107         * MiniBrowser/mac/main.m:
1108         (main):
1109         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1110         (main):
1111         * TestWebKitAPI/ios/mainIOS.mm:
1112         (main):
1113         * TestWebKitAPI/mac/mainMac.mm:
1114         (main):
1115         * WebKitTestRunner/ios/mainIOS.mm:
1116         (main):
1117         * WebKitTestRunner/mac/main.mm:
1118         (setDefaultsToConsistentValuesForTesting):
1119
1120 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1121
1122         Fix El Capitan build.
1123
1124         * Scripts/build-webkit:
1125         Don't build libwebrtc anywhere for now.
1126
1127 2017-02-10  Andy Estes  <aestes@apple.com>
1128
1129         Move two MiniBrowserBundle settings out of the .pbxproj
1130         https://bugs.webkit.org/show_bug.cgi?id=168106
1131
1132         Reviewed by Tim Horton.
1133
1134         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1135         the project file. This removes the project file override.
1136
1137         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1138
1139         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1140         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1141
1142 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1143
1144         Fix 32-and-64-bit build on El Capitan.
1145
1146         * Scripts/build-webkit:
1147         Somebody's building with something like this:
1148         build-webkit ARCHS="i386 x86_64"
1149         We want this to also not build libwebrtc for now.
1150
1151 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1152
1153         Fix 32-bit build on El Capitan.
1154
1155         * Scripts/build-webkit:
1156         The bot uses ARCHS=i386 instead of --32-bit.
1157         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1158
1159 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1160
1161         Fix 32-bit build on El Capitan.
1162
1163         * Scripts/build-webkit:
1164         Don't build i386 libwebrtc.
1165
1166 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1167
1168         Unreviewed, rolling out r212040.
1169
1170         Broke build.  I'm not surprised
1171
1172         Reverted changeset:
1173
1174         "[WebRTC][Mac] Activate libwebrtc"
1175         https://bugs.webkit.org/show_bug.cgi?id=167293
1176         http://trac.webkit.org/changeset/212040
1177
1178 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1179
1180         Build libwebrtc on bots without using it yet
1181         https://bugs.webkit.org/show_bug.cgi?id=168062
1182
1183         Reviewed by Brent Fulgham.
1184
1185         * Scripts/build-webkit:
1186
1187 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1188
1189         Don't build libwebrtc.
1190
1191         * Scripts/build-webkit:
1192         Not ready yet.  It broke El Capitan and iOS.
1193
1194 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1195
1196         Build libwebrtc on bots without using it yet
1197         https://bugs.webkit.org/show_bug.cgi?id=168062
1198
1199         Reviewed by Brent Fulgham.
1200
1201         * Scripts/build-webkit:
1202
1203 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1204
1205         Rename isAppleMacWebKit to isAppleCocoaWebKit
1206         https://bugs.webkit.org/show_bug.cgi?id=168075
1207
1208         Reviewed by Geoffrey Garen.
1209
1210         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1211
1212         * Scripts/build-api-tests:
1213         * Scripts/build-dumprendertree:
1214         * Scripts/build-jsc:
1215         (buildMyProject):
1216         * Scripts/build-layouttestrelay:
1217         * Scripts/build-webkit:
1218         * Scripts/build-webkittestrunner:
1219         * Scripts/run-api-tests:
1220         (isSupportedPlatform):
1221         (runTest):
1222         (listAllTests):
1223         (prepareEnvironmentForRunningTestTool):
1224         * Scripts/run-content-extension-tester:
1225         * Scripts/run-javascriptcore-tests:
1226         * Scripts/run-minibrowser:
1227         * Scripts/show-pretty-diff:
1228         * Scripts/webkitdirs.pm:
1229         (determineBaseProductDir):
1230         (determineArchitecture):
1231         (determinePassedArchitecture):
1232         (safariPath):
1233         (builtDylibPathForName):
1234         (checkFrameworks):
1235         (isAppleWebKit):
1236         (isAppleCocoaWebKit):
1237         (determineNmPath):
1238         (launcherName):
1239         (wrapperPrefixIfNeeded):
1240         (isCMakeBuild):
1241         (mobileSafariBundle):
1242         (debugSafari):
1243         (runSafari):
1244         (runMiniBrowser):
1245         (debugMiniBrowser):
1246         (runWebKitTestRunner):
1247         (debugWebKitTestRunner):
1248         (isAppleMacWebKit): Deleted.
1249         * Scripts/webkitperl/FeatureList.pm:
1250
1251 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1252
1253         Revert r211991
1254         https://bugs.webkit.org/show_bug.cgi?id=168062
1255
1256         * Scripts/build-webkit:
1257         Not quite ready yet.
1258
1259 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1260
1261         Build libwebrtc on bots without using it yet
1262         https://bugs.webkit.org/show_bug.cgi?id=168062
1263
1264         Reviewed by Brent Fulgham.
1265
1266         * Scripts/build-webkit:
1267         Build libwebrtc on Mac when we build ANGLE.
1268
1269 2017-02-09  Youenn Fablet  <youenn@apple.com>
1270
1271         Improve W3C importer command line options
1272         https://bugs.webkit.org/show_bug.cgi?id=167448
1273
1274         Reviewed by Ryosuke Niwa.
1275
1276         Making the list of test paths to import the main arguments of the script.
1277         Allow passing the source directory to import as a -s option.
1278         Adding a warning when given test paths are skipped by default in ImportExpectations.
1279
1280         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1281         Link conversion rules do not change when imported tests are downloaded by the script.
1282
1283         * Scripts/webkitpy/w3c/test_importer.py:
1284         (main):
1285         (parse_args):
1286         (TestImporter.__init__):
1287         (TestImporter.do_import):
1288         (TestImporter):
1289         (TestImporter.check_imported_expectations):
1290
1291 2017-02-08  Chris Dumez  <cdumez@apple.com>
1292
1293         Update web-platform-tests resources
1294         https://bugs.webkit.org/show_bug.cgi?id=168026
1295
1296         Reviewed by Youenn Fablet.
1297
1298         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1299
1300         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1301         (WebPlatformTestServer._copy_webkit_test_files):
1302
1303 2017-02-08  Andy Estes  <aestes@apple.com>
1304
1305         Custom protocols should not continue loading after a network process crash
1306         https://bugs.webkit.org/show_bug.cgi?id=168028
1307         <rdar://problem/27607520>
1308
1309         Reviewed by Brady Eidson.
1310
1311         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1312         (processGroup):
1313         (-[CloseWhileStartingProtocol startLoading]):
1314         (-[CloseWhileStartingProtocol stopLoading]):
1315         (TestWebKitAPI::runTest):
1316         (TestWebKitAPI::TEST):
1317
1318 2017-02-08  Dan Bernstein  <mitz@apple.com>
1319
1320         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1321         https://bugs.webkit.org/show_bug.cgi?id=168031
1322
1323         Reviewed by Tim Horton.
1324
1325         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1326         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1327         (TEST):
1328         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1329         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1330
1331 2017-02-08  Chris Dumez  <cdumez@apple.com>
1332
1333         Use smaller tiles in windows that are not active to facilitate App Napping
1334         https://bugs.webkit.org/show_bug.cgi?id=167997
1335         <rdar://problem/30358835>
1336
1337         Reviewed by Simon Fraser.
1338
1339         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1340         (WTR::PlatformWebView::setWindowIsKey):
1341         Actually update windowIsKey state of NSWindow so the WebView
1342         properly updates its activity state.
1343
1344 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1345
1346         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1347         https://bugs.webkit.org/show_bug.cgi?id=167942
1348         <rdar://problem/30315079>
1349
1350         Reviewed by Tim Horton.
1351
1352         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1353         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1354         contenteditable in these cases.
1355
1356         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1357         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1358         performDragOperation:) directly.
1359
1360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1361         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1362         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1363         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1364         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1365         (-[DragSource draggingSourceOperationMaskForLocal:]):
1366         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1367         (-[DragInfo lastMousePosition]):
1368         (-[DragInfo setLastMousePosition:]):
1369         (-[DragInfo draggingDestinationWindow]):
1370         (-[DragInfo draggingSourceOperationMask]):
1371         (-[DragInfo draggingLocation]):
1372         (-[DragInfo draggedImageLocation]):
1373         (-[DragInfo draggedImage]):
1374         (-[DragInfo draggingPasteboard]):
1375         (-[DragInfo draggingSource]):
1376         (-[DragInfo draggingSequenceNumber]):
1377         (-[DragInfo slideDraggedImageTo:]):
1378         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1379         (-[DragInfo draggingFormation]):
1380         (-[DragInfo setDraggingFormation:]):
1381         (-[DragInfo animatesToDestination]):
1382         (-[DragInfo setAnimatesToDestination:]):
1383         (-[DragInfo numberOfValidItemsForDrop]):
1384         (-[DragInfo setNumberOfValidItemsForDrop:]):
1385         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1386         (-[DragInfo springLoadingHighlight]):
1387         (-[DragInfo resetSpringLoading]):
1388         (TestWebKitAPI::getTestImage):
1389         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1392
1393 2017-02-08  Jer Noble  <jer.noble@apple.com>
1394
1395         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1396         https://bugs.webkit.org/show_bug.cgi?id=168007
1397
1398         Reviewed by Alex Christensen.
1399
1400         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1401         (didFinishLoadForFrame):
1402         (TestWebKitAPI::TEST):
1403
1404 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1405
1406         Unreviewed, rolling out r211873.
1407         https://bugs.webkit.org/show_bug.cgi?id=168001
1408
1409         It's in jhbuild for consistent layout tests (Requested by
1410         mcatanzaro on #webkit).
1411
1412         Reverted changeset:
1413
1414         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1415         https://bugs.webkit.org/show_bug.cgi?id=167993
1416         http://trac.webkit.org/changeset/211873
1417
1418 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1419
1420         [GTK] Add icu packages to Tools/gtk/install-dependencies
1421         https://bugs.webkit.org/show_bug.cgi?id=167993
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1426         depending in the GNU/Linux distribution)
1427
1428 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1429
1430         Update flakiness dashboard configuration.
1431         https://bugs.webkit.org/show_bug.cgi?id=167957
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         * TestResultServer/static-dashboards/builders.jsonp:
1436
1437 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1438
1439         Replace a bot that has an incorrect configuration.
1440         https://bugs.webkit.org/show_bug.cgi?id=167747
1441
1442         Rubber-stamped by Alexey Proskuryakov.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/config.json:
1445
1446 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1447
1448         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1449         https://bugs.webkit.org/show_bug.cgi?id=167927
1450
1451         Reviewed by Brent Fulgham.
1452
1453         Enable ComplexTextController API tests on the Win and GTK ports.
1454
1455         * TestWebKitAPI/PlatformGTK.cmake:
1456         * TestWebKitAPI/PlatformWin.cmake:
1457
1458 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1459
1460         File index appended to previous file in svn-create-patch with SVN 1.9
1461         https://bugs.webkit.org/show_bug.cgi?id=167903
1462         <rdar://problem/30387395>
1463
1464         Reviewed by Daniel Bates.
1465
1466         * Scripts/VCSUtils.pm:
1467         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1468         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1469         trailing newline character from the expected result before comparing it to the actual result.
1470
1471 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1472
1473         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1474         https://bugs.webkit.org/show_bug.cgi?id=167936
1475
1476         Reviewed by Michael Catanzaro.
1477
1478         * Scripts/webkitdirs.pm:
1479         (determineArchitecture):
1480         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1481         since r195083.
1482
1483 2017-02-07  Youenn Fablet  <youenn@apple.com>
1484
1485         Use a JSON file to define which WPT files/folders to import
1486         https://bugs.webkit.org/show_bug.cgi?id=167923
1487
1488         Reviewed by Alex Christensen.
1489
1490         * Scripts/webkitpy/w3c/test_downloader.py:
1491         (TestDownloader.__init__):
1492         (TestDownloader._init_paths_from_expectations):
1493         * Scripts/webkitpy/w3c/test_importer.py:
1494         (parse_args):
1495         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1496
1497 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1498
1499         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1500         https://bugs.webkit.org/show_bug.cgi?id=167916
1501
1502         Reviewed by Carlos Garcia Campos.
1503
1504         URL of mesa-11.0.6.tar.xz has been moved.
1505
1506         * gtk/jhbuild.modules: Fix the module path.
1507
1508 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1509
1510         Static Analyzer: Address some leaks in MiniBrowser
1511         https://bugs.webkit.org/show_bug.cgi?id=167897
1512
1513         Reviewed by Alexey Proskuryakov.
1514
1515         * MiniBrowser/mac/BrowserWindowController.m:
1516         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1517         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1518         (-[ExtensionManagerWindowController add:]):
1519         (-[ExtensionManagerWindowController remove:]):
1520         * MiniBrowser/mac/SettingsController.m:
1521         (-[SettingsController _populateMenu]):
1522         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1523         Address obvious leaks caught by the static analyzer.
1524
1525 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1526
1527         Migrate ComplexTextController to use platform-independent types
1528         https://bugs.webkit.org/show_bug.cgi?id=167833
1529
1530         Reviewed by Brent Fulgham.
1531
1532         Migrate tests away from platform-dependent types.
1533
1534         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1535         (TestWebKitAPI::TEST_F):
1536
1537 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1538
1539         Correct File Path Handling in SecurityOrigin and FileSystem
1540         https://bugs.webkit.org/show_bug.cgi?id=167894
1541         <rdar://problem/30380080>
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1546         and perform same-volume checks using filesystem-compatible paths.        
1547         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1548         filesystem paths, and perform validation of same-volume checks.
1549         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1550         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1551         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1552         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1553
1554 2017-02-06  Jer Noble  <jer.noble@apple.com>
1555
1556         Playback stalls when a SourceBuffer append causes frame eviction
1557         https://bugs.webkit.org/show_bug.cgi?id=167834
1558
1559         Reviewed by Eric Carlson.
1560
1561         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1562         for the WTF::MediaTime class.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1568         (WTF::operator<<):
1569         (TestWebKitAPI::TestSample::create):
1570         (TestWebKitAPI::TestSample::TestSample):
1571         (TestWebKitAPI::TEST_F):
1572
1573 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1574
1575         Change capitalization in platform name after r211735.
1576
1577         Unreviewed dashboard fix.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1580         (WebKitBuildbot):
1581
1582 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1583
1584         Move the Leaks bot to Sierra
1585         https://bugs.webkit.org/show_bug.cgi?id=167886
1586
1587         Reviewed by Daniel Bates.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/config.json:
1590         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1592         (LeaksViewer._displayURLPrompt):
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1594         (WebKitBuildbot):
1595
1596 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1597
1598         Prevent app crash on launch during simctl install workaround
1599         https://bugs.webkit.org/show_bug.cgi?id=167685
1600
1601         Reviewed by Daniel Bates.
1602
1603         * Scripts/webkitpy/port/simulator_process.py:
1604         (SimulatorProcess.__init__): Pass environment to install.
1605         * Scripts/webkitpy/xcode/simulator.py:
1606         (Device.install_app): Accept environment, pass environment to launch.
1607
1608 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1609
1610         Rebase API tests after r211638
1611         https://bugs.webkit.org/show_bug.cgi?id=167779
1612
1613         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1614         (TestWebKitAPI::TEST_F):
1615         URLs with non-special schemes and characters like % in the host now fail to parse,
1616         more like their special counterparts and according to spec.
1617
1618 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1619
1620         Unreviewed trivial fix after r211697.
1621         https://bugs.webkit.org/show_bug.cgi?id=167863
1622
1623         * Scripts/run-javascriptcore-tests:
1624         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1625
1626 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1627
1628         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1629         https://bugs.webkit.org/show_bug.cgi?id=167850
1630
1631         Reviewed by Tim Horton.
1632
1633         * DumpRenderTree/TestRunner.cpp:
1634         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1635
1636 2017-02-04  Andreas Kling  <akling@apple.com>
1637
1638         Plug some leaks in TestController and UIScriptContext.
1639         <https://webkit.org/b/167839>
1640
1641         Reviewed by Alexey Proskuryakov.
1642
1643         Fix a couple of the leaks seen on the leaks bot.
1644
1645         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1646         (UIScriptContext::runUIScript):
1647         * WebKitTestRunner/TestController.cpp:
1648         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1649         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1650
1651 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1652
1653         WK1 mouse events are missing movementX and movementY for pointerlock.
1654         https://bugs.webkit.org/show_bug.cgi?id=167775
1655         rdar://problem/30343810
1656
1657         Reviewed by Alexey Proskuryakov.
1658
1659         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1660
1661         * DumpRenderTree/mac/EventSendingController.mm:
1662         (-[EventSendingController mouseMoveToX:Y:]):
1663         * WebKitTestRunner/mac/EventSenderProxy.mm:
1664         (WTR::EventSenderProxy::mouseMoveTo):
1665
1666 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1667
1668         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1669         https://bugs.webkit.org/show_bug.cgi?id=167774
1670
1671         Reviewed by Tim Horton.
1672
1673         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1674         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1675         web process are async, so the callback fires after the web process gets the new state.
1676
1677         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1678         (WTR::UIScriptController::removeViewFromWindow):
1679         (WTR::UIScriptController::addViewToWindow):
1680         * DumpRenderTree/mac/DumpRenderTree.mm:
1681         (createWebViewAndOffscreenWindow):
1682         (resetWebViewToConsistentStateBeforeTesting):
1683         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1684         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1685         (WTR::UIScriptController::removeViewFromWindow):
1686         (WTR::UIScriptController::addViewToWindow):
1687         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1688         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1689         (WTR::UIScriptController::removeViewFromWindow):
1690         (WTR::UIScriptController::addViewToWindow):
1691         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1692         * WebKitTestRunner/PlatformWebView.h:
1693         * WebKitTestRunner/TestController.cpp:
1694         (WTR::TestController::resetStateToConsistentValues):
1695         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1696         (WTR::PlatformWebView::removeFromWindow):
1697         (WTR::PlatformWebView::addToWindow):
1698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1699         (WTR::UIScriptController::removeViewFromWindow):
1700         (WTR::UIScriptController::addViewToWindow):
1701         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1702         (WTR::PlatformWebView::removeFromWindow):
1703         (WTR::PlatformWebView::addToWindow):
1704         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1705         (WTR::UIScriptController::removeViewFromWindow):
1706         (WTR::UIScriptController::addViewToWindow):
1707
1708 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1709
1710         Remove check for SkipSafariExecutableEntitlementChecks
1711         https://bugs.webkit.org/show_bug.cgi?id=167762
1712
1713         Reviewed by Dan Bernstein.
1714
1715         Follow-up fix: don't break internal behavior.
1716
1717         * Scripts/webkitdirs.pm:
1718         (safariPath):
1719         (executableHasEntitlements): Deleted.
1720         (safariPathFromSafariBundle): Deleted.
1721         (installedSafariPath): Deleted.
1722
1723 2017-02-03  Daniel Bates  <dabates@apple.com>
1724
1725         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1726         https://bugs.webkit.org/show_bug.cgi?id=167810
1727         <rdar://problem/30102568>
1728
1729         Reviewed by Anders Carlsson.
1730
1731         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1732
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1735         (TEST):
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1737         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1739         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1740
1741 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1742
1743         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1744         https://bugs.webkit.org/show_bug.cgi?id=167773
1745         <rdar://problem/30221102>
1746
1747         Reviewed by Ryosuke Niwa.
1748
1749         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1750         (TestWebKitAPI::TEST_F):
1751
1752 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1753
1754         Remove check for SkipSafariExecutableEntitlementChecks
1755         https://bugs.webkit.org/show_bug.cgi?id=167762
1756         rdar://problem/22480673
1757
1758         Reviewed by Dan Bernstein.
1759
1760         * Scripts/webkitdirs.pm:
1761         (safariPathFromSafariBundle):
1762         (skipSafariExecutableEntitlementChecks): Deleted.
1763
1764 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1765
1766         Undefined subroutine in svn-create-patch
1767         https://bugs.webkit.org/show_bug.cgi?id=167742
1768
1769         Unreviewed build-fix after r211543.
1770
1771         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1772
1773 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1774
1775         Unreviewed. Fix jhbuild dependencies build.
1776
1777         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1778         Patch updated.
1779
1780 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1781
1782         [EME][GStreamer] Fixed decryptor selection
1783         https://bugs.webkit.org/show_bug.cgi?id=167588
1784
1785         Reviewed by Žan Doberšek.
1786
1787         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1788
1789         * gtk/jhbuild.modules: Added patches to gstreamer and
1790         gst-plugins-good packages.
1791         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1792         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1793
1794 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1795
1796         Make run-benchmark script supports 'config' key in test plan.
1797         https://bugs.webkit.org/show_bug.cgi?id=167715
1798
1799         Reviewed by Ryosuke Niwa.
1800
1801         Add support for 'config' key in test paln.
1802         'config' key is a dictionary that specifies environment configurations while test is running.
1803         Specifies orientation to be portrait in MotionMark benchmark.
1804
1805         * Scripts/webkitpy/benchmark_runner/README.md:
1806         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1807         (BenchmarkRunner.__init__):
1808         (BenchmarkRunner._run_benchmark):
1809         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1810         (BrowserDriver.prepare_env):
1811         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1812         (LinuxBrowserDriver.prepare_env):
1813         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1814         (OSXBrowserDriver.prepare_env):
1815         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1816         (OSXSafariDriver.prepare_env):
1817         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1818
1819 2017-02-01  Daniel Bates  <dabates@apple.com>
1820
1821         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1822         https://bugs.webkit.org/show_bug.cgi?id=167169
1823
1824         Reviewed by David Kilzer.
1825
1826         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1827         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1828         header from the output of "svn diff" on a file that was copied or moved.
1829
1830         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1831         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1832         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1833         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1834         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1835         of a file with only a property change also does not contain any chunk range lines. Therefore
1836         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1837         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1838         we should directly test for the presence of a leading SVN diff header with an empty body and
1839         remove such lines from the diff.
1840
1841         * Scripts/VCSUtils.pm:
1842         (fixSVNPatchForAdditionWithHistory): Added.
1843         * Scripts/svn-create-patch:
1844         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1845         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1846         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1847
1848 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1849
1850         [Mac] Update CARingBuffer class
1851         https://bugs.webkit.org/show_bug.cgi?id=167656
1852
1853         Reviewed by Jer Noble.
1854
1855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1856         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1857         (TestWebKitAPI::CARingBufferTest::SetUp):
1858         (TestWebKitAPI::CARingBufferTest::setup):
1859         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1860         (TestWebKitAPI::CARingBufferTest::description):
1861         (TestWebKitAPI::CARingBufferTest::bufferList):
1862         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1863         (TestWebKitAPI::CARingBufferTest::capacity):
1864         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1865         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1866         (TestWebKitAPI::TEST_F):
1867         (TestWebKitAPI::MixingTest::run):
1868
1869 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1870
1871         [Mac] TestWebKitAPI includes system frameworks incorrectly
1872         https://bugs.webkit.org/show_bug.cgi?id=167703
1873         rdar://problem/30301498
1874
1875         Reviewed by Ryosuke Niwa.
1876
1877         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1878         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1879
1880         Also, reduced the number of subframework search paths, looks like we only need one now.
1881
1882         * TestWebKitAPI/Configurations/Base.xcconfig:
1883
1884 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1885
1886         Correct "filesHaveSameVolume" predicate
1887         https://bugs.webkit.org/show_bug.cgi?id=167696
1888         <rdar://problem/30298722>
1889
1890         Reviewed by David Kilzer.
1891
1892         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1893         percent-escaped path inputs.
1894
1895         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1896         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1897         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1898         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1899         (TestWebKitAPI::TEST_F):
1900
1901 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1902
1903         Unreviewed. Fix coding style in MiniBrowser
1904
1905         * MiniBrowser/gtk/BrowserWindow.c:
1906         (editingCommandCallback):
1907         (insertImageCommandCallback):
1908         (insertLinkCommandCallback):
1909
1910 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1911
1912         [GTK] Add an API to add a custom tab into the print dialog
1913         https://bugs.webkit.org/show_bug.cgi?id=151998
1914
1915         Reviewed by Carlos Garcia Campos.
1916
1917         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1918         that is testing a newly added API.
1919
1920         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1921         (testPrintCustomWidget):
1922         (beforeAll):
1923
1924 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1925
1926         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1927         https://bugs.webkit.org/show_bug.cgi?id=166529
1928
1929         Reviewed by Xabier Rodriguez-Calvar.
1930
1931         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1932         New patch version accepted in GStreamer upstream.
1933
1934 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1935
1936         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1937         https://bugs.webkit.org/show_bug.cgi?id=167498
1938
1939         Reviewed by Carlos Garcia Campos.
1940
1941         Depending on the distro version you can need either libxfont1-dev
1942         or libfont-dev to build with jhbuild.
1943
1944         * gtk/install-dependencies:
1945
1946 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1947
1948         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1949         https://bugs.webkit.org/show_bug.cgi?id=167594
1950
1951         Unreviewed test gardening.
1952
1953         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1954
1955         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1956         (TEST):
1957
1958 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1959
1960         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1961         https://bugs.webkit.org/show_bug.cgi?id=167676
1962
1963         Reviewed by Saam Barati.
1964
1965         * Scripts/run-javascriptcore-tests:
1966         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1967
1968 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1969
1970         Make Dump Render Tree not crash
1971         https://bugs.webkit.org/show_bug.cgi?id=167667
1972
1973         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1974         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1975         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1976         This does not fix any tests, it just fixes the crash.
1977         
1978         Reviewed by Simon Fraser.
1979
1980         * DumpRenderTree/TestRunner.cpp:
1981         (TestRunner::callUIScriptCallback):
1982
1983 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1984
1985         Workaround for simctl install failing to report install failure
1986         https://bugs.webkit.org/show_bug.cgi?id=167654
1987
1988         Reviewed by Daniel Bates.
1989
1990         simctl install will sometimes report success even though install has failed.
1991         To workaround this bug, we attempt an app launch after install to ensure
1992         install has succeeded.
1993
1994         * Scripts/webkitpy/xcode/simulator.py:
1995         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1996         (Device.launch_app): Correct comment.
1997
1998 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1999
2000         Unreviewed webkitpy fix after r211405.
2001
2002         * Scripts/webkitpy/xcode/simulator.py:
2003         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2004
2005 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2006
2007         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2008
2009         * gtk/manifest.txt.in:
2010
2011 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2012
2013         AX: enable search predication for iOS
2014         https://bugs.webkit.org/show_bug.cgi?id=167558
2015         <rdar://problem/30251367>
2016
2017         Reviewed by Joanmarie Diggs.
2018
2019         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2020         (AccessibilityUIElement::uiElementForSearchPredicate):
2021         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2022         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2023         (searchPredicateParameterizedAttributeForSearchCriteria):
2024         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2025         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2026         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2027         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2028         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2029         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2030         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2031         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2032         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2033         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2034         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2035
2036 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2037
2038         Workaround for simctl launch bug
2039         https://bugs.webkit.org/show_bug.cgi?id=167613
2040
2041         Reviewed by Daniel Bates.
2042
2043         simctl launch will sometimes fail because of a race condition when many
2044         simulators are being run simultaneously. These failures will always have
2045         an exit code of 1. This change attempts to launch an app multiple times
2046         before reporting a failure to workaround this bug.
2047
2048         * Scripts/webkitpy/xcode/simulator.py:
2049         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2050
2051 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2052
2053         Commit queue fails to look at real name aliases for the reviewer
2054         https://bugs.webkit.org/show_bug.cgi?id=167422
2055
2056         Reviewed by Joseph Pecoraro.
2057
2058         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2059         (test_has_valid_reviewer): Added tests.
2060
2061         * Scripts/webkitpy/common/config/committers.py:
2062         (CommitterList._name_to_contributor_map):
2063         Made _name_to_contributor_map include alias names.
2064
2065         * Scripts/webkitpy/common/config/committers_unittest.py:
2066         (CommittersTest.test_contributors_by_fuzzy_match):
2067         Removed subtests that are now obsolete, as these matches are strict. It is not
2068         obvious if distance based fuzzy matching for names is useful at all, but we can
2069         look into that some other time.
2070
2071 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2072
2073         QueueStatusServer should have an explicit timeout for _fetch_url
2074         https://bugs.webkit.org/show_bug.cgi?id=167467
2075
2076         Reviewed by Alexey Proskuryakov.
2077
2078         * Scripts/webkitpy/common/net/statusserver.py:
2079         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2080
2081 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2082
2083         Add support for Trac instances that host multiple projects.
2084         https://bugs.webkit.org/show_bug.cgi?id=167524
2085
2086         Reviewed by Alexey Proskuryakov.
2087
2088         When multiple projects are hosted on a single Trac instance, the current
2089         behavior will retrieve changesets from all tracked projects.
2090         This patch teaches Trac.js to get project-specific changesets from Trac.
2091         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2092         when querying the Trac timeline.
2093
2094         To tell Trac to be aware of multi-project instances we leverage the 
2095         `options` parameter when creating a new instance: 
2096
2097             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2098
2099         If this option is not provided, the original behaviour will prevail.
2100         Additionally, add corresponding tests.
2101
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2103         (Trac): Reason about new optional parameter 'projectIdentifier'.
2104         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2105         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2106         replace default parameter `changeset=on` with `repo-projectname=on`.
2107         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2109         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2111         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2112         Add the following tests:
2113             test("revisionURL")
2114             test("revisionURL with Trac Identifier")
2115             test("_xmlTimelineURL")
2116             test("_xmlTimelineURL with Trac Identifier")
2117         (this.view._latestProductiveIteration): Fix missing ';'.
2118
2119 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2120
2121         Correct spacing regression on inter-element complex path shaping on some fonts
2122         https://bugs.webkit.org/show_bug.cgi?id=166013
2123
2124         Reviewed by Simon Fraser.
2125
2126         Unskip existing tests and make some new tests:
2127         - Testing complex text with no origins
2128         - Testing initial expansions
2129         - Testing the sign of vertical advances
2130
2131         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2132         (TestWebKitAPI::TEST_F):
2133
2134 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2135
2136         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2137         https://bugs.webkit.org/show_bug.cgi?id=167596
2138
2139         Reviewed by Daniel Bates.
2140
2141         We avoid needing a thin directory by invoking the zip program with
2142         the list of directories from the build directory to be zipped,
2143         and by using the zip feature to exclude files matching a pattern.
2144
2145         * BuildSlaveSupport/built-product-archive:
2146         (copyBuildFiles):
2147         (createZipFromList):
2148         (archiveBuiltProduct):
2149
2150 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2151
2152         Use simctl instead of LayoutTestRelay
2153         https://bugs.webkit.org/show_bug.cgi?id=165927
2154
2155         Reviewed by Daniel Bates.
2156
2157         Part 1
2158
2159         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2160         simulators through simctl (iOS 10 and later), use this functionality instead.
2161
2162         * Scripts/webkitpy/port/base.py:
2163         (Port.__init__): Added _test_runner_process_constructor.
2164         * Scripts/webkitpy/port/darwin.py:
2165         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2166         * Scripts/webkitpy/port/driver.py:
2167         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2168         (IOSSimulatorDriver): Deleted.
2169         * Scripts/webkitpy/port/driver_unittest.py:
2170         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2171         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2172         (DriverTest.test_start_actually_starts): Ditto.
2173         * Scripts/webkitpy/port/ios.py:
2174         (IOSSimulatorPort): Remove relay_name.
2175         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2176         (IOSSimulatorPort._create_simulators): Formatting change.
2177         (IOSSimulatorPort.relay_path): Deleted.
2178         (IOSSimulatorPort._check_relay): Deleted.
2179         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2180         (IOSSimulatorPort._build_relay): Deleted.
2181         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2182         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2183         * Scripts/webkitpy/port/ios_unittest.py:
2184         (iosTest.test_32bit): Update test.
2185         (iosTest.test_64bit): Update test.
2186         * Scripts/webkitpy/port/server_process.py:
2187         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2188         (ServerProcess._set_file_nonblocking): Added to share common code.
2189         * Scripts/webkitpy/port/server_process_mock.py:
2190         (MockServerProcess.__init__): Added argument worker_number.
2191         * Scripts/webkitpy/port/simulator_process.py: Added.
2192         (SimulatorProcess): Added.
2193         (SimulatorProcess.Popen): Added.
2194         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2195         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2196         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2197         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2198         (SimulatorProcess._reset): Added. Unlink fifos.
2199         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2200         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2201         * Scripts/webkitpy/xcode/simulator.py:
2202         (Device.__init__): Accept host to run install/launch/terminate.
2203         (Device.install_app): Install app to target Device.
2204         (Device.launch_app): Launch app on target Device.
2205         (Device.terminate_app): Shutdown app on target Device.
2206         (Simulator._parse_devices): Pass host to Device.
2207
2208 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2209
2210         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2211         https://bugs.webkit.org/show_bug.cgi?id=167411
2212
2213         Reviewed by Michael Catanzaro.
2214
2215         Disable the ARM iwMMXt fast path for pixman, because it triggers
2216         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2217
2218         * gtk/jhbuild.modules:
2219
2220 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2221
2222         [GTK] Add API to handle the accelerated compositing policy
2223         https://bugs.webkit.org/show_bug.cgi?id=167509
2224
2225         Reviewed by Michael Catanzaro.
2226
2227         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2228         as a special case. Also add test cases to the get/set API.
2229
2230         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2231         (hardwareAccelerationPolicyToString):
2232         (stringToHardwareAccelerationPolicy):
2233         (cellRendererChanged):
2234         (browserSettingsDialogConstructed):
2235         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2236         (testWebKitSettings):
2237
2238 2017-01-29  Andy Estes  <aestes@apple.com>
2239
2240         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2241         https://bugs.webkit.org/show_bug.cgi?id=167563
2242         <rdar://problem/30253207>
2243
2244         Reviewed by Andreas Kling.
2245
2246         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2247         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2248         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2249         (runTest):
2250         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2251         (TEST):
2252
2253 2017-01-29  Dan Bernstein  <mitz@apple.com>
2254
2255         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2256         https://bugs.webkit.org/show_bug.cgi?id=167565
2257
2258         Reviewed by Sam Weinig.
2259
2260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2261         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2262         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2263         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2264         (TEST):
2265         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2266         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2267         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2268         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2269
2270 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2271
2272         Add Link Preload as an off-by-default experimental feature menu item.
2273         https://bugs.webkit.org/show_bug.cgi?id=167201
2274
2275         Reviewed by Ryosuke Niwa.
2276
2277         * DumpRenderTree/mac/DumpRenderTree.mm:
2278         (resetWebPreferencesToConsistentValues):
2279         * DumpRenderTree/win/DumpRenderTree.cpp:
2280         (resetWebPreferencesToConsistentValues):
2281
2282 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2283
2284         Add User Timing Experimental Feature
2285         https://bugs.webkit.org/show_bug.cgi?id=167542
2286         <rdar://problem/22746307>
2287
2288         Reviewed by Ryosuke Niwa.
2289
2290         * DumpRenderTree/mac/DumpRenderTree.mm:
2291         (enableExperimentalFeatures):
2292         (resetWebPreferencesToConsistentValues):
2293         * DumpRenderTree/win/DumpRenderTree.cpp:
2294         (enableExperimentalFeatures):
2295
2296 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2297
2298         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2299         https://bugs.webkit.org/show_bug.cgi?id=167519
2300
2301         Reviewed by Ryosuke Niwa.
2302
2303         * QueueStatusServer/templates/statusbubble.html:
2304         To measure the bubbleContainer's width, it must not be wrapping based
2305         on its parent container. So when measuring the width temporarily set
2306         the parent to a very large width so as to not artificially wrap us.
2307         Restore the parent's width after measuring.
2308
2309 2017-01-27  Andy Estes  <aestes@apple.com>
2310
2311         [iOS] Add a test for _WKNSFileManagerExtras
2312         https://bugs.webkit.org/show_bug.cgi?id=167478
2313
2314         Reviewed by Andreas Kling.
2315
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2318         (expectAttributes):
2319         (TEST):
2320
2321 2017-01-27  Keith Miller  <keith_miller@apple.com>
2322
2323         run-benchmarks should make sure it passes the test url to the right application
2324         https://bugs.webkit.org/show_bug.cgi?id=167533
2325
2326         Reviewed by Joseph Pecoraro.
2327
2328         This fixes an issue when trying to run-benchmark script with the
2329         system default browser set to STP. Previously, it would run
2330         the test in STP rather than the provided build. Now, it should run
2331         in the provided build.
2332
2333         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2334         (OSXSafariDriver.launch_url):
2335
2336 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2337
2338         [Cocoa] Prepare ComplexTextController for unit testing
2339         https://bugs.webkit.org/show_bug.cgi?id=167493
2340
2341         Reviewed by Simon Fraser.
2342
2343         Addressing post-review comments from Simon Fraser.
2344
2345         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2346         (TestWebKitAPI::TEST_F):
2347
2348 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2349
2350         [Cocoa] Prepare ComplexTextController for unit testing
2351         https://bugs.webkit.org/show_bug.cgi?id=167493
2352
2353         Reviewed by Dean Jackson.
2354
2355         Create four unit tests.
2356
2357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2358         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2359         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2360         (TestWebKitAPI::TEST_F):
2361
2362 2017-01-26  Chris Dumez  <cdumez@apple.com>
2363
2364         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2365         https://bugs.webkit.org/show_bug.cgi?id=167421
2366         <rdar://problem/30188490>
2367
2368         Reviewed by Darin Adler.
2369
2370         Add a new setting allowing layout tests to enable PageCache in a window
2371         that has an opener, for convenience.
2372
2373         * DumpRenderTree/mac/DumpRenderTree.mm:
2374         (resetWebPreferencesToConsistentValues):
2375         * DumpRenderTree/win/DumpRenderTree.cpp:
2376         (resetWebPreferencesToConsistentValues):
2377         * WebKitTestRunner/TestController.cpp:
2378         (WTR::TestController::resetPreferencesToConsistentValues):
2379
2380 2017-01-26  Keith Miller  <keith_miller@apple.com>
2381
2382         classInfo should take a VM so it is not materialized from the object on each call
2383         https://bugs.webkit.org/show_bug.cgi?id=167424
2384
2385         Rubber Stamped by Michael Saboff.
2386
2387         Previously, classInfo() would get the VM from the target's
2388         MarkedBlock.  Most callers already have a VM on hand, so it is
2389         wasteful to compute the VM from the marked block every time. This
2390         patch refactors some of the most common callers of classInfo(),
2391         jsDynamicCast and inherits to take a VM as well.
2392
2393         * DumpRenderTree/TestRunner.cpp:
2394         (setAudioResultCallback):
2395
2396 2017-01-26  Jer Noble  <jer.noble@apple.com>
2397
2398         Autoplay muted videos stop playback of any streaming app in the background
2399         https://bugs.webkit.org/show_bug.cgi?id=163993
2400         <rdar://problem/29020431>
2401
2402         Reviewed by Eric Carlson.
2403
2404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2405         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2406         (TestWebKitAPI::TEST):
2407         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2408
2409 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2410
2411         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2412         https://bugs.webkit.org/show_bug.cgi?id=167466
2413
2414         Unreviewed test gardening.
2415
2416         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2417         (TEST):
2418
2419 2017-01-26  Matt Rajca  <mrajca@apple.com>
2420
2421         Notify clients when the user plays media otherwise prevented from autoplaying
2422         https://bugs.webkit.org/show_bug.cgi?id=167390
2423
2424         Reviewed by Alex Christensen.
2425
2426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2427         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2428         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2429         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2430         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2431         (TEST):
2432         * TestWebKitAPI/cocoa/TestWKWebView.h:
2433         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2434         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2435         (-[TestWKWebView waitForLoad]):
2436         (-[TestWKWebView mouseUpAtPoint:]):
2437         * WebKitTestRunner/TestController.cpp:
2438         (WTR::TestController::createOtherPage):
2439         (WTR::TestController::createWebViewWithOptions):
2440
2441 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2442
2443         Crash when setting custom scale factor.
2444         https://bugs.webkit.org/show_bug.cgi?id=167369
2445
2446         Reviewed by Sam Weinig.
2447
2448         Added API test.
2449
2450         * TestWebKitAPI/PlatformWin.cmake:
2451         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2452         (TestWebKitAPI::WebKitCreateInstance):
2453         (TestWebKitAPI::ScaleWebView::SetUp):
2454         (TestWebKitAPI::ScaleWebView::TearDown):
2455         (TestWebKitAPI::TEST_F):
2456
2457 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         run-benchmark nests MotionMark results by the suite name twice
2460         https://bugs.webkit.org/show_bug.cgi?id=164948
2461
2462         Reviewed by Said Abou-Hallawa.
2463
2464         Use a single level MotionMark now that this is the name of the benchmark,
2465         and we no longer have tests that aren't part of the MotionMark suite.
2466
2467         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2468
2469 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2470
2471         Unreviewed, rolling out r211193.
2472
2473         This change broke internal builds.
2474
2475         Reverted changeset:
2476
2477         "Notify clients when the user plays media otherwise prevented
2478         from autoplaying"
2479         https://bugs.webkit.org/show_bug.cgi?id=167390
2480         http://trac.webkit.org/changeset/211193
2481
2482 2017-01-25  Matt Rajca  <mrajca@apple.com>
2483
2484         Notify clients when the user plays media otherwise prevented from autoplaying
2485         https://bugs.webkit.org/show_bug.cgi?id=167390
2486
2487         Reviewed by Alex Christensen.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2490         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2491         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2492         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2493         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2494         (TEST):
2495         * TestWebKitAPI/cocoa/TestWKWebView.h:
2496         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2497         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2498         (-[TestWKWebView waitForLoad]):
2499         (-[TestWKWebView mouseUpAtPoint:]):
2500         * WebKitTestRunner/TestController.cpp:
2501         (WTR::TestController::createOtherPage):
2502         (WTR::TestController::createWebViewWithOptions):
2503
2504 2017-01-25  Matt Rajca  <mrajca@apple.com>
2505
2506         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2507         https://bugs.webkit.org/show_bug.cgi?id=167385
2508
2509         Reviewed by Alex Christensen.
2510
2511         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2512         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2513         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2514         (TEST): Allow inline (rather than full screen) media playback on iOS.
2515
2516 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2517
2518         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2519         https://bugs.webkit.org/show_bug.cgi?id=167414
2520
2521         Reviewed by Michael Catanzaro.
2522
2523         Add a test case to check ephemeral web views don't write favicons to the database.
2524
2525         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2526         (ephemeralViewLoadChanged):
2527         (testPrivateBrowsing):
2528         (testFaviconDatabase):
2529
2530 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2531
2532         [GTK] Add a private browsing mode to MiniBrowser
2533         https://bugs.webkit.org/show_bug.cgi?id=167413
2534
2535         Reviewed by Michael Catanzaro.
2536
2537         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2538         private windows, even on non-private instances.
2539
2540         * MiniBrowser/gtk/BrowserWindow.c:
2541         (webViewTitleChanged): Add [Private] to title window for private windows.
2542         (webViewCreate): Pass web context to browser_window_new.
2543         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2544         (browserWindowFinalize): Disconnect web context signal handlers.
2545         (browser_window_init): Add shortcut for opening private window.
2546         (browser_window_new): It now receives the context and connect to download-started here.
2547         (browser_window_get_web_context): Return the context.
2548         * MiniBrowser/gtk/BrowserWindow.h:
2549         * MiniBrowser/gtk/main.c:
2550         (createBrowserTab): Create the web view for the window web context.
2551         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2552         (aboutDataHandleRequest): Ditto.
2553         (aboutURISchemeRequestCallback): Ditto.
2554         (main): Create ephemeral web context if private command line option is used.
2555
2556 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2557
2558         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2559         https://bugs.webkit.org/show_bug.cgi?id=167409
2560
2561         Reviewed by Antti Koivisto.
2562
2563         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2564         as well as tests for the newly added matchingElementInFlatTree.
2565
2566         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2567         (TestWebKitAPI::runJavaScriptAlert):
2568         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2569         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2570         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2571
2572 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2573
2574         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2575         https://bugs.webkit.org/show_bug.cgi?id=167370
2576
2577         Reviewed by Michael Catanzaro.
2578
2579         Add several test cases of ephemeral web views.
2580
2581         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2582         (testWebViewAuthenticationStorage):
2583         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2584         (ephemeralViewloadChanged):
2585         (testCookieManagerEphemeral):
2586         (beforeAll):
2587         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2588         (testWebKitSettings):
2589         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2590         (testWebContextEphemeral):
2591         (ephemeralViewloadChanged):
2592         (testWebContextProxySettings):
2593         (beforeAll):
2594         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2595         (ephemeralViewloadChanged):
2596         (testWebViewEphemeral):
2597         (beforeAll):
2598         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2599         (ephemeralViewloadChanged):
2600         (testWebsiteDataEphemeral):
2601         (beforeAll):
2602
2603 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2604
2605         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2606         https://bugs.webkit.org/show_bug.cgi?id=167402
2607
2608         Reviewed by Ryosuke Niwa.
2609
2610         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2611         (TestWebKitAPI::TEST):
2612
2613 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2614
2615         Add simple line layout toggle to MiniBrowser
2616         https://bugs.webkit.org/show_bug.cgi?id=167405
2617
2618         Reviewed by Andreas Kling.
2619
2620         * MiniBrowser/mac/SettingsController.h:
2621         * MiniBrowser/mac/SettingsController.m:
2622         (-[SettingsController _populateMenu]):
2623         (-[SettingsController validateMenuItem:]):
2624         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2625         (-[SettingsController simpleLineLayoutEnabled]):
2626         * MiniBrowser/mac/WK1BrowserWindowController.m:
2627         (-[WK1BrowserWindowController didChangeSettings]):
2628         * MiniBrowser/mac/WK2BrowserWindowController.m:
2629         (-[WK2BrowserWindowController didChangeSettings]):
2630
2631 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2632
2633         WKR does not include my nick when commit-queue lands my patch
2634         https://bugs.webkit.org/show_bug.cgi?id=167388
2635
2636         Reviewed by Ryosuke Niwa.
2637
2638         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2639         (NewCommitBot._summarize_commit_log):
2640         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2641         Perform nickname insertion before grabbing "Patch by" details.
2642         This way we can include the nickname with the full name.
2643
2644 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2645
2646         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2647         https://bugs.webkit.org/show_bug.cgi?id=167394
2648
2649         Reviewed by Ryosuke Niwa.
2650
2651         * Scripts/webkitperl/FeatureList.pm:
2652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2653
2654 2017-01-24  Youenn Fablet  <youenn@apple.com>
2655
2656         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2657         https://bugs.webkit.org/show_bug.cgi?id=167353
2658
2659         Reviewed by Alex Christensen.
2660
2661         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2662         (CMakeGenerator.initialize_targets):
2663
2664 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2665
2666         WKR should not confuse Miguel Gomez with Andres Gomez
2667         https://bugs.webkit.org/show_bug.cgi?id=167389
2668
2669         Reviewed by Lucas Forschler.
2670
2671         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2672         "mAndres Gomez". Fix this.
2673
2674         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2675         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2676         space on each side of the email address, so expect both spaces to be there before
2677         considering the email for replacement.
2678         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2679
2680 2017-01-24  Matt Rajca  <mrajca@apple.com>
2681
2682         Pass down website autoplay policies to media elements
2683         https://bugs.webkit.org/show_bug.cgi?id=167355
2684
2685         Reviewed by Alex Christensen.
2686
2687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2688         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2689         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2690         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2691         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2692         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2693         (TEST):
2694
2695 2017-01-24  Nan Wang  <n_wang@apple.com>
2696
2697         AX: Speak Selection does not work in an iframe
2698         https://bugs.webkit.org/show_bug.cgi?id=166794
2699         <rdar://problem/29913013>
2700
2701         Reviewed by Chris Fleizach.
2702
2703         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2704         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2705         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2706         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2707         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2708         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2709         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2710         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2711         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2712         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2713         (-[TestRunnerWKWebView dealloc]):
2714         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2715         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2716         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2717         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2718         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2719
2720 2017-01-24  Daniel Bates  <dabates@apple.com>
2721
2722         StringView.split() should use an iterator design pattern instead of allocating a Vector
2723         https://bugs.webkit.org/show_bug.cgi?id=163225
2724
2725         Reviewed by Darin Adler.
2726
2727         Add unit tests for StringView.split().
2728
2729         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2730         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2731         used in the StringView.split() unit tests.
2732         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2733         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2734         object to a Vector of String objects.
2735         (TestWebKitAPI::TEST): Added the following tests:
2736             - WTF.StringViewSplitEmptyAndNullStrings
2737             - WTF.StringViewSplitBasic
2738             - WTF.StringViewSplitWithConsecutiveSeparators
2739
2740 2017-01-23  Anders Carlsson  <andersca@apple.com>
2741
2742         The Score Esports crashes on launch
2743         https://bugs.webkit.org/show_bug.cgi?id=167338
2744         rdar://problem/29948645
2745
2746         Reviewed by Dan Bernstein.
2747
2748         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2749         (TestWebKitAPI::TEST):
2750         Add a test.
2751
2752 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2753
2754         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2755         https://bugs.webkit.org/show_bug.cgi?id=146589
2756
2757         Reviewed by Michael Catanzaro.
2758
2759         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2760         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2761
2762         * MiniBrowser/gtk/BrowserWindow.c:
2763         (webViewDecidePolicy):
2764         (newTabCallback):
2765         * MiniBrowser/gtk/main.c:
2766         (createBrowserTab):
2767         (aboutDataRequestFree):
2768         (aboutDataRequestNew):
2769         (aboutDataRequestForView):
2770         (websiteDataRemovedCallback):
2771         (websiteDataClearedCallback):
2772         (aboutDataScriptMessageReceivedCallback):
2773         (domainListFree):
2774         (aboutDataFillTable):
2775         (gotWebsiteDataCallback):
2776         (aboutDataHandleRequest):
2777         (aboutURISchemeRequestCallback):
2778         (main):
2779         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2780         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2781         (serverCallback):
2782         (beforeAll):
2783         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2784         (serverCallback):
2785         (WebsiteDataTest::WebsiteDataTest):
2786         (WebsiteDataTest::~WebsiteDataTest):
2787         (WebsiteDataTest::fetch):
2788         (WebsiteDataTest::remove):
2789         (WebsiteDataTest::clear):
2790         (testWebsiteDataConfiguration):
2791         (testWebsiteDataCache):
2792         (testWebsiteDataStorage):
2793         (testWebsiteDataDatabases):
2794         (testWebsiteDataAppcache):
2795         (beforeAll):
2796         (afterAll):
2797
2798 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2799
2800         Unreviewed, rolling out r211062.
2801         https://bugs.webkit.org/show_bug.cgi?id=167354
2802
2803         broke API tests (Requested by alexchristensen on #webkit).
2804
2805         Reverted changeset:
2806
2807         "Pass down website autoplay policies to media elements"
2808         https://bugs.webkit.org/show_bug.cgi?id=167132
2809         http://trac.webkit.org/changeset/211062
2810
2811 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2812
2813         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2814         https://bugs.webkit.org/show_bug.cgi?id=167330
2815
2816         Reviewed by Tim Horton.
2817
2818         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2819         (TestWebKitAPI::TEST_F):
2820
2821 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2822
2823         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2824         https://bugs.webkit.org/show_bug.cgi?id=167317
2825
2826         Reviewed by Sam Weinig.
2827
2828         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2829         (TestWebKitAPI::TEST_F):
2830
2831 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2832
2833         svn-create-patch should emit properties when files are moved or copied
2834         https://bugs.webkit.org/show_bug.cgi?id=167264
2835
2836         Reviewed by Daniel Bates.
2837
2838         * Scripts/svn-create-patch:
2839         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2840
2841 2017-01-23  Youenn Fablet  <youenn@apple.com>
2842
2843         [WebRTC] Filter libwebrtc link flags
2844         https://bugs.webkit.org/show_bug.cgi?id=167287
2845
2846         Reviewed by Alex Christensen.
2847
2848         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2849         (CMakeGenerator._compute_link_flags):
2850         (CMakeGenerator._compute_link_flags.keep_flag):
2851         (CMakeGenerator._generate_compile_target_options):
2852
2853 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2854
2855         [WebRTC] Make VP8 optional in libwebrtc
2856         https://bugs.webkit.org/show_bug.cgi?id=167257
2857
2858         Reviewed by Darin Adler.
2859
2860         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2861         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2862
2863 2017-01-23  Jer Noble  <jer.noble@apple.com>
2864
2865         Video details does not apear and missing scrubber in Control Center
2866         https://bugs.webkit.org/show_bug.cgi?id=167233
2867
2868         Reviewed by Alex Christensen.
2869
2870         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2871         NowPlayingControlTests for iOS.
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2875         (-[NowPlayingTestWebView setWindowVisible:]):
2876         (TestWebKitAPI::TEST):
2877         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2878         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2879         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2880         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2881         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2882         (SOFT_LINK_CLASS):
2883         (-[TestMessageHandler addMessage:withHandler:]):
2884         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2885         (__simulated_forceClickAssociatedEventsMask):
2886         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2887         (-[TestWKWebViewHostWindow isKeyWindow]):
2888         (-[TestWKWebViewHostWindow makeKeyWindow]):
2889         (-[TestWKWebViewHostWindow resignKeyWindow]):
2890         (-[TestWKWebView initWithFrame:]):
2891         (-[TestWKWebView initWithFrame:configuration:]):
2892         (-[TestWKWebView _setUpTestWindow:]):
2893         (-[TestWKWebView performAfterReceivingMessage:action:]):
2894         (-[TestWKWebView loadTestPageNamed:]):
2895         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2896         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2897         (-[TestWKWebView waitForMessage:]):
2898         (-[TestWKWebView performAfterLoading:]):
2899         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2900         (-[TestWKWebView typeCharacter:]):
2901
2902 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2903
2904         Unreviewed. Bring back gtk-doc error messages after r209981.
2905
2906         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2907         impossible to know what's wrong.
2908
2909         * gtk/gtkdoc.py:
2910         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2911
2912 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2913
2914         [WebRTC] Update build system to make G711 optional in libwebrtc
2915         https://bugs.webkit.org/show_bug.cgi?id=167256
2916
2917         Reviewed by Alex Christensen.
2918
2919         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2920         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2921
2922 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2923
2924         Cleanup RuntimeEnabledFeatures
2925         https://bugs.webkit.org/show_bug.cgi?id=167228
2926
2927         Reviewed by Simon Fraser.
2928
2929         * DumpRenderTree/mac/DumpRenderTree.mm:
2930         (enableExperimentalFeatures):
2931         (resetWebPreferencesToConsistentValues):
2932         (setWebPreferencesForTestOptions):
2933         (resetWebViewToConsistentStateBeforeTesting):
2934         * DumpRenderTree/win/DumpRenderTree.cpp:
2935         (enableExperimentalFeatures):
2936         (resetWebPreferencesToConsistentValues):
2937         More closely match WebKitTestRunner initialization of preferences
2938         for experimental features.
2939
2940 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2941
2942         Build Fix for Windows DumpRenderTree after r210976
2943         https://bugs.webkit.org/show_bug.cgi?id=167115
2944
2945         * DumpRenderTree/win/DumpRenderTree.cpp:
2946         (resetWebPreferencesToConsistentValues):
2947
2948 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2949
2950         Remove outdated ENABLE(CSP_NEXT) build flag
2951         https://bugs.webkit.org/show_bug.cgi?id=167252
2952
2953         Reviewed by Brent Fulgham.
2954
2955         * Scripts/webkitperl/FeatureList.pm:
2956         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2957
2958 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2959
2960         Build Fix for Windows DumpRenderTree after r210976
2961
2962         * DumpRenderTree/win/DumpRenderTree.cpp:
2963         (resetWebPreferencesToConsistentValues):
2964
2965 2017-01-20  Antoine Quint  <graouts@apple.com>
2966
2967         Web Animations should be off by default and enabled as an experimental feature
2968         https://bugs.webkit.org/show_bug.cgi?id=167115
2969         <rdar://problem/30048963>
2970
2971         Reviewed by Joseph Pecoraro.
2972
2973         Turn Web Animations on in DRT.
2974
2975         * DumpRenderTree/mac/DumpRenderTree.mm:
2976         (resetWebPreferencesToConsistentValues):
2977         * DumpRenderTree/win/DumpRenderTree.cpp:
2978         (resetWebPreferencesToConsistentValues):
2979
2980 2017-01-20  Youenn Fablet  <youenn@apple.com>
2981
2982         [WebRTC] Add libwebrtc build infrastructure
2983         https://bugs.webkit.org/show_bug.cgi?id=167207
2984
2985         Reviewed by Alex Christensen.
2986
2987         Adding a script doing the libwebrtc project json to CMake file conversion.
2988
2989         * Scripts/generate-libwebrtc-cmake: Added.
2990         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2991         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2992
2993 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2994
2995         Mini Browser: Show tooltip for Experimental Features
2996         https://bugs.webkit.org/show_bug.cgi?id=167225
2997
2998         Reviewed by Alex Christensen.
2999
3000         * MiniBrowser/mac/SettingsController.m:
3001         (-[SettingsController _populateMenu]):
3002         Include the full details string as a tooltip.
3003
3004 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3005
3006         [Win] Test output results should not be written twice.
3007         https://bugs.webkit.org/show_bug.cgi?id=167197
3008
3009         Reviewed by Brent Fulgham.
3010
3011         Prevent test output from being written twice by returning early from
3012         the dump() function, if it already has been called.
3013         This patch also adds a missing newline to a test output line. 
3014         
3015         * DumpRenderTree/win/DumpRenderTree.cpp:
3016         (dump):
3017
3018 2017-01-20  Antoine Quint  <graouts@apple.com>
3019
3020         [Modern Media Controls] Turn modern media controls on by default
3021         https://bugs.webkit.org/show_bug.cgi?id=165668
3022
3023         Reviewed by Dean Jackson.
3024
3025         Enabled modern media controls by default in test runners.
3026
3027         * DumpRenderTree/TestOptions.h:
3028         * WebKitTestRunner/TestOptions.h:
3029
3030 2017-01-19  Chris Dumez  <cdumez@apple.com>
3031
3032         iterable<> should be enabled on WK1
3033         https://bugs.webkit.org/show_bug.cgi?id=167221
3034         <rdar://problem/30108531>
3035
3036         Reviewed by Youenn Fablet.
3037
3038         * DumpRenderTree/mac/DumpRenderTree.mm:
3039         (resetWebPreferencesToConsistentValues):
3040         * DumpRenderTree/win/DumpRenderTree.cpp:
3041         (resetWebPreferencesToConsistentValues):
3042         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3043         (WTR::InjectedBundle::beginTesting):
3044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3045         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3046         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3047
3048 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3049
3050         Ensure status server logs go to log file
3051         https://bugs.webkit.org/show_bug.cgi?id=167210
3052
3053         Reviewed by Alexey Proskuryakov.
3054
3055         * Scripts/webkitpy/common/net/statusserver.py:
3056         (StatusServer.next_work_item): Change log level from debug to info in
3057         order to facilitate deubgging issues.
3058         (StatusServer.update_work_items): Same.
3059
3060 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3061
3062         Additional selection tests and interpolation fix
3063         https://bugs.webkit.org/show_bug.cgi?id=167171
3064
3065         Reviewed by Simon Fraser.
3066
3067         We weren't adding the final event when interpolating event streams.
3068
3069         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3070         (-[HIDEventGenerator interpolatedEvents:]):
3071
3072 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3073
3074         [Cocoa] Variation fonts are erroneously disabled on iOS
3075         https://bugs.webkit.org/show_bug.cgi?id=167172
3076
3077         Reviewed by Simon Fraser.
3078
3079         OpenSource builders don't seem to understand sdk=embedded*.
3080
3081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3082
3083 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3084
3085         Unreviewed. Fix GTK+ unit tests failing since r210531.
3086
3087         Avoid using paths to files that don't actually exist.
3088
3089         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3090         (testWebKitConsoleMessageNetworkError):
3091         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3092         (testContextMenuDefaultMenu):
3093         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3094         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3095         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3096
3097 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3098
3099         [GTK] Provide API to set proxy settings
3100         https://bugs.webkit.org/show_bug.cgi?id=128674
3101
3102         Reviewed by Michael Catanzaro.
3103
3104         Add tests for new proxy settings API.
3105
3106         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3107         (serverCallback):
3108         (ProxyTest::ProxyTest):
3109         (ProxyTest::~ProxyTest):
3110         (ProxyTest::loadURIAndGetMainResourceData):
3111         (ProxyTest::proxyServerPortAsString):
3112         (testWebContextProxySettings):
3113         (beforeAll):
3114
3115 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3116
3117         Add back my old email address so old commits will still match it.
3118
3119         * Scripts/webkitpy/common/config/contributors.json:
3120
3121 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3122
3123         Remove my old email address from contributors.json and watchlist.
3124
3125         * Scripts/validate-committer-lists:
3126         (CommitterListFromGit): Change the mapping to the correct email.
3127         * Scripts/webkitpy/common/config/contributors.json:
3128         * Scripts/webkitpy/common/config/watchlist:
3129
3130 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3131
3132         Unreviewed, rolling out r210848.
3133
3134         This change introduced media-related LayoutTest failures and
3135         crashes on macOS.
3136
3137         Reverted changeset:
3138
3139         "[Modern Media Controls] Turn modern media controls on by
3140         default"
3141         https://bugs.webkit.org/show_bug.cgi?id=165668
3142         http://trac.webkit.org/changeset/210848
3143
3144 2017-01-18  Andreas Kling  <akling@apple.com>
3145
3146         Document::securityOrigin() should return a reference.
3147         <https://webkit.org/b/167124>
3148
3149         Reviewed by Sam Weinig.
3150
3151         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3152         (TestWebKitAPI::TEST_F):
3153
3154 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3155
3156         [Win] Clipboard tests are flaky.
3157         https://bugs.webkit.org/show_bug.cgi?id=167088
3158
3159         Reviewed by Brent Fulgham.
3160
3161         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3162         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3163
3164         * DumpRenderTree/win/DumpRenderTree.cpp:
3165         (main):
3166
3167 2017-01-18  Antoine Quint  <graouts@apple.com>
3168
3169         [Modern Media Controls] Turn modern media controls on by default
3170         https://bugs.webkit.org/show_bug.cgi?id=165668
3171
3172         Reviewed by Dean Jackson.
3173
3174         Enabled modern media controls by default in test runners. 
3175
3176         * DumpRenderTree/TestOptions.h:
3177         * WebKitTestRunner/TestOptions.h:
3178
3179 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3180
3181         Unreviewed, rolling out r210834
3182         https://bugs.webkit.org/show_bug.cgi?id=165668
3183
3184         It introduced dozens of test timeouts.
3185
3186         Reverted changeset:
3187         "[Modern Media Controls] Turn modern media controls on by default"
3188         https://bugs.webkit.org/show_bug.cgi?id=165668
3189         http://trac.webkit.org/changeset/210834
3190
3191 2017-01-17  Antoine Quint  <graouts@apple.com>
3192
3193         [Modern Media Controls] Turn modern media controls on by default
3194         https://bugs.webkit.org/show_bug.cgi?id=165668
3195
3196         Reviewed by Dean Jackson.
3197
3198         Enabled modern media controls by default in test runners. 
3199
3200         * DumpRenderTree/TestOptions.h:
3201         * WebKitTestRunner/TestOptions.h:
3202
3203 2017-01-17  Chris Dumez  <cdumez@apple.com>
3204
3205         Document title changed twice when setting document.title
3206         https://bugs.webkit.org/show_bug.cgi?id=167065
3207
3208         Reviewed by Darin Adler.
3209
3210         Add WebKit2GTK API test that was written by Michael Catanzaro.
3211
3212         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3213         (testWebViewTitleChange):
3214         (beforeAll):
3215
3216 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3217
3218         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3219         https://bugs.webkit.org/show_bug.cgi?id=116551
3220         <rdar://problem/13949830>
3221
3222         Reviewed by Alex Christensen.
3223
3224         * Scripts/webkitperl/FeatureList.pm:
3225         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3226         that is part of the existing WEB_TIMING feature.
3227
3228         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3229
3230 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3231
3232         'webkit-patch post' no longer works with moved/copied files
3233         https://bugs.webkit.org/show_bug.cgi?id=166914
3234         <rdar://problem/29979707>
3235
3236         Reviewed by Daniel Bates.
3237
3238         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3239         file outputs only the "Index:" line with an empty body.  This workaround
3240         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3241         public email list tracking this bug is below.
3242         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3243         
3244
3245         * Scripts/svn-create-patch:
3246         (generateDiff): Ignore an "Index:" line with an empty body.
3247
3248 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3249
3250         Remove the REQUEST_ANIMATION_FRAME flag
3251         https://bugs.webkit.org/show_bug.cgi?id=156980
3252         <rdar://problem/25906849>
3253
3254         Reviewed by Simon Fraser.
3255
3256         * Scripts/webkitperl/FeatureList.pm:
3257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3258
3259 2017-01-15  Sam Weinig  <sam@webkit.org>
3260
3261         Add the ability to use numbers in makeString()
3262         https://bugs.webkit.org/show_bug.cgi?id=167087
3263
3264         Reviewed by Darin Adler.
3265
3266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3267         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3268         Add tests for StringConcatenate, focusing on new numeric additions.
3269
3270 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3271
3272         Unreviewed, remove stale comment.
3273
3274         This test was fixed by r163173.
3275
3276         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3277
3278 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3279
3280         Annotate large string tests with largeHeap
3281         https://bugs.webkit.org/show_bug.cgi?id=167054
3282
3283         Reviewed by Filip Pizlo.
3284
3285         * Scripts/run-javascriptcore-tests:
3286         * Scripts/run-jsc-stress-tests:
3287
3288 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3289
3290         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3291         https://bugs.webkit.org/show_bug.cgi?id=167043
3292
3293         Reviewed by Darin Adler.
3294
3295         * Scripts/webkitperl/FeatureList.pm:
3296
3297 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3298
3299         Remove ENABLE(DETAILS_ELEMENT) guards
3300         https://bugs.webkit.org/show_bug.cgi?id=167042
3301
3302         Reviewed by Alex Christensen.
3303
3304         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3305
3306 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3307
3308         26 MotionMark performance tests failing
3309         https://bugs.webkit.org/show_bug.cgi?id=166854
3310
3311         Reviewed by Ryosuke Niwa.
3312
3313         Unrelated change. This is the last place that we need to rename Animometer
3314         to MotionMark.
3315
3316         * Scripts/webkitpy/common/config/watchlist:
3317
3318 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3319
3320         run-jsc-benchmarks' echo should have -e option
3321         https://bugs.webkit.org/show_bug.cgi?id=167009
3322
3323         Reviewed by Sam Weinig.
3324
3325         echo requires `-e` option to use escape sequence.
3326         Without it, in some environment (in my Fedora 25), the escape sequence is not
3327         recognized and just dumped as `\c` etc.
3328
3329         * Scripts/run-jsc-benchmarks:
3330
3331 2017-01-12  Chris Dumez  <cdumez@apple.com>
3332
3333         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3334         https://bugs.webkit.org/show_bug.cgi?id=166995
3335
3336         Reviewed by Jer Noble.
3337
3338         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3339         as some people are having trouble building without it.
3340
3341         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3342
3343 2017-01-12  Sam Weinig  <sam@webkit.org>
3344
3345         Add the ability to filter the set of bindings tests you want to run
3346         https://bugs.webkit.org/show_bug.cgi?id=166977
3347
3348         Reviewed by Tim Horton.
3349
3350         Allows doing things like:
3351             run-bindings-tests TestObj* TestCEReactions*
3352         
3353         to run only those tests that match the patterns.
3354
3355         * Scripts/run-bindings-tests:
3356         (main):
3357         Switch to using optparse and pass the remaining args as the filters.
3358
3359         * Scripts/webkitpy/bindings/main.py:
3360         (BindingsTests.__init__):
3361         Store the pattens.
3362
3363         (BindingsTests.test_matches_patterns):
3364         Add helper predicate to determine if a test should be run. When no
3365         patterns are present, all tests should run.
3366
3367         (BindingsTests.run_tests):
3368         Filter tests using the passed in patterns.
3369
3370 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3371
3372         Followup fix after r210503.
3373         https://bugs.webkit.org/show_bug.cgi?id=166887
3374
3375         Reviewed by Alex Christensen.
3376
3377         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3378         duplicated file handle on Windows. This patch fixes the remaining call sites.
3379
3380         * DumpRenderTree/PixelDumpSupport.cpp:
3381         * DumpRenderTree/TestRunner.cpp:
3382         (TestRunner::waitToDumpWatchdogTimerFired):
3383         * DumpRenderTree/TestRunner.h:
3384         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3385         * DumpRenderTree/win/DumpRenderTree.cpp:
3386         * DumpRenderTree/win/DumpRenderTreeWin.h:
3387         * DumpRenderTree/win/TestRunnerWin.cpp:
3388         (TestRunner::setSpellCheckerLoggingEnabled):
3389
3390 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3391
3392         Add committer status for Megan
3393         https://bugs.webkit.org/show_bug.cgi?id=166954
3394
3395         Reviewed by Tim Horton.
3396
3397         Add committer status for Megan Gardner
3398
3399         * Scripts/webkitpy/common/config/contributors.json:
3400
3401 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3402
3403         Unreviewed test fix after r210599.
3404
3405         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3406         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3407
3408 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3409
3410         Unreviewed build fix after r210599.
3411
3412         Add missing files.
3413
3414         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3415         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3416
3417 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3418
3419         File scheme should not allow access of a resource on a different volume.
3420         https://bugs.webkit.org/show_bug.cgi?id=158552
3421         <rdar://problem/15307582>
3422
3423         Reviewed by Alex Christensen.
3424
3425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3426         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3427         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3428
3429 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3430
3431         Unreviewed, rolling out r210571.
3432
3433         This change broke the 32-bit macOS build and caused LayoutTest
3434         failures.
3435
3436         Reverted changeset:
3437
3438         "File scheme should not allow access of a resource on a
3439         different volume."
3440         https://bugs.webkit.org/show_bug.cgi?id=158552
3441         http://trac.webkit.org/changeset/210571
3442
3443 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3444
3445         [GTK] install-dependencies script misses gdb
3446         https://bugs.webkit.org/show_bug.cgi?id=166917
3447
3448         Reviewed by Michael Catanzaro.
3449
3450         gdb is needed for generating the crash logs.
3451
3452         * gtk/install-dependencies:
3453
3454 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3455
3456         [GTK] No way for applications to set notification permissions without waiting for permission request
3457         https://bugs.webkit.org/show_bug.cgi?id=163366
3458
3459         Reviewed by Carlos Garcia Campos.
3460
3461         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3462         (testWebViewNotification):
3463         (setInitialNotificationPermissionsAllowedCallback):
3464         (setInitialNotificationPermissionsDisallowedCallback):
3465         (testWebViewNotificationInitialPermissionAllowed):
3466         (testWebViewNotificationInitialPermissionDisallowed):
3467         (beforeAll):
3468         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3469         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3470         (WebViewTest::WebViewTest):
3471         (WebViewTest::initializeWebView):
3472         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3473
3474 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3475
3476         MobileMiniBrowser tests don't work by default
3477         https://bugs.webkit.org/show_bug.cgi?id=166910
3478
3479         Reviewed by Alex Christensen.
3480
3481         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3482         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3483
3484 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3485
3486         File scheme should not allow access of a resource on a different volume.
3487         https://bugs.webkit.org/show_bug.cgi?id=158552
3488         <rdar://problem/15307582>
3489
3490         Reviewed by Alex Christensen.
3491
3492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3493         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3494         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3495
3496 2017-01-10  Mark Lam  <mark.lam@apple.com>
3497
3498         Reverting run-jsc-stress-tests' $buildType to use string values.
3499         https://bugs.webkit.org/show_bug.cgi?id=166912
3500
3501         Rubber stamped by Filip Pizlo.
3502
3503         This is so that we can test for it in the tests e.g.
3504         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3505
3506         * Scripts/run-jsc-stress-tests:
3507
3508 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3509
3510         Temporarily add back the file removed in r210463 to unbreak internal bots.
3511
3512         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3513
3514 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3515
3516         svn-apply failed to apply a patch (deleting file with svn property)
3517         https://bugs.webkit.org/show_bug.cgi?id=165953
3518
3519         Reviewed by Daniel Bates.
3520
3521         * Scripts/VCSUtils.pm:
3522         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3523         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3524
3525 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3526
3527         Update flakiness dashboard configuration.
3528         https://bugs.webkit.org/show_bug.cgi?id=166869
3529
3530         Reviewed by Alexey Proskuryakov.
3531
3532         * TestResultServer/static-dashboards/builders.jsonp:
3533         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3534
3535 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3536
3537         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3538         https://bugs.webkit.org/show_bug.cgi?id=165232
3539
3540         Unreviewed follow-up patch after r210539 and r210523.
3541
3542         Instead of using that environment variable, the argument
3543         --display-server=xorg should be passed now.
3544
3545         The GTK+ performance bot was the only bot using this, and is
3546         already passing --display-server=xorg after r210539.
3547
3548         * Scripts/webkitpy/port/gtk.py:
3549         (GtkPort._driver_class):
3550
3551 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3552
3553         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3554         https://bugs.webkit.org/show_bug.cgi?id=166872
3555
3556         Reviewed by Michael Catanzaro.
3557
3558         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3559         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3560         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3561         The step RunWebKitTests already has support for it.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/config.json:
3564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3565         (RunGtkAPITests.start):
3566         (RunAndUploadPerfTests.start):
3567         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3568
3569 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3570
3571         Unreviewed, rolling out r210531.
3572
3573         This change broke the 32-bit macOS build and caused LayoutTest
3574         failures.
3575
3576         Reverted changeset:
3577
3578         "File scheme should not allow access of a resource on a
3579         different volume."
3580         https://bugs.webkit.org/show_bug.cgi?id=158552
3581         http://trac.webkit.org/changeset/210531
3582
3583 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3584
3585         File scheme should not allow access of a resource on a different volume.
3586         https://bugs.webkit.org/show_bug.cgi?id=158552
3587         <rdar://problem/15307582>
3588
3589         Reviewed by Alex Christensen.
3590
3591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3592         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3593         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3594
3595 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3596
3597         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3598         https://bugs.webkit.org/show_bug.cgi?id=165232
3599
3600         Reviewed by Michael Catanzaro.
3601
3602         Add a new WaylandDriver to run the tests in the user current wayland session.
3603
3604         Also merge all the configuration options for selecting the display server inside one
3605         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3606
3607         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3608
3609         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3610         (TestRunner._create_driver):
3611         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3612         (parse_args):
3613         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3614         (PerfTestsRunner._parse_args):
3615         * Scripts/webkitpy/port/gtk.py:
3616         (GtkPort.__init__):
3617         (GtkPort._driver_class):
3618         (GtkPort._search_paths):
3619         * Scripts/webkitpy/port/waylanddriver.py: Added.
3620         (WaylandDriver):
3621         (WaylandDriver.check_driver):
3622         (WaylandDriver._setup_environ_for_test):
3623         (WaylandDriver._start):
3624
3625 2017-01-09  Andy Estes  <aestes@apple.com>
3626
3627         [QuickLook] Add a layout test for webkit.org/b/135651
3628         https://bugs.webkit.org/show_bug.cgi?id=166855
3629
3630         Reviewed by Andreas Kling.
3631
3632         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3633         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3634         errors with code WebKitErrorCannotShowURL.
3635         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3636         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3637         not specific to WebKit2 error codes.
3638
3639 2017-01-09  Antoine Quint  <graouts@apple.com>
3640
3641         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3642         https://bugs.webkit.org/show_bug.cgi?id=166837
3643
3644         Reviewed by Alex Christensen.
3645
3646         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3647         the provided value when trying to determine the path to the test file. Failing
3648         that, we use the computed URL or the raw path provided to cover all cases.
3649         
3650         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3651         by applying this patch and seeing the number test failures dramatically reduced
3652         with WK1 due to the option to turn modern media controls off for older media controls
3653         tests.
3654
3655         * DumpRenderTree/DumpRenderTree.h:
3656         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3657         (parseInputLine):
3658         * DumpRenderTree/TestOptions.h:
3659         * DumpRenderTree/TestOptions.mm:
3660         (TestOptions::TestOptions):
3661         * DumpRenderTree/mac/DumpRenderTree.mm:
3662         (runTest):
3663
3664 2017-01-09  Milan Crha  <mcrha@redhat.com>
3665
3666         prepare-ChangeLog: Correct help string for --style option
3667         https://bugs.webkit.org/show_bug.cgi?id=166725
3668
3669         Reviewed by Alexey Proskuryakov.
3670
3671         * Scripts/prepare-ChangeLog:
3672         (main):
3673
3674 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3675
3676         https://bugs.webkit.org/show_bug.cgi?id=166839
3677         Add php7 support for macOS.
3678         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3679
3680         Reviewed by Alexey Proskuryakov.
3681
3682         * Scripts/webkitpy/port/base.py:
3683         (Port._is_darwin_php_version_7):
3684         (Port._debian_php_version):
3685         (Port):
3686         (Port._darwin_php_version):
3687         (Port._apache_config_file_name_for_platform):
3688
3689 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3690
3691         [GTK] Should support key and code properties on keyboard events
3692         https://bugs.webkit.org/show_bug.cgi?id=166759
3693
3694         Reviewed by Carlos Garcia Campos.
3695
3696         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3697         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3698         on tests.
3699
3700 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3701
3702         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3703         https://bugs.webkit.org/show_bug.cgi?id=166760
3704
3705         Reviewed by Darin Adler.
3706
3707         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3708         We can work around that by duplicating and redirecting stdout.
3709
3710         * DumpRenderTree/PixelDumpSupport.cpp:
3711         (dumpWebViewAsPixelsAndCompareWithExpected):
3712         (printPNG):
3713         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3714         (logEventProc):
3715         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3716         (DRTDesktopNotificationPresenter::showDesktopNotification):
3717         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3718         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3719         * DumpRenderTree/win/DumpRenderTree.cpp:
3720         (dumpFrameScrollPosition):
3721         (dumpHistoryItem):
3722         (dumpBackForwardList):
3723         (dump):
3724         (runTest):
3725         (main):
3726         * DumpRenderTree/win/DumpRenderTreeWin.h:
3727         * DumpRenderTree/win/EditingDelegate.cpp:
3728         (EditingDelegate::shouldBeginEditingInDOMRange):
3729         (EditingDelegate::shouldEndEditingInDOMRange):
3730         (EditingDelegate::shouldInsertNode):
3731         (EditingDelegate::shouldInsertText):
3732         (EditingDelegate::shouldDeleteDOMRange):
3733         (EditingDelegate::shouldChangeSelectedDOMRange):
3734         (EditingDelegate::shouldApplyStyle):
3735         (EditingDelegate::shouldChangeTypingStyle):
3736         (EditingDelegate::doPlatformCommand):
3737         (EditingDelegate::webViewDidBeginEditing):
3738         (EditingDelegate::webViewDidChange):
3739         (EditingDelegate::webViewDidEndEditing):
3740         (EditingDelegate::webViewDidChangeTypingStyle):
3741         (EditingDelegate::webViewDidChangeSelection):
3742         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3743         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3744         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3745         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3746         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3747         (FrameLoadDelegate::didCommitLoadForFrame):
3748         (FrameLoadDelegate::didReceiveTitle):
3749         (FrameLoadDelegate::didFinishLoadForFrame):
3750         (FrameLoadDelegate::didFailLoadWithError):
3751         (FrameLoadDelegate::willPerformClientRedirectToURL):
3752         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3753         (FrameLoadDelegate::windowScriptObjectAvailable):
3754         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3755         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3756         (FrameLoadDelegate::didDisplayInsecureContent):
3757         (FrameLoadDelegate::didRunInsecureContent):
3758         (FrameLoadDelegate::webViewProgressFinishedNotification):
3759         * DumpRenderTree/win/HistoryDelegate.cpp:
3760         (HistoryDelegate::didNavigateWithNavigationData):
3761         (HistoryDelegate::didPerformClientRedirectFromURL):
3762         (HistoryDelegate::didPerformServerRedirectFromURL):
3763         (HistoryDelegate::updateHistoryTitle):
3764         (HistoryDelegate::populateVisitedLinksForWebView):
3765         * DumpRenderTree/win/PolicyDelegate.cpp:
3766         (PolicyDelegate::decidePolicyForNavigationAction):
3767         (PolicyDelegate::unableToImplementPolicyWithError):
3768         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3769         (ResourceLoadDelegate::willSendRequest):
3770         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3771         (ResourceLoadDelegate::didReceiveResponse):
3772         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3773         (ResourceLoadDelegate::didFailLoadingWithError):
3774         * DumpRenderTree/win/TestRunnerWin.cpp:
3775         (TestRunner::addDisallowedURL):
3776         (TestRunner::originsWithApplicationCache):
3777         (TestRunner::setStorageDatabaseIdleInterval):
3778         (TestRunner::closeIdleLocalStorageDatabases):
3779         (TestRunner::copyDecodedHostName):
3780         (TestRunner::copyEncodedHostName):
3781         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3782         (TestRunner::isGeolocationProviderActive):
3783         (TestRunner::pathToLocalResource):
3784         (TestRunner::setMockDeviceOrientation):
3785         (TestRunner::setMockGeolocationPosition):
3786         (TestRunner::setMockGeolocationPositionUnavailableError):
3787         (TestRunner::setSpatialNavigationEnabled):
3788         (TestRunner::setAutomaticLinkDetectionEnabled):
3789         (TestRunner::isCommandEnabled):
3790         (TestRunner::authenticateSession):
3791         (TestRunner::addChromeInputField):
3792         (TestRunner::removeChromeInputField):
3793         (TestRunner::focusWebView):
3794         (TestRunner::grantWebNotificationPermission):
3795         (TestRunner::denyWebNotificationPermission):
3796         (TestRunner::removeAllWebNotificationPermissions):
3797         (TestRunner::simulateWebNotificationClick):
3798         (TestRunner::imageCountInGeneralPasteboard):
3799         * DumpRenderTree/win/UIDelegate.cpp:
3800         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3801         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3802         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3803         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3804         (UIDelegate::webViewAddMessageToConsole):
3805         (UIDelegate::exceededDatabaseQuota):
3806         (UIDelegate::setStatusText):
3807         (UIDelegate::didPressMissingPluginButton):
3808
3809 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3810
3811         Add a setting to create editable MiniBrowser windows by default
3812         https://bugs.webkit.org/show_bug.cgi?id=166806
3813
3814         Reviewed by Beth Dakin.
3815
3816         * MiniBrowser/mac/AppDelegate.m:
3817         (-[BrowserAppDelegate createBrowserWindowController:]):
3818         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3819         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3820         * MiniBrowser/mac/SettingsController.h:
3821         * MiniBrowser/mac/SettingsController.m:
3822         (-[SettingsController _populateMenu]):
3823         (-[SettingsController validateMenuItem:]):
3824         (-[SettingsController toggleCreateEditorByDefault:]):
3825         (-[SettingsController createEditorByDefault]):
3826         Add a setting and update the key equivalents accordingly.
3827         Also make sure to make the right kind of window on launch.
3828
3829 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3830
3831         Fix the 32-bit build.
3832
3833         * MiniBrowser/mac/BrowserWindowController.h:
3834         * MiniBrowser/mac/BrowserWindowController.m:
3835
3836 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3837
3838         Fix the 32-bit build.
3839
3840         * MiniBrowser/mac/BrowserWindowController.m:
3841
3842 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3843
3844         Make it possible to drop HTML files on the MiniBrowser icon
3845         https://bugs.webkit.org/show_bug.cgi?id=166802
3846
3847         Reviewed by Simon Fraser.
3848
3849         * MiniBrowser/mac/AppDelegate.m:
3850         (-[BrowserAppDelegate application:openFile:]):
3851         * MiniBrowser/mac/Info.plist:
3852         If you're using an editable window, the usual trick of dropping on the
3853         window doesn't work anymore (it makes an <attachment> instead).
3854
3855 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3856
3857         MiniBrowser window gets smaller each time it is instantiated
3858         https://bugs.webkit.org/show_bug.cgi?id=166807
3859
3860         Reviewed by Andy Estes.
3861
3862         * MiniBrowser/mac/BrowserWindowController.m:
3863         (-[BrowserWindowController windowDidLoad]):
3864         * MiniBrowser/mac/BrowserWindow.xib:
3865         Turn on full-window content view support with IB, instead of waiting
3866         until after the views have been loaded. This seems to resolve the
3867         longstanding ever-shrinking-window problem.
3868
3869 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3870
3871         Add indent/outdent items to MiniBrowser's new format menu
3872         https://bugs.webkit.org/show_bug.cgi?id=166805
3873
3874         Reviewed by Dan Bernstein.
3875
3876         * MiniBrowser/mac/MainMenu.xib:
3877
3878 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3879
3880         Add a stock Format menu to MiniBrowser
3881         https://bugs.webkit.org/show_bug.cgi?id=166804
3882
3883         Reviewed by Andy Estes.
3884
3885         * MiniBrowser/mac/MainMenu.xib:
3886         Many of the features automatically work with editable web views.
3887         However, this seems to expose a bug where none of the font-related features
3888         (Cmd-B, for example) work until the first time the font panel is shown,
3889         per process, which will need to be investigated separately.
3890
3891 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3892
3893         Remove unused applicationWillTerminate methods from MiniBrowser
3894         https://bugs.webkit.org/show_bug.cgi?id=166803
3895
3896         Reviewed by Andy Estes.
3897
3898         * MiniBrowser/mac/AppDelegate.m:
3899         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3900         * MiniBrowser/mac/BrowserWindowController.h:
3901         * MiniBrowser/mac/BrowserWindowController.m:
3902         (-[BrowserWindowController applicationTerminating]): Deleted.
3903         * MiniBrowser/mac/WK1BrowserWindowController.m:
3904         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3905         * MiniBrowser/mac/WK2BrowserWindowController.m:
3906         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3907
3908 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3909
3910         Add the ability to create empty contentEditable windows in MiniBrowser
3911         https://bugs.webkit.org/show_bug.cgi?id=166801
3912
3913         Reviewed by Wenson Hsieh.
3914
3915         * MiniBrowser/mac/AppDelegate.h:
3916         * MiniBrowser/mac/AppDelegate.m:
3917         (-[BrowserAppDelegate createBrowserWindowController:]):
3918         (-[BrowserAppDelegate newWindow:]):
3919         (-[BrowserAppDelegate newEditorWindow:]):
3920         (-[BrowserAppDelegate openDocument:]):
3921         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3922         * MiniBrowser/mac/BrowserWindowController.h:
3923         * MiniBrowser/mac/BrowserWindowController.m:
3924         (-[BrowserWindowController loadHTMLString:]):
3925         (-[BrowserWindowController toggleEditable:]):
3926         * MiniBrowser/mac/MainMenu.xib:
3927         * MiniBrowser/mac/WK1BrowserWindowController.m:
3928         (-[WK1BrowserWindowController awakeFromNib]):
3929         (-[WK1BrowserWindowController loadHTMLString:]):
3930         (-[WK1BrowserWindowController validateMenuItem:]):
3931         (-[WK1BrowserWindowController setEditable:]):
3932         (-[WK1BrowserWindowController updateTitle:]):
3933         * MiniBrowser/mac/WK2BrowserWindowController.m:
3934         (-[WK2BrowserWindowController awakeFromNib]):
3935         (-[WK2BrowserWindowController validateMenuItem:]):
3936         (-[WK2BrowserWindowController setEditable:]):
3937         (-[WK2BrowserWindowController updateTitle:]):
3938         (-[WK2BrowserWindowController loadHTMLString:]):
3939         Merge more functionality from WebEditingTester.
3940         Add two menu items for creating empty editable WebKit1/2 windows.
3941         Add a menu item to the Edit menu to toggle editability on any window.
3942
3943 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3944
3945         Implement find-in-page in MiniBrowser
3946         https://bugs.webkit.org/show_bug.cgi?id=166799
3947
3948         Reviewed by Andy Estes.
3949
3950         * MiniBrowser/mac/BrowserWindow.xib:
3951         * MiniBrowser/mac/BrowserWindowController.h:
3952         * MiniBrowser/mac/BrowserWindowController.m:
3953         (-[BrowserWindowController find:]): Deleted.
3954         * MiniBrowser/mac/MainMenu.xib:
3955         * MiniBrowser/mac/WK1BrowserWindowController.m:
3956         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3957         (-[WK1BrowserWindowController find:]): Deleted.
3958         * MiniBrowser/mac/WK2BrowserWindowController.m:
3959         (-[WK2BrowserWindowController awakeFromNib]):
3960         (-[WK2BrowserWindowController dealloc]):
3961         (-[WK2BrowserWindowController validateMenuItem:]):
3962         (-[WK2BrowserWindowController performTextFinderAction:]):
3963         (-[WK2BrowserWindowController findBarView]):
3964         (-[WK2BrowserWindowController setFindBarView:]):
3965         (-[WK2BrowserWindowController isFindBarVisible]):
3966         (-[WK2BrowserWindowController setFindBarVisible:]):
3967         (-[WK2BrowserWindowController contentView]):
3968         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3969         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3970         (-[WK2BrowserWindowController find:]): Deleted.
3971         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3972         protocol. At first glance, it's pretty broken, but vaguely works.
3973
3974 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3975
3976         Share the implementation of MiniBrowser view hiding functionality
3977         https://bugs.webkit.org/show_bug.cgi?id=166800
3978
3979         Reviewed by Andy Estes.
3980
3981         * MiniBrowser/mac/BrowserWindowController.m:
3982         (-[BrowserWindowController showHideWebView:]):
3983         (-[BrowserWindowController removeReinsertWebView:]):
3984         * MiniBrowser/mac/WK1BrowserWindowController.m:
3985         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3986         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3987         * MiniBrowser/mac/WK2BrowserWindowController.m:
3988         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3989         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3990         Move the implementation of these two things to the shared superclass,
3991         since they don't depend on WebKit-specific things.
3992         Also, there was no reason to retain the (WK)WebView while it was unparented,
3993         as the BrowserWindowController maintains a reference the entire time.
3994
3995 2017-01-06  Andy Estes  <aestes@apple.com>
3996
3997         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3998         https://bugs.webkit.org/show_bug.cgi?id=166789
3999
4000         Reviewed by Alex Christensen.
4001
4002         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4003         * DumpRenderTree/PlatformMac.cmake:
4004         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
4005         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
4006         * DumpRenderTree/mac/DumpRenderTree.mm:
4007         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4008         createXMLStringFromWebArchiveData().
4009         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
4010         * WebKitTestRunner/Configurations/Base.xcconfig:
4011         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
4012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4013         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4014         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4015         createXMLStringFromWebArchiveData().
4016         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
4017         * WebKitTestRunner/PlatformMac.cmake:
4018         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4019         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
4020
4021 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4022
4023         Minor cleanups to IndentOutdentCommand and related code
4024         https://bugs.webkit.org/show_bug.cgi?id=166791
4025
4026         Reviewed by Simon Fraser.
4027
4028         * WebEditingTester/EditingOperations.m:
4029         (editingOperations):
4030         Add the outdent operation to WebEditingTester.
4031
4032 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
4033
4034         Create a plan and a patch files for MotionMark and delete the Animometer's ones
4035         https://bugs.webkit.org/show_bug.cgi?id=166785
4036
4037         Reviewed by Ryosuke Niwa.
4038
4039         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
4040         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
4041
4042 2017-01-06  Antoine Quint  <graouts@apple.com>
4043
4044         Support webkit-test-runner key-value pairs in http tests
4045         https://bugs.webkit.org/show_bug.cgi?id=149812
4046
4047         Reviewed by Alex Christensen.
4048
4049         We pass the absolute path for a test through to WKTR so that we can parse
4050         tests that are running as URLs for webkit-test-runner options.
4051
4052         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4053         (parseInputLine):
4054
4055         Explicitly skip the --absolute-path option in DRT or else we'd crash.
4056
4057         * Scripts/webkitpy/port/driver.py:
4058         (Driver._command_from_driver_input):
4059
4060         Pass the absolute path to the file through the CLI.
4061
4062         * WebKitTestRunner/TestController.cpp:
4063         (WTR::updateTestOptionsFromTestHeader):
4064         (WTR::TestController::testOptionsForTest):
4065         (WTR::parseInputLine):
4066         (WTR::TestController::runTest):
4067         * WebKitTestRunner/TestController.h:
4068
4069 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4070
4071         Warning about unconnectable outlets when opening a MiniBrowser window
4072         https://bugs.webkit.org/show_bug.cgi?id=166756
4073
4074         Reviewed by Dan Bernstein.
4075
4076         * MiniBrowser/mac/BrowserWindow.xib:
4077         When launching MiniBrowser, it says:
4078         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
4079             (MBToolbarItem): missing setter or instance variable
4080         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
4081             (NSButtonCell): missing setter or instance variable.
4082
4083         It looks like someone added the connection from the share button
4084         to the BrowserWindowController three times; only one of the connections
4085         is valid. Remove the other two.
4086
4087 2017-01-05  Keith Rollin  <krollin@apple.com>
4088
4089         Add WebCore::URL::protocolHostAndPort
4090         https://bugs.webkit.org/show_bug.cgi?id=166426
4091
4092         Reviewed by Alex Christensen.
4093
4094         Add test for protocolHostAndPort.
4095
4096         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4097         (TestWebKitAPI::TEST_F):
4098
4099 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
4100
4101         [Win] Archive test result is failing.
4102         https://bugs.webkit.org/show_bug.cgi?id=166720
4103
4104         Reviewed by Alex Christensen.
4105
4106         Deleting the layout test result folder is sometimes failing
4107         on Windows. This is not a critical error.
4108
4109         * BuildSlaveSupport/test-result-archive:
4110         (archiveTestResults):
4111
4112 2017-01-04  Tomas Popela  <tpopela@redhat.com>
4113
4114         [GTK] Minibrowser: Add printing support
4115         https://bugs.webkit.org/show_bug.cgi?id=165298
4116
4117         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
4118         an error during the print, it's printed on the console.
4119
4120         Reviewed by Michael Catanzaro.
4121
4122         * MiniBrowser/gtk/BrowserWindow.c:
4123         (webKitPrintOperationFailedCallback):
4124         (printPage):
4125         (browser_window_init):
4126
4127 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
4128
4129         [css-grid] Fix crash clamping grid lines
4130         https://bugs.webkit.org/show_bug.cgi?id=166637
4131
4132         Reviewed by Darin Adler.
4133
4134         Creates new unit test to verify that the maximum tracks limit
4135         is used in GridPosition too.
4136
4137         * TestWebKitAPI/PlatformEfl.cmake:
4138         * TestWebKitAPI/PlatformGTK.cmake:
4139         * TestWebKitAPI/PlatformWin.cmake:
4140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4141         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
4142         (TestWebKitAPI::TEST):
4143
4144 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4145
4146         Move editing history scripts to WebCore PrivateHeaders
4147         https://bugs.webkit.org/show_bug.cgi?id=166709
4148         <rdar://problem/29876612>
4149
4150         Reviewed by Dan Bernstein.
4151
4152         Update references to editing script files in WebCore that were moved.
4153
4154         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
4155
4156 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4157
4158         Unreviewed, build fix after r210313 part 2
4159         https://bugs.webkit.org/show_bug.cgi?id=166676
4160
4161         Add 'U' suffix.
4162
4163         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4164         (TestWebKitAPI::TEST):
4165         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4166         (TestWebKitAPI::TEST):
4167
4168 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4169
4170         Limit thread name appropriately
4171         https://bugs.webkit.org/show_bug.cgi?id=166676
4172
4173         Reviewed by Sam Weinig.
4174
4175         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4176         (TestWebKitAPI::TEST):
4177         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4178         (TestWebKitAPI::TEST):
4179
4180 2017-01-04  Andy Estes  <aestes@apple.com>
4181
4182         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
4183         https://bugs.webkit.org/show_bug.cgi?id=166696
4184
4185         Reviewed by Tim Horton.
4186
4187         * TestWebKitAPI/PlatformGTK.cmake:
4188         * TestWebKitAPI/PlatformWin.cmake:
4189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4190         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
4191         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
4192         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
4193         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
4194         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
4195         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
4196
4197 2017-01-03  Brian Burg  <bburg@apple.com>
4198
4199         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
4200         https://bugs.webkit.org/show_bug.cgi?id=166003
4201         <rdar://problem/28718990>
4202
4203         Reviewed by Joseph Pecoraro.
4204
4205         Teach run-inspector-generator-tests to generate test output using the platform name
4206         derived from the directory that the test is in. For example, tests in the /generic/
4207         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
4208
4209         * Scripts/webkitpy/inspector/main.py:
4210         (InspectorGeneratorTests.generate_from_json):
4211         (InspectorGeneratorTests.run_tests):
4212         (InspectorGeneratorTests.main):
4213
4214 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
4215
4216         Unreviewed cmake buildfix after r210266.
4217
4218         * DumpRenderTree/PlatformMac.cmake:
4219
4220 2017-01-04  Tim Horton  <timothy_horton@apple.com>
4221
4222         Provide a setting for clients to always prefer low-power WebGL
4223         https://bugs.webkit.org/show_bug.cgi?id=166675
4224         <rdar://problem/29834093>
4225
4226         Reviewed by Dan Bernstein.
4227
4228         * MiniBrowser/mac/Info.plist:
4229         Have MiniBrowser claim to be a modern app that supports
4230         automatic graphics switching. WebKit needs to support automatic
4231         graphics switching, so our test app might as well. Without this
4232         Info.plist parameter, this change has no effect, and bringing up
4233         a WebGL context still brings up the discrete GPU (also true of the
4234         existing web-exposed preferLowPowerToHighPerformance API).
4235
4236 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4237
4238         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
4239         https://bugs.webkit.org/show_bug.cgi?id=166645
4240
4241         Reviewed by Carlos Garcia Campos.
4242
4243         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4244         (TestWebKitAPI::TEST):
4245
4246 2017-01-03  Andy Estes  <aestes@apple.com>
4247
4248         Place all the Cocoa WebCore API tests in the same directory
4249         https://bugs.webkit.org/show_bug.cgi?id=166673
4250
4251         Reviewed by Michael Catanzaro.
4252
4253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4254         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
4255         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
4256         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
4257
4258 2017-01-03  Tim Horton  <timothy_horton@apple.com>
4259
4260         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
4261         https://bugs.webkit.org/show_bug.cgi?id=166450
4262         <rdar://problem/29447824>
4263
4264         Reviewed by Darin Adler.
4265
4266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4267         * DumpRenderTree/TestRunner.cpp:
4268         (TestRunner::staticFunctions):
4269         * DumpRenderTree/mac/TestRunnerMac.mm:
4270         (setSpellCheckerLoggingEnabledCallback):
4271         * DumpRenderTree/win/TestRunnerWin.cpp:
4272         (setSpellCheckerLoggingEnabledCallback):
4273         * DumpRenderTree/mac/DumpRenderTree.mm:
4274         (resetWebViewToConsistentStateBeforeTesting):
4275         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
4276         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
4277         (stringForCorrectionResponse):
4278         (drt_NSSpellChecker_recordResponseToCorrection):
4279         (swizzleNSSpellCheckerMethodsIfNeeded):
4280         (setSpellCheckerLoggingEnabled):
4281       &