Add a comment to make my test from r244139 less mysterious.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2
3         Add a comment to make my test from r244139 less mysterious.
4         https://bugs.webkit.org/show_bug.cgi?id=196744
5
6         As suggested by Darin Adler.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
9         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
10
11 2019-04-17  Chris Dumez  <cdumez@apple.com>
12
13         Remember device orientation permission for the duration of the browsing session
14         https://bugs.webkit.org/show_bug.cgi?id=196992
15         <rdar://problem/49946067>
16
17         Reviewed by Alex Christensen.
18
19         Add API test coverage.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
22         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
23         (TEST):
24
25 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
26
27         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
28         https://bugs.webkit.org/show_bug.cgi?id=196675
29
30         Reviewed by Lucas Forschler.
31
32         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
33         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
34
35 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
36
37         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
38         https://bugs.webkit.org/show_bug.cgi?id=196919
39         <rdar://problem/41630459>
40
41         Reviewed by Tim Horton.
42
43         Add iOS support for several new testing hooks. See below for more detail.
44
45         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
46         (WTR::UIScriptController::isDismissingMenu const):
47
48         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
49         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
50         by UIKit when dismissing the callout bar (i.e. UIMenuController).
51
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::isDismissingMenu const):
55         * TestRunnerShared/UIScriptContext/UIScriptController.h:
56         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
57         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
58         (WTR::InjectedBundle::didReceiveMessageToPage):
59         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
60         (WTR::TestRunner::setAllowedMenuActions):
61
62         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
63         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
64         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
65         against the name of the custom action.
66
67         (WTR::TestRunner::installCustomMenuAction):
68
69         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
70         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
71         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
72         triggered.
73
74         (WTR::TestRunner::performCustomMenuAction):
75
76         Invoked when the custom menu action is triggered.
77
78         * WebKitTestRunner/InjectedBundle/TestRunner.h:
79         * WebKitTestRunner/TestController.cpp:
80         (WTR::TestController::installCustomMenuAction):
81         (WTR::TestController::setAllowedMenuActions):
82         * WebKitTestRunner/TestController.h:
83         * WebKitTestRunner/TestInvocation.cpp:
84         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
85         (WTR::TestInvocation::performCustomMenuAction):
86
87         Add plumbing to call back into the injected bundle when performing the custom action.
88
89         * WebKitTestRunner/TestInvocation.h:
90         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
91         (WTR::TestController::installCustomMenuAction):
92         (WTR::TestController::setAllowedMenuActions):
93         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
94         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
95         (-[TestRunnerWKWebView initWithFrame:configuration:]):
96         (-[TestRunnerWKWebView becomeFirstResponder]):
97         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
98
99         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
100         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
101         in the Mail app on iOS.
102
103         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
104         (-[TestRunnerWKWebView setAllowedMenuActions:]):
105         (-[TestRunnerWKWebView resetCustomMenuAction]):
106         (-[TestRunnerWKWebView performCustomAction:]):
107         (-[TestRunnerWKWebView canPerformAction:withSender:]):
108         (-[TestRunnerWKWebView _willHideMenu]):
109         (-[TestRunnerWKWebView _didHideMenu]):
110         * WebKitTestRunner/ios/TestControllerIOS.mm:
111         (WTR::TestController::platformResetStateToConsistentValues):
112
113         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
114         if specified.
115
116         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
117         (WTR::UIScriptController::isDismissingMenu const):
118
119 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
120
121         Allow sharing from imageSheet on an image document
122         https://bugs.webkit.org/show_bug.cgi?id=196891
123         <rdar://problem/25377386>
124
125         Reviewed by Tim Horton.
126
127         Test to make sure that the correct imageURL is extracted from an image element.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
130         (TestWebKitAPI::TEST):
131
132 2019-04-16  Alex Christensen  <achristensen@webkit.org>
133
134         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
135         https://bugs.webkit.org/show_bug.cgi?id=196995
136
137         Reviewed by Brady Eidson.
138
139         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
140         (TEST):
141
142 2019-04-16  Chris Dumez  <cdumez@apple.com>
143
144         URL set by document.open() is not communicated to the UIProcess
145         https://bugs.webkit.org/show_bug.cgi?id=196941
146         <rdar://problem/49237544>
147
148         Reviewed by Geoff Garen.
149
150         Add API test coverage.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
154         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
155         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
156         (TEST):
157
158 2019-04-16  Commit Queue  <commit-queue@webkit.org>
159
160         Unreviewed, rolling out r244321.
161         https://bugs.webkit.org/show_bug.cgi?id=196968
162
163         Causing all WK2 Debug builds to exit early after Assertion
164         failures. (Requested by ShawnRoberts on #webkit).
165
166         Reverted changeset:
167
168         "URL set by document.open() is not communicated to the
169         UIProcess"
170         https://bugs.webkit.org/show_bug.cgi?id=196941
171         https://trac.webkit.org/changeset/244321
172
173 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
174
175         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
176         https://bugs.webkit.org/show_bug.cgi?id=196948
177
178         Reviewed by Zalan Bujtas.
179
180         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
181         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
182
183 2019-04-15  Chris Dumez  <cdumez@apple.com>
184
185         URL set by document.open() is not communicated to the UIProcess
186         https://bugs.webkit.org/show_bug.cgi?id=196941
187         <rdar://problem/49237544>
188
189         Reviewed by Geoffrey Garen.
190
191         Add API test coverage.
192
193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
194         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
195         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
196         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
197         (TEST):
198
199 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
200
201         Using Tools/Scripts/clean-webkit should not install requests
202         https://bugs.webkit.org/show_bug.cgi?id=196940
203
204         Reviewed by Lucas Forschler.
205
206         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
207         existing, depending on the path autoinstalled is run through.
208         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
209         needed.
210         (Port.configuration_for_upload):
211         (Port.commits_for_upload):
212
213 2019-04-15  Alex Christensen  <achristensen@webkit.org>
214
215         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
216         https://bugs.webkit.org/show_bug.cgi?id=196773
217
218         Reviewed by Jer Noble.
219
220         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
221         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
222         (TEST):
223
224 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
225
226         ews-build should clearly indicate flaky test failures
227         https://bugs.webkit.org/show_bug.cgi?id=196947
228
229         Reviewed by Lucas Forschler.
230
231         * BuildSlaveSupport/ews-build/steps.py:
232         (AnalyzeAPITestsResults.analyzeResults):
233
234 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
235
236         InjectedBundle parameters often need initialization function called before unarchiving
237         https://bugs.webkit.org/show_bug.cgi?id=189709
238         <rdar://problem/44573653>
239
240         Reviewed by Ryosuke Niwa.
241
242         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
243         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
244
245 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
246
247         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
248         https://bugs.webkit.org/show_bug.cgi?id=196681
249
250         Reviewed by Darin Adler.
251
252         Added tests.
253
254         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
255         (WTF_HashSet.RemoveIf):
256         (WTF_HashSet.RemoveIfShrinkToBestSize):
257
258 2019-04-15  John Wilander  <wilander@apple.com>
259
260         Send delayed Ad Click Attribution conversion requests to the click source
261         https://bugs.webkit.org/show_bug.cgi?id=196838
262         <rdar://problem/47650157>
263
264         Reviewed by Chris Dumez and Youenn Fablet.
265
266         This patch adds test infrastructure to override the default behavior in
267         WebKit::NetworkAdClickAttribution.
268
269         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
270         (TestWebKitAPI::TEST):
271         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
272         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
273         (WTR::TestRunner::dumpAdClickAttribution):
274         (WTR::TestRunner::clearAdClickAttribution):
275         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
276         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
277         * WebKitTestRunner/InjectedBundle/TestRunner.h:
278         * WebKitTestRunner/TestController.cpp:
279         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
280         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
281         * WebKitTestRunner/TestController.h:
282         * WebKitTestRunner/TestInvocation.cpp:
283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
284
285 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-app] status-bubble should display position in queue
288         https://bugs.webkit.org/show_bug.cgi?id=196607
289
290         Reviewed by Lucas Forschler.
291
292         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
293         (StatusBubble._build_bubble):
294         (StatusBubble._queue_position): Method to calculate patch's position in queue.
295
296 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
297
298         [ews-build] Do not run clean build by default on EWS builders
299         https://bugs.webkit.org/show_bug.cgi?id=196897
300
301         Reviewed by Lucas Forschler.
302
303         * BuildSlaveSupport/ews-build/steps.py:
304         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
305         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
306         untracked directories like WebKitBuild).
307         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
308         untracked files/directories (like WebKitBuild).
309
310 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
311
312         TestRunner::notifyDone() should be safely reentrant
313         https://bugs.webkit.org/show_bug.cgi?id=196898
314
315         Reviewed by Darin Adler.
316
317         It is currently possible that TestRunner::notifyDone() will call itself, since
318         notifyDone() will force a repaint, which can start executing JavaScript, which
319         may call notifyDone() again. This can lead to test failures and flakiness.
320         Fix this by setting the m_waitToDump flag before calling the dump() method.
321
322         * DumpRenderTree/mac/TestRunnerMac.mm:
323         (TestRunner::notifyDone):
324         (TestRunner::forceImmediateCompletion):
325         * DumpRenderTree/win/TestRunnerWin.cpp:
326         (TestRunner::notifyDone):
327         (TestRunner::forceImmediateCompletion):
328
329 2019-04-15  Philippe Normand  <pnormand@igalia.com>
330
331         [GTK][WPE] Add enable-media websetting
332         https://bugs.webkit.org/show_bug.cgi?id=196863
333
334         Reviewed by Michael Catanzaro.
335
336         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
337         (testWebKitSettings): Add test for the enable-media web-setting.
338
339 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
340
341         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
342         https://bugs.webkit.org/show_bug.cgi?id=196905
343         <rdar://problem/49886096>
344
345         Reviewed by Tim Horton.
346
347         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
348         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
349         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
350         delay timer, we end up with this sequence of events in the problematic (failure) case:
351
352         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
353             ...IPC from UI to web process...
354         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
355             ...IPC from web to UI process...
356         (c) [UI]    Invoke completion handler for script #1
357         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
358             ...IPC from UI to web process...
359         (e) [Web]   Evaluate script #2 in the web process
360         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
361
362         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
363         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
364         #2 is run in step (e).
365
366         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
367         the UI process by waiting on a script message posted by the web process, after attachment updates are
368         dispatched.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
371         (TestWebKitAPI::TEST):
372
373 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
374
375         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
376         https://bugs.webkit.org/show_bug.cgi?id=196909
377
378         Reviewed by Wenson Hsieh.
379
380         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
381         (TestWebKitAPI::TEST):
382
383 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
384
385         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
386         https://bugs.webkit.org/show_bug.cgi?id=196880
387
388         Reviewed by Yusuke Suzuki.
389
390         Add a new function for bytecode cache tests that does not forceDiskCache
391         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
392         test added in this patch, since the code is invalid and therefore won't be
393         cached. It should also be useful for tests that evaluate dynamically
394         generated code.
395
396         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
397         * Scripts/run-jsc-stress-tests:
398
399 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
400
401         Update AudioSession route sharing policy
402         https://bugs.webkit.org/show_bug.cgi?id=196776
403         <rdar://problem/46501611>
404
405         Reviewed by Jer Noble.
406
407         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
408         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
409         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
410         (TestWebKitAPI::TEST):
411
412 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
413
414         [iOS] Software keyboard is shown too frequently on some websites
415         https://bugs.webkit.org/show_bug.cgi?id=195856
416         <rdar://problem/49191395>
417
418         Reviewed by Darin Adler.
419
420         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
421
422         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
423         (WTR::UIScriptController::setHardwareKeyboardAttached):
424         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
425         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
426         (WTR::UIScriptController::setHardwareKeyboardAttached):
427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
428         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
429
430         Additionally link against GraphicsServices in WebKitTestRunner.
431
432         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
433         (WTR::TestController::platformResetStateToConsistentValues):
434         (WTR::UIScriptController::setHardwareKeyboardAttached):
435
436 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
437
438         [GTK][WPE] Fix pacman install-dependencies packages
439         https://bugs.webkit.org/show_bug.cgi?id=196817
440
441         Reviewed by Žan Doberšek.
442         
443         python3-setuptools is called python-setuptools
444         ruby-highline is only available on AUR
445         libv4l-devel is incorporated in v4l-utils
446
447         * gtk/install-dependencies:
448         * wpe/install-dependencies:
449
450 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
451
452         [GTK] REGRESSION(r243860): Many tests failing
453         https://bugs.webkit.org/show_bug.cgi?id=196791
454
455         Reviewed by Joanmarie Diggs.
456
457         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
458         multiple documents and check that accessibility hierarchy is updated after a navigation.
459
460         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
461         (loadChangedCallback):
462         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
463         (AccessibilityTest::AccessibilityTest):
464         (AccessibilityTest::~AccessibilityTest):
465         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
466         (AccessibilityTest::findTestServerApplication):
467         (AccessibilityTest::findDocumentWeb):
468         (AccessibilityTest::findRootObject):
469         (AccessibilityTest::waitUntilChildrenRemoved):
470         (AccessibilityTest::ensureProxy):
471         (testAtspiBasicHierarchy):
472         (beforeAll):
473         (afterAll):
474
475 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-build] Handle bug titles with unicode characters
478         https://bugs.webkit.org/show_bug.cgi?id=196802
479
480         Reviewed by Dewei Zhu.
481
482         * BuildSlaveSupport/ews-build/steps.py:
483         (ValidatePatch._is_bug_closed):
484
485 2019-04-11  Michael Saboff  <msaboff@apple.com>
486
487         Improve the Inline Cache Stats code
488         https://bugs.webkit.org/show_bug.cgi?id=196836
489
490         Reviewed by Saam Barati.
491
492         Added a new script to consolidate and arrange the output of --useICStats option.
493
494         This script merges the output from every group into one large table and sorts it from most common to
495         least common.  It also counts the slow path GetById and PutById variants and then calculates the
496         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
497         Put together, this is useful to see what property accesses are not getting cached.
498
499         * Scripts/ic-stats.py: Added.
500         (ICStats):
501         (ICStats.__init__):
502         (ICStats.parse):
503         (ICStats.dumpStats):
504         (usage):
505
506 2019-04-10  Alex Christensen  <achristensen@webkit.org>
507
508         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
509         https://bugs.webkit.org/show_bug.cgi?id=196809
510         <rdar://49800762>
511
512         Reviewed by Brady Eidson.
513
514         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
515         (TEST):
516
517 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
518
519         requestAnimationFrame should execute before the next frame
520         https://bugs.webkit.org/show_bug.cgi?id=177484
521
522         Reviewed by Simon Fraser.
523
524         Add trace points for the page RenderingUpdate.
525
526         * Tracing/SystemTracePoints.plist:
527
528 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
529
530         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
531         https://bugs.webkit.org/show_bug.cgi?id=196760
532
533         Reviewed by Don Olmstead.
534
535         vswhere.exe has been bundled since Visual Studio 2017 version
536         15.2. We shouldn't download vswhere.exe.
537
538         * Scripts/build-jsc: Do not call update-vswhere.py.
539         * Scripts/build-webkit: Ditto.
540         * Scripts/update-vswhere.py: Removed.
541         * Scripts/webkitdirs.pm:
542         (requireModulesForVSWhere): Deleted.
543         (pickCurrentVisualStudioInstallation): Deleted.
544         (visualStudioInstallDirVSWhere): Return the latest installed VS
545         installation path by using the bundled vswhere.exe.
546         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
547         (visualStudioInstallDirFallback): Removed.
548
549 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
550
551         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
552         https://bugs.webkit.org/show_bug.cgi?id=196780
553
554         Reviewed by Alexey Proskuryakov.
555
556         * BuildSlaveSupport/ews-build/steps.py:
557         * BuildSlaveSupport/ews-build/steps_unittest.py:
558
559 2019-04-10  Alex Christensen  <achristensen@webkit.org>
560
561         Add SPI WKNavigationResponse._downloadAttribute
562         https://bugs.webkit.org/show_bug.cgi?id=196755
563         <rdar://49587365>
564
565         Reviewed by Brady Eidson.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
568         (-[NavigationResponseTestDelegate navigationResponse]):
569         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
570         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
571         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
572         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
573         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
574         (readRequest):
575         (writeResponse):
576         (TEST):
577
578 2019-04-10  Tim Horton  <timothy_horton@apple.com>
579
580         Add modern API for overriding the page's specified viewport configuration
581         https://bugs.webkit.org/show_bug.cgi?id=167734
582         <rdar://problem/30331795>
583
584         Reviewed by Simon Fraser.
585
586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
587         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
588
589 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
590
591         Add support for incremental bytecode cache updates
592         https://bugs.webkit.org/show_bug.cgi?id=195000
593
594         Reviewed by Filip Pizlo.
595
596         Exit when the initial run to generate bytecode fails.
597
598         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
599
600 2019-04-10  Alex Christensen  <achristensen@webkit.org>
601
602         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
603         https://bugs.webkit.org/show_bug.cgi?id=196744
604         <rdar://49415309>
605
606         Reviewed by Chris Dumez.
607
608         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
609         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
610
611 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
612
613         Add a way to opt into modern compatibility mode in layout tests
614         https://bugs.webkit.org/show_bug.cgi?id=196770
615         <rdar://problem/49777550>
616
617         Reviewed by Antoine Quint.
618
619         Add a new test option to enable modern compatibility mode in layout tests.
620
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::updateTestOptionsFromTestHeader):
623         * WebKitTestRunner/TestController.h:
624         * WebKitTestRunner/TestOptions.h:
625         (WTR::TestOptions::hasSameInitializationOptions const):
626         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
627         (WTR::TestController::platformCreateWebView):
628         (WTR::TestController::enableModernCompatibilityMode):
629
630 2019-04-10  Andy Estes  <aestes@apple.com>
631
632         Try to fix the 32-bit watchOS build.
633
634         * TestWebKitAPI/cocoa/TestWKWebView.mm:
635         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
636
637 2019-04-10  Antoine Quint  <graouts@apple.com>
638
639         Enable Pointer Events on watchOS
640         https://bugs.webkit.org/show_bug.cgi?id=196771
641         <rdar://problem/49040909>
642
643         Reviewed by Dean Jackson.
644
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646
647 2019-04-10  Philippe Normand  <pnormand@igalia.com>
648
649         Unreviewed. Fix WPE accessibility tests after r244059.
650
651         We are failing to load the injected bundle due to undefined symbol
652         AccessibilityUIElement::replaceTextInRange().
653
654         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
655         (WTR::AccessibilityUIElement::replaceTextInRange):
656
657 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
658
659         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
660         https://bugs.webkit.org/show_bug.cgi?id=196727
661
662         Reviewed by Fujii Hironori.
663
664         * MiniBrowser/win/WebKitBrowserWindow.cpp:
665         (WebKitBrowserWindow::create):
666
667 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
668
669         [ews-build] Add unit tests for PrintConfiguration
670         https://bugs.webkit.org/show_bug.cgi?id=196752
671
672         Reviewed by Dewei Zhu.
673
674         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
675
676 2019-04-09  Keith Rollin  <krollin@apple.com>
677
678         Unreviewed build maintenance -- update .xcfilelists.
679
680         * DumpRenderTree/DerivedSources-input.xcfilelist:
681         * DumpRenderTree/DerivedSources-output.xcfilelist:
682
683 2019-04-09  Zalan Bujtas  <zalan@apple.com>
684
685         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
686         https://bugs.webkit.org/show_bug.cgi?id=196743
687         <rdar://problem/43897551>
688
689         Reviewed by Tim Horton.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
692         (TEST):
693
694 2019-04-09  Youenn Fablet  <youenn@apple.com>
695
696         Close service worker database on network process suspension
697         https://bugs.webkit.org/show_bug.cgi?id=196623
698         <rdar://problem/48930869>
699
700         Reviewed by Alex Christensen.
701
702         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
703
704 2019-04-09  Daniel Bates  <dabates@apple.com>
705
706         [iPad] Should open popover when the spacebar is pressed
707         https://bugs.webkit.org/show_bug.cgi?id=196360
708         <rdar://problem/49389129>
709
710         Reviewed by Brent Fulgham.
711
712         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
713
714         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
715         (WTR::UIScriptController::isShowingPopover const): Added.
716         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
717         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
719         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
720         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
721         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
722         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
723         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
724         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
725         (WTR::UIScriptController::isShowingPopover const): Added.
726         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
727         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
728         * TestRunnerShared/UIScriptContext/UIScriptController.h:
729         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
730         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
731         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
732         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
733         (-[TestRunnerWKWebView _willPresentPopover]): Added.
734         (-[TestRunnerWKWebView _didDismissPopover]): Added.
735         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
736         (WTR::UIScriptController::isShowingPopover const): Added.
737         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
738         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
739
740 2019-04-09  Alex Christensen  <achristensen@webkit.org>
741
742         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
743         https://bugs.webkit.org/show_bug.cgi?id=196665
744         <rdar://45115669>
745
746         Reviewed by Geoff Garen.
747
748         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
749         (goBack):
750         (+[SimpleLookupContext sharedLookupContext]):
751         (-[SimpleLookupContext lookUpURL:completionHandler:]):
752         (TEST):
753         (+[Simple3LookupContext sharedLookupContext]): Deleted.
754         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
755
756 2019-04-09  John Wilander  <wilander@apple.com>
757
758         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
759         https://bugs.webkit.org/show_bug.cgi?id=196558
760         <rdar://problem/47650245>
761
762         Reviewed by Youenn Fablet.
763
764         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
765         (TestWebKitAPI::TEST):
766             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
767
768 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
769
770         [CMake] Apple builds should use ICU_INCLUDE_DIRS
771         https://bugs.webkit.org/show_bug.cgi?id=196720
772
773         Reviewed by Konstantin Tokarev.
774
775         * TestWebKitAPI/PlatformMac.cmake:
776
777 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
778
779         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
780         https://bugs.webkit.org/show_bug.cgi?id=196694
781         <rdar://problem/48388734>
782
783         Rubber-stamped by Aakash Jain.
784
785         * Scripts/webkitpy/port/image_diff.py:
786         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
787         * Scripts/webkitpy/port/server_process.py:
788         (ServerProcess.has_available_stdout): Check if stdout has data in it.
789         (ServerProcess._wait_for_data_and_update_buffers_using_select):
790         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
791         * Scripts/webkitpy/port/server_process_mock.py:
792         (MockServerProcess.has_available_stdout):
793         * Scripts/webkitpy/port/server_process_unittest.py:
794         (TestServerProcess.serial_test_basic):
795
796 2019-04-09  Jer Noble  <jer.noble@apple.com>
797
798         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
799         https://bugs.webkit.org/show_bug.cgi?id=196097
800
801         Reviewed by Eric Carlson.
802
803         Drive-by bug fix: allow tests to play audio without a user gesture by default.
804
805         * DumpRenderTree/mac/DumpRenderTree.mm:
806         (resetWebPreferencesToConsistentValues):
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::resetPreferencesToConsistentValues):
809
810 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
811
812         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
813         https://bugs.webkit.org/show_bug.cgi?id=196690
814
815         Reviewed by Michael Catanzaro.
816
817         * QueueStatusServer/config/queues.py:
818         * Scripts/webkitpy/common/config/ews.json:
819         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
820         (test_ews_name):
821
822 2019-04-09  Chris Dumez  <cdumez@apple.com>
823
824         Loads using loadHTMLString() cause flashing when process-swapping
825         https://bugs.webkit.org/show_bug.cgi?id=196714
826         <rdar://problem/49637354>
827
828         Reviewed by Antti Koivisto.
829
830         Add API test coverage.
831
832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
833
834 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         Unreviewed. Fix ATK accessibility tests after r244059.
837
838         We are failing to load the injected bundle due to undefined symbol
839         AccessibilityUIElement::replaceTextInRange().
840
841         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
842         (WTR::AccessibilityUIElement::replaceTextInRange):
843
844 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
845
846         AX: Support API: accessibilityReplaceRange:withText
847         https://bugs.webkit.org/show_bug.cgi?id=196636
848
849         Unreviewed build fix for Windows port.
850
851         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
852         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
853
854 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
855
856         [CMake][WinCairo] Separate copied headers into different directories
857         https://bugs.webkit.org/show_bug.cgi?id=196655
858
859         Reviewed by Michael Catanzaro.
860
861         * DumpRenderTree/CMakeLists.txt:
862         * MiniBrowser/win/CMakeLists.txt:
863         * TestWebKitAPI/CMakeLists.txt:
864         * TestWebKitAPI/PlatformWin.cmake:
865
866 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
867
868         Log stack-trace for run-webkit-tests when interrupted
869         https://bugs.webkit.org/show_bug.cgi?id=176393
870         <rdar://problem/34262310>
871
872         Reviewed by Lucas Forschler.
873
874         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
875         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
876         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
877         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
878         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
879         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
880         (main): Set handlers to log stack trace on interruption.
881
882 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
883
884         AX: Support API: accessibilityReplaceRange:withText
885         https://bugs.webkit.org/show_bug.cgi?id=196636
886
887         Unreviewed build fix for Windows port.
888
889         * DumpRenderTree/AccessibilityUIElement.cpp:
890         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
891
892 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
893
894         [ews-build] Scripts using Buildbot API have CORS error
895         https://bugs.webkit.org/show_bug.cgi?id=196709
896
897         Reviewed by Alexey Proskuryakov.
898
899         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
900
901 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
902
903         AX: Support API: accessibilityReplaceRange:withText
904         https://bugs.webkit.org/show_bug.cgi?id=196636
905
906         Reviewed by Daniel Bates.
907
908         * DumpRenderTree/AccessibilityUIElement.cpp:
909         (replaceTextInRangeCallback):
910         (AccessibilityUIElement::replaceTextInRange):
911         (AccessibilityUIElement::getJSClass):
912         * DumpRenderTree/AccessibilityUIElement.h:
913         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
914         (AccessibilityUIElement::replaceTextInRange):
915         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
916         (AccessibilityUIElement::replaceTextInRange):
917         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
918         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
919         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
920         (WTR::AccessibilityUIElement::replaceTextInRange):
921         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
922         (WTR::AccessibilityUIElement::replaceTextInRange):
923
924 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
925
926         [iOS] Do not allow starting selection drags when selection views are not visible
927         https://bugs.webkit.org/show_bug.cgi?id=196686
928         <rdar://problem/49399192>
929
930         Reviewed by Tim Horton.
931
932         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
933         also add some new API tests to cover scenarios where the web view is not first responder.
934
935         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
936         (TestWebKitAPI::TEST):
937         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
938
939         Add a switch to optionally make the web view first responder when starting the simulated drag.
940
941         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
942         (-[DragAndDropSimulator initWithWebView:]):
943         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
944
945 2019-04-08  Justin Fan  <justin_fan@apple.com>
946
947         [Web GPU] Fix Web GPU experimental feature on iOS
948         https://bugs.webkit.org/show_bug.cgi?id=196632
949
950         Reviewed by Myles C. Maxfield.
951
952         Properly make Web GPU available on iOS 11+.
953
954         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
955
956 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-build] Do not upload archive when Compile Fails
959         https://bugs.webkit.org/show_bug.cgi?id=196674
960
961         Reviewed by Alexey Proskuryakov.
962
963         * BuildSlaveSupport/ews-build/factories.py:
964         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
965         * BuildSlaveSupport/ews-build/steps.py:
966         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
967         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
968         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
969
970 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
971
972         Enable DFG on MIPS
973         https://bugs.webkit.org/show_bug.cgi?id=196689
974
975         Reviewed by Žan Doberšek.
976
977         Since the bytecode change, we enabled the baseline JIT on mips in
978         r240432, but DFG is still missing. With this change, all tests are
979         passing on a ci20 board.
980
981         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
982
983 2019-04-08  Philippe Normand  <pnormand@igalia.com>
984
985         [Flatpak] Second run update-webkitwpe-flatpak fails
986         https://bugs.webkit.org/show_bug.cgi?id=192702
987
988         Reviewed by Carlos Garcia Campos.
989
990         * flatpak/flatpakutils.py:
991         (FlatpakObject.flatpak): Fix typo.
992         (FlatpakPackage.install): When installing, also update to the configured remote commit.
993         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
994
995 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
996
997         [GTK][WPE] outlook.live.com displays old-fashioned UI
998         https://bugs.webkit.org/show_bug.cgi?id=196642
999
1000         Reviewed by Carlos Garcia Campos.
1001
1002         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1003         (TestWebKitAPI::TEST): New Mac platform quirk test.
1004
1005 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1006
1007         Unreviewed, rolling out r243956.
1008         https://bugs.webkit.org/show_bug.cgi?id=196688
1009
1010         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1011         by aakashjain on #webkit).
1012
1013         Reverted changeset:
1014
1015         "Clicking "Go Back" from a safe browsing warning from an
1016         iframe should navigate the WKWebView back to the previous
1017         page"
1018         https://bugs.webkit.org/show_bug.cgi?id=196665
1019         https://trac.webkit.org/changeset/243956
1020
1021 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1022
1023         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1024         https://bugs.webkit.org/show_bug.cgi?id=196669
1025
1026         Reviewed by Geoffrey Garen.
1027
1028         Added three new unit tests for WeakHashSet.
1029
1030         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1031         (WTF_WeakPtr.WeakHashSetConstObjects):
1032         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1033         (WTF_WeakPtr.WeakHashSetComputeSize):
1034
1035 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1036
1037         Hide next and previous form control buttons when WKWebView is editable
1038         https://bugs.webkit.org/show_bug.cgi?id=196672
1039         <rdar://problem/35625321>
1040
1041         Reviewed by Tim Horton.
1042
1043         Add a new API test.
1044
1045         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1046         (-[TestWKWebView lastTrailingBarButtonGroup]):
1047         (TestWebKitAPI::TEST):
1048         * TestWebKitAPI/ios/UIKitSPI.h:
1049
1050 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1051
1052         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1053         https://bugs.webkit.org/show_bug.cgi?id=196077
1054         <rdar://problem/49108202>
1055
1056         Reviewed by Chris Dumez.
1057
1058         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1059         on new web view.
1060
1061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1062
1063 2019-04-05  Saam Barati  <sbarati@apple.com>
1064
1065         Make compare-results understand MotionMark
1066         https://bugs.webkit.org/show_bug.cgi?id=196666
1067
1068         Reviewed by Yusuke Suzuki.
1069
1070         * Scripts/compare-results:
1071         (PLT5Results):
1072         (detectMotionMark):
1073         (detectMotionMark1_1):
1074         (motionMarkResults):
1075         (motionMark1_1Results):
1076         (detectBenchmark):
1077         (biggerIsBetter):
1078         (main):
1079
1080 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1081
1082         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1083         https://bugs.webkit.org/show_bug.cgi?id=196665
1084         <rdar://45115669>
1085
1086         Reviewed by Geoff Garen.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1089         (goBack):
1090         (+[SimpleLookupContext sharedLookupContext]):
1091         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1092         (TEST):
1093         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1094         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1095
1096 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1097
1098         [ews-build] Add configuration and architecture for windows builders
1099         https://bugs.webkit.org/show_bug.cgi?id=196660
1100
1101         Reviewed by Lucas Forschler.
1102
1103         * BuildSlaveSupport/ews-build/config.json:
1104
1105 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1106
1107         webkitpy: Don't run subsequent rounds if interrupted
1108         https://bugs.webkit.org/show_bug.cgi?id=196646
1109
1110         Reviewed by Aakash Jain.
1111
1112         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1113         (Manager.run): Bail out if interrupted.
1114
1115 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1116
1117         Test sessionStorage in PSON private browsing mode
1118         https://bugs.webkit.org/show_bug.cgi?id=196561
1119
1120         Reviewed by Alex Christensen.
1121
1122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1123
1124 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1125
1126         Unreviewed, rolling out r243833.
1127         https://bugs.webkit.org/show_bug.cgi?id=196645
1128
1129         This change breaks build of WPE and GTK ports (Requested by
1130         annulen on #webkit).
1131
1132         Reverted changeset:
1133
1134         "[CMake][WTF] Mirror XCode header directories"
1135         https://bugs.webkit.org/show_bug.cgi?id=191662
1136         https://trac.webkit.org/changeset/243833
1137
1138 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1139
1140         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1141         https://bugs.webkit.org/show_bug.cgi?id=196635
1142
1143         Reviewed by Antti Koivisto.
1144         
1145         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1146         for a test to enable async frame scrolling via:
1147             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1148         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1149         
1150         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1151
1152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1153         (WTR::InjectedBundle::beginTesting):
1154         * WebKitTestRunner/TestController.cpp:
1155         (WTR::TestController::resetPreferencesToConsistentValues):
1156
1157 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1158
1159         Use a correct LC_RPATH when building with ASan
1160         https://bugs.webkit.org/show_bug.cgi?id=196576
1161
1162         Reviewed by David Kilzer.
1163
1164         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1165         so that ../Frameworks is checked. This is simpler and more reliable than updating
1166         each SPC service xcconfig.
1167
1168 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1169
1170         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1171         https://bugs.webkit.org/show_bug.cgi?id=196629
1172
1173         Reviewed by Lucas Forschler.
1174
1175         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1176
1177 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1178
1179         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1180         https://bugs.webkit.org/show_bug.cgi?id=196618
1181
1182         Reviewed by Lucas Forschler.
1183
1184         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1185         (StatusBubble): Added QUEUE_TRIGGERS.
1186         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1187         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1188         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1189         its parent(builder).
1190
1191 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1192
1193         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1194         https://bugs.webkit.org/show_bug.cgi?id=196625
1195
1196         Reviewed by Lucas Forschler.
1197
1198         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1199         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1200
1201 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1202
1203         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1204         https://bugs.webkit.org/show_bug.cgi?id=196630
1205
1206         Reviewed by Wenson Hsieh.
1207
1208         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1209
1210 2019-04-04  Youenn Fablet  <youenn@apple.com>
1211
1212         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1213         https://bugs.webkit.org/show_bug.cgi?id=196543
1214
1215         Reviewed by Alex Christensen.
1216
1217         * WebKitTestRunner/TestController.cpp:
1218         (WTR::TestController::generatePageConfiguration):
1219
1220 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1221
1222         [ews-app] Status bubble should not display skipped buildbot steps
1223         https://bugs.webkit.org/show_bug.cgi?id=196584
1224
1225         Reviewed by Lucas Forschler.
1226
1227         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1228
1229 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1230
1231         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1232         https://bugs.webkit.org/show_bug.cgi?id=196620
1233
1234         Reviewed by Lucas Forschler.
1235
1236         * BuildSlaveSupport/ews-app/ews/config.py:
1237
1238 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1239
1240         [Win] DumpRenderTreeWatchDog.py is not checked into source
1241         https://bugs.webkit.org/show_bug.cgi?id=196567
1242         <rdar://problem/49525901>
1243
1244         Reviewed by Lucas Forschler.
1245
1246         This script is used on Win EWS bots to terminate hanging DRT processes.
1247
1248         * EWSTools/dumprendertreewatchdog.py: Added.
1249
1250 2019-04-04  Chris Dumez  <cdumez@apple.com>
1251
1252         Unreviewed, roll out r243858 which made tests time out.
1253
1254         Disable new API tests on Windows instead.
1255
1256         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1257         (TestWebKitAPI::TEST):
1258
1259 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1260
1261         [ATK] Cleanup WebPageAccessibilityObjectAtk
1262         https://bugs.webkit.org/show_bug.cgi?id=196537
1263
1264         Reviewed by Michael Catanzaro.
1265
1266         Also consider files under atk directories as exceptions for GObject conventions.
1267
1268         * Scripts/webkitpy/style/checkers/cpp.py:
1269         (check_identifier_name_in_declaration):
1270
1271 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1272
1273         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1274         https://bugs.webkit.org/show_bug.cgi?id=196588
1275         <rdar://problem/49365787>
1276
1277         Unreviewed build fix for Windows port.
1278
1279         error C3861: 'kill': identifier not found
1280
1281         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1282         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1283
1284 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-build] Cancel build and similar operations should have authentication
1287         https://bugs.webkit.org/show_bug.cgi?id=196520
1288
1289         Reviewed by Dewei Zhu.
1290
1291         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1292         environment variables.
1293
1294 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1295
1296         [ews-build] Do not trigger queues which are not in production yet
1297         https://bugs.webkit.org/show_bug.cgi?id=196581
1298
1299         Reviewed by Dewei Zhu.
1300
1301         * BuildSlaveSupport/ews-build/config.json:
1302
1303 2019-04-03  Chris Dumez  <cdumez@apple.com>
1304
1305         Unreviewed, fix typo in the name of API test added in r243848.
1306
1307         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1308         (TestWebKitAPI::TEST):
1309
1310 2019-04-03  Chris Dumez  <cdumez@apple.com>
1311
1312         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1313         https://bugs.webkit.org/show_bug.cgi?id=196588
1314         <rdar://problem/49365787>
1315
1316         Reviewed by Ryosuke Niwa.
1317
1318         Add API test coverage.
1319
1320         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1321         (TestWebKitAPI::nullJavaScriptCallback):
1322         (TestWebKitAPI::didCrashCheckFrames):
1323         (TestWebKitAPI::TEST):
1324
1325 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1326
1327         run-webkit-tests: Upload test results (new results database)
1328         https://bugs.webkit.org/show_bug.cgi?id=196577
1329         <rdar://problem/34841155>
1330
1331         Reviewed by Lucas Forschler.
1332
1333         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1334         (Manager.run): Upload results after each device shard, since the configuration will be
1335         different for each device.
1336         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1337         uploaded to a results database.
1338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1339         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1340
1341 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1342
1343         -apple-trailing-word is needed for browser detection
1344         https://bugs.webkit.org/show_bug.cgi?id=196575
1345
1346         Unreviewed.
1347
1348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1349
1350 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1351
1352         [CMake][WTF] Mirror XCode header directories
1353         https://bugs.webkit.org/show_bug.cgi?id=191662
1354
1355         Reviewed by Konstantin Tokarev.
1356
1357         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1358         builds.
1359
1360         * CMakeLists.txt:
1361         * DumpRenderTree/CMakeLists.txt:
1362         * DumpRenderTree/PlatformWin.cmake:
1363         * MiniBrowser/win/CMakeLists.txt:
1364         * TestWebKitAPI/CMakeLists.txt:
1365         * TestWebKitAPI/PlatformWin.cmake:
1366         * WebKitTestRunner/PlatformGTK.cmake:
1367         * WebKitTestRunner/PlatformWin.cmake:
1368
1369 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-app] Status bubble should not display certain infrastructure status messages
1372         https://bugs.webkit.org/show_bug.cgi?id=196550
1373
1374         Reviewed by Lucas Forschler.
1375
1376         Do not display the steps which are un-needed for end-user. This information is still avaiable
1377         if the user click on the bubble and look at the Buildbot build.
1378         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1379         (StatusBubble._steps_messages):
1380         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1381
1382 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1383
1384         [ews-build] Use https for sending data to ews-app
1385         https://bugs.webkit.org/show_bug.cgi?id=196492
1386
1387         Reviewed by Lucas Forschler.
1388
1389         * BuildSlaveSupport/ews-build/events.py:
1390
1391 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1392
1393         Remove support for -apple-trailing-word
1394         https://bugs.webkit.org/show_bug.cgi?id=196525
1395
1396         Reviewed by Zalan Bujtas.
1397
1398         This CSS property is nonstandard and not used.
1399
1400         * Scripts/webkitperl/FeatureList.pm:
1401         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1402
1403 2019-04-03  Youenn Fablet  <youenn@apple.com>
1404
1405         Add a test for DOMCache on multiple browsing in case of private browsing
1406         https://bugs.webkit.org/show_bug.cgi?id=196524
1407
1408         Reviewed by Alex Christensen.
1409
1410         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1411         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1412
1413 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1414
1415         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1416         https://bugs.webkit.org/show_bug.cgi?id=196540
1417
1418         Reviewed by Aakash Jain.
1419
1420         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1421
1422 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1423
1424         Add plumbing for a compatibility mode preference in WebKit
1425         https://bugs.webkit.org/show_bug.cgi?id=196005
1426
1427         Reviewed by Tim Horton.
1428
1429         Add new API tests.
1430
1431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1432         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1433
1434 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1435
1436         [WPE][GTK] Update libsrtp dependency package for Debian
1437         https://bugs.webkit.org/show_bug.cgi?id=196528
1438
1439         Reviewed by Frédéric Wang.
1440
1441         * gtk/install-dependencies:
1442         * wpe/install-dependencies:
1443
1444 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1445
1446         [WK2] Add support for Window's beforeprint / afterprint events
1447         https://bugs.webkit.org/show_bug.cgi?id=196478
1448         <rdar://problem/49535124>
1449
1450         Unreviewed build fix for MSVC.
1451
1452         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1453
1454         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1455
1456         * WebKitTestRunner/TestController.cpp:
1457         (WTR::printFrame): Use int and float literals.
1458
1459 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1460
1461         [ews-build] Reassign bots to queues
1462
1463         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1464
1465 2019-04-02  Chris Dumez  <cdumez@apple.com>
1466
1467         [WK2] Add support for Window's beforeprint / afterprint events
1468         https://bugs.webkit.org/show_bug.cgi?id=196478
1469
1470         Reviewed by Alex Christensen.
1471
1472         Add minimal implementation for printFrame in WebKitTestRunner.
1473
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::printFrame):
1476         (WTR::TestController::createOtherPage):
1477         (WTR::TestController::createWebViewWithOptions):
1478
1479 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1482         https://bugs.webkit.org/show_bug.cgi?id=196491
1483
1484         Reviewed by Lucas Forschler.
1485
1486         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1487
1488 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1489
1490         [ews-build] Configure buildbot try credentials in environment variables
1491         https://bugs.webkit.org/show_bug.cgi?id=196501
1492
1493         Reviewed by Lucas Forschler.
1494
1495         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1496         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1497         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1498
1499 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1500
1501         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1502         https://bugs.webkit.org/show_bug.cgi?id=196496
1503         <rdar://problem/49521634>
1504
1505         Reviewed by Chris Dumez.
1506
1507         Add new API tests (see WebKit ChangeLog for more detail).
1508
1509         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1510         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1511         (TEST):
1512
1513 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1514
1515         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1516         <https://webkit.org/b/196499>
1517
1518         Reviewed by Alexey Proskuryakov.
1519
1520         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1521         ENABLE_ADDRESS_SANITIZER.
1522
1523 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1524
1525         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1526         https://bugs.webkit.org/show_bug.cgi?id=182757
1527
1528         Reviewed by Don Olmstead.
1529
1530         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1531         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1532
1533 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1534
1535         run-api-tests: Upload test results
1536         https://bugs.webkit.org/show_bug.cgi?id=196323
1537         <rdar://problem/49356714>
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * Scripts/webkitpy/api_tests/manager.py:
1542         (Manager):
1543         (Manager.run): Upload results to a results database.
1544         * Scripts/webkitpy/api_tests/run_api_tests.py:
1545         (parse_args): Add upload arguments.
1546         * Scripts/webkitpy/port/base.py:
1547         (Port):
1548         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1549         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1550         with commits from any other associated repositories.
1551         * Scripts/webkitpy/port/device.py:
1552         (Device):
1553         (Device.build_version): Access build_versoin of underlying platform device.
1554         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1555         (IOSSimulatorTest):
1556         (IOSSimulatorTest.test_configuration_for_upload):
1557         * Scripts/webkitpy/port/device_port.py:
1558         (DevicePort):
1559         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1560         the same as the machine uploading results.
1561         * Scripts/webkitpy/port/mac.py:
1562         (MacPort):
1563         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1564         * Scripts/webkitpy/port/mac_unittest.py:
1565         (MacTest):
1566         (MacTest.test_configuration_for_upload):
1567         * Scripts/webkitpy/xcode/simulated_device.py:
1568         (SimulatedDeviceManager._create_device_with_runtime):
1569         (SimulatedDevice.__init__): Create simulated device with a build_version.
1570         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1571         (test_existing_simulator):
1572
1573 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1574
1575         Remove extra newline characters (Follow-up fix to r243707)
1576
1577         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1578
1579 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1580
1581         [ews-app] Use API_KEY to accept results data
1582         https://bugs.webkit.org/show_bug.cgi?id=196461
1583
1584         Reviewed by Dewei Zhu.
1585
1586         * BuildSlaveSupport/ews-app/ews/views/results.py:
1587         (Results.post): Validate EWS_API_KEY before accepting any data.
1588         * BuildSlaveSupport/ews-build/events.py:
1589         (Events.sendData): Send EWS_API_KEY if available along with event data.
1590
1591 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1592
1593         Unable to copy and paste a PDF from Notes into Mail compose body
1594         https://bugs.webkit.org/show_bug.cgi?id=196442
1595         <rdar://problem/48573098>
1596
1597         Reviewed by Tim Horton.
1598
1599         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1600         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1601         to be specified on the item providers.
1602
1603         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1604         (TestWebKitAPI::mapItemForTesting):
1605         (TestWebKitAPI::contactItemForTesting):
1606
1607 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1608
1609         Make UIWKDocumentContext rects per-character instead of per-word
1610         https://bugs.webkit.org/show_bug.cgi?id=196459
1611
1612         Reviewed by Wenson Hsieh.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1615         (TEST):
1616         Adjust test results due to switching to per-character rects.
1617
1618 2019-04-01  Chris Dumez  <cdumez@apple.com>
1619
1620         UIProcess crash when a prewarmed process is terminated
1621         https://bugs.webkit.org/show_bug.cgi?id=196451
1622         <rdar://problem/49245471>
1623
1624         Reviewed by Geoffrey Garen.
1625
1626         Add API test coverage.
1627
1628         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1629         (TEST):
1630
1631 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1634         https://bugs.webkit.org/show_bug.cgi?id=196449
1635
1636         Reviewed by Lucas Forschler.
1637
1638         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1639         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1640         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1641         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1642
1643 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1644
1645         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1646         https://bugs.webkit.org/show_bug.cgi?id=196444
1647
1648         Reviewed by Lucas Forschler.
1649
1650         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1651
1652 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1653
1654         Add SPI to canonicalize NSURLs with WTF::URL
1655         https://bugs.webkit.org/show_bug.cgi?id=196415
1656         <rdar://problem/44980271>
1657
1658         Reviewed by Darin Adler.
1659
1660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1661         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1662         (TestWebKitAPI::TEST):
1663
1664 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1665
1666         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1667         https://bugs.webkit.org/show_bug.cgi?id=196441
1668
1669         Reviewed by Carlos Garcia Campos.
1670
1671         Don't cache the wpe_view_backend object that might not exist yet at the
1672         time of EventSenderProxy constructor invocation, but instead retrieve
1673         that object whenever it's required for event dispatching. This should
1674         avoid crashes in this constructor now that it's invoked before any
1675         PlatformWindow has been set up (as changed in r243496).
1676
1677         * WebKitTestRunner/EventSenderProxy.h:
1678         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1679         (WTR::viewBackend):
1680         (WTR::EventSenderProxy::EventSenderProxy):
1681         (WTR::EventSenderProxy::mouseDown):
1682         (WTR::EventSenderProxy::mouseUp):
1683         (WTR::EventSenderProxy::mouseMoveTo):
1684         (WTR::EventSenderProxy::mouseScrollBy):
1685         (WTR::EventSenderProxy::keyDown):
1686         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1687
1688 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1689
1690         [Win][WebKit] MiniBrowser should support high DPI display
1691         https://bugs.webkit.org/show_bug.cgi?id=196391
1692
1693         Reviewed by Alex Christensen.
1694
1695         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1696         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1697         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1698         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1699
1700 2019-03-31  Sam Weinig  <weinig@apple.com>
1701
1702         Remove more i386 specific configurations
1703         https://bugs.webkit.org/show_bug.cgi?id=196430
1704
1705         Reviewed by Alexey Proskuryakov.
1706
1707         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1708         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1709
1710 2019-03-31  Andy Estes  <aestes@apple.com>
1711
1712         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1713         https://bugs.webkit.org/show_bug.cgi?id=196433
1714         <rdar://problem/49293305>
1715
1716         Reviewed by Tim Horton.
1717
1718         Enhanced API test coverage to include all navigation response policy decisions in both
1719         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1720
1721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1722         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1723         (TestWebKitAPI::TEST):
1724         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1725         (readFile):
1726         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1727         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1728         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1729         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1730         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1731         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1732         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1733         (-[QuickLookDelegate _downloadDidStart:]):
1734         (-[QuickLookDelegate _download:didReceiveResponse:]):
1735         (-[QuickLookDelegate _download:didReceiveData:]):
1736         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1737         (-[QuickLookDelegate _downloadDidFinish:]):
1738         (-[QuickLookDelegate _download:didFailWithError:]):
1739         (-[QuickLookDelegate _downloadDidCancel:]):
1740         (-[QuickLookDelegate verifyDownload]):
1741         (runTest):
1742         (runTestDecideBeforeLoading):
1743         (runTestDecideAfterLoading):
1744         (TEST):
1745         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1746         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1747         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1748         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1749         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1750         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1751         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1752         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1753         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1754         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1755         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1756         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1757         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1758         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1759
1760 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1761
1762         [CMake] add testdfg as target with build-jsc
1763         https://bugs.webkit.org/show_bug.cgi?id=196393
1764
1765         Reviewed by Saam Barati.
1766
1767         Added testdfg as one of the targets to build when
1768         using CMake.
1769
1770         * Scripts/build-jsc:
1771
1772 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1773
1774         Delete WebMetal implementation in favor of WebGPU
1775         https://bugs.webkit.org/show_bug.cgi?id=195418
1776
1777         Reviewed by Dean Jackson.
1778
1779         * DumpRenderTree/mac/DumpRenderTree.mm:
1780         (enableExperimentalFeatures):
1781         (resetWebPreferencesToConsistentValues):
1782         * Scripts/webkitperl/FeatureList.pm:
1783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1785         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1786         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1787         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1788         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1789         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1790         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1791         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1792         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1793         (WTR::InjectedBundle::beginTesting):
1794         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1795         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1796         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1797
1798 2019-03-29  Chris Dumez  <cdumez@apple.com>
1799
1800         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1801         https://bugs.webkit.org/show_bug.cgi?id=196405
1802         <rdar://problem/49428130>
1803
1804         Reviewed by Wenson Hsieh.
1805
1806         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1807         the popover presentation methods to be no-ops. Use this in the new test added in
1808         r243523 so that we do not swizzle those methods for all tests. This is needed because
1809         those WatchOS tests rely on the popover getting presented and interactive.
1810
1811         * WebKitTestRunner/TestController.cpp:
1812         (WTR::updateTestOptionsFromTestHeader):
1813         * WebKitTestRunner/TestController.h:
1814         * WebKitTestRunner/TestOptions.h:
1815         (WTR::TestOptions::hasSameInitializationOptions const):
1816         * WebKitTestRunner/ios/TestControllerIOS.mm:
1817         (WTR::TestController::platformInitialize):
1818         (WTR::TestController::platformResetStateToConsistentValues):
1819
1820 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1821
1822         [Curl] Add Server Trust Evaluation Support.
1823         https://bugs.webkit.org/show_bug.cgi?id=191646
1824
1825         Reviewed by Fujii Hironori.
1826
1827         Implemented MiniBrowser UI for asking if user trusts the server.
1828
1829         * MiniBrowser/win/Common.cpp:
1830         (askServerTrustEvaluation):
1831         (replaceString):
1832         * MiniBrowser/win/Common.h:
1833         * MiniBrowser/win/MiniBrowserLib.rc:
1834         * MiniBrowser/win/MiniBrowserLibResource.h:
1835         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1836         (createPEMString):
1837         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1838         (WebKitBrowserWindow::canTrustServerCertificate):
1839         * MiniBrowser/win/WebKitBrowserWindow.h:
1840
1841 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1842
1843         Implement ResizeObserver.
1844         https://bugs.webkit.org/show_bug.cgi?id=157743
1845
1846         Reviewed by Simon Fraser.
1847
1848         Support resizeObserverEnabled webPreferences.
1849
1850         * DumpRenderTree/TestOptions.cpp:
1851         (TestOptions::TestOptions):
1852         * DumpRenderTree/TestOptions.h:
1853         * DumpRenderTree/mac/DumpRenderTree.mm:
1854         (setWebPreferencesForTestOptions):
1855         * DumpRenderTree/win/DumpRenderTree.cpp:
1856         (enableExperimentalFeatures):
1857         * Scripts/webkitperl/FeatureList.pm:
1858         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1859
1860 2019-03-28  John Wilander  <wilander@apple.com>
1861
1862         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1863         https://bugs.webkit.org/show_bug.cgi?id=196281
1864         <rdar://problem/48938748>
1865
1866         Reviewed by Alex Christensen.
1867
1868         This patch adds the function isStatisticsHasLocalStorage() to the
1869         TestRunner. With it, the page can query the WebsiteDataStore in the
1870         UI process to make sure that it sees LocalStorage.
1871
1872         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1873         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1874         (WTR::TestRunner::isStatisticsHasLocalStorage):
1875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1876         * WebKitTestRunner/TestController.cpp:
1877         (WTR::TestController::isStatisticsHasLocalStorage):
1878         * WebKitTestRunner/TestController.h:
1879         * WebKitTestRunner/TestInvocation.cpp:
1880         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1881
1882 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1883
1884         API::Data::createWithoutCopying should do a null check before calling CFRelease
1885         https://bugs.webkit.org/show_bug.cgi?id=196276
1886         <rdar://problem/48059859>
1887
1888         Reviewed by Alex Christensen.
1889
1890         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1891
1892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1893         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1894         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1895         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1896         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1897         (TestWebKitAPI::TEST):
1898
1899 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1900
1901         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1902         https://bugs.webkit.org/show_bug.cgi?id=186276
1903
1904         Reviewed by Carlos Garcia Campos.
1905
1906         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1907         (webViewLoadChanged):
1908         (testWebResourceGetDataError):
1909         (testWebResourceGetDataEmpty):
1910         (beforeAll):
1911         (webViewloadChanged): Deleted.
1912
1913 2019-03-27  Andy Estes  <aestes@apple.com>
1914
1915         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1916         https://bugs.webkit.org/show_bug.cgi?id=196317
1917
1918         Reviewed by Dan Bernstein.
1919
1920         package-root copies built products into a staging directory using ditto(1), which does not
1921         follow symbolic links as it traverses a directory. Now that the files in
1922         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1923         itself, these become broken links when ditto'd into the staging directory.
1924
1925         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1926
1927         * Scripts/package-root:
1928
1929 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1930
1931         [ews-app] Update display text of Submit for ews analysis
1932         https://bugs.webkit.org/show_bug.cgi?id=196309
1933
1934         Reviewed by Dewei Zhu.
1935
1936         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1937
1938 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1939
1940         run-webkit-tests should check for leaks in WebKit processes
1941         <https://webkit.org/b/193772>
1942         <rdar://problem/46526680>
1943
1944         Reviewed by Ryosuke Niwa.
1945
1946         This works by doing the following:
1947         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1948           The list of child processes are returned one per line:
1949           process.name: pid
1950         - Run the "#LIST CHILD PROCESSES" command just before the
1951           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1952           processes on the ServerProcess object.
1953         - When the `--leaks` switch is handled, run check_for_leaks() on
1954           each child process after the main test harness.
1955
1956         * DumpRenderTree/mac/DumpRenderTree.mm:
1957         (handleControlCommand):
1958         - Use strncmp() instead of strcmp().
1959         - Add support for handling "#LIST CHILD PROCESSES" command.
1960
1961         * Scripts/webkitpy/port/base.py:
1962         (Port.check_for_leaks):
1963         * Scripts/webkitpy/port/darwin.py:
1964         (DarwinPort.check_for_leaks):
1965         - Rename redundant 'process_pid' argument to 'process_id'.
1966
1967         * Scripts/webkitpy/port/driver.py:
1968         (Driver.do_post_tests_work):
1969         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1970           longer the only command this sends to WebKitTestRunner.
1971         - If the `--leaks` switch is present, send the
1972           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1973           result using Port.set_webkit_processes().
1974         (Driver._parse_child_processes_output):
1975         - Add helper method to parse list of child process names and
1976           process IDs returned from WebKitTestRunner.
1977
1978         * Scripts/webkitpy/port/ios_device.py:
1979         (IOSDevicePort.check_for_leaks):
1980         - Rename redundant 'process_pid' argument to 'process_id'.
1981
1982         * Scripts/webkitpy/port/leakdetector.py:
1983         (LeakDetector._parse_leaks_output):
1984         - Return early if there is no leaks_output.
1985         (LeakDetector.check_for_leaks):
1986         - Rename redundant 'process_pid' argument to 'process_id'.
1987
1988         * Scripts/webkitpy/port/server_process.py:
1989         (ServerProcess.__init__):
1990         (ServerProcess.child_processes):
1991         (ServerProcess.set_child_processes):
1992         - Add instance variable to Port to store list of child process
1993           names and process IDs returned from WebKitTestRunner.
1994         (ServerProcess._start):
1995         - Clear self._child_processes.
1996         (ServerProcess.stop):
1997         - If self._child_processes is set, call
1998           self._port.check_for_leaks() for each child process.
1999
2000         * Scripts/webkitpy/port/server_process_unittest.py:
2001         (TrivialMockPort.check_for_leaks):
2002         - Rename redundant 'process_pid' argument to 'process_id'.
2003
2004         * Scripts/webkitpy/port/simulator_process.py:
2005         (SimulatorProcess.stop):
2006         - If self._child_processes is set, call
2007           self._port.check_for_leaks() for each child process.
2008
2009         * Scripts/webkitpy/port/watch_device.py:
2010         (WatchDevicePort.check_for_leaks):
2011         - Rename redundant 'process_pid' argument to 'process_id'.
2012
2013         * WebKitTestRunner/TestController.cpp:
2014         (WTR::TestController::dumpResponse):
2015         - Extract method from findAndDumpWorldLeaks() so that it may be
2016           reused by findAndDumpWebKitProcessIdentifiers().
2017         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2018         - Add method to output process name and process ID of both the
2019           WebContent and Networking processes.
2020         (WTR::TestController::findAndDumpWorldLeaks):
2021         - Fix missing newline in output when there were no abandoned
2022           documents.
2023         - Call dumpResponse() for extracted code.
2024         (WTR::TestController::handleControlCommand):
2025         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2026         - Use strncmp() instead of strcmp().
2027         - Call findAndDumpWebKitProcessIdentifiers() when
2028           "#LIST CHILD PROCESSES" command is sent.
2029         * WebKitTestRunner/TestController.h:
2030         (WTR::TestController::dumpResponse):
2031         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2032         - Declare methods.
2033
2034 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2035
2036         Unreviewed. Add GLib API test cases after r243434.
2037
2038         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2039         (testWebViewActiveURI):
2040         (serverCallback):
2041         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2042         (sendRequestCallback):
2043
2044 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2045
2046         Geolocation request not complete when watch request was started in a different web process
2047         https://bugs.webkit.org/show_bug.cgi?id=195996
2048
2049         Reviewed by Alex Christensen.
2050
2051         Add a test case.
2052
2053         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2054         (TestWebKitAPI::runJavaScriptAlert):
2055         (TestWebKitAPI::TEST):
2056
2057 2019-03-26  Keith Rollin  <krollin@apple.com>
2058
2059         Update the way generate-xcfilelists returns strings from functions
2060         https://bugs.webkit.org/show_bug.cgi?id=195975
2061         <rdar://problem/49040807>
2062
2063         Reviewed by Dean Jackson.
2064
2065         There are places where generate-xcfilelists executes assignments with
2066         statements like:
2067
2068             FOO=$(some_function)
2069
2070         where "some_function" return a string by echoing it. E.g.
2071
2072             some_function()
2073             {
2074                 echo "Hello, World"
2075             }
2076
2077         This is a common idiom, but it has a problem if "some_function" needs
2078         to call "exit" in an attempt to halt the entire script right then and
2079         there. Since "some_function" is called inside of $(), it's being
2080         executed in a sub-shell. Calling exit in that sub-shell simply exits
2081         that shell; it doesn't not exit the outer shell in which the main part
2082         of the script is still running. As such, the main script keeps
2083         executing when the intent was for the script to halt.
2084
2085         The solution to this is to use a different idiom for returning
2086         strings. The one we now is to pass in the name of the variable to
2087         receive the string result:
2088
2089             some_function()
2090             {
2091                 variable_name=$1
2092                 eval $variable_name ="Hello, World"
2093             }
2094
2095         The call site now looks like
2096
2097             some_function FOO
2098
2099         Because there's no invocation of a sub-shell, some_function can now
2100         call "exit" if it wants to, and the entire script will exit at that
2101         point.
2102
2103         * Scripts/generate-xcfilelists:
2104
2105 2019-03-26  Chris Dumez  <cdumez@apple.com>
2106
2107         Add basic layout test coverage for File Picker on iOS
2108         https://bugs.webkit.org/show_bug.cgi?id=196265
2109
2110         Reviewed by Wenson Hsieh.
2111
2112         Add layout test infrastructure to test the file picker on iOS.
2113
2114         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2115         (WTR::UIScriptController::dismissFilePicker):
2116         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2117         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2118         (WTR::UIScriptController::dismissFilePicker):
2119         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2120         * WebKitTestRunner/TestController.cpp:
2121         (WTR::TestController::createWebViewWithOptions):
2122         (WTR::updateTestOptionsFromTestHeader):
2123         * WebKitTestRunner/TestOptions.h:
2124         (WTR::TestOptions::hasSameInitializationOptions const):
2125         * WebKitTestRunner/ios/TestControllerIOS.mm:
2126         (overridePresentViewController):
2127         (WTR::TestController::platformInitialize):
2128         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2129         (WTR::UIScriptController::dismissFilePicker):
2130
2131 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2132
2133         Implement async paste method on UIWKInteractionViewProtocol
2134         https://bugs.webkit.org/show_bug.cgi?id=196267
2135         <rdar://problem/49236346>
2136
2137         Reviewed by Tim Horton.
2138
2139         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2140         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2141         are now a part of all iOS 12 internal SDKs.
2142
2143         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2144
2145         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2146         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2147
2148         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2149         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2150         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2151         * TestWebKitAPI/ios/UIKitSPI.h:
2152
2153 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2154
2155         [ews-build] Use PostgreSQL for ews.webkit.org database
2156         https://bugs.webkit.org/show_bug.cgi?id=196270
2157
2158         Reviewed by Lucas Forschler.
2159
2160         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2161
2162 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2163
2164         [ews] Reset simctl states on reboot
2165         https://bugs.webkit.org/show_bug.cgi?id=196260
2166
2167         Rubber-stamped by Aakash Jain.
2168
2169         * EWSTools/start-queue-mac.sh:
2170
2171 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2172
2173         [ews-build] Use PostgreSQL for ews-build database
2174         https://bugs.webkit.org/show_bug.cgi?id=196229
2175
2176         Reviewed by Lucas Forschler.
2177
2178         * BuildSlaveSupport/ews-build/master.cfg:
2179
2180 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2181
2182         [ews-build] Get master_hostname dynamically in master.cfg
2183         https://bugs.webkit.org/show_bug.cgi?id=196255
2184
2185         Reviewed by Lucas Forschler.
2186
2187         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2188         send events data in test mode.
2189
2190 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2191
2192         [ews-app] Set db_constraint to False for Foreign Keys
2193         https://bugs.webkit.org/show_bug.cgi?id=196252
2194
2195         Reviewed by Lucas Forschler.
2196
2197         * BuildSlaveSupport/ews-app/ews/models/build.py:
2198         * BuildSlaveSupport/ews-app/ews/models/step.py:
2199
2200 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2201
2202         [ews-build] is_test_mode_enabled should default to True
2203         https://bugs.webkit.org/show_bug.cgi?id=196248
2204
2205         Reviewed by Lucas Forschler.
2206
2207         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2208
2209 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews-app] Add webkitperl to ENABLED_QUEUES
2212         https://bugs.webkit.org/show_bug.cgi?id=196253
2213
2214         Reviewed by Lucas Forschler.
2215
2216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2217
2218 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2219
2220         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2221         https://bugs.webkit.org/show_bug.cgi?id=196211
2222         rdar://problem/49110552
2223
2224         Reviewed by Tim Horton.
2225
2226         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2227         Make sure that EventSenderProxy always exists when running tests. We used to create
2228         it when resetting before the first test, which is a bit too late.
2229
2230         * WebKitTestRunner/TestController.h:
2231         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2232         (WTR::TestController::platformCreateWebView):
2233         (WTR::TestController::platformCreateOtherPage):
2234         (WTR::TestController::finishCreatingPlatformWebView):
2235         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2236         (WTR::PlatformWebView::PlatformWebView):
2237         Moved some code that made NSWindow use NSEvent during web view creation. We may
2238         need to move more if some other case us found, but this is enough for now.
2239
2240 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2241
2242         Unreviewed. Fix typo in GLib geolocation API after r243285.
2243
2244         gelocation -> geolocation.
2245
2246         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2247         (testGeolocationManagerWatchPosition):
2248
2249 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2250
2251         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2252         https://bugs.webkit.org/show_bug.cgi?id=196213
2253
2254         Reviewed by Geoff Garen.
2255
2256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2257         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2258         (credentialWithIdentityAndKeychainPath):
2259         (-[ChallengeDelegate webView:didFinishNavigation:]):
2260         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2261         (TestWebKitAPI::TEST):
2262
2263 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2264
2265         Expected shouldn't assume its contained types are copyable
2266         https://bugs.webkit.org/show_bug.cgi?id=195986
2267
2268         Reviewed by JF Bastien.
2269
2270         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2271         (TestWebKitAPI::NonCopyable::operator== const):
2272         (TestWebKitAPI::NonCopyable::operator!= const):
2273         (TestWebKitAPI::TEST):
2274
2275 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2276
2277         Remove some now-unnecessary dynamic class lookup
2278         https://bugs.webkit.org/show_bug.cgi?id=196237
2279
2280         Reviewed by Simon Fraser.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2283         (makeRequest):
2284         (TEST):
2285
2286 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2287
2288         Unreviewed, rolling out r243450.
2289
2290         AppleWin and WinCairo port builds get broken.
2291
2292         Reverted changeset:
2293
2294         "Add test for fix of #196095"
2295         https://bugs.webkit.org/show_bug.cgi?id=196097
2296         https://trac.webkit.org/changeset/243450
2297
2298 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2299
2300         Unreviewed, rolling out r243465.
2301         https://bugs.webkit.org/show_bug.cgi?id=196226
2302
2303         the test doesn't build (Requested by thorton on #webkit).
2304
2305         Reverted changeset:
2306
2307         "Do not terminate the NetworkProcess if a third party
2308         application sends a NSCredential with a SecIdentityRef"
2309         https://bugs.webkit.org/show_bug.cgi?id=196213
2310         https://trac.webkit.org/changeset/243465
2311
2312 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2313
2314         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2315         https://bugs.webkit.org/show_bug.cgi?id=196213
2316
2317         Reviewed by Geoff Garen.
2318
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2320         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2321         (credentialWithIdentityAndKeychainPath):
2322         (-[ChallengeDelegate webView:didFinishNavigation:]):
2323         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2324         (TestWebKitAPI::TEST):
2325
2326 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Gracefully handle missing patch_id in events
2329         https://bugs.webkit.org/show_bug.cgi?id=196216
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-build/events.py:
2334
2335 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2336
2337         [ews-build] use lz4 compression for improving buildbot performance
2338         https://bugs.webkit.org/show_bug.cgi?id=196155
2339
2340         Reviewed by Lucas Forschler.
2341
2342         * BuildSlaveSupport/ews-build/master.cfg:
2343
2344 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         Pull some API testing helper methods out of TestWKWebView
2347         https://bugs.webkit.org/show_bug.cgi?id=196212
2348
2349         Reviewed by Tim Horton.
2350
2351         Refactor some more API testing utility methods, so that they can be used in
2352         tests that do not use TestWKWebView.
2353
2354         * TestWebKitAPI/cocoa/TestWKWebView.h:
2355         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2356         (-[WKWebView loadTestPageNamed:]):
2357         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2358         (-[WKWebView synchronouslyLoadHTMLString:]):
2359         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2360         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2361         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2362         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2363         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2364
2365 2019-03-25  Jer Noble  <jer.noble@apple.com>
2366
2367         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2368         https://bugs.webkit.org/show_bug.cgi?id=196097
2369
2370         Reviewed by Eric Carlson.
2371
2372         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2373
2374         * DumpRenderTree/mac/DumpRenderTree.mm:
2375         (resetWebPreferencesToConsistentValues):
2376         * WebKitTestRunner/TestController.cpp:
2377         (WTR::TestController::resetPreferencesToConsistentValues):
2378
2379 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2380
2381         Pull IPadUserInterfaceSwizzler out into a separate header file
2382         https://bugs.webkit.org/show_bug.cgi?id=196193
2383
2384         Reviewed by Anders Carlsson.
2385
2386         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2387         be used in other API tests.
2388
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2391         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2392         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2393         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2394         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2395         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2396
2397 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2398
2399         Remove NavigatorContentUtils in WebCore/Modules
2400         https://bugs.webkit.org/show_bug.cgi?id=196070
2401
2402         Reviewed by Alex Christensen.
2403
2404         NavigatorContentUtils was to support the custom scheme spec [1].
2405         However, in WebKit side, no port has supported the feature in
2406         WebKit layer after EFL port was removed. So there has been the
2407         only IDL implementation of the NavigatorContentUtils in WebCore.
2408         So we don't need to keep the implementation in WebCore anymore.
2409
2410         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2411
2412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2413
2414 2019-03-24  Andy Estes  <aestes@apple.com>
2415
2416         [watchOS] Remove unused Proximity Networking code
2417         https://bugs.webkit.org/show_bug.cgi?id=196188
2418
2419         Reviewed by Tim Horton.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2422         (TEST):
2423
2424 2019-03-23  Keith Miller  <keith_miller@apple.com>
2425
2426         Refactor clz/ctz and fix getLSBSet.
2427         https://bugs.webkit.org/show_bug.cgi?id=196162
2428
2429         Reviewed by Saam Barati.
2430
2431         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2432
2433         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2434         (TestWebKitAPI::TEST):
2435
2436 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2437
2438         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2439         https://bugs.webkit.org/show_bug.cgi?id=196143
2440
2441         Reviewed by Michael Catanzaro.
2442
2443         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2444         directories.
2445
2446         * Scripts/webkitpy/style/checkers/cpp.py:
2447         (check_identifier_name_in_declaration):
2448         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2449         (WebKitStyleTest.test_names):
2450
2451 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2452
2453         [Flatpak] Manifest expanding fails for qt WPE extension
2454         https://bugs.webkit.org/show_bug.cgi?id=196148
2455
2456         Reviewed by Alex Christensen.
2457
2458         * flatpak/flatpakutils.py:
2459         (expand_submodules_recurse): The last recurse manifest expand
2460         iteration might lead to a single module so take it into account
2461         and don't try to recurse further.
2462
2463 2019-03-22  Chris Dumez  <cdumez@apple.com>
2464
2465         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2466         https://bugs.webkit.org/show_bug.cgi?id=195348
2467         <rdar://problem/48622090>
2468
2469         Reviewed by Alex Christensen.
2470
2471         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2472         to NO when test.options().shouldIgnoreMetaViewport is false.
2473
2474         * WebKitTestRunner/ios/TestControllerIOS.mm:
2475         (WTR::TestController::platformConfigureViewForTest):
2476
2477 2019-03-22  Chris Dumez  <cdumez@apple.com>
2478
2479         Prewarmed processes should be usable with any website data store
2480         https://bugs.webkit.org/show_bug.cgi?id=196104
2481
2482         Reviewed by Alex Christensen.
2483
2484         Add API test coverage.
2485
2486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2487         (runInitialWarmedProcessUsedTest):
2488         (TEST):
2489
2490 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2491
2492         Back out local changes to Alex's Subversion working directory
2493
2494         They were accidentally committed.
2495
2496         * Scripts/webkitpy/common/system/abstractexecutive.py:
2497         (AbstractExecutive.wait_newest):
2498         * Scripts/webkitpy/common/system/executive.py:
2499         (Executive.running_pids):
2500         * Scripts/webkitpy/common/system/executive_mock.py:
2501         (MockExecutive.running_pids):
2502         * Scripts/webkitpy/common/system/executive_unittest.py:
2503         (ExecutiveTest.serial_test_running_pids):
2504         * Scripts/webkitpy/port/darwin.py:
2505         (DarwinPort.check_for_leaks):
2506         * Scripts/webkitpy/port/leakdetector.py:
2507         (LeakDetector.check_for_leaks):
2508         - This was the hack attached to Bug 193772.
2509
2510         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2511         (+[WebKitTestRunnerEvent mouseLocation]):
2512         - This works around a crash on an internal build.
2513
2514 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2515
2516         Fix the build after r243354
2517         https://bugs.webkit.org/show_bug.cgi?id=196138
2518         <rdar://problem/49145951>
2519
2520         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2521         (TEST):
2522         * TestWebKitAPI/ios/UIKitSPI.h:
2523
2524 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2525
2526         Adopt UIWKDocumentContext
2527         https://bugs.webkit.org/show_bug.cgi?id=196040
2528         <rdar://problem/48642440>
2529
2530         Reviewed by Ryosuke Niwa.
2531
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2534         (makeRequest):
2535         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2536         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2537         (applyStyle):
2538         (TEST):
2539         Add tests for UIWKDocumentContext.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2542         (TEST):
2543         (recursiveFindWKContentView): Deleted.
2544         * TestWebKitAPI/cocoa/TestWKWebView.h:
2545         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2546         (recursiveFindWKContentView):
2547         (-[TestWKWebView wkContentView]):
2548         * TestWebKitAPI/ios/UIKitSPI.h:
2549         Share the WKContentView finding code between tests.
2550
2551 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2552
2553         [iOS WK2] Turn on async overflow scrolling by default
2554         https://bugs.webkit.org/show_bug.cgi?id=196011
2555         rdar://problem/48453859
2556
2557         Reviewed by Antti Koivisto.
2558         
2559         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2560         since so many basic layout tests have different results when compositing is triggered for
2561         overflow.
2562         
2563         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2564
2565         * WebKitTestRunner/TestController.cpp:
2566         (WTR::TestController::resetPreferencesToConsistentValues):
2567
2568 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-build] Retry API test in case of failures
2571         https://bugs.webkit.org/show_bug.cgi?id=196004
2572
2573         Reviewed by Lucas Forschler.
2574
2575         * BuildSlaveSupport/ews-build/steps.py:
2576         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2577         (CompileWebKitToT.doStepIf): Ditto.
2578         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2579         (ReRunAPITests): Re-run API tests.
2580         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2581         (RunAPITestsWithoutPatch): Run API tests without patch.
2582         (RunAPITestsWithoutPatch.doStepIf):
2583         (RunAPITestsWithoutPatch.hideStepIf):
2584         (RunAPITestsWithoutPatch.evaluateCommand):
2585         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2586         (AnalyzeAPITestsResults.start):
2587         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2588         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2589         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2590         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2591
2592 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Update queues configurations
2595         https://bugs.webkit.org/show_bug.cgi?id=196074
2596
2597         Reviewed by Dewei Zhu.
2598
2599         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2600         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2601
2602 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2605         https://bugs.webkit.org/show_bug.cgi?id=195680
2606         <rdar://problem/48903534>
2607
2608         Unreviewed infrastructure fix.
2609
2610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2611         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2612
2613 2019-03-21  Andy Estes  <aestes@apple.com>
2614
2615         [iOS] Apple Pay should be available in documents with no user agent scripts
2616         https://bugs.webkit.org/show_bug.cgi?id=196061
2617         <rdar://problem/48649391>
2618
2619         Reviewed by Brady Eidson.
2620
2621         Added API tests and related infrastructure.
2622
2623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2624         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2625         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2626         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2627         (TestWebKitAPI::TEST):
2628         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2629         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2630         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2631         * TestWebKitAPI/cocoa/TestProtocol.mm:
2632         (-[TestProtocol startLoading]):
2633         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2634         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2635         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2636         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2637
2638 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2639
2640         REGRESSSION (r243297): webkitpy tests broken
2641         https://bugs.webkit.org/show_bug.cgi?id=196108
2642
2643         Reviewed by Aakash Jain.
2644
2645         r243297 updated contributors.json, which broke a few unit tests.
2646
2647         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2648         (IRCCommandTest.test_whois):
2649         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2650
2651 2019-03-21  Chris Dumez  <cdumez@apple.com>
2652
2653         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2654         https://bugs.webkit.org/show_bug.cgi?id=196041
2655         <rdar://problem/49083230>
2656
2657         Reviewed by Alex Christensen.
2658
2659         Add API test coverage.
2660
2661         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2662         (TEST):
2663
2664 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2665
2666         Add SPI to inform applications of WKContentRuleList actions
2667         https://bugs.webkit.org/show_bug.cgi?id=195965
2668         <rdar://problem/42664365>
2669
2670         Reviewed by Geoff Garen.
2671
2672         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2673         (TestWebKitAPI::allActionsForResourceLoad):
2674         (TestWebKitAPI::testRequest):
2675         (TestWebKitAPI::TEST_F):
2676         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2677         (Notification::description):
2678         (Notification::operator== const):
2679         (toVector):
2680         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2681         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2682         (makeContentRuleList):
2683         (TEST):
2684         (makeWarnContentRuleList): Deleted.
2685
2686 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2687
2688         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2689         https://bugs.webkit.org/show_bug.cgi?id=196088
2690
2691         Reviewed by Brian Burg.
2692
2693         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2694         Support checks when only one platform is specified. Also deprecate macosx() and
2695         force the use of macos() instead.
2696
2697         * Scripts/webkitpy/style/checkers/cpp.py:
2698         (check_min_versions_of_wk_api_available):
2699         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2700         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2701
2702 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2703
2704         Update status inactive committers' status to 'contributor'.
2705
2706         * Scripts/webkitpy/common/config/contributors.json:
2707
2708 2019-03-21  Xan Lopez  <xan@igalia.com>
2709
2710         [JSC][x86] Drop support for x87 floating point
2711         https://bugs.webkit.org/show_bug.cgi?id=194853
2712
2713         Reviewed by Don Olmstead.
2714
2715         Force SSE2 on x86/32bit builds.
2716
2717         * Scripts/webkitdirs.pm:
2718         (generateBuildSystemFromCMakeProject):
2719
2720 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2721
2722         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2723         https://bugs.webkit.org/show_bug.cgi?id=196073
2724
2725         Reviewed by Michael Catanzaro.
2726
2727         Add test cases to check functions and constructors with no arguments but receiving user data.
2728
2729         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2730         (checkUserData):
2731         (testJSCFunction):
2732         (fooCreateWithUserData):
2733         (testJSCClass):
2734
2735 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2736
2737         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2738
2739         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2740
2741         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2742
2743 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2744
2745         [GTK][WPE] Add API to provide geolocation information
2746         https://bugs.webkit.org/show_bug.cgi?id=195940
2747
2748         Reviewed by Michael Catanzaro.
2749
2750         Add a new test to check the new API.
2751
2752         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2753         (testGeolocationManagerCurrentPosition):
2754         (testGeolocationManagerWatchPosition):
2755         (beforeAll):
2756         (afterAll):
2757         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2758         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2759         (beforeAll): Ditto.
2760         * TestWebKitAPI/glib/CMakeLists.txt:
2761
2762 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2763
2764         [GLib] Returning G_TYPE_OBJECT from a method does not work
2765         https://bugs.webkit.org/show_bug.cgi?id=195574
2766
2767         Reviewed by Michael Catanzaro.
2768
2769         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2770
2771         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2772         (getGFile):
2773         (getParent):
2774         (createGString):
2775         (getGString):
2776         (getGStringCopyWillRaise):
2777         (getGStringCopy):
2778         (getGStringStr):
2779         (getGStringLen):
2780         (freeGString):
2781         (testJSCClass):
2782
2783 2019-03-20  Saam Barati  <sbarati@apple.com>
2784
2785         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2786         https://bugs.webkit.org/show_bug.cgi?id=195721
2787
2788         Reviewed by Filip Pizlo.
2789
2790         * Scripts/run-javascriptcore-tests:
2791
2792 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2793
2794         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2795         https://bugs.webkit.org/show_bug.cgi?id=196049
2796
2797         Reviewed by Tim Horton.
2798
2799         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2800         overflow scrolling in general, so rename it.
2801
2802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2803
2804 2019-03-20  Daniel Bates  <dabates@apple.com>
2805
2806         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2807         https://bugs.webkit.org/show_bug.cgi?id=196031
2808         <rdar://problem/49078172>
2809
2810         Reviewed by Tim Horton.
2811
2812         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2813         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2814         same code path used when the Done button is pressed to dismiss the <select> picker.
2815
2816         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2817         (TestWebKitAPI::TEST):
2818
2819 2019-03-20  Chris Dumez  <cdumez@apple.com>
2820
2821         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2822         https://bugs.webkit.org/show_bug.cgi?id=196029
2823         <rdar://problem/48954651>
2824
2825         Reviewed by Tim Horton.
2826
2827         Add API test coverage.
2828
2829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2830
2831 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2832
2833         [ews-build] Improve failure summary string for ApplyPatch step
2834         https://bugs.webkit.org/show_bug.cgi?id=195995
2835
2836         Reviewed by Alexey Proskuryakov.
2837
2838         * BuildSlaveSupport/ews-build/steps.py:
2839         (ApplyPatch.getResultSummary): Override getResultSummary.
2840
2841 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2842
2843         AX: Implement support for new meter ARIA role
2844         https://bugs.webkit.org/show_bug.cgi?id=195966
2845
2846         Reviewed by Chris Fleizach.
2847
2848         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2849         to AXLevelIndicator.
2850
2851         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2852
2853 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2854
2855         [WebAuthN] Implement FIDO AppID extension
2856         https://bugs.webkit.org/show_bug.cgi?id=143491
2857         <rdar://problem/48298273>
2858
2859         Reviewed by Brent Fulgham.
2860
2861         Add a test that covers the new flag of convertToU2fSignCommand.
2862
2863         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2864         (TestWebKitAPI::TEST):
2865         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2866         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2867         (TestWebKitAPI::TEST):
2868
2869 2019-03-19  Keith Rollin  <krollin@apple.com>
2870
2871         Add support for more platforms to generate-xcfilelists
2872         https://bugs.webkit.org/show_bug.cgi?id=195977
2873
2874         Reviewed by Alexey Proskuryakov.
2875
2876         generate-xcfilelists incorrectly complains when involved with building
2877         WebKit for iphonesimulator:
2878
2879             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2880             …
2881             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2882
2883         Address this by teaching generate-xcfilelists about more platforms.
2884
2885         * Scripts/generate-xcfilelists:
2886
2887 2019-03-19  John Wilander  <wilander@apple.com>
2888
2889         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2890         https://bugs.webkit.org/show_bug.cgi?id=195923
2891         <rdar://problem/49001272>
2892
2893         Reviewed by Alex Christensen.
2894
2895         This patch does the following to the TestRunner:
2896         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2897         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2898         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2899
2900         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2901         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2902         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2903         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2904         * WebKitTestRunner/TestController.cpp:
2905         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2906         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2907         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2908         * WebKitTestRunner/TestController.h:
2909         * WebKitTestRunner/TestInvocation.cpp:
2910         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2911
2912 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2913
2914         [CMake] Support more clang and gcc sanitizers
2915         https://bugs.webkit.org/show_bug.cgi?id=195956
2916
2917         Reviewed by Michael Catanzaro.
2918
2919         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2920
2921 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2922
2923         [ews-build] Improve summary for PrintConfiguration step
2924         https://bugs.webkit.org/show_bug.cgi?id=195945
2925
2926         Reviewed by Lucas Forschler.
2927
2928         * BuildSlaveSupport/ews-build/steps.py:
2929         (PrintConfiguration.getResultSummary): Override getResultSummary.
2930
2931 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [ews-build] Improve summary for CheckOutSource step
2934         https://bugs.webkit.org/show_bug.cgi?id=195963
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * BuildSlaveSupport/ews-build/steps.py:
2939         (CheckOutSource.getResultSummary):
2940
2941 2019-03-19  Daniel Bates  <dabates@apple.com>
2942
2943         [iOS] Focus not preserved when switching between tabs
2944         https://bugs.webkit.org/show_bug.cgi?id=195820
2945         <rdar://problem/43614450>
2946
2947         Reviewed by Brent Fulgham.
2948
2949         Add tests to ensure that we restore focus when resigning and becoming first responder.
2950
2951         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2952         (TestWebKitAPI::TEST):
2953
2954 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2955
2956         Make WTFLogChannelState and WTFLogLevel enum classes
2957         https://bugs.webkit.org/show_bug.cgi?id=195904
2958
2959         Reviewed by Eric Carlson.
2960
2961         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2962         (TestWebKitAPI::TEST_F):
2963
2964 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2965
2966         [GStreamer][EME] Backported mssdemux protection data crash fix
2967         https://bugs.webkit.org/show_bug.cgi?id=195918
2968
2969         Reviewed by Philippe Normand.
2970
2971         * gstreamer/jhbuild.modules:
2972         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2973
2974 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2975
2976         Unreviewed, rolling out r243132.
2977
2978         Broke GTK build
2979
2980         Reverted changeset:
2981
2982         "Make WTFLogChannelState and WTFLogLevel enum classes"
2983         https://bugs.webkit.org/show_bug.cgi?id=195904
2984         https://trac.webkit.org/changeset/243132
2985
2986 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2987
2988         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2989
2990         * Scripts/webkitdirs.pm:
2991         (builtDylibPathForName): Adjust the shared library name that's changed
2992         with the API version bump in r243073.
2993
2994 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2995
2996         Make WTFLogChannelState and WTFLogLevel enum classes
2997         https://bugs.webkit.org/show_bug.cgi?id=195904
2998
2999         Reviewed by Eric Carlson.
3000
3001         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3002         (TestWebKitAPI::TEST_F):
3003
3004 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3005
3006         Disable flaky test added in r2431100
3007         https://webkit.org/b/195785
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3010         (TestWebKitAPI::TEST):
3011         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3012
3013 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3014
3015         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3016         https://bugs.webkit.org/show_bug.cgi?id=195916
3017
3018         Reviewed by Tim Horton.
3019
3020         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3021         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3022
3023 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3024
3025         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3026
3027         * Scripts/webkitpy/common/config/contributors.json:
3028
3029 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3030
3031         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3032         https://bugs.webkit.org/show_bug.cgi?id=195785
3033
3034         Reviewed by Geoffrey Garen.
3035
3036         * TestWebKitAPI/TCPServer.cpp: Added.
3037         (TestWebKitAPI::TCPServer::TCPServer):
3038         (TestWebKitAPI::TCPServer::~TCPServer):
3039         (TestWebKitAPI::TCPServer::socketBindListen):
3040         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3041         * TestWebKitAPI/TCPServer.h: Added.
3042         (TestWebKitAPI::TCPServer::port const):
3043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3044         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3045         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3046         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3047         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3048         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3049         (TestWebKitAPI::respondSlowly):
3050         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3051         (TestWebKitAPI::downloadAtRate):
3052         (TestWebKitAPI::TEST):
3053
3054 2019-03-18  Saam Barati  <sbarati@apple.com>
3055
3056         Add a plan file for JetStream 2
3057         https://bugs.webkit.org/show_bug.cgi?id=190734
3058
3059         Reviewed by Mark Lam.
3060
3061         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3062
3063 2019-03-18  Chris Dumez  <cdumez@apple.com>
3064
3065         Delay WebProcess launch until a load is triggered in a Web view
3066         https://bugs.webkit.org/show_bug.cgi?id=195758
3067         <rdar://problem/48126013>
3068
3069         Reviewed by Geoff Garen.
3070
3071         Add API test coverage. Also update some existing API tests to not expect
3072         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3073
3074         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3075         (TestWebKitAPI::TEST):
3076         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3077         (TestWebKitAPI::TEST):
3078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3079         (TEST):
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3082         (TEST):
3083         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3084         (TEST):
3085         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3086
3087 2019-03-18  Xan Lopez  <xan@igalia.com>
3088
3089         [CMake] Prevent potential warning when determining $architecture
3090         https://bugs.webkit.org/show_bug.cgi?id=195891
3091
3092         Reviewed by Michael Catanzaro.
3093
3094         It's possible for generateBuildSystemForCMakeProject to be called
3095         before determineArchitecture() is ever called. This will make the
3096         first eq check with $architecture to be bogus (and print a
3097         warning). Change that to an eq check with architecture(), which
3098         implicitly calls determineArchitecture() if needed, and change all
3099         the other similar cases in the method in the same way to prevent
3100         future bugs like this one.
3101
3102         * Scripts/webkitdirs.pm:
3103         (generateBuildSystemFromCMakeProject):
3104
3105 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3106
3107         [WPE] Tarballs generated with “make dist” cannot build documentation
3108         https://bugs.webkit.org/show_bug.cgi?id=195885
3109
3110         Reviewed by Carlos Garcia Campos.
3111
3112         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3113
3114 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3115
3116         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3117         https://bugs.webkit.org/show_bug.cgi?id=195883
3118
3119         Reviewed by Carlos Garcia Campos.
3120
3121         * gtkdoc/gtkdoc.py:
3122         (GTKDoc._run_command): When commands fail to run, include the full command line for
3123         the program invocation and the output it has generated on the standard error stream.
3124
3125 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3126
3127         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3128         https://bugs.webkit.org/show_bug.cgi?id=195786
3129
3130         Reviewed by Philippe Normand.
3131
3132         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3133         * wpe/jhbuild.modules: Ditto.
3134
3135 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3136
3137         [ews-build] Don't run clean builds on EWS builders
3138         https://bugs.webkit.org/show_bug.cgi?id=195851
3139
3140         Reviewed by Geoffrey Garen.
3141
3142         * BuildSlaveSupport/ews-build/factories.py:
3143
3144 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3145
3146         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3147         https://bugs.webkit.org/show_bug.cgi?id=195849
3148
3149         Reviewed by Chris Dumez.
3150
3151         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3152
3153         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3154         (runWebsiteDataStoreCustomPaths):
3155
3156 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3157
3158         webkitpy: Upload test results
3159         https://bugs.webkit.org/show_bug.cgi?id=195755
3160         <rdar://problem/48896182>
3161
3162         Reviewed by Aakash Jain.
3163
3164         Establish a new format for uploading results that is not tied to layout tests, apply
3165         that format to webkitpy tests.
3166
3167         * Scripts/webkitpy/common/checkout/scm/git.py:
3168         (Git.native_branch): Return what branch the current checkout is on.
3169         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3170         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3171         * Scripts/webkitpy/common/checkout/scm/svn.py:
3172         (SVN.native_branch): Ditto.
3173         * Scripts/webkitpy/common/system/platforminfo.py:
3174         (PlatformInfo.build_version): Return a build version for Mac.
3175         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3176         (MockPlatformInfo.__init__):
3177         (MockPlatformInfo.build_version):
3178         * Scripts/webkitpy/results: Added.
3179         * Scripts/webkitpy/results/__init__.py: Added.
3180         * Scripts/webkitpy/results/options.py: Added.
3181         (upload_options): OptParse list for upload options.
3182         * Scripts/webkitpy/results/upload.py: Added.
3183         (Upload): Class which enforces the upload format expected by the results server.
3184         (Upload.Expectations):
3185         (Upload.create_configuration):
3186         (Upload.create_commit):
3187         (Upload.create_details):
3188         (Upload.create_run_stats):
3189         (Upload.create_test_result):
3190         (Upload.__init__):
3191         (Upload.Encoder): Encode Upload object as json.
3192         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3193         * Scripts/webkitpy/results/upload_unittest.py: Added.
3194         * Scripts/webkitpy/test/main.py:
3195         (Tester._parse_args): Add upload arguments.
3196         (Tester._run_tests): Allow results to be uploaded.
3197         * Scripts/webkitpy/test/runner.py:
3198         (Runner.__init__): Record which tests were run, rather than just counting them.
3199         (Runner.handle):
3200         * Scripts/webkitpy/test/runner_unittest.py:
3201         (RunnerTest.test_run):
3202         * Scripts/webkitpy/thirdparty/__init__.py:
3203         (AutoinstallImportHook.find_module): Add requests auto-install.
3204         (AutoinstallImportHook._install_requests):
3205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3206         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3207
3208 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3209
3210         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3211         https://bugs.webkit.org/show_bug.cgi?id=195810
3212
3213         Reviewed by Tim Horton.
3214
3215         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3216         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3217         ending certain layout tests.
3218
3219         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3220         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3221         (-[TestRunnerWKWebView dealloc]):
3222         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3223
3224         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3225         helper method when destroying the web view, and when resetting state between tests.
3226
3227         * WebKitTestRunner/ios/TestControllerIOS.mm:
3228         (WTR::TestController::platformResetStateToConsistentValues):
3229
3230         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3231
3232 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3233
3234         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3235         https://bugs.webkit.org/show_bug.cgi?id=190350
3236         <rdar://problem/45089503>
3237
3238         Reviewed by Geoffrey Garen.
3239
3240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3241         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3242         (TEST):
3243         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3244         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3245         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3246         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3247         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3248         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3249         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3250         (runTest):
3251         (createDirectories):
3252         (TEST):
3253         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3254         (TEST):
3255         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3256         (TEST):
3257
3258 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3259
3260         Add support to WebPage for getting the contents as an attributed string.
3261         https://bugs.webkit.org/show_bug.cgi?id=195636
3262         rdar://problem/45055697
3263
3264         Reviewed by Tim Horton.
3265
3266         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3267         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3268
3269 2019-03-15  Chris Dumez  <cdumez@apple.com>
3270
3271         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3272         https://bugs.webkit.org/show_bug.cgi?id=195747
3273
3274         Reviewed by Geoff Garen.
3275
3276         Add API test coverage.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3279
3280 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3281
3282         Unreviewed, rolling out r242952.
3283
3284         Causing API failures on iOS Simulator
3285
3286         Reverted changeset:
3287
3288         "[PSON] Make sure the WebProcessCache is leverage when
3289         relaunching a process after termination"
3290         https://bugs.webkit.org/show_bug.cgi?id=195747
3291         https://trac.webkit.org/changeset/242952
3292
3293 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3294
3295         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3296         https://bugs.webkit.org/show_bug.cgi?id=195740
3297
3298         Reviewed by Ross Kirsling.
3299
3300         window.open doesn't work for WebKitBrowserWindow because it is not
3301         implemented yet.
3302
3303         1. Implemented createNewPage callback of WKPageUIClient.
3304         2. Changed MainWindow to take a BrowserWindow factory function
3305           instead of BrowserWindowType to be flexible to create
3306           BrowserWindow with extra settings.
3307         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3308           because it is not relevant with MainWindow anymore.
3309
3310         * MiniBrowser/win/Common.cpp:
3311         (parseCommandLine):
3312         * MiniBrowser/win/Common.h:
3313         (CommandLineOptions::CommandLineOptions):
3314         * MiniBrowser/win/MainWindow.cpp:
3315         (MainWindow::MainWindow):
3316         (MainWindow::create):
3317         (MainWindow::init):
3318         (MainWindow::WndProc):
3319         * MiniBrowser/win/MainWindow.h:
3320         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3321         (PrintWebUIDelegate::createWebViewWithRequest):
3322         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3323         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3324         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3325         (WebKitBrowserWindow::updateProxySettings):
3326         (WebKitBrowserWindow::createNewPage):
3327         * MiniBrowser/win/WebKitBrowserWindow.h:
3328         * MiniBrowser/win/WinMain.cpp:
3329         (wWinMain):
3330
3331 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3332
3333         Make it possible to test scrolling tree layer manipulation more easily
3334         https://bugs.webkit.org/show_bug.cgi?id=195780
3335
3336         Reviewed by Tim Horton.
3337         
3338         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3339         cuts off communication of scrolling tree scrolls back to the web process
3340         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3341         allows tests to trigger scrolls which run the scrolling tree layer positioning
3342         logic, but never get another commit from the web process that might mask
3343         scrolling tree bugs.
3344         
3345         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3346         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3347         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3348
3349         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3350         (WTR::UIScriptController::scrollUpdatesDisabled const):
3351         (WTR::UIScriptController::setScrollUpdatesDisabled):
3352         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3353         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3354         (WTR::UIScriptController::scrollUpdatesDisabled const):
3355         (WTR::UIScriptController::setScrollUpdatesDisabled):
3356         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3357         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3358         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3359         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3360         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3361         * WebKitTestRunner/ios/TestControllerIOS.mm:
3362         (WTR::TestController::platformResetStateToConsistentValues):
3363         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3364         (WTR::UIScriptController::scrollUpdatesDisabled const):
3365         (WTR::UIScriptController::setScrollUpdatesDisabled):
3366
3367 2019-03-14  Youenn Fablet  <youenn@apple.com>
3368
3369         Move IDB storage in private browsing mode to NetworkProcess
3370         https://bugs.webkit.org/show_bug.cgi?id=195602
3371
3372         Reviewed by Brady Eidson.
3373
3374         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3375         (TEST):
3376
3377 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3378
3379         [ews-build] Make descriptionDone messages more readable
3380         https://bugs.webkit.org/show_bug.cgi?id=195760
3381
3382         Reviewed by Lucas Forschler.
3383
3384         * BuildSlaveSupport/ews-build/steps.py:
3385         * BuildSlaveSupport/ews-build/steps_unittest.py:
3386
3387 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3388
3389         [ews-build] Generate status-bubble hover-over messages
3390         https://bugs.webkit.org/show_bug.cgi?id=195680
3391
3392         Reviewed by Lucas Forschler.
3393
3394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3395         (StatusBubble):
3396         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3397         on hover-over.
3398         (StatusBubble._iso_time):
3399         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3400         hover-over message.
3401         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3402
3403 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-app] Gracefully handle the case when state_string is None
3406         https://bugs.webkit.org/show_bug.cgi?id=195753
3407
3408         Reviewed by Lucas Forschler.
3409
3410         * BuildSlaveSupport/ews-app/ews/models/build.py:
3411         * BuildSlaveSupport/ews-app/ews/models/step.py:
3412
3413 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3414
3415         [ews-app] Status bubble display pending for currently running build step
3416         https://bugs.webkit.org/show_bug.cgi?id=195744
3417
3418         Reviewed by Lucas Forschler.
3419
3420         * BuildSlaveSupport/ews-build/events.py:
3421         (Events.stepStarted): If state_string is pending, replace it with step name.
3422
3423 2019-03-14  Chris Dumez  <cdumez@apple.com>
3424
3425         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3426         https://bugs.webkit.org/show_bug.cgi?id=195750
3427
3428         Reviewed by Geoffrey Garen.
3429
3430         Add API test coverage.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3433         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3434         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3435         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3436
3437 2019-03-14  Chris Dumez  <cdumez@apple.com>
3438
3439         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3440         https://bugs.webkit.org/show_bug.cgi?id=195747
3441
3442         Reviewed by Geoff Garen.
3443
3444         Add API test coverage.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3447
3448 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3449
3450         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3451         https://bugs.webkit.org/show_bug.cgi?id=195725
3452         <rdar://problem/48545062>
3453
3454         Reviewed by Tim Horton.
3455
3456         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3457         handler is nil.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3460         (TestWebKitAPI::TEST):
3461
3462 2019-03-13  Sam Weinig  <sam@webkit.org>
3463
3464         Add utility function to allow easy reverse range-based iteration of a container
3465         https://bugs.webkit.org/show_bug.cgi?id=195542
3466
3467         Reviewed by Antti Koivisto.
3468
3469         * TestWebKitAPI/CMakeLists.txt:
3470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3471         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3472         (TestWebKitAPI::TEST):
3473         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3474
3475 2019-03-13  Chris Dumez  <cdumez@apple.com>
3476
3477         Use a ServiceWorker process per registrable domain
3478         https://bugs.webkit.org/show_bug.cgi?id=195649
3479
3480         Reviewed by Youenn Fablet.
3481
3482         Update API test coverage.
3483
3484         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3485
3486 2019-03-13  Chris Dumez  <cdumez@apple.com>
3487
3488         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3489         https://bugs.webkit.org/show_bug.cgi?id=195684
3490         <rdar://problem/48294714>
3491
3492         Reviewed by Antti Koivisto.
3493
3494         Add API test coverage.
3495
3496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3497
3498 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-app] Remove unused patch view
3501         https://bugs.webkit.org/show_bug.cgi?id=195669
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-app/ews/urls.py:
3506         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3507
3508 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3509
3510         [ews-app] Use Buildbot result code variables
3511         https://bugs.webkit.org/show_bug.cgi?id=195668
3512
3513         Reviewed by Alexey Proskuryakov.
3514
3515         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3516         (Buildbot): Added Buildbot result code variables.
3517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3518         (StatusBubble._build_bubble): Used Buildbot result code variables.
3519
3520 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3521
3522         [Flatpak] Expand submodule recursively
3523         https://bugs.webkit.org/show_bug.cgi?id=195672
3524
3525         Building WPE with flatpak was impossible without that as it was raising an exception.
3526         Also update wpebackend-fdo to match what is built in jhbuild
3527
3528         Reviewed by Philippe Normand.
3529
3530         * flatpak/flatpakutils.py:
3531         (expand_submodules_recurse):
3532         (expand_manifest):
3533         * flatpak/org.webkit.WPEModules.yaml:
3534
3535 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3536
3537         [ews-app] status bubble should be hidden for certain builds
3538         https://bugs.webkit.org/show_bug.cgi?id=194597
3539
3540         Reviewed by Dewei Zhu.
3541
3542         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3543         (StatusBubble._build_bubble):
3544         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3545         because the patch didn't have relevant changes.
3546         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3547         in production yet.
3548
3549 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3550
3551         [Win] Fix a slew of simple clang-cl warnings.
3552         https://bugs.webkit.org/show_bug.cgi?id=195652
3553
3554         Reviewed by Don Olmstead.
3555
3556         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3557         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3558
3559 2019-03-12  Justin Fan  <justin_fan@apple.com>
3560
3561         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3562         https://bugs.webkit.org/show_bug.cgi?id=195518
3563         <rdar://problem/46322356>
3564
3565         Reviewed by Myles C. Maxfield.
3566
3567         * DumpRenderTree/DerivedSources-input.xcfilelist:
3568         * DumpRenderTree/DerivedSources-output.xcfilelist:
3569
3570 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3571
3572         Unreviewed, rolling out r242825.
3573         https://bugs.webkit.org/show_bug.cgi?id=195648
3574
3575         "Broke webkitpy tests with my change to
3576         lldb_dump_class_layout.py" (Requested by rmorisset on
3577         #webkit).
3578
3579         Reverted changeset:
3580
3581         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3582         classes with suspicious padding"
3583         https://bugs.webkit.org/show_bug.cgi?id=195573
3584         https://trac.webkit.org/changeset/242825
3585
3586 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3587
3588         [ews-build] Show status bubbles while the patch is waiting in queue
3589         https://bugs.webkit.org/show_bug.cgi?id=195618
3590
3591         Reviewed by Lucas Forschler.
3592
3593         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3594         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3595         enabled in initial deployment.
3596         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3597         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3598         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3599         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3600         (StatusBubble._build_bubbles_for_patch):
3601
3602 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3603
3604         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3605         https://bugs.webkit.org/show_bug.cgi?id=195573
3606
3607         Reviewed by Simon Fraser.
3608
3609         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3610
3611         * Scripts/dump-class-layout:
3612         (main):
3613         * lldb/lldb_dump_class_layout.py:
3614         (ClassLayout.__init__):
3615         (ClassLayout._compute_padding_recursive):
3616         (LLDBDebuggerInstance.dump_layout_for_classname):
3617         (LLDBDebuggerInstance):
3618         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3619         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3620
3621 2019-03-12  Chris Dumez  <cdumez@apple.com>
3622
3623         Device Orientation access permission should be denied unless explicitly granted by the client
3624         https://bugs.webkit.org/show_bug.cgi?id=195625
3625
3626         Reviewed by Youenn Fablet.
3627
3628         add API test coverage.
3629
3630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3631         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3632         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3633         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3634         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3635         (runDeviceOrientationTest):
3636         (TEST):
3637         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3638         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3639
3640 2019-03-12  Jer Noble  <jer.noble@apple.com>
3641
3642         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3643         https://bugs.webkit.org/show_bug.cgi?id=195137
3644         <rdar://problem/48810307>
3645
3646         Reviewed by Eric Carlson.
3647
3648         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3649         (TestWebKitAPI::TEST):
3650
3651 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3652
3653         [ews-build] Change urls from uat to production
3654         https://bugs.webkit.org/show_bug.cgi?id=195566
3655
3656         Reviewed by Lucas Forschler.
3657
3658         * BuildSlaveSupport/ews-app/ews/config.py:
3659         * BuildSlaveSupport/ews-build/events.py:
3660         * BuildSlaveSupport/ews-build/steps.py:
3661
3662 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3663
3664         [ews-build] change max_builds for local-worker to 1
3665         https://bugs.webkit.org/show_bug.cgi?id=195568
3666
3667         Reviewed by Lucas Forschler.
3668
3669         * BuildSlaveSupport/ews-build/loadConfig.py:
3670
3671 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3672
3673         Fix the build
3674
3675         * TestRunnerShared/spi/PencilKitTestSPI.h:
3676         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3677
3678 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3679
3680         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3681         https://bugs.webkit.org/show_bug.cgi?id=194131
3682
3683         Reviewed by Michael Catanzaro.
3684
3685         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3686         (uriChanged):
3687         (testUnfinishedSubresourceLoad):
3688         (serverCallback):
3689         (beforeAll):
3690
3691 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3692
3693         WTF::Expected should use std::addressof instead of operator&
3694         https://bugs.webkit.org/show_bug.cgi?id=195604
3695
3696         Reviewed by Myles Maxfield.
3697
3698         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3699         (TestWebKitAPI::Unique::Unique):
3700         (TestWebKitAPI::Unique::operator&):
3701         (TestWebKitAPI::TEST):
3702
3703 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3704
3705         Add Optional to Forward.h.
3706         https://bugs.webkit.org/show_bug.cgi?id=195586
3707
3708         Reviewed by Darin Adler.
3709
3710         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3711         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3712         Remove unnecessary includes from headers.
3713
3714 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3715
3716         Add testing API to hit-test and scroll overflow scrollers
3717         https://bugs.webkit.org/show_bug.cgi?id=195278
3718
3719         Reviewed by Antti Koivisto.
3720         
3721         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3722         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3723         
3724         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3725
3726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3727         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3728         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3729         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3730         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3731         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3732         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3733         (WTR::enclosingScrollViewIncludingSelf):
3734         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3735
3736 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3737
3738         API test WebKit.RequestTextInputContext fails on iOS
3739         https://bugs.webkit.org/show_bug.cgi?id=195585
3740
3741         Reviewed by Wenson Hsieh and Simon Fraser.
3742
3743         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3744         (applyStyle):
3745         (TEST):
3746         Add a viewport, so that the coordinates match up on iOS.
3747         Scroll by moving the UIScrollView's contentOffset.
3748
3749 2019-03-11  Chris Dumez  <cdumez@apple.com>
3750
3751         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3752         https://bugs.webkit.org/show_bug.cgi?id=195506
3753         <rdar://problem/48733477>
3754
3755         Reviewed by Alex Christensen.
3756
3757         Add API test coverage.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3760
3761 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3762
3763         Adding myself to contributors.json
3764
3765         Unreviewed, addming myself to contributors.json .
3766
3767         * Scripts/webkitpy/common/config/contributors.json:
3768
3769 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3770
3771         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3772         https://bugs.webkit.org/show_bug.cgi?id=195511
3773         <rdar://problem/44873269>
3774
3775         Reviewed by Darin Adler.
3776
3777         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3778         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3779         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3780         (TEST_F):
3781
3782 2019-03-11  Chris Dumez  <cdumez@apple.com>
3783
3784         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3785         https://bugs.webkit.org/show_bug.cgi?id=195561
3786
3787         Reviewed by Youenn Fablet.
3788
3789         Make sure the JS in the test requests for permission to receive device orientation events.
3790
3791         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3792
3793 2019-03-11  Youenn Fablet  <youenn@apple.com>
3794
3795         Allow storage quota increase by default in WTR
3796         https://bugs.webkit.org/show_bug.cgi?id=195541
3797
3798         Reviewed by Geoffrey Garen.
3799
3800         Allow storage quota increase by default in WTR.
3801         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3802         Use this for tests that explicitly need cache increase.
3803
3804         Instead of increasing quota by 2, make sure the next request is
3805         granted by adding all given parameters.
3806
3807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3809         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3810         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3811         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3812         * WebKitTestRunner/TestController.cpp:
3813         (WTR::TestController::setAllowStorageQuotaIncrease):
3814         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3815         * WebKitTestRunner/TestController.h:
3816         * WebKitTestRunner/TestInvocation.cpp:
3817         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3818         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3819         (WTR::TestController::cocoaResetStateToConsistentValues):
3820         (WTR::TestController::setAllowStorageQuotaIncrease):
3821         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3822         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3823         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3824
3825 2019-03-11  Xan Lopez  <xan@igalia.com>
3826
3827         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3828         https://bugs.webkit.org/show_bug.cgi?id=194147
3829
3830         Reviewed by Michael Saboff.
3831
3832         To make --32-bit work correctly on Linux/64bit we need to:
3833
3834         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3835         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3836         unfortunately CMake only allows us to do this during
3837         crosscompilation, which is overkill here.
3838         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3839         pkg-config detection module uses the x86 .pc files instead of the
3840         x86_64 ones.
3841         - Set the -m32 flags for the compiler.
3842
3843         * Scripts/webkitdirs.pm:
3844         (generateBuildSystemFromCMakeProject):
3845
3846 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3847
3848         Add MotionMark-1.1 plan file for run-benchmark script.
3849         https://bugs.webkit.org/show_bug.cgi?id=195481
3850
3851         Rubber-stamped by Darin Adler.
3852
3853         Run-benchmark script should support MontionMark-1.1.
3854
3855         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3856
3857 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3858
3859         [ews-app] Add support for submit-to-ews url
3860         https://bugs.webkit.org/show_bug.cgi?id=195477
3861
3862         Reviewed by Lucas Forschler.
3863
3864         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3865         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3866         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3867         * BuildSlaveSupport/ews-app/ews/urls.py:
3868         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3869
3870 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3871
3872         Unreviewed, rolling out r242688, r242643, r242624.
3873
3874         Caused multiple layout test failures and crashes on iOS and macOS.
3875
3876         Reverted changeset:
3877
3878         "requestAnimationFrame should execute before the next frame"
3879         https://bugs.webkit.org/show_bug.cgi?id=177484
3880         https://trac.webkit.org/changeset/242624/webkit
3881
3882         * Tracing/SystemTracePoints.plist:
3883
3884 2019-03-11  John Wilander  <wilander@apple.com>
3885
3886         Resource Load Statistics: Make it possible exclude localhost from classification
3887         https://bugs.webkit.org/show_bug.cgi?id=195474
3888         <rdar://problem/47520577>
3889
3890         Reviewed by Brent Fulgham.
3891
3892         This patch allows for localhost to be excluded from classification and
3893         treatment as a prevalent resource.
3894
3895         The WebKit Tools change adds a new function called
3896         testRunner.setStatisticsIsRunningTest() which can be used to control this
3897         behavior.
3898
3899         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3901         (WTR::TestRunner::setStatisticsIsRunningTest):
3902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3903         * WebKitTestRunner/TestController.cpp:
3904         (WTR::TestController::setStatisticsIsRunningTest):
3905         * WebKitTestRunner/TestController.h:
3906         * WebKitTestRunner/TestInvocation.cpp:
3907         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3908
3909 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3910
3911         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3912         https://bugs.webkit.org/show_bug.cgi?id=195560
3913
3914         Reviewed by Lucas Forschler.
3915
3916         * BuildSlaveSupport/ews-build/master.cfg:
3917
3918 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3919
3920         Unreviewed, rolling out r242698.
3921
3922         API test crashes on bots.
3923
3924         Reverted changeset:
3925
3926         "Add a WKContentRuleList variant that uses copied memory
3927         instead of mmap'd shared memory for class A containerized
3928         apps"
3929         https://bugs.webkit.org/show_bug.cgi?id=195511
3930         https://trac.webkit.org/changeset/242698
3931
3932 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3933
3934         [WPE] Enable web process sandbox
3935         https://bugs.webkit.org/show_bug.cgi?id=195169
3936
3937         Reviewed by Daniel Bates.
3938
3939         * wpe/install-dependencies:
3940         * wpe/jhbuild.modules:
3941
3942 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3943
3944         [ews-app] Use port 17000 for worker communication
3945         https://bugs.webkit.org/show_bug.cgi?id=195558
3946
3947         Reviewed by Lucas Forschler.
3948
3949         * BuildSlaveSupport/ews-build/master.cfg:
3950
3951 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3952
3953         [ews-build] unit-tests fail when passwords.json is missing
3954         https://bugs.webkit.org/show_bug.cgi?id=195557
3955
3956         Reviewed by Lucas Forschler.
3957
3958         * BuildSlaveSupport/ews-build/loadConfig.py:
3959         (loadBuilderConfig):
3960         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3961         (ConfigDotJSONTest.test_configuration):
3962         * BuildSlaveSupport/ews-build/master.cfg:
3963
3964 2019-03-11  Truitt Savell  <tsavell@apple.com>
3965
3966         Unreviewed, rolling out r242702.
3967
3968         Broke High Sierra builders.
3969
3970         Reverted changeset:
3971
3972         "Add utility function to allow easy reverse range-based
3973         iteration of a container"
3974         https://bugs.webkit.org/show_bug.cgi?id=195542
3975         https://trac.webkit.org/changeset/242702
3976
3977 2019-03-11  Sam Weinig  <sam@webkit.org>
3978
3979         Add utility function to allow easy reverse range-based iteration of a container
3980         https://bugs.webkit.org/show_bug.cgi?id=195542
3981
3982         Reviewed by Antti Koivisto.
3983
3984         * TestWebKitAPI/CMakeLists.txt:
3985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3986         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3987         (TestWebKitAPI::TEST):
3988         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3989
3990 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3991
3992         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3993         https://bugs.webkit.org/show_bug.cgi?id=195511
3994         <rdar://problem/44873269>
3995
3996         Reviewed by Darin Adler.
3997
3998         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3999         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4000         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4001         (TEST_F):
4002
4003 2019-03-10  Tim Horton  <timothy_horton@apple.com>
4004
4005         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
4006         https://bugs.webkit.org/show_bug.cgi?id=195499
4007
4008         Reviewed by Darin Adler.
4009
4010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4011         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
4012         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
4013         (-[WKWebView synchronouslyFocusTextInputContext:]):
4014         (applyStyle):
4015         (applyIframe):
4016         (TEST):
4017         Add some tests for this SPI.
4018
4019 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
4020
4021         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
4022         https://bugs.webkit.org/show_bug.cgi?id=181151
4023
4024         Reviewed by Don Olmstead.
4025
4026         * TestWebKitAPI/CMakeLists.txt:
4027         * TestWebKitAPI/PlatformWin.cmake:
4028         Enable TestWTF RunLoop tests in all platforms.
4029
4030         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
4031         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
4032         (TestWebKitAPI::DerivedOneShotTimer::fired):
4033         (TestWebKitAPI::TEST):
4034         Only a few platforms support nested RunLoop.
4035
4036         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
4037         (TestWebKitAPI::DerivedRepeatingTimer::fired):
4038
4039 2019-03-10  David Quesada  <david_quesada@apple.com>
4040
4041         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
4042         https://bugs.webkit.org/show_bug.cgi?id=152480
4043
4044         Reviewed by Chris Dumez.
4045
4046         Add a unit test based on Daniel Bates's test case that starts a download, ensures
4047         there are no additional references to the process pool besides the one held by
4048         the download, waits for the download to finish (in the sense that the
4049         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
4050         measure, also check that the process pool has been deallocated at the end of the
4051         test. The test wouldn't be meaningful if the process pool were still alive.
4052
4053         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4054         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
4055         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
4056             The download will be canceled because the delegate does not implement the
4057             method to decide the download's destination, so this is where we know the
4058             DownloadProxyMap is done with the DownloadProxy.
4059         (TEST):
4060
4061 2019-03-08  Chris Dumez  <cdumez@apple.com>
4062
4063         Add support for Device Orientation / Motion permission API
4064         https://bugs.webkit.org/show_bug.cgi?id=195329
4065         <rdar://problem/47645367>
4066
4067         Reviewed by Geoffrey Garen.
4068
4069         Add test infrastructure to help test the Device Orientation / Motion permission API.
4070
4071         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4073         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
4074         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4075         * WebKitTestRunner/TestController.cpp:
4076         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
4077         (WTR::TestController::createWebViewWithOptions):
4078         (WTR::TestController::resetStateToConsistentValues):
4079         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
4080         * WebKitTestRunner/TestController.h:
4081         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
4082         * WebKitTestRunner/TestInvocation.cpp:
4083         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4084
4085 2019-03-08  Saam barati  <sbarati@apple.com>
4086
4087         Add a compare-results script to compare benchmark results
4088         https://bugs.webkit.org/show_bug.cgi?id=195486
4089         <rdar://problem/48723397>
4090
4091         Reviewed by Geoffrey Garen.
4092
4093         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
4094         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
4095         to extend it to learn about our other benchmarks.
4096
4097         * Scripts/compare-results: Added.
4098         (readJSONFile):
4099         (detectJetStream2):
4100         (JetStream2Results):
4101         (detectSpeedometer2):
4102         (Speedometer2Results):
4103         (detectPLT5):
4104         (PLT5Results):
4105         (detectBenchmark):
4106         (biggerIsBetter):
4107         (ttest):
4108         (getOptions):
4109         (main):
4110
4111 2019-03-08  Stephanie Lewis  <slewis@apple.com>
4112
4113         Ensure old tab state is cleared between iterations of run-benchmark
4114         https://bugs.webkit.org/show_bug.cgi?id=195393
4115         <rdar://problem/46885583>
4116
4117         Reviewed by Dewei Zhu.
4118
4119         a) ensure the default to restore state is not set
4120         b) terminate Safari correctly
4121         c) Set the system default to ignore Persistent State in Safari
4122
4123         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4124         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
4125         (OSXBrowserDriver.prepare_env): 
4126         (OSXBrowserDriver.restore_env):
4127         (OSXBrowserDriver.close_browsers):
4128         (OSXBrowserDriver._terminate_processes):
4129         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
4130         (OSXChromeDriver):
4131         (OSXChromeCanaryDriver):
4132         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
4133         (OSXFirefoxDriver):
4134         (OSXFirefoxNightlyDriver):
4135         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
4136         (OSXSafariDriver):
4137         (OSXSafariDriver.prepare_env):
4138
4139 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
4140
4141         [GTK] Several InputMethodFilter tests are failing
4142         https://bugs.webkit.org/show_bug.cgi?id=195408
4143
4144         Reviewed by Carlos Garcia Campos.
4145
4146         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
4147         Regressed in r241751.
4148         Hexadecimal values of keycodes are expressed now in upper letters.
4149         Composited characters should be cast to UTF8 strings.
4150
4151         (TestWebKitAPI::TEST):
4152
4153 2019-03-07  Tomas Popela  <tpopela@redhat.com>
4154
4155         [GTK] Make Tools/gtkdoc python3 compatible
4156         https://bugs.webkit.org/show_bug.cgi?id=195359
4157
4158         Reviewed by Carlos Garcia Campos.
4159
4160         * gtkdoc/generate-gtkdoc:
4161         ConfigParser was reworked in Python 3.2 so we have adapt the code to
4162         work with Python 2 and 3.
4163         (get_gtkdoc_module_paths):
4164         The iteritems() was removed in Python 3, so let's use items() that's
4165         available in Python 2 and 3.
4166         (get_generator_for_config):
4167         * gtkdoc/gtkdoc.py:
4168         (GTKDoc._run_command):
4169         The sys.stdout.write() is expecting str in Python 3 and not bytes
4170         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
4171         for passing the bytes there.
4172
4173 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4174
4175         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4176         https://bugs.webkit.org/show_bug.cgi?id=195346
4177         <rdar://problem/48667048>
4178
4179         Unreviewed build fix for clang-cl.
4180
4181         * DumpRenderTree/win/DumpRenderTree.cpp:
4182         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
4183
4184 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
4185
4186         requestAnimationFrame should execute before the next frame
4187         https://bugs.webkit.org/show_bug.cgi?id=177484
4188
4189         Reviewed by Simon Fraser.
4190
4191         Add trace points for the page RenderingUpdate.
4192
4193         * Tracing/SystemTracePoints.plist:
4194
4195 2019-03-07  Zalan Bujtas  <zalan@apple.com>
4196
4197         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4198         https://bugs.webkit.org/show_bug.cgi?id=195353
4199         <rdar://problem/48626394>
4200
4201         Reviewed by Simon Fraser.
4202
4203         * WebKitTestRunner/ios/TestControllerIOS.mm:
4204         (WTR::TestController::platformResetPreferencesToConsistentValues):
4205
4206 2019-03-07  John Wilander  <wilander@apple.com>
4207
4208         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4209         https://bugs.webkit.org/show_bug.cgi?id=195383
4210         <rdar://problem/48570136>
4211
4212         Reviewed by Brent Fulgham.
4213
4214         This patch adds test infrastructure to purge only script-accessible cookies,
4215         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4216
4217         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4219         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4220         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4221         * WebKitTestRunner/TestController.cpp:
4222         (WTR::TestController::statisticsDeleteCookiesForHost):
4223         * WebKitTestRunner/TestController.h:
4224         * WebKitTestRunner/TestInvocation.cpp:
4225         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4226
4227 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4228
4229         Unreviewed, rolling out r242354.
4230         https://bugs.webkit.org/show_bug.cgi?id=195402
4231
4232         breaks layout tests in all configurations (Requested by
4233         zdobersek on #webkit).
4234
4235         Reverted changeset:
4236
4237         "[WPE] Enable web process sandbox"
4238         https://bugs.webkit.org/show_bug.cgi?id=195169
4239         https://trac.webkit.org/changeset/242354
4240
4241 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4242
4243         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4244         https://bugs.webkit.org/show_bug.cgi?id=195346
4245
4246         Reviewed by Fujii Hironori.
4247
4248         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4249         (TestWebKitAPI::TEST):
4250         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4251
4252         * DumpRenderTree/win/DumpRenderTree.cpp:
4253         (findFontFallback):
4254         (addFontFallbackIfPresent):
4255         (removeFontFallbackIfPresent):
4256         (main):
4257         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4258         (TestWebKitAPI::Util::moduleDirectory):
4259         (TestWebKitAPI::Util::createInjectedBundlePath):
4260         Use wchar helpers as needed.
4261
4262 2019-03-06  Rob Buis  <rbuis@igalia.com>
4263
4264         Consider supporting the `referrerpolicy` attribute.
4265         https://bugs.webkit.org/show_bug.cgi?id=179053
4266
4267         Reviewed by Darin Adler.
4268
4269         Add a runtime flag for referrerpolicy attribute.
4270
4271         * DumpRenderTree/mac/DumpRenderTree.mm:
4272         (enableExperimentalFeatures):
4273
4274 2019-03-05  Daniel Bates  <dabates@apple.com>
4275
4276         Update expected API test result following r242379
4277         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4278
4279         Update expected x-coordinate of selection rect now that the left padding of
4280         a textarea is sized in ems (so dependent on the font size) just like the left
4281         padding of a text field.
4282
4283         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4284         (TestWebKitAPI::TEST):
4285
4286 2019-03-05  David Quesada  <david_quesada@apple.com>
4287
4288         [WK2] It should be possible to follow links with 'download' attributes
4289         https://bugs.webkit.org/show_bug.cgi?id=195145
4290         rdar://problem/48462642
4291
4292         Reviewed by Alex Christensen.
4293
4294         Add a unit test to verify that activating links with 'download' attributes now
4295         navigates to the linked resource, rather than starts downloading it. Add another
4296         to verify that it is still possible to explicitly download the link via the
4297         'Download' navigation action policy.
4298
4299         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4300         (-[DownloadAttributeTestDelegate init]):
4301         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4302         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4303         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4304         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4305         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4306         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4307         (TEST):
4308         * WebKitTestRunner/TestController.cpp:
4309         (WTR::TestController::decidePolicyForNavigationAction):
4310         * WebKitTestRunner/TestController.h:
4311
4312 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4313
4314         [Curl] Implement Cookie Accept Policy.
4315         https://bugs.webkit.org/show_bug.cgi?id=191645
4316
4317         Reviewed by Fujii Hironori.
4318
4319         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4320         (TestWebKitAPI::Curl::TEST_F):
4321
4322 2019-03-05  Youenn Fablet  <youenn@apple.com>
4323
4324         Rename requestCacheStorageSpace to requestStorageSpace
4325         https://bugs.webkit.org/show_bug.cgi?id=195282
4326
4327         Reviewed by Chris Dumez.
4328
4329         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4330         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4331         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4332
4333 2019-03-05  Brady Eidson  <beidson@apple.com>
4334
4335         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4336         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4337
4338         Reviewed by Tim Horton.
4339
4340         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4341         different directory into that same WKWebView should work.
4342
4343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4344         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4345
4346 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4347
4348         Add WeakHashSet
4349         https://bugs.webkit.org/show_bug.cgi?id=195152
4350
4351         Reviewed by Antti Koivisto.
4352
4353         Added tests for WeakHashSet.