[Qt] Prospective Qt/Windows cross-compiling fix
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2
3         [Qt] Prospective Qt/Windows cross-compiling fix
4
5         Reviewed by Tor Arne Vestbø.
6
7         The win32 scope is not set when cross-compiling from Linux to Windows.
8
9         * qmake/mkspecs/features/functions.prf:
10
11 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
12
13         [EFL] Remove background view on EWebLauncher and MiniBrowser
14         https://bugs.webkit.org/show_bug.cgi?id=96905
15
16         Reviewed by Gyuyoung Kim.
17
18         The size of webview was changed after adding url bar.
19         And the background view is not necessary anymore, since it was used for debugging back in the day.
20
21         * EWebLauncher/main.c:
22         (_ELauncher):
23         (on_ecore_evas_resize):
24         (browserCreate):
25         * MiniBrowser/efl/main.c:
26         (_MiniBrowser):
27         (on_ecore_evas_resize):
28         (browserCreate):
29
30 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
31
32         [GTK] run-webkit-tests unable to find TestExpectations for WK2
33         https://bugs.webkit.org/show_bug.cgi?id=96998
34
35         Reviewed by Philippe Normand.
36
37         We should look for TestExpectations files in all the locations where
38         we currently look for Skipped files. This will allow
39         run-webkit-tests to look for TestExpectations files in
40         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
41
42         * Scripts/webkitpy/layout_tests/port/gtk.py:
43         (GtkPort.expectations_files):
44
45 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
46
47         [Qt] Fix build without the QtQuick module
48
49         Reviewed by Simon Hausmann.
50
51         * qmake/mkspecs/features/features.prf:
52
53 2012-09-18  Stephanie Lewis  <slewis@apple.com>
54
55         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
56
57         Unreviewed.
58
59         * DumpRenderTree/mac/DumpRenderTree.mm:
60         (poseAsClass):
61
62 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
63
64         Unreviewed update of email addresses for Berlin QtWebKit office.
65
66         * Scripts/webkitpy/common/config/committers.py:
67
68 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
69
70         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
71         https://bugs.webkit.org/show_bug.cgi?id=96899
72
73         Reviewed by Martin Robinson.
74
75         When overriding the 'WebKitDisplayImageKey' preference, use the
76         'auto-load-images' property of WebKitWebSettings as the property which
77         should be updated with the corresponding preference value.
78
79         * DumpRenderTree/gtk/DumpRenderTree.cpp:
80         (resetDefaultsToConsistentValues):
81         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
82         (TestRunner::overridePreference):
83
84 2012-09-17  Pratik Solanki  <psolanki@apple.com>
85
86         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
87         https://bugs.webkit.org/show_bug.cgi?id=96973
88
89         Reviewed by Dan Bernstein.
90
91         * DumpRenderTree/mac/Configurations/Base.xcconfig:
92         * WebKitTestRunner/Configurations/Base.xcconfig:
93         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
94
95 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
96
97         nrwt: remove "unexpected EOF" warnings
98         https://bugs.webkit.org/show_bug.cgi?id=96970
99
100         Reviewed by Ojan Vafai.
101
102         After debugging this a bit, it looks like there aren't any cases
103         that I can reproduce where a read() of zero indicates something
104         actually wrong; either it is a prelude to a crash, or a false
105         negative. So, I'm removing these warnings and adding a comment.
106
107         * Scripts/webkitpy/layout_tests/port/server_process.py:
108         (ServerProcess._wait_for_data_and_update_buffers_using_select):
109
110 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
111
112         [chromium] ASAN bot is crashing at the end of the run
113         https://bugs.webkit.org/show_bug.cgi?id=96967
114
115         Reviewed by Abhishek Arya.
116
117         The ASAN bot is crashing attempting to decode some output into
118         UTF-8; there's no reason to do this, so let's not do this and
119         see if something else is going on as well.
120
121         * Scripts/webkitpy/layout_tests/port/chromium.py:
122         (ChromiumPort._get_crash_log):
123
124 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
125
126         nrwt: --results-directory isn't getting printed properly
127         https://bugs.webkit.org/show_bug.cgi?id=96965
128
129         Reviewed by Ojan Vafai.
130
131         options.results_directory isn't actually initialized with the
132         default values until after we call print_config(), so this
133         changes things to print the value directly.
134
135         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
136         (run):
137         * Scripts/webkitpy/layout_tests/views/printing.py:
138         (Printer.print_config):
139         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
140         (Testprinter.test_print_config):
141
142 2012-09-17  Rob Buis  <rbuis@rim.com>
143
144         [BlackBerry] Enable VIDEO_TRACK
145         https://bugs.webkit.org/show_bug.cgi?id=96949
146
147         Reviewed by Antonio Gomes.
148
149         * Scripts/webkitperl/FeatureList.pm:
150
151 2012-09-17  Rick Byers  <rbyers@chromium.org>
152
153         Add handling of new GestureTapCancel in DRT
154
155         https://bugs.webkit.org/show_bug.cgi?id=96183
156
157         Reviewed by Antonio Gomes.
158
159         * DumpRenderTree/chromium/TestWebPlugin.cpp:
160         (TestWebPlugin::handleInputEvent):
161         * DumpRenderTree/chromium/EventSender.cpp:
162         (EventSender::gestureTapCancel):
163
164 2012-09-17  Philip Rogers  <pdr@google.com>
165
166         Teach style checker about preprocessor directive indentation rules
167         https://bugs.webkit.org/show_bug.cgi?id=96874
168
169         Reviewed by Adam Barth.
170
171         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
172         This is not explicit in our style guide but is generally followed in our code.
173         Searching for violations in our codebase shows these are rarely indented:
174             #include - indented in 6 files
175             #ifdef - indented in 0 files
176             #ifndef - indented in 1 file
177             #define - indented in 11 files
178             #if - indented in 7 files
179
180         * Scripts/webkitpy/style/checkers/cpp.py:
181         (check_directive_indentation):
182
183             This is the simple test where we look for spaces followed by a #.
184
185         (check_style):
186         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
187
188             A few tests needed to be modified because they had unintentionally indented
189             preprocessor directives.
190
191         (CppStyleTest.test_build_class.Foo):
192         (CppStyleTest.test_build_class):
193         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
194         (WebKitStyleTest.test_line_breaking):
195         (WebKitStyleTest.test_directive_indentation):
196
197 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
198
199         [Qt] Auto-generate the module pri file for QtWebKit
200
201         Reviewed by Simon Hausmann.
202
203         * qmake/qt_webkit.pri: Removed.
204
205 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
206
207         nrwt: --additional-platform-dir is broken on chromium ports
208         https://bugs.webkit.org/show_bug.cgi?id=96840
209
210         Reviewed by Ojan Vafai.
211
212         Looks like I broke this when cleaning things up as part of
213         adding ML support. Fixing and adding a test.
214
215         * Scripts/webkitpy/layout_tests/port/chromium.py:
216         (ChromiumPort.default_baseline_search_path):
217         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
218         (ChromiumAndroidPort.default_baseline_search_path):
219         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
220         (ChromiumLinuxPort.default_baseline_search_path):
221         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
222         (ChromiumMacPort.__init__):
223         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
224         (ChromiumWinPort.setup_environ_for_server):
225         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
226         (test_check_build):
227         (test_additional_platform_directory):
228
229 2012-09-13  Stephanie Lewis  <slewis@apple.com>
230
231         mac-future ignores previous platform TestExpectations.
232         https://bugs.webkit.org/show_bug.cgi?id=96718.
233
234         Reviewed by Dirk Pranke.
235
236         TestExpectations match an expectation's configuraton against a list of configurations that are 
237         valid for that port.  That list does not contain mac-future so none of the expectations can be
238         applied.
239
240         * Scripts/webkitpy/layout_tests/port/apple.py:
241         (ApplePort._generate_all_test_configurations):
242
243 2012-09-14  Adam Barth  <abarth@webkit.org>
244
245         Remove webkitPostMessage
246         https://bugs.webkit.org/show_bug.cgi?id=96577
247
248         Reviewed by Ojan Vafai.
249
250         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
251
252         * Scripts/webkitperl/FeatureList.pm:
253         * qmake/mkspecs/features/features.pri:
254
255 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
256
257         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
258         https://bugs.webkit.org/show_bug.cgi?id=96817
259
260         Reviewed by Kenneth Rohde Christiansen.
261
262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
263         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
264         got overlooked when adding logging elsewhere.
265
266 2012-09-14  Peter Beverloo  <peter@chromium.org>
267
268         [Chromium] Build fix for DumpRenderTree following r128628
269         https://bugs.webkit.org/show_bug.cgi?id=96808
270
271         Reviewed by Tony Chang.
272
273         When building DumpRenderTree from the Chromium project, a compile error
274         shows up because including the header ForwardIOStreamsAndroid.h cannot
275         be located. TestWebKitAPI does this correctly.
276
277         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
278
279 2012-09-14  Dana Jansens  <danakj@chromium.org>
280
281         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
282         https://bugs.webkit.org/show_bug.cgi?id=96805
283
284         Reviewed by Dirk Pranke.
285
286         * Scripts/webkitpy/common/config/committers.py:
287         * Scripts/webkitpy/common/config/watchlist:
288
289 2012-09-14  Peter Beverloo  <peter@chromium.org>
290
291         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
292         https://bugs.webkit.org/show_bug.cgi?id=96687
293
294         Reviewed by Tony Chang.
295
296         Android's DumpRenderTree currently supports these arguments, implemented
297         as part of TestShellAndroid:
298         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
299
300         They're used by the layout test runner to get the STDOUT and STDERR while
301         a layout test run is in process, which is a safer alternative to parsing
302         all the logcat output manually. The implementation can be seen here:
303         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
304
305         This patch generalizes parsing of and applying the effects of these arguments
306         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
307         After this patch, this will make it possible to pull out the output-reading
308         code from Android's layout test port and generalize it so it can be re-used
309         in the new test-runner for the other two test suites.
310
311         This has no effect when compiling and running these tests as part of Chromium
312         code, which has a much more advanced test-runner that does parse complete log
313         output, but also directly depends on code licensed under Apache 2.
314
315         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
316         * DumpRenderTree/chromium/TestShellAndroid.cpp:
317         (platformInit):
318         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
319
320 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
321
322         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
323         https://bugs.webkit.org/show_bug.cgi?id=96656
324
325         Reviewed by Adam Barth.
326
327         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
328         macros in 1 line.
329
330         * Scripts/webkitpy/style/checkers/cpp.py:
331         (check_style.definitions):
332         (check_style): Add rule.
333         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
334         (WebKitStyleTest.test_line_breaking): Add unittest.
335
336 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
337
338         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
339         https://bugs.webkit.org/show_bug.cgi?id=57570
340
341         Reviewed by Kenneth Rohde Christiansen.
342
343         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
344         and dump the information expected by the test cases.
345
346         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
347         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
348         (WTR::InjectedBundle::beginTesting): Explicitly set the default
349         database quota.
350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
351         (WTR::securityOriginToStr): New convenience function to convert
352         a security origin to the string expected in test results.
353         (WTR):
354         (WTR::InjectedBundlePage::InjectedBundlePage):
355         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
356         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
357         refactoring to share code with didExceedDatabaseQuota.
358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
359         (InjectedBundlePage):
360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
361         (WTR::TestRunner::TestRunner):
362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
363         (WTR::TestRunner::dumpDatabaseCallbacks):
364         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
365         (TestRunner):
366
367 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
368
369         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
370
371         Rubber-stamped by Simon Hausmann.
372
373         * qmake/mkspecs/features/default_post.prf:
374
375 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
376
377         [Qt] Remove old cruft from the qmake build system
378
379         Rubber-stamped by Simon Hausmann.
380
381         * DumpRenderTree/qt/DumpRenderTree.pro:
382         * qmake/mkspecs/features/default_post.prf:
383
384 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
385
386         [Qt] Enable force_static_libs_as_shared for development
387
388         Not enabled for buildbots or production-builds (part of Qt5)
389
390         Reviewed by Simon Hausmann.
391
392         * qmake/mkspecs/features/default_post.prf:
393
394 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
395
396         [Qt] Make force_static_libs_as_shared work on Mac OS
397
398         We had to move a few LIBS += around that were in the wrong place,
399         and not caught when everything was just linked into the final
400         QtWebKit library.
401
402         Reviewed by Simon Hausmann.
403
404         * qmake/mkspecs/features/default_post.prf:
405         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
406
407 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
408
409         [Qt] Fix build of WTR on Windows
410
411         Reviewed by Tor Arne Vestbø.
412
413         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
414         With qmake's unix makefile generator as well as with the MingW generator,
415         the directory where the pro file lives (WTR/) is automatically added to
416         the include search path, but not so with MSVC. Instead of relying on qmake's
417         implicit feature here, add WTR/ explicitly to the include search path.
418
419         * WebKitTestRunner/Target.pri:
420
421 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
422
423         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
424         https://bugs.webkit.org/show_bug.cgi?id=42691
425
426         Reviewed by Kenneth Rohde Christiansen.
427
428         Add implementation for testrunner.setStopProvisionalFrameLoads()
429         in WebKitTestRunner.
430
431         Original patch by Alexey Proskuryakov.
432
433         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
434         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
435         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
437         (WTR::TestRunner::TestRunner):
438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
439         (TestRunner):
440         (WTR::TestRunner::setStopProvisionalFrameLoads):
441         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
442
443 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
444
445         [Qt] Fix handling of debug/release/debug_and_release/build_all
446
447         We now pick up the defaults from Qt, in default_pre (CONFIG already
448         contains the appropriate values for debug and release). We then let
449         the command line arguments to qmake, or the project files themselves,
450         override the configuration, and finally we sanitize the configuration
451         in default_post.
452
453         Reviewed by Simon Hausmann.
454
455         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
456         * Scripts/webkitdirs.pm:
457         (buildQMakeProjects):
458         * qmake/mkspecs/features/default_post.prf:
459         * qmake/mkspecs/features/default_pre.prf:
460         * qmake/mkspecs/features/mac/default_pre.prf:
461
462 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
463
464         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
465         https://bugs.webkit.org/show_bug.cgi?id=42687
466
467         Reviewed by Kenneth Rohde Christiansen.
468
469         Implement testRunner.setTabKeyCyclesThroughElements for
470         WebKitTestRunner.
471
472         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
473         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
474         (WTR::InjectedBundle::beginTesting):
475         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
476         (WTR::TestRunner::setTabKeyCyclesThroughElements):
477         (WTR):
478         * WebKitTestRunner/InjectedBundle/TestRunner.h:
479         (TestRunner):
480
481 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
482
483         EventSendingController::keyDown does not support non-array modifier arguments
484         https://bugs.webkit.org/show_bug.cgi?id=96727
485
486         Reviewed by Kenneth Rohde Christiansen.
487
488         Add support for handling a string as modifier argument to
489         EventSendingController::keyDown.
490
491         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
492         (WTR::parseModifierArray):
493
494 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
495
496         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
497         https://bugs.webkit.org/show_bug.cgi?id=42546
498
499         Reviewed by Kenneth Rohde Christiansen.
500
501         Exported TestRunner::setCustomPolicyDelegate() method.
502         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
503
504         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
507
508 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
509
510         [GTK] Clear application cache between tests in DumpRenderTree
511         https://bugs.webkit.org/show_bug.cgi?id=96543
512
513         Reviewed by Philippe Normand.
514
515         Call the new DumpRenderTreeSupportGtk method to clear application cache
516         after each test in DumpRenderTree.
517
518         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
519         as well. It's now being set in XvfbDriver._start so that each driver is assigned
520         a cache directory that's constructed out of the driver's name and its worker
521         number. These directories are located in the layout tests results directory.
522         At least on the builders this ensures a driver-specific empty cache directory
523         with each test run.
524
525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
526         (runTest):
527         * Scripts/webkitpy/layout_tests/port/gtk.py:
528         (GtkPort.setup_environ_for_server):
529         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
530         (XvfbDriver._start):
531
532 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
533
534         [Qt] Fix linking on Windows
535
536         Reviewed by Tor Arne Vestbø.
537
538         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
539         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
540         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
541         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
542
543         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
544         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
545         after the module. Therefore QT did never contain webkit anymore and we always passed
546         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
547
548         This patch introduces a creating_module configuration that is used to
549         scope the qt/pkgconfig sanitization.
550
551         * qmake/mkspecs/features/default_post.prf:
552
553 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
554
555         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
556         https://bugs.webkit.org/show_bug.cgi?id=96740
557
558         Reviewed by Kenneth Rohde Christiansen.
559
560         Dump information expected by the test cases about the following
561         frame load callbacks:
562         "didDisplayInsecureContentForFrame"
563         "didRunInsecureContentForFrame"
564         "didDetectXSSForFrame"
565
566         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
567         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
568         as expected by test results by calling pathSuitableForTestResult() instead
569         of printing raw URL.
570         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
571         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
572         (WTR::InjectedBundlePage::didDetectXSSForFrame):
573
574 2012-09-14  Peter Beverloo  <peter@chromium.org>
575
576         The runtime/unsigned category should be valid in the cpp style-checker.
577         https://bugs.webkit.org/show_bug.cgi?id=96748
578
579         Reviewed by Csaba Osztrogonác.
580
581         This is causing the webkitpy tests to fail because it's not listed in the
582         category array. Furthermore, change an "int" to "long" because it's
583         throwing a double error in one of the earlier asserts.
584
585         * Scripts/webkitpy/style/checkers/cpp.py:
586         (CppChecker):
587         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
588         (WebKitStyleTest.test_names):
589
590 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
591
592         Evas_Object* is a ref'ed structure, so tread it as such
593         https://bugs.webkit.org/show_bug.cgi?id=96659
594
595         Reviewed by Adam Barth.
596
597         Replace OwnPtr<Evas_Object> with RefPtr.
598
599         * DumpRenderTree/efl/ImageDiff.cpp:
600         (calculateDifference):
601         (printImageDifferences):
602         (readImageFromStdin):
603         (main):
604
605 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
606
607         Unreviewed, rolling out r128507.
608         http://trac.webkit.org/changeset/128507
609         https://bugs.webkit.org/show_bug.cgi?id=96659
610
611         Revert. r128507 makes too many crashes in EFL layout test bots.
612
613         * DumpRenderTree/efl/ImageDiff.cpp:
614         (calculateDifference):
615         (printImageDifferences):
616         (readImageFromStdin):
617         (main):
618
619 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
620
621         Make compile with both OS(WINCE) and PLATFORM(QT) support
622         https://bugs.webkit.org/show_bug.cgi?id=95536
623
624         Reviewed by Simon Hausmann.
625
626         Fix wince support in qmake files
627
628         * Tools.pro:
629         * qmake/mkspecs/features/configure.prf:
630         * qmake/mkspecs/features/default_post.prf:
631         * qmake/mkspecs/features/features.prf:
632         * qmake/mkspecs/features/functions.prf:
633
634 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
635
636         [WK2] Add color picker API support for WebKit2
637         https://bugs.webkit.org/show_bug.cgi?id=95058
638
639         Reviewed by Gyuyoung Kim.
640
641         Initialization code for color picker callbacks in UI client.
642
643         * MiniBrowser/mac/BrowserWindowController.m:
644         (-[BrowserWindowController awakeFromNib]):
645         * MiniBrowser/win/BrowserView.cpp:
646         (BrowserView::create):
647         * WebKitTestRunner/TestController.cpp:
648         (WTR::TestController::createOtherPage):
649         (WTR::TestController::initialize):
650
651 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
652
653         Upgrade yutak to reviewer
654         https://bugs.webkit.org/show_bug.cgi?id=96721
655
656         Reviewed by Kent Tamura.
657
658         * Scripts/webkitpy/common/config/committers.py:
659
660 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
661
662         Make the style checker report usage of "unsigned int"
663         https://bugs.webkit.org/show_bug.cgi?id=96693
664
665         Reviewed by Dirk Pranke.
666
667         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
668
669         * Scripts/webkitpy/style/checkers/cpp.py:
670         (check_language):
671
672 2012-09-13  Philip Rogers  <pdr@google.com>
673
674         Add gender-neutral form of webkit-patch land-cowboy
675         https://bugs.webkit.org/show_bug.cgi?id=96709
676
677         Reviewed by Adam Barth.
678
679         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
680
681         * Scripts/webkitpy/tool/commands/download.py:
682         (LandCowhand):
683
684 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
685
686         [EFL] Remove some parameters in browserCreate()
687         https://bugs.webkit.org/show_bug.cgi?id=96499
688
689         Reviewed by Kenneth Rohde Christiansen.
690
691         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
692         And I have moved some parameters into User_Arguments.
693
694         * EWebLauncher/main.c:
695         (_User_Arguments):
696         (_ELauncher):
697         (on_key_down):
698         (browserCreate):
699         (findThemePath):
700         (parseUserArguments):
701         (main):
702
703 2012-09-13  Mark Lam  <mark.lam@apple.com>
704
705         Unreviewed. Adding myself to the committers list.
706
707         * Scripts/webkitpy/common/config/committers.py:
708
709 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
710
711         run-perf-tests output cryptic error when the config file is missing.
712         https://bugs.webkit.org/show_bug.cgi?id=96453
713
714         Reviewed by Tony Chang.
715
716         Add a special error message when a configuration file is missing.
717
718         Also update the help message of --source-json-path to signify the fact it specifies
719         the configuration file on performance tests bots.
720
721         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
722         (PerfTestsRunner._parse_args):
723         (PerfTestsRunner._generate_and_show_results):
724         (PerfTestsRunner._merge_slave_config_json):
725         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
726         (_test_run_with_json_output): Make upload to fail by default and assert the result
727         in the function so that we can return logs instead.
728         (_test_run_with_json_output.mock_upload_json):
729         (test_run_with_json_output):
730         (test_run_with_description):
731         (test_run_respects_no_results):
732         (test_run_with_slave_config_json):
733         (test_run_with_bad_slave_config_json):
734         (test_run_with_multiple_repositories):
735
736 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
737
738         Evas_Object* is a ref'ed structure, so tread it as such
739         https://bugs.webkit.org/show_bug.cgi?id=96659
740
741         Reviewed by Adam Barth.
742
743         Replace OwnPtr<Evas_Object> with RefPtr.
744
745         * DumpRenderTree/efl/ImageDiff.cpp:
746         (calculateDifference):
747         (printImageDifferences):
748         (readImageFromStdin):
749         (main):
750
751 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
752
753         One more unreviewed trivial fix after r128399.
754
755         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
756
757 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
758
759         Unreviewed trivial fix after r128399.
760
761         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
762         (getLatestSVNRevision):
763         (waitForSVNRevision):
764
765 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
766
767         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
768         https://bugs.webkit.org/show_bug.cgi?id=96366
769
770         Reviewed by Anders Carlsson.
771
772         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
773         by calling shouldClose() on the FrameLoader.
774
775         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
776         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
777         (WTR::TestRunner::callShouldCloseOnWebView):
778         (WTR):
779         * WebKitTestRunner/InjectedBundle/TestRunner.h:
780         (TestRunner):
781
782 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
783
784         Unreviewed, rolling out r128453.
785         http://trac.webkit.org/changeset/128453
786         https://bugs.webkit.org/show_bug.cgi?id=96681
787
788         Having tests use the same appcache directory leads to timeouts
789         (Requested by zdobersek on #webkit).
790
791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
792         (runTest):
793         * Scripts/webkitpy/layout_tests/port/gtk.py:
794         (GtkPort.setup_environ_for_server):
795
796 2012-09-13  James Robinson  <jamesr@chromium.org>
797
798         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
799         https://bugs.webkit.org/show_bug.cgi?id=96678
800
801         Reviewed by Dirk Pranke.
802
803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
804         (.):
805
806 2012-09-13  Rob Buis  <rbuis@rim.com>
807
808         Unreviewed changes to watchlist.
809
810         - Add myself to BlackBerry bugs
811
812         * Scripts/webkitpy/common/config/watchlist:
813
814 2012-09-13  Stephen Chenney  <schenney@chromium.org>
815
816         Add an SVG entry to the watchlist
817
818         Unreviewed config change.
819
820         * Scripts/webkitpy/common/config/watchlist:
821         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
822         - Added myself and pdr as watchers
823
824 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
825
826         [Qt] Make WebKit2 work on Windows with Qt 5
827         https://bugs.webkit.org/show_bug.cgi?id=76776
828
829         Reviewed by Tor Arne Vestbø.
830
831         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
832         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
833         that for the GL TextureMapper (it's only built when that feature is set).
834
835         * qmake/mkspecs/features/configure.prf:
836
837 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
838
839         [Qt] Ensure that QT is finalized before loading qt_module.prf
840
841         As qt_module.prf does dependency tracking based on the content of the
842         QT variable. The intermediate WebKit modules modify the variable in
843         their .pri files, so we have to ensure we've loaded all the modules
844         before loading qt_module.
845
846         Reviewed by Tor Arne Vestbø.
847         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
848
849         * qmake/mkspecs/features/default_post.prf:
850         * qmake/mkspecs/features/webkit_modules.prf: Added.
851
852 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
853
854         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
855         https://bugs.webkit.org/show_bug.cgi?id=96633
856
857         Reviewed by Csaba Osztrogonác.
858
859         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
860         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
861         It's the usual problem and the usual solution is to rename one of the conflicting files.
862         This patch chooses to rename DRT instead of WTR and MBR.
863
864         Fixed include order at the same time to match style guide.
865
866         * DumpRenderTree/qt/DumpRenderTree.pro:
867         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
868         (messageHandler):
869         (isOption):
870         (takeOptionValue):
871         (printUsage):
872         (main):
873
874 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
875
876         The Script run-launcher should support -2 in combination with --efl
877         https://bugs.webkit.org/show_bug.cgi?id=96639
878
879         Reviewed by Simon Hausmann.
880
881         Support running the MiniBrowser then supplied -2 as argument.
882
883         * Scripts/run-launcher:
884
885 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
886
887         Unreviewed, add my Intel email address to the list.
888
889         * Scripts/webkitpy/common/config/committers.py:
890
891 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
892
893         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
894
895         Reviewed by Ossy.
896
897         * qmake/mkspecs/features/default_post.prf:
898
899 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
900
901         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
902         https://bugs.webkit.org/show_bug.cgi?id=82294
903
904         Reviewed by Gyuyoung Kim.
905
906         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
907
908         * DumpRenderTree/efl/TestRunnerEfl.cpp:
909         (TestRunner::layerTreeAsText):
910
911 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
912
913         [GTK] Clear application cache between tests in DumpRenderTree
914         https://bugs.webkit.org/show_bug.cgi?id=96543
915
916         Reviewed by Philippe Normand.
917
918         Call the new DumpRenderTreeSupportGtk method to clear application cache
919         after each test.
920
921         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
922         as well. Currently it points to a subdirectory in the layout tests results
923         directory. At least on the builders this ensures an empty cache directory
924         with each test run.
925
926         * DumpRenderTree/gtk/DumpRenderTree.cpp:
927         (runTest):
928         * Scripts/webkitpy/layout_tests/port/gtk.py:
929         (GtkPort.setup_environ_for_server):
930
931 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
932
933         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
934
935         Unless it's actually a dependency of the public QtWebKit API.
936
937         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
938         files with their _PRIVATE equivivalent, but that's likely to break when
939         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
940         clean up the variables in default_post.
941
942         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
943         longer needed, as it was a workaround for the intermediate libraries ending
944         up in the prl file. And, since CONFIG -= staticlib was there to support
945         the explicitlib option, we can remove that too (as well as the exception
946         for gprof, since it would be empty). If gprof needs tweaks to always link
947         statically they should go in gprof.prf.
948
949         Reviewed by Simon Hausmann.
950
951         * qmake/mkspecs/features/default_post.prf:
952         * qmake/mkspecs/features/functions.prf:
953
954 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
955
956         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
957         https://bugs.webkit.org/show_bug.cgi?id=96632
958
959         Reviewed by Carlos Garcia Campos.
960
961         Fix this by using atk_object_get_n_accessible_children instead of
962         calling getChildren() from childCount.
963
964         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
965         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
966         loop by using atk_object_get_n_accessible_children().
967
968 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
969
970         [Qt][Win] Enable USE(3D_GRAPHICS)
971         https://bugs.webkit.org/show_bug.cgi?id=90879
972
973         Reviewed by Kenneth Rohde Christiansen.
974
975         Enable it on Windows as well as on QNX (bug fixed).
976
977         * qmake/mkspecs/features/features.prf:
978
979 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
980
981         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
982         https://bugs.webkit.org/show_bug.cgi?id=96359
983
984         Reviewed by Tor Arne Vestbø.
985
986         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
987         lexer. The only viable alternative I could find on Windows that provides
988         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
989         so let's use that one instead.
990
991         * Scripts/webkitdirs.pm:
992         (checkRequiredSystemConfig):
993         * qmake/mkspecs/features/default_pre.prf:
994
995 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
996
997         [Qt] Add configuration for production builds
998         https://bugs.webkit.org/show_bug.cgi?id=96607
999
1000         Reviewed by Kenneth Rohde Christiansen.
1001
1002         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1003         and enable all-in-one-files optimizations.
1004
1005         * qmake/mkspecs/features/production_build.prf: Added.
1006
1007 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1008
1009         [Qt] GStreamer detection does not work when cross-compiling
1010         https://bugs.webkit.org/show_bug.cgi?id=96608
1011
1012         Reviewed by Kenneth Rohde Christiansen.
1013
1014         When cross-compiling it is not safe to just use system(pkg-config),
1015         because there is a high probability that it will find packages in the
1016         host system instead of in the target one. Instead use qmake's new
1017         packagesExist() function that takes care of this delicate aspect of
1018         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1019         PKG_CONFIG_LIBDIR accordingly.
1020
1021         * qmake/mkspecs/features/features.prf:
1022
1023 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1024
1025         [WK2][WTR] More efficient string handling in InjectedBundlePage
1026         https://bugs.webkit.org/show_bug.cgi?id=96609
1027
1028         Reviewed by Kenneth Rohde Christiansen.
1029
1030         Update StringBuilder usage in InjectedBundlePage to follow
1031         the latest recommandations for efficient string handling:
1032         http://trac.webkit.org/wiki/EfficientStrings
1033
1034         This involves using appendLiteral() or appendNumber()
1035         instead of append() whenever possible.
1036
1037         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1038         (WTR::dumpPath):
1039         (WTR::rangeToStr):
1040         (WTR::styleDecToStr):
1041         (WTR::frameToStr):
1042         (WTR::dumpResourceURL):
1043         (WTR):
1044         (WTR::dumpFrameDescriptionSuitableForTestResult):
1045         (WTR::dumpRequestDescriptionSuitableForTestResult):
1046         (WTR::dumpResponseDescriptionSuitableForTestResult):
1047         (WTR::dumpErrorDescriptionSuitableForTestResult):
1048         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1049         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1050         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1051         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1052         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1053         (WTR::InjectedBundlePage::didFinishProgress):
1054         (WTR::dumpFrameScrollPosition):
1055         (WTR::dumpFrameText):
1056         (WTR::dumpDescendantFramesText):
1057         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1058         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1059         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1060         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1061         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1062         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1063         (WTR::InjectedBundlePage::willSendRequestForFrame):
1064         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1065         (WTR::InjectedBundlePage::didFinishLoadForResource):
1066         (WTR::InjectedBundlePage::didFailLoadForResource):
1067         (WTR::InjectedBundlePage::shouldCacheResponse):
1068         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1069         (WTR::InjectedBundlePage::willAddMessageToConsole):
1070         (WTR::InjectedBundlePage::willSetStatusbarText):
1071         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1072         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1073         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1074         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1075         (WTR::InjectedBundlePage::shouldBeginEditing):
1076         (WTR::InjectedBundlePage::shouldEndEditing):
1077         (WTR::InjectedBundlePage::shouldInsertNode):
1078         (WTR::InjectedBundlePage::shouldInsertText):
1079         (WTR::InjectedBundlePage::shouldDeleteRange):
1080         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1081         (WTR::InjectedBundlePage::shouldApplyStyle):
1082         (WTR::InjectedBundlePage::didBeginEditing):
1083         (WTR::InjectedBundlePage::didEndEditing):
1084         (WTR::InjectedBundlePage::didChange):
1085         (WTR::InjectedBundlePage::didChangeSelection):
1086         (WTR::InjectedBundlePage::supportsFullScreen):
1087         (WTR::InjectedBundlePage::enterFullScreenForElement):
1088         (WTR::InjectedBundlePage::exitFullScreenForElement):
1089         (WTR::InjectedBundlePage::beganEnterFullScreen):
1090         (WTR::InjectedBundlePage::beganExitFullScreen):
1091         (WTR::InjectedBundlePage::closeFullScreen):
1092         (WTR::dumpBackForwardListItem):
1093         (WTR::InjectedBundlePage::dumpBackForwardList):
1094
1095 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1096
1097         [Qt][WK2] Memory leaks in Qt's TestRunner
1098         https://bugs.webkit.org/show_bug.cgi?id=96603
1099
1100         Reviewed by Csaba Osztrogonác.
1101
1102         Fix memory leaks in Qt's TestRunner code by adopting WKString
1103         created with WKStringCreateWithUTF8CString().
1104
1105         * WebKitTestRunner/qt/TestControllerQt.cpp:
1106         (WTR::TestController::initializeInjectedBundlePath):
1107         (WTR::TestController::initializeTestPluginDirectory):
1108
1109 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1110
1111         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1112         https://bugs.webkit.org/show_bug.cgi?id=96506
1113
1114         Reviewed by Dirk Pranke.
1115
1116         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1117         for debug configuration. These are the same values the Chromium port uses.
1118
1119         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1120         the layout tests under WebKit2 generally) requires more attention and gardening
1121         than what the current effort produces.
1122
1123         The unit test is updated as well to test these changes.
1124
1125         * Scripts/webkitpy/layout_tests/port/gtk.py:
1126         (GtkPort.default_timeout_ms):
1127         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1128         (GtkPortTest.test_default_timeout_ms):
1129         (GtkPortTest.assertLinesEqual):
1130
1131 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1132
1133         Add SVN mirror handling feature to build.webkit.org
1134         https://bugs.webkit.org/show_bug.cgi?id=85887
1135
1136         Reviewed by Dirk Pranke.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1139         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1140         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1141         (ConfigureBuild.start):
1142         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1143         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1144         (Factory.__init__):
1145         (BuildFactory.__init__):
1146         (TestFactory.__init__):
1147         (BuildAndTestFactory.__init__):
1148         (BuildAndPerfTestFactory.__init__):
1149         (BuildAndPerfTestWebKit2Factory.__init__):
1150         (DownloadAndPerfTestFactory.__init__):
1151         (DownloadAndPerfTestWebKit2Factory.__init__):
1152         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1153         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1154         (SVNMirrorTest):
1155         (SVNMirrorTest.setUp): Load config.json once at startup.
1156         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1157         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1158         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1159         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1160         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1161                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1162
1163 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1164
1165         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1166         https://bugs.webkit.org/show_bug.cgi?id=81606
1167
1168         Reviewed by Tim Horton.
1169
1170         6 seconds is harsh for some jquery test cases.
1171         Therefore, adjust the value to match DumpRenderTree.
1172
1173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1174         (WTR):
1175
1176 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1177
1178         [EFL] Support download attribute feature
1179         https://bugs.webkit.org/show_bug.cgi?id=96462
1180
1181         Reviewed by Gyuyoung Kim.
1182
1183         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1184         and add "download,request" callback to the DumpRenderTree for EFL.
1185
1186         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1187         (DumpRenderTreeChrome::createView):
1188         (DumpRenderTreeChrome::onDownloadRequest):
1189         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1190         (DumpRenderTreeChrome):
1191         * Scripts/webkitperl/FeatureList.pm:
1192
1193 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1194
1195         Reduce parallism on the wk2 testers.
1196         https://bugs.webkit.org/show_bug.cgi?id=95906
1197
1198         Reviewed by Dirk Pranke.
1199
1200         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1201         resource contention.  Reducing the number of processes alleviates the issue.  
1202
1203         Starting by reducing 25%.
1204
1205         * Scripts/webkitpy/layout_tests/port/mac.py:
1206         (MacPort.default_child_processes):
1207
1208 2012-09-12  Brady Eidson  <beidson@apple.com>
1209
1210         Assert in NetscapePlugin::destroy() with async plugin init
1211         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1212
1213         Reviewed by Anders Carlsson.
1214
1215         Expose NPN_Invoke to plug-in tests:
1216         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1217         (PluginTest::NPN_Invoke):
1218         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1219         (PluginTest):
1220
1221         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1222         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1223         (InvokeDestroysPluginWithinNPP_New):
1224         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1225         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1226         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1227
1228 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1229
1230         refactor TestExpectations tokenization slightly in preparation for the new syntax
1231         https://bugs.webkit.org/show_bug.cgi?id=96564
1232
1233         Reviewed by Ojan Vafai.
1234
1235         This change changes how we will tokenize/lex the
1236         TestExpectations files, in preparation for supporting both the
1237         old syntax and the new one. This change by itself should be a
1238         no-op.
1239
1240         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1241         (TestExpectationParser._tokenize_line):
1242         (TestExpectationParser):
1243         (TestExpectationParser._tokenize_line_using_old_format):
1244         (TestExpectationParser._tokenize_line_using_new_format):
1245
1246 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1247
1248         remove unused testexpectations editing code from webkitpy, garden-o-matic
1249         https://bugs.webkit.org/show_bug.cgi?id=96562
1250
1251         Reviewed by Adam Barth.
1252
1253         This code was prototyped but never fully realized. Removing
1254         until it reanimates :).
1255
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1258         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1259         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1260         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1261         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1262         (GardeningHTTPRequestHandler._run_webkit_patch):
1263         (GardeningHTTPRequestHandler.ping):
1264         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1265         (BuildCoverageExtrapolatorTest.test_extrapolate):
1266         (GardeningServerTest.test_rebaseline_new_port):
1267
1268 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1269
1270         Remove unused bot, apple-xserve-1.
1271         https://bugs.webkit.org/show_bug.cgi?id=96570
1272         
1273         Reviewed by Stephanie Lewis.
1274
1275         * BuildSlaveSupport/build.webkit.org-config/config.json:
1276
1277 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1278
1279         [GTK] We attempt to rebase documentation even if it's not present
1280         https://bugs.webkit.org/show_bug.cgi?id=96553
1281
1282         Reviewed by Martin Robinson.
1283
1284         Do not make the documentation rebase step fatal. This allows make
1285         install to succeed when there's no documentation generated.
1286
1287         * gtk/generate-gtkdoc:
1288
1289 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1290
1291         Respect WEBKITOUTPUTDIR when running EFL tests
1292         https://bugs.webkit.org/show_bug.cgi?id=96528
1293
1294         Reviewed by Dirk Pranke.
1295
1296         Expose user set WEBKITOUTPUTDIR to the web process.
1297
1298         * Scripts/webkitpy/layout_tests/port/driver.py:
1299         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1300         of the web process and its potential jhbuild wrapper.
1301
1302 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1303
1304         webkitdirs: fix uname version handling for cygwin
1305         https://bugs.webkit.org/show_bug.cgi?id=96436
1306
1307         Reviewed by Jon Honeycutt.
1308
1309         Newer versions of cygwin embed an additional version string
1310         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1311         Update the code to handle that.
1312
1313         * Scripts/webkitdirs.pm:
1314         (setupAppleWinEnv):
1315
1316 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1317
1318         Regression(r128338): Broke Windows build
1319         https://bugs.webkit.org/show_bug.cgi?id=96537
1320
1321         Unreviewed build fix.
1322
1323         Fix Apple-Win build by allocating array dynamically
1324         since its size is not constant.
1325
1326         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1327         (WTR::stringArrayToJS):
1328
1329 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1330
1331         [chromium] Add a virtual test suite for fast/hidpi
1332         https://bugs.webkit.org/show_bug.cgi?id=90192
1333
1334         Reviewed by Dirk Pranke.
1335
1336         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1337         on the hardware accelerated path as the software path.
1338
1339         * DumpRenderTree/chromium/WebPreferences.cpp:
1340         (WebPreferences::applyTo):
1341         * Scripts/webkitpy/layout_tests/port/chromium.py:
1342         (ChromiumPort.virtual_test_suites):
1343
1344 2012-09-12  Adam Klein  <adamk@chromium.org>
1345
1346         [chromium] Add content_browsertests to the flakiness dashboard
1347         https://bugs.webkit.org/show_bug.cgi?id=96535
1348
1349         Reviewed by Ojan Vafai.
1350
1351         * TestResultServer/static-dashboards/dashboard_base.js:
1352
1353 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1354
1355         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1356         https://bugs.webkit.org/show_bug.cgi?id=96496
1357
1358         Reviewed by Kenneth Rohde Christiansen.
1359
1360         Add implementation for originsWithApplicationCache to
1361         WebKitTestRunner.
1362
1363         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1365         (WTR::stringArrayToJS):
1366         (WTR):
1367         (WTR::TestRunner::originsWithApplicationCache):
1368         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1369         (TestRunner):
1370
1371 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1372
1373         Fix Qt/Windows build with Python3
1374         https://bugs.webkit.org/show_bug.cgi?id=96473
1375
1376         Reviewed by Csaba Osztrogonác.
1377
1378         In Python 3 print is a real function, so we must use parentheses around
1379         the function parameters. This is backwards compatible with Python 2.
1380
1381         * Scripts/generate-win32-export-forwards:
1382
1383 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1384
1385         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1386
1387         As pointed out by Kevin, we should inject the "set PATH=..." statement
1388         to add the GnuWin32 directory only if that directory actually exists.
1389
1390         * qmake/mkspecs/features/default_post.prf:
1391
1392 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1393
1394         [EFL] [WK2] Memory leaks in TestControllerEfl
1395         https://bugs.webkit.org/show_bug.cgi?id=96525
1396
1397         Reviewed by Kenneth Rohde Christiansen.
1398
1399         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1400         of WKString created with WKStringCreateWithUTF8CString().
1401
1402         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1403         (WTR::TestController::initializeInjectedBundlePath):
1404         (WTR::TestController::initializeTestPluginDirectory):
1405
1406 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1407
1408         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1409         https://bugs.webkit.org/show_bug.cgi?id=96374
1410
1411         Reviewed by Kenneth Rohde Christiansen.
1412
1413         Implement support for dumpApplicationCacheDelegateCallbacks
1414         and disallowIncreaseForApplicationCacheQuota in
1415         WebKitTestRunner and properly dump the information
1416         expected by the tests.
1417
1418         If the application cache quota is reached for a given
1419         security origin, WebKitTestRunner will reset the quota
1420         to its default value, unless intructed not to via
1421         disallowIncreaseForApplicationCacheQuota().
1422
1423         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1424         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1425         (WTR::InjectedBundlePage::InjectedBundlePage):
1426         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1427         (WTR):
1428         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1429         (InjectedBundlePage):
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::TestRunner):
1432         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1433         (WTR):
1434         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1435         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1436         (TestRunner):
1437         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1438         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1439
1440 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1441
1442         [chromium] remove deprecated and unused sets import from chromium_android driver
1443         https://bugs.webkit.org/show_bug.cgi?id=96485
1444
1445         Reviewed by Dirk Pranke.
1446
1447         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1448
1449 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1450
1451         Flakiness dashboard doesn't recognize new Chromium Android test builder
1452         https://bugs.webkit.org/show_bug.cgi?id=96523
1453
1454         Reviewed by Ojan Vafai.
1455
1456         Properly return 'ANDROID' as the Chromium platform for Android builders.
1457
1458         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1459         (chromiumPlatform):
1460         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1461         (test):
1462
1463 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1464
1465         [Qt] Build on Windows requires bison/flex in PATH
1466         https://bugs.webkit.org/show_bug.cgi?id=96358
1467
1468         Reviewed by Tor Arne Vestbø.
1469
1470         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1471         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1472         a separate installation of various GNU tools is required as the operating system doesn't come with
1473         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1474         the gnuwin32 directory of the qt5.git top-level repository.
1475
1476         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1477
1478         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1479         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1480         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1481         updated with the new tool.
1482
1483         * Scripts/webkitdirs.pm:
1484         (checkRequiredSystemConfig):
1485         * qmake/mkspecs/features/default_post.prf:
1486
1487 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1488
1489         [Qt] Update build-jsc after r128174
1490
1491         Reviewed by Ossy.
1492
1493         * Scripts/build-jsc:
1494
1495 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1496
1497         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1498
1499         By hard-coding the names of the targets we defined we ended up just
1500         redefining the previous target when using addStrictSubdirOrderBetween
1501         more than once in a single project file.
1502
1503         We now embed the two base targets into the target names.
1504
1505         Reviewed by Simon Hausmann.
1506
1507         * qmake/mkspecs/features/functions.prf:
1508
1509 2012-09-12  Philippe Liard  <pliard@google.com>
1510
1511         Depend on {base,net} GYP targets rather than {base,net}_java.
1512         https://bugs.webkit.org/show_bug.cgi?id=95690
1513
1514         Reviewed by Adam Barth.
1515
1516         {base,net}_java became 'private' targets on the Chromium side that
1517         clients should not depend on (see
1518         https://chromiumcodereview.appspot.com/10913083/).
1519         This removes a bunch of trailing white spaces additionally in
1520         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1521
1522         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1523         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1524
1525 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1526
1527         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1528         https://bugs.webkit.org/show_bug.cgi?id=96494
1529
1530         Reviewed by Tor Arne Vestbø.
1531
1532         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1533         plugin process feature if we don't have NPAPI.
1534
1535         * qmake/mkspecs/features/features.prf:
1536
1537 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1538
1539         Unreviewed, rolling out r128280.
1540         http://trac.webkit.org/changeset/128280
1541         https://bugs.webkit.org/show_bug.cgi?id=96498
1542
1543         it broke compilation on windows debug bot (Requested by loislo
1544         on #webkit).
1545
1546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1548         (WTR::InjectedBundlePage::InjectedBundlePage):
1549         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1550         (InjectedBundlePage):
1551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1552         (WTR::TestRunner::TestRunner):
1553         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1554         (TestRunner):
1555
1556 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1557
1558         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1559         https://bugs.webkit.org/show_bug.cgi?id=96488
1560
1561         Reviewed by Tor Arne Vestbø.
1562
1563         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1564         because there are no such targets. We want the generated sources to be independent from release
1565         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1566         redirect to the same general-purpose target (first) of creating the derived sources.
1567
1568         * qmake/mkspecs/features/default_post.prf:
1569
1570 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1571
1572         [EFL] Make DumpRenderTree smarter at finding the fonts
1573         http://webkit.org/b/96281
1574
1575         Reviewed by Gyuyoung Kim.
1576
1577         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1578         Use CString consistently.
1579
1580         * DumpRenderTree/efl/FontManagement.cpp:
1581         (buildPath):
1582         (getCoreFontFiles):
1583         (addFontDirectory):
1584         (addFontFiles):
1585         (getCustomBuildDir):
1586         (getPlatformFontsPath):
1587         (addFontsToEnvironment):
1588
1589 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1590
1591         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1592         https://bugs.webkit.org/show_bug.cgi?id=96374
1593
1594         Reviewed by Kenneth Rohde Christiansen.
1595
1596         Implement support for dumpApplicationCacheDelegateCallbacks
1597         and disallowIncreaseForApplicationCacheQuota in
1598         WebKitTestRunner and properly dump the information
1599         expected by the tests.
1600
1601         If the application cache quota is reached for a given
1602         security origin, WebKitTestRunner will reset the quota
1603         to its default value, unless intructed not to via
1604         disallowIncreaseForApplicationCacheQuota().
1605
1606         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1607         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1608         (WTR::InjectedBundlePage::InjectedBundlePage):
1609         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1610         (WTR):
1611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1612         (InjectedBundlePage):
1613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1614         (WTR::TestRunner::TestRunner):
1615         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1616         (WTR):
1617         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1618         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1619         (TestRunner):
1620         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1621         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1622
1623 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1624
1625         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1626         https://bugs.webkit.org/show_bug.cgi?id=96388
1627
1628         Reviewed by Kenneth Rohde Christiansen.
1629
1630         Exported TestRunner.workerThreadCount as readonly attribute.
1631
1632         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1634         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1635         (WTR):
1636         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1637         (TestRunner):
1638
1639 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1640
1641         [chromium] Consume a user gesture when creating a new view.
1642         https://bugs.webkit.org/show_bug.cgi?id=96373
1643
1644         Reviewed by Adam Barth.
1645
1646         * DumpRenderTree/chromium/WebViewHost.cpp:
1647         (WebViewHost::createView):
1648
1649 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1650
1651         [WK2][WTR] Some of TestRunner special options are not reset before testing
1652         https://bugs.webkit.org/show_bug.cgi?id=96384
1653
1654         Reviewed by Kenneth Rohde Christiansen.
1655
1656         Now values of the following special options are reset:
1657         void setAcceptsEditing(in boolean value);
1658         void setCloseRemainingWindowsWhenComplete(in boolean value);
1659         void setXSSAuditorEnabled(in boolean value);
1660         void setAllowFileAccessFromFileURLs(in boolean value);
1661         void setPluginsEnabled(in boolean value);
1662         void setPopupBlockingEnabled(in boolean value);
1663
1664         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1665         (WTR::InjectedBundle::beginTesting):
1666
1667 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1668
1669         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1670         https://bugs.webkit.org/show_bug.cgi?id=96273
1671
1672         Reviewed by Gyuyoung Kim.
1673
1674         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1675         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1676
1677         * WebKitTestRunner/CMakeLists.txt:
1678
1679 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1680
1681         [chromium] rename webkit_resources
1682         https://bugs.webkit.org/show_bug.cgi?id=95874
1683
1684         Reviewed by James Robinson.
1685
1686         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1687
1688 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1689
1690         [chromium] don't include content shell builders in the garden-o-matic view
1691         https://bugs.webkit.org/show_bug.cgi?id=96418
1692
1693         Reviewed by James Robinson.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1696
1697 2012-09-11  Adam Klein  <adamk@chromium.org>
1698
1699         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1700         https://bugs.webkit.org/show_bug.cgi?id=96411
1701
1702         Reviewed by Adam Barth.
1703
1704         Previously only the exact string "warning" was treated as a warning
1705         result. This patch treats any string with "warning" as a substring
1706         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1707
1708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1709         (.):
1710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1711
1712 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1713
1714         Restore original value of mock scrollbars enabled in InternalSettings
1715         https://bugs.webkit.org/show_bug.cgi?id=87680
1716
1717         Reviewed by Adam Barth.
1718
1719         Added backup support for mock scrollbars state in
1720         InternalSettings::Backup, and removed support for these
1721         from Qt's DumpRenderTree.
1722
1723         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1724         (WebCore::WebPage::resetSettings):
1725         * DumpRenderTree/qt/TestRunnerQt.cpp:
1726         (TestRunner::setFrameFlatteningEnabled):
1727         * DumpRenderTree/qt/TestRunnerQt.h:
1728         (TestRunner):
1729
1730 2012-09-11  Dan Bernstein  <mitz@apple.com>
1731
1732         Fixed a bug where kill-old-processes failed to kill clang++.
1733
1734         Rubber-stamped by Alexey Proskuryakov.
1735
1736         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1737         where it is passed as a regular expression to killall.
1738
1739 2012-09-11  Philippe Liard  <pliard@google.com>
1740
1741         Make sure that md5sum is not setup on non-Chromium Android platforms.
1742         https://bugs.webkit.org/show_bug.cgi?id=96393
1743
1744         Reviewed by Adam Barth.
1745
1746         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1747         which is also invoked on non-Chromium Android platforms. The following patch
1748         moves this logic to _startup_test() which is guaranteed to be invoked
1749         only on Android.
1750
1751         This also updates the prompt unit test in chromium_android_unittest.py.
1752
1753         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1754         (ChromiumAndroidDriver.__init__):
1755         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1756         (ChromiumAndroidDriver._setup_test):
1757
1758 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1759
1760         [EFL] Rewrite the EFL-related Find modules
1761         https://bugs.webkit.org/show_bug.cgi?id=95237
1762
1763         Reviewed by Kenneth Rohde Christiansen.
1764
1765         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1766         property and include all the Enlightenment Foundation Libraries
1767         required by the target.
1768         * EWebLauncher/CMakeLists.txt: Ditto.
1769         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1770         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1771         now that they are not added implicitly.
1772         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1773         property.
1774         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1775         property and include all the Enlightenment Foundation Libraries
1776         required by the target.
1777
1778 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1779
1780         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1781         https://bugs.webkit.org/show_bug.cgi?id=96379
1782
1783         Reviewed by Kenneth Rohde Christiansen.
1784
1785         Add implementation for setApplicationCacheOriginQuota
1786         to WebKitTestRunner.
1787
1788         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1790         (WTR::TestRunner::setApplicationCacheOriginQuota):
1791         (WTR):
1792         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1793         (TestRunner):
1794
1795 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1796
1797         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1798         https://bugs.webkit.org/show_bug.cgi?id=91988
1799
1800         Reviewed by Kenneth Rohde Christiansen.
1801
1802         Regular key events generated by Qt for the tab key fill both
1803         keyCode and keyText, so we should do the same for our fake events.
1804
1805         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1806         (WTR::EventSenderProxy::keyDown):
1807
1808 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1809
1810         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1811         https://bugs.webkit.org/show_bug.cgi?id=96269
1812
1813         Reviewed by Kenneth Rohde Christiansen.
1814
1815         Exported missing testRunner.setSpatialNavigationEnabled() method.
1816
1817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1819         (WTR::InjectedBundle::beginTesting):
1820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1821         (WTR::TestRunner::setSpatialNavigationEnabled):
1822         (WTR):
1823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1824         (TestRunner):
1825
1826 2012-09-11  Philippe Liard  <pliard@chromium.org>
1827
1828         Support LayoutTests on non-rooted devices for Chromium Android.
1829         https://bugs.webkit.org/show_bug.cgi?id=95346
1830
1831         Reviewed by Dirk Pranke.
1832
1833         We were requiring root permissions to sync resource files with the
1834         device by comparing host and device files' timestamp after we
1835         synchronized the device and host clocks.
1836         We now rely on md5sum provided by Chromium to handle data files
1837         synchronization.
1838
1839         * Scripts/webkitpy/layout_tests/port/chromium.py:
1840         (ChromiumPort._check_driver_build_up_to_date):
1841         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1842         (ChromiumAndroidDriver.__init__):
1843         (ChromiumAndroidDriver._setup_test):
1844         (ChromiumAndroidDriver._push_executable):
1845         (ChromiumAndroidDriver._push_test_resources):
1846         (ChromiumAndroidDriver._read_prompt):
1847
1848 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1849
1850         [Qt] Fix output paths on Windows
1851
1852         Reviewed by Tor Arne Vestbø.
1853
1854         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1855         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1856         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1857         incorrect here and instead for the calculation we should use forward slashes.
1858
1859         * qmake/mkspecs/features/default_pre.prf:
1860
1861 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1862
1863         [Qt] Fix passing of defines from the build system
1864
1865         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1866         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1867         will add it's own defaults if the features are not defined.
1868
1869         At some point we might want to run a configure-test to inspect what
1870         Platform.h will do, so we can sync up the build system's view of
1871         the feature-defines with the compile-time situation.
1872
1873         Reviewed by Simon Hausmann.
1874
1875         * qmake/mkspecs/features/functions.prf:
1876
1877 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1878
1879         [Qt] Fix --qt option to build-webkit
1880
1881         Reviewed by Ossy.
1882
1883         * Scripts/webkitdirs.pm:
1884         (buildQMakeProjects):
1885
1886 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1887
1888         [Qt] Add a configure step to the Qt build system
1889
1890         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1891         the build-webkit script is still supported, and will add slightly more
1892         logic to the build, such as detecting the need for clean or incremental
1893         builds.
1894
1895         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1896         all things related to configuring the build, such as use/have/enable flags,
1897         and these are translated to defines in default_post. Project files should
1898         no longer check contains(DEFINES,...) to detect features, but use the new
1899         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1900         options have been translated into WEBKIT_CONFIG options as well, and can
1901         be checked using build?().
1902
1903         Reviewed by Simon Hausmann.
1904
1905         * DumpRenderTree/qt/DumpRenderTree.pro:
1906         * MiniBrowser/qt/MiniBrowser.pro:
1907         * QtTestBrowser/QtTestBrowser.pro:
1908         * Scripts/build-webkit:
1909         * Scripts/webkitdirs.pm:
1910         (qtFeatureDefaults):
1911         (buildQMakeProjects):
1912         * Tools.pro:
1913         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1914         * WebKitTestRunner/InjectedBundle/Target.pri:
1915         * WebKitTestRunner/Target.pri:
1916         * qmake/.qmake.cache: Added.
1917         * qmake/configure.pri: Removed.
1918         * qmake/configure.pro: Removed.
1919         * qmake/dump-features: Added.
1920         * qmake/mkspecs/features/configure.prf: Added.
1921         * qmake/mkspecs/features/default_post.prf:
1922         * qmake/mkspecs/features/default_pre.prf:
1923         * qmake/mkspecs/features/features.prf:
1924         * qmake/mkspecs/features/features.pri:
1925         * qmake/mkspecs/features/functions.prf:
1926         * qmake/mkspecs/features/gprof.prf:
1927         * qmake/mkspecs/features/mac/default_pre.prf:
1928         * qmake/mkspecs/features/win32/default_pre.prf:
1929
1930 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1931
1932         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1933         https://bugs.webkit.org/show_bug.cgi?id=96372
1934
1935         Reviewed by Kenneth Rohde Christiansen.
1936
1937         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1938
1939         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1940         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1941         (WTR::TestRunner::clearApplicationCacheForOrigin):
1942         (WTR):
1943         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1944         (TestRunner):
1945
1946 2012-09-11  Peter Beverloo  <peter@chromium.org>
1947
1948         Don't ignore .pak files when making an archive for Android
1949         https://bugs.webkit.org/show_bug.cgi?id=96375
1950
1951         Reviewed by Jochen Eisinger.
1952
1953         The .pak files do need to be pushed to the device, which is currently
1954         preventing the layout test runner from correctly pushing all files.
1955
1956         * BuildSlaveSupport/built-product-archive:
1957         (archiveBuiltProduct):
1958
1959 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1960
1961         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1962         https://bugs.webkit.org/show_bug.cgi?id=96256
1963
1964         Reviewed by Kenneth Rohde Christiansen.
1965
1966         Exported TestRunner::setMinimumTimerInterval() method.
1967
1968         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1969         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1970         (WTR::InjectedBundle::beginTesting):
1971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1972         (WTR::TestRunner::setMinimumTimerInterval):
1973         (WTR):
1974         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1975         (TestRunner):
1976
1977 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1978
1979         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1980         https://bugs.webkit.org/show_bug.cgi?id=96097
1981
1982         Reviewed by Adam Barth.
1983
1984         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1985         (MockWebRTCPeerConnectionHandler::addStream):
1986         (MockWebRTCPeerConnectionHandler::removeStream):
1987
1988 2012-09-11  Peter Beverloo  <peter@chromium.org>
1989
1990         Recognize the "--chromium-android" argument in run-webkit-tests
1991         https://bugs.webkit.org/show_bug.cgi?id=96369
1992
1993         Reviewed by Jochen Eisinger.
1994
1995         Chromium for the Android platform cannot determine the platform based on
1996         the host itself, so we'll use the --chromium-android argument as the build
1997         master passes to run-webkit-tests. Make sure the layout test runner
1998         can pick the right port when doing so.
1999
2000         * Scripts/run-webkit-tests:
2001         * Scripts/webkitpy/layout_tests/port/factory.py:
2002         (port_options):
2003
2004 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2005
2006         [QT] Fix build with newer qmake from Qt 5
2007
2008         Rubber-stamped by Tor Arne Vestbø.
2009
2010         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2011         it with the use of QT_HOST_DATA/mkspecs.
2012         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2013
2014         * Scripts/webkitdirs.pm:
2015         (builtDylibPathForName):
2016         (qtMakeCommand):
2017
2018 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2019
2020         [Qt] Remove Qt 4 syncqt, no longer needed
2021
2022         Reviewed by Simon Hausmann.
2023
2024         * qmake/syncqt-4.8: Removed.
2025
2026 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2027
2028         [Qt][WK2] Fix the build with recent Qt5
2029         https://bugs.webkit.org/show_bug.cgi?id=96283
2030
2031         Reviewed by Simon Hausmann.
2032
2033         We should not use deprecated Qt API because doing that results
2034         in build failure since all the deprecated API was disabled
2035         in qtbase (https://codereview.qt-project.org/#change,24890).
2036
2037         * DumpRenderTree/qt/main.cpp:
2038         (main):
2039         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2040         (MiniBrowserApplication::notify):
2041         * MiniBrowser/qt/raw/View.cpp:
2042         (View::exposeEvent):
2043         (main):
2044
2045 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2046
2047         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2048         https://bugs.webkit.org/show_bug.cgi?id=87188
2049
2050         Reviewed by Kenneth Rohde Christiansen.
2051
2052         Add implementation for applicationCacheDiskUsageForOrigin()
2053         in WebKitTestRunner.
2054
2055         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2057         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2058         (WTR):
2059         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2060         (TestRunner):
2061
2062 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2063
2064         Properly expose <legend> elements to ATs
2065         https://bugs.webkit.org/show_bug.cgi?id=84137
2066
2067         Reviewed by Chris Fleizach.
2068
2069         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2070         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2071         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2072
2073         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2074         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2075
2076 2012-09-10  Jer Noble  <jer.noble@apple.com>
2077
2078         Unreviewed; rolling out r128081.
2079         http://trac.webkit.org/changeset/128081
2080         https://bugs.webkit.org/show_bug.cgi?id=96134
2081
2082         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2083
2084         * DumpRenderTree/TestRunner.cpp:
2085         (TestRunner::TestRunner):
2086         (TestRunner::staticFunctions):
2087         * DumpRenderTree/TestRunner.h:
2088         (TestRunner):
2089         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2090         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2091         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2092         (WTR::InjectedBundlePage::InjectedBundlePage):
2093         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2094         (InjectedBundlePage):
2095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2096         (WTR::TestRunner::TestRunner):
2097         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2098         (TestRunner):
2099
2100 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2101
2102         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2103         https://bugs.webkit.org/show_bug.cgi?id=96205
2104
2105         Reviewed by Tony Chang.
2106
2107         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2108         internally, which means that it would support only 1 TestExpectations file per port. This
2109         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2110         and efl-wk1 -> efl).
2111
2112         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2113         instead so that all the ports TestExpectations are recognized. The ports are also
2114         constructed twice, with "webkit_test_runner" option set to True and False so that we
2115         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2116
2117         * Scripts/webkitpy/style/checkers/test_expectations.py:
2118         (TestExpectationsChecker._determine_port_from_expectations_path):
2119         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2120         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2121
2122 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2123
2124         [WTR] Generated source files should include config.h
2125         https://bugs.webkit.org/show_bug.cgi?id=96254
2126
2127         Reviewed by Benjamin Poulain.
2128
2129         Current coding style has encouraged to include config.h at the first position,
2130         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2131         this rule.
2132         Therefore, this patch added it.
2133
2134         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2135         (_generateImplementationFile):
2136
2137 2012-09-10  Rick Byers  <rbyers@chromium.org>
2138
2139         Add handling of new GestureTapCancel in DRT
2140         
2141         https://bugs.webkit.org/show_bug.cgi?id=96183
2142
2143         Reviewed by Adam Barth.
2144
2145         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2146         (TestWebPlugin::handleInputEvent):
2147
2148 2012-09-10  Brady Eidson  <beidson@apple.com>
2149
2150         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2151         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2152
2153         Reviewed by Geoff Garen.
2154
2155         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2156
2157         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2158         (PluginObject):
2159         (SlowNPPNew::PluginObject::PluginObject):
2160         (SlowNPPNew::PluginObject::~PluginObject):
2161         (SlowNPPNew::PluginObject::hasProperty):
2162         (SlowNPPNew::PluginObject::getProperty):
2163         (SlowNPPNew::NPP_GetValue):
2164         (SlowNPPNew):
2165
2166 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2167
2168         WKTR often reports an unresponsive WebProcess on Mac bots
2169         https://bugs.webkit.org/show_bug.cgi?id=95906
2170
2171         Reviewed by Dan Bernstein.
2172
2173         Attempt to work around resource contention issues by increasing the NRWT
2174         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2175
2176         * Scripts/webkitpy/layout_tests/port/base.py:
2177         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2178         * WebKitTestRunner/TestController.cpp:
2179         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2180
2181 2012-09-07  Jer Noble  <jer.noble@apple.com>
2182
2183         <audio> and <video> should send Do Not Track when appropriate
2184         https://bugs.webkit.org/show_bug.cgi?id=96134
2185
2186         Reviewed by Eric Carlson.
2187
2188         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2189         WTR. Add FrameLoaderClient client methods for retrieving that value.
2190
2191         * DumpRenderTree/TestRunner.cpp:
2192         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2193         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2194         * DumpRenderTree/TestRunner.h:
2195         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2196         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2197         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2198         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2199             Pass the question on to the TestRunner.
2200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2201         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2202         (WTR::InjectedBundlePage::InjectedBundlePage):
2203             Add the setShouldSendDoNotTrackHTTPHeader client function.
2204         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2205             Pass the question on to the TestRunner.
2206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2209         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2210         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2211
2212 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2213
2214         Make EFL bots work on the flakiness dashboard
2215         https://bugs.webkit.org/show_bug.cgi?id=96164
2216
2217         Reviewed by Tony Chang.
2218
2219         Also, update outdated unittests that had started failing.
2220
2221         * TestResultServer/static-dashboards/builders.js:
2222         (isWebkitTestRunner):
2223         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2224         (nonChromiumPlatform):
2225         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2226         (test):
2227
2228 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2229
2230         [chromium] MediaStream API: Remove the Descriptor postfix
2231         https://bugs.webkit.org/show_bug.cgi?id=96268
2232
2233         Reviewed by Adam Barth.
2234
2235         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2236         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2237
2238         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2239         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2240         (MockWebRTCPeerConnectionHandler::createOffer):
2241         (MockWebRTCPeerConnectionHandler::createAnswer):
2242         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2243         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2244         (MockWebRTCPeerConnectionHandler::localDescription):
2245         (MockWebRTCPeerConnectionHandler::remoteDescription):
2246         (MockWebRTCPeerConnectionHandler::addICECandidate):
2247         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2248         (MockWebRTCPeerConnectionHandler):
2249
2250 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2251
2252         [Gtk] failure to build jhbuild dependencies with cups 1.6
2253         https://bugs.webkit.org/show_bug.cgi?id=95991
2254
2255         Reviewed by Gustavo Noronha Silva.
2256
2257         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2258         building with cups >= 1.6 [GNOME #670373].
2259
2260         * gtk/jhbuild.modules:
2261
2262 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2263
2264         [EFL][DRT] Encoding issue in printed console messages
2265         https://bugs.webkit.org/show_bug.cgi?id=96263
2266
2267         Reviewed by Kenneth Rohde Christiansen.
2268
2269         Correctly handle CONSOLE messages that contain non-ascii
2270         characters in EFL's DRT. We need to use String::fromUTF8()
2271         to construct a WTF::String from a raw string.
2272
2273         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2274         (onConsoleMessage):
2275
2276 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2277
2278         [WK2][WTR] User style sheet location should be reset before each test
2279         https://bugs.webkit.org/show_bug.cgi?id=96262
2280
2281         Reviewed by Kenneth Rohde Christiansen.
2282
2283         User style sheet location is reset before each test now.
2284
2285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2286         (WTR::InjectedBundle::beginTesting):
2287
2288 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2289
2290         Fix build of WTR with Qt on Windows
2291         https://bugs.webkit.org/show_bug.cgi?id=96249
2292
2293         Reviewed by Kenneth Rohde Christiansen.
2294
2295         Windows loves to define min and max as macros, which beautifully
2296         clashes in many places where min and max are used as variable or method
2297         names. It can be convinced not to do this when min and max are already
2298         define as macros (expanding to themselves). We have this kind of
2299         workaround in config.h files all over WebKit and as it turns out when
2300         building WTR with Qt on Windows we do end up with such a clash. Therefore
2301         we need the same workaround.
2302
2303         * WebKitTestRunner/config.h:
2304
2305 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2306
2307         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2308         https://bugs.webkit.org/show_bug.cgi?id=95936
2309
2310         Reviewed by Kenneth Rohde Christiansen.
2311
2312         Enable interactive form validation setting in WebKitTestRunner as
2313         we are currently doing in DumpRenderTree. This is needed for some
2314         tests to pass.
2315
2316         * WebKitTestRunner/TestController.cpp:
2317         (WTR::TestController::resetStateToConsistentValues):
2318
2319 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2320
2321         Clean up the code in XvfbDriver
2322         https://bugs.webkit.org/show_bug.cgi?id=96202
2323
2324         Reviewed by Philippe Normand.
2325
2326         Changes:
2327         - Remove unneeded imports,
2328         - assign the _lock_file member variable when the display number is determined,
2329         - no need for parentheses around a single string format argument,
2330         - use FileSystem.exists method when checking if lock file is present as it
2331         makes the intention much more clearer.
2332
2333         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2334         (XvfbDriver._start):
2335         (XvfbDriver.stop):
2336
2337 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2338
2339         Make the String initialization on the function side of String::number()
2340         https://bugs.webkit.org/show_bug.cgi?id=95940
2341
2342         Reviewed by Benjamin Poulain.
2343
2344         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2345         (testBoundaries):
2346         (testNumbers):
2347
2348 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2349
2350         [WK2] expose element rect for color input type
2351         https://bugs.webkit.org/show_bug.cgi?id=91664
2352
2353         Reviewed by Simon Hausmann.
2354
2355         Update the QML logic in MiniBrowser to take advantage of this.
2356         The picker size is now hardcoded and we try to place it below the
2357         input element if possible.
2358
2359         * MiniBrowser/qt/qml/ColorChooser.qml:
2360
2361 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2362
2363         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2364         https://bugs.webkit.org/show_bug.cgi?id=95329
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         Explicitely disable TabToLinks setting in WebKitTestRunner.
2369         Tests override the "WebKitTabToLinksPreferenceKey" preference
2370         to enable it.
2371
2372         * WebKitTestRunner/TestController.cpp:
2373         (WTR::TestController::resetStateToConsistentValues):
2374
2375 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2376
2377         webkit.py gdb pretty printer can't print CString
2378         https://bugs.webkit.org/show_bug.cgi?id=96068
2379
2380         Reviewed by Tony Chang.
2381
2382         Update WTFCStringPrinter to follow r126191.
2383
2384         * gdb/webkit.py:
2385         (WTFCStringPrinter.to_string):
2386
2387 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2388
2389         Rename the ustring() accessor to string()
2390         https://bugs.webkit.org/show_bug.cgi?id=95919
2391
2392         Reviewed by Geoffrey Garen.
2393
2394         Update EFL's DRT.
2395
2396         Fix some string conversion that have been made useless
2397         with recent changes.
2398
2399         * DumpRenderTree/efl/EventSender.cpp:
2400         (keyPadNameFromJSValue):
2401         (keyNameFromJSValue):
2402         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2403         (TestRunner::queueLoad):
2404         (TestRunner::addOriginAccessWhitelistEntry):
2405         (TestRunner::removeOriginAccessWhitelistEntry):
2406         (TestRunner::setUserStyleSheetLocation):
2407         (TestRunner::setValueForUser):
2408         (TestRunner::elementDoesAutoCompleteForElementWithId):
2409         (TestRunner::execCommand):
2410         (TestRunner::findString):
2411         (TestRunner::isCommandEnabled):
2412         (TestRunner::clearApplicationCacheForOrigin):
2413         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2414         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2415         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2416         (toInt):
2417         (TestRunner::overridePreference):
2418         (TestRunner::addUserScript):
2419         (TestRunner::addUserStyleSheet):
2420         (TestRunner::evaluateInWebInspector):
2421         (TestRunner::evaluateScriptInIsolatedWorld):
2422         (TestRunner::setTextDirection):
2423         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2424         (LoadItem::invoke):
2425         (LoadHTMLStringItem::invoke):
2426         (ScriptItem::invoke):
2427
2428 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2429
2430         Extend third-party storage blocking API to optionally allow blocking all storage
2431         https://bugs.webkit.org/show_bug.cgi?id=95915
2432
2433         Reviewed by Brady Eidson.
2434
2435         Modified API test to use new revised API.
2436
2437         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2438         (TestWebKitAPI::TEST):
2439
2440 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2441
2442         AX: WebCore accessibility roles should be cross-platform
2443         https://bugs.webkit.org/show_bug.cgi?id=94870
2444
2445         Reviewed by Chris Fleizach.
2446
2447         Add debug strings to Chromium for new accessibility roles.
2448
2449         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2450         (roleToString):
2451
2452 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2453
2454         AX: Chromium needs access to canvasHasFallbackContent
2455         https://bugs.webkit.org/show_bug.cgi?id=96124
2456
2457         Reviewed by Chris Fleizach.
2458
2459         Distinguish between canvas roles with and without fallback
2460         content on Chromium.
2461
2462         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2463         (getRole):
2464
2465 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2466
2467         Handle non-existant TestExpectations files gracefully
2468         https://bugs.webkit.org/show_bug.cgi?id=96149
2469
2470         Reviewed by Eric Seidel.
2471
2472         Even when we get rid of Skipped files, we shouldn't have each port
2473         require a TestExpectations file for each platform if it doesn't
2474         need one.
2475
2476         * Scripts/webkitpy/layout_tests/port/base.py:
2477         (Port.expectations_dict):
2478         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2479         (PortTest.test_nonexistant_expectations):
2480
2481 2012-09-07  Tony Chang  <tony@chromium.org>
2482
2483         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2484         https://bugs.webkit.org/show_bug.cgi?id=96136
2485
2486         Reviewed by Ojan Vafai.
2487
2488         When we renamed the file to TestExpectations, it was no longer considered a text file so
2489         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2490         from the port object, so I've removed that from the check. I'm not sure what it was
2491         supposed to do.
2492
2493         * Scripts/webkitpy/style/checker.py:
2494         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2495         * Scripts/webkitpy/style/checkers/test_expectations.py:
2496         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2497         (TestExpectationsChecker.check): Remove overrides param.
2498         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2499         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2500
2501 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2502
2503         [EFL] Use same default minimum logical font size in DRT and WTR
2504         https://bugs.webkit.org/show_bug.cgi?id=96116
2505
2506         Reviewed by Martin Robinson.
2507
2508         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2509         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2510         logical font size to 9 to match the value used in WTR.
2511         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2512         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2513         logical font size to 9 (default value in WK2)
2514
2515 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2516
2517         MediaStream API: add RTCPeerConnection::createAnswer
2518         https://bugs.webkit.org/show_bug.cgi?id=96092
2519
2520         Reviewed by Adam Barth.
2521
2522         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2523
2524         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2525         (MockWebRTCPeerConnectionHandler::createOffer):
2526         (MockWebRTCPeerConnectionHandler::createAnswer):
2527         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2528         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2529         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2530         (MockWebRTCPeerConnectionHandler):
2531
2532 2012-09-07  Dean Jackson  <dino@apple.com>
2533
2534         Unreviewed changes to watchlist.
2535
2536         - Add new WebGL and Filters definitions
2537         - Add myself to OpenGL bugs
2538
2539         * Scripts/webkitpy/common/config/watchlist:
2540
2541 2012-09-07  Peter Beverloo  <peter@chromium.org>
2542
2543         Actually trigger the Android Tester
2544         https://bugs.webkit.org/show_bug.cgi?id=96118
2545
2546         Reviewed by Adam Barth.
2547
2548         * BuildSlaveSupport/build.webkit.org-config/config.json:
2549
2550 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2551
2552         New time input needs accessibility
2553         https://bugs.webkit.org/show_bug.cgi?id=96032
2554
2555         Reviewed by Chris Fleizach.
2556
2557         Add support for valueDescription for testing.
2558
2559         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2560         (getValueDescription):
2561         (AccessibilityUIElement::AccessibilityUIElement):
2562         (AccessibilityUIElement::valueDescriptionGetterCallback):
2563         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2564         (AccessibilityUIElement):
2565
2566 2012-09-07  Peter Beverloo  <peter@chromium.org>
2567
2568         Add the google-android-tests build slave to the master's config
2569         https://bugs.webkit.org/show_bug.cgi?id=96113
2570
2571         Reviewed by Csaba Osztrogonác.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/config.json:
2574
2575 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2576
2577         [WK2] [EFL] Set theme for WebKit2 API test runner
2578         https://bugs.webkit.org/show_bug.cgi?id=96100
2579
2580         Reviewed by Kenneth Rohde Christiansen.
2581
2582         Set the theme generated by the build for the WebKit2 API test runner.
2583
2584         * TestWebKitAPI/PlatformEfl.cmake:
2585         * TestWebKitAPI/efl/PlatformWebView.cpp:
2586         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2587
2588 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2589
2590         Unreviewed. Add Gábor Ballabás as contributor.
2591
2592         * Scripts/webkitpy/common/config/committers.py:
2593
2594 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2595
2596         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2597         https://bugs.webkit.org/show_bug.cgi?id=96078
2598
2599         Reviewed by Tor Arne Vestbø.
2600
2601         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2602
2603         * qmake/mkspecs/features/default_pre.prf:
2604
2605 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2606
2607         [EFL] Add TestExpectations file for efl-wk1
2608         https://bugs.webkit.org/show_bug.cgi?id=96019
2609
2610         Reviewed by Gyuyoung Kim.
2611
2612         Update TestExpectations cascading for EFL port
2613         so that we use efl-wk1 -> efl search paths
2614         for WebKit1 EFL.
2615
2616         * Scripts/webkitpy/layout_tests/port/efl.py:
2617         (EflPort._search_paths):
2618
2619 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2620
2621         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2622         https://bugs.webkit.org/show_bug.cgi?id=95097
2623
2624         Reviewed by Dirk Pranke.
2625
2626         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2627         terminating the process does not always work as expected, leading to timeouts
2628         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2629         as it's not removed by the killed Xvfb process.
2630
2631         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2632         is tested in different circumstances - whether pixel tests are enabled or not,
2633         with an arbitrary worker number or with an Xorg process already running on the system.
2634         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2635         and then set to None.
2636
2637         * BuildSlaveSupport/kill-old-processes:
2638         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2639         is left running, potentially clogging up a display at a certain position.
2640         * Scripts/webkitpy/common/system/executive_mock.py:
2641         (MockExecutive.__init__):
2642         The _running_pids is now a dictionary with process names as keys and pids
2643         as values.
2644         (MockExecutive.check_running_pid):
2645         Check whether the passed-in pid is in the _running_pids dictionary's values.
2646         (MockExecutive):
2647         (MockExecutive.running_pids):
2648         This method returns the list of all the process pids of which the name passes
2649         through the process_name_filter.
2650         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2651         Use the Executive object of the port's host to check for running pids and open
2652         new subprocesses or kill them throughout the class.
2653         (XvfbDriver._start):
2654         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2655         start the server process after it's created.
2656         (XvfbDriver.stop):
2657         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2658         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2659         (XvfbDriverTest):
2660         (XvfbDriverTest.make_driver):
2661         (XvfbDriverTest.assertDriverStartSuccessful):
2662         (XvfbDriverTest.test_start_no_pixel_tests):
2663         (XvfbDriverTest.test_start_pixel_tests):
2664         (XvfbDriverTest.test_start_arbitrary_worker_number):
2665         (XvfbDriverTest.test_start_existing_xorg_process):
2666         (XvfbDriverTest.test_stop):
2667         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2668
2669 2012-09-06  Peter Beverloo  <peter@chromium.org>
2670
2671         Introduce the Chromium Android Release (Tests) bot
2672         https://bugs.webkit.org/show_bug.cgi?id=95980
2673
2674         Reviewed by Adam Barth.
2675
2676         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2677         which will be running layout tests on actual Android devices. Right now,
2678         four Galaxy Nexus phones are attached.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/config.json:
2681
2682 2012-09-06  James Robinson  <jamesr@chromium.org>
2683
2684         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2685         https://bugs.webkit.org/show_bug.cgi?id=96007
2686
2687         Reviewed by Adrienne Walker.
2688
2689         Fixes initialization / settings code to use WebCompositorSupport.
2690
2691         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2692         (main):
2693         * DumpRenderTree/chromium/TestShell.cpp:
2694         (TestShell::initialize):
2695         (TestShell::setPerTilePaintingEnabled):
2696
2697 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2698
2699         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2700         https://bugs.webkit.org/show_bug.cgi?id=95995
2701
2702         Reviewed by Kenneth Rohde Christiansen.
2703
2704         Provide proper implementation for PlatformWebView::windowFrame()
2705         in EFL's WebKitTestRunner.
2706
2707         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2708         (WTR::PlatformWebView::windowFrame):
2709
2710 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2711
2712         Fix WTF.Lrint on 32-bit platforms
2713         https://bugs.webkit.org/show_bug.cgi?id=96003
2714
2715         Reviewed by Benjamin Poulain.
2716
2717         Fixed failing WTF.Lrint test on 32-bit platforms.
2718
2719         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2720         (TestWebKitAPI::TEST):
2721
2722 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2723
2724         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2725         https://bugs.webkit.org/show_bug.cgi?id=95839
2726
2727         Reviewed by Adam Barth.
2728
2729         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2730         up the task definitions a bit. There was no need to have them in the header file.
2731
2732         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2733         (RTCSessionDescriptionRequestSuccededTask):
2734         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2735         (RTCSessionDescriptionRequestFailedTask):
2736         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2737         (RTCVoidRequestTask):
2738         (RTCVoidRequestTask::RTCVoidRequestTask):
2739         (MockWebRTCPeerConnectionHandler::createOffer):
2740         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2741         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2742         (MockWebRTCPeerConnectionHandler::localDescription):
2743         (MockWebRTCPeerConnectionHandler::remoteDescription):
2744         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2745         (MockWebRTCPeerConnectionHandler):
2746
2747 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2748
2749         [Qt] Fix build on Mac OS X 10.6
2750         https://bugs.webkit.org/show_bug.cgi?id=95200
2751
2752         Reviewed by Tor Arne Vestbø.
2753
2754         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2755         10.7 and newer.
2756
2757         * qmake/mkspecs/features/features.prf:
2758
2759 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2760
2761         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2762         https://bugs.webkit.org/show_bug.cgi?id=95973
2763
2764         Reviewed by Kenneth Rohde Christiansen.
2765
2766         Correctly map "addSelectionKey" to "Control" modifier
2767         in WKTR's EventSender on other OSes than Mac OS X,
2768         instead of mapping it to the "Meta" modifier.
2769
2770         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2771         (WTR::parseModifier):
2772
2773 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2774
2775         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2776         https://bugs.webkit.org/show_bug.cgi?id=95710
2777
2778         Reviewed by Dirk Pranke.
2779
2780         The stdout / stderr output can be None so make sure
2781         we won't raise an exception in this case.
2782
2783         * Scripts/webkitpy/layout_tests/port/driver.py:
2784         (Driver.run_test):
2785
2786 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2787
2788         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2789         https://bugs.webkit.org/show_bug.cgi?id=95849
2790
2791         Reviewed by Kenneth Rohde Christiansen.
2792
2793         Sanitize URLs passed by the user as program
2794         argument or typed in the URL bar in order to
2795         be more tolerant.
2796
2797         * EWebLauncher/CMakeLists.txt:
2798         * EWebLauncher/main.c:
2799         (main):
2800         * EWebLauncher/url_bar.c:
2801         (_url_bar_url_get_with_protocol):
2802         (on_urlbar_key_down):
2803         * EWebLauncher/url_utils.c: Added.
2804         (has_scheme):
2805         (url_from_user_input): Add utility function to construct a
2806         URL from user input.
2807         * EWebLauncher/url_utils.h: Added.
2808         * MiniBrowser/efl/CMakeLists.txt:
2809         * MiniBrowser/efl/main.c:
2810         (main):
2811
2812 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2813
2814         [Qt] Various small Windows / MSVC build fixes
2815         https://bugs.webkit.org/show_bug.cgi?id=95934
2816
2817         Reviewed by Kenneth Rohde Christiansen.
2818
2819         setFocus takes a boolean as argument: Don't try to implicitly convert
2820         an enum to a boolean, MSVC doesn't like that. The intent here is to
2821         enable focus, so just pass true.
2822
2823         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2824         (WTR::PlatformWebView::focus):
2825
2826 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2827
2828         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2829         https://bugs.webkit.org/show_bug.cgi?id=95965
2830
2831         Reviewed by Tor Arne Vestbø.
2832
2833         Add ANGLE as a static library module to the Qt WebKit build system.
2834
2835         * qmake/mkspecs/features/default_post.prf:
2836         * qmake/mkspecs/modules/angle.prf: Added.
2837
2838 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2839
2840         [WK2] Make [Qt]ViewportHandler cross platform
2841         https://bugs.webkit.org/show_bug.cgi?id=91257
2842
2843         Reviewed by Kenneth Rohde Christiansen.
2844
2845         Remove initial scale from viewport info item since it is
2846         set to -1 after applied thus it does not hold any valuable
2847         information.
2848
2849         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2850
2851 2012-09-05  Tony Chang  <tony@chromium.org>
2852
2853         [chromium] Remove dependency on webkit_user_agent
2854         https://bugs.webkit.org/show_bug.cgi?id=95886
2855
2856         Reviewed by Adam Barth.
2857
2858         The code isn't used by DumpRenderTree.
2859
2860         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2861
2862 2012-09-05  Rick Byers  <rbyers@chromium.org>
2863
2864         Update chromium DumpRenderTree for new WebGestureEvent fields
2865         https://bugs.webkit.org/show_bug.cgi?id=95573
2866
2867         Reviewed by James Robinson.
2868
2869         Update EventSender to write gesture details into the appropriate
2870         type-specific WebGestureEvent fields.
2871         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2872         (EventSender::gestureEvent):
2873         (EventSender::gestureFlingStart):
2874
2875 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2876
2877         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2878         https://bugs.webkit.org/show_bug.cgi?id=95789
2879
2880         Reviewed by Ojan Vafai.
2881
2882         Fix miscalculation in log message.
2883
2884         * Scripts/webkitpy/layout_tests/views/printing.py:
2885         (Printer.print_found):
2886
2887 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2888
2889         Unreviewed, rolling out r127612, r127660, and r127664.
2890         http://trac.webkit.org/changeset/127612
2891         http://trac.webkit.org/changeset/127660
2892         http://trac.webkit.org/changeset/127664
2893         https://bugs.webkit.org/show_bug.cgi?id=95920
2894
2895         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2896         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2897         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2898         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2899         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2900         (MockWebRTCPeerConnectionHandler::createOffer):
2901         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2902         (MockWebRTCPeerConnectionHandler):
2903         (SuccessCallbackTask):
2904         (FailureCallbackTask):
2905
2906 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2907
2908         Ignore-metrics includes scroll offsets.
2909         https://bugs.webkit.org/show_bug.cgi?id=95845
2910
2911         Reviewed by Dirk Pranke.
2912
2913         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2914
2915         * Scripts/old-run-webkit-tests:
2916         (stripMetrics):
2917         * Scripts/webkitpy/layout_tests/port/driver.py:
2918         (DriverOutput):
2919
2920 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2921
2922         Unreviewed test fix.
2923
2924         Including a plugin source file into the build that was added in r127595.
2925
2926         * GNUmakefile.am:
2927
2928 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2929
2930         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2931         https://bugs.webkit.org/show_bug.cgi?id=95839
2932
2933         Reviewed by Adam Barth.
2934
2935         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2936         up the task definitions a bit. There was no need to have them in the header file.
2937
2938         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2939         (RTCSessionDescriptionRequestSuccededTask):
2940         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2941         (RTCSessionDescriptionRequestFailedTask):
2942         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2943         (RTCVoidRequestTask):
2944         (RTCVoidRequestTask::RTCVoidRequestTask):
2945         (MockWebRTCPeerConnectionHandler::createOffer):
2946         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2947         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2948         (MockWebRTCPeerConnectionHandler::localDescription):
2949         (MockWebRTCPeerConnectionHandler::remoteDescription):
2950         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2951         (MockWebRTCPeerConnectionHandler):
2952
2953 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2954
2955         [EFL] Remove '+=' usage in String
2956         https://bugs.webkit.org/show_bug.cgi?id=95808
2957
2958         Reviewed by Benjamin Poulain.
2959
2960         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2961
2962         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2963         (descriptionSuitableForTestResult):
2964
2965 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2966
2967         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2968         https://bugs.webkit.org/show_bug.cgi?id=95842
2969
2970         Reviewed by Kenneth Rohde Christiansen.
2971
2972         Provide proper implementation for TestRunner::pathToLocalResource()
2973         in EFL WKTR, identical to the one for DumpRenderTree.
2974
2975         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2976         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2977         are found my WebKitTestRunner.
2978
2979         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2980         (WTR::TestRunner::pathToLocalResource):
2981
2982 2012-09-05  Brady Eidson  <beidson@apple.com>
2983
2984         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2985         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2986
2987         Reviewed by Andy Estes.
2988
2989         Add a plug-in that always fails to initialize:
2990         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2991         (NPPNewFails):
2992         (NPPNewFails::NPPNewFails):
2993         (NPPNewFails::NPP_New):
2994
2995         Add it to all the project files:
2996         * DumpRenderTree/DumpRenderTree.gypi:
2997         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2998         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2999         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3000         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3001
3002 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3003
3004         [Qt] Fix makefile race condition between derived sources and target
3005
3006         r121966 removed too much of the old qmake logic, including the rule
3007         that ensured that qmake_all would not trigger dual runs of qmake --
3008         one of the derived sources -qmake-all rule, and one for making the
3009         derived sources.
3010
3011         We now follow a similar pattern as before, by introducing a custom
3012         target that explicitly depends on the derived sources' qmake-all before
3013         doing a manual run of make. That ensures a single qmake run for the derived
3014         sources.
3015
3016         https://bugs.webkit.org/show_bug.cgi?id=93847
3017
3018         Reviewed by Csaba Osztrogonác.
3019
3020         * qmake/mkspecs/features/functions.prf:
3021
3022 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3023
3024         WKTR doesn't implement dumpWillCacheResponse()
3025         https://bugs.webkit.org/show_bug.cgi?id=94607
3026
3027         Reviewed by Kenneth Rohde Christiansen.
3028
3029         Define shouldCacheResponse() callback in resource
3030         load client and provide implementation for
3031         dumpWillCacheResponse() in WebKitTestRunner.
3032
3033         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3034         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3035         (WTR::InjectedBundlePage::InjectedBundlePage):
3036         (WTR::InjectedBundlePage::shouldCacheResponse):
3037         (WTR):
3038         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3039         (InjectedBundlePage):
3040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3041         (WTR::TestRunner::TestRunner):
3042         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3043         (WTR::TestRunner::dumpWillCacheResponse):
3044         (WTR::TestRunner::shouldDumpWillCacheResponse):
3045         (TestRunner):
3046
3047 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3048
3049         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3050         https://bugs.webkit.org/show_bug.cgi?id=92735
3051
3052         Reviewed by Hajime Morita.
3053
3054         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3055
3056         * DumpRenderTree/TestRunner.cpp:
3057         (TestRunner::staticFunctions):
3058         * DumpRenderTree/TestRunner.h:
3059         (TestRunner):
3060         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3061         (TestRunner::addUserStyleSheet):
3062         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3063         (DRTTestRunner::DRTTestRunner):
3064         (DRTTestRunner::hasCustomPageSizeStyle):
3065         * DumpRenderTree/chromium/DRTTestRunner.h:
3066         (DRTTestRunner):
3067         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3068         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3069         * DumpRenderTree/mac/TestRunnerMac.mm:
3070         * DumpRenderTree/qt/TestRunnerQt.cpp:
3071         (TestRunner::evaluateScriptInIsolatedWorld):
3072         * DumpRenderTree/qt/TestRunnerQt.h:
3073         (TestRunner):
3074         * DumpRenderTree/win/TestRunnerWin.cpp:
3075         * DumpRenderTree/wx/TestRunnerWx.cpp:
3076         (TestRunner::abortModal):
3077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3079         (WTR):
3080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3081         (TestRunner):
3082
3083 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3084
3085         [Qt] Automate the use of AllInOne files in the Qt build
3086         https://bugs.webkit.org/show_bug.cgi?id=95837
3087
3088         Reviewed by Tor Arne Vestbø.
3089
3090         New feature file that implements the all-in-one file automation by
3091         adding the requested all-in-one files to SOURCES and removing the files
3092         it includes from SOURCES.
3093
3094         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3095
3096 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3097
3098         Have NRWT log more output when crash logs are missing
3099         https://bugs.webkit.org/show_bug.cgi?id=95814
3100
3101         Reviewed by Dan Bernstein.
3102
3103         Log the stderr and stdout of the test, in order to provide slightly more
3104         context when the WebProcess times out while running tests.
3105
3106         * Scripts/webkitpy/layout_tests/port/driver.py:
3107         (Driver.run_test):
3108
3109 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3110
3111         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3112         https://bugs.webkit.org/show_bug.cgi?id=95770
3113
3114         Reviewed by Adam Barth.
3115
3116         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3117         (ChromiumAndroidDriver.__init__):
3118         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3119         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3120         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3121         (ChromiumAndroidDriver._push_executable):
3122         (ChromiumAndroidDriver._push_fonts):
3123         (ChromiumAndroidDriver._push_test_resources):
3124         (ChromiumAndroidDriver._run_adb_command):
3125         (ChromiumAndroidDriver._get_last_stacktrace):
3126         (ChromiumAndroidDriver._get_crash_log):
3127         (ChromiumAndroidDriver._start):
3128         (ChromiumAndroidDriver._start_once):
3129         (ChromiumAndroidDriver._start_once.deadlock_detector):
3130         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3131         (ChromiumAndroidDriverTest.test_get_crash_log):
3132
3133 2012-09-04  Satish Sampath  <satish@chromium.org>
3134
3135         Run git commands within the checkout directory
3136         https://bugs.webkit.org/show_bug.cgi?id=95742
3137
3138         Reviewed by Eric Seidel.
3139
3140         git commands run from scm/git.py are sometimes run with cwd set to the
3141         checkout_root and other times with whatever directory was the default cwd.
3142         Instead all these should run with the checkout root set as the cwd
3143         (except where we explicitly need a different path)
3144
3145         * Scripts/webkitpy/common/checkout/scm/git.py:
3146         (Git._run_git):
3147         (Git.find_checkout_root):
3148         (Git.discard_local_commits):
3149         (Git.local_commits):
3150         (Git.working_directory_is_clean):
3151         (Git.clean_working_directory):
3152         (Git.add_list):
3153         (Git.delete_list):
3154         (Git.exists):
3155         (Git._current_branch):
3156         (Git._changes_files_for_commit):
3157         (Git.revisions_changing_file):
3158         (Git.svn_revision):
3159         (Git._run_git_svn_find_rev):
3160         (Git.contents_at_revision):
3161         (Git.diff_for_file):
3162         (Git.show_head):
3163         (Git.committer_email_for_revision):
3164         (Git.apply_reverse_diff):
3165         (Git.revert_files):
3166         (Git.commit_with_message):
3167         (Git._commit_on_branch):
3168         (Git.svn_commit_log):
3169         (Git.last_svn_commit_log):
3170         (Git.svn_blame):
3171         (Git._branch_ref_exists):
3172         (Git.delete_branch):
3173         (Git.remote_merge_base):
3174         (Git.commit_locally_with_message):
3175         (Git.push_local_commits_to_server):
3176         (Git.commit_ids_from_commitish_arguments):
3177         (Git.commit_message_for_local_commit):
3178         (Git.files_changed_summary_for_commit):
3179
3180 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3181
3182         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3183         https://bugs.webkit.org/show_bug.cgi?id=95734
3184
3185         Reviewed by Adam Barth.
3186
3187         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3188         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3189         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3190         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3191         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3192         (MockWebRTCPeerConnectionHandler::createOffer):
3193         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3194         (MockWebRTCPeerConnectionHandler):
3195         (MockWebRTCPeerConnectionHandler::taskList):
3196         (SuccessCallbackTask):
3197         (FailureCallbackTask):
3198
3199 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3200
3201         [Chromium-Android] Output time and thread info in crash log
3202         https://bugs.webkit.org/show_bug.cgi?id=95768
3203
3204         Reviewed by Adam Barth.
3205
3206         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3207         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3208
3209 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3210
3211         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3212         https://bugs.webkit.org/show_bug.cgi?id=95721
3213
3214         Reviewed by Adam Barth.
3215
3216         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3217         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3218         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3219         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3220         (MockWebMediaStreamCenter):
3221
3222 2012-09-04  Tony Chang  <tony@chromium.org>
3223
3224         Elide test names when running new-run-webkit-tests
3225         https://bugs.webkit.org/show_bug.cgi?id=95626
3226
3227         Reviewed by Dirk Pranke.
3228
3229         When the test name exceeds the number of terminal columns, it leaves
3230         text on the screen. Avoid this by eliding the test name when running
3231         tests. This is similar to what ninja does when compiling.
3232
3233         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3234         (MeteredStream):
3235         (MeteredStream.number_of_columns): Helper method to get number of
3236         terminal columns. Won't work on Win32 python, but meh.
3237         * Scripts/webkitpy/layout_tests/views/printing.py:
3238         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3239         because stderr appears to be ascii only.
3240         (Printer.print_started_test): Route through _test_status_line.
3241         (Printer.print_finished_test): Route through _test_status_line.
3242         (Printer._print_test_trace): Route through _test_status_line.
3243         (Printer._print_baseline): Route through _test_status_line.
3244         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3245         (test_test_status_line): Test for _test_status_line.
3246
3247 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3248
3249         [GTK] Print API missing documentation when generating gtkdoc
3250         https://bugs.webkit.org/show_bug.cgi?id=95703
3251
3252         Reviewed by Carlos Garcia Campos.
3253
3254         Print out API missing documentation when generating gtkdoc. This makes it
3255         easier to fix documentation errors.
3256
3257         * gtk/generate-gtkdoc:
3258         (print_missing_api): Added.
3259         (generate_doc): Inline the rebase step, since it now reports an error
3260         when you try to rebase without generating documentation first.
3261         * gtk/gtkdoc.py:
3262         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3263         generating documentation first to enable a small cleanup at the caller.
3264         (GTKDoc.api_missing_documentation): Added.
3265
3266 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3267
3268         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3269         https://bugs.webkit.org/show_bug.cgi?id=95628
3270
3271         Reviewed by James Robinson.
3272
3273         Future tests need the ability to respond asynchronously that
3274         pointer lock requests have been accepted or rejected. This patch
3275         adds the following:
3276             testRunner.setPointerLockWillRespondAsynchronously();
3277             testRunner.didAcquirePointerLock();
3278             testRunner.didNotAcquirePointerLock();
3279
3280         Tested in existing test:
3281             pointerlockchange-pointerlockerror-events.html
3282
3283         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3284         (DRTTestRunner::DRTTestRunner):
3285         (DRTTestRunner::didAcquirePointerLock):
3286         (DRTTestRunner::didNotAcquirePointerLock):
3287         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3288         * DumpRenderTree/chromium/DRTTestRunner.h:
3289         (DRTTestRunner):
3290         * DumpRenderTree/chromium/WebViewHost.cpp:
3291         (WebViewHost::requestPointerLock):
3292         (WebViewHost::didAcquirePointerLock):
3293         (WebViewHost::didNotAcquirePointerLock):
3294         * DumpRenderTree/chromium/WebViewHost.h:
3295         (WebViewHost):
3296         (WebViewHost::setPointerLockWillRespondAsynchronously):
3297
3298 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3299
3300         Move content shell bots to their own builder group
3301         https://bugs.webkit.org/show_bug.cgi?id=95765
3302
3303         Reviewed by Adam Barth.
3304
3305         In their current state of instability, they add too much noise. Once they get more stable,
3306         we can add them back to the regular group or just have them replace the other bots.
3307
3308         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3309
3310         * TestResultServer/static-dashboards/builders.js:
3311         (isWebkitTestRunner):
3312         (isChromiumContentShellTestRunner):
3313         (isChromiumWebkitTipOfTreeTestRunner):
3314         (loadBuildersList):
3315
3316 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3317
3318         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3319         https://bugs.webkit.org/show_bug.cgi?id=95689
3320
3321         Reviewed by Kenneth Rohde Christiansen.
3322
3323         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3324         So, there are bugs that key events are always generated in url bar although
3325         the user clicked the web view.
3326
3327         This patch recovers the focus of the web view when left button is pressed and
3328         adds for MiniBrowser to toggle the focus when middle button is pressed
3329         like EWebLauncher already did.
3330
3331         * EWebLauncher/main.c:
3332         (on_mouse_down):
3333         * MiniBrowser/efl/main.c:
3334         (on_mouse_down):
3335         (browserCreate):
3336
3337 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3338
3339         Added ANDROID_GDBSERVER definition for Ant
3340         https://bugs.webkit.org/show_bug.cgi?id=95265
3341
3342         Reviewed by Adam Barth.
3343
3344         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3345         is only used for finding the gdbserver.
3346
3347         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3348         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3349
3350 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3351
3352         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3353         https://bugs.webkit.org/show_bug.cgi?id=95565
3354
3355         Reviewed by Adam Barth.
3356
3357         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3358         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3359         (MockWebRTCPeerConnectionHandler::updateICE):
3360         (MockWebRTCPeerConnectionHandler::addICECandidate):
3361         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3362         (MockWebRTCPeerConnectionHandler):
3363
3364 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3365
3366         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3367         https://bugs.webkit.org/show_bug.cgi?id=95670
3368
3369         Reviewed by Kenneth Rohde Christiansen.
3370
3371         Fix layout issues related to the URL bar in Minibrowser
3372         and EWebLauncher when the window is resized.
3373
3374         The URL bar was not resized accordingly and the Web
3375         page was moved behing the URL bar, hiding part of it.
3376
3377         * EWebLauncher/main.c:
3378         (on_ecore_evas_resize):
3379         (closeWindow):
3380         * EWebLauncher/url_bar.c:
3381         (url_bar_width_set):
3382         (url_bar_add):
3383         * EWebLauncher/url_bar.h:
3384         * MiniBrowser/efl/main.c:
3385         (on_ecore_evas_resize):
3386         (main):
3387
3388 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3389
3390         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3391         https://bugs.webkit.org/show_bug.cgi?id=95605
3392
3393         Reviewed by Dirk Pranke.
3394
3395         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3396
3397         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3398         (ChromiumAndroidPort.check_sys_deps):
3399         (ChromiumAndroidPort.expectations_files):
3400         (ChromiumAndroidPort.clean_up_test_run):
3401
3402 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3403
3404         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3405         https://bugs.webkit.org/show_bug.cgi?id=95180
3406
3407         Reviewed by Chris Fleizach.
3408
3409         The bug that was fixed stood in the way of fully implementing stringValue().
3410         Testing that the bug is fixed requires stringValue() to be fully implemented
3411         and object replacement characters to be printable.
3412
3413         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3414         (replaceCharactersForResults): New method which turns object replacement
3415         characters into "<obj>" so that the characters can be properly shown in
3416         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3417         accessible text of a single object in the accessible tree doesn't mess up
3418         the readibility of the results.
3419         (AccessibilityUIElement::stringValue): Remove the code that immediately
3420         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3421         replaceCharactersForResults() prior to returning the accessible string
3422         value.
3423
3424 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3425
3426         MediaStream API: Add MediaStream management to RTCPeerConnection
3427         https://bugs.webkit.org/show_bug.cgi?id=95543
3428
3429         Reviewed by Adam Barth.
3430
3431         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3432
3433         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3434         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3435         (MockWebRTCPeerConnectionHandler::addStream):
3436         (MockWebRTCPeerConnectionHandler::removeStream):
3437         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3438         (MockWebRTCPeerConnectionHandler):
3439
3440 2012-08-31  Tony Chang  <tony@chromium.org>
3441
3442         Remove ENABLE_CSS3_FLEXBOX compile time flag
3443         https://bugs.webkit.org/show_bug.cgi?id=95382
3444
3445         Reviewed by Ojan Vafai.
3446
3447         Everyone is already enabling this by default and the spec has stablized.
3448
3449         * Scripts/webkitperl/FeatureList.pm:
3450         * qmake/mkspecs/features/features.pri:
3451
3452 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3453
3454         objc_msgSend and IMP should be cast appropriately before using
3455         https://bugs.webkit.org/show_bug.cgi?id=95242
3456
3457         Reviewed by Benjamin Poulain.
3458
3459         Fix for older compilers. Pass id as the return type to the template
3460         instead of relying on default type.
3461
3462         * DumpRenderTree/mac/DumpRenderTree.mm:
3463         (drt_NSFontManager_availableFontFamilies):
3464         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3465         (WTR::wtr_NSFontManager_availableFontFamilies):
3466
3467 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3468
3469         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3470         https://bugs.webkit.org/show_bug.cgi?id=89616
3471
3472         Reviewed by Eric Seidel.
3473
3474         Add the new 'executive' optional function argument to the SCM.in_working_directory
3475         class method. This way we get to reuse an Executive instance which is necessary in testing
3476         when we're operating with a mock version of the object.
3477
3478         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3479         the SCMDetector with the generator's FileSystem and Executive instances.
3480
3481         * Scripts/webkitpy/common/checkout/scm/detection.py:
3482         (SCMDetector.detect_scm_system):
3483         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3484         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3485         Executive output and test it against expected output.
3486         * Scripts/webkitpy/common/checkout/scm/git.py:
3487         (Git.in_working_directory):
3488         * Scripts/webkitpy/common/checkout/scm/scm.py:
3489         (SCM.in_working_directory):
3490         * Scripts/webkitpy/common/checkout/scm/svn.py:
3491         (SVN.in_working_directory):
3492         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3493         (JSONResultsGeneratorBase.__init__):
3494         (JSONResultsGeneratorBase._get_svn_revision):
3495
3496 2012-08-31  Jon Lee  <jonlee@apple.com>
3497
3498         [Tests] Add basic tests to http/tests/notifications
3499         https://bugs.webkit.org/show_bug.cgi?id=95493
3500         <rdar://problem/12209303>
3501
3502         Reviewed by Alexey Proskuryakov.
3503
3504         Add permission request support for WTR.
3505
3506         * WebKitTestRunner/TestController.cpp:
3507         (WTR::TestController::initialize):
3508         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3509         * WebKitTestRunner/TestController.h:
3510         (TestController):
3511
3512 2012-08-31  Jon Lee  <jonlee@apple.com>
3513
3514         [DRT] Make simulating a web click on a notification a queued task
3515         https://bugs.webkit.org/show_bug.cgi?id=95546
3516         <rdar://problem/12214170>
3517
3518         Reviewed by Alexey Proskuryakov.
3519
3520         Making the web click happen asynchronously better mimics user interaction with the platform.
3521
3522         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3523         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3524         not set.
3525         * DumpRenderTree/mac/DumpRenderTree.mm:
3526         (dump): Assert that the flag is not set.
3527         * DumpRenderTree/mac/TestRunnerMac.mm:
3528         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3529         notification. In the case where the block gets executed after the flag has been unset, we avoid
3530         performing the click.
3531
3532 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3533
3534         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3535         https://bugs.webkit.org/show_bug.cgi?id=95575
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         Output 100% difference in the case of differing image dimensions so
3540         the test harness knows that we won't produce any output further.
3541         This matches the behavior of other ports.
3542
3543         * DumpRenderTree/qt/ImageDiff.cpp:
3544         (main):
3545
3546 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3547
3548         Unreviewed, rolling out r127261.
3549         http://trac.webkit.org/changeset/127261
3550         https://bugs.webkit.org/show_bug.cgi?id=95572
3551
3552         This patch depends on other build fixes (see blockers of bug
3553         95466) which should land first (Requested by milian on
3554         #webkit).
3555
3556         * qmake/mkspecs/features/features.prf:
3557
3558 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3559
3560         [Qt] Support WebKit2/QML on QNX
3561         https://bugs.webkit.org/show_bug.cgi?id=95466
3562
3563         Reviewed by Noam Rosenthal.
3564
3565         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3566         this should finally work now.
3567
3568         * qmake/mkspecs/features/features.prf:
3569
3570 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3571
3572         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3573         https://bugs.webkit.org/show_bug.cgi?id=95400
3574
3575         Reviewed by Dirk Pranke.
3576
3577         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3578
3579         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3580         (ChromiumAndroidPort.skipped_layout_tests):
3581
3582 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3583
3584         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3585         https://bugs.webkit.org/show_bug.cgi?id=95499
3586
3587         Unreviewed. One more fix to avoid trying to run the empty string.
3588
3589         * Scripts/webkitdirs.pm:
3590         (buildAutotoolsProject):
3591
3592 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3593
3594         Unreviewed, rolling out r127171.
3595         http://trac.webkit.org/changeset/127171
3596         https://bugs.webkit.org/show_bug.cgi?id=95505
3597
3598         testRunner does not need dumpWebNotificationCallbacks().
3599         (Requested by jonlee on #webkit).
3600
3601         * DumpRenderTree/TestRunner.cpp:
3602         (TestRunner::TestRunner):
3603         (TestRunner::staticFunctions):
3604         * DumpRenderTree/TestRunner.h:
3605         (TestRunner):
3606         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3607         (-[MockWebNotificationProvider webView:didShowNotification:]):
3608         (-[MockWebNotificationProvider webView:didClickNotification:]):
3609         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3610         * DumpRenderTree/mac/UIDelegate.mm:
3611         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3612
3613 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3614
3615         objc_msgSend and IMP should be cast appropriately before using
3616         https://bugs.webkit.org/show_bug.cgi?id=95242
3617
3618         Reviewed by Benjamin Poulain.
3619
3620         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3621         to a function pointer with right types when calling objc_msgSend and an
3622         IMP method directly.
3623
3624         * DumpRenderTree/mac/DumpRenderTree.mm:
3625         (drt_NSFontManager_availableFontFamilies):
3626         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3627         (WTR::wtr_NSFontManager_availableFontFamilies):
3628
3629 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3630
3631         Replace JSC::UString by WTF::String
3632         https://bugs.webkit.org/show_bug.cgi?id=95271
3633
3634         Reviewed by Geoffrey Garen.
3635
3636         Get rid of UString.
3637
3638         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3639         * gdb/webkit.py:
3640         (WTFStringPrinter.to_string):
3641         (JSCIdentifierPrinter.to_string):
3642         (JSCJSStringPrinter.to_string):
3643         (add_pretty_printers):
3644
3645 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3646
3647         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3648         https://bugs.webkit.org/show_bug.cgi?id=95495
3649
3650         Reviewed by Ojan Vafai.
3651
3652         This is a follow-on to bug 95370 that adds in support for
3653         platform/wk2/TestExpectations and
3654         platform/{mac,win}-$version/TestExpectations.
3655
3656         * Scripts/webkitpy/layout_tests/port/apple.py:
3657         (ApplePort.expectations_files):
3658         * Scripts/webkitpy/layout_tests/port/base.py:
3659         (Port._skipped_file_search_paths):
3660         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3661         (MacTest.test_expectations_files):
3662         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3663         (MockDRTPortTest.make_port):
3664         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3665         (WinPortTest.test_expectations_files):
3666
3667 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3668
3669         executive.run_in_parallel() hangs if given nothing to do
3670         https://bugs.webkit.org/show_bug.cgi?id=95387
3671
3672         Reviewed by Ojan Vafai.
3673
3674         Check to make sure that Executive.run_in_parallel() requires
3675         a non-empty list of commands to execute; passing an empty list
3676         seems surely like a programming error.
3677
3678         * Scripts/webkitpy/common/system/executive.py:
3679         (Executive.run_in_parallel):
3680         * Scripts/webkitpy/common/system/executive_unittest.py:
3681         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3682
3683 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3684
3685         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3686         https://bugs.webkit.org/show_bug.cgi?id=94746
3687
3688         Reviewed by Ojan Vafai.
3689
3690         Add an assertion to diff_image() to check that we are passing
3691         tolerance=0 explicitly when diffing ref test results.
3692
3693         * Scripts/webkitpy/layout_tests/port/test.py:
3694         (TestPort.diff_image):
3695
3696 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3697
3698         NRWT should look in mac-wk2 for a TestExpecations file
3699         https://bugs.webkit.org/show_bug.cgi?id=95370
3700
3701         Reviewed by Ojan Vafai.
3702
3703         Adds support for mac-wk2 and win-wk2 to expectations_files()
3704         for the apple mac and apple win ports.
3705         
3706         * Scripts/webkitpy/layout_tests/port/apple.py:
3707         (ApplePort.expectations_files):
3708         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3709         (MacTest.test_expectations_files):
3710         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3711         (WinTest.test_expectations_files):
3712         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3713         (PortTestCase.test_expectations_files):
3714
3715 2012-08-30  Jon Lee  <jonlee@apple.com>
3716
3717         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3718         https://bugs.webkit.org/show_bug.cgi?id=95232
3719         <rdar://problem/12190776>
3720
3721         Reviewed by Alexey Proskuryakov.
3722
3723         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3724
3725         * DumpRenderTree/TestRunner.cpp:
3726         (TestRunner::TestRunner):
3727         (dumpWebNotificationCallbacksCallback):
3728         (TestRunner::staticFunctions):
3729         * DumpRenderTree/TestRunner.h:
3730         (TestRunner):
3731         (TestRunner::dumpWebNotificationCallbacks):
3732         (TestRunner::setDumpWebNotificationCallbacks):
3733         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3734         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3735         (-[MockWebNotificationProvider webView:didShowNotification:]):
3736         (-[MockWebNotificationProvider webView:didClickNotification:]):
3737         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3738         * DumpRenderTree/mac/UIDelegate.mm:
3739         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3740
3741 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3742
3743         MediaStream API: Introduce MediaConstraints
3744         https://bugs.webkit.org/show_bug.cgi?id=95198
3745
3746         Reviewed by Adam Barth.
3747
3748         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3749
3750         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3751         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3752         (isSupportedConstraint):
3753         (isValidConstraint):
3754         (MockWebRTCPeerConnectionHandler::initialize):
3755         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3756         (MockWebRTCPeerConnectionHandler):
3757
3758 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3759
3760         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3761         https://bugs.webkit.org/show_bug.cgi?id=95454
3762
3763         Reviewed by Kenneth Rohde Christiansen.
3764
3765         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3766
3767         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3768         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3769
3770 2012-08-30  Leo Yang  <leoyang@rim.com>
3771
3772         Update my email address.
3773
3774         Not reviewed.
3775
3776         * Scripts/webkitpy/common/config/committers.py:
3777
3778 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3779
3780         [NRWT] Add support for recognizing arbitrary process names in crash lines
3781         https://bugs.webkit.org/show_bug.cgi?id=95435
3782
3783         Reviewed by Adam Barth.
3784
3785         When running layout tests in the chromium port using the content shell,
3786         we want to be able to report sub-process crashes as well.
3787
3788         * Scripts/webkitpy/layout_tests/port/driver.py:
3789         (Driver._check_for_driver_crash):
3790         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3791         (DriverTest.test_check_for_driver_crash):
3792
3793 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3794
3795         Random test-webkitpy failures on the buildbot
3796         https://bugs.webkit.org/show_bug.cgi?id=95096
3797
3798         Reviewed by Dirk Pranke.
3799
3800         Suppress occasional errors when running test-webkitpy on GTK builders
3801         by running these tests serially. The 64-bit Release builder is especially
3802         prone to these as it can run up to 24 tests in parallel.
3803
3804         Despite the tests not being run in parallel, the testing only lasts a handful
3805         of seconds more, so this is a worthy trade-off to avoid unnecessary
3806         false-alarm redness on the GTK builders.
3807
3808         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3809         (RunPythonTests.start):
3810
3811 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3812
3813         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3814         https://bugs.webkit.org/show_bug.cgi?id=95380
3815
3816         Reviewed by Michael Saboff.
3817
3818         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3819         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3820         the crash.
3821
3822 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3823
3824         AX: Canvas should have a distinct role
3825         https://bugs.webkit.org/show_bug.cgi?id=95248
3826
3827         Reviewed by Chris Fleizach.
3828
3829         Add support for canvas accessibility role.
3830
3831         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3832         (roleToString):
3833
3834 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3835
3836         [Gtk] Process Gtk 3.4 smooth scroll events properly
3837         https://bugs.webkit.org/show_bug.cgi?id=88070
3838
3839         Added continousMouseScrollBy support in WebKitTestRunner, and added
3840         implementation for gtk, and stub for Qt, mac and EFL.
3841
3842         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3843         scroll for emulating multi-tick mouseScrollBy events.
3844
3845         Reviewed by Martin Robinson.
3846
3847         * DumpRenderTree/gtk/EventSender.cpp:
3848         (mouseScrollByCallback):
3849         (continuousMouseScrollByCallback):
3850         * WebKitTestRunner/EventSenderProxy.h:
3851         (EventSenderProxy):
3852         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3853         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3854         (WTR::EventSendingController::mouseScrollBy):
3855         (WTR):
3856         (WTR::EventSendingController::continuousMouseScrollBy):
3857         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3858         (EventSendingController):
3859         * WebKitTestRunner/TestController.cpp:
3860         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3861         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3862         (WTR):
3863         (WTR::EventSenderProxy::mouseScrollBy):
3864         (WTR::EventSenderProxy::continuousMouseScrollBy):
3865         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3866         (WTR):
3867         (WTR::EventSenderProxy::continuousMouseScrollBy):
3868         * WebKitTestRunner/mac/EventSenderProxy.mm:
3869         (WTR::EventSenderProxy::continuousScrollBy):
3870         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3871         (WTR::EventSenderProxy::continuousMouseScrollBy):
3872         (WTR):
3873
3874 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3875
3876         [chromium] Support high DIP pixel tests with DumpRenderTree
3877         https://bugs.webkit.org/show_bug.cgi?id=94935
3878
3879         Reviewed by James Robinson.
3880
3881         Adding device scale factor into the drt image dumping code
3882
3883         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3884         (DRTTestRunner::reset):
3885         (DRTTestRunner::setBackingScaleFactor):
3886         * DumpRenderTree/chromium/WebViewHost.cpp:
3887         (WebViewHost::setDeviceScaleFactor):
3888         (WebViewHost::paintInvalidatedRegion):
3889         (WebViewHost::canvas):
3890         * DumpRenderTree/chromium/WebViewHost.h:
3891         (WebViewHost):
3892
3893 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3894
3895         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3896         https://bugs.webkit.org/show_bug.cgi?id=95177
3897
3898         Reviewed by Dirk Pranke.
3899
3900         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3901
3902         * Scripts/webkitpy/common/checkout/scm/git.py:
3903
3904 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3905
3906         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3907         https://bugs.webkit.org/show_bug.cgi?id=95222
3908
3909         Reviewed by Adam Barth.
3910
3911         The code we had to remove REBASELINE lines from the
3912         TestExpectations files did not handle multiple files (in a
3913         cascade) correctly; we weren't limiting lines to a particular
3914         file correctly in without_rebaseline_modifier(). This patch
3915         fixes that and corrects the tests (which weren't correct and
3916         didn't cover things very well).
3917
3918         Note also that the webkit-patch rebaseline-commands are still
3919         using the include_overrides=False option in a couple places;
3920         this is never correct or needed at this point. This patch fixes
3921         the usage for webkit-patch rebaseline-expectations, but I still
3922         need to fix rebaseline-test-internal, which I will do in a
3923         separate patch (see bug 95268).
3924
3925         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3926         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3927         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3928         (RebaseliningTest.assertRemove):
3929         (RebaseliningTest.test_remove):
3930         * Scripts/webkitpy/tool/commands/rebaseline.py:
3931         (RebaselineExpectations._update_expectations_files):
3932
3933 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3934
3935         webkit-patch rebaseline-expectations hangs
3936         https://bugs.webkit.org/show_bug.cgi?id=95243
3937
3938         Reviewed by Tony Chang.
3939
3940         Don't try to run no commands in parallel; report an error
3941         instead that we didn't find any tests to rebaseline.
3942
3943         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3944
3945         * Scripts/webkitpy/tool/commands/rebaseline.py:
3946         (RebaselineExpectations.execute):
3947         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3948         (_assert_command):
3949         (test_rebaseline_expectations_noop):
3950
3951 2012-08-29  Brady Eidson  <beidson@apple.com>
3952
3953         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3954         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3955
3956         Reviewed by Sam Weinig.
3957
3958         Add a test plug-in that calls back into the page with info on the NPWindow passed
3959         in to NPP_SetWindow.
3960
3961         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3962         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3963         (LogNPPSetWindow):
3964         (LogNPPSetWindow::LogNPPSetWindow):
3965         (LogNPPSetWindow::NPP_SetWindow):
3966
3967 2012-08-29  Jon Lee  <jonlee@apple.com>
3968
3969         [Mac] Basic DRT support for web notifications
3970         https://bugs.webkit.org/show_bug.cgi?id=79492
3971         <rdar://problem/10357639>
3972
3973         Reviewed by Alexey Proskuryakov.
3974
3975         This patch implements the stubs for web notification support on DRT. Assume that when
3976         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3977         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3978
3979         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3980         * DumpRenderTree/mac/DumpRenderTree.mm:
3981         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3982         web view.
3983         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3984
3985         * DumpRenderTree/mac/TestRunnerMac.mm:
3986         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3987         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3988         (TestRunner::removeAllWebNotificationPermissions):
3989         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3990         simulate the click. This is similar to how WTR performs the click.
3991         * DumpRenderTree/mac/UIDelegate.mm:
3992         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3993         user allows web notifications.
3994
3995         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3996         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3997         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3998         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3999         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
4000         (-[MockWebNotificationProvider registerWebView:]):
4001         (-[MockWebNotificationProvider unregisterWebView:]):
4002         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
4003         notification did show.
4004         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
4005         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
4006         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
4007         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
4008         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
4009         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
4010         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
4011         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
4012         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
4013         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
4014         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
4015
4016 2012-08-29  Rob Buis  <rbuis@rim.com>
4017
4018         [BlackBerry] Adjust wtf include header style
4019         https://bugs.webkit.org/show_bug.cgi?id=95368
4020
4021         Reviewed by Yong Li.
4022
4023         Switch to #include <wtf/...> like the other ports.
4024
4025         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4026         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
4027         * DumpRenderTree/blackberry/PNGImageEncoder.h:
4028         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
4029         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
4030         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
4031
4032 2012-08-29  Roger Fong  <roger_fong@apple.com>
4033
4034         Update cygwin-downloader.zip to match modified downloader script.
4035         https://bugs.webkit.org/show_bug.cgi?id=76936
4036
4037         Rubber Stamped by Jon Honeycutt.
4038
4039         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
4040         Updating zip to reflect changes.
4041
4042         * CygwinDownloader/cygwin-downloader.zip:
4043
4044 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4045
4046         Stylechecker warns about comparison to zero when comparing to 0.5
4047         https://bugs.webkit.org/show_bug.cgi?id=94913
4048
4049         Reviewed by Dirk Pranke.
4050
4051         According to the python documentation, \W is the character group with all
4052         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
4053         to [^\w]. We need to exclude the dot "." as well, so that floating point
4054         values do not trigger this warning. Adding a unit test that shows the problem.
4055
4056         * Scripts/webkitpy/style/checkers/cpp.py:
4057         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
4058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4059         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
4060
4061 2012-08-29  Jon Lee  <jonlee@apple.com>
4062
4063         WTR build fixes.
4064
4065         * WebKitTestRunner/CMakeLists.txt:
4066         * WebKitTestRunner/GNUmakefile.am:
4067         * WebKitTestRunner/Target.pri:
4068         * WebKitTestRunner/WebNotificationProvider.cpp:
4069         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
4070         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4071
4072 2012-08-29  Jon Lee  <jonlee@apple.com>
4073
4074         [WK2] Basic WTR support for web notifications
4075         https://bugs.webkit.org/show_bug.cgi?id=95154
4076         <rdar://problem/12184492>
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         Implement WTR support, without platform event output (bug 95233).
4081
4082         Legacy APIs will not be supported, since many of the tests are skipped
4083         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
4084         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
4085         the tests to http/tests/notifications.
4086
4087         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
4088         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
4089         be invoked from the UIProcess.
4090
4091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4092         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4093         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
4094         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
4095         notification's internal ID.
4096         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4097         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4098         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
4099         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
4100         (WTR::TestRunner::removeAllWebNotificationPermissions):
4101         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
4102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4103
4104         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
4105         class.
4106         * WebKitTestRunner/TestInvocation.cpp:
4107         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
4108         TestInvocation forwards that request to the TestController.
4109         * WebKitTestRunner/TestController.cpp:
4110         (WTR::TestController::initialize): Set the provider.
4111         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
4112         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
4113         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
4114
4115         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
4116         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
4117         * WebKitTestRunner/WebNotificationProvider.h: Added.
4118         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
4119         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
4120         the notification got shown.
4121         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
4122         got closed.
4123         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
4124         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
4125         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
4126         permissions. For testing purposes, we always want this set to be empty.
4127         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
4128         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
4129
4130         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
4131
4132 2012-08-29  Kamil Blank  <k.blank@samsung.com>
4133
4134         [EFL] Add setting API for allow universal/file access from file URLs.
4135         https://bugs.webkit.org/show_bug.cgi?id=83121
4136
4137         Reviewed by Eric Seidel.
4138
4139         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
4140
4141         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4142         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4143         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4144         (TestRunner::setAllowUniversalAccessFromFileURLs):
4145         (TestRunner::setAllowFileAccessFromFileURLs):
4146
4147 2012-08-29  Jon Lee  <jonlee@apple.com>
4148
4149         Update TestRunner API for web notifications
4150         https://bugs.webkit.org/show_bug.cgi?id=95093
4151         <rdar://problem/12179649>
4152
4153         Reviewed by Alexey Proskuryakov.
4154
4155         As it turns out the patch for this accidentally got squashed into the commit for
4156         bug 95099 (r126909). This amendment patch adds some comments about the renaming
4157         of the older TestRunner API for web notifications.
4158
4159         * DumpRenderTree/TestRunner.h:
4160         (TestRunner):
4161
4162 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4163
4164         Unreviewed, rolling out r126972.
4165         http://trac.webkit.org/changeset/126972
4166         https://bugs.webkit.org/show_bug.cgi?id=95349
4167
4168         accessibility/canvas-description-and-role.html has been
4169         failing consistently on several bots and Dominic needs some
4170         time to investigate why (Requested by jchaffraix on #webkit).
4171
4172         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4173         (roleToString):
4174
4175 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
4176
4177         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
4178         https://bugs.webkit.org/show_bug.cgi?id=84707
4179
4180         Reviewed by Gustavo Noronha Silva.
4181
4182         Most of the warnings have been fixed now that FindCairo.cmake and
4183         FindGLIB.cmake have been rewritten. The remaining one, related to
4184         FindFontconfig.cmake, shows up when building on a 64-bit
4185         Debian-based systems.
4186
4187         jhbuild installs libraries into lib64/ by default on 64-bit Linux
4188         installations, while CMake does not look for libraries in lib64/
4189         when /etc/debian_version exists on the system. The FIND_LIBRARY()
4190         would then sometimes end up using the system installation instead of
4191         the jhbuild one, causing mismatches and, when pkg-config is not used
4192         at all, failing to find libraries altogether.
4193
4194         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
4195         when use_lib64 is set to force CMake to look into lib64/ regardless
4196         of the presence of /etc/debian_version.
4197
4198 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4199
4200         The 2d.imageData.object.round canvas test is failing
4201         https://bugs.webkit.org/show_bug.cgi?id=40272
4202
4203         Reviewed by Benjamin Poulain.
4204
4205         Updating patch to address Benjamin's review comments.
4206         Adding a WTF test to test lrint implementation.
4207
4208         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
4209         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
4210         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
4211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
4212         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
4213         (TestWebKitAPI):
4214         (TestWebKitAPI::TEST):
4215         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
4216
4217 2012-08-29  Florin Malita  <fmalita@chromium.org>
4218
4219         Unreviewed, updating Kelly Norton's email address at his request.
4220
4221         * Scripts/webkitpy/common/config/committers.py:
4222
4223 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
4224
4225         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
4226         https://bugs.webkit.org/show_bug.cgi?id=93723
4227
4228         Reviewed by Dirk Pranke.
4229
4230         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4231         (TestExpectationParser.expectation_for_skipped_test):
4232         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4233         (SkippedTests.test_skipped_entry_dont_exist):
4234
4235 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4236
4237         Unreviewed, rolling out r120113.
4238         http://trac.webkit.org/changeset/120113
4239         https://bugs.webkit.org/show_bug.cgi?id=95320
4240
4241         Wrong fix for the problem, experimentally rolling it out for
4242         bug 95237. (Requested by rakuco on #webkit).
4243
4244         * efl/jhbuildrc:
4245
4246 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
4247
4248         AX: Canvas should have a distinct role
4249         https://bugs.webkit.org/show_bug.cgi?id=95248
4250
4251         Reviewed by Chris Fleizach.
4252
4253         Add support for canvas accessibility role.
4254
4255         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4256         (roleToString):
4257
4258 2012-08-28  Eric Seidel  <eric@webkit.org>
4259
4260         cr-ews bot doesn't set CWD correctly when zipping layout test results
4261         https://bugs.webkit.org/show_bug.cgi?id=91265
4262
4263         Reviewed by Kenneth Russell.
4264
4265         This should make the zips slightly less cumbersome to deal with.
4266
4267         * Scripts/webkitpy/common/system/workspace.py:
4268         (Workspace.create_zip):
4269         * Scripts/webkitpy/common/system/workspace_unittest.py:
4270         (WorkspaceTest.test_create_zip):
4271         (WorkspaceTest.test_create_zip_exception):
4272
4273 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
4274
4275         Fix the Commiters script
4276
4277         Unreviewed.
4278
4279         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
4280
4281         * Scripts/webkitpy/common/config/committers.py:
4282
4283 2012-08-28  Roger Fong  <roger_fong@apple.com>
4284
4285         Unreviewed. Adding myself to committers list.
4286
4287         * Scripts/webkitpy/common/config/committers.py:
4288
4289 2012-08-28  Roger Fong  <roger_fong@apple.com>
4290
4291         Add minires to list of required cygwin install packages.
4292         https://bugs.webkit.org/show_bug.cgi?id=76936
4293
4294         Reviewed by Tim Horton.
4295
4296         * CygwinDownloader/cygwin-downloader.py:
4297
4298 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
4299
4300         [Chromium-Android] Upstream layout test expectations (Part 2)
4301         https://bugs.webkit.org/show_bug.cgi?id=95212
4302
4303         Reviewed by Adam Barth.
4304
4305         - Now run both gpu path and non-gpu path of 2d canvas layout tests
4306         because both are used in chromium-android.
4307
4308         - Exclude all webgl tests because webgl is not enabled yet.
4309
4310         - Removed 'win' from the baseline fallback list. This was a mistake.
4311
4312         - Moved some small directories to TestExpectations from skipped_layout_tests().
4313
4314         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4315         (ChromiumAndroidPort):