[CG] Adding support for HEIF-sequence ('public.heics') images
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
2
3         [CG] Adding support for HEIF-sequence ('public.heics') images
4         https://bugs.webkit.org/show_bug.cgi?id=197384
5
6         Reviewed by Simon Fraser.
7
8         * DumpRenderTree/TestOptions.cpp:
9         (TestOptions::TestOptions):
10         * DumpRenderTree/TestOptions.h:
11         * DumpRenderTree/mac/DumpRenderTree.mm:
12         (resetWebViewToConsistentStateBeforeTesting):
13         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
14         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
15         the test.
16
17         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
18         (WTR::InjectedBundle::stringForKey):
19         (WTR::InjectedBundle::beginTesting):
20         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
21         * WebKitTestRunner/TestController.cpp:
22         (WTR::TestController::resetStateToConsistentValues):
23         (WTR::updateTestOptionsFromTestHeader):
24         * WebKitTestRunner/TestInvocation.cpp:
25         (WTR::TestInvocation::createTestSettingsDictionary):
26         * WebKitTestRunner/TestOptions.h:
27         (WTR::TestOptions::hasSameInitializationOptions const):
28         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
29         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
30         the test.
31
32 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
33
34         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
35         https://bugs.webkit.org/show_bug.cgi?id=197730
36
37         Reviewed by Filip Pizlo.
38
39         * TestWebKitAPI/CMakeLists.txt:
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
42         (TestWebKitAPI::TEST):
43         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
44         (TestWebKitAPI::TEST):
45
46 2019-05-10  Chris Dumez  <cdumez@apple.com>
47
48         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
49
50         It became flaky after r245198.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
53
54 2019-05-10  Youenn Fablet  <youenn@apple.com>
55
56         A service worker instance should be terminated when its SWServer is destroyed
57         https://bugs.webkit.org/show_bug.cgi?id=197801
58         <rdar://problem/50587270>
59
60         Reviewed by Chris Dumez.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
63
64 2019-05-10  Chris Dumez  <cdumez@apple.com>
65
66         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
67         https://bugs.webkit.org/show_bug.cgi?id=197750
68
69         Reviewed by Geoffrey Garen.
70
71         Add API test coverage.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
74         (TEST):
75
76 2019-05-10  Keith Miller  <keith_miller@apple.com>
77
78         Remove legacy test262 import script
79         https://bugs.webkit.org/show_bug.cgi?id=197788
80
81         Reviewed by Yusuke Suzuki.
82
83         import-test262-tests doesn't work anymore. We should be using test262-import instead.
84
85         * Scripts/import-test262-tests: Removed.
86
87 2019-05-10  Charlie Turner  <cturner@igalia.com>
88
89         [WPE] Forward libepoxy cflags
90         https://bugs.webkit.org/show_bug.cgi?id=197784
91
92         Reviewed by Žan Doberšek.
93
94         Patch by Zan Dobersek.
95
96         * wpe/backends/CMakeLists.txt: This is required to keep
97         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
98         up trying to include X11 headers even when they're not present in the
99         environment.
100
101 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
102
103         Fix a bunch of compiler warnings
104         https://bugs.webkit.org/show_bug.cgi?id=197785
105
106         Reviewed by Don Olmstead.
107
108         Add preprocessor guards to avoid -Wunused-function warnings.
109
110         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
111         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
112         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
113
114 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
115
116         [WPE][GTK] Add webkit_frame_get_id() API
117         https://bugs.webkit.org/show_bug.cgi?id=197270
118
119         Reviewed by Carlos Garcia Campos.
120
121         This was hard, but I added a test to verify that two different WebKitFrames of the same
122         WebKitWebPage return two different frame IDs.
123
124         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
125         (WebKitFrameTest::willSubmitFormCallback):
126         (WebKitFrameTest::testSubframe):
127         (registerTests):
128         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
129         (testWebKitFrameSubframe):
130         (beforeAll):
131         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
132         (willSubmitFormCallback):
133         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
134         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
135
136 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
137
138         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
139         https://bugs.webkit.org/show_bug.cgi?id=197271
140
141         Reviewed by Youenn Fablet.
142
143         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
144         (formControlsAssociatedForFrameCallback):
145         (pageCreatedCallback):
146         (formControlsAssociatedCallback): Deleted.
147
148 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
149
150         [Flatpak] Use the safe PyYAML loader if available
151         https://bugs.webkit.org/show_bug.cgi?id=197771
152
153         Reviewed by Philippe Normand.
154
155         * flatpak/flatpakutils.py:
156         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
157         still used as fallback when the former is not provided by the module.
158
159 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
160
161         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
162         https://bugs.webkit.org/show_bug.cgi?id=197734
163
164         Reviewed by Don Olmstead.
165
166         * Scripts/webkitpy/port/win.py:
167         (WinCairoPort._search_paths): Add 'wk2' and
168         additional_platform_directory to paths as well as other ports do.
169
170 2019-05-09  Daniel Bates  <dabates@apple.com>
171
172         [iOS] Numpad comma key has incorrect keyIdentifier property
173         https://bugs.webkit.org/show_bug.cgi?id=197753
174         <rdar://problem/50636274>
175
176         Reviewed by Brent Fulgham.
177
178         Recognize "numpadComma" and return the appropriate HID usage code.
179
180         * WebKitTestRunner/ios/HIDEventGenerator.mm:
181         (hidUsageCodeForCharacter):
182
183 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
184
185         Refine AudioSession route sharing policy
186         https://bugs.webkit.org/show_bug.cgi?id=197742
187         <rdar://problem/50590818>
188
189         Reviewed by Darin Adler.
190
191         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
192         (TestWebKitAPI::TEST):
193
194 2019-05-09  Alex Christensen  <achristensen@webkit.org>
195
196         Remove unnecessary test SPI after r244883
197         https://bugs.webkit.org/show_bug.cgi?id=197575
198
199         Reviewed by Tim Horton.
200
201         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
202         (TEST):
203         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
204         (TestWebKitAPI::TEST):
205
206 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
207
208         [ews-app] Add migrations file to repository
209         https://bugs.webkit.org/show_bug.cgi?id=197729
210
211         Reviewed by Jonathan Bedard.
212
213         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
214
215 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews-build] Fix formatting issues and typos
218         https://bugs.webkit.org/show_bug.cgi?id=197737
219
220         Reviewed by Jonathan Bedard.
221
222         * BuildSlaveSupport/ews-build/steps.py:
223         (CompileWebKit.evaluateCommand): Removed extra empty line.
224         * BuildSlaveSupport/ews-build/steps_unittest.py:
225         (TestRunWebKitPerlTests): Fixed typo.
226         * BuildSlaveSupport/ews-app/ews/models/step.py:
227         (Step.save_step): Changed log level to info so that it is logged in production.
228
229 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
230
231         [ews-app] Production and Development env should configure DEBUG appropriately
232         https://bugs.webkit.org/show_bug.cgi?id=197700
233
234         Reviewed by Jonathan Bedard.
235
236         * BuildSlaveSupport/ews-app/ews-app/settings.py:
237
238 2019-05-09  Xan López  <xan@igalia.com>
239
240         [CMake] Detect SSE2 at compile time
241         https://bugs.webkit.org/show_bug.cgi?id=196488
242
243         Reviewed by Carlos Garcia Campos.
244
245         * Scripts/webkitdirs.pm:
246         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
247         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
248
249 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
250
251         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
252         https://bugs.webkit.org/show_bug.cgi?id=197697
253
254         Reviewed by Žan Doberšek.
255
256         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
257         * wpe/jhbuild.modules: Ditto.
258
259 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
260
261         Update ANGLE
262         https://bugs.webkit.org/show_bug.cgi?id=197676
263
264         Reviewed by Alex Christensen.
265
266         * TestWebKitAPI/PlatformWin.cmake:
267         Remove unnecessary library linkage.
268
269 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
270
271         [Win] build-webkit should be ready for Visual Studio 2019
272         https://bugs.webkit.org/show_bug.cgi?id=196622
273
274         Reviewed by Ross Kirsling.
275
276         1. Accommodated to the new msbuild.exe location of VS 2019.
277         2. Removed the hard coded "Visual Studio 15" generator.
278
279         build-webkit is going to choose a Visual Studio generator version
280         matching with the latest installed VS. If you invoke vcvars.bat
281         before build-webkit, it chooses the corresponding Visual Studio
282         generator version by cheking 'VisualStudioVersion' env var which
283         is set by vcvars.bat.
284
285         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
286         (msBuildPath): When looking for MSBuild, look in
287         "MSBuild\Current\bin" (the new expected location) and fallback
288         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
289         first location.
290         (msBuildInstallDir): Renamed to msBuildPath.
291         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
292         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
293
294 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
295
296         [PlayStation] Update port options
297         https://bugs.webkit.org/show_bug.cgi?id=197723
298
299         Reviewed by Ross Kirsling.
300
301         ICU headers were missing from TestWTF.
302
303         * TestWebKitAPI/PlatformPlayStation.cmake:
304
305 2019-05-08  Alex Christensen  <achristensen@webkit.org>
306
307         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
308         https://bugs.webkit.org/show_bug.cgi?id=197712
309         <rdar://problem/50429770>
310
311         Reviewed by Tim Horton.
312
313         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
314         (TestWebKitAPI::TEST):
315
316 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
317
318         Change my status to be a WebKit reviewer.
319
320         * Scripts/webkitpy/common/config/contributors.json:
321
322 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
323
324         Unreviewed, rolling out r244952.
325
326         Caused inspector to appear blank.
327
328         Reverted changeset:
329
330         "Web Inspector: Provide UIString descriptions to improve
331         localizations"
332         https://bugs.webkit.org/show_bug.cgi?id=195132
333         https://trac.webkit.org/changeset/244952
334
335 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
336
337         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
338         https://bugs.webkit.org/show_bug.cgi?id=197685
339
340         Reviewed by Alex Christensen.
341
342         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
343         completion. See LayoutTests/ChangeLog for more details.
344
345         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
346         (WTR::UIScriptController::platformClearAllCallbacks):
347
348 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
349
350         Unreviewed. Add myself as a committer.
351
352         * Scripts/webkitpy/common/config/contributors.json:
353
354 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
355
356         Unreviewed, rolling out r245038.
357
358         Breaks internal builds.
359
360         Reverted changeset:
361
362         "Add SPI to set a list of hosts to which to send custom header
363         fields cross-origin"
364         https://bugs.webkit.org/show_bug.cgi?id=197397
365         https://trac.webkit.org/changeset/245038
366
367 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
368
369         Unreviewed. Add myself as a committer.
370
371         * Scripts/webkitpy/common/config/contributors.json:
372
373 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
374
375         Define media buffering policy
376         https://bugs.webkit.org/show_bug.cgi?id=196979
377         <rdar://problem/28383861>
378
379         Reviewed by Jer Noble.
380
381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
382         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
383         (waitUntilBufferingPolicyIsEqualTo):
384         (TEST):
385
386 2019-05-07  Alex Christensen  <achristensen@webkit.org>
387
388         Add SPI to set a list of hosts to which to send custom header fields cross-origin
389         https://bugs.webkit.org/show_bug.cgi?id=197397
390
391         Reviewed by Geoff Garen.
392
393         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
394         (TEST):
395         (expectLegacyHeaders):
396         (expectHeaders):
397         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
398         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
399         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
400
401 2019-05-07  Keith Rollin  <krollin@apple.com>
402
403         Add option to build-webkit to control whether or not XCBuild is used
404         https://bugs.webkit.org/show_bug.cgi?id=197668
405         <rdar://problem/50549728>
406
407         Reviewed by Tim Horton.
408
409         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
410         Also update build-webkit and the makefiles with the foundation for
411         automatically using XCBuild when the conditions allow it. This latter
412         facility is currently turned off until Xcode fully supports building
413         WebKit with XCBuild.
414
415         * Scripts/build-webkit:
416         * Scripts/webkitdirs.pm:
417         (XcodeOptions):
418         (canUseXCBuild):
419
420 2019-05-07  Andy Estes  <aestes@apple.com>
421
422         run-bindings-tests should test global scope constructor generation
423         https://bugs.webkit.org/show_bug.cgi?id=197669
424
425         Reviewed by Alex Christensen.
426
427         * Scripts/webkitpy/bindings/main.py:
428         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
429         invoking preprocess-idls.pl.
430
431 2019-05-07  Youenn Fablet  <youenn@apple.com>
432
433         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
434         https://bugs.webkit.org/show_bug.cgi?id=195997
435         <rdar://problem/50509884>
436
437         Reviewed by Chris Dumez.
438
439         Spin test until successful.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
442
443 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
444
445         [Flatpak] webkit-build fails due to missing GTK2 in build environment
446         https://bugs.webkit.org/show_bug.cgi?id=197352
447
448         Reviewed by Philippe Normand.
449
450         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
451         to build it ourselves on top in order to be able to build the GTK 2.x plugin
452         process.
453
454         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
455
456 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
457
458         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
459         https://bugs.webkit.org/show_bug.cgi?id=197644
460         <rdar://problem/50526364>
461
462         Reviewed by Tim Horton.
463
464         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
465
466         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
467         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
468         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
469         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
470
471 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
472
473         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
474         https://bugs.webkit.org/show_bug.cgi?id=197651
475
476         Reviewed by Žan Doberšek.
477
478         This is required since the process creation was delayed until something is loaded in the view.
479
480         * MiniBrowser/gtk/BrowserWindow.c:
481         (browser_window_get_or_create_web_view_for_automation):
482         * MiniBrowser/wpe/main.cpp:
483         (main):
484
485 2019-05-06  Tim Horton  <timothy_horton@apple.com>
486
487         _overrideViewportWithArguments does not work when called before loading
488         https://bugs.webkit.org/show_bug.cgi?id=197638
489         <rdar://problem/50505111>
490
491         Reviewed by Wenson Hsieh.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
494         (TEST):
495
496 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
497
498         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
499         https://bugs.webkit.org/show_bug.cgi?id=197510
500
501         Reviewed by Alex Christensen.
502
503         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
504         (TestWebKitAPI::TEST):
505
506 2019-05-06  Keith Rollin  <krollin@apple.com>
507
508         Temporarily disable generate-xcfilelists
509         https://bugs.webkit.org/show_bug.cgi?id=197619
510         <rdar://problem/50507392>
511
512         Reviewed by Alex Christensen.
513
514         We need to perform a significant update to the generate-xcfilelist
515         scripts. This work involves coordinated work with another facility. If
516         the work does not occur in tandem, the build will be broken. To avoid
517         this, disable the invoking of the scripts during the transition. The
518         checking will be restored once the new scripts are in place.
519
520         * DumpRenderTree/Scripts/check-xcfilelists.sh:
521         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
522
523 2019-05-04  Alex Christensen  <achristensen@webkit.org>
524
525         Revert r244953 and r244954 because they broke internal builds.
526         https://bugs.webkit.org/show_bug.cgi?id=197534
527
528         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
529         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
530         * DumpRenderTree/mac/DumpRenderTree.mm:
531         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
532         * DumpRenderTree/mac/TestRunnerMac.mm:
533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
534         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
535         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
536         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
537         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
538         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
539         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
540         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
541         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
542         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
543         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
544         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
545         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
546         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
547         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
548         * TestWebKitAPI/cocoa/TestWKWebView.mm:
549         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
550         * TestWebKitAPI/ios/UIKitSPI.h: Added.
551         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
552         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
553         * WebKitTestRunner/ios/HIDEventGenerator.h:
554         * WebKitTestRunner/ios/HIDEventGenerator.mm:
555         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
556         * WebKitTestRunner/ios/TestControllerIOS.mm:
557         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
558         * WebKitTestRunner/ios/mainIOS.mm:
559
560 2019-05-04  Alex Christensen  <achristensen@webkit.org>
561
562         Merge the three UIKitSPI.h files into a single one in PAL
563         https://bugs.webkit.org/show_bug.cgi?id=197534
564
565         Reviewed by Darin Adler.
566
567         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
568         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
569         * DumpRenderTree/mac/DumpRenderTree.mm:
570         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
571         * DumpRenderTree/mac/TestRunnerMac.mm:
572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
573         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
574         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
575         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
576         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
577         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
578         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
579         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
580         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
581         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
582         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
583         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
584         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
585         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
586         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
587         * TestWebKitAPI/cocoa/TestWKWebView.mm:
588         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
589         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
590         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
591         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
592         * WebKitTestRunner/ios/HIDEventGenerator.h:
593         * WebKitTestRunner/ios/HIDEventGenerator.mm:
594         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
595         * WebKitTestRunner/ios/TestControllerIOS.mm:
596         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
597         * WebKitTestRunner/ios/mainIOS.mm:
598
599 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
600
601         Web Inspector: Provide UIString descriptions to improve localizations
602         https://bugs.webkit.org/show_bug.cgi?id=195132
603         <rdar://problem/48457817>
604
605         Reviewed by Devin Rousso.
606
607         Allow WI.UIString to take:
608         - WI.UIString(string, key, comment)
609         - WI.UIString(string, comment)
610         - WI.UIString(string)
611
612         * Scripts/extract-localizable-js-strings:
613
614 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
615
616         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
617         https://bugs.webkit.org/show_bug.cgi?id=197579
618
619         Reviewed by Tim Horton.
620
621         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
622         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
623         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
624         ensure that the the focused element has been blurred.
625
626         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
627
628 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
629
630         Add a tool to block spammer accounts
631         https://bugs.webkit.org/show_bug.cgi?id=197537
632
633         Reviewed by Darin Adler.
634
635         Usage: block-spammers email1 email2 ...
636
637         The tool finds and hides all bugs and comments from this account. Before any work
638         is done, these bugs and comments are displayed for confirmation.
639
640         * Scripts/block-spammers: Added.
641         (get_bugzilla_token):
642         (invalidate_bugzilla_token):
643         (get_user_info):
644         (get_user_info_self):
645         (can_use_this_tool):
646         (disable_user):
647         (get_bugs_created_by_user):
648         (get_bugs_commented_on_by_user):
649         (get_comments):
650         (hide_bug):
651         (hide_comments):
652         (ask_yes_no):
653         (sanitized_string):
654         (main):
655
656 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
657
658         run-apit-tests: Add --iterations and --repeat-each
659         https://bugs.webkit.org/show_bug.cgi?id=197563
660
661         Reviewed by Aakash Jain.
662
663         * Scripts/webkitpy/api_tests/manager.py:
664         (Manager.run): Add --iterations and --repeat-each/
665         * Scripts/webkitpy/api_tests/run_api_tests.py:
666         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
667
668 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
669
670         New EWS: Clicking on white bubble navigates to page with only bubbles
671         https://bugs.webkit.org/show_bug.cgi?id=197520
672
673         Reviewed by Lucas Forschler.
674
675         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
676
677 2019-05-03  Daniel Bates  <dabates@apple.com>
678
679         [lldb-webkit] Support adding pretty-printing for qualified types
680         https://bugs.webkit.org/show_bug.cgi?id=197518
681
682         Reviewed by Darin Adler.
683
684         Remove all "::"s from the name of the specified type when computing the name for the Python classes
685         that will provide summary and synthetic details as LLDB is not happy about registering such classes
686         when they contain :: in their name.
687
688         * lldb/lldb_webkit.py:
689         (addSummaryAndSyntheticFormattersForRawBitmaskType):
690
691 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
692
693         New EWS: patches on recently added queues listed as #1 for older bugs
694         https://bugs.webkit.org/show_bug.cgi?id=197496
695
696         Reviewed by Lucas Forschler.
697
698         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
699         (StatusBubble._build_bubble):
700         (StatusBubble._queue_position):
701
702 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
703
704         webkit-patch --no-review upload does not submit patch to New EWS
705         https://bugs.webkit.org/show_bug.cgi?id=197519
706         <rdar://problem/50424887>
707
708         Reviewed by Lucas Forschler.
709
710         * Scripts/webkitpy/tool/steps/submittoews.py:
711         (SubmitToEWS.run): Submit to both old and new EWS.
712         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
713         * Scripts/webkitpy/common/net/ewsserver.py: Added.
714         (EWSServer._server_url): Method to return server url.
715         (EWSServer._post_patch_to_ews): Method to post patch to ews.
716         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
717         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
718         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
719         * Scripts/webkitpy/common/net/statusserver_mock.py:
720         (MockStatusServer.submit_to_ews): Updated the log text.
721         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
722         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
723         * Scripts/webkitpy/tool/main.py:
724         (WebKitPatch.__init__): Initialize ews_server. 
725         * Scripts/webkitpy/tool/mocktool.py:
726         (MockTool.__init__): Ditto.
727
728 2019-05-03  Chris Dumez  <cdumez@apple.com>
729
730         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
731         https://bugs.webkit.org/show_bug.cgi?id=197574
732         <rdar://problem/50453181>
733
734         Reviewed by Tim Horton.
735
736         Add API test coverage.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
739         (TEST):
740
741 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
742
743         [JSC] Generator CodeBlock generation should be idempotent
744         https://bugs.webkit.org/show_bug.cgi?id=197552
745
746         Reviewed by Keith Miller.
747
748         * Scripts/run-javascriptcore-tests:
749         (runJSCStressTests):
750         * Scripts/run-jsc-stress-tests:
751
752 2019-05-03  Commit Queue  <commit-queue@webkit.org>
753
754         Unreviewed, rolling out r244881.
755         https://bugs.webkit.org/show_bug.cgi?id=197559
756
757         Breaks compilation of jsconly on linux, breaking compilation
758         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
759         guijemont on #webkit).
760
761         Reverted changeset:
762
763         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
764         WEBKIT_COPY_FILES"
765         https://bugs.webkit.org/show_bug.cgi?id=197174
766         https://trac.webkit.org/changeset/244881
767
768 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
769
770         Unreviewed WPE build fix after r244898.
771
772         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
773         (WTR::TestController::abortModal): Add the missing (no-op) definition.
774
775 2019-05-02  Alex Christensen  <achristensen@webkit.org>
776
777         Mark U+01C0 as a homograph of U+006C
778         https://bugs.webkit.org/show_bug.cgi?id=197526
779         <rdar://problem/50301904>
780
781         Reviewed by Tim Horton.
782
783         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
784         (TestWebKitAPI::TEST):
785
786 2019-05-02  Chris Dumez  <cdumez@apple.com>
787
788         Add test coverage for <rdar://problem/49731231>
789         https://bugs.webkit.org/show_bug.cgi?id=196730
790         <rdar://problem/49731231>
791
792         Reviewed by Ryosuke Niwa.
793
794         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
795         to match DumpRenderTree.
796
797         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
798         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
799         (WTR::TestRunner::abortModal):
800         * WebKitTestRunner/InjectedBundle/TestRunner.h:
801         * WebKitTestRunner/TestController.cpp:
802         (WTR::TestController::runModal):
803         * WebKitTestRunner/TestController.h:
804         * WebKitTestRunner/TestInvocation.cpp:
805         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
806         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
807         (WTR::TestController::abortModal):
808         * WebKitTestRunner/ios/TestControllerIOS.mm:
809         (WTR::TestController::abortModal):
810         * WebKitTestRunner/mac/TestControllerMac.mm:
811         (WTR::TestController::abortModal):
812         * WebKitTestRunner/win/TestControllerWin.cpp:
813         (WTR::TestController::abortModal):
814
815 2019-05-02  Christopher Reid  <chris.reid@sony.com>
816
817         [CMake] Add support for LTO builds
818         https://bugs.webkit.org/show_bug.cgi?id=188986
819
820         Reviewed by Don Olmstead.
821
822         Add support to configure --lto-mode with cmake builds.
823
824         * Scripts/build-webkit:
825         * Scripts/webkitdirs.pm:
826         (generateBuildSystemFromCMakeProject):
827
828 2019-05-02  John Wilander  <wilander@apple.com>
829
830         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
831         https://bugs.webkit.org/show_bug.cgi?id=197521
832         <rdar://problem/49651503>
833
834         Reviewed by Brent Fulgham.
835
836         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
837         (TestWebKitAPI::TEST):
838            Added a test for host strings with leading dots since they are
839            often used for the domain attribute in cookies.
840
841 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
842
843         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
844         https://bugs.webkit.org/show_bug.cgi?id=197510
845
846         Reviewed by Alex Christensen.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
849         (TestWebKitAPI::TEST):
850
851 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
852
853         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
854         https://bugs.webkit.org/show_bug.cgi?id=197174
855
856         Reviewed by Alex Christensen.
857
858         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
859
860         * TestWebKitAPI/PlatformGTK.cmake:
861         * TestWebKitAPI/PlatformWPE.cmake:
862
863 2019-05-02  Alex Christensen  <achristensen@webkit.org>
864
865         Build fix for internal branch.
866
867         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
868         RetainPtr.h was not explicitly included.
869
870 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
871
872         webkitpy: Ignore errors when shutting down an already shutdown simulator
873         <https://bugs.webkit.org/show_bug.cgi?id=197514>
874         <rdar://problem/50390247>
875
876         Reviewed by Lucas Forschler.
877
878         * Scripts/webkitpy/xcode/simulated_device.py:
879         (SimulatedDevice._shut_down):
880
881 2019-05-02  Frederic Wang  <fwang@igalia.com>
882
883         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
884         https://bugs.webkit.org/show_bug.cgi?id=196142
885
886         This patch introduces some experimental runtime flag to let users
887         disable MathML features that are removed from MathML Core [1]. For now,
888         these features are only disabled on GTK and WPE ports.
889
890         [1] https://mathml-refresh.github.io/mathml-core/
891
892         Reviewed by Rob Buis.
893
894         * DumpRenderTree/TestOptions.cpp:
895         (TestOptions::TestOptions):
896         * DumpRenderTree/TestOptions.h:
897         * DumpRenderTree/mac/DumpRenderTree.mm:
898         (setWebPreferencesForTestOptions):
899
900 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
901
902         TestWebKitAPI config.h should be aware of what suite is being built
903         https://bugs.webkit.org/show_bug.cgi?id=196583
904
905         Reviewed by Konstantin Tokarev.
906
907         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
908         benefit the macro defines BUILDING_* for the executable which allows the includes
909         of the config.h to be tailored to the test suite being built. Because of that the
910         dependencies of the Test* executable are specific to the test suite which may
911         speed up the build.
912
913         Some source files were including "PlatformUtilities.h" which includes WebKit headers
914         when "Utilities.h" is what was needed.
915
916         * TestWebKitAPI/CMakeLists.txt:
917         * TestWebKitAPI/PlatformGTK.cmake:
918         * TestWebKitAPI/PlatformJSCOnly.cmake:
919         * TestWebKitAPI/PlatformMac.cmake:
920         * TestWebKitAPI/PlatformPlayStation.cmake:
921         * TestWebKitAPI/PlatformUtilities.h:
922         * TestWebKitAPI/PlatformWPE.cmake:
923         * TestWebKitAPI/PlatformWin.cmake:
924         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
925         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
926         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
927         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
928         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
929         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
930         * TestWebKitAPI/config.h:
931
932 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
933
934         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
935         https://bugs.webkit.org/show_bug.cgi?id=181950
936         <rdar://problem/43357371>
937
938         Reviewed by Brent Fulgham.
939
940         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
941         (TestWebKitAPI::TEST_F):
942
943 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
944
945         Remove webkitpy and bindings EWS queues from dashboard
946         https://bugs.webkit.org/show_bug.cgi?id=197475
947
948         Reviewed by Alexey Proskuryakov.
949
950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
951
952 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
953
954         Remove webkitpy and bindings test queues from old EWS
955         https://bugs.webkit.org/show_bug.cgi?id=197468
956
957         Reviewed by Alexey Proskuryakov.
958
959         * QueueStatusServer/config/queues.py:
960
961 2019-04-30  Tim Horton  <timothy_horton@apple.com>
962
963         Fix the WebKitTestRunner build
964         https://bugs.webkit.org/show_bug.cgi?id=197449
965         <rdar://problem/50334169>
966
967         Reviewed by Alexey Proskuryakov.
968
969         * WebKitTestRunner/mac/EventSenderProxy.mm:
970         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
971         (WTR::EventSenderProxy::mouseForceChanged):
972         Use some SPI instead of IPI.
973
974 2019-04-30  Chris Dumez  <cdumez@apple.com>
975
976         Regression(PSON) URL scheme handlers can no longer respond asynchronously
977         https://bugs.webkit.org/show_bug.cgi?id=197426
978         <rdar://problem/50256169>
979
980         Reviewed by Brady Eidson.
981
982         Add API test coverage.
983
984         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
985         (-[PSONScheme setShouldRespondAsynchronously:]):
986         (-[PSONScheme webView:startURLSchemeTask:]):
987         (-[PSONScheme webView:stopURLSchemeTask:]):
988
989 2019-04-30  Chris Dumez  <cdumez@apple.com>
990
991         Unreviewed, rolling out r244802.
992
993         Caused an API test failure
994
995         Reverted changeset:
996
997         "Regression(PSON) URL scheme handlers can no longer respond
998         asynchronously"
999         https://bugs.webkit.org/show_bug.cgi?id=197426
1000         https://trac.webkit.org/changeset/244802
1001
1002 2019-04-30  Chris Dumez  <cdumez@apple.com>
1003
1004         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1005         https://bugs.webkit.org/show_bug.cgi?id=197426
1006         <rdar://problem/50256169>
1007
1008         Reviewed by Brady Eidson.
1009
1010         Add API test coverage.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1013         (-[PSONScheme setShouldRespondAsynchronously:]):
1014         (-[PSONScheme webView:startURLSchemeTask:]):
1015         (-[PSONScheme webView:stopURLSchemeTask:]):
1016
1017 2019-04-30  Chris Dumez  <cdumez@apple.com>
1018
1019         Only use a related page's process if that page has not been closed yet
1020         https://bugs.webkit.org/show_bug.cgi?id=197393
1021         <rdar://problem/50302423>
1022
1023         Reviewed by Tim Horton.
1024
1025         Add API test coverage.
1026
1027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1028
1029 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1030
1031         [ews-build] Enable Bindings tests queue on new EWS
1032         https://bugs.webkit.org/show_bug.cgi?id=197424
1033
1034         Reviewed by Lucas Forschler.
1035
1036         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1037         (StatusBubble):
1038         * BuildSlaveSupport/ews-build/config.json:
1039
1040 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1041
1042         [ews-build] Configure ews151 for running various tests
1043         https://bugs.webkit.org/show_bug.cgi?id=197419
1044
1045         Reviewed by Lucas Forschler.
1046
1047         * BuildSlaveSupport/ews-build/config.json:
1048
1049 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1050
1051         [ews-build] Parse and display bindings test failures
1052         https://bugs.webkit.org/show_bug.cgi?id=197423
1053
1054         Reviewed by Lucas Forschler.
1055
1056         * BuildSlaveSupport/ews-build/steps.py:
1057         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1058         (RunBindingsTests.start): Initialize log_observer for json output.
1059         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1060         (RunBindingsTests._addToLog): Method to add message to log.
1061         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1062
1063 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1064
1065         Unreviewed. Add myself as a committer.
1066
1067         * Scripts/webkitpy/common/config/contributors.json:
1068
1069 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1070
1071         [ews-build] Enable webkitpy queue on new EWS
1072         https://bugs.webkit.org/show_bug.cgi?id=197396
1073
1074         Reviewed by Lucas Forschler.
1075
1076         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1077         (StatusBubble):
1078         * BuildSlaveSupport/ews-build/config.json:
1079
1080 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-build] Parse and display webkitpy failures
1083         https://bugs.webkit.org/show_bug.cgi?id=197395
1084
1085         Reviewed by Lucas Forschler.
1086
1087         * BuildSlaveSupport/ews-build/steps.py:
1088         (RunWebKitPyTests.start): Initialize log_observer for json output.
1089         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1090         (RunWebKitPyTests._addToLog): Method to add message to log.
1091         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1092
1093 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1094
1095         <rdar://problem/50299396> Fix internal High Sierra build
1096         https://bugs.webkit.org/show_bug.cgi?id=197388
1097
1098         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1099         * MiniBrowser/Configurations/Base.xcconfig:
1100         * MobileMiniBrowser/Configurations/Base.xcconfig:
1101         * TestWebKitAPI/Configurations/Base.xcconfig:
1102         * WebKitTestRunner/Configurations/Base.xcconfig:
1103
1104 2019-04-29  Youenn Fablet  <youenn@apple.com>
1105
1106         Remove spurious GVA printf logging
1107         https://bugs.webkit.org/show_bug.cgi?id=197368
1108         <rdar://problem/35975256>
1109
1110         Reviewed by Alexey Proskuryakov.
1111
1112         * Scripts/webkitpy/port/mac.py:
1113         (MacPort.logging_patterns_to_strip):
1114
1115 2019-04-29  Youenn Fablet  <youenn@apple.com>
1116
1117         getDisplayMedia should be called on user gesture
1118         https://bugs.webkit.org/show_bug.cgi?id=197356
1119         <rdar://problem/50296074>
1120
1121         Reviewed by Eric Carlson.
1122
1123         Update test configuration to inject internals
1124         so that we can use it to simulate a user click to call getDisplayMedia.
1125
1126         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1127         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1128         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1129
1130 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1131
1132         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1133         https://bugs.webkit.org/show_bug.cgi?id=197339
1134
1135         Reviewed by Dewei Zhu.
1136
1137         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1138         test run for setup steps that are too expensive to do every iteration.
1139
1140         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1141         (BenchmarkRunner._run_benchmark):
1142         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1143         (BrowserDriver):
1144         (BrowserDriver.prepare_initial_env):
1145         (BrowserDriver.restore_env_after_all_testing):
1146         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1147         (LinuxBrowserDriver.prepare_initial_env):
1148         (LinuxBrowserDriver.restore_env_after_all_testing):
1149         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1150         (OSXBrowserDriver.prepare_initial_env):
1151         (OSXBrowserDriver.restore_env_after_all_testing):
1152
1153 2019-04-28  Andy Estes  <aestes@apple.com>
1154
1155         Fix the watchOS engineering build.
1156
1157         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1158         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1159
1160 2019-04-27  Chris Dumez  <cdumez@apple.com>
1161
1162         [WKTR] Move test timeout handling to the UIProcess
1163         https://bugs.webkit.org/show_bug.cgi?id=197333
1164
1165         Reviewed by Darin Adler.
1166
1167         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1168         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1169         every WebContent process in the case of swapping.
1170
1171         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1172         would lead to crashes when firing the timer.
1173
1174         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1175         (WTR::InjectedBundle::didReceiveMessageToPage):
1176         (WTR::InjectedBundle::done):
1177         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1178         (WTR::InjectedBundle::shouldDumpPixels const):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1180         (WTR::TestRunner::TestRunner):
1181         (WTR::TestRunner::waitUntilDone):
1182         (WTR::TestRunner::setWaitUntilDone):
1183         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1184         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1185         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1186         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1187         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1188         * WebKitTestRunner/TestInvocation.cpp:
1189         (WTR::TestInvocation::TestInvocation):
1190         (WTR::TestInvocation::createTestSettingsDictionary):
1191         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1192         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1193         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1194         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1195         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1196         (WTR::TestInvocation::setWaitUntilDone):
1197         (WTR::TestInvocation::done):
1198         * WebKitTestRunner/TestInvocation.h:
1199
1200 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1201
1202         [JSC] linkPolymorphicCall now does GC
1203         https://bugs.webkit.org/show_bug.cgi?id=197306
1204
1205         Reviewed by Saam Barati.
1206
1207         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1208         To add this test, we add `runWithoutBaseOption`.
1209
1210         * Scripts/run-jsc-stress-tests:
1211
1212 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1213
1214         Update inactive reviewers' status to 'contributor'.
1215
1216         Accidentally skipped one at first.
1217
1218         * Scripts/webkitpy/common/config/contributors.json:
1219
1220 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1221
1222         Update inactive reviewers' status to 'contributor'.
1223
1224         * Scripts/webkitpy/common/config/contributors.json: The change.
1225
1226         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1227         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1228         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1229         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1230         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1231         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1232         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1233         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1234         Sadly, regression tests operate on a crazy mix of mock and live data for
1235         contributors.json. It would be a substantial project to mock all code paths,
1236         so changing the tests instead.
1237
1238 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1239
1240         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1241         https://bugs.webkit.org/show_bug.cgi?id=197171
1242         <rdar://problem/47454979>
1243
1244         Reviewed by Youenn Fablet.
1245
1246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1248         (TestWebKitAPI::TEST):
1249
1250 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1251
1252         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1253         <https://webkit.org/b/197314>
1254         <rdar://problem/50245252>
1255
1256         Reviewed by Simon Fraser.
1257
1258         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1259         (WTR::UIScriptController::lastUndoLabel const):
1260         (WTR::UIScriptController::firstRedoLabel const):
1261         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1262
1263         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1264         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1265         - Call -autorelease to fix leak of NSDictionary.
1266
1267         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1268         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1269         (WTR::UIScriptController::selectFormPopoverTitle const):
1270         (WTR::UIScriptController::textContentType const):
1271         (WTR::UIScriptController::formInputLabel const):
1272         (WTR::UIScriptController::scrollingTreeAsText const):
1273         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1274
1275 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1276
1277         webkitpy: Running a single test will always use the default device
1278         https://bugs.webkit.org/show_bug.cgi?id=195472
1279         <rdar://problem/48724825>
1280
1281         Reviewed by Lucas Forschler.
1282
1283         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1284         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1285         requested will be run regardless of what shard they are in.
1286
1287         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1288         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1289         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1290         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1291         on the default device type.
1292         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1293         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1294         (RunTest.test_run_part): Ditto.
1295
1296 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1297
1298         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1299         https://bugs.webkit.org/show_bug.cgi?id=197165
1300
1301         Reviewed by Youenn Fablet.
1302
1303         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1304
1305 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1306
1307         Replace iOS build queue hardware
1308         https://bugs.webkit.org/show_bug.cgi?id=197312
1309
1310         Reviewed by Aakash Jain.
1311
1312         * BuildSlaveSupport/build.webkit.org-config/config.json:
1313         Use newer hardware that supports macOS Mojave.
1314
1315 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1316
1317         check-webkit-style complains the first block in while loop.
1318         https://bugs.webkit.org/show_bug.cgi?id=197307
1319
1320         The style checker shouldn't complain about an open brace on
1321         its own line if the last non-whitespace character on the previous
1322         non-blank line is another open brace, because it's likely to
1323         indicate the begining of a nested code block.
1324
1325         Reviewed by Alex Christensen.
1326
1327         * Scripts/webkitpy/style/checkers/cpp.py:
1328         (check_braces):
1329         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1330         (WebKitStyleTest.test_braces):
1331
1332 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1333
1334         Stop IDB transactions to release locked database files when network process is ready to suspend
1335         https://bugs.webkit.org/show_bug.cgi?id=196372
1336         <rdar://problem/48930116>
1337
1338         Reviewed by Brady Eidson.
1339
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1341         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1342         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1343         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1344         (runTestAndCheckResult):
1345         (keepNetworkProcessActive):
1346         (TEST):
1347
1348 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1349
1350         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1351         https://bugs.webkit.org/show_bug.cgi?id=188357
1352         <rdar://problem/42986633>
1353
1354         Reviewed by Dean Jackson.
1355
1356         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1357         tests would fall into low memory mode and have different behavior.
1358         
1359         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1360         to Internals, so it's shared by DRT and WTR.
1361         
1362         We no longer need the WK2 C SPI glue.
1363
1364         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1365         (WTR::InjectedBundlePage::prepare):
1366
1367 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1368
1369         webkitpy: Including skipped tests in the final count
1370         https://bugs.webkit.org/show_bug.cgi?id=197298
1371         <rdar://problem/49705424>
1372
1373         Reviewed by Lucas Forschler.
1374
1375         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1376         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1377
1378 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1379
1380         Disable date and time inputs on iOSMac.
1381         https://bugs.webkit.org/show_bug.cgi?id=197287
1382         rdar://problem/46794376
1383
1384         Reviewed by Wenson Hsieh.
1385
1386         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1387
1388 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1389
1390         Fix test-webkitpy after r244653
1391         https://bugs.webkit.org/show_bug.cgi?id=197131
1392
1393         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1394         Also use C++17.
1395
1396 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1397
1398         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1399         https://bugs.webkit.org/show_bug.cgi?id=196991
1400         <rdar://problem/45507423>
1401
1402         Reviewed by Alex Christensen.
1403
1404         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1405         (-[NavigationTestDelegate init]):
1406         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1407         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1408         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1409         (TestWebKitAPI::TEST):
1410         (TEST): Deleted.
1411
1412 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1413
1414         Revert some code accidentally committed with r244653
1415         https://bugs.webkit.org/show_bug.cgi?id=197131
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1418         (TestWebKitAPI::TEST):
1419
1420 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1421
1422         Start using C++17
1423         https://bugs.webkit.org/show_bug.cgi?id=197131
1424
1425         Reviewed by Darin Adler.
1426
1427         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1428         * MiniBrowser/Configurations/Base.xcconfig:
1429         * MobileMiniBrowser/Configurations/Base.xcconfig:
1430         * TestWebKitAPI/Configurations/Base.xcconfig:
1431         * WebKitTestRunner/Configurations/Base.xcconfig:
1432
1433 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1434
1435         Unreviewed, rolling out r244627.
1436         https://bugs.webkit.org/show_bug.cgi?id=197282
1437
1438         Causing internal build failures (Requested by ShawnRoberts on
1439         #webkit).
1440
1441         Reverted changeset:
1442
1443         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1444         https://bugs.webkit.org/show_bug.cgi?id=197171
1445         https://trac.webkit.org/changeset/244627
1446
1447 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GTK] Hardcoded text color in input fields
1450         https://bugs.webkit.org/show_bug.cgi?id=126907
1451
1452         Reviewed by Michael Catanzaro.
1453
1454         Add dark-mode command line option to MiniBrowser.
1455
1456         * MiniBrowser/gtk/main.c:
1457         (main):
1458
1459 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1460
1461         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1462         https://bugs.webkit.org/show_bug.cgi?id=196948
1463         <rdar://problem/49927131>
1464
1465         Reviewed by Tim Horton.
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1468         (TEST):
1469         The expected order of incoming events is
1470         1. didInvalidateIntrinsicContentSize
1471         2. didFirstLayout
1472         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1473         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1474         (and remember, all we care about is ordering).
1475
1476 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1477
1478         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1479         https://bugs.webkit.org/show_bug.cgi?id=197171
1480         <rdar://problem/47454979>
1481
1482         Reviewed by Youenn Fablet.
1483
1484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1485         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1486         (TestWebKitAPI::TEST):
1487
1488 2019-04-24  Brady Eidson  <beidson@apple.com>
1489
1490         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1491         https://bugs.webkit.org/show_bug.cgi?id=191362
1492
1493         Reviewed by Alex Christensen.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1496           from an XHR to a custom protocol.
1497
1498 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1499
1500         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1501         https://bugs.webkit.org/show_bug.cgi?id=197273
1502
1503         Reviewed by Dean Jackson.
1504
1505         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1506         so that WebCoreTestSupport::resetInternalsObject() is always run.
1507
1508         * DumpRenderTree/mac/DumpRenderTree.mm:
1509         (resetWebViewToConsistentStateBeforeTesting):
1510         (runTest):
1511
1512 2019-04-24  John Wilander  <wilander@apple.com>
1513
1514         Age out unconverted Ad Click Attributions after one week.
1515         https://bugs.webkit.org/show_bug.cgi?id=197238
1516         <rdar://problem/50177349>
1517
1518         Reviewed by Chris Dumez.
1519
1520         This patch adds infrastructure to allow tests to expire all unconverted
1521         attributions early.
1522
1523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1525         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1527         * WebKitTestRunner/TestController.cpp:
1528         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1529         * WebKitTestRunner/TestController.h:
1530         * WebKitTestRunner/TestInvocation.cpp:
1531         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1532
1533 2019-04-24  Chris Dumez  <cdumez@apple.com>
1534
1535         Fix flaky crashes in a couple of PSON API tests
1536         https://bugs.webkit.org/show_bug.cgi?id=197239
1537
1538         Reviewed by Tim Horton.
1539
1540         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1543
1544 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1545
1546         Make it possible to control the renderTreeAsText output by setting options on testRunner
1547         https://bugs.webkit.org/show_bug.cgi?id=197133
1548
1549         Reviewed by Sam Weinig.
1550
1551         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1552         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1553         these flags through the various framework layers.
1554
1555         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1556
1557         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1558         and hand-code DumpRenderTree bindings.
1559
1560         Some cleanup of the TestRunners, using member initializers.
1561
1562         * DumpRenderTree/TestRunner.cpp:
1563         (TestRunner::TestRunner):
1564         (setRenderTreeDumpOptionsCallback):
1565         (TestRunner::staticFunctions):
1566         (TestRunner::setRenderTreeDumpOptions):
1567         * DumpRenderTree/TestRunner.h:
1568         (TestRunner::renderTreeDumpOptions const):
1569         * DumpRenderTree/mac/DumpRenderTree.mm:
1570         (dump):
1571         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1572         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1573         (WTR::InjectedBundlePage::dump):
1574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1575         (WTR::TestRunner::TestRunner):
1576         (WTR::TestRunner::setRenderTreeDumpOptions):
1577         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1578         (WTR::TestRunner::renderTreeDumpOptions const):
1579
1580 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1581
1582         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1583         https://bugs.webkit.org/show_bug.cgi?id=197078
1584         <rdar://problem/49564348>
1585
1586         Reviewed by Geoff Garen.
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1589         (TEST_F):
1590         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1591         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1592         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1593
1594 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1595
1596         Add unit test for r239322
1597         https://bugs.webkit.org/show_bug.cgi?id=197236
1598
1599         Reviewed by Chris Dumez.
1600
1601         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1602         May as well add the test infrastructure which was needed before and will be needed in the future.
1603
1604         * TestWebKitAPI/TCPServer.cpp:
1605         (TestWebKitAPI::TCPServer::TCPServer):
1606         * TestWebKitAPI/TCPServer.h:
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1609         (TestWebKitAPI::TEST):
1610         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1611         (TestWebKitAPI::downloadAtRate):
1612         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1613         (TEST):
1614         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1615         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1616         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1619         (TEST):
1620
1621 2019-04-24  Chris Dumez  <cdumez@apple.com>
1622
1623         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1624         https://bugs.webkit.org/show_bug.cgi?id=197214
1625         <rdar://problem/49237544>
1626
1627         Reviewed by Alex Christensen.
1628
1629         Extend API test coverage.
1630
1631         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1632         (TEST):
1633
1634 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1635
1636         [Build][GStreamer] Update to 1.16.0
1637         https://bugs.webkit.org/show_bug.cgi?id=197157
1638
1639         Reviewed by Xabier Rodriguez-Calvar.
1640
1641         The upstreamed patches were removed and a new one was added for a
1642         regression detected in the scaletempo GStreamer element. The GNOME
1643         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1644         on the way, as it is the preferred build system now in GStreamer
1645         1.16.
1646
1647         * flatpak/files/httpd-autogen.sh:
1648         * flatpak/flatpakutils.py:
1649         (FlatpakPackage.install):
1650         (WebkitFlatpak.run_in_sandbox):
1651         * flatpak/org.webkit.CommonModules.yaml:
1652         * flatpak/org.webkit.WebKit.yaml:
1653         * gstreamer/jhbuild.modules:
1654         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1655         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1656         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1657         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1658         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1659         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1660         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1661         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1662         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1663         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1664         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1665         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1666         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1667         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1668         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1669         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1670         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1671         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1672         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1673         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1674         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1675         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1676
1677 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1678
1679         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1680         https://bugs.webkit.org/show_bug.cgi?id=197156
1681
1682         Reviewed by Michael Catanzaro.
1683
1684         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1685         support was added.
1686
1687         * MiniBrowser/gtk/BrowserTab.c:
1688         (browser_tab_set_background_color): Set the passed in color as web view background color.
1689         * MiniBrowser/gtk/BrowserTab.h:
1690         * MiniBrowser/gtk/BrowserWindow.c:
1691         (browser_window_init): Initialize backgroundColor.
1692         (browser_window_append_view): Call browser_tab_set_background_color().
1693         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1694         are added.
1695         * MiniBrowser/gtk/main.c:
1696         (main): Call browser_window_set_background_color() before creating the tabs.
1697
1698 2019-04-23  John Wilander  <wilander@apple.com>
1699
1700         Move Ad Click Attribution from internal feature to experimental feature
1701         https://bugs.webkit.org/show_bug.cgi?id=197218
1702         <rdar://problem/47651691>
1703
1704         Reviewed by Brent Fulgham.
1705
1706         * DumpRenderTree/TestOptions.cpp:
1707         (TestOptions::TestOptions):
1708
1709 2019-04-23  Andy Estes  <aestes@apple.com>
1710
1711         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1712         https://bugs.webkit.org/show_bug.cgi?id=196749
1713         <rdar://problem/35773454>
1714
1715         Reviewed by Daniel Bates.
1716
1717         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1720         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1721         (-[QuickLookDelegate webView:didFinishNavigation:]):
1722         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1723         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1724         (runTest):
1725         (runTestDecideBeforeLoading):
1726         (runTestDecideAfterLoading):
1727         (TEST):
1728
1729 2019-04-23  John Wilander  <wilander@apple.com>
1730
1731         Remove Ad Click Attribution data when removing website data
1732         https://bugs.webkit.org/show_bug.cgi?id=197215
1733         <rdar://problem/47668988>
1734
1735         Reviewed by Chris Dumez.
1736
1737         This patch adds test infrastructure to delete Ad Click Attribution data
1738         through WebsiteDataStore::removeData().
1739
1740         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1741         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1742         (WTR::TestRunner::clearAdClickAttribution):
1743         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1745         * WebKitTestRunner/TestController.cpp:
1746         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1747         * WebKitTestRunner/TestController.h:
1748         * WebKitTestRunner/TestInvocation.cpp:
1749         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1750
1751 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1752
1753         webkitpy: Kill unresponsive worker processes
1754         https://bugs.webkit.org/show_bug.cgi?id=197205
1755         <rdar://problem/50104388>
1756
1757         Reviewed by Lucas Forschler.
1758
1759         * Scripts/webkitpy/common/message_pool.py:
1760         (_MessagePool.__init__): Add close timeout.
1761         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1762
1763 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1764
1765         Add unit tests for WKWebView.serverTrust
1766         https://bugs.webkit.org/show_bug.cgi?id=197202
1767
1768         Reviewed by Youenn Fablet
1769
1770         * TestWebKitAPI/TCPServer.cpp:
1771         (TestWebKitAPI::deleter<BIO>::operator()):
1772         (TestWebKitAPI::deleter<SSL>::operator()):
1773         (TestWebKitAPI::deleter<X509>::operator()):
1774         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1775         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1776         (TestWebKitAPI::TCPServer::TCPServer):
1777         (TestWebKitAPI::TCPServer::listenForConnections):
1778         * TestWebKitAPI/TCPServer.h:
1779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1780         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1781         (TestWebKitAPI::TEST):
1782         (verifyCertificateAndPublicKey):
1783         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1784         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1785         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1786         (TestWebKitAPI::downloadAtRate):
1787         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1788         (TEST):
1789         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1790         (TEST):
1791
1792 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1793
1794         Unreviewed, rolling out r244556.
1795         https://bugs.webkit.org/show_bug.cgi?id=197212
1796
1797         Causing build failures on multiple builders (Requested by
1798         ShawnRoberts on #webkit).
1799
1800         Reverted changeset:
1801
1802         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1803         https://bugs.webkit.org/show_bug.cgi?id=197171
1804         https://trac.webkit.org/changeset/244556
1805
1806 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1807
1808         Fix iOS build.
1809         https://bugs.webkit.org/show_bug.cgi?id=195537
1810
1811         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1812         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1813         AdoptWK constructor is private now.  Use adoptWK instead.
1814
1815 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1816
1817         Accessibility text search and selection API enhancements.
1818         https://bugs.webkit.org/show_bug.cgi?id=197095
1819         <rdar://problem/48181791>
1820
1821         Reviewed by Chris Fleizach.
1822
1823         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1824
1825         * DumpRenderTree/AccessibilityTextMarker.h:
1826         * DumpRenderTree/AccessibilityUIElement.cpp:
1827         (searchTextWithCriteriaCallback):
1828         (AccessibilityUIElement::getJSClass):
1829         * DumpRenderTree/AccessibilityUIElement.h:
1830         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1831         (convertVectorToObjectArray):
1832         (convertNSArrayToVector):
1833         (searchTextParameterizedAttributeForCriteria):
1834         (AccessibilityUIElement::getLinkedUIElements):
1835         (AccessibilityUIElement::getDocumentLinks):
1836         (AccessibilityUIElement::getChildren):
1837         (AccessibilityUIElement::getChildrenWithRange):
1838         (AccessibilityUIElement::rowHeaders const):
1839         (AccessibilityUIElement::columnHeaders const):
1840         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1841         (AccessibilityUIElement::searchTextWithCriteria):
1842         (AccessibilityUIElement::attributesOfColumnHeaders):
1843         (AccessibilityUIElement::attributesOfRowHeaders):
1844         (AccessibilityUIElement::attributesOfColumns):
1845         (AccessibilityUIElement::attributesOfRows):
1846         (AccessibilityUIElement::attributesOfVisibleCells):
1847         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1848         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1849         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1850         (WTR::convertVectorToObjectArray):
1851         (WTR::convertNSArrayToVector):
1852         (WTR::searchTextParameterizedAttributeForCriteria):
1853         (WTR::AccessibilityUIElement::getLinkedUIElements):
1854         (WTR::AccessibilityUIElement::getDocumentLinks):
1855         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1856         (WTR::AccessibilityUIElement::getChildren):
1857         (WTR::AccessibilityUIElement::getChildrenWithRange):
1858         (WTR::AccessibilityUIElement::rowHeaders const):
1859         (WTR::AccessibilityUIElement::columnHeaders const):
1860         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1861         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1862         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1863         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1864         (WTR::AccessibilityUIElement::attributesOfColumns):
1865         (WTR::AccessibilityUIElement::attributesOfRows):
1866         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1867         (WTR::convertElementsToObjectArray): Deleted.
1868
1869 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1870
1871         Multiple File Input Icon Set Regardless of File List
1872         https://bugs.webkit.org/show_bug.cgi?id=195537
1873
1874         Reviewed by Alexey Proskuryakov.
1875
1876         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1877         display string in iOS file inputs
1878
1879         * DumpRenderTree/TestRunner.cpp:
1880         (SetOpenPanelFilesMediaIconCallback):
1881         (TestRunner::staticFunctions):
1882         (TestRunner::setOpenPanelFilesMediaIcon):
1883         * DumpRenderTree/TestRunner.h:
1884         (TestRunner::openPanelFilesMediaIcon const):
1885         * DumpRenderTree/mac/UIDelegate.mm:
1886         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1889         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1890         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1891         * WebKitTestRunner/TestController.cpp:
1892         (WTR::runOpenPanel):
1893         (WTR::TestController::resetStateToConsistentValues):
1894         * WebKitTestRunner/TestController.h:
1895         (WTR::TestController::openPanelFileURLsMediaIcon const):
1896         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1897         * WebKitTestRunner/TestInvocation.cpp:
1898         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1899
1900 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1901
1902         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1903         https://bugs.webkit.org/show_bug.cgi?id=197171
1904         <rdar://problem/47454979>
1905
1906         Reviewed by Youenn Fablet.
1907
1908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1909         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1910         (TestWebKitAPI::TEST):
1911
1912 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [ews-build] Add unit tests for UnApplyPatchIfRequired
1915         https://bugs.webkit.org/show_bug.cgi?id=197197
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * BuildSlaveSupport/ews-build/steps_unittest.py:
1920         (TestUnApplyPatchIfRequired):
1921         (TestUnApplyPatchIfRequired.test_success):
1922         (TestUnApplyPatchIfRequired.test_failure):
1923         (TestUnApplyPatchIfRequired.test_skip):
1924
1925 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1926
1927         [ews-build] Add unit tests for CleanWorkingDirectory
1928         https://bugs.webkit.org/show_bug.cgi?id=197195
1929
1930         Reviewed by Lucas Forschler.
1931
1932         * BuildSlaveSupport/ews-build/steps_unittest.py:
1933         (TestCleanWorkingDirectory):
1934         (TestCleanWorkingDirectory.test_success):
1935         (TestCleanWorkingDirectory.test_failure):
1936
1937 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-build] Use explicit imports instead of wildcard imports
1940         https://bugs.webkit.org/show_bug.cgi?id=197194
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * BuildSlaveSupport/ews-build/factories.py:
1945         * BuildSlaveSupport/ews-build/loadConfig.py:
1946         * BuildSlaveSupport/ews-build/steps_unittest.py:
1947
1948 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1949
1950         [ews-build] Add unit tests for DownloadBuiltProduct
1951         https://bugs.webkit.org/show_bug.cgi?id=197193
1952
1953         Reviewed by Lucas Forschler.
1954
1955         * BuildSlaveSupport/ews-build/steps_unittest.py:
1956         (TestDownloadBuiltProduct):
1957         (TestDownloadBuiltProduct.setUp):
1958         (TestDownloadBuiltProduct.tearDown):
1959         (TestDownloadBuiltProduct.test_success):
1960         (TestDownloadBuiltProduct.test_failure):
1961
1962 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1963
1964         [ews-app] Exception while loading status-bubble when no build step has started
1965         https://bugs.webkit.org/show_bug.cgi?id=196676
1966
1967         Reviewed by Lucas Forschler.
1968
1969         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1970         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1971
1972 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1973
1974         [PlayStation] Support running of JSC tests on remote playstation devices
1975         https://bugs.webkit.org/show_bug.cgi?id=197170
1976
1977         Reviewed by Ross Kirsling.
1978
1979         Script changes
1980
1981         * Scripts/run-javascriptcore-tests:
1982         (runJSCStressTests): Pass arguments for playstation to
1983         run-jsc-stress-tests
1984         * Scripts/run-jsc-stress-tests:
1985         Handle $hostOS=="playstation" for determineArchitecture, turning
1986         off $isFTLPlatform and runProfiler and defaulting test writer.
1987         * Scripts/webkitdirs.pm:
1988         (jscPath): PlayStation WebKit executables have .elf extension
1989         (executableProductDir): PlayStation builds on Windows hosts but
1990         uses bin directory rather than bin64/bin32 for executable output
1991         location.
1992         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1993
1994 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1995
1996         [CMake][Win] Use target oriented design for WebKit
1997         https://bugs.webkit.org/show_bug.cgi?id=197173
1998
1999         Reviewed by Alex Christensen.
2000
2001         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2002         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2003
2004 2019-04-23  Chris Dumez  <cdumez@apple.com>
2005
2006         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2007         https://bugs.webkit.org/show_bug.cgi?id=197097
2008         <rdar://problem/50048318>
2009
2010         Reviewed by Alex Christensen.
2011
2012         Add API test coverage.
2013
2014         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2015         (-[PSONScheme webView:startURLSchemeTask:]):
2016
2017 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         [ATK] Implement AtkComponentIface scroll_to methods
2020         https://bugs.webkit.org/show_bug.cgi?id=196856
2021
2022         Reviewed by Michael Catanzaro.
2023
2024         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2025         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2026         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2027         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2028
2029 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews-build] Improve summary for UploadBuiltProduct step
2032         https://bugs.webkit.org/show_bug.cgi?id=197182
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/ews-build/steps.py:
2037         (UploadBuiltProduct): Added descriptionDone.
2038         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2039         * BuildSlaveSupport/ews-build/steps_unittest.py:
2040         (TestUploadBuiltProduct.test_success): Updated unit-test.
2041         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2042
2043 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2044
2045         [ews-build] Trigger queues only after uploading the archive
2046         https://bugs.webkit.org/show_bug.cgi?id=197180
2047
2048         Reviewed by Lucas Forschler.
2049
2050         * BuildSlaveSupport/ews-build/factories.py:
2051         (Factory.__init__):
2052         (BuildFactory.__init__): Remove trigger step from factories.
2053         (BuildFactory.propertiesToPassToTriggers): Deleted.
2054         * BuildSlaveSupport/ews-build/steps.py:
2055         (ConfigureBuild.__init__): Confiure triggers property.
2056         (Trigger): Step to trigger other queues.
2057         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2058         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2059
2060 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2061
2062         Deprecate WKContextCreateWithInjectedBundlePath
2063         https://bugs.webkit.org/show_bug.cgi?id=197169
2064
2065         Reviewed by Youenn Fablet.
2066
2067         * TestWebKitAPI/PlatformUtilities.cpp:
2068         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2069         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2070
2071 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2072
2073         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2074         https://bugs.webkit.org/show_bug.cgi?id=197093
2075         <rdar://problem/49708268>
2076
2077         Reviewed by Chris Dumez.
2078
2079         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2080         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2081         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2082         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2083         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2084
2085         * TestWebKitAPI/TCPServer.cpp:
2086         (TestWebKitAPI::TCPServer::TCPServer):
2087         (TestWebKitAPI::TCPServer::~TCPServer):
2088         (TestWebKitAPI::TCPServer::socketBindListen):
2089         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2090         * TestWebKitAPI/TCPServer.h:
2091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2092         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2093         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2094         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2095         (respondWithChallengeThenOK):
2096         (TestWebKitAPI::TEST):
2097         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2098         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2099         (TEST):
2100
2101 2019-04-22  Chris Dumez  <cdumez@apple.com>
2102
2103         Delayed WebProcessLaunch may break the _relatedWebView SPI
2104         https://bugs.webkit.org/show_bug.cgi?id=197160
2105
2106         Reviewed by Alex Christensen.
2107
2108         Add API test coverage.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2111
2112 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2113
2114         Use curl to download packages for webkitpy autoinstaller
2115         https://bugs.webkit.org/show_bug.cgi?id=197164
2116
2117         Reviewed by Darin Adler.
2118
2119         * Scripts/webkitpy/common/system/autoinstall.py:
2120         (AutoInstaller._download): Use curl(1) to download packages necessary for
2121         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2122         errors which are not present when using curl(1).
2123
2124 2019-04-22  Chris Dumez  <cdumez@apple.com>
2125
2126         Unreviewed, rolling out r244502.
2127
2128         Caused crashes on the bots
2129
2130         Reverted changeset:
2131
2132         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2133         https://bugs.webkit.org/show_bug.cgi?id=197160
2134         https://trac.webkit.org/changeset/244502
2135
2136 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2137
2138         Unreviewed, rolling out r244437.
2139
2140         Still breaks internal tests.
2141
2142         Reverted changeset:
2143
2144         "InjectedBundle parameters often need initialization function
2145         called before unarchiving"
2146         https://bugs.webkit.org/show_bug.cgi?id=189709
2147         https://trac.webkit.org/changeset/244437
2148
2149 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2150
2151         [ews-build] Use singular verb in failure description in case of single api test failure
2152         https://bugs.webkit.org/show_bug.cgi?id=197013
2153
2154         Reviewed by Lucas Forschler.
2155
2156         * BuildSlaveSupport/ews-build/steps.py:
2157         (AnalyzeAPITestsResults.analyzeResults):
2158
2159 2019-04-22  Chris Dumez  <cdumez@apple.com>
2160
2161         Delayed WebProcessLaunch may break the _relatedWebView SPI
2162         https://bugs.webkit.org/show_bug.cgi?id=197160
2163
2164         Reviewed by Alex Christensen.
2165
2166         Add API test coverage.
2167
2168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2169
2170 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2171
2172         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2173         https://bugs.webkit.org/show_bug.cgi?id=194630
2174
2175         Reviewed by Michael Catanzaro.
2176
2177         Return early from getAttributeSet() is passed in accessible is nullptr.
2178
2179         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2180
2181 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2182
2183         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2184         https://bugs.webkit.org/show_bug.cgi?id=197145
2185         <rdar://problem/50078170>
2186
2187         Reviewed by Darin Adler.
2188
2189         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2190         focus, or showing the font manager.
2191
2192         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2193         (TestWebKitAPI::TEST):
2194         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2195         (TEST):
2196         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2197         (TestWebKitAPI::TEST):
2198
2199 2019-04-21  Brian Burg  <bburg@apple.com>
2200
2201         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2202         https://bugs.webkit.org/show_bug.cgi?id=197125
2203         <rdar://problem/50061468>
2204
2205         Reviewed by Darin Adler.
2206
2207         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2208         using this class rather than making our own ./wpt serve invocation.
2209
2210         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2211         (WebDriverW3CWebServer):
2212         (WebDriverW3CWebServer.document_root): Expose this to clients.
2213         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2214
2215         (WebDriverW3CWebServer.__enter__):
2216         (WebDriverW3CWebServer.__exit__):
2217         Make it possible to use the web server with a 'with' statement.
2218
2219 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2220
2221         [CMake][Win] Use target oriented design for WebKitLegacy
2222         https://bugs.webkit.org/show_bug.cgi?id=197112
2223
2224         Reviewed by Konstantin Tokarev.
2225
2226         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2227
2228         * DumpRenderTree/CMakeLists.txt:
2229         * DumpRenderTree/PlatformWin.cmake:
2230         * DumpRenderTree/win/EventSender.cpp:
2231
2232 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2233
2234         Update text for old EWS submit button
2235         https://bugs.webkit.org/show_bug.cgi?id=197140
2236
2237         Reviewed by Alexey Proskuryakov.
2238
2239         * QueueStatusServer/templates/statusbubble.html:
2240
2241 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2242
2243         [ews-app] New EWS should poll bugzilla more frequently
2244         https://bugs.webkit.org/show_bug.cgi?id=197138
2245
2246         Reviewed by Alexey Proskuryakov.
2247
2248         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2249         (FetchLoop.__init__):
2250
2251 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2252
2253         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2254         https://bugs.webkit.org/show_bug.cgi?id=197139
2255
2256         Reviewed by Alexey Proskuryakov.
2257
2258         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2259         * QueueStatusServer/templates/statusbubble.html:
2260
2261 2019-04-20  Chris Dumez  <cdumez@apple.com>
2262
2263         Unreviewed, fix iOS build with recent SDKs.
2264
2265         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2266
2267 2019-04-19  Keith Miller  <keith_miller@apple.com>
2268
2269         Add script to merge run_benchmark jsons
2270         https://bugs.webkit.org/show_bug.cgi?id=197107
2271
2272         Reviewed by Michael Saboff.
2273
2274         The script basically recursively decends through all json objects until it gets
2275         to an array or JSON primitive and concats or takes the first value, respectively.
2276
2277         This patch also adds +x bits to the compare-results script so it
2278         can be run directly from the command line. I had to add a new line so that svn
2279         will accept the change... yay svn!
2280
2281         * Scripts/compare-results:
2282         * Scripts/merge-result-jsons: Added.
2283         (readJSONFile):
2284         (deepAppend):
2285         (mergeJSONs):
2286         (main):
2287
2288 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2289
2290         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2291         https://bugs.webkit.org/show_bug.cgi?id=197079
2292
2293         Reviewed by Darin Adler.
2294
2295         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2296
2297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2298         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2299
2300 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2301
2302         Unreviewed, rolling out r244434.
2303         https://bugs.webkit.org/show_bug.cgi?id=197089
2304
2305         caused 1 API test failure (Requested by zalan on #webkit).
2306
2307         Reverted changeset:
2308
2309         "Regression (r244291): Broken API Test
2310         AutoLayoutRenderingProgressRelativeOrdering"
2311         https://bugs.webkit.org/show_bug.cgi?id=196948
2312         https://trac.webkit.org/changeset/244434
2313
2314 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2315
2316         Add new compatibility mode API on WKNavigation
2317         https://bugs.webkit.org/show_bug.cgi?id=197069
2318         <rdar://problem/50025800>
2319
2320         Reviewed by Tim Horton.
2321
2322         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2323
2324         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2325         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2326         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2327
2328 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2329
2330         [CMake] Make WebCore headers copies
2331         https://bugs.webkit.org/show_bug.cgi?id=182512
2332         <rdar://problem/37510435>
2333
2334         Reviewed by Alex Christensen.
2335
2336         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2337         ports.
2338
2339         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2340         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2341
2342         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2343         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2344         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2345         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2346         * TestWebKitAPI/CMakeLists.txt:
2347         * TestWebKitAPI/PlatformWin.cmake:
2348         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2349         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2350         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2351
2352 2019-04-18  Jer Noble  <jer.noble@apple.com>
2353
2354         Add support for parsing FairPlayStreaming PSSH boxes.
2355         https://bugs.webkit.org/show_bug.cgi?id=197064
2356
2357         Reviewed by Eric Carlson.
2358
2359         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2360         (TestWebKitAPI::TEST):
2361
2362 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2363
2364         InjectedBundle parameters often need initialization function called before unarchiving
2365         https://bugs.webkit.org/show_bug.cgi?id=189709
2366         <rdar://problem/44573653>
2367
2368         Reviewed by Ryosuke Niwa.
2369
2370         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2371         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2372
2373 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2374
2375         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2376         https://bugs.webkit.org/show_bug.cgi?id=196948
2377         <rdar://problem/49927131>
2378
2379         Reviewed by Tim Horton.
2380
2381         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2382         (TEST): 
2383         The expected order of incoming events is
2384         1. didInvalidateIntrinsicContentSize
2385         2. didFirstLayout
2386         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2387         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2388         (and remember, all we care about is ordering).
2389
2390 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2391
2392         Unreviewed, rolling out r244299.
2393
2394         Breaks internal tests.
2395
2396         Reverted changeset:
2397
2398         "InjectedBundle parameters often need initialization function
2399         called before unarchiving"
2400         https://bugs.webkit.org/show_bug.cgi?id=189709
2401         https://trac.webkit.org/changeset/244299
2402
2403 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2404
2405         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2406         https://bugs.webkit.org/show_bug.cgi?id=197053
2407
2408         Reviewed by Saam Barati.
2409
2410         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2411         (TestWebKitAPI::TEST):
2412
2413 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2414
2415         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2416         https://bugs.webkit.org/show_bug.cgi?id=197028
2417         <rdar://problem/49985290>
2418
2419         Reviewed by Wenson Hsieh.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2422         (TEST):
2423         Liberal application of waitForNextPresentationUpdate works around a race
2424         where if the page rapidly changes its viewport arguments (or an API client
2425         rapidly changes its viewport arguments), we'd get stuck thinking that the
2426         user had intentionally zoomed the page, and stop resetting the initial scale.
2427         This deserves a separate bug, but no need to keep the test failing while
2428         we think about it.
2429
2430 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2431
2432         REGRESSION (r241988): Switching tabs is slow
2433         https://bugs.webkit.org/show_bug.cgi?id=197037
2434         <rdar://problem/49951473>
2435
2436         Reviewed by Simon Fraser.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2440         (TEST):
2441         * TestWebKitAPI/cocoa/TestWKWebView.h:
2442         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2443         (-[TestWKWebView addToTestWindow]):
2444         Add a test that hangs without this fix.
2445
2446 2019-04-17  Truitt Savell  <tsavell@apple.com>
2447
2448         Unreviewed, rolling out r244400.
2449
2450         Caused testing to exit early with assertionon Debug WK2
2451
2452         Reverted changeset:
2453
2454         "UI↔Web deadlock when printing with a JavaScript alert
2455         visible"
2456         https://bugs.webkit.org/show_bug.cgi?id=196839
2457         https://trac.webkit.org/changeset/244400
2458
2459 2019-04-17  Brady Eidson  <beidson@apple.com>
2460
2461         Link clicks in PDFs shouldn't send referrer headers.
2462         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2463
2464         Reviewed by Tim Horton.
2465
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2468         (putPDFBytesCallback):
2469         (emptyReleaseInfoCallback):
2470         (createPDFWithLinkToURL):
2471         (TEST):
2472
2473 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2474
2475         UI↔Web deadlock when printing with a JavaScript alert visible
2476         https://bugs.webkit.org/show_bug.cgi?id=196839
2477         <rdar://problem/49157642>
2478
2479         Reviewed by Andy Estes.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2482         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2483         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2484         (TEST):
2485
2486 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2487
2488         WKRetainPtr's adoption constructor should be private
2489         https://bugs.webkit.org/show_bug.cgi?id=197019
2490
2491         Reviewed by Tim Horton.
2492
2493         * DumpRenderTree/mac/DumpRenderTree.mm:
2494         (dumpFramesAsText):
2495         * TestWebKitAPI/InjectedBundleController.cpp:
2496         (TestWebKitAPI::InjectedBundleController::initialize):
2497         * TestWebKitAPI/PlatformUtilities.cpp:
2498         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2499         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2500         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2501         (TestWebKitAPI::Util::toWK):
2502         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2503         (TestWebKitAPI::TEST):
2504         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2505         (TestWebKitAPI::TEST):
2506         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2511         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2512         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2515         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2516         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2521         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2522         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2523         (TestWebKitAPI::TEST):
2524         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2525         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2526         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2527         (TestWebKitAPI::TEST):
2528         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2531         (TestWebKitAPI::TEST):
2532         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2533         (TestWebKitAPI::TEST):
2534         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2535         (TestWebKitAPI::TEST):
2536         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2537         (TestWebKitAPI::TEST):
2538         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2541         (TestWebKitAPI::TEST):
2542         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2543         (TestWebKitAPI::TEST):
2544         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2545         (TestWebKitAPI::TEST):
2546         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2547         (TestWebKitAPI::TEST):
2548         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2549         (TestWebKitAPI::TEST):
2550         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2551         (TestWebKitAPI::TEST):
2552         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2553         (TestWebKitAPI::TEST):
2554         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2557         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2558         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2559         (TestWebKitAPI::TEST):
2560         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2561         (TestWebKitAPI::TEST):
2562         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2563         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2564         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2565         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2566         (TestWebKitAPI::TEST):
2567         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2568         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2569         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2570         (TestWebKitAPI::TEST):
2571         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2574         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2575         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2576         (TestWebKitAPI::TEST):
2577         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2578         (TestWebKitAPI::loadAlternateHTMLString):
2579         (TestWebKitAPI::TEST):
2580         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2581         (TestWebKitAPI::TEST):
2582         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2583         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2584         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2585         (TestWebKitAPI::buildAndPerformTest):
2586         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2587         (TestWebKitAPI::TEST):
2588         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2591         (TestWebKitAPI::TEST):
2592         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2595         (TestWebKitAPI::TEST):
2596         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2597         (TestWebKitAPI::TEST):
2598         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2599         (TestWebKitAPI::TEST):
2600         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2601         (TestWebKitAPI::TEST):
2602         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2605         (TestWebKitAPI::TEST):
2606         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2607         (TestWebKitAPI::TEST):
2608         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2609         (TestWebKitAPI::TEST):
2610         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2611         (TestWebKitAPI::TEST):
2612         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2613         (TestWebKitAPI::TEST):
2614         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2615         (TestWebKitAPI::TEST):
2616         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2617         (TestWebKitAPI::TEST):
2618         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2619         (TestWebKitAPI::TEST):
2620         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2621         (TestWebKitAPI::TEST):
2622         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2623         (TestWebKitAPI::TEST):
2624         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2625         (TestWebKitAPI::TEST):
2626         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2627         (TestWebKitAPI::TEST):
2628         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2629         (TestWebKitAPI::TEST):
2630         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2631         (TestWebKitAPI::TEST):
2632         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2633         (TestWebKitAPI::TEST):
2634         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2635         (TestWebKitAPI::TEST):
2636         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2637         (TestWebKitAPI::TEST):
2638         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2639         (TestWebKitAPI::TEST):
2640         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2641         (TestWebKitAPI::TEST):
2642         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2643         (TestWebKitAPI::TEST):
2644         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2645         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2646         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2647         (TestWebKitAPI::TEST):
2648         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2649         (TestWebKitAPI::TEST):
2650         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2651         (TestWebKitAPI::TEST):
2652         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2653         (TestWebKitAPI::TEST):
2654         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2655         (TestWebKitAPI::TEST):
2656         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2657         (TestWebKitAPI::TEST):
2658         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2659         (TestWebKitAPI::TEST):
2660         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2661         (TestWebKitAPI::TEST):
2662         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2663         (TestWebKitAPI::TEST):
2664         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2665         (TestWebKitAPI::TEST):
2666         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2668         (TEST):
2669         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2670         (TEST):
2671         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2672         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2673         (TEST):
2674         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2675         (TestWebKitAPI::TEST):
2676         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2677         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2678         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2679         (WTR::getMenuItemTitleCallback):
2680         (WTR::createMouseMessageBody):
2681         (WTR::EventSendingController::mouseDown):
2682         (WTR::EventSendingController::mouseUp):
2683         (WTR::EventSendingController::mouseMoveTo):
2684         (WTR::EventSendingController::mouseForceClick):
2685         (WTR::EventSendingController::startAndCancelMouseForceClick):
2686         (WTR::EventSendingController::mouseForceDown):
2687         (WTR::EventSendingController::mouseForceUp):
2688         (WTR::EventSendingController::mouseForceChanged):
2689         (WTR::EventSendingController::leapForward):
2690         (WTR::EventSendingController::scheduleAsynchronousClick):
2691         (WTR::createKeyDownMessageBody):
2692         (WTR::EventSendingController::keyDown):
2693         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2694         (WTR::EventSendingController::mouseScrollBy):
2695         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2696         (WTR::EventSendingController::continuousMouseScrollBy):
2697         (WTR::EventSendingController::addTouchPoint):
2698         (WTR::EventSendingController::updateTouchPoint):
2699         (WTR::EventSendingController::setTouchModifier):
2700         (WTR::EventSendingController::setTouchPointRadius):
2701         (WTR::EventSendingController::touchStart):
2702         (WTR::EventSendingController::touchMove):
2703         (WTR::EventSendingController::touchEnd):
2704         (WTR::EventSendingController::touchCancel):
2705         (WTR::EventSendingController::clearTouchPoints):
2706         (WTR::EventSendingController::releaseTouchPoint):
2707         (WTR::EventSendingController::cancelTouchPoint):
2708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2709         (WTR::InjectedBundle::didCreatePage):
2710         (WTR::InjectedBundle::didReceiveMessage):
2711         (WTR::InjectedBundle::didReceiveMessageToPage):
2712         (WTR::InjectedBundle::booleanForKey):
2713         (WTR::InjectedBundle::done):
2714         (WTR::InjectedBundle::dumpToStdErr):
2715         (WTR::InjectedBundle::outputText):
2716         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2717         (WTR::InjectedBundle::postAddChromeInputField):
2718         (WTR::InjectedBundle::postRemoveChromeInputField):
2719         (WTR::InjectedBundle::postFocusWebView):
2720         (WTR::InjectedBundle::postSetBackingScaleFactor):
2721         (WTR::InjectedBundle::postSetWindowIsKey):
2722         (WTR::InjectedBundle::postSetViewSize):
2723         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2724         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2725         (WTR::InjectedBundle::setGeolocationPermission):
2726         (WTR::InjectedBundle::setMockGeolocationPosition):
2727         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2728         (WTR::InjectedBundle::isGeolocationProviderActive const):
2729         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2730         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2731         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2732         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2733         (WTR::InjectedBundle::setCustomPolicyDelegate):
2734         (WTR::InjectedBundle::setHidden):
2735         (WTR::InjectedBundle::setCacheModel):
2736         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2737         (WTR::InjectedBundle::processWorkQueue):
2738         (WTR::InjectedBundle::queueBackNavigation):
2739         (WTR::InjectedBundle::queueForwardNavigation):
2740         (WTR::InjectedBundle::queueLoad):
2741         (WTR::InjectedBundle::queueLoadHTMLString):
2742         (WTR::InjectedBundle::queueReload):
2743         (WTR::InjectedBundle::queueLoadingScript):
2744         (WTR::InjectedBundle::queueNonLoadingScript):
2745         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2746         (WTR::frameToStr):
2747         (WTR::InjectedBundlePage::InjectedBundlePage):
2748         (WTR::dumpFrameDescriptionSuitableForTestResult):
2749         (WTR::dumpFrameScrollPosition):
2750         (WTR::dumpDescendantFrameScrollPositions):
2751         (WTR::dumpFrameText):
2752         (WTR::dumpDescendantFramesText):
2753         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2754         (WTR::TestRunner::shouldDumpPixels const):
2755         (WTR::TestRunner::setDumpPixels):
2756         (WTR::TestRunner::whatToDump const):
2757         (WTR::TestRunner::setWhatToDump):
2758         (WTR::TestRunner::setWaitUntilDone):
2759         (WTR::TestRunner::shouldWaitUntilDone const):
2760         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2761         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2762         (WTR::TestRunner::clearAllDatabases):
2763         (WTR::TestRunner::setIDBPerOriginQuota):
2764         (WTR::TestRunner::originsWithApplicationCache):
2765         (WTR::TestRunner::setCanOpenWindows):
2766         (WTR::TestRunner::setXSSAuditorEnabled):
2767         (WTR::TestRunner::setMediaDevicesEnabled):
2768         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2769         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2770         (WTR::TestRunner::setCustomUserAgent):
2771         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2772         (WTR::TestRunner::setModernMediaControlsEnabled):
2773         (WTR::TestRunner::setWebGL2Enabled):
2774         (WTR::TestRunner::setWritableStreamAPIEnabled):
2775         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2776         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2777         (WTR::TestRunner::setAllowsAnySSLCertificate):
2778         (WTR::TestRunner::setPluginsEnabled):
2779         (WTR::TestRunner::setValueForUser):
2780         (WTR::TestRunner::setAudioResult):
2781         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2782         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2783         (WTR::TestRunner::setAlwaysAcceptCookies):
2784         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2785         (WTR::TestRunner::isDoingMediaCapture const):
2786         (WTR::TestRunner::queueLoad):
2787         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2788         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2789         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2790         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2791         (WTR::TestRunner::setAuthenticationUsername):
2792         (WTR::TestRunner::setAuthenticationPassword):
2793         (WTR::TestRunner::secureEventInputIsEnabled const):
2794         (WTR::TestRunner::setBlockAllPlugins):
2795         (WTR::TestRunner::setPluginSupportedMode):
2796         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2797         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2798         (WTR::TestRunner::setNavigationGesturesEnabled):
2799         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2800         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2801         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2802         (WTR::TestRunner::terminateNetworkProcess):
2803         (WTR::TestRunner::terminateServiceWorkerProcess):
2804         (WTR::TestRunner::runUIScript):
2805         (WTR::TestRunner::setStatisticsDebugMode):
2806         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2807         (WTR::TestRunner::setStatisticsLastSeen):
2808         (WTR::TestRunner::setStatisticsPrevalentResource):
2809         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2810         (WTR::TestRunner::dumpResourceLoadStatistics):
2811         (WTR::TestRunner::isStatisticsPrevalentResource):
2812         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2813         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2814         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2815         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2816         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2817         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2818         (WTR::TestRunner::setStatisticsGrandfathered):
2819         (WTR::TestRunner::isStatisticsGrandfathered):
2820         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2821         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2822         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2823         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2824         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2825         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2826         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2827         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2828         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2829         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2830         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2831         (WTR::TestRunner::statisticsSubmitTelemetry):
2832         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2833         (WTR::TestRunner::setStatisticsIsRunningTest):
2834         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2835         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2836         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2837         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2838         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2839         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2840         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2841         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2842         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2843         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2844         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2845         (WTR::TestRunner::statisticsResetToConsistentState):
2846         (WTR::TestRunner::setStorageAccessAPIEnabled):
2847         (WTR::TestRunner::getAllStorageAccessEntries):
2848         (WTR::TestRunner::addMockMediaDevice):
2849         (WTR::TestRunner::clearMockMediaDevices):
2850         (WTR::TestRunner::removeMockMediaDevice):
2851         (WTR::TestRunner::resetMockMediaDevices):
2852         (WTR::TestRunner::connectMockGamepad):
2853         (WTR::TestRunner::disconnectMockGamepad):
2854         (WTR::TestRunner::setMockGamepadDetails):
2855         (WTR::TestRunner::setMockGamepadAxisValue):
2856         (WTR::TestRunner::setMockGamepadButtonValue):
2857         (WTR::TestRunner::removeAllSessionCredentials):
2858         (WTR::TestRunner::clearDOMCache):
2859         (WTR::TestRunner::clearDOMCaches):
2860         (WTR::TestRunner::hasDOMCache):
2861         (WTR::TestRunner::domCacheSize):
2862         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2863         (WTR::TestRunner::getApplicationManifestThen):
2864         (WTR::TestRunner::injectUserScript):
2865         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2866         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2867         (WTR::TestRunner::addTestKeyToKeychain):
2868         (WTR::TestRunner::cleanUpKeychain):
2869         (WTR::TestRunner::keyExistsInKeychain):
2870         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2871         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2872         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2873         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2874         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2875         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2876         * WebKitTestRunner/TestController.cpp:
2877         (WTR::TestController::initialize):
2878         (WTR::parseStringTestHeaderValueAsRelativePath):
2879         (WTR::updateTestOptionsFromTestHeader):
2880         (WTR::TestController::runTest):
2881         (WTR::TestController::didReceiveLiveDocumentsList):
2882         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2883         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2884         (WTR::TestController::didFinishNavigation):
2885         (WTR::TestController::didReceiveAuthenticationChallenge):
2886         * WebKitTestRunner/TestInvocation.cpp:
2887         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2888         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2889         (WTR::TestInvocation::uiScriptDidComplete):
2890         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2891         * WebKitTestRunner/WebNotificationProvider.cpp:
2892         (WTR::WebNotificationProvider::closeWebNotification):
2893         * WebKitTestRunner/WorkQueueManager.cpp:
2894         (WTR::ScriptItem::ScriptItem):
2895         (WTR::WorkQueueManager::queueLoad):
2896         (WTR::WorkQueueManager::queueLoadHTMLString):
2897
2898 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2899
2900         Add a comment to make my test from r244139 less mysterious.
2901         https://bugs.webkit.org/show_bug.cgi?id=196744
2902
2903         As suggested by Darin Adler.
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2906         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2907
2908 2019-04-17  Chris Dumez  <cdumez@apple.com>
2909
2910         Remember device orientation permission for the duration of the browsing session
2911         https://bugs.webkit.org/show_bug.cgi?id=196992
2912         <rdar://problem/49946067>
2913
2914         Reviewed by Alex Christensen.
2915
2916         Add API test coverage.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2919         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2920         (TEST):
2921
2922 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2925         https://bugs.webkit.org/show_bug.cgi?id=196675
2926
2927         Reviewed by Lucas Forschler.
2928
2929         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2930         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2931
2932 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2933
2934         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2935         https://bugs.webkit.org/show_bug.cgi?id=196919
2936         <rdar://problem/41630459>
2937
2938         Reviewed by Tim Horton.
2939
2940         Add iOS support for several new testing hooks. See below for more detail.
2941
2942         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2943         (WTR::UIScriptController::isDismissingMenu const):
2944
2945         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2946         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2947         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2948
2949         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2951         (WTR::UIScriptController::isDismissingMenu const):
2952         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2953         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2955         (WTR::InjectedBundle::didReceiveMessageToPage):
2956         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2957         (WTR::TestRunner::setAllowedMenuActions):
2958
2959         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2960         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2961         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2962         against the name of the custom action.
2963
2964         (WTR::TestRunner::installCustomMenuAction):
2965
2966         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2967         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2968         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2969         triggered.
2970
2971         (WTR::TestRunner::performCustomMenuAction):
2972
2973         Invoked when the custom menu action is triggered.
2974
2975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2976         * WebKitTestRunner/TestController.cpp:
2977         (WTR::TestController::installCustomMenuAction):
2978         (WTR::TestController::setAllowedMenuActions):
2979         * WebKitTestRunner/TestController.h:
2980         * WebKitTestRunner/TestInvocation.cpp:
2981         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2982         (WTR::TestInvocation::performCustomMenuAction):
2983
2984         Add plumbing to call back into the injected bundle when performing the custom action.
2985
2986         * WebKitTestRunner/TestInvocation.h:
2987         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2988         (WTR::TestController::installCustomMenuAction):
2989         (WTR::TestController::setAllowedMenuActions):
2990         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2991         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2992         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2993         (-[TestRunnerWKWebView becomeFirstResponder]):
2994         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2995
2996         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2997         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2998         in the Mail app on iOS.
2999
3000         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3001         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3002         (-[TestRunnerWKWebView resetCustomMenuAction]):
3003         (-[TestRunnerWKWebView performCustomAction:]):
3004         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3005         (-[TestRunnerWKWebView _willHideMenu]):
3006         (-[TestRunnerWKWebView _didHideMenu]):
3007         * WebKitTestRunner/ios/TestControllerIOS.mm:
3008         (WTR::TestController::platformResetStateToConsistentValues):
3009
3010         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3011         if specified.
3012
3013         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3014         (WTR::UIScriptController::isDismissingMenu const):
3015
3016 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3017
3018         Allow sharing from imageSheet on an image document
3019         https://bugs.webkit.org/show_bug.cgi?id=196891
3020         <rdar://problem/25377386>
3021
3022         Reviewed by Tim Horton.
3023
3024         Test to make sure that the correct imageURL is extracted from an image element.
3025
3026         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3027         (TestWebKitAPI::TEST):
3028
3029 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3030
3031         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3032         https://bugs.webkit.org/show_bug.cgi?id=196995
3033
3034         Reviewed by Brady Eidson.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3037         (TEST):
3038
3039 2019-04-16  Chris Dumez  <cdumez@apple.com>
3040
3041         URL set by document.open() is not communicated to the UIProcess
3042         https://bugs.webkit.org/show_bug.cgi?id=196941
3043         <rdar://problem/49237544>
3044
3045         Reviewed by Geoff Garen.
3046
3047         Add API test coverage.
3048
3049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3050         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3051         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3052         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3053         (TEST):
3054
3055 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3056
3057         Unreviewed, rolling out r244321.
3058         https://bugs.webkit.org/show_bug.cgi?id=196968
3059
3060         Causing all WK2 Debug builds to exit early after Assertion
3061         failures. (Requested by ShawnRoberts on #webkit).
3062
3063         Reverted changeset:
3064
3065         "URL set by document.open() is not communicated to the
3066         UIProcess"
3067         https://bugs.webkit.org/show_bug.cgi?id=196941
3068         https://trac.webkit.org/changeset/244321
3069
3070 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3071
3072         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3073         https://bugs.webkit.org/show_bug.cgi?id=196948
3074
3075         Reviewed by Zalan Bujtas.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3078         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3079
3080 2019-04-15  Chris Dumez  <cdumez@apple.com>
3081
3082         URL set by document.open() is not communicated to the UIProcess
3083         https://bugs.webkit.org/show_bug.cgi?id=196941
3084         <rdar://problem/49237544>
3085
3086         Reviewed by Geoffrey Garen.
3087
3088         Add API test coverage.
3089
3090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3091         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3092         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3093         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3094         (TEST):
3095
3096 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3097
3098         Using Tools/Scripts/clean-webkit should not install requests
3099         https://bugs.webkit.org/show_bug.cgi?id=196940
3100
3101         Reviewed by Lucas Forschler.
3102
3103         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3104         existing, depending on the path autoinstalled is run through.
3105         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3106         needed.
3107         (Port.configuration_for_upload):
3108         (Port.commits_for_upload):
3109
3110 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3111
3112         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3113         https://bugs.webkit.org/show_bug.cgi?id=196773
3114
3115         Reviewed by Jer Noble.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3118         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3119         (TEST):
3120
3121 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3122
3123         ews-build should clearly indicate flaky test failures
3124         https://bugs.webkit.org/show_bug.cgi?id=196947
3125
3126         Reviewed by Lucas Forschler.
3127
3128         * BuildSlaveSupport/ews-build/steps.py:
3129         (AnalyzeAPITestsResults.analyzeResults):
3130
3131 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3132
3133         InjectedBundle parameters often need initialization function called before unarchiving
3134         https://bugs.webkit.org/show_bug.cgi?id=189709
3135         <rdar://problem/44573653>
3136
3137         Reviewed by Ryosuke Niwa.
3138
3139         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3140         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3141
3142 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3143
3144         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3145         https://bugs.webkit.org/show_bug.cgi?id=196681
3146
3147         Reviewed by Darin Adler.
3148
3149         Added tests.
3150
3151         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3152         (WTF_HashSet.RemoveIf):
3153         (WTF_HashSet.RemoveIfShrinkToBestSize):
3154
3155 2019-04-15  John Wilander  <wilander@apple.com>
3156
3157         Send delayed Ad Click Attribution conversion requests to the click source
3158         https://bugs.webkit.org/show_bug.cgi?id=196838
3159         <rdar://problem/47650157>
3160
3161         Reviewed by Chris Dumez and Youenn Fablet.
3162
3163         This patch adds test infrastructure to override the default behavior in
3164         WebKit::NetworkAdClickAttribution.
3165
3166         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3167         (TestWebKitAPI::TEST):
3168         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3170         (WTR::TestRunner::dumpAdClickAttribution):
3171         (WTR::TestRunner::clearAdClickAttribution):
3172         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3173         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3174         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3177         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3178         * WebKitTestRunner/TestController.h:
3179         * WebKitTestRunner/TestInvocation.cpp:
3180         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3181
3182 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3183
3184         [ews-app] status-bubble should display position in queue
3185         https://bugs.webkit.org/show_bug.cgi?id=196607
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3190         (StatusBubble._build_bubble):
3191         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3192
3193 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3194
3195         [ews-build] Do not run clean build by default on EWS builders
3196         https://bugs.webkit.org/show_bug.cgi?id=196897
3197
3198         Reviewed by Lucas Forschler.
3199
3200         * BuildSlaveSupport/ews-build/steps.py:
3201         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3202         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3203         untracked directories like WebKitBuild).
3204         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3205         untracked files/directories (like WebKitBuild).
3206
3207 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3208
3209         TestRunner::notifyDone() should be safely reentrant
3210         https://bugs.webkit.org/show_bug.cgi?id=196898
3211
3212         Reviewed by Darin Adler.
3213
3214         It is currently possible that TestRunner::notifyDone() will call itself, since
3215         notifyDone() will force a repaint, which can start executing JavaScript, which
3216         may call notifyDone() again. This can lead to test failures and flakiness.
3217         Fix this by setting the m_waitToDump flag before calling the dump() method.
3218
3219         * DumpRenderTree/mac/TestRunnerMac.mm:
3220         (TestRunner::notifyDone):
3221         (TestRunner::forceImmediateCompletion):
3222         * DumpRenderTree/win/TestRunnerWin.cpp:
3223         (TestRunner::notifyDone):
3224         (TestRunner::forceImmediateCompletion):
3225
3226 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3227
3228         [GTK][WPE] Add enable-media websetting
3229         https://bugs.webkit.org/show_bug.cgi?id=196863
3230
3231         Reviewed by Michael Catanzaro.
3232
3233         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3234         (testWebKitSettings): Add test for the enable-media web-setting.
3235
3236 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3237
3238         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3239         https://bugs.webkit.org/show_bug.cgi?id=196905
3240         <rdar://problem/49886096>
3241
3242         Reviewed by Tim Horton.
3243
3244         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3245         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3246         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3247         delay timer, we end up with this sequence of events in the problematic (failure) case:
3248
3249         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3250             ...IPC from UI to web process...
3251         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3252             ...IPC from web to UI process...
3253         (c) [UI]    Invoke completion handler for script #1
3254         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3255             ...IPC from UI to web process...
3256         (e) [Web]   Evaluate script #2 in the web process
3257         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3258
3259         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3260         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3261         #2 is run in step (e).
3262
3263         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3264         the UI process by waiting on a script message posted by the web process, after attachment updates are
3265         dispatched.
3266
3267         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3268         (TestWebKitAPI::TEST):
3269
3270 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3271
3272         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3273         https://bugs.webkit.org/show_bug.cgi?id=196909
3274
3275         Reviewed by Wenson Hsieh.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3278         (TestWebKitAPI::TEST):
3279
3280 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3281
3282         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3283         https://bugs.webkit.org/show_bug.cgi?id=196880
3284
3285         Reviewed by Yusuke Suzuki.
3286
3287         Add a new function for bytecode cache tests that does not forceDiskCache
3288         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3289         test added in this patch, since the code is invalid and therefore won't be
3290         cached. It should also be useful for tests that evaluate dynamically
3291         generated code.
3292
3293         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3294         * Scripts/run-jsc-stress-tests:
3295
3296 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3297
3298         Update AudioSession route sharing policy
3299         https://bugs.webkit.org/show_bug.cgi?id=196776
3300         <rdar://problem/46501611>
3301
3302         Reviewed by Jer Noble.
3303
3304         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3305         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3306         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3307         (TestWebKitAPI::TEST):
3308
3309 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3310
3311         [iOS] Software keyboard is shown too frequently on some websites
3312         https://bugs.webkit.org/show_bug.cgi?id=195856
3313         <rdar://problem/49191395>
3314
3315         Reviewed by Darin Adler.
3316
3317         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3318
3319         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3320         (WTR::UIScriptController::setHardwareKeyboardAttached):
3321         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3322         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3323         (WTR::UIScriptController::setHardwareKeyboardAttached):
3324         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3325         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3326
3327         Additionally link against GraphicsServices in WebKitTestRunner.
3328
3329         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3330         (WTR::TestController::platformResetStateToConsistentValues):
3331         (WTR::UIScriptController::setHardwareKeyboardAttached):
3332
3333 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3334
3335         [GTK][WPE] Fix pacman install-dependencies packages
3336         https://bugs.webkit.org/show_bug.cgi?id=196817
3337
3338         Reviewed by Žan Doberšek.
3339         
3340         python3-setuptools is called python-setuptools
3341         ruby-highline is only available on AUR
3342         libv4l-devel is incorporated in v4l-utils
3343
3344         * gtk/install-dependencies:
3345         * wpe/install-dependencies:
3346
3347 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GTK] REGRESSION(r243860): Many tests failing
3350         https://bugs.webkit.org/show_bug.cgi?id=196791
3351
3352         Reviewed by Joanmarie Diggs.
3353
3354         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3355         multiple documents and check that accessibility hierarchy is updated after a navigation.
3356
3357         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3358         (loadChangedCallback):
3359         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3360         (AccessibilityTest::AccessibilityTest):
3361         (AccessibilityTest::~AccessibilityTest):
3362         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3363         (AccessibilityTest::findTestServerApplication):
3364         (AccessibilityTest::findDocumentWeb):
3365         (AccessibilityTest::findRootObject):
3366         (AccessibilityTest::waitUntilChildrenRemoved):
3367         (AccessibilityTest::ensureProxy):
3368         (testAtspiBasicHierarchy):
3369         (beforeAll):
3370         (afterAll):
3371
3372 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3373
3374         [ews-build] Handle bug titles with unicode characters
3375         https://bugs.webkit.org/show_bug.cgi?id=196802
3376
3377         Reviewed by Dewei Zhu.
3378
3379         * BuildSlaveSupport/ews-build/steps.py:
3380         (ValidatePatch._is_bug_closed):
3381
3382 2019-04-11  Michael Saboff  <msaboff@apple.com>
3383
3384         Improve the Inline Cache Stats code
3385         https://bugs.webkit.org/show_bug.cgi?id=196836
3386
3387         Reviewed by Saam Barati.
3388
3389         Added a new script to consolidate and arrange the output of --useICStats option.
3390
3391         This script merges the output from every group into one large table and sorts it from most common to
3392         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3393         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3394         Put together, this is useful to see what property accesses are not getting cached.
3395
3396         * Scripts/ic-stats.py: Added.
3397         (ICStats):
3398         (ICStats.__init__):
3399         (ICStats.parse):
3400         (ICStats.dumpStats):
3401         (usage):
3402
3403 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3404
3405         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3406         https://bugs.webkit.org/show_bug.cgi?id=196809
3407         <rdar://49800762>
3408
3409         Reviewed by Brady Eidson.
3410
3411         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3412         (TEST):
3413
3414 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3415
3416         requestAnimationFrame should execute before the next frame
3417         https://bugs.webkit.org/show_bug.cgi?id=177484
3418
3419         Reviewed by Simon Fraser.
3420
3421         Add trace points for the page RenderingUpdate.
3422
3423         * Tracing/SystemTracePoints.plist:
3424
3425 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3426
3427         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3428         https://bugs.webkit.org/show_bug.cgi?id=196760
3429
3430         Reviewed by Don Olmstead.
3431
3432         vswhere.exe has been bundled since Visual Studio 2017 version
3433         15.2. We shouldn't download vswhere.exe.
3434
3435         * Scripts/build-jsc: Do not call update-vswhere.py.
3436         * Scripts/build-webkit: Ditto.
3437         * Scripts/update-vswhere.py: Removed.
3438         * Scripts/webkitdirs.pm:
3439         (requireModulesForVSWhere): Deleted.
3440         (pickCurrentVisualStudioInstallation): Deleted.
3441         (visualStudioInstallDirVSWhere): Return the latest installed VS
3442         installation path by using the bundled vswhere.exe.
3443         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3444         (visualStudioInstallDirFallback): Removed.
3445
3446 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3449         https://bugs.webkit.org/show_bug.cgi?id=196780
3450
3451         Reviewed by Alexey Proskuryakov.
3452
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         * BuildSlaveSupport/ews-build/steps_unittest.py:
3455
3456 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3457
3458         Add SPI WKNavigationResponse._downloadAttribute
3459         https://bugs.webkit.org/show_bug.cgi?id=196755
3460         <rdar://49587365>
3461
3462         Reviewed by Brady Eidson.
3463
3464         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3465         (-[NavigationResponseTestDelegate navigationResponse]):
3466         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3467         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3468         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3469         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3470         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3471         (readRequest):
3472         (writeResponse):
3473         (TEST):
3474
3475 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3476
3477         Add modern API for overriding the page's specified viewport configuration
3478         https://bugs.webkit.org/show_bug.cgi?id=167734
3479         <rdar://problem/30331795>
3480
3481         Reviewed by Simon Fraser.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3485
3486 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3487
3488         Add support for incremental bytecode cache updates
3489         https://bugs.webkit.org/show_bug.cgi?id=195000
3490
3491         Reviewed by Filip Pizlo.
3492
3493         Exit when the initial run to generate bytecode fails.
3494
3495         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3496
3497 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3498
3499         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3500         https://bugs.webkit.org/show_bug.cgi?id=196744
3501         <rdar://49415309>
3502
3503         Reviewed by Chris Dumez.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3506         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3507
3508 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3509
3510         Add a way to opt into modern compatibility mode in layout tests
3511         https://bugs.webkit.org/show_bug.cgi?id=196770
3512         <rdar://problem/49777550>
3513
3514         Reviewed by Antoine Quint.
3515
3516         Add a new test option to enable modern compatibility mode in layout tests.
3517
3518         * WebKitTestRunner/TestController.cpp:
3519         (WTR::updateTestOptionsFromTestHeader):
3520         * WebKitTestRunner/TestController.h:
3521         * WebKitTestRunner/TestOptions.h:
3522         (WTR::TestOptions::hasSameInitializationOptions const):
3523         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3524         (WTR::TestController::platformCreateWebView):
3525         (WTR::TestController::enableModernCompatibilityMode):
3526
3527 2019-04-10  Andy Estes  <aestes@apple.com>
3528
3529         Try to fix the 32-bit watchOS build.
3530
3531         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3532         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3533
3534 2019-04-10  Antoine Quint  <graouts@apple.com>
3535
3536         Enable Pointer Events on watchOS
3537         https://bugs.webkit.org/show_bug.cgi?id=196771
3538         <rdar://problem/49040909>
3539
3540         Reviewed by Dean Jackson.
3541
3542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3543
3544 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3545
3546         Unreviewed. Fix WPE accessibility tests after r244059.
3547
3548         We are failing to load the injected bundle due to undefined symbol
3549         AccessibilityUIElement::replaceTextInRange().
3550
3551         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3552         (WTR::AccessibilityUIElement::replaceTextInRange):
3553
3554 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3555
3556         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3557         https://bugs.webkit.org/show_bug.cgi?id=196727
3558
3559         Reviewed by Fujii Hironori.
3560
3561         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3562         (WebKitBrowserWindow::create):
3563
3564 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3565
3566         [ews-build] Add unit tests for PrintConfiguration
3567         https://bugs.webkit.org/show_bug.cgi?id=196752
3568
3569         Reviewed by Dewei Zhu.
3570
3571         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3572
3573 2019-04-09  Keith Rollin  <krollin@apple.com>
3574
3575         Unreviewed build maintenance -- update .xcfilelists.
3576
3577         * DumpRenderTree/DerivedSources-input.xcfilelist:
3578         * DumpRenderTree/DerivedSources-output.xcfilelist:
3579
3580 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3581
3582         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3583         https://bugs.webkit.org/show_bug.cgi?id=196743
3584         <rdar://problem/43897551>
3585
3586         Reviewed by Tim Horton.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3589         (TEST):
3590
3591 2019-04-09  Youenn Fablet  <youenn@apple.com>
3592
3593         Close service worker database on network process suspension
3594         https://bugs.webkit.org/show_bug.cgi?id=196623
3595         <rdar://problem/48930869>
3596
3597         Reviewed by Alex Christensen.
3598
3599         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3600
3601 2019-04-09  Daniel Bates  <dabates@apple.com>
3602
3603         [iPad] Should open popover when the spacebar is pressed
3604         https://bugs.webkit.org/show_bug.cgi?id=196360
3605         <rdar://problem/49389129>
3606
3607         Reviewed by Brent Fulgham.
3608
3609         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3610
3611         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3612         (WTR::UIScriptController::isShowingPopover const): Added.
3613         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3614         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3615         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3616         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3617         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3618         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3619         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3620         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3621         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3622         (WTR::UIScriptController::isShowingPopover const): Added.
3623         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3624         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3625         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3626         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3627         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3628         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3629         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3630         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3631         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3632         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3633         (WTR::UIScriptController::isShowingPopover const): Added.
3634         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3635         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3636
3637 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3638
3639         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3640         https://bugs.webkit.org/show_bug.cgi?id=196665
3641         <rdar://45115669>
3642
3643         Reviewed by Geoff Garen.
3644
3645         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3646         (goBack):
3647         (+[SimpleLookupContext sharedLookupContext]):
3648         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3649         (TEST):
3650         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3651         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3652
3653 2019-04-09  John Wilander  <wilander@apple.com>
3654
3655         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3656         https://bugs.webkit.org/show_bug.cgi?id=196558
3657         <rdar://problem/47650245>
3658
3659         Reviewed by Youenn Fablet.
3660
3661         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3662         (TestWebKitAPI::TEST):
3663             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3664
3665 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3666
3667         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3668         https://bugs.webkit.org/show_bug.cgi?id=196720
3669
3670         Reviewed by Konstantin Tokarev.
3671
3672         * TestWebKitAPI/PlatformMac.cmake:
3673
3674 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3675
3676         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3677         https://bugs.webkit.org/show_bug.cgi?id=196694
3678         <rdar://problem/48388734>
3679
3680         Rubber-stamped by Aakash Jain.
3681
3682         * Scripts/webkitpy/port/image_diff.py:
3683         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3684         * Scripts/webkitpy/port/server_process.py:
3685         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3686         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3687         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3688         * Scripts/webkitpy/port/server_process_mock.py:
3689         (MockServerProcess.has_available_stdout):
3690         * Scripts/webkitpy/port/server_process_unittest.py:
3691         (TestServerProcess.serial_test_basic):
3692
3693 2019-04-09  Jer Noble  <jer.noble@apple.com>
3694
3695         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3696         https://bugs.webkit.org/show_bug.cgi?id=196097
3697
3698         Reviewed by Eric Carlson.
3699
3700         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3701
3702         * DumpRenderTree/mac/DumpRenderTree.mm:
3703         (resetWebPreferencesToConsistentValues):
3704         * WebKitTestRunner/TestController.cpp:
3705         (WTR::TestController::resetPreferencesToConsistentValues):
3706
3707 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3708
3709         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3710         https://bugs.webkit.org/show_bug.cgi?id=196690
3711
3712         Reviewed by Michael Catanzaro.
3713
3714         * QueueStatusServer/config/queues.py:
3715         * Scripts/webkitpy/common/config/ews.json:
3716         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3717         (test_ews_name):
3718
3719 2019-04-09  Chris Dumez  <cdumez@apple.com>
3720
3721         Loads using loadHTMLString() cause flashing when process-swapping
3722         https://bugs.webkit.org/show_bug.cgi?id=196714
3723         <rdar://problem/49637354>
3724
3725         Reviewed by Antti Koivisto.
3726
3727         Add API test coverage.
3728
3729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3730
3731 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3732
3733         Unreviewed. Fix ATK accessibility tests after r244059.
3734
3735         We are failing to load the injected bundle due to undefined symbol
3736         AccessibilityUIElement::replaceTextInRange().
3737
3738         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3739         (WTR::AccessibilityUIElement::replaceTextInRange):
3740
3741 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3742
3743         AX: Support API: accessibilityReplaceRange:withText
3744         https://bugs.webkit.org/show_bug.cgi?id=196636
3745
3746         Unreviewed build fix for Windows port.
3747
3748         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3749         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3750
3751 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3752
3753         [CMake][WinCairo] Separate copied headers into different directories
3754         https://bugs.webkit.org/show_bug.cgi?id=196655
3755
3756         Reviewed by Michael Catanzaro.
3757
3758         * DumpRenderTree/CMakeLists.txt:
3759         * MiniBrowser/win/CMakeLists.txt:
3760         * TestWebKitAPI/CMakeLists.txt:
3761         * TestWebKitAPI/PlatformWin.cmake:
3762
3763 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3764
3765         Log stack-trace for run-webkit-tests when interrupted
3766         https://bugs.webkit.org/show_bug.cgi?id=176393
3767         <rdar://problem/34262310>
3768
3769         Reviewed by Lucas Forschler.
3770
3771         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3772         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3773         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3774         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3775         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3776         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3777         (main): Set handlers to log stack trace on interruption.
3778
3779 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3780
3781         AX: Support API: accessibilityReplaceRange:withText
3782         https://bugs.webkit.org/show_bug.cgi?id=196636
3783
3784         Unreviewed build fix for Windows port.
3785
3786         * DumpRenderTree/AccessibilityUIElement.cpp:
3787         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3788
3789 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3790
3791         [ews-build] Scripts using Buildbot API have CORS error
3792         https://bugs.webkit.org/show_bug.cgi?id=196709
3793
3794         Reviewed by Alexey Proskuryakov.
3795
3796         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3797
3798 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3799
3800         AX: Support API: accessibilityReplaceRange:withText
3801         https://bugs.webkit.org/show_bug.cgi?id=196636
3802
3803         Reviewed by Daniel Bates.
3804
3805         * DumpRenderTree/AccessibilityUIElement.cpp:
3806         (replaceTextInRangeCallback):
3807         (AccessibilityUIElement::replaceTextInRange):
3808         (AccessibilityUIElement::getJSClass):
3809         * DumpRenderTree/AccessibilityUIElement.h:
3810         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3811         (AccessibilityUIElement::replaceTextInRange):
3812         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3813         (AccessibilityUIElement::replaceTextInRange):
3814         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3815         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3816         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3817         (WTR::AccessibilityUIElement::replaceTextInRange):
3818         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3819         (WTR::AccessibilityUIElement::replaceTextInRange):
3820
3821 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3822
3823         [iOS] Do not allow starting selection drags when selection views are not visible
3824         https://bugs.webkit.org/show_bug.cgi?id=196686
3825         <rdar://problem/49399192>
3826
3827         Reviewed by Tim Horton.
3828
3829         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3830         also add some new API tests to cover scenarios where the web view is not first responder.
3831
3832         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3833         (TestWebKitAPI::TEST):
3834         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3835
3836         Add a switch to optionally make the web view first responder when starting the simulated drag.
3837
3838         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3839         (-[DragAndDropSimulator initWithWebView:]):
3840         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3841
3842 2019-04-08  Justin Fan  <justin_fan@apple.com>
3843
3844         [Web GPU] Fix Web GPU experimental feature on iOS
3845         https://bugs.webkit.org/show_bug.cgi?id=196632
3846
3847         Reviewed by Myles C. Maxfield.
3848
3849         Properly make Web GPU available on iOS 11+.
3850
3851         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3852
3853 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3854
3855         [ews-build] Do not upload archive when Compile Fails
3856         https://bugs.webkit.org/show_bug.cgi?id=196674
3857
3858         Reviewed by Alexey Proskuryakov.
3859
3860         * BuildSlaveSupport/ews-build/factories.py:
3861         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3862         * BuildSlaveSupport/ews-build/steps.py:
3863         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3864         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3865         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3866
3867 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3868
3869         Enable DFG on MIPS
3870         https://bugs.webkit.org/show_bug.cgi?id=196689
3871
3872         Reviewed by Žan Doberšek.
3873
3874         Since the bytecode change, we enabled the baseline JIT on mips in
3875         r240432, but DFG is still missing. With this change, all tests are
3876         passing on a ci20 board.
3877
3878         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3879
3880 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3881
3882         [Flatpak] Second run update-webkitwpe-flatpak fails
3883         https://bugs.webkit.org/show_bug.cgi?id=192702
3884
3885         Reviewed by Carlos Garcia Campos.
3886
3887         * flatpak/flatpakutils.py:
3888         (FlatpakObject.flatpak): Fix typo.
3889         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3890         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3891
3892 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3893
3894         [GTK][WPE] outlook.live.com displays old-fashioned UI
3895         https://bugs.webkit.org/show_bug.cgi?id=196642
3896
3897         Reviewed by Carlos Garcia Campos.
3898
3899         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3900         (TestWebKitAPI::TEST): New Mac platform quirk test.
3901
3902 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3903
3904         Unreviewed, rolling out r243956.
3905         https://bugs.webkit.org/show_bug.cgi?id=196688
3906
3907         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3908         by aakashjain on #webkit).
3909
3910         Reverted changeset:
3911
3912         "Clicking "Go Back" from a safe browsing warning from an
3913         iframe should navigate the WKWebView back to the previous
3914         page"
3915         https://bugs.webkit.org/show_bug.cgi?id=196665
3916         https://trac.webkit.org/changeset/243956
3917
3918 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3919
3920         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3921         https://bugs.webkit.org/show_bug.cgi?id=196669
3922
3923         Reviewed by Geoffrey Garen.
3924
3925         Added three new unit tests for WeakHashSet.
3926
3927         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3928         (WTF_WeakPtr.WeakHashSetConstObjects):
3929         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3930         (WTF_WeakPtr.WeakHashSetComputeSize):
3931
3932 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3933
3934         Hide next and previous form control buttons when WKWebView is editable
3935         https://bugs.webkit.org/show_bug.cgi?id=196672
3936         <rdar://problem/35625321>
3937
3938         Reviewed by Tim Horton.
3939
3940         Add a new API test.
3941
3942         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3943         (-[TestWKWebView lastTrailingBarButtonGroup]):
3944         (TestWebKitAPI::TEST):
3945         * TestWebKitAPI/ios/UIKitSPI.h:
3946
3947 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3948
3949         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3950         https://bugs.webkit.org/show_bug.cgi?id=196077
3951         <rdar://problem/49108202>
3952
3953         Reviewed by Chris Dumez.
3954
3955         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3956         on new web view.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3959
3960 2019-04-05  Saam Barati  <sbarati@apple.com>
3961
3962         Make compare-results understand MotionMark
3963         https://bugs.webkit.org/show_bug.cgi?id=196666
3964
3965         Reviewed by Yusuke Suzuki.
3966
3967         * Scripts/compare-results:
3968         (PLT5Results):
3969         (detectMotionMark):
3970         (detectMotionMark1_1):
3971         (motionMarkResults):
3972         (motionMark1_1Results):
3973         (detectBenchmark):
3974         (biggerIsBetter):
3975         (main):
3976
3977 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3978
3979         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3980         https://bugs.webkit.org/show_bug.cgi?id=196665
3981         <rdar://45115669>
3982
3983         Reviewed by Geoff Garen.
3984
3985         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3986         (goBack):
3987         (+[SimpleLookupContext sharedLookupContext]):
3988         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3989         (TEST):
3990         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3991         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3992
3993 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3994
3995         [ews-build] Add configuration and architecture for windows builders
3996         https://bugs.webkit.org/show_bug.cgi?id=196660
3997
3998         Reviewed by Lucas Forschler.
3999
4000         * BuildSlaveSupport/ews-build/config.json:
4001
4002 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
4003
4004         webkitpy: Don't run subsequent rounds if interrupted
4005         https://bugs.webkit.org/show_bug.cgi?id=196646
4006
4007         Reviewed by Aakash Jain.
4008
4009         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4010         (Manager.run): Bail out if interrupted.
4011
4012 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
4013
4014         Test sessionStorage in PSON private browsing mode
4015         https://bugs.webkit.org/show_bug.cgi?id=196561
4016
4017         Reviewed by Alex Christensen.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4020
4021 2019-04-05  Commit Queue  <commit-queue@webkit.org>
4022
4023         Unreviewed, rolling out r243833.
4024         https://bugs.webkit.org/show_bug.cgi?id=196645
4025
4026         This change breaks build of WPE and GTK ports (Requested by
4027         annulen on #webkit).
4028
4029         Reverted changeset:
4030
4031         "[CMake][WTF] Mirror XCode header directories"
4032         https://bugs.webkit.org/show_bug.cgi?id=191662
4033         https://trac.webkit.org/changeset/243833
4034
4035 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
4036
4037         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
4038         https://bugs.webkit.org/show_bug.cgi?id=196635
4039
4040         Reviewed by Antti Koivisto.
4041         
4042         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
4043         for a test to enable async frame scrolling via:
4044             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
4045         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
4046         
4047         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
4048
4049         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4050         (WTR::InjectedBundle::beginTesting):
4051         * WebKitTestRunner/TestController.cpp:
4052         (WTR::TestController::resetPreferencesToConsistentValues):
4053
4054 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
4055
4056         Use a correct LC_RPATH when building with ASan
4057         https://bugs.webkit.org/show_bug.cgi?id=196576
4058
4059         Reviewed by David Kilzer.
4060
4061         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
4062         so that ../Frameworks is checked. This is simpler and more reliable than updating
4063         each SPC service xcconfig.
4064
4065 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4066
4067         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4068         https://bugs.webkit.org/show_bug.cgi?id=196629
4069
4070         Reviewed by Lucas Forschler.
4071
4072         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4073
4074 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4075
4076         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4077         https://bugs.webkit.org/show_bug.cgi?id=196618
4078
4079         Reviewed by Lucas Forschler.
4080
4081         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4082         (StatusBubble): Added QUEUE_TRIGGERS.
4083         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
4084         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
4085         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4086         its parent(builder).
4087
4088 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4089
4090         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4091         https://bugs.webkit.org/show_bug.cgi?id=196625
4092
4093         Reviewed by Lucas Forschler.
4094
4095         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4096         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4097
4098 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4099
4100         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4101         https://bugs.webkit.org/show_bug.cgi?id=196630
4102
4103         Reviewed by Wenson Hsieh.
4104
4105         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4106
4107 2019-04-04  Youenn Fablet  <youenn@apple.com>
4108
4109         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4110         https://bugs.webkit.org/show_bug.cgi?id=196543
4111
4112         Reviewed by Alex Christensen.
4113
4114         * WebKitTestRunner/TestController.cpp:
4115         (WTR::TestController::generatePageConfiguration):
4116
4117 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4118
4119         [ews-app] Status bubble should not display skipped buildbot steps
4120         https://bugs.webkit.org/show_bug.cgi?id=196584
4121
4122         Reviewed by Lucas Forschler.
4123
4124         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4125
4126 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4127
4128         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4129         https://bugs.webkit.org/show_bug.cgi?id=196620
4130
4131         Reviewed by Lucas Forschler.
4132
4133         * BuildSlaveSupport/ews-app/ews/config.py:
4134
4135 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4136
4137         [Win] DumpRenderTreeWatchDog.py is not checked into source
4138         https://bugs.webkit.org/show_bug.cgi?id=196567
4139         <rdar://problem/49525901>
4140
4141         Reviewed by Lucas Forschler.
4142
4143         This script is used on Win EWS bots to terminate hanging DRT processes.
4144
4145         * EWSTools/dumprendertreewatchdog.py: Added.
4146
4147 2019-04-04  Chris Dumez  <cdumez@apple.com>
4148
4149         Unreviewed, roll out r243858 which made tests time out.
4150
4151         Disable new API tests on Windows instead.
4152
4153         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4154         (TestWebKitAPI::TEST):
4155
4156 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4157
4158         [ATK] Cleanup WebPageAccessibilityObjectAtk
4159         https://bugs.webkit.org/show_bug.cgi?id=196537
4160
4161         Reviewed by Michael Catanzaro.
4162
4163         Also consider files under atk directories as exceptions for GObject conventions.
4164
4165         * Scripts/webkitpy/style/checkers/cpp.py:
4166         (check_identifier_name_in_declaration):
4167
4168 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
4169
4170         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4171         https://bugs.webkit.org/show_bug.cgi?id=196588
4172         <rdar://problem/49365787>
4173
4174         Unreviewed build fix for Windows port.
4175
4176         error C3861: 'kill': identifier not found
4177
4178         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4179         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
4180
4181 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4182
4183         [ews-build] Cancel build and similar operations should have authentication
4184         https://bugs.webkit.org/show_bug.cgi?id=196520
4185
4186         Reviewed by Dewei Zhu.
4187
4188         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
4189         environment variables.
4190
4191 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4192
4193         [ews-build] Do not trigger queues which are not in production yet
4194         https://bugs.webkit.org/show_bug.cgi?id=196581
4195
4196         Reviewed by Dewei Zhu.
4197
4198         * BuildSlaveSupport/ews-build/config.json:
4199
4200 2019-04-03  Chris Dumez  <cdumez@apple.com>
4201
4202         Unreviewed, fix typo in the name of API test added in r243848.
4203
4204         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4205         (TestWebKitAPI::TEST):
4206
4207 2019-04-03  Chris Dumez  <cdumez@apple.com>
4208
4209         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4210         https://bugs.webkit.org/show_bug.cgi?id=196588
4211         <rdar://problem/49365787>
4212
4213         Reviewed by Ryosuke Niwa.
4214
4215         Add API test coverage.
4216
4217         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4218         (TestWebKitAPI::nullJavaScriptCallback):
4219         (TestWebKitAPI::didCrashCheckFrames):
4220         (TestWebKitAPI::TEST):
4221
4222 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4223
4224         run-webkit-tests: Upload test results (new results database)
4225         https://bugs.webkit.org/show_bug.cgi?id=196577
4226         <rdar://problem/34841155>
4227
4228         Reviewed by Lucas Forschler.
4229
4230         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4231         (Manager.run): Upload results after each device shard, since the configuration will be
4232         different for each device.
4233         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
4234         uploaded to a results database.
4235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4236         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
4237
4238 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4239
4240         -apple-trailing-word is needed for browser detection
4241         https://bugs.webkit.org/show_bug.cgi?id=196575
4242
4243         Unreviewed.
4244
4245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4246
4247 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
4248
4249         [CMake][WTF] Mirror XCode header directories
4250         https://bugs.webkit.org/show_bug.cgi?id=191662
4251
4252         Reviewed by Konstantin Tokarev.
4253
4254         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
4255         builds.
4256
4257         * CMakeLists.txt:
4258         * DumpRenderTree/CMakeLists.txt:
4259         * DumpRenderTree/PlatformWin.cmake:
4260         * MiniBrowser/win/CMakeLists.txt:
4261         * TestWebKitAPI/CMakeLists.txt:
4262         * TestWebKitAPI/PlatformWin.cmake:
4263         * WebKitTestRunner/PlatformGTK.cmake:
4264         * WebKitTestRunner/PlatformWin.cmake:
4265
4266 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4267
4268         [ews-app] Status bubble should not display certain infrastructure status messages
4269         https://bugs.webkit.org/show_bug.cgi?id=196550
4270
4271         Reviewed by Lucas Forschler.
4272
4273         Do not display the steps which are un-needed for end-user. This information is still avaiable
4274         if the user click on the bubble and look at the Buildbot build.
4275         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4276         (StatusBubble._steps_messages):
4277         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
4278
4279 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4280
4281         [ews-build] Use https for sending data to ews-app
4282         https://bugs.webkit.org/show_bug.cgi?id=196492
4283
4284         Reviewed by Lucas Forschler.
4285
4286         * BuildSlaveSupport/ews-build/events.py:
4287
4288 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4289
4290         Remove support for -apple-trailing-word
4291         https://bugs.webkit.org/show_bug.cgi?id=196525
4292
4293         Reviewed by Zalan Bujtas.
4294
4295         This CSS property is nonstandard and not used.
4296
4297         * Scripts/webkitperl/FeatureList.pm:
4298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4299
4300 2019-04-03  Youenn Fablet  <youenn@apple.com>
4301
4302         Add a test for DOMCache on multiple browsing in case of private browsing
4303         https://bugs.webkit.org/show_bug.cgi?id=196524
4304
4305         Reviewed by Alex Christensen.
4306
4307         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4308         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
4309
4310 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4311
4312         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
4313         https://bugs.webkit.org/show_bug.cgi?id=196540
4314
4315         Reviewed by Aakash Jain.
4316
4317         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
4318
4319 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4320
4321         Add plumbing for a compatibility mode preference in WebKit
4322         https://bugs.webkit.org/show_bug.cgi?id=196005
4323
4324         Reviewed by Tim Horton.
4325
4326         Add new API tests.
4327
4328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4329         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
4330