[iOS WK2] Use the simulated device's screen size, rather than a harcoded size
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2
3         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
4         https://bugs.webkit.org/show_bug.cgi?id=160748
5
6         Reviewed by Tim Horton.
7         
8         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
9         opens the door for tests using other device sizes.
10
11         * WebKitTestRunner/ios/TestControllerIOS.mm:
12         (WTR::TestController::platformConfigureViewForTest):
13
14 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
15
16         Sort the feature flags in the FEATURE_DEFINES lines
17         https://bugs.webkit.org/show_bug.cgi?id=160742
18
19         Reviewed by Anders Carlsson.
20         
21         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22
23 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
24
25         Logging and other minor improvements to iOS webkitpy
26         https://bugs.webkit.org/show_bug.cgi?id=160722
27
28         Reviewed by Dan Bates.
29
30         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
31         to make it easier to debug launching issues.
32
33         Have reset_preferences() reset the device, rather than just nuking the data
34         directory (which broke some versions of the simulator).
35
36         Make the Simulator.app launch in the background with open -g.
37
38         Wait for the simulator device to be in a known state in some more places.
39
40         * Scripts/webkitpy/port/ios.py:
41         (IOSSimulatorPort.setup_test_run):
42         (IOSSimulatorPort._quit_ios_simulator):
43         (IOSSimulatorPort.clean_up_test_run):
44         (IOSSimulatorPort.setup_environ_for_server):
45         (IOSSimulatorPort.reset_preferences):
46         * Scripts/webkitpy/xcode/simulator.py:
47         (Device.create):
48         (Device.delete):
49         (Device):
50         (Device.reset):
51         (Simulator.wait_until_device_is_booted):
52         (Simulator.wait_until_device_is_in_state):
53         (Simulator):
54         (Simulator.delete_device):
55         (Simulator.reset_device):
56         (Simulator.lookup_or_create_device):
57
58 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
59
60         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
61         https://bugs.webkit.org/show_bug.cgi?id=160697
62
63         Reviewed by Antonio Gomes.
64
65         * Scripts/webkitpy/port/base.py:
66         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
67         list of environment variables to copy.
68
69 2016-08-09  George Ruan  <gruan@apple.com>
70
71         Implement functionality of media capture on iOS
72         https://bugs.webkit.org/show_bug.cgi?id=158945
73         <rdar://problem/26893343>
74
75         Reviewed by Tim Horton.
76
77         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
78         Capture feature on iOS.
79
80 2016-08-09  Saam Barati  <sbarati@apple.com>
81
82         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
83         https://bugs.webkit.org/show_bug.cgi?id=160671
84         <rdar://problem/27756112>
85
86         Reviewed by Mark Lam.
87
88         * Scripts/run-jsc-stress-tests:
89
90 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
91
92         Make directory reading code in iOSSimulatorDevices() more strict
93         https://bugs.webkit.org/show_bug.cgi?id=160702
94
95         Reviewed by Tim Horton.
96
97         * Scripts/webkitdirs.pm:
98         (iOSSimulatorDevices):
99
100 2016-08-06  Sam Weinig  <sam@webkit.org>
101
102         Replace NodeOrString with std::variant<RefPtr<Node>, String>
103         https://bugs.webkit.org/show_bug.cgi?id=160638
104
105         Reviewed by Anders Carlsson.
106
107         * TestWebKitAPI/CMakeLists.txt:
108         * TestWebKitAPI/Tests/WTF/Variant.cpp:
109         Add additional tests for the initial state of std::variant and using
110         makeVisitor for visiting.
111
112 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
113
114         EWS logging should ensure the logging to file is stopped on queue termination
115         https://bugs.webkit.org/show_bug.cgi?id=160698
116         rdar://problem/24464570
117
118         Reviewed by Daniel Bates.
119
120         * Scripts/webkitpy/tool/bot/queueengine.py:
121         (QueueEngine._stopping): Stop logging to file on queue termination.
122         (QueueEngine._begin_logging): Configure the Python logger to log to file.
123         * Scripts/webkitpy/common/system/logutils.py:
124         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
125         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
126         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
127         * Scripts/webkitpy/tool/commands/queues.py:
128         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
129         (AbstractQueue.queue_log_path): Same.
130         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
131         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
132         which moved to QueueEngine now.
133         (PatchProcessingQueue.__init__): Same.
134         (CommitQueue.__init__): Same.
135         (AbstractReviewQueue.__init__): Same.
136         (StyleQueue.__init__): Same.
137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
138         (TestCommitQueue): Removed host parameter.
139         (TestCommitQueue.__init__): Same.
140         (AbstractPatchQueueTest.test_next_patch): Same.
141         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
142         (test_commit_queue_failure): Same.
143         (mock_run_webkit_patch):
144         (MockCommitQueueTask.results_from_patch_test_run): Same.
145         (test_rollout_lands): Same.
146         (test_non_valid_patch): Same.
147         (test_auto_retry): Same.
148         (test_style_queue_with_watch_list_exception): Same.
149         (TestQueue.__init__): Deleted.
150         (TestReviewQueue.__init__): Deleted.
151         (TestFeederQueue.__init__): Deleted.
152
153 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
154
155         webkit-gtk tarball fails to build due to missing files
156         https://bugs.webkit.org/show_bug.cgi?id=160684
157
158         Reviewed by Alex Christensen.
159
160         * gtk/manifest.txt.in: Added back spi directories.
161
162 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
163
164         [GTK] Build the jhbuild with -O2 optimization level by default
165         https://bugs.webkit.org/show_bug.cgi?id=160544
166
167         Reviewed by Michael Catanzaro.
168
169         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
170         which don't increases the required disk space significatively and
171         provides better debug information than no passing it.
172
173 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
174
175         Allow more --cmakeargs option in build-jsc and build-webkit
176         https://bugs.webkit.org/show_bug.cgi?id=160340
177
178         Reviewed by Michael Catanzaro.
179
180         * Scripts/build-jsc:
181         * Scripts/build-webkit:
182
183 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
184
185         Do not check if WebKitLibraries folder exists on EFL and GTK
186         https://bugs.webkit.org/show_bug.cgi?id=160659
187
188         Reviewed by Csaba Osztrogonác.
189
190         Though WebKitLibraries is only needed by mac and win ports,
191         EFL and GTK ports have checked whether it exists.
192
193         * Scripts/build-webkit:
194
195 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
196
197         Some EWS console logs doesn't go to log file
198         https://bugs.webkit.org/show_bug.cgi?id=160585
199         rdar://problem/24464570
200
201         Reviewed by Daniel Bates.
202
203         * Scripts/webkitpy/common/system/logutils.py:
204         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
205         any possible overwriting.
206         * Scripts/webkitpy/common/system/filesystem.py:
207         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
208         * Scripts/webkitpy/common/system/filesystem_mock.py:
209         (MockFileSystem.open_text_file_for_writing): Same.
210         * Scripts/webkitpy/common/system/filesystem_unittest.py:
211         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
212         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
213         * Scripts/webkitpy/tool/commands/queues.py:
214         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
215         This will ensure that all the sub-modules inside webkitpy will log to file.
216
217 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
218
219         Have the iOS platform interit from the Apple platform in webkitpy
220         https://bugs.webkit.org/show_bug.cgi?id=160672
221
222         Reviewed by Dan Bates.
223         
224         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
225         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
226         ApplePort.
227         
228         Since WinPort also inherits from ApplePort, it needs to stub out some things
229         that are unavailable on Windows (leaks, sampling).
230         
231         Some SnowLeopard-related code and the associated test were removed.
232
233         * Scripts/webkitpy/port/apple.py:
234         (ApplePort.__init__):
235         (ApplePort):
236         (ApplePort._make_leak_detector):
237         (ApplePort.default_timeout_ms):
238         (ApplePort.supports_per_test_timeout):
239         (ApplePort.should_retry_crashes):
240         (ApplePort._generate_all_test_configurations):
241         (ApplePort.check_for_leaks):
242         (ApplePort.print_leaks_summary):
243         (ApplePort._path_to_webcore_library):
244         (ApplePort.show_results_html_file):
245         (ApplePort._merge_crash_logs):
246         (ApplePort._look_for_all_crash_logs_in_log_dir):
247         (ApplePort._get_crash_log):
248         (ApplePort.look_for_new_crash_logs):
249         (ApplePort.sample_process):
250         (ApplePort.sample_file_path):
251         (ApplePort.look_for_new_samples):
252         (ApplePort._path_to_helper):
253         (ApplePort.determine_full_port_name): Deleted.
254         * Scripts/webkitpy/port/ios.py:
255         (IOSSimulatorPort):
256         (IOSSimulatorPort.__init__):
257         (IOSSimulatorPort.default_timeout_ms): Deleted.
258         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
259         (IOSSimulatorPort.should_retry_crashes): Deleted.
260         (IOSSimulatorPort.check_for_leaks): Deleted.
261         (IOSSimulatorPort.print_leaks_summary): Deleted.
262         (IOSSimulatorPort._path_to_webcore_library): Deleted.
263         (IOSSimulatorPort.show_results_html_file): Deleted.
264         (IOSSimulatorPort.sample_file_path): Deleted.
265         (IOSSimulatorPort._merge_crash_logs): Deleted.
266         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
267         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
268         (IOSSimulatorPort.look_for_new_samples): Deleted.
269         (IOSSimulatorPort.sample_process): Deleted.
270         (IOSSimulatorPort._path_to_helper): Deleted.
271         (IOSSimulatorPort.make_command): Deleted.
272         * Scripts/webkitpy/port/mac.py:
273         (MacPort.__init__):
274         (MacPort.make_command):
275         (MacPort._build_java_test_support):
276         (MacPort): Deleted.
277         (MacPort.default_timeout_ms): Deleted.
278         (MacPort.supports_per_test_timeout): Deleted.
279         (MacPort.should_retry_crashes): Deleted.
280         (MacPort.default_child_processes): Deleted.
281         (MacPort.check_for_leaks): Deleted.
282         (MacPort.print_leaks_summary): Deleted.
283         (MacPort._path_to_webcore_library): Deleted.
284         (MacPort.show_results_html_file): Deleted.
285         (MacPort.sample_file_path): Deleted.
286         (MacPort._merge_crash_logs): Deleted.
287         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
288         (MacPort.look_for_new_crash_logs): Deleted.
289         (MacPort.look_for_new_samples): Deleted.
290         (MacPort.sample_process): Deleted.
291         (MacPort._path_to_helper): Deleted.
292         * Scripts/webkitpy/port/mac_unittest.py:
293         (MacTest.test_default_child_processes): Deleted.
294         * Scripts/webkitpy/port/win.py:
295         (WinPort.look_for_new_samples):
296         (WinPort):
297         (WinPort.sample_process):
298         (WinPort._make_leak_detector):
299         (WinPort.check_for_leaks):
300         (WinPort.print_leaks_summary):
301         (WinPort._path_to_webcore_library):
302
303 2016-08-08  Matt Baker  <mattbaker@apple.com>
304
305         Unreviewed: moved myself to the reviewers list.
306
307         * Scripts/webkitpy/common/config/contributors.json:
308
309 2016-08-08  Chris Dumez  <cdumez@apple.com>
310
311         Update API tests in mac/SetDocumentURI.mm after r204247
312         https://bugs.webkit.org/show_bug.cgi?id=160660
313
314         Reviewed by Alex Christensen.
315
316         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
317         (TestWebKitAPI::TEST):
318
319 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
320
321         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
322         https://bugs.webkit.org/show_bug.cgi?id=159827
323
324         Reviewed by Daniel Bates.
325
326         This change was spurred by a process hang which occurred between tests and did
327         not produce a meaningful crashlog.
328
329         * Scripts/webkitpy/port/driver.py:
330         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
331
332          * Scripts/webkitpy/port/ios.py:
333         (IOSSimulatorPort):
334         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
335         * Scripts/webkitpy/port/mac.py:
336         (MacPort):
337         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
338
339         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
340         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
341
342         * WebKitTestRunner/TestController.h:
343         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
344         * WebKitTestRunner/TestInvocation.cpp:
345         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
346
347 2016-08-07  Dan Bernstein  <mitz@apple.com>
348
349         [Cocoa] Reply block leaks if the remote object doesn’t call it
350         https://bugs.webkit.org/show_bug.cgi?id=160642
351
352         Reviewed by Sam Weinig.
353
354         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
355         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
356         (TEST): Added a test case that checks that the reply block is released even when it’s not
357           called.
358         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
359         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
360           calling the completion handler.
361
362 2016-08-07  Chris Dumez  <cdumez@apple.com>
363
364         Write API test to cover crash fix in r204135
365         https://bugs.webkit.org/show_bug.cgi?id=160587
366
367         Reviewed by Darin Adler.
368
369         Add API test to cover crash fix in r204135. This reproduces the crash
370         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
371         callback.
372
373         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
374         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
375         (TEST):
376
377 2016-08-06  Chris Dumez  <cdumez@apple.com>
378
379         Unreviewed, rolling out r204226.
380
381         Broke some API tests
382
383         Reverted changeset:
384
385         "Write API test to cover crash fix in r204135"
386         https://bugs.webkit.org/show_bug.cgi?id=160587
387         http://trac.webkit.org/changeset/204226
388
389 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
390
391         EWS Style Queue fails to process patches which fails validation
392         https://bugs.webkit.org/show_bug.cgi?id=160632
393
394         Reviewed by Alexey Proskuryakov.
395
396         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
397         (StyleQueueTask.validate): Add more information about validation failure.
398         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
399         * Scripts/webkitpy/tool/commands/queues_unittest.py:
400         (test_non_valid_patch): Add a unit test to test the above code path.
401
402 2016-08-06  Sam Weinig  <sam@webkit.org>
403
404         WTF needs a variant implementation
405         https://bugs.webkit.org/show_bug.cgi?id=160618
406
407         Reviewed by Darin Adler.
408
409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
410         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
411         Add tests for the variant implementation.
412
413 2016-08-06  Chris Dumez  <cdumez@apple.com>
414
415         Write API test to cover crash fix in r204135
416         https://bugs.webkit.org/show_bug.cgi?id=160587
417
418         Reviewed by Darin Adler.
419
420         Add API test to cover crash fix in r204135. This reproduces the crash
421         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
422         callback.
423
424         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
425         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
426         (TEST):
427
428 2016-08-05  Tim Horton  <timothy_horton@apple.com>
429
430         run-api-tests should use a headed simulator
431         https://bugs.webkit.org/show_bug.cgi?id=160611
432
433         Reviewed by Sam Weinig.
434
435         CADisplayLink doesn't work in a headless simulator, but is
436         vital for the proper functioning of WebKit2 painting on iOS.
437         So, we should not use a headless simulator.
438
439         * Scripts/run-api-tests:
440         Launch a simulator app, don't just boot the simulator.
441
442         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
443         Re-enable a test that works now.
444
445 2016-08-05  Dan Bernstein  <mitz@apple.com>
446
447         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
448         https://bugs.webkit.org/show_bug.cgi?id=160589
449
450         Reviewed by Tim Horton.
451
452         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
453         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
454           blocks, which wasn’t caught because the test wasn’t run correctly.
455         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
456         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
457           added a test that sends over an NSRange.
458         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
459         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
460           handler with the range‘s location and length.
461
462 2016-08-05  Enrica Casucci  <enrica@apple.com>
463
464         Fixing tests failing after r204175.
465
466         Unreviewed.
467
468         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
469
470 2016-08-05  Enrica Casucci  <enrica@apple.com>
471
472         Build fix after 204053.
473
474         Unreviewed.
475
476         * TestWebKitAPI/Configurations/Base.xcconfig:
477         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
478         (-[MockContentFilterEnabler initWithCoder:]):
479         (-[MockContentFilterEnabler dealloc]):
480
481 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
482
483         Print test name in "Last character read from DRT..." error message.
484         https://bugs.webkit.org/show_bug.cgi?id=160559
485
486         Reviewed by Michael Catanzaro.
487
488         * Scripts/webkitpy/port/driver.py:
489         (Driver.run_test):
490         (Driver._read_first_block):
491         (Driver._read_optional_image_block):
492         (Driver._read_block):
493         * Scripts/webkitpy/port/driver_unittest.py:
494         (DriverTest.test_read_block):
495         (DriverTest.test_read_binary_block):
496         (DriverTest.test_read_base64_block):
497
498 2016-08-05  Commit Queue  <commit-queue@webkit.org>
499
500         Unreviewed, rolling out r204123.
501         https://bugs.webkit.org/show_bug.cgi?id=160597
502
503         Caused layout test timeouts on Windows. (Requested by perarne
504         on #webkit).
505
506         Reverted changeset:
507
508         "[Win] Unable to reliably run tests in parallel"
509         https://bugs.webkit.org/show_bug.cgi?id=140914
510         http://trac.webkit.org/changeset/204123
511
512 2016-08-04  Saam Barati  <sbarati@apple.com>
513
514         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
515         https://bugs.webkit.org/show_bug.cgi?id=151241
516
517         Reviewed by Benjamin Poulain.
518
519         * Scripts/run-jsc-stress-tests:
520
521 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
522
523         UI improvements to Flakiness Dashboard.
524         https://bugs.webkit.org/show_bug.cgi?id=153295
525
526         Reviewed by Alexey Proskuryakov.
527
528         * TestResultServer/static-dashboards/flakiness_dashboard.css:
529         (td.options-container): Center text in most fields.
530         * TestResultServer/static-dashboards/flakiness_dashboard.js:
531         (createBugHTML): Text/Grammar updates.
532         (tableHeaders): Ditto.
533         (htmlForSingleTestRow): Ditto.
534         (headerForTestTableHtml): Ditto.
535         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
536         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
537
538 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
539
540         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
541         https://bugs.webkit.org/show_bug.cgi?id=160518
542
543         Reviewed by Michael Catanzaro.
544
545         * Scripts/webkitpy/thirdparty/__init__.py:
546         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
547         * gtk/install-dependencies:
548
549 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
550
551         Optimize bot watcher's dashboard a little
552         https://bugs.webkit.org/show_bug.cgi?id=160515
553         rdar://problem/26096900
554
555         Reviewed by Lucas Forschler.
556
557         Made re-sorting after loading an iteration more efficient.
558
559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
560         (BuildbotIteration.prototype._updateWithData):
561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
562         (BuildbotQueue.prototype.updateIterationPosition):
563
564 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
565
566         [Win] Unable to reliably run tests in parallel
567         https://bugs.webkit.org/show_bug.cgi?id=140914
568
569         Reviewed by Brent Fulgham.
570
571         The cygpath utility function can fail badly when running with multiple DumpRenderTree
572         processes. We can use string replacement to convert the Cygwin path to a Windows path
573         instead.
574  
575         * Scripts/webkitpy/common/system/path.py:
576         (cygpathFast):
577         * Scripts/webkitpy/port/driver.py:
578         (Driver._command_from_driver_input):
579
580 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
581
582         Document instructions for increasing process and file limits
583         https://bugs.webkit.org/show_bug.cgi?id=160528
584         rdar://problem/24777576
585
586         Reviewed by Alexey Proskuryakov.
587
588         * Scripts/webkitpy/port/ios.py:
589         (IOSSimulatorPort.default_child_processes):
590
591 2016-08-03  Anders Carlsson  <andersca@apple.com>
592
593         Remove the Objective-C bindings generator
594         https://bugs.webkit.org/show_bug.cgi?id=160526
595
596         Reviewed by Sam Weinig.
597
598         * Scripts/run-bindings-tests:
599         Update test.
600
601 2016-08-03  Tim Horton  <timothy_horton@apple.com>
602
603         Revise a TestWebKitAPI comment to mention the actual underlying problem
604
605         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
606         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
607
608 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
609
610         Benchmark test content-animation timeouts always
611         https://bugs.webkit.org/show_bug.cgi?id=160057
612
613         Reviewed by Simon Fraser.
614
615         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
616         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
617         (start):
618
619 2016-08-02  Nan Wang  <n_wang@apple.com>
620
621         AX: Simulated touch events are not working on iOS
622         https://bugs.webkit.org/show_bug.cgi?id=160395
623         <rdar://problem/27633597>
624
625         Reviewed by Chris Fleizach.
626
627         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
628         (WTR::AccessibilityUIElement::press):
629         (WTR::AccessibilityUIElement::setSelectedChild):
630
631 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
632
633         run-javascriptcore-tests should accept multiple --extra-tests
634         https://bugs.webkit.org/show_bug.cgi?id=160486
635
636         Reviewed by Saam Barati.
637         
638         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
639         test suites. This does it by using GetOpt::Long's array support.
640
641         * Scripts/run-javascriptcore-tests:
642         (runJSCStressTests):
643
644 2016-08-02  Enrica Casucci  <enrica@apple.com>
645
646         Allow building with content filtering disabled.
647         https://bugs.webkit.org/show_bug.cgi?id=160454
648
649         Reviewed by Simon Fraser.
650
651         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
652
653 2016-08-02  Brady Eidson  <beidson@apple.com>
654
655         Removing IndexedDB WebsiteData can fail for some users.
656         https://bugs.webkit.org/show_bug.cgi?id=160463
657
658         Reviewed by Alex Christensen.
659
660         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
661
662 2016-08-01  Alex Christensen  <achristensen@webkit.org>
663
664         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
665         https://bugs.webkit.org/show_bug.cgi?id=160437
666         <rdar://problem/27578272>
667
668         Reviewed by Brady Eidson.
669
670         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
671         (-[DownloadDelegate _download:didReceiveResponse:]):
672         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
673         (runTest):
674         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
675
676 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
677
678         [Tools] The GDB backtrace report tool don't checks the gdb return code.
679         https://bugs.webkit.org/show_bug.cgi?id=160414
680
681         Reviewed by Michael Catanzaro.
682
683         * Scripts/webkitpy/port/linux_get_crash_log.py:
684         (GDBCrashLogGenerator._wait_for_corefile):
685
686 2016-08-01  Youenn Fablet  <youenn@apple.com>
687
688         Make wpt server generate its certificates in layout test results folder
689         https://bugs.webkit.org/show_bug.cgi?id=160422
690
691         Reviewed by Chris Dumez.
692
693         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
694         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
695
696 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
697
698         Function Call on NULL Object
699         https://bugs.webkit.org/show_bug.cgi?id=160325
700
701         Reviewed by Darin Adler.
702
703         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
704         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
705         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
706
707 2016-08-01  Keith Miller  <keith_miller@apple.com>
708
709         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
710         https://bugs.webkit.org/show_bug.cgi?id=160372
711
712         Rubber stamped by Geoffrey Garen.
713
714         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
715         a new top level directory, JSTests. Having the tests in the Source directory
716         was both confusing an inconvenient for people that just want to checkout the
717         source code of WebKit. Since there is no other obvious place to put all the
718         JavaScript tests a new top level directory seemed the most sensible.
719
720         * Scripts/import-test262-tests:
721         * Scripts/run-javascriptcore-tests:
722         * Scripts/update-javascriptcore-test-res:
723
724 2016-07-31  Nan Wang  <n_wang@apple.com>
725
726         AX: Add a check for touch event listener on iOS accessibility object
727         https://bugs.webkit.org/show_bug.cgi?id=160388
728
729         Reviewed by Chris Fleizach.
730
731         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
732         (AccessibilityUIElement::boolAttributeValue):
733         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
734         (WTR::AccessibilityUIElement::boolAttributeValue):
735
736 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
737
738         Unreviewed: add myself to the reviewers list.
739
740         * Scripts/webkitpy/common/config/contributors.json:
741
742 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
743
744         Undo r203939, and copy over a rule that clips the logos.
745
746         Sierra wasn't the only logo without transparency.
747
748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
751
752 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
753
754         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
755         https://bugs.webkit.org/show_bug.cgi?id=160377
756
757         Reviewed by Brian Weinstein.
758
759         Update assets to remove the white background and use a transparent background instead.
760
761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
763
764 2016-07-29  David Kilzer  <ddkilzer@apple.com>
765
766         Ignore most check-webkit-style checks for ANGLE project
767         <https://webkit.org/b/160333>
768
769         Reviewed by Daniel Bates.
770
771         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
772         - No tabs.
773         - No spaces at the end of lines.
774         - No carriage returns (DOS line endings).
775
776 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
777
778         Media controls are not displayed for some autoplaying videos at certain browser dimensions
779         https://bugs.webkit.org/show_bug.cgi?id=160360
780         <rdar://problem/27179484>
781
782         Reviewed by Myles C. Maxfield.
783
784         Adds two tests verifying that videos may be considered main content as long as they
785         are large enough and cover a majority of the mainframe's viewport.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
789         (TestWebKitAPI::TEST):
790         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
791         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
792
793 2016-07-29  Mark Lam  <mark.lam@apple.com>
794
795         Gardening: removed unused variable.
796
797         Not reviewed.
798
799         * TestWebKitAPI/Tests/WTF/StringView.cpp:
800         (TestWebKitAPI::TEST):
801
802 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
803
804         Add TestWebKitAPI support for interacting with media controls
805         https://bugs.webkit.org/show_bug.cgi?id=160342
806         <rdar://problem/27610246>
807
808         Reviewed by Beth Dakin.
809
810         Adds support for testing interaction with some media controls, as well as a basic test
811         verifying that media control teardown after interaction does not result in a crash.
812
813         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
814         (-[WKWebView mouseDownAtPoint:]):
815         (-[WKWebView performAfterLoading:]):
816         (TestWebKitAPI::TEST):
817
818 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
819
820         Crash Log Clobbering on Unbound Crashes
821         https://bugs.webkit.org/show_bug.cgi?id=160198
822         <rdar://problem/27472618>
823
824         Reviewed by Alexey Proskuryakov.
825
826         * Scripts/webkitpy/common/system/crashlogs.py:
827         (CrashLogs): Fix header order.
828         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
829         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
830
831 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
832
833         Update for contributors.json
834         https://bugs.webkit.org/show_bug.cgi?id=160294
835
836         * Scripts/webkitpy/common/config/contributors.json:
837
838 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
839
840         Remove deprecated SPI for video inline / fullscreen controls
841         https://bugs.webkit.org/show_bug.cgi?id=160318
842
843         Reviewed by Tim Horton.
844
845         * DumpRenderTree/mac/DumpRenderTree.mm:
846         (setDefaultsToConsistentValuesForTesting): Deleted.
847         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
848         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
849         * WebKitTestRunner/TestController.cpp:
850         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
851         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
852         (WTR::initializeWebViewConfiguration): Deleted.
853
854 2016-07-28  Daniel Bates  <dabates@apple.com>
855
856         [iOS] TestWebKitAPI bundle targets are not code signed
857         https://bugs.webkit.org/show_bug.cgi?id=160328
858         <rdar://problem/27409246>
859
860         Reviewed by Andy Estes.
861
862         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
863         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
864         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
865
866         * TestWebKitAPI/Configurations/Base.xcconfig:
867
868 2016-07-28  Tim Horton  <timothy_horton@apple.com>
869
870         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
871
872         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
873         (animatedResizeWebView):
874         (TEST):
875         This test times out only when run in the WebKit Testing simulator environment,
876         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
877
878 2016-07-28  Tim Horton  <timothy_horton@apple.com>
879
880         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
881         https://bugs.webkit.org/show_bug.cgi?id=160289
882         <rdar://problem/27553464>
883
884         Reviewed by Simon Fraser.
885
886         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
889         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
890         (-[AnimatedResizeWebView _endAnimatedResize]):
891         (animatedResizeWebView):
892         (TEST):
893         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
894         Add two tests that ensure that hidden-content and animated resizes
895         don't cause unnecessary synchronous waits. Only the hidden-content
896         one fails before my patch, but it seemed reasonable to add both anyway.
897
898 2016-07-28  David Kilzer  <ddkilzer@apple.com>
899
900         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
901         <https://webkit.org/b/83342>
902
903         Reviewed by Ryosuke Niwa.
904
905         * Scripts/webkitpy/common/checkout/scm/git.py:
906         (Git.revisions_changing_file): Remove code to raise an exception
907         when the file doesn't exist.  If a file was moved or renamed,
908         then this caused the script to terminate, which was very
909         frustrating when you wanted a list of reviewers.
910         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
911         (SCMTest._shared_test_revisions_changing_file): Update test
912         expectation to return an empty list of revisions.
913         (test_create_patch_is_full_patch): Drive-by fix when running all
914         webkitpy tests (including scm tests).
915         * Scripts/webkitpy/common/checkout/scm/svn.py:
916         (SVN.revisions_changing_file): Catch ScriptError exceptions and
917         return an empty array of revisions if this occurs.
918
919 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
920
921         EWS error message "Error: * did not process patch" should include explanation
922         https://bugs.webkit.org/show_bug.cgi?id=159903
923         <rdar://problem/27410788>
924
925         Reviewed by Alexey Proskuryakov.
926
927         * QueueStatusServer/handlers/statusbubble.py:
928         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
929         is not processed.
930         * QueueStatusServer/handlers/processingtimesjson.py:
931         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
932         of the code.
933         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
934         (CommitQueueTask.validate): Add more information about validation failure.
935         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
936         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
937         (EarlyWarningSystemTask.validate): Add more information about validation failure.
938         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
939         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
940         (PatchIsNotValid.__init__): Add the failure_message argument.
941         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
942         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
943         failure details.
944         * Scripts/webkitpy/tool/commands/queues.py:
945         (CommitQueue.process_work_item): Same.
946         (StyleQueue.review_patch): Same.
947         * Scripts/webkitpy/tool/commands/queues_unittest.py:
948         (test_non_valid_patch): Updated test-cases messages to match the above changes.
949
950 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
951
952         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
953         https://bugs.webkit.org/show_bug.cgi?id=160262
954
955         Reviewed by Daniel Bates.
956
957         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
958         (-[LTRelayController installApp]):
959
960 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
961
962         Disable WebCoreNSURLSessionTest API tests on ios-simulator
963         https://bugs.webkit.org/show_bug.cgi?id=160225
964
965         Reviewed by Alexey Proskuryakov.
966
967         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
968
969 2016-07-27  Miguel Gomez  <magomez@igalia.com>
970
971         [GTK] Fix some video/canvas tests that should be passing
972         https://bugs.webkit.org/show_bug.cgi?id=160023
973
974         Reviewed by Carlos Garcia Campos.
975
976         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
977         EFL or GTK platforms.
978
979         * WebKitTestRunner/efl/TestControllerEfl.cpp:
980         (WTR::TestController::platformConfigureViewForTest):
981         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
982         (WTR::TestController::platformConfigureViewForTest):
983
984 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
985
986         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
987         https://bugs.webkit.org/show_bug.cgi?id=160247
988
989         Reviewed by Michael Catanzaro.
990
991         * BuildSlaveSupport/built-product-archive:
992         (createZip):
993         (dirContainsdwo):
994         (archiveBuiltProduct):
995
996 2016-07-26  Alex Christensen  <achristensen@webkit.org>
997
998         Fix tests after r203743.
999         https://bugs.webkit.org/show_bug.cgi?id=156947
1000
1001         * WebKitTestRunner/TestController.cpp:
1002         (WTR::TestController::resetStateToConsistentValues):
1003         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1004
1005 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1006
1007         [iPhone] Playing a video on tudou.com plays only sound, no video
1008         https://bugs.webkit.org/show_bug.cgi?id=160178
1009         <rdar://problem/27535468>
1010
1011         Reviewed by Dan Bernstein.
1012
1013         * DumpRenderTree/mac/DumpRenderTree.mm:
1014         (setDefaultsToConsistentValuesForTesting):
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1016         (RequiresUserActionForPlaybackTest::SetUp):
1017         * WebKitTestRunner/TestController.cpp:
1018         (WTR::TestController::resetPreferencesToConsistentValues):
1019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1020         (WTR::initializeWebViewConfiguration):
1021
1022 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1023
1024         Allow LOG macros to be used outside the namespace, and other logging cleanup
1025         https://bugs.webkit.org/show_bug.cgi?id=160216
1026
1027         Reviewed by Anders Carlsson.
1028         
1029         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1030
1031         * DumpRenderTree/TestRunner.cpp:
1032         * DumpRenderTree/mac/DumpRenderTree.mm:
1033         (resetWebViewToConsistentStateBeforeTesting):
1034
1035 2016-07-26  David Kilzer <ddkilzer@apple.com>
1036
1037         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1038         https://bugs.webkit.org/show_bug.cgi?id=156947
1039         <rdar://problem/23325160>
1040
1041         Reviewed by Alex Christensen.
1042
1043         * DumpRenderTree/TestRunner.cpp:
1044         (TestRunner::TestRunner):
1045         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1046         * DumpRenderTree/TestRunner.h:
1047         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1048         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1049         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1050         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1053         (WTR::TestRunner::queueNonLoadingScript):
1054         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1055         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1056         * WebKitTestRunner/TestController.cpp:
1057         (WTR::TestController::didReceiveAuthenticationChallenge):
1058         * WebKitTestRunner/TestController.h:
1059         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1060         * WebKitTestRunner/TestInvocation.cpp:
1061         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1062         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1063
1064 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1065
1066         check-for-exit-time-destructors should be usable outside Xcode
1067         <https://webkit.org/b/160195>
1068
1069         Reviewed by Darin Adler.
1070
1071         * Scripts/check-for-exit-time-destructors: Update to parse
1072         -h|--help switch, or to take one argument to a binary to check
1073         for exit time destructors on the command-line.  The clang
1074         compiler will find these at compile-time with the
1075         -Wexit-time-destructors switch, but this script will check for
1076         them after-the-fact.
1077
1078 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1079
1080         Test svn.webkit.org functionality after maintenance.
1081
1082 2016-07-25  Brady Eidson  <beidson@apple.com>
1083
1084         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1085         https://bugs.webkit.org/show_bug.cgi?id=153783
1086
1087         Reviewed by Alex Christensen.
1088
1089         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1090         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1091         
1092         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1093         
1094         Change the relevant API tests to make sure this continues to be no longer required.
1095
1096         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1097         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1098         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1099         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1100         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1101         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1102
1103 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1104
1105         Media controls should not be displayed for a video until it starts playing
1106         https://bugs.webkit.org/show_bug.cgi?id=160092
1107         <rdar://problem/26986673>
1108
1109         Reviewed by Beth Dakin.
1110
1111         Verify that multiple videos do or don't show the media controller depending on whether videos
1112         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1113         passing because we were always showing media controls for large videos with audio, even if they
1114         had not played back yet. This change ensures that large videos with audio show media controls
1115         only after they begin to play back, and not by virtue of being large enough for main content.
1116
1117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1118         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1119         (TestWebKitAPI::TEST):
1120         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1121         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1123
1124 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1125
1126         Media controls on apple.com don't disappear when movie finishes playing
1127         https://bugs.webkit.org/show_bug.cgi?id=160068
1128         <rdar://problem/26668526>
1129
1130         Reviewed by Darin Adler.
1131
1132         Adds new API tests. Please see WebCore ChangeLog for more details.
1133
1134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1135         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1136         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1137         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1138         (TestWebKitAPI::TEST):
1139         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1140         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1141         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1142         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1143         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1144
1145 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1146
1147         Unreviewed, fix test-webkitpy after r203674.
1148
1149         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1150         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1151
1152 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1153
1154         Unreviewed, forgot to commit this file in r203674.
1155
1156         * Scripts/process-linux-coredump: Added.
1157         (main):
1158
1159 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1160
1161         Improve GDB backtrace generation for GTK/EFL
1162         https://bugs.webkit.org/show_bug.cgi?id=128928
1163
1164         Reviewed by Carlos Garcia Campos.
1165
1166         The PID of the crashed process is now correctly supplied to the
1167         crash log reporter. The kernel core_pattern needs to be updated
1168         after this change to something like:
1169
1170         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1171
1172         * Scripts/process-linux-coredump: Added.
1173         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1174         * Scripts/webkitpy/port/efl.py:
1175         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1176         * Scripts/webkitpy/port/gtk.py:
1177         (GtkPort._get_crash_log): Ditto.
1178         * Scripts/webkitpy/port/linux_get_crash_log.py:
1179         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1180         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1181         (GDBCrashLogGenerator): Deleted.
1182         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1183         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1184         * WebKitTestRunner/TestController.cpp:
1185         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1186         (WTR::TestController::databaseProcessDidCrash): Ditto.
1187         (WTR::TestController::processDidCrash): Ditto.
1188
1189 2016-07-23  Youenn Fablet  <youenn@apple.com>
1190
1191         WPT stash server should be kept running when launching wpt server
1192         https://bugs.webkit.org/show_bug.cgi?id=160052
1193
1194         Reviewed by Sam Weinig.
1195
1196         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1197         (main): waiting to read stdin while stash server is started.
1198
1199 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         Media controls should be displayed for media in media documents
1202         https://bugs.webkit.org/show_bug.cgi?id=160104
1203         <rdar://problem/27438936>
1204
1205         Reviewed by Myles C. Maxfield.
1206
1207         Verifies that even a small video with audio in a media document gets media controls.
1208
1209         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1210         (TestWebKitAPI::TEST):
1211
1212 2016-07-22  Michael Saboff  <msaboff@apple.com>
1213
1214         REGRESSION(203616): no FTL testing was inadvertently removed
1215         https://bugs.webkit.org/show_bug.cgi?id=160100
1216
1217         Rubber-stamped by Filip Pizlo.
1218
1219         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1220         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1221         logic for the runLayout and runNoisy variants to match the run test logic,
1222         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1223         enabled platforms.
1224
1225         * Scripts/run-jsc-stress-tests:
1226
1227 2016-07-22  Brady Eidson  <beidson@apple.com>
1228
1229         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1230         https://bugs.webkit.org/show_bug.cgi?id=160089
1231
1232         Reviewed by Darin Adler.
1233
1234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1235         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1236         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1237
1238 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1239
1240         [GTK] Improved exclusion patterns in make-dist.py manifest.
1241         https://bugs.webkit.org/show_bug.cgi?id=160094
1242
1243         Reviewed by Michael Catanzaro.
1244
1245         * gtk/manifest.txt.in:
1246         Exclude Platform*.cmake files for more ports.
1247         Removed obsolete .gyp and .pro.user patterns.
1248         Exclude 'Configurations' and 'spi' directories.
1249         Exclude CMakeLists.txt.user (Qt Creator IDE).
1250
1251 2016-07-22  Michael Saboff  <msaboff@apple.com>
1252
1253         Don't run FTL related JSC stress tests on non-FTL platforms
1254         https://bugs.webkit.org/show_bug.cgi?id=160033
1255
1256         Reviewed by Mark Lam.
1257
1258         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1259         Refactored several of the runXXX test methods to always runXXXDefault and made those
1260         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1261         doesn't cause a problem.
1262
1263         * Scripts/run-jsc-stress-tests:
1264
1265 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1266
1267         IWebView::mainFrame crashes if called after IWebView::close
1268         https://bugs.webkit.org/show_bug.cgi?id=32868
1269
1270         Reviewed by Brent Fulgham.
1271
1272         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1273         (TestWebKitAPI::TEST_F): Added test.
1274
1275 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1276
1277         [GTK] Enable threaded compositor by default
1278         https://bugs.webkit.org/show_bug.cgi?id=160079
1279
1280         Reviewed by Žan Doberšek.
1281
1282         * Scripts/webkitperl/FeatureList.pm:
1283
1284 2016-07-22  Youenn Fablet  <youenn@apple.com>
1285
1286         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1287         https://bugs.webkit.org/show_bug.cgi?id=159921
1288
1289         Reviewed by Brian Burg.
1290
1291         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1292
1293         * Scripts/webkitpy/codegen/main.py:
1294         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1295         (BuiltinsGeneratorTests):
1296         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1297         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1298         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1299         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1300
1301 2016-07-21  Dan Bernstein  <mitz@apple.com>
1302
1303         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1304         https://bugs.webkit.org/show_bug.cgi?id=160072
1305
1306         Reviewed by Andy Estes.
1307
1308         * Scripts/webkitdirs.pm:
1309         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1310           for old Xcode versions.
1311         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1312           to readXcodeUserDefault.
1313         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1314           debugger.
1315         (determineDebugger): Ditto.
1316         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1317           7.0.
1318         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1319           switches.
1320         (execMacWebKitAppForDebugging): Removed support for GDB.
1321
1322 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1323
1324         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1325         https://bugs.webkit.org/show_bug.cgi?id=160066
1326
1327         Reviewed by Dean Jackson.
1328
1329         * DumpRenderTree/mac/DumpRenderTree.mm:
1330         (setDefaultsToConsistentValuesForTesting): Deleted.
1331         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1332         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1335         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1336         (WTR::initializeWebViewConfiguration): Deleted.
1337
1338 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1339
1340         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1341         https://bugs.webkit.org/show_bug.cgi?id=159980
1342         rdar://problem/27450825
1343
1344         Reviewed by Dan Bernstein.
1345
1346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1347         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1348         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1349         when our delegate has hit -dealloc.
1350         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1351         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1352         will not be messaged.
1353
1354 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1355
1356         Follow-up patch to r203520
1357         https://bugs.webkit.org/show_bug.cgi?id=159967
1358         <rdar://problem/26964090>
1359
1360         Unreviewed.
1361
1362         * DumpRenderTree/mac/DumpRenderTree.mm:
1363         (setDefaultsToConsistentValuesForTesting):
1364         * WebKitTestRunner/TestController.cpp:
1365         (WTR::TestController::resetPreferencesToConsistentValues):
1366
1367 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1368
1369         [iPhone] Playing a video on tudou.com plays only sound, no video
1370         https://bugs.webkit.org/show_bug.cgi?id=159967
1371         <rdar://problem/26964090>
1372
1373         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1374
1375         Migrate tests to use new SPI.
1376
1377         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1378         (RequiresUserActionForPlaybackTest::SetUp):
1379         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1380         (WTR::initializeWebViewConfiguration):
1381
1382 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1383
1384         Clarify testing mode names in run-jsc-stress-tests
1385         https://bugs.webkit.org/show_bug.cgi?id=160021
1386
1387         Reviewed by Mark Lam.
1388
1389         Default should mean really default, not default with disabled FTL, renamed
1390         - runMozillaTestDefault to runMozillaTestNoFTL
1391         - runMozillaTestDefaultFTL to runMozillaTestDefault
1392         - runDefault to runNoFTL
1393         - runDefaultFTL to runDefault
1394         - runLayoutTestDefault to runLayoutTestNoFTL
1395         - runLayoutTestDefaultFTL to runLayoutTestDefault
1396         - runNoisyTestDefault to runNoisyTestNoFTL
1397         - runNoisyTestDefaultFTL to runNoisyTestDefault
1398
1399         * Scripts/run-jsc-stress-tests:
1400
1401 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1402
1403         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1404         https://bugs.webkit.org/show_bug.cgi?id=159986
1405
1406         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1407         to 0.
1408
1409         Reviewed by Dan Bernstein.
1410
1411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1412         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1413         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1414         (TEST):
1415
1416 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1417
1418         [GTK] Web view background colors don't work in accelerated compositing mode
1419         https://bugs.webkit.org/show_bug.cgi?id=159455
1420
1421         Reviewed by Michael Catanzaro.
1422
1423         Set always RGBA visual to the view widget when setting a background color.
1424
1425         * MiniBrowser/gtk/BrowserWindow.c:
1426         (browser_window_set_background_color):
1427
1428 2016-07-20  Youenn Fablet  <youenn@apple.com>
1429
1430         Bots should run built-ins generator tests
1431         https://bugs.webkit.org/show_bug.cgi?id=159971
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1436         (RunBuiltinsTests): New step to run built-in generator tests.
1437         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1438         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1440
1441 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1442
1443         Revert temporary fix r203417
1444         https://bugs.webkit.org/show_bug.cgi?id=160001
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1449
1450 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1451
1452         REGRESSION(r148588): ews classes might get garbage collected
1453         https://bugs.webkit.org/show_bug.cgi?id=159990
1454
1455         Reviewed by Ryosuke Niwa.
1456
1457         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1458         in a variable so that they do not get garbage collected.
1459
1460 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1461
1462         Add API test for layout constraints after exit fullscreen
1463         https://bugs.webkit.org/show_bug.cgi?id=159900
1464
1465         Reviewed by Jon Lee.
1466
1467         Added Fullscreen.LaytoutConstraints API test. 
1468         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1469
1470         This test compares layout constraints on the web view before and after fullscreen to make sure 
1471         they are preserved.
1472
1473         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1474         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1475         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1476         (TestWebKitAPI::TEST):
1477
1478 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1479
1480         Disable two failing API tests.
1481
1482         Unreviewed test gardening.
1483
1484         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1485         (TestWebKitAPI::TEST):
1486
1487 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         Unreviewed iOS build fix.
1490
1491         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1492
1493 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1494
1495         Media controls don't appear when pausing a small autoplaying video
1496         https://bugs.webkit.org/show_bug.cgi?id=159972
1497         <rdar://problem/27180657>
1498
1499         Reviewed by Beth Dakin.
1500
1501         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1502         for simulating basic user interaction in VideoControlsManager.
1503
1504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1505         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1506         (-[WKWebView mouseDownAtPoint:]):
1507         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1508         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1509         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1510         (TestWebKitAPI::TEST):
1511         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1512
1513 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1514
1515         [Win] MathML fonts are not found.
1516         https://bugs.webkit.org/show_bug.cgi?id=159920
1517
1518         Reviewed by Alex Christensen.
1519
1520         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1521         for a specific registry key value.
1522
1523         * Scripts/webkitdirs.pm:
1524         (fontExists):
1525
1526 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1527
1528         Improve prepare-ChangeLog for @media blocks
1529         https://bugs.webkit.org/show_bug.cgi?id=159907
1530
1531         Reviewed by Timothy Hatcher.
1532
1533         * Scripts/prepare-ChangeLog:
1534         (get_selector_line_ranges_for_css):
1535         Get a range for @media blocks just like a selector.
1536             Start Line = line with '{'
1537             End line = line with '}'
1538             Name = "@media ..."
1539
1540         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1541         Improved error messages for unbalanced portions.
1542
1543         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1544         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1545         (.media-query::before):
1546         (@media only screen and (max-width: 980px)):
1547         (.media-query a):
1548         (@media (-webkit-min-device-pixel-ratio: 2)):
1549         (.both a):
1550         (.both b):
1551         (.media-query b):
1552         (.media-query::after):
1553
1554 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         Fix expectedFailErrorHandler in run-jsc-stress-tests
1557         https://bugs.webkit.org/show_bug.cgi?id=159811
1558
1559         Reviewed by Yusuke Suzuki.
1560
1561         * Scripts/run-jsc-stress-tests:
1562
1563 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1564
1565         Unreviewed Mac cmake buildfix after r203426. Just for fun.
1566
1567         * TestWebKitAPI/PlatformMac.cmake:
1568
1569 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
1570
1571         The default testing mode should not involve disabling the FTL JIT
1572         https://bugs.webkit.org/show_bug.cgi?id=159929
1573
1574         Rubber stamped by Mark Lam and Saam Barati.
1575         
1576         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
1577         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
1578         FTL was not the default. You had to enable it with an option.
1579         
1580         For some reason we have kept this arrangement even though the FTL JIT is now the default on
1581         all of the major ports. This has become a serious pain. For example, it's useful to be able
1582         to say that a test should only run in the default config that is representative of what a
1583         normal user would see if they ran JSC. Clearly, this would be a config that does not
1584         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
1585         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
1586         
1587         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
1588         try to fix it, because:
1589         
1590         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
1591           have the FTL enabled never run any tests that explicitly disable the FTL, since that
1592           doesn't do anything. The code is not really structured to allow this.
1593         
1594         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
1595           disabled in testing. On the other hand there are already build bots that do FTL tests
1596           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
1597           preserving this broken feature, we should create something that (a) acknowledges the fact
1598           that the FTL is the default on those platforms that support it and (b) avoids running
1599           no-ftl tests on precisely those platforms that don't have FTL.
1600         
1601         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
1602           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
1603           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
1604           pretending that the FTL JIT is not the default just because some bots used that as an
1605           optimization.
1606         
1607         This change allows me to speed up some debug tests and paint some bots green.
1608
1609         * Scripts/run-javascriptcore-tests:
1610         (runJSCStressTests):
1611         * Scripts/run-jsc-stress-tests:
1612
1613 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1614
1615         Fix API test after r203426.
1616         https://bugs.webkit.org/show_bug.cgi?id=159949
1617
1618         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1619         (TEST):
1620         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
1621         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
1622
1623 2016-07-19  Andy Estes  <aestes@apple.com>
1624
1625         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
1626         https://bugs.webkit.org/show_bug.cgi?id=159956
1627
1628         Reviewed by Dan Bernstein.
1629
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
1631         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1632         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
1633         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
1634
1635 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1636
1637         Add regression test for r203392
1638         https://bugs.webkit.org/show_bug.cgi?id=159949
1639
1640         Reviewed by Brady Eidson.
1641
1642         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1643         (fileSize):
1644         (swizzledBundleIdentifierWebBookmarksD):
1645         (defaultApplicationCacheDirectory):
1646         (TEST):
1647         (swizzledBundleIdentifierMobileSafari): Deleted.
1648         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
1649         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
1650         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
1651
1652 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1653
1654         Add regression test for r203392
1655         https://bugs.webkit.org/show_bug.cgi?id=159949
1656
1657         Reviewed by Brady Eidson.
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
1661         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
1662         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
1663         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1664         (TEST):
1665         (fileSize):
1666         (swizzledBundleIdentifierMobileSafari):
1667         (swizzledBundleIdentifierWebBookmarksD):
1668         (defaultApplicationCacheDirectory):
1669         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
1670         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
1671         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
1672         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
1673
1674 2016-07-19  Keith Miller  <keith_miller@apple.com>
1675
1676         Test262 should have a file with the revision and url
1677         https://bugs.webkit.org/show_bug.cgi?id=159937
1678
1679         Reviewed by Mark Lam.
1680
1681         The import script should update the information from
1682         the path to the test262 repository it gets.
1683
1684         * Scripts/import-test262-tests:
1685
1686 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
1687
1688         Temporary workaround for iOS EWS failing after the fix for bug 159539.
1689         To be deleted once the root cause is found and addressed.
1690
1691         * EWSTools/start-queue-mac.sh:
1692
1693 2016-07-19  Frederic Wang  <fwang@igalia.com>
1694
1695         [win] Fixup the register name for STIX Math and Latin Modern Math
1696
1697         Unreviewed follow-up of r203406
1698
1699         * Scripts/webkitdirs.pm:
1700         (checkInstalledTools):
1701
1702 2016-07-19  Frederic Wang  <fwang@igalia.com>
1703
1704         [win] Update the list of MathML fonts
1705         https://bugs.webkit.org/show_bug.cgi?id=156838
1706
1707         The set of recommended math fonts is now described at
1708         https://trac.webkit.org/wiki/MathML/Fonts
1709         We update the Perl script to use the latest list of fonts.
1710
1711         Reviewed by Brent Fulgham.
1712
1713         * Scripts/webkitdirs.pm:
1714         (checkInstalledTools):
1715
1716 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
1717
1718         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
1719         https://bugs.webkit.org/show_bug.cgi?id=159342
1720
1721         Reviewed by Darin Adler.
1722
1723         Implement required functions in event sender.
1724
1725         * DumpRenderTree/PlatformWin.cmake:
1726         * DumpRenderTree/win/EventSender.cpp:
1727         (monitorWheelEvents): Added.
1728         (callAfterScrollingCompletes): Added.
1729
1730 2016-07-19  Youenn Fablet  <youenn@apple.com>
1731
1732         Add new aliases to http test server
1733         https://bugs.webkit.org/show_bug.cgi?id=159878
1734
1735         Reviewed by Darin Adler.
1736
1737         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
1738         Adding explicitly these links to perl script.
1739         Extracting default alias in an aliases.json file.
1740         Reading that file from python scripts to initialize aliases from that file.
1741
1742         Python script changes covered by unit tests and changed layout test.
1743
1744         * Scripts/webkitperl/httpd.pm:
1745         (getDefaultConfigForTestDirectory): Adding 3 new aliases
1746         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
1747         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1748         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1749         Adding -c directives for each alias.
1750         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1751         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
1752         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1753         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1754         Adding alias directive for each alias.
1755         (Lighttpd._prepare_config):
1756         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1757         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
1758         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
1759         layout tests directory.
1760         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1761         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
1762         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
1763
1764 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
1765
1766         EWS console logs doesn't go to log file
1767         https://bugs.webkit.org/show_bug.cgi?id=159539
1768         <rdar://problem/24464570>
1769
1770         Reviewed by David Kilzer.
1771
1772         * Scripts/webkitpy/common/system/logutils.py:
1773         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
1774         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
1775         to filesystem. It also supports passing MockFilesystem.
1776         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
1777         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
1778         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1779         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
1780         (_test_ews): Same.
1781         * Scripts/webkitpy/tool/commands/queues.py:
1782         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
1783         (AbstractQueue._log_directory): Using filesystem object instead of os.
1784         (AbstractQueue.queue_log_path): Same.
1785         (AbstractQueue.__init__): Passed host parameter.
1786         (PatchProcessingQueue.__init__): Same.
1787         (CommitQueue.__init__): Same.
1788         (AbstractReviewQueue.__init__): Same.
1789         (StyleQueue.__init__): Same.
1790         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1791         (TestCommitQueue): Passed MockHost() as host.
1792         (TestCommitQueue.__init__): Same.
1793         (TestQueue.__init__): Same.
1794         (TestReviewQueue.__init__): Same.
1795         (TestFeederQueue.__init__): Same.
1796         (AbstractPatchQueueTest.test_next_patch): Same.
1797         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1798         (test_commit_queue_failure): Same.
1799         (MockCommitQueueTask.results_from_patch_test_run): Same.
1800         (test_rollout_lands): Same.
1801         (test_non_valid_patch): Same.
1802         (test_auto_retry): Same.
1803         (test_style_queue_with_watch_list_exception): Same.
1804
1805 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
1806
1807         WTF::Lock should be fair eventually
1808         https://bugs.webkit.org/show_bug.cgi?id=159384
1809
1810         Reviewed by Geoffrey Garen.
1811
1812         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1813
1814 2016-07-17  Sam Weinig  <sam@webkit.org>
1815
1816         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
1817         <rdar://problem/26554137>
1818         https://bugs.webkit.org/show_bug.cgi?id=159856
1819
1820         Reviewed by Dan Bernstein.
1821
1822         * MiniBrowser/mac/WK2BrowserWindowController.m:
1823         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1824         Add basic window.open implementation.
1825
1826         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
1827         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
1828         to open a single non-web URL, all others are dropped.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
1833         Add API for the new SPI.
1834
1835 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1836
1837         [JSC] Enable test262 module tests
1838         https://bugs.webkit.org/show_bug.cgi?id=159854
1839
1840         Reviewed by Saam Barati.
1841
1842         Use --module-file instead.
1843
1844         * Scripts/run-jsc-stress-tests:
1845
1846 2016-07-16  Chris Dumez  <cdumez@apple.com>
1847
1848         Unreviewed, rolling out r203318.
1849
1850         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
1851         SunSpider)
1852
1853         Reverted changeset:
1854
1855         "[JSC] Change some parameters based on a random search"
1856         https://bugs.webkit.org/show_bug.cgi?id=158514
1857         http://trac.webkit.org/changeset/203318
1858
1859 2016-07-16  Chris Dumez  <cdumez@apple.com>
1860
1861         Add move constructor / assignment operator to ListHashSet
1862         https://bugs.webkit.org/show_bug.cgi?id=159837
1863
1864         Reviewed by Darin Adler.
1865
1866         Add API tests.
1867
1868         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1869         (TestWebKitAPI::TEST):
1870
1871 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
1872
1873         [JSC] Change some parameters based on a random search
1874         https://bugs.webkit.org/show_bug.cgi?id=158514
1875
1876         Reviewed by Saam Barati.
1877
1878         * Scripts/run-jsc-stress-tests:
1879
1880 2016-07-15  Jon Davis  <jond@apple.com>
1881
1882         Changed the start page URL for WebKit Nightly builds.
1883         https://bugs.webkit.org/show_bug.cgi?id=159816
1884
1885         Reviewed by Timothy Hatcher.
1886
1887         * WebKitLauncher/start.html:
1888
1889 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
1890
1891         Uninitialized variable in DIBPixelData can cause a dangerous memory write
1892         https://bugs.webkit.org/show_bug.cgi?id=159414
1893
1894         Reviewed by Brent Fulgham.
1895
1896         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
1897         when the HDC parameter is invalid.
1898
1899         * TestWebKitAPI/PlatformWin.cmake:
1900         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
1901         (TestWebKitAPI::TEST):
1902
1903 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1904
1905         [GTK] Add basic tabs support to MiniBrowser
1906         https://bugs.webkit.org/show_bug.cgi?id=159803
1907
1908         Reviewed by Sergio Villar Senin.
1909
1910         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
1911         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
1912
1913         * MiniBrowser/gtk/BrowserTab.c: Added.
1914         (titleChanged):
1915         (isLoadingChanged):
1916         (decidePolicy):
1917         (removeChildIfInfoBar):
1918         (loadChanged):
1919         (createInfoBarQuestionMessage):
1920         (tlsErrorsDialogResponse):
1921         (loadFailedWithTLSerrors):
1922         (permissionRequestDialogResponse):
1923         (decidePermissionRequest):
1924         (colorChooserRGBAChanged):
1925         (popoverColorClosed):
1926         (colorChooserRequestFinished):
1927         (runColorChooserCallback):
1928         (inspectorOpenedInWindow):
1929         (inspectorClosed):
1930         (browserTabSetProperty):
1931         (browserTabFinalize):
1932         (browser_tab_init):
1933         (browserTabConstructed):
1934         (browser_tab_class_init):
1935         (getInternalURI):
1936         (browser_tab_new):
1937         (browser_tab_get_web_view):
1938         (browser_tab_load_uri):
1939         (browser_tab_get_title_widget):
1940         (browser_tab_set_status_text):
1941         (browser_tab_toggle_inspector):
1942         (browser_tab_start_search):
1943         (browser_tab_stop_search):
1944         (browser_tab_add_accelerators):
1945         (fullScreenMessageTimeoutCallback):
1946         (browser_tab_enter_fullscreen):
1947         (browser_tab_leave_fullscreen):
1948         * MiniBrowser/gtk/BrowserTab.h: Added.
1949         * MiniBrowser/gtk/BrowserWindow.c:
1950         (getExternalURI):
1951         (browserWindowSetStatusText):
1952         (reloadOrStopCallback):
1953         (goBackCallback):
1954         (goForwardCallback):
1955         (settingsCallback):
1956         (webViewURIChanged):
1957         (browserWindowHistoryItemActivated):
1958         (browserWindowUpdateNavigationActions):
1959         (webViewCreate):
1960         (webViewEnterFullScreen):
1961         (webViewLeaveFullScreen):
1962         (webViewDecidePolicy):
1963         (browserWindowCanZoomIn):
1964         (browserWindowCanZoomOut):
1965         (browserWindowZoomIn):
1966         (browserWindowZoomOut):
1967         (scrollEventCallback):
1968         (faviconChanged):
1969         (webViewIsLoadingChanged):
1970         (defaultZoomCallback):
1971         (searchCallback):
1972         (newTabCallback):
1973         (toggleWebInspector):
1974         (reloadPage):
1975         (reloadPageIgnoringCache):
1976         (stopPageLoad):
1977         (loadHomePage):
1978         (editingCommandCallback):
1979         (insertImageCommandCallback):
1980         (insertLinkCommandCallback):
1981         (browserWindowSetupEditorToolbar):
1982         (browserWindowSwitchTab):
1983         (browserWindowTabAddedOrRemoved):
1984         (browser_window_init):
1985         (browserWindowConstructed):
1986         (browserWindowSaveSession):
1987         (browserWindowDeleteEvent):
1988         (browser_window_new):
1989         (browser_window_append_view):
1990         (browser_window_load_uri):
1991         (browser_window_load_session):
1992         (browser_window_set_background_color):
1993         (resetStatusText): Deleted.
1994         (activateUriEntryCallback): Deleted.
1995         (webViewTitleChanged): Deleted.
1996         (resetEntryProgress): Deleted.
1997         (browserWindowCreateBackForwardMenu): Deleted.
1998         (webViewReadyToShow): Deleted.
1999         (webViewLoadFailed): Deleted.
2000         (webViewMouseTargetChanged): Deleted.
2001         (browserWindowUpdateZoomActions): Deleted.
2002         (webViewZoomLevelChanged): Deleted.
2003         (updateUriEntryIcon): Deleted.
2004         (zoomInCallback): Deleted.
2005         (zoomOutCallback): Deleted.
2006         (toggleFullScreen): Deleted.
2007         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2008         (browserWindowFinalize): Deleted.
2009         (browser_window_class_init): Deleted.
2010         * MiniBrowser/gtk/BrowserWindow.h:
2011         * MiniBrowser/gtk/CMakeLists.txt:
2012         * MiniBrowser/gtk/main.c:
2013         (createBrowserTab):
2014         (aboutURISchemeRequestCallback):
2015         (main):
2016         (parseBackgroundColor): Deleted.
2017
2018 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2019
2020         Allow RefPtrs of const RefCounted types
2021         https://bugs.webkit.org/show_bug.cgi?id=158269
2022
2023         Reviewed by Anders Carlsson.
2024
2025         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2026         (TestWebKitAPI::TEST):
2027         (TestWebKitAPI::ConstRefCounted::create):
2028         (TestWebKitAPI::returnConstRefCountedRef):
2029         (TestWebKitAPI::returnRefCountedRef):
2030
2031 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2032
2033         Test WTF.StringViewIterators is crashing since r203119
2034         https://bugs.webkit.org/show_bug.cgi?id=159710
2035
2036         Reviewed by Darin Adler.
2037
2038         There are two problems in the test case added in r203119. First is that it's testing
2039         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2040         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2041         const reference to the string view member of the deleted CodePoints object.
2042
2043         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2044         (TestWebKitAPI::TEST):
2045
2046 2016-07-13  Daniel Bates  <dabates@apple.com>
2047
2048         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2049         https://bugs.webkit.org/show_bug.cgi?id=159738
2050         <rdar://problem/27304649>
2051
2052         Reviewed by Dan Bernstein.
2053
2054         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2055         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2056         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2057         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2058
2059         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2060         * WebKitTestRunner/ios/TestControllerIOS.mm:
2061         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2062         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2063
2064 2016-07-13  Beth Dakin  <bdakin@apple.com>
2065
2066         Attempted build fix.
2067
2068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2069
2070 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2071
2072         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2073         https://bugs.webkit.org/show_bug.cgi?id=159686
2074
2075         Reviewed by Chris Dumez.
2076
2077         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2078
2079         * WebKitTestRunner/TestController.cpp:
2080         (WTR::runOpenPanel):
2081         (WTR::TestController::createOtherPage):
2082         (WTR::TestController::createWebViewWithOptions):
2083
2084 2016-07-13  Beth Dakin  <bdakin@apple.com>
2085
2086         Add more candidate tests
2087         https://bugs.webkit.org/show_bug.cgi?id=159730
2088
2089         Reviewed by Tim Horton.
2090
2091         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2092         two new tests to that file.
2093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2094         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2095         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2096         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2097         (TestWebKitAPI::TEST):
2098         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2099
2100 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2101
2102         AX: [ATK] spinbutton-crash.html fails
2103         https://bugs.webkit.org/show_bug.cgi?id=159723
2104
2105         Reviewed by Chris Fleizach.
2106
2107         Implement support for AXDecrementButton and AXIncrementButton in
2108         ATK's AccessibilityUIElement::uiElementAttributeValue().
2109
2110         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2111         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2112
2113 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2114
2115         [EFL] [GTK] Enable back crypto subtle on development builds.
2116         https://bugs.webkit.org/show_bug.cgi?id=159260
2117
2118         Reviewed by Carlos Garcia Campos.
2119
2120         * Scripts/webkitperl/FeatureList.pm:
2121
2122 2016-07-12  Mark Lam  <mark.lam@apple.com>
2123
2124         We should use different stack limits for stack checks from JS and host code.
2125         https://bugs.webkit.org/show_bug.cgi?id=159442
2126         <rdar://problem/26889188>
2127
2128         Reviewed by Geoffrey Garen.
2129
2130         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2131         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2132         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2133         order to keep the js/regress-139548.html test happy with this patch.
2134
2135         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2136         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2137
2138         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2139         (-[LTRelayController _environmentVariables]):
2140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2141         (main):
2142
2143 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2144
2145         platformUserPreferredLanguages on Mac should not try to put the region into the language
2146         https://bugs.webkit.org/show_bug.cgi?id=159693
2147
2148         Rubber stamped by Alexey Proskuryakov.
2149         
2150         Revert the test change in r200105.
2151
2152         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2153         (TestWebKitAPI::languageForSystemLanguage):
2154
2155 2016-07-12  Chris Dumez  <cdumez@apple.com>
2156
2157         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2158         https://bugs.webkit.org/show_bug.cgi?id=159663
2159         <rdar://problem/18995873>
2160
2161         Reviewed by Benjamin Poulain.
2162
2163         Add API test coverage.
2164
2165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2166         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2167         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2169         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2170         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2171         (TEST):
2172
2173 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2174
2175         Relax ordering requirements on StringView::CodePoints iterator
2176         https://bugs.webkit.org/show_bug.cgi?id=159609
2177
2178         Reviewed by Darin Adler.
2179
2180         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2181         (TestWebKitAPI::TEST):
2182
2183 2016-07-12  Youenn Fablet  <youenn@apple.com>
2184
2185         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2186         https://bugs.webkit.org/show_bug.cgi?id=159564
2187
2188         Reviewed by Brian Burg.
2189
2190         * Scripts/webkitpy/codegen/main.py:
2191         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2192
2193 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2194
2195         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2196         https://bugs.webkit.org/show_bug.cgi?id=159671
2197
2198         Reviewed by Csaba Osztrogonác.
2199
2200         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2201         https://bugs.webkit.org/show_bug.cgi?id=89235
2202
2203         So this guard can be removed in build scripts.
2204
2205         * Scripts/webkitperl/FeatureList.pm:
2206         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2207
2208 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2209
2210         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2211         https://bugs.webkit.org/show_bug.cgi?id=159652
2212
2213         Reviewed by Daniel Bates.
2214
2215         * Scripts/webkitpy/common/checkout/scm/svn.py:
2216         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2217
2218 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2219
2220         Implement grapheme cluster iterator on StringView
2221         https://bugs.webkit.org/show_bug.cgi?id=159598
2222
2223         Reviewed by Anders Carlsson.
2224
2225         This is in preparation for honoring the second argument to FontFaceSet.load().
2226
2227         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2228         (TestWebKitAPI::compareLoopIterations):
2229         (TestWebKitAPI::TEST):
2230
2231 2016-07-11  Nan Wang  <n_wang@apple.com>
2232
2233         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2234         https://bugs.webkit.org/show_bug.cgi?id=158364
2235
2236         Reviewed by Anders Carlsson.
2237
2238         Added a function in TestRunner so that we can toggle the ignoring viewport
2239         scale limits setting. Also added a test option for that in order to change the 
2240         configuration of the webview in test.
2241
2242         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2243         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2244         (WTR::TestRunner::setNavigationGesturesEnabled):
2245         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2246         (WTR::nextUIScriptCallbackID):
2247         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2248         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2249         * WebKitTestRunner/TestController.cpp:
2250         (WTR::TestController::resetStateToConsistentValues):
2251         (WTR::updateTestOptionsFromTestHeader):
2252         (WTR::TestController::setNavigationGesturesEnabled):
2253         (WTR::TestController::setIgnoresViewportScaleLimits):
2254         (WTR::TestController::platformWillRunTest):
2255         * WebKitTestRunner/TestController.h:
2256         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2257         * WebKitTestRunner/TestInvocation.cpp:
2258         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2259         * WebKitTestRunner/TestOptions.h:
2260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2261         (WTR::TestController::platformCreateWebView):
2262
2263 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2264
2265         [GTK] install-dependencies should not install packages built by jhbuild.
2266         https://bugs.webkit.org/show_bug.cgi?id=159628
2267
2268         Reviewed by Michael Catanzaro.
2269
2270         * gtk/install-dependencies:
2271         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2272
2273 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2274
2275         System proxy settings not used when building deps with jhbuild
2276         https://bugs.webkit.org/show_bug.cgi?id=159567
2277
2278         Reviewed by Michael Catanzaro.
2279
2280         This adds the gsettings-desktop-schemas-devel build dep to enable
2281         the libgiognomeproxy.so gio module in glib-networking, which uses
2282         GSettings on org.gnome.system.proxy.
2283         This is needed to query system proxy settings for Gnome desktops.
2284
2285         dconf can be manually added to jhbuild to build the
2286         libdconfsettings.so gio module for GSettings, so that
2287         libgiognomeproxy.so can access system settings.
2288           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2289
2290         As an alternative to dconf settings, this commit also adds the
2291         libproxy-devel build dep to enable the libgiolibproxy.so module in
2292         glib-networking (suggested by Fujii Hironori).
2293
2294         It is useful to read proxy settings from environment variables.
2295         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2296         environment variable to force using the envvar module in libproxy.
2297
2298         * gtk/install-dependencies:
2299
2300 2016-07-11  Mark Lam  <mark.lam@apple.com>
2301
2302         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2303         https://bugs.webkit.org/show_bug.cgi?id=159524
2304
2305         Reviewed by Michael Saboff.
2306
2307         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2308         Also fixed up some tests to behave better to work with this new limit.  This
2309         should make stack overflow tests complete sooner.
2310
2311         * Scripts/run-jsc-stress-tests:
2312         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2313         (main):
2314
2315 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2316
2317         [GTK] Whitespace fixes in install-dependencies script
2318
2319         Unreviewed.
2320
2321         * gtk/install-dependencies:
2322
2323 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2324
2325         [GTK] Install missing Fedora dependencies
2326
2327         Unreviewed.
2328
2329         * gtk/install-dependencies:
2330
2331 2016-07-09  Dan Bernstein  <mitz@apple.com>
2332
2333         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2334         https://bugs.webkit.org/show_bug.cgi?id=159600
2335
2336         Reviewed by Daniel Bates.
2337
2338         * Scripts/git-add-reviewer:
2339         Added the -s|--rubber-stamp option.
2340         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2341           new option.
2342
2343 2016-07-08  Andy Estes  <aestes@apple.com>
2344
2345         [Content Filtering] Load blocked pages more like other error pages are loaded
2346         https://bugs.webkit.org/show_bug.cgi?id=159485
2347         <rdar://problem/26014076>
2348
2349         Reviewed by Brady Eidson.
2350
2351         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2352         to a content filtering provisional navigation failure is ignored in preference of
2353         ContentFilter's own error page.
2354
2355         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2357         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2358         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2359         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2360         (loadAlternateTest):
2361         (TEST):
2362         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2363         (-[MockContentFilterEnabler initWithCoder:]):
2364         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2365         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2366         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2367         (TestWebKitAPI::loadAlternateTest):
2368         (TestWebKitAPI::TEST):
2369
2370 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2371
2372         Unreviewed, rolling out r202944.
2373         https://bugs.webkit.org/show_bug.cgi?id=159570
2374
2375         caused some tests to crash under GuardMalloc (Requested by
2376         estes on #webkit).
2377
2378         Reverted changeset:
2379
2380         "[Content Filtering] Load blocked pages more like other error
2381         pages are loaded"
2382         https://bugs.webkit.org/show_bug.cgi?id=159485
2383         http://trac.webkit.org/changeset/202944
2384
2385 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2386
2387         Remove mrobinson from the MathML watchlist
2388         https://bugs.webkit.org/show_bug.cgi?id=159559
2389
2390         Reviewed by Philippe Normand.
2391
2392         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2393
2394 2016-07-08  Brady Eidson  <beidson@apple.com>
2395
2396         Clearing LocalStorage doesn't also delete -wal and -shm files.
2397         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2398
2399         Reviewed by Brent Fulgham.
2400         Also helpfully picked over by Andy "Never Forgets" Estes.
2401
2402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2403         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2404         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2405
2406 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2407
2408         Removed Qt leftovers from Tools.
2409         https://bugs.webkit.org/show_bug.cgi?id=159557
2410
2411         Reviewed by Csaba Osztrogonác.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2414         Removed 'qt' platform config.
2415         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2416         Deleted non-functional e-mail address.
2417
2418 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2419
2420         Unreviewed, rolling out r202967.
2421         https://bugs.webkit.org/show_bug.cgi?id=159556
2422
2423         This patch caused crashes in https tests on Windows (Requested
2424         by perarne on #webkit).
2425
2426         Reverted changeset:
2427
2428         "[Win] The test http/tests/security/contentSecurityPolicy
2429         /upgrade-insecure-requests/basic-upgrade.https.html is
2430         failing."
2431         https://bugs.webkit.org/show_bug.cgi?id=159510
2432         http://trac.webkit.org/changeset/202967
2433
2434 2016-07-08  Youenn Fablet  <youenn@apple.com>
2435
2436         Generate WebCore builtin wrapper files
2437         https://bugs.webkit.org/show_bug.cgi?id=159461
2438
2439         Reviewed by Brian Burg.
2440
2441         * Scripts/webkitpy/codegen/main.py:
2442         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2443         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2444
2445 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2446
2447         [EFL] Fix build when media-stream is enabled.
2448         https://bugs.webkit.org/show_bug.cgi?id=159206
2449
2450         Bump up the openwebrtc to find the correct package.
2451
2452         Reviewed by Gyuyoung Kim.
2453
2454         * efl/jhbuild.modules:
2455         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2456
2457 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2458
2459         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2460         https://bugs.webkit.org/show_bug.cgi?id=159510
2461
2462         Reviewed by Brent Fulgham.
2463
2464         Allow any https certificate when running tests.
2465
2466         * DumpRenderTree/win/DumpRenderTree.cpp:
2467         (runTest):
2468
2469 2016-07-07  Beth Dakin  <bdakin@apple.com>
2470
2471         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2472         https://bugs.webkit.org/show_bug.cgi?id=159532
2473         -and corresponding-
2474         rdar://problem/27177179
2475
2476         Reviewed by Tim Horton.
2477
2478         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2479         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2480
2481 2016-07-07  Andy Estes  <aestes@apple.com>
2482
2483         [Content Filtering] Load blocked pages more like other error pages are loaded
2484         https://bugs.webkit.org/show_bug.cgi?id=159485
2485         <rdar://problem/26014076>
2486
2487         Reviewed by Brady Eidson.
2488
2489         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2490         to a content filtering provisional navigation failure is ignored in preference of
2491         ContentFilter's own error page.
2492
2493         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2495         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2496         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2497         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2498         (loadAlternateTest):
2499         (TEST):
2500         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2501         (-[MockContentFilterEnabler initWithCoder:]):
2502         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2503         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2504         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2505         (TestWebKitAPI::loadAlternateTest):
2506         (TestWebKitAPI::TEST):
2507
2508 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2509
2510         Unreviewed: add myself to the reviewers list.
2511
2512         * Scripts/webkitpy/common/config/contributors.json:
2513
2514 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2515
2516         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2517         https://bugs.webkit.org/show_bug.cgi?id=159509
2518
2519         Reviewed by Alex Christensen.
2520
2521         We should always insert the url in the url map when identifierForInitialRequest
2522         is called. Otherwise we can end up with identifiers not having an entry in the
2523         url map when urls are written to the test output file. 
2524
2525         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2526         (ResourceLoadDelegate::identifierForInitialRequest):
2527
2528 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2529
2530         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2531         https://bugs.webkit.org/show_bug.cgi?id=159498
2532         <rdar://problem/26719903>
2533
2534         Reviewed by Sam Weinig.
2535
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2538         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2539         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2540         (expectLinkCount):
2541         (TEST):
2542         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2543         when deciding what to linkify.
2544
2545 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2546
2547         Build fix - work around rdar://problem/27196668.
2548
2549         * LayoutTestRelay/Configurations/Base.xcconfig:
2550
2551 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2552
2553         Enhance Windows DRT implementation to support platform scroll wheel events.
2554         https://bugs.webkit.org/show_bug.cgi?id=36002
2555
2556         Reviewed by Brent Fulgham.
2557
2558         Implement function continuousMouseScrollBy in Windows event sender.
2559
2560         * DumpRenderTree/win/EventSender.cpp:
2561         (mouseScrollBy):
2562         (continuousMouseScrollBy):
2563
2564 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
2565
2566         [Sierra] Rebaseline tests to use un-mocked system font metrics
2567         https://bugs.webkit.org/show_bug.cgi?id=159311
2568         <rdar://problem/24138411>
2569
2570         Reviewed in person by Alexey Proskuryakov.
2571
2572         Stop mocking the system font on Sierra.
2573
2574         * DumpRenderTree/mac/DumpRenderTree.mm:
2575         (setDefaultsToConsistentValuesForTesting):
2576         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2577         (WTR::InjectedBundle::platformInitialize):
2578
2579 2016-07-05  Brady Eidson  <beidson@apple.com>
2580
2581         Database process crashes deleting a corrupt SQLite database file (null deref).
2582         https://bugs.webkit.org/show_bug.cgi?id=155506.
2583
2584         Reviewed by Alex Christensen.
2585
2586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2587         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
2588         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
2589         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
2590         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
2591         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
2592
2593 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
2594
2595         run-webkit-tests should print more complete baseline search paths
2596         https://bugs.webkit.org/show_bug.cgi?id=159354
2597
2598         Reviewed by Daniel Bates.
2599
2600         run-webkit-tests used to only print directory names in baseline search paths.
2601         This was ok in basic usage, but quickly got confusing when using
2602         --additional-platform-directory flags.
2603
2604         * Scripts/webkitpy/layout_tests/views/printing.py:
2605         (Printer.print_config):
2606         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2607         (Testprinter.test_print_config):
2608         (Testprinter.test_print_one_line_summary):
2609
2610 2016-07-04  Brady Eidson  <beidson@apple.com>
2611
2612         WebProcesses don't handle DatabaseProcess going away uncleanly..
2613         https://bugs.webkit.org/show_bug.cgi?id=159371
2614
2615         Reviewed by Alex Christensen.
2616
2617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2618         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
2619         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
2620         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
2621         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2622
2623 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2624
2625         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
2626         https://bugs.webkit.org/show_bug.cgi?id=158141
2627
2628         Rubber-stamped by Michael Catanzaro.
2629
2630         Instead of checking for an specific Ubuntu version, query the apt
2631         database to see which version of PHP is available.
2632
2633         * efl/install-dependencies:
2634         * gtk/install-dependencies:
2635
2636 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2637
2638         webkit-patch failure-reason always raises TypeError
2639         https://bugs.webkit.org/show_bug.cgi?id=159394
2640
2641         Reviewed by Benjamin Poulain.
2642
2643         In r170637 (Bug 133067), the first and second arguments of
2644         pluralize were swapped.
2645
2646         * Scripts/webkitpy/tool/commands/queries.py:
2647         (FailureReason._builder_to_explain): Swap the first and second
2648         arguments of pluralize.
2649
2650 2016-07-02  Youenn Fablet  <youennf@gmail.com>
2651
2652         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
2653         https://bugs.webkit.org/show_bug.cgi?id=152486
2654
2655         Reviewed by Daniel Bates.
2656
2657         Add launch of web-platform-tests server by run-webkit-httpd.
2658         Add two options to disable starting httpd and web-platform-tests servers.
2659
2660         * Scripts/run-webkit-httpd:
2661         (parse_args):
2662         (main):
2663
2664 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
2665
2666         REGRESSION(r189668): Notification tests are flakey
2667         https://bugs.webkit.org/show_bug.cgi?id=159375
2668         <rdar://problem/22760990>
2669
2670         Reviewed by Alexey Proskuryakov.
2671
2672         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
2673         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
2674         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
2675         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
2676
2677         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
2678         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
2679         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
2680         global notification ID mapping, causing the wrong notification to be investigated.
2681
2682         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
2683         manually perform this same mapping. Luckily, this object already receives callbacks every time a
2684         notification is created or destroyed. However, because this object is implemented outside WebKit,
2685         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
2686         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
2687         WebNotificationProvider can properly map between the different IDs.
2688
2689         * WebKitTestRunner/TestController.cpp:
2690         (WTR::TestController::runTestingServerLoop):
2691         (WTR::TestController::simulateWebNotificationClick):
2692         * WebKitTestRunner/WebNotificationProvider.cpp:
2693         (WTR::WebNotificationProvider::showWebNotification):
2694         (WTR::removeGlobalIDFromIDMap):
2695         (WTR::WebNotificationProvider::closeWebNotification):
2696         (WTR::WebNotificationProvider::removeNotificationManager):
2697         (WTR::WebNotificationProvider::simulateWebNotificationClick):
2698         (WTR::WebNotificationProvider::reset):
2699         * WebKitTestRunner/WebNotificationProvider.h:
2700
2701 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
2702
2703         Simplify LayoutTestRelay
2704         https://bugs.webkit.org/show_bug.cgi?id=159353
2705
2706         Reviewed by Daniel Bates.
2707
2708         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
2709         by name and runtime makes no sense.
2710         2. Removed code to create devices, webkitpy always does this in advance.
2711         3. Don't create copies of testing apps - we can install the same one into
2712         each simulator, now that we don't run multiple tester processes in a single simulator.
2713         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
2714         5. Removed code that kept testing apps alive in the background.
2715         6. Slightly updated coding style in functions that I touched.
2716
2717         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2718         Updated for what we acually use at this point.
2719
2720         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2721         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2722         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
2723         (-[LTRelayController ipcIdentifier]):
2724         (-[LTRelayController processName]):
2725         (-[LTRelayController didReceiveStdoutData:]):
2726         (-[LTRelayController didCrashWithMessage:]):
2727         (-[LTRelayController installApp]):
2728         (-[LTRelayController _environmentVariables]):
2729         (-[LTRelayController launchApp]):
2730         (-[LTRelayController start]):
2731         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
2732         (-[LTRelayController uniqueAppPath]): Deleted.
2733         (-[LTRelayController uniqueAppURL]): Deleted.
2734         (-[LTRelayController uniqueAppIdentifier]): Deleted.
2735         (-[LTRelayController createUniqueApp]): Deleted.
2736         * LayoutTestRelay/LayoutTestRelay/main.m:
2737         (usage):
2738         (getRequiredStringArgument):
2739         (main):
2740         (getTestingSimDevice): Deleted.
2741         * Scripts/webkitpy/port/driver.py:
2742         (IOSSimulatorDriver.cmd_line):
2743         * WebKitTestRunner/ios/TestControllerIOS.mm:
2744         (WTR::TestController::platformInitialize):
2745         * WebKitTestRunner/ios/mainIOS.mm:
2746         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2747         * DumpRenderTree/mac/DumpRenderTree.mm:
2748         (dumpRenderTree):
2749         (-[DumpRenderTree applicationDidEnterBackground:]):
2750
2751 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
2752
2753         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
2754         https://bugs.webkit.org/show_bug.cgi?id=159344
2755
2756         Reviewed by Alex Christensen.
2757
2758         * DumpRenderTree/CMakeLists.txt:
2759
2760 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2761
2762         Add a runtime flag for DOM iterators
2763         https://bugs.webkit.org/show_bug.cgi?id=159300
2764
2765         Reviewed by Alex Christensen.
2766
2767         * DumpRenderTree/mac/DumpRenderTree.mm:
2768         (resetWebPreferencesToConsistentValues):
2769         * DumpRenderTree/win/DumpRenderTree.cpp:
2770         (resetWebPreferencesToConsistentValues):
2771         * Scripts/webkitperl/FeatureList.pm:
2772         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2773         (WTR::InjectedBundle::beginTesting):
2774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2775         (WTR::TestRunner::setDOMIteratorEnabled):
2776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2777
2778 2016-06-30  Tina Liu  <iting_liu@apple.com>
2779
2780         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
2781         https://bugs.webkit.org/show_bug.cgi?id=159326
2782
2783         Reviewed by Brady Eidson.
2784
2785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2786         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
2787         (TestWebKitAPI::didFinishLoadForFrame):
2788         (TestWebKitAPI::didChangeBackForwardListForPage):
2789         (TestWebKitAPI::setPageLoaderClient):
2790         Set the page loader client and register for didFinishLoadForFrame and
2791         didChangeBackForwardList callbacks.
2792         (TestWebKitAPI::createSessionStateData):
2793         Load a webpage ("simple.html") and return the session state for this page.
2794         (TestWebKitAPI::TEST):
2795         Restore the page session state with that of "simple.html" without navigation.
2796         Verify that the committed URL is NULL since there's no navigation involved.
2797         Verify that the current item in the back forward list, which should be what
2798         we restored from the session state, has the expected URL.
2799
2800 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
2801
2802         Generators violate bytecode liveness validation
2803         https://bugs.webkit.org/show_bug.cgi?id=159279
2804
2805         Reviewed by Yusuke Suzuki.
2806         
2807         Add Basic to our test harness.
2808
2809         * Scripts/run-javascriptcore-tests:
2810         (runJSCStressTests):
2811
2812 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
2813
2814         [Win][Debug] Assertion fails in TestWTF.
2815         https://bugs.webkit.org/show_bug.cgi?id=159299
2816
2817         Reviewed by Alex Christensen.
2818
2819         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
2820         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
2821         the assertion failure. Since the variable is actually used, there is no need to use the
2822         UNUSED_PARAM macro.
2823
2824         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
2825         (TestWebKitAPI::TEST):
2826
2827 2016-06-30  Youenn Fablet  <youennf@gmail.com>
2828
2829         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
2830         https://bugs.webkit.org/show_bug.cgi?id=159166
2831         <rdar://problem/27051759>
2832
2833         Reviewed by Alexey Proskuryakov.
2834
2835         Setting the certificate directory to the copied config.json.
2836
2837         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2838         (WebPlatformTestServer._copy_webkit_test_files):
2839
2840 2016-06-29  Mark Lam  <mark.lam@apple.com>
2841
2842         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
2843         https://bugs.webkit.org/show_bug.cgi?id=159274
2844
2845         Reviewed by Keith Miller.
2846
2847         * DumpRenderTree/mac/DumpRenderTree.mm:
2848         (DumpRenderTreeMain):
2849
2850 2016-06-29  Alex Christensen  <achristensen@webkit.org>
2851
2852         WKWebView should ask WKNavigationDelegate about bad ssl certificates
2853         https://bugs.webkit.org/show_bug.cgi?id=159176
2854
2855         Reviewed by Sam Weinig.
2856
2857         * MiniBrowser/mac/WK2BrowserWindowController.m:
2858         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2859         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
2860         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2861
2862 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2863
2864         [GTK] Add missing install dependency after r202619
2865         https://bugs.webkit.org/show_bug.cgi?id=156716
2866
2867         Unreviewed.
2868
2869         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
2870
2871 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2872
2873         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
2874         https://bugs.webkit.org/show_bug.cgi?id=156716
2875
2876         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
2877
2878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
2879         (parse_args):
2880         * Scripts/webkitpy/port/gtk.py:
2881         (GtkPort.__init__):
2882         (GtkPort._driver_class):
2883         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
2884         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
2885         platform directory for storing the wayland specific layout test results and expectations for ${port}.
2886         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
2887         test expectations file on the GTK port when running the tests with the --wayland command line switch.
2888         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
2889         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
2890         (WestonDriver.check_driver):
2891         (WestonDriver.__init__):
2892         (WestonDriver._start):
2893         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
2894         (WestonXvfbDriverDisplayTest):
2895         (WestonXvfbDriverDisplayTest.__init__):
2896         (WestonXvfbDriverDisplayTest._xvfb_run):
2897         (WestonDriverTest.make_driver):
2898         (WestonDriverTest.test_start):
2899         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
2900         or to satisfy the pkg-config check of the new added modules in JHBuild.
2901         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
2902         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
2903         provided by the system are already new enough.
2904         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
2905         It was the only way to get the software EGL rasterizer working without depending on user drivers.
2906         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
2907         feature to avoid building libdrm when the one provided by the system is new enough.
2908         * gtk/jhbuildrc:
2909         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
2910         Xorg had no support for searching the DRI drivers on a custom path at runtime.
2911         This patch implements support for that reusing the same variable that we use with Mesa to set the
2912         custom path for the DRI drivers path.
2913
2914 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
2915
2916         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
2917         https://bugs.webkit.org/show_bug.cgi?id=159256
2918
2919         Reviewed by Philippe Normand.
2920
2921         We need the last fixes in the repository to make the scream queue
2922         work with apprtc.
2923
2924         * gtk/jhbuild.modules:
2925
2926 2016-06-28  Commit Queue  <commit-queue@webkit.org>
2927
2928         Unreviewed, rolling out r202580.
2929         https://bugs.webkit.org/show_bug.cgi?id=159245
2930
2931         Caused all WKTR tests to fail on GuardMalloc and Production
2932         only for unknown reasons, investigating offline. (Requested by
2933         brrian on #webkit).
2934
2935         Reverted changeset:
2936
2937         "RunLoop::Timer should use constructor templates instead of
2938         class templates"
2939         https://bugs.webkit.org/show_bug.cgi?id=159153
2940         http://trac.webkit.org/changeset/202580
2941
2942 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2943
2944         Use a regex to check if a test step is for JavaScriptCore
2945         https://bugs.webkit.org/show_bug.cgi?id=159224
2946
2947         Reviewed by Geoffrey Garen.
2948
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2950         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2952         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2954         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
2955
2956 2016-06-28  Michael Saboff  <msaboff@apple.com>
2957
2958         btjs no longer accepts optional frame count argument
2959         https://bugs.webkit.org/show_bug.cgi?id=159235
2960
2961         Reviewed by Saam Barati.
2962
2963         Fix the detection of optional backtrace-depth parameter to use the length
2964         of the command.
2965
2966         * lldb/lldb_webkit.py:
2967         (btjs):
2968
2969 2016-06-28  Jon Lee  <jonlee@apple.com>
2970
2971         Update animometer.plan
2972
2973         Rubber-stamped by Said Abou-Hallawa.
2974
2975         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
2976
2977 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
2978
2979         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
2980
2981         * Scripts/run-javascriptcore-tests:
2982         (runJSCStressTests):
2983
2984 2016-06-28  Brian Burg  <bburg@apple.com>
2985
2986         RunLoop::Timer should use constructor templates instead of class templates
2987         https://bugs.webkit.org/show_bug.cgi?id=159153
2988
2989         Reviewed by Alex Christensen.
2990
2991         Remove the RunLoop::Timer class template argument, and pass its constructor
2992         a reference to `this` instead of a pointer to `this`.
2993
2994         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2995         (WTR::TestRunner::TestRunner):
2996         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2997         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2998         (TestWebKitAPI::TEST):
2999
3000 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3001
3002         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3003         https://bugs.webkit.org/show_bug.cgi?id=159199
3004
3005         Reviewed by Alexey Proskuryakov.
3006
3007         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3008
3009         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3010         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3011         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3012         an input element getting automatically focused on Mac.
3013
3014 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3015
3016         [Win] Custom elements tests are failing.
3017         https://bugs.webkit.org/show_bug.cgi?id=159139
3018
3019         Reviewed by Alex Christensen.
3020
3021         Enable custom element API when running tests.
3022
3023         * DumpRenderTree/win/DumpRenderTree.cpp:
3024         (resetWebPreferencesToConsistentValues):
3025
3026 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3027
3028         Test commit. Please ignore.
3029         
3030 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3031
3032         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3033         https://bugs.webkit.org/show_bug.cgi?id=155073
3034
3035         Reviewed by Daniel Bates.
3036
3037         * Scripts/webkitperl/FeatureList.pm:
3038
3039 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3040
3041         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3042         https://bugs.webkit.org/show_bug.cgi?id=159077
3043
3044         Reviewed by Tim Horton.
3045
3046         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3047
3048         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3049         which is necessary for UI-side compositing.
3050
3051         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3052         seems to happen for some tests that call window.resizeTo().
3053
3054         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3055         (WTR::InjectedBundlePage::dump): Deleted.
3056         * WebKitTestRunner/TestInvocation.cpp:
3057         (WTR::TestInvocation::dumpResults):
3058         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3059         (WTR::createCGContextFromImage):
3060         (WTR::computeMD5HashStringForContext):
3061         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3062         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3063         (WTR::PlatformWebView::windowSnapshotImage):
3064
3065 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3066
3067         [EFL] Support to build on Debian linux
3068         https://bugs.webkit.org/show_bug.cgi?id=159123
3069
3070         Reviewed by Antonio Gomes.
3071
3072         * efl/install-dependencies: Install libgnutls28-dev.
3073
3074 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3075
3076         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3077         https://bugs.webkit.org/show_bug.cgi?id=159071
3078
3079         Reviewed by Brady Eidson.
3080
3081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3083         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3084         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3085         (WTR::TestRunner::setAuthenticationUsername):
3086         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3087         * WebKitTestRunner/TestController.cpp:
3088         (WTR::TestController::TestController):
3089         (WTR::TestController::resetStateToConsistentValues):
3090         (WTR::TestController::didFinishNavigation):
3091         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3092         (WTR::TestController::didReceiveAuthenticationChallenge):
3093         (WTR::TestController::didCommitNavigation):
3094         * WebKitTestRunner/TestController.h:
3095         (WTR::TestController::setBlockAllPlugins):
3096         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3097         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3098         (WTR::TestController::isCurrentInvocation):
3099         * WebKitTestRunner/TestInvocation.cpp:
3100         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3101         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3102
3103 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3104
3105         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3106         https://bugs.webkit.org/show_bug.cgi?id=159129
3107
3108         Reviewed by Alex Christensen.
3109
3110         Implement the function mouseScrollBy in the Windows event sender.
3111
3112         * DumpRenderTree/win/EventSender.cpp:
3113         (mouseScrollBy):
3114         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3115
3116 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3117
3118         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3119         https://bugs.webkit.org/show_bug.cgi?id=159104
3120
3121         Reviewed by Dan Bernstein.
3122         
3123         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3124         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3125
3126         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3127         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3129
3130 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3131
3132         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3133         https://bugs.webkit.org/show_bug.cgi?id=159086
3134
3135         Reviewed by Alex Christensen.
3136
3137         Implement required wheel event function in event sender.
3138  
3139         * DumpRenderTree/win/EventSender.cpp:
3140         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3141
3142 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3143
3144         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3145         https://bugs.webkit.org/show_bug.cgi?id=159104
3146
3147         Reviewed by Mark Lam.
3148         
3149         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3150         WK.
3151
3152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3153
3154 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3155
3156         parser_unittests.pl should not hardcode list of tests
3157         <https://webkit.org/b/159074>
3158
3159         Reviewed by Daniel Bates.
3160
3161         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3162         Update to read the list of tests from the 'resources' directory,
3163         and instead map file extensions to subroutine names.  Switch to
3164         use File::Basename::fileparse() to get basename and file
3165         extension for each test.
3166         (readTestFiles): Added.  Reads files from the directory passed
3167         in and ignores: hidden files, anything that isn't a plain file,
3168         and expected test results files.
3169
3170 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3171
3172         Fix Windows build.
3173
3174         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3175         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3176
3177 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3178
3179         [EFL] Change download path of libxslt
3180
3181         Unreviewed EFL build fix.
3182
3183         In Korea current download path can't be accessed. Change it.
3184
3185         * efl/jhbuild.modules:
3186
3187 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=159077
3190
3191         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3192         snapshot the final state of the test in release builds. 
3193
3194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3195         (WTR::InjectedBundlePage::dump):
3196
3197 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3198
3199         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3200
3201         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3202         (createBitmapContextFromWebView):
3203         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3204         (WTR::PlatformWebView::windowSnapshotImage):
3205
3206 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3207
3208         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3209         https://bugs.webkit.org/show_bug.cgi?id=159077
3210
3211         Reviewed by Tim Horton.
3212
3213         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3214         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3215         thus enabling testing of more things.
3216
3217         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3218         (createBitmapContext): Moved to this file to share it.
3219         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3220         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3221         (createBitmapContextFromWebView):
3222         (BitmapContext::createFromUIImage): Deleted.
3223         (BitmapContext::pixelData): Deleted.
3224         (BitmapContext::BitmapContext): Deleted.
3225         (computeMD5HashStringForBitmapContext): Deleted.
3226         (dumpBitmap): Deleted.
3227         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3228         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3229         (createPagedBitmapContext):
3230         (createBitmapContext): Deleted.
3231         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3232         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3233         (WTR::InjectedBundlePage::dump): Deleted.
3234         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3235         (WTR::PlatformWebView::windowSnapshotImage):
3236
3237 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3238
3239         [jhbuild] Added libxslt module.
3240         https://bugs.webkit.org/show_bug.cgi?id=159034
3241
3242         Unreviewed, followup for r202373.
3243
3244         * efl/install-dependencies: Removed libxslt 
3245         * gtk/install-dependencies: Ditto.
3246
3247 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3248
3249         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3250         https://bugs.webkit.org/show_bug.cgi?id=159050
3251
3252         Reviewed by Antonio Gomes.
3253
3254         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3255
3256         * efl/jhbuild.modules:
3257         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3258         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3259
3260 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3261
3262         [jhbuild] Added libxslt module.
3263         https://bugs.webkit.org/show_bug.cgi?id=159034
3264
3265         Reviewed by Michael Catanzaro.
3266
3267         * efl/jhbuild.modules:
3268         * gtk/jhbuild.modules:
3269
3270 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3271
3272         [Win] Use Windows api function to find top level parent.
3273         https://bugs.webkit.org/show_bug.cgi?id=159021
3274
3275         Reviewed by Brent Fulgham.
3276
3277         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3278  
3279         * DumpRenderTree/win/UIDelegate.cpp:
3280         (UIDelegate::runModal):
3281         (findTopLevelParent): Deleted.
3282         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3283         (PrintWebUIDelegate::runModal):
3284         (findTopLevelParent): Deleted.
3285
3286 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3287
3288         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3289         https://bugs.webkit.org/show_bug.cgi?id=158934
3290
3291         Reviewed by Brent Fulgham.
3292
3293         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3294
3295         * DumpRenderTree/win/TestRunnerWin.cpp:
3296         (TestRunner::clearAllDatabases):
3297
3298 2016-06-22  Saam Barati  <sbarati@apple.com>
3299
3300         run-javascriptcore-tests should have some environment variables for commonly used settings
3301         https://bugs.webkit.org/show_bug.cgi?id=159047
3302
3303         Reviewed by Keith Miller.
3304
3305         This patch adds three environment variables that run-javascriptcore-tests
3306         consults:
3307         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3308           determines if we should run the api tests or not.
3309         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3310           determines if we will perform a build or not before running the tests.
3311           to set the default should-build setting.
3312         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3313           a yaml file. If set, we will run the extra tests it refers to.
3314
3315         All the values in these environment variables will be overridden if an
3316         option is explicitly passed in. For example, the following will run
3317         the api tests:
3318         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3319
3320         * Scripts/run-javascriptcore-tests:
3321
3322 2016-06-22  Saam barati  <sbarati@apple.com>
3323
3324         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3325         https://bugs.webkit.org/show_bug.cgi?id=159037
3326         <rdar://problem/26935349>
3327
3328         Reviewed by Benjamin Poulain.
3329
3330         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3331
3332         * Scripts/run-jsc-stress-tests:
3333
3334 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3335
3336         Fix style issues in webkitpy
3337         https://bugs.webkit.org/show_bug.cgi?id=159019
3338
3339         Reviewed by Daniel Bates.
3340
3341         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3342         There is no functionality change.
3343         Only affected file names retained below for brevity.
3344
3345         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3346         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3347         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3348         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3349         * Scripts/webkitpy/benchmark_runner/utils.py:
3350         * Scripts/webkitpy/common/checkout/changelog.py:
3351         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3352         * Scripts/webkitpy/common/checkout/checkout.py:
3353         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3354         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3355         * Scripts/webkitpy/common/checkout/commitinfo.py:
3356         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3357         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3358         * Scripts/webkitpy/common/checkout/scm/scm.py:
3359         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3360         * Scripts/webkitpy/common/config/committers_unittest.py:
3361         * Scripts/webkitpy/common/config/irc.py:
3362         * Scripts/webkitpy/common/config/ports.py:
3363         * Scripts/webkitpy/common/config/ports_unittest.py:
3364         * Scripts/webkitpy/common/config/urls.py:
3365         * Scripts/webkitpy/common/host_mock.py:
3366         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3367         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3368         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3369         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3370         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3371         * Scripts/webkitpy/common/net/credentials_unittest.py:
3372         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3373         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3374         * Scripts/webkitpy/common/net/statusserver.py:
3375         * Scripts/webkitpy/common/system/autoinstall.py:
3376         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3377         * Scripts/webkitpy/common/system/executive.py:
3378         * Scripts/webkitpy/common/system/executive_mock.py:
3379         * Scripts/webkitpy/common/system/executive_unittest.py:
3380         * Scripts/webkitpy/common/system/filesystem_mock.py:
3381         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3382         * Scripts/webkitpy/common/system/logutils_unittest.py:
3383         * Scripts/webkitpy/common/system/path.py:
3384         * Scripts/webkitpy/common/system/path_unittest.py:
3385         * Scripts/webkitpy/common/system/platforminfo.py:
3386         * Scripts/webkitpy/common/system/user.py:
3387         * Scripts/webkitpy/common/system/user_unittest.py:
3388         * Scripts/webkitpy/common/system/workspace_unittest.py:
3389         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3390         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3391         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3392         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3393         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3394         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3395         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3396         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3397         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3398         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3399         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3400         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3401         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3402         * Scripts/webkitpy/layout_tests/views/printing.py:
3403         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3404         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3405         * Scripts/webkitpy/port/base_unittest.py:
3406         * Scripts/webkitpy/port/driver.py:
3407         * Scripts/webkitpy/port/driver_unittest.py:
3408         * Scripts/webkitpy/port/factory.py:
3409         * Scripts/webkitpy/port/gtk.py:
3410         * Scripts/webkitpy/port/server_process_unittest.py:
3411         * Scripts/webkitpy/port/test.py:
3412         * Scripts/webkitpy/port/win.py:
3413         * Scripts/webkitpy/style/checker.py:
3414         * Scripts/webkitpy/style/checkers/common_unittest.py:
3415         * Scripts/webkitpy/style/checkers/cpp.py:
3416         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3417         * Scripts/webkitpy/style/checkers/js.py:
3418         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3419         * Scripts/webkitpy/style/checkers/png.py:
3420         * Scripts/webkitpy/style/checkers/text.py:
3421         * Scripts/webkitpy/style/checkers/text_unittest.py:
3422         * Scripts/webkitpy/style/error_handlers.py:
3423         * Scripts/webkitpy/style/filter.py:
3424         * Scripts/webkitpy/style/filter_unittest.py:
3425         * Scripts/webkitpy/style/optparser.py:
3426         * Scripts/webkitpy/style/optparser_unittest.py:
3427         * Scripts/webkitpy/test/main.py:
3428         * Scripts/webkitpy/w3c/test_converter.py:
3429         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3430         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3431         * Scripts/webkitpy/xcode/simulator.py:
3432
3433 2016-06-22  Brady Eidson  <beidson@apple.com>
3434
3435         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3436         https://bugs.webkit.org/show_bug.cgi?id=158894
3437
3438         Reviewed by Alex Christensen.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3441         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3443         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3444
3445 2016-06-22  Jon Lee  <jonlee@apple.com>
3446
3447         Update animometer.plan
3448         https://bugs.webkit.org/show_bug.cgi?id=159012
3449
3450         Reviewed by Ryosuke Niwa.
3451
3452         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3453
3454 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3455
3456         W3C test importer should generate files to ignore by WebKit SCM
3457         https://bugs.webkit.org/show_bug.cgi?id=142743
3458
3459         Reviewed by Darin Adler.
3460
3461         TestDownloader generates the .gitignore file according submodules git repository information.
3462         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3463
3464         * Scripts/webkitpy/w3c/test_downloader.py:
3465         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3466         * Scripts/webkitpy/w3c/test_importer.py:
3467         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3468         (TestImporter):
3469         (TestImporter.write_init_py): Writing not empty __init__.py files.
3470         (TestImporter.import_tests): Using  of write_init_py. 
3471         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3472         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3473         (TestImporterTest):
3474         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3475
3476 2016-06-21  Sam Weinig  <sam@webkit.org>
3477
3478         WKWebView with no WKNavigationDelegate does not follow universal links
3479         <rdar://problem/24374110>
3480         https://bugs.webkit.org/show_bug.cgi?id=158997
3481
3482         Reviewed by Dan Bernstein.
3483
3484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3485         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3486         Add a new test that shows that we have a default navigation delegate by swizzling
3487         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3488
3489 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3490
3491         [Win] Implement modal dialog support in MiniBrowser.
3492         https://bugs.webkit.org/show_bug.cgi?id=158976
3493
3494         Reviewed by Brent Fulgham.
3495
3496         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3497         (PrintWebUIDelegate::createWebViewWithRequest):
3498         (getHandleFromWebView):
3499         (PrintWebUIDelegate::webViewClose):
3500         (PrintWebUIDelegate::setFrame):
3501         (PrintWebUIDelegate::webViewFrame):
3502         (PrintWebUIDelegate::canRunModal):
3503         (findTopLevelParent):
3504         (PrintWebUIDelegate::runModal):
3505         (PrintWebUIDelegate::createModalDialog):
3506         * MiniBrowser/win/PrintWebUIDelegate.h:
3507         (PrintWebUIDelegate::webViewClose):
3508         (PrintWebUIDelegate::setFrame):
3509         (PrintWebUIDelegate::webViewFrame):
3510         (PrintWebUIDelegate::canRunModal):
3511         (PrintWebUIDelegate::runModal):
3512
3513 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3514
3515         window.showModalDialog doesn't work in DumpRenderTree on Windows
3516         https://bugs.webkit.org/show_bug.cgi?id=53675
3517
3518         Reviewed by Brent Fulgham.
3519
3520         Implement modal dialog support in DumpRenderTree.
3521
3522         * DumpRenderTree/win/UIDelegate.cpp:
3523         (UIDelegate::canRunModal):
3524         (getHandleFromWebView):
3525         (UIDelegate::createModalDialog):
3526         (findTopLevelParent):
3527         (UIDelegate::runModal):
3528         (UIDelegate::webViewClose):
3529         * DumpRenderTree/win/UIDelegate.h:
3530
3531 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3532
3533         Fix formatting issues reported by check-webkit-style
3534         https://bugs.webkit.org/show_bug.cgi?id=159008
3535
3536         Reviewed by Alexey Proskuryakov.
3537
3538         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3539         There is no functionality change.
3540
3541         * Scripts/webkitpy/tool/bot/irc_command.py:
3542         (Restart.execute):
3543         (Rollout):
3544         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3545         (IRCBotTest.test_exception_during_command):
3546         (IRCBotTest.test_exception_during_command.CommandWithException):
3547         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3548         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3549         (test_missing_unit_test_results_path):
3550         (test_layout_test_results):
3551         * Scripts/webkitpy/tool/bot/queueengine.py:
3552         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3553         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3554         (AbstractSequencedCommand):
3555         (AbstractSequencedCommand.__init__):
3556         * Scripts/webkitpy/tool/commands/download.py:
3557         (Land):
3558         * Scripts/webkitpy/tool/commands/openbugs.py:
3559         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3560         (OpenBugsTest):
3561         * Scripts/webkitpy/tool/commands/queries.py:
3562         (PatchesToCommitQueue):
3563         (PatchesToCommitQueue.__init__):
3564         (PatchesToCommitQueue._needs_commit_queue):
3565         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3566         (PrintExpectationsTest.test_platform):
3567         (PrintBaselinesTest):
3568         (PrintBaselinesTest.setUp):
3569         * Scripts/webkitpy/tool/commands/queues.py:
3570         (AbstractQueue):
3571         (AbstractQueue.__init__):
3572         (AbstractQueue.execute):
3573         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3574         (test_auto_retry):
3575         * Scripts/webkitpy/tool/commands/rebaseline.py:
3576         (AbstractParallelRebaselineCommand._files_to_add):
3577         (AbstractParallelRebaselineCommand):
3578         (AbstractParallelRebaselineCommand._rebaseline):
3579         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3580         (SetupGitClone):
3581         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3582         * Scripts/webkitpy/tool/commands/stepsequence.py:
3583         * Scripts/webkitpy/tool/commands/upload.py:
3584         (PostCommits._comment_text_for_commit):
3585         (PostCommits):
3586         (PostCommits.execute):
3587         (MarkBugFixed):
3588         (MarkBugFixed.__init__):
3589         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3590         (UploadCommandsTest):
3591         (UploadCommandsTest.test_commit_message_for_current_diff):
3592         * Scripts/webkitpy/tool/grammar_unittest.py:
3593         (GrammarTest):
3594         (GrammarTest.test_join_with_separators):
3595         * Scripts/webkitpy/tool/multicommandtool.py:
3596         (HelpCommand.__init__):
3597         (HelpCommand):
3598         (HelpCommand._help_epilog):
3599         (HelpCommand._remove_help_options):
3600         (MultiCommandTool):
3601         (MultiCommandTool.__init__):
3602         (MultiCommandTool.main):
3603         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3604         (TrivialCommand):
3605         (TrivialCommand.__init__):
3606         (MultiCommandToolTest):
3607         (MultiCommandToolTest._assert_tool_main_outputs):
3608         (MultiCommandToolTest.test_retry):
3609         (test_command_help):
3610         * Scripts/webkitpy/tool/steps/__init__.py:
3611         * Scripts/webkitpy/tool/steps/abstractstep.py:
3612         * Scripts/webkitpy/tool/steps/applypatch.py:
3613         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
3614         (ApplyPatchWithLocalCommit):
3615         (ApplyPatchWithLocalCommit.options):
3616         * Scripts/webkitpy/tool/steps/build.py:
3617         * Scripts/webkitpy/tool/steps/checkstyle.py:
3618         (CheckStyle):
3619         (CheckStyle.options):
3620         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3621         * Scripts/webkitpy/tool/steps/closebug.py:
3622         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3623         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3624         (CloseBugForLandDiffTest):
3625         (CloseBugForLandDiffTest.test_empty_state):
3626         * Scripts/webkitpy/tool/steps/closepatch.py:
3627         * Scripts/webkitpy/tool/steps/commit.py:
3628         (Commit.run):
3629         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3630         * Scripts/webkitpy/tool/steps/editchangelog.py:
3631         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3632         * Scripts/webkitpy/tool/steps/metastep.py:
3633         (MetaStep):
3634         (MetaStep.__init__):
3635         (MetaStep.run):
3636         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3637         * Scripts/webkitpy/tool/steps/options.py:
3638         (Options):
3639         * Scripts/webkitpy/tool/steps/postdiff.py:
3640         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3641         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3642         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3643         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3644         (PrepareChangeLogTest):
3645         (PrepareChangeLogTest.test_resolve_existing_entry):
3646         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3647         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3648         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3649         * Scripts/webkitpy/tool/steps/revertrevision.py:
3650         * Scripts/webkitpy/tool/steps/runtests.py:
3651         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3652         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3653         (StepsTest):
3654         (StepsTest._step_options):
3655         * Scripts/webkitpy/tool/steps/update.py:
3656         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3657         (UpdateChangeLogsWithReviewerTest):
3658         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3659         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3660         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3661
3662 2016-06-21  Chris Dumez  <cdumez@apple.com>
3663
3664         Unreviewed, rolling out r202296.
3665
3666         Broke basic browsing in Safari
3667
3668         Reverted changeset:
3669
3670         "WKWebView with no WKNavigationDelegate does not follow
3671         universal links"
3672         https://bugs.webkit.org/show_bug.cgi?id=158997
3673         http://trac.webkit.org/changeset/202296
3674
3675 2016-06-21  Anders Carlsson  <andersca@apple.com>
3676
3677         Fix build.
3678
3679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3680
3681 2016-06-21  Anders Carlsson  <andersca@apple.com>
3682
3683         Begin moving the Apple Pay code to the open source repository
3684         https://bugs.webkit.org/show_bug.cgi?id=158998
3685
3686         Reviewed by Tim Horton.
3687
3688         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3689         Add ENABLE_APPLE_PAY.
3690
3691 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
3692
3693         Add system tracing points for requestAnimationFrame() workflow
3694         https://bugs.webkit.org/show_bug.cgi?id=158723
3695
3696         Reviewed by Simon Fraser.
3697
3698         Add new plist entries to be used by kdebug_trace() viewing tools.
3699
3700         * Tracing/SystemTracePoints.plist:
3701
3702 2016-06-21  Sam Weinig  <sam@webkit.org>
3703
3704         WKWebView with no WKNavigationDelegate does not follow universal links
3705         <rdar://problem/24374110>
3706         https://bugs.webkit.org/show_bug.cgi?id=158997
3707
3708         Reviewed by Dan Bernstein.
3709
3710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3711         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3712         Add a new test that shows that we have a default navigation delegate by swizzling
3713         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3714
3715 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3716
3717         run-javascriptcore-tests should have flag to skip mozilla tests
3718         https://bugs.webkit.org/show_bug.cgi?id=158963
3719         rdar://problem/25838924
3720
3721         Reviewed by Alexey Proskuryakov.
3722
3723         * Scripts/run-javascriptcore-tests:
3724         (runJSCStressTests): Added flag to skip mozilla tests.
3725
3726 2016-06-20  Commit Queue  <commit-queue@webkit.org>
3727
3728         Unreviewed, rolling out r202136.
3729         https://bugs.webkit.org/show_bug.cgi?id=158932
3730
3731         JSBench wasn't regressed by r202002 and r202111 on iOS after
3732         all (Requested by rniwa_ on #webkit).
3733
3734         Reverted changeset:
3735
3736         "Unreviewed, rolling out r202002 and r202111."
3737         https://bugs.webkit.org/show_bug.cgi?id=158638
3738         http://trac.webkit.org/changeset/202136
3739
3740 2016-06-20  Keith Rollin  <krollin@apple.com>
3741
3742         Remove RefPtr::release() and change calls sites to use WTFMove()
3743         https://bugs.webkit.org/show_bug.cgi?id=158369
3744
3745         Reviewed by Chris Dumez.
3746
3747         RefPtr::release() releases its managed pointer awkwardly. It's more
3748         direct and clearer to use WTFMove to transfer ownership of the managed
3749         pointer.
3750
3751         As part of this cleanup, also change a lot of explicit data types to
3752         'auto'.
3753
3754         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3755         (createBitmapContextFromWebView):
3756         (createPagedBitmapContext):
3757         * DumpRenderTree/mac/TestRunnerMac.mm:
3758         (TestRunner::setMockGeolocationPosition):
3759         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3760         (TestWebKitAPI::TEST):
3761         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3762         (TestWebKitAPI::TEST):
3763
3764 2016-06-20  Tim Horton  <timothy_horton@apple.com>
3765
3766         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
3767         https://bugs.webkit.org/show_bug.cgi?id=158947
3768
3769         Reviewed by Simon Fraser.
3770
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
3773         (TestWebKitAPI::didFinishLoadForFrame):
3774         (TestWebKitAPI::setPageLoaderClient):
3775         (TestWebKitAPI::TEST):
3776         Add a test ensuring that in-window state changes are deferred when using
3777         the SPI for deferring them, as fixed in r202230.
3778
3779 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3780
3781         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
3782         https://bugs.webkit.org/show_bug.cgi?id=158931
3783
3784         Reviewed by Alexey Proskuryakov.
3785
3786         * WebKitTestRunner/TestInvocation.cpp:
3787         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
3788
3789 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
3790
3791         Add test expectations for macOS Sierra
3792         https://bugs.webkit.org/show_bug.cgi?id=158903
3793
3794         Reviewed by Alex Christensen.
3795
3796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
3797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
3798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3800         Added dashboard support.
3801
3802         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3803         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3804         Trigger the right build queues on check-in.
3805
3806         * Scripts/webkitpy/common/system/platforminfo.py:
3807         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3808         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3809         * Scripts/webkitpy/port/mac.py:
3810         * Scripts/webkitpy/port/mac_unittest.py:
3811         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3812         Added cases for Sierra, and updated tests for new baseline search paths.
3813
3814 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3815
3816         Another buid fix for master.cfg.
3817
3818         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3819         (CompileWebKit.start):
3820
3821 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3822
3823         Another buid fix for master.cfg.
3824
3825         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3826         (CompileWebKit.start):
3827
3828 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3829
3830         Fix master.cfg
3831         
3832         Unreviewed build fix.
3833
3834         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3835         (CompileWebKit.start):
3836
3837 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3838
3839         Test another commit.
3840         
3841         Unreviewed.
3842
3843 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3844
3845         Testing fix for trac-mirror.
3846         
3847         Unreviewed.
3848
3849 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3850
3851         Test a commit against the SVN 1.9 server upgrade.
3852         
3853         Unreviewed.
3854         
3855 2016-06-17  Daniel Bates  <dabates@apple.com>
3856
3857         Unreviewed, rolling out r202186.
3858
3859         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
3860         builds.
3861
3862         Reverted changeset:
3863
3864         "File scheme should not allow access of a resource on a
3865         different volume."
3866         https://bugs.webkit.org/show_bug.cgi?id=158552
3867         http://trac.webkit.org/changeset/202186
3868
3869 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
3870
3871         File scheme should not allow access of a resource on a different volume.
3872         https://bugs.webkit.org/show_bug.cgi?id=158552
3873         <rdar://problem/15307582>
3874
3875         Reviewed by Brent Fulgham.
3876
3877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3878         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3879         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3880         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
3881         When the main page load is complete fetch the contents of the document to check if iframe was loaded
3882         (createPartition):
3883         Create a disk image and load the contents of the file.
3884         (cleanUp):
3885         (TestWebKitAPI::TEST):
3886
3887 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
3888
3889         Unreviewed. Added myself to the list of committers.
3890
3891         * Scripts/webkitpy/common/config/contributors.json:
3892
3893 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3894
3895         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
3896         https://bugs.webkit.org/show_bug.cgi?id=158141
3897
3898         Reviewed by Michael Catanzaro.
3899
3900         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
3901         (Port._is_debian_php_version_7):
3902         (Port._debian_php_version):
3903         (Port._apache_config_file_name_for_platform):
3904         * efl/install-dependencies:
3905         * gtk/install-dependencies:
3906
3907 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
3908
3909         Baseline JIT should be concurrent
3910         https://bugs.webkit.org/show_bug.cgi?id=158755
3911
3912         Reviewed by Geoffrey Garen.
3913         
3914         Need to disable concurrent JIT when running profiler tests. We should have been doing this
3915         all along.
3916
3917         * Scripts/run-jsc-stress-tests:
3918
3919 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
3920
3921         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
3922         https://bugs.webkit.org/show_bug.cgi?id=140798
3923
3924         Reviewed by Brent Fulgham.
3925        
3926         Make sure layout is up-to-date before trying to find named elements. 
3927
3928         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3929         (AccessibilityController::rootElement):
3930
3931 2016-06-16  Chris Dumez  <cdumez@apple.com>
3932
3933         Unreviewed, rolling out r202002 and r202111.
3934
3935         Ryosuke says this was a JSBench regression on iOS
3936
3937         Reverted changesets:
3938
3939         "Make HashMap and HashSet work with Refs"
3940         https://bugs.webkit.org/show_bug.cgi?id=158638
3941         http://trac.webkit.org/changeset/202002
3942
3943         "Improve HashMap and HashSet support for Ref"
3944         https://bugs.webkit.org/show_bug.cgi?id=158789
3945         http://trac.webkit.org/changeset/202111
3946
3947 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
3948
3949         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
3950         https://bugs.webkit.org/show_bug.cgi?id=158828
3951
3952         Reviewed by Enrica Casucci.
3953         
3954         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
3955         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
3956
3957         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3958         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3959         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
3960         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
3961         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3962         * WebKitTestRunner/ios/TestControllerIOS.mm:
3963         (WTR::TestController::platformResetStateToConsistentValues):
3964         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3965         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
3966         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
3967
3968 2016-06-15  Sam Weinig  <sam@webkit.org>
3969
3970         Forward/Back keyboard shortcuts need to flip for RTL
3971         https://bugs.webkit.org/show_bug.cgi?id=158823
3972         <rdar://problem/25975359>
3973
3974         Reviewed by Darin Adler.
3975
3976         Add tests for flipping the behavior of command-left and command-right
3977         under RTL mode.
3978
3979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3980         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
3981         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
3982         (-[CommandBackForwardOffscreenWindow isVisible]):
3983         (simulateCommandArrow):
3984         (WebKit2_CommandBackForwardTest::SetUp):
3985         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
3986         (WebKit2_CommandBackForwardTestWKView::SetUp):
3987         (WebKit2_CommandBackForwardTestWKView::loadFiles):
3988         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
3989         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
3990         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
3991
3992 2016-06-15  Tim Horton  <timothy_horton@apple.com>
3993
3994         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
3995         https://bugs.webkit.org/show_bug.cgi?id=158824
3996         <rdar://problem/23713857>
3997
3998         Reviewed by Simon Fraser.
3999
4000         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4001         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
4002         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
4003         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
4004         (TEST):
4005         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
4006
4007 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
4008
4009         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
4010         https://bugs.webkit.org/show_bug.cgi?id=158714
4011
4012         Reviewed by Enrica Casucci.
4013
4014         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
4015         method that gets called from UIKit.
4016
4017         Add a test that exercises it.
4018
4019         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4020         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4021         (WTR::UIScriptController::keyboardAccessoryBarNext):
4022         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4023         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4025         (WTR::UIScriptController::keyboardAccessoryBarNext):
4026         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4027
4028 2016-06-15  Sam Weinig  <sam@webkit.org>
4029
4030         Improve HashMap and HashSet support for Ref
4031         https://bugs.webkit.org/show_bug.cgi?id=158789
4032
4033         Reviewed by Chris Dumez.
4034
4035         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4036         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4037         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
4038
4039 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
4040
4041         Too much log data generated during layout-tests on iOS Simulator
4042         https://bugs.webkit.org/show_bug.cgi?id=158751
4043
4044         Reviewed by Alexey Proskuryakov.
4045
4046         * Scripts/webkitpy/port/ios.py:
4047         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
4048         repeatedly.
4049
4050 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4051
4052         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
4053         https://bugs.webkit.org/show_bug.cgi?id=158727
4054
4055         Reviewed by Alex Christensen.
4056
4057         Delete CMake cache file if WebKit options have been modified.
4058
4059         * Scripts/build-webkit:
4060         * Scripts/webkitdirs.pm:
4061         (shouldRemoveCMakeCache):
4062
4063 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
4064
4065         Enabling Shadow DOM for all platforms
4066         https://bugs.webkit.org/show_bug.cgi?id=158738
4067
4068         Reviewed by Ryosuke Niwa.
4069
4070         Removed Shadow DOM from options (enabled by default)
4071
4072         * Scripts/webkitperl/FeatureList.pm:
4073         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4074
4075 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4076
4077         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
4078         https://bugs.webkit.org/show_bug.cgi?id=158732
4079
4080         Reviewed by Brent Fulgham.
4081
4082         Implement selectedTextRange() method.
4083
4084         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4085         (AccessibilityUIElement::selectedTextRange):
4086
4087 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4088
4089         [Win] MiniBrowser is not DPI aware.
4090         https://bugs.webkit.org/show_bug.cgi?id=158733
4091
4092         Reviewed by Brent Fulgham.
4093
4094         Call Win32 api function to let Windows know that we will scale the contents ourselves.
4095
4096         * MiniBrowser/win/WinMain.cpp:
4097         (wWinMain):
4098
4099 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4100
4101         Unreviewed: add new email address to contributors.json.
4102
4103         * Scripts/webkitpy/common/config/contributors.json:
4104
4105 2016-06-14  Keith Miller  <keith_miller@apple.com>
4106
4107         JSBench should use geometric mean
4108         https://bugs.webkit.org/show_bug.cgi?id=158775
4109
4110         Reviewed by Mark Lam.
4111
4112         For some reason JSBench was using algebraic mean. Since each test
4113         is pretty substantially different it should use geometric mean
4114         instead.
4115
4116         * Scripts/run-jsc-benchmarks:
4117
4118 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4119
4120         Debug crash logs are not fully symbolicated on Yosemite
4121         https://bugs.webkit.org/show_bug.cgi?id=158760
4122
4123         Reviewed by Darin Adler.
4124
4125         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
4126         for debug builds on Yosemite.
4127
4128 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4129
4130         Tests don't work in iOS Simulator when ASan is enabled
4131         https://bugs.webkit.org/show_bug.cgi?id=158726
4132
4133         Reviewed by David Kilzer.
4134
4135         * Scripts/webkitpy/port/driver.py:
4136         (Driver._setup_environ_for_driver): Added a FIXME.
4137         * Scripts/webkitpy/port/ios.py:
4138         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
4139         simulator into LayoutTestRelay, which is a macOS tool.
4140
4141 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
4142
4143         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
4144         https://bugs.webkit.org/show_bug.cgi?id=158756
4145
4146         Reviewed by Alexey Proskuryakov.
4147
4148         * Scripts/webkitpy/xcode/simulator.py:
4149         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
4150         the "simulator device" is still in booted state. Since we ensured that simulator device 
4151         was in booted state earlier in this method, this indicates that simulator device has shut down
4152         unexpectedly.
4153
4154 2016-06-14  David Kilzer  <ddkilzer@apple.com>
4155
4156         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
4157         <https://webkit.org/b/158743>
4158
4159         Unreviewed build fix.
4160
4161         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
4162
4163 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
4164
4165         Too much log data generated during layout-tests on iOS Simulator
4166         https://bugs.webkit.org/show_bug.cgi?id=158751
4167
4168         Reviewed by Alexey Proskuryakov.
4169
4170         * Scripts/webkitpy/port/ios.py:
4171         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
4172         (IOSSimulatorPort.clean_up_test_run): Ditto.
4173         (IOSSimulatorPort._createSimulatorApp): Ditto.
4174
4175 2016-06-14  David Kilzer  <ddkilzer@apple.com>
4176
4177         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
4178         <https://webkit.org/b/158743>
4179
4180         Unreviewed build fix.
4181
4182         The fix in r202056 clobbered DumpRenderTree_SOURCES and
4183         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
4184         so the build failure is now that we're not building the common
4185         sources.
4186
4187         Fix that by saving the common sources (which are all C++ source
4188         files) into *_Cpp_SOURCES lists first, then setting the compiler
4189         flags, then creating the final *_SOURCES lists.
4190
4191         * DumpRenderTree/PlatformMac.cmake: Add
4192         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
4193         "-std=c++14" compiler switch.
4194         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
4195         files for TestNetscapePlugin.  Seeded with
4196         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
4197         (TestNetscapePlugin_SOURCES): Add
4198         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
4199         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
4200         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
4201         (DumpRenderTree_SOURCES): Reformat and sort source lists.
4202
4203 2016-06-14  David Kilzer  <ddkilzer@apple.com>
4204
4205         REGRESSION (r202020): El Capitan CMake Debug build broken
4206         <https://webkit.org/b/158743>
4207
4208         Reviewed by Alex Christensen.
4209
4210         The bug was that pure C++ source files (and Objective-C source
4211         files) were being compiled as Objective-C++ source files.  This
4212         is obviously incorrect, so the fix was to split out the list of
4213         source files by language, then define compiler switches based on
4214         each file type.
4215
4216         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
4217         with separate foreach loops that set compiler flags based on
4218         each source file's type.
4219         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
4220         TestNetscapePlugin_SOURCES.
4221         (TestNetscapePlugin_SOURCES): Create based on
4222         ${TestNetscapePlugin_ObjCpp_SOURCES}.
4223         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
4224         (DumpRenderTree_Cpp_SOURCES): Ditto.
4225         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
4226         (DumpRenderTree_SOURCES): Create from above three lists.
4227
4228 2016-06-14  Lucas Forschler  <lforschler@apple.com>
4229
4230         <rdar://problem/26685782>
4231         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
4232
4233         Rubber-stamped by Jessie Berlin.
4234
4235         * Scripts/copy-webkitlibraries-to-product-directory:
4236
4237 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4238
4239         Activate CMake export compile commands option
4240         https://bugs.webkit.org/show_bug.cgi?id=158734
4241
4242         Reviewed by Alex Christensen.
4243
4244         * Scripts/webkitdirs.pm:
4245         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
4246         This allows using ymcd for WebKit hacking.
4247
4248 2016-06-14  David Kilzer  <ddkilzer@apple.com>
4249
4250         Modernize DumpRenderTreeMac.h
4251         <https://webkit.org/b/158721>
4252
4253         Reviewed by Andy Estes.
4254
4255         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4256         - Update copyright.
4257         - Update license.
4258         - Use #pragma once.
4259         - Use OBJC_CLASS macro.
4260
4261 2016-06-13  David Kilzer  <ddkilzer@apple.com>
4262
4263         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
4264         <https://webkit.org/b/158716>
4265
4266         Reviewed by Andy Estes.
4267
4268         * DumpRenderTree/mac/DumpRenderTree.mm:
4269         (destroyWebViewAndOffscreenWindow): Change this function to take
4270         a WebView, and assert that it's the same as [mainFrame webView].
4271         (dumpRenderTree): Pass 'webView' into
4272         destroyWebViewAndOffscreenWindow().
4273         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4274         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
4275         this function returns a +1 WebView.  Declare this method only for
4276         Objective-C[++] source.
4277
4278 2016-06-13  Sam Weinig  <sam@webkit.org>
4279
4280         Make HashMap and HashSet work with Refs
4281         https://bugs.webkit.org/show_bug.cgi?id=158638
4282
4283         Reviewed by Darin Adler.
4284
4285         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4286         (TestWebKitAPI::TEST):
4287         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4288         (TestWebKitAPI::TEST):
4289         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
4290
4291 2016-06-13  Mark Lam  <mark.lam@apple.com>
4292
4293         Add a mechanism for collecting LLINT stats.