Regression(PSON) cross-site provisional page is not canceled if a new same-site one...
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Chris Dumez  <cdumez@apple.com>
2
3         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4         https://bugs.webkit.org/show_bug.cgi?id=193788
5         <rdar://problem/47531231>
6
7         Reviewed by Alex Christensen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
13
14 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
15
16         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
17         https://bugs.webkit.org/show_bug.cgi?id=193771
18
19         Unreviewed infrastructure fix.
20
21         * Scripts/webkitpy/port/darwin.py:
22         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
23
24 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
25
26         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
27
28 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
29
30         Add contributors.json entries for Ling Ho and for a new bot watchers group.
31
32         * Scripts/webkitpy/common/config/contributors.json:
33
34 2019-01-25  Chris Dumez  <cdumez@apple.com>
35
36         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
37         https://bugs.webkit.org/show_bug.cgi?id=193779
38         <rdar://problem/46170903>
39
40         Reviewed by Antti Koivisto.
41
42         Add API test that quickly navigates forward to a previous process without waiting for it to
43         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
44         the process' previous page when reconnecting the it for the forward navigation.
45
46         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
47
48 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
49
50         Need a way for JavaScript (or bundle) code to participate in undo
51         https://bugs.webkit.org/show_bug.cgi?id=190009
52         <rdar://problem/44807048>
53
54         Reviewed by Ryosuke Niwa.
55
56         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
57         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
58
59         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
60         (WTR::UIScriptController::lastUndoLabel const):
61         (WTR::UIScriptController::firstRedoLabel const):
62         (WTR::UIScriptController::platformUndoManager const):
63         * DumpRenderTree/mac/UIScriptControllerMac.mm:
64         (WTR::UIScriptController::lastUndoLabel const):
65         (WTR::UIScriptController::firstRedoLabel const):
66         (WTR::UIScriptController::platformUndoManager const):
67         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
68         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
69         (WTR::UIScriptController::lastUndoLabel const):
70         (WTR::UIScriptController::firstRedoLabel const):
71         * TestRunnerShared/UIScriptContext/UIScriptController.h:
72         * WebKitTestRunner/UIScriptControllerCocoa.mm:
73         (WTR::UIScriptController::lastUndoLabel const):
74         (WTR::UIScriptController::firstRedoLabel const):
75         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
76         (WTR::UIScriptController::platformUndoManager const):
77         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
78         (WTR::UIScriptController::platformUndoManager const):
79
80 2019-01-25  Zalan Bujtas  <zalan@apple.com>
81
82         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
83         https://bugs.webkit.org/show_bug.cgi?id=193824
84
85         Reviewed by Antti Koivisto.
86
87         * LayoutReloaded/misc/LFC-passing-tests.txt:
88
89 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
90
91         Update macOS JSC bot configurations
92         https://bugs.webkit.org/show_bug.cgi?id=193739
93
94         Reviewed by Alexey Proskuryakov.
95
96         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
97         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
98         (BubbleQueueServer): Move JSC EWS to Mojave section.
99         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
100         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
101         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
102
103 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
104
105         [Win][WebKitTestRunner] Implement EventSenderProxy
106         https://bugs.webkit.org/show_bug.cgi?id=193755
107
108         Reviewed by Don Olmstead.
109
110         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
111         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
112         (WTR::EventSenderProxy::dispatchMessage):
113         (WTR::EventSenderProxy::EventSenderProxy):
114         (WTR::EventSenderProxy::mouseDown):
115         (WTR::EventSenderProxy::mouseUp):
116         (WTR::EventSenderProxy::mouseMoveTo):
117         (WTR::EventSenderProxy::mouseScrollBy):
118         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
119
120 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
121
122         Unreviewed fix for API test failure after r240437.
123
124         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
125
126         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
127
128 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
129
130         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
131         https://bugs.webkit.org/show_bug.cgi?id=193787
132         <rdar://problem/47497634>
133
134         Reviewed by Alexey Proskuryakov.
135
136         * Scripts/webkitdirs.pm:
137         (iosSimulatorApplicationsPath): Pick from available runtime directories.
138
139 2019-01-24  Truitt Savell  <tsavell@apple.com>
140
141         Unreviewed, rolling out r240446.
142
143         Casued 5 API failures
144
145         Reverted changeset:
146
147         "Activate the WebResourceLoadStatisticsStore in the
148         NetworkProcess and deactivate it in the UIProcess."
149         https://bugs.webkit.org/show_bug.cgi?id=193297
150         https://trac.webkit.org/changeset/240446
151
152 2019-01-24  Zalan Bujtas  <zalan@apple.com>
153
154         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
155         https://bugs.webkit.org/show_bug.cgi?id=193741
156         <rdar://problem/47135030>
157
158         Reviewed by Antti Koivisto and Simon Fraser.
159
160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
161         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
162         (TestWebKitAPI::TEST):
163
164 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
165
166         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
167         https://bugs.webkit.org/show_bug.cgi?id=193297
168         <rdar://problem/47158841>
169
170         Reviewed by Alex Christensen.
171
172         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
173         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
174         activating the message used to trigger the callback when it is set.
175
176 2019-01-24  John Wilander  <wilander@apple.com>
177
178         Add Ad Click Attribution as an internal/experimental feature
179         https://bugs.webkit.org/show_bug.cgi?id=193685
180         <rdar://problem/47450399>
181
182         Reviewed by Brent Fulgham.
183
184         Added test option adClickAttributionEnabled.
185
186         * DumpRenderTree/TestOptions.cpp:
187         (TestOptions::TestOptions):
188         * DumpRenderTree/TestOptions.h:
189         * DumpRenderTree/mac/DumpRenderTree.mm:
190         (setWebPreferencesForTestOptions):
191
192 2019-01-24  Antti Koivisto  <antti@apple.com>
193
194         [PSON] Flash on back navigation on Mac
195         https://bugs.webkit.org/show_bug.cgi?id=193716
196         <rdar://problem/47148458>
197
198         Reviewed by Chris Dumez.
199
200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
201
202         Closing of the previous page is delayed so waiting for didFinishNavigation is
203         not sufficient to guarantee we have received all the messages. Wait for them.
204
205 2019-01-24  Chris Dumez  <cdumez@apple.com>
206
207         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
208         https://bugs.webkit.org/show_bug.cgi?id=193761
209         <rdar://problem/47456405>
210
211         Reviewed by Alex Christensen.
212
213         Add API test coverage.
214
215         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
216
217 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
218
219         webkitpy: Missing PID in crashlog name should not be fatal
220         https://bugs.webkit.org/show_bug.cgi?id=193771
221
222         If we can't determine the PID of a crashlog, just ignore the crashlog instead
223         of raising an exception.
224
225         Reviewed by Lucas Forschler.
226
227         * Scripts/webkitpy/port/darwin.py:
228         (DarwinPort._merge_crash_logs):
229
230 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
231
232         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
233         https://bugs.webkit.org/show_bug.cgi?id=193746
234
235         Reviewed by Youenn Fablet.
236
237         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
238         so we'd best just not call it.
239
240         * Scripts/webkitpy/w3c/test_exporter.py:
241         (WebPlatformTestExporter.create_branch_with_patch):
242
243 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
244
245         Move FileSystem to WTF
246         https://bugs.webkit.org/show_bug.cgi?id=193602
247
248         Reviewed by Yusuke Suzuki.
249
250         * DumpRenderTree/win/DumpRenderTree.cpp:
251         * TestWebKitAPI/CMakeLists.txt:
252         * TestWebKitAPI/PlatformGTK.cmake:
253         * TestWebKitAPI/PlatformJSCOnly.cmake:
254         * TestWebKitAPI/PlatformPlayStation.cmake:
255         * TestWebKitAPI/PlatformWPE.cmake:
256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
257         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
258         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
259         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
260         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
261         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
262         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
263         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
264         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
265         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
266
267 2019-01-24  Philippe Normand  <pnormand@igalia.com>
268
269         [WPE] Remove hard dependency on subprocess32 for the API tests
270
271         Rubber-stamped by Carlos Garcia Campos.
272
273         * glib/api_test_runner.py:
274         (TestRunner._run_test_qt): Lazily import subprocess32 and check
275         its presence only when running WPEQt tests.
276
277 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
278
279         [GLIB] Expose JavaScriptCore options in GLib public API
280         https://bugs.webkit.org/show_bug.cgi?id=188742
281
282         Reviewed by Michael Catanzaro.
283
284         Add a test for the new API.
285
286         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
287         (testsJSCOptions):
288         (main):
289
290 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         [GTK][WPE] Support JPEG 2000 images
293         https://bugs.webkit.org/show_bug.cgi?id=186272
294
295         Reviewed by Žan Doberšek.
296
297         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
298
299         * gtk/jhbuild.modules:
300         * wpe/jhbuild.modules:
301
302 2019-01-23  David Kilzer  <ddkilzer@apple.com>
303
304         check-webkit-style should warn when using soft-linking macros in a header
305         <https://webkit.org/b/193750>
306
307         Reviewed by Darin Adler.
308
309         * Scripts/webkitpy/style/checkers/cpp.py:
310         (check_language): Add softlink/header check by refactoring the
311         softlink/framework check.
312         (CppChecker): Enable softlink/header check by default.
313         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
314         (CppStyleTest.test_softlink_framework): Rename from
315         CppStyleTest.test_softlink() and change test framework name in
316         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
317         files. Set file_name for macros that only appear in headers.
318         (CppStyleTest.test_softlink_header): Add tests for using
319         soft-link macros in headers.
320
321 2019-01-23  Chris Dumez  <cdumez@apple.com>
322
323         Deprecate API to limit the maximum number of WebProcesses
324         https://bugs.webkit.org/show_bug.cgi?id=193725
325         <rdar://problem/47464879>
326
327         Reviewed by Geoff Garen.
328
329         Update existing API tests to stop using deprecated API.
330
331         * MiniBrowser/mac/AppDelegate.m:
332         (defaultConfiguration):
333         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
334         (TestWebKitAPI::TEST):
335         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
338         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
339         (TEST):
340         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
341         (TEST):
342
343 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
344
345         [ews-app] Rename ews model buildermappings to buildermapping
346         https://bugs.webkit.org/show_bug.cgi?id=193729
347
348         Reviewed by Lucas Forschler.
349
350         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
351         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
352         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
353
354 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
355
356         [ews-app] Rename ews model steps to step
357         https://bugs.webkit.org/show_bug.cgi?id=193697
358
359         Reviewed by Lucas Forschler.
360
361         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
362         (Step): Renamed Steps to Step.
363
364 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
365
366         Clean up IndexedDB files between tests
367         https://bugs.webkit.org/show_bug.cgi?id=192796
368         <rdar://problem/46824999>
369
370         Reviewed by Geoffrey Garen.
371
372         * DumpRenderTree/mac/DumpRenderTree.mm:
373         (runTest):
374         * WebKitTestRunner/TestController.cpp:
375         (WTR::TestController::resetStateToConsistentValues):
376         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
377         (WTR::RemoveAllIndexedDatabasesCallback):
378         (WTR::TestController::ClearIndexedDatabases):
379         * WebKitTestRunner/TestController.h:
380         * WebKitTestRunner/TestInvocation.cpp:
381         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
382
383 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
384
385         [ews-app] Rename ews model Builds to Build
386         https://bugs.webkit.org/show_bug.cgi?id=193695
387
388         Reviewed by Lucas Forschler.
389
390         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
391         (Build): Renamed Builds to Build.
392
393 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
394
395         webkitpy: Wait longer when launching WebKitTestRunner
396         https://bugs.webkit.org/show_bug.cgi?id=193734
397
398         Reviewed by Aakash Jain.
399
400         * Scripts/webkitpy/port/simulator_process.py:
401         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
402
403 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
404
405         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
406         https://bugs.webkit.org/show_bug.cgi?id=193182
407         <rdar://problem/47452154>
408
409         Reviewed by Tim Horton.
410
411         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
412         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
413         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
414
415         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
416         preventing later tests from recognizing gestures.
417
418         * WebKitTestRunner/ios/TestControllerIOS.mm:
419         (WTR::TestController::platformResetStateToConsistentValues):
420
421         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
422
423 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
424
425         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
426         https://bugs.webkit.org/show_bug.cgi?id=193722
427         <rdar://problem/47481475>
428
429         Reviewed by Lucas Forschler.
430
431         iPhone and iPad ports should both use the iOS config.
432
433         * Scripts/webkitpy/port/ios_simulator.py:
434         (IPhoneSimulatorPort.__init__):
435         (IPadSimulatorPort.__init__):
436
437 2019-01-23  Rob Buis  <rbuis@igalia.com>
438
439         Update MIME type parser
440         https://bugs.webkit.org/show_bug.cgi?id=180526
441
442         Reviewed by Frédéric Wang.
443
444         Add unit tests for both parse modes of ParsedContentType.
445
446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
447         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
448         (TestWebKitAPI::TEST):
449
450 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-app] fetch loop should not stop on network issues
453         https://bugs.webkit.org/show_bug.cgi?id=193666
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-app/ews/fetcher.py:
458         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
459
460 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
461
462         [iOS] Multiple WKWebViewAutofillTests are flaky failures
463         https://bugs.webkit.org/show_bug.cgi?id=189165
464         <rdar://problem/47433765>
465
466         Reviewed by Tim Horton.
467
468         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
469         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
470         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
471         process in sufficient to ensure that any previous action that blurred the focused element in the web process
472         would make its way to the UI process by the time the layer tree commit is finished.
473
474         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
475         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
476         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
477         will fail because it asks for -_autofillContext too early.
478
479         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
480         is handled in the UI process.
481
482         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
483
484         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
485         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
486         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
487         input session.
488
489         (-[AutofillTestView textInputHasAutofillContext]):
490
491         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
492
493         * TestWebKitAPI/cocoa/TestWKWebView.h:
494         * TestWebKitAPI/cocoa/TestWKWebView.mm:
495         (nextInputSessionChangeCount):
496
497         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
498         This includes changing the focused element from one to another.
499
500         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
501         (-[TestWKWebView didStartFormControlInteraction]):
502         (-[TestWKWebView didEndFormControlInteraction]):
503         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
504
505         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
506         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
507         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
508         that doesn't require an input session to one that doesn't.
509
510 2019-01-22  David Kilzer  <ddkilzer@apple.com>
511
512         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
513         <https://webkit.org/b/193676>
514
515         Reviewed by Alexey Proskuryakov.
516
517         * Scripts/webkitpy/style/checkers/cpp.py:
518         (check_member_initialization_list):
519         - Don't report missing whitespace around colon if the colon at
520           the start of the line is formatted correctly.
521         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
522         (WebKitStyleTest.test_member_initialization_list):
523         - Add a test for a missing permutation of existing tests.
524         - Add a test this false-positive.
525         - Add blank lines between subtests to make them easier to read.
526
527 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
528
529         [build.webkit.org] Unit-test failure after r237113
530         https://bugs.webkit.org/show_bug.cgi?id=193669
531
532         Reviewed by Michael Catanzaro.
533
534         * BuildSlaveSupport/build.webkit.org-config/factories.py:
535         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
536         multiple or zero flags.
537
538 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
539
540         Cache bytecode to disk
541         https://bugs.webkit.org/show_bug.cgi?id=192782
542         <rdar://problem/46084932>
543
544         Reviewed by Keith Miller.
545
546         Add test helper to execute bytecode-cache tests: it executes each test
547         twice, the first with JSC_diskCachePath set to a temporary directory
548         and second with JSC_forceDiskCache=true (in addition to the cache path)
549         to guarantee that only the disk cache is being used and no new
550         UnlinkedCodeBlocks are being created.
551
552         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
553         * Scripts/run-jsc-stress-tests:
554
555 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
556
557         [css-logical] Implement flow-relative margin, padding and border shorthands
558         https://bugs.webkit.org/show_bug.cgi?id=188697
559
560         Reviewed by Simon Fraser and Antti Koivisto.
561
562         * DumpRenderTree/TestOptions.cpp:
563         (TestOptions::TestOptions):
564         * DumpRenderTree/TestOptions.h:
565         * DumpRenderTree/mac/DumpRenderTree.mm:
566         (setWebPreferencesForTestOptions):
567         Allow tests to enable the CSSLogicalEnabled flag in WK1.
568
569         * Scripts/webkitpy/style/checkers/jsonchecker.py:
570         (JSONCSSPropertiesChecker.check_codegen_properties):
571         Allow CSS property definitions to have a 'runtime-flag' parameter which
572         disables the property when the specified runtime flag is disabled.
573
574 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
575
576         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
577         https://bugs.webkit.org/show_bug.cgi?id=193643
578
579         Reviewed by Michael Catanzaro.
580
581         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
582         * wpe/jhbuild.modules: Ditto.
583
584 2019-01-21  Zalan Bujtas  <zalan@apple.com>
585
586         [LFC][Floats] Take float top position into account when computing containing block height.
587         https://bugs.webkit.org/show_bug.cgi?id=193655
588
589         Reviewed by Antti Koivisto.
590
591         * LayoutReloaded/misc/LFC-passing-tests.txt:
592
593 2019-01-21  David Kilzer  <ddkilzer@apple.com>
594
595         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
596         <https://webkit.org/b/193645>
597         <rdar://problem/47421574>
598
599         Reviewed by Alex Christensen.
600
601         - Now checks for local soft-linking of all frameworks that have
602           their own *SoftLinking.{cpp,h,mm} files.
603         - Changes softlink/uikit warning to softlink/framework.
604
605         * Scripts/webkitpy/style/checkers/cpp.py:
606         (check_language):
607         (CppChecker):
608         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
609         (CppStyleTest):
610
611 2019-01-20  Saam Barati  <sbarati@apple.com>
612
613         Rollout r240210: It broke tests on iOS
614         https://bugs.webkit.org/show_bug.cgi?id=193640
615
616         Unreviewed.
617
618         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
619         * Scripts/run-jsc-stress-tests:
620
621 2019-01-20  chris fleizach  <cfleizach@apple.com>
622
623         AX: Support returning relative frames for accessibility
624         https://bugs.webkit.org/show_bug.cgi?id=193414
625         <rdar://problem/47268501>
626
627         Reviewed by Zalan Bujtas.
628
629         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
630         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
631         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
632         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
633         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
634         (WTR::attributesOfElement):
635         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
636
637 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
638
639         Unreviewed, add my new email address
640
641         * Scripts/webkitpy/common/config/contributors.json:
642
643 2019-01-19  Zalan Bujtas  <zalan@apple.com>
644
645         [LFC][BFC] <body>'s overflow property value is propagated to viewport
646         https://bugs.webkit.org/show_bug.cgi?id=193617
647
648         Reviewed by Antti Koivisto.
649
650         * LayoutReloaded/misc/LFC-passing-tests.txt:
651
652 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
653
654         Unreviewed, rolling out r240209.
655
656         Broke GTK/WPE injected bundle
657
658         Reverted changeset:
659
660         "AX: Support returning relative frames for accessibility"
661         https://bugs.webkit.org/show_bug.cgi?id=193414
662         https://trac.webkit.org/changeset/240209
663
664 2019-01-12  Dan Bernstein  <mitz@apple.com>
665
666         [Cocoa] Avoid importing directly from subumbrella frameworks
667         https://bugs.webkit.org/show_bug.cgi?id=186016
668         <rdar://problem/40591038>
669
670         Reviewed by Sam Weinig.
671
672         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
673           LaunchServices header.
674         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
675           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
676         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
677           when using SDKs earlier than 10.13.
678         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
679           and OTHER_CPLUSPLUSFLAGS.
680         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
681           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
682         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
683           LaunchServices header.
684
685 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
686
687         Cache bytecode to disk
688         https://bugs.webkit.org/show_bug.cgi?id=192782
689         <rdar://problem/46084932>
690
691         Reviewed by Keith Miller.
692
693         Add test helper to execute bytecode-cache tests: it executes each test
694         twice, the first with JSC_diskCachePath set to a temporary directory
695         and second with JSC_forceDiskCache=true (in addition to the cache path)
696         to guarantee that only the disk cache is being used and no new
697         UnlinkedCodeBlocks are being created.
698
699         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
700         * Scripts/run-jsc-stress-tests:
701
702 2019-01-20  chris fleizach  <cfleizach@apple.com>
703
704         AX: Support returning relative frames for accessibility
705         https://bugs.webkit.org/show_bug.cgi?id=193414
706         <rdar://problem/47268501>
707
708         Reviewed by Zalan Bujtas.
709
710         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
711         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
712         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
713         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
714         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
715         (WTR::attributesOfElement):
716         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
717
718 2019-01-20  Antoine Quint  <graouts@apple.com>
719
720         Add a POINTER_EVENTS feature flag
721         https://bugs.webkit.org/show_bug.cgi?id=193577
722         <rdar://problem/47408511>
723
724         Unreviewed. Also enable Pointer Events for iosmac.
725
726         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
727
728 2019-01-19  Zalan Bujtas  <zalan@apple.com>
729
730         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
731         https://bugs.webkit.org/show_bug.cgi?id=193613
732
733         Reviewed by Antti Koivisto.
734
735         * LayoutReloaded/misc/LFC-passing-tests.txt:
736
737 2019-01-19  Antoine Quint  <graouts@apple.com>
738
739         Add a POINTER_EVENTS feature flag
740         https://bugs.webkit.org/show_bug.cgi?id=193577
741
742         Reviewed by Dean Jackson.
743
744         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
745
746 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
747
748         Disable the run-jsc-stress-test remote host key check [second round].
749         https://bugs.webkit.org/show_bug.cgi?id=192988
750
751         Reviewed by Dewei Zhu.
752
753         * Scripts/run-jsc-stress-tests:
754
755 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
756
757         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
758         https://bugs.webkit.org/show_bug.cgi?id=193597
759
760         Reviewed by Lucas Forschler.
761
762         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
763
764 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
765
766         [build.webkit.org] api tests failures are incorrectly named as unit test failures
767         https://bugs.webkit.org/show_bug.cgi?id=193595
768
769         Reviewed by Lucas Forschler.
770
771         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
772         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
773         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
774
775 2019-01-18  Chris Dumez  <cdumez@apple.com>
776
777         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
778         https://bugs.webkit.org/show_bug.cgi?id=193588
779         <rdar://problem/47131566>
780
781         Reviewed by Alex Christensen.
782
783         Add layout test coverage.
784
785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
786
787 2019-01-18  Jer Noble  <jer.noble@apple.com>
788
789         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
790         https://bugs.webkit.org/show_bug.cgi?id=189553
791
792         Reviewed by Tim Horton.
793
794         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
795
796         * ContentExtensionTester/Configurations/Base.xcconfig:
797         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
798         * DumpRenderTree/mac/Configurations/Base.xcconfig:
799         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
800         * ImageDiff/cg/Configurations/Base.xcconfig:
801         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
802         * MiniBrowser/Configurations/Base.xcconfig:
803         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
804         * MobileMiniBrowser/Configurations/Base.xcconfig:
805         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
806         * Scripts/webkitpy/style/checker.py:
807         (_all_categories):
808         (FileType):
809         (CheckerDispatcher._file_type):
810         (CheckerDispatcher._create_checker):
811         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
812         (SDKVariantChecker):
813         (SDKVariantChecker.__init__):
814         (SDKVariantChecker.check):
815         * TestWebKitAPI/Configurations/Base.xcconfig:
816         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
817         * WebEditingTester/Configurations/Base.xcconfig:
818         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
819         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
820         * WebKitTestRunner/Configurations/Base.xcconfig:
821         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
822         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
823         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
824
825 2019-01-18  David Kilzer  <ddkilzer@apple.com>
826
827         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
828         <https://webkit.org/b/193568>
829         <rdar://problem/47381130>
830
831         Reviewed by Alex Christensen.
832
833         Make sure no one re-introduces UIKit soft-linking by adding a
834         style rule.
835
836         * Scripts/webkitpy/style/checkers/cpp.py:
837         (check_language): Add softlink/uikit check.
838         (CppChecker): Enable softlink/uikit check.
839         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
840         (CppStyleTest): Add test for softlink/uikit.
841
842 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
843
844         [GTK] install-dependencies tool looks for libunistring-dev for dnf
845         https://bugs.webkit.org/show_bug.cgi?id=193584
846
847         Change "-dev" to "-devel".
848
849         Reviewed by Michael Catanzaro.
850
851         * gtk/install-dependencies:
852
853 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
854
855         webkitpy: Add iPhone and iPad ports
856         https://bugs.webkit.org/show_bug.cgi?id=193537
857         <rdar://problem/47353390>
858
859         Reviewed by Lucas Forschler.
860
861         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
862         ports. Note that this separation is optional, the --ios-simulator command remains.
863
864         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
865         (RunTest.test_device_type_test_division): Drive-by fix.
866         (RunTest.test_device_type_specific_listing): Ditto.
867         (RunTest.test_ipad_test_division):
868         (RunTest):
869         (RunTest.test_ipad_listing):
870         * Scripts/webkitpy/port/factory.py:
871         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
872         (PortFactory):
873         * Scripts/webkitpy/port/ios_simulator.py:
874         (IPhoneSimulatorPort):
875         (IPadSimulatorPort):
876
877 2019-01-18  Chris Dumez  <cdumez@apple.com>
878
879         Regression(PSON) Scroll position is not always restored properly when navigating back
880         https://bugs.webkit.org/show_bug.cgi?id=193578
881         <rdar://problem/47386331>
882
883         Reviewed by Tim Horton.
884
885         Add API test coverage.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
888
889 2019-01-18  Youenn Fablet  <youenn@apple.com>
890
891         Add a new SPI to request for cache storage quota increase
892         https://bugs.webkit.org/show_bug.cgi?id=193323
893
894         Reviewed by Alex Christensen.
895
896         Implement WebsiteDataStore quota delegate to handle quota requests.
897         By default, do not update quota.
898         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
899
900         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
901         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
902         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
903         * WebKitTestRunner/InjectedBundle/TestRunner.h:
904         * WebKitTestRunner/TestController.cpp:
905         (WTR::TestController::allowCacheStorageQuotaIncrease):
906         * WebKitTestRunner/TestController.h:
907         * WebKitTestRunner/TestInvocation.cpp:
908         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
909         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
910         (-[CacheStorageQuotaManager init]):
911         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
912         (WTR::initializeWebViewConfiguration):
913         (WTR::TestController::cocoaResetStateToConsistentValues):
914         (WTR::TestController::allowCacheStorageQuotaIncrease):
915
916 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
917
918         [ews-build] Pass owner to the triggered builds
919         https://bugs.webkit.org/show_bug.cgi?id=193574
920
921         Reviewed by Lucas Forschler.
922
923         * BuildSlaveSupport/ews-build/factories.py:
924         (BuildFactory.propertiesToPassToTriggers):
925
926 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
927
928         [ews-app] Send patch author as a build property
929         https://bugs.webkit.org/show_bug.cgi?id=193560
930
931         Reviewed by Lucas Forschler.
932
933         * BuildSlaveSupport/ews-app/ews/fetcher.py:
934         (BugzillaPatchFetcher.fetch):
935
936 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
937
938         webkitpy: Implement device type specific expected results (Follow-up fix)
939         https://bugs.webkit.org/show_bug.cgi?id=192162
940         <rdar://problem/46345449>
941
942         Unreviewed infrastructure fix.
943
944         * Scripts/webkitpy/layout_tests/controllers/manager.py:
945         (Manager.run): Don't boot a device if no tests are available to run on it.
946
947 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
948
949         webkitpy: Implement device type specific expected results (Follow-up fix)
950         https://bugs.webkit.org/show_bug.cgi?id=192162
951         <rdar://problem/46345449>
952
953         Unreviewed infrastructure fix.
954
955         * Scripts/webkitpy/api_tests/manager.py:
956         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
957
958 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
959
960         webkitpy: Implement device type specific expected results (Part 2)
961         https://bugs.webkit.org/show_bug.cgi?id=192162
962         <rdar://problem/46345449>
963
964         Rubber-stamped by Aakash Jain.
965
966         This change uses device_type to select a different set of TestExpectation files based on the type of device running
967         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
968         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
969
970         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
971         (LayoutTestFinder.find_tests): Pass device_type through.
972         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
973         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
974         * Scripts/webkitpy/layout_tests/controllers/manager.py:
975         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
976         (Manager._collect_tests): Pass device type to test finder.
977         (Manager._needs_web_platform_test):
978         (Manager._prepare_lists): Index _expectations by device type.
979         (Manager._test_input_for_file):
980         (Manager._test_is_slow): Ditto.
981         (Manager._test_should_dump_jsconsolelog_in_stderr):
982         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
983         (Manager._get_test_inputs):
984         (Manager._update_worker_count):
985         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
986         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
987         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
988         the one which runs the test.
989         (Manager._run_test_subset):
990         (Manager._run_tests): Index _expectations by current_device_type.
991         (Manager._print_expectation_line_for_test): Ditto.
992         (Manager._print_expectations_for_subset): Ditto.
993         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
994         Unlike run, this function will behave the same regardless of what devices are available.
995         (Manager._custom_device_for_test): Deleted.
996         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
997         (ManagerTest.test_uses_custom_device): Deleted.
998         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
999         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1000         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1001         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1002         all of the expectations.
1003         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1004         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1005         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1006         (TestExpectations.__init__): Allow device_type to be passed through.
1007         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1008         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1009         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1010         (summarize_results):
1011         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1012         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1013         a test ran with, one must check all expectations to find the first non-skip expectation.
1014         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1015         (RunTest.test_device_type_test_division):
1016         (RunTest):
1017         (RunTest.test_device_type_specific_listing):
1018         * Scripts/webkitpy/port/base.py:
1019         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1020         (Port.supported_device_types): The result of this function will change based on what devices are available.
1021         * Scripts/webkitpy/port/device_port.py:
1022         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1023         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1024         can be used.
1025         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1026         any, or the DEFAULT_DEVICE_TYPES of the port.
1027         * Scripts/webkitpy/port/ios.py:
1028         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1029         * Scripts/webkitpy/port/ios_simulator.py:
1030         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1031         * Scripts/webkitpy/port/watch.py:
1032         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1033         * Scripts/webkitpy/port/watch_simulator.py:
1034         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1035         * Scripts/webkitpy/xcode/device_type.py:
1036         (DeviceType):
1037         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1038
1039 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1040
1041         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1042         https://bugs.webkit.org/show_bug.cgi?id=193575
1043
1044         Reviewed by Michael Catanzaro.
1045
1046         Allow the script to run without explicit port argument because
1047         it's specific to the WPE port anyway.
1048
1049         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1050         and simplify the rest of the code accordingly.
1051
1052 2019-01-18  Charlie Turner  <cturner@igalia.com>
1053
1054         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1055         https://bugs.webkit.org/show_bug.cgi?id=192229
1056
1057         Reviewed by Xabier Rodriguez-Calvar.
1058
1059         * MiniBrowser/wpe/main.cpp:
1060         (main): Enable encrypted-media by default.
1061
1062 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1063
1064         [Flatpak] Missing KeyboardInterrupt exception handler
1065         https://bugs.webkit.org/show_bug.cgi?id=193570
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * flatpak/flatpakutils.py:
1070         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1071
1072 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1073
1074         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1075         https://bugs.webkit.org/show_bug.cgi?id=193564
1076
1077         Reviewed by Antti Koivisto.
1078
1079         * LayoutReloaded/misc/LFC-passing-tests.txt:
1080
1081 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1082
1083         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1084         https://bugs.webkit.org/show_bug.cgi?id=193562
1085
1086         Reviewed by Antti Koivisto.
1087
1088         * LayoutReloaded/misc/LFC-passing-tests.txt:
1089
1090 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1091
1092         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1093         https://bugs.webkit.org/show_bug.cgi?id=193555
1094
1095         Reviewed by Antti Koivisto.
1096
1097         * LayoutReloaded/misc/LFC-passing-tests.txt:
1098
1099 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1100
1101         [WPE] Add Qt extension
1102         https://bugs.webkit.org/show_bug.cgi?id=191464
1103
1104         Reviewed by Carlos Garcia Campos.
1105
1106         MiniBrowser and API tests for the WPE Qt API. To run the
1107         MiniBrowser a new script is introduced. Example invocation:
1108
1109         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1110
1111         Also note-worthy is the introduction of the python2-subprocess32
1112         dependency to run the GLib API tests.
1113
1114         * MiniBrowser/wpe/CMakeLists.txt:
1115         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1116         * MiniBrowser/wpe/qt/main.cpp: Added.
1117         (main):
1118         * MiniBrowser/wpe/qt/main.qml: Added.
1119         * MiniBrowser/wpe/qt/qml.qrc: Added.
1120         * Scripts/run-gtk-tests:
1121         (GtkTestRunner.is_google_test):
1122         (GtkTestRunner):
1123         (GtkTestRunner.is_qt_test):
1124         * Scripts/run-qt-wpe-minibrowser: Added.
1125         * Scripts/run-wpe-tests:
1126         (WPETestRunner):
1127         (WPETestRunner.is_google_test):
1128         (WPETestRunner.is_qt_test):
1129         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1130         (TestLoad::main):
1131         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1132         (TestLoadHtml::main):
1133         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1134         (TestLoadRequest::main):
1135         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1136         (TestRunJavaScript::main):
1137         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1138         (waitForSignal):
1139         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1140         (LoadSpy::LoadSpy):
1141         (LoadSpy::~LoadSpy):
1142         (LoadSpy::onLoadingChanged):
1143         (LoadStartedCatcher::LoadStartedCatcher):
1144         (LoadStartedCatcher::~LoadStartedCatcher):
1145         (LoadStartedCatcher::onLoadingChanged):
1146         (waitForLoadSucceeded):
1147         (waitForLoadFailed):
1148         * TestWebKitAPI/glib/CMakeLists.txt:
1149         * flatpak/flatpakutils.py:
1150         (WebkitFlatpak.load_from_args):
1151         (WebkitFlatpak.__init__):
1152         (WebkitFlatpak.clean_args):
1153         (WebkitFlatpak.run_in_sandbox):
1154         * flatpak/org.webkit.CommonModules.yaml:
1155         * flatpak/org.webkit.WPE.yaml:
1156         * flatpak/org.webkit.WPEModules.yaml:
1157         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1158         * flatpak/org.webkit.WebKit.yaml:
1159         * glib/api_test_runner.py:
1160         (TestRunner._run_test_qt):
1161         (TestRunner.is_qt_test):
1162         (TestRunner._run_test):
1163
1164 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1165
1166         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1167         https://bugs.webkit.org/show_bug.cgi?id=193494
1168         <rdar://problem/46859627>
1169
1170         Reviewed by Simon Fraser and Tim Horton.
1171
1172         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1173         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1174
1175         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1176         (WTR::UIScriptController::contentOffsetX const):
1177         (WTR::UIScriptController::contentOffsetY const):
1178         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1179         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1180         (WTR::UIScriptController::contentOffsetX const):
1181         (WTR::UIScriptController::contentOffsetY const):
1182         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1183
1184         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1185
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::updateTestOptionsFromTestHeader):
1188         * WebKitTestRunner/TestOptions.h:
1189         (WTR::TestOptions::hasSameInitializationOptions const):
1190         * WebKitTestRunner/ios/TestControllerIOS.mm:
1191         (WTR::TestController::platformResetStateToConsistentValues):
1192         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1193         (WTR::UIScriptController::contentOffsetX const):
1194         (WTR::UIScriptController::contentOffsetY const):
1195
1196 2019-01-17  Truitt Savell  <tsavell@apple.com>
1197
1198         Unreviewed, rolling out r240124.
1199
1200         This commit broke an internal build.
1201
1202         Reverted changeset:
1203
1204         "SDK_VARIANT build destinations should be separate from non-
1205         SDK_VARIANT builds"
1206         https://bugs.webkit.org/show_bug.cgi?id=189553
1207         https://trac.webkit.org/changeset/240124
1208
1209 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1210
1211         Fix string concatenation API test after r239920
1212         https://bugs.webkit.org/show_bug.cgi?id=193551
1213         <rdar://problem/47359304>
1214
1215         Reviewed by Youenn Fablet.
1216
1217         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1218         (TestWebKitAPI::TEST):
1219         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1220         in WebKit's build configuration like it apparently is on Linux.
1221
1222 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1223
1224         [ews-build] validate-patch should handle the case when bug_id is None
1225         https://bugs.webkit.org/show_bug.cgi?id=193547
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/ews-build/steps.py:
1230         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1231         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1232
1233 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1234
1235         [ews-build] Add patch author information in build
1236         https://bugs.webkit.org/show_bug.cgi?id=193465
1237
1238         Reviewed by Lucas Forschler.
1239
1240         * BuildSlaveSupport/ews-build/steps.py:
1241         (ValidatePatch._is_patch_obsolete):
1242
1243 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1244
1245         [ews-build] Pass bug_id to the triggered builds
1246         https://bugs.webkit.org/show_bug.cgi?id=193548
1247
1248         Reviewed by Lucas Forschler.
1249
1250         * BuildSlaveSupport/ews-build/factories.py:
1251         (BuildFactory.propertiesToPassToTriggers):
1252
1253 2019-01-17  Jer Noble  <jer.noble@apple.com>
1254
1255         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1256         https://bugs.webkit.org/show_bug.cgi?id=189553
1257
1258         Reviewed by Tim Horton.
1259
1260         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1261
1262         * ContentExtensionTester/Configurations/Base.xcconfig:
1263         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1264         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1265         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1266         * ImageDiff/cg/Configurations/Base.xcconfig:
1267         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1268         * MiniBrowser/Configurations/Base.xcconfig:
1269         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1270         * MobileMiniBrowser/Configurations/Base.xcconfig:
1271         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1272         * Scripts/webkitpy/style/checker.py:
1273         (_all_categories):
1274         (FileType):
1275         (CheckerDispatcher._file_type):
1276         (CheckerDispatcher._create_checker):
1277         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1278         (SDKVariantChecker):
1279         (SDKVariantChecker.__init__):
1280         (SDKVariantChecker.check):
1281         * TestWebKitAPI/Configurations/Base.xcconfig:
1282         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1283         * WebEditingTester/Configurations/Base.xcconfig:
1284         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1285         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1286         * WebKitTestRunner/Configurations/Base.xcconfig:
1287         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1288         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1289         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1290
1291 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1292
1293         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1294         https://bugs.webkit.org/show_bug.cgi?id=193534
1295
1296         Reviewed by Antti Koivisto.
1297
1298         * LayoutReloaded/misc/LFC-passing-tests.txt:
1299
1300 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1301
1302         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1303         https://bugs.webkit.org/show_bug.cgi?id=193528
1304
1305         Reviewed by Antti Koivisto.
1306
1307         * LayoutReloaded/misc/LFC-passing-tests.txt:
1308
1309 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1310
1311         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1312         https://bugs.webkit.org/show_bug.cgi?id=193520
1313
1314         Reviewed by Antti Koivisto.
1315
1316         * LayoutReloaded/misc/LFC-passing-tests.txt:
1317
1318 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1319
1320         [ews-build] unapply-patch step should not update source
1321         https://bugs.webkit.org/show_bug.cgi?id=193234
1322
1323         Reviewed by Lucas Forschler.
1324
1325         * BuildSlaveSupport/ews-build/steps.py:
1326         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1327         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1328
1329 2019-01-16  Youenn Fablet  <youenn@apple.com>
1330
1331         Add a new SPI for controlling getUserMedia
1332         https://bugs.webkit.org/show_bug.cgi?id=192793
1333
1334         Reviewed by Eric Carlson.
1335
1336         * MiniBrowser/mac/WK2BrowserWindowController.m:
1337         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1338         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1339         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1340         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1341         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1342         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1343         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1344         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1345         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1346         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1347         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1348         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1349         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1350         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1351
1352 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1353
1354         [LFC][BFC] Inflow non-replaced used width should not be negative.
1355         https://bugs.webkit.org/show_bug.cgi?id=193495
1356
1357         Reviewed by Antti Koivisto.
1358
1359         * LayoutReloaded/misc/LFC-passing-tests.txt:
1360
1361 2019-01-16  Chris Dumez  <cdumez@apple.com>
1362
1363         Regression(PSON) View becomes blank after click a cross-site download link
1364         https://bugs.webkit.org/show_bug.cgi?id=193361
1365         <rdar://problem/47099573>
1366
1367         Reviewed by Geoffrey Garen.
1368
1369         Add API test coverage.
1370
1371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1372         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1373
1374 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1375
1376         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1377         https://bugs.webkit.org/show_bug.cgi?id=193470
1378
1379         Reviewed by Antti Koivisto.
1380
1381         * LayoutReloaded/misc/LFC-passing-tests.txt:
1382
1383 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1384
1385         [LFC] Adjust margin box verification.
1386         https://bugs.webkit.org/show_bug.cgi?id=193482
1387
1388         Reviewed by Antti Koivisto.
1389
1390         * LayoutReloaded/misc/LFC-passing-tests.txt:
1391
1392 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1393
1394         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1395         https://bugs.webkit.org/show_bug.cgi?id=193451
1396
1397         Reviewed by Geoffrey Garen.
1398
1399         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1400         (TEST):
1401         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1402         (runWebsiteDataStoreCustomPaths):
1403
1404 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1405
1406         webkitpy: Support boolean simctl isAvailable
1407         https://bugs.webkit.org/show_bug.cgi?id=193472
1408         <rdar://problem/47296150>
1409
1410         Reviewed by Ryosuke Niwa.
1411
1412         * Scripts/webkitpy/xcode/simulated_device.py:
1413         (SimulatedDeviceManager._create_runtimes):
1414         (SimulatedDeviceManager._create_device_with_runtime):
1415
1416 2019-01-15  Chris Dumez  <cdumez@apple.com>
1417
1418         Unreviewed, rolling out r239993, r239995, r239997, and
1419         r239999.
1420
1421         Caused assertions under
1422         ViewGestureController::disconnectFromProcess()
1423
1424         Reverted changesets:
1425
1426         "Regression(PSON) View becomes blank after click a cross-site
1427         download link"
1428         https://bugs.webkit.org/show_bug.cgi?id=193361
1429         https://trac.webkit.org/changeset/239993
1430
1431         "Unreviewed iOS build fix after r239993."
1432         https://trac.webkit.org/changeset/239995
1433
1434         "Fix iOS build after r239993"
1435         https://bugs.webkit.org/show_bug.cgi?id=193361
1436         https://trac.webkit.org/changeset/239997
1437
1438         "Unreviewed, revert part of r239997 as it is not needed to fix
1439         the build."
1440         https://trac.webkit.org/changeset/239999
1441
1442 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1443
1444         Cannot tab out of WKWebView on macOS
1445         https://bugs.webkit.org/show_bug.cgi?id=161448
1446         <rdar://problem/28100085>
1447
1448         Reviewed by Dean Jackson.
1449
1450         Add a test that tabbing into and out of WKWebView works correctly.
1451
1452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1453         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1454         (WebKit2_CommandBackForwardTest::SetUp):
1455         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1456         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1457         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1458         (-[FocusableView canBecomeKeyView]):
1459         (TEST):
1460         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1461         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1462         (-[OffscreenWindow initWithSize:]):
1463         (-[OffscreenWindow isKeyWindow]):
1464         (-[OffscreenWindow isVisible]):
1465         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1466         (TestWebKitAPI::PlatformWebView::initialize):
1467         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1468         (-[ActiveOffscreenWindow isVisible]): Deleted.
1469         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1470
1471 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1472
1473         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1474         https://bugs.webkit.org/show_bug.cgi?id=193459
1475
1476         Reviewed by Mark Lam.
1477
1478         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1479         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1480
1481 2019-01-15  Chris Dumez  <cdumez@apple.com>
1482
1483         Regression(PSON) View becomes blank after click a cross-site download link
1484         https://bugs.webkit.org/show_bug.cgi?id=193361
1485         <rdar://problem/47099573>
1486
1487         Reviewed by Geoff Garen.
1488
1489         Add API test coverage.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1492         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1493
1494 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1495
1496         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1497         https://bugs.webkit.org/show_bug.cgi?id=193448
1498
1499         Reviewed by Antti Koivisto.
1500
1501         * LayoutReloaded/misc/LFC-passing-tests.txt:
1502
1503 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1504
1505         webkitpy: Implement device type specific expected results (Part 1)
1506         https://bugs.webkit.org/show_bug.cgi?id=192162
1507
1508         Reviewed by Lucas Forschler.
1509
1510         Device type specific expected results covers two related ideas. The first (covered by this change)
1511         is where to search for -expected.* files. The second is which tests to run based on the
1512         TestExpectations.txt file.
1513
1514         After this change, the baseline search path will be determined by the type of device running a
1515         test. Device type will be passed into any function which picks a file based on the baseline search
1516         path.
1517
1518         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1519         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1520         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1521         (Manager.run): Print baseline search path for each round of devices.
1522         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1523         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1524         (SingleTestRunner._expected_driver_output): Ditto.
1525         (SingleTestRunner._driver_input): Ditto.
1526         * Scripts/webkitpy/layout_tests/views/printing.py:
1527         (Printer.print_config): Move printing of baseline search path to a separate function.
1528         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1529         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1530         (Testprinter.test_print_config):
1531         (Testprinter.test_print_baseline_search_path):
1532         * Scripts/webkitpy/port/base.py:
1533         (Port.baseline_search_path): Pass device_type through.
1534         (Port._expected_baselines_for_suffixes): Ditto.
1535         (Port.expected_baselines): Ditto.
1536         (Port.expected_filename): Ditto.
1537         (Port.expected_checksum): Ditto.
1538         (Port.expected_image): Ditto.
1539         (Port.expected_audio): Ditto.
1540         (Port.expected_text): Ditto.
1541         (Port.reference_files): Ditto.
1542         (Port.tests): Ditto.
1543         (Port._expanded_paths): Ditto.
1544         (Port.skipped_layout_tests): Ditto.
1545         (Port.expectations_dict): Ditto.
1546         (Port._port_specific_expectations_files): Ditto.
1547         (Port.expectations_files): Ditto.
1548         (Port.test_search_path): Ditto.
1549         (Port._tests_for_other_platforms): Ditto.
1550         * Scripts/webkitpy/port/base_unittest.py:
1551         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1552         (PortTest.test_nonexistant_expectations): Ditto.
1553         (test_ref_tests_platform_directory): Ditto.
1554         * Scripts/webkitpy/port/darwin.py:
1555         (DarwinPort._port_specific_expectations_files): Accept device_type.
1556         * Scripts/webkitpy/port/driver.py:
1557         (DriverProxy):
1558         (DriverProxy.host): Expose _target_host for device_type information.
1559         * Scripts/webkitpy/port/gtk.py:
1560         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1561         * Scripts/webkitpy/port/ios.py:
1562         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1563         * Scripts/webkitpy/port/mac.py:
1564         (MacPort. default_baseline_search_path): Ditto.
1565         * Scripts/webkitpy/port/port_testcase.py:
1566         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1567         * Scripts/webkitpy/port/test.py:
1568         * Scripts/webkitpy/port/watch.py:
1569         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1570         * Scripts/webkitpy/port/win.py:
1571         (WinPort.test_search_path): Accept, but do not use, device_type.
1572         * Scripts/webkitpy/port/wpe.py:
1573         (WPEPort._port_specific_expectations_files): Ditto.
1574         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1575         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1576
1577 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1578
1579         [LFC] Use the containing block's padding box to position out-of-flow elements.
1580         https://bugs.webkit.org/show_bug.cgi?id=193431
1581
1582         Reviewed by Antti Koivisto.
1583
1584         * LayoutReloaded/misc/LFC-passing-tests.txt:
1585
1586 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1587
1588         Move a test implementation file that got misplaced in the Xcode project
1589
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591
1592 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1593
1594         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1595         r239913, and r239914.
1596         https://bugs.webkit.org/show_bug.cgi?id=193407
1597
1598         These revisions caused an internal failure (Requested by
1599         Truitt on #webkit).
1600
1601         Reverted changesets:
1602
1603         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1604         https://bugs.webkit.org/show_bug.cgi?id=186016
1605         https://trac.webkit.org/changeset/239901
1606
1607         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1608         https://trac.webkit.org/changeset/239909
1609
1610         "Tried to fix the build."
1611         https://trac.webkit.org/changeset/239910
1612
1613         "Fixed iOS builds after r239910."
1614         https://trac.webkit.org/changeset/239912
1615
1616         "More build fixing."
1617         https://trac.webkit.org/changeset/239913
1618
1619         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1620         https://trac.webkit.org/changeset/239914
1621
1622 2019-01-14  Mark Lam  <mark.lam@apple.com>
1623
1624         Re-enable ability to build --cloop builds.
1625         https://bugs.webkit.org/show_bug.cgi?id=192955
1626         <rdar://problem/46882363>
1627
1628         Reviewed by Saam barati and Keith Miller.
1629
1630         The --cloop build option was being ignored this whole time since r236381.
1631         This patch makes it possible to build CLoop builds again.
1632
1633         * Scripts/build-jsc:
1634         * Scripts/webkitperl/FeatureList.pm:
1635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1636
1637 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1638
1639         webkitpy: Expose device_type from host-like objects
1640         https://bugs.webkit.org/show_bug.cgi?id=193406
1641         <rdar://problem/47262305>
1642
1643         Reviewed by Lucas Forschler.
1644
1645         Devices should expose device_type. As a result, all host objects should
1646         provide a device_type property, even if they do not yet define a device_type.
1647
1648         * Scripts/webkitpy/common/system/systemhost.py:
1649         (SystemHost):
1650         (SystemHost.device_type):
1651         * Scripts/webkitpy/common/system/systemhost_mock.py:
1652         (MockSystemHost):
1653         (MockSystemHost.device_type):
1654         * Scripts/webkitpy/port/device.py:
1655         (Device):
1656         (Device.device_type):
1657         * Scripts/webkitpy/xcode/simulated_device.py:
1658         (SimulatedDeviceManager._find_exisiting_device_for_request):
1659         (SimulatedDeviceManager._disambiguate_device_type):
1660         (SimulatedDeviceManager._does_fulfill_request):
1661         (SimulatedDeviceManager.device_count_for_type):
1662         (SimulatedDeviceManager.initialize_devices):
1663         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1664         (test_available_devices):
1665         (test_swapping_devices):
1666
1667 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1668
1669         webkitpy: Support alternate simctl device list output (Follow-up fix)
1670         https://bugs.webkit.org/show_bug.cgi?id=193362
1671         <rdar://problem/47122965>
1672
1673         Rubber-stamped by Lucas Forschler.
1674
1675         * Scripts/webkitpy/xcode/simulated_device.py:
1676         (SimulatedDeviceManager.populate_available_devices):
1677
1678 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1679
1680         [iOS] Expose SPI to access the current sentence boundary and selection state
1681         https://bugs.webkit.org/show_bug.cgi?id=193398
1682         <rdar://problem/45893108>
1683
1684         Reviewed by Dean Jackson.
1685
1686         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1687         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1688         expected.
1689
1690         * TestWebKitAPI/EditingTestHarness.h:
1691         * TestWebKitAPI/EditingTestHarness.mm:
1692         (-[EditingTestHarness moveBackward]):
1693         (-[EditingTestHarness moveForward]):
1694         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1695
1696         Add a couple of new helper methods on EditingTestHarness.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1699         (-[SelectionChangeObserver initWithWebView:]):
1700         (-[SelectionChangeObserver webView]):
1701         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1702         (-[SelectionChangeObserver currentSelectionAttributes]):
1703
1704 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1705
1706         [LFC][BFC] Add basic box-sizing support.
1707         https://bugs.webkit.org/show_bug.cgi?id=193392
1708
1709         Reviewed by Antti Koivisto.
1710
1711         * LayoutReloaded/misc/LFC-passing-tests.txt:
1712
1713 2019-01-14  Charlie Turner  <cturner@igalia.com>
1714
1715         [WPE] API test gardening
1716         https://bugs.webkit.org/show_bug.cgi?id=193319
1717
1718         Reviewed by Michael Catanzaro.
1719
1720         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1721         passing tests.
1722
1723 2019-01-14  Charlie Turner  <cturner@igalia.com>
1724
1725         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1726         https://bugs.webkit.org/show_bug.cgi?id=192977
1727
1728         Reviewed by Carlos Garcia Campos.
1729
1730         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1731         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1732         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1733         (TestWebKitAPI::GStreamerTest::SetUp):
1734         (TestWebKitAPI::GStreamerTest::TearDown):
1735         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1736         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1737         (TestWebKitAPI::TEST_F):
1738
1739 2019-01-14  Charlie Turner  <cturner@igalia.com>
1740
1741         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1742         https://bugs.webkit.org/show_bug.cgi?id=193332
1743
1744         Reviewed by Michael Catanzaro.
1745
1746         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1747         defined as a char16_t, which changed in ICU 59, the
1748         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1749         unsigned short. This test is relying on the behaviour that
1750         UChar=unsigned short, which doesn't hold across platforms and ICU
1751         library versions. The full fix would be a special syntax for
1752         literal characters so that these ambiguities do not arise. That
1753         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1754         (TestWebKitAPI::TEST):
1755
1756 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1757
1758         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1759
1760         * Scripts/make-dist:
1761         (Distcheck.configure):
1762
1763 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1764
1765         [ews-build] Update macOS queue configurations
1766         https://bugs.webkit.org/show_bug.cgi?id=193365
1767         <rdar://problem/47221073>
1768
1769         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1770
1771         * BuildSlaveSupport/ews-build/config.json:
1772
1773 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1774
1775         [LFC] Adjust assert for statically positioned fixed elements
1776         https://bugs.webkit.org/show_bug.cgi?id=193385
1777
1778         Reviewed by Antti Koivisto.
1779
1780         * LayoutReloaded/misc/LFC-passing-tests.txt:
1781
1782 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1783
1784         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1785         https://bugs.webkit.org/show_bug.cgi?id=193387
1786
1787         Reviewed by Carlos Garcia Campos.
1788
1789         * MiniBrowser/wpe/main.cpp:
1790         (main):
1791
1792 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1793
1794         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1795         https://bugs.webkit.org/show_bug.cgi?id=191655
1796         rdar://problem/46074680
1797
1798         Reviewed by Megan Gardner.
1799
1800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1801         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1802
1803 2019-01-12  Dan Bernstein  <mitz@apple.com>
1804
1805         [Cocoa] Avoid importing directly from subumbrella frameworks
1806         https://bugs.webkit.org/show_bug.cgi?id=186016
1807         <rdar://problem/40591038>
1808
1809         Reviewed by Sam Weinig.
1810
1811         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1812           LaunchServices header.
1813         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1814           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1815         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1816           when using SDKs earlier than 10.13.
1817         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1818           and OTHER_CPLUSPLUSFLAGS.
1819         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1820           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1821         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1822           LaunchServices header.
1823
1824 2019-01-11  John Wilander  <wilander@apple.com>
1825
1826         Compile out Web API Statistics Collection
1827         https://bugs.webkit.org/show_bug.cgi?id=193370
1828         <rdar://problem/45388584>
1829
1830         Reviewed by Brent Fulgham.
1831
1832         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1833             Defined ENABLE_WEB_API_STATISTICS, off by default.
1834
1835 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1836
1837         [WPE] Add gtk-doc
1838         https://bugs.webkit.org/show_bug.cgi?id=178900
1839
1840         Reviewed by Michael Catanzaro.
1841
1842         Add Tools/gtkdoc to manifest.txt.in files.
1843         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1844
1845         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1846         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1847
1848 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1849
1850         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1851         https://bugs.webkit.org/show_bug.cgi?id=193364
1852         <rdar://problem/47214117>
1853
1854         Reviewed by Tim Horton.
1855
1856         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1857         precise, whereas dragging near the middle of the textarea does.
1858
1859         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1860         (TestWebKitAPI::TEST):
1861
1862 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1863
1864         webkitpy: Support alternate simctl device list output
1865         https://bugs.webkit.org/show_bug.cgi?id=193362
1866         <rdar://problem/47122965>
1867
1868         Reviewed by Lucas Forschler.
1869
1870         * Scripts/webkitpy/xcode/simulated_device.py:
1871         (SimulatedDeviceManager.populate_available_devices):
1872
1873 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1874
1875         [ews-build] Update macOS queue configurations
1876         https://bugs.webkit.org/show_bug.cgi?id=193365
1877
1878         Reviewed by Lucas Forschler.
1879
1880         * BuildSlaveSupport/ews-build/config.json:
1881
1882 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1883
1884         webkitpy: Incorporate device type into baseline search path
1885         https://bugs.webkit.org/show_bug.cgi?id=193356
1886         <rdar://problem/47215515>
1887
1888         Reviewed by Lucas Forschler.
1889
1890         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1891
1892         * Scripts/webkitpy/port/base.py:
1893         (Port.default_baseline_search_path): Allow device type to be passed in.
1894         * Scripts/webkitpy/port/gtk.py:
1895         (GtkPort.default_baseline_search_path): Ignore device type.
1896         * Scripts/webkitpy/port/ios.py:
1897         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1898         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1899         * Scripts/webkitpy/port/ios_device_unittest.py:
1900         (IOSDeviceTest):
1901         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1902         (IOSSimulatorTest):
1903         * Scripts/webkitpy/port/mac.py:
1904         (MacPort.default_baseline_search_path): Ignore device type.
1905         * Scripts/webkitpy/port/watch.py:
1906         (WatchPort.default_baseline_search_path): Ditto.
1907         * Scripts/webkitpy/port/win.py:
1908         (WinPort.default_baseline_search_path): Ditto.
1909         (WinCairoPort.default_baseline_search_path): Ditto.
1910         * Scripts/webkitpy/port/wpe.py:
1911         (WPEPort.default_baseline_search_path): Ditto.
1912
1913 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1914
1915         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1916         https://bugs.webkit.org/show_bug.cgi?id=193352
1917         <rdar://problem/47210736>
1918
1919         Reviewed by Lucas Forschler.
1920
1921         * Scripts/webkitpy/layout_tests/views/printing.py:
1922         (Printer.print_config): Print list on only baseline search paths which exist. 
1923         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1924         (Testprinter.test_print_config):
1925
1926 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1927
1928         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1929         https://bugs.webkit.org/show_bug.cgi?id=193340
1930
1931         Reviewed by David Kilzer.
1932
1933         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1934         (WTR::InjectedBundle::didReceiveMessageToPage):
1935         Pull the strings out into a WKRetainPtr.
1936
1937         * WebKitTestRunner/WebNotificationProvider.cpp:
1938         (WTR::WebNotificationProvider::closeWebNotification):
1939         Adopt the created value into the WKRetainPtr.
1940
1941         * WebKitTestRunner/mac/TestControllerMac.mm:
1942         (WTR::generateWhitelist):
1943         Immediately adopt a created value to avoid potential mistakes.
1944
1945 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1946
1947         Enable DFG on ARM/Linux again
1948         https://bugs.webkit.org/show_bug.cgi?id=192496
1949
1950         Reviewed by Yusuke Suzuki.
1951
1952         After changing the bytecode format DFG was disabled on all 32-bit
1953         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1954         on ARM by default.
1955
1956         * Scripts/run-jsc-stress-tests:
1957
1958 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1959
1960         Unreviewed, fix #ifdef in API test added in r239851.
1961         https://bugs.webkit.org/show_bug.cgi?id=193327
1962         rdar://problem/47093222
1963
1964         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1965
1966 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1967
1968         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1969         https://bugs.webkit.org/show_bug.cgi?id=193109
1970         <rdar://problem/44807048>
1971
1972         Reviewed by Ryosuke Niwa.
1973
1974         Introduce and respect a test option to enable the UndoManager API.
1975
1976         * WebKitTestRunner/TestController.cpp:
1977         (WTR::updateTestOptionsFromTestHeader):
1978         * WebKitTestRunner/TestOptions.h:
1979         (WTR::TestOptions::hasSameInitializationOptions const):
1980         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1981         (WTR::TestController::platformCreateWebView):
1982
1983 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1984
1985         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1986         https://bugs.webkit.org/show_bug.cgi?id=193346
1987
1988         Reviewed by Antti Koivisto.
1989
1990         * LayoutReloaded/misc/LFC-passing-tests.txt:
1991
1992 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1993
1994         Unreviewed, fix typo that breaks dashboard link.
1995
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1997         (WebKitBuildbot):
1998
1999 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2000
2001         Update macOS queue configurations
2002         https://bugs.webkit.org/show_bug.cgi?id=193329
2003
2004         Reviewed by Alexey Proskuryakov.
2005
2006         * BuildSlaveSupport/build.webkit.org-config/config.json:
2007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2008         (BubbleQueueServer):
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2011         (WebKitBuildbot):
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2013         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2014         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2015
2016 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2017
2018         MiniBrowser should be able to navigate to about:blank
2019         https://bugs.webkit.org/show_bug.cgi?id=193345
2020
2021         Reviewed by Simon Fraser.
2022
2023         * MiniBrowser/mac/BrowserWindowController.m:
2024         (-[BrowserWindowController addProtocolIfNecessary:]):
2025         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2026
2027         * MiniBrowser/mac/WK1BrowserWindowController.m:
2028         (-[WK1BrowserWindowController fetch:]):
2029         * MiniBrowser/mac/WK2BrowserWindowController.m:
2030         (-[WK2BrowserWindowController fetch:]):
2031         Clean up the code that uses this to match style.
2032
2033 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2034
2035         Remove MiniBrowser custom "Process Swap" menu item which does not work
2036         https://bugs.webkit.org/show_bug.cgi?id=193344
2037
2038         Reviewed by Simon Fraser.
2039
2040         There is a menu item under the Experimental menu that does work.
2041
2042         * MiniBrowser/mac/AppDelegate.m:
2043         (defaultConfiguration):
2044         * MiniBrowser/mac/SettingsController.h:
2045         * MiniBrowser/mac/SettingsController.m:
2046         (-[SettingsController _populateMenu]):
2047         (-[SettingsController validateMenuItem:]):
2048         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2049         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2050
2051 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2052
2053         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2054         https://bugs.webkit.org/show_bug.cgi?id=193327
2055         rdar://problem/47093222
2056
2057         Reviewed by Tim Horton.
2058
2059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2060         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2061         (TestWebKitAPI::didFinishNavigation):
2062         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2063         (TestWebKitAPI::TEST):
2064         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2065         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2066         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2067         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2068         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2069
2070 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2071
2072         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2073         https://bugs.webkit.org/show_bug.cgi?id=193338
2074         <rdar://problem/46664774>
2075
2076         Reviewed by David Kilzer.
2077
2078         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2079         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2080
2081 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2082
2083         Unreviewed, rolling out r239825.
2084         https://bugs.webkit.org/show_bug.cgi?id=193330
2085
2086         Broke tests on armv7/linux bots (Requested by guijemont on
2087         #webkit).
2088
2089         Reverted changeset:
2090
2091         "Enable DFG on ARM/Linux again"
2092         https://bugs.webkit.org/show_bug.cgi?id=192496
2093         https://trac.webkit.org/changeset/239825
2094
2095 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2096
2097         Disable the run-jsc-stress-test remote host key check.
2098         https://bugs.webkit.org/show_bug.cgi?id=192988
2099
2100         Reviewed by Alexey Proskuryakov.
2101
2102         * Scripts/run-jsc-stress-tests:
2103
2104 2019-01-10  John Wilander  <wilander@apple.com>
2105
2106         Override the session configuration for cookieAcceptPolicy
2107         https://bugs.webkit.org/show_bug.cgi?id=190925
2108         <rdar://problem/45497382>
2109
2110         Reviewed by Alexey Proskuryakov and Alex Christensen.
2111
2112         Test infrastructure for setting a first-party-only cookie policy.
2113
2114         * DumpRenderTree/TestRunner.cpp:
2115         (setOnlyAcceptFirstPartyCookiesCallback):
2116         (TestRunner::staticFunctions):
2117         * DumpRenderTree/TestRunner.h:
2118         * DumpRenderTree/mac/TestRunnerMac.mm:
2119         (TestRunner::setOnlyAcceptFirstPartyCookies):
2120         * DumpRenderTree/win/TestRunnerWin.cpp:
2121         (TestRunner::setOnlyAcceptFirstPartyCookies):
2122         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2124         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2126         * WebKitTestRunner/TestInvocation.cpp:
2127         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2128
2129 2019-01-09  Matt Rajca  <mrajca@apple.com>
2130
2131         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2132         https://bugs.webkit.org/show_bug.cgi?id=193301
2133
2134         Reviewed by Jer Noble.
2135         
2136         Added API tests.
2137
2138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2139         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2140         (TEST):
2141         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2142
2143 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2144
2145         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2146         https://bugs.webkit.org/show_bug.cgi?id=193310
2147
2148         Reviewed by Antti Koivisto.
2149
2150         * LayoutReloaded/misc/LFC-passing-tests.txt:
2151
2152 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2153
2154         Enable DFG on ARM/Linux again
2155         https://bugs.webkit.org/show_bug.cgi?id=192496
2156
2157         Reviewed by Yusuke Suzuki.
2158
2159         After changing the bytecode format DFG was disabled on all 32-bit
2160         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2161         on ARM by default.
2162
2163         * Scripts/run-jsc-stress-tests:
2164
2165 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2166
2167         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2168         https://bugs.webkit.org/show_bug.cgi?id=193271
2169
2170         Reviewed by Brent Fulgham.
2171
2172         BSTR is a special data structure created by SysAllocString, not a
2173         wchar_t null-terminated string.
2174
2175         * DumpRenderTree/win/TestRunnerWin.cpp:
2176         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2177         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2178         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2179         BSTR from wide string literals.
2180
2181 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2182
2183         Tweak wording for build/version_check style checker error
2184         https://bugs.webkit.org/show_bug.cgi?id=193256
2185
2186         Reviewed by Tim Horton.
2187
2188         * Scripts/webkitpy/style/checkers/cpp.py:
2189         (check_os_version_checks):
2190         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2191         (WebKitStyleTest.test_os_version_checks):
2192
2193 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2194
2195         [ews-build] Add link to bug along with bug title
2196         https://bugs.webkit.org/show_bug.cgi?id=193293
2197
2198         Reviewed by Lucas Forschler.
2199
2200         * BuildSlaveSupport/ews-build/steps.py:
2201         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2202         (ConfigureBuild.add_bug_id_url): Deleted.
2203         (ConfigureBuild.getBugURL): Deleted.
2204
2205 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-build] Use https for ews-build server
2208         https://bugs.webkit.org/show_bug.cgi?id=193193
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-build/steps.py:
2213
2214 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2215
2216         [ews-build] Parse and display number of style failures
2217         https://bugs.webkit.org/show_bug.cgi?id=193280
2218
2219         Reviewed by Lucas Forschler.
2220
2221         * BuildSlaveSupport/ews-build/steps.py:
2222         (CheckStyle): Use TestWithFailureCount as base class.
2223         (CheckStyle.countFailures): Count the number of style failures.
2224
2225 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2226
2227         [ews-build] use patch_id instead of ewspatchid
2228         https://bugs.webkit.org/show_bug.cgi?id=193235
2229
2230         Reviewed by Lucas Forschler.
2231
2232         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2233         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2234         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2235
2236 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2237
2238         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2239         https://bugs.webkit.org/show_bug.cgi?id=192625
2240
2241         Reviewed by Antti Koivisto.
2242
2243         * LayoutReloaded/misc/LFC-passing-tests.txt:
2244
2245 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2246
2247         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2248         https://bugs.webkit.org/show_bug.cgi?id=192841
2249
2250         Reviewed by Carlos Garcia Campos.
2251
2252         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2253         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2254         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2255
2256         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2257
2258         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2259         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2260         (WebKitWebEditorTest::testSelectionChanged):
2261         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2262         (WebKitFrameTest::testMainFrame):
2263         (WebKitFrameTest::testURI):
2264         (WebKitFrameTest::testJavaScriptContext):
2265         (WebKitFrameTest::testJavaScriptValues):
2266         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2267         (testWebViewAuthenticationRequest):
2268         (testWebViewAuthenticationLoadCancelled):
2269         (testWebViewAuthenticationFailure):
2270         (testWebViewAuthenticationStorage):
2271         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2272         (testWebViewAuthenticationProxy):
2273         (testWebViewAuthenticationProxyHTTPS):
2274         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2275         (testAutomationSessionRequestSession):
2276         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2277         (testBackForwardListNavigation):
2278         (testWebKitWebViewSessionState):
2279         (testWebKitWebViewSessionStateWithFormData):
2280         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2281         (ConsoleMessageTest::consoleMessageReceivedCallback):
2282         (testWebKitConsoleMessageConsoleAPI):
2283         (testWebKitConsoleMessageJavaScriptException):
2284         (testWebKitConsoleMessageNetworkError):
2285         (testWebKitConsoleMessageSecurityError):
2286         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2287         (testCookieManagerAcceptPolicy):
2288         (testCookieManagerCookiesChanged):
2289         (testCookieManagerPersistentStorage):
2290         (testCookieManagerPersistentStorageDeleteAll):
2291         (testCookieManagerEphemeral):
2292         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2293         (testWebKitDOMElementAutoFill):
2294         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2295         (downloadLocalFileSuccessfully):
2296         (createFileAtDestination):
2297         (testDownloadOverwriteDestinationDisallowed):
2298         (testDownloadLocalFileError):
2299         (testDownloadRemoteFile):
2300         (testDownloadRemoteFileError):
2301         (testWebViewDownloadURI):
2302         (testPolicyResponseDownload):
2303         (testPolicyResponseDownloadCancel):
2304         (testDownloadMIMEType):
2305         (contextMenuCallback):
2306         (testContextMenuDownloadActions):
2307         (testBlobDownload):
2308         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2309         (testWebKitWebEditorSelectionChanged):
2310         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2311         (testWebKitFrameMainFrame):
2312         (testWebKitFrameURI):
2313         (testWebKitFrameJavaScriptContext):
2314         (testWebKitFrameJavaScriptValues):
2315         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2316         (LoadStopTrackingTest::loadFailed):
2317         (testWebViewTitle):
2318         (testURIRequestHTTPHeaders):
2319         (testURIRequestHTTPMethod):
2320         (testURIResponseHTTPHeaders):
2321         (testRedirectToDataURI):
2322         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2323         (testProcessPerWebView):
2324         (testWebProcessLimit):
2325         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2326         (testWebViewResources):
2327         (testWebResourceLoading):
2328         (testWebResourceSuggestedFilename):
2329         (testWebResourceGetData):
2330         (testWebResourceGetDataError):
2331         (testWebViewResourcesHistoryCache):
2332         (testWebResourceSendRequest):
2333         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2334         (testSSL):
2335         (testInsecureContent):
2336         (testTLSErrorsPolicy):
2337         (testTLSErrorsRedirect):
2338         (testTLSErrorsHTTPAuth):
2339         (testLoadFailedWithTLSErrors):
2340         (testSubresourceLoadFailedWithTLSErrors):
2341         (httpsServerCallback):
2342         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2343         (testWebViewCreateNavigationData):
2344         (testWebViewJavaScriptDialogs):
2345         (testWebViewWindowProperties):
2346         (testWebViewMouseTarget):
2347         (testWebViewFileChooserRequest):
2348         (testWebViewColorChooserRequest):
2349         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2350         (testWebExtensionGetTitle):
2351         (testDocumentLoadedSignal):
2352         (testWebKitWebViewProcessCrashed):
2353         (testWebExtensionWindowObjectCleared):
2354         (testWebExtensionIsolatedWorld):
2355         (permissionRequestCallback):
2356         (didAssociateFormControlsCallback):
2357         (testWebExtensionFormControlsAssociated):
2358         (FormSubmissionTest::FormSubmissionTest):
2359         (FormSubmissionTest::testFormSubmissionResult):
2360         (testWebExtensionFormSubmissionSteps):
2361         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2362         (testNotInitialized):
2363         (testClearDatabase):
2364         (testPrivateBrowsing):
2365         (testGetFavicon):
2366         (testWebViewFavicon):
2367         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2368         (testFindControllerTextFound):
2369         (testFindControllerTextNotFound):
2370         (testFindControllerMatchCount):
2371         (testFindControllerMaxMatchCount):
2372         (testFindControllerNext):
2373         (testFindControllerPrevious):
2374         (testFindControllerCountedMatches):
2375         (testFindControllerOptions):
2376         (testFindControllerHide):
2377         (testFindControllerInstance):
2378         (testFindControllerGetters):
2379         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2380         (testNavigationPolicy):
2381         (testResponsePolicy):
2382         (testNewWindowPolicy):
2383         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2384         (testSecurityOriginBasicConstructor):
2385         (testSecurityOriginURIConstructor):
2386         (testSecurityOriginDefaultPort):
2387         (testSecurityOriginFileURI):
2388         (testOpaqueSecurityOrigin):
2389         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2390         (testWebKitSettings):
2391         (testWebKitSettingsNewWithSettings):
2392         (testWebKitSettingsUserAgent):
2393         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2394         (testWebViewNewWithUserContentManager):
2395         (isStyleSheetInjectedForURLAtPath):
2396         (isScriptInjectedForURLAtPath):
2397         (testUserContentManagerInjectedStyleSheet):
2398         (testUserContentManagerInjectedScript):
2399         (UserScriptMessageTest::scriptMessageReceived):
2400         (UserScriptMessageTest::waitUntilMessageReceived):
2401         (UserScriptMessageTest::runJavaScriptFinished):
2402         (testUserContentManagerScriptMessageReceived):
2403         (testUserContentManagerScriptMessageInWorldReceived):
2404         (testUserContentManagerScriptMessageFromDOMBindings):
2405         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2406         (testWebContextDefault):
2407         (testWebContextEphemeral):
2408         (testWebContextGetPlugins):
2409         (testWebContextURIScheme):
2410         (testWebContextSpellChecker):
2411         (testWebContextLanguages):
2412         (consoleMessageReceivedCallback):
2413         (testWebContextSecurityFileXHR):
2414         (ProxyTest::ProxyTest):
2415         (testWebContextProxySettings):
2416         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2417         (testWebViewWebContext):
2418         (testWebViewWebBackend):
2419         (testWebViewEphemeral):
2420         (testWebViewCustomCharset):
2421         (testWebViewSettings):
2422         (testWebViewRunJavaScript):
2423         (testWebViewCanShowMIMEType):
2424         (testWebViewSubmitForm):
2425         (testWebViewSave):
2426         (testWebViewPageVisibility):
2427         (testWebViewSnapshot):
2428         (testWebViewNotification):
2429         (testWebViewNotificationInitialPermissionAllowed):
2430         (testWebViewNotificationInitialPermissionDisallowed):
2431         (testWebViewIsPlayingAudio):
2432         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2433         (WebsiteDataTest::WebsiteDataTest):
2434         (WebsiteDataTest::remove):
2435         (WebsiteDataTest::clear):
2436         (testWebsiteDataConfiguration):
2437         (testWebsiteDataEphemeral):
2438         (testWebsiteDataCache):
2439         (testWebsiteDataStorage):
2440         (testWebsiteDataDatabases):
2441         (testWebsiteDataAppcache):
2442         (testWebsiteDataCookies):
2443         (testWebsiteDataDeviceIdHashSalt):
2444         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2445         (emitDocumentLoaded):
2446         (emitURIChanged):
2447         (sendRequestCallback):
2448         (contextMenuCallback):
2449         (consoleMessageSentCallback):
2450         (emitFormControlsAssociated):
2451         (formControlsAssociatedCallback):
2452         (emitFormSubmissionEvent):
2453         (willSubmitFormCallback):
2454         (windowObjectCleared):
2455         (methodCallCallback):
2456         (registerGResource):
2457         (webkit_web_extension_initialize_with_user_data):
2458         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2459         (checkLeaks):
2460         (WebProcessTest::create):
2461         (runTest):
2462         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2463         (AutocleanupsTest::testWebProcessAutocleanups):
2464         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2465         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2466         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2467         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2468         (WebKitDOMDOMWindowTest::testSignals):
2469         (WebKitDOMDOMWindowTest::testDispatchEvent):
2470         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2471         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2472         (WebKitDOMNodeFilterTest::testTreeWalker):
2473         (WebKitDOMNodeFilterTest::testNodeIterator):
2474         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2475         (WebKitDOMNodeTest::testHierarchyNavigation):
2476         (WebKitDOMNodeTest::testInsertion):
2477         (WebKitDOMNodeTest::testTagNamesNodeList):
2478         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2479         (WebKitDOMNodeTest::testDOMCache):
2480         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2481         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2482         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2483         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2484         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2485         (testUIProcessAutocleanups):
2486         (testWebProcessAutocleanups):
2487         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2488         (testContextMenuPopulateMenu):
2489         (testContextMenuDismissed):
2490         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2491         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2492         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2493         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2494         (testWebKitDOMDOMWindowSignals):
2495         (testWebKitDOMDOMWindowDispatchEvent):
2496         (testWebKitDOMDOMWindowGetComputedStyle):
2497         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2498         (testWebKitDOMNodeHierarchyNavigation):
2499         (testWebKitDOMNodeInsertion):
2500         (testWebKitDOMNodeTagNamesNodeList):
2501         (testWebKitDOMNodeTagNamesHTMLCollection):
2502         (testWebKitDOMObjectCache):
2503         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2504         (testWebKitDOMNodeFilterTreeWalker):
2505         (testWebKitDOMNodeFilterNodeIterator):
2506         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2507         (testWebKitDOMXPathNSResolverNative):
2508         (testWebKitDOMXPathNSResolverCustom):
2509         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2510         (testInspectorDefault):
2511         (testInspectorManualAttachDetach):
2512         (testInspectorCustomContainerDestroyed):
2513         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2514         (startTestServer):
2515         (testInspectorServerPageList):
2516         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2517         (OptionMenuTest::showOptionMenuCallback):
2518         (OptionMenuTest::menuCloseCallback):
2519         (OptionMenuTest::close):
2520         (OptionMenuTest::activateItem):
2521         (OptionMenuTest::selectItem):
2522         (testOptionMenuSimple):
2523         (testOptionMenuGroups):
2524         (testOptionMenuActivate):
2525         (testOptionMenuSelect):
2526         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2527         (testPrintOperationPrintSettings):
2528         (webViewPrintCallback):
2529         (testPrintOperationPrint):
2530         (testPrintCustomWidget):
2531         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2532         (checkAtspiAccessible):
2533         (testAtspiBasicHierarchy):
2534         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2535         (testWebKitCheckVersion):
2536         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2537         (testWebViewEditorCutCopyPasteNonEditable):
2538         (testWebViewEditorCutCopyPasteEditable):
2539         (testWebViewEditorSelectAllNonEditable):
2540         (testWebViewEditorSelectAllEditable):
2541         (loadContentsAndTryToCutSelection):
2542         (testWebViewEditorNonEditable):
2543         (testWebViewEditorEditable):
2544         (testWebViewEditorEditorStateTypingAttributes):
2545         (testWebViewEditorInsertImage):
2546         (testWebViewEditorCreateLink):
2547         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2548         (loadChangedCallback):
2549         (loadFailedCallback):
2550         (loadFailedWithTLSErrorsCallback):
2551         (LoadTrackingTest::LoadTrackingTest):
2552         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2553         (registerGResource):
2554         (removeNonEmptyDirectory):
2555         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2556         (Test::adoptView):
2557         (Test::~Test):
2558         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2559         (WebKitTestBus::getOrCreateConnection):
2560         (WebKitTestBus::createProxy):
2561         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2562         (WebKitTestServer::getWebSocketURIForPath const):
2563         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2564         (WebViewTest::initializeWebView):
2565         (WebViewTest::loadURI):
2566         (WebViewTest::loadHtml):
2567         (WebViewTest::loadPlainText):
2568         (WebViewTest::loadBytes):
2569         (WebViewTest::loadRequest):
2570         (WebViewTest::loadAlternateHTML):
2571         (WebViewTest::goBack):
2572         (WebViewTest::goForward):
2573         (WebViewTest::goToBackForwardListItem):
2574         (resourceGetDataCallback):
2575         (WebViewTest::mainResourceData):
2576         (WebViewTest::javascriptResultToCString):
2577         (WebViewTest::javascriptResultToNumber):
2578         (WebViewTest::javascriptResultToBoolean):
2579         (WebViewTest::javascriptResultIsNull):
2580         (WebViewTest::javascriptResultIsUndefined):
2581         (onSnapshotReady):
2582         (WebViewTest::runWebProcessTest):
2583         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2584         (WebViewTest::platformInitializeWebView):
2585         (WebViewTest::showInWindow):
2586         (WebViewTest::showInWindowAndWaitUntilMapped):
2587         (WebViewTest::mouseMoveTo):
2588         (WebViewTest::emitPopupMenuSignal):
2589         (WebViewTest::keyStroke):
2590         (WebViewTest::doMouseButtonEvent):
2591
2592 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2593
2594         [WPE] API tests can't run in flatpak environment
2595         https://bugs.webkit.org/show_bug.cgi?id=193242
2596
2597         Reviewed by Michael Catanzaro.
2598
2599         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2600         flatpakutils so that it knows which port it's dealing with.
2601         * glib/common.py: Remove build_dir globals so that subsequent
2602         calls actually take args into account.
2603         (library_build_path):
2604         (binary_build_path):
2605
2606 2019-01-08  Dean Jackson  <dino@apple.com>
2607
2608         Blob references for System Previews don't get a correct file extension
2609         https://bugs.webkit.org/show_bug.cgi?id=193268
2610         <rdar://problem/47133037>
2611
2612         Reviewed by Tim Horton.
2613
2614         New test that a Blob download of a USDZ file gets named correctly.
2615
2616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2617         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2618         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2619         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2620         (TEST):
2621         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2622
2623 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2624
2625         [WebAuthN] Support U2F HID Authenticators on macOS
2626         https://bugs.webkit.org/show_bug.cgi?id=191535
2627         <rdar://problem/47102027>
2628
2629         Reviewed by Brent Fulgham.
2630
2631         This patch:
2632         1) adds support for U2F mocking mechanism;
2633         2) updates tests to reflect U2fCommandConstructor changes.
2634
2635         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2636         (TestWebKitAPI::TEST):
2637         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2639         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2640
2641 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2642
2643         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2644         https://bugs.webkit.org/show_bug.cgi?id=193229
2645         <rdar://problem/46717097>
2646
2647         Reviewed by Tim Horton.
2648
2649         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2650         prevents a drag from starting.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2653         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2654
2655         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2656
2657 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2658   
2659         Layout test will generate a perf metric file to results dir.
2660         https://bugs.webkit.org/show_bug.cgi?id=192030
2661         <rdar://problem/32779516>
2662
2663         Reviewed by Aakash Jain.
2664
2665         Layout test running time will be collected to a perf metric file.
2666         For now, instead of outputing running time of all tests (which is huge),
2667         we aggregate them by test directories which are at most two level deep. 
2668
2669         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2670         (Manager._end_test_run):
2671         (Manager._output_perf_metrics):
2672         (Manager._print_expectation_line_for_test):
2673         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2674         (add_test_perf_metric):
2675         (test_perf_metrics):
2676         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2677         (JSONGeneratorTest.test_test_timings_trie):
2678         (JSONGeneratorTest):
2679         (JSONGeneratorTest.test_test_perf_metrics):
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2681         (RebaselineTest.test_reset_results):
2682         (RebaselineTest.test_missing_results):
2683         (RebaselineTest.test_new_baseline):
2684
2685 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2686
2687         [WPE][GTK] Add php-json to install-dependencies
2688         https://bugs.webkit.org/show_bug.cgi?id=193233
2689
2690         Reviewed by Michael Catanzaro.
2691
2692         * gtk/install-dependencies:
2693         * wpe/install-dependencies:
2694
2695 2019-01-08  Chris Dumez  <cdumez@apple.com>
2696
2697         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2698         https://bugs.webkit.org/show_bug.cgi?id=193224
2699         <rdar://problem/47097726>
2700
2701         Reviewed by Alex Christensen.
2702
2703         Add API test coverage.
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2706
2707 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2708
2709         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2710         <https://webkit.org/b/193222>
2711         <rdar://problem/46862309>
2712
2713         Reviewed by Joseph Pecoraro.
2714
2715         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2716         (WTR::executeCallback): Fix camel case of variable name.
2717         (WTR::EventSendingController::callAfterScrollingCompletes): If
2718         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2719         false, make sure to release the ScrollCompletionCallbackData
2720         object.  This fixes the leak.
2721
2722 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2723
2724         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2725         https://bugs.webkit.org/show_bug.cgi?id=193044
2726
2727         Reviewed by Daniel Bates.
2728
2729         WinCairo EWS bots are using Windows Perl. Binary files should be
2730         opened as binary mode.
2731
2732         * Scripts/svn-apply:
2733         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2734
2735 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2736
2737         [CMake] Add ENABLE_CSS_TYPED_OM option
2738         https://bugs.webkit.org/show_bug.cgi?id=193216
2739
2740         Reviewed by Michael Catanzaro.
2741
2742         * Scripts/webkitperl/FeatureList.pm:
2743
2744 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2745
2746         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2747         <https://webkit.org/b/193056>
2748
2749         Reviewed by Alex Christensen.
2750
2751         * Scripts/webkitpy/style/checker.py:
2752         - Ignore use of new runtime/retainptr check in
2753           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2754           contains tests to ensure RetainPtr<NSObject *> is compatible
2755           with RetainPtr<NSObject>.
2756
2757         * Scripts/webkitpy/style/checkers/cpp.py:
2758         (check_language):
2759         (CppChecker):
2760         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2761           was used instead of a single regex so that angle brackets
2762           could be matched up when checking the type contained within
2763           the RetainPtr<> type.
2764
2765         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2766         (CppStyleTest):
2767         - Add unit test for new runtime/retainptr check.
2768
2769         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2770         * TestWebKitAPI/EditingTestHarness.h:
2771         - Remove '*' from RetainPtr<> type.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2775           regressed in r201938.
2776
2777         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2778         (TestWebKitAPI::TEST):
2779         - Update tests to match RetainPtr.mm tests (except for the
2780           `*SimilarNSType` tests since there is no CF equivalent of
2781           RetainPtr<NSString> and RetainPtr<NSString *>).
2782
2783         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2784         (TestWebKitAPI::TEST):
2785         - Update tests to:
2786           - Not conflict by name with equivalent CF tests in
2787             RetainPtr.cpp.
2788           - Add test cases for RetainPtr<NSObject>,
2789             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2790           - Add `*SimilarNSType` tests for converting between
2791             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2792           - Change `0` to `nil` as appropriate.
2793           - Re-alphabetize the tests by name.
2794           - Add Optional<RetainPtr<>> tests.
2795           - Add retainPtr() tests.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2798         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2799         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2800         (TEST):
2801         - Remove '*' from RetainPtr<> type.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2804         (TEST(WebKit, JITEnabled)):
2805         - Add missing WTFMove().  Apparently a temporary was being
2806           created before in the argument list due to mismatched
2807           RetainPtr<> types.
2808
2809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2810         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2811         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2812         (TestWebKitAPI::TEST):
2813         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2814         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2815         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2816         (WTR::resourcesDirectoryURL):
2817         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2818         (WTR::InjectedBundle::platformInitialize):
2819         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2820         - Remove '*' from RetainPtr<> type.
2821
2822 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2823
2824         A MediaTime timescale must never be zero
2825         https://bugs.webkit.org/show_bug.cgi?id=193156
2826         <rdar://problem/32504501>
2827
2828         Reviewed by Jer Noble.
2829
2830         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2831         (TestWebKitAPI::TEST): Add tests for zero timescale.
2832
2833 2019-01-07  Youenn Fablet  <youenn@apple.com>
2834
2835         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2836         https://bugs.webkit.org/show_bug.cgi?id=193175
2837
2838         Reviewed by Chris Dumez.
2839
2840         Updated API test as we bumped the SW schema to version 4.
2841
2842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2843         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2844         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2845         (TEST):
2846
2847 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2848
2849         [Win][Clang] Fix compilation warnings of MiniBrowser
2850         https://bugs.webkit.org/show_bug.cgi?id=193029
2851
2852         Reviewed by Ross Kirsling.
2853
2854         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2855         and m_URLBarFont. Reorder member variables to fix -Wreorder
2856         warning.
2857         * MiniBrowser/win/PageLoadTestClient.cpp:
2858         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2859         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2860         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2861         m_currentURLIndex.
2862         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2863         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2864         navigationClient with '{ }' to fix the missing field warning.
2865         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2866         (initDocStruct): Changed the argument type docname to const.
2867
2868 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2869
2870         [WebAuthN] Import U2F command/response converters from Chromium
2871         https://bugs.webkit.org/show_bug.cgi?id=193150
2872         <rdar://problem/47054028>
2873
2874         Reviewed by Brent Fulgham.
2875
2876         Adds API tests.
2877
2878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2879         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2880         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2881         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2882         (TestWebKitAPI::getTestAttestationObjectBytes):
2883         (TestWebKitAPI::getTestSignResponse):
2884         (TestWebKitAPI::getTestU2fRegisterResponse):
2885         (TestWebKitAPI::TEST):
2886         (TestWebKitAPI::convertToVector): Deleted.
2887         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2888         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2889         (TestWebKitAPI::constructMakeCredentialRequest):
2890         (TestWebKitAPI::constructGetAssertionRequest):
2891         (TestWebKitAPI::TEST):
2892
2893 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2894
2895         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2896         https://bugs.webkit.org/show_bug.cgi?id=193136
2897
2898         Reviewed by Michael Catanzaro.
2899
2900         * gtk/install-dependencies:
2901         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2902         they are needed by update-webkitgtk-libs.
2903
2904 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2905
2906         Unreviewed follow-up fix to r239650
2907         https://bugs.webkit.org/show_bug.cgi?id=193140
2908         <rdar://problem/47063037>
2909
2910         Typecast patch_id to string.
2911
2912         * BuildSlaveSupport/ews-build/steps.py:
2913         (ValidatePatch._is_patch_obsolete):
2914
2915 2019-01-04  Daniel Bates  <dabates@apple.com>
2916
2917         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2918         https://bugs.webkit.org/show_bug.cgi?id=193024
2919
2920         Reviewed by Jer Noble.
2921
2922         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2923         for the bitmask type WebEventFlags as an example.
2924
2925         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2926         that can be used to register summary and synthetic child formatters for a bitmask type.
2927         For example, consider the following enum and bitmask typedefs:
2928
2929         typedef enum {
2930             A = 1 << 0,
2931             B = 1 << 1,
2932             C = 1 << 2,
2933         } SpecialFlagValues;
2934         typedef unsigned SpecialFlags;
2935
2936         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2937         __lldb_init_module():
2938
2939             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2940                     1 << 0: "A",
2941                     1 << 1: "B",
2942                     1 << 2: "C",
2943             })
2944
2945         * lldb/lldb_webkit.py:
2946         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2947         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2948         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2949         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2950         A convenience function to dynamically creaste a synthetic formatter class and summary
2951         string function for the specified bitmask type and enumerator value to name map. This
2952         function register the dynamically created class and function with LLDB.
2953
2954         (__lldb_init_module):
2955         (FlagEnumerationProvider):
2956         (FlagEnumerationProvider._enumerator_value_to_name_map):
2957         (FlagEnumerationProvider._bitmask):
2958         (FlagEnumerationProvider._update):
2959         (FlagEnumerationProvider.has_children):
2960         (FlagEnumerationProvider.num_children):
2961         (FlagEnumerationProvider.get_child_index):
2962         (FlagEnumerationProvider.get_child_at_index):
2963         (FlagEnumerationProvider.update):
2964         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2965
2966         (WTFOptionSetProvider):
2967         (WTFOptionSetProvider._enumerator_value_to_name_map):
2968         (WTFOptionSetProvider._bitmask):
2969         (WTFOptionSetProvider._update):
2970         Write in terms of the base class.
2971
2972         (RawBitmaskProviderBase):
2973         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2974         (RawBitmaskProviderBase._bitmask):
2975         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2976         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2977         {
2978             1 << 0: "A",
2979             1 << 1: "B",
2980             1 << 2: "C",
2981         }
2982         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2983         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2984
2985         (WTFOptionSetProvider.has_children): Deleted.
2986         (WTFOptionSetProvider.num_children): Deleted.
2987         (WTFOptionSetProvider.get_child_index): Deleted.
2988         (WTFOptionSetProvider.get_child_at_index): Deleted.
2989         (WTFOptionSetProvider.update): Deleted.
2990
2991 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2992
2993         [ews-build] Add build step to validate the patch before processing it
2994         https://bugs.webkit.org/show_bug.cgi?id=193140
2995
2996         Reviewed by Lucas Forschler.
2997
2998         * BuildSlaveSupport/ews-build/factories.py:
2999         (Factory.__init__): Added ValidatePatch step.
3000         * BuildSlaveSupport/ews-build/steps.py:
3001         (ValidatePatch):
3002         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3003         (ValidatePatch.get_patch_json): Get patch json data.
3004         (ValidatePatch.get_bug_json): Get bug json data.
3005         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3006         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3007         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3008         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3009         (ValidatePatch.skip_build): Skip the build.
3010         (ValidatePatch.start):
3011
3012 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3013
3014         Progress towards fixing Mac CMake build
3015         https://bugs.webkit.org/show_bug.cgi?id=193105
3016
3017         Reviewed by Don Olmstead.
3018
3019         * TestWebKitAPI/PlatformMac.cmake:
3020
3021 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3022
3023         Fix API test after r239631
3024         https://bugs.webkit.org/show_bug.cgi?id=193118
3025
3026         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3027         (TestWebKitAPI::TEST):
3028         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3029         Do the same thing via the API to fix the test.
3030
3031 2019-01-04  Jer Noble  <jer.noble@apple.com>
3032
3033         [WebKitLegacy] Media playback pauses on scroll
3034         https://bugs.webkit.org/show_bug.cgi?id=192829
3035
3036         Reviewed by Eric Carlson.
3037
3038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3039         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3040         (TestWebKitAPI::TEST):
3041         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3042         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3043         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3044         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3045         (TestWebKitAPI::TEST):
3046
3047 2019-01-04  Chris Dumez  <cdumez@apple.com>
3048
3049         Add support for toggling device orientation API support per site
3050         https://bugs.webkit.org/show_bug.cgi?id=193143
3051         <rdar://problem/46605724>
3052
3053         Reviewed by Alex Christensen.
3054
3055         Add API test coverage.
3056
3057         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3058         (-[DataMappingSchemeHandler setTaskHandler:]):
3059         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3060         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3061         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3062         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3063
3064 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3065
3066         [ews-build] use svn-apply script to apply the patches
3067         https://bugs.webkit.org/show_bug.cgi?id=193138
3068
3069         Reviewed by Lucas Forschler.
3070
3071         * BuildSlaveSupport/ews-build/factories.py:
3072         (Factory.__init__): Add the ApplyPatch step.
3073         * BuildSlaveSupport/ews-build/steps.py:
3074         (CheckOutSource): Added step name.
3075         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3076         (ApplyPatch): Build step to apply patch using svn-apply script.
3077         (UnApplyPatchIfRequired):
3078         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3079
3080 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3081
3082         Deprecate WKContextCreate
3083         https://bugs.webkit.org/show_bug.cgi?id=193118
3084
3085         Reviewed by Brady Eidson.
3086
3087         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3088         (WebKitBrowserWindow::WebKitBrowserWindow):
3089         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3090         (TestWebKitAPI::TEST):
3091         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3092         (TestWebKitAPI::TEST):
3093         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3094         (TestWebKitAPI::TEST):
3095         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3096         (TestWebKitAPI::TEST):
3097         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3102         (TestWebKitAPI::TEST):
3103         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3104         (TestWebKitAPI::TEST):
3105         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3106         (TestWebKitAPI::TEST):
3107         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3108         (TestWebKitAPI::TEST):
3109         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3110         (TestWebKitAPI::TEST):
3111         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3114         (TestWebKitAPI::TEST):
3115         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3116         (TestWebKitAPI::TEST):
3117         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3120         (TestWebKitAPI::TEST):
3121         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3126         (TestWebKitAPI::loadAlternateHTMLString):
3127         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3128         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3129         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3130         (TestWebKitAPI::buildAndPerformTest):
3131         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3132         (TestWebKitAPI::TEST):
3133         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3134         (TestWebKitAPI::TEST):
3135         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3136         (TestWebKitAPI::TEST):
3137         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3138         (TestWebKitAPI::TEST):
3139         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3140         (TestWebKitAPI::TEST):
3141         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3142         (TestWebKitAPI::TEST):
3143         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3144         (TestWebKitAPI::TEST):
3145         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3146         (TestWebKitAPI::TEST):
3147         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3150         (TestWebKitAPI::TEST):
3151         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3152         (TestWebKitAPI::TEST):
3153         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3154         (TestWebKitAPI::TEST):
3155         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3156         (TestWebKitAPI::TEST):
3157         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3158         (TestWebKitAPI::TEST):
3159         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3162         (TestWebKitAPI::TEST):
3163         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3164         (TestWebKitAPI::TEST):
3165         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3166         (TestWebKitAPI::TEST):
3167         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3168         (TestWebKitAPI::TEST):
3169         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3170         (TestWebKitAPI::TEST):
3171         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3172         (TestWebKitAPI::TEST):
3173         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3174         (TestWebKitAPI::TEST):
3175         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3176         (TestWebKitAPI::TEST):
3177         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3178         (TestWebKitAPI::TEST):
3179         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3180         (TestWebKitAPI::TEST):
3181         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3182         (TestWebKitAPI::TEST):
3183         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3184         (WebKit2_CommandBackForwardTestWKView::SetUp):
3185         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3186         (TestWebKitAPI::TEST):
3187         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3188         (TestWebKitAPI::TEST):
3189         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3190         (TestWebKitAPI::TEST):
3191         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3192         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3193
3194 2019-01-03  Matt Rajca  <mrajca@apple.com>
3195
3196         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3197         https://bugs.webkit.org/show_bug.cgi?id=193128
3198         rdar://34554231
3199
3200         Reviewed by Jer Noble.
3201
3202         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3203         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3204         event along with a flag that indicates whether or not autoplay was actually prevented.
3205
3206         Tests: existing API tests were updated to reflect the new names. New API tests
3207         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3208
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3211         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3212         (TEST):
3213         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3214         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3215
3216 2019-01-04  Chris Dumez  <cdumez@apple.com>
3217
3218         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3219         https://bugs.webkit.org/show_bug.cgi?id=193120
3220
3221         Reviewed by Alex Christensen.
3222
3223         Add API test coverage.
3224
3225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3226
3227 2019-01-04  Chris Dumez  <cdumez@apple.com>
3228
3229         Crash under WebProcessPool::addSuspendedPage()
3230         https://bugs.webkit.org/show_bug.cgi?id=193110
3231
3232         Reviewed by Youenn Fablet.
3233
3234         Add API test coverage.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3237
3238 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3239
3240         [ews-build] Check patch relevance before applying the patch
3241         https://bugs.webkit.org/show_bug.cgi?id=193102
3242
3243         Reviewed by Lucas Forschler.
3244
3245         * BuildSlaveSupport/ews-build/factories.py:
3246         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3247
3248 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3249
3250         [ews-build] Check patch relevance step should print patch id
3251         https://bugs.webkit.org/show_bug.cgi?id=193137
3252
3253         Reviewed by Lucas Forschler.
3254
3255         * BuildSlaveSupport/ews-build/steps.py:
3256         (CheckPatchRelevance.start): Update the status to include patch id.
3257
3258 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3259
3260         webkitpy: Increase simulator teardown timeout
3261         https://bugs.webkit.org/show_bug.cgi?id=193141
3262         <rdar://problem/46174217>
3263
3264         Rubber-stamped by Aakash Jain.
3265
3266         * Scripts/webkitpy/xcode/simulated_device.py:
3267         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3268
3269 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3270
3271         test262-runner misbehaves when test file YAML has a trailing space
3272         https://bugs.webkit.org/show_bug.cgi?id=193053
3273
3274         Reviewed by Yusuke Suzuki.
3275
3276         * Scripts/test262/Runner.pm:
3277         (parseData):
3278         Accept trailing space when parsing a test file's YAML block.
3279
3280 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3281
3282         UserMedia test should use WKPageNavigationClient
3283         https://bugs.webkit.org/show_bug.cgi?id=192913
3284
3285         Reviewed by Youenn Fablet.
3286
3287         The test currently uses the deprecated WKPageLoaderClient. It should use
3288         WKPageNavigationClient instead, which provides the same callback under a similar name.
3289
3290         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3291         (TestWebKitAPI::TEST):
3292
3293 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3294
3295         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3296         https://bugs.webkit.org/show_bug.cgi?id=192944
3297
3298         Reviewed by Tim Horton.
3299
3300         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3301         (TestWebKitAPI::TEST):
3302
3303 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3304
3305         Add support for using the current text selection as the find string on iOS
3306         https://bugs.webkit.org/show_bug.cgi?id=193034
3307         <rdar://problem/45138739>
3308
3309         Reviewed by Tim Horton.
3310
3311         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3312         _setStringForFind) works as expected.
3313
3314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3315         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3316
3317 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] Use git on OpenSource EWS bots
3320         https://bugs.webkit.org/show_bug.cgi?id=193092
3321
3322         Reviewed by Lucas Forschler.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (CheckOutSource): Use git instead of svn.
3326         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3327
3328 2019-01-02  Daniel Bates  <dabates@apple.com>
3329
3330         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3331         https://bugs.webkit.org/show_bug.cgi?id=193023
3332
3333         Reviewed by Simon Fraser.
3334
3335         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3336         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3337         enumerator values. We should just remove this code.
3338
3339         * lldb/lldb_webkit.py:
3340         (WTFOptionSetProvider.has_children):
3341         (WTFOptionSetProvider.num_children):
3342         (WTFOptionSetProvider.get_child_index):
3343         (WTFOptionSetProvider.get_child_at_index):
3344
3345 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3346
3347         .ycm_extra_conf.py should handle XXXInlines.h
3348         https://bugs.webkit.org/show_bug.cgi?id=193055
3349
3350         Reviewed by Carlos Garcia Campos.
3351
3352         compile_commands.json database only records flags and options for cpp source files.
3353         So, when we open headers, this database does not have any information for that.
3354         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3355         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3356         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3357         we attempt to find XXX.cpp and use the configuration if it exists.
3358
3359         * gtk/ycm_extra_conf.py:
3360         (getImplementationFilename):
3361         (FlagsForFile):
3362
3363 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3364
3365         Unreviewed. Support PHP 7.3 in Debian.
3366
3367         Add 7.3 to the list of php versions supported in Debian.
3368
3369         * Scripts/webkitpy/port/base.py:
3370         (Port._debian_php_version):
3371
3372 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3373
3374         Resurrect Mac CMake build
3375         https://bugs.webkit.org/show_bug.cgi?id=192658
3376
3377         Reviewed by Yusuke Suzuki.
3378
3379         * DumpRenderTree/PlatformMac.cmake:
3380         * MiniBrowser/mac/CMakeLists.txt:
3381         * TestWebKitAPI/PlatformMac.cmake:
3382
3383 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3384
3385         [Tools] Remove references to Bison and Flex
3386         https://bugs.webkit.org/show_bug.cgi?id=193033
3387
3388         Reviewed by Michael Catanzaro.
3389
3390         The Bison and Flex tools are not needed anymore since r209883.
3391
3392         * CygwinDownloader/cygwin-downloader.py:
3393         * EWSTools/ubuntu-ews-packages:
3394         * Scripts/filter-build-webkit:
3395         (shouldIgnoreLine):
3396         * gtk/install-dependencies:
3397         * wpe/install-dependencies:
3398
3399 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         WebDriver: warn about non existing tests when parsing expectations
3402         https://bugs.webkit.org/show_bug.cgi?id=192979
3403
3404         Reviewed by Michael Catanzaro.
3405
3406         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3407         renamed.
3408
3409         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3410         (WebDriverTestRunner.__init__):
3411
3412 2018-12-21  Chris Dumez  <cdumez@apple.com>
3413
3414         navigator.userAgent in service workers does not reflect customUserAgent set by client
3415         https://bugs.webkit.org/show_bug.cgi?id=192951
3416
3417         Reviewed by Youenn Fablet.
3418
3419         Extend API test coverage.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3422         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3423         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3424         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3425         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3426
3427 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3428
3429         [WebAuthN] userPresence should always be true
3430         https://bugs.webkit.org/show_bug.cgi?id=192835
3431         <rdar://problem/46538788>
3432
3433         Reviewed by Brent Fulgham.
3434
3435         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3436         (TestWebKitAPI::TEST):
3437
3438 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3439
3440         Add support to run-benchmark to use non-default copies of the browser apps
3441         https://bugs.webkit.org/show_bug.cgi?id=192905
3442         rdar://problem/46845840
3443
3444         Reviewed by Dewei Zhu.
3445         
3446         Add support for a --browser-path argument to run-benchmark, which allows you to use
3447         a custom app bundle for a given browser (only implemented for Safari at present).
3448
3449         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3450         (BenchmarkRunner.__init__):
3451         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3452         (BrowserDriver.__init__):
3453         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3454         (BrowserDriverFactory.create):
3455         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3456         (OSXBrowserDriver._launch_process):
3457         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3458         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3459         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3460         (OSXChromeCanaryDriver.launch_url):
3461         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3462         (OSXFirefoxNightlyDriver.launch_url):
3463         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3464         (OSXSafariDriver.__init__):
3465         (OSXSafariDriver.launch_url):
3466         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3467         (parse_args):
3468         (run_benchmark_plan):
3469         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3470         (WebServerBenchmarkRunner.__init__):
3471         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3472         (FakeBenchmarkRunner.__init__):
3473
3474 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3475
3476         [WebAuthN] Import an APDU coder from Chromium
3477         https://bugs.webkit.org/show_bug.cgi?id=192949
3478         <rdar://problem/46879933>
3479
3480         Reviewed by Brent Fulgham.
3481
3482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3483         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3484         (TestWebKitAPI::TEST):
3485
3486 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3487
3488         Setting the file wrapper and content type of an attachment to a PDF should update its image
3489         https://bugs.webkit.org/show_bug.cgi?id=192984
3490         <rdar://problem/46798028>
3491
3492         Reviewed by Tim Horton.
3493
3494         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3495         PDF data correctly updates the image element.
3496
3497         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3498
3499 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3500
3501         Add JSCOnly to bot dashboard
3502         https://bugs.webkit.org/show_bug.cgi?id=192964
3503
3504         Reviewed by Alexey Proskuryakov.
3505
3506         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3507         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3508         useful if they were not so secret, so add them.
3509
3510         There appear to be no build-only bots, so the first column is blank. And of course there are
3511         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3512         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3513         and there's plenty of room in the final column for all the bots.
3514
3515         I had a hard time picking a logo to use, because the JavaScript language does not have an
3516         official logo. But I believe I've found one that will be satisfactory.
3517
3518         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3523         (BubbleQueueServer):
3524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3526         (WebKitBuildbot):
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3528         (table.queue-grid tr.platform.linux-jsconly img.logo):
3529
3530 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3531
3532         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3533         https://bugs.webkit.org/show_bug.cgi?id=192821
3534
3535         Reviewed by Chris Dumez.
3536
3537         * DumpRenderTree/mac/DumpRenderTree.mm:
3538         (createWebViewAndOffscreenWindow):
3539         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3540
3541 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3542
3543         [Win][Clang] Fix compilation warnings of DumpRenderTree
3544         https://bugs.webkit.org/show_bug.cgi?id=192924
3545
3546         Reviewed by Alex Christensen.
3547
3548         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3549         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3550         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3551         * DumpRenderTree/win/DumpRenderTree.cpp:
3552         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3553         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3554         object to the argument of setDefaultTextEncodingName instead of a
3555         const string literal.
3556         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3557         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3558         (setCacheFolder): Deleted.
3559         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3560         * DumpRenderTree/win/EditingDelegate.cpp:
3561         (dump): Use %d for int.
3562         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3563         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3564         (BSTRFromString): Deleted unused function.
3565         * DumpRenderTree/win/TestRunnerWin.cpp:
3566         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3567         the arguemnt of setQuota instead of const string literal.
3568         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3569         (jsStringRefToWString): Deleted unused function.
3570
3571 2018-12-20  Chris Dumez  <cdumez@apple.com>
3572
3573         Add API test coverage for customUserAgent client setting and service workers
3574         https://bugs.webkit.org/show_bug.cgi?id=192952
3575
3576         Reviewed by Alex Christensen.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3579         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3580         (-[SWSchemes webView:startURLSchemeTask:]):
3581         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3582         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3583
3584 2018-12-20  Chris Dumez  <cdumez@apple.com>
3585
3586         Use Optional::hasValue() instead of Optional::has_value()
3587         https://bugs.webkit.org/show_bug.cgi?id=192948
3588
3589         Reviewed by Tim Horton.
3590
3591         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3592         (TestWebKitAPI::TEST):
3593         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3594         (TestWebKitAPI::TEST):
3595         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3596         (TestWebKitAPI::TEST_F):
3597
3598 2018-12-20  Chris Dumez  <cdumez@apple.com>
3599
3600         Add style script rule to check for uses of std::optional<>
3601         https://bugs.webkit.org/show_bug.cgi?id=192931
3602
3603         Reviewed by Tim Horton.
3604
3605         * Scripts/webkitpy/style/checkers/cpp.py:
3606         (check_wtf_optional):
3607         (check_style):
3608
3609 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3610
3611         [WebAuthN] Add a runtime flag for local authenticator
3612         https://bugs.webkit.org/show_bug.cgi?id=192792
3613         <rdar://problem/46798738>
3614
3615         Reviewed by Brent Fulgham.
3616
3617         * DumpRenderTree/TestOptions.cpp:
3618         (TestOptions::TestOptions):
3619         * DumpRenderTree/TestOptions.h:
3620         * DumpRenderTree/mac/DumpRenderTree.mm:
3621         (enableExperimentalFeatures):
3622         (setWebPreferencesForTestOptions):
3623         * WebKitTestRunner/TestController.cpp:
3624         (WTR::TestController::resetPreferencesToConsistentValues):
3625         (WTR::updateTestOptionsFromTestHeader):
3626         * WebKitTestRunner/TestOptions.h:
3627         (WTR::TestOptions::hasSameInitializationOptions const):
3628
3629 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3630
3631         webkitpy: Autoinstall package URLs have changed
3632         https://bugs.webkit.org/show_bug.cgi?id=192909
3633         <rdar://problem/46860359>
3634
3635         Rubber-stamped by Alexey Proskuryakov.
3636
3637         PyPi urls have been moved around, we need to update our auto-installed packages.
3638
3639         We should check for Selenium before asking PyPi for the latest version.
3640
3641         * Scripts/webkitpy/thirdparty/__init__.py:
3642         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3643         (AutoinstallImportHook._install_keyring): Ditto.
3644         (AutoinstallImportHook._install_pep8): Ditto.
3645         (AutoinstallImportHook._install_mozlog): Ditto.
3646         (AutoinstallImportHook._install_mozprocess): Ditto.
3647         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3648         (AutoinstallImportHook._install_pytest): Ditto.
3649         (AutoinstallImportHook._install_pylint): Ditto.
3650         (AutoinstallImportHook._install_buildbot): Ditto.
3651         (AutoinstallImportHook._install_coverage): Ditto.
3652         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3653         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3654         for new Selenium if the installed version isn't sufficient.
3655         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3656
3657 2018-12-20  Chris Dumez  <cdumez@apple.com>
3658
3659         Use Optional::valueOr() instead of Optional::value_or()
3660         https://bugs.webkit.org/show_bug.cgi?id=192933
3661
3662         Reviewed by Geoffrey Garen.
3663
3664         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3665         (TestWebKitAPI::checkURL):
3666         (TestWebKitAPI::checkRelativeURL):
3667         (TestWebKitAPI::checkURLDifferences):
3668         (TestWebKitAPI::checkRelativeURLDifferences):
3669         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3670         (TestWebKitAPI::checkURL):
3671
3672 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3673
3674         Unreviewed, rolling out r239417.
3675
3676         Introduced two API test failures on macOS.
3677
3678         Reverted changeset:
3679
3680         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3681         occlusion changes"
3682         https://bugs.webkit.org/show_bug.cgi?id=192821
3683         https://trac.webkit.org/changeset/239417
3684
3685 2018-12-20  Devin Rousso  <drousso@apple.com>
3686
3687         Web Inspector: UIString should take an optional key and description to aid localization
3688         https://bugs.webkit.org/show_bug.cgi?id=153962
3689         <rdar://problem/24542505>
3690
3691         Reviewed by Brian Burg.
3692
3693         * Scripts/extract-localizable-js-strings:
3694
3695 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3696
3697         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3698         https://bugs.webkit.org/show_bug.cgi?id=192923
3699         <rdar://problem/46859068>
3700
3701         Reviewed by Wenson Hsieh.
3702
3703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3704         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3705         Add a test ensuring that both parented and unparented WKWebViews can
3706         retrieve main resource data when loading a PDF.
3707
3708 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3709
3710         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3711         https://bugs.webkit.org/show_bug.cgi?id=192852
3712
3713         Reviewed by Michael Catanzaro.
3714
3715         EmojiOne font was replaced by Noto Color Emoji.
3716
3717         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3718         * gtk/jhbuild.modules:
3719         * wpe/jhbuild.modules:
3720
3721 2018-12-19  Chris Dumez  <cdumez@apple.com>
3722
3723         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3724         https://bugs.webkit.org/show_bug.cgi?id=192728
3725         <rdar://problem/46746779>
3726
3727         Reviewed by Geoff Garen.
3728
3729         * DumpRenderTree/*:
3730         * MiniBrowser/*:
3731         * TestRunnerShared/*:
3732         * TestWebKitAPI/*:
3733         * WebGPUAPIStructure/*:
3734         * WebKitTestRunner/*:
3735
3736 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3737
3738         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3739         https://bugs.webkit.org/show_bug.cgi?id=192821
3740
3741         Reviewed by Chris Dumez.
3742
3743         * DumpRenderTree/mac/DumpRenderTree.mm:
3744         (createWebViewAndOffscreenWindow):
3745
3746 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3747
3748         Navigations away from the SafeBrowsing interstitial show a flash of old content
3749         https://bugs.webkit.org/show_bug.cgi?id=192676
3750
3751         Reviewed by Chris Dumez.
3752
3753         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3754         (safeBrowsingView):
3755         (TEST):
3756         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3757
3758 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3759
3760         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3761         https://bugs.webkit.org/show_bug.cgi?id=192855
3762
3763         Reviewed by Michael Catanzaro.
3764
3765         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3766         (WTR::TestController::notifyDone): Use the WPE implementation.
3767         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3768         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3769         (WTR::TestController::platformRunUntil): Honor the condition flag.
3770
3771 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3772
3773         Allow clients to set the navigator platform
3774         https://bugs.webkit.org/show_bug.cgi?id=192735
3775
3776         Reviewed by Tim Horton.
3777
3778         Add a test for setting a custom navigator platform.
3779
3780         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3781         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3782         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3783
3784 2018-12-19  Truitt Savell  <tsavell@apple.com>
3785
3786         Unreviewed, rolling out r239358.
3787
3788         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3789         crash on Debug bots
3790
3791         Reverted changeset:
3792
3793         "Clean up IndexedDB files between tests"
3794         https://bugs.webkit.org/show_bug.cgi?id=192796
3795         https://trac.webkit.org/changeset/239358
3796
3797 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3798
3799         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3800         https://bugs.webkit.org/show_bug.cgi?id=192842
3801         <rdar://problem/46823586>
3802
3803         Reviewed by Tim Horton.
3804
3805         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3806         item provider when dragging a rich text selection.
3807
3808         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3809
3810 2018-12-18  David Quesada  <david_quesada@apple.com>
3811
3812         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3813         https://bugs.webkit.org/show_bug.cgi?id=192810
3814         <rdar://problem/46812536>
3815
3816         Reviewed by Alex Christensen.
3817
3818         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3819         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3820             After releasing our reference to the web view, wait until the next turn of the runloop
3821             before checking that the originatingWebView has been zeroed, since the web view might
3822             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3823             testing general memory management of WKWebViews, only that _WKDownload does not retain
3824             its web view via the 'originatingWebView' property.
3825
3826 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3827
3828         Clean up IndexedDB files between tests
3829         https://bugs.webkit.org/show_bug.cgi?id=192796
3830
3831         Reviewed by Geoffrey Garen.
3832
3833         * DumpRenderTree/mac/DumpRenderTree.mm:
3834         (runTest):
3835         * WebKitTestRunner/TestController.cpp:
3836         (WTR::TestController::resetStateToConsistentValues):
3837         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3838         (WTR::RemoveAllIndexedDatabasesCallback):
3839         (WTR::TestController::ClearIndexedDatabases):
3840         * WebKitTestRunner/TestController.h:
3841
3842 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3843
3844         Fix API test introduced in r239339 on iOS.
3845         https://bugs.webkit.org/show_bug.cgi?id=192675
3846
3847         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3848         (TEST):
3849         The iOS implementation of the safe browsing warning is a little different.
3850         It does some element creation when it is added to the window so it knows how big it is.
3851         To test these elements, we need to simulate adding it to the window.
3852         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3853
3854 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3855
3856         webkitpy: Ignore device type for test when using --force
3857         https://bugs.webkit.org/show_bug.cgi?id=192786
3858         <rdar://problem/46794894>
3859
3860         Reviewed by Daniel Bates.
3861
3862         It is sometimes the case that a contributor will wish to run a test on a specific device,
3863         despite expectations which indicate a test should not be run on that device.
3864
3865         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3866         (parse_args):
3867         * Scripts/webkitpy/port/device_port.py:
3868         (DevicePort.default_child_processes): Strip device type information when using --force.
3869         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3870
3871 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3872
3873         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3874         https://bugs.webkit.org/show_bug.cgi?id=192675
3875
3876         Reviewed by Geoffrey Garen.
3877
3878         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3879         (goBack):
3880         (TEST):
3881         (visitUnsafeSite):
3882         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3883         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3884
3885 2018-12-18  Chris Dumez  <cdumez@apple.com>
3886
3887         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3888         https://bugs.webkit.org/show_bug.cgi?id=192772
3889
3890         Reviewed by Antti Koivisto.
3891
3892         Add API test coverage.
3893
3894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3895
3896 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3897
3898         Unreviewed, JHBuild GTK build fix attempt
3899
3900         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3901         There's no ninja module either, it should be provided by the
3902         host system.
3903
3904 2018-12-17  Chris Dumez  <cdumez@apple.com>
3905
3906         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3907         https://bugs.webkit.org/show_bug.cgi?id=192789
3908         <rdar://problem/46755277>
3909
3910         Reviewed by Alex Christensen.
3911
3912         Add API test coverage.
3913
3914         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3915         (TEST):
3916
3917 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3918
3919         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3920         https://bugs.webkit.org/show_bug.cgi?id=192780
3921         rdar://problem/43394387
3922
3923         Reviewed by Tim Horton.
3924
3925         No need to set "AppleFontSmoothing" defaults for WK2.
3926
3927         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3928         (WTR::InjectedBundle::platformInitialize):
3929
3930 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3931
3932         webkitpy: Handle case where stdout and stderr don't accept unicode
3933         https://bugs.webkit.org/show_bug.cgi?id=192775
3934         <rdar://problem/46497303>
3935
3936         Reviewed by Stephanie Lewis.
3937
3938         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3939         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3940         characters with '?'.
3941         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3942         (RegularTest.test_stream_with_encoding):
3943
3944 2018-12-17  Daniel Bates  <dabates@apple.com>
3945
3946         Support concatenating StringView with other string types
3947         https://bugs.webkit.org/show_bug.cgi?id=177566
3948
3949         Reviewed by Darin Adler.
3950
3951         Add some tests to ensure we do not regress the number of allocations needed when performing
3952         string concatenation with string views.
3953
3954         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3955         (TestWebKitAPI::TEST):
3956
3957 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3958
3959         Unreviewed, rolling out r239265 and r239274.
3960         https://bugs.webkit.org/show_bug.cgi?id=192765
3961
3962         unorm_normalize is deprecated, and broke an internal build
3963         (Requested by Truitt on #webkit).
3964
3965         Reverted changesets:
3966
3967         "[GTK][WPE] Need a function to convert internal URI to display
3968         ("pretty") URI"
3969         https://bugs.webkit.org/show_bug.cgi?id=174816
3970         https://trac.webkit.org/changeset/239265
3971
3972         "Fix the Apple Internal Mac build with a newer SDK"
3973         https://trac.webkit.org/changeset/239274
3974
3975 2018-12-17  Daniel Bates  <dabates@apple.com>
3976
3977         Implement UIScriptController::toggleCapsLock() for iOS
3978         https://bugs.webkit.org/show_bug.cgi?id=191815
3979
3980         Reviewed by Andy Estes.
3981
3982         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3983
3984         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3985         * WebKitTestRunner/TestController.cpp:
3986         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3987         before running a test. This ensures that the caps lock state does not persist between
3988         tests should a test enable caps lock and not disable it.
3989         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3990         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3991         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3992         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3993         create the event. Also substituted NSString* for const String& as the data type for the first
3994         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3995         below.
3996         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3997         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3998
3999 2018-12-17  Daniel Bates  <dabates@apple.com>
4000
4001         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
4002         https://bugs.webkit.org/show_bug.cgi?id=192633
4003
4004         Reviewed by Wenson Hsieh.
4005
4006         Update code to use the modern initializer.
4007
4008         * DumpRenderTree/mac/EventSendingController.mm:
4009         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4010
4011 2018-12-17  Matt Lewis  <jlewis3@apple.com>
4012
4013         Unreviewed, rolling out r239254.
4014
4015         This broke the Windows 10 Debug build
4016
4017         Reverted changeset:
4018
4019         "Replace many uses of String::format with more type-safe
4020         alternatives"
4021         https://bugs.webkit.org/show_bug.cgi?id=192742
4022         https://trac.webkit.org/changeset/239254
4023
4024 2018-12-17  David Kilzer  <ddkilzer@apple.com>
4025
4026         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
4027         <https://webkit.org/b/192751>
4028         <rdar://problem/46771623>
4029
4030         Reviewed by Daniel Bates.
4031
4032         Change loop variables to const references to avoid unnecessary
4033         copies.
4034
4035         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
4036         (-[LocalPasteboard pasteboardItems]):
4037
4038 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
4039
4040         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4041         https://bugs.webkit.org/show_bug.cgi?id=174816
4042
4043         Reviewed by Michael Catanzaro.
4044
4045         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
4046
4047         * TestWebKitAPI/CMakeLists.txt:
4048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4049         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
4050         (TestWebKitAPI::TEST):
4051         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
4052         (testURIForDisplayUnaffected):
4053         (testURIForDisplayAffected):
4054         (beforeAll):
4055         (afterAll):
4056         * TestWebKitAPI/glib/CMakeLists.txt:
4057
4058 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4059
4060         [WPE] Add API to notify about frame displayed view backend callback
4061         https://bugs.webkit.org/show_bug.cgi?id=192224
4062
4063         Reviewed by Michael Catanzaro.
4064
4065         Add a test case to check the new API.
4066
4067         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4068         (testWebViewFrameDisplayed):
4069         (beforeAll):
4070         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
4071
4072 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
4073
4074         Unreviewed build fix after r239253
4075
4076         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
4077
4078 2018-12-15  Darin Adler  <darin@apple.com>
4079
4080         Use warning-ignoring macros more consistently and simply
4081         https://bugs.webkit.org/show_bug.cgi?id=192743
4082
4083         Reviewed by Mark Lam.
4084
4085         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4086         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
4087         * DumpRenderTree/mac/TextInputControllerMac.m:
4088         (-[TextInputController interpretKeyEvents:withSender:]): Use
4089         IGNORE_WARNINGS_BEGIN/END.
4090         * WebKitTestRunner/mac/EventSenderProxy.mm:
4091         (WTR::EventSenderProxy::mouseForceClick): Use
4092         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
4093         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
4094         (WTR::EventSenderProxy::mouseForceDown): Ditto.
4095         (WTR::EventSenderProxy::mouseForceUp): Ditto.
4096         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
4097
4098 2018-12-15  Darin Adler  <darin@apple.com>
4099
4100         Replace many uses of String::format with more type-safe alternatives
4101         https://bugs.webkit.org/show_bug.cgi?id=192742
4102
4103         Reviewed by Mark Lam.
4104
4105         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4106         (WTR::cacheTestRunnerCallback): Use makeString.
4107         * WebKitTestRunner/TestController.cpp:
4108         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4109         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4110
4111 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
4112
4113         [WPE][GTK] Add libpsl to JHBuild module sets
4114         https://bugs.webkit.org/show_bug.cgi?id=192740
4115
4116         Reviewed by Michael Catanzaro.
4117
4118         * gtk/jhbuild.modules: Add libpsl module.
4119         * wpe/jhbuild.modules: Ditto.
4120
4121 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4122
4123         Add a style checker rule for Xcode version macros use
4124         https://bugs.webkit.org/show_bug.cgi?id=192703
4125
4126         Reviewed by Alex Christensen.
4127
4128         * Scripts/webkitpy/style/checkers/cpp.py:
4129         (check_os_version_checks):
4130         (process_line):
4131         (CppChecker):
4132         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4133         (WebKitStyleTest.test_os_version_checks):
4134
4135 2018-12-14  Chris Dumez  <cdumez@apple.com>
4136
4137         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4138         https://bugs.webkit.org/show_bug.cgi?id=192704
4139
4140         Reviewed by Geoffrey Garen.
4141
4142         Extend existing API test to reproduce the problem.
4143
4144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4145
4146 2018-12-14  Chris Dumez  <cdumez@apple.com>
4147
4148         [PSON] WebsitePolicies are lost on process-swap
4149         https://bugs.webkit.org/show_bug.cgi?id=192694
4150         <rdar://problem/46715748>
4151
4152         Reviewed by Brady Eidson.
4153
4154         Extend existing API test to reproduce the issue.
4155
4156         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4157
4158 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4159
4160         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4161         https://bugs.webkit.org/show_bug.cgi?id=192678
4162
4163         Reviewed by Carlos Garcia Campos.
4164
4165         Update our ancient versions of libsoup and glib-networking.
4166
4167         * gtk/install-dependencies:
4168         * gtk/jhbuild.modules:
4169         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4170         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4171         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4172         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4173         * wpe/install-dependencies:
4174         * wpe/jhbuild.modules:
4175         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4176
4177 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4178
4179         [WPE] Use new view state API from libwpe
4180         https://bugs.webkit.org/show_bug.cgi?id=191906
4181
4182         Reviewed by Žan Doberšek.
4183
4184         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4185         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4186         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4187         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4188         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4189         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4190         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4191         wpe_view_activity_state_focused state flags.
4192         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4193         * wpe/backends/HeadlessViewBackend.cpp:
4194         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4195         * wpe/backends/WindowViewBackend.cpp:
4196         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4197         received in configure callback.
4198         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4199
4200 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4201
4202         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4203         https://bugs.webkit.org/show_bug.cgi?id=192688
4204
4205         Reviewed by Ross Kirsling.
4206
4207         * win/DLLLauncher/DLLLauncherMain.cpp:
4208         (copyEnvironmentVariable): Moved.
4209         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4210         (applePathFromRegistry): Ditto.
4211         (appleApplicationSupportDirectory): Ditto.
4212         (prependPath): Ditto.
4213
4214 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4215
4216         Unreviewed. Changed my status to a reviewer.
4217
4218         * Scripts/webkitpy/common/config/contributors.json:
4219
4220 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4221
4222         [iOS] Support dropping contact card data (public.vcard) in editable content
4223         https://bugs.webkit.org/show_bug.cgi?id=192570
4224         <rdar://problem/35626913>
4225
4226         Reviewed by Tim Horton.
4227
4228         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4229
4230         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4231         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4232         additionally inserts a link).
4233
4234         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4235         (TestWebKitAPI::createMapItemForTesting):
4236         (TestWebKitAPI::createContactItemForTesting):
4237
4238         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4239         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4240         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4241         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4242         files.
4243
4244 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4245
4246         Unreviewed -- update my status to "reviewer".
4247
4248         * Scripts/webkitpy/common/config/contributors.json:
4249
4250 2018-12-13  Youenn Fablet  <youenn@apple.com>
4251
4252         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4253         https://bugs.webkit.org/show_bug.cgi?id=192657
4254
4255         Reviewed by Eric Carlson.
4256
4257         Add a test that loads a page registering ondevicechange,
4258         load another page in the same process, closes the first page.
4259         Ensure that the process does not crash in that case.
4260
4261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4262         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4263         (TestWebKitAPI::TEST):
4264         (TestWebKitAPI::didCrashCallback):
4265         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4266
4267 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4268
4269         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4270         https://bugs.webkit.org/show_bug.cgi?id=192643
4271
4272         Reviewed by Philippe Normand.
4273
4274         This problem happens with Arch Linux users which have libfdk-2.0.0
4275         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4276
4277         The problem has already been solved upstream at
4278         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4279
4280         Adding patches while this problem is not in a release yet.
4281
4282         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4283         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4284         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4285
4286 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4287
4288         [FreeType] Add initial implementation of variation fonts
4289         https://bugs.webkit.org/show_bug.cgi?id=192151
4290
4291         Reviewed by Michael Catanzaro.
4292
4293         Add cairo patch to avoid crashes.
4294
4295         * gtk/jhbuild.modules:
4296         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4297
4298 2018-12-12  Fujii Hironori