Update expected API test result following r242379
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-05  Daniel Bates  <dabates@apple.com>
2
3         Update expected API test result following r242379
4         (https://bugs.webkit.org/show_bug.cgi?id=195125)
5
6         Update expected x-coordinate of selection rect now that the left padding of
7         a textarea is sized in ems (so dependent on the font size) just like the left
8         padding of a text field.
9
10         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
11         (TestWebKitAPI::TEST):
12
13 2019-03-05  David Quesada  <david_quesada@apple.com>
14
15         [WK2] It should be possible to follow links with 'download' attributes
16         https://bugs.webkit.org/show_bug.cgi?id=195145
17         rdar://problem/48462642
18
19         Reviewed by Alex Christensen.
20
21         Add a unit test to verify that activating links with 'download' attributes now
22         navigates to the linked resource, rather than starts downloading it. Add another
23         to verify that it is still possible to explicitly download the link via the
24         'Download' navigation action policy.
25
26         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
27         (-[DownloadAttributeTestDelegate init]):
28         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
29         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
30         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
31         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
32         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
33         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
34         (TEST):
35         * WebKitTestRunner/TestController.cpp:
36         (WTR::TestController::decidePolicyForNavigationAction):
37         * WebKitTestRunner/TestController.h:
38
39 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
40
41         [Curl] Implement Cookie Accept Policy.
42         https://bugs.webkit.org/show_bug.cgi?id=191645
43
44         Reviewed by Fujii Hironori.
45
46         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
47         (TestWebKitAPI::Curl::TEST_F):
48
49 2019-03-05  Youenn Fablet  <youenn@apple.com>
50
51         Rename requestCacheStorageSpace to requestStorageSpace
52         https://bugs.webkit.org/show_bug.cgi?id=195282
53
54         Reviewed by Chris Dumez.
55
56         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
57         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
58         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
59
60 2019-03-05  Brady Eidson  <beidson@apple.com>
61
62         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
63         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
64
65         Reviewed by Tim Horton.
66
67         Loading a file: URL into a WKWebView and then loading another file: url from a completely
68         different directory into that same WKWebView should work.
69
70         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
71         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
72
73 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
74
75         Add WeakHashSet
76         https://bugs.webkit.org/show_bug.cgi?id=195152
77
78         Reviewed by Antti Koivisto.
79
80         Added tests for WeakHashSet.
81
82         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
83         (TestWebKitAPI::Base::Base): Moved.
84         (TestWebKitAPI::Derived::foo): Moved.
85         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
86         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
87         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
88         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
89
90 2019-03-04  Chris Dumez  <cdumez@apple.com>
91
92         Do not share WebProcesses between private and regular sessions
93         https://bugs.webkit.org/show_bug.cgi?id=195189
94         <rdar://problem/48421064>
95
96         Reviewed by Alex Christensen.
97
98         Add API test coverage.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
101         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
102
103 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
104
105         [WPE] Enable web process sandbox
106         https://bugs.webkit.org/show_bug.cgi?id=195169
107
108         Reviewed by Daniel Bates.
109
110         * wpe/install-dependencies:
111         * wpe/jhbuild.modules:
112
113 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
114
115         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
116         https://bugs.webkit.org/show_bug.cgi?id=195206
117
118         Reviewed by Žan Doberšek.
119
120         Add a new test case.
121
122         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
123         (testJSCClass):
124
125 2019-03-04  Charlie Turner  <cturner@igalia.com>
126
127         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
128         https://bugs.webkit.org/show_bug.cgi?id=194898
129
130         Reviewed by Žan Doberšek.
131
132         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
133         a GCC extension that permits arithmetic on void* pointer. Inline
134         the macro until this issue is fixed upstream.
135
136 2019-03-03  Tim Horton  <timothy_horton@apple.com>
137
138         Rid the world of WK_API_ENABLED
139         https://bugs.webkit.org/show_bug.cgi?id=195263
140
141         Reviewed by Dan Bernstein.
142
143         List of changed files elided because it's useless.
144
145 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
146
147         Unreviewed follow-up to r242292.
148
149         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
150
151         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
152         (TestWebKitAPI::testStrip): Renamed from strip.
153         (TestWebKitAPI::TEST):
154
155 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
156
157         Unreviewed, remove accidentally-committed URLHelpers.cpp test
158
159         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
160         and bug #194272 for details.
161
162         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
163
164 2019-03-03  Tim Horton  <timothy_horton@apple.com>
165
166         Remove some more unused 32-bit code
167         https://bugs.webkit.org/show_bug.cgi?id=195255
168
169         Reviewed by Darin Adler.
170
171         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
172         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
173         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
174         (NPP_New):
175         (NPP_HandleEvent):
176         (handleEventCarbon): Deleted.
177
178 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
179
180         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
181
182         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
183         (TestWebKitAPI::TEST):
184
185 2019-03-01  Darin Adler  <darin@apple.com>
186
187         Finish removing String::format
188         https://bugs.webkit.org/show_bug.cgi?id=194893
189
190         Reviewed by Daniel Bates.
191 '
192         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
193
194 2019-03-01  Alex Christensen  <achristensen@webkit.org>
195
196         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
197         https://bugs.webkit.org/show_bug.cgi?id=195229
198         <rdar://problem/48520362>
199
200         Reviewed by Chris Dumez.
201
202         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
203         (TEST):
204
205 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
206
207         Add a system trace scope for event region building
208         https://bugs.webkit.org/show_bug.cgi?id=195226
209
210         Reviewed by Jon Lee.
211
212         This trace scope measures the time spend converting element rects into Region objects,
213         which can be large on some pages.
214
215         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
216
217         * Tracing/SystemTracePoints.plist:
218
219 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
220
221         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
222         https://bugs.webkit.org/show_bug.cgi?id=194612
223
224         Reviewed by Alex Christensen.
225
226         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
227         Just test the new string-processing function and don't touch the actual environment.
228         (Test cases are all as before, but based on operator== instead of strcmp.)
229
230 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-app] Update primary keys for handling multiple Buildbot instances
233         https://bugs.webkit.org/show_bug.cgi?id=195120
234
235         Reviewed by Stephanie Lewis.
236
237         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
238         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
239         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
240
241         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
242         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
243         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
244         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
245         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
246         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
247
248 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
249
250         [WinCairo] Enable service worker
251         https://bugs.webkit.org/show_bug.cgi?id=188318
252
253         Reviewed by Youenn Fablet.
254
255         * DumpRenderTree/DumpRenderTreePrefix.h:
256         * TestWebKitAPI/PlatformWin.cmake:
257         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
258         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
259         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
260
261 2019-03-01  Justin Fan  <justin_fan@apple.com>
262
263         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
264         https://bugs.webkit.org/show_bug.cgi?id=195191
265
266         Rubber-stamped by Dean Jackson.
267
268         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
269
270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
271
272 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
273
274         Unreviewed, fix lldb webkitpy tests
275         https://bugs.webkit.org/show_bug.cgi?id=194375
276
277         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
278
279         * lldb/lldb_webkit.py:
280         (WTFStringImplProvider.is_8bit):
281
282 2019-02-28  David Quesada  <david_quesada@apple.com>
283
284         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
285         https://bugs.webkit.org/show_bug.cgi?id=195121
286         rdar://problem/48450302
287
288         Reviewed by Alex Christensen.
289
290         Add API tests for -WKNavigationAction._shouldPerformDownload in various
291         configurations where the 'download' attribute is absent, blank, or populated
292         with a filename, and where the anchor element is same-origin or cross-origin
293         (meaning the 'download' attribute shouldn't be honored).
294
295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
296         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
297         (-[NavigationActionTestDelegate init]):
298         (-[NavigationActionTestDelegate navigationAction]):
299         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
300         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
301         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
302         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
303         (TEST):
304
305 2019-02-28  Antoine Quint  <graouts@apple.com>
306
307         Enable the Pointer Events runtime flag by default
308         https://bugs.webkit.org/show_bug.cgi?id=195156
309
310         Reviewed by Dean Jackson.
311
312         * DumpRenderTree/mac/DumpRenderTree.mm:
313         (enableExperimentalFeatures):
314
315 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
316
317         Several PasteImage API tests are flaky
318         https://bugs.webkit.org/show_bug.cgi?id=195160
319
320         Reviewed by Tim Horton.
321
322         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
323         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
324         listening for a "load" event after image load is already complete.
325
326         To address this, make these tests first register a "load" event handler, then run script to insert an image
327         element into the document, and finally wait until the load event is observed before checking image size.
328
329         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
330
331 2019-02-28  Chris Dumez  <cdumez@apple.com>
332
333         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
334         https://bugs.webkit.org/show_bug.cgi?id=195107
335
336         Reviewed by Alex Christensen.
337
338         Give some time for the zoom level to get restored.
339
340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
341
342 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
343
344         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
345         https://bugs.webkit.org/show_bug.cgi?id=194958
346
347         Reviewed by Geoffrey Garen.
348
349         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
350         (TEST):
351
352 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
353
354         [ews-app] Update method to save build to handle builder_display_name
355         https://bugs.webkit.org/show_bug.cgi?id=195047
356
357         Reviewed by Dewei Zhu.
358
359         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
360         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
361
362 2019-02-28  Justin Fan  <justin_fan@apple.com>
363
364         [Web GPU] Enable Web GPU only on 64-bit
365         https://bugs.webkit.org/show_bug.cgi?id=195139
366
367         Because Metal is only supported on 64 bit apps.
368
369         Unreviewed build fix.
370
371         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
372
373 2019-02-27  Youenn Fablet  <youenn@apple.com>
374
375         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
376         https://bugs.webkit.org/show_bug.cgi?id=194959
377
378         Reviewed by Chris Dumez.
379
380         Spin loop until getting the condition to remove flakiness.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
383
384 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
385
386         [ews-build] Buildbot should include builder_display_name in the build events
387         https://bugs.webkit.org/show_bug.cgi?id=195045
388
389         Reviewed by Dewei Zhu.
390
391         * BuildSlaveSupport/ews-build/events.py:
392         (Events.buildStarted): Included builder_display_name in event data. Also renamed
393         buildername to builder_name to be consistent in naming style.
394         (Events.buildFinished): Ditto.
395
396 2019-02-27  Chris Dumez  <cdumez@apple.com>
397
398         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
399         https://bugs.webkit.org/show_bug.cgi?id=194480
400
401         Reviewed by Brady Eidson.
402
403         Update existing API test to make it more likely to reproduce the issue.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
406
407 2019-02-27  Brady Eidson  <beidson@apple.com>
408
409         Universal links from Google search results pages don't open the app.
410         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
411
412         Reviewed by Geoffrey Garen.
413
414         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
415         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
416         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
417         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
418
419 2019-02-27  Chris Dumez  <cdumez@apple.com>
420
421         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
422         https://bugs.webkit.org/show_bug.cgi?id=195102
423
424         Reviewed by Geoffrey Garen.
425
426         If the number of processes is not yet what we expect, wait a bit and check again to give
427         processes some time to exit.
428
429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
430
431 2019-02-27  Chris Dumez  <cdumez@apple.com>
432
433         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
434         https://bugs.webkit.org/show_bug.cgi?id=194545
435
436         Reviewed by Brady Eidson.
437
438         Make sure the test navigates forward and then back only once. Previously, navigating
439         back would trigger a navigation again in a timer.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
442
443 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
444
445         High Sierra Debug JSC test queue should use faster hardware
446         https://bugs.webkit.org/show_bug.cgi?id=194603
447
448         Rubber-stamped by Alexey Proskuryakov.
449
450         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
451
452         * BuildSlaveSupport/build.webkit.org-config/config.json:
453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
454         (BubbleQueueServer):
455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
456         (WebKitBuildbot):
457         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
458         * QueueStatusServer/config/queues.py:
459         * Scripts/webkitpy/common/config/ews.json:
460         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
461         (test_ews_name):
462
463 2019-02-27  John Wilander  <wilander@apple.com>
464
465         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
466         https://bugs.webkit.org/show_bug.cgi?id=195071
467         <rdar://problem/48417690>
468
469         Reviewed by Alex Christensen and Brent Fulgham.
470
471         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
472         (TestWebKitAPI::createURL):
473             Convenience function.
474         (TestWebKitAPI::TEST):
475             WebCore::AdClickAttribution now takes a URL when creating Source and
476             Destination.
477         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
478         (TestWebKitAPI::TEST):
479             WebCore::AdClickAttribution now takes a URL when creating Source and
480             Destination.
481
482 2019-02-27  Antoine Quint  <graouts@apple.com>
483
484         Support Pointer Events on macOS
485         https://bugs.webkit.org/show_bug.cgi?id=195008
486         <rdar://problem/47454419>
487
488         Reviewed by Dean Jackson.
489
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
492         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
493
494 2019-02-26  Mark Lam  <mark.lam@apple.com>
495
496         Remove remaining poisoning code.
497         https://bugs.webkit.org/show_bug.cgi?id=194138
498
499         Reviewed by Saam Barati.
500
501         * TestWebKitAPI/CMakeLists.txt:
502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
503         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
504         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
505         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
506         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
507         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
508         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
509
510 2019-02-26  Alex Christensen  <achristensen@webkit.org>
511
512         Move ephemeral local storage from WebProcess to UIProcess
513         https://bugs.webkit.org/show_bug.cgi?id=195074
514         <rdar://problem/47937975>
515
516         Reviewed by Geoff Garen.
517
518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
519
520 2019-02-20  Jer Noble  <jer.noble@apple.com>
521
522         [Cocoa] Media elements will restart network buffering just before suspending
523         https://bugs.webkit.org/show_bug.cgi?id=193691
524
525         Reviewed by Eric Carlson.
526
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
529         (TEST):
530
531 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
532
533         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
534         https://bugs.webkit.org/show_bug.cgi?id=191652
535
536         Reviewed by Alex Christensen.
537
538         Fix WinCairo MiniBrowser behavior of authentication dialog.
539
540         * MiniBrowser/win/WebKitBrowserWindow.cpp:
541         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
542
543 2019-02-26  Youenn Fablet  <youenn@apple.com>
544
545         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
546         https://bugs.webkit.org/show_bug.cgi?id=195028
547         <rdar://problem/48243733>
548
549         Reviewed by Eric Carlson.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
552
553 2019-02-26  Philippe Normand  <pnormand@igalia.com>
554
555         [WPE] Add API for webview background color configuration
556         https://bugs.webkit.org/show_bug.cgi?id=192305
557
558         Reviewed by Michael Catanzaro.
559
560         * MiniBrowser/wpe/main.cpp:
561         (main): Add a new option to configure the webview background
562         color. Example: --bg-color=transparent.
563         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
564         (testWebViewBackgroundColor): Enable background color API tests for WPE.
565         (beforeAll): Ditto.
566
567 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
568
569         scalableNativeWebpageParameters() is not preserved on new page navigation.
570         https://bugs.webkit.org/show_bug.cgi?id=194892
571         <rdar://problem/47538280>
572
573         Reviewed by Wenson Hsieh.
574         
575         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
576
577         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
578         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
579         * DumpRenderTree/mac/UIScriptControllerMac.mm:
580         (WTR::UIScriptController::allowsViewportShrinkToFit):
581         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
582         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
583         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
584         * TestRunnerShared/UIScriptContext/UIScriptController.h:
585         * WebKitTestRunner/UIScriptControllerCocoa.mm:
586         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
587
588 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
589
590         [ews-app] Add model for handling multiple Buildbot instances
591         https://bugs.webkit.org/show_bug.cgi?id=194863
592
593         Reviewed by Stephanie Lewis.
594
595         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
596
597 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-app] Remove BuilderMapping table
600         https://bugs.webkit.org/show_bug.cgi?id=194961
601
602         Reviewed by Stephanie Lewis.
603
604         Store builder name directly in build table, instead of having a separate
605         table for it.
606
607         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
608         * BuildSlaveSupport/ews-app/ews/models/build.py:
609         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
611
612 2019-02-25  John Wilander  <wilander@apple.com>
613
614         Introduce and adopt new class RegistrableDomain for eTLD+1
615         https://bugs.webkit.org/show_bug.cgi?id=194791
616         <rdar://problem/48179240>
617
618         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
619
620         This patch adds an API test and replaces two instances of
621         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
622
623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
624         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
625         (TestWebKitAPI::TEST):
626             Changed two strings to make sure the registrable domains are still considered
627             invalid and pass the test.
628         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
629         (TestWebKitAPI::TEST):
630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
631         (WTR::InjectedBundle::didReceiveMessageToPage):
632
633 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
634
635         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
636         https://bugs.webkit.org/show_bug.cgi?id=195001
637
638         Reviewed by Carlos Garcia Campos.
639
640         API version 1.0 always includes the functionality previously guarded with
641         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
642         unconditionally.
643
644         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
645         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
646         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
647         (WebViewTest::showInWindow): Ditto.
648         (WebViewTest::hideView): Ditto.
649         * wpe/backends/HeadlessViewBackend.cpp:
650         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
651         * wpe/backends/ViewBackend.cpp:
652         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
653         * wpe/backends/WindowViewBackend.cpp:
654         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
655         WPE_BACKEND_CHECK_VERSION().
656         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
657
658 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
659
660         [Flatpak] Add support for flatpak > 1.1.2
661         https://bugs.webkit.org/show_bug.cgi?id=194088
662
663         Flatpak 1.2 is now out so we need to support that
664         version now.
665
666         Reviewed by Michael Catanzaro.
667
668         * flatpak/flatpakutils.py:
669         (check_flatpak):
670         (FlatpakPackages.__init__):
671         (FlatpakPackages.__detect_packages):
672         (FlatpakPackages.__detect_packages.in):
673         (FlatpakRepos.update):
674
675 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
676
677         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
678         https://bugs.webkit.org/show_bug.cgi?id=194998
679
680         Reviewed by Carlos Garcia Campos.
681
682         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
683         to a Git checkout and using the latest commit containing various fixes
684         and improvements.
685
686 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
687
688         [WPE][GTK] Remove user agent quirk for washingtonpost.com
689         https://bugs.webkit.org/show_bug.cgi?id=194981
690
691         Reviewed by Žan Doberšek.
692
693         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
694         (TestWebKitAPI::TEST):
695
696 2019-02-23  Keith Miller  <keith_miller@apple.com>
697
698         Add new mac target numbers
699         https://bugs.webkit.org/show_bug.cgi?id=194955
700
701         Reviewed by Tim Horton.
702
703         * DumpRenderTree/mac/Configurations/Base.xcconfig:
704         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
705         * MiniBrowser/Configurations/Base.xcconfig:
706         * TestWebKitAPI/Configurations/Base.xcconfig:
707         * WebKitTestRunner/Configurations/Base.xcconfig:
708
709 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
710
711         [WinCairo] Enable wk1/wk2 suffix for platform search path.
712         https://bugs.webkit.org/show_bug.cgi?id=194846
713
714         Reviewed by Don Olmstead.
715
716         Added _search_paths() and _port_specific_expectations_files() for
717         WinCairoPort.
718
719         * Scripts/webkitpy/port/win.py:
720         (WinCairoPort.default_baseline_search_path):
721         (WinCairoPort):
722         (WinCairoPort._port_specific_expectations_files):
723         (WinCairoPort._search_paths):
724
725 2019-02-22  Tim Horton  <timothy_horton@apple.com>
726
727         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
728         https://bugs.webkit.org/show_bug.cgi?id=194963
729
730         Reviewed by Dean Jackson.
731
732         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
733         Do a `contains` check instead of `equals`, because in debug builds we
734         put the GraphicsLayer pointer in a prefix.
735
736 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
737
738         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
739         https://bugs.webkit.org/show_bug.cgi?id=194873
740         <rdar://problem/46701974>
741
742         Reviewed by Tim Horton.
743
744         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
745
746         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
747         (WTR::UIScriptController::menuRect const):
748         (WTR::UIScriptController::isShowingMenu const):
749         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
750         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
751         (WTR::UIScriptController::menuRect const):
752
753         Add a function to query the bounds of the callout menu in content coordinates.
754
755         (WTR::UIScriptController::isShowingMenu const):
756
757         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
758
759         * TestRunnerShared/UIScriptContext/UIScriptController.h:
760         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
761         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
762         (WTR::UIScriptController::rectForMenuAction const):
763         (WTR::UIScriptController::menuRect const):
764         (WTR::UIScriptController::isShowingMenu const):
765         (WTR::findViewInHierarchyOfType): Deleted.
766
767 2019-02-22  Chris Dumez  <cdumez@apple.com>
768
769         Regression(PSON) Unable to preview password-protected documents on iCloud.com
770         https://bugs.webkit.org/show_bug.cgi?id=194954
771         <rdar://problem/48127957>
772
773         Reviewed by Alex Christensen.
774
775         Add API test coverage.
776
777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
778         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
779         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
780         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
781
782 2019-02-22  Chris Dumez  <cdumez@apple.com>
783
784         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
785         https://bugs.webkit.org/show_bug.cgi?id=194924
786         <rdar://problem/48216125>
787
788         Reviewed by Geoffrey Garen.
789
790         Add API test coverage.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
793
794 2019-02-22  Chris Dumez  <cdumez@apple.com>
795
796         Unreviewed, disable API test added in r241928 on iOS.
797
798         The cache is not enabled on devices with less than 3GB of RAM.
799
800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
801
802 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
803
804         Hardcode Visual Viewports on everywhere except iOS WK1
805         https://bugs.webkit.org/show_bug.cgi?id=194928
806
807         Reviewed by Zalan Bujtas.
808
809         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
810         change the default value of the Setting to 'true', and hardcode WebView on iOS to
811         set it to false. The setting has shipped for several years and there's no need to turn
812         it off now.
813
814         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
815         Visual Viewports are not enabled.
816         
817         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
818         that only runs in WK2
819
820         * MiniBrowser/mac/SettingsController.h:
821         * MiniBrowser/mac/SettingsController.m:
822         (-[SettingsController init]):
823         (-[SettingsController _populateMenu]):
824         (-[SettingsController validateMenuItem:]):
825         (-[SettingsController visualViewportEnabled]): Deleted.
826         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
827         * MiniBrowser/mac/WK1BrowserWindowController.m:
828         (-[WK1BrowserWindowController didChangeSettings]):
829         * MiniBrowser/mac/WK2BrowserWindowController.m:
830         (-[WK2BrowserWindowController didChangeSettings]):
831
832 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
833
834         Discard cached processes when clearing website data store
835         https://bugs.webkit.org/show_bug.cgi?id=194894
836
837         Reviewed by Chris Dumez.
838
839         Added a test case.
840
841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
842         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
843
844 2019-02-21  Alex Christensen  <achristensen@webkit.org>
845
846         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
847         https://bugs.webkit.org/show_bug.cgi?id=194914
848         <rdar://problem/47586889>
849
850         Reviewed by Geoffrey Garen.
851
852         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
853         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
854         (TEST):
855         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
856
857 2019-02-21  David Kilzer  <ddkilzer@apple.com>
858
859         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
860         <https://webkit.org/b/194761>
861
862         Reviewed by Myles Maxfield.
863
864         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
865         (WTR::activateSystemCoreWebFonts): Log `error` to console if
866         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
867         to use ARC-compliant cast.
868         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
869         ARC-compliant cast.
870         (WTR::installFakeHelvetica): Log `error` to console if
871         CTFontManagerRegisterFontsForURL() fails, but only on supported
872         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
873         Call CFRelease() on `error` to fix the leak.  Update to use
874         ARC-compliant cast.
875         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
876         cast.
877
878 2019-02-21  Chris Dumez  <cdumez@apple.com>
879
880         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
881         https://bugs.webkit.org/show_bug.cgi?id=194481
882
883         Reviewed by Alex Christensen.
884
885         Give the processes a chance to shutdown and wait until we reached the expected number
886         of processes.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
889
890 2019-02-21  Tim Horton  <timothy_horton@apple.com>
891
892         Fix the macOS build
893
894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
895
896 2019-02-21  Tim Horton  <timothy_horton@apple.com>
897
898         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
899
900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
901         I am a backwards.
902
903 2019-02-21  Tim Horton  <timothy_horton@apple.com>
904
905         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
906
907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
908         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
909         We could force on UI-side compositing, but I feel like the test might be more
910         valuable exercising the normal path on each platform (though the original
911         bug was also UI-side specific). Though we can't validate that the overlay
912         layer was installed successfully, there are layout tests that do that.
913
914 2019-02-21  Tim Horton  <timothy_horton@apple.com>
915
916         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
917         https://bugs.webkit.org/show_bug.cgi?id=194845
918         <rdar://problem/47944579>
919
920         Reviewed by Antti Koivisto.
921
922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
924
925 2019-02-21  Zalan Bujtas  <zalan@apple.com>
926
927         [LFC][Floats] Add support for placing formatting roots in-between floats.
928         https://bugs.webkit.org/show_bug.cgi?id=194902
929
930         Reviewed by Antti Koivisto.
931
932         * LayoutReloaded/misc/LFC-passing-tests.txt:
933
934 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
935
936         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
937         https://bugs.webkit.org/show_bug.cgi?id=194901
938
939         Unreviewed build fix.
940
941         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
942         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
943         WPEBackend-fdo-0.1 as library name.
944
945 2019-02-21  Rob Buis  <rbuis@igalia.com>
946
947         Update MIME type parser
948         https://bugs.webkit.org/show_bug.cgi?id=180526
949
950         Reviewed by Darin Adler.
951
952         Add tests involving leading and trailing whitespace, non-token
953         characters and quoted strings.
954
955         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
956         (TestWebKitAPI::TEST):
957
958 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
959
960         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
961         https://bugs.webkit.org/show_bug.cgi?id=194884
962
963         Reviewed by Michael Catanzaro.
964
965         * PlatformWin.cmake:
966
967 2019-02-20  Chris Dumez  <cdumez@apple.com>
968
969         Add API test for <rdar://problem/47471222>
970         https://bugs.webkit.org/show_bug.cgi?id=194847
971
972         Reviewed by Alex Christensen.
973
974         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
975
976 2019-02-20  Chris Dumez  <cdumez@apple.com>
977
978         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
979         https://bugs.webkit.org/show_bug.cgi?id=194872
980         <rdar://problem/47924500>
981
982         Reviewed by Alex Christensen.
983
984         Add API test coverage.
985
986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
987
988 2019-02-20  Jer Noble  <jer.noble@apple.com>
989
990         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
991         https://bugs.webkit.org/show_bug.cgi?id=191332
992
993         Reviewed by Dean Jackson.
994
995         * Scripts/git-is-in-range: Added.
996
997 2019-02-20  Andy Estes  <aestes@apple.com>
998
999         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1000         https://bugs.webkit.org/show_bug.cgi?id=194869
1001
1002         Rubber-stamped by Jer Noble.
1003
1004         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1005         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1006         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1007         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1010
1011 2019-02-20  Chris Dumez  <cdumez@apple.com>
1012
1013         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1014         https://bugs.webkit.org/show_bug.cgi?id=194857
1015         <rdar://problem/47759323>
1016
1017         Reviewed by Alex Christensen.
1018
1019         Add API test coverage.
1020
1021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1022
1023 2019-02-20  Chris Dumez  <cdumez@apple.com>
1024
1025         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1026         https://bugs.webkit.org/show_bug.cgi?id=194829
1027         <rdar://problem/47889906>
1028
1029         Reviewed by Alexey Proskuryakov.
1030
1031         Every time the TestOptions were changing we were creating both a new Web view and
1032         a new WKContext, which would start a new Network process. In most cases, we only
1033         need to contruct a new Web view and we do can keep reusing the same WKContext.
1034         This patch implements this optimization and thus avoids spinning a lot of new
1035         Network processes while running the layout tests.
1036
1037         * WebKitTestRunner/TestController.cpp:
1038         (WTR::TestController::generateContextConfiguration const):
1039         (WTR::TestController::generatePageConfiguration):
1040         (WTR::TestController::createWebViewWithOptions):
1041         (WTR::TestController::resetPreferencesToConsistentValues):
1042         (WTR::updateTestOptionsFromTestHeader):
1043         * WebKitTestRunner/TestController.h:
1044         * WebKitTestRunner/TestOptions.h:
1045         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1046         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1047         (WTR::TestOptions::hasSameInitializationOptions const):
1048         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1049         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1050         (WTR::TestController::platformAddTestOptions const):
1051
1052 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1053
1054         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1055         https://bugs.webkit.org/show_bug.cgi?id=167941
1056
1057         Reviewed by Carlos Garcia Campos.
1058
1059         * MiniBrowser/gtk/main.c:
1060         (filterSavedCallback): Added.
1061         (main): Support loading a JSON rule set file for content filtering.
1062         * MiniBrowser/wpe/main.cpp:
1063         (filterSavedCallback): Added.
1064         (main): Support loading a JSON rule set file for content filtering.
1065         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1066         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1067         (WTF::derefGPtr): Ditto.
1068         (testEmptyStore):
1069         (testSaveInvalidFilter):
1070         (testSaveLoadFilter):
1071         (testSavedFilterIdentifierMatch):
1072         (testRemoveFilter):
1073         (testSaveMultipleFilters):
1074         (testSaveFilterFromFile):
1075         (testFilterPersistence):
1076         (beforeAll):
1077         (afterAll):
1078         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1079         (removeOldInjectedContentAndResetLists): Also reset content filters.
1080         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1081         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1082         the element affected by the style sheet.
1083         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1084         and returns it to be used by tests.
1085         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1086         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1087         (serverCallback): Add support for serving a CSS style sheet for testing.
1088         (beforeAll): Add call to testUserContentManagerContentFilter().
1089         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1090
1091 2019-02-19  Keith Rollin  <krollin@apple.com>
1092
1093         Add timing information to build output
1094         https://bugs.webkit.org/show_bug.cgi?id=194839
1095         <rdar://problem/48219609>
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1100         emit each project's build time to its output. E.g.,
1101
1102             ** BUILD SUCCEEDED ** [0.132 sec]
1103
1104         * Scripts/webkitdirs.pm:
1105         (XcodeOptions):
1106
1107 2019-02-19  Truitt Savell  <tsavell@apple.com>
1108
1109         Unreviewed, rolling out r241784.
1110
1111         Broke all OpenSource builds.
1112
1113         Reverted changeset:
1114
1115         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1116         instances view"
1117         https://bugs.webkit.org/show_bug.cgi?id=172848
1118         https://trac.webkit.org/changeset/241784
1119
1120 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1121
1122         [LFC][Floats] Remove redundant intersecting logic
1123         https://bugs.webkit.org/show_bug.cgi?id=194804
1124
1125         Reviewed by Antti Koivisto.
1126
1127         * LayoutReloaded/misc/LFC-passing-tests.txt:
1128
1129 2019-02-19  Dean Jackson  <dino@apple.com>
1130
1131         Clean-up output from generate-xcfilelists so it can be filtered
1132         https://bugs.webkit.org/show_bug.cgi?id=194795
1133
1134         Reviewed by Joseph Pecoraro (and Keith Rollin).
1135
1136         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1137         make a slight tweak to filter-build-webkit so such lines are marked
1138         as plain.
1139
1140         * Scripts/filter-build-webkit:
1141         * Scripts/generate-xcfilelists:
1142
1143 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1144
1145         pytest is not correctly auto-installed
1146         https://bugs.webkit.org/show_bug.cgi?id=194707
1147
1148         Reviewed by Carlos Garcia Campos.
1149
1150         * Scripts/webkitpy/thirdparty/__init__.py:
1151         (AutoinstallImportHook._install_pytest):
1152
1153 2019-02-18  Chris Dumez  <cdumez@apple.com>
1154
1155         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1156         https://bugs.webkit.org/show_bug.cgi?id=194797
1157         <rdar://problem/48055151>
1158
1159         Reviewed by Geoffrey Garen.
1160
1161         Add API test coverage.
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1164
1165 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1166
1167         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1168         https://bugs.webkit.org/show_bug.cgi?id=194670
1169         <rdar://problem/39066529>
1170
1171         Reviewed by Tim Horton.
1172
1173         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1174         pasted in an editable area as attachment elements.
1175
1176         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1177         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1178         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1179         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1180         (TestWebKitAPI::TEST):
1181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1182         (WTR::InjectedBundlePage::InjectedBundlePage):
1183
1184 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1185
1186         Fix API test after r241728
1187        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1188
1189         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1190         (TEST):
1191         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1192
1193 2019-02-18  Daniel Bates  <dabates@apple.com>
1194
1195         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1196         https://bugs.webkit.org/show_bug.cgi?id=192824
1197         <rdar://problem/47100332>
1198
1199         Reviewed by Wenson Hsieh.
1200
1201         Fix a bug where the wrong usage code was used for F13 thru F24.
1202
1203         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1204         (keyCodeForDOMFunctionKey):
1205
1206 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1207
1208         Bytecode cache should a have a boot-specific validation
1209         https://bugs.webkit.org/show_bug.cgi?id=194769
1210         <rdar://problem/48149509>
1211
1212         Reviewed by Keith Miller.
1213
1214         Add test for WTF::bootSessionUUIDString()
1215
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1218         (TEST):
1219
1220 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1221
1222         Disable safe browsing in WKWebView and remove its WKPreferences API
1223         https://bugs.webkit.org/show_bug.cgi?id=194723
1224         <rdar://problem/48122993>
1225
1226         Reviewed by Geoffrey Garen.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1229         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1230         (TEST):
1231         (safeBrowsingView):
1232         Make tests use SPI instead of API.
1233
1234 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1235
1236         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1237         https://bugs.webkit.org/show_bug.cgi?id=194586
1238
1239         Reviewed by Ross Kirsling.
1240
1241         * DumpRenderTree/win/DumpRenderTree.cpp:
1242         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1243         * Scripts/webkitpy/port/driver.py:
1244         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1245
1246 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1247
1248         Unreviewed, rolling out r241620.
1249
1250         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1251         (Requested by ddkilzer on #webkit.)
1252
1253         Reverted changeset:
1254
1255         "[WTF] Add environment variable helpers"
1256         https://bugs.webkit.org/show_bug.cgi?id=192405
1257         https://trac.webkit.org/changeset/241620
1258
1259 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1260
1261         [LFC] RenderImage's default intrinsic size is 0.
1262         https://bugs.webkit.org/show_bug.cgi?id=194745
1263
1264         Reviewed by Antti Koivisto.
1265
1266         * LayoutReloaded/misc/LFC-passing-tests.txt:
1267
1268 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1269
1270         [LFC][BFC] Add support for block replaced intrinsic width.
1271         https://bugs.webkit.org/show_bug.cgi?id=194705
1272
1273         Reviewed by Simon Fraser.
1274
1275         * LayoutReloaded/misc/LFC-passing-tests.txt:
1276
1277 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1278
1279         [LFC] Apply min/max width constraints to preferred width computation
1280         https://bugs.webkit.org/show_bug.cgi?id=194739
1281
1282         Reviewed by Simon Fraser.
1283
1284         * LayoutReloaded/misc/LFC-passing-tests.txt:
1285
1286 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1287
1288         [WTF] Add environment variable helpers
1289         https://bugs.webkit.org/show_bug.cgi?id=192405
1290
1291         Reviewed by Michael Catanzaro.
1292
1293         * DumpRenderTree/mac/DumpRenderTree.mm:
1294         (libraryPathForDumpRenderTree):
1295         * DumpRenderTree/win/DumpRenderTree.cpp:
1296         (libraryPathForDumpRenderTree):
1297         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1298         (setUpIOSLayoutTestCommunication):
1299         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1300         (beforeAll):
1301         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1302         (main):
1303         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1304         (WebKitTestBus::run):
1305         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1306         (WTR::getOutputDir):
1307         (WTR::initializeFontConfigSetting):
1308         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1309         (WTR::InjectedBundle::platformInitialize):
1310         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1311         (WTR::topLevelPath):
1312         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1313         (WTR::topLevelPath):
1314         (WTR::getOutputDir):
1315         (WTR::activateFonts):
1316         * WebKitTestRunner/TestController.cpp:
1317         (WTR::TestController::libraryPathForTesting):
1318         (WTR::TestController::generateContextConfiguration const):
1319         (WTR::TestController::generatePageConfiguration):
1320         (WTR::TestController::decideDestinationWithSuggestedFilename):
1321         (WTR::TestController::platformAdjustContext):
1322         * WebKitTestRunner/TestController.h:
1323         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1324         (WTR::TestController::cocoaPlatformInitialize):
1325         (WTR::TestController::platformAdjustContext):
1326         * WebKitTestRunner/gtk/main.cpp:
1327         (main):
1328         * WebKitTestRunner/mac/TestControllerMac.mm:
1329         (WTR::TestController::configureContentExtensionForTest):
1330         * WebKitTestRunner/wpe/main.cpp:
1331         (main):
1332         Utilize WTF::Environment where possible.
1333
1334 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1335
1336         [iOS] WKWebView callout bar is missing Change Writing Direction item
1337         https://bugs.webkit.org/show_bug.cgi?id=190015
1338         <rdar://problem/44810366>
1339
1340         Reviewed by Tim Horton.
1341
1342         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1343         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1344
1345         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1346         (TestWebKitAPI::TEST):
1347
1348 2019-02-15  Chris Dumez  <cdumez@apple.com>
1349
1350         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1351         https://bugs.webkit.org/show_bug.cgi?id=194717
1352         <rdar://problem/47884404>
1353
1354         Reviewed by Brady Eidson.
1355
1356         Add API test coverage.
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1359
1360 2019-02-15  Youenn Fablet  <youenn@apple.com>
1361
1362         Make navigator.mediaDevices SecureContext
1363         https://bugs.webkit.org/show_bug.cgi?id=194666
1364
1365         Reviewed by Eric Carlson.
1366
1367         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1368         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1369         (TEST_F):
1370
1371 2019-02-15  Brian Burg  <bburg@apple.com>
1372
1373         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1374         https://bugs.webkit.org/show_bug.cgi?id=194411
1375         <rdar://problem/47787614>
1376
1377         Reviewed by Joseph Pecoraro.
1378
1379         Remove unnecessary soft linking macro usage.
1380
1381         * DumpRenderTree/mac/TestRunnerMac.mm:
1382         (TestRunner::inspectorTestStubURL):
1383         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1384         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1385         (WTR::TestRunner::inspectorTestStubURL):
1386
1387 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1388
1389         Unreviewed, rolling out r241559 and r241566.
1390         https://bugs.webkit.org/show_bug.cgi?id=194710
1391
1392         Causes layout test crashes under GuardMalloc (Requested by
1393         ryanhaddad on #webkit).
1394
1395         Reverted changesets:
1396
1397         "[WTF] Add environment variable helpers"
1398         https://bugs.webkit.org/show_bug.cgi?id=192405
1399         https://trac.webkit.org/changeset/241559
1400
1401         "Unreviewed build fix for WinCairo Debug after r241559."
1402         https://trac.webkit.org/changeset/241566
1403
1404 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1405
1406         [LFC] Out-of-flow box is never a float box
1407         https://bugs.webkit.org/show_bug.cgi?id=194704
1408
1409         Reviewed by Antti Koivisto.
1410
1411         * LayoutReloaded/misc/LFC-passing-tests.txt:
1412
1413 2019-02-10  Darin Adler  <darin@apple.com>
1414
1415         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1416         https://bugs.webkit.org/show_bug.cgi?id=194487
1417
1418         Reviewed by Daniel Bates.
1419
1420         * DumpRenderTree/win/DumpRenderTree.cpp:
1421         (applicationId): Use makeString instead of String::format.
1422         (main): Ditto.
1423         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1424         (TestWebKitAPI::Util::createURLForResource): Ditto.
1425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1426         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1427
1428         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1429         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1430         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1431         (WTR::createStringWithAttributes): Use appendLiteral.
1432         (WTR::AccessibilityUIElement::helpText const): Ditto.
1433         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1434         directly instead of using String::format.
1435         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1436         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1437
1438 2019-02-15  Truitt Savell  <tsavell@apple.com>
1439
1440         Unreviewed, rolling out r241564.
1441
1442         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1443
1444         Reverted changeset:
1445
1446         "[Mac] WebInspectorUI.framework does not need to be soft-
1447         linked anymore"
1448         https://bugs.webkit.org/show_bug.cgi?id=194411
1449         https://trac.webkit.org/changeset/241564
1450
1451 2019-02-15  Saam barati  <sbarati@apple.com>
1452
1453         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1454         https://bugs.webkit.org/show_bug.cgi?id=194036
1455
1456         Reviewed by Yusuke Suzuki.
1457
1458         * Scripts/run-jsc-stress-tests:
1459
1460 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1461
1462         Fix the build.
1463
1464         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1465         (WTR::UIScriptController::drawSquareInEditableImage):
1466         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1467         (TestWebKitAPI::drawSquareInEditableImage):
1468
1469 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1470
1471         Fix the build.
1472
1473         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1474         (WTR::UIScriptController::drawSquareInEditableImage):
1475         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1476         (TestWebKitAPI::drawSquareInEditableImage):
1477
1478 2019-02-14  Brian Burg  <bburg@apple.com>
1479
1480         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1481         https://bugs.webkit.org/show_bug.cgi?id=194411
1482         <rdar://problem/47787614>
1483
1484         Reviewed by Joseph Pecoraro.
1485
1486         Remove unnecessary soft linking macro usage.
1487
1488         * DumpRenderTree/mac/TestRunnerMac.mm:
1489         (TestRunner::inspectorTestStubURL):
1490         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1491         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1492         (WTR::TestRunner::inspectorTestStubURL):
1493
1494 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1495
1496         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1497         https://bugs.webkit.org/show_bug.cgi?id=194599
1498
1499         Reviewed by Lucas Forschler.
1500
1501         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1502         (StatusBubble._build_bubble):
1503
1504 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1505
1506         [ews-app] Set Foreign Key in Django build model
1507         https://bugs.webkit.org/show_bug.cgi?id=194667
1508
1509         Reviewed by Lucas Forschler.
1510
1511         * BuildSlaveSupport/ews-app/ews/models/build.py:
1512         (Build):
1513
1514 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1515
1516         [WTF] Add environment variable helpers
1517         https://bugs.webkit.org/show_bug.cgi?id=192405
1518
1519         Reviewed by Michael Catanzaro.
1520
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (libraryPathForDumpRenderTree):
1523         * DumpRenderTree/win/DumpRenderTree.cpp:
1524         (libraryPathForDumpRenderTree):
1525         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1526         (setUpIOSLayoutTestCommunication):
1527         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1528         (TestWebKitAPI::strip):
1529         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1530         (beforeAll):
1531         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1532         (main):
1533         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1534         (WebKitTestBus::run):
1535         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1536         (WTR::getOutputDir):
1537         (WTR::initializeFontConfigSetting):
1538         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1539         (WTR::InjectedBundle::platformInitialize):
1540         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1541         (WTR::topLevelPath):
1542         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1543         (WTR::topLevelPath):
1544         (WTR::getOutputDir):
1545         (WTR::activateFonts):
1546         * WebKitTestRunner/TestController.cpp:
1547         (WTR::TestController::libraryPathForTesting):
1548         (WTR::TestController::generateContextConfiguration const):
1549         (WTR::TestController::generatePageConfiguration):
1550         (WTR::TestController::decideDestinationWithSuggestedFilename):
1551         (WTR::TestController::platformAdjustContext):
1552         * WebKitTestRunner/TestController.h:
1553         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1554         (WTR::TestController::cocoaPlatformInitialize):
1555         (WTR::TestController::platformAdjustContext):
1556         * WebKitTestRunner/gtk/main.cpp:
1557         (main):
1558         * WebKitTestRunner/mac/TestControllerMac.mm:
1559         (WTR::TestController::configureContentExtensionForTest):
1560         * WebKitTestRunner/wpe/main.cpp:
1561         (main):
1562         Utilize WTF::Environment where possible.
1563
1564 2019-02-14  Chris Dumez  <cdumez@apple.com>
1565
1566         [PSON] Introduce a WebContent Process cache
1567         https://bugs.webkit.org/show_bug.cgi?id=194594
1568         <rdar://problem/46793397>
1569
1570         Reviewed by Geoff Garen.
1571
1572         Update API tests to turn on the WebContent Process cache.
1573
1574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1575
1576 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1577
1578         Unreviewed, build fix after r241480
1579
1580         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1581         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1582         (-[DragAndDropSimulator initWithWebView:]):
1583
1584 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1585
1586         AX: ARIA Reflection was disabled in error
1587         https://bugs.webkit.org/show_bug.cgi?id=194647
1588         <rdar://problem/48068336>
1589
1590         Reviewed by Ryosuke Niwa.
1591
1592         Remove test override now that this feature should be enabled by default.
1593
1594         * WebKitTestRunner/TestController.cpp:
1595         (WTR::TestController::resetPreferencesToConsistentValues):
1596
1597 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1598
1599         Unreviewed, rolling out r241486.
1600         https://bugs.webkit.org/show_bug.cgi?id=194655
1601
1602         causing API failures in builds (Requested by ShawnRoberts on
1603         #webkit).
1604
1605         Reverted changeset:
1606
1607         "[Cocoa] Media elements will restart network buffering just
1608         before suspending"
1609         https://bugs.webkit.org/show_bug.cgi?id=193691
1610         https://trac.webkit.org/changeset/241486
1611
1612 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1613
1614         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1615         https://bugs.webkit.org/show_bug.cgi?id=194622
1616
1617         Reviewed by Antti Koivisto.
1618
1619         * LayoutReloaded/misc/LFC-passing-tests.txt:
1620
1621 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1622
1623         [LFC] Shrink-to-fit-width should be constrained by min/max width
1624         https://bugs.webkit.org/show_bug.cgi?id=194653
1625
1626         Reviewed by Antti Koivisto.
1627
1628         * LayoutReloaded/misc/LFC-passing-tests.txt:
1629
1630 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1631
1632         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1633         https://bugs.webkit.org/show_bug.cgi?id=194641
1634
1635         Reviewed by Geoffrey Garen.
1636
1637         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1638         so that the test would fail without this fix.
1639
1640         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1641         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1642
1643 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1644
1645         [ews-app] Change log level for a log statement
1646
1647         Unreviewed minor fix.
1648
1649         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1650         (Patch.save_patch):
1651
1652 2019-02-13  Jer Noble  <jer.noble@apple.com>
1653
1654         [Cocoa] Media elements will restart network buffering just before suspending
1655         https://bugs.webkit.org/show_bug.cgi?id=193691
1656
1657         Reviewed by Eric Carlson.
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1661         (TEST):
1662
1663 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1664
1665         [ews-app] Fetch builder id to name mapping
1666         https://bugs.webkit.org/show_bug.cgi?id=194355
1667
1668         Reviewed by Lucas Forschler.
1669
1670         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1671         (Buildbot.get_builder_id_to_name_mapping):
1672         (Buildbot._get_display_name_from_builder_name):
1673
1674 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1675
1676         Further restricting webarchive loads
1677         https://bugs.webkit.org/show_bug.cgi?id=194567
1678         <rdar://problem/47610130>
1679
1680         Reviewed by Youenn Fablet.
1681
1682         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1683         navigations on drop.
1684
1685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1686         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1687         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1688         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1689         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1690         (TestWebKitAPI::TEST):
1691         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1692         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1693         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1694         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1695         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1696         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1697         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1698
1699 2019-02-13  John Wilander  <wilander@apple.com>
1700
1701         Store Ad Click Attribution requests in the network process
1702         https://bugs.webkit.org/show_bug.cgi?id=194510
1703         <rdar://problem/47650118>
1704
1705         Reviewed by Alex Christensen and Daniel Bates.
1706
1707         This patch adds two TestRunner functions:
1708         - dumpAdClickAttribution()
1709         - clearAdClickAttribution()
1710
1711         They call into the network process to dump and clear Ad Click
1712         Attribution state, respectively.
1713
1714         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1715         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1716         (WTR::TestRunner::dumpAdClickAttribution):
1717         (WTR::TestRunner::clearAdClickAttribution):
1718         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::TestController::resetStateToConsistentValues):
1721         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1722         (WTR::adClickAttributionStringResultCallback):
1723         (WTR::TestController::dumpAdClickAttribution):
1724         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1725         (WTR::adClickAttributionVoidCallback):
1726         (WTR::TestController::clearAdClickAttribution):
1727         * WebKitTestRunner/TestController.h:
1728         * WebKitTestRunner/TestInvocation.cpp:
1729         (WTR::TestInvocation::dumpResults):
1730         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1731         (WTR::TestInvocation::dumpAdClickAttribution):
1732         * WebKitTestRunner/TestInvocation.h:
1733
1734 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1735
1736         [ews-app] Generate status-bubble
1737         https://bugs.webkit.org/show_bug.cgi?id=194572
1738
1739         Reviewed by Lucas Forschler.
1740
1741         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1742         (StatusBubble._build_bubble):
1743         (StatusBubble._should_show_bubble_for):
1744         (StatusBubble._build_bubbles_for_patch):
1745
1746 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-app] Add status bubble html template
1749         https://bugs.webkit.org/show_bug.cgi?id=194571
1750
1751         Reviewed by Lucas Forschler.
1752
1753         * BuildSlaveSupport/ews-app/ews/templates: Added.
1754         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1755
1756 2019-02-12  Chris Dumez  <cdumez@apple.com>
1757
1758         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1759         https://bugs.webkit.org/show_bug.cgi?id=194568
1760         <rdar://problem/47944490>
1761
1762         Reviewed by Ryosuke Niwa.
1763
1764         Add API test coverage.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1767         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1768
1769 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1770
1771         webkitpy: Remove bug_dummy from parsed test expectations
1772         https://bugs.webkit.org/show_bug.cgi?id=194562
1773         <rdar://problem/47853999>
1774
1775         Reviewed by Lucas Forschler.
1776
1777         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1778         (TestExpectationParser):
1779         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1780         skipped tests.
1781         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1782
1783 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1784
1785         [ews-app] Add method to fetch patch
1786         https://bugs.webkit.org/show_bug.cgi?id=194518
1787
1788         Reviewed by Lucas Forschler.
1789
1790         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1791         (Patch.get_patch):
1792
1793 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1794
1795         [LFC] Expand tests coverage (60 new tests -> 860)
1796
1797         Unreviewed test gardening (run-singly, --child-processes=1).
1798
1799         * LayoutReloaded/misc/LFC-passing-tests.txt:
1800
1801 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1802
1803         Allow pages to trigger programmatic paste from script on iOS
1804         https://bugs.webkit.org/show_bug.cgi?id=194271
1805         <rdar://problem/47808810>
1806
1807         Reviewed by Tim Horton.
1808
1809         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1810
1811         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1812         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1813         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1814         (WTR::UIScriptController::rectForMenuAction const):
1815
1816         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1817         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1818         for when the menu is shown or hidden.
1819
1820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1821         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1822         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1823         (WTR::UIScriptController::setDidShowMenuCallback):
1824         (WTR::UIScriptController::didShowMenuCallback const):
1825         (WTR::UIScriptController::setDidHideMenuCallback):
1826         (WTR::UIScriptController::didHideMenuCallback const):
1827         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1828         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1829         (WTR::UIScriptController::rectForMenuAction const):
1830         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1831         * WebKitTestRunner/TestController.cpp:
1832         (WTR::TestController::resetPreferencesToConsistentValues):
1833         (WTR::updateTestOptionsFromTestHeader):
1834         * WebKitTestRunner/TestOptions.h:
1835
1836         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1837         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1838
1839         (WTR::TestOptions::hasSameInitializationOptions const):
1840         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1841         (WTR::UIScriptController::calendarType const):
1842         (WTR::UIScriptController::platformUndoManager const):
1843         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1844         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1845         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1846         (-[TestRunnerWKWebView dealloc]):
1847         (-[TestRunnerWKWebView _didShowMenu]):
1848         (-[TestRunnerWKWebView _didHideMenu]):
1849
1850         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1851
1852         * WebKitTestRunner/ios/TestControllerIOS.mm:
1853         (WTR::handleMenuWillHideNotification):
1854         (WTR::handleMenuDidHideNotification):
1855         (WTR::TestController::platformInitialize):
1856         (WTR::TestController::platformDestroy):
1857         (WTR::TestController::platformResetStateToConsistentValues):
1858
1859         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1860         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1861
1862         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1863         (WTR::forEachViewInHierarchy):
1864         (WTR::findViewInHierarchyOfType):
1865
1866         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1867         functions that dig through a given view's hierarchy in search of a view of a given class.
1868
1869         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1870         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1871         (WTR::UIScriptController::selectionCaretViewRect const):
1872         (WTR::UIScriptController::selectionRangeViewRects const):
1873         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1874         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1875
1876         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1877
1878         (WTR::UIScriptController::rectForMenuAction const):
1879
1880         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1881         callout bar) whose label matches the given string.
1882
1883         (WTR::UIScriptController::platformContentView const):
1884
1885         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1886         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1887         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1888
1889         (WTR::UIScriptController::platformUndoManager const): Deleted.
1890         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1891         (WTR::UIScriptController::platformContentView const):
1892         (WTR::UIScriptController::platformUndoManager const): Deleted.
1893
1894 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1895
1896         webkitpy: No option to only show unexpected failures in results.html for iPad
1897         https://bugs.webkit.org/show_bug.cgi?id=194554
1898         <rdar://problem/47922442>
1899
1900         Rubber-stamped by Aakash Jain.
1901
1902         Just because a TestExpecations file does not exist for a specific platform does not mean that
1903         TestExpecations are not being used, given that platforms inherit test expectations.
1904
1905         * Scripts/webkitpy/port/base.py:
1906         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1907         * Scripts/webkitpy/port/base_unittest.py:
1908         (PortTest.test_uses_test_expectations_file):
1909
1910 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1911
1912         Remove setDefersLoading infrastructure from WebKit2
1913         https://bugs.webkit.org/show_bug.cgi?id=194506
1914
1915         Reviewed by Brady Eidson.
1916
1917         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1919         (WTR::TestRunner::setDefersLoading): Deleted.
1920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1921
1922 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1923
1924         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1925         https://bugs.webkit.org/show_bug.cgi?id=194522
1926         <rdar://problem/47789393>
1927
1928         Reviewed by Chris Dumez.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1932         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1933         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1934
1935 2019-02-12  Andy Estes  <aestes@apple.com>
1936
1937         [iOSMac] Enable Parental Controls Content Filtering
1938         https://bugs.webkit.org/show_bug.cgi?id=194521
1939         <rdar://39732376>
1940
1941         Reviewed by Tim Horton.
1942
1943         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1944
1945 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1946
1947         [LFC][IFC] Add intrinsic width support for float boxes.
1948         https://bugs.webkit.org/show_bug.cgi?id=194528
1949
1950         Reviewed by Antti Koivisto.
1951
1952         Expand tests coverage (2 new tests -> 800).
1953         (This is the correct test ordering --runs-singly --child-processes=1)
1954
1955         * LayoutReloaded/misc/LFC-passing-tests.txt:
1956
1957 2019-02-12  Rob Buis  <rbuis@igalia.com>
1958
1959         Implement serializing in MIME type parser
1960         https://bugs.webkit.org/show_bug.cgi?id=193909
1961
1962         Reviewed by Darin Adler.
1963
1964         Add various tests involving upper case, non-ASCII, control/null characters,
1965         various HTTP whitespace, single quotes and an unpaired surrogate.
1966
1967         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1968         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1969         (TestWebKitAPI::serializeIfValid):
1970         (TestWebKitAPI::TEST):
1971
1972 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1973
1974         [Cocoa] Ask platform for generic font family mappings
1975         https://bugs.webkit.org/show_bug.cgi?id=187723
1976         <rdar://problem/41892438>
1977
1978         Reviewed by Brent Fulgham.
1979
1980         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1981
1982         * DumpRenderTree/mac/DumpRenderTree.mm:
1983         (allowedFontFamilySet):
1984         * WebKitTestRunner/mac/TestControllerMac.mm:
1985         (WTR::allowedFontFamilySet):
1986
1987 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1988
1989         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1990         https://bugs.webkit.org/show_bug.cgi?id=193622
1991
1992         Reviewed by Michael Catanzaro.
1993
1994         This adds support for loading content extension rule sets from the JSON files which
1995         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1996         of WKTR for this could be removed, but that is left for a follow-up patch with
1997         cleanups.
1998
1999         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2000         * WebKitTestRunner/TestController.cpp:
2001         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2002         avoid having the null-terminator copied into the result.
2003         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2004         part of the preparations to run a test.
2005         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2006         (WTR::contentExtensionStoreCallback): Added.
2007         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2008         used for content extensions test.
2009         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2010         extensions and compiling the JSON rule set for tests involving content extensions.
2011         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2012         testing and disables content extensions.
2013         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2014         resetContentExtensions().
2015         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2016         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2017         configureContentExtensionForTest(), and userContentController().
2018
2019 2019-02-11  Daniel Bates  <dabates@apple.com>
2020
2021         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2022         https://bugs.webkit.org/show_bug.cgi?id=191446
2023         <rdar://problem/45929460>
2024
2025         Reviewed by Tim Horton.
2026
2027         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2028
2029         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2030         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2031         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2032         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2033         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2034         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2035         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2036         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2037         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2038         (WTR::arrayLength):
2039         (WTR::parseModifierArray):
2040         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2041         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2042         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2043         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2044
2045 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2046
2047         Unreviewed, rolling out r241272 and r241276.
2048         https://bugs.webkit.org/show_bug.cgi?id=194514
2049
2050         Broke the Apple Internal build and the fix requires human
2051         intervention :( (Requested by dydz on #webkit).
2052
2053         Reverted changesets:
2054
2055         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2056         https://bugs.webkit.org/show_bug.cgi?id=191446
2057         https://trac.webkit.org/changeset/241272
2058
2059         "Fix internal iOS build after r241272"
2060         https://bugs.webkit.org/show_bug.cgi?id=191446
2061         https://trac.webkit.org/changeset/241276
2062
2063 2019-02-11  Truitt Savell  <tsavell@apple.com>
2064
2065         Unreviewed, rolling out r241269.
2066
2067         Caused 5 layout tests crashes on Mac WK1
2068
2069         Reverted changeset:
2070
2071         "DumpRenderTree should report unknown options"
2072         https://bugs.webkit.org/show_bug.cgi?id=191303
2073         https://trac.webkit.org/changeset/241269
2074
2075 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2076
2077         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2078         https://bugs.webkit.org/show_bug.cgi?id=194313
2079
2080         Reviewed by Tim Horton.
2081
2082         Add a helper to determine whether the web view is presenting modal UI.
2083
2084         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2085         (WTR::UIScriptController::isPresentingModally const):
2086         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2087         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2088         (WTR::UIScriptController::isPresentingModally const):
2089         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2090         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2091         (WTR::UIScriptController::calendarType const): Deleted.
2092         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2093         (WTR::UIScriptController::isPresentingModally const):
2094         (WTR::UIScriptController::calendarType const):
2095         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2096         (WTR::UIScriptController::calendarType const):
2097
2098 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2099
2100         GCHeapInspector: Show the retained sizes in more places
2101         https://bugs.webkit.org/show_bug.cgi?id=194464
2102
2103         Reviewed by Simon Fraser.
2104
2105         * GCHeapInspector/gc-heap-inspector.html:
2106         * GCHeapInspector/script/interface.js:
2107         (HeapInspectorUtils.humanReadableSize):
2108         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2109         (HeapInspectorUtils.spanForNode.span.span):
2110         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2111         (HeapSnapshotInspector.prototype.buildRoots):
2112
2113 2019-02-11  Daniel Bates  <dabates@apple.com>
2114
2115         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2116         https://bugs.webkit.org/show_bug.cgi?id=191446
2117         <rdar://problem/45929460>
2118
2119         Reviewed by Tim Horton.
2120
2121         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2122
2123         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2124         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2125         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2126         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2127         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2128         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2129         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2130         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2132         (WTR::arrayLength):
2133         (WTR::parseModifierArray):
2134         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2135         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2136         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2137         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2138
2139 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2140
2141         DumpRenderTree should report unknown options
2142         https://bugs.webkit.org/show_bug.cgi?id=191303
2143
2144         Reviewed by Frédéric Wang.
2145
2146         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2147         to report unknown options.
2148         Added and assigned test options which are currently used in tests.
2149
2150         * DumpRenderTree/TestOptions.cpp:
2151         (TestOptions::TestOptions):
2152
2153 2019-02-11  Truitt Savell  <tsavell@apple.com>
2154
2155         Unreviewed, rolling out r241229.
2156
2157         Revision broke internal builds for watchOS.
2158
2159         Reverted changeset:
2160
2161         "[Cocoa] Ask platform for generic font family mappings"
2162         https://bugs.webkit.org/show_bug.cgi?id=187723
2163         https://trac.webkit.org/changeset/241229
2164
2165 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2166
2167         [WinCairo][MiniBrowser] Basic authentication always fails.
2168         https://bugs.webkit.org/show_bug.cgi?id=194496
2169
2170         Reviewed by Don Olmstead.
2171
2172         * MiniBrowser/win/DialogHelper.h:
2173         (Dialog::getText):
2174
2175 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2176
2177         [GStreamer] GstMappedBuffer testsuite build fails
2178         https://bugs.webkit.org/show_bug.cgi?id=194495
2179
2180         Reviewed by Carlos Garcia Campos.
2181
2182         Fix the build by explicitely adding the gstreamer1.0-audio include
2183         directories to the include path.
2184
2185         * TestWebKitAPI/PlatformGTK.cmake:
2186         * TestWebKitAPI/PlatformWPE.cmake:
2187
2188 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2189
2190         [GTK][WPE] Add enable-javascript-markup setting
2191         https://bugs.webkit.org/show_bug.cgi?id=193439
2192
2193         Reviewed by Michael Catanzaro.
2194
2195         Add test cases to check the new setting.
2196
2197         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2198         (testWebKitSettings):
2199         (testWebKitSettingsJavaScriptMarkup):
2200         (beforeAll):
2201
2202 2019-02-10  Darin Adler  <darin@apple.com>
2203
2204         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2205         https://bugs.webkit.org/show_bug.cgi?id=194485
2206
2207         Reviewed by Daniel Bates.
2208
2209         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2210
2211 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2212
2213         Add more tests for clampTo<>()
2214         https://bugs.webkit.org/show_bug.cgi?id=194462
2215
2216         Reviewed by Geoffrey Garen.
2217
2218         Darin suggested to test the very last floating point number
2219         at the boundaries when truncating to integer.
2220         I added test for max/min and max-1/min-1.
2221
2222         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2223         (TestWebKitAPI::TEST):
2224
2225 2019-02-09  Darin Adler  <darin@apple.com>
2226
2227         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2228         https://bugs.webkit.org/show_bug.cgi?id=194021
2229
2230         Reviewed by Geoffrey Garen.
2231
2232         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2233         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2234         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2235
2236 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2237
2238         [LFC][IFC] Add intrinsic width support for basic inline containers
2239         https://bugs.webkit.org/show_bug.cgi?id=194473
2240
2241         Reviewed by Antti Koivisto.
2242
2243         Expand tests coverage (11 new tests -> 798)
2244
2245         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2246
2247 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2248
2249         Fix MiniBrowser's entitlements
2250         https://bugs.webkit.org/show_bug.cgi?id=192431
2251
2252         Reviewed by Joseph Pecoraro.
2253
2254         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2255         files, making it impossible to load any extension.
2256
2257         * MiniBrowser/MiniBrowser.entitlements:
2258
2259 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2260
2261         [Cocoa] Ask platform for generic font family mappings
2262         https://bugs.webkit.org/show_bug.cgi?id=187723
2263         <rdar://problem/41892438>
2264
2265         Reviewed by Brent Fulgham.
2266
2267         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2268
2269         * DumpRenderTree/mac/DumpRenderTree.mm:
2270         (allowedFontFamilySet):
2271         * WebKitTestRunner/mac/TestControllerMac.mm:
2272         (WTR::allowedFontFamilySet):
2273
2274 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2275
2276         [GTK] Implement back/forward touchpad gesture
2277         https://bugs.webkit.org/show_bug.cgi?id=193919
2278
2279         Reviewed by Michael Catanzaro.
2280
2281         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2282         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2283
2284 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2285
2286         Add SPI to use networking daemon instead of XPC service
2287         https://bugs.webkit.org/show_bug.cgi?id=194427
2288
2289         Reviewed by Geoffrey Garen
2290
2291         * MiniBrowser/MiniBrowser.entitlements:
2292
2293 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2294
2295         [ews-build] Ensure that every builder in config.json has short name
2296         https://bugs.webkit.org/show_bug.cgi?id=194461
2297
2298         Reviewed by Lucas Forschler.
2299
2300         * BuildSlaveSupport/ews-build/loadConfig.py:
2301         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2302
2303 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2304
2305         [ews-build] Add short name to config.json
2306         https://bugs.webkit.org/show_bug.cgi?id=194456
2307
2308         Reviewed by Lucas Forschler.
2309
2310         * BuildSlaveSupport/ews-build/config.json: Added short name.
2311         * BuildSlaveSupport/ews-build/loadConfig.py:
2312         (loadBuilderConfig): Set the short name as the builder description.
2313
2314 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2315
2316         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2317         https://bugs.webkit.org/show_bug.cgi?id=194418
2318
2319         Reviewed by Lucas Forschler.
2320
2321         Do not include errors trying when finding crashlogs at the end of
2322         a run-webkit-tests run since we don't process those errors.
2323
2324         * Scripts/webkitpy/port/darwin.py:
2325         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2326         * Scripts/webkitpy/port/ios_device.py:
2327         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2328         * Scripts/webkitpy/port/watch_device.py:
2329         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2330
2331 2019-02-08  Beth Dakin  <bdakin@apple.com>
2332
2333         Add afterScreenUpdates to WKSnapshotConfiguration
2334         https://bugs.webkit.org/show_bug.cgi?id=194362
2335         -and corresponding-
2336         <rdar://problem/40655528> Please add an "after screen updates" property to 
2337         WKSnapshotConfiguration (to solve blank snapshots)
2338
2339         Reviewed by Tim Horton.
2340
2341         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2342         (TEST):
2343
2344 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2345
2346         clampTo(): do not convert the input to double when dealing with integers
2347         https://bugs.webkit.org/show_bug.cgi?id=194263
2348         <rdar://problem/47692312>
2349
2350         Reviewed by Darin Adler.
2351
2352         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2353         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2354         (TestWebKitAPI::testClampFloatingPointToInteger):
2355         (TestWebKitAPI::testClampSameSignIntegers):
2356         (TestWebKitAPI::testClampUnsignedToSigned):
2357         (TestWebKitAPI::testClampSignedToUnsigned):
2358
2359 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2360
2361         webkitpy: Respect --dedicated-simulators flag
2362         https://bugs.webkit.org/show_bug.cgi?id=194416
2363         <rdar://problem/47894722>
2364
2365         Reviewed by Lucas Forschler.
2366
2367         * Scripts/webkitpy/port/device_port.py:
2368         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2369         available devices can be safely ignored.
2370
2371 2019-02-07  Keith Rollin  <krollin@apple.com>
2372
2373         Remove extra copy of 100x100-red.tga
2374         https://bugs.webkit.org/show_bug.cgi?id=194371
2375         <rdar://problem/47873465>
2376
2377         Reviewed by Said Abou-Hallawa.
2378
2379         In order to help it pass its tests, Bug 194190 added a second copy of
2380         the file 100x100-red.tga. However, it turns out that this additional
2381         file wasn't actually needed, and that that sole previous copy was
2382         sufficient. At the same time, this second copy -- which was copied to
2383         the same location in the build output as the first copy -- now caused
2384         XCBuild to complain because there were two production rules for the
2385         same output file. Address this by removing the newly-added extra copy.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2389
2390 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2391
2392         Deprecate WKBundlePageSetDefersLoading
2393         https://bugs.webkit.org/show_bug.cgi?id=191394
2394
2395         Reviewed by Dean Jackson.
2396
2397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2398         (WTR::TestRunner::setDefersLoading):
2399
2400 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2401
2402         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2403         https://bugs.webkit.org/show_bug.cgi?id=194391
2404
2405         Reviewed by Antti Koivisto.
2406
2407         * LayoutReloaded/misc/LFC-passing-tests.txt:
2408
2409 2019-02-06  Keith Rollin  <krollin@apple.com>
2410
2411         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2412         https://bugs.webkit.org/show_bug.cgi?id=193975
2413         <rdar://problem/47643306>
2414
2415         Reviewed by Tim Horton.
2416
2417         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2418         the Info.plist file into the bundle. This step is not necessary as the
2419         implicit "bundle up all the build products into a framework" build
2420         phase does this already. Having the Copy Bundle Resources phase do
2421         this causes a conflict under XCBuild, which objects to two build
2422         phases producing the same file (Info.plist). Address this by removing
2423         Info.plist from the Copy Bundle Resources phase.
2424
2425         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2426
2427 2019-02-06  Keith Rollin  <krollin@apple.com>
2428
2429         Really enable the automatic checking and regenerations of .xcfilelists during builds
2430         https://bugs.webkit.org/show_bug.cgi?id=194357
2431         <rdar://problem/47861231>
2432
2433         Reviewed by Chris Dumez.
2434
2435         Bug 194124 was supposed to enable the automatic checking and
2436         regenerating of .xcfilelist files during the build. While related
2437         changes were included in that patch, the change to actually enable the
2438         operation somehow was omitted. This patch actually enables the
2439         operation. The check-xcfilelist.sh scripts now check
2440         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2441         from the checking.
2442
2443         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2444         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2445
2446 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2447
2448         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2449         <https://webkit.org/b/194286>
2450         <rdar://problem/47815558>
2451
2452         Reviewed by Alexey Proskuryakov.
2453
2454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2455         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2456         WKRetainPtr<> to avoid leaking the WKDataRef.
2457
2458 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2459
2460         Unreviewed, fix a typo
2461
2462         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2463
2464 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2465
2466         [GTK][WPE] force libpsl build to use ICU in jhbuild
2467         https://bugs.webkit.org/show_bug.cgi?id=194288
2468
2469         Reviewed by Carlos Garcia Campos.
2470
2471         * gtk/jhbuild.modules:
2472         Require ICU for libpsl build in jhbuild, like done in WPE.
2473
2474 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2475
2476         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2477         https://bugs.webkit.org/show_bug.cgi?id=194209
2478
2479         Reviewed by Carlos Garcia Campos.
2480
2481         Enhance TestCookieManager to ensure this doesn't happen again.
2482
2483         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2484         (testCookieManagerPersistentStorage):
2485         (beforeAll):
2486
2487 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2488
2489         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2490         https://bugs.webkit.org/show_bug.cgi?id=194324
2491
2492         Reviewed by Andy Estes.
2493
2494         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2495         part of the name is already implicit, since this is in testing code in TestOptions.
2496
2497         * WebKitTestRunner/TestController.cpp:
2498         (WTR::TestController::generateContextConfiguration const):
2499         (WTR::updateTestOptionsFromTestHeader):
2500         * WebKitTestRunner/TestOptions.h:
2501         (WTR::TestOptions::hasSameInitializationOptions const):
2502
2503 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2504
2505         [ews-build] Allow * as platform for builders and workers
2506         https://bugs.webkit.org/show_bug.cgi?id=188533
2507
2508         Reviewed by Lucas Forschler.
2509
2510         * BuildSlaveSupport/ews-build/loadConfig.py:
2511         (checkWorkersAndBuildersForConsistency):
2512
2513 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2514
2515         [ews-build] Add few bots to config.json
2516         https://bugs.webkit.org/show_bug.cgi?id=194304
2517
2518         Reviewed by Lucas Forschler.
2519
2520         * BuildSlaveSupport/ews-build/config.json:
2521
2522 2019-02-05  Keith Rollin  <krollin@apple.com>
2523
2524         Enable the automatic checking and regenerations of .xcfilelists during builds
2525         https://bugs.webkit.org/show_bug.cgi?id=194124
2526         <rdar://problem/47721277>
2527
2528         Reviewed by Tim Horton.
2529
2530         Bug 193790 add a facility for checking -- during build time -- that
2531         any needed .xcfilelist files are up-to-date and for updating them if
2532         they are not. This facility was initially opt-in by setting
2533         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2534         the process seemed robust. Its now time to enable this facility and
2535         make it opt-out. If there is a need to disable this facility, set and
2536         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2537         running `make` or `build-webkit`, or before running Xcode from the
2538         command line.
2539
2540         Additionally, remove the step that generates a list of source files
2541         going into the UnifiedSources build step. It's only necessarily to
2542         specify Sources.txt and SourcesCocoa.txt as inputs.
2543
2544         * Scripts/generate-xcfilelists:
2545
2546 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2547
2548         [GTK][WPE] force libpsl build to use ICU in jhbuild
2549         https://bugs.webkit.org/show_bug.cgi?id=194288
2550
2551         Reviewed by Philippe Normand.
2552
2553         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2554         This can cause build failures if libidn is detected but libunistring is not available.
2555
2556         Make sure that ICU is used for runtime and builtin PSL data.
2557
2558         * gtk/jhbuild.modules:
2559         * wpe/jhbuild.modules:
2560
2561 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2562
2563         [ews-app] Modified timestamp should be updated on updating data
2564         https://bugs.webkit.org/show_bug.cgi?id=194295
2565
2566         Reviewed by Lucas Forschler.
2567
2568         * BuildSlaveSupport/ews-app/ews/models/build.py:
2569         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2570         * BuildSlaveSupport/ews-app/ews/models/step.py:
2571
2572 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2573
2574         Unreviewed, rolling out r240742.
2575
2576         Causes crashes on iOS simulator.
2577
2578         Reverted changeset:
2579
2580         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2581         not focused in a content-editable element"
2582         https://bugs.webkit.org/show_bug.cgi?id=192824
2583         https://trac.webkit.org/changeset/240742
2584
2585 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2586
2587         run-webkit-tests emits message "...running None" when running tests
2588         https://bugs.webkit.org/show_bug.cgi?id=194133
2589         <rdar://problem/47724738>
2590
2591         Reviewed by Lucas Forschler.
2592
2593         * Scripts/webkitpy/xcode/device_type.py:
2594         (DeviceType.__str__): Use both version mapping tables and use just the variant
2595         name if no version name is available.
2596         * Scripts/webkitpy/xcode/device_type_unittest.py:
2597         (DeviceTypeTest):
2598         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2599         an associated named.
2600
2601 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2602
2603         [WPE] require python3-setuptools for meson build in jhbuild
2604         https://bugs.webkit.org/show_bug.cgi?id=194287
2605
2606         Reviewed by Philippe Normand.
2607
2608         python3-setuptools is needed to build meson in jhbuild.
2609         It is already required by the GTK port.
2610
2611         * wpe/install-dependencies:
2612
2613 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2614
2615         [ews-app] Add method to save BuilderMapping to database
2616         https://bugs.webkit.org/show_bug.cgi?id=194264
2617
2618         Reviewed by Lucas Forschler.
2619
2620         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2621         (BuilderMapping.__str__):
2622         (BuilderMapping):
2623         (BuilderMapping.save_mapping):
2624         (BuilderMapping.update_mapping):
2625         (BuilderMapping.get_existing_mapping):
2626         (BuilderMapping.is_valid_mapping):
2627
2628 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-app] Add timestamp fields for BuilderMappings
2631         https://bugs.webkit.org/show_bug.cgi?id=194266
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2636         (BuilderMapping):
2637
2638 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2639
2640         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2641         https://bugs.webkit.org/show_bug.cgi?id=174816
2642
2643         Reviewed by Michael Catanzaro.
2644
2645         Add tests for webkit_uri_for_display().
2646
2647         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2648         (testURIForDisplayUnaffected):
2649         (testURIForDisplayAffected):
2650         (beforeAll):
2651         (afterAll):
2652         * TestWebKitAPI/glib/CMakeLists.txt:
2653
2654 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2655
2656         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2657         https://bugs.webkit.org/show_bug.cgi?id=194158
2658         <rdar://problem/47737268>
2659
2660         Rubber-stamped by Aakash Jain.
2661
2662         * Scripts/webkitpy/port/device_port.py:
2663         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2664
2665 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2666
2667         [CG] Enable setAdditionalSupportedImageTypes for WK1
2668         https://bugs.webkit.org/show_bug.cgi?id=194190
2669
2670         Reviewed by Tim Horton.
2671
2672         Add a test similar to the one under WebKit Cocoa but make it create a
2673         WebView instead of a WKWebView.
2674
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2677         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2678         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2679         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2680         (TestWebKitAPI::runTest):
2681         (TestWebKitAPI::TEST):
2682
2683 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2684
2685         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2686         https://bugs.webkit.org/show_bug.cgi?id=194168
2687
2688         Reviewed by Simon Fraser.
2689
2690         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2694         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2695         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2696         (TEST):
2697         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2698         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2699
2700 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2701
2702         REGRESSION (r237269): webkit-patch what-broke is broken 
2703         https://bugs.webkit.org/show_bug.cgi?id=193025
2704
2705         Reviewed by Aakash Jain.
2706
2707         * Scripts/webkitpy/common/host.py:
2708         (Host.buildbot):
2709         (Host.bugzilla): Renamed to 'buildbot'.
2710
2711 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2714         https://bugs.webkit.org/show_bug.cgi?id=194207
2715
2716         Reviewed by Tim Horton.
2717
2718         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2719         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2720         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2721         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2722         start and delete forwards to remove the original attachment.
2723
2724         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2725         (TestWebKitAPI::TEST):
2726
2727 2019-02-04  Youenn Fablet  <youenn@apple.com>
2728
2729         Capture state should be managed consistently when doing process swapping
2730         https://bugs.webkit.org/show_bug.cgi?id=194122
2731         <rdar://problem/47609293>
2732
2733         Reviewed by Eric Carlson.
2734
2735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2736         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2737         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2738         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2741         (WTR::TestRunner::isDoingMediaCapture const):
2742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2743         * WebKitTestRunner/TestController.cpp:
2744         (WTR::TestController::isDoingMediaCapture const):
2745         * WebKitTestRunner/TestController.h:
2746         * WebKitTestRunner/TestInvocation.cpp:
2747         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2748         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2749         (WTR::TestController::isDoingMediaCapture const):
2750
2751 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2752
2753         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2754         https://bugs.webkit.org/show_bug.cgi?id=194142
2755
2756         Reviewed by Ross Kirsling.
2757
2758         There three 'separator' variables in TestController.cpp. Renamed
2759         it 'pathSeparator', and unified them.
2760
2761         * WebKitTestRunner/TestController.cpp:
2762         (WTR::TestController::generateContextConfiguration const):
2763         (WTR::createTestURL):
2764         (WTR::TestController::platformAdjustContext):
2765
2766 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2767
2768         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2769         https://bugs.webkit.org/show_bug.cgi?id=194198
2770
2771         Reviewed by Antti Koivisto.
2772
2773         No need to set the banner heights on navigation now, since Page stores them.
2774
2775         * MiniBrowser/mac/WK2BrowserWindowController.m:
2776         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2777
2778 2019-02-03  John Wilander  <wilander@apple.com>
2779
2780         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2781         https://bugs.webkit.org/show_bug.cgi?id=194104
2782         <rdar://problem/47649991>
2783
2784         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2785
2786         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2787         (TestWebKitAPI::TEST):
2788             Changed numeric types from unsigned short to uint32_t.
2789
2790 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2791
2792         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2793         <https://webkit.org/b/194178>
2794         <rdar://problem/47753473>
2795
2796         Reviewed by Alexey Proskuryakov.
2797
2798         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2799         (WTR::uninstallFakeHelvetica): Pass nullptr into
2800         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2801
2802 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2803
2804         [LFC] Initialize ICB's style with fixed width/height.
2805         https://bugs.webkit.org/show_bug.cgi?id=194188
2806
2807         Reviewed by Antti Koivisto.
2808
2809         * LayoutReloaded/misc/LFC-passing-tests.txt:
2810
2811 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2812
2813         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2814         https://bugs.webkit.org/show_bug.cgi?id=194185
2815
2816         Reviewed by Antti Koivisto.
2817
2818         * LayoutReloaded/misc/LFC-passing-tests.txt:
2819
2820 2018-12-16  Darin Adler  <darin@apple.com>
2821
2822         Convert additional String::format clients to alternative approaches
2823         https://bugs.webkit.org/show_bug.cgi?id=192746
2824
2825         Reviewed by Alexey Proskuryakov.
2826
2827         * WebKitTestRunner/TestController.cpp:
2828         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2829         as an intermediate in code that ultimately constructs a WTF::String.
2830         (WTR::userMediaOriginHash): Use makeString.
2831         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2832         (WTR::TestController::didPerformClientRedirect): Ditto.
2833         (WTR::TestController::didPerformServerRedirect): Ditto.
2834         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2835
2836 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2837
2838         [ews-build] Add unit test to verify builder keys
2839         https://bugs.webkit.org/show_bug.cgi?id=194152
2840
2841         Reviewed by Lucas Forschler.
2842
2843         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2844         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2845
2846 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2847
2848         [LFC] Expand tests coverage (12 new tests -> 787)
2849
2850         Unreviewed test gardening.
2851
2852         * LayoutReloaded/misc/LFC-passing-tests.txt:
2853
2854 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2855
2856         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2857         https://bugs.webkit.org/show_bug.cgi?id=194163
2858
2859         Reviewed by Simon Fraser.
2860
2861         775
2862
2863         * LayoutReloaded/misc/LFC-passing-tests.txt:
2864
2865 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2866
2867         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2868         https://bugs.webkit.org/show_bug.cgi?id=194140
2869         <rdar://problem/47728098>
2870
2871         Reviewed by Tim Horton.
2872
2873         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2874         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2875         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2876
2877         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2878         test to induce an IPC deadlock when presenting a modal alert during touch start.
2879
2880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::runJavaScriptAlert):
2883
2884         Add a client callback function for running JavaScript alerts.
2885
2886         (WTR::TestController::createOtherPage):
2887         (WTR::TestController::generateContextConfiguration const):
2888
2889         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2890         the fix in this patch.
2891
2892         (WTR::TestController::createWebViewWithOptions):
2893
2894         Plumb TestOptions to generateContextConfiguration.
2895
2896         (WTR::TestController::resetPreferencesToConsistentValues):
2897         (WTR::TestController::resetStateToConsistentValues):
2898         (WTR::updateTestOptionsFromTestHeader):
2899         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2900         (WTR::TestController::handleJavaScriptAlert):
2901         * WebKitTestRunner/TestController.h:
2902         * WebKitTestRunner/TestInvocation.cpp:
2903         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2904         * WebKitTestRunner/TestOptions.h:
2905         (WTR::TestOptions::hasSameInitializationOptions const):
2906
2907 2019-02-01  Chris Dumez  <cdumez@apple.com>
2908
2909         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2910         https://bugs.webkit.org/show_bug.cgi?id=193740
2911         <rdar://problem/47527267>
2912
2913         Reviewed by Alex Christensen.
2914
2915         Add API test coverage.
2916
2917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2918
2919 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2920
2921         [ews-app] Add display name field to BuilderMapping model
2922         https://bugs.webkit.org/show_bug.cgi?id=194153
2923
2924         Reviewed by Lucas Forschler.
2925
2926         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2927         (BuilderMapping):
2928
2929 2019-02-01  Youenn Fablet  <youenn@apple.com>
2930
2931         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2932         https://bugs.webkit.org/show_bug.cgi?id=194155
2933
2934         Reviewed by Eric Carlson.
2935
2936         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2937         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2938         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2939
2940 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2941
2942         [LFC] Adjust replaced element's intrinsic ratio
2943         https://bugs.webkit.org/show_bug.cgi?id=194154
2944
2945         Reviewed by Antti Koivisto.
2946
2947         761
2948
2949         * LayoutReloaded/misc/LFC-passing-tests.txt:
2950
2951 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2952
2953         [WPE] Show test results in minibrowser
2954         https://bugs.webkit.org/show_bug.cgi?id=194150
2955
2956         Reviewed by Žan Doberšek.
2957
2958         * Scripts/webkitpy/port/wpe.py:
2959         (WPEPort.show_results_html_file):
2960
2961 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2964         https://bugs.webkit.org/show_bug.cgi?id=194151
2965
2966         Reviewed by Žan Doberšek.
2967
2968         ALT + <- go back
2969         ALT + -> go forward
2970
2971         * MiniBrowser/wpe/main.cpp:
2972         (main):
2973
2974 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2975
2976         [LFC] Set intrinsic size on Layout::Replaced
2977         https://bugs.webkit.org/show_bug.cgi?id=194139
2978
2979         Reviewed by Antti Koivisto.
2980
2981         744
2982
2983         * LayoutReloaded/misc/LFC-passing-tests.txt:
2984
2985 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2986
2987         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2988         https://bugs.webkit.org/show_bug.cgi?id=194146
2989
2990         Reviewed by Xabier Rodriguez-Calvar.
2991
2992         It allows to open relative paths.
2993
2994         * MiniBrowser/wpe/main.cpp:
2995         (main):
2996
2997 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2998
2999         Update flakiness dashboard configuration after recent queue changes
3000         https://bugs.webkit.org/show_bug.cgi?id=194127
3001
3002         Rubber-stamped by Aakash Jain.
3003
3004         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3005
3006         * TestResultServer/static-dashboards/builders.jsonp:
3007
3008 2019-01-31  Youenn Fablet  <youenn@apple.com>
3009
3010         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3011         https://bugs.webkit.org/show_bug.cgi?id=194106
3012         <rdar://problem/47676333>
3013
3014         Reviewed by Ryosuke Niwa.
3015
3016         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3017         (TestWebKitAPI::didFinishNavigation):
3018         (TestWebKitAPI::TEST):
3019         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3020
3021 2019-01-31  Chris Dumez  <cdumez@apple.com>
3022
3023         Page zoom level is lost after a process swap or a crash
3024         https://bugs.webkit.org/show_bug.cgi?id=194105
3025         <rdar://problem/47610781>
3026
3027         Reviewed by Alex Christensen.
3028
3029         Add API test coverage.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3032         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3033
3034 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3035
3036         Revert r238819 which is unneeded and caused a performance regression.
3037         https://bugs.webkit.org/show_bug.cgi?id=192272
3038         <rdar://problem/46664625>
3039
3040         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3041         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3042         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3043
3044 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3045
3046         Formalize WebKitAdditions mechanism of LoadOptimizer
3047         https://bugs.webkit.org/show_bug.cgi?id=193886
3048         <rdar://problem/47696809>
3049
3050         Reviewed by Brent Fulgham.
3051
3052         * MiniBrowser/MiniBrowser.entitlements:
3053         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3054
3055 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3056
3057         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3058         https://bugs.webkit.org/show_bug.cgi?id=194090
3059
3060         Reviewed by Antti Koivisto.
3061
3062         * LayoutReloaded/misc/LFC-passing-tests.txt:
3063
3064 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3065
3066         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3067         https://bugs.webkit.org/show_bug.cgi?id=194074
3068
3069         Reviewed by Antti Koivisto.
3070
3071         * LayoutReloaded/misc/LFC-passing-tests.txt:
3072
3073 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3074
3075         [LFC][BFC] Add support for block level replaced box.
3076         https://bugs.webkit.org/show_bug.cgi?id=194071
3077
3078         Reviewed by Antti Koivisto.
3079
3080         * LayoutReloaded/misc/LFC-passing-tests.txt:
3081
3082 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3083
3084         Fix WebKitTestRunner's testPath with Windows full paths
3085         https://bugs.webkit.org/show_bug.cgi?id=194012
3086
3087         Reviewed by Alex Christensen.
3088
3089         updateTestOptionsFromTestHeader failed to open test files because
3090         testPath returned wrong file paths. It returned a path "/C:/..."
3091         if a URL "file:///C:/..." was given.
3092
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3095
3096 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3097
3098         [WPE] Bump font related dependencies to match the GTK+ port
3099         https://bugs.webkit.org/show_bug.cgi?id=194017
3100
3101         Reviewed by Žan Doberšek.
3102
3103         * wpe/jhbuild.modules:
3104         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3105         * wpe/patches/icudata-stdlibs.patch: Added.
3106
3107 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3108
3109         Enable swipe tests on iOS
3110         https://bugs.webkit.org/show_bug.cgi?id=194076
3111
3112         Reviewed by Geoffrey Garen.
3113
3114         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3115         it causes a debug assertion failure in runUIScript.
3116
3117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3118         (WTR::UIScriptController::beginBackSwipe):
3119         (WTR::UIScriptController::completeBackSwipe):
3120
3121 2019-01-30  Keith Rollin  <krollin@apple.com>
3122
3123         Use correct printf format specifier
3124         https://bugs.webkit.org/show_bug.cgi?id=194062
3125         <rdar://problem/47686167>
3126
3127         Reviewed by Alexey Proskuryakov.
3128
3129         LayoutTestSpellChecker.mm is trying to format a variable of type
3130         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3131         actually an unsigned long long. Fix this by formatting with %llu.
3132
3133         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3134         (-[LayoutTestTextCheckingResult description]):
3135
3136 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3137
3138         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3139         https://bugs.webkit.org/show_bug.cgi?id=193979
3140
3141         Reviewed by Wenson Hsieh.
3142
3143         Fix the test for iOS. Make the test work with iOS UA string.
3144
3145         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3146
3147 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3148
3149         Replace High Sierra LLINT CLoop bot due to hardware failure
3150         https://bugs.webkit.org/show_bug.cgi?id=194066
3151
3152         Reviewed by Aakash Jain.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/config.json:
3155
3156 2019-01-30  Keith Rollin  <krollin@apple.com>
3157
3158         [NSDragItem init] is unavailable
3159         https://bugs.webkit.org/show_bug.cgi?id=194059
3160         <rdar://problem/47685715>
3161
3162         Reviewed by Wenson Hsieh.
3163
3164         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3165         DumpRenderTree and TestWebKitAPI, which both try to create an
3166         NSDragItem in a manner that invokes this method. Address this by using
3167         -initWithPasteboardWriter instead.
3168
3169         Note that the parameter passed to initWithPasteboardWriter is likely
3170         incorrect. In both cases, the object passed does not conform to
3171         NSPasteboardWriting. However, with this fix, we're no worse off than
3172         before, and can now perform builds with newer compilers and SDKs until
3173         a real fix can be crafted. That work is tracked in
3174         https://bugs.webkit.org/show_bug.cgi?id=194060
3175
3176         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3177         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3178         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3179         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3180
3181 2019-01-30  Daniel Bates  <dabates@apple.com>
3182
3183         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3184         https://bugs.webkit.org/show_bug.cgi?id=192824
3185         <rdar://problem/47100332>
3186
3187         Reviewed by Wenson Hsieh.
3188
3189         Fix a bug where the wrong usage code was used for F13 thru F24.
3190
3191         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3192         (keyCodeForDOMFunctionKey):
3193
3194 2019-01-30  Chris Dumez  <cdumez@apple.com>
3195
3196         Regression(PSON) Load hang can occur on history navigation
3197         https://bugs.webkit.org/show_bug.cgi?id=194030
3198         <rdar://problem/47656939>
3199
3200         Reviewed by Antti Koivisto.
3201
3202         Add API test coverage.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3205
3206 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3207
3208         [LFC] Expand tests coverage.
3209
3210         Unreviewed test gardening.
3211
3212         * LayoutReloaded/misc/LFC-passing-tests.txt:
3213
3214 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3215
3216         [Flatpak] Add openjpeg support
3217         https://bugs.webkit.org/show_bug.cgi?id=194019
3218
3219         Reviewed by Michael Catanzaro.
3220
3221         * flatpak/org.webkit.CommonModules.yaml:
3222
3223 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3224
3225         Unreviewed, rolling out r240708.
3226         https://bugs.webkit.org/show_bug.cgi?id=194022
3227
3228         It broke WPE build (Requested by KaL on #webkit).
3229
3230         Reverted changeset:
3231
3232         "[WPE] Bump font related dependencies to match the GTK+ port"
3233         https://bugs.webkit.org/show_bug.cgi?id=194017
3234         https://trac.webkit.org/changeset/240708
3235
3236 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3237
3238         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3239         https://bugs.webkit.org/show_bug.cgi?id=194001
3240
3241         Reviewed by Antti Koivisto.
3242
3243         * LayoutReloaded/misc/LFC-passing-tests.txt:
3244
3245 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3246
3247         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3248         https://bugs.webkit.org/show_bug.cgi?id=194020
3249
3250         Reviewed by Antti Koivisto.
3251
3252         * LayoutReloaded/misc/LFC-passing-tests.txt:
3253
3254 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3255
3256         AX: Support color well on iOS
3257         https://bugs.webkit.org/show_bug.cgi?id=194010
3258
3259         Reviewed by Joanmarie Diggs.
3260
3261         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3262         (WTR::AccessibilityUIElement::stringAttributeValue):
3263
3264 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3265
3266         [WPE] Bump font related dependencies to match the GTK+ port
3267         https://bugs.webkit.org/show_bug.cgi?id=194017
3268
3269         Reviewed by Žan Doberšek.
3270
3271         * wpe/jhbuild.modules:
3272         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3273         * wpe/patches/icudata-stdlibs.patch: Added.
3274
3275 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3276
3277         [Mac] Update window scale API usage
3278         https://bugs.webkit.org/show_bug.cgi?id=193991
3279         rdar://problem/47614795
3280
3281         Reviewed by Tim Horton.
3282
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (changeWindowScaleIfNeeded):
3285         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3286         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3287         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3288
3289 2019-01-29  Chris Dumez  <cdumez@apple.com>
3290
3291         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3292         https://bugs.webkit.org/show_bug.cgi?id=193977
3293         <rdar://problem/47643716>
3294
3295         Reviewed by Geoff Garen.
3296
3297         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3298         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3299         to the previous provisional committing *before* we make the last load. 
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3302
3303 2019-01-29  Youenn Fablet  <youenn@apple.com>
3304
3305         Adopt new SPI to evaluate server certificate trust
3306         https://bugs.webkit.org/show_bug.cgi?id=193355
3307
3308         Reviewed by Alex Christensen.
3309
3310         Add infrastructure to handle HTTPS server trust evaluation testing.
3311
3312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3314         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3315         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3316         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3317         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3318         * WebKitTestRunner/TestController.cpp:
3319         (WTR::TestController::resetPreferencesToConsistentValues):
3320         (WTR::TestController::didReceiveAuthenticationChallenge):
3321         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3322         * WebKitTestRunner/TestController.h:
3323         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3324         * WebKitTestRunner/TestInvocation.cpp:
3325         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3326         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3327         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3328
3329 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-build] Add build step to print bot Configuration
3332         https://bugs.webkit.org/show_bug.cgi?id=193887
3333
3334         Reviewed by Lucas Forschler.
3335
3336         * BuildSlaveSupport/ews-build/steps.py:
3337         (PrintConfiguration): Build step to print configuration.
3338         * BuildSlaveSupport/ews-build/factories.py:
3339
3340 2019-01-29  Chris Dumez  <cdumez@apple.com>
3341
3342         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3343         https://bugs.webkit.org/show_bug.cgi?id=193967
3344         <rdar://problem/47635348>
3345
3346         Reviewed by Alex Christensen.
3347
3348         Add API test coverage.
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3351         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3352
3353 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-app] Handle incoming results data
3356         https://bugs.webkit.org/show_bug.cgi?id=193973
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-app/ews/views/results.py:
3361
3362 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3363
3364         [ews-app] Make the results url generic
3365         https://bugs.webkit.org/show_bug.cgi?id=193928
3366
3367         Reviewed by Lucas Forschler.
3368
3369         * BuildSlaveSupport/ews-app/ews/urls.py:
3370
3371 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3372
3373         [ews-build] Configure buildbot to send events to ews-app
3374         https://bugs.webkit.org/show_bug.cgi?id=193968
3375
3376         Reviewed by Lucas Forschler.
3377
3378         * BuildSlaveSupport/ews-build/events.py: Added.
3379         * BuildSlaveSupport/ews-build/master.cfg:
3380
3381 2019-01-29  Keith Rollin  <krollin@apple.com>
3382
3383         Add .xcfilelists to Run Script build phases
3384         https://bugs.webkit.org/show_bug.cgi?id=193792
3385         <rdar://problem/47201785>
3386
3387         Reviewed by Alex Christensen.
3388
3389         As part of supporting XCBuild, update the necessary Run Script build
3390         phases in their Xcode projects to refer to their associated
3391         .xcfilelist files.
3392
3393         Note that the addition of these files bumps the Xcode project version
3394         number to something that's Xcode 10 compatible. This change means that
3395         older versions of the Xcode IDE can't read these projects. Nor can it
3396         fully load workspaces that refer to these projects (the updated
3397         projects are shown as non-expandable placeholders). `xcodebuild` can
3398         still build these projects; it's just that the IDE can't open them.
3399
3400         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3402
3403 2019-01-29  John Wilander  <wilander@apple.com>
3404
3405         Add data abstraction and validation for Ad Click Attribution
3406         https://bugs.webkit.org/show_bug.cgi?id=193916
3407         <rdar://problem/47603481>
3408
3409         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3410
3411         Ad click attribution has two steps. First, the storage of an ad
3412         campaign ID for a click that takes the user to a destination
3413         site. Second, a conversion on the destination site that can be
3414         attributed to the ad click.
3415
3416         This patch adds a class that represents a request for ad click
3417         attribution. Validation makes sure that the bits of entropy
3418         reported through this mechanism is limited.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3422         (TestWebKitAPI::TEST):
3423
3424 2019-01-29  Chris Dumez  <cdumez@apple.com>
3425
3426         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3427         https://bugs.webkit.org/show_bug.cgi?id=193932
3428         <rdar://problem/47598947>
3429
3430         Reviewed by Brady Eidson.
3431
3432         Add API test coverage.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3435
3436 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3437
3438         Adding new passing LFC tests.
3439
3440         Unreviewed test gardening.
3441
3442         * LayoutReloaded/misc/LFC-passing-tests.txt:
3443
3444 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3445
3446         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3447         https://bugs.webkit.org/show_bug.cgi?id=193964
3448
3449         Reviewed by Antti Koivisto.
3450
3451         * LayoutReloaded/misc/LFC-passing-tests.txt:
3452
3453 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3454
3455         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3456         https://bugs.webkit.org/show_bug.cgi?id=193954
3457
3458         Reviewed by Antti Koivisto.
3459
3460         * LayoutReloaded/misc/LFC-passing-tests.txt:
3461
3462 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3463
3464         WebDriver: add support for running subtests
3465         https://bugs.webkit.org/show_bug.cgi?id=193904
3466
3467         Reviewed by Michael Catanzaro.
3468
3469         pytest already supports it by passing test.py::subtest, so we can do the same.
3470
3471         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3472         (get_item_name): Made this global.
3473         (CollectRecorder.__init__): Receive the parameter to ignore.
3474         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3475         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3476         (collect): Add parameter to ignore.
3477         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3478         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3479         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3480         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3481         (WebDriverTestRunnerSelenium.run): Ditto.
3482         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3483         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3484         (WebDriverTestRunnerW3C.run): Ditto.
3485
3486 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3487
3488         User agent string override for navigator.userAgent should be site specific quirks
3489         https://bugs.webkit.org/show_bug.cgi?id=193950
3490
3491         Reviewed by Brent Fulgham.
3492
3493         Updated per the _WKWebsitePolicies rename.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3496         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3497
3498 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3499
3500         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3501         https://bugs.webkit.org/show_bug.cgi?id=193941
3502
3503         Reviewed by Alex Christensen.
3504
3505         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3506         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3507         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3508         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3509         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3510         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3511         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3512         * TestWebKitAPI/Tests/WTF/Time.cpp:
3513         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3514         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3515         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3516         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3517
3518 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3519
3520         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3521
3522         * Scripts/webkitpy/common/config/contributors.json:
3523
3524 2019-01-28  Andy Estes  <aestes@apple.com>
3525
3526         [watchOS] Enable Parental Controls content filtering
3527         https://bugs.webkit.org/show_bug.cgi?id=193939
3528         <rdar://problem/46641912>
3529
3530         Reviewed by Ryosuke Niwa.
3531
3532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3533
3534 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3535
3536         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3537         <https://webkit.org/b/193884>
3538
3539         Reviewed by Jiewen Tan.
3540
3541         * Scripts/webkitpy/style/checkers/cpp.py:
3542         (check_language): Add LocalAuthentication to
3543         `frameworks_with_soft_links`.
3544
3545 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3546
3547         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3548         https://bugs.webkit.org/show_bug.cgi?id=193891
3549
3550         Reviewed by Ross Kirsling.
3551
3552         There were three problems in window sizes of WebView and the host window.
3553         1. The sizes of pixel image output were incorrect.
3554         2. The host window is going to appear after window.resize was invoked.
3555         3. window.resize resized only the host window, not WebView.
3556
3557         This change solves them with a following approach.
3558         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3559         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3560            as well as DumpRenderTree in order to match the client area and the window area.
3561         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3562         d. PlatformWebView::setWindowFrame changes both window sizes.
3563         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3564
3565         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3566         (WTR::PlatformWebView::PlatformWebView): Create the host window
3567         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3568         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3569         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3570
3571 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3572
3573         [ews-app] Add method to save Step data to database
3574         https://bugs.webkit.org/show_bug.cgi?id=193890
3575
3576         Reviewed by Lucas Forschler.
3577
3578         * BuildSlaveSupport/ews-app/ews/models/step.py:
3579         (Step.save_step): Method to save step data.
3580         (Step.update_step): Method to update step data.
3581         (Step.get_existing_step): Method to fetch existing step from database.
3582         (Step.is_valid_result): Method to validate valid step result.
3583
3584 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3585
3586         [ews-app] Add method to save Build data to database
3587         https://bugs.webkit.org/show_bug.cgi?id=193735
3588
3589         Reviewed by Lucas Forschler.
3590
3591         * BuildSlaveSupport/ews-app/ews/models/build.py:
3592         (Build.save_build): Method to save build information to database.
3593         (Build.get_existing_build): Method to fetch existing build from database.
3594         (Build.is_valid_result): Method to validate build result.
3595         * BuildSlaveSupport/ews-app/ews/common/util.py:
3596         (is_valid_int_id): Method to validate valid id.
3597
3598 2019-01-28  Chris Dumez  <cdumez@apple.com>
3599
3600         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3601         https://bugs.webkit.org/show_bug.cgi?id=193915
3602         <rdar://problem/47560907>
3603
3604         Reviewed by Alex Christensen.
3605
3606         Add API test coverage.
3607
3608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3609
3610 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3611
3612         [ews-app] Rename id variables
3613         https://bugs.webkit.org/show_bug.cgi?id=193883
3614
3615         Reviewed by Lucas Forschler.
3616
3617         * BuildSlaveSupport/ews-app/ews/models/build.py:
3618         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3619         * BuildSlaveSupport/ews-app/ews/models/step.py:
3620         * BuildSlaveSupport/ews-app/ews/urls.py:
3621         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3622         * BuildSlaveSupport/ews-app/ews/views/results.py:
3623         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3624
3625 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-app] Allow certain fields to be empty
3628         https://bugs.webkit.org/show_bug.cgi?id=193892
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * BuildSlaveSupport/ews-app/ews/models/build.py:
3633         * BuildSlaveSupport/ews-app/ews/models/step.py:
3634
3635 2019-01-28  Rob Buis  <rbuis@igalia.com>
3636
3637         Update MIME type parser
3638         https://bugs.webkit.org/show_bug.cgi?id=180526
3639
3640         Reviewed by Frédéric Wang.
3641
3642         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3643         (TestWebKitAPI::TEST):
3644
3645 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3646
3647         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3648         https://bugs.webkit.org/show_bug.cgi?id=193896
3649
3650         Reviewed by Antti Koivisto.
3651
3652         * LayoutReloaded/misc/LFC-passing-tests.txt:
3653
3654 2018-12-15  Darin Adler  <darin@apple.com>
3655
3656         Replace many uses of String::format with more type-safe alternatives
3657         https://bugs.webkit.org/show_bug.cgi?id=192742
3658
3659         Reviewed by Mark Lam.
3660
3661         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3662         (WTR::cacheTestRunnerCallback): Use makeString.
3663         * WebKitTestRunner/TestController.cpp:
3664         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3665         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3666
3667 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3668
3669         Use a load optimizer for some sites
3670         https://bugs.webkit.org/show_bug.cgi?id=193881
3671         <rdar://problem/46325455>
3672
3673         Reviewed by Brent Fulgham.
3674
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3676         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3677
3678 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3679
3680         AX: Introduce a static accessibility tree
3681         https://bugs.webkit.org/show_bug.cgi?id=193348
3682         <rdar://problem/47203295>
3683
3684         Reviewed by Ryosuke Niwa.
3685
3686         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3687
3688 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3689
3690         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3691         https://bugs.webkit.org/show_bug.cgi?id=193867
3692
3693         Reviewed by Antti Koivisto.
3694
3695         * LayoutReloaded/misc/LFC-passing-tests.txt:
3696
3697 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3698
3699         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3700         https://bugs.webkit.org/show_bug.cgi?id=193865
3701
3702         Reviewed by Antti Koivisto.
3703
3704         * LayoutReloaded/misc/LFC-passing-tests.txt:
3705
3706 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3707
3708         Need a mechanism to override navigator.userAgent
3709         https://bugs.webkit.org/show_bug.cgi?id=193762
3710         <rdar://problem/47504939>
3711
3712         Reviewed by Brent Fulgham.
3713
3714         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3715
3716         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3717         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3718         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3719
3720 2019-01-25  Dean Jackson  <dino@apple.com>
3721
3722         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3723         https://bugs.webkit.org/show_bug.cgi?id=193831
3724         <rdar://problem/47399263>
3725
3726         Reviewed by Chris Dumez.
3727
3728         Two new tests that exercise cross-origin and same-origin System
3729         Previews.
3730
3731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3732
3733 2019-01-25  Keith Rollin  <krollin@apple.com>
3734
3735         Update Xcode projects with "Check .xcfilelists" build phase
3736         https://bugs.webkit.org/show_bug.cgi?id=193790
3737         <rdar://problem/47201374>
3738
3739         Reviewed by Alex Christensen.
3740
3741         Support for XCBuild includes specifying inputs and outputs to various
3742         Run Script build phases. These inputs and outputs are specified as
3743         .xcfilelist files. Once created, these .xcfilelist files need to be
3744         kept up-to-date. In order to check that they are up-to-date or not,
3745         add an Xcode build step that invokes an external script that performs
3746         the checking. If the .xcfilelists are found to be out-of-date, update
3747         them, halt the build, and instruct the developer to restart the build
3748         with up-to-date files.
3749
3750         At this time, the checking and regenerating is performed only if the
3751         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3752         who want to use this facility can set this variable and test out the
3753         checking/regenerating. Once it seems like there are no egregious
3754         issues that upset a developer's workflow, we'll unconditionally enable
3755         this facility.
3756
3757         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3758         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3759         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3760         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3761
3762 2019-01-25  Keith Rollin  <krollin@apple.com>
3763
3764         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3765         https://bugs.webkit.org/show_bug.cgi?id=193781
3766         <rdar://problem/47201153>
3767
3768         Reviewed by Alex Christensen.
3769
3770         Part of generating the .xcfilelists used as part of adopting XCBuild
3771         includes running `make DerivedSources.make` from a standalone script.
3772         It’s important for this invocation to have the same environment as
3773         when the actual build invokes `make DerivedSources.make`. If the
3774         environments are different, then the two invocations will provide
3775         different results. In order to get the same environment in the
3776         standalone script, have the script launch xcodebuild targeting the
3777         "Apply Configuration to XCFileLists" build target, which will then
3778         re-invoke our standalone script. The script is now running again, this
3779         time in an environment with all workspace, project, target, xcconfig
3780         and other environment variables established.
3781
3782         The "Apply Configuration to XCFileLists" build target accomplishes
3783         this task via a small embedded shell script that consists only of:
3784
3785             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3786
3787         The process that invokes "Apply Configuration to XCFileLists" first
3788         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3789         evaluated and exports it into the shell environment. When xcodebuild
3790         is invoked, it inherits the value of this variable and can `eval` the
3791         contents of that variable. Our external standalone script can then set
3792         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3793         of command-line parameters needed to restart itself in the appropriate
3794         state.
3795
3796         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3797         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3798
3799 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3800
3801         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3802         https://bugs.webkit.org/show_bug.cgi?id=193802
3803         <rdar://problem/46010580>
3804
3805         Reviewed by Andy Estes.
3806
3807         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3808         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3809         (TEST):
3810
3811 2019-01-25  Daniel Bates  <dabates@apple.com>
3812
3813         [iOS] uiController.keyDown() does not translate Control modified key
3814         https://bugs.webkit.org/show_bug.cgi?id=192898
3815
3816         Reviewed by Wenson Hsieh.
3817
3818         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3819         key translation, as applicable. Among other cases, key translation occurs when performing
3820         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3821         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3822         human pressing down and releasing key(s) using a hardware keyboard.
3823
3824         * WebKitTestRunner/ios/HIDEventGenerator.h:
3825         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3826         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3827
3828         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3829         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3830         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3831         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3832         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3833         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3834         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3835         (-[HIDEventGenerator longPress:completionBlock:]):
3836         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3837         Update code for above renaming.
3838
3839         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3840         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3841
3842         (-[HIDEventGenerator keyDown:]): Added.
3843         (-[HIDEventGenerator keyUp:]): Added.
3844         (-[HIDEventGenerator keyPress:completionBlock:]):
3845         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3846         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3847         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3848         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3849         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3850         (WTR::parseModifier): Deleted.
3851
3852 2019-01-25  Keith Rollin  <krollin@apple.com>
3853
3854         Complete the implementation of generate-xcfilelists
3855         https://bugs.webkit.org/show_bug.cgi?id=193782
3856
3857         Reviewed by Alex Christensen.
3858
3859         A preliminary version of generate-xcfilelists was added in r238008.
3860         This patch updates that script in order to:
3861
3862         - Support checking of .xcfilelists
3863         - Perform better execution of `make DerivedSources.make` by
3864           relaunching generate-xcfilelists under xcodebuild
3865         - Support incremental generation and checking of .xcfilelists
3866         - Support supplementary .xcfilelists files from WebKitAdditions
3867         - Support being wrapped by parallel version of generate-xcfilelists in
3868           Internal that adds support for (re)generating WebKit projects in
3869           that repo.
3870         - Support builds that have been performed in WebKitBuild as well as
3871           ~/Library/Developer/code/DerivedData
3872         - Increase robustness and debugging facilities.
3873
3874         * Scripts/generate-xcfilelists:
3875
3876 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3877
3878         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3879         https://bugs.webkit.org/show_bug.cgi?id=193297
3880         <rdar://problem/47158841>
3881
3882         Unreviewed test case fix.
3883
3884         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3885         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3888         (TEST):
3889
3890 2019-01-25  Keith Rollin  <krollin@apple.com>
3891
3892         Update existing .xcfilelists
3893         https://bugs.webkit.org/show_bug.cgi?id=193791
3894         <rdar://problem/47201706>
3895
3896         Reviewed by Alex Christensen.
3897
3898         Many .xcfilelist files were added in r238824 in order to support
3899         XCBuild. Update these with recent changes to the set of build files
3900         and with the current generate-xcfilelist script.
3901
3902         * DumpRenderTree/DerivedSources-input.xcfilelist:
3903         * DumpRenderTree/DerivedSources-output.xcfilelist:
3904         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3905         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3906
3907 2019-01-25  Keith Rollin  <krollin@apple.com>
3908
3909         Fix missing dependencies in extract-dependencies-from-makefile
3910         https://bugs.webkit.org/show_bug.cgi?id=193783
3911         <rdar://problem/47201571>
3912
3913         Reviewed by Alex Christensen.
3914
3915         The extract-dependencies-from-makefile script generates .xcfilelists
3916         for XCBuild by invoking a makefile in --debug mode, parsing the
3917         dependency information in the output, and extracting information
3918         regarding targets and dependents. However, the way `make` emits this
3919         dependency information is not rigorous, and so we need to determine
3920         what lines to look for and parse by trial and error. This approach
3921         didn't coriginally atch all the information we needed to collect, so
3922         update the script to look for the additional lines we now know to look
3923         for.
3924
3925         * Scripts/extract-dependencies-from-makefile:
3926         (Parser):
3927         (Parser.addTarget):
3928         (Parser.addPrereq):
3929         (Parser.doParse):
3930
3931 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3932
3933         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3934         https://bugs.webkit.org/show_bug.cgi?id=193297
3935         <rdar://problem/47158841>
3936
3937         Reviewed by Alex Christensen.
3938
3939         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3940             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3941         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3942         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3943         activating the message used to trigger the callback when it is set.
3944
3945 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3946
3947         WKWebView.goBack should reload if there is a safe browsing warning
3948         https://bugs.webkit.org/show_bug.cgi?id=193805
3949         <rdar://problem/46908216>
3950
3951         Reviewed by Geoff Garen.
3952
3953         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3954         (+[Simple3LookupContext sharedLookupContext]):
3955         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3956         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3957         (TEST):
3958
3959 2019-01-25  Chris Dumez  <cdumez@apple.com>
3960
3961         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3962         https://bugs.webkit.org/show_bug.cgi?id=193788
3963         <rdar://problem/47531231>
3964
3965         Reviewed by Alex Christensen.
3966
3967         Add API test coverage.
3968
3969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3970         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3971
3972 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3973
3974         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3975         https://bugs.webkit.org/show_bug.cgi?id=193771
3976
3977         Unreviewed infrastructure fix.
3978
3979         * Scripts/webkitpy/port/darwin.py:
3980         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3981
3982 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3983
3984         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3985
3986 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3987
3988         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3989
3990         * Scripts/webkitpy/common/config/contributors.json:
3991
3992 2019-01-25  Chris Dumez  <cdumez@apple.com>
3993
3994         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3995         https://bugs.webkit.org/show_bug.cgi?id=193779
3996         <rdar://problem/46170903>
3997
3998         Reviewed by Antti Koivisto.
3999
4000         Add API test that quickly navigates forward to a previous process without waiting for it to
4001         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4002         the process' previous page when reconnecting the it for the forward navigation.
4003
4004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4005
4006 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4007
4008         Need a way for JavaScript (or bundle) code to participate in undo
4009         https://bugs.webkit.org/show_bug.cgi?id=190009
4010         <rdar://problem/44807048>
4011
4012         Reviewed by Ryosuke Niwa.
4013
4014         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4015         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4016
4017         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4018         (WTR::UIScriptController::lastUndoLabel const):
4019         (WTR::UIScriptController::firstRedoLabel const):
4020         (WTR::UIScriptController::platformUndoManager const):
4021         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4022         (WTR::UIScriptController::lastUndoLabel const):
4023         (WTR::UIScriptController::firstRedoLabel const):
4024         (WTR::UIScriptController::platformUndoManager const):
4025         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4026         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4027         (WTR::UIScriptController::lastUndoLabel const):
4028         (WTR::UIScriptController::firstRedoLabel const):
4029         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4030         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4031         (WTR::UIScriptController::lastUndoLabel const):
4032         (WTR::UIScriptController::firstRedoLabel const):
4033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4034         (WTR::UIScriptController::platformUndoManager const):
4035         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4036         (WTR::UIScriptController::platformUndoManager const):
4037
4038 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4039
4040         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4041         https://bugs.webkit.org/show_bug.cgi?id=193824
4042
4043         Reviewed by Antti Koivisto.
4044
4045         * LayoutReloaded/misc/LFC-passing-tests.txt:
4046
4047 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4048
4049         Update macOS JSC bot configurations
4050         https://bugs.webkit.org/show_bug.cgi?id=193739
4051
4052         Reviewed by Alexey Proskuryakov.
4053
4054         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4056         (BubbleQueueServer): Move JSC EWS to Mojave section.
4057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4058         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4059         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4060
4061 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4062
4063         [Win][WebKitTestRunner] Implement EventSenderProxy
4064         https://bugs.webkit.org/show_bug.cgi?id=193755
4065
4066         Reviewed by Don Olmstead.
4067
4068         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4069         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4070         (WTR::EventSenderProxy::dispatchMessage):
4071         (WTR::EventSenderProxy::EventSenderProxy):
4072         (WTR::EventSenderProxy::mouseDown):
4073         (WTR::EventSenderProxy::mouseUp):
4074         (WTR::EventSenderProxy::mouseMoveTo):
4075         (WTR::EventSenderProxy::mouseScrollBy):
4076         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4077
4078 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4079
4080         Unreviewed fix for API test failure after r240437.
4081
4082         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4083
4084         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4085
4086 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4087
4088         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4089         https://bugs.webkit.org/show_bug.cgi?id=193787
4090         <rdar://problem/47497634>
4091
4092         Reviewed by Alexey Proskuryakov.
4093
4094         * Scripts/webkitdirs.pm:
4095         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4096
4097 2019-01-24  Truitt Savell  <tsavell@apple.com>
4098
4099         Unreviewed, rolling out r240446.
4100
4101         Casued 5 API failures
4102
4103         Reverted changeset:
4104
4105         "Activate the WebResourceLoadStatisticsStore in the
4106         NetworkProcess and deactivate it in the UIProcess."
4107         https://bugs.webkit.org/show_bug.cgi?id=193297
4108         https://trac.webkit.org/changeset/240446
4109
4110 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4111
4112         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4113         https://bugs.webkit.org/show_bug.cgi?id=193741
4114         <rdar://problem/47135030>
4115
4116         Reviewed by Antti Koivisto and Simon Fraser.
4117
4118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4119         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4120         (TestWebKitAPI::TEST):
4121
4122 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4123
4124         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4125         https://bugs.webkit.org/show_bug.cgi?id=193297
4126         <rdar://problem/47158841>
4127
4128         Reviewed by Alex Christensen.
4129
4130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4131         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4132         activating the message used to trigger the callback when it is set.
4133
4134 2019-01-24  John Wilander  <wilander@apple.com>
4135
4136         Add Ad Click Attribution as an internal/experimental feature
4137         https://bugs.webkit.org/show_bug.cgi?id=193685
4138         <rdar://problem/47450399>
4139
4140         Reviewed by Brent Fulgham.
4141
4142         Added test option adClickAttributionEnabled.
4143
4144         * DumpRenderTree/TestOptions.cpp:
4145         (TestOptions::TestOptions):
4146         * DumpRenderTree/TestOptions.h:
4147         * DumpRenderTree/mac/DumpRenderTree.mm:
4148         (setWebPreferencesForTestOptions):
4149
4150 2019-01-24  Antti Koivisto  <antti@apple.com>
4151
4152         [PSON] Flash on back navigation on Mac
4153         https://bugs.webkit.org/show_bug.cgi?id=193716
4154         <rdar://problem/47148458>
4155
4156         Reviewed by Chris Dumez.
4157
4158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4159
4160         Closing of the previous page is delayed so waiting for didFinishNavigation is
4161         not sufficient to guarantee we have received all the messages. Wait for them.
4162
4163 2019-01-24  Chris Dumez  <cdumez@apple.com>
4164
4165         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4166         https://bugs.webkit.org/show_bug.cgi?id=193761
4167         <rdar://problem/47456405>
4168
4169         Reviewed by Alex Christensen.
4170
4171         Add API test coverage.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4174
4175 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4176
4177         webkitpy: Missing PID in crashlog name should not be fatal
4178         https://bugs.webkit.org/show_bug.cgi?id=193771
4179
4180         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4181         of raising an exception.
4182
4183         Reviewed by Lucas Forschler.
4184
4185         * Scripts/webkitpy/port/darwin.py:
4186         (DarwinPort._merge_crash_logs):
4187
4188 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4189
4190         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4191         https://bugs.webkit.org/show_bug.cgi?id=193746
4192
4193         Reviewed by Youenn Fablet.
4194
4195         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4196         so we'd best just not call it.
4197
4198         * Scripts/webkitpy/w3c/test_exporter.py:
4199         (WebPlatformTestExporter.create_branch_with_patch):
4200
4201 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4202
4203         Move FileSystem to WTF
4204         https://bugs.webkit.org/show_bug.cgi?id=193602
4205
4206         Reviewed by Yusuke Suzuki.
4207
4208         * DumpRenderTree/win/DumpRenderTree.cpp:
4209         * TestWebKitAPI/CMakeLists.txt:
4210         * TestWebKitAPI/PlatformGTK.cmake:
4211         * TestWebKitAPI/PlatformJSCOnly.cmake:
4212         * TestWebKitAPI/PlatformPlayStation.cmake:
4213         * TestWebKitAPI/PlatformWPE.cmake:
4214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4215         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4216         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4217         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4218         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4219         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4220         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4221         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4222         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4223         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4224
4225 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4226
4227         [WPE] Remove hard dependency on subprocess32 for the API tests
4228
4229         Rubber-stamped by Carlos Garcia Campos.
4230
4231         * glib/api_test_runner.py:
4232         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4233         its presence only when running WPEQt tests.
4234
4235 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4236
4237         [GLIB] Expose JavaScriptCore options in GLib public API
4238         https://bugs.webkit.org/show_bug.cgi?id=188742
4239
4240         Reviewed by Michael Catanzaro.
4241
4242         Add a test for the new API.
4243
4244         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4245         (testsJSCOptions):
4246         (main):
4247
4248 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4249
4250         [GTK][WPE] Support JPEG 2000 images
4251         https://bugs.webkit.org/show_bug.cgi?id=186272
4252
4253         Reviewed by Žan Doberšek.
4254
4255         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4256
4257         * gtk/jhbuild.modules:
4258         * wpe/jhbuild.modules:
4259
4260 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4261
4262         check-webkit-style should warn when using soft-linking macros in a header
4263         <https://webkit.org/b/193750>
4264
4265         Reviewed by Darin Adler.
4266
4267         * Scripts/webkitpy/style/checkers/cpp.py:
4268         (check_language): Add softlink/header check by refactoring the
4269         softlink/framework check.
4270         (CppChecker): Enable softlink/header check by default.
4271         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4272         (CppStyleTest.test_softlink_framework): Rename from
4273         CppStyleTest.test_softlink() and change test framework name in
4274         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4275         files. Set file_name for macros that only appear in headers.
4276         (CppStyleTest.test_softlink_header): Add tests for using
4277         soft-link macros in headers.
4278
4279 2019-01-23  Chris Dumez  <cdumez@apple.com>
4280
4281         Deprecate API to limit the maximum number of WebProcesses
4282         https://bugs.webkit.org/show_bug.cgi?id=193725
4283         <rdar://problem/47464879>
4284
4285         Reviewed by Geoff Garen.
4286
4287         Update existing API tests to stop using deprecated API.
4288
4289         * MiniBrowser/mac/AppDelegate.m:
4290         (defaultConfiguration):
4291         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4292         (TestWebKitAPI::TEST):
4293         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4294         (TestWebKitAPI::TEST):
4295         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4296         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4297         (TEST):
4298         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4299         (TEST):
4300
4301 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4302
4303         [ews-app] Rename ews model buildermappings to buildermapping
4304         https://bugs.webkit.org/show_bug.cgi?id=193729
4305
4306         Reviewed by Lucas Forschler.
4307
4308         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4309         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4310         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4311
4312 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4313
4314         [ews-app] Rename ews model steps to step
4315         https://bugs.webkit.org/show_bug.cgi?id=193697
4316
4317         Reviewed by Lucas Forschler.
4318
4319         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4320         (Step): Renamed Steps to Step.
4321
4322 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4323
4324         Clean up IndexedDB files between tests
4325         https://bugs.webkit.org/show_bug.cgi?id=192796
4326         <rdar://problem/46824999>
4327
4328         Reviewed by Geoffrey Garen.
4329
4330         * DumpRenderTree/mac/DumpRenderTree.mm:
4331         (runTest):
4332         * WebKitTestRunner/TestController.cpp:
4333         (WTR::TestController::resetStateToConsistentValues):
4334         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4335         (WTR::RemoveAllIndexedDatabasesCallback):
4336         (WTR::TestController::ClearIndexedDatabases):
4337         * WebKitTestRunner/TestController.h:
4338         * WebKitTestRunner/TestInvocation.cpp:
4339         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4340
4341 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4342
4343         [ews-app] Rename ews model Builds to Build
4344         https://bugs.webkit.org/show_bug.cgi?id=193695
4345
4346         Reviewed by Lucas Forschler.
4347
4348         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4349         (Build): Renamed Builds to Build.
4350
4351 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4352
4353         webkitpy: Wait longer when launching WebKitTestRunner
4354         https://bugs.webkit.org/show_bug.cgi?id=193734
4355
4356         Reviewed by Aakash Jain.
4357
4358         * Scripts/webkitpy/port/simulator_process.py:
4359         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4360
4361 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4362
4363         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4364         https://bugs.webkit.org/show_bug.cgi?id=193182
4365         <rdar://problem/47452154>
4366
4367         Reviewed by Tim Horton.
4368
4369         This test was timing&