Source/WebCore:
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Jer Noble  <jer.noble@apple.com>
2
3         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4         https://bugs.webkit.org/show_bug.cgi?id=196097
5
6         Reviewed by Eric Carlson.
7
8         Drive-by bug fix: allow tests to play audio without a user gesture by default.
9
10         * DumpRenderTree/mac/DumpRenderTree.mm:
11         (resetWebPreferencesToConsistentValues):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::resetPreferencesToConsistentValues):
14
15 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
16
17         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
18         https://bugs.webkit.org/show_bug.cgi?id=196690
19
20         Reviewed by Michael Catanzaro.
21
22         * QueueStatusServer/config/queues.py:
23         * Scripts/webkitpy/common/config/ews.json:
24         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
25         (test_ews_name):
26
27 2019-04-09  Chris Dumez  <cdumez@apple.com>
28
29         Loads using loadHTMLString() cause flashing when process-swapping
30         https://bugs.webkit.org/show_bug.cgi?id=196714
31         <rdar://problem/49637354>
32
33         Reviewed by Antti Koivisto.
34
35         Add API test coverage.
36
37         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
38
39 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         Unreviewed. Fix ATK accessibility tests after r244059.
42
43         We are failing to load the injected bundle due to undefined symbol
44         AccessibilityUIElement::replaceTextInRange().
45
46         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
47         (WTR::AccessibilityUIElement::replaceTextInRange):
48
49 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
50
51         AX: Support API: accessibilityReplaceRange:withText
52         https://bugs.webkit.org/show_bug.cgi?id=196636
53
54         Unreviewed build fix for Windows port.
55
56         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
57         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
58
59 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
60
61         [CMake][WinCairo] Separate copied headers into different directories
62         https://bugs.webkit.org/show_bug.cgi?id=196655
63
64         Reviewed by Michael Catanzaro.
65
66         * DumpRenderTree/CMakeLists.txt:
67         * MiniBrowser/win/CMakeLists.txt:
68         * TestWebKitAPI/CMakeLists.txt:
69         * TestWebKitAPI/PlatformWin.cmake:
70
71 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
72
73         Log stack-trace for run-webkit-tests when interrupted
74         https://bugs.webkit.org/show_bug.cgi?id=176393
75         <rdar://problem/34262310>
76
77         Reviewed by Lucas Forschler.
78
79         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
80         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
81         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
82         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
83         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
84         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
85         (main): Set handlers to log stack trace on interruption.
86
87 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
88
89         AX: Support API: accessibilityReplaceRange:withText
90         https://bugs.webkit.org/show_bug.cgi?id=196636
91
92         Unreviewed build fix for Windows port.
93
94         * DumpRenderTree/AccessibilityUIElement.cpp:
95         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
96
97 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
98
99         [ews-build] Scripts using Buildbot API have CORS error
100         https://bugs.webkit.org/show_bug.cgi?id=196709
101
102         Reviewed by Alexey Proskuryakov.
103
104         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
105
106 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
107
108         AX: Support API: accessibilityReplaceRange:withText
109         https://bugs.webkit.org/show_bug.cgi?id=196636
110
111         Reviewed by Daniel Bates.
112
113         * DumpRenderTree/AccessibilityUIElement.cpp:
114         (replaceTextInRangeCallback):
115         (AccessibilityUIElement::replaceTextInRange):
116         (AccessibilityUIElement::getJSClass):
117         * DumpRenderTree/AccessibilityUIElement.h:
118         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
119         (AccessibilityUIElement::replaceTextInRange):
120         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
121         (AccessibilityUIElement::replaceTextInRange):
122         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
123         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
124         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
125         (WTR::AccessibilityUIElement::replaceTextInRange):
126         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
127         (WTR::AccessibilityUIElement::replaceTextInRange):
128
129 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
130
131         [iOS] Do not allow starting selection drags when selection views are not visible
132         https://bugs.webkit.org/show_bug.cgi?id=196686
133         <rdar://problem/49399192>
134
135         Reviewed by Tim Horton.
136
137         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
138         also add some new API tests to cover scenarios where the web view is not first responder.
139
140         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
143
144         Add a switch to optionally make the web view first responder when starting the simulated drag.
145
146         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
147         (-[DragAndDropSimulator initWithWebView:]):
148         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
149
150 2019-04-08  Justin Fan  <justin_fan@apple.com>
151
152         [Web GPU] Fix Web GPU experimental feature on iOS
153         https://bugs.webkit.org/show_bug.cgi?id=196632
154
155         Reviewed by Myles C. Maxfield.
156
157         Properly make Web GPU available on iOS 11+.
158
159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
160
161 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-build] Do not upload archive when Compile Fails
164         https://bugs.webkit.org/show_bug.cgi?id=196674
165
166         Reviewed by Alexey Proskuryakov.
167
168         * BuildSlaveSupport/ews-build/factories.py:
169         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
170         * BuildSlaveSupport/ews-build/steps.py:
171         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
172         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
173         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
174
175 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
176
177         Enable DFG on MIPS
178         https://bugs.webkit.org/show_bug.cgi?id=196689
179
180         Reviewed by Žan Doberšek.
181
182         Since the bytecode change, we enabled the baseline JIT on mips in
183         r240432, but DFG is still missing. With this change, all tests are
184         passing on a ci20 board.
185
186         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
187
188 2019-04-08  Philippe Normand  <pnormand@igalia.com>
189
190         [Flatpak] Second run update-webkitwpe-flatpak fails
191         https://bugs.webkit.org/show_bug.cgi?id=192702
192
193         Reviewed by Carlos Garcia Campos.
194
195         * flatpak/flatpakutils.py:
196         (FlatpakObject.flatpak): Fix typo.
197         (FlatpakPackage.install): When installing, also update to the configured remote commit.
198         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
199
200 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
201
202         [GTK][WPE] outlook.live.com displays old-fashioned UI
203         https://bugs.webkit.org/show_bug.cgi?id=196642
204
205         Reviewed by Carlos Garcia Campos.
206
207         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
208         (TestWebKitAPI::TEST): New Mac platform quirk test.
209
210 2019-04-07  Commit Queue  <commit-queue@webkit.org>
211
212         Unreviewed, rolling out r243956.
213         https://bugs.webkit.org/show_bug.cgi?id=196688
214
215         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
216         by aakashjain on #webkit).
217
218         Reverted changeset:
219
220         "Clicking "Go Back" from a safe browsing warning from an
221         iframe should navigate the WKWebView back to the previous
222         page"
223         https://bugs.webkit.org/show_bug.cgi?id=196665
224         https://trac.webkit.org/changeset/243956
225
226 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
227
228         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
229         https://bugs.webkit.org/show_bug.cgi?id=196669
230
231         Reviewed by Geoffrey Garen.
232
233         Added three new unit tests for WeakHashSet.
234
235         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
236         (WTF_WeakPtr.WeakHashSetConstObjects):
237         (WTF_WeakPtr.WeakHashSetComputesEmpty):
238         (WTF_WeakPtr.WeakHashSetComputeSize):
239
240 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
241
242         Hide next and previous form control buttons when WKWebView is editable
243         https://bugs.webkit.org/show_bug.cgi?id=196672
244         <rdar://problem/35625321>
245
246         Reviewed by Tim Horton.
247
248         Add a new API test.
249
250         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
251         (-[TestWKWebView lastTrailingBarButtonGroup]):
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/ios/UIKitSPI.h:
254
255 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
256
257         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
258         https://bugs.webkit.org/show_bug.cgi?id=196077
259         <rdar://problem/49108202>
260
261         Reviewed by Chris Dumez.
262
263         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
264         on new web view.
265
266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
267
268 2019-04-05  Saam Barati  <sbarati@apple.com>
269
270         Make compare-results understand MotionMark
271         https://bugs.webkit.org/show_bug.cgi?id=196666
272
273         Reviewed by Yusuke Suzuki.
274
275         * Scripts/compare-results:
276         (PLT5Results):
277         (detectMotionMark):
278         (detectMotionMark1_1):
279         (motionMarkResults):
280         (motionMark1_1Results):
281         (detectBenchmark):
282         (biggerIsBetter):
283         (main):
284
285 2019-04-05  Alex Christensen  <achristensen@webkit.org>
286
287         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
288         https://bugs.webkit.org/show_bug.cgi?id=196665
289         <rdar://45115669>
290
291         Reviewed by Geoff Garen.
292
293         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
294         (goBack):
295         (+[SimpleLookupContext sharedLookupContext]):
296         (-[SimpleLookupContext lookUpURL:completionHandler:]):
297         (TEST):
298         (+[Simple3LookupContext sharedLookupContext]): Deleted.
299         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
300
301 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
302
303         [ews-build] Add configuration and architecture for windows builders
304         https://bugs.webkit.org/show_bug.cgi?id=196660
305
306         Reviewed by Lucas Forschler.
307
308         * BuildSlaveSupport/ews-build/config.json:
309
310 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
311
312         webkitpy: Don't run subsequent rounds if interrupted
313         https://bugs.webkit.org/show_bug.cgi?id=196646
314
315         Reviewed by Aakash Jain.
316
317         * Scripts/webkitpy/layout_tests/controllers/manager.py:
318         (Manager.run): Bail out if interrupted.
319
320 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
321
322         Test sessionStorage in PSON private browsing mode
323         https://bugs.webkit.org/show_bug.cgi?id=196561
324
325         Reviewed by Alex Christensen.
326
327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
328
329 2019-04-05  Commit Queue  <commit-queue@webkit.org>
330
331         Unreviewed, rolling out r243833.
332         https://bugs.webkit.org/show_bug.cgi?id=196645
333
334         This change breaks build of WPE and GTK ports (Requested by
335         annulen on #webkit).
336
337         Reverted changeset:
338
339         "[CMake][WTF] Mirror XCode header directories"
340         https://bugs.webkit.org/show_bug.cgi?id=191662
341         https://trac.webkit.org/changeset/243833
342
343 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
344
345         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
346         https://bugs.webkit.org/show_bug.cgi?id=196635
347
348         Reviewed by Antti Koivisto.
349         
350         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
351         for a test to enable async frame scrolling via:
352             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
353         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
354         
355         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
356
357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
358         (WTR::InjectedBundle::beginTesting):
359         * WebKitTestRunner/TestController.cpp:
360         (WTR::TestController::resetPreferencesToConsistentValues):
361
362 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
363
364         Use a correct LC_RPATH when building with ASan
365         https://bugs.webkit.org/show_bug.cgi?id=196576
366
367         Reviewed by David Kilzer.
368
369         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
370         so that ../Frameworks is checked. This is simpler and more reliable than updating
371         each SPC service xcconfig.
372
373 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
374
375         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
376         https://bugs.webkit.org/show_bug.cgi?id=196629
377
378         Reviewed by Lucas Forschler.
379
380         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
381
382 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
383
384         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
385         https://bugs.webkit.org/show_bug.cgi?id=196618
386
387         Reviewed by Lucas Forschler.
388
389         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
390         (StatusBubble): Added QUEUE_TRIGGERS.
391         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
392         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
393         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
394         its parent(builder).
395
396 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
397
398         [ews-app] Status-bubble steps are sometimes displayed in reverse order
399         https://bugs.webkit.org/show_bug.cgi?id=196625
400
401         Reviewed by Lucas Forschler.
402
403         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
404         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
405
406 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
407
408         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
409         https://bugs.webkit.org/show_bug.cgi?id=196630
410
411         Reviewed by Wenson Hsieh.
412
413         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
414
415 2019-04-04  Youenn Fablet  <youenn@apple.com>
416
417         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
418         https://bugs.webkit.org/show_bug.cgi?id=196543
419
420         Reviewed by Alex Christensen.
421
422         * WebKitTestRunner/TestController.cpp:
423         (WTR::TestController::generatePageConfiguration):
424
425 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
426
427         [ews-app] Status bubble should not display skipped buildbot steps
428         https://bugs.webkit.org/show_bug.cgi?id=196584
429
430         Reviewed by Lucas Forschler.
431
432         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
433
434 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
435
436         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
437         https://bugs.webkit.org/show_bug.cgi?id=196620
438
439         Reviewed by Lucas Forschler.
440
441         * BuildSlaveSupport/ews-app/ews/config.py:
442
443 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
444
445         [Win] DumpRenderTreeWatchDog.py is not checked into source
446         https://bugs.webkit.org/show_bug.cgi?id=196567
447         <rdar://problem/49525901>
448
449         Reviewed by Lucas Forschler.
450
451         This script is used on Win EWS bots to terminate hanging DRT processes.
452
453         * EWSTools/dumprendertreewatchdog.py: Added.
454
455 2019-04-04  Chris Dumez  <cdumez@apple.com>
456
457         Unreviewed, roll out r243858 which made tests time out.
458
459         Disable new API tests on Windows instead.
460
461         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
462         (TestWebKitAPI::TEST):
463
464 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
465
466         [ATK] Cleanup WebPageAccessibilityObjectAtk
467         https://bugs.webkit.org/show_bug.cgi?id=196537
468
469         Reviewed by Michael Catanzaro.
470
471         Also consider files under atk directories as exceptions for GObject conventions.
472
473         * Scripts/webkitpy/style/checkers/cpp.py:
474         (check_identifier_name_in_declaration):
475
476 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
477
478         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
479         https://bugs.webkit.org/show_bug.cgi?id=196588
480         <rdar://problem/49365787>
481
482         Unreviewed build fix for Windows port.
483
484         error C3861: 'kill': identifier not found
485
486         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
487         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
488
489 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
490
491         [ews-build] Cancel build and similar operations should have authentication
492         https://bugs.webkit.org/show_bug.cgi?id=196520
493
494         Reviewed by Dewei Zhu.
495
496         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
497         environment variables.
498
499 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
500
501         [ews-build] Do not trigger queues which are not in production yet
502         https://bugs.webkit.org/show_bug.cgi?id=196581
503
504         Reviewed by Dewei Zhu.
505
506         * BuildSlaveSupport/ews-build/config.json:
507
508 2019-04-03  Chris Dumez  <cdumez@apple.com>
509
510         Unreviewed, fix typo in the name of API test added in r243848.
511
512         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
513         (TestWebKitAPI::TEST):
514
515 2019-04-03  Chris Dumez  <cdumez@apple.com>
516
517         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
518         https://bugs.webkit.org/show_bug.cgi?id=196588
519         <rdar://problem/49365787>
520
521         Reviewed by Ryosuke Niwa.
522
523         Add API test coverage.
524
525         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
526         (TestWebKitAPI::nullJavaScriptCallback):
527         (TestWebKitAPI::didCrashCheckFrames):
528         (TestWebKitAPI::TEST):
529
530 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
531
532         run-webkit-tests: Upload test results (new results database)
533         https://bugs.webkit.org/show_bug.cgi?id=196577
534         <rdar://problem/34841155>
535
536         Reviewed by Lucas Forschler.
537
538         * Scripts/webkitpy/layout_tests/controllers/manager.py:
539         (Manager.run): Upload results after each device shard, since the configuration will be
540         different for each device.
541         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
542         uploaded to a results database.
543         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
544         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
545
546 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
547
548         -apple-trailing-word is needed for browser detection
549         https://bugs.webkit.org/show_bug.cgi?id=196575
550
551         Unreviewed.
552
553         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
554
555 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
556
557         [CMake][WTF] Mirror XCode header directories
558         https://bugs.webkit.org/show_bug.cgi?id=191662
559
560         Reviewed by Konstantin Tokarev.
561
562         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
563         builds.
564
565         * CMakeLists.txt:
566         * DumpRenderTree/CMakeLists.txt:
567         * DumpRenderTree/PlatformWin.cmake:
568         * MiniBrowser/win/CMakeLists.txt:
569         * TestWebKitAPI/CMakeLists.txt:
570         * TestWebKitAPI/PlatformWin.cmake:
571         * WebKitTestRunner/PlatformGTK.cmake:
572         * WebKitTestRunner/PlatformWin.cmake:
573
574 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
575
576         [ews-app] Status bubble should not display certain infrastructure status messages
577         https://bugs.webkit.org/show_bug.cgi?id=196550
578
579         Reviewed by Lucas Forschler.
580
581         Do not display the steps which are un-needed for end-user. This information is still avaiable
582         if the user click on the bubble and look at the Buildbot build.
583         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
584         (StatusBubble._steps_messages):
585         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
586
587 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
588
589         [ews-build] Use https for sending data to ews-app
590         https://bugs.webkit.org/show_bug.cgi?id=196492
591
592         Reviewed by Lucas Forschler.
593
594         * BuildSlaveSupport/ews-build/events.py:
595
596 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
597
598         Remove support for -apple-trailing-word
599         https://bugs.webkit.org/show_bug.cgi?id=196525
600
601         Reviewed by Zalan Bujtas.
602
603         This CSS property is nonstandard and not used.
604
605         * Scripts/webkitperl/FeatureList.pm:
606         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
607
608 2019-04-03  Youenn Fablet  <youenn@apple.com>
609
610         Add a test for DOMCache on multiple browsing in case of private browsing
611         https://bugs.webkit.org/show_bug.cgi?id=196524
612
613         Reviewed by Alex Christensen.
614
615         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
616         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
617
618 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
619
620         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
621         https://bugs.webkit.org/show_bug.cgi?id=196540
622
623         Reviewed by Aakash Jain.
624
625         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
626
627 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
628
629         Add plumbing for a compatibility mode preference in WebKit
630         https://bugs.webkit.org/show_bug.cgi?id=196005
631
632         Reviewed by Tim Horton.
633
634         Add new API tests.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
638
639 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
640
641         [WPE][GTK] Update libsrtp dependency package for Debian
642         https://bugs.webkit.org/show_bug.cgi?id=196528
643
644         Reviewed by Frédéric Wang.
645
646         * gtk/install-dependencies:
647         * wpe/install-dependencies:
648
649 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
650
651         [WK2] Add support for Window's beforeprint / afterprint events
652         https://bugs.webkit.org/show_bug.cgi?id=196478
653         <rdar://problem/49535124>
654
655         Unreviewed build fix for MSVC.
656
657         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
658
659         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
660
661         * WebKitTestRunner/TestController.cpp:
662         (WTR::printFrame): Use int and float literals.
663
664 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
665
666         [ews-build] Reassign bots to queues
667
668         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
669
670 2019-04-02  Chris Dumez  <cdumez@apple.com>
671
672         [WK2] Add support for Window's beforeprint / afterprint events
673         https://bugs.webkit.org/show_bug.cgi?id=196478
674
675         Reviewed by Alex Christensen.
676
677         Add minimal implementation for printFrame in WebKitTestRunner.
678
679         * WebKitTestRunner/TestController.cpp:
680         (WTR::printFrame):
681         (WTR::TestController::createOtherPage):
682         (WTR::TestController::createWebViewWithOptions):
683
684 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
685
686         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
687         https://bugs.webkit.org/show_bug.cgi?id=196491
688
689         Reviewed by Lucas Forschler.
690
691         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
692
693 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
694
695         [ews-build] Configure buildbot try credentials in environment variables
696         https://bugs.webkit.org/show_bug.cgi?id=196501
697
698         Reviewed by Lucas Forschler.
699
700         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
701         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
702         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
703
704 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
705
706         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
707         https://bugs.webkit.org/show_bug.cgi?id=196496
708         <rdar://problem/49521634>
709
710         Reviewed by Chris Dumez.
711
712         Add new API tests (see WebKit ChangeLog for more detail).
713
714         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
715         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
716         (TEST):
717
718 2019-04-02  David Kilzer  <ddkilzer@apple.com>
719
720         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
721         <https://webkit.org/b/196499>
722
723         Reviewed by Alexey Proskuryakov.
724
725         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
726         ENABLE_ADDRESS_SANITIZER.
727
728 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
729
730         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
731         https://bugs.webkit.org/show_bug.cgi?id=182757
732
733         Reviewed by Don Olmstead.
734
735         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
736         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
737
738 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
739
740         run-api-tests: Upload test results
741         https://bugs.webkit.org/show_bug.cgi?id=196323
742         <rdar://problem/49356714>
743
744         Reviewed by Lucas Forschler.
745
746         * Scripts/webkitpy/api_tests/manager.py:
747         (Manager):
748         (Manager.run): Upload results to a results database.
749         * Scripts/webkitpy/api_tests/run_api_tests.py:
750         (parse_args): Add upload arguments.
751         * Scripts/webkitpy/port/base.py:
752         (Port):
753         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
754         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
755         with commits from any other associated repositories.
756         * Scripts/webkitpy/port/device.py:
757         (Device):
758         (Device.build_version): Access build_versoin of underlying platform device.
759         * Scripts/webkitpy/port/ios_simulator_unittest.py:
760         (IOSSimulatorTest):
761         (IOSSimulatorTest.test_configuration_for_upload):
762         * Scripts/webkitpy/port/device_port.py:
763         (DevicePort):
764         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
765         the same as the machine uploading results.
766         * Scripts/webkitpy/port/mac.py:
767         (MacPort):
768         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
769         * Scripts/webkitpy/port/mac_unittest.py:
770         (MacTest):
771         (MacTest.test_configuration_for_upload):
772         * Scripts/webkitpy/xcode/simulated_device.py:
773         (SimulatedDeviceManager._create_device_with_runtime):
774         (SimulatedDevice.__init__): Create simulated device with a build_version.
775         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
776         (test_existing_simulator):
777
778 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
779
780         Remove extra newline characters (Follow-up fix to r243707)
781
782         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
783
784 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-app] Use API_KEY to accept results data
787         https://bugs.webkit.org/show_bug.cgi?id=196461
788
789         Reviewed by Dewei Zhu.
790
791         * BuildSlaveSupport/ews-app/ews/views/results.py:
792         (Results.post): Validate EWS_API_KEY before accepting any data.
793         * BuildSlaveSupport/ews-build/events.py:
794         (Events.sendData): Send EWS_API_KEY if available along with event data.
795
796 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
797
798         Unable to copy and paste a PDF from Notes into Mail compose body
799         https://bugs.webkit.org/show_bug.cgi?id=196442
800         <rdar://problem/48573098>
801
802         Reviewed by Tim Horton.
803
804         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
805         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
806         to be specified on the item providers.
807
808         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
809         (TestWebKitAPI::mapItemForTesting):
810         (TestWebKitAPI::contactItemForTesting):
811
812 2019-04-01  Tim Horton  <timothy_horton@apple.com>
813
814         Make UIWKDocumentContext rects per-character instead of per-word
815         https://bugs.webkit.org/show_bug.cgi?id=196459
816
817         Reviewed by Wenson Hsieh.
818
819         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
820         (TEST):
821         Adjust test results due to switching to per-character rects.
822
823 2019-04-01  Chris Dumez  <cdumez@apple.com>
824
825         UIProcess crash when a prewarmed process is terminated
826         https://bugs.webkit.org/show_bug.cgi?id=196451
827         <rdar://problem/49245471>
828
829         Reviewed by Geoffrey Garen.
830
831         Add API test coverage.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
834         (TEST):
835
836 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
837
838         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
839         https://bugs.webkit.org/show_bug.cgi?id=196449
840
841         Reviewed by Lucas Forschler.
842
843         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
844         (StatusBubble.get_os_details): Method to get OS and Xcode details.
845         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
846         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
847
848 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
849
850         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
851         https://bugs.webkit.org/show_bug.cgi?id=196444
852
853         Reviewed by Lucas Forschler.
854
855         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
856
857 2019-04-01  Alex Christensen  <achristensen@webkit.org>
858
859         Add SPI to canonicalize NSURLs with WTF::URL
860         https://bugs.webkit.org/show_bug.cgi?id=196415
861         <rdar://problem/44980271>
862
863         Reviewed by Darin Adler.
864
865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
866         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
867         (TestWebKitAPI::TEST):
868
869 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
870
871         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
872         https://bugs.webkit.org/show_bug.cgi?id=196441
873
874         Reviewed by Carlos Garcia Campos.
875
876         Don't cache the wpe_view_backend object that might not exist yet at the
877         time of EventSenderProxy constructor invocation, but instead retrieve
878         that object whenever it's required for event dispatching. This should
879         avoid crashes in this constructor now that it's invoked before any
880         PlatformWindow has been set up (as changed in r243496).
881
882         * WebKitTestRunner/EventSenderProxy.h:
883         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
884         (WTR::viewBackend):
885         (WTR::EventSenderProxy::EventSenderProxy):
886         (WTR::EventSenderProxy::mouseDown):
887         (WTR::EventSenderProxy::mouseUp):
888         (WTR::EventSenderProxy::mouseMoveTo):
889         (WTR::EventSenderProxy::mouseScrollBy):
890         (WTR::EventSenderProxy::keyDown):
891         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
892
893 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
894
895         [Win][WebKit] MiniBrowser should support high DPI display
896         https://bugs.webkit.org/show_bug.cgi?id=196391
897
898         Reviewed by Alex Christensen.
899
900         * MiniBrowser/win/WebKitBrowserWindow.cpp:
901         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
902         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
903         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
904
905 2019-03-31  Sam Weinig  <weinig@apple.com>
906
907         Remove more i386 specific configurations
908         https://bugs.webkit.org/show_bug.cgi?id=196430
909
910         Reviewed by Alexey Proskuryakov.
911
912         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
913         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
914
915 2019-03-31  Andy Estes  <aestes@apple.com>
916
917         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
918         https://bugs.webkit.org/show_bug.cgi?id=196433
919         <rdar://problem/49293305>
920
921         Reviewed by Tim Horton.
922
923         Enhanced API test coverage to include all navigation response policy decisions in both
924         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
928         (TestWebKitAPI::TEST):
929         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
930         (readFile):
931         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
932         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
933         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
934         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
935         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
936         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
937         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
938         (-[QuickLookDelegate _downloadDidStart:]):
939         (-[QuickLookDelegate _download:didReceiveResponse:]):
940         (-[QuickLookDelegate _download:didReceiveData:]):
941         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
942         (-[QuickLookDelegate _downloadDidFinish:]):
943         (-[QuickLookDelegate _download:didFailWithError:]):
944         (-[QuickLookDelegate _downloadDidCancel:]):
945         (-[QuickLookDelegate verifyDownload]):
946         (runTest):
947         (runTestDecideBeforeLoading):
948         (runTestDecideAfterLoading):
949         (TEST):
950         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
951         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
952         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
953         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
954         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
955         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
956         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
957         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
958         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
959         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
960         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
961         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
962         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
963         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
964
965 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
966
967         [CMake] add testdfg as target with build-jsc
968         https://bugs.webkit.org/show_bug.cgi?id=196393
969
970         Reviewed by Saam Barati.
971
972         Added testdfg as one of the targets to build when
973         using CMake.
974
975         * Scripts/build-jsc:
976
977 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
978
979         Delete WebMetal implementation in favor of WebGPU
980         https://bugs.webkit.org/show_bug.cgi?id=195418
981
982         Reviewed by Dean Jackson.
983
984         * DumpRenderTree/mac/DumpRenderTree.mm:
985         (enableExperimentalFeatures):
986         (resetWebPreferencesToConsistentValues):
987         * Scripts/webkitperl/FeatureList.pm:
988         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
990         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
991         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
992         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
993         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
994         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
995         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
996         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
997         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
998         (WTR::InjectedBundle::beginTesting):
999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1000         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1001         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1002
1003 2019-03-29  Chris Dumez  <cdumez@apple.com>
1004
1005         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1006         https://bugs.webkit.org/show_bug.cgi?id=196405
1007         <rdar://problem/49428130>
1008
1009         Reviewed by Wenson Hsieh.
1010
1011         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1012         the popover presentation methods to be no-ops. Use this in the new test added in
1013         r243523 so that we do not swizzle those methods for all tests. This is needed because
1014         those WatchOS tests rely on the popover getting presented and interactive.
1015
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::updateTestOptionsFromTestHeader):
1018         * WebKitTestRunner/TestController.h:
1019         * WebKitTestRunner/TestOptions.h:
1020         (WTR::TestOptions::hasSameInitializationOptions const):
1021         * WebKitTestRunner/ios/TestControllerIOS.mm:
1022         (WTR::TestController::platformInitialize):
1023         (WTR::TestController::platformResetStateToConsistentValues):
1024
1025 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1026
1027         [Curl] Add Server Trust Evaluation Support.
1028         https://bugs.webkit.org/show_bug.cgi?id=191646
1029
1030         Reviewed by Fujii Hironori.
1031
1032         Implemented MiniBrowser UI for asking if user trusts the server.
1033
1034         * MiniBrowser/win/Common.cpp:
1035         (askServerTrustEvaluation):
1036         (replaceString):
1037         * MiniBrowser/win/Common.h:
1038         * MiniBrowser/win/MiniBrowserLib.rc:
1039         * MiniBrowser/win/MiniBrowserLibResource.h:
1040         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1041         (createPEMString):
1042         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1043         (WebKitBrowserWindow::canTrustServerCertificate):
1044         * MiniBrowser/win/WebKitBrowserWindow.h:
1045
1046 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1047
1048         Implement ResizeObserver.
1049         https://bugs.webkit.org/show_bug.cgi?id=157743
1050
1051         Reviewed by Simon Fraser.
1052
1053         Support resizeObserverEnabled webPreferences.
1054
1055         * DumpRenderTree/TestOptions.cpp:
1056         (TestOptions::TestOptions):
1057         * DumpRenderTree/TestOptions.h:
1058         * DumpRenderTree/mac/DumpRenderTree.mm:
1059         (setWebPreferencesForTestOptions):
1060         * DumpRenderTree/win/DumpRenderTree.cpp:
1061         (enableExperimentalFeatures):
1062         * Scripts/webkitperl/FeatureList.pm:
1063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1064
1065 2019-03-28  John Wilander  <wilander@apple.com>
1066
1067         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1068         https://bugs.webkit.org/show_bug.cgi?id=196281
1069         <rdar://problem/48938748>
1070
1071         Reviewed by Alex Christensen.
1072
1073         This patch adds the function isStatisticsHasLocalStorage() to the
1074         TestRunner. With it, the page can query the WebsiteDataStore in the
1075         UI process to make sure that it sees LocalStorage.
1076
1077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1079         (WTR::TestRunner::isStatisticsHasLocalStorage):
1080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1081         * WebKitTestRunner/TestController.cpp:
1082         (WTR::TestController::isStatisticsHasLocalStorage):
1083         * WebKitTestRunner/TestController.h:
1084         * WebKitTestRunner/TestInvocation.cpp:
1085         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1086
1087 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1088
1089         API::Data::createWithoutCopying should do a null check before calling CFRelease
1090         https://bugs.webkit.org/show_bug.cgi?id=196276
1091         <rdar://problem/48059859>
1092
1093         Reviewed by Alex Christensen.
1094
1095         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1096
1097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1098         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1099         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1100         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1101         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1102         (TestWebKitAPI::TEST):
1103
1104 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1105
1106         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1107         https://bugs.webkit.org/show_bug.cgi?id=186276
1108
1109         Reviewed by Carlos Garcia Campos.
1110
1111         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1112         (webViewLoadChanged):
1113         (testWebResourceGetDataError):
1114         (testWebResourceGetDataEmpty):
1115         (beforeAll):
1116         (webViewloadChanged): Deleted.
1117
1118 2019-03-27  Andy Estes  <aestes@apple.com>
1119
1120         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1121         https://bugs.webkit.org/show_bug.cgi?id=196317
1122
1123         Reviewed by Dan Bernstein.
1124
1125         package-root copies built products into a staging directory using ditto(1), which does not
1126         follow symbolic links as it traverses a directory. Now that the files in
1127         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1128         itself, these become broken links when ditto'd into the staging directory.
1129
1130         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1131
1132         * Scripts/package-root:
1133
1134 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-app] Update display text of Submit for ews analysis
1137         https://bugs.webkit.org/show_bug.cgi?id=196309
1138
1139         Reviewed by Dewei Zhu.
1140
1141         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1142
1143 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1144
1145         run-webkit-tests should check for leaks in WebKit processes
1146         <https://webkit.org/b/193772>
1147         <rdar://problem/46526680>
1148
1149         Reviewed by Ryosuke Niwa.
1150
1151         This works by doing the following:
1152         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1153           The list of child processes are returned one per line:
1154           process.name: pid
1155         - Run the "#LIST CHILD PROCESSES" command just before the
1156           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1157           processes on the ServerProcess object.
1158         - When the `--leaks` switch is handled, run check_for_leaks() on
1159           each child process after the main test harness.
1160
1161         * DumpRenderTree/mac/DumpRenderTree.mm:
1162         (handleControlCommand):
1163         - Use strncmp() instead of strcmp().
1164         - Add support for handling "#LIST CHILD PROCESSES" command.
1165
1166         * Scripts/webkitpy/port/base.py:
1167         (Port.check_for_leaks):
1168         * Scripts/webkitpy/port/darwin.py:
1169         (DarwinPort.check_for_leaks):
1170         - Rename redundant 'process_pid' argument to 'process_id'.
1171
1172         * Scripts/webkitpy/port/driver.py:
1173         (Driver.do_post_tests_work):
1174         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1175           longer the only command this sends to WebKitTestRunner.
1176         - If the `--leaks` switch is present, send the
1177           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1178           result using Port.set_webkit_processes().
1179         (Driver._parse_child_processes_output):
1180         - Add helper method to parse list of child process names and
1181           process IDs returned from WebKitTestRunner.
1182
1183         * Scripts/webkitpy/port/ios_device.py:
1184         (IOSDevicePort.check_for_leaks):
1185         - Rename redundant 'process_pid' argument to 'process_id'.
1186
1187         * Scripts/webkitpy/port/leakdetector.py:
1188         (LeakDetector._parse_leaks_output):
1189         - Return early if there is no leaks_output.
1190         (LeakDetector.check_for_leaks):
1191         - Rename redundant 'process_pid' argument to 'process_id'.
1192
1193         * Scripts/webkitpy/port/server_process.py:
1194         (ServerProcess.__init__):
1195         (ServerProcess.child_processes):
1196         (ServerProcess.set_child_processes):
1197         - Add instance variable to Port to store list of child process
1198           names and process IDs returned from WebKitTestRunner.
1199         (ServerProcess._start):
1200         - Clear self._child_processes.
1201         (ServerProcess.stop):
1202         - If self._child_processes is set, call
1203           self._port.check_for_leaks() for each child process.
1204
1205         * Scripts/webkitpy/port/server_process_unittest.py:
1206         (TrivialMockPort.check_for_leaks):
1207         - Rename redundant 'process_pid' argument to 'process_id'.
1208
1209         * Scripts/webkitpy/port/simulator_process.py:
1210         (SimulatorProcess.stop):
1211         - If self._child_processes is set, call
1212           self._port.check_for_leaks() for each child process.
1213
1214         * Scripts/webkitpy/port/watch_device.py:
1215         (WatchDevicePort.check_for_leaks):
1216         - Rename redundant 'process_pid' argument to 'process_id'.
1217
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::dumpResponse):
1220         - Extract method from findAndDumpWorldLeaks() so that it may be
1221           reused by findAndDumpWebKitProcessIdentifiers().
1222         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1223         - Add method to output process name and process ID of both the
1224           WebContent and Networking processes.
1225         (WTR::TestController::findAndDumpWorldLeaks):
1226         - Fix missing newline in output when there were no abandoned
1227           documents.
1228         - Call dumpResponse() for extracted code.
1229         (WTR::TestController::handleControlCommand):
1230         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1231         - Use strncmp() instead of strcmp().
1232         - Call findAndDumpWebKitProcessIdentifiers() when
1233           "#LIST CHILD PROCESSES" command is sent.
1234         * WebKitTestRunner/TestController.h:
1235         (WTR::TestController::dumpResponse):
1236         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1237         - Declare methods.
1238
1239 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1240
1241         Unreviewed. Add GLib API test cases after r243434.
1242
1243         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1244         (testWebViewActiveURI):
1245         (serverCallback):
1246         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1247         (sendRequestCallback):
1248
1249 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1250
1251         Geolocation request not complete when watch request was started in a different web process
1252         https://bugs.webkit.org/show_bug.cgi?id=195996
1253
1254         Reviewed by Alex Christensen.
1255
1256         Add a test case.
1257
1258         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1259         (TestWebKitAPI::runJavaScriptAlert):
1260         (TestWebKitAPI::TEST):
1261
1262 2019-03-26  Keith Rollin  <krollin@apple.com>
1263
1264         Update the way generate-xcfilelists returns strings from functions
1265         https://bugs.webkit.org/show_bug.cgi?id=195975
1266         <rdar://problem/49040807>
1267
1268         Reviewed by Dean Jackson.
1269
1270         There are places where generate-xcfilelists executes assignments with
1271         statements like:
1272
1273             FOO=$(some_function)
1274
1275         where "some_function" return a string by echoing it. E.g.
1276
1277             some_function()
1278             {
1279                 echo "Hello, World"
1280             }
1281
1282         This is a common idiom, but it has a problem if "some_function" needs
1283         to call "exit" in an attempt to halt the entire script right then and
1284         there. Since "some_function" is called inside of $(), it's being
1285         executed in a sub-shell. Calling exit in that sub-shell simply exits
1286         that shell; it doesn't not exit the outer shell in which the main part
1287         of the script is still running. As such, the main script keeps
1288         executing when the intent was for the script to halt.
1289
1290         The solution to this is to use a different idiom for returning
1291         strings. The one we now is to pass in the name of the variable to
1292         receive the string result:
1293
1294             some_function()
1295             {
1296                 variable_name=$1
1297                 eval $variable_name ="Hello, World"
1298             }
1299
1300         The call site now looks like
1301
1302             some_function FOO
1303
1304         Because there's no invocation of a sub-shell, some_function can now
1305         call "exit" if it wants to, and the entire script will exit at that
1306         point.
1307
1308         * Scripts/generate-xcfilelists:
1309
1310 2019-03-26  Chris Dumez  <cdumez@apple.com>
1311
1312         Add basic layout test coverage for File Picker on iOS
1313         https://bugs.webkit.org/show_bug.cgi?id=196265
1314
1315         Reviewed by Wenson Hsieh.
1316
1317         Add layout test infrastructure to test the file picker on iOS.
1318
1319         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1320         (WTR::UIScriptController::dismissFilePicker):
1321         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1322         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1323         (WTR::UIScriptController::dismissFilePicker):
1324         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::TestController::createWebViewWithOptions):
1327         (WTR::updateTestOptionsFromTestHeader):
1328         * WebKitTestRunner/TestOptions.h:
1329         (WTR::TestOptions::hasSameInitializationOptions const):
1330         * WebKitTestRunner/ios/TestControllerIOS.mm:
1331         (overridePresentViewController):
1332         (WTR::TestController::platformInitialize):
1333         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1334         (WTR::UIScriptController::dismissFilePicker):
1335
1336 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1337
1338         Implement async paste method on UIWKInteractionViewProtocol
1339         https://bugs.webkit.org/show_bug.cgi?id=196267
1340         <rdar://problem/49236346>
1341
1342         Reviewed by Tim Horton.
1343
1344         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1345         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1346         are now a part of all iOS 12 internal SDKs.
1347
1348         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1349
1350         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1351         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1352
1353         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1354         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1355         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1356         * TestWebKitAPI/ios/UIKitSPI.h:
1357
1358 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1359
1360         [ews-build] Use PostgreSQL for ews.webkit.org database
1361         https://bugs.webkit.org/show_bug.cgi?id=196270
1362
1363         Reviewed by Lucas Forschler.
1364
1365         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1366
1367 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1368
1369         [ews] Reset simctl states on reboot
1370         https://bugs.webkit.org/show_bug.cgi?id=196260
1371
1372         Rubber-stamped by Aakash Jain.
1373
1374         * EWSTools/start-queue-mac.sh:
1375
1376 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1377
1378         [ews-build] Use PostgreSQL for ews-build database
1379         https://bugs.webkit.org/show_bug.cgi?id=196229
1380
1381         Reviewed by Lucas Forschler.
1382
1383         * BuildSlaveSupport/ews-build/master.cfg:
1384
1385 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1386
1387         [ews-build] Get master_hostname dynamically in master.cfg
1388         https://bugs.webkit.org/show_bug.cgi?id=196255
1389
1390         Reviewed by Lucas Forschler.
1391
1392         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1393         send events data in test mode.
1394
1395 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-app] Set db_constraint to False for Foreign Keys
1398         https://bugs.webkit.org/show_bug.cgi?id=196252
1399
1400         Reviewed by Lucas Forschler.
1401
1402         * BuildSlaveSupport/ews-app/ews/models/build.py:
1403         * BuildSlaveSupport/ews-app/ews/models/step.py:
1404
1405 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1406
1407         [ews-build] is_test_mode_enabled should default to True
1408         https://bugs.webkit.org/show_bug.cgi?id=196248
1409
1410         Reviewed by Lucas Forschler.
1411
1412         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1413
1414 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1415
1416         [ews-app] Add webkitperl to ENABLED_QUEUES
1417         https://bugs.webkit.org/show_bug.cgi?id=196253
1418
1419         Reviewed by Lucas Forschler.
1420
1421         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1422
1423 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1424
1425         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1426         https://bugs.webkit.org/show_bug.cgi?id=196211
1427         rdar://problem/49110552
1428
1429         Reviewed by Tim Horton.
1430
1431         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1432         Make sure that EventSenderProxy always exists when running tests. We used to create
1433         it when resetting before the first test, which is a bit too late.
1434
1435         * WebKitTestRunner/TestController.h:
1436         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1437         (WTR::TestController::platformCreateWebView):
1438         (WTR::TestController::platformCreateOtherPage):
1439         (WTR::TestController::finishCreatingPlatformWebView):
1440         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1441         (WTR::PlatformWebView::PlatformWebView):
1442         Moved some code that made NSWindow use NSEvent during web view creation. We may
1443         need to move more if some other case us found, but this is enough for now.
1444
1445 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         Unreviewed. Fix typo in GLib geolocation API after r243285.
1448
1449         gelocation -> geolocation.
1450
1451         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1452         (testGeolocationManagerWatchPosition):
1453
1454 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1455
1456         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1457         https://bugs.webkit.org/show_bug.cgi?id=196213
1458
1459         Reviewed by Geoff Garen.
1460
1461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1462         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1463         (credentialWithIdentityAndKeychainPath):
1464         (-[ChallengeDelegate webView:didFinishNavigation:]):
1465         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1466         (TestWebKitAPI::TEST):
1467
1468 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1469
1470         Expected shouldn't assume its contained types are copyable
1471         https://bugs.webkit.org/show_bug.cgi?id=195986
1472
1473         Reviewed by JF Bastien.
1474
1475         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1476         (TestWebKitAPI::NonCopyable::operator== const):
1477         (TestWebKitAPI::NonCopyable::operator!= const):
1478         (TestWebKitAPI::TEST):
1479
1480 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1481
1482         Remove some now-unnecessary dynamic class lookup
1483         https://bugs.webkit.org/show_bug.cgi?id=196237
1484
1485         Reviewed by Simon Fraser.
1486
1487         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1488         (makeRequest):
1489         (TEST):
1490
1491 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1492
1493         Unreviewed, rolling out r243450.
1494
1495         AppleWin and WinCairo port builds get broken.
1496
1497         Reverted changeset:
1498
1499         "Add test for fix of #196095"
1500         https://bugs.webkit.org/show_bug.cgi?id=196097
1501         https://trac.webkit.org/changeset/243450
1502
1503 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1504
1505         Unreviewed, rolling out r243465.
1506         https://bugs.webkit.org/show_bug.cgi?id=196226
1507
1508         the test doesn't build (Requested by thorton on #webkit).
1509
1510         Reverted changeset:
1511
1512         "Do not terminate the NetworkProcess if a third party
1513         application sends a NSCredential with a SecIdentityRef"
1514         https://bugs.webkit.org/show_bug.cgi?id=196213
1515         https://trac.webkit.org/changeset/243465
1516
1517 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1518
1519         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1520         https://bugs.webkit.org/show_bug.cgi?id=196213
1521
1522         Reviewed by Geoff Garen.
1523
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1525         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1526         (credentialWithIdentityAndKeychainPath):
1527         (-[ChallengeDelegate webView:didFinishNavigation:]):
1528         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1529         (TestWebKitAPI::TEST):
1530
1531 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1532
1533         [ews-build] Gracefully handle missing patch_id in events
1534         https://bugs.webkit.org/show_bug.cgi?id=196216
1535
1536         Reviewed by Lucas Forschler.
1537
1538         * BuildSlaveSupport/ews-build/events.py:
1539
1540 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-build] use lz4 compression for improving buildbot performance
1543         https://bugs.webkit.org/show_bug.cgi?id=196155
1544
1545         Reviewed by Lucas Forschler.
1546
1547         * BuildSlaveSupport/ews-build/master.cfg:
1548
1549 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1550
1551         Pull some API testing helper methods out of TestWKWebView
1552         https://bugs.webkit.org/show_bug.cgi?id=196212
1553
1554         Reviewed by Tim Horton.
1555
1556         Refactor some more API testing utility methods, so that they can be used in
1557         tests that do not use TestWKWebView.
1558
1559         * TestWebKitAPI/cocoa/TestWKWebView.h:
1560         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1561         (-[WKWebView loadTestPageNamed:]):
1562         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1563         (-[WKWebView synchronouslyLoadHTMLString:]):
1564         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1565         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1566         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1567         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1568         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1569
1570 2019-03-25  Jer Noble  <jer.noble@apple.com>
1571
1572         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1573         https://bugs.webkit.org/show_bug.cgi?id=196097
1574
1575         Reviewed by Eric Carlson.
1576
1577         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1578
1579         * DumpRenderTree/mac/DumpRenderTree.mm:
1580         (resetWebPreferencesToConsistentValues):
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::TestController::resetPreferencesToConsistentValues):
1583
1584 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1585
1586         Pull IPadUserInterfaceSwizzler out into a separate header file
1587         https://bugs.webkit.org/show_bug.cgi?id=196193
1588
1589         Reviewed by Anders Carlsson.
1590
1591         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1592         be used in other API tests.
1593
1594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1595         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1596         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1597         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1598         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1599         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1600         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1601
1602 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1603
1604         Remove NavigatorContentUtils in WebCore/Modules
1605         https://bugs.webkit.org/show_bug.cgi?id=196070
1606
1607         Reviewed by Alex Christensen.
1608
1609         NavigatorContentUtils was to support the custom scheme spec [1].
1610         However, in WebKit side, no port has supported the feature in
1611         WebKit layer after EFL port was removed. So there has been the
1612         only IDL implementation of the NavigatorContentUtils in WebCore.
1613         So we don't need to keep the implementation in WebCore anymore.
1614
1615         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1616
1617         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1618
1619 2019-03-24  Andy Estes  <aestes@apple.com>
1620
1621         [watchOS] Remove unused Proximity Networking code
1622         https://bugs.webkit.org/show_bug.cgi?id=196188
1623
1624         Reviewed by Tim Horton.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1627         (TEST):
1628
1629 2019-03-23  Keith Miller  <keith_miller@apple.com>
1630
1631         Refactor clz/ctz and fix getLSBSet.
1632         https://bugs.webkit.org/show_bug.cgi?id=196162
1633
1634         Reviewed by Saam Barati.
1635
1636         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1637
1638         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1639         (TestWebKitAPI::TEST):
1640
1641 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1642
1643         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1644         https://bugs.webkit.org/show_bug.cgi?id=196143
1645
1646         Reviewed by Michael Catanzaro.
1647
1648         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1649         directories.
1650
1651         * Scripts/webkitpy/style/checkers/cpp.py:
1652         (check_identifier_name_in_declaration):
1653         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1654         (WebKitStyleTest.test_names):
1655
1656 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1657
1658         [Flatpak] Manifest expanding fails for qt WPE extension
1659         https://bugs.webkit.org/show_bug.cgi?id=196148
1660
1661         Reviewed by Alex Christensen.
1662
1663         * flatpak/flatpakutils.py:
1664         (expand_submodules_recurse): The last recurse manifest expand
1665         iteration might lead to a single module so take it into account
1666         and don't try to recurse further.
1667
1668 2019-03-22  Chris Dumez  <cdumez@apple.com>
1669
1670         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1671         https://bugs.webkit.org/show_bug.cgi?id=195348
1672         <rdar://problem/48622090>
1673
1674         Reviewed by Alex Christensen.
1675
1676         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1677         to NO when test.options().shouldIgnoreMetaViewport is false.
1678
1679         * WebKitTestRunner/ios/TestControllerIOS.mm:
1680         (WTR::TestController::platformConfigureViewForTest):
1681
1682 2019-03-22  Chris Dumez  <cdumez@apple.com>
1683
1684         Prewarmed processes should be usable with any website data store
1685         https://bugs.webkit.org/show_bug.cgi?id=196104
1686
1687         Reviewed by Alex Christensen.
1688
1689         Add API test coverage.
1690
1691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1692         (runInitialWarmedProcessUsedTest):
1693         (TEST):
1694
1695 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1696
1697         Back out local changes to Alex's Subversion working directory
1698
1699         They were accidentally committed.
1700
1701         * Scripts/webkitpy/common/system/abstractexecutive.py:
1702         (AbstractExecutive.wait_newest):
1703         * Scripts/webkitpy/common/system/executive.py:
1704         (Executive.running_pids):
1705         * Scripts/webkitpy/common/system/executive_mock.py:
1706         (MockExecutive.running_pids):
1707         * Scripts/webkitpy/common/system/executive_unittest.py:
1708         (ExecutiveTest.serial_test_running_pids):
1709         * Scripts/webkitpy/port/darwin.py:
1710         (DarwinPort.check_for_leaks):
1711         * Scripts/webkitpy/port/leakdetector.py:
1712         (LeakDetector.check_for_leaks):
1713         - This was the hack attached to Bug 193772.
1714
1715         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1716         (+[WebKitTestRunnerEvent mouseLocation]):
1717         - This works around a crash on an internal build.
1718
1719 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1720
1721         Fix the build after r243354
1722         https://bugs.webkit.org/show_bug.cgi?id=196138
1723         <rdar://problem/49145951>
1724
1725         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1726         (TEST):
1727         * TestWebKitAPI/ios/UIKitSPI.h:
1728
1729 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1730
1731         Adopt UIWKDocumentContext
1732         https://bugs.webkit.org/show_bug.cgi?id=196040
1733         <rdar://problem/48642440>
1734
1735         Reviewed by Ryosuke Niwa.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1738         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1739         (makeRequest):
1740         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1741         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1742         (applyStyle):
1743         (TEST):
1744         Add tests for UIWKDocumentContext.
1745
1746         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1747         (TEST):
1748         (recursiveFindWKContentView): Deleted.
1749         * TestWebKitAPI/cocoa/TestWKWebView.h:
1750         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1751         (recursiveFindWKContentView):
1752         (-[TestWKWebView wkContentView]):
1753         * TestWebKitAPI/ios/UIKitSPI.h:
1754         Share the WKContentView finding code between tests.
1755
1756 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1757
1758         [iOS WK2] Turn on async overflow scrolling by default
1759         https://bugs.webkit.org/show_bug.cgi?id=196011
1760         rdar://problem/48453859
1761
1762         Reviewed by Antti Koivisto.
1763         
1764         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1765         since so many basic layout tests have different results when compositing is triggered for
1766         overflow.
1767         
1768         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1769
1770         * WebKitTestRunner/TestController.cpp:
1771         (WTR::TestController::resetPreferencesToConsistentValues):
1772
1773 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1774
1775         [ews-build] Retry API test in case of failures
1776         https://bugs.webkit.org/show_bug.cgi?id=196004
1777
1778         Reviewed by Lucas Forschler.
1779
1780         * BuildSlaveSupport/ews-build/steps.py:
1781         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1782         (CompileWebKitToT.doStepIf): Ditto.
1783         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1784         (ReRunAPITests): Re-run API tests.
1785         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1786         (RunAPITestsWithoutPatch): Run API tests without patch.
1787         (RunAPITestsWithoutPatch.doStepIf):
1788         (RunAPITestsWithoutPatch.hideStepIf):
1789         (RunAPITestsWithoutPatch.evaluateCommand):
1790         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1791         (AnalyzeAPITestsResults.start):
1792         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1793         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1794         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1795         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1796
1797 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1798
1799         [ews-build] Update queues configurations
1800         https://bugs.webkit.org/show_bug.cgi?id=196074
1801
1802         Reviewed by Dewei Zhu.
1803
1804         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1805         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1806
1807 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1808
1809         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1810         https://bugs.webkit.org/show_bug.cgi?id=195680
1811         <rdar://problem/48903534>
1812
1813         Unreviewed infrastructure fix.
1814
1815         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1816         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1817
1818 2019-03-21  Andy Estes  <aestes@apple.com>
1819
1820         [iOS] Apple Pay should be available in documents with no user agent scripts
1821         https://bugs.webkit.org/show_bug.cgi?id=196061
1822         <rdar://problem/48649391>
1823
1824         Reviewed by Brady Eidson.
1825
1826         Added API tests and related infrastructure.
1827
1828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1829         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1830         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1831         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1832         (TestWebKitAPI::TEST):
1833         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1834         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1835         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1836         * TestWebKitAPI/cocoa/TestProtocol.mm:
1837         (-[TestProtocol startLoading]):
1838         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1839         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1840         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1841         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1842
1843 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1844
1845         REGRESSSION (r243297): webkitpy tests broken
1846         https://bugs.webkit.org/show_bug.cgi?id=196108
1847
1848         Reviewed by Aakash Jain.
1849
1850         r243297 updated contributors.json, which broke a few unit tests.
1851
1852         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1853         (IRCCommandTest.test_whois):
1854         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1855
1856 2019-03-21  Chris Dumez  <cdumez@apple.com>
1857
1858         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1859         https://bugs.webkit.org/show_bug.cgi?id=196041
1860         <rdar://problem/49083230>
1861
1862         Reviewed by Alex Christensen.
1863
1864         Add API test coverage.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1867         (TEST):
1868
1869 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1870
1871         Add SPI to inform applications of WKContentRuleList actions
1872         https://bugs.webkit.org/show_bug.cgi?id=195965
1873         <rdar://problem/42664365>
1874
1875         Reviewed by Geoff Garen.
1876
1877         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1878         (TestWebKitAPI::allActionsForResourceLoad):
1879         (TestWebKitAPI::testRequest):
1880         (TestWebKitAPI::TEST_F):
1881         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1882         (Notification::description):
1883         (Notification::operator== const):
1884         (toVector):
1885         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1886         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1887         (makeContentRuleList):
1888         (TEST):
1889         (makeWarnContentRuleList): Deleted.
1890
1891 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1892
1893         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1894         https://bugs.webkit.org/show_bug.cgi?id=196088
1895
1896         Reviewed by Brian Burg.
1897
1898         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1899         Support checks when only one platform is specified. Also deprecate macosx() and
1900         force the use of macos() instead.
1901
1902         * Scripts/webkitpy/style/checkers/cpp.py:
1903         (check_min_versions_of_wk_api_available):
1904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1905         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1906
1907 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1908
1909         Update status inactive committers' status to 'contributor'.
1910
1911         * Scripts/webkitpy/common/config/contributors.json:
1912
1913 2019-03-21  Xan Lopez  <xan@igalia.com>
1914
1915         [JSC][x86] Drop support for x87 floating point
1916         https://bugs.webkit.org/show_bug.cgi?id=194853
1917
1918         Reviewed by Don Olmstead.
1919
1920         Force SSE2 on x86/32bit builds.
1921
1922         * Scripts/webkitdirs.pm:
1923         (generateBuildSystemFromCMakeProject):
1924
1925 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1926
1927         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1928         https://bugs.webkit.org/show_bug.cgi?id=196073
1929
1930         Reviewed by Michael Catanzaro.
1931
1932         Add test cases to check functions and constructors with no arguments but receiving user data.
1933
1934         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1935         (checkUserData):
1936         (testJSCFunction):
1937         (fooCreateWithUserData):
1938         (testJSCClass):
1939
1940 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1941
1942         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1943
1944         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1945
1946         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1947
1948 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1949
1950         [GTK][WPE] Add API to provide geolocation information
1951         https://bugs.webkit.org/show_bug.cgi?id=195940
1952
1953         Reviewed by Michael Catanzaro.
1954
1955         Add a new test to check the new API.
1956
1957         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1958         (testGeolocationManagerCurrentPosition):
1959         (testGeolocationManagerWatchPosition):
1960         (beforeAll):
1961         (afterAll):
1962         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1963         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1964         (beforeAll): Ditto.
1965         * TestWebKitAPI/glib/CMakeLists.txt:
1966
1967 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1968
1969         [GLib] Returning G_TYPE_OBJECT from a method does not work
1970         https://bugs.webkit.org/show_bug.cgi?id=195574
1971
1972         Reviewed by Michael Catanzaro.
1973
1974         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1975
1976         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1977         (getGFile):
1978         (getParent):
1979         (createGString):
1980         (getGString):
1981         (getGStringCopyWillRaise):
1982         (getGStringCopy):
1983         (getGStringStr):
1984         (getGStringLen):
1985         (freeGString):
1986         (testJSCClass):
1987
1988 2019-03-20  Saam Barati  <sbarati@apple.com>
1989
1990         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1991         https://bugs.webkit.org/show_bug.cgi?id=195721
1992
1993         Reviewed by Filip Pizlo.
1994
1995         * Scripts/run-javascriptcore-tests:
1996
1997 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1998
1999         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2000         https://bugs.webkit.org/show_bug.cgi?id=196049
2001
2002         Reviewed by Tim Horton.
2003
2004         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2005         overflow scrolling in general, so rename it.
2006
2007         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2008
2009 2019-03-20  Daniel Bates  <dabates@apple.com>
2010
2011         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2012         https://bugs.webkit.org/show_bug.cgi?id=196031
2013         <rdar://problem/49078172>
2014
2015         Reviewed by Tim Horton.
2016
2017         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2018         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2019         same code path used when the Done button is pressed to dismiss the <select> picker.
2020
2021         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2022         (TestWebKitAPI::TEST):
2023
2024 2019-03-20  Chris Dumez  <cdumez@apple.com>
2025
2026         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2027         https://bugs.webkit.org/show_bug.cgi?id=196029
2028         <rdar://problem/48954651>
2029
2030         Reviewed by Tim Horton.
2031
2032         Add API test coverage.
2033
2034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2035
2036 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2037
2038         [ews-build] Improve failure summary string for ApplyPatch step
2039         https://bugs.webkit.org/show_bug.cgi?id=195995
2040
2041         Reviewed by Alexey Proskuryakov.
2042
2043         * BuildSlaveSupport/ews-build/steps.py:
2044         (ApplyPatch.getResultSummary): Override getResultSummary.
2045
2046 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2047
2048         AX: Implement support for new meter ARIA role
2049         https://bugs.webkit.org/show_bug.cgi?id=195966
2050
2051         Reviewed by Chris Fleizach.
2052
2053         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2054         to AXLevelIndicator.
2055
2056         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2057
2058 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2059
2060         [WebAuthN] Implement FIDO AppID extension
2061         https://bugs.webkit.org/show_bug.cgi?id=143491
2062         <rdar://problem/48298273>
2063
2064         Reviewed by Brent Fulgham.
2065
2066         Add a test that covers the new flag of convertToU2fSignCommand.
2067
2068         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2069         (TestWebKitAPI::TEST):
2070         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2071         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2072         (TestWebKitAPI::TEST):
2073
2074 2019-03-19  Keith Rollin  <krollin@apple.com>
2075
2076         Add support for more platforms to generate-xcfilelists
2077         https://bugs.webkit.org/show_bug.cgi?id=195977
2078
2079         Reviewed by Alexey Proskuryakov.
2080
2081         generate-xcfilelists incorrectly complains when involved with building
2082         WebKit for iphonesimulator:
2083
2084             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2085             …
2086             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2087
2088         Address this by teaching generate-xcfilelists about more platforms.
2089
2090         * Scripts/generate-xcfilelists:
2091
2092 2019-03-19  John Wilander  <wilander@apple.com>
2093
2094         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2095         https://bugs.webkit.org/show_bug.cgi?id=195923
2096         <rdar://problem/49001272>
2097
2098         Reviewed by Alex Christensen.
2099
2100         This patch does the following to the TestRunner:
2101         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2102         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2103         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2104
2105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2107         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2109         * WebKitTestRunner/TestController.cpp:
2110         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2111         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2112         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2113         * WebKitTestRunner/TestController.h:
2114         * WebKitTestRunner/TestInvocation.cpp:
2115         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2116
2117 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2118
2119         [CMake] Support more clang and gcc sanitizers
2120         https://bugs.webkit.org/show_bug.cgi?id=195956
2121
2122         Reviewed by Michael Catanzaro.
2123
2124         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2125
2126 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2127
2128         [ews-build] Improve summary for PrintConfiguration step
2129         https://bugs.webkit.org/show_bug.cgi?id=195945
2130
2131         Reviewed by Lucas Forschler.
2132
2133         * BuildSlaveSupport/ews-build/steps.py:
2134         (PrintConfiguration.getResultSummary): Override getResultSummary.
2135
2136 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2137
2138         [ews-build] Improve summary for CheckOutSource step
2139         https://bugs.webkit.org/show_bug.cgi?id=195963
2140
2141         Reviewed by Lucas Forschler.
2142
2143         * BuildSlaveSupport/ews-build/steps.py:
2144         (CheckOutSource.getResultSummary):
2145
2146 2019-03-19  Daniel Bates  <dabates@apple.com>
2147
2148         [iOS] Focus not preserved when switching between tabs
2149         https://bugs.webkit.org/show_bug.cgi?id=195820
2150         <rdar://problem/43614450>
2151
2152         Reviewed by Brent Fulgham.
2153
2154         Add tests to ensure that we restore focus when resigning and becoming first responder.
2155
2156         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2157         (TestWebKitAPI::TEST):
2158
2159 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2160
2161         Make WTFLogChannelState and WTFLogLevel enum classes
2162         https://bugs.webkit.org/show_bug.cgi?id=195904
2163
2164         Reviewed by Eric Carlson.
2165
2166         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2167         (TestWebKitAPI::TEST_F):
2168
2169 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2170
2171         [GStreamer][EME] Backported mssdemux protection data crash fix
2172         https://bugs.webkit.org/show_bug.cgi?id=195918
2173
2174         Reviewed by Philippe Normand.
2175
2176         * gstreamer/jhbuild.modules:
2177         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2178
2179 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2180
2181         Unreviewed, rolling out r243132.
2182
2183         Broke GTK build
2184
2185         Reverted changeset:
2186
2187         "Make WTFLogChannelState and WTFLogLevel enum classes"
2188         https://bugs.webkit.org/show_bug.cgi?id=195904
2189         https://trac.webkit.org/changeset/243132
2190
2191 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2192
2193         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2194
2195         * Scripts/webkitdirs.pm:
2196         (builtDylibPathForName): Adjust the shared library name that's changed
2197         with the API version bump in r243073.
2198
2199 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2200
2201         Make WTFLogChannelState and WTFLogLevel enum classes
2202         https://bugs.webkit.org/show_bug.cgi?id=195904
2203
2204         Reviewed by Eric Carlson.
2205
2206         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2207         (TestWebKitAPI::TEST_F):
2208
2209 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2210
2211         Disable flaky test added in r2431100
2212         https://webkit.org/b/195785
2213
2214         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2215         (TestWebKitAPI::TEST):
2216         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2217
2218 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2219
2220         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2221         https://bugs.webkit.org/show_bug.cgi?id=195916
2222
2223         Reviewed by Tim Horton.
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2226         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2227
2228 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2229
2230         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2231
2232         * Scripts/webkitpy/common/config/contributors.json:
2233
2234 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2235
2236         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2237         https://bugs.webkit.org/show_bug.cgi?id=195785
2238
2239         Reviewed by Geoffrey Garen.
2240
2241         * TestWebKitAPI/TCPServer.cpp: Added.
2242         (TestWebKitAPI::TCPServer::TCPServer):
2243         (TestWebKitAPI::TCPServer::~TCPServer):
2244         (TestWebKitAPI::TCPServer::socketBindListen):
2245         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2246         * TestWebKitAPI/TCPServer.h: Added.
2247         (TestWebKitAPI::TCPServer::port const):
2248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2249         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2250         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2251         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2252         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2253         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2254         (TestWebKitAPI::respondSlowly):
2255         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2256         (TestWebKitAPI::downloadAtRate):
2257         (TestWebKitAPI::TEST):
2258
2259 2019-03-18  Saam Barati  <sbarati@apple.com>
2260
2261         Add a plan file for JetStream 2
2262         https://bugs.webkit.org/show_bug.cgi?id=190734
2263
2264         Reviewed by Mark Lam.
2265
2266         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2267
2268 2019-03-18  Chris Dumez  <cdumez@apple.com>
2269
2270         Delay WebProcess launch until a load is triggered in a Web view
2271         https://bugs.webkit.org/show_bug.cgi?id=195758
2272         <rdar://problem/48126013>
2273
2274         Reviewed by Geoff Garen.
2275
2276         Add API test coverage. Also update some existing API tests to not expect
2277         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2278
2279         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2280         (TestWebKitAPI::TEST):
2281         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2282         (TestWebKitAPI::TEST):
2283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2284         (TEST):
2285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2286         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2287         (TEST):
2288         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2289         (TEST):
2290         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2291
2292 2019-03-18  Xan Lopez  <xan@igalia.com>
2293
2294         [CMake] Prevent potential warning when determining $architecture
2295         https://bugs.webkit.org/show_bug.cgi?id=195891
2296
2297         Reviewed by Michael Catanzaro.
2298
2299         It's possible for generateBuildSystemForCMakeProject to be called
2300         before determineArchitecture() is ever called. This will make the
2301         first eq check with $architecture to be bogus (and print a
2302         warning). Change that to an eq check with architecture(), which
2303         implicitly calls determineArchitecture() if needed, and change all
2304         the other similar cases in the method in the same way to prevent
2305         future bugs like this one.
2306
2307         * Scripts/webkitdirs.pm:
2308         (generateBuildSystemFromCMakeProject):
2309
2310 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2311
2312         [WPE] Tarballs generated with “make dist” cannot build documentation
2313         https://bugs.webkit.org/show_bug.cgi?id=195885
2314
2315         Reviewed by Carlos Garcia Campos.
2316
2317         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2318
2319 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2320
2321         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2322         https://bugs.webkit.org/show_bug.cgi?id=195883
2323
2324         Reviewed by Carlos Garcia Campos.
2325
2326         * gtkdoc/gtkdoc.py:
2327         (GTKDoc._run_command): When commands fail to run, include the full command line for
2328         the program invocation and the output it has generated on the standard error stream.
2329
2330 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2331
2332         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2333         https://bugs.webkit.org/show_bug.cgi?id=195786
2334
2335         Reviewed by Philippe Normand.
2336
2337         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2338         * wpe/jhbuild.modules: Ditto.
2339
2340 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2341
2342         [ews-build] Don't run clean builds on EWS builders
2343         https://bugs.webkit.org/show_bug.cgi?id=195851
2344
2345         Reviewed by Geoffrey Garen.
2346
2347         * BuildSlaveSupport/ews-build/factories.py:
2348
2349 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2350
2351         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2352         https://bugs.webkit.org/show_bug.cgi?id=195849
2353
2354         Reviewed by Chris Dumez.
2355
2356         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2357
2358         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2359         (runWebsiteDataStoreCustomPaths):
2360
2361 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2362
2363         webkitpy: Upload test results
2364         https://bugs.webkit.org/show_bug.cgi?id=195755
2365         <rdar://problem/48896182>
2366
2367         Reviewed by Aakash Jain.
2368
2369         Establish a new format for uploading results that is not tied to layout tests, apply
2370         that format to webkitpy tests.
2371
2372         * Scripts/webkitpy/common/checkout/scm/git.py:
2373         (Git.native_branch): Return what branch the current checkout is on.
2374         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2375         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2376         * Scripts/webkitpy/common/checkout/scm/svn.py:
2377         (SVN.native_branch): Ditto.
2378         * Scripts/webkitpy/common/system/platforminfo.py:
2379         (PlatformInfo.build_version): Return a build version for Mac.
2380         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2381         (MockPlatformInfo.__init__):
2382         (MockPlatformInfo.build_version):
2383         * Scripts/webkitpy/results: Added.
2384         * Scripts/webkitpy/results/__init__.py: Added.
2385         * Scripts/webkitpy/results/options.py: Added.
2386         (upload_options): OptParse list for upload options.
2387         * Scripts/webkitpy/results/upload.py: Added.
2388         (Upload): Class which enforces the upload format expected by the results server.
2389         (Upload.Expectations):
2390         (Upload.create_configuration):
2391         (Upload.create_commit):
2392         (Upload.create_details):
2393         (Upload.create_run_stats):
2394         (Upload.create_test_result):
2395         (Upload.__init__):
2396         (Upload.Encoder): Encode Upload object as json.
2397         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2398         * Scripts/webkitpy/results/upload_unittest.py: Added.
2399         * Scripts/webkitpy/test/main.py:
2400         (Tester._parse_args): Add upload arguments.
2401         (Tester._run_tests): Allow results to be uploaded.
2402         * Scripts/webkitpy/test/runner.py:
2403         (Runner.__init__): Record which tests were run, rather than just counting them.
2404         (Runner.handle):
2405         * Scripts/webkitpy/test/runner_unittest.py:
2406         (RunnerTest.test_run):
2407         * Scripts/webkitpy/thirdparty/__init__.py:
2408         (AutoinstallImportHook.find_module): Add requests auto-install.
2409         (AutoinstallImportHook._install_requests):
2410         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2411         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2412
2413 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2414
2415         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2416         https://bugs.webkit.org/show_bug.cgi?id=195810
2417
2418         Reviewed by Tim Horton.
2419
2420         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2421         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2422         ending certain layout tests.
2423
2424         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2425         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2426         (-[TestRunnerWKWebView dealloc]):
2427         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2428
2429         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2430         helper method when destroying the web view, and when resetting state between tests.
2431
2432         * WebKitTestRunner/ios/TestControllerIOS.mm:
2433         (WTR::TestController::platformResetStateToConsistentValues):
2434
2435         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2436
2437 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2438
2439         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2440         https://bugs.webkit.org/show_bug.cgi?id=190350
2441         <rdar://problem/45089503>
2442
2443         Reviewed by Geoffrey Garen.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2447         (TEST):
2448         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2449         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2450         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2451         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2452         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2453         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2454         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2455         (runTest):
2456         (createDirectories):
2457         (TEST):
2458         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2459         (TEST):
2460         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2461         (TEST):
2462
2463 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2464
2465         Add support to WebPage for getting the contents as an attributed string.
2466         https://bugs.webkit.org/show_bug.cgi?id=195636
2467         rdar://problem/45055697
2468
2469         Reviewed by Tim Horton.
2470
2471         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2472         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2473
2474 2019-03-15  Chris Dumez  <cdumez@apple.com>
2475
2476         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2477         https://bugs.webkit.org/show_bug.cgi?id=195747
2478
2479         Reviewed by Geoff Garen.
2480
2481         Add API test coverage.
2482
2483         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2484
2485 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2486
2487         Unreviewed, rolling out r242952.
2488
2489         Causing API failures on iOS Simulator
2490
2491         Reverted changeset:
2492
2493         "[PSON] Make sure the WebProcessCache is leverage when
2494         relaunching a process after termination"
2495         https://bugs.webkit.org/show_bug.cgi?id=195747
2496         https://trac.webkit.org/changeset/242952
2497
2498 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2499
2500         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2501         https://bugs.webkit.org/show_bug.cgi?id=195740
2502
2503         Reviewed by Ross Kirsling.
2504
2505         window.open doesn't work for WebKitBrowserWindow because it is not
2506         implemented yet.
2507
2508         1. Implemented createNewPage callback of WKPageUIClient.
2509         2. Changed MainWindow to take a BrowserWindow factory function
2510           instead of BrowserWindowType to be flexible to create
2511           BrowserWindow with extra settings.
2512         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2513           because it is not relevant with MainWindow anymore.
2514
2515         * MiniBrowser/win/Common.cpp:
2516         (parseCommandLine):
2517         * MiniBrowser/win/Common.h:
2518         (CommandLineOptions::CommandLineOptions):
2519         * MiniBrowser/win/MainWindow.cpp:
2520         (MainWindow::MainWindow):
2521         (MainWindow::create):
2522         (MainWindow::init):
2523         (MainWindow::WndProc):
2524         * MiniBrowser/win/MainWindow.h:
2525         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2526         (PrintWebUIDelegate::createWebViewWithRequest):
2527         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2528         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2529         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2530         (WebKitBrowserWindow::updateProxySettings):
2531         (WebKitBrowserWindow::createNewPage):
2532         * MiniBrowser/win/WebKitBrowserWindow.h:
2533         * MiniBrowser/win/WinMain.cpp:
2534         (wWinMain):
2535
2536 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2537
2538         Make it possible to test scrolling tree layer manipulation more easily
2539         https://bugs.webkit.org/show_bug.cgi?id=195780
2540
2541         Reviewed by Tim Horton.
2542         
2543         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2544         cuts off communication of scrolling tree scrolls back to the web process
2545         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2546         allows tests to trigger scrolls which run the scrolling tree layer positioning
2547         logic, but never get another commit from the web process that might mask
2548         scrolling tree bugs.
2549         
2550         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2551         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2552         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2553
2554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2555         (WTR::UIScriptController::scrollUpdatesDisabled const):
2556         (WTR::UIScriptController::setScrollUpdatesDisabled):
2557         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2559         (WTR::UIScriptController::scrollUpdatesDisabled const):
2560         (WTR::UIScriptController::setScrollUpdatesDisabled):
2561         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2562         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2563         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2564         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2565         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2566         * WebKitTestRunner/ios/TestControllerIOS.mm:
2567         (WTR::TestController::platformResetStateToConsistentValues):
2568         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2569         (WTR::UIScriptController::scrollUpdatesDisabled const):
2570         (WTR::UIScriptController::setScrollUpdatesDisabled):
2571
2572 2019-03-14  Youenn Fablet  <youenn@apple.com>
2573
2574         Move IDB storage in private browsing mode to NetworkProcess
2575         https://bugs.webkit.org/show_bug.cgi?id=195602
2576
2577         Reviewed by Brady Eidson.
2578
2579         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2580         (TEST):
2581
2582 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2583
2584         [ews-build] Make descriptionDone messages more readable
2585         https://bugs.webkit.org/show_bug.cgi?id=195760
2586
2587         Reviewed by Lucas Forschler.
2588
2589         * BuildSlaveSupport/ews-build/steps.py:
2590         * BuildSlaveSupport/ews-build/steps_unittest.py:
2591
2592 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Generate status-bubble hover-over messages
2595         https://bugs.webkit.org/show_bug.cgi?id=195680
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2600         (StatusBubble):
2601         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2602         on hover-over.
2603         (StatusBubble._iso_time):
2604         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2605         hover-over message.
2606         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2607
2608 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-app] Gracefully handle the case when state_string is None
2611         https://bugs.webkit.org/show_bug.cgi?id=195753
2612
2613         Reviewed by Lucas Forschler.
2614
2615         * BuildSlaveSupport/ews-app/ews/models/build.py:
2616         * BuildSlaveSupport/ews-app/ews/models/step.py:
2617
2618 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2619
2620         [ews-app] Status bubble display pending for currently running build step
2621         https://bugs.webkit.org/show_bug.cgi?id=195744
2622
2623         Reviewed by Lucas Forschler.
2624
2625         * BuildSlaveSupport/ews-build/events.py:
2626         (Events.stepStarted): If state_string is pending, replace it with step name.
2627
2628 2019-03-14  Chris Dumez  <cdumez@apple.com>
2629
2630         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2631         https://bugs.webkit.org/show_bug.cgi?id=195750
2632
2633         Reviewed by Geoffrey Garen.
2634
2635         Add API test coverage.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2638         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2639         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2640         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2641
2642 2019-03-14  Chris Dumez  <cdumez@apple.com>
2643
2644         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2645         https://bugs.webkit.org/show_bug.cgi?id=195747
2646
2647         Reviewed by Geoff Garen.
2648
2649         Add API test coverage.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2652
2653 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2654
2655         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2656         https://bugs.webkit.org/show_bug.cgi?id=195725
2657         <rdar://problem/48545062>
2658
2659         Reviewed by Tim Horton.
2660
2661         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2662         handler is nil.
2663
2664         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2665         (TestWebKitAPI::TEST):
2666
2667 2019-03-13  Sam Weinig  <sam@webkit.org>
2668
2669         Add utility function to allow easy reverse range-based iteration of a container
2670         https://bugs.webkit.org/show_bug.cgi?id=195542
2671
2672         Reviewed by Antti Koivisto.
2673
2674         * TestWebKitAPI/CMakeLists.txt:
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2677         (TestWebKitAPI::TEST):
2678         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2679
2680 2019-03-13  Chris Dumez  <cdumez@apple.com>
2681
2682         Use a ServiceWorker process per registrable domain
2683         https://bugs.webkit.org/show_bug.cgi?id=195649
2684
2685         Reviewed by Youenn Fablet.
2686
2687         Update API test coverage.
2688
2689         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2690
2691 2019-03-13  Chris Dumez  <cdumez@apple.com>
2692
2693         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2694         https://bugs.webkit.org/show_bug.cgi?id=195684
2695         <rdar://problem/48294714>
2696
2697         Reviewed by Antti Koivisto.
2698
2699         Add API test coverage.
2700
2701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2702
2703 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2704
2705         [ews-app] Remove unused patch view
2706         https://bugs.webkit.org/show_bug.cgi?id=195669
2707
2708         Reviewed by Lucas Forschler.
2709
2710         * BuildSlaveSupport/ews-app/ews/urls.py:
2711         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2712
2713 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2714
2715         [ews-app] Use Buildbot result code variables
2716         https://bugs.webkit.org/show_bug.cgi?id=195668
2717
2718         Reviewed by Alexey Proskuryakov.
2719
2720         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2721         (Buildbot): Added Buildbot result code variables.
2722         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2723         (StatusBubble._build_bubble): Used Buildbot result code variables.
2724
2725 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2726
2727         [Flatpak] Expand submodule recursively
2728         https://bugs.webkit.org/show_bug.cgi?id=195672
2729
2730         Building WPE with flatpak was impossible without that as it was raising an exception.
2731         Also update wpebackend-fdo to match what is built in jhbuild
2732
2733         Reviewed by Philippe Normand.
2734
2735         * flatpak/flatpakutils.py:
2736         (expand_submodules_recurse):
2737         (expand_manifest):
2738         * flatpak/org.webkit.WPEModules.yaml:
2739
2740 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2741
2742         [ews-app] status bubble should be hidden for certain builds
2743         https://bugs.webkit.org/show_bug.cgi?id=194597
2744
2745         Reviewed by Dewei Zhu.
2746
2747         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2748         (StatusBubble._build_bubble):
2749         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2750         because the patch didn't have relevant changes.
2751         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2752         in production yet.
2753
2754 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2755
2756         [Win] Fix a slew of simple clang-cl warnings.
2757         https://bugs.webkit.org/show_bug.cgi?id=195652
2758
2759         Reviewed by Don Olmstead.
2760
2761         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2762         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2763
2764 2019-03-12  Justin Fan  <justin_fan@apple.com>
2765
2766         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2767         https://bugs.webkit.org/show_bug.cgi?id=195518
2768         <rdar://problem/46322356>
2769
2770         Reviewed by Myles C. Maxfield.
2771
2772         * DumpRenderTree/DerivedSources-input.xcfilelist:
2773         * DumpRenderTree/DerivedSources-output.xcfilelist:
2774
2775 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2776
2777         Unreviewed, rolling out r242825.
2778         https://bugs.webkit.org/show_bug.cgi?id=195648
2779
2780         "Broke webkitpy tests with my change to
2781         lldb_dump_class_layout.py" (Requested by rmorisset on
2782         #webkit).
2783
2784         Reverted changeset:
2785
2786         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2787         classes with suspicious padding"
2788         https://bugs.webkit.org/show_bug.cgi?id=195573
2789         https://trac.webkit.org/changeset/242825
2790
2791 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2792
2793         [ews-build] Show status bubbles while the patch is waiting in queue
2794         https://bugs.webkit.org/show_bug.cgi?id=195618
2795
2796         Reviewed by Lucas Forschler.
2797
2798         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2799         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2800         enabled in initial deployment.
2801         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2802         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2803         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2804         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2805         (StatusBubble._build_bubbles_for_patch):
2806
2807 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2808
2809         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2810         https://bugs.webkit.org/show_bug.cgi?id=195573
2811
2812         Reviewed by Simon Fraser.
2813
2814         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2815
2816         * Scripts/dump-class-layout:
2817         (main):
2818         * lldb/lldb_dump_class_layout.py:
2819         (ClassLayout.__init__):
2820         (ClassLayout._compute_padding_recursive):
2821         (LLDBDebuggerInstance.dump_layout_for_classname):
2822         (LLDBDebuggerInstance):
2823         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2824         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2825
2826 2019-03-12  Chris Dumez  <cdumez@apple.com>
2827
2828         Device Orientation access permission should be denied unless explicitly granted by the client
2829         https://bugs.webkit.org/show_bug.cgi?id=195625
2830
2831         Reviewed by Youenn Fablet.
2832
2833         add API test coverage.
2834
2835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2836         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2837         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2838         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2839         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2840         (runDeviceOrientationTest):
2841         (TEST):
2842         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2843         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2844
2845 2019-03-12  Jer Noble  <jer.noble@apple.com>
2846
2847         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2848         https://bugs.webkit.org/show_bug.cgi?id=195137
2849         <rdar://problem/48810307>
2850
2851         Reviewed by Eric Carlson.
2852
2853         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2854         (TestWebKitAPI::TEST):
2855
2856 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2857
2858         [ews-build] Change urls from uat to production
2859         https://bugs.webkit.org/show_bug.cgi?id=195566
2860
2861         Reviewed by Lucas Forschler.
2862
2863         * BuildSlaveSupport/ews-app/ews/config.py:
2864         * BuildSlaveSupport/ews-build/events.py:
2865         * BuildSlaveSupport/ews-build/steps.py:
2866
2867 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] change max_builds for local-worker to 1
2870         https://bugs.webkit.org/show_bug.cgi?id=195568
2871
2872         Reviewed by Lucas Forschler.
2873
2874         * BuildSlaveSupport/ews-build/loadConfig.py:
2875
2876 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2877
2878         Fix the build
2879
2880         * TestRunnerShared/spi/PencilKitTestSPI.h:
2881         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2882
2883 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2884
2885         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2886         https://bugs.webkit.org/show_bug.cgi?id=194131
2887
2888         Reviewed by Michael Catanzaro.
2889
2890         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2891         (uriChanged):
2892         (testUnfinishedSubresourceLoad):
2893         (serverCallback):
2894         (beforeAll):
2895
2896 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2897
2898         WTF::Expected should use std::addressof instead of operator&
2899         https://bugs.webkit.org/show_bug.cgi?id=195604
2900
2901         Reviewed by Myles Maxfield.
2902
2903         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2904         (TestWebKitAPI::Unique::Unique):
2905         (TestWebKitAPI::Unique::operator&):
2906         (TestWebKitAPI::TEST):
2907
2908 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2909
2910         Add Optional to Forward.h.
2911         https://bugs.webkit.org/show_bug.cgi?id=195586
2912
2913         Reviewed by Darin Adler.
2914
2915         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2916         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2917         Remove unnecessary includes from headers.
2918
2919 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2920
2921         Add testing API to hit-test and scroll overflow scrollers
2922         https://bugs.webkit.org/show_bug.cgi?id=195278
2923
2924         Reviewed by Antti Koivisto.
2925         
2926         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2927         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2928         
2929         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2930
2931         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2932         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2933         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2934         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2935         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2936         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2937         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2938         (WTR::enclosingScrollViewIncludingSelf):
2939         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2940
2941 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2942
2943         API test WebKit.RequestTextInputContext fails on iOS
2944         https://bugs.webkit.org/show_bug.cgi?id=195585
2945
2946         Reviewed by Wenson Hsieh and Simon Fraser.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2949         (applyStyle):
2950         (TEST):
2951         Add a viewport, so that the coordinates match up on iOS.
2952         Scroll by moving the UIScrollView's contentOffset.
2953
2954 2019-03-11  Chris Dumez  <cdumez@apple.com>
2955
2956         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2957         https://bugs.webkit.org/show_bug.cgi?id=195506
2958         <rdar://problem/48733477>
2959
2960         Reviewed by Alex Christensen.
2961
2962         Add API test coverage.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2965
2966 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2967
2968         Adding myself to contributors.json
2969
2970         Unreviewed, addming myself to contributors.json .
2971
2972         * Scripts/webkitpy/common/config/contributors.json:
2973
2974 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2975
2976         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2977         https://bugs.webkit.org/show_bug.cgi?id=195511
2978         <rdar://problem/44873269>
2979
2980         Reviewed by Darin Adler.
2981
2982         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2983         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2984         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2985         (TEST_F):
2986
2987 2019-03-11  Chris Dumez  <cdumez@apple.com>
2988
2989         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2990         https://bugs.webkit.org/show_bug.cgi?id=195561
2991
2992         Reviewed by Youenn Fablet.
2993
2994         Make sure the JS in the test requests for permission to receive device orientation events.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2997
2998 2019-03-11  Youenn Fablet  <youenn@apple.com>
2999
3000         Allow storage quota increase by default in WTR
3001         https://bugs.webkit.org/show_bug.cgi?id=195541
3002
3003         Reviewed by Geoffrey Garen.
3004
3005         Allow storage quota increase by default in WTR.
3006         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3007         Use this for tests that explicitly need cache increase.
3008
3009         Instead of increasing quota by 2, make sure the next request is
3010         granted by adding all given parameters.
3011
3012         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3013         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3014         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3015         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3016         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3017         * WebKitTestRunner/TestController.cpp:
3018         (WTR::TestController::setAllowStorageQuotaIncrease):
3019         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3020         * WebKitTestRunner/TestController.h:
3021         * WebKitTestRunner/TestInvocation.cpp:
3022         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3023         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3024         (WTR::TestController::cocoaResetStateToConsistentValues):
3025         (WTR::TestController::setAllowStorageQuotaIncrease):
3026         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3027         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3028         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3029
3030 2019-03-11  Xan Lopez  <xan@igalia.com>
3031
3032         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3033         https://bugs.webkit.org/show_bug.cgi?id=194147
3034
3035         Reviewed by Michael Saboff.
3036
3037         To make --32-bit work correctly on Linux/64bit we need to:
3038
3039         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3040         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3041         unfortunately CMake only allows us to do this during
3042         crosscompilation, which is overkill here.
3043         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3044         pkg-config detection module uses the x86 .pc files instead of the
3045         x86_64 ones.
3046         - Set the -m32 flags for the compiler.
3047
3048         * Scripts/webkitdirs.pm:
3049         (generateBuildSystemFromCMakeProject):
3050
3051 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3052
3053         Add MotionMark-1.1 plan file for run-benchmark script.
3054         https://bugs.webkit.org/show_bug.cgi?id=195481
3055
3056         Rubber-stamped by Darin Adler.
3057
3058         Run-benchmark script should support MontionMark-1.1.
3059
3060         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3061
3062 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3063
3064         [ews-app] Add support for submit-to-ews url
3065         https://bugs.webkit.org/show_bug.cgi?id=195477
3066
3067         Reviewed by Lucas Forschler.
3068
3069         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3070         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3071         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3072         * BuildSlaveSupport/ews-app/ews/urls.py:
3073         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3074
3075 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3076
3077         Unreviewed, rolling out r242688, r242643, r242624.
3078
3079         Caused multiple layout test failures and crashes on iOS and macOS.
3080
3081         Reverted changeset:
3082
3083         "requestAnimationFrame should execute before the next frame"
3084         https://bugs.webkit.org/show_bug.cgi?id=177484
3085         https://trac.webkit.org/changeset/242624/webkit
3086
3087         * Tracing/SystemTracePoints.plist:
3088
3089 2019-03-11  John Wilander  <wilander@apple.com>
3090
3091         Resource Load Statistics: Make it possible exclude localhost from classification
3092         https://bugs.webkit.org/show_bug.cgi?id=195474
3093         <rdar://problem/47520577>
3094
3095         Reviewed by Brent Fulgham.
3096
3097         This patch allows for localhost to be excluded from classification and
3098         treatment as a prevalent resource.
3099
3100         The WebKit Tools change adds a new function called
3101         testRunner.setStatisticsIsRunningTest() which can be used to control this
3102         behavior.
3103
3104         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3105         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3106         (WTR::TestRunner::setStatisticsIsRunningTest):
3107         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3108         * WebKitTestRunner/TestController.cpp:
3109         (WTR::TestController::setStatisticsIsRunningTest):
3110         * WebKitTestRunner/TestController.h:
3111         * WebKitTestRunner/TestInvocation.cpp:
3112         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3113
3114 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3115
3116         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3117         https://bugs.webkit.org/show_bug.cgi?id=195560
3118
3119         Reviewed by Lucas Forschler.
3120
3121         * BuildSlaveSupport/ews-build/master.cfg:
3122
3123 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3124
3125         Unreviewed, rolling out r242698.
3126
3127         API test crashes on bots.
3128
3129         Reverted changeset:
3130
3131         "Add a WKContentRuleList variant that uses copied memory
3132         instead of mmap'd shared memory for class A containerized
3133         apps"
3134         https://bugs.webkit.org/show_bug.cgi?id=195511
3135         https://trac.webkit.org/changeset/242698
3136
3137 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3138
3139         [WPE] Enable web process sandbox
3140         https://bugs.webkit.org/show_bug.cgi?id=195169
3141
3142         Reviewed by Daniel Bates.
3143
3144         * wpe/install-dependencies:
3145         * wpe/jhbuild.modules:
3146
3147 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3148
3149         [ews-app] Use port 17000 for worker communication
3150         https://bugs.webkit.org/show_bug.cgi?id=195558
3151
3152         Reviewed by Lucas Forschler.
3153
3154         * BuildSlaveSupport/ews-build/master.cfg:
3155
3156 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3157
3158         [ews-build] unit-tests fail when passwords.json is missing
3159         https://bugs.webkit.org/show_bug.cgi?id=195557
3160
3161         Reviewed by Lucas Forschler.
3162
3163         * BuildSlaveSupport/ews-build/loadConfig.py:
3164         (loadBuilderConfig):
3165         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3166         (ConfigDotJSONTest.test_configuration):
3167         * BuildSlaveSupport/ews-build/master.cfg:
3168
3169 2019-03-11  Truitt Savell  <tsavell@apple.com>
3170
3171         Unreviewed, rolling out r242702.
3172
3173         Broke High Sierra builders.
3174
3175         Reverted changeset:
3176
3177         "Add utility function to allow easy reverse range-based
3178         iteration of a container"
3179         https://bugs.webkit.org/show_bug.cgi?id=195542
3180         https://trac.webkit.org/changeset/242702
3181
3182 2019-03-11  Sam Weinig  <sam@webkit.org>
3183
3184         Add utility function to allow easy reverse range-based iteration of a container
3185         https://bugs.webkit.org/show_bug.cgi?id=195542
3186
3187         Reviewed by Antti Koivisto.
3188
3189         * TestWebKitAPI/CMakeLists.txt:
3190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3191         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3192         (TestWebKitAPI::TEST):
3193         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3194
3195 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3196
3197         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3198         https://bugs.webkit.org/show_bug.cgi?id=195511
3199         <rdar://problem/44873269>
3200
3201         Reviewed by Darin Adler.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3204         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3205         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3206         (TEST_F):
3207
3208 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3209
3210         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3211         https://bugs.webkit.org/show_bug.cgi?id=195499
3212
3213         Reviewed by Darin Adler.
3214
3215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3216         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3217         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3218         (-[WKWebView synchronouslyFocusTextInputContext:]):
3219         (applyStyle):
3220         (applyIframe):
3221         (TEST):
3222         Add some tests for this SPI.
3223
3224 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3225
3226         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3227         https://bugs.webkit.org/show_bug.cgi?id=181151
3228
3229         Reviewed by Don Olmstead.
3230
3231         * TestWebKitAPI/CMakeLists.txt:
3232         * TestWebKitAPI/PlatformWin.cmake:
3233         Enable TestWTF RunLoop tests in all platforms.
3234
3235         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3236         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3237         (TestWebKitAPI::DerivedOneShotTimer::fired):
3238         (TestWebKitAPI::TEST):
3239         Only a few platforms support nested RunLoop.
3240
3241         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3242         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3243
3244 2019-03-10  David Quesada  <david_quesada@apple.com>
3245
3246         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3247         https://bugs.webkit.org/show_bug.cgi?id=152480
3248
3249         Reviewed by Chris Dumez.
3250
3251         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3252         there are no additional references to the process pool besides the one held by
3253         the download, waits for the download to finish (in the sense that the
3254         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3255         measure, also check that the process pool has been deallocated at the end of the
3256         test. The test wouldn't be meaningful if the process pool were still alive.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3259         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3260         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3261             The download will be canceled because the delegate does not implement the
3262             method to decide the download's destination, so this is where we know the
3263             DownloadProxyMap is done with the DownloadProxy.
3264         (TEST):
3265
3266 2019-03-08  Chris Dumez  <cdumez@apple.com>
3267
3268         Add support for Device Orientation / Motion permission API
3269         https://bugs.webkit.org/show_bug.cgi?id=195329
3270         <rdar://problem/47645367>
3271
3272         Reviewed by Geoffrey Garen.
3273
3274         Add test infrastructure to help test the Device Orientation / Motion permission API.
3275
3276         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3277         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3278         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3280         * WebKitTestRunner/TestController.cpp:
3281         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3282         (WTR::TestController::createWebViewWithOptions):
3283         (WTR::TestController::resetStateToConsistentValues):
3284         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3285         * WebKitTestRunner/TestController.h:
3286         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3287         * WebKitTestRunner/TestInvocation.cpp:
3288         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3289
3290 2019-03-08  Saam barati  <sbarati@apple.com>
3291
3292         Add a compare-results script to compare benchmark results
3293         https://bugs.webkit.org/show_bug.cgi?id=195486
3294         <rdar://problem/48723397>
3295
3296         Reviewed by Geoffrey Garen.
3297
3298         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3299         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3300         to extend it to learn about our other benchmarks.
3301
3302         * Scripts/compare-results: Added.
3303         (readJSONFile):
3304         (detectJetStream2):
3305         (JetStream2Results):
3306         (detectSpeedometer2):
3307         (Speedometer2Results):
3308         (detectPLT5):
3309         (PLT5Results):
3310         (detectBenchmark):
3311         (biggerIsBetter):
3312         (ttest):
3313         (getOptions):
3314         (main):
3315
3316 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3317
3318         Ensure old tab state is cleared between iterations of run-benchmark
3319         https://bugs.webkit.org/show_bug.cgi?id=195393
3320         <rdar://problem/46885583>
3321
3322         Reviewed by Dewei Zhu.
3323
3324         a) ensure the default to restore state is not set
3325         b) terminate Safari correctly
3326         c) Set the system default to ignore Persistent State in Safari
3327
3328         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3329         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3330         (OSXBrowserDriver.prepare_env): 
3331         (OSXBrowserDriver.restore_env):
3332         (OSXBrowserDriver.close_browsers):
3333         (OSXBrowserDriver._terminate_processes):
3334         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3335         (OSXChromeDriver):
3336         (OSXChromeCanaryDriver):
3337         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3338         (OSXFirefoxDriver):
3339         (OSXFirefoxNightlyDriver):
3340         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3341         (OSXSafariDriver):
3342         (OSXSafariDriver.prepare_env):
3343
3344 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3345
3346         [GTK] Several InputMethodFilter tests are failing
3347         https://bugs.webkit.org/show_bug.cgi?id=195408
3348
3349         Reviewed by Carlos Garcia Campos.
3350
3351         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3352         Regressed in r241751.
3353         Hexadecimal values of keycodes are expressed now in upper letters.
3354         Composited characters should be cast to UTF8 strings.
3355
3356         (TestWebKitAPI::TEST):
3357
3358 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3359
3360         [GTK] Make Tools/gtkdoc python3 compatible
3361         https://bugs.webkit.org/show_bug.cgi?id=195359
3362
3363         Reviewed by Carlos Garcia Campos.
3364
3365         * gtkdoc/generate-gtkdoc:
3366         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3367         work with Python 2 and 3.
3368         (get_gtkdoc_module_paths):
3369         The iteritems() was removed in Python 3, so let's use items() that's
3370         available in Python 2 and 3.
3371         (get_generator_for_config):
3372         * gtkdoc/gtkdoc.py:
3373         (GTKDoc._run_command):
3374         The sys.stdout.write() is expecting str in Python 3 and not bytes
3375         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3376         for passing the bytes there.
3377
3378 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3379
3380         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3381         https://bugs.webkit.org/show_bug.cgi?id=195346
3382         <rdar://problem/48667048>
3383
3384         Unreviewed build fix for clang-cl.
3385
3386         * DumpRenderTree/win/DumpRenderTree.cpp:
3387         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3388
3389 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3390
3391         requestAnimationFrame should execute before the next frame
3392         https://bugs.webkit.org/show_bug.cgi?id=177484
3393
3394         Reviewed by Simon Fraser.
3395
3396         Add trace points for the page RenderingUpdate.
3397
3398         * Tracing/SystemTracePoints.plist:
3399
3400 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3401
3402         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3403         https://bugs.webkit.org/show_bug.cgi?id=195353
3404         <rdar://problem/48626394>
3405
3406         Reviewed by Simon Fraser.
3407
3408         * WebKitTestRunner/ios/TestControllerIOS.mm:
3409         (WTR::TestController::platformResetPreferencesToConsistentValues):
3410
3411 2019-03-07  John Wilander  <wilander@apple.com>
3412
3413         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3414         https://bugs.webkit.org/show_bug.cgi?id=195383
3415         <rdar://problem/48570136>
3416
3417         Reviewed by Brent Fulgham.
3418
3419         This patch adds test infrastructure to purge only script-accessible cookies,
3420         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3421
3422         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3424         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3426         * WebKitTestRunner/TestController.cpp:
3427         (WTR::TestController::statisticsDeleteCookiesForHost):
3428         * WebKitTestRunner/TestController.h:
3429         * WebKitTestRunner/TestInvocation.cpp:
3430         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3431
3432 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3433
3434         Unreviewed, rolling out r242354.
3435         https://bugs.webkit.org/show_bug.cgi?id=195402
3436
3437         breaks layout tests in all configurations (Requested by
3438         zdobersek on #webkit).
3439
3440         Reverted changeset:
3441
3442         "[WPE] Enable web process sandbox"
3443         https://bugs.webkit.org/show_bug.cgi?id=195169
3444         https://trac.webkit.org/changeset/242354
3445
3446 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3447
3448         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3449         https://bugs.webkit.org/show_bug.cgi?id=195346
3450
3451         Reviewed by Fujii Hironori.
3452
3453         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3454         (TestWebKitAPI::TEST):
3455         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3456
3457         * DumpRenderTree/win/DumpRenderTree.cpp:
3458         (findFontFallback):
3459         (addFontFallbackIfPresent):
3460         (removeFontFallbackIfPresent):
3461         (main):
3462         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3463         (TestWebKitAPI::Util::moduleDirectory):
3464         (TestWebKitAPI::Util::createInjectedBundlePath):
3465         Use wchar helpers as needed.
3466
3467 2019-03-06  Rob Buis  <rbuis@igalia.com>
3468
3469         Consider supporting the `referrerpolicy` attribute.
3470         https://bugs.webkit.org/show_bug.cgi?id=179053
3471
3472         Reviewed by Darin Adler.
3473
3474         Add a runtime flag for referrerpolicy attribute.
3475
3476         * DumpRenderTree/mac/DumpRenderTree.mm:
3477         (enableExperimentalFeatures):
3478
3479 2019-03-05  Daniel Bates  <dabates@apple.com>
3480
3481         Update expected API test result following r242379
3482         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3483
3484         Update expected x-coordinate of selection rect now that the left padding of
3485         a textarea is sized in ems (so dependent on the font size) just like the left
3486         padding of a text field.
3487
3488         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3489         (TestWebKitAPI::TEST):
3490
3491 2019-03-05  David Quesada  <david_quesada@apple.com>
3492
3493         [WK2] It should be possible to follow links with 'download' attributes
3494         https://bugs.webkit.org/show_bug.cgi?id=195145
3495         rdar://problem/48462642
3496
3497         Reviewed by Alex Christensen.
3498
3499         Add a unit test to verify that activating links with 'download' attributes now
3500         navigates to the linked resource, rather than starts downloading it. Add another
3501         to verify that it is still possible to explicitly download the link via the
3502         'Download' navigation action policy.
3503
3504         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3505         (-[DownloadAttributeTestDelegate init]):
3506         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3507         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3508         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3509         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3510         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3511         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3512         (TEST):
3513         * WebKitTestRunner/TestController.cpp:
3514         (WTR::TestController::decidePolicyForNavigationAction):
3515         * WebKitTestRunner/TestController.h:
3516
3517 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3518
3519         [Curl] Implement Cookie Accept Policy.
3520         https://bugs.webkit.org/show_bug.cgi?id=191645
3521
3522         Reviewed by Fujii Hironori.
3523
3524         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3525         (TestWebKitAPI::Curl::TEST_F):
3526
3527 2019-03-05  Youenn Fablet  <youenn@apple.com>
3528
3529         Rename requestCacheStorageSpace to requestStorageSpace
3530         https://bugs.webkit.org/show_bug.cgi?id=195282
3531
3532         Reviewed by Chris Dumez.
3533
3534         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3535         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3536         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3537
3538 2019-03-05  Brady Eidson  <beidson@apple.com>
3539
3540         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3541         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3542
3543         Reviewed by Tim Horton.
3544
3545         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3546         different directory into that same WKWebView should work.
3547
3548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3549         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3550
3551 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3552
3553         Add WeakHashSet
3554         https://bugs.webkit.org/show_bug.cgi?id=195152
3555
3556         Reviewed by Antti Koivisto.
3557
3558         Added tests for WeakHashSet.
3559
3560         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3561         (TestWebKitAPI::Base::Base): Moved.
3562         (TestWebKitAPI::Derived::foo): Moved.
3563         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3564         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3565         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3566         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3567
3568 2019-03-04  Chris Dumez  <cdumez@apple.com>
3569
3570         Do not share WebProcesses between private and regular sessions
3571         https://bugs.webkit.org/show_bug.cgi?id=195189
3572         <rdar://problem/48421064>
3573
3574         Reviewed by Alex Christensen.
3575
3576         Add API test coverage.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3579         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3580
3581 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3582
3583         [WPE] Enable web process sandbox
3584         https://bugs.webkit.org/show_bug.cgi?id=195169
3585
3586         Reviewed by Daniel Bates.
3587
3588         * wpe/install-dependencies:
3589         * wpe/jhbuild.modules:
3590
3591 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3592
3593         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3594         https://bugs.webkit.org/show_bug.cgi?id=195206
3595
3596         Reviewed by Žan Doberšek.
3597
3598         Add a new test case.
3599
3600         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3601         (testJSCClass):
3602
3603 2019-03-04  Charlie Turner  <cturner@igalia.com>
3604
3605         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3606         https://bugs.webkit.org/show_bug.cgi?id=194898
3607
3608         Reviewed by Žan Doberšek.
3609
3610         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3611         a GCC extension that permits arithmetic on void* pointer. Inline
3612         the macro until this issue is fixed upstream.
3613
3614 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3615
3616         Rid the world of WK_API_ENABLED
3617         https://bugs.webkit.org/show_bug.cgi?id=195263
3618
3619         Reviewed by Dan Bernstein.
3620
3621         List of changed files elided because it's useless.
3622
3623 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3624
3625         Unreviewed follow-up to r242292.
3626
3627         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3628
3629         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3630         (TestWebKitAPI::testStrip): Renamed from strip.
3631         (TestWebKitAPI::TEST):
3632
3633 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3634
3635         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3636
3637         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3638         and bug #194272 for details.
3639
3640         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3641
3642 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3643
3644         Remove some more unused 32-bit code
3645         https://bugs.webkit.org/show_bug.cgi?id=195255
3646
3647         Reviewed by Darin Adler.
3648
3649         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3650         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3651         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3652         (NPP_New):
3653         (NPP_HandleEvent):
3654         (handleEventCarbon): Deleted.
3655
3656 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3657
3658         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3659
3660         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3661         (TestWebKitAPI::TEST):
3662
3663 2019-03-01  Darin Adler  <darin@apple.com>
3664
3665         Finish removing String::format
3666         https://bugs.webkit.org/show_bug.cgi?id=194893
3667
3668         Reviewed by Daniel Bates.
3669 '
3670         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3671
3672 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3673
3674         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3675         https://bugs.webkit.org/show_bug.cgi?id=195229
3676         <rdar://problem/48520362>
3677
3678         Reviewed by Chris Dumez.
3679
3680         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3681         (TEST):
3682
3683 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3684
3685         Add a system trace scope for event region building
3686         https://bugs.webkit.org/show_bug.cgi?id=195226
3687
3688         Reviewed by Jon Lee.
3689
3690         This trace scope measures the time spend converting element rects into Region objects,
3691         which can be large on some pages.
3692
3693         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3694
3695         * Tracing/SystemTracePoints.plist:
3696
3697 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3698
3699         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3700         https://bugs.webkit.org/show_bug.cgi?id=194612
3701
3702         Reviewed by Alex Christensen.
3703
3704         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3705         Just test the new string-processing function and don't touch the actual environment.
3706         (Test cases are all as before, but based on operator== instead of strcmp.)
3707
3708 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3709
3710         [ews-app] Update primary keys for handling multiple Buildbot instances
3711         https://bugs.webkit.org/show_bug.cgi?id=195120
3712
3713         Reviewed by Stephanie Lewis.
3714
3715         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3716         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3717         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3718
3719         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3720         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3721         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3722         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3723         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3724         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3725
3726 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3727
3728         [WinCairo] Enable service worker
3729         https://bugs.webkit.org/show_bug.cgi?id=188318
3730
3731         Reviewed by Youenn Fablet.
3732
3733         * DumpRenderTree/DumpRenderTreePrefix.h:
3734         * TestWebKitAPI/PlatformWin.cmake:
3735         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3736         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3737         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3738
3739 2019-03-01  Justin Fan  <justin_fan@apple.com>
3740
3741         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3742         https://bugs.webkit.org/show_bug.cgi?id=195191
3743
3744         Rubber-stamped by Dean Jackson.
3745
3746         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3747
3748         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3749
3750 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3751
3752         Unreviewed, fix lldb webkitpy tests
3753         https://bugs.webkit.org/show_bug.cgi?id=194375
3754
3755         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3756
3757         * lldb/lldb_webkit.py:
3758         (WTFStringImplProvider.is_8bit):
3759
3760 2019-02-28  David Quesada  <david_quesada@apple.com>
3761
3762         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3763         https://bugs.webkit.org/show_bug.cgi?id=195121
3764         rdar://problem/48450302
3765
3766         Reviewed by Alex Christensen.
3767
3768         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3769         configurations where the 'download' attribute is absent, blank, or populated
3770         with a filename, and where the anchor element is same-origin or cross-origin
3771         (meaning the 'download' attribute shouldn't be honored).
3772
3773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3774         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3775         (-[NavigationActionTestDelegate init]):
3776         (-[NavigationActionTestDelegate navigationAction]):
3777         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3778         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3779         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3780         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3781         (TEST):
3782
3783 2019-02-28  Antoine Quint  <graouts@apple.com>
3784
3785         Enable the Pointer Events runtime flag by default
3786         https://bugs.webkit.org/show_bug.cgi?id=195156
3787
3788         Reviewed by Dean Jackson.
3789
3790         * DumpRenderTree/mac/DumpRenderTree.mm:
3791         (enableExperimentalFeatures):
3792
3793 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3794
3795         Several PasteImage API tests are flaky
3796         https://bugs.webkit.org/show_bug.cgi?id=195160
3797
3798         Reviewed by Tim Horton.
3799
3800         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3801         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3802         listening for a "load" event after image load is already complete.
3803
3804         To address this, make these tests first register a "load" event handler, then run script to insert an image
3805         element into the document, and finally wait until the load event is observed before checking image size.
3806
3807         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3808
3809 2019-02-28  Chris Dumez  <cdumez@apple.com>
3810
3811         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3812         https://bugs.webkit.org/show_bug.cgi?id=195107
3813
3814         Reviewed by Alex Christensen.
3815
3816         Give some time for the zoom level to get restored.
3817
3818         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3819
3820 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3821
3822         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3823         https://bugs.webkit.org/show_bug.cgi?id=194958
3824
3825         Reviewed by Geoffrey Garen.
3826
3827         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3828         (TEST):
3829
3830 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3831
3832         [ews-app] Update method to save build to handle builder_display_name
3833         https://bugs.webkit.org/show_bug.cgi?id=195047
3834
3835         Reviewed by Dewei Zhu.
3836
3837         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3838         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3839
3840 2019-02-28  Justin Fan  <justin_fan@apple.com>
3841
3842         [Web GPU] Enable Web GPU only on 64-bit
3843         https://bugs.webkit.org/show_bug.cgi?id=195139
3844
3845         Because Metal is only supported on 64 bit apps.
3846
3847         Unreviewed build fix.
3848
3849         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3850
3851 2019-02-27  Youenn Fablet  <youenn@apple.com>
3852
3853         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3854         https://bugs.webkit.org/show_bug.cgi?id=194959
3855
3856         Reviewed by Chris Dumez.
3857
3858         Spin loop until getting the condition to remove flakiness.
3859
3860         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3861
3862 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3863
3864         [ews-build] Buildbot should include builder_display_name in the build events
3865         https://bugs.webkit.org/show_bug.cgi?id=195045
3866
3867         Reviewed by Dewei Zhu.
3868
3869         * BuildSlaveSupport/ews-build/events.py:
3870         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3871         buildername to builder_name to be consistent in naming style.
3872         (Events.buildFinished): Ditto.
3873
3874 2019-02-27  Chris Dumez  <cdumez@apple.com>
3875
3876         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3877         https://bugs.webkit.org/show_bug.cgi?id=194480
3878
3879         Reviewed by Brady Eidson.
3880
3881         Update existing API test to make it more likely to reproduce the issue.
3882
3883         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3884
3885 2019-02-27  Brady Eidson  <beidson@apple.com>
3886
3887         Universal links from Google search results pages don't open the app.
3888         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3889
3890         Reviewed by Geoffrey Garen.
3891
3892         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3893         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3894         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3895         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3896
3897 2019-02-27  Chris Dumez  <cdumez@apple.com>
3898
3899         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3900         https://bugs.webkit.org/show_bug.cgi?id=195102
3901
3902         Reviewed by Geoffrey Garen.
3903
3904         If the number of processes is not yet what we expect, wait a bit and check again to give
3905         processes some time to exit.
3906
3907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3908
3909 2019-02-27  Chris Dumez  <cdumez@apple.com>
3910
3911         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3912         https://bugs.webkit.org/show_bug.cgi?id=194545
3913
3914         Reviewed by Brady Eidson.
3915
3916         Make sure the test navigates forward and then back only once. Previously, navigating
3917         back would trigger a navigation again in a timer.
3918
3919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3920
3921 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3922
3923         High Sierra Debug JSC test queue should use faster hardware
3924         https://bugs.webkit.org/show_bug.cgi?id=194603
3925
3926         Rubber-stamped by Alexey Proskuryakov.
3927
3928         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3929
3930         * BuildSlaveSupport/build.webkit.org-config/config.json:
3931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3932         (BubbleQueueServer):
3933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3934         (WebKitBuildbot):
3935         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3936         * QueueStatusServer/config/queues.py:
3937         * Scripts/webkitpy/common/config/ews.json:
3938         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3939         (test_ews_name):
3940
3941 2019-02-27  John Wilander  <wilander@apple.com>
3942
3943         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3944         https://bugs.webkit.org/show_bug.cgi?id=195071
3945         <rdar://problem/48417690>
3946
3947         Reviewed by Alex Christensen and Brent Fulgham.
3948
3949         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3950         (TestWebKitAPI::createURL):
3951             Convenience function.
3952         (TestWebKitAPI::TEST):
3953             WebCore::AdClickAttribution now takes a URL when creating Source and
3954             Destination.
3955         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3956         (TestWebKitAPI::TEST):
3957             WebCore::AdClickAttribution now takes a URL when creating Source and
3958             Destination.
3959
3960 2019-02-27  Antoine Quint  <graouts@apple.com>
3961
3962         Support Pointer Events on macOS
3963         https://bugs.webkit.org/show_bug.cgi?id=195008
3964         <rdar://problem/47454419>
3965
3966         Reviewed by Dean Jackson.
3967
3968         * DumpRenderTree/mac/DumpRenderTree.mm:
3969         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3970         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3971
3972 2019-02-26  Mark Lam  <mark.lam@apple.com>
3973
3974         Remove remaining poisoning code.
3975         https://bugs.webkit.org/show_bug.cgi?id=194138
3976
3977         Reviewed by Saam Barati.
3978
3979         * TestWebKitAPI/CMakeLists.txt:
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3981         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3982         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3983         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3984         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3985         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3986         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3987
3988 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3989
3990         Move ephemeral local storage from WebProcess to UIProcess
3991         https://bugs.webkit.org/show_bug.cgi?id=195074
3992         <rdar://problem/47937975>
3993
3994         Reviewed by Geoff Garen.
3995
3996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3997
3998 2019-02-20  Jer Noble  <jer.noble@apple.com>
3999
4000         [Cocoa] Media elements will restart network buffering just before suspending
4001         https://bugs.webkit.org/show_bug.cgi?id=193691
4002
4003         Reviewed by Eric Carlson.
4004
4005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4006         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4007         (TEST):
4008
4009 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4010
4011         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4012         https://bugs.webkit.org/show_bug.cgi?id=191652
4013
4014         Reviewed by Alex Christensen.
4015
4016         Fix WinCairo MiniBrowser behavior of authentication dialog.
4017
4018         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4019         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4020
4021 2019-02-26  Youenn Fablet  <youenn@apple.com>
4022
4023         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4024         https://bugs.webkit.org/show_bug.cgi?id=195028
4025         <rdar://problem/48243733>
4026
4027         Reviewed by Eric Carlson.
4028
4029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4030
4031 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4032
4033         [WPE] Add API for webview background color configuration
4034         https://bugs.webkit.org/show_bug.cgi?id=192305
4035
4036         Reviewed by Michael Catanzaro.
4037
4038         * MiniBrowser/wpe/main.cpp:
4039         (main): Add a new option to configure the webview background
4040         color. Example: --bg-color=transparent.
4041         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4042         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4043         (beforeAll): Ditto.
4044
4045 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4046
4047         scalableNativeWebpageParameters() is not preserved on new page navigation.
4048         https://bugs.webkit.org/show_bug.cgi?id=194892
4049         <rdar://problem/47538280>
4050
4051         Reviewed by Wenson Hsieh.
4052         
4053         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4054
4055         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4056         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4057         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4058         (WTR::UIScriptController::allowsViewportShrinkToFit):
4059         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4060         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4061         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4062         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4063         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4064         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4065
4066 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4067
4068         [ews-app] Add model for handling multiple Buildbot instances
4069         https://bugs.webkit.org/show_bug.cgi?id=194863
4070
4071         Reviewed by Stephanie Lewis.
4072
4073         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4074
4075 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4076
4077         [ews-app] Remove BuilderMapping table
4078         https://bugs.webkit.org/show_bug.cgi?id=194961
4079
4080         Reviewed by Stephanie Lewis.
4081
4082         Store builder name directly in build table, instead of having a separate
4083         table for it.
4084
4085         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4086         * BuildSlaveSupport/ews-app/ews/models/build.py:
4087         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4088         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4089
4090 2019-02-25  John Wilander  <wilander@apple.com>
4091
4092         Introduce and adopt new class RegistrableDomain for eTLD+1
4093         https://bugs.webkit.org/show_bug.cgi?id=194791
4094         <rdar://problem/48179240>
4095
4096         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4097
4098         This patch adds an API test and replaces two instances of
4099         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4100
4101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4102         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4103         (TestWebKitAPI::TEST):
4104             Changed two strings to make sure the registrable domains are still considered
4105             invalid and pass the test.
4106         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4107         (TestWebKitAPI::TEST):
4108         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4109         (WTR::InjectedBundle::didReceiveMessageToPage):
4110
4111 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4112
4113         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4114         https://bugs.webkit.org/show_bug.cgi?id=195001
4115
4116         Reviewed by Carlos Garcia Campos.
4117
4118         API version 1.0 always includes the functionality previously guarded with
4119         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4120         unconditionally.
4121
4122         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4123         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4124         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4125         (WebViewTest::showInWindow): Ditto.
4126         (WebViewTest::hideView): Ditto.
4127         * wpe/backends/HeadlessViewBackend.cpp:
4128         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4129         * wpe/backends/ViewBackend.cpp:
4130         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4131         * wpe/backends/WindowViewBackend.cpp:
4132         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4133         WPE_BACKEND_CHECK_VERSION().
4134         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4135
4136 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4137
4138         [Flatpak] Add support for flatpak > 1.1.2
4139         https://bugs.webkit.org/show_bug.cgi?id=194088
4140
4141         Flatpak 1.2 is now out so we need to support that
4142         version now.
4143
4144         Reviewed by Michael Catanzaro.
4145
4146         * flatpak/flatpakutils.py:
4147         (check_flatpak):
4148         (FlatpakPackages.__init__):
4149         (FlatpakPackages.__detect_packages):
4150         (FlatpakPackages.__detect_packages.in):
4151         (FlatpakRepos.update):
4152
4153 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4154
4155         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4156         https://bugs.webkit.org/show_bug.cgi?id=194998
4157
4158         Reviewed by Carlos Garcia Campos.
4159
4160         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4161         to a Git checkout and using the latest commit containing various fixes
4162         and improvements.
4163
4164 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4165
4166         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4167         https://bugs.webkit.org/show_bug.cgi?id=194981
4168
4169         Reviewed by Žan Doberšek.
4170
4171         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4172         (TestWebKitAPI::TEST):
4173
4174 2019-02-23  Keith Miller  <keith_miller@apple.com>
4175
4176         Add new mac target numbers
4177         https://bugs.webkit.org/show_bug.cgi?id=194955
4178
4179         Reviewed by Tim Horton.
4180
4181         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4182         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4183         * MiniBrowser/Configurations/Base.xcconfig:
4184         * TestWebKitAPI/Configurations/Base.xcconfig:
4185         * WebKitTestRunner/Configurations/Base.xcconfig:
4186
4187 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4188
4189         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4190         https://bugs.webkit.org/show_bug.cgi?id=194846
4191
4192         Reviewed by Don Olmstead.
4193
4194         Added _search_paths() and _port_specific_expectations_files() for
4195         WinCairoPort.
4196
4197         * Scripts/webkitpy/port/win.py:
4198         (WinCairoPort.default_baseline_search_path):
4199         (WinCairoPort):
4200         (WinCairoPort._port_specific_expectations_files):
4201         (WinCairoPort._search_paths):
4202
4203 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4204
4205         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4206         https://bugs.webkit.org/show_bug.cgi?id=194963
4207
4208         Reviewed by Dean Jackson.
4209
4210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4211         Do a `contains` check instead of `equals`, because in debug builds we
4212         put the GraphicsLayer pointer in a prefix.
4213
4214 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4215
4216         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4217         https://bugs.webkit.org/show_bug.cgi?id=194873
4218         <rdar://problem/46701974>
4219
4220         Reviewed by Tim Horton.
4221
4222         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4223
4224         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4225         (WTR::UIScriptController::menuRect const):
4226         (WTR::UIScriptController::isShowingMenu const):
4227         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4228         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4229         (WTR::UIScriptController::menuRect const):
4230
4231         Add a function to query the bounds of the callout menu in content coordinates.
4232
4233         (WTR::UIScriptController::isShowingMenu const):
4234
4235         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4236
4237         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4238         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4239         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4240         (WTR::UIScriptController::rectForMenuAction const):
4241         (WTR::UIScriptController::menuRect const):
4242         (WTR::UIScriptController::isShowingMenu const):
4243         (WTR::findViewInHierarchyOfType): Deleted.
4244
4245 2019-02-22  Chris Dumez  <cdumez@apple.com>
4246
4247         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4248         https://bugs.webkit.org/show_bug.cgi?id=194954
4249         <rdar://problem/48127957>
4250
4251         Reviewed by Alex Christensen.
4252
4253         Add API test coverage.
4254
4255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4256         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4257         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4258         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4259
4260 2019-02-22  Chris Dumez  <cdumez@apple.com>
4261
4262         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4263         https://bugs.webkit.org/show_bug.cgi?id=194924
4264         <rdar://problem/48216125>
4265
4266         Reviewed by Geoffrey Garen.
4267
4268         Add API test coverage.
4269
4270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4271
4272 2019-02-22  Chris Dumez  <cdumez@apple.com>
4273
4274         Unreviewed, disable API test added in r241928 on iOS.
4275
4276         The cache is not enabled on devices with less than 3GB of RAM.
4277
4278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4279
4280 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4281
4282         Hardcode Visual Viewports on everywhere except iOS WK1
4283         https://bugs.webkit.org/show_bug.cgi?id=194928
4284
4285         Reviewed by Zalan Bujtas.
4286
4287         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4288         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4289         set it to false. The setting has shipped for several years and there's no need to turn
4290         it off now.
4291
4292         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4293         Visual Viewports are not enabled.
4294         
4295         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4296         that only runs in WK2
4297
4298         * MiniBrowser/mac/SettingsController.h:
4299         * MiniBrowser/mac/SettingsController.m:
4300         (-[SettingsController init]):
4301         (-[SettingsController _populateMenu]):
4302         (-[SettingsController validateMenuItem:]):
4303         (-[SettingsController visualViewportEnabled]): Deleted.
4304         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4305         * MiniBrowser/mac/WK1BrowserWindowController.m:
4306         (-[WK1BrowserWindowController didChangeSettings]):
4307         * MiniBrowser/mac/WK2BrowserWindowController.m:
4308         (-[WK2BrowserWindowController didChangeSettings]):
4309
4310 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4311
4312         Discard cached processes when clearing website data store
4313         https://bugs.webkit.org/show_bug.cgi?id=194894
4314
4315         Reviewed by Chris Dumez.
4316
4317         Added a test case.
4318
4319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4320         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4321
4322 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4323
4324         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4325         https://bugs.webkit.org/show_bug.cgi?id=194914
4326         <rdar://problem/47586889>
4327
4328         Reviewed by Geoffrey Garen.
4329
4330         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4331         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4332         (TEST):
4333         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4334
4335 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4336
4337         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4338         <https://webkit.org/b/194761>
4339
4340         Reviewed by Myles Maxfield.
4341
4342         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4343         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4344         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4345         to use ARC-compliant cast.
4346         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4347         ARC-compliant cast.
4348         (WTR::installFakeHelvetica): Log `error` to console if
4349         CTFontManagerRegisterFontsForURL() fails, but only on supported
4350         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4351         Call CFRelease() on `error` to fix the leak.  Update to use
4352         ARC-compliant cast.
4353         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4354         cast.
4355
4356 2019-02-21  Chris Dumez  <cdumez@apple.com>
4357
4358         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4359         https://bugs.webkit.org/show_bug.cgi?id=194481
4360
4361         Reviewed by Alex Christensen.
4362
4363         Give the processes a chance to shutdown and wait until we reached the expected number
4364         of processes.
4365
4366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4367