Unreviewed, rolling out r241269.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Truitt Savell  <tsavell@apple.com>
2
3         Unreviewed, rolling out r241269.
4
5         Caused 5 layout tests crashes on Mac WK1
6
7         Reverted changeset:
8
9         "DumpRenderTree should report unknown options"
10         https://bugs.webkit.org/show_bug.cgi?id=191303
11         https://trac.webkit.org/changeset/241269
12
13 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
14
15         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
16         https://bugs.webkit.org/show_bug.cgi?id=194313
17
18         Reviewed by Tim Horton.
19
20         Add a helper to determine whether the web view is presenting modal UI.
21
22         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
23         (WTR::UIScriptController::isPresentingModally const):
24         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
25         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
26         (WTR::UIScriptController::isPresentingModally const):
27         * TestRunnerShared/UIScriptContext/UIScriptController.h:
28         * WebKitTestRunner/UIScriptControllerCocoa.mm:
29         (WTR::UIScriptController::calendarType const): Deleted.
30         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
31         (WTR::UIScriptController::isPresentingModally const):
32         (WTR::UIScriptController::calendarType const):
33         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
34         (WTR::UIScriptController::calendarType const):
35
36 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
37
38         GCHeapInspector: Show the retained sizes in more places
39         https://bugs.webkit.org/show_bug.cgi?id=194464
40
41         Reviewed by Simon Fraser.
42
43         * GCHeapInspector/gc-heap-inspector.html:
44         * GCHeapInspector/script/interface.js:
45         (HeapInspectorUtils.humanReadableSize):
46         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
47         (HeapInspectorUtils.spanForNode.span.span):
48         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
49         (HeapSnapshotInspector.prototype.buildRoots):
50
51 2019-02-11  Daniel Bates  <dabates@apple.com>
52
53         [iOS] Mouse/Touch/Pointer events are missing modifier keys
54         https://bugs.webkit.org/show_bug.cgi?id=191446
55         <rdar://problem/45929460>
56
57         Reviewed by Tim Horton.
58
59         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
60
61         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
62         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
63         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
64         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
65         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
66         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
67         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
68         * TestRunnerShared/UIScriptContext/UIScriptController.h:
69         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
70         (WTR::arrayLength):
71         (WTR::parseModifierArray):
72         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
73         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
74         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
75         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
76
77 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
78
79         DumpRenderTree should report unknown options
80         https://bugs.webkit.org/show_bug.cgi?id=191303
81
82         Reviewed by Frédéric Wang.
83
84         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
85         to report unknown options.
86         Added and assigned test options which are currently used in tests.
87
88         * DumpRenderTree/TestOptions.cpp:
89         (TestOptions::TestOptions):
90
91 2019-02-11  Truitt Savell  <tsavell@apple.com>
92
93         Unreviewed, rolling out r241229.
94
95         Revision broke internal builds for watchOS.
96
97         Reverted changeset:
98
99         "[Cocoa] Ask platform for generic font family mappings"
100         https://bugs.webkit.org/show_bug.cgi?id=187723
101         https://trac.webkit.org/changeset/241229
102
103 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
104
105         [WinCairo][MiniBrowser] Basic authentication always fails.
106         https://bugs.webkit.org/show_bug.cgi?id=194496
107
108         Reviewed by Don Olmstead.
109
110         * MiniBrowser/win/DialogHelper.h:
111         (Dialog::getText):
112
113 2019-02-11  Philippe Normand  <pnormand@igalia.com>
114
115         [GStreamer] GstMappedBuffer testsuite build fails
116         https://bugs.webkit.org/show_bug.cgi?id=194495
117
118         Reviewed by Carlos Garcia Campos.
119
120         Fix the build by explicitely adding the gstreamer1.0-audio include
121         directories to the include path.
122
123         * TestWebKitAPI/PlatformGTK.cmake:
124         * TestWebKitAPI/PlatformWPE.cmake:
125
126 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
127
128         [GTK][WPE] Add enable-javascript-markup setting
129         https://bugs.webkit.org/show_bug.cgi?id=193439
130
131         Reviewed by Michael Catanzaro.
132
133         Add test cases to check the new setting.
134
135         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
136         (testWebKitSettings):
137         (testWebKitSettingsJavaScriptMarkup):
138         (beforeAll):
139
140 2019-02-10  Darin Adler  <darin@apple.com>
141
142         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
143         https://bugs.webkit.org/show_bug.cgi?id=194485
144
145         Reviewed by Daniel Bates.
146
147         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
148
149 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
150
151         Add more tests for clampTo<>()
152         https://bugs.webkit.org/show_bug.cgi?id=194462
153
154         Reviewed by Geoffrey Garen.
155
156         Darin suggested to test the very last floating point number
157         at the boundaries when truncating to integer.
158         I added test for max/min and max-1/min-1.
159
160         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
161         (TestWebKitAPI::TEST):
162
163 2019-02-09  Darin Adler  <darin@apple.com>
164
165         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
166         https://bugs.webkit.org/show_bug.cgi?id=194021
167
168         Reviewed by Geoffrey Garen.
169
170         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
171         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
172         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
173
174 2019-02-09  Zalan Bujtas  <zalan@apple.com>
175
176         [LFC][IFC] Add intrinsic width support for basic inline containers
177         https://bugs.webkit.org/show_bug.cgi?id=194473
178
179         Reviewed by Antti Koivisto.
180
181         Expand tests coverage (11 new tests -> 798)
182
183         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
184
185 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
186
187         Fix MiniBrowser's entitlements
188         https://bugs.webkit.org/show_bug.cgi?id=192431
189
190         Reviewed by Joseph Pecoraro.
191
192         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
193         files, making it impossible to load any extension.
194
195         * MiniBrowser/MiniBrowser.entitlements:
196
197 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
198
199         [Cocoa] Ask platform for generic font family mappings
200         https://bugs.webkit.org/show_bug.cgi?id=187723
201         <rdar://problem/41892438>
202
203         Reviewed by Brent Fulgham.
204
205         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
206
207         * DumpRenderTree/mac/DumpRenderTree.mm:
208         (allowedFontFamilySet):
209         * WebKitTestRunner/mac/TestControllerMac.mm:
210         (WTR::allowedFontFamilySet):
211
212 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
213
214         [GTK] Implement back/forward touchpad gesture
215         https://bugs.webkit.org/show_bug.cgi?id=193919
216
217         Reviewed by Michael Catanzaro.
218
219         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
220         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
221
222 2019-02-08  Alex Christensen  <achristensen@webkit.org>
223
224         Add SPI to use networking daemon instead of XPC service
225         https://bugs.webkit.org/show_bug.cgi?id=194427
226
227         Reviewed by Geoffrey Garen
228
229         * MiniBrowser/MiniBrowser.entitlements:
230
231 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
232
233         [ews-build] Ensure that every builder in config.json has short name
234         https://bugs.webkit.org/show_bug.cgi?id=194461
235
236         Reviewed by Lucas Forschler.
237
238         * BuildSlaveSupport/ews-build/loadConfig.py:
239         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
240
241 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
242
243         [ews-build] Add short name to config.json
244         https://bugs.webkit.org/show_bug.cgi?id=194456
245
246         Reviewed by Lucas Forschler.
247
248         * BuildSlaveSupport/ews-build/config.json: Added short name.
249         * BuildSlaveSupport/ews-build/loadConfig.py:
250         (loadBuilderConfig): Set the short name as the builder description.
251
252 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
253
254         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
255         https://bugs.webkit.org/show_bug.cgi?id=194418
256
257         Reviewed by Lucas Forschler.
258
259         Do not include errors trying when finding crashlogs at the end of
260         a run-webkit-tests run since we don't process those errors.
261
262         * Scripts/webkitpy/port/darwin.py:
263         (DarwinPort._look_for_all_crash_logs_in_log_dir):
264         * Scripts/webkitpy/port/ios_device.py:
265         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
266         * Scripts/webkitpy/port/watch_device.py:
267         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
268
269 2019-02-08  Beth Dakin  <bdakin@apple.com>
270
271         Add afterScreenUpdates to WKSnapshotConfiguration
272         https://bugs.webkit.org/show_bug.cgi?id=194362
273         -and corresponding-
274         <rdar://problem/40655528> Please add an "after screen updates" property to 
275         WKSnapshotConfiguration (to solve blank snapshots)
276
277         Reviewed by Tim Horton.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
280         (TEST):
281
282 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
283
284         clampTo(): do not convert the input to double when dealing with integers
285         https://bugs.webkit.org/show_bug.cgi?id=194263
286         <rdar://problem/47692312>
287
288         Reviewed by Darin Adler.
289
290         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
291         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
292         (TestWebKitAPI::testClampFloatingPointToInteger):
293         (TestWebKitAPI::testClampSameSignIntegers):
294         (TestWebKitAPI::testClampUnsignedToSigned):
295         (TestWebKitAPI::testClampSignedToUnsigned):
296
297 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
298
299         webkitpy: Respect --dedicated-simulators flag
300         https://bugs.webkit.org/show_bug.cgi?id=194416
301         <rdar://problem/47894722>
302
303         Reviewed by Lucas Forschler.
304
305         * Scripts/webkitpy/port/device_port.py:
306         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
307         available devices can be safely ignored.
308
309 2019-02-07  Keith Rollin  <krollin@apple.com>
310
311         Remove extra copy of 100x100-red.tga
312         https://bugs.webkit.org/show_bug.cgi?id=194371
313         <rdar://problem/47873465>
314
315         Reviewed by Said Abou-Hallawa.
316
317         In order to help it pass its tests, Bug 194190 added a second copy of
318         the file 100x100-red.tga. However, it turns out that this additional
319         file wasn't actually needed, and that that sole previous copy was
320         sufficient. At the same time, this second copy -- which was copied to
321         the same location in the build output as the first copy -- now caused
322         XCBuild to complain because there were two production rules for the
323         same output file. Address this by removing the newly-added extra copy.
324
325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
326         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
327
328 2019-02-07  Alex Christensen  <achristensen@webkit.org>
329
330         Deprecate WKBundlePageSetDefersLoading
331         https://bugs.webkit.org/show_bug.cgi?id=191394
332
333         Reviewed by Dean Jackson.
334
335         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
336         (WTR::TestRunner::setDefersLoading):
337
338 2019-02-07  Zalan Bujtas  <zalan@apple.com>
339
340         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
341         https://bugs.webkit.org/show_bug.cgi?id=194391
342
343         Reviewed by Antti Koivisto.
344
345         * LayoutReloaded/misc/LFC-passing-tests.txt:
346
347 2019-02-06  Keith Rollin  <krollin@apple.com>
348
349         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
350         https://bugs.webkit.org/show_bug.cgi?id=193975
351         <rdar://problem/47643306>
352
353         Reviewed by Tim Horton.
354
355         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
356         the Info.plist file into the bundle. This step is not necessary as the
357         implicit "bundle up all the build products into a framework" build
358         phase does this already. Having the Copy Bundle Resources phase do
359         this causes a conflict under XCBuild, which objects to two build
360         phases producing the same file (Info.plist). Address this by removing
361         Info.plist from the Copy Bundle Resources phase.
362
363         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
364
365 2019-02-06  Keith Rollin  <krollin@apple.com>
366
367         Really enable the automatic checking and regenerations of .xcfilelists during builds
368         https://bugs.webkit.org/show_bug.cgi?id=194357
369         <rdar://problem/47861231>
370
371         Reviewed by Chris Dumez.
372
373         Bug 194124 was supposed to enable the automatic checking and
374         regenerating of .xcfilelist files during the build. While related
375         changes were included in that patch, the change to actually enable the
376         operation somehow was omitted. This patch actually enables the
377         operation. The check-xcfilelist.sh scripts now check
378         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
379         from the checking.
380
381         * DumpRenderTree/Scripts/check-xcfilelists.sh:
382         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
383
384 2019-02-06  David Kilzer  <ddkilzer@apple.com>
385
386         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
387         <https://webkit.org/b/194286>
388         <rdar://problem/47815558>
389
390         Reviewed by Alexey Proskuryakov.
391
392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
393         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
394         WKRetainPtr<> to avoid leaking the WKDataRef.
395
396 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
397
398         Unreviewed, fix a typo
399
400         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
401
402 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
403
404         [GTK][WPE] force libpsl build to use ICU in jhbuild
405         https://bugs.webkit.org/show_bug.cgi?id=194288
406
407         Reviewed by Carlos Garcia Campos.
408
409         * gtk/jhbuild.modules:
410         Require ICU for libpsl build in jhbuild, like done in WPE.
411
412 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
413
414         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
415         https://bugs.webkit.org/show_bug.cgi?id=194209
416
417         Reviewed by Carlos Garcia Campos.
418
419         Enhance TestCookieManager to ensure this doesn't happen again.
420
421         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
422         (testCookieManagerPersistentStorage):
423         (beforeAll):
424
425 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
426
427         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
428         https://bugs.webkit.org/show_bug.cgi?id=194324
429
430         Reviewed by Andy Estes.
431
432         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
433         part of the name is already implicit, since this is in testing code in TestOptions.
434
435         * WebKitTestRunner/TestController.cpp:
436         (WTR::TestController::generateContextConfiguration const):
437         (WTR::updateTestOptionsFromTestHeader):
438         * WebKitTestRunner/TestOptions.h:
439         (WTR::TestOptions::hasSameInitializationOptions const):
440
441 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-build] Allow * as platform for builders and workers
444         https://bugs.webkit.org/show_bug.cgi?id=188533
445
446         Reviewed by Lucas Forschler.
447
448         * BuildSlaveSupport/ews-build/loadConfig.py:
449         (checkWorkersAndBuildersForConsistency):
450
451 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Add few bots to config.json
454         https://bugs.webkit.org/show_bug.cgi?id=194304
455
456         Reviewed by Lucas Forschler.
457
458         * BuildSlaveSupport/ews-build/config.json:
459
460 2019-02-05  Keith Rollin  <krollin@apple.com>
461
462         Enable the automatic checking and regenerations of .xcfilelists during builds
463         https://bugs.webkit.org/show_bug.cgi?id=194124
464         <rdar://problem/47721277>
465
466         Reviewed by Tim Horton.
467
468         Bug 193790 add a facility for checking -- during build time -- that
469         any needed .xcfilelist files are up-to-date and for updating them if
470         they are not. This facility was initially opt-in by setting
471         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
472         the process seemed robust. Its now time to enable this facility and
473         make it opt-out. If there is a need to disable this facility, set and
474         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
475         running `make` or `build-webkit`, or before running Xcode from the
476         command line.
477
478         Additionally, remove the step that generates a list of source files
479         going into the UnifiedSources build step. It's only necessarily to
480         specify Sources.txt and SourcesCocoa.txt as inputs.
481
482         * Scripts/generate-xcfilelists:
483
484 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
485
486         [GTK][WPE] force libpsl build to use ICU in jhbuild
487         https://bugs.webkit.org/show_bug.cgi?id=194288
488
489         Reviewed by Philippe Normand.
490
491         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
492         This can cause build failures if libidn is detected but libunistring is not available.
493
494         Make sure that ICU is used for runtime and builtin PSL data.
495
496         * gtk/jhbuild.modules:
497         * wpe/jhbuild.modules:
498
499 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
500
501         [ews-app] Modified timestamp should be updated on updating data
502         https://bugs.webkit.org/show_bug.cgi?id=194295
503
504         Reviewed by Lucas Forschler.
505
506         * BuildSlaveSupport/ews-app/ews/models/build.py:
507         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
508         * BuildSlaveSupport/ews-app/ews/models/step.py:
509
510 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
511
512         Unreviewed, rolling out r240742.
513
514         Causes crashes on iOS simulator.
515
516         Reverted changeset:
517
518         "[iOS] Keyups for non-modifier keys identified as "Dead" when
519         not focused in a content-editable element"
520         https://bugs.webkit.org/show_bug.cgi?id=192824
521         https://trac.webkit.org/changeset/240742
522
523 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
524
525         run-webkit-tests emits message "...running None" when running tests
526         https://bugs.webkit.org/show_bug.cgi?id=194133
527         <rdar://problem/47724738>
528
529         Reviewed by Lucas Forschler.
530
531         * Scripts/webkitpy/xcode/device_type.py:
532         (DeviceType.__str__): Use both version mapping tables and use just the variant
533         name if no version name is available.
534         * Scripts/webkitpy/xcode/device_type_unittest.py:
535         (DeviceTypeTest):
536         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
537         an associated named.
538
539 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
540
541         [WPE] require python3-setuptools for meson build in jhbuild
542         https://bugs.webkit.org/show_bug.cgi?id=194287
543
544         Reviewed by Philippe Normand.
545
546         python3-setuptools is needed to build meson in jhbuild.
547         It is already required by the GTK port.
548
549         * wpe/install-dependencies:
550
551 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
552
553         [ews-app] Add method to save BuilderMapping to database
554         https://bugs.webkit.org/show_bug.cgi?id=194264
555
556         Reviewed by Lucas Forschler.
557
558         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
559         (BuilderMapping.__str__):
560         (BuilderMapping):
561         (BuilderMapping.save_mapping):
562         (BuilderMapping.update_mapping):
563         (BuilderMapping.get_existing_mapping):
564         (BuilderMapping.is_valid_mapping):
565
566 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
567
568         [ews-app] Add timestamp fields for BuilderMappings
569         https://bugs.webkit.org/show_bug.cgi?id=194266
570
571         Reviewed by Lucas Forschler.
572
573         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
574         (BuilderMapping):
575
576 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
577
578         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
579         https://bugs.webkit.org/show_bug.cgi?id=174816
580
581         Reviewed by Michael Catanzaro.
582
583         Add tests for webkit_uri_for_display().
584
585         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
586         (testURIForDisplayUnaffected):
587         (testURIForDisplayAffected):
588         (beforeAll):
589         (afterAll):
590         * TestWebKitAPI/glib/CMakeLists.txt:
591
592 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
593
594         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
595         https://bugs.webkit.org/show_bug.cgi?id=194158
596         <rdar://problem/47737268>
597
598         Rubber-stamped by Aakash Jain.
599
600         * Scripts/webkitpy/port/device_port.py:
601         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
602
603 2019-02-04  Said Abou-Hallawa  <said@apple.com>
604
605         [CG] Enable setAdditionalSupportedImageTypes for WK1
606         https://bugs.webkit.org/show_bug.cgi?id=194190
607
608         Reviewed by Tim Horton.
609
610         Add a test similar to the one under WebKit Cocoa but make it create a
611         WebView instead of a WKWebView.
612
613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
614         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
615         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
616         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
617         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
618         (TestWebKitAPI::runTest):
619         (TestWebKitAPI::TEST):
620
621 2019-02-04  Zalan Bujtas  <zalan@apple.com>
622
623         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
624         https://bugs.webkit.org/show_bug.cgi?id=194168
625
626         Reviewed by Simon Fraser.
627
628         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
629
630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
631         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
632         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
633         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
634         (TEST):
635         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
636         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
637
638 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
639
640         REGRESSION (r237269): webkit-patch what-broke is broken 
641         https://bugs.webkit.org/show_bug.cgi?id=193025
642
643         Reviewed by Aakash Jain.
644
645         * Scripts/webkitpy/common/host.py:
646         (Host.buildbot):
647         (Host.bugzilla): Renamed to 'buildbot'.
648
649 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
650
651         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
652         https://bugs.webkit.org/show_bug.cgi?id=194207
653
654         Reviewed by Tim Horton.
655
656         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
657         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
658         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
659         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
660         start and delete forwards to remove the original attachment.
661
662         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
663         (TestWebKitAPI::TEST):
664
665 2019-02-04  Youenn Fablet  <youenn@apple.com>
666
667         Capture state should be managed consistently when doing process swapping
668         https://bugs.webkit.org/show_bug.cgi?id=194122
669         <rdar://problem/47609293>
670
671         Reviewed by Eric Carlson.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
674         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
675         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
676         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
679         (WTR::TestRunner::isDoingMediaCapture const):
680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
681         * WebKitTestRunner/TestController.cpp:
682         (WTR::TestController::isDoingMediaCapture const):
683         * WebKitTestRunner/TestController.h:
684         * WebKitTestRunner/TestInvocation.cpp:
685         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
686         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
687         (WTR::TestController::isDoingMediaCapture const):
688
689 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
690
691         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
692         https://bugs.webkit.org/show_bug.cgi?id=194142
693
694         Reviewed by Ross Kirsling.
695
696         There three 'separator' variables in TestController.cpp. Renamed
697         it 'pathSeparator', and unified them.
698
699         * WebKitTestRunner/TestController.cpp:
700         (WTR::TestController::generateContextConfiguration const):
701         (WTR::createTestURL):
702         (WTR::TestController::platformAdjustContext):
703
704 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
705
706         Make setNeedsLayout on the root more explicitly about triggering its side-effects
707         https://bugs.webkit.org/show_bug.cgi?id=194198
708
709         Reviewed by Antti Koivisto.
710
711         No need to set the banner heights on navigation now, since Page stores them.
712
713         * MiniBrowser/mac/WK2BrowserWindowController.m:
714         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
715
716 2019-02-03  John Wilander  <wilander@apple.com>
717
718         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
719         https://bugs.webkit.org/show_bug.cgi?id=194104
720         <rdar://problem/47649991>
721
722         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
723
724         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
725         (TestWebKitAPI::TEST):
726             Changed numeric types from unsigned short to uint32_t.
727
728 2019-02-02  David Kilzer  <ddkilzer@apple.com>
729
730         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
731         <https://webkit.org/b/194178>
732         <rdar://problem/47753473>
733
734         Reviewed by Alexey Proskuryakov.
735
736         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
737         (WTR::uninstallFakeHelvetica): Pass nullptr into
738         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
739
740 2019-02-02  Zalan Bujtas  <zalan@apple.com>
741
742         [LFC] Initialize ICB's style with fixed width/height.
743         https://bugs.webkit.org/show_bug.cgi?id=194188
744
745         Reviewed by Antti Koivisto.
746
747         * LayoutReloaded/misc/LFC-passing-tests.txt:
748
749 2019-02-02  Zalan Bujtas  <zalan@apple.com>
750
751         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
752         https://bugs.webkit.org/show_bug.cgi?id=194185
753
754         Reviewed by Antti Koivisto.
755
756         * LayoutReloaded/misc/LFC-passing-tests.txt:
757
758 2018-12-16  Darin Adler  <darin@apple.com>
759
760         Convert additional String::format clients to alternative approaches
761         https://bugs.webkit.org/show_bug.cgi?id=192746
762
763         Reviewed by Alexey Proskuryakov.
764
765         * WebKitTestRunner/TestController.cpp:
766         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
767         as an intermediate in code that ultimately constructs a WTF::String.
768         (WTR::userMediaOriginHash): Use makeString.
769         (WTR::TestController::didNavigateWithNavigationData): More of the same.
770         (WTR::TestController::didPerformClientRedirect): Ditto.
771         (WTR::TestController::didPerformServerRedirect): Ditto.
772         (WTR::TestController::didUpdateHistoryTitle): Ditto.
773
774 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
775
776         [ews-build] Add unit test to verify builder keys
777         https://bugs.webkit.org/show_bug.cgi?id=194152
778
779         Reviewed by Lucas Forschler.
780
781         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
782         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
783
784 2019-02-01  Zalan Bujtas  <zalan@apple.com>
785
786         [LFC] Expand tests coverage (12 new tests -> 787)
787
788         Unreviewed test gardening.
789
790         * LayoutReloaded/misc/LFC-passing-tests.txt:
791
792 2019-02-01  Zalan Bujtas  <zalan@apple.com>
793
794         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
795         https://bugs.webkit.org/show_bug.cgi?id=194163
796
797         Reviewed by Simon Fraser.
798
799         775
800
801         * LayoutReloaded/misc/LFC-passing-tests.txt:
802
803 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
804
805         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
806         https://bugs.webkit.org/show_bug.cgi?id=194140
807         <rdar://problem/47728098>
808
809         Reviewed by Tim Horton.
810
811         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
812         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
813         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
814
815         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
816         test to induce an IPC deadlock when presenting a modal alert during touch start.
817
818         * WebKitTestRunner/InjectedBundle/TestRunner.h:
819         * WebKitTestRunner/TestController.cpp:
820         (WTR::runJavaScriptAlert):
821
822         Add a client callback function for running JavaScript alerts.
823
824         (WTR::TestController::createOtherPage):
825         (WTR::TestController::generateContextConfiguration const):
826
827         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
828         the fix in this patch.
829
830         (WTR::TestController::createWebViewWithOptions):
831
832         Plumb TestOptions to generateContextConfiguration.
833
834         (WTR::TestController::resetPreferencesToConsistentValues):
835         (WTR::TestController::resetStateToConsistentValues):
836         (WTR::updateTestOptionsFromTestHeader):
837         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
838         (WTR::TestController::handleJavaScriptAlert):
839         * WebKitTestRunner/TestController.h:
840         * WebKitTestRunner/TestInvocation.cpp:
841         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
842         * WebKitTestRunner/TestOptions.h:
843         (WTR::TestOptions::hasSameInitializationOptions const):
844
845 2019-02-01  Chris Dumez  <cdumez@apple.com>
846
847         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
848         https://bugs.webkit.org/show_bug.cgi?id=193740
849         <rdar://problem/47527267>
850
851         Reviewed by Alex Christensen.
852
853         Add API test coverage.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
856
857 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
858
859         [ews-app] Add display name field to BuilderMapping model
860         https://bugs.webkit.org/show_bug.cgi?id=194153
861
862         Reviewed by Lucas Forschler.
863
864         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
865         (BuilderMapping):
866
867 2019-02-01  Youenn Fablet  <youenn@apple.com>
868
869         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
870         https://bugs.webkit.org/show_bug.cgi?id=194155
871
872         Reviewed by Eric Carlson.
873
874         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
875         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
876         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
877
878 2019-02-01  Zalan Bujtas  <zalan@apple.com>
879
880         [LFC] Adjust replaced element's intrinsic ratio
881         https://bugs.webkit.org/show_bug.cgi?id=194154
882
883         Reviewed by Antti Koivisto.
884
885         761
886
887         * LayoutReloaded/misc/LFC-passing-tests.txt:
888
889 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
890
891         [WPE] Show test results in minibrowser
892         https://bugs.webkit.org/show_bug.cgi?id=194150
893
894         Reviewed by Žan Doberšek.
895
896         * Scripts/webkitpy/port/wpe.py:
897         (WPEPort.show_results_html_file):
898
899 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
900
901         [WPE] MiniBrowser: add ky bindings for back/forward navigation
902         https://bugs.webkit.org/show_bug.cgi?id=194151
903
904         Reviewed by Žan Doberšek.
905
906         ALT + <- go back
907         ALT + -> go forward
908
909         * MiniBrowser/wpe/main.cpp:
910         (main):
911
912 2019-02-01  Zalan Bujtas  <zalan@apple.com>
913
914         [LFC] Set intrinsic size on Layout::Replaced
915         https://bugs.webkit.org/show_bug.cgi?id=194139
916
917         Reviewed by Antti Koivisto.
918
919         744
920
921         * LayoutReloaded/misc/LFC-passing-tests.txt:
922
923 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
924
925         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
926         https://bugs.webkit.org/show_bug.cgi?id=194146
927
928         Reviewed by Xabier Rodriguez-Calvar.
929
930         It allows to open relative paths.
931
932         * MiniBrowser/wpe/main.cpp:
933         (main):
934
935 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
936
937         Update flakiness dashboard configuration after recent queue changes
938         https://bugs.webkit.org/show_bug.cgi?id=194127
939
940         Rubber-stamped by Aakash Jain.
941
942         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
943
944         * TestResultServer/static-dashboards/builders.jsonp:
945
946 2019-01-31  Youenn Fablet  <youenn@apple.com>
947
948         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
949         https://bugs.webkit.org/show_bug.cgi?id=194106
950         <rdar://problem/47676333>
951
952         Reviewed by Ryosuke Niwa.
953
954         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
955         (TestWebKitAPI::didFinishNavigation):
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
958
959 2019-01-31  Chris Dumez  <cdumez@apple.com>
960
961         Page zoom level is lost after a process swap or a crash
962         https://bugs.webkit.org/show_bug.cgi?id=194105
963         <rdar://problem/47610781>
964
965         Reviewed by Alex Christensen.
966
967         Add API test coverage.
968
969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
970         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
971
972 2019-01-31  Alex Christensen  <achristensen@webkit.org>
973
974         Revert r238819 which is unneeded and caused a performance regression.
975         https://bugs.webkit.org/show_bug.cgi?id=192272
976         <rdar://problem/46664625>
977
978         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
979         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
980         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
981
982 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
983
984         Formalize WebKitAdditions mechanism of LoadOptimizer
985         https://bugs.webkit.org/show_bug.cgi?id=193886
986         <rdar://problem/47696809>
987
988         Reviewed by Brent Fulgham.
989
990         * MiniBrowser/MiniBrowser.entitlements:
991         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
992
993 2019-01-31  Zalan Bujtas  <zalan@apple.com>
994
995         [LFC] Margin before/after/start/end initial value is 0 and not auto.
996         https://bugs.webkit.org/show_bug.cgi?id=194090
997
998         Reviewed by Antti Koivisto.
999
1000         * LayoutReloaded/misc/LFC-passing-tests.txt:
1001
1002 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1003
1004         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1005         https://bugs.webkit.org/show_bug.cgi?id=194074
1006
1007         Reviewed by Antti Koivisto.
1008
1009         * LayoutReloaded/misc/LFC-passing-tests.txt:
1010
1011 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1012
1013         [LFC][BFC] Add support for block level replaced box.
1014         https://bugs.webkit.org/show_bug.cgi?id=194071
1015
1016         Reviewed by Antti Koivisto.
1017
1018         * LayoutReloaded/misc/LFC-passing-tests.txt:
1019
1020 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1021
1022         Fix WebKitTestRunner's testPath with Windows full paths
1023         https://bugs.webkit.org/show_bug.cgi?id=194012
1024
1025         Reviewed by Alex Christensen.
1026
1027         updateTestOptionsFromTestHeader failed to open test files because
1028         testPath returned wrong file paths. It returned a path "/C:/..."
1029         if a URL "file:///C:/..." was given.
1030
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1033
1034 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1035
1036         [WPE] Bump font related dependencies to match the GTK+ port
1037         https://bugs.webkit.org/show_bug.cgi?id=194017
1038
1039         Reviewed by Žan Doberšek.
1040
1041         * wpe/jhbuild.modules:
1042         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1043         * wpe/patches/icudata-stdlibs.patch: Added.
1044
1045 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1046
1047         Enable swipe tests on iOS
1048         https://bugs.webkit.org/show_bug.cgi?id=194076
1049
1050         Reviewed by Geoffrey Garen.
1051
1052         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1053         it causes a debug assertion failure in runUIScript.
1054
1055         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1056         (WTR::UIScriptController::beginBackSwipe):
1057         (WTR::UIScriptController::completeBackSwipe):
1058
1059 2019-01-30  Keith Rollin  <krollin@apple.com>
1060
1061         Use correct printf format specifier
1062         https://bugs.webkit.org/show_bug.cgi?id=194062
1063         <rdar://problem/47686167>
1064
1065         Reviewed by Alexey Proskuryakov.
1066
1067         LayoutTestSpellChecker.mm is trying to format a variable of type
1068         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1069         actually an unsigned long long. Fix this by formatting with %llu.
1070
1071         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1072         (-[LayoutTestTextCheckingResult description]):
1073
1074 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1075
1076         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1077         https://bugs.webkit.org/show_bug.cgi?id=193979
1078
1079         Reviewed by Wenson Hsieh.
1080
1081         Fix the test for iOS. Make the test work with iOS UA string.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1084
1085 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1086
1087         Replace High Sierra LLINT CLoop bot due to hardware failure
1088         https://bugs.webkit.org/show_bug.cgi?id=194066
1089
1090         Reviewed by Aakash Jain.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/config.json:
1093
1094 2019-01-30  Keith Rollin  <krollin@apple.com>
1095
1096         [NSDragItem init] is unavailable
1097         https://bugs.webkit.org/show_bug.cgi?id=194059
1098         <rdar://problem/47685715>
1099
1100         Reviewed by Wenson Hsieh.
1101
1102         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1103         DumpRenderTree and TestWebKitAPI, which both try to create an
1104         NSDragItem in a manner that invokes this method. Address this by using
1105         -initWithPasteboardWriter instead.
1106
1107         Note that the parameter passed to initWithPasteboardWriter is likely
1108         incorrect. In both cases, the object passed does not conform to
1109         NSPasteboardWriting. However, with this fix, we're no worse off than
1110         before, and can now perform builds with newer compilers and SDKs until
1111         a real fix can be crafted. That work is tracked in
1112         https://bugs.webkit.org/show_bug.cgi?id=194060
1113
1114         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1115         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1116         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1117         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1118
1119 2019-01-30  Daniel Bates  <dabates@apple.com>
1120
1121         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1122         https://bugs.webkit.org/show_bug.cgi?id=192824
1123         <rdar://problem/47100332>
1124
1125         Reviewed by Wenson Hsieh.
1126
1127         Fix a bug where the wrong usage code was used for F13 thru F24.
1128
1129         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1130         (keyCodeForDOMFunctionKey):
1131
1132 2019-01-30  Chris Dumez  <cdumez@apple.com>
1133
1134         Regression(PSON) Load hang can occur on history navigation
1135         https://bugs.webkit.org/show_bug.cgi?id=194030
1136         <rdar://problem/47656939>
1137
1138         Reviewed by Antti Koivisto.
1139
1140         Add API test coverage.
1141
1142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1143
1144 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1145
1146         [LFC] Expand tests coverage.
1147
1148         Unreviewed test gardening.
1149
1150         * LayoutReloaded/misc/LFC-passing-tests.txt:
1151
1152 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1153
1154         [Flatpak] Add openjpeg support
1155         https://bugs.webkit.org/show_bug.cgi?id=194019
1156
1157         Reviewed by Michael Catanzaro.
1158
1159         * flatpak/org.webkit.CommonModules.yaml:
1160
1161 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1162
1163         Unreviewed, rolling out r240708.
1164         https://bugs.webkit.org/show_bug.cgi?id=194022
1165
1166         It broke WPE build (Requested by KaL on #webkit).
1167
1168         Reverted changeset:
1169
1170         "[WPE] Bump font related dependencies to match the GTK+ port"
1171         https://bugs.webkit.org/show_bug.cgi?id=194017
1172         https://trac.webkit.org/changeset/240708
1173
1174 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1175
1176         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1177         https://bugs.webkit.org/show_bug.cgi?id=194001
1178
1179         Reviewed by Antti Koivisto.
1180
1181         * LayoutReloaded/misc/LFC-passing-tests.txt:
1182
1183 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1184
1185         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1186         https://bugs.webkit.org/show_bug.cgi?id=194020
1187
1188         Reviewed by Antti Koivisto.
1189
1190         * LayoutReloaded/misc/LFC-passing-tests.txt:
1191
1192 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1193
1194         AX: Support color well on iOS
1195         https://bugs.webkit.org/show_bug.cgi?id=194010
1196
1197         Reviewed by Joanmarie Diggs.
1198
1199         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1200         (WTR::AccessibilityUIElement::stringAttributeValue):
1201
1202 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1203
1204         [WPE] Bump font related dependencies to match the GTK+ port
1205         https://bugs.webkit.org/show_bug.cgi?id=194017
1206
1207         Reviewed by Žan Doberšek.
1208
1209         * wpe/jhbuild.modules:
1210         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1211         * wpe/patches/icudata-stdlibs.patch: Added.
1212
1213 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1214
1215         [Mac] Update window scale API usage
1216         https://bugs.webkit.org/show_bug.cgi?id=193991
1217         rdar://problem/47614795
1218
1219         Reviewed by Tim Horton.
1220
1221         * DumpRenderTree/mac/DumpRenderTree.mm:
1222         (changeWindowScaleIfNeeded):
1223         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1224         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1225         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1226
1227 2019-01-29  Chris Dumez  <cdumez@apple.com>
1228
1229         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1230         https://bugs.webkit.org/show_bug.cgi?id=193977
1231         <rdar://problem/47643716>
1232
1233         Reviewed by Geoff Garen.
1234
1235         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1236         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1237         to the previous provisional committing *before* we make the last load. 
1238
1239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1240
1241 2019-01-29  Youenn Fablet  <youenn@apple.com>
1242
1243         Adopt new SPI to evaluate server certificate trust
1244         https://bugs.webkit.org/show_bug.cgi?id=193355
1245
1246         Reviewed by Alex Christensen.
1247
1248         Add infrastructure to handle HTTPS server trust evaluation testing.
1249
1250         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1252         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1253         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1254         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1256         * WebKitTestRunner/TestController.cpp:
1257         (WTR::TestController::resetPreferencesToConsistentValues):
1258         (WTR::TestController::didReceiveAuthenticationChallenge):
1259         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1260         * WebKitTestRunner/TestController.h:
1261         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1262         * WebKitTestRunner/TestInvocation.cpp:
1263         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1264         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1265         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1266
1267 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-build] Add build step to print bot Configuration
1270         https://bugs.webkit.org/show_bug.cgi?id=193887
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-build/steps.py:
1275         (PrintConfiguration): Build step to print configuration.
1276         * BuildSlaveSupport/ews-build/factories.py:
1277
1278 2019-01-29  Chris Dumez  <cdumez@apple.com>
1279
1280         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1281         https://bugs.webkit.org/show_bug.cgi?id=193967
1282         <rdar://problem/47635348>
1283
1284         Reviewed by Alex Christensen.
1285
1286         Add API test coverage.
1287
1288         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1289         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1290
1291 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1292
1293         [ews-app] Handle incoming results data
1294         https://bugs.webkit.org/show_bug.cgi?id=193973
1295
1296         Reviewed by Lucas Forschler.
1297
1298         * BuildSlaveSupport/ews-app/ews/views/results.py:
1299
1300 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-app] Make the results url generic
1303         https://bugs.webkit.org/show_bug.cgi?id=193928
1304
1305         Reviewed by Lucas Forschler.
1306
1307         * BuildSlaveSupport/ews-app/ews/urls.py:
1308
1309 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-build] Configure buildbot to send events to ews-app
1312         https://bugs.webkit.org/show_bug.cgi?id=193968
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-build/events.py: Added.
1317         * BuildSlaveSupport/ews-build/master.cfg:
1318
1319 2019-01-29  Keith Rollin  <krollin@apple.com>
1320
1321         Add .xcfilelists to Run Script build phases
1322         https://bugs.webkit.org/show_bug.cgi?id=193792
1323         <rdar://problem/47201785>
1324
1325         Reviewed by Alex Christensen.
1326
1327         As part of supporting XCBuild, update the necessary Run Script build
1328         phases in their Xcode projects to refer to their associated
1329         .xcfilelist files.
1330
1331         Note that the addition of these files bumps the Xcode project version
1332         number to something that's Xcode 10 compatible. This change means that
1333         older versions of the Xcode IDE can't read these projects. Nor can it
1334         fully load workspaces that refer to these projects (the updated
1335         projects are shown as non-expandable placeholders). `xcodebuild` can
1336         still build these projects; it's just that the IDE can't open them.
1337
1338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1339         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1340
1341 2019-01-29  John Wilander  <wilander@apple.com>
1342
1343         Add data abstraction and validation for Ad Click Attribution
1344         https://bugs.webkit.org/show_bug.cgi?id=193916
1345         <rdar://problem/47603481>
1346
1347         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1348
1349         Ad click attribution has two steps. First, the storage of an ad
1350         campaign ID for a click that takes the user to a destination
1351         site. Second, a conversion on the destination site that can be
1352         attributed to the ad click.
1353
1354         This patch adds a class that represents a request for ad click
1355         attribution. Validation makes sure that the bits of entropy
1356         reported through this mechanism is limited.
1357
1358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1359         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1360         (TestWebKitAPI::TEST):
1361
1362 2019-01-29  Chris Dumez  <cdumez@apple.com>
1363
1364         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1365         https://bugs.webkit.org/show_bug.cgi?id=193932
1366         <rdar://problem/47598947>
1367
1368         Reviewed by Brady Eidson.
1369
1370         Add API test coverage.
1371
1372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1373
1374 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1375
1376         Adding new passing LFC tests.
1377
1378         Unreviewed test gardening.
1379
1380         * LayoutReloaded/misc/LFC-passing-tests.txt:
1381
1382 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1383
1384         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1385         https://bugs.webkit.org/show_bug.cgi?id=193964
1386
1387         Reviewed by Antti Koivisto.
1388
1389         * LayoutReloaded/misc/LFC-passing-tests.txt:
1390
1391 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1392
1393         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1394         https://bugs.webkit.org/show_bug.cgi?id=193954
1395
1396         Reviewed by Antti Koivisto.
1397
1398         * LayoutReloaded/misc/LFC-passing-tests.txt:
1399
1400 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1401
1402         WebDriver: add support for running subtests
1403         https://bugs.webkit.org/show_bug.cgi?id=193904
1404
1405         Reviewed by Michael Catanzaro.
1406
1407         pytest already supports it by passing test.py::subtest, so we can do the same.
1408
1409         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1410         (get_item_name): Made this global.
1411         (CollectRecorder.__init__): Receive the parameter to ignore.
1412         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1413         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1414         (collect): Add parameter to ignore.
1415         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1416         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1417         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1418         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1419         (WebDriverTestRunnerSelenium.run): Ditto.
1420         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1421         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1422         (WebDriverTestRunnerW3C.run): Ditto.
1423
1424 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1425
1426         User agent string override for navigator.userAgent should be site specific quirks
1427         https://bugs.webkit.org/show_bug.cgi?id=193950
1428
1429         Reviewed by Brent Fulgham.
1430
1431         Updated per the _WKWebsitePolicies rename.
1432
1433         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1434         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1435
1436 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1437
1438         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1439         https://bugs.webkit.org/show_bug.cgi?id=193941
1440
1441         Reviewed by Alex Christensen.
1442
1443         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1444         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1445         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1446         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1447         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1448         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1449         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1450         * TestWebKitAPI/Tests/WTF/Time.cpp:
1451         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1452         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1453         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1454         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1455
1456 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1457
1458         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1459
1460         * Scripts/webkitpy/common/config/contributors.json:
1461
1462 2019-01-28  Andy Estes  <aestes@apple.com>
1463
1464         [watchOS] Enable Parental Controls content filtering
1465         https://bugs.webkit.org/show_bug.cgi?id=193939
1466         <rdar://problem/46641912>
1467
1468         Reviewed by Ryosuke Niwa.
1469
1470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1471
1472 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1473
1474         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1475         <https://webkit.org/b/193884>
1476
1477         Reviewed by Jiewen Tan.
1478
1479         * Scripts/webkitpy/style/checkers/cpp.py:
1480         (check_language): Add LocalAuthentication to
1481         `frameworks_with_soft_links`.
1482
1483 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1484
1485         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1486         https://bugs.webkit.org/show_bug.cgi?id=193891
1487
1488         Reviewed by Ross Kirsling.
1489
1490         There were three problems in window sizes of WebView and the host window.
1491         1. The sizes of pixel image output were incorrect.
1492         2. The host window is going to appear after window.resize was invoked.
1493         3. window.resize resized only the host window, not WebView.
1494
1495         This change solves them with a following approach.
1496         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1497         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1498            as well as DumpRenderTree in order to match the client area and the window area.
1499         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1500         d. PlatformWebView::setWindowFrame changes both window sizes.
1501         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1502
1503         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1504         (WTR::PlatformWebView::PlatformWebView): Create the host window
1505         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1506         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1507         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1508
1509 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1510
1511         [ews-app] Add method to save Step data to database
1512         https://bugs.webkit.org/show_bug.cgi?id=193890
1513
1514         Reviewed by Lucas Forschler.
1515
1516         * BuildSlaveSupport/ews-app/ews/models/step.py:
1517         (Step.save_step): Method to save step data.
1518         (Step.update_step): Method to update step data.
1519         (Step.get_existing_step): Method to fetch existing step from database.
1520         (Step.is_valid_result): Method to validate valid step result.
1521
1522 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1523
1524         [ews-app] Add method to save Build data to database
1525         https://bugs.webkit.org/show_bug.cgi?id=193735
1526
1527         Reviewed by Lucas Forschler.
1528
1529         * BuildSlaveSupport/ews-app/ews/models/build.py:
1530         (Build.save_build): Method to save build information to database.
1531         (Build.get_existing_build): Method to fetch existing build from database.
1532         (Build.is_valid_result): Method to validate build result.
1533         * BuildSlaveSupport/ews-app/ews/common/util.py:
1534         (is_valid_int_id): Method to validate valid id.
1535
1536 2019-01-28  Chris Dumez  <cdumez@apple.com>
1537
1538         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1539         https://bugs.webkit.org/show_bug.cgi?id=193915
1540         <rdar://problem/47560907>
1541
1542         Reviewed by Alex Christensen.
1543
1544         Add API test coverage.
1545
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1547
1548 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1549
1550         [ews-app] Rename id variables
1551         https://bugs.webkit.org/show_bug.cgi?id=193883
1552
1553         Reviewed by Lucas Forschler.
1554
1555         * BuildSlaveSupport/ews-app/ews/models/build.py:
1556         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1557         * BuildSlaveSupport/ews-app/ews/models/step.py:
1558         * BuildSlaveSupport/ews-app/ews/urls.py:
1559         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1560         * BuildSlaveSupport/ews-app/ews/views/results.py:
1561         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1562
1563 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1564
1565         [ews-app] Allow certain fields to be empty
1566         https://bugs.webkit.org/show_bug.cgi?id=193892
1567
1568         Reviewed by Lucas Forschler.
1569
1570         * BuildSlaveSupport/ews-app/ews/models/build.py:
1571         * BuildSlaveSupport/ews-app/ews/models/step.py:
1572
1573 2019-01-28  Rob Buis  <rbuis@igalia.com>
1574
1575         Update MIME type parser
1576         https://bugs.webkit.org/show_bug.cgi?id=180526
1577
1578         Reviewed by Frédéric Wang.
1579
1580         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1581         (TestWebKitAPI::TEST):
1582
1583 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1584
1585         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1586         https://bugs.webkit.org/show_bug.cgi?id=193896
1587
1588         Reviewed by Antti Koivisto.
1589
1590         * LayoutReloaded/misc/LFC-passing-tests.txt:
1591
1592 2018-12-15  Darin Adler  <darin@apple.com>
1593
1594         Replace many uses of String::format with more type-safe alternatives
1595         https://bugs.webkit.org/show_bug.cgi?id=192742
1596
1597         Reviewed by Mark Lam.
1598
1599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1600         (WTR::cacheTestRunnerCallback): Use makeString.
1601         * WebKitTestRunner/TestController.cpp:
1602         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1603         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1604
1605 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1606
1607         Use a load optimizer for some sites
1608         https://bugs.webkit.org/show_bug.cgi?id=193881
1609         <rdar://problem/46325455>
1610
1611         Reviewed by Brent Fulgham.
1612
1613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1614         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1615
1616 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1617
1618         AX: Introduce a static accessibility tree
1619         https://bugs.webkit.org/show_bug.cgi?id=193348
1620         <rdar://problem/47203295>
1621
1622         Reviewed by Ryosuke Niwa.
1623
1624         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1625
1626 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1627
1628         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1629         https://bugs.webkit.org/show_bug.cgi?id=193867
1630
1631         Reviewed by Antti Koivisto.
1632
1633         * LayoutReloaded/misc/LFC-passing-tests.txt:
1634
1635 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1636
1637         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1638         https://bugs.webkit.org/show_bug.cgi?id=193865
1639
1640         Reviewed by Antti Koivisto.
1641
1642         * LayoutReloaded/misc/LFC-passing-tests.txt:
1643
1644 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         Need a mechanism to override navigator.userAgent
1647         https://bugs.webkit.org/show_bug.cgi?id=193762
1648         <rdar://problem/47504939>
1649
1650         Reviewed by Brent Fulgham.
1651
1652         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1653
1654         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1655         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1656         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1657
1658 2019-01-25  Dean Jackson  <dino@apple.com>
1659
1660         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1661         https://bugs.webkit.org/show_bug.cgi?id=193831
1662         <rdar://problem/47399263>
1663
1664         Reviewed by Chris Dumez.
1665
1666         Two new tests that exercise cross-origin and same-origin System
1667         Previews.
1668
1669         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1670
1671 2019-01-25  Keith Rollin  <krollin@apple.com>
1672
1673         Update Xcode projects with "Check .xcfilelists" build phase
1674         https://bugs.webkit.org/show_bug.cgi?id=193790
1675         <rdar://problem/47201374>
1676
1677         Reviewed by Alex Christensen.
1678
1679         Support for XCBuild includes specifying inputs and outputs to various
1680         Run Script build phases. These inputs and outputs are specified as
1681         .xcfilelist files. Once created, these .xcfilelist files need to be
1682         kept up-to-date. In order to check that they are up-to-date or not,
1683         add an Xcode build step that invokes an external script that performs
1684         the checking. If the .xcfilelists are found to be out-of-date, update
1685         them, halt the build, and instruct the developer to restart the build
1686         with up-to-date files.
1687
1688         At this time, the checking and regenerating is performed only if the
1689         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1690         who want to use this facility can set this variable and test out the
1691         checking/regenerating. Once it seems like there are no egregious
1692         issues that upset a developer's workflow, we'll unconditionally enable
1693         this facility.
1694
1695         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1696         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1697         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1698         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1699
1700 2019-01-25  Keith Rollin  <krollin@apple.com>
1701
1702         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1703         https://bugs.webkit.org/show_bug.cgi?id=193781
1704         <rdar://problem/47201153>
1705
1706         Reviewed by Alex Christensen.
1707
1708         Part of generating the .xcfilelists used as part of adopting XCBuild
1709         includes running `make DerivedSources.make` from a standalone script.
1710         It’s important for this invocation to have the same environment as
1711         when the actual build invokes `make DerivedSources.make`. If the
1712         environments are different, then the two invocations will provide
1713         different results. In order to get the same environment in the
1714         standalone script, have the script launch xcodebuild targeting the
1715         "Apply Configuration to XCFileLists" build target, which will then
1716         re-invoke our standalone script. The script is now running again, this
1717         time in an environment with all workspace, project, target, xcconfig
1718         and other environment variables established.
1719
1720         The "Apply Configuration to XCFileLists" build target accomplishes
1721         this task via a small embedded shell script that consists only of:
1722
1723             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1724
1725         The process that invokes "Apply Configuration to XCFileLists" first
1726         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1727         evaluated and exports it into the shell environment. When xcodebuild
1728         is invoked, it inherits the value of this variable and can `eval` the
1729         contents of that variable. Our external standalone script can then set
1730         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1731         of command-line parameters needed to restart itself in the appropriate
1732         state.
1733
1734         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1735         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1736
1737 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1738
1739         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1740         https://bugs.webkit.org/show_bug.cgi?id=193802
1741         <rdar://problem/46010580>
1742
1743         Reviewed by Andy Estes.
1744
1745         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1746         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1747         (TEST):
1748
1749 2019-01-25  Daniel Bates  <dabates@apple.com>
1750
1751         [iOS] uiController.keyDown() does not translate Control modified key
1752         https://bugs.webkit.org/show_bug.cgi?id=192898
1753
1754         Reviewed by Wenson Hsieh.
1755
1756         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1757         key translation, as applicable. Among other cases, key translation occurs when performing
1758         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1759         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1760         human pressing down and releasing key(s) using a hardware keyboard.
1761
1762         * WebKitTestRunner/ios/HIDEventGenerator.h:
1763         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1764         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1765
1766         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1767         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1768         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1769         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1770         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1771         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1772         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1773         (-[HIDEventGenerator longPress:completionBlock:]):
1774         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1775         Update code for above renaming.
1776
1777         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1778         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1779
1780         (-[HIDEventGenerator keyDown:]): Added.
1781         (-[HIDEventGenerator keyUp:]): Added.
1782         (-[HIDEventGenerator keyPress:completionBlock:]):
1783         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1784         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1785         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1786         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1787         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1788         (WTR::parseModifier): Deleted.
1789
1790 2019-01-25  Keith Rollin  <krollin@apple.com>
1791
1792         Complete the implementation of generate-xcfilelists
1793         https://bugs.webkit.org/show_bug.cgi?id=193782
1794
1795         Reviewed by Alex Christensen.
1796
1797         A preliminary version of generate-xcfilelists was added in r238008.
1798         This patch updates that script in order to:
1799
1800         - Support checking of .xcfilelists
1801         - Perform better execution of `make DerivedSources.make` by
1802           relaunching generate-xcfilelists under xcodebuild
1803         - Support incremental generation and checking of .xcfilelists
1804         - Support supplementary .xcfilelists files from WebKitAdditions
1805         - Support being wrapped by parallel version of generate-xcfilelists in
1806           Internal that adds support for (re)generating WebKit projects in
1807           that repo.
1808         - Support builds that have been performed in WebKitBuild as well as
1809           ~/Library/Developer/code/DerivedData
1810         - Increase robustness and debugging facilities.
1811
1812         * Scripts/generate-xcfilelists:
1813
1814 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1815
1816         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1817         https://bugs.webkit.org/show_bug.cgi?id=193297
1818         <rdar://problem/47158841>
1819
1820         Unreviewed test case fix.
1821
1822         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1823         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1824
1825         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1826         (TEST):
1827
1828 2019-01-25  Keith Rollin  <krollin@apple.com>
1829
1830         Update existing .xcfilelists
1831         https://bugs.webkit.org/show_bug.cgi?id=193791
1832         <rdar://problem/47201706>
1833
1834         Reviewed by Alex Christensen.
1835
1836         Many .xcfilelist files were added in r238824 in order to support
1837         XCBuild. Update these with recent changes to the set of build files
1838         and with the current generate-xcfilelist script.
1839
1840         * DumpRenderTree/DerivedSources-input.xcfilelist:
1841         * DumpRenderTree/DerivedSources-output.xcfilelist:
1842         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1843         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1844
1845 2019-01-25  Keith Rollin  <krollin@apple.com>
1846
1847         Fix missing dependencies in extract-dependencies-from-makefile
1848         https://bugs.webkit.org/show_bug.cgi?id=193783
1849         <rdar://problem/47201571>
1850
1851         Reviewed by Alex Christensen.
1852
1853         The extract-dependencies-from-makefile script generates .xcfilelists
1854         for XCBuild by invoking a makefile in --debug mode, parsing the
1855         dependency information in the output, and extracting information
1856         regarding targets and dependents. However, the way `make` emits this
1857         dependency information is not rigorous, and so we need to determine
1858         what lines to look for and parse by trial and error. This approach
1859         didn't coriginally atch all the information we needed to collect, so
1860         update the script to look for the additional lines we now know to look
1861         for.
1862
1863         * Scripts/extract-dependencies-from-makefile:
1864         (Parser):
1865         (Parser.addTarget):
1866         (Parser.addPrereq):
1867         (Parser.doParse):
1868
1869 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1870
1871         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1872         https://bugs.webkit.org/show_bug.cgi?id=193297
1873         <rdar://problem/47158841>
1874
1875         Reviewed by Alex Christensen.
1876
1877         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1878             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1880         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1881         activating the message used to trigger the callback when it is set.
1882
1883 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1884
1885         WKWebView.goBack should reload if there is a safe browsing warning
1886         https://bugs.webkit.org/show_bug.cgi?id=193805
1887         <rdar://problem/46908216>
1888
1889         Reviewed by Geoff Garen.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1892         (+[Simple3LookupContext sharedLookupContext]):
1893         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1894         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1895         (TEST):
1896
1897 2019-01-25  Chris Dumez  <cdumez@apple.com>
1898
1899         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1900         https://bugs.webkit.org/show_bug.cgi?id=193788
1901         <rdar://problem/47531231>
1902
1903         Reviewed by Alex Christensen.
1904
1905         Add API test coverage.
1906
1907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1908         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1909
1910 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1911
1912         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1913         https://bugs.webkit.org/show_bug.cgi?id=193771
1914
1915         Unreviewed infrastructure fix.
1916
1917         * Scripts/webkitpy/port/darwin.py:
1918         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1919
1920 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1921
1922         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1923
1924 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1925
1926         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1927
1928         * Scripts/webkitpy/common/config/contributors.json:
1929
1930 2019-01-25  Chris Dumez  <cdumez@apple.com>
1931
1932         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1933         https://bugs.webkit.org/show_bug.cgi?id=193779
1934         <rdar://problem/46170903>
1935
1936         Reviewed by Antti Koivisto.
1937
1938         Add API test that quickly navigates forward to a previous process without waiting for it to
1939         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1940         the process' previous page when reconnecting the it for the forward navigation.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1943
1944 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1945
1946         Need a way for JavaScript (or bundle) code to participate in undo
1947         https://bugs.webkit.org/show_bug.cgi?id=190009
1948         <rdar://problem/44807048>
1949
1950         Reviewed by Ryosuke Niwa.
1951
1952         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1953         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1954
1955         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1956         (WTR::UIScriptController::lastUndoLabel const):
1957         (WTR::UIScriptController::firstRedoLabel const):
1958         (WTR::UIScriptController::platformUndoManager const):
1959         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1960         (WTR::UIScriptController::lastUndoLabel const):
1961         (WTR::UIScriptController::firstRedoLabel const):
1962         (WTR::UIScriptController::platformUndoManager const):
1963         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1964         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1965         (WTR::UIScriptController::lastUndoLabel const):
1966         (WTR::UIScriptController::firstRedoLabel const):
1967         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1968         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1969         (WTR::UIScriptController::lastUndoLabel const):
1970         (WTR::UIScriptController::firstRedoLabel const):
1971         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1972         (WTR::UIScriptController::platformUndoManager const):
1973         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1974         (WTR::UIScriptController::platformUndoManager const):
1975
1976 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1977
1978         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1979         https://bugs.webkit.org/show_bug.cgi?id=193824
1980
1981         Reviewed by Antti Koivisto.
1982
1983         * LayoutReloaded/misc/LFC-passing-tests.txt:
1984
1985 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1986
1987         Update macOS JSC bot configurations
1988         https://bugs.webkit.org/show_bug.cgi?id=193739
1989
1990         Reviewed by Alexey Proskuryakov.
1991
1992         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1994         (BubbleQueueServer): Move JSC EWS to Mojave section.
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1996         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1997         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1998
1999 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2000
2001         [Win][WebKitTestRunner] Implement EventSenderProxy
2002         https://bugs.webkit.org/show_bug.cgi?id=193755
2003
2004         Reviewed by Don Olmstead.
2005
2006         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2007         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2008         (WTR::EventSenderProxy::dispatchMessage):
2009         (WTR::EventSenderProxy::EventSenderProxy):
2010         (WTR::EventSenderProxy::mouseDown):
2011         (WTR::EventSenderProxy::mouseUp):
2012         (WTR::EventSenderProxy::mouseMoveTo):
2013         (WTR::EventSenderProxy::mouseScrollBy):
2014         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2015
2016 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2017
2018         Unreviewed fix for API test failure after r240437.
2019
2020         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2021
2022         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2023
2024 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2025
2026         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2027         https://bugs.webkit.org/show_bug.cgi?id=193787
2028         <rdar://problem/47497634>
2029
2030         Reviewed by Alexey Proskuryakov.
2031
2032         * Scripts/webkitdirs.pm:
2033         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2034
2035 2019-01-24  Truitt Savell  <tsavell@apple.com>
2036
2037         Unreviewed, rolling out r240446.
2038
2039         Casued 5 API failures
2040
2041         Reverted changeset:
2042
2043         "Activate the WebResourceLoadStatisticsStore in the
2044         NetworkProcess and deactivate it in the UIProcess."
2045         https://bugs.webkit.org/show_bug.cgi?id=193297
2046         https://trac.webkit.org/changeset/240446
2047
2048 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2049
2050         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2051         https://bugs.webkit.org/show_bug.cgi?id=193741
2052         <rdar://problem/47135030>
2053
2054         Reviewed by Antti Koivisto and Simon Fraser.
2055
2056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2057         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2058         (TestWebKitAPI::TEST):
2059
2060 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2061
2062         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2063         https://bugs.webkit.org/show_bug.cgi?id=193297
2064         <rdar://problem/47158841>
2065
2066         Reviewed by Alex Christensen.
2067
2068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2069         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2070         activating the message used to trigger the callback when it is set.
2071
2072 2019-01-24  John Wilander  <wilander@apple.com>
2073
2074         Add Ad Click Attribution as an internal/experimental feature
2075         https://bugs.webkit.org/show_bug.cgi?id=193685
2076         <rdar://problem/47450399>
2077
2078         Reviewed by Brent Fulgham.
2079
2080         Added test option adClickAttributionEnabled.
2081
2082         * DumpRenderTree/TestOptions.cpp:
2083         (TestOptions::TestOptions):
2084         * DumpRenderTree/TestOptions.h:
2085         * DumpRenderTree/mac/DumpRenderTree.mm:
2086         (setWebPreferencesForTestOptions):
2087
2088 2019-01-24  Antti Koivisto  <antti@apple.com>
2089
2090         [PSON] Flash on back navigation on Mac
2091         https://bugs.webkit.org/show_bug.cgi?id=193716
2092         <rdar://problem/47148458>
2093
2094         Reviewed by Chris Dumez.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2097
2098         Closing of the previous page is delayed so waiting for didFinishNavigation is
2099         not sufficient to guarantee we have received all the messages. Wait for them.
2100
2101 2019-01-24  Chris Dumez  <cdumez@apple.com>
2102
2103         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2104         https://bugs.webkit.org/show_bug.cgi?id=193761
2105         <rdar://problem/47456405>
2106
2107         Reviewed by Alex Christensen.
2108
2109         Add API test coverage.
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112
2113 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2114
2115         webkitpy: Missing PID in crashlog name should not be fatal
2116         https://bugs.webkit.org/show_bug.cgi?id=193771
2117
2118         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2119         of raising an exception.
2120
2121         Reviewed by Lucas Forschler.
2122
2123         * Scripts/webkitpy/port/darwin.py:
2124         (DarwinPort._merge_crash_logs):
2125
2126 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2127
2128         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2129         https://bugs.webkit.org/show_bug.cgi?id=193746
2130
2131         Reviewed by Youenn Fablet.
2132
2133         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2134         so we'd best just not call it.
2135
2136         * Scripts/webkitpy/w3c/test_exporter.py:
2137         (WebPlatformTestExporter.create_branch_with_patch):
2138
2139 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2140
2141         Move FileSystem to WTF
2142         https://bugs.webkit.org/show_bug.cgi?id=193602
2143
2144         Reviewed by Yusuke Suzuki.
2145
2146         * DumpRenderTree/win/DumpRenderTree.cpp:
2147         * TestWebKitAPI/CMakeLists.txt:
2148         * TestWebKitAPI/PlatformGTK.cmake:
2149         * TestWebKitAPI/PlatformJSCOnly.cmake:
2150         * TestWebKitAPI/PlatformPlayStation.cmake:
2151         * TestWebKitAPI/PlatformWPE.cmake:
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2154         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2155         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2156         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2157         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2158         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2159         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2160         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2161         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2162
2163 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2164
2165         [WPE] Remove hard dependency on subprocess32 for the API tests
2166
2167         Rubber-stamped by Carlos Garcia Campos.
2168
2169         * glib/api_test_runner.py:
2170         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2171         its presence only when running WPEQt tests.
2172
2173 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2174
2175         [GLIB] Expose JavaScriptCore options in GLib public API
2176         https://bugs.webkit.org/show_bug.cgi?id=188742
2177
2178         Reviewed by Michael Catanzaro.
2179
2180         Add a test for the new API.
2181
2182         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2183         (testsJSCOptions):
2184         (main):
2185
2186 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2187
2188         [GTK][WPE] Support JPEG 2000 images
2189         https://bugs.webkit.org/show_bug.cgi?id=186272
2190
2191         Reviewed by Žan Doberšek.
2192
2193         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2194
2195         * gtk/jhbuild.modules:
2196         * wpe/jhbuild.modules:
2197
2198 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2199
2200         check-webkit-style should warn when using soft-linking macros in a header
2201         <https://webkit.org/b/193750>
2202
2203         Reviewed by Darin Adler.
2204
2205         * Scripts/webkitpy/style/checkers/cpp.py:
2206         (check_language): Add softlink/header check by refactoring the
2207         softlink/framework check.
2208         (CppChecker): Enable softlink/header check by default.
2209         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2210         (CppStyleTest.test_softlink_framework): Rename from
2211         CppStyleTest.test_softlink() and change test framework name in
2212         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2213         files. Set file_name for macros that only appear in headers.
2214         (CppStyleTest.test_softlink_header): Add tests for using
2215         soft-link macros in headers.
2216
2217 2019-01-23  Chris Dumez  <cdumez@apple.com>
2218
2219         Deprecate API to limit the maximum number of WebProcesses
2220         https://bugs.webkit.org/show_bug.cgi?id=193725
2221         <rdar://problem/47464879>
2222
2223         Reviewed by Geoff Garen.
2224
2225         Update existing API tests to stop using deprecated API.
2226
2227         * MiniBrowser/mac/AppDelegate.m:
2228         (defaultConfiguration):
2229         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2230         (TestWebKitAPI::TEST):
2231         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2232         (TestWebKitAPI::TEST):
2233         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2234         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2235         (TEST):
2236         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2237         (TEST):
2238
2239 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2240
2241         [ews-app] Rename ews model buildermappings to buildermapping
2242         https://bugs.webkit.org/show_bug.cgi?id=193729
2243
2244         Reviewed by Lucas Forschler.
2245
2246         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2247         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2248         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2249
2250 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2251
2252         [ews-app] Rename ews model steps to step
2253         https://bugs.webkit.org/show_bug.cgi?id=193697
2254
2255         Reviewed by Lucas Forschler.
2256
2257         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2258         (Step): Renamed Steps to Step.
2259
2260 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2261
2262         Clean up IndexedDB files between tests
2263         https://bugs.webkit.org/show_bug.cgi?id=192796
2264         <rdar://problem/46824999>
2265
2266         Reviewed by Geoffrey Garen.
2267
2268         * DumpRenderTree/mac/DumpRenderTree.mm:
2269         (runTest):
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::TestController::resetStateToConsistentValues):
2272         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2273         (WTR::RemoveAllIndexedDatabasesCallback):
2274         (WTR::TestController::ClearIndexedDatabases):
2275         * WebKitTestRunner/TestController.h:
2276         * WebKitTestRunner/TestInvocation.cpp:
2277         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2278
2279 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2280
2281         [ews-app] Rename ews model Builds to Build
2282         https://bugs.webkit.org/show_bug.cgi?id=193695
2283
2284         Reviewed by Lucas Forschler.
2285
2286         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2287         (Build): Renamed Builds to Build.
2288
2289 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2290
2291         webkitpy: Wait longer when launching WebKitTestRunner
2292         https://bugs.webkit.org/show_bug.cgi?id=193734
2293
2294         Reviewed by Aakash Jain.
2295
2296         * Scripts/webkitpy/port/simulator_process.py:
2297         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2298
2299 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2300
2301         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2302         https://bugs.webkit.org/show_bug.cgi?id=193182
2303         <rdar://problem/47452154>
2304
2305         Reviewed by Tim Horton.
2306
2307         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2308         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2309         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2310
2311         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2312         preventing later tests from recognizing gestures.
2313
2314         * WebKitTestRunner/ios/TestControllerIOS.mm:
2315         (WTR::TestController::platformResetStateToConsistentValues):
2316
2317         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2318
2319 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2320
2321         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2322         https://bugs.webkit.org/show_bug.cgi?id=193722
2323         <rdar://problem/47481475>
2324
2325         Reviewed by Lucas Forschler.
2326
2327         iPhone and iPad ports should both use the iOS config.
2328
2329         * Scripts/webkitpy/port/ios_simulator.py:
2330         (IPhoneSimulatorPort.__init__):
2331         (IPadSimulatorPort.__init__):
2332
2333 2019-01-23  Rob Buis  <rbuis@igalia.com>
2334
2335         Update MIME type parser
2336         https://bugs.webkit.org/show_bug.cgi?id=180526
2337
2338         Reviewed by Frédéric Wang.
2339
2340         Add unit tests for both parse modes of ParsedContentType.
2341
2342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2343         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2344         (TestWebKitAPI::TEST):
2345
2346 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2347
2348         [ews-app] fetch loop should not stop on network issues
2349         https://bugs.webkit.org/show_bug.cgi?id=193666
2350
2351         Reviewed by Lucas Forschler.
2352
2353         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2354         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2355
2356 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2357
2358         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2359         https://bugs.webkit.org/show_bug.cgi?id=189165
2360         <rdar://problem/47433765>
2361
2362         Reviewed by Tim Horton.
2363
2364         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2365         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2366         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2367         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2368         would make its way to the UI process by the time the layer tree commit is finished.
2369
2370         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2371         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2372         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2373         will fail because it asks for -_autofillContext too early.
2374
2375         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2376         is handled in the UI process.
2377
2378         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2379
2380         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2381         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2382         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2383         input session.
2384
2385         (-[AutofillTestView textInputHasAutofillContext]):
2386
2387         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2388
2389         * TestWebKitAPI/cocoa/TestWKWebView.h:
2390         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2391         (nextInputSessionChangeCount):
2392
2393         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2394         This includes changing the focused element from one to another.
2395
2396         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2397         (-[TestWKWebView didStartFormControlInteraction]):
2398         (-[TestWKWebView didEndFormControlInteraction]):
2399         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2400
2401         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2402         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2403         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2404         that doesn't require an input session to one that doesn't.
2405
2406 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2407
2408         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2409         <https://webkit.org/b/193676>
2410
2411         Reviewed by Alexey Proskuryakov.
2412
2413         * Scripts/webkitpy/style/checkers/cpp.py:
2414         (check_member_initialization_list):
2415         - Don't report missing whitespace around colon if the colon at
2416           the start of the line is formatted correctly.
2417         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2418         (WebKitStyleTest.test_member_initialization_list):
2419         - Add a test for a missing permutation of existing tests.
2420         - Add a test this false-positive.
2421         - Add blank lines between subtests to make them easier to read.
2422
2423 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2424
2425         [build.webkit.org] Unit-test failure after r237113
2426         https://bugs.webkit.org/show_bug.cgi?id=193669
2427
2428         Reviewed by Michael Catanzaro.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2431         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2432         multiple or zero flags.
2433
2434 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2435
2436         Cache bytecode to disk
2437         https://bugs.webkit.org/show_bug.cgi?id=192782
2438         <rdar://problem/46084932>
2439
2440         Reviewed by Keith Miller.
2441
2442         Add test helper to execute bytecode-cache tests: it executes each test
2443         twice, the first with JSC_diskCachePath set to a temporary directory
2444         and second with JSC_forceDiskCache=true (in addition to the cache path)
2445         to guarantee that only the disk cache is being used and no new
2446         UnlinkedCodeBlocks are being created.
2447
2448         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2449         * Scripts/run-jsc-stress-tests:
2450
2451 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2452
2453         [css-logical] Implement flow-relative margin, padding and border shorthands
2454         https://bugs.webkit.org/show_bug.cgi?id=188697
2455
2456         Reviewed by Simon Fraser and Antti Koivisto.
2457
2458         * DumpRenderTree/TestOptions.cpp:
2459         (TestOptions::TestOptions):
2460         * DumpRenderTree/TestOptions.h:
2461         * DumpRenderTree/mac/DumpRenderTree.mm:
2462         (setWebPreferencesForTestOptions):
2463         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2464
2465         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2466         (JSONCSSPropertiesChecker.check_codegen_properties):
2467         Allow CSS property definitions to have a 'runtime-flag' parameter which
2468         disables the property when the specified runtime flag is disabled.
2469
2470 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2471
2472         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2473         https://bugs.webkit.org/show_bug.cgi?id=193643
2474
2475         Reviewed by Michael Catanzaro.
2476
2477         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2478         * wpe/jhbuild.modules: Ditto.
2479
2480 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2481
2482         [LFC][Floats] Take float top position into account when computing containing block height.
2483         https://bugs.webkit.org/show_bug.cgi?id=193655
2484
2485         Reviewed by Antti Koivisto.
2486
2487         * LayoutReloaded/misc/LFC-passing-tests.txt:
2488
2489 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2490
2491         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2492         <https://webkit.org/b/193645>
2493         <rdar://problem/47421574>
2494
2495         Reviewed by Alex Christensen.
2496
2497         - Now checks for local soft-linking of all frameworks that have
2498           their own *SoftLinking.{cpp,h,mm} files.
2499         - Changes softlink/uikit warning to softlink/framework.
2500
2501         * Scripts/webkitpy/style/checkers/cpp.py:
2502         (check_language):
2503         (CppChecker):
2504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2505         (CppStyleTest):
2506
2507 2019-01-20  Saam Barati  <sbarati@apple.com>
2508
2509         Rollout r240210: It broke tests on iOS
2510         https://bugs.webkit.org/show_bug.cgi?id=193640
2511
2512         Unreviewed.
2513
2514         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2515         * Scripts/run-jsc-stress-tests:
2516
2517 2019-01-20  chris fleizach  <cfleizach@apple.com>
2518
2519         AX: Support returning relative frames for accessibility
2520         https://bugs.webkit.org/show_bug.cgi?id=193414
2521         <rdar://problem/47268501>
2522
2523         Reviewed by Zalan Bujtas.
2524
2525         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2526         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2527         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2528         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2529         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2530         (WTR::attributesOfElement):
2531         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2532
2533 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2534
2535         Unreviewed, add my new email address
2536
2537         * Scripts/webkitpy/common/config/contributors.json:
2538
2539 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2540
2541         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2542         https://bugs.webkit.org/show_bug.cgi?id=193617
2543
2544         Reviewed by Antti Koivisto.
2545
2546         * LayoutReloaded/misc/LFC-passing-tests.txt:
2547
2548 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2549
2550         Unreviewed, rolling out r240209.
2551
2552         Broke GTK/WPE injected bundle
2553
2554         Reverted changeset:
2555
2556         "AX: Support returning relative frames for accessibility"
2557         https://bugs.webkit.org/show_bug.cgi?id=193414
2558         https://trac.webkit.org/changeset/240209
2559
2560 2019-01-12  Dan Bernstein  <mitz@apple.com>
2561
2562         [Cocoa] Avoid importing directly from subumbrella frameworks
2563         https://bugs.webkit.org/show_bug.cgi?id=186016
2564         <rdar://problem/40591038>
2565
2566         Reviewed by Sam Weinig.
2567
2568         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2569           LaunchServices header.
2570         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2571           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2572         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2573           when using SDKs earlier than 10.13.
2574         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2575           and OTHER_CPLUSPLUSFLAGS.
2576         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2577           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2578         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2579           LaunchServices header.
2580
2581 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2582
2583         Cache bytecode to disk
2584         https://bugs.webkit.org/show_bug.cgi?id=192782
2585         <rdar://problem/46084932>
2586
2587         Reviewed by Keith Miller.
2588
2589         Add test helper to execute bytecode-cache tests: it executes each test
2590         twice, the first with JSC_diskCachePath set to a temporary directory
2591         and second with JSC_forceDiskCache=true (in addition to the cache path)
2592         to guarantee that only the disk cache is being used and no new
2593         UnlinkedCodeBlocks are being created.
2594
2595         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2596         * Scripts/run-jsc-stress-tests:
2597
2598 2019-01-20  chris fleizach  <cfleizach@apple.com>
2599
2600         AX: Support returning relative frames for accessibility
2601         https://bugs.webkit.org/show_bug.cgi?id=193414
2602         <rdar://problem/47268501>
2603
2604         Reviewed by Zalan Bujtas.
2605
2606         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2607         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2608         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2609         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2610         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2611         (WTR::attributesOfElement):
2612         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2613
2614 2019-01-20  Antoine Quint  <graouts@apple.com>
2615
2616         Add a POINTER_EVENTS feature flag
2617         https://bugs.webkit.org/show_bug.cgi?id=193577
2618         <rdar://problem/47408511>
2619
2620         Unreviewed. Also enable Pointer Events for iosmac.
2621
2622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2623
2624 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2625
2626         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2627         https://bugs.webkit.org/show_bug.cgi?id=193613
2628
2629         Reviewed by Antti Koivisto.
2630
2631         * LayoutReloaded/misc/LFC-passing-tests.txt:
2632
2633 2019-01-19  Antoine Quint  <graouts@apple.com>
2634
2635         Add a POINTER_EVENTS feature flag
2636         https://bugs.webkit.org/show_bug.cgi?id=193577
2637
2638         Reviewed by Dean Jackson.
2639
2640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2641
2642 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2643
2644         Disable the run-jsc-stress-test remote host key check [second round].
2645         https://bugs.webkit.org/show_bug.cgi?id=192988
2646
2647         Reviewed by Dewei Zhu.
2648
2649         * Scripts/run-jsc-stress-tests:
2650
2651 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2652
2653         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2654         https://bugs.webkit.org/show_bug.cgi?id=193597
2655
2656         Reviewed by Lucas Forschler.
2657
2658         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2659
2660 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2661
2662         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2663         https://bugs.webkit.org/show_bug.cgi?id=193595
2664
2665         Reviewed by Lucas Forschler.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2668         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2669         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2670
2671 2019-01-18  Chris Dumez  <cdumez@apple.com>
2672
2673         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2674         https://bugs.webkit.org/show_bug.cgi?id=193588
2675         <rdar://problem/47131566>
2676
2677         Reviewed by Alex Christensen.
2678
2679         Add layout test coverage.
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2682
2683 2019-01-18  Jer Noble  <jer.noble@apple.com>
2684
2685         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2686         https://bugs.webkit.org/show_bug.cgi?id=189553
2687
2688         Reviewed by Tim Horton.
2689
2690         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2691
2692         * ContentExtensionTester/Configurations/Base.xcconfig:
2693         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2694         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2695         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2696         * ImageDiff/cg/Configurations/Base.xcconfig:
2697         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2698         * MiniBrowser/Configurations/Base.xcconfig:
2699         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2700         * MobileMiniBrowser/Configurations/Base.xcconfig:
2701         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2702         * Scripts/webkitpy/style/checker.py:
2703         (_all_categories):
2704         (FileType):
2705         (CheckerDispatcher._file_type):
2706         (CheckerDispatcher._create_checker):
2707         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2708         (SDKVariantChecker):
2709         (SDKVariantChecker.__init__):
2710         (SDKVariantChecker.check):
2711         * TestWebKitAPI/Configurations/Base.xcconfig:
2712         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2713         * WebEditingTester/Configurations/Base.xcconfig:
2714         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2715         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2716         * WebKitTestRunner/Configurations/Base.xcconfig:
2717         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2718         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2719         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2720
2721 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2722
2723         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2724         <https://webkit.org/b/193568>
2725         <rdar://problem/47381130>
2726
2727         Reviewed by Alex Christensen.
2728
2729         Make sure no one re-introduces UIKit soft-linking by adding a
2730         style rule.
2731
2732         * Scripts/webkitpy/style/checkers/cpp.py:
2733         (check_language): Add softlink/uikit check.
2734         (CppChecker): Enable softlink/uikit check.
2735         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2736         (CppStyleTest): Add test for softlink/uikit.
2737
2738 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2739
2740         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2741         https://bugs.webkit.org/show_bug.cgi?id=193584
2742
2743         Change "-dev" to "-devel".
2744
2745         Reviewed by Michael Catanzaro.
2746
2747         * gtk/install-dependencies:
2748
2749 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2750
2751         webkitpy: Add iPhone and iPad ports
2752         https://bugs.webkit.org/show_bug.cgi?id=193537
2753         <rdar://problem/47353390>
2754
2755         Reviewed by Lucas Forschler.
2756
2757         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2758         ports. Note that this separation is optional, the --ios-simulator command remains.
2759
2760         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2761         (RunTest.test_device_type_test_division): Drive-by fix.
2762         (RunTest.test_device_type_specific_listing): Ditto.
2763         (RunTest.test_ipad_test_division):
2764         (RunTest):
2765         (RunTest.test_ipad_listing):
2766         * Scripts/webkitpy/port/factory.py:
2767         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2768         (PortFactory):
2769         * Scripts/webkitpy/port/ios_simulator.py:
2770         (IPhoneSimulatorPort):
2771         (IPadSimulatorPort):
2772
2773 2019-01-18  Chris Dumez  <cdumez@apple.com>
2774
2775         Regression(PSON) Scroll position is not always restored properly when navigating back
2776         https://bugs.webkit.org/show_bug.cgi?id=193578
2777         <rdar://problem/47386331>
2778
2779         Reviewed by Tim Horton.
2780
2781         Add API test coverage.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2784
2785 2019-01-18  Youenn Fablet  <youenn@apple.com>
2786
2787         Add a new SPI to request for cache storage quota increase
2788         https://bugs.webkit.org/show_bug.cgi?id=193323
2789
2790         Reviewed by Alex Christensen.
2791
2792         Implement WebsiteDataStore quota delegate to handle quota requests.
2793         By default, do not update quota.
2794         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2795
2796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2798         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2799         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2800         * WebKitTestRunner/TestController.cpp:
2801         (WTR::TestController::allowCacheStorageQuotaIncrease):
2802         * WebKitTestRunner/TestController.h:
2803         * WebKitTestRunner/TestInvocation.cpp:
2804         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2805         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2806         (-[CacheStorageQuotaManager init]):
2807         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2808         (WTR::initializeWebViewConfiguration):
2809         (WTR::TestController::cocoaResetStateToConsistentValues):
2810         (WTR::TestController::allowCacheStorageQuotaIncrease):
2811
2812 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2813
2814         [ews-build] Pass owner to the triggered builds
2815         https://bugs.webkit.org/show_bug.cgi?id=193574
2816
2817         Reviewed by Lucas Forschler.
2818
2819         * BuildSlaveSupport/ews-build/factories.py:
2820         (BuildFactory.propertiesToPassToTriggers):
2821
2822 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2823
2824         [ews-app] Send patch author as a build property
2825         https://bugs.webkit.org/show_bug.cgi?id=193560
2826
2827         Reviewed by Lucas Forschler.
2828
2829         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2830         (BugzillaPatchFetcher.fetch):
2831
2832 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2833
2834         webkitpy: Implement device type specific expected results (Follow-up fix)
2835         https://bugs.webkit.org/show_bug.cgi?id=192162
2836         <rdar://problem/46345449>
2837
2838         Unreviewed infrastructure fix.
2839
2840         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2841         (Manager.run): Don't boot a device if no tests are available to run on it.
2842
2843 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2844
2845         webkitpy: Implement device type specific expected results (Follow-up fix)
2846         https://bugs.webkit.org/show_bug.cgi?id=192162
2847         <rdar://problem/46345449>
2848
2849         Unreviewed infrastructure fix.
2850
2851         * Scripts/webkitpy/api_tests/manager.py:
2852         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2853
2854 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2855
2856         webkitpy: Implement device type specific expected results (Part 2)
2857         https://bugs.webkit.org/show_bug.cgi?id=192162
2858         <rdar://problem/46345449>
2859
2860         Rubber-stamped by Aakash Jain.
2861
2862         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2863         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2864         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2865
2866         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2867         (LayoutTestFinder.find_tests): Pass device_type through.
2868         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2869         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2870         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2871         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2872         (Manager._collect_tests): Pass device type to test finder.
2873         (Manager._needs_web_platform_test):
2874         (Manager._prepare_lists): Index _expectations by device type.
2875         (Manager._test_input_for_file):
2876         (Manager._test_is_slow): Ditto.
2877         (Manager._test_should_dump_jsconsolelog_in_stderr):
2878         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2879         (Manager._get_test_inputs):
2880         (Manager._update_worker_count):
2881         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2882         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2883         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2884         the one which runs the test.
2885         (Manager._run_test_subset):
2886         (Manager._run_tests): Index _expectations by current_device_type.
2887         (Manager._print_expectation_line_for_test): Ditto.
2888         (Manager._print_expectations_for_subset): Ditto.
2889         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2890         Unlike run, this function will behave the same regardless of what devices are available.
2891         (Manager._custom_device_for_test): Deleted.
2892         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2893         (ManagerTest.test_uses_custom_device): Deleted.
2894         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2895         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2896         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2897         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2898         all of the expectations.
2899         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2900         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2901         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2902         (TestExpectations.__init__): Allow device_type to be passed through.
2903         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2904         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2905         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2906         (summarize_results):
2907         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2908         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2909         a test ran with, one must check all expectations to find the first non-skip expectation.
2910         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2911         (RunTest.test_device_type_test_division):
2912         (RunTest):
2913         (RunTest.test_device_type_specific_listing):
2914         * Scripts/webkitpy/port/base.py:
2915         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2916         (Port.supported_device_types): The result of this function will change based on what devices are available.
2917         * Scripts/webkitpy/port/device_port.py:
2918         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2919         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2920         can be used.
2921         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2922         any, or the DEFAULT_DEVICE_TYPES of the port.
2923         * Scripts/webkitpy/port/ios.py:
2924         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2925         * Scripts/webkitpy/port/ios_simulator.py:
2926         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2927         * Scripts/webkitpy/port/watch.py:
2928         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2929         * Scripts/webkitpy/port/watch_simulator.py:
2930         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2931         * Scripts/webkitpy/xcode/device_type.py:
2932         (DeviceType):
2933         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2934
2935 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2936
2937         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2938         https://bugs.webkit.org/show_bug.cgi?id=193575
2939
2940         Reviewed by Michael Catanzaro.
2941
2942         Allow the script to run without explicit port argument because
2943         it's specific to the WPE port anyway.
2944
2945         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2946         and simplify the rest of the code accordingly.
2947
2948 2019-01-18  Charlie Turner  <cturner@igalia.com>
2949
2950         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2951         https://bugs.webkit.org/show_bug.cgi?id=192229
2952
2953         Reviewed by Xabier Rodriguez-Calvar.
2954
2955         * MiniBrowser/wpe/main.cpp:
2956         (main): Enable encrypted-media by default.
2957
2958 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2959
2960         [Flatpak] Missing KeyboardInterrupt exception handler
2961         https://bugs.webkit.org/show_bug.cgi?id=193570
2962
2963         Reviewed by Michael Catanzaro.
2964
2965         * flatpak/flatpakutils.py:
2966         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2967
2968 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2969
2970         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2971         https://bugs.webkit.org/show_bug.cgi?id=193564
2972
2973         Reviewed by Antti Koivisto.
2974
2975         * LayoutReloaded/misc/LFC-passing-tests.txt:
2976
2977 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2978
2979         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2980         https://bugs.webkit.org/show_bug.cgi?id=193562
2981
2982         Reviewed by Antti Koivisto.
2983
2984         * LayoutReloaded/misc/LFC-passing-tests.txt:
2985
2986 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2987
2988         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2989         https://bugs.webkit.org/show_bug.cgi?id=193555
2990
2991         Reviewed by Antti Koivisto.
2992
2993         * LayoutReloaded/misc/LFC-passing-tests.txt:
2994
2995 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2996
2997         [WPE] Add Qt extension
2998         https://bugs.webkit.org/show_bug.cgi?id=191464
2999
3000         Reviewed by Carlos Garcia Campos.
3001
3002         MiniBrowser and API tests for the WPE Qt API. To run the
3003         MiniBrowser a new script is introduced. Example invocation:
3004
3005         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3006
3007         Also note-worthy is the introduction of the python2-subprocess32
3008         dependency to run the GLib API tests.
3009
3010         * MiniBrowser/wpe/CMakeLists.txt:
3011         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3012         * MiniBrowser/wpe/qt/main.cpp: Added.
3013         (main):
3014         * MiniBrowser/wpe/qt/main.qml: Added.
3015         * MiniBrowser/wpe/qt/qml.qrc: Added.
3016         * Scripts/run-gtk-tests:
3017         (GtkTestRunner.is_google_test):
3018         (GtkTestRunner):
3019         (GtkTestRunner.is_qt_test):
3020         * Scripts/run-qt-wpe-minibrowser: Added.
3021         * Scripts/run-wpe-tests:
3022         (WPETestRunner):
3023         (WPETestRunner.is_google_test):
3024         (WPETestRunner.is_qt_test):
3025         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3026         (TestLoad::main):
3027         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3028         (TestLoadHtml::main):
3029         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3030         (TestLoadRequest::main):
3031         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3032         (TestRunJavaScript::main):
3033         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3034         (waitForSignal):
3035         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3036         (LoadSpy::LoadSpy):
3037         (LoadSpy::~LoadSpy):
3038         (LoadSpy::onLoadingChanged):
3039         (LoadStartedCatcher::LoadStartedCatcher):
3040         (LoadStartedCatcher::~LoadStartedCatcher):
3041         (LoadStartedCatcher::onLoadingChanged):
3042         (waitForLoadSucceeded):
3043         (waitForLoadFailed):
3044         * TestWebKitAPI/glib/CMakeLists.txt:
3045         * flatpak/flatpakutils.py:
3046         (WebkitFlatpak.load_from_args):
3047         (WebkitFlatpak.__init__):
3048         (WebkitFlatpak.clean_args):
3049         (WebkitFlatpak.run_in_sandbox):
3050         * flatpak/org.webkit.CommonModules.yaml:
3051         * flatpak/org.webkit.WPE.yaml:
3052         * flatpak/org.webkit.WPEModules.yaml:
3053         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3054         * flatpak/org.webkit.WebKit.yaml:
3055         * glib/api_test_runner.py:
3056         (TestRunner._run_test_qt):
3057         (TestRunner.is_qt_test):
3058         (TestRunner._run_test):
3059
3060 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3061
3062         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3063         https://bugs.webkit.org/show_bug.cgi?id=193494
3064         <rdar://problem/46859627>
3065
3066         Reviewed by Simon Fraser and Tim Horton.
3067
3068         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3069         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3070
3071         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3072         (WTR::UIScriptController::contentOffsetX const):
3073         (WTR::UIScriptController::contentOffsetY const):
3074         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3075         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3076         (WTR::UIScriptController::contentOffsetX const):
3077         (WTR::UIScriptController::contentOffsetY const):
3078         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3079
3080         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3081
3082         * WebKitTestRunner/TestController.cpp:
3083         (WTR::updateTestOptionsFromTestHeader):
3084         * WebKitTestRunner/TestOptions.h:
3085         (WTR::TestOptions::hasSameInitializationOptions const):
3086         * WebKitTestRunner/ios/TestControllerIOS.mm:
3087         (WTR::TestController::platformResetStateToConsistentValues):
3088         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3089         (WTR::UIScriptController::contentOffsetX const):
3090         (WTR::UIScriptController::contentOffsetY const):
3091
3092 2019-01-17  Truitt Savell  <tsavell@apple.com>
3093
3094         Unreviewed, rolling out r240124.
3095
3096         This commit broke an internal build.
3097
3098         Reverted changeset:
3099
3100         "SDK_VARIANT build destinations should be separate from non-
3101         SDK_VARIANT builds"
3102         https://bugs.webkit.org/show_bug.cgi?id=189553
3103         https://trac.webkit.org/changeset/240124
3104
3105 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3106
3107         Fix string concatenation API test after r239920
3108         https://bugs.webkit.org/show_bug.cgi?id=193551
3109         <rdar://problem/47359304>
3110
3111         Reviewed by Youenn Fablet.
3112
3113         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3114         (TestWebKitAPI::TEST):
3115         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3116         in WebKit's build configuration like it apparently is on Linux.
3117
3118 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-build] validate-patch should handle the case when bug_id is None
3121         https://bugs.webkit.org/show_bug.cgi?id=193547
3122
3123         Reviewed by Lucas Forschler.
3124
3125         * BuildSlaveSupport/ews-build/steps.py:
3126         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3127         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3128
3129 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-build] Add patch author information in build
3132         https://bugs.webkit.org/show_bug.cgi?id=193465
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-build/steps.py:
3137         (ValidatePatch._is_patch_obsolete):
3138
3139 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3140
3141         [ews-build] Pass bug_id to the triggered builds
3142         https://bugs.webkit.org/show_bug.cgi?id=193548
3143
3144         Reviewed by Lucas Forschler.
3145
3146         * BuildSlaveSupport/ews-build/factories.py:
3147         (BuildFactory.propertiesToPassToTriggers):
3148
3149 2019-01-17  Jer Noble  <jer.noble@apple.com>
3150
3151         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3152         https://bugs.webkit.org/show_bug.cgi?id=189553
3153
3154         Reviewed by Tim Horton.
3155
3156         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3157
3158         * ContentExtensionTester/Configurations/Base.xcconfig:
3159         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3160         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3161         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3162         * ImageDiff/cg/Configurations/Base.xcconfig:
3163         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3164         * MiniBrowser/Configurations/Base.xcconfig:
3165         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3166         * MobileMiniBrowser/Configurations/Base.xcconfig:
3167         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3168         * Scripts/webkitpy/style/checker.py:
3169         (_all_categories):
3170         (FileType):
3171         (CheckerDispatcher._file_type):
3172         (CheckerDispatcher._create_checker):
3173         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3174         (SDKVariantChecker):
3175         (SDKVariantChecker.__init__):
3176         (SDKVariantChecker.check):
3177         * TestWebKitAPI/Configurations/Base.xcconfig:
3178         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3179         * WebEditingTester/Configurations/Base.xcconfig:
3180         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3181         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3182         * WebKitTestRunner/Configurations/Base.xcconfig:
3183         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3184         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3185         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3186
3187 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3188
3189         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3190         https://bugs.webkit.org/show_bug.cgi?id=193534
3191
3192         Reviewed by Antti Koivisto.
3193
3194         * LayoutReloaded/misc/LFC-passing-tests.txt:
3195
3196 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3197
3198         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3199         https://bugs.webkit.org/show_bug.cgi?id=193528
3200
3201         Reviewed by Antti Koivisto.
3202
3203         * LayoutReloaded/misc/LFC-passing-tests.txt:
3204
3205 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3206
3207         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3208         https://bugs.webkit.org/show_bug.cgi?id=193520
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * LayoutReloaded/misc/LFC-passing-tests.txt:
3213
3214 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews-build] unapply-patch step should not update source
3217         https://bugs.webkit.org/show_bug.cgi?id=193234
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * BuildSlaveSupport/ews-build/steps.py:
3222         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3223         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3224
3225 2019-01-16  Youenn Fablet  <youenn@apple.com>
3226
3227         Add a new SPI for controlling getUserMedia
3228         https://bugs.webkit.org/show_bug.cgi?id=192793
3229
3230         Reviewed by Eric Carlson.
3231
3232         * MiniBrowser/mac/WK2BrowserWindowController.m:
3233         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3234         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3235         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3236         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3237         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3238         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3239         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3240         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3241         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3242         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3243         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3244         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3245         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3246         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3247
3248 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3249
3250         [LFC][BFC] Inflow non-replaced used width should not be negative.
3251         https://bugs.webkit.org/show_bug.cgi?id=193495
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * LayoutReloaded/misc/LFC-passing-tests.txt:
3256
3257 2019-01-16  Chris Dumez  <cdumez@apple.com>
3258
3259         Regression(PSON) View becomes blank after click a cross-site download link
3260         https://bugs.webkit.org/show_bug.cgi?id=193361
3261         <rdar://problem/47099573>
3262
3263         Reviewed by Geoffrey Garen.
3264
3265         Add API test coverage.
3266
3267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3268         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3269
3270 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3271
3272         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3273         https://bugs.webkit.org/show_bug.cgi?id=193470
3274
3275         Reviewed by Antti Koivisto.
3276
3277         * LayoutReloaded/misc/LFC-passing-tests.txt:
3278
3279 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3280
3281         [LFC] Adjust margin box verification.
3282         https://bugs.webkit.org/show_bug.cgi?id=193482
3283
3284         Reviewed by Antti Koivisto.
3285
3286         * LayoutReloaded/misc/LFC-passing-tests.txt:
3287
3288 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3289
3290         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3291         https://bugs.webkit.org/show_bug.cgi?id=193451
3292
3293         Reviewed by Geoffrey Garen.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3296         (TEST):
3297         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3298         (runWebsiteDataStoreCustomPaths):
3299
3300 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3301
3302         webkitpy: Support boolean simctl isAvailable
3303         https://bugs.webkit.org/show_bug.cgi?id=193472
3304         <rdar://problem/47296150>
3305
3306         Reviewed by Ryosuke Niwa.
3307
3308         * Scripts/webkitpy/xcode/simulated_device.py:
3309         (SimulatedDeviceManager._create_runtimes):
3310         (SimulatedDeviceManager._create_device_with_runtime):
3311
3312 2019-01-15  Chris Dumez  <cdumez@apple.com>
3313
3314         Unreviewed, rolling out r239993, r239995, r239997, and
3315         r239999.
3316
3317         Caused assertions under
3318         ViewGestureController::disconnectFromProcess()
3319
3320         Reverted changesets:
3321
3322         "Regression(PSON) View becomes blank after click a cross-site
3323         download link"
3324         https://bugs.webkit.org/show_bug.cgi?id=193361
3325         https://trac.webkit.org/changeset/239993
3326
3327         "Unreviewed iOS build fix after r239993."
3328         https://trac.webkit.org/changeset/239995
3329
3330         "Fix iOS build after r239993"
3331         https://bugs.webkit.org/show_bug.cgi?id=193361
3332         https://trac.webkit.org/changeset/239997
3333
3334         "Unreviewed, revert part of r239997 as it is not needed to fix
3335         the build."
3336         https://trac.webkit.org/changeset/239999
3337
3338 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3339
3340         Cannot tab out of WKWebView on macOS
3341         https://bugs.webkit.org/show_bug.cgi?id=161448
3342         <rdar://problem/28100085>
3343
3344         Reviewed by Dean Jackson.
3345
3346         Add a test that tabbing into and out of WKWebView works correctly.
3347
3348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3349         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3350         (WebKit2_CommandBackForwardTest::SetUp):
3351         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3352         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3353         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3354         (-[FocusableView canBecomeKeyView]):
3355         (TEST):
3356         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3357         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3358         (-[OffscreenWindow initWithSize:]):
3359         (-[OffscreenWindow isKeyWindow]):
3360         (-[OffscreenWindow isVisible]):
3361         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3362         (TestWebKitAPI::PlatformWebView::initialize):
3363         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3364         (-[ActiveOffscreenWindow isVisible]): Deleted.
3365         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3366
3367 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3368
3369         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3370         https://bugs.webkit.org/show_bug.cgi?id=193459
3371
3372         Reviewed by Mark Lam.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3375         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3376
3377 2019-01-15  Chris Dumez  <cdumez@apple.com>
3378
3379         Regression(PSON) View becomes blank after click a cross-site download link
3380         https://bugs.webkit.org/show_bug.cgi?id=193361
3381         <rdar://problem/47099573>
3382
3383         Reviewed by Geoff Garen.
3384
3385         Add API test coverage.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3388         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3389
3390 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3391
3392         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3393         https://bugs.webkit.org/show_bug.cgi?id=193448
3394
3395         Reviewed by Antti Koivisto.
3396
3397         * LayoutReloaded/misc/LFC-passing-tests.txt:
3398
3399 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3400
3401         webkitpy: Implement device type specific expected results (Part 1)
3402         https://bugs.webkit.org/show_bug.cgi?id=192162
3403
3404         Reviewed by Lucas Forschler.
3405
3406         Device type specific expected results covers two related ideas. The first (covered by this change)
3407         is where to search for -expected.* files. The second is which tests to run based on the
3408         TestExpectations.txt file.
3409
3410         After this change, the baseline search path will be determined by the type of device running a
3411         test. Device type will be passed into any function which picks a file based on the baseline search
3412         path.
3413
3414         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3415         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3416         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3417         (Manager.run): Print baseline search path for each round of devices.
3418         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3419         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3420         (SingleTestRunner._expected_driver_output): Ditto.
3421         (SingleTestRunner._driver_input): Ditto.
3422         * Scripts/webkitpy/layout_tests/views/printing.py:
3423         (Printer.print_config): Move printing of baseline search path to a separate function.
3424         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3425         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3426         (Testprinter.test_print_config):
3427         (Testprinter.test_print_baseline_search_path):
3428         * Scripts/webkitpy/port/base.py:
3429         (Port.baseline_search_path): Pass device_type through.
3430         (Port._expected_baselines_for_suffixes): Ditto.
3431         (Port.expected_baselines): Ditto.
3432         (Port.expected_filename): Ditto.
3433         (Port.expected_checksum): Ditto.
3434         (Port.expected_image): Ditto.
3435         (Port.expected_audio): Ditto.
3436         (Port.expected_text): Ditto.
3437         (Port.reference_files): Ditto.
3438         (Port.tests): Ditto.
3439         (Port._expanded_paths): Ditto.
3440         (Port.skipped_layout_tests): Ditto.
3441         (Port.expectations_dict): Ditto.
3442         (Port._port_specific_expectations_files): Ditto.
3443         (Port.expectations_files): Ditto.
3444         (Port.test_search_path): Ditto.
3445         (Port._tests_for_other_platforms): Ditto.
3446         * Scripts/webkitpy/port/base_unittest.py:
3447         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3448         (PortTest.test_nonexistant_expectations): Ditto.
3449         (test_ref_tests_platform_directory): Ditto.
3450         * Scripts/webkitpy/port/darwin.py:
3451         (DarwinPort._port_specific_expectations_files): Accept device_type.
3452         * Scripts/webkitpy/port/driver.py:
3453         (DriverProxy):
3454         (DriverProxy.host): Expose _target_host for device_type information.
3455         * Scripts/webkitpy/port/gtk.py:
3456         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3457         * Scripts/webkitpy/port/ios.py:
3458         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3459         * Scripts/webkitpy/port/mac.py:
3460         (MacPort. default_baseline_search_path): Ditto.
3461         * Scripts/webkitpy/port/port_testcase.py:
3462         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3463         * Scripts/webkitpy/port/test.py:
3464         * Scripts/webkitpy/port/watch.py:
3465         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3466         * Scripts/webkitpy/port/win.py:
3467         (WinPort.test_search_path): Accept, but do not use, device_type.
3468         * Scripts/webkitpy/port/wpe.py:
3469         (WPEPort._port_specific_expectations_files): Ditto.
3470         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3471         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3472
3473 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3474
3475         [LFC] Use the containing block's padding box to position out-of-flow elements.
3476         https://bugs.webkit.org/show_bug.cgi?id=193431
3477
3478         Reviewed by Antti Koivisto.
3479
3480         * LayoutReloaded/misc/LFC-passing-tests.txt:
3481
3482 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3483
3484         Move a test implementation file that got misplaced in the Xcode project
3485
3486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3487
3488 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3489
3490         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3491         r239913, and r239914.
3492         https://bugs.webkit.org/show_bug.cgi?id=193407
3493
3494         These revisions caused an internal failure (Requested by
3495         Truitt on #webkit).
3496
3497         Reverted changesets:
3498
3499         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3500         https://bugs.webkit.org/show_bug.cgi?id=186016
3501         https://trac.webkit.org/changeset/239901
3502
3503         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3504         https://trac.webkit.org/changeset/239909
3505
3506         "Tried to fix the build."
3507         https://trac.webkit.org/changeset/239910
3508
3509         "Fixed iOS builds after r239910."
3510         https://trac.webkit.org/changeset/239912
3511
3512         "More build fixing."
3513         https://trac.webkit.org/changeset/239913
3514
3515         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3516         https://trac.webkit.org/changeset/239914
3517
3518 2019-01-14  Mark Lam  <mark.lam@apple.com>
3519
3520         Re-enable ability to build --cloop builds.
3521         https://bugs.webkit.org/show_bug.cgi?id=192955
3522         <rdar://problem/46882363>
3523
3524         Reviewed by Saam barati and Keith Miller.
3525
3526         The --cloop build option was being ignored this whole time since r236381.
3527         This patch makes it possible to build CLoop builds again.
3528
3529         * Scripts/build-jsc:
3530         * Scripts/webkitperl/FeatureList.pm:
3531         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3532
3533 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3534
3535         webkitpy: Expose device_type from host-like objects
3536         https://bugs.webkit.org/show_bug.cgi?id=193406
3537         <rdar://problem/47262305>
3538
3539         Reviewed by Lucas Forschler.
3540
3541         Devices should expose device_type. As a result, all host objects should
3542         provide a device_type property, even if they do not yet define a device_type.
3543
3544         * Scripts/webkitpy/common/system/systemhost.py:
3545         (SystemHost):
3546         (SystemHost.device_type):
3547         * Scripts/webkitpy/common/system/systemhost_mock.py:
3548         (MockSystemHost):
3549         (MockSystemHost.device_type):
3550         * Scripts/webkitpy/port/device.py:
3551         (Device):
3552         (Device.device_type):
3553         * Scripts/webkitpy/xcode/simulated_device.py:
3554         (SimulatedDeviceManager._find_exisiting_device_for_request):
3555         (SimulatedDeviceManager._disambiguate_device_type):
3556         (SimulatedDeviceManager._does_fulfill_request):
3557         (SimulatedDeviceManager.device_count_for_type):
3558         (SimulatedDeviceManager.initialize_devices):
3559         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3560         (test_available_devices):
3561         (test_swapping_devices):
3562
3563 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3564
3565         webkitpy: Support alternate simctl device list output (Follow-up fix)
3566         https://bugs.webkit.org/show_bug.cgi?id=193362
3567         <rdar://problem/47122965>
3568
3569         Rubber-stamped by Lucas Forschler.
3570
3571         * Scripts/webkitpy/xcode/simulated_device.py:
3572         (SimulatedDeviceManager.populate_available_devices):
3573
3574 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3575
3576         [iOS] Expose SPI to access the current sentence boundary and selection state
3577         https://bugs.webkit.org/show_bug.cgi?id=193398
3578         <rdar://problem/45893108>
3579
3580         Reviewed by Dean Jackson.
3581
3582         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3583         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3584         expected.
3585
3586         * TestWebKitAPI/EditingTestHarness.h:
3587         * TestWebKitAPI/EditingTestHarness.mm:
3588         (-[EditingTestHarness moveBackward]):
3589         (-[EditingTestHarness moveForward]):
3590         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3591
3592         Add a couple of new helper methods on EditingTestHarness.
3593
3594         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3595         (-[SelectionChangeObserver initWithWebView:]):
3596         (-[SelectionChangeObserver webView]):
3597         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3598         (-[SelectionChangeObserver currentSelectionAttributes]):
3599
3600 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3601
3602         [LFC][BFC] Add basic box-sizing support.
3603         https://bugs.webkit.org/show_bug.cgi?id=193392
3604
3605         Reviewed by Antti Koivisto.
3606
3607         * LayoutReloaded/misc/LFC-passing-tests.txt:
3608
3609 2019-01-14  Charlie Turner  <cturner@igalia.com>
3610
3611         [WPE] API test gardening
3612         https://bugs.webkit.org/show_bug.cgi?id=193319
3613
3614         Reviewed by Michael Catanzaro.
3615
3616         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3617         passing tests.
3618
3619 2019-01-14  Charlie Turner  <cturner@igalia.com>
3620
3621         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3622         https://bugs.webkit.org/show_bug.cgi?id=192977
3623
3624         Reviewed by Carlos Garcia Campos.
3625
3626         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3627         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3628         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3629         (TestWebKitAPI::GStreamerTest::SetUp):
3630         (TestWebKitAPI::GStreamerTest::TearDown):
3631         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3632         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3633         (TestWebKitAPI::TEST_F):
3634
3635 2019-01-14  Charlie Turner  <cturner@igalia.com>
3636
3637         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3638         https://bugs.webkit.org/show_bug.cgi?id=193332
3639
3640         Reviewed by Michael Catanzaro.
3641
3642         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3643         defined as a char16_t, which changed in ICU 59, the
3644         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3645         unsigned short. This test is relying on the behaviour that
3646         UChar=unsigned short, which doesn't hold across platforms and ICU
3647         library versions. The full fix would be a special syntax for
3648         literal characters so that these ambiguities do not arise. That
3649         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3650         (TestWebKitAPI::TEST):
3651
3652 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3653
3654         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3655
3656         * Scripts/make-dist:
3657         (Distcheck.configure):
3658
3659 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3660
3661         [ews-build] Update macOS queue configurations
3662         https://bugs.webkit.org/show_bug.cgi?id=193365
3663         <rdar://problem/47221073>
3664
3665         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3666
3667         * BuildSlaveSupport/ews-build/config.json:
3668
3669 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3670
3671         [LFC] Adjust assert for statically positioned fixed elements
3672         https://bugs.webkit.org/show_bug.cgi?id=193385
3673
3674         Reviewed by Antti Koivisto.
3675
3676         * LayoutReloaded/misc/LFC-passing-tests.txt:
3677
3678 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3679
3680         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3681         https://bugs.webkit.org/show_bug.cgi?id=193387
3682
3683         Reviewed by Carlos Garcia Campos.
3684
3685         * MiniBrowser/wpe/main.cpp:
3686         (main):
3687
3688 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3689
3690         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3691         https://bugs.webkit.org/show_bug.cgi?id=191655
3692         rdar://problem/46074680
3693
3694         Reviewed by Megan Gardner.
3695
3696         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3697         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3698
3699 2019-01-12  Dan Bernstein  <mitz@apple.com>
3700
3701         [Cocoa] Avoid importing directly from subumbrella frameworks
3702         https://bugs.webkit.org/show_bug.cgi?id=186016
3703         <rdar://problem/40591038>
3704
3705         Reviewed by Sam Weinig.
3706
3707         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3708           LaunchServices header.
3709         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3710           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3711         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3712           when using SDKs earlier than 10.13.
3713         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3714           and OTHER_CPLUSPLUSFLAGS.
3715         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3716           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3717         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3718           LaunchServices header.
3719
3720 2019-01-11  John Wilander  <wilander@apple.com>
3721
3722         Compile out Web API Statistics Collection
3723         https://bugs.webkit.org/show_bug.cgi?id=193370
3724         <rdar://problem/45388584>
3725
3726         Reviewed by Brent Fulgham.
3727
3728         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3729             Defined ENABLE_WEB_API_STATISTICS, off by default.
3730
3731 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3732
3733         [WPE] Add gtk-doc
3734         https://bugs.webkit.org/show_bug.cgi?id=178900
3735
3736         Reviewed by Michael Catanzaro.
3737
3738         Add Tools/gtkdoc to manifest.txt.in files.
3739         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3740
3741         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3742         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3743
3744 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3745
3746         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3747         https://bugs.webkit.org/show_bug.cgi?id=193364
3748         <rdar://problem/47214117>
3749
3750         Reviewed by Tim Horton.
3751
3752         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3753         precise, whereas dragging near the middle of the textarea does.
3754
3755         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3756         (TestWebKitAPI::TEST):
3757
3758 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3759
3760         webkitpy: Support alternate simctl device list output
3761         https://bugs.webkit.org/show_bug.cgi?id=193362
3762         <rdar://problem/47122965>
3763
3764         Reviewed by Lucas Forschler.
3765
3766         * Scripts/webkitpy/xcode/simulated_device.py:
3767         (SimulatedDeviceManager.populate_available_devices):
3768
3769 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3770
3771         [ews-build] Update macOS queue configurations
3772         https://bugs.webkit.org/show_bug.cgi?id=193365
3773
3774         Reviewed by Lucas Forschler.
3775
3776         * BuildSlaveSupport/ews-build/config.json:
3777
3778 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3779
3780         webkitpy: Incorporate device type into baseline search path
3781         https://bugs.webkit.org/show_bug.cgi?id=193356
3782         <rdar://problem/47215515>
3783
3784         Reviewed by Lucas Forschler.
3785
3786         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3787
3788         * Scripts/webkitpy/port/base.py:
3789         (Port.default_baseline_search_path): Allow device type to be passed in.
3790         * Scripts/webkitpy/port/gtk.py:
3791         (GtkPort.default_baseline_search_path): Ignore device type.
3792         * Scripts/webkitpy/port/ios.py:
3793         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3794         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3795         * Scripts/webkitpy/port/ios_device_unittest.py:
3796         (IOSDeviceTest):
3797         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3798         (IOSSimulatorTest):
3799         * Scripts/webkitpy/port/mac.py:
3800         (MacPort.default_baseline_search_path): Ignore device type.
3801         * Scripts/webkitpy/port/watch.py:
3802         (WatchPort.default_baseline_search_path): Ditto.
3803         * Scripts/webkitpy/port/win.py:
3804         (WinPort.default_baseline_search_path): Ditto.
3805         (WinCairoPort.default_baseline_search_path): Ditto.
3806         * Scripts/webkitpy/port/wpe.py:
3807         (WPEPort.default_baseline_search_path): Ditto.
3808
3809 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3810
3811         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3812         https://bugs.webkit.org/show_bug.cgi?id=193352
3813         <rdar://problem/47210736>
3814
3815         Reviewed by Lucas Forschler.
3816
3817         * Scripts/webkitpy/layout_tests/views/printing.py:
3818         (Printer.print_config): Print list on only baseline search paths which exist. 
3819         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3820         (Testprinter.test_print_config):
3821
3822 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3823
3824         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3825         https://bugs.webkit.org/show_bug.cgi?id=193340
3826
3827         Reviewed by David Kilzer.
3828
3829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3830         (WTR::InjectedBundle::didReceiveMessageToPage):
3831         Pull the strings out into a WKRetainPtr.
3832
3833         * WebKitTestRunner/WebNotificationProvider.cpp:
3834         (WTR::WebNotificationProvider::closeWebNotification):
3835         Adopt the created value into the WKRetainPtr.
3836
3837         * WebKitTestRunner/mac/TestControllerMac.mm:
3838         (WTR::generateWhitelist):
3839         Immediately adopt a created value to avoid potential mistakes.
3840
3841 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3842
3843         Enable DFG on ARM/Linux again
3844         https://bugs.webkit.org/show_bug.cgi?id=192496
3845
3846         Reviewed by Yusuke Suzuki.
3847
3848         After changing the bytecode format DFG was disabled on all 32-bit
3849         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3850         on ARM by default.
3851
3852         * Scripts/run-jsc-stress-tests:
3853
3854 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3855
3856         Unreviewed, fix #ifdef in API test added in r239851.
3857         https://bugs.webkit.org/show_bug.cgi?id=193327
3858         rdar://problem/47093222
3859
3860         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3861
3862 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3863
3864         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3865         https://bugs.webkit.org/show_bug.cgi?id=193109
3866         <rdar://problem/44807048>
3867
3868         Reviewed by Ryosuke Niwa.
3869
3870         Introduce and respect a test option to enable the UndoManager API.
3871
3872         * WebKitTestRunner/TestController.cpp:
3873         (WTR::updateTestOptionsFromTestHeader):
3874         * WebKitTestRunner/TestOptions.h:
3875         (WTR::TestOptions::hasSameInitializationOptions const):
3876         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3877         (WTR::TestController::platformCreateWebView):
3878
3879 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3880
3881         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3882         https://bugs.webkit.org/show_bug.cgi?id=193346
3883
3884         Reviewed by Antti Koivisto.
3885
3886         * LayoutReloaded/misc/LFC-passing-tests.txt:
3887
3888 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3889
3890         Unreviewed, fix typo that breaks dashboard link.
3891
3892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3893         (WebKitBuildbot):
3894
3895 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3896
3897         Update macOS queue configurations
3898         https://bugs.webkit.org/show_bug.cgi?id=193329
3899
3900         Reviewed by Alexey Proskuryakov.
3901
3902         * BuildSlaveSupport/build.webkit.org-config/config.json:
3903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3904         (BubbleQueueServer):
3905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3907         (WebKitBuildbot):
3908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3909         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3910         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3911
3912 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3913
3914         MiniBrowser should be able to navigate to about:blank
3915         https://bugs.webkit.org/show_bug.cgi?id=193345
3916
3917         Reviewed by Simon Fraser.
3918
3919         * MiniBrowser/mac/BrowserWindowController.m:
3920         (-[BrowserWindowController addProtocolIfNecessary:]):
3921         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3922
3923         * MiniBrowser/mac/WK1BrowserWindowController.m:
3924         (-[WK1BrowserWindowController fetch:]):
3925         * MiniBrowser/mac/WK2BrowserWindowController.m:
3926         (-[WK2BrowserWindowController fetch:]):
3927         Clean up the code that uses this to match style.
3928
3929 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3930
3931         Remove MiniBrowser custom "Process Swap" menu item which does not work
3932         https://bugs.webkit.org/show_bug.cgi?id=193344
3933
3934         Reviewed by Simon Fraser.
3935
3936         There is a menu item under the Experimental menu that does work.
3937
3938         * MiniBrowser/mac/AppDelegate.m:
3939         (defaultConfiguration):
3940         * MiniBrowser/mac/SettingsController.h:
3941         * MiniBrowser/mac/SettingsController.m:
3942         (-[SettingsController _populateMenu]):
3943         (-[SettingsController validateMenuItem:]):
3944         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3945         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3946
3947 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3948
3949         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3950         https://bugs.webkit.org/show_bug.cgi?id=193327
3951         rdar://problem/47093222
3952
3953         Reviewed by Tim Horton.
3954
3955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3956         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3957         (TestWebKitAPI::didFinishNavigation):
3958         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3959         (TestWebKitAPI::TEST):
3960         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3961         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3962         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3963         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3964         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3965
3966 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3967
3968         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3969         https://bugs.webkit.org/show_bug.cgi?id=193338
3970         <rdar://problem/46664774>
3971
3972         Reviewed by David Kilzer.
3973
3974         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3975         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3976
3977 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3978
3979         Unreviewed, rolling out r239825.
3980         https://bugs.webkit.org/show_bug.cgi?id=193330
3981
3982         Broke tests on armv7/linux bots (Requested by guijemont on
3983         #webkit).
3984
3985         Reverted changeset:
3986
3987         "Enable DFG on ARM/Linux again"
3988         https://bugs.webkit.org/show_bug.cgi?id=192496
3989         https://trac.webkit.org/changeset/239825
3990
3991 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3992
3993         Disable the run-jsc-stress-test remote host key check.
3994         https://bugs.webkit.org/show_bug.cgi?id=192988
3995
3996         Reviewed by Alexey Proskuryakov.
3997
3998         * Scripts/run-jsc-stress-tests:
3999
4000 2019-01-10  John Wilander  <wilander@apple.com>
4001
4002         Override the session configuration for cookieAcceptPolicy
4003         https://bugs.webkit.org/show_bug.cgi?id=190925
4004         <rdar://problem/45497382>
4005
4006         Reviewed by Alexey Proskuryakov and Alex Christensen.
4007
4008         Test infrastructure for setting a first-party-only cookie policy.
4009
4010         * DumpRenderTree/TestRunner.cpp:
4011         (setOnlyAcceptFirstPartyCookiesCallback):
4012         (TestRunner::staticFunctions):
4013         * DumpRenderTree/TestRunner.h:
4014         * DumpRenderTree/mac/TestRunnerMac.mm:
4015         (TestRunner::setOnlyAcceptFirstPartyCookies):
4016         * DumpRenderTree/win/TestRunnerWin.cpp:
4017         (TestRunner::setOnlyAcceptFirstPartyCookies):
4018         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4019         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4020         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4021         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4022         * WebKitTestRunner/TestInvocation.cpp:
4023         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4024
4025 2019-01-09  Matt Rajca  <mrajca@apple.com>
4026
4027         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4028         https://bugs.webkit.org/show_bug.cgi?id=193301
4029
4030         Reviewed by Jer Noble.
4031         
4032         Added API tests.
4033
4034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4035         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4036         (TEST):
4037         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4038
4039 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4040
4041         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4042         https://bugs.webkit.org/show_bug.cgi?id=193310
4043
4044         Reviewed by Antti Koivisto.
4045
4046         * LayoutReloaded/misc/LFC-passing-tests.txt:
4047
4048 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
4049
4050         Enable DFG on ARM/Linux again
4051         https://bugs.webkit.org/show_bug.cgi?id=192496
4052
4053         Reviewed by Yusuke Suzuki.
4054
4055         After changing the bytecode format DFG was disabled on all 32-bit
4056         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4057         on ARM by default.
4058
4059         * Scripts/run-jsc-stress-tests:
4060
4061 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4062
4063         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
4064         https://bugs.webkit.org/show_bug.cgi?id=193271
4065
4066         Reviewed by Brent Fulgham.
4067
4068         BSTR is a special data structure created by SysAllocString, not a
4069         wchar_t null-terminated string.
4070
4071         * DumpRenderTree/win/TestRunnerWin.cpp:
4072         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
4073         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4074         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
4075         BSTR from wide string literals.
4076
4077 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
4078
4079         Tweak wording for build/version_check style checker error
4080         https://bugs.webkit.org/show_bug.cgi?id=193256
4081
4082         Reviewed by Tim Horton.
4083
4084         * Scripts/webkitpy/style/checkers/cpp.py:
4085         (check_os_version_checks):
4086         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4087         (WebKitStyleTest.test_os_version_checks):
4088
4089 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4090
4091         [ews-build] Add link to bug along with bug title
4092         https://bugs.webkit.org/show_bug.cgi?id=193293
4093
4094         Reviewed by Lucas Forschler.
4095
4096         * BuildSlaveSupport/ews-build/steps.py:
4097         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4098         (ConfigureBuild.add_bug_id_url): Deleted.
4099         (ConfigureBuild.getBugURL): Deleted.
4100
4101 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4102
4103         [ews-build] Use https for ews-build server
4104         https://bugs.webkit.org/show_bug.cgi?id=193193
4105
4106         Reviewed by Lucas Forschler.
4107
4108         * BuildSlaveSupport/ews-build/steps.py:
4109
4110 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4111
4112         [ews-build] Parse and display number of style failures
4113         https://bugs.webkit.org/show_bug.cgi?id=193280
4114
4115         Reviewed by Lucas Forschler.
4116
4117         * BuildSlaveSupport/ews-build/steps.py:
4118         (CheckStyle): Use TestWithFailureCount as base class.
4119         (CheckStyle.countFailures): Count the number of style failures.
4120
4121 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4122
4123         [ews-build] use patch_id instead of ewspatchid
4124         https://bugs.webkit.org/show_bug.cgi?id=193235
4125
4126         Reviewed by Lucas Forschler.
4127
4128         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4129         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4130         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4131
4132 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4133
4134         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4135         https://bugs.webkit.org/show_bug.cgi?id=192625
4136
4137         Reviewed by Antti Koivisto.
4138
4139         * LayoutReloaded/misc/LFC-passing-tests.txt:
4140
4141 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4142
4143         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4144         https://bugs.webkit.org/show_bug.cgi?id=192841
4145
4146         Reviewed by Carlos Garcia Campos.
4147
4148         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4149         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4150         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4151
4152         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4153
4154         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4155         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4156         (WebKitWebEditorTest::testSelectionChanged):
4157         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4158         (WebKitFrameTest::testMainFrame):
4159         (WebKitFrameTest::testURI):
4160         (WebKitFrameTest::testJavaScriptContext):
4161         (WebKitFrameTest::testJavaScriptValues):
4162         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4163         (testWebViewAuthenticationRequest):
4164         (testWebViewAuthenticationLoadCancelled):
4165         (testWebViewAuthenticationFailure):
4166         (testWebViewAuthenticationStorage):
4167         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4168         (testWebViewAuthenticationProxy):
4169         (testWebViewAuthenticationProxyHTTPS):
4170         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4171         (testAutomationSessionRequestSession):
4172         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4173         (testBackForwardListNavigation):
4174         (testWebKitWebViewSessionState):
4175         (testWebKitWebViewSessionStateWithFormData):
4176         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4177         (ConsoleMessageTest::consoleMessageReceivedCallback):
4178         (testWebKitConsoleMessageConsoleAPI):
4179         (testWebKitConsoleMessageJavaScriptException):
4180         (testWebKitConsoleMessageNetworkError):
4181         (testWebKitConsoleMessageSecurityError):
4182         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4183         (testCookieManagerAcceptPolicy):
4184         (testCookieManagerCookiesChanged):
4185         (testCookieManagerPersistentStorage):
4186         (testCookieManagerPersistentStorageDeleteAll):
4187         (testCookieManagerEphemeral):
4188         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4189         (testWebKitDOMElementAutoFill):
4190         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4191         (downloadLocalFileSuccessfully):
4192         (createFileAtDestination):
4193         (testDownloadOverwriteDestinationDisallowed):
4194         (testDownloadLocalFileError):
4195         (testDownloadRemoteFile):
4196         (testDownloadRemoteFileError):
4197         (testWebViewDownloadURI):
4198         (testPolicyResponseDownload):
4199         (testPolicyResponseDownloadCancel):
4200         (testDownloadMIMEType):
4201         (contextMenuCallback):
4202         (testContextMenuDownloadActions):
4203         (testBlobDownload):
4204         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4205         (testWebKitWebEditorSelectionChanged):
4206         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4207         (testWebKitFrameMainFrame):
4208         (testWebKitFrameURI):
4209         (testWebKitFrameJavaScriptContext):
4210         (testWebKitFrameJavaScriptValues):
4211         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4212         (LoadStopTrackingTest::loadFailed):
4213         (testWebViewTitle):
4214         (testURIRequestHTTPHeaders):
4215         (testURIRequestHTTPMethod):
4216         (testURIResponseHTTPHeaders):
4217         (testRedirectToDataURI):
4218         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4219         (testProcessPerWebView):
4220         (testWebProcessLimit):
4221         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4222         (testWebViewResources):
4223         (testWebResourceLoading):
4224         (testWebResourceSuggestedFilename):
4225         (testWebResourceGetData):
4226         (testWebResourceGetDataError):
4227         (testWebViewResourcesHistoryCache):
4228         (testWebResourceSendRequest):
4229         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4230         (testSSL):
4231         (testInsecureContent):
4232         (testTLSErrorsPolicy):
4233         (testTLSErrorsRedirect):
4234         (testTLSErrorsHTTPAuth):
4235         (testLoadFailedWithTLSErrors):
4236         (testSubresourceLoadFailedWithTLSErrors):
4237         (httpsServerCallback):
4238         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4239         (testWebViewCreateNavigationData):
4240         (testWebViewJavaScriptDialogs):
4241         (testWebViewWindowProperties):
4242         (testWebViewMouseTarget):
4243         (testWebViewFileChooserRequest):
4244         (testWebViewColorChooserRequest):
4245         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4246         (testWebExtensionGetTitle):
4247         (testDocumentLoadedSignal):
4248         (testWebKitWebViewProcessCrashed):
4249         (testWebExtensionWindowObjectCleared):
4250         (testWebExtensionIsolatedWorld):
4251         (permissionRequestCallback):
4252         (didAssociateFormControlsCallback):
4253         (testWebExtensionFormControlsAssociated):
4254         (FormSubmissionTest::FormSubmissionTest):
4255         (FormSubmissionTest::testFormSubmissionResult):
4256         (testWebExtensionFormSubmissionSteps):
4257         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4258         (testNotInitialized):
4259         (testClearDatabase):
4260         (testPrivateBrowsing):
4261         (testGetFavicon):
4262         (testWebViewFavicon):
4263         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4264         (testFindControllerTextFound):
4265         (testFindControllerTextNotFound):
4266         (testFindControllerMatchCount):
4267         (testFindControllerMaxMatchCount):
4268         (testFindControllerNext):
4269         (testFindControllerPrevious):
4270         (testFindControllerCountedMatches):
4271         (testFindControllerOptions):
4272         (testFindControllerHide):
4273         (testFindControllerInstance):
4274         (testFindControllerGetters):
4275         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4276         (testNavigationPolicy):
4277         (testResponsePolicy):
4278         (testNewWindowPolicy):
4279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4280         (testSecurityOriginBasicConstructor):
4281         (testSecurityOriginURIConstructor):
4282         (testSecurityOriginDefaultPort):
4283         (testSecurityOriginFileURI):
4284         (testOpaqueSecurityOrigin):
4285         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4286         (testWebKitSettings):
4287         (testWebKitSettingsNewWithSettings):
4288         (testWebKitSettingsUserAgent):
4289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4290         (testWebViewNewWithUserContentManager):
4291         (isStyleSheetInjectedForURLAtPath):
4292         (isScriptInjectedForURLAtPath):
4293         (testUserContentManagerInjectedStyleSheet):
4294         (testUserContentManagerInjectedScript):
4295         (UserScriptMessageTest::scriptMessageReceived):
4296         (UserScriptMessageTest::waitUntilMessageReceived):
4297         (UserScriptMessageTest::runJavaScriptFinished):
4298         (testUserContentManagerScriptMessageReceived):
4299         (testUserContentManagerScriptMessageInWorldReceived):
4300         (testUserContentManagerScriptMessageFromDOMBindings):
4301         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4302         (testWebContextDefault):
4303         (testWebContextEphemeral):
4304         (testWebContextGetPlugins):
4305         (testWebContextURIScheme):
4306         (testWebContextSpellChecker):
4307         (testWebContextLanguages):
4308         (consoleMessageReceivedCallback):
4309         (testWebContextSecurityFileXHR):
4310         (ProxyTest::ProxyTest):
4311         (testWebContextProxySettings):
4312         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4313         (testWebViewWebContext):
4314         (testWebViewWebBackend):
4315         (testWebViewEphemeral):
4316         (testWebViewCustomCharset):
4317         (testWebViewSettings):
4318         (testWebViewRunJavaScript):
4319         (testWebViewCanShowMIMEType):
4320         (testWebViewSubmitForm):
4321         (testWebViewSave):
4322         (testWebViewPageVisibility):
4323         (testWebViewSnapshot):
4324         (testWebViewNotification):
4325         (testWebViewNotificationInitialPermissionAllowed):
4326         (testWebViewNotificationInitialPermissionDisallowed):
4327         (testWebViewIsPlayingAudio):
4328         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4329         (WebsiteDataTest::WebsiteDataTest):
4330         (WebsiteDataTest::remove):
4331         (WebsiteDataTest::clear):
4332         (testWebsiteDataConfiguration):
4333         (testWebsiteDataEphemeral):
4334         (testWebsiteDataCache):
4335         (testWebsiteDataStorage):
4336         (testWebsiteDataDatabases):
4337         (testWebsiteDataAppcache):
4338