Add a unit test for client certificate authentication
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-14  Alex Christensen  <achristensen@webkit.org>
2
3         Add a unit test for client certificate authentication
4         https://bugs.webkit.org/show_bug.cgi?id=197800
5
6         Reviewed by Youenn Fablet.
7
8         Make better abstractions for reading and writing from/to TCPServer.
9         Add a unit test that causes a client certificate authentication challenge to happen.
10
11         * TestWebKitAPI/TCPServer.cpp:
12         (TestWebKitAPI::TCPServer::TCPServer):
13         (TestWebKitAPI::TCPServer::read):
14         (TestWebKitAPI::TCPServer::write):
15         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
16         (TestWebKitAPI::TCPServer::respondWithOK):
17         * TestWebKitAPI/TCPServer.h:
18         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
19         (credentialWithIdentity):
20         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
21         (TEST):
22         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
23         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
24         (-[ClientCertificateDelegate challengeCount]):
25         (TestWebKitAPI::TEST):
26         (respondWithChallengeThenOK): Deleted.
27         (credentialWithIdentityAndKeychainPath): Deleted.
28         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
29         (TEST):
30         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
31         (TestWebKitAPI::TEST):
32         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
33         (TEST):
34         (readRequest): Deleted.
35         (writeResponse): Deleted.
36         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
37         (TestWebKitAPI::TEST):
38         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
39
40 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
41
42         [CG] Adding support for HEIF-sequence ('public.heics') images
43         https://bugs.webkit.org/show_bug.cgi?id=197384
44
45         Reviewed by Simon Fraser.
46
47         * DumpRenderTree/TestOptions.cpp:
48         (TestOptions::TestOptions):
49         * DumpRenderTree/TestOptions.h:
50         * DumpRenderTree/mac/DumpRenderTree.mm:
51         (resetWebViewToConsistentStateBeforeTesting):
52         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
53         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
54         the test.
55
56         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
57         (WTR::InjectedBundle::stringForKey):
58         (WTR::InjectedBundle::beginTesting):
59         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
60         * WebKitTestRunner/TestController.cpp:
61         (WTR::TestController::resetStateToConsistentValues):
62         (WTR::updateTestOptionsFromTestHeader):
63         * WebKitTestRunner/TestInvocation.cpp:
64         (WTR::TestInvocation::createTestSettingsDictionary):
65         * WebKitTestRunner/TestOptions.h:
66         (WTR::TestOptions::hasSameInitializationOptions const):
67         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
68         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
69         the test.
70
71 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
72
73         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
74         https://bugs.webkit.org/show_bug.cgi?id=197730
75
76         Reviewed by Filip Pizlo.
77
78         * TestWebKitAPI/CMakeLists.txt:
79         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
80         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
81         (TestWebKitAPI::TEST):
82         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
83         (TestWebKitAPI::TEST):
84
85 2019-05-10  Chris Dumez  <cdumez@apple.com>
86
87         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
88
89         It became flaky after r245198.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
92
93 2019-05-10  Youenn Fablet  <youenn@apple.com>
94
95         A service worker instance should be terminated when its SWServer is destroyed
96         https://bugs.webkit.org/show_bug.cgi?id=197801
97         <rdar://problem/50587270>
98
99         Reviewed by Chris Dumez.
100
101         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
102
103 2019-05-10  Chris Dumez  <cdumez@apple.com>
104
105         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
106         https://bugs.webkit.org/show_bug.cgi?id=197750
107
108         Reviewed by Geoffrey Garen.
109
110         Add API test coverage.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
113         (TEST):
114
115 2019-05-10  Keith Miller  <keith_miller@apple.com>
116
117         Remove legacy test262 import script
118         https://bugs.webkit.org/show_bug.cgi?id=197788
119
120         Reviewed by Yusuke Suzuki.
121
122         import-test262-tests doesn't work anymore. We should be using test262-import instead.
123
124         * Scripts/import-test262-tests: Removed.
125
126 2019-05-10  Charlie Turner  <cturner@igalia.com>
127
128         [WPE] Forward libepoxy cflags
129         https://bugs.webkit.org/show_bug.cgi?id=197784
130
131         Reviewed by Žan Doberšek.
132
133         Patch by Zan Dobersek.
134
135         * wpe/backends/CMakeLists.txt: This is required to keep
136         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
137         up trying to include X11 headers even when they're not present in the
138         environment.
139
140 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
141
142         Fix a bunch of compiler warnings
143         https://bugs.webkit.org/show_bug.cgi?id=197785
144
145         Reviewed by Don Olmstead.
146
147         Add preprocessor guards to avoid -Wunused-function warnings.
148
149         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
150         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
151         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
152
153 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
154
155         [WPE][GTK] Add webkit_frame_get_id() API
156         https://bugs.webkit.org/show_bug.cgi?id=197270
157
158         Reviewed by Carlos Garcia Campos.
159
160         This was hard, but I added a test to verify that two different WebKitFrames of the same
161         WebKitWebPage return two different frame IDs.
162
163         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
164         (WebKitFrameTest::willSubmitFormCallback):
165         (WebKitFrameTest::testSubframe):
166         (registerTests):
167         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
168         (testWebKitFrameSubframe):
169         (beforeAll):
170         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
171         (willSubmitFormCallback):
172         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
173         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
174
175 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
176
177         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
178         https://bugs.webkit.org/show_bug.cgi?id=197271
179
180         Reviewed by Youenn Fablet.
181
182         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
183         (formControlsAssociatedForFrameCallback):
184         (pageCreatedCallback):
185         (formControlsAssociatedCallback): Deleted.
186
187 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
188
189         [Flatpak] Use the safe PyYAML loader if available
190         https://bugs.webkit.org/show_bug.cgi?id=197771
191
192         Reviewed by Philippe Normand.
193
194         * flatpak/flatpakutils.py:
195         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
196         still used as fallback when the former is not provided by the module.
197
198 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
199
200         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
201         https://bugs.webkit.org/show_bug.cgi?id=197734
202
203         Reviewed by Don Olmstead.
204
205         * Scripts/webkitpy/port/win.py:
206         (WinCairoPort._search_paths): Add 'wk2' and
207         additional_platform_directory to paths as well as other ports do.
208
209 2019-05-09  Daniel Bates  <dabates@apple.com>
210
211         [iOS] Numpad comma key has incorrect keyIdentifier property
212         https://bugs.webkit.org/show_bug.cgi?id=197753
213         <rdar://problem/50636274>
214
215         Reviewed by Brent Fulgham.
216
217         Recognize "numpadComma" and return the appropriate HID usage code.
218
219         * WebKitTestRunner/ios/HIDEventGenerator.mm:
220         (hidUsageCodeForCharacter):
221
222 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
223
224         Refine AudioSession route sharing policy
225         https://bugs.webkit.org/show_bug.cgi?id=197742
226         <rdar://problem/50590818>
227
228         Reviewed by Darin Adler.
229
230         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
231         (TestWebKitAPI::TEST):
232
233 2019-05-09  Alex Christensen  <achristensen@webkit.org>
234
235         Remove unnecessary test SPI after r244883
236         https://bugs.webkit.org/show_bug.cgi?id=197575
237
238         Reviewed by Tim Horton.
239
240         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
241         (TEST):
242         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
243         (TestWebKitAPI::TEST):
244
245 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
246
247         [ews-app] Add migrations file to repository
248         https://bugs.webkit.org/show_bug.cgi?id=197729
249
250         Reviewed by Jonathan Bedard.
251
252         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
253
254 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
255
256         [ews-build] Fix formatting issues and typos
257         https://bugs.webkit.org/show_bug.cgi?id=197737
258
259         Reviewed by Jonathan Bedard.
260
261         * BuildSlaveSupport/ews-build/steps.py:
262         (CompileWebKit.evaluateCommand): Removed extra empty line.
263         * BuildSlaveSupport/ews-build/steps_unittest.py:
264         (TestRunWebKitPerlTests): Fixed typo.
265         * BuildSlaveSupport/ews-app/ews/models/step.py:
266         (Step.save_step): Changed log level to info so that it is logged in production.
267
268 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
269
270         [ews-app] Production and Development env should configure DEBUG appropriately
271         https://bugs.webkit.org/show_bug.cgi?id=197700
272
273         Reviewed by Jonathan Bedard.
274
275         * BuildSlaveSupport/ews-app/ews-app/settings.py:
276
277 2019-05-09  Xan López  <xan@igalia.com>
278
279         [CMake] Detect SSE2 at compile time
280         https://bugs.webkit.org/show_bug.cgi?id=196488
281
282         Reviewed by Carlos Garcia Campos.
283
284         * Scripts/webkitdirs.pm:
285         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
286         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
287
288 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
289
290         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
291         https://bugs.webkit.org/show_bug.cgi?id=197697
292
293         Reviewed by Žan Doberšek.
294
295         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
296         * wpe/jhbuild.modules: Ditto.
297
298 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
299
300         Update ANGLE
301         https://bugs.webkit.org/show_bug.cgi?id=197676
302
303         Reviewed by Alex Christensen.
304
305         * TestWebKitAPI/PlatformWin.cmake:
306         Remove unnecessary library linkage.
307
308 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
309
310         [Win] build-webkit should be ready for Visual Studio 2019
311         https://bugs.webkit.org/show_bug.cgi?id=196622
312
313         Reviewed by Ross Kirsling.
314
315         1. Accommodated to the new msbuild.exe location of VS 2019.
316         2. Removed the hard coded "Visual Studio 15" generator.
317
318         build-webkit is going to choose a Visual Studio generator version
319         matching with the latest installed VS. If you invoke vcvars.bat
320         before build-webkit, it chooses the corresponding Visual Studio
321         generator version by cheking 'VisualStudioVersion' env var which
322         is set by vcvars.bat.
323
324         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
325         (msBuildPath): When looking for MSBuild, look in
326         "MSBuild\Current\bin" (the new expected location) and fallback
327         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
328         first location.
329         (msBuildInstallDir): Renamed to msBuildPath.
330         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
331         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
332
333 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
334
335         [PlayStation] Update port options
336         https://bugs.webkit.org/show_bug.cgi?id=197723
337
338         Reviewed by Ross Kirsling.
339
340         ICU headers were missing from TestWTF.
341
342         * TestWebKitAPI/PlatformPlayStation.cmake:
343
344 2019-05-08  Alex Christensen  <achristensen@webkit.org>
345
346         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
347         https://bugs.webkit.org/show_bug.cgi?id=197712
348         <rdar://problem/50429770>
349
350         Reviewed by Tim Horton.
351
352         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
353         (TestWebKitAPI::TEST):
354
355 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
356
357         Change my status to be a WebKit reviewer.
358
359         * Scripts/webkitpy/common/config/contributors.json:
360
361 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
362
363         Unreviewed, rolling out r244952.
364
365         Caused inspector to appear blank.
366
367         Reverted changeset:
368
369         "Web Inspector: Provide UIString descriptions to improve
370         localizations"
371         https://bugs.webkit.org/show_bug.cgi?id=195132
372         https://trac.webkit.org/changeset/244952
373
374 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
375
376         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
377         https://bugs.webkit.org/show_bug.cgi?id=197685
378
379         Reviewed by Alex Christensen.
380
381         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
382         completion. See LayoutTests/ChangeLog for more details.
383
384         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
385         (WTR::UIScriptController::platformClearAllCallbacks):
386
387 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
388
389         Unreviewed. Add myself as a committer.
390
391         * Scripts/webkitpy/common/config/contributors.json:
392
393 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
394
395         Unreviewed, rolling out r245038.
396
397         Breaks internal builds.
398
399         Reverted changeset:
400
401         "Add SPI to set a list of hosts to which to send custom header
402         fields cross-origin"
403         https://bugs.webkit.org/show_bug.cgi?id=197397
404         https://trac.webkit.org/changeset/245038
405
406 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
407
408         Unreviewed. Add myself as a committer.
409
410         * Scripts/webkitpy/common/config/contributors.json:
411
412 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
413
414         Define media buffering policy
415         https://bugs.webkit.org/show_bug.cgi?id=196979
416         <rdar://problem/28383861>
417
418         Reviewed by Jer Noble.
419
420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
421         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
422         (waitUntilBufferingPolicyIsEqualTo):
423         (TEST):
424
425 2019-05-07  Alex Christensen  <achristensen@webkit.org>
426
427         Add SPI to set a list of hosts to which to send custom header fields cross-origin
428         https://bugs.webkit.org/show_bug.cgi?id=197397
429
430         Reviewed by Geoff Garen.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
433         (TEST):
434         (expectLegacyHeaders):
435         (expectHeaders):
436         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
437         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
438         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
439
440 2019-05-07  Keith Rollin  <krollin@apple.com>
441
442         Add option to build-webkit to control whether or not XCBuild is used
443         https://bugs.webkit.org/show_bug.cgi?id=197668
444         <rdar://problem/50549728>
445
446         Reviewed by Tim Horton.
447
448         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
449         Also update build-webkit and the makefiles with the foundation for
450         automatically using XCBuild when the conditions allow it. This latter
451         facility is currently turned off until Xcode fully supports building
452         WebKit with XCBuild.
453
454         * Scripts/build-webkit:
455         * Scripts/webkitdirs.pm:
456         (XcodeOptions):
457         (canUseXCBuild):
458
459 2019-05-07  Andy Estes  <aestes@apple.com>
460
461         run-bindings-tests should test global scope constructor generation
462         https://bugs.webkit.org/show_bug.cgi?id=197669
463
464         Reviewed by Alex Christensen.
465
466         * Scripts/webkitpy/bindings/main.py:
467         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
468         invoking preprocess-idls.pl.
469
470 2019-05-07  Youenn Fablet  <youenn@apple.com>
471
472         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
473         https://bugs.webkit.org/show_bug.cgi?id=195997
474         <rdar://problem/50509884>
475
476         Reviewed by Chris Dumez.
477
478         Spin test until successful.
479
480         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
481
482 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
483
484         [Flatpak] webkit-build fails due to missing GTK2 in build environment
485         https://bugs.webkit.org/show_bug.cgi?id=197352
486
487         Reviewed by Philippe Normand.
488
489         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
490         to build it ourselves on top in order to be able to build the GTK 2.x plugin
491         process.
492
493         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
494
495 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
498         https://bugs.webkit.org/show_bug.cgi?id=197644
499         <rdar://problem/50526364>
500
501         Reviewed by Tim Horton.
502
503         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
504
505         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
506         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
507         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
508         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
509
510 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
511
512         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
513         https://bugs.webkit.org/show_bug.cgi?id=197651
514
515         Reviewed by Žan Doberšek.
516
517         This is required since the process creation was delayed until something is loaded in the view.
518
519         * MiniBrowser/gtk/BrowserWindow.c:
520         (browser_window_get_or_create_web_view_for_automation):
521         * MiniBrowser/wpe/main.cpp:
522         (main):
523
524 2019-05-06  Tim Horton  <timothy_horton@apple.com>
525
526         _overrideViewportWithArguments does not work when called before loading
527         https://bugs.webkit.org/show_bug.cgi?id=197638
528         <rdar://problem/50505111>
529
530         Reviewed by Wenson Hsieh.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
533         (TEST):
534
535 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
536
537         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
538         https://bugs.webkit.org/show_bug.cgi?id=197510
539
540         Reviewed by Alex Christensen.
541
542         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
543         (TestWebKitAPI::TEST):
544
545 2019-05-06  Keith Rollin  <krollin@apple.com>
546
547         Temporarily disable generate-xcfilelists
548         https://bugs.webkit.org/show_bug.cgi?id=197619
549         <rdar://problem/50507392>
550
551         Reviewed by Alex Christensen.
552
553         We need to perform a significant update to the generate-xcfilelist
554         scripts. This work involves coordinated work with another facility. If
555         the work does not occur in tandem, the build will be broken. To avoid
556         this, disable the invoking of the scripts during the transition. The
557         checking will be restored once the new scripts are in place.
558
559         * DumpRenderTree/Scripts/check-xcfilelists.sh:
560         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
561
562 2019-05-04  Alex Christensen  <achristensen@webkit.org>
563
564         Revert r244953 and r244954 because they broke internal builds.
565         https://bugs.webkit.org/show_bug.cgi?id=197534
566
567         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
568         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
569         * DumpRenderTree/mac/DumpRenderTree.mm:
570         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
571         * DumpRenderTree/mac/TestRunnerMac.mm:
572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
573         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
574         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
575         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
576         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
577         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
578         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
579         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
580         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
581         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
582         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
583         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
584         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
585         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
586         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
587         * TestWebKitAPI/cocoa/TestWKWebView.mm:
588         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
589         * TestWebKitAPI/ios/UIKitSPI.h: Added.
590         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
591         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
592         * WebKitTestRunner/ios/HIDEventGenerator.h:
593         * WebKitTestRunner/ios/HIDEventGenerator.mm:
594         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
595         * WebKitTestRunner/ios/TestControllerIOS.mm:
596         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
597         * WebKitTestRunner/ios/mainIOS.mm:
598
599 2019-05-04  Alex Christensen  <achristensen@webkit.org>
600
601         Merge the three UIKitSPI.h files into a single one in PAL
602         https://bugs.webkit.org/show_bug.cgi?id=197534
603
604         Reviewed by Darin Adler.
605
606         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
607         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
608         * DumpRenderTree/mac/DumpRenderTree.mm:
609         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
610         * DumpRenderTree/mac/TestRunnerMac.mm:
611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
612         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
613         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
614         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
615         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
616         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
617         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
618         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
619         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
620         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
621         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
622         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
623         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
624         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
625         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
626         * TestWebKitAPI/cocoa/TestWKWebView.mm:
627         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
628         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
629         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
630         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
631         * WebKitTestRunner/ios/HIDEventGenerator.h:
632         * WebKitTestRunner/ios/HIDEventGenerator.mm:
633         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
634         * WebKitTestRunner/ios/TestControllerIOS.mm:
635         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
636         * WebKitTestRunner/ios/mainIOS.mm:
637
638 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
639
640         Web Inspector: Provide UIString descriptions to improve localizations
641         https://bugs.webkit.org/show_bug.cgi?id=195132
642         <rdar://problem/48457817>
643
644         Reviewed by Devin Rousso.
645
646         Allow WI.UIString to take:
647         - WI.UIString(string, key, comment)
648         - WI.UIString(string, comment)
649         - WI.UIString(string)
650
651         * Scripts/extract-localizable-js-strings:
652
653 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
654
655         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
656         https://bugs.webkit.org/show_bug.cgi?id=197579
657
658         Reviewed by Tim Horton.
659
660         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
661         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
662         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
663         ensure that the the focused element has been blurred.
664
665         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
666
667 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
668
669         Add a tool to block spammer accounts
670         https://bugs.webkit.org/show_bug.cgi?id=197537
671
672         Reviewed by Darin Adler.
673
674         Usage: block-spammers email1 email2 ...
675
676         The tool finds and hides all bugs and comments from this account. Before any work
677         is done, these bugs and comments are displayed for confirmation.
678
679         * Scripts/block-spammers: Added.
680         (get_bugzilla_token):
681         (invalidate_bugzilla_token):
682         (get_user_info):
683         (get_user_info_self):
684         (can_use_this_tool):
685         (disable_user):
686         (get_bugs_created_by_user):
687         (get_bugs_commented_on_by_user):
688         (get_comments):
689         (hide_bug):
690         (hide_comments):
691         (ask_yes_no):
692         (sanitized_string):
693         (main):
694
695 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
696
697         run-apit-tests: Add --iterations and --repeat-each
698         https://bugs.webkit.org/show_bug.cgi?id=197563
699
700         Reviewed by Aakash Jain.
701
702         * Scripts/webkitpy/api_tests/manager.py:
703         (Manager.run): Add --iterations and --repeat-each/
704         * Scripts/webkitpy/api_tests/run_api_tests.py:
705         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
706
707 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
708
709         New EWS: Clicking on white bubble navigates to page with only bubbles
710         https://bugs.webkit.org/show_bug.cgi?id=197520
711
712         Reviewed by Lucas Forschler.
713
714         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
715
716 2019-05-03  Daniel Bates  <dabates@apple.com>
717
718         [lldb-webkit] Support adding pretty-printing for qualified types
719         https://bugs.webkit.org/show_bug.cgi?id=197518
720
721         Reviewed by Darin Adler.
722
723         Remove all "::"s from the name of the specified type when computing the name for the Python classes
724         that will provide summary and synthetic details as LLDB is not happy about registering such classes
725         when they contain :: in their name.
726
727         * lldb/lldb_webkit.py:
728         (addSummaryAndSyntheticFormattersForRawBitmaskType):
729
730 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
731
732         New EWS: patches on recently added queues listed as #1 for older bugs
733         https://bugs.webkit.org/show_bug.cgi?id=197496
734
735         Reviewed by Lucas Forschler.
736
737         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
738         (StatusBubble._build_bubble):
739         (StatusBubble._queue_position):
740
741 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
742
743         webkit-patch --no-review upload does not submit patch to New EWS
744         https://bugs.webkit.org/show_bug.cgi?id=197519
745         <rdar://problem/50424887>
746
747         Reviewed by Lucas Forschler.
748
749         * Scripts/webkitpy/tool/steps/submittoews.py:
750         (SubmitToEWS.run): Submit to both old and new EWS.
751         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
752         * Scripts/webkitpy/common/net/ewsserver.py: Added.
753         (EWSServer._server_url): Method to return server url.
754         (EWSServer._post_patch_to_ews): Method to post patch to ews.
755         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
756         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
757         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
758         * Scripts/webkitpy/common/net/statusserver_mock.py:
759         (MockStatusServer.submit_to_ews): Updated the log text.
760         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
761         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
762         * Scripts/webkitpy/tool/main.py:
763         (WebKitPatch.__init__): Initialize ews_server. 
764         * Scripts/webkitpy/tool/mocktool.py:
765         (MockTool.__init__): Ditto.
766
767 2019-05-03  Chris Dumez  <cdumez@apple.com>
768
769         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
770         https://bugs.webkit.org/show_bug.cgi?id=197574
771         <rdar://problem/50453181>
772
773         Reviewed by Tim Horton.
774
775         Add API test coverage.
776
777         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
778         (TEST):
779
780 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
781
782         [JSC] Generator CodeBlock generation should be idempotent
783         https://bugs.webkit.org/show_bug.cgi?id=197552
784
785         Reviewed by Keith Miller.
786
787         * Scripts/run-javascriptcore-tests:
788         (runJSCStressTests):
789         * Scripts/run-jsc-stress-tests:
790
791 2019-05-03  Commit Queue  <commit-queue@webkit.org>
792
793         Unreviewed, rolling out r244881.
794         https://bugs.webkit.org/show_bug.cgi?id=197559
795
796         Breaks compilation of jsconly on linux, breaking compilation
797         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
798         guijemont on #webkit).
799
800         Reverted changeset:
801
802         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
803         WEBKIT_COPY_FILES"
804         https://bugs.webkit.org/show_bug.cgi?id=197174
805         https://trac.webkit.org/changeset/244881
806
807 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
808
809         Unreviewed WPE build fix after r244898.
810
811         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
812         (WTR::TestController::abortModal): Add the missing (no-op) definition.
813
814 2019-05-02  Alex Christensen  <achristensen@webkit.org>
815
816         Mark U+01C0 as a homograph of U+006C
817         https://bugs.webkit.org/show_bug.cgi?id=197526
818         <rdar://problem/50301904>
819
820         Reviewed by Tim Horton.
821
822         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
823         (TestWebKitAPI::TEST):
824
825 2019-05-02  Chris Dumez  <cdumez@apple.com>
826
827         Add test coverage for <rdar://problem/49731231>
828         https://bugs.webkit.org/show_bug.cgi?id=196730
829         <rdar://problem/49731231>
830
831         Reviewed by Ryosuke Niwa.
832
833         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
834         to match DumpRenderTree.
835
836         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
837         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
838         (WTR::TestRunner::abortModal):
839         * WebKitTestRunner/InjectedBundle/TestRunner.h:
840         * WebKitTestRunner/TestController.cpp:
841         (WTR::TestController::runModal):
842         * WebKitTestRunner/TestController.h:
843         * WebKitTestRunner/TestInvocation.cpp:
844         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
845         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
846         (WTR::TestController::abortModal):
847         * WebKitTestRunner/ios/TestControllerIOS.mm:
848         (WTR::TestController::abortModal):
849         * WebKitTestRunner/mac/TestControllerMac.mm:
850         (WTR::TestController::abortModal):
851         * WebKitTestRunner/win/TestControllerWin.cpp:
852         (WTR::TestController::abortModal):
853
854 2019-05-02  Christopher Reid  <chris.reid@sony.com>
855
856         [CMake] Add support for LTO builds
857         https://bugs.webkit.org/show_bug.cgi?id=188986
858
859         Reviewed by Don Olmstead.
860
861         Add support to configure --lto-mode with cmake builds.
862
863         * Scripts/build-webkit:
864         * Scripts/webkitdirs.pm:
865         (generateBuildSystemFromCMakeProject):
866
867 2019-05-02  John Wilander  <wilander@apple.com>
868
869         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
870         https://bugs.webkit.org/show_bug.cgi?id=197521
871         <rdar://problem/49651503>
872
873         Reviewed by Brent Fulgham.
874
875         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
876         (TestWebKitAPI::TEST):
877            Added a test for host strings with leading dots since they are
878            often used for the domain attribute in cookies.
879
880 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
881
882         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
883         https://bugs.webkit.org/show_bug.cgi?id=197510
884
885         Reviewed by Alex Christensen.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
888         (TestWebKitAPI::TEST):
889
890 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
891
892         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
893         https://bugs.webkit.org/show_bug.cgi?id=197174
894
895         Reviewed by Alex Christensen.
896
897         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
898
899         * TestWebKitAPI/PlatformGTK.cmake:
900         * TestWebKitAPI/PlatformWPE.cmake:
901
902 2019-05-02  Alex Christensen  <achristensen@webkit.org>
903
904         Build fix for internal branch.
905
906         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
907         RetainPtr.h was not explicitly included.
908
909 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
910
911         webkitpy: Ignore errors when shutting down an already shutdown simulator
912         <https://bugs.webkit.org/show_bug.cgi?id=197514>
913         <rdar://problem/50390247>
914
915         Reviewed by Lucas Forschler.
916
917         * Scripts/webkitpy/xcode/simulated_device.py:
918         (SimulatedDevice._shut_down):
919
920 2019-05-02  Frederic Wang  <fwang@igalia.com>
921
922         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
923         https://bugs.webkit.org/show_bug.cgi?id=196142
924
925         This patch introduces some experimental runtime flag to let users
926         disable MathML features that are removed from MathML Core [1]. For now,
927         these features are only disabled on GTK and WPE ports.
928
929         [1] https://mathml-refresh.github.io/mathml-core/
930
931         Reviewed by Rob Buis.
932
933         * DumpRenderTree/TestOptions.cpp:
934         (TestOptions::TestOptions):
935         * DumpRenderTree/TestOptions.h:
936         * DumpRenderTree/mac/DumpRenderTree.mm:
937         (setWebPreferencesForTestOptions):
938
939 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
940
941         TestWebKitAPI config.h should be aware of what suite is being built
942         https://bugs.webkit.org/show_bug.cgi?id=196583
943
944         Reviewed by Konstantin Tokarev.
945
946         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
947         benefit the macro defines BUILDING_* for the executable which allows the includes
948         of the config.h to be tailored to the test suite being built. Because of that the
949         dependencies of the Test* executable are specific to the test suite which may
950         speed up the build.
951
952         Some source files were including "PlatformUtilities.h" which includes WebKit headers
953         when "Utilities.h" is what was needed.
954
955         * TestWebKitAPI/CMakeLists.txt:
956         * TestWebKitAPI/PlatformGTK.cmake:
957         * TestWebKitAPI/PlatformJSCOnly.cmake:
958         * TestWebKitAPI/PlatformMac.cmake:
959         * TestWebKitAPI/PlatformPlayStation.cmake:
960         * TestWebKitAPI/PlatformUtilities.h:
961         * TestWebKitAPI/PlatformWPE.cmake:
962         * TestWebKitAPI/PlatformWin.cmake:
963         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
964         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
965         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
966         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
967         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
968         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
969         * TestWebKitAPI/config.h:
970
971 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
972
973         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
974         https://bugs.webkit.org/show_bug.cgi?id=181950
975         <rdar://problem/43357371>
976
977         Reviewed by Brent Fulgham.
978
979         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
980         (TestWebKitAPI::TEST_F):
981
982 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
983
984         Remove webkitpy and bindings EWS queues from dashboard
985         https://bugs.webkit.org/show_bug.cgi?id=197475
986
987         Reviewed by Alexey Proskuryakov.
988
989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
990
991 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
992
993         Remove webkitpy and bindings test queues from old EWS
994         https://bugs.webkit.org/show_bug.cgi?id=197468
995
996         Reviewed by Alexey Proskuryakov.
997
998         * QueueStatusServer/config/queues.py:
999
1000 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1001
1002         Fix the WebKitTestRunner build
1003         https://bugs.webkit.org/show_bug.cgi?id=197449
1004         <rdar://problem/50334169>
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * WebKitTestRunner/mac/EventSenderProxy.mm:
1009         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1010         (WTR::EventSenderProxy::mouseForceChanged):
1011         Use some SPI instead of IPI.
1012
1013 2019-04-30  Chris Dumez  <cdumez@apple.com>
1014
1015         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1016         https://bugs.webkit.org/show_bug.cgi?id=197426
1017         <rdar://problem/50256169>
1018
1019         Reviewed by Brady Eidson.
1020
1021         Add API test coverage.
1022
1023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1024         (-[PSONScheme setShouldRespondAsynchronously:]):
1025         (-[PSONScheme webView:startURLSchemeTask:]):
1026         (-[PSONScheme webView:stopURLSchemeTask:]):
1027
1028 2019-04-30  Chris Dumez  <cdumez@apple.com>
1029
1030         Unreviewed, rolling out r244802.
1031
1032         Caused an API test failure
1033
1034         Reverted changeset:
1035
1036         "Regression(PSON) URL scheme handlers can no longer respond
1037         asynchronously"
1038         https://bugs.webkit.org/show_bug.cgi?id=197426
1039         https://trac.webkit.org/changeset/244802
1040
1041 2019-04-30  Chris Dumez  <cdumez@apple.com>
1042
1043         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1044         https://bugs.webkit.org/show_bug.cgi?id=197426
1045         <rdar://problem/50256169>
1046
1047         Reviewed by Brady Eidson.
1048
1049         Add API test coverage.
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1052         (-[PSONScheme setShouldRespondAsynchronously:]):
1053         (-[PSONScheme webView:startURLSchemeTask:]):
1054         (-[PSONScheme webView:stopURLSchemeTask:]):
1055
1056 2019-04-30  Chris Dumez  <cdumez@apple.com>
1057
1058         Only use a related page's process if that page has not been closed yet
1059         https://bugs.webkit.org/show_bug.cgi?id=197393
1060         <rdar://problem/50302423>
1061
1062         Reviewed by Tim Horton.
1063
1064         Add API test coverage.
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1067
1068 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1069
1070         [ews-build] Enable Bindings tests queue on new EWS
1071         https://bugs.webkit.org/show_bug.cgi?id=197424
1072
1073         Reviewed by Lucas Forschler.
1074
1075         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1076         (StatusBubble):
1077         * BuildSlaveSupport/ews-build/config.json:
1078
1079 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews-build] Configure ews151 for running various tests
1082         https://bugs.webkit.org/show_bug.cgi?id=197419
1083
1084         Reviewed by Lucas Forschler.
1085
1086         * BuildSlaveSupport/ews-build/config.json:
1087
1088 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-build] Parse and display bindings test failures
1091         https://bugs.webkit.org/show_bug.cgi?id=197423
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-build/steps.py:
1096         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1097         (RunBindingsTests.start): Initialize log_observer for json output.
1098         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1099         (RunBindingsTests._addToLog): Method to add message to log.
1100         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1101
1102 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1103
1104         Unreviewed. Add myself as a committer.
1105
1106         * Scripts/webkitpy/common/config/contributors.json:
1107
1108 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1109
1110         [ews-build] Enable webkitpy queue on new EWS
1111         https://bugs.webkit.org/show_bug.cgi?id=197396
1112
1113         Reviewed by Lucas Forschler.
1114
1115         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1116         (StatusBubble):
1117         * BuildSlaveSupport/ews-build/config.json:
1118
1119 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1120
1121         [ews-build] Parse and display webkitpy failures
1122         https://bugs.webkit.org/show_bug.cgi?id=197395
1123
1124         Reviewed by Lucas Forschler.
1125
1126         * BuildSlaveSupport/ews-build/steps.py:
1127         (RunWebKitPyTests.start): Initialize log_observer for json output.
1128         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1129         (RunWebKitPyTests._addToLog): Method to add message to log.
1130         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1131
1132 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1133
1134         <rdar://problem/50299396> Fix internal High Sierra build
1135         https://bugs.webkit.org/show_bug.cgi?id=197388
1136
1137         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1138         * MiniBrowser/Configurations/Base.xcconfig:
1139         * MobileMiniBrowser/Configurations/Base.xcconfig:
1140         * TestWebKitAPI/Configurations/Base.xcconfig:
1141         * WebKitTestRunner/Configurations/Base.xcconfig:
1142
1143 2019-04-29  Youenn Fablet  <youenn@apple.com>
1144
1145         Remove spurious GVA printf logging
1146         https://bugs.webkit.org/show_bug.cgi?id=197368
1147         <rdar://problem/35975256>
1148
1149         Reviewed by Alexey Proskuryakov.
1150
1151         * Scripts/webkitpy/port/mac.py:
1152         (MacPort.logging_patterns_to_strip):
1153
1154 2019-04-29  Youenn Fablet  <youenn@apple.com>
1155
1156         getDisplayMedia should be called on user gesture
1157         https://bugs.webkit.org/show_bug.cgi?id=197356
1158         <rdar://problem/50296074>
1159
1160         Reviewed by Eric Carlson.
1161
1162         Update test configuration to inject internals
1163         so that we can use it to simulate a user click to call getDisplayMedia.
1164
1165         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1166         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1167         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1168
1169 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1170
1171         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1172         https://bugs.webkit.org/show_bug.cgi?id=197339
1173
1174         Reviewed by Dewei Zhu.
1175
1176         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1177         test run for setup steps that are too expensive to do every iteration.
1178
1179         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1180         (BenchmarkRunner._run_benchmark):
1181         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1182         (BrowserDriver):
1183         (BrowserDriver.prepare_initial_env):
1184         (BrowserDriver.restore_env_after_all_testing):
1185         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1186         (LinuxBrowserDriver.prepare_initial_env):
1187         (LinuxBrowserDriver.restore_env_after_all_testing):
1188         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1189         (OSXBrowserDriver.prepare_initial_env):
1190         (OSXBrowserDriver.restore_env_after_all_testing):
1191
1192 2019-04-28  Andy Estes  <aestes@apple.com>
1193
1194         Fix the watchOS engineering build.
1195
1196         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1197         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1198
1199 2019-04-27  Chris Dumez  <cdumez@apple.com>
1200
1201         [WKTR] Move test timeout handling to the UIProcess
1202         https://bugs.webkit.org/show_bug.cgi?id=197333
1203
1204         Reviewed by Darin Adler.
1205
1206         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1207         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1208         every WebContent process in the case of swapping.
1209
1210         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1211         would lead to crashes when firing the timer.
1212
1213         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1214         (WTR::InjectedBundle::didReceiveMessageToPage):
1215         (WTR::InjectedBundle::done):
1216         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1217         (WTR::InjectedBundle::shouldDumpPixels const):
1218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1219         (WTR::TestRunner::TestRunner):
1220         (WTR::TestRunner::waitUntilDone):
1221         (WTR::TestRunner::setWaitUntilDone):
1222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1223         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1224         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1225         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1226         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1227         * WebKitTestRunner/TestInvocation.cpp:
1228         (WTR::TestInvocation::TestInvocation):
1229         (WTR::TestInvocation::createTestSettingsDictionary):
1230         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1231         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1232         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1233         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1234         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1235         (WTR::TestInvocation::setWaitUntilDone):
1236         (WTR::TestInvocation::done):
1237         * WebKitTestRunner/TestInvocation.h:
1238
1239 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1240
1241         [JSC] linkPolymorphicCall now does GC
1242         https://bugs.webkit.org/show_bug.cgi?id=197306
1243
1244         Reviewed by Saam Barati.
1245
1246         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1247         To add this test, we add `runWithoutBaseOption`.
1248
1249         * Scripts/run-jsc-stress-tests:
1250
1251 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1252
1253         Update inactive reviewers' status to 'contributor'.
1254
1255         Accidentally skipped one at first.
1256
1257         * Scripts/webkitpy/common/config/contributors.json:
1258
1259 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1260
1261         Update inactive reviewers' status to 'contributor'.
1262
1263         * Scripts/webkitpy/common/config/contributors.json: The change.
1264
1265         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1266         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1267         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1268         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1269         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1270         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1271         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1272         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1273         Sadly, regression tests operate on a crazy mix of mock and live data for
1274         contributors.json. It would be a substantial project to mock all code paths,
1275         so changing the tests instead.
1276
1277 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1278
1279         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1280         https://bugs.webkit.org/show_bug.cgi?id=197171
1281         <rdar://problem/47454979>
1282
1283         Reviewed by Youenn Fablet.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1287         (TestWebKitAPI::TEST):
1288
1289 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1290
1291         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1292         <https://webkit.org/b/197314>
1293         <rdar://problem/50245252>
1294
1295         Reviewed by Simon Fraser.
1296
1297         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1298         (WTR::UIScriptController::lastUndoLabel const):
1299         (WTR::UIScriptController::firstRedoLabel const):
1300         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1301
1302         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1303         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1304         - Call -autorelease to fix leak of NSDictionary.
1305
1306         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1307         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1308         (WTR::UIScriptController::selectFormPopoverTitle const):
1309         (WTR::UIScriptController::textContentType const):
1310         (WTR::UIScriptController::formInputLabel const):
1311         (WTR::UIScriptController::scrollingTreeAsText const):
1312         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1313
1314 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1315
1316         webkitpy: Running a single test will always use the default device
1317         https://bugs.webkit.org/show_bug.cgi?id=195472
1318         <rdar://problem/48724825>
1319
1320         Reviewed by Lucas Forschler.
1321
1322         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1323         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1324         requested will be run regardless of what shard they are in.
1325
1326         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1327         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1328         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1329         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1330         on the default device type.
1331         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1332         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1333         (RunTest.test_run_part): Ditto.
1334
1335 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1336
1337         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1338         https://bugs.webkit.org/show_bug.cgi?id=197165
1339
1340         Reviewed by Youenn Fablet.
1341
1342         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1343
1344 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1345
1346         Replace iOS build queue hardware
1347         https://bugs.webkit.org/show_bug.cgi?id=197312
1348
1349         Reviewed by Aakash Jain.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/config.json:
1352         Use newer hardware that supports macOS Mojave.
1353
1354 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1355
1356         check-webkit-style complains the first block in while loop.
1357         https://bugs.webkit.org/show_bug.cgi?id=197307
1358
1359         The style checker shouldn't complain about an open brace on
1360         its own line if the last non-whitespace character on the previous
1361         non-blank line is another open brace, because it's likely to
1362         indicate the begining of a nested code block.
1363
1364         Reviewed by Alex Christensen.
1365
1366         * Scripts/webkitpy/style/checkers/cpp.py:
1367         (check_braces):
1368         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1369         (WebKitStyleTest.test_braces):
1370
1371 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1372
1373         Stop IDB transactions to release locked database files when network process is ready to suspend
1374         https://bugs.webkit.org/show_bug.cgi?id=196372
1375         <rdar://problem/48930116>
1376
1377         Reviewed by Brady Eidson.
1378
1379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1380         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1381         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1382         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1383         (runTestAndCheckResult):
1384         (keepNetworkProcessActive):
1385         (TEST):
1386
1387 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1388
1389         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1390         https://bugs.webkit.org/show_bug.cgi?id=188357
1391         <rdar://problem/42986633>
1392
1393         Reviewed by Dean Jackson.
1394
1395         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1396         tests would fall into low memory mode and have different behavior.
1397         
1398         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1399         to Internals, so it's shared by DRT and WTR.
1400         
1401         We no longer need the WK2 C SPI glue.
1402
1403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1404         (WTR::InjectedBundlePage::prepare):
1405
1406 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1407
1408         webkitpy: Including skipped tests in the final count
1409         https://bugs.webkit.org/show_bug.cgi?id=197298
1410         <rdar://problem/49705424>
1411
1412         Reviewed by Lucas Forschler.
1413
1414         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1415         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1416
1417 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1418
1419         Disable date and time inputs on iOSMac.
1420         https://bugs.webkit.org/show_bug.cgi?id=197287
1421         rdar://problem/46794376
1422
1423         Reviewed by Wenson Hsieh.
1424
1425         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1426
1427 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1428
1429         Fix test-webkitpy after r244653
1430         https://bugs.webkit.org/show_bug.cgi?id=197131
1431
1432         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1433         Also use C++17.
1434
1435 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1436
1437         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1438         https://bugs.webkit.org/show_bug.cgi?id=196991
1439         <rdar://problem/45507423>
1440
1441         Reviewed by Alex Christensen.
1442
1443         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1444         (-[NavigationTestDelegate init]):
1445         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1446         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1447         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1448         (TestWebKitAPI::TEST):
1449         (TEST): Deleted.
1450
1451 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1452
1453         Revert some code accidentally committed with r244653
1454         https://bugs.webkit.org/show_bug.cgi?id=197131
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1457         (TestWebKitAPI::TEST):
1458
1459 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1460
1461         Start using C++17
1462         https://bugs.webkit.org/show_bug.cgi?id=197131
1463
1464         Reviewed by Darin Adler.
1465
1466         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1467         * MiniBrowser/Configurations/Base.xcconfig:
1468         * MobileMiniBrowser/Configurations/Base.xcconfig:
1469         * TestWebKitAPI/Configurations/Base.xcconfig:
1470         * WebKitTestRunner/Configurations/Base.xcconfig:
1471
1472 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1473
1474         Unreviewed, rolling out r244627.
1475         https://bugs.webkit.org/show_bug.cgi?id=197282
1476
1477         Causing internal build failures (Requested by ShawnRoberts on
1478         #webkit).
1479
1480         Reverted changeset:
1481
1482         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1483         https://bugs.webkit.org/show_bug.cgi?id=197171
1484         https://trac.webkit.org/changeset/244627
1485
1486 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         [GTK] Hardcoded text color in input fields
1489         https://bugs.webkit.org/show_bug.cgi?id=126907
1490
1491         Reviewed by Michael Catanzaro.
1492
1493         Add dark-mode command line option to MiniBrowser.
1494
1495         * MiniBrowser/gtk/main.c:
1496         (main):
1497
1498 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1499
1500         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1501         https://bugs.webkit.org/show_bug.cgi?id=196948
1502         <rdar://problem/49927131>
1503
1504         Reviewed by Tim Horton.
1505
1506         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1507         (TEST):
1508         The expected order of incoming events is
1509         1. didInvalidateIntrinsicContentSize
1510         2. didFirstLayout
1511         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1512         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1513         (and remember, all we care about is ordering).
1514
1515 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1516
1517         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1518         https://bugs.webkit.org/show_bug.cgi?id=197171
1519         <rdar://problem/47454979>
1520
1521         Reviewed by Youenn Fablet.
1522
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1524         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1525         (TestWebKitAPI::TEST):
1526
1527 2019-04-24  Brady Eidson  <beidson@apple.com>
1528
1529         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1530         https://bugs.webkit.org/show_bug.cgi?id=191362
1531
1532         Reviewed by Alex Christensen.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1535           from an XHR to a custom protocol.
1536
1537 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1538
1539         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1540         https://bugs.webkit.org/show_bug.cgi?id=197273
1541
1542         Reviewed by Dean Jackson.
1543
1544         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1545         so that WebCoreTestSupport::resetInternalsObject() is always run.
1546
1547         * DumpRenderTree/mac/DumpRenderTree.mm:
1548         (resetWebViewToConsistentStateBeforeTesting):
1549         (runTest):
1550
1551 2019-04-24  John Wilander  <wilander@apple.com>
1552
1553         Age out unconverted Ad Click Attributions after one week.
1554         https://bugs.webkit.org/show_bug.cgi?id=197238
1555         <rdar://problem/50177349>
1556
1557         Reviewed by Chris Dumez.
1558
1559         This patch adds infrastructure to allow tests to expire all unconverted
1560         attributions early.
1561
1562         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1563         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1564         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1565         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1566         * WebKitTestRunner/TestController.cpp:
1567         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1568         * WebKitTestRunner/TestController.h:
1569         * WebKitTestRunner/TestInvocation.cpp:
1570         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1571
1572 2019-04-24  Chris Dumez  <cdumez@apple.com>
1573
1574         Fix flaky crashes in a couple of PSON API tests
1575         https://bugs.webkit.org/show_bug.cgi?id=197239
1576
1577         Reviewed by Tim Horton.
1578
1579         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1580
1581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1582
1583 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1584
1585         Make it possible to control the renderTreeAsText output by setting options on testRunner
1586         https://bugs.webkit.org/show_bug.cgi?id=197133
1587
1588         Reviewed by Sam Weinig.
1589
1590         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1591         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1592         these flags through the various framework layers.
1593
1594         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1595
1596         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1597         and hand-code DumpRenderTree bindings.
1598
1599         Some cleanup of the TestRunners, using member initializers.
1600
1601         * DumpRenderTree/TestRunner.cpp:
1602         (TestRunner::TestRunner):
1603         (setRenderTreeDumpOptionsCallback):
1604         (TestRunner::staticFunctions):
1605         (TestRunner::setRenderTreeDumpOptions):
1606         * DumpRenderTree/TestRunner.h:
1607         (TestRunner::renderTreeDumpOptions const):
1608         * DumpRenderTree/mac/DumpRenderTree.mm:
1609         (dump):
1610         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1612         (WTR::InjectedBundlePage::dump):
1613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1614         (WTR::TestRunner::TestRunner):
1615         (WTR::TestRunner::setRenderTreeDumpOptions):
1616         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1617         (WTR::TestRunner::renderTreeDumpOptions const):
1618
1619 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1620
1621         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1622         https://bugs.webkit.org/show_bug.cgi?id=197078
1623         <rdar://problem/49564348>
1624
1625         Reviewed by Geoff Garen.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1628         (TEST_F):
1629         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1630         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1631         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1632
1633 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1634
1635         Add unit test for r239322
1636         https://bugs.webkit.org/show_bug.cgi?id=197236
1637
1638         Reviewed by Chris Dumez.
1639
1640         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1641         May as well add the test infrastructure which was needed before and will be needed in the future.
1642
1643         * TestWebKitAPI/TCPServer.cpp:
1644         (TestWebKitAPI::TCPServer::TCPServer):
1645         * TestWebKitAPI/TCPServer.h:
1646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1647         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1648         (TestWebKitAPI::TEST):
1649         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1650         (TestWebKitAPI::downloadAtRate):
1651         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1652         (TEST):
1653         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1654         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1655         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1658         (TEST):
1659
1660 2019-04-24  Chris Dumez  <cdumez@apple.com>
1661
1662         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1663         https://bugs.webkit.org/show_bug.cgi?id=197214
1664         <rdar://problem/49237544>
1665
1666         Reviewed by Alex Christensen.
1667
1668         Extend API test coverage.
1669
1670         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1671         (TEST):
1672
1673 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1674
1675         [Build][GStreamer] Update to 1.16.0
1676         https://bugs.webkit.org/show_bug.cgi?id=197157
1677
1678         Reviewed by Xabier Rodriguez-Calvar.
1679
1680         The upstreamed patches were removed and a new one was added for a
1681         regression detected in the scaletempo GStreamer element. The GNOME
1682         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1683         on the way, as it is the preferred build system now in GStreamer
1684         1.16.
1685
1686         * flatpak/files/httpd-autogen.sh:
1687         * flatpak/flatpakutils.py:
1688         (FlatpakPackage.install):
1689         (WebkitFlatpak.run_in_sandbox):
1690         * flatpak/org.webkit.CommonModules.yaml:
1691         * flatpak/org.webkit.WebKit.yaml:
1692         * gstreamer/jhbuild.modules:
1693         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1694         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1695         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1696         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1697         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1698         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1699         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1700         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1701         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1702         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1703         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1704         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1705         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1706         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1707         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1708         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1709         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1710         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1711         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1712         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1713         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1714         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1715
1716 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1719         https://bugs.webkit.org/show_bug.cgi?id=197156
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1724         support was added.
1725
1726         * MiniBrowser/gtk/BrowserTab.c:
1727         (browser_tab_set_background_color): Set the passed in color as web view background color.
1728         * MiniBrowser/gtk/BrowserTab.h:
1729         * MiniBrowser/gtk/BrowserWindow.c:
1730         (browser_window_init): Initialize backgroundColor.
1731         (browser_window_append_view): Call browser_tab_set_background_color().
1732         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1733         are added.
1734         * MiniBrowser/gtk/main.c:
1735         (main): Call browser_window_set_background_color() before creating the tabs.
1736
1737 2019-04-23  John Wilander  <wilander@apple.com>
1738
1739         Move Ad Click Attribution from internal feature to experimental feature
1740         https://bugs.webkit.org/show_bug.cgi?id=197218
1741         <rdar://problem/47651691>
1742
1743         Reviewed by Brent Fulgham.
1744
1745         * DumpRenderTree/TestOptions.cpp:
1746         (TestOptions::TestOptions):
1747
1748 2019-04-23  Andy Estes  <aestes@apple.com>
1749
1750         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1751         https://bugs.webkit.org/show_bug.cgi?id=196749
1752         <rdar://problem/35773454>
1753
1754         Reviewed by Daniel Bates.
1755
1756         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1757
1758         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1759         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1760         (-[QuickLookDelegate webView:didFinishNavigation:]):
1761         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1762         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1763         (runTest):
1764         (runTestDecideBeforeLoading):
1765         (runTestDecideAfterLoading):
1766         (TEST):
1767
1768 2019-04-23  John Wilander  <wilander@apple.com>
1769
1770         Remove Ad Click Attribution data when removing website data
1771         https://bugs.webkit.org/show_bug.cgi?id=197215
1772         <rdar://problem/47668988>
1773
1774         Reviewed by Chris Dumez.
1775
1776         This patch adds test infrastructure to delete Ad Click Attribution data
1777         through WebsiteDataStore::removeData().
1778
1779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1781         (WTR::TestRunner::clearAdClickAttribution):
1782         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1783         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1786         * WebKitTestRunner/TestController.h:
1787         * WebKitTestRunner/TestInvocation.cpp:
1788         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1789
1790 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1791
1792         webkitpy: Kill unresponsive worker processes
1793         https://bugs.webkit.org/show_bug.cgi?id=197205
1794         <rdar://problem/50104388>
1795
1796         Reviewed by Lucas Forschler.
1797
1798         * Scripts/webkitpy/common/message_pool.py:
1799         (_MessagePool.__init__): Add close timeout.
1800         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1801
1802 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1803
1804         Add unit tests for WKWebView.serverTrust
1805         https://bugs.webkit.org/show_bug.cgi?id=197202
1806
1807         Reviewed by Youenn Fablet
1808
1809         * TestWebKitAPI/TCPServer.cpp:
1810         (TestWebKitAPI::deleter<BIO>::operator()):
1811         (TestWebKitAPI::deleter<SSL>::operator()):
1812         (TestWebKitAPI::deleter<X509>::operator()):
1813         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1814         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1815         (TestWebKitAPI::TCPServer::TCPServer):
1816         (TestWebKitAPI::TCPServer::listenForConnections):
1817         * TestWebKitAPI/TCPServer.h:
1818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1819         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1820         (TestWebKitAPI::TEST):
1821         (verifyCertificateAndPublicKey):
1822         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1823         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1824         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1825         (TestWebKitAPI::downloadAtRate):
1826         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1827         (TEST):
1828         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1829         (TEST):
1830
1831 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1832
1833         Unreviewed, rolling out r244556.
1834         https://bugs.webkit.org/show_bug.cgi?id=197212
1835
1836         Causing build failures on multiple builders (Requested by
1837         ShawnRoberts on #webkit).
1838
1839         Reverted changeset:
1840
1841         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1842         https://bugs.webkit.org/show_bug.cgi?id=197171
1843         https://trac.webkit.org/changeset/244556
1844
1845 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1846
1847         Fix iOS build.
1848         https://bugs.webkit.org/show_bug.cgi?id=195537
1849
1850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1851         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1852         AdoptWK constructor is private now.  Use adoptWK instead.
1853
1854 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1855
1856         Accessibility text search and selection API enhancements.
1857         https://bugs.webkit.org/show_bug.cgi?id=197095
1858         <rdar://problem/48181791>
1859
1860         Reviewed by Chris Fleizach.
1861
1862         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1863
1864         * DumpRenderTree/AccessibilityTextMarker.h:
1865         * DumpRenderTree/AccessibilityUIElement.cpp:
1866         (searchTextWithCriteriaCallback):
1867         (AccessibilityUIElement::getJSClass):
1868         * DumpRenderTree/AccessibilityUIElement.h:
1869         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1870         (convertVectorToObjectArray):
1871         (convertNSArrayToVector):
1872         (searchTextParameterizedAttributeForCriteria):
1873         (AccessibilityUIElement::getLinkedUIElements):
1874         (AccessibilityUIElement::getDocumentLinks):
1875         (AccessibilityUIElement::getChildren):
1876         (AccessibilityUIElement::getChildrenWithRange):
1877         (AccessibilityUIElement::rowHeaders const):
1878         (AccessibilityUIElement::columnHeaders const):
1879         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1880         (AccessibilityUIElement::searchTextWithCriteria):
1881         (AccessibilityUIElement::attributesOfColumnHeaders):
1882         (AccessibilityUIElement::attributesOfRowHeaders):
1883         (AccessibilityUIElement::attributesOfColumns):
1884         (AccessibilityUIElement::attributesOfRows):
1885         (AccessibilityUIElement::attributesOfVisibleCells):
1886         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1887         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1888         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1889         (WTR::convertVectorToObjectArray):
1890         (WTR::convertNSArrayToVector):
1891         (WTR::searchTextParameterizedAttributeForCriteria):
1892         (WTR::AccessibilityUIElement::getLinkedUIElements):
1893         (WTR::AccessibilityUIElement::getDocumentLinks):
1894         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1895         (WTR::AccessibilityUIElement::getChildren):
1896         (WTR::AccessibilityUIElement::getChildrenWithRange):
1897         (WTR::AccessibilityUIElement::rowHeaders const):
1898         (WTR::AccessibilityUIElement::columnHeaders const):
1899         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1900         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1901         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1902         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1903         (WTR::AccessibilityUIElement::attributesOfColumns):
1904         (WTR::AccessibilityUIElement::attributesOfRows):
1905         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1906         (WTR::convertElementsToObjectArray): Deleted.
1907
1908 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1909
1910         Multiple File Input Icon Set Regardless of File List
1911         https://bugs.webkit.org/show_bug.cgi?id=195537
1912
1913         Reviewed by Alexey Proskuryakov.
1914
1915         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1916         display string in iOS file inputs
1917
1918         * DumpRenderTree/TestRunner.cpp:
1919         (SetOpenPanelFilesMediaIconCallback):
1920         (TestRunner::staticFunctions):
1921         (TestRunner::setOpenPanelFilesMediaIcon):
1922         * DumpRenderTree/TestRunner.h:
1923         (TestRunner::openPanelFilesMediaIcon const):
1924         * DumpRenderTree/mac/UIDelegate.mm:
1925         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1928         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1930         * WebKitTestRunner/TestController.cpp:
1931         (WTR::runOpenPanel):
1932         (WTR::TestController::resetStateToConsistentValues):
1933         * WebKitTestRunner/TestController.h:
1934         (WTR::TestController::openPanelFileURLsMediaIcon const):
1935         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1936         * WebKitTestRunner/TestInvocation.cpp:
1937         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1938
1939 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1940
1941         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1942         https://bugs.webkit.org/show_bug.cgi?id=197171
1943         <rdar://problem/47454979>
1944
1945         Reviewed by Youenn Fablet.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1949         (TestWebKitAPI::TEST):
1950
1951 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1952
1953         [ews-build] Add unit tests for UnApplyPatchIfRequired
1954         https://bugs.webkit.org/show_bug.cgi?id=197197
1955
1956         Reviewed by Lucas Forschler.
1957
1958         * BuildSlaveSupport/ews-build/steps_unittest.py:
1959         (TestUnApplyPatchIfRequired):
1960         (TestUnApplyPatchIfRequired.test_success):
1961         (TestUnApplyPatchIfRequired.test_failure):
1962         (TestUnApplyPatchIfRequired.test_skip):
1963
1964 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews-build] Add unit tests for CleanWorkingDirectory
1967         https://bugs.webkit.org/show_bug.cgi?id=197195
1968
1969         Reviewed by Lucas Forschler.
1970
1971         * BuildSlaveSupport/ews-build/steps_unittest.py:
1972         (TestCleanWorkingDirectory):
1973         (TestCleanWorkingDirectory.test_success):
1974         (TestCleanWorkingDirectory.test_failure):
1975
1976 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews-build] Use explicit imports instead of wildcard imports
1979         https://bugs.webkit.org/show_bug.cgi?id=197194
1980
1981         Reviewed by Lucas Forschler.
1982
1983         * BuildSlaveSupport/ews-build/factories.py:
1984         * BuildSlaveSupport/ews-build/loadConfig.py:
1985         * BuildSlaveSupport/ews-build/steps_unittest.py:
1986
1987 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1988
1989         [ews-build] Add unit tests for DownloadBuiltProduct
1990         https://bugs.webkit.org/show_bug.cgi?id=197193
1991
1992         Reviewed by Lucas Forschler.
1993
1994         * BuildSlaveSupport/ews-build/steps_unittest.py:
1995         (TestDownloadBuiltProduct):
1996         (TestDownloadBuiltProduct.setUp):
1997         (TestDownloadBuiltProduct.tearDown):
1998         (TestDownloadBuiltProduct.test_success):
1999         (TestDownloadBuiltProduct.test_failure):
2000
2001 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2002
2003         [ews-app] Exception while loading status-bubble when no build step has started
2004         https://bugs.webkit.org/show_bug.cgi?id=196676
2005
2006         Reviewed by Lucas Forschler.
2007
2008         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2009         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2010
2011 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2012
2013         [PlayStation] Support running of JSC tests on remote playstation devices
2014         https://bugs.webkit.org/show_bug.cgi?id=197170
2015
2016         Reviewed by Ross Kirsling.
2017
2018         Script changes
2019
2020         * Scripts/run-javascriptcore-tests:
2021         (runJSCStressTests): Pass arguments for playstation to
2022         run-jsc-stress-tests
2023         * Scripts/run-jsc-stress-tests:
2024         Handle $hostOS=="playstation" for determineArchitecture, turning
2025         off $isFTLPlatform and runProfiler and defaulting test writer.
2026         * Scripts/webkitdirs.pm:
2027         (jscPath): PlayStation WebKit executables have .elf extension
2028         (executableProductDir): PlayStation builds on Windows hosts but
2029         uses bin directory rather than bin64/bin32 for executable output
2030         location.
2031         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2032
2033 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2034
2035         [CMake][Win] Use target oriented design for WebKit
2036         https://bugs.webkit.org/show_bug.cgi?id=197173
2037
2038         Reviewed by Alex Christensen.
2039
2040         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2041         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2042
2043 2019-04-23  Chris Dumez  <cdumez@apple.com>
2044
2045         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2046         https://bugs.webkit.org/show_bug.cgi?id=197097
2047         <rdar://problem/50048318>
2048
2049         Reviewed by Alex Christensen.
2050
2051         Add API test coverage.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2054         (-[PSONScheme webView:startURLSchemeTask:]):
2055
2056 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         [ATK] Implement AtkComponentIface scroll_to methods
2059         https://bugs.webkit.org/show_bug.cgi?id=196856
2060
2061         Reviewed by Michael Catanzaro.
2062
2063         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2064         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2065         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2066         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2067
2068 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-build] Improve summary for UploadBuiltProduct step
2071         https://bugs.webkit.org/show_bug.cgi?id=197182
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-build/steps.py:
2076         (UploadBuiltProduct): Added descriptionDone.
2077         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2078         * BuildSlaveSupport/ews-build/steps_unittest.py:
2079         (TestUploadBuiltProduct.test_success): Updated unit-test.
2080         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2081
2082 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2083
2084         [ews-build] Trigger queues only after uploading the archive
2085         https://bugs.webkit.org/show_bug.cgi?id=197180
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/factories.py:
2090         (Factory.__init__):
2091         (BuildFactory.__init__): Remove trigger step from factories.
2092         (BuildFactory.propertiesToPassToTriggers): Deleted.
2093         * BuildSlaveSupport/ews-build/steps.py:
2094         (ConfigureBuild.__init__): Confiure triggers property.
2095         (Trigger): Step to trigger other queues.
2096         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2097         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2098
2099 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2100
2101         Deprecate WKContextCreateWithInjectedBundlePath
2102         https://bugs.webkit.org/show_bug.cgi?id=197169
2103
2104         Reviewed by Youenn Fablet.
2105
2106         * TestWebKitAPI/PlatformUtilities.cpp:
2107         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2108         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2109
2110 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2111
2112         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2113         https://bugs.webkit.org/show_bug.cgi?id=197093
2114         <rdar://problem/49708268>
2115
2116         Reviewed by Chris Dumez.
2117
2118         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2119         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2120         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2121         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2122         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2123
2124         * TestWebKitAPI/TCPServer.cpp:
2125         (TestWebKitAPI::TCPServer::TCPServer):
2126         (TestWebKitAPI::TCPServer::~TCPServer):
2127         (TestWebKitAPI::TCPServer::socketBindListen):
2128         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2129         * TestWebKitAPI/TCPServer.h:
2130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2131         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2132         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2133         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2134         (respondWithChallengeThenOK):
2135         (TestWebKitAPI::TEST):
2136         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2137         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2138         (TEST):
2139
2140 2019-04-22  Chris Dumez  <cdumez@apple.com>
2141
2142         Delayed WebProcessLaunch may break the _relatedWebView SPI
2143         https://bugs.webkit.org/show_bug.cgi?id=197160
2144
2145         Reviewed by Alex Christensen.
2146
2147         Add API test coverage.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2150
2151 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2152
2153         Use curl to download packages for webkitpy autoinstaller
2154         https://bugs.webkit.org/show_bug.cgi?id=197164
2155
2156         Reviewed by Darin Adler.
2157
2158         * Scripts/webkitpy/common/system/autoinstall.py:
2159         (AutoInstaller._download): Use curl(1) to download packages necessary for
2160         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2161         errors which are not present when using curl(1).
2162
2163 2019-04-22  Chris Dumez  <cdumez@apple.com>
2164
2165         Unreviewed, rolling out r244502.
2166
2167         Caused crashes on the bots
2168
2169         Reverted changeset:
2170
2171         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2172         https://bugs.webkit.org/show_bug.cgi?id=197160
2173         https://trac.webkit.org/changeset/244502
2174
2175 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2176
2177         Unreviewed, rolling out r244437.
2178
2179         Still breaks internal tests.
2180
2181         Reverted changeset:
2182
2183         "InjectedBundle parameters often need initialization function
2184         called before unarchiving"
2185         https://bugs.webkit.org/show_bug.cgi?id=189709
2186         https://trac.webkit.org/changeset/244437
2187
2188 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2189
2190         [ews-build] Use singular verb in failure description in case of single api test failure
2191         https://bugs.webkit.org/show_bug.cgi?id=197013
2192
2193         Reviewed by Lucas Forschler.
2194
2195         * BuildSlaveSupport/ews-build/steps.py:
2196         (AnalyzeAPITestsResults.analyzeResults):
2197
2198 2019-04-22  Chris Dumez  <cdumez@apple.com>
2199
2200         Delayed WebProcessLaunch may break the _relatedWebView SPI
2201         https://bugs.webkit.org/show_bug.cgi?id=197160
2202
2203         Reviewed by Alex Christensen.
2204
2205         Add API test coverage.
2206
2207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2208
2209 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2212         https://bugs.webkit.org/show_bug.cgi?id=194630
2213
2214         Reviewed by Michael Catanzaro.
2215
2216         Return early from getAttributeSet() is passed in accessible is nullptr.
2217
2218         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2219
2220 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2221
2222         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2223         https://bugs.webkit.org/show_bug.cgi?id=197145
2224         <rdar://problem/50078170>
2225
2226         Reviewed by Darin Adler.
2227
2228         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2229         focus, or showing the font manager.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2232         (TestWebKitAPI::TEST):
2233         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2234         (TEST):
2235         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2236         (TestWebKitAPI::TEST):
2237
2238 2019-04-21  Brian Burg  <bburg@apple.com>
2239
2240         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2241         https://bugs.webkit.org/show_bug.cgi?id=197125
2242         <rdar://problem/50061468>
2243
2244         Reviewed by Darin Adler.
2245
2246         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2247         using this class rather than making our own ./wpt serve invocation.
2248
2249         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2250         (WebDriverW3CWebServer):
2251         (WebDriverW3CWebServer.document_root): Expose this to clients.
2252         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2253
2254         (WebDriverW3CWebServer.__enter__):
2255         (WebDriverW3CWebServer.__exit__):
2256         Make it possible to use the web server with a 'with' statement.
2257
2258 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2259
2260         [CMake][Win] Use target oriented design for WebKitLegacy
2261         https://bugs.webkit.org/show_bug.cgi?id=197112
2262
2263         Reviewed by Konstantin Tokarev.
2264
2265         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2266
2267         * DumpRenderTree/CMakeLists.txt:
2268         * DumpRenderTree/PlatformWin.cmake:
2269         * DumpRenderTree/win/EventSender.cpp:
2270
2271 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2272
2273         Update text for old EWS submit button
2274         https://bugs.webkit.org/show_bug.cgi?id=197140
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         * QueueStatusServer/templates/statusbubble.html:
2279
2280 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2281
2282         [ews-app] New EWS should poll bugzilla more frequently
2283         https://bugs.webkit.org/show_bug.cgi?id=197138
2284
2285         Reviewed by Alexey Proskuryakov.
2286
2287         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2288         (FetchLoop.__init__):
2289
2290 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2291
2292         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2293         https://bugs.webkit.org/show_bug.cgi?id=197139
2294
2295         Reviewed by Alexey Proskuryakov.
2296
2297         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2298         * QueueStatusServer/templates/statusbubble.html:
2299
2300 2019-04-20  Chris Dumez  <cdumez@apple.com>
2301
2302         Unreviewed, fix iOS build with recent SDKs.
2303
2304         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2305
2306 2019-04-19  Keith Miller  <keith_miller@apple.com>
2307
2308         Add script to merge run_benchmark jsons
2309         https://bugs.webkit.org/show_bug.cgi?id=197107
2310
2311         Reviewed by Michael Saboff.
2312
2313         The script basically recursively decends through all json objects until it gets
2314         to an array or JSON primitive and concats or takes the first value, respectively.
2315
2316         This patch also adds +x bits to the compare-results script so it
2317         can be run directly from the command line. I had to add a new line so that svn
2318         will accept the change... yay svn!
2319
2320         * Scripts/compare-results:
2321         * Scripts/merge-result-jsons: Added.
2322         (readJSONFile):
2323         (deepAppend):
2324         (mergeJSONs):
2325         (main):
2326
2327 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2328
2329         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2330         https://bugs.webkit.org/show_bug.cgi?id=197079
2331
2332         Reviewed by Darin Adler.
2333
2334         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2335
2336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2337         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2338
2339 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2340
2341         Unreviewed, rolling out r244434.
2342         https://bugs.webkit.org/show_bug.cgi?id=197089
2343
2344         caused 1 API test failure (Requested by zalan on #webkit).
2345
2346         Reverted changeset:
2347
2348         "Regression (r244291): Broken API Test
2349         AutoLayoutRenderingProgressRelativeOrdering"
2350         https://bugs.webkit.org/show_bug.cgi?id=196948
2351         https://trac.webkit.org/changeset/244434
2352
2353 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2354
2355         Add new compatibility mode API on WKNavigation
2356         https://bugs.webkit.org/show_bug.cgi?id=197069
2357         <rdar://problem/50025800>
2358
2359         Reviewed by Tim Horton.
2360
2361         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2362
2363         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2364         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2365         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2366
2367 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2368
2369         [CMake] Make WebCore headers copies
2370         https://bugs.webkit.org/show_bug.cgi?id=182512
2371         <rdar://problem/37510435>
2372
2373         Reviewed by Alex Christensen.
2374
2375         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2376         ports.
2377
2378         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2379         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2380
2381         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2382         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2383         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2384         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2385         * TestWebKitAPI/CMakeLists.txt:
2386         * TestWebKitAPI/PlatformWin.cmake:
2387         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2388         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2389         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2390
2391 2019-04-18  Jer Noble  <jer.noble@apple.com>
2392
2393         Add support for parsing FairPlayStreaming PSSH boxes.
2394         https://bugs.webkit.org/show_bug.cgi?id=197064
2395
2396         Reviewed by Eric Carlson.
2397
2398         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2399         (TestWebKitAPI::TEST):
2400
2401 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2402
2403         InjectedBundle parameters often need initialization function called before unarchiving
2404         https://bugs.webkit.org/show_bug.cgi?id=189709
2405         <rdar://problem/44573653>
2406
2407         Reviewed by Ryosuke Niwa.
2408
2409         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2410         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2411
2412 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2413
2414         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2415         https://bugs.webkit.org/show_bug.cgi?id=196948
2416         <rdar://problem/49927131>
2417
2418         Reviewed by Tim Horton.
2419
2420         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2421         (TEST): 
2422         The expected order of incoming events is
2423         1. didInvalidateIntrinsicContentSize
2424         2. didFirstLayout
2425         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2426         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2427         (and remember, all we care about is ordering).
2428
2429 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2430
2431         Unreviewed, rolling out r244299.
2432
2433         Breaks internal tests.
2434
2435         Reverted changeset:
2436
2437         "InjectedBundle parameters often need initialization function
2438         called before unarchiving"
2439         https://bugs.webkit.org/show_bug.cgi?id=189709
2440         https://trac.webkit.org/changeset/244299
2441
2442 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2443
2444         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2445         https://bugs.webkit.org/show_bug.cgi?id=197053
2446
2447         Reviewed by Saam Barati.
2448
2449         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2450         (TestWebKitAPI::TEST):
2451
2452 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2453
2454         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2455         https://bugs.webkit.org/show_bug.cgi?id=197028
2456         <rdar://problem/49985290>
2457
2458         Reviewed by Wenson Hsieh.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2461         (TEST):
2462         Liberal application of waitForNextPresentationUpdate works around a race
2463         where if the page rapidly changes its viewport arguments (or an API client
2464         rapidly changes its viewport arguments), we'd get stuck thinking that the
2465         user had intentionally zoomed the page, and stop resetting the initial scale.
2466         This deserves a separate bug, but no need to keep the test failing while
2467         we think about it.
2468
2469 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2470
2471         REGRESSION (r241988): Switching tabs is slow
2472         https://bugs.webkit.org/show_bug.cgi?id=197037
2473         <rdar://problem/49951473>
2474
2475         Reviewed by Simon Fraser.
2476
2477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2478         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2479         (TEST):
2480         * TestWebKitAPI/cocoa/TestWKWebView.h:
2481         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2482         (-[TestWKWebView addToTestWindow]):
2483         Add a test that hangs without this fix.
2484
2485 2019-04-17  Truitt Savell  <tsavell@apple.com>
2486
2487         Unreviewed, rolling out r244400.
2488
2489         Caused testing to exit early with assertionon Debug WK2
2490
2491         Reverted changeset:
2492
2493         "UI↔Web deadlock when printing with a JavaScript alert
2494         visible"
2495         https://bugs.webkit.org/show_bug.cgi?id=196839
2496         https://trac.webkit.org/changeset/244400
2497
2498 2019-04-17  Brady Eidson  <beidson@apple.com>
2499
2500         Link clicks in PDFs shouldn't send referrer headers.
2501         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2502
2503         Reviewed by Tim Horton.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2507         (putPDFBytesCallback):
2508         (emptyReleaseInfoCallback):
2509         (createPDFWithLinkToURL):
2510         (TEST):
2511
2512 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2513
2514         UI↔Web deadlock when printing with a JavaScript alert visible
2515         https://bugs.webkit.org/show_bug.cgi?id=196839
2516         <rdar://problem/49157642>
2517
2518         Reviewed by Andy Estes.
2519
2520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2521         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2522         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2523         (TEST):
2524
2525 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2526
2527         WKRetainPtr's adoption constructor should be private
2528         https://bugs.webkit.org/show_bug.cgi?id=197019
2529
2530         Reviewed by Tim Horton.
2531
2532         * DumpRenderTree/mac/DumpRenderTree.mm:
2533         (dumpFramesAsText):
2534         * TestWebKitAPI/InjectedBundleController.cpp:
2535         (TestWebKitAPI::InjectedBundleController::initialize):
2536         * TestWebKitAPI/PlatformUtilities.cpp:
2537         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2538         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2539         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2540         (TestWebKitAPI::Util::toWK):
2541         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2542         (TestWebKitAPI::TEST):
2543         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2544         (TestWebKitAPI::TEST):
2545         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2546         (TestWebKitAPI::TEST):
2547         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2548         (TestWebKitAPI::TEST):
2549         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2550         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2551         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2552         (TestWebKitAPI::TEST):
2553         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2554         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2555         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2556         (TestWebKitAPI::TEST):
2557         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2558         (TestWebKitAPI::TEST):
2559         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2560         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2561         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2562         (TestWebKitAPI::TEST):
2563         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2564         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2565         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2566         (TestWebKitAPI::TEST):
2567         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2568         (TestWebKitAPI::TEST):
2569         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2570         (TestWebKitAPI::TEST):
2571         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2574         (TestWebKitAPI::TEST):
2575         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2576         (TestWebKitAPI::TEST):
2577         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2578         (TestWebKitAPI::TEST):
2579         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2580         (TestWebKitAPI::TEST):
2581         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2582         (TestWebKitAPI::TEST):
2583         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2584         (TestWebKitAPI::TEST):
2585         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2586         (TestWebKitAPI::TEST):
2587         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2588         (TestWebKitAPI::TEST):
2589         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2590         (TestWebKitAPI::TEST):
2591         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2594         (TestWebKitAPI::TEST):
2595         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2596         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2597         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2598         (TestWebKitAPI::TEST):
2599         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2600         (TestWebKitAPI::TEST):
2601         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2602         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2603         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2604         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2605         (TestWebKitAPI::TEST):
2606         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2607         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2608         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2609         (TestWebKitAPI::TEST):
2610         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2611         (TestWebKitAPI::TEST):
2612         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2613         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2614         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2615         (TestWebKitAPI::TEST):
2616         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2617         (TestWebKitAPI::loadAlternateHTMLString):
2618         (TestWebKitAPI::TEST):
2619         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2620         (TestWebKitAPI::TEST):
2621         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2622         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2623         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2624         (TestWebKitAPI::buildAndPerformTest):
2625         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2626         (TestWebKitAPI::TEST):
2627         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2628         (TestWebKitAPI::TEST):
2629         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2630         (TestWebKitAPI::TEST):
2631         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2632         (TestWebKitAPI::TEST):
2633         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2634         (TestWebKitAPI::TEST):
2635         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2636         (TestWebKitAPI::TEST):
2637         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2638         (TestWebKitAPI::TEST):
2639         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2640         (TestWebKitAPI::TEST):
2641         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2642         (TestWebKitAPI::TEST):
2643         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2644         (TestWebKitAPI::TEST):
2645         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2646         (TestWebKitAPI::TEST):
2647         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2648         (TestWebKitAPI::TEST):
2649         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2650         (TestWebKitAPI::TEST):
2651         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2652         (TestWebKitAPI::TEST):
2653         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2654         (TestWebKitAPI::TEST):
2655         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2656         (TestWebKitAPI::TEST):
2657         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2658         (TestWebKitAPI::TEST):
2659         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2660         (TestWebKitAPI::TEST):
2661         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2662         (TestWebKitAPI::TEST):
2663         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2668         (TestWebKitAPI::TEST):
2669         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2670         (TestWebKitAPI::TEST):
2671         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2672         (TestWebKitAPI::TEST):
2673         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2674         (TestWebKitAPI::TEST):
2675         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2676         (TestWebKitAPI::TEST):
2677         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2678         (TestWebKitAPI::TEST):
2679         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2680         (TestWebKitAPI::TEST):
2681         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2682         (TestWebKitAPI::TEST):
2683         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2684         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2685         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2686         (TestWebKitAPI::TEST):
2687         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2688         (TestWebKitAPI::TEST):
2689         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2690         (TestWebKitAPI::TEST):
2691         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2692         (TestWebKitAPI::TEST):
2693         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2694         (TestWebKitAPI::TEST):
2695         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2696         (TestWebKitAPI::TEST):
2697         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2698         (TestWebKitAPI::TEST):
2699         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2700         (TestWebKitAPI::TEST):
2701         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2702         (TestWebKitAPI::TEST):
2703         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2704         (TestWebKitAPI::TEST):
2705         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2707         (TEST):
2708         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2709         (TEST):
2710         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2711         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2712         (TEST):
2713         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2714         (TestWebKitAPI::TEST):
2715         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2716         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2717         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2718         (WTR::getMenuItemTitleCallback):
2719         (WTR::createMouseMessageBody):
2720         (WTR::EventSendingController::mouseDown):
2721         (WTR::EventSendingController::mouseUp):
2722         (WTR::EventSendingController::mouseMoveTo):
2723         (WTR::EventSendingController::mouseForceClick):
2724         (WTR::EventSendingController::startAndCancelMouseForceClick):
2725         (WTR::EventSendingController::mouseForceDown):
2726         (WTR::EventSendingController::mouseForceUp):
2727         (WTR::EventSendingController::mouseForceChanged):
2728         (WTR::EventSendingController::leapForward):
2729         (WTR::EventSendingController::scheduleAsynchronousClick):
2730         (WTR::createKeyDownMessageBody):
2731         (WTR::EventSendingController::keyDown):
2732         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2733         (WTR::EventSendingController::mouseScrollBy):
2734         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2735         (WTR::EventSendingController::continuousMouseScrollBy):
2736         (WTR::EventSendingController::addTouchPoint):
2737         (WTR::EventSendingController::updateTouchPoint):
2738         (WTR::EventSendingController::setTouchModifier):
2739         (WTR::EventSendingController::setTouchPointRadius):
2740         (WTR::EventSendingController::touchStart):
2741         (WTR::EventSendingController::touchMove):
2742         (WTR::EventSendingController::touchEnd):
2743         (WTR::EventSendingController::touchCancel):
2744         (WTR::EventSendingController::clearTouchPoints):
2745         (WTR::EventSendingController::releaseTouchPoint):
2746         (WTR::EventSendingController::cancelTouchPoint):
2747         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2748         (WTR::InjectedBundle::didCreatePage):
2749         (WTR::InjectedBundle::didReceiveMessage):
2750         (WTR::InjectedBundle::didReceiveMessageToPage):
2751         (WTR::InjectedBundle::booleanForKey):
2752         (WTR::InjectedBundle::done):
2753         (WTR::InjectedBundle::dumpToStdErr):
2754         (WTR::InjectedBundle::outputText):
2755         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2756         (WTR::InjectedBundle::postAddChromeInputField):
2757         (WTR::InjectedBundle::postRemoveChromeInputField):
2758         (WTR::InjectedBundle::postFocusWebView):
2759         (WTR::InjectedBundle::postSetBackingScaleFactor):
2760         (WTR::InjectedBundle::postSetWindowIsKey):
2761         (WTR::InjectedBundle::postSetViewSize):
2762         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2763         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2764         (WTR::InjectedBundle::setGeolocationPermission):
2765         (WTR::InjectedBundle::setMockGeolocationPosition):
2766         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2767         (WTR::InjectedBundle::isGeolocationProviderActive const):
2768         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2769         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2770         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2771         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2772         (WTR::InjectedBundle::setCustomPolicyDelegate):
2773         (WTR::InjectedBundle::setHidden):
2774         (WTR::InjectedBundle::setCacheModel):
2775         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2776         (WTR::InjectedBundle::processWorkQueue):
2777         (WTR::InjectedBundle::queueBackNavigation):
2778         (WTR::InjectedBundle::queueForwardNavigation):
2779         (WTR::InjectedBundle::queueLoad):
2780         (WTR::InjectedBundle::queueLoadHTMLString):
2781         (WTR::InjectedBundle::queueReload):
2782         (WTR::InjectedBundle::queueLoadingScript):
2783         (WTR::InjectedBundle::queueNonLoadingScript):
2784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2785         (WTR::frameToStr):
2786         (WTR::InjectedBundlePage::InjectedBundlePage):
2787         (WTR::dumpFrameDescriptionSuitableForTestResult):
2788         (WTR::dumpFrameScrollPosition):
2789         (WTR::dumpDescendantFrameScrollPositions):
2790         (WTR::dumpFrameText):
2791         (WTR::dumpDescendantFramesText):
2792         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2793         (WTR::TestRunner::shouldDumpPixels const):
2794         (WTR::TestRunner::setDumpPixels):
2795         (WTR::TestRunner::whatToDump const):
2796         (WTR::TestRunner::setWhatToDump):
2797         (WTR::TestRunner::setWaitUntilDone):
2798         (WTR::TestRunner::shouldWaitUntilDone const):
2799         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2800         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2801         (WTR::TestRunner::clearAllDatabases):
2802         (WTR::TestRunner::setIDBPerOriginQuota):
2803         (WTR::TestRunner::originsWithApplicationCache):
2804         (WTR::TestRunner::setCanOpenWindows):
2805         (WTR::TestRunner::setXSSAuditorEnabled):
2806         (WTR::TestRunner::setMediaDevicesEnabled):
2807         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2808         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2809         (WTR::TestRunner::setCustomUserAgent):
2810         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2811         (WTR::TestRunner::setModernMediaControlsEnabled):
2812         (WTR::TestRunner::setWebGL2Enabled):
2813         (WTR::TestRunner::setWritableStreamAPIEnabled):
2814         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2815         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2816         (WTR::TestRunner::setAllowsAnySSLCertificate):
2817         (WTR::TestRunner::setPluginsEnabled):
2818         (WTR::TestRunner::setValueForUser):
2819         (WTR::TestRunner::setAudioResult):
2820         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2821         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2822         (WTR::TestRunner::setAlwaysAcceptCookies):
2823         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2824         (WTR::TestRunner::isDoingMediaCapture const):
2825         (WTR::TestRunner::queueLoad):
2826         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2827         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2828         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2829         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2830         (WTR::TestRunner::setAuthenticationUsername):
2831         (WTR::TestRunner::setAuthenticationPassword):
2832         (WTR::TestRunner::secureEventInputIsEnabled const):
2833         (WTR::TestRunner::setBlockAllPlugins):
2834         (WTR::TestRunner::setPluginSupportedMode):
2835         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2836         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2837         (WTR::TestRunner::setNavigationGesturesEnabled):
2838         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2839         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2840         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2841         (WTR::TestRunner::terminateNetworkProcess):
2842         (WTR::TestRunner::terminateServiceWorkerProcess):
2843         (WTR::TestRunner::runUIScript):
2844         (WTR::TestRunner::setStatisticsDebugMode):
2845         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2846         (WTR::TestRunner::setStatisticsLastSeen):
2847         (WTR::TestRunner::setStatisticsPrevalentResource):
2848         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2849         (WTR::TestRunner::dumpResourceLoadStatistics):
2850         (WTR::TestRunner::isStatisticsPrevalentResource):
2851         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2852         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2853         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2854         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2855         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2856         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2857         (WTR::TestRunner::setStatisticsGrandfathered):
2858         (WTR::TestRunner::isStatisticsGrandfathered):
2859         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2860         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2861         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2862         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2863         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2864         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2865         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2866         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2867         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2868         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2869         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2870         (WTR::TestRunner::statisticsSubmitTelemetry):
2871         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2872         (WTR::TestRunner::setStatisticsIsRunningTest):
2873         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2874         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2875         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2876         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2877         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2878         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2879         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2880         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2881         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2882         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2883         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2884         (WTR::TestRunner::statisticsResetToConsistentState):
2885         (WTR::TestRunner::setStorageAccessAPIEnabled):
2886         (WTR::TestRunner::getAllStorageAccessEntries):
2887         (WTR::TestRunner::addMockMediaDevice):
2888         (WTR::TestRunner::clearMockMediaDevices):
2889         (WTR::TestRunner::removeMockMediaDevice):
2890         (WTR::TestRunner::resetMockMediaDevices):
2891         (WTR::TestRunner::connectMockGamepad):
2892         (WTR::TestRunner::disconnectMockGamepad):
2893         (WTR::TestRunner::setMockGamepadDetails):
2894         (WTR::TestRunner::setMockGamepadAxisValue):
2895         (WTR::TestRunner::setMockGamepadButtonValue):
2896         (WTR::TestRunner::removeAllSessionCredentials):
2897         (WTR::TestRunner::clearDOMCache):
2898         (WTR::TestRunner::clearDOMCaches):
2899         (WTR::TestRunner::hasDOMCache):
2900         (WTR::TestRunner::domCacheSize):
2901         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2902         (WTR::TestRunner::getApplicationManifestThen):
2903         (WTR::TestRunner::injectUserScript):
2904         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2905         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2906         (WTR::TestRunner::addTestKeyToKeychain):
2907         (WTR::TestRunner::cleanUpKeychain):
2908         (WTR::TestRunner::keyExistsInKeychain):
2909         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2910         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2911         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2912         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2913         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2914         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::initialize):
2917         (WTR::parseStringTestHeaderValueAsRelativePath):
2918         (WTR::updateTestOptionsFromTestHeader):
2919         (WTR::TestController::runTest):
2920         (WTR::TestController::didReceiveLiveDocumentsList):
2921         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2922         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2923         (WTR::TestController::didFinishNavigation):
2924         (WTR::TestController::didReceiveAuthenticationChallenge):
2925         * WebKitTestRunner/TestInvocation.cpp:
2926         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2927         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2928         (WTR::TestInvocation::uiScriptDidComplete):
2929         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2930         * WebKitTestRunner/WebNotificationProvider.cpp:
2931         (WTR::WebNotificationProvider::closeWebNotification):
2932         * WebKitTestRunner/WorkQueueManager.cpp:
2933         (WTR::ScriptItem::ScriptItem):
2934         (WTR::WorkQueueManager::queueLoad):
2935         (WTR::WorkQueueManager::queueLoadHTMLString):
2936
2937 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2938
2939         Add a comment to make my test from r244139 less mysterious.
2940         https://bugs.webkit.org/show_bug.cgi?id=196744
2941
2942         As suggested by Darin Adler.
2943
2944         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2945         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2946
2947 2019-04-17  Chris Dumez  <cdumez@apple.com>
2948
2949         Remember device orientation permission for the duration of the browsing session
2950         https://bugs.webkit.org/show_bug.cgi?id=196992
2951         <rdar://problem/49946067>
2952
2953         Reviewed by Alex Christensen.
2954
2955         Add API test coverage.
2956
2957         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2958         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2959         (TEST):
2960
2961 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2962
2963         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2964         https://bugs.webkit.org/show_bug.cgi?id=196675
2965
2966         Reviewed by Lucas Forschler.
2967
2968         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2969         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2970
2971 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2972
2973         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2974         https://bugs.webkit.org/show_bug.cgi?id=196919
2975         <rdar://problem/41630459>
2976
2977         Reviewed by Tim Horton.
2978
2979         Add iOS support for several new testing hooks. See below for more detail.
2980
2981         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2982         (WTR::UIScriptController::isDismissingMenu const):
2983
2984         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2985         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2986         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2987
2988         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2989         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2990         (WTR::UIScriptController::isDismissingMenu const):
2991         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2992         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2993         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2994         (WTR::InjectedBundle::didReceiveMessageToPage):
2995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2996         (WTR::TestRunner::setAllowedMenuActions):
2997
2998         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2999         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3000         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3001         against the name of the custom action.
3002
3003         (WTR::TestRunner::installCustomMenuAction):
3004
3005         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3006         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3007         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3008         triggered.
3009
3010         (WTR::TestRunner::performCustomMenuAction):
3011
3012         Invoked when the custom menu action is triggered.
3013
3014         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3015         * WebKitTestRunner/TestController.cpp:
3016         (WTR::TestController::installCustomMenuAction):
3017         (WTR::TestController::setAllowedMenuActions):
3018         * WebKitTestRunner/TestController.h:
3019         * WebKitTestRunner/TestInvocation.cpp:
3020         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3021         (WTR::TestInvocation::performCustomMenuAction):
3022
3023         Add plumbing to call back into the injected bundle when performing the custom action.
3024
3025         * WebKitTestRunner/TestInvocation.h:
3026         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3027         (WTR::TestController::installCustomMenuAction):
3028         (WTR::TestController::setAllowedMenuActions):
3029         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3030         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3031         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3032         (-[TestRunnerWKWebView becomeFirstResponder]):
3033         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3034
3035         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3036         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3037         in the Mail app on iOS.
3038
3039         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3040         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3041         (-[TestRunnerWKWebView resetCustomMenuAction]):
3042         (-[TestRunnerWKWebView performCustomAction:]):
3043         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3044         (-[TestRunnerWKWebView _willHideMenu]):
3045         (-[TestRunnerWKWebView _didHideMenu]):
3046         * WebKitTestRunner/ios/TestControllerIOS.mm:
3047         (WTR::TestController::platformResetStateToConsistentValues):
3048
3049         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3050         if specified.
3051
3052         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3053         (WTR::UIScriptController::isDismissingMenu const):
3054
3055 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3056
3057         Allow sharing from imageSheet on an image document
3058         https://bugs.webkit.org/show_bug.cgi?id=196891
3059         <rdar://problem/25377386>
3060
3061         Reviewed by Tim Horton.
3062
3063         Test to make sure that the correct imageURL is extracted from an image element.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3066         (TestWebKitAPI::TEST):
3067
3068 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3069
3070         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3071         https://bugs.webkit.org/show_bug.cgi?id=196995
3072
3073         Reviewed by Brady Eidson.
3074
3075         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3076         (TEST):
3077
3078 2019-04-16  Chris Dumez  <cdumez@apple.com>
3079
3080         URL set by document.open() is not communicated to the UIProcess
3081         https://bugs.webkit.org/show_bug.cgi?id=196941
3082         <rdar://problem/49237544>
3083
3084         Reviewed by Geoff Garen.
3085
3086         Add API test coverage.
3087
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3090         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3091         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3092         (TEST):
3093
3094 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3095
3096         Unreviewed, rolling out r244321.
3097         https://bugs.webkit.org/show_bug.cgi?id=196968
3098
3099         Causing all WK2 Debug builds to exit early after Assertion
3100         failures. (Requested by ShawnRoberts on #webkit).
3101
3102         Reverted changeset:
3103
3104         "URL set by document.open() is not communicated to the
3105         UIProcess"
3106         https://bugs.webkit.org/show_bug.cgi?id=196941
3107         https://trac.webkit.org/changeset/244321
3108
3109 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3110
3111         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3112         https://bugs.webkit.org/show_bug.cgi?id=196948
3113
3114         Reviewed by Zalan Bujtas.
3115
3116         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3117         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3118
3119 2019-04-15  Chris Dumez  <cdumez@apple.com>
3120
3121         URL set by document.open() is not communicated to the UIProcess
3122         https://bugs.webkit.org/show_bug.cgi?id=196941
3123         <rdar://problem/49237544>
3124
3125         Reviewed by Geoffrey Garen.
3126
3127         Add API test coverage.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3131         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3132         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3133         (TEST):
3134
3135 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3136
3137         Using Tools/Scripts/clean-webkit should not install requests
3138         https://bugs.webkit.org/show_bug.cgi?id=196940
3139
3140         Reviewed by Lucas Forschler.
3141
3142         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3143         existing, depending on the path autoinstalled is run through.
3144         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3145         needed.
3146         (Port.configuration_for_upload):
3147         (Port.commits_for_upload):
3148
3149 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3150
3151         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3152         https://bugs.webkit.org/show_bug.cgi?id=196773
3153
3154         Reviewed by Jer Noble.
3155
3156         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3157         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3158         (TEST):
3159
3160 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3161
3162         ews-build should clearly indicate flaky test failures
3163         https://bugs.webkit.org/show_bug.cgi?id=196947
3164
3165         Reviewed by Lucas Forschler.
3166
3167         * BuildSlaveSupport/ews-build/steps.py:
3168         (AnalyzeAPITestsResults.analyzeResults):
3169
3170 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3171
3172         InjectedBundle parameters often need initialization function called before unarchiving
3173         https://bugs.webkit.org/show_bug.cgi?id=189709
3174         <rdar://problem/44573653>
3175
3176         Reviewed by Ryosuke Niwa.
3177
3178         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3179         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3180
3181 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3182
3183         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3184         https://bugs.webkit.org/show_bug.cgi?id=196681
3185
3186         Reviewed by Darin Adler.
3187
3188         Added tests.
3189
3190         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3191         (WTF_HashSet.RemoveIf):
3192         (WTF_HashSet.RemoveIfShrinkToBestSize):
3193
3194 2019-04-15  John Wilander  <wilander@apple.com>
3195
3196         Send delayed Ad Click Attribution conversion requests to the click source
3197         https://bugs.webkit.org/show_bug.cgi?id=196838
3198         <rdar://problem/47650157>
3199
3200         Reviewed by Chris Dumez and Youenn Fablet.
3201
3202         This patch adds test infrastructure to override the default behavior in
3203         WebKit::NetworkAdClickAttribution.
3204
3205         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3206         (TestWebKitAPI::TEST):
3207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3209         (WTR::TestRunner::dumpAdClickAttribution):
3210         (WTR::TestRunner::clearAdClickAttribution):
3211         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3212         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3214         * WebKitTestRunner/TestController.cpp:
3215         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3216         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3217         * WebKitTestRunner/TestController.h:
3218         * WebKitTestRunner/TestInvocation.cpp:
3219         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3220
3221 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3222
3223         [ews-app] status-bubble should display position in queue
3224         https://bugs.webkit.org/show_bug.cgi?id=196607
3225
3226         Reviewed by Lucas Forschler.
3227
3228         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3229         (StatusBubble._build_bubble):
3230         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3231
3232 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3233
3234         [ews-build] Do not run clean build by default on EWS builders
3235         https://bugs.webkit.org/show_bug.cgi?id=196897
3236
3237         Reviewed by Lucas Forschler.
3238
3239         * BuildSlaveSupport/ews-build/steps.py:
3240         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3241         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3242         untracked directories like WebKitBuild).
3243         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3244         untracked files/directories (like WebKitBuild).
3245
3246 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3247
3248         TestRunner::notifyDone() should be safely reentrant
3249         https://bugs.webkit.org/show_bug.cgi?id=196898
3250
3251         Reviewed by Darin Adler.
3252
3253         It is currently possible that TestRunner::notifyDone() will call itself, since
3254         notifyDone() will force a repaint, which can start executing JavaScript, which
3255         may call notifyDone() again. This can lead to test failures and flakiness.
3256         Fix this by setting the m_waitToDump flag before calling the dump() method.
3257
3258         * DumpRenderTree/mac/TestRunnerMac.mm:
3259         (TestRunner::notifyDone):
3260         (TestRunner::forceImmediateCompletion):
3261         * DumpRenderTree/win/TestRunnerWin.cpp:
3262         (TestRunner::notifyDone):
3263         (TestRunner::forceImmediateCompletion):
3264
3265 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3266
3267         [GTK][WPE] Add enable-media websetting
3268         https://bugs.webkit.org/show_bug.cgi?id=196863
3269
3270         Reviewed by Michael Catanzaro.
3271
3272         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3273         (testWebKitSettings): Add test for the enable-media web-setting.
3274
3275 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3276
3277         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3278         https://bugs.webkit.org/show_bug.cgi?id=196905
3279         <rdar://problem/49886096>
3280
3281         Reviewed by Tim Horton.
3282
3283         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3284         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3285         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3286         delay timer, we end up with this sequence of events in the problematic (failure) case:
3287
3288         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3289             ...IPC from UI to web process...
3290         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3291             ...IPC from web to UI process...
3292         (c) [UI]    Invoke completion handler for script #1
3293         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3294             ...IPC from UI to web process...
3295         (e) [Web]   Evaluate script #2 in the web process
3296         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3297
3298         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3299         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3300         #2 is run in step (e).
3301
3302         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3303         the UI process by waiting on a script message posted by the web process, after attachment updates are
3304         dispatched.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3307         (TestWebKitAPI::TEST):
3308
3309 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3310
3311         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3312         https://bugs.webkit.org/show_bug.cgi?id=196909
3313
3314         Reviewed by Wenson Hsieh.
3315
3316         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3317         (TestWebKitAPI::TEST):
3318
3319 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3320
3321         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3322         https://bugs.webkit.org/show_bug.cgi?id=196880
3323
3324         Reviewed by Yusuke Suzuki.
3325
3326         Add a new function for bytecode cache tests that does not forceDiskCache
3327         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3328         test added in this patch, since the code is invalid and therefore won't be
3329         cached. It should also be useful for tests that evaluate dynamically
3330         generated code.
3331
3332         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3333         * Scripts/run-jsc-stress-tests:
3334
3335 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3336
3337         Update AudioSession route sharing policy
3338         https://bugs.webkit.org/show_bug.cgi?id=196776
3339         <rdar://problem/46501611>
3340
3341         Reviewed by Jer Noble.
3342
3343         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3344         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3345         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3346         (TestWebKitAPI::TEST):
3347
3348 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3349
3350         [iOS] Software keyboard is shown too frequently on some websites
3351         https://bugs.webkit.org/show_bug.cgi?id=195856
3352         <rdar://problem/49191395>
3353
3354         Reviewed by Darin Adler.
3355
3356         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3357
3358         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3359         (WTR::UIScriptController::setHardwareKeyboardAttached):
3360         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3361         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3362         (WTR::UIScriptController::setHardwareKeyboardAttached):
3363         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3364         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3365
3366         Additionally link against GraphicsServices in WebKitTestRunner.
3367
3368         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3369         (WTR::TestController::platformResetStateToConsistentValues):
3370         (WTR::UIScriptController::setHardwareKeyboardAttached):
3371
3372 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3373
3374         [GTK][WPE] Fix pacman install-dependencies packages
3375         https://bugs.webkit.org/show_bug.cgi?id=196817
3376
3377         Reviewed by Žan Doberšek.
3378         
3379         python3-setuptools is called python-setuptools
3380         ruby-highline is only available on AUR
3381         libv4l-devel is incorporated in v4l-utils
3382
3383         * gtk/install-dependencies:
3384         * wpe/install-dependencies:
3385
3386 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3387
3388         [GTK] REGRESSION(r243860): Many tests failing
3389         https://bugs.webkit.org/show_bug.cgi?id=196791
3390
3391         Reviewed by Joanmarie Diggs.
3392
3393         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3394         multiple documents and check that accessibility hierarchy is updated after a navigation.
3395
3396         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3397         (loadChangedCallback):
3398         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3399         (AccessibilityTest::AccessibilityTest):
3400         (AccessibilityTest::~AccessibilityTest):
3401         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3402         (AccessibilityTest::findTestServerApplication):
3403         (AccessibilityTest::findDocumentWeb):
3404         (AccessibilityTest::findRootObject):
3405         (AccessibilityTest::waitUntilChildrenRemoved):
3406         (AccessibilityTest::ensureProxy):
3407         (testAtspiBasicHierarchy):
3408         (beforeAll):
3409         (afterAll):
3410
3411 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3412
3413         [ews-build] Handle bug titles with unicode characters
3414         https://bugs.webkit.org/show_bug.cgi?id=196802
3415
3416         Reviewed by Dewei Zhu.
3417
3418         * BuildSlaveSupport/ews-build/steps.py:
3419         (ValidatePatch._is_bug_closed):
3420
3421 2019-04-11  Michael Saboff  <msaboff@apple.com>
3422
3423         Improve the Inline Cache Stats code
3424         https://bugs.webkit.org/show_bug.cgi?id=196836
3425
3426         Reviewed by Saam Barati.
3427
3428         Added a new script to consolidate and arrange the output of --useICStats option.
3429
3430         This script merges the output from every group into one large table and sorts it from most common to
3431         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3432         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3433         Put together, this is useful to see what property accesses are not getting cached.
3434
3435         * Scripts/ic-stats.py: Added.
3436         (ICStats):
3437         (ICStats.__init__):
3438         (ICStats.parse):
3439         (ICStats.dumpStats):
3440         (usage):
3441
3442 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3443
3444         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3445         https://bugs.webkit.org/show_bug.cgi?id=196809
3446         <rdar://49800762>
3447
3448         Reviewed by Brady Eidson.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3451         (TEST):
3452
3453 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3454
3455         requestAnimationFrame should execute before the next frame
3456         https://bugs.webkit.org/show_bug.cgi?id=177484
3457
3458         Reviewed by Simon Fraser.
3459
3460         Add trace points for the page RenderingUpdate.
3461
3462         * Tracing/SystemTracePoints.plist:
3463
3464 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3465
3466         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3467         https://bugs.webkit.org/show_bug.cgi?id=196760
3468
3469         Reviewed by Don Olmstead.
3470
3471         vswhere.exe has been bundled since Visual Studio 2017 version
3472         15.2. We shouldn't download vswhere.exe.
3473
3474         * Scripts/build-jsc: Do not call update-vswhere.py.
3475         * Scripts/build-webkit: Ditto.
3476         * Scripts/update-vswhere.py: Removed.
3477         * Scripts/webkitdirs.pm:
3478         (requireModulesForVSWhere): Deleted.
3479         (pickCurrentVisualStudioInstallation): Deleted.
3480         (visualStudioInstallDirVSWhere): Return the latest installed VS
3481         installation path by using the bundled vswhere.exe.
3482         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3483         (visualStudioInstallDirFallback): Removed.
3484
3485 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3486
3487         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3488         https://bugs.webkit.org/show_bug.cgi?id=196780
3489
3490         Reviewed by Alexey Proskuryakov.
3491
3492         * BuildSlaveSupport/ews-build/steps.py:
3493         * BuildSlaveSupport/ews-build/steps_unittest.py:
3494
3495 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3496
3497         Add SPI WKNavigationResponse._downloadAttribute
3498         https://bugs.webkit.org/show_bug.cgi?id=196755
3499         <rdar://49587365>
3500
3501         Reviewed by Brady Eidson.
3502
3503         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3504         (-[NavigationResponseTestDelegate navigationResponse]):
3505         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3506         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3507         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3508         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3509         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3510         (readRequest):
3511         (writeResponse):
3512         (TEST):
3513
3514 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3515
3516         Add modern API for overriding the page's specified viewport configuration
3517         https://bugs.webkit.org/show_bug.cgi?id=167734
3518         <rdar://problem/30331795>
3519
3520         Reviewed by Simon Fraser.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3524
3525 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3526
3527         Add support for incremental bytecode cache updates
3528         https://bugs.webkit.org/show_bug.cgi?id=195000
3529
3530         Reviewed by Filip Pizlo.
3531
3532         Exit when the initial run to generate bytecode fails.
3533
3534         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3535
3536 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3537
3538         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3539         https://bugs.webkit.org/show_bug.cgi?id=196744
3540         <rdar://49415309>
3541
3542         Reviewed by Chris Dumez.
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3545         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3546
3547 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3548
3549         Add a way to opt into modern compatibility mode in layout tests
3550         https://bugs.webkit.org/show_bug.cgi?id=196770
3551         <rdar://problem/49777550>
3552
3553         Reviewed by Antoine Quint.
3554
3555         Add a new test option to enable modern compatibility mode in layout tests.
3556
3557         * WebKitTestRunner/TestController.cpp:
3558         (WTR::updateTestOptionsFromTestHeader):
3559         * WebKitTestRunner/TestController.h:
3560         * WebKitTestRunner/TestOptions.h:
3561         (WTR::TestOptions::hasSameInitializationOptions const):
3562         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3563         (WTR::TestController::platformCreateWebView):
3564         (WTR::TestController::enableModernCompatibilityMode):
3565
3566 2019-04-10  Andy Estes  <aestes@apple.com>
3567
3568         Try to fix the 32-bit watchOS build.
3569
3570         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3571         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3572
3573 2019-04-10  Antoine Quint  <graouts@apple.com>
3574
3575         Enable Pointer Events on watchOS
3576         https://bugs.webkit.org/show_bug.cgi?id=196771
3577         <rdar://problem/49040909>
3578
3579         Reviewed by Dean Jackson.
3580
3581         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3582
3583 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3584
3585         Unreviewed. Fix WPE accessibility tests after r244059.
3586
3587         We are failing to load the injected bundle due to undefined symbol
3588         AccessibilityUIElement::replaceTextInRange().
3589
3590         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3591         (WTR::AccessibilityUIElement::replaceTextInRange):
3592
3593 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3594
3595         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3596         https://bugs.webkit.org/show_bug.cgi?id=196727
3597
3598         Reviewed by Fujii Hironori.
3599
3600         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3601         (WebKitBrowserWindow::create):
3602
3603 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3604
3605         [ews-build] Add unit tests for PrintConfiguration
3606         https://bugs.webkit.org/show_bug.cgi?id=196752
3607
3608         Reviewed by Dewei Zhu.
3609
3610         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3611
3612 2019-04-09  Keith Rollin  <krollin@apple.com>
3613
3614         Unreviewed build maintenance -- update .xcfilelists.
3615
3616         * DumpRenderTree/DerivedSources-input.xcfilelist:
3617         * DumpRenderTree/DerivedSources-output.xcfilelist:
3618
3619 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3620
3621         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3622         https://bugs.webkit.org/show_bug.cgi?id=196743
3623         <rdar://problem/43897551>
3624
3625         Reviewed by Tim Horton.
3626
3627         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3628         (TEST):
3629
3630 2019-04-09  Youenn Fablet  <youenn@apple.com>
3631
3632         Close service worker database on network process suspension
3633         https://bugs.webkit.org/show_bug.cgi?id=196623
3634         <rdar://problem/48930869>
3635
3636         Reviewed by Alex Christensen.
3637
3638         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3639
3640 2019-04-09  Daniel Bates  <dabates@apple.com>
3641
3642         [iPad] Should open popover when the spacebar is pressed
3643         https://bugs.webkit.org/show_bug.cgi?id=196360
3644         <rdar://problem/49389129>
3645
3646         Reviewed by Brent Fulgham.
3647
3648         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3649
3650         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3651         (WTR::UIScriptController::isShowingPopover const): Added.
3652         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3653         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3655         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3656         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3657         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3658         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3659         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3660         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3661         (WTR::UIScriptController::isShowingPopover const): Added.
3662         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3663         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3664         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3665         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3666         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3667         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3668         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3669         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3670         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3671         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3672         (WTR::UIScriptController::isShowingPopover const): Added.
3673         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3674         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3675
3676 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3677
3678         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3679         https://bugs.webkit.org/show_bug.cgi?id=196665
3680         <rdar://45115669>
3681
3682         Reviewed by Geoff Garen.
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3685         (goBack):
3686         (+[SimpleLookupContext sharedLookupContext]):
3687         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3688         (TEST):
3689         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3690         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3691
3692 2019-04-09  John Wilander  <wilander@apple.com>
3693
3694         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3695         https://bugs.webkit.org/show_bug.cgi?id=196558
3696         <rdar://problem/47650245>
3697
3698         Reviewed by Youenn Fablet.
3699
3700         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3701         (TestWebKitAPI::TEST):
3702             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3703
3704 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3705
3706         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3707         https://bugs.webkit.org/show_bug.cgi?id=196720
3708
3709         Reviewed by Konstantin Tokarev.
3710
3711         * TestWebKitAPI/PlatformMac.cmake:
3712
3713 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3714
3715         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3716         https://bugs.webkit.org/show_bug.cgi?id=196694
3717         <rdar://problem/48388734>
3718
3719         Rubber-stamped by Aakash Jain.
3720
3721         * Scripts/webkitpy/port/image_diff.py:
3722         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3723         * Scripts/webkitpy/port/server_process.py:
3724         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3725         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3726         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3727         * Scripts/webkitpy/port/server_process_mock.py:
3728         (MockServerProcess.has_available_stdout):
3729         * Scripts/webkitpy/port/server_process_unittest.py:
3730         (TestServerProcess.serial_test_basic):
3731
3732 2019-04-09  Jer Noble  <jer.noble@apple.com>
3733
3734         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3735         https://bugs.webkit.org/show_bug.cgi?id=196097
3736
3737         Reviewed by Eric Carlson.
3738
3739         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3740
3741         * DumpRenderTree/mac/DumpRenderTree.mm:
3742         (resetWebPreferencesToConsistentValues):
3743         * WebKitTestRunner/TestController.cpp:
3744         (WTR::TestController::resetPreferencesToConsistentValues):
3745
3746 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3747
3748         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3749         https://bugs.webkit.org/show_bug.cgi?id=196690
3750
3751         Reviewed by Michael Catanzaro.
3752
3753         * QueueStatusServer/config/queues.py:
3754         * Scripts/webkitpy/common/config/ews.json:
3755         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3756         (test_ews_name):
3757
3758 2019-04-09  Chris Dumez  <cdumez@apple.com>
3759
3760         Loads using loadHTMLString() cause flashing when process-swapping
3761         https://bugs.webkit.org/show_bug.cgi?id=196714
3762         <rdar://problem/49637354>
3763
3764         Reviewed by Antti Koivisto.
3765
3766         Add API test coverage.
3767
3768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3769
3770 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3771
3772         Unreviewed. Fix ATK accessibility tests after r244059.
3773
3774         We are failing to load the injected bundle due to undefined symbol
3775         AccessibilityUIElement::replaceTextInRange().
3776
3777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3778         (WTR::AccessibilityUIElement::replaceTextInRange):
3779
3780 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3781
3782         AX: Support API: accessibilityReplaceRange:withText
3783         https://bugs.webkit.org/show_bug.cgi?id=196636
3784
3785         Unreviewed build fix for Windows port.
3786
3787         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3788         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3789
3790 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3791
3792         [CMake][WinCairo] Separate copied headers into different directories
3793         https://bugs.webkit.org/show_bug.cgi?id=196655
3794
3795         Reviewed by Michael Catanzaro.
3796
3797         * DumpRenderTree/CMakeLists.txt:
3798         * MiniBrowser/win/CMakeLists.txt:
3799         * TestWebKitAPI/CMakeLists.txt:
3800         * TestWebKitAPI/PlatformWin.cmake:
3801
3802 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3803
3804         Log stack-trace for run-webkit-tests when interrupted
3805         https://bugs.webkit.org/show_bug.cgi?id=176393
3806         <rdar://problem/34262310>
3807
3808         Reviewed by Lucas Forschler.
3809
3810         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3811         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3812         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3813         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3814         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3816         (main): Set handlers to log stack trace on interruption.
3817
3818 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3819
3820         AX: Support API: accessibilityReplaceRange:withText
3821         https://bugs.webkit.org/show_bug.cgi?id=196636
3822
3823         Unreviewed build fix for Windows port.
3824
3825         * DumpRenderTree/AccessibilityUIElement.cpp:
3826         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3827
3828 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3829
3830         [ews-build] Scripts using Buildbot API have CORS error
3831         https://bugs.webkit.org/show_bug.cgi?id=196709
3832
3833         Reviewed by Alexey Proskuryakov.
3834
3835         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3836
3837 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3838
3839         AX: Support API: accessibilityReplaceRange:withText
3840         https://bugs.webkit.org/show_bug.cgi?id=196636
3841
3842         Reviewed by Daniel Bates.
3843
3844         * DumpRenderTree/AccessibilityUIElement.cpp:
3845         (replaceTextInRangeCallback):
3846         (AccessibilityUIElement::replaceTextInRange):
3847         (AccessibilityUIElement::getJSClass):
3848         * DumpRenderTree/AccessibilityUIElement.h:
3849         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3850         (AccessibilityUIElement::replaceTextInRange):
3851         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3852         (AccessibilityUIElement::replaceTextInRange):
3853         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3854         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3855         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3856         (WTR::AccessibilityUIElement::replaceTextInRange):
3857         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3858         (WTR::AccessibilityUIElement::replaceTextInRange):
3859
3860 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3861
3862         [iOS] Do not allow starting selection drags when selection views are not visible
3863         https://bugs.webkit.org/show_bug.cgi?id=196686
3864         <rdar://problem/49399192>
3865
3866         Reviewed by Tim Horton.
3867
3868         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3869         also add some new API tests to cover scenarios where the web view is not first responder.
3870
3871         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3872         (TestWebKitAPI::TEST):
3873         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3874
3875         Add a switch to optionally make the web view first responder when starting the simulated drag.
3876
3877         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3878         (-[DragAndDropSimulator initWithWebView:]):
3879         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3880
3881 2019-04-08  Justin Fan  <justin_fan@apple.com>
3882
3883         [Web GPU] Fix Web GPU experimental feature on iOS
3884         https://bugs.webkit.org/show_bug.cgi?id=196632
3885
3886         Reviewed by Myles C. Maxfield.
3887
3888         Properly make Web GPU available on iOS 11+.
3889
3890         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3891
3892 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3893
3894         [ews-build] Do not upload archive when Compile Fails
3895         https://bugs.webkit.org/show_bug.cgi?id=196674
3896
3897         Reviewed by Alexey Proskuryakov.
3898
3899         * BuildSlaveSupport/ews-build/factories.py:
3900         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3901         * BuildSlaveSupport/ews-build/steps.py:
3902         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3903         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3904         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3905
3906 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3907
3908         Enable DFG on MIPS
3909         https://bugs.webkit.org/show_bug.cgi?id=196689
3910
3911         Reviewed by Žan Doberšek.
3912
3913         Since the bytecode change, we enabled the baseline JIT on mips in
3914         r240432, but DFG is still missing. With this change, all tests are
3915         passing on a ci20 board.
3916
3917         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3918
3919 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3920
3921         [Flatpak] Second run update-webkitwpe-flatpak fails
3922         https://bugs.webkit.org/show_bug.cgi?id=192702
3923
3924         Reviewed by Carlos Garcia Campos.
3925
3926         * flatpak/flatpakutils.py:
3927         (FlatpakObject.flatpak): Fix typo.
3928         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3929         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3930
3931 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3932
3933         [GTK][WPE] outlook.live.com displays old-fashioned UI
3934         https://bugs.webkit.org/show_bug.cgi?id=196642
3935
3936         Reviewed by Carlos Garcia Campos.
3937
3938         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3939         (TestWebKitAPI::TEST): New Mac platform quirk test.
3940
3941 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3942
3943         Unreviewed, rolling out r243956.
3944         https://bugs.webkit.org/show_bug.cgi?id=196688
3945
3946         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3947         by aakashjain on #webkit).
3948
3949         Reverted changeset:
3950
3951         "Clicking "Go Back" from a safe browsing warning from an
3952         iframe should navigate the WKWebView back to the previous
3953         page"
3954         https://bugs.webkit.org/show_bug.cgi?id=196665
3955         https://trac.webkit.org/changeset/243956
3956
3957 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3958
3959         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3960         https://bugs.webkit.org/show_bug.cgi?id=196669
3961
3962         Reviewed by Geoffrey Garen.
3963
3964         Added three new unit tests for WeakHashSet.
3965
3966         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3967         (WTF_WeakPtr.WeakHashSetConstObjects):
3968         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3969         (WTF_WeakPtr.WeakHashSetComputeSize):
3970
3971 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3972
3973         Hide next and previous form control buttons when WKWebView is editable
3974         https://bugs.webkit.org/show_bug.cgi?id=196672
3975         <rdar://problem/35625321>
3976
3977         Reviewed by Tim Horton.
3978
3979         Add a new API test.
3980
3981         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3982         (-[TestWKWebView lastTrailingBarButtonGroup]):
3983         (TestWebKitAPI::TEST):
3984         * TestWebKitAPI/ios/UIKitSPI.h:
3985
3986 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3987
3988         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3989         https://bugs.webkit.org/show_bug.cgi?id=196077
3990         <rdar://problem/49108202>
3991
3992         Reviewed by Chris Dumez.
3993
3994         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3995         on new web view.
3996
3997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3998
3999 2019-04-05  Saam Barati  <sbarati@apple.com>
4000
4001         Make compare-results understand MotionMark
4002         https://bugs.webkit.org/show_bug.cgi?id=196666
4003
4004         Reviewed by Yusuke Suzuki.
4005
4006         * Scripts/compare-results:
4007         (PLT5Results):
4008         (detectMotionMark):
4009         (detectMotionMark1_1):
4010         (motionMarkResults):
4011         (motionMark1_1Results):
4012         (detectBenchmark):
4013         (biggerIsBetter):
4014         (main):
4015
4016 2019-04-05  Alex Christensen  <achristensen@webkit.org>
4017
4018         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
4019         https://bugs.webkit.org/show_bug.cgi?id=196665
4020         <rdar://45115669>
4021
4022         Reviewed by Geoff Garen.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4025         (goBack):
4026         (+[SimpleLookupContext sharedLookupContext]):
4027         (-[SimpleLookupContext lookUpURL:completionHandler:]):
4028         (TEST):
4029         (+[Simple3LookupContext sharedLookupContext]): Deleted.
4030         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
4031
4032 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
4033
4034         [ews-build] Add configuration and architecture for windows builders
4035         https://bugs.webkit.org/show_bug.cgi?id=196660
4036
4037         Reviewed by Lucas Forschler.
4038
4039         * BuildSlaveSupport/ews-build/config.json:
4040
4041 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
4042
4043         webkitpy: Don't run subsequent rounds if interrupted
4044         https://bugs.webkit.org/show_bug.cgi?id=196646
4045
4046         Reviewed by Aakash Jain.
4047
4048         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4049         (Manager.run): Bail out if interrupted.
4050
4051 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
4052
4053         Test sessionStorage in PSON private browsing mode
4054         https://bugs.webkit.org/show_bug.cgi?id=196561
4055
4056         Reviewed by Alex Christensen.
4057
4058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4059
4060 2019-04-05  Commit Queue  <commit-queue@webkit.org>
4061
4062         Unreviewed, rolling out r243833.
4063         https://bugs.webkit.org/show_bug.cgi?id=196645
4064
4065         This change breaks build of WPE and GTK ports (Requested by
4066         annulen on #webkit).
4067
4068         Reverted changeset:
4069
4070         "[CMake][WTF] Mirror XCode header directories"
4071         https://bugs.webkit.org/show_bug.cgi?id=191662
4072         https://trac.webkit.org/changeset/243833
4073
4074 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
4075
4076         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
4077         https://bugs.webkit.org/show_bug.cgi?id=196635
4078
4079         Reviewed by Antti Koivisto.
4080         
4081         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
4082         for a test to enable async frame scrolling via:
4083             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
4084         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
4085         
4086         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
4087
4088         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4089         (WTR::InjectedBundle::beginTesting):
4090         * WebKitTestRunner/TestController.cpp:
4091         (WTR::TestController::resetPreferencesToConsistentValues):
4092
4093 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
4094
4095         Use a correct LC_RPATH when building with ASan
4096         https://bugs.webkit.org/show_bug.cgi?id=196576
4097
4098         Reviewed by David Kilzer.
4099
4100         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
4101         so that ../Frameworks is checked. This is simpler and more reliable than updating
4102         each SPC service xcconfig.
4103
4104 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4105
4106         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4107         https://bugs.webkit.org/show_bug.cgi?id=196629
4108
4109         Reviewed by Lucas Forschler.
4110
4111         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4112
4113 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4114
4115         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4116         https://bugs.webkit.org/show_bug.cgi?id=196618
4117
4118         Reviewed by Lucas Forschler.
4119
4120         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4121         (StatusBubble): Added QUEUE_TRIGGERS.
4122         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
4123         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
4124         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4125         its parent(builder).
4126
4127 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4128
4129         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4130         https://bugs.webkit.org/show_bug.cgi?id=196625
4131
4132         Reviewed by Lucas Forschler.
4133
4134         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4135         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4136
4137 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4138
4139         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4140         https://bugs.webkit.org/show_bug.cgi?id=196630
4141
4142         Reviewed by Wenson Hsieh.
4143
4144         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4145
4146 2019-04-04  Youenn Fablet  <youenn@apple.com>
4147
4148         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4149         https://bugs.webkit.org/show_bug.cgi?id=196543
4150
4151         Reviewed by Alex Christensen.
4152
4153         * WebKitTestRunner/TestController.cpp:
4154         (WTR::TestController::generatePageConfiguration):
4155
4156 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4157
4158         [ews-app] Status bubble should not display skipped buildbot steps
4159         https://bugs.webkit.org/show_bug.cgi?id=196584
4160
4161         Reviewed by Lucas Forschler.
4162
4163         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4164
4165 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4166
4167         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4168         https://bugs.webkit.org/show_bug.cgi?id=196620
4169
4170         Reviewed by Lucas Forschler.
4171
4172         * BuildSlaveSupport/ews-app/ews/config.py:
4173
4174 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4175
4176         [Win] DumpRenderTreeWatchDog.py is not checked into source
4177         https://bugs.webkit.org/show_bug.cgi?id=196567
4178         <rdar://problem/49525901>
4179
4180         Reviewed by Lucas Forschler.
4181
4182         This script is used on Win EWS bots to terminate hanging DRT processes.
4183
4184         * EWSTools/dumprendertreewatchdog.py: Added.
4185
4186 2019-04-04  Chris Dumez  <cdumez@apple.com>
4187
4188         Unreviewed, roll out r243858 which made tests time out.
4189
4190         Disable new API tests on Windows instead.
4191
4192         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4193         (TestWebKitAPI::TEST):
4194
4195 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4196
4197         [ATK] Cleanup WebPageAccessibilityObjectAtk
4198         https://bugs.webkit.org/show_bug.cgi?id=196537
4199
4200         Reviewed by Michael Catanzaro.
4201
4202         Also consider files under atk directories as exceptions for GObject conventions.
4203
4204         * Scripts/webkitpy/style/checkers/cpp.py:
4205         (check_identifier_name_in_declaration):
4206
4207 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
4208
4209         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4210         https://bugs.webkit.org/show_bug.cgi?id=196588
4211         <rdar://problem/49365787>
4212
4213         Unreviewed build fix for Windows port.
4214
4215         error C3861: 'kill': identifier not found
4216
4217         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4218         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
4219
4220 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4221
4222         [ews-build] Cancel build and similar operations should have authentication
4223         https://bugs.webkit.org/show_bug.cgi?id=196520
4224
4225         Reviewed by Dewei Zhu.
4226
4227         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
4228         environment variables.
4229
4230 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4231
4232         [ews-build] Do not trigger queues which are not in production yet
4233         https://bugs.webkit.org/show_bug.cgi?id=196581
4234
4235         Reviewed by Dewei Zhu.
4236
4237         * BuildSlaveSupport/ews-build/config.json:
4238
4239 2019-04-03  Chris Dumez  <cdumez@apple.com>
4240
4241         Unreviewed, fix typo in the name of API test added in r243848.
4242
4243         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4244         (TestWebKitAPI::TEST):
4245
4246 2019-04-03  Chris Dumez  <cdumez@apple.com>
4247
4248         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4249         https://bugs.webkit.org/show_bug.cgi?id=196588
4250         <rdar://problem/49365787>
4251
4252         Reviewed by Ryosuke Niwa.
4253
4254         Add API test coverage.
4255
4256         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4257         (TestWebKitAPI::nullJavaScriptCallback):
4258         (TestWebKitAPI::didCrashCheckFrames):
4259         (TestWebKitAPI::TEST):
4260
4261 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4262
4263         run-webkit-tests: Upload test results (new results database)
4264         https://bugs.webkit.org/show_bug.cgi?id=196577
4265         <rdar://problem/34841155>
4266
4267         Reviewed by Lucas Forschler.
4268
4269         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4270         (Manager.run): Upload results after each device shard, since the configuration will be
4271         different for each device.
4272         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
4273         uploaded to a results database.
4274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4275         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
4276
4277 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4278
4279         -apple-trailing-word is needed for browser detection
4280         https://bugs.webkit.org/show_bug.cgi?id=196575
4281
4282         Unreviewed.
4283
4284         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4285
4286 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
4287
4288         [CMake][WTF] Mirror XCode header directories
4289         https://bugs.webkit.org/show_bug.cgi?id=191662
4290
4291         Reviewed by Konstantin Tokarev.
4292
4293         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
4294         builds.
4295
4296         * CMakeLists.txt:
4297         * DumpRenderTree/CMakeLists.txt:
4298         * DumpRenderTree/PlatformWin.cmake:
4299         * MiniBrowser/win/CMakeLists.txt:
4300         * TestWebKitAPI/CMakeLists.txt:
4301         * TestWebKitAPI/PlatformWin.cmake:
4302         * WebKitTestRunner/PlatformGTK.cmake:
4303         * WebKitTestRunner/PlatformWin.cmake:
4304
4305 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4306
4307         [ews-app] Status bubble should not display certain infrastructure status messages
4308         https://bugs.webkit.org/show_bug.cgi?id=196550
4309
4310         Reviewed by Lucas Forschler.
4311
4312         Do not display the steps which are un-needed for end-user. This information is still avaiable
4313         if the user click on the bubble and look at the Buildbot build.
4314         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4315         (StatusBubble._steps_messages):
4316         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
4317
4318 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4319
4320         [ews-build] Use https for sending data to ews-app
4321         https://bugs.webkit.org/show_bug.cgi?id=196492
4322
4323         Reviewed by Lucas Forschler.
4324
4325         * BuildSlaveSupport/ews-build/events.py:
4326