[JSC] linkPolymorphicCall now does GC
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
2
3         [JSC] linkPolymorphicCall now does GC
4         https://bugs.webkit.org/show_bug.cgi?id=197306
5
6         Reviewed by Saam Barati.
7
8         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
9         To add this test, we add `runWithoutBaseOption`.
10
11         * Scripts/run-jsc-stress-tests:
12
13 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
14
15         Update inactive reviewers' status to 'contributor'.
16
17         Accidentally skipped one at first.
18
19         * Scripts/webkitpy/common/config/contributors.json:
20
21 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
22
23         Update inactive reviewers' status to 'contributor'.
24
25         * Scripts/webkitpy/common/config/contributors.json: The change.
26
27         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
28         * Scripts/webkitpy/common/checkout/checkout_mock.py:
29         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
30         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
31         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
32         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
33         * Scripts/webkitpy/tool/commands/queries_unittest.py:
34         * Scripts/webkitpy/tool/commands/upload_unittest.py:
35         Sadly, regression tests operate on a crazy mix of mock and live data for
36         contributors.json. It would be a substantial project to mock all code paths,
37         so changing the tests instead.
38
39 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
40
41         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
42         https://bugs.webkit.org/show_bug.cgi?id=197171
43         <rdar://problem/47454979>
44
45         Reviewed by Youenn Fablet.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
49         (TestWebKitAPI::TEST):
50
51 2019-04-26  David Kilzer  <ddkilzer@apple.com>
52
53         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
54         <https://webkit.org/b/197314>
55         <rdar://problem/50245252>
56
57         Reviewed by Simon Fraser.
58
59         * WebKitTestRunner/UIScriptControllerCocoa.mm:
60         (WTR::UIScriptController::lastUndoLabel const):
61         (WTR::UIScriptController::firstRedoLabel const):
62         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
63
64         * WebKitTestRunner/ios/HIDEventGenerator.mm:
65         (-[HIDEventGenerator sendEventStream:completionBlock:]):
66         - Call -autorelease to fix leak of NSDictionary.
67
68         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
69         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
70         (WTR::UIScriptController::selectFormPopoverTitle const):
71         (WTR::UIScriptController::textContentType const):
72         (WTR::UIScriptController::formInputLabel const):
73         (WTR::UIScriptController::scrollingTreeAsText const):
74         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
75
76 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
77
78         webkitpy: Running a single test will always use the default device
79         https://bugs.webkit.org/show_bug.cgi?id=195472
80         <rdar://problem/48724825>
81
82         Reviewed by Lucas Forschler.
83
84         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
85         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
86         requested will be run regardless of what shard they are in.
87
88         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
89         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
90         * Scripts/webkitpy/layout_tests/controllers/manager.py:
91         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
92         on the default device type.
93         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
94         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
95         (RunTest.test_run_part): Ditto.
96
97 2019-04-26  Alex Christensen  <achristensen@webkit.org>
98
99         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
100         https://bugs.webkit.org/show_bug.cgi?id=197165
101
102         Reviewed by Youenn Fablet.
103
104         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
105
106 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
107
108         Replace iOS build queue hardware
109         https://bugs.webkit.org/show_bug.cgi?id=197312
110
111         Reviewed by Aakash Jain.
112
113         * BuildSlaveSupport/build.webkit.org-config/config.json:
114         Use newer hardware that supports macOS Mojave.
115
116 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
117
118         check-webkit-style complains the first block in while loop.
119         https://bugs.webkit.org/show_bug.cgi?id=197307
120
121         The style checker shouldn't complain about an open brace on
122         its own line if the last non-whitespace character on the previous
123         non-blank line is another open brace, because it's likely to
124         indicate the begining of a nested code block.
125
126         Reviewed by Alex Christensen.
127
128         * Scripts/webkitpy/style/checkers/cpp.py:
129         (check_braces):
130         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
131         (WebKitStyleTest.test_braces):
132
133 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
134
135         Stop IDB transactions to release locked database files when network process is ready to suspend
136         https://bugs.webkit.org/show_bug.cgi?id=196372
137         <rdar://problem/48930116>
138
139         Reviewed by Brady Eidson.
140
141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
142         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
143         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
144         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
145         (runTestAndCheckResult):
146         (keepNetworkProcessActive):
147         (TEST):
148
149 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
150
151         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
152         https://bugs.webkit.org/show_bug.cgi?id=188357
153         <rdar://problem/42986633>
154
155         Reviewed by Dean Jackson.
156
157         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
158         tests would fall into low memory mode and have different behavior.
159         
160         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
161         to Internals, so it's shared by DRT and WTR.
162         
163         We no longer need the WK2 C SPI glue.
164
165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
166         (WTR::InjectedBundlePage::prepare):
167
168 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
169
170         webkitpy: Including skipped tests in the final count
171         https://bugs.webkit.org/show_bug.cgi?id=197298
172         <rdar://problem/49705424>
173
174         Reviewed by Lucas Forschler.
175
176         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
177         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
178
179 2019-04-25  Timothy Hatcher  <timothy@apple.com>
180
181         Disable date and time inputs on iOSMac.
182         https://bugs.webkit.org/show_bug.cgi?id=197287
183         rdar://problem/46794376
184
185         Reviewed by Wenson Hsieh.
186
187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
188
189 2019-04-25  Alex Christensen  <achristensen@webkit.org>
190
191         Fix test-webkitpy after r244653
192         https://bugs.webkit.org/show_bug.cgi?id=197131
193
194         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
195         Also use C++17.
196
197 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
198
199         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
200         https://bugs.webkit.org/show_bug.cgi?id=196991
201         <rdar://problem/45507423>
202
203         Reviewed by Alex Christensen.
204
205         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
206         (-[NavigationTestDelegate init]):
207         (-[NavigationTestDelegate waitForDidFinishNavigation]):
208         (-[NavigationTestDelegate webView:didFinishNavigation:]):
209         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
210         (TestWebKitAPI::TEST):
211         (TEST): Deleted.
212
213 2019-04-25  Alex Christensen  <achristensen@webkit.org>
214
215         Revert some code accidentally committed with r244653
216         https://bugs.webkit.org/show_bug.cgi?id=197131
217
218         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
219         (TestWebKitAPI::TEST):
220
221 2019-04-25  Alex Christensen  <achristensen@webkit.org>
222
223         Start using C++17
224         https://bugs.webkit.org/show_bug.cgi?id=197131
225
226         Reviewed by Darin Adler.
227
228         * DumpRenderTree/mac/Configurations/Base.xcconfig:
229         * MiniBrowser/Configurations/Base.xcconfig:
230         * MobileMiniBrowser/Configurations/Base.xcconfig:
231         * TestWebKitAPI/Configurations/Base.xcconfig:
232         * WebKitTestRunner/Configurations/Base.xcconfig:
233
234 2019-04-25  Commit Queue  <commit-queue@webkit.org>
235
236         Unreviewed, rolling out r244627.
237         https://bugs.webkit.org/show_bug.cgi?id=197282
238
239         Causing internal build failures (Requested by ShawnRoberts on
240         #webkit).
241
242         Reverted changeset:
243
244         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
245         https://bugs.webkit.org/show_bug.cgi?id=197171
246         https://trac.webkit.org/changeset/244627
247
248 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
249
250         [GTK] Hardcoded text color in input fields
251         https://bugs.webkit.org/show_bug.cgi?id=126907
252
253         Reviewed by Michael Catanzaro.
254
255         Add dark-mode command line option to MiniBrowser.
256
257         * MiniBrowser/gtk/main.c:
258         (main):
259
260 2019-04-24  Zalan Bujtas  <zalan@apple.com>
261
262         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
263         https://bugs.webkit.org/show_bug.cgi?id=196948
264         <rdar://problem/49927131>
265
266         Reviewed by Tim Horton.
267
268         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
269         (TEST):
270         The expected order of incoming events is
271         1. didInvalidateIntrinsicContentSize
272         2. didFirstLayout
273         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
274         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
275         (and remember, all we care about is ordering).
276
277 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
278
279         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
280         https://bugs.webkit.org/show_bug.cgi?id=197171
281         <rdar://problem/47454979>
282
283         Reviewed by Youenn Fablet.
284
285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
286         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
287         (TestWebKitAPI::TEST):
288
289 2019-04-24  Brady Eidson  <beidson@apple.com>
290
291         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
292         https://bugs.webkit.org/show_bug.cgi?id=191362
293
294         Reviewed by Alex Christensen.
295
296         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
297           from an XHR to a custom protocol.
298
299 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
300
301         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
302         https://bugs.webkit.org/show_bug.cgi?id=197273
303
304         Reviewed by Dean Jackson.
305
306         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
307         so that WebCoreTestSupport::resetInternalsObject() is always run.
308
309         * DumpRenderTree/mac/DumpRenderTree.mm:
310         (resetWebViewToConsistentStateBeforeTesting):
311         (runTest):
312
313 2019-04-24  John Wilander  <wilander@apple.com>
314
315         Age out unconverted Ad Click Attributions after one week.
316         https://bugs.webkit.org/show_bug.cgi?id=197238
317         <rdar://problem/50177349>
318
319         Reviewed by Chris Dumez.
320
321         This patch adds infrastructure to allow tests to expire all unconverted
322         attributions early.
323
324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
326         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
328         * WebKitTestRunner/TestController.cpp:
329         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
330         * WebKitTestRunner/TestController.h:
331         * WebKitTestRunner/TestInvocation.cpp:
332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
333
334 2019-04-24  Chris Dumez  <cdumez@apple.com>
335
336         Fix flaky crashes in a couple of PSON API tests
337         https://bugs.webkit.org/show_bug.cgi?id=197239
338
339         Reviewed by Tim Horton.
340
341         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
342
343         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
344
345 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
346
347         Make it possible to control the renderTreeAsText output by setting options on testRunner
348         https://bugs.webkit.org/show_bug.cgi?id=197133
349
350         Reviewed by Sam Weinig.
351
352         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
353         that make sense in testing (those that don't dump unstable data like addresses), and plumb
354         these flags through the various framework layers.
355
356         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
357
358         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
359         and hand-code DumpRenderTree bindings.
360
361         Some cleanup of the TestRunners, using member initializers.
362
363         * DumpRenderTree/TestRunner.cpp:
364         (TestRunner::TestRunner):
365         (setRenderTreeDumpOptionsCallback):
366         (TestRunner::staticFunctions):
367         (TestRunner::setRenderTreeDumpOptions):
368         * DumpRenderTree/TestRunner.h:
369         (TestRunner::renderTreeDumpOptions const):
370         * DumpRenderTree/mac/DumpRenderTree.mm:
371         (dump):
372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
374         (WTR::InjectedBundlePage::dump):
375         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
376         (WTR::TestRunner::TestRunner):
377         (WTR::TestRunner::setRenderTreeDumpOptions):
378         * WebKitTestRunner/InjectedBundle/TestRunner.h:
379         (WTR::TestRunner::renderTreeDumpOptions const):
380
381 2019-04-24  Alex Christensen  <achristensen@webkit.org>
382
383         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
384         https://bugs.webkit.org/show_bug.cgi?id=197078
385         <rdar://problem/49564348>
386
387         Reviewed by Geoff Garen.
388
389         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
390         (TEST_F):
391         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
392         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
393         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
394
395 2019-04-24  Alex Christensen  <achristensen@webkit.org>
396
397         Add unit test for r239322
398         https://bugs.webkit.org/show_bug.cgi?id=197236
399
400         Reviewed by Chris Dumez.
401
402         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
403         May as well add the test infrastructure which was needed before and will be needed in the future.
404
405         * TestWebKitAPI/TCPServer.cpp:
406         (TestWebKitAPI::TCPServer::TCPServer):
407         * TestWebKitAPI/TCPServer.h:
408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
409         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
410         (TestWebKitAPI::TEST):
411         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
412         (TestWebKitAPI::downloadAtRate):
413         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
414         (TEST):
415         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
416         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
417         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
420         (TEST):
421
422 2019-04-24  Chris Dumez  <cdumez@apple.com>
423
424         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
425         https://bugs.webkit.org/show_bug.cgi?id=197214
426         <rdar://problem/49237544>
427
428         Reviewed by Alex Christensen.
429
430         Extend API test coverage.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
433         (TEST):
434
435 2019-04-24  Philippe Normand  <pnormand@igalia.com>
436
437         [Build][GStreamer] Update to 1.16.0
438         https://bugs.webkit.org/show_bug.cgi?id=197157
439
440         Reviewed by Xabier Rodriguez-Calvar.
441
442         The upstreamed patches were removed and a new one was added for a
443         regression detected in the scaletempo GStreamer element. The GNOME
444         Flatpak was migrated to 3.32 and I switched a few modules to Meson
445         on the way, as it is the preferred build system now in GStreamer
446         1.16.
447
448         * flatpak/files/httpd-autogen.sh:
449         * flatpak/flatpakutils.py:
450         (FlatpakPackage.install):
451         (WebkitFlatpak.run_in_sandbox):
452         * flatpak/org.webkit.CommonModules.yaml:
453         * flatpak/org.webkit.WebKit.yaml:
454         * gstreamer/jhbuild.modules:
455         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
456         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
457         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
458         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
459         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
460         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
461         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
462         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
463         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
464         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
465         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
466         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
467         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
468         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
469         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
470         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
471         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
472         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
473         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
474         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
475         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
476         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
477
478 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
481         https://bugs.webkit.org/show_bug.cgi?id=197156
482
483         Reviewed by Michael Catanzaro.
484
485         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
486         support was added.
487
488         * MiniBrowser/gtk/BrowserTab.c:
489         (browser_tab_set_background_color): Set the passed in color as web view background color.
490         * MiniBrowser/gtk/BrowserTab.h:
491         * MiniBrowser/gtk/BrowserWindow.c:
492         (browser_window_init): Initialize backgroundColor.
493         (browser_window_append_view): Call browser_tab_set_background_color().
494         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
495         are added.
496         * MiniBrowser/gtk/main.c:
497         (main): Call browser_window_set_background_color() before creating the tabs.
498
499 2019-04-23  John Wilander  <wilander@apple.com>
500
501         Move Ad Click Attribution from internal feature to experimental feature
502         https://bugs.webkit.org/show_bug.cgi?id=197218
503         <rdar://problem/47651691>
504
505         Reviewed by Brent Fulgham.
506
507         * DumpRenderTree/TestOptions.cpp:
508         (TestOptions::TestOptions):
509
510 2019-04-23  Andy Estes  <aestes@apple.com>
511
512         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
513         https://bugs.webkit.org/show_bug.cgi?id=196749
514         <rdar://problem/35773454>
515
516         Reviewed by Daniel Bates.
517
518         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
521         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
522         (-[QuickLookDelegate webView:didFinishNavigation:]):
523         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
524         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
525         (runTest):
526         (runTestDecideBeforeLoading):
527         (runTestDecideAfterLoading):
528         (TEST):
529
530 2019-04-23  John Wilander  <wilander@apple.com>
531
532         Remove Ad Click Attribution data when removing website data
533         https://bugs.webkit.org/show_bug.cgi?id=197215
534         <rdar://problem/47668988>
535
536         Reviewed by Chris Dumez.
537
538         This patch adds test infrastructure to delete Ad Click Attribution data
539         through WebsiteDataStore::removeData().
540
541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
542         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
543         (WTR::TestRunner::clearAdClickAttribution):
544         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
546         * WebKitTestRunner/TestController.cpp:
547         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
548         * WebKitTestRunner/TestController.h:
549         * WebKitTestRunner/TestInvocation.cpp:
550         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
551
552 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
553
554         webkitpy: Kill unresponsive worker processes
555         https://bugs.webkit.org/show_bug.cgi?id=197205
556         <rdar://problem/50104388>
557
558         Reviewed by Lucas Forschler.
559
560         * Scripts/webkitpy/common/message_pool.py:
561         (_MessagePool.__init__): Add close timeout.
562         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
563
564 2019-04-23  Alex Christensen  <achristensen@webkit.org>
565
566         Add unit tests for WKWebView.serverTrust
567         https://bugs.webkit.org/show_bug.cgi?id=197202
568
569         Reviewed by Youenn Fablet
570
571         * TestWebKitAPI/TCPServer.cpp:
572         (TestWebKitAPI::deleter<BIO>::operator()):
573         (TestWebKitAPI::deleter<SSL>::operator()):
574         (TestWebKitAPI::deleter<X509>::operator()):
575         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
576         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
577         (TestWebKitAPI::TCPServer::TCPServer):
578         (TestWebKitAPI::TCPServer::listenForConnections):
579         * TestWebKitAPI/TCPServer.h:
580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
581         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
582         (TestWebKitAPI::TEST):
583         (verifyCertificateAndPublicKey):
584         (-[ServerTrustDelegate webView:didFinishNavigation:]):
585         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
586         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
587         (TestWebKitAPI::downloadAtRate):
588         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
589         (TEST):
590         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
591         (TEST):
592
593 2019-04-23  Commit Queue  <commit-queue@webkit.org>
594
595         Unreviewed, rolling out r244556.
596         https://bugs.webkit.org/show_bug.cgi?id=197212
597
598         Causing build failures on multiple builders (Requested by
599         ShawnRoberts on #webkit).
600
601         Reverted changeset:
602
603         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
604         https://bugs.webkit.org/show_bug.cgi?id=197171
605         https://trac.webkit.org/changeset/244556
606
607 2019-04-23  Alex Christensen  <achristensen@webkit.org>
608
609         Fix iOS build.
610         https://bugs.webkit.org/show_bug.cgi?id=195537
611
612         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
613         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
614         AdoptWK constructor is private now.  Use adoptWK instead.
615
616 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
617
618         Accessibility text search and selection API enhancements.
619         https://bugs.webkit.org/show_bug.cgi?id=197095
620         <rdar://problem/48181791>
621
622         Reviewed by Chris Fleizach.
623
624         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
625
626         * DumpRenderTree/AccessibilityTextMarker.h:
627         * DumpRenderTree/AccessibilityUIElement.cpp:
628         (searchTextWithCriteriaCallback):
629         (AccessibilityUIElement::getJSClass):
630         * DumpRenderTree/AccessibilityUIElement.h:
631         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
632         (convertVectorToObjectArray):
633         (convertNSArrayToVector):
634         (searchTextParameterizedAttributeForCriteria):
635         (AccessibilityUIElement::getLinkedUIElements):
636         (AccessibilityUIElement::getDocumentLinks):
637         (AccessibilityUIElement::getChildren):
638         (AccessibilityUIElement::getChildrenWithRange):
639         (AccessibilityUIElement::rowHeaders const):
640         (AccessibilityUIElement::columnHeaders const):
641         (AccessibilityUIElement::uiElementArrayAttributeValue const):
642         (AccessibilityUIElement::searchTextWithCriteria):
643         (AccessibilityUIElement::attributesOfColumnHeaders):
644         (AccessibilityUIElement::attributesOfRowHeaders):
645         (AccessibilityUIElement::attributesOfColumns):
646         (AccessibilityUIElement::attributesOfRows):
647         (AccessibilityUIElement::attributesOfVisibleCells):
648         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
649         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
650         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
651         (WTR::convertVectorToObjectArray):
652         (WTR::convertNSArrayToVector):
653         (WTR::searchTextParameterizedAttributeForCriteria):
654         (WTR::AccessibilityUIElement::getLinkedUIElements):
655         (WTR::AccessibilityUIElement::getDocumentLinks):
656         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
657         (WTR::AccessibilityUIElement::getChildren):
658         (WTR::AccessibilityUIElement::getChildrenWithRange):
659         (WTR::AccessibilityUIElement::rowHeaders const):
660         (WTR::AccessibilityUIElement::columnHeaders const):
661         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
662         (WTR::AccessibilityUIElement::searchTextWithCriteria):
663         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
664         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
665         (WTR::AccessibilityUIElement::attributesOfColumns):
666         (WTR::AccessibilityUIElement::attributesOfRows):
667         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
668         (WTR::convertElementsToObjectArray): Deleted.
669
670 2019-04-23  Guy Lewin  <guy@lewin.co.il>
671
672         Multiple File Input Icon Set Regardless of File List
673         https://bugs.webkit.org/show_bug.cgi?id=195537
674
675         Reviewed by Alexey Proskuryakov.
676
677         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
678         display string in iOS file inputs
679
680         * DumpRenderTree/TestRunner.cpp:
681         (SetOpenPanelFilesMediaIconCallback):
682         (TestRunner::staticFunctions):
683         (TestRunner::setOpenPanelFilesMediaIcon):
684         * DumpRenderTree/TestRunner.h:
685         (TestRunner::openPanelFilesMediaIcon const):
686         * DumpRenderTree/mac/UIDelegate.mm:
687         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
688         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
689         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
690         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
691         * WebKitTestRunner/InjectedBundle/TestRunner.h:
692         * WebKitTestRunner/TestController.cpp:
693         (WTR::runOpenPanel):
694         (WTR::TestController::resetStateToConsistentValues):
695         * WebKitTestRunner/TestController.h:
696         (WTR::TestController::openPanelFileURLsMediaIcon const):
697         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
698         * WebKitTestRunner/TestInvocation.cpp:
699         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
700
701 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
702
703         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
704         https://bugs.webkit.org/show_bug.cgi?id=197171
705         <rdar://problem/47454979>
706
707         Reviewed by Youenn Fablet.
708
709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
710         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
711         (TestWebKitAPI::TEST):
712
713 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
714
715         [ews-build] Add unit tests for UnApplyPatchIfRequired
716         https://bugs.webkit.org/show_bug.cgi?id=197197
717
718         Reviewed by Lucas Forschler.
719
720         * BuildSlaveSupport/ews-build/steps_unittest.py:
721         (TestUnApplyPatchIfRequired):
722         (TestUnApplyPatchIfRequired.test_success):
723         (TestUnApplyPatchIfRequired.test_failure):
724         (TestUnApplyPatchIfRequired.test_skip):
725
726 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-build] Add unit tests for CleanWorkingDirectory
729         https://bugs.webkit.org/show_bug.cgi?id=197195
730
731         Reviewed by Lucas Forschler.
732
733         * BuildSlaveSupport/ews-build/steps_unittest.py:
734         (TestCleanWorkingDirectory):
735         (TestCleanWorkingDirectory.test_success):
736         (TestCleanWorkingDirectory.test_failure):
737
738 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
739
740         [ews-build] Use explicit imports instead of wildcard imports
741         https://bugs.webkit.org/show_bug.cgi?id=197194
742
743         Reviewed by Lucas Forschler.
744
745         * BuildSlaveSupport/ews-build/factories.py:
746         * BuildSlaveSupport/ews-build/loadConfig.py:
747         * BuildSlaveSupport/ews-build/steps_unittest.py:
748
749 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
750
751         [ews-build] Add unit tests for DownloadBuiltProduct
752         https://bugs.webkit.org/show_bug.cgi?id=197193
753
754         Reviewed by Lucas Forschler.
755
756         * BuildSlaveSupport/ews-build/steps_unittest.py:
757         (TestDownloadBuiltProduct):
758         (TestDownloadBuiltProduct.setUp):
759         (TestDownloadBuiltProduct.tearDown):
760         (TestDownloadBuiltProduct.test_success):
761         (TestDownloadBuiltProduct.test_failure):
762
763 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
764
765         [ews-app] Exception while loading status-bubble when no build step has started
766         https://bugs.webkit.org/show_bug.cgi?id=196676
767
768         Reviewed by Lucas Forschler.
769
770         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
771         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
772
773 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
774
775         [PlayStation] Support running of JSC tests on remote playstation devices
776         https://bugs.webkit.org/show_bug.cgi?id=197170
777
778         Reviewed by Ross Kirsling.
779
780         Script changes
781
782         * Scripts/run-javascriptcore-tests:
783         (runJSCStressTests): Pass arguments for playstation to
784         run-jsc-stress-tests
785         * Scripts/run-jsc-stress-tests:
786         Handle $hostOS=="playstation" for determineArchitecture, turning
787         off $isFTLPlatform and runProfiler and defaulting test writer.
788         * Scripts/webkitdirs.pm:
789         (jscPath): PlayStation WebKit executables have .elf extension
790         (executableProductDir): PlayStation builds on Windows hosts but
791         uses bin directory rather than bin64/bin32 for executable output
792         location.
793         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
794
795 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
796
797         [CMake][Win] Use target oriented design for WebKit
798         https://bugs.webkit.org/show_bug.cgi?id=197173
799
800         Reviewed by Alex Christensen.
801
802         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
803         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
804
805 2019-04-23  Chris Dumez  <cdumez@apple.com>
806
807         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
808         https://bugs.webkit.org/show_bug.cgi?id=197097
809         <rdar://problem/50048318>
810
811         Reviewed by Alex Christensen.
812
813         Add API test coverage.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
816         (-[PSONScheme webView:startURLSchemeTask:]):
817
818 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
819
820         [ATK] Implement AtkComponentIface scroll_to methods
821         https://bugs.webkit.org/show_bug.cgi?id=196856
822
823         Reviewed by Michael Catanzaro.
824
825         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
826         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
827         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
828         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
829
830 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
831
832         [ews-build] Improve summary for UploadBuiltProduct step
833         https://bugs.webkit.org/show_bug.cgi?id=197182
834
835         Reviewed by Lucas Forschler.
836
837         * BuildSlaveSupport/ews-build/steps.py:
838         (UploadBuiltProduct): Added descriptionDone.
839         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
840         * BuildSlaveSupport/ews-build/steps_unittest.py:
841         (TestUploadBuiltProduct.test_success): Updated unit-test.
842         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
843
844 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
845
846         [ews-build] Trigger queues only after uploading the archive
847         https://bugs.webkit.org/show_bug.cgi?id=197180
848
849         Reviewed by Lucas Forschler.
850
851         * BuildSlaveSupport/ews-build/factories.py:
852         (Factory.__init__):
853         (BuildFactory.__init__): Remove trigger step from factories.
854         (BuildFactory.propertiesToPassToTriggers): Deleted.
855         * BuildSlaveSupport/ews-build/steps.py:
856         (ConfigureBuild.__init__): Confiure triggers property.
857         (Trigger): Step to trigger other queues.
858         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
859         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
860
861 2019-04-22  Alex Christensen  <achristensen@webkit.org>
862
863         Deprecate WKContextCreateWithInjectedBundlePath
864         https://bugs.webkit.org/show_bug.cgi?id=197169
865
866         Reviewed by Youenn Fablet.
867
868         * TestWebKitAPI/PlatformUtilities.cpp:
869         (TestWebKitAPI::Util::createContextWithInjectedBundle):
870         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
871
872 2019-04-22  Alex Christensen  <achristensen@webkit.org>
873
874         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
875         https://bugs.webkit.org/show_bug.cgi?id=197093
876         <rdar://problem/49708268>
877
878         Reviewed by Chris Dumez.
879
880         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
881         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
882         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
883         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
884         and one for loads without credentials, so there are two TCP connections to the same server in this test.
885
886         * TestWebKitAPI/TCPServer.cpp:
887         (TestWebKitAPI::TCPServer::TCPServer):
888         (TestWebKitAPI::TCPServer::~TCPServer):
889         (TestWebKitAPI::TCPServer::socketBindListen):
890         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
891         * TestWebKitAPI/TCPServer.h:
892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
893         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
894         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
895         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
896         (respondWithChallengeThenOK):
897         (TestWebKitAPI::TEST):
898         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
899         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
900         (TEST):
901
902 2019-04-22  Chris Dumez  <cdumez@apple.com>
903
904         Delayed WebProcessLaunch may break the _relatedWebView SPI
905         https://bugs.webkit.org/show_bug.cgi?id=197160
906
907         Reviewed by Alex Christensen.
908
909         Add API test coverage.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
912
913 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
914
915         Use curl to download packages for webkitpy autoinstaller
916         https://bugs.webkit.org/show_bug.cgi?id=197164
917
918         Reviewed by Darin Adler.
919
920         * Scripts/webkitpy/common/system/autoinstall.py:
921         (AutoInstaller._download): Use curl(1) to download packages necessary for
922         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
923         errors which are not present when using curl(1).
924
925 2019-04-22  Chris Dumez  <cdumez@apple.com>
926
927         Unreviewed, rolling out r244502.
928
929         Caused crashes on the bots
930
931         Reverted changeset:
932
933         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
934         https://bugs.webkit.org/show_bug.cgi?id=197160
935         https://trac.webkit.org/changeset/244502
936
937 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
938
939         Unreviewed, rolling out r244437.
940
941         Still breaks internal tests.
942
943         Reverted changeset:
944
945         "InjectedBundle parameters often need initialization function
946         called before unarchiving"
947         https://bugs.webkit.org/show_bug.cgi?id=189709
948         https://trac.webkit.org/changeset/244437
949
950 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
951
952         [ews-build] Use singular verb in failure description in case of single api test failure
953         https://bugs.webkit.org/show_bug.cgi?id=197013
954
955         Reviewed by Lucas Forschler.
956
957         * BuildSlaveSupport/ews-build/steps.py:
958         (AnalyzeAPITestsResults.analyzeResults):
959
960 2019-04-22  Chris Dumez  <cdumez@apple.com>
961
962         Delayed WebProcessLaunch may break the _relatedWebView SPI
963         https://bugs.webkit.org/show_bug.cgi?id=197160
964
965         Reviewed by Alex Christensen.
966
967         Add API test coverage.
968
969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
970
971 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
972
973         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
974         https://bugs.webkit.org/show_bug.cgi?id=194630
975
976         Reviewed by Michael Catanzaro.
977
978         Return early from getAttributeSet() is passed in accessible is nullptr.
979
980         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
981
982 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
983
984         Defer EditorState updates until the next layer tree flush in a few additional circumstances
985         https://bugs.webkit.org/show_bug.cgi?id=197145
986         <rdar://problem/50078170>
987
988         Reviewed by Darin Adler.
989
990         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
991         focus, or showing the font manager.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
996         (TEST):
997         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
998         (TestWebKitAPI::TEST):
999
1000 2019-04-21  Brian Burg  <bburg@apple.com>
1001
1002         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1003         https://bugs.webkit.org/show_bug.cgi?id=197125
1004         <rdar://problem/50061468>
1005
1006         Reviewed by Darin Adler.
1007
1008         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1009         using this class rather than making our own ./wpt serve invocation.
1010
1011         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1012         (WebDriverW3CWebServer):
1013         (WebDriverW3CWebServer.document_root): Expose this to clients.
1014         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1015
1016         (WebDriverW3CWebServer.__enter__):
1017         (WebDriverW3CWebServer.__exit__):
1018         Make it possible to use the web server with a 'with' statement.
1019
1020 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1021
1022         [CMake][Win] Use target oriented design for WebKitLegacy
1023         https://bugs.webkit.org/show_bug.cgi?id=197112
1024
1025         Reviewed by Konstantin Tokarev.
1026
1027         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1028
1029         * DumpRenderTree/CMakeLists.txt:
1030         * DumpRenderTree/PlatformWin.cmake:
1031         * DumpRenderTree/win/EventSender.cpp:
1032
1033 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1034
1035         Update text for old EWS submit button
1036         https://bugs.webkit.org/show_bug.cgi?id=197140
1037
1038         Reviewed by Alexey Proskuryakov.
1039
1040         * QueueStatusServer/templates/statusbubble.html:
1041
1042 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-app] New EWS should poll bugzilla more frequently
1045         https://bugs.webkit.org/show_bug.cgi?id=197138
1046
1047         Reviewed by Alexey Proskuryakov.
1048
1049         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1050         (FetchLoop.__init__):
1051
1052 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1055         https://bugs.webkit.org/show_bug.cgi?id=197139
1056
1057         Reviewed by Alexey Proskuryakov.
1058
1059         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1060         * QueueStatusServer/templates/statusbubble.html:
1061
1062 2019-04-20  Chris Dumez  <cdumez@apple.com>
1063
1064         Unreviewed, fix iOS build with recent SDKs.
1065
1066         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1067
1068 2019-04-19  Keith Miller  <keith_miller@apple.com>
1069
1070         Add script to merge run_benchmark jsons
1071         https://bugs.webkit.org/show_bug.cgi?id=197107
1072
1073         Reviewed by Michael Saboff.
1074
1075         The script basically recursively decends through all json objects until it gets
1076         to an array or JSON primitive and concats or takes the first value, respectively.
1077
1078         This patch also adds +x bits to the compare-results script so it
1079         can be run directly from the command line. I had to add a new line so that svn
1080         will accept the change... yay svn!
1081
1082         * Scripts/compare-results:
1083         * Scripts/merge-result-jsons: Added.
1084         (readJSONFile):
1085         (deepAppend):
1086         (mergeJSONs):
1087         (main):
1088
1089 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1092         https://bugs.webkit.org/show_bug.cgi?id=197079
1093
1094         Reviewed by Darin Adler.
1095
1096         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1097
1098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1099         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1100
1101 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1102
1103         Unreviewed, rolling out r244434.
1104         https://bugs.webkit.org/show_bug.cgi?id=197089
1105
1106         caused 1 API test failure (Requested by zalan on #webkit).
1107
1108         Reverted changeset:
1109
1110         "Regression (r244291): Broken API Test
1111         AutoLayoutRenderingProgressRelativeOrdering"
1112         https://bugs.webkit.org/show_bug.cgi?id=196948
1113         https://trac.webkit.org/changeset/244434
1114
1115 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1116
1117         Add new compatibility mode API on WKNavigation
1118         https://bugs.webkit.org/show_bug.cgi?id=197069
1119         <rdar://problem/50025800>
1120
1121         Reviewed by Tim Horton.
1122
1123         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1124
1125         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1126         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1127         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1128
1129 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1130
1131         [CMake] Make WebCore headers copies
1132         https://bugs.webkit.org/show_bug.cgi?id=182512
1133         <rdar://problem/37510435>
1134
1135         Reviewed by Alex Christensen.
1136
1137         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1138         ports.
1139
1140         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1141         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1142
1143         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1144         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1145         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1146         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1147         * TestWebKitAPI/CMakeLists.txt:
1148         * TestWebKitAPI/PlatformWin.cmake:
1149         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1150         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1151         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1152
1153 2019-04-18  Jer Noble  <jer.noble@apple.com>
1154
1155         Add support for parsing FairPlayStreaming PSSH boxes.
1156         https://bugs.webkit.org/show_bug.cgi?id=197064
1157
1158         Reviewed by Eric Carlson.
1159
1160         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1161         (TestWebKitAPI::TEST):
1162
1163 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1164
1165         InjectedBundle parameters often need initialization function called before unarchiving
1166         https://bugs.webkit.org/show_bug.cgi?id=189709
1167         <rdar://problem/44573653>
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1172         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1173
1174 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1175
1176         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1177         https://bugs.webkit.org/show_bug.cgi?id=196948
1178         <rdar://problem/49927131>
1179
1180         Reviewed by Tim Horton.
1181
1182         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1183         (TEST): 
1184         The expected order of incoming events is
1185         1. didInvalidateIntrinsicContentSize
1186         2. didFirstLayout
1187         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1188         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1189         (and remember, all we care about is ordering).
1190
1191 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1192
1193         Unreviewed, rolling out r244299.
1194
1195         Breaks internal tests.
1196
1197         Reverted changeset:
1198
1199         "InjectedBundle parameters often need initialization function
1200         called before unarchiving"
1201         https://bugs.webkit.org/show_bug.cgi?id=189709
1202         https://trac.webkit.org/changeset/244299
1203
1204 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1205
1206         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1207         https://bugs.webkit.org/show_bug.cgi?id=197053
1208
1209         Reviewed by Saam Barati.
1210
1211         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1212         (TestWebKitAPI::TEST):
1213
1214 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1215
1216         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1217         https://bugs.webkit.org/show_bug.cgi?id=197028
1218         <rdar://problem/49985290>
1219
1220         Reviewed by Wenson Hsieh.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1223         (TEST):
1224         Liberal application of waitForNextPresentationUpdate works around a race
1225         where if the page rapidly changes its viewport arguments (or an API client
1226         rapidly changes its viewport arguments), we'd get stuck thinking that the
1227         user had intentionally zoomed the page, and stop resetting the initial scale.
1228         This deserves a separate bug, but no need to keep the test failing while
1229         we think about it.
1230
1231 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1232
1233         REGRESSION (r241988): Switching tabs is slow
1234         https://bugs.webkit.org/show_bug.cgi?id=197037
1235         <rdar://problem/49951473>
1236
1237         Reviewed by Simon Fraser.
1238
1239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1241         (TEST):
1242         * TestWebKitAPI/cocoa/TestWKWebView.h:
1243         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1244         (-[TestWKWebView addToTestWindow]):
1245         Add a test that hangs without this fix.
1246
1247 2019-04-17  Truitt Savell  <tsavell@apple.com>
1248
1249         Unreviewed, rolling out r244400.
1250
1251         Caused testing to exit early with assertionon Debug WK2
1252
1253         Reverted changeset:
1254
1255         "UI↔Web deadlock when printing with a JavaScript alert
1256         visible"
1257         https://bugs.webkit.org/show_bug.cgi?id=196839
1258         https://trac.webkit.org/changeset/244400
1259
1260 2019-04-17  Brady Eidson  <beidson@apple.com>
1261
1262         Link clicks in PDFs shouldn't send referrer headers.
1263         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1264
1265         Reviewed by Tim Horton.
1266
1267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1268         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1269         (putPDFBytesCallback):
1270         (emptyReleaseInfoCallback):
1271         (createPDFWithLinkToURL):
1272         (TEST):
1273
1274 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1275
1276         UI↔Web deadlock when printing with a JavaScript alert visible
1277         https://bugs.webkit.org/show_bug.cgi?id=196839
1278         <rdar://problem/49157642>
1279
1280         Reviewed by Andy Estes.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1284         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1285         (TEST):
1286
1287 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1288
1289         WKRetainPtr's adoption constructor should be private
1290         https://bugs.webkit.org/show_bug.cgi?id=197019
1291
1292         Reviewed by Tim Horton.
1293
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (dumpFramesAsText):
1296         * TestWebKitAPI/InjectedBundleController.cpp:
1297         (TestWebKitAPI::InjectedBundleController::initialize):
1298         * TestWebKitAPI/PlatformUtilities.cpp:
1299         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1300         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1301         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1302         (TestWebKitAPI::Util::toWK):
1303         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1304         (TestWebKitAPI::TEST):
1305         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1306         (TestWebKitAPI::TEST):
1307         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1308         (TestWebKitAPI::TEST):
1309         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1310         (TestWebKitAPI::TEST):
1311         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1312         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1313         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1314         (TestWebKitAPI::TEST):
1315         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1316         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1317         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1318         (TestWebKitAPI::TEST):
1319         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1320         (TestWebKitAPI::TEST):
1321         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1322         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1323         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1324         (TestWebKitAPI::TEST):
1325         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1326         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1327         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1328         (TestWebKitAPI::TEST):
1329         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1330         (TestWebKitAPI::TEST):
1331         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1332         (TestWebKitAPI::TEST):
1333         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1334         (TestWebKitAPI::TEST):
1335         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1338         (TestWebKitAPI::TEST):
1339         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1342         (TestWebKitAPI::TEST):
1343         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1344         (TestWebKitAPI::TEST):
1345         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1346         (TestWebKitAPI::TEST):
1347         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1348         (TestWebKitAPI::TEST):
1349         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1350         (TestWebKitAPI::TEST):
1351         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1352         (TestWebKitAPI::TEST):
1353         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1354         (TestWebKitAPI::TEST):
1355         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1356         (TestWebKitAPI::TEST):
1357         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1358         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1359         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1360         (TestWebKitAPI::TEST):
1361         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1362         (TestWebKitAPI::TEST):
1363         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1364         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1365         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1366         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1367         (TestWebKitAPI::TEST):
1368         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1369         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1370         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1371         (TestWebKitAPI::TEST):
1372         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1373         (TestWebKitAPI::TEST):
1374         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1375         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1376         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1377         (TestWebKitAPI::TEST):
1378         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1379         (TestWebKitAPI::loadAlternateHTMLString):
1380         (TestWebKitAPI::TEST):
1381         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1382         (TestWebKitAPI::TEST):
1383         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1384         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1385         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1386         (TestWebKitAPI::buildAndPerformTest):
1387         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1392         (TestWebKitAPI::TEST):
1393         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1394         (TestWebKitAPI::TEST):
1395         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1396         (TestWebKitAPI::TEST):
1397         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1398         (TestWebKitAPI::TEST):
1399         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1400         (TestWebKitAPI::TEST):
1401         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1404         (TestWebKitAPI::TEST):
1405         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1406         (TestWebKitAPI::TEST):
1407         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1408         (TestWebKitAPI::TEST):
1409         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1410         (TestWebKitAPI::TEST):
1411         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1412         (TestWebKitAPI::TEST):
1413         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1414         (TestWebKitAPI::TEST):
1415         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1416         (TestWebKitAPI::TEST):
1417         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1420         (TestWebKitAPI::TEST):
1421         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1422         (TestWebKitAPI::TEST):
1423         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1424         (TestWebKitAPI::TEST):
1425         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1426         (TestWebKitAPI::TEST):
1427         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1430         (TestWebKitAPI::TEST):
1431         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1432         (TestWebKitAPI::TEST):
1433         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1434         (TestWebKitAPI::TEST):
1435         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1436         (TestWebKitAPI::TEST):
1437         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1438         (TestWebKitAPI::TEST):
1439         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1440         (TestWebKitAPI::TEST):
1441         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1442         (TestWebKitAPI::TEST):
1443         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1444         (TestWebKitAPI::TEST):
1445         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1446         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1447         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1448         (TestWebKitAPI::TEST):
1449         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1450         (TestWebKitAPI::TEST):
1451         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1452         (TestWebKitAPI::TEST):
1453         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1454         (TestWebKitAPI::TEST):
1455         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1456         (TestWebKitAPI::TEST):
1457         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1458         (TestWebKitAPI::TEST):
1459         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1460         (TestWebKitAPI::TEST):
1461         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1462         (TestWebKitAPI::TEST):
1463         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1464         (TestWebKitAPI::TEST):
1465         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1466         (TestWebKitAPI::TEST):
1467         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1469         (TEST):
1470         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1471         (TEST):
1472         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1473         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1474         (TEST):
1475         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1476         (TestWebKitAPI::TEST):
1477         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1478         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1479         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1480         (WTR::getMenuItemTitleCallback):
1481         (WTR::createMouseMessageBody):
1482         (WTR::EventSendingController::mouseDown):
1483         (WTR::EventSendingController::mouseUp):
1484         (WTR::EventSendingController::mouseMoveTo):
1485         (WTR::EventSendingController::mouseForceClick):
1486         (WTR::EventSendingController::startAndCancelMouseForceClick):
1487         (WTR::EventSendingController::mouseForceDown):
1488         (WTR::EventSendingController::mouseForceUp):
1489         (WTR::EventSendingController::mouseForceChanged):
1490         (WTR::EventSendingController::leapForward):
1491         (WTR::EventSendingController::scheduleAsynchronousClick):
1492         (WTR::createKeyDownMessageBody):
1493         (WTR::EventSendingController::keyDown):
1494         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1495         (WTR::EventSendingController::mouseScrollBy):
1496         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1497         (WTR::EventSendingController::continuousMouseScrollBy):
1498         (WTR::EventSendingController::addTouchPoint):
1499         (WTR::EventSendingController::updateTouchPoint):
1500         (WTR::EventSendingController::setTouchModifier):
1501         (WTR::EventSendingController::setTouchPointRadius):
1502         (WTR::EventSendingController::touchStart):
1503         (WTR::EventSendingController::touchMove):
1504         (WTR::EventSendingController::touchEnd):
1505         (WTR::EventSendingController::touchCancel):
1506         (WTR::EventSendingController::clearTouchPoints):
1507         (WTR::EventSendingController::releaseTouchPoint):
1508         (WTR::EventSendingController::cancelTouchPoint):
1509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1510         (WTR::InjectedBundle::didCreatePage):
1511         (WTR::InjectedBundle::didReceiveMessage):
1512         (WTR::InjectedBundle::didReceiveMessageToPage):
1513         (WTR::InjectedBundle::booleanForKey):
1514         (WTR::InjectedBundle::done):
1515         (WTR::InjectedBundle::dumpToStdErr):
1516         (WTR::InjectedBundle::outputText):
1517         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1518         (WTR::InjectedBundle::postAddChromeInputField):
1519         (WTR::InjectedBundle::postRemoveChromeInputField):
1520         (WTR::InjectedBundle::postFocusWebView):
1521         (WTR::InjectedBundle::postSetBackingScaleFactor):
1522         (WTR::InjectedBundle::postSetWindowIsKey):
1523         (WTR::InjectedBundle::postSetViewSize):
1524         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1525         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1526         (WTR::InjectedBundle::setGeolocationPermission):
1527         (WTR::InjectedBundle::setMockGeolocationPosition):
1528         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1529         (WTR::InjectedBundle::isGeolocationProviderActive const):
1530         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1531         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1532         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1533         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1534         (WTR::InjectedBundle::setCustomPolicyDelegate):
1535         (WTR::InjectedBundle::setHidden):
1536         (WTR::InjectedBundle::setCacheModel):
1537         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1538         (WTR::InjectedBundle::processWorkQueue):
1539         (WTR::InjectedBundle::queueBackNavigation):
1540         (WTR::InjectedBundle::queueForwardNavigation):
1541         (WTR::InjectedBundle::queueLoad):
1542         (WTR::InjectedBundle::queueLoadHTMLString):
1543         (WTR::InjectedBundle::queueReload):
1544         (WTR::InjectedBundle::queueLoadingScript):
1545         (WTR::InjectedBundle::queueNonLoadingScript):
1546         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1547         (WTR::frameToStr):
1548         (WTR::InjectedBundlePage::InjectedBundlePage):
1549         (WTR::dumpFrameDescriptionSuitableForTestResult):
1550         (WTR::dumpFrameScrollPosition):
1551         (WTR::dumpDescendantFrameScrollPositions):
1552         (WTR::dumpFrameText):
1553         (WTR::dumpDescendantFramesText):
1554         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1555         (WTR::TestRunner::shouldDumpPixels const):
1556         (WTR::TestRunner::setDumpPixels):
1557         (WTR::TestRunner::whatToDump const):
1558         (WTR::TestRunner::setWhatToDump):
1559         (WTR::TestRunner::setWaitUntilDone):
1560         (WTR::TestRunner::shouldWaitUntilDone const):
1561         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1562         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1563         (WTR::TestRunner::clearAllDatabases):
1564         (WTR::TestRunner::setIDBPerOriginQuota):
1565         (WTR::TestRunner::originsWithApplicationCache):
1566         (WTR::TestRunner::setCanOpenWindows):
1567         (WTR::TestRunner::setXSSAuditorEnabled):
1568         (WTR::TestRunner::setMediaDevicesEnabled):
1569         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1570         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1571         (WTR::TestRunner::setCustomUserAgent):
1572         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1573         (WTR::TestRunner::setModernMediaControlsEnabled):
1574         (WTR::TestRunner::setWebGL2Enabled):
1575         (WTR::TestRunner::setWritableStreamAPIEnabled):
1576         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1577         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1578         (WTR::TestRunner::setAllowsAnySSLCertificate):
1579         (WTR::TestRunner::setPluginsEnabled):
1580         (WTR::TestRunner::setValueForUser):
1581         (WTR::TestRunner::setAudioResult):
1582         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1583         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1584         (WTR::TestRunner::setAlwaysAcceptCookies):
1585         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1586         (WTR::TestRunner::isDoingMediaCapture const):
1587         (WTR::TestRunner::queueLoad):
1588         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1589         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1590         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1591         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1592         (WTR::TestRunner::setAuthenticationUsername):
1593         (WTR::TestRunner::setAuthenticationPassword):
1594         (WTR::TestRunner::secureEventInputIsEnabled const):
1595         (WTR::TestRunner::setBlockAllPlugins):
1596         (WTR::TestRunner::setPluginSupportedMode):
1597         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1598         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1599         (WTR::TestRunner::setNavigationGesturesEnabled):
1600         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1601         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1602         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1603         (WTR::TestRunner::terminateNetworkProcess):
1604         (WTR::TestRunner::terminateServiceWorkerProcess):
1605         (WTR::TestRunner::runUIScript):
1606         (WTR::TestRunner::setStatisticsDebugMode):
1607         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1608         (WTR::TestRunner::setStatisticsLastSeen):
1609         (WTR::TestRunner::setStatisticsPrevalentResource):
1610         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1611         (WTR::TestRunner::dumpResourceLoadStatistics):
1612         (WTR::TestRunner::isStatisticsPrevalentResource):
1613         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1614         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1615         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1616         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1617         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1618         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1619         (WTR::TestRunner::setStatisticsGrandfathered):
1620         (WTR::TestRunner::isStatisticsGrandfathered):
1621         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1622         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1623         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1624         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1625         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1626         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1627         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1628         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1629         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1630         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1631         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1632         (WTR::TestRunner::statisticsSubmitTelemetry):
1633         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1634         (WTR::TestRunner::setStatisticsIsRunningTest):
1635         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1636         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1637         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1638         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1639         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1640         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1641         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1642         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1643         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1644         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1645         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1646         (WTR::TestRunner::statisticsResetToConsistentState):
1647         (WTR::TestRunner::setStorageAccessAPIEnabled):
1648         (WTR::TestRunner::getAllStorageAccessEntries):
1649         (WTR::TestRunner::addMockMediaDevice):
1650         (WTR::TestRunner::clearMockMediaDevices):
1651         (WTR::TestRunner::removeMockMediaDevice):
1652         (WTR::TestRunner::resetMockMediaDevices):
1653         (WTR::TestRunner::connectMockGamepad):
1654         (WTR::TestRunner::disconnectMockGamepad):
1655         (WTR::TestRunner::setMockGamepadDetails):
1656         (WTR::TestRunner::setMockGamepadAxisValue):
1657         (WTR::TestRunner::setMockGamepadButtonValue):
1658         (WTR::TestRunner::removeAllSessionCredentials):
1659         (WTR::TestRunner::clearDOMCache):
1660         (WTR::TestRunner::clearDOMCaches):
1661         (WTR::TestRunner::hasDOMCache):
1662         (WTR::TestRunner::domCacheSize):
1663         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1664         (WTR::TestRunner::getApplicationManifestThen):
1665         (WTR::TestRunner::injectUserScript):
1666         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1667         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1668         (WTR::TestRunner::addTestKeyToKeychain):
1669         (WTR::TestRunner::cleanUpKeychain):
1670         (WTR::TestRunner::keyExistsInKeychain):
1671         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1672         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1673         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1674         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1675         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1676         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1677         * WebKitTestRunner/TestController.cpp:
1678         (WTR::TestController::initialize):
1679         (WTR::parseStringTestHeaderValueAsRelativePath):
1680         (WTR::updateTestOptionsFromTestHeader):
1681         (WTR::TestController::runTest):
1682         (WTR::TestController::didReceiveLiveDocumentsList):
1683         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1684         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1685         (WTR::TestController::didFinishNavigation):
1686         (WTR::TestController::didReceiveAuthenticationChallenge):
1687         * WebKitTestRunner/TestInvocation.cpp:
1688         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1689         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1690         (WTR::TestInvocation::uiScriptDidComplete):
1691         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1692         * WebKitTestRunner/WebNotificationProvider.cpp:
1693         (WTR::WebNotificationProvider::closeWebNotification):
1694         * WebKitTestRunner/WorkQueueManager.cpp:
1695         (WTR::ScriptItem::ScriptItem):
1696         (WTR::WorkQueueManager::queueLoad):
1697         (WTR::WorkQueueManager::queueLoadHTMLString):
1698
1699 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1700
1701         Add a comment to make my test from r244139 less mysterious.
1702         https://bugs.webkit.org/show_bug.cgi?id=196744
1703
1704         As suggested by Darin Adler.
1705
1706         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1707         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1708
1709 2019-04-17  Chris Dumez  <cdumez@apple.com>
1710
1711         Remember device orientation permission for the duration of the browsing session
1712         https://bugs.webkit.org/show_bug.cgi?id=196992
1713         <rdar://problem/49946067>
1714
1715         Reviewed by Alex Christensen.
1716
1717         Add API test coverage.
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1720         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1721         (TEST):
1722
1723 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1724
1725         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1726         https://bugs.webkit.org/show_bug.cgi?id=196675
1727
1728         Reviewed by Lucas Forschler.
1729
1730         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1731         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1732
1733 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1734
1735         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1736         https://bugs.webkit.org/show_bug.cgi?id=196919
1737         <rdar://problem/41630459>
1738
1739         Reviewed by Tim Horton.
1740
1741         Add iOS support for several new testing hooks. See below for more detail.
1742
1743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1744         (WTR::UIScriptController::isDismissingMenu const):
1745
1746         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1747         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1748         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1749
1750         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1751         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1752         (WTR::UIScriptController::isDismissingMenu const):
1753         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1755         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1756         (WTR::InjectedBundle::didReceiveMessageToPage):
1757         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1758         (WTR::TestRunner::setAllowedMenuActions):
1759
1760         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1761         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1762         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1763         against the name of the custom action.
1764
1765         (WTR::TestRunner::installCustomMenuAction):
1766
1767         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1768         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1769         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1770         triggered.
1771
1772         (WTR::TestRunner::performCustomMenuAction):
1773
1774         Invoked when the custom menu action is triggered.
1775
1776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::installCustomMenuAction):
1779         (WTR::TestController::setAllowedMenuActions):
1780         * WebKitTestRunner/TestController.h:
1781         * WebKitTestRunner/TestInvocation.cpp:
1782         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1783         (WTR::TestInvocation::performCustomMenuAction):
1784
1785         Add plumbing to call back into the injected bundle when performing the custom action.
1786
1787         * WebKitTestRunner/TestInvocation.h:
1788         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1789         (WTR::TestController::installCustomMenuAction):
1790         (WTR::TestController::setAllowedMenuActions):
1791         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1792         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1793         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1794         (-[TestRunnerWKWebView becomeFirstResponder]):
1795         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1796
1797         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1798         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1799         in the Mail app on iOS.
1800
1801         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1802         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1803         (-[TestRunnerWKWebView resetCustomMenuAction]):
1804         (-[TestRunnerWKWebView performCustomAction:]):
1805         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1806         (-[TestRunnerWKWebView _willHideMenu]):
1807         (-[TestRunnerWKWebView _didHideMenu]):
1808         * WebKitTestRunner/ios/TestControllerIOS.mm:
1809         (WTR::TestController::platformResetStateToConsistentValues):
1810
1811         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1812         if specified.
1813
1814         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1815         (WTR::UIScriptController::isDismissingMenu const):
1816
1817 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1818
1819         Allow sharing from imageSheet on an image document
1820         https://bugs.webkit.org/show_bug.cgi?id=196891
1821         <rdar://problem/25377386>
1822
1823         Reviewed by Tim Horton.
1824
1825         Test to make sure that the correct imageURL is extracted from an image element.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1828         (TestWebKitAPI::TEST):
1829
1830 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1831
1832         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1833         https://bugs.webkit.org/show_bug.cgi?id=196995
1834
1835         Reviewed by Brady Eidson.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1838         (TEST):
1839
1840 2019-04-16  Chris Dumez  <cdumez@apple.com>
1841
1842         URL set by document.open() is not communicated to the UIProcess
1843         https://bugs.webkit.org/show_bug.cgi?id=196941
1844         <rdar://problem/49237544>
1845
1846         Reviewed by Geoff Garen.
1847
1848         Add API test coverage.
1849
1850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1851         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1852         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1853         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1854         (TEST):
1855
1856 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1857
1858         Unreviewed, rolling out r244321.
1859         https://bugs.webkit.org/show_bug.cgi?id=196968
1860
1861         Causing all WK2 Debug builds to exit early after Assertion
1862         failures. (Requested by ShawnRoberts on #webkit).
1863
1864         Reverted changeset:
1865
1866         "URL set by document.open() is not communicated to the
1867         UIProcess"
1868         https://bugs.webkit.org/show_bug.cgi?id=196941
1869         https://trac.webkit.org/changeset/244321
1870
1871 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1872
1873         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1874         https://bugs.webkit.org/show_bug.cgi?id=196948
1875
1876         Reviewed by Zalan Bujtas.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1879         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1880
1881 2019-04-15  Chris Dumez  <cdumez@apple.com>
1882
1883         URL set by document.open() is not communicated to the UIProcess
1884         https://bugs.webkit.org/show_bug.cgi?id=196941
1885         <rdar://problem/49237544>
1886
1887         Reviewed by Geoffrey Garen.
1888
1889         Add API test coverage.
1890
1891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1892         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1893         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1894         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1895         (TEST):
1896
1897 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1898
1899         Using Tools/Scripts/clean-webkit should not install requests
1900         https://bugs.webkit.org/show_bug.cgi?id=196940
1901
1902         Reviewed by Lucas Forschler.
1903
1904         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1905         existing, depending on the path autoinstalled is run through.
1906         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1907         needed.
1908         (Port.configuration_for_upload):
1909         (Port.commits_for_upload):
1910
1911 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1912
1913         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1914         https://bugs.webkit.org/show_bug.cgi?id=196773
1915
1916         Reviewed by Jer Noble.
1917
1918         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1919         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1920         (TEST):
1921
1922 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1923
1924         ews-build should clearly indicate flaky test failures
1925         https://bugs.webkit.org/show_bug.cgi?id=196947
1926
1927         Reviewed by Lucas Forschler.
1928
1929         * BuildSlaveSupport/ews-build/steps.py:
1930         (AnalyzeAPITestsResults.analyzeResults):
1931
1932 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1933
1934         InjectedBundle parameters often need initialization function called before unarchiving
1935         https://bugs.webkit.org/show_bug.cgi?id=189709
1936         <rdar://problem/44573653>
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1941         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1942
1943 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1944
1945         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1946         https://bugs.webkit.org/show_bug.cgi?id=196681
1947
1948         Reviewed by Darin Adler.
1949
1950         Added tests.
1951
1952         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1953         (WTF_HashSet.RemoveIf):
1954         (WTF_HashSet.RemoveIfShrinkToBestSize):
1955
1956 2019-04-15  John Wilander  <wilander@apple.com>
1957
1958         Send delayed Ad Click Attribution conversion requests to the click source
1959         https://bugs.webkit.org/show_bug.cgi?id=196838
1960         <rdar://problem/47650157>
1961
1962         Reviewed by Chris Dumez and Youenn Fablet.
1963
1964         This patch adds test infrastructure to override the default behavior in
1965         WebKit::NetworkAdClickAttribution.
1966
1967         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1968         (TestWebKitAPI::TEST):
1969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::dumpAdClickAttribution):
1972         (WTR::TestRunner::clearAdClickAttribution):
1973         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1974         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1976         * WebKitTestRunner/TestController.cpp:
1977         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1978         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1979         * WebKitTestRunner/TestController.h:
1980         * WebKitTestRunner/TestInvocation.cpp:
1981         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1982
1983 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1984
1985         [ews-app] status-bubble should display position in queue
1986         https://bugs.webkit.org/show_bug.cgi?id=196607
1987
1988         Reviewed by Lucas Forschler.
1989
1990         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1991         (StatusBubble._build_bubble):
1992         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1993
1994 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1995
1996         [ews-build] Do not run clean build by default on EWS builders
1997         https://bugs.webkit.org/show_bug.cgi?id=196897
1998
1999         Reviewed by Lucas Forschler.
2000
2001         * BuildSlaveSupport/ews-build/steps.py:
2002         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2003         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2004         untracked directories like WebKitBuild).
2005         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2006         untracked files/directories (like WebKitBuild).
2007
2008 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2009
2010         TestRunner::notifyDone() should be safely reentrant
2011         https://bugs.webkit.org/show_bug.cgi?id=196898
2012
2013         Reviewed by Darin Adler.
2014
2015         It is currently possible that TestRunner::notifyDone() will call itself, since
2016         notifyDone() will force a repaint, which can start executing JavaScript, which
2017         may call notifyDone() again. This can lead to test failures and flakiness.
2018         Fix this by setting the m_waitToDump flag before calling the dump() method.
2019
2020         * DumpRenderTree/mac/TestRunnerMac.mm:
2021         (TestRunner::notifyDone):
2022         (TestRunner::forceImmediateCompletion):
2023         * DumpRenderTree/win/TestRunnerWin.cpp:
2024         (TestRunner::notifyDone):
2025         (TestRunner::forceImmediateCompletion):
2026
2027 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2028
2029         [GTK][WPE] Add enable-media websetting
2030         https://bugs.webkit.org/show_bug.cgi?id=196863
2031
2032         Reviewed by Michael Catanzaro.
2033
2034         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2035         (testWebKitSettings): Add test for the enable-media web-setting.
2036
2037 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2038
2039         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2040         https://bugs.webkit.org/show_bug.cgi?id=196905
2041         <rdar://problem/49886096>
2042
2043         Reviewed by Tim Horton.
2044
2045         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2046         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2047         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2048         delay timer, we end up with this sequence of events in the problematic (failure) case:
2049
2050         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2051             ...IPC from UI to web process...
2052         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2053             ...IPC from web to UI process...
2054         (c) [UI]    Invoke completion handler for script #1
2055         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2056             ...IPC from UI to web process...
2057         (e) [Web]   Evaluate script #2 in the web process
2058         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2059
2060         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2061         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2062         #2 is run in step (e).
2063
2064         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2065         the UI process by waiting on a script message posted by the web process, after attachment updates are
2066         dispatched.
2067
2068         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2069         (TestWebKitAPI::TEST):
2070
2071 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2072
2073         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2074         https://bugs.webkit.org/show_bug.cgi?id=196909
2075
2076         Reviewed by Wenson Hsieh.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2079         (TestWebKitAPI::TEST):
2080
2081 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2082
2083         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2084         https://bugs.webkit.org/show_bug.cgi?id=196880
2085
2086         Reviewed by Yusuke Suzuki.
2087
2088         Add a new function for bytecode cache tests that does not forceDiskCache
2089         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2090         test added in this patch, since the code is invalid and therefore won't be
2091         cached. It should also be useful for tests that evaluate dynamically
2092         generated code.
2093
2094         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2095         * Scripts/run-jsc-stress-tests:
2096
2097 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2098
2099         Update AudioSession route sharing policy
2100         https://bugs.webkit.org/show_bug.cgi?id=196776
2101         <rdar://problem/46501611>
2102
2103         Reviewed by Jer Noble.
2104
2105         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2106         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2107         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2108         (TestWebKitAPI::TEST):
2109
2110 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2111
2112         [iOS] Software keyboard is shown too frequently on some websites
2113         https://bugs.webkit.org/show_bug.cgi?id=195856
2114         <rdar://problem/49191395>
2115
2116         Reviewed by Darin Adler.
2117
2118         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2119
2120         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2121         (WTR::UIScriptController::setHardwareKeyboardAttached):
2122         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2123         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2124         (WTR::UIScriptController::setHardwareKeyboardAttached):
2125         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2126         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2127
2128         Additionally link against GraphicsServices in WebKitTestRunner.
2129
2130         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2131         (WTR::TestController::platformResetStateToConsistentValues):
2132         (WTR::UIScriptController::setHardwareKeyboardAttached):
2133
2134 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2135
2136         [GTK][WPE] Fix pacman install-dependencies packages
2137         https://bugs.webkit.org/show_bug.cgi?id=196817
2138
2139         Reviewed by Žan Doberšek.
2140         
2141         python3-setuptools is called python-setuptools
2142         ruby-highline is only available on AUR
2143         libv4l-devel is incorporated in v4l-utils
2144
2145         * gtk/install-dependencies:
2146         * wpe/install-dependencies:
2147
2148 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2149
2150         [GTK] REGRESSION(r243860): Many tests failing
2151         https://bugs.webkit.org/show_bug.cgi?id=196791
2152
2153         Reviewed by Joanmarie Diggs.
2154
2155         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2156         multiple documents and check that accessibility hierarchy is updated after a navigation.
2157
2158         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2159         (loadChangedCallback):
2160         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2161         (AccessibilityTest::AccessibilityTest):
2162         (AccessibilityTest::~AccessibilityTest):
2163         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2164         (AccessibilityTest::findTestServerApplication):
2165         (AccessibilityTest::findDocumentWeb):
2166         (AccessibilityTest::findRootObject):
2167         (AccessibilityTest::waitUntilChildrenRemoved):
2168         (AccessibilityTest::ensureProxy):
2169         (testAtspiBasicHierarchy):
2170         (beforeAll):
2171         (afterAll):
2172
2173 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2174
2175         [ews-build] Handle bug titles with unicode characters
2176         https://bugs.webkit.org/show_bug.cgi?id=196802
2177
2178         Reviewed by Dewei Zhu.
2179
2180         * BuildSlaveSupport/ews-build/steps.py:
2181         (ValidatePatch._is_bug_closed):
2182
2183 2019-04-11  Michael Saboff  <msaboff@apple.com>
2184
2185         Improve the Inline Cache Stats code
2186         https://bugs.webkit.org/show_bug.cgi?id=196836
2187
2188         Reviewed by Saam Barati.
2189
2190         Added a new script to consolidate and arrange the output of --useICStats option.
2191
2192         This script merges the output from every group into one large table and sorts it from most common to
2193         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2194         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2195         Put together, this is useful to see what property accesses are not getting cached.
2196
2197         * Scripts/ic-stats.py: Added.
2198         (ICStats):
2199         (ICStats.__init__):
2200         (ICStats.parse):
2201         (ICStats.dumpStats):
2202         (usage):
2203
2204 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2205
2206         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2207         https://bugs.webkit.org/show_bug.cgi?id=196809
2208         <rdar://49800762>
2209
2210         Reviewed by Brady Eidson.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2213         (TEST):
2214
2215 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2216
2217         requestAnimationFrame should execute before the next frame
2218         https://bugs.webkit.org/show_bug.cgi?id=177484
2219
2220         Reviewed by Simon Fraser.
2221
2222         Add trace points for the page RenderingUpdate.
2223
2224         * Tracing/SystemTracePoints.plist:
2225
2226 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2227
2228         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2229         https://bugs.webkit.org/show_bug.cgi?id=196760
2230
2231         Reviewed by Don Olmstead.
2232
2233         vswhere.exe has been bundled since Visual Studio 2017 version
2234         15.2. We shouldn't download vswhere.exe.
2235
2236         * Scripts/build-jsc: Do not call update-vswhere.py.
2237         * Scripts/build-webkit: Ditto.
2238         * Scripts/update-vswhere.py: Removed.
2239         * Scripts/webkitdirs.pm:
2240         (requireModulesForVSWhere): Deleted.
2241         (pickCurrentVisualStudioInstallation): Deleted.
2242         (visualStudioInstallDirVSWhere): Return the latest installed VS
2243         installation path by using the bundled vswhere.exe.
2244         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2245         (visualStudioInstallDirFallback): Removed.
2246
2247 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2248
2249         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2250         https://bugs.webkit.org/show_bug.cgi?id=196780
2251
2252         Reviewed by Alexey Proskuryakov.
2253
2254         * BuildSlaveSupport/ews-build/steps.py:
2255         * BuildSlaveSupport/ews-build/steps_unittest.py:
2256
2257 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2258
2259         Add SPI WKNavigationResponse._downloadAttribute
2260         https://bugs.webkit.org/show_bug.cgi?id=196755
2261         <rdar://49587365>
2262
2263         Reviewed by Brady Eidson.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2266         (-[NavigationResponseTestDelegate navigationResponse]):
2267         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2268         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2269         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2270         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2271         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2272         (readRequest):
2273         (writeResponse):
2274         (TEST):
2275
2276 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2277
2278         Add modern API for overriding the page's specified viewport configuration
2279         https://bugs.webkit.org/show_bug.cgi?id=167734
2280         <rdar://problem/30331795>
2281
2282         Reviewed by Simon Fraser.
2283
2284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2285         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2286
2287 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2288
2289         Add support for incremental bytecode cache updates
2290         https://bugs.webkit.org/show_bug.cgi?id=195000
2291
2292         Reviewed by Filip Pizlo.
2293
2294         Exit when the initial run to generate bytecode fails.
2295
2296         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2297
2298 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2299
2300         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2301         https://bugs.webkit.org/show_bug.cgi?id=196744
2302         <rdar://49415309>
2303
2304         Reviewed by Chris Dumez.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2307         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2308
2309 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2310
2311         Add a way to opt into modern compatibility mode in layout tests
2312         https://bugs.webkit.org/show_bug.cgi?id=196770
2313         <rdar://problem/49777550>
2314
2315         Reviewed by Antoine Quint.
2316
2317         Add a new test option to enable modern compatibility mode in layout tests.
2318
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::updateTestOptionsFromTestHeader):
2321         * WebKitTestRunner/TestController.h:
2322         * WebKitTestRunner/TestOptions.h:
2323         (WTR::TestOptions::hasSameInitializationOptions const):
2324         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2325         (WTR::TestController::platformCreateWebView):
2326         (WTR::TestController::enableModernCompatibilityMode):
2327
2328 2019-04-10  Andy Estes  <aestes@apple.com>
2329
2330         Try to fix the 32-bit watchOS build.
2331
2332         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2333         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2334
2335 2019-04-10  Antoine Quint  <graouts@apple.com>
2336
2337         Enable Pointer Events on watchOS
2338         https://bugs.webkit.org/show_bug.cgi?id=196771
2339         <rdar://problem/49040909>
2340
2341         Reviewed by Dean Jackson.
2342
2343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2344
2345 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2346
2347         Unreviewed. Fix WPE accessibility tests after r244059.
2348
2349         We are failing to load the injected bundle due to undefined symbol
2350         AccessibilityUIElement::replaceTextInRange().
2351
2352         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2353         (WTR::AccessibilityUIElement::replaceTextInRange):
2354
2355 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2356
2357         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2358         https://bugs.webkit.org/show_bug.cgi?id=196727
2359
2360         Reviewed by Fujii Hironori.
2361
2362         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2363         (WebKitBrowserWindow::create):
2364
2365 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2366
2367         [ews-build] Add unit tests for PrintConfiguration
2368         https://bugs.webkit.org/show_bug.cgi?id=196752
2369
2370         Reviewed by Dewei Zhu.
2371
2372         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2373
2374 2019-04-09  Keith Rollin  <krollin@apple.com>
2375
2376         Unreviewed build maintenance -- update .xcfilelists.
2377
2378         * DumpRenderTree/DerivedSources-input.xcfilelist:
2379         * DumpRenderTree/DerivedSources-output.xcfilelist:
2380
2381 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2382
2383         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2384         https://bugs.webkit.org/show_bug.cgi?id=196743
2385         <rdar://problem/43897551>
2386
2387         Reviewed by Tim Horton.
2388
2389         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2390         (TEST):
2391
2392 2019-04-09  Youenn Fablet  <youenn@apple.com>
2393
2394         Close service worker database on network process suspension
2395         https://bugs.webkit.org/show_bug.cgi?id=196623
2396         <rdar://problem/48930869>
2397
2398         Reviewed by Alex Christensen.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2401
2402 2019-04-09  Daniel Bates  <dabates@apple.com>
2403
2404         [iPad] Should open popover when the spacebar is pressed
2405         https://bugs.webkit.org/show_bug.cgi?id=196360
2406         <rdar://problem/49389129>
2407
2408         Reviewed by Brent Fulgham.
2409
2410         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2411
2412         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2413         (WTR::UIScriptController::isShowingPopover const): Added.
2414         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2415         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2416         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2417         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2418         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2419         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2420         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2421         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2422         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2423         (WTR::UIScriptController::isShowingPopover const): Added.
2424         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2425         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2426         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2427         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2428         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2429         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2430         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2431         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2432         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2433         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2434         (WTR::UIScriptController::isShowingPopover const): Added.
2435         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2436         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2437
2438 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2439
2440         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2441         https://bugs.webkit.org/show_bug.cgi?id=196665
2442         <rdar://45115669>
2443
2444         Reviewed by Geoff Garen.
2445
2446         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2447         (goBack):
2448         (+[SimpleLookupContext sharedLookupContext]):
2449         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2450         (TEST):
2451         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2452         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2453
2454 2019-04-09  John Wilander  <wilander@apple.com>
2455
2456         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2457         https://bugs.webkit.org/show_bug.cgi?id=196558
2458         <rdar://problem/47650245>
2459
2460         Reviewed by Youenn Fablet.
2461
2462         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2463         (TestWebKitAPI::TEST):
2464             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2465
2466 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2467
2468         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2469         https://bugs.webkit.org/show_bug.cgi?id=196720
2470
2471         Reviewed by Konstantin Tokarev.
2472
2473         * TestWebKitAPI/PlatformMac.cmake:
2474
2475 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2476
2477         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2478         https://bugs.webkit.org/show_bug.cgi?id=196694
2479         <rdar://problem/48388734>
2480
2481         Rubber-stamped by Aakash Jain.
2482
2483         * Scripts/webkitpy/port/image_diff.py:
2484         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2485         * Scripts/webkitpy/port/server_process.py:
2486         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2487         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2488         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2489         * Scripts/webkitpy/port/server_process_mock.py:
2490         (MockServerProcess.has_available_stdout):
2491         * Scripts/webkitpy/port/server_process_unittest.py:
2492         (TestServerProcess.serial_test_basic):
2493
2494 2019-04-09  Jer Noble  <jer.noble@apple.com>
2495
2496         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2497         https://bugs.webkit.org/show_bug.cgi?id=196097
2498
2499         Reviewed by Eric Carlson.
2500
2501         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2502
2503         * DumpRenderTree/mac/DumpRenderTree.mm:
2504         (resetWebPreferencesToConsistentValues):
2505         * WebKitTestRunner/TestController.cpp:
2506         (WTR::TestController::resetPreferencesToConsistentValues):
2507
2508 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2509
2510         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2511         https://bugs.webkit.org/show_bug.cgi?id=196690
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         * QueueStatusServer/config/queues.py:
2516         * Scripts/webkitpy/common/config/ews.json:
2517         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2518         (test_ews_name):
2519
2520 2019-04-09  Chris Dumez  <cdumez@apple.com>
2521
2522         Loads using loadHTMLString() cause flashing when process-swapping
2523         https://bugs.webkit.org/show_bug.cgi?id=196714
2524         <rdar://problem/49637354>
2525
2526         Reviewed by Antti Koivisto.
2527
2528         Add API test coverage.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2531
2532 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2533
2534         Unreviewed. Fix ATK accessibility tests after r244059.
2535
2536         We are failing to load the injected bundle due to undefined symbol
2537         AccessibilityUIElement::replaceTextInRange().
2538
2539         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2540         (WTR::AccessibilityUIElement::replaceTextInRange):
2541
2542 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2543
2544         AX: Support API: accessibilityReplaceRange:withText
2545         https://bugs.webkit.org/show_bug.cgi?id=196636
2546
2547         Unreviewed build fix for Windows port.
2548
2549         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2550         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2551
2552 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2553
2554         [CMake][WinCairo] Separate copied headers into different directories
2555         https://bugs.webkit.org/show_bug.cgi?id=196655
2556
2557         Reviewed by Michael Catanzaro.
2558
2559         * DumpRenderTree/CMakeLists.txt:
2560         * MiniBrowser/win/CMakeLists.txt:
2561         * TestWebKitAPI/CMakeLists.txt:
2562         * TestWebKitAPI/PlatformWin.cmake:
2563
2564 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2565
2566         Log stack-trace for run-webkit-tests when interrupted
2567         https://bugs.webkit.org/show_bug.cgi?id=176393
2568         <rdar://problem/34262310>
2569
2570         Reviewed by Lucas Forschler.
2571
2572         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2573         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2574         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2575         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2576         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2577         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2578         (main): Set handlers to log stack trace on interruption.
2579
2580 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2581
2582         AX: Support API: accessibilityReplaceRange:withText
2583         https://bugs.webkit.org/show_bug.cgi?id=196636
2584
2585         Unreviewed build fix for Windows port.
2586
2587         * DumpRenderTree/AccessibilityUIElement.cpp:
2588         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2589
2590 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2591
2592         [ews-build] Scripts using Buildbot API have CORS error
2593         https://bugs.webkit.org/show_bug.cgi?id=196709
2594
2595         Reviewed by Alexey Proskuryakov.
2596
2597         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2598
2599 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2600
2601         AX: Support API: accessibilityReplaceRange:withText
2602         https://bugs.webkit.org/show_bug.cgi?id=196636
2603
2604         Reviewed by Daniel Bates.
2605
2606         * DumpRenderTree/AccessibilityUIElement.cpp:
2607         (replaceTextInRangeCallback):
2608         (AccessibilityUIElement::replaceTextInRange):
2609         (AccessibilityUIElement::getJSClass):
2610         * DumpRenderTree/AccessibilityUIElement.h:
2611         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2612         (AccessibilityUIElement::replaceTextInRange):
2613         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2614         (AccessibilityUIElement::replaceTextInRange):
2615         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2616         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2617         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2618         (WTR::AccessibilityUIElement::replaceTextInRange):
2619         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2620         (WTR::AccessibilityUIElement::replaceTextInRange):
2621
2622 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2623
2624         [iOS] Do not allow starting selection drags when selection views are not visible
2625         https://bugs.webkit.org/show_bug.cgi?id=196686
2626         <rdar://problem/49399192>
2627
2628         Reviewed by Tim Horton.
2629
2630         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2631         also add some new API tests to cover scenarios where the web view is not first responder.
2632
2633         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2634         (TestWebKitAPI::TEST):
2635         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2636
2637         Add a switch to optionally make the web view first responder when starting the simulated drag.
2638
2639         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2640         (-[DragAndDropSimulator initWithWebView:]):
2641         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2642
2643 2019-04-08  Justin Fan  <justin_fan@apple.com>
2644
2645         [Web GPU] Fix Web GPU experimental feature on iOS
2646         https://bugs.webkit.org/show_bug.cgi?id=196632
2647
2648         Reviewed by Myles C. Maxfield.
2649
2650         Properly make Web GPU available on iOS 11+.
2651
2652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2653
2654 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2655
2656         [ews-build] Do not upload archive when Compile Fails
2657         https://bugs.webkit.org/show_bug.cgi?id=196674
2658
2659         Reviewed by Alexey Proskuryakov.
2660
2661         * BuildSlaveSupport/ews-build/factories.py:
2662         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2663         * BuildSlaveSupport/ews-build/steps.py:
2664         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2665         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2666         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2667
2668 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2669
2670         Enable DFG on MIPS
2671         https://bugs.webkit.org/show_bug.cgi?id=196689
2672
2673         Reviewed by Žan Doberšek.
2674
2675         Since the bytecode change, we enabled the baseline JIT on mips in
2676         r240432, but DFG is still missing. With this change, all tests are
2677         passing on a ci20 board.
2678
2679         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2680
2681 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2682
2683         [Flatpak] Second run update-webkitwpe-flatpak fails
2684         https://bugs.webkit.org/show_bug.cgi?id=192702
2685
2686         Reviewed by Carlos Garcia Campos.
2687
2688         * flatpak/flatpakutils.py:
2689         (FlatpakObject.flatpak): Fix typo.
2690         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2691         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2692
2693 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2694
2695         [GTK][WPE] outlook.live.com displays old-fashioned UI
2696         https://bugs.webkit.org/show_bug.cgi?id=196642
2697
2698         Reviewed by Carlos Garcia Campos.
2699
2700         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2701         (TestWebKitAPI::TEST): New Mac platform quirk test.
2702
2703 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2704
2705         Unreviewed, rolling out r243956.
2706         https://bugs.webkit.org/show_bug.cgi?id=196688
2707
2708         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2709         by aakashjain on #webkit).
2710
2711         Reverted changeset:
2712
2713         "Clicking "Go Back" from a safe browsing warning from an
2714         iframe should navigate the WKWebView back to the previous
2715         page"
2716         https://bugs.webkit.org/show_bug.cgi?id=196665
2717         https://trac.webkit.org/changeset/243956
2718
2719 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2720
2721         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2722         https://bugs.webkit.org/show_bug.cgi?id=196669
2723
2724         Reviewed by Geoffrey Garen.
2725
2726         Added three new unit tests for WeakHashSet.
2727
2728         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2729         (WTF_WeakPtr.WeakHashSetConstObjects):
2730         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2731         (WTF_WeakPtr.WeakHashSetComputeSize):
2732
2733 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2734
2735         Hide next and previous form control buttons when WKWebView is editable
2736         https://bugs.webkit.org/show_bug.cgi?id=196672
2737         <rdar://problem/35625321>
2738
2739         Reviewed by Tim Horton.
2740
2741         Add a new API test.
2742
2743         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2744         (-[TestWKWebView lastTrailingBarButtonGroup]):
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/ios/UIKitSPI.h:
2747
2748 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2749
2750         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2751         https://bugs.webkit.org/show_bug.cgi?id=196077
2752         <rdar://problem/49108202>
2753
2754         Reviewed by Chris Dumez.
2755
2756         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2757         on new web view.
2758
2759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2760
2761 2019-04-05  Saam Barati  <sbarati@apple.com>
2762
2763         Make compare-results understand MotionMark
2764         https://bugs.webkit.org/show_bug.cgi?id=196666
2765
2766         Reviewed by Yusuke Suzuki.
2767
2768         * Scripts/compare-results:
2769         (PLT5Results):
2770         (detectMotionMark):
2771         (detectMotionMark1_1):
2772         (motionMarkResults):
2773         (motionMark1_1Results):
2774         (detectBenchmark):
2775         (biggerIsBetter):
2776         (main):
2777
2778 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2779
2780         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2781         https://bugs.webkit.org/show_bug.cgi?id=196665
2782         <rdar://45115669>
2783
2784         Reviewed by Geoff Garen.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2787         (goBack):
2788         (+[SimpleLookupContext sharedLookupContext]):
2789         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2790         (TEST):
2791         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2792         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2793
2794 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2795
2796         [ews-build] Add configuration and architecture for windows builders
2797         https://bugs.webkit.org/show_bug.cgi?id=196660
2798
2799         Reviewed by Lucas Forschler.
2800
2801         * BuildSlaveSupport/ews-build/config.json:
2802
2803 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2804
2805         webkitpy: Don't run subsequent rounds if interrupted
2806         https://bugs.webkit.org/show_bug.cgi?id=196646
2807
2808         Reviewed by Aakash Jain.
2809
2810         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2811         (Manager.run): Bail out if interrupted.
2812
2813 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2814
2815         Test sessionStorage in PSON private browsing mode
2816         https://bugs.webkit.org/show_bug.cgi?id=196561
2817
2818         Reviewed by Alex Christensen.
2819
2820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2821
2822 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2823
2824         Unreviewed, rolling out r243833.
2825         https://bugs.webkit.org/show_bug.cgi?id=196645
2826
2827         This change breaks build of WPE and GTK ports (Requested by
2828         annulen on #webkit).
2829
2830         Reverted changeset:
2831
2832         "[CMake][WTF] Mirror XCode header directories"
2833         https://bugs.webkit.org/show_bug.cgi?id=191662
2834         https://trac.webkit.org/changeset/243833
2835
2836 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2837
2838         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2839         https://bugs.webkit.org/show_bug.cgi?id=196635
2840
2841         Reviewed by Antti Koivisto.
2842         
2843         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2844         for a test to enable async frame scrolling via:
2845             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2846         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2847         
2848         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2849
2850         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2851         (WTR::InjectedBundle::beginTesting):
2852         * WebKitTestRunner/TestController.cpp:
2853         (WTR::TestController::resetPreferencesToConsistentValues):
2854
2855 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2856
2857         Use a correct LC_RPATH when building with ASan
2858         https://bugs.webkit.org/show_bug.cgi?id=196576
2859
2860         Reviewed by David Kilzer.
2861
2862         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2863         so that ../Frameworks is checked. This is simpler and more reliable than updating
2864         each SPC service xcconfig.
2865
2866 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2867
2868         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2869         https://bugs.webkit.org/show_bug.cgi?id=196629
2870
2871         Reviewed by Lucas Forschler.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2874
2875 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2876
2877         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2878         https://bugs.webkit.org/show_bug.cgi?id=196618
2879
2880         Reviewed by Lucas Forschler.
2881
2882         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2883         (StatusBubble): Added QUEUE_TRIGGERS.
2884         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2885         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2886         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2887         its parent(builder).
2888
2889 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2892         https://bugs.webkit.org/show_bug.cgi?id=196625
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2897         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2898
2899 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2900
2901         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2902         https://bugs.webkit.org/show_bug.cgi?id=196630
2903
2904         Reviewed by Wenson Hsieh.
2905
2906         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2907
2908 2019-04-04  Youenn Fablet  <youenn@apple.com>
2909
2910         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2911         https://bugs.webkit.org/show_bug.cgi?id=196543
2912
2913         Reviewed by Alex Christensen.
2914
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::generatePageConfiguration):
2917
2918 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2919
2920         [ews-app] Status bubble should not display skipped buildbot steps
2921         https://bugs.webkit.org/show_bug.cgi?id=196584
2922
2923         Reviewed by Lucas Forschler.
2924
2925         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2926
2927 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2928
2929         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2930         https://bugs.webkit.org/show_bug.cgi?id=196620
2931
2932         Reviewed by Lucas Forschler.
2933
2934         * BuildSlaveSupport/ews-app/ews/config.py:
2935
2936 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2937
2938         [Win] DumpRenderTreeWatchDog.py is not checked into source
2939         https://bugs.webkit.org/show_bug.cgi?id=196567
2940         <rdar://problem/49525901>
2941
2942         Reviewed by Lucas Forschler.
2943
2944         This script is used on Win EWS bots to terminate hanging DRT processes.
2945
2946         * EWSTools/dumprendertreewatchdog.py: Added.
2947
2948 2019-04-04  Chris Dumez  <cdumez@apple.com>
2949
2950         Unreviewed, roll out r243858 which made tests time out.
2951
2952         Disable new API tests on Windows instead.
2953
2954         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2955         (TestWebKitAPI::TEST):
2956
2957 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2958
2959         [ATK] Cleanup WebPageAccessibilityObjectAtk
2960         https://bugs.webkit.org/show_bug.cgi?id=196537
2961
2962         Reviewed by Michael Catanzaro.
2963
2964         Also consider files under atk directories as exceptions for GObject conventions.
2965
2966         * Scripts/webkitpy/style/checkers/cpp.py:
2967         (check_identifier_name_in_declaration):
2968
2969 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2970
2971         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2972         https://bugs.webkit.org/show_bug.cgi?id=196588
2973         <rdar://problem/49365787>
2974
2975         Unreviewed build fix for Windows port.
2976
2977         error C3861: 'kill': identifier not found
2978
2979         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2980         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2981
2982 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2983
2984         [ews-build] Cancel build and similar operations should have authentication
2985         https://bugs.webkit.org/show_bug.cgi?id=196520
2986
2987         Reviewed by Dewei Zhu.
2988
2989         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2990         environment variables.
2991
2992 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-build] Do not trigger queues which are not in production yet
2995         https://bugs.webkit.org/show_bug.cgi?id=196581
2996
2997         Reviewed by Dewei Zhu.
2998
2999         * BuildSlaveSupport/ews-build/config.json:
3000
3001 2019-04-03  Chris Dumez  <cdumez@apple.com>
3002
3003         Unreviewed, fix typo in the name of API test added in r243848.
3004
3005         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3006         (TestWebKitAPI::TEST):
3007
3008 2019-04-03  Chris Dumez  <cdumez@apple.com>
3009
3010         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3011         https://bugs.webkit.org/show_bug.cgi?id=196588
3012         <rdar://problem/49365787>
3013
3014         Reviewed by Ryosuke Niwa.
3015
3016         Add API test coverage.
3017
3018         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3019         (TestWebKitAPI::nullJavaScriptCallback):
3020         (TestWebKitAPI::didCrashCheckFrames):
3021         (TestWebKitAPI::TEST):
3022
3023 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3024
3025         run-webkit-tests: Upload test results (new results database)
3026         https://bugs.webkit.org/show_bug.cgi?id=196577
3027         <rdar://problem/34841155>
3028
3029         Reviewed by Lucas Forschler.
3030
3031         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3032         (Manager.run): Upload results after each device shard, since the configuration will be
3033         different for each device.
3034         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3035         uploaded to a results database.
3036         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3037         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3038
3039 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3040
3041         -apple-trailing-word is needed for browser detection
3042         https://bugs.webkit.org/show_bug.cgi?id=196575
3043
3044         Unreviewed.
3045
3046         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3047
3048 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3049
3050         [CMake][WTF] Mirror XCode header directories
3051         https://bugs.webkit.org/show_bug.cgi?id=191662
3052
3053         Reviewed by Konstantin Tokarev.
3054
3055         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3056         builds.
3057
3058         * CMakeLists.txt:
3059         * DumpRenderTree/CMakeLists.txt:
3060         * DumpRenderTree/PlatformWin.cmake:
3061         * MiniBrowser/win/CMakeLists.txt:
3062         * TestWebKitAPI/CMakeLists.txt:
3063         * TestWebKitAPI/PlatformWin.cmake:
3064         * WebKitTestRunner/PlatformGTK.cmake:
3065         * WebKitTestRunner/PlatformWin.cmake:
3066
3067 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3068
3069         [ews-app] Status bubble should not display certain infrastructure status messages
3070         https://bugs.webkit.org/show_bug.cgi?id=196550
3071
3072         Reviewed by Lucas Forschler.
3073
3074         Do not display the steps which are un-needed for end-user. This information is still avaiable
3075         if the user click on the bubble and look at the Buildbot build.
3076         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3077         (StatusBubble._steps_messages):
3078         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3079
3080 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3081
3082         [ews-build] Use https for sending data to ews-app
3083         https://bugs.webkit.org/show_bug.cgi?id=196492
3084
3085         Reviewed by Lucas Forschler.
3086
3087         * BuildSlaveSupport/ews-build/events.py:
3088
3089 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3090
3091         Remove support for -apple-trailing-word
3092         https://bugs.webkit.org/show_bug.cgi?id=196525
3093
3094         Reviewed by Zalan Bujtas.
3095
3096         This CSS property is nonstandard and not used.
3097
3098         * Scripts/webkitperl/FeatureList.pm:
3099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3100
3101 2019-04-03  Youenn Fablet  <youenn@apple.com>
3102
3103         Add a test for DOMCache on multiple browsing in case of private browsing
3104         https://bugs.webkit.org/show_bug.cgi?id=196524
3105
3106         Reviewed by Alex Christensen.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3109         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3110
3111 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3112
3113         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3114         https://bugs.webkit.org/show_bug.cgi?id=196540
3115
3116         Reviewed by Aakash Jain.
3117
3118         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3119
3120 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         Add plumbing for a compatibility mode preference in WebKit
3123         https://bugs.webkit.org/show_bug.cgi?id=196005
3124
3125         Reviewed by Tim Horton.
3126
3127         Add new API tests.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3131
3132 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3133
3134         [WPE][GTK] Update libsrtp dependency package for Debian
3135         https://bugs.webkit.org/show_bug.cgi?id=196528
3136
3137         Reviewed by Frédéric Wang.
3138
3139         * gtk/install-dependencies:
3140         * wpe/install-dependencies:
3141
3142 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3143
3144         [WK2] Add support for Window's beforeprint / afterprint events
3145         https://bugs.webkit.org/show_bug.cgi?id=196478
3146         <rdar://problem/49535124>
3147
3148         Unreviewed build fix for MSVC.
3149
3150         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3151
3152         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3153
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::printFrame): Use int and float literals.
3156
3157 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-build] Reassign bots to queues
3160
3161         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3162
3163 2019-04-02  Chris Dumez  <cdumez@apple.com>
3164
3165         [WK2] Add support for Window's beforeprint / afterprint events
3166         https://bugs.webkit.org/show_bug.cgi?id=196478
3167
3168         Reviewed by Alex Christensen.
3169
3170         Add minimal implementation for printFrame in WebKitTestRunner.
3171
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::printFrame):
3174         (WTR::TestController::createOtherPage):
3175         (WTR::TestController::createWebViewWithOptions):
3176
3177 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3178
3179         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3180         https://bugs.webkit.org/show_bug.cgi?id=196491
3181
3182         Reviewed by Lucas Forschler.
3183
3184         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3185
3186 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3187
3188         [ews-build] Configure buildbot try credentials in environment variables
3189         https://bugs.webkit.org/show_bug.cgi?id=196501
3190
3191         Reviewed by Lucas Forschler.
3192
3193         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3194         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3195         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3196
3197 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3198
3199         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3200         https://bugs.webkit.org/show_bug.cgi?id=196496
3201         <rdar://problem/49521634>
3202
3203         Reviewed by Chris Dumez.
3204
3205         Add new API tests (see WebKit ChangeLog for more detail).
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3208         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3209         (TEST):
3210
3211 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3212
3213         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3214         <https://webkit.org/b/196499>
3215
3216         Reviewed by Alexey Proskuryakov.
3217
3218         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3219         ENABLE_ADDRESS_SANITIZER.
3220
3221 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3222
3223         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3224         https://bugs.webkit.org/show_bug.cgi?id=182757
3225
3226         Reviewed by Don Olmstead.
3227
3228         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3229         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3230
3231 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3232
3233         run-api-tests: Upload test results
3234         https://bugs.webkit.org/show_bug.cgi?id=196323
3235         <rdar://problem/49356714>
3236
3237         Reviewed by Lucas Forschler.
3238
3239         * Scripts/webkitpy/api_tests/manager.py:
3240         (Manager):
3241         (Manager.run): Upload results to a results database.
3242         * Scripts/webkitpy/api_tests/run_api_tests.py:
3243         (parse_args): Add upload arguments.
3244         * Scripts/webkitpy/port/base.py:
3245         (Port):
3246         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3247         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3248         with commits from any other associated repositories.
3249         * Scripts/webkitpy/port/device.py:
3250         (Device):
3251         (Device.build_version): Access build_versoin of underlying platform device.
3252         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3253         (IOSSimulatorTest):
3254         (IOSSimulatorTest.test_configuration_for_upload):
3255         * Scripts/webkitpy/port/device_port.py:
3256         (DevicePort):
3257         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3258         the same as the machine uploading results.
3259         * Scripts/webkitpy/port/mac.py:
3260         (MacPort):
3261         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3262         * Scripts/webkitpy/port/mac_unittest.py:
3263         (MacTest):
3264         (MacTest.test_configuration_for_upload):
3265         * Scripts/webkitpy/xcode/simulated_device.py:
3266         (SimulatedDeviceManager._create_device_with_runtime):
3267         (SimulatedDevice.__init__): Create simulated device with a build_version.
3268         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3269         (test_existing_simulator):
3270
3271 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3272
3273         Remove extra newline characters (Follow-up fix to r243707)
3274
3275         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3276
3277 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3278
3279         [ews-app] Use API_KEY to accept results data
3280         https://bugs.webkit.org/show_bug.cgi?id=196461
3281
3282         Reviewed by Dewei Zhu.
3283
3284         * BuildSlaveSupport/ews-app/ews/views/results.py:
3285         (Results.post): Validate EWS_API_KEY before accepting any data.
3286         * BuildSlaveSupport/ews-build/events.py:
3287         (Events.sendData): Send EWS_API_KEY if available along with event data.
3288
3289 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3290
3291         Unable to copy and paste a PDF from Notes into Mail compose body
3292         https://bugs.webkit.org/show_bug.cgi?id=196442
3293         <rdar://problem/48573098>
3294
3295         Reviewed by Tim Horton.
3296
3297         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3298         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3299         to be specified on the item providers.
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3302         (TestWebKitAPI::mapItemForTesting):
3303         (TestWebKitAPI::contactItemForTesting):
3304
3305 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3306
3307         Make UIWKDocumentContext rects per-character instead of per-word
3308         https://bugs.webkit.org/show_bug.cgi?id=196459
3309
3310         Reviewed by Wenson Hsieh.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3313         (TEST):
3314         Adjust test results due to switching to per-character rects.
3315
3316 2019-04-01  Chris Dumez  <cdumez@apple.com>
3317
3318         UIProcess crash when a prewarmed process is terminated
3319         https://bugs.webkit.org/show_bug.cgi?id=196451
3320         <rdar://problem/49245471>
3321
3322         Reviewed by Geoffrey Garen.
3323
3324         Add API test coverage.
3325
3326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3327         (TEST):
3328
3329 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3332         https://bugs.webkit.org/show_bug.cgi?id=196449
3333
3334         Reviewed by Lucas Forschler.
3335
3336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3337         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3338         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3339         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3340
3341 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3344         https://bugs.webkit.org/show_bug.cgi?id=196444
3345
3346         Reviewed by Lucas Forschler.
3347
3348         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3349
3350 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3351
3352         Add SPI to canonicalize NSURLs with WTF::URL
3353         https://bugs.webkit.org/show_bug.cgi?id=196415
3354         <rdar://problem/44980271>
3355
3356         Reviewed by Darin Adler.
3357
3358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3359         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3360         (TestWebKitAPI::TEST):
3361
3362 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3363
3364         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3365         https://bugs.webkit.org/show_bug.cgi?id=196441
3366
3367         Reviewed by Carlos Garcia Campos.
3368
3369         Don't cache the wpe_view_backend object that might not exist yet at the
3370         time of EventSenderProxy constructor invocation, but instead retrieve
3371         that object whenever it's required for event dispatching. This should
3372         avoid crashes in this constructor now that it's invoked before any
3373         PlatformWindow has been set up (as changed in r243496).
3374
3375         * WebKitTestRunner/EventSenderProxy.h:
3376         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3377         (WTR::viewBackend):
3378         (WTR::EventSenderProxy::EventSenderProxy):
3379         (WTR::EventSenderProxy::mouseDown):
3380         (WTR::EventSenderProxy::mouseUp):
3381         (WTR::EventSenderProxy::mouseMoveTo):
3382         (WTR::EventSenderProxy::mouseScrollBy):
3383         (WTR::EventSenderProxy::keyDown):
3384         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3385
3386 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3387
3388         [Win][WebKit] MiniBrowser should support high DPI display
3389         https://bugs.webkit.org/show_bug.cgi?id=196391
3390
3391         Reviewed by Alex Christensen.
3392
3393         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3394         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3395         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3396         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3397
3398 2019-03-31  Sam Weinig  <weinig@apple.com>
3399
3400         Remove more i386 specific configurations
3401         https://bugs.webkit.org/show_bug.cgi?id=196430
3402
3403         Reviewed by Alexey Proskuryakov.
3404
3405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3406         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3407
3408 2019-03-31  Andy Estes  <aestes@apple.com>
3409
3410         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3411         https://bugs.webkit.org/show_bug.cgi?id=196433
3412         <rdar://problem/49293305>
3413
3414         Reviewed by Tim Horton.
3415
3416         Enhanced API test coverage to include all navigation response policy decisions in both
3417         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3418
3419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3420         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3421         (TestWebKitAPI::TEST):
3422         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3423         (readFile):
3424         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3425         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3426         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3427         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3428         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3429         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3430         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3431         (-[QuickLookDelegate _downloadDidStart:]):
3432         (-[QuickLookDelegate _download:didReceiveResponse:]):
3433         (-[QuickLookDelegate _download:didReceiveData:]):
3434         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3435         (-[QuickLookDelegate _downloadDidFinish:]):
3436         (-[QuickLookDelegate _download:didFailWithError:]):
3437         (-[QuickLookDelegate _downloadDidCancel:]):
3438         (-[QuickLookDelegate verifyDownload]):
3439         (runTest):
3440         (runTestDecideBeforeLoading):
3441         (runTestDecideAfterLoading):
3442         (TEST):
3443         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3444         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3445         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3446         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3447         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3448         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3449         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3450         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3451         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3452         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3453         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3454         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3455         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3456         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3457
3458 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3459
3460         [CMake] add testdfg as target with build-jsc
3461         https://bugs.webkit.org/show_bug.cgi?id=196393
3462
3463         Reviewed by Saam Barati.
3464
3465         Added testdfg as one of the targets to build when
3466         using CMake.
3467
3468         * Scripts/build-jsc:
3469
3470 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3471
3472         Delete WebMetal implementation in favor of WebGPU
3473         https://bugs.webkit.org/show_bug.cgi?id=195418
3474
3475         Reviewed by Dean Jackson.
3476
3477         * DumpRenderTree/mac/DumpRenderTree.mm:
3478         (enableExperimentalFeatures):
3479         (resetWebPreferencesToConsistentValues):
3480         * Scripts/webkitperl/FeatureList.pm:
3481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3483         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3484         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3485         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3486         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3487         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3488         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3489         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3490         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3491         (WTR::InjectedBundle::beginTesting):
3492         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3493         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3495
3496 2019-03-29  Chris Dumez  <cdumez@apple.com>
3497
3498         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3499         https://bugs.webkit.org/show_bug.cgi?id=196405
3500         <rdar://problem/49428130>
3501
3502         Reviewed by Wenson Hsieh.
3503
3504         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3505         the popover presentation methods to be no-ops. Use this in the new test added in
3506         r243523 so that we do not swizzle those methods for all tests. This is needed because
3507         those WatchOS tests rely on the popover getting presented and interactive.
3508
3509         * WebKitTestRunner/TestController.cpp:
3510         (WTR::updateTestOptionsFromTestHeader):
3511         * WebKitTestRunner/TestController.h:
3512         * WebKitTestRunner/TestOptions.h:
3513         (WTR::TestOptions::hasSameInitializationOptions const):
3514         * WebKitTestRunner/ios/TestControllerIOS.mm:
3515         (WTR::TestController::platformInitialize):
3516         (WTR::TestController::platformResetStateToConsistentValues):
3517
3518 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3519
3520         [Curl] Add Server Trust Evaluation Support.
3521         https://bugs.webkit.org/show_bug.cgi?id=191646
3522
3523         Reviewed by Fujii Hironori.
3524
3525         Implemented MiniBrowser UI for asking if user trusts the server.
3526
3527         * MiniBrowser/win/Common.cpp:
3528         (askServerTrustEvaluation):
3529         (replaceString):
3530         * MiniBrowser/win/Common.h:
3531         * MiniBrowser/win/MiniBrowserLib.rc:
3532         * MiniBrowser/win/MiniBrowserLibResource.h:
3533         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3534         (createPEMString):
3535         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3536         (WebKitBrowserWindow::canTrustServerCertificate):
3537         * MiniBrowser/win/WebKitBrowserWindow.h:
3538
3539 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3540
3541         Implement ResizeObserver.
3542         https://bugs.webkit.org/show_bug.cgi?id=157743
3543
3544         Reviewed by Simon Fraser.
3545
3546         Support resizeObserverEnabled webPreferences.
3547
3548         * DumpRenderTree/TestOptions.cpp:
3549         (TestOptions::TestOptions):
3550         * DumpRenderTree/TestOptions.h:
3551         * DumpRenderTree/mac/DumpRenderTree.mm:
3552         (setWebPreferencesForTestOptions):
3553         * DumpRenderTree/win/DumpRenderTree.cpp:
3554         (enableExperimentalFeatures):
3555         * Scripts/webkitperl/FeatureList.pm:
3556         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3557
3558 2019-03-28  John Wilander  <wilander@apple.com>
3559
3560         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3561         https://bugs.webkit.org/show_bug.cgi?id=196281
3562         <rdar://problem/48938748>
3563
3564         Reviewed by Alex Christensen.
3565
3566         This patch adds the function isStatisticsHasLocalStorage() to the
3567         TestRunner. With it, the page can query the WebsiteDataStore in the
3568         UI process to make sure that it sees LocalStorage.
3569
3570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3572         (WTR::TestRunner::isStatisticsHasLocalStorage):
3573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3574         * WebKitTestRunner/TestController.cpp:
3575         (WTR::TestController::isStatisticsHasLocalStorage):
3576         * WebKitTestRunner/TestController.h:
3577         * WebKitTestRunner/TestInvocation.cpp:
3578         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3579
3580 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3581
3582         API::Data::createWithoutCopying should do a null check before calling CFRelease
3583         https://bugs.webkit.org/show_bug.cgi?id=196276
3584         <rdar://problem/48059859>
3585
3586         Reviewed by Alex Christensen.
3587
3588         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3589
3590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3591         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3592         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3593         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3594         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3595         (TestWebKitAPI::TEST):
3596
3597 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3598
3599         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3600         https://bugs.webkit.org/show_bug.cgi?id=186276
3601
3602         Reviewed by Carlos Garcia Campos.
3603
3604         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3605         (webViewLoadChanged):
3606         (testWebResourceGetDataError):
3607         (testWebResourceGetDataEmpty):
3608         (beforeAll):
3609         (webViewloadChanged): Deleted.
3610
3611 2019-03-27  Andy Estes  <aestes@apple.com>
3612
3613         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3614         https://bugs.webkit.org/show_bug.cgi?id=196317
3615
3616         Reviewed by Dan Bernstein.
3617
3618         package-root copies built products into a staging directory using ditto(1), which does not
3619         follow symbolic links as it traverses a directory. Now that the files in
3620         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3621         itself, these become broken links when ditto'd into the staging directory.
3622
3623         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3624
3625         * Scripts/package-root:
3626
3627 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3628
3629         [ews-app] Update display text of Submit for ews analysis
3630         https://bugs.webkit.org/show_bug.cgi?id=196309
3631
3632         Reviewed by Dewei Zhu.
3633
3634         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3635
3636 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3637
3638         run-webkit-tests should check for leaks in WebKit processes
3639         <https://webkit.org/b/193772>
3640         <rdar://problem/46526680>
3641
3642         Reviewed by Ryosuke Niwa.
3643
3644         This works by doing the following:
3645         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3646           The list of child processes are returned one per line:
3647           process.name: pid
3648         - Run the "#LIST CHILD PROCESSES" command just before the
3649           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3650           processes on the ServerProcess object.
3651         - When the `--leaks` switch is handled, run check_for_leaks() on
3652           each child process after the main test harness.
3653
3654         * DumpRenderTree/mac/DumpRenderTree.mm:
3655         (handleControlCommand):
3656         - Use strncmp() instead of strcmp().
3657         - Add support for handling "#LIST CHILD PROCESSES" command.
3658
3659         * Scripts/webkitpy/port/base.py:
3660         (Port.check_for_leaks):
3661         * Scripts/webkitpy/port/darwin.py:
3662         (DarwinPort.check_for_leaks):
3663         - Rename redundant 'process_pid' argument to 'process_id'.
3664
3665         * Scripts/webkitpy/port/driver.py:
3666         (Driver.do_post_tests_work):
3667         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3668           longer the only command this sends to WebKitTestRunner.
3669         - If the `--leaks` switch is present, send the
3670           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3671           result using Port.set_webkit_processes().
3672         (Driver._parse_child_processes_output):
3673         - Add helper method to parse list of child process names and
3674           process IDs returned from WebKitTestRunner.
3675
3676         * Scripts/webkitpy/port/ios_device.py:
3677         (IOSDevicePort.check_for_leaks):
3678         - Rename redundant 'process_pid' argument to 'process_id'.
3679
3680         * Scripts/webkitpy/port/leakdetector.py:
3681         (LeakDetector._parse_leaks_output):
3682         - Return early if there is no leaks_output.
3683         (LeakDetector.check_for_leaks):
3684         - Rename redundant 'process_pid' argument to 'process_id'.
3685
3686         * Scripts/webkitpy/port/server_process.py:
3687         (ServerProcess.__init__):
3688         (ServerProcess.child_processes):
3689         (ServerProcess.set_child_processes):
3690         - Add instance variable to Port to store list of child process
3691           names and process IDs returned from WebKitTestRunner.
3692         (ServerProcess._start):
3693         - Clear self._child_processes.
3694         (ServerProcess.stop):
3695         - If self._child_processes is set, call
3696           self._port.check_for_leaks() for each child process.
3697
3698         * Scripts/webkitpy/port/server_process_unittest.py:
3699         (TrivialMockPort.check_for_leaks):
3700         - Rename redundant 'process_pid' argument to 'process_id'.
3701
3702         * Scripts/webkitpy/port/simulator_process.py:
3703         (SimulatorProcess.stop):
3704         - If self._child_processes is set, call
3705           self._port.check_for_leaks() for each child process.
3706
3707         * Scripts/webkitpy/port/watch_device.py:
3708         (WatchDevicePort.check_for_leaks):
3709         - Rename redundant 'process_pid' argument to 'process_id'.
3710
3711         * WebKitTestRunner/TestController.cpp:
3712         (WTR::TestController::dumpResponse):
3713         - Extract method from findAndDumpWorldLeaks() so that it may be
3714           reused by findAndDumpWebKitProcessIdentifiers().
3715         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3716         - Add method to output process name and process ID of both the
3717           WebContent and Networking processes.
3718         (WTR::TestController::findAndDumpWorldLeaks):
3719         - Fix missing newline in output when there were no abandoned
3720           documents.
3721         - Call dumpResponse() for extracted code.
3722         (WTR::TestController::handleControlCommand):
3723         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3724         - Use strncmp() instead of strcmp().
3725         - Call findAndDumpWebKitProcessIdentifiers() when
3726           "#LIST CHILD PROCESSES" command is sent.
3727         * WebKitTestRunner/TestController.h:
3728         (WTR::TestController::dumpResponse):
3729         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3730         - Declare methods.
3731
3732 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3733
3734         Unreviewed. Add GLib API test cases after r243434.
3735
3736         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3737         (testWebViewActiveURI):
3738         (serverCallback):
3739         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3740         (sendRequestCallback):
3741
3742 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3743
3744         Geolocation request not complete when watch request was started in a different web process
3745         https://bugs.webkit.org/show_bug.cgi?id=195996
3746
3747         Reviewed by Alex Christensen.
3748
3749         Add a test case.
3750
3751         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3752         (TestWebKitAPI::runJavaScriptAlert):
3753         (TestWebKitAPI::TEST):
3754
3755 2019-03-26  Keith Rollin  <krollin@apple.com>
3756
3757         Update the way generate-xcfilelists returns strings from functions
3758         https://bugs.webkit.org/show_bug.cgi?id=195975
3759         <rdar://problem/49040807>
3760
3761         Reviewed by Dean Jackson.
3762
3763         There are places where generate-xcfilelists executes assignments with
3764         statements like:
3765
3766             FOO=$(some_function)
3767
3768         where "some_function" return a string by echoing it. E.g.
3769
3770             some_function()
3771             {
3772                 echo "Hello, World"
3773             }
3774
3775         This is a common idiom, but it has a problem if "some_function" needs
3776         to call "exit" in an attempt to halt the entire script right then and
3777         there. Since "some_function" is called inside of $(), it's being
3778         executed in a sub-shell. Calling exit in that sub-shell simply exits
3779         that shell; it doesn't not exit the outer shell in which the main part
3780         of the script is still running. As such, the main script keeps
3781         executing when the intent was for the script to halt.
3782
3783         The solution to this is to use a different idiom for returning
3784         strings. The one we now is to pass in the name of the variable to
3785         receive the string result:
3786
3787             some_function()
3788             {
3789                 variable_name=$1
3790                 eval $variable_name ="Hello, World"
3791             }
3792
3793         The call site now looks like
3794
3795             some_function FOO
3796
3797         Because there's no invocation of a sub-shell, some_function can now
3798         call "exit" if it wants to, and the entire script will exit at that
3799         point.
3800
3801         * Scripts/generate-xcfilelists:
3802
3803 2019-03-26  Chris Dumez  <cdumez@apple.com>
3804
3805         Add basic layout test coverage for File Picker on iOS
3806         https://bugs.webkit.org/show_bug.cgi?id=196265
3807
3808         Reviewed by Wenson Hsieh.
3809
3810         Add layout test infrastructure to test the file picker on iOS.
3811
3812         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3813         (WTR::UIScriptController::dismissFilePicker):
3814         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3815         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3816         (WTR::UIScriptController::dismissFilePicker):
3817         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3818         * WebKitTestRunner/TestController.cpp:
3819         (WTR::TestController::createWebViewWithOptions):
3820         (WTR::updateTestOptionsFromTestHeader):
3821         * WebKitTestRunner/TestOptions.h:
3822         (WTR::TestOptions::hasSameInitializationOptions const):
3823         * WebKitTestRunner/ios/TestControllerIOS.mm:
3824         (overridePresentViewController):
3825         (WTR::TestController::platformInitialize):
3826         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3827         (WTR::UIScriptController::dismissFilePicker):
3828
3829 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3830
3831         Implement async paste method on UIWKInteractionViewProtocol
3832         https://bugs.webkit.org/show_bug.cgi?id=196267
3833         <rdar://problem/49236346>
3834
3835         Reviewed by Tim Horton.
3836
3837         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3838         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3839         are now a part of all iOS 12 internal SDKs.
3840
3841         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3842
3843         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3844         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3845
3846         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3847         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3848         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3849         * TestWebKitAPI/ios/UIKitSPI.h:
3850
3851 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3852
3853         [ews-build] Use PostgreSQL for ews.webkit.org database
3854         https://bugs.webkit.org/show_bug.cgi?id=196270
3855
3856         Reviewed by Lucas Forschler.
3857
3858         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3859
3860 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3861
3862         [ews] Reset simctl states on reboot
3863         https://bugs.webkit.org/show_bug.cgi?id=196260
3864
3865         Rubber-stamped by Aakash Jain.
3866
3867         * EWSTools/start-queue-mac.sh:
3868
3869 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3870
3871         [ews-build] Use PostgreSQL for ews-build database
3872         https://bugs.webkit.org/show_bug.cgi?id=196229
3873
3874         Reviewed by Lucas Forschler.
3875
3876         * BuildSlaveSupport/ews-build/master.cfg:
3877
3878 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3879
3880         [ews-build] Get master_hostname dynamically in master.cfg
3881         https://bugs.webkit.org/show_bug.cgi?id=196255
3882
3883         Reviewed by Lucas Forschler.
3884
3885         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3886         send events data in test mode.
3887
3888 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3889
3890         [ews-app] Set db_constraint to False for Foreign Keys
3891         https://bugs.webkit.org/show_bug.cgi?id=196252
3892
3893         Reviewed by Lucas Forschler.
3894
3895         * BuildSlaveSupport/ews-app/ews/models/build.py:
3896         * BuildSlaveSupport/ews-app/ews/models/step.py:
3897
3898 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3899
3900         [ews-build] is_test_mode_enabled should default to True
3901         https://bugs.webkit.org/show_bug.cgi?id=196248
3902
3903         Reviewed by Lucas Forschler.
3904
3905         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3906
3907 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3908
3909         [ews-app] Add webkitperl to ENABLED_QUEUES
3910         https://bugs.webkit.org/show_bug.cgi?id=196253
3911
3912         Reviewed by Lucas Forschler.
3913
3914         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3915
3916 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3917
3918         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3919         https://bugs.webkit.org/show_bug.cgi?id=196211
3920         rdar://problem/49110552
3921
3922         Reviewed by Tim Horton.
3923
3924         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3925         Make sure that EventSenderProxy always exists when running tests. We used to create
3926         it when resetting before the first test, which is a bit too late.
3927
3928         * WebKitTestRunner/TestController.h:
3929         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3930         (WTR::TestController::platformCreateWebView):
3931         (WTR::TestController::platformCreateOtherPage):
3932         (WTR::TestController::finishCreatingPlatformWebView):
3933         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3934         (WTR::PlatformWebView::PlatformWebView):
3935         Moved some code that made NSWindow use NSEvent during web view creation. We may
3936         need to move more if some other case us found, but this is enough for now.
3937
3938 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3939
3940         Unreviewed. Fix typo in GLib geolocation API after r243285.
3941
3942         gelocation -> geolocation.
3943
3944         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3945         (testGeolocationManagerWatchPosition):
3946
3947 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3948
3949         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3950         https://bugs.webkit.org/show_bug.cgi?id=196213
3951
3952         Reviewed by Geoff Garen.
3953
3954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3955         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3956         (credentialWithIdentityAndKeychainPath):
3957         (-[ChallengeDelegate webView:didFinishNavigation:]):
3958         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3959         (TestWebKitAPI::TEST):
3960
3961 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3962
3963         Expected shouldn't assume its contained types are copyable
3964         https://bugs.webkit.org/show_bug.cgi?id=195986
3965
3966         Reviewed by JF Bastien.
3967
3968         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3969         (TestWebKitAPI::NonCopyable::operator== const):
3970         (TestWebKitAPI::NonCopyable::operator!= const):
3971         (TestWebKitAPI::TEST):
3972
3973 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3974
3975         Remove some now-unnecessary dynamic class lookup
3976         https://bugs.webkit.org/show_bug.cgi?id=196237
3977
3978         Reviewed by Simon Fraser.
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3981         (makeRequest):
3982         (TEST):
3983
3984 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3985
3986         Unreviewed, rolling out r243450.
3987
3988         AppleWin and WinCairo port builds get broken.
3989
3990         Reverted changeset:
3991
3992         "Add test for fix of #196095"
3993         https://bugs.webkit.org/show_bug.cgi?id=196097
3994         https://trac.webkit.org/changeset/243450
3995
3996 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3997
3998         Unreviewed, rolling out r243465.
3999         https://bugs.webkit.org/show_bug.cgi?id=196226
4000
4001         the test doesn't build (Requested by thorton on #webkit).
4002
4003         Reverted changeset:
4004
4005         "Do not terminate the NetworkProcess if a third party
4006         application sends a NSCredential with a SecIdentityRef"
4007         https://bugs.webkit.org/show_bug.cgi?id=196213
4008         https://trac.webkit.org/changeset/243465
4009
4010 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4011
4012         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4013         https://bugs.webkit.org/show_bug.cgi?id=196213
4014
4015         Reviewed by Geoff Garen.
4016
4017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4018         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4019         (credentialWithIdentityAndKeychainPath):
4020         (-[ChallengeDelegate webView:didFinishNavigation:]):
4021         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4022         (TestWebKitAPI::TEST):
4023
4024 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4025
4026         [ews-build] Gracefully handle missing patch_id in events
4027         https://bugs.webkit.org/show_bug.cgi?id=196216
4028
4029         Reviewed by Lucas Forschler.
4030
4031         * BuildSlaveSupport/ews-build/events.py:
4032
4033 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4034
4035         [ews-build] use lz4 compression for improving buildbot performance
4036         https://bugs.webkit.org/show_bug.cgi?id=196155
4037
4038         Reviewed by Lucas Forschler.
4039
4040         * BuildSlaveSupport/ews-build/master.cfg:
4041
4042 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4043
4044         Pull some API testing helper methods out of TestWKWebView
4045         https://bugs.webkit.org/show_bug.cgi?id=196212
4046
4047         Reviewed by Tim Horton.
4048
4049         Refactor some more API testing utility methods, so that they can be used in
4050         tests that do not use TestWKWebView.
4051
4052         * TestWebKitAPI/cocoa/TestWKWebView.h:
4053         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4054         (-[WKWebView loadTestPageNamed:]):
4055         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4056         (-[WKWebView synchronouslyLoadHTMLString:]):
4057         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4058         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4059         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4060         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4061         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4062
4063 2019-03-25  Jer Noble  <jer.noble@apple.com>
4064
4065         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4066         https://bugs.webkit.org/show_bug.cgi?id=196097
4067
4068         Reviewed by Eric Carlson.
4069
4070         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4071
4072         * DumpRenderTree/mac/DumpRenderTree.mm:
4073         (resetWebPreferencesToConsistentValues):
4074         * WebKitTestRunner/TestController.cpp:
4075         (WTR::TestController::resetPreferencesToConsistentValues):
4076
4077 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4078
4079         Pull IPadUserInterfaceSwizzler out into a separate header file
4080         https://bugs.webkit.org/show_bug.cgi?id=196193
4081
4082         Reviewed by Anders Carlsson.
4083
4084         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
4085         be used in other API tests.
4086
4087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4088         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4089         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
4090         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
4091         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
4092         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
4093         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
4094
4095 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4096
4097         Remove NavigatorContentUtils in WebCore/Modules
4098         https://bugs.webkit.org/show_bug.cgi?id=196070
4099
4100         Reviewed by Alex Christensen.
4101
4102         NavigatorContentUtils was to support the custom scheme spec [1].
4103         However, in WebKit side, no port has supported the feature in
4104         WebKit layer after EFL port was removed. So there has been the
4105         only IDL implementation of the NavigatorContentUtils in WebCore.
4106         So we don't need to keep the implementation in WebCore anymore.
4107
4108         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
4109
4110         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4111
4112 2019-03-24  Andy Estes  <aestes@apple.com>
4113
4114         [watchOS] Remove unused Proximity Networking code
4115         https://bugs.webkit.org/show_bug.cgi?id=196188
4116
4117         Reviewed by Tim Horton.
4118
4119         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4120         (TEST):
4121
4122 2019-03-23  Keith Miller  <keith_miller@apple.com>
4123
4124         Refactor clz/ctz and fix getLSBSet.
4125         https://bugs.webkit.org/show_bug.cgi?id=196162
4126
4127         Reviewed by Saam Barati.
4128
4129         Add tests for clz, ctz, getLSBSet, and getMSBSet.
4130
4131         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4132         (TestWebKitAPI::TEST):
4133
4134 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4135
4136         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
4137         https://bugs.webkit.org/show_bug.cgi?id=196143
4138
4139         Reviewed by Michael Catanzaro.
4140
4141         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
4142         directories.
4143
4144         * Scripts/webkitpy/style/checkers/cpp.py:
4145         (check_identifier_name_in_declaration):
4146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4147         (WebKitStyleTest.test_names):
4148
4149 2019-03-22  Philippe Normand  <pnormand@igalia.com>
4150
4151         [Flatpak] Manifest expanding fails for qt WPE extension
4152         https://bugs.webkit.org/show_bug.cgi?id=196148
4153
4154         Reviewed by Alex Christensen.
4155
4156         * flatpak/flatpakutils.py:
4157         (expand_submodules_recurse): The last recurse manifest expand
4158         iteration might lead to a single module so take it into account
4159         and don't try to recurse further.
4160
4161 2019-03-22  Chris Dumez  <cdumez@apple.com>
4162
4163         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
4164         https://bugs.webkit.org/show_bug.cgi?id=195348
4165         <rdar://problem/48622090>
4166
4167         Reviewed by Alex Christensen.
4168
4169         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
4170         to NO when test.options().shouldIgnoreMetaViewport is false.
4171
4172         * WebKitTestRunner/ios/TestControllerIOS.mm:
4173         (WTR::TestController::platformConfigureViewForTest):
4174
4175 2019-03-22  Chris Dumez  <cdumez@apple.com>
4176
4177         Prewarmed processes should be usable with any website data store
4178         https://bugs.webkit.org/show_bug.cgi?id=196104
4179
4180         Reviewed by Alex Christensen.
4181
4182         Add API test coverage.
4183
4184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4185         (runInitialWarmedProcessUsedTest):
4186         (TEST):
4187
4188 2019-03-22  David Kilzer  <ddkilzer@apple.com>
4189
4190         Back out local changes to Alex's Subversion working directory
4191
4192         They were accidentally committed.
4193
4194         * Scripts/webkitpy/common/system/abstractexecutive.py:
4195         (AbstractExecutive.wait_newest):
4196         * Scripts/webkitpy/common/system/executive.py:
4197         (Executive.running_pids):
4198         * Scripts/webkitpy/common/system/executive_mock.py:
4199         (MockExecutive.running_pids):
4200         * Scripts/webkitpy/common/system/executive_unittest.py:
4201         (ExecutiveTest.serial_test_running_pids):
4202         * Scripts/webkitpy/port/darwin.py:
4203         (DarwinPort.check_for_leaks):
4204         * Scripts/webkitpy/port/leakdetector.py:
4205         (LeakDetector.check_for_leaks):
4206         - This was the hack attached to Bug 193772.
4207
4208         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
4209         (+[WebKitTestRunnerEvent mouseLocation]):
4210         - This works around a crash on an internal build.
4211
4212 2019-03-22  Tim Horton  <timothy_horton@apple.com>
4213
4214         Fix the build after r243354
4215         https://bugs.webkit.org/show_bug.cgi?id=196138
4216         <rdar://problem/49145951>
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4219         (TEST):
4220         * TestWebKitAPI/ios/UIKitSPI.h:
4221
4222 2019-03-21  Tim Horton  <timothy_horton@apple.com>
4223
4224         Adopt UIWKDocumentContext
4225         https://bugs.webkit.org/show_bug.cgi?id=196040
4226         <rdar://problem/48642440>
4227
4228         Reviewed by Ryosuke Niwa.
4229
4230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4231         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
4232         (makeRequest):
4233         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
4234         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
4235         (applyStyle):
4236         (TEST):
4237         Add tests for UIWKDocumentContext.
4238
4239         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
4240         (TEST):
4241         (recursiveFindWKContentView): Deleted.
4242         * TestWebKitAPI/cocoa/TestWKWebView.h:
4243         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4244         (recursiveFindWKContentView):
4245         (-[TestWKWebView wkContentView]):
4246         * TestWebKitAPI/ios/UIKitSPI.h:
4247         Share the WKContentView finding code between tests.
4248
4249 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
4250
4251         [iOS WK2] Turn on async overflow scrolling by default
4252         https://bugs.webkit.org/show_bug.cgi?id=196011
4253         rdar://problem/48453859
4254
4255         Reviewed by Antti Koivisto.
4256         
4257         Explicitly turn off the async overflow scrolling internal feature for tests by default,
4258         since so many basic layout tests have different results when compositing is triggered for
4259         overflow.
4260         
4261         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
4262
4263         * WebKitTestRunner/TestController.cpp:
4264         (WTR::TestController::resetPreferencesToConsistentValues):
4265
4266 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4267
4268         [ews-build] Retry API test in case of failures
4269         https://bugs.webkit.org/show_bug.cgi?id=196004
4270
4271         Reviewed by Lucas Forschler.
4272
4273         * BuildSlaveSupport/ews-build/steps.py:
4274         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
4275         (CompileWebKitToT.doStepIf): Ditto.
4276         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
4277         (ReRunAPITests): Re-run API tests.
4278         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
4279         (RunAPITestsWithoutPatch): Run API tests without patch.
4280         (RunAPITestsWithoutPatch.doStepIf):
4281         (RunAPITestsWithoutPatch.hideStepIf):
4282         (RunAPITestsWithoutPatch.evaluateCommand):
4283         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
4284         (AnalyzeAPITestsResults.start):
4285         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
4286         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
4287         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
4288         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
4289
4290 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4291
4292         [ews-build] Update queues configurations
4293         https://bugs.webkit.org/show_bug.cgi?id=196074
4294
4295         Reviewed by Dewei Zhu.
4296
4297         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
4298         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
4299
4300 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4301
4302         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
4303         https://bugs.webkit.org/show_bug.cgi?id=195680
4304         <rdar://problem/48903534>