TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-15  David Kilzer  <ddkilzer@apple.com>
2
3         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
4         <http://webkit.org/b/132959>
5
6         Reviewed by Dan Bernstein.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
9         Cocoa directory to project and move URLExtras.mm into it.
10         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
11
12 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
13
14         [GTK] Compile all installed resources as GResources
15         https://bugs.webkit.org/show_bug.cgi?id=131099
16
17         Reviewed by Philippe Normand.
18
19         * Scripts/webkitpy/port/gtk.py:
20         (GtkPort.setup_environ_for_server): Removed now unneeded
21         AUDIO_RESOURCES_PATH env var.
22
23 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
24
25         Remove CSS_STICKY_POSITION guards
26         https://bugs.webkit.org/show_bug.cgi?id=132676
27
28         Reviewed by Simon Fraser.
29
30         * Scripts/webkitperl/FeatureList.pm:
31
32 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
33
34         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
35         https://bugs.webkit.org/show_bug.cgi?id=132686
36
37         Reviewed by Philippe Normand.
38
39         Bring back InputMethodFilter test to the build and compile it into
40         a single binary TestWebCore with the other WebCore tests. Also
41         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
42
43         * Scripts/run-gtk-tests:
44         (TestRunner): Remove WebCoreGtk from the list of test directories.
45         * TestWebKitAPI/PlatformGTK.cmake:
46         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
47
48 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
49
50         [EFL] Make XVFBDriver optional
51         https://bugs.webkit.org/show_bug.cgi?id=131036
52
53         Reviewed by Gyuyoung Kim.
54
55         * Scripts/webkitpy/port/efl.py:
56         (EflPort._driver_class):
57
58 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
59
60         Flakiness dashboard contains outdated list of bots on builders.jsonp
61         https://bugs.webkit.org/show_bug.cgi?id=132874
62
63         Reviewed by Darin Adler.
64
65         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
66         file by changing to the directory Tools/TestResultServer and executing
67         the script generate_builders_json.py
68
69 2014-05-11  Anders Carlsson  <andersca@apple.com>
70
71         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
72         https://bugs.webkit.org/show_bug.cgi?id=132809
73
74         Reviewed by Dan Bernstein.
75
76         * WebKitTestRunner/TestController.cpp:
77         (WTR::TestController::initialize):
78         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
79
80 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
81
82         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
83         https://bugs.webkit.org/show_bug.cgi?id=132739
84
85         Reviewed Anders Carlsson.
86
87         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
88         the JSC unit tests.
89         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
90
91 2014-05-11  Anders Carlsson  <andersca@apple.com>
92
93         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
94         https://bugs.webkit.org/show_bug.cgi?id=132806
95
96         Reviewed by Beth Dakin.
97
98         Migrate to WKContextConfiguration.
99
100         * WebKitTestRunner/TestController.cpp:
101         (WTR::TestController::initialize):
102
103 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
106         https://bugs.webkit.org/show_bug.cgi?id=132685
107
108         Reviewed by Martin Robinson.
109
110         Use a single TestWebKit2 binary for all WebKit2 C API tests.
111
112         * TestWebKitAPI/PlatformGTK.cmake:
113
114 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
115
116         [iOS] Switch geolocation to an explicit authorization query model
117         https://bugs.webkit.org/show_bug.cgi?id=132717
118
119         Reviewed by Sam Weinig.
120
121         * DumpRenderTree/mac/MockGeolocationProvider.mm:
122         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
123         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
124
125 2014-05-09  David Farler  <dfarler@apple.com>
126
127         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
128         https://bugs.webkit.org/show_bug.cgi?id=132718
129
130         Reviewed by David Kilzer.
131
132         The simulator may not be able to look up runtimes by SDK paths
133         and instead will map SDK versions to runtimes instead. In
134         com.apple.iphonesimulator.startSession notifications,
135         'runtimeIdentifier' (SDK version string) is preferred over
136         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
137         when creating a new DRT or WKTR simulator session.
138
139         IPhoneSimulatorNotification.pm filters out keys for this
140         notification's userInfo with a hard-coded list. There's no harm
141         in including extra key-value pairs in an NSNotification userInfo
142         dictionary anyway and the simulator may again change its
143         userInfo schema for this notification.
144
145         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
146         (postStartSessionNotification):
147         * Scripts/old-run-webkit-tests:
148         (installAndLaunchDumpToolAppUsingNotification):
149
150 2014-05-09  Anders Carlsson  <andersca@apple.com>
151
152         Another build fix.
153
154         * Scripts/build-webkit:
155         WebKit2 should always be built for OS X and iOS.
156
157 2014-05-09  Anders Carlsson  <andersca@apple.com>
158
159         Follow-up build fix.
160
161         * Scripts/build-webkit:
162         WebKit2 should no longer be built before WebKit.
163
164 2014-05-09  Anders Carlsson  <andersca@apple.com>
165
166         Rename WebKit2.framework to WebKit.framework
167         https://bugs.webkit.org/show_bug.cgi?id=132743
168         <rdar://problem/15920046>
169
170         Reviewed by Dan Bernstein.
171
172         * Scripts/check-for-inappropriate-files-in-framework:
173         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
174         Change WebKit2 to WebKit.
175
176         * Scripts/check-for-webkit-framework-include-consistency:
177         Change WebKit to WebKitLegacy.
178
179 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
180
181         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
182         https://bugs.webkit.org/show_bug.cgi?id=132732
183
184         Reviewed by Alexey Proskuryakov.
185
186         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
189         (EWS): Remove GTK+ WK1 EWS.
190
191 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
192
193         Add new u-szeged contributors.
194
195         Reviewed by Csaba Osztrogonác.
196
197         * Scripts/webkitpy/common/config/contributors.json:
198
199 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
200
201         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
202         https://bugs.webkit.org/show_bug.cgi?id=132736
203
204         Reviewed by Philippe Normand.
205
206         There are two problems, the path returned by common.library_build_path() is wrong when
207         common.binary_build_path() has previously been called, and the test is still looking for
208         the .la instead of .so
209
210         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
211         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
212         of .la as extension of the injected bundle library.
213         * gtk/common.py:
214         (binary_build_path): Remove unused global variable and add a new
215         one for binary_build_dir instead of sharing the same global
216         variable for library_build_path and binary_build_path.
217
218 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
219
220         [EFL] Enable MEDIA_STREAM for EFL port
221         https://bugs.webkit.org/show_bug.cgi?id=132648
222
223         Reviewed by Gyuyoung Kim.
224
225         Script modified to enable MEDIA_STREAM for EFL build.
226
227         * Scripts/webkitperl/FeatureList.pm: 
228
229 2014-05-08  David Farler  <dfarler@apple.com>
230
231         old-run-webkit-tests: update strings for simulator devices and app name
232         https://bugs.webkit.org/show_bug.cgi?id=132687
233
234         Reviewed by Darin Adler.
235
236         iPhone Retina (4-inch) -> iPhone 5
237         iPhone Retina (4-inch 64-bit) -> iPhone 5s
238
239         * Scripts/old-run-webkit-tests:
240         (installAndLaunchDumpToolAppUsingNotification):
241         (openIPhoneSimulator):
242         (quitIPhoneSimulator):
243         quit iOS Simulator, not iPhone Simulator.
244
245 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
246
247         REGRESSION(r168471): Update the builder names on the scheduler list.
248         https://bugs.webkit.org/show_bug.cgi?id=132699
249
250         Reviewed by Martin Robinson.
251
252         On r168471 I missed to update the builder names for the GTK build
253         bots on the AnyBranchScheduler type scheduler list of bots.
254
255         * BuildSlaveSupport/build.webkit.org-config/config.json:
256
257 2014-05-08  Brady Eidson  <beidson@apple.com>
258
259         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
260         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
261
262         Reviewed by Tim Horton.
263
264         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
265         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
266
267 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
268
269         REGRESSION(r168471): Duplicate builddirs broke the build master.
270         https://bugs.webkit.org/show_bug.cgi?id=132688
271
272         Reviewed by Carlos Garcia Campos.
273
274         Rename the builddirs of the new GTK bots introduced on r168471 to
275         be unique. Otherwise the master will break.
276
277         * BuildSlaveSupport/build.webkit.org-config/config.json:
278
279 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
280
281         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
282         https://bugs.webkit.org/show_bug.cgi?id=132674
283
284         Reviewed by Philippe Normand.
285
286         Only ignore mkdir failure when exception is raised because the
287         file already exists and it's a directory.
288
289         * gtk/webkitdom.py:
290         (write_doc_files):
291
292 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
293
294         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
295         https://bugs.webkit.org/show_bug.cgi?id=131358
296
297         Reviewed by Carlos Garcia Campos.
298
299         Current 64-bit GTK build bots (Release and Debug) not only test
300         the build, but run all tests. Split each one of the bots in
301         BuildOnly and TestWebKit2.
302
303         This will allow us to have a better overview of the status of
304         the GTK port.
305
306         Original patch from Sergio Villar Senin <svillar@igalia.com>
307
308         * BuildSlaveSupport/build.webkit.org-config/config.json:
309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
311         (WebKitBuildbot):
312         * Scripts/webkitpy/port/builders.py:
313         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
314         (TestRebaselineTest.test_baseline_directory):
315         * TestResultServer/static-dashboards/builders.jsonp:
316         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
317         (resetGlobals):
318         * TestResultServer/static-dashboards/loader_unittests.js:
319
320 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
321
322         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
323         https://bugs.webkit.org/show_bug.cgi?id=126022
324
325         Reviewed by Benjamin Poulain.
326
327         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
328
329         Added an unit test case to check if scroll position and scale are restored properly.
330
331         * TestWebKitAPI/PlatformEfl.cmake:
332         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
333         (TestWebKitAPI::didFinishLoadForFrame):
334         (TestWebKitAPI::didChangeContentsPosition):
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
337         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
338
339 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
340
341         WebKit1 is flashy when compositing layers come and go
342         https://bugs.webkit.org/show_bug.cgi?id=132655
343         <rdar://problem/16830981&16788846>
344
345         Reviewed by Sam Weinig.
346         
347         Revert the change from r166117.
348
349         * DumpRenderTree/mac/DumpRenderTree.mm:
350         (updateDisplay):
351
352 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
353
354         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
355         https://bugs.webkit.org/show_bug.cgi?id=132622
356
357         Reviewed by Mario Sanchez Prada.
358
359         * DumpRenderTree/AccessibilityUIElement.cpp:
360         (selectTextWithCriteriaCallback):
361         (isEqualCallback):
362         * DumpRenderTree/AccessibilityUIElement.h:
363         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
364         (AccessibilityUIElement::selectTextWithCriteria):
365         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
366         (AccessibilityUIElement::selectTextWithCriteria):
367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
368         (selectTextParameterizedAttributeForCriteria):
369         (AccessibilityUIElement::selectTextWithCriteria):
370         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
371         (AccessibilityUIElement::selectTextWithCriteria):
372         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
373         (WTR::AccessibilityUIElement::selectTextWithCriteria):
374         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
375         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
376         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
377         (WTR::AccessibilityUIElement::selectTextWithCriteria):
378         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
379         (WTR::AccessibilityUIElement::selectTextWithCriteria):
380         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
381         (WTR::selectTextParameterizedAttributeForCriteria):
382         (WTR::AccessibilityUIElement::selectTextWithCriteria):
383
384 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
385
386         [SOUP] TLSErrors do not cause page load to fail when not ignored
387         https://bugs.webkit.org/show_bug.cgi?id=121548
388
389         Reviewed by Sergio Villar Senin.
390
391         Add unit tests to check that the load fails with TLS errors in
392         case of a redirection.
393
394         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
395         (testTLSErrorsRedirect):
396         (httpsServerCallback):
397         (beforeAll):
398
399 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
400
401         [CSS Grid Layout] Remove runtime feature
402         https://bugs.webkit.org/show_bug.cgi?id=132382
403
404         Reviewed by Benjamin Poulain.
405
406         Remove cssGridLayoutEnabled setting usage.
407
408         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
409         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
410         * DumpRenderTree/efl/TestRunnerEfl.cpp:
411         (TestRunner::overridePreference):
412         * DumpRenderTree/mac/DumpRenderTree.mm:
413         (resetWebPreferencesToConsistentValues):
414
415 2014-05-06  David Kilzer  <ddkilzer@apple.com>
416
417         Add Makefile targets for copying static libraries (LLVM and WKSI)
418         <http://webkit.org/b/132619>
419
420         Reviewed by Mark Rowe.
421
422         * Scripts/copy-webkitlibraries-to-product-directory: Set a
423         sensible default for product directory if not specified on
424         either the command-line or in the environment (by Xcode) by
425         calling productDir() in webkitdirs.pm.
426
427 2014-05-06  Brady Eidson  <beidson@apple.com>
428
429         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
430         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
431
432         Reviewed by Sam Weinig.
433
434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
435
436         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
437         (TestWebKitAPI::itemURLLastComponentIsString):
438         (TestWebKitAPI::didFinishLoadForFrame):
439         (TestWebKitAPI::willGoToBackForwardListItem):
440         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
441         (TestWebKitAPI::setPageLoaderClient):
442         (TestWebKitAPI::TEST):
443         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
444         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
445
446         * WebKitTestRunner/TestController.cpp:
447         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
448
449 2014-05-06  Darin Adler  <darin@apple.com>
450
451         Try to fix iOS build.
452
453         * DumpRenderTree/mac/TestRunnerMac.mm:
454         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
455         Updated since I changed testRunner into a pointer instead of a reference.
456         Updated argument names to avoid conflict with field names.
457         (-[APITestDelegateIPhone run]): Ditto.
458         (-[APITestDelegateIPhone _cleanUp]): Ditto.
459
460 2014-05-06  Commit Queue  <commit-queue@webkit.org>
461
462         Unreviewed, rolling out r168304.
463         https://bugs.webkit.org/show_bug.cgi?id=132607
464
465         Broke the build (Requested by KaL on #webkit).
466
467         Reverted changeset:
468
469         "[GTK][CMake] Unable to do make install"
470         https://bugs.webkit.org/show_bug.cgi?id=130188
471         http://trac.webkit.org/changeset/168304
472
473 2014-05-04  Darin Adler  <darin@apple.com>
474
475         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
476         https://bugs.webkit.org/show_bug.cgi?id=80222
477
478         Reviewed by Alexey Proskuryakov.
479
480         * DumpRenderTree/mac/TestRunnerMac.mm:
481         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
482         do more work here so we don't use RetainPtr local variables.
483         (-[APITestDelegateIPhone dealloc]): Added.
484         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
485         created. Updated for changes to member names and types.
486         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
487         updated for changes to member names and types. Changed to two word spelling.
488         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
489         name of _cleanUp method.
490         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
491         Ditto.
492         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
493
494 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
495
496         Clean up Image Document and tweak the layout and viewport
497         https://bugs.webkit.org/show_bug.cgi?id=132552
498
499         Reviewed by Anders Carlsson.
500
501         * DumpRenderTree/mac/DumpRenderTree.mm:
502         (resetWebPreferencesToConsistentValues):
503         Update the default settings to have something consistent with WebKit2.
504
505 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
506
507         [GTK][CMake] Unable to do make install
508         https://bugs.webkit.org/show_bug.cgi?id=130188
509
510         Reviewed by Carlos Garcia Campos.
511
512         * Scripts/webkitdirs.pm:
513         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
514         will give an early signal that a change has broken the documentation.
515
516 2014-05-05  Pratik Solanki  <psolanki@apple.com>
517
518         Update framework locations in package-root
519         https://bugs.webkit.org/show_bug.cgi?id=132571
520
521         Reviewed by Simon Fraser.
522
523         * Scripts/package-root:
524
525 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
526
527         [EFL][WK2] Refactor favicon database APIs
528         https://bugs.webkit.org/show_bug.cgi?id=132519
529
530         Reviewed by Gyuyoung Kim.
531
532         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
533         (update_view_favicon):
534         (on_icon_changed_cb):
535         (window_free):
536         (on_url_changed):
537         (window_create):
538         (on_view_favicon_changed): Deleted.
539
540 2014-05-02  Mark Rowe  <mrowe@apple.com>
541
542         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
543
544         Reviewed by Dan Bernstein.
545
546         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
547         when determining which LLVM archive to extract.
548
549 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
550
551         Add Jeremy as a committer.
552         https://bugs.webkit.org/show_bug.cgi?id=132492
553
554         Reviewed by Jer Noble.
555
556         Add myself as a committer.
557
558         * Scripts/webkitpy/common/config/contributors.json:
559
560 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
561
562         Add Jeremy as a committer.
563         https://bugs.webkit.org/show_bug.cgi?id=132492
564
565         Reviewed by Jer Noble.
566
567         Add Jeremy Jones to the committers file.
568
569         * Scripts/webkitpy/common/config/contributors.json:
570
571 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
572
573         Hard to figure out how to run a single test with run-api-tests
574         https://bugs.webkit.org/show_bug.cgi?id=116332
575
576         Reviewed by Alexey Proskuryakov.
577
578         * Scripts/run-api-tests: add two examples to the help message.
579
580 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
581
582         Fix several memory leaks found by code inspection
583         https://bugs.webkit.org/show_bug.cgi?id=132472
584
585         Reviewed by Geoffrey Garen.
586         
587         Fix memory leaks.
588
589         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
590         (TestWebKitAPI::TEST):
591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
592         (WTR::InjectedBundlePage::willSendRequestForFrame):
593         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
594         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
595
596 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
597
598         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
599         https://bugs.webkit.org/show_bug.cgi?id=132446
600
601         Reviewed by Mark Hahnenberg.
602         
603         Test the FTL by default now that it's enabled by default.
604
605         * Scripts/run-javascriptcore-tests:
606
607 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
608
609         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
610         https://bugs.webkit.org/show_bug.cgi?id=132240
611
612         Reviewed by Anders Carlsson.
613
614         Removed ewk_view_setting_tiled_backingstore related code.
615
616         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
617         (DumpRenderTreeChrome::createView):
618         (shouldUseTiledBackingStore): Deleted.
619         * EWebLauncher/main.c:
620         (windowCreate):
621         (parseUserArguments):
622
623 2014-05-01  Anders Carlsson  <andersca@apple.com>
624
625         window.testRunner.keepWebHistory() should update the UI process state
626         https://bugs.webkit.org/show_bug.cgi?id=132440
627
628         Reviewed by Dan Bernstein.
629
630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
631         (WTR::InjectedBundle::postSetAddsVisitedLinks):
632         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
634         (WTR::TestRunner::keepWebHistory):
635         * WebKitTestRunner/TestInvocation.cpp:
636         (WTR::TestInvocation::invoke):
637         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
638
639 2014-05-01  David Kilzer  <ddkilzer@apple.com>
640
641         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
642         <http://webkit.org/b/132432>
643
644         Reviewed by Tim Horton.
645
646         * Scripts/webkitperl/FeatureList.pm: Remove support for
647         --plugin-proxy-for-video switch.
648
649 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
650
651         Kernel sysctl interface hw.activecpu don't exists on Linux.
652         https://bugs.webkit.org/show_bug.cgi?id=132286
653
654         Reviewed by Filip Pizlo.
655
656         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
657         calling sysctl over hw.activecpu
658
659 2014-04-30  Anders Carlsson  <andersca@apple.com>
660
661         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
662         https://bugs.webkit.org/show_bug.cgi?id=132399
663         <rdar://problem/15920046>
664
665         Reviewed by Dan Bernstein.
666
667         * Scripts/check-for-webkit-framework-include-consistency:
668         Allos WAK headers in WebKitLegacy as well as WebKit.
669
670         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
671         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
672         Update header imports.
673
674 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
675
676         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
677         https://bugs.webkit.org/show_bug.cgi?id=131954
678
679         Reviewed by Darin Adler.
680         
681         WebKitTestRunner was adding application-specific information to crash reports
682         to log the test path, but only in the web process. Fix it to also do this
683         for the UI process, for both iOS and OS X.
684         
685         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
686         both iOS and OS X.
687         
688         Factored crash reprorter-related code into CrashReporterInfo, and call it from
689         a new TestController::platformWillRunTest() function on Mac and iOS.
690         
691         Also remove Xcode-added unit test junk from the project.
692
693         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
694         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
695         * WebKitTestRunner/TestController.cpp:
696         (WTR::TestController::runTest):
697         * WebKitTestRunner/TestController.h:
698         * WebKitTestRunner/TestInvocation.cpp:
699         (WTR::TestInvocation::url):
700         * WebKitTestRunner/TestInvocation.h:
701         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
702         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
703         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
704         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
705         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
706         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
707         (WTR::testPathFromURL):
708         (WTR::setCrashReportApplicationSpecificInformationToURL):
709         * WebKitTestRunner/efl/TestControllerEfl.cpp:
710         (WTR::TestController::platformWillRunTest):
711         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
712         (WTR::TestController::platformWillRunTest):
713         * WebKitTestRunner/ios/TestControllerIOS.mm:
714         (WTR::TestController::platformWillRunTest):
715         (WTR::TestController::setHidden):
716         * WebKitTestRunner/mac/TestControllerMac.mm:
717         (WTR::TestController::platformWillRunTest):
718
719 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
720
721         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
722
723         Reviewed by Tim Horton.
724
725         * DumpRenderTree/mac/DumpRenderTree.mm:
726         (resetWebPreferencesToConsistentValues):
727         (prepareConsistentTestingEnvironment):
728
729 2014-04-30  Anders Carlsson  <andersca@apple.com>
730
731         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
732         https://bugs.webkit.org/show_bug.cgi?id=132397
733
734         Reviewed by Dan Bernstein.
735
736         * Scripts/check-for-inappropriate-macros-in-external-headers:
737
738 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
739
740         [GTK] Make it easier to run CMake for downstreams
741         https://bugs.webkit.org/show_bug.cgi?id=132370
742
743         Reviewed by Carlos Garcia Campos.
744
745         * Scripts/webkitdirs.pm:
746         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
747         the GTK+ port.
748
749 2014-04-29  Stephanie Lewis  <slewis@apple.com>
750
751         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
752         
753         Rubber stamped by Jessie Berlin.
754
755         JSON.pm was removed from our tools setup.
756
757         * Scripts/generate-coverage-data:
758
759 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
760
761         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
762         https://bugs.webkit.org/show_bug.cgi?id=112840
763
764         Rubber stamped by Geoffrey Garen.
765
766         * Scripts/build-jsc: Enable it on Mac.
767         * Scripts/build-webkit: Enable it on Mac.
768         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
769
770 2014-04-28  Sam Weinig  <sam@webkit.org>
771
772         REGRESSION (r167751): svn-create-patch is very slow
773         https://bugs.webkit.org/show_bug.cgi?id=132300
774
775         Reviewed by Alexey Proskuryakov.
776
777         * Scripts/svn-create-patch:
778         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
779         by calling `svn-create-patch --style`.
780
781 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
782
783         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
784         https://bugs.webkit.org/show_bug.cgi?id=132190
785
786         Reviewed by Gustavo Noronha Silva.
787
788         * Scripts/webkitdirs.pm:
789         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
790             if ninja is in the path.
791         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
792             to the previous ninja generator if not.
793
794 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
795
796         check-webkit-style should understand --git-index
797         https://bugs.webkit.org/show_bug.cgi?id=125364
798
799         Reviewed by Csaba Osztrogonác.
800
801         * Scripts/webkitpy/common/checkout/scm/git.py:
802         (Git.create_patch): The command now supports the --cached option.
803         * Scripts/webkitpy/style/main.py:
804         (CheckWebKitStyle.main): Passing the --git-index option.
805         * Scripts/webkitpy/style/optparser.py:
806         (CommandOptionValues.__init__): The git-index option is switched off by default.
807         (CommandOptionValues.__eq__): Equality check for the new option.
808         (ArgumentParser._create_option_parser):Adding the --git-index option
809         (ArgumentParser.parse):
810         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
811         (CommandOptionValuesTest.test_init): 
812         (CommandOptionValuesTest.test_eq):
813
814 2014-04-28  Michael Saboff  <msaboff@apple.com>
815
816         Crash in platform/mac/accessibility/table-visible-rows.html
817         https://bugs.webkit.org/show_bug.cgi?id=132146
818
819         Reviewed by Filip Pizlo.
820
821         Instead of creating a local JSValueRef array on the stack and passing that to
822         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
823         values using the JSObjectSetPropertyAtIndex() API.
824
825         * DumpRenderTree/AccessibilityUIElement.cpp:
826         (elementsForRangeCallback):
827         (convertElementsToObjectArray):
828         * DumpRenderTree/mac/TestRunnerMac.mm:
829         (originsArrayToJS):
830         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
831         (WTR::EventSendingController::contextClick):
832         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
833         (WTR::stringArrayToJS):
834         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
835         (WTR::convertElementsToObjectArray):
836
837 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
838
839         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
840         "no-cjit" runs force the old-school threshold.
841
842         Rubber stamped by Mark Hahnenberg.
843
844         * Scripts/run-jsc-stress-tests:
845
846 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
847
848         [GTK] install-dependencies should also install ruby-json and ruby-highline
849         https://bugs.webkit.org/show_bug.cgi?id=132292
850
851         Reviewed by Philippe Normand.
852
853         * gtk/install-dependencies: Install ruby json and highline packages.
854
855 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
856
857         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
858         https://bugs.webkit.org/show_bug.cgi?id=132176
859
860         Reviewed by Gyuyoung Kim.
861
862         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
863         and turn off indexedDB feature until the sqlite implementation is introduced.
864
865         * Scripts/webkitperl/FeatureList.pm:
866
867 2014-04-25  James Craig  <jcraig@apple.com>
868
869         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
870         https://bugs.webkit.org/show_bug.cgi?id=132209
871
872         Reviewed by Daniel Bates.
873
874         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
875         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
876
877         * Scripts/prepare-ChangeLog:
878         (main): 
879
880 2014-04-25  Michael Saboff  <msaboff@apple.com>
881
882         Crash in platform/mac/accessibility/table-visible-rows.html
883         https://bugs.webkit.org/show_bug.cgi?id=132146
884
885         Reviewed by Mark Lam.
886
887         Changed to use a local JSValueRef array temporary instead of a
888         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
889         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
890         the temporary values could be collected.
891
892         * DumpRenderTree/AccessibilityUIElement.cpp:
893         (convertElementsToObjectArray):
894         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
895         (WTR::EventSendingController::contextClick):
896         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
897         (WTR::convertElementsToObjectArray):
898
899 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
900
901         Unreviewed GTK gardening
902
903         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
904         (TestRunner):
905
906 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
907
908         prepare-ChangeLog reports as deleted methods that has not been removed.
909         https://bugs.webkit.org/show_bug.cgi?id=131733
910
911         Reviewed by Ryosuke Niwa.
912
913         * Scripts/prepare-ChangeLog:
914         (originalFile): Set merge base to origin/master by default.
915
916 2014-04-23  James Craig  <jcraig@apple.com>
917
918         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
919         https://bugs.webkit.org/show_bug.cgi?id=131115
920
921         Reviewed by Daniel Bates.
922
923         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
924
925         * Scripts/commit-log-editor: Added --no-style.
926         * Scripts/prepare-ChangeLog: Primary patch.
927         (main): Primary patch.
928         (createPatchCommand): Added --no-style.
929         * Scripts/svn-create-patch: Primary patch.
930         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
931         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
932         (SVN.create_patch): Added --no-style.
933
934 2014-04-23  Anders Carlsson  <andersca@apple.com>
935
936         Try to fix iOS build.
937
938         * DumpRenderTree/mac/DumpRenderTree.mm:
939
940 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
941
942         Eliminate internals.setMockScrollbarsEnabled()
943         https://bugs.webkit.org/show_bug.cgi?id=132085
944
945         Reviewed by Tim Horton.
946
947         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
948         No need to reset the preference, there is no way it can change.
949
950 2014-04-23  James Craig  <jcraig@apple.com>
951
952         Unreviewed. Moving myself from Contributors to Committers list.
953
954         * Scripts/webkitpy/common/config/contributors.json:
955
956 2014-04-23  Tim Horton  <timothy_horton@apple.com>
957
958         Mock scrollbars don't always work in DumpRenderTree
959         https://bugs.webkit.org/show_bug.cgi?id=132082
960
961         Reviewed by Alexey Proskuryakov.
962
963         * DumpRenderTree/mac/DumpRenderTree.mm:
964         (prepareConsistentTestingEnvironment):
965         Set the mock scrollbar setting before creating the WebView, as this setting
966         cannot be dynamically changed, so any scrollbars that are created during
967         WebView initialization and are not replaced before snapshotting will end
968         up being platform scrollbars instead of mock ones.
969         WebKitTestRunner already sets this preference before creating WKViews,
970         so we're just matching its behavior.
971
972 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
973
974         [GTK] ShadowRoot API was removed in r164131
975         https://bugs.webkit.org/show_bug.cgi?id=132059
976
977         Reviewed by Gustavo Noronha Silva.
978
979         Add WebKitDOMShadowRoot to the list of deleted classes to generate
980         the API docs.
981
982         * gtk/webkitdom.py:
983         (WebKitDOMDocGenerator):
984
985 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
986
987         [GTK] run-webkit-tests script is failing to invoke run-launcher
988         https://bugs.webkit.org/show_bug.cgi?id=132051
989
990         Reviewed by Philippe Normand.
991
992         After the WK1 support was dropped, if run-webkit-tests is executed
993         without --no-show-results parameter, the launcher is being called
994         using a -2 parameter that is it causing the run-launcher to break.
995
996         * Scripts/webkitpy/port/gtk.py:
997         (GtkPort.show_results_html_file):
998
999 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1000
1001         DumpRenderTree generates black snapshots on some platforms
1002         https://bugs.webkit.org/show_bug.cgi?id=132029
1003         <rdar://problem/16679363>
1004
1005         Reviewed by Simon Fraser.
1006
1007         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1008         (createBitmapContextFromWebView):
1009         DRT checks with the WebView to determine whether it can use the window's
1010         backing store directly or (because of compositing) needs to take a WindowServer
1011         snapshot. However, on some platforms and in some situations, the window can
1012         be layer backed without the WebView necessarily currently being composited.
1013         We should check with the window in addition to the WebView before going
1014         ahead and using its backing store.
1015
1016 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1017
1018         DumpRenderTree generates white snapshots on some platforms
1019         https://bugs.webkit.org/show_bug.cgi?id=132026
1020         <rdar://problem/16679363>
1021
1022         Reviewed by Simon Fraser.
1023
1024         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1025         Link DRT against QuartzCore.
1026
1027         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1028         (createBitmapContextFromWebView):
1029         Force CoreAnimation to synchronously update layers in a more explicit
1030         way that doesn't depend on AppKit behavior. This is very similar to what
1031         WebKitTestRunner does (indirectly) during its force repaint.
1032
1033 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1034
1035         [Win] Support Python 2.7 in Cygwin
1036         https://bugs.webkit.org/show_bug.cgi?id=132023
1037
1038         Reviewed by Michael Saboff.
1039
1040         * Scripts/webkitdirs.pm:
1041         (checkInstalledTools): Remove check for Python 2.7, since
1042         it now works properly.
1043
1044 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1045
1046         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1047         https://bugs.webkit.org/show_bug.cgi?id=130867
1048         <rdar://problem/16432456> 
1049
1050         Reviewed by Mark Hahnenberg.
1051
1052         * Scripts/build-webkit:
1053         * Scripts/copy-webkitlibraries-to-product-directory:
1054
1055 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1056
1057         [GTK] Fails to build documentation when output is redirected
1058         https://bugs.webkit.org/show_bug.cgi?id=131178
1059
1060         Reviewed by Martin Robinson.
1061
1062         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1063         explicitly to avoid encoding issues when they are redirected.
1064
1065 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1066
1067         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1068         https://bugs.webkit.org/show_bug.cgi?id=131911
1069
1070         Reviewed by Martin Robinson.
1071
1072         common.get_build_path returns release path even though Debug configuration
1073         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1074
1075         * gtk/ycm_extra_conf.py:
1076         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1077         (FlagsForFile):
1078
1079 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1080
1081         Unreviewed build fix.
1082
1083         * DumpRenderTree/mac/EventSendingController.mm:
1084         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1085         Correct a typo that prevented tests from working properly.
1086
1087 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1088
1089         [GTK] Should have the ability to output composited contents during layout testing
1090         https://bugs.webkit.org/show_bug.cgi?id=131864
1091
1092         Reviewed by Philippe Normand.
1093
1094         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1095         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1096         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1097         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1098         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1099
1100 2014-04-21  Sam Weinig  <sam@webkit.org>
1101
1102         Attempt to fix the tests.
1103
1104         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1105         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1106         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1107
1108 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1109
1110         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1111         being the same as a "quick run", which is meant for genuinely slow tests).
1112
1113         * Scripts/run-jsc-stress-tests:
1114
1115 2014-04-21  Darin Adler  <darin@apple.com>
1116
1117         Add HashSet::takeAny
1118         https://bugs.webkit.org/show_bug.cgi?id=131928
1119
1120         Reviewed by Benjamin Poulain.
1121
1122         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1123
1124 2014-04-20  Dan Bernstein  <mitz@apple.com>
1125
1126         Fixed a test timing out after r167572.
1127
1128         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1129         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1130         -webView:didFinishLoadingNavigation:.
1131
1132 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1133
1134         Unreviewed, rolling out r167510.
1135         https://bugs.webkit.org/show_bug.cgi?id=131915
1136
1137         broke GTK Debug bot (Requested by philn on #webkit).
1138
1139         Reverted changeset:
1140
1141         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1142         it when running layout tests"
1143         https://bugs.webkit.org/show_bug.cgi?id=131472
1144         http://trac.webkit.org/changeset/167510
1145
1146 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1147
1148         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1149         https://bugs.webkit.org/show_bug.cgi?id=131472
1150
1151         Reviewed by Philippe Normand.
1152
1153         * Scripts/webkitpy/port/gtk.py:
1154         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1155         when running WebKitTestRunner with run-webkit-tests.
1156         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1157         installed.
1158         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1159         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1160         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1161         deal.
1162
1163 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1164
1165         DownloadDecideDestinationCrash API test uses an incorrect value for path
1166         https://bugs.webkit.org/show_bug.cgi?id=131845
1167         <rdar://problem/15925560>
1168
1169         Reviewed by Enrica Casucci.
1170
1171         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1172         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1173
1174 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1175
1176         [Mac] AttributedStringTest API tests fail with async text input
1177         https://bugs.webkit.org/show_bug.cgi?id=131833
1178
1179         Reviewed by Enrica Casucci.
1180
1181         Don't run sync NSTextInputClient tests where we don't implement these calls.
1182
1183         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1184         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1185         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1186         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1187         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1188         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1189         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1190
1191 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1192
1193         Remove NETWORK_INFO support
1194         https://bugs.webkit.org/show_bug.cgi?id=131841
1195
1196         Reviewed by Gyuyoung Kim.
1197
1198         * Scripts/webkitperl/FeatureList.pm:
1199
1200 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1201
1202         [GTK] YouCompleteMe doesn't work for cmake build system.
1203         https://bugs.webkit.org/show_bug.cgi?id=131591
1204
1205         Reviewed by Martin Robinson.
1206
1207         Add cmake build system support for YouCompleteMe. It should work regardless of
1208         using make or ninja. In addition, autotools related code is removed since it's
1209         not used anymore in WebKit.
1210
1211         * Scripts/webkitdirs.pm:
1212         (generateBuildSystemFromCMakeProject):
1213         * gtk/ycm_extra_conf.py:
1214         (transform_relative_paths_to_absolute_paths):
1215         (FlagsForFile):
1216
1217 2014-04-17  Anders Carlsson  <andersca@apple.com>
1218
1219         Fix build.
1220
1221         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1222         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1223         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1224
1225 2014-04-17  Anders Carlsson  <andersca@apple.com>
1226
1227         Remove unused API enums
1228         https://bugs.webkit.org/show_bug.cgi?id=131836
1229
1230         Reviewed by Tim Horton.
1231
1232         * MiniBrowser/mac/WK2BrowserWindowController.m:
1233         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1234
1235 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1236
1237         [Win] A few final cleanups to the DataObject classes.
1238         https://bugs.webkit.org/show_bug.cgi?id=131784
1239
1240         Reviewed by Anders Carlsson.
1241
1242         * DumpRenderTree/win/DRTDataObject.cpp:
1243         (DRTDataObject::clearData): Use 'last()' method.
1244         * DumpRenderTree/win/UIDelegate.cpp:
1245         (DRTUndoStack::pop): Use 'takeLast()' method.
1246
1247 2014-04-17  Andres Gomez  <agomez@igalia.com>
1248
1249         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1250         https://bugs.webkit.org/show_bug.cgi?id=131365
1251
1252         Reviewed by Brent Fulgham.
1253
1254         The cygwin installer is now downloading the wanted versions for
1255         the local installation given to the setup wizard.
1256
1257         * CygwinDownloader/cygwin-downloader.py:
1258         * CygwinDownloader/cygwin-downloader.zip:
1259
1260 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1261
1262         [GTK] Make run-webkit-tests always use WKTR
1263         https://bugs.webkit.org/show_bug.cgi?id=131737
1264
1265         Reviewed by Darin Adler.
1266
1267         Now that the GTK+ port only has support for WebKit2, instruct
1268         run-webkit-tests to always use WKTR. This avoids needing to pass
1269         flag "-2" every time.
1270
1271         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1272         (_set_up_derived_options): Always set webkit_test_runner when
1273         the platform is GTK+.
1274
1275 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1276
1277         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1278         https://bugs.webkit.org/show_bug.cgi?id=131760
1279
1280         Reviewed by Philippe Normand.
1281
1282         * gtk/install-dependencies: Install ninja-build when it's available.
1283
1284 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1285
1286         [Win] run-javascriptcore-tests fails to run.
1287         https://bugs.webkit.org/show_bug.cgi?id=131761
1288
1289         Reviewed by Brent Fulgham.
1290
1291         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1292
1293 2014-04-16  Andres Gomez  <agomez@igalia.com>
1294
1295         [Win] Pass default parameters to cygwin setup wizard
1296         https://bugs.webkit.org/show_bug.cgi?id=131361
1297
1298         Reviewed by Brent Fulgham.
1299
1300         Added some parameters to the cygwin setup wizard so the user
1301         doesn't really have to do any interaction.
1302
1303         * CygwinDownloader/cygwin-downloader.py:
1304         * CygwinDownloader/cygwin-downloader.zip:
1305
1306 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1307
1308         [Win] Eliminate use of deleteAllValues in Windows Files
1309         https://bugs.webkit.org/show_bug.cgi?id=131631
1310
1311         Reviewed by Darin Adler.
1312
1313         Switch to std::unique_ptr for memory lifetime. Get rid of
1314         deleteAllValues now that it is no longer needed. Use ranged
1315         for loops where possible.
1316
1317         * DumpRenderTree/win/DRTDataObject.cpp:
1318         (WCEnumFormatEtc::WCEnumFormatEtc):
1319         (DRTDataObject::~DRTDataObject):
1320         (DRTDataObject::GetData):
1321         (DRTDataObject::QueryGetData):
1322         (DRTDataObject::SetData):
1323         (DRTDataObject::clearData):
1324         * DumpRenderTree/win/DRTDataObject.h:
1325         * DumpRenderTree/win/UIDelegate.cpp:
1326         (DRTUndoObject::DRTUndoObject):
1327         (DRTUndoObject::~DRTUndoObject):
1328         (DRTUndoStack::~DRTUndoStack):
1329         (DRTUndoStack::clear):
1330         (DRTUndoStack::pop):
1331         (DRTUndoManager::DRTUndoManager):
1332         (DRTUndoManager::redo):
1333         (DRTUndoManager::undo):
1334         (UIDelegate::UIDelegate):
1335         (UIDelegate::resetUndoManager):
1336         * DumpRenderTree/win/UIDelegate.h:
1337
1338 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1339
1340         [GTK] Unreviewed GTK gardening.
1341
1342         Update list of skipped unit tests:
1343
1344           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1345
1346           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1347           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1348
1349         * Scripts/run-gtk-tests:
1350         (TestRunner):
1351
1352 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1353
1354         check-webkit-style doesn't check code style in .mm or .m files
1355         https://bugs.webkit.org/show_bug.cgi?id=131708
1356
1357         Reviewed by Darin Adler.
1358
1359         * Scripts/webkitpy/style/checker.py:
1360         * Scripts/webkitpy/style/checker_unittest.py:
1361         (CheckerDispatcherDispatchTest.test_cpp_paths):
1362         (CheckerDispatcherDispatchTest.test_text_paths):
1363         Check .mm and .m files as C++.
1364
1365         * Scripts/webkitpy/style/checkers/cpp.py:
1366         (check_spacing):
1367         Add an override for our ordinary "missing spaces around =" for @synthesize,
1368         which should look like "@synthesize propertyName=_varName;"
1369
1370         Add an override for "missing space before {" for blocks' "^{".
1371
1372         Don't follow the "extra space before [" rule for Objective-C, because
1373         it breaks this rule in a multitude of ways because of method calls.
1374
1375         (check_braces):
1376         Don't complain about { not being on the end of the previous line if
1377         the previous line starts with "- (" or "+ (", which would indicate a
1378         Objective-C method definition.
1379
1380 2014-04-16  Darin Adler  <darin@apple.com>
1381
1382         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1383         https://bugs.webkit.org/show_bug.cgi?id=131735
1384
1385         Reviewed by Alexey Proskuryakov.
1386
1387         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1388         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1389         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1390         way, but gtest works better this way.
1391
1392 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1393
1394         [EFL] Fix problems with the pixel dump.
1395         https://bugs.webkit.org/show_bug.cgi?id=131265
1396
1397         Reviewed by Gyuyoung Kim.
1398
1399         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1400         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1401         which causes that nothing is drawn.
1402
1403         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1404         One of new functions is AcceleratedCompositingContext::extractImageData(),
1405         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1406         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1407
1408         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1409         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1410
1411 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1412
1413         Update LLVM export scrpt to handle the build directory being different from the
1414         source directory.
1415
1416         Rubber stamped by Geoffrey Garen.
1417
1418         * Scripts/export-llvm-build:
1419
1420 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1421
1422         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1423         https://bugs.webkit.org/show_bug.cgi?id=131695
1424
1425         Reviewed by Antti Koivisto.
1426
1427         Updated.
1428
1429         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1430
1431 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1432
1433         [GTK] Reduce the binary size by compressing the text based web inspector resources
1434         https://bugs.webkit.org/show_bug.cgi?id=121545
1435
1436         Reviewed by Gustavo Noronha Silva.
1437
1438         Compress text based files when compiling inspector resources. It
1439         reduces the binary size in 3MB.
1440
1441         * gtk/generate-inspector-gresource-manifest.py:
1442         (find_all_files_in_directory):
1443         (is_compressible):
1444
1445 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1446
1447         Remove Gtk WebKit1 tester.
1448
1449         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1450         results over and over as fast as it could.
1451
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1453         (WebKitBuildbot):
1454
1455 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1456
1457         Wrong link for webkitpy tests results in dashboard popover
1458         https://bugs.webkit.org/show_bug.cgi?id=131664
1459
1460         Reviewed by Timothy Hatcher.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1463         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1464         Use a correct link.
1465
1466 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1467
1468         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1469
1470         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1471
1472         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1473         (CommitMessageForThisCommitTest):
1474
1475 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1476
1477         Fix commit-log-editor bug revealed by r165447
1478         https://bugs.webkit.org/show_bug.cgi?id=130676
1479
1480         Reviewed by Csaba Osztrogonác.
1481
1482         * Scripts/commit-log-editor:
1483         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1484         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1485         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1486         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1487
1488 2014-04-13  Darin Adler  <darin@apple.com>
1489
1490         userVisibleString should not try to "encode" host names
1491         https://bugs.webkit.org/show_bug.cgi?id=131587
1492         rdar://problem/14686849
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1497
1498         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1499         Coverage is tiny at this point; we could add a lot more cases!
1500
1501 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1502
1503         Use #include instead of #import
1504         https://bugs.webkit.org/show_bug.cgi?id=131604
1505
1506         Reviewed by Darin Adler.
1507
1508         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1509
1510         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1511
1512 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1513
1514         Make slow-stress tests run faster by running fewer VM variants.
1515
1516         Rubber stamped by Geoffrey Garen.
1517
1518         * Scripts/run-javascriptcore-tests:
1519         * Scripts/run-jsc-stress-tests:
1520
1521 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1522
1523         [CMake] Add missing WTF unit tests
1524         https://bugs.webkit.org/show_bug.cgi?id=131459
1525
1526         Reviewed by Martin Robinson.
1527
1528         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1529         that should be compiled into the TestWTF binary.
1530
1531 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1532
1533         [Gtk] run-launcher doesn't work by default
1534         https://bugs.webkit.org/show_bug.cgi?id=131494
1535
1536         Reviewed by Philippe Normand.
1537
1538         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1539         * Scripts/webkitdirs.pm:
1540         (launcherName): Same.
1541         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1542         * gtk/common.py:
1543         (get_build_path.is_valid_build_directory): Same.
1544         * gtk/manifest.txt: Same.
1545
1546 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1547
1548         Unreviewed, rolling out r167046.
1549         https://bugs.webkit.org/show_bug.cgi?id=131479
1550
1551         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1552         on #webkit).
1553
1554         Reverted changeset:
1555
1556         "Remove "System Font" from whitelisted DRT fonts and char
1557         width calculations"
1558         https://bugs.webkit.org/show_bug.cgi?id=131411
1559         http://trac.webkit.org/changeset/167046
1560
1561 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1562
1563         Remove "System Font" from whitelisted DRT fonts and char width calculations
1564         https://bugs.webkit.org/show_bug.cgi?id=131411
1565
1566         Reviewed by Tim Horton.
1567
1568         Covered by existing tests.
1569
1570         * DumpRenderTree/mac/DumpRenderTree.mm:
1571         (allowedFontFamilySet):
1572
1573 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1574
1575         systemHiddenFontFamilySet in DRT is unnecessary
1576         https://bugs.webkit.org/show_bug.cgi?id=131414
1577
1578         Reviewed by Tim Horton.
1579
1580         It doesn't seem to affect test results on my machine.
1581
1582         * DumpRenderTree/mac/DumpRenderTree.mm:
1583         (drt_NSFontManager_availableFonts):
1584         (systemHiddenFontFamilySet): Deleted.
1585
1586 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1587
1588         [Win] Unreviewed test fix: Don't double-release BSTR.
1589
1590         * DumpRenderTree/win/DumpRenderTree.cpp:
1591         (dump): Remove unneeded call to SysFreeString now that we are
1592         using _bstr_t for this variable.
1593
1594 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1595
1596         [Win] Various DumpRenderTree Fixes.
1597         https://bugs.webkit.org/show_bug.cgi?id=131446.
1598
1599         Reviewed by Tim Horton.
1600
1601         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1602         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1603         (AccessibilityUIElement::description): Ditto.
1604         (AccessibilityUIElement::helpText): Ditto.
1605         (AccessibilityUIElement::intValue): Ditto.
1606         (AccessibilityUIElement::isPressActionSupported): Ditto.
1607         (AccessibilityUIElement::accessibilityValue): Ditto.
1608         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1609         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1610         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1611         (DRTDesktopNotificationPresenter::Release): Ditto.
1612         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1613         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1614         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1615         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1616         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1617         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1618         * DumpRenderTree/win/DumpRenderTree.cpp:
1619         (dumpFrameScrollPosition): Ditto.
1620         (dumpFramesAsText): Ditto.
1621         (compareHistoryItems): Ditto.
1622         (dumpHistoryItem): Ditto.
1623         (dump): Ditto.
1624         (resetDefaultsToConsistentValues): Ditto.
1625         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1626         (runTest): Ditto.
1627         (createWebViewAndOffscreenWindow): Ditto.
1628         * DumpRenderTree/win/EditingDelegate.cpp:
1629         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1630         (EditingDelegate::AddRef): Ditto.
1631         (EditingDelegate::Release): Ditto.
1632         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1633         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1634         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1635         (EditingDelegate::shouldInsertNode): Ditto.
1636         (EditingDelegate::shouldInsertText): Ditto.
1637         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1638         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1639         (EditingDelegate::shouldApplyStyle): Ditto.
1640         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1641         (EditingDelegate::doPlatformCommand): Ditto.
1642         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1643         (EditingDelegate::webViewDidChange): Ditto.
1644         (EditingDelegate::webViewDidEndEditing): Ditto.
1645         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1646         (EditingDelegate::webViewDidChangeSelection): Ditto.
1647         (EditingDelegate::checkSpellingOfString): Ditto.
1648         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1649         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1650         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1651         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1652         (FrameLoadDelegate::AddRef): Ditto.
1653         (FrameLoadDelegate::Release): Ditto.
1654         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1655         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1656         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1657         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1658         (FrameLoadDelegate::didReceiveTitle): Ditto.
1659         (FrameLoadDelegate::didChangeIcons): Ditto.
1660         (delegatesWithDelayedWork): Ditto.
1661         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1662         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1663         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1664         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1665         (FrameLoadDelegate::willCloseFrame): Ditto.
1666         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1667         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1668         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1669         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1670         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1671         * DumpRenderTree/win/FrameLoadDelegate.h:
1672         * DumpRenderTree/win/HistoryDelegate.cpp:
1673         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1674         (HistoryDelegate::updateHistoryTitle): Ditto.
1675         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1676         * DumpRenderTree/win/PolicyDelegate.cpp:
1677         (dumpPath):
1678         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1679         (PolicyDelegate::AddRef): Ditto.
1680         (PolicyDelegate::Release): Ditto.
1681         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1682         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1683         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1684         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1685         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1686         (ResourceLoadDelegate::AddRef): Ditto.
1687         (ResourceLoadDelegate::Release): Ditto.
1688         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1689         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1690         (ResourceLoadDelegate::willSendRequest): Ditto.
1691         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1692         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1693         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1694         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1695         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1696         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1697         (TestRunner::setUserStyleSheetLocation): Ditto.
1698         (TestRunner::execCommand): Ditto.
1699         (TestRunner::overridePreference): Ditto.
1700         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1701         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1702         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1703         (TextInputController::insertText): Ditto.
1704         * DumpRenderTree/win/UIDelegate.cpp:
1705         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1706         (UIDelegate::AddRef): Ditto.
1707         (UIDelegate::Release): Ditto.
1708         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1709         (UIDelegate::trackCustomPopupMenu): Ditto.
1710         (UIDelegate::registerUndoWithTarget): Ditto.
1711         (UIDelegate::removeAllActionsWithTarget): Ditto.
1712         (UIDelegate::setActionTitle): Ditto.
1713         (UIDelegate::undo): Ditto.
1714         (UIDelegate::redo): Ditto.
1715         (UIDelegate::canUndo): Ditto.
1716         (UIDelegate::canRedo): Ditto.
1717         (UIDelegate::printFrame): Ditto.
1718         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1719         (UIDelegate::webViewHeaderHeight): Ditto.
1720         (UIDelegate::webViewFooterHeight): Ditto.
1721         (UIDelegate::drawHeaderInRect): Ditto.
1722         (UIDelegate::drawFooterInRect): Ditto.
1723         (UIDelegate::webViewPrintingMarginRect): Ditto.
1724         (UIDelegate::canRunModal): Ditto.
1725         (UIDelegate::createModalDialog): Ditto.
1726         (UIDelegate::runModal): Ditto.
1727         (UIDelegate::isMenuBarVisible): Ditto.
1728         (UIDelegate::setMenuBarVisible): Ditto.
1729         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1730         (UIDelegate::paintCustomScrollbar): Ditto.
1731         (UIDelegate::paintCustomScrollCorner): Ditto.
1732         (UIDelegate::setFrame): Ditto.
1733         (UIDelegate::webViewFrame): Ditto.
1734         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1735         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1736         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1737         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1738         (UIDelegate::webViewAddMessageToConsole): Ditto.
1739         (UIDelegate::doDragDrop): Ditto.
1740         (UIDelegate::webViewGetDlgCode): Ditto.
1741         (UIDelegate::createWebViewWithRequest): Ditto.
1742         (UIDelegate::webViewClose): Ditto.
1743         (UIDelegate::webViewFocus): Ditto.
1744         (UIDelegate::webViewUnfocus): Ditto.
1745         (UIDelegate::webViewPainted): Ditto.
1746         (UIDelegate::exceededDatabaseQuota): Ditto.
1747         (UIDelegate::embeddedViewWithArguments): Ditto.
1748         (UIDelegate::webViewClosing): Ditto.
1749         (UIDelegate::webViewSetCursor): Ditto.
1750         (UIDelegate::webViewDidInvalidate): Ditto.
1751         (UIDelegate::setStatusText): Ditto.
1752         (UIDelegate::desktopNotificationsDelegate): Ditto.
1753         (UIDelegate::drawBackground): Ditto.
1754         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1755         (UIDelegate::didPressMissingPluginButton): Ditto.
1756         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1757         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1758         (LoadHTMLStringItem::invoke): Ditto.
1759         (ScriptItem::invoke): Ditto.
1760
1761 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1762
1763         Stylechecker: False positive on inline asm code.
1764         https://bugs.webkit.org/show_bug.cgi?id=130570
1765
1766         Reviewed by Csaba Osztrogonác.
1767
1768         Disable stylechecking in asm blocks.
1769
1770         * Scripts/webkitpy/style/checkers/cpp.py:
1771         (process_line):
1772         (_InlineASMState):
1773         (_InlineASMState.__init__):
1774         (_InlineASMState.process_line):
1775         (_InlineASMState.isInside):
1776         (_process_lines):
1777         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1778         (WebKitStyleTest.test_member_initialization_list):
1779
1780 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1783         https://bugs.webkit.org/show_bug.cgi?id=131029
1784
1785         Reviewed by Philippe Normand.
1786
1787         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1788         tests and remove the getWebKit1TestResoucesDir() method.
1789
1790         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1791         (testDownloadLocalFile): Use Test::getResourcesDir().
1792         (testDownloadLocalFileError): Ditto.
1793         (serverCallback): Ditto.
1794         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1795         (serverCallback): Ditto.
1796         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1797         (httpServerCallback): Ditto.
1798         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1799         (serverCallback): Ditto.
1800         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1801         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1802         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1803         (Test::getWebKit1TestResoucesDir): Deleted.
1804
1805 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1806
1807         [WK2] HTTP authentication regression tests fail
1808         https://bugs.webkit.org/show_bug.cgi?id=81627
1809         <rdar://problem/11079296>
1810
1811         Reviewed by Anders Carlsson.
1812
1813         * WebKitTestRunner/TestController.h:
1814         * WebKitTestRunner/TestController.cpp:
1815         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1816         to pageLoaderClient structure.
1817         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1818         for password based authentication (we do get server trust challenges on some tests,
1819         which WKTR can't handle).
1820         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1821         calls won't be made, at least on CFNetwork based platforms.
1822         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1823         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1824         make sense to associate auth requests with individual resources - there can be
1825         multiple resources loading at once from the same protection space, so WebKit1 API
1826         that had a resource identifier was inherently racy.
1827
1828 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1829
1830         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1831         https://bugs.webkit.org/show_bug.cgi?id=131427
1832
1833         Reviewed by Gyuyoung Kim.
1834
1835         Since r166973, font path was changed.
1836
1837         * DumpRenderTree/PlatformEfl.cmake:
1838         * WebKitTestRunner/PlatformEfl.cmake:
1839
1840 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1841
1842         Fix the build-jsc build
1843         https://bugs.webkit.org/show_bug.cgi?id=131410
1844
1845         Reviewed by Michael Saboff.
1846
1847         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1848         WTF depends on it.
1849
1850 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1851
1852         [GTK] Remove WebKit1 unit tests
1853         https://bugs.webkit.org/show_bug.cgi?id=131359
1854
1855         Reviewed by Anders Carlsson.
1856
1857         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1858         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1859         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1860
1861         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1862         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1863         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1864         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1865         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1866         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1867         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1868         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1869         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1870         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1871         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1872         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1873         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1874         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1875         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1876         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1877         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1878         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1879         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1880         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1881         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1882         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1883         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1884         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1885         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1886         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1887         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1888         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1889         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1890         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1891         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1892         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1893         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1894         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1895         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1896         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1897         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1898         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1899
1900 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1901
1902         Unreviewed gardening (Take 2): Prevent users from attempting
1903         to build with known invalid cURL. 
1904
1905         * Scripts/webkitdirs.pm:
1906         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1907         7.33.0 (the known good version).
1908
1909 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1910
1911         [GTK] Remove DumpRenderTree and GtkLauncher
1912         https://bugs.webkit.org/show_bug.cgi?id=131373
1913
1914         Reviewed by Andreas Kling.
1915
1916         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1917         no longer necessary now that WebKit1 GTK+ will be removed.
1918
1919         * CMakeLists.txt:
1920         * DumpRenderTree/PlatformGTK.cmake: Removed.
1921         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1922         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1923         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1924         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1925         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1926         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1927         * DumpRenderTree/gtk/EventSender.h: Removed.
1928         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1929         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1930         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1931         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1932         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1933         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1934         * DumpRenderTree/gtk/TextInputController.h: Removed.
1935         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1936         * GtkLauncher/CMakeLists.txt: Removed.
1937         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1938         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1939         * GtkLauncher/main.c: Removed.
1940         * GtkLauncher/simple.svg: Removed.
1941         * GtkLauncher/text.html: Removed.
1942         * WebKitTestRunner/PlatformGTK.cmake:
1943         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1944         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1945         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1946
1947 2014-04-08  Mark Rowe  <mrowe@apple.com>
1948
1949         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1950         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1951
1952         Reviewed by Alexey Proskuryakov.
1953
1954         * Scripts/webkitdirs.pm:
1955         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1956         (execMacWebKitAppForDebugging): Ditto.
1957
1958 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1959
1960         Build bmalloc on iOS too
1961         https://bugs.webkit.org/show_bug.cgi?id=131381
1962
1963         Reviewed by Andreas Kling.
1964
1965         * Scripts/build-webkit:
1966
1967 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1968
1969         Unreviewed gardening: Prevent users from attempting
1970         to build with known invalid cURL.
1971
1972         * Scripts/webkitdirs.pm:
1973         (checkInstalledTools): Block build attempts with bad
1974         Cygwin tool set.
1975
1976 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1977
1978         Build bmalloc on Mac
1979         https://bugs.webkit.org/show_bug.cgi?id=131333
1980
1981         Reviewed by Mark Rowe.
1982
1983         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1984         (Note: Just testing Mac is not good enough because in this
1985         script 'Mac' means 'Mac or iOS'.)
1986
1987 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1988
1989         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1990         https://bugs.webkit.org/show_bug.cgi?id=130951
1991
1992         Reviewed by Geoffrey Garen.
1993
1994         * Scripts/run-javascriptcore-tests:
1995
1996 2014-04-06  Darin Adler  <darin@apple.com>
1997
1998         Rework CSS calc logic, fixing some reference count mistakes in Length
1999         https://bugs.webkit.org/show_bug.cgi?id=131280
2000
2001         Reviewed by Andreas Kling.
2002
2003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2004         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2005
2006 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2007
2008         Enable WEB_REPLAY for PLATFORM(MAC)
2009         https://bugs.webkit.org/show_bug.cgi?id=130700
2010
2011         Reviewed by Timothy Hatcher.
2012
2013         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2014
2015 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2016
2017         [CMake] Include X11's include dirs in TestNetscapePlugin
2018         https://bugs.webkit.org/show_bug.cgi?id=131270
2019
2020         Reviewed by Martin Robinson.
2021
2022         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2023         TestNetscapePlugin includes WebCore code that includes X headers.
2024
2025 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2026
2027         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2028         <http://webkit.org/b/130986>
2029
2030         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2031         prefix to TileCache class names in exception list.
2032
2033 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2034
2035         [GTK] kill-old-processes should kill dbus-daemon processes
2036         https://bugs.webkit.org/show_bug.cgi?id=127352
2037
2038         Reviewed by Martin Robinson.
2039
2040         * BuildSlaveSupport/kill-old-processes:
2041         (main):
2042
2043 2014-04-04  Andres Gomez  <agomez@igalia.com>
2044
2045         [Win] Update obsolete packages in cygwin
2046         https://bugs.webkit.org/show_bug.cgi?id=126264
2047
2048         Reviewed by Brent Fulgham.
2049
2050         Removed "apache" and "minires" as the first has been replaced by
2051         "lighttpd" and the second is now integrated into
2052         "cygwin". Replaced the transitional and now obsolete "gcc" package
2053         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2054         since the newer version available is "2.7.3" which breaks the
2055         build due to some funniness with environment variable handling.
2056
2057         * CygwinDownloader/cygwin-downloader.py:
2058         * CygwinDownloader/cygwin-downloader.zip:
2059
2060 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2061
2062         check-webkit-style: Improve warnings on Objective-C @property syntax
2063         https://bugs.webkit.org/show_bug.cgi?id=131200
2064
2065         Reviewed by Dan Bernstein.
2066
2067         * Scripts/webkitpy/style/checkers/cpp.py:
2068         (check_spacing):
2069         (CppChecker):
2070         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2071         (CppStyleTest.test_spacing_in_objective_c_properties):
2072
2073 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2074
2075         Unreviewed. Moving my name to commiter section
2076
2077         * Scripts/webkitpy/common/config/contributors.json:
2078
2079 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2080
2081         Unreviewed. Add myself as a committer.
2082
2083         * Scripts/webkitpy/common/config/contributors.json:
2084
2085 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2086
2087         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2088         https://bugs.webkit.org/show_bug.cgi?id=130391
2089
2090         Reviewed by Gyuyoung Kim.
2091
2092         Change the implementation of the zoom functionality from ewk_view_scale_set
2093         to ewk_view_page_zoom_set.
2094
2095         * MiniBrowser/efl/main.c:
2096
2097 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2098
2099         [webkitpy] perf profiler does not understand --call-graph argument
2100         https://bugs.webkit.org/show_bug.cgi?id=131132
2101
2102         Reviewed by Ryosuke Niwa.
2103
2104         New versions of perf profiler have changed the argument from --call-graph to -g.
2105
2106         * Scripts/webkitpy/common/system/profiler.py:
2107         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2108         * Scripts/webkitpy/port/driver_unittest.py:
2109         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2110
2111 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2112
2113         Add EFL WK2 performance bot to build.webkit.org
2114         https://bugs.webkit.org/show_bug.cgi?id=131034
2115
2116         Fix after r166707, use "Perf" instead of "perf" for consistency.
2117
2118         Reviewed by Csaba Osztrogonác.
2119
2120         * BuildSlaveSupport/build.webkit.org-config/config.json:
2121
2122 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2123
2124         Add EFL WK2 performance bot to build.webkit.org
2125         https://bugs.webkit.org/show_bug.cgi?id=131034
2126
2127         Reviewed by Csaba Osztrogonác.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/config.json:
2130
2131 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2132
2133         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2134         https://bugs.webkit.org/show_bug.cgi?id=131151
2135
2136         Reviewed by Gyuyoung Kim.
2137
2138         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2139         (TouchEventInfo::TouchEventInfo):
2140         (sendTouchEvent):
2141         (addTouchPointCallback):
2142         (updateTouchPointCallback):
2143         (cancelTouchPointCallback):
2144         (releaseTouchPointCallback):
2145
2146 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2147
2148         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2149         <http://webkit.org/b/131045>
2150
2151         Reviewed by Daniel Bates.
2152
2153         * Scripts/filter-build-webkit:
2154         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2155         of clang, plus debug data for all DVTAssertions.
2156
2157 2014-04-01  Dean Jackson  <dino@apple.com>
2158
2159         Load Media Controls js/css from bundle
2160         https://bugs.webkit.org/show_bug.cgi?id=131086
2161
2162         Reviewed by Eric Carlson.
2163
2164         We're now putting CSS files into the bundle, so remove the test for them.
2165
2166         * Scripts/check-for-inappropriate-files-in-framework:
2167
2168 2014-04-02  Martin Hock  <mhock@apple.com>
2169
2170         Unify private browsing with sessions.
2171         https://bugs.webkit.org/show_bug.cgi?id=130099
2172
2173         Reviewed by Alexey Proskuryakov.
2174
2175         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2177         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2178         (TestWebKitAPI::didNavigateWithNavigationData):
2179         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2180         (TestWebKitAPI::TEST):
2181
2182         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2183         (TestWebKitAPI::didNavigateWithoutNavigationData):
2184         (TestWebKitAPI::didNavigateWithNavigationData):
2185         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2186         (TestWebKitAPI::TEST):
2187
2188 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2189
2190         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2191         https://bugs.webkit.org/show_bug.cgi?id=130343
2192
2193         Reviewed by Gustavo Noronha Silva.
2194
2195         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2196         of directories on the command line and look for all appropriate files in those directories for the
2197         GResource archive. Also make archive paths relative to those directories.
2198         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2199         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2200
2201 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2202
2203         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2204         https://bugs.webkit.org/show_bug.cgi?id=131106
2205
2206         Reviewed by Csaba Osztrogonác.
2207
2208         * Scripts/webkitpy/tool/commands/download.py:
2209         (AbstractRolloutPrepCommand._prepare_state):
2210         * Scripts/webkitpy/tool/commands/download_unittest.py:
2211         (test_prepare_rollout):
2212         (test_create_rollout):
2213         (test_create_rollout_resolved):
2214         (test_rollout):
2215
2216 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2217
2218         [EFL] Add option to use separate web process for new window in MiniBrowser
2219         https://bugs.webkit.org/show_bug.cgi?id=130190
2220
2221         Reviewed by Gyuyoung Kim.
2222
2223         New created window (CTRL + n) will be open in separated web process.
2224         This option is enabled by adding a flag (S/separate-process) with launching
2225         MiniBrowser.
2226
2227         * MiniBrowser/efl/main.c:
2228         (elm_main):
2229
2230 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         [GTK] Move NEWS file to a new location
2233         https://bugs.webkit.org/show_bug.cgi?id=130901
2234
2235         Reviewed by Brent Fulgham.
2236
2237         * gtk/manifest.txt: Update the NEWS file path.
2238
2239 2014-04-01  Anders Carlsson  <andersca@apple.com>
2240
2241         Fix build.
2242
2243         * MiniBrowser/mac/WK2BrowserWindowController.m:
2244         (-[WK2BrowserWindowController awakeFromNib]):
2245         (-[WK2BrowserWindowController dealloc]):
2246         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2247
2248 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2249
2250         Unreviewed test gardening.
2251
2252         * Scripts/webkitpy/port/base_unittest.py:
2253         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2254
2255 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2256
2257         [CSS Exclusions] Remove exclusions parsing support
2258         https://bugs.webkit.org/show_bug.cgi?id=131046
2259
2260         Reviewed by David Hyatt.
2261
2262         * Scripts/webkitperl/FeatureList.pm:
2263
2264 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2265
2266         [GTK] Remove last reference to GTK+ WK1 EWS
2267         https://bugs.webkit.org/show_bug.cgi?id=131058
2268
2269         Reviewed by Martin Robinson.
2270
2271         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2272
2273         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2274
2275 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2276
2277         Add a 32bit JSC builder/tester.
2278         https://bugs.webkit.org/show_bug.cgi?id=131054
2279         
2280         Reviewed by Michael Saboff.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/config.json:
2283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2284         (Compile32bitJSC):
2285         (Run32bitJSCTests):
2286         (Run32bitJSCTests.countFailures):
2287         (BuildAndTest32bitJSCFactory):
2288         (BuildAndTest32bitJSCFactory.__init__):
2289
2290 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2291
2292         [GTK] No longer build WebKit1 gtkdoc
2293         https://bugs.webkit.org/show_bug.cgi?id=130970
2294
2295         Reviewed by Anders Carlsson.
2296
2297         * gtk/common.py:
2298         (gtk_version_of_pkg_config_file): Deleted.
2299         * gtk/generate-gtkdoc:
2300         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2301         was only applicable for WebKit1.
2302         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2303
2304 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2305
2306         [GTK] Running minibrowser with url crashes in debug build
2307         https://bugs.webkit.org/show_bug.cgi?id=130492
2308
2309         Reviewed by Martin Robinson.
2310
2311         Update "uri-scheme" test not to use invalid URIs in it, so we
2312         don't get a mistmatch when comparing the original URI stored in
2313         the test class with the one returned by the WebKitWebView.
2314
2315         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2316         (testWebContextURIScheme): Update the test.
2317
2318 2014-04-01  Mihai Tica  <mitica@adobe.com>
2319
2320         Unreviewed: Add myself as a commiter to the contributors list.
2321
2322         * Scripts/webkitpy/common/config/contributors.json:
2323
2324 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2325
2326         [EFL][WK2] Extract the control of page background out of color_set
2327         https://bugs.webkit.org/show_bug.cgi?id=127539
2328
2329         Reviewed by Gyuyoung Kim.
2330
2331         Added an option(C) to change background color.
2332
2333         * MiniBrowser/efl/main.c:
2334         (window_create):
2335         (elm_main):
2336
2337 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2338
2339         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2340
2341         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2342
2343 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2344
2345         Unreviewed test correction after r166530.
2346
2347         * DumpRenderTree/mac/DumpRenderTree.mm:
2348         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2349         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2350
2351 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2352
2353         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2354         https://bugs.webkit.org/show_bug.cgi?id=130987
2355
2356         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2357         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2358
2359         Reviewed by Martin Robinson.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/config.json:
2362
2363 2014-03-31  Dean Jackson  <dino@apple.com>
2364
2365         Remove WEB_ANIMATIONS
2366         https://bugs.webkit.org/show_bug.cgi?id=130989
2367
2368         Reviewed by Simon Fraser.
2369
2370         Remove this feature flag until we plan to implement.
2371
2372         * Scripts/webkitperl/FeatureList.pm:
2373
2374 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2375
2376         Reduced Latched Scroll Test Flakiness
2377         https://bugs.webkit.org/show_bug.cgi?id=130983
2378
2379         Reviewed by Darin Adler.
2380
2381         * DumpRenderTree/mac/DumpRenderTree.mm:
2382         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2383         * DumpRenderTree/mac/EventSendingController.mm:
2384         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2385         with high resolution flags turned on.
2386         * WebKitTestRunner/mac/EventSenderProxy.mm:
2387         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2388
2389 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2390
2391         run-webkit-tests should have a --no-timeout option
2392         https://bugs.webkit.org/show_bug.cgi?id=128286
2393
2394         Reviewed by Joseph Pecoraro.
2395
2396         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2397         (Worker._run_test): Renaming _run_test_with_timeout()
2398         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2399         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2400         (Worker._run_test_in_this_thread):
2401         (Worker._run_test_with_timeout): Deleted.
2402         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2403         (parse_args): Added the --no-timeout option
2404
2405 2014-03-31  Samuel White  <samuel_white@apple.com>
2406
2407         AX: Need ability to get line range for text marker.
2408         https://bugs.webkit.org/show_bug.cgi?id=130906
2409
2410         Reviewed by Chris Fleizach.
2411
2412         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2413
2414         * DumpRenderTree/AccessibilityUIElement.cpp:
2415         (lineTextMarkerRangeForTextMarkerCallback):
2416         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2417         (AccessibilityUIElement::getJSClass):
2418         * DumpRenderTree/AccessibilityUIElement.h:
2419         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2420         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2421         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2422         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2423         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2424         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2426         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2427         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2428         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2429         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2430         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2431
2432 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2433
2434         More validation for FTL inline caches
2435         https://bugs.webkit.org/show_bug.cgi?id=130948
2436
2437         Reviewed by Geoffrey Garen.
2438
2439         * Scripts/run-jsc-stress-tests:
2440
2441 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2442
2443         [GTK] Do not run WebKit1 unit tests by default
2444         https://bugs.webkit.org/show_bug.cgi?id=130968
2445
2446         Reviewed by Martin Robinson.
2447
2448         * Scripts/run-gtk-tests:
2449         (TestRunner):
2450
2451 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2452
2453         [GTK] Remove scripts code only applicable to autotools
2454         https://bugs.webkit.org/show_bug.cgi?id=130841
2455
2456         Reviewed by Anders Carlsson.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2459         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2460         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2461         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2462         * gtk/find-make-dist-errors: Removed.
2463         * gtk/generate-feature-defines-files: Removed.
2464         * gtk/manifest.txt: No longer need to consider autotools files.
2465
2466 2014-03-30  Andy Estes  <aestes@apple.com>
2467
2468         Fix two failing layout tests on Mountain Lion after r166466.
2469
2470         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2471         (-[DownloadDelegate _downloadDidStart:]):
2472
2473 2014-03-30  Andy Estes  <aestes@apple.com>
2474
2475         [Cocoa] Add an originatingWebView property to _WKDownload
2476         https://bugs.webkit.org/show_bug.cgi?id=130945
2477
2478         Reviewed by Anders Carlsson.
2479
2480         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2481         (-[DownloadDelegate _downloadDidStart:]):
2482         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2483         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2484         (TEST):
2485
2486 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2487
2488         Land the stackmap register liveness glue with the uses of the liveness disabled
2489         https://bugs.webkit.org/show_bug.cgi?id=130924
2490
2491         Reviewed by Oliver Hunt.
2492
2493         * Scripts/run-jsc-stress-tests:
2494
2495 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2496
2497         Update WebKit1.StringTruncator for Mountain Lion.
2498
2499         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2500         due to different font metrics on 10.8.
2501
2502 2014-03-28  Darin Adler  <darin@apple.com>
2503
2504         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2505         https://bugs.webkit.org/show_bug.cgi?id=130889
2506
2507         Reviewed by Alexey Proskuryakov.
2508
2509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2510         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2511         WebStringTruncator methods; should be good for a start. These are dependent on the
2512         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2513
2514 2014-03-28  Martin Hock  <mhock@apple.com>
2515
2516         Unreviewed. Add myself as a committer.
2517
2518         * Scripts/webkitpy/common/config/contributors.json:
2519
2520 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2521
2522         Remove WebKit1 GTK+ bots
2523         https://bugs.webkit.org/show_bug.cgi?id=130904
2524
2525         Reviewed by Anders Carlsson.
2526
2527         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2528         all bots are testing WebKit2 only.
2529         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2530         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2531         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2532         * Scripts/webkitpy/port/builders.py: Ditto.
2533         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2534         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2535
2536 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2537
2538         Remove Brian Burg's apple.com email address.
2539
2540         * Scripts/webkitpy/common/config/contributors.json:
2541
2542 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2543
2544         bisect-builds should print Trac 'changeset' URL if only one build is detected
2545         <http://webkit.org/b/130903>
2546
2547         Reviewed by Dan Bernstein.
2548
2549         * Scripts/bisect-builds:
2550         (printTracLink): Print a direct link to the Trac 'changeset'
2551         URL if there is only one revision in the range.
2552
2553 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2554
2555         [EFL] Bump glib version from 2.36 to 2.38 
2556         https://bugs.webkit.org/show_bug.cgi?id=130886
2557
2558         Reviewed by Csaba Osztrogonác.
2559
2560         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2561         we need to bump glib version up to 2.38 as gtk port.
2562
2563         * efl/jhbuild.modules:
2564
2565 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2566
2567         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2568
2569         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2570         the globalhistory directory.
2571
2572         Reviewed by Sam Weinig.
2573
2574         * WebKitTestRunner/TestController.cpp:
2575         (WTR::TestController::TestController):
2576         (WTR::TestController::initialize): Set the history client.
2577         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2578         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2579         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2580         and we don't yet have API to access the data in question.
2581         (WTR::TestController::didPerformClientRedirect):
2582         (WTR::TestController::didPerformServerRedirect):
2583         (WTR::TestController::didUpdateHistoryTitle):
2584         * WebKitTestRunner/TestController.h:
2585         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2586         * WebKitTestRunner/TestInvocation.cpp:
2587         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2588         (WTR::TestInvocation::invoke):
2589
2590 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2591
2592         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2593
2594         * Scripts/build-webkit:
2595         * Scripts/copy-webkitlibraries-to-product-directory:
2596
2597 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2598
2599         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2600         https://bugs.webkit.org/show_bug.cgi?id=130867
2601         <rdar://problem/16432456> 
2602
2603         Reviewed by Mark Hahnenberg.
2604
2605         * Scripts/build-webkit:
2606         * Scripts/copy-webkitlibraries-to-product-directory:
2607
2608 2014-03-26  Andy Estes  <aestes@apple.com>
2609
2610         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2611         https://bugs.webkit.org/show_bug.cgi?id=130805
2612
2613         Reviewed by Dan Bernstein.
2614
2615         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2616         (-[DownloadDelegate _download:didReceiveResponse:]):
2617         (-[DownloadDelegate _downloadDidFinish:]):
2618         (runTest):
2619         (TEST):
2620         (-[FailingDownloadDelegate _downloadDidFinish:]):
2621         (-[FailingDownloadDelegate _download:didFailWithError:]):
2622         (-[FailingDownloadDelegate _downloadDidCancel:]):
2623         (-[CancelledDownloadDelegate _downloadDidStart:]):
2624         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2625         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2626         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2627         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2628         (-[DownloadDelegate sourceURL]): Deleted.
2629         (runTestWithNavigationDelegate): Deleted.
2630
2631 2014-03-26  Anders Carlsson  <andersca@apple.com>
2632
2633         Change MiniBrowser to hold on to window controllers instead of windows
2634         https://bugs.webkit.org/show_bug.cgi?id=130797
2635
2636         Reviewed by Oliver Hunt.
2637
2638         * MiniBrowser/mac/AppDelegate.h:
2639         * MiniBrowser/mac/AppDelegate.m:
2640         (-[BrowserAppDelegate init]):
2641         (-[BrowserAppDelegate newWindow:]):
2642         (-[BrowserAppDelegate browserWindowWillClose:]):
2643         (-[BrowserAppDelegate applicationWillTerminate:]):
2644         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2645
2646 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2647
2648         Unreviewed, rolling out r166264.
2649         https://bugs.webkit.org/show_bug.cgi?id=130785
2650
2651         Broke some window.opener tests for WK2 Mavericks (Requested by
2652         brrian__ on #webkit).
2653
2654         Reverted changeset:
2655
2656         "Web Replay: resource unique identifiers should be unique-per-
2657         frame, not globally"
2658         https://bugs.webkit.org/show_bug.cgi?id=130632
2659         http://trac.webkit.org/changeset/166264
2660
2661 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2662
2663         [CSS Shapes] Remove shape-inside support
2664         https://bugs.webkit.org/show_bug.cgi?id=130698
2665
2666         Reviewed by David Hyatt.
2667
2668         * Scripts/webkitperl/FeatureList.pm:
2669
2670 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2671
2672         Unreviewed. Add myself as a committer.
2673
2674         * Scripts/webkitpy/common/config/contributors.json:
2675
2676 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2677
2678         run-launcher is Perl script so use elsif and not elif
2679         https://bugs.webkit.org/show_bug.cgi?id=130771
2680
2681         Reviewed by Carlos Garcia Campos.
2682
2683         * Scripts/run-launcher:
2684
2685 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2686
2687         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2688         https://bugs.webkit.org/show_bug.cgi?id=130575
2689
2690         Reviewed by Mario Sanchez Prada.
2691
2692         Change ATK version to 2.11.92. Adjust current implementation.
2693
2694         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2695         (AccessibilityUIElement::intValue):
2696         (AccessibilityUIElement::minValue):
2697         (AccessibilityUIElement::maxValue):
2698         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2699         (WTR::AccessibilityUIElement::intValue):
2700         (WTR::AccessibilityUIElement::minValue):
2701         (WTR::AccessibilityUIElement::maxValue):
2702         * efl/jhbuild.modules:
2703         * gtk/jhbuild.modules:
2704
2705 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2706
2707         [GTK] The gnumake package is no longer needed in jhbuild
2708         https://bugs.webkit.org/show_bug.cgi?id=130121
2709
2710         Reviewed by Martin Robinson.
2711
2712         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2713         for a debug build cmake/system-gnumake worked just fine for me.
2714
2715         * gtk/jhbuild.modules: Removed gnumake.
2716         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2717         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2718
2719 2014-03-25  Andy Estes  <aestes@apple.com>
2720
2721         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2722
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2724         (-[DownloadDelegate _download:didReceiveData:]):
2725         (-[DownloadDelegate _downloadDidFinish:]):
2726
2727 2014-03-25  Brian Burg  <bburg@apple.com>
2728
2729         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2730         https://bugs.webkit.org/show_bug.cgi?id=130623
2731
2732         Reviewed by Timothy Hatcher.
2733
2734         The resource loader callback dumping routines assumed that resource identifiers
2735         were globally unique. Its map of resource identifiers to URLs must also track the
2736         frame associated with the resource.
2737
2738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2739         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2740         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2741         stable as long as the frame is valid.
2742         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2743         (WTR::InjectedBundlePage::willSendRequestForFrame):
2744         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2745         (WTR::InjectedBundlePage::didFinishLoadForResource):
2746         (WTR::InjectedBundlePage::didFailLoadForResource):
2747
2748 2014-03-25  Andy Estes  <aestes@apple.com>
2749
2750         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2751
2752         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2753         (-[DownloadDelegate _download:didReceiveResponse:]):
2754         (-[DownloadDelegate _download:didReceiveData:]):
2755
2756 2014-03-25  Andy Estes  <aestes@apple.com>
2757
2758         Add some debug logging to an API test that's failing on Mountain Lion.
2759
2760         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2761         (-[DownloadDelegate _download:didReceiveResponse:]):
2762         (-[DownloadDelegate _downloadDidFinish:]):
2763
2764 2014-03-25  Anders Carlsson  <andersca@apple.com>
2765
2766         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2767         https://bugs.webkit.org/show_bug.cgi?id=130732
2768
2769         Reviewed by Tim Horton.
2770
2771         * MiniBrowser/mac/WK2BrowserWindowController.m:
2772         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2773
2774 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2775
2776         [GTK] Remove the autotools build
2777         https://bugs.webkit.org/show_bug.cgi?id=130717
2778
2779         Reviewed by Anders Carlsson.
2780
2781         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2782         * GNUmakefile.am: Removed.
2783         * GtkLauncher/GNUmakefile.am: Removed.
2784         * GtkLauncher/main.c: Remove references to the autotools configure file.
2785         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2786         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2787         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2788         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2789         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2790         * Scripts/build-webkit: No longer handle autotools.
2791         * Scripts/run-gtk-tests: Ditto.
2792         (TestRunner._setup_testing_environment):
2793         * Scripts/run-launcher: Ditto.
2794         * Scripts/webkitdirs.pm: Ditto.
2795         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2796         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2797         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2798         * Scripts/webkitpy/style/checker.py:
2799         * TestWebKitAPI/GNUmakefile.am: Removed.
2800         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2801         * WebKitTestRunner/GNUmakefile.am: Removed.
2802         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2803         * gtk/GNUmakefile.am: Removed.
2804         * gtk/common.py: Remove checks for the autotools build.
2805         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2806
2807 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2808
2809         prepare-ChangeLog throws false positive warnings for modified files.
2810         https://bugs.webkit.org/show_bug.cgi?id=130687
2811
2812         Reviewed by Darin Adler.
2813
2814         * Scripts/prepare-ChangeLog:
2815         (originalFile): Ignore git commit paremeter.
2816         We don't need this to get the unmodified file.
2817         (extractLineRangeBeforeChange):
2818         Simplify the if statement. Follow-up after r166189.
2819
2820 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2821
2822         [EFL] Add ARM64 build support
2823         https://bugs.webkit.org/show_bug.cgi?id=130506
2824
2825         Rubber stamped by Gyuyoung Kim.
2826
2827         * Scripts/webkitdirs.pm:
2828         (isARM): Detect aarch64 as ARM.
2829
2830 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2831
2832         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2833         https://bugs.webkit.org/show_bug.cgi?id=130137
2834
2835         Reviewed by Csaba Osztrogonác.
2836
2837         * Scripts/webkitpy/common/checkout/changelog.py:
2838         (ChangeLogEntry._parse_bug_description):
2839         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2840         (test_parse_log_entries_from_changelog):
2841         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2842         (CheckoutTest.test_commit_info_for_revision):
2843
2844 2014-03-24  Andy Estes  <aestes@apple.com>
2845
2846         Fix the iOS build of TestWebKitAPI.
2847
2848         * TestWebKitAPI/Configurations/Base.xcconfig:
2849         * TestWebKitAPI/PlatformUtilities.h:
2850
2851 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2852
2853         Fix prepare-ChangeLog after r166156.
2854         https://bugs.webkit.org/show_bug.cgi?id=130674
2855
2856         Reviewed by Darin Adler.
2857
2858         * Scripts/prepare-ChangeLog:
2859         (generateFunctionLists):
2860         (extractLineRangeBeforeChange):
2861
2862 2014-03-24  Andy Estes  <aestes@apple.com>
2863
2864         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2865         https://bugs.webkit.org/show_bug.cgi?id=129322
2866
2867         Reviewed by Anders Carlsson.
2868
2869         Add an API test suite for _WKDownload.
2870
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2873         (-[DownloadDelegate initWithSourceURL:]):
2874         (-[DownloadDelegate sourceURL]):
2875         (-[DownloadDelegate _downloadDidStart:]):
2876         (-[DownloadDelegate _download:didReceiveResponse:]):
2877         (-[DownloadDelegate _download:didReceiveData:]):
2878         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2879         (-[DownloadDelegate _downloadDidFinish:]):
2880         (TEST):
2881         (runTestWithNavigationDelegate):
2882         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2883         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2884
2885 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2886
2887         filter-build-webkit: reduce unfiltered output
2888         https://bugs.webkit.org/show_bug.cgi?id=130485
2889
2890         Reviewed by Brent Fulgham.
2891
2892         * Scripts/filter-build-webkit:
2893         (shouldIgnoreLine):
2894
2895 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2896
2897         prepare-ChangeLog should list functions that have been removed too.
2898         https://bugs.webkit.org/show_bug.cgi?id=130508
2899
2900         Reviewed by Darin Adler.
2901
2902         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2903         We have to read the functions and the line ranges of them from the source
2904         before the change, then search for overlaps between them and the changed
2905         line ranges from diff.
2906
2907         * Scripts/prepare-ChangeLog:
2908         (originalFile): Get original source command.
2909         (generateFunctionLists): Collect deleted functions too.
2910         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2911         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2912         deleted functions ranges too.
2913         (extractLineRange): Renamed to extractLineRangeAfterChange.
2914
2915 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2916
2917         Move all EFL typedefs into EflTypedefs.h.
2918         https://bugs.webkit.org/show_bug.cgi?id=130511
2919
2920         Reviewed by Gyuyoung Kim.
2921
2922         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2923         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2924         * WebKitTestRunner/PlatformWebView.h: Ditto.
2925
2926 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2927
2928         Don't flush compositing layers within FrameView::willPaintContents()
2929         https://bugs.webkit.org/show_bug.cgi?id=130627
2930         <rdar://problem/16368869>
2931
2932         Reviewed by Sam Weinig.
2933         
2934         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2935         does not flush.
2936         
2937         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2938         into an explicit function called before dumping. 
2939         
2940         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2941         are flushed to CA. They will be pushed to the window by snapshotting.
2942
2943         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2944         Fix weird path to IOKit.framework.
2945         * DumpRenderTree/mac/DumpRenderTree.mm:
2946         (updateDisplay):
2947         (dump):
2948         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2949         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2950         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2951
2952 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2953
2954         fix-blink-patch: tool to fix up renamed directory paths in Blink
2955         <http://webkit.org/b/130609>
2956
2957         Reviewed by Ryosuke Niwa.
2958
2959         Usage: cat blink.patch | fix-blink-patch | svn-apply
2960
2961         * Scripts/fix-blink-patch: Added.
2962
2963 2014-03-21  Darin Adler  <darin@apple.com>
2964
2965         Remove use of deprecatedCharacters in WebKit API tests
2966         https://bugs.webkit.org/show_bug.cgi?id=130602
2967
2968         Reviewed by Antti Koivisto.
2969
2970         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2971         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2972         (TestWebKitAPI::expectEmpty): Use characters8.
2973         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2974
2975         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2976         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2977         the deprecatedCharacters function itself, which we are about to delete.
2978
2979 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2980
2981         [webkitpy] Fix has_valid_reviewer()
2982         https://bugs.webkit.org/show_bug.cgi?id=130589
2983
2984         Reviewed by Csaba Osztrogonác.
2985
2986         * Scripts/webkitpy/common/checkout/changelog.py:
2987         (ChangeLogEntry.has_valid_reviewer):
2988         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2989         (test_has_valid_reviewer):
2990         * Scripts/webkitpy/common/config/committers.py:
2991         (CommitterList._reviewer_only):
2992         (CommitterList.committer_by_name):
2993         (CommitterList.reviewer_by_email):
2994         (CommitterList):
2995         (CommitterList.reviewer_by_name):
2996
2997 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2998
2999         Add cache support for jhbuild
3000         https://bugs.webkit.org/show_bug.cgi?id=130588
3001
3002         Reviewed by Csaba Osztrogonác.
3003
3004         * jhbuild/jhbuildrc_common.py:
3005         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3006
3007 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3008
3009         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3010         https://bugs.webkit.org/show_bug.cgi?id=130504
3011
3012         Reviewed by Martin Robinson.
3013
3014         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3015         CMake if not specified.
3016         * Scripts/webkitdirs.pm:
3017         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3018         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3019
3020 2014-03-21  Andreas Kling  <akling@apple.com>
3021
3022         RetainPtr API test should use CFArray instead of CFString for testing.
3023         <rdar://problem/16384899>
3024
3025         Unreviewed bot fix.
3026
3027         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3028         (TestWebKitAPI::TEST):
3029         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3030         (TestWebKitAPI::TEST):
3031
3032 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3033
3034         Move to using std::unique_ptr for EFL objects.
3035         https://bugs.webkit.org/show_bug.cgi?id=129853
3036
3037         Reviewed by Gyuyoung Kim.
3038
3039         EflUniquePtr is a template alias of std::unique_ptr
3040         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3041         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3042
3043         * DumpRenderTree/efl/DumpRenderTree.cpp:
3044         (main):
3045         * ImageDiff/efl/ImageDiff.cpp:
3046         (initEfl):
3047         (main):
3048
3049 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3050
3051         Unreviewed buildfix after r165983 for non Cocoa platforms
3052
3053         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3054
3055         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3056         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3057         * WebKitTestRunner/TestController.cpp:
3058
3059 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3060
3061         [GTK][CMake] Add support for building with Clang
3062         https://bugs.webkit.org/show_bug.cgi?id=130260
3063
3064         Reviewed by Martin Robinson.
3065
3066         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3067         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3068         included GTest framework headers.
3069         * gtk/generate-gtkdoc:
3070         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3071         in case of using Clang since that is now set by the CMake rule.
3072
3073 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3074
3075         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3076         https://bugs.webkit.org/show_bug.cgi?id=130476
3077
3078         Reviewed by Anders Carlsson.
3079         
3080         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3081
3082         * MiniBrowser/mac/WK1BrowserWindowController.m:
3083         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3084         Remove log.
3085         * MiniBrowser/mac/WK2BrowserWindowController.m:
3086         (-[WK2BrowserWindowController awakeFromNib]):
3087         (-[WK2BrowserWindowController validateMenuItem:]):
3088         (-[WK2BrowserWindowController reload:]):
3089         Hook up reload.
3090         (-[WK2BrowserWindowController toggleZoomMode:]):
3091         (-[WK2BrowserWindowController resetZoom:]):
3092         (-[WK2BrowserWindowController canResetZoom]):
3093         (-[WK2BrowserWindowController currentZoomFactor]):
3094         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3095         (-[WK2BrowserWindowController canZoomIn]):
3096         (-[WK2BrowserWindowController canZoomOut]):
3097
3098 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3099
3100         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3101         https://bugs.webkit.org/show_bug.cgi?id=130463
3102
3103         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3104
3105 2014-03-18  Samuel White  <samuel_white@apple.com>
3106
3107         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3108         https://bugs.webkit.org/show_bug.cgi?id=130250
3109
3110         Reviewed by Chris Fleizach.
3111
3112         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3113
3114         * DumpRenderTree/AccessibilityController.cpp:
3115         (enableEnhancedAccessibilityCallback):
3116         (getEnhancedAccessibilityEnabledCallback):
3117         (AccessibilityController::getJSClass):
3118         * DumpRenderTree/AccessibilityController.h:
3119         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3120         (AccessibilityController::enableEnhancedAccessibility):
3121         (AccessibilityController::enhancedAccessibilityEnabled):
3122         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3123         (AccessibilityController::enableEnhancedAccessibility):
3124         (AccessibilityController::enhancedAccessibilityEnabled):
3125         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3126         (AccessibilityController::enableEnhancedAccessibility):
3127         (AccessibilityController::enhancedAccessibilityEnabled):
3128         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3129         (AccessibilityController::enableEnhancedAccessibility):
3130         (AccessibilityController::enhancedAccessibilityEnabled):
3131         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3132         (WTR::AccessibilityController::enableEnhancedAccessibility):
3133         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3134         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3136
3137 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3138
3139         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3140         yet).
3141
3142         * Scripts/webkitpy/common/config/contributors.json:
3143
3144 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3145
3146         Web Inspector: Remove stale ReportMemoryUsagePlugin
3147         https://bugs.webkit.org/show_bug.cgi?id=130405
3148
3149         Reviewed by Andreas Kling.
3150
3151         This clang plugin looks like it was used for the old Inspector memory
3152         instrumentation that was removed. So the tool can be removed.
3153
3154         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3155         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3156         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3157         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3158
3159 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3160
3161         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3162         https://bugs.webkit.org/show_bug.cgi?id=130220
3163
3164         Reviewed by Csaba Osztrogonác.
3165
3166         * Scripts/webkitpy/common/checkout/changelog.py:
3167         (ChangeLog.set_reviewer):
3168         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3169         (test_set_reviewer):
3170
3171 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3172
3173         More FTL enabling.
3174
3175         Rubber stamped by Dan Bernstein.
3176
3177         * Tools/Scripts/build-webkit:
3178
3179 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3180
3181         Renable pagination mode in WK2 MiniBrowser
3182         https://bugs.webkit.org/show_bug.cgi?id=130374
3183
3184         Reviewed by Anders Carlsson.
3185         
3186         Put the implementation of togglePaginationMode: back, and correctly
3187         enable the menu item.
3188
3189         * MiniBrowser/mac/WK2BrowserWindowController.m:
3190         (-[WK2BrowserWindowController validateMenuItem:]):
3191         (-[WK2BrowserWindowController isPaginated]):
3192         (-[WK2BrowserWindowController togglePaginationMode:]):
3193
3194 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3195
3196         Add --reset option to Tools/Scripts/set-webkit-configuration script
3197         https://bugs.webkit.org/show_bug.cgi?id=130401
3198
3199         Reviewed by Csaba Osztrogonác.
3200
3201         * Scripts/set-webkit-configuration:
3202
3203 2014-03-18  Alberto Garcia  <berto@igalia.com>
3204
3205         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3206         https://bugs.webkit.org/show_bug.cgi?id=130388
3207
3208         Reviewed by Sergio Villar Senin.
3209
3210         * Scripts/webkitdirs.pm:
3211         (shouldRemoveCMakeCache): make sure that the build directory
3212         exists before attempting to create a file in it.
3213
3214 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3215
3216         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3217         https://bugs.webkit.org/show_bug.cgi?id=130336
3218
3219         Reviewed by Gyuyoung Kim.
3220
3221         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3222         requires a space between literal and string macro [-Wliteral-suffix]'
3223         warning treated as error.
3224
3225         This patch applies a solution from r162448 to the EFL port.
3226
3227         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3228         * efl/jhbuild.modules: Added appropriate patch section.
3229
3230 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3231
3232         webkitpy test rebaseline.
3233
3234         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3235         (MainTest.test_default_args):
3236
3237 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3238
3239         --profile should imply --test-runner-count=1 in run-perf-tests
3240         https://bugs.webkit.org/show_bug.cgi?id=130375
3241
3242         Reviewed by Benjamin Poulain.
3243
3244         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3245
3246         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3247         (PerfTestsRunner._parse_args): Use -1 as the default value.
3248         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3249         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3250         should be 1.
3251
3252 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3253
3254         Address some style nits.
3255
3256         * MiniBrowser/mac/WK2BrowserWindowController.m:
3257
3258 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3259
3260         Add transparent window support back into MiniBrowser
3261         https://bugs.webkit.org/show_bug.cgi?id=130363
3262
3263         Reviewed by Anders Carlsson.
3264         
3265         Re-enable transparent window support for WK2.
3266
3267         * MiniBrowser/mac/WK2BrowserWindowController.m:
3268         (-[WK2BrowserWindowController validateMenuItem:]):
3269         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3270
3271 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3272
3273         Fix the 32-bit build; make the open panel make a WK1 window.
3274
3275         * MiniBrowser/mac/AppDelegate.m:
3276         (-[BrowserAppDelegate openDocument:]):
3277
3278 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3279
3280         Convert MiniBrowser to use WKWebView API
3281         https://bugs.webkit.org/show_bug.cgi?id=130061
3282
3283         Reviewed by Anders Carlsson.
3284         
3285         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3286         as possible.
3287         
3288         Some functionality was removed temporarily:
3289             - text zoom, page zoom
3290             - reload
3291             - pagination mode
3292             - transparent window
3293             - dumping source
3294             - window.open support
3295             - beforeUnload panel
3296             - find in page
3297
3298         * MiniBrowser/mac/AppDelegate.h:
3299         * MiniBrowser/mac/AppDelegate.m:
3300         (-[BrowserAppDelegate init]):
3301         (-[BrowserAppDelegate newWindow:]):
3302         (-[BrowserAppDelegate applicationWillTerminate:]):
3303         (-[BrowserAppDelegate openDocument:]):
3304         * MiniBrowser/mac/WK2BrowserWindowController.h:
3305         * MiniBrowser/mac/WK2BrowserWindowController.m:
3306         (-[WK2BrowserWindowController awakeFromNib]):
3307         (-[WK2BrowserWindowController dealloc]):
3308         (-[WK2BrowserWindowController fetch:]):
3309         (-[WK2BrowserWindowController validateMenuItem:]):
3310         (-[WK2BrowserWindowController reload:]):
3311         (-[WK2BrowserWindowController goBack:]):
3312         (-[WK2BrowserWindowController goForward:]):
3313         (-[WK2BrowserWindowController toggleZoomMode:]):
3314         (-[WK2BrowserWindowController resetZoom:]):
3315         (-[WK2BrowserWindowController canResetZoom]):
3316         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3317         (-[WK2BrowserWindowController togglePaginationMode:]):
3318         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3319         (-[WK2BrowserWindowController windowShouldClose:]):
3320         (-[WK2BrowserWindowController applicationTerminating]):
3321         (-[WK2BrowserWindowController currentZoomFactor]):
3322         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3323         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3324         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3325         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3326         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3327         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3328         (-[WK2BrowserWindowController find:]):
3329         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3330         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3331         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3332         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3333         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3334         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3335         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3336         * WebKitTestRunner/PlatformWebView.h:
3337         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3338         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3339
3340 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3341
3342         Use RunLoop objects through references instead of pointers
3343         https://bugs.webkit.org/show_bug.cgi?id=130313
3344
3345         Reviewed by Andreas Kling.
3346
3347         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3348         return RunLoop reference instead of a pointer.
3349
3350         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3351         (loadedCallback):
3352         (clickedCallback):
3353
3354 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3355
3356         sort-export-file --help doesn't work (missing 'use')
3357         https://bugs.webkit.org/show_bug.cgi?id=130338
3358
3359         Reviewed by Anders Carlsson.
3360
3361         * Scripts/sort-export-file:
3362         Add a missing 'use', and fix a typo in an error message.
3363
3364 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3365
3366         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3367         https://bugs.webkit.org/show_bug.cgi?id=130155
3368
3369         Reviewed by Philippe Normand.
3370
3371         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3372
3373 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3374
3375         [GTK] MiniBrowser fails to load injected bundle lib
3376         https://bugs.webkit.org/show_bug.cgi?id=130332
3377
3378         Reviewed by Anders Carlsson.
3379
3380         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3381
3382         * MiniBrowser/gtk/main.c:
3383         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3384         process is spawn.
3385
3386 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3387
3388         [EFL] Enable TOUCH_SLIDER macro
3389         https://bugs.webkit.org/show_bug.cgi?id=130185
3390
3391         Reviewed by Gyuyoung Kim.
3392
3393         * Scripts/webkitperl/FeatureList.pm:
3394
3395 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3396
3397         [GTK][CMake] Build with -fno-rtti
3398         https://bugs.webkit.org/show_bug.cgi?id=130261
3399
3400         Reviewed by Martin Robinson.
3401
3402         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3403         defined to 0 to prevent typeid use in included GTest headers.
3404
3405 2014-03-16  Brian Burg  <bburg@apple.com>
3406
3407         Web Inspector: vended backend commands file should be generated as part of the build
3408         https://bugs.webkit.org/show_bug.cgi?id=130110
3409
3410         Reviewed by Timothy Hatcher.
3411
3412         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3413
3414 2014-03-16  Diego Pino García  <dpino@igalia.com>
3415
3416         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3417         https://bugs.webkit.org/show_bug.cgi?id=128999
3418
3419         Reviewed by Philippe Normand.
3420
3421         * MiniBrowser/gtk/BrowserWindow.c:
3422         (reloadPage):
3423         (reloadPageIgnoringCache):
3424         (browser_window_init):
3425
3426 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3427
3428         [GTK] Improve ninja detection in webkitdirs.pm
3429         https://bugs.webkit.org/show_bug.cgi?id=129902
3430
3431         Reviewed by Daniel Bates.
3432
3433         * Scripts/webkitdirs.pm:
3434         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3435         us to look for ninja-build as well.
3436
3437 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3438
3439         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3440         https://bugs.webkit.org/show_bug.cgi?id=130276
3441         <rdar://problem/16266927>
3442         
3443         Reviewed by Simon Fraser.
3444
3445         * BuildSlaveSupport/build-launcher-app:
3446         * BuildSlaveSupport/build-launcher-dmg:
3447         * DumpRenderTree/DumpRenderTree.h:
3448         * DumpRenderTree/DumpRenderTreePrefix.h:
3449         * DumpRenderTree/GCController.cpp:
3450         * DumpRenderTree/GCController.h:
3451         * DumpRenderTree/JavaScriptThreading.cpp:
3452         * DumpRenderTree/JavaScriptThreading.h:
3453         * DumpRenderTree/PixelDumpSupport.cpp:
3454         * DumpRenderTree/PixelDumpSupport.h:
3455         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3456         * DumpRenderTree/TestRunner.cpp:
3457         * DumpRenderTree/TestRunner.h:
3458         * DumpRenderTree/WorkQueue.cpp:
3459         * DumpRenderTree/WorkQueue.h:
3460         * DumpRenderTree/WorkQueueItem.h:
3461         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3462         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3463         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3464         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3465         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3466         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3467         * DumpRenderTree/efl/EditingCallbacks.cpp:
3468         * DumpRenderTree/efl/EditingCallbacks.h:
3469         * DumpRenderTree/efl/EventSender.cpp:
3470         * DumpRenderTree/efl/EventSender.h:
3471         * DumpRenderTree/efl/GCControllerEfl.cpp:
3472         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3473         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3475         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3476         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3477         * DumpRenderTree/gtk/EditingCallbacks.h:
3478         * DumpRenderTree/gtk/EventSender.cpp:
3479         * DumpRenderTree/gtk/EventSender.h:
3480         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3481         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3482         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3483         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3484         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3485         * DumpRenderTree/gtk/TextInputController.cpp:
3486         * DumpRenderTree/gtk/TextInputController.h:
3487         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3488         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3489         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3490         * DumpRenderTree/mac/AppleScriptController.h:
3491         * DumpRenderTree/mac/AppleScriptController.m:
3492         * DumpRenderTree/mac/CheckedMalloc.cpp:
3493         * DumpRenderTree/mac/CheckedMalloc.h:
3494         * DumpRenderTree/mac/DumpRenderTree.mm:
3495         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3496         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3497         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3498         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3499         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3500         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3501         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3502         * DumpRenderTree/mac/EditingDelegate.h:
3503         * DumpRenderTree/mac/EditingDelegate.mm:
3504         * DumpRenderTree/mac/EventSendingController.h:
3505         * DumpRenderTree/mac/EventSendingController.mm:
3506         * DumpRenderTree/mac/FrameLoadDelegate.h:
3507         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3508         * DumpRenderTree/mac/GCControllerMac.mm:
3509         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3510         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3511         * DumpRenderTree/mac/NavigationController.h:
3512         * DumpRenderTree/mac/NavigationController.m:
3513         * DumpRenderTree/mac/ObjCController.h:
3514         * DumpRenderTree/mac/ObjCController.m:
3515         * DumpRenderTree/mac/ObjCPlugin.h:
3516         * DumpRenderTree/mac/ObjCPlugin.m:
3517         * DumpRenderTree/mac/ObjCPluginFunction.h:
3518         * DumpRenderTree/mac/ObjCPluginFunction.m:
3519         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3520         * DumpRenderTree/mac/PolicyDelegate.h:
3521         * DumpRenderTree/mac/PolicyDelegate.mm:
3522         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3523         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3524         * DumpRenderTree/mac/TestRunnerMac.mm:
3525         * DumpRenderTree/mac/TextInputController.h:
3526         * DumpRenderTree/mac/TextInputController.m:
3527         * DumpRenderTree/mac/UIDelegate.h:
3528         * DumpRenderTree/mac/UIDelegate.mm:
3529         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3530         * DumpRenderTree/win/DRTDataObject.cpp:
3531         * DumpRenderTree/win/DRTDataObject.h:
3532         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3533         * DumpRenderTree/win/DRTDropSource.cpp:
3534         * DumpRenderTree/win/DRTDropSource.h:
3535         * DumpRenderTree/win/DraggingInfo.h:
3536         * DumpRenderTree/win/DumpRenderTree.cpp:
3537         * DumpRenderTree/win/DumpRenderTreeWin.h:
3538         * DumpRenderTree/win/EditingDelegate.cpp:
3539         * DumpRenderTree/win/EditingDelegate.h:
3540         * DumpRenderTree/win/EventSender.cpp:
3541         * DumpRenderTree/win/EventSender.h:
3542         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3543         * DumpRenderTree/win/FrameLoadDelegate.h:
3544         * DumpRenderTree/win/GCControllerWin.cpp:
3545         * DumpRenderTree/win/HistoryDelegate.cpp:
3546         * DumpRenderTree/win/HistoryDelegate.h:
3547         * DumpRenderTree/win/MD5.cpp:
3548         * DumpRenderTree/win/MD5.h:
3549         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3550         * DumpRenderTree/win/PolicyDelegate.cpp:
3551         * DumpRenderTree/win/PolicyDelegate.h:
3552         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3553         * DumpRenderTree/win/ResourceLoadDelegate.h:
3554         * DumpRenderTree/win/TestRunnerWin.cpp:
3555         * DumpRenderTree/win/TextInputController.cpp:
3556         * DumpRenderTree/win/TextInputController.h:
3557         * DumpRenderTree/win/TextInputControllerWin.cpp:
3558         * DumpRenderTree/win/UIDelegate.cpp:
3559         * DumpRenderTree/win/UIDelegate.h:
3560         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3561         * EWebLauncher/main.c:
3562         * GtkLauncher/main.c:
3563         * ImageDiff/efl/ImageDiff.cpp:
3564         * ImageDiff/gtk/ImageDiff.cpp:
3565         * MiniBrowser/gtk/main.c:
3566         * Scripts/SpacingHeuristics.pm:
3567         * Scripts/VCSUtils.pm:
3568         * Scripts/bisect-builds:
3569         * Scripts/build-dumprendertree:
3570         * Scripts/build-jsc:
3571         * Scripts/build-webkit:
3572         * Scripts/check-dom-results:
3573         * Scripts/check-for-exit-time-destructors:
3574         * Scripts/check-for-global-initializers:
3575         * Scripts/commit-log-editor:
3576         * Scripts/compare-timing-files:
3577         * Scripts/debug-minibrowser:
3578         * Scripts/debug-safari:
3579         * Scripts/do-file-rename:
3580         * Scripts/find-extra-includes:
3581         * Scripts/generate-coverage-data:
3582         * Scripts/make-script-test-wrappers:
3583         * Scripts/malloc-tree:
3584         * Scripts/old-run-webkit-tests:
3585         * Scripts/parse-malloc-history:
3586         * Scripts/report-include-statistics:
3587         * Scripts/resolve-ChangeLogs:
3588         * Scripts/run-bindings-tests:
3589         * Scripts/run-iexploder-tests:
3590         * Scripts/run-javascriptcore-tests:
3591         * Scripts/run-jsc:
3592         * Scripts/run-launcher:
3593         * Scripts/run-leaks:
3594         * Scripts/run-mangleme-tests:
3595         * Scripts/run-minibrowser:
3596         * Scripts/run-pageloadtest:
3597         * Scripts/run-regexp-tests:
3598         * Scripts/run-safari:
3599         * Scripts/run-sunspider:
3600         * Scripts/run-webkit-app:
3601         * Scripts/sampstat:
3602         * Scripts/set-webkit-configuration:
3603         * Scripts/sort-Xcode-project-file:
3604         * Scripts/sort-export-file:
3605         * Scripts/split-file-by-class:
3606         * Scripts/sunspider-compare-results:
3607         * Scripts/svn-apply:
3608         * Scripts/svn-create-patch:
3609         * Scripts/svn-unapply:
3610         * Scripts/test-webkit-scripts:
3611         * Scripts/update-javascriptcore-test-results:
3612         * Scripts/update-webkit:
3613         * Scripts/update-webkit-auxiliary-libs:
3614         * Scripts/update-webkit-dependency:
3615         * Scripts/update-webkit-localizable-strings:
3616         * Scripts/update-webkit-support-libs:
3617         * Scripts/update-webkit-wincairo-libs:
3618         * Scripts/webkit-build-directory:
3619         * Scripts/webkitdirs.pm:
3620         (installedSafariPath):
3621         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3622         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3623         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3624         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3625         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3626         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3627         * Scripts/webkitperl/features.pm:
3628         * Scripts/webkitperl/httpd.pm:
3629         * Scripts/webkitpy/bindings/main.py:
3630         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3631         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3632         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3633         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3634         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3635         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3636         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3637         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3638         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3639         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3640         * WebKitTestRunner/PixelDumpSupport.cpp:
3641         * WebKitTestRunner/PixelDumpSupport.h:
3642         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3643         * WinLauncher/WinLauncher.cpp:
3644         * WinLauncher/WinLauncher.h:
3645         * WinLauncher/stdafx.cpp:
3646         * WinLauncher/stdafx.h:
3647
3648 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3649
3650         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3651         https://bugs.webkit.org/show_bug.cgi?id=130265
3652
3653         Reviewed by Michael Saboff.
3654
3655         * Scripts/build-webkit:
3656         * Scripts/copy-webkitlibraries-to-product-directory:
3657
3658 2014-03-14  Landry Breuil  <landry@openbsd.org>
3659
3660         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3661         Also allow to set MAKE in the environment.
3662         https://bugs.webkit.org/show_bug.cgi?id=129991
3663
3664         Reviewed by Andreas Kling.
3665
3666         * Scripts/webkitdirs.pm:
3667         (determineArchitecture):
3668         (determineNumberOfCPUs):
3669         (isBSD):
3670         (buildAutotoolsProject):
3671         * Scripts/webkitpy/common/system/platforminfo.py:
3672         (PlatformInfo.__init__):
3673         (PlatformInfo.is_openbsd):
3674         (PlatformInfo):
3675         (PlatformInfo.is_netbsd):
3676         (PlatformInfo._determine_os_name):
3677
3678 2014-03-14  Dean Jackson  <dino@apple.com>
3679
3680         Remove libWebKitSystemInterfaceLion.a
3681         https://bugs.webkit.org/show_bug.cgi?id=130254
3682
3683         Reviewed by Geoffrey Garen and Andreas Kling.
3684
3685         No need to copy the Lion libraries into the build.
3686
3687         * Scripts/copy-webkitlibraries-to-product-directory:
3688
3689 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3690
3691         [EFL][MiniBrowser] Revise help messages of command line parameters
3692         https://bugs.webkit.org/show_bug.cgi?id=130222
3693
3694         Reviewed by Csaba Osztrogonác.
3695
3696         Correct the default value description and make help messages to be consistent.
3697
3698         * MiniBrowser/efl/main.c:
3699
3700 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3701
3702         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3703         https://bugs.webkit.org/show_bug.cgi?id=129612
3704
3705         Reviewed by Darin Adler.
3706
3707         For new code use static NeverDestroyed<T> instead.
3708
3709         * DumpRenderTree/JavaScriptThreading.cpp:
3710         (javaScriptThreadsMutex):
3711         (javaScriptThreads):
3712         * DumpRenderTree/efl/EventSender.cpp:
3713         (touchPointList):
3714         (delayedEventQueue):
3715         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3716         (delegatesWithDelayedWork):
3717         * Scripts/check-for-exit-time-destructors:
3718         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3719         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3720         (testsMap):
3721
3722 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3723
3724         [EFL][WK2] Fix compilation warning in Minibrowser
3725         https://bugs.webkit.org/show_bug.cgi?id=130132
3726
3727         Reviewed by Csaba Osztrogonác.
3728
3729         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3730
3731         * MiniBrowser/efl/main.c:
3732         (on_download_request):
3733
3734 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3735
3736         FTL should support IsBlah
3737         https://bugs.webkit.org/show_bug.cgi?id=130202
3738
3739         Reviewed by Geoffrey Garen.
3740         
3741         Running existing JSRegress tests with noInline gives us coverage for these
3742         changes. Chances are, this will also give coverage for other interesting things
3743         as well.
3744
3745         * Scripts/run-jsc-stress-tests:
3746
3747 2014-03-12  Brian Burg  <bburg@apple.com>
3748
3749         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3750         https://bugs.webkit.org/show_bug.cgi?id=129744
3751
3752         Reviewed by Timothy Hatcher.
3753
3754         * DumpRenderTree/TestRunner.cpp:
3755         (evaluateInWebInspectorCallback):
3756         * DumpRenderTree/TestRunner.h:
3757         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3758         (TestRunner::evaluateInWebInspector):
3759         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3760         (TestRunner::evaluateInWebInspector):
3761         * DumpRenderTree/mac/TestRunnerMac.mm:
3762         (TestRunner::evaluateInWebInspector):
3763         * DumpRenderTree/win/TestRunnerWin.cpp:
3764         (TestRunner::evaluateInWebInspector):
3765         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3766         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3767         (WTR::TestRunner::evaluateInWebInspector):
3768         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3769
3770 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3771
3772         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3773         https://bugs.webkit.org/show_bug.cgi?id=130129
3774
3775         Reviewed by Csaba Osztrogonác.
3776
3777         * Scripts/webkitdirs.pm:
3778         (canUseNinja): Redirecting stderr to /dev/null
3779
3780 2014-03-13  Andres Gomez  <agomez@igalia.com>
3781
3782         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3783         https://bugs.webkit.org/show_bug.cgi?id=130092
3784
3785         Reviewed by Csaba Osztrogonác.
3786
3787         Added "python-dev" as dependency for deb based distros. It is
3788         already present for rpm based distros. This dependency will allow
3789         libxml2 to generate its python bindings, needed by gtk-doc.
3790
3791         * gtk/install-dependencies:
3792
3793 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3794
3795         Unreviewed. Fix GTK+ cmake build after r165488.
3796
3797         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3798
3799 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3800
3801         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3802         https://bugs.webkit.org/show_bug.cgi?id=130014
3803
3804         Reviewed by Martin Robinson.
3805
3806         Include cmake or autotools config header.
3807
3808         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3809         * MiniBrowser/gtk/BrowserSearchBar.c:
3810         * MiniBrowser/gtk/BrowserWindow.c:
3811         * MiniBrowser/gtk/main.c:
3812
3813 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3814
3815         Unreviewed, rolling out r165471.
3816         https://bugs.webkit.org/show_bug.cgi?id=130139
3817
3818         Didn't really fix the issue and broke another bot (Requested
3819         by mrobinson on #webkit).
3820
3821         Reverted changeset:
3822
3823         "[CMake] Newer versions of CMake cannot find older versions of
3824         Freetype"
3825         https://bugs.webkit.org/show_bug.cgi?id=130107
3826         http://trac.webkit.org/changeset/165471
3827
3828 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3829
3830         It should be possible to build WebKit with FTL on iOS
3831         https://bugs.webkit.org/show_bug.cgi?id=130116
3832
3833         Reviewed by Dan Bernstein.
3834
3835         * Scripts/build-webkit:
3836         * Scripts/copy-webkitlibraries-to-product-directory:
3837
3838 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3839
3840         [Win] Remove use of QTSDK
3841         https://bugs.webkit.org/show_bug.cgi?id=130049
3842
3843         Reviewed by Darin Adler.
3844
3845         * DumpRenderTree/win/DumpRenderTree.cpp:
3846         (initialize): Remove QuickTime code.
3847         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3848         building QTMovieWin.
3849
3850 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3851
3852         [GTK][CMAKE] Too verbose build output
3853         https://bugs.webkit.org/show_bug.cgi?id=130076
3854
3855         Reviewed by Carlos Garcia Campos.
3856
3857         Instead of building with cmake --build which isn't smart about pretty printing and
3858         colors, we build with a script which calls the proper build command.
3859
3860         * Scripts/webkitdirs.pm:
3861         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3862         the CMake configuration pass.
3863
3864 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3865
3866         [CMake] Newer versions of CMake cannot find older versions of Freetype
3867         https://bugs.webkit.org/show_bug.cgi?id=130107
3868
3869         Reviewed by Gustavo Noronha Silva.
3870
3871         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3872         to CMake during jhbuild initialization.
3873
3874 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3875
3876         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3877         https://bugs.webkit.org/show_bug.cgi?id=129961
3878
3879         Reviewed by Simon Fraser.
3880
3881         Now scaled content can go through the window capturing mechanism too for compositing content.
3882         AppleMagnifiedMode is redundant.
3883
3884         * DumpRenderTree/mac/DumpRenderTree.mm:
3885         (setDefaultsToConsistentValuesForTesting):
3886         (runTest):
3887         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3888         (createBitmapContextFromWebView):
3889         * WebKitTestRunner/PlatformWebView.h:
3890         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3891         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3892         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3893         (WTR::PlatformWebView::didInitializeClients):
3894         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3895         (WTR::PlatformWebView::forceWindowFramesChanged):
3896         * WebKitTestRunner/mac/main.mm:
3897         (setDefaultsToConsistentValuesForTesting):
3898
3899 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3900
3901         Unreviewed. Add myself as a committer.
3902
3903         * Scripts/webkitpy/common/config/contributors.json:
3904
3905 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3906
3907         Unreviewed build fix on the EFL port when used lower version of ATK
3908
3909         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3910         (WTR::AccessibilityUIElement::y): Fixed typo.
3911
3912 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3913
3914         Some images are blank in the rebaseline server UI
3915         https://bugs.webkit.org/show_bug.cgi?id=130104
3916
3917         Reviewed by Tim Horton.
3918
3919         Let the server check for images in the 'retries' directory
3920         if it can't find an image otherwise.
3921
3922         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3923         (RebaselineHTTPRequestHandler.test_result):
3924
3925 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3926
3927         [GTK][CMake] --update-gtk has no effect
3928         https://bugs.webkit.org/show_bug.cgi?id=130088
3929
3930         Reviewed by Philippe Normand.
3931
3932         * Scripts/webkitdirs.pm:
3933         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3934         as an argument.
3935
3936 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3937
3938         Add "System Font" to the list of whitelisted DRT fonts
3939         https://bugs.webkit.org/show_bug.cgi?id=130046
3940
3941         Reviewed by Darin Adler.
3942
3943         * DumpRenderTree/mac/DumpRenderTree.mm:
3944         (allowedFontFamilySet):
3945         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3946
3947 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3948
3949         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3950         https://bugs.webkit.org/show_bug.cgi?id=130064
3951
3952         Reviewed by Philippe Normand.
3953
3954         * efl/jhbuildrc: Remove duplicated code.
3955         * gtk/jhbuildrc: Remove duplicated code.
3956         * jhbuild/jhbuildrc_common.py:
3957         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3958         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3959         and is apparently necessary for GTK+.
3960
3961 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3962
3963         check-webkit-style failed to complain about missing braces
3964         https://bugs.webkit.org/show_bug.cgi?id=34189
3965
3966         Reviewed by Ryosuke Niwa.
3967
3968         * Scripts/webkitpy/style/checkers/cpp.py:
3969         (check_braces):
3970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3971         (WebKitStyleTest.test_braces):
3972
3973 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3974
3975         Remove Qt cruft from style checker.
3976         https://bugs.webkit.org/show_bug.cgi?id=130085
3977
3978         Reviewed by Csaba Osztrogonác.
3979
3980         There is no 'foreach' keyword in c++. That was a Qt feature
3981         added in: http://trac.webkit.org/changeset/46113
3982         Qt was removed from WebKit, so we should remove the checks
3983         of this keyword from check-webkit-style scripts.
3984
3985         * Scripts/webkitpy/style/checkers/cpp.py:
3986         (check_spacing_for_function_call):
3987         (check_spacing):
3988         (check_braces):
3989         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3990         (CppStyleTest.test_mismatching_spaces_in_parens):
3991         (CppStyleTest.test_spacing_for_fncall):
3992         (WebKitStyleTest.test_braces):
3993
3994 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3995
3996         [GTK] update-webkitgtk-libs needs itstool
3997         https://bugs.webkit.org/show_bug.cgi?id=130082
3998
3999         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
4000         itstool is a dependency of building gtk-doc from version 1.19, so it should
4001         be added to Tools/gtk/install-dependencies script, too.
4002
4003         Reviewed by Philippe Normand.
4004
4005         * gtk/install-dependencies:
4006
4007 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4008
4009         webkitbot rollout ChangeLogs should be nicer
4010         https://bugs.webkit.org/show_bug.cgi?id=122654
4011
4012         Reviewed by Csaba Osztrogonác.
4013
4014         Added bug urls and descriptions of rolled out patches to the rollout changelog
4015         if they are present in the original changelog. Additionally removed the list of
4016         changed files and functions.
4017
4018         * Scripts/webkitpy/common/checkout/changelog.py:
4019         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
4020         * Scripts/webkitpy/common/checkout/checkout.py:
4021         (Checkout._changelog_data_for_revision): Store bug description.
4022         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4023         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4024         (CheckoutTest.test_commit_info_for_revision):
4025         * Scripts/webkitpy/common/checkout/commitinfo.py:
4026         (CommitInfo.bug_description): Added.
4027         (CommitInfo.to_json):
4028         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4029         (CommitInfoTest.test_commit_info_creation):
4030         * Scripts/webkitpy/tool/commands/download.py:
4031         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
4032         out patches for creating rollout changelog.
4033         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
4034         caused the regression is stored in state["bug_blocked"] now.
4035         * Scripts/webkitpy/tool/commands/download_unittest.py:
4036         (test_prepare_rollout):
4037         (test_create_rollout_multiple_revision):
4038         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4039         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
4040         rolled out patches to the changelog.
4041         (PrepareChangeLogForRevert.run):
4042         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
4043         (UpdateChangeLogsForRevertTest):
4044         (test_message_for_revert):
4045         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4046         (ReopenBugAfterRollout.run):
4047
4048 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
4049
4050         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
4051         https://bugs.webkit.org/show_bug.cgi?id=130021
4052
4053         Reviewed by Mario Sanchez Prada.
4054
4055         Replace deprecated functions to use new API from ATK 2.11.90.
4056
4057         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4058         (AccessibilityUIElement::x):
4059         (AccessibilityUIElement::y):
4060         (AccessibilityUIElement::width):
4061         (AccessibilityUIElement::height):
4062         (AccessibilityUIElement::clickPointX):
4063         (AccessibilityUIElement::clickPointY):
4064         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4065         (WTR::AccessibilityUIElement::x):
4066         (WTR::AccessibilityUIElement::y):
4067         (WTR::AccessibilityUIElement::width):
4068         (WTR::AccessibilityUIElement::height):
4069         (WTR::AccessibilityUIElement::clickPointX):
4070         (WTR::AccessibilityUIElement::clickPointY):
4071
4072 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
4073
4074         [ATK] Expose aria-posinset and aria-setsize through object attributes
4075         https://bugs.webkit.org/show_bug.cgi?id=130011
4076
4077         Reviewed by Chris Fleizach.
4078
4079         Added missing implementation of numberAttributeValue both to WKTR and DRT.
4080
4081         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4082         (AccessibilityUIElement::numberAttributeValue):
4083         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4084         (WTR::AccessibilityUIElement::numberAttributeValue):
4085
4086 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4087
4088         [Win] Unreviewed build fix.
4089
4090         Some bad Windows code was committed at some point that prevents the Apple Windows port
4091         from finding its runtime dependencies reliably.
4092
4093         * win/DLLLauncher/DLLLauncherMain.cpp:
4094         (appleApplicationSupportDirectory): Restored this function.
4095         (modifyPath): Update to use appleApplicationSupportDirectory function.
4096
4097 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
4098
4099         Let the user define the full address of the performance-site-server for uploading results
4100         https://bugs.webkit.org/show_bug.cgi?id=129819
4101
4102         Reviewed by Ryosuke Niwa.
4103
4104         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
4105         can be confusing. It's more straightforward, if you need to define explicitly the server's full
4106         address along with the protocol, when you're using this parameter. I added HTTPS as the default
4107         protocol for now, in order to avoid breaking the perf bots.
4108
4109         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4110         (_upload_json):
4111         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4112         (MainTest.test_upload_json):
4113
4114 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4115
4116         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
4117         https://bugs.webkit.org/show_bug.cgi?id=130023
4118
4119         Reviewed by Dean Jackson.
4120
4121         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
4122         /SAFESEH flag to DLL launcher process.
4123
4124 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4125
4126         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
4127         https://bugs.webkit.org/show_bug.cgi?id=129980
4128
4129         Reviewed by Carlos Garcia Campos.
4130
4131         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
4132
4133 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4134
4135         [GTK] Remove the WebView source-mode WebKit1 test
4136         https://bugs.webkit.org/show_bug.cgi?id=129976
4137
4138         Reviewed by Carlos Garcia Campos.
4139
4140         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
4141
4142 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
4143
4144         Unreviewed build fix for GTKbuild after the switch to CMake
4145
4146         * gtk/common.py:
4147         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
4148         test-only bot doesn't have any build files.
4149
4150 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4151
4152         [GTK] built-product-archive does not handle GTK+ CMake build
4153         https://bugs.webkit.org/show_bug.cgi?id=129941
4154
4155         * BuildSlaveSupport/built-product-archive:
4156         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
4157         the CMake build.
4158
4159 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
4160
4161         [GTK] Include CMake into install-dependencies script
4162         https://bugs.webkit.org/show_bug.cgi?id=129909
4163
4164         Reviewed by Martin Robinson.
4165
4166         As since r165267 buid-webkit uses CMake by default, the dependency
4167         with 'cmake' package should be introduced.
4168
4169         * gtk/install-dependencies: Ditto.
4170
4171 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4172
4173         REGRESSION(165267): Broke a webkitpy unit tests
4174         https://bugs.webkit.org/show_bug.cgi?id=129904
4175
4176         Reviewed by Jon Honeycutt.
4177
4178         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
4179         (GtkPort._is_cmake_build):
4180
4181 2014-03-07  Andres Gomez  <agomez@igalia.com>
4182
4183         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
4184         https://bugs.webkit.org/show_bug.cgi?id=129893
4185
4186         Reviewed by Martin Robinson.
4187
4188         Added "git-svn" as dependency for deb based distros and,
4189         additionally, "subversion" for rpm based distros.
4190
4191         * gtk/install-dependencies:
4192
4193 2014-03-07  Roger Fong  <roger_fong@apple.com>
4194
4195         Remove dummy setSystemWebGLLoadPolicy client method.
4196         https://bugs.webkit.org/show_bug.cgi?id=129873.
4197
4198         Reviewed by Dean Jackson.
4199
4200         * WebKitTestRunner/TestController.cpp:
4201         (WTR::TestController::createWebViewWithOptions):
4202
4203 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
4204
4205         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
4206         https://bugs.webkit.org/show_bug.cgi?id=129886
4207
4208         Reviewed by Mark Lam.
4209
4210         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
4211         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
4212         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
4213         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
4214         make it through when in non-verbose mode.
4215
4216 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4217
4218         [GTK] buid-webkit should use CMake by default
4219         https://bugs.webkit.org/show_bug.cgi?id=129855
4220
4221         Reviewed by Carlos Garcia Campos.
4222
4223         Make the CMake build the default GTK+ build when using build-webkit. This will
4224         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
4225         so that we have --gtk and --gtkautotools.
4226
4227         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
4228         * Scripts/webkitpy/port/gtk.py: Ditto.
4229
4230 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
4231
4232         [CMake] [GTK] Build with ninja when it is available
4233         https://bugs.webkit.org/show_bug.cgi?id=129805
4234
4235         Reviewed by Philippe Normand.
4236
4237         * Scripts/webkitdirs.pm:
4238         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
4239         if it's available on the system.
4240         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
4241         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
4242
4243 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
4244
4245         If the FTL is build-time enabled then it should be run-time enabled.
4246
4247         Rubber stamped by Geoffrey Garen.
4248
4249         * Scripts/run-jsc-stress-tests:
4250
4251 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
4252
4253         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
4254         https://bugs.webkit.org/show_bug.cgi?id=129837
4255
4256         Reviewed by Michael Saboff.
4257
4258         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
4259         The fix is to use find instead of ls like we do in shell-runner.sh.
4260
4261         * Scripts/run-jsc-stress-tests:
4262
4263 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
4264
4265         filter-build-webkit should not strip .o
4266         https://bugs.webkit.org/show_bug.cgi?id=129614
4267
4268         Reviewed by Dean Jackson.
4269
4270         This makes it much easier to jump from the failing output at
4271         the end back up to the compile errors earlier in the output.
4272
4273         * Scripts/filter-build-webkit:
4274
4275 2014-03-06  Anders Carlsson  <andersca@apple.com>
4276
4277         Build WebKit2 before building WebKit
4278         https://bugs.webkit.org/show_bug.cgi?id=129831
4279         <rdar://problem/15920020>
4280
4281         Reviewed by Dan Bernstein.
4282
4283         * Scripts/build-webkit:
4284         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4285
4286 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4287
4288         make-3.82 fails to build on ARM/Linux
4289         https://bugs.webkit.org/show_bug.cgi?id=107926
4290
4291         Reviewed by Martin Robinson.
4292
4293         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4294         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4295         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4296         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4297
4298         * gtk/patches/make-3.82-arg-list-length.patch:
4299
4300 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4301
4302         [GTK] Close the page when the view is disposed instead of when finalized
4303         https://bugs.webkit.org/show_bug.cgi?id=129783
4304
4305         Reviewed by Sergio Villar Senin.
4306
4307         Add test case but disabled for now because it's affetected by bug #129684.
4308
4309         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4310         (testProcessPerWebView):
4311
4312 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4313
4314         [GTK] MiniBrowser crashes when opening several urls passed as command line options
4315         https://bugs.webkit.org/show_bug.cgi?id=129738
4316
4317         Reviewed by Sergio Villar Senin.
4318
4319         The problem is that we are calling g_object_unref() for the
4320         WebKitWebSettings everytime we set it to a WebKitWebView, but the
4321         view only increases the reference counter when the settings is not
4322         the same it currently has. We should release our reference once.
4323
4324         * MiniBrowser/gtk/main.c:
4325         (createBrowserWindow):
4326         (main):
4327
4328 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4329
4330         [GTK][CMake] Tarball is created with wrong tarball paths
4331         https://bugs.webkit.org/show_bug.cgi?id=129496
4332
4333         Reviewed by Daniel Bates.