Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-06  Keith Rollin  <krollin@apple.com>
2
3         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
4         https://bugs.webkit.org/show_bug.cgi?id=193975
5         <rdar://problem/47643306>
6
7         Reviewed by Tim Horton.
8
9         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
10         the Info.plist file into the bundle. This step is not necessary as the
11         implicit "bundle up all the build products into a framework" build
12         phase does this already. Having the Copy Bundle Resources phase do
13         this causes a conflict under XCBuild, which objects to two build
14         phases producing the same file (Info.plist). Address this by removing
15         Info.plist from the Copy Bundle Resources phase.
16
17         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
18
19 2019-02-06  Keith Rollin  <krollin@apple.com>
20
21         Really enable the automatic checking and regenerations of .xcfilelists during builds
22         https://bugs.webkit.org/show_bug.cgi?id=194357
23         <rdar://problem/47861231>
24
25         Reviewed by Chris Dumez.
26
27         Bug 194124 was supposed to enable the automatic checking and
28         regenerating of .xcfilelist files during the build. While related
29         changes were included in that patch, the change to actually enable the
30         operation somehow was omitted. This patch actually enables the
31         operation. The check-xcfilelist.sh scripts now check
32         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
33         from the checking.
34
35         * DumpRenderTree/Scripts/check-xcfilelists.sh:
36         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
37
38 2019-02-06  David Kilzer  <ddkilzer@apple.com>
39
40         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
41         <https://webkit.org/b/194286>
42         <rdar://problem/47815558>
43
44         Reviewed by Alexey Proskuryakov.
45
46         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
47         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
48         WKRetainPtr<> to avoid leaking the WKDataRef.
49
50 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
51
52         Unreviewed, fix a typo
53
54         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
55
56 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
57
58         [GTK][WPE] force libpsl build to use ICU in jhbuild
59         https://bugs.webkit.org/show_bug.cgi?id=194288
60
61         Reviewed by Carlos Garcia Campos.
62
63         * gtk/jhbuild.modules:
64         Require ICU for libpsl build in jhbuild, like done in WPE.
65
66 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
67
68         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
69         https://bugs.webkit.org/show_bug.cgi?id=194209
70
71         Reviewed by Carlos Garcia Campos.
72
73         Enhance TestCookieManager to ensure this doesn't happen again.
74
75         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
76         (testCookieManagerPersistentStorage):
77         (beforeAll):
78
79 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
80
81         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
82         https://bugs.webkit.org/show_bug.cgi?id=194324
83
84         Reviewed by Andy Estes.
85
86         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
87         part of the name is already implicit, since this is in testing code in TestOptions.
88
89         * WebKitTestRunner/TestController.cpp:
90         (WTR::TestController::generateContextConfiguration const):
91         (WTR::updateTestOptionsFromTestHeader):
92         * WebKitTestRunner/TestOptions.h:
93         (WTR::TestOptions::hasSameInitializationOptions const):
94
95 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
96
97         [ews-build] Allow * as platform for builders and workers
98         https://bugs.webkit.org/show_bug.cgi?id=188533
99
100         Reviewed by Lucas Forschler.
101
102         * BuildSlaveSupport/ews-build/loadConfig.py:
103         (checkWorkersAndBuildersForConsistency):
104
105 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
106
107         [ews-build] Add few bots to config.json
108         https://bugs.webkit.org/show_bug.cgi?id=194304
109
110         Reviewed by Lucas Forschler.
111
112         * BuildSlaveSupport/ews-build/config.json:
113
114 2019-02-05  Keith Rollin  <krollin@apple.com>
115
116         Enable the automatic checking and regenerations of .xcfilelists during builds
117         https://bugs.webkit.org/show_bug.cgi?id=194124
118         <rdar://problem/47721277>
119
120         Reviewed by Tim Horton.
121
122         Bug 193790 add a facility for checking -- during build time -- that
123         any needed .xcfilelist files are up-to-date and for updating them if
124         they are not. This facility was initially opt-in by setting
125         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
126         the process seemed robust. Its now time to enable this facility and
127         make it opt-out. If there is a need to disable this facility, set and
128         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
129         running `make` or `build-webkit`, or before running Xcode from the
130         command line.
131
132         Additionally, remove the step that generates a list of source files
133         going into the UnifiedSources build step. It's only necessarily to
134         specify Sources.txt and SourcesCocoa.txt as inputs.
135
136         * Scripts/generate-xcfilelists:
137
138 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
139
140         [GTK][WPE] force libpsl build to use ICU in jhbuild
141         https://bugs.webkit.org/show_bug.cgi?id=194288
142
143         Reviewed by Philippe Normand.
144
145         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
146         This can cause build failures if libidn is detected but libunistring is not available.
147
148         Make sure that ICU is used for runtime and builtin PSL data.
149
150         * gtk/jhbuild.modules:
151         * wpe/jhbuild.modules:
152
153 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
154
155         [ews-app] Modified timestamp should be updated on updating data
156         https://bugs.webkit.org/show_bug.cgi?id=194295
157
158         Reviewed by Lucas Forschler.
159
160         * BuildSlaveSupport/ews-app/ews/models/build.py:
161         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
162         * BuildSlaveSupport/ews-app/ews/models/step.py:
163
164 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
165
166         Unreviewed, rolling out r240742.
167
168         Causes crashes on iOS simulator.
169
170         Reverted changeset:
171
172         "[iOS] Keyups for non-modifier keys identified as "Dead" when
173         not focused in a content-editable element"
174         https://bugs.webkit.org/show_bug.cgi?id=192824
175         https://trac.webkit.org/changeset/240742
176
177 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
178
179         run-webkit-tests emits message "...running None" when running tests
180         https://bugs.webkit.org/show_bug.cgi?id=194133
181         <rdar://problem/47724738>
182
183         Reviewed by Lucas Forschler.
184
185         * Scripts/webkitpy/xcode/device_type.py:
186         (DeviceType.__str__): Use both version mapping tables and use just the variant
187         name if no version name is available.
188         * Scripts/webkitpy/xcode/device_type_unittest.py:
189         (DeviceTypeTest):
190         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
191         an associated named.
192
193 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
194
195         [WPE] require python3-setuptools for meson build in jhbuild
196         https://bugs.webkit.org/show_bug.cgi?id=194287
197
198         Reviewed by Philippe Normand.
199
200         python3-setuptools is needed to build meson in jhbuild.
201         It is already required by the GTK port.
202
203         * wpe/install-dependencies:
204
205 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
206
207         [ews-app] Add method to save BuilderMapping to database
208         https://bugs.webkit.org/show_bug.cgi?id=194264
209
210         Reviewed by Lucas Forschler.
211
212         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
213         (BuilderMapping.__str__):
214         (BuilderMapping):
215         (BuilderMapping.save_mapping):
216         (BuilderMapping.update_mapping):
217         (BuilderMapping.get_existing_mapping):
218         (BuilderMapping.is_valid_mapping):
219
220 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
221
222         [ews-app] Add timestamp fields for BuilderMappings
223         https://bugs.webkit.org/show_bug.cgi?id=194266
224
225         Reviewed by Lucas Forschler.
226
227         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
228         (BuilderMapping):
229
230 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
231
232         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
233         https://bugs.webkit.org/show_bug.cgi?id=174816
234
235         Reviewed by Michael Catanzaro.
236
237         Add tests for webkit_uri_for_display().
238
239         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
240         (testURIForDisplayUnaffected):
241         (testURIForDisplayAffected):
242         (beforeAll):
243         (afterAll):
244         * TestWebKitAPI/glib/CMakeLists.txt:
245
246 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
247
248         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
249         https://bugs.webkit.org/show_bug.cgi?id=194158
250         <rdar://problem/47737268>
251
252         Rubber-stamped by Aakash Jain.
253
254         * Scripts/webkitpy/port/device_port.py:
255         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
256
257 2019-02-04  Said Abou-Hallawa  <said@apple.com>
258
259         [CG] Enable setAdditionalSupportedImageTypes for WK1
260         https://bugs.webkit.org/show_bug.cgi?id=194190
261
262         Reviewed by Tim Horton.
263
264         Add a test similar to the one under WebKit Cocoa but make it create a
265         WebView instead of a WKWebView.
266
267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
268         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
269         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
270         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
271         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
272         (TestWebKitAPI::runTest):
273         (TestWebKitAPI::TEST):
274
275 2019-02-04  Zalan Bujtas  <zalan@apple.com>
276
277         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
278         https://bugs.webkit.org/show_bug.cgi?id=194168
279
280         Reviewed by Simon Fraser.
281
282         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
283
284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
285         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
286         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
287         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
288         (TEST):
289         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
290         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
291
292 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
293
294         REGRESSION (r237269): webkit-patch what-broke is broken 
295         https://bugs.webkit.org/show_bug.cgi?id=193025
296
297         Reviewed by Aakash Jain.
298
299         * Scripts/webkitpy/common/host.py:
300         (Host.buildbot):
301         (Host.bugzilla): Renamed to 'buildbot'.
302
303 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
304
305         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
306         https://bugs.webkit.org/show_bug.cgi?id=194207
307
308         Reviewed by Tim Horton.
309
310         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
311         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
312         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
313         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
314         start and delete forwards to remove the original attachment.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
317         (TestWebKitAPI::TEST):
318
319 2019-02-04  Youenn Fablet  <youenn@apple.com>
320
321         Capture state should be managed consistently when doing process swapping
322         https://bugs.webkit.org/show_bug.cgi?id=194122
323         <rdar://problem/47609293>
324
325         Reviewed by Eric Carlson.
326
327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
328         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
329         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
330         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
331         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
332         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
333         (WTR::TestRunner::isDoingMediaCapture const):
334         * WebKitTestRunner/InjectedBundle/TestRunner.h:
335         * WebKitTestRunner/TestController.cpp:
336         (WTR::TestController::isDoingMediaCapture const):
337         * WebKitTestRunner/TestController.h:
338         * WebKitTestRunner/TestInvocation.cpp:
339         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
340         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
341         (WTR::TestController::isDoingMediaCapture const):
342
343 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
344
345         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
346         https://bugs.webkit.org/show_bug.cgi?id=194142
347
348         Reviewed by Ross Kirsling.
349
350         There three 'separator' variables in TestController.cpp. Renamed
351         it 'pathSeparator', and unified them.
352
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::TestController::generateContextConfiguration const):
355         (WTR::createTestURL):
356         (WTR::TestController::platformAdjustContext):
357
358 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
359
360         Make setNeedsLayout on the root more explicitly about triggering its side-effects
361         https://bugs.webkit.org/show_bug.cgi?id=194198
362
363         Reviewed by Antti Koivisto.
364
365         No need to set the banner heights on navigation now, since Page stores them.
366
367         * MiniBrowser/mac/WK2BrowserWindowController.m:
368         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
369
370 2019-02-03  John Wilander  <wilander@apple.com>
371
372         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
373         https://bugs.webkit.org/show_bug.cgi?id=194104
374         <rdar://problem/47649991>
375
376         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
377
378         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
379         (TestWebKitAPI::TEST):
380             Changed numeric types from unsigned short to uint32_t.
381
382 2019-02-02  David Kilzer  <ddkilzer@apple.com>
383
384         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
385         <https://webkit.org/b/194178>
386         <rdar://problem/47753473>
387
388         Reviewed by Alexey Proskuryakov.
389
390         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
391         (WTR::uninstallFakeHelvetica): Pass nullptr into
392         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
393
394 2019-02-02  Zalan Bujtas  <zalan@apple.com>
395
396         [LFC] Initialize ICB's style with fixed width/height.
397         https://bugs.webkit.org/show_bug.cgi?id=194188
398
399         Reviewed by Antti Koivisto.
400
401         * LayoutReloaded/misc/LFC-passing-tests.txt:
402
403 2019-02-02  Zalan Bujtas  <zalan@apple.com>
404
405         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
406         https://bugs.webkit.org/show_bug.cgi?id=194185
407
408         Reviewed by Antti Koivisto.
409
410         * LayoutReloaded/misc/LFC-passing-tests.txt:
411
412 2018-12-16  Darin Adler  <darin@apple.com>
413
414         Convert additional String::format clients to alternative approaches
415         https://bugs.webkit.org/show_bug.cgi?id=192746
416
417         Reviewed by Alexey Proskuryakov.
418
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
421         as an intermediate in code that ultimately constructs a WTF::String.
422         (WTR::userMediaOriginHash): Use makeString.
423         (WTR::TestController::didNavigateWithNavigationData): More of the same.
424         (WTR::TestController::didPerformClientRedirect): Ditto.
425         (WTR::TestController::didPerformServerRedirect): Ditto.
426         (WTR::TestController::didUpdateHistoryTitle): Ditto.
427
428 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
429
430         [ews-build] Add unit test to verify builder keys
431         https://bugs.webkit.org/show_bug.cgi?id=194152
432
433         Reviewed by Lucas Forschler.
434
435         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
436         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
437
438 2019-02-01  Zalan Bujtas  <zalan@apple.com>
439
440         [LFC] Expand tests coverage (12 new tests -> 787)
441
442         Unreviewed test gardening.
443
444         * LayoutReloaded/misc/LFC-passing-tests.txt:
445
446 2019-02-01  Zalan Bujtas  <zalan@apple.com>
447
448         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
449         https://bugs.webkit.org/show_bug.cgi?id=194163
450
451         Reviewed by Simon Fraser.
452
453         775
454
455         * LayoutReloaded/misc/LFC-passing-tests.txt:
456
457 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
458
459         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
460         https://bugs.webkit.org/show_bug.cgi?id=194140
461         <rdar://problem/47728098>
462
463         Reviewed by Tim Horton.
464
465         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
467         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
468
469         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
470         test to induce an IPC deadlock when presenting a modal alert during touch start.
471
472         * WebKitTestRunner/InjectedBundle/TestRunner.h:
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::runJavaScriptAlert):
475
476         Add a client callback function for running JavaScript alerts.
477
478         (WTR::TestController::createOtherPage):
479         (WTR::TestController::generateContextConfiguration const):
480
481         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
482         the fix in this patch.
483
484         (WTR::TestController::createWebViewWithOptions):
485
486         Plumb TestOptions to generateContextConfiguration.
487
488         (WTR::TestController::resetPreferencesToConsistentValues):
489         (WTR::TestController::resetStateToConsistentValues):
490         (WTR::updateTestOptionsFromTestHeader):
491         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
492         (WTR::TestController::handleJavaScriptAlert):
493         * WebKitTestRunner/TestController.h:
494         * WebKitTestRunner/TestInvocation.cpp:
495         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
496         * WebKitTestRunner/TestOptions.h:
497         (WTR::TestOptions::hasSameInitializationOptions const):
498
499 2019-02-01  Chris Dumez  <cdumez@apple.com>
500
501         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
502         https://bugs.webkit.org/show_bug.cgi?id=193740
503         <rdar://problem/47527267>
504
505         Reviewed by Alex Christensen.
506
507         Add API test coverage.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
510
511 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
512
513         [ews-app] Add display name field to BuilderMapping model
514         https://bugs.webkit.org/show_bug.cgi?id=194153
515
516         Reviewed by Lucas Forschler.
517
518         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
519         (BuilderMapping):
520
521 2019-02-01  Youenn Fablet  <youenn@apple.com>
522
523         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
524         https://bugs.webkit.org/show_bug.cgi?id=194155
525
526         Reviewed by Eric Carlson.
527
528         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
529         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
530         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
531
532 2019-02-01  Zalan Bujtas  <zalan@apple.com>
533
534         [LFC] Adjust replaced element's intrinsic ratio
535         https://bugs.webkit.org/show_bug.cgi?id=194154
536
537         Reviewed by Antti Koivisto.
538
539         761
540
541         * LayoutReloaded/misc/LFC-passing-tests.txt:
542
543 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         [WPE] Show test results in minibrowser
546         https://bugs.webkit.org/show_bug.cgi?id=194150
547
548         Reviewed by Žan Doberšek.
549
550         * Scripts/webkitpy/port/wpe.py:
551         (WPEPort.show_results_html_file):
552
553 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
554
555         [WPE] MiniBrowser: add ky bindings for back/forward navigation
556         https://bugs.webkit.org/show_bug.cgi?id=194151
557
558         Reviewed by Žan Doberšek.
559
560         ALT + <- go back
561         ALT + -> go forward
562
563         * MiniBrowser/wpe/main.cpp:
564         (main):
565
566 2019-02-01  Zalan Bujtas  <zalan@apple.com>
567
568         [LFC] Set intrinsic size on Layout::Replaced
569         https://bugs.webkit.org/show_bug.cgi?id=194139
570
571         Reviewed by Antti Koivisto.
572
573         744
574
575         * LayoutReloaded/misc/LFC-passing-tests.txt:
576
577 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
580         https://bugs.webkit.org/show_bug.cgi?id=194146
581
582         Reviewed by Xabier Rodriguez-Calvar.
583
584         It allows to open relative paths.
585
586         * MiniBrowser/wpe/main.cpp:
587         (main):
588
589 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
590
591         Update flakiness dashboard configuration after recent queue changes
592         https://bugs.webkit.org/show_bug.cgi?id=194127
593
594         Rubber-stamped by Aakash Jain.
595
596         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
597
598         * TestResultServer/static-dashboards/builders.jsonp:
599
600 2019-01-31  Youenn Fablet  <youenn@apple.com>
601
602         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
603         https://bugs.webkit.org/show_bug.cgi?id=194106
604         <rdar://problem/47676333>
605
606         Reviewed by Ryosuke Niwa.
607
608         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
609         (TestWebKitAPI::didFinishNavigation):
610         (TestWebKitAPI::TEST):
611         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
612
613 2019-01-31  Chris Dumez  <cdumez@apple.com>
614
615         Page zoom level is lost after a process swap or a crash
616         https://bugs.webkit.org/show_bug.cgi?id=194105
617         <rdar://problem/47610781>
618
619         Reviewed by Alex Christensen.
620
621         Add API test coverage.
622
623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
624         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
625
626 2019-01-31  Alex Christensen  <achristensen@webkit.org>
627
628         Revert r238819 which is unneeded and caused a performance regression.
629         https://bugs.webkit.org/show_bug.cgi?id=192272
630         <rdar://problem/46664625>
631
632         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
633         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
634         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
635
636 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
637
638         Formalize WebKitAdditions mechanism of LoadOptimizer
639         https://bugs.webkit.org/show_bug.cgi?id=193886
640         <rdar://problem/47696809>
641
642         Reviewed by Brent Fulgham.
643
644         * MiniBrowser/MiniBrowser.entitlements:
645         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
646
647 2019-01-31  Zalan Bujtas  <zalan@apple.com>
648
649         [LFC] Margin before/after/start/end initial value is 0 and not auto.
650         https://bugs.webkit.org/show_bug.cgi?id=194090
651
652         Reviewed by Antti Koivisto.
653
654         * LayoutReloaded/misc/LFC-passing-tests.txt:
655
656 2019-01-31  Zalan Bujtas  <zalan@apple.com>
657
658         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
659         https://bugs.webkit.org/show_bug.cgi?id=194074
660
661         Reviewed by Antti Koivisto.
662
663         * LayoutReloaded/misc/LFC-passing-tests.txt:
664
665 2019-01-31  Zalan Bujtas  <zalan@apple.com>
666
667         [LFC][BFC] Add support for block level replaced box.
668         https://bugs.webkit.org/show_bug.cgi?id=194071
669
670         Reviewed by Antti Koivisto.
671
672         * LayoutReloaded/misc/LFC-passing-tests.txt:
673
674 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
675
676         Fix WebKitTestRunner's testPath with Windows full paths
677         https://bugs.webkit.org/show_bug.cgi?id=194012
678
679         Reviewed by Alex Christensen.
680
681         updateTestOptionsFromTestHeader failed to open test files because
682         testPath returned wrong file paths. It returned a path "/C:/..."
683         if a URL "file:///C:/..." was given.
684
685         * WebKitTestRunner/TestController.cpp:
686         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
687
688 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
689
690         [WPE] Bump font related dependencies to match the GTK+ port
691         https://bugs.webkit.org/show_bug.cgi?id=194017
692
693         Reviewed by Žan Doberšek.
694
695         * wpe/jhbuild.modules:
696         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
697         * wpe/patches/icudata-stdlibs.patch: Added.
698
699 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
700
701         Enable swipe tests on iOS
702         https://bugs.webkit.org/show_bug.cgi?id=194076
703
704         Reviewed by Geoffrey Garen.
705
706         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
707         it causes a debug assertion failure in runUIScript.
708
709         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
710         (WTR::UIScriptController::beginBackSwipe):
711         (WTR::UIScriptController::completeBackSwipe):
712
713 2019-01-30  Keith Rollin  <krollin@apple.com>
714
715         Use correct printf format specifier
716         https://bugs.webkit.org/show_bug.cgi?id=194062
717         <rdar://problem/47686167>
718
719         Reviewed by Alexey Proskuryakov.
720
721         LayoutTestSpellChecker.mm is trying to format a variable of type
722         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
723         actually an unsigned long long. Fix this by formatting with %llu.
724
725         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
726         (-[LayoutTestTextCheckingResult description]):
727
728 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
729
730         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
731         https://bugs.webkit.org/show_bug.cgi?id=193979
732
733         Reviewed by Wenson Hsieh.
734
735         Fix the test for iOS. Make the test work with iOS UA string.
736
737         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
738
739 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
740
741         Replace High Sierra LLINT CLoop bot due to hardware failure
742         https://bugs.webkit.org/show_bug.cgi?id=194066
743
744         Reviewed by Aakash Jain.
745
746         * BuildSlaveSupport/build.webkit.org-config/config.json:
747
748 2019-01-30  Keith Rollin  <krollin@apple.com>
749
750         [NSDragItem init] is unavailable
751         https://bugs.webkit.org/show_bug.cgi?id=194059
752         <rdar://problem/47685715>
753
754         Reviewed by Wenson Hsieh.
755
756         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
757         DumpRenderTree and TestWebKitAPI, which both try to create an
758         NSDragItem in a manner that invokes this method. Address this by using
759         -initWithPasteboardWriter instead.
760
761         Note that the parameter passed to initWithPasteboardWriter is likely
762         incorrect. In both cases, the object passed does not conform to
763         NSPasteboardWriting. However, with this fix, we're no worse off than
764         before, and can now perform builds with newer compilers and SDKs until
765         a real fix can be crafted. That work is tracked in
766         https://bugs.webkit.org/show_bug.cgi?id=194060
767
768         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
769         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
770         * TestWebKitAPI/mac/TestDraggingInfo.mm:
771         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
772
773 2019-01-30  Daniel Bates  <dabates@apple.com>
774
775         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
776         https://bugs.webkit.org/show_bug.cgi?id=192824
777         <rdar://problem/47100332>
778
779         Reviewed by Wenson Hsieh.
780
781         Fix a bug where the wrong usage code was used for F13 thru F24.
782
783         * WebKitTestRunner/ios/HIDEventGenerator.mm:
784         (keyCodeForDOMFunctionKey):
785
786 2019-01-30  Chris Dumez  <cdumez@apple.com>
787
788         Regression(PSON) Load hang can occur on history navigation
789         https://bugs.webkit.org/show_bug.cgi?id=194030
790         <rdar://problem/47656939>
791
792         Reviewed by Antti Koivisto.
793
794         Add API test coverage.
795
796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
797
798 2019-01-30  Zalan Bujtas  <zalan@apple.com>
799
800         [LFC] Expand tests coverage.
801
802         Unreviewed test gardening.
803
804         * LayoutReloaded/misc/LFC-passing-tests.txt:
805
806 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
807
808         [Flatpak] Add openjpeg support
809         https://bugs.webkit.org/show_bug.cgi?id=194019
810
811         Reviewed by Michael Catanzaro.
812
813         * flatpak/org.webkit.CommonModules.yaml:
814
815 2019-01-30  Commit Queue  <commit-queue@webkit.org>
816
817         Unreviewed, rolling out r240708.
818         https://bugs.webkit.org/show_bug.cgi?id=194022
819
820         It broke WPE build (Requested by KaL on #webkit).
821
822         Reverted changeset:
823
824         "[WPE] Bump font related dependencies to match the GTK+ port"
825         https://bugs.webkit.org/show_bug.cgi?id=194017
826         https://trac.webkit.org/changeset/240708
827
828 2019-01-30  Zalan Bujtas  <zalan@apple.com>
829
830         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
831         https://bugs.webkit.org/show_bug.cgi?id=194001
832
833         Reviewed by Antti Koivisto.
834
835         * LayoutReloaded/misc/LFC-passing-tests.txt:
836
837 2019-01-30  Zalan Bujtas  <zalan@apple.com>
838
839         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
840         https://bugs.webkit.org/show_bug.cgi?id=194020
841
842         Reviewed by Antti Koivisto.
843
844         * LayoutReloaded/misc/LFC-passing-tests.txt:
845
846 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
847
848         AX: Support color well on iOS
849         https://bugs.webkit.org/show_bug.cgi?id=194010
850
851         Reviewed by Joanmarie Diggs.
852
853         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
854         (WTR::AccessibilityUIElement::stringAttributeValue):
855
856 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
857
858         [WPE] Bump font related dependencies to match the GTK+ port
859         https://bugs.webkit.org/show_bug.cgi?id=194017
860
861         Reviewed by Žan Doberšek.
862
863         * wpe/jhbuild.modules:
864         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
865         * wpe/patches/icudata-stdlibs.patch: Added.
866
867 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
868
869         [Mac] Update window scale API usage
870         https://bugs.webkit.org/show_bug.cgi?id=193991
871         rdar://problem/47614795
872
873         Reviewed by Tim Horton.
874
875         * DumpRenderTree/mac/DumpRenderTree.mm:
876         (changeWindowScaleIfNeeded):
877         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
878         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
879         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
880
881 2019-01-29  Chris Dumez  <cdumez@apple.com>
882
883         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
884         https://bugs.webkit.org/show_bug.cgi?id=193977
885         <rdar://problem/47643716>
886
887         Reviewed by Geoff Garen.
888
889         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
890         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
891         to the previous provisional committing *before* we make the last load. 
892
893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
894
895 2019-01-29  Youenn Fablet  <youenn@apple.com>
896
897         Adopt new SPI to evaluate server certificate trust
898         https://bugs.webkit.org/show_bug.cgi?id=193355
899
900         Reviewed by Alex Christensen.
901
902         Add infrastructure to handle HTTPS server trust evaluation testing.
903
904         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
906         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
907         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
908         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::TestController::resetPreferencesToConsistentValues):
912         (WTR::TestController::didReceiveAuthenticationChallenge):
913         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
914         * WebKitTestRunner/TestController.h:
915         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
916         * WebKitTestRunner/TestInvocation.cpp:
917         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
918         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
919         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
920
921 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
922
923         [ews-build] Add build step to print bot Configuration
924         https://bugs.webkit.org/show_bug.cgi?id=193887
925
926         Reviewed by Lucas Forschler.
927
928         * BuildSlaveSupport/ews-build/steps.py:
929         (PrintConfiguration): Build step to print configuration.
930         * BuildSlaveSupport/ews-build/factories.py:
931
932 2019-01-29  Chris Dumez  <cdumez@apple.com>
933
934         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
935         https://bugs.webkit.org/show_bug.cgi?id=193967
936         <rdar://problem/47635348>
937
938         Reviewed by Alex Christensen.
939
940         Add API test coverage.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
943         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
944
945 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
946
947         [ews-app] Handle incoming results data
948         https://bugs.webkit.org/show_bug.cgi?id=193973
949
950         Reviewed by Lucas Forschler.
951
952         * BuildSlaveSupport/ews-app/ews/views/results.py:
953
954 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
955
956         [ews-app] Make the results url generic
957         https://bugs.webkit.org/show_bug.cgi?id=193928
958
959         Reviewed by Lucas Forschler.
960
961         * BuildSlaveSupport/ews-app/ews/urls.py:
962
963 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-build] Configure buildbot to send events to ews-app
966         https://bugs.webkit.org/show_bug.cgi?id=193968
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-build/events.py: Added.
971         * BuildSlaveSupport/ews-build/master.cfg:
972
973 2019-01-29  Keith Rollin  <krollin@apple.com>
974
975         Add .xcfilelists to Run Script build phases
976         https://bugs.webkit.org/show_bug.cgi?id=193792
977         <rdar://problem/47201785>
978
979         Reviewed by Alex Christensen.
980
981         As part of supporting XCBuild, update the necessary Run Script build
982         phases in their Xcode projects to refer to their associated
983         .xcfilelist files.
984
985         Note that the addition of these files bumps the Xcode project version
986         number to something that's Xcode 10 compatible. This change means that
987         older versions of the Xcode IDE can't read these projects. Nor can it
988         fully load workspaces that refer to these projects (the updated
989         projects are shown as non-expandable placeholders). `xcodebuild` can
990         still build these projects; it's just that the IDE can't open them.
991
992         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
993         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
994
995 2019-01-29  John Wilander  <wilander@apple.com>
996
997         Add data abstraction and validation for Ad Click Attribution
998         https://bugs.webkit.org/show_bug.cgi?id=193916
999         <rdar://problem/47603481>
1000
1001         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1002
1003         Ad click attribution has two steps. First, the storage of an ad
1004         campaign ID for a click that takes the user to a destination
1005         site. Second, a conversion on the destination site that can be
1006         attributed to the ad click.
1007
1008         This patch adds a class that represents a request for ad click
1009         attribution. Validation makes sure that the bits of entropy
1010         reported through this mechanism is limited.
1011
1012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1013         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1014         (TestWebKitAPI::TEST):
1015
1016 2019-01-29  Chris Dumez  <cdumez@apple.com>
1017
1018         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1019         https://bugs.webkit.org/show_bug.cgi?id=193932
1020         <rdar://problem/47598947>
1021
1022         Reviewed by Brady Eidson.
1023
1024         Add API test coverage.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1027
1028 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1029
1030         Adding new passing LFC tests.
1031
1032         Unreviewed test gardening.
1033
1034         * LayoutReloaded/misc/LFC-passing-tests.txt:
1035
1036 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1037
1038         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1039         https://bugs.webkit.org/show_bug.cgi?id=193964
1040
1041         Reviewed by Antti Koivisto.
1042
1043         * LayoutReloaded/misc/LFC-passing-tests.txt:
1044
1045 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1046
1047         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1048         https://bugs.webkit.org/show_bug.cgi?id=193954
1049
1050         Reviewed by Antti Koivisto.
1051
1052         * LayoutReloaded/misc/LFC-passing-tests.txt:
1053
1054 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1055
1056         WebDriver: add support for running subtests
1057         https://bugs.webkit.org/show_bug.cgi?id=193904
1058
1059         Reviewed by Michael Catanzaro.
1060
1061         pytest already supports it by passing test.py::subtest, so we can do the same.
1062
1063         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1064         (get_item_name): Made this global.
1065         (CollectRecorder.__init__): Receive the parameter to ignore.
1066         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1067         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1068         (collect): Add parameter to ignore.
1069         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1070         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1071         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1072         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1073         (WebDriverTestRunnerSelenium.run): Ditto.
1074         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1075         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1076         (WebDriverTestRunnerW3C.run): Ditto.
1077
1078 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1079
1080         User agent string override for navigator.userAgent should be site specific quirks
1081         https://bugs.webkit.org/show_bug.cgi?id=193950
1082
1083         Reviewed by Brent Fulgham.
1084
1085         Updated per the _WKWebsitePolicies rename.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1088         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1089
1090 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1091
1092         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1093         https://bugs.webkit.org/show_bug.cgi?id=193941
1094
1095         Reviewed by Alex Christensen.
1096
1097         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1098         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1099         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1100         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1101         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1102         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1103         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1104         * TestWebKitAPI/Tests/WTF/Time.cpp:
1105         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1106         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1107         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1108         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1109
1110 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1111
1112         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1113
1114         * Scripts/webkitpy/common/config/contributors.json:
1115
1116 2019-01-28  Andy Estes  <aestes@apple.com>
1117
1118         [watchOS] Enable Parental Controls content filtering
1119         https://bugs.webkit.org/show_bug.cgi?id=193939
1120         <rdar://problem/46641912>
1121
1122         Reviewed by Ryosuke Niwa.
1123
1124         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1125
1126 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1127
1128         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1129         <https://webkit.org/b/193884>
1130
1131         Reviewed by Jiewen Tan.
1132
1133         * Scripts/webkitpy/style/checkers/cpp.py:
1134         (check_language): Add LocalAuthentication to
1135         `frameworks_with_soft_links`.
1136
1137 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1138
1139         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1140         https://bugs.webkit.org/show_bug.cgi?id=193891
1141
1142         Reviewed by Ross Kirsling.
1143
1144         There were three problems in window sizes of WebView and the host window.
1145         1. The sizes of pixel image output were incorrect.
1146         2. The host window is going to appear after window.resize was invoked.
1147         3. window.resize resized only the host window, not WebView.
1148
1149         This change solves them with a following approach.
1150         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1151         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1152            as well as DumpRenderTree in order to match the client area and the window area.
1153         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1154         d. PlatformWebView::setWindowFrame changes both window sizes.
1155         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1156
1157         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1158         (WTR::PlatformWebView::PlatformWebView): Create the host window
1159         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1160         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1161         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1162
1163 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1164
1165         [ews-app] Add method to save Step data to database
1166         https://bugs.webkit.org/show_bug.cgi?id=193890
1167
1168         Reviewed by Lucas Forschler.
1169
1170         * BuildSlaveSupport/ews-app/ews/models/step.py:
1171         (Step.save_step): Method to save step data.
1172         (Step.update_step): Method to update step data.
1173         (Step.get_existing_step): Method to fetch existing step from database.
1174         (Step.is_valid_result): Method to validate valid step result.
1175
1176 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1177
1178         [ews-app] Add method to save Build data to database
1179         https://bugs.webkit.org/show_bug.cgi?id=193735
1180
1181         Reviewed by Lucas Forschler.
1182
1183         * BuildSlaveSupport/ews-app/ews/models/build.py:
1184         (Build.save_build): Method to save build information to database.
1185         (Build.get_existing_build): Method to fetch existing build from database.
1186         (Build.is_valid_result): Method to validate build result.
1187         * BuildSlaveSupport/ews-app/ews/common/util.py:
1188         (is_valid_int_id): Method to validate valid id.
1189
1190 2019-01-28  Chris Dumez  <cdumez@apple.com>
1191
1192         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1193         https://bugs.webkit.org/show_bug.cgi?id=193915
1194         <rdar://problem/47560907>
1195
1196         Reviewed by Alex Christensen.
1197
1198         Add API test coverage.
1199
1200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1201
1202 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1203
1204         [ews-app] Rename id variables
1205         https://bugs.webkit.org/show_bug.cgi?id=193883
1206
1207         Reviewed by Lucas Forschler.
1208
1209         * BuildSlaveSupport/ews-app/ews/models/build.py:
1210         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1211         * BuildSlaveSupport/ews-app/ews/models/step.py:
1212         * BuildSlaveSupport/ews-app/ews/urls.py:
1213         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1214         * BuildSlaveSupport/ews-app/ews/views/results.py:
1215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1216
1217 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1218
1219         [ews-app] Allow certain fields to be empty
1220         https://bugs.webkit.org/show_bug.cgi?id=193892
1221
1222         Reviewed by Lucas Forschler.
1223
1224         * BuildSlaveSupport/ews-app/ews/models/build.py:
1225         * BuildSlaveSupport/ews-app/ews/models/step.py:
1226
1227 2019-01-28  Rob Buis  <rbuis@igalia.com>
1228
1229         Update MIME type parser
1230         https://bugs.webkit.org/show_bug.cgi?id=180526
1231
1232         Reviewed by Frédéric Wang.
1233
1234         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1235         (TestWebKitAPI::TEST):
1236
1237 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1238
1239         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1240         https://bugs.webkit.org/show_bug.cgi?id=193896
1241
1242         Reviewed by Antti Koivisto.
1243
1244         * LayoutReloaded/misc/LFC-passing-tests.txt:
1245
1246 2018-12-15  Darin Adler  <darin@apple.com>
1247
1248         Replace many uses of String::format with more type-safe alternatives
1249         https://bugs.webkit.org/show_bug.cgi?id=192742
1250
1251         Reviewed by Mark Lam.
1252
1253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1254         (WTR::cacheTestRunnerCallback): Use makeString.
1255         * WebKitTestRunner/TestController.cpp:
1256         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1257         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1258
1259 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1260
1261         Use a load optimizer for some sites
1262         https://bugs.webkit.org/show_bug.cgi?id=193881
1263         <rdar://problem/46325455>
1264
1265         Reviewed by Brent Fulgham.
1266
1267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1268         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1269
1270 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1271
1272         AX: Introduce a static accessibility tree
1273         https://bugs.webkit.org/show_bug.cgi?id=193348
1274         <rdar://problem/47203295>
1275
1276         Reviewed by Ryosuke Niwa.
1277
1278         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1279
1280 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1281
1282         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1283         https://bugs.webkit.org/show_bug.cgi?id=193867
1284
1285         Reviewed by Antti Koivisto.
1286
1287         * LayoutReloaded/misc/LFC-passing-tests.txt:
1288
1289 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1290
1291         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1292         https://bugs.webkit.org/show_bug.cgi?id=193865
1293
1294         Reviewed by Antti Koivisto.
1295
1296         * LayoutReloaded/misc/LFC-passing-tests.txt:
1297
1298 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1299
1300         Need a mechanism to override navigator.userAgent
1301         https://bugs.webkit.org/show_bug.cgi?id=193762
1302         <rdar://problem/47504939>
1303
1304         Reviewed by Brent Fulgham.
1305
1306         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1307
1308         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1309         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1310         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1311
1312 2019-01-25  Dean Jackson  <dino@apple.com>
1313
1314         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1315         https://bugs.webkit.org/show_bug.cgi?id=193831
1316         <rdar://problem/47399263>
1317
1318         Reviewed by Chris Dumez.
1319
1320         Two new tests that exercise cross-origin and same-origin System
1321         Previews.
1322
1323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1324
1325 2019-01-25  Keith Rollin  <krollin@apple.com>
1326
1327         Update Xcode projects with "Check .xcfilelists" build phase
1328         https://bugs.webkit.org/show_bug.cgi?id=193790
1329         <rdar://problem/47201374>
1330
1331         Reviewed by Alex Christensen.
1332
1333         Support for XCBuild includes specifying inputs and outputs to various
1334         Run Script build phases. These inputs and outputs are specified as
1335         .xcfilelist files. Once created, these .xcfilelist files need to be
1336         kept up-to-date. In order to check that they are up-to-date or not,
1337         add an Xcode build step that invokes an external script that performs
1338         the checking. If the .xcfilelists are found to be out-of-date, update
1339         them, halt the build, and instruct the developer to restart the build
1340         with up-to-date files.
1341
1342         At this time, the checking and regenerating is performed only if the
1343         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1344         who want to use this facility can set this variable and test out the
1345         checking/regenerating. Once it seems like there are no egregious
1346         issues that upset a developer's workflow, we'll unconditionally enable
1347         this facility.
1348
1349         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1350         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1351         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1352         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1353
1354 2019-01-25  Keith Rollin  <krollin@apple.com>
1355
1356         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1357         https://bugs.webkit.org/show_bug.cgi?id=193781
1358         <rdar://problem/47201153>
1359
1360         Reviewed by Alex Christensen.
1361
1362         Part of generating the .xcfilelists used as part of adopting XCBuild
1363         includes running `make DerivedSources.make` from a standalone script.
1364         It’s important for this invocation to have the same environment as
1365         when the actual build invokes `make DerivedSources.make`. If the
1366         environments are different, then the two invocations will provide
1367         different results. In order to get the same environment in the
1368         standalone script, have the script launch xcodebuild targeting the
1369         "Apply Configuration to XCFileLists" build target, which will then
1370         re-invoke our standalone script. The script is now running again, this
1371         time in an environment with all workspace, project, target, xcconfig
1372         and other environment variables established.
1373
1374         The "Apply Configuration to XCFileLists" build target accomplishes
1375         this task via a small embedded shell script that consists only of:
1376
1377             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1378
1379         The process that invokes "Apply Configuration to XCFileLists" first
1380         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1381         evaluated and exports it into the shell environment. When xcodebuild
1382         is invoked, it inherits the value of this variable and can `eval` the
1383         contents of that variable. Our external standalone script can then set
1384         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1385         of command-line parameters needed to restart itself in the appropriate
1386         state.
1387
1388         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1389         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1390
1391 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1392
1393         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1394         https://bugs.webkit.org/show_bug.cgi?id=193802
1395         <rdar://problem/46010580>
1396
1397         Reviewed by Andy Estes.
1398
1399         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1400         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1401         (TEST):
1402
1403 2019-01-25  Daniel Bates  <dabates@apple.com>
1404
1405         [iOS] uiController.keyDown() does not translate Control modified key
1406         https://bugs.webkit.org/show_bug.cgi?id=192898
1407
1408         Reviewed by Wenson Hsieh.
1409
1410         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1411         key translation, as applicable. Among other cases, key translation occurs when performing
1412         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1413         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1414         human pressing down and releasing key(s) using a hardware keyboard.
1415
1416         * WebKitTestRunner/ios/HIDEventGenerator.h:
1417         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1418         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1419
1420         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1421         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1422         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1423         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1424         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1425         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1426         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1427         (-[HIDEventGenerator longPress:completionBlock:]):
1428         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1429         Update code for above renaming.
1430
1431         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1432         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1433
1434         (-[HIDEventGenerator keyDown:]): Added.
1435         (-[HIDEventGenerator keyUp:]): Added.
1436         (-[HIDEventGenerator keyPress:completionBlock:]):
1437         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1438         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1439         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1440         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1441         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1442         (WTR::parseModifier): Deleted.
1443
1444 2019-01-25  Keith Rollin  <krollin@apple.com>
1445
1446         Complete the implementation of generate-xcfilelists
1447         https://bugs.webkit.org/show_bug.cgi?id=193782
1448
1449         Reviewed by Alex Christensen.
1450
1451         A preliminary version of generate-xcfilelists was added in r238008.
1452         This patch updates that script in order to:
1453
1454         - Support checking of .xcfilelists
1455         - Perform better execution of `make DerivedSources.make` by
1456           relaunching generate-xcfilelists under xcodebuild
1457         - Support incremental generation and checking of .xcfilelists
1458         - Support supplementary .xcfilelists files from WebKitAdditions
1459         - Support being wrapped by parallel version of generate-xcfilelists in
1460           Internal that adds support for (re)generating WebKit projects in
1461           that repo.
1462         - Support builds that have been performed in WebKitBuild as well as
1463           ~/Library/Developer/code/DerivedData
1464         - Increase robustness and debugging facilities.
1465
1466         * Scripts/generate-xcfilelists:
1467
1468 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1469
1470         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1471         https://bugs.webkit.org/show_bug.cgi?id=193297
1472         <rdar://problem/47158841>
1473
1474         Unreviewed test case fix.
1475
1476         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1477         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1480         (TEST):
1481
1482 2019-01-25  Keith Rollin  <krollin@apple.com>
1483
1484         Update existing .xcfilelists
1485         https://bugs.webkit.org/show_bug.cgi?id=193791
1486         <rdar://problem/47201706>
1487
1488         Reviewed by Alex Christensen.
1489
1490         Many .xcfilelist files were added in r238824 in order to support
1491         XCBuild. Update these with recent changes to the set of build files
1492         and with the current generate-xcfilelist script.
1493
1494         * DumpRenderTree/DerivedSources-input.xcfilelist:
1495         * DumpRenderTree/DerivedSources-output.xcfilelist:
1496         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1497         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1498
1499 2019-01-25  Keith Rollin  <krollin@apple.com>
1500
1501         Fix missing dependencies in extract-dependencies-from-makefile
1502         https://bugs.webkit.org/show_bug.cgi?id=193783
1503         <rdar://problem/47201571>
1504
1505         Reviewed by Alex Christensen.
1506
1507         The extract-dependencies-from-makefile script generates .xcfilelists
1508         for XCBuild by invoking a makefile in --debug mode, parsing the
1509         dependency information in the output, and extracting information
1510         regarding targets and dependents. However, the way `make` emits this
1511         dependency information is not rigorous, and so we need to determine
1512         what lines to look for and parse by trial and error. This approach
1513         didn't coriginally atch all the information we needed to collect, so
1514         update the script to look for the additional lines we now know to look
1515         for.
1516
1517         * Scripts/extract-dependencies-from-makefile:
1518         (Parser):
1519         (Parser.addTarget):
1520         (Parser.addPrereq):
1521         (Parser.doParse):
1522
1523 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1524
1525         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1526         https://bugs.webkit.org/show_bug.cgi?id=193297
1527         <rdar://problem/47158841>
1528
1529         Reviewed by Alex Christensen.
1530
1531         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1532             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1533         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1534         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1535         activating the message used to trigger the callback when it is set.
1536
1537 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1538
1539         WKWebView.goBack should reload if there is a safe browsing warning
1540         https://bugs.webkit.org/show_bug.cgi?id=193805
1541         <rdar://problem/46908216>
1542
1543         Reviewed by Geoff Garen.
1544
1545         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1546         (+[Simple3LookupContext sharedLookupContext]):
1547         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1548         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1549         (TEST):
1550
1551 2019-01-25  Chris Dumez  <cdumez@apple.com>
1552
1553         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1554         https://bugs.webkit.org/show_bug.cgi?id=193788
1555         <rdar://problem/47531231>
1556
1557         Reviewed by Alex Christensen.
1558
1559         Add API test coverage.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1562         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1563
1564 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1565
1566         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1567         https://bugs.webkit.org/show_bug.cgi?id=193771
1568
1569         Unreviewed infrastructure fix.
1570
1571         * Scripts/webkitpy/port/darwin.py:
1572         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1573
1574 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1575
1576         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1577
1578 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1579
1580         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1581
1582         * Scripts/webkitpy/common/config/contributors.json:
1583
1584 2019-01-25  Chris Dumez  <cdumez@apple.com>
1585
1586         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1587         https://bugs.webkit.org/show_bug.cgi?id=193779
1588         <rdar://problem/46170903>
1589
1590         Reviewed by Antti Koivisto.
1591
1592         Add API test that quickly navigates forward to a previous process without waiting for it to
1593         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1594         the process' previous page when reconnecting the it for the forward navigation.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1597
1598 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1599
1600         Need a way for JavaScript (or bundle) code to participate in undo
1601         https://bugs.webkit.org/show_bug.cgi?id=190009
1602         <rdar://problem/44807048>
1603
1604         Reviewed by Ryosuke Niwa.
1605
1606         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1607         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1608
1609         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1610         (WTR::UIScriptController::lastUndoLabel const):
1611         (WTR::UIScriptController::firstRedoLabel const):
1612         (WTR::UIScriptController::platformUndoManager const):
1613         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1614         (WTR::UIScriptController::lastUndoLabel const):
1615         (WTR::UIScriptController::firstRedoLabel const):
1616         (WTR::UIScriptController::platformUndoManager const):
1617         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1618         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1619         (WTR::UIScriptController::lastUndoLabel const):
1620         (WTR::UIScriptController::firstRedoLabel const):
1621         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1622         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1623         (WTR::UIScriptController::lastUndoLabel const):
1624         (WTR::UIScriptController::firstRedoLabel const):
1625         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1626         (WTR::UIScriptController::platformUndoManager const):
1627         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1628         (WTR::UIScriptController::platformUndoManager const):
1629
1630 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1631
1632         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1633         https://bugs.webkit.org/show_bug.cgi?id=193824
1634
1635         Reviewed by Antti Koivisto.
1636
1637         * LayoutReloaded/misc/LFC-passing-tests.txt:
1638
1639 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1640
1641         Update macOS JSC bot configurations
1642         https://bugs.webkit.org/show_bug.cgi?id=193739
1643
1644         Reviewed by Alexey Proskuryakov.
1645
1646         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1648         (BubbleQueueServer): Move JSC EWS to Mojave section.
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1650         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1651         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1652
1653 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1654
1655         [Win][WebKitTestRunner] Implement EventSenderProxy
1656         https://bugs.webkit.org/show_bug.cgi?id=193755
1657
1658         Reviewed by Don Olmstead.
1659
1660         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1661         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1662         (WTR::EventSenderProxy::dispatchMessage):
1663         (WTR::EventSenderProxy::EventSenderProxy):
1664         (WTR::EventSenderProxy::mouseDown):
1665         (WTR::EventSenderProxy::mouseUp):
1666         (WTR::EventSenderProxy::mouseMoveTo):
1667         (WTR::EventSenderProxy::mouseScrollBy):
1668         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1669
1670 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1671
1672         Unreviewed fix for API test failure after r240437.
1673
1674         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1675
1676         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1677
1678 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1679
1680         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1681         https://bugs.webkit.org/show_bug.cgi?id=193787
1682         <rdar://problem/47497634>
1683
1684         Reviewed by Alexey Proskuryakov.
1685
1686         * Scripts/webkitdirs.pm:
1687         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1688
1689 2019-01-24  Truitt Savell  <tsavell@apple.com>
1690
1691         Unreviewed, rolling out r240446.
1692
1693         Casued 5 API failures
1694
1695         Reverted changeset:
1696
1697         "Activate the WebResourceLoadStatisticsStore in the
1698         NetworkProcess and deactivate it in the UIProcess."
1699         https://bugs.webkit.org/show_bug.cgi?id=193297
1700         https://trac.webkit.org/changeset/240446
1701
1702 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1703
1704         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1705         https://bugs.webkit.org/show_bug.cgi?id=193741
1706         <rdar://problem/47135030>
1707
1708         Reviewed by Antti Koivisto and Simon Fraser.
1709
1710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1712         (TestWebKitAPI::TEST):
1713
1714 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1715
1716         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1717         https://bugs.webkit.org/show_bug.cgi?id=193297
1718         <rdar://problem/47158841>
1719
1720         Reviewed by Alex Christensen.
1721
1722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1723         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1724         activating the message used to trigger the callback when it is set.
1725
1726 2019-01-24  John Wilander  <wilander@apple.com>
1727
1728         Add Ad Click Attribution as an internal/experimental feature
1729         https://bugs.webkit.org/show_bug.cgi?id=193685
1730         <rdar://problem/47450399>
1731
1732         Reviewed by Brent Fulgham.
1733
1734         Added test option adClickAttributionEnabled.
1735
1736         * DumpRenderTree/TestOptions.cpp:
1737         (TestOptions::TestOptions):
1738         * DumpRenderTree/TestOptions.h:
1739         * DumpRenderTree/mac/DumpRenderTree.mm:
1740         (setWebPreferencesForTestOptions):
1741
1742 2019-01-24  Antti Koivisto  <antti@apple.com>
1743
1744         [PSON] Flash on back navigation on Mac
1745         https://bugs.webkit.org/show_bug.cgi?id=193716
1746         <rdar://problem/47148458>
1747
1748         Reviewed by Chris Dumez.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1751
1752         Closing of the previous page is delayed so waiting for didFinishNavigation is
1753         not sufficient to guarantee we have received all the messages. Wait for them.
1754
1755 2019-01-24  Chris Dumez  <cdumez@apple.com>
1756
1757         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1758         https://bugs.webkit.org/show_bug.cgi?id=193761
1759         <rdar://problem/47456405>
1760
1761         Reviewed by Alex Christensen.
1762
1763         Add API test coverage.
1764
1765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1766
1767 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1768
1769         webkitpy: Missing PID in crashlog name should not be fatal
1770         https://bugs.webkit.org/show_bug.cgi?id=193771
1771
1772         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1773         of raising an exception.
1774
1775         Reviewed by Lucas Forschler.
1776
1777         * Scripts/webkitpy/port/darwin.py:
1778         (DarwinPort._merge_crash_logs):
1779
1780 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1781
1782         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1783         https://bugs.webkit.org/show_bug.cgi?id=193746
1784
1785         Reviewed by Youenn Fablet.
1786
1787         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1788         so we'd best just not call it.
1789
1790         * Scripts/webkitpy/w3c/test_exporter.py:
1791         (WebPlatformTestExporter.create_branch_with_patch):
1792
1793 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1794
1795         Move FileSystem to WTF
1796         https://bugs.webkit.org/show_bug.cgi?id=193602
1797
1798         Reviewed by Yusuke Suzuki.
1799
1800         * DumpRenderTree/win/DumpRenderTree.cpp:
1801         * TestWebKitAPI/CMakeLists.txt:
1802         * TestWebKitAPI/PlatformGTK.cmake:
1803         * TestWebKitAPI/PlatformJSCOnly.cmake:
1804         * TestWebKitAPI/PlatformPlayStation.cmake:
1805         * TestWebKitAPI/PlatformWPE.cmake:
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1808         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1809         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1810         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1811         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1812         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1813         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1814         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1815         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1816
1817 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1818
1819         [WPE] Remove hard dependency on subprocess32 for the API tests
1820
1821         Rubber-stamped by Carlos Garcia Campos.
1822
1823         * glib/api_test_runner.py:
1824         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1825         its presence only when running WPEQt tests.
1826
1827 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GLIB] Expose JavaScriptCore options in GLib public API
1830         https://bugs.webkit.org/show_bug.cgi?id=188742
1831
1832         Reviewed by Michael Catanzaro.
1833
1834         Add a test for the new API.
1835
1836         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1837         (testsJSCOptions):
1838         (main):
1839
1840 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [GTK][WPE] Support JPEG 2000 images
1843         https://bugs.webkit.org/show_bug.cgi?id=186272
1844
1845         Reviewed by Žan Doberšek.
1846
1847         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1848
1849         * gtk/jhbuild.modules:
1850         * wpe/jhbuild.modules:
1851
1852 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1853
1854         check-webkit-style should warn when using soft-linking macros in a header
1855         <https://webkit.org/b/193750>
1856
1857         Reviewed by Darin Adler.
1858
1859         * Scripts/webkitpy/style/checkers/cpp.py:
1860         (check_language): Add softlink/header check by refactoring the
1861         softlink/framework check.
1862         (CppChecker): Enable softlink/header check by default.
1863         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1864         (CppStyleTest.test_softlink_framework): Rename from
1865         CppStyleTest.test_softlink() and change test framework name in
1866         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1867         files. Set file_name for macros that only appear in headers.
1868         (CppStyleTest.test_softlink_header): Add tests for using
1869         soft-link macros in headers.
1870
1871 2019-01-23  Chris Dumez  <cdumez@apple.com>
1872
1873         Deprecate API to limit the maximum number of WebProcesses
1874         https://bugs.webkit.org/show_bug.cgi?id=193725
1875         <rdar://problem/47464879>
1876
1877         Reviewed by Geoff Garen.
1878
1879         Update existing API tests to stop using deprecated API.
1880
1881         * MiniBrowser/mac/AppDelegate.m:
1882         (defaultConfiguration):
1883         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1884         (TestWebKitAPI::TEST):
1885         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1886         (TestWebKitAPI::TEST):
1887         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1888         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1889         (TEST):
1890         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1891         (TEST):
1892
1893 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1894
1895         [ews-app] Rename ews model buildermappings to buildermapping
1896         https://bugs.webkit.org/show_bug.cgi?id=193729
1897
1898         Reviewed by Lucas Forschler.
1899
1900         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1901         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1902         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1903
1904 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1905
1906         [ews-app] Rename ews model steps to step
1907         https://bugs.webkit.org/show_bug.cgi?id=193697
1908
1909         Reviewed by Lucas Forschler.
1910
1911         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1912         (Step): Renamed Steps to Step.
1913
1914 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1915
1916         Clean up IndexedDB files between tests
1917         https://bugs.webkit.org/show_bug.cgi?id=192796
1918         <rdar://problem/46824999>
1919
1920         Reviewed by Geoffrey Garen.
1921
1922         * DumpRenderTree/mac/DumpRenderTree.mm:
1923         (runTest):
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR::TestController::resetStateToConsistentValues):
1926         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1927         (WTR::RemoveAllIndexedDatabasesCallback):
1928         (WTR::TestController::ClearIndexedDatabases):
1929         * WebKitTestRunner/TestController.h:
1930         * WebKitTestRunner/TestInvocation.cpp:
1931         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1932
1933 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1934
1935         [ews-app] Rename ews model Builds to Build
1936         https://bugs.webkit.org/show_bug.cgi?id=193695
1937
1938         Reviewed by Lucas Forschler.
1939
1940         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1941         (Build): Renamed Builds to Build.
1942
1943 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1944
1945         webkitpy: Wait longer when launching WebKitTestRunner
1946         https://bugs.webkit.org/show_bug.cgi?id=193734
1947
1948         Reviewed by Aakash Jain.
1949
1950         * Scripts/webkitpy/port/simulator_process.py:
1951         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1952
1953 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1954
1955         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1956         https://bugs.webkit.org/show_bug.cgi?id=193182
1957         <rdar://problem/47452154>
1958
1959         Reviewed by Tim Horton.
1960
1961         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1962         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1963         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1964
1965         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1966         preventing later tests from recognizing gestures.
1967
1968         * WebKitTestRunner/ios/TestControllerIOS.mm:
1969         (WTR::TestController::platformResetStateToConsistentValues):
1970
1971         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1972
1973 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1974
1975         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1976         https://bugs.webkit.org/show_bug.cgi?id=193722
1977         <rdar://problem/47481475>
1978
1979         Reviewed by Lucas Forschler.
1980
1981         iPhone and iPad ports should both use the iOS config.
1982
1983         * Scripts/webkitpy/port/ios_simulator.py:
1984         (IPhoneSimulatorPort.__init__):
1985         (IPadSimulatorPort.__init__):
1986
1987 2019-01-23  Rob Buis  <rbuis@igalia.com>
1988
1989         Update MIME type parser
1990         https://bugs.webkit.org/show_bug.cgi?id=180526
1991
1992         Reviewed by Frédéric Wang.
1993
1994         Add unit tests for both parse modes of ParsedContentType.
1995
1996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1997         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1998         (TestWebKitAPI::TEST):
1999
2000 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [ews-app] fetch loop should not stop on network issues
2003         https://bugs.webkit.org/show_bug.cgi?id=193666
2004
2005         Reviewed by Lucas Forschler.
2006
2007         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2008         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2009
2010 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2011
2012         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2013         https://bugs.webkit.org/show_bug.cgi?id=189165
2014         <rdar://problem/47433765>
2015
2016         Reviewed by Tim Horton.
2017
2018         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2019         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2020         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2021         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2022         would make its way to the UI process by the time the layer tree commit is finished.
2023
2024         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2025         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2026         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2027         will fail because it asks for -_autofillContext too early.
2028
2029         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2030         is handled in the UI process.
2031
2032         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2033
2034         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2035         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2036         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2037         input session.
2038
2039         (-[AutofillTestView textInputHasAutofillContext]):
2040
2041         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2042
2043         * TestWebKitAPI/cocoa/TestWKWebView.h:
2044         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2045         (nextInputSessionChangeCount):
2046
2047         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2048         This includes changing the focused element from one to another.
2049
2050         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2051         (-[TestWKWebView didStartFormControlInteraction]):
2052         (-[TestWKWebView didEndFormControlInteraction]):
2053         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2054
2055         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2056         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2057         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2058         that doesn't require an input session to one that doesn't.
2059
2060 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2061
2062         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2063         <https://webkit.org/b/193676>
2064
2065         Reviewed by Alexey Proskuryakov.
2066
2067         * Scripts/webkitpy/style/checkers/cpp.py:
2068         (check_member_initialization_list):
2069         - Don't report missing whitespace around colon if the colon at
2070           the start of the line is formatted correctly.
2071         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2072         (WebKitStyleTest.test_member_initialization_list):
2073         - Add a test for a missing permutation of existing tests.
2074         - Add a test this false-positive.
2075         - Add blank lines between subtests to make them easier to read.
2076
2077 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [build.webkit.org] Unit-test failure after r237113
2080         https://bugs.webkit.org/show_bug.cgi?id=193669
2081
2082         Reviewed by Michael Catanzaro.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2085         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2086         multiple or zero flags.
2087
2088 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2089
2090         Cache bytecode to disk
2091         https://bugs.webkit.org/show_bug.cgi?id=192782
2092         <rdar://problem/46084932>
2093
2094         Reviewed by Keith Miller.
2095
2096         Add test helper to execute bytecode-cache tests: it executes each test
2097         twice, the first with JSC_diskCachePath set to a temporary directory
2098         and second with JSC_forceDiskCache=true (in addition to the cache path)
2099         to guarantee that only the disk cache is being used and no new
2100         UnlinkedCodeBlocks are being created.
2101
2102         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2103         * Scripts/run-jsc-stress-tests:
2104
2105 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2106
2107         [css-logical] Implement flow-relative margin, padding and border shorthands
2108         https://bugs.webkit.org/show_bug.cgi?id=188697
2109
2110         Reviewed by Simon Fraser and Antti Koivisto.
2111
2112         * DumpRenderTree/TestOptions.cpp:
2113         (TestOptions::TestOptions):
2114         * DumpRenderTree/TestOptions.h:
2115         * DumpRenderTree/mac/DumpRenderTree.mm:
2116         (setWebPreferencesForTestOptions):
2117         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2118
2119         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2120         (JSONCSSPropertiesChecker.check_codegen_properties):
2121         Allow CSS property definitions to have a 'runtime-flag' parameter which
2122         disables the property when the specified runtime flag is disabled.
2123
2124 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2125
2126         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2127         https://bugs.webkit.org/show_bug.cgi?id=193643
2128
2129         Reviewed by Michael Catanzaro.
2130
2131         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2132         * wpe/jhbuild.modules: Ditto.
2133
2134 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2135
2136         [LFC][Floats] Take float top position into account when computing containing block height.
2137         https://bugs.webkit.org/show_bug.cgi?id=193655
2138
2139         Reviewed by Antti Koivisto.
2140
2141         * LayoutReloaded/misc/LFC-passing-tests.txt:
2142
2143 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2144
2145         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2146         <https://webkit.org/b/193645>
2147         <rdar://problem/47421574>
2148
2149         Reviewed by Alex Christensen.
2150
2151         - Now checks for local soft-linking of all frameworks that have
2152           their own *SoftLinking.{cpp,h,mm} files.
2153         - Changes softlink/uikit warning to softlink/framework.
2154
2155         * Scripts/webkitpy/style/checkers/cpp.py:
2156         (check_language):
2157         (CppChecker):
2158         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2159         (CppStyleTest):
2160
2161 2019-01-20  Saam Barati  <sbarati@apple.com>
2162
2163         Rollout r240210: It broke tests on iOS
2164         https://bugs.webkit.org/show_bug.cgi?id=193640
2165
2166         Unreviewed.
2167
2168         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2169         * Scripts/run-jsc-stress-tests:
2170
2171 2019-01-20  chris fleizach  <cfleizach@apple.com>
2172
2173         AX: Support returning relative frames for accessibility
2174         https://bugs.webkit.org/show_bug.cgi?id=193414
2175         <rdar://problem/47268501>
2176
2177         Reviewed by Zalan Bujtas.
2178
2179         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2180         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2181         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2182         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2183         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2184         (WTR::attributesOfElement):
2185         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2186
2187 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2188
2189         Unreviewed, add my new email address
2190
2191         * Scripts/webkitpy/common/config/contributors.json:
2192
2193 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2194
2195         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2196         https://bugs.webkit.org/show_bug.cgi?id=193617
2197
2198         Reviewed by Antti Koivisto.
2199
2200         * LayoutReloaded/misc/LFC-passing-tests.txt:
2201
2202 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2203
2204         Unreviewed, rolling out r240209.
2205
2206         Broke GTK/WPE injected bundle
2207
2208         Reverted changeset:
2209
2210         "AX: Support returning relative frames for accessibility"
2211         https://bugs.webkit.org/show_bug.cgi?id=193414
2212         https://trac.webkit.org/changeset/240209
2213
2214 2019-01-12  Dan Bernstein  <mitz@apple.com>
2215
2216         [Cocoa] Avoid importing directly from subumbrella frameworks
2217         https://bugs.webkit.org/show_bug.cgi?id=186016
2218         <rdar://problem/40591038>
2219
2220         Reviewed by Sam Weinig.
2221
2222         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2223           LaunchServices header.
2224         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2225           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2226         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2227           when using SDKs earlier than 10.13.
2228         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2229           and OTHER_CPLUSPLUSFLAGS.
2230         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2231           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2232         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2233           LaunchServices header.
2234
2235 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2236
2237         Cache bytecode to disk
2238         https://bugs.webkit.org/show_bug.cgi?id=192782
2239         <rdar://problem/46084932>
2240
2241         Reviewed by Keith Miller.
2242
2243         Add test helper to execute bytecode-cache tests: it executes each test
2244         twice, the first with JSC_diskCachePath set to a temporary directory
2245         and second with JSC_forceDiskCache=true (in addition to the cache path)
2246         to guarantee that only the disk cache is being used and no new
2247         UnlinkedCodeBlocks are being created.
2248
2249         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2250         * Scripts/run-jsc-stress-tests:
2251
2252 2019-01-20  chris fleizach  <cfleizach@apple.com>
2253
2254         AX: Support returning relative frames for accessibility
2255         https://bugs.webkit.org/show_bug.cgi?id=193414
2256         <rdar://problem/47268501>
2257
2258         Reviewed by Zalan Bujtas.
2259
2260         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2261         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2262         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2263         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2264         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2265         (WTR::attributesOfElement):
2266         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2267
2268 2019-01-20  Antoine Quint  <graouts@apple.com>
2269
2270         Add a POINTER_EVENTS feature flag
2271         https://bugs.webkit.org/show_bug.cgi?id=193577
2272         <rdar://problem/47408511>
2273
2274         Unreviewed. Also enable Pointer Events for iosmac.
2275
2276         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2277
2278 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2279
2280         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2281         https://bugs.webkit.org/show_bug.cgi?id=193613
2282
2283         Reviewed by Antti Koivisto.
2284
2285         * LayoutReloaded/misc/LFC-passing-tests.txt:
2286
2287 2019-01-19  Antoine Quint  <graouts@apple.com>
2288
2289         Add a POINTER_EVENTS feature flag
2290         https://bugs.webkit.org/show_bug.cgi?id=193577
2291
2292         Reviewed by Dean Jackson.
2293
2294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2295
2296 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2297
2298         Disable the run-jsc-stress-test remote host key check [second round].
2299         https://bugs.webkit.org/show_bug.cgi?id=192988
2300
2301         Reviewed by Dewei Zhu.
2302
2303         * Scripts/run-jsc-stress-tests:
2304
2305 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2306
2307         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2308         https://bugs.webkit.org/show_bug.cgi?id=193597
2309
2310         Reviewed by Lucas Forschler.
2311
2312         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2313
2314 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2315
2316         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2317         https://bugs.webkit.org/show_bug.cgi?id=193595
2318
2319         Reviewed by Lucas Forschler.
2320
2321         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2322         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2323         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2324
2325 2019-01-18  Chris Dumez  <cdumez@apple.com>
2326
2327         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2328         https://bugs.webkit.org/show_bug.cgi?id=193588
2329         <rdar://problem/47131566>
2330
2331         Reviewed by Alex Christensen.
2332
2333         Add layout test coverage.
2334
2335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2336
2337 2019-01-18  Jer Noble  <jer.noble@apple.com>
2338
2339         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2340         https://bugs.webkit.org/show_bug.cgi?id=189553
2341
2342         Reviewed by Tim Horton.
2343
2344         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2345
2346         * ContentExtensionTester/Configurations/Base.xcconfig:
2347         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2348         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2349         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2350         * ImageDiff/cg/Configurations/Base.xcconfig:
2351         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2352         * MiniBrowser/Configurations/Base.xcconfig:
2353         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2354         * MobileMiniBrowser/Configurations/Base.xcconfig:
2355         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2356         * Scripts/webkitpy/style/checker.py:
2357         (_all_categories):
2358         (FileType):
2359         (CheckerDispatcher._file_type):
2360         (CheckerDispatcher._create_checker):
2361         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2362         (SDKVariantChecker):
2363         (SDKVariantChecker.__init__):
2364         (SDKVariantChecker.check):
2365         * TestWebKitAPI/Configurations/Base.xcconfig:
2366         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2367         * WebEditingTester/Configurations/Base.xcconfig:
2368         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2369         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2370         * WebKitTestRunner/Configurations/Base.xcconfig:
2371         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2372         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2373         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2374
2375 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2376
2377         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2378         <https://webkit.org/b/193568>
2379         <rdar://problem/47381130>
2380
2381         Reviewed by Alex Christensen.
2382
2383         Make sure no one re-introduces UIKit soft-linking by adding a
2384         style rule.
2385
2386         * Scripts/webkitpy/style/checkers/cpp.py:
2387         (check_language): Add softlink/uikit check.
2388         (CppChecker): Enable softlink/uikit check.
2389         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2390         (CppStyleTest): Add test for softlink/uikit.
2391
2392 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2393
2394         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2395         https://bugs.webkit.org/show_bug.cgi?id=193584
2396
2397         Change "-dev" to "-devel".
2398
2399         Reviewed by Michael Catanzaro.
2400
2401         * gtk/install-dependencies:
2402
2403 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2404
2405         webkitpy: Add iPhone and iPad ports
2406         https://bugs.webkit.org/show_bug.cgi?id=193537
2407         <rdar://problem/47353390>
2408
2409         Reviewed by Lucas Forschler.
2410
2411         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2412         ports. Note that this separation is optional, the --ios-simulator command remains.
2413
2414         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2415         (RunTest.test_device_type_test_division): Drive-by fix.
2416         (RunTest.test_device_type_specific_listing): Ditto.
2417         (RunTest.test_ipad_test_division):
2418         (RunTest):
2419         (RunTest.test_ipad_listing):
2420         * Scripts/webkitpy/port/factory.py:
2421         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2422         (PortFactory):
2423         * Scripts/webkitpy/port/ios_simulator.py:
2424         (IPhoneSimulatorPort):
2425         (IPadSimulatorPort):
2426
2427 2019-01-18  Chris Dumez  <cdumez@apple.com>
2428
2429         Regression(PSON) Scroll position is not always restored properly when navigating back
2430         https://bugs.webkit.org/show_bug.cgi?id=193578
2431         <rdar://problem/47386331>
2432
2433         Reviewed by Tim Horton.
2434
2435         Add API test coverage.
2436
2437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2438
2439 2019-01-18  Youenn Fablet  <youenn@apple.com>
2440
2441         Add a new SPI to request for cache storage quota increase
2442         https://bugs.webkit.org/show_bug.cgi?id=193323
2443
2444         Reviewed by Alex Christensen.
2445
2446         Implement WebsiteDataStore quota delegate to handle quota requests.
2447         By default, do not update quota.
2448         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2449
2450         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2451         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2452         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2453         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2454         * WebKitTestRunner/TestController.cpp:
2455         (WTR::TestController::allowCacheStorageQuotaIncrease):
2456         * WebKitTestRunner/TestController.h:
2457         * WebKitTestRunner/TestInvocation.cpp:
2458         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2459         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2460         (-[CacheStorageQuotaManager init]):
2461         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2462         (WTR::initializeWebViewConfiguration):
2463         (WTR::TestController::cocoaResetStateToConsistentValues):
2464         (WTR::TestController::allowCacheStorageQuotaIncrease):
2465
2466 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2467
2468         [ews-build] Pass owner to the triggered builds
2469         https://bugs.webkit.org/show_bug.cgi?id=193574
2470
2471         Reviewed by Lucas Forschler.
2472
2473         * BuildSlaveSupport/ews-build/factories.py:
2474         (BuildFactory.propertiesToPassToTriggers):
2475
2476 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2477
2478         [ews-app] Send patch author as a build property
2479         https://bugs.webkit.org/show_bug.cgi?id=193560
2480
2481         Reviewed by Lucas Forschler.
2482
2483         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2484         (BugzillaPatchFetcher.fetch):
2485
2486 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2487
2488         webkitpy: Implement device type specific expected results (Follow-up fix)
2489         https://bugs.webkit.org/show_bug.cgi?id=192162
2490         <rdar://problem/46345449>
2491
2492         Unreviewed infrastructure fix.
2493
2494         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2495         (Manager.run): Don't boot a device if no tests are available to run on it.
2496
2497 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2498
2499         webkitpy: Implement device type specific expected results (Follow-up fix)
2500         https://bugs.webkit.org/show_bug.cgi?id=192162
2501         <rdar://problem/46345449>
2502
2503         Unreviewed infrastructure fix.
2504
2505         * Scripts/webkitpy/api_tests/manager.py:
2506         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2507
2508 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2509
2510         webkitpy: Implement device type specific expected results (Part 2)
2511         https://bugs.webkit.org/show_bug.cgi?id=192162
2512         <rdar://problem/46345449>
2513
2514         Rubber-stamped by Aakash Jain.
2515
2516         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2517         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2518         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2519
2520         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2521         (LayoutTestFinder.find_tests): Pass device_type through.
2522         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2523         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2524         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2525         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2526         (Manager._collect_tests): Pass device type to test finder.
2527         (Manager._needs_web_platform_test):
2528         (Manager._prepare_lists): Index _expectations by device type.
2529         (Manager._test_input_for_file):
2530         (Manager._test_is_slow): Ditto.
2531         (Manager._test_should_dump_jsconsolelog_in_stderr):
2532         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2533         (Manager._get_test_inputs):
2534         (Manager._update_worker_count):
2535         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2536         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2537         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2538         the one which runs the test.
2539         (Manager._run_test_subset):
2540         (Manager._run_tests): Index _expectations by current_device_type.
2541         (Manager._print_expectation_line_for_test): Ditto.
2542         (Manager._print_expectations_for_subset): Ditto.
2543         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2544         Unlike run, this function will behave the same regardless of what devices are available.
2545         (Manager._custom_device_for_test): Deleted.
2546         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2547         (ManagerTest.test_uses_custom_device): Deleted.
2548         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2549         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2550         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2551         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2552         all of the expectations.
2553         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2554         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2555         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2556         (TestExpectations.__init__): Allow device_type to be passed through.
2557         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2558         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2559         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2560         (summarize_results):
2561         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2562         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2563         a test ran with, one must check all expectations to find the first non-skip expectation.
2564         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2565         (RunTest.test_device_type_test_division):
2566         (RunTest):
2567         (RunTest.test_device_type_specific_listing):
2568         * Scripts/webkitpy/port/base.py:
2569         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2570         (Port.supported_device_types): The result of this function will change based on what devices are available.
2571         * Scripts/webkitpy/port/device_port.py:
2572         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2573         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2574         can be used.
2575         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2576         any, or the DEFAULT_DEVICE_TYPES of the port.
2577         * Scripts/webkitpy/port/ios.py:
2578         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2579         * Scripts/webkitpy/port/ios_simulator.py:
2580         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2581         * Scripts/webkitpy/port/watch.py:
2582         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2583         * Scripts/webkitpy/port/watch_simulator.py:
2584         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2585         * Scripts/webkitpy/xcode/device_type.py:
2586         (DeviceType):
2587         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2588
2589 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2590
2591         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2592         https://bugs.webkit.org/show_bug.cgi?id=193575
2593
2594         Reviewed by Michael Catanzaro.
2595
2596         Allow the script to run without explicit port argument because
2597         it's specific to the WPE port anyway.
2598
2599         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2600         and simplify the rest of the code accordingly.
2601
2602 2019-01-18  Charlie Turner  <cturner@igalia.com>
2603
2604         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2605         https://bugs.webkit.org/show_bug.cgi?id=192229
2606
2607         Reviewed by Xabier Rodriguez-Calvar.
2608
2609         * MiniBrowser/wpe/main.cpp:
2610         (main): Enable encrypted-media by default.
2611
2612 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2613
2614         [Flatpak] Missing KeyboardInterrupt exception handler
2615         https://bugs.webkit.org/show_bug.cgi?id=193570
2616
2617         Reviewed by Michael Catanzaro.
2618
2619         * flatpak/flatpakutils.py:
2620         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2621
2622 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2623
2624         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2625         https://bugs.webkit.org/show_bug.cgi?id=193564
2626
2627         Reviewed by Antti Koivisto.
2628
2629         * LayoutReloaded/misc/LFC-passing-tests.txt:
2630
2631 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2632
2633         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2634         https://bugs.webkit.org/show_bug.cgi?id=193562
2635
2636         Reviewed by Antti Koivisto.
2637
2638         * LayoutReloaded/misc/LFC-passing-tests.txt:
2639
2640 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2641
2642         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2643         https://bugs.webkit.org/show_bug.cgi?id=193555
2644
2645         Reviewed by Antti Koivisto.
2646
2647         * LayoutReloaded/misc/LFC-passing-tests.txt:
2648
2649 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2650
2651         [WPE] Add Qt extension
2652         https://bugs.webkit.org/show_bug.cgi?id=191464
2653
2654         Reviewed by Carlos Garcia Campos.
2655
2656         MiniBrowser and API tests for the WPE Qt API. To run the
2657         MiniBrowser a new script is introduced. Example invocation:
2658
2659         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2660
2661         Also note-worthy is the introduction of the python2-subprocess32
2662         dependency to run the GLib API tests.
2663
2664         * MiniBrowser/wpe/CMakeLists.txt:
2665         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2666         * MiniBrowser/wpe/qt/main.cpp: Added.
2667         (main):
2668         * MiniBrowser/wpe/qt/main.qml: Added.
2669         * MiniBrowser/wpe/qt/qml.qrc: Added.
2670         * Scripts/run-gtk-tests:
2671         (GtkTestRunner.is_google_test):
2672         (GtkTestRunner):
2673         (GtkTestRunner.is_qt_test):
2674         * Scripts/run-qt-wpe-minibrowser: Added.
2675         * Scripts/run-wpe-tests:
2676         (WPETestRunner):
2677         (WPETestRunner.is_google_test):
2678         (WPETestRunner.is_qt_test):
2679         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2680         (TestLoad::main):
2681         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2682         (TestLoadHtml::main):
2683         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2684         (TestLoadRequest::main):
2685         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2686         (TestRunJavaScript::main):
2687         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2688         (waitForSignal):
2689         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2690         (LoadSpy::LoadSpy):
2691         (LoadSpy::~LoadSpy):
2692         (LoadSpy::onLoadingChanged):
2693         (LoadStartedCatcher::LoadStartedCatcher):
2694         (LoadStartedCatcher::~LoadStartedCatcher):
2695         (LoadStartedCatcher::onLoadingChanged):
2696         (waitForLoadSucceeded):
2697         (waitForLoadFailed):
2698         * TestWebKitAPI/glib/CMakeLists.txt:
2699         * flatpak/flatpakutils.py:
2700         (WebkitFlatpak.load_from_args):
2701         (WebkitFlatpak.__init__):
2702         (WebkitFlatpak.clean_args):
2703         (WebkitFlatpak.run_in_sandbox):
2704         * flatpak/org.webkit.CommonModules.yaml:
2705         * flatpak/org.webkit.WPE.yaml:
2706         * flatpak/org.webkit.WPEModules.yaml:
2707         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2708         * flatpak/org.webkit.WebKit.yaml:
2709         * glib/api_test_runner.py:
2710         (TestRunner._run_test_qt):
2711         (TestRunner.is_qt_test):
2712         (TestRunner._run_test):
2713
2714 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2715
2716         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2717         https://bugs.webkit.org/show_bug.cgi?id=193494
2718         <rdar://problem/46859627>
2719
2720         Reviewed by Simon Fraser and Tim Horton.
2721
2722         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2723         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2724
2725         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2726         (WTR::UIScriptController::contentOffsetX const):
2727         (WTR::UIScriptController::contentOffsetY const):
2728         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2729         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2730         (WTR::UIScriptController::contentOffsetX const):
2731         (WTR::UIScriptController::contentOffsetY const):
2732         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2733
2734         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2735
2736         * WebKitTestRunner/TestController.cpp:
2737         (WTR::updateTestOptionsFromTestHeader):
2738         * WebKitTestRunner/TestOptions.h:
2739         (WTR::TestOptions::hasSameInitializationOptions const):
2740         * WebKitTestRunner/ios/TestControllerIOS.mm:
2741         (WTR::TestController::platformResetStateToConsistentValues):
2742         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2743         (WTR::UIScriptController::contentOffsetX const):
2744         (WTR::UIScriptController::contentOffsetY const):
2745
2746 2019-01-17  Truitt Savell  <tsavell@apple.com>
2747
2748         Unreviewed, rolling out r240124.
2749
2750         This commit broke an internal build.
2751
2752         Reverted changeset:
2753
2754         "SDK_VARIANT build destinations should be separate from non-
2755         SDK_VARIANT builds"
2756         https://bugs.webkit.org/show_bug.cgi?id=189553
2757         https://trac.webkit.org/changeset/240124
2758
2759 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2760
2761         Fix string concatenation API test after r239920
2762         https://bugs.webkit.org/show_bug.cgi?id=193551
2763         <rdar://problem/47359304>
2764
2765         Reviewed by Youenn Fablet.
2766
2767         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2768         (TestWebKitAPI::TEST):
2769         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2770         in WebKit's build configuration like it apparently is on Linux.
2771
2772 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2773
2774         [ews-build] validate-patch should handle the case when bug_id is None
2775         https://bugs.webkit.org/show_bug.cgi?id=193547
2776
2777         Reviewed by Lucas Forschler.
2778
2779         * BuildSlaveSupport/ews-build/steps.py:
2780         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2781         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2782
2783 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2784
2785         [ews-build] Add patch author information in build
2786         https://bugs.webkit.org/show_bug.cgi?id=193465
2787
2788         Reviewed by Lucas Forschler.
2789
2790         * BuildSlaveSupport/ews-build/steps.py:
2791         (ValidatePatch._is_patch_obsolete):
2792
2793 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2794
2795         [ews-build] Pass bug_id to the triggered builds
2796         https://bugs.webkit.org/show_bug.cgi?id=193548
2797
2798         Reviewed by Lucas Forschler.
2799
2800         * BuildSlaveSupport/ews-build/factories.py:
2801         (BuildFactory.propertiesToPassToTriggers):
2802
2803 2019-01-17  Jer Noble  <jer.noble@apple.com>
2804
2805         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2806         https://bugs.webkit.org/show_bug.cgi?id=189553
2807
2808         Reviewed by Tim Horton.
2809
2810         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2811
2812         * ContentExtensionTester/Configurations/Base.xcconfig:
2813         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2814         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2815         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2816         * ImageDiff/cg/Configurations/Base.xcconfig:
2817         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2818         * MiniBrowser/Configurations/Base.xcconfig:
2819         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2820         * MobileMiniBrowser/Configurations/Base.xcconfig:
2821         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2822         * Scripts/webkitpy/style/checker.py:
2823         (_all_categories):
2824         (FileType):
2825         (CheckerDispatcher._file_type):
2826         (CheckerDispatcher._create_checker):
2827         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2828         (SDKVariantChecker):
2829         (SDKVariantChecker.__init__):
2830         (SDKVariantChecker.check):
2831         * TestWebKitAPI/Configurations/Base.xcconfig:
2832         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2833         * WebEditingTester/Configurations/Base.xcconfig:
2834         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2835         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2836         * WebKitTestRunner/Configurations/Base.xcconfig:
2837         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2838         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2839         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2840
2841 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2842
2843         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2844         https://bugs.webkit.org/show_bug.cgi?id=193534
2845
2846         Reviewed by Antti Koivisto.
2847
2848         * LayoutReloaded/misc/LFC-passing-tests.txt:
2849
2850 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2851
2852         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2853         https://bugs.webkit.org/show_bug.cgi?id=193528
2854
2855         Reviewed by Antti Koivisto.
2856
2857         * LayoutReloaded/misc/LFC-passing-tests.txt:
2858
2859 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2860
2861         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2862         https://bugs.webkit.org/show_bug.cgi?id=193520
2863
2864         Reviewed by Antti Koivisto.
2865
2866         * LayoutReloaded/misc/LFC-passing-tests.txt:
2867
2868 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2869
2870         [ews-build] unapply-patch step should not update source
2871         https://bugs.webkit.org/show_bug.cgi?id=193234
2872
2873         Reviewed by Lucas Forschler.
2874
2875         * BuildSlaveSupport/ews-build/steps.py:
2876         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2877         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2878
2879 2019-01-16  Youenn Fablet  <youenn@apple.com>
2880
2881         Add a new SPI for controlling getUserMedia
2882         https://bugs.webkit.org/show_bug.cgi?id=192793
2883
2884         Reviewed by Eric Carlson.
2885
2886         * MiniBrowser/mac/WK2BrowserWindowController.m:
2887         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2888         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2889         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2890         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2891         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2892         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2893         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2894         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2895         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2896         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2897         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2898         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2899         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2900         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2901
2902 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2903
2904         [LFC][BFC] Inflow non-replaced used width should not be negative.
2905         https://bugs.webkit.org/show_bug.cgi?id=193495
2906
2907         Reviewed by Antti Koivisto.
2908
2909         * LayoutReloaded/misc/LFC-passing-tests.txt:
2910
2911 2019-01-16  Chris Dumez  <cdumez@apple.com>
2912
2913         Regression(PSON) View becomes blank after click a cross-site download link
2914         https://bugs.webkit.org/show_bug.cgi?id=193361
2915         <rdar://problem/47099573>
2916
2917         Reviewed by Geoffrey Garen.
2918
2919         Add API test coverage.
2920
2921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2922         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2923
2924 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2925
2926         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2927         https://bugs.webkit.org/show_bug.cgi?id=193470
2928
2929         Reviewed by Antti Koivisto.
2930
2931         * LayoutReloaded/misc/LFC-passing-tests.txt:
2932
2933 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2934
2935         [LFC] Adjust margin box verification.
2936         https://bugs.webkit.org/show_bug.cgi?id=193482
2937
2938         Reviewed by Antti Koivisto.
2939
2940         * LayoutReloaded/misc/LFC-passing-tests.txt:
2941
2942 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2943
2944         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2945         https://bugs.webkit.org/show_bug.cgi?id=193451
2946
2947         Reviewed by Geoffrey Garen.
2948
2949         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2950         (TEST):
2951         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2952         (runWebsiteDataStoreCustomPaths):
2953
2954 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2955
2956         webkitpy: Support boolean simctl isAvailable
2957         https://bugs.webkit.org/show_bug.cgi?id=193472
2958         <rdar://problem/47296150>
2959
2960         Reviewed by Ryosuke Niwa.
2961
2962         * Scripts/webkitpy/xcode/simulated_device.py:
2963         (SimulatedDeviceManager._create_runtimes):
2964         (SimulatedDeviceManager._create_device_with_runtime):
2965
2966 2019-01-15  Chris Dumez  <cdumez@apple.com>
2967
2968         Unreviewed, rolling out r239993, r239995, r239997, and
2969         r239999.
2970
2971         Caused assertions under
2972         ViewGestureController::disconnectFromProcess()
2973
2974         Reverted changesets:
2975
2976         "Regression(PSON) View becomes blank after click a cross-site
2977         download link"
2978         https://bugs.webkit.org/show_bug.cgi?id=193361
2979         https://trac.webkit.org/changeset/239993
2980
2981         "Unreviewed iOS build fix after r239993."
2982         https://trac.webkit.org/changeset/239995
2983
2984         "Fix iOS build after r239993"
2985         https://bugs.webkit.org/show_bug.cgi?id=193361
2986         https://trac.webkit.org/changeset/239997
2987
2988         "Unreviewed, revert part of r239997 as it is not needed to fix
2989         the build."
2990         https://trac.webkit.org/changeset/239999
2991
2992 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2993
2994         Cannot tab out of WKWebView on macOS
2995         https://bugs.webkit.org/show_bug.cgi?id=161448
2996         <rdar://problem/28100085>
2997
2998         Reviewed by Dean Jackson.
2999
3000         Add a test that tabbing into and out of WKWebView works correctly.
3001
3002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3003         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3004         (WebKit2_CommandBackForwardTest::SetUp):
3005         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3006         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3007         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3008         (-[FocusableView canBecomeKeyView]):
3009         (TEST):
3010         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3011         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3012         (-[OffscreenWindow initWithSize:]):
3013         (-[OffscreenWindow isKeyWindow]):
3014         (-[OffscreenWindow isVisible]):
3015         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3016         (TestWebKitAPI::PlatformWebView::initialize):
3017         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3018         (-[ActiveOffscreenWindow isVisible]): Deleted.
3019         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3020
3021 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3022
3023         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3024         https://bugs.webkit.org/show_bug.cgi?id=193459
3025
3026         Reviewed by Mark Lam.
3027
3028         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3029         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3030
3031 2019-01-15  Chris Dumez  <cdumez@apple.com>
3032
3033         Regression(PSON) View becomes blank after click a cross-site download link
3034         https://bugs.webkit.org/show_bug.cgi?id=193361
3035         <rdar://problem/47099573>
3036
3037         Reviewed by Geoff Garen.
3038
3039         Add API test coverage.
3040
3041         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3042         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3043
3044 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3045
3046         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3047         https://bugs.webkit.org/show_bug.cgi?id=193448
3048
3049         Reviewed by Antti Koivisto.
3050
3051         * LayoutReloaded/misc/LFC-passing-tests.txt:
3052
3053 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3054
3055         webkitpy: Implement device type specific expected results (Part 1)
3056         https://bugs.webkit.org/show_bug.cgi?id=192162
3057
3058         Reviewed by Lucas Forschler.
3059
3060         Device type specific expected results covers two related ideas. The first (covered by this change)
3061         is where to search for -expected.* files. The second is which tests to run based on the
3062         TestExpectations.txt file.
3063
3064         After this change, the baseline search path will be determined by the type of device running a
3065         test. Device type will be passed into any function which picks a file based on the baseline search
3066         path.
3067
3068         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3069         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3070         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3071         (Manager.run): Print baseline search path for each round of devices.
3072         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3073         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3074         (SingleTestRunner._expected_driver_output): Ditto.
3075         (SingleTestRunner._driver_input): Ditto.
3076         * Scripts/webkitpy/layout_tests/views/printing.py:
3077         (Printer.print_config): Move printing of baseline search path to a separate function.
3078         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3079         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3080         (Testprinter.test_print_config):
3081         (Testprinter.test_print_baseline_search_path):
3082         * Scripts/webkitpy/port/base.py:
3083         (Port.baseline_search_path): Pass device_type through.
3084         (Port._expected_baselines_for_suffixes): Ditto.
3085         (Port.expected_baselines): Ditto.
3086         (Port.expected_filename): Ditto.
3087         (Port.expected_checksum): Ditto.
3088         (Port.expected_image): Ditto.
3089         (Port.expected_audio): Ditto.
3090         (Port.expected_text): Ditto.
3091         (Port.reference_files): Ditto.
3092         (Port.tests): Ditto.
3093         (Port._expanded_paths): Ditto.
3094         (Port.skipped_layout_tests): Ditto.
3095         (Port.expectations_dict): Ditto.
3096         (Port._port_specific_expectations_files): Ditto.
3097         (Port.expectations_files): Ditto.
3098         (Port.test_search_path): Ditto.
3099         (Port._tests_for_other_platforms): Ditto.
3100         * Scripts/webkitpy/port/base_unittest.py:
3101         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3102         (PortTest.test_nonexistant_expectations): Ditto.
3103         (test_ref_tests_platform_directory): Ditto.
3104         * Scripts/webkitpy/port/darwin.py:
3105         (DarwinPort._port_specific_expectations_files): Accept device_type.
3106         * Scripts/webkitpy/port/driver.py:
3107         (DriverProxy):
3108         (DriverProxy.host): Expose _target_host for device_type information.
3109         * Scripts/webkitpy/port/gtk.py:
3110         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3111         * Scripts/webkitpy/port/ios.py:
3112         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3113         * Scripts/webkitpy/port/mac.py:
3114         (MacPort. default_baseline_search_path): Ditto.
3115         * Scripts/webkitpy/port/port_testcase.py:
3116         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3117         * Scripts/webkitpy/port/test.py:
3118         * Scripts/webkitpy/port/watch.py:
3119         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3120         * Scripts/webkitpy/port/win.py:
3121         (WinPort.test_search_path): Accept, but do not use, device_type.
3122         * Scripts/webkitpy/port/wpe.py:
3123         (WPEPort._port_specific_expectations_files): Ditto.
3124         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3125         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3126
3127 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3128
3129         [LFC] Use the containing block's padding box to position out-of-flow elements.
3130         https://bugs.webkit.org/show_bug.cgi?id=193431
3131
3132         Reviewed by Antti Koivisto.
3133
3134         * LayoutReloaded/misc/LFC-passing-tests.txt:
3135
3136 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3137
3138         Move a test implementation file that got misplaced in the Xcode project
3139
3140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3141
3142 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3143
3144         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3145         r239913, and r239914.
3146         https://bugs.webkit.org/show_bug.cgi?id=193407
3147
3148         These revisions caused an internal failure (Requested by
3149         Truitt on #webkit).
3150
3151         Reverted changesets:
3152
3153         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3154         https://bugs.webkit.org/show_bug.cgi?id=186016
3155         https://trac.webkit.org/changeset/239901
3156
3157         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3158         https://trac.webkit.org/changeset/239909
3159
3160         "Tried to fix the build."
3161         https://trac.webkit.org/changeset/239910
3162
3163         "Fixed iOS builds after r239910."
3164         https://trac.webkit.org/changeset/239912
3165
3166         "More build fixing."
3167         https://trac.webkit.org/changeset/239913
3168
3169         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3170         https://trac.webkit.org/changeset/239914
3171
3172 2019-01-14  Mark Lam  <mark.lam@apple.com>
3173
3174         Re-enable ability to build --cloop builds.
3175         https://bugs.webkit.org/show_bug.cgi?id=192955
3176         <rdar://problem/46882363>
3177
3178         Reviewed by Saam barati and Keith Miller.
3179
3180         The --cloop build option was being ignored this whole time since r236381.
3181         This patch makes it possible to build CLoop builds again.
3182
3183         * Scripts/build-jsc:
3184         * Scripts/webkitperl/FeatureList.pm:
3185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3186
3187 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3188
3189         webkitpy: Expose device_type from host-like objects
3190         https://bugs.webkit.org/show_bug.cgi?id=193406
3191         <rdar://problem/47262305>
3192
3193         Reviewed by Lucas Forschler.
3194
3195         Devices should expose device_type. As a result, all host objects should
3196         provide a device_type property, even if they do not yet define a device_type.
3197
3198         * Scripts/webkitpy/common/system/systemhost.py:
3199         (SystemHost):
3200         (SystemHost.device_type):
3201         * Scripts/webkitpy/common/system/systemhost_mock.py:
3202         (MockSystemHost):
3203         (MockSystemHost.device_type):
3204         * Scripts/webkitpy/port/device.py:
3205         (Device):
3206         (Device.device_type):
3207         * Scripts/webkitpy/xcode/simulated_device.py:
3208         (SimulatedDeviceManager._find_exisiting_device_for_request):
3209         (SimulatedDeviceManager._disambiguate_device_type):
3210         (SimulatedDeviceManager._does_fulfill_request):
3211         (SimulatedDeviceManager.device_count_for_type):
3212         (SimulatedDeviceManager.initialize_devices):
3213         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3214         (test_available_devices):
3215         (test_swapping_devices):
3216
3217 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3218
3219         webkitpy: Support alternate simctl device list output (Follow-up fix)
3220         https://bugs.webkit.org/show_bug.cgi?id=193362
3221         <rdar://problem/47122965>
3222
3223         Rubber-stamped by Lucas Forschler.
3224
3225         * Scripts/webkitpy/xcode/simulated_device.py:
3226         (SimulatedDeviceManager.populate_available_devices):
3227
3228 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3229
3230         [iOS] Expose SPI to access the current sentence boundary and selection state
3231         https://bugs.webkit.org/show_bug.cgi?id=193398
3232         <rdar://problem/45893108>
3233
3234         Reviewed by Dean Jackson.
3235
3236         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3237         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3238         expected.
3239
3240         * TestWebKitAPI/EditingTestHarness.h:
3241         * TestWebKitAPI/EditingTestHarness.mm:
3242         (-[EditingTestHarness moveBackward]):
3243         (-[EditingTestHarness moveForward]):
3244         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3245
3246         Add a couple of new helper methods on EditingTestHarness.
3247
3248         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3249         (-[SelectionChangeObserver initWithWebView:]):
3250         (-[SelectionChangeObserver webView]):
3251         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3252         (-[SelectionChangeObserver currentSelectionAttributes]):
3253
3254 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3255
3256         [LFC][BFC] Add basic box-sizing support.
3257         https://bugs.webkit.org/show_bug.cgi?id=193392
3258
3259         Reviewed by Antti Koivisto.
3260
3261         * LayoutReloaded/misc/LFC-passing-tests.txt:
3262
3263 2019-01-14  Charlie Turner  <cturner@igalia.com>
3264
3265         [WPE] API test gardening
3266         https://bugs.webkit.org/show_bug.cgi?id=193319
3267
3268         Reviewed by Michael Catanzaro.
3269
3270         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3271         passing tests.
3272
3273 2019-01-14  Charlie Turner  <cturner@igalia.com>
3274
3275         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3276         https://bugs.webkit.org/show_bug.cgi?id=192977
3277
3278         Reviewed by Carlos Garcia Campos.
3279
3280         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3281         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3282         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3283         (TestWebKitAPI::GStreamerTest::SetUp):
3284         (TestWebKitAPI::GStreamerTest::TearDown):
3285         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3286         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3287         (TestWebKitAPI::TEST_F):
3288
3289 2019-01-14  Charlie Turner  <cturner@igalia.com>
3290
3291         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3292         https://bugs.webkit.org/show_bug.cgi?id=193332
3293
3294         Reviewed by Michael Catanzaro.
3295
3296         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3297         defined as a char16_t, which changed in ICU 59, the
3298         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3299         unsigned short. This test is relying on the behaviour that
3300         UChar=unsigned short, which doesn't hold across platforms and ICU
3301         library versions. The full fix would be a special syntax for
3302         literal characters so that these ambiguities do not arise. That
3303         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3304         (TestWebKitAPI::TEST):
3305
3306 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3309
3310         * Scripts/make-dist:
3311         (Distcheck.configure):
3312
3313 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3314
3315         [ews-build] Update macOS queue configurations
3316         https://bugs.webkit.org/show_bug.cgi?id=193365
3317         <rdar://problem/47221073>
3318
3319         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3320
3321         * BuildSlaveSupport/ews-build/config.json:
3322
3323 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3324
3325         [LFC] Adjust assert for statically positioned fixed elements
3326         https://bugs.webkit.org/show_bug.cgi?id=193385
3327
3328         Reviewed by Antti Koivisto.
3329
3330         * LayoutReloaded/misc/LFC-passing-tests.txt:
3331
3332 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3333
3334         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3335         https://bugs.webkit.org/show_bug.cgi?id=193387
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         * MiniBrowser/wpe/main.cpp:
3340         (main):
3341
3342 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3343
3344         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3345         https://bugs.webkit.org/show_bug.cgi?id=191655
3346         rdar://problem/46074680
3347
3348         Reviewed by Megan Gardner.
3349
3350         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3351         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3352
3353 2019-01-12  Dan Bernstein  <mitz@apple.com>
3354
3355         [Cocoa] Avoid importing directly from subumbrella frameworks
3356         https://bugs.webkit.org/show_bug.cgi?id=186016
3357         <rdar://problem/40591038>
3358
3359         Reviewed by Sam Weinig.
3360
3361         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3362           LaunchServices header.
3363         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3364           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3365         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3366           when using SDKs earlier than 10.13.
3367         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3368           and OTHER_CPLUSPLUSFLAGS.
3369         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3370           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3371         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3372           LaunchServices header.
3373
3374 2019-01-11  John Wilander  <wilander@apple.com>
3375
3376         Compile out Web API Statistics Collection
3377         https://bugs.webkit.org/show_bug.cgi?id=193370
3378         <rdar://problem/45388584>
3379
3380         Reviewed by Brent Fulgham.
3381
3382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3383             Defined ENABLE_WEB_API_STATISTICS, off by default.
3384
3385 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3386
3387         [WPE] Add gtk-doc
3388         https://bugs.webkit.org/show_bug.cgi?id=178900
3389
3390         Reviewed by Michael Catanzaro.
3391
3392         Add Tools/gtkdoc to manifest.txt.in files.
3393         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3394
3395         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3396         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3397
3398 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3399
3400         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3401         https://bugs.webkit.org/show_bug.cgi?id=193364
3402         <rdar://problem/47214117>
3403
3404         Reviewed by Tim Horton.
3405
3406         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3407         precise, whereas dragging near the middle of the textarea does.
3408
3409         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3410         (TestWebKitAPI::TEST):
3411
3412 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3413
3414         webkitpy: Support alternate simctl device list output
3415         https://bugs.webkit.org/show_bug.cgi?id=193362
3416         <rdar://problem/47122965>
3417
3418         Reviewed by Lucas Forschler.
3419
3420         * Scripts/webkitpy/xcode/simulated_device.py:
3421         (SimulatedDeviceManager.populate_available_devices):
3422
3423 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3424
3425         [ews-build] Update macOS queue configurations
3426         https://bugs.webkit.org/show_bug.cgi?id=193365
3427
3428         Reviewed by Lucas Forschler.
3429
3430         * BuildSlaveSupport/ews-build/config.json:
3431
3432 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3433
3434         webkitpy: Incorporate device type into baseline search path
3435         https://bugs.webkit.org/show_bug.cgi?id=193356
3436         <rdar://problem/47215515>
3437
3438         Reviewed by Lucas Forschler.
3439
3440         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3441
3442         * Scripts/webkitpy/port/base.py:
3443         (Port.default_baseline_search_path): Allow device type to be passed in.
3444         * Scripts/webkitpy/port/gtk.py:
3445         (GtkPort.default_baseline_search_path): Ignore device type.
3446         * Scripts/webkitpy/port/ios.py:
3447         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3448         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3449         * Scripts/webkitpy/port/ios_device_unittest.py:
3450         (IOSDeviceTest):
3451         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3452         (IOSSimulatorTest):
3453         * Scripts/webkitpy/port/mac.py:
3454         (MacPort.default_baseline_search_path): Ignore device type.
3455         * Scripts/webkitpy/port/watch.py:
3456         (WatchPort.default_baseline_search_path): Ditto.
3457         * Scripts/webkitpy/port/win.py:
3458         (WinPort.default_baseline_search_path): Ditto.
3459         (WinCairoPort.default_baseline_search_path): Ditto.
3460         * Scripts/webkitpy/port/wpe.py:
3461         (WPEPort.default_baseline_search_path): Ditto.
3462
3463 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3464
3465         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3466         https://bugs.webkit.org/show_bug.cgi?id=193352
3467         <rdar://problem/47210736>
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * Scripts/webkitpy/layout_tests/views/printing.py:
3472         (Printer.print_config): Print list on only baseline search paths which exist. 
3473         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3474         (Testprinter.test_print_config):
3475
3476 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3477
3478         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3479         https://bugs.webkit.org/show_bug.cgi?id=193340
3480
3481         Reviewed by David Kilzer.
3482
3483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3484         (WTR::InjectedBundle::didReceiveMessageToPage):
3485         Pull the strings out into a WKRetainPtr.
3486
3487         * WebKitTestRunner/WebNotificationProvider.cpp:
3488         (WTR::WebNotificationProvider::closeWebNotification):
3489         Adopt the created value into the WKRetainPtr.
3490
3491         * WebKitTestRunner/mac/TestControllerMac.mm:
3492         (WTR::generateWhitelist):
3493         Immediately adopt a created value to avoid potential mistakes.
3494
3495 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3496
3497         Enable DFG on ARM/Linux again
3498         https://bugs.webkit.org/show_bug.cgi?id=192496
3499
3500         Reviewed by Yusuke Suzuki.
3501
3502         After changing the bytecode format DFG was disabled on all 32-bit
3503         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3504         on ARM by default.
3505
3506         * Scripts/run-jsc-stress-tests:
3507
3508 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3509
3510         Unreviewed, fix #ifdef in API test added in r239851.
3511         https://bugs.webkit.org/show_bug.cgi?id=193327
3512         rdar://problem/47093222
3513
3514         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3515
3516 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3517
3518         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3519         https://bugs.webkit.org/show_bug.cgi?id=193109
3520         <rdar://problem/44807048>
3521
3522         Reviewed by Ryosuke Niwa.
3523
3524         Introduce and respect a test option to enable the UndoManager API.
3525
3526         * WebKitTestRunner/TestController.cpp:
3527         (WTR::updateTestOptionsFromTestHeader):
3528         * WebKitTestRunner/TestOptions.h:
3529         (WTR::TestOptions::hasSameInitializationOptions const):
3530         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3531         (WTR::TestController::platformCreateWebView):
3532
3533 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3534
3535         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3536         https://bugs.webkit.org/show_bug.cgi?id=193346
3537
3538         Reviewed by Antti Koivisto.
3539
3540         * LayoutReloaded/misc/LFC-passing-tests.txt:
3541
3542 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3543
3544         Unreviewed, fix typo that breaks dashboard link.
3545
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3547         (WebKitBuildbot):
3548
3549 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3550
3551         Update macOS queue configurations
3552         https://bugs.webkit.org/show_bug.cgi?id=193329
3553
3554         Reviewed by Alexey Proskuryakov.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/config.json:
3557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3558         (BubbleQueueServer):
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3561         (WebKitBuildbot):
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3563         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3564         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3565
3566 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3567
3568         MiniBrowser should be able to navigate to about:blank
3569         https://bugs.webkit.org/show_bug.cgi?id=193345
3570
3571         Reviewed by Simon Fraser.
3572
3573         * MiniBrowser/mac/BrowserWindowController.m:
3574         (-[BrowserWindowController addProtocolIfNecessary:]):
3575         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3576
3577         * MiniBrowser/mac/WK1BrowserWindowController.m:
3578         (-[WK1BrowserWindowController fetch:]):
3579         * MiniBrowser/mac/WK2BrowserWindowController.m:
3580         (-[WK2BrowserWindowController fetch:]):
3581         Clean up the code that uses this to match style.
3582
3583 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3584
3585         Remove MiniBrowser custom "Process Swap" menu item which does not work
3586         https://bugs.webkit.org/show_bug.cgi?id=193344
3587
3588         Reviewed by Simon Fraser.
3589
3590         There is a menu item under the Experimental menu that does work.
3591
3592         * MiniBrowser/mac/AppDelegate.m:
3593         (defaultConfiguration):
3594         * MiniBrowser/mac/SettingsController.h:
3595         * MiniBrowser/mac/SettingsController.m:
3596         (-[SettingsController _populateMenu]):
3597         (-[SettingsController validateMenuItem:]):
3598         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3599         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3600
3601 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3602
3603         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3604         https://bugs.webkit.org/show_bug.cgi?id=193327
3605         rdar://problem/47093222
3606
3607         Reviewed by Tim Horton.
3608
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3611         (TestWebKitAPI::didFinishNavigation):
3612         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3615         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3616         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3617         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3618         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3619
3620 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3621
3622         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3623         https://bugs.webkit.org/show_bug.cgi?id=193338
3624         <rdar://problem/46664774>
3625
3626         Reviewed by David Kilzer.
3627
3628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3629         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3630
3631 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3632
3633         Unreviewed, rolling out r239825.
3634         https://bugs.webkit.org/show_bug.cgi?id=193330
3635
3636         Broke tests on armv7/linux bots (Requested by guijemont on
3637         #webkit).
3638
3639         Reverted changeset:
3640
3641         "Enable DFG on ARM/Linux again"
3642         https://bugs.webkit.org/show_bug.cgi?id=192496
3643         https://trac.webkit.org/changeset/239825
3644
3645 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3646
3647         Disable the run-jsc-stress-test remote host key check.
3648         https://bugs.webkit.org/show_bug.cgi?id=192988
3649
3650         Reviewed by Alexey Proskuryakov.
3651
3652         * Scripts/run-jsc-stress-tests:
3653
3654 2019-01-10  John Wilander  <wilander@apple.com>
3655
3656         Override the session configuration for cookieAcceptPolicy
3657         https://bugs.webkit.org/show_bug.cgi?id=190925
3658         <rdar://problem/45497382>
3659
3660         Reviewed by Alexey Proskuryakov and Alex Christensen.
3661
3662         Test infrastructure for setting a first-party-only cookie policy.
3663
3664         * DumpRenderTree/TestRunner.cpp:
3665         (setOnlyAcceptFirstPartyCookiesCallback):
3666         (TestRunner::staticFunctions):
3667         * DumpRenderTree/TestRunner.h:
3668         * DumpRenderTree/mac/TestRunnerMac.mm:
3669         (TestRunner::setOnlyAcceptFirstPartyCookies):
3670         * DumpRenderTree/win/TestRunnerWin.cpp:
3671         (TestRunner::setOnlyAcceptFirstPartyCookies):
3672         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3674         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3676         * WebKitTestRunner/TestInvocation.cpp:
3677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3678
3679 2019-01-09  Matt Rajca  <mrajca@apple.com>
3680
3681         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3682         https://bugs.webkit.org/show_bug.cgi?id=193301
3683
3684         Reviewed by Jer Noble.
3685         
3686         Added API tests.
3687
3688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3689         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3690         (TEST):
3691         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3692
3693 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3694
3695         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3696         https://bugs.webkit.org/show_bug.cgi?id=193310
3697
3698         Reviewed by Antti Koivisto.
3699
3700         * LayoutReloaded/misc/LFC-passing-tests.txt:
3701
3702 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3703
3704         Enable DFG on ARM/Linux again
3705         https://bugs.webkit.org/show_bug.cgi?id=192496
3706
3707         Reviewed by Yusuke Suzuki.
3708
3709         After changing the bytecode format DFG was disabled on all 32-bit
3710         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3711         on ARM by default.
3712
3713         * Scripts/run-jsc-stress-tests:
3714
3715 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3716
3717         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3718         https://bugs.webkit.org/show_bug.cgi?id=193271
3719
3720         Reviewed by Brent Fulgham.
3721
3722         BSTR is a special data structure created by SysAllocString, not a
3723         wchar_t null-terminated string.
3724
3725         * DumpRenderTree/win/TestRunnerWin.cpp:
3726         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3727         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3728         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3729         BSTR from wide string literals.
3730
3731 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3732
3733         Tweak wording for build/version_check style checker error
3734         https://bugs.webkit.org/show_bug.cgi?id=193256
3735
3736         Reviewed by Tim Horton.
3737
3738         * Scripts/webkitpy/style/checkers/cpp.py:
3739         (check_os_version_checks):
3740         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3741         (WebKitStyleTest.test_os_version_checks):
3742
3743 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3744
3745         [ews-build] Add link to bug along with bug title
3746         https://bugs.webkit.org/show_bug.cgi?id=193293
3747
3748         Reviewed by Lucas Forschler.
3749
3750         * BuildSlaveSupport/ews-build/steps.py:
3751         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3752         (ConfigureBuild.add_bug_id_url): Deleted.
3753         (ConfigureBuild.getBugURL): Deleted.
3754
3755 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3756
3757         [ews-build] Use https for ews-build server
3758         https://bugs.webkit.org/show_bug.cgi?id=193193
3759
3760         Reviewed by Lucas Forschler.
3761
3762         * BuildSlaveSupport/ews-build/steps.py:
3763
3764 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3765
3766         [ews-build] Parse and display number of style failures
3767         https://bugs.webkit.org/show_bug.cgi?id=193280
3768
3769         Reviewed by Lucas Forschler.
3770
3771         * BuildSlaveSupport/ews-build/steps.py:
3772         (CheckStyle): Use TestWithFailureCount as base class.
3773         (CheckStyle.countFailures): Count the number of style failures.
3774
3775 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3776
3777         [ews-build] use patch_id instead of ewspatchid
3778         https://bugs.webkit.org/show_bug.cgi?id=193235
3779
3780         Reviewed by Lucas Forschler.
3781
3782         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3783         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3784         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3785
3786 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3787
3788         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3789         https://bugs.webkit.org/show_bug.cgi?id=192625
3790
3791         Reviewed by Antti Koivisto.
3792
3793         * LayoutReloaded/misc/LFC-passing-tests.txt:
3794
3795 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3796
3797         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3798         https://bugs.webkit.org/show_bug.cgi?id=192841
3799
3800         Reviewed by Carlos Garcia Campos.
3801
3802         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3803         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3804         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3805
3806         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3807
3808         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3809         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3810         (WebKitWebEditorTest::testSelectionChanged):
3811         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3812         (WebKitFrameTest::testMainFrame):
3813         (WebKitFrameTest::testURI):
3814         (WebKitFrameTest::testJavaScriptContext):
3815         (WebKitFrameTest::testJavaScriptValues):
3816         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3817         (testWebViewAuthenticationRequest):
3818         (testWebViewAuthenticationLoadCancelled):
3819         (testWebViewAuthenticationFailure):
3820         (testWebViewAuthenticationStorage):
3821         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3822         (testWebViewAuthenticationProxy):
3823         (testWebViewAuthenticationProxyHTTPS):
3824         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3825         (testAutomationSessionRequestSession):
3826         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3827         (testBackForwardListNavigation):
3828         (testWebKitWebViewSessionState):
3829         (testWebKitWebViewSessionStateWithFormData):
3830         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3831         (ConsoleMessageTest::consoleMessageReceivedCallback):
3832         (testWebKitConsoleMessageConsoleAPI):
3833         (testWebKitConsoleMessageJavaScriptException):
3834         (testWebKitConsoleMessageNetworkError):
3835         (testWebKitConsoleMessageSecurityError):
3836         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3837         (testCookieManagerAcceptPolicy):
3838         (testCookieManagerCookiesChanged):
3839         (testCookieManagerPersistentStorage):
3840         (testCookieManagerPersistentStorageDeleteAll):
3841         (testCookieManagerEphemeral):
3842         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3843         (testWebKitDOMElementAutoFill):
3844         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3845         (downloadLocalFileSuccessfully):
3846         (createFileAtDestination):
3847         (testDownloadOverwriteDestinationDisallowed):
3848         (testDownloadLocalFileError):
3849         (testDownloadRemoteFile):
3850         (testDownloadRemoteFileError):
3851         (testWebViewDownloadURI):
3852         (testPolicyResponseDownload):
3853         (testPolicyResponseDownloadCancel):
3854         (testDownloadMIMEType):
3855         (contextMenuCallback):
3856         (testContextMenuDownloadActions):
3857         (testBlobDownload):
3858         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3859         (testWebKitWebEditorSelectionChanged):
3860         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3861         (testWebKitFrameMainFrame):
3862         (testWebKitFrameURI):
3863         (testWebKitFrameJavaScriptContext):
3864         (testWebKitFrameJavaScriptValues):
3865         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3866         (LoadStopTrackingTest::loadFailed):
3867         (testWebViewTitle):
3868         (testURIRequestHTTPHeaders):
3869         (testURIRequestHTTPMethod):
3870         (testURIResponseHTTPHeaders):
3871         (testRedirectToDataURI):
3872         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3873         (testProcessPerWebView):
3874         (testWebProcessLimit):
3875         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3876         (testWebViewResources):
3877         (testWebResourceLoading):
3878         (testWebResourceSuggestedFilename):
3879         (testWebResourceGetData):
3880         (testWebResourceGetDataError):
3881         (testWebViewResourcesHistoryCache):
3882         (testWebResourceSendRequest):
3883         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3884         (testSSL):
3885         (testInsecureContent):
3886         (testTLSErrorsPolicy):
3887         (testTLSErrorsRedirect):
3888         (testTLSErrorsHTTPAuth):
3889         (testLoadFailedWithTLSErrors):
3890         (testSubresourceLoadFailedWithTLSErrors):
3891         (httpsServerCallback):
3892         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3893         (testWebViewCreateNavigationData):
3894         (testWebViewJavaScriptDialogs):
3895         (testWebViewWindowProperties):
3896         (testWebViewMouseTarget):
3897         (testWebViewFileChooserRequest):
3898         (testWebViewColorChooserRequest):
3899         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3900         (testWebExtensionGetTitle):
3901         (testDocumentLoadedSignal):
3902         (testWebKitWebViewProcessCrashed):
3903         (testWebExtensionWindowObjectCleared):
3904         (testWebExtensionIsolatedWorld):
3905         (permissionRequestCallback):
3906         (didAssociateFormControlsCallback):
3907         (testWebExtensionFormControlsAssociated):
3908         (FormSubmissionTest::FormSubmissionTest):
3909         (FormSubmissionTest::testFormSubmissionResult):
3910         (testWebExtensionFormSubmissionSteps):
3911         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3912         (testNotInitialized):
3913         (testClearDatabase):
3914         (testPrivateBrowsing):
3915         (testGetFavicon):
3916         (testWebViewFavicon):
3917         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3918         (testFindControllerTextFound):
3919         (testFindControllerTextNotFound):
3920         (testFindControllerMatchCount):
3921         (testFindControllerMaxMatchCount):
3922         (testFindControllerNext):
3923         (testFindControllerPrevious):
3924         (testFindControllerCountedMatches):
3925         (testFindControllerOptions):
3926         (testFindControllerHide):
3927         (testFindControllerInstance):
3928         (testFindControllerGetters):
3929         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3930         (testNavigationPolicy):
3931         (testResponsePolicy):
3932         (testNewWindowPolicy):
3933         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3934         (testSecurityOriginBasicConstructor):
3935         (testSecurityOriginURIConstructor):
3936         (testSecurityOriginDefaultPort):
3937         (testSecurityOriginFileURI):
3938         (testOpaqueSecurityOrigin):
3939         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3940         (testWebKitSettings):
3941         (testWebKitSettingsNewWithSettings):
3942         (testWebKitSettingsUserAgent):
3943         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3944         (testWebViewNewWithUserContentManager):
3945         (isStyleSheetInjectedForURLAtPath):
3946         (isScriptInjectedForURLAtPath):
3947         (testUserContentManagerInjectedStyleSheet):
3948         (testUserContentManagerInjectedScript):
3949         (UserScriptMessageTest::scriptMessageReceived):
3950         (UserScriptMessageTest::waitUntilMessageReceived):
3951         (UserScriptMessageTest::runJavaScriptFinished):
3952         (testUserContentManagerScriptMessageReceived):
3953         (testUserContentManagerScriptMessageInWorldReceived):
3954         (testUserContentManagerScriptMessageFromDOMBindings):
3955         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3956         (testWebContextDefault):
3957         (testWebContextEphemeral):
3958         (testWebContextGetPlugins):
3959         (testWebContextURIScheme):
3960         (testWebContextSpellChecker):
3961         (testWebContextLanguages):
3962         (consoleMessageReceivedCallback):
3963         (testWebContextSecurityFileXHR):
3964         (ProxyTest::ProxyTest):
3965         (testWebContextProxySettings):
3966         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3967         (testWebViewWebContext):
3968         (testWebViewWebBackend):
3969         (testWebViewEphemeral):
3970         (testWebViewCustomCharset):
3971         (testWebViewSettings):
3972         (testWebViewRunJavaScript):
3973         (testWebViewCanShowMIMEType):
3974         (testWebViewSubmitForm):
3975         (testWebViewSave):
3976         (testWebViewPageVisibility):
3977         (testWebViewSnapshot):
3978         (testWebViewNotification):
3979         (testWebViewNotificationInitialPermissionAllowed):
3980         (testWebViewNotificationInitialPermissionDisallowed):
3981         (testWebViewIsPlayingAudio):
3982         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3983         (WebsiteDataTest::WebsiteDataTest):
3984         (WebsiteDataTest::remove):
3985         (WebsiteDataTest::clear):
3986         (testWebsiteDataConfiguration):
3987         (testWebsiteDataEphemeral):
3988         (testWebsiteDataCache):
3989         (testWebsiteDataStorage):
3990         (testWebsiteDataDatabases):
3991         (testWebsiteDataAppcache):
3992         (testWebsiteDataCookies):
3993         (testWebsiteDataDeviceIdHashSalt):
3994         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3995         (emitDocumentLoaded):
3996         (emitURIChanged):
3997         (sendRequestCallback):
3998         (contextMenuCallback):
3999         (consoleMessageSentCallback):
4000         (emitFormControlsAssociated):
4001         (formControlsAssociatedCallback):
4002         (emitFormSubmissionEvent):
4003         (willSubmitFormCallback):
4004         (windowObjectCleared):
4005         (methodCallCallback):
4006         (registerGResource):
4007         (webkit_web_extension_initialize_with_user_data):
4008         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4009         (checkLeaks):
4010         (WebProcessTest::create):
4011         (runTest):
4012         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4013         (AutocleanupsTest::testWebProcessAutocleanups):
4014         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4015         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4016         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4017         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4018         (WebKitDOMDOMWindowTest::testSignals):
4019         (WebKitDOMDOMWindowTest::testDispatchEvent):
4020         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4021         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4022         (WebKitDOMNodeFilterTest::testTreeWalker):
4023         (WebKitDOMNodeFilterTest::testNodeIterator):
4024         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4025         (WebKitDOMNodeTest::testHierarchyNavigation):
4026         (WebKitDOMNodeTest::testInsertion):
4027         (WebKitDOMNodeTest::testTagNamesNodeList):
4028         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4029         (WebKitDOMNodeTest::testDOMCache):
4030         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4031         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4032         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4033         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4034         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4035         (testUIProcessAutocleanups):
4036         (testWebProcessAutocleanups):
4037         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4038         (testContextMenuPopulateMenu):
4039         (testContextMenuDismissed):
4040         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4041         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4042         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4043         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4044         (testWebKitDOMDOMWindowSignals):
4045         (testWebKitDOMDOMWindowDispatchEvent):
4046         (testWebKitDOMDOMWindowGetComputedStyle):
4047         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4048         (testWebKitDOMNodeHierarchyNavigation):
4049         (testWebKitDOMNodeInsertion):
4050         (testWebKitDOMNodeTagNamesNodeList):
4051         (testWebKitDOMNodeTagNamesHTMLCollection):
4052         (testWebKitDOMObjectCache):
4053         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4054         (testWebKitDOMNodeFilterTreeWalker):
4055         (testWebKitDOMNodeFilterNodeIterator):
4056         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4057         (testWebKitDOMXPathNSResolverNative):
4058         (testWebKitDOMXPathNSResolverCustom):
4059         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4060         (testInspectorDefault):
4061         (testInspectorManualAttachDetach):
4062         (testInspectorCustomContainerDestroyed):
4063         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4064         (startTestServer):
4065         (testInspectorServerPageList):
4066         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4067         (OptionMenuTest::showOptionMenuCallback):
4068         (OptionMenuTest::menuCloseCallback):
4069         (OptionMenuTest::close):
4070         (OptionMenuTest::activateItem):
4071         (OptionMenuTest::selectItem):
4072         (testOptionMenuSimple):
4073         (testOptionMenuGroups):
4074         (testOptionMenuActivate):
4075         (testOptionMenuSelect):
4076         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4077         (testPrintOperationPrintSettings):
4078         (webViewPrintCallback):
4079         (testPrintOperationPrint):
4080         (testPrintCustomWidget):
4081         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4082         (checkAtspiAccessible):
4083         (testAtspiBasicHierarchy):
4084         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4085         (testWebKitCheckVersion):
4086         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4087         (testWebViewEditorCutCopyPasteNonEditable):
4088         (testWebViewEditorCutCopyPasteEditable):
4089         (testWebViewEditorSelectAllNonEditable):
4090         (testWebViewEditorSelectAllEditable):
4091         (loadContentsAndTryToCutSelection):
4092         (testWebViewEditorNonEditable):
4093         (testWebViewEditorEditable):
4094         (testWebViewEditorEditorStateTypingAttributes):
4095         (testWebViewEditorInsertImage):
4096         (testWebViewEditorCreateLink):
4097         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4098         (loadChangedCallback):
4099         (loadFailedCallback):
4100         (loadFailedWithTLSErrorsCallback):
4101         (LoadTrackingTest::LoadTrackingTest):
4102         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4103         (registerGResource):
4104         (removeNonEmptyDirectory):
4105         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4106         (Test::adoptView):
4107         (Test::~Test):
4108         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4109         (WebKitTestBus::getOrCreateConnection):
4110         (WebKitTestBus::createProxy):
4111         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4112         (WebKitTestServer::getWebSocketURIForPath const):
4113         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4114         (WebViewTest::initializeWebView):
4115         (WebViewTest::loadURI):
4116         (WebViewTest::loadHtml):
4117         (WebViewTest::loadPlainText):
4118         (WebViewTest::loadBytes):
4119         (WebViewTest::loadRequest):
4120         (WebViewTest::loadAlternateHTML):
4121         (WebViewTest::goBack):
4122         (WebViewTest::goForward):
4123         (WebViewTest::goToBackForwardListItem):
4124         (resourceGetDataCallback):
4125         (WebViewTest::mainResourceData):
4126         (WebViewTest::javascriptResultToCString):
4127         (WebViewTest::javascriptResultToNumber):
4128         (WebViewTest::javascriptResultToBoolean):
4129         (WebViewTest::javascriptResultIsNull):
4130         (WebViewTest::javascriptResultIsUndefined):
4131         (onSnapshotReady):
4132         (WebViewTest::runWebProcessTest):
4133         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4134         (WebViewTest::platformInitializeWebView):
4135         (WebViewTest::showInWindow):
4136         (WebViewTest::showInWindowAndWaitUntilMapped):
4137         (WebViewTest::mouseMoveTo):
4138         (WebViewTest::emitPopupMenuSignal):
4139         (WebViewTest::keyStroke):
4140         (WebViewTest::doMouseButtonEvent):
4141
4142 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4143
4144         [WPE] API tests can't run in flatpak environment
4145         https://bugs.webkit.org/show_bug.cgi?id=193242
4146
4147         Reviewed by Michael Catanzaro.
4148
4149         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4150         flatpakutils so that it knows which port it's dealing with.
4151         * glib/common.py: Remove build_dir globals so that subsequent
4152         calls actually take args into account.
4153         (library_build_path):
4154         (binary_build_path):
4155
4156 2019-01-08  Dean Jackson  <dino@apple.com>
4157
4158         Blob references for System Previews don't get a correct file extension
4159         https://bugs.webkit.org/show_bug.cgi?id=193268
4160         <rdar://problem/47133037>
4161
4162         Reviewed by Tim Horton.
4163
4164         New test that a Blob download of a USDZ file gets named correctly.
4165
4166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4167         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4168         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4169         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4170         (TEST):
4171         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4172
4173 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4174
4175         [WebAuthN] Support U2F HID Authenticators on macOS
4176         https://bugs.webkit.org/show_bug.cgi?id=191535
4177         <rdar://problem/47102027>
4178
4179         Reviewed by Brent Fulgham.
4180
4181         This patch:
4182         1) adds support for U2F mocking mechanism;
4183         2) updates tests to reflect U2fCommandConstructor changes.
4184
4185         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4186         (TestWebKitAPI::TEST):
4187         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4189         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4190
4191 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4192
4193         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4194         https://bugs.webkit.org/show_bug.cgi?id=193229
4195         <rdar://problem/46717097>
4196
4197         Reviewed by Tim Horton.
4198
4199         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4200         prevents a drag from starting.
4201
4202         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4203         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4204
4205         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4206
4207 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4208   
4209         Layout test will generate a perf metric file to results dir.
4210         https://bugs.webkit.org/show_bug.cgi?id=192030
4211         <rdar://problem/32779516>
4212
4213         Reviewed by Aakash Jain.
4214
4215         Layout test running time will be collected to a perf metric file.
4216         For now, instead of outputing running time of all tests (which is huge),
4217         we aggregate them by test directories which are at most two level deep. 
4218
4219         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4220         (Manager._end_test_run):
4221         (Manager._output_perf_metrics):
4222         (Manager._print_expectation_line_for_test):
4223         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4224         (add_test_perf_metric):
4225         (test_perf_metrics):
4226         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4227         (JSONGeneratorTest.test_test_timings_trie):
4228         (JSONGeneratorTest):
4229         (JSONGeneratorTest.test_test_perf_metrics):
4230         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4231         (RebaselineTest.test_reset_results):
4232         (RebaselineTest.test_missing_results):
4233         (RebaselineTest.test_new_baseline):
4234
4235 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
4236
4237         [WPE][GTK] Add php-json to install-dependencies
4238         https://bugs.webkit.org/show_bug.cgi?id=193233
4239
4240         Reviewed by Michael Catanzaro.
4241
4242         * gtk/install-dependencies:
4243         * wpe/install-dependencies:
4244
4245 2019-01-08  Chris Dumez  <cdumez@apple.com>
4246
4247         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4248         https://bugs.webkit.org/show_bug.cgi?id=193224
4249         <rdar://problem/47097726>
4250
4251         Reviewed by Alex Christensen.
4252
4253         Add API test coverage.
4254
4255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4256
4257 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4258
4259         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4260         <https://webkit.org/b/193222>
4261         <rdar://problem/46862309>
4262
4263         Reviewed by Joseph Pecoraro.
4264
4265         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4266         (WTR::executeCallback): Fix camel case of variable name.
4267         (WTR::EventSendingController::callAfterScrollingCompletes): If
4268         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4269         false, make sure to release the ScrollCompletionCallbackData
4270         object.  This fixes the leak.
4271
4272 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4273
4274         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4275         https://bugs.webkit.org/show_bug.cgi?id=193044
4276
4277         Reviewed by Daniel Bates.
4278
4279         WinCairo EWS bots are using Windows Perl. Binary files should be
4280         opened as binary mode.
4281
4282         * Scripts/svn-apply:
4283         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4284
4285 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4286
4287         [CMake] Add ENABLE_CSS_TYPED_OM option
4288         https://bugs.webkit.org/show_bug.cgi?id=193216
4289
4290         Reviewed by Michael Catanzaro.
4291
4292         * Scripts/webkitperl/FeatureList.pm:
4293
4294 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4295
4296         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
4297         <https://webkit.org/b/193056>
4298
4299         Reviewed by Alex Christensen.
4300
4301         * Scripts/webkitpy/style/checker.py:
4302         - Ignore use of new runtime/retainptr check in
4303           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
4304           contains tests to ensure RetainPtr<NSObject *> is compatible
4305           with RetainPtr<NSObject>.
4306
4307         * Scripts/webkitpy/style/checkers/cpp.py:
4308         (check_language):
4309         (CppChecker):
4310         - Add checker for use of '*' in RetainPtr<> type.  A for loop
4311           was used instead of a single regex so that angle brackets
4312           could be matched up when checking the type contained within
4313           the RetainPtr<> type.
4314
4315         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4316         (CppStyleTest):
4317         - Add unit test for new runtime/retainptr check.
4318
4319         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
4320         * TestWebKitAPI/EditingTestHarness.h:
4321         - Remove '*' from RetainPtr<> type.
4322
4323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4324         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This</