Tools/ChangeLog

   1 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
   2
   3         [WPE] Enable web process sandbox
   4         https://bugs.webkit.org/show_bug.cgi?id=195169
   5
   6         Reviewed by Daniel Bates.
   7
   8         * wpe/install-dependencies:
   9         * wpe/jhbuild.modules:
  10
  11 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
  12
  13         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
  14         https://bugs.webkit.org/show_bug.cgi?id=195206
  15
  16         Reviewed by Žan Doberšek.
  17
  18         Add a new test case.
  19
  20         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
  21         (testJSCClass):
  22
  23 2019-03-04  Charlie Turner  <cturner@igalia.com>
  24
  25         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
  26         https://bugs.webkit.org/show_bug.cgi?id=194898
  27
  28         Reviewed by Žan Doberšek.
  29
  30         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
  31         a GCC extension that permits arithmetic on void* pointer. Inline
  32         the macro until this issue is fixed upstream.
  33
  34 2019-03-03  Tim Horton  <timothy_horton@apple.com>
  35
  36         Rid the world of WK_API_ENABLED
  37         https://bugs.webkit.org/show_bug.cgi?id=195263
  38
  39         Reviewed by Dan Bernstein.
  40
  41         List of changed files elided because it's useless.
  42
  43 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
  44
  45         Unreviewed follow-up to r242292.
  46
  47         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
  48
  49         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
  50         (TestWebKitAPI::testStrip): Renamed from strip.
  51         (TestWebKitAPI::TEST):
  52
  53 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
  54
  55         Unreviewed, remove accidentally-committed URLHelpers.cpp test
  56
  57         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
  58         and bug #194272 for details.
  59
  60         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
  61
  62 2019-03-03  Tim Horton  <timothy_horton@apple.com>
  63
  64         Remove some more unused 32-bit code
  65         https://bugs.webkit.org/show_bug.cgi?id=195255
  66
  67         Reviewed by Darin Adler.
  68
  69         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  70         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
  71         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  72         (NPP_New):
  73         (NPP_HandleEvent):
  74         (handleEventCarbon): Deleted.
  75
  76 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
  77
  78         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
  79
  80         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
  81         (TestWebKitAPI::TEST):
  82
  83 2019-03-01  Darin Adler  <darin@apple.com>
  84
  85         Finish removing String::format
  86         https://bugs.webkit.org/show_bug.cgi?id=194893
  87
  88         Reviewed by Daniel Bates.
  89 '
  90         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
  91
  92 2019-03-01  Alex Christensen  <achristensen@webkit.org>
  93
  94         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
  95         https://bugs.webkit.org/show_bug.cgi?id=195229
  96         <rdar://problem/48520362>
  97
  98         Reviewed by Chris Dumez.
  99
 100         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
 101         (TEST):
 102
 103 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
 104
 105         Add a system trace scope for event region building
 106         https://bugs.webkit.org/show_bug.cgi?id=195226
 107
 108         Reviewed by Jon Lee.
 109
 110         This trace scope measures the time spend converting element rects into Region objects,
 111         which can be large on some pages.
 112
 113         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
 114
 115         * Tracing/SystemTracePoints.plist:
 116
 117 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
 118
 119         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
 120         https://bugs.webkit.org/show_bug.cgi?id=194612
 121
 122         Reviewed by Alex Christensen.
 123
 124         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
 125         Just test the new string-processing function and don't touch the actual environment.
 126         (Test cases are all as before, but based on operator== instead of strcmp.)
 127
 128 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
 129
 130         [ews-app] Update primary keys for handling multiple Buildbot instances
 131         https://bugs.webkit.org/show_bug.cgi?id=195120
 132
 133         Reviewed by Stephanie Lewis.
 134
 135         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
 136         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
 137         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
 138
 139         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
 140         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
 141         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
 142         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
 143         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
 144         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
 145
 146 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
 147
 148         [WinCairo] Enable service worker
 149         https://bugs.webkit.org/show_bug.cgi?id=188318
 150
 151         Reviewed by Youenn Fablet.
 152
 153         * DumpRenderTree/DumpRenderTreePrefix.h:
 154         * TestWebKitAPI/PlatformWin.cmake:
 155         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
 156         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
 157         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
 158
 159 2019-03-01  Justin Fan  <justin_fan@apple.com>
 160
 161         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
 162         https://bugs.webkit.org/show_bug.cgi?id=195191
 163
 164         Rubber-stamped by Dean Jackson.
 165
 166         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
 167
 168         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 169
 170 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
 171
 172         Unreviewed, fix lldb webkitpy tests
 173         https://bugs.webkit.org/show_bug.cgi?id=194375
 174
 175         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
 176
 177         * lldb/lldb_webkit.py:
 178         (WTFStringImplProvider.is_8bit):
 179
 180 2019-02-28  David Quesada  <david_quesada@apple.com>
 181
 182         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
 183         https://bugs.webkit.org/show_bug.cgi?id=195121
 184         rdar://problem/48450302
 185
 186         Reviewed by Alex Christensen.
 187
 188         Add API tests for -WKNavigationAction._shouldPerformDownload in various
 189         configurations where the 'download' attribute is absent, blank, or populated
 190         with a filename, and where the anchor element is same-origin or cross-origin
 191         (meaning the 'download' attribute shouldn't be honored).
 192
 193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 194         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
 195         (-[NavigationActionTestDelegate init]):
 196         (-[NavigationActionTestDelegate navigationAction]):
 197         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
 198         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
 199         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
 200         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
 201         (TEST):
 202
 203 2019-02-28  Antoine Quint  <graouts@apple.com>
 204
 205         Enable the Pointer Events runtime flag by default
 206         https://bugs.webkit.org/show_bug.cgi?id=195156
 207
 208         Reviewed by Dean Jackson.
 209
 210         * DumpRenderTree/mac/DumpRenderTree.mm:
 211         (enableExperimentalFeatures):
 212
 213 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
 214
 215         Several PasteImage API tests are flaky
 216         https://bugs.webkit.org/show_bug.cgi?id=195160
 217
 218         Reviewed by Tim Horton.
 219
 220         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
 221         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
 222         listening for a "load" event after image load is already complete.
 223
 224         To address this, make these tests first register a "load" event handler, then run script to insert an image
 225         element into the document, and finally wait until the load event is observed before checking image size.
 226
 227         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
 228
 229 2019-02-28  Chris Dumez  <cdumez@apple.com>
 230
 231         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
 232         https://bugs.webkit.org/show_bug.cgi?id=195107
 233
 234         Reviewed by Alex Christensen.
 235
 236         Give some time for the zoom level to get restored.
 237
 238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 239
 240 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
 241
 242         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
 243         https://bugs.webkit.org/show_bug.cgi?id=194958
 244
 245         Reviewed by Geoffrey Garen.
 246
 247         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
 248         (TEST):
 249
 250 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
 251
 252         [ews-app] Update method to save build to handle builder_display_name
 253         https://bugs.webkit.org/show_bug.cgi?id=195047
 254
 255         Reviewed by Dewei Zhu.
 256
 257         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
 258         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
 259
 260 2019-02-28  Justin Fan  <justin_fan@apple.com>
 261
 262         [Web GPU] Enable Web GPU only on 64-bit
 263         https://bugs.webkit.org/show_bug.cgi?id=195139
 264
 265         Because Metal is only supported on 64 bit apps.
 266
 267         Unreviewed build fix.
 268
 269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 270
 271 2019-02-27  Youenn Fablet  <youenn@apple.com>
 272
 273         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
 274         https://bugs.webkit.org/show_bug.cgi?id=194959
 275
 276         Reviewed by Chris Dumez.
 277
 278         Spin loop until getting the condition to remove flakiness.
 279
 280         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
 281
 282 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
 283
 284         [ews-build] Buildbot should include builder_display_name in the build events
 285         https://bugs.webkit.org/show_bug.cgi?id=195045
 286
 287         Reviewed by Dewei Zhu.
 288
 289         * BuildSlaveSupport/ews-build/events.py:
 290         (Events.buildStarted): Included builder_display_name in event data. Also renamed
 291         buildername to builder_name to be consistent in naming style.
 292         (Events.buildFinished): Ditto.
 293
 294 2019-02-27  Chris Dumez  <cdumez@apple.com>
 295
 296         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
 297         https://bugs.webkit.org/show_bug.cgi?id=194480
 298
 299         Reviewed by Brady Eidson.
 300
 301         Update existing API test to make it more likely to reproduce the issue.
 302
 303         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 304
 305 2019-02-27  Brady Eidson  <beidson@apple.com>
 306
 307         Universal links from Google search results pages don't open the app.
 308         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
 309
 310         Reviewed by Geoffrey Garen.
 311
 312         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
 313         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
 314         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
 315         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
 316
 317 2019-02-27  Chris Dumez  <cdumez@apple.com>
 318
 319         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
 320         https://bugs.webkit.org/show_bug.cgi?id=195102
 321
 322         Reviewed by Geoffrey Garen.
 323
 324         If the number of processes is not yet what we expect, wait a bit and check again to give
 325         processes some time to exit.
 326
 327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 328
 329 2019-02-27  Chris Dumez  <cdumez@apple.com>
 330
 331         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
 332         https://bugs.webkit.org/show_bug.cgi?id=194545
 333
 334         Reviewed by Brady Eidson.
 335
 336         Make sure the test navigates forward and then back only once. Previously, navigating
 337         back would trigger a navigation again in a timer.
 338
 339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 340
 341 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
 342
 343         High Sierra Debug JSC test queue should use faster hardware
 344         https://bugs.webkit.org/show_bug.cgi?id=194603
 345
 346         Rubber-stamped by Alexey Proskuryakov.
 347
 348         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
 349
 350         * BuildSlaveSupport/build.webkit.org-config/config.json:
 351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 352         (BubbleQueueServer):
 353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 354         (WebKitBuildbot):
 355         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
 356         * QueueStatusServer/config/queues.py:
 357         * Scripts/webkitpy/common/config/ews.json:
 358         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 359         (test_ews_name):
 360
 361 2019-02-27  John Wilander  <wilander@apple.com>
 362
 363         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
 364         https://bugs.webkit.org/show_bug.cgi?id=195071
 365         <rdar://problem/48417690>
 366
 367         Reviewed by Alex Christensen and Brent Fulgham.
 368
 369         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
 370         (TestWebKitAPI::createURL):
 371             Convenience function.
 372         (TestWebKitAPI::TEST):
 373             WebCore::AdClickAttribution now takes a URL when creating Source and
 374             Destination.
 375         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
 376         (TestWebKitAPI::TEST):
 377             WebCore::AdClickAttribution now takes a URL when creating Source and
 378             Destination.
 379
 380 2019-02-27  Antoine Quint  <graouts@apple.com>
 381
 382         Support Pointer Events on macOS
 383         https://bugs.webkit.org/show_bug.cgi?id=195008
 384         <rdar://problem/47454419>
 385
 386         Reviewed by Dean Jackson.
 387
 388         * DumpRenderTree/mac/DumpRenderTree.mm:
 389         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
 390         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 391
 392 2019-02-26  Mark Lam  <mark.lam@apple.com>
 393
 394         Remove remaining poisoning code.
 395         https://bugs.webkit.org/show_bug.cgi?id=194138
 396
 397         Reviewed by Saam Barati.
 398
 399         * TestWebKitAPI/CMakeLists.txt:
 400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 401         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
 402         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
 403         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
 404         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
 405         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
 406         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
 407
 408 2019-02-26  Alex Christensen  <achristensen@webkit.org>
 409
 410         Move ephemeral local storage from WebProcess to UIProcess
 411         https://bugs.webkit.org/show_bug.cgi?id=195074
 412         <rdar://problem/47937975>
 413
 414         Reviewed by Geoff Garen.
 415
 416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 417
 418 2019-02-20  Jer Noble  <jer.noble@apple.com>
 419
 420         [Cocoa] Media elements will restart network buffering just before suspending
 421         https://bugs.webkit.org/show_bug.cgi?id=193691
 422
 423         Reviewed by Eric Carlson.
 424
 425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
 427         (TEST):
 428
 429 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
 430
 431         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
 432         https://bugs.webkit.org/show_bug.cgi?id=191652
 433
 434         Reviewed by Alex Christensen.
 435
 436         Fix WinCairo MiniBrowser behavior of authentication dialog.
 437
 438         * MiniBrowser/win/WebKitBrowserWindow.cpp:
 439         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
 440
 441 2019-02-26  Youenn Fablet  <youenn@apple.com>
 442
 443         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
 444         https://bugs.webkit.org/show_bug.cgi?id=195028
 445         <rdar://problem/48243733>
 446
 447         Reviewed by Eric Carlson.
 448
 449         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 450
 451 2019-02-26  Philippe Normand  <pnormand@igalia.com>
 452
 453         [WPE] Add API for webview background color configuration
 454         https://bugs.webkit.org/show_bug.cgi?id=192305
 455
 456         Reviewed by Michael Catanzaro.
 457
 458         * MiniBrowser/wpe/main.cpp:
 459         (main): Add a new option to configure the webview background
 460         color. Example: --bg-color=transparent.
 461         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
 462         (testWebViewBackgroundColor): Enable background color API tests for WPE.
 463         (beforeAll): Ditto.
 464
 465 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
 466
 467         scalableNativeWebpageParameters() is not preserved on new page navigation.
 468         https://bugs.webkit.org/show_bug.cgi?id=194892
 469         <rdar://problem/47538280>
 470
 471         Reviewed by Wenson Hsieh.
 472
 473         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
 474
 475         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 476         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
 477         * DumpRenderTree/mac/UIScriptControllerMac.mm:
 478         (WTR::UIScriptController::allowsViewportShrinkToFit):
 479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 480         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
 481         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
 482         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 483         * WebKitTestRunner/UIScriptControllerCocoa.mm:
 484         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
 485
 486 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
 487
 488         [ews-app] Add model for handling multiple Buildbot instances
 489         https://bugs.webkit.org/show_bug.cgi?id=194863
 490
 491         Reviewed by Stephanie Lewis.
 492
 493         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
 494
 495 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
 496
 497         [ews-app] Remove BuilderMapping table
 498         https://bugs.webkit.org/show_bug.cgi?id=194961
 499
 500         Reviewed by Stephanie Lewis.
 501
 502         Store builder name directly in build table, instead of having a separate
 503         table for it.
 504
 505         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
 506         * BuildSlaveSupport/ews-app/ews/models/build.py:
 507         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
 508         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
 509
 510 2019-02-25  John Wilander  <wilander@apple.com>
 511
 512         Introduce and adopt new class RegistrableDomain for eTLD+1
 513         https://bugs.webkit.org/show_bug.cgi?id=194791
 514         <rdar://problem/48179240>
 515
 516         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
 517
 518         This patch adds an API test and replaces two instances of
 519         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
 520
 521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 522         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
 523         (TestWebKitAPI::TEST):
 524             Changed two strings to make sure the registrable domains are still considered
 525             invalid and pass the test.
 526         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
 527         (TestWebKitAPI::TEST):
 528         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 529         (WTR::InjectedBundle::didReceiveMessageToPage):
 530
 531 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
 532
 533         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
 534         https://bugs.webkit.org/show_bug.cgi?id=195001
 535
 536         Reviewed by Carlos Garcia Campos.
 537
 538         API version 1.0 always includes the functionality previously guarded with
 539         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
 540         unconditionally.
 541
 542         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
 543         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
 544         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
 545         (WebViewTest::showInWindow): Ditto.
 546         (WebViewTest::hideView): Ditto.
 547         * wpe/backends/HeadlessViewBackend.cpp:
 548         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
 549         * wpe/backends/ViewBackend.cpp:
 550         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
 551         * wpe/backends/WindowViewBackend.cpp:
 552         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
 553         WPE_BACKEND_CHECK_VERSION().
 554         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
 555
 556 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
 557
 558         [Flatpak] Add support for flatpak > 1.1.2
 559         https://bugs.webkit.org/show_bug.cgi?id=194088
 560
 561         Flatpak 1.2 is now out so we need to support that
 562         version now.
 563
 564         Reviewed by Michael Catanzaro.
 565
 566         * flatpak/flatpakutils.py:
 567         (check_flatpak):
 568         (FlatpakPackages.__init__):
 569         (FlatpakPackages.__detect_packages):
 570         (FlatpakPackages.__detect_packages.in):
 571         (FlatpakRepos.update):
 572
 573 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
 574
 575         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
 576         https://bugs.webkit.org/show_bug.cgi?id=194998
 577
 578         Reviewed by Carlos Garcia Campos.
 579
 580         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
 581         to a Git checkout and using the latest commit containing various fixes
 582         and improvements.
 583
 584 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
 585
 586         [WPE][GTK] Remove user agent quirk for washingtonpost.com
 587         https://bugs.webkit.org/show_bug.cgi?id=194981
 588
 589         Reviewed by Žan Doberšek.
 590
 591         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
 592         (TestWebKitAPI::TEST):
 593
 594 2019-02-23  Keith Miller  <keith_miller@apple.com>
 595
 596         Add new mac target numbers
 597         https://bugs.webkit.org/show_bug.cgi?id=194955
 598
 599         Reviewed by Tim Horton.
 600
 601         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 602         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 603         * MiniBrowser/Configurations/Base.xcconfig:
 604         * TestWebKitAPI/Configurations/Base.xcconfig:
 605         * WebKitTestRunner/Configurations/Base.xcconfig:
 606
 607 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
 608
 609         [WinCairo] Enable wk1/wk2 suffix for platform search path.
 610         https://bugs.webkit.org/show_bug.cgi?id=194846
 611
 612         Reviewed by Don Olmstead.
 613
 614         Added _search_paths() and _port_specific_expectations_files() for
 615         WinCairoPort.
 616
 617         * Scripts/webkitpy/port/win.py:
 618         (WinCairoPort.default_baseline_search_path):
 619         (WinCairoPort):
 620         (WinCairoPort._port_specific_expectations_files):
 621         (WinCairoPort._search_paths):
 622
 623 2019-02-22  Tim Horton  <timothy_horton@apple.com>
 624
 625         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
 626         https://bugs.webkit.org/show_bug.cgi?id=194963
 627
 628         Reviewed by Dean Jackson.
 629
 630         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 631         Do a `contains` check instead of `equals`, because in debug builds we
 632         put the GraphicsLayer pointer in a prefix.
 633
 634 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 635
 636         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
 637         https://bugs.webkit.org/show_bug.cgi?id=194873
 638         <rdar://problem/46701974>
 639
 640         Reviewed by Tim Horton.
 641
 642         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
 643
 644         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 645         (WTR::UIScriptController::menuRect const):
 646         (WTR::UIScriptController::isShowingMenu const):
 647         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 648         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
 649         (WTR::UIScriptController::menuRect const):
 650
 651         Add a function to query the bounds of the callout menu in content coordinates.
 652
 653         (WTR::UIScriptController::isShowingMenu const):
 654
 655         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
 656
 657         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 658         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
 659         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 660         (WTR::UIScriptController::rectForMenuAction const):
 661         (WTR::UIScriptController::menuRect const):
 662         (WTR::UIScriptController::isShowingMenu const):
 663         (WTR::findViewInHierarchyOfType): Deleted.
 664
 665 2019-02-22  Chris Dumez  <cdumez@apple.com>
 666
 667         Regression(PSON) Unable to preview password-protected documents on iCloud.com
 668         https://bugs.webkit.org/show_bug.cgi?id=194954
 669         <rdar://problem/48127957>
 670
 671         Reviewed by Alex Christensen.
 672
 673         Add API test coverage.
 674
 675         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 676         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
 677         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
 678         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
 679
 680 2019-02-22  Chris Dumez  <cdumez@apple.com>
 681
 682         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
 683         https://bugs.webkit.org/show_bug.cgi?id=194924
 684         <rdar://problem/48216125>
 685
 686         Reviewed by Geoffrey Garen.
 687
 688         Add API test coverage.
 689
 690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 691
 692 2019-02-22  Chris Dumez  <cdumez@apple.com>
 693
 694         Unreviewed, disable API test added in r241928 on iOS.
 695
 696         The cache is not enabled on devices with less than 3GB of RAM.
 697
 698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 699
 700 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
 701
 702         Hardcode Visual Viewports on everywhere except iOS WK1
 703         https://bugs.webkit.org/show_bug.cgi?id=194928
 704
 705         Reviewed by Zalan Bujtas.
 706
 707         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
 708         change the default value of the Setting to 'true', and hardcode WebView on iOS to
 709         set it to false. The setting has shipped for several years and there's no need to turn
 710         it off now.
 711
 712         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
 713         Visual Viewports are not enabled.
 714
 715         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
 716         that only runs in WK2
 717
 718         * MiniBrowser/mac/SettingsController.h:
 719         * MiniBrowser/mac/SettingsController.m:
 720         (-[SettingsController init]):
 721         (-[SettingsController _populateMenu]):
 722         (-[SettingsController validateMenuItem:]):
 723         (-[SettingsController visualViewportEnabled]): Deleted.
 724         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
 725         * MiniBrowser/mac/WK1BrowserWindowController.m:
 726         (-[WK1BrowserWindowController didChangeSettings]):
 727         * MiniBrowser/mac/WK2BrowserWindowController.m:
 728         (-[WK2BrowserWindowController didChangeSettings]):
 729
 730 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
 731
 732         Discard cached processes when clearing website data store
 733         https://bugs.webkit.org/show_bug.cgi?id=194894
 734
 735         Reviewed by Chris Dumez.
 736
 737         Added a test case.
 738
 739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 740         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
 741
 742 2019-02-21  Alex Christensen  <achristensen@webkit.org>
 743
 744         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
 745         https://bugs.webkit.org/show_bug.cgi?id=194914
 746         <rdar://problem/47586889>
 747
 748         Reviewed by Geoffrey Garen.
 749
 750         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
 751         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
 752         (TEST):
 753         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
 754
 755 2019-02-21  David Kilzer  <ddkilzer@apple.com>
 756
 757         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
 758         <https://webkit.org/b/194761>
 759
 760         Reviewed by Myles Maxfield.
 761
 762         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 763         (WTR::activateSystemCoreWebFonts): Log `error` to console if
 764         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
 765         to use ARC-compliant cast.
 766         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
 767         ARC-compliant cast.
 768         (WTR::installFakeHelvetica): Log `error` to console if
 769         CTFontManagerRegisterFontsForURL() fails, but only on supported
 770         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
 771         Call CFRelease() on `error` to fix the leak.  Update to use
 772         ARC-compliant cast.
 773         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
 774         cast.
 775
 776 2019-02-21  Chris Dumez  <cdumez@apple.com>
 777
 778         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
 779         https://bugs.webkit.org/show_bug.cgi?id=194481
 780
 781         Reviewed by Alex Christensen.
 782
 783         Give the processes a chance to shutdown and wait until we reached the expected number
 784         of processes.
 785
 786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 787
 788 2019-02-21  Tim Horton  <timothy_horton@apple.com>
 789
 790         Fix the macOS build
 791
 792         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 793
 794 2019-02-21  Tim Horton  <timothy_horton@apple.com>
 795
 796         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
 797
 798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 799         I am a backwards.
 800
 801 2019-02-21  Tim Horton  <timothy_horton@apple.com>
 802
 803         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
 804
 805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 806         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
 807         We could force on UI-side compositing, but I feel like the test might be more
 808         valuable exercising the normal path on each platform (though the original
 809         bug was also UI-side specific). Though we can't validate that the overlay
 810         layer was installed successfully, there are layout tests that do that.
 811
 812 2019-02-21  Tim Horton  <timothy_horton@apple.com>
 813
 814         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
 815         https://bugs.webkit.org/show_bug.cgi?id=194845
 816         <rdar://problem/47944579>
 817
 818         Reviewed by Antti Koivisto.
 819
 820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 822
 823 2019-02-21  Zalan Bujtas  <zalan@apple.com>
 824
 825         [LFC][Floats] Add support for placing formatting roots in-between floats.
 826         https://bugs.webkit.org/show_bug.cgi?id=194902
 827
 828         Reviewed by Antti Koivisto.
 829
 830         * LayoutReloaded/misc/LFC-passing-tests.txt:
 831
 832 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
 833
 834         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
 835         https://bugs.webkit.org/show_bug.cgi?id=194901
 836
 837         Unreviewed build fix.
 838
 839         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
 840         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
 841         WPEBackend-fdo-0.1 as library name.
 842
 843 2019-02-21  Rob Buis  <rbuis@igalia.com>
 844
 845         Update MIME type parser
 846         https://bugs.webkit.org/show_bug.cgi?id=180526
 847
 848         Reviewed by Darin Adler.
 849
 850         Add tests involving leading and trailing whitespace, non-token
 851         characters and quoted strings.
 852
 853         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
 854         (TestWebKitAPI::TEST):
 855
 856 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
 857
 858         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
 859         https://bugs.webkit.org/show_bug.cgi?id=194884
 860
 861         Reviewed by Michael Catanzaro.
 862
 863         * PlatformWin.cmake:
 864
 865 2019-02-20  Chris Dumez  <cdumez@apple.com>
 866
 867         Add API test for <rdar://problem/47471222>
 868         https://bugs.webkit.org/show_bug.cgi?id=194847
 869
 870         Reviewed by Alex Christensen.
 871
 872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 873
 874 2019-02-20  Chris Dumez  <cdumez@apple.com>
 875
 876         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
 877         https://bugs.webkit.org/show_bug.cgi?id=194872
 878         <rdar://problem/47924500>
 879
 880         Reviewed by Alex Christensen.
 881
 882         Add API test coverage.
 883
 884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 885
 886 2019-02-20  Jer Noble  <jer.noble@apple.com>
 887
 888         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
 889         https://bugs.webkit.org/show_bug.cgi?id=191332
 890
 891         Reviewed by Dean Jackson.
 892
 893         * Scripts/git-is-in-range: Added.
 894
 895 2019-02-20  Andy Estes  <aestes@apple.com>
 896
 897         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
 898         https://bugs.webkit.org/show_bug.cgi?id=194869
 899
 900         Rubber-stamped by Jer Noble.
 901
 902         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 903         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
 904         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 905         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
 906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 907         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 908
 909 2019-02-20  Chris Dumez  <cdumez@apple.com>
 910
 911         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
 912         https://bugs.webkit.org/show_bug.cgi?id=194857
 913         <rdar://problem/47759323>
 914
 915         Reviewed by Alex Christensen.
 916
 917         Add API test coverage.
 918
 919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
 920
 921 2019-02-20  Chris Dumez  <cdumez@apple.com>
 922
 923         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
 924         https://bugs.webkit.org/show_bug.cgi?id=194829
 925         <rdar://problem/47889906>
 926
 927         Reviewed by Alexey Proskuryakov.
 928
 929         Every time the TestOptions were changing we were creating both a new Web view and
 930         a new WKContext, which would start a new Network process. In most cases, we only
 931         need to contruct a new Web view and we do can keep reusing the same WKContext.
 932         This patch implements this optimization and thus avoids spinning a lot of new
 933         Network processes while running the layout tests.
 934
 935         * WebKitTestRunner/TestController.cpp:
 936         (WTR::TestController::generateContextConfiguration const):
 937         (WTR::TestController::generatePageConfiguration):
 938         (WTR::TestController::createWebViewWithOptions):
 939         (WTR::TestController::resetPreferencesToConsistentValues):
 940         (WTR::updateTestOptionsFromTestHeader):
 941         * WebKitTestRunner/TestController.h:
 942         * WebKitTestRunner/TestOptions.h:
 943         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
 944         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
 945         (WTR::TestOptions::hasSameInitializationOptions const):
 946         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
 947         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 948         (WTR::TestController::platformAddTestOptions const):
 949
 950 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
 951
 952         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
 953         https://bugs.webkit.org/show_bug.cgi?id=167941
 954
 955         Reviewed by Carlos Garcia Campos.
 956
 957         * MiniBrowser/gtk/main.c:
 958         (filterSavedCallback): Added.
 959         (main): Support loading a JSON rule set file for content filtering.
 960         * MiniBrowser/wpe/main.cpp:
 961         (filterSavedCallback): Added.
 962         (main): Support loading a JSON rule set file for content filtering.
 963         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
 964         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
 965         (WTF::derefGPtr): Ditto.
 966         (testEmptyStore):
 967         (testSaveInvalidFilter):
 968         (testSaveLoadFilter):
 969         (testSavedFilterIdentifierMatch):
 970         (testRemoveFilter):
 971         (testSaveMultipleFilters):
 972         (testSaveFilterFromFile):
 973         (testFilterPersistence):
 974         (beforeAll):
 975         (afterAll):
 976         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
 977         (removeOldInjectedContentAndResetLists): Also reset content filters.
 978         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
 979         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
 980         the element affected by the style sheet.
 981         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
 982         and returns it to be used by tests.
 983         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
 984         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
 985         (serverCallback): Add support for serving a CSS style sheet for testing.
 986         (beforeAll): Add call to testUserContentManagerContentFilter().
 987         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
 988
 989 2019-02-19  Keith Rollin  <krollin@apple.com>
 990
 991         Add timing information to build output
 992         https://bugs.webkit.org/show_bug.cgi?id=194839
 993         <rdar://problem/48219609>
 994
 995         Reviewed by Alexey Proskuryakov.
 996
 997         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
 998         emit each project's build time to its output. E.g.,
 999
1000             ** BUILD SUCCEEDED ** [0.132 sec]
1001
1002         * Scripts/webkitdirs.pm:
1003         (XcodeOptions):
1004
1005 2019-02-19  Truitt Savell  <tsavell@apple.com>
1006
1007         Unreviewed, rolling out r241784.
1008
1009         Broke all OpenSource builds.
1010
1011         Reverted changeset:
1012
1013         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1014         instances view"
1015         https://bugs.webkit.org/show_bug.cgi?id=172848
1016         https://trac.webkit.org/changeset/241784
1017
1018 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1019
1020         [LFC][Floats] Remove redundant intersecting logic
1021         https://bugs.webkit.org/show_bug.cgi?id=194804
1022
1023         Reviewed by Antti Koivisto.
1024
1025         * LayoutReloaded/misc/LFC-passing-tests.txt:
1026
1027 2019-02-19  Dean Jackson  <dino@apple.com>
1028
1029         Clean-up output from generate-xcfilelists so it can be filtered
1030         https://bugs.webkit.org/show_bug.cgi?id=194795
1031
1032         Reviewed by Joseph Pecoraro (and Keith Rollin).
1033
1034         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1035         make a slight tweak to filter-build-webkit so such lines are marked
1036         as plain.
1037
1038         * Scripts/filter-build-webkit:
1039         * Scripts/generate-xcfilelists:
1040
1041 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1042
1043         pytest is not correctly auto-installed
1044         https://bugs.webkit.org/show_bug.cgi?id=194707
1045
1046         Reviewed by Carlos Garcia Campos.
1047
1048         * Scripts/webkitpy/thirdparty/__init__.py:
1049         (AutoinstallImportHook._install_pytest):
1050
1051 2019-02-18  Chris Dumez  <cdumez@apple.com>
1052
1053         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1054         https://bugs.webkit.org/show_bug.cgi?id=194797
1055         <rdar://problem/48055151>
1056
1057         Reviewed by Geoffrey Garen.
1058
1059         Add API test coverage.
1060
1061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1062
1063 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1064
1065         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1066         https://bugs.webkit.org/show_bug.cgi?id=194670
1067         <rdar://problem/39066529>
1068
1069         Reviewed by Tim Horton.
1070
1071         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1072         pasted in an editable area as attachment elements.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1075         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1076         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1077         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1078         (TestWebKitAPI::TEST):
1079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1080         (WTR::InjectedBundlePage::InjectedBundlePage):
1081
1082 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1083
1084         Fix API test after r241728
1085        https://bugs.webkit.org/show_bug.cgi?id=194723
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1088         (TEST):
1089         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1090
1091 2019-02-18  Daniel Bates  <dabates@apple.com>
1092
1093         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1094         https://bugs.webkit.org/show_bug.cgi?id=192824
1095         <rdar://problem/47100332>
1096
1097         Reviewed by Wenson Hsieh.
1098
1099         Fix a bug where the wrong usage code was used for F13 thru F24.
1100
1101         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1102         (keyCodeForDOMFunctionKey):
1103
1104 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1105
1106         Bytecode cache should a have a boot-specific validation
1107         https://bugs.webkit.org/show_bug.cgi?id=194769
1108         <rdar://problem/48149509>
1109
1110         Reviewed by Keith Miller.
1111
1112         Add test for WTF::bootSessionUUIDString()
1113
1114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1115         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1116         (TEST):
1117
1118 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1119
1120         Disable safe browsing in WKWebView and remove its WKPreferences API
1121         https://bugs.webkit.org/show_bug.cgi?id=194723
1122         <rdar://problem/48122993>
1123
1124         Reviewed by Geoffrey Garen.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1127         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1128         (TEST):
1129         (safeBrowsingView):
1130         Make tests use SPI instead of API.
1131
1132 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1133
1134         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1135         https://bugs.webkit.org/show_bug.cgi?id=194586
1136
1137         Reviewed by Ross Kirsling.
1138
1139         * DumpRenderTree/win/DumpRenderTree.cpp:
1140         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1141         * Scripts/webkitpy/port/driver.py:
1142         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1143
1144 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1145
1146         Unreviewed, rolling out r241620.
1147
1148         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1149         (Requested by ddkilzer on #webkit.)
1150
1151         Reverted changeset:
1152
1153         "[WTF] Add environment variable helpers"
1154         https://bugs.webkit.org/show_bug.cgi?id=192405
1155         https://trac.webkit.org/changeset/241620
1156
1157 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1158
1159         [LFC] RenderImage's default intrinsic size is 0.
1160         https://bugs.webkit.org/show_bug.cgi?id=194745
1161
1162         Reviewed by Antti Koivisto.
1163
1164         * LayoutReloaded/misc/LFC-passing-tests.txt:
1165
1166 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1167
1168         [LFC][BFC] Add support for block replaced intrinsic width.
1169         https://bugs.webkit.org/show_bug.cgi?id=194705
1170
1171         Reviewed by Simon Fraser.
1172
1173         * LayoutReloaded/misc/LFC-passing-tests.txt:
1174
1175 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1176
1177         [LFC] Apply min/max width constraints to preferred width computation
1178         https://bugs.webkit.org/show_bug.cgi?id=194739
1179
1180         Reviewed by Simon Fraser.
1181
1182         * LayoutReloaded/misc/LFC-passing-tests.txt:
1183
1184 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1185
1186         [WTF] Add environment variable helpers
1187         https://bugs.webkit.org/show_bug.cgi?id=192405
1188
1189         Reviewed by Michael Catanzaro.
1190
1191         * DumpRenderTree/mac/DumpRenderTree.mm:
1192         (libraryPathForDumpRenderTree):
1193         * DumpRenderTree/win/DumpRenderTree.cpp:
1194         (libraryPathForDumpRenderTree):
1195         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1196         (setUpIOSLayoutTestCommunication):
1197         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1198         (beforeAll):
1199         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1200         (main):
1201         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1202         (WebKitTestBus::run):
1203         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1204         (WTR::getOutputDir):
1205         (WTR::initializeFontConfigSetting):
1206         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1207         (WTR::InjectedBundle::platformInitialize):
1208         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1209         (WTR::topLevelPath):
1210         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1211         (WTR::topLevelPath):
1212         (WTR::getOutputDir):
1213         (WTR::activateFonts):
1214         * WebKitTestRunner/TestController.cpp:
1215         (WTR::TestController::libraryPathForTesting):
1216         (WTR::TestController::generateContextConfiguration const):
1217         (WTR::TestController::generatePageConfiguration):
1218         (WTR::TestController::decideDestinationWithSuggestedFilename):
1219         (WTR::TestController::platformAdjustContext):
1220         * WebKitTestRunner/TestController.h:
1221         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1222         (WTR::TestController::cocoaPlatformInitialize):
1223         (WTR::TestController::platformAdjustContext):
1224         * WebKitTestRunner/gtk/main.cpp:
1225         (main):
1226         * WebKitTestRunner/mac/TestControllerMac.mm:
1227         (WTR::TestController::configureContentExtensionForTest):
1228         * WebKitTestRunner/wpe/main.cpp:
1229         (main):
1230         Utilize WTF::Environment where possible.
1231
1232 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1233
1234         [iOS] WKWebView callout bar is missing Change Writing Direction item
1235         https://bugs.webkit.org/show_bug.cgi?id=190015
1236         <rdar://problem/44810366>
1237
1238         Reviewed by Tim Horton.
1239
1240         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1241         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1242
1243         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1244         (TestWebKitAPI::TEST):
1245
1246 2019-02-15  Chris Dumez  <cdumez@apple.com>
1247
1248         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1249         https://bugs.webkit.org/show_bug.cgi?id=194717
1250         <rdar://problem/47884404>
1251
1252         Reviewed by Brady Eidson.
1253
1254         Add API test coverage.
1255
1256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1257
1258 2019-02-15  Youenn Fablet  <youenn@apple.com>
1259
1260         Make navigator.mediaDevices SecureContext
1261         https://bugs.webkit.org/show_bug.cgi?id=194666
1262
1263         Reviewed by Eric Carlson.
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1266         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1267         (TEST_F):
1268
1269 2019-02-15  Brian Burg  <bburg@apple.com>
1270
1271         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1272         https://bugs.webkit.org/show_bug.cgi?id=194411
1273         <rdar://problem/47787614>
1274
1275         Reviewed by Joseph Pecoraro.
1276
1277         Remove unnecessary soft linking macro usage.
1278
1279         * DumpRenderTree/mac/TestRunnerMac.mm:
1280         (TestRunner::inspectorTestStubURL):
1281         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1282         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1283         (WTR::TestRunner::inspectorTestStubURL):
1284
1285 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1286
1287         Unreviewed, rolling out r241559 and r241566.
1288         https://bugs.webkit.org/show_bug.cgi?id=194710
1289
1290         Causes layout test crashes under GuardMalloc (Requested by
1291         ryanhaddad on #webkit).
1292
1293         Reverted changesets:
1294
1295         "[WTF] Add environment variable helpers"
1296         https://bugs.webkit.org/show_bug.cgi?id=192405
1297         https://trac.webkit.org/changeset/241559
1298
1299         "Unreviewed build fix for WinCairo Debug after r241559."
1300         https://trac.webkit.org/changeset/241566
1301
1302 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1303
1304         [LFC] Out-of-flow box is never a float box
1305         https://bugs.webkit.org/show_bug.cgi?id=194704
1306
1307         Reviewed by Antti Koivisto.
1308
1309         * LayoutReloaded/misc/LFC-passing-tests.txt:
1310
1311 2019-02-10  Darin Adler  <darin@apple.com>
1312
1313         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1314         https://bugs.webkit.org/show_bug.cgi?id=194487
1315
1316         Reviewed by Daniel Bates.
1317
1318         * DumpRenderTree/win/DumpRenderTree.cpp:
1319         (applicationId): Use makeString instead of String::format.
1320         (main): Ditto.
1321         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1322         (TestWebKitAPI::Util::createURLForResource): Ditto.
1323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1324         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1325
1326         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1327         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1328         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1329         (WTR::createStringWithAttributes): Use appendLiteral.
1330         (WTR::AccessibilityUIElement::helpText const): Ditto.
1331         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1332         directly instead of using String::format.
1333         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1334         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1335
1336 2019-02-15  Truitt Savell  <tsavell@apple.com>
1337
1338         Unreviewed, rolling out r241564.
1339
1340         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1341
1342         Reverted changeset:
1343
1344         "[Mac] WebInspectorUI.framework does not need to be soft-
1345         linked anymore"
1346         https://bugs.webkit.org/show_bug.cgi?id=194411
1347         https://trac.webkit.org/changeset/241564
1348
1349 2019-02-15  Saam barati  <sbarati@apple.com>
1350
1351         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1352         https://bugs.webkit.org/show_bug.cgi?id=194036
1353
1354         Reviewed by Yusuke Suzuki.
1355
1356         * Scripts/run-jsc-stress-tests:
1357
1358 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1359
1360         Fix the build.
1361
1362         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1363         (WTR::UIScriptController::drawSquareInEditableImage):
1364         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1365         (TestWebKitAPI::drawSquareInEditableImage):
1366
1367 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1368
1369         Fix the build.
1370
1371         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1372         (WTR::UIScriptController::drawSquareInEditableImage):
1373         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1374         (TestWebKitAPI::drawSquareInEditableImage):
1375
1376 2019-02-14  Brian Burg  <bburg@apple.com>
1377
1378         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1379         https://bugs.webkit.org/show_bug.cgi?id=194411
1380         <rdar://problem/47787614>
1381
1382         Reviewed by Joseph Pecoraro.
1383
1384         Remove unnecessary soft linking macro usage.
1385
1386         * DumpRenderTree/mac/TestRunnerMac.mm:
1387         (TestRunner::inspectorTestStubURL):
1388         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1389         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1390         (WTR::TestRunner::inspectorTestStubURL):
1391
1392 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1393
1394         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1395         https://bugs.webkit.org/show_bug.cgi?id=194599
1396
1397         Reviewed by Lucas Forschler.
1398
1399         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1400         (StatusBubble._build_bubble):
1401
1402 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1403
1404         [ews-app] Set Foreign Key in Django build model
1405         https://bugs.webkit.org/show_bug.cgi?id=194667
1406
1407         Reviewed by Lucas Forschler.
1408
1409         * BuildSlaveSupport/ews-app/ews/models/build.py:
1410         (Build):
1411
1412 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1413
1414         [WTF] Add environment variable helpers
1415         https://bugs.webkit.org/show_bug.cgi?id=192405
1416
1417         Reviewed by Michael Catanzaro.
1418
1419         * DumpRenderTree/mac/DumpRenderTree.mm:
1420         (libraryPathForDumpRenderTree):
1421         * DumpRenderTree/win/DumpRenderTree.cpp:
1422         (libraryPathForDumpRenderTree):
1423         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1424         (setUpIOSLayoutTestCommunication):
1425         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1426         (TestWebKitAPI::strip):
1427         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1428         (beforeAll):
1429         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1430         (main):
1431         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1432         (WebKitTestBus::run):
1433         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1434         (WTR::getOutputDir):
1435         (WTR::initializeFontConfigSetting):
1436         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1437         (WTR::InjectedBundle::platformInitialize):
1438         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1439         (WTR::topLevelPath):
1440         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1441         (WTR::topLevelPath):
1442         (WTR::getOutputDir):
1443         (WTR::activateFonts):
1444         * WebKitTestRunner/TestController.cpp:
1445         (WTR::TestController::libraryPathForTesting):
1446         (WTR::TestController::generateContextConfiguration const):
1447         (WTR::TestController::generatePageConfiguration):
1448         (WTR::TestController::decideDestinationWithSuggestedFilename):
1449         (WTR::TestController::platformAdjustContext):
1450         * WebKitTestRunner/TestController.h:
1451         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1452         (WTR::TestController::cocoaPlatformInitialize):
1453         (WTR::TestController::platformAdjustContext):
1454         * WebKitTestRunner/gtk/main.cpp:
1455         (main):
1456         * WebKitTestRunner/mac/TestControllerMac.mm:
1457         (WTR::TestController::configureContentExtensionForTest):
1458         * WebKitTestRunner/wpe/main.cpp:
1459         (main):
1460         Utilize WTF::Environment where possible.
1461
1462 2019-02-14  Chris Dumez  <cdumez@apple.com>
1463
1464         [PSON] Introduce a WebContent Process cache
1465         https://bugs.webkit.org/show_bug.cgi?id=194594
1466         <rdar://problem/46793397>
1467
1468         Reviewed by Geoff Garen.
1469
1470         Update API tests to turn on the WebContent Process cache.
1471
1472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1473
1474 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1475
1476         Unreviewed, build fix after r241480
1477
1478         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1479         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1480         (-[DragAndDropSimulator initWithWebView:]):
1481
1482 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1483
1484         AX: ARIA Reflection was disabled in error
1485         https://bugs.webkit.org/show_bug.cgi?id=194647
1486         <rdar://problem/48068336>
1487
1488         Reviewed by Ryosuke Niwa.
1489
1490         Remove test override now that this feature should be enabled by default.
1491
1492         * WebKitTestRunner/TestController.cpp:
1493         (WTR::TestController::resetPreferencesToConsistentValues):
1494
1495 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1496
1497         Unreviewed, rolling out r241486.
1498         https://bugs.webkit.org/show_bug.cgi?id=194655
1499
1500         causing API failures in builds (Requested by ShawnRoberts on
1501         #webkit).
1502
1503         Reverted changeset:
1504
1505         "[Cocoa] Media elements will restart network buffering just
1506         before suspending"
1507         https://bugs.webkit.org/show_bug.cgi?id=193691
1508         https://trac.webkit.org/changeset/241486
1509
1510 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1511
1512         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1513         https://bugs.webkit.org/show_bug.cgi?id=194622
1514
1515         Reviewed by Antti Koivisto.
1516
1517         * LayoutReloaded/misc/LFC-passing-tests.txt:
1518
1519 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1520
1521         [LFC] Shrink-to-fit-width should be constrained by min/max width
1522         https://bugs.webkit.org/show_bug.cgi?id=194653
1523
1524         Reviewed by Antti Koivisto.
1525
1526         * LayoutReloaded/misc/LFC-passing-tests.txt:
1527
1528 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1529
1530         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1531         https://bugs.webkit.org/show_bug.cgi?id=194641
1532
1533         Reviewed by Geoffrey Garen.
1534
1535         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1536         so that the test would fail without this fix.
1537
1538         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1539         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1540
1541 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1542
1543         [ews-app] Change log level for a log statement
1544
1545         Unreviewed minor fix.
1546
1547         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1548         (Patch.save_patch):
1549
1550 2019-02-13  Jer Noble  <jer.noble@apple.com>
1551
1552         [Cocoa] Media elements will restart network buffering just before suspending
1553         https://bugs.webkit.org/show_bug.cgi?id=193691
1554
1555         Reviewed by Eric Carlson.
1556
1557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1558         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1559         (TEST):
1560
1561 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1562
1563         [ews-app] Fetch builder id to name mapping
1564         https://bugs.webkit.org/show_bug.cgi?id=194355
1565
1566         Reviewed by Lucas Forschler.
1567
1568         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1569         (Buildbot.get_builder_id_to_name_mapping):
1570         (Buildbot._get_display_name_from_builder_name):
1571
1572 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1573
1574         Further restricting webarchive loads
1575         https://bugs.webkit.org/show_bug.cgi?id=194567
1576         <rdar://problem/47610130>
1577
1578         Reviewed by Youenn Fablet.
1579
1580         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1581         navigations on drop.
1582
1583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1584         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1585         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1586         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1587         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1590         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1591         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1592         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1593         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1594         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1595         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1596
1597 2019-02-13  John Wilander  <wilander@apple.com>
1598
1599         Store Ad Click Attribution requests in the network process
1600         https://bugs.webkit.org/show_bug.cgi?id=194510
1601         <rdar://problem/47650118>
1602
1603         Reviewed by Alex Christensen and Daniel Bates.
1604
1605         This patch adds two TestRunner functions:
1606         - dumpAdClickAttribution()
1607         - clearAdClickAttribution()
1608
1609         They call into the network process to dump and clear Ad Click
1610         Attribution state, respectively.
1611
1612         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1614         (WTR::TestRunner::dumpAdClickAttribution):
1615         (WTR::TestRunner::clearAdClickAttribution):
1616         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1617         * WebKitTestRunner/TestController.cpp:
1618         (WTR::TestController::resetStateToConsistentValues):
1619         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1620         (WTR::adClickAttributionStringResultCallback):
1621         (WTR::TestController::dumpAdClickAttribution):
1622         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1623         (WTR::adClickAttributionVoidCallback):
1624         (WTR::TestController::clearAdClickAttribution):
1625         * WebKitTestRunner/TestController.h:
1626         * WebKitTestRunner/TestInvocation.cpp:
1627         (WTR::TestInvocation::dumpResults):
1628         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1629         (WTR::TestInvocation::dumpAdClickAttribution):
1630         * WebKitTestRunner/TestInvocation.h:
1631
1632 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-app] Generate status-bubble
1635         https://bugs.webkit.org/show_bug.cgi?id=194572
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1640         (StatusBubble._build_bubble):
1641         (StatusBubble._should_show_bubble_for):
1642         (StatusBubble._build_bubbles_for_patch):
1643
1644 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-app] Add status bubble html template
1647         https://bugs.webkit.org/show_bug.cgi?id=194571
1648
1649         Reviewed by Lucas Forschler.
1650
1651         * BuildSlaveSupport/ews-app/ews/templates: Added.
1652         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1653
1654 2019-02-12  Chris Dumez  <cdumez@apple.com>
1655
1656         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1657         https://bugs.webkit.org/show_bug.cgi?id=194568
1658         <rdar://problem/47944490>
1659
1660         Reviewed by Ryosuke Niwa.
1661
1662         Add API test coverage.
1663
1664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1665         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1666
1667 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1668
1669         webkitpy: Remove bug_dummy from parsed test expectations
1670         https://bugs.webkit.org/show_bug.cgi?id=194562
1671         <rdar://problem/47853999>
1672
1673         Reviewed by Lucas Forschler.
1674
1675         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1676         (TestExpectationParser):
1677         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1678         skipped tests.
1679         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1680
1681 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1682
1683         [ews-app] Add method to fetch patch
1684         https://bugs.webkit.org/show_bug.cgi?id=194518
1685
1686         Reviewed by Lucas Forschler.
1687
1688         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1689         (Patch.get_patch):
1690
1691 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1692
1693         [LFC] Expand tests coverage (60 new tests -> 860)
1694
1695         Unreviewed test gardening (run-singly, --child-processes=1).
1696
1697         * LayoutReloaded/misc/LFC-passing-tests.txt:
1698
1699 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         Allow pages to trigger programmatic paste from script on iOS
1702         https://bugs.webkit.org/show_bug.cgi?id=194271
1703         <rdar://problem/47808810>
1704
1705         Reviewed by Tim Horton.
1706
1707         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1708
1709         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1710         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1711         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1712         (WTR::UIScriptController::rectForMenuAction const):
1713
1714         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1715         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1716         for when the menu is shown or hidden.
1717
1718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1719         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1720         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1721         (WTR::UIScriptController::setDidShowMenuCallback):
1722         (WTR::UIScriptController::didShowMenuCallback const):
1723         (WTR::UIScriptController::setDidHideMenuCallback):
1724         (WTR::UIScriptController::didHideMenuCallback const):
1725         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1726         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1727         (WTR::UIScriptController::rectForMenuAction const):
1728         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::resetPreferencesToConsistentValues):
1731         (WTR::updateTestOptionsFromTestHeader):
1732         * WebKitTestRunner/TestOptions.h:
1733
1734         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1735         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1736
1737         (WTR::TestOptions::hasSameInitializationOptions const):
1738         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1739         (WTR::UIScriptController::calendarType const):
1740         (WTR::UIScriptController::platformUndoManager const):
1741         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1742         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1743         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1744         (-[TestRunnerWKWebView dealloc]):
1745         (-[TestRunnerWKWebView _didShowMenu]):
1746         (-[TestRunnerWKWebView _didHideMenu]):
1747
1748         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1749
1750         * WebKitTestRunner/ios/TestControllerIOS.mm:
1751         (WTR::handleMenuWillHideNotification):
1752         (WTR::handleMenuDidHideNotification):
1753         (WTR::TestController::platformInitialize):
1754         (WTR::TestController::platformDestroy):
1755         (WTR::TestController::platformResetStateToConsistentValues):
1756
1757         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1758         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1759
1760         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1761         (WTR::forEachViewInHierarchy):
1762         (WTR::findViewInHierarchyOfType):
1763
1764         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1765         functions that dig through a given view's hierarchy in search of a view of a given class.
1766
1767         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1768         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1769         (WTR::UIScriptController::selectionCaretViewRect const):
1770         (WTR::UIScriptController::selectionRangeViewRects const):
1771         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1772         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1773
1774         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1775
1776         (WTR::UIScriptController::rectForMenuAction const):
1777
1778         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1779         callout bar) whose label matches the given string.
1780
1781         (WTR::UIScriptController::platformContentView const):
1782
1783         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1784         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1785         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1786
1787         (WTR::UIScriptController::platformUndoManager const): Deleted.
1788         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1789         (WTR::UIScriptController::platformContentView const):
1790         (WTR::UIScriptController::platformUndoManager const): Deleted.
1791
1792 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1793
1794         webkitpy: No option to only show unexpected failures in results.html for iPad
1795         https://bugs.webkit.org/show_bug.cgi?id=194554
1796         <rdar://problem/47922442>
1797
1798         Rubber-stamped by Aakash Jain.
1799
1800         Just because a TestExpecations file does not exist for a specific platform does not mean that
1801         TestExpecations are not being used, given that platforms inherit test expectations.
1802
1803         * Scripts/webkitpy/port/base.py:
1804         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1805         * Scripts/webkitpy/port/base_unittest.py:
1806         (PortTest.test_uses_test_expectations_file):
1807
1808 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1809
1810         Remove setDefersLoading infrastructure from WebKit2
1811         https://bugs.webkit.org/show_bug.cgi?id=194506
1812
1813         Reviewed by Brady Eidson.
1814
1815         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1816         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1817         (WTR::TestRunner::setDefersLoading): Deleted.
1818         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1819
1820 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1821
1822         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1823         https://bugs.webkit.org/show_bug.cgi?id=194522
1824         <rdar://problem/47789393>
1825
1826         Reviewed by Chris Dumez.
1827
1828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1829         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1830         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1832
1833 2019-02-12  Andy Estes  <aestes@apple.com>
1834
1835         [iOSMac] Enable Parental Controls Content Filtering
1836         https://bugs.webkit.org/show_bug.cgi?id=194521
1837         <rdar://39732376>
1838
1839         Reviewed by Tim Horton.
1840
1841         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1842
1843 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1844
1845         [LFC][IFC] Add intrinsic width support for float boxes.
1846         https://bugs.webkit.org/show_bug.cgi?id=194528
1847
1848         Reviewed by Antti Koivisto.
1849
1850         Expand tests coverage (2 new tests -> 800).
1851         (This is the correct test ordering --runs-singly --child-processes=1)
1852
1853         * LayoutReloaded/misc/LFC-passing-tests.txt:
1854
1855 2019-02-12  Rob Buis  <rbuis@igalia.com>
1856
1857         Implement serializing in MIME type parser
1858         https://bugs.webkit.org/show_bug.cgi?id=193909
1859
1860         Reviewed by Darin Adler.
1861
1862         Add various tests involving upper case, non-ASCII, control/null characters,
1863         various HTTP whitespace, single quotes and an unpaired surrogate.
1864
1865         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1866         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1867         (TestWebKitAPI::serializeIfValid):
1868         (TestWebKitAPI::TEST):
1869
1870 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1871
1872         [Cocoa] Ask platform for generic font family mappings
1873         https://bugs.webkit.org/show_bug.cgi?id=187723
1874         <rdar://problem/41892438>
1875
1876         Reviewed by Brent Fulgham.
1877
1878         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1879
1880         * DumpRenderTree/mac/DumpRenderTree.mm:
1881         (allowedFontFamilySet):
1882         * WebKitTestRunner/mac/TestControllerMac.mm:
1883         (WTR::allowedFontFamilySet):
1884
1885 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1886
1887         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1888         https://bugs.webkit.org/show_bug.cgi?id=193622
1889
1890         Reviewed by Michael Catanzaro.
1891
1892         This adds support for loading content extension rule sets from the JSON files which
1893         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1894         of WKTR for this could be removed, but that is left for a follow-up patch with
1895         cleanups.
1896
1897         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1898         * WebKitTestRunner/TestController.cpp:
1899         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1900         avoid having the null-terminator copied into the result.
1901         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1902         part of the preparations to run a test.
1903         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1904         (WTR::contentExtensionStoreCallback): Added.
1905         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1906         used for content extensions test.
1907         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1908         extensions and compiling the JSON rule set for tests involving content extensions.
1909         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1910         testing and disables content extensions.
1911         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1912         resetContentExtensions().
1913         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1914         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1915         configureContentExtensionForTest(), and userContentController().
1916
1917 2019-02-11  Daniel Bates  <dabates@apple.com>
1918
1919         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1920         https://bugs.webkit.org/show_bug.cgi?id=191446
1921         <rdar://problem/45929460>
1922
1923         Reviewed by Tim Horton.
1924
1925         Add support infrastructure for testing touch and stylus taps when holding modifier keys.
1926
1927         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1928         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1929         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1930         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1931         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1932         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1933         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1934         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1935         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1936         (WTR::arrayLength):
1937         (WTR::parseModifierArray):
1938         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1939         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1940         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1941         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1942
1943 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1944
1945         Unreviewed, rolling out r241272 and r241276.
1946         https://bugs.webkit.org/show_bug.cgi?id=194514
1947
1948         Broke the Apple Internal build and the fix requires human
1949         intervention :( (Requested by dydz on #webkit).
1950
1951         Reverted changesets:
1952
1953         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1954         https://bugs.webkit.org/show_bug.cgi?id=191446
1955         https://trac.webkit.org/changeset/241272
1956
1957         "Fix internal iOS build after r241272"
1958         https://bugs.webkit.org/show_bug.cgi?id=191446
1959         https://trac.webkit.org/changeset/241276
1960
1961 2019-02-11  Truitt Savell  <tsavell@apple.com>
1962
1963         Unreviewed, rolling out r241269.
1964
1965         Caused 5 layout tests crashes on Mac WK1
1966
1967         Reverted changeset:
1968
1969         "DumpRenderTree should report unknown options"
1970         https://bugs.webkit.org/show_bug.cgi?id=191303
1971         https://trac.webkit.org/changeset/241269
1972
1973 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1974
1975         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1976         https://bugs.webkit.org/show_bug.cgi?id=194313
1977
1978         Reviewed by Tim Horton.
1979
1980         Add a helper to determine whether the web view is presenting modal UI.
1981
1982         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1983         (WTR::UIScriptController::isPresentingModally const):
1984         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1985         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1986         (WTR::UIScriptController::isPresentingModally const):
1987         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1988         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1989         (WTR::UIScriptController::calendarType const): Deleted.
1990         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1991         (WTR::UIScriptController::isPresentingModally const):
1992         (WTR::UIScriptController::calendarType const):
1993         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1994         (WTR::UIScriptController::calendarType const):
1995
1996 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1997
1998         GCHeapInspector: Show the retained sizes in more places
1999         https://bugs.webkit.org/show_bug.cgi?id=194464
2000
2001         Reviewed by Simon Fraser.
2002
2003         * GCHeapInspector/gc-heap-inspector.html:
2004         * GCHeapInspector/script/interface.js:
2005         (HeapInspectorUtils.humanReadableSize):
2006         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2007         (HeapInspectorUtils.spanForNode.span.span):
2008         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2009         (HeapSnapshotInspector.prototype.buildRoots):
2010
2011 2019-02-11  Daniel Bates  <dabates@apple.com>
2012
2013         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2014         https://bugs.webkit.org/show_bug.cgi?id=191446
2015         <rdar://problem/45929460>
2016
2017         Reviewed by Tim Horton.
2018
2019         Add support infrastructure for testing touch and stylus taps when holding modifier keys.
2020
2021         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2022         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2023         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2024         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2025         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2026         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2027         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2028         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2029         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2030         (WTR::arrayLength):
2031         (WTR::parseModifierArray):
2032         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2033         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2034         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2035         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2036
2037 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2038
2039         DumpRenderTree should report unknown options
2040         https://bugs.webkit.org/show_bug.cgi?id=191303
2041
2042         Reviewed by Frédéric Wang.
2043
2044         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2045         to report unknown options.
2046         Added and assigned test options which are currently used in tests.
2047
2048         * DumpRenderTree/TestOptions.cpp:
2049         (TestOptions::TestOptions):
2050
2051 2019-02-11  Truitt Savell  <tsavell@apple.com>
2052
2053         Unreviewed, rolling out r241229.
2054
2055         Revision broke internal builds for watchOS.
2056
2057         Reverted changeset:
2058
2059         "[Cocoa] Ask platform for generic font family mappings"
2060         https://bugs.webkit.org/show_bug.cgi?id=187723
2061         https://trac.webkit.org/changeset/241229
2062
2063 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2064
2065         [WinCairo][MiniBrowser] Basic authentication always fails.
2066         https://bugs.webkit.org/show_bug.cgi?id=194496
2067
2068         Reviewed by Don Olmstead.
2069
2070         * MiniBrowser/win/DialogHelper.h:
2071         (Dialog::getText):
2072
2073 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2074
2075         [GStreamer] GstMappedBuffer testsuite build fails
2076         https://bugs.webkit.org/show_bug.cgi?id=194495
2077
2078         Reviewed by Carlos Garcia Campos.
2079
2080         Fix the build by explicitely adding the gstreamer1.0-audio include
2081         directories to the include path.
2082
2083         * TestWebKitAPI/PlatformGTK.cmake:
2084         * TestWebKitAPI/PlatformWPE.cmake:
2085
2086 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2087
2088         [GTK][WPE] Add enable-javascript-markup setting
2089         https://bugs.webkit.org/show_bug.cgi?id=193439
2090
2091         Reviewed by Michael Catanzaro.
2092
2093         Add test cases to check the new setting.
2094
2095         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2096         (testWebKitSettings):
2097         (testWebKitSettingsJavaScriptMarkup):
2098         (beforeAll):
2099
2100 2019-02-10  Darin Adler  <darin@apple.com>
2101
2102         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2103         https://bugs.webkit.org/show_bug.cgi?id=194485
2104
2105         Reviewed by Daniel Bates.
2106
2107         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2108
2109 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2110
2111         Add more tests for clampTo<>()
2112         https://bugs.webkit.org/show_bug.cgi?id=194462
2113
2114         Reviewed by Geoffrey Garen.
2115
2116         Darin suggested to test the very last floating point number
2117         at the boundaries when truncating to integer.
2118         I added test for max/min and max-1/min-1.
2119
2120         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2121         (TestWebKitAPI::TEST):
2122
2123 2019-02-09  Darin Adler  <darin@apple.com>
2124
2125         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2126         https://bugs.webkit.org/show_bug.cgi?id=194021
2127
2128         Reviewed by Geoffrey Garen.
2129
2130         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2131         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2132         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2133
2134 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2135
2136         [LFC][IFC] Add intrinsic width support for basic inline containers
2137         https://bugs.webkit.org/show_bug.cgi?id=194473
2138
2139         Reviewed by Antti Koivisto.
2140
2141         Expand tests coverage (11 new tests -> 798)
2142
2143         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2144
2145 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2146
2147         Fix MiniBrowser's entitlements
2148         https://bugs.webkit.org/show_bug.cgi?id=192431
2149
2150         Reviewed by Joseph Pecoraro.
2151
2152         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2153         files, making it impossible to load any extension.
2154
2155         * MiniBrowser/MiniBrowser.entitlements:
2156
2157 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2158
2159         [Cocoa] Ask platform for generic font family mappings
2160         https://bugs.webkit.org/show_bug.cgi?id=187723
2161         <rdar://problem/41892438>
2162
2163         Reviewed by Brent Fulgham.
2164
2165         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2166
2167         * DumpRenderTree/mac/DumpRenderTree.mm:
2168         (allowedFontFamilySet):
2169         * WebKitTestRunner/mac/TestControllerMac.mm:
2170         (WTR::allowedFontFamilySet):
2171
2172 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2173
2174         [GTK] Implement back/forward touchpad gesture
2175         https://bugs.webkit.org/show_bug.cgi?id=193919
2176
2177         Reviewed by Michael Catanzaro.
2178
2179         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2180         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2181
2182 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2183
2184         Add SPI to use networking daemon instead of XPC service
2185         https://bugs.webkit.org/show_bug.cgi?id=194427
2186
2187         Reviewed by Geoffrey Garen
2188
2189         * MiniBrowser/MiniBrowser.entitlements:
2190
2191 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2192
2193         [ews-build] Ensure that every builder in config.json has short name
2194         https://bugs.webkit.org/show_bug.cgi?id=194461
2195
2196         Reviewed by Lucas Forschler.
2197
2198         * BuildSlaveSupport/ews-build/loadConfig.py:
2199         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2200
2201 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2202
2203         [ews-build] Add short name to config.json
2204         https://bugs.webkit.org/show_bug.cgi?id=194456
2205
2206         Reviewed by Lucas Forschler.
2207
2208         * BuildSlaveSupport/ews-build/config.json: Added short name.
2209         * BuildSlaveSupport/ews-build/loadConfig.py:
2210         (loadBuilderConfig): Set the short name as the builder description.
2211
2212 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2213
2214         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2215         https://bugs.webkit.org/show_bug.cgi?id=194418
2216
2217         Reviewed by Lucas Forschler.
2218
2219         Do not include errors trying when finding crashlogs at the end of
2220         a run-webkit-tests run since we don't process those errors.
2221
2222         * Scripts/webkitpy/port/darwin.py:
2223         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2224         * Scripts/webkitpy/port/ios_device.py:
2225         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2226         * Scripts/webkitpy/port/watch_device.py:
2227         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2228
2229 2019-02-08  Beth Dakin  <bdakin@apple.com>
2230
2231         Add afterScreenUpdates to WKSnapshotConfiguration
2232         https://bugs.webkit.org/show_bug.cgi?id=194362
2233         -and corresponding-
2234         <rdar://problem/40655528> Please add an "after screen updates" property to
2235         WKSnapshotConfiguration (to solve blank snapshots)
2236
2237         Reviewed by Tim Horton.
2238
2239         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2240         (TEST):
2241
2242 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2243
2244         clampTo(): do not convert the input to double when dealing with integers
2245         https://bugs.webkit.org/show_bug.cgi?id=194263
2246         <rdar://problem/47692312>
2247
2248         Reviewed by Darin Adler.
2249
2250         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2251         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2252         (TestWebKitAPI::testClampFloatingPointToInteger):
2253         (TestWebKitAPI::testClampSameSignIntegers):
2254         (TestWebKitAPI::testClampUnsignedToSigned):
2255         (TestWebKitAPI::testClampSignedToUnsigned):
2256
2257 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2258
2259         webkitpy: Respect --dedicated-simulators flag
2260         https://bugs.webkit.org/show_bug.cgi?id=194416
2261         <rdar://problem/47894722>
2262
2263         Reviewed by Lucas Forschler.
2264
2265         * Scripts/webkitpy/port/device_port.py:
2266         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2267         available devices can be safely ignored.
2268
2269 2019-02-07  Keith Rollin  <krollin@apple.com>
2270
2271         Remove extra copy of 100x100-red.tga
2272         https://bugs.webkit.org/show_bug.cgi?id=194371
2273         <rdar://problem/47873465>
2274
2275         Reviewed by Said Abou-Hallawa.
2276
2277         In order to help it pass its tests, Bug 194190 added a second copy of
2278         the file 100x100-red.tga. However, it turns out that this additional
2279         file wasn't actually needed, and that that sole previous copy was
2280         sufficient. At the same time, this second copy -- which was copied to
2281         the same location in the build output as the first copy -- now caused
2282         XCBuild to complain because there were two production rules for the
2283         same output file. Address this by removing the newly-added extra copy.
2284
2285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2286         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2287
2288 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2289
2290         Deprecate WKBundlePageSetDefersLoading
2291         https://bugs.webkit.org/show_bug.cgi?id=191394
2292
2293         Reviewed by Dean Jackson.
2294
2295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2296         (WTR::TestRunner::setDefersLoading):
2297
2298 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2299
2300         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2301         https://bugs.webkit.org/show_bug.cgi?id=194391
2302
2303         Reviewed by Antti Koivisto.
2304
2305         * LayoutReloaded/misc/LFC-passing-tests.txt:
2306
2307 2019-02-06  Keith Rollin  <krollin@apple.com>
2308
2309         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2310         https://bugs.webkit.org/show_bug.cgi?id=193975
2311         <rdar://problem/47643306>
2312
2313         Reviewed by Tim Horton.
2314
2315         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2316         the Info.plist file into the bundle. This step is not necessary as the
2317         implicit "bundle up all the build products into a framework" build
2318         phase does this already. Having the Copy Bundle Resources phase do
2319         this causes a conflict under XCBuild, which objects to two build
2320         phases producing the same file (Info.plist). Address this by removing
2321         Info.plist from the Copy Bundle Resources phase.
2322
2323         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2324
2325 2019-02-06  Keith Rollin  <krollin@apple.com>
2326
2327         Really enable the automatic checking and regenerations of .xcfilelists during builds
2328         https://bugs.webkit.org/show_bug.cgi?id=194357
2329         <rdar://problem/47861231>
2330
2331         Reviewed by Chris Dumez.
2332
2333         Bug 194124 was supposed to enable the automatic checking and
2334         regenerating of .xcfilelist files during the build. While related
2335         changes were included in that patch, the change to actually enable the
2336         operation somehow was omitted. This patch actually enables the
2337         operation. The check-xcfilelist.sh scripts now check
2338         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2339         from the checking.
2340
2341         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2342         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2343
2344 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2345
2346         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2347         <https://webkit.org/b/194286>
2348         <rdar://problem/47815558>
2349
2350         Reviewed by Alexey Proskuryakov.
2351
2352         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2353         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2354         WKRetainPtr<> to avoid leaking the WKDataRef.
2355
2356 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2357
2358         Unreviewed, fix a typo
2359
2360         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2361
2362 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2363
2364         [GTK][WPE] force libpsl build to use ICU in jhbuild
2365         https://bugs.webkit.org/show_bug.cgi?id=194288
2366
2367         Reviewed by Carlos Garcia Campos.
2368
2369         * gtk/jhbuild.modules:
2370         Require ICU for libpsl build in jhbuild, like done in WPE.
2371
2372 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2373
2374         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2375         https://bugs.webkit.org/show_bug.cgi?id=194209
2376
2377         Reviewed by Carlos Garcia Campos.
2378
2379         Enhance TestCookieManager to ensure this doesn't happen again.
2380
2381         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2382         (testCookieManagerPersistentStorage):
2383         (beforeAll):
2384
2385 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2386
2387         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2388         https://bugs.webkit.org/show_bug.cgi?id=194324
2389
2390         Reviewed by Andy Estes.
2391
2392         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2393         part of the name is already implicit, since this is in testing code in TestOptions.
2394
2395         * WebKitTestRunner/TestController.cpp:
2396         (WTR::TestController::generateContextConfiguration const):
2397         (WTR::updateTestOptionsFromTestHeader):
2398         * WebKitTestRunner/TestOptions.h:
2399         (WTR::TestOptions::hasSameInitializationOptions const):
2400
2401 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2402
2403         [ews-build] Allow * as platform for builders and workers
2404         https://bugs.webkit.org/show_bug.cgi?id=188533
2405
2406         Reviewed by Lucas Forschler.
2407
2408         * BuildSlaveSupport/ews-build/loadConfig.py:
2409         (checkWorkersAndBuildersForConsistency):
2410
2411 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2412
2413         [ews-build] Add few bots to config.json
2414         https://bugs.webkit.org/show_bug.cgi?id=194304
2415
2416         Reviewed by Lucas Forschler.
2417
2418         * BuildSlaveSupport/ews-build/config.json:
2419
2420 2019-02-05  Keith Rollin  <krollin@apple.com>
2421
2422         Enable the automatic checking and regenerations of .xcfilelists during builds
2423         https://bugs.webkit.org/show_bug.cgi?id=194124
2424         <rdar://problem/47721277>
2425
2426         Reviewed by Tim Horton.
2427
2428         Bug 193790 add a facility for checking -- during build time -- that
2429         any needed .xcfilelist files are up-to-date and for updating them if
2430         they are not. This facility was initially opt-in by setting
2431         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2432         the process seemed robust. Its now time to enable this facility and
2433         make it opt-out. If there is a need to disable this facility, set and
2434         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2435         running `make` or `build-webkit`, or before running Xcode from the
2436         command line.
2437
2438         Additionally, remove the step that generates a list of source files
2439         going into the UnifiedSources build step. It's only necessarily to
2440         specify Sources.txt and SourcesCocoa.txt as inputs.
2441
2442         * Scripts/generate-xcfilelists:
2443
2444 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2445
2446         [GTK][WPE] force libpsl build to use ICU in jhbuild
2447         https://bugs.webkit.org/show_bug.cgi?id=194288
2448
2449         Reviewed by Philippe Normand.
2450
2451         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2452         This can cause build failures if libidn is detected but libunistring is not available.
2453
2454         Make sure that ICU is used for runtime and builtin PSL data.
2455
2456         * gtk/jhbuild.modules:
2457         * wpe/jhbuild.modules:
2458
2459 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2460
2461         [ews-app] Modified timestamp should be updated on updating data
2462         https://bugs.webkit.org/show_bug.cgi?id=194295
2463
2464         Reviewed by Lucas Forschler.
2465
2466         * BuildSlaveSupport/ews-app/ews/models/build.py:
2467         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2468         * BuildSlaveSupport/ews-app/ews/models/step.py:
2469
2470 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2471
2472         Unreviewed, rolling out r240742.
2473
2474         Causes crashes on iOS simulator.
2475
2476         Reverted changeset:
2477
2478         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2479         not focused in a content-editable element"
2480         https://bugs.webkit.org/show_bug.cgi?id=192824
2481         https://trac.webkit.org/changeset/240742
2482
2483 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2484
2485         run-webkit-tests emits message "...running None" when running tests
2486         https://bugs.webkit.org/show_bug.cgi?id=194133
2487         <rdar://problem/47724738>
2488
2489         Reviewed by Lucas Forschler.
2490
2491         * Scripts/webkitpy/xcode/device_type.py:
2492         (DeviceType.__str__): Use both version mapping tables and use just the variant
2493         name if no version name is available.
2494         * Scripts/webkitpy/xcode/device_type_unittest.py:
2495         (DeviceTypeTest):
2496         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2497         an associated named.
2498
2499 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2500
2501         [WPE] require python3-setuptools for meson build in jhbuild
2502         https://bugs.webkit.org/show_bug.cgi?id=194287
2503
2504         Reviewed by Philippe Normand.
2505
2506         python3-setuptools is needed to build meson in jhbuild.
2507         It is already required by the GTK port.
2508
2509         * wpe/install-dependencies:
2510
2511 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2512
2513         [ews-app] Add method to save BuilderMapping to database
2514         https://bugs.webkit.org/show_bug.cgi?id=194264
2515
2516         Reviewed by Lucas Forschler.
2517
2518         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2519         (BuilderMapping.__str__):
2520         (BuilderMapping):
2521         (BuilderMapping.save_mapping):
2522         (BuilderMapping.update_mapping):
2523         (BuilderMapping.get_existing_mapping):
2524         (BuilderMapping.is_valid_mapping):
2525
2526 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2527
2528         [ews-app] Add timestamp fields for BuilderMappings
2529         https://bugs.webkit.org/show_bug.cgi?id=194266
2530
2531         Reviewed by Lucas Forschler.
2532
2533         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2534         (BuilderMapping):
2535
2536 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2537
2538         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2539         https://bugs.webkit.org/show_bug.cgi?id=174816
2540
2541         Reviewed by Michael Catanzaro.
2542
2543         Add tests for webkit_uri_for_display().
2544
2545         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2546         (testURIForDisplayUnaffected):
2547         (testURIForDisplayAffected):
2548         (beforeAll):
2549         (afterAll):
2550         * TestWebKitAPI/glib/CMakeLists.txt:
2551
2552 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2553
2554         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2555         https://bugs.webkit.org/show_bug.cgi?id=194158
2556         <rdar://problem/47737268>
2557
2558         Rubber-stamped by Aakash Jain.
2559
2560         * Scripts/webkitpy/port/device_port.py:
2561         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2562
2563 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2564
2565         [CG] Enable setAdditionalSupportedImageTypes for WK1
2566         https://bugs.webkit.org/show_bug.cgi?id=194190
2567
2568         Reviewed by Tim Horton.
2569
2570         Add a test similar to the one under WebKit Cocoa but make it create a
2571         WebView instead of a WKWebView.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2575         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2576         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2577         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2578         (TestWebKitAPI::runTest):
2579         (TestWebKitAPI::TEST):
2580
2581 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2582
2583         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2584         https://bugs.webkit.org/show_bug.cgi?id=194168
2585
2586         Reviewed by Simon Fraser.
2587
2588         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message.
2589
2590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2591         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2592         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2593         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2594         (TEST):
2595         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2596         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2597
2598 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2599
2600         REGRESSION (r237269): webkit-patch what-broke is broken
2601         https://bugs.webkit.org/show_bug.cgi?id=193025
2602
2603         Reviewed by Aakash Jain.
2604
2605         * Scripts/webkitpy/common/host.py:
2606         (Host.buildbot):
2607         (Host.bugzilla): Renamed to 'buildbot'.
2608
2609 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2610
2611         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2612         https://bugs.webkit.org/show_bug.cgi?id=194207
2613
2614         Reviewed by Tim Horton.
2615
2616         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2617         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2618         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2619         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2620         start and delete forwards to remove the original attachment.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2623         (TestWebKitAPI::TEST):
2624
2625 2019-02-04  Youenn Fablet  <youenn@apple.com>
2626
2627         Capture state should be managed consistently when doing process swapping
2628         https://bugs.webkit.org/show_bug.cgi?id=194122
2629         <rdar://problem/47609293>
2630
2631         Reviewed by Eric Carlson.
2632
2633         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2634         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2635         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2636         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2637         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2639         (WTR::TestRunner::isDoingMediaCapture const):
2640         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2641         * WebKitTestRunner/TestController.cpp:
2642         (WTR::TestController::isDoingMediaCapture const):
2643         * WebKitTestRunner/TestController.h:
2644         * WebKitTestRunner/TestInvocation.cpp:
2645         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2646         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2647         (WTR::TestController::isDoingMediaCapture const):
2648
2649 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2650
2651         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2652         https://bugs.webkit.org/show_bug.cgi?id=194142
2653
2654         Reviewed by Ross Kirsling.
2655
2656         There three 'separator' variables in TestController.cpp. Renamed
2657         it 'pathSeparator', and unified them.
2658
2659         * WebKitTestRunner/TestController.cpp:
2660         (WTR::TestController::generateContextConfiguration const):
2661         (WTR::createTestURL):
2662         (WTR::TestController::platformAdjustContext):
2663
2664 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2665
2666         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2667         https://bugs.webkit.org/show_bug.cgi?id=194198
2668
2669         Reviewed by Antti Koivisto.
2670
2671         No need to set the banner heights on navigation now, since Page stores them.
2672
2673         * MiniBrowser/mac/WK2BrowserWindowController.m:
2674         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2675
2676 2019-02-03  John Wilander  <wilander@apple.com>
2677
2678         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2679         https://bugs.webkit.org/show_bug.cgi?id=194104
2680         <rdar://problem/47649991>
2681
2682         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2683
2684         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2685         (TestWebKitAPI::TEST):
2686             Changed numeric types from unsigned short to uint32_t.
2687
2688 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2689
2690         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2691         <https://webkit.org/b/194178>
2692         <rdar://problem/47753473>
2693
2694         Reviewed by Alexey Proskuryakov.
2695
2696         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2697         (WTR::uninstallFakeHelvetica): Pass nullptr into
2698         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2699
2700 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2701
2702         [LFC] Initialize ICB's style with fixed width/height.
2703         https://bugs.webkit.org/show_bug.cgi?id=194188
2704
2705         Reviewed by Antti Koivisto.
2706
2707         * LayoutReloaded/misc/LFC-passing-tests.txt:
2708
2709 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2710
2711         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2712         https://bugs.webkit.org/show_bug.cgi?id=194185
2713
2714         Reviewed by Antti Koivisto.
2715
2716         * LayoutReloaded/misc/LFC-passing-tests.txt:
2717
2718 2018-12-16  Darin Adler  <darin@apple.com>
2719
2720         Convert additional String::format clients to alternative approaches
2721         https://bugs.webkit.org/show_bug.cgi?id=192746
2722
2723         Reviewed by Alexey Proskuryakov.
2724
2725         * WebKitTestRunner/TestController.cpp:
2726         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2727         as an intermediate in code that ultimately constructs a WTF::String.
2728         (WTR::userMediaOriginHash): Use makeString.
2729         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2730         (WTR::TestController::didPerformClientRedirect): Ditto.
2731         (WTR::TestController::didPerformServerRedirect): Ditto.
2732         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2733
2734 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2735
2736         [ews-build] Add unit test to verify builder keys
2737         https://bugs.webkit.org/show_bug.cgi?id=194152
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2742         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2743
2744 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2745
2746         [LFC] Expand tests coverage (12 new tests -> 787)
2747
2748         Unreviewed test gardening.
2749
2750         * LayoutReloaded/misc/LFC-passing-tests.txt:
2751
2752 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2753
2754         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2755         https://bugs.webkit.org/show_bug.cgi?id=194163
2756
2757         Reviewed by Simon Fraser.
2758
2759         775
2760
2761         * LayoutReloaded/misc/LFC-passing-tests.txt:
2762
2763 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2764
2765         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2766         https://bugs.webkit.org/show_bug.cgi?id=194140
2767         <rdar://problem/47728098>
2768
2769         Reviewed by Tim Horton.
2770
2771         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2773         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2774
2775         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2776         test to induce an IPC deadlock when presenting a modal alert during touch start.
2777
2778         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2779         * WebKitTestRunner/TestController.cpp:
2780         (WTR::runJavaScriptAlert):
2781
2782         Add a client callback function for running JavaScript alerts.
2783
2784         (WTR::TestController::createOtherPage):
2785         (WTR::TestController::generateContextConfiguration const):
2786
2787         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2788         the fix in this patch.
2789
2790         (WTR::TestController::createWebViewWithOptions):
2791
2792         Plumb TestOptions to generateContextConfiguration.
2793
2794         (WTR::TestController::resetPreferencesToConsistentValues):
2795         (WTR::TestController::resetStateToConsistentValues):
2796         (WTR::updateTestOptionsFromTestHeader):
2797         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2798         (WTR::TestController::handleJavaScriptAlert):
2799         * WebKitTestRunner/TestController.h:
2800         * WebKitTestRunner/TestInvocation.cpp:
2801         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2802         * WebKitTestRunner/TestOptions.h:
2803         (WTR::TestOptions::hasSameInitializationOptions const):
2804
2805 2019-02-01  Chris Dumez  <cdumez@apple.com>
2806
2807         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2808         https://bugs.webkit.org/show_bug.cgi?id=193740
2809         <rdar://problem/47527267>
2810
2811         Reviewed by Alex Christensen.
2812
2813         Add API test coverage.
2814
2815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2816
2817 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2818
2819         [ews-app] Add display name field to BuilderMapping model
2820         https://bugs.webkit.org/show_bug.cgi?id=194153
2821
2822         Reviewed by Lucas Forschler.
2823
2824         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2825         (BuilderMapping):
2826
2827 2019-02-01  Youenn Fablet  <youenn@apple.com>
2828
2829         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2830         https://bugs.webkit.org/show_bug.cgi?id=194155
2831
2832         Reviewed by Eric Carlson.
2833
2834         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2835         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2836         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2837
2838 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2839
2840         [LFC] Adjust replaced element's intrinsic ratio
2841         https://bugs.webkit.org/show_bug.cgi?id=194154
2842
2843         Reviewed by Antti Koivisto.
2844
2845         761
2846
2847         * LayoutReloaded/misc/LFC-passing-tests.txt:
2848
2849 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2850
2851         [WPE] Show test results in minibrowser
2852         https://bugs.webkit.org/show_bug.cgi?id=194150
2853
2854         Reviewed by Žan Doberšek.
2855
2856         * Scripts/webkitpy/port/wpe.py:
2857         (WPEPort.show_results_html_file):
2858
2859 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2860
2861         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2862         https://bugs.webkit.org/show_bug.cgi?id=194151
2863
2864         Reviewed by Žan Doberšek.
2865
2866         ALT + <- go back
2867         ALT + -> go forward
2868
2869         * MiniBrowser/wpe/main.cpp:
2870         (main):
2871
2872 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2873
2874         [LFC] Set intrinsic size on Layout::Replaced
2875         https://bugs.webkit.org/show_bug.cgi?id=194139
2876
2877         Reviewed by Antti Koivisto.
2878
2879         744
2880
2881         * LayoutReloaded/misc/LFC-passing-tests.txt:
2882
2883 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2884
2885         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2886         https://bugs.webkit.org/show_bug.cgi?id=194146
2887
2888         Reviewed by Xabier Rodriguez-Calvar.
2889
2890         It allows to open relative paths.
2891
2892         * MiniBrowser/wpe/main.cpp:
2893         (main):
2894
2895 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2896
2897         Update flakiness dashboard configuration after recent queue changes
2898         https://bugs.webkit.org/show_bug.cgi?id=194127
2899
2900         Rubber-stamped by Aakash Jain.
2901
2902         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2903
2904         * TestResultServer/static-dashboards/builders.jsonp:
2905
2906 2019-01-31  Youenn Fablet  <youenn@apple.com>
2907
2908         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2909         https://bugs.webkit.org/show_bug.cgi?id=194106
2910         <rdar://problem/47676333>
2911
2912         Reviewed by Ryosuke Niwa.
2913
2914         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2915         (TestWebKitAPI::didFinishNavigation):
2916         (TestWebKitAPI::TEST):
2917         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2918
2919 2019-01-31  Chris Dumez  <cdumez@apple.com>
2920
2921         Page zoom level is lost after a process swap or a crash
2922         https://bugs.webkit.org/show_bug.cgi?id=194105
2923         <rdar://problem/47610781>
2924
2925         Reviewed by Alex Christensen.
2926
2927         Add API test coverage.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2930         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2931
2932 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2933
2934         Revert r238819 which is unneeded and caused a performance regression.
2935         https://bugs.webkit.org/show_bug.cgi?id=192272
2936         <rdar://problem/46664625>
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2939         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2940         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2941
2942 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2943
2944         Formalize WebKitAdditions mechanism of LoadOptimizer
2945         https://bugs.webkit.org/show_bug.cgi?id=193886
2946         <rdar://problem/47696809>
2947
2948         Reviewed by Brent Fulgham.
2949
2950         * MiniBrowser/MiniBrowser.entitlements:
2951         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2952
2953 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2954
2955         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2956         https://bugs.webkit.org/show_bug.cgi?id=194090
2957
2958         Reviewed by Antti Koivisto.
2959
2960         * LayoutReloaded/misc/LFC-passing-tests.txt:
2961
2962 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2963
2964         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2965         https://bugs.webkit.org/show_bug.cgi?id=194074
2966
2967         Reviewed by Antti Koivisto.
2968
2969         * LayoutReloaded/misc/LFC-passing-tests.txt:
2970
2971 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2972
2973         [LFC][BFC] Add support for block level replaced box.
2974         https://bugs.webkit.org/show_bug.cgi?id=194071
2975
2976         Reviewed by Antti Koivisto.
2977
2978         * LayoutReloaded/misc/LFC-passing-tests.txt:
2979
2980 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2981
2982         Fix WebKitTestRunner's testPath with Windows full paths
2983         https://bugs.webkit.org/show_bug.cgi?id=194012
2984
2985         Reviewed by Alex Christensen.
2986
2987         updateTestOptionsFromTestHeader failed to open test files because
2988         testPath returned wrong file paths. It returned a path "/C:/..."
2989         if a URL "file:///C:/..." was given.
2990
2991         * WebKitTestRunner/TestController.cpp:
2992         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2993
2994 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2995
2996         [WPE] Bump font related dependencies to match the GTK+ port
2997         https://bugs.webkit.org/show_bug.cgi?id=194017
2998
2999         Reviewed by Žan Doberšek.
3000
3001         * wpe/jhbuild.modules:
3002         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3003         * wpe/patches/icudata-stdlibs.patch: Added.
3004
3005 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3006
3007         Enable swipe tests on iOS
3008         https://bugs.webkit.org/show_bug.cgi?id=194076
3009
3010         Reviewed by Geoffrey Garen.
3011
3012         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3013         it causes a debug assertion failure in runUIScript.
3014
3015         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3016         (WTR::UIScriptController::beginBackSwipe):
3017         (WTR::UIScriptController::completeBackSwipe):
3018
3019 2019-01-30  Keith Rollin  <krollin@apple.com>
3020
3021         Use correct printf format specifier
3022         https://bugs.webkit.org/show_bug.cgi?id=194062
3023         <rdar://problem/47686167>
3024
3025         Reviewed by Alexey Proskuryakov.
3026
3027         LayoutTestSpellChecker.mm is trying to format a variable of type
3028         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3029         actually an unsigned long long. Fix this by formatting with %llu.
3030
3031         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3032         (-[LayoutTestTextCheckingResult description]):
3033
3034 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3035
3036         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3037         https://bugs.webkit.org/show_bug.cgi?id=193979
3038
3039         Reviewed by Wenson Hsieh.
3040
3041         Fix the test for iOS. Make the test work with iOS UA string.
3042
3043         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3044
3045 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3046
3047         Replace High Sierra LLINT CLoop bot due to hardware failure
3048         https://bugs.webkit.org/show_bug.cgi?id=194066
3049
3050         Reviewed by Aakash Jain.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/config.json:
3053
3054 2019-01-30  Keith Rollin  <krollin@apple.com>
3055
3056         [NSDragItem init] is unavailable
3057         https://bugs.webkit.org/show_bug.cgi?id=194059
3058         <rdar://problem/47685715>
3059
3060         Reviewed by Wenson Hsieh.
3061
3062         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3063         DumpRenderTree and TestWebKitAPI, which both try to create an
3064         NSDragItem in a manner that invokes this method. Address this by using
3065         -initWithPasteboardWriter instead.
3066
3067         Note that the parameter passed to initWithPasteboardWriter is likely
3068         incorrect. In both cases, the object passed does not conform to
3069         NSPasteboardWriting. However, with this fix, we're no worse off than
3070         before, and can now perform builds with newer compilers and SDKs until
3071         a real fix can be crafted. That work is tracked in
3072         https://bugs.webkit.org/show_bug.cgi?id=194060
3073
3074         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3075         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3076         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3077         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3078
3079 2019-01-30  Daniel Bates  <dabates@apple.com>
3080
3081         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3082         https://bugs.webkit.org/show_bug.cgi?id=192824
3083         <rdar://problem/47100332>
3084
3085         Reviewed by Wenson Hsieh.
3086
3087         Fix a bug where the wrong usage code was used for F13 thru F24.
3088
3089         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3090         (keyCodeForDOMFunctionKey):
3091
3092 2019-01-30  Chris Dumez  <cdumez@apple.com>
3093
3094         Regression(PSON) Load hang can occur on history navigation
3095         https://bugs.webkit.org/show_bug.cgi?id=194030
3096         <rdar://problem/47656939>
3097
3098         Reviewed by Antti Koivisto.
3099
3100         Add API test coverage.
3101
3102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3103
3104 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3105
3106         [LFC] Expand tests coverage.
3107
3108         Unreviewed test gardening.
3109
3110         * LayoutReloaded/misc/LFC-passing-tests.txt:
3111
3112 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3113
3114         [Flatpak] Add openjpeg support
3115         https://bugs.webkit.org/show_bug.cgi?id=194019
3116
3117         Reviewed by Michael Catanzaro.
3118
3119         * flatpak/org.webkit.CommonModules.yaml:
3120
3121 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3122
3123         Unreviewed, rolling out r240708.
3124         https://bugs.webkit.org/show_bug.cgi?id=194022
3125
3126         It broke WPE build (Requested by KaL on #webkit).
3127
3128         Reverted changeset:
3129
3130         "[WPE] Bump font related dependencies to match the GTK+ port"
3131         https://bugs.webkit.org/show_bug.cgi?id=194017
3132         https://trac.webkit.org/changeset/240708
3133
3134 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3135
3136         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3137         https://bugs.webkit.org/show_bug.cgi?id=194001
3138
3139         Reviewed by Antti Koivisto.
3140
3141         * LayoutReloaded/misc/LFC-passing-tests.txt:
3142
3143 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3144
3145         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3146         https://bugs.webkit.org/show_bug.cgi?id=194020
3147
3148         Reviewed by Antti Koivisto.
3149
3150         * LayoutReloaded/misc/LFC-passing-tests.txt:
3151
3152 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3153
3154         AX: Support color well on iOS
3155         https://bugs.webkit.org/show_bug.cgi?id=194010
3156
3157         Reviewed by Joanmarie Diggs.
3158
3159         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3160         (WTR::AccessibilityUIElement::stringAttributeValue):
3161
3162 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3163
3164         [WPE] Bump font related dependencies to match the GTK+ port
3165         https://bugs.webkit.org/show_bug.cgi?id=194017
3166
3167         Reviewed by Žan Doberšek.
3168
3169         * wpe/jhbuild.modules:
3170         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3171         * wpe/patches/icudata-stdlibs.patch: Added.
3172
3173 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3174
3175         [Mac] Update window scale API usage
3176         https://bugs.webkit.org/show_bug.cgi?id=193991
3177         rdar://problem/47614795
3178
3179         Reviewed by Tim Horton.
3180
3181         * DumpRenderTree/mac/DumpRenderTree.mm:
3182         (changeWindowScaleIfNeeded):
3183         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3184         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3185         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3186
3187 2019-01-29  Chris Dumez  <cdumez@apple.com>
3188
3189         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3190         https://bugs.webkit.org/show_bug.cgi?id=193977
3191         <rdar://problem/47643716>
3192
3193         Reviewed by Geoff Garen.
3194
3195         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3196         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3197         to the previous provisional committing *before* we make the last load.
3198
3199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3200
3201 2019-01-29  Youenn Fablet  <youenn@apple.com>
3202
3203         Adopt new SPI to evaluate server certificate trust
3204         https://bugs.webkit.org/show_bug.cgi?id=193355
3205
3206         Reviewed by Alex Christensen.
3207
3208         Add infrastructure to handle HTTPS server trust evaluation testing.
3209
3210         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3212         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3213         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3214         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3215         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3216         * WebKitTestRunner/TestController.cpp:
3217         (WTR::TestController::resetPreferencesToConsistentValues):
3218         (WTR::TestController::didReceiveAuthenticationChallenge):
3219         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3220         * WebKitTestRunner/TestController.h:
3221         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3222         * WebKitTestRunner/TestInvocation.cpp:
3223         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3224         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3225         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3226
3227 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-build] Add build step to print bot Configuration
3230         https://bugs.webkit.org/show_bug.cgi?id=193887
3231
3232         Reviewed by Lucas Forschler.
3233
3234         * BuildSlaveSupport/ews-build/steps.py:
3235         (PrintConfiguration): Build step to print configuration.
3236         * BuildSlaveSupport/ews-build/factories.py:
3237
3238 2019-01-29  Chris Dumez  <cdumez@apple.com>
3239
3240         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3241         https://bugs.webkit.org/show_bug.cgi?id=193967
3242         <rdar://problem/47635348>
3243
3244         Reviewed by Alex Christensen.
3245
3246         Add API test coverage.
3247
3248         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3249         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3250
3251 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-app] Handle incoming results data
3254         https://bugs.webkit.org/show_bug.cgi?id=193973
3255
3256         Reviewed by Lucas Forschler.
3257
3258         * BuildSlaveSupport/ews-app/ews/views/results.py:
3259
3260 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3261
3262         [ews-app] Make the results url generic
3263         https://bugs.webkit.org/show_bug.cgi?id=193928
3264
3265         Reviewed by Lucas Forschler.
3266
3267         * BuildSlaveSupport/ews-app/ews/urls.py:
3268
3269 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-build] Configure buildbot to send events to ews-app
3272         https://bugs.webkit.org/show_bug.cgi?id=193968
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-build/events.py: Added.
3277         * BuildSlaveSupport/ews-build/master.cfg:
3278
3279 2019-01-29  Keith Rollin  <krollin@apple.com>
3280
3281         Add .xcfilelists to Run Script build phases
3282         https://bugs.webkit.org/show_bug.cgi?id=193792
3283         <rdar://problem/47201785>
3284
3285         Reviewed by Alex Christensen.
3286
3287         As part of supporting XCBuild, update the necessary Run Script build
3288         phases in their Xcode projects to refer to their associated
3289         .xcfilelist files.
3290
3291         Note that the addition of these files bumps the Xcode project version
3292         number to something that's Xcode 10 compatible. This change means that
3293         older versions of the Xcode IDE can't read these projects. Nor can it
3294         fully load workspaces that refer to these projects (the updated
3295         projects are shown as non-expandable placeholders). `xcodebuild` can
3296         still build these projects; it's just that the IDE can't open them.
3297
3298         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3299         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3300
3301 2019-01-29  John Wilander  <wilander@apple.com>
3302
3303         Add data abstraction and validation for Ad Click Attribution
3304         https://bugs.webkit.org/show_bug.cgi?id=193916
3305         <rdar://problem/47603481>
3306
3307         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3308
3309         Ad click attribution has two steps. First, the storage of an ad
3310         campaign ID for a click that takes the user to a destination
3311         site. Second, a conversion on the destination site that can be
3312         attributed to the ad click.
3313
3314         This patch adds a class that represents a request for ad click
3315         attribution. Validation makes sure that the bits of entropy
3316         reported through this mechanism is limited.
3317
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3320         (TestWebKitAPI::TEST):
3321
3322 2019-01-29  Chris Dumez  <cdumez@apple.com>
3323
3324         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3325         https://bugs.webkit.org/show_bug.cgi?id=193932
3326         <rdar://problem/47598947>
3327
3328         Reviewed by Brady Eidson.
3329
3330         Add API test coverage.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3333
3334 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3335
3336         Adding new passing LFC tests.
3337
3338         Unreviewed test gardening.
3339
3340         * LayoutReloaded/misc/LFC-passing-tests.txt:
3341
3342 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3343
3344         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3345         https://bugs.webkit.org/show_bug.cgi?id=193964
3346
3347         Reviewed by Antti Koivisto.
3348
3349         * LayoutReloaded/misc/LFC-passing-tests.txt:
3350
3351 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3352
3353         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3354         https://bugs.webkit.org/show_bug.cgi?id=193954
3355
3356         Reviewed by Antti Koivisto.
3357
3358         * LayoutReloaded/misc/LFC-passing-tests.txt:
3359
3360 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3361
3362         WebDriver: add support for running subtests
3363         https://bugs.webkit.org/show_bug.cgi?id=193904
3364
3365         Reviewed by Michael Catanzaro.
3366
3367         pytest already supports it by passing test.py::subtest, so we can do the same.
3368
3369         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3370         (get_item_name): Made this global.
3371         (CollectRecorder.__init__): Receive the parameter to ignore.
3372         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3373         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3374         (collect): Add parameter to ignore.
3375         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3376         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3377         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3378         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3379         (WebDriverTestRunnerSelenium.run): Ditto.
3380         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3381         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3382         (WebDriverTestRunnerW3C.run): Ditto.
3383
3384 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3385
3386         User agent string override for navigator.userAgent should be site specific quirks
3387         https://bugs.webkit.org/show_bug.cgi?id=193950
3388
3389         Reviewed by Brent Fulgham.
3390
3391         Updated per the _WKWebsitePolicies rename.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3394         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3395
3396 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3397
3398         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3399         https://bugs.webkit.org/show_bug.cgi?id=193941
3400
3401         Reviewed by Alex Christensen.
3402
3403         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3404         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3405         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3406         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3407         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3408         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3409         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3410         * TestWebKitAPI/Tests/WTF/Time.cpp:
3411         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3412         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3413         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3414         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3415
3416 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3417
3418         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3419
3420         * Scripts/webkitpy/common/config/contributors.json:
3421
3422 2019-01-28  Andy Estes  <aestes@apple.com>
3423
3424         [watchOS] Enable Parental Controls content filtering
3425         https://bugs.webkit.org/show_bug.cgi?id=193939
3426         <rdar://problem/46641912>
3427
3428         Reviewed by Ryosuke Niwa.
3429
3430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3431
3432 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3433
3434         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3435         <https://webkit.org/b/193884>
3436
3437         Reviewed by Jiewen Tan.
3438
3439         * Scripts/webkitpy/style/checkers/cpp.py:
3440         (check_language): Add LocalAuthentication to
3441         `frameworks_with_soft_links`.
3442
3443 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3444
3445         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3446         https://bugs.webkit.org/show_bug.cgi?id=193891
3447
3448         Reviewed by Ross Kirsling.
3449
3450         There were three problems in window sizes of WebView and the host window.
3451         1. The sizes of pixel image output were incorrect.
3452         2. The host window is going to appear after window.resize was invoked.
3453         3. window.resize resized only the host window, not WebView.
3454
3455         This change solves them with a following approach.
3456         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3457         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3458            as well as DumpRenderTree in order to match the client area and the window area.
3459         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3460         d. PlatformWebView::setWindowFrame changes both window sizes.
3461         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3462
3463         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3464         (WTR::PlatformWebView::PlatformWebView): Create the host window
3465         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3466         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3467         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3468
3469 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3470
3471         [ews-app] Add method to save Step data to database
3472         https://bugs.webkit.org/show_bug.cgi?id=193890
3473
3474         Reviewed by Lucas Forschler.
3475
3476         * BuildSlaveSupport/ews-app/ews/models/step.py:
3477         (Step.save_step): Method to save step data.
3478         (Step.update_step): Method to update step data.
3479         (Step.get_existing_step): Method to fetch existing step from database.
3480         (Step.is_valid_result): Method to validate valid step result.
3481
3482 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3483
3484         [ews-app] Add method to save Build data to database
3485         https://bugs.webkit.org/show_bug.cgi?id=193735
3486
3487         Reviewed by Lucas Forschler.
3488
3489         * BuildSlaveSupport/ews-app/ews/models/build.py:
3490         (Build.save_build): Method to save build information to database.
3491         (Build.get_existing_build): Method to fetch existing build from database.
3492         (Build.is_valid_result): Method to validate build result.
3493         * BuildSlaveSupport/ews-app/ews/common/util.py:
3494         (is_valid_int_id): Method to validate valid id.
3495
3496 2019-01-28  Chris Dumez  <cdumez@apple.com>
3497
3498         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3499         https://bugs.webkit.org/show_bug.cgi?id=193915
3500         <rdar://problem/47560907>
3501
3502         Reviewed by Alex Christensen.
3503
3504         Add API test coverage.
3505
3506         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3507
3508 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3509
3510         [ews-app] Rename id variables
3511         https://bugs.webkit.org/show_bug.cgi?id=193883
3512
3513         Reviewed by Lucas Forschler.
3514
3515         * BuildSlaveSupport/ews-app/ews/models/build.py:
3516         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3517         * BuildSlaveSupport/ews-app/ews/models/step.py:
3518         * BuildSlaveSupport/ews-app/ews/urls.py:
3519         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3520         * BuildSlaveSupport/ews-app/ews/views/results.py:
3521         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3522
3523 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3524
3525         [ews-app] Allow certain fields to be empty
3526         https://bugs.webkit.org/show_bug.cgi?id=193892
3527
3528         Reviewed by Lucas Forschler.
3529
3530         * BuildSlaveSupport/ews-app/ews/models/build.py:
3531         * BuildSlaveSupport/ews-app/ews/models/step.py:
3532
3533 2019-01-28  Rob Buis  <rbuis@igalia.com>
3534
3535         Update MIME type parser
3536         https://bugs.webkit.org/show_bug.cgi?id=180526
3537
3538         Reviewed by Frédéric Wang.
3539
3540         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3541         (TestWebKitAPI::TEST):
3542
3543 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3544
3545         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3546         https://bugs.webkit.org/show_bug.cgi?id=193896
3547
3548         Reviewed by Antti Koivisto.
3549
3550         * LayoutReloaded/misc/LFC-passing-tests.txt:
3551
3552 2018-12-15  Darin Adler  <darin@apple.com>
3553
3554         Replace many uses of String::format with more type-safe alternatives
3555         https://bugs.webkit.org/show_bug.cgi?id=192742
3556
3557         Reviewed by Mark Lam.
3558
3559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3560         (WTR::cacheTestRunnerCallback): Use makeString.
3561         * WebKitTestRunner/TestController.cpp:
3562         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3563         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3564
3565 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3566
3567         Use a load optimizer for some sites
3568         https://bugs.webkit.org/show_bug.cgi?id=193881
3569         <rdar://problem/46325455>
3570
3571         Reviewed by Brent Fulgham.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3575
3576 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3577
3578         AX: Introduce a static accessibility tree
3579         https://bugs.webkit.org/show_bug.cgi?id=193348
3580         <rdar://problem/47203295>
3581
3582         Reviewed by Ryosuke Niwa.
3583
3584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3585
3586 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3587
3588         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3589         https://bugs.webkit.org/show_bug.cgi?id=193867
3590
3591         Reviewed by Antti Koivisto.
3592
3593         * LayoutReloaded/misc/LFC-passing-tests.txt:
3594
3595 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3596
3597         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3598         https://bugs.webkit.org/show_bug.cgi?id=193865
3599
3600         Reviewed by Antti Koivisto.
3601
3602         * LayoutReloaded/misc/LFC-passing-tests.txt:
3603
3604 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3605
3606         Need a mechanism to override navigator.userAgent
3607         https://bugs.webkit.org/show_bug.cgi?id=193762
3608         <rdar://problem/47504939>
3609
3610         Reviewed by Brent Fulgham.
3611
3612         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3613
3614         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3615         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3616         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3617
3618 2019-01-25  Dean Jackson  <dino@apple.com>
3619
3620         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3621         https://bugs.webkit.org/show_bug.cgi?id=193831
3622         <rdar://problem/47399263>
3623
3624         Reviewed by Chris Dumez.
3625
3626         Two new tests that exercise cross-origin and same-origin System
3627         Previews.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3630
3631 2019-01-25  Keith Rollin  <krollin@apple.com>
3632
3633         Update Xcode projects with "Check .xcfilelists" build phase
3634         https://bugs.webkit.org/show_bug.cgi?id=193790
3635         <rdar://problem/47201374>
3636
3637         Reviewed by Alex Christensen.
3638
3639         Support for XCBuild includes specifying inputs and outputs to various
3640         Run Script build phases. These inputs and outputs are specified as
3641         .xcfilelist files. Once created, these .xcfilelist files need to be
3642         kept up-to-date. In order to check that they are up-to-date or not,
3643         add an Xcode build step that invokes an external script that performs
3644         the checking. If the .xcfilelists are found to be out-of-date, update
3645         them, halt the build, and instruct the developer to restart the build
3646         with up-to-date files.
3647
3648         At this time, the checking and regenerating is performed only if the
3649         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3650         who want to use this facility can set this variable and test out the
3651         checking/regenerating. Once it seems like there are no egregious
3652         issues that upset a developer's workflow, we'll unconditionally enable
3653         this facility.
3654
3655         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3656         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3657         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3658         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3659
3660 2019-01-25  Keith Rollin  <krollin@apple.com>
3661
3662         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3663         https://bugs.webkit.org/show_bug.cgi?id=193781
3664         <rdar://problem/47201153>
3665
3666         Reviewed by Alex Christensen.
3667
3668         Part of generating the .xcfilelists used as part of adopting XCBuild
3669         includes running `make DerivedSources.make` from a standalone script.
3670         It’s important for this invocation to have the same environment as
3671         when the actual build invokes `make DerivedSources.make`. If the
3672         environments are different, then the two invocations will provide
3673         different results. In order to get the same environment in the
3674         standalone script, have the script launch xcodebuild targeting the
3675         "Apply Configuration to XCFileLists" build target, which will then
3676         re-invoke our standalone script. The script is now running again, this
3677         time in an environment with all workspace, project, target, xcconfig
3678         and other environment variables established.
3679
3680         The "Apply Configuration to XCFileLists" build target accomplishes
3681         this task via a small embedded shell script that consists only of:
3682
3683             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3684
3685         The process that invokes "Apply Configuration to XCFileLists" first
3686         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3687         evaluated and exports it into the shell environment. When xcodebuild
3688         is invoked, it inherits the value of this variable and can `eval` the
3689         contents of that variable. Our external standalone script can then set
3690         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3691         of command-line parameters needed to restart itself in the appropriate
3692         state.
3693
3694         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3695         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3696
3697 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3698
3699         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3700         https://bugs.webkit.org/show_bug.cgi?id=193802
3701         <rdar://problem/46010580>
3702
3703         Reviewed by Andy Estes.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3706         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3707         (TEST):
3708
3709 2019-01-25  Daniel Bates  <dabates@apple.com>
3710
3711         [iOS] uiController.keyDown() does not translate Control modified key
3712         https://bugs.webkit.org/show_bug.cgi?id=192898
3713
3714         Reviewed by Wenson Hsieh.
3715
3716         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3717         key translation, as applicable. Among other cases, key translation occurs when performing
3718         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3719         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3720         human pressing down and releasing key(s) using a hardware keyboard.
3721
3722         * WebKitTestRunner/ios/HIDEventGenerator.h:
3723         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3724         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3725
3726         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3727         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3728         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3729         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3730         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3731         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3732         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3733         (-[HIDEventGenerator longPress:completionBlock:]):
3734         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3735         Update code for above renaming.
3736
3737         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3738         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3739
3740         (-[HIDEventGenerator keyDown:]): Added.
3741         (-[HIDEventGenerator keyUp:]): Added.
3742         (-[HIDEventGenerator keyPress:completionBlock:]):
3743         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3744         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3745         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3746         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3747         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3748         (WTR::parseModifier): Deleted.
3749
3750 2019-01-25  Keith Rollin  <krollin@apple.com>
3751
3752         Complete the implementation of generate-xcfilelists
3753         https://bugs.webkit.org/show_bug.cgi?id=193782
3754
3755         Reviewed by Alex Christensen.
3756
3757         A preliminary version of generate-xcfilelists was added in r238008.
3758         This patch updates that script in order to:
3759
3760         - Support checking of .xcfilelists
3761         - Perform better execution of `make DerivedSources.make` by
3762           relaunching generate-xcfilelists under xcodebuild
3763         - Support incremental generation and checking of .xcfilelists
3764         - Support supplementary .xcfilelists files from WebKitAdditions
3765         - Support being wrapped by parallel version of generate-xcfilelists in
3766           Internal that adds support for (re)generating WebKit projects in
3767           that repo.
3768         - Support builds that have been performed in WebKitBuild as well as
3769           ~/Library/Developer/code/DerivedData
3770         - Increase robustness and debugging facilities.
3771
3772         * Scripts/generate-xcfilelists:
3773
3774 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3775
3776         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3777         https://bugs.webkit.org/show_bug.cgi?id=193297
3778         <rdar://problem/47158841>
3779
3780         Unreviewed test case fix.
3781
3782         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3783         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3784
3785         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3786         (TEST):
3787
3788 2019-01-25  Keith Rollin  <krollin@apple.com>
3789
3790         Update existing .xcfilelists
3791         https://bugs.webkit.org/show_bug.cgi?id=193791
3792         <rdar://problem/47201706>
3793
3794         Reviewed by Alex Christensen.
3795
3796         Many .xcfilelist files were added in r238824 in order to support
3797         XCBuild. Update these with recent changes to the set of build files
3798         and with the current generate-xcfilelist script.
3799
3800         * DumpRenderTree/DerivedSources-input.xcfilelist:
3801         * DumpRenderTree/DerivedSources-output.xcfilelist:
3802         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3803         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3804
3805 2019-01-25  Keith Rollin  <krollin@apple.com>
3806
3807         Fix missing dependencies in extract-dependencies-from-makefile
3808         https://bugs.webkit.org/show_bug.cgi?id=193783
3809         <rdar://problem/47201571>
3810
3811         Reviewed by Alex Christensen.
3812
3813         The extract-dependencies-from-makefile script generates .xcfilelists
3814         for XCBuild by invoking a makefile in --debug mode, parsing the
3815         dependency information in the output, and extracting information
3816         regarding targets and dependents. However, the way `make` emits this
3817         dependency information is not rigorous, and so we need to determine
3818         what lines to look for and parse by trial and error. This approach
3819         didn't coriginally atch all the information we needed to collect, so
3820         update the script to look for the additional lines we now know to look
3821         for.
3822
3823         * Scripts/extract-dependencies-from-makefile:
3824         (Parser):
3825         (Parser.addTarget):
3826         (Parser.addPrereq):
3827         (Parser.doParse):
3828
3829 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3830
3831         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3832         https://bugs.webkit.org/show_bug.cgi?id=193297
3833         <rdar://problem/47158841>
3834
3835         Reviewed by Alex Christensen.
3836
3837         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3838             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3840         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3841         activating the message used to trigger the callback when it is set.
3842
3843 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3844
3845         WKWebView.goBack should reload if there is a safe browsing warning
3846         https://bugs.webkit.org/show_bug.cgi?id=193805
3847         <rdar://problem/46908216>
3848
3849         Reviewed by Geoff Garen.
3850
3851         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3852         (+[Simple3LookupContext sharedLookupContext]):
3853         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3854         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3855         (TEST):
3856
3857 2019-01-25  Chris Dumez  <cdumez@apple.com>
3858
3859         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3860         https://bugs.webkit.org/show_bug.cgi?id=193788
3861         <rdar://problem/47531231>
3862
3863         Reviewed by Alex Christensen.
3864
3865         Add API test coverage.
3866
3867         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3868         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3869
3870 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3871
3872         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3873         https://bugs.webkit.org/show_bug.cgi?id=193771
3874
3875         Unreviewed infrastructure fix.
3876
3877         * Scripts/webkitpy/port/darwin.py:
3878         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3879
3880 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3881
3882         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3883
3884 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3885
3886         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3887
3888         * Scripts/webkitpy/common/config/contributors.json:
3889
3890 2019-01-25  Chris Dumez  <cdumez@apple.com>
3891
3892         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3893         https://bugs.webkit.org/show_bug.cgi?id=193779
3894         <rdar://problem/46170903>
3895
3896         Reviewed by Antti Koivisto.
3897
3898         Add API test that quickly navigates forward to a previous process without waiting for it to
3899         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3900         the process' previous page when reconnecting the it for the forward navigation.
3901
3902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3903
3904 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3905
3906         Need a way for JavaScript (or bundle) code to participate in undo
3907         https://bugs.webkit.org/show_bug.cgi?id=190009
3908         <rdar://problem/44807048>
3909
3910         Reviewed by Ryosuke Niwa.
3911
3912         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3913         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3914
3915         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3916         (WTR::UIScriptController::lastUndoLabel const):
3917         (WTR::UIScriptController::firstRedoLabel const):
3918         (WTR::UIScriptController::platformUndoManager const):
3919         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3920         (WTR::UIScriptController::lastUndoLabel const):
3921         (WTR::UIScriptController::firstRedoLabel const):
3922         (WTR::UIScriptController::platformUndoManager const):
3923         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3924         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3925         (WTR::UIScriptController::lastUndoLabel const):
3926         (WTR::UIScriptController::firstRedoLabel const):
3927         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3928         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3929         (WTR::UIScriptController::lastUndoLabel const):
3930         (WTR::UIScriptController::firstRedoLabel const):
3931         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3932         (WTR::UIScriptController::platformUndoManager const):
3933         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3934         (WTR::UIScriptController::platformUndoManager const):
3935
3936 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3937
3938         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3939         https://bugs.webkit.org/show_bug.cgi?id=193824
3940
3941         Reviewed by Antti Koivisto.
3942
3943         * LayoutReloaded/misc/LFC-passing-tests.txt:
3944
3945 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3946
3947         Update macOS JSC bot configurations
3948         https://bugs.webkit.org/show_bug.cgi?id=193739
3949
3950         Reviewed by Alexey Proskuryakov.
3951
3952         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3954         (BubbleQueueServer): Move JSC EWS to Mojave section.
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3956         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3957         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3958
3959 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3960
3961         [Win][WebKitTestRunner] Implement EventSenderProxy
3962         https://bugs.webkit.org/show_bug.cgi?id=193755
3963
3964         Reviewed by Don Olmstead.
3965
3966         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3967         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3968         (WTR::EventSenderProxy::dispatchMessage):
3969         (WTR::EventSenderProxy::EventSenderProxy):
3970         (WTR::EventSenderProxy::mouseDown):
3971         (WTR::EventSenderProxy::mouseUp):
3972         (WTR::EventSenderProxy::mouseMoveTo):
3973         (WTR::EventSenderProxy::mouseScrollBy):
3974         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3975
3976 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3977
3978         Unreviewed fix for API test failure after r240437.
3979
3980         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3981
3982         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3983
3984 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3985
3986         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3987         https://bugs.webkit.org/show_bug.cgi?id=193787
3988         <rdar://problem/47497634>
3989
3990         Reviewed by Alexey Proskuryakov.
3991
3992         * Scripts/webkitdirs.pm:
3993         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3994
3995 2019-01-24  Truitt Savell  <tsavell@apple.com>
3996
3997         Unreviewed, rolling out r240446.
3998
3999         Casued 5 API failures
4000
4001         Reverted changeset:
4002
4003         "Activate the WebResourceLoadStatisticsStore in the
4004         NetworkProcess and deactivate it in the UIProcess."
4005         https://bugs.webkit.org/show_bug.cgi?id=193297
4006         https://trac.webkit.org/changeset/240446
4007
4008 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4009
4010         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4011         https://bugs.webkit.org/show_bug.cgi?id=193741
4012         <rdar://problem/47135030>
4013
4014         Reviewed by Antti Koivisto and Simon Fraser.
4015
4016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4017         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4018         (TestWebKitAPI::TEST):
4019
4020 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4021
4022         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4023         https://bugs.webkit.org/show_bug.cgi?id=193297
4024         <rdar://problem/47158841>
4025
4026         Reviewed by Alex Christensen.
4027
4028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4029         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4030         activating the message used to trigger the callback when it is set.
4031
4032 2019-01-24  John Wilander  <wilander@apple.com>
4033
4034         Add Ad Click Attribution as an internal/experimental feature
4035         https://bugs.webkit.org/show_bug.cgi?id=193685
4036         <rdar://problem/47450399>
4037
4038         Reviewed by Brent Fulgham.
4039
4040         Added test option adClickAttributionEnabled.
4041
4042         * DumpRenderTree/TestOptions.cpp:
4043         (TestOptions::TestOptions):
4044         * DumpRenderTree/TestOptions.h:
4045         * DumpRenderTree/mac/DumpRenderTree.mm:
4046         (setWebPreferencesForTestOptions):
4047
4048 2019-01-24  Antti Koivisto  <antti@apple.com>
4049
4050         [PSON] Flash on back navigation on Mac
4051         https://bugs.webkit.org/show_bug.cgi?id=193716
4052         <rdar://problem/47148458>
4053
4054         Reviewed by Chris Dumez.
4055
4056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4057
4058         Closing of the previous page is delayed so waiting for didFinishNavigation is
4059         not sufficient to guarantee we have received all the messages. Wait for them.
4060
4061 2019-01-24  Chris Dumez  <cdumez@apple.com>
4062
4063         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4064         https://bugs.webkit.org/show_bug.cgi?id=193761
4065         <rdar://problem/47456405>
4066
4067         Reviewed by Alex Christensen.
4068
4069         Add API test coverage.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4072
4073 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4074
4075         webkitpy: Missing PID in crashlog name should not be fatal
4076         https://bugs.webkit.org/show_bug.cgi?id=193771
4077
4078         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4079         of raising an exception.
4080
4081         Reviewed by Lucas Forschler.
4082
4083         * Scripts/webkitpy/port/darwin.py:
4084         (DarwinPort._merge_crash_logs):
4085
4086 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4087
4088         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4089         https://bugs.webkit.org/show_bug.cgi?id=193746
4090
4091         Reviewed by Youenn Fablet.
4092
4093         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4094         so we'd best just not call it.
4095
4096         * Scripts/webkitpy/w3c/test_exporter.py:
4097         (WebPlatformTestExporter.create_branch_with_patch):
4098
4099 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4100
4101         Move FileSystem to WTF
4102         https://bugs.webkit.org/show_bug.cgi?id=193602
4103
4104         Reviewed by Yusuke Suzuki.
4105
4106         * DumpRenderTree/win/DumpRenderTree.cpp:
4107         * TestWebKitAPI/CMakeLists.txt:
4108         * TestWebKitAPI/PlatformGTK.cmake:
4109         * TestWebKitAPI/PlatformJSCOnly.cmake:
4110         * TestWebKitAPI/PlatformPlayStation.cmake:
4111         * TestWebKitAPI/PlatformWPE.cmake:
4112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4113         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4114         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4115         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4116         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4117         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4118         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4119         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4120         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4121         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4122
4123 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4124
4125         [WPE] Remove hard dependency on subprocess32 for the API tests
4126
4127         Rubber-stamped by Carlos Garcia Campos.
4128
4129         * glib/api_test_runner.py:
4130         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4131         its presence only when running WPEQt tests.
4132
4133 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4134
4135         [GLIB] Expose JavaScriptCore options in GLib public API
4136         https://bugs.webkit.org/show_bug.cgi?id=188742
4137
4138         Reviewed by Michael Catanzaro.
4139
4140         Add a test for the new API.
4141
4142         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4143         (testsJSCOptions):
4144         (main):
4145
4146 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4147
4148         [GTK][WPE] Support JPEG 2000 images
4149         https://bugs.webkit.org/show_bug.cgi?id=186272
4150
4151         Reviewed by Žan Doberšek.
4152
4153         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4154
4155         * gtk/jhbuild.modules:
4156         * wpe/jhbuild.modules:
4157
4158 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4159
4160         check-webkit-style should warn when using soft-linking macros in a header
4161         <https://webkit.org/b/193750>
4162
4163         Reviewed by Darin Adler.
4164
4165         * Scripts/webkitpy/style/checkers/cpp.py:
4166         (check_language): Add softlink/header check by refactoring the
4167         softlink/framework check.
4168         (CppChecker): Enable softlink/header check by default.
4169         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4170         (CppStyleTest.test_softlink_framework): Rename from
4171         CppStyleTest.test_softlink() and change test framework name in
4172         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4173         files. Set file_name for macros that only appear in headers.
4174         (CppStyleTest.test_softlink_header): Add tests for using
4175         soft-link macros in headers.
4176
4177 2019-01-23  Chris Dumez  <cdumez@apple.com>
4178
4179         Deprecate API to limit the maximum number of WebProcesses
4180         https://bugs.webkit.org/show_bug.cgi?id=193725
4181         <rdar://problem/47464879>
4182
4183         Reviewed by Geoff Garen.
4184
4185         Update existing API tests to stop using deprecated API.
4186
4187         * MiniBrowser/mac/AppDelegate.m:
4188         (defaultConfiguration):
4189         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4190         (TestWebKitAPI::TEST):
4191         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4192         (TestWebKitAPI::TEST):
4193         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4194         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4195         (TEST):
4196         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4197         (TEST):
4198
4199 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4200
4201         [ews-app] Rename ews model buildermappings to buildermapping
4202         https://bugs.webkit.org/show_bug.cgi?id=193729
4203
4204         Reviewed by Lucas Forschler.
4205
4206         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4207         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4208         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4209
4210 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4211
4212         [ews-app] Rename ews model steps to step
4213         https://bugs.webkit.org/show_bug.cgi?id=193697
4214
4215         Reviewed by Lucas Forschler.
4216
4217         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4218         (Step): Renamed Steps to Step.
4219
4220 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4221
4222         Clean up IndexedDB files between tests
4223         https://bugs.webkit.org/show_bug.cgi?id=192796
4224         <rdar://problem/46824999>
4225
4226         Reviewed by Geoffrey Garen.
4227
4228         * DumpRenderTree/mac/DumpRenderTree.mm:
4229         (runTest):
4230         * WebKitTestRunner/TestController.cpp:
4231         (WTR::TestController::resetStateToConsistentValues):
4232         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4233         (WTR::RemoveAllIndexedDatabasesCallback):
4234         (WTR::TestController::ClearIndexedDatabases):
4235         * WebKitTestRunner/TestController.h:
4236         * WebKitTestRunner/TestInvocation.cpp:
4237         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4238
4239 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4240
4241         [ews-app] Rename ews model Builds to Build
4242         https://bugs.webkit.org/show_bug.cgi?id=193695
4243
4244         Reviewed by Lucas Forschler.
4245
4246         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4247         (Build): Renamed Builds to Build.
4248
4249 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4250
4251         webkitpy: Wait longer when launching WebKitTestRunner
4252         https://bugs.webkit.org/show_bug.cgi?id=193734
4253
4254         Reviewed by Aakash Jain.
4255
4256         * Scripts/webkitpy/port/simulator_process.py:
4257         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4258
4259 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4260
4261         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4262         https://bugs.webkit.org/show_bug.cgi?id=193182
4263         <rdar://problem/47452154>
4264
4265         Reviewed by Tim Horton.
4266
4267         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4268         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4269         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4270
4271         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4272         preventing later tests from recognizing gestures.
4273
4274         * WebKitTestRunner/ios/TestControllerIOS.mm:
4275         (WTR::TestController::platformResetStateToConsistentValues):
4276
4277         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4278
4279 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4280
4281         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4282         https://bugs.webkit.org/show_bug.cgi?id=193722
4283         <rdar://problem/47481475>
4284
4285         Reviewed by Lucas Forschler.
4286
4287         iPhone and iPad ports should both use the iOS config.
4288
4289         * Scripts/webkitpy/port/ios_simulator.py:
4290         (IPhoneSimulatorPort.__init__):
4291         (IPadSimulatorPort.__init__):
4292
4293 2019-01-23  Rob Buis  <rbuis@igalia.com>
4294
4295         Update MIME type parser
4296         https://bugs.webkit.org/show_bug.cgi?id=180526
4297
4298         Reviewed by Frédéric Wang.
4299
4300         Add unit tests for both parse modes of ParsedContentType.
4301
4302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4303         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4304         (TestWebKitAPI::TEST):
4305
4306 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4307
4308         [ews-app] fetch loop should not stop on network issues
4309         https://bugs.webkit.org/show_bug.cgi?id=193666
4310
4311         Reviewed by Lucas Forschler.
4312
4313         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4314         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
4315
4316 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4317
4318         [iOS] Multiple WKWebViewAutofillTests are flaky failures
4319         https://bugs.webkit.org/show_bug.cgi?id=189165
4320         <rdar://problem/47433765>
4321
4322         Reviewed by Tim Horton.
4323
4324         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
4325         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
4326         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
4327         process in sufficient to ensure that any previous action that blurred the focused element in the web process
4328         would make its way to the UI process by the time the layer tree commit is finished.
4329
4330         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
4331         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
4332         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
4333         will fail because it asks for -_autofillContext too early.
4334
4335         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
4336         is handled in the UI process.
4337
4338         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4339
4340         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4341         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4342         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
4343         input session.
4344
4345         (-[AutofillTestView textInputHasAutofillContext]):
4346
4347         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
4348
4349         * TestWebKitAPI/cocoa/TestWKWebView.h:
4350         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4351         (nextInputSessionChangeCount):
4352
4353         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
4354         This includes changing the focused element from one to another.
4355
4356         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
4357         (-[TestWKWebView didStartFormControlInteraction]):
4358         (-[TestWKWebView didEndFormControlInteraction]):
4359         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4360
4361         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This