Remove extra copy of 100x100-red.tga
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-07  Keith Rollin  <krollin@apple.com>
2
3         Remove extra copy of 100x100-red.tga
4         https://bugs.webkit.org/show_bug.cgi?id=194371
5         <rdar://problem/47873465>
6
7         Reviewed by Said Abou-Hallawa.
8
9         In order to help it pass its tests, Bug 194190 added a second copy of
10         the file 100x100-red.tga. However, it turns out that this additional
11         file wasn't actually needed, and that that sole previous copy was
12         sufficient. At the same time, this second copy -- which was copied to
13         the same location in the build output as the first copy -- now caused
14         XCBuild to complain because there were two production rules for the
15         same output file. Address this by removing the newly-added extra copy.
16
17         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
19
20 2019-02-07  Alex Christensen  <achristensen@webkit.org>
21
22         Deprecate WKBundlePageSetDefersLoading
23         https://bugs.webkit.org/show_bug.cgi?id=191394
24
25         Reviewed by Dean Jackson.
26
27         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
28         (WTR::TestRunner::setDefersLoading):
29
30 2019-02-07  Zalan Bujtas  <zalan@apple.com>
31
32         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
33         https://bugs.webkit.org/show_bug.cgi?id=194391
34
35         Reviewed by Antti Koivisto.
36
37         * LayoutReloaded/misc/LFC-passing-tests.txt:
38
39 2019-02-06  Keith Rollin  <krollin@apple.com>
40
41         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
42         https://bugs.webkit.org/show_bug.cgi?id=193975
43         <rdar://problem/47643306>
44
45         Reviewed by Tim Horton.
46
47         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
48         the Info.plist file into the bundle. This step is not necessary as the
49         implicit "bundle up all the build products into a framework" build
50         phase does this already. Having the Copy Bundle Resources phase do
51         this causes a conflict under XCBuild, which objects to two build
52         phases producing the same file (Info.plist). Address this by removing
53         Info.plist from the Copy Bundle Resources phase.
54
55         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
56
57 2019-02-06  Keith Rollin  <krollin@apple.com>
58
59         Really enable the automatic checking and regenerations of .xcfilelists during builds
60         https://bugs.webkit.org/show_bug.cgi?id=194357
61         <rdar://problem/47861231>
62
63         Reviewed by Chris Dumez.
64
65         Bug 194124 was supposed to enable the automatic checking and
66         regenerating of .xcfilelist files during the build. While related
67         changes were included in that patch, the change to actually enable the
68         operation somehow was omitted. This patch actually enables the
69         operation. The check-xcfilelist.sh scripts now check
70         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
71         from the checking.
72
73         * DumpRenderTree/Scripts/check-xcfilelists.sh:
74         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
75
76 2019-02-06  David Kilzer  <ddkilzer@apple.com>
77
78         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
79         <https://webkit.org/b/194286>
80         <rdar://problem/47815558>
81
82         Reviewed by Alexey Proskuryakov.
83
84         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
85         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
86         WKRetainPtr<> to avoid leaking the WKDataRef.
87
88 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
89
90         Unreviewed, fix a typo
91
92         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
93
94 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
95
96         [GTK][WPE] force libpsl build to use ICU in jhbuild
97         https://bugs.webkit.org/show_bug.cgi?id=194288
98
99         Reviewed by Carlos Garcia Campos.
100
101         * gtk/jhbuild.modules:
102         Require ICU for libpsl build in jhbuild, like done in WPE.
103
104 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
105
106         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
107         https://bugs.webkit.org/show_bug.cgi?id=194209
108
109         Reviewed by Carlos Garcia Campos.
110
111         Enhance TestCookieManager to ensure this doesn't happen again.
112
113         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
114         (testCookieManagerPersistentStorage):
115         (beforeAll):
116
117 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
120         https://bugs.webkit.org/show_bug.cgi?id=194324
121
122         Reviewed by Andy Estes.
123
124         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
125         part of the name is already implicit, since this is in testing code in TestOptions.
126
127         * WebKitTestRunner/TestController.cpp:
128         (WTR::TestController::generateContextConfiguration const):
129         (WTR::updateTestOptionsFromTestHeader):
130         * WebKitTestRunner/TestOptions.h:
131         (WTR::TestOptions::hasSameInitializationOptions const):
132
133 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
134
135         [ews-build] Allow * as platform for builders and workers
136         https://bugs.webkit.org/show_bug.cgi?id=188533
137
138         Reviewed by Lucas Forschler.
139
140         * BuildSlaveSupport/ews-build/loadConfig.py:
141         (checkWorkersAndBuildersForConsistency):
142
143 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
144
145         [ews-build] Add few bots to config.json
146         https://bugs.webkit.org/show_bug.cgi?id=194304
147
148         Reviewed by Lucas Forschler.
149
150         * BuildSlaveSupport/ews-build/config.json:
151
152 2019-02-05  Keith Rollin  <krollin@apple.com>
153
154         Enable the automatic checking and regenerations of .xcfilelists during builds
155         https://bugs.webkit.org/show_bug.cgi?id=194124
156         <rdar://problem/47721277>
157
158         Reviewed by Tim Horton.
159
160         Bug 193790 add a facility for checking -- during build time -- that
161         any needed .xcfilelist files are up-to-date and for updating them if
162         they are not. This facility was initially opt-in by setting
163         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
164         the process seemed robust. Its now time to enable this facility and
165         make it opt-out. If there is a need to disable this facility, set and
166         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
167         running `make` or `build-webkit`, or before running Xcode from the
168         command line.
169
170         Additionally, remove the step that generates a list of source files
171         going into the UnifiedSources build step. It's only necessarily to
172         specify Sources.txt and SourcesCocoa.txt as inputs.
173
174         * Scripts/generate-xcfilelists:
175
176 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
177
178         [GTK][WPE] force libpsl build to use ICU in jhbuild
179         https://bugs.webkit.org/show_bug.cgi?id=194288
180
181         Reviewed by Philippe Normand.
182
183         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
184         This can cause build failures if libidn is detected but libunistring is not available.
185
186         Make sure that ICU is used for runtime and builtin PSL data.
187
188         * gtk/jhbuild.modules:
189         * wpe/jhbuild.modules:
190
191 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews-app] Modified timestamp should be updated on updating data
194         https://bugs.webkit.org/show_bug.cgi?id=194295
195
196         Reviewed by Lucas Forschler.
197
198         * BuildSlaveSupport/ews-app/ews/models/build.py:
199         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
200         * BuildSlaveSupport/ews-app/ews/models/step.py:
201
202 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
203
204         Unreviewed, rolling out r240742.
205
206         Causes crashes on iOS simulator.
207
208         Reverted changeset:
209
210         "[iOS] Keyups for non-modifier keys identified as "Dead" when
211         not focused in a content-editable element"
212         https://bugs.webkit.org/show_bug.cgi?id=192824
213         https://trac.webkit.org/changeset/240742
214
215 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
216
217         run-webkit-tests emits message "...running None" when running tests
218         https://bugs.webkit.org/show_bug.cgi?id=194133
219         <rdar://problem/47724738>
220
221         Reviewed by Lucas Forschler.
222
223         * Scripts/webkitpy/xcode/device_type.py:
224         (DeviceType.__str__): Use both version mapping tables and use just the variant
225         name if no version name is available.
226         * Scripts/webkitpy/xcode/device_type_unittest.py:
227         (DeviceTypeTest):
228         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
229         an associated named.
230
231 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
232
233         [WPE] require python3-setuptools for meson build in jhbuild
234         https://bugs.webkit.org/show_bug.cgi?id=194287
235
236         Reviewed by Philippe Normand.
237
238         python3-setuptools is needed to build meson in jhbuild.
239         It is already required by the GTK port.
240
241         * wpe/install-dependencies:
242
243 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
244
245         [ews-app] Add method to save BuilderMapping to database
246         https://bugs.webkit.org/show_bug.cgi?id=194264
247
248         Reviewed by Lucas Forschler.
249
250         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
251         (BuilderMapping.__str__):
252         (BuilderMapping):
253         (BuilderMapping.save_mapping):
254         (BuilderMapping.update_mapping):
255         (BuilderMapping.get_existing_mapping):
256         (BuilderMapping.is_valid_mapping):
257
258 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
259
260         [ews-app] Add timestamp fields for BuilderMappings
261         https://bugs.webkit.org/show_bug.cgi?id=194266
262
263         Reviewed by Lucas Forschler.
264
265         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
266         (BuilderMapping):
267
268 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
269
270         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
271         https://bugs.webkit.org/show_bug.cgi?id=174816
272
273         Reviewed by Michael Catanzaro.
274
275         Add tests for webkit_uri_for_display().
276
277         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
278         (testURIForDisplayUnaffected):
279         (testURIForDisplayAffected):
280         (beforeAll):
281         (afterAll):
282         * TestWebKitAPI/glib/CMakeLists.txt:
283
284 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
285
286         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
287         https://bugs.webkit.org/show_bug.cgi?id=194158
288         <rdar://problem/47737268>
289
290         Rubber-stamped by Aakash Jain.
291
292         * Scripts/webkitpy/port/device_port.py:
293         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
294
295 2019-02-04  Said Abou-Hallawa  <said@apple.com>
296
297         [CG] Enable setAdditionalSupportedImageTypes for WK1
298         https://bugs.webkit.org/show_bug.cgi?id=194190
299
300         Reviewed by Tim Horton.
301
302         Add a test similar to the one under WebKit Cocoa but make it create a
303         WebView instead of a WKWebView.
304
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
307         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
308         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
309         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
310         (TestWebKitAPI::runTest):
311         (TestWebKitAPI::TEST):
312
313 2019-02-04  Zalan Bujtas  <zalan@apple.com>
314
315         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
316         https://bugs.webkit.org/show_bug.cgi?id=194168
317
318         Reviewed by Simon Fraser.
319
320         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
321
322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
323         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
324         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
325         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
326         (TEST):
327         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
328         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
329
330 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
331
332         REGRESSION (r237269): webkit-patch what-broke is broken 
333         https://bugs.webkit.org/show_bug.cgi?id=193025
334
335         Reviewed by Aakash Jain.
336
337         * Scripts/webkitpy/common/host.py:
338         (Host.buildbot):
339         (Host.bugzilla): Renamed to 'buildbot'.
340
341 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
342
343         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
344         https://bugs.webkit.org/show_bug.cgi?id=194207
345
346         Reviewed by Tim Horton.
347
348         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
349         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
350         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
351         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
352         start and delete forwards to remove the original attachment.
353
354         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
355         (TestWebKitAPI::TEST):
356
357 2019-02-04  Youenn Fablet  <youenn@apple.com>
358
359         Capture state should be managed consistently when doing process swapping
360         https://bugs.webkit.org/show_bug.cgi?id=194122
361         <rdar://problem/47609293>
362
363         Reviewed by Eric Carlson.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
366         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
367         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
368         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
369         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
370         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
371         (WTR::TestRunner::isDoingMediaCapture const):
372         * WebKitTestRunner/InjectedBundle/TestRunner.h:
373         * WebKitTestRunner/TestController.cpp:
374         (WTR::TestController::isDoingMediaCapture const):
375         * WebKitTestRunner/TestController.h:
376         * WebKitTestRunner/TestInvocation.cpp:
377         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
378         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
379         (WTR::TestController::isDoingMediaCapture const):
380
381 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
382
383         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
384         https://bugs.webkit.org/show_bug.cgi?id=194142
385
386         Reviewed by Ross Kirsling.
387
388         There three 'separator' variables in TestController.cpp. Renamed
389         it 'pathSeparator', and unified them.
390
391         * WebKitTestRunner/TestController.cpp:
392         (WTR::TestController::generateContextConfiguration const):
393         (WTR::createTestURL):
394         (WTR::TestController::platformAdjustContext):
395
396 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
397
398         Make setNeedsLayout on the root more explicitly about triggering its side-effects
399         https://bugs.webkit.org/show_bug.cgi?id=194198
400
401         Reviewed by Antti Koivisto.
402
403         No need to set the banner heights on navigation now, since Page stores them.
404
405         * MiniBrowser/mac/WK2BrowserWindowController.m:
406         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
407
408 2019-02-03  John Wilander  <wilander@apple.com>
409
410         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
411         https://bugs.webkit.org/show_bug.cgi?id=194104
412         <rdar://problem/47649991>
413
414         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
415
416         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
417         (TestWebKitAPI::TEST):
418             Changed numeric types from unsigned short to uint32_t.
419
420 2019-02-02  David Kilzer  <ddkilzer@apple.com>
421
422         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
423         <https://webkit.org/b/194178>
424         <rdar://problem/47753473>
425
426         Reviewed by Alexey Proskuryakov.
427
428         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
429         (WTR::uninstallFakeHelvetica): Pass nullptr into
430         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
431
432 2019-02-02  Zalan Bujtas  <zalan@apple.com>
433
434         [LFC] Initialize ICB's style with fixed width/height.
435         https://bugs.webkit.org/show_bug.cgi?id=194188
436
437         Reviewed by Antti Koivisto.
438
439         * LayoutReloaded/misc/LFC-passing-tests.txt:
440
441 2019-02-02  Zalan Bujtas  <zalan@apple.com>
442
443         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
444         https://bugs.webkit.org/show_bug.cgi?id=194185
445
446         Reviewed by Antti Koivisto.
447
448         * LayoutReloaded/misc/LFC-passing-tests.txt:
449
450 2018-12-16  Darin Adler  <darin@apple.com>
451
452         Convert additional String::format clients to alternative approaches
453         https://bugs.webkit.org/show_bug.cgi?id=192746
454
455         Reviewed by Alexey Proskuryakov.
456
457         * WebKitTestRunner/TestController.cpp:
458         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
459         as an intermediate in code that ultimately constructs a WTF::String.
460         (WTR::userMediaOriginHash): Use makeString.
461         (WTR::TestController::didNavigateWithNavigationData): More of the same.
462         (WTR::TestController::didPerformClientRedirect): Ditto.
463         (WTR::TestController::didPerformServerRedirect): Ditto.
464         (WTR::TestController::didUpdateHistoryTitle): Ditto.
465
466 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
467
468         [ews-build] Add unit test to verify builder keys
469         https://bugs.webkit.org/show_bug.cgi?id=194152
470
471         Reviewed by Lucas Forschler.
472
473         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
474         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
475
476 2019-02-01  Zalan Bujtas  <zalan@apple.com>
477
478         [LFC] Expand tests coverage (12 new tests -> 787)
479
480         Unreviewed test gardening.
481
482         * LayoutReloaded/misc/LFC-passing-tests.txt:
483
484 2019-02-01  Zalan Bujtas  <zalan@apple.com>
485
486         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
487         https://bugs.webkit.org/show_bug.cgi?id=194163
488
489         Reviewed by Simon Fraser.
490
491         775
492
493         * LayoutReloaded/misc/LFC-passing-tests.txt:
494
495 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
498         https://bugs.webkit.org/show_bug.cgi?id=194140
499         <rdar://problem/47728098>
500
501         Reviewed by Tim Horton.
502
503         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
505         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
506
507         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
508         test to induce an IPC deadlock when presenting a modal alert during touch start.
509
510         * WebKitTestRunner/InjectedBundle/TestRunner.h:
511         * WebKitTestRunner/TestController.cpp:
512         (WTR::runJavaScriptAlert):
513
514         Add a client callback function for running JavaScript alerts.
515
516         (WTR::TestController::createOtherPage):
517         (WTR::TestController::generateContextConfiguration const):
518
519         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
520         the fix in this patch.
521
522         (WTR::TestController::createWebViewWithOptions):
523
524         Plumb TestOptions to generateContextConfiguration.
525
526         (WTR::TestController::resetPreferencesToConsistentValues):
527         (WTR::TestController::resetStateToConsistentValues):
528         (WTR::updateTestOptionsFromTestHeader):
529         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
530         (WTR::TestController::handleJavaScriptAlert):
531         * WebKitTestRunner/TestController.h:
532         * WebKitTestRunner/TestInvocation.cpp:
533         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
534         * WebKitTestRunner/TestOptions.h:
535         (WTR::TestOptions::hasSameInitializationOptions const):
536
537 2019-02-01  Chris Dumez  <cdumez@apple.com>
538
539         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
540         https://bugs.webkit.org/show_bug.cgi?id=193740
541         <rdar://problem/47527267>
542
543         Reviewed by Alex Christensen.
544
545         Add API test coverage.
546
547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
548
549 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
550
551         [ews-app] Add display name field to BuilderMapping model
552         https://bugs.webkit.org/show_bug.cgi?id=194153
553
554         Reviewed by Lucas Forschler.
555
556         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
557         (BuilderMapping):
558
559 2019-02-01  Youenn Fablet  <youenn@apple.com>
560
561         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
562         https://bugs.webkit.org/show_bug.cgi?id=194155
563
564         Reviewed by Eric Carlson.
565
566         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
567         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
568         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
569
570 2019-02-01  Zalan Bujtas  <zalan@apple.com>
571
572         [LFC] Adjust replaced element's intrinsic ratio
573         https://bugs.webkit.org/show_bug.cgi?id=194154
574
575         Reviewed by Antti Koivisto.
576
577         761
578
579         * LayoutReloaded/misc/LFC-passing-tests.txt:
580
581 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
582
583         [WPE] Show test results in minibrowser
584         https://bugs.webkit.org/show_bug.cgi?id=194150
585
586         Reviewed by Žan Doberšek.
587
588         * Scripts/webkitpy/port/wpe.py:
589         (WPEPort.show_results_html_file):
590
591 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         [WPE] MiniBrowser: add ky bindings for back/forward navigation
594         https://bugs.webkit.org/show_bug.cgi?id=194151
595
596         Reviewed by Žan Doberšek.
597
598         ALT + <- go back
599         ALT + -> go forward
600
601         * MiniBrowser/wpe/main.cpp:
602         (main):
603
604 2019-02-01  Zalan Bujtas  <zalan@apple.com>
605
606         [LFC] Set intrinsic size on Layout::Replaced
607         https://bugs.webkit.org/show_bug.cgi?id=194139
608
609         Reviewed by Antti Koivisto.
610
611         744
612
613         * LayoutReloaded/misc/LFC-passing-tests.txt:
614
615 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
618         https://bugs.webkit.org/show_bug.cgi?id=194146
619
620         Reviewed by Xabier Rodriguez-Calvar.
621
622         It allows to open relative paths.
623
624         * MiniBrowser/wpe/main.cpp:
625         (main):
626
627 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
628
629         Update flakiness dashboard configuration after recent queue changes
630         https://bugs.webkit.org/show_bug.cgi?id=194127
631
632         Rubber-stamped by Aakash Jain.
633
634         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
635
636         * TestResultServer/static-dashboards/builders.jsonp:
637
638 2019-01-31  Youenn Fablet  <youenn@apple.com>
639
640         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
641         https://bugs.webkit.org/show_bug.cgi?id=194106
642         <rdar://problem/47676333>
643
644         Reviewed by Ryosuke Niwa.
645
646         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
647         (TestWebKitAPI::didFinishNavigation):
648         (TestWebKitAPI::TEST):
649         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
650
651 2019-01-31  Chris Dumez  <cdumez@apple.com>
652
653         Page zoom level is lost after a process swap or a crash
654         https://bugs.webkit.org/show_bug.cgi?id=194105
655         <rdar://problem/47610781>
656
657         Reviewed by Alex Christensen.
658
659         Add API test coverage.
660
661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
662         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
663
664 2019-01-31  Alex Christensen  <achristensen@webkit.org>
665
666         Revert r238819 which is unneeded and caused a performance regression.
667         https://bugs.webkit.org/show_bug.cgi?id=192272
668         <rdar://problem/46664625>
669
670         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
671         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
672         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
673
674 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
675
676         Formalize WebKitAdditions mechanism of LoadOptimizer
677         https://bugs.webkit.org/show_bug.cgi?id=193886
678         <rdar://problem/47696809>
679
680         Reviewed by Brent Fulgham.
681
682         * MiniBrowser/MiniBrowser.entitlements:
683         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
684
685 2019-01-31  Zalan Bujtas  <zalan@apple.com>
686
687         [LFC] Margin before/after/start/end initial value is 0 and not auto.
688         https://bugs.webkit.org/show_bug.cgi?id=194090
689
690         Reviewed by Antti Koivisto.
691
692         * LayoutReloaded/misc/LFC-passing-tests.txt:
693
694 2019-01-31  Zalan Bujtas  <zalan@apple.com>
695
696         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
697         https://bugs.webkit.org/show_bug.cgi?id=194074
698
699         Reviewed by Antti Koivisto.
700
701         * LayoutReloaded/misc/LFC-passing-tests.txt:
702
703 2019-01-31  Zalan Bujtas  <zalan@apple.com>
704
705         [LFC][BFC] Add support for block level replaced box.
706         https://bugs.webkit.org/show_bug.cgi?id=194071
707
708         Reviewed by Antti Koivisto.
709
710         * LayoutReloaded/misc/LFC-passing-tests.txt:
711
712 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
713
714         Fix WebKitTestRunner's testPath with Windows full paths
715         https://bugs.webkit.org/show_bug.cgi?id=194012
716
717         Reviewed by Alex Christensen.
718
719         updateTestOptionsFromTestHeader failed to open test files because
720         testPath returned wrong file paths. It returned a path "/C:/..."
721         if a URL "file:///C:/..." was given.
722
723         * WebKitTestRunner/TestController.cpp:
724         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
725
726 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [WPE] Bump font related dependencies to match the GTK+ port
729         https://bugs.webkit.org/show_bug.cgi?id=194017
730
731         Reviewed by Žan Doberšek.
732
733         * wpe/jhbuild.modules:
734         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
735         * wpe/patches/icudata-stdlibs.patch: Added.
736
737 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
738
739         Enable swipe tests on iOS
740         https://bugs.webkit.org/show_bug.cgi?id=194076
741
742         Reviewed by Geoffrey Garen.
743
744         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
745         it causes a debug assertion failure in runUIScript.
746
747         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
748         (WTR::UIScriptController::beginBackSwipe):
749         (WTR::UIScriptController::completeBackSwipe):
750
751 2019-01-30  Keith Rollin  <krollin@apple.com>
752
753         Use correct printf format specifier
754         https://bugs.webkit.org/show_bug.cgi?id=194062
755         <rdar://problem/47686167>
756
757         Reviewed by Alexey Proskuryakov.
758
759         LayoutTestSpellChecker.mm is trying to format a variable of type
760         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
761         actually an unsigned long long. Fix this by formatting with %llu.
762
763         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
764         (-[LayoutTestTextCheckingResult description]):
765
766 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
767
768         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
769         https://bugs.webkit.org/show_bug.cgi?id=193979
770
771         Reviewed by Wenson Hsieh.
772
773         Fix the test for iOS. Make the test work with iOS UA string.
774
775         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
776
777 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
778
779         Replace High Sierra LLINT CLoop bot due to hardware failure
780         https://bugs.webkit.org/show_bug.cgi?id=194066
781
782         Reviewed by Aakash Jain.
783
784         * BuildSlaveSupport/build.webkit.org-config/config.json:
785
786 2019-01-30  Keith Rollin  <krollin@apple.com>
787
788         [NSDragItem init] is unavailable
789         https://bugs.webkit.org/show_bug.cgi?id=194059
790         <rdar://problem/47685715>
791
792         Reviewed by Wenson Hsieh.
793
794         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
795         DumpRenderTree and TestWebKitAPI, which both try to create an
796         NSDragItem in a manner that invokes this method. Address this by using
797         -initWithPasteboardWriter instead.
798
799         Note that the parameter passed to initWithPasteboardWriter is likely
800         incorrect. In both cases, the object passed does not conform to
801         NSPasteboardWriting. However, with this fix, we're no worse off than
802         before, and can now perform builds with newer compilers and SDKs until
803         a real fix can be crafted. That work is tracked in
804         https://bugs.webkit.org/show_bug.cgi?id=194060
805
806         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
807         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
808         * TestWebKitAPI/mac/TestDraggingInfo.mm:
809         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
810
811 2019-01-30  Daniel Bates  <dabates@apple.com>
812
813         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
814         https://bugs.webkit.org/show_bug.cgi?id=192824
815         <rdar://problem/47100332>
816
817         Reviewed by Wenson Hsieh.
818
819         Fix a bug where the wrong usage code was used for F13 thru F24.
820
821         * WebKitTestRunner/ios/HIDEventGenerator.mm:
822         (keyCodeForDOMFunctionKey):
823
824 2019-01-30  Chris Dumez  <cdumez@apple.com>
825
826         Regression(PSON) Load hang can occur on history navigation
827         https://bugs.webkit.org/show_bug.cgi?id=194030
828         <rdar://problem/47656939>
829
830         Reviewed by Antti Koivisto.
831
832         Add API test coverage.
833
834         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
835
836 2019-01-30  Zalan Bujtas  <zalan@apple.com>
837
838         [LFC] Expand tests coverage.
839
840         Unreviewed test gardening.
841
842         * LayoutReloaded/misc/LFC-passing-tests.txt:
843
844 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
845
846         [Flatpak] Add openjpeg support
847         https://bugs.webkit.org/show_bug.cgi?id=194019
848
849         Reviewed by Michael Catanzaro.
850
851         * flatpak/org.webkit.CommonModules.yaml:
852
853 2019-01-30  Commit Queue  <commit-queue@webkit.org>
854
855         Unreviewed, rolling out r240708.
856         https://bugs.webkit.org/show_bug.cgi?id=194022
857
858         It broke WPE build (Requested by KaL on #webkit).
859
860         Reverted changeset:
861
862         "[WPE] Bump font related dependencies to match the GTK+ port"
863         https://bugs.webkit.org/show_bug.cgi?id=194017
864         https://trac.webkit.org/changeset/240708
865
866 2019-01-30  Zalan Bujtas  <zalan@apple.com>
867
868         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
869         https://bugs.webkit.org/show_bug.cgi?id=194001
870
871         Reviewed by Antti Koivisto.
872
873         * LayoutReloaded/misc/LFC-passing-tests.txt:
874
875 2019-01-30  Zalan Bujtas  <zalan@apple.com>
876
877         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
878         https://bugs.webkit.org/show_bug.cgi?id=194020
879
880         Reviewed by Antti Koivisto.
881
882         * LayoutReloaded/misc/LFC-passing-tests.txt:
883
884 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
885
886         AX: Support color well on iOS
887         https://bugs.webkit.org/show_bug.cgi?id=194010
888
889         Reviewed by Joanmarie Diggs.
890
891         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
892         (WTR::AccessibilityUIElement::stringAttributeValue):
893
894 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
895
896         [WPE] Bump font related dependencies to match the GTK+ port
897         https://bugs.webkit.org/show_bug.cgi?id=194017
898
899         Reviewed by Žan Doberšek.
900
901         * wpe/jhbuild.modules:
902         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
903         * wpe/patches/icudata-stdlibs.patch: Added.
904
905 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
906
907         [Mac] Update window scale API usage
908         https://bugs.webkit.org/show_bug.cgi?id=193991
909         rdar://problem/47614795
910
911         Reviewed by Tim Horton.
912
913         * DumpRenderTree/mac/DumpRenderTree.mm:
914         (changeWindowScaleIfNeeded):
915         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
916         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
917         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
918
919 2019-01-29  Chris Dumez  <cdumez@apple.com>
920
921         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
922         https://bugs.webkit.org/show_bug.cgi?id=193977
923         <rdar://problem/47643716>
924
925         Reviewed by Geoff Garen.
926
927         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
928         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
929         to the previous provisional committing *before* we make the last load. 
930
931         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
932
933 2019-01-29  Youenn Fablet  <youenn@apple.com>
934
935         Adopt new SPI to evaluate server certificate trust
936         https://bugs.webkit.org/show_bug.cgi?id=193355
937
938         Reviewed by Alex Christensen.
939
940         Add infrastructure to handle HTTPS server trust evaluation testing.
941
942         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
943         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
944         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
945         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
946         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
948         * WebKitTestRunner/TestController.cpp:
949         (WTR::TestController::resetPreferencesToConsistentValues):
950         (WTR::TestController::didReceiveAuthenticationChallenge):
951         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
952         * WebKitTestRunner/TestController.h:
953         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
954         * WebKitTestRunner/TestInvocation.cpp:
955         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
956         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
957         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
958
959 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
960
961         [ews-build] Add build step to print bot Configuration
962         https://bugs.webkit.org/show_bug.cgi?id=193887
963
964         Reviewed by Lucas Forschler.
965
966         * BuildSlaveSupport/ews-build/steps.py:
967         (PrintConfiguration): Build step to print configuration.
968         * BuildSlaveSupport/ews-build/factories.py:
969
970 2019-01-29  Chris Dumez  <cdumez@apple.com>
971
972         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
973         https://bugs.webkit.org/show_bug.cgi?id=193967
974         <rdar://problem/47635348>
975
976         Reviewed by Alex Christensen.
977
978         Add API test coverage.
979
980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
981         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
982
983 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
984
985         [ews-app] Handle incoming results data
986         https://bugs.webkit.org/show_bug.cgi?id=193973
987
988         Reviewed by Lucas Forschler.
989
990         * BuildSlaveSupport/ews-app/ews/views/results.py:
991
992 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
993
994         [ews-app] Make the results url generic
995         https://bugs.webkit.org/show_bug.cgi?id=193928
996
997         Reviewed by Lucas Forschler.
998
999         * BuildSlaveSupport/ews-app/ews/urls.py:
1000
1001 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1002
1003         [ews-build] Configure buildbot to send events to ews-app
1004         https://bugs.webkit.org/show_bug.cgi?id=193968
1005
1006         Reviewed by Lucas Forschler.
1007
1008         * BuildSlaveSupport/ews-build/events.py: Added.
1009         * BuildSlaveSupport/ews-build/master.cfg:
1010
1011 2019-01-29  Keith Rollin  <krollin@apple.com>
1012
1013         Add .xcfilelists to Run Script build phases
1014         https://bugs.webkit.org/show_bug.cgi?id=193792
1015         <rdar://problem/47201785>
1016
1017         Reviewed by Alex Christensen.
1018
1019         As part of supporting XCBuild, update the necessary Run Script build
1020         phases in their Xcode projects to refer to their associated
1021         .xcfilelist files.
1022
1023         Note that the addition of these files bumps the Xcode project version
1024         number to something that's Xcode 10 compatible. This change means that
1025         older versions of the Xcode IDE can't read these projects. Nor can it
1026         fully load workspaces that refer to these projects (the updated
1027         projects are shown as non-expandable placeholders). `xcodebuild` can
1028         still build these projects; it's just that the IDE can't open them.
1029
1030         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1032
1033 2019-01-29  John Wilander  <wilander@apple.com>
1034
1035         Add data abstraction and validation for Ad Click Attribution
1036         https://bugs.webkit.org/show_bug.cgi?id=193916
1037         <rdar://problem/47603481>
1038
1039         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1040
1041         Ad click attribution has two steps. First, the storage of an ad
1042         campaign ID for a click that takes the user to a destination
1043         site. Second, a conversion on the destination site that can be
1044         attributed to the ad click.
1045
1046         This patch adds a class that represents a request for ad click
1047         attribution. Validation makes sure that the bits of entropy
1048         reported through this mechanism is limited.
1049
1050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1051         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1052         (TestWebKitAPI::TEST):
1053
1054 2019-01-29  Chris Dumez  <cdumez@apple.com>
1055
1056         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1057         https://bugs.webkit.org/show_bug.cgi?id=193932
1058         <rdar://problem/47598947>
1059
1060         Reviewed by Brady Eidson.
1061
1062         Add API test coverage.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1065
1066 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1067
1068         Adding new passing LFC tests.
1069
1070         Unreviewed test gardening.
1071
1072         * LayoutReloaded/misc/LFC-passing-tests.txt:
1073
1074 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1075
1076         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1077         https://bugs.webkit.org/show_bug.cgi?id=193964
1078
1079         Reviewed by Antti Koivisto.
1080
1081         * LayoutReloaded/misc/LFC-passing-tests.txt:
1082
1083 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1084
1085         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1086         https://bugs.webkit.org/show_bug.cgi?id=193954
1087
1088         Reviewed by Antti Koivisto.
1089
1090         * LayoutReloaded/misc/LFC-passing-tests.txt:
1091
1092 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1093
1094         WebDriver: add support for running subtests
1095         https://bugs.webkit.org/show_bug.cgi?id=193904
1096
1097         Reviewed by Michael Catanzaro.
1098
1099         pytest already supports it by passing test.py::subtest, so we can do the same.
1100
1101         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1102         (get_item_name): Made this global.
1103         (CollectRecorder.__init__): Receive the parameter to ignore.
1104         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1105         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1106         (collect): Add parameter to ignore.
1107         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1108         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1109         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1110         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1111         (WebDriverTestRunnerSelenium.run): Ditto.
1112         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1113         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1114         (WebDriverTestRunnerW3C.run): Ditto.
1115
1116 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1117
1118         User agent string override for navigator.userAgent should be site specific quirks
1119         https://bugs.webkit.org/show_bug.cgi?id=193950
1120
1121         Reviewed by Brent Fulgham.
1122
1123         Updated per the _WKWebsitePolicies rename.
1124
1125         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1126         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1127
1128 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1129
1130         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1131         https://bugs.webkit.org/show_bug.cgi?id=193941
1132
1133         Reviewed by Alex Christensen.
1134
1135         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1136         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1137         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1138         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1139         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1140         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1141         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1142         * TestWebKitAPI/Tests/WTF/Time.cpp:
1143         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1144         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1145         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1146         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1147
1148 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1149
1150         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1151
1152         * Scripts/webkitpy/common/config/contributors.json:
1153
1154 2019-01-28  Andy Estes  <aestes@apple.com>
1155
1156         [watchOS] Enable Parental Controls content filtering
1157         https://bugs.webkit.org/show_bug.cgi?id=193939
1158         <rdar://problem/46641912>
1159
1160         Reviewed by Ryosuke Niwa.
1161
1162         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1163
1164 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1165
1166         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1167         <https://webkit.org/b/193884>
1168
1169         Reviewed by Jiewen Tan.
1170
1171         * Scripts/webkitpy/style/checkers/cpp.py:
1172         (check_language): Add LocalAuthentication to
1173         `frameworks_with_soft_links`.
1174
1175 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1176
1177         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1178         https://bugs.webkit.org/show_bug.cgi?id=193891
1179
1180         Reviewed by Ross Kirsling.
1181
1182         There were three problems in window sizes of WebView and the host window.
1183         1. The sizes of pixel image output were incorrect.
1184         2. The host window is going to appear after window.resize was invoked.
1185         3. window.resize resized only the host window, not WebView.
1186
1187         This change solves them with a following approach.
1188         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1189         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1190            as well as DumpRenderTree in order to match the client area and the window area.
1191         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1192         d. PlatformWebView::setWindowFrame changes both window sizes.
1193         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1194
1195         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1196         (WTR::PlatformWebView::PlatformWebView): Create the host window
1197         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1198         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1199         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1200
1201 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Add method to save Step data to database
1204         https://bugs.webkit.org/show_bug.cgi?id=193890
1205
1206         Reviewed by Lucas Forschler.
1207
1208         * BuildSlaveSupport/ews-app/ews/models/step.py:
1209         (Step.save_step): Method to save step data.
1210         (Step.update_step): Method to update step data.
1211         (Step.get_existing_step): Method to fetch existing step from database.
1212         (Step.is_valid_result): Method to validate valid step result.
1213
1214 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1215
1216         [ews-app] Add method to save Build data to database
1217         https://bugs.webkit.org/show_bug.cgi?id=193735
1218
1219         Reviewed by Lucas Forschler.
1220
1221         * BuildSlaveSupport/ews-app/ews/models/build.py:
1222         (Build.save_build): Method to save build information to database.
1223         (Build.get_existing_build): Method to fetch existing build from database.
1224         (Build.is_valid_result): Method to validate build result.
1225         * BuildSlaveSupport/ews-app/ews/common/util.py:
1226         (is_valid_int_id): Method to validate valid id.
1227
1228 2019-01-28  Chris Dumez  <cdumez@apple.com>
1229
1230         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1231         https://bugs.webkit.org/show_bug.cgi?id=193915
1232         <rdar://problem/47560907>
1233
1234         Reviewed by Alex Christensen.
1235
1236         Add API test coverage.
1237
1238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1239
1240 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1241
1242         [ews-app] Rename id variables
1243         https://bugs.webkit.org/show_bug.cgi?id=193883
1244
1245         Reviewed by Lucas Forschler.
1246
1247         * BuildSlaveSupport/ews-app/ews/models/build.py:
1248         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1249         * BuildSlaveSupport/ews-app/ews/models/step.py:
1250         * BuildSlaveSupport/ews-app/ews/urls.py:
1251         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1252         * BuildSlaveSupport/ews-app/ews/views/results.py:
1253         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1254
1255 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1256
1257         [ews-app] Allow certain fields to be empty
1258         https://bugs.webkit.org/show_bug.cgi?id=193892
1259
1260         Reviewed by Lucas Forschler.
1261
1262         * BuildSlaveSupport/ews-app/ews/models/build.py:
1263         * BuildSlaveSupport/ews-app/ews/models/step.py:
1264
1265 2019-01-28  Rob Buis  <rbuis@igalia.com>
1266
1267         Update MIME type parser
1268         https://bugs.webkit.org/show_bug.cgi?id=180526
1269
1270         Reviewed by Frédéric Wang.
1271
1272         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1273         (TestWebKitAPI::TEST):
1274
1275 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1276
1277         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1278         https://bugs.webkit.org/show_bug.cgi?id=193896
1279
1280         Reviewed by Antti Koivisto.
1281
1282         * LayoutReloaded/misc/LFC-passing-tests.txt:
1283
1284 2018-12-15  Darin Adler  <darin@apple.com>
1285
1286         Replace many uses of String::format with more type-safe alternatives
1287         https://bugs.webkit.org/show_bug.cgi?id=192742
1288
1289         Reviewed by Mark Lam.
1290
1291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1292         (WTR::cacheTestRunnerCallback): Use makeString.
1293         * WebKitTestRunner/TestController.cpp:
1294         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1295         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1296
1297 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1298
1299         Use a load optimizer for some sites
1300         https://bugs.webkit.org/show_bug.cgi?id=193881
1301         <rdar://problem/46325455>
1302
1303         Reviewed by Brent Fulgham.
1304
1305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1306         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1307
1308 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1309
1310         AX: Introduce a static accessibility tree
1311         https://bugs.webkit.org/show_bug.cgi?id=193348
1312         <rdar://problem/47203295>
1313
1314         Reviewed by Ryosuke Niwa.
1315
1316         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1317
1318 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1319
1320         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1321         https://bugs.webkit.org/show_bug.cgi?id=193867
1322
1323         Reviewed by Antti Koivisto.
1324
1325         * LayoutReloaded/misc/LFC-passing-tests.txt:
1326
1327 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1328
1329         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1330         https://bugs.webkit.org/show_bug.cgi?id=193865
1331
1332         Reviewed by Antti Koivisto.
1333
1334         * LayoutReloaded/misc/LFC-passing-tests.txt:
1335
1336 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1337
1338         Need a mechanism to override navigator.userAgent
1339         https://bugs.webkit.org/show_bug.cgi?id=193762
1340         <rdar://problem/47504939>
1341
1342         Reviewed by Brent Fulgham.
1343
1344         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1347         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1348         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1349
1350 2019-01-25  Dean Jackson  <dino@apple.com>
1351
1352         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1353         https://bugs.webkit.org/show_bug.cgi?id=193831
1354         <rdar://problem/47399263>
1355
1356         Reviewed by Chris Dumez.
1357
1358         Two new tests that exercise cross-origin and same-origin System
1359         Previews.
1360
1361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1362
1363 2019-01-25  Keith Rollin  <krollin@apple.com>
1364
1365         Update Xcode projects with "Check .xcfilelists" build phase
1366         https://bugs.webkit.org/show_bug.cgi?id=193790
1367         <rdar://problem/47201374>
1368
1369         Reviewed by Alex Christensen.
1370
1371         Support for XCBuild includes specifying inputs and outputs to various
1372         Run Script build phases. These inputs and outputs are specified as
1373         .xcfilelist files. Once created, these .xcfilelist files need to be
1374         kept up-to-date. In order to check that they are up-to-date or not,
1375         add an Xcode build step that invokes an external script that performs
1376         the checking. If the .xcfilelists are found to be out-of-date, update
1377         them, halt the build, and instruct the developer to restart the build
1378         with up-to-date files.
1379
1380         At this time, the checking and regenerating is performed only if the
1381         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1382         who want to use this facility can set this variable and test out the
1383         checking/regenerating. Once it seems like there are no egregious
1384         issues that upset a developer's workflow, we'll unconditionally enable
1385         this facility.
1386
1387         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1388         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1389         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1390         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1391
1392 2019-01-25  Keith Rollin  <krollin@apple.com>
1393
1394         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1395         https://bugs.webkit.org/show_bug.cgi?id=193781
1396         <rdar://problem/47201153>
1397
1398         Reviewed by Alex Christensen.
1399
1400         Part of generating the .xcfilelists used as part of adopting XCBuild
1401         includes running `make DerivedSources.make` from a standalone script.
1402         It’s important for this invocation to have the same environment as
1403         when the actual build invokes `make DerivedSources.make`. If the
1404         environments are different, then the two invocations will provide
1405         different results. In order to get the same environment in the
1406         standalone script, have the script launch xcodebuild targeting the
1407         "Apply Configuration to XCFileLists" build target, which will then
1408         re-invoke our standalone script. The script is now running again, this
1409         time in an environment with all workspace, project, target, xcconfig
1410         and other environment variables established.
1411
1412         The "Apply Configuration to XCFileLists" build target accomplishes
1413         this task via a small embedded shell script that consists only of:
1414
1415             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1416
1417         The process that invokes "Apply Configuration to XCFileLists" first
1418         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1419         evaluated and exports it into the shell environment. When xcodebuild
1420         is invoked, it inherits the value of this variable and can `eval` the
1421         contents of that variable. Our external standalone script can then set
1422         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1423         of command-line parameters needed to restart itself in the appropriate
1424         state.
1425
1426         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1427         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1428
1429 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1430
1431         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1432         https://bugs.webkit.org/show_bug.cgi?id=193802
1433         <rdar://problem/46010580>
1434
1435         Reviewed by Andy Estes.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1438         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1439         (TEST):
1440
1441 2019-01-25  Daniel Bates  <dabates@apple.com>
1442
1443         [iOS] uiController.keyDown() does not translate Control modified key
1444         https://bugs.webkit.org/show_bug.cgi?id=192898
1445
1446         Reviewed by Wenson Hsieh.
1447
1448         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1449         key translation, as applicable. Among other cases, key translation occurs when performing
1450         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1451         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1452         human pressing down and releasing key(s) using a hardware keyboard.
1453
1454         * WebKitTestRunner/ios/HIDEventGenerator.h:
1455         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1456         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1457
1458         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1459         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1460         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1461         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1462         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1463         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1464         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1465         (-[HIDEventGenerator longPress:completionBlock:]):
1466         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1467         Update code for above renaming.
1468
1469         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1470         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1471
1472         (-[HIDEventGenerator keyDown:]): Added.
1473         (-[HIDEventGenerator keyUp:]): Added.
1474         (-[HIDEventGenerator keyPress:completionBlock:]):
1475         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1476         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1477         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1478         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1479         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1480         (WTR::parseModifier): Deleted.
1481
1482 2019-01-25  Keith Rollin  <krollin@apple.com>
1483
1484         Complete the implementation of generate-xcfilelists
1485         https://bugs.webkit.org/show_bug.cgi?id=193782
1486
1487         Reviewed by Alex Christensen.
1488
1489         A preliminary version of generate-xcfilelists was added in r238008.
1490         This patch updates that script in order to:
1491
1492         - Support checking of .xcfilelists
1493         - Perform better execution of `make DerivedSources.make` by
1494           relaunching generate-xcfilelists under xcodebuild
1495         - Support incremental generation and checking of .xcfilelists
1496         - Support supplementary .xcfilelists files from WebKitAdditions
1497         - Support being wrapped by parallel version of generate-xcfilelists in
1498           Internal that adds support for (re)generating WebKit projects in
1499           that repo.
1500         - Support builds that have been performed in WebKitBuild as well as
1501           ~/Library/Developer/code/DerivedData
1502         - Increase robustness and debugging facilities.
1503
1504         * Scripts/generate-xcfilelists:
1505
1506 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1507
1508         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1509         https://bugs.webkit.org/show_bug.cgi?id=193297
1510         <rdar://problem/47158841>
1511
1512         Unreviewed test case fix.
1513
1514         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1515         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1516
1517         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1518         (TEST):
1519
1520 2019-01-25  Keith Rollin  <krollin@apple.com>
1521
1522         Update existing .xcfilelists
1523         https://bugs.webkit.org/show_bug.cgi?id=193791
1524         <rdar://problem/47201706>
1525
1526         Reviewed by Alex Christensen.
1527
1528         Many .xcfilelist files were added in r238824 in order to support
1529         XCBuild. Update these with recent changes to the set of build files
1530         and with the current generate-xcfilelist script.
1531
1532         * DumpRenderTree/DerivedSources-input.xcfilelist:
1533         * DumpRenderTree/DerivedSources-output.xcfilelist:
1534         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1535         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1536
1537 2019-01-25  Keith Rollin  <krollin@apple.com>
1538
1539         Fix missing dependencies in extract-dependencies-from-makefile
1540         https://bugs.webkit.org/show_bug.cgi?id=193783
1541         <rdar://problem/47201571>
1542
1543         Reviewed by Alex Christensen.
1544
1545         The extract-dependencies-from-makefile script generates .xcfilelists
1546         for XCBuild by invoking a makefile in --debug mode, parsing the
1547         dependency information in the output, and extracting information
1548         regarding targets and dependents. However, the way `make` emits this
1549         dependency information is not rigorous, and so we need to determine
1550         what lines to look for and parse by trial and error. This approach
1551         didn't coriginally atch all the information we needed to collect, so
1552         update the script to look for the additional lines we now know to look
1553         for.
1554
1555         * Scripts/extract-dependencies-from-makefile:
1556         (Parser):
1557         (Parser.addTarget):
1558         (Parser.addPrereq):
1559         (Parser.doParse):
1560
1561 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1562
1563         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1564         https://bugs.webkit.org/show_bug.cgi?id=193297
1565         <rdar://problem/47158841>
1566
1567         Reviewed by Alex Christensen.
1568
1569         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1570             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1572         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1573         activating the message used to trigger the callback when it is set.
1574
1575 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1576
1577         WKWebView.goBack should reload if there is a safe browsing warning
1578         https://bugs.webkit.org/show_bug.cgi?id=193805
1579         <rdar://problem/46908216>
1580
1581         Reviewed by Geoff Garen.
1582
1583         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1584         (+[Simple3LookupContext sharedLookupContext]):
1585         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1586         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1587         (TEST):
1588
1589 2019-01-25  Chris Dumez  <cdumez@apple.com>
1590
1591         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1592         https://bugs.webkit.org/show_bug.cgi?id=193788
1593         <rdar://problem/47531231>
1594
1595         Reviewed by Alex Christensen.
1596
1597         Add API test coverage.
1598
1599         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1600         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1601
1602 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1603
1604         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1605         https://bugs.webkit.org/show_bug.cgi?id=193771
1606
1607         Unreviewed infrastructure fix.
1608
1609         * Scripts/webkitpy/port/darwin.py:
1610         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1611
1612 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1613
1614         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1615
1616 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1617
1618         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1619
1620         * Scripts/webkitpy/common/config/contributors.json:
1621
1622 2019-01-25  Chris Dumez  <cdumez@apple.com>
1623
1624         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1625         https://bugs.webkit.org/show_bug.cgi?id=193779
1626         <rdar://problem/46170903>
1627
1628         Reviewed by Antti Koivisto.
1629
1630         Add API test that quickly navigates forward to a previous process without waiting for it to
1631         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1632         the process' previous page when reconnecting the it for the forward navigation.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1635
1636 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1637
1638         Need a way for JavaScript (or bundle) code to participate in undo
1639         https://bugs.webkit.org/show_bug.cgi?id=190009
1640         <rdar://problem/44807048>
1641
1642         Reviewed by Ryosuke Niwa.
1643
1644         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1645         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1646
1647         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1648         (WTR::UIScriptController::lastUndoLabel const):
1649         (WTR::UIScriptController::firstRedoLabel const):
1650         (WTR::UIScriptController::platformUndoManager const):
1651         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1652         (WTR::UIScriptController::lastUndoLabel const):
1653         (WTR::UIScriptController::firstRedoLabel const):
1654         (WTR::UIScriptController::platformUndoManager const):
1655         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1656         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1657         (WTR::UIScriptController::lastUndoLabel const):
1658         (WTR::UIScriptController::firstRedoLabel const):
1659         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1660         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1661         (WTR::UIScriptController::lastUndoLabel const):
1662         (WTR::UIScriptController::firstRedoLabel const):
1663         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1664         (WTR::UIScriptController::platformUndoManager const):
1665         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1666         (WTR::UIScriptController::platformUndoManager const):
1667
1668 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1669
1670         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1671         https://bugs.webkit.org/show_bug.cgi?id=193824
1672
1673         Reviewed by Antti Koivisto.
1674
1675         * LayoutReloaded/misc/LFC-passing-tests.txt:
1676
1677 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1678
1679         Update macOS JSC bot configurations
1680         https://bugs.webkit.org/show_bug.cgi?id=193739
1681
1682         Reviewed by Alexey Proskuryakov.
1683
1684         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1686         (BubbleQueueServer): Move JSC EWS to Mojave section.
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1688         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1689         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1690
1691 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1692
1693         [Win][WebKitTestRunner] Implement EventSenderProxy
1694         https://bugs.webkit.org/show_bug.cgi?id=193755
1695
1696         Reviewed by Don Olmstead.
1697
1698         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1699         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1700         (WTR::EventSenderProxy::dispatchMessage):
1701         (WTR::EventSenderProxy::EventSenderProxy):
1702         (WTR::EventSenderProxy::mouseDown):
1703         (WTR::EventSenderProxy::mouseUp):
1704         (WTR::EventSenderProxy::mouseMoveTo):
1705         (WTR::EventSenderProxy::mouseScrollBy):
1706         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1707
1708 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1709
1710         Unreviewed fix for API test failure after r240437.
1711
1712         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1713
1714         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1715
1716 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1717
1718         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1719         https://bugs.webkit.org/show_bug.cgi?id=193787
1720         <rdar://problem/47497634>
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         * Scripts/webkitdirs.pm:
1725         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1726
1727 2019-01-24  Truitt Savell  <tsavell@apple.com>
1728
1729         Unreviewed, rolling out r240446.
1730
1731         Casued 5 API failures
1732
1733         Reverted changeset:
1734
1735         "Activate the WebResourceLoadStatisticsStore in the
1736         NetworkProcess and deactivate it in the UIProcess."
1737         https://bugs.webkit.org/show_bug.cgi?id=193297
1738         https://trac.webkit.org/changeset/240446
1739
1740 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1741
1742         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1743         https://bugs.webkit.org/show_bug.cgi?id=193741
1744         <rdar://problem/47135030>
1745
1746         Reviewed by Antti Koivisto and Simon Fraser.
1747
1748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1749         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1750         (TestWebKitAPI::TEST):
1751
1752 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1753
1754         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1755         https://bugs.webkit.org/show_bug.cgi?id=193297
1756         <rdar://problem/47158841>
1757
1758         Reviewed by Alex Christensen.
1759
1760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1761         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1762         activating the message used to trigger the callback when it is set.
1763
1764 2019-01-24  John Wilander  <wilander@apple.com>
1765
1766         Add Ad Click Attribution as an internal/experimental feature
1767         https://bugs.webkit.org/show_bug.cgi?id=193685
1768         <rdar://problem/47450399>
1769
1770         Reviewed by Brent Fulgham.
1771
1772         Added test option adClickAttributionEnabled.
1773
1774         * DumpRenderTree/TestOptions.cpp:
1775         (TestOptions::TestOptions):
1776         * DumpRenderTree/TestOptions.h:
1777         * DumpRenderTree/mac/DumpRenderTree.mm:
1778         (setWebPreferencesForTestOptions):
1779
1780 2019-01-24  Antti Koivisto  <antti@apple.com>
1781
1782         [PSON] Flash on back navigation on Mac
1783         https://bugs.webkit.org/show_bug.cgi?id=193716
1784         <rdar://problem/47148458>
1785
1786         Reviewed by Chris Dumez.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1789
1790         Closing of the previous page is delayed so waiting for didFinishNavigation is
1791         not sufficient to guarantee we have received all the messages. Wait for them.
1792
1793 2019-01-24  Chris Dumez  <cdumez@apple.com>
1794
1795         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1796         https://bugs.webkit.org/show_bug.cgi?id=193761
1797         <rdar://problem/47456405>
1798
1799         Reviewed by Alex Christensen.
1800
1801         Add API test coverage.
1802
1803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1804
1805 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1806
1807         webkitpy: Missing PID in crashlog name should not be fatal
1808         https://bugs.webkit.org/show_bug.cgi?id=193771
1809
1810         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1811         of raising an exception.
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * Scripts/webkitpy/port/darwin.py:
1816         (DarwinPort._merge_crash_logs):
1817
1818 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1819
1820         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1821         https://bugs.webkit.org/show_bug.cgi?id=193746
1822
1823         Reviewed by Youenn Fablet.
1824
1825         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1826         so we'd best just not call it.
1827
1828         * Scripts/webkitpy/w3c/test_exporter.py:
1829         (WebPlatformTestExporter.create_branch_with_patch):
1830
1831 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1832
1833         Move FileSystem to WTF
1834         https://bugs.webkit.org/show_bug.cgi?id=193602
1835
1836         Reviewed by Yusuke Suzuki.
1837
1838         * DumpRenderTree/win/DumpRenderTree.cpp:
1839         * TestWebKitAPI/CMakeLists.txt:
1840         * TestWebKitAPI/PlatformGTK.cmake:
1841         * TestWebKitAPI/PlatformJSCOnly.cmake:
1842         * TestWebKitAPI/PlatformPlayStation.cmake:
1843         * TestWebKitAPI/PlatformWPE.cmake:
1844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1845         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1846         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1847         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1848         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1849         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1850         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1851         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1852         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1853         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1854
1855 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1856
1857         [WPE] Remove hard dependency on subprocess32 for the API tests
1858
1859         Rubber-stamped by Carlos Garcia Campos.
1860
1861         * glib/api_test_runner.py:
1862         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1863         its presence only when running WPEQt tests.
1864
1865 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         [GLIB] Expose JavaScriptCore options in GLib public API
1868         https://bugs.webkit.org/show_bug.cgi?id=188742
1869
1870         Reviewed by Michael Catanzaro.
1871
1872         Add a test for the new API.
1873
1874         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1875         (testsJSCOptions):
1876         (main):
1877
1878 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GTK][WPE] Support JPEG 2000 images
1881         https://bugs.webkit.org/show_bug.cgi?id=186272
1882
1883         Reviewed by Žan Doberšek.
1884
1885         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1886
1887         * gtk/jhbuild.modules:
1888         * wpe/jhbuild.modules:
1889
1890 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1891
1892         check-webkit-style should warn when using soft-linking macros in a header
1893         <https://webkit.org/b/193750>
1894
1895         Reviewed by Darin Adler.
1896
1897         * Scripts/webkitpy/style/checkers/cpp.py:
1898         (check_language): Add softlink/header check by refactoring the
1899         softlink/framework check.
1900         (CppChecker): Enable softlink/header check by default.
1901         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1902         (CppStyleTest.test_softlink_framework): Rename from
1903         CppStyleTest.test_softlink() and change test framework name in
1904         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1905         files. Set file_name for macros that only appear in headers.
1906         (CppStyleTest.test_softlink_header): Add tests for using
1907         soft-link macros in headers.
1908
1909 2019-01-23  Chris Dumez  <cdumez@apple.com>
1910
1911         Deprecate API to limit the maximum number of WebProcesses
1912         https://bugs.webkit.org/show_bug.cgi?id=193725
1913         <rdar://problem/47464879>
1914
1915         Reviewed by Geoff Garen.
1916
1917         Update existing API tests to stop using deprecated API.
1918
1919         * MiniBrowser/mac/AppDelegate.m:
1920         (defaultConfiguration):
1921         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1922         (TestWebKitAPI::TEST):
1923         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1924         (TestWebKitAPI::TEST):
1925         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1926         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1927         (TEST):
1928         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1929         (TEST):
1930
1931 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-app] Rename ews model buildermappings to buildermapping
1934         https://bugs.webkit.org/show_bug.cgi?id=193729
1935
1936         Reviewed by Lucas Forschler.
1937
1938         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1939         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1940         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1941
1942 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1943
1944         [ews-app] Rename ews model steps to step
1945         https://bugs.webkit.org/show_bug.cgi?id=193697
1946
1947         Reviewed by Lucas Forschler.
1948
1949         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1950         (Step): Renamed Steps to Step.
1951
1952 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1953
1954         Clean up IndexedDB files between tests
1955         https://bugs.webkit.org/show_bug.cgi?id=192796
1956         <rdar://problem/46824999>
1957
1958         Reviewed by Geoffrey Garen.
1959
1960         * DumpRenderTree/mac/DumpRenderTree.mm:
1961         (runTest):
1962         * WebKitTestRunner/TestController.cpp:
1963         (WTR::TestController::resetStateToConsistentValues):
1964         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1965         (WTR::RemoveAllIndexedDatabasesCallback):
1966         (WTR::TestController::ClearIndexedDatabases):
1967         * WebKitTestRunner/TestController.h:
1968         * WebKitTestRunner/TestInvocation.cpp:
1969         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1970
1971 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-app] Rename ews model Builds to Build
1974         https://bugs.webkit.org/show_bug.cgi?id=193695
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1979         (Build): Renamed Builds to Build.
1980
1981 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1982
1983         webkitpy: Wait longer when launching WebKitTestRunner
1984         https://bugs.webkit.org/show_bug.cgi?id=193734
1985
1986         Reviewed by Aakash Jain.
1987
1988         * Scripts/webkitpy/port/simulator_process.py:
1989         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1990
1991 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1992
1993         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1994         https://bugs.webkit.org/show_bug.cgi?id=193182
1995         <rdar://problem/47452154>
1996
1997         Reviewed by Tim Horton.
1998
1999         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2000         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2001         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2002
2003         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2004         preventing later tests from recognizing gestures.
2005
2006         * WebKitTestRunner/ios/TestControllerIOS.mm:
2007         (WTR::TestController::platformResetStateToConsistentValues):
2008
2009         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2010
2011 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2012
2013         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2014         https://bugs.webkit.org/show_bug.cgi?id=193722
2015         <rdar://problem/47481475>
2016
2017         Reviewed by Lucas Forschler.
2018
2019         iPhone and iPad ports should both use the iOS config.
2020
2021         * Scripts/webkitpy/port/ios_simulator.py:
2022         (IPhoneSimulatorPort.__init__):
2023         (IPadSimulatorPort.__init__):
2024
2025 2019-01-23  Rob Buis  <rbuis@igalia.com>
2026
2027         Update MIME type parser
2028         https://bugs.webkit.org/show_bug.cgi?id=180526
2029
2030         Reviewed by Frédéric Wang.
2031
2032         Add unit tests for both parse modes of ParsedContentType.
2033
2034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2035         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2036         (TestWebKitAPI::TEST):
2037
2038 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2039
2040         [ews-app] fetch loop should not stop on network issues
2041         https://bugs.webkit.org/show_bug.cgi?id=193666
2042
2043         Reviewed by Lucas Forschler.
2044
2045         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2046         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2047
2048 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2049
2050         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2051         https://bugs.webkit.org/show_bug.cgi?id=189165
2052         <rdar://problem/47433765>
2053
2054         Reviewed by Tim Horton.
2055
2056         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2057         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2058         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2059         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2060         would make its way to the UI process by the time the layer tree commit is finished.
2061
2062         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2063         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2064         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2065         will fail because it asks for -_autofillContext too early.
2066
2067         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2068         is handled in the UI process.
2069
2070         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2071
2072         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2073         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2074         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2075         input session.
2076
2077         (-[AutofillTestView textInputHasAutofillContext]):
2078
2079         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2080
2081         * TestWebKitAPI/cocoa/TestWKWebView.h:
2082         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2083         (nextInputSessionChangeCount):
2084
2085         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2086         This includes changing the focused element from one to another.
2087
2088         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2089         (-[TestWKWebView didStartFormControlInteraction]):
2090         (-[TestWKWebView didEndFormControlInteraction]):
2091         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2092
2093         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2094         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2095         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2096         that doesn't require an input session to one that doesn't.
2097
2098 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2099
2100         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2101         <https://webkit.org/b/193676>
2102
2103         Reviewed by Alexey Proskuryakov.
2104
2105         * Scripts/webkitpy/style/checkers/cpp.py:
2106         (check_member_initialization_list):
2107         - Don't report missing whitespace around colon if the colon at
2108           the start of the line is formatted correctly.
2109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2110         (WebKitStyleTest.test_member_initialization_list):
2111         - Add a test for a missing permutation of existing tests.
2112         - Add a test this false-positive.
2113         - Add blank lines between subtests to make them easier to read.
2114
2115 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2116
2117         [build.webkit.org] Unit-test failure after r237113
2118         https://bugs.webkit.org/show_bug.cgi?id=193669
2119
2120         Reviewed by Michael Catanzaro.
2121
2122         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2123         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2124         multiple or zero flags.
2125
2126 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2127
2128         Cache bytecode to disk
2129         https://bugs.webkit.org/show_bug.cgi?id=192782
2130         <rdar://problem/46084932>
2131
2132         Reviewed by Keith Miller.
2133
2134         Add test helper to execute bytecode-cache tests: it executes each test
2135         twice, the first with JSC_diskCachePath set to a temporary directory
2136         and second with JSC_forceDiskCache=true (in addition to the cache path)
2137         to guarantee that only the disk cache is being used and no new
2138         UnlinkedCodeBlocks are being created.
2139
2140         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2141         * Scripts/run-jsc-stress-tests:
2142
2143 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2144
2145         [css-logical] Implement flow-relative margin, padding and border shorthands
2146         https://bugs.webkit.org/show_bug.cgi?id=188697
2147
2148         Reviewed by Simon Fraser and Antti Koivisto.
2149
2150         * DumpRenderTree/TestOptions.cpp:
2151         (TestOptions::TestOptions):
2152         * DumpRenderTree/TestOptions.h:
2153         * DumpRenderTree/mac/DumpRenderTree.mm:
2154         (setWebPreferencesForTestOptions):
2155         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2156
2157         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2158         (JSONCSSPropertiesChecker.check_codegen_properties):
2159         Allow CSS property definitions to have a 'runtime-flag' parameter which
2160         disables the property when the specified runtime flag is disabled.
2161
2162 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2163
2164         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2165         https://bugs.webkit.org/show_bug.cgi?id=193643
2166
2167         Reviewed by Michael Catanzaro.
2168
2169         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2170         * wpe/jhbuild.modules: Ditto.
2171
2172 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2173
2174         [LFC][Floats] Take float top position into account when computing containing block height.
2175         https://bugs.webkit.org/show_bug.cgi?id=193655
2176
2177         Reviewed by Antti Koivisto.
2178
2179         * LayoutReloaded/misc/LFC-passing-tests.txt:
2180
2181 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2182
2183         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2184         <https://webkit.org/b/193645>
2185         <rdar://problem/47421574>
2186
2187         Reviewed by Alex Christensen.
2188
2189         - Now checks for local soft-linking of all frameworks that have
2190           their own *SoftLinking.{cpp,h,mm} files.
2191         - Changes softlink/uikit warning to softlink/framework.
2192
2193         * Scripts/webkitpy/style/checkers/cpp.py:
2194         (check_language):
2195         (CppChecker):
2196         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2197         (CppStyleTest):
2198
2199 2019-01-20  Saam Barati  <sbarati@apple.com>
2200
2201         Rollout r240210: It broke tests on iOS
2202         https://bugs.webkit.org/show_bug.cgi?id=193640
2203
2204         Unreviewed.
2205
2206         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2207         * Scripts/run-jsc-stress-tests:
2208
2209 2019-01-20  chris fleizach  <cfleizach@apple.com>
2210
2211         AX: Support returning relative frames for accessibility
2212         https://bugs.webkit.org/show_bug.cgi?id=193414
2213         <rdar://problem/47268501>
2214
2215         Reviewed by Zalan Bujtas.
2216
2217         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2218         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2219         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2220         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2221         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2222         (WTR::attributesOfElement):
2223         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2224
2225 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2226
2227         Unreviewed, add my new email address
2228
2229         * Scripts/webkitpy/common/config/contributors.json:
2230
2231 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2232
2233         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2234         https://bugs.webkit.org/show_bug.cgi?id=193617
2235
2236         Reviewed by Antti Koivisto.
2237
2238         * LayoutReloaded/misc/LFC-passing-tests.txt:
2239
2240 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2241
2242         Unreviewed, rolling out r240209.
2243
2244         Broke GTK/WPE injected bundle
2245
2246         Reverted changeset:
2247
2248         "AX: Support returning relative frames for accessibility"
2249         https://bugs.webkit.org/show_bug.cgi?id=193414
2250         https://trac.webkit.org/changeset/240209
2251
2252 2019-01-12  Dan Bernstein  <mitz@apple.com>
2253
2254         [Cocoa] Avoid importing directly from subumbrella frameworks
2255         https://bugs.webkit.org/show_bug.cgi?id=186016
2256         <rdar://problem/40591038>
2257
2258         Reviewed by Sam Weinig.
2259
2260         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2261           LaunchServices header.
2262         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2263           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2264         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2265           when using SDKs earlier than 10.13.
2266         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2267           and OTHER_CPLUSPLUSFLAGS.
2268         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2269           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2270         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2271           LaunchServices header.
2272
2273 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2274
2275         Cache bytecode to disk
2276         https://bugs.webkit.org/show_bug.cgi?id=192782
2277         <rdar://problem/46084932>
2278
2279         Reviewed by Keith Miller.
2280
2281         Add test helper to execute bytecode-cache tests: it executes each test
2282         twice, the first with JSC_diskCachePath set to a temporary directory
2283         and second with JSC_forceDiskCache=true (in addition to the cache path)
2284         to guarantee that only the disk cache is being used and no new
2285         UnlinkedCodeBlocks are being created.
2286
2287         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2288         * Scripts/run-jsc-stress-tests:
2289
2290 2019-01-20  chris fleizach  <cfleizach@apple.com>
2291
2292         AX: Support returning relative frames for accessibility
2293         https://bugs.webkit.org/show_bug.cgi?id=193414
2294         <rdar://problem/47268501>
2295
2296         Reviewed by Zalan Bujtas.
2297
2298         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2299         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2300         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2301         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2302         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2303         (WTR::attributesOfElement):
2304         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2305
2306 2019-01-20  Antoine Quint  <graouts@apple.com>
2307
2308         Add a POINTER_EVENTS feature flag
2309         https://bugs.webkit.org/show_bug.cgi?id=193577
2310         <rdar://problem/47408511>
2311
2312         Unreviewed. Also enable Pointer Events for iosmac.
2313
2314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2315
2316 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2317
2318         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2319         https://bugs.webkit.org/show_bug.cgi?id=193613
2320
2321         Reviewed by Antti Koivisto.
2322
2323         * LayoutReloaded/misc/LFC-passing-tests.txt:
2324
2325 2019-01-19  Antoine Quint  <graouts@apple.com>
2326
2327         Add a POINTER_EVENTS feature flag
2328         https://bugs.webkit.org/show_bug.cgi?id=193577
2329
2330         Reviewed by Dean Jackson.
2331
2332         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2333
2334 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2335
2336         Disable the run-jsc-stress-test remote host key check [second round].
2337         https://bugs.webkit.org/show_bug.cgi?id=192988
2338
2339         Reviewed by Dewei Zhu.
2340
2341         * Scripts/run-jsc-stress-tests:
2342
2343 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2346         https://bugs.webkit.org/show_bug.cgi?id=193597
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2351
2352 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2353
2354         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2355         https://bugs.webkit.org/show_bug.cgi?id=193595
2356
2357         Reviewed by Lucas Forschler.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2360         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2361         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2362
2363 2019-01-18  Chris Dumez  <cdumez@apple.com>
2364
2365         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2366         https://bugs.webkit.org/show_bug.cgi?id=193588
2367         <rdar://problem/47131566>
2368
2369         Reviewed by Alex Christensen.
2370
2371         Add layout test coverage.
2372
2373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2374
2375 2019-01-18  Jer Noble  <jer.noble@apple.com>
2376
2377         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2378         https://bugs.webkit.org/show_bug.cgi?id=189553
2379
2380         Reviewed by Tim Horton.
2381
2382         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2383
2384         * ContentExtensionTester/Configurations/Base.xcconfig:
2385         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2386         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2387         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2388         * ImageDiff/cg/Configurations/Base.xcconfig:
2389         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2390         * MiniBrowser/Configurations/Base.xcconfig:
2391         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2392         * MobileMiniBrowser/Configurations/Base.xcconfig:
2393         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2394         * Scripts/webkitpy/style/checker.py:
2395         (_all_categories):
2396         (FileType):
2397         (CheckerDispatcher._file_type):
2398         (CheckerDispatcher._create_checker):
2399         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2400         (SDKVariantChecker):
2401         (SDKVariantChecker.__init__):
2402         (SDKVariantChecker.check):
2403         * TestWebKitAPI/Configurations/Base.xcconfig:
2404         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2405         * WebEditingTester/Configurations/Base.xcconfig:
2406         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2407         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2408         * WebKitTestRunner/Configurations/Base.xcconfig:
2409         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2410         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2411         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2412
2413 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2414
2415         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2416         <https://webkit.org/b/193568>
2417         <rdar://problem/47381130>
2418
2419         Reviewed by Alex Christensen.
2420
2421         Make sure no one re-introduces UIKit soft-linking by adding a
2422         style rule.
2423
2424         * Scripts/webkitpy/style/checkers/cpp.py:
2425         (check_language): Add softlink/uikit check.
2426         (CppChecker): Enable softlink/uikit check.
2427         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2428         (CppStyleTest): Add test for softlink/uikit.
2429
2430 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2431
2432         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2433         https://bugs.webkit.org/show_bug.cgi?id=193584
2434
2435         Change "-dev" to "-devel".
2436
2437         Reviewed by Michael Catanzaro.
2438
2439         * gtk/install-dependencies:
2440
2441 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2442
2443         webkitpy: Add iPhone and iPad ports
2444         https://bugs.webkit.org/show_bug.cgi?id=193537
2445         <rdar://problem/47353390>
2446
2447         Reviewed by Lucas Forschler.
2448
2449         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2450         ports. Note that this separation is optional, the --ios-simulator command remains.
2451
2452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2453         (RunTest.test_device_type_test_division): Drive-by fix.
2454         (RunTest.test_device_type_specific_listing): Ditto.
2455         (RunTest.test_ipad_test_division):
2456         (RunTest):
2457         (RunTest.test_ipad_listing):
2458         * Scripts/webkitpy/port/factory.py:
2459         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2460         (PortFactory):
2461         * Scripts/webkitpy/port/ios_simulator.py:
2462         (IPhoneSimulatorPort):
2463         (IPadSimulatorPort):
2464
2465 2019-01-18  Chris Dumez  <cdumez@apple.com>
2466
2467         Regression(PSON) Scroll position is not always restored properly when navigating back
2468         https://bugs.webkit.org/show_bug.cgi?id=193578
2469         <rdar://problem/47386331>
2470
2471         Reviewed by Tim Horton.
2472
2473         Add API test coverage.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2476
2477 2019-01-18  Youenn Fablet  <youenn@apple.com>
2478
2479         Add a new SPI to request for cache storage quota increase
2480         https://bugs.webkit.org/show_bug.cgi?id=193323
2481
2482         Reviewed by Alex Christensen.
2483
2484         Implement WebsiteDataStore quota delegate to handle quota requests.
2485         By default, do not update quota.
2486         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2487
2488         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2490         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2492         * WebKitTestRunner/TestController.cpp:
2493         (WTR::TestController::allowCacheStorageQuotaIncrease):
2494         * WebKitTestRunner/TestController.h:
2495         * WebKitTestRunner/TestInvocation.cpp:
2496         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2497         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2498         (-[CacheStorageQuotaManager init]):
2499         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2500         (WTR::initializeWebViewConfiguration):
2501         (WTR::TestController::cocoaResetStateToConsistentValues):
2502         (WTR::TestController::allowCacheStorageQuotaIncrease):
2503
2504 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2505
2506         [ews-build] Pass owner to the triggered builds
2507         https://bugs.webkit.org/show_bug.cgi?id=193574
2508
2509         Reviewed by Lucas Forschler.
2510
2511         * BuildSlaveSupport/ews-build/factories.py:
2512         (BuildFactory.propertiesToPassToTriggers):
2513
2514 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2515
2516         [ews-app] Send patch author as a build property
2517         https://bugs.webkit.org/show_bug.cgi?id=193560
2518
2519         Reviewed by Lucas Forschler.
2520
2521         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2522         (BugzillaPatchFetcher.fetch):
2523
2524 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2525
2526         webkitpy: Implement device type specific expected results (Follow-up fix)
2527         https://bugs.webkit.org/show_bug.cgi?id=192162
2528         <rdar://problem/46345449>
2529
2530         Unreviewed infrastructure fix.
2531
2532         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2533         (Manager.run): Don't boot a device if no tests are available to run on it.
2534
2535 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2536
2537         webkitpy: Implement device type specific expected results (Follow-up fix)
2538         https://bugs.webkit.org/show_bug.cgi?id=192162
2539         <rdar://problem/46345449>
2540
2541         Unreviewed infrastructure fix.
2542
2543         * Scripts/webkitpy/api_tests/manager.py:
2544         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2545
2546 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2547
2548         webkitpy: Implement device type specific expected results (Part 2)
2549         https://bugs.webkit.org/show_bug.cgi?id=192162
2550         <rdar://problem/46345449>
2551
2552         Rubber-stamped by Aakash Jain.
2553
2554         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2555         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2556         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2557
2558         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2559         (LayoutTestFinder.find_tests): Pass device_type through.
2560         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2561         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2562         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2563         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2564         (Manager._collect_tests): Pass device type to test finder.
2565         (Manager._needs_web_platform_test):
2566         (Manager._prepare_lists): Index _expectations by device type.
2567         (Manager._test_input_for_file):
2568         (Manager._test_is_slow): Ditto.
2569         (Manager._test_should_dump_jsconsolelog_in_stderr):
2570         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2571         (Manager._get_test_inputs):
2572         (Manager._update_worker_count):
2573         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2574         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2575         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2576         the one which runs the test.
2577         (Manager._run_test_subset):
2578         (Manager._run_tests): Index _expectations by current_device_type.
2579         (Manager._print_expectation_line_for_test): Ditto.
2580         (Manager._print_expectations_for_subset): Ditto.
2581         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2582         Unlike run, this function will behave the same regardless of what devices are available.
2583         (Manager._custom_device_for_test): Deleted.
2584         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2585         (ManagerTest.test_uses_custom_device): Deleted.
2586         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2587         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2588         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2589         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2590         all of the expectations.
2591         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2592         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2593         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2594         (TestExpectations.__init__): Allow device_type to be passed through.
2595         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2596         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2597         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2598         (summarize_results):
2599         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2600         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2601         a test ran with, one must check all expectations to find the first non-skip expectation.
2602         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2603         (RunTest.test_device_type_test_division):
2604         (RunTest):
2605         (RunTest.test_device_type_specific_listing):
2606         * Scripts/webkitpy/port/base.py:
2607         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2608         (Port.supported_device_types): The result of this function will change based on what devices are available.
2609         * Scripts/webkitpy/port/device_port.py:
2610         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2611         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2612         can be used.
2613         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2614         any, or the DEFAULT_DEVICE_TYPES of the port.
2615         * Scripts/webkitpy/port/ios.py:
2616         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2617         * Scripts/webkitpy/port/ios_simulator.py:
2618         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2619         * Scripts/webkitpy/port/watch.py:
2620         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2621         * Scripts/webkitpy/port/watch_simulator.py:
2622         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2623         * Scripts/webkitpy/xcode/device_type.py:
2624         (DeviceType):
2625         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2626
2627 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2628
2629         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2630         https://bugs.webkit.org/show_bug.cgi?id=193575
2631
2632         Reviewed by Michael Catanzaro.
2633
2634         Allow the script to run without explicit port argument because
2635         it's specific to the WPE port anyway.
2636
2637         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2638         and simplify the rest of the code accordingly.
2639
2640 2019-01-18  Charlie Turner  <cturner@igalia.com>
2641
2642         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2643         https://bugs.webkit.org/show_bug.cgi?id=192229
2644
2645         Reviewed by Xabier Rodriguez-Calvar.
2646
2647         * MiniBrowser/wpe/main.cpp:
2648         (main): Enable encrypted-media by default.
2649
2650 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2651
2652         [Flatpak] Missing KeyboardInterrupt exception handler
2653         https://bugs.webkit.org/show_bug.cgi?id=193570
2654
2655         Reviewed by Michael Catanzaro.
2656
2657         * flatpak/flatpakutils.py:
2658         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2659
2660 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2661
2662         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2663         https://bugs.webkit.org/show_bug.cgi?id=193564
2664
2665         Reviewed by Antti Koivisto.
2666
2667         * LayoutReloaded/misc/LFC-passing-tests.txt:
2668
2669 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2670
2671         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2672         https://bugs.webkit.org/show_bug.cgi?id=193562
2673
2674         Reviewed by Antti Koivisto.
2675
2676         * LayoutReloaded/misc/LFC-passing-tests.txt:
2677
2678 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2679
2680         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2681         https://bugs.webkit.org/show_bug.cgi?id=193555
2682
2683         Reviewed by Antti Koivisto.
2684
2685         * LayoutReloaded/misc/LFC-passing-tests.txt:
2686
2687 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2688
2689         [WPE] Add Qt extension
2690         https://bugs.webkit.org/show_bug.cgi?id=191464
2691
2692         Reviewed by Carlos Garcia Campos.
2693
2694         MiniBrowser and API tests for the WPE Qt API. To run the
2695         MiniBrowser a new script is introduced. Example invocation:
2696
2697         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2698
2699         Also note-worthy is the introduction of the python2-subprocess32
2700         dependency to run the GLib API tests.
2701
2702         * MiniBrowser/wpe/CMakeLists.txt:
2703         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2704         * MiniBrowser/wpe/qt/main.cpp: Added.
2705         (main):
2706         * MiniBrowser/wpe/qt/main.qml: Added.
2707         * MiniBrowser/wpe/qt/qml.qrc: Added.
2708         * Scripts/run-gtk-tests:
2709         (GtkTestRunner.is_google_test):
2710         (GtkTestRunner):
2711         (GtkTestRunner.is_qt_test):
2712         * Scripts/run-qt-wpe-minibrowser: Added.
2713         * Scripts/run-wpe-tests:
2714         (WPETestRunner):
2715         (WPETestRunner.is_google_test):
2716         (WPETestRunner.is_qt_test):
2717         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2718         (TestLoad::main):
2719         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2720         (TestLoadHtml::main):
2721         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2722         (TestLoadRequest::main):
2723         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2724         (TestRunJavaScript::main):
2725         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2726         (waitForSignal):
2727         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2728         (LoadSpy::LoadSpy):
2729         (LoadSpy::~LoadSpy):
2730         (LoadSpy::onLoadingChanged):
2731         (LoadStartedCatcher::LoadStartedCatcher):
2732         (LoadStartedCatcher::~LoadStartedCatcher):
2733         (LoadStartedCatcher::onLoadingChanged):
2734         (waitForLoadSucceeded):
2735         (waitForLoadFailed):
2736         * TestWebKitAPI/glib/CMakeLists.txt:
2737         * flatpak/flatpakutils.py:
2738         (WebkitFlatpak.load_from_args):
2739         (WebkitFlatpak.__init__):
2740         (WebkitFlatpak.clean_args):
2741         (WebkitFlatpak.run_in_sandbox):
2742         * flatpak/org.webkit.CommonModules.yaml:
2743         * flatpak/org.webkit.WPE.yaml:
2744         * flatpak/org.webkit.WPEModules.yaml:
2745         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2746         * flatpak/org.webkit.WebKit.yaml:
2747         * glib/api_test_runner.py:
2748         (TestRunner._run_test_qt):
2749         (TestRunner.is_qt_test):
2750         (TestRunner._run_test):
2751
2752 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2753
2754         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2755         https://bugs.webkit.org/show_bug.cgi?id=193494
2756         <rdar://problem/46859627>
2757
2758         Reviewed by Simon Fraser and Tim Horton.
2759
2760         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2761         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2762
2763         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2764         (WTR::UIScriptController::contentOffsetX const):
2765         (WTR::UIScriptController::contentOffsetY const):
2766         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2767         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2768         (WTR::UIScriptController::contentOffsetX const):
2769         (WTR::UIScriptController::contentOffsetY const):
2770         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2771
2772         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2773
2774         * WebKitTestRunner/TestController.cpp:
2775         (WTR::updateTestOptionsFromTestHeader):
2776         * WebKitTestRunner/TestOptions.h:
2777         (WTR::TestOptions::hasSameInitializationOptions const):
2778         * WebKitTestRunner/ios/TestControllerIOS.mm:
2779         (WTR::TestController::platformResetStateToConsistentValues):
2780         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2781         (WTR::UIScriptController::contentOffsetX const):
2782         (WTR::UIScriptController::contentOffsetY const):
2783
2784 2019-01-17  Truitt Savell  <tsavell@apple.com>
2785
2786         Unreviewed, rolling out r240124.
2787
2788         This commit broke an internal build.
2789
2790         Reverted changeset:
2791
2792         "SDK_VARIANT build destinations should be separate from non-
2793         SDK_VARIANT builds"
2794         https://bugs.webkit.org/show_bug.cgi?id=189553
2795         https://trac.webkit.org/changeset/240124
2796
2797 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2798
2799         Fix string concatenation API test after r239920
2800         https://bugs.webkit.org/show_bug.cgi?id=193551
2801         <rdar://problem/47359304>
2802
2803         Reviewed by Youenn Fablet.
2804
2805         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2806         (TestWebKitAPI::TEST):
2807         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2808         in WebKit's build configuration like it apparently is on Linux.
2809
2810 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-build] validate-patch should handle the case when bug_id is None
2813         https://bugs.webkit.org/show_bug.cgi?id=193547
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-build/steps.py:
2818         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2819         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2820
2821 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2822
2823         [ews-build] Add patch author information in build
2824         https://bugs.webkit.org/show_bug.cgi?id=193465
2825
2826         Reviewed by Lucas Forschler.
2827
2828         * BuildSlaveSupport/ews-build/steps.py:
2829         (ValidatePatch._is_patch_obsolete):
2830
2831 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2832
2833         [ews-build] Pass bug_id to the triggered builds
2834         https://bugs.webkit.org/show_bug.cgi?id=193548
2835
2836         Reviewed by Lucas Forschler.
2837
2838         * BuildSlaveSupport/ews-build/factories.py:
2839         (BuildFactory.propertiesToPassToTriggers):
2840
2841 2019-01-17  Jer Noble  <jer.noble@apple.com>
2842
2843         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2844         https://bugs.webkit.org/show_bug.cgi?id=189553
2845
2846         Reviewed by Tim Horton.
2847
2848         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2849
2850         * ContentExtensionTester/Configurations/Base.xcconfig:
2851         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2852         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2853         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2854         * ImageDiff/cg/Configurations/Base.xcconfig:
2855         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2856         * MiniBrowser/Configurations/Base.xcconfig:
2857         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2858         * MobileMiniBrowser/Configurations/Base.xcconfig:
2859         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2860         * Scripts/webkitpy/style/checker.py:
2861         (_all_categories):
2862         (FileType):
2863         (CheckerDispatcher._file_type):
2864         (CheckerDispatcher._create_checker):
2865         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2866         (SDKVariantChecker):
2867         (SDKVariantChecker.__init__):
2868         (SDKVariantChecker.check):
2869         * TestWebKitAPI/Configurations/Base.xcconfig:
2870         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2871         * WebEditingTester/Configurations/Base.xcconfig:
2872         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2873         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2874         * WebKitTestRunner/Configurations/Base.xcconfig:
2875         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2876         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2877         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2878
2879 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2880
2881         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2882         https://bugs.webkit.org/show_bug.cgi?id=193534
2883
2884         Reviewed by Antti Koivisto.
2885
2886         * LayoutReloaded/misc/LFC-passing-tests.txt:
2887
2888 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2889
2890         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2891         https://bugs.webkit.org/show_bug.cgi?id=193528
2892
2893         Reviewed by Antti Koivisto.
2894
2895         * LayoutReloaded/misc/LFC-passing-tests.txt:
2896
2897 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2898
2899         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2900         https://bugs.webkit.org/show_bug.cgi?id=193520
2901
2902         Reviewed by Antti Koivisto.
2903
2904         * LayoutReloaded/misc/LFC-passing-tests.txt:
2905
2906 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2907
2908         [ews-build] unapply-patch step should not update source
2909         https://bugs.webkit.org/show_bug.cgi?id=193234
2910
2911         Reviewed by Lucas Forschler.
2912
2913         * BuildSlaveSupport/ews-build/steps.py:
2914         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2915         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2916
2917 2019-01-16  Youenn Fablet  <youenn@apple.com>
2918
2919         Add a new SPI for controlling getUserMedia
2920         https://bugs.webkit.org/show_bug.cgi?id=192793
2921
2922         Reviewed by Eric Carlson.
2923
2924         * MiniBrowser/mac/WK2BrowserWindowController.m:
2925         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2926         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2927         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2928         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2929         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2930         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2931         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2932         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2933         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2934         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2935         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2936         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2937         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2938         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2939
2940 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2941
2942         [LFC][BFC] Inflow non-replaced used width should not be negative.
2943         https://bugs.webkit.org/show_bug.cgi?id=193495
2944
2945         Reviewed by Antti Koivisto.
2946
2947         * LayoutReloaded/misc/LFC-passing-tests.txt:
2948
2949 2019-01-16  Chris Dumez  <cdumez@apple.com>
2950
2951         Regression(PSON) View becomes blank after click a cross-site download link
2952         https://bugs.webkit.org/show_bug.cgi?id=193361
2953         <rdar://problem/47099573>
2954
2955         Reviewed by Geoffrey Garen.
2956
2957         Add API test coverage.
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2960         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2961
2962 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2963
2964         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2965         https://bugs.webkit.org/show_bug.cgi?id=193470
2966
2967         Reviewed by Antti Koivisto.
2968
2969         * LayoutReloaded/misc/LFC-passing-tests.txt:
2970
2971 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2972
2973         [LFC] Adjust margin box verification.
2974         https://bugs.webkit.org/show_bug.cgi?id=193482
2975
2976         Reviewed by Antti Koivisto.
2977
2978         * LayoutReloaded/misc/LFC-passing-tests.txt:
2979
2980 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2981
2982         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2983         https://bugs.webkit.org/show_bug.cgi?id=193451
2984
2985         Reviewed by Geoffrey Garen.
2986
2987         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2988         (TEST):
2989         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2990         (runWebsiteDataStoreCustomPaths):
2991
2992 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2993
2994         webkitpy: Support boolean simctl isAvailable
2995         https://bugs.webkit.org/show_bug.cgi?id=193472
2996         <rdar://problem/47296150>
2997
2998         Reviewed by Ryosuke Niwa.
2999
3000         * Scripts/webkitpy/xcode/simulated_device.py:
3001         (SimulatedDeviceManager._create_runtimes):
3002         (SimulatedDeviceManager._create_device_with_runtime):
3003
3004 2019-01-15  Chris Dumez  <cdumez@apple.com>
3005
3006         Unreviewed, rolling out r239993, r239995, r239997, and
3007         r239999.
3008
3009         Caused assertions under
3010         ViewGestureController::disconnectFromProcess()
3011
3012         Reverted changesets:
3013
3014         "Regression(PSON) View becomes blank after click a cross-site
3015         download link"
3016         https://bugs.webkit.org/show_bug.cgi?id=193361
3017         https://trac.webkit.org/changeset/239993
3018
3019         "Unreviewed iOS build fix after r239993."
3020         https://trac.webkit.org/changeset/239995
3021
3022         "Fix iOS build after r239993"
3023         https://bugs.webkit.org/show_bug.cgi?id=193361
3024         https://trac.webkit.org/changeset/239997
3025
3026         "Unreviewed, revert part of r239997 as it is not needed to fix
3027         the build."
3028         https://trac.webkit.org/changeset/239999
3029
3030 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3031
3032         Cannot tab out of WKWebView on macOS
3033         https://bugs.webkit.org/show_bug.cgi?id=161448
3034         <rdar://problem/28100085>
3035
3036         Reviewed by Dean Jackson.
3037
3038         Add a test that tabbing into and out of WKWebView works correctly.
3039
3040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3041         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3042         (WebKit2_CommandBackForwardTest::SetUp):
3043         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3044         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3045         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3046         (-[FocusableView canBecomeKeyView]):
3047         (TEST):
3048         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3049         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3050         (-[OffscreenWindow initWithSize:]):
3051         (-[OffscreenWindow isKeyWindow]):
3052         (-[OffscreenWindow isVisible]):
3053         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3054         (TestWebKitAPI::PlatformWebView::initialize):
3055         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3056         (-[ActiveOffscreenWindow isVisible]): Deleted.
3057         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3058
3059 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3060
3061         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3062         https://bugs.webkit.org/show_bug.cgi?id=193459
3063
3064         Reviewed by Mark Lam.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3067         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3068
3069 2019-01-15  Chris Dumez  <cdumez@apple.com>
3070
3071         Regression(PSON) View becomes blank after click a cross-site download link
3072         https://bugs.webkit.org/show_bug.cgi?id=193361
3073         <rdar://problem/47099573>
3074
3075         Reviewed by Geoff Garen.
3076
3077         Add API test coverage.
3078
3079         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3080         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3081
3082 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3083
3084         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3085         https://bugs.webkit.org/show_bug.cgi?id=193448
3086
3087         Reviewed by Antti Koivisto.
3088
3089         * LayoutReloaded/misc/LFC-passing-tests.txt:
3090
3091 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3092
3093         webkitpy: Implement device type specific expected results (Part 1)
3094         https://bugs.webkit.org/show_bug.cgi?id=192162
3095
3096         Reviewed by Lucas Forschler.
3097
3098         Device type specific expected results covers two related ideas. The first (covered by this change)
3099         is where to search for -expected.* files. The second is which tests to run based on the
3100         TestExpectations.txt file.
3101
3102         After this change, the baseline search path will be determined by the type of device running a
3103         test. Device type will be passed into any function which picks a file based on the baseline search
3104         path.
3105
3106         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3107         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3108         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3109         (Manager.run): Print baseline search path for each round of devices.
3110         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3111         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3112         (SingleTestRunner._expected_driver_output): Ditto.
3113         (SingleTestRunner._driver_input): Ditto.
3114         * Scripts/webkitpy/layout_tests/views/printing.py:
3115         (Printer.print_config): Move printing of baseline search path to a separate function.
3116         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3117         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3118         (Testprinter.test_print_config):
3119         (Testprinter.test_print_baseline_search_path):
3120         * Scripts/webkitpy/port/base.py:
3121         (Port.baseline_search_path): Pass device_type through.
3122         (Port._expected_baselines_for_suffixes): Ditto.
3123         (Port.expected_baselines): Ditto.
3124         (Port.expected_filename): Ditto.
3125         (Port.expected_checksum): Ditto.
3126         (Port.expected_image): Ditto.
3127         (Port.expected_audio): Ditto.
3128         (Port.expected_text): Ditto.
3129         (Port.reference_files): Ditto.
3130         (Port.tests): Ditto.
3131         (Port._expanded_paths): Ditto.
3132         (Port.skipped_layout_tests): Ditto.
3133         (Port.expectations_dict): Ditto.
3134         (Port._port_specific_expectations_files): Ditto.
3135         (Port.expectations_files): Ditto.
3136         (Port.test_search_path): Ditto.
3137         (Port._tests_for_other_platforms): Ditto.
3138         * Scripts/webkitpy/port/base_unittest.py:
3139         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3140         (PortTest.test_nonexistant_expectations): Ditto.
3141         (test_ref_tests_platform_directory): Ditto.
3142         * Scripts/webkitpy/port/darwin.py:
3143         (DarwinPort._port_specific_expectations_files): Accept device_type.
3144         * Scripts/webkitpy/port/driver.py:
3145         (DriverProxy):
3146         (DriverProxy.host): Expose _target_host for device_type information.
3147         * Scripts/webkitpy/port/gtk.py:
3148         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3149         * Scripts/webkitpy/port/ios.py:
3150         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3151         * Scripts/webkitpy/port/mac.py:
3152         (MacPort. default_baseline_search_path): Ditto.
3153         * Scripts/webkitpy/port/port_testcase.py:
3154         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3155         * Scripts/webkitpy/port/test.py:
3156         * Scripts/webkitpy/port/watch.py:
3157         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3158         * Scripts/webkitpy/port/win.py:
3159         (WinPort.test_search_path): Accept, but do not use, device_type.
3160         * Scripts/webkitpy/port/wpe.py:
3161         (WPEPort._port_specific_expectations_files): Ditto.
3162         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3163         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3164
3165 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3166
3167         [LFC] Use the containing block's padding box to position out-of-flow elements.
3168         https://bugs.webkit.org/show_bug.cgi?id=193431
3169
3170         Reviewed by Antti Koivisto.
3171
3172         * LayoutReloaded/misc/LFC-passing-tests.txt:
3173
3174 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3175
3176         Move a test implementation file that got misplaced in the Xcode project
3177
3178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3179
3180 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3181
3182         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3183         r239913, and r239914.
3184         https://bugs.webkit.org/show_bug.cgi?id=193407
3185
3186         These revisions caused an internal failure (Requested by
3187         Truitt on #webkit).
3188
3189         Reverted changesets:
3190
3191         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3192         https://bugs.webkit.org/show_bug.cgi?id=186016
3193         https://trac.webkit.org/changeset/239901
3194
3195         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3196         https://trac.webkit.org/changeset/239909
3197
3198         "Tried to fix the build."
3199         https://trac.webkit.org/changeset/239910
3200
3201         "Fixed iOS builds after r239910."
3202         https://trac.webkit.org/changeset/239912
3203
3204         "More build fixing."
3205         https://trac.webkit.org/changeset/239913
3206
3207         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3208         https://trac.webkit.org/changeset/239914
3209
3210 2019-01-14  Mark Lam  <mark.lam@apple.com>
3211
3212         Re-enable ability to build --cloop builds.
3213         https://bugs.webkit.org/show_bug.cgi?id=192955
3214         <rdar://problem/46882363>
3215
3216         Reviewed by Saam barati and Keith Miller.
3217
3218         The --cloop build option was being ignored this whole time since r236381.
3219         This patch makes it possible to build CLoop builds again.
3220
3221         * Scripts/build-jsc:
3222         * Scripts/webkitperl/FeatureList.pm:
3223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3224
3225 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3226
3227         webkitpy: Expose device_type from host-like objects
3228         https://bugs.webkit.org/show_bug.cgi?id=193406
3229         <rdar://problem/47262305>
3230
3231         Reviewed by Lucas Forschler.
3232
3233         Devices should expose device_type. As a result, all host objects should
3234         provide a device_type property, even if they do not yet define a device_type.
3235
3236         * Scripts/webkitpy/common/system/systemhost.py:
3237         (SystemHost):
3238         (SystemHost.device_type):
3239         * Scripts/webkitpy/common/system/systemhost_mock.py:
3240         (MockSystemHost):
3241         (MockSystemHost.device_type):
3242         * Scripts/webkitpy/port/device.py:
3243         (Device):
3244         (Device.device_type):
3245         * Scripts/webkitpy/xcode/simulated_device.py:
3246         (SimulatedDeviceManager._find_exisiting_device_for_request):
3247         (SimulatedDeviceManager._disambiguate_device_type):
3248         (SimulatedDeviceManager._does_fulfill_request):
3249         (SimulatedDeviceManager.device_count_for_type):
3250         (SimulatedDeviceManager.initialize_devices):
3251         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3252         (test_available_devices):
3253         (test_swapping_devices):
3254
3255 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3256
3257         webkitpy: Support alternate simctl device list output (Follow-up fix)
3258         https://bugs.webkit.org/show_bug.cgi?id=193362
3259         <rdar://problem/47122965>
3260
3261         Rubber-stamped by Lucas Forschler.
3262
3263         * Scripts/webkitpy/xcode/simulated_device.py:
3264         (SimulatedDeviceManager.populate_available_devices):
3265
3266 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3267
3268         [iOS] Expose SPI to access the current sentence boundary and selection state
3269         https://bugs.webkit.org/show_bug.cgi?id=193398
3270         <rdar://problem/45893108>
3271
3272         Reviewed by Dean Jackson.
3273
3274         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3275         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3276         expected.
3277
3278         * TestWebKitAPI/EditingTestHarness.h:
3279         * TestWebKitAPI/EditingTestHarness.mm:
3280         (-[EditingTestHarness moveBackward]):
3281         (-[EditingTestHarness moveForward]):
3282         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3283
3284         Add a couple of new helper methods on EditingTestHarness.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3287         (-[SelectionChangeObserver initWithWebView:]):
3288         (-[SelectionChangeObserver webView]):
3289         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3290         (-[SelectionChangeObserver currentSelectionAttributes]):
3291
3292 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3293
3294         [LFC][BFC] Add basic box-sizing support.
3295         https://bugs.webkit.org/show_bug.cgi?id=193392
3296
3297         Reviewed by Antti Koivisto.
3298
3299         * LayoutReloaded/misc/LFC-passing-tests.txt:
3300
3301 2019-01-14  Charlie Turner  <cturner@igalia.com>
3302
3303         [WPE] API test gardening
3304         https://bugs.webkit.org/show_bug.cgi?id=193319
3305
3306         Reviewed by Michael Catanzaro.
3307
3308         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3309         passing tests.
3310
3311 2019-01-14  Charlie Turner  <cturner@igalia.com>
3312
3313         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3314         https://bugs.webkit.org/show_bug.cgi?id=192977
3315
3316         Reviewed by Carlos Garcia Campos.
3317
3318         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3319         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3320         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3321         (TestWebKitAPI::GStreamerTest::SetUp):
3322         (TestWebKitAPI::GStreamerTest::TearDown):
3323         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3324         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3325         (TestWebKitAPI::TEST_F):
3326
3327 2019-01-14  Charlie Turner  <cturner@igalia.com>
3328
3329         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3330         https://bugs.webkit.org/show_bug.cgi?id=193332
3331
3332         Reviewed by Michael Catanzaro.
3333
3334         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3335         defined as a char16_t, which changed in ICU 59, the
3336         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3337         unsigned short. This test is relying on the behaviour that
3338         UChar=unsigned short, which doesn't hold across platforms and ICU
3339         library versions. The full fix would be a special syntax for
3340         literal characters so that these ambiguities do not arise. That
3341         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3342         (TestWebKitAPI::TEST):
3343
3344 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3345
3346         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3347
3348         * Scripts/make-dist:
3349         (Distcheck.configure):
3350
3351 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3352
3353         [ews-build] Update macOS queue configurations
3354         https://bugs.webkit.org/show_bug.cgi?id=193365
3355         <rdar://problem/47221073>
3356
3357         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3358
3359         * BuildSlaveSupport/ews-build/config.json:
3360
3361 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3362
3363         [LFC] Adjust assert for statically positioned fixed elements
3364         https://bugs.webkit.org/show_bug.cgi?id=193385
3365
3366         Reviewed by Antti Koivisto.
3367
3368         * LayoutReloaded/misc/LFC-passing-tests.txt:
3369
3370 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3371
3372         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3373         https://bugs.webkit.org/show_bug.cgi?id=193387
3374
3375         Reviewed by Carlos Garcia Campos.
3376
3377         * MiniBrowser/wpe/main.cpp:
3378         (main):
3379
3380 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3381
3382         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3383         https://bugs.webkit.org/show_bug.cgi?id=191655
3384         rdar://problem/46074680
3385
3386         Reviewed by Megan Gardner.
3387
3388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3389         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3390
3391 2019-01-12  Dan Bernstein  <mitz@apple.com>
3392
3393         [Cocoa] Avoid importing directly from subumbrella frameworks
3394         https://bugs.webkit.org/show_bug.cgi?id=186016
3395         <rdar://problem/40591038>
3396
3397         Reviewed by Sam Weinig.
3398
3399         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3400           LaunchServices header.
3401         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3402           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3403         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3404           when using SDKs earlier than 10.13.
3405         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3406           and OTHER_CPLUSPLUSFLAGS.
3407         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3408           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3409         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3410           LaunchServices header.
3411
3412 2019-01-11  John Wilander  <wilander@apple.com>
3413
3414         Compile out Web API Statistics Collection
3415         https://bugs.webkit.org/show_bug.cgi?id=193370
3416         <rdar://problem/45388584>
3417
3418         Reviewed by Brent Fulgham.
3419
3420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3421             Defined ENABLE_WEB_API_STATISTICS, off by default.
3422
3423 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3424
3425         [WPE] Add gtk-doc
3426         https://bugs.webkit.org/show_bug.cgi?id=178900
3427
3428         Reviewed by Michael Catanzaro.
3429
3430         Add Tools/gtkdoc to manifest.txt.in files.
3431         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3432
3433         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3434         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3435
3436 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3437
3438         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3439         https://bugs.webkit.org/show_bug.cgi?id=193364
3440         <rdar://problem/47214117>
3441
3442         Reviewed by Tim Horton.
3443
3444         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3445         precise, whereas dragging near the middle of the textarea does.
3446
3447         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3448         (TestWebKitAPI::TEST):
3449
3450 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3451
3452         webkitpy: Support alternate simctl device list output
3453         https://bugs.webkit.org/show_bug.cgi?id=193362
3454         <rdar://problem/47122965>
3455
3456         Reviewed by Lucas Forschler.
3457
3458         * Scripts/webkitpy/xcode/simulated_device.py:
3459         (SimulatedDeviceManager.populate_available_devices):
3460
3461 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3462
3463         [ews-build] Update macOS queue configurations
3464         https://bugs.webkit.org/show_bug.cgi?id=193365
3465
3466         Reviewed by Lucas Forschler.
3467
3468         * BuildSlaveSupport/ews-build/config.json:
3469
3470 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3471
3472         webkitpy: Incorporate device type into baseline search path
3473         https://bugs.webkit.org/show_bug.cgi?id=193356
3474         <rdar://problem/47215515>
3475
3476         Reviewed by Lucas Forschler.
3477
3478         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3479
3480         * Scripts/webkitpy/port/base.py:
3481         (Port.default_baseline_search_path): Allow device type to be passed in.
3482         * Scripts/webkitpy/port/gtk.py:
3483         (GtkPort.default_baseline_search_path): Ignore device type.
3484         * Scripts/webkitpy/port/ios.py:
3485         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3486         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3487         * Scripts/webkitpy/port/ios_device_unittest.py:
3488         (IOSDeviceTest):
3489         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3490         (IOSSimulatorTest):
3491         * Scripts/webkitpy/port/mac.py:
3492         (MacPort.default_baseline_search_path): Ignore device type.
3493         * Scripts/webkitpy/port/watch.py:
3494         (WatchPort.default_baseline_search_path): Ditto.
3495         * Scripts/webkitpy/port/win.py:
3496         (WinPort.default_baseline_search_path): Ditto.
3497         (WinCairoPort.default_baseline_search_path): Ditto.
3498         * Scripts/webkitpy/port/wpe.py:
3499         (WPEPort.default_baseline_search_path): Ditto.
3500
3501 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3502
3503         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3504         https://bugs.webkit.org/show_bug.cgi?id=193352
3505         <rdar://problem/47210736>
3506
3507         Reviewed by Lucas Forschler.
3508
3509         * Scripts/webkitpy/layout_tests/views/printing.py:
3510         (Printer.print_config): Print list on only baseline search paths which exist. 
3511         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3512         (Testprinter.test_print_config):
3513
3514 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3515
3516         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3517         https://bugs.webkit.org/show_bug.cgi?id=193340
3518
3519         Reviewed by David Kilzer.
3520
3521         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3522         (WTR::InjectedBundle::didReceiveMessageToPage):
3523         Pull the strings out into a WKRetainPtr.
3524
3525         * WebKitTestRunner/WebNotificationProvider.cpp:
3526         (WTR::WebNotificationProvider::closeWebNotification):
3527         Adopt the created value into the WKRetainPtr.
3528
3529         * WebKitTestRunner/mac/TestControllerMac.mm:
3530         (WTR::generateWhitelist):
3531         Immediately adopt a created value to avoid potential mistakes.
3532
3533 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3534
3535         Enable DFG on ARM/Linux again
3536         https://bugs.webkit.org/show_bug.cgi?id=192496
3537
3538         Reviewed by Yusuke Suzuki.
3539
3540         After changing the bytecode format DFG was disabled on all 32-bit
3541         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3542         on ARM by default.
3543
3544         * Scripts/run-jsc-stress-tests:
3545
3546 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3547
3548         Unreviewed, fix #ifdef in API test added in r239851.
3549         https://bugs.webkit.org/show_bug.cgi?id=193327
3550         rdar://problem/47093222
3551
3552         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3553
3554 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3555
3556         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3557         https://bugs.webkit.org/show_bug.cgi?id=193109
3558         <rdar://problem/44807048>
3559
3560         Reviewed by Ryosuke Niwa.
3561
3562         Introduce and respect a test option to enable the UndoManager API.
3563
3564         * WebKitTestRunner/TestController.cpp:
3565         (WTR::updateTestOptionsFromTestHeader):
3566         * WebKitTestRunner/TestOptions.h:
3567         (WTR::TestOptions::hasSameInitializationOptions const):
3568         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3569         (WTR::TestController::platformCreateWebView):
3570
3571 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3572
3573         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3574         https://bugs.webkit.org/show_bug.cgi?id=193346
3575
3576         Reviewed by Antti Koivisto.
3577
3578         * LayoutReloaded/misc/LFC-passing-tests.txt:
3579
3580 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3581
3582         Unreviewed, fix typo that breaks dashboard link.
3583
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3585         (WebKitBuildbot):
3586
3587 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3588
3589         Update macOS queue configurations
3590         https://bugs.webkit.org/show_bug.cgi?id=193329
3591
3592         Reviewed by Alexey Proskuryakov.
3593
3594         * BuildSlaveSupport/build.webkit.org-config/config.json:
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3596         (BubbleQueueServer):
3597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3599         (WebKitBuildbot):
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3601         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3602         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3603
3604 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3605
3606         MiniBrowser should be able to navigate to about:blank
3607         https://bugs.webkit.org/show_bug.cgi?id=193345
3608
3609         Reviewed by Simon Fraser.
3610
3611         * MiniBrowser/mac/BrowserWindowController.m:
3612         (-[BrowserWindowController addProtocolIfNecessary:]):
3613         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3614
3615         * MiniBrowser/mac/WK1BrowserWindowController.m:
3616         (-[WK1BrowserWindowController fetch:]):
3617         * MiniBrowser/mac/WK2BrowserWindowController.m:
3618         (-[WK2BrowserWindowController fetch:]):
3619         Clean up the code that uses this to match style.
3620
3621 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3622
3623         Remove MiniBrowser custom "Process Swap" menu item which does not work
3624         https://bugs.webkit.org/show_bug.cgi?id=193344
3625
3626         Reviewed by Simon Fraser.
3627
3628         There is a menu item under the Experimental menu that does work.
3629
3630         * MiniBrowser/mac/AppDelegate.m:
3631         (defaultConfiguration):
3632         * MiniBrowser/mac/SettingsController.h:
3633         * MiniBrowser/mac/SettingsController.m:
3634         (-[SettingsController _populateMenu]):
3635         (-[SettingsController validateMenuItem:]):
3636         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3637         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3638
3639 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3640
3641         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3642         https://bugs.webkit.org/show_bug.cgi?id=193327
3643         rdar://problem/47093222
3644
3645         Reviewed by Tim Horton.
3646
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3649         (TestWebKitAPI::didFinishNavigation):
3650         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3651         (TestWebKitAPI::TEST):
3652         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3653         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3654         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3655         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3656         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3657
3658 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3659
3660         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3661         https://bugs.webkit.org/show_bug.cgi?id=193338
3662         <rdar://problem/46664774>
3663
3664         Reviewed by David Kilzer.
3665
3666         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3667         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3668
3669 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3670
3671         Unreviewed, rolling out r239825.
3672         https://bugs.webkit.org/show_bug.cgi?id=193330
3673
3674         Broke tests on armv7/linux bots (Requested by guijemont on
3675         #webkit).
3676
3677         Reverted changeset:
3678
3679         "Enable DFG on ARM/Linux again"
3680         https://bugs.webkit.org/show_bug.cgi?id=192496
3681         https://trac.webkit.org/changeset/239825
3682
3683 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3684
3685         Disable the run-jsc-stress-test remote host key check.
3686         https://bugs.webkit.org/show_bug.cgi?id=192988
3687
3688         Reviewed by Alexey Proskuryakov.
3689
3690         * Scripts/run-jsc-stress-tests:
3691
3692 2019-01-10  John Wilander  <wilander@apple.com>
3693
3694         Override the session configuration for cookieAcceptPolicy
3695         https://bugs.webkit.org/show_bug.cgi?id=190925
3696         <rdar://problem/45497382>
3697
3698         Reviewed by Alexey Proskuryakov and Alex Christensen.
3699
3700         Test infrastructure for setting a first-party-only cookie policy.
3701
3702         * DumpRenderTree/TestRunner.cpp:
3703         (setOnlyAcceptFirstPartyCookiesCallback):
3704         (TestRunner::staticFunctions):
3705         * DumpRenderTree/TestRunner.h:
3706         * DumpRenderTree/mac/TestRunnerMac.mm:
3707         (TestRunner::setOnlyAcceptFirstPartyCookies):
3708         * DumpRenderTree/win/TestRunnerWin.cpp:
3709         (TestRunner::setOnlyAcceptFirstPartyCookies):
3710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3712         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3714         * WebKitTestRunner/TestInvocation.cpp:
3715         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3716
3717 2019-01-09  Matt Rajca  <mrajca@apple.com>
3718
3719         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3720         https://bugs.webkit.org/show_bug.cgi?id=193301
3721
3722         Reviewed by Jer Noble.
3723         
3724         Added API tests.
3725
3726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3727         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3728         (TEST):
3729         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3730
3731 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3732
3733         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3734         https://bugs.webkit.org/show_bug.cgi?id=193310
3735
3736         Reviewed by Antti Koivisto.
3737
3738         * LayoutReloaded/misc/LFC-passing-tests.txt:
3739
3740 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3741
3742         Enable DFG on ARM/Linux again
3743         https://bugs.webkit.org/show_bug.cgi?id=192496
3744
3745         Reviewed by Yusuke Suzuki.
3746
3747         After changing the bytecode format DFG was disabled on all 32-bit
3748         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3749         on ARM by default.
3750
3751         * Scripts/run-jsc-stress-tests:
3752
3753 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3754
3755         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3756         https://bugs.webkit.org/show_bug.cgi?id=193271
3757
3758         Reviewed by Brent Fulgham.
3759
3760         BSTR is a special data structure created by SysAllocString, not a
3761         wchar_t null-terminated string.
3762
3763         * DumpRenderTree/win/TestRunnerWin.cpp:
3764         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3765         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3766         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3767         BSTR from wide string literals.
3768
3769 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3770
3771         Tweak wording for build/version_check style checker error
3772         https://bugs.webkit.org/show_bug.cgi?id=193256
3773
3774         Reviewed by Tim Horton.
3775
3776         * Scripts/webkitpy/style/checkers/cpp.py:
3777         (check_os_version_checks):
3778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3779         (WebKitStyleTest.test_os_version_checks):
3780
3781 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3782
3783         [ews-build] Add link to bug along with bug title
3784         https://bugs.webkit.org/show_bug.cgi?id=193293
3785
3786         Reviewed by Lucas Forschler.
3787
3788         * BuildSlaveSupport/ews-build/steps.py:
3789         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3790         (ConfigureBuild.add_bug_id_url): Deleted.
3791         (ConfigureBuild.getBugURL): Deleted.
3792
3793 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3794
3795         [ews-build] Use https for ews-build server
3796         https://bugs.webkit.org/show_bug.cgi?id=193193
3797
3798         Reviewed by Lucas Forschler.
3799
3800         * BuildSlaveSupport/ews-build/steps.py:
3801
3802 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3803
3804         [ews-build] Parse and display number of style failures
3805         https://bugs.webkit.org/show_bug.cgi?id=193280
3806
3807         Reviewed by Lucas Forschler.
3808
3809         * BuildSlaveSupport/ews-build/steps.py:
3810         (CheckStyle): Use TestWithFailureCount as base class.
3811         (CheckStyle.countFailures): Count the number of style failures.
3812
3813 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3814
3815         [ews-build] use patch_id instead of ewspatchid
3816         https://bugs.webkit.org/show_bug.cgi?id=193235
3817
3818         Reviewed by Lucas Forschler.
3819
3820         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3821         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3822         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3823
3824 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3825
3826         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3827         https://bugs.webkit.org/show_bug.cgi?id=192625
3828
3829         Reviewed by Antti Koivisto.
3830
3831         * LayoutReloaded/misc/LFC-passing-tests.txt:
3832
3833 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3834
3835         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3836         https://bugs.webkit.org/show_bug.cgi?id=192841
3837
3838         Reviewed by Carlos Garcia Campos.
3839
3840         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3841         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3842         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3843
3844         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3845
3846         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3847         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3848         (WebKitWebEditorTest::testSelectionChanged):
3849         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3850         (WebKitFrameTest::testMainFrame):
3851         (WebKitFrameTest::testURI):
3852         (WebKitFrameTest::testJavaScriptContext):
3853         (WebKitFrameTest::testJavaScriptValues):
3854         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3855         (testWebViewAuthenticationRequest):
3856         (testWebViewAuthenticationLoadCancelled):
3857         (testWebViewAuthenticationFailure):
3858         (testWebViewAuthenticationStorage):
3859         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3860         (testWebViewAuthenticationProxy):
3861         (testWebViewAuthenticationProxyHTTPS):
3862         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3863         (testAutomationSessionRequestSession):
3864         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3865         (testBackForwardListNavigation):
3866         (testWebKitWebViewSessionState):
3867         (testWebKitWebViewSessionStateWithFormData):
3868         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3869         (ConsoleMessageTest::consoleMessageReceivedCallback):
3870         (testWebKitConsoleMessageConsoleAPI):
3871         (testWebKitConsoleMessageJavaScriptException):
3872         (testWebKitConsoleMessageNetworkError):
3873         (testWebKitConsoleMessageSecurityError):
3874         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3875         (testCookieManagerAcceptPolicy):
3876         (testCookieManagerCookiesChanged):
3877         (testCookieManagerPersistentStorage):
3878         (testCookieManagerPersistentStorageDeleteAll):
3879         (testCookieManagerEphemeral):
3880         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3881         (testWebKitDOMElementAutoFill):
3882         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3883         (downloadLocalFileSuccessfully):
3884         (createFileAtDestination):
3885         (testDownloadOverwriteDestinationDisallowed):
3886         (testDownloadLocalFileError):
3887         (testDownloadRemoteFile):
3888         (testDownloadRemoteFileError):
3889         (testWebViewDownloadURI):
3890         (testPolicyResponseDownload):
3891         (testPolicyResponseDownloadCancel):
3892         (testDownloadMIMEType):
3893         (contextMenuCallback):
3894         (testContextMenuDownloadActions):
3895         (testBlobDownload):
3896         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3897         (testWebKitWebEditorSelectionChanged):
3898         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3899         (testWebKitFrameMainFrame):
3900         (testWebKitFrameURI):
3901         (testWebKitFrameJavaScriptContext):
3902         (testWebKitFrameJavaScriptValues):
3903         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3904         (LoadStopTrackingTest::loadFailed):
3905         (testWebViewTitle):
3906         (testURIRequestHTTPHeaders):
3907         (testURIRequestHTTPMethod):
3908         (testURIResponseHTTPHeaders):
3909         (testRedirectToDataURI):
3910         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3911         (testProcessPerWebView):
3912         (testWebProcessLimit):
3913         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3914         (testWebViewResources):
3915         (testWebResourceLoading):
3916         (testWebResourceSuggestedFilename):
3917         (testWebResourceGetData):
3918         (testWebResourceGetDataError):
3919         (testWebViewResourcesHistoryCache):
3920         (testWebResourceSendRequest):
3921         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3922         (testSSL):
3923         (testInsecureContent):
3924         (testTLSErrorsPolicy):
3925         (testTLSErrorsRedirect):
3926         (testTLSErrorsHTTPAuth):
3927         (testLoadFailedWithTLSErrors):
3928         (testSubresourceLoadFailedWithTLSErrors):
3929         (httpsServerCallback):
3930         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3931         (testWebViewCreateNavigationData):
3932         (testWebViewJavaScriptDialogs):
3933         (testWebViewWindowProperties):
3934         (testWebViewMouseTarget):
3935         (testWebViewFileChooserRequest):
3936         (testWebViewColorChooserRequest):
3937         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3938         (testWebExtensionGetTitle):
3939         (testDocumentLoadedSignal):
3940         (testWebKitWebViewProcessCrashed):
3941         (testWebExtensionWindowObjectCleared):
3942         (testWebExtensionIsolatedWorld):
3943         (permissionRequestCallback):
3944         (didAssociateFormControlsCallback):
3945         (testWebExtensionFormControlsAssociated):
3946         (FormSubmissionTest::FormSubmissionTest):
3947         (FormSubmissionTest::testFormSubmissionResult):
3948         (testWebExtensionFormSubmissionSteps):
3949         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3950         (testNotInitialized):
3951         (testClearDatabase):
3952         (testPrivateBrowsing):
3953         (testGetFavicon):
3954         (testWebViewFavicon):
3955         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3956         (testFindControllerTextFound):
3957         (testFindControllerTextNotFound):
3958         (testFindControllerMatchCount):
3959         (testFindControllerMaxMatchCount):
3960         (testFindControllerNext):
3961         (testFindControllerPrevious):
3962         (testFindControllerCountedMatches):
3963         (testFindControllerOptions):
3964         (testFindControllerHide):
3965         (testFindControllerInstance):
3966         (testFindControllerGetters):
3967         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3968         (testNavigationPolicy):
3969         (testResponsePolicy):
3970         (testNewWindowPolicy):
3971         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3972         (testSecurityOriginBasicConstructor):
3973         (testSecurityOriginURIConstructor):
3974         (testSecurityOriginDefaultPort):
3975         (testSecurityOriginFileURI):
3976         (testOpaqueSecurityOrigin):
3977         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3978         (testWebKitSettings):
3979         (testWebKitSettingsNewWithSettings):
3980         (testWebKitSettingsUserAgent):
3981         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3982         (testWebViewNewWithUserContentManager):
3983         (isStyleSheetInjectedForURLAtPath):
3984         (isScriptInjectedForURLAtPath):
3985         (testUserContentManagerInjectedStyleSheet):
3986         (testUserContentManagerInjectedScript):
3987         (UserScriptMessageTest::scriptMessageReceived):
3988         (UserScriptMessageTest::waitUntilMessageReceived):
3989         (UserScriptMessageTest::runJavaScriptFinished):
3990         (testUserContentManagerScriptMessageReceived):
3991         (testUserContentManagerScriptMessageInWorldReceived):
3992         (testUserContentManagerScriptMessageFromDOMBindings):
3993         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3994         (testWebContextDefault):
3995         (testWebContextEphemeral):
3996         (testWebContextGetPlugins):
3997         (testWebContextURIScheme):
3998         (testWebContextSpellChecker):
3999         (testWebContextLanguages):
4000         (consoleMessageReceivedCallback):
4001         (testWebContextSecurityFileXHR):
4002         (ProxyTest::ProxyTest):
4003         (testWebContextProxySettings):
4004         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4005         (testWebViewWebContext):
4006         (testWebViewWebBackend):
4007         (testWebViewEphemeral):
4008         (testWebViewCustomCharset):
4009         (testWebViewSettings):
4010         (testWebViewRunJavaScript):
4011         (testWebViewCanShowMIMEType):
4012         (testWebViewSubmitForm):
4013         (testWebViewSave):
4014         (testWebViewPageVisibility):
4015         (testWebViewSnapshot):
4016         (testWebViewNotification):
4017         (testWebViewNotificationInitialPermissionAllowed):
4018         (testWebViewNotificationInitialPermissionDisallowed):
4019         (testWebViewIsPlayingAudio):
4020         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4021         (WebsiteDataTest::WebsiteDataTest):
4022         (WebsiteDataTest::remove):
4023         (WebsiteDataTest::clear):
4024         (testWebsiteDataConfiguration):
4025         (testWebsiteDataEphemeral):
4026         (testWebsiteDataCache):
4027         (testWebsiteDataStorage):
4028         (testWebsiteDataDatabases):
4029         (testWebsiteDataAppcache):
4030         (testWebsiteDataCookies):
4031         (testWebsiteDataDeviceIdHashSalt):
4032         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4033         (emitDocumentLoaded):
4034         (emitURIChanged):
4035         (sendRequestCallback):
4036         (contextMenuCallback):
4037         (consoleMessageSentCallback):
4038         (emitFormControlsAssociated):
4039         (formControlsAssociatedCallback):
4040         (emitFormSubmissionEvent):
4041         (willSubmitFormCallback):
4042         (windowObjectCleared):
4043         (methodCallCallback):
4044         (registerGResource):
4045         (webkit_web_extension_initialize_with_user_data):
4046         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4047         (checkLeaks):
4048         (WebProcessTest::create):
4049         (runTest):
4050         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4051         (AutocleanupsTest::testWebProcessAutocleanups):
4052         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4053         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4054         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4055         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4056         (WebKitDOMDOMWindowTest::testSignals):
4057         (WebKitDOMDOMWindowTest::testDispatchEvent):
4058         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4059         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4060         (WebKitDOMNodeFilterTest::testTreeWalker):
4061         (WebKitDOMNodeFilterTest::testNodeIterator):
4062         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4063         (WebKitDOMNodeTest::testHierarchyNavigation):
4064         (WebKitDOMNodeTest::testInsertion):
4065         (WebKitDOMNodeTest::testTagNamesNodeList):
4066         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4067         (WebKitDOMNodeTest::testDOMCache):
4068         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4069         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4070         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4071         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4072         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4073         (testUIProcessAutocleanups):
4074         (testWebProcessAutocleanups):
4075         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4076         (testContextMenuPopulateMenu):
4077         (testContextMenuDismissed):
4078         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4079         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4080         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4081         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4082         (testWebKitDOMDOMWindowSignals):
4083         (testWebKitDOMDOMWindowDispatchEvent):
4084         (testWebKitDOMDOMWindowGetComputedStyle):
4085         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4086         (testWebKitDOMNodeHierarchyNavigation):
4087         (testWebKitDOMNodeInsertion):
4088         (testWebKitDOMNodeTagNamesNodeList):
4089         (testWebKitDOMNodeTagNamesHTMLCollection):
4090         (testWebKitDOMObjectCache):
4091         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4092         (testWebKitDOMNodeFilterTreeWalker):
4093         (testWebKitDOMNodeFilterNodeIterator):
4094         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4095         (testWebKitDOMXPathNSResolverNative):
4096         (testWebKitDOMXPathNSResolverCustom):
4097         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4098         (testInspectorDefault):
4099         (testInspectorManualAttachDetach):
4100         (testInspectorCustomContainerDestroyed):
4101         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4102         (startTestServer):
4103         (testInspectorServerPageList):
4104         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4105         (OptionMenuTest::showOptionMenuCallback):
4106         (OptionMenuTest::menuCloseCallback):
4107         (OptionMenuTest::close):
4108         (OptionMenuTest::activateItem):
4109         (OptionMenuTest::selectItem):
4110         (testOptionMenuSimple):
4111         (testOptionMenuGroups):
4112         (testOptionMenuActivate):
4113         (testOptionMenuSelect):
4114         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4115         (testPrintOperationPrintSettings):
4116         (webViewPrintCallback):
4117         (testPrintOperationPrint):
4118         (testPrintCustomWidget):
4119         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4120         (checkAtspiAccessible):
4121         (testAtspiBasicHierarchy):
4122         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4123         (testWebKitCheckVersion):
4124         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4125         (testWebViewEditorCutCopyPasteNonEditable):
4126         (testWebViewEditorCutCopyPasteEditable):
4127         (testWebViewEditorSelectAllNonEditable):
4128         (testWebViewEditorSelectAllEditable):
4129         (loadContentsAndTryToCutSelection):
4130         (testWebViewEditorNonEditable):
4131         (testWebViewEditorEditable):
4132         (testWebViewEditorEditorStateTypingAttributes):
4133         (testWebViewEditorInsertImage):
4134         (testWebViewEditorCreateLink):
4135         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4136         (loadChangedCallback):
4137         (loadFailedCallback):
4138         (loadFailedWithTLSErrorsCallback):
4139         (LoadTrackingTest::LoadTrackingTest):
4140         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4141         (registerGResource):
4142         (removeNonEmptyDirectory):
4143         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4144         (Test::adoptView):
4145         (Test::~Test):
4146         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4147         (WebKitTestBus::getOrCreateConnection):
4148         (WebKitTestBus::createProxy):
4149         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4150         (WebKitTestServer::getWebSocketURIForPath const):
4151         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4152         (WebViewTest::initializeWebView):
4153         (WebViewTest::loadURI):
4154         (WebViewTest::loadHtml):
4155         (WebViewTest::loadPlainText):
4156         (WebViewTest::loadBytes):
4157         (WebViewTest::loadRequest):
4158         (WebViewTest::loadAlternateHTML):
4159         (WebViewTest::goBack):
4160         (WebViewTest::goForward):
4161         (WebViewTest::goToBackForwardListItem):
4162         (resourceGetDataCallback):
4163         (WebViewTest::mainResourceData):
4164         (WebViewTest::javascriptResultToCString):
4165         (WebViewTest::javascriptResultToNumber):
4166         (WebViewTest::javascriptResultToBoolean):
4167         (WebViewTest::javascriptResultIsNull):
4168         (WebViewTest::javascriptResultIsUndefined):
4169         (onSnapshotReady):
4170         (WebViewTest::runWebProcessTest):
4171         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4172         (WebViewTest::platformInitializeWebView):
4173         (WebViewTest::showInWindow):
4174         (WebViewTest::showInWindowAndWaitUntilMapped):
4175         (WebViewTest::mouseMoveTo):
4176         (WebViewTest::emitPopupMenuSignal):
4177         (WebViewTest::keyStroke):
4178         (WebViewTest::doMouseButtonEvent):
4179
4180 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4181
4182         [WPE] API tests can't run in flatpak environment
4183         https://bugs.webkit.org/show_bug.cgi?id=193242
4184
4185         Reviewed by Michael Catanzaro.
4186
4187         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4188         flatpakutils so that it knows which port it's dealing with.
4189         * glib/common.py: Remove build_dir globals so that subsequent
4190         calls actually take args into account.
4191         (library_build_path):
4192         (binary_build_path):
4193
4194 2019-01-08  Dean Jackson  <dino@apple.com>
4195
4196         Blob references for System Previews don't get a correct file extension
4197         https://bugs.webkit.org/show_bug.cgi?id=193268
4198         <rdar://problem/47133037>
4199
4200         Reviewed by Tim Horton.
4201
4202         New test that a Blob download of a USDZ file gets named correctly.
4203
4204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4205         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4206         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4207         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4208         (TEST):
4209         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4210
4211 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4212
4213         [WebAuthN] Support U2F HID Authenticators on macOS
4214         https://bugs.webkit.org/show_bug.cgi?id=191535
4215         <rdar://problem/47102027>
4216
4217         Reviewed by Brent Fulgham.
4218
4219         This patch:
4220         1) adds support for U2F mocking mechanism;
4221         2) updates tests to reflect U2fCommandConstructor changes.
4222
4223         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4224         (TestWebKitAPI::TEST):
4225         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4227         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4228
4229 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4230
4231         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4232         https://bugs.webkit.org/show_bug.cgi?id=193229
4233         <rdar://problem/46717097>
4234
4235         Reviewed by Tim Horton.
4236
4237         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4238         prevents a drag from starting.
4239
4240         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4241         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4242
4243         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4244
4245 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4246   
4247         Layout test will generate a perf metric file to results dir.
4248         https://bugs.webkit.org/show_bug.cgi?id=192030
4249         <rdar://problem/32779516>
4250
4251         Reviewed by Aakash Jain.
4252
4253         Layout test running time will be collected to a perf metric file.
4254         For now, instead of outputing running time of all tests (which is huge),
4255         we aggregate them by test directories which are at most two level deep. 
4256
4257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4258         (Manager._end_test_run):
4259         (Manager._output_perf_metrics):
4260         (Manager._print_expectation_line_for_test):
4261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4262         (add_test_perf_metric):
4263         (test_perf_metrics):
4264         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4265         (JSONGeneratorTest.test_test_timings_trie):
4266         (JSONGeneratorTest):
4267         (JSONGeneratorTest.test_test_perf_metrics):
4268         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4269         (RebaselineTest.test_reset_results):
4270         (RebaselineTest.test_missing_results):
4271         (RebaselineTest.test_new_baseline):
4272
4273 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
4274
4275         [WPE][GTK] Add php-json to install-dependencies
4276         https://bugs.webkit.org/show_bug.cgi?id=193233
4277
4278         Reviewed by Michael Catanzaro.
4279
4280         * gtk/install-dependencies:
4281         * wpe/install-dependencies:
4282
4283 2019-01-08  Chris Dumez  <cdumez@apple.com>
4284
4285         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4286         https://bugs.webkit.org/show_bug.cgi?id=193224
4287         <rdar://problem/47097726>
4288
4289         Reviewed by Alex Christensen.
4290
4291         Add API test coverage.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4294
4295 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4296
4297         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4298         <https://webkit.org/b/193222>
4299         <rdar://problem/46862309>
4300
4301         Reviewed by Joseph Pecoraro.
4302
4303         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4304         (WTR::executeCallback): Fix camel case of variable name.
4305         (WTR::EventSendingController::callAfterScrollingCompletes): If
4306         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4307         false, make sure to release the ScrollCompletionCallbackData
4308         object.  This fixes the leak.
4309
4310 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4311
4312         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4313         https://bugs.webkit.org/show_bug.cgi?id=193044
4314
4315         Reviewed by Daniel Bates.
4316
4317         WinCairo EWS bots are using Windows Perl. Binary files should be
4318         opened as binary mode.
4319
4320         * Scripts/svn-apply:
4321         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4322
4323 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4324