Add Optional to Forward.h.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2
3         Add Optional to Forward.h.
4         https://bugs.webkit.org/show_bug.cgi?id=195586
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
9         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
10         Remove unnecessary includes from headers.
11
12 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
13
14         Add testing API to hit-test and scroll overflow scrollers
15         https://bugs.webkit.org/show_bug.cgi?id=195278
16
17         Reviewed by Antti Koivisto.
18         
19         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
20         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
21         
22         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
23
24         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
25         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
26         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
27         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
28         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
29         * TestRunnerShared/UIScriptContext/UIScriptController.h:
30         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
31         (WTR::enclosingScrollViewIncludingSelf):
32         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
33
34 2019-03-11  Tim Horton  <timothy_horton@apple.com>
35
36         API test WebKit.RequestTextInputContext fails on iOS
37         https://bugs.webkit.org/show_bug.cgi?id=195585
38
39         Reviewed by Wenson Hsieh and Simon Fraser.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
42         (applyStyle):
43         (TEST):
44         Add a viewport, so that the coordinates match up on iOS.
45         Scroll by moving the UIScrollView's contentOffset.
46
47 2019-03-11  Chris Dumez  <cdumez@apple.com>
48
49         Assert in WebPageProxy::suspendCurrentPageIfPossible()
50         https://bugs.webkit.org/show_bug.cgi?id=195506
51         <rdar://problem/48733477>
52
53         Reviewed by Alex Christensen.
54
55         Add API test coverage.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
58
59 2019-03-11  Shawn Roberts  <sroberts@apple.com>
60
61         Adding myself to contributors.json
62
63         Unreviewed, addming myself to contributors.json .
64
65         * Scripts/webkitpy/common/config/contributors.json:
66
67 2019-03-11  Alex Christensen  <achristensen@webkit.org>
68
69         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
70         https://bugs.webkit.org/show_bug.cgi?id=195511
71         <rdar://problem/44873269>
72
73         Reviewed by Darin Adler.
74
75         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
76         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
77         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
78         (TEST_F):
79
80 2019-03-11  Chris Dumez  <cdumez@apple.com>
81
82         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
83         https://bugs.webkit.org/show_bug.cgi?id=195561
84
85         Reviewed by Youenn Fablet.
86
87         Make sure the JS in the test requests for permission to receive device orientation events.
88
89         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
90
91 2019-03-11  Youenn Fablet  <youenn@apple.com>
92
93         Allow storage quota increase by default in WTR
94         https://bugs.webkit.org/show_bug.cgi?id=195541
95
96         Reviewed by Geoffrey Garen.
97
98         Allow storage quota increase by default in WTR.
99         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
100         Use this for tests that explicitly need cache increase.
101
102         Instead of increasing quota by 2, make sure the next request is
103         granted by adding all given parameters.
104
105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
107         (WTR::TestRunner::setAllowStorageQuotaIncrease):
108         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::setAllowStorageQuotaIncrease):
112         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
113         * WebKitTestRunner/TestController.h:
114         * WebKitTestRunner/TestInvocation.cpp:
115         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
116         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
117         (WTR::TestController::cocoaResetStateToConsistentValues):
118         (WTR::TestController::setAllowStorageQuotaIncrease):
119         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
120         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
121         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
122
123 2019-03-11  Xan Lopez  <xan@igalia.com>
124
125         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
126         https://bugs.webkit.org/show_bug.cgi?id=194147
127
128         Reviewed by Michael Saboff.
129
130         To make --32-bit work correctly on Linux/64bit we need to:
131
132         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
133         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
134         unfortunately CMake only allows us to do this during
135         crosscompilation, which is overkill here.
136         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
137         pkg-config detection module uses the x86 .pc files instead of the
138         x86_64 ones.
139         - Set the -m32 flags for the compiler.
140
141         * Scripts/webkitdirs.pm:
142         (generateBuildSystemFromCMakeProject):
143
144 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
145
146         Add MotionMark-1.1 plan file for run-benchmark script.
147         https://bugs.webkit.org/show_bug.cgi?id=195481
148
149         Rubber-stamped by Darin Adler.
150
151         Run-benchmark script should support MontionMark-1.1.
152
153         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
154
155 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-app] Add support for submit-to-ews url
158         https://bugs.webkit.org/show_bug.cgi?id=195477
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-app/ews/fetcher.py:
163         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
164         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
165         * BuildSlaveSupport/ews-app/ews/urls.py:
166         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
167
168 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
169
170         Unreviewed, rolling out r242688, r242643, r242624.
171
172         Caused multiple layout test failures and crashes on iOS and macOS.
173
174         Reverted changeset:
175
176         "requestAnimationFrame should execute before the next frame"
177         https://bugs.webkit.org/show_bug.cgi?id=177484
178         https://trac.webkit.org/changeset/242624/webkit
179
180         * Tracing/SystemTracePoints.plist:
181
182 2019-03-11  John Wilander  <wilander@apple.com>
183
184         Resource Load Statistics: Make it possible exclude localhost from classification
185         https://bugs.webkit.org/show_bug.cgi?id=195474
186         <rdar://problem/47520577>
187
188         Reviewed by Brent Fulgham.
189
190         This patch allows for localhost to be excluded from classification and
191         treatment as a prevalent resource.
192
193         The WebKit Tools change adds a new function called
194         testRunner.setStatisticsIsRunningTest() which can be used to control this
195         behavior.
196
197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
199         (WTR::TestRunner::setStatisticsIsRunningTest):
200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
201         * WebKitTestRunner/TestController.cpp:
202         (WTR::TestController::setStatisticsIsRunningTest):
203         * WebKitTestRunner/TestController.h:
204         * WebKitTestRunner/TestInvocation.cpp:
205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
206
207 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
208
209         [ews-build] Disable waterfall and console view for ews-build.webkit.org
210         https://bugs.webkit.org/show_bug.cgi?id=195560
211
212         Reviewed by Lucas Forschler.
213
214         * BuildSlaveSupport/ews-build/master.cfg:
215
216 2019-03-11  Alex Christensen  <achristensen@webkit.org>
217
218         Unreviewed, rolling out r242698.
219
220         API test crashes on bots.
221
222         Reverted changeset:
223
224         "Add a WKContentRuleList variant that uses copied memory
225         instead of mmap'd shared memory for class A containerized
226         apps"
227         https://bugs.webkit.org/show_bug.cgi?id=195511
228         https://trac.webkit.org/changeset/242698
229
230 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
231
232         [WPE] Enable web process sandbox
233         https://bugs.webkit.org/show_bug.cgi?id=195169
234
235         Reviewed by Daniel Bates.
236
237         * wpe/install-dependencies:
238         * wpe/jhbuild.modules:
239
240 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews-app] Use port 17000 for worker communication
243         https://bugs.webkit.org/show_bug.cgi?id=195558
244
245         Reviewed by Lucas Forschler.
246
247         * BuildSlaveSupport/ews-build/master.cfg:
248
249 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-build] unit-tests fail when passwords.json is missing
252         https://bugs.webkit.org/show_bug.cgi?id=195557
253
254         Reviewed by Lucas Forschler.
255
256         * BuildSlaveSupport/ews-build/loadConfig.py:
257         (loadBuilderConfig):
258         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
259         (ConfigDotJSONTest.test_configuration):
260         * BuildSlaveSupport/ews-build/master.cfg:
261
262 2019-03-11  Truitt Savell  <tsavell@apple.com>
263
264         Unreviewed, rolling out r242702.
265
266         Broke High Sierra builders.
267
268         Reverted changeset:
269
270         "Add utility function to allow easy reverse range-based
271         iteration of a container"
272         https://bugs.webkit.org/show_bug.cgi?id=195542
273         https://trac.webkit.org/changeset/242702
274
275 2019-03-11  Sam Weinig  <sam@webkit.org>
276
277         Add utility function to allow easy reverse range-based iteration of a container
278         https://bugs.webkit.org/show_bug.cgi?id=195542
279
280         Reviewed by Antti Koivisto.
281
282         * TestWebKitAPI/CMakeLists.txt:
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
285         (TestWebKitAPI::TEST):
286         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
287
288 2019-03-10  Alex Christensen  <achristensen@webkit.org>
289
290         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
291         https://bugs.webkit.org/show_bug.cgi?id=195511
292         <rdar://problem/44873269>
293
294         Reviewed by Darin Adler.
295
296         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
297         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
298         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
299         (TEST_F):
300
301 2019-03-10  Tim Horton  <timothy_horton@apple.com>
302
303         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
304         https://bugs.webkit.org/show_bug.cgi?id=195499
305
306         Reviewed by Darin Adler.
307
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
310         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
311         (-[WKWebView synchronouslyFocusTextInputContext:]):
312         (applyStyle):
313         (applyIframe):
314         (TEST):
315         Add some tests for this SPI.
316
317 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
318
319         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
320         https://bugs.webkit.org/show_bug.cgi?id=181151
321
322         Reviewed by Don Olmstead.
323
324         * TestWebKitAPI/CMakeLists.txt:
325         * TestWebKitAPI/PlatformWin.cmake:
326         Enable TestWTF RunLoop tests in all platforms.
327
328         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
329         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
330         (TestWebKitAPI::DerivedOneShotTimer::fired):
331         (TestWebKitAPI::TEST):
332         Only a few platforms support nested RunLoop.
333
334         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
335         (TestWebKitAPI::DerivedRepeatingTimer::fired):
336
337 2019-03-10  David Quesada  <david_quesada@apple.com>
338
339         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
340         https://bugs.webkit.org/show_bug.cgi?id=152480
341
342         Reviewed by Chris Dumez.
343
344         Add a unit test based on Daniel Bates's test case that starts a download, ensures
345         there are no additional references to the process pool besides the one held by
346         the download, waits for the download to finish (in the sense that the
347         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
348         measure, also check that the process pool has been deallocated at the end of the
349         test. The test wouldn't be meaningful if the process pool were still alive.
350
351         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
352         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
353         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
354             The download will be canceled because the delegate does not implement the
355             method to decide the download's destination, so this is where we know the
356             DownloadProxyMap is done with the DownloadProxy.
357         (TEST):
358
359 2019-03-08  Chris Dumez  <cdumez@apple.com>
360
361         Add support for Device Orientation / Motion permission API
362         https://bugs.webkit.org/show_bug.cgi?id=195329
363         <rdar://problem/47645367>
364
365         Reviewed by Geoffrey Garen.
366
367         Add test infrastructure to help test the Device Orientation / Motion permission API.
368
369         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
370         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
371         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
372         * WebKitTestRunner/InjectedBundle/TestRunner.h:
373         * WebKitTestRunner/TestController.cpp:
374         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
375         (WTR::TestController::createWebViewWithOptions):
376         (WTR::TestController::resetStateToConsistentValues):
377         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
378         * WebKitTestRunner/TestController.h:
379         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
380         * WebKitTestRunner/TestInvocation.cpp:
381         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
382
383 2019-03-08  Saam barati  <sbarati@apple.com>
384
385         Add a compare-results script to compare benchmark results
386         https://bugs.webkit.org/show_bug.cgi?id=195486
387         <rdar://problem/48723397>
388
389         Reviewed by Geoffrey Garen.
390
391         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
392         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
393         to extend it to learn about our other benchmarks.
394
395         * Scripts/compare-results: Added.
396         (readJSONFile):
397         (detectJetStream2):
398         (JetStream2Results):
399         (detectSpeedometer2):
400         (Speedometer2Results):
401         (detectPLT5):
402         (PLT5Results):
403         (detectBenchmark):
404         (biggerIsBetter):
405         (ttest):
406         (getOptions):
407         (main):
408
409 2019-03-08  Stephanie Lewis  <slewis@apple.com>
410
411         Ensure old tab state is cleared between iterations of run-benchmark
412         https://bugs.webkit.org/show_bug.cgi?id=195393
413         <rdar://problem/46885583>
414
415         Reviewed by Dewei Zhu.
416
417         a) ensure the default to restore state is not set
418         b) terminate Safari correctly
419         c) Set the system default to ignore Persistent State in Safari
420
421         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
422         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
423         (OSXBrowserDriver.prepare_env): 
424         (OSXBrowserDriver.restore_env):
425         (OSXBrowserDriver.close_browsers):
426         (OSXBrowserDriver._terminate_processes):
427         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
428         (OSXChromeDriver):
429         (OSXChromeCanaryDriver):
430         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
431         (OSXFirefoxDriver):
432         (OSXFirefoxNightlyDriver):
433         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
434         (OSXSafariDriver):
435         (OSXSafariDriver.prepare_env):
436
437 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
438
439         [GTK] Several InputMethodFilter tests are failing
440         https://bugs.webkit.org/show_bug.cgi?id=195408
441
442         Reviewed by Carlos Garcia Campos.
443
444         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
445         Regressed in r241751.
446         Hexadecimal values of keycodes are expressed now in upper letters.
447         Composited characters should be cast to UTF8 strings.
448
449         (TestWebKitAPI::TEST):
450
451 2019-03-07  Tomas Popela  <tpopela@redhat.com>
452
453         [GTK] Make Tools/gtkdoc python3 compatible
454         https://bugs.webkit.org/show_bug.cgi?id=195359
455
456         Reviewed by Carlos Garcia Campos.
457
458         * gtkdoc/generate-gtkdoc:
459         ConfigParser was reworked in Python 3.2 so we have adapt the code to
460         work with Python 2 and 3.
461         (get_gtkdoc_module_paths):
462         The iteritems() was removed in Python 3, so let's use items() that's
463         available in Python 2 and 3.
464         (get_generator_for_config):
465         * gtkdoc/gtkdoc.py:
466         (GTKDoc._run_command):
467         The sys.stdout.write() is expecting str in Python 3 and not bytes
468         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
469         for passing the bytes there.
470
471 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
472
473         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
474         https://bugs.webkit.org/show_bug.cgi?id=195346
475         <rdar://problem/48667048>
476
477         Unreviewed build fix for clang-cl.
478
479         * DumpRenderTree/win/DumpRenderTree.cpp:
480         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
481
482 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
483
484         requestAnimationFrame should execute before the next frame
485         https://bugs.webkit.org/show_bug.cgi?id=177484
486
487         Reviewed by Simon Fraser.
488
489         Add trace points for the page RenderingUpdate.
490
491         * Tracing/SystemTracePoints.plist:
492
493 2019-03-07  Zalan Bujtas  <zalan@apple.com>
494
495         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
496         https://bugs.webkit.org/show_bug.cgi?id=195353
497         <rdar://problem/48626394>
498
499         Reviewed by Simon Fraser.
500
501         * WebKitTestRunner/ios/TestControllerIOS.mm:
502         (WTR::TestController::platformResetPreferencesToConsistentValues):
503
504 2019-03-07  John Wilander  <wilander@apple.com>
505
506         Resource Load Statistics: Make it possible to purge only script-accessible cookies
507         https://bugs.webkit.org/show_bug.cgi?id=195383
508         <rdar://problem/48570136>
509
510         Reviewed by Brent Fulgham.
511
512         This patch adds test infrastructure to purge only script-accessible cookies,
513         including a new testRunner function called statisticsDeleteCookiesForHost().git a
514
515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
517         (WTR::TestRunner::statisticsDeleteCookiesForHost):
518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
519         * WebKitTestRunner/TestController.cpp:
520         (WTR::TestController::statisticsDeleteCookiesForHost):
521         * WebKitTestRunner/TestController.h:
522         * WebKitTestRunner/TestInvocation.cpp:
523         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
524
525 2019-03-07  Commit Queue  <commit-queue@webkit.org>
526
527         Unreviewed, rolling out r242354.
528         https://bugs.webkit.org/show_bug.cgi?id=195402
529
530         breaks layout tests in all configurations (Requested by
531         zdobersek on #webkit).
532
533         Reverted changeset:
534
535         "[WPE] Enable web process sandbox"
536         https://bugs.webkit.org/show_bug.cgi?id=195169
537         https://trac.webkit.org/changeset/242354
538
539 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
540
541         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
542         https://bugs.webkit.org/show_bug.cgi?id=195346
543
544         Reviewed by Fujii Hironori.
545
546         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
547         (TestWebKitAPI::TEST):
548         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
549
550         * DumpRenderTree/win/DumpRenderTree.cpp:
551         (findFontFallback):
552         (addFontFallbackIfPresent):
553         (removeFontFallbackIfPresent):
554         (main):
555         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
556         (TestWebKitAPI::Util::moduleDirectory):
557         (TestWebKitAPI::Util::createInjectedBundlePath):
558         Use wchar helpers as needed.
559
560 2019-03-06  Rob Buis  <rbuis@igalia.com>
561
562         Consider supporting the `referrerpolicy` attribute.
563         https://bugs.webkit.org/show_bug.cgi?id=179053
564
565         Reviewed by Darin Adler.
566
567         Add a runtime flag for referrerpolicy attribute.
568
569         * DumpRenderTree/mac/DumpRenderTree.mm:
570         (enableExperimentalFeatures):
571
572 2019-03-05  Daniel Bates  <dabates@apple.com>
573
574         Update expected API test result following r242379
575         (https://bugs.webkit.org/show_bug.cgi?id=195125)
576
577         Update expected x-coordinate of selection rect now that the left padding of
578         a textarea is sized in ems (so dependent on the font size) just like the left
579         padding of a text field.
580
581         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
582         (TestWebKitAPI::TEST):
583
584 2019-03-05  David Quesada  <david_quesada@apple.com>
585
586         [WK2] It should be possible to follow links with 'download' attributes
587         https://bugs.webkit.org/show_bug.cgi?id=195145
588         rdar://problem/48462642
589
590         Reviewed by Alex Christensen.
591
592         Add a unit test to verify that activating links with 'download' attributes now
593         navigates to the linked resource, rather than starts downloading it. Add another
594         to verify that it is still possible to explicitly download the link via the
595         'Download' navigation action policy.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
598         (-[DownloadAttributeTestDelegate init]):
599         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
600         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
601         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
602         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
603         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
604         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
605         (TEST):
606         * WebKitTestRunner/TestController.cpp:
607         (WTR::TestController::decidePolicyForNavigationAction):
608         * WebKitTestRunner/TestController.h:
609
610 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
611
612         [Curl] Implement Cookie Accept Policy.
613         https://bugs.webkit.org/show_bug.cgi?id=191645
614
615         Reviewed by Fujii Hironori.
616
617         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
618         (TestWebKitAPI::Curl::TEST_F):
619
620 2019-03-05  Youenn Fablet  <youenn@apple.com>
621
622         Rename requestCacheStorageSpace to requestStorageSpace
623         https://bugs.webkit.org/show_bug.cgi?id=195282
624
625         Reviewed by Chris Dumez.
626
627         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
628         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
629         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
630
631 2019-03-05  Brady Eidson  <beidson@apple.com>
632
633         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
634         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
635
636         Reviewed by Tim Horton.
637
638         Loading a file: URL into a WKWebView and then loading another file: url from a completely
639         different directory into that same WKWebView should work.
640
641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
642         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
643
644 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
645
646         Add WeakHashSet
647         https://bugs.webkit.org/show_bug.cgi?id=195152
648
649         Reviewed by Antti Koivisto.
650
651         Added tests for WeakHashSet.
652
653         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
654         (TestWebKitAPI::Base::Base): Moved.
655         (TestWebKitAPI::Derived::foo): Moved.
656         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
657         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
658         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
659         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
660
661 2019-03-04  Chris Dumez  <cdumez@apple.com>
662
663         Do not share WebProcesses between private and regular sessions
664         https://bugs.webkit.org/show_bug.cgi?id=195189
665         <rdar://problem/48421064>
666
667         Reviewed by Alex Christensen.
668
669         Add API test coverage.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
672         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
673
674 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
675
676         [WPE] Enable web process sandbox
677         https://bugs.webkit.org/show_bug.cgi?id=195169
678
679         Reviewed by Daniel Bates.
680
681         * wpe/install-dependencies:
682         * wpe/jhbuild.modules:
683
684 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
685
686         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
687         https://bugs.webkit.org/show_bug.cgi?id=195206
688
689         Reviewed by Žan Doberšek.
690
691         Add a new test case.
692
693         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
694         (testJSCClass):
695
696 2019-03-04  Charlie Turner  <cturner@igalia.com>
697
698         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
699         https://bugs.webkit.org/show_bug.cgi?id=194898
700
701         Reviewed by Žan Doberšek.
702
703         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
704         a GCC extension that permits arithmetic on void* pointer. Inline
705         the macro until this issue is fixed upstream.
706
707 2019-03-03  Tim Horton  <timothy_horton@apple.com>
708
709         Rid the world of WK_API_ENABLED
710         https://bugs.webkit.org/show_bug.cgi?id=195263
711
712         Reviewed by Dan Bernstein.
713
714         List of changed files elided because it's useless.
715
716 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
717
718         Unreviewed follow-up to r242292.
719
720         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
721
722         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
723         (TestWebKitAPI::testStrip): Renamed from strip.
724         (TestWebKitAPI::TEST):
725
726 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
727
728         Unreviewed, remove accidentally-committed URLHelpers.cpp test
729
730         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
731         and bug #194272 for details.
732
733         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
734
735 2019-03-03  Tim Horton  <timothy_horton@apple.com>
736
737         Remove some more unused 32-bit code
738         https://bugs.webkit.org/show_bug.cgi?id=195255
739
740         Reviewed by Darin Adler.
741
742         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
743         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
744         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
745         (NPP_New):
746         (NPP_HandleEvent):
747         (handleEventCarbon): Deleted.
748
749 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
750
751         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
752
753         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
754         (TestWebKitAPI::TEST):
755
756 2019-03-01  Darin Adler  <darin@apple.com>
757
758         Finish removing String::format
759         https://bugs.webkit.org/show_bug.cgi?id=194893
760
761         Reviewed by Daniel Bates.
762 '
763         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
764
765 2019-03-01  Alex Christensen  <achristensen@webkit.org>
766
767         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
768         https://bugs.webkit.org/show_bug.cgi?id=195229
769         <rdar://problem/48520362>
770
771         Reviewed by Chris Dumez.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
774         (TEST):
775
776 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
777
778         Add a system trace scope for event region building
779         https://bugs.webkit.org/show_bug.cgi?id=195226
780
781         Reviewed by Jon Lee.
782
783         This trace scope measures the time spend converting element rects into Region objects,
784         which can be large on some pages.
785
786         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
787
788         * Tracing/SystemTracePoints.plist:
789
790 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
791
792         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
793         https://bugs.webkit.org/show_bug.cgi?id=194612
794
795         Reviewed by Alex Christensen.
796
797         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
798         Just test the new string-processing function and don't touch the actual environment.
799         (Test cases are all as before, but based on operator== instead of strcmp.)
800
801 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-app] Update primary keys for handling multiple Buildbot instances
804         https://bugs.webkit.org/show_bug.cgi?id=195120
805
806         Reviewed by Stephanie Lewis.
807
808         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
809         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
810         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
811
812         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
813         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
814         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
815         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
816         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
817         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
818
819 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
820
821         [WinCairo] Enable service worker
822         https://bugs.webkit.org/show_bug.cgi?id=188318
823
824         Reviewed by Youenn Fablet.
825
826         * DumpRenderTree/DumpRenderTreePrefix.h:
827         * TestWebKitAPI/PlatformWin.cmake:
828         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
829         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
830         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
831
832 2019-03-01  Justin Fan  <justin_fan@apple.com>
833
834         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
835         https://bugs.webkit.org/show_bug.cgi?id=195191
836
837         Rubber-stamped by Dean Jackson.
838
839         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
840
841         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
842
843 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
844
845         Unreviewed, fix lldb webkitpy tests
846         https://bugs.webkit.org/show_bug.cgi?id=194375
847
848         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
849
850         * lldb/lldb_webkit.py:
851         (WTFStringImplProvider.is_8bit):
852
853 2019-02-28  David Quesada  <david_quesada@apple.com>
854
855         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
856         https://bugs.webkit.org/show_bug.cgi?id=195121
857         rdar://problem/48450302
858
859         Reviewed by Alex Christensen.
860
861         Add API tests for -WKNavigationAction._shouldPerformDownload in various
862         configurations where the 'download' attribute is absent, blank, or populated
863         with a filename, and where the anchor element is same-origin or cross-origin
864         (meaning the 'download' attribute shouldn't be honored).
865
866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
867         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
868         (-[NavigationActionTestDelegate init]):
869         (-[NavigationActionTestDelegate navigationAction]):
870         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
871         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
872         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
873         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
874         (TEST):
875
876 2019-02-28  Antoine Quint  <graouts@apple.com>
877
878         Enable the Pointer Events runtime flag by default
879         https://bugs.webkit.org/show_bug.cgi?id=195156
880
881         Reviewed by Dean Jackson.
882
883         * DumpRenderTree/mac/DumpRenderTree.mm:
884         (enableExperimentalFeatures):
885
886 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
887
888         Several PasteImage API tests are flaky
889         https://bugs.webkit.org/show_bug.cgi?id=195160
890
891         Reviewed by Tim Horton.
892
893         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
894         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
895         listening for a "load" event after image load is already complete.
896
897         To address this, make these tests first register a "load" event handler, then run script to insert an image
898         element into the document, and finally wait until the load event is observed before checking image size.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
901
902 2019-02-28  Chris Dumez  <cdumez@apple.com>
903
904         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
905         https://bugs.webkit.org/show_bug.cgi?id=195107
906
907         Reviewed by Alex Christensen.
908
909         Give some time for the zoom level to get restored.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
912
913 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
914
915         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
916         https://bugs.webkit.org/show_bug.cgi?id=194958
917
918         Reviewed by Geoffrey Garen.
919
920         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
921         (TEST):
922
923 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
924
925         [ews-app] Update method to save build to handle builder_display_name
926         https://bugs.webkit.org/show_bug.cgi?id=195047
927
928         Reviewed by Dewei Zhu.
929
930         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
931         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
932
933 2019-02-28  Justin Fan  <justin_fan@apple.com>
934
935         [Web GPU] Enable Web GPU only on 64-bit
936         https://bugs.webkit.org/show_bug.cgi?id=195139
937
938         Because Metal is only supported on 64 bit apps.
939
940         Unreviewed build fix.
941
942         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
943
944 2019-02-27  Youenn Fablet  <youenn@apple.com>
945
946         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
947         https://bugs.webkit.org/show_bug.cgi?id=194959
948
949         Reviewed by Chris Dumez.
950
951         Spin loop until getting the condition to remove flakiness.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
954
955 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
956
957         [ews-build] Buildbot should include builder_display_name in the build events
958         https://bugs.webkit.org/show_bug.cgi?id=195045
959
960         Reviewed by Dewei Zhu.
961
962         * BuildSlaveSupport/ews-build/events.py:
963         (Events.buildStarted): Included builder_display_name in event data. Also renamed
964         buildername to builder_name to be consistent in naming style.
965         (Events.buildFinished): Ditto.
966
967 2019-02-27  Chris Dumez  <cdumez@apple.com>
968
969         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
970         https://bugs.webkit.org/show_bug.cgi?id=194480
971
972         Reviewed by Brady Eidson.
973
974         Update existing API test to make it more likely to reproduce the issue.
975
976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
977
978 2019-02-27  Brady Eidson  <beidson@apple.com>
979
980         Universal links from Google search results pages don't open the app.
981         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
982
983         Reviewed by Geoffrey Garen.
984
985         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
986         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
987         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
988         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
989
990 2019-02-27  Chris Dumez  <cdumez@apple.com>
991
992         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
993         https://bugs.webkit.org/show_bug.cgi?id=195102
994
995         Reviewed by Geoffrey Garen.
996
997         If the number of processes is not yet what we expect, wait a bit and check again to give
998         processes some time to exit.
999
1000         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1001
1002 2019-02-27  Chris Dumez  <cdumez@apple.com>
1003
1004         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1005         https://bugs.webkit.org/show_bug.cgi?id=194545
1006
1007         Reviewed by Brady Eidson.
1008
1009         Make sure the test navigates forward and then back only once. Previously, navigating
1010         back would trigger a navigation again in a timer.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1013
1014 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1015
1016         High Sierra Debug JSC test queue should use faster hardware
1017         https://bugs.webkit.org/show_bug.cgi?id=194603
1018
1019         Rubber-stamped by Alexey Proskuryakov.
1020
1021         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1022
1023         * BuildSlaveSupport/build.webkit.org-config/config.json:
1024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1025         (BubbleQueueServer):
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1027         (WebKitBuildbot):
1028         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1029         * QueueStatusServer/config/queues.py:
1030         * Scripts/webkitpy/common/config/ews.json:
1031         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1032         (test_ews_name):
1033
1034 2019-02-27  John Wilander  <wilander@apple.com>
1035
1036         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1037         https://bugs.webkit.org/show_bug.cgi?id=195071
1038         <rdar://problem/48417690>
1039
1040         Reviewed by Alex Christensen and Brent Fulgham.
1041
1042         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1043         (TestWebKitAPI::createURL):
1044             Convenience function.
1045         (TestWebKitAPI::TEST):
1046             WebCore::AdClickAttribution now takes a URL when creating Source and
1047             Destination.
1048         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1049         (TestWebKitAPI::TEST):
1050             WebCore::AdClickAttribution now takes a URL when creating Source and
1051             Destination.
1052
1053 2019-02-27  Antoine Quint  <graouts@apple.com>
1054
1055         Support Pointer Events on macOS
1056         https://bugs.webkit.org/show_bug.cgi?id=195008
1057         <rdar://problem/47454419>
1058
1059         Reviewed by Dean Jackson.
1060
1061         * DumpRenderTree/mac/DumpRenderTree.mm:
1062         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1064
1065 2019-02-26  Mark Lam  <mark.lam@apple.com>
1066
1067         Remove remaining poisoning code.
1068         https://bugs.webkit.org/show_bug.cgi?id=194138
1069
1070         Reviewed by Saam Barati.
1071
1072         * TestWebKitAPI/CMakeLists.txt:
1073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1074         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1075         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1076         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1077         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1078         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1079         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1080
1081 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1082
1083         Move ephemeral local storage from WebProcess to UIProcess
1084         https://bugs.webkit.org/show_bug.cgi?id=195074
1085         <rdar://problem/47937975>
1086
1087         Reviewed by Geoff Garen.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1090
1091 2019-02-20  Jer Noble  <jer.noble@apple.com>
1092
1093         [Cocoa] Media elements will restart network buffering just before suspending
1094         https://bugs.webkit.org/show_bug.cgi?id=193691
1095
1096         Reviewed by Eric Carlson.
1097
1098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1100         (TEST):
1101
1102 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1103
1104         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1105         https://bugs.webkit.org/show_bug.cgi?id=191652
1106
1107         Reviewed by Alex Christensen.
1108
1109         Fix WinCairo MiniBrowser behavior of authentication dialog.
1110
1111         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1112         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1113
1114 2019-02-26  Youenn Fablet  <youenn@apple.com>
1115
1116         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1117         https://bugs.webkit.org/show_bug.cgi?id=195028
1118         <rdar://problem/48243733>
1119
1120         Reviewed by Eric Carlson.
1121
1122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1123
1124 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1125
1126         [WPE] Add API for webview background color configuration
1127         https://bugs.webkit.org/show_bug.cgi?id=192305
1128
1129         Reviewed by Michael Catanzaro.
1130
1131         * MiniBrowser/wpe/main.cpp:
1132         (main): Add a new option to configure the webview background
1133         color. Example: --bg-color=transparent.
1134         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1135         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1136         (beforeAll): Ditto.
1137
1138 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1139
1140         scalableNativeWebpageParameters() is not preserved on new page navigation.
1141         https://bugs.webkit.org/show_bug.cgi?id=194892
1142         <rdar://problem/47538280>
1143
1144         Reviewed by Wenson Hsieh.
1145         
1146         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1147
1148         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1149         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1150         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1151         (WTR::UIScriptController::allowsViewportShrinkToFit):
1152         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1153         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1154         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1155         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1156         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1157         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1158
1159 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-app] Add model for handling multiple Buildbot instances
1162         https://bugs.webkit.org/show_bug.cgi?id=194863
1163
1164         Reviewed by Stephanie Lewis.
1165
1166         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1167
1168 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-app] Remove BuilderMapping table
1171         https://bugs.webkit.org/show_bug.cgi?id=194961
1172
1173         Reviewed by Stephanie Lewis.
1174
1175         Store builder name directly in build table, instead of having a separate
1176         table for it.
1177
1178         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1179         * BuildSlaveSupport/ews-app/ews/models/build.py:
1180         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1181         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1182
1183 2019-02-25  John Wilander  <wilander@apple.com>
1184
1185         Introduce and adopt new class RegistrableDomain for eTLD+1
1186         https://bugs.webkit.org/show_bug.cgi?id=194791
1187         <rdar://problem/48179240>
1188
1189         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1190
1191         This patch adds an API test and replaces two instances of
1192         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1193
1194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1195         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1196         (TestWebKitAPI::TEST):
1197             Changed two strings to make sure the registrable domains are still considered
1198             invalid and pass the test.
1199         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1200         (TestWebKitAPI::TEST):
1201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1202         (WTR::InjectedBundle::didReceiveMessageToPage):
1203
1204 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1205
1206         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1207         https://bugs.webkit.org/show_bug.cgi?id=195001
1208
1209         Reviewed by Carlos Garcia Campos.
1210
1211         API version 1.0 always includes the functionality previously guarded with
1212         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1213         unconditionally.
1214
1215         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1216         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1217         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1218         (WebViewTest::showInWindow): Ditto.
1219         (WebViewTest::hideView): Ditto.
1220         * wpe/backends/HeadlessViewBackend.cpp:
1221         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1222         * wpe/backends/ViewBackend.cpp:
1223         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1224         * wpe/backends/WindowViewBackend.cpp:
1225         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1226         WPE_BACKEND_CHECK_VERSION().
1227         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1228
1229 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1230
1231         [Flatpak] Add support for flatpak > 1.1.2
1232         https://bugs.webkit.org/show_bug.cgi?id=194088
1233
1234         Flatpak 1.2 is now out so we need to support that
1235         version now.
1236
1237         Reviewed by Michael Catanzaro.
1238
1239         * flatpak/flatpakutils.py:
1240         (check_flatpak):
1241         (FlatpakPackages.__init__):
1242         (FlatpakPackages.__detect_packages):
1243         (FlatpakPackages.__detect_packages.in):
1244         (FlatpakRepos.update):
1245
1246 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1247
1248         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1249         https://bugs.webkit.org/show_bug.cgi?id=194998
1250
1251         Reviewed by Carlos Garcia Campos.
1252
1253         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1254         to a Git checkout and using the latest commit containing various fixes
1255         and improvements.
1256
1257 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1258
1259         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1260         https://bugs.webkit.org/show_bug.cgi?id=194981
1261
1262         Reviewed by Žan Doberšek.
1263
1264         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1265         (TestWebKitAPI::TEST):
1266
1267 2019-02-23  Keith Miller  <keith_miller@apple.com>
1268
1269         Add new mac target numbers
1270         https://bugs.webkit.org/show_bug.cgi?id=194955
1271
1272         Reviewed by Tim Horton.
1273
1274         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1275         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1276         * MiniBrowser/Configurations/Base.xcconfig:
1277         * TestWebKitAPI/Configurations/Base.xcconfig:
1278         * WebKitTestRunner/Configurations/Base.xcconfig:
1279
1280 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1281
1282         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1283         https://bugs.webkit.org/show_bug.cgi?id=194846
1284
1285         Reviewed by Don Olmstead.
1286
1287         Added _search_paths() and _port_specific_expectations_files() for
1288         WinCairoPort.
1289
1290         * Scripts/webkitpy/port/win.py:
1291         (WinCairoPort.default_baseline_search_path):
1292         (WinCairoPort):
1293         (WinCairoPort._port_specific_expectations_files):
1294         (WinCairoPort._search_paths):
1295
1296 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1297
1298         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1299         https://bugs.webkit.org/show_bug.cgi?id=194963
1300
1301         Reviewed by Dean Jackson.
1302
1303         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1304         Do a `contains` check instead of `equals`, because in debug builds we
1305         put the GraphicsLayer pointer in a prefix.
1306
1307 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1308
1309         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1310         https://bugs.webkit.org/show_bug.cgi?id=194873
1311         <rdar://problem/46701974>
1312
1313         Reviewed by Tim Horton.
1314
1315         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1316
1317         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1318         (WTR::UIScriptController::menuRect const):
1319         (WTR::UIScriptController::isShowingMenu const):
1320         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1321         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1322         (WTR::UIScriptController::menuRect const):
1323
1324         Add a function to query the bounds of the callout menu in content coordinates.
1325
1326         (WTR::UIScriptController::isShowingMenu const):
1327
1328         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1329
1330         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1331         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1332         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1333         (WTR::UIScriptController::rectForMenuAction const):
1334         (WTR::UIScriptController::menuRect const):
1335         (WTR::UIScriptController::isShowingMenu const):
1336         (WTR::findViewInHierarchyOfType): Deleted.
1337
1338 2019-02-22  Chris Dumez  <cdumez@apple.com>
1339
1340         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1341         https://bugs.webkit.org/show_bug.cgi?id=194954
1342         <rdar://problem/48127957>
1343
1344         Reviewed by Alex Christensen.
1345
1346         Add API test coverage.
1347
1348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1349         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1350         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1351         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1352
1353 2019-02-22  Chris Dumez  <cdumez@apple.com>
1354
1355         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1356         https://bugs.webkit.org/show_bug.cgi?id=194924
1357         <rdar://problem/48216125>
1358
1359         Reviewed by Geoffrey Garen.
1360
1361         Add API test coverage.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1364
1365 2019-02-22  Chris Dumez  <cdumez@apple.com>
1366
1367         Unreviewed, disable API test added in r241928 on iOS.
1368
1369         The cache is not enabled on devices with less than 3GB of RAM.
1370
1371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1372
1373 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1374
1375         Hardcode Visual Viewports on everywhere except iOS WK1
1376         https://bugs.webkit.org/show_bug.cgi?id=194928
1377
1378         Reviewed by Zalan Bujtas.
1379
1380         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1381         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1382         set it to false. The setting has shipped for several years and there's no need to turn
1383         it off now.
1384
1385         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1386         Visual Viewports are not enabled.
1387         
1388         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1389         that only runs in WK2
1390
1391         * MiniBrowser/mac/SettingsController.h:
1392         * MiniBrowser/mac/SettingsController.m:
1393         (-[SettingsController init]):
1394         (-[SettingsController _populateMenu]):
1395         (-[SettingsController validateMenuItem:]):
1396         (-[SettingsController visualViewportEnabled]): Deleted.
1397         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1398         * MiniBrowser/mac/WK1BrowserWindowController.m:
1399         (-[WK1BrowserWindowController didChangeSettings]):
1400         * MiniBrowser/mac/WK2BrowserWindowController.m:
1401         (-[WK2BrowserWindowController didChangeSettings]):
1402
1403 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1404
1405         Discard cached processes when clearing website data store
1406         https://bugs.webkit.org/show_bug.cgi?id=194894
1407
1408         Reviewed by Chris Dumez.
1409
1410         Added a test case.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1413         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1414
1415 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1416
1417         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1418         https://bugs.webkit.org/show_bug.cgi?id=194914
1419         <rdar://problem/47586889>
1420
1421         Reviewed by Geoffrey Garen.
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1424         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1425         (TEST):
1426         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1427
1428 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1429
1430         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1431         <https://webkit.org/b/194761>
1432
1433         Reviewed by Myles Maxfield.
1434
1435         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1436         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1437         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1438         to use ARC-compliant cast.
1439         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1440         ARC-compliant cast.
1441         (WTR::installFakeHelvetica): Log `error` to console if
1442         CTFontManagerRegisterFontsForURL() fails, but only on supported
1443         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1444         Call CFRelease() on `error` to fix the leak.  Update to use
1445         ARC-compliant cast.
1446         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1447         cast.
1448
1449 2019-02-21  Chris Dumez  <cdumez@apple.com>
1450
1451         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1452         https://bugs.webkit.org/show_bug.cgi?id=194481
1453
1454         Reviewed by Alex Christensen.
1455
1456         Give the processes a chance to shutdown and wait until we reached the expected number
1457         of processes.
1458
1459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1460
1461 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1462
1463         Fix the macOS build
1464
1465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1466
1467 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1468
1469         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1472         I am a backwards.
1473
1474 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1475
1476         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1477
1478         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1479         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1480         We could force on UI-side compositing, but I feel like the test might be more
1481         valuable exercising the normal path on each platform (though the original
1482         bug was also UI-side specific). Though we can't validate that the overlay
1483         layer was installed successfully, there are layout tests that do that.
1484
1485 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1486
1487         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1488         https://bugs.webkit.org/show_bug.cgi?id=194845
1489         <rdar://problem/47944579>
1490
1491         Reviewed by Antti Koivisto.
1492
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1495
1496 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1497
1498         [LFC][Floats] Add support for placing formatting roots in-between floats.
1499         https://bugs.webkit.org/show_bug.cgi?id=194902
1500
1501         Reviewed by Antti Koivisto.
1502
1503         * LayoutReloaded/misc/LFC-passing-tests.txt:
1504
1505 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1506
1507         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1508         https://bugs.webkit.org/show_bug.cgi?id=194901
1509
1510         Unreviewed build fix.
1511
1512         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1513         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1514         WPEBackend-fdo-0.1 as library name.
1515
1516 2019-02-21  Rob Buis  <rbuis@igalia.com>
1517
1518         Update MIME type parser
1519         https://bugs.webkit.org/show_bug.cgi?id=180526
1520
1521         Reviewed by Darin Adler.
1522
1523         Add tests involving leading and trailing whitespace, non-token
1524         characters and quoted strings.
1525
1526         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1527         (TestWebKitAPI::TEST):
1528
1529 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1530
1531         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1532         https://bugs.webkit.org/show_bug.cgi?id=194884
1533
1534         Reviewed by Michael Catanzaro.
1535
1536         * PlatformWin.cmake:
1537
1538 2019-02-20  Chris Dumez  <cdumez@apple.com>
1539
1540         Add API test for <rdar://problem/47471222>
1541         https://bugs.webkit.org/show_bug.cgi?id=194847
1542
1543         Reviewed by Alex Christensen.
1544
1545         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1546
1547 2019-02-20  Chris Dumez  <cdumez@apple.com>
1548
1549         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1550         https://bugs.webkit.org/show_bug.cgi?id=194872
1551         <rdar://problem/47924500>
1552
1553         Reviewed by Alex Christensen.
1554
1555         Add API test coverage.
1556
1557         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1558
1559 2019-02-20  Jer Noble  <jer.noble@apple.com>
1560
1561         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1562         https://bugs.webkit.org/show_bug.cgi?id=191332
1563
1564         Reviewed by Dean Jackson.
1565
1566         * Scripts/git-is-in-range: Added.
1567
1568 2019-02-20  Andy Estes  <aestes@apple.com>
1569
1570         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1571         https://bugs.webkit.org/show_bug.cgi?id=194869
1572
1573         Rubber-stamped by Jer Noble.
1574
1575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1576         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1577         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1578         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1580         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1581
1582 2019-02-20  Chris Dumez  <cdumez@apple.com>
1583
1584         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1585         https://bugs.webkit.org/show_bug.cgi?id=194857
1586         <rdar://problem/47759323>
1587
1588         Reviewed by Alex Christensen.
1589
1590         Add API test coverage.
1591
1592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1593
1594 2019-02-20  Chris Dumez  <cdumez@apple.com>
1595
1596         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1597         https://bugs.webkit.org/show_bug.cgi?id=194829
1598         <rdar://problem/47889906>
1599
1600         Reviewed by Alexey Proskuryakov.
1601
1602         Every time the TestOptions were changing we were creating both a new Web view and
1603         a new WKContext, which would start a new Network process. In most cases, we only
1604         need to contruct a new Web view and we do can keep reusing the same WKContext.
1605         This patch implements this optimization and thus avoids spinning a lot of new
1606         Network processes while running the layout tests.
1607
1608         * WebKitTestRunner/TestController.cpp:
1609         (WTR::TestController::generateContextConfiguration const):
1610         (WTR::TestController::generatePageConfiguration):
1611         (WTR::TestController::createWebViewWithOptions):
1612         (WTR::TestController::resetPreferencesToConsistentValues):
1613         (WTR::updateTestOptionsFromTestHeader):
1614         * WebKitTestRunner/TestController.h:
1615         * WebKitTestRunner/TestOptions.h:
1616         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1617         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1618         (WTR::TestOptions::hasSameInitializationOptions const):
1619         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1620         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1621         (WTR::TestController::platformAddTestOptions const):
1622
1623 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1624
1625         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1626         https://bugs.webkit.org/show_bug.cgi?id=167941
1627
1628         Reviewed by Carlos Garcia Campos.
1629
1630         * MiniBrowser/gtk/main.c:
1631         (filterSavedCallback): Added.
1632         (main): Support loading a JSON rule set file for content filtering.
1633         * MiniBrowser/wpe/main.cpp:
1634         (filterSavedCallback): Added.
1635         (main): Support loading a JSON rule set file for content filtering.
1636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1637         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1638         (WTF::derefGPtr): Ditto.
1639         (testEmptyStore):
1640         (testSaveInvalidFilter):
1641         (testSaveLoadFilter):
1642         (testSavedFilterIdentifierMatch):
1643         (testRemoveFilter):
1644         (testSaveMultipleFilters):
1645         (testSaveFilterFromFile):
1646         (testFilterPersistence):
1647         (beforeAll):
1648         (afterAll):
1649         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1650         (removeOldInjectedContentAndResetLists): Also reset content filters.
1651         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1652         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1653         the element affected by the style sheet.
1654         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1655         and returns it to be used by tests.
1656         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1657         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1658         (serverCallback): Add support for serving a CSS style sheet for testing.
1659         (beforeAll): Add call to testUserContentManagerContentFilter().
1660         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1661
1662 2019-02-19  Keith Rollin  <krollin@apple.com>
1663
1664         Add timing information to build output
1665         https://bugs.webkit.org/show_bug.cgi?id=194839
1666         <rdar://problem/48219609>
1667
1668         Reviewed by Alexey Proskuryakov.
1669
1670         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1671         emit each project's build time to its output. E.g.,
1672
1673             ** BUILD SUCCEEDED ** [0.132 sec]
1674
1675         * Scripts/webkitdirs.pm:
1676         (XcodeOptions):
1677
1678 2019-02-19  Truitt Savell  <tsavell@apple.com>
1679
1680         Unreviewed, rolling out r241784.
1681
1682         Broke all OpenSource builds.
1683
1684         Reverted changeset:
1685
1686         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1687         instances view"
1688         https://bugs.webkit.org/show_bug.cgi?id=172848
1689         https://trac.webkit.org/changeset/241784
1690
1691 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1692
1693         [LFC][Floats] Remove redundant intersecting logic
1694         https://bugs.webkit.org/show_bug.cgi?id=194804
1695
1696         Reviewed by Antti Koivisto.
1697
1698         * LayoutReloaded/misc/LFC-passing-tests.txt:
1699
1700 2019-02-19  Dean Jackson  <dino@apple.com>
1701
1702         Clean-up output from generate-xcfilelists so it can be filtered
1703         https://bugs.webkit.org/show_bug.cgi?id=194795
1704
1705         Reviewed by Joseph Pecoraro (and Keith Rollin).
1706
1707         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1708         make a slight tweak to filter-build-webkit so such lines are marked
1709         as plain.
1710
1711         * Scripts/filter-build-webkit:
1712         * Scripts/generate-xcfilelists:
1713
1714 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1715
1716         pytest is not correctly auto-installed
1717         https://bugs.webkit.org/show_bug.cgi?id=194707
1718
1719         Reviewed by Carlos Garcia Campos.
1720
1721         * Scripts/webkitpy/thirdparty/__init__.py:
1722         (AutoinstallImportHook._install_pytest):
1723
1724 2019-02-18  Chris Dumez  <cdumez@apple.com>
1725
1726         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1727         https://bugs.webkit.org/show_bug.cgi?id=194797
1728         <rdar://problem/48055151>
1729
1730         Reviewed by Geoffrey Garen.
1731
1732         Add API test coverage.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1735
1736 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1737
1738         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1739         https://bugs.webkit.org/show_bug.cgi?id=194670
1740         <rdar://problem/39066529>
1741
1742         Reviewed by Tim Horton.
1743
1744         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1745         pasted in an editable area as attachment elements.
1746
1747         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1748         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1749         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1750         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1751         (TestWebKitAPI::TEST):
1752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1753         (WTR::InjectedBundlePage::InjectedBundlePage):
1754
1755 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1756
1757         Fix API test after r241728
1758        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1761         (TEST):
1762         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1763
1764 2019-02-18  Daniel Bates  <dabates@apple.com>
1765
1766         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1767         https://bugs.webkit.org/show_bug.cgi?id=192824
1768         <rdar://problem/47100332>
1769
1770         Reviewed by Wenson Hsieh.
1771
1772         Fix a bug where the wrong usage code was used for F13 thru F24.
1773
1774         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1775         (keyCodeForDOMFunctionKey):
1776
1777 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1778
1779         Bytecode cache should a have a boot-specific validation
1780         https://bugs.webkit.org/show_bug.cgi?id=194769
1781         <rdar://problem/48149509>
1782
1783         Reviewed by Keith Miller.
1784
1785         Add test for WTF::bootSessionUUIDString()
1786
1787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1788         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1789         (TEST):
1790
1791 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1792
1793         Disable safe browsing in WKWebView and remove its WKPreferences API
1794         https://bugs.webkit.org/show_bug.cgi?id=194723
1795         <rdar://problem/48122993>
1796
1797         Reviewed by Geoffrey Garen.
1798
1799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1800         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1801         (TEST):
1802         (safeBrowsingView):
1803         Make tests use SPI instead of API.
1804
1805 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1806
1807         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1808         https://bugs.webkit.org/show_bug.cgi?id=194586
1809
1810         Reviewed by Ross Kirsling.
1811
1812         * DumpRenderTree/win/DumpRenderTree.cpp:
1813         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1814         * Scripts/webkitpy/port/driver.py:
1815         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1816
1817 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1818
1819         Unreviewed, rolling out r241620.
1820
1821         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1822         (Requested by ddkilzer on #webkit.)
1823
1824         Reverted changeset:
1825
1826         "[WTF] Add environment variable helpers"
1827         https://bugs.webkit.org/show_bug.cgi?id=192405
1828         https://trac.webkit.org/changeset/241620
1829
1830 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1831
1832         [LFC] RenderImage's default intrinsic size is 0.
1833         https://bugs.webkit.org/show_bug.cgi?id=194745
1834
1835         Reviewed by Antti Koivisto.
1836
1837         * LayoutReloaded/misc/LFC-passing-tests.txt:
1838
1839 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1840
1841         [LFC][BFC] Add support for block replaced intrinsic width.
1842         https://bugs.webkit.org/show_bug.cgi?id=194705
1843
1844         Reviewed by Simon Fraser.
1845
1846         * LayoutReloaded/misc/LFC-passing-tests.txt:
1847
1848 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1849
1850         [LFC] Apply min/max width constraints to preferred width computation
1851         https://bugs.webkit.org/show_bug.cgi?id=194739
1852
1853         Reviewed by Simon Fraser.
1854
1855         * LayoutReloaded/misc/LFC-passing-tests.txt:
1856
1857 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1858
1859         [WTF] Add environment variable helpers
1860         https://bugs.webkit.org/show_bug.cgi?id=192405
1861
1862         Reviewed by Michael Catanzaro.
1863
1864         * DumpRenderTree/mac/DumpRenderTree.mm:
1865         (libraryPathForDumpRenderTree):
1866         * DumpRenderTree/win/DumpRenderTree.cpp:
1867         (libraryPathForDumpRenderTree):
1868         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1869         (setUpIOSLayoutTestCommunication):
1870         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1871         (beforeAll):
1872         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1873         (main):
1874         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1875         (WebKitTestBus::run):
1876         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1877         (WTR::getOutputDir):
1878         (WTR::initializeFontConfigSetting):
1879         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1880         (WTR::InjectedBundle::platformInitialize):
1881         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1882         (WTR::topLevelPath):
1883         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1884         (WTR::topLevelPath):
1885         (WTR::getOutputDir):
1886         (WTR::activateFonts):
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::libraryPathForTesting):
1889         (WTR::TestController::generateContextConfiguration const):
1890         (WTR::TestController::generatePageConfiguration):
1891         (WTR::TestController::decideDestinationWithSuggestedFilename):
1892         (WTR::TestController::platformAdjustContext):
1893         * WebKitTestRunner/TestController.h:
1894         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1895         (WTR::TestController::cocoaPlatformInitialize):
1896         (WTR::TestController::platformAdjustContext):
1897         * WebKitTestRunner/gtk/main.cpp:
1898         (main):
1899         * WebKitTestRunner/mac/TestControllerMac.mm:
1900         (WTR::TestController::configureContentExtensionForTest):
1901         * WebKitTestRunner/wpe/main.cpp:
1902         (main):
1903         Utilize WTF::Environment where possible.
1904
1905 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1906
1907         [iOS] WKWebView callout bar is missing Change Writing Direction item
1908         https://bugs.webkit.org/show_bug.cgi?id=190015
1909         <rdar://problem/44810366>
1910
1911         Reviewed by Tim Horton.
1912
1913         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1914         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1917         (TestWebKitAPI::TEST):
1918
1919 2019-02-15  Chris Dumez  <cdumez@apple.com>
1920
1921         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1922         https://bugs.webkit.org/show_bug.cgi?id=194717
1923         <rdar://problem/47884404>
1924
1925         Reviewed by Brady Eidson.
1926
1927         Add API test coverage.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1930
1931 2019-02-15  Youenn Fablet  <youenn@apple.com>
1932
1933         Make navigator.mediaDevices SecureContext
1934         https://bugs.webkit.org/show_bug.cgi?id=194666
1935
1936         Reviewed by Eric Carlson.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1939         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1940         (TEST_F):
1941
1942 2019-02-15  Brian Burg  <bburg@apple.com>
1943
1944         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1945         https://bugs.webkit.org/show_bug.cgi?id=194411
1946         <rdar://problem/47787614>
1947
1948         Reviewed by Joseph Pecoraro.
1949
1950         Remove unnecessary soft linking macro usage.
1951
1952         * DumpRenderTree/mac/TestRunnerMac.mm:
1953         (TestRunner::inspectorTestStubURL):
1954         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1955         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1956         (WTR::TestRunner::inspectorTestStubURL):
1957
1958 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1959
1960         Unreviewed, rolling out r241559 and r241566.
1961         https://bugs.webkit.org/show_bug.cgi?id=194710
1962
1963         Causes layout test crashes under GuardMalloc (Requested by
1964         ryanhaddad on #webkit).
1965
1966         Reverted changesets:
1967
1968         "[WTF] Add environment variable helpers"
1969         https://bugs.webkit.org/show_bug.cgi?id=192405
1970         https://trac.webkit.org/changeset/241559
1971
1972         "Unreviewed build fix for WinCairo Debug after r241559."
1973         https://trac.webkit.org/changeset/241566
1974
1975 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1976
1977         [LFC] Out-of-flow box is never a float box
1978         https://bugs.webkit.org/show_bug.cgi?id=194704
1979
1980         Reviewed by Antti Koivisto.
1981
1982         * LayoutReloaded/misc/LFC-passing-tests.txt:
1983
1984 2019-02-10  Darin Adler  <darin@apple.com>
1985
1986         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1987         https://bugs.webkit.org/show_bug.cgi?id=194487
1988
1989         Reviewed by Daniel Bates.
1990
1991         * DumpRenderTree/win/DumpRenderTree.cpp:
1992         (applicationId): Use makeString instead of String::format.
1993         (main): Ditto.
1994         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1995         (TestWebKitAPI::Util::createURLForResource): Ditto.
1996         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1997         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1998
1999         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2000         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2001         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2002         (WTR::createStringWithAttributes): Use appendLiteral.
2003         (WTR::AccessibilityUIElement::helpText const): Ditto.
2004         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2005         directly instead of using String::format.
2006         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2007         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2008
2009 2019-02-15  Truitt Savell  <tsavell@apple.com>
2010
2011         Unreviewed, rolling out r241564.
2012
2013         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2014
2015         Reverted changeset:
2016
2017         "[Mac] WebInspectorUI.framework does not need to be soft-
2018         linked anymore"
2019         https://bugs.webkit.org/show_bug.cgi?id=194411
2020         https://trac.webkit.org/changeset/241564
2021
2022 2019-02-15  Saam barati  <sbarati@apple.com>
2023
2024         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2025         https://bugs.webkit.org/show_bug.cgi?id=194036
2026
2027         Reviewed by Yusuke Suzuki.
2028
2029         * Scripts/run-jsc-stress-tests:
2030
2031 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2032
2033         Fix the build.
2034
2035         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2036         (WTR::UIScriptController::drawSquareInEditableImage):
2037         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2038         (TestWebKitAPI::drawSquareInEditableImage):
2039
2040 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2041
2042         Fix the build.
2043
2044         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2045         (WTR::UIScriptController::drawSquareInEditableImage):
2046         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2047         (TestWebKitAPI::drawSquareInEditableImage):
2048
2049 2019-02-14  Brian Burg  <bburg@apple.com>
2050
2051         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2052         https://bugs.webkit.org/show_bug.cgi?id=194411
2053         <rdar://problem/47787614>
2054
2055         Reviewed by Joseph Pecoraro.
2056
2057         Remove unnecessary soft linking macro usage.
2058
2059         * DumpRenderTree/mac/TestRunnerMac.mm:
2060         (TestRunner::inspectorTestStubURL):
2061         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2062         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2063         (WTR::TestRunner::inspectorTestStubURL):
2064
2065 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2066
2067         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2068         https://bugs.webkit.org/show_bug.cgi?id=194599
2069
2070         Reviewed by Lucas Forschler.
2071
2072         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2073         (StatusBubble._build_bubble):
2074
2075 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews-app] Set Foreign Key in Django build model
2078         https://bugs.webkit.org/show_bug.cgi?id=194667
2079
2080         Reviewed by Lucas Forschler.
2081
2082         * BuildSlaveSupport/ews-app/ews/models/build.py:
2083         (Build):
2084
2085 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2086
2087         [WTF] Add environment variable helpers
2088         https://bugs.webkit.org/show_bug.cgi?id=192405
2089
2090         Reviewed by Michael Catanzaro.
2091
2092         * DumpRenderTree/mac/DumpRenderTree.mm:
2093         (libraryPathForDumpRenderTree):
2094         * DumpRenderTree/win/DumpRenderTree.cpp:
2095         (libraryPathForDumpRenderTree):
2096         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2097         (setUpIOSLayoutTestCommunication):
2098         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2099         (TestWebKitAPI::strip):
2100         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2101         (beforeAll):
2102         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2103         (main):
2104         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2105         (WebKitTestBus::run):
2106         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2107         (WTR::getOutputDir):
2108         (WTR::initializeFontConfigSetting):
2109         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2110         (WTR::InjectedBundle::platformInitialize):
2111         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2112         (WTR::topLevelPath):
2113         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2114         (WTR::topLevelPath):
2115         (WTR::getOutputDir):
2116         (WTR::activateFonts):
2117         * WebKitTestRunner/TestController.cpp:
2118         (WTR::TestController::libraryPathForTesting):
2119         (WTR::TestController::generateContextConfiguration const):
2120         (WTR::TestController::generatePageConfiguration):
2121         (WTR::TestController::decideDestinationWithSuggestedFilename):
2122         (WTR::TestController::platformAdjustContext):
2123         * WebKitTestRunner/TestController.h:
2124         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2125         (WTR::TestController::cocoaPlatformInitialize):
2126         (WTR::TestController::platformAdjustContext):
2127         * WebKitTestRunner/gtk/main.cpp:
2128         (main):
2129         * WebKitTestRunner/mac/TestControllerMac.mm:
2130         (WTR::TestController::configureContentExtensionForTest):
2131         * WebKitTestRunner/wpe/main.cpp:
2132         (main):
2133         Utilize WTF::Environment where possible.
2134
2135 2019-02-14  Chris Dumez  <cdumez@apple.com>
2136
2137         [PSON] Introduce a WebContent Process cache
2138         https://bugs.webkit.org/show_bug.cgi?id=194594
2139         <rdar://problem/46793397>
2140
2141         Reviewed by Geoff Garen.
2142
2143         Update API tests to turn on the WebContent Process cache.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2146
2147 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2148
2149         Unreviewed, build fix after r241480
2150
2151         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2152         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2153         (-[DragAndDropSimulator initWithWebView:]):
2154
2155 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2156
2157         AX: ARIA Reflection was disabled in error
2158         https://bugs.webkit.org/show_bug.cgi?id=194647
2159         <rdar://problem/48068336>
2160
2161         Reviewed by Ryosuke Niwa.
2162
2163         Remove test override now that this feature should be enabled by default.
2164
2165         * WebKitTestRunner/TestController.cpp:
2166         (WTR::TestController::resetPreferencesToConsistentValues):
2167
2168 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2169
2170         Unreviewed, rolling out r241486.
2171         https://bugs.webkit.org/show_bug.cgi?id=194655
2172
2173         causing API failures in builds (Requested by ShawnRoberts on
2174         #webkit).
2175
2176         Reverted changeset:
2177
2178         "[Cocoa] Media elements will restart network buffering just
2179         before suspending"
2180         https://bugs.webkit.org/show_bug.cgi?id=193691
2181         https://trac.webkit.org/changeset/241486
2182
2183 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2184
2185         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2186         https://bugs.webkit.org/show_bug.cgi?id=194622
2187
2188         Reviewed by Antti Koivisto.
2189
2190         * LayoutReloaded/misc/LFC-passing-tests.txt:
2191
2192 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2193
2194         [LFC] Shrink-to-fit-width should be constrained by min/max width
2195         https://bugs.webkit.org/show_bug.cgi?id=194653
2196
2197         Reviewed by Antti Koivisto.
2198
2199         * LayoutReloaded/misc/LFC-passing-tests.txt:
2200
2201 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2202
2203         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2204         https://bugs.webkit.org/show_bug.cgi?id=194641
2205
2206         Reviewed by Geoffrey Garen.
2207
2208         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2209         so that the test would fail without this fix.
2210
2211         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2212         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2213
2214 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2215
2216         [ews-app] Change log level for a log statement
2217
2218         Unreviewed minor fix.
2219
2220         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2221         (Patch.save_patch):
2222
2223 2019-02-13  Jer Noble  <jer.noble@apple.com>
2224
2225         [Cocoa] Media elements will restart network buffering just before suspending
2226         https://bugs.webkit.org/show_bug.cgi?id=193691
2227
2228         Reviewed by Eric Carlson.
2229
2230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2232         (TEST):
2233
2234 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2235
2236         [ews-app] Fetch builder id to name mapping
2237         https://bugs.webkit.org/show_bug.cgi?id=194355
2238
2239         Reviewed by Lucas Forschler.
2240
2241         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2242         (Buildbot.get_builder_id_to_name_mapping):
2243         (Buildbot._get_display_name_from_builder_name):
2244
2245 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2246
2247         Further restricting webarchive loads
2248         https://bugs.webkit.org/show_bug.cgi?id=194567
2249         <rdar://problem/47610130>
2250
2251         Reviewed by Youenn Fablet.
2252
2253         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2254         navigations on drop.
2255
2256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2257         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2258         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2259         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2260         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2261         (TestWebKitAPI::TEST):
2262         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2263         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2264         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2265         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2266         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2267         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2268         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2269
2270 2019-02-13  John Wilander  <wilander@apple.com>
2271
2272         Store Ad Click Attribution requests in the network process
2273         https://bugs.webkit.org/show_bug.cgi?id=194510
2274         <rdar://problem/47650118>
2275
2276         Reviewed by Alex Christensen and Daniel Bates.
2277
2278         This patch adds two TestRunner functions:
2279         - dumpAdClickAttribution()
2280         - clearAdClickAttribution()
2281
2282         They call into the network process to dump and clear Ad Click
2283         Attribution state, respectively.
2284
2285         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2287         (WTR::TestRunner::dumpAdClickAttribution):
2288         (WTR::TestRunner::clearAdClickAttribution):
2289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2290         * WebKitTestRunner/TestController.cpp:
2291         (WTR::TestController::resetStateToConsistentValues):
2292         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2293         (WTR::adClickAttributionStringResultCallback):
2294         (WTR::TestController::dumpAdClickAttribution):
2295         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2296         (WTR::adClickAttributionVoidCallback):
2297         (WTR::TestController::clearAdClickAttribution):
2298         * WebKitTestRunner/TestController.h:
2299         * WebKitTestRunner/TestInvocation.cpp:
2300         (WTR::TestInvocation::dumpResults):
2301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2302         (WTR::TestInvocation::dumpAdClickAttribution):
2303         * WebKitTestRunner/TestInvocation.h:
2304
2305 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2306
2307         [ews-app] Generate status-bubble
2308         https://bugs.webkit.org/show_bug.cgi?id=194572
2309
2310         Reviewed by Lucas Forschler.
2311
2312         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2313         (StatusBubble._build_bubble):
2314         (StatusBubble._should_show_bubble_for):
2315         (StatusBubble._build_bubbles_for_patch):
2316
2317 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews-app] Add status bubble html template
2320         https://bugs.webkit.org/show_bug.cgi?id=194571
2321
2322         Reviewed by Lucas Forschler.
2323
2324         * BuildSlaveSupport/ews-app/ews/templates: Added.
2325         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2326
2327 2019-02-12  Chris Dumez  <cdumez@apple.com>
2328
2329         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2330         https://bugs.webkit.org/show_bug.cgi?id=194568
2331         <rdar://problem/47944490>
2332
2333         Reviewed by Ryosuke Niwa.
2334
2335         Add API test coverage.
2336
2337         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2338         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2339
2340 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2341
2342         webkitpy: Remove bug_dummy from parsed test expectations
2343         https://bugs.webkit.org/show_bug.cgi?id=194562
2344         <rdar://problem/47853999>
2345
2346         Reviewed by Lucas Forschler.
2347
2348         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2349         (TestExpectationParser):
2350         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2351         skipped tests.
2352         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2353
2354 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2355
2356         [ews-app] Add method to fetch patch
2357         https://bugs.webkit.org/show_bug.cgi?id=194518
2358
2359         Reviewed by Lucas Forschler.
2360
2361         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2362         (Patch.get_patch):
2363
2364 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2365
2366         [LFC] Expand tests coverage (60 new tests -> 860)
2367
2368         Unreviewed test gardening (run-singly, --child-processes=1).
2369
2370         * LayoutReloaded/misc/LFC-passing-tests.txt:
2371
2372 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2373
2374         Allow pages to trigger programmatic paste from script on iOS
2375         https://bugs.webkit.org/show_bug.cgi?id=194271
2376         <rdar://problem/47808810>
2377
2378         Reviewed by Tim Horton.
2379
2380         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2381
2382         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2383         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2384         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2385         (WTR::UIScriptController::rectForMenuAction const):
2386
2387         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2388         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2389         for when the menu is shown or hidden.
2390
2391         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2392         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2393         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2394         (WTR::UIScriptController::setDidShowMenuCallback):
2395         (WTR::UIScriptController::didShowMenuCallback const):
2396         (WTR::UIScriptController::setDidHideMenuCallback):
2397         (WTR::UIScriptController::didHideMenuCallback const):
2398         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2399         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2400         (WTR::UIScriptController::rectForMenuAction const):
2401         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2402         * WebKitTestRunner/TestController.cpp:
2403         (WTR::TestController::resetPreferencesToConsistentValues):
2404         (WTR::updateTestOptionsFromTestHeader):
2405         * WebKitTestRunner/TestOptions.h:
2406
2407         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2408         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2409
2410         (WTR::TestOptions::hasSameInitializationOptions const):
2411         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2412         (WTR::UIScriptController::calendarType const):
2413         (WTR::UIScriptController::platformUndoManager const):
2414         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2415         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2416         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2417         (-[TestRunnerWKWebView dealloc]):
2418         (-[TestRunnerWKWebView _didShowMenu]):
2419         (-[TestRunnerWKWebView _didHideMenu]):
2420
2421         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2422
2423         * WebKitTestRunner/ios/TestControllerIOS.mm:
2424         (WTR::handleMenuWillHideNotification):
2425         (WTR::handleMenuDidHideNotification):
2426         (WTR::TestController::platformInitialize):
2427         (WTR::TestController::platformDestroy):
2428         (WTR::TestController::platformResetStateToConsistentValues):
2429
2430         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2431         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2432
2433         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2434         (WTR::forEachViewInHierarchy):
2435         (WTR::findViewInHierarchyOfType):
2436
2437         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2438         functions that dig through a given view's hierarchy in search of a view of a given class.
2439
2440         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2441         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2442         (WTR::UIScriptController::selectionCaretViewRect const):
2443         (WTR::UIScriptController::selectionRangeViewRects const):
2444         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2445         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2446
2447         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2448
2449         (WTR::UIScriptController::rectForMenuAction const):
2450
2451         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2452         callout bar) whose label matches the given string.
2453
2454         (WTR::UIScriptController::platformContentView const):
2455
2456         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2457         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2458         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2459
2460         (WTR::UIScriptController::platformUndoManager const): Deleted.
2461         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2462         (WTR::UIScriptController::platformContentView const):
2463         (WTR::UIScriptController::platformUndoManager const): Deleted.
2464
2465 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2466
2467         webkitpy: No option to only show unexpected failures in results.html for iPad
2468         https://bugs.webkit.org/show_bug.cgi?id=194554
2469         <rdar://problem/47922442>
2470
2471         Rubber-stamped by Aakash Jain.
2472
2473         Just because a TestExpecations file does not exist for a specific platform does not mean that
2474         TestExpecations are not being used, given that platforms inherit test expectations.
2475
2476         * Scripts/webkitpy/port/base.py:
2477         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2478         * Scripts/webkitpy/port/base_unittest.py:
2479         (PortTest.test_uses_test_expectations_file):
2480
2481 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2482
2483         Remove setDefersLoading infrastructure from WebKit2
2484         https://bugs.webkit.org/show_bug.cgi?id=194506
2485
2486         Reviewed by Brady Eidson.
2487
2488         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2490         (WTR::TestRunner::setDefersLoading): Deleted.
2491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2492
2493 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2494
2495         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2496         https://bugs.webkit.org/show_bug.cgi?id=194522
2497         <rdar://problem/47789393>
2498
2499         Reviewed by Chris Dumez.
2500
2501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2502         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2503         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2504         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2505
2506 2019-02-12  Andy Estes  <aestes@apple.com>
2507
2508         [iOSMac] Enable Parental Controls Content Filtering
2509         https://bugs.webkit.org/show_bug.cgi?id=194521
2510         <rdar://39732376>
2511
2512         Reviewed by Tim Horton.
2513
2514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2515
2516 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2517
2518         [LFC][IFC] Add intrinsic width support for float boxes.
2519         https://bugs.webkit.org/show_bug.cgi?id=194528
2520
2521         Reviewed by Antti Koivisto.
2522
2523         Expand tests coverage (2 new tests -> 800).
2524         (This is the correct test ordering --runs-singly --child-processes=1)
2525
2526         * LayoutReloaded/misc/LFC-passing-tests.txt:
2527
2528 2019-02-12  Rob Buis  <rbuis@igalia.com>
2529
2530         Implement serializing in MIME type parser
2531         https://bugs.webkit.org/show_bug.cgi?id=193909
2532
2533         Reviewed by Darin Adler.
2534
2535         Add various tests involving upper case, non-ASCII, control/null characters,
2536         various HTTP whitespace, single quotes and an unpaired surrogate.
2537
2538         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2539         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2540         (TestWebKitAPI::serializeIfValid):
2541         (TestWebKitAPI::TEST):
2542
2543 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2544
2545         [Cocoa] Ask platform for generic font family mappings
2546         https://bugs.webkit.org/show_bug.cgi?id=187723
2547         <rdar://problem/41892438>
2548
2549         Reviewed by Brent Fulgham.
2550
2551         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2552
2553         * DumpRenderTree/mac/DumpRenderTree.mm:
2554         (allowedFontFamilySet):
2555         * WebKitTestRunner/mac/TestControllerMac.mm:
2556         (WTR::allowedFontFamilySet):
2557
2558 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2559
2560         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2561         https://bugs.webkit.org/show_bug.cgi?id=193622
2562
2563         Reviewed by Michael Catanzaro.
2564
2565         This adds support for loading content extension rule sets from the JSON files which
2566         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2567         of WKTR for this could be removed, but that is left for a follow-up patch with
2568         cleanups.
2569
2570         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2571         * WebKitTestRunner/TestController.cpp:
2572         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2573         avoid having the null-terminator copied into the result.
2574         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2575         part of the preparations to run a test.
2576         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2577         (WTR::contentExtensionStoreCallback): Added.
2578         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2579         used for content extensions test.
2580         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2581         extensions and compiling the JSON rule set for tests involving content extensions.
2582         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2583         testing and disables content extensions.
2584         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2585         resetContentExtensions().
2586         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2587         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2588         configureContentExtensionForTest(), and userContentController().
2589
2590 2019-02-11  Daniel Bates  <dabates@apple.com>
2591
2592         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2593         https://bugs.webkit.org/show_bug.cgi?id=191446
2594         <rdar://problem/45929460>
2595
2596         Reviewed by Tim Horton.
2597
2598         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2599
2600         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2601         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2602         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2603         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2604         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2605         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2606         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2607         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2608         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2609         (WTR::arrayLength):
2610         (WTR::parseModifierArray):
2611         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2612         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2613         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2614         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2615
2616 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2617
2618         Unreviewed, rolling out r241272 and r241276.
2619         https://bugs.webkit.org/show_bug.cgi?id=194514
2620
2621         Broke the Apple Internal build and the fix requires human
2622         intervention :( (Requested by dydz on #webkit).
2623
2624         Reverted changesets:
2625
2626         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2627         https://bugs.webkit.org/show_bug.cgi?id=191446
2628         https://trac.webkit.org/changeset/241272
2629
2630         "Fix internal iOS build after r241272"
2631         https://bugs.webkit.org/show_bug.cgi?id=191446
2632         https://trac.webkit.org/changeset/241276
2633
2634 2019-02-11  Truitt Savell  <tsavell@apple.com>
2635
2636         Unreviewed, rolling out r241269.
2637
2638         Caused 5 layout tests crashes on Mac WK1
2639
2640         Reverted changeset:
2641
2642         "DumpRenderTree should report unknown options"
2643         https://bugs.webkit.org/show_bug.cgi?id=191303
2644         https://trac.webkit.org/changeset/241269
2645
2646 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2647
2648         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2649         https://bugs.webkit.org/show_bug.cgi?id=194313
2650
2651         Reviewed by Tim Horton.
2652
2653         Add a helper to determine whether the web view is presenting modal UI.
2654
2655         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2656         (WTR::UIScriptController::isPresentingModally const):
2657         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2658         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2659         (WTR::UIScriptController::isPresentingModally const):
2660         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2661         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2662         (WTR::UIScriptController::calendarType const): Deleted.
2663         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2664         (WTR::UIScriptController::isPresentingModally const):
2665         (WTR::UIScriptController::calendarType const):
2666         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2667         (WTR::UIScriptController::calendarType const):
2668
2669 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2670
2671         GCHeapInspector: Show the retained sizes in more places
2672         https://bugs.webkit.org/show_bug.cgi?id=194464
2673
2674         Reviewed by Simon Fraser.
2675
2676         * GCHeapInspector/gc-heap-inspector.html:
2677         * GCHeapInspector/script/interface.js:
2678         (HeapInspectorUtils.humanReadableSize):
2679         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2680         (HeapInspectorUtils.spanForNode.span.span):
2681         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2682         (HeapSnapshotInspector.prototype.buildRoots):
2683
2684 2019-02-11  Daniel Bates  <dabates@apple.com>
2685
2686         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2687         https://bugs.webkit.org/show_bug.cgi?id=191446
2688         <rdar://problem/45929460>
2689
2690         Reviewed by Tim Horton.
2691
2692         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2693
2694         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2695         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2696         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2697         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2698         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2699         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2700         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2701         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2702         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2703         (WTR::arrayLength):
2704         (WTR::parseModifierArray):
2705         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2706         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2707         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2708         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2709
2710 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2711
2712         DumpRenderTree should report unknown options
2713         https://bugs.webkit.org/show_bug.cgi?id=191303
2714
2715         Reviewed by Frédéric Wang.
2716
2717         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2718         to report unknown options.
2719         Added and assigned test options which are currently used in tests.
2720
2721         * DumpRenderTree/TestOptions.cpp:
2722         (TestOptions::TestOptions):
2723
2724 2019-02-11  Truitt Savell  <tsavell@apple.com>
2725
2726         Unreviewed, rolling out r241229.
2727
2728         Revision broke internal builds for watchOS.
2729
2730         Reverted changeset:
2731
2732         "[Cocoa] Ask platform for generic font family mappings"
2733         https://bugs.webkit.org/show_bug.cgi?id=187723
2734         https://trac.webkit.org/changeset/241229
2735
2736 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2737
2738         [WinCairo][MiniBrowser] Basic authentication always fails.
2739         https://bugs.webkit.org/show_bug.cgi?id=194496
2740
2741         Reviewed by Don Olmstead.
2742
2743         * MiniBrowser/win/DialogHelper.h:
2744         (Dialog::getText):
2745
2746 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2747
2748         [GStreamer] GstMappedBuffer testsuite build fails
2749         https://bugs.webkit.org/show_bug.cgi?id=194495
2750
2751         Reviewed by Carlos Garcia Campos.
2752
2753         Fix the build by explicitely adding the gstreamer1.0-audio include
2754         directories to the include path.
2755
2756         * TestWebKitAPI/PlatformGTK.cmake:
2757         * TestWebKitAPI/PlatformWPE.cmake:
2758
2759 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         [GTK][WPE] Add enable-javascript-markup setting
2762         https://bugs.webkit.org/show_bug.cgi?id=193439
2763
2764         Reviewed by Michael Catanzaro.
2765
2766         Add test cases to check the new setting.
2767
2768         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2769         (testWebKitSettings):
2770         (testWebKitSettingsJavaScriptMarkup):
2771         (beforeAll):
2772
2773 2019-02-10  Darin Adler  <darin@apple.com>
2774
2775         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2776         https://bugs.webkit.org/show_bug.cgi?id=194485
2777
2778         Reviewed by Daniel Bates.
2779
2780         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2781
2782 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2783
2784         Add more tests for clampTo<>()
2785         https://bugs.webkit.org/show_bug.cgi?id=194462
2786
2787         Reviewed by Geoffrey Garen.
2788
2789         Darin suggested to test the very last floating point number
2790         at the boundaries when truncating to integer.
2791         I added test for max/min and max-1/min-1.
2792
2793         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2794         (TestWebKitAPI::TEST):
2795
2796 2019-02-09  Darin Adler  <darin@apple.com>
2797
2798         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2799         https://bugs.webkit.org/show_bug.cgi?id=194021
2800
2801         Reviewed by Geoffrey Garen.
2802
2803         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2804         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2805         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2806
2807 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2808
2809         [LFC][IFC] Add intrinsic width support for basic inline containers
2810         https://bugs.webkit.org/show_bug.cgi?id=194473
2811
2812         Reviewed by Antti Koivisto.
2813
2814         Expand tests coverage (11 new tests -> 798)
2815
2816         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2817
2818 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2819
2820         Fix MiniBrowser's entitlements
2821         https://bugs.webkit.org/show_bug.cgi?id=192431
2822
2823         Reviewed by Joseph Pecoraro.
2824
2825         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2826         files, making it impossible to load any extension.
2827
2828         * MiniBrowser/MiniBrowser.entitlements:
2829
2830 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2831
2832         [Cocoa] Ask platform for generic font family mappings
2833         https://bugs.webkit.org/show_bug.cgi?id=187723
2834         <rdar://problem/41892438>
2835
2836         Reviewed by Brent Fulgham.
2837
2838         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2839
2840         * DumpRenderTree/mac/DumpRenderTree.mm:
2841         (allowedFontFamilySet):
2842         * WebKitTestRunner/mac/TestControllerMac.mm:
2843         (WTR::allowedFontFamilySet):
2844
2845 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2846
2847         [GTK] Implement back/forward touchpad gesture
2848         https://bugs.webkit.org/show_bug.cgi?id=193919
2849
2850         Reviewed by Michael Catanzaro.
2851
2852         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2853         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2854
2855 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2856
2857         Add SPI to use networking daemon instead of XPC service
2858         https://bugs.webkit.org/show_bug.cgi?id=194427
2859
2860         Reviewed by Geoffrey Garen
2861
2862         * MiniBrowser/MiniBrowser.entitlements:
2863
2864 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2865
2866         [ews-build] Ensure that every builder in config.json has short name
2867         https://bugs.webkit.org/show_bug.cgi?id=194461
2868
2869         Reviewed by Lucas Forschler.
2870
2871         * BuildSlaveSupport/ews-build/loadConfig.py:
2872         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2873
2874 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2875
2876         [ews-build] Add short name to config.json
2877         https://bugs.webkit.org/show_bug.cgi?id=194456
2878
2879         Reviewed by Lucas Forschler.
2880
2881         * BuildSlaveSupport/ews-build/config.json: Added short name.
2882         * BuildSlaveSupport/ews-build/loadConfig.py:
2883         (loadBuilderConfig): Set the short name as the builder description.
2884
2885 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2886
2887         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2888         https://bugs.webkit.org/show_bug.cgi?id=194418
2889
2890         Reviewed by Lucas Forschler.
2891
2892         Do not include errors trying when finding crashlogs at the end of
2893         a run-webkit-tests run since we don't process those errors.
2894
2895         * Scripts/webkitpy/port/darwin.py:
2896         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2897         * Scripts/webkitpy/port/ios_device.py:
2898         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2899         * Scripts/webkitpy/port/watch_device.py:
2900         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2901
2902 2019-02-08  Beth Dakin  <bdakin@apple.com>
2903
2904         Add afterScreenUpdates to WKSnapshotConfiguration
2905         https://bugs.webkit.org/show_bug.cgi?id=194362
2906         -and corresponding-
2907         <rdar://problem/40655528> Please add an "after screen updates" property to 
2908         WKSnapshotConfiguration (to solve blank snapshots)
2909
2910         Reviewed by Tim Horton.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2913         (TEST):
2914
2915 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2916
2917         clampTo(): do not convert the input to double when dealing with integers
2918         https://bugs.webkit.org/show_bug.cgi?id=194263
2919         <rdar://problem/47692312>
2920
2921         Reviewed by Darin Adler.
2922
2923         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2924         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2925         (TestWebKitAPI::testClampFloatingPointToInteger):
2926         (TestWebKitAPI::testClampSameSignIntegers):
2927         (TestWebKitAPI::testClampUnsignedToSigned):
2928         (TestWebKitAPI::testClampSignedToUnsigned):
2929
2930 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2931
2932         webkitpy: Respect --dedicated-simulators flag
2933         https://bugs.webkit.org/show_bug.cgi?id=194416
2934         <rdar://problem/47894722>
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * Scripts/webkitpy/port/device_port.py:
2939         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2940         available devices can be safely ignored.
2941
2942 2019-02-07  Keith Rollin  <krollin@apple.com>
2943
2944         Remove extra copy of 100x100-red.tga
2945         https://bugs.webkit.org/show_bug.cgi?id=194371
2946         <rdar://problem/47873465>
2947
2948         Reviewed by Said Abou-Hallawa.
2949
2950         In order to help it pass its tests, Bug 194190 added a second copy of
2951         the file 100x100-red.tga. However, it turns out that this additional
2952         file wasn't actually needed, and that that sole previous copy was
2953         sufficient. At the same time, this second copy -- which was copied to
2954         the same location in the build output as the first copy -- now caused
2955         XCBuild to complain because there were two production rules for the
2956         same output file. Address this by removing the newly-added extra copy.
2957
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2960
2961 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2962
2963         Deprecate WKBundlePageSetDefersLoading
2964         https://bugs.webkit.org/show_bug.cgi?id=191394
2965
2966         Reviewed by Dean Jackson.
2967
2968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2969         (WTR::TestRunner::setDefersLoading):
2970
2971 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2972
2973         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2974         https://bugs.webkit.org/show_bug.cgi?id=194391
2975
2976         Reviewed by Antti Koivisto.
2977
2978         * LayoutReloaded/misc/LFC-passing-tests.txt:
2979
2980 2019-02-06  Keith Rollin  <krollin@apple.com>
2981
2982         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2983         https://bugs.webkit.org/show_bug.cgi?id=193975
2984         <rdar://problem/47643306>
2985
2986         Reviewed by Tim Horton.
2987
2988         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2989         the Info.plist file into the bundle. This step is not necessary as the
2990         implicit "bundle up all the build products into a framework" build
2991         phase does this already. Having the Copy Bundle Resources phase do
2992         this causes a conflict under XCBuild, which objects to two build
2993         phases producing the same file (Info.plist). Address this by removing
2994         Info.plist from the Copy Bundle Resources phase.
2995
2996         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2997
2998 2019-02-06  Keith Rollin  <krollin@apple.com>
2999
3000         Really enable the automatic checking and regenerations of .xcfilelists during builds
3001         https://bugs.webkit.org/show_bug.cgi?id=194357
3002         <rdar://problem/47861231>
3003
3004         Reviewed by Chris Dumez.
3005
3006         Bug 194124 was supposed to enable the automatic checking and
3007         regenerating of .xcfilelist files during the build. While related
3008         changes were included in that patch, the change to actually enable the
3009         operation somehow was omitted. This patch actually enables the
3010         operation. The check-xcfilelist.sh scripts now check
3011         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3012         from the checking.
3013
3014         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3015         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3016
3017 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3018
3019         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3020         <https://webkit.org/b/194286>
3021         <rdar://problem/47815558>
3022
3023         Reviewed by Alexey Proskuryakov.
3024
3025         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3026         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3027         WKRetainPtr<> to avoid leaking the WKDataRef.
3028
3029 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3030
3031         Unreviewed, fix a typo
3032
3033         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3034
3035 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3036
3037         [GTK][WPE] force libpsl build to use ICU in jhbuild
3038         https://bugs.webkit.org/show_bug.cgi?id=194288
3039
3040         Reviewed by Carlos Garcia Campos.
3041
3042         * gtk/jhbuild.modules:
3043         Require ICU for libpsl build in jhbuild, like done in WPE.
3044
3045 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3046
3047         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3048         https://bugs.webkit.org/show_bug.cgi?id=194209
3049
3050         Reviewed by Carlos Garcia Campos.
3051
3052         Enhance TestCookieManager to ensure this doesn't happen again.
3053
3054         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3055         (testCookieManagerPersistentStorage):
3056         (beforeAll):
3057
3058 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3059
3060         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3061         https://bugs.webkit.org/show_bug.cgi?id=194324
3062
3063         Reviewed by Andy Estes.
3064
3065         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3066         part of the name is already implicit, since this is in testing code in TestOptions.
3067
3068         * WebKitTestRunner/TestController.cpp:
3069         (WTR::TestController::generateContextConfiguration const):
3070         (WTR::updateTestOptionsFromTestHeader):
3071         * WebKitTestRunner/TestOptions.h:
3072         (WTR::TestOptions::hasSameInitializationOptions const):
3073
3074 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3075
3076         [ews-build] Allow * as platform for builders and workers
3077         https://bugs.webkit.org/show_bug.cgi?id=188533
3078
3079         Reviewed by Lucas Forschler.
3080
3081         * BuildSlaveSupport/ews-build/loadConfig.py:
3082         (checkWorkersAndBuildersForConsistency):
3083
3084 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3085
3086         [ews-build] Add few bots to config.json
3087         https://bugs.webkit.org/show_bug.cgi?id=194304
3088
3089         Reviewed by Lucas Forschler.
3090
3091         * BuildSlaveSupport/ews-build/config.json:
3092
3093 2019-02-05  Keith Rollin  <krollin@apple.com>
3094
3095         Enable the automatic checking and regenerations of .xcfilelists during builds
3096         https://bugs.webkit.org/show_bug.cgi?id=194124
3097         <rdar://problem/47721277>
3098
3099         Reviewed by Tim Horton.
3100
3101         Bug 193790 add a facility for checking -- during build time -- that
3102         any needed .xcfilelist files are up-to-date and for updating them if
3103         they are not. This facility was initially opt-in by setting
3104         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3105         the process seemed robust. Its now time to enable this facility and
3106         make it opt-out. If there is a need to disable this facility, set and
3107         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3108         running `make` or `build-webkit`, or before running Xcode from the
3109         command line.
3110
3111         Additionally, remove the step that generates a list of source files
3112         going into the UnifiedSources build step. It's only necessarily to
3113         specify Sources.txt and SourcesCocoa.txt as inputs.
3114
3115         * Scripts/generate-xcfilelists:
3116
3117 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3118
3119         [GTK][WPE] force libpsl build to use ICU in jhbuild
3120         https://bugs.webkit.org/show_bug.cgi?id=194288
3121
3122         Reviewed by Philippe Normand.
3123
3124         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3125         This can cause build failures if libidn is detected but libunistring is not available.
3126
3127         Make sure that ICU is used for runtime and builtin PSL data.
3128
3129         * gtk/jhbuild.modules:
3130         * wpe/jhbuild.modules:
3131
3132 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3133
3134         [ews-app] Modified timestamp should be updated on updating data
3135         https://bugs.webkit.org/show_bug.cgi?id=194295
3136
3137         Reviewed by Lucas Forschler.
3138
3139         * BuildSlaveSupport/ews-app/ews/models/build.py:
3140         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3141         * BuildSlaveSupport/ews-app/ews/models/step.py:
3142
3143 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3144
3145         Unreviewed, rolling out r240742.
3146
3147         Causes crashes on iOS simulator.
3148
3149         Reverted changeset:
3150
3151         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3152         not focused in a content-editable element"
3153         https://bugs.webkit.org/show_bug.cgi?id=192824
3154         https://trac.webkit.org/changeset/240742
3155
3156 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3157
3158         run-webkit-tests emits message "...running None" when running tests
3159         https://bugs.webkit.org/show_bug.cgi?id=194133
3160         <rdar://problem/47724738>
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * Scripts/webkitpy/xcode/device_type.py:
3165         (DeviceType.__str__): Use both version mapping tables and use just the variant
3166         name if no version name is available.
3167         * Scripts/webkitpy/xcode/device_type_unittest.py:
3168         (DeviceTypeTest):
3169         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3170         an associated named.
3171
3172 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3173
3174         [WPE] require python3-setuptools for meson build in jhbuild
3175         https://bugs.webkit.org/show_bug.cgi?id=194287
3176
3177         Reviewed by Philippe Normand.
3178
3179         python3-setuptools is needed to build meson in jhbuild.
3180         It is already required by the GTK port.
3181
3182         * wpe/install-dependencies:
3183
3184 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3185
3186         [ews-app] Add method to save BuilderMapping to database
3187         https://bugs.webkit.org/show_bug.cgi?id=194264
3188
3189         Reviewed by Lucas Forschler.
3190
3191         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3192         (BuilderMapping.__str__):
3193         (BuilderMapping):
3194         (BuilderMapping.save_mapping):
3195         (BuilderMapping.update_mapping):
3196         (BuilderMapping.get_existing_mapping):
3197         (BuilderMapping.is_valid_mapping):
3198
3199 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3200
3201         [ews-app] Add timestamp fields for BuilderMappings
3202         https://bugs.webkit.org/show_bug.cgi?id=194266
3203
3204         Reviewed by Lucas Forschler.
3205
3206         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3207         (BuilderMapping):
3208
3209 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3210
3211         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3212         https://bugs.webkit.org/show_bug.cgi?id=174816
3213
3214         Reviewed by Michael Catanzaro.
3215
3216         Add tests for webkit_uri_for_display().
3217
3218         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3219         (testURIForDisplayUnaffected):
3220         (testURIForDisplayAffected):
3221         (beforeAll):
3222         (afterAll):
3223         * TestWebKitAPI/glib/CMakeLists.txt:
3224
3225 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3226
3227         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3228         https://bugs.webkit.org/show_bug.cgi?id=194158
3229         <rdar://problem/47737268>
3230
3231         Rubber-stamped by Aakash Jain.
3232
3233         * Scripts/webkitpy/port/device_port.py:
3234         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3235
3236 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3237
3238         [CG] Enable setAdditionalSupportedImageTypes for WK1
3239         https://bugs.webkit.org/show_bug.cgi?id=194190
3240
3241         Reviewed by Tim Horton.
3242
3243         Add a test similar to the one under WebKit Cocoa but make it create a
3244         WebView instead of a WKWebView.
3245
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3248         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3249         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3250         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3251         (TestWebKitAPI::runTest):
3252         (TestWebKitAPI::TEST):
3253
3254 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3255
3256         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3257         https://bugs.webkit.org/show_bug.cgi?id=194168
3258
3259         Reviewed by Simon Fraser.
3260
3261         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3262
3263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3264         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3265         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3266         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3267         (TEST):
3268         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3269         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3270
3271 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3272
3273         REGRESSION (r237269): webkit-patch what-broke is broken 
3274         https://bugs.webkit.org/show_bug.cgi?id=193025
3275
3276         Reviewed by Aakash Jain.
3277
3278         * Scripts/webkitpy/common/host.py:
3279         (Host.buildbot):
3280         (Host.bugzilla): Renamed to 'buildbot'.
3281
3282 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3283
3284         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3285         https://bugs.webkit.org/show_bug.cgi?id=194207
3286
3287         Reviewed by Tim Horton.
3288
3289         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3290         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3291         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3292         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3293         start and delete forwards to remove the original attachment.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3296         (TestWebKitAPI::TEST):
3297
3298 2019-02-04  Youenn Fablet  <youenn@apple.com>
3299
3300         Capture state should be managed consistently when doing process swapping
3301         https://bugs.webkit.org/show_bug.cgi?id=194122
3302         <rdar://problem/47609293>
3303
3304         Reviewed by Eric Carlson.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3307         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3308         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3309         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3312         (WTR::TestRunner::isDoingMediaCapture const):
3313         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::isDoingMediaCapture const):
3316         * WebKitTestRunner/TestController.h:
3317         * WebKitTestRunner/TestInvocation.cpp:
3318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3319         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3320         (WTR::TestController::isDoingMediaCapture const):
3321
3322 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3323
3324         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3325         https://bugs.webkit.org/show_bug.cgi?id=194142
3326
3327         Reviewed by Ross Kirsling.
3328
3329         There three 'separator' variables in TestController.cpp. Renamed
3330         it 'pathSeparator', and unified them.
3331
3332         * WebKitTestRunner/TestController.cpp:
3333         (WTR::TestController::generateContextConfiguration const):
3334         (WTR::createTestURL):
3335         (WTR::TestController::platformAdjustContext):
3336
3337 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3338
3339         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3340         https://bugs.webkit.org/show_bug.cgi?id=194198
3341
3342         Reviewed by Antti Koivisto.
3343
3344         No need to set the banner heights on navigation now, since Page stores them.
3345
3346         * MiniBrowser/mac/WK2BrowserWindowController.m:
3347         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3348
3349 2019-02-03  John Wilander  <wilander@apple.com>
3350
3351         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3352         https://bugs.webkit.org/show_bug.cgi?id=194104
3353         <rdar://problem/47649991>
3354
3355         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3356
3357         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3358         (TestWebKitAPI::TEST):
3359             Changed numeric types from unsigned short to uint32_t.
3360
3361 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3362
3363         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3364         <https://webkit.org/b/194178>
3365         <rdar://problem/47753473>
3366
3367         Reviewed by Alexey Proskuryakov.
3368
3369         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3370         (WTR::uninstallFakeHelvetica): Pass nullptr into
3371         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3372
3373 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3374
3375         [LFC] Initialize ICB's style with fixed width/height.
3376         https://bugs.webkit.org/show_bug.cgi?id=194188
3377
3378         Reviewed by Antti Koivisto.
3379
3380         * LayoutReloaded/misc/LFC-passing-tests.txt:
3381
3382 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3383
3384         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3385         https://bugs.webkit.org/show_bug.cgi?id=194185
3386
3387         Reviewed by Antti Koivisto.
3388
3389         * LayoutReloaded/misc/LFC-passing-tests.txt:
3390
3391 2018-12-16  Darin Adler  <darin@apple.com>
3392
3393         Convert additional String::format clients to alternative approaches
3394         https://bugs.webkit.org/show_bug.cgi?id=192746
3395
3396         Reviewed by Alexey Proskuryakov.
3397
3398         * WebKitTestRunner/TestController.cpp:
3399         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3400         as an intermediate in code that ultimately constructs a WTF::String.
3401         (WTR::userMediaOriginHash): Use makeString.
3402         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3403         (WTR::TestController::didPerformClientRedirect): Ditto.
3404         (WTR::TestController::didPerformServerRedirect): Ditto.
3405         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3406
3407 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3408
3409         [ews-build] Add unit test to verify builder keys
3410         https://bugs.webkit.org/show_bug.cgi?id=194152
3411
3412         Reviewed by Lucas Forschler.
3413
3414         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3415         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3416
3417 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3418
3419         [LFC] Expand tests coverage (12 new tests -> 787)
3420
3421         Unreviewed test gardening.
3422
3423         * LayoutReloaded/misc/LFC-passing-tests.txt:
3424
3425 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3426
3427         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3428         https://bugs.webkit.org/show_bug.cgi?id=194163
3429
3430         Reviewed by Simon Fraser.
3431
3432         775
3433
3434         * LayoutReloaded/misc/LFC-passing-tests.txt:
3435
3436 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3437
3438         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3439         https://bugs.webkit.org/show_bug.cgi?id=194140
3440         <rdar://problem/47728098>
3441
3442         Reviewed by Tim Horton.
3443
3444         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3445         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3446         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3447
3448         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3449         test to induce an IPC deadlock when presenting a modal alert during touch start.
3450
3451         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3452         * WebKitTestRunner/TestController.cpp:
3453         (WTR::runJavaScriptAlert):
3454
3455         Add a client callback function for running JavaScript alerts.
3456
3457         (WTR::TestController::createOtherPage):
3458         (WTR::TestController::generateContextConfiguration const):
3459
3460         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3461         the fix in this patch.
3462
3463         (WTR::TestController::createWebViewWithOptions):
3464
3465         Plumb TestOptions to generateContextConfiguration.
3466
3467         (WTR::TestController::resetPreferencesToConsistentValues):
3468         (WTR::TestController::resetStateToConsistentValues):
3469         (WTR::updateTestOptionsFromTestHeader):
3470         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3471         (WTR::TestController::handleJavaScriptAlert):
3472         * WebKitTestRunner/TestController.h:
3473         * WebKitTestRunner/TestInvocation.cpp:
3474         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3475         * WebKitTestRunner/TestOptions.h:
3476         (WTR::TestOptions::hasSameInitializationOptions const):
3477
3478 2019-02-01  Chris Dumez  <cdumez@apple.com>
3479
3480         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3481         https://bugs.webkit.org/show_bug.cgi?id=193740
3482         <rdar://problem/47527267>
3483
3484         Reviewed by Alex Christensen.
3485
3486         Add API test coverage.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3489
3490 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-app] Add display name field to BuilderMapping model
3493         https://bugs.webkit.org/show_bug.cgi?id=194153
3494
3495         Reviewed by Lucas Forschler.
3496
3497         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3498         (BuilderMapping):
3499
3500 2019-02-01  Youenn Fablet  <youenn@apple.com>
3501
3502         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3503         https://bugs.webkit.org/show_bug.cgi?id=194155
3504
3505         Reviewed by Eric Carlson.
3506
3507         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3508         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3509         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3510
3511 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3512
3513         [LFC] Adjust replaced element's intrinsic ratio
3514         https://bugs.webkit.org/show_bug.cgi?id=194154
3515
3516         Reviewed by Antti Koivisto.
3517
3518         761
3519
3520         * LayoutReloaded/misc/LFC-passing-tests.txt:
3521
3522 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3523
3524         [WPE] Show test results in minibrowser
3525         https://bugs.webkit.org/show_bug.cgi?id=194150
3526
3527         Reviewed by Žan Doberšek.
3528
3529         * Scripts/webkitpy/port/wpe.py:
3530         (WPEPort.show_results_html_file):
3531
3532 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3535         https://bugs.webkit.org/show_bug.cgi?id=194151
3536
3537         Reviewed by Žan Doberšek.
3538
3539         ALT + <- go back
3540         ALT + -> go forward
3541
3542         * MiniBrowser/wpe/main.cpp:
3543         (main):
3544
3545 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3546
3547         [LFC] Set intrinsic size on Layout::Replaced
3548         https://bugs.webkit.org/show_bug.cgi?id=194139
3549
3550         Reviewed by Antti Koivisto.
3551
3552         744
3553
3554         * LayoutReloaded/misc/LFC-passing-tests.txt:
3555
3556 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3557
3558         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3559         https://bugs.webkit.org/show_bug.cgi?id=194146
3560
3561         Reviewed by Xabier Rodriguez-Calvar.
3562
3563         It allows to open relative paths.
3564
3565         * MiniBrowser/wpe/main.cpp:
3566         (main):
3567
3568 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3569
3570         Update flakiness dashboard configuration after recent queue changes
3571         https://bugs.webkit.org/show_bug.cgi?id=194127
3572
3573         Rubber-stamped by Aakash Jain.
3574
3575         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3576
3577         * TestResultServer/static-dashboards/builders.jsonp:
3578
3579 2019-01-31  Youenn Fablet  <youenn@apple.com>
3580
3581         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3582         https://bugs.webkit.org/show_bug.cgi?id=194106
3583         <rdar://problem/47676333>
3584
3585         Reviewed by Ryosuke Niwa.
3586
3587         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3588         (TestWebKitAPI::didFinishNavigation):
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3591
3592 2019-01-31  Chris Dumez  <cdumez@apple.com>
3593
3594         Page zoom level is lost after a process swap or a crash
3595         https://bugs.webkit.org/show_bug.cgi?id=194105
3596         <rdar://problem/47610781>
3597
3598         Reviewed by Alex Christensen.
3599
3600         Add API test coverage.
3601
3602         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3603         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3604
3605 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3606
3607         Revert r238819 which is unneeded and caused a performance regression.
3608         https://bugs.webkit.org/show_bug.cgi?id=192272
3609         <rdar://problem/46664625>
3610
3611         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3612         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3613         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3614
3615 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3616
3617         Formalize WebKitAdditions mechanism of LoadOptimizer
3618         https://bugs.webkit.org/show_bug.cgi?id=193886
3619         <rdar://problem/47696809>
3620
3621         Reviewed by Brent Fulgham.
3622
3623         * MiniBrowser/MiniBrowser.entitlements:
3624         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3625
3626 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3627
3628         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3629         https://bugs.webkit.org/show_bug.cgi?id=194090
3630
3631         Reviewed by Antti Koivisto.
3632
3633         * LayoutReloaded/misc/LFC-passing-tests.txt:
3634
3635 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3636
3637         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3638         https://bugs.webkit.org/show_bug.cgi?id=194074
3639
3640         Reviewed by Antti Koivisto.
3641
3642         * LayoutReloaded/misc/LFC-passing-tests.txt:
3643
3644 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3645
3646         [LFC][BFC] Add support for block level replaced box.
3647         https://bugs.webkit.org/show_bug.cgi?id=194071
3648
3649         Reviewed by Antti Koivisto.
3650
3651         * LayoutReloaded/misc/LFC-passing-tests.txt:
3652
3653 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3654
3655         Fix WebKitTestRunner's testPath with Windows full paths
3656         https://bugs.webkit.org/show_bug.cgi?id=194012
3657
3658         Reviewed by Alex Christensen.
3659
3660         updateTestOptionsFromTestHeader failed to open test files because
3661         testPath returned wrong file paths. It returned a path "/C:/..."
3662         if a URL "file:///C:/..." was given.
3663
3664         * WebKitTestRunner/TestController.cpp:
3665         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3666
3667 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3668
3669         [WPE] Bump font related dependencies to match the GTK+ port
3670         https://bugs.webkit.org/show_bug.cgi?id=194017
3671
3672         Reviewed by Žan Doberšek.
3673
3674         * wpe/jhbuild.modules:
3675         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3676         * wpe/patches/icudata-stdlibs.patch: Added.
3677
3678 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3679
3680         Enable swipe tests on iOS
3681         https://bugs.webkit.org/show_bug.cgi?id=194076
3682
3683         Reviewed by Geoffrey Garen.
3684
3685         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3686         it causes a debug assertion failure in runUIScript.
3687
3688         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3689         (WTR::UIScriptController::beginBackSwipe):
3690         (WTR::UIScriptController::completeBackSwipe):
3691
3692 2019-01-30  Keith Rollin  <krollin@apple.com>
3693
3694         Use correct printf format specifier
3695         https://bugs.webkit.org/show_bug.cgi?id=194062
3696         <rdar://problem/47686167>
3697
3698         Reviewed by Alexey Proskuryakov.
3699
3700         LayoutTestSpellChecker.mm is trying to format a variable of type
3701         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3702         actually an unsigned long long. Fix this by formatting with %llu.
3703
3704         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3705         (-[LayoutTestTextCheckingResult description]):
3706
3707 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3708
3709         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3710         https://bugs.webkit.org/show_bug.cgi?id=193979
3711
3712         Reviewed by Wenson Hsieh.
3713
3714         Fix the test for iOS. Make the test work with iOS UA string.
3715
3716         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3717
3718 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3719
3720         Replace High Sierra LLINT CLoop bot due to hardware failure
3721         https://bugs.webkit.org/show_bug.cgi?id=194066
3722
3723         Reviewed by Aakash Jain.
3724
3725         * BuildSlaveSupport/build.webkit.org-config/config.json:
3726
3727 2019-01-30  Keith Rollin  <krollin@apple.com>
3728
3729         [NSDragItem init] is unavailable
3730         https://bugs.webkit.org/show_bug.cgi?id=194059
3731         <rdar://problem/47685715>
3732
3733         Reviewed by Wenson Hsieh.
3734
3735         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3736         DumpRenderTree and TestWebKitAPI, which both try to create an
3737         NSDragItem in a manner that invokes this method. Address this by using
3738         -initWithPasteboardWriter instead.
3739
3740         Note that the parameter passed to initWithPasteboardWriter is likely
3741         incorrect. In both cases, the object passed does not conform to
3742         NSPasteboardWriting. However, with this fix, we're no worse off than
3743         before, and can now perform builds with newer compilers and SDKs until
3744         a real fix can be crafted. That work is tracked in
3745         https://bugs.webkit.org/show_bug.cgi?id=194060
3746
3747         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3748         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3749         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3750         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3751
3752 2019-01-30  Daniel Bates  <dabates@apple.com>
3753
3754         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3755         https://bugs.webkit.org/show_bug.cgi?id=192824
3756         <rdar://problem/47100332>
3757
3758         Reviewed by Wenson Hsieh.
3759
3760         Fix a bug where the wrong usage code was used for F13 thru F24.
3761
3762         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3763         (keyCodeForDOMFunctionKey):
3764
3765 2019-01-30  Chris Dumez  <cdumez@apple.com>
3766
3767         Regression(PSON) Load hang can occur on history navigation
3768         https://bugs.webkit.org/show_bug.cgi?id=194030
3769         <rdar://problem/47656939>
3770
3771         Reviewed by Antti Koivisto.
3772
3773         Add API test coverage.
3774
3775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3776
3777 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3778
3779         [LFC] Expand tests coverage.
3780
3781         Unreviewed test gardening.
3782
3783         * LayoutReloaded/misc/LFC-passing-tests.txt:
3784
3785 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3786
3787         [Flatpak] Add openjpeg support
3788         https://bugs.webkit.org/show_bug.cgi?id=194019
3789
3790         Reviewed by Michael Catanzaro.
3791
3792         * flatpak/org.webkit.CommonModules.yaml:
3793
3794 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3795
3796         Unreviewed, rolling out r240708.
3797         https://bugs.webkit.org/show_bug.cgi?id=194022
3798
3799         It broke WPE build (Requested by KaL on #webkit).
3800
3801         Reverted changeset:
3802
3803         "[WPE] Bump font related dependencies to match the GTK+ port"
3804         https://bugs.webkit.org/show_bug.cgi?id=194017
3805         https://trac.webkit.org/changeset/240708
3806
3807 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3808
3809         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3810         https://bugs.webkit.org/show_bug.cgi?id=194001
3811
3812         Reviewed by Antti Koivisto.
3813
3814         * LayoutReloaded/misc/LFC-passing-tests.txt:
3815
3816 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3817
3818         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3819         https://bugs.webkit.org/show_bug.cgi?id=194020
3820
3821         Reviewed by Antti Koivisto.
3822
3823         * LayoutReloaded/misc/LFC-passing-tests.txt:
3824
3825 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3826
3827         AX: Support color well on iOS
3828         https://bugs.webkit.org/show_bug.cgi?id=194010
3829
3830         Reviewed by Joanmarie Diggs.
3831
3832         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3833         (WTR::AccessibilityUIElement::stringAttributeValue):
3834
3835 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3836
3837         [WPE] Bump font related dependencies to match the GTK+ port
3838         https://bugs.webkit.org/show_bug.cgi?id=194017
3839
3840         Reviewed by Žan Doberšek.
3841
3842         * wpe/jhbuild.modules:
3843         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3844         * wpe/patches/icudata-stdlibs.patch: Added.
3845
3846 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3847
3848         [Mac] Update window scale API usage
3849         https://bugs.webkit.org/show_bug.cgi?id=193991
3850         rdar://problem/47614795
3851
3852         Reviewed by Tim Horton.
3853
3854         * DumpRenderTree/mac/DumpRenderTree.mm:
3855         (changeWindowScaleIfNeeded):
3856         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3857         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3858         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3859
3860 2019-01-29  Chris Dumez  <cdumez@apple.com>
3861
3862         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3863         https://bugs.webkit.org/show_bug.cgi?id=193977
3864         <rdar://problem/47643716>
3865
3866         Reviewed by Geoff Garen.
3867
3868         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3869         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3870         to the previous provisional committing *before* we make the last load. 
3871
3872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3873
3874 2019-01-29  Youenn Fablet  <youenn@apple.com>
3875
3876         Adopt new SPI to evaluate server certificate trust
3877         https://bugs.webkit.org/show_bug.cgi?id=193355
3878
3879         Reviewed by Alex Christensen.
3880
3881         Add infrastructure to handle HTTPS server trust evaluation testing.
3882
3883         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3885         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3886         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3887         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3888         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3889         * WebKitTestRunner/TestController.cpp:
3890         (WTR::TestController::resetPreferencesToConsistentValues):
3891         (WTR::TestController::didReceiveAuthenticationChallenge):
3892         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3893         * WebKitTestRunner/TestController.h:
3894         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3895         * WebKitTestRunner/TestInvocation.cpp:
3896         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3897         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3898         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3899
3900 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3901
3902         [ews-build] Add build step to print bot Configuration
3903         https://bugs.webkit.org/show_bug.cgi?id=193887
3904
3905         Reviewed by Lucas Forschler.
3906
3907         * BuildSlaveSupport/ews-build/steps.py:
3908         (PrintConfiguration): Build step to print configuration.
3909         * BuildSlaveSupport/ews-build/factories.py:
3910
3911 2019-01-29  Chris Dumez  <cdumez@apple.com>
3912
3913         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3914         https://bugs.webkit.org/show_bug.cgi?id=193967
3915         <rdar://problem/47635348>
3916
3917         Reviewed by Alex Christensen.
3918
3919         Add API test coverage.
3920
3921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3922         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3923
3924 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3925
3926         [ews-app] Handle incoming results data
3927         https://bugs.webkit.org/show_bug.cgi?id=193973
3928
3929         Reviewed by Lucas Forschler.
3930
3931         * BuildSlaveSupport/ews-app/ews/views/results.py:
3932
3933 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [ews-app] Make the results url generic
3936         https://bugs.webkit.org/show_bug.cgi?id=193928
3937
3938         Reviewed by Lucas Forschler.
3939
3940         * BuildSlaveSupport/ews-app/ews/urls.py:
3941
3942 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3943
3944         [ews-build] Configure buildbot to send events to ews-app
3945         https://bugs.webkit.org/show_bug.cgi?id=193968
3946
3947         Reviewed by Lucas Forschler.
3948
3949         * BuildSlaveSupport/ews-build/events.py: Added.
3950         * BuildSlaveSupport/ews-build/master.cfg:
3951
3952 2019-01-29  Keith Rollin  <krollin@apple.com>
3953
3954         Add .xcfilelists to Run Script build phases
3955         https://bugs.webkit.org/show_bug.cgi?id=193792
3956         <rdar://problem/47201785>
3957
3958         Reviewed by Alex Christensen.
3959
3960         As part of supporting XCBuild, update the necessary Run Script build
3961         phases in their Xcode projects to refer to their associated
3962         .xcfilelist files.
3963
3964         Note that the addition of these files bumps the Xcode project version
3965         number to something that's Xcode 10 compatible. This change means that
3966         older versions of the Xcode IDE can't read these projects. Nor can it
3967         fully load workspaces that refer to these projects (the updated
3968         projects are shown as non-expandable placeholders). `xcodebuild` can
3969         still build these projects; it's just that the IDE can't open them.
3970
3971         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3972         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3973
3974 2019-01-29  John Wilander  <wilander@apple.com>
3975
3976         Add data abstraction and validation for Ad Click Attribution
3977         https://bugs.webkit.org/show_bug.cgi?id=193916
3978         <rdar://problem/47603481>
3979
3980         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3981
3982         Ad click attribution has two steps. First, the storage of an ad
3983         campaign ID for a click that takes the user to a destination
3984         site. Second, a conversion on the destination site that can be
3985         attributed to the ad click.
3986
3987         This patch adds a class that represents a request for ad click
3988         attribution. Validation makes sure that the bits of entropy
3989         reported through this mechanism is limited.
3990
3991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3992         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3993         (TestWebKitAPI::TEST):
3994
3995 2019-01-29  Chris Dumez  <cdumez@apple.com>
3996
3997         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3998         https://bugs.webkit.org/show_bug.cgi?id=193932
3999         <rdar://problem/47598947>
4000
4001         Reviewed by Brady Eidson.
4002
4003         Add API test coverage.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4006
4007 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4008
4009         Adding new passing LFC tests.
4010
4011         Unreviewed test gardening.
4012
4013         * LayoutReloaded/misc/LFC-passing-tests.txt:
4014
4015 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4016
4017         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4018         https://bugs.webkit.org/show_bug.cgi?id=193964
4019
4020         Reviewed by Antti Koivisto.
4021
4022         * LayoutReloaded/misc/LFC-passing-tests.txt:
4023
4024 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4025
4026         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4027         https://bugs.webkit.org/show_bug.cgi?id=193954
4028
4029         Reviewed by Antti Koivisto.
4030
4031         * LayoutReloaded/misc/LFC-passing-tests.txt:
4032
4033 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4034
4035         WebDriver: add support for running subtests
4036         https://bugs.webkit.org/show_bug.cgi?id=193904
4037
4038         Reviewed by Michael Catanzaro.
4039
4040         pytest already supports it by passing test.py::subtest, so we can do the same.
4041
4042         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4043         (get_item_name): Made this global.
4044         (CollectRecorder.__init__): Receive the parameter to ignore.
4045         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4046         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4047         (collect): Add parameter to ignore.
4048         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4049         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4050         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4051         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4052         (WebDriverTestRunnerSelenium.run): Ditto.
4053         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4054         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4055         (WebDriverTestRunnerW3C.run): Ditto.
4056
4057 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4058
4059         User agent string override for navigator.userAgent should be site specific quirks
4060         https://bugs.webkit.org/show_bug.cgi?id=193950
4061
4062         Reviewed by Brent Fulgham.
4063
4064         Updated per the _WKWebsitePolicies rename.
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4067         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4068
4069 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4070
4071         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4072         https://bugs.webkit.org/show_bug.cgi?id=193941
4073
4074         Reviewed by Alex Christensen.
4075
4076         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4077         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4078         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4079         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4080         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4081         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4082         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4083         * TestWebKitAPI/Tests/WTF/Time.cpp:
4084         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4085         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4086         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4087         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4088
4089 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4090
4091         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4092
4093         * Scripts/webkitpy/common/config/contributors.json:
4094
4095 2019-01-28  Andy Estes  <aestes@apple.com>
4096
4097         [watchOS] Enable Parental Controls content filtering
4098         https://bugs.webkit.org/show_bug.cgi?id=193939
4099         <rdar://problem/46641912>
4100
4101         Reviewed by Ryosuke Niwa.
4102
4103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4104
4105 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4106
4107         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4108         <https://webkit.org/b/193884>
4109
4110         Reviewed by Jiewen Tan.
4111
4112         * Scripts/webkitpy/style/checkers/cpp.py:
4113         (check_language): Add LocalAuthentication to
4114         `frameworks_with_soft_links`.
4115
4116 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4117
4118         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4119         https://bugs.webkit.org/show_bug.cgi?id=193891
4120
4121         Reviewed by Ross Kirsling.
4122
4123         There were three problems in window sizes of WebView and the host window.
4124         1. The sizes of pixel image output were incorrect.
4125         2. The host window is going to appear after window.resize was invoked.
4126         3. window.resize resized only the host window, not WebView.
4127
4128         This change solves them with a following approach.
4129         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4130         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4131            as well as DumpRenderTree in order to match the client area and the window area.
4132         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4133         d. PlatformWebView::setWindowFrame changes both window sizes.
4134         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4135
4136         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4137         (WTR::PlatformWebView::PlatformWebView): Create the host window
4138         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4139         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4140         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4141
4142 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4143
4144         [ews-app] Add method to save Step data to database
4145         https://bugs.webkit.org/show_bug.cgi?id=193890
4146
4147         Reviewed by Lucas Forschler.
4148
4149         * BuildSlaveSupport/ews-app/ews/models/step.py:
4150         (Step.save_step): Method to save step data.
4151         (Step.update_step): Method to update step data.
4152         (Step.get_existing_step): Method to fetch existing step from database.
4153         (Step.is_valid_result): Method to validate valid step result.
4154
4155 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4156
4157         [ews-app] Add method to save Build data to database
4158         https://bugs.webkit.org/show_bug.cgi?id=193735
4159
4160         Reviewed by Lucas Forschler.
4161
4162         * BuildSlaveSupport/ews-app/ews/models/build.py:
4163         (Build.save_build): Method to save build information to database.
4164         (Build.get_existing_build): Method to fetch existing build from database.
4165         (Build.is_valid_result): Method to validate build result.
4166         * BuildSlaveSupport/ews-app/ews/common/util.py:
4167         (is_valid_int_id): Method to validate valid id.
4168
4169 2019-01-28  Chris Dumez  <cdumez@apple.com>
4170
4171         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4172         https://bugs.webkit.org/show_bug.cgi?id=193915
4173         <rdar://problem/47560907>
4174
4175         Reviewed by Alex Christensen.
4176
4177         Add API test coverage.
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4180
4181 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4182
4183         [ews-app] Rename id variables
4184         https://bugs.webkit.org/show_bug.cgi?id=193883
4185
4186         Reviewed by Lucas Forschler.
4187
4188         * BuildSlaveSupport/ews-app/ews/models/build.py:
4189         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4190         * BuildSlaveSupport/ews-app/ews/models/step.py:
4191         * BuildSlaveSupport/ews-app/ews/urls.py:
4192         * BuildSlaveSupport/ews-app/ews/views/patch.py:
4193         * BuildSlaveSupport/ews-app/ews/views/results.py:
4194         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4195
4196 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4197
4198         [ews-app] Allow certain fields to be empty
4199         https://bugs.webkit.org/show_bug.cgi?id=193892
4200
4201         Reviewed by Lucas Forschler.
4202
4203         * BuildSlaveSupport/ews-app/ews/models/build.py:
4204         * BuildSlaveSupport/ews-app/ews/models/step.py:
4205
4206 2019-01-28  Rob Buis  <rbuis@igalia.com>
4207
4208         Update MIME type parser
4209         https://bugs.webkit.org/show_bug.cgi?id=180526
4210
4211         Reviewed by Frédéric Wang.
4212
4213         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4214         (TestWebKitAPI::TEST):
4215
4216 2019-01-28  Zalan Bujtas  <zalan@apple.com>
4217
4218         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
4219         https://bugs.webkit.org/show_bug.cgi?id=193896
4220
4221         Reviewed by Antti Koivisto.
4222
4223         * LayoutReloaded/misc/LFC-passing-tests.txt:
4224
4225 2018-12-15  Darin Adler  <darin@apple.com>
4226
4227         Replace many uses of String::format with more type-safe alternatives
4228         https://bugs.webkit.org/show_bug.cgi?id=192742
4229
4230         Reviewed by Mark Lam.
4231
4232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4233         (WTR::cacheTestRunnerCallback): Use makeString.
4234         * WebKitTestRunner/TestController.cpp:
4235         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4236         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4237
4238 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
4239
4240         Use a load optimizer for some sites
4241         https://bugs.webkit.org/show_bug.cgi?id=193881
4242         <rdar://problem/46325455>
4243
4244         Reviewed by Brent Fulgham.
4245
4246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4247         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
4248
4249 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
4250
4251         AX: Introduce a static accessibility tree
4252         https://bugs.webkit.org/show_bug.cgi?id=193348
4253         <rdar://problem/47203295>
4254
4255         Reviewed by Ryosuke Niwa.
4256
4257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4258
4259 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4260
4261         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
4262         https://bugs.webkit.org/show_bug.cgi?id=193867
4263
4264         Reviewed by Antti Koivisto.
4265
4266         * LayoutReloaded/misc/LFC-passing-tests.txt:
4267
4268 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4269
4270         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
4271         https://bugs.webkit.org/show_bug.cgi?id=193865
4272
4273         Reviewed by Antti Koivisto.
4274
4275         * LayoutReloaded/misc/LFC-passing-tests.txt:
4276
4277 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4278
4279         Need a mechanism to override navigator.userAgent
4280         https://bugs.webkit.org/show_bug.cgi?id=193762
4281         <rdar://problem/47504939>
4282
4283         Reviewed by Brent Fulgham.
4284
4285         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
4286
4287         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4288         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4289         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4290
4291 2019-01-25  Dean Jackson  <dino@apple.com>
4292
4293         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4294         https://bugs.webkit.org/show_bug.cgi?id=193831
4295         <rdar://problem/47399263>
4296
4297         Reviewed by Chris Dumez.
4298
4299         Two new tests that exercise cross-origin and same-origin System
4300         Previews.
4301
4302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4303
4304 2019-01-25  Keith Rollin  <krollin@apple.com>
4305
4306         Update Xcode projects with "Check .xcfilelists" build phase
4307         https://bugs.webkit.org/show_bug.cgi?id=193790
4308         <rdar://problem/47201374>
4309
4310         Reviewed by Alex Christensen.
4311
4312         Support for XCBuild includes specifying inputs and outputs to various
4313         Run Script build phases. These inputs and outputs are specified as
4314         .xcfilelist files. Once created, these .xcfilelist files need to be
4315         kept up-to-date. In order to check that they are up-to-date or not,
4316         add an Xcode build step that invokes an external script that performs
4317         the checking. If the .xcfilelists are found to be out-of-date, update
4318         them, halt the build, and instruct the developer to restart the build
4319         with up-to-date files.
4320
4321         At this time, the checking and regenerating is performed only if the
4322         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4323         who want to use this facility can set this variable and test out the
4324         checking/regenerating. Once it seems like there are no egregious
4325         issues that upset a developer's workflow, we'll unconditionally enable
4326         this facility.
4327
4328         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4329         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4330         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4331         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4332
4333 2019-01-25  Keith Rollin  <krollin@apple.com>
4334
4335         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4336         https://bugs.webkit.org/show_bug.cgi?id=193781
4337         <rdar://problem/47201153>
4338
4339         Reviewed by Alex Christensen.
4340
4341         Part of generating the .xcfilelists used as part of adopting XCBuild
4342         includes running `make DerivedSources.make` from a standalone script.
4343         It’s important for this invocation to have the same environment as
4344         when the actual build invokes `make DerivedSources.make`. If the
4345         environments are different, then the two invocations will provide
4346         different results. In order to get the same environment in the
4347         standalone script, have the script launch xcodebuild targeting the
4348         "Apply Configuration to XCFileLists" build target, which will then
4349         re-invoke our standalone script. The script is now running again, this
4350         time in an environment with all workspace, project, target, xcconfig
4351         and other environment variables established.
4352
4353         The "Apply Configuration to XCFileLists" build target accomplishes
4354         this task via a small embedded shell script that consists only of:
4355
4356             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
4357
4358         The process that invokes "Apply Configuration to XCFileLists" first
4359         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
4360         evaluated and exports it into the shell environment. When xcodebuild
4361         is invoked, it inherits the value of this variable and can `eval` the
4362         contents of that variable. Our external standalone script can then set
4363         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
4364         of command-line parameters needed to restart itself in the appropriate
4365         state.
4366
4367         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4368         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4369
4370 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4371
4372         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
4373         https://bugs.webkit.org/show_bug.cgi?id=193802
4374         <rdar://problem/46010580>
4375
4376         Reviewed by And