Unreviewed, rolling out r212466.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-19  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r212466.
4         https://bugs.webkit.org/show_bug.cgi?id=168577
5
6         causes crashes on AArch64 on linux, maybe it's causing crashes
7         on iOS too (Requested by pizlo on #webkit).
8
9         Reverted changeset:
10
11         "The collector thread should only start when the mutator
12         doesn't have heap access"
13         https://bugs.webkit.org/show_bug.cgi?id=167737
14         http://trac.webkit.org/changeset/212466
15
16 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
17
18         Fix failure from r212579.
19
20         Unreviewed build-fix.
21
22         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
23         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
24
25 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
26
27         EWS should run JavaScriptCore tests
28         https://bugs.webkit.org/show_bug.cgi?id=162458
29
30         Reviewed by Alexey Proskuryakov.
31
32         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
33         * QueueStatusServer/model/queuestatus.py:
34         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
35         * QueueStatusServer/handlers/statusbubble.py:
36         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
37         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
38         (MockSCM.__init__): Add _mockChangedFiles variable.
39         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
40         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
41         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
42         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
43         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
44         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
45         (MacPort.run_webkit_tests_command): Check for JSC.
46         * Scripts/webkitpy/common/config/ports_mock.py:
47         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
48         * Scripts/webkitpy/common/config/ports_unittest.py:
49         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
50         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
51         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
52         (AbstractTestResults.test_results): Stub.
53         (AbstractTestResults.failing_tests): Stub.
54         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
55         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
56         (JSCTestResults): Added.
57         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
58         (JSCTestResults.results_from_string): Use json library to parse results.
59         (JSCTestResults.__init__): Initialize members.
60         (JSCTestResults.equals): This enables unit testing.
61         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
62         (JSCTestResults.all_passed): Getter.
63         (JSCTestResults.failing_tests): Getter.
64         (JSCTestResults.did_exceed_test_failure_limit): Getter.
65         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
66         (JSCTestResultsTest): Class to test JSCTestResults.
67         (JSCTestResultsTest.test_results_from_string): Tests parsing.
68         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
69         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
70         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
71         * Scripts/webkitpy/port/base.py:
72         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
73         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
74         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
75         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
76         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
77         (MockPatchAnalysisTask.__init__): Sets attributes.
78         (MockPatchAnalysisTask._test): Override to not run command.
79         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
80         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
81         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
82         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
83         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
84         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
85         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
86         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
87         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
88         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
89         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
90         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
91         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
92         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
93         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
94         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
95         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
96         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
97         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
98         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
99         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
100         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
101         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
102         (JSCTestResultsReader): Reads results file.
103         (JSCTestResultsReader.__init__): Sets attributes.
104         (JSCTestResultsReader._read_file_contents): Reads file.
105         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
106         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
107         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
108         (PatchAnalysisTask._check_patch_relevance): Added.
109         (PatchAnalysisTask._build): Check for JSC.
110         (PatchAnalysisTask._build_without_patch): Check for JSC.
111         (PatchAnalysisTask._test): Check for JSC.
112         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
113         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
114         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
115         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
116         * Scripts/webkitpy/tool/commands/download.py:
117         (CheckPatchRelevance): Add check-patch-relevance command.
118         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
119         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
120         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
121         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
122         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
123         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
124         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
125         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
126         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
127         (TestEWS): Sample layout test EWS class used for unit testing.
128         (TestJSCEWS): Sample JSC EWS class used for unit testing.
129         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
130         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
131         (AbstractEarlyWarningSystemTest): Add _group variable.
132         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
133         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
134         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
135         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
136         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
137         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
138         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
139         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
140         * Scripts/webkitpy/tool/steps/build.py:
141         (Build.options): Check for JSC.
142         (Build.build): Check for JSC.
143         (Build.run): Check for JSC.
144         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
145         (CheckPatchRelevance): Added.
146         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
147         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
148         * Scripts/webkitpy/tool/steps/options.py:
149         (Options): Add --group command line option.
150         * Scripts/webkitpy/tool/steps/runtests.py:
151         (RunTests.options): Add group.
152         (RunTests.run): Check for JSC.
153         (RunTests._run_webkit_tests): Check for JSC.
154         (RunTests): Add _group attribute.
155         (RunTests._run_javascriptcore_tests): New.
156         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
157
158 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
159
160         Fix tools that were broken by Efl removal
161         https://bugs.webkit.org/show_bug.cgi?id=168496
162
163         Reviewed by Alexey Proskuryakov.
164
165         * QueueStatusServer/config/queues.py:
166         * Scripts/webkitpy/common/config/ews.json:
167         * TestResultServer/static-dashboards/builders.jsonp:
168         * TestResultServer/static-dashboards/flakiness_dashboard.js:
169         * TestResultServer/static-dashboards/loader_unittests.js:
170
171 2017-02-16  Lucas Forschler  <lforschler@apple.com>
172
173         https://bugs.webkit.org/show_bug.cgi?id=168442
174         Move the SVN checkout from http -> https.
175         Update unit tests.
176
177         Reviewed by Alexey Proskuryakov.
178
179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
180         (CheckOutSource.__init__):
181         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
182         (SVNMirrorTest.get_SVNMirrorFromConfig):
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
184
185 2017-02-16  Commit Queue  <commit-queue@webkit.org>
186
187         Unreviewed, rolling out r212514.
188         https://bugs.webkit.org/show_bug.cgi?id=168489
189
190         broke test runner (Requested by alexchristensen on #webkit).
191
192         Reverted changeset:
193
194         "Remove EFL-specific files in Tools."
195         http://trac.webkit.org/changeset/212514
196
197 2017-02-16  Alex Christensen  <achristensen@webkit.org>
198
199         Remove EFL-specific files in Tools.
200
201         Rubber-stamped by Anders Carlsson.
202
203         * ImageDiff/efl: Removed.
204         * ImageDiff/efl/ImageDiff.cpp: Removed.
205         * MiniBrowser/efl: Removed.
206         * MiniBrowser/efl/CMakeLists.txt: Removed.
207         * MiniBrowser/efl/main.c: Removed.
208         * Scripts/run-efl-tests: Removed.
209         * Scripts/update-webkitefl-libs: Removed.
210         * Scripts/webkitpy/port/efl.py: Removed.
211         * Scripts/webkitpy/port/efl_unittest.py: Removed.
212         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
213         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
214         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
215         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
216         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
217         * TestWebKitAPI/efl: Removed.
218         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
219         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
220         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
221         * TestWebKitAPI/efl/main.cpp: Removed.
222         * WebKitTestRunner/InjectedBundle/efl: Removed.
223         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
224         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
225         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
226         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
227         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
228         * WebKitTestRunner/efl: Removed.
229         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
230         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
231         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
232         * WebKitTestRunner/efl/main.cpp: Removed.
233         * efl: Removed.
234         * efl/install-dependencies: Removed.
235         * efl/jhbuild-optional.modules: Removed.
236         * efl/jhbuild.modules: Removed.
237         * efl/jhbuildrc: Removed.
238         * efl/patches: Removed.
239         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
240         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
241         * efl/patches/gst-libav.patch: Removed.
242         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
243         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
244         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
245         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
246
247 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
248
249         font-weight in @font-face can cause a font to be downloaded even when it's not used
250         https://bugs.webkit.org/show_bug.cgi?id=168114
251         <rdar://problem/30301317>
252
253         Reviewed by Darin Adler.
254
255         LastResort needs to be usable in tests.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (allowedFontFamilySet):
259         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
260         (WTR::allowedFontFamilySet):
261         * WebKitTestRunner/mac/TestControllerMac.mm:
262         (WTR::allowedFontFamilySet):
263
264 2017-02-16  Alex Christensen  <achristensen@webkit.org>
265
266         Remove old URL parser
267         https://bugs.webkit.org/show_bug.cgi?id=168483
268
269         Reviewed by Tim Horton.
270
271         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
272         (TestWebKitAPI::checkURL):
273         (TestWebKitAPI::checkRelativeURL):
274         (TestWebKitAPI::checkURLDifferences):
275         (TestWebKitAPI::checkRelativeURLDifferences):
276
277 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [WK2] Add additional test infrastructure and unit tests for data interaction
280         https://bugs.webkit.org/show_bug.cgi?id=168439
281         <rdar://problem/30557942>
282
283         Reviewed by Tim Horton.
284
285         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
286         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
287         support data interaction from  See per-method descriptions below for more details.
288
289         * Configurations/TestWebKitAPI.xcconfig:
290
291         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
292
293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
294
295         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
296         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
297
298         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
299         (-[TestWKWebView editorContainsImageElement]):
300         (-[TestWKWebView editorValue]):
301
302         New helper methods for querying information from the "editor" element in a test page.
303
304         (TestWebKitAPI::TEST):
305         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
306
307         Moves logic for capturing events during a simulated data interaction run from the test file to
308         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
309
310         * TestWebKitAPI/cocoa/TestWKWebView.h:
311         * TestWebKitAPI/cocoa/TestWKWebView.mm:
312         (-[TestMessageHandler removeMessage:]):
313         (-[TestWKWebView clearMessageHandlers:]):
314
315         Add the ability to clear message handlers from the TestWKWebView.
316
317         * TestWebKitAPI/ios/DataInteractionSimulator.h:
318         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
319         (dataInteractionEventNames):
320         (-[DataInteractionSimulator initWithWebView:]):
321         (-[DataInteractionSimulator _resetSimulatedState]):
322
323         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
324         simulating data interaction.
325
326         (-[DataInteractionSimulator observedEventNames]):
327
328         Returns a list of the names of events relevant to data interaction that were observed over the course of the
329         most recent run.
330
331         (-[DataInteractionSimulator runFrom:to:]):
332
333         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
334         to run the same data interaction for multiple simulated gestures.
335
336         (-[DataInteractionSimulator _advanceProgress]):
337         (-[DataInteractionSimulator _finishDataInteraction]):
338         (-[DataInteractionSimulator externalItemProvider]):
339         (-[DataInteractionSimulator setExternalItemProvider:]):
340
341         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
342         phase of a test run.
343
344         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
345         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
346         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
347         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
348
349         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
350         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
351         wherein the the web process might take longer than usual to process the request to start data interaction, and
352         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
353         the web process is received, which then causes no simulated delegate methods to be fired.
354
355         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
356         (-[DataInteractionSimulator run]): Deleted.
357
358 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
359
360         Remove unused test pages in TestWebKitAPI
361         https://bugs.webkit.org/show_bug.cgi?id=168462
362
363         Reviewed by Anders Carlsson.
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
367         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
368         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
369         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
370         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
371
372 2017-02-16  Alex Christensen  <achristensen@webkit.org>
373
374         Special URLs without a host are invalid
375         https://bugs.webkit.org/show_bug.cgi?id=168461
376
377         Reviewed by Tim Horton.
378
379         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
380         (TestWebKitAPI::TEST_F):
381
382 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
383
384         The collector thread should only start when the mutator doesn't have heap access
385         https://bugs.webkit.org/show_bug.cgi?id=167737
386
387         Reviewed by Keith Miller.
388         
389         Make more tests collect continuously.
390
391         * Scripts/run-jsc-stress-tests:
392
393 2017-02-16  Tim Horton  <timothy_horton@apple.com>
394
395         WKWebView inside a UICollectionView flashes when items are inserted above it
396         https://bugs.webkit.org/show_bug.cgi?id=168376
397         <rdar://problem/29322051>
398
399         Reviewed by Simon Fraser.
400
401         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
402         (-[TestRunnerWKWebView _setStableStateOverride:]):
403         Update the one external caller of this internal method...
404
405         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
406         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
407         * DumpRenderTree/mac/UIScriptControllerMac.mm:
408         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
409         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
410         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
411         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
412         * TestRunnerShared/UIScriptContext/UIScriptController.h:
413         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
414         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
415         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
416         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
417         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
418         back after we dispatch a visible content rect update from the UI process
419         to the Web Content process, so any messages sent from the block will arrive
420         after the visible content rect update.
421
422 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
423
424         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
425         https://bugs.webkit.org/show_bug.cgi?id=168321
426
427         This bots should be added to the trunk build scheduler.
428         Unreviewed fix after r212429.
429
430         * BuildSlaveSupport/build.webkit.org-config/config.json:
431
432 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
433
434         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
435         https://bugs.webkit.org/show_bug.cgi?id=168321
436
437         Reviewed by Michael Catanzaro.
438
439         The additionalArgument --default-cmake-features is used both to
440         skip the JHBuild (InstallGtkDependencies) build step and to build
441         with the default features from the CMake config.
442
443         * BuildSlaveSupport/build.webkit.org-config/config.json:
444         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
445         (Factory.__init__):
446         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
447
448 2017-02-15  Lucas Forschler  <lforschler@apple.com>
449
450         https://bugs.webkit.org/show_bug.cgi?id=168386
451         Remove EFL from build.webkit.org
452
453         Reviewed by Alex Christensen
454
455         * BuildSlaveSupport/build.webkit.org-config/config.json:
456         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
457         (DeleteStaleBuildFiles.start):
458         (appendCustomBuildFlags):
459         (RunWebKitTests.start):
460         (RunBuiltinsTests):
461         (Factory.__init__):
462         (TestFactory.__init__):
463         (loadBuilderConfig):
464         (InstallEflDependencies): Deleted.
465         (RunEflAPITests): Deleted.
466         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
469         (BubbleQueueServer):
470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
472         (Analyzer.prototype._triggeringQueue):
473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
474         (WebKitBuildbot):
475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
476         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
477         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
478         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
479         (_should_file_trigger_build):
480
481 2017-02-15  Alex Christensen  <achristensen@webkit.org>
482
483         Unreviewed, rolling out r212169.
484
485         Broke iOS WebInspector
486
487         Reverted changeset:
488
489         "WebInspector: refactor RemoteInspector to move cocoa specific
490         code to their own files"
491         https://bugs.webkit.org/show_bug.cgi?id=166681
492         http://trac.webkit.org/changeset/212169
493
494 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
495
496         webkitpy: Fix DarwinPort._get_crash_log()
497         https://bugs.webkit.org/show_bug.cgi?id=168372
498         <rdar://problem/30535156>
499
500         Reviewed by Daniel Bates.
501
502         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
503         DarwinPort should return the expected return value for _get_crash_log.
504
505         * Scripts/webkitpy/port/darwin.py:
506         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
507
508 2017-02-15  Chris Dumez  <cdumez@apple.com>
509
510         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
511         https://bugs.webkit.org/show_bug.cgi?id=168291
512         <rdar://problem/30508593>
513
514         Reviewed by Tim Horton.
515
516         Drop overridePreference() implementation in iOS's UIScriptController
517         as it was only used for the minimum font size setting and this setting
518         is not exposed on iOS.
519
520         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
522         (WTR::UIScriptController::overridePreference):
523         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
524
525 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
526
527         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
528         https://bugs.webkit.org/show_bug.cgi?id=168329
529         <rdar://problem/30518832>
530
531         Reviewed by Daniel Bates.
532
533         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
534         never change given the same input arguments.  Memoize function for efficiency.
535
536         * Scripts/webkitpy/port/darwin.py: Add memoized import.
537         (DarwinPort):
538         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
539         
540
541 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
542
543         webkitpy: Remove unused import from darwin.py
544         https://bugs.webkit.org/show_bug.cgi?id=168371
545
546         Reviewed by Alex Christensen.
547
548         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
549
550 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
551
552         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
553         https://bugs.webkit.org/show_bug.cgi?id=168364
554
555         Reviewed by Michael Catanzaro.
556
557         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
558         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
559         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
560
561         Fixes: http/tests/security/credentials-from-different-domains.html
562                http/tests/xmlhttprequest/cross-origin-no-authorization.html
563
564         * gtk/jhbuild.modules:
565         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
566         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
567
568 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
569
570         [GTK] Update cookie manager API to properly work with ephemeral sessions
571         https://bugs.webkit.org/show_bug.cgi?id=168230
572
573         Reviewed by Michael Catanzaro.
574
575         Update unit tests and add new cases for the new API.
576
577         * MiniBrowser/gtk/main.c:
578         (gotWebsiteDataCallback):
579         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
580         (testCookieManagerEphemeral):
581         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
582         (testWebContextEphemeral):
583         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
584         (testWebViewEphemeral):
585         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
586         (serverCallback):
587         (testWebsiteDataEphemeral):
588         (testWebsiteDataCookies):
589         (beforeAll):
590
591 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
592
593         [WK2] Support data interaction on links
594         https://bugs.webkit.org/show_bug.cgi?id=168331
595         <rdar://problem/30200837>
596
597         Reviewed by Tim Horton.
598
599         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
600         editable area results in the link URL being inserted.
601
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
604         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
605         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
606         (TestWebKitAPI::TEST):
607
608 2017-02-14  Jason Rinn  <jrinn@apple.com>
609
610         Add a test for new WebKit Cocoa API, _getContentsAsString.
611         https://bugs.webkit.org/show_bug.cgi?id=168147
612         <rdar://problem/30502539>
613
614         Reviewed by Tim Horton.
615
616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
617         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
618         (TEST):
619
620 2017-02-14  Matt Rajca  <mrajca@apple.com>
621
622         Website policies: iframes should respect the autoplay policy of the top-level document
623         https://bugs.webkit.org/show_bug.cgi?id=168333
624
625         Reviewed by Alex Christensen.
626
627         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
628         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
629         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
630         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
631         (TEST):
632
633 2017-02-14  Chris Dumez  <cdumez@apple.com>
634
635         HTML Form Validation bubble should take minimum font size setting into consideration
636         https://bugs.webkit.org/show_bug.cgi?id=168271
637         <rdar://problem/29869869>
638
639         Reviewed by Simon Fraser.
640
641         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
642         font size of the validation bubble.
643
644         Add an overridePreference() method to UIScriptController. This is currently
645         used to override the value of the minimumFontSize setting. testRunner's
646         overridePreference() is not usable on WK2 because it does not update the
647         value of the preference on the UIProcess side.
648
649         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
650         (WTR::UIScriptController::overridePreference):
651         * DumpRenderTree/mac/UIScriptControllerMac.mm:
652         (WTR::UIScriptController::overridePreference):
653         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
654         * TestRunnerShared/UIScriptContext/UIScriptController.h:
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::TestController::resetPreferencesToConsistentValues):
657         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
658         (WTR::UIScriptController::overridePreference):
659         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
660         (WTR::UIScriptController::contentsOfUserInterfaceItem):
661         (WTR::UIScriptController::overridePreference):
662
663 2017-02-14  Florian Bruhin  <git@the-compiler.org>
664
665         Use a set instead of a list for tests when parsing expectations
666         https://bugs.webkit.org/show_bug.cgi?id=168304
667
668         In _collect_matching_tests, a lot of membership tests are done on a giant list
669         of strings. By making it a set instead, we can make those much faster, and
670         there's no reason for it to be a list.
671
672         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
673         to 3s on my machine.
674
675         Reviewed by Ryosuke Niwa.
676
677         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
678         (TestExpectationParser.__init__):
679         (TestExpectationParser._collect_matching_tests):
680
681 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
682
683         Unreviewed build-fix after r212297.
684
685         * Scripts/webkitpy/port/simulator_process.py:
686         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
687
688 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
689
690         [CMake] build-webkit should allow building with the default cmake configuration
691         https://bugs.webkit.org/show_bug.cgi?id=168323
692
693         Reviewed by Michael Catanzaro.
694
695         Add a --default-cmake-features switch that makes the script pass
696         no value for any of the features defined by build-webkit, that
697         way the default values from the port cmake config will be used.
698
699         * Scripts/build-webkit:
700         (cMakeArgsFromFeatures):
701
702 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
703
704         Unreviewed build-fix after r212297.
705
706         * Scripts/webkitpy/port/simulator_process.py:
707         (SimulatorProcess.stop): Handle case where there is no process to kill.
708
709 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
710
711         [CMake] build-webkit should print the cmake command executed
712         https://bugs.webkit.org/show_bug.cgi?id=168318
713
714         Reviewed by Michael Catanzaro.
715
716         Run the cmake commands to configure or start the build through
717         a wrapper that prints the command before executing it.
718
719         * Scripts/webkitdirs.pm:
720         (systemVerbose):
721         (generateBuildSystemFromCMakeProject):
722         (buildCMakeGeneratedProject):
723         (cleanCMakeGeneratedProject):
724
725 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
726
727         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
728         https://bugs.webkit.org/show_bug.cgi?id=168150
729
730         Reviewed by Alexey Proskuryakov.
731
732         * Scripts/webkitpy/port/simulator_process.py:
733         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
734         (SimulatorProcess._kill): Move closing of app into stop().
735         * Scripts/webkitpy/xcode/simulator.py:
736         (Device.launch_app):
737         (Device.terminate_app): Deleted.
738
739 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
740
741         REGRESSION(r212192): [GTK] Broke downloads API tests
742         https://bugs.webkit.org/show_bug.cgi?id=168193
743
744         Unreviewed. Update test expectations after r212192.
745
746         The suggested filename now includes a file extensions if the MIME type is known.
747
748         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
749         (testDownloadRemoteFile):
750         (testDownloadMIMEType):
751
752 2017-02-14  Commit Queue  <commit-queue@webkit.org>
753
754         Unreviewed, rolling out r212237.
755         https://bugs.webkit.org/show_bug.cgi?id=168298
756
757         This was a wrong fix (Requested by rniwa on #webkit).
758
759         Reverted changeset:
760
761         "Nwtr unexpectedly passes mismatch ref test if the hashes
762         doesn't match but no diff"
763         https://bugs.webkit.org/show_bug.cgi?id=168221
764         http://trac.webkit.org/changeset/212237
765
766 2017-02-13  Alex Christensen  <achristensen@webkit.org>
767
768         URLs with an invalid IPv4 address should be invalid
769         https://bugs.webkit.org/show_bug.cgi?id=168260
770
771         Reviewed by Tim Horton.
772
773         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
774         (TestWebKitAPI::TEST_F):
775         Update tests to reflect new correct behavior.
776
777 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
778
779         [WinCairo] Add Build Slave
780         https://bugs.webkit.org/show_bug.cgi?id=168263
781
782         Reviewed by Lucas Forschler.
783
784         * BuildSlaveSupport/build.webkit.org-config/config.json:
785
786 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
787
788         Fix the build after r212254
789
790         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
791         (-[DataInteractionSimulator _currentLocation]):
792
793 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
794
795         [WK2] Add test infrastructure and unit tests for data interaction
796         https://bugs.webkit.org/show_bug.cgi?id=168159
797         <rdar://problem/30477634>
798
799         Reviewed by Tim Horton.
800
801         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
802         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
803         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
804         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
805         gesture has already been recognized) at regular intervals over the course of the test.
806
807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
808         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
809         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
810         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
811
812         New test pages for data interaction.
813
814         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
815         (TestWebKitAPI::runTestsExpectingToObserveEvents):
816         (TestWebKitAPI::TEST):
817         * TestWebKitAPI/cocoa/TestWKWebView.mm:
818         (-[TestWKWebView stringByEvaluatingJavaScript:]):
819         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
820         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
821         (-[MockLongPressGestureRecognizer initWithWindow:]):
822         (-[MockLongPressGestureRecognizer locationInView:]):
823         (-[MockLongPressGestureRecognizer state]):
824         (-[MockLongPressGestureRecognizer numberOfTouches]):
825         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
826         (-[DataInteractionSimulator dealloc]):
827         (-[DataInteractionSimulator run]):
828
829         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
830         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
831         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
832
833         (-[DataInteractionSimulator _advanceProgress]):
834
835         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
836         completed, and calls _finishDataInteraction when progress is at 1.
837
838         (-[DataInteractionSimulator _finishDataInteraction]):
839         (-[DataInteractionSimulator _currentLocation]):
840         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
841         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
842         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
843         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
844         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
845
846 2017-02-13  Alex Christensen  <achristensen@webkit.org>
847
848         Percent should be allowed in non-special URL hosts
849         https://bugs.webkit.org/show_bug.cgi?id=168255
850
851         Reviewed by Tim Horton.
852
853         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
854         (TestWebKitAPI::TEST_F):
855
856 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
857
858         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
859         https://bugs.webkit.org/show_bug.cgi?id=168221
860
861         Reviewed by Ryosuke Niwa.
862
863         There is a logic error in comparing mismatch ref test images. In
864         mismatch ref tests, it should be failed if two images has no diff.
865         But, if the hashes are different, nwtr unexpectedly pass the
866         mismatch ref test.
867
868         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
869         (SingleTestRunner._compare_output_with_reference): Fail the
870         mismatch ref test if hashes of two images are equal. Invoke
871         ImageDiff if the hashes don't match.
872
873 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
874
875         Update custom line breaking iterators to the latest version of Unicode
876         https://bugs.webkit.org/show_bug.cgi?id=168182
877
878         Reviewed by Zalan Bujtas.
879
880         Treat the system's ICU as the source of truth to compare breaking positions against.
881
882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
883         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
884         (generateJavaScriptForTest):
885         (breakingLocationsFromICU):
886         (testAFewStrings):
887         (TEST):
888         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
889         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
890
891 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
892
893         [GTK] Several failing WebViewEditor API tests
894         https://bugs.webkit.org/show_bug.cgi?id=161608
895
896         Reviewed by Carlos Garcia Campos.
897
898         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
899         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
900         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
901         except the first one, which is still broken due to unrelated bug #151654.
902
903         * Scripts/run-gtk-tests:
904         (TestRunner):
905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
906
907 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
908
909         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
910
911         * Scripts/run-gtk-tests:
912         (TestRunner):
913
914 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
915
916         Unreviewed, skip flaky form-controls-associated-signal test
917
918         * Scripts/run-gtk-tests:
919         (TestRunner):
920
921 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         [GTK] Handle caps lock indicator in event modifiers
924         https://bugs.webkit.org/show_bug.cgi?id=168186
925
926         Reviewed by Michael Catanzaro.
927
928         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
929         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
930
931 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
932
933         MiniBrowser WK1 fails to update URL for within-page navigations
934         https://bugs.webkit.org/show_bug.cgi?id=168173
935
936         Reviewed by Tim Horton.
937         
938         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
939         anchors updates the URL field.
940
941         * MiniBrowser/mac/WK1BrowserWindowController.m:
942         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
943
944 2017-02-10  John Wilander  <wilander@apple.com>
945
946         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
947         https://bugs.webkit.org/show_bug.cgi?id=167474
948         <rdar://problem/24681808>
949         <rdar://problem/24703286>
950         <rdar://problem/30290270>
951
952         This patch adds test infrastructure to allow testing 
953         of the various rules in place for data records removal.
954
955         Reviewed by Andy Estes.
956
957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
959         (WTR::InjectedBundle::didReceiveMessageToPage):
960             Callback mechanism to tell pages that a website data store
961             scan has happened.
962         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
963         (WTR::TestRunner::setStatisticsPrevalentResource):
964         (WTR::TestRunner::isStatisticsPrevalentResource):
965         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
966         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
967         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
968         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
969         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
970         (WTR::TestRunner::statisticsFireDataModificationHandler):
971         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
972         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
973         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
974         (WTR::TestRunner::statisticsResetToConsistentState):
975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
976         * WebKitTestRunner/TestController.cpp:
977         (WTR::TestController::setStatisticsPrevalentResource):
978         (WTR::TestController::isStatisticsPrevalentResource):
979         (WTR::TestController::setStatisticsHasHadUserInteraction):
980         (WTR::TestController::isStatisticsHasHadUserInteraction):
981         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
982         (WTR::TestController::statisticsFireDataModificationHandler):
983         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
984         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
985         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
986         (WTR::TestController::statisticsResetToConsistentState):
987         * WebKitTestRunner/TestController.h:
988             These are all configuration and test functions.
989         * WebKitTestRunner/TestInvocation.cpp:
990         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
991
992 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
993
994         REGRESSION(r182916) run-perf-tests never timeouts
995         https://bugs.webkit.org/show_bug.cgi?id=167626
996
997         Reviewed by Ryosuke Niwa.
998
999         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1000         was beeing ignored because the driver was created with no_timeout=True
1001         unconditionally.
1002         This adds a new parameter --no-timeout (disabled by default), that
1003         allows to use the driver with the expected timeout values.
1004         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1005         are always controlled by the Python Driver.
1006
1007         * Scripts/webkitpy/performance_tests/perftest.py:
1008         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1009         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1010         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1011         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1012         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1013         (_run_tests_set): Pass the no-timeout parameter.
1014         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1015         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1016         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1017         (MainTest.test_parse_args): Test that the argument no-timeout.
1018
1019 2017-02-10  Daniel Bates  <dabates@apple.com>
1020
1021         Detach frame from document when entering page cache
1022         https://bugs.webkit.org/show_bug.cgi?id=166774
1023         <rdar://problem/29904368>
1024
1025         Reviewed by Chris Dumez.
1026
1027         * DumpRenderTree/mac/DumpRenderTree.mm:
1028         (resetWebPreferencesToConsistentValues):
1029         * DumpRenderTree/win/DumpRenderTree.cpp:
1030         (resetWebPreferencesToConsistentValues):
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::TestController::resetPreferencesToConsistentValues):
1033
1034 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1035
1036         Infinite UI process hang under ensurePositionInformationIsUpToDate
1037         https://bugs.webkit.org/show_bug.cgi?id=168154
1038         <rdar://problem/30428673>
1039
1040         Reviewed by Simon Fraser.
1041
1042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1043         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1044         (recursiveFindHighlightLongPressRecognizer):
1045         (TEST):
1046         Add a somewhat nasty test that does an async interaction information update, but
1047         kills the Web process before it arrives, and then does a sync interaction
1048         information update, which will wait for the oustanding async interaction
1049         information update if we still think it's coming. Before the patch, this
1050         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1051
1052 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1053
1054         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1055         https://bugs.webkit.org/show_bug.cgi?id=168127
1056         rdar://problem/30467120
1057
1058         Reviewed by Tim Horton.
1059
1060         Reparent the web view before we try to fetch it via:
1061             [[[window contentView] subviews] objectAtIndex:0];
1062         which would throw an exception if the test unparented it.
1063
1064         * DumpRenderTree/mac/DumpRenderTree.mm:
1065         (resetWebViewToConsistentStateBeforeTesting):
1066         (runTest):
1067
1068 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1069
1070         [Resource Timing] Enable Resource Timing by default in Tests
1071         https://bugs.webkit.org/show_bug.cgi?id=168145
1072
1073         Reviewed by Ryosuke Niwa.
1074
1075         * DumpRenderTree/mac/DumpRenderTree.mm:
1076         (resetWebPreferencesToConsistentValues):
1077         * DumpRenderTree/win/DumpRenderTree.cpp:
1078         (resetWebPreferencesToConsistentValues):
1079         * WebKitTestRunner/TestController.cpp:
1080         (WTR::TestController::resetPreferencesToConsistentValues):
1081
1082 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1083
1084         Removing LayoutTestRelay
1085         https://bugs.webkit.org/show_bug.cgi?id=165927
1086
1087         Reviewed by Daniel Bates.
1088         Part 2
1089
1090         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1091         simulators through simctl (iOS 10 and later), use this functionality instead.
1092
1093         * BuildSlaveSupport/built-product-archive:
1094         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1095         Added a FIXME that we will need to implement similar archiving machinery once we build
1096         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1097         * BuildSlaveSupport/kill-old-processes:
1098         (main): Remove LayoutTestRelay from list of processes.
1099         * LayoutTestRelay: Removed LayoutTestRelay.
1100         * Makefile:
1101         * Scripts/build-layouttestrelay: Removed.
1102         * Scripts/build-webkit: Removed LayoutTestRelay references.
1103
1104 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1105
1106         [WebCrypto] Add WebCryptoAPI to watchlist
1107         https://bugs.webkit.org/show_bug.cgi?id=168138
1108
1109         Reviewed by Youenn Fablet.
1110
1111         * Scripts/webkitpy/common/config/watchlist:
1112
1113 2017-02-10  Brady Eidson  <beidson@apple.com>
1114
1115         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1116         https://bugs.webkit.org/show_bug.cgi?id=168124
1117
1118         Reviewed by Geoffrey Garen.
1119
1120         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1121         
1122         * MiniBrowser/mac/main.m:
1123         (main):
1124         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1125         (main):
1126         * TestWebKitAPI/ios/mainIOS.mm:
1127         (main):
1128         * TestWebKitAPI/mac/mainMac.mm:
1129         (main):
1130         * WebKitTestRunner/ios/mainIOS.mm:
1131         (main):
1132         * WebKitTestRunner/mac/main.mm:
1133         (setDefaultsToConsistentValuesForTesting):
1134
1135 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1136
1137         Fix El Capitan build.
1138
1139         * Scripts/build-webkit:
1140         Don't build libwebrtc anywhere for now.
1141
1142 2017-02-10  Andy Estes  <aestes@apple.com>
1143
1144         Move two MiniBrowserBundle settings out of the .pbxproj
1145         https://bugs.webkit.org/show_bug.cgi?id=168106
1146
1147         Reviewed by Tim Horton.
1148
1149         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1150         the project file. This removes the project file override.
1151
1152         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1153
1154         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1155         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1156
1157 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1158
1159         Fix 32-and-64-bit build on El Capitan.
1160
1161         * Scripts/build-webkit:
1162         Somebody's building with something like this:
1163         build-webkit ARCHS="i386 x86_64"
1164         We want this to also not build libwebrtc for now.
1165
1166 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1167
1168         Fix 32-bit build on El Capitan.
1169
1170         * Scripts/build-webkit:
1171         The bot uses ARCHS=i386 instead of --32-bit.
1172         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1173
1174 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1175
1176         Fix 32-bit build on El Capitan.
1177
1178         * Scripts/build-webkit:
1179         Don't build i386 libwebrtc.
1180
1181 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1182
1183         Unreviewed, rolling out r212040.
1184
1185         Broke build.  I'm not surprised
1186
1187         Reverted changeset:
1188
1189         "[WebRTC][Mac] Activate libwebrtc"
1190         https://bugs.webkit.org/show_bug.cgi?id=167293
1191         http://trac.webkit.org/changeset/212040
1192
1193 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1194
1195         Build libwebrtc on bots without using it yet
1196         https://bugs.webkit.org/show_bug.cgi?id=168062
1197
1198         Reviewed by Brent Fulgham.
1199
1200         * Scripts/build-webkit:
1201
1202 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1203
1204         Don't build libwebrtc.
1205
1206         * Scripts/build-webkit:
1207         Not ready yet.  It broke El Capitan and iOS.
1208
1209 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1210
1211         Build libwebrtc on bots without using it yet
1212         https://bugs.webkit.org/show_bug.cgi?id=168062
1213
1214         Reviewed by Brent Fulgham.
1215
1216         * Scripts/build-webkit:
1217
1218 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1219
1220         Rename isAppleMacWebKit to isAppleCocoaWebKit
1221         https://bugs.webkit.org/show_bug.cgi?id=168075
1222
1223         Reviewed by Geoffrey Garen.
1224
1225         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1226
1227         * Scripts/build-api-tests:
1228         * Scripts/build-dumprendertree:
1229         * Scripts/build-jsc:
1230         (buildMyProject):
1231         * Scripts/build-layouttestrelay:
1232         * Scripts/build-webkit:
1233         * Scripts/build-webkittestrunner:
1234         * Scripts/run-api-tests:
1235         (isSupportedPlatform):
1236         (runTest):
1237         (listAllTests):
1238         (prepareEnvironmentForRunningTestTool):
1239         * Scripts/run-content-extension-tester:
1240         * Scripts/run-javascriptcore-tests:
1241         * Scripts/run-minibrowser:
1242         * Scripts/show-pretty-diff:
1243         * Scripts/webkitdirs.pm:
1244         (determineBaseProductDir):
1245         (determineArchitecture):
1246         (determinePassedArchitecture):
1247         (safariPath):
1248         (builtDylibPathForName):
1249         (checkFrameworks):
1250         (isAppleWebKit):
1251         (isAppleCocoaWebKit):
1252         (determineNmPath):
1253         (launcherName):
1254         (wrapperPrefixIfNeeded):
1255         (isCMakeBuild):
1256         (mobileSafariBundle):
1257         (debugSafari):
1258         (runSafari):
1259         (runMiniBrowser):
1260         (debugMiniBrowser):
1261         (runWebKitTestRunner):
1262         (debugWebKitTestRunner):
1263         (isAppleMacWebKit): Deleted.
1264         * Scripts/webkitperl/FeatureList.pm:
1265
1266 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1267
1268         Revert r211991
1269         https://bugs.webkit.org/show_bug.cgi?id=168062
1270
1271         * Scripts/build-webkit:
1272         Not quite ready yet.
1273
1274 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1275
1276         Build libwebrtc on bots without using it yet
1277         https://bugs.webkit.org/show_bug.cgi?id=168062
1278
1279         Reviewed by Brent Fulgham.
1280
1281         * Scripts/build-webkit:
1282         Build libwebrtc on Mac when we build ANGLE.
1283
1284 2017-02-09  Youenn Fablet  <youenn@apple.com>
1285
1286         Improve W3C importer command line options
1287         https://bugs.webkit.org/show_bug.cgi?id=167448
1288
1289         Reviewed by Ryosuke Niwa.
1290
1291         Making the list of test paths to import the main arguments of the script.
1292         Allow passing the source directory to import as a -s option.
1293         Adding a warning when given test paths are skipped by default in ImportExpectations.
1294
1295         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1296         Link conversion rules do not change when imported tests are downloaded by the script.
1297
1298         * Scripts/webkitpy/w3c/test_importer.py:
1299         (main):
1300         (parse_args):
1301         (TestImporter.__init__):
1302         (TestImporter.do_import):
1303         (TestImporter):
1304         (TestImporter.check_imported_expectations):
1305
1306 2017-02-08  Chris Dumez  <cdumez@apple.com>
1307
1308         Update web-platform-tests resources
1309         https://bugs.webkit.org/show_bug.cgi?id=168026
1310
1311         Reviewed by Youenn Fablet.
1312
1313         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1314
1315         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1316         (WebPlatformTestServer._copy_webkit_test_files):
1317
1318 2017-02-08  Andy Estes  <aestes@apple.com>
1319
1320         Custom protocols should not continue loading after a network process crash
1321         https://bugs.webkit.org/show_bug.cgi?id=168028
1322         <rdar://problem/27607520>
1323
1324         Reviewed by Brady Eidson.
1325
1326         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1327         (processGroup):
1328         (-[CloseWhileStartingProtocol startLoading]):
1329         (-[CloseWhileStartingProtocol stopLoading]):
1330         (TestWebKitAPI::runTest):
1331         (TestWebKitAPI::TEST):
1332
1333 2017-02-08  Dan Bernstein  <mitz@apple.com>
1334
1335         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1336         https://bugs.webkit.org/show_bug.cgi?id=168031
1337
1338         Reviewed by Tim Horton.
1339
1340         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1341         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1342         (TEST):
1343         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1344         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1345
1346 2017-02-08  Chris Dumez  <cdumez@apple.com>
1347
1348         Use smaller tiles in windows that are not active to facilitate App Napping
1349         https://bugs.webkit.org/show_bug.cgi?id=167997
1350         <rdar://problem/30358835>
1351
1352         Reviewed by Simon Fraser.
1353
1354         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1355         (WTR::PlatformWebView::setWindowIsKey):
1356         Actually update windowIsKey state of NSWindow so the WebView
1357         properly updates its activity state.
1358
1359 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1362         https://bugs.webkit.org/show_bug.cgi?id=167942
1363         <rdar://problem/30315079>
1364
1365         Reviewed by Tim Horton.
1366
1367         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1368         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1369         contenteditable in these cases.
1370
1371         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1372         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1373         performDragOperation:) directly.
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1377         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1378         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1379         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1380         (-[DragSource draggingSourceOperationMaskForLocal:]):
1381         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1382         (-[DragInfo lastMousePosition]):
1383         (-[DragInfo setLastMousePosition:]):
1384         (-[DragInfo draggingDestinationWindow]):
1385         (-[DragInfo draggingSourceOperationMask]):
1386         (-[DragInfo draggingLocation]):
1387         (-[DragInfo draggedImageLocation]):
1388         (-[DragInfo draggedImage]):
1389         (-[DragInfo draggingPasteboard]):
1390         (-[DragInfo draggingSource]):
1391         (-[DragInfo draggingSequenceNumber]):
1392         (-[DragInfo slideDraggedImageTo:]):
1393         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1394         (-[DragInfo draggingFormation]):
1395         (-[DragInfo setDraggingFormation:]):
1396         (-[DragInfo animatesToDestination]):
1397         (-[DragInfo setAnimatesToDestination:]):
1398         (-[DragInfo numberOfValidItemsForDrop]):
1399         (-[DragInfo setNumberOfValidItemsForDrop:]):
1400         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1401         (-[DragInfo springLoadingHighlight]):
1402         (-[DragInfo resetSpringLoading]):
1403         (TestWebKitAPI::getTestImage):
1404         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1405         (TestWebKitAPI::TEST):
1406         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1407
1408 2017-02-08  Jer Noble  <jer.noble@apple.com>
1409
1410         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1411         https://bugs.webkit.org/show_bug.cgi?id=168007
1412
1413         Reviewed by Alex Christensen.
1414
1415         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1416         (didFinishLoadForFrame):
1417         (TestWebKitAPI::TEST):
1418
1419 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1420
1421         Unreviewed, rolling out r211873.
1422         https://bugs.webkit.org/show_bug.cgi?id=168001
1423
1424         It's in jhbuild for consistent layout tests (Requested by
1425         mcatanzaro on #webkit).
1426
1427         Reverted changeset:
1428
1429         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1430         https://bugs.webkit.org/show_bug.cgi?id=167993
1431         http://trac.webkit.org/changeset/211873
1432
1433 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1434
1435         [GTK] Add icu packages to Tools/gtk/install-dependencies
1436         https://bugs.webkit.org/show_bug.cgi?id=167993
1437
1438         Reviewed by Michael Catanzaro.
1439
1440         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1441         depending in the GNU/Linux distribution)
1442
1443 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1444
1445         Update flakiness dashboard configuration.
1446         https://bugs.webkit.org/show_bug.cgi?id=167957
1447
1448         Reviewed by Alexey Proskuryakov.
1449
1450         * TestResultServer/static-dashboards/builders.jsonp:
1451
1452 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1453
1454         Replace a bot that has an incorrect configuration.
1455         https://bugs.webkit.org/show_bug.cgi?id=167747
1456
1457         Rubber-stamped by Alexey Proskuryakov.
1458
1459         * BuildSlaveSupport/build.webkit.org-config/config.json:
1460
1461 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1462
1463         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1464         https://bugs.webkit.org/show_bug.cgi?id=167927
1465
1466         Reviewed by Brent Fulgham.
1467
1468         Enable ComplexTextController API tests on the Win and GTK ports.
1469
1470         * TestWebKitAPI/PlatformGTK.cmake:
1471         * TestWebKitAPI/PlatformWin.cmake:
1472
1473 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1474
1475         File index appended to previous file in svn-create-patch with SVN 1.9
1476         https://bugs.webkit.org/show_bug.cgi?id=167903
1477         <rdar://problem/30387395>
1478
1479         Reviewed by Daniel Bates.
1480
1481         * Scripts/VCSUtils.pm:
1482         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1483         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1484         trailing newline character from the expected result before comparing it to the actual result.
1485
1486 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1487
1488         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1489         https://bugs.webkit.org/show_bug.cgi?id=167936
1490
1491         Reviewed by Michael Catanzaro.
1492
1493         * Scripts/webkitdirs.pm:
1494         (determineArchitecture):
1495         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1496         since r195083.
1497
1498 2017-02-07  Youenn Fablet  <youenn@apple.com>
1499
1500         Use a JSON file to define which WPT files/folders to import
1501         https://bugs.webkit.org/show_bug.cgi?id=167923
1502
1503         Reviewed by Alex Christensen.
1504
1505         * Scripts/webkitpy/w3c/test_downloader.py:
1506         (TestDownloader.__init__):
1507         (TestDownloader._init_paths_from_expectations):
1508         * Scripts/webkitpy/w3c/test_importer.py:
1509         (parse_args):
1510         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1511
1512 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1513
1514         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1515         https://bugs.webkit.org/show_bug.cgi?id=167916
1516
1517         Reviewed by Carlos Garcia Campos.
1518
1519         URL of mesa-11.0.6.tar.xz has been moved.
1520
1521         * gtk/jhbuild.modules: Fix the module path.
1522
1523 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1524
1525         Static Analyzer: Address some leaks in MiniBrowser
1526         https://bugs.webkit.org/show_bug.cgi?id=167897
1527
1528         Reviewed by Alexey Proskuryakov.
1529
1530         * MiniBrowser/mac/BrowserWindowController.m:
1531         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1532         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1533         (-[ExtensionManagerWindowController add:]):
1534         (-[ExtensionManagerWindowController remove:]):
1535         * MiniBrowser/mac/SettingsController.m:
1536         (-[SettingsController _populateMenu]):
1537         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1538         Address obvious leaks caught by the static analyzer.
1539
1540 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1541
1542         Migrate ComplexTextController to use platform-independent types
1543         https://bugs.webkit.org/show_bug.cgi?id=167833
1544
1545         Reviewed by Brent Fulgham.
1546
1547         Migrate tests away from platform-dependent types.
1548
1549         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1550         (TestWebKitAPI::TEST_F):
1551
1552 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1553
1554         Correct File Path Handling in SecurityOrigin and FileSystem
1555         https://bugs.webkit.org/show_bug.cgi?id=167894
1556         <rdar://problem/30380080>
1557
1558         Reviewed by Alexey Proskuryakov.
1559
1560         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1561         and perform same-volume checks using filesystem-compatible paths.        
1562         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1563         filesystem paths, and perform validation of same-volume checks.
1564         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1565         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1566         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1567         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1568
1569 2017-02-06  Jer Noble  <jer.noble@apple.com>
1570
1571         Playback stalls when a SourceBuffer append causes frame eviction
1572         https://bugs.webkit.org/show_bug.cgi?id=167834
1573
1574         Reviewed by Eric Carlson.
1575
1576         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1577         for the WTF::MediaTime class.
1578
1579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1580         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1583         (WTF::operator<<):
1584         (TestWebKitAPI::TestSample::create):
1585         (TestWebKitAPI::TestSample::TestSample):
1586         (TestWebKitAPI::TEST_F):
1587
1588 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1589
1590         Change capitalization in platform name after r211735.
1591
1592         Unreviewed dashboard fix.
1593
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1595         (WebKitBuildbot):
1596
1597 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1598
1599         Move the Leaks bot to Sierra
1600         https://bugs.webkit.org/show_bug.cgi?id=167886
1601
1602         Reviewed by Daniel Bates.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/config.json:
1605         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1607         (LeaksViewer._displayURLPrompt):
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1609         (WebKitBuildbot):
1610
1611 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1612
1613         Prevent app crash on launch during simctl install workaround
1614         https://bugs.webkit.org/show_bug.cgi?id=167685
1615
1616         Reviewed by Daniel Bates.
1617
1618         * Scripts/webkitpy/port/simulator_process.py:
1619         (SimulatorProcess.__init__): Pass environment to install.
1620         * Scripts/webkitpy/xcode/simulator.py:
1621         (Device.install_app): Accept environment, pass environment to launch.
1622
1623 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1624
1625         Rebase API tests after r211638
1626         https://bugs.webkit.org/show_bug.cgi?id=167779
1627
1628         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1629         (TestWebKitAPI::TEST_F):
1630         URLs with non-special schemes and characters like % in the host now fail to parse,
1631         more like their special counterparts and according to spec.
1632
1633 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1634
1635         Unreviewed trivial fix after r211697.
1636         https://bugs.webkit.org/show_bug.cgi?id=167863
1637
1638         * Scripts/run-javascriptcore-tests:
1639         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1640
1641 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1642
1643         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1644         https://bugs.webkit.org/show_bug.cgi?id=167850
1645
1646         Reviewed by Tim Horton.
1647
1648         * DumpRenderTree/TestRunner.cpp:
1649         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1650
1651 2017-02-04  Andreas Kling  <akling@apple.com>
1652
1653         Plug some leaks in TestController and UIScriptContext.
1654         <https://webkit.org/b/167839>
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         Fix a couple of the leaks seen on the leaks bot.
1659
1660         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1661         (UIScriptContext::runUIScript):
1662         * WebKitTestRunner/TestController.cpp:
1663         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1664         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1665
1666 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1667
1668         WK1 mouse events are missing movementX and movementY for pointerlock.
1669         https://bugs.webkit.org/show_bug.cgi?id=167775
1670         rdar://problem/30343810
1671
1672         Reviewed by Alexey Proskuryakov.
1673
1674         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1675
1676         * DumpRenderTree/mac/EventSendingController.mm:
1677         (-[EventSendingController mouseMoveToX:Y:]):
1678         * WebKitTestRunner/mac/EventSenderProxy.mm:
1679         (WTR::EventSenderProxy::mouseMoveTo):
1680
1681 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1682
1683         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1684         https://bugs.webkit.org/show_bug.cgi?id=167774
1685
1686         Reviewed by Tim Horton.
1687
1688         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1689         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1690         web process are async, so the callback fires after the web process gets the new state.
1691
1692         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1693         (WTR::UIScriptController::removeViewFromWindow):
1694         (WTR::UIScriptController::addViewToWindow):
1695         * DumpRenderTree/mac/DumpRenderTree.mm:
1696         (createWebViewAndOffscreenWindow):
1697         (resetWebViewToConsistentStateBeforeTesting):
1698         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1699         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1700         (WTR::UIScriptController::removeViewFromWindow):
1701         (WTR::UIScriptController::addViewToWindow):
1702         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1703         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1704         (WTR::UIScriptController::removeViewFromWindow):
1705         (WTR::UIScriptController::addViewToWindow):
1706         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1707         * WebKitTestRunner/PlatformWebView.h:
1708         * WebKitTestRunner/TestController.cpp:
1709         (WTR::TestController::resetStateToConsistentValues):
1710         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1711         (WTR::PlatformWebView::removeFromWindow):
1712         (WTR::PlatformWebView::addToWindow):
1713         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1714         (WTR::UIScriptController::removeViewFromWindow):
1715         (WTR::UIScriptController::addViewToWindow):
1716         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1717         (WTR::PlatformWebView::removeFromWindow):
1718         (WTR::PlatformWebView::addToWindow):
1719         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1720         (WTR::UIScriptController::removeViewFromWindow):
1721         (WTR::UIScriptController::addViewToWindow):
1722
1723 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1724
1725         Remove check for SkipSafariExecutableEntitlementChecks
1726         https://bugs.webkit.org/show_bug.cgi?id=167762
1727
1728         Reviewed by Dan Bernstein.
1729
1730         Follow-up fix: don't break internal behavior.
1731
1732         * Scripts/webkitdirs.pm:
1733         (safariPath):
1734         (executableHasEntitlements): Deleted.
1735         (safariPathFromSafariBundle): Deleted.
1736         (installedSafariPath): Deleted.
1737
1738 2017-02-03  Daniel Bates  <dabates@apple.com>
1739
1740         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1741         https://bugs.webkit.org/show_bug.cgi?id=167810
1742         <rdar://problem/30102568>
1743
1744         Reviewed by Anders Carlsson.
1745
1746         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1747
1748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1749         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1750         (TEST):
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1753         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1754         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1755
1756 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1757
1758         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1759         https://bugs.webkit.org/show_bug.cgi?id=167773
1760         <rdar://problem/30221102>
1761
1762         Reviewed by Ryosuke Niwa.
1763
1764         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1765         (TestWebKitAPI::TEST_F):
1766
1767 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1768
1769         Remove check for SkipSafariExecutableEntitlementChecks
1770         https://bugs.webkit.org/show_bug.cgi?id=167762
1771         rdar://problem/22480673
1772
1773         Reviewed by Dan Bernstein.
1774
1775         * Scripts/webkitdirs.pm:
1776         (safariPathFromSafariBundle):
1777         (skipSafariExecutableEntitlementChecks): Deleted.
1778
1779 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1780
1781         Undefined subroutine in svn-create-patch
1782         https://bugs.webkit.org/show_bug.cgi?id=167742
1783
1784         Unreviewed build-fix after r211543.
1785
1786         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1787
1788 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1789
1790         Unreviewed. Fix jhbuild dependencies build.
1791
1792         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1793         Patch updated.
1794
1795 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1796
1797         [EME][GStreamer] Fixed decryptor selection
1798         https://bugs.webkit.org/show_bug.cgi?id=167588
1799
1800         Reviewed by Žan Doberšek.
1801
1802         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1803
1804         * gtk/jhbuild.modules: Added patches to gstreamer and
1805         gst-plugins-good packages.
1806         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1807         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1808
1809 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1810
1811         Make run-benchmark script supports 'config' key in test plan.
1812         https://bugs.webkit.org/show_bug.cgi?id=167715
1813
1814         Reviewed by Ryosuke Niwa.
1815
1816         Add support for 'config' key in test paln.
1817         'config' key is a dictionary that specifies environment configurations while test is running.
1818         Specifies orientation to be portrait in MotionMark benchmark.
1819
1820         * Scripts/webkitpy/benchmark_runner/README.md:
1821         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1822         (BenchmarkRunner.__init__):
1823         (BenchmarkRunner._run_benchmark):
1824         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1825         (BrowserDriver.prepare_env):
1826         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1827         (LinuxBrowserDriver.prepare_env):
1828         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1829         (OSXBrowserDriver.prepare_env):
1830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1831         (OSXSafariDriver.prepare_env):
1832         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1833
1834 2017-02-01  Daniel Bates  <dabates@apple.com>
1835
1836         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1837         https://bugs.webkit.org/show_bug.cgi?id=167169
1838
1839         Reviewed by David Kilzer.
1840
1841         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1842         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1843         header from the output of "svn diff" on a file that was copied or moved.
1844
1845         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1846         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1847         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1848         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1849         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1850         of a file with only a property change also does not contain any chunk range lines. Therefore
1851         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1852         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1853         we should directly test for the presence of a leading SVN diff header with an empty body and
1854         remove such lines from the diff.
1855
1856         * Scripts/VCSUtils.pm:
1857         (fixSVNPatchForAdditionWithHistory): Added.
1858         * Scripts/svn-create-patch:
1859         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1860         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1861         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1862
1863 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1864
1865         [Mac] Update CARingBuffer class
1866         https://bugs.webkit.org/show_bug.cgi?id=167656
1867
1868         Reviewed by Jer Noble.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1872         (TestWebKitAPI::CARingBufferTest::SetUp):
1873         (TestWebKitAPI::CARingBufferTest::setup):
1874         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1875         (TestWebKitAPI::CARingBufferTest::description):
1876         (TestWebKitAPI::CARingBufferTest::bufferList):
1877         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1878         (TestWebKitAPI::CARingBufferTest::capacity):
1879         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1880         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1881         (TestWebKitAPI::TEST_F):
1882         (TestWebKitAPI::MixingTest::run):
1883
1884 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1885
1886         [Mac] TestWebKitAPI includes system frameworks incorrectly
1887         https://bugs.webkit.org/show_bug.cgi?id=167703
1888         rdar://problem/30301498
1889
1890         Reviewed by Ryosuke Niwa.
1891
1892         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1893         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1894
1895         Also, reduced the number of subframework search paths, looks like we only need one now.
1896
1897         * TestWebKitAPI/Configurations/Base.xcconfig:
1898
1899 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1900
1901         Correct "filesHaveSameVolume" predicate
1902         https://bugs.webkit.org/show_bug.cgi?id=167696
1903         <rdar://problem/30298722>
1904
1905         Reviewed by David Kilzer.
1906
1907         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1908         percent-escaped path inputs.
1909
1910         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1911         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1912         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1913         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1914         (TestWebKitAPI::TEST_F):
1915
1916 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1917
1918         Unreviewed. Fix coding style in MiniBrowser
1919
1920         * MiniBrowser/gtk/BrowserWindow.c:
1921         (editingCommandCallback):
1922         (insertImageCommandCallback):
1923         (insertLinkCommandCallback):
1924
1925 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1926
1927         [GTK] Add an API to add a custom tab into the print dialog
1928         https://bugs.webkit.org/show_bug.cgi?id=151998
1929
1930         Reviewed by Carlos Garcia Campos.
1931
1932         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1933         that is testing a newly added API.
1934
1935         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1936         (testPrintCustomWidget):
1937         (beforeAll):
1938
1939 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1940
1941         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1942         https://bugs.webkit.org/show_bug.cgi?id=166529
1943
1944         Reviewed by Xabier Rodriguez-Calvar.
1945
1946         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1947         New patch version accepted in GStreamer upstream.
1948
1949 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1950
1951         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1952         https://bugs.webkit.org/show_bug.cgi?id=167498
1953
1954         Reviewed by Carlos Garcia Campos.
1955
1956         Depending on the distro version you can need either libxfont1-dev
1957         or libfont-dev to build with jhbuild.
1958
1959         * gtk/install-dependencies:
1960
1961 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1962
1963         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1964         https://bugs.webkit.org/show_bug.cgi?id=167594
1965
1966         Unreviewed test gardening.
1967
1968         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1969
1970         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1971         (TEST):
1972
1973 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1974
1975         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1976         https://bugs.webkit.org/show_bug.cgi?id=167676
1977
1978         Reviewed by Saam Barati.
1979
1980         * Scripts/run-javascriptcore-tests:
1981         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1982
1983 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1984
1985         Make Dump Render Tree not crash
1986         https://bugs.webkit.org/show_bug.cgi?id=167667
1987
1988         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1989         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1990         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1991         This does not fix any tests, it just fixes the crash.
1992         
1993         Reviewed by Simon Fraser.
1994
1995         * DumpRenderTree/TestRunner.cpp:
1996         (TestRunner::callUIScriptCallback):
1997
1998 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1999
2000         Workaround for simctl install failing to report install failure
2001         https://bugs.webkit.org/show_bug.cgi?id=167654
2002
2003         Reviewed by Daniel Bates.
2004
2005         simctl install will sometimes report success even though install has failed.
2006         To workaround this bug, we attempt an app launch after install to ensure
2007         install has succeeded.
2008
2009         * Scripts/webkitpy/xcode/simulator.py:
2010         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2011         (Device.launch_app): Correct comment.
2012
2013 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2014
2015         Unreviewed webkitpy fix after r211405.
2016
2017         * Scripts/webkitpy/xcode/simulator.py:
2018         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2019
2020 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2021
2022         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2023
2024         * gtk/manifest.txt.in:
2025
2026 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2027
2028         AX: enable search predication for iOS
2029         https://bugs.webkit.org/show_bug.cgi?id=167558
2030         <rdar://problem/30251367>
2031
2032         Reviewed by Joanmarie Diggs.
2033
2034         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2035         (AccessibilityUIElement::uiElementForSearchPredicate):
2036         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2037         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2038         (searchPredicateParameterizedAttributeForSearchCriteria):
2039         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2040         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2041         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2042         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2043         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2044         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2045         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2046         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2047         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2048         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2049         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2050
2051 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2052
2053         Workaround for simctl launch bug
2054         https://bugs.webkit.org/show_bug.cgi?id=167613
2055
2056         Reviewed by Daniel Bates.
2057
2058         simctl launch will sometimes fail because of a race condition when many
2059         simulators are being run simultaneously. These failures will always have
2060         an exit code of 1. This change attempts to launch an app multiple times
2061         before reporting a failure to workaround this bug.
2062
2063         * Scripts/webkitpy/xcode/simulator.py:
2064         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2065
2066 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2067
2068         Commit queue fails to look at real name aliases for the reviewer
2069         https://bugs.webkit.org/show_bug.cgi?id=167422
2070
2071         Reviewed by Joseph Pecoraro.
2072
2073         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2074         (test_has_valid_reviewer): Added tests.
2075
2076         * Scripts/webkitpy/common/config/committers.py:
2077         (CommitterList._name_to_contributor_map):
2078         Made _name_to_contributor_map include alias names.
2079
2080         * Scripts/webkitpy/common/config/committers_unittest.py:
2081         (CommittersTest.test_contributors_by_fuzzy_match):
2082         Removed subtests that are now obsolete, as these matches are strict. It is not
2083         obvious if distance based fuzzy matching for names is useful at all, but we can
2084         look into that some other time.
2085
2086 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2087
2088         QueueStatusServer should have an explicit timeout for _fetch_url
2089         https://bugs.webkit.org/show_bug.cgi?id=167467
2090
2091         Reviewed by Alexey Proskuryakov.
2092
2093         * Scripts/webkitpy/common/net/statusserver.py:
2094         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2095
2096 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2097
2098         Add support for Trac instances that host multiple projects.
2099         https://bugs.webkit.org/show_bug.cgi?id=167524
2100
2101         Reviewed by Alexey Proskuryakov.
2102
2103         When multiple projects are hosted on a single Trac instance, the current
2104         behavior will retrieve changesets from all tracked projects.
2105         This patch teaches Trac.js to get project-specific changesets from Trac.
2106         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2107         when querying the Trac timeline.
2108
2109         To tell Trac to be aware of multi-project instances we leverage the 
2110         `options` parameter when creating a new instance: 
2111
2112             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2113
2114         If this option is not provided, the original behaviour will prevail.
2115         Additionally, add corresponding tests.
2116
2117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2118         (Trac): Reason about new optional parameter 'projectIdentifier'.
2119         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2120         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2121         replace default parameter `changeset=on` with `repo-projectname=on`.
2122         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2124         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2126         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2127         Add the following tests:
2128             test("revisionURL")
2129             test("revisionURL with Trac Identifier")
2130             test("_xmlTimelineURL")
2131             test("_xmlTimelineURL with Trac Identifier")
2132         (this.view._latestProductiveIteration): Fix missing ';'.
2133
2134 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2135
2136         Correct spacing regression on inter-element complex path shaping on some fonts
2137         https://bugs.webkit.org/show_bug.cgi?id=166013
2138
2139         Reviewed by Simon Fraser.
2140
2141         Unskip existing tests and make some new tests:
2142         - Testing complex text with no origins
2143         - Testing initial expansions
2144         - Testing the sign of vertical advances
2145
2146         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2147         (TestWebKitAPI::TEST_F):
2148
2149 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2150
2151         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2152         https://bugs.webkit.org/show_bug.cgi?id=167596
2153
2154         Reviewed by Daniel Bates.
2155
2156         We avoid needing a thin directory by invoking the zip program with
2157         the list of directories from the build directory to be zipped,
2158         and by using the zip feature to exclude files matching a pattern.
2159
2160         * BuildSlaveSupport/built-product-archive:
2161         (copyBuildFiles):
2162         (createZipFromList):
2163         (archiveBuiltProduct):
2164
2165 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2166
2167         Use simctl instead of LayoutTestRelay
2168         https://bugs.webkit.org/show_bug.cgi?id=165927
2169
2170         Reviewed by Daniel Bates.
2171
2172         Part 1
2173
2174         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2175         simulators through simctl (iOS 10 and later), use this functionality instead.
2176
2177         * Scripts/webkitpy/port/base.py:
2178         (Port.__init__): Added _test_runner_process_constructor.
2179         * Scripts/webkitpy/port/darwin.py:
2180         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2181         * Scripts/webkitpy/port/driver.py:
2182         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2183         (IOSSimulatorDriver): Deleted.
2184         * Scripts/webkitpy/port/driver_unittest.py:
2185         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2186         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2187         (DriverTest.test_start_actually_starts): Ditto.
2188         * Scripts/webkitpy/port/ios.py:
2189         (IOSSimulatorPort): Remove relay_name.
2190         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2191         (IOSSimulatorPort._create_simulators): Formatting change.
2192         (IOSSimulatorPort.relay_path): Deleted.
2193         (IOSSimulatorPort._check_relay): Deleted.
2194         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2195         (IOSSimulatorPort._build_relay): Deleted.
2196         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2197         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2198         * Scripts/webkitpy/port/ios_unittest.py:
2199         (iosTest.test_32bit): Update test.
2200         (iosTest.test_64bit): Update test.
2201         * Scripts/webkitpy/port/server_process.py:
2202         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2203         (ServerProcess._set_file_nonblocking): Added to share common code.
2204         * Scripts/webkitpy/port/server_process_mock.py:
2205         (MockServerProcess.__init__): Added argument worker_number.
2206         * Scripts/webkitpy/port/simulator_process.py: Added.
2207         (SimulatorProcess): Added.
2208         (SimulatorProcess.Popen): Added.
2209         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2210         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2211         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2212         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2213         (SimulatorProcess._reset): Added. Unlink fifos.
2214         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2215         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2216         * Scripts/webkitpy/xcode/simulator.py:
2217         (Device.__init__): Accept host to run install/launch/terminate.
2218         (Device.install_app): Install app to target Device.
2219         (Device.launch_app): Launch app on target Device.
2220         (Device.terminate_app): Shutdown app on target Device.
2221         (Simulator._parse_devices): Pass host to Device.
2222
2223 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2224
2225         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2226         https://bugs.webkit.org/show_bug.cgi?id=167411
2227
2228         Reviewed by Michael Catanzaro.
2229
2230         Disable the ARM iwMMXt fast path for pixman, because it triggers
2231         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2232
2233         * gtk/jhbuild.modules:
2234
2235 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2236
2237         [GTK] Add API to handle the accelerated compositing policy
2238         https://bugs.webkit.org/show_bug.cgi?id=167509
2239
2240         Reviewed by Michael Catanzaro.
2241
2242         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2243         as a special case. Also add test cases to the get/set API.
2244
2245         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2246         (hardwareAccelerationPolicyToString):
2247         (stringToHardwareAccelerationPolicy):
2248         (cellRendererChanged):
2249         (browserSettingsDialogConstructed):
2250         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2251         (testWebKitSettings):
2252
2253 2017-01-29  Andy Estes  <aestes@apple.com>
2254
2255         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2256         https://bugs.webkit.org/show_bug.cgi?id=167563
2257         <rdar://problem/30253207>
2258
2259         Reviewed by Andreas Kling.
2260
2261         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2262         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2263         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2264         (runTest):
2265         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2266         (TEST):
2267
2268 2017-01-29  Dan Bernstein  <mitz@apple.com>
2269
2270         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2271         https://bugs.webkit.org/show_bug.cgi?id=167565
2272
2273         Reviewed by Sam Weinig.
2274
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2276         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2277         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2278         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2279         (TEST):
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2281         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2282         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2283         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2284
2285 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2286
2287         Add Link Preload as an off-by-default experimental feature menu item.
2288         https://bugs.webkit.org/show_bug.cgi?id=167201
2289
2290         Reviewed by Ryosuke Niwa.
2291
2292         * DumpRenderTree/mac/DumpRenderTree.mm:
2293         (resetWebPreferencesToConsistentValues):
2294         * DumpRenderTree/win/DumpRenderTree.cpp:
2295         (resetWebPreferencesToConsistentValues):
2296
2297 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2298
2299         Add User Timing Experimental Feature
2300         https://bugs.webkit.org/show_bug.cgi?id=167542
2301         <rdar://problem/22746307>
2302
2303         Reviewed by Ryosuke Niwa.
2304
2305         * DumpRenderTree/mac/DumpRenderTree.mm:
2306         (enableExperimentalFeatures):
2307         (resetWebPreferencesToConsistentValues):
2308         * DumpRenderTree/win/DumpRenderTree.cpp:
2309         (enableExperimentalFeatures):
2310
2311 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2312
2313         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2314         https://bugs.webkit.org/show_bug.cgi?id=167519
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         * QueueStatusServer/templates/statusbubble.html:
2319         To measure the bubbleContainer's width, it must not be wrapping based
2320         on its parent container. So when measuring the width temporarily set
2321         the parent to a very large width so as to not artificially wrap us.
2322         Restore the parent's width after measuring.
2323
2324 2017-01-27  Andy Estes  <aestes@apple.com>
2325
2326         [iOS] Add a test for _WKNSFileManagerExtras
2327         https://bugs.webkit.org/show_bug.cgi?id=167478
2328
2329         Reviewed by Andreas Kling.
2330
2331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2332         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2333         (expectAttributes):
2334         (TEST):
2335
2336 2017-01-27  Keith Miller  <keith_miller@apple.com>
2337
2338         run-benchmarks should make sure it passes the test url to the right application
2339         https://bugs.webkit.org/show_bug.cgi?id=167533
2340
2341         Reviewed by Joseph Pecoraro.
2342
2343         This fixes an issue when trying to run-benchmark script with the
2344         system default browser set to STP. Previously, it would run
2345         the test in STP rather than the provided build. Now, it should run
2346         in the provided build.
2347
2348         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2349         (OSXSafariDriver.launch_url):
2350
2351 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2352
2353         [Cocoa] Prepare ComplexTextController for unit testing
2354         https://bugs.webkit.org/show_bug.cgi?id=167493
2355
2356         Reviewed by Simon Fraser.
2357
2358         Addressing post-review comments from Simon Fraser.
2359
2360         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2361         (TestWebKitAPI::TEST_F):
2362
2363 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2364
2365         [Cocoa] Prepare ComplexTextController for unit testing
2366         https://bugs.webkit.org/show_bug.cgi?id=167493
2367
2368         Reviewed by Dean Jackson.
2369
2370         Create four unit tests.
2371
2372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2373         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2374         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2375         (TestWebKitAPI::TEST_F):
2376
2377 2017-01-26  Chris Dumez  <cdumez@apple.com>
2378
2379         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2380         https://bugs.webkit.org/show_bug.cgi?id=167421
2381         <rdar://problem/30188490>
2382
2383         Reviewed by Darin Adler.
2384
2385         Add a new setting allowing layout tests to enable PageCache in a window
2386         that has an opener, for convenience.
2387
2388         * DumpRenderTree/mac/DumpRenderTree.mm:
2389         (resetWebPreferencesToConsistentValues):
2390         * DumpRenderTree/win/DumpRenderTree.cpp:
2391         (resetWebPreferencesToConsistentValues):
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::resetPreferencesToConsistentValues):
2394
2395 2017-01-26  Keith Miller  <keith_miller@apple.com>
2396
2397         classInfo should take a VM so it is not materialized from the object on each call
2398         https://bugs.webkit.org/show_bug.cgi?id=167424
2399
2400         Rubber Stamped by Michael Saboff.
2401
2402         Previously, classInfo() would get the VM from the target's
2403         MarkedBlock.  Most callers already have a VM on hand, so it is
2404         wasteful to compute the VM from the marked block every time. This
2405         patch refactors some of the most common callers of classInfo(),
2406         jsDynamicCast and inherits to take a VM as well.
2407
2408         * DumpRenderTree/TestRunner.cpp:
2409         (setAudioResultCallback):
2410
2411 2017-01-26  Jer Noble  <jer.noble@apple.com>
2412
2413         Autoplay muted videos stop playback of any streaming app in the background
2414         https://bugs.webkit.org/show_bug.cgi?id=163993
2415         <rdar://problem/29020431>
2416
2417         Reviewed by Eric Carlson.
2418
2419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2420         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2421         (TestWebKitAPI::TEST):
2422         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2423
2424 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2425
2426         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2427         https://bugs.webkit.org/show_bug.cgi?id=167466
2428
2429         Unreviewed test gardening.
2430
2431         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2432         (TEST):
2433
2434 2017-01-26  Matt Rajca  <mrajca@apple.com>
2435
2436         Notify clients when the user plays media otherwise prevented from autoplaying
2437         https://bugs.webkit.org/show_bug.cgi?id=167390
2438
2439         Reviewed by Alex Christensen.
2440
2441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2442         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2443         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2444         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2445         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2446         (TEST):
2447         * TestWebKitAPI/cocoa/TestWKWebView.h:
2448         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2449         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2450         (-[TestWKWebView waitForLoad]):
2451         (-[TestWKWebView mouseUpAtPoint:]):
2452         * WebKitTestRunner/TestController.cpp:
2453         (WTR::TestController::createOtherPage):
2454         (WTR::TestController::createWebViewWithOptions):
2455
2456 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2457
2458         Crash when setting custom scale factor.
2459         https://bugs.webkit.org/show_bug.cgi?id=167369
2460
2461         Reviewed by Sam Weinig.
2462
2463         Added API test.
2464
2465         * TestWebKitAPI/PlatformWin.cmake:
2466         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2467         (TestWebKitAPI::WebKitCreateInstance):
2468         (TestWebKitAPI::ScaleWebView::SetUp):
2469         (TestWebKitAPI::ScaleWebView::TearDown):
2470         (TestWebKitAPI::TEST_F):
2471
2472 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2473
2474         run-benchmark nests MotionMark results by the suite name twice
2475         https://bugs.webkit.org/show_bug.cgi?id=164948
2476
2477         Reviewed by Said Abou-Hallawa.
2478
2479         Use a single level MotionMark now that this is the name of the benchmark,
2480         and we no longer have tests that aren't part of the MotionMark suite.
2481
2482         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2483
2484 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2485
2486         Unreviewed, rolling out r211193.
2487
2488         This change broke internal builds.
2489
2490         Reverted changeset:
2491
2492         "Notify clients when the user plays media otherwise prevented
2493         from autoplaying"
2494         https://bugs.webkit.org/show_bug.cgi?id=167390
2495         http://trac.webkit.org/changeset/211193
2496
2497 2017-01-25  Matt Rajca  <mrajca@apple.com>
2498
2499         Notify clients when the user plays media otherwise prevented from autoplaying
2500         https://bugs.webkit.org/show_bug.cgi?id=167390
2501
2502         Reviewed by Alex Christensen.
2503
2504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2505         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2506         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2507         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2508         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2509         (TEST):
2510         * TestWebKitAPI/cocoa/TestWKWebView.h:
2511         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2512         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2513         (-[TestWKWebView waitForLoad]):
2514         (-[TestWKWebView mouseUpAtPoint:]):
2515         * WebKitTestRunner/TestController.cpp:
2516         (WTR::TestController::createOtherPage):
2517         (WTR::TestController::createWebViewWithOptions):
2518
2519 2017-01-25  Matt Rajca  <mrajca@apple.com>
2520
2521         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2522         https://bugs.webkit.org/show_bug.cgi?id=167385
2523
2524         Reviewed by Alex Christensen.
2525
2526         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2527         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2528         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2529         (TEST): Allow inline (rather than full screen) media playback on iOS.
2530
2531 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2532
2533         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2534         https://bugs.webkit.org/show_bug.cgi?id=167414
2535
2536         Reviewed by Michael Catanzaro.
2537
2538         Add a test case to check ephemeral web views don't write favicons to the database.
2539
2540         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2541         (ephemeralViewLoadChanged):
2542         (testPrivateBrowsing):
2543         (testFaviconDatabase):
2544
2545 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2546
2547         [GTK] Add a private browsing mode to MiniBrowser
2548         https://bugs.webkit.org/show_bug.cgi?id=167413
2549
2550         Reviewed by Michael Catanzaro.
2551
2552         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2553         private windows, even on non-private instances.
2554
2555         * MiniBrowser/gtk/BrowserWindow.c:
2556         (webViewTitleChanged): Add [Private] to title window for private windows.
2557         (webViewCreate): Pass web context to browser_window_new.
2558         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2559         (browserWindowFinalize): Disconnect web context signal handlers.
2560         (browser_window_init): Add shortcut for opening private window.
2561         (browser_window_new): It now receives the context and connect to download-started here.
2562         (browser_window_get_web_context): Return the context.
2563         * MiniBrowser/gtk/BrowserWindow.h:
2564         * MiniBrowser/gtk/main.c:
2565         (createBrowserTab): Create the web view for the window web context.
2566         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2567         (aboutDataHandleRequest): Ditto.
2568         (aboutURISchemeRequestCallback): Ditto.
2569         (main): Create ephemeral web context if private command line option is used.
2570
2571 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2572
2573         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2574         https://bugs.webkit.org/show_bug.cgi?id=167409
2575
2576         Reviewed by Antti Koivisto.
2577
2578         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2579         as well as tests for the newly added matchingElementInFlatTree.
2580
2581         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2582         (TestWebKitAPI::runJavaScriptAlert):
2583         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2584         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2585         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2586
2587 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2590         https://bugs.webkit.org/show_bug.cgi?id=167370
2591
2592         Reviewed by Michael Catanzaro.
2593
2594         Add several test cases of ephemeral web views.
2595
2596         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2597         (testWebViewAuthenticationStorage):
2598         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2599         (ephemeralViewloadChanged):
2600         (testCookieManagerEphemeral):
2601         (beforeAll):
2602         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2603         (testWebKitSettings):
2604         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2605         (testWebContextEphemeral):
2606         (ephemeralViewloadChanged):
2607         (testWebContextProxySettings):
2608         (beforeAll):
2609         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2610         (ephemeralViewloadChanged):
2611         (testWebViewEphemeral):
2612         (beforeAll):
2613         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2614         (ephemeralViewloadChanged):
2615         (testWebsiteDataEphemeral):
2616         (beforeAll):
2617
2618 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2619
2620         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2621         https://bugs.webkit.org/show_bug.cgi?id=167402
2622
2623         Reviewed by Ryosuke Niwa.
2624
2625         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2626         (TestWebKitAPI::TEST):
2627
2628 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2629
2630         Add simple line layout toggle to MiniBrowser
2631         https://bugs.webkit.org/show_bug.cgi?id=167405
2632
2633         Reviewed by Andreas Kling.
2634
2635         * MiniBrowser/mac/SettingsController.h:
2636         * MiniBrowser/mac/SettingsController.m:
2637         (-[SettingsController _populateMenu]):
2638         (-[SettingsController validateMenuItem:]):
2639         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2640         (-[SettingsController simpleLineLayoutEnabled]):
2641         * MiniBrowser/mac/WK1BrowserWindowController.m:
2642         (-[WK1BrowserWindowController didChangeSettings]):
2643         * MiniBrowser/mac/WK2BrowserWindowController.m:
2644         (-[WK2BrowserWindowController didChangeSettings]):
2645
2646 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2647
2648         WKR does not include my nick when commit-queue lands my patch
2649         https://bugs.webkit.org/show_bug.cgi?id=167388
2650
2651         Reviewed by Ryosuke Niwa.
2652
2653         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2654         (NewCommitBot._summarize_commit_log):
2655         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2656         Perform nickname insertion before grabbing "Patch by" details.
2657         This way we can include the nickname with the full name.
2658
2659 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2660
2661         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2662         https://bugs.webkit.org/show_bug.cgi?id=167394
2663
2664         Reviewed by Ryosuke Niwa.
2665
2666         * Scripts/webkitperl/FeatureList.pm:
2667         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2668
2669 2017-01-24  Youenn Fablet  <youenn@apple.com>
2670
2671         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2672         https://bugs.webkit.org/show_bug.cgi?id=167353
2673
2674         Reviewed by Alex Christensen.
2675
2676         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2677         (CMakeGenerator.initialize_targets):
2678
2679 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2680
2681         WKR should not confuse Miguel Gomez with Andres Gomez
2682         https://bugs.webkit.org/show_bug.cgi?id=167389
2683
2684         Reviewed by Lucas Forschler.
2685
2686         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2687         "mAndres Gomez". Fix this.
2688
2689         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2690         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2691         space on each side of the email address, so expect both spaces to be there before
2692         considering the email for replacement.
2693         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2694
2695 2017-01-24  Matt Rajca  <mrajca@apple.com>
2696
2697         Pass down website autoplay policies to media elements
2698         https://bugs.webkit.org/show_bug.cgi?id=167355
2699
2700         Reviewed by Alex Christensen.
2701
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2704         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2705         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2706         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2707         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2708         (TEST):
2709
2710 2017-01-24  Nan Wang  <n_wang@apple.com>
2711
2712         AX: Speak Selection does not work in an iframe
2713         https://bugs.webkit.org/show_bug.cgi?id=166794
2714         <rdar://problem/29913013>
2715
2716         Reviewed by Chris Fleizach.
2717
2718         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2719         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2720         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2721         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2722         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2723         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2724         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2725         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2726         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2727         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2728         (-[TestRunnerWKWebView dealloc]):
2729         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2730         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2731         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2732         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2733         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2734
2735 2017-01-24  Daniel Bates  <dabates@apple.com>
2736
2737         StringView.split() should use an iterator design pattern instead of allocating a Vector
2738         https://bugs.webkit.org/show_bug.cgi?id=163225
2739
2740         Reviewed by Darin Adler.
2741
2742         Add unit tests for StringView.split().
2743
2744         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2745         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2746         used in the StringView.split() unit tests.
2747         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2748         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2749         object to a Vector of String objects.
2750         (TestWebKitAPI::TEST): Added the following tests:
2751             - WTF.StringViewSplitEmptyAndNullStrings
2752             - WTF.StringViewSplitBasic
2753             - WTF.StringViewSplitWithConsecutiveSeparators
2754
2755 2017-01-23  Anders Carlsson  <andersca@apple.com>
2756
2757         The Score Esports crashes on launch
2758         https://bugs.webkit.org/show_bug.cgi?id=167338
2759         rdar://problem/29948645
2760
2761         Reviewed by Dan Bernstein.
2762
2763         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2764         (TestWebKitAPI::TEST):
2765         Add a test.
2766
2767 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2768
2769         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2770         https://bugs.webkit.org/show_bug.cgi?id=146589
2771
2772         Reviewed by Michael Catanzaro.
2773
2774         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2775         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2776
2777         * MiniBrowser/gtk/BrowserWindow.c:
2778         (webViewDecidePolicy):
2779         (newTabCallback):
2780         * MiniBrowser/gtk/main.c:
2781         (createBrowserTab):
2782         (aboutDataRequestFree):
2783         (aboutDataRequestNew):
2784         (aboutDataRequestForView):
2785         (websiteDataRemovedCallback):
2786         (websiteDataClearedCallback):
2787         (aboutDataScriptMessageReceivedCallback):
2788         (domainListFree):
2789         (aboutDataFillTable):
2790         (gotWebsiteDataCallback):
2791         (aboutDataHandleRequest):
2792         (aboutURISchemeRequestCallback):
2793         (main):
2794         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2795         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2796         (serverCallback):
2797         (beforeAll):
2798         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2799         (serverCallback):
2800         (WebsiteDataTest::WebsiteDataTest):
2801         (WebsiteDataTest::~WebsiteDataTest):
2802         (WebsiteDataTest::fetch):
2803         (WebsiteDataTest::remove):
2804         (WebsiteDataTest::clear):
2805         (testWebsiteDataConfiguration):
2806         (testWebsiteDataCache):
2807         (testWebsiteDataStorage):
2808         (testWebsiteDataDatabases):
2809         (testWebsiteDataAppcache):
2810         (beforeAll):
2811         (afterAll):
2812
2813 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2814
2815         Unreviewed, rolling out r211062.
2816         https://bugs.webkit.org/show_bug.cgi?id=167354
2817
2818         broke API tests (Requested by alexchristensen on #webkit).
2819
2820         Reverted changeset:
2821
2822         "Pass down website autoplay policies to media elements"
2823         https://bugs.webkit.org/show_bug.cgi?id=167132
2824         http://trac.webkit.org/changeset/211062
2825
2826 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2827
2828         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2829         https://bugs.webkit.org/show_bug.cgi?id=167330
2830
2831         Reviewed by Tim Horton.
2832
2833         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2834         (TestWebKitAPI::TEST_F):
2835
2836 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2837
2838         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2839         https://bugs.webkit.org/show_bug.cgi?id=167317
2840
2841         Reviewed by Sam Weinig.
2842
2843         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2844         (TestWebKitAPI::TEST_F):
2845
2846 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2847
2848         svn-create-patch should emit properties when files are moved or copied
2849         https://bugs.webkit.org/show_bug.cgi?id=167264
2850
2851         Reviewed by Daniel Bates.
2852
2853         * Scripts/svn-create-patch:
2854         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2855
2856 2017-01-23  Youenn Fablet  <youenn@apple.com>
2857
2858         [WebRTC] Filter libwebrtc link flags
2859         https://bugs.webkit.org/show_bug.cgi?id=167287
2860
2861         Reviewed by Alex Christensen.
2862
2863         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2864         (CMakeGenerator._compute_link_flags):
2865         (CMakeGenerator._compute_link_flags.keep_flag):
2866         (CMakeGenerator._generate_compile_target_options):
2867
2868 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2869
2870         [WebRTC] Make VP8 optional in libwebrtc
2871         https://bugs.webkit.org/show_bug.cgi?id=167257
2872
2873         Reviewed by Darin Adler.
2874
2875         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2876         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2877
2878 2017-01-23  Jer Noble  <jer.noble@apple.com>
2879
2880         Video details does not apear and missing scrubber in Control Center
2881         https://bugs.webkit.org/show_bug.cgi?id=167233
2882
2883         Reviewed by Alex Christensen.
2884
2885         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2886         NowPlayingControlTests for iOS.
2887
2888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2889         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2890         (-[NowPlayingTestWebView setWindowVisible:]):
2891         (TestWebKitAPI::TEST):
2892         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2893         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2894         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2895         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2896         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2897         (SOFT_LINK_CLASS):
2898         (-[TestMessageHandler addMessage:withHandler:]):
2899         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2900         (__simulated_forceClickAssociatedEventsMask):
2901         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2902         (-[TestWKWebViewHostWindow isKeyWindow]):
2903         (-[TestWKWebViewHostWindow makeKeyWindow]):
2904         (-[TestWKWebViewHostWindow resignKeyWindow]):
2905         (-[TestWKWebView initWithFrame:]):
2906         (-[TestWKWebView initWithFrame:configuration:]):
2907         (-[TestWKWebView _setUpTestWindow:]):
2908         (-[TestWKWebView performAfterReceivingMessage:action:]):
2909         (-[TestWKWebView loadTestPageNamed:]):
2910         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2911         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2912         (-[TestWKWebView waitForMessage:]):
2913         (-[TestWKWebView performAfterLoading:]):
2914         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2915         (-[TestWKWebView typeCharacter:]):
2916
2917 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2918
2919         Unreviewed. Bring back gtk-doc error messages after r209981.
2920
2921         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2922         impossible to know what's wrong.
2923
2924         * gtk/gtkdoc.py:
2925         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2926
2927 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2928
2929         [WebRTC] Update build system to make G711 optional in libwebrtc
2930         https://bugs.webkit.org/show_bug.cgi?id=167256
2931
2932         Reviewed by Alex Christensen.
2933
2934         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2935         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2936
2937 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2938
2939         Cleanup RuntimeEnabledFeatures
2940         https://bugs.webkit.org/show_bug.cgi?id=167228
2941
2942         Reviewed by Simon Fraser.
2943
2944         * DumpRenderTree/mac/DumpRenderTree.mm:
2945         (enableExperimentalFeatures):
2946         (resetWebPreferencesToConsistentValues):
2947         (setWebPreferencesForTestOptions):
2948         (resetWebViewToConsistentStateBeforeTesting):
2949         * DumpRenderTree/win/DumpRenderTree.cpp:
2950         (enableExperimentalFeatures):
2951         (resetWebPreferencesToConsistentValues):
2952         More closely match WebKitTestRunner initialization of preferences
2953         for experimental features.
2954
2955 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2956
2957         Build Fix for Windows DumpRenderTree after r210976
2958         https://bugs.webkit.org/show_bug.cgi?id=167115
2959
2960         * DumpRenderTree/win/DumpRenderTree.cpp:
2961         (resetWebPreferencesToConsistentValues):
2962
2963 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2964
2965         Remove outdated ENABLE(CSP_NEXT) build flag
2966         https://bugs.webkit.org/show_bug.cgi?id=167252
2967
2968         Reviewed by Brent Fulgham.
2969
2970         * Scripts/webkitperl/FeatureList.pm:
2971         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2972
2973 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2974
2975         Build Fix for Windows DumpRenderTree after r210976
2976
2977         * DumpRenderTree/win/DumpRenderTree.cpp:
2978         (resetWebPreferencesToConsistentValues):
2979
2980 2017-01-20  Antoine Quint  <graouts@apple.com>
2981
2982         Web Animations should be off by default and enabled as an experimental feature
2983         https://bugs.webkit.org/show_bug.cgi?id=167115
2984         <rdar://problem/30048963>
2985
2986         Reviewed by Joseph Pecoraro.
2987
2988         Turn Web Animations on in DRT.
2989
2990         * DumpRenderTree/mac/DumpRenderTree.mm:
2991         (resetWebPreferencesToConsistentValues):
2992         * DumpRenderTree/win/DumpRenderTree.cpp:
2993         (resetWebPreferencesToConsistentValues):
2994
2995 2017-01-20  Youenn Fablet  <youenn@apple.com>
2996
2997         [WebRTC] Add libwebrtc build infrastructure
2998         https://bugs.webkit.org/show_bug.cgi?id=167207
2999
3000         Reviewed by Alex Christensen.
3001
3002         Adding a script doing the libwebrtc project json to CMake file conversion.
3003
3004         * Scripts/generate-libwebrtc-cmake: Added.
3005         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3006         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3007
3008 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3009
3010         Mini Browser: Show tooltip for Experimental Features
3011         https://bugs.webkit.org/show_bug.cgi?id=167225
3012
3013         Reviewed by Alex Christensen.
3014
3015         * MiniBrowser/mac/SettingsController.m:
3016         (-[SettingsController _populateMenu]):
3017         Include the full details string as a tooltip.
3018
3019 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3020
3021         [Win] Test output results should not be written twice.
3022         https://bugs.webkit.org/show_bug.cgi?id=167197
3023
3024         Reviewed by Brent Fulgham.
3025
3026         Prevent test output from being written twice by returning early from
3027         the dump() function, if it already has been called.
3028         This patch also adds a missing newline to a test output line. 
3029         
3030         * DumpRenderTree/win/DumpRenderTree.cpp:
3031         (dump):
3032
3033 2017-01-20  Antoine Quint  <graouts@apple.com>
3034
3035         [Modern Media Controls] Turn modern media controls on by default
3036         https://bugs.webkit.org/show_bug.cgi?id=165668
3037
3038         Reviewed by Dean Jackson.
3039
3040         Enabled modern media controls by default in test runners.
3041
3042         * DumpRenderTree/TestOptions.h:
3043         * WebKitTestRunner/TestOptions.h:
3044
3045 2017-01-19  Chris Dumez  <cdumez@apple.com>
3046
3047         iterable<> should be enabled on WK1
3048         https://bugs.webkit.org/show_bug.cgi?id=167221
3049         <rdar://problem/30108531>
3050
3051         Reviewed by Youenn Fablet.
3052
3053         * DumpRenderTree/mac/DumpRenderTree.mm:
3054         (resetWebPreferencesToConsistentValues):
3055         * DumpRenderTree/win/DumpRenderTree.cpp:
3056         (resetWebPreferencesToConsistentValues):
3057         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3058         (WTR::InjectedBundle::beginTesting):
3059         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3060         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3061         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3062
3063 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3064
3065         Ensure status server logs go to log file
3066         https://bugs.webkit.org/show_bug.cgi?id=167210
3067
3068         Reviewed by Alexey Proskuryakov.
3069
3070         * Scripts/webkitpy/common/net/statusserver.py:
3071         (StatusServer.next_work_item): Change log level from debug to info in
3072         order to facilitate deubgging issues.
3073         (StatusServer.update_work_items): Same.
3074
3075 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3076
3077         Additional selection tests and interpolation fix
3078         https://bugs.webkit.org/show_bug.cgi?id=167171
3079
3080         Reviewed by Simon Fraser.
3081
3082         We weren't adding the final event when interpolating event streams.
3083
3084         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3085         (-[HIDEventGenerator interpolatedEvents:]):
3086
3087 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3088
3089         [Cocoa] Variation fonts are erroneously disabled on iOS
3090         https://bugs.webkit.org/show_bug.cgi?id=167172
3091
3092         Reviewed by Simon Fraser.
3093
3094         OpenSource builders don't seem to understand sdk=embedded*.
3095
3096         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3097
3098 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3099
3100         Unreviewed. Fix GTK+ unit tests failing since r210531.
3101
3102         Avoid using paths to files that don't actually exist.
3103
3104         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3105         (testWebKitConsoleMessageNetworkError):
3106         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3107         (testContextMenuDefaultMenu):
3108         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3109         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3110         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3111
3112 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3113
3114         [GTK] Provide API to set proxy settings
3115         https://bugs.webkit.org/show_bug.cgi?id=128674
3116
3117         Reviewed by Michael Catanzaro.
3118
3119         Add tests for new proxy settings API.
3120
3121         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3122         (serverCallback):
3123         (ProxyTest::ProxyTest):
3124         (ProxyTest::~ProxyTest):
3125         (ProxyTest::loadURIAndGetMainResourceData):
3126         (ProxyTest::proxyServerPortAsString):
3127         (testWebContextProxySettings):
3128         (beforeAll):
3129
3130 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3131
3132         Add back my old email address so old commits will still match it.
3133
3134         * Scripts/webkitpy/common/config/contributors.json:
3135
3136 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3137
3138         Remove my old email address from contributors.json and watchlist.
3139
3140         * Scripts/validate-committer-lists:
3141         (CommitterListFromGit): Change the mapping to the correct email.
3142         * Scripts/webkitpy/common/config/contributors.json:
3143         * Scripts/webkitpy/common/config/watchlist:
3144
3145 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3146
3147         Unreviewed, rolling out r210848.
3148
3149         This change introduced media-related LayoutTest failures and
3150         crashes on macOS.
3151
3152         Reverted changeset:
3153
3154         "[Modern Media Controls] Turn modern media controls on by
3155         default"
3156         https://bugs.webkit.org/show_bug.cgi?id=165668
3157         http://trac.webkit.org/changeset/210848
3158
3159 2017-01-18  Andreas Kling  <akling@apple.com>
3160
3161         Document::securityOrigin() should return a reference.
3162         <https://webkit.org/b/167124>
3163
3164         Reviewed by Sam Weinig.
3165
3166         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3167         (TestWebKitAPI::TEST_F):
3168
3169 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3170
3171         [Win] Clipboard tests are flaky.
3172         https://bugs.webkit.org/show_bug.cgi?id=167088
3173
3174         Reviewed by Brent Fulgham.
3175
3176         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3177         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3178
3179         * DumpRenderTree/win/DumpRenderTree.cpp:
3180         (main):
3181
3182 2017-01-18  Antoine Quint  <graouts@apple.com>
3183
3184         [Modern Media Controls] Turn modern media controls on by default
3185         https://bugs.webkit.org/show_bug.cgi?id=165668
3186
3187         Reviewed by Dean Jackson.
3188
3189         Enabled modern media controls by default in test runners. 
3190
3191         * DumpRenderTree/TestOptions.h:
3192         * WebKitTestRunner/TestOptions.h:
3193
3194 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3195
3196         Unreviewed, rolling out r210834
3197         https://bugs.webkit.org/show_bug.cgi?id=165668
3198
3199         It introduced dozens of test timeouts.
3200
3201         Reverted changeset:
3202         "[Modern Media Controls] Turn modern media controls on by default"
3203         https://bugs.webkit.org/show_bug.cgi?id=165668
3204         http://trac.webkit.org/changeset/210834
3205
3206 2017-01-17  Antoine Quint  <graouts@apple.com>
3207
3208         [Modern Media Controls] Turn modern media controls on by default
3209         https://bugs.webkit.org/show_bug.cgi?id=165668
3210
3211         Reviewed by Dean Jackson.
3212
3213         Enabled modern media controls by default in test runners. 
3214
3215         * DumpRenderTree/TestOptions.h:
3216         * WebKitTestRunner/TestOptions.h:
3217
3218 2017-01-17  Chris Dumez  <cdumez@apple.com>
3219
3220         Document title changed twice when setting document.title
3221         https://bugs.webkit.org/show_bug.cgi?id=167065
3222
3223         Reviewed by Darin Adler.
3224
3225         Add WebKit2GTK API test that was written by Michael Catanzaro.
3226
3227         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3228         (testWebViewTitleChange):
3229         (beforeAll):
3230
3231 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3232
3233         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3234         https://bugs.webkit.org/show_bug.cgi?id=116551
3235         <rdar://problem/13949830>
3236
3237         Reviewed by Alex Christensen.
3238
3239         * Scripts/webkitperl/FeatureList.pm:
3240         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3241         that is part of the existing WEB_TIMING feature.
3242
3243         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3244
3245 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3246
3247         'webkit-patch post' no longer works with moved/copied files
3248         https://bugs.webkit.org/show_bug.cgi?id=166914
3249         <rdar://problem/29979707>
3250
3251         Reviewed by Daniel Bates.
3252
3253         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3254         file outputs only the "Index:" line with an empty body.  This workaround
3255         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3256         public email list tracking this bug is below.
3257         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3258         
3259
3260         * Scripts/svn-create-patch:
3261         (generateDiff): Ignore an "Index:" line with an empty body.
3262
3263 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3264
3265         Remove the REQUEST_ANIMATION_FRAME flag
3266         https://bugs.webkit.org/show_bug.cgi?id=156980
3267         <rdar://problem/25906849>
3268
3269         Reviewed by Simon Fraser.
3270
3271         * Scripts/webkitperl/FeatureList.pm:
3272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3273
3274 2017-01-15  Sam Weinig  <sam@webkit.org>
3275
3276         Add the ability to use numbers in makeString()
3277         https://bugs.webkit.org/show_bug.cgi?id=167087
3278
3279         Reviewed by Darin Adler.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3283         Add tests for StringConcatenate, focusing on new numeric additions.
3284
3285 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3286
3287         Unreviewed, remove stale comment.
3288
3289         This test was fixed by r163173.
3290
3291         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3292
3293 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3294
3295         Annotate large string tests with largeHeap
3296         https://bugs.webkit.org/show_bug.cgi?id=167054
3297
3298         Reviewed by Filip Pizlo.
3299
3300         * Scripts/run-javascriptcore-tests:
3301         * Scripts/run-jsc-stress-tests:
3302
3303 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3304
3305         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3306         https://bugs.webkit.org/show_bug.cgi?id=167043
3307
3308         Reviewed by Darin Adler.
3309
3310         * Scripts/webkitperl/FeatureList.pm:
3311
3312 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3313
3314         Remove ENABLE(DETAILS_ELEMENT) guards
3315         https://bugs.webkit.org/show_bug.cgi?id=167042
3316
3317         Reviewed by Alex Christensen.
3318
3319         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3320
3321 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3322
3323         26 MotionMark performance tests failing
3324         https://bugs.webkit.org/show_bug.cgi?id=166854
3325
3326         Reviewed by Ryosuke Niwa.
3327
3328         Unrelated change. This is the last place that we need to rename Animometer
3329         to MotionMark.
3330
3331         * Scripts/webkitpy/common/config/watchlist:
3332
3333 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3334
3335         run-jsc-benchmarks' echo should have -e option
3336         https://bugs.webkit.org/show_bug.cgi?id=167009
3337
3338         Reviewed by Sam Weinig.
3339
3340         echo requires `-e` option to use escape sequence.
3341         Without it, in some environment (in my Fedora 25), the escape sequence is not
3342         recognized and just dumped as `\c` etc.
3343
3344         * Scripts/run-jsc-benchmarks:
3345
3346 2017-01-12  Chris Dumez  <cdumez@apple.com>
3347
3348         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3349         https://bugs.webkit.org/show_bug.cgi?id=166995
3350
3351         Reviewed by Jer Noble.
3352
3353         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3354         as some people are having trouble building without it.
3355
3356         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3357
3358 2017-01-12  Sam Weinig  <sam@webkit.org>
3359
3360         Add the ability to filter the set of bindings tests you want to run
3361         https://bugs.webkit.org/show_bug.cgi?id=166977
3362
3363         Reviewed by Tim Horton.
3364
3365         Allows doing things like:
3366             run-bindings-tests TestObj* TestCEReactions*
3367         
3368         to run only those tests that match the patterns.
3369
3370         * Scripts/run-bindings-tests:
3371         (main):
3372         Switch to using optparse and pass the remaining args as the filters.
3373
3374         * Scripts/webkitpy/bindings/main.py:
3375         (BindingsTests.__init__):
3376         Store the pattens.
3377
3378         (BindingsTests.test_matches_patterns):
3379         Add helper predicate to determine if a test should be run. When no
3380         patterns are present, all tests should run.
3381
3382         (BindingsTests.run_tests):
3383         Filter tests using the passed in patterns.
3384
3385 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3386
3387         Followup fix after r210503.
3388         https://bugs.webkit.org/show_bug.cgi?id=166887
3389
3390         Reviewed by Alex Christensen.
3391
3392         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3393         duplicated file handle on Windows. This patch fixes the remaining call sites.
3394
3395         * DumpRenderTree/PixelDumpSupport.cpp:
3396         * DumpRenderTree/TestRunner.cpp:
3397         (TestRunner::waitToDumpWatchdogTimerFired):
3398         * DumpRenderTree/TestRunner.h:
3399         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3400         * DumpRenderTree/win/DumpRenderTree.cpp:
3401         * DumpRenderTree/win/DumpRenderTreeWin.h:
3402         * DumpRenderTree/win/TestRunnerWin.cpp:
3403         (TestRunner::setSpellCheckerLoggingEnabled):
3404
3405 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3406
3407         Add committer status for Megan
3408         https://bugs.webkit.org/show_bug.cgi?id=166954
3409
3410         Reviewed by Tim Horton.
3411
3412         Add committer status for Megan Gardner
3413
3414         * Scripts/webkitpy/common/config/contributors.json:
3415
3416 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3417
3418         Unreviewed test fix after r210599.
3419
3420         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3421         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3422
3423 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3424
3425         Unreviewed build fix after r210599.
3426
3427         Add missing files.
3428
3429         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3430         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3431
3432 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3433
3434         File scheme should not allow access of a resource on a different volume.
3435         https://bugs.webkit.org/show_bug.cgi?id=158552
3436         <rdar://problem/15307582>
3437
3438         Reviewed by Alex Christensen.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3441         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3442         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3443
3444 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3445
3446         Unreviewed, rolling out r210571.
3447
3448         This change broke the 32-bit macOS build and caused LayoutTest
3449         failures.
3450
3451         Reverted changeset:
3452
3453         "File scheme should not allow access of a resource on a
3454         different volume."
3455         https://bugs.webkit.org/show_bug.cgi?id=158552
3456         http://trac.webkit.org/changeset/210571
3457
3458 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3459
3460         [GTK] install-dependencies script misses gdb
3461         https://bugs.webkit.org/show_bug.cgi?id=166917
3462
3463         Reviewed by Michael Catanzaro.
3464
3465         gdb is needed for generating the crash logs.
3466
3467         * gtk/install-dependencies:
3468
3469 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3470
3471         [GTK] No way for applications to set notification permissions without waiting for permission request
3472         https://bugs.webkit.org/show_bug.cgi?id=163366
3473
3474         Reviewed by Carlos Garcia Campos.
3475
3476         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3477         (testWebViewNotification):
3478         (setInitialNotificationPermissionsAllowedCallback):
3479         (setInitialNotificationPermissionsDisallowedCallback):
3480         (testWebViewNotificationInitialPermissionAllowed):
3481         (testWebViewNotificationInitialPermissionDisallowed):
3482         (beforeAll):
3483         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3484         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3485         (WebViewTest::WebViewTest):
3486         (WebViewTest::initializeWebView):
3487         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3488
3489 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3490
3491         MobileMiniBrowser tests don't work by default
3492         https://bugs.webkit.org/show_bug.cgi?id=166910
3493
3494         Reviewed by Alex Christensen.
3495
3496         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3497         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3498
3499 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3500
3501         File scheme should not allow access of a resource on a different volume.
3502         https://bugs.webkit.org/show_bug.cgi?id=158552
3503         <rdar://problem/15307582>
3504
3505         Reviewed by Alex Christensen.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3508         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3509         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3510
3511 2017-01-10  Mark Lam  <mark.lam@apple.com>
3512
3513         Reverting run-jsc-stress-tests' $buildType to use string values.
3514         https://bugs.webkit.org/show_bug.cgi?id=166912
3515
3516         Rubber stamped by Filip Pizlo.
3517
3518         This is so that we can test for it in the tests e.g.
3519         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3520
3521         * Scripts/run-jsc-stress-tests:
3522
3523 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3524
3525         Temporarily add back the file removed in r210463 to unbreak internal bots.
3526
3527         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3528
3529 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3530
3531         svn-apply failed to apply a patch (deleting file with svn property)
3532         https://bugs.webkit.org/show_bug.cgi?id=165953
3533
3534         Reviewed by Daniel Bates.
3535
3536         * Scripts/VCSUtils.pm:
3537         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3538         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3539
3540 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3541
3542         Update flakiness dashboard configuration.
3543         https://bugs.webkit.org/show_bug.cgi?id=166869
3544
3545         Reviewed by Alexey Proskuryakov.
3546
3547         * TestResultServer/static-dashboards/builders.jsonp:
3548         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3549
3550 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3551
3552         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3553         https://bugs.webkit.org/show_bug.cgi?id=165232
3554
3555         Unreviewed follow-up patch after r210539 and r210523.
3556
3557         Instead of using that environment variable, the argument
3558         --display-server=xorg should be passed now.
3559
3560         The GTK+ performance bot was the only bot using this, and is
3561         already passing --display-server=xorg after r210539.
3562
3563         * Scripts/webkitpy/port/gtk.py:
3564         (GtkPort._driver_class):
3565
3566 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3567
3568         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3569         https://bugs.webkit.org/show_bug.cgi?id=166872
3570
3571         Reviewed by Michael Catanzaro.
3572
3573         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3574         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3575         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3576         The step RunWebKitTests already has support for it.
3577
3578         * BuildSlaveSupport/build.webkit.org-config/config.json:
3579         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3580         (RunGtkAPITests.start):
3581         (RunAndUploadPerfTests.start):
3582         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3583
3584 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3585
3586         Unreviewed, rolling out r210531.
3587
3588         This change broke the 32-bit macOS build and caused LayoutTest
3589         failures.
3590
3591         Reverted changeset:
3592
3593         "File scheme should not allow access of a resource on a
3594         different volume."
3595         https://bugs.webkit.org/show_bug.cgi?id=158552
3596         http://trac.webkit.org/changeset/210531
3597
3598 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3599
3600         File scheme should not allow access of a resource on a different volume.
3601         https://bugs.webkit.org/show_bug.cgi?id=158552
3602         <rdar://problem/15307582>
3603
3604         Reviewed by Alex Christensen.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3607         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3608         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3609
3610 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3611
3612         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3613         https://bugs.webkit.org/show_bug.cgi?id=165232
3614
3615         Reviewed by Michael Catanzaro.
3616
3617         Add a new WaylandDriver to run the tests in the user current wayland session.
3618
3619         Also merge all the configuration options for selecting the display server inside one
3620         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3621
3622         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3623
3624         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3625         (TestRunner._create_driver):
3626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3627         (parse_args):
3628         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3629         (PerfTestsRunner._parse_args):
3630         * Scripts/webkitpy/port/gtk.py:
3631         (GtkPort.__init__):
3632         (GtkPort._driver_class):
3633         (GtkPort._search_paths):
3634         * Scripts/webkitpy/port/waylanddriver.py: Added.
3635         (WaylandDriver):
3636         (WaylandDriver.check_driver):
3637         (WaylandDriver._setup_environ_for_test):
3638         (WaylandDriver._start):
3639
3640 2017-01-09  Andy Estes  <aestes@apple.com>
3641
3642         [QuickLook] Add a layout test for webkit.org/b/135651
3643         https://bugs.webkit.org/show_bug.cgi?id=166855
3644
3645         Reviewed by Andreas Kling.
3646
3647         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3648         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3649         errors with code WebKitErrorCannotShowURL.
3650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3651         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3652         not specific to WebKit2 error codes.
3653
3654 2017-01-09  Antoine Quint  <graouts@apple.com>
3655
3656         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3657         https://bugs.webkit.org/show_bug.cgi?id=166837
3658
3659         Reviewed by Alex Christensen.
3660
3661         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3662         the provided value when trying to determine the path to the test file. Failing
3663         that, we use the computed URL or the raw path provided to cover all cases.
3664         
3665         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3666         by applying this patch and seeing the number test failures dramatically reduced
3667         with WK1 due to the option to turn modern media controls off for older media controls
3668         tests.
3669
3670         * DumpRenderTree/DumpRenderTree.h:
3671         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3672         (parseInputLine):
3673         * DumpRenderTree/TestOptions.h:
3674         * DumpRenderTree/TestOptions.mm:
3675         (TestOptions::TestOptions):
3676         * DumpRenderTree/mac/DumpRenderTree.mm:
3677         (runTest):
3678
3679 2017-01-09  Milan Crha  <mcrha@redhat.com>
3680
3681         prepare-ChangeLog: Correct help string for --style option
3682         https://bugs.webkit.org/show_bug.cgi?id=166725
3683
3684         Reviewed by Alexey Proskuryakov.
3685
3686         * Scripts/prepare-ChangeLog:
3687         (main):
3688
3689 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3690
3691         https://bugs.webkit.org/show_bug.cgi?id=166839
3692         Add php7 support for macOS.
3693         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3694
3695         Reviewed by Alexey Proskuryakov.
3696
3697         * Scripts/webkitpy/port/base.py:
3698         (Port._is_darwin_php_version_7):
3699         (Port._debian_php_version):
3700         (Port):
3701         (Port._darwin_php_version):
3702         (Port._apache_config_file_name_for_platform):
3703
3704 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3705
3706         [GTK] Should support key and code properties on keyboard events
3707         https://bugs.webkit.org/show_bug.cgi?id=166759
3708
3709         Reviewed by Carlos Garcia Campos.
3710
3711         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3712         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3713         on tests.
3714
3715 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3716
3717         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3718         https://bugs.webkit.org/show_bug.cgi?id=166760
3719
3720         Reviewed by Darin Adler.
3721
3722         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3723         We can work around that by duplicating and redirecting stdout.
3724
3725         * DumpRenderTree/PixelDumpSupport.cpp:
3726         (dumpWebViewAsPixelsAndCompareWithExpected):
3727         (printPNG):
3728         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3729         (logEventProc):
3730         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3731         (DRTDesktopNotificationPresenter::showDesktopNotification):
3732         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3733         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3734         * DumpRenderTree/win/DumpRenderTree.cpp:
3735         (dumpFrameScrollPosition):
3736         (dumpHistoryItem):
3737         (dumpBackForwardList):
3738         (dump):
3739         (runTest):
3740         (main):
3741         * DumpRenderTree/win/DumpRenderTreeWin.h:
3742         * DumpRenderTree/win/EditingDelegate.cpp:
3743         (EditingDelegate::shouldBeginEditingInDOMRange):
3744         (EditingDelegate::shouldEndEditingInDOMRange):
3745         (EditingDelegate::shouldInsertNode):
3746         (EditingDelegate::shouldInsertText):
3747         (EditingDelegate::shouldDeleteDOMRange):
3748         (EditingDelegate::shouldChangeSelectedDOMRange):
3749         (EditingDelegate::shouldApplyStyle):
3750         (EditingDelegate::shouldChangeTypingStyle):
3751         (EditingDelegate::doPlatformCommand):
3752         (EditingDelegate::webViewDidBeginEditing):
3753         (EditingDelegate::webViewDidChange):
3754         (EditingDelegate::webViewDidEndEditing):
3755         (EditingDelegate::webViewDidChangeTypingStyle):
3756         (EditingDelegate::webViewDidChangeSelection):
3757         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3758         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3759         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3760         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3761         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3762         (FrameLoadDelegate::didCommitLoadForFrame):
3763         (FrameLoadDelegate::didReceiveTitle):
3764         (FrameLoadDelegate::didFinishLoadForFrame):
3765         (FrameLoadDelegate::didFailLoadWithError):
3766         (FrameLoadDelegate::willPerformClientRedirectToURL):
3767         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3768         (FrameLoadDelegate::windowScriptObjectAvailable):
3769         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3770         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3771         (FrameLoadDelegate::didDisplayInsecureContent):
3772         (FrameLoadDelegate::didRunInsecureContent):
3773         (FrameLoadDelegate::webViewProgressFinishedNotification):
3774         * DumpRenderTree/win/HistoryDelegate.cpp:
3775         (HistoryDelegate::didNavigateWithNavigationData):
3776         (HistoryDelegate::didPerformClientRedirectFromURL):
3777         (HistoryDelegate::didPerformServerRedirectFromURL):
3778         (HistoryDelegate::updateHistoryTitle):
3779         (HistoryDelegate::populateVisitedLinksForWebView):
3780         * DumpRenderTree/win/PolicyDelegate.cpp:
3781         (PolicyDelegate::decidePolicyForNavigationAction):
3782         (PolicyDelegate::unableToImplementPolicyWithError):
3783         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3784         (ResourceLoadDelegate::willSendRequest):
3785         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3786         (ResourceLoadDelegate::didReceiveResponse):
3787         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3788         (ResourceLoadDelegate::didFailLoadingWithError):
3789         * DumpRenderTree/win/TestRunnerWin.cpp:
3790         (TestRunner::addDisallowedURL):
3791         (TestRunner::originsWithApplicationCache):
3792         (TestRunner::setStorageDatabaseIdleInterval):
3793         (TestRunner::closeIdleLocalStorageDatabases):
3794         (TestRunner::copyDecodedHostName):
3795         (TestRunner::copyEncodedHostName):
3796         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3797         (TestRunner::isGeolocationProviderActive):
3798         (TestRunner::pathToLocalResource):
3799         (TestRunner::setMockDeviceOrientation):
3800         (TestRunner::setMockGeolocationPosition):
3801         (TestRunner::setMockGeolocationPositionUnavailableError):
3802         (TestRunner::setSpatialNavigationEnabled):
3803         (TestRunner::setAutomaticLinkDetectionEnabled):
3804         (TestRunner::isCommandEnabled):
3805         (TestRunner::authenticateSession):
3806         (TestRunner::addChromeInputField):
3807         (TestRunner::removeChromeInputField):
3808         (TestRunner::focusWebView):
3809         (TestRunner::grantWebNotificationPermission):
3810         (TestRunner::denyWebNotificationPermission):
3811         (TestRunner::removeAllWebNotificationPermissions):
3812         (TestRunner::simulateWebNotificationClick):
3813         (TestRunner::imageCountInGeneralPasteboard):
3814         * DumpRenderTree/win/UIDelegate.cpp:
3815         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3816         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3817         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3818         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3819         (UIDelegate::webViewAddMessageToConsole):
3820         (UIDelegate::exceededDatabaseQuota):
3821         (UIDelegate::setStatusText):
3822         (UIDelegate::didPressMissingPluginButton):
3823
3824 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3825
3826         Add a setting to create editable MiniBrowser windows by default
3827         https://bugs.webkit.org/show_bug.cgi?id=166806
3828
3829         Reviewed by Beth Dakin.
3830
3831         * MiniBrowser/mac/AppDelegate.m:
3832         (-[BrowserAppDelegate createBrowserWindowController:]):
3833         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3834         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3835         * MiniBrowser/mac/SettingsController.h:
3836         * MiniBrowser/mac/SettingsController.m:
3837         (-[SettingsController _populateMenu]):
3838         (-[SettingsController validateMenuItem:]):
3839         (-[SettingsController toggleCreateEditorByDefault:]):
3840         (-[SettingsController createEditorByDefault]):
3841         Add a setting and update the key equivalents accordingly.
3842         Also make sure to make the right kind of window on launch.
3843
3844 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3845
3846         Fix the 32-bit build.
3847
3848         * MiniBrowser/mac/BrowserWindowController.h:
3849         * MiniBrowser/mac/BrowserWindowController.m:
3850
3851 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3852
3853         Fix the 32-bit build.
3854
3855         * MiniBrowser/mac/BrowserWindowController.m:
3856
3857 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3858
3859         Make it possible to drop HTML files on the MiniBrowser icon
3860         https://bugs.webkit.org/show_bug.cgi?id=166802
3861
3862         Reviewed by Simon Fraser.
3863
3864         * MiniBrowser/mac/AppDelegate.m:
3865         (-[BrowserAppDelegate application:openFile:]):
3866         * MiniBrowser/mac/Info.plist:
3867         If you're using an editable window, the usual trick of dropping on the
3868         window doesn't work anymore (it makes an <attachment> instead).
3869
3870 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3871
3872         MiniBrowser window gets smaller each time it is instantiated
3873         https://bugs.webkit.org/show_bug.cgi?id=166807
3874
3875         Reviewed by Andy Estes.
3876
3877         * MiniBrowser/mac/BrowserWindowController.m:
3878         (-[BrowserWindowController windowDidLoad]):
3879         * MiniBrowser/mac/BrowserWindow.xib:
3880         Turn on full-window content view support with IB, instead of waiting
3881         until after the views have been loaded. This seems to resolve the
3882         longstanding ever-shrinking-window problem.
3883
3884 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3885
3886         Add indent/outdent items to MiniBrowser's new format menu
3887         https://bugs.webkit.org/show_bug.cgi?id=166805
3888
3889         Reviewed by Dan Bernstein.
3890
3891         * MiniBrowser/mac/MainMenu.xib:
3892
3893 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3894
3895         Add a stock Format menu to MiniBrowser
3896         https://bugs.webkit.org/show_bug.cgi?id=166804
3897
3898         Reviewed by Andy Estes.
3899
3900         * MiniBrowser/mac/MainMenu.xib:
3901         Many of the features automatically work with editable web views.
3902         However, this seems to expose a bug where none of the font-related features
3903         (Cmd-B, for example) work until the first time the font panel is shown,
3904         per process, which will need to be investigated separately.
3905
3906 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3907
3908         Remove unused applicationWillTerminate methods from MiniBrowser
3909         https://bugs.webkit.org/show_bug.cgi?id=166803
3910
3911         Reviewed by Andy Estes.
3912
3913         * MiniBrowser/mac/AppDelegate.m:
3914         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3915         * MiniBrowser/mac/BrowserWindowController.h:
3916         * MiniBrowser/mac/BrowserWindowController.m:
3917         (-[BrowserWindowController applicationTerminating]): Deleted.
3918         * MiniBrowser/mac/WK1BrowserWindowController.m:
3919         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3920         * MiniBrowser/mac/WK2BrowserWindowController.m:
3921         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3922
3923 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3924
3925         Add the ability to create empty contentEditable windows in MiniBrowser
3926         https://bugs.webkit.org/show_bug.cgi?id=166801
3927
3928         Reviewed by Wenson Hsieh.
3929
3930         * MiniBrowser/mac/AppDelegate.h:
3931         * MiniBrowser/mac/AppDelegate.m:
3932         (-[BrowserAppDelegate createBrowserWindowController:]):
3933         (-[BrowserAppDelegate newWindow:]):
3934         (-[BrowserAppDelegate newEditorWindow:]):
3935         (-[BrowserAppDelegate openDocument:]):
3936         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3937         * MiniBrowser/mac/BrowserWindowController.h:
3938         * MiniBrowser/mac/BrowserWindowController.m:
3939         (-[BrowserWindowController loadHTMLString:]):
3940         (-[BrowserWindowController toggleEditable:]):
3941         * MiniBrowser/mac/MainMenu.xib:
3942         * MiniBrowser/mac/WK1BrowserWindowController.m:
3943         (-[WK1BrowserWindowController awakeFromNib]):
3944         (-[WK1BrowserWindowController loadHTMLString:]):
3945         (-[WK1BrowserWindowController validateMenuItem:]):
3946         (-[WK1BrowserWindowController setEditable:]):
3947         (-[WK1BrowserWindowController updateTitle:]):
3948         * MiniBrowser/mac/WK2BrowserWindowController.m:
3949         (-[WK2BrowserWindowController awakeFromNib]):
3950         (-[WK2BrowserWindowController validateMenuItem:]):
3951         (-[WK2BrowserWindowController setEditable:]):
3952         (-[WK2BrowserWindowController updateTitle:]):
3953         (-[WK2BrowserWindowController loadHTMLString:]):
3954         Merge more functionality from WebEditingTester.
3955         Add two menu items for creating empty editable WebKit1/2 windows.
3956         Add a menu item to the Edit menu to toggle editability on any window.
3957
3958 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3959
3960         Implement find-in-page in MiniBrowser
3961         https://bugs.webkit.org/show_bug.cgi?id=166799
3962
3963         Reviewed by Andy Estes.
3964
3965         * MiniBrowser/mac/BrowserWindow.xib:
3966         * MiniBrowser/mac/BrowserWindowController.h:
3967         * MiniBrowser/mac/BrowserWindowController.m:
3968         (-[BrowserWindowController find:]): Deleted.
3969         * MiniBrowser/mac/MainMenu.xib:
3970         * MiniBrowser/mac/WK1BrowserWindowController.m:
3971         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3972         (-[WK1BrowserWindowController find:]): Deleted.
3973         * MiniBrowser/mac/WK2BrowserWindowController.m:
3974         (-[WK2BrowserWindowController awakeFromNib]):
3975         (-[WK2BrowserWindowController dealloc]):
3976         (-[WK2BrowserWindowController validateMenuItem:]):
3977         (-[WK2BrowserWindowController performTextFinderAction:]):
3978         (-[WK2BrowserWindowController findBarView]):
3979         (-[WK2BrowserWindowController setFindBarView:]):
3980         (-[WK2BrowserWindowController isFindBarVisible]):
3981         (-[WK2BrowserWindowController setFindBarVisible:]):
3982         (-[WK2BrowserWindowController contentView]):
3983         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3984         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3985         (-[WK2BrowserWindowController find:]): Deleted.
3986         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3987         protocol. At first glance, it's pretty broken, but vaguely works.
3988
3989 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3990
3991         Share the implementation of MiniBrowser view hiding functionality
3992         https://bugs.webkit.org/show_bug.cgi?id=166800
3993
3994         Reviewed by Andy Estes.
3995
3996         * MiniBrowser/mac/BrowserWindowController.m:
3997         (-[BrowserWindowController showHideWebView:]):
3998         (-[BrowserWindowController removeReinsertWebView:]):
3999         * MiniBrowser/mac/WK1BrowserWindowController.m:
4000         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
4001         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
4002         * MiniBrowser/mac/WK2BrowserWindowController.m:
4003         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
4004         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
4005         Move the implementation of these two things to the shared superclass,
4006         since they don't depend on WebKit-specific things.
4007         Also, there was no reason to retain the (WK)WebView while it was unparented,
4008         as the BrowserWindowController maintains a reference the entire time.
4009
4010 2017-01-06  Andy Estes  <aestes@apple.com>
4011
4012         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
4013         https://bugs.webkit.org/show_bug.cgi?id=166789
4014
4015         Reviewed by Alex Christensen.
4016
4017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4018         * DumpRenderTree/PlatformMac.cmake:
4019         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
4020         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
4021         * DumpRenderTree/mac/DumpRenderTree.mm:
4022         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4023         createXMLStringFromWebArchiveData().
4024         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
4025         * WebKitTestRunner/Configurations/Base.xcconfig:
4026         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
4027         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4028         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4029         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4030         createXMLStringFromWebArchiveData().
4031         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
4032         * WebKitTestRunner/PlatformMac.cmake:
4033         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4034         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
4035
4036 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4037
4038         Minor cleanups to IndentOutdentCommand and related code
4039         https://bugs.webkit.org/show_bug.cgi?id=166791
4040
4041         Reviewed by Simon Fraser.
4042
4043         * WebEditingTester/EditingOperations.m:
4044         (editingOperations):
4045         Add the outdent operation to WebEditingTester.
4046
4047 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
4048
4049         Create a plan and a patch files for MotionMark and delete the Animometer's ones
4050         https://bugs.webkit.org/show_bug.cgi?id=166785
4051
4052         Reviewed by Ryosuke Niwa.
4053
4054         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
4055         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
4056
4057 2017-01-06  Antoine Quint  <graouts@apple.com>
4058
4059         Support webkit-test-runner key-value pairs in http tests
4060         https://bugs.webkit.org/show_bug.cgi?id=149812
4061
4062         Reviewed by Alex Christensen.
4063
4064         We pass the absolute path for a test through to WKTR so that we can parse
4065         tests that are running as URLs for webkit-test-runner options.
4066
4067         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4068         (parseInputLine):
4069
4070         Explicitly skip the --absolute-path option in DRT or else we'd crash.
4071
4072         * Scripts/webkitpy/port/driver.py:
4073         (Driver._command_from_driver_input):
4074
4075         Pass the absolute path to the file through the CLI.
4076
4077         * WebKitTestRunner/TestController.cpp:
4078         (WTR::updateTestOptionsFromTestHeader):
4079         (WTR::TestController::testOptionsForTest):
4080         (WTR::parseInputLine):
4081         (WTR::TestController::runTest):
4082         * WebKitTestRunner/TestController.h:
4083
4084 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4085
4086         Warning about unconnectable outlets when opening a MiniBrowser window
4087         https://bugs.webkit.org/show_bug.cgi?id=166756
4088
4089         Reviewed by Dan Bernstein.
4090
4091         * MiniBrowser/mac/BrowserWindow.xib:
4092         When launching MiniBrowser, it says:
4093         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
4094             (MBToolbarItem): missing setter or instance variable
4095         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
4096             (NSButtonCell): missing setter or instance variable.
4097
4098         It looks like someone added the connection from the share button
4099         to the BrowserWindowController three times; only one of the connections
4100         is valid. Remove the other two.
4101
4102 2017-01-05  Keith Rollin  <krollin@apple.com>
4103
4104         Add WebCore::URL::protocolHostAndPort
4105         https://bugs.webkit.org/show_bug.cgi?id=166426
4106
4107         Reviewed by Alex Christensen.
4108
4109         Add test for protocolHostAndPort.
4110
4111         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4112         (TestWebKitAPI::TEST_F):
4113
4114 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
4115
4116         [Win] Archive test result is failing.
4117         https://bugs.webkit.org/show_bug.cgi?id=166720
4118
4119         Reviewed by Alex Christensen.
4120
4121         Deleting the layout test result folder is sometimes failing
4122         on Windows. This is not a critical error.
4123
4124         * BuildSlaveSupport/test-result-archive:
4125         (archiveTestResults):
4126
4127 2017-01-04  Tomas Popela  <tpopela@redhat.com>
4128
4129         [GTK] Minibrowser: Add printing support
4130         https://bugs.webkit.org/show_bug.cgi?id=165298
4131
4132         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
4133         an error during the print, it's printed on the console.
4134
4135         Reviewed by Michael Catanzaro.
4136
4137         * MiniBrowser/gtk/BrowserWindow.c:
4138         (webKitPrintOperationFailedCallback):
4139         (printPage):
4140         (browser_window_init):
4141
4142 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
4143
4144         [css-grid] Fix crash clamping grid lines
4145         https://bugs.webkit.org/show_bug.cgi?id=166637
4146
4147         Reviewed by Darin Adler.
4148
4149         Creates new unit test to verify that the maximum tracks limit
4150         is used in GridPosition too.
4151
4152         * TestWebKitAPI/PlatformEfl.cmake:
4153         * TestWebKitAPI/PlatformGTK.cmake:
4154         * TestWebKitAPI/PlatformWin.cmake:
4155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4156         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
4157         (TestWebKitAPI::TEST):
4158
4159 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4160
4161         Move editing history scripts to WebCore PrivateHeaders
4162         https://bugs.webkit.org/show_bug.cgi?id=166709
4163         <rdar://problem/29876612>
4164
4165         Reviewed by Dan Bernstein.
4166
4167         Update references to editing script files in WebCore that were moved.
4168
4169         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
4170
4171 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4172
4173         Unreviewed, build fix after r210313 part 2
4174         https://bugs.webkit.org/show_bug.cgi?id=166676
4175
4176         Add 'U' suffix.
4177
4178         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4179         (TestWebKitAPI::TEST):
4180         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4181         (TestWebKitAPI::TEST):
4182
4183 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4184
4185         Limit thread name appropriately
4186         https://bugs.webkit.org/show_bug.cgi?id=166676
4187
4188         Reviewed by Sam Weinig.
4189
4190         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4191         (TestWebKitAPI::TEST):
4192         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4193         (TestWebKitAPI::TEST):
4194
4195 2017-01-04  Andy Estes  <aestes@apple.com>
4196
4197         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
4198         https://bugs.webkit.org/show_bug.cgi?id=166696
4199
4200         Reviewed by Tim Horton.
4201
4202         * TestWebKitAPI/PlatformGTK.cmake:
4203         * TestWebKitAPI/PlatformWin.cmake:
4204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4205         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
4206         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
4207         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
4208         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
4209         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
4210         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
4211
4212 2017-01-03  Brian Burg  <bburg@apple.com>
4213
4214         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
4215         https://bugs.webkit.org/show_bug.cgi?id=166003
4216         <rdar://problem/28718990>
4217
4218         Reviewed by Joseph Pecoraro.
4219
4220         Teach run-inspector-generator-tests to generate test output using the platform name
4221         derived from the directory that the test is in. For example, tests in the /generic/
4222         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
4223
4224         * Scripts/webkitpy/inspector/main.py:
4225         (InspectorGeneratorTests.generate_from_json):
4226         (InspectorGeneratorTests.run_tests):
4227         (InspectorGeneratorTests.main):
4228
4229 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
4230
4231         Unreviewed cmake buildfix after r210266.
4232
4233         * DumpRenderTree/PlatformMac.cmake:
4234
4235 2017-01-04  Tim Horton  <timothy_horton@apple.com>
4236
4237         Provide a setting for clients to always prefer low-power WebGL
4238         https://bugs.webkit.org/show_bug.cgi?id=166675
4239         <rdar://problem/29834093>
4240
4241         Reviewed by Dan Bernstein.
4242
4243         * MiniBrowser/mac/Info.plist:
4244         Have MiniBrowser claim to be a modern app that supports
4245         automatic graphics switching. WebKit needs to support automatic
4246         graphics switching, so our test app might as well. Without this
4247         Info.plist parameter, this change has no effect, and bringing up
4248         a WebGL context still brings up the discrete GPU (also true of the
4249         existing web-exposed preferLowPowerToHighPerformance API).
4250
4251 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4252
4253         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
4254         https://bugs.webkit.org/show_bug.cgi?id=166645
4255
4256         Reviewed by Carlos Garcia Campos.
4257
4258         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4259         (TestWebKitAPI::TEST):
4260
4261 2017-01-03  Andy Estes  <aestes@apple.com>
4262
4263         Place all the Cocoa WebCore API tests in the same directory
4264         https://bugs.webkit.org/show_bug.cgi?id=166673
4265
4266         Reviewed by Michael Catanzaro.
4267
4268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4269         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
4270         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
4271         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
4272
4273 2017-01-03  Tim Horton  <timothy_horton@apple.com>
4274
4275         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
4276         https://bugs.webkit.org/show_bug.cgi?id=166450
4277         <rdar://problem/29447824>
4278
4279         Reviewed by Darin Adler.
4280
4281         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4282         * DumpRenderTree/TestRunner.cpp: