[ews-app] Add method to save Build data to database
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Add method to save Build data to database
4         https://bugs.webkit.org/show_bug.cgi?id=193735
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/models/build.py:
9         (Build.save_build): Method to save build information to database.
10         (Build.get_existing_build): Method to fetch existing build from database.
11         (Build.is_valid_result): Method to validate build result.
12         * BuildSlaveSupport/ews-app/ews/common/util.py:
13         (is_valid_int_id): Method to validate valid id.
14
15 2019-01-28  Chris Dumez  <cdumez@apple.com>
16
17         Regression(PSON) Crash under WebPageProxy::didStartProgress()
18         https://bugs.webkit.org/show_bug.cgi?id=193915
19         <rdar://problem/47560907>
20
21         Reviewed by Alex Christensen.
22
23         Add API test coverage.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
26
27 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
28
29         [ews-app] Rename id variables
30         https://bugs.webkit.org/show_bug.cgi?id=193883
31
32         Reviewed by Lucas Forschler.
33
34         * BuildSlaveSupport/ews-app/ews/models/build.py:
35         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
36         * BuildSlaveSupport/ews-app/ews/models/step.py:
37         * BuildSlaveSupport/ews-app/ews/urls.py:
38         * BuildSlaveSupport/ews-app/ews/views/patch.py:
39         * BuildSlaveSupport/ews-app/ews/views/results.py:
40         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
41
42 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
43
44         [ews-app] Allow certain fields to be empty
45         https://bugs.webkit.org/show_bug.cgi?id=193892
46
47         Reviewed by Lucas Forschler.
48
49         * BuildSlaveSupport/ews-app/ews/models/build.py:
50         * BuildSlaveSupport/ews-app/ews/models/step.py:
51
52 2019-01-28  Rob Buis  <rbuis@igalia.com>
53
54         Update MIME type parser
55         https://bugs.webkit.org/show_bug.cgi?id=180526
56
57         Reviewed by Frédéric Wang.
58
59         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
60         (TestWebKitAPI::TEST):
61
62 2019-01-28  Zalan Bujtas  <zalan@apple.com>
63
64         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
65         https://bugs.webkit.org/show_bug.cgi?id=193896
66
67         Reviewed by Antti Koivisto.
68
69         * LayoutReloaded/misc/LFC-passing-tests.txt:
70
71 2018-12-15  Darin Adler  <darin@apple.com>
72
73         Replace many uses of String::format with more type-safe alternatives
74         https://bugs.webkit.org/show_bug.cgi?id=192742
75
76         Reviewed by Mark Lam.
77
78         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
79         (WTR::cacheTestRunnerCallback): Use makeString.
80         * WebKitTestRunner/TestController.cpp:
81         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
82         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
83
84 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
85
86         Use a load optimizer for some sites
87         https://bugs.webkit.org/show_bug.cgi?id=193881
88         <rdar://problem/46325455>
89
90         Reviewed by Brent Fulgham.
91
92         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
93         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
94
95 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
96
97         AX: Introduce a static accessibility tree
98         https://bugs.webkit.org/show_bug.cgi?id=193348
99         <rdar://problem/47203295>
100
101         Reviewed by Ryosuke Niwa.
102
103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
104
105 2019-01-26  Zalan Bujtas  <zalan@apple.com>
106
107         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
108         https://bugs.webkit.org/show_bug.cgi?id=193867
109
110         Reviewed by Antti Koivisto.
111
112         * LayoutReloaded/misc/LFC-passing-tests.txt:
113
114 2019-01-26  Zalan Bujtas  <zalan@apple.com>
115
116         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
117         https://bugs.webkit.org/show_bug.cgi?id=193865
118
119         Reviewed by Antti Koivisto.
120
121         * LayoutReloaded/misc/LFC-passing-tests.txt:
122
123 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
124
125         Need a mechanism to override navigator.userAgent
126         https://bugs.webkit.org/show_bug.cgi?id=193762
127         <rdar://problem/47504939>
128
129         Reviewed by Brent Fulgham.
130
131         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
132
133         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
134         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
135         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
136
137 2019-01-25  Dean Jackson  <dino@apple.com>
138
139         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
140         https://bugs.webkit.org/show_bug.cgi?id=193831
141         <rdar://problem/47399263>
142
143         Reviewed by Chris Dumez.
144
145         Two new tests that exercise cross-origin and same-origin System
146         Previews.
147
148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
149
150 2019-01-25  Keith Rollin  <krollin@apple.com>
151
152         Update Xcode projects with "Check .xcfilelists" build phase
153         https://bugs.webkit.org/show_bug.cgi?id=193790
154         <rdar://problem/47201374>
155
156         Reviewed by Alex Christensen.
157
158         Support for XCBuild includes specifying inputs and outputs to various
159         Run Script build phases. These inputs and outputs are specified as
160         .xcfilelist files. Once created, these .xcfilelist files need to be
161         kept up-to-date. In order to check that they are up-to-date or not,
162         add an Xcode build step that invokes an external script that performs
163         the checking. If the .xcfilelists are found to be out-of-date, update
164         them, halt the build, and instruct the developer to restart the build
165         with up-to-date files.
166
167         At this time, the checking and regenerating is performed only if the
168         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
169         who want to use this facility can set this variable and test out the
170         checking/regenerating. Once it seems like there are no egregious
171         issues that upset a developer's workflow, we'll unconditionally enable
172         this facility.
173
174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
175         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
176         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
177         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
178
179 2019-01-25  Keith Rollin  <krollin@apple.com>
180
181         Update Xcode projects with "Apply Configuration to XCFileLists" build target
182         https://bugs.webkit.org/show_bug.cgi?id=193781
183         <rdar://problem/47201153>
184
185         Reviewed by Alex Christensen.
186
187         Part of generating the .xcfilelists used as part of adopting XCBuild
188         includes running `make DerivedSources.make` from a standalone script.
189         It’s important for this invocation to have the same environment as
190         when the actual build invokes `make DerivedSources.make`. If the
191         environments are different, then the two invocations will provide
192         different results. In order to get the same environment in the
193         standalone script, have the script launch xcodebuild targeting the
194         "Apply Configuration to XCFileLists" build target, which will then
195         re-invoke our standalone script. The script is now running again, this
196         time in an environment with all workspace, project, target, xcconfig
197         and other environment variables established.
198
199         The "Apply Configuration to XCFileLists" build target accomplishes
200         this task via a small embedded shell script that consists only of:
201
202             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
203
204         The process that invokes "Apply Configuration to XCFileLists" first
205         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
206         evaluated and exports it into the shell environment. When xcodebuild
207         is invoked, it inherits the value of this variable and can `eval` the
208         contents of that variable. Our external standalone script can then set
209         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
210         of command-line parameters needed to restart itself in the appropriate
211         state.
212
213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
214         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
215
216 2019-01-25  Alex Christensen  <achristensen@webkit.org>
217
218         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
219         https://bugs.webkit.org/show_bug.cgi?id=193802
220         <rdar://problem/46010580>
221
222         Reviewed by Andy Estes.
223
224         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
225         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
226         (TEST):
227
228 2019-01-25  Daniel Bates  <dabates@apple.com>
229
230         [iOS] uiController.keyDown() does not translate Control modified key
231         https://bugs.webkit.org/show_bug.cgi?id=192898
232
233         Reviewed by Wenson Hsieh.
234
235         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
236         key translation, as applicable. Among other cases, key translation occurs when performing
237         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
238         also makes the behavior of uiController.keyDown() more closely match the behavior of a
239         human pressing down and releasing key(s) using a hardware keyboard.
240
241         * WebKitTestRunner/ios/HIDEventGenerator.h:
242         * WebKitTestRunner/ios/HIDEventGenerator.mm:
243         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
244
245         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
246         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
247         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
248         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
249         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
250         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
251         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
252         (-[HIDEventGenerator longPress:completionBlock:]):
253         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
254         Update code for above renaming.
255
256         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
257         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
258
259         (-[HIDEventGenerator keyDown:]): Added.
260         (-[HIDEventGenerator keyUp:]): Added.
261         (-[HIDEventGenerator keyPress:completionBlock:]):
262         (-[HIDEventGenerator eventDispatchThreadEntry:]):
263         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
264         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
265         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
266         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
267         (WTR::parseModifier): Deleted.
268
269 2019-01-25  Keith Rollin  <krollin@apple.com>
270
271         Complete the implementation of generate-xcfilelists
272         https://bugs.webkit.org/show_bug.cgi?id=193782
273
274         Reviewed by Alex Christensen.
275
276         A preliminary version of generate-xcfilelists was added in r238008.
277         This patch updates that script in order to:
278
279         - Support checking of .xcfilelists
280         - Perform better execution of `make DerivedSources.make` by
281           relaunching generate-xcfilelists under xcodebuild
282         - Support incremental generation and checking of .xcfilelists
283         - Support supplementary .xcfilelists files from WebKitAdditions
284         - Support being wrapped by parallel version of generate-xcfilelists in
285           Internal that adds support for (re)generating WebKit projects in
286           that repo.
287         - Support builds that have been performed in WebKitBuild as well as
288           ~/Library/Developer/code/DerivedData
289         - Increase robustness and debugging facilities.
290
291         * Scripts/generate-xcfilelists:
292
293 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
294
295         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
296         https://bugs.webkit.org/show_bug.cgi?id=193297
297         <rdar://problem/47158841>
298
299         Unreviewed test case fix.
300
301         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
302         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
305         (TEST):
306
307 2019-01-25  Keith Rollin  <krollin@apple.com>
308
309         Update existing .xcfilelists
310         https://bugs.webkit.org/show_bug.cgi?id=193791
311         <rdar://problem/47201706>
312
313         Reviewed by Alex Christensen.
314
315         Many .xcfilelist files were added in r238824 in order to support
316         XCBuild. Update these with recent changes to the set of build files
317         and with the current generate-xcfilelist script.
318
319         * DumpRenderTree/DerivedSources-input.xcfilelist:
320         * DumpRenderTree/DerivedSources-output.xcfilelist:
321         * WebKitTestRunner/DerivedSources-input.xcfilelist:
322         * WebKitTestRunner/DerivedSources-output.xcfilelist:
323
324 2019-01-25  Keith Rollin  <krollin@apple.com>
325
326         Fix missing dependencies in extract-dependencies-from-makefile
327         https://bugs.webkit.org/show_bug.cgi?id=193783
328         <rdar://problem/47201571>
329
330         Reviewed by Alex Christensen.
331
332         The extract-dependencies-from-makefile script generates .xcfilelists
333         for XCBuild by invoking a makefile in --debug mode, parsing the
334         dependency information in the output, and extracting information
335         regarding targets and dependents. However, the way `make` emits this
336         dependency information is not rigorous, and so we need to determine
337         what lines to look for and parse by trial and error. This approach
338         didn't coriginally atch all the information we needed to collect, so
339         update the script to look for the additional lines we now know to look
340         for.
341
342         * Scripts/extract-dependencies-from-makefile:
343         (Parser):
344         (Parser.addTarget):
345         (Parser.addPrereq):
346         (Parser.doParse):
347
348 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
349
350         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
351         https://bugs.webkit.org/show_bug.cgi?id=193297
352         <rdar://problem/47158841>
353
354         Reviewed by Alex Christensen.
355
356         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
357             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
359         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
360         activating the message used to trigger the callback when it is set.
361
362 2019-01-25  Alex Christensen  <achristensen@webkit.org>
363
364         WKWebView.goBack should reload if there is a safe browsing warning
365         https://bugs.webkit.org/show_bug.cgi?id=193805
366         <rdar://problem/46908216>
367
368         Reviewed by Geoff Garen.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
371         (+[Simple3LookupContext sharedLookupContext]):
372         (-[Simple3LookupContext lookUpURL:completionHandler:]):
373         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
374         (TEST):
375
376 2019-01-25  Chris Dumez  <cdumez@apple.com>
377
378         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
379         https://bugs.webkit.org/show_bug.cgi?id=193788
380         <rdar://problem/47531231>
381
382         Reviewed by Alex Christensen.
383
384         Add API test coverage.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
387         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
388
389 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
390
391         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
392         https://bugs.webkit.org/show_bug.cgi?id=193771
393
394         Unreviewed infrastructure fix.
395
396         * Scripts/webkitpy/port/darwin.py:
397         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
398
399 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
400
401         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
402
403 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
404
405         Add contributors.json entries for Ling Ho and for a new bot watchers group.
406
407         * Scripts/webkitpy/common/config/contributors.json:
408
409 2019-01-25  Chris Dumez  <cdumez@apple.com>
410
411         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
412         https://bugs.webkit.org/show_bug.cgi?id=193779
413         <rdar://problem/46170903>
414
415         Reviewed by Antti Koivisto.
416
417         Add API test that quickly navigates forward to a previous process without waiting for it to
418         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
419         the process' previous page when reconnecting the it for the forward navigation.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
422
423 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
424
425         Need a way for JavaScript (or bundle) code to participate in undo
426         https://bugs.webkit.org/show_bug.cgi?id=190009
427         <rdar://problem/44807048>
428
429         Reviewed by Ryosuke Niwa.
430
431         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
432         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
433
434         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
435         (WTR::UIScriptController::lastUndoLabel const):
436         (WTR::UIScriptController::firstRedoLabel const):
437         (WTR::UIScriptController::platformUndoManager const):
438         * DumpRenderTree/mac/UIScriptControllerMac.mm:
439         (WTR::UIScriptController::lastUndoLabel const):
440         (WTR::UIScriptController::firstRedoLabel const):
441         (WTR::UIScriptController::platformUndoManager const):
442         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
443         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
444         (WTR::UIScriptController::lastUndoLabel const):
445         (WTR::UIScriptController::firstRedoLabel const):
446         * TestRunnerShared/UIScriptContext/UIScriptController.h:
447         * WebKitTestRunner/UIScriptControllerCocoa.mm:
448         (WTR::UIScriptController::lastUndoLabel const):
449         (WTR::UIScriptController::firstRedoLabel const):
450         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
451         (WTR::UIScriptController::platformUndoManager const):
452         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
453         (WTR::UIScriptController::platformUndoManager const):
454
455 2019-01-25  Zalan Bujtas  <zalan@apple.com>
456
457         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
458         https://bugs.webkit.org/show_bug.cgi?id=193824
459
460         Reviewed by Antti Koivisto.
461
462         * LayoutReloaded/misc/LFC-passing-tests.txt:
463
464 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
465
466         Update macOS JSC bot configurations
467         https://bugs.webkit.org/show_bug.cgi?id=193739
468
469         Reviewed by Alexey Proskuryakov.
470
471         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
473         (BubbleQueueServer): Move JSC EWS to Mojave section.
474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
475         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
476         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
477
478 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
479
480         [Win][WebKitTestRunner] Implement EventSenderProxy
481         https://bugs.webkit.org/show_bug.cgi?id=193755
482
483         Reviewed by Don Olmstead.
484
485         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
486         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
487         (WTR::EventSenderProxy::dispatchMessage):
488         (WTR::EventSenderProxy::EventSenderProxy):
489         (WTR::EventSenderProxy::mouseDown):
490         (WTR::EventSenderProxy::mouseUp):
491         (WTR::EventSenderProxy::mouseMoveTo):
492         (WTR::EventSenderProxy::mouseScrollBy):
493         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
494
495 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
496
497         Unreviewed fix for API test failure after r240437.
498
499         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
500
501         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
502
503 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
504
505         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
506         https://bugs.webkit.org/show_bug.cgi?id=193787
507         <rdar://problem/47497634>
508
509         Reviewed by Alexey Proskuryakov.
510
511         * Scripts/webkitdirs.pm:
512         (iosSimulatorApplicationsPath): Pick from available runtime directories.
513
514 2019-01-24  Truitt Savell  <tsavell@apple.com>
515
516         Unreviewed, rolling out r240446.
517
518         Casued 5 API failures
519
520         Reverted changeset:
521
522         "Activate the WebResourceLoadStatisticsStore in the
523         NetworkProcess and deactivate it in the UIProcess."
524         https://bugs.webkit.org/show_bug.cgi?id=193297
525         https://trac.webkit.org/changeset/240446
526
527 2019-01-24  Zalan Bujtas  <zalan@apple.com>
528
529         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
530         https://bugs.webkit.org/show_bug.cgi?id=193741
531         <rdar://problem/47135030>
532
533         Reviewed by Antti Koivisto and Simon Fraser.
534
535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
536         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
537         (TestWebKitAPI::TEST):
538
539 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
540
541         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
542         https://bugs.webkit.org/show_bug.cgi?id=193297
543         <rdar://problem/47158841>
544
545         Reviewed by Alex Christensen.
546
547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
548         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
549         activating the message used to trigger the callback when it is set.
550
551 2019-01-24  John Wilander  <wilander@apple.com>
552
553         Add Ad Click Attribution as an internal/experimental feature
554         https://bugs.webkit.org/show_bug.cgi?id=193685
555         <rdar://problem/47450399>
556
557         Reviewed by Brent Fulgham.
558
559         Added test option adClickAttributionEnabled.
560
561         * DumpRenderTree/TestOptions.cpp:
562         (TestOptions::TestOptions):
563         * DumpRenderTree/TestOptions.h:
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (setWebPreferencesForTestOptions):
566
567 2019-01-24  Antti Koivisto  <antti@apple.com>
568
569         [PSON] Flash on back navigation on Mac
570         https://bugs.webkit.org/show_bug.cgi?id=193716
571         <rdar://problem/47148458>
572
573         Reviewed by Chris Dumez.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
576
577         Closing of the previous page is delayed so waiting for didFinishNavigation is
578         not sufficient to guarantee we have received all the messages. Wait for them.
579
580 2019-01-24  Chris Dumez  <cdumez@apple.com>
581
582         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
583         https://bugs.webkit.org/show_bug.cgi?id=193761
584         <rdar://problem/47456405>
585
586         Reviewed by Alex Christensen.
587
588         Add API test coverage.
589
590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
591
592 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
593
594         webkitpy: Missing PID in crashlog name should not be fatal
595         https://bugs.webkit.org/show_bug.cgi?id=193771
596
597         If we can't determine the PID of a crashlog, just ignore the crashlog instead
598         of raising an exception.
599
600         Reviewed by Lucas Forschler.
601
602         * Scripts/webkitpy/port/darwin.py:
603         (DarwinPort._merge_crash_logs):
604
605 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
606
607         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
608         https://bugs.webkit.org/show_bug.cgi?id=193746
609
610         Reviewed by Youenn Fablet.
611
612         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
613         so we'd best just not call it.
614
615         * Scripts/webkitpy/w3c/test_exporter.py:
616         (WebPlatformTestExporter.create_branch_with_patch):
617
618 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
619
620         Move FileSystem to WTF
621         https://bugs.webkit.org/show_bug.cgi?id=193602
622
623         Reviewed by Yusuke Suzuki.
624
625         * DumpRenderTree/win/DumpRenderTree.cpp:
626         * TestWebKitAPI/CMakeLists.txt:
627         * TestWebKitAPI/PlatformGTK.cmake:
628         * TestWebKitAPI/PlatformJSCOnly.cmake:
629         * TestWebKitAPI/PlatformPlayStation.cmake:
630         * TestWebKitAPI/PlatformWPE.cmake:
631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
632         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
633         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
634         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
635         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
636         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
637         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
638         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
639         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
640         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
641
642 2019-01-24  Philippe Normand  <pnormand@igalia.com>
643
644         [WPE] Remove hard dependency on subprocess32 for the API tests
645
646         Rubber-stamped by Carlos Garcia Campos.
647
648         * glib/api_test_runner.py:
649         (TestRunner._run_test_qt): Lazily import subprocess32 and check
650         its presence only when running WPEQt tests.
651
652 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         [GLIB] Expose JavaScriptCore options in GLib public API
655         https://bugs.webkit.org/show_bug.cgi?id=188742
656
657         Reviewed by Michael Catanzaro.
658
659         Add a test for the new API.
660
661         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
662         (testsJSCOptions):
663         (main):
664
665 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
666
667         [GTK][WPE] Support JPEG 2000 images
668         https://bugs.webkit.org/show_bug.cgi?id=186272
669
670         Reviewed by Žan Doberšek.
671
672         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
673
674         * gtk/jhbuild.modules:
675         * wpe/jhbuild.modules:
676
677 2019-01-23  David Kilzer  <ddkilzer@apple.com>
678
679         check-webkit-style should warn when using soft-linking macros in a header
680         <https://webkit.org/b/193750>
681
682         Reviewed by Darin Adler.
683
684         * Scripts/webkitpy/style/checkers/cpp.py:
685         (check_language): Add softlink/header check by refactoring the
686         softlink/framework check.
687         (CppChecker): Enable softlink/header check by default.
688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
689         (CppStyleTest.test_softlink_framework): Rename from
690         CppStyleTest.test_softlink() and change test framework name in
691         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
692         files. Set file_name for macros that only appear in headers.
693         (CppStyleTest.test_softlink_header): Add tests for using
694         soft-link macros in headers.
695
696 2019-01-23  Chris Dumez  <cdumez@apple.com>
697
698         Deprecate API to limit the maximum number of WebProcesses
699         https://bugs.webkit.org/show_bug.cgi?id=193725
700         <rdar://problem/47464879>
701
702         Reviewed by Geoff Garen.
703
704         Update existing API tests to stop using deprecated API.
705
706         * MiniBrowser/mac/AppDelegate.m:
707         (defaultConfiguration):
708         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
709         (TestWebKitAPI::TEST):
710         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
711         (TestWebKitAPI::TEST):
712         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
713         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
714         (TEST):
715         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
716         (TEST):
717
718 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
719
720         [ews-app] Rename ews model buildermappings to buildermapping
721         https://bugs.webkit.org/show_bug.cgi?id=193729
722
723         Reviewed by Lucas Forschler.
724
725         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
726         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
727         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
728
729 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
730
731         [ews-app] Rename ews model steps to step
732         https://bugs.webkit.org/show_bug.cgi?id=193697
733
734         Reviewed by Lucas Forschler.
735
736         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
737         (Step): Renamed Steps to Step.
738
739 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
740
741         Clean up IndexedDB files between tests
742         https://bugs.webkit.org/show_bug.cgi?id=192796
743         <rdar://problem/46824999>
744
745         Reviewed by Geoffrey Garen.
746
747         * DumpRenderTree/mac/DumpRenderTree.mm:
748         (runTest):
749         * WebKitTestRunner/TestController.cpp:
750         (WTR::TestController::resetStateToConsistentValues):
751         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
752         (WTR::RemoveAllIndexedDatabasesCallback):
753         (WTR::TestController::ClearIndexedDatabases):
754         * WebKitTestRunner/TestController.h:
755         * WebKitTestRunner/TestInvocation.cpp:
756         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
757
758 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-app] Rename ews model Builds to Build
761         https://bugs.webkit.org/show_bug.cgi?id=193695
762
763         Reviewed by Lucas Forschler.
764
765         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
766         (Build): Renamed Builds to Build.
767
768 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
769
770         webkitpy: Wait longer when launching WebKitTestRunner
771         https://bugs.webkit.org/show_bug.cgi?id=193734
772
773         Reviewed by Aakash Jain.
774
775         * Scripts/webkitpy/port/simulator_process.py:
776         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
777
778 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
781         https://bugs.webkit.org/show_bug.cgi?id=193182
782         <rdar://problem/47452154>
783
784         Reviewed by Tim Horton.
785
786         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
787         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
788         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
789
790         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
791         preventing later tests from recognizing gestures.
792
793         * WebKitTestRunner/ios/TestControllerIOS.mm:
794         (WTR::TestController::platformResetStateToConsistentValues):
795
796         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
797
798 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
799
800         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
801         https://bugs.webkit.org/show_bug.cgi?id=193722
802         <rdar://problem/47481475>
803
804         Reviewed by Lucas Forschler.
805
806         iPhone and iPad ports should both use the iOS config.
807
808         * Scripts/webkitpy/port/ios_simulator.py:
809         (IPhoneSimulatorPort.__init__):
810         (IPadSimulatorPort.__init__):
811
812 2019-01-23  Rob Buis  <rbuis@igalia.com>
813
814         Update MIME type parser
815         https://bugs.webkit.org/show_bug.cgi?id=180526
816
817         Reviewed by Frédéric Wang.
818
819         Add unit tests for both parse modes of ParsedContentType.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
823         (TestWebKitAPI::TEST):
824
825 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
826
827         [ews-app] fetch loop should not stop on network issues
828         https://bugs.webkit.org/show_bug.cgi?id=193666
829
830         Reviewed by Lucas Forschler.
831
832         * BuildSlaveSupport/ews-app/ews/fetcher.py:
833         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
834
835 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
836
837         [iOS] Multiple WKWebViewAutofillTests are flaky failures
838         https://bugs.webkit.org/show_bug.cgi?id=189165
839         <rdar://problem/47433765>
840
841         Reviewed by Tim Horton.
842
843         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
844         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
845         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
846         process in sufficient to ensure that any previous action that blurred the focused element in the web process
847         would make its way to the UI process by the time the layer tree commit is finished.
848
849         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
850         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
851         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
852         will fail because it asks for -_autofillContext too early.
853
854         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
855         is handled in the UI process.
856
857         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
858
859         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
860         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
861         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
862         input session.
863
864         (-[AutofillTestView textInputHasAutofillContext]):
865
866         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
867
868         * TestWebKitAPI/cocoa/TestWKWebView.h:
869         * TestWebKitAPI/cocoa/TestWKWebView.mm:
870         (nextInputSessionChangeCount):
871
872         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
873         This includes changing the focused element from one to another.
874
875         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
876         (-[TestWKWebView didStartFormControlInteraction]):
877         (-[TestWKWebView didEndFormControlInteraction]):
878         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
879
880         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
881         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
882         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
883         that doesn't require an input session to one that doesn't.
884
885 2019-01-22  David Kilzer  <ddkilzer@apple.com>
886
887         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
888         <https://webkit.org/b/193676>
889
890         Reviewed by Alexey Proskuryakov.
891
892         * Scripts/webkitpy/style/checkers/cpp.py:
893         (check_member_initialization_list):
894         - Don't report missing whitespace around colon if the colon at
895           the start of the line is formatted correctly.
896         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
897         (WebKitStyleTest.test_member_initialization_list):
898         - Add a test for a missing permutation of existing tests.
899         - Add a test this false-positive.
900         - Add blank lines between subtests to make them easier to read.
901
902 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
903
904         [build.webkit.org] Unit-test failure after r237113
905         https://bugs.webkit.org/show_bug.cgi?id=193669
906
907         Reviewed by Michael Catanzaro.
908
909         * BuildSlaveSupport/build.webkit.org-config/factories.py:
910         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
911         multiple or zero flags.
912
913 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
914
915         Cache bytecode to disk
916         https://bugs.webkit.org/show_bug.cgi?id=192782
917         <rdar://problem/46084932>
918
919         Reviewed by Keith Miller.
920
921         Add test helper to execute bytecode-cache tests: it executes each test
922         twice, the first with JSC_diskCachePath set to a temporary directory
923         and second with JSC_forceDiskCache=true (in addition to the cache path)
924         to guarantee that only the disk cache is being used and no new
925         UnlinkedCodeBlocks are being created.
926
927         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
928         * Scripts/run-jsc-stress-tests:
929
930 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
931
932         [css-logical] Implement flow-relative margin, padding and border shorthands
933         https://bugs.webkit.org/show_bug.cgi?id=188697
934
935         Reviewed by Simon Fraser and Antti Koivisto.
936
937         * DumpRenderTree/TestOptions.cpp:
938         (TestOptions::TestOptions):
939         * DumpRenderTree/TestOptions.h:
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (setWebPreferencesForTestOptions):
942         Allow tests to enable the CSSLogicalEnabled flag in WK1.
943
944         * Scripts/webkitpy/style/checkers/jsonchecker.py:
945         (JSONCSSPropertiesChecker.check_codegen_properties):
946         Allow CSS property definitions to have a 'runtime-flag' parameter which
947         disables the property when the specified runtime flag is disabled.
948
949 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
950
951         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
952         https://bugs.webkit.org/show_bug.cgi?id=193643
953
954         Reviewed by Michael Catanzaro.
955
956         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
957         * wpe/jhbuild.modules: Ditto.
958
959 2019-01-21  Zalan Bujtas  <zalan@apple.com>
960
961         [LFC][Floats] Take float top position into account when computing containing block height.
962         https://bugs.webkit.org/show_bug.cgi?id=193655
963
964         Reviewed by Antti Koivisto.
965
966         * LayoutReloaded/misc/LFC-passing-tests.txt:
967
968 2019-01-21  David Kilzer  <ddkilzer@apple.com>
969
970         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
971         <https://webkit.org/b/193645>
972         <rdar://problem/47421574>
973
974         Reviewed by Alex Christensen.
975
976         - Now checks for local soft-linking of all frameworks that have
977           their own *SoftLinking.{cpp,h,mm} files.
978         - Changes softlink/uikit warning to softlink/framework.
979
980         * Scripts/webkitpy/style/checkers/cpp.py:
981         (check_language):
982         (CppChecker):
983         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
984         (CppStyleTest):
985
986 2019-01-20  Saam Barati  <sbarati@apple.com>
987
988         Rollout r240210: It broke tests on iOS
989         https://bugs.webkit.org/show_bug.cgi?id=193640
990
991         Unreviewed.
992
993         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
994         * Scripts/run-jsc-stress-tests:
995
996 2019-01-20  chris fleizach  <cfleizach@apple.com>
997
998         AX: Support returning relative frames for accessibility
999         https://bugs.webkit.org/show_bug.cgi?id=193414
1000         <rdar://problem/47268501>
1001
1002         Reviewed by Zalan Bujtas.
1003
1004         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1005         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1006         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1007         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1008         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1009         (WTR::attributesOfElement):
1010         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1011
1012 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1013
1014         Unreviewed, add my new email address
1015
1016         * Scripts/webkitpy/common/config/contributors.json:
1017
1018 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1019
1020         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1021         https://bugs.webkit.org/show_bug.cgi?id=193617
1022
1023         Reviewed by Antti Koivisto.
1024
1025         * LayoutReloaded/misc/LFC-passing-tests.txt:
1026
1027 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1028
1029         Unreviewed, rolling out r240209.
1030
1031         Broke GTK/WPE injected bundle
1032
1033         Reverted changeset:
1034
1035         "AX: Support returning relative frames for accessibility"
1036         https://bugs.webkit.org/show_bug.cgi?id=193414
1037         https://trac.webkit.org/changeset/240209
1038
1039 2019-01-12  Dan Bernstein  <mitz@apple.com>
1040
1041         [Cocoa] Avoid importing directly from subumbrella frameworks
1042         https://bugs.webkit.org/show_bug.cgi?id=186016
1043         <rdar://problem/40591038>
1044
1045         Reviewed by Sam Weinig.
1046
1047         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1048           LaunchServices header.
1049         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1050           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1051         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1052           when using SDKs earlier than 10.13.
1053         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1054           and OTHER_CPLUSPLUSFLAGS.
1055         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1056           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1057         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1058           LaunchServices header.
1059
1060 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1061
1062         Cache bytecode to disk
1063         https://bugs.webkit.org/show_bug.cgi?id=192782
1064         <rdar://problem/46084932>
1065
1066         Reviewed by Keith Miller.
1067
1068         Add test helper to execute bytecode-cache tests: it executes each test
1069         twice, the first with JSC_diskCachePath set to a temporary directory
1070         and second with JSC_forceDiskCache=true (in addition to the cache path)
1071         to guarantee that only the disk cache is being used and no new
1072         UnlinkedCodeBlocks are being created.
1073
1074         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1075         * Scripts/run-jsc-stress-tests:
1076
1077 2019-01-20  chris fleizach  <cfleizach@apple.com>
1078
1079         AX: Support returning relative frames for accessibility
1080         https://bugs.webkit.org/show_bug.cgi?id=193414
1081         <rdar://problem/47268501>
1082
1083         Reviewed by Zalan Bujtas.
1084
1085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1087         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1088         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1089         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1090         (WTR::attributesOfElement):
1091         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1092
1093 2019-01-20  Antoine Quint  <graouts@apple.com>
1094
1095         Add a POINTER_EVENTS feature flag
1096         https://bugs.webkit.org/show_bug.cgi?id=193577
1097         <rdar://problem/47408511>
1098
1099         Unreviewed. Also enable Pointer Events for iosmac.
1100
1101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1102
1103 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1104
1105         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1106         https://bugs.webkit.org/show_bug.cgi?id=193613
1107
1108         Reviewed by Antti Koivisto.
1109
1110         * LayoutReloaded/misc/LFC-passing-tests.txt:
1111
1112 2019-01-19  Antoine Quint  <graouts@apple.com>
1113
1114         Add a POINTER_EVENTS feature flag
1115         https://bugs.webkit.org/show_bug.cgi?id=193577
1116
1117         Reviewed by Dean Jackson.
1118
1119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1120
1121 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1122
1123         Disable the run-jsc-stress-test remote host key check [second round].
1124         https://bugs.webkit.org/show_bug.cgi?id=192988
1125
1126         Reviewed by Dewei Zhu.
1127
1128         * Scripts/run-jsc-stress-tests:
1129
1130 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1131
1132         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1133         https://bugs.webkit.org/show_bug.cgi?id=193597
1134
1135         Reviewed by Lucas Forschler.
1136
1137         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1138
1139 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1140
1141         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1142         https://bugs.webkit.org/show_bug.cgi?id=193595
1143
1144         Reviewed by Lucas Forschler.
1145
1146         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1147         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1148         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1149
1150 2019-01-18  Chris Dumez  <cdumez@apple.com>
1151
1152         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1153         https://bugs.webkit.org/show_bug.cgi?id=193588
1154         <rdar://problem/47131566>
1155
1156         Reviewed by Alex Christensen.
1157
1158         Add layout test coverage.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1161
1162 2019-01-18  Jer Noble  <jer.noble@apple.com>
1163
1164         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1165         https://bugs.webkit.org/show_bug.cgi?id=189553
1166
1167         Reviewed by Tim Horton.
1168
1169         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1170
1171         * ContentExtensionTester/Configurations/Base.xcconfig:
1172         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1173         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1174         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1175         * ImageDiff/cg/Configurations/Base.xcconfig:
1176         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1177         * MiniBrowser/Configurations/Base.xcconfig:
1178         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1179         * MobileMiniBrowser/Configurations/Base.xcconfig:
1180         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1181         * Scripts/webkitpy/style/checker.py:
1182         (_all_categories):
1183         (FileType):
1184         (CheckerDispatcher._file_type):
1185         (CheckerDispatcher._create_checker):
1186         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1187         (SDKVariantChecker):
1188         (SDKVariantChecker.__init__):
1189         (SDKVariantChecker.check):
1190         * TestWebKitAPI/Configurations/Base.xcconfig:
1191         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1192         * WebEditingTester/Configurations/Base.xcconfig:
1193         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1194         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1195         * WebKitTestRunner/Configurations/Base.xcconfig:
1196         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1197         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1198         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1199
1200 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1201
1202         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1203         <https://webkit.org/b/193568>
1204         <rdar://problem/47381130>
1205
1206         Reviewed by Alex Christensen.
1207
1208         Make sure no one re-introduces UIKit soft-linking by adding a
1209         style rule.
1210
1211         * Scripts/webkitpy/style/checkers/cpp.py:
1212         (check_language): Add softlink/uikit check.
1213         (CppChecker): Enable softlink/uikit check.
1214         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1215         (CppStyleTest): Add test for softlink/uikit.
1216
1217 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1218
1219         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1220         https://bugs.webkit.org/show_bug.cgi?id=193584
1221
1222         Change "-dev" to "-devel".
1223
1224         Reviewed by Michael Catanzaro.
1225
1226         * gtk/install-dependencies:
1227
1228 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1229
1230         webkitpy: Add iPhone and iPad ports
1231         https://bugs.webkit.org/show_bug.cgi?id=193537
1232         <rdar://problem/47353390>
1233
1234         Reviewed by Lucas Forschler.
1235
1236         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1237         ports. Note that this separation is optional, the --ios-simulator command remains.
1238
1239         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1240         (RunTest.test_device_type_test_division): Drive-by fix.
1241         (RunTest.test_device_type_specific_listing): Ditto.
1242         (RunTest.test_ipad_test_division):
1243         (RunTest):
1244         (RunTest.test_ipad_listing):
1245         * Scripts/webkitpy/port/factory.py:
1246         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1247         (PortFactory):
1248         * Scripts/webkitpy/port/ios_simulator.py:
1249         (IPhoneSimulatorPort):
1250         (IPadSimulatorPort):
1251
1252 2019-01-18  Chris Dumez  <cdumez@apple.com>
1253
1254         Regression(PSON) Scroll position is not always restored properly when navigating back
1255         https://bugs.webkit.org/show_bug.cgi?id=193578
1256         <rdar://problem/47386331>
1257
1258         Reviewed by Tim Horton.
1259
1260         Add API test coverage.
1261
1262         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1263
1264 2019-01-18  Youenn Fablet  <youenn@apple.com>
1265
1266         Add a new SPI to request for cache storage quota increase
1267         https://bugs.webkit.org/show_bug.cgi?id=193323
1268
1269         Reviewed by Alex Christensen.
1270
1271         Implement WebsiteDataStore quota delegate to handle quota requests.
1272         By default, do not update quota.
1273         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1274
1275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1277         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1279         * WebKitTestRunner/TestController.cpp:
1280         (WTR::TestController::allowCacheStorageQuotaIncrease):
1281         * WebKitTestRunner/TestController.h:
1282         * WebKitTestRunner/TestInvocation.cpp:
1283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1284         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1285         (-[CacheStorageQuotaManager init]):
1286         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1287         (WTR::initializeWebViewConfiguration):
1288         (WTR::TestController::cocoaResetStateToConsistentValues):
1289         (WTR::TestController::allowCacheStorageQuotaIncrease):
1290
1291 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1292
1293         [ews-build] Pass owner to the triggered builds
1294         https://bugs.webkit.org/show_bug.cgi?id=193574
1295
1296         Reviewed by Lucas Forschler.
1297
1298         * BuildSlaveSupport/ews-build/factories.py:
1299         (BuildFactory.propertiesToPassToTriggers):
1300
1301 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1302
1303         [ews-app] Send patch author as a build property
1304         https://bugs.webkit.org/show_bug.cgi?id=193560
1305
1306         Reviewed by Lucas Forschler.
1307
1308         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1309         (BugzillaPatchFetcher.fetch):
1310
1311 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1312
1313         webkitpy: Implement device type specific expected results (Follow-up fix)
1314         https://bugs.webkit.org/show_bug.cgi?id=192162
1315         <rdar://problem/46345449>
1316
1317         Unreviewed infrastructure fix.
1318
1319         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1320         (Manager.run): Don't boot a device if no tests are available to run on it.
1321
1322 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1323
1324         webkitpy: Implement device type specific expected results (Follow-up fix)
1325         https://bugs.webkit.org/show_bug.cgi?id=192162
1326         <rdar://problem/46345449>
1327
1328         Unreviewed infrastructure fix.
1329
1330         * Scripts/webkitpy/api_tests/manager.py:
1331         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1332
1333 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1334
1335         webkitpy: Implement device type specific expected results (Part 2)
1336         https://bugs.webkit.org/show_bug.cgi?id=192162
1337         <rdar://problem/46345449>
1338
1339         Rubber-stamped by Aakash Jain.
1340
1341         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1342         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1343         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1344
1345         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1346         (LayoutTestFinder.find_tests): Pass device_type through.
1347         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1348         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1349         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1350         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1351         (Manager._collect_tests): Pass device type to test finder.
1352         (Manager._needs_web_platform_test):
1353         (Manager._prepare_lists): Index _expectations by device type.
1354         (Manager._test_input_for_file):
1355         (Manager._test_is_slow): Ditto.
1356         (Manager._test_should_dump_jsconsolelog_in_stderr):
1357         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1358         (Manager._get_test_inputs):
1359         (Manager._update_worker_count):
1360         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1361         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1362         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1363         the one which runs the test.
1364         (Manager._run_test_subset):
1365         (Manager._run_tests): Index _expectations by current_device_type.
1366         (Manager._print_expectation_line_for_test): Ditto.
1367         (Manager._print_expectations_for_subset): Ditto.
1368         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1369         Unlike run, this function will behave the same regardless of what devices are available.
1370         (Manager._custom_device_for_test): Deleted.
1371         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1372         (ManagerTest.test_uses_custom_device): Deleted.
1373         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1374         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1375         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1376         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1377         all of the expectations.
1378         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1379         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1380         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1381         (TestExpectations.__init__): Allow device_type to be passed through.
1382         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1383         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1384         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1385         (summarize_results):
1386         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1387         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1388         a test ran with, one must check all expectations to find the first non-skip expectation.
1389         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1390         (RunTest.test_device_type_test_division):
1391         (RunTest):
1392         (RunTest.test_device_type_specific_listing):
1393         * Scripts/webkitpy/port/base.py:
1394         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1395         (Port.supported_device_types): The result of this function will change based on what devices are available.
1396         * Scripts/webkitpy/port/device_port.py:
1397         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1398         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1399         can be used.
1400         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1401         any, or the DEFAULT_DEVICE_TYPES of the port.
1402         * Scripts/webkitpy/port/ios.py:
1403         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1404         * Scripts/webkitpy/port/ios_simulator.py:
1405         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1406         * Scripts/webkitpy/port/watch.py:
1407         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1408         * Scripts/webkitpy/port/watch_simulator.py:
1409         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1410         * Scripts/webkitpy/xcode/device_type.py:
1411         (DeviceType):
1412         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1413
1414 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1415
1416         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1417         https://bugs.webkit.org/show_bug.cgi?id=193575
1418
1419         Reviewed by Michael Catanzaro.
1420
1421         Allow the script to run without explicit port argument because
1422         it's specific to the WPE port anyway.
1423
1424         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1425         and simplify the rest of the code accordingly.
1426
1427 2019-01-18  Charlie Turner  <cturner@igalia.com>
1428
1429         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1430         https://bugs.webkit.org/show_bug.cgi?id=192229
1431
1432         Reviewed by Xabier Rodriguez-Calvar.
1433
1434         * MiniBrowser/wpe/main.cpp:
1435         (main): Enable encrypted-media by default.
1436
1437 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1438
1439         [Flatpak] Missing KeyboardInterrupt exception handler
1440         https://bugs.webkit.org/show_bug.cgi?id=193570
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         * flatpak/flatpakutils.py:
1445         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1446
1447 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1448
1449         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1450         https://bugs.webkit.org/show_bug.cgi?id=193564
1451
1452         Reviewed by Antti Koivisto.
1453
1454         * LayoutReloaded/misc/LFC-passing-tests.txt:
1455
1456 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1457
1458         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1459         https://bugs.webkit.org/show_bug.cgi?id=193562
1460
1461         Reviewed by Antti Koivisto.
1462
1463         * LayoutReloaded/misc/LFC-passing-tests.txt:
1464
1465 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1466
1467         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1468         https://bugs.webkit.org/show_bug.cgi?id=193555
1469
1470         Reviewed by Antti Koivisto.
1471
1472         * LayoutReloaded/misc/LFC-passing-tests.txt:
1473
1474 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1475
1476         [WPE] Add Qt extension
1477         https://bugs.webkit.org/show_bug.cgi?id=191464
1478
1479         Reviewed by Carlos Garcia Campos.
1480
1481         MiniBrowser and API tests for the WPE Qt API. To run the
1482         MiniBrowser a new script is introduced. Example invocation:
1483
1484         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1485
1486         Also note-worthy is the introduction of the python2-subprocess32
1487         dependency to run the GLib API tests.
1488
1489         * MiniBrowser/wpe/CMakeLists.txt:
1490         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1491         * MiniBrowser/wpe/qt/main.cpp: Added.
1492         (main):
1493         * MiniBrowser/wpe/qt/main.qml: Added.
1494         * MiniBrowser/wpe/qt/qml.qrc: Added.
1495         * Scripts/run-gtk-tests:
1496         (GtkTestRunner.is_google_test):
1497         (GtkTestRunner):
1498         (GtkTestRunner.is_qt_test):
1499         * Scripts/run-qt-wpe-minibrowser: Added.
1500         * Scripts/run-wpe-tests:
1501         (WPETestRunner):
1502         (WPETestRunner.is_google_test):
1503         (WPETestRunner.is_qt_test):
1504         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1505         (TestLoad::main):
1506         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1507         (TestLoadHtml::main):
1508         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1509         (TestLoadRequest::main):
1510         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1511         (TestRunJavaScript::main):
1512         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1513         (waitForSignal):
1514         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1515         (LoadSpy::LoadSpy):
1516         (LoadSpy::~LoadSpy):
1517         (LoadSpy::onLoadingChanged):
1518         (LoadStartedCatcher::LoadStartedCatcher):
1519         (LoadStartedCatcher::~LoadStartedCatcher):
1520         (LoadStartedCatcher::onLoadingChanged):
1521         (waitForLoadSucceeded):
1522         (waitForLoadFailed):
1523         * TestWebKitAPI/glib/CMakeLists.txt:
1524         * flatpak/flatpakutils.py:
1525         (WebkitFlatpak.load_from_args):
1526         (WebkitFlatpak.__init__):
1527         (WebkitFlatpak.clean_args):
1528         (WebkitFlatpak.run_in_sandbox):
1529         * flatpak/org.webkit.CommonModules.yaml:
1530         * flatpak/org.webkit.WPE.yaml:
1531         * flatpak/org.webkit.WPEModules.yaml:
1532         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1533         * flatpak/org.webkit.WebKit.yaml:
1534         * glib/api_test_runner.py:
1535         (TestRunner._run_test_qt):
1536         (TestRunner.is_qt_test):
1537         (TestRunner._run_test):
1538
1539 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1540
1541         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1542         https://bugs.webkit.org/show_bug.cgi?id=193494
1543         <rdar://problem/46859627>
1544
1545         Reviewed by Simon Fraser and Tim Horton.
1546
1547         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1548         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1549
1550         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1551         (WTR::UIScriptController::contentOffsetX const):
1552         (WTR::UIScriptController::contentOffsetY const):
1553         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1554         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1555         (WTR::UIScriptController::contentOffsetX const):
1556         (WTR::UIScriptController::contentOffsetY const):
1557         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1558
1559         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562         (WTR::updateTestOptionsFromTestHeader):
1563         * WebKitTestRunner/TestOptions.h:
1564         (WTR::TestOptions::hasSameInitializationOptions const):
1565         * WebKitTestRunner/ios/TestControllerIOS.mm:
1566         (WTR::TestController::platformResetStateToConsistentValues):
1567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1568         (WTR::UIScriptController::contentOffsetX const):
1569         (WTR::UIScriptController::contentOffsetY const):
1570
1571 2019-01-17  Truitt Savell  <tsavell@apple.com>
1572
1573         Unreviewed, rolling out r240124.
1574
1575         This commit broke an internal build.
1576
1577         Reverted changeset:
1578
1579         "SDK_VARIANT build destinations should be separate from non-
1580         SDK_VARIANT builds"
1581         https://bugs.webkit.org/show_bug.cgi?id=189553
1582         https://trac.webkit.org/changeset/240124
1583
1584 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1585
1586         Fix string concatenation API test after r239920
1587         https://bugs.webkit.org/show_bug.cgi?id=193551
1588         <rdar://problem/47359304>
1589
1590         Reviewed by Youenn Fablet.
1591
1592         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1593         (TestWebKitAPI::TEST):
1594         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1595         in WebKit's build configuration like it apparently is on Linux.
1596
1597 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1598
1599         [ews-build] validate-patch should handle the case when bug_id is None
1600         https://bugs.webkit.org/show_bug.cgi?id=193547
1601
1602         Reviewed by Lucas Forschler.
1603
1604         * BuildSlaveSupport/ews-build/steps.py:
1605         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1606         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1607
1608 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1609
1610         [ews-build] Add patch author information in build
1611         https://bugs.webkit.org/show_bug.cgi?id=193465
1612
1613         Reviewed by Lucas Forschler.
1614
1615         * BuildSlaveSupport/ews-build/steps.py:
1616         (ValidatePatch._is_patch_obsolete):
1617
1618 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1619
1620         [ews-build] Pass bug_id to the triggered builds
1621         https://bugs.webkit.org/show_bug.cgi?id=193548
1622
1623         Reviewed by Lucas Forschler.
1624
1625         * BuildSlaveSupport/ews-build/factories.py:
1626         (BuildFactory.propertiesToPassToTriggers):
1627
1628 2019-01-17  Jer Noble  <jer.noble@apple.com>
1629
1630         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1631         https://bugs.webkit.org/show_bug.cgi?id=189553
1632
1633         Reviewed by Tim Horton.
1634
1635         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1636
1637         * ContentExtensionTester/Configurations/Base.xcconfig:
1638         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1639         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1640         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1641         * ImageDiff/cg/Configurations/Base.xcconfig:
1642         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1643         * MiniBrowser/Configurations/Base.xcconfig:
1644         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1645         * MobileMiniBrowser/Configurations/Base.xcconfig:
1646         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1647         * Scripts/webkitpy/style/checker.py:
1648         (_all_categories):
1649         (FileType):
1650         (CheckerDispatcher._file_type):
1651         (CheckerDispatcher._create_checker):
1652         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1653         (SDKVariantChecker):
1654         (SDKVariantChecker.__init__):
1655         (SDKVariantChecker.check):
1656         * TestWebKitAPI/Configurations/Base.xcconfig:
1657         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1658         * WebEditingTester/Configurations/Base.xcconfig:
1659         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1660         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1661         * WebKitTestRunner/Configurations/Base.xcconfig:
1662         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1663         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1664         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1665
1666 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1667
1668         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1669         https://bugs.webkit.org/show_bug.cgi?id=193534
1670
1671         Reviewed by Antti Koivisto.
1672
1673         * LayoutReloaded/misc/LFC-passing-tests.txt:
1674
1675 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1676
1677         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1678         https://bugs.webkit.org/show_bug.cgi?id=193528
1679
1680         Reviewed by Antti Koivisto.
1681
1682         * LayoutReloaded/misc/LFC-passing-tests.txt:
1683
1684 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1685
1686         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1687         https://bugs.webkit.org/show_bug.cgi?id=193520
1688
1689         Reviewed by Antti Koivisto.
1690
1691         * LayoutReloaded/misc/LFC-passing-tests.txt:
1692
1693 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1694
1695         [ews-build] unapply-patch step should not update source
1696         https://bugs.webkit.org/show_bug.cgi?id=193234
1697
1698         Reviewed by Lucas Forschler.
1699
1700         * BuildSlaveSupport/ews-build/steps.py:
1701         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1702         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1703
1704 2019-01-16  Youenn Fablet  <youenn@apple.com>
1705
1706         Add a new SPI for controlling getUserMedia
1707         https://bugs.webkit.org/show_bug.cgi?id=192793
1708
1709         Reviewed by Eric Carlson.
1710
1711         * MiniBrowser/mac/WK2BrowserWindowController.m:
1712         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1713         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1714         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1715         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1716         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1717         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1718         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1719         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1720         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1721         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1722         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1723         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1724         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1725         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1726
1727 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1728
1729         [LFC][BFC] Inflow non-replaced used width should not be negative.
1730         https://bugs.webkit.org/show_bug.cgi?id=193495
1731
1732         Reviewed by Antti Koivisto.
1733
1734         * LayoutReloaded/misc/LFC-passing-tests.txt:
1735
1736 2019-01-16  Chris Dumez  <cdumez@apple.com>
1737
1738         Regression(PSON) View becomes blank after click a cross-site download link
1739         https://bugs.webkit.org/show_bug.cgi?id=193361
1740         <rdar://problem/47099573>
1741
1742         Reviewed by Geoffrey Garen.
1743
1744         Add API test coverage.
1745
1746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1747         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1748
1749 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1750
1751         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1752         https://bugs.webkit.org/show_bug.cgi?id=193470
1753
1754         Reviewed by Antti Koivisto.
1755
1756         * LayoutReloaded/misc/LFC-passing-tests.txt:
1757
1758 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1759
1760         [LFC] Adjust margin box verification.
1761         https://bugs.webkit.org/show_bug.cgi?id=193482
1762
1763         Reviewed by Antti Koivisto.
1764
1765         * LayoutReloaded/misc/LFC-passing-tests.txt:
1766
1767 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1768
1769         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1770         https://bugs.webkit.org/show_bug.cgi?id=193451
1771
1772         Reviewed by Geoffrey Garen.
1773
1774         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1775         (TEST):
1776         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1777         (runWebsiteDataStoreCustomPaths):
1778
1779 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1780
1781         webkitpy: Support boolean simctl isAvailable
1782         https://bugs.webkit.org/show_bug.cgi?id=193472
1783         <rdar://problem/47296150>
1784
1785         Reviewed by Ryosuke Niwa.
1786
1787         * Scripts/webkitpy/xcode/simulated_device.py:
1788         (SimulatedDeviceManager._create_runtimes):
1789         (SimulatedDeviceManager._create_device_with_runtime):
1790
1791 2019-01-15  Chris Dumez  <cdumez@apple.com>
1792
1793         Unreviewed, rolling out r239993, r239995, r239997, and
1794         r239999.
1795
1796         Caused assertions under
1797         ViewGestureController::disconnectFromProcess()
1798
1799         Reverted changesets:
1800
1801         "Regression(PSON) View becomes blank after click a cross-site
1802         download link"
1803         https://bugs.webkit.org/show_bug.cgi?id=193361
1804         https://trac.webkit.org/changeset/239993
1805
1806         "Unreviewed iOS build fix after r239993."
1807         https://trac.webkit.org/changeset/239995
1808
1809         "Fix iOS build after r239993"
1810         https://bugs.webkit.org/show_bug.cgi?id=193361
1811         https://trac.webkit.org/changeset/239997
1812
1813         "Unreviewed, revert part of r239997 as it is not needed to fix
1814         the build."
1815         https://trac.webkit.org/changeset/239999
1816
1817 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1818
1819         Cannot tab out of WKWebView on macOS
1820         https://bugs.webkit.org/show_bug.cgi?id=161448
1821         <rdar://problem/28100085>
1822
1823         Reviewed by Dean Jackson.
1824
1825         Add a test that tabbing into and out of WKWebView works correctly.
1826
1827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1828         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1829         (WebKit2_CommandBackForwardTest::SetUp):
1830         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1831         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1832         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1833         (-[FocusableView canBecomeKeyView]):
1834         (TEST):
1835         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1836         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1837         (-[OffscreenWindow initWithSize:]):
1838         (-[OffscreenWindow isKeyWindow]):
1839         (-[OffscreenWindow isVisible]):
1840         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1841         (TestWebKitAPI::PlatformWebView::initialize):
1842         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1843         (-[ActiveOffscreenWindow isVisible]): Deleted.
1844         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1845
1846 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1847
1848         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1849         https://bugs.webkit.org/show_bug.cgi?id=193459
1850
1851         Reviewed by Mark Lam.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1854         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1855
1856 2019-01-15  Chris Dumez  <cdumez@apple.com>
1857
1858         Regression(PSON) View becomes blank after click a cross-site download link
1859         https://bugs.webkit.org/show_bug.cgi?id=193361
1860         <rdar://problem/47099573>
1861
1862         Reviewed by Geoff Garen.
1863
1864         Add API test coverage.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1867         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1868
1869 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1870
1871         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1872         https://bugs.webkit.org/show_bug.cgi?id=193448
1873
1874         Reviewed by Antti Koivisto.
1875
1876         * LayoutReloaded/misc/LFC-passing-tests.txt:
1877
1878 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1879
1880         webkitpy: Implement device type specific expected results (Part 1)
1881         https://bugs.webkit.org/show_bug.cgi?id=192162
1882
1883         Reviewed by Lucas Forschler.
1884
1885         Device type specific expected results covers two related ideas. The first (covered by this change)
1886         is where to search for -expected.* files. The second is which tests to run based on the
1887         TestExpectations.txt file.
1888
1889         After this change, the baseline search path will be determined by the type of device running a
1890         test. Device type will be passed into any function which picks a file based on the baseline search
1891         path.
1892
1893         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1894         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1896         (Manager.run): Print baseline search path for each round of devices.
1897         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1898         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1899         (SingleTestRunner._expected_driver_output): Ditto.
1900         (SingleTestRunner._driver_input): Ditto.
1901         * Scripts/webkitpy/layout_tests/views/printing.py:
1902         (Printer.print_config): Move printing of baseline search path to a separate function.
1903         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1904         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1905         (Testprinter.test_print_config):
1906         (Testprinter.test_print_baseline_search_path):
1907         * Scripts/webkitpy/port/base.py:
1908         (Port.baseline_search_path): Pass device_type through.
1909         (Port._expected_baselines_for_suffixes): Ditto.
1910         (Port.expected_baselines): Ditto.
1911         (Port.expected_filename): Ditto.
1912         (Port.expected_checksum): Ditto.
1913         (Port.expected_image): Ditto.
1914         (Port.expected_audio): Ditto.
1915         (Port.expected_text): Ditto.
1916         (Port.reference_files): Ditto.
1917         (Port.tests): Ditto.
1918         (Port._expanded_paths): Ditto.
1919         (Port.skipped_layout_tests): Ditto.
1920         (Port.expectations_dict): Ditto.
1921         (Port._port_specific_expectations_files): Ditto.
1922         (Port.expectations_files): Ditto.
1923         (Port.test_search_path): Ditto.
1924         (Port._tests_for_other_platforms): Ditto.
1925         * Scripts/webkitpy/port/base_unittest.py:
1926         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1927         (PortTest.test_nonexistant_expectations): Ditto.
1928         (test_ref_tests_platform_directory): Ditto.
1929         * Scripts/webkitpy/port/darwin.py:
1930         (DarwinPort._port_specific_expectations_files): Accept device_type.
1931         * Scripts/webkitpy/port/driver.py:
1932         (DriverProxy):
1933         (DriverProxy.host): Expose _target_host for device_type information.
1934         * Scripts/webkitpy/port/gtk.py:
1935         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1936         * Scripts/webkitpy/port/ios.py:
1937         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1938         * Scripts/webkitpy/port/mac.py:
1939         (MacPort. default_baseline_search_path): Ditto.
1940         * Scripts/webkitpy/port/port_testcase.py:
1941         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1942         * Scripts/webkitpy/port/test.py:
1943         * Scripts/webkitpy/port/watch.py:
1944         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1945         * Scripts/webkitpy/port/win.py:
1946         (WinPort.test_search_path): Accept, but do not use, device_type.
1947         * Scripts/webkitpy/port/wpe.py:
1948         (WPEPort._port_specific_expectations_files): Ditto.
1949         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1950         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1951
1952 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1953
1954         [LFC] Use the containing block's padding box to position out-of-flow elements.
1955         https://bugs.webkit.org/show_bug.cgi?id=193431
1956
1957         Reviewed by Antti Koivisto.
1958
1959         * LayoutReloaded/misc/LFC-passing-tests.txt:
1960
1961 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1962
1963         Move a test implementation file that got misplaced in the Xcode project
1964
1965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1966
1967 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1968
1969         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1970         r239913, and r239914.
1971         https://bugs.webkit.org/show_bug.cgi?id=193407
1972
1973         These revisions caused an internal failure (Requested by
1974         Truitt on #webkit).
1975
1976         Reverted changesets:
1977
1978         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1979         https://bugs.webkit.org/show_bug.cgi?id=186016
1980         https://trac.webkit.org/changeset/239901
1981
1982         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1983         https://trac.webkit.org/changeset/239909
1984
1985         "Tried to fix the build."
1986         https://trac.webkit.org/changeset/239910
1987
1988         "Fixed iOS builds after r239910."
1989         https://trac.webkit.org/changeset/239912
1990
1991         "More build fixing."
1992         https://trac.webkit.org/changeset/239913
1993
1994         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1995         https://trac.webkit.org/changeset/239914
1996
1997 2019-01-14  Mark Lam  <mark.lam@apple.com>
1998
1999         Re-enable ability to build --cloop builds.
2000         https://bugs.webkit.org/show_bug.cgi?id=192955
2001         <rdar://problem/46882363>
2002
2003         Reviewed by Saam barati and Keith Miller.
2004
2005         The --cloop build option was being ignored this whole time since r236381.
2006         This patch makes it possible to build CLoop builds again.
2007
2008         * Scripts/build-jsc:
2009         * Scripts/webkitperl/FeatureList.pm:
2010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2011
2012 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2013
2014         webkitpy: Expose device_type from host-like objects
2015         https://bugs.webkit.org/show_bug.cgi?id=193406
2016         <rdar://problem/47262305>
2017
2018         Reviewed by Lucas Forschler.
2019
2020         Devices should expose device_type. As a result, all host objects should
2021         provide a device_type property, even if they do not yet define a device_type.
2022
2023         * Scripts/webkitpy/common/system/systemhost.py:
2024         (SystemHost):
2025         (SystemHost.device_type):
2026         * Scripts/webkitpy/common/system/systemhost_mock.py:
2027         (MockSystemHost):
2028         (MockSystemHost.device_type):
2029         * Scripts/webkitpy/port/device.py:
2030         (Device):
2031         (Device.device_type):
2032         * Scripts/webkitpy/xcode/simulated_device.py:
2033         (SimulatedDeviceManager._find_exisiting_device_for_request):
2034         (SimulatedDeviceManager._disambiguate_device_type):
2035         (SimulatedDeviceManager._does_fulfill_request):
2036         (SimulatedDeviceManager.device_count_for_type):
2037         (SimulatedDeviceManager.initialize_devices):
2038         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2039         (test_available_devices):
2040         (test_swapping_devices):
2041
2042 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2043
2044         webkitpy: Support alternate simctl device list output (Follow-up fix)
2045         https://bugs.webkit.org/show_bug.cgi?id=193362
2046         <rdar://problem/47122965>
2047
2048         Rubber-stamped by Lucas Forschler.
2049
2050         * Scripts/webkitpy/xcode/simulated_device.py:
2051         (SimulatedDeviceManager.populate_available_devices):
2052
2053 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2054
2055         [iOS] Expose SPI to access the current sentence boundary and selection state
2056         https://bugs.webkit.org/show_bug.cgi?id=193398
2057         <rdar://problem/45893108>
2058
2059         Reviewed by Dean Jackson.
2060
2061         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2062         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2063         expected.
2064
2065         * TestWebKitAPI/EditingTestHarness.h:
2066         * TestWebKitAPI/EditingTestHarness.mm:
2067         (-[EditingTestHarness moveBackward]):
2068         (-[EditingTestHarness moveForward]):
2069         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2070
2071         Add a couple of new helper methods on EditingTestHarness.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2074         (-[SelectionChangeObserver initWithWebView:]):
2075         (-[SelectionChangeObserver webView]):
2076         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2077         (-[SelectionChangeObserver currentSelectionAttributes]):
2078
2079 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2080
2081         [LFC][BFC] Add basic box-sizing support.
2082         https://bugs.webkit.org/show_bug.cgi?id=193392
2083
2084         Reviewed by Antti Koivisto.
2085
2086         * LayoutReloaded/misc/LFC-passing-tests.txt:
2087
2088 2019-01-14  Charlie Turner  <cturner@igalia.com>
2089
2090         [WPE] API test gardening
2091         https://bugs.webkit.org/show_bug.cgi?id=193319
2092
2093         Reviewed by Michael Catanzaro.
2094
2095         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2096         passing tests.
2097
2098 2019-01-14  Charlie Turner  <cturner@igalia.com>
2099
2100         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2101         https://bugs.webkit.org/show_bug.cgi?id=192977
2102
2103         Reviewed by Carlos Garcia Campos.
2104
2105         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2106         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2107         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2108         (TestWebKitAPI::GStreamerTest::SetUp):
2109         (TestWebKitAPI::GStreamerTest::TearDown):
2110         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2111         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2112         (TestWebKitAPI::TEST_F):
2113
2114 2019-01-14  Charlie Turner  <cturner@igalia.com>
2115
2116         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2117         https://bugs.webkit.org/show_bug.cgi?id=193332
2118
2119         Reviewed by Michael Catanzaro.
2120
2121         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2122         defined as a char16_t, which changed in ICU 59, the
2123         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2124         unsigned short. This test is relying on the behaviour that
2125         UChar=unsigned short, which doesn't hold across platforms and ICU
2126         library versions. The full fix would be a special syntax for
2127         literal characters so that these ambiguities do not arise. That
2128         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2129         (TestWebKitAPI::TEST):
2130
2131 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2132
2133         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2134
2135         * Scripts/make-dist:
2136         (Distcheck.configure):
2137
2138 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Update macOS queue configurations
2141         https://bugs.webkit.org/show_bug.cgi?id=193365
2142         <rdar://problem/47221073>
2143
2144         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2145
2146         * BuildSlaveSupport/ews-build/config.json:
2147
2148 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2149
2150         [LFC] Adjust assert for statically positioned fixed elements
2151         https://bugs.webkit.org/show_bug.cgi?id=193385
2152
2153         Reviewed by Antti Koivisto.
2154
2155         * LayoutReloaded/misc/LFC-passing-tests.txt:
2156
2157 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2158
2159         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2160         https://bugs.webkit.org/show_bug.cgi?id=193387
2161
2162         Reviewed by Carlos Garcia Campos.
2163
2164         * MiniBrowser/wpe/main.cpp:
2165         (main):
2166
2167 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2168
2169         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2170         https://bugs.webkit.org/show_bug.cgi?id=191655
2171         rdar://problem/46074680
2172
2173         Reviewed by Megan Gardner.
2174
2175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2176         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2177
2178 2019-01-12  Dan Bernstein  <mitz@apple.com>
2179
2180         [Cocoa] Avoid importing directly from subumbrella frameworks
2181         https://bugs.webkit.org/show_bug.cgi?id=186016
2182         <rdar://problem/40591038>
2183
2184         Reviewed by Sam Weinig.
2185
2186         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2187           LaunchServices header.
2188         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2189           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2190         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2191           when using SDKs earlier than 10.13.
2192         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2193           and OTHER_CPLUSPLUSFLAGS.
2194         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2195           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2196         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2197           LaunchServices header.
2198
2199 2019-01-11  John Wilander  <wilander@apple.com>
2200
2201         Compile out Web API Statistics Collection
2202         https://bugs.webkit.org/show_bug.cgi?id=193370
2203         <rdar://problem/45388584>
2204
2205         Reviewed by Brent Fulgham.
2206
2207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2208             Defined ENABLE_WEB_API_STATISTICS, off by default.
2209
2210 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2211
2212         [WPE] Add gtk-doc
2213         https://bugs.webkit.org/show_bug.cgi?id=178900
2214
2215         Reviewed by Michael Catanzaro.
2216
2217         Add Tools/gtkdoc to manifest.txt.in files.
2218         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2219
2220         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2221         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2222
2223 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2224
2225         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2226         https://bugs.webkit.org/show_bug.cgi?id=193364
2227         <rdar://problem/47214117>
2228
2229         Reviewed by Tim Horton.
2230
2231         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2232         precise, whereas dragging near the middle of the textarea does.
2233
2234         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2235         (TestWebKitAPI::TEST):
2236
2237 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2238
2239         webkitpy: Support alternate simctl device list output
2240         https://bugs.webkit.org/show_bug.cgi?id=193362
2241         <rdar://problem/47122965>
2242
2243         Reviewed by Lucas Forschler.
2244
2245         * Scripts/webkitpy/xcode/simulated_device.py:
2246         (SimulatedDeviceManager.populate_available_devices):
2247
2248 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2249
2250         [ews-build] Update macOS queue configurations
2251         https://bugs.webkit.org/show_bug.cgi?id=193365
2252
2253         Reviewed by Lucas Forschler.
2254
2255         * BuildSlaveSupport/ews-build/config.json:
2256
2257 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2258
2259         webkitpy: Incorporate device type into baseline search path
2260         https://bugs.webkit.org/show_bug.cgi?id=193356
2261         <rdar://problem/47215515>
2262
2263         Reviewed by Lucas Forschler.
2264
2265         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2266
2267         * Scripts/webkitpy/port/base.py:
2268         (Port.default_baseline_search_path): Allow device type to be passed in.
2269         * Scripts/webkitpy/port/gtk.py:
2270         (GtkPort.default_baseline_search_path): Ignore device type.
2271         * Scripts/webkitpy/port/ios.py:
2272         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2273         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2274         * Scripts/webkitpy/port/ios_device_unittest.py:
2275         (IOSDeviceTest):
2276         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2277         (IOSSimulatorTest):
2278         * Scripts/webkitpy/port/mac.py:
2279         (MacPort.default_baseline_search_path): Ignore device type.
2280         * Scripts/webkitpy/port/watch.py:
2281         (WatchPort.default_baseline_search_path): Ditto.
2282         * Scripts/webkitpy/port/win.py:
2283         (WinPort.default_baseline_search_path): Ditto.
2284         (WinCairoPort.default_baseline_search_path): Ditto.
2285         * Scripts/webkitpy/port/wpe.py:
2286         (WPEPort.default_baseline_search_path): Ditto.
2287
2288 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2289
2290         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2291         https://bugs.webkit.org/show_bug.cgi?id=193352
2292         <rdar://problem/47210736>
2293
2294         Reviewed by Lucas Forschler.
2295
2296         * Scripts/webkitpy/layout_tests/views/printing.py:
2297         (Printer.print_config): Print list on only baseline search paths which exist. 
2298         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2299         (Testprinter.test_print_config):
2300
2301 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2302
2303         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2304         https://bugs.webkit.org/show_bug.cgi?id=193340
2305
2306         Reviewed by David Kilzer.
2307
2308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2309         (WTR::InjectedBundle::didReceiveMessageToPage):
2310         Pull the strings out into a WKRetainPtr.
2311
2312         * WebKitTestRunner/WebNotificationProvider.cpp:
2313         (WTR::WebNotificationProvider::closeWebNotification):
2314         Adopt the created value into the WKRetainPtr.
2315
2316         * WebKitTestRunner/mac/TestControllerMac.mm:
2317         (WTR::generateWhitelist):
2318         Immediately adopt a created value to avoid potential mistakes.
2319
2320 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2321
2322         Enable DFG on ARM/Linux again
2323         https://bugs.webkit.org/show_bug.cgi?id=192496
2324
2325         Reviewed by Yusuke Suzuki.
2326
2327         After changing the bytecode format DFG was disabled on all 32-bit
2328         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2329         on ARM by default.
2330
2331         * Scripts/run-jsc-stress-tests:
2332
2333 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2334
2335         Unreviewed, fix #ifdef in API test added in r239851.
2336         https://bugs.webkit.org/show_bug.cgi?id=193327
2337         rdar://problem/47093222
2338
2339         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2340
2341 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2342
2343         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2344         https://bugs.webkit.org/show_bug.cgi?id=193109
2345         <rdar://problem/44807048>
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         Introduce and respect a test option to enable the UndoManager API.
2350
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::updateTestOptionsFromTestHeader):
2353         * WebKitTestRunner/TestOptions.h:
2354         (WTR::TestOptions::hasSameInitializationOptions const):
2355         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2356         (WTR::TestController::platformCreateWebView):
2357
2358 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2359
2360         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2361         https://bugs.webkit.org/show_bug.cgi?id=193346
2362
2363         Reviewed by Antti Koivisto.
2364
2365         * LayoutReloaded/misc/LFC-passing-tests.txt:
2366
2367 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2368
2369         Unreviewed, fix typo that breaks dashboard link.
2370
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2372         (WebKitBuildbot):
2373
2374 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2375
2376         Update macOS queue configurations
2377         https://bugs.webkit.org/show_bug.cgi?id=193329
2378
2379         Reviewed by Alexey Proskuryakov.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/config.json:
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2383         (BubbleQueueServer):
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2386         (WebKitBuildbot):
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2388         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2389         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2390
2391 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2392
2393         MiniBrowser should be able to navigate to about:blank
2394         https://bugs.webkit.org/show_bug.cgi?id=193345
2395
2396         Reviewed by Simon Fraser.
2397
2398         * MiniBrowser/mac/BrowserWindowController.m:
2399         (-[BrowserWindowController addProtocolIfNecessary:]):
2400         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2401
2402         * MiniBrowser/mac/WK1BrowserWindowController.m:
2403         (-[WK1BrowserWindowController fetch:]):
2404         * MiniBrowser/mac/WK2BrowserWindowController.m:
2405         (-[WK2BrowserWindowController fetch:]):
2406         Clean up the code that uses this to match style.
2407
2408 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2409
2410         Remove MiniBrowser custom "Process Swap" menu item which does not work
2411         https://bugs.webkit.org/show_bug.cgi?id=193344
2412
2413         Reviewed by Simon Fraser.
2414
2415         There is a menu item under the Experimental menu that does work.
2416
2417         * MiniBrowser/mac/AppDelegate.m:
2418         (defaultConfiguration):
2419         * MiniBrowser/mac/SettingsController.h:
2420         * MiniBrowser/mac/SettingsController.m:
2421         (-[SettingsController _populateMenu]):
2422         (-[SettingsController validateMenuItem:]):
2423         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2424         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2425
2426 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2427
2428         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2429         https://bugs.webkit.org/show_bug.cgi?id=193327
2430         rdar://problem/47093222
2431
2432         Reviewed by Tim Horton.
2433
2434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2435         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2436         (TestWebKitAPI::didFinishNavigation):
2437         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2438         (TestWebKitAPI::TEST):
2439         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2440         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2441         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2442         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2443         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2444
2445 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2446
2447         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2448         https://bugs.webkit.org/show_bug.cgi?id=193338
2449         <rdar://problem/46664774>
2450
2451         Reviewed by David Kilzer.
2452
2453         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2454         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2455
2456 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2457
2458         Unreviewed, rolling out r239825.
2459         https://bugs.webkit.org/show_bug.cgi?id=193330
2460
2461         Broke tests on armv7/linux bots (Requested by guijemont on
2462         #webkit).
2463
2464         Reverted changeset:
2465
2466         "Enable DFG on ARM/Linux again"
2467         https://bugs.webkit.org/show_bug.cgi?id=192496
2468         https://trac.webkit.org/changeset/239825
2469
2470 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2471
2472         Disable the run-jsc-stress-test remote host key check.
2473         https://bugs.webkit.org/show_bug.cgi?id=192988
2474
2475         Reviewed by Alexey Proskuryakov.
2476
2477         * Scripts/run-jsc-stress-tests:
2478
2479 2019-01-10  John Wilander  <wilander@apple.com>
2480
2481         Override the session configuration for cookieAcceptPolicy
2482         https://bugs.webkit.org/show_bug.cgi?id=190925
2483         <rdar://problem/45497382>
2484
2485         Reviewed by Alexey Proskuryakov and Alex Christensen.
2486
2487         Test infrastructure for setting a first-party-only cookie policy.
2488
2489         * DumpRenderTree/TestRunner.cpp:
2490         (setOnlyAcceptFirstPartyCookiesCallback):
2491         (TestRunner::staticFunctions):
2492         * DumpRenderTree/TestRunner.h:
2493         * DumpRenderTree/mac/TestRunnerMac.mm:
2494         (TestRunner::setOnlyAcceptFirstPartyCookies):
2495         * DumpRenderTree/win/TestRunnerWin.cpp:
2496         (TestRunner::setOnlyAcceptFirstPartyCookies):
2497         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2498         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2499         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2500         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2501         * WebKitTestRunner/TestInvocation.cpp:
2502         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2503
2504 2019-01-09  Matt Rajca  <mrajca@apple.com>
2505
2506         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2507         https://bugs.webkit.org/show_bug.cgi?id=193301
2508
2509         Reviewed by Jer Noble.
2510         
2511         Added API tests.
2512
2513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2514         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2515         (TEST):
2516         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2517
2518 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2519
2520         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2521         https://bugs.webkit.org/show_bug.cgi?id=193310
2522
2523         Reviewed by Antti Koivisto.
2524
2525         * LayoutReloaded/misc/LFC-passing-tests.txt:
2526
2527 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2528
2529         Enable DFG on ARM/Linux again
2530         https://bugs.webkit.org/show_bug.cgi?id=192496
2531
2532         Reviewed by Yusuke Suzuki.
2533
2534         After changing the bytecode format DFG was disabled on all 32-bit
2535         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2536         on ARM by default.
2537
2538         * Scripts/run-jsc-stress-tests:
2539
2540 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2541
2542         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2543         https://bugs.webkit.org/show_bug.cgi?id=193271
2544
2545         Reviewed by Brent Fulgham.
2546
2547         BSTR is a special data structure created by SysAllocString, not a
2548         wchar_t null-terminated string.
2549
2550         * DumpRenderTree/win/TestRunnerWin.cpp:
2551         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2552         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2553         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2554         BSTR from wide string literals.
2555
2556 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2557
2558         Tweak wording for build/version_check style checker error
2559         https://bugs.webkit.org/show_bug.cgi?id=193256
2560
2561         Reviewed by Tim Horton.
2562
2563         * Scripts/webkitpy/style/checkers/cpp.py:
2564         (check_os_version_checks):
2565         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2566         (WebKitStyleTest.test_os_version_checks):
2567
2568 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-build] Add link to bug along with bug title
2571         https://bugs.webkit.org/show_bug.cgi?id=193293
2572
2573         Reviewed by Lucas Forschler.
2574
2575         * BuildSlaveSupport/ews-build/steps.py:
2576         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2577         (ConfigureBuild.add_bug_id_url): Deleted.
2578         (ConfigureBuild.getBugURL): Deleted.
2579
2580 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews-build] Use https for ews-build server
2583         https://bugs.webkit.org/show_bug.cgi?id=193193
2584
2585         Reviewed by Lucas Forschler.
2586
2587         * BuildSlaveSupport/ews-build/steps.py:
2588
2589 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2590
2591         [ews-build] Parse and display number of style failures
2592         https://bugs.webkit.org/show_bug.cgi?id=193280
2593
2594         Reviewed by Lucas Forschler.
2595
2596         * BuildSlaveSupport/ews-build/steps.py:
2597         (CheckStyle): Use TestWithFailureCount as base class.
2598         (CheckStyle.countFailures): Count the number of style failures.
2599
2600 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2601
2602         [ews-build] use patch_id instead of ewspatchid
2603         https://bugs.webkit.org/show_bug.cgi?id=193235
2604
2605         Reviewed by Lucas Forschler.
2606
2607         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2608         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2609         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2610
2611 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2612
2613         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2614         https://bugs.webkit.org/show_bug.cgi?id=192625
2615
2616         Reviewed by Antti Koivisto.
2617
2618         * LayoutReloaded/misc/LFC-passing-tests.txt:
2619
2620 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2621
2622         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2623         https://bugs.webkit.org/show_bug.cgi?id=192841
2624
2625         Reviewed by Carlos Garcia Campos.
2626
2627         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2628         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2629         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2630
2631         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2632
2633         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2634         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2635         (WebKitWebEditorTest::testSelectionChanged):
2636         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2637         (WebKitFrameTest::testMainFrame):
2638         (WebKitFrameTest::testURI):
2639         (WebKitFrameTest::testJavaScriptContext):
2640         (WebKitFrameTest::testJavaScriptValues):
2641         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2642         (testWebViewAuthenticationRequest):
2643         (testWebViewAuthenticationLoadCancelled):
2644         (testWebViewAuthenticationFailure):
2645         (testWebViewAuthenticationStorage):
2646         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2647         (testWebViewAuthenticationProxy):
2648         (testWebViewAuthenticationProxyHTTPS):
2649         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2650         (testAutomationSessionRequestSession):
2651         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2652         (testBackForwardListNavigation):
2653         (testWebKitWebViewSessionState):
2654         (testWebKitWebViewSessionStateWithFormData):
2655         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2656         (ConsoleMessageTest::consoleMessageReceivedCallback):
2657         (testWebKitConsoleMessageConsoleAPI):
2658         (testWebKitConsoleMessageJavaScriptException):
2659         (testWebKitConsoleMessageNetworkError):
2660         (testWebKitConsoleMessageSecurityError):
2661         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2662         (testCookieManagerAcceptPolicy):
2663         (testCookieManagerCookiesChanged):
2664         (testCookieManagerPersistentStorage):
2665         (testCookieManagerPersistentStorageDeleteAll):
2666         (testCookieManagerEphemeral):
2667         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2668         (testWebKitDOMElementAutoFill):
2669         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2670         (downloadLocalFileSuccessfully):
2671         (createFileAtDestination):
2672         (testDownloadOverwriteDestinationDisallowed):
2673         (testDownloadLocalFileError):
2674         (testDownloadRemoteFile):
2675         (testDownloadRemoteFileError):
2676         (testWebViewDownloadURI):
2677         (testPolicyResponseDownload):
2678         (testPolicyResponseDownloadCancel):
2679         (testDownloadMIMEType):
2680         (contextMenuCallback):
2681         (testContextMenuDownloadActions):
2682         (testBlobDownload):
2683         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2684         (testWebKitWebEditorSelectionChanged):
2685         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2686         (testWebKitFrameMainFrame):
2687         (testWebKitFrameURI):
2688         (testWebKitFrameJavaScriptContext):
2689         (testWebKitFrameJavaScriptValues):
2690         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2691         (LoadStopTrackingTest::loadFailed):
2692         (testWebViewTitle):
2693         (testURIRequestHTTPHeaders):
2694         (testURIRequestHTTPMethod):
2695         (testURIResponseHTTPHeaders):
2696         (testRedirectToDataURI):
2697         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2698         (testProcessPerWebView):
2699         (testWebProcessLimit):
2700         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2701         (testWebViewResources):
2702         (testWebResourceLoading):
2703         (testWebResourceSuggestedFilename):
2704         (testWebResourceGetData):
2705         (testWebResourceGetDataError):
2706         (testWebViewResourcesHistoryCache):
2707         (testWebResourceSendRequest):
2708         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2709         (testSSL):
2710         (testInsecureContent):
2711         (testTLSErrorsPolicy):
2712         (testTLSErrorsRedirect):
2713         (testTLSErrorsHTTPAuth):
2714         (testLoadFailedWithTLSErrors):
2715         (testSubresourceLoadFailedWithTLSErrors):
2716         (httpsServerCallback):
2717         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2718         (testWebViewCreateNavigationData):
2719         (testWebViewJavaScriptDialogs):
2720         (testWebViewWindowProperties):
2721         (testWebViewMouseTarget):
2722         (testWebViewFileChooserRequest):
2723         (testWebViewColorChooserRequest):
2724         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2725         (testWebExtensionGetTitle):
2726         (testDocumentLoadedSignal):
2727         (testWebKitWebViewProcessCrashed):
2728         (testWebExtensionWindowObjectCleared):
2729         (testWebExtensionIsolatedWorld):
2730         (permissionRequestCallback):
2731         (didAssociateFormControlsCallback):
2732         (testWebExtensionFormControlsAssociated):
2733         (FormSubmissionTest::FormSubmissionTest):
2734         (FormSubmissionTest::testFormSubmissionResult):
2735         (testWebExtensionFormSubmissionSteps):
2736         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2737         (testNotInitialized):
2738         (testClearDatabase):
2739         (testPrivateBrowsing):
2740         (testGetFavicon):
2741         (testWebViewFavicon):
2742         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2743         (testFindControllerTextFound):
2744         (testFindControllerTextNotFound):
2745         (testFindControllerMatchCount):
2746         (testFindControllerMaxMatchCount):
2747         (testFindControllerNext):
2748         (testFindControllerPrevious):
2749         (testFindControllerCountedMatches):
2750         (testFindControllerOptions):
2751         (testFindControllerHide):
2752         (testFindControllerInstance):
2753         (testFindControllerGetters):
2754         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2755         (testNavigationPolicy):
2756         (testResponsePolicy):
2757         (testNewWindowPolicy):
2758         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2759         (testSecurityOriginBasicConstructor):
2760         (testSecurityOriginURIConstructor):
2761         (testSecurityOriginDefaultPort):
2762         (testSecurityOriginFileURI):
2763         (testOpaqueSecurityOrigin):
2764         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2765         (testWebKitSettings):
2766         (testWebKitSettingsNewWithSettings):
2767         (testWebKitSettingsUserAgent):
2768         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2769         (testWebViewNewWithUserContentManager):
2770         (isStyleSheetInjectedForURLAtPath):
2771         (isScriptInjectedForURLAtPath):
2772         (testUserContentManagerInjectedStyleSheet):
2773         (testUserContentManagerInjectedScript):
2774         (UserScriptMessageTest::scriptMessageReceived):
2775         (UserScriptMessageTest::waitUntilMessageReceived):
2776         (UserScriptMessageTest::runJavaScriptFinished):
2777         (testUserContentManagerScriptMessageReceived):
2778         (testUserContentManagerScriptMessageInWorldReceived):
2779         (testUserContentManagerScriptMessageFromDOMBindings):
2780         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2781         (testWebContextDefault):
2782         (testWebContextEphemeral):
2783         (testWebContextGetPlugins):
2784         (testWebContextURIScheme):
2785         (testWebContextSpellChecker):
2786         (testWebContextLanguages):
2787         (consoleMessageReceivedCallback):
2788         (testWebContextSecurityFileXHR):
2789         (ProxyTest::ProxyTest):
2790         (testWebContextProxySettings):
2791         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2792         (testWebViewWebContext):
2793         (testWebViewWebBackend):
2794         (testWebViewEphemeral):
2795         (testWebViewCustomCharset):
2796         (testWebViewSettings):
2797         (testWebViewRunJavaScript):
2798         (testWebViewCanShowMIMEType):
2799         (testWebViewSubmitForm):
2800         (testWebViewSave):
2801         (testWebViewPageVisibility):
2802         (testWebViewSnapshot):
2803         (testWebViewNotification):
2804         (testWebViewNotificationInitialPermissionAllowed):
2805         (testWebViewNotificationInitialPermissionDisallowed):
2806         (testWebViewIsPlayingAudio):
2807         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2808         (WebsiteDataTest::WebsiteDataTest):
2809         (WebsiteDataTest::remove):
2810         (WebsiteDataTest::clear):
2811         (testWebsiteDataConfiguration):
2812         (testWebsiteDataEphemeral):
2813         (testWebsiteDataCache):
2814         (testWebsiteDataStorage):
2815         (testWebsiteDataDatabases):
2816         (testWebsiteDataAppcache):
2817         (testWebsiteDataCookies):
2818         (testWebsiteDataDeviceIdHashSalt):
2819         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2820         (emitDocumentLoaded):
2821         (emitURIChanged):
2822         (sendRequestCallback):
2823         (contextMenuCallback):
2824         (consoleMessageSentCallback):
2825         (emitFormControlsAssociated):
2826         (formControlsAssociatedCallback):
2827         (emitFormSubmissionEvent):
2828         (willSubmitFormCallback):
2829         (windowObjectCleared):
2830         (methodCallCallback):
2831         (registerGResource):
2832         (webkit_web_extension_initialize_with_user_data):
2833         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2834         (checkLeaks):
2835         (WebProcessTest::create):
2836         (runTest):
2837         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2838         (AutocleanupsTest::testWebProcessAutocleanups):
2839         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2840         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2841         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2842         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2843         (WebKitDOMDOMWindowTest::testSignals):
2844         (WebKitDOMDOMWindowTest::testDispatchEvent):
2845         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2846         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2847         (WebKitDOMNodeFilterTest::testTreeWalker):
2848         (WebKitDOMNodeFilterTest::testNodeIterator):
2849         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2850         (WebKitDOMNodeTest::testHierarchyNavigation):
2851         (WebKitDOMNodeTest::testInsertion):
2852         (WebKitDOMNodeTest::testTagNamesNodeList):
2853         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2854         (WebKitDOMNodeTest::testDOMCache):
2855         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2856         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2857         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2858         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2859         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2860         (testUIProcessAutocleanups):
2861         (testWebProcessAutocleanups):
2862         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2863         (testContextMenuPopulateMenu):
2864         (testContextMenuDismissed):
2865         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2866         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2867         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2868         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2869         (testWebKitDOMDOMWindowSignals):
2870         (testWebKitDOMDOMWindowDispatchEvent):
2871         (testWebKitDOMDOMWindowGetComputedStyle):
2872         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2873         (testWebKitDOMNodeHierarchyNavigation):
2874         (testWebKitDOMNodeInsertion):
2875         (testWebKitDOMNodeTagNamesNodeList):
2876         (testWebKitDOMNodeTagNamesHTMLCollection):
2877         (testWebKitDOMObjectCache):
2878         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2879         (testWebKitDOMNodeFilterTreeWalker):
2880         (testWebKitDOMNodeFilterNodeIterator):
2881         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2882         (testWebKitDOMXPathNSResolverNative):
2883         (testWebKitDOMXPathNSResolverCustom):
2884         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2885         (testInspectorDefault):
2886         (testInspectorManualAttachDetach):
2887         (testInspectorCustomContainerDestroyed):
2888         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2889         (startTestServer):
2890         (testInspectorServerPageList):
2891         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2892         (OptionMenuTest::showOptionMenuCallback):
2893         (OptionMenuTest::menuCloseCallback):
2894         (OptionMenuTest::close):
2895         (OptionMenuTest::activateItem):
2896         (OptionMenuTest::selectItem):
2897         (testOptionMenuSimple):
2898         (testOptionMenuGroups):
2899         (testOptionMenuActivate):
2900         (testOptionMenuSelect):
2901         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2902         (testPrintOperationPrintSettings):
2903         (webViewPrintCallback):
2904         (testPrintOperationPrint):
2905         (testPrintCustomWidget):
2906         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2907         (checkAtspiAccessible):
2908         (testAtspiBasicHierarchy):
2909         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2910         (testWebKitCheckVersion):
2911         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2912         (testWebViewEditorCutCopyPasteNonEditable):
2913         (testWebViewEditorCutCopyPasteEditable):
2914         (testWebViewEditorSelectAllNonEditable):
2915         (testWebViewEditorSelectAllEditable):
2916         (loadContentsAndTryToCutSelection):
2917         (testWebViewEditorNonEditable):
2918         (testWebViewEditorEditable):
2919         (testWebViewEditorEditorStateTypingAttributes):
2920         (testWebViewEditorInsertImage):
2921         (testWebViewEditorCreateLink):
2922         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2923         (loadChangedCallback):
2924         (loadFailedCallback):
2925         (loadFailedWithTLSErrorsCallback):
2926         (LoadTrackingTest::LoadTrackingTest):
2927         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2928         (registerGResource):
2929         (removeNonEmptyDirectory):
2930         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2931         (Test::adoptView):
2932         (Test::~Test):
2933         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2934         (WebKitTestBus::getOrCreateConnection):
2935         (WebKitTestBus::createProxy):
2936         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2937         (WebKitTestServer::getWebSocketURIForPath const):
2938         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2939         (WebViewTest::initializeWebView):
2940         (WebViewTest::loadURI):
2941         (WebViewTest::loadHtml):
2942         (WebViewTest::loadPlainText):
2943         (WebViewTest::loadBytes):
2944         (WebViewTest::loadRequest):
2945         (WebViewTest::loadAlternateHTML):
2946         (WebViewTest::goBack):
2947         (WebViewTest::goForward):
2948         (WebViewTest::goToBackForwardListItem):
2949         (resourceGetDataCallback):
2950         (WebViewTest::mainResourceData):
2951         (WebViewTest::javascriptResultToCString):
2952         (WebViewTest::javascriptResultToNumber):
2953         (WebViewTest::javascriptResultToBoolean):
2954         (WebViewTest::javascriptResultIsNull):
2955         (WebViewTest::javascriptResultIsUndefined):
2956         (onSnapshotReady):
2957         (WebViewTest::runWebProcessTest):
2958         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2959         (WebViewTest::platformInitializeWebView):
2960         (WebViewTest::showInWindow):
2961         (WebViewTest::showInWindowAndWaitUntilMapped):
2962         (WebViewTest::mouseMoveTo):
2963         (WebViewTest::emitPopupMenuSignal):
2964         (WebViewTest::keyStroke):
2965         (WebViewTest::doMouseButtonEvent):
2966
2967 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2968
2969         [WPE] API tests can't run in flatpak environment
2970         https://bugs.webkit.org/show_bug.cgi?id=193242
2971
2972         Reviewed by Michael Catanzaro.
2973
2974         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2975         flatpakutils so that it knows which port it's dealing with.
2976         * glib/common.py: Remove build_dir globals so that subsequent
2977         calls actually take args into account.
2978         (library_build_path):
2979         (binary_build_path):
2980
2981 2019-01-08  Dean Jackson  <dino@apple.com>
2982
2983         Blob references for System Previews don't get a correct file extension
2984         https://bugs.webkit.org/show_bug.cgi?id=193268
2985         <rdar://problem/47133037>
2986
2987         Reviewed by Tim Horton.
2988
2989         New test that a Blob download of a USDZ file gets named correctly.
2990
2991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2992         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2993         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2994         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2995         (TEST):
2996         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2997
2998 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2999
3000         [WebAuthN] Support U2F HID Authenticators on macOS
3001         https://bugs.webkit.org/show_bug.cgi?id=191535
3002         <rdar://problem/47102027>
3003
3004         Reviewed by Brent Fulgham.
3005
3006         This patch:
3007         1) adds support for U2F mocking mechanism;
3008         2) updates tests to reflect U2fCommandConstructor changes.
3009
3010         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3011         (TestWebKitAPI::TEST):
3012         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3013         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3014         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3015
3016 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3017
3018         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3019         https://bugs.webkit.org/show_bug.cgi?id=193229
3020         <rdar://problem/46717097>
3021
3022         Reviewed by Tim Horton.
3023
3024         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3025         prevents a drag from starting.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3028         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3029
3030         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3031
3032 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3033   
3034         Layout test will generate a perf metric file to results dir.
3035         https://bugs.webkit.org/show_bug.cgi?id=192030
3036         <rdar://problem/32779516>
3037
3038         Reviewed by Aakash Jain.
3039
3040         Layout test running time will be collected to a perf metric file.
3041         For now, instead of outputing running time of all tests (which is huge),
3042         we aggregate them by test directories which are at most two level deep. 
3043
3044         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3045         (Manager._end_test_run):
3046         (Manager._output_perf_metrics):
3047         (Manager._print_expectation_line_for_test):
3048         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3049         (add_test_perf_metric):
3050         (test_perf_metrics):
3051         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3052         (JSONGeneratorTest.test_test_timings_trie):
3053         (JSONGeneratorTest):
3054         (JSONGeneratorTest.test_test_perf_metrics):
3055         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3056         (RebaselineTest.test_reset_results):
3057         (RebaselineTest.test_missing_results):
3058         (RebaselineTest.test_new_baseline):
3059
3060 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3061
3062         [WPE][GTK] Add php-json to install-dependencies
3063         https://bugs.webkit.org/show_bug.cgi?id=193233
3064
3065         Reviewed by Michael Catanzaro.
3066
3067         * gtk/install-dependencies:
3068         * wpe/install-dependencies:
3069
3070 2019-01-08  Chris Dumez  <cdumez@apple.com>
3071
3072         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3073         https://bugs.webkit.org/show_bug.cgi?id=193224
3074         <rdar://problem/47097726>
3075
3076         Reviewed by Alex Christensen.
3077
3078         Add API test coverage.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081
3082 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3083
3084         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3085         <https://webkit.org/b/193222>
3086         <rdar://problem/46862309>
3087
3088         Reviewed by Joseph Pecoraro.
3089
3090         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3091         (WTR::executeCallback): Fix camel case of variable name.
3092         (WTR::EventSendingController::callAfterScrollingCompletes): If
3093         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3094         false, make sure to release the ScrollCompletionCallbackData
3095         object.  This fixes the leak.
3096
3097 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3098
3099         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3100         https://bugs.webkit.org/show_bug.cgi?id=193044
3101
3102         Reviewed by Daniel Bates.
3103
3104         WinCairo EWS bots are using Windows Perl. Binary files should be
3105         opened as binary mode.
3106
3107         * Scripts/svn-apply:
3108         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3109
3110 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3111
3112         [CMake] Add ENABLE_CSS_TYPED_OM option
3113         https://bugs.webkit.org/show_bug.cgi?id=193216
3114
3115         Reviewed by Michael Catanzaro.
3116
3117         * Scripts/webkitperl/FeatureList.pm:
3118
3119 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3120
3121         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3122         <https://webkit.org/b/193056>
3123
3124         Reviewed by Alex Christensen.
3125
3126         * Scripts/webkitpy/style/checker.py:
3127         - Ignore use of new runtime/retainptr check in
3128           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3129           contains tests to ensure RetainPtr<NSObject *> is compatible
3130           with RetainPtr<NSObject>.
3131
3132         * Scripts/webkitpy/style/checkers/cpp.py:
3133         (check_language):
3134         (CppChecker):
3135         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3136           was used instead of a single regex so that angle brackets
3137           could be matched up when checking the type contained within
3138           the RetainPtr<> type.
3139
3140         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3141         (CppStyleTest):
3142         - Add unit test for new runtime/retainptr check.
3143
3144         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3145         * TestWebKitAPI/EditingTestHarness.h:
3146         - Remove '*' from RetainPtr<> type.
3147
3148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3149         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3150           regressed in r201938.
3151
3152         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3153         (TestWebKitAPI::TEST):
3154         - Update tests to match RetainPtr.mm tests (except for the
3155           `*SimilarNSType` tests since there is no CF equivalent of
3156           RetainPtr<NSString> and RetainPtr<NSString *>).
3157
3158         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3159         (TestWebKitAPI::TEST):
3160         - Update tests to:
3161           - Not conflict by name with equivalent CF tests in
3162             RetainPtr.cpp.
3163           - Add test cases for RetainPtr<NSObject>,
3164             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3165           - Add `*SimilarNSType` tests for converting between
3166             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3167           - Change `0` to `nil` as appropriate.
3168           - Re-alphabetize the tests by name.
3169           - Add Optional<RetainPtr<>> tests.
3170           - Add retainPtr() tests.
3171
3172         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3173         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3174         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3175         (TEST):
3176         - Remove '*' from RetainPtr<> type.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3179         (TEST(WebKit, JITEnabled)):
3180         - Add missing WTFMove().  Apparently a temporary was being
3181           created before in the argument list due to mismatched
3182           RetainPtr<> types.
3183
3184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3185         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3186         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3187         (TestWebKitAPI::TEST):
3188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3189         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3190         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3191         (WTR::resourcesDirectoryURL):
3192         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3193         (WTR::InjectedBundle::platformInitialize):
3194         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3195         - Remove '*' from RetainPtr<> type.
3196
3197 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3198
3199         A MediaTime timescale must never be zero
3200         https://bugs.webkit.org/show_bug.cgi?id=193156
3201         <rdar://problem/32504501>
3202
3203         Reviewed by Jer Noble.
3204
3205         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3206         (TestWebKitAPI::TEST): Add tests for zero timescale.
3207
3208 2019-01-07  Youenn Fablet  <youenn@apple.com>
3209
3210         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3211         https://bugs.webkit.org/show_bug.cgi?id=193175
3212
3213         Reviewed by Chris Dumez.
3214
3215         Updated API test as we bumped the SW schema to version 4.
3216
3217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3218         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3219         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3220         (TEST):
3221
3222 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3223
3224         [Win][Clang] Fix compilation warnings of MiniBrowser
3225         https://bugs.webkit.org/show_bug.cgi?id=193029
3226
3227         Reviewed by Ross Kirsling.
3228
3229         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3230         and m_URLBarFont. Reorder member variables to fix -Wreorder
3231         warning.
3232         * MiniBrowser/win/PageLoadTestClient.cpp:
3233         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3234         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3235         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3236         m_currentURLIndex.
3237         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3238         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3239         navigationClient with '{ }' to fix the missing field warning.
3240         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3241         (initDocStruct): Changed the argument type docname to const.
3242
3243 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3244
3245         [WebAuthN] Import U2F command/response converters from Chromium
3246         https://bugs.webkit.org/show_bug.cgi?id=193150
3247         <rdar://problem/47054028>
3248
3249         Reviewed by Brent Fulgham.
3250
3251         Adds API tests.
3252
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3255         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3256         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3257         (TestWebKitAPI::getTestAttestationObjectBytes):
3258         (TestWebKitAPI::getTestSignResponse):
3259         (TestWebKitAPI::getTestU2fRegisterResponse):
3260         (TestWebKitAPI::TEST):
3261         (TestWebKitAPI::convertToVector): Deleted.
3262         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3263         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3264         (TestWebKitAPI::constructMakeCredentialRequest):
3265         (TestWebKitAPI::constructGetAssertionRequest):
3266         (TestWebKitAPI::TEST):
3267
3268 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3269
3270         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3271         https://bugs.webkit.org/show_bug.cgi?id=193136
3272
3273         Reviewed by Michael Catanzaro.
3274
3275         * gtk/install-dependencies:
3276         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3277         they are needed by update-webkitgtk-libs.
3278
3279 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3280
3281         Unreviewed follow-up fix to r239650
3282         https://bugs.webkit.org/show_bug.cgi?id=193140
3283         <rdar://problem/47063037>
3284
3285         Typecast patch_id to string.
3286
3287         * BuildSlaveSupport/ews-build/steps.py:
3288         (ValidatePatch._is_patch_obsolete):
3289
3290 2019-01-04  Daniel Bates  <dabates@apple.com>
3291
3292         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3293         https://bugs.webkit.org/show_bug.cgi?id=193024
3294
3295         Reviewed by Jer Noble.
3296
3297         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3298         for the bitmask type WebEventFlags as an example.
3299
3300         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3301         that can be used to register summary and synthetic child formatters for a bitmask type.
3302         For example, consider the following enum and bitmask typedefs:
3303
3304         typedef enum {
3305             A = 1 << 0,
3306             B = 1 << 1,
3307             C = 1 << 2,
3308         } SpecialFlagValues;
3309         typedef unsigned SpecialFlags;
3310
3311         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3312         __lldb_init_module():
3313
3314             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3315                     1 << 0: "A",
3316                     1 << 1: "B",
3317                     1 << 2: "C",
3318             })
3319
3320         * lldb/lldb_webkit.py:
3321         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3322         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3323         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3324         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3325         A convenience function to dynamically creaste a synthetic formatter class and summary
3326         string function for the specified bitmask type and enumerator value to name map. This
3327         function register the dynamically created class and function with LLDB.
3328
3329         (__lldb_init_module):
3330         (FlagEnumerationProvider):
3331         (FlagEnumerationProvider._enumerator_value_to_name_map):
3332         (FlagEnumerationProvider._bitmask):
3333         (FlagEnumerationProvider._update):
3334         (FlagEnumerationProvider.has_children):
3335         (FlagEnumerationProvider.num_children):
3336         (FlagEnumerationProvider.get_child_index):
3337         (FlagEnumerationProvider.get_child_at_index):
3338         (FlagEnumerationProvider.update):
3339         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3340
3341         (WTFOptionSetProvider):
3342         (WTFOptionSetProvider._enumerator_value_to_name_map):
3343         (WTFOptionSetProvider._bitmask):
3344         (WTFOptionSetProvider._update):
3345         Write in terms of the base class.
3346
3347         (RawBitmaskProviderBase):
3348         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3349         (RawBitmaskProviderBase._bitmask):
3350         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3351         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3352         {
3353             1 << 0: "A",
3354             1 << 1: "B",
3355             1 << 2: "C",
3356         }
3357         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3358         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3359
3360         (WTFOptionSetProvider.has_children): Deleted.
3361         (WTFOptionSetProvider.num_children): Deleted.
3362         (WTFOptionSetProvider.get_child_index): Deleted.
3363         (WTFOptionSetProvider.get_child_at_index): Deleted.
3364         (WTFOptionSetProvider.update): Deleted.
3365
3366 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3367
3368         [ews-build] Add build step to validate the patch before processing it
3369         https://bugs.webkit.org/show_bug.cgi?id=193140
3370
3371         Reviewed by Lucas Forschler.
3372
3373         * BuildSlaveSupport/ews-build/factories.py:
3374         (Factory.__init__): Added ValidatePatch step.
3375         * BuildSlaveSupport/ews-build/steps.py:
3376         (ValidatePatch):
3377         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3378         (ValidatePatch.get_patch_json): Get patch json data.
3379         (ValidatePatch.get_bug_json): Get bug json data.
3380         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3381         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3382         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3383         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3384         (ValidatePatch.skip_build): Skip the build.
3385         (ValidatePatch.start):
3386
3387 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3388
3389         Progress towards fixing Mac CMake build
3390         https://bugs.webkit.org/show_bug.cgi?id=193105
3391
3392         Reviewed by Don Olmstead.
3393
3394         * TestWebKitAPI/PlatformMac.cmake:
3395
3396 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3397
3398         Fix API test after r239631
3399         https://bugs.webkit.org/show_bug.cgi?id=193118
3400
3401         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3402         (TestWebKitAPI::TEST):
3403         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3404         Do the same thing via the API to fix the test.
3405
3406 2019-01-04  Jer Noble  <jer.noble@apple.com>
3407
3408         [WebKitLegacy] Media playback pauses on scroll
3409         https://bugs.webkit.org/show_bug.cgi?id=192829
3410
3411         Reviewed by Eric Carlson.
3412
3413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3414         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3415         (TestWebKitAPI::TEST):
3416         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3417         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3418         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3419         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3420         (TestWebKitAPI::TEST):
3421
3422 2019-01-04  Chris Dumez  <cdumez@apple.com>
3423
3424         Add support for toggling device orientation API support per site
3425         https://bugs.webkit.org/show_bug.cgi?id=193143
3426         <rdar://problem/46605724>
3427
3428         Reviewed by Alex Christensen.
3429
3430         Add API test coverage.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3433         (-[DataMappingSchemeHandler setTaskHandler:]):
3434         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3435         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3436         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3437         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3438
3439 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews-build] use svn-apply script to apply the patches
3442         https://bugs.webkit.org/show_bug.cgi?id=193138
3443
3444         Reviewed by Lucas Forschler.
3445
3446         * BuildSlaveSupport/ews-build/factories.py:
3447         (Factory.__init__): Add the ApplyPatch step.
3448         * BuildSlaveSupport/ews-build/steps.py:
3449         (CheckOutSource): Added step name.
3450         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3451         (ApplyPatch): Build step to apply patch using svn-apply script.
3452         (UnApplyPatchIfRequired):
3453         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3454
3455 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3456
3457         Deprecate WKContextCreate
3458         https://bugs.webkit.org/show_bug.cgi?id=193118
3459
3460         Reviewed by Brady Eidson.
3461
3462         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3463         (WebKitBrowserWindow::WebKitBrowserWindow):
3464         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3465         (TestWebKitAPI::TEST):
3466         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3467         (TestWebKitAPI::TEST):
3468         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3469         (TestWebKitAPI::TEST):
3470         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3471         (TestWebKitAPI::TEST):
3472         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3473         (TestWebKitAPI::TEST):
3474         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3475         (TestWebKitAPI::TEST):
3476         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3477         (TestWebKitAPI::TEST):
3478         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3479         (TestWebKitAPI::TEST):
3480         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3481         (TestWebKitAPI::TEST):
3482         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3483         (TestWebKitAPI::TEST):
3484         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3485         (TestWebKitAPI::TEST):
3486         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3487         (TestWebKitAPI::TEST):
3488         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3489         (TestWebKitAPI::TEST):
3490         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3491         (TestWebKitAPI::TEST):
3492         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3493         (TestWebKitAPI::TEST):
3494         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3495         (TestWebKitAPI::TEST):
3496         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3497         (TestWebKitAPI::TEST):
3498         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3499         (TestWebKitAPI::TEST):
3500         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3501         (TestWebKitAPI::loadAlternateHTMLString):
3502         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3503         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3504         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3505         (TestWebKitAPI::buildAndPerformTest):
3506         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3507         (TestWebKitAPI::TEST):
3508         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3509         (TestWebKitAPI::TEST):
3510         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3511         (TestWebKitAPI::TEST):
3512         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3515         (TestWebKitAPI::TEST):
3516         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3517         (TestWebKitAPI::TEST):
3518         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3519         (TestWebKitAPI::TEST):
3520         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3521         (TestWebKitAPI::TEST):
3522         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3523         (TestWebKitAPI::TEST):
3524         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3525         (TestWebKitAPI::TEST):
3526         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3527         (TestWebKitAPI::TEST):
3528         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3529         (TestWebKitAPI::TEST):
3530         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3531         (TestWebKitAPI::TEST):
3532         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3533         (TestWebKitAPI::TEST):
3534         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3535         (TestWebKitAPI::TEST):
3536         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3537         (TestWebKitAPI::TEST):
3538         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3539         (TestWebKitAPI::TEST):
3540         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3541         (TestWebKitAPI::TEST):
3542         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3545         (TestWebKitAPI::TEST):
3546         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3547         (TestWebKitAPI::TEST):
3548         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3549         (TestWebKitAPI::TEST):
3550         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3551         (TestWebKitAPI::TEST):
3552         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3553         (TestWebKitAPI::TEST):
3554         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3559         (WebKit2_CommandBackForwardTestWKView::SetUp):
3560         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3561         (TestWebKitAPI::TEST):
3562         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3563         (TestWebKitAPI::TEST):
3564         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3565         (TestWebKitAPI::TEST):
3566         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3567         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3568
3569 2019-01-03  Matt Rajca  <mrajca@apple.com>
3570
3571         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3572         https://bugs.webkit.org/show_bug.cgi?id=193128
3573         rdar://34554231
3574
3575         Reviewed by Jer Noble.
3576
3577         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3578         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3579         event along with a flag that indicates whether or not autoplay was actually prevented.
3580
3581         Tests: existing API tests were updated to reflect the new names. New API tests
3582         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3583
3584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3585         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3586         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3587         (TEST):
3588         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3589         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3590
3591 2019-01-04  Chris Dumez  <cdumez@apple.com>
3592
3593         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3594         https://bugs.webkit.org/show_bug.cgi?id=193120
3595
3596         Reviewed by Alex Christensen.
3597
3598         Add API test coverage.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3601
3602 2019-01-04  Chris Dumez  <cdumez@apple.com>
3603
3604         Crash under WebProcessPool::addSuspendedPage()
3605         https://bugs.webkit.org/show_bug.cgi?id=193110
3606
3607         Reviewed by Youenn Fablet.
3608
3609         Add API test coverage.
3610
3611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3612
3613 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3614
3615         [ews-build] Check patch relevance before applying the patch
3616         https://bugs.webkit.org/show_bug.cgi?id=193102
3617
3618         Reviewed by Lucas Forschler.
3619
3620         * BuildSlaveSupport/ews-build/factories.py:
3621         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3622
3623 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3624
3625         [ews-build] Check patch relevance step should print patch id
3626         https://bugs.webkit.org/show_bug.cgi?id=193137
3627
3628         Reviewed by Lucas Forschler.
3629
3630         * BuildSlaveSupport/ews-build/steps.py:
3631         (CheckPatchRelevance.start): Update the status to include patch id.
3632
3633 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3634
3635         webkitpy: Increase simulator teardown timeout
3636         https://bugs.webkit.org/show_bug.cgi?id=193141
3637         <rdar://problem/46174217>
3638
3639         Rubber-stamped by Aakash Jain.
3640
3641         * Scripts/webkitpy/xcode/simulated_device.py:
3642         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3643
3644 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3645
3646         test262-runner misbehaves when test file YAML has a trailing space
3647         https://bugs.webkit.org/show_bug.cgi?id=193053
3648
3649         Reviewed by Yusuke Suzuki.
3650
3651         * Scripts/test262/Runner.pm:
3652         (parseData):
3653         Accept trailing space when parsing a test file's YAML block.
3654
3655 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3656
3657         UserMedia test should use WKPageNavigationClient
3658         https://bugs.webkit.org/show_bug.cgi?id=192913
3659
3660         Reviewed by Youenn Fablet.
3661
3662         The test currently uses the deprecated WKPageLoaderClient. It should use
3663         WKPageNavigationClient instead, which provides the same callback under a similar name.
3664
3665         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3666         (TestWebKitAPI::TEST):
3667
3668 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3669
3670         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3671         https://bugs.webkit.org/show_bug.cgi?id=192944
3672
3673         Reviewed by Tim Horton.
3674
3675         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3676         (TestWebKitAPI::TEST):
3677
3678 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3679
3680         Add support for using the current text selection as the find string on iOS
3681         https://bugs.webkit.org/show_bug.cgi?id=193034
3682         <rdar://problem/45138739>
3683
3684         Reviewed by Tim Horton.
3685
3686         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3687         _setStringForFind) works as expected.
3688
3689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3690         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3691
3692 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3693
3694         [ews-build] Use git on OpenSource EWS bots
3695         https://bugs.webkit.org/show_bug.cgi?id=193092
3696
3697         Reviewed by Lucas Forschler.
3698
3699         * BuildSlaveSupport/ews-build/steps.py:
3700         (CheckOutSource): Use git instead of svn.
3701         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3702
3703 2019-01-02  Daniel Bates  <dabates@apple.com>
3704
3705         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3706         https://bugs.webkit.org/show_bug.cgi?id=193023
3707
3708         Reviewed by Simon Fraser.
3709
3710         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3711         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3712         enumerator values. We should just remove this code.
3713
3714         * lldb/lldb_webkit.py:
3715         (WTFOptionSetProvider.has_children):
3716         (WTFOptionSetProvider.num_children):
3717         (WTFOptionSetProvider.get_child_index):
3718         (WTFOptionSetProvider.get_child_at_index):
3719
3720 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3721
3722         .ycm_extra_conf.py should handle XXXInlines.h
3723         https://bugs.webkit.org/show_bug.cgi?id=193055
3724
3725         Reviewed by Carlos Garcia Campos.
3726
3727         compile_commands.json database only records flags and options for cpp source files.
3728         So, when we open headers, this database does not have any information for that.
3729         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3730         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3731         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3732         we attempt to find XXX.cpp and use the configuration if it exists.
3733
3734         * gtk/ycm_extra_conf.py:
3735         (getImplementationFilename):
3736         (FlagsForFile):
3737
3738 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3739
3740         Unreviewed. Support PHP 7.3 in Debian.
3741
3742         Add 7.3 to the list of php versions supported in Debian.
3743
3744         * Scripts/webkitpy/port/base.py:
3745         (Port._debian_php_version):
3746
3747 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3748
3749         Resurrect Mac CMake build
3750         https://bugs.webkit.org/show_bug.cgi?id=192658
3751
3752         Reviewed by Yusuke Suzuki.
3753
3754         * DumpRenderTree/PlatformMac.cmake:
3755         * MiniBrowser/mac/CMakeLists.txt:
3756         * TestWebKitAPI/PlatformMac.cmake:
3757
3758 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3759
3760         [Tools] Remove references to Bison and Flex
3761         https://bugs.webkit.org/show_bug.cgi?id=193033
3762
3763         Reviewed by Michael Catanzaro.
3764
3765         The Bison and Flex tools are not needed anymore since r209883.
3766
3767         * CygwinDownloader/cygwin-downloader.py:
3768         * EWSTools/ubuntu-ews-packages:
3769         * Scripts/filter-build-webkit:
3770         (shouldIgnoreLine):
3771         * gtk/install-dependencies:
3772         * wpe/install-dependencies:
3773
3774 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3775
3776         WebDriver: warn about non existing tests when parsing expectations
3777         https://bugs.webkit.org/show_bug.cgi?id=192979
3778
3779         Reviewed by Michael Catanzaro.
3780
3781         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3782         renamed.
3783
3784         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3785         (WebDriverTestRunner.__init__):
3786
3787 2018-12-21  Chris Dumez  <cdumez@apple.com>
3788
3789         navigator.userAgent in service workers does not reflect customUserAgent set by client
3790         https://bugs.webkit.org/show_bug.cgi?id=192951
3791
3792         Reviewed by Youenn Fablet.
3793
3794         Extend API test coverage.
3795
3796         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3797         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3798         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3799         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3800         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3801
3802 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3803
3804         [WebAuthN] userPresence should always be true
3805         https://bugs.webkit.org/show_bug.cgi?id=192835
3806         <rdar://problem/46538788>
3807
3808         Reviewed by Brent Fulgham.
3809
3810         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3811         (TestWebKitAPI::TEST):
3812
3813 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3814
3815         Add support to run-benchmark to use non-default copies of the browser apps
3816         https://bugs.webkit.org/show_bug.cgi?id=192905
3817         rdar://problem/46845840
3818
3819         Reviewed by Dewei Zhu.
3820         
3821         Add support for a --browser-path argument to run-benchmark, which allows you to use
3822         a custom app bundle for a given browser (only implemented for Safari at present).
3823
3824         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3825         (BenchmarkRunner.__init__):
3826         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3827         (BrowserDriver.__init__):
3828         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3829         (BrowserDriverFactory.create):
3830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3831         (OSXBrowserDriver._launch_process):
3832         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3833         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3834         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3835         (OSXChromeCanaryDriver.launch_url):
3836         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3837         (OSXFirefoxNightlyDriver.launch_url):
3838         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3839         (OSXSafariDriver.__init__):
3840         (OSXSafariDriver.launch_url):
3841         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3842         (parse_args):
3843         (run_benchmark_plan):
3844         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3845         (WebServerBenchmarkRunner.__init__):
3846         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3847         (FakeBenchmarkRunner.__init__):
3848
3849 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3850
3851         [WebAuthN] Import an APDU coder from Chromium
3852         https://bugs.webkit.org/show_bug.cgi?id=192949
3853         <rdar://problem/46879933>
3854
3855         Reviewed by Brent Fulgham.
3856
3857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3858         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3859         (TestWebKitAPI::TEST):
3860
3861 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3862
3863         Setting the file wrapper and content type of an attachment to a PDF should update its image
3864         https://bugs.webkit.org/show_bug.cgi?id=192984
3865         <rdar://problem/46798028>
3866
3867         Reviewed by Tim Horton.
3868
3869         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3870         PDF data correctly updates the image element.
3871
3872         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3873
3874 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3875
3876         Add JSCOnly to bot dashboard
3877         https://bugs.webkit.org/show_bug.cgi?id=192964
3878
3879         Reviewed by Alexey Proskuryakov.
3880
3881         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3882         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3883         useful if they were not so secret, so add them.
3884
3885         There appear to be no build-only bots, so the first column is blank. And of course there are
3886         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3887         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3888         and there's plenty of room in the final column for all the bots.
3889
3890         I had a hard time picking a logo to use, because the JavaScript language does not have an
3891         official logo. But I believe I've found one that will be satisfactory.
3892
3893         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3894
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3898         (BubbleQueueServer):
3899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3901         (WebKitBuildbot):
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3903         (table.queue-grid tr.platform.linux-jsconly img.logo):
3904
3905 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3906
3907         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3908         https://bugs.webkit.org/show_bug.cgi?id=192821
3909
3910         Reviewed by Chris Dumez.
3911
3912         * DumpRenderTree/mac/DumpRenderTree.mm:
3913         (createWebViewAndOffscreenWindow):
3914         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3915
3916 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3917
3918         [Win][Clang] Fix compilation warnings of DumpRenderTree
3919         https://bugs.webkit.org/show_bug.cgi?id=192924
3920
3921         Reviewed by Alex Christensen.
3922
3923         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3924         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3925         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3926         * DumpRenderTree/win/DumpRenderTree.cpp:
3927         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3928         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3929         object to the argument of setDefaultTextEncodingName instead of a
3930         const string literal.
3931         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3932         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3933         (setCacheFolder): Deleted.
3934         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3935         * DumpRenderTree/win/EditingDelegate.cpp:
3936         (dump): Use %d for int.
3937         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3938         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3939         (BSTRFromString): Deleted unused function.
3940         * DumpRenderTree/win/TestRunnerWin.cpp:
3941         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3942         the arguemnt of setQuota instead of const string literal.
3943         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3944         (jsStringRefToWString): Deleted unused function.
3945
3946 2018-12-20  Chris Dumez  <cdumez@apple.com>
3947
3948         Add API test coverage for customUserAgent client setting and service workers
3949         https://bugs.webkit.org/show_bug.cgi?id=192952
3950
3951         Reviewed by Alex Christensen.
3952
3953         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3954         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3955         (-[SWSchemes webView:startURLSchemeTask:]):
3956         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3957         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3958
3959 2018-12-20  Chris Dumez  <cdumez@apple.com>
3960
3961         Use Optional::hasValue() instead of Optional::has_value()
3962         https://bugs.webkit.org/show_bug.cgi?id=192948
3963
3964         Reviewed by Tim Horton.
3965
3966         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3967         (TestWebKitAPI::TEST):
3968         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3969         (TestWebKitAPI::TEST):
3970         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3971         (TestWebKitAPI::TEST_F):
3972
3973 2018-12-20  Chris Dumez  <cdumez@apple.com>
3974
3975         Add style script rule to check for uses of std::optional<>
3976         https://bugs.webkit.org/show_bug.cgi?id=192931
3977
3978         Reviewed by Tim Horton.
3979
3980         * Scripts/webkitpy/style/checkers/cpp.py:
3981         (check_wtf_optional):
3982         (check_style):
3983
3984 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3985
3986         [WebAuthN] Add a runtime flag for local authenticator
3987         https://bugs.webkit.org/show_bug.cgi?id=192792
3988         <rdar://problem/46798738>
3989
3990         Reviewed by Brent Fulgham.
3991
3992         * DumpRenderTree/TestOptions.cpp:
3993         (TestOptions::TestOptions):
3994         * DumpRenderTree/TestOptions.h:
3995         * DumpRenderTree/mac/DumpRenderTree.mm:
3996         (enableExperimentalFeatures):
3997         (setWebPreferencesForTestOptions):
3998         * WebKitTestRunner/TestController.cpp:
3999         (WTR::TestController::resetPreferencesToConsistentValues):
4000         (WTR::updateTestOptionsFromTestHeader):
4001         * WebKitTestRunner/TestOptions.h:
4002         (WTR::TestOptions::hasSameInitializationOptions const):
4003
4004 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4005
4006         webkitpy: Autoinstall package URLs have changed
4007         https://bugs.webkit.org/show_bug.cgi?id=192909
4008         <rdar://problem/46860359>
4009
4010         Rubber-stamped by Alexey Proskuryakov.
4011
4012         PyPi urls have been moved around, we need to update our auto-installed packages.
4013
4014         We should check for Selenium before asking PyPi for the latest version.
4015
4016         * Scripts/webkitpy/thirdparty/__init__.py:
4017         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4018         (AutoinstallImportHook._install_keyring): Ditto.
4019         (AutoinstallImportHook._install_pep8): Ditto.
4020         (AutoinstallImportHook._install_mozlog): Ditto.
4021         (AutoinstallImportHook._install_mozprocess): Ditto.
4022         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4023         (AutoinstallImportHook._install_pytest): Ditto.
4024         (AutoinstallImportHook._install_pylint): Ditto.
4025         (AutoinstallImportHook._install_buildbot): Ditto.
4026         (AutoinstallImportHook._install_coverage): Ditto.
4027         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4028         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4029         for new Selenium if the installed version isn't sufficient.
4030         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4031
4032 2018-12-20  Chris Dumez  <cdumez@apple.com>
4033
4034         Use Optional::valueOr() instead of Optional::value_or()
4035         https://bugs.webkit.org/show_bug.cgi?id=192933
4036
4037         Reviewed by Geoffrey Garen.
4038
4039         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4040         (TestWebKitAPI::checkURL):
4041         (TestWebKitAPI::checkRelativeURL):
4042         (TestWebKitAPI::checkURLDifferences):
4043         (TestWebKitAPI::checkRelativeURLDifferences):
4044         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4045         (TestWebKitAPI::checkURL):
4046
4047 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4048
4049         Unreviewed, rolling out r239417.
4050
4051         Introduced two API test failures on macOS.
4052
4053         Reverted changeset:
4054
4055         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4056         occlusion changes"
4057         https://bugs.webkit.org/show_bug.cgi?id=192821
4058         https://trac.webkit.org/changeset/239417
4059
4060 2018-12-20  Devin Rousso  <drousso@apple.com>
4061
4062         Web Inspector: UIString should take an optional key and description to aid localization
4063         https://bugs.webkit.org/show_bug.cgi?id=153962
4064         <rdar://problem/24542505>
4065
4066         Reviewed by Brian Burg.
4067
4068         * Scripts/extract-localizable-js-strings:
4069
4070 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4071
4072         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4073         https://bugs.webkit.org/show_bug.cgi?id=192923
4074         <rdar://problem/46859068>
4075
4076         Reviewed by Wenson Hsieh.
4077
4078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4079         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4080         Add a test ensuring that both parented and unparented WKWebViews can
4081         retrieve main resource data when loading a PDF.
4082
4083 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4084
4085         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4086         https://bugs.webkit.org/show_bug.cgi?id=192852
4087
4088         Reviewed by Michael Catanzaro.
4089
4090         EmojiOne font was replaced by Noto Color Emoji.
4091
4092         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4093         * gtk/jhbuild.modules:
4094         * wpe/jhbuild.modules:
4095
4096 2018-12-19  Chris Dumez  <cdumez@apple.com>
4097
4098         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4099         https://bugs.webkit.org/show_bug.cgi?id=192728
4100         <rdar://problem/46746779>
4101
4102         Reviewed by Geoff Garen.
4103
4104         * DumpRenderTree/*:
4105         * MiniBrowser/*:
4106         * TestRunnerShared/*:
4107         * TestWebKitAPI/*:
4108         * WebGPUAPIStructure/*:
4109         * WebKitTestRunner/*:
4110
4111 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4112
4113         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4114         https://bugs.webkit.org/show_bug.cgi?id=192821
4115
4116         Reviewed by Chris Dumez.
4117
4118         * DumpRenderTree/mac/DumpRenderTree.mm:
4119         (createWebViewAndOffscreenWindow):
4120
4121 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4122
4123         Navigations away from the SafeBrowsing interstitial show a flash of old content
4124         https://bugs.webkit.org/show_bug.cgi?id=192676
4125
4126         Reviewed by Chris Dumez.
4127
4128         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4129         (safeBrowsingView):
4130         (TEST):
4131         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4132
4133 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4134
4135         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4136         https://bugs.webkit.org/show_bug.cgi?id=192855
4137
4138         Reviewed by Michael Catanzaro.
4139
4140         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4141         (WTR::TestController::notifyDone): Use the WPE implementation.
4142         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4143         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4144         (WTR::TestController::platformRunUntil): Honor the condition flag.
4145
4146 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4147
4148         Allow clients to set the navigator platform
4149         https://bugs.webkit.org/show_bug.cgi?id=192735
4150
4151         Reviewed by Tim Horton.
4152
4153         Add a test for setting a custom navigator platform.
4154
4155         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4156         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4157         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
4158
4159 2018-12-19  Truitt Savell  <tsavell@apple.com>
4160
4161         Unreviewed, rolling out r239358.
4162
4163         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
4164         crash on Debug bots
4165
4166         Reverted changeset:
4167
4168         "Clean up IndexedDB files between tests"
4169         https://bugs.webkit.org/show_bug.cgi?id=192796
4170         https://trac.webkit.org/changeset/239358
4171
4172 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4173
4174         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
4175         https://bugs.webkit.org/show_bug.cgi?id=192842
4176         <rdar://problem/46823586>
4177
4178         Reviewed by Tim Horton.
4179
4180         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
4181         item provider when dragging a rich text selection.
4182
4183         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4184
4185 2018-12-18  David Quesada  <david_quesada@apple.com>
4186
4187         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
4188         https://bugs.webkit.org/show_bug.cgi?id=192810
4189         <rdar://problem/46812536>
4190
4191         Reviewed by Alex Christensen.
4192
4193         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4194         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4195             After releasing our reference to the web view, wait until the next turn of the runloop
4196             before checking that the originatingWebView has been zeroed, since the web view might
4197             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
4198             testing general memory management of WKWebViews, only that _WKDownload does not retain
4199             its web view via the 'originatingWebView' property.
4200
4201 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
4202
4203         Clean up IndexedDB files between tests
4204         https://bugs.webkit.org/show_bug.cgi?id=192796
4205
4206         Reviewed by Geoffrey Garen.
4207
4208         * DumpRenderTree/mac/DumpRenderTree.mm:
4209         (runTest):
4210         * WebKitTestRunner/TestController.cpp:
4211         (WTR::TestController::resetStateToConsistentValues):
4212         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4213         (WTR::RemoveAllIndexedDatabasesCallback):
4214         (WTR::TestController::ClearIndexedDatabases):
4215         * WebKitTestRunner/TestController.h:
4216
4217 2018-12-18  Alex Christensen  <achristensen@webkit.org>
4218
4219         Fix API test introduced in r239339 on iOS.
4220         https://bugs.webkit.org/show_bug.cgi?id=192675
4221
4222         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4223         (TEST):
4224         The iOS implementation of the safe browsing warning is a little different.
4225         It does some element creation when it is added to the window so it knows how big it is.
4226         To test these elements, we need to simulate adding it to the window.
4227         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
4228
4229 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
4230
4231         webkitpy: Ignore device type for test when using --force
4232         https://bugs.webkit.org/show_bug.cgi?id=192786
4233         <rdar://problem/46794894>
4234
4235         Reviewed by Daniel Bates.
4236
4237         It is sometimes the case that a contributor will wish to run a test on a specific device,
4238         despite expectations which indicate a test should not be run on that device.
4239
4240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4241         (parse_args):
4242         * Scripts/webkitpy/port/device_port.py:
4243         (DevicePort.default_child_processes): Strip device type information when using --force.
4244         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
4245
4246 2018-12-18  Alex Christensen  <achristensen@webkit.org>
4247
4248         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
4249         https://bugs.webkit.org/show_bug.cgi?id=192675
4250
4251         Reviewed by Geoffrey Garen.
4252
4253         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4254         (goBack):
4255         (TEST):
4256         (visitUnsafeSite):
4257         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
4258         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4259
4260 2018-12-18  Chris Dumez  <cdumez@apple.com>
4261
4262         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
4263         https://bugs.webkit.org/show_bug.cgi?id=192772
4264
4265         Reviewed by Antti Koivisto.
4266
4267         Add API test coverage.
4268
4269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4270
4271 2018-12-18  Philippe Normand  <pnormand@igalia.com>
4272
4273         Unreviewed, JHBuild GTK build fix attempt
4274
4275         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
4276         There's no ninja module either, it should be provided by the
4277         host system.
4278
4279 2018-12-17  Chris Dumez  <cdumez@apple.com>
4280
4281         Allow passing nil as session state to [WKWebView _restoreSessionState:]
4282         https://bugs.webkit.org/show_bug.cgi?id=192789
4283         <rdar://problem/46755277>
4284
4285         Reviewed by Alex Christensen.
4286
4287         Add API test coverage.