[Mac] REGRESSION: Auto substitution strips new lines
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         [Mac] REGRESSION: Auto substitution strips new lines
4         https://bugs.webkit.org/show_bug.cgi?id=114537
5
6         Reviewed by Enrica Casucci.
7
8         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
9
10         * DumpRenderTree/mac/DumpRenderTree.mm:
11         (resetDefaultsToConsistentValues):
12
13 2013-04-09  Roger Fong  <roger_fong@apple.com>
14
15         Re-enable WinEWS tests.
16
17         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
18         (WinEWS):
19
20 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
21
22         [GTK] Split GtkAuthenticationDialog in two widgets
23         https://bugs.webkit.org/show_bug.cgi?id=103644
24
25         Reviewed by Xan Lopez.
26
27         * gtk/generate-gtkdoc:
28         (get_webkit2_options): Do not generate api docs for
29         WebKitAuthenticationDialog which is private in WebKit2.
30         (get_webkit1_options): Do not generate api docs for
31         webkitauthenticationdialog which is private in WebKit1.
32
33 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
34
35         WebKit Queues should capitalize K in Wk2
36         https://bugs.webkit.org/show_bug.cgi?id=114524
37
38         Reviewed by Philippe Normand.
39
40         * QueueStatusServer/model/queues.py:
41         (Queue.display_name):
42
43 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
44
45         [Mac] Enable spellchecking tests added in r141471
46         https://bugs.webkit.org/show_bug.cgi?id=108525
47
48         Reviewed by Darin Adler.
49
50         * DumpRenderTree/mac/DumpRenderTree.mm:
51         (createWebViewAndOffscreenWindow):
52         (resetDefaultsToConsistentValues):
53         * WebKitTestRunner/TestController.cpp:
54         (WTR::TestController::resetStateToConsistentValues):
55
56 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
57
58         [GTK] Enable WebKit2 building on GTK EWSs
59         https://bugs.webkit.org/show_bug.cgi?id=114500
60
61         Reviewed by Philippe Normand.
62
63         Add configuration in order to be able to setup GTK EWSs building
64         WebKit2. A new queue gtk-wk2-ews is added.
65
66         * QueueStatusServer/config/queues.py:
67         * Scripts/webkitpy/common/config/ports.py:
68         (DeprecatedPort.port):
69         (GtkWK2Port):
70         (GtkWK2Port.build_webkit_command):
71         (GtkWK2Port.run_webkit_tests_command):
72         * Scripts/webkitpy/common/config/ports_unittest.py:
73         (DeprecatedPortTest.test_gtk_port):
74         (DeprecatedPortTest):
75         (DeprecatedPortTest.test_gtk_wk2_port):
76         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
77         (GtkWK2EWS):
78
79 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
80
81         Remove Chromium scripts
82         https://bugs.webkit.org/show_bug.cgi?id=114492
83
84         Reviewed by Benjamin Poulain.
85
86         * Scripts/run-chromium-webkit-unit-tests: Removed.
87         * Scripts/update-webkit-chromium: Removed.
88
89 2013-04-12  Commit Queue  <rniwa@webkit.org>
90
91         Unreviewed, rolling out r148262.
92         http://trac.webkit.org/changeset/148262
93         https://bugs.webkit.org/show_bug.cgi?id=114493
94
95         Cairo dep should now build, rolling r148247 back in (Requested
96         by zdobersek on #webkit).
97
98         * Scripts/webkitdirs.pm:
99         (buildAutotoolsProject):
100         * gtk/jhbuild.modules:
101
102 2013-04-11  Commit Queue  <rniwa@webkit.org>
103
104         Unreviewed, rolling out r148247.
105         http://trac.webkit.org/changeset/148247
106         https://bugs.webkit.org/show_bug.cgi?id=114490
107
108         Cairo dep fails to build on builders due to missing EGL
109         headers (Requested by zdobersek on #webkit).
110
111         * Scripts/webkitdirs.pm:
112         (buildAutotoolsProject):
113         * gtk/jhbuild.modules:
114
115 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
116
117         [GTK] Add accelerated 2D canvas support using cairo-gl
118         https://bugs.webkit.org/show_bug.cgi?id=104672
119
120         Reviewed by Alejandro G. Castro.
121
122         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
123         dependencies, don't override value of the setting determined by configure.
124         This will make it easier for people using build-webkit, but not the
125         WebKit JHBuild.
126
127         * Scripts/webkitdirs.pm:
128         (buildAutotoolsProject): Add a blacklist for settings to never override.
129         * gtk/jhbuild.modules: Build CairoGL.
130
131 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
132
133         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
134         https://bugs.webkit.org/show_bug.cgi?id=114477
135
136         Reviewed by Benjamin Poulain.
137
138         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
139
140 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
141
142         Leaks builder should not be triggered upon new commits
143         https://bugs.webkit.org/show_bug.cgi?id=114475
144
145         Reviewed by Jessie Berlin.
146
147         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
148         the leak builder when builds are done.
149
150         * BuildSlaveSupport/build.webkit.org-config/config.json:
151
152 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
153
154         [GTK] Windows build failure after r136056
155         https://bugs.webkit.org/show_bug.cgi?id=114121
156
157         Reviewed by Martin Robinson.
158
159         * TestWebKitAPI/config.h: Make sure defines are correct for other
160         Windows ports than apple-win.
161
162 2013-04-11  Ojan Vafai  <ojan@chromium.org>
163
164         Remove myself from watchlists.
165         * Scripts/webkitpy/common/config/watchlist:
166
167 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
168
169         Build fix. Don't hard-code queues.webkit.org at least during the transition.
170
171         * QueueStatusServer/templates/statusbubble.html:
172
173 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
174
175         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
176         https://bugs.webkit.org/show_bug.cgi?id=114397
177
178         Reviewed by Benjamin Poulain.
179
180         Reland the patch since Alan appears to have finished the migration.
181
182         * Scripts/webkitpy/common/net/statusserver.py:
183         (StatusServer):
184
185 2013-04-11  Brian Holt  <brian.holt@samsung.com>
186
187         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
188         https://bugs.webkit.org/show_bug.cgi?id=76796
189
190         Reviewed by Chris Fleizach.
191
192         Make the Gtk window for the DRT a toplevel so that it gets the
193         focus from the window manager when the test starts.
194
195         * DumpRenderTree/gtk/DumpRenderTree.cpp:
196         (main):
197
198 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
199
200         Use CSS4 image-rendering to determing image scaling quality
201         https://bugs.webkit.org/show_bug.cgi?id=113405
202
203         Reviewed by Simon Fraser.
204
205         Introduce new flag to enable experimental support for CSS4 Images.
206
207         * Scripts/webkitperl/FeatureList.pm:
208
209 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
210
211         Remove code for Chromium from wkbuild.py
212         https://bugs.webkit.org/show_bug.cgi?id=114423
213
214         Reviewed by Benjamin Poulain.
215
216         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
217         (_should_file_trigger_build):
218         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
219         (ShouldBuildTest):
220
221 2013-04-11  Philippe Normand  <pnormand@igalia.com>
222
223         Unreviewed, update my IRC nickname.
224
225         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
226
227 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
228
229         Remove the rest of Chromium code from webkitpy
230         https://bugs.webkit.org/show_bug.cgi?id=114420
231
232         Reviewed by Benjamin Poulain.
233
234         * Scripts/webkitpy/common/config/urls.py:
235         (view_revision_url):
236         * Scripts/webkitpy/common/host.py:
237         (Host._engage_awesome_locale_hacks):
238         (Host.initialize_scm):
239         (Host):
240         * Scripts/webkitpy/common/host_mock.py:
241         (MockHost.__init__):
242         (MockHost.checkout):
243         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
244         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
245         (JSONResultsGeneratorBase._insert_generic_metadata):
246         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
247         (TestExpectationParser._tokenize_line):
248         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
249         (ExpectationSyntaxTests.test_bare_name_and_bugs):
250         (ExpectationSyntaxTests.test_warnings):
251         * Scripts/webkitpy/layout_tests/port/base.py:
252         (Port.skips_perf_test):
253         (Port.path_to_test_expectations_file):
254         (Port._port_flag_for_scripts):
255         * Scripts/webkitpy/style/checkers/cpp.py:
256         (check_function_definition):
257         (check_include_line):
258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
259         (OrderOfIncludesTest.test_check_wtf_includes):
260         (WebKitStyleTest.test_webkit_export_check):
261         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
262         (TestExpectationsTestCase.test_valid_expectations):
263         * Scripts/webkitpy/tool/bot/irc_command.py:
264         (Rollout.execute):
265         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
266         (IRCCommandTest.test_whois):
267         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
268         (IRCBotTest.test_help):
269         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
270         (SheriffBotTest.test_command_aliases):
271
272 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
273
274         roll-chromium-deps doesn't roll DEPS
275         https://bugs.webkit.org/show_bug.cgi?id=114421
276
277         Reviewed by Antti Koivisto.
278
279         Roll DEPS. Rolling DEPS. Rolled DEPS.
280
281         * Scripts/webkitpy/tool/bot/irc_command.py:
282         (RollChromiumDEPS.execute):
283
284 2013-04-11  Glenn Adams  <glenn@skynav.com>
285
286         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
287         https://bugs.webkit.org/show_bug.cgi?id=114418
288
289         Reviewed by Ryosuke Niwa.
290
291         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
292         (MockSCM.add): Remove optional remove_exit_code argument.
293         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
294         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
295         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
296         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
297
298 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
299
300         Fix roll-chromium-deps and hi.
301
302         * Scripts/webkitpy/tool/bot/irc_command.py:
303         (Hi.execute):
304         (RollChromiumDEPS.execute):
305
306 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
307
308         Remove webkitpy code to roll Chromium DEPS
309         https://bugs.webkit.org/show_bug.cgi?id=114415
310
311         Reviewed by Benjamin Poulain.
312
313         Removed the code to roll Chromium DEPS in WebKit.
314
315         * Scripts/webkitpy/common/checkout/checkout.py:
316         (Checkout.bug_id_for_this_commit):
317         * Scripts/webkitpy/common/checkout/checkout_mock.py:
318         (MockCheckout.commit_message_for_this_commit):
319         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
320         (CheckoutTest.test_suggested_reviewers):
321         * Scripts/webkitpy/common/checkout/deps.py: Removed.
322         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
323         * Scripts/webkitpy/tool/bot/irc_command.py:
324         (RollChromiumDEPS): Teach webkitbot a sense of humor.
325         (RollChromiumDEPS.execute):
326         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
327         (IRCCommandTest.test_create_bug):
328         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
329         (IRCBotTest.test_revert):
330         * Scripts/webkitpy/tool/bot/sheriff.py:
331         (Sheriff.post_rollout_patch):
332         * Scripts/webkitpy/tool/commands/__init__.py:
333         * Scripts/webkitpy/tool/commands/roll.py: Removed.
334         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
335         * Scripts/webkitpy/tool/steps/__init__.py:
336         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
337         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
338         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
339
340 2013-04-11  Glenn Adams  <glenn@skynav.com>
341
342         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
343         https://bugs.webkit.org/show_bug.cgi?id=114386
344
345         Reviewed by Benjamin Poulain.
346
347         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
348         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
349         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
350         by default and to return exit code 1 if a file/dir had already been added.
351
352         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
353         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
354         * Scripts/webkitpy/common/checkout/scm/svn.py:
355         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
356
357 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
358
359         Unreviewed.
360
361         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
362
363 2013-04-10  Glenn Adams  <glenn@skynav.com>
364
365         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
366         https://bugs.webkit.org/show_bug.cgi?id=114410
367
368         Reviewed by Ryosuke Niwa.
369
370         * Scripts/webkitpy/common/checkout/scm/git.py:
371         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
372         * Scripts/webkitpy/common/checkout/scm/scm.py:
373         (SCM.add): Remove optional return_exit_code argument.
374         (SCM.add_list): Remove optional return_exit_code argument.
375         * Scripts/webkitpy/common/checkout/scm/svn.py:
376         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
377
378 2013-04-10  Eric Seidel  <eric@webkit.org>
379
380         Remove myself from the watchlists, I'm getting too much bug mail. :)
381
382         * Scripts/webkitpy/common/config/watchlist:
383
384 2013-04-10  Commit Queue  <rniwa@webkit.org>
385
386         Unreviewed, rolling out r148158.
387         http://trac.webkit.org/changeset/148158
388         https://bugs.webkit.org/show_bug.cgi?id=114405
389
390         We need to migrate status data (Requested by rniwa on
391         #webkit).
392
393         * Scripts/webkitpy/common/net/statusserver.py:
394         (StatusServer):
395
396 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
397
398         Mass remove all the empty directories
399
400         Rubberstamped by Ryosuke Niwa.
401
402         * BuildSlaveSupport/gtk/crashmon/log: Removed.
403         * BuildSlaveSupport/gtk/xvfb/log: Removed.
404         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
405         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
406         * MiniBrowser/gtk/WebBundle: Removed.
407         * MiniBrowser/win: Removed.
408         * QtTestPlatformPlugin/mac: Removed.
409         * Scripts/webkitpy/tool/bot/testdata: Removed.
410         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
411         * efl/ImageDiff: Removed.
412         * iExploder/htdocs: Removed.
413         * iExploder/iexploder-1.7.2/output: Removed.
414         * iExploder/tools: Removed.
415         * qmake/config.tests/libexecdir: Removed.
416         * qmake/config.tests/libjpeg: Removed.
417         * qmake/config.tests/libpng: Removed.
418
419 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
420
421         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
422         https://bugs.webkit.org/show_bug.cgi?id=114397
423
424         Reviewed by Benjamin Poulain.
425
426         * Scripts/webkitpy/common/net/statusserver.py:
427         (StatusServer):
428
429 2013-04-10  Adam Barth  <abarth@webkit.org>
430
431         Remove abarth from watchlists
432         https://bugs.webkit.org/show_bug.cgi?id=114390
433
434         Reviewed by Ryosuke Niwa.
435
436         I'm trying to cut down on the amount of bugmail I get so that I'll have
437         more of a chance to notice a piece of bugmail directed at me.
438
439         * Scripts/webkitpy/common/config/watchlist:
440
441 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
442
443         webkit-test-results.appspot.com loads the dashboard for Chromium by default
444         https://bugs.webkit.org/show_bug.cgi?id=114381
445
446         Reviewed by Benjamin Poulain.
447
448         Changed the defaults.
449
450         * TestResultServer/static-dashboards/builders.js:
451         * TestResultServer/static-dashboards/dashboard_base.js:
452         (currentBuilderGroupCategory):
453
454 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
455
456         Remove Chromium EWS bots from the queue status server
457         https://bugs.webkit.org/show_bug.cgi?id=113988
458
459         Reviewed by Benjamin Poulain.
460
461         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
462
463         * QueueStatusServer/app.yaml:
464         * QueueStatusServer/config/queues.py:
465         * QueueStatusServer/model/queues.py:
466         (Queue.short_name):
467         (Queue.display_name):
468         * QueueStatusServer/model/queues_unittest.py:
469         (QueueTest.test_short_name):
470         (QueueTest.test_display_name):
471         (QueueTest.test_name_with_underscores):
472         * QueueStatusServer/templates/activebots.html:
473
474 2013-04-10  Ojan Vafai  <ojan@chromium.org>
475
476         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
477         https://bugs.webkit.org/show_bug.cgi?id=114370
478
479         Reviewed by Ryosuke Niwa.
480
481         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
482         Unfortunately, there's no way to test this until this is committed and there is
483         a master restart.
484
485         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
491         * TestResultServer/generate_builders_json.py:
492         * TestResultServer/static-dashboards/dashboard_base.js:
493         * TestResultServer/static-dashboards/loader.js:
494
495 2013-04-10  Glenn Adams  <glenn@skynav.com>
496
497         [Qt] Fix regression to test-webkitpy.
498         https://bugs.webkit.org/show_bug.cgi?id=114368
499
500         Reviewed by Ryosuke Niwa.
501
502         * Scripts/webkitpy/layout_tests/port/factory.py:
503         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
504         (PortFactory.get): Remove obsolete chromium port related code.
505         * Scripts/webkitpy/layout_tests/port/mac.py:
506         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
507
508 2013-04-10  Anders Carlsson  <andersca@apple.com>
509
510         Remove unneeded headers from FrameLoader.h
511         https://bugs.webkit.org/show_bug.cgi?id=114223
512
513         Reviewed by Geoffrey Garen.
514
515         Add back headers implicitly included by other headers.
516
517         * WebKitTestRunner/WorkQueueManager.cpp:
518
519 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
520
521         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
522         https://bugs.webkit.org/show_bug.cgi?id=114365
523
524         Reviewed by Martin Robinson.
525
526         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
527         The patch addresses crashes in the tally_event_reply method. It is already committed into the
528         at-spi2-atk source tree and will be available with the next stable release, after which the
529         patch should be removed and the dependency version bumped.
530
531         * gtk/jhbuild.modules:
532         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
533
534 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
535
536         [WinCairo] Unreviewed build fix. Correct DropBox download link.
537
538         * Scripts/update-webkit-wincairo-libs: Revise download URL to
539         match change in DropBox server behavior.
540
541 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
542
543         Removed an annoying message from svn-create-patch
544         https://bugs.webkit.org/show_bug.cgi?id=114332
545
546         Reviewed by Alexey Proskuryakov.
547
548         I see this message basically every time I write a patch, so it must not
549         be true.
550
551         * Scripts/svn-create-patch:
552         (generateDiff):
553
554 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
555
556         [GTK] Add support for Page Visibility
557         https://bugs.webkit.org/show_bug.cgi?id=97324
558
559         Reviewed by Sam Weinig.
560
561         Implemented test runner API for page visibility layout tests.
562
563         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
564         (TestRunner::resetPageVisibility):
565         (TestRunner::setPageVisibility):
566         * Scripts/webkitperl/FeatureList.pm:
567
568 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
569
570         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
571         https://bugs.webkit.org/show_bug.cgi?id=114342
572
573         Reviewed by Gyuyoung Kim.
574
575         Commit 148033 only added an implementation for the Mac port, which made
576         other ports fail most tests since loading the injected bundle failed
577         with a missing symbol.
578
579         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
580         (WTR::AccessibilityUIElement::pathDescription):
581
582 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
583
584         [EFL] Add spell checking option to MiniBrowser
585         https://bugs.webkit.org/show_bug.cgi?id=114282
586
587         Reviewed by Ryosuke Niwa.
588
589         Spell checking is enabled by adding a flag (t/text-checking)
590         with launching MiniBrowser.
591
592         * MiniBrowser/efl/main.c:
593         (window_create):
594         (elm_main):
595
596 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
597
598         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
599         https://bugs.webkit.org/show_bug.cgi?id=113281
600
601         Reviewed by Darin Adler.
602
603         * Scripts/run-gtk-tests:
604         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
605
606 2013-04-09  Glenn Adams  <glenn@skynav.com>
607
608         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
609
610         Unreviewed.
611
612         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
613         (RunTest.test_build_check):
614
615 2013-04-09  Glenn Adams  <glenn@skynav.com>
616
617         [webkitpy] Remove chromium ports.
618         https://bugs.webkit.org/show_bug.cgi?id=114326
619
620         Reviewed by Dirk Pranke.
621
622         As a side effect, also:
623
624         - remove chromium builders from webkitpy.layout_tests.port.builders
625         - remove chromium builders from rebaseline
626         - rewrite chromium dependent tests in rebaseline_unittest
627         - remove chromium platform from garden-o-matic
628         - select apple platform as default platform in garden-o-matic
629         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
630
631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
633         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
634         (BaselineOptimizerTest.test_move_baselines):
635         (BaselineOptimizerTest.test_efl):
636         (BaselineOptimizerTest.test_no_add_mac_future):
637         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
638         (BaselineOptimizerTest.test_common_directory_includes_root):
639         (BaselineOptimizerTest.test_complex_shadowing):
640         (BaselineOptimizerTest.test_virtual_ports_filtered):
641         * Scripts/webkitpy/layout_tests/port/builders.py:
642         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
643         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
644         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
645         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
646         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
647         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
648         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
649         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
650         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
651         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
652         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
653         * Scripts/webkitpy/layout_tests/port/factory.py:
654         (platform_options):
655         (PortFactory):
656         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
657         (FactoryTest.test_qt):
658         (FactoryTest.test_get_from_builder_name):
659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
660         (RunTest.test_build_check):
661         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
662         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
663         * Scripts/webkitpy/tool/commands/rebaseline.py:
664         (Rebaseline._builders_to_pull_from):
665         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
666         (_BaseTestCase):
667         (_BaseTestCase.setUp):
668         (TestRebaselineTest.setUp):
669         (TestRebaselineTest.test_baseline_directory):
670         (test_rebaseline_updates_expectations_file):
671         (test_rebaseline_does_not_include_overrides):
672         (test_rebaseline_test):
673         (test_rebaseline_test_and_print_scm_changes):
674         (test_rebaseline_and_copy_test):
675         (test_rebaseline_and_copy_test_no_existing_result):
676         (test_rebaseline_and_copy_test_with_lion_result):
677         (test_rebaseline_and_copy_no_overwrite_test):
678         (TestRebaselineExpectations.test_rebaseline_expectations):
679
680 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
681
682         newcommitbot (WKR) requires a subversion checkout
683         https://bugs.webkit.org/show_bug.cgi?id=114309
684
685         Reviewed by Benjamin Poulain.
686
687         Directly talk to the subversion server instead of relying on a local checkout.
688         This allows us to run WKR off of a git clone.
689
690         * Scripts/webkitpy/tool/commands/newcommitbot.py:
691         (NewCommitBot.next_work_item):
692         (NewCommitBot.process_work_item):
693
694 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
695
696         webkitbot refers to sheriffbot in help
697         https://bugs.webkit.org/show_bug.cgi?id=114307
698
699         Reviewed by Benjamin Poulain.
700
701         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
702
703         * Scripts/webkitpy/tool/bot/irc_command.py:
704         (Help):
705         (Help.execute):
706         (RollChromiumDEPS.execute):
707         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
708         (IRCBotTest.test_help):
709         * Scripts/webkitpy/tool/bot/sheriff.py:
710         (Sheriff.name):
711
712 2013-04-06  Roger Fong  <roger_fong@apple.com>
713
714         Kill old processes between runs on WinEWS bots.
715         Temporarily disable tests to let bots catch up again.
716
717         * EWSTools/start-queue-win.sh:
718         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
719         (WinEWS):
720
721 2013-04-09  Glenn Adams  <glenn@skynav.com>
722
723         [webkitpy] Remove chromium deprecated port support.
724         https://bugs.webkit.org/show_bug.cgi?id=114228
725
726         Reviewed by Ryosuke Niwa.
727
728         * Scripts/webkitpy/common/config/ports.py:
729         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
730         (ChromiumPort): Removed.
731         (ChromiumAndroidPort): Removed.
732         (ChromiumXVFBPort): Removed.
733         * Scripts/webkitpy/common/config/ports_unittest.py:
734         (DeprecatedPortTest.test_chromium_port): Removed.
735         (DeprecatedPortTest.test_chromium_android_port): Removed.
736         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
737         * Scripts/webkitpy/tool/steps/update_unittest.py:
738         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
739         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
740
741 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
742
743         AX: The bounding paths should be made available through accessibility
744         https://bugs.webkit.org/show_bug.cgi?id=113817
745
746         Reviewed by David Kilzer.
747
748         Add a pathDescription property for testing so that it's possible
749         to verify that a path is being returned correctly.
750
751         * DumpRenderTree/AccessibilityUIElement.cpp:
752         (getPathDescriptionCallback):
753         (AccessibilityUIElement::pathDescription):
754         (AccessibilityUIElement::getJSClass):
755         * DumpRenderTree/AccessibilityUIElement.h:
756         (AccessibilityUIElement):
757         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
758         (_CGPathEnumerationIteration):
759         (AccessibilityUIElement::pathDescription):
760         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
761         (AccessibilityUIElement::pathDescription):
762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
763         (WTR::AccessibilityUIElement::pathDescription):
764         (WTR):
765         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
766         (AccessibilityUIElement):
767         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
768         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
769         (WTR::AccessibilityUIElement::pathDescription):
770         (WTR):
771
772 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
773
774         [EFL] Declare TEST_THEME_DIR in a single place.
775         https://bugs.webkit.org/show_bug.cgi?id=114285
776
777         Reviewed by Anders Carlsson.
778
779         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
780
781         * DumpRenderTree/efl/CMakeLists.txt:
782         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
783         (DumpRenderTreeChrome::createView):
784         (DumpRenderTreeChrome::createInspectorView):
785         (DumpRenderTreeChrome::initialize):
786         (DumpRenderTreeChrome::onDownloadRequest):
787         * EWebLauncher/CMakeLists.txt:
788         * EWebLauncher/main.c:
789         (findThemePath):
790         * EWebLauncher/url_bar.c:
791         (url_bar_add):
792         * MiniBrowser/efl/CMakeLists.txt:
793         * MiniBrowser/efl/main.c:
794         (window_create):
795         * TestWebKitAPI/PlatformEfl.cmake:
796         * TestWebKitAPI/efl/PlatformWebView.cpp:
797         (TestWebKitAPI::PlatformWebView::PlatformWebView):
798         * WebKitTestRunner/PlatformEfl.cmake:
799         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
800         (WTR::PlatformWebView::PlatformWebView):
801
802 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
803
804         [GTK][AC] upversion of clutter and its dependecy
805         https://bugs.webkit.org/show_bug.cgi?id=114016
806
807         Reviewed by Gustavo Noronha Silva.
808
809         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
810
811         * gtk/jhbuild-optional.modules:
812
813 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
814
815         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
816         https://bugs.webkit.org/show_bug.cgi?id=89875
817
818         Reviewed by Maciej Stachowiak.
819
820         Add unit tests to verify if the handling of the open, openat, creat syscall
821         is being done right. We check if the Read/Write/ReadAndWrite permissions
822         are respected, if the canonical path is being resolved and if
823         the permissions are falling back to the topmost parent directory with a
824         policy set when the directory being opened has no policy.
825
826         We also test if any attempt of blocking SIGSYS is silently ignored.
827         SIGSYS cannot be blocked because in it's handler is where we hook
828         syscalls to the broker process.
829
830         Also added libseccomp to EFL's jhbuild to make the life of developers
831         willing to help easier.
832
833         * Scripts/webkitperl/FeatureList.pm:
834         * TestWebKitAPI/PlatformEfl.cmake:
835         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
836         (TestWebKitAPI):
837         (SeccompEnvironment):
838         (TestWebKitAPI::SeccompEnvironment::SetUp):
839         (TestWebKitAPI::SeccompEnvironment::TearDown):
840         (TestWebKitAPI::dummyHandler):
841         (TestWebKitAPI::TEST):
842         (TestWebKitAPI::stressTest):
843         * efl/jhbuild.modules:
844         * qmake/mkspecs/features/features.pri:
845
846 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
847
848         REGRESSION: Autocorrection doesn't work in DumpRenderTree
849         https://bugs.webkit.org/show_bug.cgi?id=113846
850
851         Reviewed by Alexey Proskuryakov.
852
853         The problem was that we were replacing NSSpellCheck's dictionary with our own
854         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
855
856         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
857         and "would" respectively in DumpRenderTree.
858
859         * DumpRenderTree/mac/DumpRenderTree.mm:
860         (resetDefaultsToConsistentValues):
861
862 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
863
864         Remove the gyp files for Tools
865         https://bugs.webkit.org/show_bug.cgi?id=114248
866
867         Reviewed by Ryosuke Niwa.
868
869         * DumpRenderTree/DumpRenderTree.gyp: Removed.
870         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
871         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
872         * DumpRenderTree/DumpRenderTree.gypi: Removed.
873         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
874         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
875         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
876         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
877
878 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
879
880         WKR (new-commit-bot) is too slow
881         https://bugs.webkit.org/show_bug.cgi?id=110087
882
883         Reviewed by Geoffrey Garen.
884
885         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
886         Just run "svn log -r <revision>" instead to cut down the delay.
887
888         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
889
890         * Scripts/webkitpy/tool/commands/newcommitbot.py:
891         (NewCommitBot):
892         (NewCommitBot.next_work_item):
893         (NewCommitBot._is_empty_log):
894         (NewCommitBot._update_checkout):
895
896 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
897
898         Build fix. Can't remove appendCustomBuildFlags.
899
900         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
901         (appendCustomBuildFlags):
902
903 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
904
905         Remove Chromium builders from build.webkit.org
906         https://bugs.webkit.org/show_bug.cgi?id=113990
907
908         Reviewed by Benjamin Poulain.
909
910         Removed.
911
912         * BuildSlaveSupport/build.webkit.org-config/config.json:
913         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
914         (InstallGtkDependencies):
915         (RunUnitTests.start):
916         (RunWebKit2Tests.start):
917         (Factory.__init__):
918         (unitTestsSupported):
919         (TestFactory.__init__):
920         (BuildAndTestFactory.__init__):
921         (BuildAndPerfTestFactory.__init__):
922         (BuildAndPerfTestWebKit2Factory.__init__):
923         (DownloadAndPerfTestFactory.__init__):
924         (loadBuilderConfig):
925         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
926
927 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
928
929         Remove HTML Notification
930         https://bugs.webkit.org/show_bug.cgi?id=114231
931
932         Reviewed by Ryosuke Niwa.
933
934         * qmake/mkspecs/features/features.pri:
935
936 2013-04-08  Glenn Adams  <glenn@skynav.com>
937
938         Remove chromium EWS support, and fix broken test.
939         https://bugs.webkit.org/show_bug.cgi?id=114221
940
941         Reviewed by Ryosuke Niwa.
942
943         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
944         (AbstractChromiumEWS): Removed.
945         (ChromiumLinuxEWS): Removed.
946         (ChromiumLinuxDebugEWS): Removed.
947         (ChromiumWindowsEWS): Removed.
948         (ChromiumAndroidEWS): Removed.
949         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
950         (EarlyWarningSystemTest): Fix misspelled class name.
951         (test_ewses): Fix entry point name to ensure test is run.
952
953 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
954
955         [WIN] Remove WebKit2 source code
956         https://bugs.webkit.org/show_bug.cgi?id=114096
957
958         Reviewed by Anders Carlsson.
959
960         Remove the windows specific parts of the MiniBrowser.
961
962         * MiniBrowser/MiniBrowser.vcproj: Removed.
963         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
964         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
965         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
966         * MiniBrowser/win/BrowserView.cpp: Removed.
967         * MiniBrowser/win/BrowserView.h: Removed.
968         * MiniBrowser/win/BrowserWindow.cpp: Removed.
969         * MiniBrowser/win/BrowserWindow.h: Removed.
970         * MiniBrowser/win/MiniBrowser.cpp: Removed.
971         * MiniBrowser/win/MiniBrowser.h: Removed.
972         * MiniBrowser/win/MiniBrowser.rc: Removed.
973         * MiniBrowser/win/main.cpp: Removed.
974         * MiniBrowser/win/resource.h: Removed.
975         * MiniBrowser/win/stdafx.cpp: Removed.
976         * MiniBrowser/win/stdafx.h: Removed.
977
978 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
979
980         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
981
982         * Scripts/webkitpy/common/config/irc.py:
983
984 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
985
986         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
987         https://bugs.webkit.org/show_bug.cgi?id=113139
988
989         Reviewed by Anders Carlsson.
990
991         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
992         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
993         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
994         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
995         (ToStringAndValueOfObject):
996         (ToStringAndValueOfObject::ToStringAndValueOfObject):
997         (ScriptableObject):
998         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
999         (ToStringAndValueOfObject::ScriptableObject::invoke):
1000         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
1001         (ToStringAndValueOfObject::NPP_GetValue):
1002         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1003         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1004         * GNUmakefile.am:
1005
1006 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
1007
1008         [GTK] Bump gnome-themes-standard to 3.6.0
1009         https://bugs.webkit.org/show_bug.cgi?id=114155
1010
1011         Reviewed by Martin Robinson.
1012
1013         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
1014         dependency of gnome-themes-standard accordingly.
1015
1016 2013-04-08  David Levin  <levin@chromium.org>
1017
1018         Remove my watchlist entries.
1019         https://bugs.webkit.org/show_bug.cgi?id=114180
1020
1021         Reviewed by Adam Barth.
1022
1023         * Scripts/webkitpy/common/config/committers.py:
1024         * Scripts/webkitpy/common/config/watchlist:
1025
1026 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1027
1028         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
1029         https://bugs.webkit.org/show_bug.cgi?id=114161
1030
1031         Reviewed by Gyuyoung Kim.
1032
1033         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
1034         as it is crashing due to Bug 111074.
1035
1036         * TestWebKitAPI/PlatformEfl.cmake:
1037
1038 2013-04-07  David Kilzer  <ddkilzer@apple.com>
1039
1040         Remove the rest of SVG_DOM_OBJC_BINDINGS
1041         <http://webkit.org/b/114112>
1042
1043         Reviewed by Geoffrey Garen.
1044
1045         * Scripts/webkitperl/FeatureList.pm:
1046         - Remove --svg-dom-objc-bindings switch.
1047         * qmake/mkspecs/features/features.pri:
1048         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1049
1050 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
1051
1052         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
1053         https://bugs.webkit.org/show_bug.cgi?id=114089
1054
1055         Reviewed by Chris Fleizach.
1056
1057         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
1058         * DumpRenderTree/AccessibilityController.cpp:
1059         * DumpRenderTree/AccessibilityUIElement.cpp:
1060         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1061         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1062         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1063         (DumpRenderTreeChrome):
1064
1065 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
1066
1067         Build fix after r147857, remove remaining USE(JSC) guards.
1068
1069         Unreviewed.
1070
1071         * DumpRenderTree/config.h:
1072         * TestWebKitAPI/config.h:
1073         * WebKitTestRunner/config.h:
1074
1075 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         Rename sheriffbot to webkitbot
1078         https://bugs.webkit.org/show_bug.cgi?id=114109
1079
1080         Reviewed by Benjamin Poulain.
1081
1082         Renamed since sheriffbot will be used in Blink.
1083
1084         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1085         (SheriffBot):
1086         (SheriffBot.begin_work_queue):
1087
1088 2013-04-06  Oliver Hunt  <oliver@apple.com>
1089
1090         Unify the many and varied stack trace mechanisms, and make the result sane.
1091         https://bugs.webkit.org/show_bug.cgi?id=114072
1092
1093         Reviewed by Filip Pizlo.
1094
1095         The commandline jsc executable no longer requires arguments, so
1096         I've made run-jsc work without them.
1097
1098         * Scripts/run-jsc:
1099
1100 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1101
1102         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1103         https://bugs.webkit.org/show_bug.cgi?id=114086
1104
1105         Reviewed by Tim Horton.
1106
1107         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1108
1109 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1110
1111         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1112         https://bugs.webkit.org/show_bug.cgi?id=114083
1113
1114         Reviewed by Ryosuke Niwa.
1115
1116         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1117         in TestWebKitAPI and WebKitTestRunner.
1118
1119         * TestWebKitAPI/config.h:
1120         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1121         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1122         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1123         (WTR::InjectedBundle::platformInitialize):
1124
1125 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1126
1127         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1128         https://bugs.webkit.org/show_bug.cgi?id=114094
1129
1130         Reviewed by Anders Carlsson.
1131
1132         * Scripts/run-jsc:
1133
1134 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1135
1136         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1137         https://bugs.webkit.org/show_bug.cgi?id=114080
1138
1139         Reviewed by Ryosuke Niwa.
1140
1141         This way, the WebKit and Blink dashboard code can change as appropriate without
1142         needing to consider the other project's needs. This still doesn't update the
1143         buildbots to upload to the new location, or the dashboard code to pull the
1144         results.json files from the new location, but it at least allows for changing the
1145         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1146
1147         * TestResultServer/app.yaml:
1148
1149 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1150
1151         Re-enable testing on the commit queue
1152         https://bugs.webkit.org/show_bug.cgi?id=114078
1153
1154         Reviewed by Darin Adler.
1155
1156         Re-enabled the feature and the associated tests.
1157
1158         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1159         (CommitQueueTask.run):
1160         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1161         (CommitQueueTaskTest._run_through_task):
1162         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1163         (CommitQueueTest._mock_test_result):
1164
1165 2013-04-05  Oliver Hunt  <oliver@apple.com>
1166
1167         Unify the many and varied stack trace mechanisms, and make the result sane.
1168         https://bugs.webkit.org/show_bug.cgi?id=114072
1169
1170         Reviewed by Filip Pizlo.
1171
1172         The commandline jsc executable no longer requires arguments, so
1173         I've made run-jsc work without them.
1174
1175         * Scripts/run-jsc:
1176
1177 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1178
1179         AX: Make SVG Group containers accessible elements
1180         https://bugs.webkit.org/show_bug.cgi?id=113939
1181
1182         Reviewed by Simon Fraser.
1183
1184         Implement axController.elementAtPoint for iOS.
1185         Implement a correct version of clickPoint for iOS.
1186
1187         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1188         (AccessibilityController::elementAtPoint):
1189         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1190         (AccessibilityUIElement::clickPointX):
1191         (AccessibilityUIElement::clickPointY):
1192
1193 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1194
1195         Unreviewed, rolling out r147773 and r147774.
1196         http://trac.webkit.org/changeset/147773
1197         http://trac.webkit.org/changeset/147774
1198         https://bugs.webkit.org/show_bug.cgi?id=114056
1199
1200         Causing some exceptions on AppEngine I don't understand
1201         (Requested by rniwa on #webkit).
1202
1203         * QueueStatusServer/config/queues.py:
1204         * QueueStatusServer/model/queues.py:
1205         (Queue.short_name):
1206         (Queue.display_name):
1207         * QueueStatusServer/model/queues_unittest.py:
1208         (QueueTest.test_short_name):
1209         (QueueTest.test_display_name):
1210         (QueueTest.test_name_with_underscores):
1211
1212 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1213
1214         Fixed run-bindings-tests by removing V8
1215         https://bugs.webkit.org/show_bug.cgi?id=114053
1216
1217         Reviewed by Benjamin Poulain.
1218
1219         * Scripts/run-bindings-tests:
1220         (main):
1221
1222 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1223
1224         Build fix.
1225
1226         * QueueStatusServer/model/queues.py:
1227         (Queue.short_name):
1228         (Queue.display_name):
1229
1230 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1231
1232         Remove Chromium EWS bots from the queue status server
1233         https://bugs.webkit.org/show_bug.cgi?id=113988
1234
1235         Reviewed by Benjamin Poulain.
1236
1237         Removed Chromium EWS bots.
1238
1239         * QueueStatusServer/config/queues.py:
1240         * QueueStatusServer/model/queues.py:
1241         (Queue.short_name):
1242         (Queue.display_name):
1243         * QueueStatusServer/model/queues_unittest.py:
1244         (QueueTest.test_short_name):
1245         (QueueTest.test_display_name):
1246         (QueueTest.test_name_with_underscores):
1247
1248 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1249
1250         [EFL] Enable indexed database
1251         https://bugs.webkit.org/show_bug.cgi?id=107248
1252
1253         Reviewed by Alexis Menard.
1254
1255         * Scripts/webkitperl/FeatureList.pm:
1256
1257 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1258
1259         Remove vestiges of Chromium bits from watchlists.
1260         https://bugs.webkit.org/show_bug.cgi?id=114047
1261
1262         Reviewed by Ryosuke Niwa.
1263
1264         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1265
1266 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1267
1268         Add James Craig to the contributors list.
1269
1270         * Scripts/webkitpy/common/config/committers.py:
1271
1272 2013-04-04  Kent Tamura  <tkent@chromium.org>
1273
1274         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1275
1276         * Scripts/webkitpy/common/config/watchlist:
1277
1278 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1279
1280         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1281         https://bugs.webkit.org/show_bug.cgi?id=113997
1282
1283         Reviewed by Ryosuke Niwa.
1284
1285         Disable the tests until Ryosuke gets the time and hardware to have
1286         a testing commit-queue.
1287
1288         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1289         (CommitQueueTaskTest):
1290         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1291         (CommitQueueTest):
1292
1293 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1294
1295         Remove Chromium builders from build.webkit.org
1296         https://bugs.webkit.org/show_bug.cgi?id=113990
1297
1298         Reviewed by Benjamin Poulain.
1299
1300         Land the part to disable triggering of Chromium builders first so that we may start
1301         deleting more Chromium code that breaks the update step.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/config.json:
1304
1305 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1306
1307         Remove Chromium's DumpRenderTree
1308         https://bugs.webkit.org/show_bug.cgi?id=113989
1309
1310         Reviewed by Kent Tamura.
1311
1312         On second thought, let's not go to Camelot. It is a silly place.
1313
1314         * DumpRenderTree/mac/DumpRenderTree.mm:
1315         (resetDefaultsToConsistentValues):
1316
1317 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1318
1319         Nixed the defunct chromium folder from DumpRenderTree
1320         https://bugs.webkit.org/show_bug.cgi?id=113993
1321
1322         Reviewed by Ryosuke Niwa.
1323
1324         * DumpRenderTree/chromium: Removed.
1325         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1326         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1327         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1328         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1329         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1330         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1331         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1332         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1333         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1334         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1335         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1336         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1337         * DumpRenderTree/chromium/Task.cpp: Removed.
1338         * DumpRenderTree/chromium/Task.h: Removed.
1339         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1340         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1341         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1342         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1343         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1344         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1345         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1346         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1347         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1348         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1349         * DumpRenderTree/chromium/TestRunner: Removed.
1350         * DumpRenderTree/chromium/TestRunner/public: Removed.
1351         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1352         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1353         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1354         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1355         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1356         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1357         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1358         * DumpRenderTree/chromium/TestRunner/src: Removed.
1359         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1360         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1361         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1362         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1363         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1364         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1365         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1366         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1367         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1368         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1369         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1370         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1371         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1372         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1373         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1374         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1375         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1376         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1377         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1378         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1379         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1380         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1381         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1382         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1383         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1384         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1385         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1386         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1387         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1388         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1389         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1390         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1391         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1392         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1393         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1394         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1395         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1396         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1397         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1398         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1399         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1400         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1401         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1402         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1403         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1404         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1405         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1406         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1407         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1408         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1409         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1410         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1411         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1412         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1413         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1414         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1415         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1416         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1417         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1418         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1419         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1420         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1421         * DumpRenderTree/chromium/TestShell.h: Removed.
1422         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1423         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1424         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1425         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1426         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1427         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1428         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1429         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1430         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1431         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1432         * DumpRenderTree/chromium/config.h: Removed.
1433         * DumpRenderTree/chromium/fonts.conf: Removed.
1434
1435 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1436
1437         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1438
1439         Rubber stamped by Benjamin Poulain.
1440
1441         * RebaselineQueueServer: Removed.
1442         * RebaselineQueueServer/app.yaml: Removed.
1443         * RebaselineQueueServer/handlers: Removed.
1444         * RebaselineQueueServer/handlers/__init__.py: Removed.
1445         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1446         * RebaselineQueueServer/handlers/pages.py: Removed.
1447         * RebaselineQueueServer/index.yaml: Removed.
1448         * RebaselineQueueServer/main.py: Removed.
1449         * RebaselineQueueServer/model: Removed.
1450         * RebaselineQueueServer/model/__init__.py: Removed.
1451         * RebaselineQueueServer/model/queueentry.py: Removed.
1452         * RebaselineQueueServer/static: Removed.
1453         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1454         * RebaselineQueueServer/static/styles.css: Removed.
1455         * RebaselineQueueServer/templates: Removed.
1456         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1457         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1458         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1459         * RebaselineQueueServer/templates/home.html: Removed.
1460
1461 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1462
1463         Fix setup-commit-queue and temporarily disable testing on commit-queue
1464         https://bugs.webkit.org/show_bug.cgi?id=113979
1465
1466         Reviewed by Benjamin Poulain.
1467
1468         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1469         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1470
1471         * EWSTools/setup-commit-queue.sh:
1472         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1473         (CommitQueueTask.run):
1474
1475 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1476
1477         temporarily make flakiness dashboard work again webkit.org bots
1478         https://bugs.webkit.org/show_bug.cgi?id=113972
1479
1480         Reviewed by Ojan Vafai.
1481
1482         This patch disables the chromium.org layout test bots TestExpectations
1483         parsing temporarily until we can work out the right way to split into
1484         two instances for webkit.org and chromium.org and figure out which
1485         code to delete where :).
1486
1487         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1488
1489 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1490
1491         Fix webkitpy tests after r147678.
1492
1493         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1494         (CommitQueueTest.test_commit_queue):
1495         (test_manual_reject_during_processing):
1496
1497 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1498
1499         The commit queue should use Mac MountainLion port
1500         https://bugs.webkit.org/show_bug.cgi?id=113971
1501
1502         Reviewed by Lucas Forschler.
1503
1504         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1505         * Scripts/webkitpy/tool/commands/queues.py:
1506         (CommitQueue):
1507
1508 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1509
1510         turn off running tests on chromium linux EWS bots
1511         https://bugs.webkit.org/show_bug.cgi?id=113959
1512
1513         Reviewed by Geoffrey Garen.
1514
1515         Now that the Chromium port is no longer being maintained
1516         there's little point in running the tests. Soon we should
1517         just shut this bot off altogether.
1518
1519         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1520         (ChromiumLinuxEWS):
1521
1522 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1523
1524         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1525
1526         * Scripts/webkitpy/common/config/watchlist:
1527
1528 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1529
1530         Indentation fix to get webkit-patch working again after r147625
1531
1532         Unreviewed.
1533
1534         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1535         (MacEWS):
1536         (MacWK2EWS):
1537
1538 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1539
1540         Turn tests back on for Mac WK1/WK2 EWS.
1541         
1542         Unreviewed.
1543         
1544         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1545         (MacEWS):
1546         (MacWK2EWS):
1547
1548 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1549
1550         [GTK][WK2] MiniBrowser custom URI scheme support
1551         https://bugs.webkit.org/show_bug.cgi?id=112419
1552
1553         Reviewed by Carlos Garcia Campos.
1554
1555         Add support for about URIs in MiniBrowser. An example about page is show
1556         with URI "about:minibrowser", the rest of the cases it will show a
1557         proper message explaining that the about page didn't exist.
1558
1559         Internally it uses "minibrowser-about" prefix instead of "about", but
1560         from the user point of view it works with "about" prefix.
1561
1562         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1563         (getInternalURI): Method to convert URIs from "about" prefix to
1564         "minibrowser-about".
1565         (getExternalURI): Opposite method.
1566         (webViewURIChanged): Use "about" prefix to show the URI to users.
1567         (webViewEnterFullScreen): Ditto.
1568         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1569         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1570         (aboutURISchemeRequestCallback): Callback to manage about calls.
1571         (main): Register the URI scheme to manage about URIs.
1572
1573 2013-04-03  Roger Fong  <roger_fong@apple.com>
1574
1575         Re-enable WinEWS tests.
1576
1577         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1578         (WinEWS):
1579
1580 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1581
1582         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1583         https://bugs.webkit.org/show_bug.cgi?id=113883
1584
1585         Reviewed by Martin Robinson.
1586
1587         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1588         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1589         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1590
1591 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1592
1593         [GTK] Include Pango in jhbuild-optional.modules
1594         https://bugs.webkit.org/show_bug.cgi?id=113878
1595
1596         Reviewed by Martin Robinson.
1597
1598         Since r147547 Pango 1.32.0 is required. Including the module in the
1599         JHBuild optional moduleset.
1600
1601         * gtk/jhbuild-optional.modules: Add Pango module.
1602
1603 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1604
1605         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1606         https://bugs.webkit.org/show_bug.cgi?id=113864
1607
1608         Moving setDefersLoading from TestRunnerQt to TestRunner
1609         requires access to the non-Qt TestRunner.
1610         As long as we instantiate both TestRunner and TestRunnerQt,
1611         we need a separate getter for the non-Qt TestRunner instance.
1612
1613         Reviewed by Simon Hausmann.
1614
1615         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1616         (WebPage::resetSettings):
1617         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1618         (DumpRenderTree::jscTestRunner):
1619         * DumpRenderTree/qt/TestRunnerQt.cpp:
1620         (TestRunner::setDefersLoading):
1621             Moving setDefersLoading from TestRunnerQt
1622             to TestRunner.
1623         * DumpRenderTree/qt/TestRunnerQt.h:
1624         (TestRunnerQt):
1625
1626 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1627
1628         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1629         https://bugs.webkit.org/show_bug.cgi?id=104779
1630
1631         Reviewed by Carlos Garcia Campos.
1632
1633         * Scripts/run-gtk-tests:
1634         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1635         passing in current trunk.
1636
1637 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1638
1639         Fix HAVE(QTTESTSUPPORT) logic
1640
1641         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1642         resulting in HAVE(QTTESTSUPPORT) never being true.
1643         Move that logic down in sanitizeFeatures.
1644
1645         Rubber-stamped by Tor Arne Vestbø.
1646
1647         * qmake/mkspecs/features/features.prf:
1648
1649 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1650
1651         [GTK] Bump required versions of some dependencies
1652         https://bugs.webkit.org/show_bug.cgi?id=113282
1653
1654         Reviewed by Martin Robinson.
1655
1656         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1657
1658 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1659
1660         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1661         https://bugs.webkit.org/show_bug.cgi?id=113809
1662
1663         Reviewed by Philippe Normand.
1664
1665         Newer Linux kernels have removed some deprecated macros from v4l2
1666         headers, causing gst-plugins-good's build to break. We don't need it
1667         right now, so just disable it.
1668
1669         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1670
1671 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1672
1673         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1674         https://bugs.webkit.org/show_bug.cgi?id=113535
1675
1676         Reviewed by Simon Hausmann.
1677
1678         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1679
1680         * qmake/mkspecs/features/features.prf:
1681
1682 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1683
1684         [Qt] Move logic of simple forwarding functions to TestRunner.
1685         https://bugs.webkit.org/show_bug.cgi?id=113863
1686
1687         Reviewed by Simon Hausmann.
1688
1689         * DumpRenderTree/qt/TestRunnerQt.cpp:
1690         (TestRunner::setTextDirection):
1691         (TestRunner::goBack):
1692         (TestRunner::evaluateScriptInIsolatedWorld):
1693         (TestRunner::addUserStyleSheet):
1694         * DumpRenderTree/qt/TestRunnerQt.h:
1695         (TestRunnerQt):
1696
1697 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1698
1699         [Qt] Disable media support using QuickTime if deployment target != SDK
1700
1701         We link to a single libWebKitSystemInterface static lib, so unless the
1702         deployment target matches the SDK let's not pretend like we'll be able
1703         to run on anything lower than the SDK version.
1704
1705         Reviewed by Simon Hausmann.
1706
1707         * qmake/mkspecs/features/features.prf:
1708
1709 2013-04-02  James Craig  <james@cookiecrook.com>
1710
1711         AXRoleDescripton for DL is "list"; should be "description list"
1712         https://bugs.webkit.org/show_bug.cgi?id=111665
1713
1714         Reviewed by Chris Fleizach.
1715
1716         Defining the role and description strings.
1717
1718         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1719
1720 2013-04-02  Roger Fong  <roger_fong@apple.com>
1721
1722         Unreviewed. Disable running tests on Win EWS queue.
1723
1724         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1725         (WinEWS):
1726
1727 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1728
1729         Disable running tests on the MAC WK2 EWS queue.
1730         
1731         Unreviewed.
1732         
1733         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1734         (MacWK2EWS):
1735
1736 2013-04-02  Julie Parent  <jparent@chromium.org>
1737
1738         Dashboard refactor: Move dashboard specific history related features to History.
1739         https://bugs.webkit.org/show_bug.cgi?id=113717
1740
1741         Reviewed by Ojan Vafai.
1742         
1743         Each dashboard now creates its own History object, with a custom
1744         configuration. This changes from just overriding global functions
1745         to passing in callbacks for generatePage, handleValidHashParameter,
1746         and handleQueryParameterChange. Same with passing in defaultStateValues
1747         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1748         variables.
1749         
1750         All functions related to these features are now (mostly) private
1751         function on History. 
1752         
1753         Loader no longer needs a loadingComplete callback, since it can just
1754         initialize the history object itself.
1755
1756         * TestResultServer/static-dashboards/aggregate_results.js:
1757         (handleValidHashParameter):
1758         * TestResultServer/static-dashboards/dashboard_base.js:
1759         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1760         (generatePage):
1761         (.switch.return):
1762         (handleQueryParameterChange):
1763         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1764         (resetGlobals):
1765         * TestResultServer/static-dashboards/history.js:
1766         (.):
1767         * TestResultServer/static-dashboards/loader.js:
1768         (.):
1769         * TestResultServer/static-dashboards/loader_unittests.js:
1770         * TestResultServer/static-dashboards/timeline_explorer.js:
1771         (generatePage):
1772         (initCurrentBuilderTestResults):
1773         * TestResultServer/static-dashboards/treemap.js:
1774         (generatePage):
1775         (.switch.return):
1776         (handleQueryParameterChange):
1777
1778 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1779
1780         Unreviewed, rolling out r147401.
1781         http://trac.webkit.org/changeset/147401
1782         https://bugs.webkit.org/show_bug.cgi?id=113767
1783
1784         The patch makes it extremely hard to set up the dependencies
1785         properly on the GTK builders (Requested by zdobersek on
1786         #webkit).
1787
1788         * gtk/jhbuild.modules:
1789
1790 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1791
1792         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1793         https://bugs.webkit.org/show_bug.cgi?id=113382
1794
1795         Reviewed by Gyuyoung Kim.
1796
1797         Do not show the empty tooltip box if the text is null.
1798
1799         * MiniBrowser/efl/main.c:
1800         (popup_menu_populate):
1801
1802 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         [GTK] Bump required versions of some dependencies
1805         https://bugs.webkit.org/show_bug.cgi?id=113282
1806
1807         Reviewed by Martin Robinson.
1808
1809         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1810
1811 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1812
1813         Unreviewed, rolling out r147319.
1814         http://trac.webkit.org/changeset/147319
1815         https://bugs.webkit.org/show_bug.cgi?id=113707
1816
1817         The unit test is still failing on the buildbot (Requested by
1818         zdobersek on #webkit).
1819
1820         * Scripts/run-gtk-tests:
1821         (TestRunner):
1822
1823 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1824
1825         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1826         https://bugs.webkit.org/show_bug.cgi?id=104779
1827
1828         Reviewed by Carlos Garcia Campos.
1829
1830         * Scripts/run-gtk-tests:
1831         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1832         passing in current trunk.
1833
1834 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1835
1836         Unreviewed, rolling out r147289.
1837         http://trac.webkit.org/changeset/147289
1838         https://bugs.webkit.org/show_bug.cgi?id=113678
1839
1840         broke Win7 (dbg) build (Requested by shinyak|gardener on
1841         #webkit).
1842
1843         * DumpRenderTree/DumpRenderTree.gypi:
1844         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1845         (WebTestRunner):
1846         (WebUserMediaClientMock):
1847         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1848         (WebTestRunner::WebUserMediaClientMock::taskList):
1849         * Scripts/webkitpy/style/checkers/cpp.py:
1850         (check_function_definition):
1851
1852 2013-03-31  Adam Barth  <abarth@webkit.org>
1853
1854         configure-svn-config.sh fails
1855         https://codereview.chromium.org/13392007/
1856
1857         Reviewed by Eric Seidel.
1858
1859         This script was trying to use "svn checkout" to dowload a file from
1860         svn.webkit.org, but "svn checkout" only works with directories.
1861         Instead, we should use "svn export".
1862
1863         * EWSTools/configure-svn-config.sh:
1864
1865 2013-03-31  Wei Jia  <wjia@chromium.org>
1866
1867         Allow WebUserMediaClientMock to be used by client
1868         https://bugs.webkit.org/show_bug.cgi?id=113633
1869
1870         Reviewed by Adam Barth.
1871
1872         Export WebUserMediaClientMock.
1873         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1874
1875         * DumpRenderTree/DumpRenderTree.gypi:
1876         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1877         (WebUserMediaClientMock):
1878         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1879         * Scripts/webkitpy/style/checkers/cpp.py:
1880         (check_function_definition):
1881
1882 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1883
1884         Expose FeatureObserver data to WebKit clients
1885         https://bugs.webkit.org/show_bug.cgi?id=113613
1886
1887         Reviewed by Sam Weinig.
1888
1889         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1890         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1891
1892 2013-03-29  Greg Hughes  <ghughes@apple.com>
1893
1894         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1895         https://bugs.webkit.org/show_bug.cgi?id=112276
1896
1897         Reviewed by Chris Fleizach.
1898
1899         Added support to test accessibility search predicates with multiple keys.  
1900
1901         * DumpRenderTree/AccessibilityUIElement.cpp:
1902         (uiElementForSearchPredicateCallback):
1903         * DumpRenderTree/AccessibilityUIElement.h:
1904         (AccessibilityUIElement):
1905         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1906         (AccessibilityUIElement::uiElementForSearchPredicate):
1907         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1908         (AccessibilityUIElement::uiElementForSearchPredicate):
1909         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1910         (AccessibilityUIElement::uiElementForSearchPredicate):
1911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1912         (AccessibilityUIElement::uiElementForSearchPredicate):
1913         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1914         (AccessibilityUIElement::uiElementForSearchPredicate):
1915         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1916         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1917         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1918         (AccessibilityUIElement):
1919         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1920         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1921         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1922         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1923         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1924
1925 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1926
1927         Fix a typo in r147147 to fix Mac EWS.
1928
1929         * Scripts/webkitpy/tool/commands/queues.py:
1930         (PatchProcessingQueue._new_port_name_from_old):
1931
1932 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1933
1934         [EFL] Build break with latest EFL libraries after r146265
1935         https://bugs.webkit.org/show_bug.cgi?id=113558
1936
1937         Unreviewed build fix.
1938
1939         * TestWebKitAPI/PlatformWebView.h:
1940         * WebKitTestRunner/PlatformWebView.h:
1941
1942 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1943
1944         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1945
1946         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1947         in libgcrypt build.
1948
1949 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1950
1951         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1952
1953         Unreviewed.
1954
1955         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1956         (MacEWS):
1957
1958 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1959
1960         Use the right OS name on Mac EWS instead of mac-future.
1961
1962         Rubber-stamped by Dirk Pranke.
1963
1964         * Scripts/webkitpy/tool/commands/queues.py:
1965         (PatchProcessingQueue._new_port_name_from_old):
1966         (PatchProcessingQueue.begin_work_queue):
1967         (PatchProcessingQueue._upload_results_archive_for_patch):
1968
1969 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1970
1971         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1972         https://bugs.webkit.org/show_bug.cgi?id=112546
1973
1974         Reviewed by Martin Robinson.
1975
1976         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1977         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1978
1979 2013-03-28  Ming Xie  <mxie@blackberry.com>
1980
1981         [BlackBerry] Committer Email Updates
1982         https://bugs.webkit.org/show_bug.cgi?id=113435
1983
1984         Reviewed by Rob Buis.
1985
1986         Add the @blackberry.com email address for all our BlackBerry
1987         WebKit committers. This is the first step for our email address
1988         migration.
1989
1990         * Scripts/webkitpy/common/config/committers.py:
1991
1992 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1993
1994         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1995         https://bugs.webkit.org/show_bug.cgi?id=113508
1996
1997         Reviewed by Martin Robinson.
1998
1999         Prevent the GStreamer plugin scanner to load system-wide
2000         plugins. Only the ones built in JHBuild should be loaded and used
2001         at runtime.
2002
2003         * efl/jhbuildrc:
2004         * gtk/jhbuildrc:
2005
2006 2013-03-27  Philippe Normand  <pnormand@igalia.com>
2007
2008         [GTK] run-launcher --gtk -2 fails on a WK2-only build
2009         https://bugs.webkit.org/show_bug.cgi?id=113386
2010
2011         Reviewed by Carlos Garcia Campos.
2012
2013         * Scripts/webkitdirs.pm:
2014         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
2015         version to 3.0. Reflect this change so the builtDylibPathForName
2016         function doesn't fail to report the library as found.
2017
2018 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
2019
2020         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
2021         https://bugs.webkit.org/show_bug.cgi?id=113484
2022
2023         Unreviewed build fix.
2024
2025         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
2026
2027         * TestWebKitAPI/CMakeLists.txt:
2028         * WebKitTestRunner/CMakeLists.txt:
2029
2030 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2031
2032         Revision for the internal jhbuild is too old
2033         https://bugs.webkit.org/show_bug.cgi?id=113324
2034
2035         Reviewed by Martin Robinson.
2036
2037         Update the minimum required version to a point where jhbuild won't
2038         fail installing packages when trying to remove a symlink to a directory.
2039
2040         * jhbuild/jhbuild-wrapper: Updated revision.
2041
2042 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
2043
2044         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
2045         https://bugs.webkit.org/show_bug.cgi?id=113203
2046
2047         Reviewed by Philippe Normand.
2048
2049         We build our libsoup without GNOME support. gst-plugins-good does separate
2050         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
2051         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
2052         build failures as the headers of those diverge. We do not use souphttpsrc, so
2053         disable it when building gst-plugins-good.
2054
2055         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
2056
2057 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2058
2059         Build fix after r146852. Please another reference to the Lion leaks builder.
2060
2061         * BuildSlaveSupport/build.webkit.org-config/config.json:
2062
2063 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
2064
2065         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
2066         https://bugs.webkit.org/show_bug.cgi?id=113421
2067
2068         Reviewed by Dirk Pranke.
2069
2070         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
2071         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
2072         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
2073         in the GTK-specific TestExpectations files.
2074
2075         To avoid this only enable the warnings only when not using WKTR.
2076
2077         * Scripts/webkitpy/layout_tests/port/gtk.py:
2078         (GtkPort.warn_if_bug_missing_in_test_expectations):
2079
2080 2013-03-27  Antti Koivisto  <antti@apple.com>
2081
2082         Fix Zalan's email.
2083
2084         * Scripts/webkitpy/common/config/committers.py:
2085
2086 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2087
2088         master.cfg cleanup
2089         https://bugs.webkit.org/show_bug.cgi?id=113195
2090
2091         Reviewed by Ryosuke Niwa.
2092
2093         * BuildSlaveSupport/build.webkit.org-config/config.json:
2094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2095
2096 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2097
2098         master.cfg fine-tuning for Qt Mountain Lion Release bot
2099         https://bugs.webkit.org/show_bug.cgi?id=113191
2100
2101         Reviewed by Ryosuke Niwa.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/config.json:
2104           - Rename the slave due to its location change.
2105           - Update the platform of the slave.
2106         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2107         (RunQtAPITests): Enable running WK2 API tests on Qt.
2108         (RunQtAPITests.start):
2109         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2110         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2111
2112 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2113
2114         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2115         https://bugs.webkit.org/show_bug.cgi?id=113403
2116
2117         Reviewed by Kenneth Rohde Christiansen.
2118
2119         As of Evas 1.7.5, when Wayland is detected on the system, support for
2120         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2121         The code, however, seems to depend on a few other flags which must be
2122         explicitly enabled.
2123
2124         If those additional GL-related options are passed, we end up
2125         having issues on the WebKit side, so disable Wayland support for
2126         now.
2127
2128         * efl/jhbuild.modules:
2129
2130 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2131
2132         Unreviewed, rolling out r146864.
2133         http://trac.webkit.org/changeset/146864
2134         https://bugs.webkit.org/show_bug.cgi?id=113391
2135
2136         causes crashes on Wk2 EFL release bot (Requested by drott on
2137         #webkit).
2138
2139         * Scripts/webkitperl/FeatureList.pm:
2140
2141 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2142
2143         [jhbuild] Correctly specify an alternate number of make jobs.
2144         https://bugs.webkit.org/show_bug.cgi?id=113396
2145
2146         Reviewed by Philippe Normand.
2147
2148         So far, we were using the `MAKEFLAGS' environment variable to pass the
2149         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2150         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2151
2152         We now behave more closely to the rest of the WebKit tools by first
2153         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2154         not set, just letting jhbuild itself figure out how many jobs to use.
2155
2156         * efl/jhbuildrc:
2157         * gtk/jhbuildrc:
2158
2159 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2160
2161         [Qt] Remove Qt specific WorkQueueItem definitions.
2162         https://bugs.webkit.org/show_bug.cgi?id=112891
2163
2164         This patch is preparation work for removing
2165         WorkQueue related code from TestRunnerQt and
2166         replacing it with generic TestRunner code.
2167
2168         Reviewed by Benjamin Poulain.
2169
2170         * DumpRenderTree/qt/TestRunnerQt.cpp:
2171         (TestRunnerQt::queueBackNavigation):
2172         (TestRunnerQt::queueForwardNavigation):
2173         (TestRunnerQt::queueLoadHTMLString):
2174         (TestRunnerQt::queueReload):
2175         (TestRunnerQt::queueLoadingScript):
2176         (TestRunnerQt::queueNonLoadingScript):
2177         (TestRunner::queueLoad):
2178         * DumpRenderTree/qt/TestRunnerQt.h:
2179         (TestRunnerQt):
2180         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2181         (LoadItem::invoke):
2182         (LoadHTMLStringItem::invoke):
2183         (LoadAlternateHTMLStringItem::invoke):
2184         (ReloadItem::invoke):
2185         (ScriptItem::invoke):
2186         (BackForwardItem::invoke):
2187         * DumpRenderTree/qt/WorkQueueItemQt.h:
2188         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2189         (LoadAlternateHTMLStringItem):
2190
2191 2013-03-26  Julie Parent  <jparent@chromium.org>
2192
2193         Flakiness dashboard: simplify logic around which tests to show.
2194         https://bugs.webkit.org/show_bug.cgi?id=113250
2195
2196         Reviewed by Ojan Vafai.
2197         
2198         The different filters for showing results are only used for layout
2199         tests, otherwise, we show everything.
2200         
2201         Change the defaults to false (what layout tests used), and only
2202         look at the values when viewing layout tests.
2203
2204         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2205         (htmlForTestsWithExpectationsButNoFailures):
2206         (shouldHideTest):
2207
2208 2013-03-26  Isaac Levy  <ilevy@google.com>
2209
2210         Update bots on test-results.appspot
2211         https://bugs.webkit.org/show_bug.cgi?id=113333
2212
2213         Reviewed by Ojan Vafai.
2214
2215         * TestResultServer/static-dashboards/builders.jsonp:
2216
2217 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2218
2219         Unreviewed GTK gardening.
2220
2221         * Scripts/run-gtk-tests:
2222         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2223
2224 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2225
2226         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2227         https://bugs.webkit.org/show_bug.cgi?id=113287
2228
2229         Reviewed by Jocelyn Turcotte.
2230
2231         * Scripts/run-qtwebkit-tests:
2232         (Options.__init__):
2233
2234 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2235
2236         [EFL] Enable IndexedDB by default
2237         https://bugs.webkit.org/show_bug.cgi?id=107248
2238
2239         Reviewed by Laszlo Gombos.
2240
2241         * Scripts/webkitperl/FeatureList.pm:
2242         Enable IndexedDB by default on EFL.
2243
2244 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2245
2246         Sheriffbot should explain rollout failures in a human readable form.
2247         https://bugs.webkit.org/show_bug.cgi?id=107092
2248
2249         Reviewed by Ryosuke Niwa.
2250
2251         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2252
2253         * Scripts/webkitpy/tool/bot/irc_command.py:
2254         (Rollout._check_diff_failure):
2255         (Rollout.execute):
2256         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2257         (IRCCommandTest.test_rollout):
2258
2259 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2260
2261         Unreviewed GTK gardening.
2262
2263         * Scripts/run-gtk-tests:
2264         (TestRunner): Skipping a failing unit test after r146518.
2265
2266 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2267
2268         Remove Lion leaks builder
2269         https://bugs.webkit.org/show_bug.cgi?id=113252
2270
2271         Reviewed by Andreas Kling.
2272
2273         Removed.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/config.json:
2276
2277 2013-03-25  Kent Tamura  <tkent@chromium.org>
2278
2279         Rename ENABLE_INPUT_TYPE_DATETIME
2280         https://bugs.webkit.org/show_bug.cgi?id=113254
2281
2282         Reviewed by Kentaro Hara.
2283
2284         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2285         Actually I'd like to remove the code, but we shouldn't remove it yet
2286         because we shipped products with it on some platforms.
2287
2288         * Scripts/webkitperl/FeatureList.pm:
2289         * qmake/mkspecs/features/features.pri:
2290
2291 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2292
2293         Remove one more line that was intended to be removed in r146657.
2294
2295         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2296         (summarize_results):
2297
2298 2013-03-25  Roger Fong  <roger_fong@apple.com>
2299
2300         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2301         Re-enable WinEWS tests.
2302
2303         * Scripts/webkitpy/common/config/ports.py:
2304         (WinPort.run_bindings_tests_command):
2305         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2306         (WinEWS):
2307
2308 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2309
2310         Unreviewed, rolling out r146793.
2311         http://trac.webkit.org/changeset/146793
2312         https://bugs.webkit.org/show_bug.cgi?id=113248
2313
2314         Fix did not work (Requested by rfong on #webkit).
2315
2316         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2317         (WinEWS):
2318
2319 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2320
2321         REGRESSION(r146657): Test failures reported incorrectly
2322         https://bugs.webkit.org/show_bug.cgi?id=113223
2323
2324         Reviewed by Dirk Pranke.
2325
2326         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2327
2328         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2329         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2330
2331         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2332         (Manager.run):
2333
2334         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2335         (RunDetails.__init__):
2336         (summarize_results): Remove the line I intended to remove in r146657.
2337
2338         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2339         (logging_run): Return details instead of the exit code.
2340         (run_and_capture): Ditto.
2341
2342         (RunTest.test_full_results_html):
2343         (RunTest.test_hung_thread):
2344         (RunTest.test_no_tests_found):
2345         (RunTest.test_no_tests_found_2):
2346         (RunTest.test_repeat_each_iterations_num_tests):
2347         (RunTest.test_run_singly_actually_runs_tests):
2348         (RunTest.test_test_list):
2349         (RunTest.test_missing_and_unexpected_results):
2350         (RunTest.test_pixel_test_directories):
2351         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2352         (RunTest.test_crash_with_stderr):
2353         (RunTest.test_no_image_failure_with_image_diff):
2354         (RunTest.test_crash_log):
2355         (RunTest.test_exit_after_n_failures_upload):
2356         (RunTest.test_results_directory_absolute):
2357         (RunTest.test_results_directory_relative):
2358         (RunTest.test_retrying_and_flaky_tests):
2359         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2360         (RunTest.test_retrying_uses_retries_directory):
2361         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2362         (RunTest.test_output_diffs):
2363         (EndToEndTest.test_reftest_with_two_notrefs):
2364         (RebaselineTest.test_reset_results):
2365         (RebaselineTest.test_missing_results):
2366         (RebaselineTest.test_new_baseline):
2367
2368         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2369         (BuildBotPrinter.print_results):
2370         (BuildBotPrinter.print_unexpected_results):
2371         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2372         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2373
2374 2013-03-25  Julie Parent  <jparent@chromium.org>
2375
2376         Dashboard refactor: Move cross dashboard history related code into history.js.
2377         https://bugs.webkit.org/show_bug.cgi?id=113104
2378
2379         Reviewed by Ojan Vafai.
2380
2381         All functions relating to cross dashboard behavior move from being
2382         globals to methods on the history.History object. Names stay the same,
2383         except many are made private, ones that should have been constants now
2384         are, and the long standing TODO to change "currentState" to 
2385         dashboardSpecificState is done.
2386         
2387         We now create a global history object in dashboard_base, as an 
2388         intermediate measure.  Once the dashboard specific code is
2389         added to history, each DB will need to create its own, and this
2390         global will be eliminated.
2391         
2392         * TestResultServer/static-dashboards/aggregate_results.js:
2393         (handleValidHashParameter):
2394         (htmlForBuilder):
2395         (rawValuesHTML):
2396         * TestResultServer/static-dashboards/dashboard_base.js:
2397         (parseDashboardSpecificParameters):
2398         (defaultValue):
2399         (currentBuilderGroupCategory):
2400         (currentBuilderGroupName):
2401         (handleLocationChange):
2402         (expectationsMap):
2403         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2404         (generatePage):
2405         (.switch.return):
2406         (platformAndBuildType):
2407         (individualTests):
2408         (substringList):
2409         (processMissingAndExtraExpectations):
2410         (pathToFailureLog):
2411         (showPopupForBuild):
2412         (htmlForTestsWithExpectationsButNoFailures):
2413         (shouldHideTest):
2414         (isCrossBuilderView):
2415         (tableHeaders):
2416         (htmlForSingleTestRow):
2417         (htmlForTableColumnHeader):
2418         (generatePageForExpectationsUpdate):
2419         (handleUpdate):
2420         (nextUpdate):
2421         (setUpdateIndex):
2422         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2423         (.appendExpectationsItem):
2424         (loadExpectations):
2425         (.dummyNode.onload):
2426         (loadExpectationsLayoutTests):
2427         (appendExpectations):
2428         (htmlForNavBar):
2429         (checkBoxToToggleState):
2430         (linkHTMLToToggleState):
2431         (generatePageForBuilder):
2432         (isInvalidKeyForCrossBuilderView):
2433         (handleQueryParameterChange):
2434         (showLegend):
2435         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2436         (resetGlobals):
2437         (test):
2438         * TestResultServer/static-dashboards/history.js:
2439         (.):
2440         * TestResultServer/static-dashboards/history_unittests.js:
2441         * TestResultServer/static-dashboards/loader.js:
2442         (.):
2443         * TestResultServer/static-dashboards/loader_unittests.js:
2444         * TestResultServer/static-dashboards/timeline_explorer.js:
2445         (generatePage):
2446         (initCurrentBuilderTestResults):
2447         (selectBuild):
2448         (showResultsDelta):
2449         * TestResultServer/static-dashboards/treemap.js:
2450         (generatePage):
2451         (.switch.return):
2452         (handleFocus):
2453         * TestResultServer/static-dashboards/ui.js:
2454
2455 2013-03-25  Roger Fong  <roger_fong@apple.com>
2456
2457         Unreviewed. Enable WinEWS tests again.
2458
2459         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2460         (WinEWS):
2461
2462 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2463
2464         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2465         https://bugs.webkit.org/show_bug.cgi?id=112166
2466
2467         HarfBuzz 0.9.14 merged my patch for icu detection without
2468         pkg-config files, as needed by for example Ubuntu 12.04.
2469         This obsoletes our local workaround. Removed it for GTK and EFL.
2470
2471         Reviewed by Martin Robinson.
2472
2473         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2474         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2475         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2476         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2477
2478 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2479
2480         Unreviewed.  Move self from contributor to committer list.
2481
2482         * Scripts/webkitpy/common/config/committers.py:
2483
2484 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2485
2486         EWS should use a human readable port name when uploading layout test archives
2487         https://bugs.webkit.org/show_bug.cgi?id=113099
2488
2489         Reviewed by Dirk Pranke.
2490
2491         Use new port's object's name() method to report human readable port names.
2492         This will also help us resolving the bug to apply layout test results posted by EWS.
2493
2494         * Scripts/webkitpy/tool/bot/botinfo.py:
2495         (BotInfo.__init__): Take port's name.
2496         (BotInfo.summary_text):
2497
2498         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2499         (BotInfoTest.test_summary_text):
2500
2501         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2502         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2503
2504         * Scripts/webkitpy/tool/commands/queues.py:
2505         (PatchProcessingQueue.__init__): Initialize self._port.
2506         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2507         and use that for the attachment filename and the comment posted.
2508
2509         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2510         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2511         "mac-snowleopard" as expected for TestPort.
2512
2513 2013-03-22  Roger Fong  <roger_fong@apple.com>
2514
2515         Unreviewed. Turn off EWS test on Win again.
2516         The battle continues.
2517
2518         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2519         (WinEWS):
2520
2521 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2522
2523         NRWT: Enable pixel tests when retrying tests
2524         https://bugs.webkit.org/show_bug.cgi?id=112898
2525
2526         Reviewed by Dirk Pranke.
2527
2528         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2529         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2530         if we've forced pixel tests in the retry.
2531         (Manager._run_tests):
2532         (Manager._clean_up_run): Fixed the capitalizations.
2533         (Manager._force_pixel_tests_if_needed): Added.
2534
2535         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2536         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2537         'image_diff_percent' if it doesn't already exist.
2538
2539         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2540         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2541         treat this as a regular regression instead of a flakiness.
2542
2543         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2544         run had image diffs.
2545
2546         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2547         (summarized_results):
2548
2549         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2550         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2551         Also removed some dead code.
2552
2553         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2554         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2555         is set and pixel_tests_enabled is set to false.
2556         (EndToEndTest.test_reftest_with_two_notrefs):
2557
2558 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2559
2560         Make it possible to run layout tests on Retina MBP
2561         https://bugs.webkit.org/show_bug.cgi?id=93673
2562
2563         Reviewed by Ryosuke Niwa.
2564
2565         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2566         windows on 2x machines still run at 1x.
2567
2568         * DumpRenderTree/mac/DumpRenderTree.mm:
2569         (createWebViewAndOffscreenWindow):
2570         Reset the window resolution to 1x on creation.
2571         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2572         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2573         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2574         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2575         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2576         (WTR::PlatformWebView::PlatformWebView):
2577         Add NSWindow details, reset the window resolution to 1x on creation.
2578
2579 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2580
2581         Leak bots shouldn't build
2582         https://bugs.webkit.org/show_bug.cgi?id=112774
2583
2584         Reviewed by Simon Fraser.
2585
2586         Since leak bots use regular debug builds, there is no need to build on these bots.
2587         Simply downloading builds will dramatically improve the cycle time of these bots.
2588
2589         * BuildSlaveSupport/build.webkit.org-config/config.json:
2590         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2591         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2592         TestFactory instead of BuildAndTestFactory.
2593
2594 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2595
2596         [Qt] Fix the TestWebKitAPI build
2597         https://bugs.webkit.org/show_bug.cgi?id=113044
2598
2599         Reviewed by Tor Arne Vestbø.
2600
2601         The generate-forwarding-headers script would only be run
2602         after the targets in InjectedBundle.pri since the second
2603         addStrictSubdirOrderBetween call in
2604         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2605         the derived_sources -> injected_bundle order in SUBDIRS.
2606
2607         Fix it by only moving the dependent target at the end of
2608         SUBDIRS, don't touch its dependency.
2609
2610         * qmake/mkspecs/features/functions.prf:
2611
2612 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2613
2614         [EFL][WK2] View is not focused when fullscreen mode toggled
2615         https://bugs.webkit.org/show_bug.cgi?id=113009
2616
2617         Reviewed by Laszlo Gombos.
2618
2619         Set focus on view when fullscreen mode enabled/disabled
2620         by FullScreen API.
2621
2622         * MiniBrowser/efl/main.c:
2623         (on_fullscreen_accept):
2624         (on_fullscreen_deny):
2625
2626 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2627
2628         nrwt is no longer saving retry results in the retries/ subdirectory
2629         https://bugs.webkit.org/show_bug.cgi?id=112995
2630
2631         Reviewed by Ojan Vafai.
2632
2633         I think this has been broken a long time, unfortunately. This
2634         patch should fix that.
2635
2636         In order to do so, I had to pass the directory to use from
2637         the Worker object through the SingleTestWriter to the
2638         TestResultWriter. While I was plumbing that through, I rationalized
2639         the order of the parameter arguments a bit ...
2640
2641         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2642         (Worker._run_single_test):
2643         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2644         (run_single_test):
2645         (SingleTestRunner.__init__):
2646         (SingleTestRunner._run_compare_test):
2647         (SingleTestRunner._run_rebaseline):
2648         (SingleTestRunner._run_reftest):
2649         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2650         (write_test_result):
2651         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2652         (TestResultWriterTest.test_reftest_diff_image):
2653         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2654         (RunTest.test_retrying_uses_retries_directory):
2655
2656 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2657
2658         JSC profiler should have an at-a-glance report of the success of DFG optimization
2659         https://bugs.webkit.org/show_bug.cgi?id=112988
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         * Scripts/display-profiler-output:
2664
2665 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2666
2667         [chromium] Linux ASAN WebKit canary is running out of memory
2668         https://bugs.webkit.org/show_bug.cgi?id=112978
2669
2670         Reviewed by Tony Chang.
2671
2672         Running the AddressSanitizer on a crash takes a lot of
2673         memory, so we should serialize access to it to avoid running
2674         out of memory on a machine.
2675
2676         * Scripts/webkitpy/layout_tests/port/chromium.py:
2677         (ChromiumPort._get_crash_log):
2678         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2679         (HttpLock.__init__):
2680         (HttpLock.wait_for_httpd_lock):
2681
2682 2013-03-21  Min Qin  <qinmin@chromium.org>
2683
2684         Cleanup android media layout test code
2685         https://bugs.webkit.org/show_bug.cgi?id=112944
2686
2687         Reviewed by Adam Barth.
2688
2689         Chromium change: https://codereview.chromium.org/12892010/
2690         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2691         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2692         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2693         Instead, we should switch to use content shell for layout tests.
2694
2695         * DumpRenderTree/chromium/TestShell.cpp:
2696         (TestShell::resetTestController):
2697
2698 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2699
2700         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2701         https://bugs.webkit.org/show_bug.cgi?id=112953
2702
2703         Reviewed by Tony Chang.
2704
2705         When I created the DumpRenderTree_resources target in r144863 I
2706         forgot to declare the needed dependencies on the other resource
2707         targets. Due to a quirk of ordering, this appears to have been fine
2708         w/ ninja but not w/ Xcode (which is still being used on the chromium
2709         mac valgrind bots). Declaring the dependencies fixes the build
2710         failures.
2711
2712         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2713
2714 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2715
2716         [WinCairo] Correct assert in Empty BitmapImage Test.
2717         https://bugs.webkit.org/show_bug.cgi?id=112934
2718
2719         Reviewed by Tim Horton.
2720
2721         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2722         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2723         to avoid ref counting assertion when leaving test scope.
2724
2725 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2726
2727         [GTK] generate-feature-defines-files is incompatible with Python3
2728         https://bugs.webkit.org/show_bug.cgi?id=112956
2729
2730         Reviewed by Martin Robinson.
2731
2732         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2733         method on the dictionary objects when iterating through said dictionaries.
2734
2735         * gtk/generate-feature-defines-files:
2736         (write_feature_defines_header):
2737         (write_flattened_feature_defines_file):
2738
2739 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2740
2741         kill-old-processes spits out error messages on Mac
2742         https://bugs.webkit.org/show_bug.cgi?id=112878
2743
2744         Reviewed by Jessie Berlin.
2745
2746         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2747         included in the list of options grep --help shows.
2748
2749         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2750
2751         * BuildSlaveSupport/kill-old-processes:
2752         (main):
2753
2754 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2755
2756         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2757         https://bugs.webkit.org/show_bug.cgi?id=112597
2758
2759         Reviewed by Xan Lopez.
2760
2761         These were introduced for the Chromium port in r105295. We need
2762         dummy implementations in order to compile the BlackBerry port.
2763
2764         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2765         (AccessibilityUIElement::scrollToMakeVisible):
2766         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2767         (AccessibilityUIElement::scrollToGlobalPoint):
2768
2769 2013-03-21  Roger Fong  <roger_fong@apple.com>
2770
2771         Re-enable WinEWS tests following r146376.
2772
2773         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2774         (WinEWS):
2775
2776 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2777
2778         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2779
2780         * Scripts/webkitpy/common/config/committers.py:
2781
2782 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2783
2784         [GTK] Missing atk in install-dependencies script
2785         https://bugs.webkit.org/show_bug.cgi?id=112272
2786
2787         Reviewed by Gustavo Noronha Silva.
2788
2789         * gtk/install-dependencies: Add missing atk dependency.
2790
2791 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2792
2793         [GTK] Missing backslash in install-dependencies script
2794         https://bugs.webkit.org/show_bug.cgi?id=112907
2795
2796         Reviewed by Philippe Normand.
2797
2798         * gtk/install-dependencies: Add missing backslash to dependencies
2799         list.
2800
2801 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2802
2803         EWS bots have stopped uploading results to bugzilla
2804         https://bugs.webkit.org/show_bug.cgi?id=101091
2805
2806         Reviewed by Adam Barth.
2807
2808         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2809         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2810         this relative file path resoled to a file inside a non-existent directory for "zip".
2811
2812         Fixed the bug by resolving both test results directory and zip archive paths in
2813         LayoutTestResultsReader.archive.
2814
2815         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2816         in the future.
2817
2818         * Scripts/webkitpy/common/system/filesystem_mock.py:
2819         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2820
2821         * Scripts/webkitpy/common/system/workspace.py:
2822         (Workspace.create_zip): Log the source path when "zip" failed.
2823
2824         * Scripts/webkitpy/common/system/workspace_mock.py:
2825         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2826
2827         * Scripts/webkitpy/common/system/workspace_unittest.py:
2828         (WorkspaceTest.test_create_zip_exception): Test that.
2829
2830         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2831         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2832         This is the actual bug fix.
2833
2834         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2835         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2836
2837 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2838
2839         [chromium] move WebThemeEngine implementations to TestRunner library
2840         https://bugs.webkit.org/show_bug.cgi?id=112751
2841
2842         Reviewed by Adam Barth.
2843
2844         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2845         * DumpRenderTree/DumpRenderTree.gypi:
2846         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2847         (WebKit):
2848         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2849         (WebTestRunner::TestInterfaces::themeEngine):
2850         (WebTestRunner):
2851         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2852         (WebKit):
2853         (TestInterfaces):
2854         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2855         (WebTestRunner::WebTestInterfaces::themeEngine):
2856         (WebTestRunner):
2857         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2858         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2859         (WebTestRunner):
2860         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2861         (WebTestRunner::WebTestThemeControlWin::box):
2862         (WebTestRunner::WebTestThemeControlWin::line):
2863         (WebTestRunner::WebTestThemeControlWin::triangle):
2864         (WebTestRunner::WebTestThemeControlWin::roundRect):
2865         (WebTestRunner::WebTestThemeControlWin::oval):
2866         (WebTestRunner::WebTestThemeControlWin::circle):
2867         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2868         (WebTestRunner::WebTestThemeControlWin::markState):
2869         (WebTestRunner::WebTestThemeControlWin::draw):
2870         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2871         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2872         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2873         (WebTestRunner):
2874         (WebTestThemeControlWin):
2875         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2876         (WebTestRunner):
2877         (WebTestThemeEngineMac):
2878         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2879         (+[FakeActiveWindow alwaysActiveWindow]):
2880         (+[FakeActiveWindow alwaysInactiveWindow]):
2881         (-[FakeActiveWindow initWithActiveControls:]):
2882         (-[FakeActiveWindow _hasActiveControls]):
2883         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2884         (WebTestRunner):
2885         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2886         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2887         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2888         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2889         (WebTestRunner):
2890         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2891         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2892         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2893         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2894         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2895         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2896         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2897         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2898         (WebTestRunner::WebTestThemeEngineWin::getSize):
2899         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2900         (WebTestRunner):
2901         (WebTestThemeEngineWin):
2902         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2903         * DumpRenderTree/chromium/TestShell.cpp:
2904         (TestShell::initialize):
2905         * DumpRenderTree/chromium/TestShell.h:
2906         (WebKit):
2907         * DumpRenderTree/chromium/TestShellMac.mm:
2908         (platformInit):
2909         * DumpRenderTree/chromium/TestShellWin.cpp:
2910         (platformInit):
2911         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2912
2913 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2914
2915         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2916
2917         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2918         New property sheet that does not link against CoreFoundation and
2919         CFNetwork.
2920         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2921         Use new TestWebKitAPICommonWinCairo property sheet.
2922         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2923         Ditto.
2924
2925 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2926
2927         [WinCairo] Unreviewed build fix for VS2010.
2928
2929         Had to add WinCairo-specific property sheets to deal with some
2930         library and path differences with the main Apple port.
2931
2932         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2933         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2934         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2935         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2936         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2937         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2938
2939 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2940
2941         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2942         https://bugs.webkit.org/show_bug.cgi?id=112849
2943
2944         Reviewed by Sam Weinig.
2945
2946         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2949
2950 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2951
2952         [WinCairo] Build WebKit Tools under VS2010
2953         https://bugs.webkit.org/show_bug.cgi?id=112821
2954
2955         Reviewed by Tim Horton.
2956
2957         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2958         Add WinCairo-specific build target.
2959         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2960         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2961         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2962         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2963         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2964         Add WinCairo-specific build target.
2965         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2966         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2967         Add WinCairo-specific build target.
2968         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2969         WinCairo-specific build target.
2970         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2971         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2972         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2973         specific build target.
2974         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2975         WinCairo-specific build target.
2976         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2977         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2978         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2979
2980 2013-03-20  Roger Fong  <roger_fong@apple.com>
2981
2982         API test gardening AppleWin port.
2983
2984         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2985
2986         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2987         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2988
2989 2013-03-20  Roger Fong  <roger_fong@apple.com>
2990
2991         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2992
2993         * EWSTools/start-queue-win.sh:
2994
2995 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2996
2997         Unreviewed, add myself to committers.py.
2998
2999 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3000
3001         Unreviewed. Adding another email for me.
3002
3003         * Scripts/webkitpy/common/config/committers.py:
3004
3005 2013-03-20  Justin Novosad  <junov@google.com>
3006
3007         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
3008         https://bugs.webkit.org/show_bug.cgi?id=112605
3009
3010         Reviewed by James Robinson.
3011
3012         Deleting all the code that was used for propagating and supporting
3013         the Chromium setting for disabling deferred 2d canvas rendering.
3014
3015         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3016         (main):
3017         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3018         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3019         (WebTestRunner::WebPreferences::reset):
3020         (WebTestRunner::WebPreferences::applyTo):
3021         * DumpRenderTree/chromium/TestShell.cpp:
3022         (TestShell::TestShell):
3023         (TestShell::resetWebSettings):
3024         (TestShell::runFileTest):
3025         * DumpRenderTree/chromium/TestShell.h:
3026         (TestShell):
3027
3028 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
3029
3030         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
3031         https://bugs.webkit.org/show_bug.cgi?id=112699.
3032
3033         Reviewed by Adam Barth.
3034
3035         * Scripts/webkitpy/layout_tests/port/qt.py:
3036         (QtPort._search_paths):
3037         (QtPort._port_specific_expectations_files):
3038         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3039         (QtPortTest):
3040         (QtPortTest._assert_search_path):
3041         (QtPortTest._assert_expectations_files):
3042
3043 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3044
3045         [Qt] Enable kerning by default
3046         https://bugs.webkit.org/show_bug.cgi?id=112704
3047
3048         Reviewed by Jocelyn Turcotte.
3049
3050         Disable kerning by default, since some reference test expectations
3051         expect kerning to be default off.
3052
3053         * DumpRenderTree/qt/TestRunnerQt.cpp:
3054         (TestRunnerQt::reset):
3055         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3056         (WTR::activateFonts):
3057
3058 2013-03-20  Zeno Albisser  <zeno@webkit.org>
3059
3060         [Qt] Remove empty function stubs from TestRunnerQt.
3061         https://bugs.webkit.org/show_bug.cgi?id=112799
3062
3063         We are reducing the code in TestRunnerQt step by step,
3064         in order to finally replace all of it with the generic
3065         TestRunner implementation.
3066         This patch removes several simple function stubs that
3067         currently do not implement any actual functionality.
3068
3069         Reviewed by Kenneth Rohde Christiansen.
3070
3071         * DumpRenderTree/qt/TestRunnerQt.cpp:
3072         * DumpRenderTree/qt/TestRunnerQt.h:
3073         (TestRunnerQt):
3074
3075 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3076
3077         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
3078         https://bugs.webkit.org/show_bug.cgi?id=112687
3079
3080         Reviewed by Kenneth Rohde Christiansen.
3081
3082         Hide the SearchBar by default on window creation.
3083
3084         * MiniBrowser/efl/main.c:
3085         (window_create):
3086
3087 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3088
3089         Unreviewed, rolling out r146304.
3090         http://trac.webkit.org/changeset/146304
3091         https://bugs.webkit.org/show_bug.cgi?id=112788
3092
3093         to many expectations to update (Requested by antonm on
3094         #webkit).
3095
3096         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3097         * DumpRenderTree/DumpRenderTree.gypi:
3098         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3099         (WebKit):
3100         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3101         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3102         (TestInterfaces):
3103         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3104         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3105         * DumpRenderTree/chromium/TestShell.cpp:
3106         (TestShell::initialize):
3107         * DumpRenderTree/chromium/TestShell.h:
3108         (WebKit):
3109         * DumpRenderTree/chromium/TestShellMac.mm:
3110         (platformInit):
3111         * DumpRenderTree/chromium/TestShellWin.cpp:
3112         (platformInit):
3113         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3114         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3115         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3116         (WebThemeControlDRTWin::box):
3117         (WebThemeControlDRTWin::line):
3118         (WebThemeControlDRTWin::triangle):
3119         (WebThemeControlDRTWin::roundRect):
3120         (WebThemeControlDRTWin::oval):
3121         (WebThemeControlDRTWin::circle):
3122         (WebThemeControlDRTWin::nestedBoxes):
3123         (WebThemeControlDRTWin::markState):
3124         (WebThemeControlDRTWin::draw):
3125         (WebThemeControlDRTWin::drawTextField):
3126         (WebThemeControlDRTWin::drawProgressBar):
3127         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3128         (WebThemeControlDRTWin):
3129         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3130         (WebThemeEngineDRTMac):
3131         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3132         (+[FakeActiveWindow alwaysActiveWindow]):
3133         (+[FakeActiveWindow alwaysInactiveWindow]):
3134         (-[FakeActiveWindow initWithActiveControls:]):
3135         (-[FakeActiveWindow _hasActiveControls]):
3136         (WebThemeEngineDRTMac::paintScrollbarThumb):
3137         (stateToHIEnableState):
3138         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3139         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3140         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3141         (webRectToSkIRect):
3142         (drawControl):
3143         (drawTextField):
3144         (drawProgressBar):
3145         (WebThemeEngineDRTWin::paintButton):
3146         (WebThemeEngineDRTWin::paintMenuList):
3147         (WebThemeEngineDRTWin::paintScrollbarArrow):
3148         (WebThemeEngineDRTWin::paintScrollbarThumb):
3149         (WebThemeEngineDRTWin::paintScrollbarTrack):
3150         (WebThemeEngineDRTWin::paintSpinButton):
3151         (WebThemeEngineDRTWin::paintTextField):
3152         (WebThemeEngineDRTWin::paintTrackbar):
3153         (WebThemeEngineDRTWin::paintProgressBar):
3154         (WebThemeEngineDRTWin::getSize):
3155         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3156         (WebThemeEngineDRTWin):
3157         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3158
3159 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3160
3161         [Qt] Support -webkit-font-smoothing
3162         https://bugs.webkit.org/show_bug.cgi?id=106009
3163
3164         Reviewed by Jocelyn Turcotte.
3165
3166         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3167
3168         * DumpRenderTree/qt/TestRunnerQt.cpp:
3169         (TestRunnerQt::reset):
3170
3171 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3172
3173         [GTK] accessibility/aria-scrollbar-role.html is failing
3174         https://bugs.webkit.org/show_bug.cgi?id=98358
3175
3176         Reviewed by Martin Robinson.
3177
3178         Adds support for checking accessibility object's orientation.
3179         Orientation is checked by retrieving proper state of accessibility object.
3180
3181         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3182         (checkElementState):
3183         (AccessibilityUIElement::orientation):
3184         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3185         (WTR::AccessibilityUIElement::orientation):
3186
3187 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3188
3189         [chromium] move WebThemeEngine implementations to TestRunner library
3190         https://bugs.webkit.org/show_bug.cgi?id=112751
3191
3192         Reviewed by Adam Barth.
3193
3194         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3195         * DumpRenderTree/DumpRenderTree.gypi:
3196         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3197         (WebKit):
3198         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3199         (WebTestRunner::TestInterfaces::themeEngine):
3200         (WebTestRunner):
3201         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3202         (WebKit):
3203         (TestInterfaces):
3204         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3205         (WebTestRunner::WebTestInterfaces::themeEngine):
3206         (WebTestRunner):
3207         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3208         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3209         (WebTestRunner):
3210         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3211         (WebTestRunner::WebTestThemeControlWin::box):
3212         (WebTestRunner::WebTestThemeControlWin::line):
3213         (WebTestRunner::WebTestThemeControlWin::triangle):
3214         (WebTestRunner::WebTestThemeControlWin::roundRect):
3215         (WebTestRunner::WebTestThemeControlWin::oval):
3216         (WebTestRunner::WebTestThemeControlWin::circle):
3217         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3218         (WebTestRunner::WebTestThemeControlWin::markState):
3219         (WebTestRunner::WebTestThemeControlWin::draw):
3220         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3221         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3222         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3223         (WebTestRunner):
3224         (WebTestThemeControlWin):
3225         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3226         (WebTestRunner):
3227         (WebTestThemeEngineMac):
3228         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3229         (+[FakeActiveWindow alwaysActiveWindow]):
3230         (+[FakeActiveWindow alwaysInactiveWindow]):
3231         (-[FakeActiveWindow initWithActiveControls:]):
3232         (-[FakeActiveWindow _hasActiveControls]):
3233         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3234         (WebTestRunner):
3235         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3236         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3237         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3238         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3239         (WebTestRunner):
3240         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3241         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3242         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3243         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3244         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3245         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3246         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3247         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3248         (WebTestRunner::WebTestThemeEngineWin::getSize):
3249         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3250         (WebTestRunner):
3251         (WebTestThemeEngineWin):
3252         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3253         * DumpRenderTree/chromium/TestShell.cpp:
3254         (TestShell::initialize):
3255         * DumpRenderTree/chromium/TestShell.h:
3256         (WebKit):
3257         * DumpRenderTree/chromium/TestShellMac.mm:
3258         (platformInit):
3259         * DumpRenderTree/chromium/TestShellWin.cpp:
3260         (platformInit):
3261         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3262
3263 2013-03-19  Tony Chang  <tony@chromium.org>
3264
3265         Move testRunner.setTouchDragDropEnabled to internals.settings
3266         https://bugs.webkit.org/show_bug.cgi?id=112739
3267
3268         Reviewed by Adam Barth.
3269
3270         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3271         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3272         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3273         (TestRunner): Remove unnecessary code.
3274         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3275         (WebTestRunner::WebPreferences::reset):
3276         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3277
3278 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3279
3280         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3281         https://bugs.webkit.org/show_bug.cgi?id=112754
3282
3283         Reviewed by Darin Fisher.
3284
3285         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3286         now that it's always defined.
3287
3288         * DumpRenderTree/chromium/WebViewHost.cpp:
3289         * DumpRenderTree/chromium/WebViewHost.h:
3290         (WebViewHost):
3291
3292 2013-03-19  Kenneth Russell  <kbr@google.com>
3293
3294         Unreviewed, rolling out r146290.
3295         http://trac.webkit.org/changeset/146290
3296         https://bugs.webkit.org/show_bug.cgi?id=112751
3297
3298         Broke Chromium Mac build.
3299
3300         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3301         * DumpRenderTree/DumpRenderTree.gypi:
3302         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3303         (WebKit):
3304         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3305         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3306         (TestInterfaces):
3307         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3308         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3309         * DumpRenderTree/chromium/TestShell.cpp:
3310         (TestShell::initialize):
3311         * DumpRenderTree/chromium/TestShell.h:
3312         (WebKit):
3313         * DumpRenderTree/chromium/TestShellMac.mm:
3314         (platformInit):
3315         * DumpRenderTree/chromium/TestShellWin.cpp:
3316         (platformInit):
3317         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3318         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3319         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3320         (WebThemeControlDRTWin::box):
3321         (WebThemeControlDRTWin::line):
3322         (WebThemeControlDRTWin::triangle):
3323         (WebThemeControlDRTWin::roundRect):
3324         (WebThemeControlDRTWin::oval):
3325         (WebThemeControlDRTWin::circle):
3326         (WebThemeControlDRTWin::nestedBoxes):
3327         (WebThemeControlDRTWin::markState):
3328         (WebThemeControlDRTWin::draw):
3329         (WebThemeControlDRTWin::drawTextField):
3330         (WebThemeControlDRTWin::drawProgressBar):
3331         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3332         (WebThemeControlDRTWin):
3333         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3334         (WebThemeEngineDRTMac):
3335         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3336         (+[FakeActiveWindow alwaysActiveWindow]):
3337         (+[FakeActiveWindow alwaysInactiveWindow]):
3338         (-[FakeActiveWindow initWithActiveControls:]):
3339         (-[FakeActiveWindow _hasActiveControls]):
3340         (WebThemeEngineDRTMac::paintScrollbarThumb):
3341         (stateToHIEnableState):
3342         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3343         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3344         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3345         (webRectToSkIRect):
3346         (drawControl):
3347         (drawTextField):
3348         (drawProgressBar):
3349         (WebThemeEngineDRTWin::paintButton):
3350         (WebThemeEngineDRTWin::paintMenuList):
3351         (WebThemeEngineDRTWin::paintScrollbarArrow):
3352         (WebThemeEngineDRTWin::paintScrollbarThumb):
3353         (WebThemeEngineDRTWin::paintScrollbarTrack):
3354         (WebThemeEngineDRTWin::paintSpinButton):
3355         (WebThemeEngineDRTWin::paintTextField):
3356         (WebThemeEngineDRTWin::paintTrackbar):
3357         (WebThemeEngineDRTWin::paintProgressBar):
3358         (WebThemeEngineDRTWin::getSize):
3359         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3360         (WebThemeEngineDRTWin):
3361         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3362
3363 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3364
3365         [EFL] canvas-fallback-content.html is failing
3366         https://bugs.webkit.org/show_bug.cgi?id=111998
3367
3368         Reviewed by Chris Fleizach.
3369
3370         Adds support for getting platform name.
3371
3372         * DumpRenderTree/TestRunner.cpp:
3373         (TestRunner::staticValues):
3374         * DumpRenderTree/TestRunner.h:
3375         (TestRunner):
3376         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3377         (TestRunner::platformName):
3378
3379 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3380
3381         [chromium] move WebThemeEngine implementations to TestRunner library
3382         https://bugs.webkit.org/show_bug.cgi?id=112751
3383
3384         Reviewed by Adam Barth.
3385
3386         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3387         * DumpRenderTree/DumpRenderTree.gypi:
3388         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3389         (WebKit):
3390         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3391         (WebTestRunner::TestInterfaces::themeEngine):
3392         (WebTestRunner):
3393         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3394         (WebKit):
3395         (TestInterfaces):
3396         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3397         (WebTestRunner::WebTestInterfaces::themeEngine):
3398         (WebTestRunner):
3399         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3400         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3401         (WebTestRunner):
3402         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3403         (WebTestRunner::WebTestThemeControlWin::box):
3404         (WebTestRunner::WebTestThemeControlWin::line):
3405         (WebTestRunner::WebTestThemeControlWin::triangle):
3406         (WebTestRunner::WebTestThemeControlWin::roundRect):
3407         (WebTestRunner::WebTestThemeControlWin::oval):
3408         (WebTestRunner::WebTestThemeControlWin::circle):
3409         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3410         (WebTestRunner::WebTestThemeControlWin::markState):
3411         (WebTestRunner::WebTestThemeControlWin::draw):
3412         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3413         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3414         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3415         (WebTestRunner):
3416         (WebTestThemeControlWin):
3417         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3418         (WebTestRunner):
3419         (WebTestThemeEngineMac):
3420         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3421         (+[FakeActiveWindow alwaysActiveWindow]):
3422         (+[FakeActiveWindow alwaysInactiveWindow]):
3423         (-[FakeActiveWindow initWithActiveControls:]):
3424         (-[FakeActiveWindow _hasActiveControls]):
3425         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3426         (WebTestRunner):
3427         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3428         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3429         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3430         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3431         (WebTestRunner):
3432         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3433         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3434         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3435         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3436         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3437         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3438         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3439         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3440         (WebTestRunner::WebTestThemeEngineWin::getSize):
3441         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3442         (WebTestRunner):
3443         (WebTestThemeEngineWin):
3444         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3445         * DumpRenderTree/chromium/TestShell.cpp:
3446         (TestShell::initialize):
3447         * DumpRenderTree/chromium/TestShell.h:
3448         (WebKit):
3449         * DumpRenderTree/chromium/TestShellMac.mm:
3450         (platformInit):
3451         * DumpRenderTree/chromium/TestShellWin.cpp:
3452         (platformInit):
3453         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3454
3455 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3456
3457         [EFL][WK2] Separate WebView further from EwkView
3458         https://bugs.webkit.org/show_bug.cgi?id=111591
3459
3460         Reviewed by Caio Marcelo de Oliveira Filho.
3461
3462         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3463         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3464         since we can afford it having EWKViewGetWKView() private API to access WKView.
3465
3466         * TestWebKitAPI/PlatformWebView.h:
3467         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3468         (TestWebKitAPI::TEST):
3469         * TestWebKitAPI/efl/PlatformWebView.cpp:
3470         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3471         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3472         (TestWebKitAPI::PlatformWebView::resizeTo):
3473         (TestWebKitAPI::PlatformWebView::page):
3474         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3475         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3476         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3477         * WebKitTestRunner/PlatformWebView.h:
3478         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3479         (WTR::EventSenderProxy::dispatchEvent):
3480         (WTR::EventSenderProxy::keyDown):
3481         (WTR::EventSenderProxy::sendTouchEvent):
3482         (WTR::EventSenderProxy::setTouchModifier):
3483         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3484         (WTR::PlatformWebView::PlatformWebView):
3485         (WTR::PlatformWebView::~PlatformWebView):
3486         (WTR::PlatformWebView::resizeTo):
3487         (WTR::PlatformWebView::page):
3488         (WTR::PlatformWebView::focus):
3489         (WTR::PlatformWebView::windowSnapshotImage):
3490
3491 2013-03-19  Roger Fong  <roger_fong@apple.com>
3492
3493         Changes to VS2010 project files should only trigger builds on Windows bots.
3494         https://bugs.webkit.org/show_bug.cgi?id=112731
3495
3496         Reviewed by Timothy Horton.
3497
3498         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3499         (_should_file_trigger_build):
3500
3501 2013-03-19  Roger Fong  <roger_fong@apple.com>
3502
3503         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3504
3505         * Scripts/webkitpy/tool/steps/runtests.py:
3506         (RunTests.run):
3507         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3508         (RunTestsTest.test_webkit_run_unit_tests):
3509
3510 2013-03-19  Julie Parent  <jparent@chromium.org>
3511
3512         Dashboards: Introduce history namespace and unit tests.
3513         https://bugs.webkit.org/show_bug.cgi?id=112645
3514
3515         Reviewed by Ojan Vafai.
3516         
3517         Laying the framework for introducing the new history object and
3518         namespace.  This moves only static functions into the history
3519         namespace, and moves corresponding unit tests into seperate
3520         unit test file.
3521
3522         * TestResultServer/static-dashboards/aggregate_results.html:
3523         * TestResultServer/static-dashboards/dashboard_base.js:
3524         (parseCrossDashboardParameters):
3525         (parseDashboardSpecificParameters):
3526         (parseParameters):
3527         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3528         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3529         (.switch.return):
3530         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3531         * TestResultServer/static-dashboards/history.js: Added.
3532         * TestResultServer/static-dashboards/history_unittests.js: Added.
3533         * TestResultServer/static-dashboards/loader.js:
3534         (.):
3535         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3536         * TestResultServer/static-dashboards/run-unittests.html:
3537         * TestResultServer/static-dashboards/timeline_explorer.html:
3538         * TestResultServer/static-dashboards/timeline_explorer.js:
3539         * TestResultServer/static-dashboards/treemap.html:
3540         * TestResultServer/static-dashboards/treemap.js:
3541         (.switch.return):
3542         * TestResultServer/static-dashboards/ui.js:
3543
3544 2013-03-19  Daniel Bates  <dbates@webkit.org>
3545
3546         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3547         https://bugs.webkit.org/show_bug.cgi?id=112732
3548
3549         Reviewed by Eric Seidel.
3550
3551         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3552         of an existing file cannot be applied.
3553
3554         In particular, svn-{apply, unapply} compensate for differences in line endings
3555         by converting the line endings in a diff to match the line endings in the target
3556         file. The diff(1) command precedes the last line of a diff that adds a newline
3557         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3558         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3559         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3560         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3561         the newline characters in this special character sequence to match the line endings
3562         in the target file.
3563
3564         * Scripts/VCSUtils.pm:
3565         (parseDiff):
3566         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3567         Added tests:
3568             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3569             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3570             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3571             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3572         (escapeNewLineCharacters): Added.
3573         (toMacLineEndings): Added.
3574
3575 2013-03-19  James Robinson  <jamesr@chromium.org>
3576
3577         [chromium] Remove compositor settings that don't go through WebKit
3578         https://bugs.webkit.org/show_bug.cgi?id=112718
3579
3580         Reviewed by Adam Barth.
3581
3582         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3583         (main):
3584         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3585         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3586         (WebTestRunner::WebPreferences::reset):
3587         (WebTestRunner::WebPreferences::applyTo):
3588         * DumpRenderTree/chromium/TestShell.cpp:
3589         (TestShell::TestShell):
3590         (TestShell::resetWebSettings):
3591         * DumpRenderTree/chromium/TestShell.h:
3592         (TestShell):
3593
3594 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3595
3596         Unreviewed, rolling out r146101.
3597         https://bugs.webkit.org/show_bug.cgi?id=111884
3598
3599         re-enable custom freetype on asan; this needs to be on
3600         now that the bot is running lucid.
3601
3602         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3603
3604 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3605
3606         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3607         https://bugs.webkit.org/show_bug.cgi?id=112365
3608
3609         Reviewed by Benjamin Poulain.
3610
3611         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3612         harcoding it in wtf/Platform.h
3613
3614         * Scripts/webkitperl/FeatureList.pm:
3615
3616 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3617
3618         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3619         https://bugs.webkit.org/show_bug.cgi?id=94782
3620
3621         Based on patch by Csaba Osztrogonác.
3622         Reviewed by Jocelyn Turcotte.
3623
3624         The diff image is generated with bright red indicating errors, but letting the base image
3625         shine through so the context of the error-pixel can be identified.
3626
3627         * DumpRenderTree/qt/ImageDiff.cpp:
3628         (main):
3629
3630 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3631
3632         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3633
3634         Rubber-stamped by Csaba Osztrogonác.
3635
3636         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3637         since the latter might not cover the former.
3638
3639         * QtTestBrowser/launcherwindow.cpp:
3640         (LauncherWindow::print):
3641
3642 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3643
3644         Style tweeks to default.css.
3645         
3646         Rubber-stamped by David Kilzer.
3647         
3648         Give visited links a different color to other links, so you can
3649         see which builds you've viewed.
3650         
3651         Make the <small> text less tiny.
3652
3653         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3654         (small):
3655         (a:link,a:visited,a:active):
3656         (a:visited):
3657
3658 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3659
3660         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3661         https://bugs.webkit.org/show_bug.cgi?id=112494
3662
3663         Reviewed by Dirk Pranke.
3664
3665         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3666         Also merged two pairs of methods to cleanup the code.
3667
3668         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3669         (PerfTestsRunner.run): Merged _upload_and_show_results.
3670         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3671
3672 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3673
3674         [chromium] build xdisplaycheck when building DRT
3675         https://bugs.webkit.org/show_bug.cgi?id=112636
3676
3677         Reviewed by Tony Chang.
3678
3679         It appears that we need xdisplaycheck to be built in order for
3680         Xvfb to be started correctly on the bots, and DRT was missing
3681         a dependency on it. This may be the cause of the ASAN bot not
3682         starting up properly (it only builds DRT).
3683
3684         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3685
3686 2013-03-18  David Levin  <levin@chromium.org>
3687
3688         Implement icon change notification dump for Chromium's test shell.
3689         https://bugs.webkit.org/show_bug.cgi?id=112614
3690
3691         This was previously implemented for some other platforms in r58111
3692         and r116547.
3693
3694         In r122806, fast/dom/icon-url-property.html stopped using it, but
3695         it is useful for tests, so I plan to re-add it to that test again.
3696
3697         Reviewed by Jochen Eisinger.
3698
3699         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3700         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3701          icon change notifications from WebKit may be logged in test output.
3702         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3703         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3704         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3705         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3706         (WebTestRunner):
3707         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3708         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3709         (TestRunner):
3710         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3711         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3712         (WebTestRunner):
3713         * DumpRenderTree/chromium/WebViewHost.cpp:
3714         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3715         * DumpRenderTree/chromium/WebViewHost.h:
3716         (WebViewHost):
3717
3718 2013-03-18  Julie Parent  <jparent@chromium.org>
3719
3720         Cleanup: Move js for treemap and aggregate_results into own js files.
3721         https://bugs.webkit.org/show_bug.cgi?id=112618
3722
3723         Reviewed by Dirk Pranke.
3724         
3725         No functional changes, just moving the code into separate js file
3726         rather than inlined in the html, so we can test it, make it more
3727         modular, etc.  Other dashboard types are already done this way.
3728
3729         * TestResultServer/static-dashboards/aggregate_results.html:
3730         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3731         (generatePage):
3732         (handleValidHashParameter):
3733         (htmlForBuilder):
3734         (rawValuesHTML):
3735         (chartHTML):
3736         (filteredValues):
3737         (chart):
3738         (htmlForRevisionRows):
3739         (wrapHTMLInTable):
3740         (htmlForSummaryTable):
3741         (valuesPerExpectation):
3742         (htmlForTestType):
3743         (htmlForTableRow):
3744         (extendedEncode):
3745         * TestResultServer/static-dashboards/treemap.html:
3746         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3747         (humanReadableTime):
3748         (convertToWebTreemapFormat):
3749         (reverseSortByAverage):
3750         (generatePage):
3751         (focusPath):
3752         (.switch.return):
3753         (handleQueryParameterChange):
3754         (extractName):
3755         (fullName):
3756         (handleFocus.):
3757         (handleFocus):
3758
3759 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3760
3761         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3762         https://bugs.webkit.org/show_bug.cgi?id=112622
3763
3764         Reviewed by Dirk Pranke.
3765
3766         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3767         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3768
3769 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3770
3771         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3772         https://bugs.webkit.org/show_bug.cgi?id=112619
3773
3774         Reviewed by Dirk Pranke.
3775
3776         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3777         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3778
3779         * Scripts/webkitpy/layout_tests/port/gtk.py:
3780         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3781         Port._webkit_baseline_path method.
3782         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3783         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3784         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3785         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3786         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3787         that are expected based on the builder name.
3788
3789 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3790
3791         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3792         https://bugs.webkit.org/show_bug.cgi?id=112571
3793
3794         Reviewed by Adam Barth.
3795
3796         Update function declarations for new WebFileSystemType enum. (All
3797         changes are behind an #ifdef so we can sync required changes in embedders.)
3798
3799         * DumpRenderTree/chromium/WebViewHost.cpp:
3800         (WebViewHost::openFileSystem):
3801         (WebViewHost::deleteFileSystem):
3802         * DumpRenderTree/chromium/WebViewHost.h:
3803         (WebViewHost):
3804
3805 2013-03-18  Julie Parent  <jparent@chromium.org>
3806
3807         Cleanup: Move timeline_exporer js out of html file into js.
3808         https://bugs.webkit.org/show_bug.cgi?id=112188
3809
3810         Reviewed by Dirk Pranke.
3811         
3812         Moves the javascript out of the html file and into a new js file.
3813         This follows the format of flakiness_dashboard.{html|js}.
3814         
3815         Also moves code from dashboard_base that is used only by this one
3816         dashboard, and makes it private to the dashboard.
3817
3818         * TestResultServer/static-dashboards/dashboard_base.js:
3819         * TestResultServer/static-dashboards/timeline_explorer.html:
3820         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3821         (generatePage):
3822         (initCurrentBuilderTestResults):
3823         (shouldShowWebKitRevisionsOnly):
3824         (updateTimelineForBuilder.):
3825         (updateTimelineForBuilder):
3826         (selectBuild):
3827         (updateBuildIndicator):
3828         (.addRow):
3829         (.addNumberRow):
3830         (.inspectorNode.getElementsByTagName.0.onclick):
3831         (.inspectorNode.getElementsByTagName.1.onclick):
3832         (.inspectorNode.getElementsByTagName.2.onclick):
3833         (updateBuildInspector):
3834         (showResultsDelta):
3835         (decompressResults.addFlakyDelta):
3836         (decompressResults):
3837
3838 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3839
3840         Unreviewed, rolling out r145272.
3841         http://trac.webkit.org/changeset/145272
3842         https://bugs.webkit.org/show_bug.cgi?id=111884
3843
3844         Turns out the ASAN build is still broken; possibly there's
3845         something still setting LD_LIBRARY_PATH, or possibly there's
3846         something else wrong. In the meantime, we need it to work again.
3847
3848         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3849
3850 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3851
3852         delete-stale-build-files is too aggressive
3853         https://bugs.webkit.org/show_bug.cgi?id=112595
3854
3855         Reviewed by Tim Horton.
3856
3857         It appears that whitelisting file extensions to keep is not a good idea.
3858         Blacklist files to delete instead, and only delete .o files for now.
3859         We can add more file extensions as needed.
3860
3861         * BuildSlaveSupport/delete-stale-build-files:
3862
3863 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3864
3865         Disable accessibility notifications after each test
3866         https://bugs.webkit.org/show_bug.cgi?id=112579
3867
3868         Reviewed by Tim Horton.
3869         
3870         In WebKitTestRunner, if any tests triggered accessibility notifications,
3871         the global notification handler would thereafter be active, and fire
3872         notifications for all subsequent tests.
3873         
3874         Fix by implementing AccessibilityController::resetToConsistentState() for
3875         Mac, and using it to clear the global notification handler.
3876
3877         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3878         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3879         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3880         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3881         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3882         (e.g. because of -autorelease).
3883         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3884         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3885         if there is one.
3886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3887         Add -stopObserving
3888         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3889         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3890         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3891         center.
3892
3893 2013-03-18  Dana Jansens  <danakj@chromium.org>
3894
3895         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3896         https://bugs.webkit.org/show_bug.cgi?id=112392
3897
3898         Reviewed by James Robinson.
3899
3900         Removes the command line flag option from DRT.
3901
3902         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3903         (main):
3904
3905 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3906
3907         [GTK] plugins/plugin-clip-subframe.html is failing
3908         https://bugs.webkit.org/show_bug.cgi?id=112570
3909
3910         Reviewed by Martin Robinson.
3911
3912         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3913
3914 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3915
3916         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3917         https://bugs.webkit.org/show_bug.cgi?id=112442
3918
3919         Reviewed by Gustavo Noronha Silva.
3920
3921         * GtkLauncher/main.c:
3922         (reloadCb):
3923         (createToolbar):
3924         (createWindow):
3925
3926 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3927
3928         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3929         https://bugs.webkit.org/show_bug.cgi?id=112205
3930
3931         Disable this API test until Geoff can fix it.
3932
3933         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3934         (TestWebKitAPI::TEST):
3935
3936 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3937
3938         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3939         https://bugs.webkit.org/show_bug.cgi?id=112478
3940
3941         Reviewed by Tony Chang.
3942
3943         There is nothing that ensures that the log messages from the plugin
3944         come in before the layout test finished loading.
3945
3946         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3947         (PassDifferentNPPStruct::NPP_SetWindow):
3948         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3949         (NPP_SetWindow):
3950
3951 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3952
3953         Have the mac port support per_test_timeout in webkitpy
3954         https://bugs.webkit.org/show_bug.cgi?id=112466
3955
3956         Reviewed by Dirk Pranke.
3957         
3958         Both WTR and DRT handle --timeout arguments, so we can
3959         have the scripts pass the timeout values down to the tools.
3960
3961         * Scripts/webkitpy/layout_tests/port/mac.py:
3962         (MacPort.supports_per_test_timeout):
3963
3964 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3965
3966         Remove setAsynchronousSpellCheckingEnabled from test runners
3967         https://bugs.webkit.org/show_bug.cgi?id=112362
3968
3969         Reviewed by Tony Chang.
3970
3971         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3972         in internals.settings, so all ports can share it.
3973
3974         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3975         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3976         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3977         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3978         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3979         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3980         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3981         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3982         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3983         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3984         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3985         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3986
3987 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3988
3989         Fix the stupid unit tests.
3990
3991         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3992         (test_sample_process):
3993
3994 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3995
3996         Collect samples for unresponsive web processes
3997         https://bugs.webkit.org/show_bug.cgi?id=112409
3998
3999         Reviewed by Tim Horton.
4000         
4001         When we detect that a subprocess was unresponsive, run the 'sample'
4002         tool on that process, for the Mac port.
4003         
4004         The sample will be linked to from the results.html page, next
4005         to the crash log link.
4006
4007         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4008         (Manager._look_for_new_crash_logs): Before looking for crash logs,
4009         look for samples on disk.
4010         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4011         (TestResultWriter):
4012         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
4013         -sample.txt files, and have it copy their contents to a new file
4014         next to the test that spawned them (as we do for crash logs).
4015         * Scripts/webkitpy/layout_tests/port/base.py:
4016         (Port.look_for_new_samples): Base class does nothing for sampling.
4017         * Scripts/webkitpy/layout_tests/port/driver.py:
4018         (Driver._check_for_driver_crash): Kick off a sample if we detected
4019         that the subprocess was unresponsive.
4020         * Scripts/webkitpy/layout_tests/port/mac.py:
4021         (MacPort.sample_file_path): Utility to generate the file path
4022         to the generated sample files at the top level of layout-test-results.
4023         (MacPort.look_for_new_crash_logs): Fix typo
4024         (MacPort.look_for_new_samples): New function to find sample files.
4025         (MacPort.sample_process): Use the utility function to get the file path.
4026
4027 2013-03-15  Zeno Albisser  <zeno@webkit.org>
4028
4029         [Qt] Remove simple getters and setters from TestRunnerQt
4030         https://bugs.webkit.org/show_bug.cgi?id=112343
4031
4032         Reviewed by Benjamin Poulain.
4033
4034         The removed functions and boolean members
4035         are being replaced by the implementations in the
4036         generic TestRunner.h.
4037
4038         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4039         (DumpRenderTree::dumpFrameScrollPosition):
4040         (DumpRenderTree::dumpFramesAsText):
4041         (DumpRenderTree::dump):
4042         (DumpRenderTree::titleChanged):
4043         (DumpRenderTree::dumpDatabaseQuota):
4044         (DumpRenderTree::dumpApplicationCacheQuota):
4045         (DumpRenderTree::statusBarMessage):
4046         (DumpRenderTree::createWindow):
4047         * DumpRenderTree/qt/TestRunnerQt.cpp:
4048         (TestRunnerQt::reset):
4049         * DumpRenderTree/qt/TestRunnerQt.h:
4050         (TestRunnerQt):
4051
4052 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
4053
4054         Update the link on build.webkit.org to refer to perf.webkit.org
4055         https://bugs.webkit.org/show_bug.cgi?id=112416
4056
4057         Reviewed by Philip Rogers.
4058
4059         Updated the link. Also updated the template to use HTML5 DOCTYPE.
4060
4061         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4062
4063 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
4064
4065         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
4066         https://bugs.webkit.org/show_bug.cgi?id=112394
4067
4068         Reviewed by Philippe Normand.
4069
4070         * GtkLauncher/main.c:
4071         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
4072
4073 2013-03-14  Andreas Kling  <akling@apple.com>
4074
4075         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
4076         <http://webkit.org/b/111815>
4077         <rdar://problem/13380145>
4078
4079         Reviewed by Anders Carlsson.
4080
4081         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
4082         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
4083         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
4084
4085         * WebKitTestRunner/PlatformWebView.h:
4086         (PlatformWebView):
4087         * WebKitTestRunner/TestController.cpp:
4088         (WTR::TestController::createOtherPage):
4089         (WTR::TestController::createWebViewWithOptions):
4090         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4091         (WTR::PlatformWebView::didInitializeClients):
4092
4093 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4094
4095         [EFL][MiniBrowser] Add a search field to the MiniBrowser
4096         https://bugs.webkit.org/show_bug.cgi?id=112122
4097
4098         Reviewed by Kenneth Rohde Christiansen.
4099
4100         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
4101
4102         * MiniBrowser/efl/main.c:
4103         (_Browser_Window):
4104         (search_box_show):
4105         (search_box_hide):
4106         (on_key_down):
4107         (on_url_changed):
4108         (on_search_field_aborted):
4109         (on_search_field_activated):
4110         (on_search_field_clicked):
4111         (on_search_backward_button_clicked):
4112         (on_search_forward_button_clicked):
4113         (window_create):
4114
4115 2013-03-14  Julie Parent  <jparent@chromium.org>
4116
4117         Cleanup: Remove g_resourceLoader.
4118         https://bugs.webkit.org/show_bug.cgi?id=112305
4119
4120         Reviewed by Dirk Pranke.
4121         
4122         Removing another global.
4123         
4124         Now, each dashboard creates its own loader, rather than having
4125         a general global one.
4126         
4127         Remove usage of g_resourceLoader.isLoadingComplete from 
4128         handleLocationChange by ensuring that handleLocationChange is
4129         never called before the loader is done.  It was called in two
4130         places before: 1 was from the callback when the loader is done,
4131         so that was obviously true, and the other was from onhashchange,
4132         where it would just return rather than running.  Instead, lets
4133         only register the onhashchange handler once the loader is
4134         setup, so the check is no longer necessary.
4135         
4136         Remove isLoadingComplete since it is now unused.
4137         
4138         Callback for loader is now initializeHistory, rather than just
4139         handleLocationChange which will set up the hashchange handler now.
4140         This will all eventually be moving to a new History object.
4141
4142         * TestResultServer/static-dashboards/aggregate_results.html:
4143         * TestResultServer/static-dashboards/dashboard_base.js:
4144         (handleLocationChange):
4145         (intializeHistory):
4146         (decompressResults):
4147         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4148         (generatePage):
4149         * TestResultServer/static-dashboards/loader.js:
4150         (.):
4151         * TestResultServer/static-dashboards/loader_unittests.js:
4152         * TestResultServer/static-dashboards/timeline_explorer.html:
4153         * TestResultServer/static-dashboards/treemap.html:
4154
4155 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
4156
4157         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
4158         https://bugs.webkit.org/show_bug.cgi?id=109404
4159
4160         Reviewed by Tony Chang.
4161
4162         Removes all the code related to smartInsertDeleteEnabled and
4163         selectTrailingWhitespaceEnabled settings as they will be managed from
4164         internals from now on.
4165
4166         * DumpRenderTree/TestRunner.cpp:
4167         (TestRunner::staticFunctions):
4168         * DumpRenderTree/TestRunner.h:
4169         (TestRunner):
4170         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4171         (WebKit):
4172         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4173         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4174         (DumpRenderTree):
4175         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4176         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4177         (WebTestRunner::WebTestProxy::didStopLoading):
4178         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4179         (WebTestRunner::TestRunner::TestRunner):
4180         (WebTestRunner::TestRunner::reset):
4181         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4182         (TestRunner):
4183         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4184         (WebTestRunner::WebPreferences::applyTo): Set default values for
4185         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4186         Chromium DRT default values are different from Chromium browser.
4187         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4188         * DumpRenderTree/chromium/WebViewHost.cpp:
4189         * DumpRenderTree/chromium/WebViewHost.h:
4190         (WebViewHost):
4191         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4192         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4193         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4194         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4195         (resetDefaultsToConsistentValues):
4196         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4197         * DumpRenderTree/mac/DumpRenderTree.mm:
4198         (resetWebViewToConsistentStateBeforeTesting):
4199         * DumpRenderTree/mac/TestRunnerMac.mm:
4200         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4201         (WebCore::WebPage::resetSettings):
4202         * DumpRenderTree/qt/TestRunnerQt.cpp:
4203         * DumpRenderTree/qt/TestRunnerQt.h:
4204         (TestRunnerQt):
4205         * DumpRenderTree/win/DumpRenderTree.cpp:
4206         (resetWebViewToConsistentStateBeforeTesting):
4207         * DumpRenderTree/win/TestRunnerWin.cpp:
4208         * DumpRenderTree/wx/TestRunnerWx.cpp:
4209
4210 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4211
4212         [Qt] Disable DRT on Windows
4213
4214         Reviewed by Jocelyn Turcotte.
4215
4216         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4217
4218         * qmake/mkspecs/features/configure.prf:
4219
4220 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4221
4222         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4223         https://bugs.webkit.org/show_bug.cgi?id=110728
4224
4225         Reviewed by Gyuyoung Kim.
4226
4227         Use the page group to create the view object.
4228
4229         * MiniBrowser/efl/main.c:
4230         (window_create):
4231
4232 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4233
4234         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4235
4236         Reviewed by Tor Arne Vestbø.
4237
4238         The mock versions of these web facing features should be instantiated when
4239         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4240         such as QtLocation are actually needed.
4241
4242         This patch decouples enabling device orientation/motion and geolocation from
4243         the underlying Qt modules and makes them available in developer builds
4244         (!production_build) and backed by mock backends when running in drt.
4245
4246         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4247         developers the web facing features are always enabled (although requests will
4248         time out) and the mock backends are enabled inside DRT, allowing for the layout
4249         tests to run with less dependencies.
4250
4251         In addition this also enables the mock device motion client, which was
4252         previously never instantiated.
4253
4254         * qmake/mkspecs/features/features.prf:
4255
4256 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4257
4258         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4259         https://bugs.webkit.org/show_bug.cgi?id=112340
4260
4261         Reviewed by Simon Hausmann.
4262
4263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4264         (DumpRenderTree::dump):
4265             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4266         (DumpRenderTree::dumpApplicationCacheQuota):
4267         * DumpRenderTree/qt/TestRunnerQt.cpp:
4268         (TestRunnerQt::reset):
4269         * DumpRenderTree/qt/TestRunnerQt.h:
4270         (TestRunnerQt):
4271
4272 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4273
4274         [Qt] Port DRT to use TestRunner::dumpAsText()
4275         https://bugs.webkit.org/show_bug.cgi?id=112260
4276
4277         Reviewed by Benjamin Poulain.
4278
4279         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4280         (WebCore::DumpRenderTree::open):
4281         (WebCore::methodNameStringForFailedTest):
4282             Change parameter from type TestRunnerQt* to TestRunner*.
4283         (WebCore::DumpRenderTree::dump):
4284             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4285             Instead we should rely on TestRunner::generatePixelResults().
4286         * DumpRenderTree/qt/TestRunnerQt.cpp:
4287         (TestRunnerQt::reset):
4288         * DumpRenderTree/qt/TestRunnerQt.h:
4289         (TestRunnerQt):
4290
4291 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4292
4293         Implement FontLoader interface
4294         https://bugs.webkit.org/show_bug.cgi?id=98395
4295
4296         Reviewed by Eric Seidel.
4297
4298         Enable FontLoadEvents runtime flag for TestShell.
4299