Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared...
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2
3         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4         https://bugs.webkit.org/show_bug.cgi?id=195511
5         <rdar://problem/44873269>
6
7         Reviewed by Darin Adler.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
10         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
11         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
12         (TEST_F):
13
14 2019-03-10  Tim Horton  <timothy_horton@apple.com>
15
16         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
17         https://bugs.webkit.org/show_bug.cgi?id=195499
18
19         Reviewed by Darin Adler.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
23         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
24         (-[WKWebView synchronouslyFocusTextInputContext:]):
25         (applyStyle):
26         (applyIframe):
27         (TEST):
28         Add some tests for this SPI.
29
30 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
31
32         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
33         https://bugs.webkit.org/show_bug.cgi?id=181151
34
35         Reviewed by Don Olmstead.
36
37         * TestWebKitAPI/CMakeLists.txt:
38         * TestWebKitAPI/PlatformWin.cmake:
39         Enable TestWTF RunLoop tests in all platforms.
40
41         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
42         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
43         (TestWebKitAPI::DerivedOneShotTimer::fired):
44         (TestWebKitAPI::TEST):
45         Only a few platforms support nested RunLoop.
46
47         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
48         (TestWebKitAPI::DerivedRepeatingTimer::fired):
49
50 2019-03-10  David Quesada  <david_quesada@apple.com>
51
52         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
53         https://bugs.webkit.org/show_bug.cgi?id=152480
54
55         Reviewed by Chris Dumez.
56
57         Add a unit test based on Daniel Bates's test case that starts a download, ensures
58         there are no additional references to the process pool besides the one held by
59         the download, waits for the download to finish (in the sense that the
60         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
61         measure, also check that the process pool has been deallocated at the end of the
62         test. The test wouldn't be meaningful if the process pool were still alive.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
65         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
66         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
67             The download will be canceled because the delegate does not implement the
68             method to decide the download's destination, so this is where we know the
69             DownloadProxyMap is done with the DownloadProxy.
70         (TEST):
71
72 2019-03-08  Chris Dumez  <cdumez@apple.com>
73
74         Add support for Device Orientation / Motion permission API
75         https://bugs.webkit.org/show_bug.cgi?id=195329
76         <rdar://problem/47645367>
77
78         Reviewed by Geoffrey Garen.
79
80         Add test infrastructure to help test the Device Orientation / Motion permission API.
81
82         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
83         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
84         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
85         * WebKitTestRunner/InjectedBundle/TestRunner.h:
86         * WebKitTestRunner/TestController.cpp:
87         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
88         (WTR::TestController::createWebViewWithOptions):
89         (WTR::TestController::resetStateToConsistentValues):
90         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
91         * WebKitTestRunner/TestController.h:
92         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
93         * WebKitTestRunner/TestInvocation.cpp:
94         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
95
96 2019-03-08  Saam barati  <sbarati@apple.com>
97
98         Add a compare-results script to compare benchmark results
99         https://bugs.webkit.org/show_bug.cgi?id=195486
100         <rdar://problem/48723397>
101
102         Reviewed by Geoffrey Garen.
103
104         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
105         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
106         to extend it to learn about our other benchmarks.
107
108         * Scripts/compare-results: Added.
109         (readJSONFile):
110         (detectJetStream2):
111         (JetStream2Results):
112         (detectSpeedometer2):
113         (Speedometer2Results):
114         (detectPLT5):
115         (PLT5Results):
116         (detectBenchmark):
117         (biggerIsBetter):
118         (ttest):
119         (getOptions):
120         (main):
121
122 2019-03-08  Stephanie Lewis  <slewis@apple.com>
123
124         Ensure old tab state is cleared between iterations of run-benchmark
125         https://bugs.webkit.org/show_bug.cgi?id=195393
126         <rdar://problem/46885583>
127
128         Reviewed by Dewei Zhu.
129
130         a) ensure the default to restore state is not set
131         b) terminate Safari correctly
132         c) Set the system default to ignore Persistent State in Safari
133
134         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
135         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
136         (OSXBrowserDriver.prepare_env): 
137         (OSXBrowserDriver.restore_env):
138         (OSXBrowserDriver.close_browsers):
139         (OSXBrowserDriver._terminate_processes):
140         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
141         (OSXChromeDriver):
142         (OSXChromeCanaryDriver):
143         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
144         (OSXFirefoxDriver):
145         (OSXFirefoxNightlyDriver):
146         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
147         (OSXSafariDriver):
148         (OSXSafariDriver.prepare_env):
149
150 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
151
152         [GTK] Several InputMethodFilter tests are failing
153         https://bugs.webkit.org/show_bug.cgi?id=195408
154
155         Reviewed by Carlos Garcia Campos.
156
157         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
158         Regressed in r241751.
159         Hexadecimal values of keycodes are expressed now in upper letters.
160         Composited characters should be cast to UTF8 strings.
161
162         (TestWebKitAPI::TEST):
163
164 2019-03-07  Tomas Popela  <tpopela@redhat.com>
165
166         [GTK] Make Tools/gtkdoc python3 compatible
167         https://bugs.webkit.org/show_bug.cgi?id=195359
168
169         Reviewed by Carlos Garcia Campos.
170
171         * gtkdoc/generate-gtkdoc:
172         ConfigParser was reworked in Python 3.2 so we have adapt the code to
173         work with Python 2 and 3.
174         (get_gtkdoc_module_paths):
175         The iteritems() was removed in Python 3, so let's use items() that's
176         available in Python 2 and 3.
177         (get_generator_for_config):
178         * gtkdoc/gtkdoc.py:
179         (GTKDoc._run_command):
180         The sys.stdout.write() is expecting str in Python 3 and not bytes
181         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
182         for passing the bytes there.
183
184 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
185
186         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
187         https://bugs.webkit.org/show_bug.cgi?id=195346
188         <rdar://problem/48667048>
189
190         Unreviewed build fix for clang-cl.
191
192         * DumpRenderTree/win/DumpRenderTree.cpp:
193         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
194
195 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
196
197         requestAnimationFrame should execute before the next frame
198         https://bugs.webkit.org/show_bug.cgi?id=177484
199
200         Reviewed by Simon Fraser.
201
202         Add trace points for the page RenderingUpdate.
203
204         * Tracing/SystemTracePoints.plist:
205
206 2019-03-07  Zalan Bujtas  <zalan@apple.com>
207
208         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
209         https://bugs.webkit.org/show_bug.cgi?id=195353
210         <rdar://problem/48626394>
211
212         Reviewed by Simon Fraser.
213
214         * WebKitTestRunner/ios/TestControllerIOS.mm:
215         (WTR::TestController::platformResetPreferencesToConsistentValues):
216
217 2019-03-07  John Wilander  <wilander@apple.com>
218
219         Resource Load Statistics: Make it possible to purge only script-accessible cookies
220         https://bugs.webkit.org/show_bug.cgi?id=195383
221         <rdar://problem/48570136>
222
223         Reviewed by Brent Fulgham.
224
225         This patch adds test infrastructure to purge only script-accessible cookies,
226         including a new testRunner function called statisticsDeleteCookiesForHost().git a
227
228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
229         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
230         (WTR::TestRunner::statisticsDeleteCookiesForHost):
231         * WebKitTestRunner/InjectedBundle/TestRunner.h:
232         * WebKitTestRunner/TestController.cpp:
233         (WTR::TestController::statisticsDeleteCookiesForHost):
234         * WebKitTestRunner/TestController.h:
235         * WebKitTestRunner/TestInvocation.cpp:
236         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
237
238 2019-03-07  Commit Queue  <commit-queue@webkit.org>
239
240         Unreviewed, rolling out r242354.
241         https://bugs.webkit.org/show_bug.cgi?id=195402
242
243         breaks layout tests in all configurations (Requested by
244         zdobersek on #webkit).
245
246         Reverted changeset:
247
248         "[WPE] Enable web process sandbox"
249         https://bugs.webkit.org/show_bug.cgi?id=195169
250         https://trac.webkit.org/changeset/242354
251
252 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
253
254         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
255         https://bugs.webkit.org/show_bug.cgi?id=195346
256
257         Reviewed by Fujii Hironori.
258
259         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
260         (TestWebKitAPI::TEST):
261         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
262
263         * DumpRenderTree/win/DumpRenderTree.cpp:
264         (findFontFallback):
265         (addFontFallbackIfPresent):
266         (removeFontFallbackIfPresent):
267         (main):
268         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
269         (TestWebKitAPI::Util::moduleDirectory):
270         (TestWebKitAPI::Util::createInjectedBundlePath):
271         Use wchar helpers as needed.
272
273 2019-03-06  Rob Buis  <rbuis@igalia.com>
274
275         Consider supporting the `referrerpolicy` attribute.
276         https://bugs.webkit.org/show_bug.cgi?id=179053
277
278         Reviewed by Darin Adler.
279
280         Add a runtime flag for referrerpolicy attribute.
281
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         (enableExperimentalFeatures):
284
285 2019-03-05  Daniel Bates  <dabates@apple.com>
286
287         Update expected API test result following r242379
288         (https://bugs.webkit.org/show_bug.cgi?id=195125)
289
290         Update expected x-coordinate of selection rect now that the left padding of
291         a textarea is sized in ems (so dependent on the font size) just like the left
292         padding of a text field.
293
294         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
295         (TestWebKitAPI::TEST):
296
297 2019-03-05  David Quesada  <david_quesada@apple.com>
298
299         [WK2] It should be possible to follow links with 'download' attributes
300         https://bugs.webkit.org/show_bug.cgi?id=195145
301         rdar://problem/48462642
302
303         Reviewed by Alex Christensen.
304
305         Add a unit test to verify that activating links with 'download' attributes now
306         navigates to the linked resource, rather than starts downloading it. Add another
307         to verify that it is still possible to explicitly download the link via the
308         'Download' navigation action policy.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
311         (-[DownloadAttributeTestDelegate init]):
312         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
313         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
314         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
315         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
316         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
317         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
318         (TEST):
319         * WebKitTestRunner/TestController.cpp:
320         (WTR::TestController::decidePolicyForNavigationAction):
321         * WebKitTestRunner/TestController.h:
322
323 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
324
325         [Curl] Implement Cookie Accept Policy.
326         https://bugs.webkit.org/show_bug.cgi?id=191645
327
328         Reviewed by Fujii Hironori.
329
330         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
331         (TestWebKitAPI::Curl::TEST_F):
332
333 2019-03-05  Youenn Fablet  <youenn@apple.com>
334
335         Rename requestCacheStorageSpace to requestStorageSpace
336         https://bugs.webkit.org/show_bug.cgi?id=195282
337
338         Reviewed by Chris Dumez.
339
340         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
341         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
342         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
343
344 2019-03-05  Brady Eidson  <beidson@apple.com>
345
346         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
347         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
348
349         Reviewed by Tim Horton.
350
351         Loading a file: URL into a WKWebView and then loading another file: url from a completely
352         different directory into that same WKWebView should work.
353
354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
355         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
356
357 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
358
359         Add WeakHashSet
360         https://bugs.webkit.org/show_bug.cgi?id=195152
361
362         Reviewed by Antti Koivisto.
363
364         Added tests for WeakHashSet.
365
366         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
367         (TestWebKitAPI::Base::Base): Moved.
368         (TestWebKitAPI::Derived::foo): Moved.
369         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
370         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
371         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
372         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
373
374 2019-03-04  Chris Dumez  <cdumez@apple.com>
375
376         Do not share WebProcesses between private and regular sessions
377         https://bugs.webkit.org/show_bug.cgi?id=195189
378         <rdar://problem/48421064>
379
380         Reviewed by Alex Christensen.
381
382         Add API test coverage.
383
384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
385         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
386
387 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
388
389         [WPE] Enable web process sandbox
390         https://bugs.webkit.org/show_bug.cgi?id=195169
391
392         Reviewed by Daniel Bates.
393
394         * wpe/install-dependencies:
395         * wpe/jhbuild.modules:
396
397 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
398
399         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
400         https://bugs.webkit.org/show_bug.cgi?id=195206
401
402         Reviewed by Žan Doberšek.
403
404         Add a new test case.
405
406         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
407         (testJSCClass):
408
409 2019-03-04  Charlie Turner  <cturner@igalia.com>
410
411         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
412         https://bugs.webkit.org/show_bug.cgi?id=194898
413
414         Reviewed by Žan Doberšek.
415
416         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
417         a GCC extension that permits arithmetic on void* pointer. Inline
418         the macro until this issue is fixed upstream.
419
420 2019-03-03  Tim Horton  <timothy_horton@apple.com>
421
422         Rid the world of WK_API_ENABLED
423         https://bugs.webkit.org/show_bug.cgi?id=195263
424
425         Reviewed by Dan Bernstein.
426
427         List of changed files elided because it's useless.
428
429 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
430
431         Unreviewed follow-up to r242292.
432
433         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
434
435         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
436         (TestWebKitAPI::testStrip): Renamed from strip.
437         (TestWebKitAPI::TEST):
438
439 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
440
441         Unreviewed, remove accidentally-committed URLHelpers.cpp test
442
443         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
444         and bug #194272 for details.
445
446         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
447
448 2019-03-03  Tim Horton  <timothy_horton@apple.com>
449
450         Remove some more unused 32-bit code
451         https://bugs.webkit.org/show_bug.cgi?id=195255
452
453         Reviewed by Darin Adler.
454
455         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
456         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
457         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
458         (NPP_New):
459         (NPP_HandleEvent):
460         (handleEventCarbon): Deleted.
461
462 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
463
464         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
465
466         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
467         (TestWebKitAPI::TEST):
468
469 2019-03-01  Darin Adler  <darin@apple.com>
470
471         Finish removing String::format
472         https://bugs.webkit.org/show_bug.cgi?id=194893
473
474         Reviewed by Daniel Bates.
475 '
476         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
477
478 2019-03-01  Alex Christensen  <achristensen@webkit.org>
479
480         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
481         https://bugs.webkit.org/show_bug.cgi?id=195229
482         <rdar://problem/48520362>
483
484         Reviewed by Chris Dumez.
485
486         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
487         (TEST):
488
489 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
490
491         Add a system trace scope for event region building
492         https://bugs.webkit.org/show_bug.cgi?id=195226
493
494         Reviewed by Jon Lee.
495
496         This trace scope measures the time spend converting element rects into Region objects,
497         which can be large on some pages.
498
499         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
500
501         * Tracing/SystemTracePoints.plist:
502
503 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
504
505         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
506         https://bugs.webkit.org/show_bug.cgi?id=194612
507
508         Reviewed by Alex Christensen.
509
510         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
511         Just test the new string-processing function and don't touch the actual environment.
512         (Test cases are all as before, but based on operator== instead of strcmp.)
513
514 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
515
516         [ews-app] Update primary keys for handling multiple Buildbot instances
517         https://bugs.webkit.org/show_bug.cgi?id=195120
518
519         Reviewed by Stephanie Lewis.
520
521         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
522         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
523         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
524
525         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
526         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
527         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
528         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
529         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
530         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
531
532 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
533
534         [WinCairo] Enable service worker
535         https://bugs.webkit.org/show_bug.cgi?id=188318
536
537         Reviewed by Youenn Fablet.
538
539         * DumpRenderTree/DumpRenderTreePrefix.h:
540         * TestWebKitAPI/PlatformWin.cmake:
541         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
542         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
543         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
544
545 2019-03-01  Justin Fan  <justin_fan@apple.com>
546
547         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
548         https://bugs.webkit.org/show_bug.cgi?id=195191
549
550         Rubber-stamped by Dean Jackson.
551
552         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
553
554         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
555
556 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
557
558         Unreviewed, fix lldb webkitpy tests
559         https://bugs.webkit.org/show_bug.cgi?id=194375
560
561         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
562
563         * lldb/lldb_webkit.py:
564         (WTFStringImplProvider.is_8bit):
565
566 2019-02-28  David Quesada  <david_quesada@apple.com>
567
568         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
569         https://bugs.webkit.org/show_bug.cgi?id=195121
570         rdar://problem/48450302
571
572         Reviewed by Alex Christensen.
573
574         Add API tests for -WKNavigationAction._shouldPerformDownload in various
575         configurations where the 'download' attribute is absent, blank, or populated
576         with a filename, and where the anchor element is same-origin or cross-origin
577         (meaning the 'download' attribute shouldn't be honored).
578
579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
580         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
581         (-[NavigationActionTestDelegate init]):
582         (-[NavigationActionTestDelegate navigationAction]):
583         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
584         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
585         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
586         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
587         (TEST):
588
589 2019-02-28  Antoine Quint  <graouts@apple.com>
590
591         Enable the Pointer Events runtime flag by default
592         https://bugs.webkit.org/show_bug.cgi?id=195156
593
594         Reviewed by Dean Jackson.
595
596         * DumpRenderTree/mac/DumpRenderTree.mm:
597         (enableExperimentalFeatures):
598
599 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         Several PasteImage API tests are flaky
602         https://bugs.webkit.org/show_bug.cgi?id=195160
603
604         Reviewed by Tim Horton.
605
606         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
607         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
608         listening for a "load" event after image load is already complete.
609
610         To address this, make these tests first register a "load" event handler, then run script to insert an image
611         element into the document, and finally wait until the load event is observed before checking image size.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
614
615 2019-02-28  Chris Dumez  <cdumez@apple.com>
616
617         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
618         https://bugs.webkit.org/show_bug.cgi?id=195107
619
620         Reviewed by Alex Christensen.
621
622         Give some time for the zoom level to get restored.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
625
626 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
627
628         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
629         https://bugs.webkit.org/show_bug.cgi?id=194958
630
631         Reviewed by Geoffrey Garen.
632
633         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
634         (TEST):
635
636 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
637
638         [ews-app] Update method to save build to handle builder_display_name
639         https://bugs.webkit.org/show_bug.cgi?id=195047
640
641         Reviewed by Dewei Zhu.
642
643         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
644         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
645
646 2019-02-28  Justin Fan  <justin_fan@apple.com>
647
648         [Web GPU] Enable Web GPU only on 64-bit
649         https://bugs.webkit.org/show_bug.cgi?id=195139
650
651         Because Metal is only supported on 64 bit apps.
652
653         Unreviewed build fix.
654
655         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
656
657 2019-02-27  Youenn Fablet  <youenn@apple.com>
658
659         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
660         https://bugs.webkit.org/show_bug.cgi?id=194959
661
662         Reviewed by Chris Dumez.
663
664         Spin loop until getting the condition to remove flakiness.
665
666         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
667
668 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
669
670         [ews-build] Buildbot should include builder_display_name in the build events
671         https://bugs.webkit.org/show_bug.cgi?id=195045
672
673         Reviewed by Dewei Zhu.
674
675         * BuildSlaveSupport/ews-build/events.py:
676         (Events.buildStarted): Included builder_display_name in event data. Also renamed
677         buildername to builder_name to be consistent in naming style.
678         (Events.buildFinished): Ditto.
679
680 2019-02-27  Chris Dumez  <cdumez@apple.com>
681
682         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
683         https://bugs.webkit.org/show_bug.cgi?id=194480
684
685         Reviewed by Brady Eidson.
686
687         Update existing API test to make it more likely to reproduce the issue.
688
689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
690
691 2019-02-27  Brady Eidson  <beidson@apple.com>
692
693         Universal links from Google search results pages don't open the app.
694         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
695
696         Reviewed by Geoffrey Garen.
697
698         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
699         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
700         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
701         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
702
703 2019-02-27  Chris Dumez  <cdumez@apple.com>
704
705         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
706         https://bugs.webkit.org/show_bug.cgi?id=195102
707
708         Reviewed by Geoffrey Garen.
709
710         If the number of processes is not yet what we expect, wait a bit and check again to give
711         processes some time to exit.
712
713         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
714
715 2019-02-27  Chris Dumez  <cdumez@apple.com>
716
717         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
718         https://bugs.webkit.org/show_bug.cgi?id=194545
719
720         Reviewed by Brady Eidson.
721
722         Make sure the test navigates forward and then back only once. Previously, navigating
723         back would trigger a navigation again in a timer.
724
725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
726
727 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
728
729         High Sierra Debug JSC test queue should use faster hardware
730         https://bugs.webkit.org/show_bug.cgi?id=194603
731
732         Rubber-stamped by Alexey Proskuryakov.
733
734         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
735
736         * BuildSlaveSupport/build.webkit.org-config/config.json:
737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
738         (BubbleQueueServer):
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
740         (WebKitBuildbot):
741         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
742         * QueueStatusServer/config/queues.py:
743         * Scripts/webkitpy/common/config/ews.json:
744         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
745         (test_ews_name):
746
747 2019-02-27  John Wilander  <wilander@apple.com>
748
749         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
750         https://bugs.webkit.org/show_bug.cgi?id=195071
751         <rdar://problem/48417690>
752
753         Reviewed by Alex Christensen and Brent Fulgham.
754
755         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
756         (TestWebKitAPI::createURL):
757             Convenience function.
758         (TestWebKitAPI::TEST):
759             WebCore::AdClickAttribution now takes a URL when creating Source and
760             Destination.
761         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
762         (TestWebKitAPI::TEST):
763             WebCore::AdClickAttribution now takes a URL when creating Source and
764             Destination.
765
766 2019-02-27  Antoine Quint  <graouts@apple.com>
767
768         Support Pointer Events on macOS
769         https://bugs.webkit.org/show_bug.cgi?id=195008
770         <rdar://problem/47454419>
771
772         Reviewed by Dean Jackson.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
777
778 2019-02-26  Mark Lam  <mark.lam@apple.com>
779
780         Remove remaining poisoning code.
781         https://bugs.webkit.org/show_bug.cgi?id=194138
782
783         Reviewed by Saam Barati.
784
785         * TestWebKitAPI/CMakeLists.txt:
786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
787         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
788         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
789         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
790         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
791         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
792         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
793
794 2019-02-26  Alex Christensen  <achristensen@webkit.org>
795
796         Move ephemeral local storage from WebProcess to UIProcess
797         https://bugs.webkit.org/show_bug.cgi?id=195074
798         <rdar://problem/47937975>
799
800         Reviewed by Geoff Garen.
801
802         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
803
804 2019-02-20  Jer Noble  <jer.noble@apple.com>
805
806         [Cocoa] Media elements will restart network buffering just before suspending
807         https://bugs.webkit.org/show_bug.cgi?id=193691
808
809         Reviewed by Eric Carlson.
810
811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
813         (TEST):
814
815 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
816
817         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
818         https://bugs.webkit.org/show_bug.cgi?id=191652
819
820         Reviewed by Alex Christensen.
821
822         Fix WinCairo MiniBrowser behavior of authentication dialog.
823
824         * MiniBrowser/win/WebKitBrowserWindow.cpp:
825         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
826
827 2019-02-26  Youenn Fablet  <youenn@apple.com>
828
829         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
830         https://bugs.webkit.org/show_bug.cgi?id=195028
831         <rdar://problem/48243733>
832
833         Reviewed by Eric Carlson.
834
835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
836
837 2019-02-26  Philippe Normand  <pnormand@igalia.com>
838
839         [WPE] Add API for webview background color configuration
840         https://bugs.webkit.org/show_bug.cgi?id=192305
841
842         Reviewed by Michael Catanzaro.
843
844         * MiniBrowser/wpe/main.cpp:
845         (main): Add a new option to configure the webview background
846         color. Example: --bg-color=transparent.
847         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
848         (testWebViewBackgroundColor): Enable background color API tests for WPE.
849         (beforeAll): Ditto.
850
851 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
852
853         scalableNativeWebpageParameters() is not preserved on new page navigation.
854         https://bugs.webkit.org/show_bug.cgi?id=194892
855         <rdar://problem/47538280>
856
857         Reviewed by Wenson Hsieh.
858         
859         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
860
861         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
862         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
863         * DumpRenderTree/mac/UIScriptControllerMac.mm:
864         (WTR::UIScriptController::allowsViewportShrinkToFit):
865         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
866         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
867         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
868         * TestRunnerShared/UIScriptContext/UIScriptController.h:
869         * WebKitTestRunner/UIScriptControllerCocoa.mm:
870         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
871
872 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
873
874         [ews-app] Add model for handling multiple Buildbot instances
875         https://bugs.webkit.org/show_bug.cgi?id=194863
876
877         Reviewed by Stephanie Lewis.
878
879         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
880
881 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
882
883         [ews-app] Remove BuilderMapping table
884         https://bugs.webkit.org/show_bug.cgi?id=194961
885
886         Reviewed by Stephanie Lewis.
887
888         Store builder name directly in build table, instead of having a separate
889         table for it.
890
891         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
892         * BuildSlaveSupport/ews-app/ews/models/build.py:
893         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
894         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
895
896 2019-02-25  John Wilander  <wilander@apple.com>
897
898         Introduce and adopt new class RegistrableDomain for eTLD+1
899         https://bugs.webkit.org/show_bug.cgi?id=194791
900         <rdar://problem/48179240>
901
902         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
903
904         This patch adds an API test and replaces two instances of
905         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
906
907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
908         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
909         (TestWebKitAPI::TEST):
910             Changed two strings to make sure the registrable domains are still considered
911             invalid and pass the test.
912         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
913         (TestWebKitAPI::TEST):
914         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
915         (WTR::InjectedBundle::didReceiveMessageToPage):
916
917 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
918
919         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
920         https://bugs.webkit.org/show_bug.cgi?id=195001
921
922         Reviewed by Carlos Garcia Campos.
923
924         API version 1.0 always includes the functionality previously guarded with
925         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
926         unconditionally.
927
928         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
929         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
930         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
931         (WebViewTest::showInWindow): Ditto.
932         (WebViewTest::hideView): Ditto.
933         * wpe/backends/HeadlessViewBackend.cpp:
934         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
935         * wpe/backends/ViewBackend.cpp:
936         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
937         * wpe/backends/WindowViewBackend.cpp:
938         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
939         WPE_BACKEND_CHECK_VERSION().
940         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
941
942 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
943
944         [Flatpak] Add support for flatpak > 1.1.2
945         https://bugs.webkit.org/show_bug.cgi?id=194088
946
947         Flatpak 1.2 is now out so we need to support that
948         version now.
949
950         Reviewed by Michael Catanzaro.
951
952         * flatpak/flatpakutils.py:
953         (check_flatpak):
954         (FlatpakPackages.__init__):
955         (FlatpakPackages.__detect_packages):
956         (FlatpakPackages.__detect_packages.in):
957         (FlatpakRepos.update):
958
959 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
960
961         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
962         https://bugs.webkit.org/show_bug.cgi?id=194998
963
964         Reviewed by Carlos Garcia Campos.
965
966         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
967         to a Git checkout and using the latest commit containing various fixes
968         and improvements.
969
970 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
971
972         [WPE][GTK] Remove user agent quirk for washingtonpost.com
973         https://bugs.webkit.org/show_bug.cgi?id=194981
974
975         Reviewed by Žan Doberšek.
976
977         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
978         (TestWebKitAPI::TEST):
979
980 2019-02-23  Keith Miller  <keith_miller@apple.com>
981
982         Add new mac target numbers
983         https://bugs.webkit.org/show_bug.cgi?id=194955
984
985         Reviewed by Tim Horton.
986
987         * DumpRenderTree/mac/Configurations/Base.xcconfig:
988         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
989         * MiniBrowser/Configurations/Base.xcconfig:
990         * TestWebKitAPI/Configurations/Base.xcconfig:
991         * WebKitTestRunner/Configurations/Base.xcconfig:
992
993 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
994
995         [WinCairo] Enable wk1/wk2 suffix for platform search path.
996         https://bugs.webkit.org/show_bug.cgi?id=194846
997
998         Reviewed by Don Olmstead.
999
1000         Added _search_paths() and _port_specific_expectations_files() for
1001         WinCairoPort.
1002
1003         * Scripts/webkitpy/port/win.py:
1004         (WinCairoPort.default_baseline_search_path):
1005         (WinCairoPort):
1006         (WinCairoPort._port_specific_expectations_files):
1007         (WinCairoPort._search_paths):
1008
1009 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1010
1011         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1012         https://bugs.webkit.org/show_bug.cgi?id=194963
1013
1014         Reviewed by Dean Jackson.
1015
1016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1017         Do a `contains` check instead of `equals`, because in debug builds we
1018         put the GraphicsLayer pointer in a prefix.
1019
1020 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1021
1022         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1023         https://bugs.webkit.org/show_bug.cgi?id=194873
1024         <rdar://problem/46701974>
1025
1026         Reviewed by Tim Horton.
1027
1028         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1029
1030         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1031         (WTR::UIScriptController::menuRect const):
1032         (WTR::UIScriptController::isShowingMenu const):
1033         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1034         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1035         (WTR::UIScriptController::menuRect const):
1036
1037         Add a function to query the bounds of the callout menu in content coordinates.
1038
1039         (WTR::UIScriptController::isShowingMenu const):
1040
1041         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1042
1043         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1044         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1046         (WTR::UIScriptController::rectForMenuAction const):
1047         (WTR::UIScriptController::menuRect const):
1048         (WTR::UIScriptController::isShowingMenu const):
1049         (WTR::findViewInHierarchyOfType): Deleted.
1050
1051 2019-02-22  Chris Dumez  <cdumez@apple.com>
1052
1053         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1054         https://bugs.webkit.org/show_bug.cgi?id=194954
1055         <rdar://problem/48127957>
1056
1057         Reviewed by Alex Christensen.
1058
1059         Add API test coverage.
1060
1061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1062         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1063         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1064         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1065
1066 2019-02-22  Chris Dumez  <cdumez@apple.com>
1067
1068         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1069         https://bugs.webkit.org/show_bug.cgi?id=194924
1070         <rdar://problem/48216125>
1071
1072         Reviewed by Geoffrey Garen.
1073
1074         Add API test coverage.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1077
1078 2019-02-22  Chris Dumez  <cdumez@apple.com>
1079
1080         Unreviewed, disable API test added in r241928 on iOS.
1081
1082         The cache is not enabled on devices with less than 3GB of RAM.
1083
1084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1085
1086 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1087
1088         Hardcode Visual Viewports on everywhere except iOS WK1
1089         https://bugs.webkit.org/show_bug.cgi?id=194928
1090
1091         Reviewed by Zalan Bujtas.
1092
1093         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1094         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1095         set it to false. The setting has shipped for several years and there's no need to turn
1096         it off now.
1097
1098         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1099         Visual Viewports are not enabled.
1100         
1101         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1102         that only runs in WK2
1103
1104         * MiniBrowser/mac/SettingsController.h:
1105         * MiniBrowser/mac/SettingsController.m:
1106         (-[SettingsController init]):
1107         (-[SettingsController _populateMenu]):
1108         (-[SettingsController validateMenuItem:]):
1109         (-[SettingsController visualViewportEnabled]): Deleted.
1110         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1111         * MiniBrowser/mac/WK1BrowserWindowController.m:
1112         (-[WK1BrowserWindowController didChangeSettings]):
1113         * MiniBrowser/mac/WK2BrowserWindowController.m:
1114         (-[WK2BrowserWindowController didChangeSettings]):
1115
1116 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1117
1118         Discard cached processes when clearing website data store
1119         https://bugs.webkit.org/show_bug.cgi?id=194894
1120
1121         Reviewed by Chris Dumez.
1122
1123         Added a test case.
1124
1125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1126         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1127
1128 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1129
1130         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1131         https://bugs.webkit.org/show_bug.cgi?id=194914
1132         <rdar://problem/47586889>
1133
1134         Reviewed by Geoffrey Garen.
1135
1136         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1137         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1138         (TEST):
1139         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1140
1141 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1142
1143         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1144         <https://webkit.org/b/194761>
1145
1146         Reviewed by Myles Maxfield.
1147
1148         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1149         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1150         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1151         to use ARC-compliant cast.
1152         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1153         ARC-compliant cast.
1154         (WTR::installFakeHelvetica): Log `error` to console if
1155         CTFontManagerRegisterFontsForURL() fails, but only on supported
1156         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1157         Call CFRelease() on `error` to fix the leak.  Update to use
1158         ARC-compliant cast.
1159         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1160         cast.
1161
1162 2019-02-21  Chris Dumez  <cdumez@apple.com>
1163
1164         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1165         https://bugs.webkit.org/show_bug.cgi?id=194481
1166
1167         Reviewed by Alex Christensen.
1168
1169         Give the processes a chance to shutdown and wait until we reached the expected number
1170         of processes.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1173
1174 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1175
1176         Fix the macOS build
1177
1178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1179
1180 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1181
1182         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1183
1184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1185         I am a backwards.
1186
1187 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1188
1189         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1190
1191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1192         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1193         We could force on UI-side compositing, but I feel like the test might be more
1194         valuable exercising the normal path on each platform (though the original
1195         bug was also UI-side specific). Though we can't validate that the overlay
1196         layer was installed successfully, there are layout tests that do that.
1197
1198 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1199
1200         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1201         https://bugs.webkit.org/show_bug.cgi?id=194845
1202         <rdar://problem/47944579>
1203
1204         Reviewed by Antti Koivisto.
1205
1206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1208
1209 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1210
1211         [LFC][Floats] Add support for placing formatting roots in-between floats.
1212         https://bugs.webkit.org/show_bug.cgi?id=194902
1213
1214         Reviewed by Antti Koivisto.
1215
1216         * LayoutReloaded/misc/LFC-passing-tests.txt:
1217
1218 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1219
1220         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1221         https://bugs.webkit.org/show_bug.cgi?id=194901
1222
1223         Unreviewed build fix.
1224
1225         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1226         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1227         WPEBackend-fdo-0.1 as library name.
1228
1229 2019-02-21  Rob Buis  <rbuis@igalia.com>
1230
1231         Update MIME type parser
1232         https://bugs.webkit.org/show_bug.cgi?id=180526
1233
1234         Reviewed by Darin Adler.
1235
1236         Add tests involving leading and trailing whitespace, non-token
1237         characters and quoted strings.
1238
1239         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1240         (TestWebKitAPI::TEST):
1241
1242 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1243
1244         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1245         https://bugs.webkit.org/show_bug.cgi?id=194884
1246
1247         Reviewed by Michael Catanzaro.
1248
1249         * PlatformWin.cmake:
1250
1251 2019-02-20  Chris Dumez  <cdumez@apple.com>
1252
1253         Add API test for <rdar://problem/47471222>
1254         https://bugs.webkit.org/show_bug.cgi?id=194847
1255
1256         Reviewed by Alex Christensen.
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1259
1260 2019-02-20  Chris Dumez  <cdumez@apple.com>
1261
1262         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1263         https://bugs.webkit.org/show_bug.cgi?id=194872
1264         <rdar://problem/47924500>
1265
1266         Reviewed by Alex Christensen.
1267
1268         Add API test coverage.
1269
1270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1271
1272 2019-02-20  Jer Noble  <jer.noble@apple.com>
1273
1274         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1275         https://bugs.webkit.org/show_bug.cgi?id=191332
1276
1277         Reviewed by Dean Jackson.
1278
1279         * Scripts/git-is-in-range: Added.
1280
1281 2019-02-20  Andy Estes  <aestes@apple.com>
1282
1283         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1284         https://bugs.webkit.org/show_bug.cgi?id=194869
1285
1286         Rubber-stamped by Jer Noble.
1287
1288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1289         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1290         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1291         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1294
1295 2019-02-20  Chris Dumez  <cdumez@apple.com>
1296
1297         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1298         https://bugs.webkit.org/show_bug.cgi?id=194857
1299         <rdar://problem/47759323>
1300
1301         Reviewed by Alex Christensen.
1302
1303         Add API test coverage.
1304
1305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1306
1307 2019-02-20  Chris Dumez  <cdumez@apple.com>
1308
1309         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1310         https://bugs.webkit.org/show_bug.cgi?id=194829
1311         <rdar://problem/47889906>
1312
1313         Reviewed by Alexey Proskuryakov.
1314
1315         Every time the TestOptions were changing we were creating both a new Web view and
1316         a new WKContext, which would start a new Network process. In most cases, we only
1317         need to contruct a new Web view and we do can keep reusing the same WKContext.
1318         This patch implements this optimization and thus avoids spinning a lot of new
1319         Network processes while running the layout tests.
1320
1321         * WebKitTestRunner/TestController.cpp:
1322         (WTR::TestController::generateContextConfiguration const):
1323         (WTR::TestController::generatePageConfiguration):
1324         (WTR::TestController::createWebViewWithOptions):
1325         (WTR::TestController::resetPreferencesToConsistentValues):
1326         (WTR::updateTestOptionsFromTestHeader):
1327         * WebKitTestRunner/TestController.h:
1328         * WebKitTestRunner/TestOptions.h:
1329         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1330         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1331         (WTR::TestOptions::hasSameInitializationOptions const):
1332         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1333         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1334         (WTR::TestController::platformAddTestOptions const):
1335
1336 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1337
1338         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1339         https://bugs.webkit.org/show_bug.cgi?id=167941
1340
1341         Reviewed by Carlos Garcia Campos.
1342
1343         * MiniBrowser/gtk/main.c:
1344         (filterSavedCallback): Added.
1345         (main): Support loading a JSON rule set file for content filtering.
1346         * MiniBrowser/wpe/main.cpp:
1347         (filterSavedCallback): Added.
1348         (main): Support loading a JSON rule set file for content filtering.
1349         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1350         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1351         (WTF::derefGPtr): Ditto.
1352         (testEmptyStore):
1353         (testSaveInvalidFilter):
1354         (testSaveLoadFilter):
1355         (testSavedFilterIdentifierMatch):
1356         (testRemoveFilter):
1357         (testSaveMultipleFilters):
1358         (testSaveFilterFromFile):
1359         (testFilterPersistence):
1360         (beforeAll):
1361         (afterAll):
1362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1363         (removeOldInjectedContentAndResetLists): Also reset content filters.
1364         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1365         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1366         the element affected by the style sheet.
1367         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1368         and returns it to be used by tests.
1369         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1370         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1371         (serverCallback): Add support for serving a CSS style sheet for testing.
1372         (beforeAll): Add call to testUserContentManagerContentFilter().
1373         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1374
1375 2019-02-19  Keith Rollin  <krollin@apple.com>
1376
1377         Add timing information to build output
1378         https://bugs.webkit.org/show_bug.cgi?id=194839
1379         <rdar://problem/48219609>
1380
1381         Reviewed by Alexey Proskuryakov.
1382
1383         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1384         emit each project's build time to its output. E.g.,
1385
1386             ** BUILD SUCCEEDED ** [0.132 sec]
1387
1388         * Scripts/webkitdirs.pm:
1389         (XcodeOptions):
1390
1391 2019-02-19  Truitt Savell  <tsavell@apple.com>
1392
1393         Unreviewed, rolling out r241784.
1394
1395         Broke all OpenSource builds.
1396
1397         Reverted changeset:
1398
1399         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1400         instances view"
1401         https://bugs.webkit.org/show_bug.cgi?id=172848
1402         https://trac.webkit.org/changeset/241784
1403
1404 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1405
1406         [LFC][Floats] Remove redundant intersecting logic
1407         https://bugs.webkit.org/show_bug.cgi?id=194804
1408
1409         Reviewed by Antti Koivisto.
1410
1411         * LayoutReloaded/misc/LFC-passing-tests.txt:
1412
1413 2019-02-19  Dean Jackson  <dino@apple.com>
1414
1415         Clean-up output from generate-xcfilelists so it can be filtered
1416         https://bugs.webkit.org/show_bug.cgi?id=194795
1417
1418         Reviewed by Joseph Pecoraro (and Keith Rollin).
1419
1420         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1421         make a slight tweak to filter-build-webkit so such lines are marked
1422         as plain.
1423
1424         * Scripts/filter-build-webkit:
1425         * Scripts/generate-xcfilelists:
1426
1427 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1428
1429         pytest is not correctly auto-installed
1430         https://bugs.webkit.org/show_bug.cgi?id=194707
1431
1432         Reviewed by Carlos Garcia Campos.
1433
1434         * Scripts/webkitpy/thirdparty/__init__.py:
1435         (AutoinstallImportHook._install_pytest):
1436
1437 2019-02-18  Chris Dumez  <cdumez@apple.com>
1438
1439         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1440         https://bugs.webkit.org/show_bug.cgi?id=194797
1441         <rdar://problem/48055151>
1442
1443         Reviewed by Geoffrey Garen.
1444
1445         Add API test coverage.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1448
1449 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1452         https://bugs.webkit.org/show_bug.cgi?id=194670
1453         <rdar://problem/39066529>
1454
1455         Reviewed by Tim Horton.
1456
1457         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1458         pasted in an editable area as attachment elements.
1459
1460         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1461         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1462         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1463         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1464         (TestWebKitAPI::TEST):
1465         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1466         (WTR::InjectedBundlePage::InjectedBundlePage):
1467
1468 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1469
1470         Fix API test after r241728
1471        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1474         (TEST):
1475         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1476
1477 2019-02-18  Daniel Bates  <dabates@apple.com>
1478
1479         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1480         https://bugs.webkit.org/show_bug.cgi?id=192824
1481         <rdar://problem/47100332>
1482
1483         Reviewed by Wenson Hsieh.
1484
1485         Fix a bug where the wrong usage code was used for F13 thru F24.
1486
1487         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1488         (keyCodeForDOMFunctionKey):
1489
1490 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1491
1492         Bytecode cache should a have a boot-specific validation
1493         https://bugs.webkit.org/show_bug.cgi?id=194769
1494         <rdar://problem/48149509>
1495
1496         Reviewed by Keith Miller.
1497
1498         Add test for WTF::bootSessionUUIDString()
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1502         (TEST):
1503
1504 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1505
1506         Disable safe browsing in WKWebView and remove its WKPreferences API
1507         https://bugs.webkit.org/show_bug.cgi?id=194723
1508         <rdar://problem/48122993>
1509
1510         Reviewed by Geoffrey Garen.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1513         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1514         (TEST):
1515         (safeBrowsingView):
1516         Make tests use SPI instead of API.
1517
1518 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1519
1520         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1521         https://bugs.webkit.org/show_bug.cgi?id=194586
1522
1523         Reviewed by Ross Kirsling.
1524
1525         * DumpRenderTree/win/DumpRenderTree.cpp:
1526         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1527         * Scripts/webkitpy/port/driver.py:
1528         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1529
1530 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1531
1532         Unreviewed, rolling out r241620.
1533
1534         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1535         (Requested by ddkilzer on #webkit.)
1536
1537         Reverted changeset:
1538
1539         "[WTF] Add environment variable helpers"
1540         https://bugs.webkit.org/show_bug.cgi?id=192405
1541         https://trac.webkit.org/changeset/241620
1542
1543 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1544
1545         [LFC] RenderImage's default intrinsic size is 0.
1546         https://bugs.webkit.org/show_bug.cgi?id=194745
1547
1548         Reviewed by Antti Koivisto.
1549
1550         * LayoutReloaded/misc/LFC-passing-tests.txt:
1551
1552 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1553
1554         [LFC][BFC] Add support for block replaced intrinsic width.
1555         https://bugs.webkit.org/show_bug.cgi?id=194705
1556
1557         Reviewed by Simon Fraser.
1558
1559         * LayoutReloaded/misc/LFC-passing-tests.txt:
1560
1561 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1562
1563         [LFC] Apply min/max width constraints to preferred width computation
1564         https://bugs.webkit.org/show_bug.cgi?id=194739
1565
1566         Reviewed by Simon Fraser.
1567
1568         * LayoutReloaded/misc/LFC-passing-tests.txt:
1569
1570 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1571
1572         [WTF] Add environment variable helpers
1573         https://bugs.webkit.org/show_bug.cgi?id=192405
1574
1575         Reviewed by Michael Catanzaro.
1576
1577         * DumpRenderTree/mac/DumpRenderTree.mm:
1578         (libraryPathForDumpRenderTree):
1579         * DumpRenderTree/win/DumpRenderTree.cpp:
1580         (libraryPathForDumpRenderTree):
1581         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1582         (setUpIOSLayoutTestCommunication):
1583         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1584         (beforeAll):
1585         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1586         (main):
1587         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1588         (WebKitTestBus::run):
1589         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1590         (WTR::getOutputDir):
1591         (WTR::initializeFontConfigSetting):
1592         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1593         (WTR::InjectedBundle::platformInitialize):
1594         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1595         (WTR::topLevelPath):
1596         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1597         (WTR::topLevelPath):
1598         (WTR::getOutputDir):
1599         (WTR::activateFonts):
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::libraryPathForTesting):
1602         (WTR::TestController::generateContextConfiguration const):
1603         (WTR::TestController::generatePageConfiguration):
1604         (WTR::TestController::decideDestinationWithSuggestedFilename):
1605         (WTR::TestController::platformAdjustContext):
1606         * WebKitTestRunner/TestController.h:
1607         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1608         (WTR::TestController::cocoaPlatformInitialize):
1609         (WTR::TestController::platformAdjustContext):
1610         * WebKitTestRunner/gtk/main.cpp:
1611         (main):
1612         * WebKitTestRunner/mac/TestControllerMac.mm:
1613         (WTR::TestController::configureContentExtensionForTest):
1614         * WebKitTestRunner/wpe/main.cpp:
1615         (main):
1616         Utilize WTF::Environment where possible.
1617
1618 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1619
1620         [iOS] WKWebView callout bar is missing Change Writing Direction item
1621         https://bugs.webkit.org/show_bug.cgi?id=190015
1622         <rdar://problem/44810366>
1623
1624         Reviewed by Tim Horton.
1625
1626         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1627         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1630         (TestWebKitAPI::TEST):
1631
1632 2019-02-15  Chris Dumez  <cdumez@apple.com>
1633
1634         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1635         https://bugs.webkit.org/show_bug.cgi?id=194717
1636         <rdar://problem/47884404>
1637
1638         Reviewed by Brady Eidson.
1639
1640         Add API test coverage.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1643
1644 2019-02-15  Youenn Fablet  <youenn@apple.com>
1645
1646         Make navigator.mediaDevices SecureContext
1647         https://bugs.webkit.org/show_bug.cgi?id=194666
1648
1649         Reviewed by Eric Carlson.
1650
1651         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1652         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1653         (TEST_F):
1654
1655 2019-02-15  Brian Burg  <bburg@apple.com>
1656
1657         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1658         https://bugs.webkit.org/show_bug.cgi?id=194411
1659         <rdar://problem/47787614>
1660
1661         Reviewed by Joseph Pecoraro.
1662
1663         Remove unnecessary soft linking macro usage.
1664
1665         * DumpRenderTree/mac/TestRunnerMac.mm:
1666         (TestRunner::inspectorTestStubURL):
1667         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1668         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1669         (WTR::TestRunner::inspectorTestStubURL):
1670
1671 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1672
1673         Unreviewed, rolling out r241559 and r241566.
1674         https://bugs.webkit.org/show_bug.cgi?id=194710
1675
1676         Causes layout test crashes under GuardMalloc (Requested by
1677         ryanhaddad on #webkit).
1678
1679         Reverted changesets:
1680
1681         "[WTF] Add environment variable helpers"
1682         https://bugs.webkit.org/show_bug.cgi?id=192405
1683         https://trac.webkit.org/changeset/241559
1684
1685         "Unreviewed build fix for WinCairo Debug after r241559."
1686         https://trac.webkit.org/changeset/241566
1687
1688 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1689
1690         [LFC] Out-of-flow box is never a float box
1691         https://bugs.webkit.org/show_bug.cgi?id=194704
1692
1693         Reviewed by Antti Koivisto.
1694
1695         * LayoutReloaded/misc/LFC-passing-tests.txt:
1696
1697 2019-02-10  Darin Adler  <darin@apple.com>
1698
1699         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1700         https://bugs.webkit.org/show_bug.cgi?id=194487
1701
1702         Reviewed by Daniel Bates.
1703
1704         * DumpRenderTree/win/DumpRenderTree.cpp:
1705         (applicationId): Use makeString instead of String::format.
1706         (main): Ditto.
1707         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1708         (TestWebKitAPI::Util::createURLForResource): Ditto.
1709         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1710         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1711
1712         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1713         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1714         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1715         (WTR::createStringWithAttributes): Use appendLiteral.
1716         (WTR::AccessibilityUIElement::helpText const): Ditto.
1717         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1718         directly instead of using String::format.
1719         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1720         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1721
1722 2019-02-15  Truitt Savell  <tsavell@apple.com>
1723
1724         Unreviewed, rolling out r241564.
1725
1726         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1727
1728         Reverted changeset:
1729
1730         "[Mac] WebInspectorUI.framework does not need to be soft-
1731         linked anymore"
1732         https://bugs.webkit.org/show_bug.cgi?id=194411
1733         https://trac.webkit.org/changeset/241564
1734
1735 2019-02-15  Saam barati  <sbarati@apple.com>
1736
1737         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1738         https://bugs.webkit.org/show_bug.cgi?id=194036
1739
1740         Reviewed by Yusuke Suzuki.
1741
1742         * Scripts/run-jsc-stress-tests:
1743
1744 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1745
1746         Fix the build.
1747
1748         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1749         (WTR::UIScriptController::drawSquareInEditableImage):
1750         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1751         (TestWebKitAPI::drawSquareInEditableImage):
1752
1753 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1754
1755         Fix the build.
1756
1757         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1758         (WTR::UIScriptController::drawSquareInEditableImage):
1759         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1760         (TestWebKitAPI::drawSquareInEditableImage):
1761
1762 2019-02-14  Brian Burg  <bburg@apple.com>
1763
1764         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1765         https://bugs.webkit.org/show_bug.cgi?id=194411
1766         <rdar://problem/47787614>
1767
1768         Reviewed by Joseph Pecoraro.
1769
1770         Remove unnecessary soft linking macro usage.
1771
1772         * DumpRenderTree/mac/TestRunnerMac.mm:
1773         (TestRunner::inspectorTestStubURL):
1774         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1775         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1776         (WTR::TestRunner::inspectorTestStubURL):
1777
1778 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1781         https://bugs.webkit.org/show_bug.cgi?id=194599
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1786         (StatusBubble._build_bubble):
1787
1788 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1789
1790         [ews-app] Set Foreign Key in Django build model
1791         https://bugs.webkit.org/show_bug.cgi?id=194667
1792
1793         Reviewed by Lucas Forschler.
1794
1795         * BuildSlaveSupport/ews-app/ews/models/build.py:
1796         (Build):
1797
1798 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1799
1800         [WTF] Add environment variable helpers
1801         https://bugs.webkit.org/show_bug.cgi?id=192405
1802
1803         Reviewed by Michael Catanzaro.
1804
1805         * DumpRenderTree/mac/DumpRenderTree.mm:
1806         (libraryPathForDumpRenderTree):
1807         * DumpRenderTree/win/DumpRenderTree.cpp:
1808         (libraryPathForDumpRenderTree):
1809         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1810         (setUpIOSLayoutTestCommunication):
1811         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1812         (TestWebKitAPI::strip):
1813         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1814         (beforeAll):
1815         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1816         (main):
1817         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1818         (WebKitTestBus::run):
1819         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1820         (WTR::getOutputDir):
1821         (WTR::initializeFontConfigSetting):
1822         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1823         (WTR::InjectedBundle::platformInitialize):
1824         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1825         (WTR::topLevelPath):
1826         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1827         (WTR::topLevelPath):
1828         (WTR::getOutputDir):
1829         (WTR::activateFonts):
1830         * WebKitTestRunner/TestController.cpp:
1831         (WTR::TestController::libraryPathForTesting):
1832         (WTR::TestController::generateContextConfiguration const):
1833         (WTR::TestController::generatePageConfiguration):
1834         (WTR::TestController::decideDestinationWithSuggestedFilename):
1835         (WTR::TestController::platformAdjustContext):
1836         * WebKitTestRunner/TestController.h:
1837         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1838         (WTR::TestController::cocoaPlatformInitialize):
1839         (WTR::TestController::platformAdjustContext):
1840         * WebKitTestRunner/gtk/main.cpp:
1841         (main):
1842         * WebKitTestRunner/mac/TestControllerMac.mm:
1843         (WTR::TestController::configureContentExtensionForTest):
1844         * WebKitTestRunner/wpe/main.cpp:
1845         (main):
1846         Utilize WTF::Environment where possible.
1847
1848 2019-02-14  Chris Dumez  <cdumez@apple.com>
1849
1850         [PSON] Introduce a WebContent Process cache
1851         https://bugs.webkit.org/show_bug.cgi?id=194594
1852         <rdar://problem/46793397>
1853
1854         Reviewed by Geoff Garen.
1855
1856         Update API tests to turn on the WebContent Process cache.
1857
1858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1859
1860 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1861
1862         Unreviewed, build fix after r241480
1863
1864         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1865         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1866         (-[DragAndDropSimulator initWithWebView:]):
1867
1868 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1869
1870         AX: ARIA Reflection was disabled in error
1871         https://bugs.webkit.org/show_bug.cgi?id=194647
1872         <rdar://problem/48068336>
1873
1874         Reviewed by Ryosuke Niwa.
1875
1876         Remove test override now that this feature should be enabled by default.
1877
1878         * WebKitTestRunner/TestController.cpp:
1879         (WTR::TestController::resetPreferencesToConsistentValues):
1880
1881 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1882
1883         Unreviewed, rolling out r241486.
1884         https://bugs.webkit.org/show_bug.cgi?id=194655
1885
1886         causing API failures in builds (Requested by ShawnRoberts on
1887         #webkit).
1888
1889         Reverted changeset:
1890
1891         "[Cocoa] Media elements will restart network buffering just
1892         before suspending"
1893         https://bugs.webkit.org/show_bug.cgi?id=193691
1894         https://trac.webkit.org/changeset/241486
1895
1896 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1897
1898         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1899         https://bugs.webkit.org/show_bug.cgi?id=194622
1900
1901         Reviewed by Antti Koivisto.
1902
1903         * LayoutReloaded/misc/LFC-passing-tests.txt:
1904
1905 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1906
1907         [LFC] Shrink-to-fit-width should be constrained by min/max width
1908         https://bugs.webkit.org/show_bug.cgi?id=194653
1909
1910         Reviewed by Antti Koivisto.
1911
1912         * LayoutReloaded/misc/LFC-passing-tests.txt:
1913
1914 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1915
1916         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1917         https://bugs.webkit.org/show_bug.cgi?id=194641
1918
1919         Reviewed by Geoffrey Garen.
1920
1921         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1922         so that the test would fail without this fix.
1923
1924         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1925         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1926
1927 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-app] Change log level for a log statement
1930
1931         Unreviewed minor fix.
1932
1933         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1934         (Patch.save_patch):
1935
1936 2019-02-13  Jer Noble  <jer.noble@apple.com>
1937
1938         [Cocoa] Media elements will restart network buffering just before suspending
1939         https://bugs.webkit.org/show_bug.cgi?id=193691
1940
1941         Reviewed by Eric Carlson.
1942
1943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1944         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1945         (TEST):
1946
1947 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews-app] Fetch builder id to name mapping
1950         https://bugs.webkit.org/show_bug.cgi?id=194355
1951
1952         Reviewed by Lucas Forschler.
1953
1954         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1955         (Buildbot.get_builder_id_to_name_mapping):
1956         (Buildbot._get_display_name_from_builder_name):
1957
1958 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1959
1960         Further restricting webarchive loads
1961         https://bugs.webkit.org/show_bug.cgi?id=194567
1962         <rdar://problem/47610130>
1963
1964         Reviewed by Youenn Fablet.
1965
1966         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1967         navigations on drop.
1968
1969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1970         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1971         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1972         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1973         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1974         (TestWebKitAPI::TEST):
1975         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1976         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1977         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1978         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1979         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1980         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1981         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1982
1983 2019-02-13  John Wilander  <wilander@apple.com>
1984
1985         Store Ad Click Attribution requests in the network process
1986         https://bugs.webkit.org/show_bug.cgi?id=194510
1987         <rdar://problem/47650118>
1988
1989         Reviewed by Alex Christensen and Daniel Bates.
1990
1991         This patch adds two TestRunner functions:
1992         - dumpAdClickAttribution()
1993         - clearAdClickAttribution()
1994
1995         They call into the network process to dump and clear Ad Click
1996         Attribution state, respectively.
1997
1998         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2000         (WTR::TestRunner::dumpAdClickAttribution):
2001         (WTR::TestRunner::clearAdClickAttribution):
2002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::resetStateToConsistentValues):
2005         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2006         (WTR::adClickAttributionStringResultCallback):
2007         (WTR::TestController::dumpAdClickAttribution):
2008         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2009         (WTR::adClickAttributionVoidCallback):
2010         (WTR::TestController::clearAdClickAttribution):
2011         * WebKitTestRunner/TestController.h:
2012         * WebKitTestRunner/TestInvocation.cpp:
2013         (WTR::TestInvocation::dumpResults):
2014         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2015         (WTR::TestInvocation::dumpAdClickAttribution):
2016         * WebKitTestRunner/TestInvocation.h:
2017
2018 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-app] Generate status-bubble
2021         https://bugs.webkit.org/show_bug.cgi?id=194572
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2026         (StatusBubble._build_bubble):
2027         (StatusBubble._should_show_bubble_for):
2028         (StatusBubble._build_bubbles_for_patch):
2029
2030 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-app] Add status bubble html template
2033         https://bugs.webkit.org/show_bug.cgi?id=194571
2034
2035         Reviewed by Lucas Forschler.
2036
2037         * BuildSlaveSupport/ews-app/ews/templates: Added.
2038         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2039
2040 2019-02-12  Chris Dumez  <cdumez@apple.com>
2041
2042         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2043         https://bugs.webkit.org/show_bug.cgi?id=194568
2044         <rdar://problem/47944490>
2045
2046         Reviewed by Ryosuke Niwa.
2047
2048         Add API test coverage.
2049
2050         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2051         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2052
2053 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2054
2055         webkitpy: Remove bug_dummy from parsed test expectations
2056         https://bugs.webkit.org/show_bug.cgi?id=194562
2057         <rdar://problem/47853999>
2058
2059         Reviewed by Lucas Forschler.
2060
2061         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2062         (TestExpectationParser):
2063         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2064         skipped tests.
2065         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2066
2067 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2068
2069         [ews-app] Add method to fetch patch
2070         https://bugs.webkit.org/show_bug.cgi?id=194518
2071
2072         Reviewed by Lucas Forschler.
2073
2074         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2075         (Patch.get_patch):
2076
2077 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2078
2079         [LFC] Expand tests coverage (60 new tests -> 860)
2080
2081         Unreviewed test gardening (run-singly, --child-processes=1).
2082
2083         * LayoutReloaded/misc/LFC-passing-tests.txt:
2084
2085 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2086
2087         Allow pages to trigger programmatic paste from script on iOS
2088         https://bugs.webkit.org/show_bug.cgi?id=194271
2089         <rdar://problem/47808810>
2090
2091         Reviewed by Tim Horton.
2092
2093         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2094
2095         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2096         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2097         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2098         (WTR::UIScriptController::rectForMenuAction const):
2099
2100         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2101         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2102         for when the menu is shown or hidden.
2103
2104         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2105         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2106         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2107         (WTR::UIScriptController::setDidShowMenuCallback):
2108         (WTR::UIScriptController::didShowMenuCallback const):
2109         (WTR::UIScriptController::setDidHideMenuCallback):
2110         (WTR::UIScriptController::didHideMenuCallback const):
2111         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2112         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2113         (WTR::UIScriptController::rectForMenuAction const):
2114         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2115         * WebKitTestRunner/TestController.cpp:
2116         (WTR::TestController::resetPreferencesToConsistentValues):
2117         (WTR::updateTestOptionsFromTestHeader):
2118         * WebKitTestRunner/TestOptions.h:
2119
2120         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2121         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2122
2123         (WTR::TestOptions::hasSameInitializationOptions const):
2124         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2125         (WTR::UIScriptController::calendarType const):
2126         (WTR::UIScriptController::platformUndoManager const):
2127         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2128         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2129         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2130         (-[TestRunnerWKWebView dealloc]):
2131         (-[TestRunnerWKWebView _didShowMenu]):
2132         (-[TestRunnerWKWebView _didHideMenu]):
2133
2134         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2135
2136         * WebKitTestRunner/ios/TestControllerIOS.mm:
2137         (WTR::handleMenuWillHideNotification):
2138         (WTR::handleMenuDidHideNotification):
2139         (WTR::TestController::platformInitialize):
2140         (WTR::TestController::platformDestroy):
2141         (WTR::TestController::platformResetStateToConsistentValues):
2142
2143         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2144         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2145
2146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2147         (WTR::forEachViewInHierarchy):
2148         (WTR::findViewInHierarchyOfType):
2149
2150         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2151         functions that dig through a given view's hierarchy in search of a view of a given class.
2152
2153         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2154         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2155         (WTR::UIScriptController::selectionCaretViewRect const):
2156         (WTR::UIScriptController::selectionRangeViewRects const):
2157         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2158         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2159
2160         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2161
2162         (WTR::UIScriptController::rectForMenuAction const):
2163
2164         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2165         callout bar) whose label matches the given string.
2166
2167         (WTR::UIScriptController::platformContentView const):
2168
2169         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2170         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2171         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2172
2173         (WTR::UIScriptController::platformUndoManager const): Deleted.
2174         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2175         (WTR::UIScriptController::platformContentView const):
2176         (WTR::UIScriptController::platformUndoManager const): Deleted.
2177
2178 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2179
2180         webkitpy: No option to only show unexpected failures in results.html for iPad
2181         https://bugs.webkit.org/show_bug.cgi?id=194554
2182         <rdar://problem/47922442>
2183
2184         Rubber-stamped by Aakash Jain.
2185
2186         Just because a TestExpecations file does not exist for a specific platform does not mean that
2187         TestExpecations are not being used, given that platforms inherit test expectations.
2188
2189         * Scripts/webkitpy/port/base.py:
2190         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2191         * Scripts/webkitpy/port/base_unittest.py:
2192         (PortTest.test_uses_test_expectations_file):
2193
2194 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2195
2196         Remove setDefersLoading infrastructure from WebKit2
2197         https://bugs.webkit.org/show_bug.cgi?id=194506
2198
2199         Reviewed by Brady Eidson.
2200
2201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2203         (WTR::TestRunner::setDefersLoading): Deleted.
2204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2205
2206 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2207
2208         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2209         https://bugs.webkit.org/show_bug.cgi?id=194522
2210         <rdar://problem/47789393>
2211
2212         Reviewed by Chris Dumez.
2213
2214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2215         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2216         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2218
2219 2019-02-12  Andy Estes  <aestes@apple.com>
2220
2221         [iOSMac] Enable Parental Controls Content Filtering
2222         https://bugs.webkit.org/show_bug.cgi?id=194521
2223         <rdar://39732376>
2224
2225         Reviewed by Tim Horton.
2226
2227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2228
2229 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2230
2231         [LFC][IFC] Add intrinsic width support for float boxes.
2232         https://bugs.webkit.org/show_bug.cgi?id=194528
2233
2234         Reviewed by Antti Koivisto.
2235
2236         Expand tests coverage (2 new tests -> 800).
2237         (This is the correct test ordering --runs-singly --child-processes=1)
2238
2239         * LayoutReloaded/misc/LFC-passing-tests.txt:
2240
2241 2019-02-12  Rob Buis  <rbuis@igalia.com>
2242
2243         Implement serializing in MIME type parser
2244         https://bugs.webkit.org/show_bug.cgi?id=193909
2245
2246         Reviewed by Darin Adler.
2247
2248         Add various tests involving upper case, non-ASCII, control/null characters,
2249         various HTTP whitespace, single quotes and an unpaired surrogate.
2250
2251         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2252         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2253         (TestWebKitAPI::serializeIfValid):
2254         (TestWebKitAPI::TEST):
2255
2256 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2257
2258         [Cocoa] Ask platform for generic font family mappings
2259         https://bugs.webkit.org/show_bug.cgi?id=187723
2260         <rdar://problem/41892438>
2261
2262         Reviewed by Brent Fulgham.
2263
2264         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2265
2266         * DumpRenderTree/mac/DumpRenderTree.mm:
2267         (allowedFontFamilySet):
2268         * WebKitTestRunner/mac/TestControllerMac.mm:
2269         (WTR::allowedFontFamilySet):
2270
2271 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2272
2273         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2274         https://bugs.webkit.org/show_bug.cgi?id=193622
2275
2276         Reviewed by Michael Catanzaro.
2277
2278         This adds support for loading content extension rule sets from the JSON files which
2279         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2280         of WKTR for this could be removed, but that is left for a follow-up patch with
2281         cleanups.
2282
2283         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2284         * WebKitTestRunner/TestController.cpp:
2285         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2286         avoid having the null-terminator copied into the result.
2287         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2288         part of the preparations to run a test.
2289         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2290         (WTR::contentExtensionStoreCallback): Added.
2291         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2292         used for content extensions test.
2293         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2294         extensions and compiling the JSON rule set for tests involving content extensions.
2295         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2296         testing and disables content extensions.
2297         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2298         resetContentExtensions().
2299         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2300         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2301         configureContentExtensionForTest(), and userContentController().
2302
2303 2019-02-11  Daniel Bates  <dabates@apple.com>
2304
2305         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2306         https://bugs.webkit.org/show_bug.cgi?id=191446
2307         <rdar://problem/45929460>
2308
2309         Reviewed by Tim Horton.
2310
2311         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2312
2313         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2314         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2315         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2316         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2317         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2318         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2319         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2320         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2321         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2322         (WTR::arrayLength):
2323         (WTR::parseModifierArray):
2324         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2325         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2326         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2327         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2328
2329 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2330
2331         Unreviewed, rolling out r241272 and r241276.
2332         https://bugs.webkit.org/show_bug.cgi?id=194514
2333
2334         Broke the Apple Internal build and the fix requires human
2335         intervention :( (Requested by dydz on #webkit).
2336
2337         Reverted changesets:
2338
2339         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2340         https://bugs.webkit.org/show_bug.cgi?id=191446
2341         https://trac.webkit.org/changeset/241272
2342
2343         "Fix internal iOS build after r241272"
2344         https://bugs.webkit.org/show_bug.cgi?id=191446
2345         https://trac.webkit.org/changeset/241276
2346
2347 2019-02-11  Truitt Savell  <tsavell@apple.com>
2348
2349         Unreviewed, rolling out r241269.
2350
2351         Caused 5 layout tests crashes on Mac WK1
2352
2353         Reverted changeset:
2354
2355         "DumpRenderTree should report unknown options"
2356         https://bugs.webkit.org/show_bug.cgi?id=191303
2357         https://trac.webkit.org/changeset/241269
2358
2359 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2360
2361         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2362         https://bugs.webkit.org/show_bug.cgi?id=194313
2363
2364         Reviewed by Tim Horton.
2365
2366         Add a helper to determine whether the web view is presenting modal UI.
2367
2368         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2369         (WTR::UIScriptController::isPresentingModally const):
2370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2372         (WTR::UIScriptController::isPresentingModally const):
2373         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2374         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2375         (WTR::UIScriptController::calendarType const): Deleted.
2376         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2377         (WTR::UIScriptController::isPresentingModally const):
2378         (WTR::UIScriptController::calendarType const):
2379         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2380         (WTR::UIScriptController::calendarType const):
2381
2382 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2383
2384         GCHeapInspector: Show the retained sizes in more places
2385         https://bugs.webkit.org/show_bug.cgi?id=194464
2386
2387         Reviewed by Simon Fraser.
2388
2389         * GCHeapInspector/gc-heap-inspector.html:
2390         * GCHeapInspector/script/interface.js:
2391         (HeapInspectorUtils.humanReadableSize):
2392         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2393         (HeapInspectorUtils.spanForNode.span.span):
2394         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2395         (HeapSnapshotInspector.prototype.buildRoots):
2396
2397 2019-02-11  Daniel Bates  <dabates@apple.com>
2398
2399         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2400         https://bugs.webkit.org/show_bug.cgi?id=191446
2401         <rdar://problem/45929460>
2402
2403         Reviewed by Tim Horton.
2404
2405         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2406
2407         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2408         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2409         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2410         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2411         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2412         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2413         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2414         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2415         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2416         (WTR::arrayLength):
2417         (WTR::parseModifierArray):
2418         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2419         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2420         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2421         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2422
2423 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2424
2425         DumpRenderTree should report unknown options
2426         https://bugs.webkit.org/show_bug.cgi?id=191303
2427
2428         Reviewed by Frédéric Wang.
2429
2430         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2431         to report unknown options.
2432         Added and assigned test options which are currently used in tests.
2433
2434         * DumpRenderTree/TestOptions.cpp:
2435         (TestOptions::TestOptions):
2436
2437 2019-02-11  Truitt Savell  <tsavell@apple.com>
2438
2439         Unreviewed, rolling out r241229.
2440
2441         Revision broke internal builds for watchOS.
2442
2443         Reverted changeset:
2444
2445         "[Cocoa] Ask platform for generic font family mappings"
2446         https://bugs.webkit.org/show_bug.cgi?id=187723
2447         https://trac.webkit.org/changeset/241229
2448
2449 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2450
2451         [WinCairo][MiniBrowser] Basic authentication always fails.
2452         https://bugs.webkit.org/show_bug.cgi?id=194496
2453
2454         Reviewed by Don Olmstead.
2455
2456         * MiniBrowser/win/DialogHelper.h:
2457         (Dialog::getText):
2458
2459 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2460
2461         [GStreamer] GstMappedBuffer testsuite build fails
2462         https://bugs.webkit.org/show_bug.cgi?id=194495
2463
2464         Reviewed by Carlos Garcia Campos.
2465
2466         Fix the build by explicitely adding the gstreamer1.0-audio include
2467         directories to the include path.
2468
2469         * TestWebKitAPI/PlatformGTK.cmake:
2470         * TestWebKitAPI/PlatformWPE.cmake:
2471
2472 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GTK][WPE] Add enable-javascript-markup setting
2475         https://bugs.webkit.org/show_bug.cgi?id=193439
2476
2477         Reviewed by Michael Catanzaro.
2478
2479         Add test cases to check the new setting.
2480
2481         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2482         (testWebKitSettings):
2483         (testWebKitSettingsJavaScriptMarkup):
2484         (beforeAll):
2485
2486 2019-02-10  Darin Adler  <darin@apple.com>
2487
2488         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2489         https://bugs.webkit.org/show_bug.cgi?id=194485
2490
2491         Reviewed by Daniel Bates.
2492
2493         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2494
2495 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2496
2497         Add more tests for clampTo<>()
2498         https://bugs.webkit.org/show_bug.cgi?id=194462
2499
2500         Reviewed by Geoffrey Garen.
2501
2502         Darin suggested to test the very last floating point number
2503         at the boundaries when truncating to integer.
2504         I added test for max/min and max-1/min-1.
2505
2506         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2507         (TestWebKitAPI::TEST):
2508
2509 2019-02-09  Darin Adler  <darin@apple.com>
2510
2511         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2512         https://bugs.webkit.org/show_bug.cgi?id=194021
2513
2514         Reviewed by Geoffrey Garen.
2515
2516         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2517         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2518         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2519
2520 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2521
2522         [LFC][IFC] Add intrinsic width support for basic inline containers
2523         https://bugs.webkit.org/show_bug.cgi?id=194473
2524
2525         Reviewed by Antti Koivisto.
2526
2527         Expand tests coverage (11 new tests -> 798)
2528
2529         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2530
2531 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2532
2533         Fix MiniBrowser's entitlements
2534         https://bugs.webkit.org/show_bug.cgi?id=192431
2535
2536         Reviewed by Joseph Pecoraro.
2537
2538         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2539         files, making it impossible to load any extension.
2540
2541         * MiniBrowser/MiniBrowser.entitlements:
2542
2543 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2544
2545         [Cocoa] Ask platform for generic font family mappings
2546         https://bugs.webkit.org/show_bug.cgi?id=187723
2547         <rdar://problem/41892438>
2548
2549         Reviewed by Brent Fulgham.
2550
2551         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2552
2553         * DumpRenderTree/mac/DumpRenderTree.mm:
2554         (allowedFontFamilySet):
2555         * WebKitTestRunner/mac/TestControllerMac.mm:
2556         (WTR::allowedFontFamilySet):
2557
2558 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2559
2560         [GTK] Implement back/forward touchpad gesture
2561         https://bugs.webkit.org/show_bug.cgi?id=193919
2562
2563         Reviewed by Michael Catanzaro.
2564
2565         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2566         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2567
2568 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2569
2570         Add SPI to use networking daemon instead of XPC service
2571         https://bugs.webkit.org/show_bug.cgi?id=194427
2572
2573         Reviewed by Geoffrey Garen
2574
2575         * MiniBrowser/MiniBrowser.entitlements:
2576
2577 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2578
2579         [ews-build] Ensure that every builder in config.json has short name
2580         https://bugs.webkit.org/show_bug.cgi?id=194461
2581
2582         Reviewed by Lucas Forschler.
2583
2584         * BuildSlaveSupport/ews-build/loadConfig.py:
2585         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2586
2587 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews-build] Add short name to config.json
2590         https://bugs.webkit.org/show_bug.cgi?id=194456
2591
2592         Reviewed by Lucas Forschler.
2593
2594         * BuildSlaveSupport/ews-build/config.json: Added short name.
2595         * BuildSlaveSupport/ews-build/loadConfig.py:
2596         (loadBuilderConfig): Set the short name as the builder description.
2597
2598 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2599
2600         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2601         https://bugs.webkit.org/show_bug.cgi?id=194418
2602
2603         Reviewed by Lucas Forschler.
2604
2605         Do not include errors trying when finding crashlogs at the end of
2606         a run-webkit-tests run since we don't process those errors.
2607
2608         * Scripts/webkitpy/port/darwin.py:
2609         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2610         * Scripts/webkitpy/port/ios_device.py:
2611         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2612         * Scripts/webkitpy/port/watch_device.py:
2613         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2614
2615 2019-02-08  Beth Dakin  <bdakin@apple.com>
2616
2617         Add afterScreenUpdates to WKSnapshotConfiguration
2618         https://bugs.webkit.org/show_bug.cgi?id=194362
2619         -and corresponding-
2620         <rdar://problem/40655528> Please add an "after screen updates" property to 
2621         WKSnapshotConfiguration (to solve blank snapshots)
2622
2623         Reviewed by Tim Horton.
2624
2625         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2626         (TEST):
2627
2628 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2629
2630         clampTo(): do not convert the input to double when dealing with integers
2631         https://bugs.webkit.org/show_bug.cgi?id=194263
2632         <rdar://problem/47692312>
2633
2634         Reviewed by Darin Adler.
2635
2636         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2637         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2638         (TestWebKitAPI::testClampFloatingPointToInteger):
2639         (TestWebKitAPI::testClampSameSignIntegers):
2640         (TestWebKitAPI::testClampUnsignedToSigned):
2641         (TestWebKitAPI::testClampSignedToUnsigned):
2642
2643 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2644
2645         webkitpy: Respect --dedicated-simulators flag
2646         https://bugs.webkit.org/show_bug.cgi?id=194416
2647         <rdar://problem/47894722>
2648
2649         Reviewed by Lucas Forschler.
2650
2651         * Scripts/webkitpy/port/device_port.py:
2652         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2653         available devices can be safely ignored.
2654
2655 2019-02-07  Keith Rollin  <krollin@apple.com>
2656
2657         Remove extra copy of 100x100-red.tga
2658         https://bugs.webkit.org/show_bug.cgi?id=194371
2659         <rdar://problem/47873465>
2660
2661         Reviewed by Said Abou-Hallawa.
2662
2663         In order to help it pass its tests, Bug 194190 added a second copy of
2664         the file 100x100-red.tga. However, it turns out that this additional
2665         file wasn't actually needed, and that that sole previous copy was
2666         sufficient. At the same time, this second copy -- which was copied to
2667         the same location in the build output as the first copy -- now caused
2668         XCBuild to complain because there were two production rules for the
2669         same output file. Address this by removing the newly-added extra copy.
2670
2671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2672         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2673
2674 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2675
2676         Deprecate WKBundlePageSetDefersLoading
2677         https://bugs.webkit.org/show_bug.cgi?id=191394
2678
2679         Reviewed by Dean Jackson.
2680
2681         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2682         (WTR::TestRunner::setDefersLoading):
2683
2684 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2685
2686         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2687         https://bugs.webkit.org/show_bug.cgi?id=194391
2688
2689         Reviewed by Antti Koivisto.
2690
2691         * LayoutReloaded/misc/LFC-passing-tests.txt:
2692
2693 2019-02-06  Keith Rollin  <krollin@apple.com>
2694
2695         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2696         https://bugs.webkit.org/show_bug.cgi?id=193975
2697         <rdar://problem/47643306>
2698
2699         Reviewed by Tim Horton.
2700
2701         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2702         the Info.plist file into the bundle. This step is not necessary as the
2703         implicit "bundle up all the build products into a framework" build
2704         phase does this already. Having the Copy Bundle Resources phase do
2705         this causes a conflict under XCBuild, which objects to two build
2706         phases producing the same file (Info.plist). Address this by removing
2707         Info.plist from the Copy Bundle Resources phase.
2708
2709         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2710
2711 2019-02-06  Keith Rollin  <krollin@apple.com>
2712
2713         Really enable the automatic checking and regenerations of .xcfilelists during builds
2714         https://bugs.webkit.org/show_bug.cgi?id=194357
2715         <rdar://problem/47861231>
2716
2717         Reviewed by Chris Dumez.
2718
2719         Bug 194124 was supposed to enable the automatic checking and
2720         regenerating of .xcfilelist files during the build. While related
2721         changes were included in that patch, the change to actually enable the
2722         operation somehow was omitted. This patch actually enables the
2723         operation. The check-xcfilelist.sh scripts now check
2724         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2725         from the checking.
2726
2727         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2728         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2729
2730 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2731
2732         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2733         <https://webkit.org/b/194286>
2734         <rdar://problem/47815558>
2735
2736         Reviewed by Alexey Proskuryakov.
2737
2738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2739         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2740         WKRetainPtr<> to avoid leaking the WKDataRef.
2741
2742 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2743
2744         Unreviewed, fix a typo
2745
2746         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2747
2748 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2749
2750         [GTK][WPE] force libpsl build to use ICU in jhbuild
2751         https://bugs.webkit.org/show_bug.cgi?id=194288
2752
2753         Reviewed by Carlos Garcia Campos.
2754
2755         * gtk/jhbuild.modules:
2756         Require ICU for libpsl build in jhbuild, like done in WPE.
2757
2758 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2759
2760         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2761         https://bugs.webkit.org/show_bug.cgi?id=194209
2762
2763         Reviewed by Carlos Garcia Campos.
2764
2765         Enhance TestCookieManager to ensure this doesn't happen again.
2766
2767         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2768         (testCookieManagerPersistentStorage):
2769         (beforeAll):
2770
2771 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2772
2773         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2774         https://bugs.webkit.org/show_bug.cgi?id=194324
2775
2776         Reviewed by Andy Estes.
2777
2778         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2779         part of the name is already implicit, since this is in testing code in TestOptions.
2780
2781         * WebKitTestRunner/TestController.cpp:
2782         (WTR::TestController::generateContextConfiguration const):
2783         (WTR::updateTestOptionsFromTestHeader):
2784         * WebKitTestRunner/TestOptions.h:
2785         (WTR::TestOptions::hasSameInitializationOptions const):
2786
2787 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2788
2789         [ews-build] Allow * as platform for builders and workers
2790         https://bugs.webkit.org/show_bug.cgi?id=188533
2791
2792         Reviewed by Lucas Forschler.
2793
2794         * BuildSlaveSupport/ews-build/loadConfig.py:
2795         (checkWorkersAndBuildersForConsistency):
2796
2797 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-build] Add few bots to config.json
2800         https://bugs.webkit.org/show_bug.cgi?id=194304
2801
2802         Reviewed by Lucas Forschler.
2803
2804         * BuildSlaveSupport/ews-build/config.json:
2805
2806 2019-02-05  Keith Rollin  <krollin@apple.com>
2807
2808         Enable the automatic checking and regenerations of .xcfilelists during builds
2809         https://bugs.webkit.org/show_bug.cgi?id=194124
2810         <rdar://problem/47721277>
2811
2812         Reviewed by Tim Horton.
2813
2814         Bug 193790 add a facility for checking -- during build time -- that
2815         any needed .xcfilelist files are up-to-date and for updating them if
2816         they are not. This facility was initially opt-in by setting
2817         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2818         the process seemed robust. Its now time to enable this facility and
2819         make it opt-out. If there is a need to disable this facility, set and
2820         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2821         running `make` or `build-webkit`, or before running Xcode from the
2822         command line.
2823
2824         Additionally, remove the step that generates a list of source files
2825         going into the UnifiedSources build step. It's only necessarily to
2826         specify Sources.txt and SourcesCocoa.txt as inputs.
2827
2828         * Scripts/generate-xcfilelists:
2829
2830 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2831
2832         [GTK][WPE] force libpsl build to use ICU in jhbuild
2833         https://bugs.webkit.org/show_bug.cgi?id=194288
2834
2835         Reviewed by Philippe Normand.
2836
2837         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2838         This can cause build failures if libidn is detected but libunistring is not available.
2839
2840         Make sure that ICU is used for runtime and builtin PSL data.
2841
2842         * gtk/jhbuild.modules:
2843         * wpe/jhbuild.modules:
2844
2845 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2846
2847         [ews-app] Modified timestamp should be updated on updating data
2848         https://bugs.webkit.org/show_bug.cgi?id=194295
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * BuildSlaveSupport/ews-app/ews/models/build.py:
2853         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2854         * BuildSlaveSupport/ews-app/ews/models/step.py:
2855
2856 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2857
2858         Unreviewed, rolling out r240742.
2859
2860         Causes crashes on iOS simulator.
2861
2862         Reverted changeset:
2863
2864         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2865         not focused in a content-editable element"
2866         https://bugs.webkit.org/show_bug.cgi?id=192824
2867         https://trac.webkit.org/changeset/240742
2868
2869 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2870
2871         run-webkit-tests emits message "...running None" when running tests
2872         https://bugs.webkit.org/show_bug.cgi?id=194133
2873         <rdar://problem/47724738>
2874
2875         Reviewed by Lucas Forschler.
2876
2877         * Scripts/webkitpy/xcode/device_type.py:
2878         (DeviceType.__str__): Use both version mapping tables and use just the variant
2879         name if no version name is available.
2880         * Scripts/webkitpy/xcode/device_type_unittest.py:
2881         (DeviceTypeTest):
2882         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2883         an associated named.
2884
2885 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2886
2887         [WPE] require python3-setuptools for meson build in jhbuild
2888         https://bugs.webkit.org/show_bug.cgi?id=194287
2889
2890         Reviewed by Philippe Normand.
2891
2892         python3-setuptools is needed to build meson in jhbuild.
2893         It is already required by the GTK port.
2894
2895         * wpe/install-dependencies:
2896
2897 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-app] Add method to save BuilderMapping to database
2900         https://bugs.webkit.org/show_bug.cgi?id=194264
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2905         (BuilderMapping.__str__):
2906         (BuilderMapping):
2907         (BuilderMapping.save_mapping):
2908         (BuilderMapping.update_mapping):
2909         (BuilderMapping.get_existing_mapping):
2910         (BuilderMapping.is_valid_mapping):
2911
2912 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2913
2914         [ews-app] Add timestamp fields for BuilderMappings
2915         https://bugs.webkit.org/show_bug.cgi?id=194266
2916
2917         Reviewed by Lucas Forschler.
2918
2919         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2920         (BuilderMapping):
2921
2922 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2923
2924         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2925         https://bugs.webkit.org/show_bug.cgi?id=174816
2926
2927         Reviewed by Michael Catanzaro.
2928
2929         Add tests for webkit_uri_for_display().
2930
2931         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2932         (testURIForDisplayUnaffected):
2933         (testURIForDisplayAffected):
2934         (beforeAll):
2935         (afterAll):
2936         * TestWebKitAPI/glib/CMakeLists.txt:
2937
2938 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2939
2940         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2941         https://bugs.webkit.org/show_bug.cgi?id=194158
2942         <rdar://problem/47737268>
2943
2944         Rubber-stamped by Aakash Jain.
2945
2946         * Scripts/webkitpy/port/device_port.py:
2947         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2948
2949 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2950
2951         [CG] Enable setAdditionalSupportedImageTypes for WK1
2952         https://bugs.webkit.org/show_bug.cgi?id=194190
2953
2954         Reviewed by Tim Horton.
2955
2956         Add a test similar to the one under WebKit Cocoa but make it create a
2957         WebView instead of a WKWebView.
2958
2959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2960         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2961         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2962         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2963         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2964         (TestWebKitAPI::runTest):
2965         (TestWebKitAPI::TEST):
2966
2967 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2968
2969         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2970         https://bugs.webkit.org/show_bug.cgi?id=194168
2971
2972         Reviewed by Simon Fraser.
2973
2974         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2975
2976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2977         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2978         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2979         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2980         (TEST):
2981         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2982         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2983
2984 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2985
2986         REGRESSION (r237269): webkit-patch what-broke is broken 
2987         https://bugs.webkit.org/show_bug.cgi?id=193025
2988
2989         Reviewed by Aakash Jain.
2990
2991         * Scripts/webkitpy/common/host.py:
2992         (Host.buildbot):
2993         (Host.bugzilla): Renamed to 'buildbot'.
2994
2995 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2996
2997         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2998         https://bugs.webkit.org/show_bug.cgi?id=194207
2999
3000         Reviewed by Tim Horton.
3001
3002         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3003         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3004         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3005         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3006         start and delete forwards to remove the original attachment.
3007
3008         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3009         (TestWebKitAPI::TEST):
3010
3011 2019-02-04  Youenn Fablet  <youenn@apple.com>
3012
3013         Capture state should be managed consistently when doing process swapping
3014         https://bugs.webkit.org/show_bug.cgi?id=194122
3015         <rdar://problem/47609293>
3016
3017         Reviewed by Eric Carlson.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3020         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3021         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3022         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3023         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3024         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3025         (WTR::TestRunner::isDoingMediaCapture const):
3026         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3027         * WebKitTestRunner/TestController.cpp:
3028         (WTR::TestController::isDoingMediaCapture const):
3029         * WebKitTestRunner/TestController.h:
3030         * WebKitTestRunner/TestInvocation.cpp:
3031         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3032         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3033         (WTR::TestController::isDoingMediaCapture const):
3034
3035 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3036
3037         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3038         https://bugs.webkit.org/show_bug.cgi?id=194142
3039
3040         Reviewed by Ross Kirsling.
3041
3042         There three 'separator' variables in TestController.cpp. Renamed
3043         it 'pathSeparator', and unified them.
3044
3045         * WebKitTestRunner/TestController.cpp:
3046         (WTR::TestController::generateContextConfiguration const):
3047         (WTR::createTestURL):
3048         (WTR::TestController::platformAdjustContext):
3049
3050 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3051
3052         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3053         https://bugs.webkit.org/show_bug.cgi?id=194198
3054
3055         Reviewed by Antti Koivisto.
3056
3057         No need to set the banner heights on navigation now, since Page stores them.
3058
3059         * MiniBrowser/mac/WK2BrowserWindowController.m:
3060         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3061
3062 2019-02-03  John Wilander  <wilander@apple.com>
3063
3064         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3065         https://bugs.webkit.org/show_bug.cgi?id=194104
3066         <rdar://problem/47649991>
3067
3068         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3069
3070         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3071         (TestWebKitAPI::TEST):
3072             Changed numeric types from unsigned short to uint32_t.
3073
3074 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3075
3076         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3077         <https://webkit.org/b/194178>
3078         <rdar://problem/47753473>
3079
3080         Reviewed by Alexey Proskuryakov.
3081
3082         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3083         (WTR::uninstallFakeHelvetica): Pass nullptr into
3084         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3085
3086 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3087
3088         [LFC] Initialize ICB's style with fixed width/height.
3089         https://bugs.webkit.org/show_bug.cgi?id=194188
3090
3091         Reviewed by Antti Koivisto.
3092
3093         * LayoutReloaded/misc/LFC-passing-tests.txt:
3094
3095 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3096
3097         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3098         https://bugs.webkit.org/show_bug.cgi?id=194185
3099
3100         Reviewed by Antti Koivisto.
3101
3102         * LayoutReloaded/misc/LFC-passing-tests.txt:
3103
3104 2018-12-16  Darin Adler  <darin@apple.com>
3105
3106         Convert additional String::format clients to alternative approaches
3107         https://bugs.webkit.org/show_bug.cgi?id=192746
3108
3109         Reviewed by Alexey Proskuryakov.
3110
3111         * WebKitTestRunner/TestController.cpp:
3112         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3113         as an intermediate in code that ultimately constructs a WTF::String.
3114         (WTR::userMediaOriginHash): Use makeString.
3115         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3116         (WTR::TestController::didPerformClientRedirect): Ditto.
3117         (WTR::TestController::didPerformServerRedirect): Ditto.
3118         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3119
3120 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3121
3122         [ews-build] Add unit test to verify builder keys
3123         https://bugs.webkit.org/show_bug.cgi?id=194152
3124
3125         Reviewed by Lucas Forschler.
3126
3127         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3128         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3129
3130 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3131
3132         [LFC] Expand tests coverage (12 new tests -> 787)
3133
3134         Unreviewed test gardening.
3135
3136         * LayoutReloaded/misc/LFC-passing-tests.txt:
3137
3138 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3139
3140         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3141         https://bugs.webkit.org/show_bug.cgi?id=194163
3142
3143         Reviewed by Simon Fraser.
3144
3145         775
3146
3147         * LayoutReloaded/misc/LFC-passing-tests.txt:
3148
3149 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3150
3151         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3152         https://bugs.webkit.org/show_bug.cgi?id=194140
3153         <rdar://problem/47728098>
3154
3155         Reviewed by Tim Horton.
3156
3157         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3159         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3160
3161         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3162         test to induce an IPC deadlock when presenting a modal alert during touch start.
3163
3164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3165         * WebKitTestRunner/TestController.cpp:
3166         (WTR::runJavaScriptAlert):
3167
3168         Add a client callback function for running JavaScript alerts.
3169
3170         (WTR::TestController::createOtherPage):
3171         (WTR::TestController::generateContextConfiguration const):
3172
3173         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3174         the fix in this patch.
3175
3176         (WTR::TestController::createWebViewWithOptions):
3177
3178         Plumb TestOptions to generateContextConfiguration.
3179
3180         (WTR::TestController::resetPreferencesToConsistentValues):
3181         (WTR::TestController::resetStateToConsistentValues):
3182         (WTR::updateTestOptionsFromTestHeader):
3183         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3184         (WTR::TestController::handleJavaScriptAlert):
3185         * WebKitTestRunner/TestController.h:
3186         * WebKitTestRunner/TestInvocation.cpp:
3187         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3188         * WebKitTestRunner/TestOptions.h:
3189         (WTR::TestOptions::hasSameInitializationOptions const):
3190
3191 2019-02-01  Chris Dumez  <cdumez@apple.com>
3192
3193         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3194         https://bugs.webkit.org/show_bug.cgi?id=193740
3195         <rdar://problem/47527267>
3196
3197         Reviewed by Alex Christensen.
3198
3199         Add API test coverage.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3202
3203 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3204
3205         [ews-app] Add display name field to BuilderMapping model
3206         https://bugs.webkit.org/show_bug.cgi?id=194153
3207
3208         Reviewed by Lucas Forschler.
3209
3210         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3211         (BuilderMapping):
3212
3213 2019-02-01  Youenn Fablet  <youenn@apple.com>
3214
3215         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3216         https://bugs.webkit.org/show_bug.cgi?id=194155
3217
3218         Reviewed by Eric Carlson.
3219
3220         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3221         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3222         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3223
3224 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3225
3226         [LFC] Adjust replaced element's intrinsic ratio
3227         https://bugs.webkit.org/show_bug.cgi?id=194154
3228
3229         Reviewed by Antti Koivisto.
3230
3231         761
3232
3233         * LayoutReloaded/misc/LFC-passing-tests.txt:
3234
3235 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3236
3237         [WPE] Show test results in minibrowser
3238         https://bugs.webkit.org/show_bug.cgi?id=194150
3239
3240         Reviewed by Žan Doberšek.
3241
3242         * Scripts/webkitpy/port/wpe.py:
3243         (WPEPort.show_results_html_file):
3244
3245 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3246
3247         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3248         https://bugs.webkit.org/show_bug.cgi?id=194151
3249
3250         Reviewed by Žan Doberšek.
3251
3252         ALT + <- go back
3253         ALT + -> go forward
3254
3255         * MiniBrowser/wpe/main.cpp:
3256         (main):
3257
3258 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3259
3260         [LFC] Set intrinsic size on Layout::Replaced
3261         https://bugs.webkit.org/show_bug.cgi?id=194139
3262
3263         Reviewed by Antti Koivisto.
3264
3265         744
3266
3267         * LayoutReloaded/misc/LFC-passing-tests.txt:
3268
3269 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3270
3271         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3272         https://bugs.webkit.org/show_bug.cgi?id=194146
3273
3274         Reviewed by Xabier Rodriguez-Calvar.
3275
3276         It allows to open relative paths.
3277
3278         * MiniBrowser/wpe/main.cpp:
3279         (main):
3280
3281 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3282
3283         Update flakiness dashboard configuration after recent queue changes
3284         https://bugs.webkit.org/show_bug.cgi?id=194127
3285
3286         Rubber-stamped by Aakash Jain.
3287
3288         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3289
3290         * TestResultServer/static-dashboards/builders.jsonp:
3291
3292 2019-01-31  Youenn Fablet  <youenn@apple.com>
3293
3294         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3295         https://bugs.webkit.org/show_bug.cgi?id=194106
3296         <rdar://problem/47676333>
3297
3298         Reviewed by Ryosuke Niwa.
3299
3300         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3301         (TestWebKitAPI::didFinishNavigation):
3302         (TestWebKitAPI::TEST):
3303         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3304
3305 2019-01-31  Chris Dumez  <cdumez@apple.com>
3306
3307         Page zoom level is lost after a process swap or a crash
3308         https://bugs.webkit.org/show_bug.cgi?id=194105
3309         <rdar://problem/47610781>
3310
3311         Reviewed by Alex Christensen.
3312
3313         Add API test coverage.
3314
3315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3316         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3317
3318 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3319
3320         Revert r238819 which is unneeded and caused a performance regression.
3321         https://bugs.webkit.org/show_bug.cgi?id=192272
3322         <rdar://problem/46664625>
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3325         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3326         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3327
3328 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3329
3330         Formalize WebKitAdditions mechanism of LoadOptimizer
3331         https://bugs.webkit.org/show_bug.cgi?id=193886
3332         <rdar://problem/47696809>
3333
3334         Reviewed by Brent Fulgham.
3335
3336         * MiniBrowser/MiniBrowser.entitlements:
3337         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3338
3339 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3340
3341         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3342         https://bugs.webkit.org/show_bug.cgi?id=194090
3343
3344         Reviewed by Antti Koivisto.
3345
3346         * LayoutReloaded/misc/LFC-passing-tests.txt:
3347
3348 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3349
3350         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3351         https://bugs.webkit.org/show_bug.cgi?id=194074
3352
3353         Reviewed by Antti Koivisto.
3354
3355         * LayoutReloaded/misc/LFC-passing-tests.txt:
3356
3357 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3358
3359         [LFC][BFC] Add support for block level replaced box.
3360         https://bugs.webkit.org/show_bug.cgi?id=194071
3361
3362         Reviewed by Antti Koivisto.
3363
3364         * LayoutReloaded/misc/LFC-passing-tests.txt:
3365
3366 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3367
3368         Fix WebKitTestRunner's testPath with Windows full paths
3369         https://bugs.webkit.org/show_bug.cgi?id=194012
3370
3371         Reviewed by Alex Christensen.
3372
3373         updateTestOptionsFromTestHeader failed to open test files because
3374         testPath returned wrong file paths. It returned a path "/C:/..."
3375         if a URL "file:///C:/..." was given.
3376
3377         * WebKitTestRunner/TestController.cpp:
3378         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3379
3380 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         [WPE] Bump font related dependencies to match the GTK+ port
3383         https://bugs.webkit.org/show_bug.cgi?id=194017
3384
3385         Reviewed by Žan Doberšek.
3386
3387         * wpe/jhbuild.modules:
3388         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3389         * wpe/patches/icudata-stdlibs.patch: Added.
3390
3391 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3392
3393         Enable swipe tests on iOS
3394         https://bugs.webkit.org/show_bug.cgi?id=194076
3395
3396         Reviewed by Geoffrey Garen.
3397
3398         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3399         it causes a debug assertion failure in runUIScript.
3400
3401         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3402         (WTR::UIScriptController::beginBackSwipe):
3403         (WTR::UIScriptController::completeBackSwipe):
3404
3405 2019-01-30  Keith Rollin  <krollin@apple.com>
3406
3407         Use correct printf format specifier
3408         https://bugs.webkit.org/show_bug.cgi?id=194062
3409         <rdar://problem/47686167>
3410
3411         Reviewed by Alexey Proskuryakov.
3412
3413         LayoutTestSpellChecker.mm is trying to format a variable of type
3414         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3415         actually an unsigned long long. Fix this by formatting with %llu.
3416
3417         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3418         (-[LayoutTestTextCheckingResult description]):
3419
3420 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3421
3422         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3423         https://bugs.webkit.org/show_bug.cgi?id=193979
3424
3425         Reviewed by Wenson Hsieh.
3426
3427         Fix the test for iOS. Make the test work with iOS UA string.
3428
3429         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3430
3431 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3432
3433         Replace High Sierra LLINT CLoop bot due to hardware failure
3434         https://bugs.webkit.org/show_bug.cgi?id=194066
3435
3436         Reviewed by Aakash Jain.
3437
3438         * BuildSlaveSupport/build.webkit.org-config/config.json:
3439
3440 2019-01-30  Keith Rollin  <krollin@apple.com>
3441
3442         [NSDragItem init] is unavailable
3443         https://bugs.webkit.org/show_bug.cgi?id=194059
3444         <rdar://problem/47685715>
3445
3446         Reviewed by Wenson Hsieh.
3447
3448         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3449         DumpRenderTree and TestWebKitAPI, which both try to create an
3450         NSDragItem in a manner that invokes this method. Address this by using
3451         -initWithPasteboardWriter instead.
3452
3453         Note that the parameter passed to initWithPasteboardWriter is likely
3454         incorrect. In both cases, the object passed does not conform to
3455         NSPasteboardWriting. However, with this fix, we're no worse off than
3456         before, and can now perform builds with newer compilers and SDKs until
3457         a real fix can be crafted. That work is tracked in
3458         https://bugs.webkit.org/show_bug.cgi?id=194060
3459
3460         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3461         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3462         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3463         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3464
3465 2019-01-30  Daniel Bates  <dabates@apple.com>
3466
3467         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3468         https://bugs.webkit.org/show_bug.cgi?id=192824
3469         <rdar://problem/47100332>
3470
3471         Reviewed by Wenson Hsieh.
3472
3473         Fix a bug where the wrong usage code was used for F13 thru F24.
3474
3475         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3476         (keyCodeForDOMFunctionKey):
3477
3478 2019-01-30  Chris Dumez  <cdumez@apple.com>
3479
3480         Regression(PSON) Load hang can occur on history navigation
3481         https://bugs.webkit.org/show_bug.cgi?id=194030
3482         <rdar://problem/47656939>
3483
3484         Reviewed by Antti Koivisto.
3485
3486         Add API test coverage.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3489
3490 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3491
3492         [LFC] Expand tests coverage.
3493
3494         Unreviewed test gardening.
3495
3496         * LayoutReloaded/misc/LFC-passing-tests.txt:
3497
3498 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3499
3500         [Flatpak] Add openjpeg support
3501         https://bugs.webkit.org/show_bug.cgi?id=194019
3502
3503         Reviewed by Michael Catanzaro.
3504
3505         * flatpak/org.webkit.CommonModules.yaml:
3506
3507 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3508
3509         Unreviewed, rolling out r240708.
3510         https://bugs.webkit.org/show_bug.cgi?id=194022
3511
3512         It broke WPE build (Requested by KaL on #webkit).
3513
3514         Reverted changeset:
3515
3516         "[WPE] Bump font related dependencies to match the GTK+ port"
3517         https://bugs.webkit.org/show_bug.cgi?id=194017
3518         https://trac.webkit.org/changeset/240708
3519
3520 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3521
3522         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3523         https://bugs.webkit.org/show_bug.cgi?id=194001
3524
3525         Reviewed by Antti Koivisto.
3526
3527         * LayoutReloaded/misc/LFC-passing-tests.txt:
3528
3529 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3530
3531         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3532         https://bugs.webkit.org/show_bug.cgi?id=194020
3533
3534         Reviewed by Antti Koivisto.
3535
3536         * LayoutReloaded/misc/LFC-passing-tests.txt:
3537
3538 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3539
3540         AX: Support color well on iOS
3541         https://bugs.webkit.org/show_bug.cgi?id=194010
3542
3543         Reviewed by Joanmarie Diggs.
3544
3545         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3546         (WTR::AccessibilityUIElement::stringAttributeValue):
3547
3548 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3549
3550         [WPE] Bump font related dependencies to match the GTK+ port
3551         https://bugs.webkit.org/show_bug.cgi?id=194017
3552
3553         Reviewed by Žan Doberšek.
3554
3555         * wpe/jhbuild.modules:
3556         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3557         * wpe/patches/icudata-stdlibs.patch: Added.
3558
3559 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3560
3561         [Mac] Update window scale API usage
3562         https://bugs.webkit.org/show_bug.cgi?id=193991
3563         rdar://problem/47614795
3564
3565         Reviewed by Tim Horton.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm:
3568         (changeWindowScaleIfNeeded):
3569         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3570         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3571         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3572
3573 2019-01-29  Chris Dumez  <cdumez@apple.com>
3574
3575         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3576         https://bugs.webkit.org/show_bug.cgi?id=193977
3577         <rdar://problem/47643716>
3578
3579         Reviewed by Geoff Garen.
3580
3581         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3582         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3583         to the previous provisional committing *before* we make the last load. 
3584
3585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3586
3587 2019-01-29  Youenn Fablet  <youenn@apple.com>
3588
3589         Adopt new SPI to evaluate server certificate trust
3590         https://bugs.webkit.org/show_bug.cgi?id=193355
3591
3592         Reviewed by Alex Christensen.
3593
3594         Add infrastructure to handle HTTPS server trust evaluation testing.
3595
3596         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3597         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3598         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3599         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3600         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3601         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3602         * WebKitTestRunner/TestController.cpp:
3603         (WTR::TestController::resetPreferencesToConsistentValues):
3604         (WTR::TestController::didReceiveAuthenticationChallenge):
3605         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3606         * WebKitTestRunner/TestController.h:
3607         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3608         * WebKitTestRunner/TestInvocation.cpp:
3609         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3610         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3611         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3612
3613 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3614
3615         [ews-build] Add build step to print bot Configuration
3616         https://bugs.webkit.org/show_bug.cgi?id=193887
3617
3618         Reviewed by Lucas Forschler.
3619
3620         * BuildSlaveSupport/ews-build/steps.py:
3621         (PrintConfiguration): Build step to print configuration.
3622         * BuildSlaveSupport/ews-build/factories.py:
3623
3624 2019-01-29  Chris Dumez  <cdumez@apple.com>
3625
3626         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3627         https://bugs.webkit.org/show_bug.cgi?id=193967
3628         <rdar://problem/47635348>
3629
3630         Reviewed by Alex Christensen.
3631
3632         Add API test coverage.
3633
3634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3635         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3636
3637 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-app] Handle incoming results data
3640         https://bugs.webkit.org/show_bug.cgi?id=193973
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * BuildSlaveSupport/ews-app/ews/views/results.py:
3645
3646 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3647
3648         [ews-app] Make the results url generic
3649         https://bugs.webkit.org/show_bug.cgi?id=193928
3650
3651         Reviewed by Lucas Forschler.
3652
3653         * BuildSlaveSupport/ews-app/ews/urls.py:
3654
3655 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3656
3657         [ews-build] Configure buildbot to send events to ews-app
3658         https://bugs.webkit.org/show_bug.cgi?id=193968
3659
3660         Reviewed by Lucas Forschler.
3661
3662         * BuildSlaveSupport/ews-build/events.py: Added.
3663         * BuildSlaveSupport/ews-build/master.cfg:
3664
3665 2019-01-29  Keith Rollin  <krollin@apple.com>
3666
3667         Add .xcfilelists to Run Script build phases
3668         https://bugs.webkit.org/show_bug.cgi?id=193792
3669         <rdar://problem/47201785>
3670
3671         Reviewed by Alex Christensen.
3672
3673         As part of supporting XCBuild, update the necessary Run Script build
3674         phases in their Xcode projects to refer to their associated
3675         .xcfilelist files.
3676
3677         Note that the addition of these files bumps the Xcode project version
3678         number to something that's Xcode 10 compatible. This change means that
3679         older versions of the Xcode IDE can't read these projects. Nor can it
3680         fully load workspaces that refer to these projects (the updated
3681         projects are shown as non-expandable placeholders). `xcodebuild` can
3682         still build these projects; it's just that the IDE can't open them.
3683
3684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3686
3687 2019-01-29  John Wilander  <wilander@apple.com>
3688
3689         Add data abstraction and validation for Ad Click Attribution
3690         https://bugs.webkit.org/show_bug.cgi?id=193916
3691         <rdar://problem/47603481>
3692
3693         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3694
3695         Ad click attribution has two steps. First, the storage of an ad
3696         campaign ID for a click that takes the user to a destination
3697         site. Second, a conversion on the destination site that can be
3698         attributed to the ad click.
3699
3700         This patch adds a class that represents a request for ad click
3701         attribution. Validation makes sure that the bits of entropy
3702         reported through this mechanism is limited.
3703
3704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3705         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3706         (TestWebKitAPI::TEST):
3707
3708 2019-01-29  Chris Dumez  <cdumez@apple.com>
3709
3710         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3711         https://bugs.webkit.org/show_bug.cgi?id=193932
3712         <rdar://problem/47598947>
3713
3714         Reviewed by Brady Eidson.
3715
3716         Add API test coverage.
3717
3718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3719
3720 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3721
3722         Adding new passing LFC tests.
3723
3724         Unreviewed test gardening.
3725
3726         * LayoutReloaded/misc/LFC-passing-tests.txt:
3727
3728 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3729
3730         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3731         https://bugs.webkit.org/show_bug.cgi?id=193964
3732
3733         Reviewed by Antti Koivisto.
3734
3735         * LayoutReloaded/misc/LFC-passing-tests.txt:
3736
3737 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3738
3739         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3740         https://bugs.webkit.org/show_bug.cgi?id=193954
3741
3742         Reviewed by Antti Koivisto.
3743
3744         * LayoutReloaded/misc/LFC-passing-tests.txt:
3745
3746 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3747
3748         WebDriver: add support for running subtests
3749         https://bugs.webkit.org/show_bug.cgi?id=193904
3750
3751         Reviewed by Michael Catanzaro.
3752
3753         pytest already supports it by passing test.py::subtest, so we can do the same.
3754
3755         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3756         (get_item_name): Made this global.
3757         (CollectRecorder.__init__): Receive the parameter to ignore.
3758         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3759         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3760         (collect): Add parameter to ignore.
3761         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3762         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3763         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3764         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3765         (WebDriverTestRunnerSelenium.run): Ditto.
3766         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3767         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3768         (WebDriverTestRunnerW3C.run): Ditto.
3769
3770 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3771
3772         User agent string override for navigator.userAgent should be site specific quirks
3773         https://bugs.webkit.org/show_bug.cgi?id=193950
3774
3775         Reviewed by Brent Fulgham.
3776
3777         Updated per the _WKWebsitePolicies rename.
3778
3779         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3780         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3781
3782 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3783
3784         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3785         https://bugs.webkit.org/show_bug.cgi?id=193941
3786
3787         Reviewed by Alex Christensen.
3788
3789         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3790         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3791         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3792         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3793         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3794         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3795         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3796         * TestWebKitAPI/Tests/WTF/Time.cpp:
3797         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3798         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3799         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3800         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3801
3802 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3803
3804         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3805
3806         * Scripts/webkitpy/common/config/contributors.json:
3807
3808 2019-01-28  Andy Estes  <aestes@apple.com>
3809
3810         [watchOS] Enable Parental Controls content filtering
3811         https://bugs.webkit.org/show_bug.cgi?id=193939
3812         <rdar://problem/46641912>
3813
3814         Reviewed by Ryosuke Niwa.
3815
3816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3817
3818 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3819
3820         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3821         <https://webkit.org/b/193884>
3822
3823         Reviewed by Jiewen Tan.
3824
3825         * Scripts/webkitpy/style/checkers/cpp.py:
3826         (check_language): Add LocalAuthentication to
3827         `frameworks_with_soft_links`.
3828
3829 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3830
3831         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3832         https://bugs.webkit.org/show_bug.cgi?id=193891
3833
3834         Reviewed by Ross Kirsling.
3835
3836         There were three problems in window sizes of WebView and the host window.
3837         1. The sizes of pixel image output were incorrect.
3838         2. The host window is going to appear after window.resize was invoked.
3839         3. window.resize resized only the host window, not WebView.
3840
3841         This change solves them with a following approach.
3842         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3843         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3844            as well as DumpRenderTree in order to match the client area and the window area.
3845         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3846         d. PlatformWebView::setWindowFrame changes both window sizes.
3847         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3848
3849         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3850         (WTR::PlatformWebView::PlatformWebView): Create the host window
3851         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3852         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3853         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3854
3855 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3856
3857         [ews-app] Add method to save Step data to database
3858         https://bugs.webkit.org/show_bug.cgi?id=193890
3859
3860         Reviewed by Lucas Forschler.
3861
3862         * BuildSlaveSupport/ews-app/ews/models/step.py:
3863         (Step.save_step): Method to save step data.
3864         (Step.update_step): Method to update step data.
3865         (Step.get_existing_step): Method to fetch existing step from database.
3866         (Step.is_valid_result): Method to validate valid step result.
3867
3868 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3869
3870         [ews-app] Add method to save Build data to database
3871         https://bugs.webkit.org/show_bug.cgi?id=193735
3872
3873         Reviewed by Lucas Forschler.
3874
3875         * BuildSlaveSupport/ews-app/ews/models/build.py:
3876         (Build.save_build): Method to save build information to database.
3877         (Build.get_existing_build): Method to fetch existing build from database.
3878         (Build.is_valid_result): Method to validate build result.
3879         * BuildSlaveSupport/ews-app/ews/common/util.py:
3880         (is_valid_int_id): Method to validate valid id.
3881
3882 2019-01-28  Chris Dumez  <cdumez@apple.com>
3883
3884         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3885         https://bugs.webkit.org/show_bug.cgi?id=193915
3886         <rdar://problem/47560907>
3887
3888         Reviewed by Alex Christensen.
3889
3890         Add API test coverage.
3891
3892         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3893
3894 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3895
3896         [ews-app] Rename id variables
3897         https://bugs.webkit.org/show_bug.cgi?id=193883
3898
3899         Reviewed by Lucas Forschler.
3900
3901         * BuildSlaveSupport/ews-app/ews/models/build.py:
3902         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3903         * BuildSlaveSupport/ews-app/ews/models/step.py:
3904         * BuildSlaveSupport/ews-app/ews/urls.py:
3905         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3906         * BuildSlaveSupport/ews-app/ews/views/results.py:
3907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3908
3909 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3910
3911         [ews-app] Allow certain fields to be empty
3912         https://bugs.webkit.org/show_bug.cgi?id=193892
3913
3914         Reviewed by Lucas Forschler.
3915
3916         * BuildSlaveSupport/ews-app/ews/models/build.py:
3917         * BuildSlaveSupport/ews-app/ews/models/step.py:
3918
3919 2019-01-28  Rob Buis  <rbuis@igalia.com>
3920
3921         Update MIME type parser
3922         https://bugs.webkit.org/show_bug.cgi?id=180526
3923
3924         Reviewed by Frédéric Wang.
3925
3926         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3927         (TestWebKitAPI::TEST):
3928
3929 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3930
3931         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3932         https://bugs.webkit.org/show_bug.cgi?id=193896
3933
3934         Reviewed by Antti Koivisto.
3935
3936         * LayoutReloaded/misc/LFC-passing-tests.txt:
3937
3938 2018-12-15  Darin Adler  <darin@apple.com>
3939
3940         Replace many uses of String::format with more type-safe alternatives
3941         https://bugs.webkit.org/show_bug.cgi?id=192742
3942
3943         Reviewed by Mark Lam.
3944
3945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3946         (WTR::cacheTestRunnerCallback): Use makeString.
3947         * WebKitTestRunner/TestController.cpp:
3948         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3949         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3950
3951 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3952
3953         Use a load optimizer for some sites
3954         https://bugs.webkit.org/show_bug.cgi?id=193881
3955         <rdar://problem/46325455>
3956
3957         Reviewed by Brent Fulgham.
3958
3959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3960         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3961
3962 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3963
3964         AX: Introduce a static accessibility tree
3965         https://bugs.webkit.org/show_bug.cgi?id=193348
3966         <rdar://problem/47203295>
3967
3968         Reviewed by Ryosuke Niwa.
3969
3970         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3971
3972 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3973
3974         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3975         https://bugs.webkit.org/show_bug.cgi?id=193867
3976
3977         Reviewed by Antti Koivisto.
3978
3979         * LayoutReloaded/misc/LFC-passing-tests.txt:
3980
3981 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3982
3983         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3984         https://bugs.webkit.org/show_bug.cgi?id=193865
3985
3986         Reviewed by Antti Koivisto.
3987
3988         * LayoutReloaded/misc/LFC-passing-tests.txt:
3989
3990 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3991
3992         Need a mechanism to override navigator.userAgent
3993         https://bugs.webkit.org/show_bug.cgi?id=193762
3994         <rdar://problem/47504939>
3995
3996         Reviewed by Brent Fulgham.
3997
3998         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3999
4000         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4001         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4002         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4003
4004 2019-01-25  Dean Jackson  <dino@apple.com>
4005
4006         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4007         https://bugs.webkit.org/show_bug.cgi?id=193831
4008         <rdar://problem/47399263>
4009
4010         Reviewed by Chris Dumez.
4011
4012         Two new tests that exercise cross-origin and same-origin System
4013         Previews.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4016
4017 2019-01-25  Keith Rollin  <krollin@apple.com>
4018
4019         Update Xcode projects with "Check .xcfilelists" build phase
4020         https://bugs.webkit.org/show_bug.cgi?id=193790
4021         <rdar://problem/47201374>
4022
4023         Reviewed by Alex Christensen.
4024
4025         Support for XCBuild includes specifying inputs and outputs to various
4026         Run Script build phases. These inputs and outputs are specified as
4027         .xcfilelist files. Once created, these .xcfilelist files need to be
4028         kept up-to-date. In order to check that they are up-to-date or not,
4029         add an Xcode build step that invokes an external script that performs
4030         the checking. If the .xcfilelists are found to be out-of-date, update
4031         them, halt the build, and instruct the developer to restart the build
4032         with up-to-date files.
4033
4034         At this time, the checking and regenerating is performed only if the
4035         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4036         who want to use this facility can set this variable and test out the
4037         checking/regenerating. Once it seems like there are no egregious
4038         issues that upset a developer's workflow, we'll unconditionally enable
4039         this facility.
4040
4041         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4042         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4043         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4044         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4045
4046 2019-01-25  Keith Rollin  <krollin@apple.com>
4047
4048         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4049         https://bugs.webkit.org/show_bug.cgi?id=193781
4050         <rdar://problem/47201153>
4051
4052         Reviewed by Alex Christensen.
4053
4054         Part of generating the .xcfilelists used as part of adopting XCBuild
4055         includes running `make DerivedSources.make` from a standalone script.
4056         It’s important for this invocation to have the same environment as
4057         when the actual build invokes `make DerivedSources.make`. If the
4058         environments are different, then the two invocations will provide
4059         different results. In order to get the same environment in the
4060         standalone script, have the script launch xcodebuild targeting the
4061         "Apply Configuration to XCFileLists" build target, which will then
4062         re-invoke our standalone script. The script is now running again, this
4063         time in an environment with all workspace, project, target, xcconfig
4064         and other environment variables established.
4065
4066         The "Apply Configuration to XCFileLists" build target accomplishes
4067         this task via a small embedded shell script that consists only of:
4068
4069             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
4070
4071         The process that invokes "Apply Configuration to XCFileLists" first
4072         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
4073         evaluated and exports it into the shell environment. When xcodebuild
4074         is invoked, it inherits the value of this variable and can `eval` the
4075         contents of that variable. Our external standalone script can then set
4076         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
4077         of command-line parameters needed to restart itself in the appropriate
4078         state.
4079
4080         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4081         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4082
4083 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4084
4085         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
4086         https://bugs.webkit.org/show_bug.cgi?id=193802
4087         <rdar://problem/46010580>
4088
4089         Reviewed by Andy Estes.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4092         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
4093         (TEST):
4094
4095 2019-01-25  Daniel Bates  <dabates@apple.com>
4096
4097         [iOS] uiController.keyDown() does not translate Control modified key
4098         https://bugs.webkit.org/show_bug.cgi?id=192898
4099
4100         Reviewed by Wenson Hsieh.
4101
4102         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
4103         key translation, as applicable. Among other cases, key translation occurs when performing
4104         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
4105         also makes the behavior of uiController.keyDown() more closely match the behavior of a
4106         human pressing down and releasing key(s) using a hardware keyboard.
4107
4108         * WebKitTestRunner/ios/HIDEventGenerator.h:
4109         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4110         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
4111
4112         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
4113         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
4114         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4115         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4116         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
4117         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4118         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
4119         (-[HIDEventGenerator longPress:completionBlock:]):
4120         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
4121         Update code for above renaming.
4122
4123         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
4124         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
4125
4126         (-[HIDEventGenerator keyDown:]): Added.
4127         (-[HIDEventGenerator keyUp:]): Added.
4128         (-[HIDEventGenerator keyPress:completionBlock:]):
4129         (-[HIDEventGenerator eventDispatchThreadEntry:]):
4130         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
4131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4132         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
4133         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
4134         (WTR::parseModifier): Deleted.
4135
4136 2019-01-25  Keith Rollin  <krollin@apple.com>
4137
4138         Complete the implementation of generate-xcfilelists
4139         https://bugs.webkit.org/show_bug.cgi?id=193782
4140
4141         Reviewed by Alex Christensen.
4142
4143         A preliminary version of generate-xcfilelists was added in r238008.
4144         This patch updates that script in order to:
4145
4146         - Support checking of .xcfilelists
4147         - Perform better execution of `make DerivedSources.make` by
4148           relaunching generate-xcfilelists under xcodebuild
4149         - Support incremental generation and checking of .xcfilelists
4150         - Support supplementary .xcfilelists files from WebKitAdditions
4151         - Support being wrapped by parallel version of generate-xcfilelists in
4152           Internal that adds support for (re)generating WebKit projects in
4153           that repo.
4154         - Support builds that have been performed in WebKitBuild as well as
4155           ~/Library/Developer/code/DerivedData
4156         - Increase robustness and debugging facilities.
4157
4158         * Scripts/generate-xcfilelists:
4159
4160 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4161
4162         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4163         https://bugs.webkit.org/show_bug.cgi?id=193297
4164         <rdar://problem/47158841>
4165
4166         Unreviewed test case fix.
4167
4168         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
4169         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4172         (TEST):
4173
4174 2019-01-25  Keith Rollin  <krollin@apple.com>
4175
4176         Update existing .xcfilelists
4177         https://bugs.webkit.org/show_bug.cgi?id=193791
4178         <rdar://problem/47201706>
4179
4180         Reviewed by Alex Christensen.
4181
4182         Many .xcfilelist files were added in r238824 in order to support
4183         XCBuild. Update these with recent changes to the set of build files
4184         and with the current generate-xcfilelist script.
4185
4186         * DumpRenderTree/DerivedSources-input.xcfilelist:
4187         * DumpRenderTree/DerivedSources-output.xcfilelist:
4188         * WebKitTestRunner/DerivedSources-input.xcfilelist:
4189         * WebKitTestRunner/DerivedSources-output.xcfilelist:
4190
4191 2019-01-25  Keith Rollin  <krollin@apple.com>
4192
4193         Fix missing dependencies in extract-dependencies-from-makefile
4194         https://bugs.webkit.org/show_bug.cgi?id=193783
4195         <rdar://problem/47201571>
4196
4197         Reviewed by Alex Christensen.
4198
4199         The extract-dependencies-from-makefile script generates .xcfilelists
4200         for XCBuild by invoking a makefile in --debug mode, parsing the
4201         dependency information in the output, and extracting information
4202         regarding targets and dependents. However, the way `make` emits this
4203         dependency information is not rigorous, and so we need to determine
4204         what lines to look for and parse by trial and error. This approach
4205         didn't coriginally atch all the information we needed to collect, so
4206         update the script to look for the additional lines we now know to look
4207         for.
4208
4209         * Scripts/extract-dependencies-from-makefile:
4210         (Parser):
4211         (Parser.addTarget):
4212         (Parser.addPrereq):
4213         (Parser.doParse):
4214
4215 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4216
4217         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4218         https://bugs.webkit.org/show_bug.cgi?id=193297
4219         <rdar://problem/47158841>
4220
4221         Reviewed by Alex Christensen.
4222
4223         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4224             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4226         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4227         activating the message used to trigger the callback when it is set.
4228
4229 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4230
4231         WKWebView.goBack should reload if there is a safe browsing warning
4232         https://bugs.webkit.org/show_bug.cgi?id=193805
4233         <rdar://problem/46908216>
4234
4235         Reviewed by Geoff Garen.
4236
4237         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4238         (+[Simple3LookupContext sharedLookupContext]):
4239         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4240         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4241         (TEST):
4242
4243 2019-01-25  Chris Dumez  <cdumez@apple.com>
4244
4245         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4246         https://bugs.webkit.org/show_bug.cgi?id=193788
4247         <rdar://problem/47531231>
4248
4249         Reviewed by Alex Christensen.
4250
4251         Add API test coverage.
4252
4253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4254         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4255
4256 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4257
4258         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4259         https://bugs.webkit.org/show_bug.cgi?id=193771
4260
4261         Unreviewed infrastructure fix.
4262
4263         * Scripts/webkitpy/port/darwin.py:
4264         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4265
4266 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4267
4268         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4269
4270 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4271
4272         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4273
4274         * Scripts/webkitpy/common/config/contributors.json:
4275
4276 2019-01-25  Chris Dumez  <cdumez@apple.com>
4277
4278         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4279         https://bugs.webkit.org/show_bug.cgi?id=193779
4280         <rdar://problem/46170903>
4281
4282         Reviewed by Antti Koivisto.
4283
4284         Add API test that quickly navigates forward to a previous process without waiting for it to
4285         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4286         the process' previous page when reconnecting the it for the forward navigation.
4287
4288         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4289
4290 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4291
4292         Need a way for JavaScript (or bundle) code to participate in undo
4293         https://bugs.webkit.org/show_bug.cgi?id=190009
4294         <rdar://problem/44807048>
4295
4296         Reviewed by Ryosuke Niwa.
4297
4298         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4299         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4300
4301         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4302         (WTR::UIScriptController::lastUndoLabel const):
4303         (WTR::UIScriptController::firstRedoLabel const):
4304         (WTR::UIScriptController::platformUndoManager const):
4305         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4306         (WTR::UIScriptController::lastUndoLabel const):
4307         (WTR::UIScriptController::firstRedoLabel const):
4308         (WTR::UIScriptController::platformUndoManager const):
4309         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4310         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4311         (WTR::UIScriptController::lastUndoLabel const):
4312         (WTR::UIScriptController::firstRedoLabel const):
4313         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4314         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4315         (WTR::UIScriptController::lastUndoLabel const):
4316         (WTR::UIScriptController::firstRedoLabel const):
4317         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4318         (WTR::UIScriptController::platformUndoManager const):
4319         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4320         (WTR::UIScriptController::platformUndoManager const):
4321
4322 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4323
4324         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4325         https://bugs.webkit.org/show_bug.cgi?id=193824
4326
4327         Reviewed by Antti Koivisto.
4328
4329         * LayoutReloaded/misc/LFC-passing-tests.txt:
4330
4331 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4332
4333         Update macOS JSC bot configurations
4334         https://bugs.webkit.org/show_bug.cgi?id=193739
4335
4336         Reviewed by Alexey Proskuryakov.
4337
4338         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4340         (BubbleQueueServer): Move JSC EWS to Mojave section.
4341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4342         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4343         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4344
4345 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4346
4347         [Win][WebKitTestRunner] Implement EventSenderProxy
4348         https://bugs.webkit.org/show_bug.cgi?id=193755
4349
4350         Reviewed by Don Olmstead.
4351
4352         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4353         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4354         (WTR::EventSenderProxy::dispatchMessage):
4355         (WTR::EventSenderProxy::EventSenderProxy):
4356         (WTR::EventSenderProxy::mouseDown):
4357         (WTR::EventSenderProxy::mouseUp):
4358         (WTR::EventSenderProxy::mouseMoveTo):
4359         (WTR::EventSenderProxy::mouseScrollBy):
4360