Pasteboard get messed up after running kill-old-processes
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
2
3         Pasteboard get messed up after running kill-old-processes
4         https://bugs.webkit.org/show_bug.cgi?id=152426
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/kill-old-processes:
9         (main): Do not kill pasteboard anymore.
10
11 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
12
13         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
14         https://bugs.webkit.org/show_bug.cgi?id=152157
15         <rdar://problem/23851817>
16
17         Reviewed by Alexey Proskuryakov.
18
19         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
20         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
21         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22         (Manager._get_test_inputs): Common method to calculate test_inputs.
23         (Manager._update_worker_count): Calculate and update required number of workers.
24
25 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
26
27         run-webkit-tests fails to delete Simulator device during cleanup
28         https://bugs.webkit.org/show_bug.cgi?id=152363
29
30         Reviewed by Alexey Proskuryakov.
31
32         * Scripts/webkitpy/xcode/simulator.py:
33         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
34
35 2015-12-16  Tim Horton  <timothy_horton@apple.com>
36
37         [mac-wk2] fast/events force click tests crashing
38         https://bugs.webkit.org/show_bug.cgi?id=152339
39
40         Reviewed by Beth Dakin.
41
42         * WebKitTestRunner/mac/EventSenderProxy.mm:
43         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
44         Set the NSEvent's _type member in addition to overriding -type,
45         because there are assertions in touch event handling code that depend on it.
46
47 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
48
49         Enforce temporarily bots to sync WebKit and WPT testharness.js
50         https://bugs.webkit.org/show_bug.cgi?id=152334
51
52         Reviewed by Darin Adler.
53
54         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
55         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
56
57 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
58
59         [Fetch API] Add fetch API compile time flag
60         https://bugs.webkit.org/show_bug.cgi?id=152254
61
62         Reviewed by Darin Adler.
63
64         * Scripts/webkitperl/FeatureList.pm:
65
66 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
67
68         Unreviewed.
69
70         Added files that have impact in building Streams API to the watchlist.
71
72         * Scripts/webkitpy/common/config/watchlist:
73
74 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
75
76         Unreviewed.
77
78         Added imported tests to Streams API watchlist.
79
80         * Scripts/webkitpy/common/config/watchlist:
81
82 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
83
84         Remove default copy of wpt testharness.js when launching wpt server
85         https://bugs.webkit.org/show_bug.cgi?id=152298
86
87         Reviewed by Darin Adler.
88
89         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
90         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
91
92 2015-12-15  David Kilzer  <ddkilzer@apple.com>
93
94         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
95         <http://webkit.org/b/152314>
96
97         Reviewed by Daniel Bates.
98
99         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
100         code path to exit immediately when calling main().
101         Unfortunately, DumpRenderTreeMain.mm was used for both
102         DumpRenderTree command-line binary and DumpRenderTree.app, which
103         meant that the app would exit immediately with no error code
104         when run!
105
106         The workaround is to introduce a separate source file called
107         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
108         already does.
109
110         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
111         DumpRenderTreeAppMain.mm to the project.  Make it the only
112         compiled source for the DumpRenderTree.app target.
113         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
114         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
115         case someone tries mistakenly to use the app.
116         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
117         Link to JavaScriptCore.framework on iOS for the assert.
118         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
119         Link to JavaScriptCore.framework on OS X for the assert.  Remove
120         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
121         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
122         (main): Add assert for iOS so that a crash occurs if someone
123         tries to run the wrong command.
124
125 2015-12-14  Tim Horton  <timothy_horton@apple.com>
126
127         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
128         https://bugs.webkit.org/show_bug.cgi?id=152266
129         <rdar://problem/22092676>
130
131         Reviewed by Simon Fraser.
132
133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
134         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
135         Add a test that crashed before this change, and doesn't crash after.
136
137 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
138
139         AX: iOS: Text field variations do not have the correct traits
140         https://bugs.webkit.org/show_bug.cgi?id=152237
141
142         Reviewed by Mario Sanchez Prada.
143
144         Add iOS calls for determing if an object is a search field or a text area.
145
146         * DumpRenderTree/AccessibilityUIElement.cpp:
147         (getIsSearchFieldCallback):
148         (getIsTextAreaCallback):
149         (stringForSelectionCallback):
150         (AccessibilityUIElement::getJSClass):
151         * DumpRenderTree/AccessibilityUIElement.h:
152         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
153         (AccessibilityUIElement::identifier):
154         (AccessibilityUIElement::isTextArea):
155         (AccessibilityUIElement::isSearchField):
156         (AccessibilityUIElement::traits):
157         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
158         (WTR::AccessibilityUIElement::scrollPageRight):
159         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
160         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
161         (WTR::AccessibilityUIElement::isSearchField):
162         (WTR::AccessibilityUIElement::isTextArea):
163         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
164         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
165         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
166         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
167         (WTR::AccessibilityUIElement::isTextArea):
168         (WTR::AccessibilityUIElement::isSearchField):
169         (WTR::AccessibilityUIElement::rowCount):
170
171 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
172
173         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
174         https://bugs.webkit.org/show_bug.cgi?id=152252
175
176         Reviewed by Sergio Villar Senin.
177
178         * gtk/install-dependencies: Add libtool-bin to the list of packages required
179         for building the JHBuild on Debian systems.
180
181 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
182
183         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
184         https://bugs.webkit.org/show_bug.cgi?id=152156
185
186         Reviewed by Dan Bernstein.
187
188         Our frameworks should appropriately prefix all ObjC classes,
189         not just external symbols.
190
191         * Scripts/check-for-inappropriate-objc-class-names:
192         Remove the -g switch to check all ObjC class names.
193
194 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
195
196         [MediaStream] Expose media capture devices persistent permissions to WebCore
197         https://bugs.webkit.org/show_bug.cgi?id=152087
198
199         Add support for the new user media permission checker page UI client method.
200
201         Reviewed by Chris Dumez.
202
203         * WebKitTestRunner/TestController.cpp:
204         (WTR::decidePolicyForUserMediaPermissionRequest):
205         (WTR::checkUserMediaPermissionForOrigin):
206         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
207         (WTR::TestController::createWebViewWithOptions): Ditto.
208         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
209         (WTR::originUserVisibleName): New, create a string for the origin.
210         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
211           according to the state of the origin permission map.
212         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
213           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
214         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
215           origin permission map.
216         * WebKitTestRunner/TestController.h:
217
218 2015-12-10  Alex Christensen  <achristensen@webkit.org>
219
220         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
221         https://bugs.webkit.org/show_bug.cgi?id=152022
222         rdar://problem/23763584
223
224         Reviewed by Darin Adler.
225
226         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
227         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
228         (WTR::InjectedBundlePage::willSendRequestForFrame):
229         * WebKitTestRunner/InjectedBundle/TestRunner.h:
230         (WTR::TestRunner::setWillSendRequestReturnsNull):
231         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
232         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
233         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
234         (WTR::TestRunner::willSendRequestHTTPBody):
235         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
236
237 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
238
239         Remove additional simulator checks before running layout-tests
240         https://bugs.webkit.org/show_bug.cgi?id=152146
241
242         Reviewed by Darin Adler.
243
244         * Scripts/webkitpy/port/ios.py:
245         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
246         * Scripts/webkitpy/xcode/simulator.py:
247         (Simulator._boot_and_shutdown_simulator_device): Deleted.
248         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
249
250 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
251
252         Run atleast one simulator even if max process limit is low
253         https://bugs.webkit.org/show_bug.cgi?id=152081
254         <rdar://problem/23819694>
255
256         Reviewed by Alexey Proskuryakov.
257
258 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
259
260         [GTK] Crash in WebProcess when loading large content with custom URI schemes
261         https://bugs.webkit.org/show_bug.cgi?id=144262
262
263         Reviewed by Carlos Garcia Campos.
264
265         Added new unit test to check the additional scenarios we now
266         handle for custom URI schemes.
267
268         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
269         (generateHTMLContent): New helper function to generate big enough content.
270         (testWebContextURIScheme): New unit test.
271
272 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
273
274         [EFL] Fix unhandled web process message when launching MiniBrowser
275         https://bugs.webkit.org/show_bug.cgi?id=152048
276
277         Reviewed by Gyuyoung Kim.
278
279         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
280         (TestWebKitAPI::TEST):
281
282 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
283
284         [GTK] Add API to handle beforeunload events
285         https://bugs.webkit.org/show_bug.cgi?id=139090
286
287         Reviewed by Gustavo Noronha Silva.
288
289         * MiniBrowser/gtk/BrowserWindow.c:
290         (browserWindowConstructed):
291         (browserWindowDeleteEvent):
292         (browser_window_class_init):
293         Handle delete-event to prevent the window from being closed when
294         the page has beforeunload handlers. Use
295         webkit_web_view_try_close() when the window is requested to be
296         closed.
297         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
298         (testWebViewJavaScriptDialogs):
299         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
300         script dialog type.
301
302 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
303
304         Refactored initialization code in LoadTrackingTest.
305
306         Rubber-stamped by Carlos Garcia Campos.
307
308         Small refactoring to make sure that the state of a LoadTrackingTest
309         gets properly reset before loading new web content.
310
311         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
312         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
313         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
314         functions and reset the remaining local variables.
315         (LoadTrackingTest::loadURI): Call reset();
316         (LoadTrackingTest::loadHtml): Ditto.
317         (LoadTrackingTest::loadPlainText): Ditto.
318         (LoadTrackingTest::loadBytes): Ditto.
319         (LoadTrackingTest::loadRequest): Ditto.
320         (LoadTrackingTest::reload): Ditto.
321         (LoadTrackingTest::goBack): Ditto.
322         (LoadTrackingTest::goForward): Ditto.
323
324 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
325
326         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
327         https://bugs.webkit.org/show_bug.cgi?id=151942
328
329         Reviewed by Darin Adler.
330
331         * MiniBrowser/efl/main.c:
332         (window_create): Enable offline web application cache feature on MiniBrowser.
333         (elm_main):
334
335 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
336
337         https://bugs.webkit.org/show_bug.cgi?id=151243
338         <rdar://problem/22955197>
339
340         Reviewed by Alexey Proskuryakov.
341
342         * LayoutTestRelay/LayoutTestRelay/main.m:
343         (getTestingSimDevice): Use separate testing device for each worker.
344         * Scripts/webkitpy/layout_tests/controllers/manager.py:
345         (Manager.run): Perform cleanup even if setup fails.
346         * Scripts/webkitpy/port/ios.py:
347         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
348         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
349         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
350         (IOSSimulatorPort._quit_ios_simulator): Same
351         (IOSSimulatorPort.clean_up_test_run): Same
352         (IOSSimulatorPort.check_sys_deps): Same
353         (IOSSimulatorPort.testing_device): Same
354         (IOSSimulatorPort.reset_preferences): Same
355         (IOSSimulatorPort.get_simulator_path): Return simulator path.
356         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
357         * Scripts/webkitpy/xcode/simulator.py:
358         (Device.delete): Delete the simulator device.
359         (Simulator.delete_device): Same
360         (Simulator.wait_until_device_is_booted): Wait for device booting.
361
362 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
363
364         [EFL] Add API to provide preferences before creating ewk_view
365         https://bugs.webkit.org/show_bug.cgi?id=151587
366
367         Reviewed by Gyuyoung Kim.
368
369         * MiniBrowser/efl/main.c:
370         (on_key_down):
371         (quit):
372         (window_create):
373         Moved settings related code to configuration() not to update settings
374         whenever ewk_view is created.
375         (configuration):
376         (elm_main):
377
378 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
379
380         Unreviewed. Fix GTK+ API tests after r193639.
381
382         The new jhbuild version needs some more variables ot be present in
383         the builtin dict, even if they are set to None.
384
385         * jhbuild/jhbuildutils.py:
386         (enter_jhbuild_environment_if_available):
387
388 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
389
390         [GTK] Notify WebCore when notification is clicked
391         https://bugs.webkit.org/show_bug.cgi?id=151951
392
393         Reviewed by Carlos Garcia Campos.
394
395         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
396         (testWebViewNotification): test the new API.
397
398 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
399
400         'jhbuild build' should fail immediately when building any module fails
401         https://bugs.webkit.org/show_bug.cgi?id=145697
402
403         Reviewed by Carlos Garcia Campos.
404
405         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
406         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
407         Everything is placed under lib instead of lib64 now.
408         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
409         --exit-on-error when running 'jhbuild build'.
410         * jhbuild/jhbuildrc_common.py:
411         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
412         jhbuild should be able to handle these for us without breaking things....
413
414 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
415
416         Add support to import w3c tests from a repository with a different root that the main repo dir
417         https://bugs.webkit.org/show_bug.cgi?id=151751
418
419         Reviewed by Ryosuke Niwa and Youenn Fablet.
420
421         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
422         in a different directory than the repository root.
423
424         This patch introduces a new parameter tests_directory that we will use as root directory to search for
425         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
426         requires having the copy_path lists including tuples of origin and destination directories.
427
428         * Scripts/webkitpy/w3c/test_downloader.py:
429         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
430         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
431         * Scripts/webkitpy/w3c/test_importer_unittest.py:
432         (TestImporterTest.test_tests_directory): Test.
433
434 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
435
436         Mock TestRepositories in W3C importer tests
437         https://bugs.webkit.org/show_bug.cgi?id=151938
438
439         Reviewed by Youenn Fablet.
440
441         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
442         is because the test repository method reading the file was using the filesystem directly instead of taking the
443         host one. This patch changes that.
444
445         * Scripts/webkitpy/w3c/test_downloader.py:
446         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
447         default one.
448         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
449         * Scripts/webkitpy/w3c/test_importer_unittest.py:
450         (TestImporterTest.test_harnesslinks_conversion):
451         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
452
453 2015-12-07  David Kilzer  <ddkilzer@apple.com>
454
455         TestNetscapePlugIn: Address review comment on 193607
456         <http://webkit.org/b/151881>
457
458         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
459         (testSetStatus): Initializing std::unique_ptr<char[]> with
460         nullptr is redundant.
461
462 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         [GTK] Add webkit_uri_request_get_http_method
465         https://bugs.webkit.org/show_bug.cgi?id=151601
466
467         Reviewed by Martin Robinson.
468
469         Add test case to check HTTP method of WebKitURIRequest.
470
471         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
472         (testURIRequestHTTPMethod):
473         (serverCallback):
474         (beforeAll):
475         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
476         (sendRequestCallback):
477
478 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
481         https://bugs.webkit.org/show_bug.cgi?id=79918
482
483         Reviewed by Gustavo Noronha Silva.
484
485         Add unit tests to check the different console messages.
486
487         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
488         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
489         (ConsoleMessageTest::ConsoleMessage::operator==):
490         (ConsoleMessageTest::consoleMessageReceivedCallback):
491         (ConsoleMessageTest::ConsoleMessageTest):
492         (ConsoleMessageTest::~ConsoleMessageTest):
493         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
494         (testWebKitConsoleMessageConsoleAPI):
495         (testWebKitConsoleMessageJavaScriptException):
496         (testWebKitConsoleMessageNetworkError):
497         (testWebKitConsoleMessageSecurityError):
498         (beforeAll):
499         (afterAll):
500         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
501         (consoleMessageSentCallback):
502         (pageCreatedCallback):
503
504 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
505
506         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
507         https://bugs.webkit.org/show_bug.cgi?id=151934
508
509         Reviewed by Csaba Osztrogonác.
510
511         * MiniBrowser/efl/main.c:
512         (on_window_deletion): Revert the changes of r192767.
513
514 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
515
516         [GTK] update-webkitgtk-libs cannot build mesa
517         https://bugs.webkit.org/show_bug.cgi?id=151535
518
519         Reviewed by Martin Robinson.
520
521         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
522         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
523         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
524         does not have a stable API and we cannot expect mesa to be buildable unless we control the
525         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
526         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
527
528         * gtk/jhbuild.modules:
529
530 2015-12-07  Philippe Normand  <pnormand@igalia.com>
531
532         [GTK][Mac] libWebExtensionTest link error
533         https://bugs.webkit.org/show_bug.cgi?id=150802
534
535         Reviewed by Carlos Garcia Campos.
536
537         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
538
539 2015-12-06  David Kilzer  <ddkilzer@apple.com>
540
541         TestNetscapePlugIn: Fix leaks found by static analyzer
542         <http://webkit.org/b/151881>
543
544         Reviewed by Darin Adler.
545
546         Fixes the following leaks found by the static analyzer:
547             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
548                     return false;
549                            ^~~~~
550             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
551                     return false;
552                            ^~~~~
553             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
554                     return false;
555                            ^~~~~
556
557         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
558         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
559         early return if allocation fails.
560         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
561         Make sure to call fclose() on filehandle, even for an early
562         return.
563         (testSetStatus): Switch to using std::unique_ptr<char[]>.
564
565 2015-12-05  David Kilzer  <ddkilzer@apple.com>
566
567         prepare-ChangeLog: Fix some warning messages when using svn
568         <http://webkit.org/b/151914>
569
570         Reviewed by Daniel Bates.
571
572         * Scripts/prepare-ChangeLog:
573         (generateFunctionLists): Simplify logic so that we never call
574         normalizePath() with an undefined value.
575         (attributeCommand): Quote $subPath for the shell so that we
576         don't try to run "svn propget" on invalid paths.
577
578 2015-12-04  David Kilzer  <ddkilzer@apple.com>
579
580         TestNetscapePlugIn: Fix remaining static analyzer warnings
581         <http://webkit.org/b/151888>
582
583         Reviewed by Alexey Proskuryakov.
584
585         Fixes the following static analyzer warnings:
586             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
587                     CRASH();
588                     ^~~~~~~
589             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
590                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
591                 ^~~~~~~~~~~~~~~~
592             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
593                 return obj->pluginTest->NPP_SetWindow(window);
594                        ^~~~~~~~~~~~~~~
595             2 warnings generated.
596
597         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
598         (CRASH): Use __builtin_trap() for gcc/clang.
599         (NPP_SetWindow): Add early return if obj is nullptr.
600
601 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
604         https://bugs.webkit.org/show_bug.cgi?id=151797
605
606         Reviewed by Martin Robinson.
607
608         Since we switched to use the network process to run the unit tests
609         the test /webkit2/WebKitWebResource/get-data sometimes fails and
610         sometimes passes. We are now also getting the notification for the
611         css image. Since we wait for 3 resources, sometimes the css image
612         is loaded before and then checkResourceData is called for it, but
613         not handled. When the css image is the last one loaded the test
614         passes. So, we just need to wait for the 4 resources.
615
616         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
617         (testWebResourceGetData):
618
619 2015-12-03  David Kilzer  <ddkilzer@apple.com>
620
621         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
622         <http://webkit.org/b/151845>
623
624         Reviewed by Simon Fraser.
625
626         Fixes the following static analyzer warning:
627             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
628                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
629                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
630
631         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
632         (createBitmapContext): Free 'buffer' after using it in logging
633         to fix the use-after-free.  Assign a value of nullptr to buffer
634         so we don't return with it set to a freed address.
635
636 2015-12-03  Jer Noble  <jer.noble@apple.com>
637
638         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
639         https://bugs.webkit.org/show_bug.cgi?id=151830
640
641         Reviewed by Anders Carlsson.
642
643         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
644
645         * DumpRenderTree/mac/DumpRenderTree.mm:
646         (resetWebPreferencesToConsistentValues):
647         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
648         (WTR::initializeWebViewConfiguration):
649
650 2015-12-03  Anders Carlsson  <andersca@apple.com>
651
652         Remove Objective-C GC support
653         https://bugs.webkit.org/show_bug.cgi?id=151819
654         rdar://problem/23746991
655
656         Reviewed by Dan Bernstein.
657
658         * asan/asan.xcconfig:
659
660 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
661
662         Allow nil for unspecified benchmark pathes
663         https://bugs.webkit.org/show_bug.cgi?id=151784
664
665         Reviewed by Filip Pizlo.
666
667         `Pathname.new(nil)` will raise an error.
668         Only generate Pathname if the benchmark path is specified.
669
670         * Scripts/run-jsc-benchmarks:
671
672 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
673
674         [Win] Run non-http tests without Cygwin
675         https://bugs.webkit.org/show_bug.cgi?id=151721
676
677         Reviewed by Andy Estes.
678
679         Support native 32-bit and 64-bit Python (and Perl) builds
680         for running tests:
681
682         1. Use "startswith('win')", rather than "== 'win32'" to support
683         various Windows build types.
684         2. Supply full path for some native Windows utilities, since the
685         path environment does not always have the specified, and they are
686         guaranteed to exist in those specific locations.
687         3. Make sure native Windows Python test runs pass proper environment
688         variables to run programs.
689         4. Append 'exe' suffix when running Windows executables.
690         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
691         command doesn't exist.
692         
693         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
694         the current Perl executable, rather than requiring a new path search.
695         * Scripts/webkitpy/common/find_files_unittest.py:
696         (TestWinNormalize.test_win): Use startswith('win').
697         * Scripts/webkitpy/common/prettypatch_unittest.py:
698         (test_pretty_diff_encodings): Ditto.
699         * Scripts/webkitpy/common/system/executive.py:
700         (Executive._should_close_fds): Ditto.
701         (Executive.shell_command_for_script): Use startswith('win').
702         (Executive.kill_process): Use full path to killall executable.
703         (Executive.check_running_pid): Use startswith('win').
704         (Executive.running_pids): Ditto.
705         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
706         running under native Windows Python.
707         (Executive._child_process_encoding): Use startswith('win').
708         (Executive._should_encode_child_process_arguments): Ditto.
709         (Executive.popen): Recognize proper script engine on Windows, since it
710         does not support the shebang syntax.
711         (Executive.run_in_parallel): Use startswith('win').
712         * Scripts/webkitpy/common/system/executive_unittest.py:
713         (never_ending_command): Ditto.
714         (ExecutiveTest.test_run_command_with_unicode): Ditto.
715         (ExecutiveTest.serial_test_kill_process): Ditto.
716         (ExecutiveTest.serial_test_kill_all): Ditto.
717         (ExecutiveTest.serial_test_check_running_pid): Ditto.
718         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
719         (main): Ditto.
720         * Scripts/webkitpy/common/system/file_lock.py:
721         (FileLock._create_lock): Ditto.
722         (FileLock._remove_lock): Ditto.
723         * Scripts/webkitpy/common/system/filesystem_unittest.py:
724         (RealFileSystemTest.test_chdir): Ditto.
725         (RealFileSystemTest.test_chdir__notexists): Ditto.
726         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
727         * Scripts/webkitpy/common/system/path_unittest.py:
728         (AbspathTest.test_abspath_to_uri_win): Ditto.
729         * Scripts/webkitpy/common/system/platforminfo.py:
730         (PlatformInfo._determine_os_name): Ditto.
731         * Scripts/webkitpy/common/system/user.py: Ditto.
732         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
733         (ManagerTest.integration_test_needs_servers): Ditto.
734         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
735         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
736         driver letters.
737         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
738         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
739         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
740         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
741         (HttpServerBase._check_that_all_ports_are_available): Ditto.
742         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
743         (TestHttpServer.test_start_cmd): Ditto.
744         * Scripts/webkitpy/port/base.py:
745         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
746         and 'SYSTEMROOT' in environment passed to test runners.
747         (Port._apache_config_file_name_for_platform): Use startswith('win').
748         (Port._build_path): Ditto.
749         (Port._path_to_driver): Include 'exe' suffix when running under native
750         Windows.
751         * Scripts/webkitpy/port/driver.py:
752         (Driver._setup_environ_for_driver): Explicitly make some environment
753         variables strings.
754         * Scripts/webkitpy/port/server_process.py:
755         (ServerProcess.__init__): Use startswith('win').
756         * Scripts/webkitpy/port/win.py:
757         (WinPort): Use the win32 registry utilities on Windows, and appropriate
758         registry key formats.
759         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
760         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
761         and regtool on Cygwin.
762         (WinPort.write_registry_value): Ditto.
763         (WinPort.setup_crash_log_saving): Ditto.
764         (WinPort.restore_crash_log_saving): Ditto.
765         (WinPort.prevent_error_dialogs): Ditto.
766         (WinPort.allow_error_dialogs): Ditto.
767         (WinPort.find_system_pid): Revise to use Windows management
768         infrastructure on native Windows, continue using 'ps' on Cygwin.
769         (WinPort.read_registry_string): Deleted.
770         (WinPort.write_registry_string): Deleted.
771         * Scripts/webkitpy/test/main.py:
772         (main): Use startswith('win').
773         (Tester._parse_args): Ditto.
774
775 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
776
777         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
778         https://bugs.webkit.org/show_bug.cgi?id=150792
779
780         Reviewed by Saam Barati.
781
782         * Scripts/webkitperl/FeatureList.pm:
783
784 2015-12-01  Commit Queue  <commit-queue@webkit.org>
785
786         Unreviewed, rolling out r192914.
787         https://bugs.webkit.org/show_bug.cgi?id=151734
788
789         JSC tests for this change are failing on 32 and 64-bit bots
790         (Requested by ryanhaddad on #webkit).
791
792         Reverted changeset:
793
794         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
795         enable this feature"
796         https://bugs.webkit.org/show_bug.cgi?id=150792
797         http://trac.webkit.org/changeset/192914
798
799 2015-12-01  David Kilzer  <ddkilzer@apple.com>
800
801         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
802         <http://webkit.org/b/151726>
803
804         Reviewed by Simon Fraser.
805
806         * WebKitTestRunner/mac/EventSenderProxy.mm:
807         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
808         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
809
810 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
811
812         Give String and AtomicString an existingHash() function
813         https://bugs.webkit.org/show_bug.cgi?id=151717
814
815         Reviewed by Andreas Kling.
816
817         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
818         (TestWebKitAPI::TEST):
819         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
820         (TestWebKitAPI::TEST):
821
822 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
823
824         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
825         https://bugs.webkit.org/show_bug.cgi?id=150792
826
827         Reviewed by Saam Barati.
828
829         * Scripts/webkitperl/FeatureList.pm:
830
831 2015-12-01  Sam Weinig  <sam@webkit.org>
832
833         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
834         <rdar://problem/23320863>
835         https://bugs.webkit.org/show_bug.cgi?id=151708
836
837         Reviewed by Anders Carlsson.
838
839         * WebKitTestRunner/TestController.cpp:
840         (WTR::TestController::createOtherPage):
841         (WTR::TestController::createWebViewWithOptions):
842         Update for new WKPageUIClient.
843
844 2015-12-01  Anders Carlsson  <andersca@apple.com>
845
846         Remove WebKit2.framework
847         https://bugs.webkit.org/show_bug.cgi?id=151715
848
849         Reviewed by Dan Bernstein.
850
851         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
852         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
853         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
854         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
855         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
856         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
857         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
858
859 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
860
861         Unreviewed common typo fix "occurance" => "occurrence".
862
863         * Scripts/webkitpy/tool/commands/queries.py:
864         (FindFlakyTests._print_statistics):
865
866 2015-11-30  Alex Christensen  <achristensen@webkit.org>
867
868         Make ProcessModel always MultipleSecondaryProcesses
869         https://bugs.webkit.org/show_bug.cgi?id=151662
870
871         Reviewed by Antti Koivisto.
872
873         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
874         (TestWebKitAPI::TEST):
875         * WebKitTestRunner/TestController.cpp:
876         (WTR::TestController::generatePageConfiguration):
877
878 2015-11-30  Alex Christensen  <achristensen@webkit.org>
879
880         Make usesNetworkProcess always true
881         https://bugs.webkit.org/show_bug.cgi?id=151580
882
883         Reviewed by Darin Adler.
884
885         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
886         (TestWebKitAPI::TEST):
887         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
888         (TestWebKitAPI::TEST):
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::generatePageConfiguration):
891
892 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
893
894         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
895
896         Add a way to skip unit tests only for Debug or Release builds and
897         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
898
899         * Scripts/run-gtk-tests:
900         (SkippedTest):
901         (SkippedTest.__init__):
902         (SkippedTest.__str__):
903         (SkippedTest.skip_entire_suite):
904         (SkippedTest.skip_for_build_type):
905         (TestRunner):
906         (TestRunner.__init__):
907
908 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
909
910         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
911
912         It's an assert hit because we are reloading a view loaded with
913         HTML data which is not supported. Use loadURI instead.
914
915         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
916         (testWebViewCustomCharset):
917
918 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
919
920         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
921         https://bugs.webkit.org/show_bug.cgi?id=151633
922
923         Reviewed by Csaba Osztrogonác.
924
925         * TestWebKitAPI/PlatformGTK.cmake:
926         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
927
928 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         [GTK] Remove the remaining uses of GMainLoopSource
931         https://bugs.webkit.org/show_bug.cgi?id=151632
932
933         Reviewed by Žan Doberšek.
934
935         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
936         (testWebViewSyncRequestOnMaxConns):
937         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
938         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
939         (WTR::TestRunner::TestRunner):
940         * WebKitTestRunner/InjectedBundle/TestRunner.h:
941         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
942         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
943         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
944         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
945         (WTR::timeoutSource):
946         (WTR::TestController::notifyDone):
947         (WTR::TestController::platformRunUntil):
948
949 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
950
951         [cmake] Add testb3 to the build system
952         https://bugs.webkit.org/show_bug.cgi?id=151619
953
954         Reviewed by Gyuyoung Kim.
955
956         * Scripts/build-jsc:
957
958 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
959
960         [jhbuild] Fix pixman build with clang
961         https://bugs.webkit.org/show_bug.cgi?id=151441
962
963         Reviewed by Carlos Garcia Campos.
964
965         * efl/jhbuild.modules:
966         * gtk/jhbuild.modules:
967
968 2015-11-26  David Kilzer  <ddkilzer@apple.com>
969
970         Extract prependToEnvironmentVariableList
971         <http://webkit.org/b/151536>
972
973         Reviewed by Daniel Bates.
974
975         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
976                webkitdirs_unittest/prependToEnvironmentVariableList.pl
977
978         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
979         and prependToEnvironmentVariableList.
980         (appendToEnvironmentVariableList): Simplify variable name.
981         Switch to use $Config{path_sep}.
982         (prependToEnvironmentVariableList): Add new method.
983         (setupMacWebKitEnvironment): Switch to use
984         prependToEnvironmentVariableList().
985         (setupIOSWebKitEnvironment): Ditto.
986
987         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
988         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
989
990 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
991
992         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
993         https://bugs.webkit.org/show_bug.cgi?id=151567
994
995         Reviewed by Darin Adler.
996
997         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
998         (on_window_deletion):
999
1000 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         [GTK] Use the network process unconditionally
1003         https://bugs.webkit.org/show_bug.cgi?id=151541
1004
1005         Reviewed by Alex Christensen.
1006
1007         Fix TestInspectorServer test. Do not assume we already have the
1008         title we want when the page has been loaded, since the title is
1009         changed afterwards. So, check if the title has already been set,
1010         and if not wait for it.
1011
1012         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1013         (openRemoteDebuggingSession):
1014
1015 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1016
1017         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1018         https://bugs.webkit.org/show_bug.cgi?id=151532
1019
1020         Reviewed by Benjamin Poulain.
1021
1022         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1023         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1024         (TestWebKitAPI::TEST):
1025         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1026         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1027         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1028         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1029         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1030         so it was calling a function on a test object that had gone out of scope.
1031         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1032         but that will become the default soon and that call will be removed.
1033
1034 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1035
1036         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1037         <http://webkit.org/b/151542>
1038
1039         Reviewed by Daniel Bates.
1040
1041         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1042         (base_url): Use the Port object (already passed in) to give us
1043         the path to the LayoutTests directory, which already checks for a
1044         --layout-tests-directory command-line switch.
1045         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1046         argument since we can get this from the Port object already
1047         passed in via Port.results_directory().  Also switch to use
1048         Port.layout_tests_dir() to get the LayoutTests directory.
1049
1050         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1051         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1052         Add test case for custom LayoutTests directory.
1053         (TestWebPlatformTestServer.test_previously_spawned_instance):
1054         Update Port object to set mock results directory as if it was
1055         set on the command-line.  Remove unneeded argument from
1056         WebPlatformTestServer constructor.
1057         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1058
1059         * Scripts/webkitpy/port/base.py:
1060         (Port.to.start_web_platform_test_server): Remove unneeded
1061         argument from WebPlatformTestServer constuctor.
1062
1063 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1064
1065         [GTK] Some unit tests fail when using the network process
1066         https://bugs.webkit.org/show_bug.cgi?id=151490
1067
1068         Reviewed by Martin Robinson.
1069
1070         Run the soup server in a separate thread in TestResources test to
1071         avoid deadlocks.
1072
1073         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1074         /webkit2/WebKitWebResource/get-data when using the network process.
1075
1076         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1077         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1078         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1079         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1080         present, create a WorkQueue to run the server.
1081         (WebKitTestServer::run): Run the server in the work queue if it
1082         has been created.
1083         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1084         type into server options as flags.
1085
1086 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1087
1088         [GTK] ImageDiff should normalize the diff image
1089         https://bugs.webkit.org/show_bug.cgi?id=151261
1090
1091         Reviewed by Sergio Villar Senin.
1092
1093         * ImageDiff/gtk/ImageDiff.cpp:
1094         (readPixbufFromStdin): Fix memory leak.
1095         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1096         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1097
1098 == Rolled over to ChangeLog-2015-11-21 ==