Teach WebKitTestRunner and DumpRenderTree about detecting world leaks
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
2
3         Teach WebKitTestRunner and DumpRenderTree about detecting world leaks
4         https://bugs.webkit.org/show_bug.cgi?id=188994
5
6         Reviewed by Tim Horton.
7         
8         This patch adds the notion of a "control command" in the protocol between webkitpy and 
9         WebKitTestRunner/DumpRenderTree. A command is simply an input string starting with a #
10         that is checked for before trying to parse the input as test URL. For now, just one
11         commmand is supported, which is "#CHECK FOR WORLD LEAKS".
12         
13         In response to the command, the tool dumps an output block in the usual pseudo-MIME-style,
14         with a trailing "#EOF". Future patches will add support to webkitpy to parse this output.
15         
16         DumpRenderTree stubs out the command, returning an empty block.
17         
18         WebKitTestRunner responds to the command by dumping the list of live documents, if it was
19         run with the --check-for-world-leaks option.
20         
21         When run with --check-for-world-leaks, WebKitTestRunner gets the list of live documents via
22         WKBundleGetLiveDocumentURLs() after every test (this allows it to detect the first test
23         that leaked a document), and keeps them in a map of document identifier to test and live document URL.
24         Then when it receives the "#CHECK FOR WORLD LEAKS" command, it calls into the bundle to
25         clear the page and memory caches, runs a GC, then posts a task (in the Document::postTaks() sense)
26         after which it requests the list of live documents for a final time, excluding any that are loaded
27         in live Frames (thus omitting the about:blank that will be loaded at this point). Documents in this
28         list are therefore leaked (or abandoned).
29         
30         Future patches will hook up webkitpy reporting for leaked documents.
31
32         * DumpRenderTree/mac/DumpRenderTree.mm:
33         (initializeGlobalsFromCommandLineOptions):
34         (handleControlCommand):
35         (runTestingServerLoop):
36         * DumpRenderTree/win/DumpRenderTree.cpp:
37         (handleControlCommand):
38         (main):
39         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
40         (WTR::postGCTask):
41         (WTR::InjectedBundle::reportLiveDocuments):
42         (WTR::InjectedBundle::didReceiveMessageToPage):
43         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
44         * WebKitTestRunner/Options.cpp:
45         (WTR::handleOptionCheckForWorldLeaks):
46         (WTR::OptionsHandler::OptionsHandler):
47         * WebKitTestRunner/Options.h:
48         * WebKitTestRunner/TestController.cpp:
49         (WTR::AsyncTask::run):
50         (WTR::AsyncTask::currentTask):
51         (WTR::TestController::initialize):
52         (WTR::TestController::ensureViewSupportsOptionsForTest):
53         (WTR::TestController::resetStateToConsistentValues):
54         (WTR::TestController::updateLiveDocumentsAfterTest):
55         (WTR::TestController::checkForWorldLeaks):
56         (WTR::TestController::findAndDumpWorldLeaks):
57         (WTR::TestController::willDestroyWebView):
58         (WTR::parseInputLine):
59         (WTR::TestController::waitForCompletion):
60         (WTR::TestController::handleControlCommand):
61         (WTR::TestController::runTestingServerLoop):
62         (WTR::TestController::run):
63         (WTR::TestController::didReceiveLiveDocumentsList):
64         (WTR::TestController::didReceiveMessageFromInjectedBundle):
65         * WebKitTestRunner/TestController.h:
66         (WTR::AsyncTask::AsyncTask):
67         (WTR::AsyncTask::taskComplete):
68         (WTR::TestController::AbandonedDocumentInfo::AbandonedDocumentInfo):
69         * WebKitTestRunner/TestInvocation.cpp:
70         (WTR::TestInvocation::invoke):
71         * WebKitTestRunner/TestOptions.h:
72         (WTR::TestOptions::hasSameInitializationOptions const):
73
74 2018-08-27  Alex Christensen  <achristensen@webkit.org>
75
76         Fix API test after r235398
77         https://bugs.webkit.org/show_bug.cgi?id=188997
78
79         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
80         (TestWebKitAPI::setPageLoaderClient):
81         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
82         willGoToBackForwardListItem is unused and unsupported.  Removing its check.
83
84 2018-08-27  Daniel Bates  <dabates@apple.com>
85
86         Partial revert of r235376
87         https://bugs.webkit.org/show_bug.cgi?id=189011
88
89         For now revert the unit tests added in r235376 as the following tests are failing on Apple Sierra
90         Debug and Apple High Sierra Debug bots:
91
92             lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_simple
93             lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple
94
95         Will investigate offline.
96
97         * lldb/lldbWebKitTester/main.cpp:
98         (testSummaryProviders):
99         * lldb/lldb_webkit_unittest.py:
100         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
101         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty): Deleted.
102         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple): Deleted.
103         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Deleted.
104         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple): Deleted.
105
106 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
107
108         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
109         https://bugs.webkit.org/show_bug.cgi?id=188931
110
111         Reviewed by Wenson Hsieh.
112
113         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
114
115 2018-08-27  Justin Fan  <justin_fan@apple.com>
116
117         Add Justin Fan to list of WebKit contributors
118         https://bugs.webkit.org/show_bug.cgi?id=184431
119
120         * Scripts/webkitpy/common/config/contributors.json:
121
122 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
123
124         Convert timeout values in WebKitTestRunner to WTF::Seconds
125         https://bugs.webkit.org/show_bug.cgi?id=188987
126
127         Reviewed by Ryosuke Niwa.
128         
129         Replace various 'int' timeout values with WTF::Seconds. The timeout argument
130         comes in as milliseconds, so convert on input. When sending messages to the InjectedBundle
131         using integers, convert to and from milliseconds.
132         
133         Also do some #pragma once, and initializer cleanup.
134
135         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
136         (WTR::InjectedBundle::didReceiveMessageToPage):
137         (WTR::InjectedBundle::beginTesting):
138         (WTR::InjectedBundle::InjectedBundle): Deleted.
139         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
141         (WTR::TestRunner::timeout):
142         (WTR::TestRunner::setCustomTimeout):
143         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
144         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
145         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
146         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
147         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
148         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
149         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
150         * WebKitTestRunner/TestController.cpp:
151         (WTR::TestController::TestController):
152         (WTR::parseInputLine):
153         (WTR::TestController::runTest):
154         (WTR::TestController::runUntil):
155         (WTR::TestController::didReceiveMessageFromInjectedBundle):
156         * WebKitTestRunner/TestController.h:
157         * WebKitTestRunner/TestInvocation.cpp:
158         (WTR::TestInvocation::shortTimeout const):
159         (WTR::TestInvocation::createTestSettingsDictionary):
160         * WebKitTestRunner/TestInvocation.h:
161         * WebKitTestRunner/TestOptions.h:
162         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
163         (WTR::TestController::platformRunUntil):
164         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
165         (WTR::TestController::platformRunUntil):
166         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
167         (WTR::TestController::platformRunUntil):
168
169 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
170
171         Convert timeout values in WebKitTestRunner to WTF::Seconds
172         https://bugs.webkit.org/show_bug.cgi?id=188987
173
174         Reviewed by Ryosuke Niwa.
175         
176         Replace various 'int' timeout values with WTF::Seconds. The timeout argument
177         comes in as milliseconds, so convert on input. When sending messages to the InjectedBundle
178         using integers, convert to and from milliseconds.
179         
180         Also do some #pragma once, and initializer cleanup.
181
182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
183         (WTR::InjectedBundle::didReceiveMessageToPage):
184         (WTR::InjectedBundle::beginTesting):
185         (WTR::InjectedBundle::InjectedBundle): Deleted.
186         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
188         (WTR::TestRunner::timeout):
189         (WTR::TestRunner::setCustomTimeout):
190         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
191         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
192         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
193         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
194         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
195         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
196         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::TestController):
199         (WTR::parseInputLine):
200         (WTR::TestController::runTest):
201         (WTR::TestController::runUntil):
202         (WTR::TestController::didReceiveMessageFromInjectedBundle):
203         * WebKitTestRunner/TestController.h:
204         * WebKitTestRunner/TestInvocation.cpp:
205         (WTR::TestInvocation::shortTimeout const):
206         (WTR::TestInvocation::createTestSettingsDictionary):
207         * WebKitTestRunner/TestInvocation.h:
208         * WebKitTestRunner/TestOptions.h:
209         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
210         (WTR::TestController::platformRunUntil):
211         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
212         (WTR::TestController::platformRunUntil):
213         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
214         (WTR::TestController::platformRunUntil):
215
216 2018-08-27  Alex Christensen  <achristensen@webkit.org>
217
218         REGRESSION(r234985/r234989) WKPageLoadHTMLString with a 16-bit String has the wrong encoding
219         https://bugs.webkit.org/show_bug.cgi?id=189002
220
221         Reviewed by Tim Horton.
222
223         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
224         (TestWebKitAPI::TEST_F):
225
226 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
227
228         [Cocoa] Exception (fileType 'dyn.agq8u' is not a valid UTI) raised when dragging an attachment whose file wrapper is a directory
229         https://bugs.webkit.org/show_bug.cgi?id=188903
230         <rdar://problem/43702993>
231
232         Reviewed by Tim Horton.
233
234         Add two API tests and adjust existing WKAttachment API tests. The new tests exercise the following scenarios, in
235         both iOS and macOS:
236         •       Dropping a folder as an attachment element, and then moving that attachment element in the document by
237                 dragging and dropping.
238         •       Using WKWebView SPI to insert a folder and a file with an unknown extension, and then using more
239                 _WKAttachment SPI to swap the attachments' backing file wrappers.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
242         (runTestWithTemporaryFolder):
243
244         Add a helper function to run a test with a new folder path, created in the temporary directory and populated
245         with some sample content. This folder is deleted after running the test.
246
247         (simulateFolderDragWithURL):
248
249         Add a helper function to prepare a given DragAndDropSimulator for simulating a dragged folder from a source
250         external to the web view.
251
252         (platformCopyRichTextWithMultipleAttachments):
253         (platformCopyRichTextWithImage):
254         (platformCopyPNG):
255         (TestWebKitAPI::TEST):
256
257         Add new API tests, and adjust existing tests to reflect new -setFileWrapper:…: behavior. Specifically,
258         ChangeAttachmentDataAndFileInformation previously required that changing a _WKAttachment's NSFileWrapper would
259         preserve the previous NSFileWrapper's preferred name if the new file wrapper does not have a preferred name, but
260         this quirk is no longer supported.
261
262         Also add a few bridging casts for the eventual transition of TestWebKitAPI to ARC.
263
264         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
265
266         Add a new hook to clear any external drag information on an existing DragAndDropSimulator. This is convenient
267         when using the same DragAndDropSimulator to perform multiple drags in a single test.
268
269         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
270         (-[DragAndDropSimulator clearExternalDragInformation]):
271         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
272         (-[DragAndDropSimulator clearExternalDragInformation]):
273
274 2018-08-27  Alex Christensen  <achristensen@webkit.org>
275
276         Translate 4 tests using WKPageLoaderClient to ObjC
277         https://bugs.webkit.org/show_bug.cgi?id=188827
278
279         Reviewed by Tim Horton.
280
281         They use processDidBecomeUnresponsive, didChangeBackForwardList, or willGoToBackForwardListItem.
282         Rather than introduce these to WKPageNavigationClient, I just translated the tests to use WKNavigationDelegate, which already have equivalent callbacks.
283         willGoToBackForwardListItem had userData from the InjectedBundle, but nobody was using it so I did not add that to the ObjC SPI, so I don't test that unused
284         bundle functionality any more.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp: Removed.
288         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
289         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp: Removed.
290         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp: Removed.
291         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
292         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp.
293         (-[ResponsivenessTimerDelegate webView:didFinishNavigation:]):
294         (-[ResponsivenessTimerDelegate _webViewWebProcessDidBecomeUnresponsive:]):
295         (TestWebKitAPI::TEST):
296         (): Deleted.
297         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
298         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
299         (TestWebKitAPI::setPageLoaderClient): Deleted.
300         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp.
301         (-[ResponsivenessDelegate webView:didFinishNavigation:]):
302         (-[ResponsivenessDelegate _webViewWebProcessDidBecomeUnresponsive:]):
303         (TestWebKitAPI::TEST):
304         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Deleted.
305         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
306         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
307         (TestWebKitAPI::setInjectedBundleClient): Deleted.
308         (TestWebKitAPI::setPageLoaderClient): Deleted.
309         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp.
310         (-[SessionStateDelegate webView:didFinishNavigation:]):
311         (-[SessionStateDelegate _webView:backForwardListItemAdded:removed:]):
312         (TestWebKitAPI::createSessionStateData):
313         (TestWebKitAPI::TEST):
314         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
315         (TestWebKitAPI::didChangeBackForwardListForPage): Deleted.
316         (TestWebKitAPI::setPageLoaderClient): Deleted.
317         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp.
318         (-[BackForwardClient webView:didFinishNavigation:]):
319         (-[BackForwardClient _webView:willGoToBackForwardListItem:inPageCache:]):
320         (TestWebKitAPI::TEST):
321         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
322         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
323         (TestWebKitAPI::setPageLoaderClient): Deleted.
324
325 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
326
327         [Cocoa] "video.html" appears at the top level of the TestWebKitAPI Xcode project
328         https://bugs.webkit.org/show_bug.cgi?id=188989
329
330         Reviewed by Andy Estes.
331
332         Move this into the Tests/WebKit/Resources group in the project.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335
336 2018-08-27  Thomas Denney  <tdenney@apple.com>
337
338         Avoid an exception in the interactive interpreter
339         https://bugs.webkit.org/show_bug.cgi?id=188991
340
341         Reviewed by Myles C. Maxfield.
342
343         * WebGPUShadingLanguageRI/index.html: Corrects a typo in the name of a
344         local variable
345
346 2018-08-27  Thomas Denney  <tdenney@apple.com>
347
348         Allow new vector types to work with the interactive interpreter
349         https://bugs.webkit.org/show_bug.cgi?id=188988
350
351         Reviewed by Myles C. Maxfield.
352
353         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
354         (FlattenedStructOffsetGatherer.prototype.visitTypeRef): Do not
355         unncessarily visit the type arguments of a TypeRef, as by this point
356         there are none that are relevant.
357         * WebGPUShadingLanguageRI/Intrinsics.js:
358         (Intrinsics): Treat VectorType as a primitive type.
359
360 2018-08-27  Keith Rollin  <krollin@apple.com>
361
362         Build system support for LTO
363         https://bugs.webkit.org/show_bug.cgi?id=187785
364         <rdar://problem/42353132>
365
366         Reviewed by Dan Bernstein.
367
368         Add tools/scripts support for controlling LTO builds.
369
370         * Scripts/build-webkit: Add --lto-mode={none,thin,full}.
371         * Scripts/set-webkit-configuration: Add support for saving LTO
372         configuration to WebKitBuild/LTO.
373         * Scripts/webkitdirs.pm: Add support for reading configuration from
374         WebKitBuild/LTO and providing it to xcodebuild.
375         (determineLTOMode):
376         (ltoMode):
377         (XcodeOptions):
378
379 2018-08-27  Daniel Bates  <dabates@apple.com>
380
381         lldb-webkit: Pretty-print OptionSet
382         https://bugs.webkit.org/show_bug.cgi?id=188936
383
384         Reviewed by Simon Fraser.
385
386         Add LLDB formatters to pretty-print an OptionSet.
387
388         * lldb/lldbWebKitTester/main.cpp:
389         (testSummaryProviders):
390         * lldb/lldb_webkit.py:
391         (__lldb_init_module):
392         (__lldb_init_module.lldb_webkit):
393         (WTFOptionSet_SummaryProvider):
394         (WTFOptionSetProvider):
395         (WTFOptionSetProvider.__init__):
396         (WTFOptionSetProvider.has_children):
397         (WTFOptionSetProvider.num_children):
398         (WTFOptionSetProvider.get_child_index):
399         (WTFOptionSetProvider.get_child_at_index):
400         (WTFOptionSetProvider.update):
401         * lldb/lldb_webkit_unittest.py:
402         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
403         (TestSummaryProviders):
404         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
405         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
406         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
407         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
408
409 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
410
411         [Attachment Support] [WK2] Images copied from Mail message view paste with the wrong file name in compose
412         https://bugs.webkit.org/show_bug.cgi?id=188957
413         <rdar://problem/43737715>
414
415         Reviewed by Darin Adler.
416
417         Add a new API test to verify that pasting a web archive containing several image elements with alt attributes
418         generates _WKAttachments whose names reflect those alt attributes.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
421         (testGIFFileURL):
422         (testGIFData):
423         (TestWebKitAPI::TEST):
424
425 2018-08-27  Alex Christensen  <achristensen@webkit.org>
426
427         Unreviewed, rolling out r235367.
428
429         Broke iOS build.
430
431         Reverted changeset:
432
433         "Translate 4 tests using WKPageLoaderClient to ObjC"
434         https://bugs.webkit.org/show_bug.cgi?id=188827
435         https://trac.webkit.org/changeset/235367
436
437 2018-08-27  Alex Christensen  <achristensen@webkit.org>
438
439         Fix GTK build.
440
441         * TestWebKitAPI/CMakeLists.txt:
442
443 2018-08-27  Alex Christensen  <achristensen@webkit.org>
444
445         Fix iOS build.
446
447         * TestWebKitAPI/PlatformWebView.h:
448
449 2018-08-27  Alex Christensen  <achristensen@webkit.org>
450
451         Translate 4 tests using WKPageLoaderClient to ObjC
452         https://bugs.webkit.org/show_bug.cgi?id=188827
453
454         Reviewed by Tim Horton.
455
456         They use processDidBecomeUnresponsive, didChangeBackForwardList, or willGoToBackForwardListItem.
457         Rather than introduce these to WKPageNavigationClient, I just translated the tests to use WKNavigationDelegate, which already have equivalent callbacks.
458         willGoToBackForwardListItem had userData from the InjectedBundle, but nobody was using it so I did not add that to the ObjC SPI, so I don't test that unused
459         bundle functionality any more.
460
461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
462         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp: Removed.
463         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
464         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp: Removed.
465         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp: Removed.
466         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
467         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp.
468         (-[ResponsivenessTimerDelegate webView:didFinishNavigation:]):
469         (-[ResponsivenessTimerDelegate _webViewWebProcessDidBecomeUnresponsive:]):
470         (TestWebKitAPI::TEST):
471         (): Deleted.
472         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
473         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
474         (TestWebKitAPI::setPageLoaderClient): Deleted.
475         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp.
476         (-[ResponsivenessDelegate webView:didFinishNavigation:]):
477         (-[ResponsivenessDelegate _webViewWebProcessDidBecomeUnresponsive:]):
478         (TestWebKitAPI::TEST):
479         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Deleted.
480         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
481         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
482         (TestWebKitAPI::setInjectedBundleClient): Deleted.
483         (TestWebKitAPI::setPageLoaderClient): Deleted.
484         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp.
485         (-[SessionStateDelegate webView:didFinishNavigation:]):
486         (-[SessionStateDelegate _webView:backForwardListItemAdded:removed:]):
487         (TestWebKitAPI::createSessionStateData):
488         (TestWebKitAPI::TEST):
489         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
490         (TestWebKitAPI::didChangeBackForwardListForPage): Deleted.
491         (TestWebKitAPI::setPageLoaderClient): Deleted.
492         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp.
493         (-[BackForwardClient webView:didFinishNavigation:]):
494         (-[BackForwardClient _webView:willGoToBackForwardListItem:inPageCache:]):
495         (TestWebKitAPI::TEST):
496         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
497         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
498         (TestWebKitAPI::setPageLoaderClient): Deleted.
499
500 2018-08-27  Keith Miller  <keith_miller@apple.com>
501
502         test262-runner -s --test-only should replace test results
503         https://bugs.webkit.org/show_bug.cgi?id=188450
504
505         Reviewed by Michael Saboff.
506
507         * Scripts/test262/Runner.pm:
508         (main):
509         (SetFailureForTest):
510         (UpdateResults):
511
512 2018-08-26  Sam Weinig  <sam@webkit.org>
513
514         Using _WKRemoteObjectInterface with a protocol that inherits from a non-NSObject protocol crashes
515         https://bugs.webkit.org/show_bug.cgi?id=188958
516
517         Reviewed by Anders Carlsson.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
520         Update test protocol to have inheritance.
521
522 2018-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
523
524         [Attachment Support] Dropping and pasting images should insert inline image elements with _WKAttachments
525         https://bugs.webkit.org/show_bug.cgi?id=188933
526         <rdar://problem/43699724>
527
528         Reviewed by Darin Adler.
529
530         Rebaseline existing API tests that involve dropping or pasting image files, and additionally write some new
531         tests. These new tests exercise the following cases:
532         •       Inserting and removing newlines before an inline image with an attachment element does not cause new
533                 _WKAttachments to be created and destroyed.
534         •       Pasting an image, cutting it, and then pasting it again propagates an attachment update to the UI
535                 process with the original _WKAttachment.
536         •       A pasted attachment in the document can be moved around by dragging, and doing so does not cause us to
537                 lose a _WKAttachment.
538
539         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
540         (-[TestWKWebView expectElementCount:tagName:]):
541         (TestWebKitAPI::TEST):
542
543         Add the new tests described above, and also adjust existing tests to check that images are dropped or pasted
544         as image elements, but still have associated attachment elements whose attachment identifiers (observed via
545         script) match that of the corresponding _WKAttachment's uniqueIdentifier in the UI process.
546
547         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
548         (-[DragAndDropSimulator runFrom:to:]):
549         (-[DragAndDropSimulator continueDragSession]):
550         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
551
552         Teach DragAndDropSimulator on macOS to wait until the drop has been handled by the web process before returning
553         execution to the caller. This ensures that tests which involve dropping promised files as attachments aren't
554         flaky, due to how the promised data is retrieved asynchronously when performing the drop.
555
556         (-[DragAndDropSimulator _webView:didPerformDragOperation:]):
557
558 2018-08-26  Lucas Forschler  <lforschler@apple.com>
559
560         Open svn.webkit.org for commits.
561
562 2018-08-24  Myles C. Maxfield  <mmaxfield@apple.com>
563
564         Unreviewed test fix after r235249
565         https://bugs.webkit.org/show_bug.cgi?id=178981
566
567         * WebGPUShadingLanguageRI/Test.js:
568
569 2018-08-24  Alex Christensen  <achristensen@webkit.org>
570
571         Introduce _WKInspector
572         https://bugs.webkit.org/show_bug.cgi?id=188923
573         <rdar://problem/34657861>
574
575         Reviewed by Brian Burg.
576
577         * MiniBrowser/mac/WK2BrowserWindowController.m:
578         (-[WK2BrowserWindowController validateMenuItem:]):
579         (-[WK2BrowserWindowController showHideWebInspector:]):
580
581 2018-08-24  Jonathan Bedard  <jbedard@apple.com>
582
583         Fix handling of iOS minor versions in default_baseline_search_path
584         https://bugs.webkit.org/show_bug.cgi?id=188902
585
586         Reviewed by Aakash Jain.
587
588         * Scripts/webkitpy/port/ios.py:
589         (IOSPort.default_baseline_search_path): When the major version matches the major version of the CURRENT_VERSION, treat
590         it as a the CURRENT_VERSION.
591
592 2018-08-24  Antti Koivisto  <antti@apple.com>
593
594         Allow creating WeakPtrs to const objects
595         https://bugs.webkit.org/show_bug.cgi?id=188785
596
597         Reviewed by Geoff Garen.
598
599         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
600         (TestWebKitAPI::Base::weakPtrFactory const):
601         (TestWebKitAPI::TEST):
602         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
603
604 2018-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
605
606         [GTK][WPE] Add API to inject/register user content in isolated worlds
607         https://bugs.webkit.org/show_bug.cgi?id=188883
608
609         Reviewed by Michael Catanzaro.
610
611         Add test cases for the new API.
612
613         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
614         (isStyleSheetInjectedForURLAtPath):
615         (isScriptInjectedForURLAtPath):
616         (testUserContentManagerInjectedStyleSheet):
617         (testUserContentManagerInjectedScript):
618         (UserScriptMessageTest::registerHandler):
619         (UserScriptMessageTest::unregisterHandler):
620         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
621         (testUserContentManagerScriptMessageInWorldReceived):
622         (beforeAll):
623
624 2018-08-23  Simon Fraser  <simon.fraser@apple.com>
625
626         Add support for dumping GC heap snapshots, and a viewer
627         https://bugs.webkit.org/show_bug.cgi?id=186416
628
629         Reviewed by Joseph Pecoraro.
630
631         Add a viewer for GC heap snapshots. A snapshot JSON file can be dragged into this
632         page for inspection (or set via the 'filename' URL parameter).
633
634         For now, this page shows all objects, all roots, and the shortest path from a root
635         to all HTMLDocuments and Windows.
636
637         * GCHeapInspector/gc-heap-inspector.html: Added.
638         * GCHeapInspector/heap-analysis/HeapSnapshot.js: Copied from Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshot.js.
639         * GCHeapInspector/script/interface.js: Added.
640
641 2018-08-23  Alex Christensen  <achristensen@webkit.org>
642
643         Add new _webViewRequestPointerLock SPI with a completionHandler
644         https://bugs.webkit.org/show_bug.cgi?id=188907
645         <rdar://problem/35871109>
646
647         Reviewed by Andy Estes.
648
649         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
650         (-[PointerLockDelegate _webViewRequestPointerLock:completionHandler:]):
651         (-[PointerLockDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
652         (TEST):
653
654 2018-08-23  David Fenton  <david_fenton@apple.com>
655
656         Unreviewed, rolling out r235129.
657
658         broke internal builds
659
660         Reverted changeset:
661
662         "Allow creating WeakPtrs to const objects"
663         https://bugs.webkit.org/show_bug.cgi?id=188785
664         https://trac.webkit.org/changeset/235129
665
666 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
667
668         API tests should output json results
669         https://bugs.webkit.org/show_bug.cgi?id=188869
670         <rdar://problem/43615652>
671
672         Reviewed by Aakash Jain.
673
674         JSON output for API tests is of the form:
675             {
676                 "Failed": [{"name": <test name>, "output": <test log>}],
677                 "Timedout": [...],
678                 "Skipped": [...],
679                 "Crashed": [...]
680             }
681         Tests which are successful are not displayed in the json output.
682
683         * Scripts/webkitpy/api_tests/manager.py:
684         (Manager.run): Print test results to provided file as a json dictionary.
685         * Scripts/webkitpy/api_tests/run_api_tests.py:
686         (run): Pass json option.
687         (parse_args): Add --json-output flag.
688
689 2018-08-23  Andy Estes  <aestes@apple.com>
690
691         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
692         https://bugs.webkit.org/show_bug.cgi?id=188829
693
694         Reviewed by Tim Horton.
695
696         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
697
698 2018-08-23  Myles C. Maxfield  <mmaxfield@apple.com>
699
700         [WSL] Ternary expressions appear to be unimplemented
701         https://bugs.webkit.org/show_bug.cgi?id=178981
702
703         Reviewed by Saam Barati.
704
705         Implement ternary statements. These can be both lvalues and rvalues. (a ? b : c ? d : e)
706         is parsed as (a ? b : (c ? d : e)).
707
708         * WebGPUShadingLanguageRI/All.js:
709         * WebGPUShadingLanguageRI/Checker.js:
710         (Checker.prototype.visitTernaryExpression):
711         * WebGPUShadingLanguageRI/Evaluator.js:
712         (Evaluator.prototype.visitTernaryExpression):
713         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js:
714         (NormalUsePropertyResolver.prototype.visitTernaryExpression):
715         (NormalUsePropertyResolver):
716         * WebGPUShadingLanguageRI/Parse.js:
717         (parsePossibleTernaryConditional):
718         * WebGPUShadingLanguageRI/PropertyResolver.js:
719         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder.prototype.visitTernaryExpression):
720         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder):
721         (PropertyResolver.prototype._visitRValuesWithinLValue):
722         * WebGPUShadingLanguageRI/Rewriter.js:
723         (Rewriter.prototype.visitTernaryExpression):
724         * WebGPUShadingLanguageRI/SPIRV.html:
725         * WebGPUShadingLanguageRI/Test.html:
726         * WebGPUShadingLanguageRI/Test.js:
727         * WebGPUShadingLanguageRI/Visitor.js:
728         (Visitor.prototype.visitProtocolDecl):
729         * WebGPUShadingLanguageRI/index.html:
730
731 2018-08-22  Ryosuke Niwa  <rniwa@webkit.org>
732
733         Assert in NetworkBlobRegistry::unregisterBlobURL after network process had terminated
734         https://bugs.webkit.org/show_bug.cgi?id=188880
735
736         Reviewed by Saam Barati.
737
738         Fixed the bug that testRunner's terminateNetworkProcess, terminateServiceWorkerProcess, and terminateStorageProcess
739         were asynchronously terminating respective processes. Do so synchronously so that we can deterministically
740         test WebKit's behavior in layout tests.
741
742         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
743         (WTR::TestRunner::terminateNetworkProcess):
744         (WTR::TestRunner::terminateServiceWorkerProcess):
745         (WTR::TestRunner::terminateStorageProcess):
746         * WebKitTestRunner/TestInvocation.cpp:
747         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
748         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
749
750 2018-08-23  Myles C. Maxfield  <mmaxfield@apple.com>
751
752         [WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
753         https://bugs.webkit.org/show_bug.cgi?id=188773
754
755         Reviewed by Filip Pizlo.
756
757         Before this patch, it was impossible to represent "native typedef vector<float, 4>" because NativeTypes couldn't have
758         typeArguments.
759
760         Previously, the way to identify a type was strictly by name, which was represented by a string. Therefore, when something like
761         "vector<int, 3>" was parsed, it would produce a TypeRef with the name "vector" and typeArguments [TypeRef, IntLiteral]. Then,
762         there was a pass to convert the TypeRef to have the name "int3" and no typeArguments. After this transformation, each type could
763         be uniquely identified by name. That name was then matched to the string-only NativeType name.
764
765         This is okay for vectors and matrices, but it is unfortunate for textures (e.g. Texture2D<float4>) because they don't have any
766         natural string-only name. In addition, the canonicalization would have to be made aware of the fact that Texture2D<float4> is
767         the same as Texture2D<vector<float, 4>>. Similarly, an author may wish to typedef float4 to a different name.
768
769         It would be possible to mangle the names of the texture types to something unique, but then we lose information about the inner
770         type. For example, if we did this, Visitor wouldn't recurse into the float4 when encountering Texture2D<float4> because that
771         information would be lost. This could potentially make operations like programWithUnnecessaryThingsRemoved() more difficult to
772         implement in the future.
773
774         So, it would be better to have each type uniquely identified by (name, typeArguments). TypeRef will therefore also have
775         typeArguments which are used to determine which type it is referencing. After this analysis is done to determine what each
776         TypeRef is referencing, subsequent passes shouldn't care about the typeArguments and should only care about the .type field
777         which had been set - this was true even before this patch.
778
779         This means that NameContext has to aggregate types that accept typeArguments into arrays, where each array holds all the Types
780         that have the same name but different typeArguments. Then, when we need to match a TypeRef with a Type, we can ask the
781         NameContext for the appropriate array. This is the same way that function resolution works.
782
783         We can use Node.unify() to determine whether a TypeRef matches a NativeType. Eventually, this will go away, but for now, this is
784         an okay start. This works just about the same way that function overload resolution works. 
785
786         * WebGPUShadingLanguageRI/All.js:
787         * WebGPUShadingLanguageRI/CallExpression.js:
788         (CallExpression.prototype.resolve):
789         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Copied from Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js. After types
790         have been resolved, there should be no TypeRefs with name "vector" that don't have type arguments. This is just a sanity check.
791         (checkTypesWithArguments.TypeWithArgumentsChecker.prototype.visitTypeRef):
792         (checkTypesWithArguments.TypeWithArgumentsChecker):
793         (checkTypesWithArguments):
794         * WebGPUShadingLanguageRI/Checker.js:
795         (Checker.prototype.visitProgram): Program.types mirrors NameContext: it's a Map that maps strings to types. Because types with
796         typeArguments share names, this has to be updated to map strings to arrays for these types.
797         (Checker.prototype.visitTypeRef):
798         * WebGPUShadingLanguageRI/InferTypesForCall.js:
799         (inferTypesForCall): Don't know why this was here.
800         (inferTypesForTypeArguments): Same as inferTypesForCall, but this one is for matching type arguments.
801         * WebGPUShadingLanguageRI/Intrinsics.js: Adding the types. This patch also adds some scalar types like half, char, etc, but they
802         don't have any functions which accept them. Those will be tested in my next patch which adds math functions for these types. This
803         moves in the direction of matching the standard library in the spec.
804         (Intrinsics.cast):
805         (Intrinsics.bitwiseCast):
806         (Intrinsics.castToHalf):
807         (Intrinsics.):
808         (Intrinsics):
809         * WebGPUShadingLanguageRI/NameContext.js: Aggregate types with typeArguments into arrays.
810         (NameContext.prototype.add):
811         (NameContext.prototype.get let):
812         (NameContext.underlyingThings.prototype.else):
813         (NameContext.prototype.Symbol.iterator):
814         (NameContext):
815         * WebGPUShadingLanguageRI/NameResolver.js:
816         (NameResolver.prototype.visitTypeRef): Call TypeRef.resolve().
817         (NameResolver.prototype.visitCallExpression):
818         (NameResolver):
819         (NameResolver.prototype.visitVectorType): Deleted.
820         * WebGPUShadingLanguageRI/NativeType.js: NativeTypes can have type arguments now.
821         (NativeType):
822         (NativeType.prototype.get typeArguments):
823         (NativeType.prototype.toString):
824         (NativeType.create):
825         * WebGPUShadingLanguageRI/Prepare.js:
826         (let.prepare):
827         * WebGPUShadingLanguageRI/Program.js: Update to work with types aggregated into arrays.
828         (Program.prototype.add):
829         (Program.prototype.toString):
830         (Program):
831         * WebGPUShadingLanguageRI/RemoveTypeArguments.js: Removed.
832         * WebGPUShadingLanguageRI/ResolveNames.js: Update to work with types aggregated into arrays.
833         (resolveNamesInTypes):
834         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Resolve the type overload for types with typeArguments.
835         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Update to work with types aggregated into arrays.
836         (resolveTypeDefsInTypes):
837         * WebGPUShadingLanguageRI/Rewriter.js: TypeRefs and Native/Vector types can have typeArguments.
838         (Rewriter.prototype.visitTypeRef):
839         (Rewriter.prototype.visitVectorType):
840         (Rewriter):
841         * WebGPUShadingLanguageRI/SPIRV.html:
842         * WebGPUShadingLanguageRI/StandardLibrary.js: Matches Intrinsics.
843         (bool.operator):
844         * WebGPUShadingLanguageRI/StatementCloner.js: Native types can have typeArguments.
845         (StatementCloner.prototype.visitNativeType):
846         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Vector types need constructors too.
847         (synthesizeDefaultConstructorOperator.FindAllTypes.prototype.visitVectorType):
848         (synthesizeDefaultConstructorOperator.FindAllTypes):
849         (synthesizeDefaultConstructorOperator):
850         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: No reason to distinguish between wrapping and instantiating a TypeRef.
851         (synthesizeStructAccessors.createTypeRef):
852         * WebGPUShadingLanguageRI/Test.html:
853         * WebGPUShadingLanguageRI/Test.js:
854         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Copied from Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js.
855         (TypeOverloadResolutionFailure):
856         (TypeOverloadResolutionFailure.prototype.get type):
857         (TypeOverloadResolutionFailure.prototype.get reason):
858         (TypeOverloadResolutionFailure.prototype.toString):
859         * WebGPUShadingLanguageRI/TypeRef.js:
860         (TypeRef.wrap):
861         (TypeRef.prototype.resolve): Figure out which item in the possibleOverloads array matches this.
862         (TypeRef.prototype.toString):
863         (TypeRef):
864         (TypeRef.instantiate): Deleted.
865         * WebGPUShadingLanguageRI/UnificationContext.js: We need to give literals a chance to assume their preferred type. This
866         adds this facility back into the compiler (it was previously deleted).
867         (UnificationContext.prototype.verify):
868         * WebGPUShadingLanguageRI/VectorType.js: Vector types have type arguments.
869         (VectorType):
870         (VectorType.prototype.get elementType):
871         (VectorType.prototype.get numElements):
872         (VectorType.prototype.get numElementsValue):
873         (VectorType.prototype.toString):
874         * WebGPUShadingLanguageRI/Visitor.js: Iterate over the typeArguments.
875         (Visitor.prototype.visitTypeRef):
876         (Visitor.prototype.visitNativeType):
877         (Visitor.prototype.visitVectorType):
878         (Visitor):
879         * WebGPUShadingLanguageRI/index.html:
880
881 2018-08-23  Wenson Hsieh  <wenson_hsieh@apple.com>
882
883         [Attachment Support] Attachment elements don't appear in drag images on macOS
884         https://bugs.webkit.org/show_bug.cgi?id=188823
885         <rdar://problem/43616378>
886
887         Reviewed by Tim Horton.
888
889         Adjusts a couple of existing tests to additionally verify that the drag image generated when dragging an
890         attachment element in macOS is not completely transparent.
891
892         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
893         (isCompletelyTransparent):
894         (TestWebKitAPI::TEST):
895
896 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
897
898         Explain test name matching in run-api-tests help
899         https://bugs.webkit.org/show_bug.cgi?id=188280
900
901         Reviewed by Ryosuke Niwa.
902
903         Improve the run-api-tests help message to explain how test
904         name matching works.
905
906         * Scripts/webkitpy/api_tests/run_api_tests.py:
907         (parse_args):
908         * Scripts/webkitpy/port/base.py:
909         (Port):
910         (Port.path_to_api_test_binaries): Make binary names a globally accessible array.
911         * Scripts/webkitpy/port/win.py:
912         (WinPort):
913         (WinPort.path_to_api_test_binaries): Ditto.
914
915 2018-08-23  Youenn Fablet  <youenn@apple.com>
916
917         Use "wpt serve" to launch WPT server
918         https://bugs.webkit.org/show_bug.cgi?id=188848
919
920         Reviewed by Ryosuke Niwa.
921
922         Use "wpt serve" provided by WPT instead of using our custom launcher.
923         This simplifies things and will avoid future breakage.
924         Further simplify web_platform_test_server.py by removing no longer needed actions.
925         - Do not copy files but use alias
926         - Do not kill main pid, which leaves subprocesses alive, use interrupt instead.
927         - Stop enumerating subprocess pids.
928
929         * Scripts/webkitpy/common/system/executive_mock.py:
930         (MockExecutive.interrupt):
931         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Removed.
932         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
933         (WebPlatformTestServer.__init__):
934         (WebPlatformTestServer.ports_to_forward):
935         (WebPlatformTestServer._prepare_config):
936         (WebPlatformTestServer._spawn_process):
937         (WebPlatformTestServer._stop_running_server):
938
939 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
940
941         run-api-tests: Add --webkit-only, --webcore-only and --webkit-legacy-only options to run WebKit, WebCore and WebKitLegacy tests 
942         https://bugs.webkit.org/show_bug.cgi?id=188262
943
944         Reviewed by Ryosuke Niwa.
945
946         * Scripts/webkitpy/api_tests/run_api_tests.py:
947         (parse_args):
948
949 2018-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
950
951         [Attachment Support] Support dragging attachment elements out as files on macOS
952         https://bugs.webkit.org/show_bug.cgi?id=181294
953         <rdar://problem/36298801>
954
955         Reviewed by Tim Horton.
956
957         Add DragAndDropSimulator support for intercepting calls to -beginDraggingSessionWithitems:event:source:. This
958         enables us to write API tests for macOS that exercise the attachment SPI in combination with dragging attachment
959         elements.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
962         (-[TestWKWebView attachmentElementMidPoint]):
963
964         Add a helper method local to this test suite that grabs the midpoint (in client coordinates) or the first
965         attachment element in the document.
966
967         (TestWebKitAPI::TEST):
968
969         Add a new API test to verify that dragging an attachment element on macOS produces file providers which may be
970         used to write attachment data to a path on disk. Additionally, refactor an existing API test,
971         MoveAttachmentElementAsIconByDragging, so that it runs on both iOS and macOS, to test the ability to move
972         attachment elements around in a document by using drag and drop.
973
974         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
975         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
976         (-[DragAndDropTestWKWebView beginDraggingSessionWithItems:event:source:]):
977         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
978         (-[DragAndDropSimulator dealloc]):
979         (-[DragAndDropSimulator runFrom:to:]):
980         (-[DragAndDropSimulator beginDraggingSessionInWebView:withItems:source:]):
981
982         Begin a drag session and kick off the -continueDragSession loop. Unlike -performDragInWebView:…, which spins
983         the main runloop until dragging ends, this version returns execution to the web view and schedules dragging
984         updates asynchronously. This matches AppKit behavior.
985
986         (-[DragAndDropSimulator continueDragSession]):
987
988         Increment the dragging progress amount, send a drag update to the web view, and continue scheduling calls to
989         itself until the progress reaches 1.
990
991         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
992         (-[DragAndDropSimulator initializeDraggingInfo:dragImage:source:]):
993
994         Pull out common logic for creating a new TestDraggingInfo after starting a drag.
995
996         (-[DragAndDropSimulator insertedAttachments]):
997         (-[DragAndDropSimulator removedAttachments]):
998         (-[DragAndDropSimulator draggingSession]):
999         (-[DragAndDropSimulator receivePromisedFiles]):
1000
1001         Helper method to save promised files written to the pasteboard after a drag to the temporary directory. These
1002         files are tracked by DragAndDropSimulator and automatically cleaned up after the test finishes.
1003
1004         (-[DragAndDropSimulator endDataTransfer]):
1005
1006         Add a method stub on macOS, so that MoveAttachmentElementAsIconByDragging can be made cross-platform.
1007
1008         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
1009         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
1010
1011         Implement method stubs to keep track of inserted or removed attachments while simulating a drag.
1012
1013 2018-08-22  Aditya Keerthi  <akeerthi@apple.com>
1014
1015         [iOS] Add support for the inputmode attribute
1016         https://bugs.webkit.org/show_bug.cgi?id=183621
1017
1018         Reviewed by Tim Horton.
1019
1020         Added an API test to verify that the correct UIKeyboardType is set depending on
1021         the type, inputmode, and pattern specified for an input field.
1022
1023         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/ios/UIKitSPI.h:
1026
1027 2018-08-22  Alex Christensen  <achristensen@webkit.org>
1028
1029         Fix API test on Sierra after r235139
1030         https://bugs.webkit.org/show_bug.cgi?id=188810
1031
1032         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
1033         (TEST):
1034
1035 2018-08-22  David Kilzer  <ddkilzer@apple.com>
1036
1037         Move files in WebCore project to match Xcode folder structure
1038         <https://webkit.org/b/188851>
1039
1040         Reviewed by Tim Horton.
1041
1042         * Scripts/extract-localizable-strings:
1043         * Scripts/update-webkit-localizable-strings:
1044         - Update to match new location of extract-localizable-strings.pl.
1045
1046 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1047
1048         Roll out r235139 and r235146
1049         https://bugs.webkit.org/show_bug.cgi?id=188805
1050
1051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1052         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1053
1054 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1055
1056         [Attachment Support] Remove _WKAttachments and notify the UI client upon mainframe navigation
1057         https://bugs.webkit.org/show_bug.cgi?id=188715
1058         <rdar://problem/43541790>
1059
1060         Reviewed by Tim Horton.
1061
1062         Adds API tests to exercises cases where (1) the UI client is notified of attachment removal upon mainframe
1063         navigation, and (2) the UI client is notified of attachment removal upon web content process termination.
1064
1065         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1066         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
1067         (TestWebKitAPI::TEST):
1068
1069 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1070
1071         Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
1072         https://bugs.webkit.org/show_bug.cgi?id=188821
1073
1074         Reviewed by Simon Fraser.
1075
1076         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1077         (TestWebKitAPI::didLayout):
1078         (TestWebKitAPI::TEST):
1079
1080 2018-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
1081
1082         [WHLSL] Call expressions shouldn't have type arguments
1083         https://bugs.webkit.org/show_bug.cgi?id=188770
1084
1085         Reviewed by Filip Pizlo.
1086
1087         Call expressions only had type arguments for casts, becuase native types can have type arguments.
1088         However, instead of putting those type arguments on the CallExpression, we should parse the casted
1089         type as a real type and not as an identifier, which puts the type arguments in the TypeRef.
1090
1091         Test: casts
1092
1093         * WebGPUShadingLanguageRI/CallExpression.js:
1094         (CallExpression):
1095         (CallExpression.prototype.get name):
1096         (CallExpression.resolve):
1097         (CallExpression.prototype.get typeArguments): Deleted.
1098         (CallExpression.prototype.becomeCast): Deleted.
1099         * WebGPUShadingLanguageRI/NameResolver.js:
1100         (NameResolver.prototype.visitCallExpression):
1101         * WebGPUShadingLanguageRI/Parse.js:
1102         (parseConstexpr):
1103         (parseTypeDef):
1104         (parseLeftOperatorCall):
1105         (parseCallExpression.let.parseArguments):
1106         (parsePossiblePrefix):
1107         (parsePossibleRelationalEquality):
1108         (parseLeftLogicalExpression):
1109         (parseIfStatement):
1110         (parseWhile):
1111         (parseFor):
1112         (parseDo):
1113         * WebGPUShadingLanguageRI/RemoveTypeArguments.js:
1114         * WebGPUShadingLanguageRI/Rewriter.js:
1115         (Rewriter.prototype.visitCallExpression):
1116
1117 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1118
1119         Translate WebKit.LimitTitleSize API test into ObjC
1120         https://bugs.webkit.org/show_bug.cgi?id=188810
1121
1122         Reviewed by Andy Estes.
1123
1124         It uses WKPageLoaderClient.didReceiveTitleForFrame which has been replaced by KVO.
1125         I'm translating the test into ObjC rather than introducing a new callback to WKPageNavigationClient.
1126
1127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1128         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp: Removed.
1129         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
1130         (TEST):
1131         (-[LimitTitleSizeTestObserver observeValueForKeyPath:ofObject:change:context:]):
1132         (TestWebKitAPI::TEST): Deleted.
1133
1134 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1135
1136         Remove unused shouldKeepCurrentBackForwardListItemInList check
1137         https://bugs.webkit.org/show_bug.cgi?id=188805
1138
1139         Reviewed by Andy Estes.
1140
1141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
1143
1144 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1145
1146         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
1147         https://bugs.webkit.org/show_bug.cgi?id=188813
1148
1149         Reviewed by Andy Estes.
1150
1151         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1152         (TestWebKitAPI::didLayout):
1153         (TestWebKitAPI::setPageLoaderClient):
1154         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1155         (TestWebKitAPI::didFinishNavigation):
1156         (TestWebKitAPI::didLayout):
1157         (TestWebKitAPI::setPageLoaderClient):
1158         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1159         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1160         (TestWebKitAPI::didLayout):
1161         (TestWebKitAPI::setPageLoaderClient):
1162
1163 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1164
1165         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1166         https://bugs.webkit.org/show_bug.cgi?id=188496
1167         <rdar://problem/43216836>
1168
1169         Reviewed by Tim Horton.
1170
1171         Adjusts existing attachment API tests. See below for more detail.
1172
1173         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1174         (-[TestWKWebView synchronouslyInsertAttachmentWithFileWrapper:contentType:]):
1175         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
1176         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
1177         (-[_WKAttachment synchronouslySetFileWrapper:newContentType:error:]):
1178
1179         Move off of deprecated attachment SPI, and add new helper functions to synchronously insert a new attachment or
1180         update an existing attachment with a file wrapper.
1181
1182         (-[_WKAttachment expectRequestedDataToBe:]):
1183         (TestWebKitAPI::TEST):
1184
1185         Add a new test to verify that file-URL-backed NSFileWrappers can be used to insert and update attachment data.
1186         Also augment an existing test to check that an attachment element which has been copied and pasted within the
1187         same document has a different _WKAttachment wrapper object than its duplicate, but both _WKAttachments are
1188         backed by the same NSFileWrapper that was originally used to insert the attachment.
1189
1190         Additionally, add another macOS test to verify that dropping promised files in an attachment-element-enabled
1191         editable area inserts attachment elements into the document and notifies the UI client with the inserted
1192         attachment data.
1193
1194         (-[_WKAttachment synchronouslyRequestInfo:]): Deleted.
1195         (-[_WKAttachment synchronouslyRequestData:]): Deleted.
1196         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1197         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
1198
1199         Move off of -_webView:didInsertAttachment:.
1200
1201         (-[DragAndDropSimulator _webView:didInsertAttachment:]): Deleted.
1202
1203 2018-08-21  David Kilzer  <ddkilzer@apple.com>
1204
1205         sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name
1206         <https://webkit.org/b/188755>
1207
1208         Reviewed by Andy Estes.
1209
1210         * Scripts/sort-Xcode-project-file: Fix regular expression to
1211         make `mainGroup` name optional.
1212
1213 2018-08-21  Andy VanWagoner  <andy@vanwagoner.family>
1214
1215         Unreviewed, add myself to committers list.
1216
1217         * Scripts/webkitpy/common/config/contributors.json:
1218
1219 2018-08-21  Antti Koivisto  <antti@apple.com>
1220
1221         Allow creating WeakPtrs to const objects
1222         https://bugs.webkit.org/show_bug.cgi?id=188785
1223
1224         Reviewed by Geoffrey Garen.
1225
1226         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1227         (TestWebKitAPI::Base::weakPtrFactory const):
1228         (TestWebKitAPI::TEST):
1229         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
1230
1231 2018-08-21  Per Arne Vollan  <pvollan@apple.com>
1232
1233         [WebGL] Contexts are not updated when display configuration changed.
1234         https://bugs.webkit.org/show_bug.cgi?id=188750
1235
1236         Reviewed by Brent Fulgham.
1237
1238         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1240         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1242         * WebKitTestRunner/TestController.cpp:
1243         (WTR::TestController::sendDisplayConfigurationChangedMessageForTesting):
1244         * WebKitTestRunner/TestController.h:
1245         * WebKitTestRunner/TestInvocation.cpp:
1246         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1247
1248 2018-08-21  John Wilander  <wilander@apple.com>
1249
1250         Make ResourceLoadObserver::logWebSocketLoading() handle websockets in detached frames
1251         https://bugs.webkit.org/show_bug.cgi?id=188757
1252         <rdar://problem/38713390>
1253
1254         Reviewed by Alex Christensen.
1255
1256         These changes add the new WebKitTestRunner function
1257         isStatisticsRegisteredAsSubresourceUnder().
1258
1259         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1261         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1262         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1263         * WebKitTestRunner/TestController.cpp:
1264         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1265         * WebKitTestRunner/TestController.h:
1266         * WebKitTestRunner/TestInvocation.cpp:
1267         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1268
1269 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1270
1271         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
1272         https://bugs.webkit.org/show_bug.cgi?id=188797
1273
1274         Reviewed by Tim Horton.
1275
1276         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
1277         (TestWebKitAPI::didFinishNavigation):
1278         (TestWebKitAPI::TEST):
1279         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1280         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1281         (TestWebKitAPI::didSameDocumentNavigation):
1282         (TestWebKitAPI::TEST):
1283         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1284         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1285         (TestWebKitAPI::didFailProvisionalNavigation):
1286         (TestWebKitAPI::TEST):
1287         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
1288         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1289         (TestWebKitAPI::didStartProvisionalNavigation):
1290         (TestWebKitAPI::didCommitNavigation):
1291         (TestWebKitAPI::didFinishNavigation):
1292         (TestWebKitAPI::TEST):
1293         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1294         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1295         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1296         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1297         (TestWebKitAPI::didStartProvisionalNavigation):
1298         (TestWebKitAPI::didCommitNavigation):
1299         (TestWebKitAPI::didFinishNavigation):
1300         (TestWebKitAPI::TEST):
1301         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1302         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1303         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1304         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1305         (TestWebKitAPI::renderingProgressDidChange):
1306         (TestWebKitAPI::TEST):
1307         (TestWebKitAPI::didLayout): Deleted.
1308         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1309         (TestWebKitAPI::didFinishNavigation):
1310         (TestWebKitAPI::renderingProgressDidChange):
1311         (TestWebKitAPI::setPageLoaderClient):
1312         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1313         (TestWebKitAPI::didLayout): Deleted.
1314         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1315         (TestWebKitAPI::State::State):
1316         (TestWebKitAPI::didStartProvisionalNavigation):
1317         (TestWebKitAPI::didCommitNavigation):
1318         (TestWebKitAPI::didFinishNavigation):
1319         (TestWebKitAPI::decidePolicyForNavigationAction):
1320         (TestWebKitAPI::decidePolicyForResponse):
1321         (TestWebKitAPI::TEST):
1322         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1323         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1324         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1325         (TestWebKitAPI::decidePolicyForNewWindowAction): Deleted.
1326         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1327         (TestWebKitAPI::didSameDocumentNavigation):
1328         (TestWebKitAPI::TEST):
1329         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1330         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1331         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1332         (TestWebKitAPI::TEST):
1333         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1334         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1335         (TestWebKitAPI::didFinishLoad):
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp:
1338         (TestWebKitAPI::didFinishNavigation):
1339         (TestWebKitAPI::TEST):
1340         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1341         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1342         (TestWebKitAPI::didFinishLoad):
1343         (TestWebKitAPI::TEST):
1344         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1345         (WebKit2_CommandBackForwardTestWKView::SetUp):
1346         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame): Deleted.
1347
1348 2018-08-20  Alex Christensen  <achristensen@webkit.org>
1349
1350         Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
1351         https://bugs.webkit.org/show_bug.cgi?id=188771
1352
1353         Reviewed by Tim Horton.
1354
1355         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1356         (TestWebKitAPI::didFinishNavigation):
1357         (TestWebKitAPI::TEST):
1358         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1359         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1360         (TestWebKitAPI::didFinishNavigation):
1361         (TestWebKitAPI::TEST):
1362         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1363         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1364         (TestWebKitAPI::didFinishNavigation):
1365         (TestWebKitAPI::setPageLoaderClient):
1366         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1367         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1368         (TestWebKitAPI::TEST):
1369         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1370         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
1371         (TestWebKitAPI::didFinishNavigation):
1372         (TestWebKitAPI::setPageLoaderClient):
1373         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1374         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1375         (TestWebKitAPI::didFinishNavigation):
1376         (TestWebKitAPI::setClients):
1377         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1378         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1379         (TestWebKitAPI::didFinishNavigation):
1380         (TestWebKitAPI::TEST):
1381         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1382         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1383         (TestWebKitAPI::didFinishNavigation):
1384         (TestWebKitAPI::TEST):
1385         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1386         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1387         (TestWebKitAPI::didFinishNavigation):
1388         (TestWebKitAPI::TEST):
1389         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1390         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1391         (TestWebKitAPI::didFinishNavigation):
1392         (TestWebKitAPI::TEST):
1393         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1394         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1395         (TestWebKitAPI::didFinishNavigation):
1396         (TestWebKitAPI::TEST):
1397         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1398         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1399         (TestWebKitAPI::didFinishNavigation):
1400         (TestWebKitAPI::setPageLoaderClient):
1401         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1402         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1403         (TestWebKitAPI::didFinishNavigation):
1404         (TestWebKitAPI::TEST):
1405         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1406         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp:
1407         (TestWebKitAPI::didFinishLoadForFrame):
1408         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1409         (TestWebKitAPI::didFinishNavigation):
1410         (TestWebKitAPI::loadAlternateHTMLString):
1411         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1412         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1413         (TestWebKitAPI::didFinishNavigation):
1414         (TestWebKitAPI::TEST):
1415         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1416         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1417         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1418         (TestWebKitAPI::didFinishLoad):
1419         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1420         (TestWebKitAPI::didFinishNavigation):
1421         (TestWebKitAPI::setPageLoaderClient):
1422         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1423         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1424         (TestWebKitAPI::didFinishNavigation):
1425         (TestWebKitAPI::setPageLoaderClient):
1426         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1427         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1428         (TestWebKitAPI::didFinishLoadForFrame):
1429         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1430         (TestWebKitAPI::TEST):
1431         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1432         (TestWebKitAPI::TEST):
1433         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1434         (TestWebKitAPI::didFinishLoad):
1435         (TestWebKitAPI::TEST):
1436         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1437         (TestWebKitAPI::didFinishNavigation):
1438         (TestWebKitAPI::setPageLoaderClient):
1439         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1440         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1441         (TestWebKitAPI::didFinishNavigation):
1442         (TestWebKitAPI::setPageLoaderClient):
1443         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1444         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1445         (TestWebKitAPI::didFinishNavigation):
1446         (TestWebKitAPI::TEST):
1447         (TestWebKitAPI::didFinishDocumentLoadForFrame): Deleted.
1448         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1449         (TestWebKitAPI::didFinishNavigation):
1450         (TestWebKitAPI::TEST):
1451         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1452         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1453         (TestWebKitAPI::didFailProvisionalNavigation):
1454         (TestWebKitAPI::TEST):
1455         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
1456         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1457         (TestWebKitAPI::didFinishNavigation):
1458         (TestWebKitAPI::TEST):
1459         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1460         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1461         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishNavigation):
1462         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1463         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame): Deleted.
1464         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1465         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishNavigation):
1466         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1467         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame): Deleted.
1468         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
1469         (TestWebKitAPI::didFinishNavigation):
1470         (TestWebKitAPI::setPageLoaderClient):
1471         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1472         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1473         (TestWebKitAPI::didFinishNavigation):
1474         (TestWebKitAPI::setPageLoaderClient):
1475         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1476         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1477         (TestWebKitAPI::didFinishNavigation):
1478         (TestWebKitAPI::setPageLoaderClient):
1479         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1480         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1481         (TestWebKitAPI::didFinishNavigation):
1482         (TestWebKitAPI::setUpClients):
1483         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1484         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1485         (TestWebKitAPI::didFinishNavigation):
1486         (TestWebKitAPI::setPageLoaderClient):
1487         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1488         * TestWebKitAPI/Tests/WebKit/WebArchive.cpp:
1489         (TestWebKitAPI::didFinishNavigation):
1490         (TestWebKitAPI::TEST):
1491         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1492         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1493         (TestWebKitAPI::didFinishNavigation):
1494         (TestWebKitAPI::TEST):
1495         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1496         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1497         (TestWebKitAPI::didFinishNavigation):
1498         (TestWebKitAPI::TEST):
1499         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1500         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1501         (TestWebKitAPI::didFinishNavigation):
1502         (TestWebKitAPI::TEST):
1503         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1504         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1505         (TestWebKitAPI::didFinishNavigation):
1506         (TestWebKitAPI::TEST):
1507         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1508         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1509         (TestWebKitAPI::didFinishNavigation):
1510         (TestWebKitAPI::TEST):
1511         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1512         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1513         (TestWebKitAPI::didFinishNavigation):
1514         (TestWebKitAPI::TEST):
1515         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1516         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1517         (didFinishNavigation):
1518         (TestWebKitAPI::TEST):
1519         (didFinishLoadForFrame): Deleted.
1520         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1521         (didFinishNavigation):
1522         (TestWebKitAPI::TEST):
1523         (didFinishLoadForFrame): Deleted.
1524         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1525         (TestWebKitAPI::didFinishNavigation):
1526         (TestWebKitAPI::TEST):
1527         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1528         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1529         (TestWebKitAPI::didFinishNavigation):
1530         (TestWebKitAPI::setPageLoaderClient):
1531         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1532
1533 2018-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1534
1535         [WPE] Update to use libwpe-1.0.0 and WPEBackend-fdo-1.0.0
1536         https://bugs.webkit.org/show_bug.cgi?id=188782
1537
1538         Reviewed by Michael Catanzaro.
1539
1540         Make the build depend on wpe-0.2, and change the Flatpak and JHBuild development
1541         environments to use version 1.0.0 of libwpe and WPEBackend-fdo.
1542
1543         * flatpak/org.webkit.WPE.yaml: Update to use libwpe and WPEBackend-fdo version 1.0.0 from
1544         release tarballs, and removed the (now unneeded) Lua and LuaJIT modules.
1545         * wpe/jhbuild.modules: Ditto.
1546
1547 2018-08-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1548
1549         [Flatpak] Update to GNOME master runtime
1550         https://bugs.webkit.org/show_bug.cgi?id=188731
1551
1552         Reviewed by Philippe Normand.
1553
1554         The 3.28 runtime is pretty stale at this point. We could wait a couple weeks for the 3.30
1555         runtime, but I don't think there's any need to stick with the stable runtime when we have
1556         the ability to pin to a particular version of the master runtime. There are also several
1557         advantages to switching to the master runtime.
1558
1559         * flatpak/files/httpd-autogen.sh: Removed.
1560         * flatpak/flatpakutils.py:
1561         (WebkitFlatpak.clean_args):
1562         * flatpak/org.webkit.GTK.yaml:
1563         * flatpak/org.webkit.WebKit.yaml:
1564         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1565         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1566
1567 2018-08-20  Jonathan Bedard  <jbedard@apple.com>
1568
1569         WebKitTestRunner: Add watchOS entitlements
1570         https://bugs.webkit.org/show_bug.cgi?id=188758
1571
1572         Reviewed by Tim Horton.
1573
1574         watchOS needs an additional entitlement to open up a socket for on-device testing.
1575
1576         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements: Added.
1577         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1578         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1579
1580 2018-08-20  Thomas Denney  <tdenney@apple.com>
1581
1582         [WHLSL] Remove generics from the interpreter
1583         https://bugs.webkit.org/show_bug.cgi?id=187988
1584
1585         Reviewed by Myles C. Maxfield.
1586
1587         This patch completely removes generic and protocol support from WHLSL
1588         whilst adding back any features that were originally implemented with
1589         generics.
1590
1591         Many of the changes in this patch just remove occurrences of type
1592         arguments and type parameters --- although there are some cases where
1593         they have been deliberately left in --- as well as removing tests only
1594         relevant to those features. These changes are not listed below.
1595
1596         * WebGPUShadingLanguageRI/All.js: Add/remove JS dependencies
1597         * WebGPUShadingLanguageRI/AutoWrapper.js:
1598         (AutoWrapper.prototype.visitConstexprTypeParameter): Deleted.
1599         * WebGPUShadingLanguageRI/BuiltinVectorCasts.js: Added. The built-in
1600         vectors have many constructors for different scalar and vector types.
1601         These were originally implemented with generics.
1602         * WebGPUShadingLanguageRI/BuiltinVectorEqualityOperator.js: Adds the
1603         equality operator for built-in vectors, again this was removed with
1604         generics.
1605         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Added, as above.
1606         Built-in vectors only support the getter and setter, and not the ander.
1607         * WebGPUShadingLanguageRI/BuiltinVectorIndexGetter.js: Added.
1608         * WebGPUShadingLanguageRI/BuiltinVectorIndexSetter.js: Added.
1609         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Added.
1610         * WebGPUShadingLanguageRI/CallExpression.js: Adds support for
1611         instantiating functions which cannot be discovered earlier in
1612         preparation because their types are absent (specifically support for the
1613         operator &[] for array references and the length operator for array
1614         references). Previously support for these was implemented with generics.
1615         (CallExpression.resolve):
1616         (CallExpression.prototype.resolve):
1617         (CallExpression.prototype._resolveByInstantiation):
1618         (CallExpression.prototype._resolveToOperatorAnderIndexer):
1619         (CallExpression.prototype._resolveToOperatorLength):
1620         (CallExpression.prototype.resolveToOverload):
1621         (CallExpression.prototype.becomeCast):
1622         (CallExpression.prototype.toString):
1623         (CallExpression):
1624         * WebGPUShadingLanguageRI/CallExpressionTypeArgumentResolver.js: Added.
1625         We support syntax like vector<int, 2>(a, b) for constructing vectors;
1626         this new preparation step resolves them to specific constructors.
1627         * WebGPUShadingLanguageRI/CallFunction.js:
1628         * WebGPUShadingLanguageRI/Checker.js:
1629         * WebGPUShadingLanguageRI/ConstexprFolder.js:
1630         * WebGPUShadingLanguageRI/CreateLiteralType.js:
1631         * WebGPUShadingLanguageRI/ExpressionFinder.js:
1632         * WebGPUShadingLanguageRI/FlattenProtocolExtends.js: Removed.
1633         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
1634         * WebGPUShadingLanguageRI/Func.js:
1635         * WebGPUShadingLanguageRI/FuncDef.js:
1636         * WebGPUShadingLanguageRI/FuncInstantiator.js: Deleted.
1637         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed usage of type arguments.
1638         * WebGPUShadingLanguageRI/Inline.js: Remove use of FuncInstantiator.
1639         * WebGPUShadingLanguageRI/Inliner.js: Ditto.
1640         * WebGPUShadingLanguageRI/Intrinsics.js:
1641         * WebGPUShadingLanguageRI/Lexer.js:
1642         * WebGPUShadingLanguageRI/LiteralTypeChecker.js:
1643         * WebGPUShadingLanguageRI/NameContext.js:
1644         (NameContext.prototype.add):
1645         (NameContext.prototype.get let):
1646         (NameContext.underlyingThings.prototype.else):
1647         (NameContext.prototype.resolveFuncOverload):
1648         * WebGPUShadingLanguageRI/NameFinder.js:
1649         * WebGPUShadingLanguageRI/NameResolver.js:
1650         (NameResolver.prototype.visitFunc):
1651         (NameResolver.prototype.visitFuncDef):
1652         (NameResolver.prototype.visitTypeDef):
1653         (NameResolver.prototype.visitStructType):
1654         (NameResolver.prototype.visitTypeRef):
1655         (NameResolver.prototype.visitCallExpression):
1656         (NameResolver.prototype.visitVectorType):
1657         (NameResolver):
1658         (NameResolver.prototype._visitTypeParametersAndBuildNameContext): Deleted.
1659         (NameResolver.prototype.visitProtocolDecl): Deleted.
1660         * WebGPUShadingLanguageRI/NativeFunc.js:
1661         (NativeFunc):
1662         * WebGPUShadingLanguageRI/NativeFuncInstance.js: Deleted.
1663         * WebGPUShadingLanguageRI/NativeType.js:
1664         (NativeType):
1665         (NativeType.prototype.get name):
1666         (NativeType.prototype.toString):
1667         (NativeType.prototype.get typeParameters): Deleted.
1668         (NativeType.prototype.instantiate): Deleted.
1669         * WebGPUShadingLanguageRI/Node.js:
1670         (Node.prototype.commit):
1671         (Node):
1672         (Node.prototype.substitute): Deleted.
1673         (Node.prototype.substituteToUnification): Deleted.
1674         * WebGPUShadingLanguageRI/OperatorAnderIndex.js: Added, previously
1675         implemented with generics.
1676         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Ditto.
1677         * WebGPUShadingLanguageRI/OperatorBool.js: Ditto.
1678         * WebGPUShadingLanguageRI/Parse.js: Removed everything related to
1679         generics and protocols.
1680         * WebGPUShadingLanguageRI/Prepare.js: Added new stages.
1681         * WebGPUShadingLanguageRI/Program.js:
1682         (Program):
1683         (Program.prototype.get types):
1684         (Program.prototype.add):
1685         (Program.prototype.get protocols): Deleted.
1686         * WebGPUShadingLanguageRI/ProtocolDecl.js: Removed.
1687         * WebGPUShadingLanguageRI/ProtocolRef.js: Removed.
1688         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js:
1689         * WebGPUShadingLanguageRI/ResolveCallExpressionsWithTypeArguments.js: Added.
1690         * WebGPUShadingLanguageRI/ResolveNames.js:
1691         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
1692         * WebGPUShadingLanguageRI/ResolveTypeDefs.js:
1693         (resolveTypeDefsInProtocols): Deleted.
1694         * WebGPUShadingLanguageRI/Rewriter.js: Changes for new classes.
1695         * WebGPUShadingLanguageRI/SPIRV.html:
1696         * WebGPUShadingLanguageRI/SPIRVCodegen.js:
1697         * WebGPUShadingLanguageRI/StandardLibrary.js: Replace old generic features.
1698         * WebGPUShadingLanguageRI/StatementCloner.js: Changes for new classes.
1699         (StructLayoutBuilder):
1700         * WebGPUShadingLanguageRI/StructType.js:
1701         * WebGPUShadingLanguageRI/SwizzleOp.js:
1702         (SwizzleOp):
1703         (SwizzleOp.prototype.get baseTypeName):
1704         (SwizzleOp.prototype.toString):
1705         (SwizzleOp.functions.):
1706         (SwizzleOp.functions):
1707         (SwizzleOp.prototype.instantiateImplementation):
1708         (SwizzleOp.allSwizzleOperators.): Deleted.
1709         (SwizzleOp.allSwizzleOperators): Deleted.
1710         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Added,
1711         previously implemented with generics.
1712         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Ditto.
1713         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Ditto.
1714         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Ditto.
1715         * WebGPUShadingLanguageRI/SynthesizeOperatorBool.js: Ditto.
1716         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1717         (synthesizeStructAccessors.setupImplementationData):
1718         (synthesizeStructAccessors.createFieldType):
1719         (synthesizeStructAccessors.createTypeRef):
1720         (synthesizeStructAccessors.setupAnder):
1721         (synthesizeStructAccessors):
1722         (synthesizeStructAccessors.createTypeParameters): Deleted.
1723         (synthesizeStructAccessors.): Deleted.
1724         * WebGPUShadingLanguageRI/Test.html:
1725         * WebGPUShadingLanguageRI/Test.js: Removed redundant tests and added new
1726         tests for changed language features.
1727         * WebGPUShadingLanguageRI/Type.js:
1728         * WebGPUShadingLanguageRI/TypeDef.js:
1729         * WebGPUShadingLanguageRI/TypeDefResolver.js:
1730         * WebGPUShadingLanguageRI/TypeParameterRewriter.js: Removed.
1731         * WebGPUShadingLanguageRI/TypeRef.js:
1732         * WebGPUShadingLanguageRI/TypeVariable.js: Removed.
1733         * WebGPUShadingLanguageRI/UnificationContext.js:
1734         * WebGPUShadingLanguageRI/VectorType.js: Added.
1735         * WebGPUShadingLanguageRI/Visitor.js: Changes for new classes.
1736         * WebGPUShadingLanguageRI/WSL.md: Removed description of
1737         generics/protocols.
1738         * WebGPUShadingLanguageRI/WrapChecker.js:
1739         (WrapChecker):
1740         (WrapChecker.visitConstexprTypeParameter): Deleted.
1741         (WrapChecker.prototype.visitFuncParameter): Deleted.
1742         (WrapChecker.prototype.visitTypeVariable): Deleted.
1743         * WebGPUShadingLanguageRI/index.html:
1744
1745 2018-08-20  Thomas Denney  <tdenney@apple.com>
1746
1747         Added Thomas Denney to contributors.json.
1748         https://bugs.webkit.org/show_bug.cgi?id=188525
1749
1750         Reviewed by Myles C. Maxfield.
1751
1752         * Scripts/webkitpy/common/config/contributors.json:
1753
1754 2018-08-20  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1755
1756         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1757         https://bugs.webkit.org/show_bug.cgi?id=188738
1758
1759         Reviewed by Michael Catanzaro.
1760
1761         * glib/generate-inspector-gresource-manifest.py:
1762         (get_filenames): sort list of input files
1763
1764 2018-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1765
1766         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
1767         https://bugs.webkit.org/show_bug.cgi?id=184271
1768         <rdar://problem/39256708>
1769
1770         Reviewed by Andy Estes.
1771
1772         This API test is failing when run against older macOS builds, where custom pasteboard
1773         data is not enabled by default.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1776         (TestWebKitAPI::TEST):
1777
1778 2018-08-20  Claudio Saavedra  <csaavedra@igalia.com>
1779
1780         Add WPE Debug configuration to the flakiness dashboard
1781         https://bugs.webkit.org/show_bug.cgi?id=188743
1782
1783         Reviewed by Michael Catanzaro.
1784
1785         * TestResultServer/static-dashboards/builders.jsonp:
1786         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1787
1788 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1789
1790         [GLIB] Add API to throw exceptions using printf formatted strings
1791         https://bugs.webkit.org/show_bug.cgi?id=188698
1792
1793         Reviewed by Michael Catanzaro.
1794
1795         Add cases to test the new API.
1796
1797         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1798         (createFormattedError):
1799         (createCustomFormattedError):
1800         (testJSCExceptions):
1801
1802 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         [GLIB] Complete the JSCException API
1805         https://bugs.webkit.org/show_bug.cgi?id=188695
1806
1807         Reviewed by Michael Catanzaro.
1808
1809         Add cases to test the new API.
1810
1811         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1812         (testJSCCheckSyntax):
1813         (createCustomError):
1814         (testJSCExceptions):
1815
1816 2018-08-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1817
1818         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
1819         https://bugs.webkit.org/show_bug.cgi?id=184271
1820         <rdar://problem/39256708>
1821
1822         Reviewed by Ryosuke Niwa.
1823
1824         Add a new API test to verify that on both iOS and macOS, copied custom pasteboard data can only be pasted in a
1825         matching origin. Additionally verify that on iOS, the web view is capable of performing the "paste:" selector.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1828         (TestWebKitAPI::TEST):
1829         (imagePath): Deleted.
1830         (writeTypesAndDataToPasteboard): Deleted.
1831         (setUpWebView): Deleted.
1832         (markupString): Deleted.
1833
1834         Make this test file no longer exclusive to macOS.
1835
1836         * TestWebKitAPI/cocoa/TestWKWebView.h:
1837         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1838         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]):
1839
1840         Tweak this helper to also take in a `baseURL`. Defaults to using the TestWebKitAPI bundle resource URL.
1841
1842         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1843
1844 2018-08-17  Jonathan Bedard  <jbedard@apple.com>
1845
1846         Add back --wtf-only to run-api-tests
1847         https://bugs.webkit.org/show_bug.cgi?id=187893
1848         <rdar://problem/42483983>
1849
1850         Reviewed by Aakash Jain.
1851
1852         When doing WTF development, it is not necessary to build or run all of the API
1853         tests. Generally, if a user has specified a specific binary (or binaries) that
1854         they are interested in testing, it is not necessary to check all API test binaries.
1855
1856         * Scripts/webkitpy/api_tests/manager.py:
1857         (Manager._collect_tests): Only use the binaries matching the program arguments
1858         when collecting tests.
1859         (Manager._binaries_for_arguments): Generate a list of binaries which match the
1860         program arguments.
1861         (Manager.run): Pass a list binaries to check.
1862         * Scripts/webkitpy/api_tests/run_api_tests.py:
1863         (parse_args):
1864         * Scripts/webkitpy/port/base.py:
1865         (Port.check_api_test_build): If the caller specifies which API test binaries it
1866         requires, only check the ones specified.
1867         (Port.path_to_api_test_binaries): Allow the caller to only build the WTF API tests.
1868         (Port._build_api_tests): Allow the caller to only build the WTF API tests.
1869         * Scripts/webkitpy/port/win.py:
1870         (WinPort.path_to_api_test_binaries):
1871
1872 2018-08-17  Jer Noble  <jer.noble@apple.com>
1873
1874         REGRESSION (234743) Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio
1875         https://bugs.webkit.org/show_bug.cgi?id=188470
1876         <rdar://problem/43144969>
1877
1878         Reviewed by Alex Christensen.
1879
1880         On a loaded server, the WebContent process may send the "playing" message before the
1881         UIProcess has a chance to register a listener for that message. Restructure the tests
1882         so that the listener is registered before the page is loaded.
1883
1884         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1885         (PreferredAudioBufferSize::runPlayingTestWithPageNamed):
1886         (TEST_F):
1887
1888 2018-08-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1889
1890         [macOS] [WK2] Add infrastructure to test receiving file promises on drop
1891         https://bugs.webkit.org/show_bug.cgi?id=188583
1892
1893         Reviewed by Andy Estes.
1894
1895         Enable testing file promise drop handling on the WebKit2 port of macOS by introducing a subclass of
1896         NSFilePromiseReceiver and implementing `-enumerateDraggingItemsWithOptions:forView:…` on TestDraggingInfo (the
1897         concrete NSDraggingInfo implementation used by DragAndDropSimulator) using the mock file receiver. Also
1898         introduces 3 new macOS tests. See below for more details.
1899
1900         A large portion of this logic is ported over from DumpRenderTree testing infrastructure added in r229297. In a
1901         future patch, we should introduce a way to write code common to both API tests, WebKitTestRunner and
1902         DumpRenderTree, and make this code shared among all three testing harnesses.
1903
1904         Tests:  DragAndDropTests.DragImageElementIntoFileUpload
1905                 DragAndDropTests.DragPromisedImageFileIntoFileUpload
1906                 DragAndDropTests.DragImageFileIntoFileUpload
1907
1908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1909         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1910         (TEST):
1911
1912         Drive-by fix: Replace NSMakePoint with CGPointMake.
1913
1914         * TestWebKitAPI/Tests/WebKitCocoa/image-and-file-upload.html:
1915
1916         Add a new test page consisting of an image and a "file upload" area that updates exercises DataTransfer API to
1917         load the dropped image.
1918
1919         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1920         (waitForConditionWithLogging):
1921
1922         Add a helper function to wait for a condition to evaluate to true. To make failures more informative,
1923         additionally add a mechanism to log a warning message after a given timeout, if the condition has yet to be met.
1924
1925         (TEST):
1926
1927         Add new tests to exercise a few cases of file upload in WebKit, including: (1) dragging from an image element,
1928         (2) dragging files written to the pasteboard as promises, and (3) files written to the pasteboard as file URLs.
1929
1930         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1931
1932         Surface the new functionality provided by the file promise receiver mock via two new methods on
1933         DragAndDropSimulator to (1) write files as file promises to the pasteboard, and (2) write files as file paths
1934         directly to the pasteboard.
1935
1936         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1937         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
1938         (-[DragAndDropSimulator externalPromisedFiles]):
1939         (getFilePathsAndTypeIdentifiers):
1940         (-[DragAndDropSimulator writePromisedFiles:]):
1941         (-[DragAndDropSimulator writeFiles:]):
1942         * TestWebKitAPI/mac/TestDraggingInfo.h:
1943         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1944         (-[TestDraggingInfo initWithDragAndDropSimulator:]):
1945         (-[TestDraggingInfo filePromiseReceivers]):
1946         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1947
1948         Implement this by invoking the given block with a TestFilePromiseReceiver. While all other classes are
1949         unhandled by this testing code, WebKit only calls into this with [NSFilePromiseReceiver class], this is
1950         currently sufficient for testing purposes.
1951
1952         * TestWebKitAPI/mac/TestFilePromiseReceiver.h: Copied from Tools/TestWebKitAPI/mac/TestDraggingInfo.h.
1953         * TestWebKitAPI/mac/TestFilePromiseReceiver.mm: Added.
1954         (-[TestFilePromiseReceiver initWithPromisedTypeIdentifiers:dragAndDropSimulator:]):
1955         (-[TestFilePromiseReceiver fileTypes]):
1956         (-[TestFilePromiseReceiver fileNames]):
1957         (-[TestFilePromiseReceiver dealloc]):
1958         (-[TestFilePromiseReceiver draggingSource]):
1959         (-[TestFilePromiseReceiver setDraggingSource:]):
1960         (fileNameWithNumericSuffix):
1961         (copyFile):
1962
1963         Add a helper to copy a file into a destination directory. Used to implement the main functionality of our
1964         NSFilePromiseReceiver subclass, which copies the files specified by test code into the directory determined by
1965         WebKit.
1966
1967         (-[TestFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
1968
1969 2018-08-16  Alex Christensen  <achristensen@webkit.org>
1970
1971         Add entitlement to MiniBrowser to allow it to communicate with com.apple.Safari.SafeBrowsing.Service
1972         https://bugs.webkit.org/show_bug.cgi?id=188677
1973
1974         Reviewed by Tim Horton.
1975
1976         * MiniBrowser/MiniBrowser.entitlements:
1977         SSBLookupContext lookUpURL:completionHandler: fails to communicate with its service without this entitlement
1978         on released operating systems.  See <rdar://problem/42749777>
1979
1980 2018-08-16  Jer Noble  <jer.noble@apple.com>
1981
1982         Add option to run-api-tests to force running of DISABLED tests.
1983         https://bugs.webkit.org/show_bug.cgi?id=188674
1984
1985         Reviewed by Joseph Pecoraro.
1986
1987         * Scripts/webkitpy/api_tests/run_api_tests.py:
1988         (parse_args):
1989         * Scripts/webkitpy/api_tests/runner.py:
1990         (Runner.command_for_port):
1991         (_Worker._run_single_test):
1992
1993 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
1994
1995         [ews-build] Separate queues for Builders and Testers - macOS High Sierra
1996         https://bugs.webkit.org/show_bug.cgi?id=188540
1997
1998         Reviewed by Lucas Forschler.
1999
2000         * BuildSlaveSupport/ews-build/config.json: Splitted few macOS queues into builders and testers. 
2001
2002 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
2003
2004         [ews-build] Add build steps ArchiveTestResults, UploadTestResults and ExtractTestResults
2005         https://bugs.webkit.org/show_bug.cgi?id=188666
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * BuildSlaveSupport/ews-build/steps.py:
2010         (ArchiveTestResults): Build step to Archive the test results.
2011         (UploadTestResults): Build step to upload the archive.
2012         (ExtractTestResults): Build step to unzip the archive on server and generate a link.
2013         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2014         (ExpectMasterShellCommand): Copied from other similar internal code.
2015
2016 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
2017
2018         [ews-build] Separate queues for Builders and Testers - macOS Sierra
2019         https://bugs.webkit.org/show_bug.cgi?id=188516
2020
2021         Reviewed by Lucas Forschler.
2022
2023         * BuildSlaveSupport/ews-build/config.json: Splitted macOS Sierra Release queues into builders and testers.
2024         * BuildSlaveSupport/ews-build/factories.py: Used appropriate base classes for builders and testers.
2025
2026 2018-08-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2027
2028         [Win][DumpRenderTree] Remove error message for duplicated tests.
2029         https://bugs.webkit.org/show_bug.cgi?id=188662
2030
2031         Reviewed by Per Arne Vollan.
2032
2033         This was added to track down an issue where the same tests appeared
2034         to be run multiple times. This turned out to not be the case.
2035         See https://bugs.webkit.org/show_bug.cgi?id=166760 .
2036
2037         * DumpRenderTree/win/DumpRenderTree.cpp:
2038         (runTest):
2039
2040 2018-08-16  Alex Christensen  <achristensen@webkit.org>
2041
2042         Re-introduce assertion removed in r234890
2043         https://bugs.webkit.org/show_bug.cgi?id=188611
2044
2045         Reviewed by Geoffrey Garen.
2046
2047         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2048         (TestWebKitAPI::TEST):
2049
2050 2018-08-16  Jer Noble  <jer.noble@apple.com>
2051
2052         Add Experimental Feature support for SourceBuffer.changeType()
2053         https://bugs.webkit.org/show_bug.cgi?id=188626
2054         <rdar://problem/43356021>
2055
2056         Reviewed by Eric Carlson.
2057
2058         * DumpRenderTree/mac/DumpRenderTree.mm:
2059         (enableExperimentalFeatures):
2060         (resetWebPreferencesToConsistentValues):
2061         * WebKitTestRunner/TestController.cpp:
2062         (WTR::TestController::resetPreferencesToConsistentValues):
2063
2064 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2065
2066         Support drag-and-drop for input[type=color]
2067         https://bugs.webkit.org/show_bug.cgi?id=188464
2068
2069         Reviewed by Wenson Hsieh.
2070
2071         Added five cross-platform API tests, to verify that dragging and dropping with
2072         color inputs changes the value of the drop target if and only if both inputs are
2073         enabled. Also tests that the change and input events are fired when changing the
2074         value of a color input through drag and drop. 
2075
2076         Additionally, added a macOS-specific test to verify that dropping an item with
2077         NSColorPboardType changes the value of the color input.
2078
2079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2080         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2081         (TestWebKitAPI::TEST):
2082         * TestWebKitAPI/Tests/WebKitCocoa/color-drop.html: Added.
2083         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2084         (TestWebKitAPI::TEST):
2085
2086 2018-08-16  Antti Koivisto  <antti@apple.com>
2087
2088         Use OptionSet for ActivityState::Flags
2089         https://bugs.webkit.org/show_bug.cgi?id=188554
2090
2091         Reviewed by Brent Fulgham.
2092
2093         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2094         (TestWebKitAPI::TEST):
2095
2096 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2097
2098         [GTK] MiniBrowser: web view doesn't get the focus when new window is created
2099         https://bugs.webkit.org/show_bug.cgi?id=188546
2100
2101         Reviewed by Michael Catanzaro.
2102
2103         When a new window is created, the first widget of the windo is getting the focus, the toolbar in this case. We
2104         always want the WebView to grab the focus. In case of new empty tab, we want to the URL bar to be focused
2105         instead. This was causing failures in WebDriver tests that create a popup window with an input element that is
2106         filled with send keys command. The input element is marked as focused in the DOM, but the actual focused widget
2107         is the toolbar, so key events are sent to the toolbar instead of the web view.
2108
2109         * MiniBrowser/gtk/BrowserWindow.c:
2110         (webViewCreate):
2111         (newTabCallback):
2112         (openPrivateWindow):
2113         (browser_window_get_or_create_web_view_for_automation):
2114
2115 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2116
2117         Unreviewed. Fix WebDriver tests after r234839.
2118
2119         New pytest requires to autoinstall attrs too.
2120
2121         * Scripts/webkitpy/thirdparty/__init__.py:
2122         (AutoinstallImportHook._install_pytest):
2123
2124 2018-08-15  Ansh Shukla  <ansh_shukla@apple.com>
2125
2126         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2127         https://bugs.webkit.org/show_bug.cgi?id=186870
2128         <rdar://problem/41314410>
2129
2130         Reviewed by Alex Christensen.
2131
2132         * WebKitTestRunner/TestController.cpp:
2133         (WTR::toString):
2134         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
2135         (WTR::TestController::didReceiveAuthenticationChallenge):
2136
2137 2018-08-15  Ben Richards  <benton_richards@apple.com>
2138
2139         We should cache the compiled sandbox profile in a data vault
2140         https://bugs.webkit.org/show_bug.cgi?id=184991
2141
2142         Reviewed by Ryosuke Niwa.
2143
2144         Added trace points for sandbox initialization
2145
2146         * Tracing/SystemTracePoints.plist:
2147
2148 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
2149
2150         Unreviewed, rolling out r234870.
2151
2152         The test introduced with this change is a flaky failure.
2153
2154         Reverted changeset:
2155
2156         "NSURLAuthenticationMethodOAuth challenges are surfaced to
2157         clients in -didReceiveAuthenticationChallenge as
2158         NSURLAuthenticationMethodDefault"
2159         https://bugs.webkit.org/show_bug.cgi?id=186870
2160         https://trac.webkit.org/changeset/234870
2161
2162 2018-08-15  Jonathan Bedard  <jbedard@apple.com>
2163
2164         WebKitTestRunner should support watch devices
2165         https://bugs.webkit.org/show_bug.cgi?id=188570
2166
2167         Reviewed by Alex Christensen.
2168
2169         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2170
2171 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2172
2173         [Attachment SPI] Remove attachment display mode options
2174         https://bugs.webkit.org/show_bug.cgi?id=188596
2175
2176         Reviewed by Dan Bernstein.
2177
2178         Remove API tests and API test helpers for verifying the behavior of in-place media attachment elements.
2179
2180         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2181         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
2182         (TestWebKitAPI::TEST):
2183         (testVideoData): Deleted.
2184         (displayOptionsWithMode): Deleted.
2185         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]): Deleted.
2186
2187 2018-08-14  Devin Rousso  <drousso@apple.com>
2188
2189         Unreviewed, change my emails.
2190
2191         * Scripts/webkitpy/common/config/contributors.json:
2192         * Scripts/webkitpy/common/config/watchlist:
2193
2194 2018-08-14  Saam barati  <sbarati@apple.com>
2195
2196         HashMap<Ref<P>, V> asserts when V is not zero for its empty value
2197         https://bugs.webkit.org/show_bug.cgi?id=188582
2198
2199         Reviewed by Sam Weinig.
2200
2201         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2202         (TestWebKitAPI::TEST):
2203
2204 2018-08-14  Zalan Bujtas  <zalan@apple.com>
2205
2206         [LFC][Floating] Add support for negative clearance.
2207         https://bugs.webkit.org/show_bug.cgi?id=188555
2208
2209         Reviewed by Simon Fraser.
2210
2211         * LayoutReloaded/misc/LFC-passing-tests.txt:
2212
2213 2018-08-14 Sihui Liu <sihui_liu@apple.com>
2214
2215         Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
2216         https://bugs.webkit.org/show_bug.cgi?id=188576
2217         <rdar://problem/43148977>
2218
2219         Reviewed by Alex Christensen.
2220
2221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2222         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Added.
2223         (TEST):
2224
2225 2018-08-14  Alex Christensen  <achristensen@webkit.org>
2226
2227         isValidCSSSelector is unsafe to be called from a non-main thread
2228         https://bugs.webkit.org/show_bug.cgi?id=188581
2229         <rdar://problem/40517358>
2230
2231         Reviewed by Sam Weinig.
2232
2233         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2234         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2235         (TestWebKitAPI::checkCompilerError):
2236
2237 2018-08-14  Ansh Shukla  <ansh_shukla@apple.com>
2238
2239         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2240         https://bugs.webkit.org/show_bug.cgi?id=186870
2241         <rdar://problem/41314410>
2242
2243         Reviewed by Alex Christensen.
2244
2245         * WebKitTestRunner/TestController.cpp:
2246         (WTR::toString):
2247         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
2248         (WTR::TestController::didReceiveAuthenticationChallenge):
2249
2250 2018-08-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2251
2252         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
2253         https://bugs.webkit.org/show_bug.cgi?id=187973
2254
2255         Reviewed by Alex Christensen.
2256
2257         In LayoutTests, test names have been canonicalized in Unix style
2258         since Bug 63597, for example 'fast/css/001.html'. But Bug 179219,
2259         Bug 179572, Bug 180660, and Bug 181814 have changed to use
2260         os.path.seq instead of slash if Windows Python is used.
2261
2262         Revert parts of those changes. Change relative_test_filename to
2263         return a slash-separated test name as chromium_win.py used to do.
2264
2265         This change fixes all 41 test-webkitpy failures in WinCairo port.
2266
2267         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2268         (TestExpectationParser._parse_line): Do not convert test names with normpath.
2269         * Scripts/webkitpy/port/base.py:
2270         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
2271         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
2272         (Port.abspath_for_test): Replace self.TEST_PATH_SEPARATOR with self.host.filesystem.sep.
2273         * Scripts/webkitpy/port/driver.py:
2274         (Driver): Use '/' instead of os.sep.
2275         * Scripts/webkitpy/port/win.py:
2276         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
2277
2278 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
2279
2280         [ews-build] Add build step to run WK1 layout-test
2281         https://bugs.webkit.org/show_bug.cgi?id=188498
2282
2283         Reviewed by Lucas Forschler.
2284
2285         * BuildSlaveSupport/ews-build/steps.py:
2286         (RunWebKit1Tests): Class to run WebKit1Tests.
2287         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2288
2289 2018-08-14  Patrick Griffis  <pgriffis@igalia.com>
2290
2291         [Flatpak] Fix --cmakeargs
2292         https://bugs.webkit.org/show_bug.cgi?id=188567
2293
2294         Reviewed by Michael Catanzaro.
2295
2296         * flatpak/flatpakutils.py:
2297         (WebkitFlatpak.setup_dev_env):
2298
2299 2018-08-14  Darshan Kadu  <dkadu@igalia.com>
2300
2301         Enhancement request: Make export-w3c-test-changes add the PR to "See Also" links
2302         https://bugs.webkit.org/show_bug.cgi?id=186140
2303
2304         Reviewed by Youenn Fablet.
2305
2306         Added an optional parameter see_also to post_comment_to_bug function and used it for adding see_also variable's content in "See Also"
2307         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2308         (Bugzilla.post_comment_to_bug):
2309         Modified mock for see_also parameter
2310         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2311         (MockBugzilla.post_comment_to_bug):
2312         Made following unit tests to have see_also in bug comment
2313         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2314         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2315         (SheriffTest.test_post_blame_comment_on_bug):
2316         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2318         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2319         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2320         * Scripts/webkitpy/w3c/test_exporter.py:
2321         (WebPlatformTestExporter.make_pull_request):
2322         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2323         (TestExporterTest.MockBugzilla.post_comment_to_bug):
2324         (TestExporterTest.test_export):
2325
2326 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Add support for max_builds parameter for workers
2329         https://bugs.webkit.org/show_bug.cgi?id=188531
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-build/loadConfig.py:
2334         (loadBuilderConfig): Added support for max_builds.
2335
2336 2018-08-14  Zalan Bujtas  <zalan@apple.com>
2337
2338         [LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
2339         https://bugs.webkit.org/show_bug.cgi?id=188543
2340
2341         Reviewed by Antti Koivisto.
2342
2343         * LayoutReloaded/misc/LFC-passing-tests.txt:
2344
2345 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         Unreviewed. Fix WebDriver tests after r234839.
2348
2349         New pytest requires to autoinstall more_itertools and six too.
2350
2351         * Scripts/webkitpy/thirdparty/__init__.py:
2352         (AutoinstallImportHook._install_pytest):
2353
2354 2018-08-14  Tomas Popela  <tpopela@redhat.com>
2355
2356         [GTK] Minibrowser: Add labels for buttons
2357         https://bugs.webkit.org/show_bug.cgi?id=188549
2358
2359         Reviewed by Carlos Garcia Campos.
2360
2361         So they are accessible easier (i.e. while testing WebKitGTK+ through Minibrowser in Dogtail).
2362
2363         * MiniBrowser/gtk/BrowserWindow.c:
2364         (webViewIsLoadingChanged):
2365         (browserWindowSetupEditorToolbar):
2366         (browser_window_init):
2367
2368 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2369
2370         Unreviewed. Fix WebDriver tests after r234839.
2371
2372         New pytest requires to autoinstall atomicwrites too.
2373
2374         * Scripts/webkitpy/thirdparty/__init__.py:
2375         (AutoinstallImportHook._install_pytest):
2376
2377 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         Unreviewed. Fix WebDriver tests after r234839.
2380
2381         New pytest requires to autoinstall pluggy and funcsigs too.
2382
2383         * Scripts/webkitpy/thirdparty/__init__.py:
2384         (AutoinstallImportHook._install_pytest):
2385
2386 2018-08-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2387
2388         Unreviewed. Update W3C WebDriver imported tests.
2389
2390         Bump pytest version to 3.6.2.
2391
2392         * Scripts/webkitpy/thirdparty/__init__.py:
2393         (AutoinstallImportHook._install_pytest):
2394
2395 2018-08-13  Thomas Denney  <tdenney@apple.com>
2396
2397         Allow the substring 'me' in contributor names and email addresses
2398         https://bugs.webkit.org/show_bug.cgi?id=188538
2399
2400         Reviewed by Tim Horton.
2401
2402         A test didn't permit the string "me" in email addresses or names of contributors.
2403
2404         * Scripts/webkitpy/common/config/committers_unittest.py:
2405         (CommittersTest.test_contributors_by_fuzzy_match):
2406
2407 2018-08-13  Commit Queue  <commit-queue@webkit.org>
2408
2409         Unreviewed, rolling out r234812.
2410         https://bugs.webkit.org/show_bug.cgi?id=188536
2411
2412         broke the build (Requested by ThomasDenney on #webkit).
2413
2414         Reverted changeset:
2415
2416         "Added Thomas Denney to contributors.json."
2417         https://bugs.webkit.org/show_bug.cgi?id=188525
2418         https://trac.webkit.org/changeset/234812
2419
2420 2018-08-13  Sihui Liu  <sihui_liu@apple.com>
2421
2422         Avoid timeout resulted from calling waitUntilDone when test is not running
2423         https://bugs.webkit.org/show_bug.cgi?id=188389
2424
2425         Reviewed by Chris Dumez.
2426
2427         If test is not running, we should not set the waitUntilDone flag, or it may cause subsequent tests timeout.
2428
2429         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2430         (WTR::TestRunner::waitUntilDone):
2431
2432 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2433
2434         [WK2] [macOS] Implement a mechanism to test drag and drop
2435         https://bugs.webkit.org/show_bug.cgi?id=181898
2436         <rdar://problem/39181698>
2437
2438         Reviewed by Simon Fraser.
2439
2440         Implements the currently stubbed DragAndDropSimulator on macOS, and introduces a new API test for r227266. See
2441         comments below for more detail.
2442
2443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2444         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
2445
2446         Introduce a file for cross-platform drag and drop tests, currently for iOS and macOS. Additionally add a test
2447         for r227266, which was fixed earlier this year but could not be tested due to a lack of testing mechanism on
2448         macOS in WebKit2.
2449
2450         (TEST):
2451         * TestWebKitAPI/Tests/WebKitCocoa/full-page-dropzone.html: Added.
2452
2453         Minor tweaks to this test page to add "dragover" and "drop" event handlers.
2454
2455         * TestWebKitAPI/Tests/WebKitCocoa/image-in-link-and-input.html:
2456         * TestWebKitAPI/Tests/WebKitCocoa/link-in-iframe-and-input.html: Added.
2457
2458         Add a new test page that includes a link embedded within an iframe below a plain text input.
2459
2460         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm: Added.
2461         (TEST):
2462         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm.
2463
2464         Move only existing WebKit2 macOS drag and drop test (DragAndDropPasteboardTests.NumberOfValidItemsForDrop) out
2465         of DragAndDropPasteboardTests.mm and into a new file, DragAndDropTestsMac.mm. Additionally, rename
2466         DragAndDropPasteboardTests to LegacyDragAndDropTests, since it now only contains two legacy WebView tests for
2467         drag and drop.
2468
2469         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
2470         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
2471         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
2472         (-[DragSource draggingSourceOperationMaskForLocal:]):
2473         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
2474         (-[DragInfo lastMousePosition]):
2475         (-[DragInfo setLastMousePosition:]):
2476         (-[DragInfo draggingDestinationWindow]):
2477         (-[DragInfo draggingSourceOperationMask]):
2478         (-[DragInfo draggingLocation]):
2479         (-[DragInfo draggedImageLocation]):
2480         (-[DragInfo draggedImage]):
2481         (-[DragInfo draggingPasteboard]):
2482         (-[DragInfo draggingSource]):
2483         (-[DragInfo draggingSequenceNumber]):
2484         (-[DragInfo slideDraggedImageTo:]):
2485         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
2486         (-[DragInfo draggingFormation]):
2487         (-[DragInfo setDraggingFormation:]):
2488         (-[DragInfo animatesToDestination]):
2489         (-[DragInfo setAnimatesToDestination:]):
2490         (-[DragInfo numberOfValidItemsForDrop]):
2491         (-[DragInfo setNumberOfValidItemsForDrop:]):
2492         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2493         (-[DragInfo springLoadingHighlight]):
2494         (-[DragInfo resetSpringLoading]):
2495         (TestWebKitAPI::getTestImage):
2496         (TestWebKitAPI::webViewAfterPerformingDragOperation):
2497         (TestWebKitAPI::TEST):
2498         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Removed.
2499         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2500
2501         Flesh out some of the DragAndDropSimulator API for macOS, exposing (among other things) the drag pasteboard,
2502         the current NSDraggingInfo, the initial location of the drag image, and the drag image itself.
2503
2504         * TestWebKitAPI/cocoa/TestWKWebView.h:
2505         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2506         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2507         (-[TestWKWebView mouseUpAtPoint:]):
2508         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
2509         (-[TestWKWebView sendClicksAtPoint:numberOfClicks:]):
2510         (-[TestWKWebView mouseEnterAtPoint:]):
2511         (-[TestWKWebView mouseExitAtPoint:]):
2512         (-[TestWKWebView mouseDragToPoint:]):
2513         (-[TestWKWebView _mouseEventWithType:atLocation:]):
2514         (-[TestWKWebView _mouseEventWithType:atLocation:flags:timestamp:clickCount:]):
2515
2516         Add TestWKWebView helpers to send MouseMove, MouseEnter and MouseDrag NSEvents to the web view. Additionally,
2517         rename parameter names to these helpers to make it more obvious that these locations are all in NSWindow
2518         coordinates.
2519
2520         (-[TestWKWebView typeCharacter:]):
2521
2522         Drive-by style fix: put this opening brace on the beginning of the next line.
2523
2524         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2525         (-[DragAndDropSimulator initWithWebViewFrame:]):
2526         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2527         (-[DragAndDropSimulator webView]):
2528
2529         Small iOS DragAndDropSimulator adjustments for new DragAndDropSimulator interfaces.
2530
2531         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2532         (-[DragAndDropTestWKWebView initWithFrame:configuration:simulator:]):
2533
2534         Introduce a WKWebView subclass for testing drag and drop that overrides `-dragImage:at:offset:…`, and instead
2535         allows DragAndDropSimulator to take over the drag.
2536
2537         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2538
2539         Override this entry point into drag and drop code, and instead call out to the DragAndDropSimulator to
2540         coordinate the drag.
2541
2542         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]):
2543
2544         Helper method to wait for the web process to finish handling all in-flight mouse events.
2545
2546         (defaultExternalDragImage):
2547
2548         Set this image as the default drag image when simulating an incoming drag session from outside of the web view.
2549
2550         (-[DragAndDropSimulator initWithWebViewFrame:]):
2551         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2552         (-[DragAndDropSimulator flipAboutXAxisInHostWindow:]):
2553
2554         Helper method to flip a given point about the X axis of the window.
2555
2556         (-[DragAndDropSimulator locationInViewForCurrentProgress]):
2557
2558         Map a progress value (between 0 and 1) to a drag location.
2559
2560         (-[DragAndDropSimulator initialProgressForMouseDrag]):
2561
2562         Determines the initial progress value when initiation a drag in web content. This is the initial progress
2563         required to ensure that the first mouse drag event exceeds the drag distance hysteresis and causes any drag
2564         (if applicable) to begin.
2565
2566         (-[DragAndDropSimulator runFrom:to:]):
2567         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
2568
2569         Helper to coordinate drag updates in both the cases where we're simulating a drag session entering from outside
2570         of the web view, and in the case where we've initiated a drag from the web view itself.
2571
2572         (-[DragAndDropSimulator webView]):
2573         (-[DragAndDropSimulator setExternalDragPasteboard:]):
2574         (-[DragAndDropSimulator externalDragPasteboard]):
2575
2576         Just like its iOS counterpart (setExternalItemProviders:), setting an external drag pasteboard on macOS puts the
2577         DragAndDropSimulator in a mode that simulates a drag coming in from outside the web view, using the given
2578         pasteboard.
2579
2580         (-[DragAndDropSimulator setExternalDragImage:]):
2581         (-[DragAndDropSimulator externalDragImage]):
2582
2583         May be optionally set when specifying an external drag pasteboard to specify the drag image used. If no external
2584         drag image is specified, falls back to the default image returned by `defaultExternalDragImage()`.
2585
2586         (-[DragAndDropSimulator draggingInfo]):
2587         (-[DragAndDropSimulator willEndDraggingHandler]):
2588         (-[DragAndDropSimulator setWillEndDraggingHandler:]):
2589
2590         Hook to allow tests to run logic right before performing the drop (if the current drag operation is not none) or
2591         ending the drag session without performing a drag operation.
2592
2593         (-[DragAndDropSimulator initWithWebView:]): Deleted.
2594         (-[DragAndDropSimulator dealloc]): Deleted.
2595         (-[DragAndDropSimulator phase]): Deleted.
2596         * TestWebKitAPI/mac/TestDraggingInfo.h: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
2597         * TestWebKitAPI/mac/TestDraggingInfo.mm: Added.
2598
2599         Mock object conforming to NSDraggingInfo that is passed to WKWebView when invoking -draggingUpdated:,
2600         -draggingEntered: and -draggingExited:.
2601
2602         (-[TestDraggingInfo draggingPasteboard]):
2603         (-[TestDraggingInfo setDraggingPasteboard:]):
2604         (-[TestDraggingInfo draggingSource]):
2605         (-[TestDraggingInfo setDraggingSource:]):
2606         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2607         (-[TestDraggingInfo draggingDestinationWindow]):
2608         (-[TestDraggingInfo draggedImage]):
2609         (-[TestDraggingInfo setDraggedImage:]):
2610         (-[TestDraggingInfo slideDraggedImageTo:]):
2611         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
2612         (-[TestDraggingInfo resetSpringLoading]):
2613
2614         Empty method stubs, to be implemented in the future as needed.
2615
2616 2018-08-13  Thomas Denney  <tdenney@apple.com>
2617
2618         Added Thomas Denney to contributors.json.
2619         https://bugs.webkit.org/show_bug.cgi?id=188525
2620
2621         Reviewed by Myles C. Maxfield.
2622
2623         * Scripts/webkitpy/common/config/contributors.json:
2624
2625 2018-08-13  Antti Koivisto  <antti@apple.com>
2626
2627         Meaning of OptionSet::contains is unclear when used with OptionSet argument
2628         https://bugs.webkit.org/show_bug.cgi?id=188501
2629
2630         Reviewed by Anders Carlsson.
2631
2632         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2633         (TestWebKitAPI::TEST):
2634
2635 2018-08-13  Commit Queue  <commit-queue@webkit.org>
2636
2637         Unreviewed, rolling out r234747.
2638         https://bugs.webkit.org/show_bug.cgi?id=188524
2639
2640         plugin processes crash on launch (Requested by smfr on
2641         #webkit).
2642
2643         Reverted changeset:
2644
2645         "We should cache the compiled sandbox profile in a data vault"
2646         https://bugs.webkit.org/show_bug.cgi?id=184991
2647         https://trac.webkit.org/changeset/234747
2648
2649 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2650
2651         [iOS] Dragging a non-editable text selection into a plain text input inserts HTML markup
2652         https://bugs.webkit.org/show_bug.cgi?id=188485
2653         <rdar://problem/43168784>
2654
2655         Reviewed by Tim Horton.
2656
2657         Add a new API test to verify that dropping selected non-editable rich text into a textarea inserts text as
2658         expected, rather than markup.
2659
2660         It's somewhat interesting to note that this particular use case isn't exercised by any existing tests; the
2661         closest test is DragAndDropTests.ContentEditableToTextarea, which drags a rich text selection from a
2662         contenteditable element to a text area. However, due to logic in `DragController::concludeEditDrag` that handles
2663         drag and drop across editable content differently than drag and drop from non-editable to editable content, the
2664         bug that is fixed here doesn't surface in that existing test.
2665
2666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2667         * TestWebKitAPI/Tests/WebKitCocoa/selected-text-and-textarea.html: Added.
2668         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2669         (TestWebKitAPI::TEST):
2670
2671 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2672
2673         Use a 1-byte enum class for TextDirection
2674         https://bugs.webkit.org/show_bug.cgi?id=188350
2675
2676         Reviewed by Simon Fraser.
2677
2678         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2679         (TestWebKitAPI::TEST_F):
2680         * TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:
2681         (WebCore::operator<<):
2682         (TestWebKitAPI::TEST):
2683         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2684         (TEST_F):
2685
2686 2018-08-13  Zalan Bujtas  <zalan@apple.com>
2687
2688         [LFC][Floating] Add basic clearance support
2689         https://bugs.webkit.org/show_bug.cgi?id=188492
2690
2691         Reviewed by Antti Koivisto.
2692
2693         * LayoutReloaded/misc/LFC-passing-tests.txt:
2694
2695 2018-08-12  Zalan Bujtas  <zalan@apple.com>
2696
2697         [LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
2698         https://bugs.webkit.org/show_bug.cgi?id=188487
2699
2700         Reviewed by Antti Koivisto.
2701
2702         * LayoutReloaded/misc/LFC-passing-tests.txt:
2703
2704 2018-08-11  Aakash Jain  <aakash_jain@apple.com>
2705
2706         [ews-build] Separate queues for Builders and Testers - iOS
2707         https://bugs.webkit.org/show_bug.cgi?id=188396
2708
2709         Reviewed by Lucas Forschler.
2710
2711         * BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
2712         Also added ews121 and ews122 to match with current EWS configuration.
2713         * BuildSlaveSupport/ews-build/factories.py:
2714         (TestsFactory): Base classes for various Test factories.
2715         (TestsFactory.getProduct): Download and extract the archive.
2716
2717 2018-08-10  Daniel Bates  <dabates@apple.com>
2718
2719         webkit-patch setup-git-clone should set Git core editor to commit-log-editor
2720         https://bugs.webkit.org/show_bug.cgi?id=188473
2721
2722         Reviewed by Ryosuke Niwa.
2723
2724         Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
2725         so that the Git commit message is generated from the ChangeLog for developers that manually
2726         generate their ChangeLog using prepare-ChangeLog.
2727
2728         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2729         (SetupGitClone.execute):
2730
2731 2018-08-10  Truitt Savell  <tsavell@apple.com>
2732
2733         Unreviewed, rolling out r234749.
2734
2735         Caused all perf tests to fail in Sierra
2736
2737         Reverted changeset:
2738
2739         "[webkitpy][Win] LayoutTests: test names should be Unix style,
2740         separated by slash not backslash"
2741         https://bugs.webkit.org/show_bug.cgi?id=187973
2742         https://trac.webkit.org/changeset/234749
2743
2744 2018-08-10  David Fenton  <david_fenton@apple.com>
2745
2746         Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
2747         https://bugs.webkit.org/show_bug.cgi?id=188470.
2748
2749         Unreviewed test gardening, disabling the tests.
2750
2751         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2752         (TEST_F):
2753
2754 2018-08-10  Joseph Pecoraro  <pecoraro@apple.com>
2755
2756         Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
2757         https://bugs.webkit.org/show_bug.cgi?id=188458
2758
2759         Reviewed by Alex Christensen.
2760
2761         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2762         (TestExpectationParser):
2763         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2764
2765 2018-08-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2766
2767         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
2768         https://bugs.webkit.org/show_bug.cgi?id=187973
2769
2770         Reviewed by Alex Christensen.
2771
2772         In LayoutTests, test names have been canonicalized in Unix style
2773         since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
2774         Bug 179572, Bug 180660 and Bug 181814 have changed to use
2775         os.path.seq instead of slash if Windows Python is used.
2776
2777         Revert parts of those changes. Change relative_test_filename to
2778         return a slash sperated test name as well as chromium_win.py used
2779         to do.
2780
2781         This change fixes all 41 test-webkitpy failures in WinCairo port.
2782
2783         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2784         (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
2785         * Scripts/webkitpy/port/base.py:
2786         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
2787         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
2788         (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
2789         * Scripts/webkitpy/port/driver.py:
2790         (Driver): Use '/' instead of os.sep.
2791         * Scripts/webkitpy/port/win.py:
2792         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
2793
2794 2018-08-09  Thomas Denney  <tdenney@apple.com>
2795
2796         [WHLSL] Add individual test durations to output
2797         https://bugs.webkit.org/show_bug.cgi?id=188448
2798
2799         Reviewed by Myles C. Maxfield.
2800
2801         * WebGPUShadingLanguageRI/Test.js: Add timing output.
2802
2803 2018-08-09  Ben Richards  <benton_richards@apple.com>
2804
2805         We should cache the compiled sandbox profile in a data vault
2806         https://bugs.webkit.org/show_bug.cgi?id=184991
2807
2808         Reviewed by Ryosuke Niwa.
2809
2810         Added trace points for sandbox initialization
2811
2812         * Tracing/SystemTracePoints.plist:
2813
2814 2018-08-09  Jer Noble  <jer.noble@apple.com>
2815
2816         Video playback is using more power
2817         https://bugs.webkit.org/show_bug.cgi?id=188452
2818         <rdar://problem/42298937>
2819
2820         Reviewed by Eric Carlson.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2823         (PreferredAudioBufferSize::createView):
2824         (PreferredAudioBufferSize::preferredAudioBufferSize const):
2825         (TEST_F):
2826
2827 2018-08-09  Alex Christensen  <achristensen@webkit.org>
2828
2829         REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
2830         https://bugs.webkit.org/show_bug.cgi?id=188453
2831         <rdar://problem/43102553>
2832
2833         Reviewed by Chris Dumez
2834
2835         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2836         (TEST):
2837         (+[NullLookupContext sharedLookupContext]):
2838         (TestWebKitAPI::TEST): Deleted.
2839
2840 2018-08-09  Alex Christensen  <achristensen@webkit.org>
2841
2842         WKURLSchemeHandler crashes when sent errors with sync XHR
2843         https://bugs.webkit.org/show_bug.cgi?id=188358
2844
2845         Reviewed by Chris Dumez.
2846
2847         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2848         (-[SyncErrorScheme webView:startURLSchemeTask:]):
2849         (-[SyncErrorScheme webView:stopURLSchemeTask:]):
2850         (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2851
2852 2018-08-09  Per Arne Vollan  <pvollan@apple.com>
2853
2854         REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
2855         https://bugs.webkit.org/show_bug.cgi?id=188397
2856
2857         Reviewed by Tim Horton.
2858
2859         After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
2860         user defaults related to scrollbars in the UI process as we do in the WebProcess.
2861
2862         * WebKitTestRunner/mac/main.mm:
2863         (setDefaultsToConsistentValuesForTesting):
2864
2865 2018-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2866
2867         [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
2868         https://bugs.webkit.org/show_bug.cgi?id=188439
2869
2870         Reviewed by Andy Estes and Megan Gardner.
2871
2872         Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
2873         macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
2874         DragAndDropTests.
2875
2876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2877         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2878         (TestWebKitAPI::TEST):
2879         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
2880         (testIconImage):
2881         (testZIPArchive):
2882         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2883         (-[TestWKWebView editorContainsImageElement]):
2884         (-[TestWKWebView editorValue]):
2885         (makeCGRectValue):
2886         (checkCGRectIsEqualToCGRectWithLogging):
2887         (checkSelectionRectsWithLogging):
2888         (checkRichTextTypePrecedesPlainTextType):
2889         (checkFirstTypeIsPresentAndSecondTypeIsMissing):
2890         (checkTypeIdentifierIsRegisteredAtIndex):
2891         (checkEstimatedSize):
2892         (checkSuggestedNameAndEstimatedSize):
2893         (checkStringArraysAreEqual):
2894         (checkDragCaretRectIsContainedInRect):
2895         (checkJSONWithLogging):
2896         (testIconImageData):
2897         (runTestWithTemporaryTextFile):
2898         (runTestWithTemporaryFolder):
2899         (TestWebKitAPI::TEST):
2900         (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
2901         (TestWebKitAPI::testDragAndDropOntoTargetElements):
2902         (TestWebKitAPI::testIconImageData):
2903         * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
2904         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
2905         (-[WKWebView dropInteractionDelegate]):
2906         (-[WKWebView dragInteractionDelegate]):
2907         (-[WKWebView dropInteraction]):
2908         (-[WKWebView dragInteraction]):
2909         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2910         (-[MockDragDropSession allowsMoveOperation]):
2911         (-[MockDragDropSession isRestrictedToDraggingApplication]):
2912         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
2913         (-[MockDragDropSession canLoadObjectsOfClass:]):
2914         (-[MockDragDropSession canLoadObjectsOfClasses:]):
2915         (-[MockDragDropSession items]):
2916         (-[MockDragDropSession setItems:]):
2917         (-[MockDragDropSession addItems:]):
2918         (-[MockDragDropSession locationInView:]):
2919         (-[MockDropSession initWithProviders:location:window:allowMove:]):
2920         (-[MockDropSession isLocal]):
2921         (-[MockDropSession progress]):
2922         (-[MockDropSession setProgressIndicatorStyle:]):
2923         (-[MockDropSession progressIndicatorStyle]):
2924         (-[MockDropSession operationMask]):
2925         (-[MockDropSession localDragSession]):
2926         (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
2927         (-[MockDropSession canCreateItemsOfClass:]):
2928         (-[MockDropSession loadObjectsOfClass:completion:]):
2929         (-[MockDragSession initWithWindow:allowMove:]):
2930         (-[MockDragSession localOperationMask]):
2931         (-[MockDragSession externalOperationMask]):
2932         (-[MockDragSession session]):
2933         (-[MockDragSession localContext]):
2934         (-[MockDragSession setLocalContext:]):
2935         (dragAndDropEventNames):
2936         (-[DragAndDropSimulatorApplication _cancelAllTouches]):
2937         (-[DragAndDropSimulator initWithWebView:]):
2938         (-[DragAndDropSimulator dealloc]):
2939         (-[DragAndDropSimulator _resetSimulatedState]):
2940         (-[DragAndDropSimulator observedEventNames]):
2941         (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
2942         (-[DragAndDropSimulator runFrom:to:]):
2943         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2944         (-[DragAndDropSimulator finalSelectionRects]):
2945         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2946         (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
2947         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2948         (-[DragAndDropSimulator _advanceProgress]):
2949         (-[DragAndDropSimulator _currentLocation]):
2950         (-[DragAndDropSimulator _scheduleAdvanceProgress]):
2951         (-[DragAndDropSimulator sourceItemProviders]):
2952         (-[DragAndDropSimulator externalItemProviders]):
2953         (-[DragAndDropSimulator setExternalItemProviders:]):
2954         (-[DragAndDropSimulator phase]):
2955         (-[DragAndDropSimulator liftPreviews]):
2956         (-[DragAndDropSimulator lastKnownDragCaretRect]):
2957         (-[DragAndDropSimulator waitForInputSession]):
2958         (-[DragAndDropSimulator insertedAttachments]):
2959         (-[DragAndDropSimulator removedAttachments]):
2960         (-[DragAndDropSimulator endDataTransfer]):
2961         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2962         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2963         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2964         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2965         (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
2966         (-[DragAndDropSimulator _webView:didInsertAttachment:]):
2967         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
2968         (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
2969         (-[DragAndDropSimulator _webView:didStartInputSession:]):
2970         * TestWebKitAPI/ios/UIKitSPI.h:
2971         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
2972         (-[DragAndDropSimulator initWithWebView:]):
2973         (-[DragAndDropSimulator dealloc]):
2974         (-[DragAndDropSimulator runFrom:to:]):
2975         (-[DragAndDropSimulator insertedAttachments]):
2976         (-[DragAndDropSimulator removedAttachments]):
2977
2978 2018-08-09  Sihui Liu  <sihui_liu@apple.com>
2979
2980         REGRESSION (r232083): WKWebView loses first-party cookies on iOS
2981         https://bugs.webkit.org/show_bug.cgi?id=188443
2982         <rdar://problem/42991584>
2983
2984         Reviewed by Chris Dumez.
2985
2986         Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
2987
2988         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2989
2990 2018-08-09  Ross Kirsling  <ross.kirsling@sony.com>
2991
2992         Unreviewed follow-up fix for r234720.
2993
2994         * Scripts/webkitpy/bindings/main.py:
2995         (BindingsTests.close_and_remove):
2996         (BindingsTests.main):
2997         Return to the original approach, since this seems to be the simplest cross-platform solution.
2998
2999 2018-08-09  Ali Juma  <ajuma@chromium.org>
3000
3001         Import WPTs for IntersectionObserver
3002         https://bugs.webkit.org/show_bug.cgi?id=188416
3003
3004         Reviewed by Simon Fraser.
3005
3006         Enable IntersectionObserver in DumpRenderTree. 
3007
3008         * DumpRenderTree/mac/DumpRenderTree.mm:
3009         (enableExperimentalFeatures):
3010         (setWebPreferencesForTestOptions):
3011         * WebKitTestRunner/TestController.cpp:
3012         (WTR::TestController::resetPreferencesToConsistentValues):
3013
3014 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
3015
3016         run-bindings-tests is not Win32-compatible
3017         https://bugs.webkit.org/show_bug.cgi?id=188424
3018
3019         Reviewed by Fujii Hironori.
3020
3021         * Scripts/webkitpy/bindings/main.py:
3022         (BindingsTests.main):
3023         Stop leaking file descriptors.
3024         (See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
3025
3026 2018-08-08  Alex Christensen  <achristensen@webkit.org>
3027
3028         Fix possible null dereference in WebBackForwardList::restoreFromState
3029         https://bugs.webkit.org/show_bug.cgi?id=188418
3030         <rdar://problem/42531726>
3031
3032         Reviewed by Chris Dumez.
3033
3034         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3035         (TestWebKitAPI::TEST):
3036
3037 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
3038
3039         run-builtins-generator-tests does not correctly handle CRLFs from stderr
3040         https://bugs.webkit.org/show_bug.cgi?id=188392
3041
3042         Reviewed by Fujii Hironori.
3043
3044         Background:
3045         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
3046
3047         * Scripts/webkitpy/common/system/executive.py:
3048         (Executive.run_command):
3049         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
3050
3051 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
3052
3053         Unreviewed, add myself to committers list.
3054
3055         * Scripts/webkitpy/common/config/contributors.json:
3056
3057 2018-08-08  Commit Queue  <commit-queue@webkit.org>
3058
3059         Unreviewed, rolling out r234314, r234320, and r234321.
3060         https://bugs.webkit.org/show_bug.cgi?id=188414
3061
3062         Caused email sign in issue (Requested by ryanhaddad on
3063         #webkit).
3064
3065         Reverted changesets:
3066
3067         "Remove unused WKNavigationDelegatePrivate
3068         decidePolicyForNavigationAction SPI"
3069         https://bugs.webkit.org/show_bug.cgi?id=188077
3070         https://trac.webkit.org/changeset/234314
3071
3072         "Fix API tests after r234314"
3073         https://bugs.webkit.org/show_bug.cgi?id=188077
3074         https://trac.webkit.org/changeset/234320
3075
3076         "Fix API tests after r234314"
3077         https://bugs.webkit.org/show_bug.cgi?id=188077
3078         https://trac.webkit.org/changeset/234321
3079
3080 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3081
3082         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
3083         https://bugs.webkit.org/show_bug.cgi?id=188401
3084         <rdar://problem/32542300>
3085
3086         Reviewed by Ryosuke Niwa.
3087
3088         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
3089         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
3090         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
3091         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
3092         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
3093         skip over one of the steps in the layout test, resulting in a text diff failure.
3094
3095         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
3096         as a part of resetting test controller state, before moving on to the next layout test.
3097
3098         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3099         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3100         (-[TestRunnerWKWebView didStartFormControlInteraction]):
3101         (-[TestRunnerWKWebView didEndFormControlInteraction]):
3102
3103         Use these hooks to keep track of whether the previous test is presenting any form input UI.
3104
3105         (-[TestRunnerWKWebView isInteractingWithFormControl]):
3106         * WebKitTestRunner/ios/TestControllerIOS.mm:
3107         (WTR::handleKeyboardWillHideNotification):
3108         (WTR::handleKeyboardDidHideNotification):
3109         (WTR::TestController::platformInitialize):
3110         (WTR::TestController::platformDestroy):
3111
3112         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
3113         of when the keyboard dismissal animation ends.
3114
3115         (WTR::TestController::platformResetStateToConsistentValues):
3116
3117         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
3118         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
3119         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
3120
3121 2018-08-05  Darin Adler  <darin@apple.com>
3122
3123         [Cocoa] More tweaks and refactoring to prepare for ARC
3124         https://bugs.webkit.org/show_bug.cgi?id=188245
3125
3126         Reviewed by Dan Bernstein.
3127
3128         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
3129         CFTypeRef instead of void*.
3130
3131         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3132         (createCoreAnimationLayer): Use CFBridgingRetain.
3133
3134         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3135         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
3136         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
3137         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
3138         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
3139         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
3140         (AccessibilityUIElement::indexForTextMarker): Ditto.
3141         (AccessibilityUIElement::textMarkerForIndex): Ditto.
3142         (AccessibilityUIElement::isTextMarkerValid): Ditto.
3143         (AccessibilityUIElement::previousTextMarker): Ditto.
3144         (AccessibilityUIElement::nextTextMarker): Ditto.
3145         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
3146         (createJSStringRef): Ditto.
3147         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
3148         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
3149         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
3150         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
3151         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
3152         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
3153         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
3154         (AccessibilityUIElement::textMarkerForPoint): Ditto.
3155         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
3156         (AccessibilityUIElement::startTextMarker): Ditto.
3157         (AccessibilityUIElement::endTextMarker): Ditto.
3158         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
3159         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
3160         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
3161         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
3162         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
3163         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
3164         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
3165         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
3166         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
3167         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
3168         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
3169
3170         * DumpRenderTree/mac/DumpRenderTree.mm:
3171         (resetWebPreferencesToConsistentValues): Use bridging cast.
3172         (dumpFramesAsText): Ditto.
3173         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
3174         CFArray functions to iterate the array.
3175         (dump): Use bridging cast.
3176         (runTest): Ditto.
3177
3178         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3179         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
3180         (toUTI): Return a RetainPtr<CFStringRef>.
3181         (-[LocalPasteboard types]): Use the above and bridging casts.
3182         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
3183         (-[LocalPasteboard setData:forType:]): Ditto.
3184         (-[LocalPasteboard dataForType:]): Ditto.
3185         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
3186         instead of CFPropertyList.
3187         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
3188         CFStringCreateExternalRepresentation.
3189
3190         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
3191         instead of an Objective-C object pointer type.
3192         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3193         (-[MockGeolocationProvider registerWebView:]): Update for above.
3194         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
3195         (-[MockGeolocationProvider timerFired]): Ditto.
3196
3197         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
3198         HashMap and HashSet instead of an Objective-C object pointer type.
3199         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3200         (-[MockWebNotificationProvider registerWebView:]): Update for above.
3201         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
3202         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
3203         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
3204         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
3205
3206         * DumpRenderTree/mac/ObjCPlugin.m:
3207         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
3208
3209         * DumpRenderTree/mac/TestRunnerMac.mm:
3210         (TestRunner::addDisallowedURL): Use bridging cast.
3211         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
3212         (TestRunner::clearApplicationCacheForOrigin): Ditto.
3213         (originsArrayToJS): Ditto.
3214         (TestRunner::copyDecodedHostName): Ditto.
3215         (TestRunner::copyEncodedHostName): Ditto.
3216         (TestRunner::queueLoad): Ditto.
3217         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
3218         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
3219         (TestRunner::setUserStyleSheetLocation): Ditto.
3220         (TestRunner::setValueForUser): Ditto.
3221         (TestRunner::overridePreference): Ditto.
3222         (TestRunner::execCommand): Ditto.
3223         (TestRunner::findString): Ditto.
3224         (TestRunner::isCommandEnabled): Ditto.
3225         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
3226         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
3227         (TestRunner::addUserScript): Ditto.
3228         (TestRunner::addUserStyleSheet): Ditto.
3229         (TestRunner::evaluateInWebInspector): Ditto.
3230         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3231         (TestRunner::authenticateSession): Ditto.
3232         (TestRunner::grantWebNotificationPermission): Ditto.
3233         (TestRunner::denyWebNotificationPermission): Ditto.
3234         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3235         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
3236
3237         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3238         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
3239         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
3240         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
3241         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
3242         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
3243         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
3244         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
3245         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
3246         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
3247         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
3248         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
3249         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
3250         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
3251         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
3252         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
3253         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
3254         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
3255         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
3256         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
3257         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
3258         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
3259         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
3260         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
3261         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
3262
3263         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
3264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
3265
3266         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
3267         so we can use the type and know it inherits from NSWindow.
3268
3269         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
3270         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
3271         class into a separate file.
3272         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
3273         instead of have a second copy of the implementation.
3274
3275         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
3276         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
3277         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
3278
3279         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
3280         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
3281         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
3282         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
3283         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
3284         instead of CFPropertyList.
3285         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
3286         CFStringCreateExternalRepresentation.
3287
3288         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
3289         WebKitTestRunnerWindow here so it can be included by files that need to know
3290         what the type is and that it inherits from NSWindow.
3291
3292         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
3293         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
3294         messier implementation.
3295
3296 2018-08-07  Alex Christensen  <achristensen@webkit.org>
3297
3298         Add a test for using SafeBrowsing
3299         https://bugs.webkit.org/show_bug.cgi?id=188290
3300
3301         Reviewed by Chris Dumez.
3302
3303         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
3304         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
3305
3306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3307         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
3308         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
3309         (TestWebKitAPI::TEST):
3310
3311 2018-08-07  Lucas Forschler  <lforschler@apple.com>
3312
3313         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
3314         https://bugs.webkit.org/show_bug.cgi?id=188235
3315
3316         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
3317
3318         * Scripts/webkitpy/common/checkout/changelog.py: 
3319         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
3320         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
3321         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3322         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
3323         * Scripts/webkitpy/tool/commands/upload.py:
3324         (Upload): Teach the upload step how to add radar information when creating a new bug.
3325         * Scripts/webkitpy/tool/steps/__init__.py:
3326         * Scripts/webkitpy/tool/steps/addradar.py: Added.
3327         (AddRadar):
3328         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
3329         * Scripts/webkitpy/tool/steps/createbug.py:
3330         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
3331
3332 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3333
3334         Post-review feedback after r234614.
3335         https://bugs.webkit.org/show_bug.cgi?id=188322
3336         <rdar://problem/42455270>
3337
3338         Reviewed by Sam Weinig.
3339
3340         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
3341
3342         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3343         (rounded):
3344
3345 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
3346
3347         [MiniBrowser][Win] Allow selection of recent user agents
3348         https://bugs.webkit.org/show_bug.cgi?id=188371
3349
3350         Reviewed by Fujii Hironori.
3351
3352         Updates the user agent spoofing strings to the latest released
3353         versions and adds Microsoft Edge's user agent.
3354
3355         Moves the menu item selection to the common base class, BrowserWindow
3356         to support user agent spoofing in a WebKitLegacyBrowserWindow and
3357         WebKitBrowserWindow.
3358
3359         * MiniBrowser/win/BrowserWindow.cpp: Added.
3360         (BrowserWindow::setUserAgent):
3361         * MiniBrowser/win/BrowserWindow.h:
3362         * MiniBrowser/win/CMakeLists.txt:
3363         * MiniBrowser/win/MainWindow.cpp:
3364         (MainWindow::toggleMenuItem):
3365         * MiniBrowser/win/MiniBrowserLib.rc:
3366         * MiniBrowser/win/MiniBrowserLibResource.h:
3367         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3368         * MiniBrowser/win/WebKitBrowserWindow.h:
3369         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3370         (WebKitLegacyBrowserWindow::setUserAgent):
3371         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3372
3373 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3374
3375         Unreviewed, add a new address to my configuration
3376
3377         * Scripts/webkitpy/common/config/contributors.json:
3378
3379 2018-08-06  David Quesada  <david_quesada@apple.com>
3380
3381         webkitdirs.pm should default to iPhone SE for 64-bit testing
3382         https://bugs.webkit.org/show_bug.cgi?id=188361
3383
3384         Reviewed by Daniel Bates.
3385
3386         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
3387
3388         * Scripts/webkitdirs.pm:
3389         (findOrCreateSimulatorForIOSDevice):
3390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3391         (parse_args):
3392             Update the help text for --device-type to reflect the new default device.
3393
3394 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3395
3396         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
3397         https://bugs.webkit.org/show_bug.cgi?id=188322
3398         <rdar://problem/42455270>
3399
3400         Reviewed by Tim Horton.
3401
3402         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
3403         was not in content view coordinates, unlike the x, y, and height.
3404
3405         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3406         (rounded):
3407         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
3408         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
3409         (TestWebKitAPI::TEST):
3410
3411 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
3412
3413         Unreviewed, rolling out r234569.
3414
3415         Breaks internal builds.
3416
3417         Reverted changeset:
3418
3419         "We should cache the compiled sandbox profile in a data vault"
3420         https://bugs.webkit.org/show_bug.cgi?id=184991
3421         https://trac.webkit.org/changeset/234569
3422
3423 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3424
3425         [Win][DLLLauncher] Remove --highDPI switch
3426         https://bugs.webkit.org/show_bug.cgi?id=188255
3427
3428         Reviewed by Yusuke Suzuki.
3429
3430         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
3431         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
3432         became useless since the change. Remove the switch.
3433
3434         This change fixes the issue all dump render tree tests are failing
3435         in WinCairo port if high DPI display is connected.
3436
3437         * MiniBrowser/win/Common.cpp:
3438         (parseCommandLine): Removed `--highDPI` switch.
3439         * win/DLLLauncher/DLLLauncherMain.cpp:
3440         (wWinMain): Do not call SetProcessDPIAware.
3441         (shouldUseHighDPI): Deleted.
3442
3443 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3444
3445         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
3446         https://bugs.webkit.org/show_bug.cgi?id=188335
3447         <rdar://problem/32542437> and <rdar://problem/32542433>
3448
3449         Reviewed by Tim Horton.
3450
3451         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
3452         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
3453         LayoutTests ChangeLog for more detail.
3454
3455         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3456         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3457         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3458         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3459         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3460         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
3461         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3462         * TestRunnerShared/spi/UIKitTestSPI.h:
3463
3464         Remove an internal class declaration that is now unnecessary.
3465
3466         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3467         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3468         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
3469
3470 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3471
3472         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
3473         https://bugs.webkit.org/show_bug.cgi?id=188322
3474         <rdar://problem/42455270>
3475
3476         Reviewed by Tim Horton.
3477
3478         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
3479         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
3480         selection views are hidden, and when first responder status is restored, both caret and range selection views
3481         are made visible again.
3482
3483         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3484         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3485         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3486         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3487         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3488         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3489         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3490         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3491         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3492         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
3493         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
3494         (webViewWithAutofocusedInput):
3495
3496         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
3497         immediately loading a web page with an autofocusing text field.
3498
3499         (TestWebKitAPI::TEST):
3500         * TestWebKitAPI/cocoa/TestWKWebView.h:
3501         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3502         (-[TestWKWebView caretViewRectInContentCoordinates]):
3503         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
3504         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3505         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3506         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3507
3508 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3509
3510         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
3511         https://bugs.webkit.org/show_bug.cgi?id=188334
3512         <rdar://problem/40630074>
3513
3514         Reviewed by Tim Horton.
3515
3516         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
3517         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
3518         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
3519         it to a completion block, and invoke the completion block to signal that the previous HID event has been
3520         processed.
3521
3522         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
3523         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
3524         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
3525         callback ID because the buffer was clamped to 8 bytes.
3526
3527         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
3528         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
3529         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
3530         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
3531         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
3532         be thrown.
3533
3534         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
3535
3536         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3537         (+[HIDEventGenerator nextEventCallbackID]):
3538         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3539
3540         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
3541
3542 2018-08-03  Ben Richards  <benton_richards@apple.com>
3543
3544         We should cache the compiled sandbox profile in a data vault
3545         https://bugs.webkit.org/show_bug.cgi?id=184991
3546
3547         Reviewed by Ryosuke Niwa.
3548
3549         Added trace points for sandbox initialization
3550
3551         * Tracing/SystemTracePoints.plist:
3552
3553 2018-08-03  David Fenton  <david_fenton@apple.com>
3554
3555         Unreviewed, rolling out r234517.
3556
3557         Caused API test failures on iOS
3558
3559         Reverted changeset:
3560
3561         "[Cocoa] setCookie API fails to set session cookies for
3562         defaultDataStore if processPool created but not used"
3563         https://bugs.webkit.org/show_bug.cgi?id=188209
3564         https://trac.webkit.org/changeset/234517
3565
3566 2018-08-03  Ben Richards  <benton_richards@apple.com>
3567
3568         Add configuration for automatic process pre-warming
3569         https://bugs.webkit.org/show_bug.cgi?id=187108
3570
3571         Reviewed by Ryosuke Niwa.
3572
3573         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
3574
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
3577         (TEST):
3578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3579         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
3580         (TEST):
3581
3582 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
3583
3584         [ews-build] Add build step to Check Patch Relevance
3585         https://bugs.webkit.org/show_bug.cgi?id=188295
3586
3587         Reviewed by Lucas Forschler.
3588
3589         * BuildSlaveSupport/ews-build/steps.py:
3590         (CheckPatchRelevance): Added step to check patch relevance.
3591         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
3592         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
3593         (CheckPatchRelevance._addToLog): Add the log message.
3594         (CheckPatchRelevance.start):
3595         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
3596
3597 2018-08-03  Jer Noble  <jer.noble@apple.com>
3598
3599         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
3600         media element is paused. Updating the test to reflect the new policy.
3601
3602         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3603         (TestWebKitAPI::TEST):
3604
3605 2018-08-03  Zalan Bujtas  <zalan@apple.com>
3606
3607         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
3608         https://bugs.webkit.org/show_bug.cgi?id=188306
3609
3610         Reviewed by Antti Koivisto.
3611
3612         * LayoutReloaded/misc/LFC-passing-tests.txt:
3613
3614 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3615
3616         [WPE] Use the new key mapper API from WPEBackend
3617         https://bugs.webkit.org/show_bug.cgi?id=188216
3618
3619         Reviewed by Žan Doberšek.
3620
3621         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3622         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
3623         code.
3624         * wpe/backends/WindowViewBackend.cpp:
3625         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3626         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
3627         (WPEToolingBackends::WindowViewBackend::modifiers const):
3628         * wpe/backends/WindowViewBackend.h:
3629
3630 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3631
3632         [WPE] Implement MouseEvent.buttons
3633         https://bugs.webkit.org/show_bug.cgi?id=187998
3634
3635         Reviewed by Žan Doberšek.
3636
3637         Pass modifiers to mouse events.
3638
3639         * WebKitTestRunner/EventSenderProxy.h:
3640         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3641         (WTR::senderButtonToWPEButton):
3642         (WTR::modifierForButton):
3643         (WTR::EventSenderProxy::mouseDown):
3644         (WTR::EventSenderProxy::mouseUp):
3645         (WTR::EventSenderProxy::mouseMoveTo):
3646         (WTR::EventSenderProxy::mouseScrollBy):
3647         (WTR::wkEventModifiersToWPE):
3648         (WTR::wpeKeySymForKeyRef):
3649         (WTR::EventSenderProxy::keyDown):
3650         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3651         * wpe/backends/WindowViewBackend.cpp:
3652         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
3653         (WPEToolingBackends::WindowViewBackend::modifiers const):
3654         * wpe/backends/WindowViewBackend.h:
3655
3656 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3657
3658         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
3659         https://bugs.webkit.org/show_bug.cgi?id=188093
3660
3661         Reviewed by Žan Doberšek.
3662
3663         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
3664         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3665         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
3666         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
3667         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
3668         * wpe/backends/WindowViewBackend.cpp:
3669         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
3670         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
3671
3672 2018-08-02  Nan Wang  <n_wang@apple.com>
3673
3674         AX: [iOS] add support to return the attributed string under the element
3675         https://bugs.webkit.org/show_bug.cgi?id=188276
3676         <rdar://problem/42872357>
3677
3678         Reviewed by Chris Fleizach.
3679
3680         * DumpRenderTree/AccessibilityUIElement.cpp:
3681         (attributedStringForElementCallback):
3682         (AccessibilityUIElement::getJSClass):
3683         * DumpRenderTree/AccessibilityUIElement.h:
3684         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3685         (AccessibilityUIElement::attributedStringForElement):
3686         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3687         (WTR::AccessibilityUIElement::attributedStringForElement):
3688         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3689         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3690         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3691         (WTR::AccessibilityUIElement::attributedStringForElement):
3692
3693 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
3694
3695         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
3696         https://bugs.webkit.org/show_bug.cgi?id=175204
3697
3698         Unreviewed test gardening.
3699
3700         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3701
3702 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
3703
3704         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
3705         https://bugs.webkit.org/show_bug.cgi?id=188209
3706
3707         Reviewed by Geoffrey Garen.
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3710         (TEST):
3711
3712 2018-08-02  Dan Bernstein  <mitz@apple.com>
3713
3714         Fixed WebKit.AttrStyle timing out on build.webkit.org.
3715
3716         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
3717           access to one that doesn’t.
3718         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
3719         (TEST): Updated expected value.
3720
3721 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3722
3723         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
3724         https://bugs.webkit.org/show_bug.cgi?id=188251
3725         <rdar://problem/37842108>
3726
3727         Reviewed by Tim Horton.
3728
3729         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
3730         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
3731
3732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3733         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
3734         (TestWebKitAPI::TEST):
3735         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
3736
3737         Pull some logic used to force an input session to start out from an existing API test file
3738         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
3739         new keyboard input test.
3740
3741         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3742         (-[AutofillTestView initWithFrame:]):
3743         (TestWebKitAPI::TEST):
3744         (-[TestInputDelegate init]): Deleted.
3745         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
3746         * TestWebKitAPI/ios/UIKitSPI.h:
3747
3748         Add some UIKit SPI utilized by the new API test.
3749
3750 2018-08-01  Dan Bernstein  <mitz@apple.com>
3751
3752         Optionally expose Attr::style to JavaScript
3753         https://bugs.webkit.org/show_bug.cgi?id=188226
3754         <rdar://problem/42818113>
3755
3756         Reviewed by Darin Adler.
3757
3758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3759         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
3760         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
3761         (TEST):
3762
3763 2018-08-02  David Fenton  <david_fenton@apple.com>
3764
3765         Unreviewed, rolling out r234489.
3766
3767         Caused 50+ crashes and 60+ API failures on iOS
3768
3769         Reverted changeset:
3770
3771         "[WTF] Rename String::format to String::deprecatedFormat"
3772         https://bugs.webkit.org/show_bug.cgi?id=188191
3773         https://trac.webkit.org/changeset/234489
3774
3775 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
3776
3777         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
3778         https://bugs.webkit.org/show_bug.cgi?id=188244
3779
3780         Reviewed by Daniel Bates.
3781
3782         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
3783
3784         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
3785
3786 2018-08-01  Tomas Popela  <tpopela@redhat.com>
3787
3788         [WTF] Rename String::format to String::deprecatedFormat
3789         https://bugs.webkit.org/show_bug.cgi?id=188191
3790
3791         Reviewed by Darin Adler.
3792
3793         It should be replaced with string concatenation.
3794
3795         * DumpRenderTree/win/DumpRenderTree.cpp:
3796         (applicationId):
3797         (main):
3798         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3799         (TestWebKitAPI::Util::createURLForResource):
3800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3801         (WTR::cacheTestRunnerCallback):
3802         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3803         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3804         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3805         (WTR::AccessibilityUIElement::attributedStringForRange):
3806         (WTR::AccessibilityUIElement::url):
3807         (WTR::stringAtOffset):
3808         * WebKitTestRunner/TestController.cpp:
3809         (WTR::TestController::didReceiveAuthenticationChallenge):
3810         (WTR::TestController::downloadDidFail):
3811         (WTR::originUserVisibleName):
3812         (WTR::userMediaOriginHash):
3813         (WTR::TestController::didNavigateWithNavigationData):
3814         (WTR::TestController::didPerformClientRedirect):
3815         (WTR::TestController::didPerformServerRedirect):
3816         (WTR::TestController::didUpdateHistoryTitle):
3817
3818 2018-08-01  Nan Wang  <n_wang@apple.com>
3819
3820         AX: AOM: Add ARIA IDL Attribute Reflection
3821         https://bugs.webkit.org/show_bug.cgi?id=184676
3822         <rdar://problem/39476882>
3823
3824         Reviewed by Chris Fleizach.
3825
3826         * DumpRenderTree/mac/DumpRenderTree.mm:
3827         (enableExperimentalFeatures):
3828         * WebKitTestRunner/TestController.cpp:
3829         (WTR::TestController::resetPreferencesToConsistentValues):
3830
3831 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
3832
3833         Use iPhone SE as the default simulated device
3834         https://bugs.webkit.org/show_bug.cgi?id=188227
3835
3836         Reviewed by Aakash Jain.
3837
3838         * Scripts/webkitpy/port/ios_simulator.py:
3839         (IOSSimulatorPort):
3840
3841 2018-08-01  Commit Queue  <commit-queue@webkit.org>
3842
3843         Unreviewed, rolling out r234443 and r234445.
3844         https://bugs.webkit.org/show_bug.cgi?id=188224
3845
3846         Revision caused 3 api failures across all platforms.
3847         (Requested by Truitt on #webkit).
3848
3849         Reverted changesets:
3850
3851         "Add configuration for automatic process pre-warming"
3852         https://bugs.webkit.org/show_bug.cgi?id=187108
3853         https://trac.webkit.org/changeset/234443
3854
3855         "Add configuration for automatic process pre-warming"
3856         https://bugs.webkit.org/show_bug.cgi?id=187108
3857         https://trac.webkit.org/changeset/234445
3858
3859 2018-07-31  Ben Richards  <benton_richards@apple.com>
3860
3861         Add configuration for automatic process pre-warming
3862         https://bugs.webkit.org/show_bug.cgi?id=187108
3863
3864         Reviewed by Ryosuke Niwa.
3865
3866         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
3867
3868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3870         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
3871         (TEST):
3872
3873 2018-07-31  John Wilander  <wilander@apple.com>
3874
3875         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
3876         https://bugs.webkit.org/show_bug.cgi?id=188109
3877         <rdar://problem/42664391>
3878
3879         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
3880
3881         This patch removes cookie partitioning which reduces the model to just
3882         blocked cookies (in third-party contexts) and first-party cookie access.
3883
3884         Several of the changes are renaming to reflect that there are no more
3885         cookie partitions.
3886
3887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3888            Removed or renamed functions to reflect that there are no more
3889            partitioned cookies.
3890         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3891         (WTR::InjectedBundle::didReceiveMessageToPage):
3892         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3893         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3894         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
3895         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
3896         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
3897         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
3898         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
3899         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
3900         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
3901         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3902         * WebKitTestRunner/TestController.cpp:
3903         (WTR::TestController::statisticsUpdateCookieBlocking):
3904         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
3905         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
3906         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
3907         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
3908         * WebKitTestRunner/TestController.h:
3909         * WebKitTestRunner/TestInvocation.cpp:
3910         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3911         (WTR::TestInvocation::didSetBlockCookiesForHost):
3912         (WTR::TestInvocation::didSetHasHadUserInteraction):
3913         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
3914         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
3915         * WebKitTestRunner/TestInvocation.h:
3916         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3917         (WTR::initializeWebViewConfiguration):
3918
3919 2018-07-31  Alex Christensen  <achristensen@webkit.org>
3920
3921         Build fix.  Remove unused variable.
3922
3923         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
3924         (TestWebKitAPI::TEST):
3925         transform was never used. It was introduced in r205871
3926         Apparently I'm the first one to build in a certain configuration that found it.
3927
3928 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3929
3930         server_process.py should print returncode in debug log if the process crashed
3931         https://bugs.webkit.org/show_bug.cgi?id=188160
3932
3933         Reviewed by Konstantin Tokarev.
3934
3935         * Scripts/webkitpy/port/server_process.py:
3936         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
3937
3938 2018-07-31  Tomas Popela  <tpopela@redhat.com>
3939
3940         [WTF] String::formatWithArguments() is unused
3941         https://bugs.webkit.org/show_bug.cgi?id=187955
3942
3943         Reviewed by Darin Adler.
3944
3945         Remove tests for WTF::String::formatWithArguments() as it's unused and
3946         we are removing it.
3947
3948         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3949
3950 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
3951
3952         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
3953
3954         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
3955         other builders.
3956
3957 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
3958
3959         [ews-build] Add support for API tests in OpenSource EWS
3960         https://bugs.webkit.org/show_bug.cgi?id=188156
3961
3962         Reviewed by Lucas Forschler.
3963
3964         * BuildSlaveSupport/ews-build/config.json:
3965         * BuildSlaveSupport/ews-build/factories.py:
3966         (BuildFactory.__init__): Added triggers parameter.
3967         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
3968         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
3969         (APITestsFactory): Factory for running API tests.
3970         * BuildSlaveSupport/ews-build/steps.py:
3971         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
3972         source of the property.
3973
3974 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
3975
3976         [ews-build] loadConfig should ensure that the triggers are valid
3977         https://bugs.webkit.org/show_bug.cgi?id=188134
3978
3979         Reviewed by Lucas Forschler.
3980
3981         * BuildSlaveSupport/ews-build/loadConfig.py:
3982         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
3983         (checkValidSchedulers): Ensures that the scheduler is not un-used.
3984         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3985
3986 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3987
3988         Unreviewed, fix typo in test expectations and mark another test as timing out
3989
3990         * TestWebKitAPI/glib/TestExpectations.json:
3991
3992 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3993
3994         More unreviewed GTK test gardening
3995
3996         * TestWebKitAPI/glib/TestExpectations.json:
3997
3998 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
3999
4000         Be more conservative with compositing layer creation when memory is low
4001         https://bugs.webkit.org/show_bug.cgi?id=187866
4002         rdar://problem/42366345
4003
4004         Reviewed by Zalan Bujtas.
4005         
4006         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
4007         compositing layers. We avoid compositing for these situations:
4008         1. Layers with 3D transforms which are affine (like translateZ(0)).
4009         2. Layers with will-change
4010         3. Layers for canvases (other than WebGL/WebGPU)
4011         
4012         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
4013         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
4014         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
4015         
4016         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
4017         flakily falling into a different mode, and so that we can impose the conservative
4018         mode for testing.
4019
4020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4021         (WTR::InjectedBundlePage::prepare):
4022
4023 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4024
4025         Unreviewed GTK test gardening
4026
4027         * TestWebKitAPI/glib/TestExpectations.json:
4028
4029 2018-07-27  Alex Christensen  <achristensen@webkit.org>
4030
4031         Fix API tests after r234314
4032         https://bugs.webkit.org/show_bug.cgi?id=188077
4033
4034         Make API tests use new delegate method.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4037         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4038         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4039
4040 2018-07-27  Alex Christensen  <achristensen@webkit.org>
4041
4042         Fix API tests after r234314
4043         https://bugs.webkit.org/show_bug.cgi?id=188077
4044
4045         Make API tests use new delegate method.
4046
4047         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4048         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4049         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4050         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4051         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4052         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4053         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4054         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4055         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4056         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4057         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4058
4059 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
4060
4061         [INTL] Remove INTL sub-feature compile flags
4062         https://bugs.webkit.org/show_bug.cgi?id=188081
4063
4064         Reviewed by Michael Catanzaro.
4065
4066         * Scripts/webkitperl/FeatureList.pm:
4067         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4068
4069 2018-07-26  Chris Dumez  <cdumez@apple.com>
4070
4071         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
4072         https://bugs.webkit.org/show_bug.cgi?id=188078
4073         <rdar://problem/42562493>
4074
4075         Reviewed by Geoff Garen.
4076
4077         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
4078         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
4079
4080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
4082         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
4083         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
4084         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
4085         (TEST):
4086
4087 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
4088
4089         Add Aaron Chu as a committer to contributors.json
4090         https://bugs.webkit.org/show_bug.cgi?id=188066
4091
4092         Unreviwed. Added myself as committer.
4093
4094         * Scripts/webkitpy/common/config/contributors.json:
4095
4096 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
4097
4098         [ews-build] Add build step to run API Tests
4099         https://bugs.webkit.org/show_bug.cgi?id=188079
4100
4101         Reviewed by Lucas Forschler.
4102
4103         * BuildSlaveSupport/ews-build/steps.py:
4104         (TestWithFailureCount): Common class for various tests with failure count.
4105         (TestWithFailureCount.start): Configure Buildbot's logobserver.
4106         (TestWithFailureCount.commandComplete): Updates the failure count.
4107         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
4108         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
4109         (RunAPITests): Build step to run API tests.
4110         (RunAPITests.countFailures): Count the failures by parsing the output.
4111         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4112
4113 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
4114
4115         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
4116         https://bugs.webkit.org/show_bug.cgi?id=187963
4117
4118         Reviewed by Alex Christensen.
4119
4120         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4121         Add tests for String::split and String::splitAllowingEmptyEntries.
4122
4123         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4124         * WebKitTestRunner/TestController.cpp:
4125         (WTR::updateTestOptionsFromTestHeader):
4126         Update split/splitAllowingEmptyEntries usage.
4127
4128 2018-07-26  Commit Queue  <commit-queue@webkit.org>
4129
4130         Unreviewed, rolling out r234181 and r234189.
4131         https://bugs.webkit.org/show_bug.cgi?id=188075
4132
4133         These are not needed right now (Requested by thorton on
4134         #webkit).
4135
4136         Reverted changesets:
4137
4138         "Enable Web Content Filtering on watchOS"
4139         https://bugs.webkit.org/show_bug.cgi?id=187979
4140         https://trac.webkit.org/changeset/234181
4141
4142         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
4143         https://bugs.webkit.org/show_bug.cgi?id=187985
4144         https://trac.webkit.org/changeset/234189
4145
4146 2018-07-04  Darin Adler  <darin@apple.com>
4147
4148         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
4149         https://bugs.webkit.org/show_bug.cgi?id=187333
4150
4151         Reviewed by Sam Weinig.
4152
4153         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
4154         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
4155         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
4156         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
4157         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
4158
4159 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
4160
4161         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
4162         https://bugs.webkit.org/show_bug.cgi?id=188031