Remove webkitpy and bindings test queues from old EWS
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2
3         Remove webkitpy and bindings test queues from old EWS
4         https://bugs.webkit.org/show_bug.cgi?id=197468
5
6         Reviewed by Alexey Proskuryakov.
7
8         * QueueStatusServer/config/queues.py:
9
10 2019-04-30  Tim Horton  <timothy_horton@apple.com>
11
12         Fix the WebKitTestRunner build
13         https://bugs.webkit.org/show_bug.cgi?id=197449
14         <rdar://problem/50334169>
15
16         Reviewed by Alexey Proskuryakov.
17
18         * WebKitTestRunner/mac/EventSenderProxy.mm:
19         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
20         (WTR::EventSenderProxy::mouseForceChanged):
21         Use some SPI instead of IPI.
22
23 2019-04-30  Chris Dumez  <cdumez@apple.com>
24
25         Regression(PSON) URL scheme handlers can no longer respond asynchronously
26         https://bugs.webkit.org/show_bug.cgi?id=197426
27         <rdar://problem/50256169>
28
29         Reviewed by Brady Eidson.
30
31         Add API test coverage.
32
33         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
34         (-[PSONScheme setShouldRespondAsynchronously:]):
35         (-[PSONScheme webView:startURLSchemeTask:]):
36         (-[PSONScheme webView:stopURLSchemeTask:]):
37
38 2019-04-30  Chris Dumez  <cdumez@apple.com>
39
40         Unreviewed, rolling out r244802.
41
42         Caused an API test failure
43
44         Reverted changeset:
45
46         "Regression(PSON) URL scheme handlers can no longer respond
47         asynchronously"
48         https://bugs.webkit.org/show_bug.cgi?id=197426
49         https://trac.webkit.org/changeset/244802
50
51 2019-04-30  Chris Dumez  <cdumez@apple.com>
52
53         Regression(PSON) URL scheme handlers can no longer respond asynchronously
54         https://bugs.webkit.org/show_bug.cgi?id=197426
55         <rdar://problem/50256169>
56
57         Reviewed by Brady Eidson.
58
59         Add API test coverage.
60
61         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
62         (-[PSONScheme setShouldRespondAsynchronously:]):
63         (-[PSONScheme webView:startURLSchemeTask:]):
64         (-[PSONScheme webView:stopURLSchemeTask:]):
65
66 2019-04-30  Chris Dumez  <cdumez@apple.com>
67
68         Only use a related page's process if that page has not been closed yet
69         https://bugs.webkit.org/show_bug.cgi?id=197393
70         <rdar://problem/50302423>
71
72         Reviewed by Tim Horton.
73
74         Add API test coverage.
75
76         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
77
78 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
79
80         [ews-build] Enable Bindings tests queue on new EWS
81         https://bugs.webkit.org/show_bug.cgi?id=197424
82
83         Reviewed by Lucas Forschler.
84
85         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
86         (StatusBubble):
87         * BuildSlaveSupport/ews-build/config.json:
88
89 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews-build] Configure ews151 for running various tests
92         https://bugs.webkit.org/show_bug.cgi?id=197419
93
94         Reviewed by Lucas Forschler.
95
96         * BuildSlaveSupport/ews-build/config.json:
97
98 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-build] Parse and display bindings test failures
101         https://bugs.webkit.org/show_bug.cgi?id=197423
102
103         Reviewed by Lucas Forschler.
104
105         * BuildSlaveSupport/ews-build/steps.py:
106         (RunBindingsTests.__init__): Set timeout of 5 minutes.
107         (RunBindingsTests.start): Initialize log_observer for json output.
108         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
109         (RunBindingsTests._addToLog): Method to add message to log.
110         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
111
112 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
113
114         Unreviewed. Add myself as a committer.
115
116         * Scripts/webkitpy/common/config/contributors.json:
117
118 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
119
120         [ews-build] Enable webkitpy queue on new EWS
121         https://bugs.webkit.org/show_bug.cgi?id=197396
122
123         Reviewed by Lucas Forschler.
124
125         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
126         (StatusBubble):
127         * BuildSlaveSupport/ews-build/config.json:
128
129 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
130
131         [ews-build] Parse and display webkitpy failures
132         https://bugs.webkit.org/show_bug.cgi?id=197395
133
134         Reviewed by Lucas Forschler.
135
136         * BuildSlaveSupport/ews-build/steps.py:
137         (RunWebKitPyTests.start): Initialize log_observer for json output.
138         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
139         (RunWebKitPyTests._addToLog): Method to add message to log.
140         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
141
142 2019-04-29  Alex Christensen  <achristensen@webkit.org>
143
144         <rdar://problem/50299396> Fix internal High Sierra build
145         https://bugs.webkit.org/show_bug.cgi?id=197388
146
147         * DumpRenderTree/mac/Configurations/Base.xcconfig:
148         * MiniBrowser/Configurations/Base.xcconfig:
149         * MobileMiniBrowser/Configurations/Base.xcconfig:
150         * TestWebKitAPI/Configurations/Base.xcconfig:
151         * WebKitTestRunner/Configurations/Base.xcconfig:
152
153 2019-04-29  Youenn Fablet  <youenn@apple.com>
154
155         Remove spurious GVA printf logging
156         https://bugs.webkit.org/show_bug.cgi?id=197368
157         <rdar://problem/35975256>
158
159         Reviewed by Alexey Proskuryakov.
160
161         * Scripts/webkitpy/port/mac.py:
162         (MacPort.logging_patterns_to_strip):
163
164 2019-04-29  Youenn Fablet  <youenn@apple.com>
165
166         getDisplayMedia should be called on user gesture
167         https://bugs.webkit.org/show_bug.cgi?id=197356
168         <rdar://problem/50296074>
169
170         Reviewed by Eric Carlson.
171
172         Update test configuration to inject internals
173         so that we can use it to simulate a user click to call getDisplayMedia.
174
175         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
176         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
177         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
178
179 2019-04-26  Stephanie Lewis  <slewis@apple.com>
180
181         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
182         https://bugs.webkit.org/show_bug.cgi?id=197339
183
184         Reviewed by Dewei Zhu.
185
186         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
187         test run for setup steps that are too expensive to do every iteration.
188
189         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
190         (BenchmarkRunner._run_benchmark):
191         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
192         (BrowserDriver):
193         (BrowserDriver.prepare_initial_env):
194         (BrowserDriver.restore_env_after_all_testing):
195         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
196         (LinuxBrowserDriver.prepare_initial_env):
197         (LinuxBrowserDriver.restore_env_after_all_testing):
198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
199         (OSXBrowserDriver.prepare_initial_env):
200         (OSXBrowserDriver.restore_env_after_all_testing):
201
202 2019-04-28  Andy Estes  <aestes@apple.com>
203
204         Fix the watchOS engineering build.
205
206         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
207         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
208
209 2019-04-27  Chris Dumez  <cdumez@apple.com>
210
211         [WKTR] Move test timeout handling to the UIProcess
212         https://bugs.webkit.org/show_bug.cgi?id=197333
213
214         Reviewed by Darin Adler.
215
216         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
217         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
218         every WebContent process in the case of swapping.
219
220         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
221         would lead to crashes when firing the timer.
222
223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
224         (WTR::InjectedBundle::didReceiveMessageToPage):
225         (WTR::InjectedBundle::done):
226         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
227         (WTR::InjectedBundle::shouldDumpPixels const):
228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
229         (WTR::TestRunner::TestRunner):
230         (WTR::TestRunner::waitUntilDone):
231         (WTR::TestRunner::setWaitUntilDone):
232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
233         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
234         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
235         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
236         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
237         * WebKitTestRunner/TestInvocation.cpp:
238         (WTR::TestInvocation::TestInvocation):
239         (WTR::TestInvocation::createTestSettingsDictionary):
240         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
241         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
242         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
243         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
244         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
245         (WTR::TestInvocation::setWaitUntilDone):
246         (WTR::TestInvocation::done):
247         * WebKitTestRunner/TestInvocation.h:
248
249 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
250
251         [JSC] linkPolymorphicCall now does GC
252         https://bugs.webkit.org/show_bug.cgi?id=197306
253
254         Reviewed by Saam Barati.
255
256         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
257         To add this test, we add `runWithoutBaseOption`.
258
259         * Scripts/run-jsc-stress-tests:
260
261 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
262
263         Update inactive reviewers' status to 'contributor'.
264
265         Accidentally skipped one at first.
266
267         * Scripts/webkitpy/common/config/contributors.json:
268
269 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
270
271         Update inactive reviewers' status to 'contributor'.
272
273         * Scripts/webkitpy/common/config/contributors.json: The change.
274
275         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
276         * Scripts/webkitpy/common/checkout/checkout_mock.py:
277         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
278         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
279         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
280         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
281         * Scripts/webkitpy/tool/commands/queries_unittest.py:
282         * Scripts/webkitpy/tool/commands/upload_unittest.py:
283         Sadly, regression tests operate on a crazy mix of mock and live data for
284         contributors.json. It would be a substantial project to mock all code paths,
285         so changing the tests instead.
286
287 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
288
289         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
290         https://bugs.webkit.org/show_bug.cgi?id=197171
291         <rdar://problem/47454979>
292
293         Reviewed by Youenn Fablet.
294
295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
296         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
297         (TestWebKitAPI::TEST):
298
299 2019-04-26  David Kilzer  <ddkilzer@apple.com>
300
301         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
302         <https://webkit.org/b/197314>
303         <rdar://problem/50245252>
304
305         Reviewed by Simon Fraser.
306
307         * WebKitTestRunner/UIScriptControllerCocoa.mm:
308         (WTR::UIScriptController::lastUndoLabel const):
309         (WTR::UIScriptController::firstRedoLabel const):
310         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
311
312         * WebKitTestRunner/ios/HIDEventGenerator.mm:
313         (-[HIDEventGenerator sendEventStream:completionBlock:]):
314         - Call -autorelease to fix leak of NSDictionary.
315
316         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
317         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
318         (WTR::UIScriptController::selectFormPopoverTitle const):
319         (WTR::UIScriptController::textContentType const):
320         (WTR::UIScriptController::formInputLabel const):
321         (WTR::UIScriptController::scrollingTreeAsText const):
322         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
323
324 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
325
326         webkitpy: Running a single test will always use the default device
327         https://bugs.webkit.org/show_bug.cgi?id=195472
328         <rdar://problem/48724825>
329
330         Reviewed by Lucas Forschler.
331
332         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
333         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
334         requested will be run regardless of what shard they are in.
335
336         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
337         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
338         * Scripts/webkitpy/layout_tests/controllers/manager.py:
339         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
340         on the default device type.
341         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
342         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
343         (RunTest.test_run_part): Ditto.
344
345 2019-04-26  Alex Christensen  <achristensen@webkit.org>
346
347         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
348         https://bugs.webkit.org/show_bug.cgi?id=197165
349
350         Reviewed by Youenn Fablet.
351
352         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
353
354 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
355
356         Replace iOS build queue hardware
357         https://bugs.webkit.org/show_bug.cgi?id=197312
358
359         Reviewed by Aakash Jain.
360
361         * BuildSlaveSupport/build.webkit.org-config/config.json:
362         Use newer hardware that supports macOS Mojave.
363
364 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
365
366         check-webkit-style complains the first block in while loop.
367         https://bugs.webkit.org/show_bug.cgi?id=197307
368
369         The style checker shouldn't complain about an open brace on
370         its own line if the last non-whitespace character on the previous
371         non-blank line is another open brace, because it's likely to
372         indicate the begining of a nested code block.
373
374         Reviewed by Alex Christensen.
375
376         * Scripts/webkitpy/style/checkers/cpp.py:
377         (check_braces):
378         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
379         (WebKitStyleTest.test_braces):
380
381 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
382
383         Stop IDB transactions to release locked database files when network process is ready to suspend
384         https://bugs.webkit.org/show_bug.cgi?id=196372
385         <rdar://problem/48930116>
386
387         Reviewed by Brady Eidson.
388
389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
390         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
391         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
392         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
393         (runTestAndCheckResult):
394         (keepNetworkProcessActive):
395         (TEST):
396
397 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
398
399         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
400         https://bugs.webkit.org/show_bug.cgi?id=188357
401         <rdar://problem/42986633>
402
403         Reviewed by Dean Jackson.
404
405         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
406         tests would fall into low memory mode and have different behavior.
407         
408         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
409         to Internals, so it's shared by DRT and WTR.
410         
411         We no longer need the WK2 C SPI glue.
412
413         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
414         (WTR::InjectedBundlePage::prepare):
415
416 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
417
418         webkitpy: Including skipped tests in the final count
419         https://bugs.webkit.org/show_bug.cgi?id=197298
420         <rdar://problem/49705424>
421
422         Reviewed by Lucas Forschler.
423
424         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
425         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
426
427 2019-04-25  Timothy Hatcher  <timothy@apple.com>
428
429         Disable date and time inputs on iOSMac.
430         https://bugs.webkit.org/show_bug.cgi?id=197287
431         rdar://problem/46794376
432
433         Reviewed by Wenson Hsieh.
434
435         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
436
437 2019-04-25  Alex Christensen  <achristensen@webkit.org>
438
439         Fix test-webkitpy after r244653
440         https://bugs.webkit.org/show_bug.cgi?id=197131
441
442         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
443         Also use C++17.
444
445 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
446
447         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
448         https://bugs.webkit.org/show_bug.cgi?id=196991
449         <rdar://problem/45507423>
450
451         Reviewed by Alex Christensen.
452
453         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
454         (-[NavigationTestDelegate init]):
455         (-[NavigationTestDelegate waitForDidFinishNavigation]):
456         (-[NavigationTestDelegate webView:didFinishNavigation:]):
457         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
458         (TestWebKitAPI::TEST):
459         (TEST): Deleted.
460
461 2019-04-25  Alex Christensen  <achristensen@webkit.org>
462
463         Revert some code accidentally committed with r244653
464         https://bugs.webkit.org/show_bug.cgi?id=197131
465
466         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
467         (TestWebKitAPI::TEST):
468
469 2019-04-25  Alex Christensen  <achristensen@webkit.org>
470
471         Start using C++17
472         https://bugs.webkit.org/show_bug.cgi?id=197131
473
474         Reviewed by Darin Adler.
475
476         * DumpRenderTree/mac/Configurations/Base.xcconfig:
477         * MiniBrowser/Configurations/Base.xcconfig:
478         * MobileMiniBrowser/Configurations/Base.xcconfig:
479         * TestWebKitAPI/Configurations/Base.xcconfig:
480         * WebKitTestRunner/Configurations/Base.xcconfig:
481
482 2019-04-25  Commit Queue  <commit-queue@webkit.org>
483
484         Unreviewed, rolling out r244627.
485         https://bugs.webkit.org/show_bug.cgi?id=197282
486
487         Causing internal build failures (Requested by ShawnRoberts on
488         #webkit).
489
490         Reverted changeset:
491
492         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
493         https://bugs.webkit.org/show_bug.cgi?id=197171
494         https://trac.webkit.org/changeset/244627
495
496 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
497
498         [GTK] Hardcoded text color in input fields
499         https://bugs.webkit.org/show_bug.cgi?id=126907
500
501         Reviewed by Michael Catanzaro.
502
503         Add dark-mode command line option to MiniBrowser.
504
505         * MiniBrowser/gtk/main.c:
506         (main):
507
508 2019-04-24  Zalan Bujtas  <zalan@apple.com>
509
510         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
511         https://bugs.webkit.org/show_bug.cgi?id=196948
512         <rdar://problem/49927131>
513
514         Reviewed by Tim Horton.
515
516         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
517         (TEST):
518         The expected order of incoming events is
519         1. didInvalidateIntrinsicContentSize
520         2. didFirstLayout
521         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
522         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
523         (and remember, all we care about is ordering).
524
525 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
526
527         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
528         https://bugs.webkit.org/show_bug.cgi?id=197171
529         <rdar://problem/47454979>
530
531         Reviewed by Youenn Fablet.
532
533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
534         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
535         (TestWebKitAPI::TEST):
536
537 2019-04-24  Brady Eidson  <beidson@apple.com>
538
539         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
540         https://bugs.webkit.org/show_bug.cgi?id=191362
541
542         Reviewed by Alex Christensen.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
545           from an XHR to a custom protocol.
546
547 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
548
549         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
550         https://bugs.webkit.org/show_bug.cgi?id=197273
551
552         Reviewed by Dean Jackson.
553
554         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
555         so that WebCoreTestSupport::resetInternalsObject() is always run.
556
557         * DumpRenderTree/mac/DumpRenderTree.mm:
558         (resetWebViewToConsistentStateBeforeTesting):
559         (runTest):
560
561 2019-04-24  John Wilander  <wilander@apple.com>
562
563         Age out unconverted Ad Click Attributions after one week.
564         https://bugs.webkit.org/show_bug.cgi?id=197238
565         <rdar://problem/50177349>
566
567         Reviewed by Chris Dumez.
568
569         This patch adds infrastructure to allow tests to expire all unconverted
570         attributions early.
571
572         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
573         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
574         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
576         * WebKitTestRunner/TestController.cpp:
577         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
578         * WebKitTestRunner/TestController.h:
579         * WebKitTestRunner/TestInvocation.cpp:
580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
581
582 2019-04-24  Chris Dumez  <cdumez@apple.com>
583
584         Fix flaky crashes in a couple of PSON API tests
585         https://bugs.webkit.org/show_bug.cgi?id=197239
586
587         Reviewed by Tim Horton.
588
589         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
590
591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
592
593 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
594
595         Make it possible to control the renderTreeAsText output by setting options on testRunner
596         https://bugs.webkit.org/show_bug.cgi?id=197133
597
598         Reviewed by Sam Weinig.
599
600         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
601         that make sense in testing (those that don't dump unstable data like addresses), and plumb
602         these flags through the various framework layers.
603
604         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
605
606         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
607         and hand-code DumpRenderTree bindings.
608
609         Some cleanup of the TestRunners, using member initializers.
610
611         * DumpRenderTree/TestRunner.cpp:
612         (TestRunner::TestRunner):
613         (setRenderTreeDumpOptionsCallback):
614         (TestRunner::staticFunctions):
615         (TestRunner::setRenderTreeDumpOptions):
616         * DumpRenderTree/TestRunner.h:
617         (TestRunner::renderTreeDumpOptions const):
618         * DumpRenderTree/mac/DumpRenderTree.mm:
619         (dump):
620         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
621         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
622         (WTR::InjectedBundlePage::dump):
623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
624         (WTR::TestRunner::TestRunner):
625         (WTR::TestRunner::setRenderTreeDumpOptions):
626         * WebKitTestRunner/InjectedBundle/TestRunner.h:
627         (WTR::TestRunner::renderTreeDumpOptions const):
628
629 2019-04-24  Alex Christensen  <achristensen@webkit.org>
630
631         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
632         https://bugs.webkit.org/show_bug.cgi?id=197078
633         <rdar://problem/49564348>
634
635         Reviewed by Geoff Garen.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
638         (TEST_F):
639         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
640         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
641         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
642
643 2019-04-24  Alex Christensen  <achristensen@webkit.org>
644
645         Add unit test for r239322
646         https://bugs.webkit.org/show_bug.cgi?id=197236
647
648         Reviewed by Chris Dumez.
649
650         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
651         May as well add the test infrastructure which was needed before and will be needed in the future.
652
653         * TestWebKitAPI/TCPServer.cpp:
654         (TestWebKitAPI::TCPServer::TCPServer):
655         * TestWebKitAPI/TCPServer.h:
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
657         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
658         (TestWebKitAPI::TEST):
659         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
660         (TestWebKitAPI::downloadAtRate):
661         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
662         (TEST):
663         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
664         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
665         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
666         (TestWebKitAPI::TEST):
667         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
668         (TEST):
669
670 2019-04-24  Chris Dumez  <cdumez@apple.com>
671
672         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
673         https://bugs.webkit.org/show_bug.cgi?id=197214
674         <rdar://problem/49237544>
675
676         Reviewed by Alex Christensen.
677
678         Extend API test coverage.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
681         (TEST):
682
683 2019-04-24  Philippe Normand  <pnormand@igalia.com>
684
685         [Build][GStreamer] Update to 1.16.0
686         https://bugs.webkit.org/show_bug.cgi?id=197157
687
688         Reviewed by Xabier Rodriguez-Calvar.
689
690         The upstreamed patches were removed and a new one was added for a
691         regression detected in the scaletempo GStreamer element. The GNOME
692         Flatpak was migrated to 3.32 and I switched a few modules to Meson
693         on the way, as it is the preferred build system now in GStreamer
694         1.16.
695
696         * flatpak/files/httpd-autogen.sh:
697         * flatpak/flatpakutils.py:
698         (FlatpakPackage.install):
699         (WebkitFlatpak.run_in_sandbox):
700         * flatpak/org.webkit.CommonModules.yaml:
701         * flatpak/org.webkit.WebKit.yaml:
702         * gstreamer/jhbuild.modules:
703         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
704         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
705         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
706         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
707         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
708         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
709         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
710         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
711         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
712         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
713         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
714         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
715         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
716         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
717         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
718         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
719         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
720         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
721         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
722         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
723         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
724         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
725
726 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
729         https://bugs.webkit.org/show_bug.cgi?id=197156
730
731         Reviewed by Michael Catanzaro.
732
733         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
734         support was added.
735
736         * MiniBrowser/gtk/BrowserTab.c:
737         (browser_tab_set_background_color): Set the passed in color as web view background color.
738         * MiniBrowser/gtk/BrowserTab.h:
739         * MiniBrowser/gtk/BrowserWindow.c:
740         (browser_window_init): Initialize backgroundColor.
741         (browser_window_append_view): Call browser_tab_set_background_color().
742         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
743         are added.
744         * MiniBrowser/gtk/main.c:
745         (main): Call browser_window_set_background_color() before creating the tabs.
746
747 2019-04-23  John Wilander  <wilander@apple.com>
748
749         Move Ad Click Attribution from internal feature to experimental feature
750         https://bugs.webkit.org/show_bug.cgi?id=197218
751         <rdar://problem/47651691>
752
753         Reviewed by Brent Fulgham.
754
755         * DumpRenderTree/TestOptions.cpp:
756         (TestOptions::TestOptions):
757
758 2019-04-23  Andy Estes  <aestes@apple.com>
759
760         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
761         https://bugs.webkit.org/show_bug.cgi?id=196749
762         <rdar://problem/35773454>
763
764         Reviewed by Daniel Bates.
765
766         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
769         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
770         (-[QuickLookDelegate webView:didFinishNavigation:]):
771         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
772         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
773         (runTest):
774         (runTestDecideBeforeLoading):
775         (runTestDecideAfterLoading):
776         (TEST):
777
778 2019-04-23  John Wilander  <wilander@apple.com>
779
780         Remove Ad Click Attribution data when removing website data
781         https://bugs.webkit.org/show_bug.cgi?id=197215
782         <rdar://problem/47668988>
783
784         Reviewed by Chris Dumez.
785
786         This patch adds test infrastructure to delete Ad Click Attribution data
787         through WebsiteDataStore::removeData().
788
789         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
790         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
791         (WTR::TestRunner::clearAdClickAttribution):
792         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
793         * WebKitTestRunner/InjectedBundle/TestRunner.h:
794         * WebKitTestRunner/TestController.cpp:
795         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
796         * WebKitTestRunner/TestController.h:
797         * WebKitTestRunner/TestInvocation.cpp:
798         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
799
800 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
801
802         webkitpy: Kill unresponsive worker processes
803         https://bugs.webkit.org/show_bug.cgi?id=197205
804         <rdar://problem/50104388>
805
806         Reviewed by Lucas Forschler.
807
808         * Scripts/webkitpy/common/message_pool.py:
809         (_MessagePool.__init__): Add close timeout.
810         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
811
812 2019-04-23  Alex Christensen  <achristensen@webkit.org>
813
814         Add unit tests for WKWebView.serverTrust
815         https://bugs.webkit.org/show_bug.cgi?id=197202
816
817         Reviewed by Youenn Fablet
818
819         * TestWebKitAPI/TCPServer.cpp:
820         (TestWebKitAPI::deleter<BIO>::operator()):
821         (TestWebKitAPI::deleter<SSL>::operator()):
822         (TestWebKitAPI::deleter<X509>::operator()):
823         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
824         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
825         (TestWebKitAPI::TCPServer::TCPServer):
826         (TestWebKitAPI::TCPServer::listenForConnections):
827         * TestWebKitAPI/TCPServer.h:
828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
829         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
830         (TestWebKitAPI::TEST):
831         (verifyCertificateAndPublicKey):
832         (-[ServerTrustDelegate webView:didFinishNavigation:]):
833         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
834         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
835         (TestWebKitAPI::downloadAtRate):
836         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
837         (TEST):
838         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
839         (TEST):
840
841 2019-04-23  Commit Queue  <commit-queue@webkit.org>
842
843         Unreviewed, rolling out r244556.
844         https://bugs.webkit.org/show_bug.cgi?id=197212
845
846         Causing build failures on multiple builders (Requested by
847         ShawnRoberts on #webkit).
848
849         Reverted changeset:
850
851         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
852         https://bugs.webkit.org/show_bug.cgi?id=197171
853         https://trac.webkit.org/changeset/244556
854
855 2019-04-23  Alex Christensen  <achristensen@webkit.org>
856
857         Fix iOS build.
858         https://bugs.webkit.org/show_bug.cgi?id=195537
859
860         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
861         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
862         AdoptWK constructor is private now.  Use adoptWK instead.
863
864 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
865
866         Accessibility text search and selection API enhancements.
867         https://bugs.webkit.org/show_bug.cgi?id=197095
868         <rdar://problem/48181791>
869
870         Reviewed by Chris Fleizach.
871
872         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
873
874         * DumpRenderTree/AccessibilityTextMarker.h:
875         * DumpRenderTree/AccessibilityUIElement.cpp:
876         (searchTextWithCriteriaCallback):
877         (AccessibilityUIElement::getJSClass):
878         * DumpRenderTree/AccessibilityUIElement.h:
879         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
880         (convertVectorToObjectArray):
881         (convertNSArrayToVector):
882         (searchTextParameterizedAttributeForCriteria):
883         (AccessibilityUIElement::getLinkedUIElements):
884         (AccessibilityUIElement::getDocumentLinks):
885         (AccessibilityUIElement::getChildren):
886         (AccessibilityUIElement::getChildrenWithRange):
887         (AccessibilityUIElement::rowHeaders const):
888         (AccessibilityUIElement::columnHeaders const):
889         (AccessibilityUIElement::uiElementArrayAttributeValue const):
890         (AccessibilityUIElement::searchTextWithCriteria):
891         (AccessibilityUIElement::attributesOfColumnHeaders):
892         (AccessibilityUIElement::attributesOfRowHeaders):
893         (AccessibilityUIElement::attributesOfColumns):
894         (AccessibilityUIElement::attributesOfRows):
895         (AccessibilityUIElement::attributesOfVisibleCells):
896         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
897         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
898         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
899         (WTR::convertVectorToObjectArray):
900         (WTR::convertNSArrayToVector):
901         (WTR::searchTextParameterizedAttributeForCriteria):
902         (WTR::AccessibilityUIElement::getLinkedUIElements):
903         (WTR::AccessibilityUIElement::getDocumentLinks):
904         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
905         (WTR::AccessibilityUIElement::getChildren):
906         (WTR::AccessibilityUIElement::getChildrenWithRange):
907         (WTR::AccessibilityUIElement::rowHeaders const):
908         (WTR::AccessibilityUIElement::columnHeaders const):
909         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
910         (WTR::AccessibilityUIElement::searchTextWithCriteria):
911         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
912         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
913         (WTR::AccessibilityUIElement::attributesOfColumns):
914         (WTR::AccessibilityUIElement::attributesOfRows):
915         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
916         (WTR::convertElementsToObjectArray): Deleted.
917
918 2019-04-23  Guy Lewin  <guy@lewin.co.il>
919
920         Multiple File Input Icon Set Regardless of File List
921         https://bugs.webkit.org/show_bug.cgi?id=195537
922
923         Reviewed by Alexey Proskuryakov.
924
925         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
926         display string in iOS file inputs
927
928         * DumpRenderTree/TestRunner.cpp:
929         (SetOpenPanelFilesMediaIconCallback):
930         (TestRunner::staticFunctions):
931         (TestRunner::setOpenPanelFilesMediaIcon):
932         * DumpRenderTree/TestRunner.h:
933         (TestRunner::openPanelFilesMediaIcon const):
934         * DumpRenderTree/mac/UIDelegate.mm:
935         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
936         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
938         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
939         * WebKitTestRunner/InjectedBundle/TestRunner.h:
940         * WebKitTestRunner/TestController.cpp:
941         (WTR::runOpenPanel):
942         (WTR::TestController::resetStateToConsistentValues):
943         * WebKitTestRunner/TestController.h:
944         (WTR::TestController::openPanelFileURLsMediaIcon const):
945         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
946         * WebKitTestRunner/TestInvocation.cpp:
947         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
948
949 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
950
951         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
952         https://bugs.webkit.org/show_bug.cgi?id=197171
953         <rdar://problem/47454979>
954
955         Reviewed by Youenn Fablet.
956
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
958         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
959         (TestWebKitAPI::TEST):
960
961 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
962
963         [ews-build] Add unit tests for UnApplyPatchIfRequired
964         https://bugs.webkit.org/show_bug.cgi?id=197197
965
966         Reviewed by Lucas Forschler.
967
968         * BuildSlaveSupport/ews-build/steps_unittest.py:
969         (TestUnApplyPatchIfRequired):
970         (TestUnApplyPatchIfRequired.test_success):
971         (TestUnApplyPatchIfRequired.test_failure):
972         (TestUnApplyPatchIfRequired.test_skip):
973
974 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-build] Add unit tests for CleanWorkingDirectory
977         https://bugs.webkit.org/show_bug.cgi?id=197195
978
979         Reviewed by Lucas Forschler.
980
981         * BuildSlaveSupport/ews-build/steps_unittest.py:
982         (TestCleanWorkingDirectory):
983         (TestCleanWorkingDirectory.test_success):
984         (TestCleanWorkingDirectory.test_failure):
985
986 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] Use explicit imports instead of wildcard imports
989         https://bugs.webkit.org/show_bug.cgi?id=197194
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-build/factories.py:
994         * BuildSlaveSupport/ews-build/loadConfig.py:
995         * BuildSlaveSupport/ews-build/steps_unittest.py:
996
997 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-build] Add unit tests for DownloadBuiltProduct
1000         https://bugs.webkit.org/show_bug.cgi?id=197193
1001
1002         Reviewed by Lucas Forschler.
1003
1004         * BuildSlaveSupport/ews-build/steps_unittest.py:
1005         (TestDownloadBuiltProduct):
1006         (TestDownloadBuiltProduct.setUp):
1007         (TestDownloadBuiltProduct.tearDown):
1008         (TestDownloadBuiltProduct.test_success):
1009         (TestDownloadBuiltProduct.test_failure):
1010
1011 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1012
1013         [ews-app] Exception while loading status-bubble when no build step has started
1014         https://bugs.webkit.org/show_bug.cgi?id=196676
1015
1016         Reviewed by Lucas Forschler.
1017
1018         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1019         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1020
1021 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1022
1023         [PlayStation] Support running of JSC tests on remote playstation devices
1024         https://bugs.webkit.org/show_bug.cgi?id=197170
1025
1026         Reviewed by Ross Kirsling.
1027
1028         Script changes
1029
1030         * Scripts/run-javascriptcore-tests:
1031         (runJSCStressTests): Pass arguments for playstation to
1032         run-jsc-stress-tests
1033         * Scripts/run-jsc-stress-tests:
1034         Handle $hostOS=="playstation" for determineArchitecture, turning
1035         off $isFTLPlatform and runProfiler and defaulting test writer.
1036         * Scripts/webkitdirs.pm:
1037         (jscPath): PlayStation WebKit executables have .elf extension
1038         (executableProductDir): PlayStation builds on Windows hosts but
1039         uses bin directory rather than bin64/bin32 for executable output
1040         location.
1041         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1042
1043 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1044
1045         [CMake][Win] Use target oriented design for WebKit
1046         https://bugs.webkit.org/show_bug.cgi?id=197173
1047
1048         Reviewed by Alex Christensen.
1049
1050         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1051         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1052
1053 2019-04-23  Chris Dumez  <cdumez@apple.com>
1054
1055         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1056         https://bugs.webkit.org/show_bug.cgi?id=197097
1057         <rdar://problem/50048318>
1058
1059         Reviewed by Alex Christensen.
1060
1061         Add API test coverage.
1062
1063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1064         (-[PSONScheme webView:startURLSchemeTask:]):
1065
1066 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1067
1068         [ATK] Implement AtkComponentIface scroll_to methods
1069         https://bugs.webkit.org/show_bug.cgi?id=196856
1070
1071         Reviewed by Michael Catanzaro.
1072
1073         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1074         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1075         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1076         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1077
1078 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1079
1080         [ews-build] Improve summary for UploadBuiltProduct step
1081         https://bugs.webkit.org/show_bug.cgi?id=197182
1082
1083         Reviewed by Lucas Forschler.
1084
1085         * BuildSlaveSupport/ews-build/steps.py:
1086         (UploadBuiltProduct): Added descriptionDone.
1087         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1088         * BuildSlaveSupport/ews-build/steps_unittest.py:
1089         (TestUploadBuiltProduct.test_success): Updated unit-test.
1090         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1091
1092 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1093
1094         [ews-build] Trigger queues only after uploading the archive
1095         https://bugs.webkit.org/show_bug.cgi?id=197180
1096
1097         Reviewed by Lucas Forschler.
1098
1099         * BuildSlaveSupport/ews-build/factories.py:
1100         (Factory.__init__):
1101         (BuildFactory.__init__): Remove trigger step from factories.
1102         (BuildFactory.propertiesToPassToTriggers): Deleted.
1103         * BuildSlaveSupport/ews-build/steps.py:
1104         (ConfigureBuild.__init__): Confiure triggers property.
1105         (Trigger): Step to trigger other queues.
1106         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1107         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1108
1109 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1110
1111         Deprecate WKContextCreateWithInjectedBundlePath
1112         https://bugs.webkit.org/show_bug.cgi?id=197169
1113
1114         Reviewed by Youenn Fablet.
1115
1116         * TestWebKitAPI/PlatformUtilities.cpp:
1117         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1118         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1119
1120 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1121
1122         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1123         https://bugs.webkit.org/show_bug.cgi?id=197093
1124         <rdar://problem/49708268>
1125
1126         Reviewed by Chris Dumez.
1127
1128         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1129         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1130         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1131         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1132         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1133
1134         * TestWebKitAPI/TCPServer.cpp:
1135         (TestWebKitAPI::TCPServer::TCPServer):
1136         (TestWebKitAPI::TCPServer::~TCPServer):
1137         (TestWebKitAPI::TCPServer::socketBindListen):
1138         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1139         * TestWebKitAPI/TCPServer.h:
1140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1141         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1142         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1143         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1144         (respondWithChallengeThenOK):
1145         (TestWebKitAPI::TEST):
1146         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1147         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1148         (TEST):
1149
1150 2019-04-22  Chris Dumez  <cdumez@apple.com>
1151
1152         Delayed WebProcessLaunch may break the _relatedWebView SPI
1153         https://bugs.webkit.org/show_bug.cgi?id=197160
1154
1155         Reviewed by Alex Christensen.
1156
1157         Add API test coverage.
1158
1159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1160
1161 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1162
1163         Use curl to download packages for webkitpy autoinstaller
1164         https://bugs.webkit.org/show_bug.cgi?id=197164
1165
1166         Reviewed by Darin Adler.
1167
1168         * Scripts/webkitpy/common/system/autoinstall.py:
1169         (AutoInstaller._download): Use curl(1) to download packages necessary for
1170         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1171         errors which are not present when using curl(1).
1172
1173 2019-04-22  Chris Dumez  <cdumez@apple.com>
1174
1175         Unreviewed, rolling out r244502.
1176
1177         Caused crashes on the bots
1178
1179         Reverted changeset:
1180
1181         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1182         https://bugs.webkit.org/show_bug.cgi?id=197160
1183         https://trac.webkit.org/changeset/244502
1184
1185 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1186
1187         Unreviewed, rolling out r244437.
1188
1189         Still breaks internal tests.
1190
1191         Reverted changeset:
1192
1193         "InjectedBundle parameters often need initialization function
1194         called before unarchiving"
1195         https://bugs.webkit.org/show_bug.cgi?id=189709
1196         https://trac.webkit.org/changeset/244437
1197
1198 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-build] Use singular verb in failure description in case of single api test failure
1201         https://bugs.webkit.org/show_bug.cgi?id=197013
1202
1203         Reviewed by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-build/steps.py:
1206         (AnalyzeAPITestsResults.analyzeResults):
1207
1208 2019-04-22  Chris Dumez  <cdumez@apple.com>
1209
1210         Delayed WebProcessLaunch may break the _relatedWebView SPI
1211         https://bugs.webkit.org/show_bug.cgi?id=197160
1212
1213         Reviewed by Alex Christensen.
1214
1215         Add API test coverage.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1218
1219 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1220
1221         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1222         https://bugs.webkit.org/show_bug.cgi?id=194630
1223
1224         Reviewed by Michael Catanzaro.
1225
1226         Return early from getAttributeSet() is passed in accessible is nullptr.
1227
1228         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1229
1230 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1231
1232         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1233         https://bugs.webkit.org/show_bug.cgi?id=197145
1234         <rdar://problem/50078170>
1235
1236         Reviewed by Darin Adler.
1237
1238         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1239         focus, or showing the font manager.
1240
1241         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1242         (TestWebKitAPI::TEST):
1243         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1244         (TEST):
1245         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1246         (TestWebKitAPI::TEST):
1247
1248 2019-04-21  Brian Burg  <bburg@apple.com>
1249
1250         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1251         https://bugs.webkit.org/show_bug.cgi?id=197125
1252         <rdar://problem/50061468>
1253
1254         Reviewed by Darin Adler.
1255
1256         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1257         using this class rather than making our own ./wpt serve invocation.
1258
1259         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1260         (WebDriverW3CWebServer):
1261         (WebDriverW3CWebServer.document_root): Expose this to clients.
1262         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1263
1264         (WebDriverW3CWebServer.__enter__):
1265         (WebDriverW3CWebServer.__exit__):
1266         Make it possible to use the web server with a 'with' statement.
1267
1268 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1269
1270         [CMake][Win] Use target oriented design for WebKitLegacy
1271         https://bugs.webkit.org/show_bug.cgi?id=197112
1272
1273         Reviewed by Konstantin Tokarev.
1274
1275         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1276
1277         * DumpRenderTree/CMakeLists.txt:
1278         * DumpRenderTree/PlatformWin.cmake:
1279         * DumpRenderTree/win/EventSender.cpp:
1280
1281 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1282
1283         Update text for old EWS submit button
1284         https://bugs.webkit.org/show_bug.cgi?id=197140
1285
1286         Reviewed by Alexey Proskuryakov.
1287
1288         * QueueStatusServer/templates/statusbubble.html:
1289
1290 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-app] New EWS should poll bugzilla more frequently
1293         https://bugs.webkit.org/show_bug.cgi?id=197138
1294
1295         Reviewed by Alexey Proskuryakov.
1296
1297         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1298         (FetchLoop.__init__):
1299
1300 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1303         https://bugs.webkit.org/show_bug.cgi?id=197139
1304
1305         Reviewed by Alexey Proskuryakov.
1306
1307         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1308         * QueueStatusServer/templates/statusbubble.html:
1309
1310 2019-04-20  Chris Dumez  <cdumez@apple.com>
1311
1312         Unreviewed, fix iOS build with recent SDKs.
1313
1314         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1315
1316 2019-04-19  Keith Miller  <keith_miller@apple.com>
1317
1318         Add script to merge run_benchmark jsons
1319         https://bugs.webkit.org/show_bug.cgi?id=197107
1320
1321         Reviewed by Michael Saboff.
1322
1323         The script basically recursively decends through all json objects until it gets
1324         to an array or JSON primitive and concats or takes the first value, respectively.
1325
1326         This patch also adds +x bits to the compare-results script so it
1327         can be run directly from the command line. I had to add a new line so that svn
1328         will accept the change... yay svn!
1329
1330         * Scripts/compare-results:
1331         * Scripts/merge-result-jsons: Added.
1332         (readJSONFile):
1333         (deepAppend):
1334         (mergeJSONs):
1335         (main):
1336
1337 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1338
1339         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1340         https://bugs.webkit.org/show_bug.cgi?id=197079
1341
1342         Reviewed by Darin Adler.
1343
1344         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1345
1346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1347         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1348
1349 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1350
1351         Unreviewed, rolling out r244434.
1352         https://bugs.webkit.org/show_bug.cgi?id=197089
1353
1354         caused 1 API test failure (Requested by zalan on #webkit).
1355
1356         Reverted changeset:
1357
1358         "Regression (r244291): Broken API Test
1359         AutoLayoutRenderingProgressRelativeOrdering"
1360         https://bugs.webkit.org/show_bug.cgi?id=196948
1361         https://trac.webkit.org/changeset/244434
1362
1363 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1364
1365         Add new compatibility mode API on WKNavigation
1366         https://bugs.webkit.org/show_bug.cgi?id=197069
1367         <rdar://problem/50025800>
1368
1369         Reviewed by Tim Horton.
1370
1371         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1372
1373         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1374         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1375         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1376
1377 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1378
1379         [CMake] Make WebCore headers copies
1380         https://bugs.webkit.org/show_bug.cgi?id=182512
1381         <rdar://problem/37510435>
1382
1383         Reviewed by Alex Christensen.
1384
1385         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1386         ports.
1387
1388         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1389         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1390
1391         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1392         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1393         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1394         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1395         * TestWebKitAPI/CMakeLists.txt:
1396         * TestWebKitAPI/PlatformWin.cmake:
1397         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1398         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1399         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1400
1401 2019-04-18  Jer Noble  <jer.noble@apple.com>
1402
1403         Add support for parsing FairPlayStreaming PSSH boxes.
1404         https://bugs.webkit.org/show_bug.cgi?id=197064
1405
1406         Reviewed by Eric Carlson.
1407
1408         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1409         (TestWebKitAPI::TEST):
1410
1411 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1412
1413         InjectedBundle parameters often need initialization function called before unarchiving
1414         https://bugs.webkit.org/show_bug.cgi?id=189709
1415         <rdar://problem/44573653>
1416
1417         Reviewed by Ryosuke Niwa.
1418
1419         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1420         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1421
1422 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1423
1424         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1425         https://bugs.webkit.org/show_bug.cgi?id=196948
1426         <rdar://problem/49927131>
1427
1428         Reviewed by Tim Horton.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1431         (TEST): 
1432         The expected order of incoming events is
1433         1. didInvalidateIntrinsicContentSize
1434         2. didFirstLayout
1435         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1436         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1437         (and remember, all we care about is ordering).
1438
1439 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1440
1441         Unreviewed, rolling out r244299.
1442
1443         Breaks internal tests.
1444
1445         Reverted changeset:
1446
1447         "InjectedBundle parameters often need initialization function
1448         called before unarchiving"
1449         https://bugs.webkit.org/show_bug.cgi?id=189709
1450         https://trac.webkit.org/changeset/244299
1451
1452 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1453
1454         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1455         https://bugs.webkit.org/show_bug.cgi?id=197053
1456
1457         Reviewed by Saam Barati.
1458
1459         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1460         (TestWebKitAPI::TEST):
1461
1462 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1463
1464         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1465         https://bugs.webkit.org/show_bug.cgi?id=197028
1466         <rdar://problem/49985290>
1467
1468         Reviewed by Wenson Hsieh.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1471         (TEST):
1472         Liberal application of waitForNextPresentationUpdate works around a race
1473         where if the page rapidly changes its viewport arguments (or an API client
1474         rapidly changes its viewport arguments), we'd get stuck thinking that the
1475         user had intentionally zoomed the page, and stop resetting the initial scale.
1476         This deserves a separate bug, but no need to keep the test failing while
1477         we think about it.
1478
1479 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1480
1481         REGRESSION (r241988): Switching tabs is slow
1482         https://bugs.webkit.org/show_bug.cgi?id=197037
1483         <rdar://problem/49951473>
1484
1485         Reviewed by Simon Fraser.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1489         (TEST):
1490         * TestWebKitAPI/cocoa/TestWKWebView.h:
1491         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1492         (-[TestWKWebView addToTestWindow]):
1493         Add a test that hangs without this fix.
1494
1495 2019-04-17  Truitt Savell  <tsavell@apple.com>
1496
1497         Unreviewed, rolling out r244400.
1498
1499         Caused testing to exit early with assertionon Debug WK2
1500
1501         Reverted changeset:
1502
1503         "UI↔Web deadlock when printing with a JavaScript alert
1504         visible"
1505         https://bugs.webkit.org/show_bug.cgi?id=196839
1506         https://trac.webkit.org/changeset/244400
1507
1508 2019-04-17  Brady Eidson  <beidson@apple.com>
1509
1510         Link clicks in PDFs shouldn't send referrer headers.
1511         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1512
1513         Reviewed by Tim Horton.
1514
1515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1516         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1517         (putPDFBytesCallback):
1518         (emptyReleaseInfoCallback):
1519         (createPDFWithLinkToURL):
1520         (TEST):
1521
1522 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1523
1524         UI↔Web deadlock when printing with a JavaScript alert visible
1525         https://bugs.webkit.org/show_bug.cgi?id=196839
1526         <rdar://problem/49157642>
1527
1528         Reviewed by Andy Estes.
1529
1530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1531         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1532         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1533         (TEST):
1534
1535 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1536
1537         WKRetainPtr's adoption constructor should be private
1538         https://bugs.webkit.org/show_bug.cgi?id=197019
1539
1540         Reviewed by Tim Horton.
1541
1542         * DumpRenderTree/mac/DumpRenderTree.mm:
1543         (dumpFramesAsText):
1544         * TestWebKitAPI/InjectedBundleController.cpp:
1545         (TestWebKitAPI::InjectedBundleController::initialize):
1546         * TestWebKitAPI/PlatformUtilities.cpp:
1547         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1548         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1549         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1550         (TestWebKitAPI::Util::toWK):
1551         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1552         (TestWebKitAPI::TEST):
1553         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1556         (TestWebKitAPI::TEST):
1557         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1558         (TestWebKitAPI::TEST):
1559         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1560         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1561         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1562         (TestWebKitAPI::TEST):
1563         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1564         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1565         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1568         (TestWebKitAPI::TEST):
1569         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1570         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1571         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1572         (TestWebKitAPI::TEST):
1573         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1574         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1575         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1580         (TestWebKitAPI::TEST):
1581         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1584         (TestWebKitAPI::TEST):
1585         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1590         (TestWebKitAPI::TEST):
1591         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1594         (TestWebKitAPI::TEST):
1595         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1598         (TestWebKitAPI::TEST):
1599         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1600         (TestWebKitAPI::TEST):
1601         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1604         (TestWebKitAPI::TEST):
1605         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1606         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1607         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1608         (TestWebKitAPI::TEST):
1609         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1610         (TestWebKitAPI::TEST):
1611         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1612         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1613         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1614         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1615         (TestWebKitAPI::TEST):
1616         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1617         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1618         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1623         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1624         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1625         (TestWebKitAPI::TEST):
1626         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1627         (TestWebKitAPI::loadAlternateHTMLString):
1628         (TestWebKitAPI::TEST):
1629         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1630         (TestWebKitAPI::TEST):
1631         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1632         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1633         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1634         (TestWebKitAPI::buildAndPerformTest):
1635         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1638         (TestWebKitAPI::TEST):
1639         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1640         (TestWebKitAPI::TEST):
1641         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1642         (TestWebKitAPI::TEST):
1643         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1644         (TestWebKitAPI::TEST):
1645         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1646         (TestWebKitAPI::TEST):
1647         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1648         (TestWebKitAPI::TEST):
1649         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1652         (TestWebKitAPI::TEST):
1653         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1654         (TestWebKitAPI::TEST):
1655         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1658         (TestWebKitAPI::TEST):
1659         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1660         (TestWebKitAPI::TEST):
1661         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1662         (TestWebKitAPI::TEST):
1663         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1666         (TestWebKitAPI::TEST):
1667         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1668         (TestWebKitAPI::TEST):
1669         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1670         (TestWebKitAPI::TEST):
1671         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1672         (TestWebKitAPI::TEST):
1673         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1674         (TestWebKitAPI::TEST):
1675         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1676         (TestWebKitAPI::TEST):
1677         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1678         (TestWebKitAPI::TEST):
1679         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1680         (TestWebKitAPI::TEST):
1681         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1682         (TestWebKitAPI::TEST):
1683         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1684         (TestWebKitAPI::TEST):
1685         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1686         (TestWebKitAPI::TEST):
1687         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1690         (TestWebKitAPI::TEST):
1691         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1692         (TestWebKitAPI::TEST):
1693         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1694         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1695         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1696         (TestWebKitAPI::TEST):
1697         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1698         (TestWebKitAPI::TEST):
1699         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1700         (TestWebKitAPI::TEST):
1701         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1702         (TestWebKitAPI::TEST):
1703         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1706         (TestWebKitAPI::TEST):
1707         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1708         (TestWebKitAPI::TEST):
1709         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1710         (TestWebKitAPI::TEST):
1711         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1712         (TestWebKitAPI::TEST):
1713         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1714         (TestWebKitAPI::TEST):
1715         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1716         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1717         (TEST):
1718         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1719         (TEST):
1720         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1721         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1722         (TEST):
1723         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1724         (TestWebKitAPI::TEST):
1725         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1726         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1727         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1728         (WTR::getMenuItemTitleCallback):
1729         (WTR::createMouseMessageBody):
1730         (WTR::EventSendingController::mouseDown):
1731         (WTR::EventSendingController::mouseUp):
1732         (WTR::EventSendingController::mouseMoveTo):
1733         (WTR::EventSendingController::mouseForceClick):
1734         (WTR::EventSendingController::startAndCancelMouseForceClick):
1735         (WTR::EventSendingController::mouseForceDown):
1736         (WTR::EventSendingController::mouseForceUp):
1737         (WTR::EventSendingController::mouseForceChanged):
1738         (WTR::EventSendingController::leapForward):
1739         (WTR::EventSendingController::scheduleAsynchronousClick):
1740         (WTR::createKeyDownMessageBody):
1741         (WTR::EventSendingController::keyDown):
1742         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1743         (WTR::EventSendingController::mouseScrollBy):
1744         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1745         (WTR::EventSendingController::continuousMouseScrollBy):
1746         (WTR::EventSendingController::addTouchPoint):
1747         (WTR::EventSendingController::updateTouchPoint):
1748         (WTR::EventSendingController::setTouchModifier):
1749         (WTR::EventSendingController::setTouchPointRadius):
1750         (WTR::EventSendingController::touchStart):
1751         (WTR::EventSendingController::touchMove):
1752         (WTR::EventSendingController::touchEnd):
1753         (WTR::EventSendingController::touchCancel):
1754         (WTR::EventSendingController::clearTouchPoints):
1755         (WTR::EventSendingController::releaseTouchPoint):
1756         (WTR::EventSendingController::cancelTouchPoint):
1757         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1758         (WTR::InjectedBundle::didCreatePage):
1759         (WTR::InjectedBundle::didReceiveMessage):
1760         (WTR::InjectedBundle::didReceiveMessageToPage):
1761         (WTR::InjectedBundle::booleanForKey):
1762         (WTR::InjectedBundle::done):
1763         (WTR::InjectedBundle::dumpToStdErr):
1764         (WTR::InjectedBundle::outputText):
1765         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1766         (WTR::InjectedBundle::postAddChromeInputField):
1767         (WTR::InjectedBundle::postRemoveChromeInputField):
1768         (WTR::InjectedBundle::postFocusWebView):
1769         (WTR::InjectedBundle::postSetBackingScaleFactor):
1770         (WTR::InjectedBundle::postSetWindowIsKey):
1771         (WTR::InjectedBundle::postSetViewSize):
1772         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1773         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1774         (WTR::InjectedBundle::setGeolocationPermission):
1775         (WTR::InjectedBundle::setMockGeolocationPosition):
1776         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1777         (WTR::InjectedBundle::isGeolocationProviderActive const):
1778         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1779         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1780         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1781         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1782         (WTR::InjectedBundle::setCustomPolicyDelegate):
1783         (WTR::InjectedBundle::setHidden):
1784         (WTR::InjectedBundle::setCacheModel):
1785         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1786         (WTR::InjectedBundle::processWorkQueue):
1787         (WTR::InjectedBundle::queueBackNavigation):
1788         (WTR::InjectedBundle::queueForwardNavigation):
1789         (WTR::InjectedBundle::queueLoad):
1790         (WTR::InjectedBundle::queueLoadHTMLString):
1791         (WTR::InjectedBundle::queueReload):
1792         (WTR::InjectedBundle::queueLoadingScript):
1793         (WTR::InjectedBundle::queueNonLoadingScript):
1794         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1795         (WTR::frameToStr):
1796         (WTR::InjectedBundlePage::InjectedBundlePage):
1797         (WTR::dumpFrameDescriptionSuitableForTestResult):
1798         (WTR::dumpFrameScrollPosition):
1799         (WTR::dumpDescendantFrameScrollPositions):
1800         (WTR::dumpFrameText):
1801         (WTR::dumpDescendantFramesText):
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR::TestRunner::shouldDumpPixels const):
1804         (WTR::TestRunner::setDumpPixels):
1805         (WTR::TestRunner::whatToDump const):
1806         (WTR::TestRunner::setWhatToDump):
1807         (WTR::TestRunner::setWaitUntilDone):
1808         (WTR::TestRunner::shouldWaitUntilDone const):
1809         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1810         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1811         (WTR::TestRunner::clearAllDatabases):
1812         (WTR::TestRunner::setIDBPerOriginQuota):
1813         (WTR::TestRunner::originsWithApplicationCache):
1814         (WTR::TestRunner::setCanOpenWindows):
1815         (WTR::TestRunner::setXSSAuditorEnabled):
1816         (WTR::TestRunner::setMediaDevicesEnabled):
1817         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1818         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1819         (WTR::TestRunner::setCustomUserAgent):
1820         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1821         (WTR::TestRunner::setModernMediaControlsEnabled):
1822         (WTR::TestRunner::setWebGL2Enabled):
1823         (WTR::TestRunner::setWritableStreamAPIEnabled):
1824         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1825         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1826         (WTR::TestRunner::setAllowsAnySSLCertificate):
1827         (WTR::TestRunner::setPluginsEnabled):
1828         (WTR::TestRunner::setValueForUser):
1829         (WTR::TestRunner::setAudioResult):
1830         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1831         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1832         (WTR::TestRunner::setAlwaysAcceptCookies):
1833         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1834         (WTR::TestRunner::isDoingMediaCapture const):
1835         (WTR::TestRunner::queueLoad):
1836         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1837         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1838         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1839         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1840         (WTR::TestRunner::setAuthenticationUsername):
1841         (WTR::TestRunner::setAuthenticationPassword):
1842         (WTR::TestRunner::secureEventInputIsEnabled const):
1843         (WTR::TestRunner::setBlockAllPlugins):
1844         (WTR::TestRunner::setPluginSupportedMode):
1845         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1846         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1847         (WTR::TestRunner::setNavigationGesturesEnabled):
1848         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1849         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1850         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1851         (WTR::TestRunner::terminateNetworkProcess):
1852         (WTR::TestRunner::terminateServiceWorkerProcess):
1853         (WTR::TestRunner::runUIScript):
1854         (WTR::TestRunner::setStatisticsDebugMode):
1855         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1856         (WTR::TestRunner::setStatisticsLastSeen):
1857         (WTR::TestRunner::setStatisticsPrevalentResource):
1858         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1859         (WTR::TestRunner::dumpResourceLoadStatistics):
1860         (WTR::TestRunner::isStatisticsPrevalentResource):
1861         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1862         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1863         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1864         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1865         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1866         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1867         (WTR::TestRunner::setStatisticsGrandfathered):
1868         (WTR::TestRunner::isStatisticsGrandfathered):
1869         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1870         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1871         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1872         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1873         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1874         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1875         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1876         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1877         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1878         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1879         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1880         (WTR::TestRunner::statisticsSubmitTelemetry):
1881         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1882         (WTR::TestRunner::setStatisticsIsRunningTest):
1883         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1884         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1885         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1886         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1887         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1888         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1889         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1890         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1891         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1892         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1893         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1894         (WTR::TestRunner::statisticsResetToConsistentState):
1895         (WTR::TestRunner::setStorageAccessAPIEnabled):
1896         (WTR::TestRunner::getAllStorageAccessEntries):
1897         (WTR::TestRunner::addMockMediaDevice):
1898         (WTR::TestRunner::clearMockMediaDevices):
1899         (WTR::TestRunner::removeMockMediaDevice):
1900         (WTR::TestRunner::resetMockMediaDevices):
1901         (WTR::TestRunner::connectMockGamepad):
1902         (WTR::TestRunner::disconnectMockGamepad):
1903         (WTR::TestRunner::setMockGamepadDetails):
1904         (WTR::TestRunner::setMockGamepadAxisValue):
1905         (WTR::TestRunner::setMockGamepadButtonValue):
1906         (WTR::TestRunner::removeAllSessionCredentials):
1907         (WTR::TestRunner::clearDOMCache):
1908         (WTR::TestRunner::clearDOMCaches):
1909         (WTR::TestRunner::hasDOMCache):
1910         (WTR::TestRunner::domCacheSize):
1911         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1912         (WTR::TestRunner::getApplicationManifestThen):
1913         (WTR::TestRunner::injectUserScript):
1914         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1915         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1916         (WTR::TestRunner::addTestKeyToKeychain):
1917         (WTR::TestRunner::cleanUpKeychain):
1918         (WTR::TestRunner::keyExistsInKeychain):
1919         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1920         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1921         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1922         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1923         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1924         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1925         * WebKitTestRunner/TestController.cpp:
1926         (WTR::TestController::initialize):
1927         (WTR::parseStringTestHeaderValueAsRelativePath):
1928         (WTR::updateTestOptionsFromTestHeader):
1929         (WTR::TestController::runTest):
1930         (WTR::TestController::didReceiveLiveDocumentsList):
1931         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1932         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1933         (WTR::TestController::didFinishNavigation):
1934         (WTR::TestController::didReceiveAuthenticationChallenge):
1935         * WebKitTestRunner/TestInvocation.cpp:
1936         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1937         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1938         (WTR::TestInvocation::uiScriptDidComplete):
1939         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1940         * WebKitTestRunner/WebNotificationProvider.cpp:
1941         (WTR::WebNotificationProvider::closeWebNotification):
1942         * WebKitTestRunner/WorkQueueManager.cpp:
1943         (WTR::ScriptItem::ScriptItem):
1944         (WTR::WorkQueueManager::queueLoad):
1945         (WTR::WorkQueueManager::queueLoadHTMLString):
1946
1947 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1948
1949         Add a comment to make my test from r244139 less mysterious.
1950         https://bugs.webkit.org/show_bug.cgi?id=196744
1951
1952         As suggested by Darin Adler.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1955         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1956
1957 2019-04-17  Chris Dumez  <cdumez@apple.com>
1958
1959         Remember device orientation permission for the duration of the browsing session
1960         https://bugs.webkit.org/show_bug.cgi?id=196992
1961         <rdar://problem/49946067>
1962
1963         Reviewed by Alex Christensen.
1964
1965         Add API test coverage.
1966
1967         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1968         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1969         (TEST):
1970
1971 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1974         https://bugs.webkit.org/show_bug.cgi?id=196675
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1979         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1980
1981 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1982
1983         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1984         https://bugs.webkit.org/show_bug.cgi?id=196919
1985         <rdar://problem/41630459>
1986
1987         Reviewed by Tim Horton.
1988
1989         Add iOS support for several new testing hooks. See below for more detail.
1990
1991         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1992         (WTR::UIScriptController::isDismissingMenu const):
1993
1994         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1995         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1996         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1997
1998         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1999         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2000         (WTR::UIScriptController::isDismissingMenu const):
2001         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2002         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2004         (WTR::InjectedBundle::didReceiveMessageToPage):
2005         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2006         (WTR::TestRunner::setAllowedMenuActions):
2007
2008         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2009         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2010         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2011         against the name of the custom action.
2012
2013         (WTR::TestRunner::installCustomMenuAction):
2014
2015         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2016         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2017         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2018         triggered.
2019
2020         (WTR::TestRunner::performCustomMenuAction):
2021
2022         Invoked when the custom menu action is triggered.
2023
2024         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2025         * WebKitTestRunner/TestController.cpp:
2026         (WTR::TestController::installCustomMenuAction):
2027         (WTR::TestController::setAllowedMenuActions):
2028         * WebKitTestRunner/TestController.h:
2029         * WebKitTestRunner/TestInvocation.cpp:
2030         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2031         (WTR::TestInvocation::performCustomMenuAction):
2032
2033         Add plumbing to call back into the injected bundle when performing the custom action.
2034
2035         * WebKitTestRunner/TestInvocation.h:
2036         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2037         (WTR::TestController::installCustomMenuAction):
2038         (WTR::TestController::setAllowedMenuActions):
2039         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2040         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2041         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2042         (-[TestRunnerWKWebView becomeFirstResponder]):
2043         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2044
2045         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2046         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2047         in the Mail app on iOS.
2048
2049         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2050         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2051         (-[TestRunnerWKWebView resetCustomMenuAction]):
2052         (-[TestRunnerWKWebView performCustomAction:]):
2053         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2054         (-[TestRunnerWKWebView _willHideMenu]):
2055         (-[TestRunnerWKWebView _didHideMenu]):
2056         * WebKitTestRunner/ios/TestControllerIOS.mm:
2057         (WTR::TestController::platformResetStateToConsistentValues):
2058
2059         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2060         if specified.
2061
2062         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2063         (WTR::UIScriptController::isDismissingMenu const):
2064
2065 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2066
2067         Allow sharing from imageSheet on an image document
2068         https://bugs.webkit.org/show_bug.cgi?id=196891
2069         <rdar://problem/25377386>
2070
2071         Reviewed by Tim Horton.
2072
2073         Test to make sure that the correct imageURL is extracted from an image element.
2074
2075         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2076         (TestWebKitAPI::TEST):
2077
2078 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2079
2080         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2081         https://bugs.webkit.org/show_bug.cgi?id=196995
2082
2083         Reviewed by Brady Eidson.
2084
2085         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2086         (TEST):
2087
2088 2019-04-16  Chris Dumez  <cdumez@apple.com>
2089
2090         URL set by document.open() is not communicated to the UIProcess
2091         https://bugs.webkit.org/show_bug.cgi?id=196941
2092         <rdar://problem/49237544>
2093
2094         Reviewed by Geoff Garen.
2095
2096         Add API test coverage.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2100         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2101         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2102         (TEST):
2103
2104 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2105
2106         Unreviewed, rolling out r244321.
2107         https://bugs.webkit.org/show_bug.cgi?id=196968
2108
2109         Causing all WK2 Debug builds to exit early after Assertion
2110         failures. (Requested by ShawnRoberts on #webkit).
2111
2112         Reverted changeset:
2113
2114         "URL set by document.open() is not communicated to the
2115         UIProcess"
2116         https://bugs.webkit.org/show_bug.cgi?id=196941
2117         https://trac.webkit.org/changeset/244321
2118
2119 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2120
2121         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2122         https://bugs.webkit.org/show_bug.cgi?id=196948
2123
2124         Reviewed by Zalan Bujtas.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2127         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2128
2129 2019-04-15  Chris Dumez  <cdumez@apple.com>
2130
2131         URL set by document.open() is not communicated to the UIProcess
2132         https://bugs.webkit.org/show_bug.cgi?id=196941
2133         <rdar://problem/49237544>
2134
2135         Reviewed by Geoffrey Garen.
2136
2137         Add API test coverage.
2138
2139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2140         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2141         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2142         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2143         (TEST):
2144
2145 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2146
2147         Using Tools/Scripts/clean-webkit should not install requests
2148         https://bugs.webkit.org/show_bug.cgi?id=196940
2149
2150         Reviewed by Lucas Forschler.
2151
2152         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2153         existing, depending on the path autoinstalled is run through.
2154         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2155         needed.
2156         (Port.configuration_for_upload):
2157         (Port.commits_for_upload):
2158
2159 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2160
2161         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2162         https://bugs.webkit.org/show_bug.cgi?id=196773
2163
2164         Reviewed by Jer Noble.
2165
2166         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2167         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2168         (TEST):
2169
2170 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2171
2172         ews-build should clearly indicate flaky test failures
2173         https://bugs.webkit.org/show_bug.cgi?id=196947
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-build/steps.py:
2178         (AnalyzeAPITestsResults.analyzeResults):
2179
2180 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2181
2182         InjectedBundle parameters often need initialization function called before unarchiving
2183         https://bugs.webkit.org/show_bug.cgi?id=189709
2184         <rdar://problem/44573653>
2185
2186         Reviewed by Ryosuke Niwa.
2187
2188         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2189         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2190
2191 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2192
2193         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2194         https://bugs.webkit.org/show_bug.cgi?id=196681
2195
2196         Reviewed by Darin Adler.
2197
2198         Added tests.
2199
2200         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2201         (WTF_HashSet.RemoveIf):
2202         (WTF_HashSet.RemoveIfShrinkToBestSize):
2203
2204 2019-04-15  John Wilander  <wilander@apple.com>
2205
2206         Send delayed Ad Click Attribution conversion requests to the click source
2207         https://bugs.webkit.org/show_bug.cgi?id=196838
2208         <rdar://problem/47650157>
2209
2210         Reviewed by Chris Dumez and Youenn Fablet.
2211
2212         This patch adds test infrastructure to override the default behavior in
2213         WebKit::NetworkAdClickAttribution.
2214
2215         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2216         (TestWebKitAPI::TEST):
2217         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2219         (WTR::TestRunner::dumpAdClickAttribution):
2220         (WTR::TestRunner::clearAdClickAttribution):
2221         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2222         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2224         * WebKitTestRunner/TestController.cpp:
2225         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2226         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2227         * WebKitTestRunner/TestController.h:
2228         * WebKitTestRunner/TestInvocation.cpp:
2229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2230
2231 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2232
2233         [ews-app] status-bubble should display position in queue
2234         https://bugs.webkit.org/show_bug.cgi?id=196607
2235
2236         Reviewed by Lucas Forschler.
2237
2238         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2239         (StatusBubble._build_bubble):
2240         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2241
2242 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2243
2244         [ews-build] Do not run clean build by default on EWS builders
2245         https://bugs.webkit.org/show_bug.cgi?id=196897
2246
2247         Reviewed by Lucas Forschler.
2248
2249         * BuildSlaveSupport/ews-build/steps.py:
2250         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2251         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2252         untracked directories like WebKitBuild).
2253         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2254         untracked files/directories (like WebKitBuild).
2255
2256 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2257
2258         TestRunner::notifyDone() should be safely reentrant
2259         https://bugs.webkit.org/show_bug.cgi?id=196898
2260
2261         Reviewed by Darin Adler.
2262
2263         It is currently possible that TestRunner::notifyDone() will call itself, since
2264         notifyDone() will force a repaint, which can start executing JavaScript, which
2265         may call notifyDone() again. This can lead to test failures and flakiness.
2266         Fix this by setting the m_waitToDump flag before calling the dump() method.
2267
2268         * DumpRenderTree/mac/TestRunnerMac.mm:
2269         (TestRunner::notifyDone):
2270         (TestRunner::forceImmediateCompletion):
2271         * DumpRenderTree/win/TestRunnerWin.cpp:
2272         (TestRunner::notifyDone):
2273         (TestRunner::forceImmediateCompletion):
2274
2275 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2276
2277         [GTK][WPE] Add enable-media websetting
2278         https://bugs.webkit.org/show_bug.cgi?id=196863
2279
2280         Reviewed by Michael Catanzaro.
2281
2282         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2283         (testWebKitSettings): Add test for the enable-media web-setting.
2284
2285 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2286
2287         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2288         https://bugs.webkit.org/show_bug.cgi?id=196905
2289         <rdar://problem/49886096>
2290
2291         Reviewed by Tim Horton.
2292
2293         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2294         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2295         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2296         delay timer, we end up with this sequence of events in the problematic (failure) case:
2297
2298         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2299             ...IPC from UI to web process...
2300         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2301             ...IPC from web to UI process...
2302         (c) [UI]    Invoke completion handler for script #1
2303         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2304             ...IPC from UI to web process...
2305         (e) [Web]   Evaluate script #2 in the web process
2306         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2307
2308         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2309         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2310         #2 is run in step (e).
2311
2312         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2313         the UI process by waiting on a script message posted by the web process, after attachment updates are
2314         dispatched.
2315
2316         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2317         (TestWebKitAPI::TEST):
2318
2319 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2320
2321         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2322         https://bugs.webkit.org/show_bug.cgi?id=196909
2323
2324         Reviewed by Wenson Hsieh.
2325
2326         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2327         (TestWebKitAPI::TEST):
2328
2329 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2330
2331         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2332         https://bugs.webkit.org/show_bug.cgi?id=196880
2333
2334         Reviewed by Yusuke Suzuki.
2335
2336         Add a new function for bytecode cache tests that does not forceDiskCache
2337         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2338         test added in this patch, since the code is invalid and therefore won't be
2339         cached. It should also be useful for tests that evaluate dynamically
2340         generated code.
2341
2342         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2343         * Scripts/run-jsc-stress-tests:
2344
2345 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2346
2347         Update AudioSession route sharing policy
2348         https://bugs.webkit.org/show_bug.cgi?id=196776
2349         <rdar://problem/46501611>
2350
2351         Reviewed by Jer Noble.
2352
2353         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2354         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2355         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2356         (TestWebKitAPI::TEST):
2357
2358 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2359
2360         [iOS] Software keyboard is shown too frequently on some websites
2361         https://bugs.webkit.org/show_bug.cgi?id=195856
2362         <rdar://problem/49191395>
2363
2364         Reviewed by Darin Adler.
2365
2366         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2367
2368         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2369         (WTR::UIScriptController::setHardwareKeyboardAttached):
2370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2372         (WTR::UIScriptController::setHardwareKeyboardAttached):
2373         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2374         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2375
2376         Additionally link against GraphicsServices in WebKitTestRunner.
2377
2378         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2379         (WTR::TestController::platformResetStateToConsistentValues):
2380         (WTR::UIScriptController::setHardwareKeyboardAttached):
2381
2382 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2383
2384         [GTK][WPE] Fix pacman install-dependencies packages
2385         https://bugs.webkit.org/show_bug.cgi?id=196817
2386
2387         Reviewed by Žan Doberšek.
2388         
2389         python3-setuptools is called python-setuptools
2390         ruby-highline is only available on AUR
2391         libv4l-devel is incorporated in v4l-utils
2392
2393         * gtk/install-dependencies:
2394         * wpe/install-dependencies:
2395
2396 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2397
2398         [GTK] REGRESSION(r243860): Many tests failing
2399         https://bugs.webkit.org/show_bug.cgi?id=196791
2400
2401         Reviewed by Joanmarie Diggs.
2402
2403         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2404         multiple documents and check that accessibility hierarchy is updated after a navigation.
2405
2406         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2407         (loadChangedCallback):
2408         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2409         (AccessibilityTest::AccessibilityTest):
2410         (AccessibilityTest::~AccessibilityTest):
2411         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2412         (AccessibilityTest::findTestServerApplication):
2413         (AccessibilityTest::findDocumentWeb):
2414         (AccessibilityTest::findRootObject):
2415         (AccessibilityTest::waitUntilChildrenRemoved):
2416         (AccessibilityTest::ensureProxy):
2417         (testAtspiBasicHierarchy):
2418         (beforeAll):
2419         (afterAll):
2420
2421 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2422
2423         [ews-build] Handle bug titles with unicode characters
2424         https://bugs.webkit.org/show_bug.cgi?id=196802
2425
2426         Reviewed by Dewei Zhu.
2427
2428         * BuildSlaveSupport/ews-build/steps.py:
2429         (ValidatePatch._is_bug_closed):
2430
2431 2019-04-11  Michael Saboff  <msaboff@apple.com>
2432
2433         Improve the Inline Cache Stats code
2434         https://bugs.webkit.org/show_bug.cgi?id=196836
2435
2436         Reviewed by Saam Barati.
2437
2438         Added a new script to consolidate and arrange the output of --useICStats option.
2439
2440         This script merges the output from every group into one large table and sorts it from most common to
2441         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2442         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2443         Put together, this is useful to see what property accesses are not getting cached.
2444
2445         * Scripts/ic-stats.py: Added.
2446         (ICStats):
2447         (ICStats.__init__):
2448         (ICStats.parse):
2449         (ICStats.dumpStats):
2450         (usage):
2451
2452 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2453
2454         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2455         https://bugs.webkit.org/show_bug.cgi?id=196809
2456         <rdar://49800762>
2457
2458         Reviewed by Brady Eidson.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2461         (TEST):
2462
2463 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2464
2465         requestAnimationFrame should execute before the next frame
2466         https://bugs.webkit.org/show_bug.cgi?id=177484
2467
2468         Reviewed by Simon Fraser.
2469
2470         Add trace points for the page RenderingUpdate.
2471
2472         * Tracing/SystemTracePoints.plist:
2473
2474 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2475
2476         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2477         https://bugs.webkit.org/show_bug.cgi?id=196760
2478
2479         Reviewed by Don Olmstead.
2480
2481         vswhere.exe has been bundled since Visual Studio 2017 version
2482         15.2. We shouldn't download vswhere.exe.
2483
2484         * Scripts/build-jsc: Do not call update-vswhere.py.
2485         * Scripts/build-webkit: Ditto.
2486         * Scripts/update-vswhere.py: Removed.
2487         * Scripts/webkitdirs.pm:
2488         (requireModulesForVSWhere): Deleted.
2489         (pickCurrentVisualStudioInstallation): Deleted.
2490         (visualStudioInstallDirVSWhere): Return the latest installed VS
2491         installation path by using the bundled vswhere.exe.
2492         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2493         (visualStudioInstallDirFallback): Removed.
2494
2495 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2498         https://bugs.webkit.org/show_bug.cgi?id=196780
2499
2500         Reviewed by Alexey Proskuryakov.
2501
2502         * BuildSlaveSupport/ews-build/steps.py:
2503         * BuildSlaveSupport/ews-build/steps_unittest.py:
2504
2505 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2506
2507         Add SPI WKNavigationResponse._downloadAttribute
2508         https://bugs.webkit.org/show_bug.cgi?id=196755
2509         <rdar://49587365>
2510
2511         Reviewed by Brady Eidson.
2512
2513         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2514         (-[NavigationResponseTestDelegate navigationResponse]):
2515         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2516         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2517         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2518         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2519         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2520         (readRequest):
2521         (writeResponse):
2522         (TEST):
2523
2524 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2525
2526         Add modern API for overriding the page's specified viewport configuration
2527         https://bugs.webkit.org/show_bug.cgi?id=167734
2528         <rdar://problem/30331795>
2529
2530         Reviewed by Simon Fraser.
2531
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2534
2535 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2536
2537         Add support for incremental bytecode cache updates
2538         https://bugs.webkit.org/show_bug.cgi?id=195000
2539
2540         Reviewed by Filip Pizlo.
2541
2542         Exit when the initial run to generate bytecode fails.
2543
2544         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2545
2546 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2547
2548         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2549         https://bugs.webkit.org/show_bug.cgi?id=196744
2550         <rdar://49415309>
2551
2552         Reviewed by Chris Dumez.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2555         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2556
2557 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2558
2559         Add a way to opt into modern compatibility mode in layout tests
2560         https://bugs.webkit.org/show_bug.cgi?id=196770
2561         <rdar://problem/49777550>
2562
2563         Reviewed by Antoine Quint.
2564
2565         Add a new test option to enable modern compatibility mode in layout tests.
2566
2567         * WebKitTestRunner/TestController.cpp:
2568         (WTR::updateTestOptionsFromTestHeader):
2569         * WebKitTestRunner/TestController.h:
2570         * WebKitTestRunner/TestOptions.h:
2571         (WTR::TestOptions::hasSameInitializationOptions const):
2572         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2573         (WTR::TestController::platformCreateWebView):
2574         (WTR::TestController::enableModernCompatibilityMode):
2575
2576 2019-04-10  Andy Estes  <aestes@apple.com>
2577
2578         Try to fix the 32-bit watchOS build.
2579
2580         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2581         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2582
2583 2019-04-10  Antoine Quint  <graouts@apple.com>
2584
2585         Enable Pointer Events on watchOS
2586         https://bugs.webkit.org/show_bug.cgi?id=196771
2587         <rdar://problem/49040909>
2588
2589         Reviewed by Dean Jackson.
2590
2591         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2592
2593 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2594
2595         Unreviewed. Fix WPE accessibility tests after r244059.
2596
2597         We are failing to load the injected bundle due to undefined symbol
2598         AccessibilityUIElement::replaceTextInRange().
2599
2600         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2601         (WTR::AccessibilityUIElement::replaceTextInRange):
2602
2603 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2604
2605         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2606         https://bugs.webkit.org/show_bug.cgi?id=196727
2607
2608         Reviewed by Fujii Hironori.
2609
2610         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2611         (WebKitBrowserWindow::create):
2612
2613 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2614
2615         [ews-build] Add unit tests for PrintConfiguration
2616         https://bugs.webkit.org/show_bug.cgi?id=196752
2617
2618         Reviewed by Dewei Zhu.
2619
2620         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2621
2622 2019-04-09  Keith Rollin  <krollin@apple.com>
2623
2624         Unreviewed build maintenance -- update .xcfilelists.
2625
2626         * DumpRenderTree/DerivedSources-input.xcfilelist:
2627         * DumpRenderTree/DerivedSources-output.xcfilelist:
2628
2629 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2630
2631         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2632         https://bugs.webkit.org/show_bug.cgi?id=196743
2633         <rdar://problem/43897551>
2634
2635         Reviewed by Tim Horton.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2638         (TEST):
2639
2640 2019-04-09  Youenn Fablet  <youenn@apple.com>
2641
2642         Close service worker database on network process suspension
2643         https://bugs.webkit.org/show_bug.cgi?id=196623
2644         <rdar://problem/48930869>
2645
2646         Reviewed by Alex Christensen.
2647
2648         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2649
2650 2019-04-09  Daniel Bates  <dabates@apple.com>
2651
2652         [iPad] Should open popover when the spacebar is pressed
2653         https://bugs.webkit.org/show_bug.cgi?id=196360
2654         <rdar://problem/49389129>
2655
2656         Reviewed by Brent Fulgham.
2657
2658         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2659
2660         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2661         (WTR::UIScriptController::isShowingPopover const): Added.
2662         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2663         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2664         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2665         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2666         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2667         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2668         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2669         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2670         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2671         (WTR::UIScriptController::isShowingPopover const): Added.
2672         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2673         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2674         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2675         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2676         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2677         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2678         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2679         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2680         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2681         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2682         (WTR::UIScriptController::isShowingPopover const): Added.
2683         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2684         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2685
2686 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2687
2688         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2689         https://bugs.webkit.org/show_bug.cgi?id=196665
2690         <rdar://45115669>
2691
2692         Reviewed by Geoff Garen.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2695         (goBack):
2696         (+[SimpleLookupContext sharedLookupContext]):
2697         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2698         (TEST):
2699         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2700         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2701
2702 2019-04-09  John Wilander  <wilander@apple.com>
2703
2704         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2705         https://bugs.webkit.org/show_bug.cgi?id=196558
2706         <rdar://problem/47650245>
2707
2708         Reviewed by Youenn Fablet.
2709
2710         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2711         (TestWebKitAPI::TEST):
2712             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2713
2714 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2715
2716         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2717         https://bugs.webkit.org/show_bug.cgi?id=196720
2718
2719         Reviewed by Konstantin Tokarev.
2720
2721         * TestWebKitAPI/PlatformMac.cmake:
2722
2723 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2724
2725         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2726         https://bugs.webkit.org/show_bug.cgi?id=196694
2727         <rdar://problem/48388734>
2728
2729         Rubber-stamped by Aakash Jain.
2730
2731         * Scripts/webkitpy/port/image_diff.py:
2732         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2733         * Scripts/webkitpy/port/server_process.py:
2734         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2735         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2736         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2737         * Scripts/webkitpy/port/server_process_mock.py:
2738         (MockServerProcess.has_available_stdout):
2739         * Scripts/webkitpy/port/server_process_unittest.py:
2740         (TestServerProcess.serial_test_basic):
2741
2742 2019-04-09  Jer Noble  <jer.noble@apple.com>
2743
2744         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2745         https://bugs.webkit.org/show_bug.cgi?id=196097
2746
2747         Reviewed by Eric Carlson.
2748
2749         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2750
2751         * DumpRenderTree/mac/DumpRenderTree.mm:
2752         (resetWebPreferencesToConsistentValues):
2753         * WebKitTestRunner/TestController.cpp:
2754         (WTR::TestController::resetPreferencesToConsistentValues):
2755
2756 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2757
2758         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2759         https://bugs.webkit.org/show_bug.cgi?id=196690
2760
2761         Reviewed by Michael Catanzaro.
2762
2763         * QueueStatusServer/config/queues.py:
2764         * Scripts/webkitpy/common/config/ews.json:
2765         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2766         (test_ews_name):
2767
2768 2019-04-09  Chris Dumez  <cdumez@apple.com>
2769
2770         Loads using loadHTMLString() cause flashing when process-swapping
2771         https://bugs.webkit.org/show_bug.cgi?id=196714
2772         <rdar://problem/49637354>
2773
2774         Reviewed by Antti Koivisto.
2775
2776         Add API test coverage.
2777
2778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2779
2780 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2781
2782         Unreviewed. Fix ATK accessibility tests after r244059.
2783
2784         We are failing to load the injected bundle due to undefined symbol
2785         AccessibilityUIElement::replaceTextInRange().
2786
2787         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2788         (WTR::AccessibilityUIElement::replaceTextInRange):
2789
2790 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2791
2792         AX: Support API: accessibilityReplaceRange:withText
2793         https://bugs.webkit.org/show_bug.cgi?id=196636
2794
2795         Unreviewed build fix for Windows port.
2796
2797         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2798         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2799
2800 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2801
2802         [CMake][WinCairo] Separate copied headers into different directories
2803         https://bugs.webkit.org/show_bug.cgi?id=196655
2804
2805         Reviewed by Michael Catanzaro.
2806
2807         * DumpRenderTree/CMakeLists.txt:
2808         * MiniBrowser/win/CMakeLists.txt:
2809         * TestWebKitAPI/CMakeLists.txt:
2810         * TestWebKitAPI/PlatformWin.cmake:
2811
2812 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2813
2814         Log stack-trace for run-webkit-tests when interrupted
2815         https://bugs.webkit.org/show_bug.cgi?id=176393
2816         <rdar://problem/34262310>
2817
2818         Reviewed by Lucas Forschler.
2819
2820         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2821         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2822         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2823         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2824         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2825         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2826         (main): Set handlers to log stack trace on interruption.
2827
2828 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2829
2830         AX: Support API: accessibilityReplaceRange:withText
2831         https://bugs.webkit.org/show_bug.cgi?id=196636
2832
2833         Unreviewed build fix for Windows port.
2834
2835         * DumpRenderTree/AccessibilityUIElement.cpp:
2836         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2837
2838 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2839
2840         [ews-build] Scripts using Buildbot API have CORS error
2841         https://bugs.webkit.org/show_bug.cgi?id=196709
2842
2843         Reviewed by Alexey Proskuryakov.
2844
2845         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2846
2847 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2848
2849         AX: Support API: accessibilityReplaceRange:withText
2850         https://bugs.webkit.org/show_bug.cgi?id=196636
2851
2852         Reviewed by Daniel Bates.
2853
2854         * DumpRenderTree/AccessibilityUIElement.cpp:
2855         (replaceTextInRangeCallback):
2856         (AccessibilityUIElement::replaceTextInRange):
2857         (AccessibilityUIElement::getJSClass):
2858         * DumpRenderTree/AccessibilityUIElement.h:
2859         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2860         (AccessibilityUIElement::replaceTextInRange):
2861         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2862         (AccessibilityUIElement::replaceTextInRange):
2863         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2864         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2865         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2866         (WTR::AccessibilityUIElement::replaceTextInRange):
2867         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2868         (WTR::AccessibilityUIElement::replaceTextInRange):
2869
2870 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2871
2872         [iOS] Do not allow starting selection drags when selection views are not visible
2873         https://bugs.webkit.org/show_bug.cgi?id=196686
2874         <rdar://problem/49399192>
2875
2876         Reviewed by Tim Horton.
2877
2878         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2879         also add some new API tests to cover scenarios where the web view is not first responder.
2880
2881         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2882         (TestWebKitAPI::TEST):
2883         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2884
2885         Add a switch to optionally make the web view first responder when starting the simulated drag.
2886
2887         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2888         (-[DragAndDropSimulator initWithWebView:]):
2889         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2890
2891 2019-04-08  Justin Fan  <justin_fan@apple.com>
2892
2893         [Web GPU] Fix Web GPU experimental feature on iOS
2894         https://bugs.webkit.org/show_bug.cgi?id=196632
2895
2896         Reviewed by Myles C. Maxfield.
2897
2898         Properly make Web GPU available on iOS 11+.
2899
2900         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2901
2902 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-build] Do not upload archive when Compile Fails
2905         https://bugs.webkit.org/show_bug.cgi?id=196674
2906
2907         Reviewed by Alexey Proskuryakov.
2908
2909         * BuildSlaveSupport/ews-build/factories.py:
2910         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2911         * BuildSlaveSupport/ews-build/steps.py:
2912         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2913         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2914         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2915
2916 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2917
2918         Enable DFG on MIPS
2919         https://bugs.webkit.org/show_bug.cgi?id=196689
2920
2921         Reviewed by Žan Doberšek.
2922
2923         Since the bytecode change, we enabled the baseline JIT on mips in
2924         r240432, but DFG is still missing. With this change, all tests are
2925         passing on a ci20 board.
2926
2927         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2928
2929 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2930
2931         [Flatpak] Second run update-webkitwpe-flatpak fails
2932         https://bugs.webkit.org/show_bug.cgi?id=192702
2933
2934         Reviewed by Carlos Garcia Campos.
2935
2936         * flatpak/flatpakutils.py:
2937         (FlatpakObject.flatpak): Fix typo.
2938         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2939         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2940
2941 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2942
2943         [GTK][WPE] outlook.live.com displays old-fashioned UI
2944         https://bugs.webkit.org/show_bug.cgi?id=196642
2945
2946         Reviewed by Carlos Garcia Campos.
2947
2948         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2949         (TestWebKitAPI::TEST): New Mac platform quirk test.
2950
2951 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2952
2953         Unreviewed, rolling out r243956.
2954         https://bugs.webkit.org/show_bug.cgi?id=196688
2955
2956         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2957         by aakashjain on #webkit).
2958
2959         Reverted changeset:
2960
2961         "Clicking "Go Back" from a safe browsing warning from an
2962         iframe should navigate the WKWebView back to the previous
2963         page"
2964         https://bugs.webkit.org/show_bug.cgi?id=196665
2965         https://trac.webkit.org/changeset/243956
2966
2967 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2968
2969         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2970         https://bugs.webkit.org/show_bug.cgi?id=196669
2971
2972         Reviewed by Geoffrey Garen.
2973
2974         Added three new unit tests for WeakHashSet.
2975
2976         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2977         (WTF_WeakPtr.WeakHashSetConstObjects):
2978         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2979         (WTF_WeakPtr.WeakHashSetComputeSize):
2980
2981 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2982
2983         Hide next and previous form control buttons when WKWebView is editable
2984         https://bugs.webkit.org/show_bug.cgi?id=196672
2985         <rdar://problem/35625321>
2986
2987         Reviewed by Tim Horton.
2988
2989         Add a new API test.
2990
2991         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2992         (-[TestWKWebView lastTrailingBarButtonGroup]):
2993         (TestWebKitAPI::TEST):
2994         * TestWebKitAPI/ios/UIKitSPI.h:
2995
2996 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2997
2998         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2999         https://bugs.webkit.org/show_bug.cgi?id=196077
3000         <rdar://problem/49108202>
3001
3002         Reviewed by Chris Dumez.
3003
3004         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3005         on new web view.
3006
3007         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3008
3009 2019-04-05  Saam Barati  <sbarati@apple.com>
3010
3011         Make compare-results understand MotionMark
3012         https://bugs.webkit.org/show_bug.cgi?id=196666
3013
3014         Reviewed by Yusuke Suzuki.
3015
3016         * Scripts/compare-results:
3017         (PLT5Results):
3018         (detectMotionMark):
3019         (detectMotionMark1_1):
3020         (motionMarkResults):
3021         (motionMark1_1Results):
3022         (detectBenchmark):
3023         (biggerIsBetter):
3024         (main):
3025
3026 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3027
3028         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3029         https://bugs.webkit.org/show_bug.cgi?id=196665
3030         <rdar://45115669>
3031
3032         Reviewed by Geoff Garen.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3035         (goBack):
3036         (+[SimpleLookupContext sharedLookupContext]):
3037         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3038         (TEST):
3039         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3040         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3041
3042 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3043
3044         [ews-build] Add configuration and architecture for windows builders
3045         https://bugs.webkit.org/show_bug.cgi?id=196660
3046
3047         Reviewed by Lucas Forschler.
3048
3049         * BuildSlaveSupport/ews-build/config.json:
3050
3051 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3052
3053         webkitpy: Don't run subsequent rounds if interrupted
3054         https://bugs.webkit.org/show_bug.cgi?id=196646
3055
3056         Reviewed by Aakash Jain.
3057
3058         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3059         (Manager.run): Bail out if interrupted.
3060
3061 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3062
3063         Test sessionStorage in PSON private browsing mode
3064         https://bugs.webkit.org/show_bug.cgi?id=196561
3065
3066         Reviewed by Alex Christensen.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3069
3070 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3071
3072         Unreviewed, rolling out r243833.
3073         https://bugs.webkit.org/show_bug.cgi?id=196645
3074
3075         This change breaks build of WPE and GTK ports (Requested by
3076         annulen on #webkit).
3077
3078         Reverted changeset:
3079
3080         "[CMake][WTF] Mirror XCode header directories"
3081         https://bugs.webkit.org/show_bug.cgi?id=191662
3082         https://trac.webkit.org/changeset/243833
3083
3084 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3085
3086         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3087         https://bugs.webkit.org/show_bug.cgi?id=196635
3088
3089         Reviewed by Antti Koivisto.
3090         
3091         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3092         for a test to enable async frame scrolling via:
3093             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3094         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3095         
3096         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3097
3098         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3099         (WTR::InjectedBundle::beginTesting):
3100         * WebKitTestRunner/TestController.cpp:
3101         (WTR::TestController::resetPreferencesToConsistentValues):
3102
3103 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3104
3105         Use a correct LC_RPATH when building with ASan
3106         https://bugs.webkit.org/show_bug.cgi?id=196576
3107
3108         Reviewed by David Kilzer.
3109
3110         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3111         so that ../Frameworks is checked. This is simpler and more reliable than updating
3112         each SPC service xcconfig.
3113
3114 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3115
3116         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3117         https://bugs.webkit.org/show_bug.cgi?id=196629
3118
3119         Reviewed by Lucas Forschler.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3122
3123 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3124
3125         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3126         https://bugs.webkit.org/show_bug.cgi?id=196618
3127
3128         Reviewed by Lucas Forschler.
3129
3130         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3131         (StatusBubble): Added QUEUE_TRIGGERS.
3132         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3133         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3134         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3135         its parent(builder).
3136
3137 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3138
3139         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3140         https://bugs.webkit.org/show_bug.cgi?id=196625
3141
3142         Reviewed by Lucas Forschler.
3143
3144         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3145         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3146
3147 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3148
3149         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3150         https://bugs.webkit.org/show_bug.cgi?id=196630
3151
3152         Reviewed by Wenson Hsieh.
3153
3154         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3155
3156 2019-04-04  Youenn Fablet  <youenn@apple.com>
3157
3158         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3159         https://bugs.webkit.org/show_bug.cgi?id=196543
3160
3161         Reviewed by Alex Christensen.
3162
3163         * WebKitTestRunner/TestController.cpp:
3164         (WTR::TestController::generatePageConfiguration):
3165
3166 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-app] Status bubble should not display skipped buildbot steps
3169         https://bugs.webkit.org/show_bug.cgi?id=196584
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3174
3175 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3178         https://bugs.webkit.org/show_bug.cgi?id=196620
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-app/ews/config.py:
3183
3184 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3185
3186         [Win] DumpRenderTreeWatchDog.py is not checked into source
3187         https://bugs.webkit.org/show_bug.cgi?id=196567
3188         <rdar://problem/49525901>
3189
3190         Reviewed by Lucas Forschler.
3191
3192         This script is used on Win EWS bots to terminate hanging DRT processes.
3193
3194         * EWSTools/dumprendertreewatchdog.py: Added.
3195
3196 2019-04-04  Chris Dumez  <cdumez@apple.com>
3197
3198         Unreviewed, roll out r243858 which made tests time out.
3199
3200         Disable new API tests on Windows instead.
3201
3202         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3203         (TestWebKitAPI::TEST):
3204
3205 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3206
3207         [ATK] Cleanup WebPageAccessibilityObjectAtk
3208         https://bugs.webkit.org/show_bug.cgi?id=196537
3209
3210         Reviewed by Michael Catanzaro.
3211
3212         Also consider files under atk directories as exceptions for GObject conventions.
3213
3214         * Scripts/webkitpy/style/checkers/cpp.py:
3215         (check_identifier_name_in_declaration):
3216
3217 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3218
3219         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3220         https://bugs.webkit.org/show_bug.cgi?id=196588
3221         <rdar://problem/49365787>
3222
3223         Unreviewed build fix for Windows port.
3224
3225         error C3861: 'kill': identifier not found
3226
3227         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3228         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3229
3230 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3231
3232         [ews-build] Cancel build and similar operations should have authentication
3233         https://bugs.webkit.org/show_bug.cgi?id=196520
3234
3235         Reviewed by Dewei Zhu.
3236
3237         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3238         environment variables.
3239
3240 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [ews-build] Do not trigger queues which are not in production yet
3243         https://bugs.webkit.org/show_bug.cgi?id=196581
3244
3245         Reviewed by Dewei Zhu.
3246
3247         * BuildSlaveSupport/ews-build/config.json:
3248
3249 2019-04-03  Chris Dumez  <cdumez@apple.com>
3250
3251         Unreviewed, fix typo in the name of API test added in r243848.
3252
3253         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3254         (TestWebKitAPI::TEST):
3255
3256 2019-04-03  Chris Dumez  <cdumez@apple.com>
3257
3258         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3259         https://bugs.webkit.org/show_bug.cgi?id=196588
3260         <rdar://problem/49365787>
3261
3262         Reviewed by Ryosuke Niwa.
3263
3264         Add API test coverage.
3265
3266         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3267         (TestWebKitAPI::nullJavaScriptCallback):
3268         (TestWebKitAPI::didCrashCheckFrames):
3269         (TestWebKitAPI::TEST):
3270
3271 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3272
3273         run-webkit-tests: Upload test results (new results database)
3274         https://bugs.webkit.org/show_bug.cgi?id=196577
3275         <rdar://problem/34841155>
3276
3277         Reviewed by Lucas Forschler.
3278
3279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3280         (Manager.run): Upload results after each device shard, since the configuration will be
3281         different for each device.
3282         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3283         uploaded to a results database.
3284         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3285         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3286
3287 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3288
3289         -apple-trailing-word is needed for browser detection
3290         https://bugs.webkit.org/show_bug.cgi?id=196575
3291
3292         Unreviewed.
3293
3294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3295
3296 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3297
3298         [CMake][WTF] Mirror XCode header directories
3299         https://bugs.webkit.org/show_bug.cgi?id=191662
3300
3301         Reviewed by Konstantin Tokarev.
3302
3303         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3304         builds.
3305
3306         * CMakeLists.txt:
3307         * DumpRenderTree/CMakeLists.txt:
3308         * DumpRenderTree/PlatformWin.cmake:
3309         * MiniBrowser/win/CMakeLists.txt:
3310         * TestWebKitAPI/CMakeLists.txt:
3311         * TestWebKitAPI/PlatformWin.cmake:
3312         * WebKitTestRunner/PlatformGTK.cmake:
3313         * WebKitTestRunner/PlatformWin.cmake:
3314
3315 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [ews-app] Status bubble should not display certain infrastructure status messages
3318         https://bugs.webkit.org/show_bug.cgi?id=196550
3319
3320         Reviewed by Lucas Forschler.
3321
3322         Do not display the steps which are un-needed for end-user. This information is still avaiable
3323         if the user click on the bubble and look at the Buildbot build.
3324         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3325         (StatusBubble._steps_messages):
3326         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3327
3328 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3329
3330         [ews-build] Use https for sending data to ews-app
3331         https://bugs.webkit.org/show_bug.cgi?id=196492
3332
3333         Reviewed by Lucas Forschler.
3334
3335         * BuildSlaveSupport/ews-build/events.py:
3336
3337 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3338
3339         Remove support for -apple-trailing-word
3340         https://bugs.webkit.org/show_bug.cgi?id=196525
3341
3342         Reviewed by Zalan Bujtas.
3343
3344         This CSS property is nonstandard and not used.
3345
3346         * Scripts/webkitperl/FeatureList.pm:
3347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3348
3349 2019-04-03  Youenn Fablet  <youenn@apple.com>
3350
3351         Add a test for DOMCache on multiple browsing in case of private browsing
3352         https://bugs.webkit.org/show_bug.cgi?id=196524
3353
3354         Reviewed by Alex Christensen.
3355
3356         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3357         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3358
3359 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3360
3361         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3362         https://bugs.webkit.org/show_bug.cgi?id=196540
3363
3364         Reviewed by Aakash Jain.
3365
3366         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3367
3368 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3369
3370         Add plumbing for a compatibility mode preference in WebKit
3371         https://bugs.webkit.org/show_bug.cgi?id=196005
3372
3373         Reviewed by Tim Horton.
3374
3375         Add new API tests.
3376
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3379
3380 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3381
3382         [WPE][GTK] Update libsrtp dependency package for Debian
3383         https://bugs.webkit.org/show_bug.cgi?id=196528
3384
3385         Reviewed by Frédéric Wang.
3386
3387         * gtk/install-dependencies:
3388         * wpe/install-dependencies:
3389
3390 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3391
3392         [WK2] Add support for Window's beforeprint / afterprint events
3393         https://bugs.webkit.org/show_bug.cgi?id=196478
3394         <rdar://problem/49535124>
3395
3396         Unreviewed build fix for MSVC.
3397
3398         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3399
3400         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3401
3402         * WebKitTestRunner/TestController.cpp:
3403         (WTR::printFrame): Use int and float literals.
3404
3405 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3406
3407         [ews-build] Reassign bots to queues
3408
3409         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3410
3411 2019-04-02  Chris Dumez  <cdumez@apple.com>
3412
3413         [WK2] Add support for Window's beforeprint / afterprint events
3414         https://bugs.webkit.org/show_bug.cgi?id=196478
3415
3416         Reviewed by Alex Christensen.
3417
3418         Add minimal implementation for printFrame in WebKitTestRunner.
3419
3420         * WebKitTestRunner/TestController.cpp:
3421         (WTR::printFrame):
3422         (WTR::TestController::createOtherPage):
3423         (WTR::TestController::createWebViewWithOptions):
3424
3425 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3428         https://bugs.webkit.org/show_bug.cgi?id=196491
3429
3430         Reviewed by Lucas Forschler.
3431
3432         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3433
3434 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3435
3436         [ews-build] Configure buildbot try credentials in environment variables
3437         https://bugs.webkit.org/show_bug.cgi?id=196501
3438
3439         Reviewed by Lucas Forschler.
3440
3441         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3442         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3443         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3444
3445 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3446
3447         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3448         https://bugs.webkit.org/show_bug.cgi?id=196496
3449         <rdar://problem/49521634>
3450
3451         Reviewed by Chris Dumez.
3452
3453         Add new API tests (see WebKit ChangeLog for more detail).
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3456         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3457         (TEST):
3458
3459 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3460
3461         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3462         <https://webkit.org/b/196499>
3463
3464         Reviewed by Alexey Proskuryakov.
3465
3466         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3467         ENABLE_ADDRESS_SANITIZER.
3468
3469 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3470
3471         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3472         https://bugs.webkit.org/show_bug.cgi?id=182757
3473
3474         Reviewed by Don Olmstead.
3475
3476         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3477         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3478
3479 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3480
3481         run-api-tests: Upload test results
3482         https://bugs.webkit.org/show_bug.cgi?id=196323
3483         <rdar://problem/49356714>
3484
3485         Reviewed by Lucas Forschler.
3486
3487         * Scripts/webkitpy/api_tests/manager.py:
3488         (Manager):
3489         (Manager.run): Upload results to a results database.
3490         * Scripts/webkitpy/api_tests/run_api_tests.py:
3491         (parse_args): Add upload arguments.
3492         * Scripts/webkitpy/port/base.py:
3493         (Port):
3494         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3495         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3496         with commits from any other associated repositories.
3497         * Scripts/webkitpy/port/device.py:
3498         (Device):
3499         (Device.build_version): Access build_versoin of underlying platform device.
3500         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3501         (IOSSimulatorTest):
3502         (IOSSimulatorTest.test_configuration_for_upload):
3503         * Scripts/webkitpy/port/device_port.py:
3504         (DevicePort):
3505         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3506         the same as the machine uploading results.
3507         * Scripts/webkitpy/port/mac.py:
3508         (MacPort):
3509         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3510         * Scripts/webkitpy/port/mac_unittest.py:
3511         (MacTest):
3512         (MacTest.test_configuration_for_upload):
3513         * Scripts/webkitpy/xcode/simulated_device.py:
3514         (SimulatedDeviceManager._create_device_with_runtime):
3515         (SimulatedDevice.__init__): Create simulated device with a build_version.
3516         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3517         (test_existing_simulator):
3518
3519 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3520
3521         Remove extra newline characters (Follow-up fix to r243707)
3522
3523         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3524
3525 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-app] Use API_KEY to accept results data
3528         https://bugs.webkit.org/show_bug.cgi?id=196461
3529
3530         Reviewed by Dewei Zhu.
3531
3532         * BuildSlaveSupport/ews-app/ews/views/results.py:
3533         (Results.post): Validate EWS_API_KEY before accepting any data.
3534         * BuildSlaveSupport/ews-build/events.py:
3535         (Events.sendData): Send EWS_API_KEY if available along with event data.
3536
3537 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3538
3539         Unable to copy and paste a PDF from Notes into Mail compose body
3540         https://bugs.webkit.org/show_bug.cgi?id=196442
3541         <rdar://problem/48573098>
3542
3543         Reviewed by Tim Horton.
3544
3545         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3546         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3547         to be specified on the item providers.
3548
3549         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3550         (TestWebKitAPI::mapItemForTesting):
3551         (TestWebKitAPI::contactItemForTesting):
3552
3553 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3554
3555         Make UIWKDocumentContext rects per-character instead of per-word
3556         https://bugs.webkit.org/show_bug.cgi?id=196459
3557
3558         Reviewed by Wenson Hsieh.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3561         (TEST):
3562         Adjust test results due to switching to per-character rects.
3563
3564 2019-04-01  Chris Dumez  <cdumez@apple.com>
3565
3566         UIProcess crash when a prewarmed process is terminated
3567         https://bugs.webkit.org/show_bug.cgi?id=196451
3568         <rdar://problem/49245471>
3569
3570         Reviewed by Geoffrey Garen.
3571
3572         Add API test coverage.
3573
3574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3575         (TEST):
3576
3577 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3578
3579         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3580         https://bugs.webkit.org/show_bug.cgi?id=196449
3581
3582         Reviewed by Lucas Forschler.
3583
3584         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3585         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3586         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3587         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3588
3589 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3590
3591         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3592         https://bugs.webkit.org/show_bug.cgi?id=196444
3593
3594         Reviewed by Lucas Forschler.
3595
3596         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3597
3598 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3599
3600         Add SPI to canonicalize NSURLs with WTF::URL
3601         https://bugs.webkit.org/show_bug.cgi?id=196415
3602         <rdar://problem/44980271>
3603
3604         Reviewed by Darin Adler.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3608         (TestWebKitAPI::TEST):
3609
3610 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3611
3612         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3613         https://bugs.webkit.org/show_bug.cgi?id=196441
3614
3615         Reviewed by Carlos Garcia Campos.
3616
3617         Don't cache the wpe_view_backend object that might not exist yet at the
3618         time of EventSenderProxy constructor invocation, but instead retrieve
3619         that object whenever it's required for event dispatching. This should
3620         avoid crashes in this constructor now that it's invoked before any
3621         PlatformWindow has been set up (as changed in r243496).
3622
3623         * WebKitTestRunner/EventSenderProxy.h:
3624         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3625         (WTR::viewBackend):
3626         (WTR::EventSenderProxy::EventSenderProxy):
3627         (WTR::EventSenderProxy::mouseDown):
3628         (WTR::EventSenderProxy::mouseUp):
3629         (WTR::EventSenderProxy::mouseMoveTo):
3630         (WTR::EventSenderProxy::mouseScrollBy):
3631         (WTR::EventSenderProxy::keyDown):
3632         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3633
3634 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3635
3636         [Win][WebKit] MiniBrowser should support high DPI display
3637         https://bugs.webkit.org/show_bug.cgi?id=196391
3638
3639         Reviewed by Alex Christensen.
3640
3641         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3642         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3643         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3644         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3645
3646 2019-03-31  Sam Weinig  <weinig@apple.com>
3647
3648         Remove more i386 specific configurations
3649         https://bugs.webkit.org/show_bug.cgi?id=196430
3650
3651         Reviewed by Alexey Proskuryakov.
3652
3653         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3654         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3655
3656 2019-03-31  Andy Estes  <aestes@apple.com>
3657
3658         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3659         https://bugs.webkit.org/show_bug.cgi?id=196433
3660         <rdar://problem/49293305>
3661
3662         Reviewed by Tim Horton.
3663
3664         Enhanced API test coverage to include all navigation response policy decisions in both
3665         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3666
3667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3668         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3669         (TestWebKitAPI::TEST):
3670         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3671         (readFile):
3672         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3673         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3674         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3675         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3676         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3677         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3678         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3679         (-[QuickLookDelegate _downloadDidStart:]):
3680         (-[QuickLookDelegate _download:didReceiveResponse:]):
3681         (-[QuickLookDelegate _download:didReceiveData:]):
3682         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3683         (-[QuickLookDelegate _downloadDidFinish:]):
3684         (-[QuickLookDelegate _download:didFailWithError:]):
3685         (-[QuickLookDelegate _downloadDidCancel:]):
3686         (-[QuickLookDelegate verifyDownload]):
3687         (runTest):
3688         (runTestDecideBeforeLoading):
3689         (runTestDecideAfterLoading):
3690         (TEST):
3691         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3692         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3693         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3694         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3695         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3696         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3697         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3698         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3699         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3700         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3701         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3702         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3703         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3704         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3705
3706 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3707
3708         [CMake] add testdfg as target with build-jsc
3709         https://bugs.webkit.org/show_bug.cgi?id=196393
3710
3711         Reviewed by Saam Barati.
3712
3713         Added testdfg as one of the targets to build when
3714         using CMake.
3715
3716         * Scripts/build-jsc:
3717
3718 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3719
3720         Delete WebMetal implementation in favor of WebGPU
3721         https://bugs.webkit.org/show_bug.cgi?id=195418
3722
3723         Reviewed by Dean Jackson.
3724
3725         * DumpRenderTree/mac/DumpRenderTree.mm:
3726         (enableExperimentalFeatures):
3727         (resetWebPreferencesToConsistentValues):
3728         * Scripts/webkitperl/FeatureList.pm:
3729         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3731         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3732         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3733         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3734         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3735         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3736         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3737         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3738         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3739         (WTR::InjectedBundle::beginTesting):
3740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3741         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3743
3744 2019-03-29  Chris Dumez  <cdumez@apple.com>
3745
3746         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3747         https://bugs.webkit.org/show_bug.cgi?id=196405
3748         <rdar://problem/49428130>
3749
3750         Reviewed by Wenson Hsieh.
3751
3752         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3753         the popover presentation methods to be no-ops. Use this in the new test added in
3754         r243523 so that we do not swizzle those methods for all tests. This is needed because
3755         those WatchOS tests rely on the popover getting presented and interactive.
3756
3757         * WebKitTestRunner/TestController.cpp:
3758         (WTR::updateTestOptionsFromTestHeader):
3759         * WebKitTestRunner/TestController.h:
3760         * WebKitTestRunner/TestOptions.h:
3761         (WTR::TestOptions::hasSameInitializationOptions const):
3762         * WebKitTestRunner/ios/TestControllerIOS.mm:
3763         (WTR::TestController::platformInitialize):
3764         (WTR::TestController::platformResetStateToConsistentValues):
3765
3766 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3767
3768         [Curl] Add Server Trust Evaluation Support.
3769         https://bugs.webkit.org/show_bug.cgi?id=191646
3770
3771         Reviewed by Fujii Hironori.
3772
3773         Implemented MiniBrowser UI for asking if user trusts the server.
3774
3775         * MiniBrowser/win/Common.cpp:
3776         (askServerTrustEvaluation):
3777         (replaceString):
3778         * MiniBrowser/win/Common.h:
3779         * MiniBrowser/win/MiniBrowserLib.rc:
3780         * MiniBrowser/win/MiniBrowserLibResource.h:
3781         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3782         (createPEMString):
3783         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3784         (WebKitBrowserWindow::canTrustServerCertificate):
3785         * MiniBrowser/win/WebKitBrowserWindow.h:
3786
3787 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3788
3789         Implement ResizeObserver.
3790         https://bugs.webkit.org/show_bug.cgi?id=157743
3791
3792         Reviewed by Simon Fraser.
3793
3794         Support resizeObserverEnabled webPreferences.
3795
3796         * DumpRenderTree/TestOptions.cpp:
3797         (TestOptions::TestOptions):
3798         * DumpRenderTree/TestOptions.h:
3799         * DumpRenderTree/mac/DumpRenderTree.mm:
3800         (setWebPreferencesForTestOptions):
3801         * DumpRenderTree/win/DumpRenderTree.cpp:
3802         (enableExperimentalFeatures):
3803         * Scripts/webkitperl/FeatureList.pm:
3804         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3805
3806 2019-03-28  John Wilander  <wilander@apple.com>
3807
3808         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3809         https://bugs.webkit.org/show_bug.cgi?id=196281
3810         <rdar://problem/48938748>
3811
3812         Reviewed by Alex Christensen.
3813
3814         This patch adds the function isStatisticsHasLocalStorage() to the
3815         TestRunner. With it, the page can query the WebsiteDataStore in the
3816         UI process to make sure that it sees LocalStorage.
3817
3818         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3819         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3820         (WTR::TestRunner::isStatisticsHasLocalStorage):
3821         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3822         * WebKitTestRunner/TestController.cpp:
3823         (WTR::TestController::isStatisticsHasLocalStorage):
3824         * WebKitTestRunner/TestController.h:
3825         * WebKitTestRunner/TestInvocation.cpp:
3826         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3827
3828 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3829
3830         API::Data::createWithoutCopying should do a null check before calling CFRelease
3831         https://bugs.webkit.org/show_bug.cgi?id=196276
3832         <rdar://problem/48059859>
3833
3834         Reviewed by Alex Christensen.
3835
3836         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3840         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3841         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3842         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3843         (TestWebKitAPI::TEST):
3844
3845 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3846
3847         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3848         https://bugs.webkit.org/show_bug.cgi?id=186276
3849
3850         Reviewed by Carlos Garcia Campos.
3851
3852         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3853         (webViewLoadChanged):
3854         (testWebResourceGetDataError):
3855         (testWebResourceGetDataEmpty):
3856         (beforeAll):
3857         (webViewloadChanged): Deleted.
3858
3859 2019-03-27  Andy Estes  <aestes@apple.com>
3860
3861         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3862         https://bugs.webkit.org/show_bug.cgi?id=196317
3863
3864         Reviewed by Dan Bernstein.
3865
3866         package-root copies built products into a staging directory using ditto(1), which does not
3867         follow symbolic links as it traverses a directory. Now that the files in
3868         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3869         itself, these become broken links when ditto'd into the staging directory.
3870
3871         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3872
3873         * Scripts/package-root:
3874
3875 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3876
3877         [ews-app] Update display text of Submit for ews analysis
3878         https://bugs.webkit.org/show_bug.cgi?id=196309
3879
3880         Reviewed by Dewei Zhu.
3881
3882         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3883
3884 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3885
3886         run-webkit-tests should check for leaks in WebKit processes
3887         <https://webkit.org/b/193772>
3888         <rdar://problem/46526680>
3889
3890         Reviewed by Ryosuke Niwa.
3891
3892         This works by doing the following:
3893         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3894           The list of child processes are returned one per line:
3895           process.name: pid
3896         - Run the "#LIST CHILD PROCESSES" command just before the
3897           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3898           processes on the ServerProcess object.
3899         - When the `--leaks` switch is handled, run check_for_leaks() on
3900           each child process after the main test harness.
3901
3902         * DumpRenderTree/mac/DumpRenderTree.mm:
3903         (handleControlCommand):
3904         - Use strncmp() instead of strcmp().
3905         - Add support for handling "#LIST CHILD PROCESSES" command.
3906
3907         * Scripts/webkitpy/port/base.py:
3908         (Port.check_for_leaks):
3909         * Scripts/webkitpy/port/darwin.py:
3910         (DarwinPort.check_for_leaks):
3911         - Rename redundant 'process_pid' argument to 'process_id'.
3912
3913         * Scripts/webkitpy/port/driver.py:
3914         (Driver.do_post_tests_work):
3915         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3916           longer the only command this sends to WebKitTestRunner.
3917         - If the `--leaks` switch is present, send the
3918           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3919           result using Port.set_webkit_processes().
3920         (Driver._parse_child_processes_output):
3921         - Add helper method to parse list of child process names and
3922           process IDs returned from WebKitTestRunner.
3923
3924         * Scripts/webkitpy/port/ios_device.py:
3925         (IOSDevicePort.check_for_leaks):
3926         - Rename redundant 'process_pid' argument to 'process_id'.
3927
3928         * Scripts/webkitpy/port/leakdetector.py:
3929         (LeakDetector._parse_leaks_output):
3930         - Return early if there is no leaks_output.
3931         (LeakDetector.check_for_leaks):
3932         - Rename redundant 'process_pid' argument to 'process_id'.
3933
3934         * Scripts/webkitpy/port/server_process.py:
3935         (ServerProcess.__init__):
3936         (ServerProcess.child_processes):
3937         (ServerProcess.set_child_processes):
3938         - Add instance variable to Port to store list of child process
3939           names and process IDs returned from WebKitTestRunner.
3940         (ServerProcess._start):
3941         - Clear self._child_processes.
3942         (ServerProcess.stop):
3943         - If self._child_processes is set, call
3944           self._port.check_for_leaks() for each child process.
3945
3946         * Scripts/webkitpy/port/server_process_unittest.py:
3947         (TrivialMockPort.check_for_leaks):
3948         - Rename redundant 'process_pid' argument to 'process_id'.
3949
3950         * Scripts/webkitpy/port/simulator_process.py:
3951         (SimulatorProcess.stop):
3952         - If self._child_processes is set, call
3953           self._port.check_for_leaks() for each child process.
3954
3955         * Scripts/webkitpy/port/watch_device.py:
3956         (WatchDevicePort.check_for_leaks):
3957         - Rename redundant 'process_pid' argument to 'process_id'.
3958
3959         * WebKitTestRunner/TestController.cpp:
3960         (WTR::TestController::dumpResponse):
3961         - Extract method from findAndDumpWorldLeaks() so that it may be
3962           reused by findAndDumpWebKitProcessIdentifiers().
3963         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3964         - Add method to output process name and process ID of both the
3965           WebContent and Networking processes.
3966         (WTR::TestController::findAndDumpWorldLeaks):
3967         - Fix missing newline in output when there were no abandoned
3968           documents.
3969         - Call dumpResponse() for extracted code.
3970         (WTR::TestController::handleControlCommand):
3971         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3972         - Use strncmp() instead of strcmp().
3973         - Call findAndDumpWebKitProcessIdentifiers() when
3974           "#LIST CHILD PROCESSES" command is sent.
3975         * WebKitTestRunner/TestController.h:
3976         (WTR::TestController::dumpResponse):
3977         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3978         - Declare methods.
3979
3980 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3981
3982         Unreviewed. Add GLib API test cases after r243434.
3983
3984         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3985         (testWebViewActiveURI):
3986         (serverCallback):
3987         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3988         (sendRequestCallback):
3989
3990 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3991
3992         Geolocation request not complete when watch request was started in a different web process
3993         https://bugs.webkit.org/show_bug.cgi?id=195996
3994
3995         Reviewed by Alex Christensen.
3996
3997         Add a test case.
3998
3999         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
4000         (TestWebKitAPI::runJavaScriptAlert):
4001         (TestWebKitAPI::TEST):
4002
4003 2019-03-26  Keith Rollin  <krollin@apple.com>
4004
4005         Update the way generate-xcfilelists returns strings from functions
4006         https://bugs.webkit.org/show_bug.cgi?id=195975
4007         <rdar://problem/49040807>
4008
4009         Reviewed by Dean Jackson.
4010
4011         There are places where generate-xcfilelists executes assignments with
4012         statements like:
4013
4014             FOO=$(some_function)
4015
4016         where "some_function" return a string by echoing it. E.g.
4017
4018             some_function()
4019             {
4020                 echo "Hello, World"
4021             }
4022
4023         This is a common idiom, but it has a problem if "some_function" needs
4024         to call "exit" in an attempt to halt the entire script right then and
4025         there. Since "some_function" is called inside of $(), it's being
4026         executed in a sub-shell. Calling exit in that sub-shell simply exits
4027         that shell; it doesn't not exit the outer shell in which the main part
4028         of the script is still running. As such, the main script keeps
4029         executing when the intent was for the script to halt.
4030
4031         The solution to this is to use a different idiom for returning
4032         strings. The one we now is to pass in the name of the variable to
4033         receive the string result:
4034
4035             some_function()
4036             {
4037                 variable_name=$1
4038                 eval $variable_name ="Hello, World"
4039             }
4040
4041         The call site now looks like
4042
4043             some_function FOO
4044
4045         Because there's no invocation of a sub-shell, some_function can now
4046         call "exit" if it wants to, and the entire script will exit at that
4047         point.
4048
4049         * Scripts/generate-xcfilelists:
4050
4051 2019-03-26  Chris Dumez  <cdumez@apple.com>
4052
4053         Add basic layout test coverage for File Picker on iOS
4054         https://bugs.webkit.org/show_bug.cgi?id=196265
4055
4056         Reviewed by Wenson Hsieh.
4057
4058         Add layout test infrastructure to test the file picker on iOS.
4059
4060         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4061         (WTR::UIScriptController::dismissFilePicker):
4062         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4063         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4064         (WTR::UIScriptController::dismissFilePicker):
4065         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4066         * WebKitTestRunner/TestController.cpp:
4067         (WTR::TestController::createWebViewWithOptions):
4068         (WTR::updateTestOptionsFromTestHeader):
4069         * WebKitTestRunner/TestOptions.h:
4070         (WTR::TestOptions::hasSameInitializationOptions const):
4071         * WebKitTestRunner/ios/TestControllerIOS.mm:
4072         (overridePresentViewController):
4073         (WTR::TestController::platformInitialize):
4074         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4075         (WTR::UIScriptController::dismissFilePicker):
4076
4077 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4078
4079         Implement async paste method on UIWKInteractionViewProtocol
4080         https://bugs.webkit.org/show_bug.cgi?id=196267
4081         <rdar://problem/49236346>
4082
4083         Reviewed by Tim Horton.
4084
4085         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4086         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4087         are now a part of all iOS 12 internal SDKs.
4088
4089         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4090
4091         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4092         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4093
4094         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4095         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4096         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4097         * TestWebKitAPI/ios/UIKitSPI.h:
4098
4099 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4100
4101         [ews-build] Use PostgreSQL for ews.webkit.org database
4102         https://bugs.webkit.org/show_bug.cgi?id=196270
4103
4104         Reviewed by Lucas Forschler.
4105
4106         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4107
4108 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4109
4110         [ews] Reset simctl states on reboot
4111         https://bugs.webkit.org/show_bug.cgi?id=196260
4112
4113         Rubber-stamped by Aakash Jain.
4114
4115         * EWSTools/start-queue-mac.sh:
4116
4117 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4118
4119         [ews-build] Use PostgreSQL for ews-build database
4120         https://bugs.webkit.org/show_bug.cgi?id=196229
4121
4122         Reviewed by Lucas Forschler.
4123
4124         * BuildSlaveSupport/ews-build/master.cfg:
4125
4126 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4127
4128         [ews-build] Get master_hostname dynamically in master.cfg
4129         https://bugs.webkit.org/show_bug.cgi?id=196255
4130
4131         Reviewed by Lucas Forschler.
4132
4133         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4134         send events data in test mode.
4135
4136 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4137
4138         [ews-app] Set db_constraint to False for Foreign Keys
4139         https://bugs.webkit.org/show_bug.cgi?id=196252
4140
4141         Reviewed by Lucas Forschler.
4142
4143         * BuildSlaveSupport/ews-app/ews/models/build.py:
4144         * BuildSlaveSupport/ews-app/ews/models/step.py:
4145
4146 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-build] is_test_mode_enabled should default to True
4149         https://bugs.webkit.org/show_bug.cgi?id=196248
4150
4151         Reviewed by Lucas Forschler.
4152
4153         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4154
4155 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4156
4157         [ews-app] Add webkitperl to ENABLED_QUEUES
4158         https://bugs.webkit.org/show_bug.cgi?id=196253
4159
4160         Reviewed by Lucas Forschler.
4161
4162         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4163
4164 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4165
4166         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4167         https://bugs.webkit.org/show_bug.cgi?id=196211
4168         rdar://problem/49110552
4169
4170         Reviewed by Tim Horton.
4171
4172         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4173         Make sure that EventSenderProxy always exists when running tests. We used to create
4174         it when resetting before the first test, which is a bit too late.
4175
4176         * WebKitTestRunner/TestController.h:
4177         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4178         (WTR::TestController::platformCreateWebView):
4179         (WTR::TestController::platformCreateOtherPage):
4180         (WTR::TestController::finishCreatingPlatformWebView):
4181         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4182         (WTR::PlatformWebView::PlatformWebView):
4183         Moved some code that made NSWindow use NSEvent during web view creation. We may
4184         need to move more if some other case us found, but this is enough for now.
4185
4186 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4187
4188         Unreviewed. Fix typo in GLib geolocation API after r243285.
4189
4190         gelocation -> geolocation.
4191
4192         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4193         (testGeolocationManagerWatchPosition):
4194
4195 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4196
4197         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4198         https://bugs.webkit.org/show_bug.cgi?id=196213
4199
4200         Reviewed by Geoff Garen.
4201
4202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4203         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4204         (credentialWithIdentityAndKeychainPath):
4205         (-[ChallengeDelegate webView:didFinishNavigation:]):
4206         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4207         (TestWebKitAPI::TEST):
4208
4209 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4210
4211         Expected shouldn't assume its contained types are copyable
4212         https://bugs.webkit.org/show_bug.cgi?id=195986
4213
4214         Reviewed by JF Bastien.
4215
4216         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4217         (TestWebKitAPI::NonCopyable::operator== const):
4218         (TestWebKitAPI::NonCopyable::operator!= const):
4219         (TestWebKitAPI::TEST):
4220
4221 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4222
4223         Remove some now-unnecessary dynamic class lookup
4224         https://bugs.webkit.org/show_bug.cgi?id=196237
4225
4226         Reviewed by Simon Fraser.
4227
4228         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4229         (makeRequest):
4230         (TEST):
4231
4232 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4233
4234         Unreviewed, rolling out r243450.
4235
4236         AppleWin and WinCairo port builds get broken.
4237
4238         Reverted changeset:
4239
4240         "Add test for fix of #196095"
4241         https://bugs.webkit.org/show_bug.cgi?id=196097
4242         https://trac.webkit.org/changeset/243450
4243
4244 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4245
4246         Unreviewed, rolling out r243465.
4247         https://bugs.webkit.org/show_bug.cgi?id=196226
4248
4249         the test doesn't build (Requested by thorton on #webkit).
4250
4251         Reverted changeset:
4252
4253         "Do not terminate the NetworkProcess if a third party
4254         application sends a NSCredential with a SecIdentityRef"
4255         https://bugs.webkit.org/show_bug.cgi?id=196213
4256         https://trac.webkit.org/changeset/243465
4257
4258 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4259
4260         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4261         https://bugs.webkit.org/show_bug.cgi?id=196213
4262
4263         Reviewed by Geoff Garen.
4264
4265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4266         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4267         (credentialWithIdentityAndKeychainPath):
4268         (-[ChallengeDelegate webView:didFinishNavigation:]):
4269         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4270         (TestWebKitAPI::TEST):
4271
4272 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4273
4274         [ews-build] Gracefully handle missing patch_id in events
4275         https://bugs.webkit.org/show_bug.cgi?id=196216
4276
4277         Reviewed by Lucas Forschler.
4278
4279         * BuildSlaveSupport/ews-build/events.py:
4280
4281 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4282
4283         [ews-build] use lz4 compression for improving buildbot performance
4284         https://bugs.webkit.org/show_bug.cgi?id=196155
4285
4286         Reviewed by Lucas Forschler.
4287
4288         * BuildSlaveSupport/ews-build/master.cfg:
4289
4290 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4291
4292         Pull some API testing helper methods out of TestWKWebView
4293         https://bugs.webkit.org/show_bug.cgi?id=196212
4294
4295         Reviewed by Tim Horton.
4296
4297         Refactor some more API testing utility methods, so that they can be used in
4298         tests that do not use TestWKWebView.
4299
4300         * TestWebKitAPI/cocoa/TestWKWebView.h:
4301         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4302         (-[WKWebView loadTestPageNamed:]):
4303         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4304         (-[WKWebView synchronouslyLoadHTMLString:]):
4305         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4306         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4307         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4308         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.