[WPE][GTK] Enable support for CONTENT_EXTENSIONS
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4         https://bugs.webkit.org/show_bug.cgi?id=167941
5
6         Reviewed by Carlos Garcia Campos.
7
8         * MiniBrowser/gtk/main.c:
9         (filterSavedCallback): Added.
10         (main): Support loading a JSON rule set file for content filtering.
11         * MiniBrowser/wpe/main.cpp:
12         (filterSavedCallback): Added.
13         (main): Support loading a JSON rule set file for content filtering.
14         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
15         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
16         (WTF::derefGPtr): Ditto.
17         (testEmptyStore):
18         (testSaveInvalidFilter):
19         (testSaveLoadFilter):
20         (testSavedFilterIdentifierMatch):
21         (testRemoveFilter):
22         (testSaveMultipleFilters):
23         (testSaveFilterFromFile):
24         (testFilterPersistence):
25         (beforeAll):
26         (afterAll):
27         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
28         (removeOldInjectedContentAndResetLists): Also reset content filters.
29         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
30         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
31         the element affected by the style sheet.
32         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
33         and returns it to be used by tests.
34         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
35         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
36         (serverCallback): Add support for serving a CSS style sheet for testing.
37         (beforeAll): Add call to testUserContentManagerContentFilter().
38         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
39
40 2019-02-19  Keith Rollin  <krollin@apple.com>
41
42         Add timing information to build output
43         https://bugs.webkit.org/show_bug.cgi?id=194839
44         <rdar://problem/48219609>
45
46         Reviewed by Alexey Proskuryakov.
47
48         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
49         emit each project's build time to its output. E.g.,
50
51             ** BUILD SUCCEEDED ** [0.132 sec]
52
53         * Scripts/webkitdirs.pm:
54         (XcodeOptions):
55
56 2019-02-19  Truitt Savell  <tsavell@apple.com>
57
58         Unreviewed, rolling out r241784.
59
60         Broke all OpenSource builds.
61
62         Reverted changeset:
63
64         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
65         instances view"
66         https://bugs.webkit.org/show_bug.cgi?id=172848
67         https://trac.webkit.org/changeset/241784
68
69 2019-02-19  Zalan Bujtas  <zalan@apple.com>
70
71         [LFC][Floats] Remove redundant intersecting logic
72         https://bugs.webkit.org/show_bug.cgi?id=194804
73
74         Reviewed by Antti Koivisto.
75
76         * LayoutReloaded/misc/LFC-passing-tests.txt:
77
78 2019-02-19  Dean Jackson  <dino@apple.com>
79
80         Clean-up output from generate-xcfilelists so it can be filtered
81         https://bugs.webkit.org/show_bug.cgi?id=194795
82
83         Reviewed by Joseph Pecoraro (and Keith Rollin).
84
85         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
86         make a slight tweak to filter-build-webkit so such lines are marked
87         as plain.
88
89         * Scripts/filter-build-webkit:
90         * Scripts/generate-xcfilelists:
91
92 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
93
94         pytest is not correctly auto-installed
95         https://bugs.webkit.org/show_bug.cgi?id=194707
96
97         Reviewed by Carlos Garcia Campos.
98
99         * Scripts/webkitpy/thirdparty/__init__.py:
100         (AutoinstallImportHook._install_pytest):
101
102 2019-02-18  Chris Dumez  <cdumez@apple.com>
103
104         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
105         https://bugs.webkit.org/show_bug.cgi?id=194797
106         <rdar://problem/48055151>
107
108         Reviewed by Geoffrey Garen.
109
110         Add API test coverage.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
113
114 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
115
116         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
117         https://bugs.webkit.org/show_bug.cgi?id=194670
118         <rdar://problem/39066529>
119
120         Reviewed by Tim Horton.
121
122         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
123         pasted in an editable area as attachment elements.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
126         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
127         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
129         (TestWebKitAPI::TEST):
130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
131         (WTR::InjectedBundlePage::InjectedBundlePage):
132
133 2019-02-18  Alex Christensen  <achristensen@webkit.org>
134
135         Fix API test after r241728
136        ​https://bugs.webkit.org/show_bug.cgi?id=194723
137
138         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
139         (TEST):
140         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
141
142 2019-02-18  Daniel Bates  <dabates@apple.com>
143
144         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
145         https://bugs.webkit.org/show_bug.cgi?id=192824
146         <rdar://problem/47100332>
147
148         Reviewed by Wenson Hsieh.
149
150         Fix a bug where the wrong usage code was used for F13 thru F24.
151
152         * WebKitTestRunner/ios/HIDEventGenerator.mm:
153         (keyCodeForDOMFunctionKey):
154
155 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
156
157         Bytecode cache should a have a boot-specific validation
158         https://bugs.webkit.org/show_bug.cgi?id=194769
159         <rdar://problem/48149509>
160
161         Reviewed by Keith Miller.
162
163         Add test for WTF::bootSessionUUIDString()
164
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
167         (TEST):
168
169 2019-02-18  Alex Christensen  <achristensen@webkit.org>
170
171         Disable safe browsing in WKWebView and remove its WKPreferences API
172         https://bugs.webkit.org/show_bug.cgi?id=194723
173         <rdar://problem/48122993>
174
175         Reviewed by Geoffrey Garen.
176
177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
178         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
179         (TEST):
180         (safeBrowsingView):
181         Make tests use SPI instead of API.
182
183 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
184
185         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
186         https://bugs.webkit.org/show_bug.cgi?id=194586
187
188         Reviewed by Ross Kirsling.
189
190         * DumpRenderTree/win/DumpRenderTree.cpp:
191         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
192         * Scripts/webkitpy/port/driver.py:
193         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
194
195 2019-02-17  David Kilzer  <ddkilzer@apple.com>
196
197         Unreviewed, rolling out r241620.
198
199         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
200         (Requested by ddkilzer on #webkit.)
201
202         Reverted changeset:
203
204         "[WTF] Add environment variable helpers"
205         https://bugs.webkit.org/show_bug.cgi?id=192405
206         https://trac.webkit.org/changeset/241620
207
208 2019-02-16  Zalan Bujtas  <zalan@apple.com>
209
210         [LFC] RenderImage's default intrinsic size is 0.
211         https://bugs.webkit.org/show_bug.cgi?id=194745
212
213         Reviewed by Antti Koivisto.
214
215         * LayoutReloaded/misc/LFC-passing-tests.txt:
216
217 2019-02-16  Zalan Bujtas  <zalan@apple.com>
218
219         [LFC][BFC] Add support for block replaced intrinsic width.
220         https://bugs.webkit.org/show_bug.cgi?id=194705
221
222         Reviewed by Simon Fraser.
223
224         * LayoutReloaded/misc/LFC-passing-tests.txt:
225
226 2019-02-16  Zalan Bujtas  <zalan@apple.com>
227
228         [LFC] Apply min/max width constraints to preferred width computation
229         https://bugs.webkit.org/show_bug.cgi?id=194739
230
231         Reviewed by Simon Fraser.
232
233         * LayoutReloaded/misc/LFC-passing-tests.txt:
234
235 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
236
237         [WTF] Add environment variable helpers
238         https://bugs.webkit.org/show_bug.cgi?id=192405
239
240         Reviewed by Michael Catanzaro.
241
242         * DumpRenderTree/mac/DumpRenderTree.mm:
243         (libraryPathForDumpRenderTree):
244         * DumpRenderTree/win/DumpRenderTree.cpp:
245         (libraryPathForDumpRenderTree):
246         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
247         (setUpIOSLayoutTestCommunication):
248         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
249         (beforeAll):
250         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
251         (main):
252         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
253         (WebKitTestBus::run):
254         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
255         (WTR::getOutputDir):
256         (WTR::initializeFontConfigSetting):
257         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
258         (WTR::InjectedBundle::platformInitialize):
259         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
260         (WTR::topLevelPath):
261         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
262         (WTR::topLevelPath):
263         (WTR::getOutputDir):
264         (WTR::activateFonts):
265         * WebKitTestRunner/TestController.cpp:
266         (WTR::TestController::libraryPathForTesting):
267         (WTR::TestController::generateContextConfiguration const):
268         (WTR::TestController::generatePageConfiguration):
269         (WTR::TestController::decideDestinationWithSuggestedFilename):
270         (WTR::TestController::platformAdjustContext):
271         * WebKitTestRunner/TestController.h:
272         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
273         (WTR::TestController::cocoaPlatformInitialize):
274         (WTR::TestController::platformAdjustContext):
275         * WebKitTestRunner/gtk/main.cpp:
276         (main):
277         * WebKitTestRunner/mac/TestControllerMac.mm:
278         (WTR::TestController::configureContentExtensionForTest):
279         * WebKitTestRunner/wpe/main.cpp:
280         (main):
281         Utilize WTF::Environment where possible.
282
283 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
284
285         [iOS] WKWebView callout bar is missing Change Writing Direction item
286         https://bugs.webkit.org/show_bug.cgi?id=190015
287         <rdar://problem/44810366>
288
289         Reviewed by Tim Horton.
290
291         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
292         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
295         (TestWebKitAPI::TEST):
296
297 2019-02-15  Chris Dumez  <cdumez@apple.com>
298
299         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
300         https://bugs.webkit.org/show_bug.cgi?id=194717
301         <rdar://problem/47884404>
302
303         Reviewed by Brady Eidson.
304
305         Add API test coverage.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
308
309 2019-02-15  Youenn Fablet  <youenn@apple.com>
310
311         Make navigator.mediaDevices SecureContext
312         https://bugs.webkit.org/show_bug.cgi?id=194666
313
314         Reviewed by Eric Carlson.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
317         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
318         (TEST_F):
319
320 2019-02-15  Brian Burg  <bburg@apple.com>
321
322         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
323         https://bugs.webkit.org/show_bug.cgi?id=194411
324         <rdar://problem/47787614>
325
326         Reviewed by Joseph Pecoraro.
327
328         Remove unnecessary soft linking macro usage.
329
330         * DumpRenderTree/mac/TestRunnerMac.mm:
331         (TestRunner::inspectorTestStubURL):
332         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
333         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
334         (WTR::TestRunner::inspectorTestStubURL):
335
336 2019-02-15  Commit Queue  <commit-queue@webkit.org>
337
338         Unreviewed, rolling out r241559 and r241566.
339         https://bugs.webkit.org/show_bug.cgi?id=194710
340
341         Causes layout test crashes under GuardMalloc (Requested by
342         ryanhaddad on #webkit).
343
344         Reverted changesets:
345
346         "[WTF] Add environment variable helpers"
347         https://bugs.webkit.org/show_bug.cgi?id=192405
348         https://trac.webkit.org/changeset/241559
349
350         "Unreviewed build fix for WinCairo Debug after r241559."
351         https://trac.webkit.org/changeset/241566
352
353 2019-02-15  Zalan Bujtas  <zalan@apple.com>
354
355         [LFC] Out-of-flow box is never a float box
356         https://bugs.webkit.org/show_bug.cgi?id=194704
357
358         Reviewed by Antti Koivisto.
359
360         * LayoutReloaded/misc/LFC-passing-tests.txt:
361
362 2019-02-10  Darin Adler  <darin@apple.com>
363
364         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
365         https://bugs.webkit.org/show_bug.cgi?id=194487
366
367         Reviewed by Daniel Bates.
368
369         * DumpRenderTree/win/DumpRenderTree.cpp:
370         (applicationId): Use makeString instead of String::format.
371         (main): Ditto.
372         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
373         (TestWebKitAPI::Util::createURLForResource): Ditto.
374         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
375         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
376
377         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
378         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
379         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
380         (WTR::createStringWithAttributes): Use appendLiteral.
381         (WTR::AccessibilityUIElement::helpText const): Ditto.
382         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
383         directly instead of using String::format.
384         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
385         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
386
387 2019-02-15  Truitt Savell  <tsavell@apple.com>
388
389         Unreviewed, rolling out r241564.
390
391         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
392
393         Reverted changeset:
394
395         "[Mac] WebInspectorUI.framework does not need to be soft-
396         linked anymore"
397         https://bugs.webkit.org/show_bug.cgi?id=194411
398         https://trac.webkit.org/changeset/241564
399
400 2019-02-15  Saam barati  <sbarati@apple.com>
401
402         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
403         https://bugs.webkit.org/show_bug.cgi?id=194036
404
405         Reviewed by Yusuke Suzuki.
406
407         * Scripts/run-jsc-stress-tests:
408
409 2019-02-14  Tim Horton  <timothy_horton@apple.com>
410
411         Fix the build.
412
413         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
414         (WTR::UIScriptController::drawSquareInEditableImage):
415         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
416         (TestWebKitAPI::drawSquareInEditableImage):
417
418 2019-02-14  Tim Horton  <timothy_horton@apple.com>
419
420         Fix the build.
421
422         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
423         (WTR::UIScriptController::drawSquareInEditableImage):
424         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
425         (TestWebKitAPI::drawSquareInEditableImage):
426
427 2019-02-14  Brian Burg  <bburg@apple.com>
428
429         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
430         https://bugs.webkit.org/show_bug.cgi?id=194411
431         <rdar://problem/47787614>
432
433         Reviewed by Joseph Pecoraro.
434
435         Remove unnecessary soft linking macro usage.
436
437         * DumpRenderTree/mac/TestRunnerMac.mm:
438         (TestRunner::inspectorTestStubURL):
439         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
440         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
441         (WTR::TestRunner::inspectorTestStubURL):
442
443 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-app] status bubble should fetch builder name info from BuilderMapping table
446         https://bugs.webkit.org/show_bug.cgi?id=194599
447
448         Reviewed by Lucas Forschler.
449
450         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
451         (StatusBubble._build_bubble):
452
453 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-app] Set Foreign Key in Django build model
456         https://bugs.webkit.org/show_bug.cgi?id=194667
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-app/ews/models/build.py:
461         (Build):
462
463 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
464
465         [WTF] Add environment variable helpers
466         https://bugs.webkit.org/show_bug.cgi?id=192405
467
468         Reviewed by Michael Catanzaro.
469
470         * DumpRenderTree/mac/DumpRenderTree.mm:
471         (libraryPathForDumpRenderTree):
472         * DumpRenderTree/win/DumpRenderTree.cpp:
473         (libraryPathForDumpRenderTree):
474         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
475         (setUpIOSLayoutTestCommunication):
476         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
477         (TestWebKitAPI::strip):
478         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
479         (beforeAll):
480         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
481         (main):
482         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
483         (WebKitTestBus::run):
484         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
485         (WTR::getOutputDir):
486         (WTR::initializeFontConfigSetting):
487         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
488         (WTR::InjectedBundle::platformInitialize):
489         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
490         (WTR::topLevelPath):
491         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
492         (WTR::topLevelPath):
493         (WTR::getOutputDir):
494         (WTR::activateFonts):
495         * WebKitTestRunner/TestController.cpp:
496         (WTR::TestController::libraryPathForTesting):
497         (WTR::TestController::generateContextConfiguration const):
498         (WTR::TestController::generatePageConfiguration):
499         (WTR::TestController::decideDestinationWithSuggestedFilename):
500         (WTR::TestController::platformAdjustContext):
501         * WebKitTestRunner/TestController.h:
502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
503         (WTR::TestController::cocoaPlatformInitialize):
504         (WTR::TestController::platformAdjustContext):
505         * WebKitTestRunner/gtk/main.cpp:
506         (main):
507         * WebKitTestRunner/mac/TestControllerMac.mm:
508         (WTR::TestController::configureContentExtensionForTest):
509         * WebKitTestRunner/wpe/main.cpp:
510         (main):
511         Utilize WTF::Environment where possible.
512
513 2019-02-14  Chris Dumez  <cdumez@apple.com>
514
515         [PSON] Introduce a WebContent Process cache
516         https://bugs.webkit.org/show_bug.cgi?id=194594
517         <rdar://problem/46793397>
518
519         Reviewed by Geoff Garen.
520
521         Update API tests to turn on the WebContent Process cache.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
524
525 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
526
527         Unreviewed, build fix after r241480
528
529         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
530         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
531         (-[DragAndDropSimulator initWithWebView:]):
532
533 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
534
535         AX: ARIA Reflection was disabled in error
536         https://bugs.webkit.org/show_bug.cgi?id=194647
537         <rdar://problem/48068336>
538
539         Reviewed by Ryosuke Niwa.
540
541         Remove test override now that this feature should be enabled by default.
542
543         * WebKitTestRunner/TestController.cpp:
544         (WTR::TestController::resetPreferencesToConsistentValues):
545
546 2019-02-14  Commit Queue  <commit-queue@webkit.org>
547
548         Unreviewed, rolling out r241486.
549         https://bugs.webkit.org/show_bug.cgi?id=194655
550
551         causing API failures in builds (Requested by ShawnRoberts on
552         #webkit).
553
554         Reverted changeset:
555
556         "[Cocoa] Media elements will restart network buffering just
557         before suspending"
558         https://bugs.webkit.org/show_bug.cgi?id=193691
559         https://trac.webkit.org/changeset/241486
560
561 2019-02-14  Zalan Bujtas  <zalan@apple.com>
562
563         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
564         https://bugs.webkit.org/show_bug.cgi?id=194622
565
566         Reviewed by Antti Koivisto.
567
568         * LayoutReloaded/misc/LFC-passing-tests.txt:
569
570 2019-02-14  Zalan Bujtas  <zalan@apple.com>
571
572         [LFC] Shrink-to-fit-width should be constrained by min/max width
573         https://bugs.webkit.org/show_bug.cgi?id=194653
574
575         Reviewed by Antti Koivisto.
576
577         * LayoutReloaded/misc/LFC-passing-tests.txt:
578
579 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
580
581         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
582         https://bugs.webkit.org/show_bug.cgi?id=194641
583
584         Reviewed by Geoffrey Garen.
585
586         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
587         so that the test would fail without this fix.
588
589         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
590         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
591
592 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
593
594         [ews-app] Change log level for a log statement
595
596         Unreviewed minor fix.
597
598         * BuildSlaveSupport/ews-app/ews/models/patch.py:
599         (Patch.save_patch):
600
601 2019-02-13  Jer Noble  <jer.noble@apple.com>
602
603         [Cocoa] Media elements will restart network buffering just before suspending
604         https://bugs.webkit.org/show_bug.cgi?id=193691
605
606         Reviewed by Eric Carlson.
607
608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
609         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
610         (TEST):
611
612 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
613
614         [ews-app] Fetch builder id to name mapping
615         https://bugs.webkit.org/show_bug.cgi?id=194355
616
617         Reviewed by Lucas Forschler.
618
619         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
620         (Buildbot.get_builder_id_to_name_mapping):
621         (Buildbot._get_display_name_from_builder_name):
622
623 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
624
625         Further restricting webarchive loads
626         https://bugs.webkit.org/show_bug.cgi?id=194567
627         <rdar://problem/47610130>
628
629         Reviewed by Youenn Fablet.
630
631         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
632         navigations on drop.
633
634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
635         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
636         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
637         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
638         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
639         (TestWebKitAPI::TEST):
640         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
641         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
642         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
643         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
644         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
645         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
646         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
647
648 2019-02-13  John Wilander  <wilander@apple.com>
649
650         Store Ad Click Attribution requests in the network process
651         https://bugs.webkit.org/show_bug.cgi?id=194510
652         <rdar://problem/47650118>
653
654         Reviewed by Alex Christensen and Daniel Bates.
655
656         This patch adds two TestRunner functions:
657         - dumpAdClickAttribution()
658         - clearAdClickAttribution()
659
660         They call into the network process to dump and clear Ad Click
661         Attribution state, respectively.
662
663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
665         (WTR::TestRunner::dumpAdClickAttribution):
666         (WTR::TestRunner::clearAdClickAttribution):
667         * WebKitTestRunner/InjectedBundle/TestRunner.h:
668         * WebKitTestRunner/TestController.cpp:
669         (WTR::TestController::resetStateToConsistentValues):
670         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
671         (WTR::adClickAttributionStringResultCallback):
672         (WTR::TestController::dumpAdClickAttribution):
673         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
674         (WTR::adClickAttributionVoidCallback):
675         (WTR::TestController::clearAdClickAttribution):
676         * WebKitTestRunner/TestController.h:
677         * WebKitTestRunner/TestInvocation.cpp:
678         (WTR::TestInvocation::dumpResults):
679         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
680         (WTR::TestInvocation::dumpAdClickAttribution):
681         * WebKitTestRunner/TestInvocation.h:
682
683 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
684
685         [ews-app] Generate status-bubble
686         https://bugs.webkit.org/show_bug.cgi?id=194572
687
688         Reviewed by Lucas Forschler.
689
690         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
691         (StatusBubble._build_bubble):
692         (StatusBubble._should_show_bubble_for):
693         (StatusBubble._build_bubbles_for_patch):
694
695 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
696
697         [ews-app] Add status bubble html template
698         https://bugs.webkit.org/show_bug.cgi?id=194571
699
700         Reviewed by Lucas Forschler.
701
702         * BuildSlaveSupport/ews-app/ews/templates: Added.
703         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
704
705 2019-02-12  Chris Dumez  <cdumez@apple.com>
706
707         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
708         https://bugs.webkit.org/show_bug.cgi?id=194568
709         <rdar://problem/47944490>
710
711         Reviewed by Ryosuke Niwa.
712
713         Add API test coverage.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
716         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
717
718 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
719
720         webkitpy: Remove bug_dummy from parsed test expectations
721         https://bugs.webkit.org/show_bug.cgi?id=194562
722         <rdar://problem/47853999>
723
724         Reviewed by Lucas Forschler.
725
726         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
727         (TestExpectationParser):
728         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
729         skipped tests.
730         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
731
732 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
733
734         [ews-app] Add method to fetch patch
735         https://bugs.webkit.org/show_bug.cgi?id=194518
736
737         Reviewed by Lucas Forschler.
738
739         * BuildSlaveSupport/ews-app/ews/models/patch.py:
740         (Patch.get_patch):
741
742 2019-02-12  Zalan Bujtas  <zalan@apple.com>
743
744         [LFC] Expand tests coverage (60 new tests -> 860)
745
746         Unreviewed test gardening (run-singly, --child-processes=1).
747
748         * LayoutReloaded/misc/LFC-passing-tests.txt:
749
750 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
751
752         Allow pages to trigger programmatic paste from script on iOS
753         https://bugs.webkit.org/show_bug.cgi?id=194271
754         <rdar://problem/47808810>
755
756         Reviewed by Tim Horton.
757
758         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
759
760         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
761         (WTR::UIScriptController::platformSetDidShowMenuCallback):
762         (WTR::UIScriptController::platformSetDidHideMenuCallback):
763         (WTR::UIScriptController::rectForMenuAction const):
764
765         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
766         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
767         for when the menu is shown or hidden.
768
769         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
770         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
771         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
772         (WTR::UIScriptController::setDidShowMenuCallback):
773         (WTR::UIScriptController::didShowMenuCallback const):
774         (WTR::UIScriptController::setDidHideMenuCallback):
775         (WTR::UIScriptController::didHideMenuCallback const):
776         (WTR::UIScriptController::platformSetDidShowMenuCallback):
777         (WTR::UIScriptController::platformSetDidHideMenuCallback):
778         (WTR::UIScriptController::rectForMenuAction const):
779         * TestRunnerShared/UIScriptContext/UIScriptController.h:
780         * WebKitTestRunner/TestController.cpp:
781         (WTR::TestController::resetPreferencesToConsistentValues):
782         (WTR::updateTestOptionsFromTestHeader):
783         * WebKitTestRunner/TestOptions.h:
784
785         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
786         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
787
788         (WTR::TestOptions::hasSameInitializationOptions const):
789         * WebKitTestRunner/UIScriptControllerCocoa.mm:
790         (WTR::UIScriptController::calendarType const):
791         (WTR::UIScriptController::platformUndoManager const):
792         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
793         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
794         (-[TestRunnerWKWebView initWithFrame:configuration:]):
795         (-[TestRunnerWKWebView dealloc]):
796         (-[TestRunnerWKWebView _didShowMenu]):
797         (-[TestRunnerWKWebView _didHideMenu]):
798
799         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
800
801         * WebKitTestRunner/ios/TestControllerIOS.mm:
802         (WTR::handleMenuWillHideNotification):
803         (WTR::handleMenuDidHideNotification):
804         (WTR::TestController::platformInitialize):
805         (WTR::TestController::platformDestroy):
806         (WTR::TestController::platformResetStateToConsistentValues):
807
808         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
809         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
810
811         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
812         (WTR::forEachViewInHierarchy):
813         (WTR::findViewInHierarchyOfType):
814
815         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
816         functions that dig through a given view's hierarchy in search of a view of a given class.
817
818         (WTR::UIScriptController::selectionStartGrabberViewRect const):
819         (WTR::UIScriptController::selectionEndGrabberViewRect const):
820         (WTR::UIScriptController::selectionCaretViewRect const):
821         (WTR::UIScriptController::selectionRangeViewRects const):
822         (WTR::UIScriptController::platformSetDidShowMenuCallback):
823         (WTR::UIScriptController::platformSetDidHideMenuCallback):
824
825         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
826
827         (WTR::UIScriptController::rectForMenuAction const):
828
829         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
830         callout bar) whose label matches the given string.
831
832         (WTR::UIScriptController::platformContentView const):
833
834         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
835         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
836         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
837
838         (WTR::UIScriptController::platformUndoManager const): Deleted.
839         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
840         (WTR::UIScriptController::platformContentView const):
841         (WTR::UIScriptController::platformUndoManager const): Deleted.
842
843 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
844
845         webkitpy: No option to only show unexpected failures in results.html for iPad
846         https://bugs.webkit.org/show_bug.cgi?id=194554
847         <rdar://problem/47922442>
848
849         Rubber-stamped by Aakash Jain.
850
851         Just because a TestExpecations file does not exist for a specific platform does not mean that
852         TestExpecations are not being used, given that platforms inherit test expectations.
853
854         * Scripts/webkitpy/port/base.py:
855         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
856         * Scripts/webkitpy/port/base_unittest.py:
857         (PortTest.test_uses_test_expectations_file):
858
859 2019-02-12  Alex Christensen  <achristensen@webkit.org>
860
861         Remove setDefersLoading infrastructure from WebKit2
862         https://bugs.webkit.org/show_bug.cgi?id=194506
863
864         Reviewed by Brady Eidson.
865
866         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
868         (WTR::TestRunner::setDefersLoading): Deleted.
869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
870
871 2019-02-12  Alex Christensen  <achristensen@webkit.org>
872
873         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
874         https://bugs.webkit.org/show_bug.cgi?id=194522
875         <rdar://problem/47789393>
876
877         Reviewed by Chris Dumez.
878
879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
880         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
881         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
883
884 2019-02-12  Andy Estes  <aestes@apple.com>
885
886         [iOSMac] Enable Parental Controls Content Filtering
887         https://bugs.webkit.org/show_bug.cgi?id=194521
888         <rdar://39732376>
889
890         Reviewed by Tim Horton.
891
892         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
893
894 2019-02-12  Zalan Bujtas  <zalan@apple.com>
895
896         [LFC][IFC] Add intrinsic width support for float boxes.
897         https://bugs.webkit.org/show_bug.cgi?id=194528
898
899         Reviewed by Antti Koivisto.
900
901         Expand tests coverage (2 new tests -> 800).
902         (This is the correct test ordering --runs-singly --child-processes=1)
903
904         * LayoutReloaded/misc/LFC-passing-tests.txt:
905
906 2019-02-12  Rob Buis  <rbuis@igalia.com>
907
908         Implement serializing in MIME type parser
909         https://bugs.webkit.org/show_bug.cgi?id=193909
910
911         Reviewed by Darin Adler.
912
913         Add various tests involving upper case, non-ASCII, control/null characters,
914         various HTTP whitespace, single quotes and an unpaired surrogate.
915
916         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
917         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
918         (TestWebKitAPI::serializeIfValid):
919         (TestWebKitAPI::TEST):
920
921 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
922
923         [Cocoa] Ask platform for generic font family mappings
924         https://bugs.webkit.org/show_bug.cgi?id=187723
925         <rdar://problem/41892438>
926
927         Reviewed by Brent Fulgham.
928
929         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
930
931         * DumpRenderTree/mac/DumpRenderTree.mm:
932         (allowedFontFamilySet):
933         * WebKitTestRunner/mac/TestControllerMac.mm:
934         (WTR::allowedFontFamilySet):
935
936 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
937
938         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
939         https://bugs.webkit.org/show_bug.cgi?id=193622
940
941         Reviewed by Michael Catanzaro.
942
943         This adds support for loading content extension rule sets from the JSON files which
944         accompany the corresponding layout test, using the C API. The Cocoa specific parts
945         of WKTR for this could be removed, but that is left for a follow-up patch with
946         cleanups.
947
948         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
949         * WebKitTestRunner/TestController.cpp:
950         (WTR::testPath): Subtract one from the length when constructing the result std::string to
951         avoid having the null-terminator copied into the result.
952         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
953         part of the preparations to run a test.
954         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
955         (WTR::contentExtensionStoreCallback): Added.
956         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
957         used for content extensions test.
958         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
959         extensions and compiling the JSON rule set for tests involving content extensions.
960         (WTR::TestController::resetContentExtensions): Removes the content extension built for
961         testing and disables content extensions.
962         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
963         resetContentExtensions().
964         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
965         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
966         configureContentExtensionForTest(), and userContentController().
967
968 2019-02-11  Daniel Bates  <dabates@apple.com>
969
970         [iOS] Mouse/Touch/Pointer events are missing modifier keys
971         https://bugs.webkit.org/show_bug.cgi?id=191446
972         <rdar://problem/45929460>
973
974         Reviewed by Tim Horton.
975
976         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
977
978         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
979         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
980         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
981         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
982         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
983         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
984         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
985         * TestRunnerShared/UIScriptContext/UIScriptController.h:
986         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
987         (WTR::arrayLength):
988         (WTR::parseModifierArray):
989         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
990         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
991         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
992         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
993
994 2019-02-11  Commit Queue  <commit-queue@webkit.org>
995
996         Unreviewed, rolling out r241272 and r241276.
997         https://bugs.webkit.org/show_bug.cgi?id=194514
998
999         Broke the Apple Internal build and the fix requires human
1000         intervention :( (Requested by dydz on #webkit).
1001
1002         Reverted changesets:
1003
1004         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1005         https://bugs.webkit.org/show_bug.cgi?id=191446
1006         https://trac.webkit.org/changeset/241272
1007
1008         "Fix internal iOS build after r241272"
1009         https://bugs.webkit.org/show_bug.cgi?id=191446
1010         https://trac.webkit.org/changeset/241276
1011
1012 2019-02-11  Truitt Savell  <tsavell@apple.com>
1013
1014         Unreviewed, rolling out r241269.
1015
1016         Caused 5 layout tests crashes on Mac WK1
1017
1018         Reverted changeset:
1019
1020         "DumpRenderTree should report unknown options"
1021         https://bugs.webkit.org/show_bug.cgi?id=191303
1022         https://trac.webkit.org/changeset/241269
1023
1024 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1025
1026         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1027         https://bugs.webkit.org/show_bug.cgi?id=194313
1028
1029         Reviewed by Tim Horton.
1030
1031         Add a helper to determine whether the web view is presenting modal UI.
1032
1033         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1034         (WTR::UIScriptController::isPresentingModally const):
1035         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1036         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1037         (WTR::UIScriptController::isPresentingModally const):
1038         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1039         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1040         (WTR::UIScriptController::calendarType const): Deleted.
1041         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1042         (WTR::UIScriptController::isPresentingModally const):
1043         (WTR::UIScriptController::calendarType const):
1044         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1045         (WTR::UIScriptController::calendarType const):
1046
1047 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1048
1049         GCHeapInspector: Show the retained sizes in more places
1050         https://bugs.webkit.org/show_bug.cgi?id=194464
1051
1052         Reviewed by Simon Fraser.
1053
1054         * GCHeapInspector/gc-heap-inspector.html:
1055         * GCHeapInspector/script/interface.js:
1056         (HeapInspectorUtils.humanReadableSize):
1057         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1058         (HeapInspectorUtils.spanForNode.span.span):
1059         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1060         (HeapSnapshotInspector.prototype.buildRoots):
1061
1062 2019-02-11  Daniel Bates  <dabates@apple.com>
1063
1064         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1065         https://bugs.webkit.org/show_bug.cgi?id=191446
1066         <rdar://problem/45929460>
1067
1068         Reviewed by Tim Horton.
1069
1070         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1071
1072         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1073         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1074         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1075         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1076         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1077         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1078         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1079         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1080         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1081         (WTR::arrayLength):
1082         (WTR::parseModifierArray):
1083         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1084         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1085         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1086         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1087
1088 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1089
1090         DumpRenderTree should report unknown options
1091         https://bugs.webkit.org/show_bug.cgi?id=191303
1092
1093         Reviewed by Frédéric Wang.
1094
1095         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1096         to report unknown options.
1097         Added and assigned test options which are currently used in tests.
1098
1099         * DumpRenderTree/TestOptions.cpp:
1100         (TestOptions::TestOptions):
1101
1102 2019-02-11  Truitt Savell  <tsavell@apple.com>
1103
1104         Unreviewed, rolling out r241229.
1105
1106         Revision broke internal builds for watchOS.
1107
1108         Reverted changeset:
1109
1110         "[Cocoa] Ask platform for generic font family mappings"
1111         https://bugs.webkit.org/show_bug.cgi?id=187723
1112         https://trac.webkit.org/changeset/241229
1113
1114 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1115
1116         [WinCairo][MiniBrowser] Basic authentication always fails.
1117         https://bugs.webkit.org/show_bug.cgi?id=194496
1118
1119         Reviewed by Don Olmstead.
1120
1121         * MiniBrowser/win/DialogHelper.h:
1122         (Dialog::getText):
1123
1124 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1125
1126         [GStreamer] GstMappedBuffer testsuite build fails
1127         https://bugs.webkit.org/show_bug.cgi?id=194495
1128
1129         Reviewed by Carlos Garcia Campos.
1130
1131         Fix the build by explicitely adding the gstreamer1.0-audio include
1132         directories to the include path.
1133
1134         * TestWebKitAPI/PlatformGTK.cmake:
1135         * TestWebKitAPI/PlatformWPE.cmake:
1136
1137 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1138
1139         [GTK][WPE] Add enable-javascript-markup setting
1140         https://bugs.webkit.org/show_bug.cgi?id=193439
1141
1142         Reviewed by Michael Catanzaro.
1143
1144         Add test cases to check the new setting.
1145
1146         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1147         (testWebKitSettings):
1148         (testWebKitSettingsJavaScriptMarkup):
1149         (beforeAll):
1150
1151 2019-02-10  Darin Adler  <darin@apple.com>
1152
1153         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1154         https://bugs.webkit.org/show_bug.cgi?id=194485
1155
1156         Reviewed by Daniel Bates.
1157
1158         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1159
1160 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1161
1162         Add more tests for clampTo<>()
1163         https://bugs.webkit.org/show_bug.cgi?id=194462
1164
1165         Reviewed by Geoffrey Garen.
1166
1167         Darin suggested to test the very last floating point number
1168         at the boundaries when truncating to integer.
1169         I added test for max/min and max-1/min-1.
1170
1171         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1172         (TestWebKitAPI::TEST):
1173
1174 2019-02-09  Darin Adler  <darin@apple.com>
1175
1176         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1177         https://bugs.webkit.org/show_bug.cgi?id=194021
1178
1179         Reviewed by Geoffrey Garen.
1180
1181         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1182         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1183         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1184
1185 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1186
1187         [LFC][IFC] Add intrinsic width support for basic inline containers
1188         https://bugs.webkit.org/show_bug.cgi?id=194473
1189
1190         Reviewed by Antti Koivisto.
1191
1192         Expand tests coverage (11 new tests -> 798)
1193
1194         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1195
1196 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1197
1198         Fix MiniBrowser's entitlements
1199         https://bugs.webkit.org/show_bug.cgi?id=192431
1200
1201         Reviewed by Joseph Pecoraro.
1202
1203         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1204         files, making it impossible to load any extension.
1205
1206         * MiniBrowser/MiniBrowser.entitlements:
1207
1208 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1209
1210         [Cocoa] Ask platform for generic font family mappings
1211         https://bugs.webkit.org/show_bug.cgi?id=187723
1212         <rdar://problem/41892438>
1213
1214         Reviewed by Brent Fulgham.
1215
1216         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1217
1218         * DumpRenderTree/mac/DumpRenderTree.mm:
1219         (allowedFontFamilySet):
1220         * WebKitTestRunner/mac/TestControllerMac.mm:
1221         (WTR::allowedFontFamilySet):
1222
1223 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1224
1225         [GTK] Implement back/forward touchpad gesture
1226         https://bugs.webkit.org/show_bug.cgi?id=193919
1227
1228         Reviewed by Michael Catanzaro.
1229
1230         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1231         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1232
1233 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1234
1235         Add SPI to use networking daemon instead of XPC service
1236         https://bugs.webkit.org/show_bug.cgi?id=194427
1237
1238         Reviewed by Geoffrey Garen
1239
1240         * MiniBrowser/MiniBrowser.entitlements:
1241
1242 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1243
1244         [ews-build] Ensure that every builder in config.json has short name
1245         https://bugs.webkit.org/show_bug.cgi?id=194461
1246
1247         Reviewed by Lucas Forschler.
1248
1249         * BuildSlaveSupport/ews-build/loadConfig.py:
1250         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1251
1252 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1253
1254         [ews-build] Add short name to config.json
1255         https://bugs.webkit.org/show_bug.cgi?id=194456
1256
1257         Reviewed by Lucas Forschler.
1258
1259         * BuildSlaveSupport/ews-build/config.json: Added short name.
1260         * BuildSlaveSupport/ews-build/loadConfig.py:
1261         (loadBuilderConfig): Set the short name as the builder description.
1262
1263 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1264
1265         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1266         https://bugs.webkit.org/show_bug.cgi?id=194418
1267
1268         Reviewed by Lucas Forschler.
1269
1270         Do not include errors trying when finding crashlogs at the end of
1271         a run-webkit-tests run since we don't process those errors.
1272
1273         * Scripts/webkitpy/port/darwin.py:
1274         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1275         * Scripts/webkitpy/port/ios_device.py:
1276         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1277         * Scripts/webkitpy/port/watch_device.py:
1278         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1279
1280 2019-02-08  Beth Dakin  <bdakin@apple.com>
1281
1282         Add afterScreenUpdates to WKSnapshotConfiguration
1283         https://bugs.webkit.org/show_bug.cgi?id=194362
1284         -and corresponding-
1285         <rdar://problem/40655528> Please add an "after screen updates" property to 
1286         WKSnapshotConfiguration (to solve blank snapshots)
1287
1288         Reviewed by Tim Horton.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1291         (TEST):
1292
1293 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1294
1295         clampTo(): do not convert the input to double when dealing with integers
1296         https://bugs.webkit.org/show_bug.cgi?id=194263
1297         <rdar://problem/47692312>
1298
1299         Reviewed by Darin Adler.
1300
1301         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1302         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1303         (TestWebKitAPI::testClampFloatingPointToInteger):
1304         (TestWebKitAPI::testClampSameSignIntegers):
1305         (TestWebKitAPI::testClampUnsignedToSigned):
1306         (TestWebKitAPI::testClampSignedToUnsigned):
1307
1308 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1309
1310         webkitpy: Respect --dedicated-simulators flag
1311         https://bugs.webkit.org/show_bug.cgi?id=194416
1312         <rdar://problem/47894722>
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * Scripts/webkitpy/port/device_port.py:
1317         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1318         available devices can be safely ignored.
1319
1320 2019-02-07  Keith Rollin  <krollin@apple.com>
1321
1322         Remove extra copy of 100x100-red.tga
1323         https://bugs.webkit.org/show_bug.cgi?id=194371
1324         <rdar://problem/47873465>
1325
1326         Reviewed by Said Abou-Hallawa.
1327
1328         In order to help it pass its tests, Bug 194190 added a second copy of
1329         the file 100x100-red.tga. However, it turns out that this additional
1330         file wasn't actually needed, and that that sole previous copy was
1331         sufficient. At the same time, this second copy -- which was copied to
1332         the same location in the build output as the first copy -- now caused
1333         XCBuild to complain because there were two production rules for the
1334         same output file. Address this by removing the newly-added extra copy.
1335
1336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1337         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1338
1339 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1340
1341         Deprecate WKBundlePageSetDefersLoading
1342         https://bugs.webkit.org/show_bug.cgi?id=191394
1343
1344         Reviewed by Dean Jackson.
1345
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::setDefersLoading):
1348
1349 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1350
1351         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1352         https://bugs.webkit.org/show_bug.cgi?id=194391
1353
1354         Reviewed by Antti Koivisto.
1355
1356         * LayoutReloaded/misc/LFC-passing-tests.txt:
1357
1358 2019-02-06  Keith Rollin  <krollin@apple.com>
1359
1360         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1361         https://bugs.webkit.org/show_bug.cgi?id=193975
1362         <rdar://problem/47643306>
1363
1364         Reviewed by Tim Horton.
1365
1366         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1367         the Info.plist file into the bundle. This step is not necessary as the
1368         implicit "bundle up all the build products into a framework" build
1369         phase does this already. Having the Copy Bundle Resources phase do
1370         this causes a conflict under XCBuild, which objects to two build
1371         phases producing the same file (Info.plist). Address this by removing
1372         Info.plist from the Copy Bundle Resources phase.
1373
1374         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1375
1376 2019-02-06  Keith Rollin  <krollin@apple.com>
1377
1378         Really enable the automatic checking and regenerations of .xcfilelists during builds
1379         https://bugs.webkit.org/show_bug.cgi?id=194357
1380         <rdar://problem/47861231>
1381
1382         Reviewed by Chris Dumez.
1383
1384         Bug 194124 was supposed to enable the automatic checking and
1385         regenerating of .xcfilelist files during the build. While related
1386         changes were included in that patch, the change to actually enable the
1387         operation somehow was omitted. This patch actually enables the
1388         operation. The check-xcfilelist.sh scripts now check
1389         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1390         from the checking.
1391
1392         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1393         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1394
1395 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1396
1397         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1398         <https://webkit.org/b/194286>
1399         <rdar://problem/47815558>
1400
1401         Reviewed by Alexey Proskuryakov.
1402
1403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1404         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1405         WKRetainPtr<> to avoid leaking the WKDataRef.
1406
1407 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1408
1409         Unreviewed, fix a typo
1410
1411         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1412
1413 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1414
1415         [GTK][WPE] force libpsl build to use ICU in jhbuild
1416         https://bugs.webkit.org/show_bug.cgi?id=194288
1417
1418         Reviewed by Carlos Garcia Campos.
1419
1420         * gtk/jhbuild.modules:
1421         Require ICU for libpsl build in jhbuild, like done in WPE.
1422
1423 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1424
1425         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1426         https://bugs.webkit.org/show_bug.cgi?id=194209
1427
1428         Reviewed by Carlos Garcia Campos.
1429
1430         Enhance TestCookieManager to ensure this doesn't happen again.
1431
1432         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1433         (testCookieManagerPersistentStorage):
1434         (beforeAll):
1435
1436 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1437
1438         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1439         https://bugs.webkit.org/show_bug.cgi?id=194324
1440
1441         Reviewed by Andy Estes.
1442
1443         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1444         part of the name is already implicit, since this is in testing code in TestOptions.
1445
1446         * WebKitTestRunner/TestController.cpp:
1447         (WTR::TestController::generateContextConfiguration const):
1448         (WTR::updateTestOptionsFromTestHeader):
1449         * WebKitTestRunner/TestOptions.h:
1450         (WTR::TestOptions::hasSameInitializationOptions const):
1451
1452 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1453
1454         [ews-build] Allow * as platform for builders and workers
1455         https://bugs.webkit.org/show_bug.cgi?id=188533
1456
1457         Reviewed by Lucas Forschler.
1458
1459         * BuildSlaveSupport/ews-build/loadConfig.py:
1460         (checkWorkersAndBuildersForConsistency):
1461
1462 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1463
1464         [ews-build] Add few bots to config.json
1465         https://bugs.webkit.org/show_bug.cgi?id=194304
1466
1467         Reviewed by Lucas Forschler.
1468
1469         * BuildSlaveSupport/ews-build/config.json:
1470
1471 2019-02-05  Keith Rollin  <krollin@apple.com>
1472
1473         Enable the automatic checking and regenerations of .xcfilelists during builds
1474         https://bugs.webkit.org/show_bug.cgi?id=194124
1475         <rdar://problem/47721277>
1476
1477         Reviewed by Tim Horton.
1478
1479         Bug 193790 add a facility for checking -- during build time -- that
1480         any needed .xcfilelist files are up-to-date and for updating them if
1481         they are not. This facility was initially opt-in by setting
1482         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1483         the process seemed robust. Its now time to enable this facility and
1484         make it opt-out. If there is a need to disable this facility, set and
1485         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1486         running `make` or `build-webkit`, or before running Xcode from the
1487         command line.
1488
1489         Additionally, remove the step that generates a list of source files
1490         going into the UnifiedSources build step. It's only necessarily to
1491         specify Sources.txt and SourcesCocoa.txt as inputs.
1492
1493         * Scripts/generate-xcfilelists:
1494
1495 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1496
1497         [GTK][WPE] force libpsl build to use ICU in jhbuild
1498         https://bugs.webkit.org/show_bug.cgi?id=194288
1499
1500         Reviewed by Philippe Normand.
1501
1502         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1503         This can cause build failures if libidn is detected but libunistring is not available.
1504
1505         Make sure that ICU is used for runtime and builtin PSL data.
1506
1507         * gtk/jhbuild.modules:
1508         * wpe/jhbuild.modules:
1509
1510 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1511
1512         [ews-app] Modified timestamp should be updated on updating data
1513         https://bugs.webkit.org/show_bug.cgi?id=194295
1514
1515         Reviewed by Lucas Forschler.
1516
1517         * BuildSlaveSupport/ews-app/ews/models/build.py:
1518         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1519         * BuildSlaveSupport/ews-app/ews/models/step.py:
1520
1521 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1522
1523         Unreviewed, rolling out r240742.
1524
1525         Causes crashes on iOS simulator.
1526
1527         Reverted changeset:
1528
1529         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1530         not focused in a content-editable element"
1531         https://bugs.webkit.org/show_bug.cgi?id=192824
1532         https://trac.webkit.org/changeset/240742
1533
1534 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1535
1536         run-webkit-tests emits message "...running None" when running tests
1537         https://bugs.webkit.org/show_bug.cgi?id=194133
1538         <rdar://problem/47724738>
1539
1540         Reviewed by Lucas Forschler.
1541
1542         * Scripts/webkitpy/xcode/device_type.py:
1543         (DeviceType.__str__): Use both version mapping tables and use just the variant
1544         name if no version name is available.
1545         * Scripts/webkitpy/xcode/device_type_unittest.py:
1546         (DeviceTypeTest):
1547         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1548         an associated named.
1549
1550 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1551
1552         [WPE] require python3-setuptools for meson build in jhbuild
1553         https://bugs.webkit.org/show_bug.cgi?id=194287
1554
1555         Reviewed by Philippe Normand.
1556
1557         python3-setuptools is needed to build meson in jhbuild.
1558         It is already required by the GTK port.
1559
1560         * wpe/install-dependencies:
1561
1562 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1563
1564         [ews-app] Add method to save BuilderMapping to database
1565         https://bugs.webkit.org/show_bug.cgi?id=194264
1566
1567         Reviewed by Lucas Forschler.
1568
1569         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1570         (BuilderMapping.__str__):
1571         (BuilderMapping):
1572         (BuilderMapping.save_mapping):
1573         (BuilderMapping.update_mapping):
1574         (BuilderMapping.get_existing_mapping):
1575         (BuilderMapping.is_valid_mapping):
1576
1577 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1578
1579         [ews-app] Add timestamp fields for BuilderMappings
1580         https://bugs.webkit.org/show_bug.cgi?id=194266
1581
1582         Reviewed by Lucas Forschler.
1583
1584         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1585         (BuilderMapping):
1586
1587 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1588
1589         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1590         https://bugs.webkit.org/show_bug.cgi?id=174816
1591
1592         Reviewed by Michael Catanzaro.
1593
1594         Add tests for webkit_uri_for_display().
1595
1596         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1597         (testURIForDisplayUnaffected):
1598         (testURIForDisplayAffected):
1599         (beforeAll):
1600         (afterAll):
1601         * TestWebKitAPI/glib/CMakeLists.txt:
1602
1603 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1604
1605         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1606         https://bugs.webkit.org/show_bug.cgi?id=194158
1607         <rdar://problem/47737268>
1608
1609         Rubber-stamped by Aakash Jain.
1610
1611         * Scripts/webkitpy/port/device_port.py:
1612         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1613
1614 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1615
1616         [CG] Enable setAdditionalSupportedImageTypes for WK1
1617         https://bugs.webkit.org/show_bug.cgi?id=194190
1618
1619         Reviewed by Tim Horton.
1620
1621         Add a test similar to the one under WebKit Cocoa but make it create a
1622         WebView instead of a WKWebView.
1623
1624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1625         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1626         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1627         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1628         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1629         (TestWebKitAPI::runTest):
1630         (TestWebKitAPI::TEST):
1631
1632 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1633
1634         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1635         https://bugs.webkit.org/show_bug.cgi?id=194168
1636
1637         Reviewed by Simon Fraser.
1638
1639         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1640
1641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1642         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1643         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1644         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1645         (TEST):
1646         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1647         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1648
1649 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1650
1651         REGRESSION (r237269): webkit-patch what-broke is broken 
1652         https://bugs.webkit.org/show_bug.cgi?id=193025
1653
1654         Reviewed by Aakash Jain.
1655
1656         * Scripts/webkitpy/common/host.py:
1657         (Host.buildbot):
1658         (Host.bugzilla): Renamed to 'buildbot'.
1659
1660 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1661
1662         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1663         https://bugs.webkit.org/show_bug.cgi?id=194207
1664
1665         Reviewed by Tim Horton.
1666
1667         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1668         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1669         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1670         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1671         start and delete forwards to remove the original attachment.
1672
1673         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1674         (TestWebKitAPI::TEST):
1675
1676 2019-02-04  Youenn Fablet  <youenn@apple.com>
1677
1678         Capture state should be managed consistently when doing process swapping
1679         https://bugs.webkit.org/show_bug.cgi?id=194122
1680         <rdar://problem/47609293>
1681
1682         Reviewed by Eric Carlson.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1685         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1686         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1687         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1688         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1689         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1690         (WTR::TestRunner::isDoingMediaCapture const):
1691         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::TestController::isDoingMediaCapture const):
1694         * WebKitTestRunner/TestController.h:
1695         * WebKitTestRunner/TestInvocation.cpp:
1696         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1698         (WTR::TestController::isDoingMediaCapture const):
1699
1700 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1701
1702         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1703         https://bugs.webkit.org/show_bug.cgi?id=194142
1704
1705         Reviewed by Ross Kirsling.
1706
1707         There three 'separator' variables in TestController.cpp. Renamed
1708         it 'pathSeparator', and unified them.
1709
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::generateContextConfiguration const):
1712         (WTR::createTestURL):
1713         (WTR::TestController::platformAdjustContext):
1714
1715 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1716
1717         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1718         https://bugs.webkit.org/show_bug.cgi?id=194198
1719
1720         Reviewed by Antti Koivisto.
1721
1722         No need to set the banner heights on navigation now, since Page stores them.
1723
1724         * MiniBrowser/mac/WK2BrowserWindowController.m:
1725         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1726
1727 2019-02-03  John Wilander  <wilander@apple.com>
1728
1729         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1730         https://bugs.webkit.org/show_bug.cgi?id=194104
1731         <rdar://problem/47649991>
1732
1733         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1734
1735         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1736         (TestWebKitAPI::TEST):
1737             Changed numeric types from unsigned short to uint32_t.
1738
1739 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1740
1741         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1742         <https://webkit.org/b/194178>
1743         <rdar://problem/47753473>
1744
1745         Reviewed by Alexey Proskuryakov.
1746
1747         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1748         (WTR::uninstallFakeHelvetica): Pass nullptr into
1749         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1750
1751 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1752
1753         [LFC] Initialize ICB's style with fixed width/height.
1754         https://bugs.webkit.org/show_bug.cgi?id=194188
1755
1756         Reviewed by Antti Koivisto.
1757
1758         * LayoutReloaded/misc/LFC-passing-tests.txt:
1759
1760 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1761
1762         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1763         https://bugs.webkit.org/show_bug.cgi?id=194185
1764
1765         Reviewed by Antti Koivisto.
1766
1767         * LayoutReloaded/misc/LFC-passing-tests.txt:
1768
1769 2018-12-16  Darin Adler  <darin@apple.com>
1770
1771         Convert additional String::format clients to alternative approaches
1772         https://bugs.webkit.org/show_bug.cgi?id=192746
1773
1774         Reviewed by Alexey Proskuryakov.
1775
1776         * WebKitTestRunner/TestController.cpp:
1777         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1778         as an intermediate in code that ultimately constructs a WTF::String.
1779         (WTR::userMediaOriginHash): Use makeString.
1780         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1781         (WTR::TestController::didPerformClientRedirect): Ditto.
1782         (WTR::TestController::didPerformServerRedirect): Ditto.
1783         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1784
1785 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1786
1787         [ews-build] Add unit test to verify builder keys
1788         https://bugs.webkit.org/show_bug.cgi?id=194152
1789
1790         Reviewed by Lucas Forschler.
1791
1792         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1793         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1794
1795 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1796
1797         [LFC] Expand tests coverage (12 new tests -> 787)
1798
1799         Unreviewed test gardening.
1800
1801         * LayoutReloaded/misc/LFC-passing-tests.txt:
1802
1803 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1804
1805         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1806         https://bugs.webkit.org/show_bug.cgi?id=194163
1807
1808         Reviewed by Simon Fraser.
1809
1810         775
1811
1812         * LayoutReloaded/misc/LFC-passing-tests.txt:
1813
1814 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1815
1816         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1817         https://bugs.webkit.org/show_bug.cgi?id=194140
1818         <rdar://problem/47728098>
1819
1820         Reviewed by Tim Horton.
1821
1822         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1824         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1825
1826         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1827         test to induce an IPC deadlock when presenting a modal alert during touch start.
1828
1829         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1830         * WebKitTestRunner/TestController.cpp:
1831         (WTR::runJavaScriptAlert):
1832
1833         Add a client callback function for running JavaScript alerts.
1834
1835         (WTR::TestController::createOtherPage):
1836         (WTR::TestController::generateContextConfiguration const):
1837
1838         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1839         the fix in this patch.
1840
1841         (WTR::TestController::createWebViewWithOptions):
1842
1843         Plumb TestOptions to generateContextConfiguration.
1844
1845         (WTR::TestController::resetPreferencesToConsistentValues):
1846         (WTR::TestController::resetStateToConsistentValues):
1847         (WTR::updateTestOptionsFromTestHeader):
1848         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1849         (WTR::TestController::handleJavaScriptAlert):
1850         * WebKitTestRunner/TestController.h:
1851         * WebKitTestRunner/TestInvocation.cpp:
1852         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1853         * WebKitTestRunner/TestOptions.h:
1854         (WTR::TestOptions::hasSameInitializationOptions const):
1855
1856 2019-02-01  Chris Dumez  <cdumez@apple.com>
1857
1858         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1859         https://bugs.webkit.org/show_bug.cgi?id=193740
1860         <rdar://problem/47527267>
1861
1862         Reviewed by Alex Christensen.
1863
1864         Add API test coverage.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1867
1868 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1869
1870         [ews-app] Add display name field to BuilderMapping model
1871         https://bugs.webkit.org/show_bug.cgi?id=194153
1872
1873         Reviewed by Lucas Forschler.
1874
1875         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1876         (BuilderMapping):
1877
1878 2019-02-01  Youenn Fablet  <youenn@apple.com>
1879
1880         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1881         https://bugs.webkit.org/show_bug.cgi?id=194155
1882
1883         Reviewed by Eric Carlson.
1884
1885         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1886         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1887         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1888
1889 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1890
1891         [LFC] Adjust replaced element's intrinsic ratio
1892         https://bugs.webkit.org/show_bug.cgi?id=194154
1893
1894         Reviewed by Antti Koivisto.
1895
1896         761
1897
1898         * LayoutReloaded/misc/LFC-passing-tests.txt:
1899
1900 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1901
1902         [WPE] Show test results in minibrowser
1903         https://bugs.webkit.org/show_bug.cgi?id=194150
1904
1905         Reviewed by Žan Doberšek.
1906
1907         * Scripts/webkitpy/port/wpe.py:
1908         (WPEPort.show_results_html_file):
1909
1910 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1911
1912         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1913         https://bugs.webkit.org/show_bug.cgi?id=194151
1914
1915         Reviewed by Žan Doberšek.
1916
1917         ALT + <- go back
1918         ALT + -> go forward
1919
1920         * MiniBrowser/wpe/main.cpp:
1921         (main):
1922
1923 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1924
1925         [LFC] Set intrinsic size on Layout::Replaced
1926         https://bugs.webkit.org/show_bug.cgi?id=194139
1927
1928         Reviewed by Antti Koivisto.
1929
1930         744
1931
1932         * LayoutReloaded/misc/LFC-passing-tests.txt:
1933
1934 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1935
1936         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1937         https://bugs.webkit.org/show_bug.cgi?id=194146
1938
1939         Reviewed by Xabier Rodriguez-Calvar.
1940
1941         It allows to open relative paths.
1942
1943         * MiniBrowser/wpe/main.cpp:
1944         (main):
1945
1946 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1947
1948         Update flakiness dashboard configuration after recent queue changes
1949         https://bugs.webkit.org/show_bug.cgi?id=194127
1950
1951         Rubber-stamped by Aakash Jain.
1952
1953         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1954
1955         * TestResultServer/static-dashboards/builders.jsonp:
1956
1957 2019-01-31  Youenn Fablet  <youenn@apple.com>
1958
1959         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1960         https://bugs.webkit.org/show_bug.cgi?id=194106
1961         <rdar://problem/47676333>
1962
1963         Reviewed by Ryosuke Niwa.
1964
1965         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1966         (TestWebKitAPI::didFinishNavigation):
1967         (TestWebKitAPI::TEST):
1968         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1969
1970 2019-01-31  Chris Dumez  <cdumez@apple.com>
1971
1972         Page zoom level is lost after a process swap or a crash
1973         https://bugs.webkit.org/show_bug.cgi?id=194105
1974         <rdar://problem/47610781>
1975
1976         Reviewed by Alex Christensen.
1977
1978         Add API test coverage.
1979
1980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1981         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1982
1983 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1984
1985         Revert r238819 which is unneeded and caused a performance regression.
1986         https://bugs.webkit.org/show_bug.cgi?id=192272
1987         <rdar://problem/46664625>
1988
1989         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1990         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1991         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1992
1993 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1994
1995         Formalize WebKitAdditions mechanism of LoadOptimizer
1996         https://bugs.webkit.org/show_bug.cgi?id=193886
1997         <rdar://problem/47696809>
1998
1999         Reviewed by Brent Fulgham.
2000
2001         * MiniBrowser/MiniBrowser.entitlements:
2002         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2003
2004 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2005
2006         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2007         https://bugs.webkit.org/show_bug.cgi?id=194090
2008
2009         Reviewed by Antti Koivisto.
2010
2011         * LayoutReloaded/misc/LFC-passing-tests.txt:
2012
2013 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2014
2015         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2016         https://bugs.webkit.org/show_bug.cgi?id=194074
2017
2018         Reviewed by Antti Koivisto.
2019
2020         * LayoutReloaded/misc/LFC-passing-tests.txt:
2021
2022 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2023
2024         [LFC][BFC] Add support for block level replaced box.
2025         https://bugs.webkit.org/show_bug.cgi?id=194071
2026
2027         Reviewed by Antti Koivisto.
2028
2029         * LayoutReloaded/misc/LFC-passing-tests.txt:
2030
2031 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2032
2033         Fix WebKitTestRunner's testPath with Windows full paths
2034         https://bugs.webkit.org/show_bug.cgi?id=194012
2035
2036         Reviewed by Alex Christensen.
2037
2038         updateTestOptionsFromTestHeader failed to open test files because
2039         testPath returned wrong file paths. It returned a path "/C:/..."
2040         if a URL "file:///C:/..." was given.
2041
2042         * WebKitTestRunner/TestController.cpp:
2043         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2044
2045 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2046
2047         [WPE] Bump font related dependencies to match the GTK+ port
2048         https://bugs.webkit.org/show_bug.cgi?id=194017
2049
2050         Reviewed by Žan Doberšek.
2051
2052         * wpe/jhbuild.modules:
2053         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2054         * wpe/patches/icudata-stdlibs.patch: Added.
2055
2056 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2057
2058         Enable swipe tests on iOS
2059         https://bugs.webkit.org/show_bug.cgi?id=194076
2060
2061         Reviewed by Geoffrey Garen.
2062
2063         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2064         it causes a debug assertion failure in runUIScript.
2065
2066         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2067         (WTR::UIScriptController::beginBackSwipe):
2068         (WTR::UIScriptController::completeBackSwipe):
2069
2070 2019-01-30  Keith Rollin  <krollin@apple.com>
2071
2072         Use correct printf format specifier
2073         https://bugs.webkit.org/show_bug.cgi?id=194062
2074         <rdar://problem/47686167>
2075
2076         Reviewed by Alexey Proskuryakov.
2077
2078         LayoutTestSpellChecker.mm is trying to format a variable of type
2079         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2080         actually an unsigned long long. Fix this by formatting with %llu.
2081
2082         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2083         (-[LayoutTestTextCheckingResult description]):
2084
2085 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2088         https://bugs.webkit.org/show_bug.cgi?id=193979
2089
2090         Reviewed by Wenson Hsieh.
2091
2092         Fix the test for iOS. Make the test work with iOS UA string.
2093
2094         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2095
2096 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2097
2098         Replace High Sierra LLINT CLoop bot due to hardware failure
2099         https://bugs.webkit.org/show_bug.cgi?id=194066
2100
2101         Reviewed by Aakash Jain.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/config.json:
2104
2105 2019-01-30  Keith Rollin  <krollin@apple.com>
2106
2107         [NSDragItem init] is unavailable
2108         https://bugs.webkit.org/show_bug.cgi?id=194059
2109         <rdar://problem/47685715>
2110
2111         Reviewed by Wenson Hsieh.
2112
2113         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2114         DumpRenderTree and TestWebKitAPI, which both try to create an
2115         NSDragItem in a manner that invokes this method. Address this by using
2116         -initWithPasteboardWriter instead.
2117
2118         Note that the parameter passed to initWithPasteboardWriter is likely
2119         incorrect. In both cases, the object passed does not conform to
2120         NSPasteboardWriting. However, with this fix, we're no worse off than
2121         before, and can now perform builds with newer compilers and SDKs until
2122         a real fix can be crafted. That work is tracked in
2123         https://bugs.webkit.org/show_bug.cgi?id=194060
2124
2125         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2126         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2127         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2128         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2129
2130 2019-01-30  Daniel Bates  <dabates@apple.com>
2131
2132         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2133         https://bugs.webkit.org/show_bug.cgi?id=192824
2134         <rdar://problem/47100332>
2135
2136         Reviewed by Wenson Hsieh.
2137
2138         Fix a bug where the wrong usage code was used for F13 thru F24.
2139
2140         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2141         (keyCodeForDOMFunctionKey):
2142
2143 2019-01-30  Chris Dumez  <cdumez@apple.com>
2144
2145         Regression(PSON) Load hang can occur on history navigation
2146         https://bugs.webkit.org/show_bug.cgi?id=194030
2147         <rdar://problem/47656939>
2148
2149         Reviewed by Antti Koivisto.
2150
2151         Add API test coverage.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2154
2155 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2156
2157         [LFC] Expand tests coverage.
2158
2159         Unreviewed test gardening.
2160
2161         * LayoutReloaded/misc/LFC-passing-tests.txt:
2162
2163 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2164
2165         [Flatpak] Add openjpeg support
2166         https://bugs.webkit.org/show_bug.cgi?id=194019
2167
2168         Reviewed by Michael Catanzaro.
2169
2170         * flatpak/org.webkit.CommonModules.yaml:
2171
2172 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2173
2174         Unreviewed, rolling out r240708.
2175         https://bugs.webkit.org/show_bug.cgi?id=194022
2176
2177         It broke WPE build (Requested by KaL on #webkit).
2178
2179         Reverted changeset:
2180
2181         "[WPE] Bump font related dependencies to match the GTK+ port"
2182         https://bugs.webkit.org/show_bug.cgi?id=194017
2183         https://trac.webkit.org/changeset/240708
2184
2185 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2186
2187         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2188         https://bugs.webkit.org/show_bug.cgi?id=194001
2189
2190         Reviewed by Antti Koivisto.
2191
2192         * LayoutReloaded/misc/LFC-passing-tests.txt:
2193
2194 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2195
2196         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2197         https://bugs.webkit.org/show_bug.cgi?id=194020
2198
2199         Reviewed by Antti Koivisto.
2200
2201         * LayoutReloaded/misc/LFC-passing-tests.txt:
2202
2203 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2204
2205         AX: Support color well on iOS
2206         https://bugs.webkit.org/show_bug.cgi?id=194010
2207
2208         Reviewed by Joanmarie Diggs.
2209
2210         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2211         (WTR::AccessibilityUIElement::stringAttributeValue):
2212
2213 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2214
2215         [WPE] Bump font related dependencies to match the GTK+ port
2216         https://bugs.webkit.org/show_bug.cgi?id=194017
2217
2218         Reviewed by Žan Doberšek.
2219
2220         * wpe/jhbuild.modules:
2221         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2222         * wpe/patches/icudata-stdlibs.patch: Added.
2223
2224 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2225
2226         [Mac] Update window scale API usage
2227         https://bugs.webkit.org/show_bug.cgi?id=193991
2228         rdar://problem/47614795
2229
2230         Reviewed by Tim Horton.
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm:
2233         (changeWindowScaleIfNeeded):
2234         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2235         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2236         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2237
2238 2019-01-29  Chris Dumez  <cdumez@apple.com>
2239
2240         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2241         https://bugs.webkit.org/show_bug.cgi?id=193977
2242         <rdar://problem/47643716>
2243
2244         Reviewed by Geoff Garen.
2245
2246         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2247         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2248         to the previous provisional committing *before* we make the last load. 
2249
2250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2251
2252 2019-01-29  Youenn Fablet  <youenn@apple.com>
2253
2254         Adopt new SPI to evaluate server certificate trust
2255         https://bugs.webkit.org/show_bug.cgi?id=193355
2256
2257         Reviewed by Alex Christensen.
2258
2259         Add infrastructure to handle HTTPS server trust evaluation testing.
2260
2261         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2263         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2264         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2265         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2266         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2267         * WebKitTestRunner/TestController.cpp:
2268         (WTR::TestController::resetPreferencesToConsistentValues):
2269         (WTR::TestController::didReceiveAuthenticationChallenge):
2270         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2271         * WebKitTestRunner/TestController.h:
2272         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2273         * WebKitTestRunner/TestInvocation.cpp:
2274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2276         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2277
2278 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2279
2280         [ews-build] Add build step to print bot Configuration
2281         https://bugs.webkit.org/show_bug.cgi?id=193887
2282
2283         Reviewed by Lucas Forschler.
2284
2285         * BuildSlaveSupport/ews-build/steps.py:
2286         (PrintConfiguration): Build step to print configuration.
2287         * BuildSlaveSupport/ews-build/factories.py:
2288
2289 2019-01-29  Chris Dumez  <cdumez@apple.com>
2290
2291         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2292         https://bugs.webkit.org/show_bug.cgi?id=193967
2293         <rdar://problem/47635348>
2294
2295         Reviewed by Alex Christensen.
2296
2297         Add API test coverage.
2298
2299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2300         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2301
2302 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [ews-app] Handle incoming results data
2305         https://bugs.webkit.org/show_bug.cgi?id=193973
2306
2307         Reviewed by Lucas Forschler.
2308
2309         * BuildSlaveSupport/ews-app/ews/views/results.py:
2310
2311 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2312
2313         [ews-app] Make the results url generic
2314         https://bugs.webkit.org/show_bug.cgi?id=193928
2315
2316         Reviewed by Lucas Forschler.
2317
2318         * BuildSlaveSupport/ews-app/ews/urls.py:
2319
2320 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2321
2322         [ews-build] Configure buildbot to send events to ews-app
2323         https://bugs.webkit.org/show_bug.cgi?id=193968
2324
2325         Reviewed by Lucas Forschler.
2326
2327         * BuildSlaveSupport/ews-build/events.py: Added.
2328         * BuildSlaveSupport/ews-build/master.cfg:
2329
2330 2019-01-29  Keith Rollin  <krollin@apple.com>
2331
2332         Add .xcfilelists to Run Script build phases
2333         https://bugs.webkit.org/show_bug.cgi?id=193792
2334         <rdar://problem/47201785>
2335
2336         Reviewed by Alex Christensen.
2337
2338         As part of supporting XCBuild, update the necessary Run Script build
2339         phases in their Xcode projects to refer to their associated
2340         .xcfilelist files.
2341
2342         Note that the addition of these files bumps the Xcode project version
2343         number to something that's Xcode 10 compatible. This change means that
2344         older versions of the Xcode IDE can't read these projects. Nor can it
2345         fully load workspaces that refer to these projects (the updated
2346         projects are shown as non-expandable placeholders). `xcodebuild` can
2347         still build these projects; it's just that the IDE can't open them.
2348
2349         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2350         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2351
2352 2019-01-29  John Wilander  <wilander@apple.com>
2353
2354         Add data abstraction and validation for Ad Click Attribution
2355         https://bugs.webkit.org/show_bug.cgi?id=193916
2356         <rdar://problem/47603481>
2357
2358         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2359
2360         Ad click attribution has two steps. First, the storage of an ad
2361         campaign ID for a click that takes the user to a destination
2362         site. Second, a conversion on the destination site that can be
2363         attributed to the ad click.
2364
2365         This patch adds a class that represents a request for ad click
2366         attribution. Validation makes sure that the bits of entropy
2367         reported through this mechanism is limited.
2368
2369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2370         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2371         (TestWebKitAPI::TEST):
2372
2373 2019-01-29  Chris Dumez  <cdumez@apple.com>
2374
2375         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2376         https://bugs.webkit.org/show_bug.cgi?id=193932
2377         <rdar://problem/47598947>
2378
2379         Reviewed by Brady Eidson.
2380
2381         Add API test coverage.
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2384
2385 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2386
2387         Adding new passing LFC tests.
2388
2389         Unreviewed test gardening.
2390
2391         * LayoutReloaded/misc/LFC-passing-tests.txt:
2392
2393 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2394
2395         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2396         https://bugs.webkit.org/show_bug.cgi?id=193964
2397
2398         Reviewed by Antti Koivisto.
2399
2400         * LayoutReloaded/misc/LFC-passing-tests.txt:
2401
2402 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2403
2404         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2405         https://bugs.webkit.org/show_bug.cgi?id=193954
2406
2407         Reviewed by Antti Koivisto.
2408
2409         * LayoutReloaded/misc/LFC-passing-tests.txt:
2410
2411 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2412
2413         WebDriver: add support for running subtests
2414         https://bugs.webkit.org/show_bug.cgi?id=193904
2415
2416         Reviewed by Michael Catanzaro.
2417
2418         pytest already supports it by passing test.py::subtest, so we can do the same.
2419
2420         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2421         (get_item_name): Made this global.
2422         (CollectRecorder.__init__): Receive the parameter to ignore.
2423         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2424         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2425         (collect): Add parameter to ignore.
2426         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2427         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2428         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2429         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2430         (WebDriverTestRunnerSelenium.run): Ditto.
2431         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2432         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2433         (WebDriverTestRunnerW3C.run): Ditto.
2434
2435 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         User agent string override for navigator.userAgent should be site specific quirks
2438         https://bugs.webkit.org/show_bug.cgi?id=193950
2439
2440         Reviewed by Brent Fulgham.
2441
2442         Updated per the _WKWebsitePolicies rename.
2443
2444         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2445         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2446
2447 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2448
2449         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2450         https://bugs.webkit.org/show_bug.cgi?id=193941
2451
2452         Reviewed by Alex Christensen.
2453
2454         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2455         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2456         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2457         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2458         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2459         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2460         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2461         * TestWebKitAPI/Tests/WTF/Time.cpp:
2462         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2463         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2464         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2465         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2466
2467 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2468
2469         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2470
2471         * Scripts/webkitpy/common/config/contributors.json:
2472
2473 2019-01-28  Andy Estes  <aestes@apple.com>
2474
2475         [watchOS] Enable Parental Controls content filtering
2476         https://bugs.webkit.org/show_bug.cgi?id=193939
2477         <rdar://problem/46641912>
2478
2479         Reviewed by Ryosuke Niwa.
2480
2481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2482
2483 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2484
2485         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2486         <https://webkit.org/b/193884>
2487
2488         Reviewed by Jiewen Tan.
2489
2490         * Scripts/webkitpy/style/checkers/cpp.py:
2491         (check_language): Add LocalAuthentication to
2492         `frameworks_with_soft_links`.
2493
2494 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2495
2496         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2497         https://bugs.webkit.org/show_bug.cgi?id=193891
2498
2499         Reviewed by Ross Kirsling.
2500
2501         There were three problems in window sizes of WebView and the host window.
2502         1. The sizes of pixel image output were incorrect.
2503         2. The host window is going to appear after window.resize was invoked.
2504         3. window.resize resized only the host window, not WebView.
2505
2506         This change solves them with a following approach.
2507         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2508         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2509            as well as DumpRenderTree in order to match the client area and the window area.
2510         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2511         d. PlatformWebView::setWindowFrame changes both window sizes.
2512         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2513
2514         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2515         (WTR::PlatformWebView::PlatformWebView): Create the host window
2516         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2517         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2518         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2519
2520 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2521
2522         [ews-app] Add method to save Step data to database
2523         https://bugs.webkit.org/show_bug.cgi?id=193890
2524
2525         Reviewed by Lucas Forschler.
2526
2527         * BuildSlaveSupport/ews-app/ews/models/step.py:
2528         (Step.save_step): Method to save step data.
2529         (Step.update_step): Method to update step data.
2530         (Step.get_existing_step): Method to fetch existing step from database.
2531         (Step.is_valid_result): Method to validate valid step result.
2532
2533 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2534
2535         [ews-app] Add method to save Build data to database
2536         https://bugs.webkit.org/show_bug.cgi?id=193735
2537
2538         Reviewed by Lucas Forschler.
2539
2540         * BuildSlaveSupport/ews-app/ews/models/build.py:
2541         (Build.save_build): Method to save build information to database.
2542         (Build.get_existing_build): Method to fetch existing build from database.
2543         (Build.is_valid_result): Method to validate build result.
2544         * BuildSlaveSupport/ews-app/ews/common/util.py:
2545         (is_valid_int_id): Method to validate valid id.
2546
2547 2019-01-28  Chris Dumez  <cdumez@apple.com>
2548
2549         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2550         https://bugs.webkit.org/show_bug.cgi?id=193915
2551         <rdar://problem/47560907>
2552
2553         Reviewed by Alex Christensen.
2554
2555         Add API test coverage.
2556
2557         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2558
2559 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2560
2561         [ews-app] Rename id variables
2562         https://bugs.webkit.org/show_bug.cgi?id=193883
2563
2564         Reviewed by Lucas Forschler.
2565
2566         * BuildSlaveSupport/ews-app/ews/models/build.py:
2567         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2568         * BuildSlaveSupport/ews-app/ews/models/step.py:
2569         * BuildSlaveSupport/ews-app/ews/urls.py:
2570         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2571         * BuildSlaveSupport/ews-app/ews/views/results.py:
2572         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2573
2574 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2575
2576         [ews-app] Allow certain fields to be empty
2577         https://bugs.webkit.org/show_bug.cgi?id=193892
2578
2579         Reviewed by Lucas Forschler.
2580
2581         * BuildSlaveSupport/ews-app/ews/models/build.py:
2582         * BuildSlaveSupport/ews-app/ews/models/step.py:
2583
2584 2019-01-28  Rob Buis  <rbuis@igalia.com>
2585
2586         Update MIME type parser
2587         https://bugs.webkit.org/show_bug.cgi?id=180526
2588
2589         Reviewed by Frédéric Wang.
2590
2591         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2592         (TestWebKitAPI::TEST):
2593
2594 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2595
2596         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2597         https://bugs.webkit.org/show_bug.cgi?id=193896
2598
2599         Reviewed by Antti Koivisto.
2600
2601         * LayoutReloaded/misc/LFC-passing-tests.txt:
2602
2603 2018-12-15  Darin Adler  <darin@apple.com>
2604
2605         Replace many uses of String::format with more type-safe alternatives
2606         https://bugs.webkit.org/show_bug.cgi?id=192742
2607
2608         Reviewed by Mark Lam.
2609
2610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2611         (WTR::cacheTestRunnerCallback): Use makeString.
2612         * WebKitTestRunner/TestController.cpp:
2613         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2614         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2615
2616 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2617
2618         Use a load optimizer for some sites
2619         https://bugs.webkit.org/show_bug.cgi?id=193881
2620         <rdar://problem/46325455>
2621
2622         Reviewed by Brent Fulgham.
2623
2624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2625         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2626
2627 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2628
2629         AX: Introduce a static accessibility tree
2630         https://bugs.webkit.org/show_bug.cgi?id=193348
2631         <rdar://problem/47203295>
2632
2633         Reviewed by Ryosuke Niwa.
2634
2635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2636
2637 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2638
2639         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2640         https://bugs.webkit.org/show_bug.cgi?id=193867
2641
2642         Reviewed by Antti Koivisto.
2643
2644         * LayoutReloaded/misc/LFC-passing-tests.txt:
2645
2646 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2647
2648         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2649         https://bugs.webkit.org/show_bug.cgi?id=193865
2650
2651         Reviewed by Antti Koivisto.
2652
2653         * LayoutReloaded/misc/LFC-passing-tests.txt:
2654
2655 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2656
2657         Need a mechanism to override navigator.userAgent
2658         https://bugs.webkit.org/show_bug.cgi?id=193762
2659         <rdar://problem/47504939>
2660
2661         Reviewed by Brent Fulgham.
2662
2663         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2664
2665         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2666         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2667         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2668
2669 2019-01-25  Dean Jackson  <dino@apple.com>
2670
2671         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2672         https://bugs.webkit.org/show_bug.cgi?id=193831
2673         <rdar://problem/47399263>
2674
2675         Reviewed by Chris Dumez.
2676
2677         Two new tests that exercise cross-origin and same-origin System
2678         Previews.
2679
2680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2681
2682 2019-01-25  Keith Rollin  <krollin@apple.com>
2683
2684         Update Xcode projects with "Check .xcfilelists" build phase
2685         https://bugs.webkit.org/show_bug.cgi?id=193790
2686         <rdar://problem/47201374>
2687
2688         Reviewed by Alex Christensen.
2689
2690         Support for XCBuild includes specifying inputs and outputs to various
2691         Run Script build phases. These inputs and outputs are specified as
2692         .xcfilelist files. Once created, these .xcfilelist files need to be
2693         kept up-to-date. In order to check that they are up-to-date or not,
2694         add an Xcode build step that invokes an external script that performs
2695         the checking. If the .xcfilelists are found to be out-of-date, update
2696         them, halt the build, and instruct the developer to restart the build
2697         with up-to-date files.
2698
2699         At this time, the checking and regenerating is performed only if the
2700         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2701         who want to use this facility can set this variable and test out the
2702         checking/regenerating. Once it seems like there are no egregious
2703         issues that upset a developer's workflow, we'll unconditionally enable
2704         this facility.
2705
2706         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2707         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2708         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2710
2711 2019-01-25  Keith Rollin  <krollin@apple.com>
2712
2713         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2714         https://bugs.webkit.org/show_bug.cgi?id=193781
2715         <rdar://problem/47201153>
2716
2717         Reviewed by Alex Christensen.
2718
2719         Part of generating the .xcfilelists used as part of adopting XCBuild
2720         includes running `make DerivedSources.make` from a standalone script.
2721         It’s important for this invocation to have the same environment as
2722         when the actual build invokes `make DerivedSources.make`. If the
2723         environments are different, then the two invocations will provide
2724         different results. In order to get the same environment in the
2725         standalone script, have the script launch xcodebuild targeting the
2726         "Apply Configuration to XCFileLists" build target, which will then
2727         re-invoke our standalone script. The script is now running again, this
2728         time in an environment with all workspace, project, target, xcconfig
2729         and other environment variables established.
2730
2731         The "Apply Configuration to XCFileLists" build target accomplishes
2732         this task via a small embedded shell script that consists only of:
2733
2734             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2735
2736         The process that invokes "Apply Configuration to XCFileLists" first
2737         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2738         evaluated and exports it into the shell environment. When xcodebuild
2739         is invoked, it inherits the value of this variable and can `eval` the
2740         contents of that variable. Our external standalone script can then set
2741         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2742         of command-line parameters needed to restart itself in the appropriate
2743         state.
2744
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2747
2748 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2749
2750         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2751         https://bugs.webkit.org/show_bug.cgi?id=193802
2752         <rdar://problem/46010580>
2753
2754         Reviewed by Andy Estes.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2757         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2758         (TEST):
2759
2760 2019-01-25  Daniel Bates  <dabates@apple.com>
2761
2762         [iOS] uiController.keyDown() does not translate Control modified key
2763         https://bugs.webkit.org/show_bug.cgi?id=192898
2764
2765         Reviewed by Wenson Hsieh.
2766
2767         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2768         key translation, as applicable. Among other cases, key translation occurs when performing
2769         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2770         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2771         human pressing down and releasing key(s) using a hardware keyboard.
2772
2773         * WebKitTestRunner/ios/HIDEventGenerator.h:
2774         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2775         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2776
2777         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2778         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2779         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2780         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2781         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2782         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2783         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2784         (-[HIDEventGenerator longPress:completionBlock:]):
2785         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2786         Update code for above renaming.
2787
2788         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2789         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2790
2791         (-[HIDEventGenerator keyDown:]): Added.
2792         (-[HIDEventGenerator keyUp:]): Added.
2793         (-[HIDEventGenerator keyPress:completionBlock:]):
2794         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2795         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2796         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2797         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2798         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2799         (WTR::parseModifier): Deleted.
2800
2801 2019-01-25  Keith Rollin  <krollin@apple.com>
2802
2803         Complete the implementation of generate-xcfilelists
2804         https://bugs.webkit.org/show_bug.cgi?id=193782
2805
2806         Reviewed by Alex Christensen.
2807
2808         A preliminary version of generate-xcfilelists was added in r238008.
2809         This patch updates that script in order to:
2810
2811         - Support checking of .xcfilelists
2812         - Perform better execution of `make DerivedSources.make` by
2813           relaunching generate-xcfilelists under xcodebuild
2814         - Support incremental generation and checking of .xcfilelists
2815         - Support supplementary .xcfilelists files from WebKitAdditions
2816         - Support being wrapped by parallel version of generate-xcfilelists in
2817           Internal that adds support for (re)generating WebKit projects in
2818           that repo.
2819         - Support builds that have been performed in WebKitBuild as well as
2820           ~/Library/Developer/code/DerivedData
2821         - Increase robustness and debugging facilities.
2822
2823         * Scripts/generate-xcfilelists:
2824
2825 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2826
2827         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2828         https://bugs.webkit.org/show_bug.cgi?id=193297
2829         <rdar://problem/47158841>
2830
2831         Unreviewed test case fix.
2832
2833         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2834         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2835
2836         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2837         (TEST):
2838
2839 2019-01-25  Keith Rollin  <krollin@apple.com>
2840
2841         Update existing .xcfilelists
2842         https://bugs.webkit.org/show_bug.cgi?id=193791
2843         <rdar://problem/47201706>
2844
2845         Reviewed by Alex Christensen.
2846
2847         Many .xcfilelist files were added in r238824 in order to support
2848         XCBuild. Update these with recent changes to the set of build files
2849         and with the current generate-xcfilelist script.
2850
2851         * DumpRenderTree/DerivedSources-input.xcfilelist:
2852         * DumpRenderTree/DerivedSources-output.xcfilelist:
2853         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2854         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2855
2856 2019-01-25  Keith Rollin  <krollin@apple.com>
2857
2858         Fix missing dependencies in extract-dependencies-from-makefile
2859         https://bugs.webkit.org/show_bug.cgi?id=193783
2860         <rdar://problem/47201571>
2861
2862         Reviewed by Alex Christensen.
2863
2864         The extract-dependencies-from-makefile script generates .xcfilelists
2865         for XCBuild by invoking a makefile in --debug mode, parsing the
2866         dependency information in the output, and extracting information
2867         regarding targets and dependents. However, the way `make` emits this
2868         dependency information is not rigorous, and so we need to determine
2869         what lines to look for and parse by trial and error. This approach
2870         didn't coriginally atch all the information we needed to collect, so
2871         update the script to look for the additional lines we now know to look
2872         for.
2873
2874         * Scripts/extract-dependencies-from-makefile:
2875         (Parser):
2876         (Parser.addTarget):
2877         (Parser.addPrereq):
2878         (Parser.doParse):
2879
2880 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2881
2882         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2883         https://bugs.webkit.org/show_bug.cgi?id=193297
2884         <rdar://problem/47158841>
2885
2886         Reviewed by Alex Christensen.
2887
2888         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2889             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2890         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2891         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2892         activating the message used to trigger the callback when it is set.
2893
2894 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2895
2896         WKWebView.goBack should reload if there is a safe browsing warning
2897         https://bugs.webkit.org/show_bug.cgi?id=193805
2898         <rdar://problem/46908216>
2899
2900         Reviewed by Geoff Garen.
2901
2902         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2903         (+[Simple3LookupContext sharedLookupContext]):
2904         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2905         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2906         (TEST):
2907
2908 2019-01-25  Chris Dumez  <cdumez@apple.com>
2909
2910         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2911         https://bugs.webkit.org/show_bug.cgi?id=193788
2912         <rdar://problem/47531231>
2913
2914         Reviewed by Alex Christensen.
2915
2916         Add API test coverage.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2919         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2920
2921 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2922
2923         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2924         https://bugs.webkit.org/show_bug.cgi?id=193771
2925
2926         Unreviewed infrastructure fix.
2927
2928         * Scripts/webkitpy/port/darwin.py:
2929         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2930
2931 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2932
2933         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2934
2935 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2936
2937         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2938
2939         * Scripts/webkitpy/common/config/contributors.json:
2940
2941 2019-01-25  Chris Dumez  <cdumez@apple.com>
2942
2943         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2944         https://bugs.webkit.org/show_bug.cgi?id=193779
2945         <rdar://problem/46170903>
2946
2947         Reviewed by Antti Koivisto.
2948
2949         Add API test that quickly navigates forward to a previous process without waiting for it to
2950         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2951         the process' previous page when reconnecting the it for the forward navigation.
2952
2953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2954
2955 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2956
2957         Need a way for JavaScript (or bundle) code to participate in undo
2958         https://bugs.webkit.org/show_bug.cgi?id=190009
2959         <rdar://problem/44807048>
2960
2961         Reviewed by Ryosuke Niwa.
2962
2963         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2964         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2965
2966         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2967         (WTR::UIScriptController::lastUndoLabel const):
2968         (WTR::UIScriptController::firstRedoLabel const):
2969         (WTR::UIScriptController::platformUndoManager const):
2970         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2971         (WTR::UIScriptController::lastUndoLabel const):
2972         (WTR::UIScriptController::firstRedoLabel const):
2973         (WTR::UIScriptController::platformUndoManager const):
2974         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2975         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2976         (WTR::UIScriptController::lastUndoLabel const):
2977         (WTR::UIScriptController::firstRedoLabel const):
2978         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2979         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2980         (WTR::UIScriptController::lastUndoLabel const):
2981         (WTR::UIScriptController::firstRedoLabel const):
2982         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2983         (WTR::UIScriptController::platformUndoManager const):
2984         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2985         (WTR::UIScriptController::platformUndoManager const):
2986
2987 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2988
2989         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2990         https://bugs.webkit.org/show_bug.cgi?id=193824
2991
2992         Reviewed by Antti Koivisto.
2993
2994         * LayoutReloaded/misc/LFC-passing-tests.txt:
2995
2996 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2997
2998         Update macOS JSC bot configurations
2999         https://bugs.webkit.org/show_bug.cgi?id=193739
3000
3001         Reviewed by Alexey Proskuryakov.
3002
3003         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3005         (BubbleQueueServer): Move JSC EWS to Mojave section.
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3007         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3008         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3009
3010 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3011
3012         [Win][WebKitTestRunner] Implement EventSenderProxy
3013         https://bugs.webkit.org/show_bug.cgi?id=193755
3014
3015         Reviewed by Don Olmstead.
3016
3017         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3018         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3019         (WTR::EventSenderProxy::dispatchMessage):
3020         (WTR::EventSenderProxy::EventSenderProxy):
3021         (WTR::EventSenderProxy::mouseDown):
3022         (WTR::EventSenderProxy::mouseUp):
3023         (WTR::EventSenderProxy::mouseMoveTo):
3024         (WTR::EventSenderProxy::mouseScrollBy):
3025         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3026
3027 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3028
3029         Unreviewed fix for API test failure after r240437.
3030
3031         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3032
3033         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3034
3035 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3036
3037         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3038         https://bugs.webkit.org/show_bug.cgi?id=193787
3039         <rdar://problem/47497634>
3040
3041         Reviewed by Alexey Proskuryakov.
3042
3043         * Scripts/webkitdirs.pm:
3044         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3045
3046 2019-01-24  Truitt Savell  <tsavell@apple.com>
3047
3048         Unreviewed, rolling out r240446.
3049
3050         Casued 5 API failures
3051
3052         Reverted changeset:
3053
3054         "Activate the WebResourceLoadStatisticsStore in the
3055         NetworkProcess and deactivate it in the UIProcess."
3056         https://bugs.webkit.org/show_bug.cgi?id=193297
3057         https://trac.webkit.org/changeset/240446
3058
3059 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3060
3061         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3062         https://bugs.webkit.org/show_bug.cgi?id=193741
3063         <rdar://problem/47135030>
3064
3065         Reviewed by Antti Koivisto and Simon Fraser.
3066
3067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3068         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3069         (TestWebKitAPI::TEST):
3070
3071 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3072
3073         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3074         https://bugs.webkit.org/show_bug.cgi?id=193297
3075         <rdar://problem/47158841>
3076
3077         Reviewed by Alex Christensen.
3078
3079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3080         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3081         activating the message used to trigger the callback when it is set.
3082
3083 2019-01-24  John Wilander  <wilander@apple.com>
3084
3085         Add Ad Click Attribution as an internal/experimental feature
3086         https://bugs.webkit.org/show_bug.cgi?id=193685
3087         <rdar://problem/47450399>
3088
3089         Reviewed by Brent Fulgham.
3090
3091         Added test option adClickAttributionEnabled.
3092
3093         * DumpRenderTree/TestOptions.cpp:
3094         (TestOptions::TestOptions):
3095         * DumpRenderTree/TestOptions.h:
3096         * DumpRenderTree/mac/DumpRenderTree.mm:
3097         (setWebPreferencesForTestOptions):
3098
3099 2019-01-24  Antti Koivisto  <antti@apple.com>
3100
3101         [PSON] Flash on back navigation on Mac
3102         https://bugs.webkit.org/show_bug.cgi?id=193716
3103         <rdar://problem/47148458>
3104
3105         Reviewed by Chris Dumez.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3108
3109         Closing of the previous page is delayed so waiting for didFinishNavigation is
3110         not sufficient to guarantee we have received all the messages. Wait for them.
3111
3112 2019-01-24  Chris Dumez  <cdumez@apple.com>
3113
3114         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3115         https://bugs.webkit.org/show_bug.cgi?id=193761
3116         <rdar://problem/47456405>
3117
3118         Reviewed by Alex Christensen.
3119
3120         Add API test coverage.
3121
3122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3123
3124 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3125
3126         webkitpy: Missing PID in crashlog name should not be fatal
3127         https://bugs.webkit.org/show_bug.cgi?id=193771
3128
3129         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3130         of raising an exception.
3131
3132         Reviewed by Lucas Forschler.
3133
3134         * Scripts/webkitpy/port/darwin.py:
3135         (DarwinPort._merge_crash_logs):
3136
3137 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3138
3139         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3140         https://bugs.webkit.org/show_bug.cgi?id=193746
3141
3142         Reviewed by Youenn Fablet.
3143
3144         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3145         so we'd best just not call it.
3146
3147         * Scripts/webkitpy/w3c/test_exporter.py:
3148         (WebPlatformTestExporter.create_branch_with_patch):
3149
3150 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3151
3152         Move FileSystem to WTF
3153         https://bugs.webkit.org/show_bug.cgi?id=193602
3154
3155         Reviewed by Yusuke Suzuki.
3156
3157         * DumpRenderTree/win/DumpRenderTree.cpp:
3158         * TestWebKitAPI/CMakeLists.txt:
3159         * TestWebKitAPI/PlatformGTK.cmake:
3160         * TestWebKitAPI/PlatformJSCOnly.cmake:
3161         * TestWebKitAPI/PlatformPlayStation.cmake:
3162         * TestWebKitAPI/PlatformWPE.cmake:
3163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3164         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3165         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3166         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3167         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3168         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3169         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3170         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3171         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3172         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3173
3174 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3175
3176         [WPE] Remove hard dependency on subprocess32 for the API tests
3177
3178         Rubber-stamped by Carlos Garcia Campos.
3179
3180         * glib/api_test_runner.py:
3181         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3182         its presence only when running WPEQt tests.
3183
3184 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3185
3186         [GLIB] Expose JavaScriptCore options in GLib public API
3187         https://bugs.webkit.org/show_bug.cgi?id=188742
3188
3189         Reviewed by Michael Catanzaro.
3190
3191         Add a test for the new API.
3192
3193         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3194         (testsJSCOptions):
3195         (main):
3196
3197 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         [GTK][WPE] Support JPEG 2000 images
3200         https://bugs.webkit.org/show_bug.cgi?id=186272
3201
3202         Reviewed by Žan Doberšek.
3203
3204         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3205
3206         * gtk/jhbuild.modules:
3207         * wpe/jhbuild.modules:
3208
3209 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3210
3211         check-webkit-style should warn when using soft-linking macros in a header
3212         <https://webkit.org/b/193750>
3213
3214         Reviewed by Darin Adler.
3215
3216         * Scripts/webkitpy/style/checkers/cpp.py:
3217         (check_language): Add softlink/header check by refactoring the
3218         softlink/framework check.
3219         (CppChecker): Enable softlink/header check by default.
3220         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3221         (CppStyleTest.test_softlink_framework): Rename from
3222         CppStyleTest.test_softlink() and change test framework name in
3223         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3224         files. Set file_name for macros that only appear in headers.
3225         (CppStyleTest.test_softlink_header): Add tests for using
3226         soft-link macros in headers.
3227
3228 2019-01-23  Chris Dumez  <cdumez@apple.com>
3229
3230         Deprecate API to limit the maximum number of WebProcesses
3231         https://bugs.webkit.org/show_bug.cgi?id=193725
3232         <rdar://problem/47464879>
3233
3234         Reviewed by Geoff Garen.
3235
3236         Update existing API tests to stop using deprecated API.
3237
3238         * MiniBrowser/mac/AppDelegate.m:
3239         (defaultConfiguration):
3240         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3241         (TestWebKitAPI::TEST):
3242         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3243         (TestWebKitAPI::TEST):
3244         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3245         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3246         (TEST):
3247         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3248         (TEST):
3249
3250 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3251
3252         [ews-app] Rename ews model buildermappings to buildermapping
3253         https://bugs.webkit.org/show_bug.cgi?id=193729
3254
3255         Reviewed by Lucas Forschler.
3256
3257         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3258         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3259         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3260
3261 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3262
3263         [ews-app] Rename ews model steps to step
3264         https://bugs.webkit.org/show_bug.cgi?id=193697
3265
3266         Reviewed by Lucas Forschler.
3267
3268         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3269         (Step): Renamed Steps to Step.
3270
3271 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3272
3273         Clean up IndexedDB files between tests
3274         https://bugs.webkit.org/show_bug.cgi?id=192796
3275         <rdar://problem/46824999>
3276
3277         Reviewed by Geoffrey Garen.
3278
3279         * DumpRenderTree/mac/DumpRenderTree.mm:
3280         (runTest):
3281         * WebKitTestRunner/TestController.cpp:
3282         (WTR::TestController::resetStateToConsistentValues):
3283         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3284         (WTR::RemoveAllIndexedDatabasesCallback):
3285         (WTR::TestController::ClearIndexedDatabases):
3286         * WebKitTestRunner/TestController.h:
3287         * WebKitTestRunner/TestInvocation.cpp:
3288         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3289
3290 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3291
3292         [ews-app] Rename ews model Builds to Build
3293         https://bugs.webkit.org/show_bug.cgi?id=193695
3294
3295         Reviewed by Lucas Forschler.
3296
3297         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3298         (Build): Renamed Builds to Build.
3299
3300 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3301
3302         webkitpy: Wait longer when launching WebKitTestRunner
3303         https://bugs.webkit.org/show_bug.cgi?id=193734
3304
3305         Reviewed by Aakash Jain.
3306
3307         * Scripts/webkitpy/port/simulator_process.py:
3308         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3309
3310 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3311
3312         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3313         https://bugs.webkit.org/show_bug.cgi?id=193182
3314         <rdar://problem/47452154>
3315
3316         Reviewed by Tim Horton.
3317
3318         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3319         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3320         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3321
3322         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3323         preventing later tests from recognizing gestures.
3324
3325         * WebKitTestRunner/ios/TestControllerIOS.mm:
3326         (WTR::TestController::platformResetStateToConsistentValues):
3327
3328         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3329
3330 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3331
3332         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3333         https://bugs.webkit.org/show_bug.cgi?id=193722
3334         <rdar://problem/47481475>
3335
3336         Reviewed by Lucas Forschler.
3337
3338         iPhone and iPad ports should both use the iOS config.
3339
3340         * Scripts/webkitpy/port/ios_simulator.py:
3341         (IPhoneSimulatorPort.__init__):
3342         (IPadSimulatorPort.__init__):
3343
3344 2019-01-23  Rob Buis  <rbuis@igalia.com>
3345
3346         Update MIME type parser
3347         https://bugs.webkit.org/show_bug.cgi?id=180526
3348
3349         Reviewed by Frédéric Wang.
3350
3351         Add unit tests for both parse modes of ParsedContentType.
3352
3353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3354         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3355         (TestWebKitAPI::TEST):
3356
3357 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3358
3359         [ews-app] fetch loop should not stop on network issues
3360         https://bugs.webkit.org/show_bug.cgi?id=193666
3361
3362         Reviewed by Lucas Forschler.
3363
3364         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3365         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3366
3367 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3368
3369         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3370         https://bugs.webkit.org/show_bug.cgi?id=189165
3371         <rdar://problem/47433765>
3372
3373         Reviewed by Tim Horton.
3374
3375         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3376         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3377         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3378         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3379         would make its way to the UI process by the time the layer tree commit is finished.
3380
3381         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3382         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3383         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3384         will fail because it asks for -_autofillContext too early.
3385
3386         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3387         is handled in the UI process.
3388
3389         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3390
3391         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3392         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3393         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3394         input session.
3395
3396         (-[AutofillTestView textInputHasAutofillContext]):
3397
3398         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3399
3400         * TestWebKitAPI/cocoa/TestWKWebView.h:
3401         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3402         (nextInputSessionChangeCount):
3403
3404         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3405         This includes changing the focused element from one to another.
3406
3407         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3408         (-[TestWKWebView didStartFormControlInteraction]):
3409         (-[TestWKWebView didEndFormControlInteraction]):
3410         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3411
3412         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3413         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3414         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3415         that doesn't require an input session to one that doesn't.
3416
3417 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3418
3419         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3420         <https://webkit.org/b/193676>
3421
3422         Reviewed by Alexey Proskuryakov.
3423
3424         * Scripts/webkitpy/style/checkers/cpp.py:
3425         (check_member_initialization_list):
3426         - Don't report missing whitespace around colon if the colon at
3427           the start of the line is formatted correctly.
3428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3429         (WebKitStyleTest.test_member_initialization_list):
3430         - Add a test for a missing permutation of existing tests.
3431         - Add a test this false-positive.
3432         - Add blank lines between subtests to make them easier to read.
3433
3434 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3435
3436         [build.webkit.org] Unit-test failure after r237113
3437         https://bugs.webkit.org/show_bug.cgi?id=193669
3438
3439         Reviewed by Michael Catanzaro.
3440
3441         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3442         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3443         multiple or zero flags.
3444
3445 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3446
3447         Cache bytecode to disk
3448         https://bugs.webkit.org/show_bug.cgi?id=192782
3449         <rdar://problem/46084932>
3450
3451         Reviewed by Keith Miller.
3452
3453         Add test helper to execute bytecode-cache tests: it executes each test
3454         twice, the first with JSC_diskCachePath set to a temporary directory
3455         and second with JSC_forceDiskCache=true (in addition to the cache path)
3456         to guarantee that only the disk cache is being used and no new
3457         UnlinkedCodeBlocks are being created.
3458
3459         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3460         * Scripts/run-jsc-stress-tests:
3461
3462 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3463
3464         [css-logical] Implement flow-relative margin, padding and border shorthands
3465         https://bugs.webkit.org/show_bug.cgi?id=188697
3466
3467         Reviewed by Simon Fraser and Antti Koivisto.
3468
3469         * DumpRenderTree/TestOptions.cpp:
3470         (TestOptions::TestOptions):
3471         * DumpRenderTree/TestOptions.h:
3472         * DumpRenderTree/mac/DumpRenderTree.mm:
3473         (setWebPreferencesForTestOptions):
3474         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3475
3476         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3477         (JSONCSSPropertiesChecker.check_codegen_properties):
3478         Allow CSS property definitions to have a 'runtime-flag' parameter which
3479         disables the property when the specified runtime flag is disabled.
3480
3481 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3482
3483         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3484         https://bugs.webkit.org/show_bug.cgi?id=193643
3485
3486         Reviewed by Michael Catanzaro.
3487
3488         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3489         * wpe/jhbuild.modules: Ditto.
3490
3491 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3492
3493         [LFC][Floats] Take float top position into account when computing containing block height.
3494         https://bugs.webkit.org/show_bug.cgi?id=193655
3495
3496         Reviewed by Antti Koivisto.
3497
3498         * LayoutReloaded/misc/LFC-passing-tests.txt:
3499
3500 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3501
3502         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3503         <https://webkit.org/b/193645>
3504         <rdar://problem/47421574>
3505
3506         Reviewed by Alex Christensen.
3507
3508         - Now checks for local soft-linking of all frameworks that have
3509           their own *SoftLinking.{cpp,h,mm} files.
3510         - Changes softlink/uikit warning to softlink/framework.
3511
3512         * Scripts/webkitpy/style/checkers/cpp.py:
3513         (check_language):
3514         (CppChecker):
3515         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3516         (CppStyleTest):
3517
3518 2019-01-20  Saam Barati  <sbarati@apple.com>
3519
3520         Rollout r240210: It broke tests on iOS
3521         https://bugs.webkit.org/show_bug.cgi?id=193640
3522
3523         Unreviewed.
3524
3525         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3526         * Scripts/run-jsc-stress-tests:
3527
3528 2019-01-20  chris fleizach  <cfleizach@apple.com>
3529
3530         AX: Support returning relative frames for accessibility
3531         https://bugs.webkit.org/show_bug.cgi?id=193414
3532         <rdar://problem/47268501>
3533
3534         Reviewed by Zalan Bujtas.
3535
3536         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3537         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3538         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3539         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3540         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3541         (WTR::attributesOfElement):
3542         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3543
3544 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3545
3546         Unreviewed, add my new email address
3547
3548         * Scripts/webkitpy/common/config/contributors.json:
3549
3550 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3551
3552         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3553         https://bugs.webkit.org/show_bug.cgi?id=193617
3554
3555         Reviewed by Antti Koivisto.
3556
3557         * LayoutReloaded/misc/LFC-passing-tests.txt:
3558
3559 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3560
3561         Unreviewed, rolling out r240209.
3562
3563         Broke GTK/WPE injected bundle
3564
3565         Reverted changeset:
3566
3567         "AX: Support returning relative frames for accessibility"
3568         https://bugs.webkit.org/show_bug.cgi?id=193414
3569         https://trac.webkit.org/changeset/240209
3570
3571 2019-01-12  Dan Bernstein  <mitz@apple.com>
3572
3573         [Cocoa] Avoid importing directly from subumbrella frameworks
3574         https://bugs.webkit.org/show_bug.cgi?id=186016
3575         <rdar://problem/40591038>
3576
3577         Reviewed by Sam Weinig.
3578
3579         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3580           LaunchServices header.
3581         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3582           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3583         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3584           when using SDKs earlier than 10.13.
3585         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3586           and OTHER_CPLUSPLUSFLAGS.
3587         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3588           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3589         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3590           LaunchServices header.
3591
3592 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3593
3594         Cache bytecode to disk
3595         https://bugs.webkit.org/show_bug.cgi?id=192782
3596         <rdar://problem/46084932>
3597
3598         Reviewed by Keith Miller.
3599
3600         Add test helper to execute bytecode-cache tests: it executes each test
3601         twice, the first with JSC_diskCachePath set to a temporary directory
3602         and second with JSC_forceDiskCache=true (in addition to the cache path)
3603         to guarantee that only the disk cache is being used and no new
3604         UnlinkedCodeBlocks are being created.
3605
3606         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3607         * Scripts/run-jsc-stress-tests:
3608
3609 2019-01-20  chris fleizach  <cfleizach@apple.com>
3610
3611         AX: Support returning relative frames for accessibility
3612         https://bugs.webkit.org/show_bug.cgi?id=193414
3613         <rdar://problem/47268501>
3614
3615         Reviewed by Zalan Bujtas.
3616
3617         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3618         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3619         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3620         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3621         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3622         (WTR::attributesOfElement):
3623         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3624
3625 2019-01-20  Antoine Quint  <graouts@apple.com>
3626
3627         Add a POINTER_EVENTS feature flag
3628         https://bugs.webkit.org/show_bug.cgi?id=193577
3629         <rdar://problem/47408511>
3630
3631         Unreviewed. Also enable Pointer Events for iosmac.
3632
3633         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3634
3635 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3636
3637         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3638         https://bugs.webkit.org/show_bug.cgi?id=193613
3639
3640         Reviewed by Antti Koivisto.
3641
3642         * LayoutReloaded/misc/LFC-passing-tests.txt:
3643
3644 2019-01-19  Antoine Quint  <graouts@apple.com>
3645
3646         Add a POINTER_EVENTS feature flag
3647         https://bugs.webkit.org/show_bug.cgi?id=193577
3648
3649         Reviewed by Dean Jackson.
3650
3651         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3652
3653 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3654
3655         Disable the run-jsc-stress-test remote host key check [second round].
3656         https://bugs.webkit.org/show_bug.cgi?id=192988
3657
3658         Reviewed by Dewei Zhu.
3659
3660         * Scripts/run-jsc-stress-tests:
3661
3662 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3663
3664         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3665         https://bugs.webkit.org/show_bug.cgi?id=193597
3666
3667         Reviewed by Lucas Forschler.
3668
3669         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3670
3671 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3672
3673         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3674         https://bugs.webkit.org/show_bug.cgi?id=193595
3675
3676         Reviewed by Lucas Forschler.
3677
3678         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3679         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3680         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3681
3682 2019-01-18  Chris Dumez  <cdumez@apple.com>
3683
3684         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3685         https://bugs.webkit.org/show_bug.cgi?id=193588
3686         <rdar://problem/47131566>
3687
3688         Reviewed by Alex Christensen.
3689
3690         Add layout test coverage.
3691
3692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3693
3694 2019-01-18  Jer Noble  <jer.noble@apple.com>
3695
3696         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3697         https://bugs.webkit.org/show_bug.cgi?id=189553
3698
3699         Reviewed by Tim Horton.
3700
3701         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3702
3703         * ContentExtensionTester/Configurations/Base.xcconfig:
3704         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3705         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3706         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3707         * ImageDiff/cg/Configurations/Base.xcconfig:
3708         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3709         * MiniBrowser/Configurations/Base.xcconfig:
3710         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3711         * MobileMiniBrowser/Configurations/Base.xcconfig:
3712         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3713         * Scripts/webkitpy/style/checker.py:
3714         (_all_categories):
3715         (FileType):
3716         (CheckerDispatcher._file_type):
3717         (CheckerDispatcher._create_checker):
3718         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3719         (SDKVariantChecker):
3720         (SDKVariantChecker.__init__):
3721         (SDKVariantChecker.check):
3722         * TestWebKitAPI/Configurations/Base.xcconfig:
3723         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3724         * WebEditingTester/Configurations/Base.xcconfig:
3725         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3726         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3727         * WebKitTestRunner/Configurations/Base.xcconfig:
3728         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3729         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3730         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3731
3732 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3733
3734         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3735         <https://webkit.org/b/193568>
3736         <rdar://problem/47381130>
3737
3738         Reviewed by Alex Christensen.
3739
3740         Make sure no one re-introduces UIKit soft-linking by adding a
3741         style rule.
3742
3743         * Scripts/webkitpy/style/checkers/cpp.py:
3744         (check_language): Add softlink/uikit check.
3745         (CppChecker): Enable softlink/uikit check.
3746         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3747         (CppStyleTest): Add test for softlink/uikit.
3748
3749 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3750
3751         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3752         https://bugs.webkit.org/show_bug.cgi?id=193584
3753
3754         Change "-dev" to "-devel".
3755
3756         Reviewed by Michael Catanzaro.
3757
3758         * gtk/install-dependencies:
3759
3760 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3761
3762         webkitpy: Add iPhone and iPad ports
3763         https://bugs.webkit.org/show_bug.cgi?id=193537
3764         <rdar://problem/47353390>
3765
3766         Reviewed by Lucas Forschler.
3767
3768         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3769         ports. Note that this separation is optional, the --ios-simulator command remains.
3770
3771         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3772         (RunTest.test_device_type_test_division): Drive-by fix.
3773         (RunTest.test_device_type_specific_listing): Ditto.
3774         (RunTest.test_ipad_test_division):
3775         (RunTest):
3776         (RunTest.test_ipad_listing):
3777         * Scripts/webkitpy/port/factory.py:
3778         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3779         (PortFactory):
3780         * Scripts/webkitpy/port/ios_simulator.py:
3781         (IPhoneSimulatorPort):
3782         (IPadSimulatorPort):
3783
3784 2019-01-18  Chris Dumez  <cdumez@apple.com>
3785
3786         Regression(PSON) Scroll position is not always restored properly when navigating back
3787         https://bugs.webkit.org/show_bug.cgi?id=193578
3788         <rdar://problem/47386331>
3789
3790         Reviewed by Tim Horton.
3791
3792         Add API test coverage.
3793
3794         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3795
3796 2019-01-18  Youenn Fablet  <youenn@apple.com>
3797
3798         Add a new SPI to request for cache storage quota increase
3799         https://bugs.webkit.org/show_bug.cgi?id=193323
3800
3801         Reviewed by Alex Christensen.
3802
3803         Implement WebsiteDataStore quota delegate to handle quota requests.
3804         By default, do not update quota.
3805         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3806
3807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3809         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3810         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3811         * WebKitTestRunner/TestController.cpp:
3812         (WTR::TestController::allowCacheStorageQuotaIncrease):
3813         * WebKitTestRunner/TestController.h:
3814         * WebKitTestRunner/TestInvocation.cpp:
3815         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3816         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3817         (-[CacheStorageQuotaManager init]):
3818         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3819         (WTR::initializeWebViewConfiguration):
3820         (WTR::TestController::cocoaResetStateToConsistentValues):
3821         (WTR::TestController::allowCacheStorageQuotaIncrease):
3822
3823 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3824
3825         [ews-build] Pass owner to the triggered builds
3826         https://bugs.webkit.org/show_bug.cgi?id=193574
3827
3828         Reviewed by Lucas Forschler.
3829
3830         * BuildSlaveSupport/ews-build/factories.py:
3831         (BuildFactory.propertiesToPassToTriggers):
3832
3833 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3834
3835         [ews-app] Send patch author as a build property
3836         https://bugs.webkit.org/show_bug.cgi?id=193560
3837
3838         Reviewed by Lucas Forschler.
3839
3840         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3841         (BugzillaPatchFetcher.fetch):
3842
3843 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3844
3845         webkitpy: Implement device type specific expected results (Follow-up fix)
3846         https://bugs.webkit.org/show_bug.cgi?id=192162
3847         <rdar://problem/46345449>
3848
3849         Unreviewed infrastructure fix.
3850
3851         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3852         (Manager.run): Don't boot a device if no tests are available to run on it.
3853
3854 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3855
3856         webkitpy: Implement device type specific expected results (Follow-up fix)
3857         https://bugs.webkit.org/show_bug.cgi?id=192162
3858         <rdar://problem/46345449>
3859
3860         Unreviewed infrastructure fix.
3861
3862         * Scripts/webkitpy/api_tests/manager.py:
3863         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3864
3865 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3866
3867         webkitpy: Implement device type specific expected results (Part 2)
3868         https://bugs.webkit.org/show_bug.cgi?id=192162
3869         <rdar://problem/46345449>
3870
3871         Rubber-stamped by Aakash Jain.
3872
3873         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3874         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3875         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3876
3877         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3878         (LayoutTestFinder.find_tests): Pass device_type through.
3879         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3880         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3881         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3882         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3883         (Manager._collect_tests): Pass device type to test finder.
3884         (Manager._needs_web_platform_test):
3885         (Manager._prepare_lists): Index _expectations by device type.
3886         (Manager._test_input_for_file):
3887         (Manager._test_is_slow): Ditto.
3888         (Manager._test_should_dump_jsconsolelog_in_stderr):
3889         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3890         (Manager._get_test_inputs):
3891         (Manager._update_worker_count):
3892         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3893         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3894         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3895         the one which runs the test.
3896         (Manager._run_test_subset):
3897         (Manager._run_tests): Index _expectations by current_device_type.
3898         (Manager._print_expectation_line_for_test): Ditto.
3899         (Manager._print_expectations_for_subset): Ditto.
3900         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3901         Unlike run, this function will behave the same regardless of what devices are available.
3902         (Manager._custom_device_for_test): Deleted.
3903         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3904         (ManagerTest.test_uses_custom_device): Deleted.
3905         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3906         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3907         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3908         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3909         all of the expectations.
3910         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3911         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3912         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3913         (TestExpectations.__init__): Allow device_type to be passed through.
3914         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3915         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3916         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3917         (summarize_results):
3918         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3919         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3920         a test ran with, one must check all expectations to find the first non-skip expectation.
3921         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3922         (RunTest.test_device_type_test_division):
3923         (RunTest):
3924         (RunTest.test_device_type_specific_listing):
3925         * Scripts/webkitpy/port/base.py:
3926         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3927         (Port.supported_device_types): The result of this function will change based on what devices are available.
3928         * Scripts/webkitpy/port/device_port.py:
3929         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3930         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3931         can be used.
3932         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3933         any, or the DEFAULT_DEVICE_TYPES of the port.
3934         * Scripts/webkitpy/port/ios.py:
3935         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3936         * Scripts/webkitpy/port/ios_simulator.py:
3937         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3938         * Scripts/webkitpy/port/watch.py:
3939         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3940         * Scripts/webkitpy/port/watch_simulator.py:
3941         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3942         * Scripts/webkitpy/xcode/device_type.py:
3943         (DeviceType):
3944         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3945
3946 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3947
3948         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3949         https://bugs.webkit.org/show_bug.cgi?id=193575
3950
3951         Reviewed by Michael Catanzaro.
3952
3953         Allow the script to run without explicit port argument because
3954         it's specific to the WPE port anyway.
3955
3956         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3957         and simplify the rest of the code accordingly.
3958
3959 2019-01-18  Charlie Turner  <cturner@igalia.com>
3960
3961         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3962         https://bugs.webkit.org/show_bug.cgi?id=192229
3963
3964         Reviewed by Xabier Rodriguez-Calvar.
3965
3966         * MiniBrowser/wpe/main.cpp:
3967         (main): Enable encrypted-media by default.
3968
3969 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3970
3971         [Flatpak] Missing KeyboardInterrupt exception handler
3972         https://bugs.webkit.org/show_bug.cgi?id=193570
3973
3974         Reviewed by Michael Catanzaro.
3975
3976         * flatpak/flatpakutils.py:
3977         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3978
3979 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3980
3981         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3982         https://bugs.webkit.org/show_bug.cgi?id=193564
3983
3984         Reviewed by Antti Koivisto.
3985
3986         * LayoutReloaded/misc/LFC-passing-tests.txt:
3987
3988 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3989
3990         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3991         https://bugs.webkit.org/show_bug.cgi?id=193562
3992
3993         Reviewed by Antti Koivisto.
3994
3995         * LayoutReloaded/misc/LFC-passing-tests.txt:
3996
3997 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3998
3999         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
4000         https://bugs.webkit.org/show_bug.cgi?id=193555
4001
4002         Reviewed by Antti Koivisto.
4003
4004         * LayoutReloaded/misc/LFC-passing-tests.txt:
4005
4006 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4007
4008         [WPE] Add Qt extension
4009         https://bugs.webkit.org/show_bug.cgi?id=191464
4010
4011         Reviewed by Carlos Garcia Campos.
4012
4013         MiniBrowser and API tests for the WPE Qt API. To run the
4014         MiniBrowser a new script is introduced. Example invocation:
4015
4016         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
4017
4018         Also note-worthy is the introduction of the python2-subprocess32
4019         dependency to run the GLib API tests.
4020
4021         * MiniBrowser/wpe/CMakeLists.txt:
4022         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
4023         * MiniBrowser/wpe/qt/main.cpp: Added.
4024         (main):
4025         * MiniBrowser/wpe/qt/main.qml: Added.
4026         * MiniBrowser/wpe/qt/qml.qrc: Added.
4027         * Scripts/run-gtk-tests:
4028         (GtkTestRunner.is_google_test):
4029         (GtkTestRunner):
4030         (GtkTestRunner.is_qt_test):
4031         * Scripts/run-qt-wpe-minibrowser: Added.
4032         * Scripts/run-wpe-tests:
4033         (WPETestRunner):
4034         (WPETestRunner.is_google_test):
4035         (WPETestRunner.is_qt_test):
4036         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
4037         (TestLoad::main):
4038         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
4039         (TestLoadHtml::main):
4040         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
4041         (TestLoadRequest::main):
4042         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
4043         (TestRunJavaScript::main):
4044         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
4045         (waitForSignal):
4046         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
4047         (LoadSpy::LoadSpy):
4048         (LoadSpy::~LoadSpy):
4049         (LoadSpy::onLoadingChanged):
4050         (LoadStartedCatcher::LoadStartedCatcher):
4051         (LoadStartedCatcher::~LoadStartedCatcher):
4052         (LoadStartedCatcher::onLoadingChanged):
4053         (waitForLoadSucceeded):
4054         (waitForLoadFailed):
4055         * TestWebKitAPI/glib/CMakeLists.txt:
4056         * flatpak/flatpakutils.py:
4057         (WebkitFlatpak.load_from_args):
4058         (WebkitFlatpak.__init__):
4059         (WebkitFlatpak.clean_args):
4060         (WebkitFlatpak.run_in_sandbox):
4061         * flatpak/org.webkit.CommonModules.yaml:
4062         * flatpak/org.webkit.WPE.yaml:
4063         * flatpak/org.webkit.WPEModules.yaml:
4064         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
4065         * flatpak/org.webkit.WebKit.yaml:
4066         * glib/api_test_runner.py:
4067         (TestRunner._run_test_qt):
4068         (TestRunner.is_qt_test):
4069         (TestRunner._run_test):
4070
4071 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4072
4073         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
4074         https://bugs.webkit.org/show_bug.cgi?id=193494
4075         <rdar://problem/46859627>
4076
4077         Reviewed by Simon Fraser and Tim Horton.
4078
4079         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
4080         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
4081
4082         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4083         (WTR::UIScriptController::contentOffsetX const):
4084         (WTR::UIScriptController::contentOffsetY const):
4085         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4086         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4087         (WTR::UIScriptController::contentOffsetX const):
4088         (WTR::UIScriptController::contentOffsetY const):
4089         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4090
4091         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
4092
4093         * WebKitTestRunner/TestController.cpp:
4094         (WTR::updateTestOptionsFromTestHeader):
4095         * WebKitTestRunner/TestOptions.h:
4096         (WTR::TestOptions::hasSameInitializationOptions const):
4097         * WebKitTestRunner/ios/TestControllerIOS.mm:
4098         (WTR::TestController::platformResetStateToConsistentValues):
4099         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4100         (WTR::UIScriptController::contentOffsetX const):
4101         (WTR::UIScriptController::contentOffsetY const):
4102
4103 2019-01-17  Truitt Savell  <tsavell@apple.com>
4104
4105         Unreviewed, rolling out r240124.
4106
4107         This commit broke an internal build.
4108
4109         Reverted changeset:
4110
4111         "SDK_VARIANT build destinations should be separate from non-
4112         SDK_VARIANT builds"
4113         https://bugs.webkit.org/show_bug.cgi?id=189553
4114         https://trac.webkit.org/changeset/240124
4115
4116 2019-01-17  Alex Christensen  <achristensen@webkit.org>
4117
4118         Fix string concatenation API test after r239920
4119         https://bugs.webkit.org/show_bug.cgi?id=193551
4120         <rdar://problem/47359304>
4121
4122         Reviewed by Youenn Fablet.
4123
4124         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4125         (TestWebKitAPI::TEST):
4126         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
4127         in WebKit's build configuration like it apparently is on Linux.
4128
4129 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4130
4131         [ews-build] validate-patch should handle the case when bug_id is None
4132         https://bugs.webkit.org/show_bug.cgi?id=193547
4133
4134         Reviewed by Lucas Forschler.
4135
4136         * BuildSlaveSupport/ews-build/steps.py:
4137         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
4138         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
4139
4140 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4141
4142         [ews-build] Add patch author information in build
4143         https://bugs.webkit.org/show_bug.cgi?id=193465
4144
4145         Reviewed by Lucas Forschler.
4146
4147         * BuildSlaveSupport/ews-build/steps.py:
4148         (ValidatePatch._is_patch_obsolete):
4149
4150 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4151
4152         [ews-build] Pass bug_id to the triggered builds
4153         https://bugs.webkit.org/show_bug.cgi?id=193548
4154
4155         Reviewed by Lucas Forschler.
4156
4157         * BuildSlaveSupport/ews-build/factories.py:
4158         (BuildFactory.propertiesToPassToTriggers):
4159
4160 2019-01-17  Jer Noble  <jer.noble@apple.com>
4161
4162         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4163         https://bugs.webkit.org/show_bug.cgi?id=189553
4164
4165         Reviewed by Tim Horton.
4166
4167         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4168
4169         * ContentExtensionTester/Configurations/Base.xcconfig:
4170         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4171         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4172         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4173         * ImageDiff/cg/Configurations/Base.xcconfig:
4174         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4175         * MiniBrowser/Configurations/Base.xcconfig:
4176         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4177         * MobileMiniBrowser/Configurations/Base.xcconfig:
4178         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4179         * Scripts/webkitpy/style/checker.py:
4180         (_all_categories):
4181         (FileType):
4182         (CheckerDispatcher._file_type):
4183         (CheckerDispatcher._create_checker):
4184         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4185         (SDKVariantChecker):
4186         (SDKVariantChecker.__init__):
4187         (SDKVariantChecker.check):
4188         * TestWebKitAPI/Configurations/Base.xcconfig:
4189         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4190         * WebEditingTester/Configurations/Base.xcconfig:
4191         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4192         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4193         * WebKitTestRunner/Configurations/Base.xcconfig:
4194         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4195         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4196         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4197
4198 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4199
4200         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4201         https://bugs.webkit.org/show_bug.cgi?id=193534
4202
4203         Reviewed by Antti Koivisto.
4204
4205         * LayoutReloaded/misc/LFC-passing-tests.txt:
4206
4207 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4208
4209         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4210         https://bugs.webkit.org/show_bug.cgi?id=193528
4211
4212         Reviewed by Antti Koivisto.
4213
4214         * LayoutReloaded/misc/LFC-passing-tests.txt:
4215
4216 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4217
4218         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4219         https://bugs.webkit.org/show_bug.cgi?id=193520
4220
4221         Reviewed by Antti Koivisto.
4222
4223         * LayoutReloaded/misc/LFC-passing-tests.txt:
4224
4225 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4226
4227         [ews-build] unapply-patch step should not update source
4228         https://bugs.webkit.org/show_bug.cgi?id=193234
4229
4230         Reviewed by Lucas Forschler.
4231
4232         * BuildSlaveSupport/ews-build/steps.py:
4233         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4234         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4235
4236 2019-01-16  Youenn Fablet  <youenn@apple.com>
4237
4238         Add a new SPI for controlling getUserMedia
4239         https://bugs.webkit.org/show_bug.cgi?id=192793
4240
4241         Reviewed by Eric Carlson.
4242
4243         * MiniBrowser/mac/WK2BrowserWindowController.m:
4244         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4245         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4246         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4247         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4248         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4249         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4250         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4251         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4252         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4253         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4254         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4255         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4256         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4257         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4258
4259 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4260
4261         [LFC][BFC] Inflow non-replaced used width should not be negative.
4262         https://bugs.webkit.org/show_bug.cgi?id=193495
4263
4264         Reviewed by Antti Koivisto.
4265
4266         * LayoutReloaded/misc/LFC-passing-tests.txt:
4267
4268 2019-01-16  Chris Dumez  <cdumez@apple.com>
4269
4270         Regression(PSON) View becomes blank after click a cross-site download link
4271         https://bugs.webkit.org/show_bug.cgi?id=193361
4272         <rdar://problem/47099573>
4273
4274         Reviewed by Geoffrey Garen.
4275
4276         Add API test coverage.
4277
4278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4279         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4280
4281 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4282
4283         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4284         https://bugs.webkit.org/show_bug.cgi?id=193470
4285
4286         Reviewed by Antti Koivisto.
4287
4288         * LayoutReloaded/misc/LFC-passing-tests.txt:
4289
4290 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4291
4292         [LFC] Adjust margin box verification.
4293         https://bugs.webkit.org/show_bug.cgi?id=193482
4294
4295         Reviewed by Antti Koivisto.
4296
4297         * LayoutReloaded/misc/LFC-passing-tests.txt:
4298
4299 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4300
4301         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4302         https://bugs.webkit.org/show_bug.cgi?id=193451
4303
4304         Reviewed by Geoffrey Garen.
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4307         (TEST):
4308         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4309         (runWebsiteDataStoreCustomPaths):
4310
4311 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4312
4313         webkitpy: Support boolean simctl isAvailable
4314         https://bugs.webkit.org/show_bug.cgi?id=193472
4315         <rdar://problem/47296150>
4316
4317         Reviewed by Ryosuke Niwa.
4318
4319         * Scripts/webkitpy/xcode/simulated_device.py:
4320         (SimulatedDeviceManager._create_runtimes):
4321         (SimulatedDeviceManager._create_device_with_runtime):
4322
4323 2019-01-15  Chris Dumez  <cdumez@apple.com>
4324
4325         Unreviewed, rolling out r239993, r239995, r239997, and
4326         r239999.
4327
4328         Caused assertions under
4329         ViewGestureController::disconnectFromProcess()
4330
4331         Reverted changesets:
4332
4333         "Regression(PSON) View becomes blank after click a cross-site
4334         download link"
4335         https://bugs.webkit.org/show_bug.cgi?id=193361
4336         https://trac.webkit.org/changeset/239993
4337
4338         "Unreviewed iOS build fix after r239993."
4339         https://trac.webkit.org/changeset/239995
4340
4341         "Fix iOS build after r239993"
4342         https://bugs.webkit.org/show_bug.cgi?id=193361