Resource Load Statistics: Make it possible to purge only script-accessible cookies
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-07  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4         https://bugs.webkit.org/show_bug.cgi?id=195383
5         <rdar://problem/48570136>
6
7         Reviewed by Brent Fulgham.
8
9         This patch adds test infrastructure to purge only script-accessible cookies,
10         including a new testRunner function called statisticsDeleteCookiesForHost().git a
11
12         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
13         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
14         (WTR::TestRunner::statisticsDeleteCookiesForHost):
15         * WebKitTestRunner/InjectedBundle/TestRunner.h:
16         * WebKitTestRunner/TestController.cpp:
17         (WTR::TestController::statisticsDeleteCookiesForHost):
18         * WebKitTestRunner/TestController.h:
19         * WebKitTestRunner/TestInvocation.cpp:
20         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
21
22 2019-03-07  Commit Queue  <commit-queue@webkit.org>
23
24         Unreviewed, rolling out r242354.
25         https://bugs.webkit.org/show_bug.cgi?id=195402
26
27         breaks layout tests in all configurations (Requested by
28         zdobersek on #webkit).
29
30         Reverted changeset:
31
32         "[WPE] Enable web process sandbox"
33         https://bugs.webkit.org/show_bug.cgi?id=195169
34         https://trac.webkit.org/changeset/242354
35
36 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
37
38         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
39         https://bugs.webkit.org/show_bug.cgi?id=195346
40
41         Reviewed by Fujii Hironori.
42
43         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
44         (TestWebKitAPI::TEST):
45         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
46
47         * DumpRenderTree/win/DumpRenderTree.cpp:
48         (findFontFallback):
49         (addFontFallbackIfPresent):
50         (removeFontFallbackIfPresent):
51         (main):
52         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
53         (TestWebKitAPI::Util::moduleDirectory):
54         (TestWebKitAPI::Util::createInjectedBundlePath):
55         Use wchar helpers as needed.
56
57 2019-03-06  Rob Buis  <rbuis@igalia.com>
58
59         Consider supporting the `referrerpolicy` attribute.
60         https://bugs.webkit.org/show_bug.cgi?id=179053
61
62         Reviewed by Darin Adler.
63
64         Add a runtime flag for referrerpolicy attribute.
65
66         * DumpRenderTree/mac/DumpRenderTree.mm:
67         (enableExperimentalFeatures):
68
69 2019-03-05  Daniel Bates  <dabates@apple.com>
70
71         Update expected API test result following r242379
72         (https://bugs.webkit.org/show_bug.cgi?id=195125)
73
74         Update expected x-coordinate of selection rect now that the left padding of
75         a textarea is sized in ems (so dependent on the font size) just like the left
76         padding of a text field.
77
78         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
79         (TestWebKitAPI::TEST):
80
81 2019-03-05  David Quesada  <david_quesada@apple.com>
82
83         [WK2] It should be possible to follow links with 'download' attributes
84         https://bugs.webkit.org/show_bug.cgi?id=195145
85         rdar://problem/48462642
86
87         Reviewed by Alex Christensen.
88
89         Add a unit test to verify that activating links with 'download' attributes now
90         navigates to the linked resource, rather than starts downloading it. Add another
91         to verify that it is still possible to explicitly download the link via the
92         'Download' navigation action policy.
93
94         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
95         (-[DownloadAttributeTestDelegate init]):
96         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
97         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
98         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
99         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
100         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
101         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
102         (TEST):
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::TestController::decidePolicyForNavigationAction):
105         * WebKitTestRunner/TestController.h:
106
107 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
108
109         [Curl] Implement Cookie Accept Policy.
110         https://bugs.webkit.org/show_bug.cgi?id=191645
111
112         Reviewed by Fujii Hironori.
113
114         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
115         (TestWebKitAPI::Curl::TEST_F):
116
117 2019-03-05  Youenn Fablet  <youenn@apple.com>
118
119         Rename requestCacheStorageSpace to requestStorageSpace
120         https://bugs.webkit.org/show_bug.cgi?id=195282
121
122         Reviewed by Chris Dumez.
123
124         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
125         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
126         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
127
128 2019-03-05  Brady Eidson  <beidson@apple.com>
129
130         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
131         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
132
133         Reviewed by Tim Horton.
134
135         Loading a file: URL into a WKWebView and then loading another file: url from a completely
136         different directory into that same WKWebView should work.
137
138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
139         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
140
141 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
142
143         Add WeakHashSet
144         https://bugs.webkit.org/show_bug.cgi?id=195152
145
146         Reviewed by Antti Koivisto.
147
148         Added tests for WeakHashSet.
149
150         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
151         (TestWebKitAPI::Base::Base): Moved.
152         (TestWebKitAPI::Derived::foo): Moved.
153         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
154         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
155         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
156         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
157
158 2019-03-04  Chris Dumez  <cdumez@apple.com>
159
160         Do not share WebProcesses between private and regular sessions
161         https://bugs.webkit.org/show_bug.cgi?id=195189
162         <rdar://problem/48421064>
163
164         Reviewed by Alex Christensen.
165
166         Add API test coverage.
167
168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
169         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
170
171 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
172
173         [WPE] Enable web process sandbox
174         https://bugs.webkit.org/show_bug.cgi?id=195169
175
176         Reviewed by Daniel Bates.
177
178         * wpe/install-dependencies:
179         * wpe/jhbuild.modules:
180
181 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
182
183         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
184         https://bugs.webkit.org/show_bug.cgi?id=195206
185
186         Reviewed by Žan Doberšek.
187
188         Add a new test case.
189
190         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
191         (testJSCClass):
192
193 2019-03-04  Charlie Turner  <cturner@igalia.com>
194
195         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
196         https://bugs.webkit.org/show_bug.cgi?id=194898
197
198         Reviewed by Žan Doberšek.
199
200         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
201         a GCC extension that permits arithmetic on void* pointer. Inline
202         the macro until this issue is fixed upstream.
203
204 2019-03-03  Tim Horton  <timothy_horton@apple.com>
205
206         Rid the world of WK_API_ENABLED
207         https://bugs.webkit.org/show_bug.cgi?id=195263
208
209         Reviewed by Dan Bernstein.
210
211         List of changed files elided because it's useless.
212
213 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
214
215         Unreviewed follow-up to r242292.
216
217         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
218
219         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
220         (TestWebKitAPI::testStrip): Renamed from strip.
221         (TestWebKitAPI::TEST):
222
223 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
224
225         Unreviewed, remove accidentally-committed URLHelpers.cpp test
226
227         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
228         and bug #194272 for details.
229
230         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
231
232 2019-03-03  Tim Horton  <timothy_horton@apple.com>
233
234         Remove some more unused 32-bit code
235         https://bugs.webkit.org/show_bug.cgi?id=195255
236
237         Reviewed by Darin Adler.
238
239         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
240         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
241         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
242         (NPP_New):
243         (NPP_HandleEvent):
244         (handleEventCarbon): Deleted.
245
246 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
247
248         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
249
250         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
251         (TestWebKitAPI::TEST):
252
253 2019-03-01  Darin Adler  <darin@apple.com>
254
255         Finish removing String::format
256         https://bugs.webkit.org/show_bug.cgi?id=194893
257
258         Reviewed by Daniel Bates.
259 '
260         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
261
262 2019-03-01  Alex Christensen  <achristensen@webkit.org>
263
264         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
265         https://bugs.webkit.org/show_bug.cgi?id=195229
266         <rdar://problem/48520362>
267
268         Reviewed by Chris Dumez.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
271         (TEST):
272
273 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
274
275         Add a system trace scope for event region building
276         https://bugs.webkit.org/show_bug.cgi?id=195226
277
278         Reviewed by Jon Lee.
279
280         This trace scope measures the time spend converting element rects into Region objects,
281         which can be large on some pages.
282
283         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
284
285         * Tracing/SystemTracePoints.plist:
286
287 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
288
289         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
290         https://bugs.webkit.org/show_bug.cgi?id=194612
291
292         Reviewed by Alex Christensen.
293
294         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
295         Just test the new string-processing function and don't touch the actual environment.
296         (Test cases are all as before, but based on operator== instead of strcmp.)
297
298 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
299
300         [ews-app] Update primary keys for handling multiple Buildbot instances
301         https://bugs.webkit.org/show_bug.cgi?id=195120
302
303         Reviewed by Stephanie Lewis.
304
305         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
306         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
307         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
308
309         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
310         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
311         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
312         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
313         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
314         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
315
316 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
317
318         [WinCairo] Enable service worker
319         https://bugs.webkit.org/show_bug.cgi?id=188318
320
321         Reviewed by Youenn Fablet.
322
323         * DumpRenderTree/DumpRenderTreePrefix.h:
324         * TestWebKitAPI/PlatformWin.cmake:
325         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
326         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
327         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
328
329 2019-03-01  Justin Fan  <justin_fan@apple.com>
330
331         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
332         https://bugs.webkit.org/show_bug.cgi?id=195191
333
334         Rubber-stamped by Dean Jackson.
335
336         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
337
338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
339
340 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
341
342         Unreviewed, fix lldb webkitpy tests
343         https://bugs.webkit.org/show_bug.cgi?id=194375
344
345         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
346
347         * lldb/lldb_webkit.py:
348         (WTFStringImplProvider.is_8bit):
349
350 2019-02-28  David Quesada  <david_quesada@apple.com>
351
352         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
353         https://bugs.webkit.org/show_bug.cgi?id=195121
354         rdar://problem/48450302
355
356         Reviewed by Alex Christensen.
357
358         Add API tests for -WKNavigationAction._shouldPerformDownload in various
359         configurations where the 'download' attribute is absent, blank, or populated
360         with a filename, and where the anchor element is same-origin or cross-origin
361         (meaning the 'download' attribute shouldn't be honored).
362
363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
364         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
365         (-[NavigationActionTestDelegate init]):
366         (-[NavigationActionTestDelegate navigationAction]):
367         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
368         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
369         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
370         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
371         (TEST):
372
373 2019-02-28  Antoine Quint  <graouts@apple.com>
374
375         Enable the Pointer Events runtime flag by default
376         https://bugs.webkit.org/show_bug.cgi?id=195156
377
378         Reviewed by Dean Jackson.
379
380         * DumpRenderTree/mac/DumpRenderTree.mm:
381         (enableExperimentalFeatures):
382
383 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
384
385         Several PasteImage API tests are flaky
386         https://bugs.webkit.org/show_bug.cgi?id=195160
387
388         Reviewed by Tim Horton.
389
390         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
391         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
392         listening for a "load" event after image load is already complete.
393
394         To address this, make these tests first register a "load" event handler, then run script to insert an image
395         element into the document, and finally wait until the load event is observed before checking image size.
396
397         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
398
399 2019-02-28  Chris Dumez  <cdumez@apple.com>
400
401         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
402         https://bugs.webkit.org/show_bug.cgi?id=195107
403
404         Reviewed by Alex Christensen.
405
406         Give some time for the zoom level to get restored.
407
408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
409
410 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
411
412         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
413         https://bugs.webkit.org/show_bug.cgi?id=194958
414
415         Reviewed by Geoffrey Garen.
416
417         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
418         (TEST):
419
420 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
421
422         [ews-app] Update method to save build to handle builder_display_name
423         https://bugs.webkit.org/show_bug.cgi?id=195047
424
425         Reviewed by Dewei Zhu.
426
427         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
428         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
429
430 2019-02-28  Justin Fan  <justin_fan@apple.com>
431
432         [Web GPU] Enable Web GPU only on 64-bit
433         https://bugs.webkit.org/show_bug.cgi?id=195139
434
435         Because Metal is only supported on 64 bit apps.
436
437         Unreviewed build fix.
438
439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
440
441 2019-02-27  Youenn Fablet  <youenn@apple.com>
442
443         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
444         https://bugs.webkit.org/show_bug.cgi?id=194959
445
446         Reviewed by Chris Dumez.
447
448         Spin loop until getting the condition to remove flakiness.
449
450         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
451
452 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
453
454         [ews-build] Buildbot should include builder_display_name in the build events
455         https://bugs.webkit.org/show_bug.cgi?id=195045
456
457         Reviewed by Dewei Zhu.
458
459         * BuildSlaveSupport/ews-build/events.py:
460         (Events.buildStarted): Included builder_display_name in event data. Also renamed
461         buildername to builder_name to be consistent in naming style.
462         (Events.buildFinished): Ditto.
463
464 2019-02-27  Chris Dumez  <cdumez@apple.com>
465
466         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
467         https://bugs.webkit.org/show_bug.cgi?id=194480
468
469         Reviewed by Brady Eidson.
470
471         Update existing API test to make it more likely to reproduce the issue.
472
473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
474
475 2019-02-27  Brady Eidson  <beidson@apple.com>
476
477         Universal links from Google search results pages don't open the app.
478         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
479
480         Reviewed by Geoffrey Garen.
481
482         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
483         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
484         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
485         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
486
487 2019-02-27  Chris Dumez  <cdumez@apple.com>
488
489         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
490         https://bugs.webkit.org/show_bug.cgi?id=195102
491
492         Reviewed by Geoffrey Garen.
493
494         If the number of processes is not yet what we expect, wait a bit and check again to give
495         processes some time to exit.
496
497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
498
499 2019-02-27  Chris Dumez  <cdumez@apple.com>
500
501         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
502         https://bugs.webkit.org/show_bug.cgi?id=194545
503
504         Reviewed by Brady Eidson.
505
506         Make sure the test navigates forward and then back only once. Previously, navigating
507         back would trigger a navigation again in a timer.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
510
511 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
512
513         High Sierra Debug JSC test queue should use faster hardware
514         https://bugs.webkit.org/show_bug.cgi?id=194603
515
516         Rubber-stamped by Alexey Proskuryakov.
517
518         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
519
520         * BuildSlaveSupport/build.webkit.org-config/config.json:
521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
522         (BubbleQueueServer):
523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
524         (WebKitBuildbot):
525         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
526         * QueueStatusServer/config/queues.py:
527         * Scripts/webkitpy/common/config/ews.json:
528         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
529         (test_ews_name):
530
531 2019-02-27  John Wilander  <wilander@apple.com>
532
533         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
534         https://bugs.webkit.org/show_bug.cgi?id=195071
535         <rdar://problem/48417690>
536
537         Reviewed by Alex Christensen and Brent Fulgham.
538
539         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
540         (TestWebKitAPI::createURL):
541             Convenience function.
542         (TestWebKitAPI::TEST):
543             WebCore::AdClickAttribution now takes a URL when creating Source and
544             Destination.
545         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
546         (TestWebKitAPI::TEST):
547             WebCore::AdClickAttribution now takes a URL when creating Source and
548             Destination.
549
550 2019-02-27  Antoine Quint  <graouts@apple.com>
551
552         Support Pointer Events on macOS
553         https://bugs.webkit.org/show_bug.cgi?id=195008
554         <rdar://problem/47454419>
555
556         Reviewed by Dean Jackson.
557
558         * DumpRenderTree/mac/DumpRenderTree.mm:
559         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
560         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
561
562 2019-02-26  Mark Lam  <mark.lam@apple.com>
563
564         Remove remaining poisoning code.
565         https://bugs.webkit.org/show_bug.cgi?id=194138
566
567         Reviewed by Saam Barati.
568
569         * TestWebKitAPI/CMakeLists.txt:
570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
571         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
572         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
573         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
574         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
575         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
576         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
577
578 2019-02-26  Alex Christensen  <achristensen@webkit.org>
579
580         Move ephemeral local storage from WebProcess to UIProcess
581         https://bugs.webkit.org/show_bug.cgi?id=195074
582         <rdar://problem/47937975>
583
584         Reviewed by Geoff Garen.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
587
588 2019-02-20  Jer Noble  <jer.noble@apple.com>
589
590         [Cocoa] Media elements will restart network buffering just before suspending
591         https://bugs.webkit.org/show_bug.cgi?id=193691
592
593         Reviewed by Eric Carlson.
594
595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
597         (TEST):
598
599 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
600
601         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
602         https://bugs.webkit.org/show_bug.cgi?id=191652
603
604         Reviewed by Alex Christensen.
605
606         Fix WinCairo MiniBrowser behavior of authentication dialog.
607
608         * MiniBrowser/win/WebKitBrowserWindow.cpp:
609         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
610
611 2019-02-26  Youenn Fablet  <youenn@apple.com>
612
613         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
614         https://bugs.webkit.org/show_bug.cgi?id=195028
615         <rdar://problem/48243733>
616
617         Reviewed by Eric Carlson.
618
619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
620
621 2019-02-26  Philippe Normand  <pnormand@igalia.com>
622
623         [WPE] Add API for webview background color configuration
624         https://bugs.webkit.org/show_bug.cgi?id=192305
625
626         Reviewed by Michael Catanzaro.
627
628         * MiniBrowser/wpe/main.cpp:
629         (main): Add a new option to configure the webview background
630         color. Example: --bg-color=transparent.
631         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
632         (testWebViewBackgroundColor): Enable background color API tests for WPE.
633         (beforeAll): Ditto.
634
635 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
636
637         scalableNativeWebpageParameters() is not preserved on new page navigation.
638         https://bugs.webkit.org/show_bug.cgi?id=194892
639         <rdar://problem/47538280>
640
641         Reviewed by Wenson Hsieh.
642         
643         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
644
645         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
646         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
647         * DumpRenderTree/mac/UIScriptControllerMac.mm:
648         (WTR::UIScriptController::allowsViewportShrinkToFit):
649         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
650         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
651         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
652         * TestRunnerShared/UIScriptContext/UIScriptController.h:
653         * WebKitTestRunner/UIScriptControllerCocoa.mm:
654         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
655
656 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews-app] Add model for handling multiple Buildbot instances
659         https://bugs.webkit.org/show_bug.cgi?id=194863
660
661         Reviewed by Stephanie Lewis.
662
663         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
664
665 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
666
667         [ews-app] Remove BuilderMapping table
668         https://bugs.webkit.org/show_bug.cgi?id=194961
669
670         Reviewed by Stephanie Lewis.
671
672         Store builder name directly in build table, instead of having a separate
673         table for it.
674
675         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
676         * BuildSlaveSupport/ews-app/ews/models/build.py:
677         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
678         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
679
680 2019-02-25  John Wilander  <wilander@apple.com>
681
682         Introduce and adopt new class RegistrableDomain for eTLD+1
683         https://bugs.webkit.org/show_bug.cgi?id=194791
684         <rdar://problem/48179240>
685
686         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
687
688         This patch adds an API test and replaces two instances of
689         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
690
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
693         (TestWebKitAPI::TEST):
694             Changed two strings to make sure the registrable domains are still considered
695             invalid and pass the test.
696         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
697         (TestWebKitAPI::TEST):
698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
699         (WTR::InjectedBundle::didReceiveMessageToPage):
700
701 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
702
703         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
704         https://bugs.webkit.org/show_bug.cgi?id=195001
705
706         Reviewed by Carlos Garcia Campos.
707
708         API version 1.0 always includes the functionality previously guarded with
709         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
710         unconditionally.
711
712         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
713         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
714         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
715         (WebViewTest::showInWindow): Ditto.
716         (WebViewTest::hideView): Ditto.
717         * wpe/backends/HeadlessViewBackend.cpp:
718         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
719         * wpe/backends/ViewBackend.cpp:
720         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
721         * wpe/backends/WindowViewBackend.cpp:
722         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
723         WPE_BACKEND_CHECK_VERSION().
724         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
725
726 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
727
728         [Flatpak] Add support for flatpak > 1.1.2
729         https://bugs.webkit.org/show_bug.cgi?id=194088
730
731         Flatpak 1.2 is now out so we need to support that
732         version now.
733
734         Reviewed by Michael Catanzaro.
735
736         * flatpak/flatpakutils.py:
737         (check_flatpak):
738         (FlatpakPackages.__init__):
739         (FlatpakPackages.__detect_packages):
740         (FlatpakPackages.__detect_packages.in):
741         (FlatpakRepos.update):
742
743 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
744
745         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
746         https://bugs.webkit.org/show_bug.cgi?id=194998
747
748         Reviewed by Carlos Garcia Campos.
749
750         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
751         to a Git checkout and using the latest commit containing various fixes
752         and improvements.
753
754 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
755
756         [WPE][GTK] Remove user agent quirk for washingtonpost.com
757         https://bugs.webkit.org/show_bug.cgi?id=194981
758
759         Reviewed by Žan Doberšek.
760
761         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
762         (TestWebKitAPI::TEST):
763
764 2019-02-23  Keith Miller  <keith_miller@apple.com>
765
766         Add new mac target numbers
767         https://bugs.webkit.org/show_bug.cgi?id=194955
768
769         Reviewed by Tim Horton.
770
771         * DumpRenderTree/mac/Configurations/Base.xcconfig:
772         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
773         * MiniBrowser/Configurations/Base.xcconfig:
774         * TestWebKitAPI/Configurations/Base.xcconfig:
775         * WebKitTestRunner/Configurations/Base.xcconfig:
776
777 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
778
779         [WinCairo] Enable wk1/wk2 suffix for platform search path.
780         https://bugs.webkit.org/show_bug.cgi?id=194846
781
782         Reviewed by Don Olmstead.
783
784         Added _search_paths() and _port_specific_expectations_files() for
785         WinCairoPort.
786
787         * Scripts/webkitpy/port/win.py:
788         (WinCairoPort.default_baseline_search_path):
789         (WinCairoPort):
790         (WinCairoPort._port_specific_expectations_files):
791         (WinCairoPort._search_paths):
792
793 2019-02-22  Tim Horton  <timothy_horton@apple.com>
794
795         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
796         https://bugs.webkit.org/show_bug.cgi?id=194963
797
798         Reviewed by Dean Jackson.
799
800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
801         Do a `contains` check instead of `equals`, because in debug builds we
802         put the GraphicsLayer pointer in a prefix.
803
804 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
805
806         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
807         https://bugs.webkit.org/show_bug.cgi?id=194873
808         <rdar://problem/46701974>
809
810         Reviewed by Tim Horton.
811
812         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
813
814         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
815         (WTR::UIScriptController::menuRect const):
816         (WTR::UIScriptController::isShowingMenu const):
817         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
818         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
819         (WTR::UIScriptController::menuRect const):
820
821         Add a function to query the bounds of the callout menu in content coordinates.
822
823         (WTR::UIScriptController::isShowingMenu const):
824
825         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
826
827         * TestRunnerShared/UIScriptContext/UIScriptController.h:
828         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
829         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
830         (WTR::UIScriptController::rectForMenuAction const):
831         (WTR::UIScriptController::menuRect const):
832         (WTR::UIScriptController::isShowingMenu const):
833         (WTR::findViewInHierarchyOfType): Deleted.
834
835 2019-02-22  Chris Dumez  <cdumez@apple.com>
836
837         Regression(PSON) Unable to preview password-protected documents on iCloud.com
838         https://bugs.webkit.org/show_bug.cgi?id=194954
839         <rdar://problem/48127957>
840
841         Reviewed by Alex Christensen.
842
843         Add API test coverage.
844
845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
846         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
847         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
848         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
849
850 2019-02-22  Chris Dumez  <cdumez@apple.com>
851
852         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
853         https://bugs.webkit.org/show_bug.cgi?id=194924
854         <rdar://problem/48216125>
855
856         Reviewed by Geoffrey Garen.
857
858         Add API test coverage.
859
860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
861
862 2019-02-22  Chris Dumez  <cdumez@apple.com>
863
864         Unreviewed, disable API test added in r241928 on iOS.
865
866         The cache is not enabled on devices with less than 3GB of RAM.
867
868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
869
870 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
871
872         Hardcode Visual Viewports on everywhere except iOS WK1
873         https://bugs.webkit.org/show_bug.cgi?id=194928
874
875         Reviewed by Zalan Bujtas.
876
877         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
878         change the default value of the Setting to 'true', and hardcode WebView on iOS to
879         set it to false. The setting has shipped for several years and there's no need to turn
880         it off now.
881
882         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
883         Visual Viewports are not enabled.
884         
885         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
886         that only runs in WK2
887
888         * MiniBrowser/mac/SettingsController.h:
889         * MiniBrowser/mac/SettingsController.m:
890         (-[SettingsController init]):
891         (-[SettingsController _populateMenu]):
892         (-[SettingsController validateMenuItem:]):
893         (-[SettingsController visualViewportEnabled]): Deleted.
894         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
895         * MiniBrowser/mac/WK1BrowserWindowController.m:
896         (-[WK1BrowserWindowController didChangeSettings]):
897         * MiniBrowser/mac/WK2BrowserWindowController.m:
898         (-[WK2BrowserWindowController didChangeSettings]):
899
900 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
901
902         Discard cached processes when clearing website data store
903         https://bugs.webkit.org/show_bug.cgi?id=194894
904
905         Reviewed by Chris Dumez.
906
907         Added a test case.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
910         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
911
912 2019-02-21  Alex Christensen  <achristensen@webkit.org>
913
914         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
915         https://bugs.webkit.org/show_bug.cgi?id=194914
916         <rdar://problem/47586889>
917
918         Reviewed by Geoffrey Garen.
919
920         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
921         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
922         (TEST):
923         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
924
925 2019-02-21  David Kilzer  <ddkilzer@apple.com>
926
927         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
928         <https://webkit.org/b/194761>
929
930         Reviewed by Myles Maxfield.
931
932         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
933         (WTR::activateSystemCoreWebFonts): Log `error` to console if
934         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
935         to use ARC-compliant cast.
936         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
937         ARC-compliant cast.
938         (WTR::installFakeHelvetica): Log `error` to console if
939         CTFontManagerRegisterFontsForURL() fails, but only on supported
940         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
941         Call CFRelease() on `error` to fix the leak.  Update to use
942         ARC-compliant cast.
943         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
944         cast.
945
946 2019-02-21  Chris Dumez  <cdumez@apple.com>
947
948         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
949         https://bugs.webkit.org/show_bug.cgi?id=194481
950
951         Reviewed by Alex Christensen.
952
953         Give the processes a chance to shutdown and wait until we reached the expected number
954         of processes.
955
956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
957
958 2019-02-21  Tim Horton  <timothy_horton@apple.com>
959
960         Fix the macOS build
961
962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
963
964 2019-02-21  Tim Horton  <timothy_horton@apple.com>
965
966         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
967
968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
969         I am a backwards.
970
971 2019-02-21  Tim Horton  <timothy_horton@apple.com>
972
973         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
974
975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
976         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
977         We could force on UI-side compositing, but I feel like the test might be more
978         valuable exercising the normal path on each platform (though the original
979         bug was also UI-side specific). Though we can't validate that the overlay
980         layer was installed successfully, there are layout tests that do that.
981
982 2019-02-21  Tim Horton  <timothy_horton@apple.com>
983
984         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
985         https://bugs.webkit.org/show_bug.cgi?id=194845
986         <rdar://problem/47944579>
987
988         Reviewed by Antti Koivisto.
989
990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
992
993 2019-02-21  Zalan Bujtas  <zalan@apple.com>
994
995         [LFC][Floats] Add support for placing formatting roots in-between floats.
996         https://bugs.webkit.org/show_bug.cgi?id=194902
997
998         Reviewed by Antti Koivisto.
999
1000         * LayoutReloaded/misc/LFC-passing-tests.txt:
1001
1002 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1003
1004         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1005         https://bugs.webkit.org/show_bug.cgi?id=194901
1006
1007         Unreviewed build fix.
1008
1009         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1010         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1011         WPEBackend-fdo-0.1 as library name.
1012
1013 2019-02-21  Rob Buis  <rbuis@igalia.com>
1014
1015         Update MIME type parser
1016         https://bugs.webkit.org/show_bug.cgi?id=180526
1017
1018         Reviewed by Darin Adler.
1019
1020         Add tests involving leading and trailing whitespace, non-token
1021         characters and quoted strings.
1022
1023         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1024         (TestWebKitAPI::TEST):
1025
1026 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1027
1028         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1029         https://bugs.webkit.org/show_bug.cgi?id=194884
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         * PlatformWin.cmake:
1034
1035 2019-02-20  Chris Dumez  <cdumez@apple.com>
1036
1037         Add API test for <rdar://problem/47471222>
1038         https://bugs.webkit.org/show_bug.cgi?id=194847
1039
1040         Reviewed by Alex Christensen.
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1043
1044 2019-02-20  Chris Dumez  <cdumez@apple.com>
1045
1046         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1047         https://bugs.webkit.org/show_bug.cgi?id=194872
1048         <rdar://problem/47924500>
1049
1050         Reviewed by Alex Christensen.
1051
1052         Add API test coverage.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1055
1056 2019-02-20  Jer Noble  <jer.noble@apple.com>
1057
1058         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1059         https://bugs.webkit.org/show_bug.cgi?id=191332
1060
1061         Reviewed by Dean Jackson.
1062
1063         * Scripts/git-is-in-range: Added.
1064
1065 2019-02-20  Andy Estes  <aestes@apple.com>
1066
1067         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1068         https://bugs.webkit.org/show_bug.cgi?id=194869
1069
1070         Rubber-stamped by Jer Noble.
1071
1072         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1073         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1074         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1075         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1077         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1078
1079 2019-02-20  Chris Dumez  <cdumez@apple.com>
1080
1081         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1082         https://bugs.webkit.org/show_bug.cgi?id=194857
1083         <rdar://problem/47759323>
1084
1085         Reviewed by Alex Christensen.
1086
1087         Add API test coverage.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1090
1091 2019-02-20  Chris Dumez  <cdumez@apple.com>
1092
1093         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1094         https://bugs.webkit.org/show_bug.cgi?id=194829
1095         <rdar://problem/47889906>
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         Every time the TestOptions were changing we were creating both a new Web view and
1100         a new WKContext, which would start a new Network process. In most cases, we only
1101         need to contruct a new Web view and we do can keep reusing the same WKContext.
1102         This patch implements this optimization and thus avoids spinning a lot of new
1103         Network processes while running the layout tests.
1104
1105         * WebKitTestRunner/TestController.cpp:
1106         (WTR::TestController::generateContextConfiguration const):
1107         (WTR::TestController::generatePageConfiguration):
1108         (WTR::TestController::createWebViewWithOptions):
1109         (WTR::TestController::resetPreferencesToConsistentValues):
1110         (WTR::updateTestOptionsFromTestHeader):
1111         * WebKitTestRunner/TestController.h:
1112         * WebKitTestRunner/TestOptions.h:
1113         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1114         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1115         (WTR::TestOptions::hasSameInitializationOptions const):
1116         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1117         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1118         (WTR::TestController::platformAddTestOptions const):
1119
1120 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1121
1122         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1123         https://bugs.webkit.org/show_bug.cgi?id=167941
1124
1125         Reviewed by Carlos Garcia Campos.
1126
1127         * MiniBrowser/gtk/main.c:
1128         (filterSavedCallback): Added.
1129         (main): Support loading a JSON rule set file for content filtering.
1130         * MiniBrowser/wpe/main.cpp:
1131         (filterSavedCallback): Added.
1132         (main): Support loading a JSON rule set file for content filtering.
1133         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1134         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1135         (WTF::derefGPtr): Ditto.
1136         (testEmptyStore):
1137         (testSaveInvalidFilter):
1138         (testSaveLoadFilter):
1139         (testSavedFilterIdentifierMatch):
1140         (testRemoveFilter):
1141         (testSaveMultipleFilters):
1142         (testSaveFilterFromFile):
1143         (testFilterPersistence):
1144         (beforeAll):
1145         (afterAll):
1146         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1147         (removeOldInjectedContentAndResetLists): Also reset content filters.
1148         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1149         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1150         the element affected by the style sheet.
1151         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1152         and returns it to be used by tests.
1153         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1154         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1155         (serverCallback): Add support for serving a CSS style sheet for testing.
1156         (beforeAll): Add call to testUserContentManagerContentFilter().
1157         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1158
1159 2019-02-19  Keith Rollin  <krollin@apple.com>
1160
1161         Add timing information to build output
1162         https://bugs.webkit.org/show_bug.cgi?id=194839
1163         <rdar://problem/48219609>
1164
1165         Reviewed by Alexey Proskuryakov.
1166
1167         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1168         emit each project's build time to its output. E.g.,
1169
1170             ** BUILD SUCCEEDED ** [0.132 sec]
1171
1172         * Scripts/webkitdirs.pm:
1173         (XcodeOptions):
1174
1175 2019-02-19  Truitt Savell  <tsavell@apple.com>
1176
1177         Unreviewed, rolling out r241784.
1178
1179         Broke all OpenSource builds.
1180
1181         Reverted changeset:
1182
1183         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1184         instances view"
1185         https://bugs.webkit.org/show_bug.cgi?id=172848
1186         https://trac.webkit.org/changeset/241784
1187
1188 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1189
1190         [LFC][Floats] Remove redundant intersecting logic
1191         https://bugs.webkit.org/show_bug.cgi?id=194804
1192
1193         Reviewed by Antti Koivisto.
1194
1195         * LayoutReloaded/misc/LFC-passing-tests.txt:
1196
1197 2019-02-19  Dean Jackson  <dino@apple.com>
1198
1199         Clean-up output from generate-xcfilelists so it can be filtered
1200         https://bugs.webkit.org/show_bug.cgi?id=194795
1201
1202         Reviewed by Joseph Pecoraro (and Keith Rollin).
1203
1204         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1205         make a slight tweak to filter-build-webkit so such lines are marked
1206         as plain.
1207
1208         * Scripts/filter-build-webkit:
1209         * Scripts/generate-xcfilelists:
1210
1211 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1212
1213         pytest is not correctly auto-installed
1214         https://bugs.webkit.org/show_bug.cgi?id=194707
1215
1216         Reviewed by Carlos Garcia Campos.
1217
1218         * Scripts/webkitpy/thirdparty/__init__.py:
1219         (AutoinstallImportHook._install_pytest):
1220
1221 2019-02-18  Chris Dumez  <cdumez@apple.com>
1222
1223         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1224         https://bugs.webkit.org/show_bug.cgi?id=194797
1225         <rdar://problem/48055151>
1226
1227         Reviewed by Geoffrey Garen.
1228
1229         Add API test coverage.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1232
1233 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1234
1235         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1236         https://bugs.webkit.org/show_bug.cgi?id=194670
1237         <rdar://problem/39066529>
1238
1239         Reviewed by Tim Horton.
1240
1241         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1242         pasted in an editable area as attachment elements.
1243
1244         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1245         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1246         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1248         (TestWebKitAPI::TEST):
1249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1250         (WTR::InjectedBundlePage::InjectedBundlePage):
1251
1252 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1253
1254         Fix API test after r241728
1255        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1256
1257         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1258         (TEST):
1259         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1260
1261 2019-02-18  Daniel Bates  <dabates@apple.com>
1262
1263         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1264         https://bugs.webkit.org/show_bug.cgi?id=192824
1265         <rdar://problem/47100332>
1266
1267         Reviewed by Wenson Hsieh.
1268
1269         Fix a bug where the wrong usage code was used for F13 thru F24.
1270
1271         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1272         (keyCodeForDOMFunctionKey):
1273
1274 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1275
1276         Bytecode cache should a have a boot-specific validation
1277         https://bugs.webkit.org/show_bug.cgi?id=194769
1278         <rdar://problem/48149509>
1279
1280         Reviewed by Keith Miller.
1281
1282         Add test for WTF::bootSessionUUIDString()
1283
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1285         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1286         (TEST):
1287
1288 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1289
1290         Disable safe browsing in WKWebView and remove its WKPreferences API
1291         https://bugs.webkit.org/show_bug.cgi?id=194723
1292         <rdar://problem/48122993>
1293
1294         Reviewed by Geoffrey Garen.
1295
1296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1297         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1298         (TEST):
1299         (safeBrowsingView):
1300         Make tests use SPI instead of API.
1301
1302 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1303
1304         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1305         https://bugs.webkit.org/show_bug.cgi?id=194586
1306
1307         Reviewed by Ross Kirsling.
1308
1309         * DumpRenderTree/win/DumpRenderTree.cpp:
1310         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1311         * Scripts/webkitpy/port/driver.py:
1312         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1313
1314 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1315
1316         Unreviewed, rolling out r241620.
1317
1318         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1319         (Requested by ddkilzer on #webkit.)
1320
1321         Reverted changeset:
1322
1323         "[WTF] Add environment variable helpers"
1324         https://bugs.webkit.org/show_bug.cgi?id=192405
1325         https://trac.webkit.org/changeset/241620
1326
1327 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1328
1329         [LFC] RenderImage's default intrinsic size is 0.
1330         https://bugs.webkit.org/show_bug.cgi?id=194745
1331
1332         Reviewed by Antti Koivisto.
1333
1334         * LayoutReloaded/misc/LFC-passing-tests.txt:
1335
1336 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1337
1338         [LFC][BFC] Add support for block replaced intrinsic width.
1339         https://bugs.webkit.org/show_bug.cgi?id=194705
1340
1341         Reviewed by Simon Fraser.
1342
1343         * LayoutReloaded/misc/LFC-passing-tests.txt:
1344
1345 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1346
1347         [LFC] Apply min/max width constraints to preferred width computation
1348         https://bugs.webkit.org/show_bug.cgi?id=194739
1349
1350         Reviewed by Simon Fraser.
1351
1352         * LayoutReloaded/misc/LFC-passing-tests.txt:
1353
1354 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1355
1356         [WTF] Add environment variable helpers
1357         https://bugs.webkit.org/show_bug.cgi?id=192405
1358
1359         Reviewed by Michael Catanzaro.
1360
1361         * DumpRenderTree/mac/DumpRenderTree.mm:
1362         (libraryPathForDumpRenderTree):
1363         * DumpRenderTree/win/DumpRenderTree.cpp:
1364         (libraryPathForDumpRenderTree):
1365         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1366         (setUpIOSLayoutTestCommunication):
1367         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1368         (beforeAll):
1369         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1370         (main):
1371         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1372         (WebKitTestBus::run):
1373         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1374         (WTR::getOutputDir):
1375         (WTR::initializeFontConfigSetting):
1376         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1377         (WTR::InjectedBundle::platformInitialize):
1378         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1379         (WTR::topLevelPath):
1380         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1381         (WTR::topLevelPath):
1382         (WTR::getOutputDir):
1383         (WTR::activateFonts):
1384         * WebKitTestRunner/TestController.cpp:
1385         (WTR::TestController::libraryPathForTesting):
1386         (WTR::TestController::generateContextConfiguration const):
1387         (WTR::TestController::generatePageConfiguration):
1388         (WTR::TestController::decideDestinationWithSuggestedFilename):
1389         (WTR::TestController::platformAdjustContext):
1390         * WebKitTestRunner/TestController.h:
1391         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1392         (WTR::TestController::cocoaPlatformInitialize):
1393         (WTR::TestController::platformAdjustContext):
1394         * WebKitTestRunner/gtk/main.cpp:
1395         (main):
1396         * WebKitTestRunner/mac/TestControllerMac.mm:
1397         (WTR::TestController::configureContentExtensionForTest):
1398         * WebKitTestRunner/wpe/main.cpp:
1399         (main):
1400         Utilize WTF::Environment where possible.
1401
1402 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1403
1404         [iOS] WKWebView callout bar is missing Change Writing Direction item
1405         https://bugs.webkit.org/show_bug.cgi?id=190015
1406         <rdar://problem/44810366>
1407
1408         Reviewed by Tim Horton.
1409
1410         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1411         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1414         (TestWebKitAPI::TEST):
1415
1416 2019-02-15  Chris Dumez  <cdumez@apple.com>
1417
1418         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1419         https://bugs.webkit.org/show_bug.cgi?id=194717
1420         <rdar://problem/47884404>
1421
1422         Reviewed by Brady Eidson.
1423
1424         Add API test coverage.
1425
1426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1427
1428 2019-02-15  Youenn Fablet  <youenn@apple.com>
1429
1430         Make navigator.mediaDevices SecureContext
1431         https://bugs.webkit.org/show_bug.cgi?id=194666
1432
1433         Reviewed by Eric Carlson.
1434
1435         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1436         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1437         (TEST_F):
1438
1439 2019-02-15  Brian Burg  <bburg@apple.com>
1440
1441         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1442         https://bugs.webkit.org/show_bug.cgi?id=194411
1443         <rdar://problem/47787614>
1444
1445         Reviewed by Joseph Pecoraro.
1446
1447         Remove unnecessary soft linking macro usage.
1448
1449         * DumpRenderTree/mac/TestRunnerMac.mm:
1450         (TestRunner::inspectorTestStubURL):
1451         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1452         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1453         (WTR::TestRunner::inspectorTestStubURL):
1454
1455 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1456
1457         Unreviewed, rolling out r241559 and r241566.
1458         https://bugs.webkit.org/show_bug.cgi?id=194710
1459
1460         Causes layout test crashes under GuardMalloc (Requested by
1461         ryanhaddad on #webkit).
1462
1463         Reverted changesets:
1464
1465         "[WTF] Add environment variable helpers"
1466         https://bugs.webkit.org/show_bug.cgi?id=192405
1467         https://trac.webkit.org/changeset/241559
1468
1469         "Unreviewed build fix for WinCairo Debug after r241559."
1470         https://trac.webkit.org/changeset/241566
1471
1472 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1473
1474         [LFC] Out-of-flow box is never a float box
1475         https://bugs.webkit.org/show_bug.cgi?id=194704
1476
1477         Reviewed by Antti Koivisto.
1478
1479         * LayoutReloaded/misc/LFC-passing-tests.txt:
1480
1481 2019-02-10  Darin Adler  <darin@apple.com>
1482
1483         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1484         https://bugs.webkit.org/show_bug.cgi?id=194487
1485
1486         Reviewed by Daniel Bates.
1487
1488         * DumpRenderTree/win/DumpRenderTree.cpp:
1489         (applicationId): Use makeString instead of String::format.
1490         (main): Ditto.
1491         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1492         (TestWebKitAPI::Util::createURLForResource): Ditto.
1493         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1494         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1495
1496         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1497         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1498         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1499         (WTR::createStringWithAttributes): Use appendLiteral.
1500         (WTR::AccessibilityUIElement::helpText const): Ditto.
1501         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1502         directly instead of using String::format.
1503         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1504         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1505
1506 2019-02-15  Truitt Savell  <tsavell@apple.com>
1507
1508         Unreviewed, rolling out r241564.
1509
1510         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1511
1512         Reverted changeset:
1513
1514         "[Mac] WebInspectorUI.framework does not need to be soft-
1515         linked anymore"
1516         https://bugs.webkit.org/show_bug.cgi?id=194411
1517         https://trac.webkit.org/changeset/241564
1518
1519 2019-02-15  Saam barati  <sbarati@apple.com>
1520
1521         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1522         https://bugs.webkit.org/show_bug.cgi?id=194036
1523
1524         Reviewed by Yusuke Suzuki.
1525
1526         * Scripts/run-jsc-stress-tests:
1527
1528 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1529
1530         Fix the build.
1531
1532         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1533         (WTR::UIScriptController::drawSquareInEditableImage):
1534         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1535         (TestWebKitAPI::drawSquareInEditableImage):
1536
1537 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1538
1539         Fix the build.
1540
1541         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1542         (WTR::UIScriptController::drawSquareInEditableImage):
1543         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1544         (TestWebKitAPI::drawSquareInEditableImage):
1545
1546 2019-02-14  Brian Burg  <bburg@apple.com>
1547
1548         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1549         https://bugs.webkit.org/show_bug.cgi?id=194411
1550         <rdar://problem/47787614>
1551
1552         Reviewed by Joseph Pecoraro.
1553
1554         Remove unnecessary soft linking macro usage.
1555
1556         * DumpRenderTree/mac/TestRunnerMac.mm:
1557         (TestRunner::inspectorTestStubURL):
1558         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1559         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1560         (WTR::TestRunner::inspectorTestStubURL):
1561
1562 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1563
1564         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1565         https://bugs.webkit.org/show_bug.cgi?id=194599
1566
1567         Reviewed by Lucas Forschler.
1568
1569         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1570         (StatusBubble._build_bubble):
1571
1572 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1573
1574         [ews-app] Set Foreign Key in Django build model
1575         https://bugs.webkit.org/show_bug.cgi?id=194667
1576
1577         Reviewed by Lucas Forschler.
1578
1579         * BuildSlaveSupport/ews-app/ews/models/build.py:
1580         (Build):
1581
1582 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1583
1584         [WTF] Add environment variable helpers
1585         https://bugs.webkit.org/show_bug.cgi?id=192405
1586
1587         Reviewed by Michael Catanzaro.
1588
1589         * DumpRenderTree/mac/DumpRenderTree.mm:
1590         (libraryPathForDumpRenderTree):
1591         * DumpRenderTree/win/DumpRenderTree.cpp:
1592         (libraryPathForDumpRenderTree):
1593         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1594         (setUpIOSLayoutTestCommunication):
1595         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1596         (TestWebKitAPI::strip):
1597         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1598         (beforeAll):
1599         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1600         (main):
1601         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1602         (WebKitTestBus::run):
1603         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1604         (WTR::getOutputDir):
1605         (WTR::initializeFontConfigSetting):
1606         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1607         (WTR::InjectedBundle::platformInitialize):
1608         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1609         (WTR::topLevelPath):
1610         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1611         (WTR::topLevelPath):
1612         (WTR::getOutputDir):
1613         (WTR::activateFonts):
1614         * WebKitTestRunner/TestController.cpp:
1615         (WTR::TestController::libraryPathForTesting):
1616         (WTR::TestController::generateContextConfiguration const):
1617         (WTR::TestController::generatePageConfiguration):
1618         (WTR::TestController::decideDestinationWithSuggestedFilename):
1619         (WTR::TestController::platformAdjustContext):
1620         * WebKitTestRunner/TestController.h:
1621         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1622         (WTR::TestController::cocoaPlatformInitialize):
1623         (WTR::TestController::platformAdjustContext):
1624         * WebKitTestRunner/gtk/main.cpp:
1625         (main):
1626         * WebKitTestRunner/mac/TestControllerMac.mm:
1627         (WTR::TestController::configureContentExtensionForTest):
1628         * WebKitTestRunner/wpe/main.cpp:
1629         (main):
1630         Utilize WTF::Environment where possible.
1631
1632 2019-02-14  Chris Dumez  <cdumez@apple.com>
1633
1634         [PSON] Introduce a WebContent Process cache
1635         https://bugs.webkit.org/show_bug.cgi?id=194594
1636         <rdar://problem/46793397>
1637
1638         Reviewed by Geoff Garen.
1639
1640         Update API tests to turn on the WebContent Process cache.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1643
1644 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1645
1646         Unreviewed, build fix after r241480
1647
1648         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1649         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1650         (-[DragAndDropSimulator initWithWebView:]):
1651
1652 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1653
1654         AX: ARIA Reflection was disabled in error
1655         https://bugs.webkit.org/show_bug.cgi?id=194647
1656         <rdar://problem/48068336>
1657
1658         Reviewed by Ryosuke Niwa.
1659
1660         Remove test override now that this feature should be enabled by default.
1661
1662         * WebKitTestRunner/TestController.cpp:
1663         (WTR::TestController::resetPreferencesToConsistentValues):
1664
1665 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1666
1667         Unreviewed, rolling out r241486.
1668         https://bugs.webkit.org/show_bug.cgi?id=194655
1669
1670         causing API failures in builds (Requested by ShawnRoberts on
1671         #webkit).
1672
1673         Reverted changeset:
1674
1675         "[Cocoa] Media elements will restart network buffering just
1676         before suspending"
1677         https://bugs.webkit.org/show_bug.cgi?id=193691
1678         https://trac.webkit.org/changeset/241486
1679
1680 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1681
1682         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1683         https://bugs.webkit.org/show_bug.cgi?id=194622
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * LayoutReloaded/misc/LFC-passing-tests.txt:
1688
1689 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1690
1691         [LFC] Shrink-to-fit-width should be constrained by min/max width
1692         https://bugs.webkit.org/show_bug.cgi?id=194653
1693
1694         Reviewed by Antti Koivisto.
1695
1696         * LayoutReloaded/misc/LFC-passing-tests.txt:
1697
1698 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1699
1700         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1701         https://bugs.webkit.org/show_bug.cgi?id=194641
1702
1703         Reviewed by Geoffrey Garen.
1704
1705         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1706         so that the test would fail without this fix.
1707
1708         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1709         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1710
1711 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-app] Change log level for a log statement
1714
1715         Unreviewed minor fix.
1716
1717         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1718         (Patch.save_patch):
1719
1720 2019-02-13  Jer Noble  <jer.noble@apple.com>
1721
1722         [Cocoa] Media elements will restart network buffering just before suspending
1723         https://bugs.webkit.org/show_bug.cgi?id=193691
1724
1725         Reviewed by Eric Carlson.
1726
1727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1729         (TEST):
1730
1731 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-app] Fetch builder id to name mapping
1734         https://bugs.webkit.org/show_bug.cgi?id=194355
1735
1736         Reviewed by Lucas Forschler.
1737
1738         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1739         (Buildbot.get_builder_id_to_name_mapping):
1740         (Buildbot._get_display_name_from_builder_name):
1741
1742 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1743
1744         Further restricting webarchive loads
1745         https://bugs.webkit.org/show_bug.cgi?id=194567
1746         <rdar://problem/47610130>
1747
1748         Reviewed by Youenn Fablet.
1749
1750         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1751         navigations on drop.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1755         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1756         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1757         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1758         (TestWebKitAPI::TEST):
1759         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1760         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1761         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1762         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1763         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1764         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1765         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1766
1767 2019-02-13  John Wilander  <wilander@apple.com>
1768
1769         Store Ad Click Attribution requests in the network process
1770         https://bugs.webkit.org/show_bug.cgi?id=194510
1771         <rdar://problem/47650118>
1772
1773         Reviewed by Alex Christensen and Daniel Bates.
1774
1775         This patch adds two TestRunner functions:
1776         - dumpAdClickAttribution()
1777         - clearAdClickAttribution()
1778
1779         They call into the network process to dump and clear Ad Click
1780         Attribution state, respectively.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1784         (WTR::TestRunner::dumpAdClickAttribution):
1785         (WTR::TestRunner::clearAdClickAttribution):
1786         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1787         * WebKitTestRunner/TestController.cpp:
1788         (WTR::TestController::resetStateToConsistentValues):
1789         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1790         (WTR::adClickAttributionStringResultCallback):
1791         (WTR::TestController::dumpAdClickAttribution):
1792         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1793         (WTR::adClickAttributionVoidCallback):
1794         (WTR::TestController::clearAdClickAttribution):
1795         * WebKitTestRunner/TestController.h:
1796         * WebKitTestRunner/TestInvocation.cpp:
1797         (WTR::TestInvocation::dumpResults):
1798         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1799         (WTR::TestInvocation::dumpAdClickAttribution):
1800         * WebKitTestRunner/TestInvocation.h:
1801
1802 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1803
1804         [ews-app] Generate status-bubble
1805         https://bugs.webkit.org/show_bug.cgi?id=194572
1806
1807         Reviewed by Lucas Forschler.
1808
1809         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1810         (StatusBubble._build_bubble):
1811         (StatusBubble._should_show_bubble_for):
1812         (StatusBubble._build_bubbles_for_patch):
1813
1814 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1815
1816         [ews-app] Add status bubble html template
1817         https://bugs.webkit.org/show_bug.cgi?id=194571
1818
1819         Reviewed by Lucas Forschler.
1820
1821         * BuildSlaveSupport/ews-app/ews/templates: Added.
1822         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1823
1824 2019-02-12  Chris Dumez  <cdumez@apple.com>
1825
1826         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1827         https://bugs.webkit.org/show_bug.cgi?id=194568
1828         <rdar://problem/47944490>
1829
1830         Reviewed by Ryosuke Niwa.
1831
1832         Add API test coverage.
1833
1834         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1835         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1836
1837 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1838
1839         webkitpy: Remove bug_dummy from parsed test expectations
1840         https://bugs.webkit.org/show_bug.cgi?id=194562
1841         <rdar://problem/47853999>
1842
1843         Reviewed by Lucas Forschler.
1844
1845         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1846         (TestExpectationParser):
1847         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1848         skipped tests.
1849         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1850
1851 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1852
1853         [ews-app] Add method to fetch patch
1854         https://bugs.webkit.org/show_bug.cgi?id=194518
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1859         (Patch.get_patch):
1860
1861 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1862
1863         [LFC] Expand tests coverage (60 new tests -> 860)
1864
1865         Unreviewed test gardening (run-singly, --child-processes=1).
1866
1867         * LayoutReloaded/misc/LFC-passing-tests.txt:
1868
1869 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1870
1871         Allow pages to trigger programmatic paste from script on iOS
1872         https://bugs.webkit.org/show_bug.cgi?id=194271
1873         <rdar://problem/47808810>
1874
1875         Reviewed by Tim Horton.
1876
1877         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1878
1879         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1880         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1881         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1882         (WTR::UIScriptController::rectForMenuAction const):
1883
1884         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1885         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1886         for when the menu is shown or hidden.
1887
1888         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1889         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1890         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1891         (WTR::UIScriptController::setDidShowMenuCallback):
1892         (WTR::UIScriptController::didShowMenuCallback const):
1893         (WTR::UIScriptController::setDidHideMenuCallback):
1894         (WTR::UIScriptController::didHideMenuCallback const):
1895         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1896         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1897         (WTR::UIScriptController::rectForMenuAction const):
1898         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::TestController::resetPreferencesToConsistentValues):
1901         (WTR::updateTestOptionsFromTestHeader):
1902         * WebKitTestRunner/TestOptions.h:
1903
1904         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1905         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1906
1907         (WTR::TestOptions::hasSameInitializationOptions const):
1908         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1909         (WTR::UIScriptController::calendarType const):
1910         (WTR::UIScriptController::platformUndoManager const):
1911         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1912         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1913         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1914         (-[TestRunnerWKWebView dealloc]):
1915         (-[TestRunnerWKWebView _didShowMenu]):
1916         (-[TestRunnerWKWebView _didHideMenu]):
1917
1918         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1919
1920         * WebKitTestRunner/ios/TestControllerIOS.mm:
1921         (WTR::handleMenuWillHideNotification):
1922         (WTR::handleMenuDidHideNotification):
1923         (WTR::TestController::platformInitialize):
1924         (WTR::TestController::platformDestroy):
1925         (WTR::TestController::platformResetStateToConsistentValues):
1926
1927         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1928         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1929
1930         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1931         (WTR::forEachViewInHierarchy):
1932         (WTR::findViewInHierarchyOfType):
1933
1934         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1935         functions that dig through a given view's hierarchy in search of a view of a given class.
1936
1937         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1938         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1939         (WTR::UIScriptController::selectionCaretViewRect const):
1940         (WTR::UIScriptController::selectionRangeViewRects const):
1941         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1942         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1943
1944         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1945
1946         (WTR::UIScriptController::rectForMenuAction const):
1947
1948         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1949         callout bar) whose label matches the given string.
1950
1951         (WTR::UIScriptController::platformContentView const):
1952
1953         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1954         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1955         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1956
1957         (WTR::UIScriptController::platformUndoManager const): Deleted.
1958         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1959         (WTR::UIScriptController::platformContentView const):
1960         (WTR::UIScriptController::platformUndoManager const): Deleted.
1961
1962 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1963
1964         webkitpy: No option to only show unexpected failures in results.html for iPad
1965         https://bugs.webkit.org/show_bug.cgi?id=194554
1966         <rdar://problem/47922442>
1967
1968         Rubber-stamped by Aakash Jain.
1969
1970         Just because a TestExpecations file does not exist for a specific platform does not mean that
1971         TestExpecations are not being used, given that platforms inherit test expectations.
1972
1973         * Scripts/webkitpy/port/base.py:
1974         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1975         * Scripts/webkitpy/port/base_unittest.py:
1976         (PortTest.test_uses_test_expectations_file):
1977
1978 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1979
1980         Remove setDefersLoading infrastructure from WebKit2
1981         https://bugs.webkit.org/show_bug.cgi?id=194506
1982
1983         Reviewed by Brady Eidson.
1984
1985         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1986         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1987         (WTR::TestRunner::setDefersLoading): Deleted.
1988         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1989
1990 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1991
1992         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1993         https://bugs.webkit.org/show_bug.cgi?id=194522
1994         <rdar://problem/47789393>
1995
1996         Reviewed by Chris Dumez.
1997
1998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1999         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2000         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2002
2003 2019-02-12  Andy Estes  <aestes@apple.com>
2004
2005         [iOSMac] Enable Parental Controls Content Filtering
2006         https://bugs.webkit.org/show_bug.cgi?id=194521
2007         <rdar://39732376>
2008
2009         Reviewed by Tim Horton.
2010
2011         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2012
2013 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2014
2015         [LFC][IFC] Add intrinsic width support for float boxes.
2016         https://bugs.webkit.org/show_bug.cgi?id=194528
2017
2018         Reviewed by Antti Koivisto.
2019
2020         Expand tests coverage (2 new tests -> 800).
2021         (This is the correct test ordering --runs-singly --child-processes=1)
2022
2023         * LayoutReloaded/misc/LFC-passing-tests.txt:
2024
2025 2019-02-12  Rob Buis  <rbuis@igalia.com>
2026
2027         Implement serializing in MIME type parser
2028         https://bugs.webkit.org/show_bug.cgi?id=193909
2029
2030         Reviewed by Darin Adler.
2031
2032         Add various tests involving upper case, non-ASCII, control/null characters,
2033         various HTTP whitespace, single quotes and an unpaired surrogate.
2034
2035         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2036         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2037         (TestWebKitAPI::serializeIfValid):
2038         (TestWebKitAPI::TEST):
2039
2040 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2041
2042         [Cocoa] Ask platform for generic font family mappings
2043         https://bugs.webkit.org/show_bug.cgi?id=187723
2044         <rdar://problem/41892438>
2045
2046         Reviewed by Brent Fulgham.
2047
2048         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2049
2050         * DumpRenderTree/mac/DumpRenderTree.mm:
2051         (allowedFontFamilySet):
2052         * WebKitTestRunner/mac/TestControllerMac.mm:
2053         (WTR::allowedFontFamilySet):
2054
2055 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2056
2057         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2058         https://bugs.webkit.org/show_bug.cgi?id=193622
2059
2060         Reviewed by Michael Catanzaro.
2061
2062         This adds support for loading content extension rule sets from the JSON files which
2063         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2064         of WKTR for this could be removed, but that is left for a follow-up patch with
2065         cleanups.
2066
2067         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2068         * WebKitTestRunner/TestController.cpp:
2069         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2070         avoid having the null-terminator copied into the result.
2071         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2072         part of the preparations to run a test.
2073         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2074         (WTR::contentExtensionStoreCallback): Added.
2075         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2076         used for content extensions test.
2077         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2078         extensions and compiling the JSON rule set for tests involving content extensions.
2079         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2080         testing and disables content extensions.
2081         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2082         resetContentExtensions().
2083         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2084         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2085         configureContentExtensionForTest(), and userContentController().
2086
2087 2019-02-11  Daniel Bates  <dabates@apple.com>
2088
2089         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2090         https://bugs.webkit.org/show_bug.cgi?id=191446
2091         <rdar://problem/45929460>
2092
2093         Reviewed by Tim Horton.
2094
2095         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2096
2097         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2098         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2099         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2100         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2101         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2102         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2103         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2104         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2105         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2106         (WTR::arrayLength):
2107         (WTR::parseModifierArray):
2108         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2109         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2110         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2111         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2112
2113 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2114
2115         Unreviewed, rolling out r241272 and r241276.
2116         https://bugs.webkit.org/show_bug.cgi?id=194514
2117
2118         Broke the Apple Internal build and the fix requires human
2119         intervention :( (Requested by dydz on #webkit).
2120
2121         Reverted changesets:
2122
2123         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2124         https://bugs.webkit.org/show_bug.cgi?id=191446
2125         https://trac.webkit.org/changeset/241272
2126
2127         "Fix internal iOS build after r241272"
2128         https://bugs.webkit.org/show_bug.cgi?id=191446
2129         https://trac.webkit.org/changeset/241276
2130
2131 2019-02-11  Truitt Savell  <tsavell@apple.com>
2132
2133         Unreviewed, rolling out r241269.
2134
2135         Caused 5 layout tests crashes on Mac WK1
2136
2137         Reverted changeset:
2138
2139         "DumpRenderTree should report unknown options"
2140         https://bugs.webkit.org/show_bug.cgi?id=191303
2141         https://trac.webkit.org/changeset/241269
2142
2143 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2144
2145         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2146         https://bugs.webkit.org/show_bug.cgi?id=194313
2147
2148         Reviewed by Tim Horton.
2149
2150         Add a helper to determine whether the web view is presenting modal UI.
2151
2152         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2153         (WTR::UIScriptController::isPresentingModally const):
2154         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2155         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2156         (WTR::UIScriptController::isPresentingModally const):
2157         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2158         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2159         (WTR::UIScriptController::calendarType const): Deleted.
2160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2161         (WTR::UIScriptController::isPresentingModally const):
2162         (WTR::UIScriptController::calendarType const):
2163         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2164         (WTR::UIScriptController::calendarType const):
2165
2166 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2167
2168         GCHeapInspector: Show the retained sizes in more places
2169         https://bugs.webkit.org/show_bug.cgi?id=194464
2170
2171         Reviewed by Simon Fraser.
2172
2173         * GCHeapInspector/gc-heap-inspector.html:
2174         * GCHeapInspector/script/interface.js:
2175         (HeapInspectorUtils.humanReadableSize):
2176         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2177         (HeapInspectorUtils.spanForNode.span.span):
2178         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2179         (HeapSnapshotInspector.prototype.buildRoots):
2180
2181 2019-02-11  Daniel Bates  <dabates@apple.com>
2182
2183         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2184         https://bugs.webkit.org/show_bug.cgi?id=191446
2185         <rdar://problem/45929460>
2186
2187         Reviewed by Tim Horton.
2188
2189         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2190
2191         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2192         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2193         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2194         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2195         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2196         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2197         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2198         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2199         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2200         (WTR::arrayLength):
2201         (WTR::parseModifierArray):
2202         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2203         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2204         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2205         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2206
2207 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2208
2209         DumpRenderTree should report unknown options
2210         https://bugs.webkit.org/show_bug.cgi?id=191303
2211
2212         Reviewed by Frédéric Wang.
2213
2214         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2215         to report unknown options.
2216         Added and assigned test options which are currently used in tests.
2217
2218         * DumpRenderTree/TestOptions.cpp:
2219         (TestOptions::TestOptions):
2220
2221 2019-02-11  Truitt Savell  <tsavell@apple.com>
2222
2223         Unreviewed, rolling out r241229.
2224
2225         Revision broke internal builds for watchOS.
2226
2227         Reverted changeset:
2228
2229         "[Cocoa] Ask platform for generic font family mappings"
2230         https://bugs.webkit.org/show_bug.cgi?id=187723
2231         https://trac.webkit.org/changeset/241229
2232
2233 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2234
2235         [WinCairo][MiniBrowser] Basic authentication always fails.
2236         https://bugs.webkit.org/show_bug.cgi?id=194496
2237
2238         Reviewed by Don Olmstead.
2239
2240         * MiniBrowser/win/DialogHelper.h:
2241         (Dialog::getText):
2242
2243 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2244
2245         [GStreamer] GstMappedBuffer testsuite build fails
2246         https://bugs.webkit.org/show_bug.cgi?id=194495
2247
2248         Reviewed by Carlos Garcia Campos.
2249
2250         Fix the build by explicitely adding the gstreamer1.0-audio include
2251         directories to the include path.
2252
2253         * TestWebKitAPI/PlatformGTK.cmake:
2254         * TestWebKitAPI/PlatformWPE.cmake:
2255
2256 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2257
2258         [GTK][WPE] Add enable-javascript-markup setting
2259         https://bugs.webkit.org/show_bug.cgi?id=193439
2260
2261         Reviewed by Michael Catanzaro.
2262
2263         Add test cases to check the new setting.
2264
2265         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2266         (testWebKitSettings):
2267         (testWebKitSettingsJavaScriptMarkup):
2268         (beforeAll):
2269
2270 2019-02-10  Darin Adler  <darin@apple.com>
2271
2272         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2273         https://bugs.webkit.org/show_bug.cgi?id=194485
2274
2275         Reviewed by Daniel Bates.
2276
2277         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2278
2279 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2280
2281         Add more tests for clampTo<>()
2282         https://bugs.webkit.org/show_bug.cgi?id=194462
2283
2284         Reviewed by Geoffrey Garen.
2285
2286         Darin suggested to test the very last floating point number
2287         at the boundaries when truncating to integer.
2288         I added test for max/min and max-1/min-1.
2289
2290         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2291         (TestWebKitAPI::TEST):
2292
2293 2019-02-09  Darin Adler  <darin@apple.com>
2294
2295         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2296         https://bugs.webkit.org/show_bug.cgi?id=194021
2297
2298         Reviewed by Geoffrey Garen.
2299
2300         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2301         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2302         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2303
2304 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2305
2306         [LFC][IFC] Add intrinsic width support for basic inline containers
2307         https://bugs.webkit.org/show_bug.cgi?id=194473
2308
2309         Reviewed by Antti Koivisto.
2310
2311         Expand tests coverage (11 new tests -> 798)
2312
2313         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2314
2315 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2316
2317         Fix MiniBrowser's entitlements
2318         https://bugs.webkit.org/show_bug.cgi?id=192431
2319
2320         Reviewed by Joseph Pecoraro.
2321
2322         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2323         files, making it impossible to load any extension.
2324
2325         * MiniBrowser/MiniBrowser.entitlements:
2326
2327 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2328
2329         [Cocoa] Ask platform for generic font family mappings
2330         https://bugs.webkit.org/show_bug.cgi?id=187723
2331         <rdar://problem/41892438>
2332
2333         Reviewed by Brent Fulgham.
2334
2335         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2336
2337         * DumpRenderTree/mac/DumpRenderTree.mm:
2338         (allowedFontFamilySet):
2339         * WebKitTestRunner/mac/TestControllerMac.mm:
2340         (WTR::allowedFontFamilySet):
2341
2342 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2343
2344         [GTK] Implement back/forward touchpad gesture
2345         https://bugs.webkit.org/show_bug.cgi?id=193919
2346
2347         Reviewed by Michael Catanzaro.
2348
2349         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2350         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2351
2352 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2353
2354         Add SPI to use networking daemon instead of XPC service
2355         https://bugs.webkit.org/show_bug.cgi?id=194427
2356
2357         Reviewed by Geoffrey Garen
2358
2359         * MiniBrowser/MiniBrowser.entitlements:
2360
2361 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2362
2363         [ews-build] Ensure that every builder in config.json has short name
2364         https://bugs.webkit.org/show_bug.cgi?id=194461
2365
2366         Reviewed by Lucas Forschler.
2367
2368         * BuildSlaveSupport/ews-build/loadConfig.py:
2369         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2370
2371 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2372
2373         [ews-build] Add short name to config.json
2374         https://bugs.webkit.org/show_bug.cgi?id=194456
2375
2376         Reviewed by Lucas Forschler.
2377
2378         * BuildSlaveSupport/ews-build/config.json: Added short name.
2379         * BuildSlaveSupport/ews-build/loadConfig.py:
2380         (loadBuilderConfig): Set the short name as the builder description.
2381
2382 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2383
2384         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2385         https://bugs.webkit.org/show_bug.cgi?id=194418
2386
2387         Reviewed by Lucas Forschler.
2388
2389         Do not include errors trying when finding crashlogs at the end of
2390         a run-webkit-tests run since we don't process those errors.
2391
2392         * Scripts/webkitpy/port/darwin.py:
2393         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2394         * Scripts/webkitpy/port/ios_device.py:
2395         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2396         * Scripts/webkitpy/port/watch_device.py:
2397         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2398
2399 2019-02-08  Beth Dakin  <bdakin@apple.com>
2400
2401         Add afterScreenUpdates to WKSnapshotConfiguration
2402         https://bugs.webkit.org/show_bug.cgi?id=194362
2403         -and corresponding-
2404         <rdar://problem/40655528> Please add an "after screen updates" property to 
2405         WKSnapshotConfiguration (to solve blank snapshots)
2406
2407         Reviewed by Tim Horton.
2408
2409         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2410         (TEST):
2411
2412 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2413
2414         clampTo(): do not convert the input to double when dealing with integers
2415         https://bugs.webkit.org/show_bug.cgi?id=194263
2416         <rdar://problem/47692312>
2417
2418         Reviewed by Darin Adler.
2419
2420         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2421         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2422         (TestWebKitAPI::testClampFloatingPointToInteger):
2423         (TestWebKitAPI::testClampSameSignIntegers):
2424         (TestWebKitAPI::testClampUnsignedToSigned):
2425         (TestWebKitAPI::testClampSignedToUnsigned):
2426
2427 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2428
2429         webkitpy: Respect --dedicated-simulators flag
2430         https://bugs.webkit.org/show_bug.cgi?id=194416
2431         <rdar://problem/47894722>
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * Scripts/webkitpy/port/device_port.py:
2436         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2437         available devices can be safely ignored.
2438
2439 2019-02-07  Keith Rollin  <krollin@apple.com>
2440
2441         Remove extra copy of 100x100-red.tga
2442         https://bugs.webkit.org/show_bug.cgi?id=194371
2443         <rdar://problem/47873465>
2444
2445         Reviewed by Said Abou-Hallawa.
2446
2447         In order to help it pass its tests, Bug 194190 added a second copy of
2448         the file 100x100-red.tga. However, it turns out that this additional
2449         file wasn't actually needed, and that that sole previous copy was
2450         sufficient. At the same time, this second copy -- which was copied to
2451         the same location in the build output as the first copy -- now caused
2452         XCBuild to complain because there were two production rules for the
2453         same output file. Address this by removing the newly-added extra copy.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2457
2458 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2459
2460         Deprecate WKBundlePageSetDefersLoading
2461         https://bugs.webkit.org/show_bug.cgi?id=191394
2462
2463         Reviewed by Dean Jackson.
2464
2465         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2466         (WTR::TestRunner::setDefersLoading):
2467
2468 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2469
2470         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2471         https://bugs.webkit.org/show_bug.cgi?id=194391
2472
2473         Reviewed by Antti Koivisto.
2474
2475         * LayoutReloaded/misc/LFC-passing-tests.txt:
2476
2477 2019-02-06  Keith Rollin  <krollin@apple.com>
2478
2479         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2480         https://bugs.webkit.org/show_bug.cgi?id=193975
2481         <rdar://problem/47643306>
2482
2483         Reviewed by Tim Horton.
2484
2485         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2486         the Info.plist file into the bundle. This step is not necessary as the
2487         implicit "bundle up all the build products into a framework" build
2488         phase does this already. Having the Copy Bundle Resources phase do
2489         this causes a conflict under XCBuild, which objects to two build
2490         phases producing the same file (Info.plist). Address this by removing
2491         Info.plist from the Copy Bundle Resources phase.
2492
2493         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2494
2495 2019-02-06  Keith Rollin  <krollin@apple.com>
2496
2497         Really enable the automatic checking and regenerations of .xcfilelists during builds
2498         https://bugs.webkit.org/show_bug.cgi?id=194357
2499         <rdar://problem/47861231>
2500
2501         Reviewed by Chris Dumez.
2502
2503         Bug 194124 was supposed to enable the automatic checking and
2504         regenerating of .xcfilelist files during the build. While related
2505         changes were included in that patch, the change to actually enable the
2506         operation somehow was omitted. This patch actually enables the
2507         operation. The check-xcfilelist.sh scripts now check
2508         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2509         from the checking.
2510
2511         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2512         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2513
2514 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2515
2516         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2517         <https://webkit.org/b/194286>
2518         <rdar://problem/47815558>
2519
2520         Reviewed by Alexey Proskuryakov.
2521
2522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2523         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2524         WKRetainPtr<> to avoid leaking the WKDataRef.
2525
2526 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2527
2528         Unreviewed, fix a typo
2529
2530         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2531
2532 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2533
2534         [GTK][WPE] force libpsl build to use ICU in jhbuild
2535         https://bugs.webkit.org/show_bug.cgi?id=194288
2536
2537         Reviewed by Carlos Garcia Campos.
2538
2539         * gtk/jhbuild.modules:
2540         Require ICU for libpsl build in jhbuild, like done in WPE.
2541
2542 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2543
2544         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2545         https://bugs.webkit.org/show_bug.cgi?id=194209
2546
2547         Reviewed by Carlos Garcia Campos.
2548
2549         Enhance TestCookieManager to ensure this doesn't happen again.
2550
2551         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2552         (testCookieManagerPersistentStorage):
2553         (beforeAll):
2554
2555 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2556
2557         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2558         https://bugs.webkit.org/show_bug.cgi?id=194324
2559
2560         Reviewed by Andy Estes.
2561
2562         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2563         part of the name is already implicit, since this is in testing code in TestOptions.
2564
2565         * WebKitTestRunner/TestController.cpp:
2566         (WTR::TestController::generateContextConfiguration const):
2567         (WTR::updateTestOptionsFromTestHeader):
2568         * WebKitTestRunner/TestOptions.h:
2569         (WTR::TestOptions::hasSameInitializationOptions const):
2570
2571 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2572
2573         [ews-build] Allow * as platform for builders and workers
2574         https://bugs.webkit.org/show_bug.cgi?id=188533
2575
2576         Reviewed by Lucas Forschler.
2577
2578         * BuildSlaveSupport/ews-build/loadConfig.py:
2579         (checkWorkersAndBuildersForConsistency):
2580
2581 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2582
2583         [ews-build] Add few bots to config.json
2584         https://bugs.webkit.org/show_bug.cgi?id=194304
2585
2586         Reviewed by Lucas Forschler.
2587
2588         * BuildSlaveSupport/ews-build/config.json:
2589
2590 2019-02-05  Keith Rollin  <krollin@apple.com>
2591
2592         Enable the automatic checking and regenerations of .xcfilelists during builds
2593         https://bugs.webkit.org/show_bug.cgi?id=194124
2594         <rdar://problem/47721277>
2595
2596         Reviewed by Tim Horton.
2597
2598         Bug 193790 add a facility for checking -- during build time -- that
2599         any needed .xcfilelist files are up-to-date and for updating them if
2600         they are not. This facility was initially opt-in by setting
2601         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2602         the process seemed robust. Its now time to enable this facility and
2603         make it opt-out. If there is a need to disable this facility, set and
2604         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2605         running `make` or `build-webkit`, or before running Xcode from the
2606         command line.
2607
2608         Additionally, remove the step that generates a list of source files
2609         going into the UnifiedSources build step. It's only necessarily to
2610         specify Sources.txt and SourcesCocoa.txt as inputs.
2611
2612         * Scripts/generate-xcfilelists:
2613
2614 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2615
2616         [GTK][WPE] force libpsl build to use ICU in jhbuild
2617         https://bugs.webkit.org/show_bug.cgi?id=194288
2618
2619         Reviewed by Philippe Normand.
2620
2621         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2622         This can cause build failures if libidn is detected but libunistring is not available.
2623
2624         Make sure that ICU is used for runtime and builtin PSL data.
2625
2626         * gtk/jhbuild.modules:
2627         * wpe/jhbuild.modules:
2628
2629 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2630
2631         [ews-app] Modified timestamp should be updated on updating data
2632         https://bugs.webkit.org/show_bug.cgi?id=194295
2633
2634         Reviewed by Lucas Forschler.
2635
2636         * BuildSlaveSupport/ews-app/ews/models/build.py:
2637         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2638         * BuildSlaveSupport/ews-app/ews/models/step.py:
2639
2640 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2641
2642         Unreviewed, rolling out r240742.
2643
2644         Causes crashes on iOS simulator.
2645
2646         Reverted changeset:
2647
2648         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2649         not focused in a content-editable element"
2650         https://bugs.webkit.org/show_bug.cgi?id=192824
2651         https://trac.webkit.org/changeset/240742
2652
2653 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2654
2655         run-webkit-tests emits message "...running None" when running tests
2656         https://bugs.webkit.org/show_bug.cgi?id=194133
2657         <rdar://problem/47724738>
2658
2659         Reviewed by Lucas Forschler.
2660
2661         * Scripts/webkitpy/xcode/device_type.py:
2662         (DeviceType.__str__): Use both version mapping tables and use just the variant
2663         name if no version name is available.
2664         * Scripts/webkitpy/xcode/device_type_unittest.py:
2665         (DeviceTypeTest):
2666         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2667         an associated named.
2668
2669 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2670
2671         [WPE] require python3-setuptools for meson build in jhbuild
2672         https://bugs.webkit.org/show_bug.cgi?id=194287
2673
2674         Reviewed by Philippe Normand.
2675
2676         python3-setuptools is needed to build meson in jhbuild.
2677         It is already required by the GTK port.
2678
2679         * wpe/install-dependencies:
2680
2681 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-app] Add method to save BuilderMapping to database
2684         https://bugs.webkit.org/show_bug.cgi?id=194264
2685
2686         Reviewed by Lucas Forschler.
2687
2688         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2689         (BuilderMapping.__str__):
2690         (BuilderMapping):
2691         (BuilderMapping.save_mapping):
2692         (BuilderMapping.update_mapping):
2693         (BuilderMapping.get_existing_mapping):
2694         (BuilderMapping.is_valid_mapping):
2695
2696 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-app] Add timestamp fields for BuilderMappings
2699         https://bugs.webkit.org/show_bug.cgi?id=194266
2700
2701         Reviewed by Lucas Forschler.
2702
2703         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2704         (BuilderMapping):
2705
2706 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2707
2708         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2709         https://bugs.webkit.org/show_bug.cgi?id=174816
2710
2711         Reviewed by Michael Catanzaro.
2712
2713         Add tests for webkit_uri_for_display().
2714
2715         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2716         (testURIForDisplayUnaffected):
2717         (testURIForDisplayAffected):
2718         (beforeAll):
2719         (afterAll):
2720         * TestWebKitAPI/glib/CMakeLists.txt:
2721
2722 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2723
2724         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2725         https://bugs.webkit.org/show_bug.cgi?id=194158
2726         <rdar://problem/47737268>
2727
2728         Rubber-stamped by Aakash Jain.
2729
2730         * Scripts/webkitpy/port/device_port.py:
2731         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2732
2733 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2734
2735         [CG] Enable setAdditionalSupportedImageTypes for WK1
2736         https://bugs.webkit.org/show_bug.cgi?id=194190
2737
2738         Reviewed by Tim Horton.
2739
2740         Add a test similar to the one under WebKit Cocoa but make it create a
2741         WebView instead of a WKWebView.
2742
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2745         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2746         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2747         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2748         (TestWebKitAPI::runTest):
2749         (TestWebKitAPI::TEST):
2750
2751 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2752
2753         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2754         https://bugs.webkit.org/show_bug.cgi?id=194168
2755
2756         Reviewed by Simon Fraser.
2757
2758         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2759
2760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2761         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2762         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2763         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2764         (TEST):
2765         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2766         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2767
2768 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2769
2770         REGRESSION (r237269): webkit-patch what-broke is broken 
2771         https://bugs.webkit.org/show_bug.cgi?id=193025
2772
2773         Reviewed by Aakash Jain.
2774
2775         * Scripts/webkitpy/common/host.py:
2776         (Host.buildbot):
2777         (Host.bugzilla): Renamed to 'buildbot'.
2778
2779 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2780
2781         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2782         https://bugs.webkit.org/show_bug.cgi?id=194207
2783
2784         Reviewed by Tim Horton.
2785
2786         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2787         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2788         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2789         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2790         start and delete forwards to remove the original attachment.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2793         (TestWebKitAPI::TEST):
2794
2795 2019-02-04  Youenn Fablet  <youenn@apple.com>
2796
2797         Capture state should be managed consistently when doing process swapping
2798         https://bugs.webkit.org/show_bug.cgi?id=194122
2799         <rdar://problem/47609293>
2800
2801         Reviewed by Eric Carlson.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2804         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2805         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2806         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2809         (WTR::TestRunner::isDoingMediaCapture const):
2810         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::TestController::isDoingMediaCapture const):
2813         * WebKitTestRunner/TestController.h:
2814         * WebKitTestRunner/TestInvocation.cpp:
2815         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2816         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2817         (WTR::TestController::isDoingMediaCapture const):
2818
2819 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2820
2821         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2822         https://bugs.webkit.org/show_bug.cgi?id=194142
2823
2824         Reviewed by Ross Kirsling.
2825
2826         There three 'separator' variables in TestController.cpp. Renamed
2827         it 'pathSeparator', and unified them.
2828
2829         * WebKitTestRunner/TestController.cpp:
2830         (WTR::TestController::generateContextConfiguration const):
2831         (WTR::createTestURL):
2832         (WTR::TestController::platformAdjustContext):
2833
2834 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2835
2836         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2837         https://bugs.webkit.org/show_bug.cgi?id=194198
2838
2839         Reviewed by Antti Koivisto.
2840
2841         No need to set the banner heights on navigation now, since Page stores them.
2842
2843         * MiniBrowser/mac/WK2BrowserWindowController.m:
2844         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2845
2846 2019-02-03  John Wilander  <wilander@apple.com>
2847
2848         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2849         https://bugs.webkit.org/show_bug.cgi?id=194104
2850         <rdar://problem/47649991>
2851
2852         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2853
2854         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2855         (TestWebKitAPI::TEST):
2856             Changed numeric types from unsigned short to uint32_t.
2857
2858 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2859
2860         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2861         <https://webkit.org/b/194178>
2862         <rdar://problem/47753473>
2863
2864         Reviewed by Alexey Proskuryakov.
2865
2866         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2867         (WTR::uninstallFakeHelvetica): Pass nullptr into
2868         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2869
2870 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2871
2872         [LFC] Initialize ICB's style with fixed width/height.
2873         https://bugs.webkit.org/show_bug.cgi?id=194188
2874
2875         Reviewed by Antti Koivisto.
2876
2877         * LayoutReloaded/misc/LFC-passing-tests.txt:
2878
2879 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2880
2881         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2882         https://bugs.webkit.org/show_bug.cgi?id=194185
2883
2884         Reviewed by Antti Koivisto.
2885
2886         * LayoutReloaded/misc/LFC-passing-tests.txt:
2887
2888 2018-12-16  Darin Adler  <darin@apple.com>
2889
2890         Convert additional String::format clients to alternative approaches
2891         https://bugs.webkit.org/show_bug.cgi?id=192746
2892
2893         Reviewed by Alexey Proskuryakov.
2894
2895         * WebKitTestRunner/TestController.cpp:
2896         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2897         as an intermediate in code that ultimately constructs a WTF::String.
2898         (WTR::userMediaOriginHash): Use makeString.
2899         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2900         (WTR::TestController::didPerformClientRedirect): Ditto.
2901         (WTR::TestController::didPerformServerRedirect): Ditto.
2902         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2903
2904 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2905
2906         [ews-build] Add unit test to verify builder keys
2907         https://bugs.webkit.org/show_bug.cgi?id=194152
2908
2909         Reviewed by Lucas Forschler.
2910
2911         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2912         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2913
2914 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2915
2916         [LFC] Expand tests coverage (12 new tests -> 787)
2917
2918         Unreviewed test gardening.
2919
2920         * LayoutReloaded/misc/LFC-passing-tests.txt:
2921
2922 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2923
2924         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2925         https://bugs.webkit.org/show_bug.cgi?id=194163
2926
2927         Reviewed by Simon Fraser.
2928
2929         775
2930
2931         * LayoutReloaded/misc/LFC-passing-tests.txt:
2932
2933 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2934
2935         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2936         https://bugs.webkit.org/show_bug.cgi?id=194140
2937         <rdar://problem/47728098>
2938
2939         Reviewed by Tim Horton.
2940
2941         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2942         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2943         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2944
2945         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2946         test to induce an IPC deadlock when presenting a modal alert during touch start.
2947
2948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2949         * WebKitTestRunner/TestController.cpp:
2950         (WTR::runJavaScriptAlert):
2951
2952         Add a client callback function for running JavaScript alerts.
2953
2954         (WTR::TestController::createOtherPage):
2955         (WTR::TestController::generateContextConfiguration const):
2956
2957         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2958         the fix in this patch.
2959
2960         (WTR::TestController::createWebViewWithOptions):
2961
2962         Plumb TestOptions to generateContextConfiguration.
2963
2964         (WTR::TestController::resetPreferencesToConsistentValues):
2965         (WTR::TestController::resetStateToConsistentValues):
2966         (WTR::updateTestOptionsFromTestHeader):
2967         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2968         (WTR::TestController::handleJavaScriptAlert):
2969         * WebKitTestRunner/TestController.h:
2970         * WebKitTestRunner/TestInvocation.cpp:
2971         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2972         * WebKitTestRunner/TestOptions.h:
2973         (WTR::TestOptions::hasSameInitializationOptions const):
2974
2975 2019-02-01  Chris Dumez  <cdumez@apple.com>
2976
2977         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2978         https://bugs.webkit.org/show_bug.cgi?id=193740
2979         <rdar://problem/47527267>
2980
2981         Reviewed by Alex Christensen.
2982
2983         Add API test coverage.
2984
2985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2986
2987 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-app] Add display name field to BuilderMapping model
2990         https://bugs.webkit.org/show_bug.cgi?id=194153
2991
2992         Reviewed by Lucas Forschler.
2993
2994         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2995         (BuilderMapping):
2996
2997 2019-02-01  Youenn Fablet  <youenn@apple.com>
2998
2999         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3000         https://bugs.webkit.org/show_bug.cgi?id=194155
3001
3002         Reviewed by Eric Carlson.
3003
3004         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3005         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3006         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3007
3008 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3009
3010         [LFC] Adjust replaced element's intrinsic ratio
3011         https://bugs.webkit.org/show_bug.cgi?id=194154
3012
3013         Reviewed by Antti Koivisto.
3014
3015         761
3016
3017         * LayoutReloaded/misc/LFC-passing-tests.txt:
3018
3019 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3020
3021         [WPE] Show test results in minibrowser
3022         https://bugs.webkit.org/show_bug.cgi?id=194150
3023
3024         Reviewed by Žan Doberšek.
3025
3026         * Scripts/webkitpy/port/wpe.py:
3027         (WPEPort.show_results_html_file):
3028
3029 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3030
3031         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3032         https://bugs.webkit.org/show_bug.cgi?id=194151
3033
3034         Reviewed by Žan Doberšek.
3035
3036         ALT + <- go back
3037         ALT + -> go forward
3038
3039         * MiniBrowser/wpe/main.cpp:
3040         (main):
3041
3042 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3043
3044         [LFC] Set intrinsic size on Layout::Replaced
3045         https://bugs.webkit.org/show_bug.cgi?id=194139
3046
3047         Reviewed by Antti Koivisto.
3048
3049         744
3050
3051         * LayoutReloaded/misc/LFC-passing-tests.txt:
3052
3053 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3054
3055         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3056         https://bugs.webkit.org/show_bug.cgi?id=194146
3057
3058         Reviewed by Xabier Rodriguez-Calvar.
3059
3060         It allows to open relative paths.
3061
3062         * MiniBrowser/wpe/main.cpp:
3063         (main):
3064
3065 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3066
3067         Update flakiness dashboard configuration after recent queue changes
3068         https://bugs.webkit.org/show_bug.cgi?id=194127
3069
3070         Rubber-stamped by Aakash Jain.
3071
3072         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3073
3074         * TestResultServer/static-dashboards/builders.jsonp:
3075
3076 2019-01-31  Youenn Fablet  <youenn@apple.com>
3077
3078         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3079         https://bugs.webkit.org/show_bug.cgi?id=194106
3080         <rdar://problem/47676333>
3081
3082         Reviewed by Ryosuke Niwa.
3083
3084         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3085         (TestWebKitAPI::didFinishNavigation):
3086         (TestWebKitAPI::TEST):
3087         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3088
3089 2019-01-31  Chris Dumez  <cdumez@apple.com>
3090
3091         Page zoom level is lost after a process swap or a crash
3092         https://bugs.webkit.org/show_bug.cgi?id=194105
3093         <rdar://problem/47610781>
3094
3095         Reviewed by Alex Christensen.
3096
3097         Add API test coverage.
3098
3099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3100         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3101
3102 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3103
3104         Revert r238819 which is unneeded and caused a performance regression.
3105         https://bugs.webkit.org/show_bug.cgi?id=192272
3106         <rdar://problem/46664625>
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3109         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3110         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3111
3112 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3113
3114         Formalize WebKitAdditions mechanism of LoadOptimizer
3115         https://bugs.webkit.org/show_bug.cgi?id=193886
3116         <rdar://problem/47696809>
3117
3118         Reviewed by Brent Fulgham.
3119
3120         * MiniBrowser/MiniBrowser.entitlements:
3121         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3122
3123 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3124
3125         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3126         https://bugs.webkit.org/show_bug.cgi?id=194090
3127
3128         Reviewed by Antti Koivisto.
3129
3130         * LayoutReloaded/misc/LFC-passing-tests.txt:
3131
3132 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3133
3134         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3135         https://bugs.webkit.org/show_bug.cgi?id=194074
3136
3137         Reviewed by Antti Koivisto.
3138
3139         * LayoutReloaded/misc/LFC-passing-tests.txt:
3140
3141 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3142
3143         [LFC][BFC] Add support for block level replaced box.
3144         https://bugs.webkit.org/show_bug.cgi?id=194071
3145
3146         Reviewed by Antti Koivisto.
3147
3148         * LayoutReloaded/misc/LFC-passing-tests.txt:
3149
3150 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3151
3152         Fix WebKitTestRunner's testPath with Windows full paths
3153         https://bugs.webkit.org/show_bug.cgi?id=194012
3154
3155         Reviewed by Alex Christensen.
3156
3157         updateTestOptionsFromTestHeader failed to open test files because
3158         testPath returned wrong file paths. It returned a path "/C:/..."
3159         if a URL "file:///C:/..." was given.
3160
3161         * WebKitTestRunner/TestController.cpp:
3162         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3163
3164 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3165
3166         [WPE] Bump font related dependencies to match the GTK+ port
3167         https://bugs.webkit.org/show_bug.cgi?id=194017
3168
3169         Reviewed by Žan Doberšek.
3170
3171         * wpe/jhbuild.modules:
3172         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3173         * wpe/patches/icudata-stdlibs.patch: Added.
3174
3175 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Enable swipe tests on iOS
3178         https://bugs.webkit.org/show_bug.cgi?id=194076
3179
3180         Reviewed by Geoffrey Garen.
3181
3182         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3183         it causes a debug assertion failure in runUIScript.
3184
3185         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3186         (WTR::UIScriptController::beginBackSwipe):
3187         (WTR::UIScriptController::completeBackSwipe):
3188
3189 2019-01-30  Keith Rollin  <krollin@apple.com>
3190
3191         Use correct printf format specifier
3192         https://bugs.webkit.org/show_bug.cgi?id=194062
3193         <rdar://problem/47686167>
3194
3195         Reviewed by Alexey Proskuryakov.
3196
3197         LayoutTestSpellChecker.mm is trying to format a variable of type
3198         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3199         actually an unsigned long long. Fix this by formatting with %llu.
3200
3201         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3202         (-[LayoutTestTextCheckingResult description]):
3203
3204 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3205
3206         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3207         https://bugs.webkit.org/show_bug.cgi?id=193979
3208
3209         Reviewed by Wenson Hsieh.
3210
3211         Fix the test for iOS. Make the test work with iOS UA string.
3212
3213         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3214
3215 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3216
3217         Replace High Sierra LLINT CLoop bot due to hardware failure
3218         https://bugs.webkit.org/show_bug.cgi?id=194066
3219
3220         Reviewed by Aakash Jain.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/config.json:
3223
3224 2019-01-30  Keith Rollin  <krollin@apple.com>
3225
3226         [NSDragItem init] is unavailable
3227         https://bugs.webkit.org/show_bug.cgi?id=194059
3228         <rdar://problem/47685715>
3229
3230         Reviewed by Wenson Hsieh.
3231
3232         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3233         DumpRenderTree and TestWebKitAPI, which both try to create an
3234         NSDragItem in a manner that invokes this method. Address this by using
3235         -initWithPasteboardWriter instead.
3236
3237         Note that the parameter passed to initWithPasteboardWriter is likely
3238         incorrect. In both cases, the object passed does not conform to
3239         NSPasteboardWriting. However, with this fix, we're no worse off than
3240         before, and can now perform builds with newer compilers and SDKs until
3241         a real fix can be crafted. That work is tracked in
3242         https://bugs.webkit.org/show_bug.cgi?id=194060
3243
3244         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3245         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3246         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3247         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3248
3249 2019-01-30  Daniel Bates  <dabates@apple.com>
3250
3251         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3252         https://bugs.webkit.org/show_bug.cgi?id=192824
3253         <rdar://problem/47100332>
3254
3255         Reviewed by Wenson Hsieh.
3256
3257         Fix a bug where the wrong usage code was used for F13 thru F24.
3258
3259         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3260         (keyCodeForDOMFunctionKey):
3261
3262 2019-01-30  Chris Dumez  <cdumez@apple.com>
3263
3264         Regression(PSON) Load hang can occur on history navigation
3265         https://bugs.webkit.org/show_bug.cgi?id=194030
3266         <rdar://problem/47656939>
3267
3268         Reviewed by Antti Koivisto.
3269
3270         Add API test coverage.
3271
3272         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3273
3274 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3275
3276         [LFC] Expand tests coverage.
3277
3278         Unreviewed test gardening.
3279
3280         * LayoutReloaded/misc/LFC-passing-tests.txt:
3281
3282 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3283
3284         [Flatpak] Add openjpeg support
3285         https://bugs.webkit.org/show_bug.cgi?id=194019
3286
3287         Reviewed by Michael Catanzaro.
3288
3289         * flatpak/org.webkit.CommonModules.yaml:
3290
3291 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3292
3293         Unreviewed, rolling out r240708.
3294         https://bugs.webkit.org/show_bug.cgi?id=194022
3295
3296         It broke WPE build (Requested by KaL on #webkit).
3297
3298         Reverted changeset:
3299
3300         "[WPE] Bump font related dependencies to match the GTK+ port"
3301         https://bugs.webkit.org/show_bug.cgi?id=194017
3302         https://trac.webkit.org/changeset/240708
3303
3304 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3305
3306         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3307         https://bugs.webkit.org/show_bug.cgi?id=194001
3308
3309         Reviewed by Antti Koivisto.
3310
3311         * LayoutReloaded/misc/LFC-passing-tests.txt:
3312
3313 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3314
3315         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3316         https://bugs.webkit.org/show_bug.cgi?id=194020
3317
3318         Reviewed by Antti Koivisto.
3319
3320         * LayoutReloaded/misc/LFC-passing-tests.txt:
3321
3322 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3323
3324         AX: Support color well on iOS
3325         https://bugs.webkit.org/show_bug.cgi?id=194010
3326
3327         Reviewed by Joanmarie Diggs.
3328
3329         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3330         (WTR::AccessibilityUIElement::stringAttributeValue):
3331
3332 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3333
3334         [WPE] Bump font related dependencies to match the GTK+ port
3335         https://bugs.webkit.org/show_bug.cgi?id=194017
3336
3337         Reviewed by Žan Doberšek.
3338
3339         * wpe/jhbuild.modules:
3340         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3341         * wpe/patches/icudata-stdlibs.patch: Added.
3342
3343 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3344
3345         [Mac] Update window scale API usage
3346         https://bugs.webkit.org/show_bug.cgi?id=193991
3347         rdar://problem/47614795
3348
3349         Reviewed by Tim Horton.
3350
3351         * DumpRenderTree/mac/DumpRenderTree.mm:
3352         (changeWindowScaleIfNeeded):
3353         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3354         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3355         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3356
3357 2019-01-29  Chris Dumez  <cdumez@apple.com>
3358
3359         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3360         https://bugs.webkit.org/show_bug.cgi?id=193977
3361         <rdar://problem/47643716>
3362
3363         Reviewed by Geoff Garen.
3364
3365         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3366         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3367         to the previous provisional committing *before* we make the last load. 
3368
3369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3370
3371 2019-01-29  Youenn Fablet  <youenn@apple.com>
3372
3373         Adopt new SPI to evaluate server certificate trust
3374         https://bugs.webkit.org/show_bug.cgi?id=193355
3375
3376         Reviewed by Alex Christensen.
3377
3378         Add infrastructure to handle HTTPS server trust evaluation testing.
3379
3380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3382         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3383         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3384         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3386         * WebKitTestRunner/TestController.cpp:
3387         (WTR::TestController::resetPreferencesToConsistentValues):
3388         (WTR::TestController::didReceiveAuthenticationChallenge):
3389         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3390         * WebKitTestRunner/TestController.h:
3391         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3392         * WebKitTestRunner/TestInvocation.cpp:
3393         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3394         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3395         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3396
3397 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3398
3399         [ews-build] Add build step to print bot Configuration
3400         https://bugs.webkit.org/show_bug.cgi?id=193887
3401
3402         Reviewed by Lucas Forschler.
3403
3404         * BuildSlaveSupport/ews-build/steps.py:
3405         (PrintConfiguration): Build step to print configuration.
3406         * BuildSlaveSupport/ews-build/factories.py:
3407
3408 2019-01-29  Chris Dumez  <cdumez@apple.com>
3409
3410         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3411         https://bugs.webkit.org/show_bug.cgi?id=193967
3412         <rdar://problem/47635348>
3413
3414         Reviewed by Alex Christensen.
3415
3416         Add API test coverage.
3417
3418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3419         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3420
3421 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3422
3423         [ews-app] Handle incoming results data
3424         https://bugs.webkit.org/show_bug.cgi?id=193973
3425
3426         Reviewed by Lucas Forschler.
3427
3428         * BuildSlaveSupport/ews-app/ews/views/results.py:
3429
3430 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3431
3432         [ews-app] Make the results url generic
3433         https://bugs.webkit.org/show_bug.cgi?id=193928
3434
3435         Reviewed by Lucas Forschler.
3436
3437         * BuildSlaveSupport/ews-app/ews/urls.py:
3438
3439 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews-build] Configure buildbot to send events to ews-app
3442         https://bugs.webkit.org/show_bug.cgi?id=193968
3443
3444         Reviewed by Lucas Forschler.
3445
3446         * BuildSlaveSupport/ews-build/events.py: Added.
3447         * BuildSlaveSupport/ews-build/master.cfg:
3448
3449 2019-01-29  Keith Rollin  <krollin@apple.com>
3450
3451         Add .xcfilelists to Run Script build phases
3452         https://bugs.webkit.org/show_bug.cgi?id=193792
3453         <rdar://problem/47201785>
3454
3455         Reviewed by Alex Christensen.
3456
3457         As part of supporting XCBuild, update the necessary Run Script build
3458         phases in their Xcode projects to refer to their associated
3459         .xcfilelist files.
3460
3461         Note that the addition of these files bumps the Xcode project version
3462         number to something that's Xcode 10 compatible. This change means that
3463         older versions of the Xcode IDE can't read these projects. Nor can it
3464         fully load workspaces that refer to these projects (the updated
3465         projects are shown as non-expandable placeholders). `xcodebuild` can
3466         still build these projects; it's just that the IDE can't open them.
3467
3468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3469         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3470
3471 2019-01-29  John Wilander  <wilander@apple.com>
3472
3473         Add data abstraction and validation for Ad Click Attribution
3474         https://bugs.webkit.org/show_bug.cgi?id=193916
3475         <rdar://problem/47603481>
3476
3477         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3478
3479         Ad click attribution has two steps. First, the storage of an ad
3480         campaign ID for a click that takes the user to a destination
3481         site. Second, a conversion on the destination site that can be
3482         attributed to the ad click.
3483
3484         This patch adds a class that represents a request for ad click
3485         attribution. Validation makes sure that the bits of entropy
3486         reported through this mechanism is limited.
3487
3488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3489         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3490         (TestWebKitAPI::TEST):
3491
3492 2019-01-29  Chris Dumez  <cdumez@apple.com>
3493
3494         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3495         https://bugs.webkit.org/show_bug.cgi?id=193932
3496         <rdar://problem/47598947>
3497
3498         Reviewed by Brady Eidson.
3499
3500         Add API test coverage.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3503
3504 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3505
3506         Adding new passing LFC tests.
3507
3508         Unreviewed test gardening.
3509
3510         * LayoutReloaded/misc/LFC-passing-tests.txt:
3511
3512 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3513
3514         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3515         https://bugs.webkit.org/show_bug.cgi?id=193964
3516
3517         Reviewed by Antti Koivisto.
3518
3519         * LayoutReloaded/misc/LFC-passing-tests.txt:
3520
3521 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3522
3523         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3524         https://bugs.webkit.org/show_bug.cgi?id=193954
3525
3526         Reviewed by Antti Koivisto.
3527
3528         * LayoutReloaded/misc/LFC-passing-tests.txt:
3529
3530 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3531
3532         WebDriver: add support for running subtests
3533         https://bugs.webkit.org/show_bug.cgi?id=193904
3534
3535         Reviewed by Michael Catanzaro.
3536
3537         pytest already supports it by passing test.py::subtest, so we can do the same.
3538
3539         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3540         (get_item_name): Made this global.
3541         (CollectRecorder.__init__): Receive the parameter to ignore.
3542         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3543         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3544         (collect): Add parameter to ignore.
3545         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3546         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3547         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3548         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3549         (WebDriverTestRunnerSelenium.run): Ditto.
3550         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3551         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3552         (WebDriverTestRunnerW3C.run): Ditto.
3553
3554 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3555
3556         User agent string override for navigator.userAgent should be site specific quirks
3557         https://bugs.webkit.org/show_bug.cgi?id=193950
3558
3559         Reviewed by Brent Fulgham.
3560
3561         Updated per the _WKWebsitePolicies rename.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3564         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3565
3566 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3567
3568         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3569         https://bugs.webkit.org/show_bug.cgi?id=193941
3570
3571         Reviewed by Alex Christensen.
3572
3573         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3574         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3575         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3576         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3577         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3578         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3579         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3580         * TestWebKitAPI/Tests/WTF/Time.cpp:
3581         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3582         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3583         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3584         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3585
3586 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3587
3588         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3589
3590         * Scripts/webkitpy/common/config/contributors.json:
3591
3592 2019-01-28  Andy Estes  <aestes@apple.com>
3593
3594         [watchOS] Enable Parental Controls content filtering
3595         https://bugs.webkit.org/show_bug.cgi?id=193939
3596         <rdar://problem/46641912>
3597
3598         Reviewed by Ryosuke Niwa.
3599
3600         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3601
3602 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3603
3604         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3605         <https://webkit.org/b/193884>
3606
3607         Reviewed by Jiewen Tan.
3608
3609         * Scripts/webkitpy/style/checkers/cpp.py:
3610         (check_language): Add LocalAuthentication to
3611         `frameworks_with_soft_links`.
3612
3613 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3614
3615         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3616         https://bugs.webkit.org/show_bug.cgi?id=193891
3617
3618         Reviewed by Ross Kirsling.
3619
3620         There were three problems in window sizes of WebView and the host window.
3621         1. The sizes of pixel image output were incorrect.
3622         2. The host window is going to appear after window.resize was invoked.
3623         3. window.resize resized only the host window, not WebView.
3624
3625         This change solves them with a following approach.
3626         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3627         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3628            as well as DumpRenderTree in order to match the client area and the window area.
3629         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3630         d. PlatformWebView::setWindowFrame changes both window sizes.
3631         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3632
3633         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3634         (WTR::PlatformWebView::PlatformWebView): Create the host window
3635         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3636         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3637         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3638
3639 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-app] Add method to save Step data to database
3642         https://bugs.webkit.org/show_bug.cgi?id=193890
3643
3644         Reviewed by Lucas Forschler.
3645
3646         * BuildSlaveSupport/ews-app/ews/models/step.py:
3647         (Step.save_step): Method to save step data.
3648         (Step.update_step): Method to update step data.
3649         (Step.get_existing_step): Method to fetch existing step from database.
3650         (Step.is_valid_result): Method to validate valid step result.
3651
3652 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3653
3654         [ews-app] Add method to save Build data to database
3655         https://bugs.webkit.org/show_bug.cgi?id=193735
3656
3657         Reviewed by Lucas Forschler.
3658
3659         * BuildSlaveSupport/ews-app/ews/models/build.py:
3660         (Build.save_build): Method to save build information to database.
3661         (Build.get_existing_build): Method to fetch existing build from database.
3662         (Build.is_valid_result): Method to validate build result.
3663         * BuildSlaveSupport/ews-app/ews/common/util.py:
3664         (is_valid_int_id): Method to validate valid id.
3665
3666 2019-01-28  Chris Dumez  <cdumez@apple.com>
3667
3668         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3669         https://bugs.webkit.org/show_bug.cgi?id=193915
3670         <rdar://problem/47560907>
3671
3672         Reviewed by Alex Christensen.
3673
3674         Add API test coverage.
3675
3676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3677
3678 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3679
3680         [ews-app] Rename id variables
3681         https://bugs.webkit.org/show_bug.cgi?id=193883
3682
3683         Reviewed by Lucas Forschler.
3684
3685         * BuildSlaveSupport/ews-app/ews/models/build.py:
3686         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3687         * BuildSlaveSupport/ews-app/ews/models/step.py:
3688         * BuildSlaveSupport/ews-app/ews/urls.py:
3689         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3690         * BuildSlaveSupport/ews-app/ews/views/results.py:
3691         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3692
3693 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3694
3695         [ews-app] Allow certain fields to be empty
3696         https://bugs.webkit.org/show_bug.cgi?id=193892
3697
3698         Reviewed by Lucas Forschler.
3699
3700         * BuildSlaveSupport/ews-app/ews/models/build.py:
3701         * BuildSlaveSupport/ews-app/ews/models/step.py:
3702
3703 2019-01-28  Rob Buis  <rbuis@igalia.com>
3704
3705         Update MIME type parser
3706         https://bugs.webkit.org/show_bug.cgi?id=180526
3707
3708         Reviewed by Frédéric Wang.
3709
3710         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3711         (TestWebKitAPI::TEST):
3712
3713 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3714
3715         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3716         https://bugs.webkit.org/show_bug.cgi?id=193896
3717
3718         Reviewed by Antti Koivisto.
3719
3720         * LayoutReloaded/misc/LFC-passing-tests.txt:
3721
3722 2018-12-15  Darin Adler  <darin@apple.com>
3723
3724         Replace many uses of String::format with more type-safe alternatives
3725         https://bugs.webkit.org/show_bug.cgi?id=192742
3726
3727         Reviewed by Mark Lam.
3728
3729         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3730         (WTR::cacheTestRunnerCallback): Use makeString.
3731         * WebKitTestRunner/TestController.cpp:
3732         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3733         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3734
3735 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3736
3737         Use a load optimizer for some sites
3738         https://bugs.webkit.org/show_bug.cgi?id=193881
3739         <rdar://problem/46325455>
3740
3741         Reviewed by Brent Fulgham.
3742
3743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3744         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3745
3746 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3747
3748         AX: Introduce a static accessibility tree
3749         https://bugs.webkit.org/show_bug.cgi?id=193348
3750         <rdar://problem/47203295>
3751
3752         Reviewed by Ryosuke Niwa.
3753
3754         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3755
3756 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3757
3758         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3759         https://bugs.webkit.org/show_bug.cgi?id=193867
3760
3761         Reviewed by Antti Koivisto.
3762
3763         * LayoutReloaded/misc/LFC-passing-tests.txt:
3764
3765 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3766
3767         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3768         https://bugs.webkit.org/show_bug.cgi?id=193865
3769
3770         Reviewed by Antti Koivisto.
3771
3772         * LayoutReloaded/misc/LFC-passing-tests.txt:
3773
3774 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3775
3776         Need a mechanism to override navigator.userAgent
3777         https://bugs.webkit.org/show_bug.cgi?id=193762
3778         <rdar://problem/47504939>
3779
3780         Reviewed by Brent Fulgham.
3781
3782         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3783
3784         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3785         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3786         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3787
3788 2019-01-25  Dean Jackson  <dino@apple.com>
3789
3790         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3791         https://bugs.webkit.org/show_bug.cgi?id=193831
3792         <rdar://problem/47399263>
3793
3794         Reviewed by Chris Dumez.
3795
3796         Two new tests that exercise cross-origin and same-origin System
3797         Previews.
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3800
3801 2019-01-25  Keith Rollin  <krollin@apple.com>
3802
3803         Update Xcode projects with "Check .xcfilelists" build phase
3804         https://bugs.webkit.org/show_bug.cgi?id=193790
3805         <rdar://problem/47201374>
3806
3807         Reviewed by Alex Christensen.
3808
3809         Support for XCBuild includes specifying inputs and outputs to various
3810         Run Script build phases. These inputs and outputs are specified as
3811         .xcfilelist files. Once created, these .xcfilelist files need to be
3812         kept up-to-date. In order to check that they are up-to-date or not,
3813         add an Xcode build step that invokes an external script that performs
3814         the checking. If the .xcfilelists are found to be out-of-date, update
3815         them, halt the build, and instruct the developer to restart the build
3816         with up-to-date files.
3817
3818         At this time, the checking and regenerating is performed only if the
3819         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3820         who want to use this facility can set this variable and test out the
3821         checking/regenerating. Once it seems like there are no egregious
3822         issues that upset a developer's workflow, we'll unconditionally enable
3823         this facility.
3824
3825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3826         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3827         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3828         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3829
3830 2019-01-25  Keith Rollin  <krollin@apple.com>
3831
3832         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3833         https://bugs.webkit.org/show_bug.cgi?id=193781
3834         <rdar://problem/47201153>
3835
3836         Reviewed by Alex Christensen.
3837
3838         Part of generating the .xcfilelists used as part of adopting XCBuild
3839         includes running `make DerivedSources.make` from a standalone script.
3840         It’s important for this invocation to have the same environment as
3841         when the actual build invokes `make DerivedSources.make`. If the
3842         environments are different, then the two invocations will provide
3843         different results. In order to get the same environment in the
3844         standalone script, have the script launch xcodebuild targeting the
3845         "Apply Configuration to XCFileLists" build target, which will then
3846         re-invoke our standalone script. The script is now running again, this
3847         time in an environment with all workspace, project, target, xcconfig
3848         and other environment variables established.
3849
3850         The "Apply Configuration to XCFileLists" build target accomplishes
3851         this task via a small embedded shell script that consists only of:
3852
3853             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3854
3855         The process that invokes "Apply Configuration to XCFileLists" first
3856         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3857         evaluated and exports it into the shell environment. When xcodebuild
3858         is invoked, it inherits the value of this variable and can `eval` the
3859         contents of that variable. Our external standalone script can then set
3860         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3861         of command-line parameters needed to restart itself in the appropriate
3862         state.
3863
3864         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3865         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3866
3867 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3868
3869         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3870         https://bugs.webkit.org/show_bug.cgi?id=193802
3871         <rdar://problem/46010580>
3872
3873         Reviewed by Andy Estes.
3874
3875         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3876         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3877         (TEST):
3878
3879 2019-01-25  Daniel Bates  <dabates@apple.com>
3880
3881         [iOS] uiController.keyDown() does not translate Control modified key
3882         https://bugs.webkit.org/show_bug.cgi?id=192898
3883
3884         Reviewed by Wenson Hsieh.
3885
3886         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3887         key translation, as applicable. Among other cases, key translation occurs when performing
3888         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3889         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3890         human pressing down and releasing key(s) using a hardware keyboard.
3891
3892         * WebKitTestRunner/ios/HIDEventGenerator.h:
3893         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3894         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3895
3896         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3897         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3898         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3899         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3900         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3901         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3902         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3903         (-[HIDEventGenerator longPress:completionBlock:]):
3904         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3905         Update code for above renaming.
3906
3907         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3908         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3909
3910         (-[HIDEventGenerator keyDown:]): Added.
3911         (-[HIDEventGenerator keyUp:]): Added.
3912         (-[HIDEventGenerator keyPress:completionBlock:]):
3913         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3914         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3915         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3916         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3917         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3918         (WTR::parseModifier): Deleted.
3919
3920 2019-01-25  Keith Rollin  <krollin@apple.com>
3921
3922         Complete the implementation of generate-xcfilelists
3923         https://bugs.webkit.org/show_bug.cgi?id=193782
3924
3925         Reviewed by Alex Christensen.
3926
3927         A preliminary version of generate-xcfilelists was added in r238008.
3928         This patch updates that script in order to:
3929
3930         - Support checking of .xcfilelists
3931         - Perform better execution of `make DerivedSources.make` by
3932           relaunching generate-xcfilelists under xcodebuild
3933         - Support incremental generation and checking of .xcfilelists
3934         - Support supplementary .xcfilelists files from WebKitAdditions
3935         - Support being wrapped by parallel version of generate-xcfilelists in
3936           Internal that adds support for (re)generating WebKit projects in
3937           that repo.
3938         - Support builds that have been performed in WebKitBuild as well as
3939           ~/Library/Developer/code/DerivedData
3940         - Increase robustness and debugging facilities.
3941
3942         * Scripts/generate-xcfilelists:
3943
3944 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3945
3946         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3947         https://bugs.webkit.org/show_bug.cgi?id=193297
3948         <rdar://problem/47158841>
3949
3950         Unreviewed test case fix.
3951
3952         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3953         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3954
3955         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3956         (TEST):
3957
3958 2019-01-25  Keith Rollin  <krollin@apple.com>
3959
3960         Update existing .xcfilelists
3961         https://bugs.webkit.org/show_bug.cgi?id=193791
3962         <rdar://problem/47201706>
3963
3964         Reviewed by Alex Christensen.
3965
3966         Many .xcfilelist files were added in r238824 in order to support
3967         XCBuild. Update these with recent changes to the set of build files
3968         and with the current generate-xcfilelist script.
3969
3970         * DumpRenderTree/DerivedSources-input.xcfilelist:
3971         * DumpRenderTree/DerivedSources-output.xcfilelist:
3972         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3973         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3974
3975 2019-01-25  Keith Rollin  <krollin@apple.com>
3976
3977         Fix missing dependencies in extract-dependencies-from-makefile
3978         https://bugs.webkit.org/show_bug.cgi?id=193783
3979         <rdar://problem/47201571>
3980
3981         Reviewed by Alex Christensen.
3982
3983         The extract-dependencies-from-makefile script generates .xcfilelists
3984         for XCBuild by invoking a makefile in --debug mode, parsing the
3985         dependency information in the output, and extracting information
3986         regarding targets and dependents. However, the way `make` emits this
3987         dependency information is not rigorous, and so we need to determine
3988         what lines to look for and parse by trial and error. This approach
3989         didn't coriginally atch all the information we needed to collect, so
3990         update the script to look for the additional lines we now know to look
3991         for.
3992
3993         * Scripts/extract-dependencies-from-makefile:
3994         (Parser):
3995         (Parser.addTarget):
3996         (Parser.addPrereq):
3997         (Parser.doParse):
3998
3999 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4000
4001         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4002         https://bugs.webkit.org/show_bug.cgi?id=193297
4003         <rdar://problem/47158841>
4004
4005         Reviewed by Alex Christensen.
4006
4007         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4008             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4010         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4011         activating the message used to trigger the callback when it is set.
4012
4013 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4014
4015         WKWebView.goBack should reload if there is a safe browsing warning
4016         https://bugs.webkit.org/show_bug.cgi?id=193805
4017         <rdar://problem/46908216>
4018
4019         Reviewed by Geoff Garen.
4020
4021         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4022         (+[Simple3LookupContext sharedLookupContext]):
4023         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4024         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4025         (TEST):
4026
4027 2019-01-25  Chris Dumez  <cdumez@apple.com>
4028
4029         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4030         https://bugs.webkit.org/show_bug.cgi?id=193788
4031         <rdar://problem/47531231>
4032
4033         Reviewed by Alex Christensen.
4034
4035         Add API test coverage.
4036
4037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4038         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4039
4040 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4041
4042         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4043         https://bugs.webkit.org/show_bug.cgi?id=193771
4044
4045         Unreviewed infrastructure fix.
4046
4047         * Scripts/webkitpy/port/darwin.py:
4048         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4049
4050 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4051
4052         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4053
4054 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4055
4056         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4057
4058         * Scripts/webkitpy/common/config/contributors.json:
4059
4060 2019-01-25  Chris Dumez  <cdumez@apple.com>
4061
4062         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4063         https://bugs.webkit.org/show_bug.cgi?id=193779
4064         <rdar://problem/46170903>
4065
4066         Reviewed by Antti Koivisto.
4067
4068         Add API test that quickly navigates forward to a previous process without waiting for it to
4069         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4070         the process' previous page when reconnecting the it for the forward navigation.
4071
4072         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4073
4074 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4075
4076         Need a way for JavaScript (or bundle) code to participate in undo
4077         https://bugs.webkit.org/show_bug.cgi?id=190009
4078         <rdar://problem/44807048>
4079
4080         Reviewed by Ryosuke Niwa.
4081
4082         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4083         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4084
4085         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4086         (WTR::UIScriptController::lastUndoLabel const):
4087         (WTR::UIScriptController::firstRedoLabel const):
4088         (WTR::UIScriptController::platformUndoManager const):
4089         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4090         (WTR::UIScriptController::lastUndoLabel const):
4091         (WTR::UIScriptController::firstRedoLabel const):
4092         (WTR::UIScriptController::platformUndoManager const):
4093         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4094         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4095         (WTR::UIScriptController::lastUndoLabel const):
4096         (WTR::UIScriptController::firstRedoLabel const):
4097         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4098         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4099         (WTR::UIScriptController::lastUndoLabel const):
4100         (WTR::UIScriptController::firstRedoLabel const):
4101         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4102         (WTR::UIScriptController::platformUndoManager const):
4103         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4104         (WTR::UIScriptController::platformUndoManager const):
4105
4106 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4107
4108         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4109         https://bugs.webkit.org/show_bug.cgi?id=193824
4110
4111         Reviewed by Antti Koivisto.
4112
4113         * LayoutReloaded/misc/LFC-passing-tests.txt:
4114
4115 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4116
4117         Update macOS JSC bot configurations
4118         https://bugs.webkit.org/show_bug.cgi?id=193739
4119
4120         Reviewed by Alexey Proskuryakov.
4121
4122         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4124         (BubbleQueueServer): Move JSC EWS to Mojave section.
4125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4126         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4127         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4128
4129 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4130
4131         [Win][WebKitTestRunner] Implement EventSenderProxy
4132         https://bugs.webkit.org/show_bug.cgi?id=193755
4133
4134         Reviewed by Don Olmstead.
4135
4136         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4137         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4138         (WTR::EventSenderProxy::dispatchMessage):
4139         (WTR::EventSenderProxy::EventSenderProxy):
4140         (WTR::EventSenderProxy::mouseDown):
4141         (WTR::EventSenderProxy::mouseUp):
4142         (WTR::EventSenderProxy::mouseMoveTo):
4143         (WTR::EventSenderProxy::mouseScrollBy):
4144         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4145
4146 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4147
4148         Unreviewed fix for API test failure after r240437.
4149
4150         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4151
4152         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4153
4154 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4155
4156         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4157         https://bugs.webkit.org/show_bug.cgi?id=193787
4158         <rdar://problem/47497634>
4159
4160         Reviewed by Alexey Proskuryakov.
4161
4162         * Scripts/webkitdirs.pm:
4163         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4164
4165 2019-01-24  Truitt Savell  <tsavell@apple.com>
4166
4167         Unreviewed, rolling out r240446.
4168
4169         Casued 5 API failures
4170
4171         Reverted changeset:
4172
4173         "Activate the WebResourceLoadStatisticsStore in the
4174         NetworkProcess and deactivate it in the UIProcess."
4175         https://bugs.webkit.org/show_bug.cgi?id=193297
4176         https://trac.webkit.org/changeset/240446
4177
4178 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4179
4180         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4181         https://bugs.webkit.org/show_bug.cgi?id=193741
4182         <rdar://problem/47135030>
4183
4184         Reviewed by Antti Koivisto and Simon Fraser.
4185
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4188         (TestWebKitAPI::TEST):
4189
4190 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4191
4192         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4193         https://bugs.webkit.org/show_bug.cgi?id=193297
4194         <rdar://problem/47158841>
4195
4196         Reviewed by Alex Christensen.
4197
4198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4199         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4200         activating the message used to trigger the callback when it is set.
4201
4202 2019-01-24  John Wilander  <wilander@apple.com>
4203
4204         Add Ad Click Attribution as an internal/experimental feature
4205         https://bugs.webkit.org/show_bug.cgi?id=193685
4206         <rdar://problem/47450399>
4207
4208         Reviewed by Brent Fulgham.
4209
4210         Added test option adClickAttributionEnabled.
4211
4212         * DumpRenderTree/TestOptions.cpp:
4213         (TestOptions::TestOptions):
4214         * DumpRenderTree/TestOptions.h:
4215         * DumpRenderTree/mac/DumpRenderTree.mm:
4216         (setWebPreferencesForTestOptions):
4217
4218 2019-01-24  Antti Koivisto  <antti@apple.com>
4219
4220         [PSON] Flash on back navigation on Mac
4221         https://bugs.webkit.org/show_bug.cgi?id=193716
4222         <rdar://problem/47148458>
4223
4224         Reviewed by Chris Dumez.
4225
4226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4227
4228         Closing of the previous page is delayed so waiting for didFinishNavigation is
4229         not sufficient to guarantee we have received all the messages. Wait for them.
4230
4231 2019-01-24  Chris Dumez  <cdumez@apple.com>
4232
4233         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4234         https://bugs.webkit.org/show_bug.cgi?id=193761
4235         <rdar://problem/47456405>
4236
4237         Reviewed by Alex Christensen.
4238
4239         Add API test coverage.
4240
4241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4242
4243 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4244
4245         webkitpy: Missing PID in crashlog name should not be fatal
4246         https://bugs.webkit.org/show_bug.cgi?id=193771
4247
4248         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4249         of raising an exception.
4250
4251         Reviewed by Lucas Forschler.
4252
4253         * Scripts/webkitpy/port/darwin.py:
4254         (DarwinPort._merge_crash_logs):
4255
4256 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4257
4258         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4259         https://bugs.webkit.org/show_bug.cgi?id=193746
4260
4261         Reviewed by Youenn Fablet.
4262
4263         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4264         so we'd best just not call it.
4265
4266         * Scripts/webkitpy/w3c/test_exporter.py:
4267         (WebPlatformTestExporter.create_branch_with_patch):
4268
4269 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4270
4271         Move FileSystem to WTF
4272         https://bugs.webkit.org/show_bug.cgi?id=193602
4273
4274         Reviewed by Yusuke Suzuki.
4275
4276         * DumpRenderTree/win/DumpRenderTree.cpp:
4277         * TestWebKitAPI/CMakeLists.txt:
4278         * TestWebKitAPI/PlatformGTK.cmake:
4279         * TestWebKitAPI/PlatformJSCOnly.cmake:
4280         * TestWebKitAPI/PlatformPlayStation.cmake:
4281         * TestWebKitAPI/PlatformWPE.cmake:
4282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4283         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4284         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4285         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4286         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4287         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4288         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4289         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4290         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4291         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4292
4293 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4294
4295         [WPE] Remove hard dependency on subprocess32 for the API tests
4296
4297         Rubber-stamped by Carlos Garcia Campos.
4298
4299         * glib/api_test_runner.py:
4300         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4301         its presence only when running WPEQt tests.
4302
4303 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4304
4305         [GLIB] Expose JavaScriptCore options in GLib public API
4306         https://bugs.webkit.org/show_bug.cgi?id=188742
4307
4308         Reviewed by Michael Catanzaro.
4309
4310         Add a test for the new API.
4311
4312         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4313         (testsJSCOptions):
4314         (main):
4315
4316 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4317
4318         [GTK][WPE] Support JPEG 2000 images
4319         https://bugs.webkit.org/show_bug.cgi?id=186272
4320
4321         Reviewed by Žan Doberšek.
4322
4323         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4324
4325         * gtk/jhbuild.modules:
4326         * wpe/jhbuild.modules:
4327
4328 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4329
4330         check-webkit-style should warn when using soft-linking macros in a header
4331         <https://webkit.org/b/193750>
4332
4333         Reviewed by Darin Adler.
4334
4335         * Scripts/webkitpy/style/checkers/cpp.py:
4336         (check_language): Add softlink/header check by refactoring the
4337         softlink/framework check.
4338         (CppChecker): Enable softlink/header check by default.
4339         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4340         (CppStyleTest.test_softlink_framework): Rename from
4341         CppStyleTest.test_softlink() and change test framework name in
4342         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4343         files. Set file_name for macros that only appear in headers.
4344         (CppStyleTest.test_softlink_header): Add tests for using
4345         soft-link macros in headers.
4346
4347 2019-01-23  Chris Dumez  <cdumez@apple.com>
4348
4349         Deprecate API to limit the maximum number of WebProcesses
4350         https://bugs.webkit.org/show_bug.cgi?id=193725
4351         <rdar://problem/47464879>
4352
4353         Reviewed by Geoff Garen.
4354
4355         Update existing API tests to stop using deprecated API.
4356
4357         * MiniBrowser/mac/AppDelegate.m:
4358         (defaultConfiguration):
4359         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4360         (TestWebKitAPI::TEST):
4361         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4362         (TestWebKitAPI::TEST):
4363         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4364         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4365         (TEST):
4366         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4367         (TEST):
4368