[ews-build] Do not run clean build by default on EWS builders
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Do not run clean build by default on EWS builders
4         https://bugs.webkit.org/show_bug.cgi?id=196897
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
10         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
11         untracked directories like WebKitBuild).
12         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
13         untracked files/directories (like WebKitBuild).
14
15 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
16
17         TestRunner::notifyDone() should be safely reentrant
18         https://bugs.webkit.org/show_bug.cgi?id=196898
19
20         Reviewed by Darin Adler.
21
22         It is currently possible that TestRunner::notifyDone() will call itself, since
23         notifyDone() will force a repaint, which can start executing JavaScript, which
24         may call notifyDone() again. This can lead to test failures and flakiness.
25         Fix this by setting the m_waitToDump flag before calling the dump() method.
26
27         * DumpRenderTree/mac/TestRunnerMac.mm:
28         (TestRunner::notifyDone):
29         (TestRunner::forceImmediateCompletion):
30         * DumpRenderTree/win/TestRunnerWin.cpp:
31         (TestRunner::notifyDone):
32         (TestRunner::forceImmediateCompletion):
33
34 2019-04-15  Philippe Normand  <pnormand@igalia.com>
35
36         [GTK][WPE] Add enable-media websetting
37         https://bugs.webkit.org/show_bug.cgi?id=196863
38
39         Reviewed by Michael Catanzaro.
40
41         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
42         (testWebKitSettings): Add test for the enable-media web-setting.
43
44 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
45
46         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
47         https://bugs.webkit.org/show_bug.cgi?id=196905
48         <rdar://problem/49886096>
49
50         Reviewed by Tim Horton.
51
52         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
53         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
54         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
55         delay timer, we end up with this sequence of events in the problematic (failure) case:
56
57         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
58             ...IPC from UI to web process...
59         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
60             ...IPC from web to UI process...
61         (c) [UI]    Invoke completion handler for script #1
62         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
63             ...IPC from UI to web process...
64         (e) [Web]   Evaluate script #2 in the web process
65         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
66
67         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
68         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
69         #2 is run in step (e).
70
71         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
72         the UI process by waiting on a script message posted by the web process, after attachment updates are
73         dispatched.
74
75         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
76         (TestWebKitAPI::TEST):
77
78 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
79
80         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
81         https://bugs.webkit.org/show_bug.cgi?id=196909
82
83         Reviewed by Wenson Hsieh.
84
85         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
86         (TestWebKitAPI::TEST):
87
88 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
89
90         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
91         https://bugs.webkit.org/show_bug.cgi?id=196880
92
93         Reviewed by Yusuke Suzuki.
94
95         Add a new function for bytecode cache tests that does not forceDiskCache
96         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
97         test added in this patch, since the code is invalid and therefore won't be
98         cached. It should also be useful for tests that evaluate dynamically
99         generated code.
100
101         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
102         * Scripts/run-jsc-stress-tests:
103
104 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
105
106         Update AudioSession route sharing policy
107         https://bugs.webkit.org/show_bug.cgi?id=196776
108         <rdar://problem/46501611>
109
110         Reviewed by Jer Noble.
111
112         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
113         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
114         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
115         (TestWebKitAPI::TEST):
116
117 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         [iOS] Software keyboard is shown too frequently on some websites
120         https://bugs.webkit.org/show_bug.cgi?id=195856
121         <rdar://problem/49191395>
122
123         Reviewed by Darin Adler.
124
125         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
126
127         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
128         (WTR::UIScriptController::setHardwareKeyboardAttached):
129         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
130         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
131         (WTR::UIScriptController::setHardwareKeyboardAttached):
132         * TestRunnerShared/UIScriptContext/UIScriptController.h:
133         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
134
135         Additionally link against GraphicsServices in WebKitTestRunner.
136
137         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
138         (WTR::TestController::platformResetStateToConsistentValues):
139         (WTR::UIScriptController::setHardwareKeyboardAttached):
140
141 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
142
143         [GTK][WPE] Fix pacman install-dependencies packages
144         https://bugs.webkit.org/show_bug.cgi?id=196817
145
146         Reviewed by Žan Doberšek.
147         
148         python3-setuptools is called python-setuptools
149         ruby-highline is only available on AUR
150         libv4l-devel is incorporated in v4l-utils
151
152         * gtk/install-dependencies:
153         * wpe/install-dependencies:
154
155 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
156
157         [GTK] REGRESSION(r243860): Many tests failing
158         https://bugs.webkit.org/show_bug.cgi?id=196791
159
160         Reviewed by Joanmarie Diggs.
161
162         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
163         multiple documents and check that accessibility hierarchy is updated after a navigation.
164
165         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
166         (loadChangedCallback):
167         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
168         (AccessibilityTest::AccessibilityTest):
169         (AccessibilityTest::~AccessibilityTest):
170         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
171         (AccessibilityTest::findTestServerApplication):
172         (AccessibilityTest::findDocumentWeb):
173         (AccessibilityTest::findRootObject):
174         (AccessibilityTest::waitUntilChildrenRemoved):
175         (AccessibilityTest::ensureProxy):
176         (testAtspiBasicHierarchy):
177         (beforeAll):
178         (afterAll):
179
180 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-build] Handle bug titles with unicode characters
183         https://bugs.webkit.org/show_bug.cgi?id=196802
184
185         Reviewed by Dewei Zhu.
186
187         * BuildSlaveSupport/ews-build/steps.py:
188         (ValidatePatch._is_bug_closed):
189
190 2019-04-11  Michael Saboff  <msaboff@apple.com>
191
192         Improve the Inline Cache Stats code
193         https://bugs.webkit.org/show_bug.cgi?id=196836
194
195         Reviewed by Saam Barati.
196
197         Added a new script to consolidate and arrange the output of --useICStats option.
198
199         This script merges the output from every group into one large table and sorts it from most common to
200         least common.  It also counts the slow path GetById and PutById variants and then calculates the
201         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
202         Put together, this is useful to see what property accesses are not getting cached.
203
204         * Scripts/ic-stats.py: Added.
205         (ICStats):
206         (ICStats.__init__):
207         (ICStats.parse):
208         (ICStats.dumpStats):
209         (usage):
210
211 2019-04-10  Alex Christensen  <achristensen@webkit.org>
212
213         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
214         https://bugs.webkit.org/show_bug.cgi?id=196809
215         <rdar://49800762>
216
217         Reviewed by Brady Eidson.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
220         (TEST):
221
222 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
223
224         requestAnimationFrame should execute before the next frame
225         https://bugs.webkit.org/show_bug.cgi?id=177484
226
227         Reviewed by Simon Fraser.
228
229         Add trace points for the page RenderingUpdate.
230
231         * Tracing/SystemTracePoints.plist:
232
233 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
234
235         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
236         https://bugs.webkit.org/show_bug.cgi?id=196760
237
238         Reviewed by Don Olmstead.
239
240         vswhere.exe has been bundled since Visual Studio 2017 version
241         15.2. We shouldn't download vswhere.exe.
242
243         * Scripts/build-jsc: Do not call update-vswhere.py.
244         * Scripts/build-webkit: Ditto.
245         * Scripts/update-vswhere.py: Removed.
246         * Scripts/webkitdirs.pm:
247         (requireModulesForVSWhere): Deleted.
248         (pickCurrentVisualStudioInstallation): Deleted.
249         (visualStudioInstallDirVSWhere): Return the latest installed VS
250         installation path by using the bundled vswhere.exe.
251         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
252         (visualStudioInstallDirFallback): Removed.
253
254 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
255
256         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
257         https://bugs.webkit.org/show_bug.cgi?id=196780
258
259         Reviewed by Alexey Proskuryakov.
260
261         * BuildSlaveSupport/ews-build/steps.py:
262         * BuildSlaveSupport/ews-build/steps_unittest.py:
263
264 2019-04-10  Alex Christensen  <achristensen@webkit.org>
265
266         Add SPI WKNavigationResponse._downloadAttribute
267         https://bugs.webkit.org/show_bug.cgi?id=196755
268         <rdar://49587365>
269
270         Reviewed by Brady Eidson.
271
272         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
273         (-[NavigationResponseTestDelegate navigationResponse]):
274         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
275         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
276         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
277         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
278         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
279         (readRequest):
280         (writeResponse):
281         (TEST):
282
283 2019-04-10  Tim Horton  <timothy_horton@apple.com>
284
285         Add modern API for overriding the page's specified viewport configuration
286         https://bugs.webkit.org/show_bug.cgi?id=167734
287         <rdar://problem/30331795>
288
289         Reviewed by Simon Fraser.
290
291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
292         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
293
294 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
295
296         Add support for incremental bytecode cache updates
297         https://bugs.webkit.org/show_bug.cgi?id=195000
298
299         Reviewed by Filip Pizlo.
300
301         Exit when the initial run to generate bytecode fails.
302
303         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
304
305 2019-04-10  Alex Christensen  <achristensen@webkit.org>
306
307         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
308         https://bugs.webkit.org/show_bug.cgi?id=196744
309         <rdar://49415309>
310
311         Reviewed by Chris Dumez.
312
313         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
314         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
315
316 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
317
318         Add a way to opt into modern compatibility mode in layout tests
319         https://bugs.webkit.org/show_bug.cgi?id=196770
320         <rdar://problem/49777550>
321
322         Reviewed by Antoine Quint.
323
324         Add a new test option to enable modern compatibility mode in layout tests.
325
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::updateTestOptionsFromTestHeader):
328         * WebKitTestRunner/TestController.h:
329         * WebKitTestRunner/TestOptions.h:
330         (WTR::TestOptions::hasSameInitializationOptions const):
331         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
332         (WTR::TestController::platformCreateWebView):
333         (WTR::TestController::enableModernCompatibilityMode):
334
335 2019-04-10  Andy Estes  <aestes@apple.com>
336
337         Try to fix the 32-bit watchOS build.
338
339         * TestWebKitAPI/cocoa/TestWKWebView.mm:
340         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
341
342 2019-04-10  Antoine Quint  <graouts@apple.com>
343
344         Enable Pointer Events on watchOS
345         https://bugs.webkit.org/show_bug.cgi?id=196771
346         <rdar://problem/49040909>
347
348         Reviewed by Dean Jackson.
349
350         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
351
352 2019-04-10  Philippe Normand  <pnormand@igalia.com>
353
354         Unreviewed. Fix WPE accessibility tests after r244059.
355
356         We are failing to load the injected bundle due to undefined symbol
357         AccessibilityUIElement::replaceTextInRange().
358
359         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
360         (WTR::AccessibilityUIElement::replaceTextInRange):
361
362 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
363
364         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
365         https://bugs.webkit.org/show_bug.cgi?id=196727
366
367         Reviewed by Fujii Hironori.
368
369         * MiniBrowser/win/WebKitBrowserWindow.cpp:
370         (WebKitBrowserWindow::create):
371
372 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
373
374         [ews-build] Add unit tests for PrintConfiguration
375         https://bugs.webkit.org/show_bug.cgi?id=196752
376
377         Reviewed by Dewei Zhu.
378
379         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
380
381 2019-04-09  Keith Rollin  <krollin@apple.com>
382
383         Unreviewed build maintenance -- update .xcfilelists.
384
385         * DumpRenderTree/DerivedSources-input.xcfilelist:
386         * DumpRenderTree/DerivedSources-output.xcfilelist:
387
388 2019-04-09  Zalan Bujtas  <zalan@apple.com>
389
390         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
391         https://bugs.webkit.org/show_bug.cgi?id=196743
392         <rdar://problem/43897551>
393
394         Reviewed by Tim Horton.
395
396         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
397         (TEST):
398
399 2019-04-09  Youenn Fablet  <youenn@apple.com>
400
401         Close service worker database on network process suspension
402         https://bugs.webkit.org/show_bug.cgi?id=196623
403         <rdar://problem/48930869>
404
405         Reviewed by Alex Christensen.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
408
409 2019-04-09  Daniel Bates  <dabates@apple.com>
410
411         [iPad] Should open popover when the spacebar is pressed
412         https://bugs.webkit.org/show_bug.cgi?id=196360
413         <rdar://problem/49389129>
414
415         Reviewed by Brent Fulgham.
416
417         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
418
419         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
420         (WTR::UIScriptController::isShowingPopover const): Added.
421         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
422         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
423         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
424         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
425         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
426         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
427         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
428         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
429         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
430         (WTR::UIScriptController::isShowingPopover const): Added.
431         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
432         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
433         * TestRunnerShared/UIScriptContext/UIScriptController.h:
434         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
435         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
436         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
437         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
438         (-[TestRunnerWKWebView _willPresentPopover]): Added.
439         (-[TestRunnerWKWebView _didDismissPopover]): Added.
440         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
441         (WTR::UIScriptController::isShowingPopover const): Added.
442         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
443         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
444
445 2019-04-09  Alex Christensen  <achristensen@webkit.org>
446
447         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
448         https://bugs.webkit.org/show_bug.cgi?id=196665
449         <rdar://45115669>
450
451         Reviewed by Geoff Garen.
452
453         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
454         (goBack):
455         (+[SimpleLookupContext sharedLookupContext]):
456         (-[SimpleLookupContext lookUpURL:completionHandler:]):
457         (TEST):
458         (+[Simple3LookupContext sharedLookupContext]): Deleted.
459         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
460
461 2019-04-09  John Wilander  <wilander@apple.com>
462
463         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
464         https://bugs.webkit.org/show_bug.cgi?id=196558
465         <rdar://problem/47650245>
466
467         Reviewed by Youenn Fablet.
468
469         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
470         (TestWebKitAPI::TEST):
471             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
472
473 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
474
475         [CMake] Apple builds should use ICU_INCLUDE_DIRS
476         https://bugs.webkit.org/show_bug.cgi?id=196720
477
478         Reviewed by Konstantin Tokarev.
479
480         * TestWebKitAPI/PlatformMac.cmake:
481
482 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
483
484         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
485         https://bugs.webkit.org/show_bug.cgi?id=196694
486         <rdar://problem/48388734>
487
488         Rubber-stamped by Aakash Jain.
489
490         * Scripts/webkitpy/port/image_diff.py:
491         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
492         * Scripts/webkitpy/port/server_process.py:
493         (ServerProcess.has_available_stdout): Check if stdout has data in it.
494         (ServerProcess._wait_for_data_and_update_buffers_using_select):
495         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
496         * Scripts/webkitpy/port/server_process_mock.py:
497         (MockServerProcess.has_available_stdout):
498         * Scripts/webkitpy/port/server_process_unittest.py:
499         (TestServerProcess.serial_test_basic):
500
501 2019-04-09  Jer Noble  <jer.noble@apple.com>
502
503         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
504         https://bugs.webkit.org/show_bug.cgi?id=196097
505
506         Reviewed by Eric Carlson.
507
508         Drive-by bug fix: allow tests to play audio without a user gesture by default.
509
510         * DumpRenderTree/mac/DumpRenderTree.mm:
511         (resetWebPreferencesToConsistentValues):
512         * WebKitTestRunner/TestController.cpp:
513         (WTR::TestController::resetPreferencesToConsistentValues):
514
515 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
516
517         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
518         https://bugs.webkit.org/show_bug.cgi?id=196690
519
520         Reviewed by Michael Catanzaro.
521
522         * QueueStatusServer/config/queues.py:
523         * Scripts/webkitpy/common/config/ews.json:
524         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
525         (test_ews_name):
526
527 2019-04-09  Chris Dumez  <cdumez@apple.com>
528
529         Loads using loadHTMLString() cause flashing when process-swapping
530         https://bugs.webkit.org/show_bug.cgi?id=196714
531         <rdar://problem/49637354>
532
533         Reviewed by Antti Koivisto.
534
535         Add API test coverage.
536
537         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
538
539 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
540
541         Unreviewed. Fix ATK accessibility tests after r244059.
542
543         We are failing to load the injected bundle due to undefined symbol
544         AccessibilityUIElement::replaceTextInRange().
545
546         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
547         (WTR::AccessibilityUIElement::replaceTextInRange):
548
549 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
550
551         AX: Support API: accessibilityReplaceRange:withText
552         https://bugs.webkit.org/show_bug.cgi?id=196636
553
554         Unreviewed build fix for Windows port.
555
556         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
557         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
558
559 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
560
561         [CMake][WinCairo] Separate copied headers into different directories
562         https://bugs.webkit.org/show_bug.cgi?id=196655
563
564         Reviewed by Michael Catanzaro.
565
566         * DumpRenderTree/CMakeLists.txt:
567         * MiniBrowser/win/CMakeLists.txt:
568         * TestWebKitAPI/CMakeLists.txt:
569         * TestWebKitAPI/PlatformWin.cmake:
570
571 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
572
573         Log stack-trace for run-webkit-tests when interrupted
574         https://bugs.webkit.org/show_bug.cgi?id=176393
575         <rdar://problem/34262310>
576
577         Reviewed by Lucas Forschler.
578
579         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
580         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
581         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
582         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
583         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
584         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
585         (main): Set handlers to log stack trace on interruption.
586
587 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
588
589         AX: Support API: accessibilityReplaceRange:withText
590         https://bugs.webkit.org/show_bug.cgi?id=196636
591
592         Unreviewed build fix for Windows port.
593
594         * DumpRenderTree/AccessibilityUIElement.cpp:
595         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
596
597 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-build] Scripts using Buildbot API have CORS error
600         https://bugs.webkit.org/show_bug.cgi?id=196709
601
602         Reviewed by Alexey Proskuryakov.
603
604         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
605
606 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
607
608         AX: Support API: accessibilityReplaceRange:withText
609         https://bugs.webkit.org/show_bug.cgi?id=196636
610
611         Reviewed by Daniel Bates.
612
613         * DumpRenderTree/AccessibilityUIElement.cpp:
614         (replaceTextInRangeCallback):
615         (AccessibilityUIElement::replaceTextInRange):
616         (AccessibilityUIElement::getJSClass):
617         * DumpRenderTree/AccessibilityUIElement.h:
618         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
619         (AccessibilityUIElement::replaceTextInRange):
620         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
621         (AccessibilityUIElement::replaceTextInRange):
622         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
623         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
624         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
625         (WTR::AccessibilityUIElement::replaceTextInRange):
626         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
627         (WTR::AccessibilityUIElement::replaceTextInRange):
628
629 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
630
631         [iOS] Do not allow starting selection drags when selection views are not visible
632         https://bugs.webkit.org/show_bug.cgi?id=196686
633         <rdar://problem/49399192>
634
635         Reviewed by Tim Horton.
636
637         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
638         also add some new API tests to cover scenarios where the web view is not first responder.
639
640         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
641         (TestWebKitAPI::TEST):
642         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
643
644         Add a switch to optionally make the web view first responder when starting the simulated drag.
645
646         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
647         (-[DragAndDropSimulator initWithWebView:]):
648         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
649
650 2019-04-08  Justin Fan  <justin_fan@apple.com>
651
652         [Web GPU] Fix Web GPU experimental feature on iOS
653         https://bugs.webkit.org/show_bug.cgi?id=196632
654
655         Reviewed by Myles C. Maxfield.
656
657         Properly make Web GPU available on iOS 11+.
658
659         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
660
661 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
662
663         [ews-build] Do not upload archive when Compile Fails
664         https://bugs.webkit.org/show_bug.cgi?id=196674
665
666         Reviewed by Alexey Proskuryakov.
667
668         * BuildSlaveSupport/ews-build/factories.py:
669         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
670         * BuildSlaveSupport/ews-build/steps.py:
671         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
672         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
673         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
674
675 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
676
677         Enable DFG on MIPS
678         https://bugs.webkit.org/show_bug.cgi?id=196689
679
680         Reviewed by Žan Doberšek.
681
682         Since the bytecode change, we enabled the baseline JIT on mips in
683         r240432, but DFG is still missing. With this change, all tests are
684         passing on a ci20 board.
685
686         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
687
688 2019-04-08  Philippe Normand  <pnormand@igalia.com>
689
690         [Flatpak] Second run update-webkitwpe-flatpak fails
691         https://bugs.webkit.org/show_bug.cgi?id=192702
692
693         Reviewed by Carlos Garcia Campos.
694
695         * flatpak/flatpakutils.py:
696         (FlatpakObject.flatpak): Fix typo.
697         (FlatpakPackage.install): When installing, also update to the configured remote commit.
698         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
699
700 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
701
702         [GTK][WPE] outlook.live.com displays old-fashioned UI
703         https://bugs.webkit.org/show_bug.cgi?id=196642
704
705         Reviewed by Carlos Garcia Campos.
706
707         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
708         (TestWebKitAPI::TEST): New Mac platform quirk test.
709
710 2019-04-07  Commit Queue  <commit-queue@webkit.org>
711
712         Unreviewed, rolling out r243956.
713         https://bugs.webkit.org/show_bug.cgi?id=196688
714
715         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
716         by aakashjain on #webkit).
717
718         Reverted changeset:
719
720         "Clicking "Go Back" from a safe browsing warning from an
721         iframe should navigate the WKWebView back to the previous
722         page"
723         https://bugs.webkit.org/show_bug.cgi?id=196665
724         https://trac.webkit.org/changeset/243956
725
726 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
727
728         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
729         https://bugs.webkit.org/show_bug.cgi?id=196669
730
731         Reviewed by Geoffrey Garen.
732
733         Added three new unit tests for WeakHashSet.
734
735         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
736         (WTF_WeakPtr.WeakHashSetConstObjects):
737         (WTF_WeakPtr.WeakHashSetComputesEmpty):
738         (WTF_WeakPtr.WeakHashSetComputeSize):
739
740 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
741
742         Hide next and previous form control buttons when WKWebView is editable
743         https://bugs.webkit.org/show_bug.cgi?id=196672
744         <rdar://problem/35625321>
745
746         Reviewed by Tim Horton.
747
748         Add a new API test.
749
750         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
751         (-[TestWKWebView lastTrailingBarButtonGroup]):
752         (TestWebKitAPI::TEST):
753         * TestWebKitAPI/ios/UIKitSPI.h:
754
755 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
756
757         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
758         https://bugs.webkit.org/show_bug.cgi?id=196077
759         <rdar://problem/49108202>
760
761         Reviewed by Chris Dumez.
762
763         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
764         on new web view.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
767
768 2019-04-05  Saam Barati  <sbarati@apple.com>
769
770         Make compare-results understand MotionMark
771         https://bugs.webkit.org/show_bug.cgi?id=196666
772
773         Reviewed by Yusuke Suzuki.
774
775         * Scripts/compare-results:
776         (PLT5Results):
777         (detectMotionMark):
778         (detectMotionMark1_1):
779         (motionMarkResults):
780         (motionMark1_1Results):
781         (detectBenchmark):
782         (biggerIsBetter):
783         (main):
784
785 2019-04-05  Alex Christensen  <achristensen@webkit.org>
786
787         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
788         https://bugs.webkit.org/show_bug.cgi?id=196665
789         <rdar://45115669>
790
791         Reviewed by Geoff Garen.
792
793         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
794         (goBack):
795         (+[SimpleLookupContext sharedLookupContext]):
796         (-[SimpleLookupContext lookUpURL:completionHandler:]):
797         (TEST):
798         (+[Simple3LookupContext sharedLookupContext]): Deleted.
799         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
800
801 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-build] Add configuration and architecture for windows builders
804         https://bugs.webkit.org/show_bug.cgi?id=196660
805
806         Reviewed by Lucas Forschler.
807
808         * BuildSlaveSupport/ews-build/config.json:
809
810 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
811
812         webkitpy: Don't run subsequent rounds if interrupted
813         https://bugs.webkit.org/show_bug.cgi?id=196646
814
815         Reviewed by Aakash Jain.
816
817         * Scripts/webkitpy/layout_tests/controllers/manager.py:
818         (Manager.run): Bail out if interrupted.
819
820 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
821
822         Test sessionStorage in PSON private browsing mode
823         https://bugs.webkit.org/show_bug.cgi?id=196561
824
825         Reviewed by Alex Christensen.
826
827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
828
829 2019-04-05  Commit Queue  <commit-queue@webkit.org>
830
831         Unreviewed, rolling out r243833.
832         https://bugs.webkit.org/show_bug.cgi?id=196645
833
834         This change breaks build of WPE and GTK ports (Requested by
835         annulen on #webkit).
836
837         Reverted changeset:
838
839         "[CMake][WTF] Mirror XCode header directories"
840         https://bugs.webkit.org/show_bug.cgi?id=191662
841         https://trac.webkit.org/changeset/243833
842
843 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
844
845         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
846         https://bugs.webkit.org/show_bug.cgi?id=196635
847
848         Reviewed by Antti Koivisto.
849         
850         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
851         for a test to enable async frame scrolling via:
852             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
853         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
854         
855         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
856
857         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
858         (WTR::InjectedBundle::beginTesting):
859         * WebKitTestRunner/TestController.cpp:
860         (WTR::TestController::resetPreferencesToConsistentValues):
861
862 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
863
864         Use a correct LC_RPATH when building with ASan
865         https://bugs.webkit.org/show_bug.cgi?id=196576
866
867         Reviewed by David Kilzer.
868
869         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
870         so that ../Frameworks is checked. This is simpler and more reliable than updating
871         each SPC service xcconfig.
872
873 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
874
875         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
876         https://bugs.webkit.org/show_bug.cgi?id=196629
877
878         Reviewed by Lucas Forschler.
879
880         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
881
882 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
883
884         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
885         https://bugs.webkit.org/show_bug.cgi?id=196618
886
887         Reviewed by Lucas Forschler.
888
889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
890         (StatusBubble): Added QUEUE_TRIGGERS.
891         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
892         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
893         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
894         its parent(builder).
895
896 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
897
898         [ews-app] Status-bubble steps are sometimes displayed in reverse order
899         https://bugs.webkit.org/show_bug.cgi?id=196625
900
901         Reviewed by Lucas Forschler.
902
903         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
904         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
905
906 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
907
908         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
909         https://bugs.webkit.org/show_bug.cgi?id=196630
910
911         Reviewed by Wenson Hsieh.
912
913         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
914
915 2019-04-04  Youenn Fablet  <youenn@apple.com>
916
917         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
918         https://bugs.webkit.org/show_bug.cgi?id=196543
919
920         Reviewed by Alex Christensen.
921
922         * WebKitTestRunner/TestController.cpp:
923         (WTR::TestController::generatePageConfiguration):
924
925 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
926
927         [ews-app] Status bubble should not display skipped buildbot steps
928         https://bugs.webkit.org/show_bug.cgi?id=196584
929
930         Reviewed by Lucas Forschler.
931
932         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
933
934 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
937         https://bugs.webkit.org/show_bug.cgi?id=196620
938
939         Reviewed by Lucas Forschler.
940
941         * BuildSlaveSupport/ews-app/ews/config.py:
942
943 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
944
945         [Win] DumpRenderTreeWatchDog.py is not checked into source
946         https://bugs.webkit.org/show_bug.cgi?id=196567
947         <rdar://problem/49525901>
948
949         Reviewed by Lucas Forschler.
950
951         This script is used on Win EWS bots to terminate hanging DRT processes.
952
953         * EWSTools/dumprendertreewatchdog.py: Added.
954
955 2019-04-04  Chris Dumez  <cdumez@apple.com>
956
957         Unreviewed, roll out r243858 which made tests time out.
958
959         Disable new API tests on Windows instead.
960
961         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
962         (TestWebKitAPI::TEST):
963
964 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
965
966         [ATK] Cleanup WebPageAccessibilityObjectAtk
967         https://bugs.webkit.org/show_bug.cgi?id=196537
968
969         Reviewed by Michael Catanzaro.
970
971         Also consider files under atk directories as exceptions for GObject conventions.
972
973         * Scripts/webkitpy/style/checkers/cpp.py:
974         (check_identifier_name_in_declaration):
975
976 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
977
978         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
979         https://bugs.webkit.org/show_bug.cgi?id=196588
980         <rdar://problem/49365787>
981
982         Unreviewed build fix for Windows port.
983
984         error C3861: 'kill': identifier not found
985
986         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
987         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
988
989 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
990
991         [ews-build] Cancel build and similar operations should have authentication
992         https://bugs.webkit.org/show_bug.cgi?id=196520
993
994         Reviewed by Dewei Zhu.
995
996         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
997         environment variables.
998
999 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1000
1001         [ews-build] Do not trigger queues which are not in production yet
1002         https://bugs.webkit.org/show_bug.cgi?id=196581
1003
1004         Reviewed by Dewei Zhu.
1005
1006         * BuildSlaveSupport/ews-build/config.json:
1007
1008 2019-04-03  Chris Dumez  <cdumez@apple.com>
1009
1010         Unreviewed, fix typo in the name of API test added in r243848.
1011
1012         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1013         (TestWebKitAPI::TEST):
1014
1015 2019-04-03  Chris Dumez  <cdumez@apple.com>
1016
1017         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1018         https://bugs.webkit.org/show_bug.cgi?id=196588
1019         <rdar://problem/49365787>
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         Add API test coverage.
1024
1025         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1026         (TestWebKitAPI::nullJavaScriptCallback):
1027         (TestWebKitAPI::didCrashCheckFrames):
1028         (TestWebKitAPI::TEST):
1029
1030 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1031
1032         run-webkit-tests: Upload test results (new results database)
1033         https://bugs.webkit.org/show_bug.cgi?id=196577
1034         <rdar://problem/34841155>
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1039         (Manager.run): Upload results after each device shard, since the configuration will be
1040         different for each device.
1041         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1042         uploaded to a results database.
1043         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1044         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1045
1046 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1047
1048         -apple-trailing-word is needed for browser detection
1049         https://bugs.webkit.org/show_bug.cgi?id=196575
1050
1051         Unreviewed.
1052
1053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1054
1055 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1056
1057         [CMake][WTF] Mirror XCode header directories
1058         https://bugs.webkit.org/show_bug.cgi?id=191662
1059
1060         Reviewed by Konstantin Tokarev.
1061
1062         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1063         builds.
1064
1065         * CMakeLists.txt:
1066         * DumpRenderTree/CMakeLists.txt:
1067         * DumpRenderTree/PlatformWin.cmake:
1068         * MiniBrowser/win/CMakeLists.txt:
1069         * TestWebKitAPI/CMakeLists.txt:
1070         * TestWebKitAPI/PlatformWin.cmake:
1071         * WebKitTestRunner/PlatformGTK.cmake:
1072         * WebKitTestRunner/PlatformWin.cmake:
1073
1074 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1075
1076         [ews-app] Status bubble should not display certain infrastructure status messages
1077         https://bugs.webkit.org/show_bug.cgi?id=196550
1078
1079         Reviewed by Lucas Forschler.
1080
1081         Do not display the steps which are un-needed for end-user. This information is still avaiable
1082         if the user click on the bubble and look at the Buildbot build.
1083         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1084         (StatusBubble._steps_messages):
1085         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1086
1087 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1088
1089         [ews-build] Use https for sending data to ews-app
1090         https://bugs.webkit.org/show_bug.cgi?id=196492
1091
1092         Reviewed by Lucas Forschler.
1093
1094         * BuildSlaveSupport/ews-build/events.py:
1095
1096 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1097
1098         Remove support for -apple-trailing-word
1099         https://bugs.webkit.org/show_bug.cgi?id=196525
1100
1101         Reviewed by Zalan Bujtas.
1102
1103         This CSS property is nonstandard and not used.
1104
1105         * Scripts/webkitperl/FeatureList.pm:
1106         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1107
1108 2019-04-03  Youenn Fablet  <youenn@apple.com>
1109
1110         Add a test for DOMCache on multiple browsing in case of private browsing
1111         https://bugs.webkit.org/show_bug.cgi?id=196524
1112
1113         Reviewed by Alex Christensen.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1116         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1117
1118 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1119
1120         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1121         https://bugs.webkit.org/show_bug.cgi?id=196540
1122
1123         Reviewed by Aakash Jain.
1124
1125         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1126
1127 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         Add plumbing for a compatibility mode preference in WebKit
1130         https://bugs.webkit.org/show_bug.cgi?id=196005
1131
1132         Reviewed by Tim Horton.
1133
1134         Add new API tests.
1135
1136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1137         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1138
1139 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1140
1141         [WPE][GTK] Update libsrtp dependency package for Debian
1142         https://bugs.webkit.org/show_bug.cgi?id=196528
1143
1144         Reviewed by Frédéric Wang.
1145
1146         * gtk/install-dependencies:
1147         * wpe/install-dependencies:
1148
1149 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1150
1151         [WK2] Add support for Window's beforeprint / afterprint events
1152         https://bugs.webkit.org/show_bug.cgi?id=196478
1153         <rdar://problem/49535124>
1154
1155         Unreviewed build fix for MSVC.
1156
1157         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1158
1159         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1160
1161         * WebKitTestRunner/TestController.cpp:
1162         (WTR::printFrame): Use int and float literals.
1163
1164 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1165
1166         [ews-build] Reassign bots to queues
1167
1168         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1169
1170 2019-04-02  Chris Dumez  <cdumez@apple.com>
1171
1172         [WK2] Add support for Window's beforeprint / afterprint events
1173         https://bugs.webkit.org/show_bug.cgi?id=196478
1174
1175         Reviewed by Alex Christensen.
1176
1177         Add minimal implementation for printFrame in WebKitTestRunner.
1178
1179         * WebKitTestRunner/TestController.cpp:
1180         (WTR::printFrame):
1181         (WTR::TestController::createOtherPage):
1182         (WTR::TestController::createWebViewWithOptions):
1183
1184 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1187         https://bugs.webkit.org/show_bug.cgi?id=196491
1188
1189         Reviewed by Lucas Forschler.
1190
1191         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1192
1193 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1194
1195         [ews-build] Configure buildbot try credentials in environment variables
1196         https://bugs.webkit.org/show_bug.cgi?id=196501
1197
1198         Reviewed by Lucas Forschler.
1199
1200         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1201         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1202         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1203
1204 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1205
1206         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1207         https://bugs.webkit.org/show_bug.cgi?id=196496
1208         <rdar://problem/49521634>
1209
1210         Reviewed by Chris Dumez.
1211
1212         Add new API tests (see WebKit ChangeLog for more detail).
1213
1214         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1215         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1216         (TEST):
1217
1218 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1219
1220         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1221         <https://webkit.org/b/196499>
1222
1223         Reviewed by Alexey Proskuryakov.
1224
1225         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1226         ENABLE_ADDRESS_SANITIZER.
1227
1228 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1229
1230         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1231         https://bugs.webkit.org/show_bug.cgi?id=182757
1232
1233         Reviewed by Don Olmstead.
1234
1235         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1236         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1237
1238 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1239
1240         run-api-tests: Upload test results
1241         https://bugs.webkit.org/show_bug.cgi?id=196323
1242         <rdar://problem/49356714>
1243
1244         Reviewed by Lucas Forschler.
1245
1246         * Scripts/webkitpy/api_tests/manager.py:
1247         (Manager):
1248         (Manager.run): Upload results to a results database.
1249         * Scripts/webkitpy/api_tests/run_api_tests.py:
1250         (parse_args): Add upload arguments.
1251         * Scripts/webkitpy/port/base.py:
1252         (Port):
1253         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1254         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1255         with commits from any other associated repositories.
1256         * Scripts/webkitpy/port/device.py:
1257         (Device):
1258         (Device.build_version): Access build_versoin of underlying platform device.
1259         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1260         (IOSSimulatorTest):
1261         (IOSSimulatorTest.test_configuration_for_upload):
1262         * Scripts/webkitpy/port/device_port.py:
1263         (DevicePort):
1264         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1265         the same as the machine uploading results.
1266         * Scripts/webkitpy/port/mac.py:
1267         (MacPort):
1268         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1269         * Scripts/webkitpy/port/mac_unittest.py:
1270         (MacTest):
1271         (MacTest.test_configuration_for_upload):
1272         * Scripts/webkitpy/xcode/simulated_device.py:
1273         (SimulatedDeviceManager._create_device_with_runtime):
1274         (SimulatedDevice.__init__): Create simulated device with a build_version.
1275         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1276         (test_existing_simulator):
1277
1278 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1279
1280         Remove extra newline characters (Follow-up fix to r243707)
1281
1282         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1283
1284 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-app] Use API_KEY to accept results data
1287         https://bugs.webkit.org/show_bug.cgi?id=196461
1288
1289         Reviewed by Dewei Zhu.
1290
1291         * BuildSlaveSupport/ews-app/ews/views/results.py:
1292         (Results.post): Validate EWS_API_KEY before accepting any data.
1293         * BuildSlaveSupport/ews-build/events.py:
1294         (Events.sendData): Send EWS_API_KEY if available along with event data.
1295
1296 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1297
1298         Unable to copy and paste a PDF from Notes into Mail compose body
1299         https://bugs.webkit.org/show_bug.cgi?id=196442
1300         <rdar://problem/48573098>
1301
1302         Reviewed by Tim Horton.
1303
1304         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1305         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1306         to be specified on the item providers.
1307
1308         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1309         (TestWebKitAPI::mapItemForTesting):
1310         (TestWebKitAPI::contactItemForTesting):
1311
1312 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1313
1314         Make UIWKDocumentContext rects per-character instead of per-word
1315         https://bugs.webkit.org/show_bug.cgi?id=196459
1316
1317         Reviewed by Wenson Hsieh.
1318
1319         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1320         (TEST):
1321         Adjust test results due to switching to per-character rects.
1322
1323 2019-04-01  Chris Dumez  <cdumez@apple.com>
1324
1325         UIProcess crash when a prewarmed process is terminated
1326         https://bugs.webkit.org/show_bug.cgi?id=196451
1327         <rdar://problem/49245471>
1328
1329         Reviewed by Geoffrey Garen.
1330
1331         Add API test coverage.
1332
1333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1334         (TEST):
1335
1336 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1337
1338         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1339         https://bugs.webkit.org/show_bug.cgi?id=196449
1340
1341         Reviewed by Lucas Forschler.
1342
1343         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1344         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1345         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1346         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1347
1348 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1349
1350         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1351         https://bugs.webkit.org/show_bug.cgi?id=196444
1352
1353         Reviewed by Lucas Forschler.
1354
1355         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1356
1357 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1358
1359         Add SPI to canonicalize NSURLs with WTF::URL
1360         https://bugs.webkit.org/show_bug.cgi?id=196415
1361         <rdar://problem/44980271>
1362
1363         Reviewed by Darin Adler.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1367         (TestWebKitAPI::TEST):
1368
1369 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1370
1371         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1372         https://bugs.webkit.org/show_bug.cgi?id=196441
1373
1374         Reviewed by Carlos Garcia Campos.
1375
1376         Don't cache the wpe_view_backend object that might not exist yet at the
1377         time of EventSenderProxy constructor invocation, but instead retrieve
1378         that object whenever it's required for event dispatching. This should
1379         avoid crashes in this constructor now that it's invoked before any
1380         PlatformWindow has been set up (as changed in r243496).
1381
1382         * WebKitTestRunner/EventSenderProxy.h:
1383         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1384         (WTR::viewBackend):
1385         (WTR::EventSenderProxy::EventSenderProxy):
1386         (WTR::EventSenderProxy::mouseDown):
1387         (WTR::EventSenderProxy::mouseUp):
1388         (WTR::EventSenderProxy::mouseMoveTo):
1389         (WTR::EventSenderProxy::mouseScrollBy):
1390         (WTR::EventSenderProxy::keyDown):
1391         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1392
1393 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1394
1395         [Win][WebKit] MiniBrowser should support high DPI display
1396         https://bugs.webkit.org/show_bug.cgi?id=196391
1397
1398         Reviewed by Alex Christensen.
1399
1400         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1401         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1402         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1403         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1404
1405 2019-03-31  Sam Weinig  <weinig@apple.com>
1406
1407         Remove more i386 specific configurations
1408         https://bugs.webkit.org/show_bug.cgi?id=196430
1409
1410         Reviewed by Alexey Proskuryakov.
1411
1412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1413         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1414
1415 2019-03-31  Andy Estes  <aestes@apple.com>
1416
1417         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1418         https://bugs.webkit.org/show_bug.cgi?id=196433
1419         <rdar://problem/49293305>
1420
1421         Reviewed by Tim Horton.
1422
1423         Enhanced API test coverage to include all navigation response policy decisions in both
1424         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1425
1426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1427         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1430         (readFile):
1431         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1432         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1433         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1434         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1435         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1436         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1437         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1438         (-[QuickLookDelegate _downloadDidStart:]):
1439         (-[QuickLookDelegate _download:didReceiveResponse:]):
1440         (-[QuickLookDelegate _download:didReceiveData:]):
1441         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1442         (-[QuickLookDelegate _downloadDidFinish:]):
1443         (-[QuickLookDelegate _download:didFailWithError:]):
1444         (-[QuickLookDelegate _downloadDidCancel:]):
1445         (-[QuickLookDelegate verifyDownload]):
1446         (runTest):
1447         (runTestDecideBeforeLoading):
1448         (runTestDecideAfterLoading):
1449         (TEST):
1450         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1451         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1452         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1453         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1454         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1455         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1456         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1457         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1458         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1459         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1460         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1461         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1462         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1463         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1464
1465 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1466
1467         [CMake] add testdfg as target with build-jsc
1468         https://bugs.webkit.org/show_bug.cgi?id=196393
1469
1470         Reviewed by Saam Barati.
1471
1472         Added testdfg as one of the targets to build when
1473         using CMake.
1474
1475         * Scripts/build-jsc:
1476
1477 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1478
1479         Delete WebMetal implementation in favor of WebGPU
1480         https://bugs.webkit.org/show_bug.cgi?id=195418
1481
1482         Reviewed by Dean Jackson.
1483
1484         * DumpRenderTree/mac/DumpRenderTree.mm:
1485         (enableExperimentalFeatures):
1486         (resetWebPreferencesToConsistentValues):
1487         * Scripts/webkitperl/FeatureList.pm:
1488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1491         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1492         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1493         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1494         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1495         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1496         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1497         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1498         (WTR::InjectedBundle::beginTesting):
1499         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1500         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1501         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1502
1503 2019-03-29  Chris Dumez  <cdumez@apple.com>
1504
1505         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1506         https://bugs.webkit.org/show_bug.cgi?id=196405
1507         <rdar://problem/49428130>
1508
1509         Reviewed by Wenson Hsieh.
1510
1511         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1512         the popover presentation methods to be no-ops. Use this in the new test added in
1513         r243523 so that we do not swizzle those methods for all tests. This is needed because
1514         those WatchOS tests rely on the popover getting presented and interactive.
1515
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::updateTestOptionsFromTestHeader):
1518         * WebKitTestRunner/TestController.h:
1519         * WebKitTestRunner/TestOptions.h:
1520         (WTR::TestOptions::hasSameInitializationOptions const):
1521         * WebKitTestRunner/ios/TestControllerIOS.mm:
1522         (WTR::TestController::platformInitialize):
1523         (WTR::TestController::platformResetStateToConsistentValues):
1524
1525 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1526
1527         [Curl] Add Server Trust Evaluation Support.
1528         https://bugs.webkit.org/show_bug.cgi?id=191646
1529
1530         Reviewed by Fujii Hironori.
1531
1532         Implemented MiniBrowser UI for asking if user trusts the server.
1533
1534         * MiniBrowser/win/Common.cpp:
1535         (askServerTrustEvaluation):
1536         (replaceString):
1537         * MiniBrowser/win/Common.h:
1538         * MiniBrowser/win/MiniBrowserLib.rc:
1539         * MiniBrowser/win/MiniBrowserLibResource.h:
1540         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1541         (createPEMString):
1542         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1543         (WebKitBrowserWindow::canTrustServerCertificate):
1544         * MiniBrowser/win/WebKitBrowserWindow.h:
1545
1546 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1547
1548         Implement ResizeObserver.
1549         https://bugs.webkit.org/show_bug.cgi?id=157743
1550
1551         Reviewed by Simon Fraser.
1552
1553         Support resizeObserverEnabled webPreferences.
1554
1555         * DumpRenderTree/TestOptions.cpp:
1556         (TestOptions::TestOptions):
1557         * DumpRenderTree/TestOptions.h:
1558         * DumpRenderTree/mac/DumpRenderTree.mm:
1559         (setWebPreferencesForTestOptions):
1560         * DumpRenderTree/win/DumpRenderTree.cpp:
1561         (enableExperimentalFeatures):
1562         * Scripts/webkitperl/FeatureList.pm:
1563         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1564
1565 2019-03-28  John Wilander  <wilander@apple.com>
1566
1567         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1568         https://bugs.webkit.org/show_bug.cgi?id=196281
1569         <rdar://problem/48938748>
1570
1571         Reviewed by Alex Christensen.
1572
1573         This patch adds the function isStatisticsHasLocalStorage() to the
1574         TestRunner. With it, the page can query the WebsiteDataStore in the
1575         UI process to make sure that it sees LocalStorage.
1576
1577         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1579         (WTR::TestRunner::isStatisticsHasLocalStorage):
1580         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::TestController::isStatisticsHasLocalStorage):
1583         * WebKitTestRunner/TestController.h:
1584         * WebKitTestRunner/TestInvocation.cpp:
1585         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1586
1587 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1588
1589         API::Data::createWithoutCopying should do a null check before calling CFRelease
1590         https://bugs.webkit.org/show_bug.cgi?id=196276
1591         <rdar://problem/48059859>
1592
1593         Reviewed by Alex Christensen.
1594
1595         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1596
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1599         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1600         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1601         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1602         (TestWebKitAPI::TEST):
1603
1604 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1605
1606         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1607         https://bugs.webkit.org/show_bug.cgi?id=186276
1608
1609         Reviewed by Carlos Garcia Campos.
1610
1611         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1612         (webViewLoadChanged):
1613         (testWebResourceGetDataError):
1614         (testWebResourceGetDataEmpty):
1615         (beforeAll):
1616         (webViewloadChanged): Deleted.
1617
1618 2019-03-27  Andy Estes  <aestes@apple.com>
1619
1620         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1621         https://bugs.webkit.org/show_bug.cgi?id=196317
1622
1623         Reviewed by Dan Bernstein.
1624
1625         package-root copies built products into a staging directory using ditto(1), which does not
1626         follow symbolic links as it traverses a directory. Now that the files in
1627         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1628         itself, these become broken links when ditto'd into the staging directory.
1629
1630         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1631
1632         * Scripts/package-root:
1633
1634 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1635
1636         [ews-app] Update display text of Submit for ews analysis
1637         https://bugs.webkit.org/show_bug.cgi?id=196309
1638
1639         Reviewed by Dewei Zhu.
1640
1641         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1642
1643 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1644
1645         run-webkit-tests should check for leaks in WebKit processes
1646         <https://webkit.org/b/193772>
1647         <rdar://problem/46526680>
1648
1649         Reviewed by Ryosuke Niwa.
1650
1651         This works by doing the following:
1652         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1653           The list of child processes are returned one per line:
1654           process.name: pid
1655         - Run the "#LIST CHILD PROCESSES" command just before the
1656           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1657           processes on the ServerProcess object.
1658         - When the `--leaks` switch is handled, run check_for_leaks() on
1659           each child process after the main test harness.
1660
1661         * DumpRenderTree/mac/DumpRenderTree.mm:
1662         (handleControlCommand):
1663         - Use strncmp() instead of strcmp().
1664         - Add support for handling "#LIST CHILD PROCESSES" command.
1665
1666         * Scripts/webkitpy/port/base.py:
1667         (Port.check_for_leaks):
1668         * Scripts/webkitpy/port/darwin.py:
1669         (DarwinPort.check_for_leaks):
1670         - Rename redundant 'process_pid' argument to 'process_id'.
1671
1672         * Scripts/webkitpy/port/driver.py:
1673         (Driver.do_post_tests_work):
1674         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1675           longer the only command this sends to WebKitTestRunner.
1676         - If the `--leaks` switch is present, send the
1677           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1678           result using Port.set_webkit_processes().
1679         (Driver._parse_child_processes_output):
1680         - Add helper method to parse list of child process names and
1681           process IDs returned from WebKitTestRunner.
1682
1683         * Scripts/webkitpy/port/ios_device.py:
1684         (IOSDevicePort.check_for_leaks):
1685         - Rename redundant 'process_pid' argument to 'process_id'.
1686
1687         * Scripts/webkitpy/port/leakdetector.py:
1688         (LeakDetector._parse_leaks_output):
1689         - Return early if there is no leaks_output.
1690         (LeakDetector.check_for_leaks):
1691         - Rename redundant 'process_pid' argument to 'process_id'.
1692
1693         * Scripts/webkitpy/port/server_process.py:
1694         (ServerProcess.__init__):
1695         (ServerProcess.child_processes):
1696         (ServerProcess.set_child_processes):
1697         - Add instance variable to Port to store list of child process
1698           names and process IDs returned from WebKitTestRunner.
1699         (ServerProcess._start):
1700         - Clear self._child_processes.
1701         (ServerProcess.stop):
1702         - If self._child_processes is set, call
1703           self._port.check_for_leaks() for each child process.
1704
1705         * Scripts/webkitpy/port/server_process_unittest.py:
1706         (TrivialMockPort.check_for_leaks):
1707         - Rename redundant 'process_pid' argument to 'process_id'.
1708
1709         * Scripts/webkitpy/port/simulator_process.py:
1710         (SimulatorProcess.stop):
1711         - If self._child_processes is set, call
1712           self._port.check_for_leaks() for each child process.
1713
1714         * Scripts/webkitpy/port/watch_device.py:
1715         (WatchDevicePort.check_for_leaks):
1716         - Rename redundant 'process_pid' argument to 'process_id'.
1717
1718         * WebKitTestRunner/TestController.cpp:
1719         (WTR::TestController::dumpResponse):
1720         - Extract method from findAndDumpWorldLeaks() so that it may be
1721           reused by findAndDumpWebKitProcessIdentifiers().
1722         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1723         - Add method to output process name and process ID of both the
1724           WebContent and Networking processes.
1725         (WTR::TestController::findAndDumpWorldLeaks):
1726         - Fix missing newline in output when there were no abandoned
1727           documents.
1728         - Call dumpResponse() for extracted code.
1729         (WTR::TestController::handleControlCommand):
1730         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1731         - Use strncmp() instead of strcmp().
1732         - Call findAndDumpWebKitProcessIdentifiers() when
1733           "#LIST CHILD PROCESSES" command is sent.
1734         * WebKitTestRunner/TestController.h:
1735         (WTR::TestController::dumpResponse):
1736         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1737         - Declare methods.
1738
1739 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1740
1741         Unreviewed. Add GLib API test cases after r243434.
1742
1743         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1744         (testWebViewActiveURI):
1745         (serverCallback):
1746         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1747         (sendRequestCallback):
1748
1749 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1750
1751         Geolocation request not complete when watch request was started in a different web process
1752         https://bugs.webkit.org/show_bug.cgi?id=195996
1753
1754         Reviewed by Alex Christensen.
1755
1756         Add a test case.
1757
1758         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1759         (TestWebKitAPI::runJavaScriptAlert):
1760         (TestWebKitAPI::TEST):
1761
1762 2019-03-26  Keith Rollin  <krollin@apple.com>
1763
1764         Update the way generate-xcfilelists returns strings from functions
1765         https://bugs.webkit.org/show_bug.cgi?id=195975
1766         <rdar://problem/49040807>
1767
1768         Reviewed by Dean Jackson.
1769
1770         There are places where generate-xcfilelists executes assignments with
1771         statements like:
1772
1773             FOO=$(some_function)
1774
1775         where "some_function" return a string by echoing it. E.g.
1776
1777             some_function()
1778             {
1779                 echo "Hello, World"
1780             }
1781
1782         This is a common idiom, but it has a problem if "some_function" needs
1783         to call "exit" in an attempt to halt the entire script right then and
1784         there. Since "some_function" is called inside of $(), it's being
1785         executed in a sub-shell. Calling exit in that sub-shell simply exits
1786         that shell; it doesn't not exit the outer shell in which the main part
1787         of the script is still running. As such, the main script keeps
1788         executing when the intent was for the script to halt.
1789
1790         The solution to this is to use a different idiom for returning
1791         strings. The one we now is to pass in the name of the variable to
1792         receive the string result:
1793
1794             some_function()
1795             {
1796                 variable_name=$1
1797                 eval $variable_name ="Hello, World"
1798             }
1799
1800         The call site now looks like
1801
1802             some_function FOO
1803
1804         Because there's no invocation of a sub-shell, some_function can now
1805         call "exit" if it wants to, and the entire script will exit at that
1806         point.
1807
1808         * Scripts/generate-xcfilelists:
1809
1810 2019-03-26  Chris Dumez  <cdumez@apple.com>
1811
1812         Add basic layout test coverage for File Picker on iOS
1813         https://bugs.webkit.org/show_bug.cgi?id=196265
1814
1815         Reviewed by Wenson Hsieh.
1816
1817         Add layout test infrastructure to test the file picker on iOS.
1818
1819         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1820         (WTR::UIScriptController::dismissFilePicker):
1821         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1822         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1823         (WTR::UIScriptController::dismissFilePicker):
1824         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::createWebViewWithOptions):
1827         (WTR::updateTestOptionsFromTestHeader):
1828         * WebKitTestRunner/TestOptions.h:
1829         (WTR::TestOptions::hasSameInitializationOptions const):
1830         * WebKitTestRunner/ios/TestControllerIOS.mm:
1831         (overridePresentViewController):
1832         (WTR::TestController::platformInitialize):
1833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1834         (WTR::UIScriptController::dismissFilePicker):
1835
1836 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1837
1838         Implement async paste method on UIWKInteractionViewProtocol
1839         https://bugs.webkit.org/show_bug.cgi?id=196267
1840         <rdar://problem/49236346>
1841
1842         Reviewed by Tim Horton.
1843
1844         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1845         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1846         are now a part of all iOS 12 internal SDKs.
1847
1848         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1849
1850         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1851         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1852
1853         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1854         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1855         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1856         * TestWebKitAPI/ios/UIKitSPI.h:
1857
1858 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1859
1860         [ews-build] Use PostgreSQL for ews.webkit.org database
1861         https://bugs.webkit.org/show_bug.cgi?id=196270
1862
1863         Reviewed by Lucas Forschler.
1864
1865         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1866
1867 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1868
1869         [ews] Reset simctl states on reboot
1870         https://bugs.webkit.org/show_bug.cgi?id=196260
1871
1872         Rubber-stamped by Aakash Jain.
1873
1874         * EWSTools/start-queue-mac.sh:
1875
1876 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-build] Use PostgreSQL for ews-build database
1879         https://bugs.webkit.org/show_bug.cgi?id=196229
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * BuildSlaveSupport/ews-build/master.cfg:
1884
1885 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1886
1887         [ews-build] Get master_hostname dynamically in master.cfg
1888         https://bugs.webkit.org/show_bug.cgi?id=196255
1889
1890         Reviewed by Lucas Forschler.
1891
1892         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1893         send events data in test mode.
1894
1895 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1896
1897         [ews-app] Set db_constraint to False for Foreign Keys
1898         https://bugs.webkit.org/show_bug.cgi?id=196252
1899
1900         Reviewed by Lucas Forschler.
1901
1902         * BuildSlaveSupport/ews-app/ews/models/build.py:
1903         * BuildSlaveSupport/ews-app/ews/models/step.py:
1904
1905 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1906
1907         [ews-build] is_test_mode_enabled should default to True
1908         https://bugs.webkit.org/show_bug.cgi?id=196248
1909
1910         Reviewed by Lucas Forschler.
1911
1912         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1913
1914 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1915
1916         [ews-app] Add webkitperl to ENABLED_QUEUES
1917         https://bugs.webkit.org/show_bug.cgi?id=196253
1918
1919         Reviewed by Lucas Forschler.
1920
1921         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1922
1923 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1924
1925         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1926         https://bugs.webkit.org/show_bug.cgi?id=196211
1927         rdar://problem/49110552
1928
1929         Reviewed by Tim Horton.
1930
1931         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1932         Make sure that EventSenderProxy always exists when running tests. We used to create
1933         it when resetting before the first test, which is a bit too late.
1934
1935         * WebKitTestRunner/TestController.h:
1936         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1937         (WTR::TestController::platformCreateWebView):
1938         (WTR::TestController::platformCreateOtherPage):
1939         (WTR::TestController::finishCreatingPlatformWebView):
1940         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1941         (WTR::PlatformWebView::PlatformWebView):
1942         Moved some code that made NSWindow use NSEvent during web view creation. We may
1943         need to move more if some other case us found, but this is enough for now.
1944
1945 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1946
1947         Unreviewed. Fix typo in GLib geolocation API after r243285.
1948
1949         gelocation -> geolocation.
1950
1951         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1952         (testGeolocationManagerWatchPosition):
1953
1954 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1955
1956         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1957         https://bugs.webkit.org/show_bug.cgi?id=196213
1958
1959         Reviewed by Geoff Garen.
1960
1961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1962         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1963         (credentialWithIdentityAndKeychainPath):
1964         (-[ChallengeDelegate webView:didFinishNavigation:]):
1965         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1966         (TestWebKitAPI::TEST):
1967
1968 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1969
1970         Expected shouldn't assume its contained types are copyable
1971         https://bugs.webkit.org/show_bug.cgi?id=195986
1972
1973         Reviewed by JF Bastien.
1974
1975         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1976         (TestWebKitAPI::NonCopyable::operator== const):
1977         (TestWebKitAPI::NonCopyable::operator!= const):
1978         (TestWebKitAPI::TEST):
1979
1980 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1981
1982         Remove some now-unnecessary dynamic class lookup
1983         https://bugs.webkit.org/show_bug.cgi?id=196237
1984
1985         Reviewed by Simon Fraser.
1986
1987         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1988         (makeRequest):
1989         (TEST):
1990
1991 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1992
1993         Unreviewed, rolling out r243450.
1994
1995         AppleWin and WinCairo port builds get broken.
1996
1997         Reverted changeset:
1998
1999         "Add test for fix of #196095"
2000         https://bugs.webkit.org/show_bug.cgi?id=196097
2001         https://trac.webkit.org/changeset/243450
2002
2003 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2004
2005         Unreviewed, rolling out r243465.
2006         https://bugs.webkit.org/show_bug.cgi?id=196226
2007
2008         the test doesn't build (Requested by thorton on #webkit).
2009
2010         Reverted changeset:
2011
2012         "Do not terminate the NetworkProcess if a third party
2013         application sends a NSCredential with a SecIdentityRef"
2014         https://bugs.webkit.org/show_bug.cgi?id=196213
2015         https://trac.webkit.org/changeset/243465
2016
2017 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2018
2019         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2020         https://bugs.webkit.org/show_bug.cgi?id=196213
2021
2022         Reviewed by Geoff Garen.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2026         (credentialWithIdentityAndKeychainPath):
2027         (-[ChallengeDelegate webView:didFinishNavigation:]):
2028         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2029         (TestWebKitAPI::TEST):
2030
2031 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-build] Gracefully handle missing patch_id in events
2034         https://bugs.webkit.org/show_bug.cgi?id=196216
2035
2036         Reviewed by Lucas Forschler.
2037
2038         * BuildSlaveSupport/ews-build/events.py:
2039
2040 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] use lz4 compression for improving buildbot performance
2043         https://bugs.webkit.org/show_bug.cgi?id=196155
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-build/master.cfg:
2048
2049 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2050
2051         Pull some API testing helper methods out of TestWKWebView
2052         https://bugs.webkit.org/show_bug.cgi?id=196212
2053
2054         Reviewed by Tim Horton.
2055
2056         Refactor some more API testing utility methods, so that they can be used in
2057         tests that do not use TestWKWebView.
2058
2059         * TestWebKitAPI/cocoa/TestWKWebView.h:
2060         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2061         (-[WKWebView loadTestPageNamed:]):
2062         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2063         (-[WKWebView synchronouslyLoadHTMLString:]):
2064         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2065         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2066         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2067         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2068         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2069
2070 2019-03-25  Jer Noble  <jer.noble@apple.com>
2071
2072         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2073         https://bugs.webkit.org/show_bug.cgi?id=196097
2074
2075         Reviewed by Eric Carlson.
2076
2077         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2078
2079         * DumpRenderTree/mac/DumpRenderTree.mm:
2080         (resetWebPreferencesToConsistentValues):
2081         * WebKitTestRunner/TestController.cpp:
2082         (WTR::TestController::resetPreferencesToConsistentValues):
2083
2084 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2085
2086         Pull IPadUserInterfaceSwizzler out into a separate header file
2087         https://bugs.webkit.org/show_bug.cgi?id=196193
2088
2089         Reviewed by Anders Carlsson.
2090
2091         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2092         be used in other API tests.
2093
2094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2095         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2096         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2097         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2098         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2099         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2100         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2101
2102 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2103
2104         Remove NavigatorContentUtils in WebCore/Modules
2105         https://bugs.webkit.org/show_bug.cgi?id=196070
2106
2107         Reviewed by Alex Christensen.
2108
2109         NavigatorContentUtils was to support the custom scheme spec [1].
2110         However, in WebKit side, no port has supported the feature in
2111         WebKit layer after EFL port was removed. So there has been the
2112         only IDL implementation of the NavigatorContentUtils in WebCore.
2113         So we don't need to keep the implementation in WebCore anymore.
2114
2115         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2116
2117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2118
2119 2019-03-24  Andy Estes  <aestes@apple.com>
2120
2121         [watchOS] Remove unused Proximity Networking code
2122         https://bugs.webkit.org/show_bug.cgi?id=196188
2123
2124         Reviewed by Tim Horton.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2127         (TEST):
2128
2129 2019-03-23  Keith Miller  <keith_miller@apple.com>
2130
2131         Refactor clz/ctz and fix getLSBSet.
2132         https://bugs.webkit.org/show_bug.cgi?id=196162
2133
2134         Reviewed by Saam Barati.
2135
2136         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2137
2138         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2139         (TestWebKitAPI::TEST):
2140
2141 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2142
2143         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2144         https://bugs.webkit.org/show_bug.cgi?id=196143
2145
2146         Reviewed by Michael Catanzaro.
2147
2148         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2149         directories.
2150
2151         * Scripts/webkitpy/style/checkers/cpp.py:
2152         (check_identifier_name_in_declaration):
2153         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2154         (WebKitStyleTest.test_names):
2155
2156 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2157
2158         [Flatpak] Manifest expanding fails for qt WPE extension
2159         https://bugs.webkit.org/show_bug.cgi?id=196148
2160
2161         Reviewed by Alex Christensen.
2162
2163         * flatpak/flatpakutils.py:
2164         (expand_submodules_recurse): The last recurse manifest expand
2165         iteration might lead to a single module so take it into account
2166         and don't try to recurse further.
2167
2168 2019-03-22  Chris Dumez  <cdumez@apple.com>
2169
2170         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2171         https://bugs.webkit.org/show_bug.cgi?id=195348
2172         <rdar://problem/48622090>
2173
2174         Reviewed by Alex Christensen.
2175
2176         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2177         to NO when test.options().shouldIgnoreMetaViewport is false.
2178
2179         * WebKitTestRunner/ios/TestControllerIOS.mm:
2180         (WTR::TestController::platformConfigureViewForTest):
2181
2182 2019-03-22  Chris Dumez  <cdumez@apple.com>
2183
2184         Prewarmed processes should be usable with any website data store
2185         https://bugs.webkit.org/show_bug.cgi?id=196104
2186
2187         Reviewed by Alex Christensen.
2188
2189         Add API test coverage.
2190
2191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2192         (runInitialWarmedProcessUsedTest):
2193         (TEST):
2194
2195 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2196
2197         Back out local changes to Alex's Subversion working directory
2198
2199         They were accidentally committed.
2200
2201         * Scripts/webkitpy/common/system/abstractexecutive.py:
2202         (AbstractExecutive.wait_newest):
2203         * Scripts/webkitpy/common/system/executive.py:
2204         (Executive.running_pids):
2205         * Scripts/webkitpy/common/system/executive_mock.py:
2206         (MockExecutive.running_pids):
2207         * Scripts/webkitpy/common/system/executive_unittest.py:
2208         (ExecutiveTest.serial_test_running_pids):
2209         * Scripts/webkitpy/port/darwin.py:
2210         (DarwinPort.check_for_leaks):
2211         * Scripts/webkitpy/port/leakdetector.py:
2212         (LeakDetector.check_for_leaks):
2213         - This was the hack attached to Bug 193772.
2214
2215         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2216         (+[WebKitTestRunnerEvent mouseLocation]):
2217         - This works around a crash on an internal build.
2218
2219 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2220
2221         Fix the build after r243354
2222         https://bugs.webkit.org/show_bug.cgi?id=196138
2223         <rdar://problem/49145951>
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2226         (TEST):
2227         * TestWebKitAPI/ios/UIKitSPI.h:
2228
2229 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2230
2231         Adopt UIWKDocumentContext
2232         https://bugs.webkit.org/show_bug.cgi?id=196040
2233         <rdar://problem/48642440>
2234
2235         Reviewed by Ryosuke Niwa.
2236
2237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2238         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2239         (makeRequest):
2240         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2241         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2242         (applyStyle):
2243         (TEST):
2244         Add tests for UIWKDocumentContext.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2247         (TEST):
2248         (recursiveFindWKContentView): Deleted.
2249         * TestWebKitAPI/cocoa/TestWKWebView.h:
2250         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2251         (recursiveFindWKContentView):
2252         (-[TestWKWebView wkContentView]):
2253         * TestWebKitAPI/ios/UIKitSPI.h:
2254         Share the WKContentView finding code between tests.
2255
2256 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2257
2258         [iOS WK2] Turn on async overflow scrolling by default
2259         https://bugs.webkit.org/show_bug.cgi?id=196011
2260         rdar://problem/48453859
2261
2262         Reviewed by Antti Koivisto.
2263         
2264         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2265         since so many basic layout tests have different results when compositing is triggered for
2266         overflow.
2267         
2268         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2269
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::TestController::resetPreferencesToConsistentValues):
2272
2273 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Retry API test in case of failures
2276         https://bugs.webkit.org/show_bug.cgi?id=196004
2277
2278         Reviewed by Lucas Forschler.
2279
2280         * BuildSlaveSupport/ews-build/steps.py:
2281         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2282         (CompileWebKitToT.doStepIf): Ditto.
2283         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2284         (ReRunAPITests): Re-run API tests.
2285         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2286         (RunAPITestsWithoutPatch): Run API tests without patch.
2287         (RunAPITestsWithoutPatch.doStepIf):
2288         (RunAPITestsWithoutPatch.hideStepIf):
2289         (RunAPITestsWithoutPatch.evaluateCommand):
2290         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2291         (AnalyzeAPITestsResults.start):
2292         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2293         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2294         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2295         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2296
2297 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2298
2299         [ews-build] Update queues configurations
2300         https://bugs.webkit.org/show_bug.cgi?id=196074
2301
2302         Reviewed by Dewei Zhu.
2303
2304         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2305         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2306
2307 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2308
2309         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2310         https://bugs.webkit.org/show_bug.cgi?id=195680
2311         <rdar://problem/48903534>
2312
2313         Unreviewed infrastructure fix.
2314
2315         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2316         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2317
2318 2019-03-21  Andy Estes  <aestes@apple.com>
2319
2320         [iOS] Apple Pay should be available in documents with no user agent scripts
2321         https://bugs.webkit.org/show_bug.cgi?id=196061
2322         <rdar://problem/48649391>
2323
2324         Reviewed by Brady Eidson.
2325
2326         Added API tests and related infrastructure.
2327
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2330         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2331         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2332         (TestWebKitAPI::TEST):
2333         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2334         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2335         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2336         * TestWebKitAPI/cocoa/TestProtocol.mm:
2337         (-[TestProtocol startLoading]):
2338         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2339         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2340         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2341         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2342
2343 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2344
2345         REGRESSSION (r243297): webkitpy tests broken
2346         https://bugs.webkit.org/show_bug.cgi?id=196108
2347
2348         Reviewed by Aakash Jain.
2349
2350         r243297 updated contributors.json, which broke a few unit tests.
2351
2352         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2353         (IRCCommandTest.test_whois):
2354         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2355
2356 2019-03-21  Chris Dumez  <cdumez@apple.com>
2357
2358         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2359         https://bugs.webkit.org/show_bug.cgi?id=196041
2360         <rdar://problem/49083230>
2361
2362         Reviewed by Alex Christensen.
2363
2364         Add API test coverage.
2365
2366         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2367         (TEST):
2368
2369 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2370
2371         Add SPI to inform applications of WKContentRuleList actions
2372         https://bugs.webkit.org/show_bug.cgi?id=195965
2373         <rdar://problem/42664365>
2374
2375         Reviewed by Geoff Garen.
2376
2377         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2378         (TestWebKitAPI::allActionsForResourceLoad):
2379         (TestWebKitAPI::testRequest):
2380         (TestWebKitAPI::TEST_F):
2381         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2382         (Notification::description):
2383         (Notification::operator== const):
2384         (toVector):
2385         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2386         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2387         (makeContentRuleList):
2388         (TEST):
2389         (makeWarnContentRuleList): Deleted.
2390
2391 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2392
2393         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2394         https://bugs.webkit.org/show_bug.cgi?id=196088
2395
2396         Reviewed by Brian Burg.
2397
2398         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2399         Support checks when only one platform is specified. Also deprecate macosx() and
2400         force the use of macos() instead.
2401
2402         * Scripts/webkitpy/style/checkers/cpp.py:
2403         (check_min_versions_of_wk_api_available):
2404         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2405         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2406
2407 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2408
2409         Update status inactive committers' status to 'contributor'.
2410
2411         * Scripts/webkitpy/common/config/contributors.json:
2412
2413 2019-03-21  Xan Lopez  <xan@igalia.com>
2414
2415         [JSC][x86] Drop support for x87 floating point
2416         https://bugs.webkit.org/show_bug.cgi?id=194853
2417
2418         Reviewed by Don Olmstead.
2419
2420         Force SSE2 on x86/32bit builds.
2421
2422         * Scripts/webkitdirs.pm:
2423         (generateBuildSystemFromCMakeProject):
2424
2425 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2426
2427         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2428         https://bugs.webkit.org/show_bug.cgi?id=196073
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         Add test cases to check functions and constructors with no arguments but receiving user data.
2433
2434         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2435         (checkUserData):
2436         (testJSCFunction):
2437         (fooCreateWithUserData):
2438         (testJSCClass):
2439
2440 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2441
2442         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2443
2444         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2445
2446         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2447
2448 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2449
2450         [GTK][WPE] Add API to provide geolocation information
2451         https://bugs.webkit.org/show_bug.cgi?id=195940
2452
2453         Reviewed by Michael Catanzaro.
2454
2455         Add a new test to check the new API.
2456
2457         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2458         (testGeolocationManagerCurrentPosition):
2459         (testGeolocationManagerWatchPosition):
2460         (beforeAll):
2461         (afterAll):
2462         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2463         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2464         (beforeAll): Ditto.
2465         * TestWebKitAPI/glib/CMakeLists.txt:
2466
2467 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2468
2469         [GLib] Returning G_TYPE_OBJECT from a method does not work
2470         https://bugs.webkit.org/show_bug.cgi?id=195574
2471
2472         Reviewed by Michael Catanzaro.
2473
2474         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2475
2476         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2477         (getGFile):
2478         (getParent):
2479         (createGString):
2480         (getGString):
2481         (getGStringCopyWillRaise):
2482         (getGStringCopy):
2483         (getGStringStr):
2484         (getGStringLen):
2485         (freeGString):
2486         (testJSCClass):
2487
2488 2019-03-20  Saam Barati  <sbarati@apple.com>
2489
2490         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2491         https://bugs.webkit.org/show_bug.cgi?id=195721
2492
2493         Reviewed by Filip Pizlo.
2494
2495         * Scripts/run-javascriptcore-tests:
2496
2497 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2498
2499         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2500         https://bugs.webkit.org/show_bug.cgi?id=196049
2501
2502         Reviewed by Tim Horton.
2503
2504         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2505         overflow scrolling in general, so rename it.
2506
2507         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2508
2509 2019-03-20  Daniel Bates  <dabates@apple.com>
2510
2511         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2512         https://bugs.webkit.org/show_bug.cgi?id=196031
2513         <rdar://problem/49078172>
2514
2515         Reviewed by Tim Horton.
2516
2517         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2518         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2519         same code path used when the Done button is pressed to dismiss the <select> picker.
2520
2521         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2522         (TestWebKitAPI::TEST):
2523
2524 2019-03-20  Chris Dumez  <cdumez@apple.com>
2525
2526         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2527         https://bugs.webkit.org/show_bug.cgi?id=196029
2528         <rdar://problem/48954651>
2529
2530         Reviewed by Tim Horton.
2531
2532         Add API test coverage.
2533
2534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2535
2536 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2537
2538         [ews-build] Improve failure summary string for ApplyPatch step
2539         https://bugs.webkit.org/show_bug.cgi?id=195995
2540
2541         Reviewed by Alexey Proskuryakov.
2542
2543         * BuildSlaveSupport/ews-build/steps.py:
2544         (ApplyPatch.getResultSummary): Override getResultSummary.
2545
2546 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2547
2548         AX: Implement support for new meter ARIA role
2549         https://bugs.webkit.org/show_bug.cgi?id=195966
2550
2551         Reviewed by Chris Fleizach.
2552
2553         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2554         to AXLevelIndicator.
2555
2556         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2557
2558 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2559
2560         [WebAuthN] Implement FIDO AppID extension
2561         https://bugs.webkit.org/show_bug.cgi?id=143491
2562         <rdar://problem/48298273>
2563
2564         Reviewed by Brent Fulgham.
2565
2566         Add a test that covers the new flag of convertToU2fSignCommand.
2567
2568         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2569         (TestWebKitAPI::TEST):
2570         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2571         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2572         (TestWebKitAPI::TEST):
2573
2574 2019-03-19  Keith Rollin  <krollin@apple.com>
2575
2576         Add support for more platforms to generate-xcfilelists
2577         https://bugs.webkit.org/show_bug.cgi?id=195977
2578
2579         Reviewed by Alexey Proskuryakov.
2580
2581         generate-xcfilelists incorrectly complains when involved with building
2582         WebKit for iphonesimulator:
2583
2584             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2585             …
2586             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2587
2588         Address this by teaching generate-xcfilelists about more platforms.
2589
2590         * Scripts/generate-xcfilelists:
2591
2592 2019-03-19  John Wilander  <wilander@apple.com>
2593
2594         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2595         https://bugs.webkit.org/show_bug.cgi?id=195923
2596         <rdar://problem/49001272>
2597
2598         Reviewed by Alex Christensen.
2599
2600         This patch does the following to the TestRunner:
2601         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2602         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2603         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2604
2605         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2606         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2607         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2608         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2609         * WebKitTestRunner/TestController.cpp:
2610         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2611         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2612         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2613         * WebKitTestRunner/TestController.h:
2614         * WebKitTestRunner/TestInvocation.cpp:
2615         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2616
2617 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2618
2619         [CMake] Support more clang and gcc sanitizers
2620         https://bugs.webkit.org/show_bug.cgi?id=195956
2621
2622         Reviewed by Michael Catanzaro.
2623
2624         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2625
2626 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2627
2628         [ews-build] Improve summary for PrintConfiguration step
2629         https://bugs.webkit.org/show_bug.cgi?id=195945
2630
2631         Reviewed by Lucas Forschler.
2632
2633         * BuildSlaveSupport/ews-build/steps.py:
2634         (PrintConfiguration.getResultSummary): Override getResultSummary.
2635
2636 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2637
2638         [ews-build] Improve summary for CheckOutSource step
2639         https://bugs.webkit.org/show_bug.cgi?id=195963
2640
2641         Reviewed by Lucas Forschler.
2642
2643         * BuildSlaveSupport/ews-build/steps.py:
2644         (CheckOutSource.getResultSummary):
2645
2646 2019-03-19  Daniel Bates  <dabates@apple.com>
2647
2648         [iOS] Focus not preserved when switching between tabs
2649         https://bugs.webkit.org/show_bug.cgi?id=195820
2650         <rdar://problem/43614450>
2651
2652         Reviewed by Brent Fulgham.
2653
2654         Add tests to ensure that we restore focus when resigning and becoming first responder.
2655
2656         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2657         (TestWebKitAPI::TEST):
2658
2659 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2660
2661         Make WTFLogChannelState and WTFLogLevel enum classes
2662         https://bugs.webkit.org/show_bug.cgi?id=195904
2663
2664         Reviewed by Eric Carlson.
2665
2666         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2667         (TestWebKitAPI::TEST_F):
2668
2669 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2670
2671         [GStreamer][EME] Backported mssdemux protection data crash fix
2672         https://bugs.webkit.org/show_bug.cgi?id=195918
2673
2674         Reviewed by Philippe Normand.
2675
2676         * gstreamer/jhbuild.modules:
2677         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2678
2679 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2680
2681         Unreviewed, rolling out r243132.
2682
2683         Broke GTK build
2684
2685         Reverted changeset:
2686
2687         "Make WTFLogChannelState and WTFLogLevel enum classes"
2688         https://bugs.webkit.org/show_bug.cgi?id=195904
2689         https://trac.webkit.org/changeset/243132
2690
2691 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2692
2693         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2694
2695         * Scripts/webkitdirs.pm:
2696         (builtDylibPathForName): Adjust the shared library name that's changed
2697         with the API version bump in r243073.
2698
2699 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2700
2701         Make WTFLogChannelState and WTFLogLevel enum classes
2702         https://bugs.webkit.org/show_bug.cgi?id=195904
2703
2704         Reviewed by Eric Carlson.
2705
2706         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2707         (TestWebKitAPI::TEST_F):
2708
2709 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2710
2711         Disable flaky test added in r2431100
2712         https://webkit.org/b/195785
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2715         (TestWebKitAPI::TEST):
2716         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2717
2718 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2719
2720         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2721         https://bugs.webkit.org/show_bug.cgi?id=195916
2722
2723         Reviewed by Tim Horton.
2724
2725         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2726         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2727
2728 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2729
2730         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2731
2732         * Scripts/webkitpy/common/config/contributors.json:
2733
2734 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2735
2736         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2737         https://bugs.webkit.org/show_bug.cgi?id=195785
2738
2739         Reviewed by Geoffrey Garen.
2740
2741         * TestWebKitAPI/TCPServer.cpp: Added.
2742         (TestWebKitAPI::TCPServer::TCPServer):
2743         (TestWebKitAPI::TCPServer::~TCPServer):
2744         (TestWebKitAPI::TCPServer::socketBindListen):
2745         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2746         * TestWebKitAPI/TCPServer.h: Added.
2747         (TestWebKitAPI::TCPServer::port const):
2748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2749         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2750         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2751         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2752         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2753         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2754         (TestWebKitAPI::respondSlowly):
2755         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2756         (TestWebKitAPI::downloadAtRate):
2757         (TestWebKitAPI::TEST):
2758
2759 2019-03-18  Saam Barati  <sbarati@apple.com>
2760
2761         Add a plan file for JetStream 2
2762         https://bugs.webkit.org/show_bug.cgi?id=190734
2763
2764         Reviewed by Mark Lam.
2765
2766         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2767
2768 2019-03-18  Chris Dumez  <cdumez@apple.com>
2769
2770         Delay WebProcess launch until a load is triggered in a Web view
2771         https://bugs.webkit.org/show_bug.cgi?id=195758
2772         <rdar://problem/48126013>
2773
2774         Reviewed by Geoff Garen.
2775
2776         Add API test coverage. Also update some existing API tests to not expect
2777         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2778
2779         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2780         (TestWebKitAPI::TEST):
2781         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2782         (TestWebKitAPI::TEST):
2783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2784         (TEST):
2785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2786         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2787         (TEST):
2788         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2789         (TEST):
2790         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2791
2792 2019-03-18  Xan Lopez  <xan@igalia.com>
2793
2794         [CMake] Prevent potential warning when determining $architecture
2795         https://bugs.webkit.org/show_bug.cgi?id=195891
2796
2797         Reviewed by Michael Catanzaro.
2798
2799         It's possible for generateBuildSystemForCMakeProject to be called
2800         before determineArchitecture() is ever called. This will make the
2801         first eq check with $architecture to be bogus (and print a
2802         warning). Change that to an eq check with architecture(), which
2803         implicitly calls determineArchitecture() if needed, and change all
2804         the other similar cases in the method in the same way to prevent
2805         future bugs like this one.
2806
2807         * Scripts/webkitdirs.pm:
2808         (generateBuildSystemFromCMakeProject):
2809
2810 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2811
2812         [WPE] Tarballs generated with “make dist” cannot build documentation
2813         https://bugs.webkit.org/show_bug.cgi?id=195885
2814
2815         Reviewed by Carlos Garcia Campos.
2816
2817         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2818
2819 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2820
2821         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2822         https://bugs.webkit.org/show_bug.cgi?id=195883
2823
2824         Reviewed by Carlos Garcia Campos.
2825
2826         * gtkdoc/gtkdoc.py:
2827         (GTKDoc._run_command): When commands fail to run, include the full command line for
2828         the program invocation and the output it has generated on the standard error stream.
2829
2830 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2831
2832         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2833         https://bugs.webkit.org/show_bug.cgi?id=195786
2834
2835         Reviewed by Philippe Normand.
2836
2837         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2838         * wpe/jhbuild.modules: Ditto.
2839
2840 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2841
2842         [ews-build] Don't run clean builds on EWS builders
2843         https://bugs.webkit.org/show_bug.cgi?id=195851
2844
2845         Reviewed by Geoffrey Garen.
2846
2847         * BuildSlaveSupport/ews-build/factories.py:
2848
2849 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2850
2851         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2852         https://bugs.webkit.org/show_bug.cgi?id=195849
2853
2854         Reviewed by Chris Dumez.
2855
2856         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2859         (runWebsiteDataStoreCustomPaths):
2860
2861 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2862
2863         webkitpy: Upload test results
2864         https://bugs.webkit.org/show_bug.cgi?id=195755
2865         <rdar://problem/48896182>
2866
2867         Reviewed by Aakash Jain.
2868
2869         Establish a new format for uploading results that is not tied to layout tests, apply
2870         that format to webkitpy tests.
2871
2872         * Scripts/webkitpy/common/checkout/scm/git.py:
2873         (Git.native_branch): Return what branch the current checkout is on.
2874         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2875         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2876         * Scripts/webkitpy/common/checkout/scm/svn.py:
2877         (SVN.native_branch): Ditto.
2878         * Scripts/webkitpy/common/system/platforminfo.py:
2879         (PlatformInfo.build_version): Return a build version for Mac.
2880         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2881         (MockPlatformInfo.__init__):
2882         (MockPlatformInfo.build_version):
2883         * Scripts/webkitpy/results: Added.
2884         * Scripts/webkitpy/results/__init__.py: Added.
2885         * Scripts/webkitpy/results/options.py: Added.
2886         (upload_options): OptParse list for upload options.
2887         * Scripts/webkitpy/results/upload.py: Added.
2888         (Upload): Class which enforces the upload format expected by the results server.
2889         (Upload.Expectations):
2890         (Upload.create_configuration):
2891         (Upload.create_commit):
2892         (Upload.create_details):
2893         (Upload.create_run_stats):
2894         (Upload.create_test_result):
2895         (Upload.__init__):
2896         (Upload.Encoder): Encode Upload object as json.
2897         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2898         * Scripts/webkitpy/results/upload_unittest.py: Added.
2899         * Scripts/webkitpy/test/main.py:
2900         (Tester._parse_args): Add upload arguments.
2901         (Tester._run_tests): Allow results to be uploaded.
2902         * Scripts/webkitpy/test/runner.py:
2903         (Runner.__init__): Record which tests were run, rather than just counting them.
2904         (Runner.handle):
2905         * Scripts/webkitpy/test/runner_unittest.py:
2906         (RunnerTest.test_run):
2907         * Scripts/webkitpy/thirdparty/__init__.py:
2908         (AutoinstallImportHook.find_module): Add requests auto-install.
2909         (AutoinstallImportHook._install_requests):
2910         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2911         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2912
2913 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2914
2915         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2916         https://bugs.webkit.org/show_bug.cgi?id=195810
2917
2918         Reviewed by Tim Horton.
2919
2920         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2921         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2922         ending certain layout tests.
2923
2924         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2925         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2926         (-[TestRunnerWKWebView dealloc]):
2927         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2928
2929         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2930         helper method when destroying the web view, and when resetting state between tests.
2931
2932         * WebKitTestRunner/ios/TestControllerIOS.mm:
2933         (WTR::TestController::platformResetStateToConsistentValues):
2934
2935         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2936
2937 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2938
2939         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2940         https://bugs.webkit.org/show_bug.cgi?id=190350
2941         <rdar://problem/45089503>
2942
2943         Reviewed by Geoffrey Garen.
2944
2945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2946         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2947         (TEST):
2948         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2949         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2950         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2951         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2952         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2953         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2954         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2955         (runTest):
2956         (createDirectories):
2957         (TEST):
2958         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2959         (TEST):
2960         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2961         (TEST):
2962
2963 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2964
2965         Add support to WebPage for getting the contents as an attributed string.
2966         https://bugs.webkit.org/show_bug.cgi?id=195636
2967         rdar://problem/45055697
2968
2969         Reviewed by Tim Horton.
2970
2971         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2972         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2973
2974 2019-03-15  Chris Dumez  <cdumez@apple.com>
2975
2976         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2977         https://bugs.webkit.org/show_bug.cgi?id=195747
2978
2979         Reviewed by Geoff Garen.
2980
2981         Add API test coverage.
2982
2983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2984
2985 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2986
2987         Unreviewed, rolling out r242952.
2988
2989         Causing API failures on iOS Simulator
2990
2991         Reverted changeset:
2992
2993         "[PSON] Make sure the WebProcessCache is leverage when
2994         relaunching a process after termination"
2995         https://bugs.webkit.org/show_bug.cgi?id=195747
2996         https://trac.webkit.org/changeset/242952
2997
2998 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2999
3000         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3001         https://bugs.webkit.org/show_bug.cgi?id=195740
3002
3003         Reviewed by Ross Kirsling.
3004
3005         window.open doesn't work for WebKitBrowserWindow because it is not
3006         implemented yet.
3007
3008         1. Implemented createNewPage callback of WKPageUIClient.
3009         2. Changed MainWindow to take a BrowserWindow factory function
3010           instead of BrowserWindowType to be flexible to create
3011           BrowserWindow with extra settings.
3012         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3013           because it is not relevant with MainWindow anymore.
3014
3015         * MiniBrowser/win/Common.cpp:
3016         (parseCommandLine):
3017         * MiniBrowser/win/Common.h:
3018         (CommandLineOptions::CommandLineOptions):
3019         * MiniBrowser/win/MainWindow.cpp:
3020         (MainWindow::MainWindow):
3021         (MainWindow::create):
3022         (MainWindow::init):
3023         (MainWindow::WndProc):
3024         * MiniBrowser/win/MainWindow.h:
3025         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3026         (PrintWebUIDelegate::createWebViewWithRequest):
3027         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3028         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3029         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3030         (WebKitBrowserWindow::updateProxySettings):
3031         (WebKitBrowserWindow::createNewPage):
3032         * MiniBrowser/win/WebKitBrowserWindow.h:
3033         * MiniBrowser/win/WinMain.cpp:
3034         (wWinMain):
3035
3036 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3037
3038         Make it possible to test scrolling tree layer manipulation more easily
3039         https://bugs.webkit.org/show_bug.cgi?id=195780
3040
3041         Reviewed by Tim Horton.
3042         
3043         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3044         cuts off communication of scrolling tree scrolls back to the web process
3045         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3046         allows tests to trigger scrolls which run the scrolling tree layer positioning
3047         logic, but never get another commit from the web process that might mask
3048         scrolling tree bugs.
3049         
3050         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3051         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3052         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3053
3054         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3055         (WTR::UIScriptController::scrollUpdatesDisabled const):
3056         (WTR::UIScriptController::setScrollUpdatesDisabled):
3057         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3058         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3059         (WTR::UIScriptController::scrollUpdatesDisabled const):
3060         (WTR::UIScriptController::setScrollUpdatesDisabled):
3061         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3062         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3063         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3064         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3065         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3066         * WebKitTestRunner/ios/TestControllerIOS.mm:
3067         (WTR::TestController::platformResetStateToConsistentValues):
3068         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3069         (WTR::UIScriptController::scrollUpdatesDisabled const):
3070         (WTR::UIScriptController::setScrollUpdatesDisabled):
3071
3072 2019-03-14  Youenn Fablet  <youenn@apple.com>
3073
3074         Move IDB storage in private browsing mode to NetworkProcess
3075         https://bugs.webkit.org/show_bug.cgi?id=195602
3076
3077         Reviewed by Brady Eidson.
3078
3079         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3080         (TEST):
3081
3082 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-build] Make descriptionDone messages more readable
3085         https://bugs.webkit.org/show_bug.cgi?id=195760
3086
3087         Reviewed by Lucas Forschler.
3088
3089         * BuildSlaveSupport/ews-build/steps.py:
3090         * BuildSlaveSupport/ews-build/steps_unittest.py:
3091
3092 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3093
3094         [ews-build] Generate status-bubble hover-over messages
3095         https://bugs.webkit.org/show_bug.cgi?id=195680
3096
3097         Reviewed by Lucas Forschler.
3098
3099         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3100         (StatusBubble):
3101         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3102         on hover-over.
3103         (StatusBubble._iso_time):
3104         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3105         hover-over message.
3106         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3107
3108 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3109
3110         [ews-app] Gracefully handle the case when state_string is None
3111         https://bugs.webkit.org/show_bug.cgi?id=195753
3112
3113         Reviewed by Lucas Forschler.
3114
3115         * BuildSlaveSupport/ews-app/ews/models/build.py:
3116         * BuildSlaveSupport/ews-app/ews/models/step.py:
3117
3118 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-app] Status bubble display pending for currently running build step
3121         https://bugs.webkit.org/show_bug.cgi?id=195744
3122
3123         Reviewed by Lucas Forschler.
3124
3125         * BuildSlaveSupport/ews-build/events.py:
3126         (Events.stepStarted): If state_string is pending, replace it with step name.
3127
3128 2019-03-14  Chris Dumez  <cdumez@apple.com>
3129
3130         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3131         https://bugs.webkit.org/show_bug.cgi?id=195750
3132
3133         Reviewed by Geoffrey Garen.
3134
3135         Add API test coverage.
3136
3137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3138         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3139         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3140         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3141
3142 2019-03-14  Chris Dumez  <cdumez@apple.com>
3143
3144         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3145         https://bugs.webkit.org/show_bug.cgi?id=195747
3146
3147         Reviewed by Geoff Garen.
3148
3149         Add API test coverage.
3150
3151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3152
3153 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3154
3155         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3156         https://bugs.webkit.org/show_bug.cgi?id=195725
3157         <rdar://problem/48545062>
3158
3159         Reviewed by Tim Horton.
3160
3161         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3162         handler is nil.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3165         (TestWebKitAPI::TEST):
3166
3167 2019-03-13  Sam Weinig  <sam@webkit.org>
3168
3169         Add utility function to allow easy reverse range-based iteration of a container
3170         https://bugs.webkit.org/show_bug.cgi?id=195542
3171
3172         Reviewed by Antti Koivisto.
3173
3174         * TestWebKitAPI/CMakeLists.txt:
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3177         (TestWebKitAPI::TEST):
3178         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3179
3180 2019-03-13  Chris Dumez  <cdumez@apple.com>
3181
3182         Use a ServiceWorker process per registrable domain
3183         https://bugs.webkit.org/show_bug.cgi?id=195649
3184
3185         Reviewed by Youenn Fablet.
3186
3187         Update API test coverage.
3188
3189         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3190
3191 2019-03-13  Chris Dumez  <cdumez@apple.com>
3192
3193         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3194         https://bugs.webkit.org/show_bug.cgi?id=195684
3195         <rdar://problem/48294714>
3196
3197         Reviewed by Antti Koivisto.
3198
3199         Add API test coverage.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3202
3203 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3204
3205         [ews-app] Remove unused patch view
3206         https://bugs.webkit.org/show_bug.cgi?id=195669
3207
3208         Reviewed by Lucas Forschler.
3209
3210         * BuildSlaveSupport/ews-app/ews/urls.py:
3211         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3212
3213 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3214
3215         [ews-app] Use Buildbot result code variables
3216         https://bugs.webkit.org/show_bug.cgi?id=195668
3217
3218         Reviewed by Alexey Proskuryakov.
3219
3220         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3221         (Buildbot): Added Buildbot result code variables.
3222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3223         (StatusBubble._build_bubble): Used Buildbot result code variables.
3224
3225 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3226
3227         [Flatpak] Expand submodule recursively
3228         https://bugs.webkit.org/show_bug.cgi?id=195672
3229
3230         Building WPE with flatpak was impossible without that as it was raising an exception.
3231         Also update wpebackend-fdo to match what is built in jhbuild
3232
3233         Reviewed by Philippe Normand.
3234
3235         * flatpak/flatpakutils.py:
3236         (expand_submodules_recurse):
3237         (expand_manifest):
3238         * flatpak/org.webkit.WPEModules.yaml:
3239
3240 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [ews-app] status bubble should be hidden for certain builds
3243         https://bugs.webkit.org/show_bug.cgi?id=194597
3244
3245         Reviewed by Dewei Zhu.
3246
3247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3248         (StatusBubble._build_bubble):
3249         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3250         because the patch didn't have relevant changes.
3251         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3252         in production yet.
3253
3254 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3255
3256         [Win] Fix a slew of simple clang-cl warnings.
3257         https://bugs.webkit.org/show_bug.cgi?id=195652
3258
3259         Reviewed by Don Olmstead.
3260
3261         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3262         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3263
3264 2019-03-12  Justin Fan  <justin_fan@apple.com>
3265
3266         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3267         https://bugs.webkit.org/show_bug.cgi?id=195518
3268         <rdar://problem/46322356>
3269
3270         Reviewed by Myles C. Maxfield.
3271
3272         * DumpRenderTree/DerivedSources-input.xcfilelist:
3273         * DumpRenderTree/DerivedSources-output.xcfilelist:
3274
3275 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3276
3277         Unreviewed, rolling out r242825.
3278         https://bugs.webkit.org/show_bug.cgi?id=195648
3279
3280         "Broke webkitpy tests with my change to
3281         lldb_dump_class_layout.py" (Requested by rmorisset on
3282         #webkit).
3283
3284         Reverted changeset:
3285
3286         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3287         classes with suspicious padding"
3288         https://bugs.webkit.org/show_bug.cgi?id=195573
3289         https://trac.webkit.org/changeset/242825
3290
3291 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Show status bubbles while the patch is waiting in queue
3294         https://bugs.webkit.org/show_bug.cgi?id=195618
3295
3296         Reviewed by Lucas Forschler.
3297
3298         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3299         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3300         enabled in initial deployment.
3301         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3302         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3303         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3304         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3305         (StatusBubble._build_bubbles_for_patch):
3306
3307 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3308
3309         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3310         https://bugs.webkit.org/show_bug.cgi?id=195573
3311
3312         Reviewed by Simon Fraser.
3313
3314         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3315
3316         * Scripts/dump-class-layout:
3317         (main):
3318         * lldb/lldb_dump_class_layout.py:
3319         (ClassLayout.__init__):
3320         (ClassLayout._compute_padding_recursive):
3321         (LLDBDebuggerInstance.dump_layout_for_classname):
3322         (LLDBDebuggerInstance):
3323         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3324         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3325
3326 2019-03-12  Chris Dumez  <cdumez@apple.com>
3327
3328         Device Orientation access permission should be denied unless explicitly granted by the client
3329         https://bugs.webkit.org/show_bug.cgi?id=195625
3330
3331         Reviewed by Youenn Fablet.
3332
3333         add API test coverage.
3334
3335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3336         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3337         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3338         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3339         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3340         (runDeviceOrientationTest):
3341         (TEST):
3342         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3343         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3344
3345 2019-03-12  Jer Noble  <jer.noble@apple.com>
3346
3347         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3348         https://bugs.webkit.org/show_bug.cgi?id=195137
3349         <rdar://problem/48810307>
3350
3351         Reviewed by Eric Carlson.
3352
3353         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3354         (TestWebKitAPI::TEST):
3355
3356 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3357
3358         [ews-build] Change urls from uat to production
3359         https://bugs.webkit.org/show_bug.cgi?id=195566
3360
3361         Reviewed by Lucas Forschler.
3362
3363         * BuildSlaveSupport/ews-app/ews/config.py:
3364         * BuildSlaveSupport/ews-build/events.py:
3365         * BuildSlaveSupport/ews-build/steps.py:
3366
3367 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3368
3369         [ews-build] change max_builds for local-worker to 1
3370         https://bugs.webkit.org/show_bug.cgi?id=195568
3371
3372         Reviewed by Lucas Forschler.
3373
3374         * BuildSlaveSupport/ews-build/loadConfig.py:
3375
3376 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3377
3378         Fix the build
3379
3380         * TestRunnerShared/spi/PencilKitTestSPI.h:
3381         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3382
3383 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3384
3385         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3386         https://bugs.webkit.org/show_bug.cgi?id=194131
3387
3388         Reviewed by Michael Catanzaro.
3389
3390         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3391         (uriChanged):
3392         (testUnfinishedSubresourceLoad):
3393         (serverCallback):
3394         (beforeAll):
3395
3396 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3397
3398         WTF::Expected should use std::addressof instead of operator&
3399         https://bugs.webkit.org/show_bug.cgi?id=195604
3400
3401         Reviewed by Myles Maxfield.
3402
3403         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3404         (TestWebKitAPI::Unique::Unique):
3405         (TestWebKitAPI::Unique::operator&):
3406         (TestWebKitAPI::TEST):
3407
3408 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3409
3410         Add Optional to Forward.h.
3411         https://bugs.webkit.org/show_bug.cgi?id=195586
3412
3413         Reviewed by Darin Adler.
3414
3415         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3416         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3417         Remove unnecessary includes from headers.
3418
3419 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3420
3421         Add testing API to hit-test and scroll overflow scrollers
3422         https://bugs.webkit.org/show_bug.cgi?id=195278
3423
3424         Reviewed by Antti Koivisto.
3425         
3426         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3427         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3428         
3429         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3430
3431         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3432         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3433         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3434         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3435         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3436         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3437         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3438         (WTR::enclosingScrollViewIncludingSelf):
3439         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3440
3441 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3442
3443         API test WebKit.RequestTextInputContext fails on iOS
3444         https://bugs.webkit.org/show_bug.cgi?id=195585
3445
3446         Reviewed by Wenson Hsieh and Simon Fraser.
3447
3448         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3449         (applyStyle):
3450         (TEST):
3451         Add a viewport, so that the coordinates match up on iOS.
3452         Scroll by moving the UIScrollView's contentOffset.
3453
3454 2019-03-11  Chris Dumez  <cdumez@apple.com>
3455
3456         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3457         https://bugs.webkit.org/show_bug.cgi?id=195506
3458         <rdar://problem/48733477>
3459
3460         Reviewed by Alex Christensen.
3461
3462         Add API test coverage.
3463
3464         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3465
3466 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3467
3468         Adding myself to contributors.json
3469
3470         Unreviewed, addming myself to contributors.json .
3471
3472         * Scripts/webkitpy/common/config/contributors.json:
3473
3474 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3475
3476         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3477         https://bugs.webkit.org/show_bug.cgi?id=195511
3478         <rdar://problem/44873269>
3479
3480         Reviewed by Darin Adler.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3483         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3484         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3485         (TEST_F):
3486
3487 2019-03-11  Chris Dumez  <cdumez@apple.com>
3488
3489         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3490         https://bugs.webkit.org/show_bug.cgi?id=195561
3491
3492         Reviewed by Youenn Fablet.
3493
3494         Make sure the JS in the test requests for permission to receive device orientation events.
3495
3496         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3497
3498 2019-03-11  Youenn Fablet  <youenn@apple.com>
3499
3500         Allow storage quota increase by default in WTR
3501         https://bugs.webkit.org/show_bug.cgi?id=195541
3502
3503         Reviewed by Geoffrey Garen.
3504
3505         Allow storage quota increase by default in WTR.
3506         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3507         Use this for tests that explicitly need cache increase.
3508
3509         Instead of increasing quota by 2, make sure the next request is
3510         granted by adding all given parameters.
3511
3512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3514         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3515         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3517         * WebKitTestRunner/TestController.cpp:
3518         (WTR::TestController::setAllowStorageQuotaIncrease):
3519         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3520         * WebKitTestRunner/TestController.h:
3521         * WebKitTestRunner/TestInvocation.cpp:
3522         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3523         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3524         (WTR::TestController::cocoaResetStateToConsistentValues):
3525         (WTR::TestController::setAllowStorageQuotaIncrease):
3526         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3527         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3528         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3529
3530 2019-03-11  Xan Lopez  <xan@igalia.com>
3531
3532         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3533         https://bugs.webkit.org/show_bug.cgi?id=194147
3534
3535         Reviewed by Michael Saboff.
3536
3537         To make --32-bit work correctly on Linux/64bit we need to:
3538
3539         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3540         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3541         unfortunately CMake only allows us to do this during
3542         crosscompilation, which is overkill here.
3543         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3544         pkg-config detection module uses the x86 .pc files instead of the
3545         x86_64 ones.
3546         - Set the -m32 flags for the compiler.
3547
3548         * Scripts/webkitdirs.pm:
3549         (generateBuildSystemFromCMakeProject):
3550
3551 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3552
3553         Add MotionMark-1.1 plan file for run-benchmark script.
3554         https://bugs.webkit.org/show_bug.cgi?id=195481
3555
3556         Rubber-stamped by Darin Adler.
3557
3558         Run-benchmark script should support MontionMark-1.1.
3559
3560         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3561
3562 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3563
3564         [ews-app] Add support for submit-to-ews url
3565         https://bugs.webkit.org/show_bug.cgi?id=195477
3566
3567         Reviewed by Lucas Forschler.
3568
3569         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3570         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3571         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3572         * BuildSlaveSupport/ews-app/ews/urls.py:
3573         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3574
3575 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3576
3577         Unreviewed, rolling out r242688, r242643, r242624.
3578
3579         Caused multiple layout test failures and crashes on iOS and macOS.
3580
3581         Reverted changeset:
3582
3583         "requestAnimationFrame should execute before the next frame"
3584         https://bugs.webkit.org/show_bug.cgi?id=177484
3585         https://trac.webkit.org/changeset/242624/webkit
3586
3587         * Tracing/SystemTracePoints.plist:
3588
3589 2019-03-11  John Wilander  <wilander@apple.com>
3590
3591         Resource Load Statistics: Make it possible exclude localhost from classification
3592         https://bugs.webkit.org/show_bug.cgi?id=195474
3593         <rdar://problem/47520577>
3594
3595         Reviewed by Brent Fulgham.
3596
3597         This patch allows for localhost to be excluded from classification and
3598         treatment as a prevalent resource.
3599
3600         The WebKit Tools change adds a new function called
3601         testRunner.setStatisticsIsRunningTest() which can be used to control this
3602         behavior.
3603
3604         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3606         (WTR::TestRunner::setStatisticsIsRunningTest):
3607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3608         * WebKitTestRunner/TestController.cpp:
3609         (WTR::TestController::setStatisticsIsRunningTest):
3610         * WebKitTestRunner/TestController.h:
3611         * WebKitTestRunner/TestInvocation.cpp:
3612         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3613
3614 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3615
3616         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3617         https://bugs.webkit.org/show_bug.cgi?id=195560
3618
3619         Reviewed by Lucas Forschler.
3620
3621         * BuildSlaveSupport/ews-build/master.cfg:
3622
3623 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3624
3625         Unreviewed, rolling out r242698.
3626
3627         API test crashes on bots.
3628
3629         Reverted changeset:
3630
3631         "Add a WKContentRuleList variant that uses copied memory
3632         instead of mmap'd shared memory for class A containerized
3633         apps"
3634         https://bugs.webkit.org/show_bug.cgi?id=195511
3635         https://trac.webkit.org/changeset/242698
3636
3637 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3638
3639         [WPE] Enable web process sandbox
3640         https://bugs.webkit.org/show_bug.cgi?id=195169
3641
3642         Reviewed by Daniel Bates.
3643
3644         * wpe/install-dependencies:
3645         * wpe/jhbuild.modules:
3646
3647 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3648
3649         [ews-app] Use port 17000 for worker communication
3650         https://bugs.webkit.org/show_bug.cgi?id=195558
3651
3652         Reviewed by Lucas Forschler.
3653
3654         * BuildSlaveSupport/ews-build/master.cfg:
3655
3656 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3657
3658         [ews-build] unit-tests fail when passwords.json is missing
3659         https://bugs.webkit.org/show_bug.cgi?id=195557
3660
3661         Reviewed by Lucas Forschler.
3662
3663         * BuildSlaveSupport/ews-build/loadConfig.py:
3664         (loadBuilderConfig):
3665         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3666         (ConfigDotJSONTest.test_configuration):
3667         * BuildSlaveSupport/ews-build/master.cfg:
3668
3669 2019-03-11  Truitt Savell  <tsavell@apple.com>
3670
3671         Unreviewed, rolling out r242702.
3672
3673         Broke High Sierra builders.
3674
3675         Reverted changeset:
3676
3677         "Add utility function to allow easy reverse range-based
3678         iteration of a container"
3679         https://bugs.webkit.org/show_bug.cgi?id=195542
3680         https://trac.webkit.org/changeset/242702
3681
3682 2019-03-11  Sam Weinig  <sam@webkit.org>
3683
3684         Add utility function to allow easy reverse range-based iteration of a container
3685         https://bugs.webkit.org/show_bug.cgi?id=195542
3686
3687         Reviewed by Antti Koivisto.
3688
3689         * TestWebKitAPI/CMakeLists.txt:
3690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3691         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3692         (TestWebKitAPI::TEST):
3693         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3694
3695 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3696
3697         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3698         https://bugs.webkit.org/show_bug.cgi?id=195511
3699         <rdar://problem/44873269>
3700
3701         Reviewed by Darin Adler.
3702
3703         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3704         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3705         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3706         (TEST_F):
3707
3708 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3709
3710         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3711         https://bugs.webkit.org/show_bug.cgi?id=195499
3712
3713         Reviewed by Darin Adler.
3714
3715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3716         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3717         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3718         (-[WKWebView synchronouslyFocusTextInputContext:]):
3719         (applyStyle):
3720         (applyIframe):
3721         (TEST):
3722         Add some tests for this SPI.
3723
3724 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3725
3726         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3727         https://bugs.webkit.org/show_bug.cgi?id=181151
3728
3729         Reviewed by Don Olmstead.
3730
3731         * TestWebKitAPI/CMakeLists.txt:
3732         * TestWebKitAPI/PlatformWin.cmake:
3733         Enable TestWTF RunLoop tests in all platforms.
3734
3735         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3736         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3737         (TestWebKitAPI::DerivedOneShotTimer::fired):
3738         (TestWebKitAPI::TEST):
3739         Only a few platforms support nested RunLoop.
3740
3741         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3742         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3743
3744 2019-03-10  David Quesada  <david_quesada@apple.com>
3745
3746         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3747         https://bugs.webkit.org/show_bug.cgi?id=152480
3748
3749         Reviewed by Chris Dumez.
3750
3751         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3752         there are no additional references to the process pool besides the one held by
3753         the download, waits for the download to finish (in the sense that the
3754         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3755         measure, also check that the process pool has been deallocated at the end of the
3756         test. The test wouldn't be meaningful if the process pool were still alive.
3757
3758         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3759         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3760         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3761             The download will be canceled because the delegate does not implement the
3762             method to decide the download's destination, so this is where we know the
3763             DownloadProxyMap is done with the DownloadProxy.
3764         (TEST):
3765
3766 2019-03-08  Chris Dumez  <cdumez@apple.com>
3767
3768         Add support for Device Orientation / Motion permission API
3769         https://bugs.webkit.org/show_bug.cgi?id=195329
3770         <rdar://problem/47645367>
3771
3772         Reviewed by Geoffrey Garen.
3773
3774         Add test infrastructure to help test the Device Orientation / Motion permission API.
3775
3776         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3778         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3779         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3780         * WebKitTestRunner/TestController.cpp:
3781         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3782         (WTR::TestController::createWebViewWithOptions):
3783         (WTR::TestController::resetStateToConsistentValues):
3784         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3785         * WebKitTestRunner/TestController.h:
3786         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3787         * WebKitTestRunner/TestInvocation.cpp:
3788         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3789
3790 2019-03-08  Saam barati  <sbarati@apple.com>
3791
3792         Add a compare-results script to compare benchmark results
3793         https://bugs.webkit.org/show_bug.cgi?id=195486
3794         <rdar://problem/48723397>
3795
3796         Reviewed by Geoffrey Garen.
3797
3798         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3799         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3800         to extend it to learn about our other benchmarks.
3801
3802         * Scripts/compare-results: Added.
3803         (readJSONFile):
3804         (detectJetStream2):
3805         (JetStream2Results):
3806         (detectSpeedometer2):
3807         (Speedometer2Results):
3808         (detectPLT5):
3809         (PLT5Results):
3810         (detectBenchmark):
3811         (biggerIsBetter):
3812         (ttest):
3813         (getOptions):
3814         (main):
3815
3816 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3817
3818         Ensure old tab state is cleared between iterations of run-benchmark
3819         https://bugs.webkit.org/show_bug.cgi?id=195393
3820         <rdar://problem/46885583>
3821
3822         Reviewed by Dewei Zhu.
3823
3824         a) ensure the default to restore state is not set
3825         b) terminate Safari correctly
3826         c) Set the system default to ignore Persistent State in Safari
3827
3828         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3829         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3830         (OSXBrowserDriver.prepare_env): 
3831         (OSXBrowserDriver.restore_env):
3832         (OSXBrowserDriver.close_browsers):
3833         (OSXBrowserDriver._terminate_processes):
3834         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3835         (OSXChromeDriver):
3836         (OSXChromeCanaryDriver):
3837         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3838         (OSXFirefoxDriver):
3839         (OSXFirefoxNightlyDriver):
3840         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3841         (OSXSafariDriver):
3842         (OSXSafariDriver.prepare_env):
3843
3844 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3845
3846         [GTK] Several InputMethodFilter tests are failing
3847         https://bugs.webkit.org/show_bug.cgi?id=195408
3848
3849         Reviewed by Carlos Garcia Campos.
3850
3851         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3852         Regressed in r241751.
3853         Hexadecimal values of keycodes are expressed now in upper letters.
3854         Composited characters should be cast to UTF8 strings.
3855
3856         (TestWebKitAPI::TEST):
3857
3858 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3859
3860         [GTK] Make Tools/gtkdoc python3 compatible
3861         https://bugs.webkit.org/show_bug.cgi?id=195359
3862
3863         Reviewed by Carlos Garcia Campos.
3864
3865         * gtkdoc/generate-gtkdoc:
3866         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3867         work with Python 2 and 3.
3868         (get_gtkdoc_module_paths):
3869         The iteritems() was removed in Python 3, so let's use items() that's
3870         available in Python 2 and 3.
3871         (get_generator_for_config):
3872         * gtkdoc/gtkdoc.py:
3873         (GTKDoc._run_command):
3874         The sys.stdout.write() is expecting str in Python 3 and not bytes
3875         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3876         for passing the bytes there.
3877
3878 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3879
3880         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3881         https://bugs.webkit.org/show_bug.cgi?id=195346
3882         <rdar://problem/48667048>
3883
3884         Unreviewed build fix for clang-cl.
3885
3886         * DumpRenderTree/win/DumpRenderTree.cpp:
3887         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3888
3889 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3890
3891         requestAnimationFrame should execute before the next frame
3892         https://bugs.webkit.org/show_bug.cgi?id=177484
3893
3894         Reviewed by Simon Fraser.
3895
3896         Add trace points for the page RenderingUpdate.
3897
3898         * Tracing/SystemTracePoints.plist:
3899
3900 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3901
3902         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3903         https://bugs.webkit.org/show_bug.cgi?id=195353
3904         <rdar://problem/48626394>
3905
3906         Reviewed by Simon Fraser.
3907
3908         * WebKitTestRunner/ios/TestControllerIOS.mm:
3909         (WTR::TestController::platformResetPreferencesToConsistentValues):
3910
3911 2019-03-07  John Wilander  <wilander@apple.com>
3912
3913         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3914         https://bugs.webkit.org/show_bug.cgi?id=195383
3915         <rdar://problem/48570136>
3916
3917         Reviewed by Brent Fulgham.
3918
3919         This patch adds test infrastructure to purge only script-accessible cookies,
3920         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3921
3922         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3924         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3925         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3926         * WebKitTestRunner/TestController.cpp:
3927         (WTR::TestController::statisticsDeleteCookiesForHost):
3928         * WebKitTestRunner/TestController.h:
3929         * WebKitTestRunner/TestInvocation.cpp:
3930         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3931
3932 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3933
3934         Unreviewed, rolling out r242354.
3935         https://bugs.webkit.org/show_bug.cgi?id=195402
3936
3937         breaks layout tests in all configurations (Requested by
3938         zdobersek on #webkit).
3939
3940         Reverted changeset:
3941
3942         "[WPE] Enable web process sandbox"
3943         https://bugs.webkit.org/show_bug.cgi?id=195169
3944         https://trac.webkit.org/changeset/242354
3945
3946 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3947
3948         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3949         https://bugs.webkit.org/show_bug.cgi?id=195346
3950
3951         Reviewed by Fujii Hironori.
3952
3953         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3954         (TestWebKitAPI::TEST):
3955         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3956
3957         * DumpRenderTree/win/DumpRenderTree.cpp:
3958         (findFontFallback):
3959         (addFontFallbackIfPresent):
3960         (removeFontFallbackIfPresent):
3961         (main):
3962         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3963         (TestWebKitAPI::Util::moduleDirectory):
3964         (TestWebKitAPI::Util::createInjectedBundlePath):
3965         Use wchar helpers as needed.
3966
3967 2019-03-06  Rob Buis  <rbuis@igalia.com>
3968
3969         Consider supporting the `referrerpolicy` attribute.
3970         https://bugs.webkit.org/show_bug.cgi?id=179053
3971
3972         Reviewed by Darin Adler.
3973
3974         Add a runtime flag for referrerpolicy attribute.
3975
3976         * DumpRenderTree/mac/DumpRenderTree.mm:
3977         (enableExperimentalFeatures):
3978
3979 2019-03-05  Daniel Bates  <dabates@apple.com>
3980
3981         Update expected API test result following r242379
3982         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3983
3984         Update expected x-coordinate of selection rect now that the left padding of
3985         a textarea is sized in ems (so dependent on the font size) just like the left
3986         padding of a text field.
3987
3988         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3989         (TestWebKitAPI::TEST):
3990
3991 2019-03-05  David Quesada  <david_quesada@apple.com>
3992
3993         [WK2] It should be possible to follow links with 'download' attributes
3994         https://bugs.webkit.org/show_bug.cgi?id=195145
3995         rdar://problem/48462642
3996
3997         Reviewed by Alex Christensen.
3998
3999         Add a unit test to verify that activating links with 'download' attributes now
4000         navigates to the linked resource, rather than starts downloading it. Add another
4001         to verify that it is still possible to explicitly download the link via the
4002         'Download' navigation action policy.
4003
4004         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4005         (-[DownloadAttributeTestDelegate init]):
4006         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4007         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4008         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4009         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4010         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4011         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4012         (TEST):
4013         * WebKitTestRunner/TestController.cpp:
4014         (WTR::TestController::decidePolicyForNavigationAction):
4015         * WebKitTestRunner/TestController.h:
4016
4017 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4018
4019         [Curl] Implement Cookie Accept Policy.
4020         https://bugs.webkit.org/show_bug.cgi?id=191645
4021
4022         Reviewed by Fujii Hironori.
4023
4024         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4025         (TestWebKitAPI::Curl::TEST_F):
4026
4027 2019-03-05  Youenn Fablet  <youenn@apple.com>
4028
4029         Rename requestCacheStorageSpace to requestStorageSpace
4030         https://bugs.webkit.org/show_bug.cgi?id=195282
4031
4032         Reviewed by Chris Dumez.
4033
4034         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4035         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4036         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4037
4038 2019-03-05  Brady Eidson  <beidson@apple.com>
4039
4040         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4041         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4042
4043         Reviewed by Tim Horton.
4044
4045         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4046         different directory into that same WKWebView should work.
4047
4048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4049         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4050
4051 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4052
4053         Add WeakHashSet
4054         https://bugs.webkit.org/show_bug.cgi?id=195152
4055
4056         Reviewed by Antti Koivisto.
4057
4058         Added tests for WeakHashSet.
4059
4060         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4061         (TestWebKitAPI::Base::Base): Moved.
4062         (TestWebKitAPI::Derived::foo): Moved.
4063         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4064         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4065         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4066         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4067
4068 2019-03-04  Chris Dumez  <cdumez@apple.com>
4069
4070         Do not share WebProcesses between private and regular sessions
4071         https://bugs.webkit.org/show_bug.cgi?id=195189
4072         <rdar://problem/48421064>
4073
4074         Reviewed by Alex Christensen.
4075
4076         Add API test coverage.
4077
4078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4080
4081 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4082
4083         [WPE] Enable web process sandbox
4084         https://bugs.webkit.org/show_bug.cgi?id=195169
4085
4086         Reviewed by Daniel Bates.
4087
4088         * wpe/install-dependencies:
4089         * wpe/jhbuild.modules:
4090
4091 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4092
4093         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4094         https://bugs.webkit.org/show_bug.cgi?id=195206
4095
4096         Reviewed by Žan Doberšek.
4097
4098         Add a new test case.
4099
4100         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4101         (testJSCClass):
4102
4103 2019-03-04  Charlie Turner  <cturner@igalia.com>
4104
4105         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4106         https://bugs.webkit.org/show_bug.cgi?id=194898
4107
4108         Reviewed by Žan Doberšek.
4109
4110         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4111         a GCC extension that permits arithmetic on void* pointer. Inline
4112         the macro until this issue is fixed upstream.
4113
4114 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4115
4116         Rid the world of WK_API_ENABLED
4117         https://bugs.webkit.org/show_bug.cgi?id=195263
4118
4119         Reviewed by Dan Bernstein.
4120
4121         List of changed files elided because it's useless.
4122
4123 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4124
4125         Unreviewed follow-up to r242292.
4126
4127         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4128
4129         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4130         (TestWebKitAPI::testStrip): Renamed from strip.
4131         (TestWebKitAPI::TEST):
4132
4133 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4134
4135         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4136
4137         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4138         and bug #194272 for details.
4139
4140         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4141
4142 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4143
4144         Remove some more unused 32-bit code
4145         https://bugs.webkit.org/show_bug.cgi?id=195255
4146
4147         Reviewed by Darin Adler.
4148
4149         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4150         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4151         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4152         (NPP_New):
4153         (NPP_HandleEvent):
4154         (handleEventCarbon): Deleted.
4155
4156 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4157
4158         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4159
4160         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4161         (TestWebKitAPI::TEST):
4162
4163 2019-03-01  Darin Adler  <darin@apple.com>
4164
4165         Finish removing String::format
4166         https://bugs.webkit.org/show_bug.cgi?id=194893
4167
4168         Reviewed by Daniel Bates.
4169 '
4170         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4171
4172 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4173
4174         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4175         https://bugs.webkit.org/show_bug.cgi?id=195229
4176         <rdar://problem/48520362>
4177
4178         Reviewed by Chris Dumez.
4179
4180         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4181         (TEST):
4182
4183 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4184
4185         Add a system trace scope for event region building
4186         https://bugs.webkit.org/show_bug.cgi?id=195226
4187
4188         Reviewed by Jon Lee.
4189
4190         This trace scope measures the time spend converting element rects into Region objects,
4191         which can be large on some pages.
4192
4193         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4194
4195         * Tracing/SystemTracePoints.plist:
4196
4197 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4198
4199         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4200         https://bugs.webkit.org/show_bug.cgi?id=194612
4201
4202         Reviewed by Alex Christensen.
4203
4204         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4205         Just test the new string-processing function and don't touch the actual environment.
4206         (Test cases are all as before, but based on operator== instead of strcmp.)
4207
4208 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4209
4210         [ews-app] Update primary keys for handling multiple Buildbot instances
4211         https://bugs.webkit.org/show_bug.cgi?id=195120
4212
4213         Reviewed by Stephanie Lewis.
4214
4215         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4216         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4217         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4218
4219         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4220         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4221         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4222         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4223         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4224         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4225
4226 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4227
4228         [WinCairo] Enable service worker
4229         https://bugs.webkit.org/show_bug.cgi?id=188318
4230
4231         Reviewed by Youenn Fablet.
4232
4233         * DumpRenderTree/DumpRenderTreePrefix.h:
4234         * TestWebKitAPI/PlatformWin.cmake:
4235         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4236         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4237         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4238
4239 2019-03-01  Justin Fan  <justin_fan@apple.com>
4240
4241         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4242         https://bugs.webkit.org/show_bug.cgi?id=195191
4243
4244         Rubber-stamped by Dean Jackson.
4245
4246         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4247
4248         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4249
4250 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4251
4252         Unreviewed, fix lldb webkitpy tests
4253         https://bugs.webkit.org/show_bug.cgi?id=194375
4254
4255         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4256
4257         * lldb/lldb_webkit.py:
4258         (WTFStringImplProvider.is_8bit):
4259
4260 2019-02-28  David Quesada  <david_quesada@apple.com>
4261
4262         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4263         https://bugs.webkit.org/show_bug.cgi?id=195121
4264         rdar://problem/48450302
4265
4266         Reviewed by Alex Christensen.
4267
4268         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4269         configurations where the 'download' attribute is absent, blank, or populated
4270         with a filename, and where the anchor element is same-origin or cross-origin
4271         (meaning the 'download' attribute shouldn't be honored).
4272
4273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4274         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4275         (-[NavigationActionTestDelegate init]):
4276         (-[NavigationActionTestDelegate navigationAction]):
4277         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4278         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4279         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4280         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4281         (TEST):
4282
4283 2019-02-28  Antoine Quint  <graouts@apple.com>
4284
4285         Enable the Pointer Events runtime flag by default
4286         https://bugs.webkit.org/show_bug.cgi?id=195156
4287
4288         Reviewed by Dean Jackson.
4289
4290         * DumpRenderTree/mac/DumpRenderTree.mm:
4291         (enableExperimentalFeatures):
4292
4293 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4294
4295         Several PasteImage API tests are flaky
4296         https://bugs.webkit.org/show_bug.cgi?id=195160
4297
4298         Reviewed by Tim Horton.
4299
4300         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4301         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4302         listening for a "load" event after image load is already complete.
4303
4304         To address this, make these tests first register a "load" event handler, then run script to insert an image
4305         element into the document, and finally wait until the load event is observed before checking image size.
4306
4307         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4308
4309 2019-02-28  Chris Dumez  <cdumez@apple.com>
4310
4311         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4312         https://bugs.webkit.org/show_bug.cgi?id=195107
4313
4314         Reviewed by Alex Christensen.
4315
4316         Give some time for the zoom level to get restored.
4317
4318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4319
4320 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4321
4322         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4323         https://bugs.webkit.org/show_bug.cgi?id=194958
4324
4325         Reviewed by Geoffrey Garen.
4326
4327         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4328         (TEST):
4329
4330 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4331
4332         [ews-app] Update method to save build to handle builder_display_name
4333         https://bugs.webkit.org/show_bug.cgi?id=195047
4334
4335         Reviewed by Dewei Zhu.
4336
4337         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4338         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4339
4340 2019-02-28  Justin Fan  <justin_fan@apple.com>
4341
4342         [Web GPU] Enable Web GPU only on 64-bit
4343         https://bugs.webkit.org/show_bug.cgi?id=195139
4344
4345         Because Metal is only supported on 64 bit apps.
4346
4347         Unreviewed build fix.
4348
4349         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4350
4351 2019-02-27  Youenn Fablet  <youenn@apple.com>
4352
4353         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4354         https://bugs.webkit.org/show_bug.cgi?id=194959
4355
4356         Reviewed by Chris Dumez.
4357
4358         Spin loop until getting the condition to remove flakiness.
4359
4360         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4361
4362 2019-02-27  Aakash Jain  <aakash_jain@apple.com>