[CMake] Make WebCore headers copies
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake] Make WebCore headers copies
4         https://bugs.webkit.org/show_bug.cgi?id=182512
5         <rdar://problem/37510435>
6
7         Reviewed by Alex Christensen.
8
9         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
10         ports.
11
12         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
13         of WebCore headers using "*.h" were modified to <WebCore/*.h>
14
15         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
16         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
17         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
18         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
19         * TestWebKitAPI/CMakeLists.txt:
20         * TestWebKitAPI/PlatformWin.cmake:
21         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
22         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
23         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
24
25 2019-04-18  Jer Noble  <jer.noble@apple.com>
26
27         Add support for parsing FairPlayStreaming PSSH boxes.
28         https://bugs.webkit.org/show_bug.cgi?id=197064
29
30         Reviewed by Eric Carlson.
31
32         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
33         (TestWebKitAPI::TEST):
34
35 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
36
37         InjectedBundle parameters often need initialization function called before unarchiving
38         https://bugs.webkit.org/show_bug.cgi?id=189709
39         <rdar://problem/44573653>
40
41         Reviewed by Ryosuke Niwa.
42
43         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
44         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
45
46 2019-04-18  Zalan Bujtas  <zalan@apple.com>
47
48         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
49         https://bugs.webkit.org/show_bug.cgi?id=196948
50         <rdar://problem/49927131>
51
52         Reviewed by Tim Horton.
53
54         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
55         (TEST): 
56         The expected order of incoming events is
57         1. didInvalidateIntrinsicContentSize
58         2. didFirstLayout
59         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
60         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
61         (and remember, all we care about is ordering).
62
63 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
64
65         Unreviewed, rolling out r244299.
66
67         Breaks internal tests.
68
69         Reverted changeset:
70
71         "InjectedBundle parameters often need initialization function
72         called before unarchiving"
73         https://bugs.webkit.org/show_bug.cgi?id=189709
74         https://trac.webkit.org/changeset/244299
75
76 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
77
78         [WTF] StringBuilder should set correct m_is8Bit flag when merging
79         https://bugs.webkit.org/show_bug.cgi?id=197053
80
81         Reviewed by Saam Barati.
82
83         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
84         (TestWebKitAPI::TEST):
85
86 2019-04-17  Tim Horton  <timothy_horton@apple.com>
87
88         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
89         https://bugs.webkit.org/show_bug.cgi?id=197028
90         <rdar://problem/49985290>
91
92         Reviewed by Wenson Hsieh.
93
94         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
95         (TEST):
96         Liberal application of waitForNextPresentationUpdate works around a race
97         where if the page rapidly changes its viewport arguments (or an API client
98         rapidly changes its viewport arguments), we'd get stuck thinking that the
99         user had intentionally zoomed the page, and stop resetting the initial scale.
100         This deserves a separate bug, but no need to keep the test failing while
101         we think about it.
102
103 2019-04-17  Tim Horton  <timothy_horton@apple.com>
104
105         REGRESSION (r241988): Switching tabs is slow
106         https://bugs.webkit.org/show_bug.cgi?id=197037
107         <rdar://problem/49951473>
108
109         Reviewed by Simon Fraser.
110
111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
112         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
113         (TEST):
114         * TestWebKitAPI/cocoa/TestWKWebView.h:
115         * TestWebKitAPI/cocoa/TestWKWebView.mm:
116         (-[TestWKWebView addToTestWindow]):
117         Add a test that hangs without this fix.
118
119 2019-04-17  Truitt Savell  <tsavell@apple.com>
120
121         Unreviewed, rolling out r244400.
122
123         Caused testing to exit early with assertionon Debug WK2
124
125         Reverted changeset:
126
127         "UI↔Web deadlock when printing with a JavaScript alert
128         visible"
129         https://bugs.webkit.org/show_bug.cgi?id=196839
130         https://trac.webkit.org/changeset/244400
131
132 2019-04-17  Brady Eidson  <beidson@apple.com>
133
134         Link clicks in PDFs shouldn't send referrer headers.
135         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
136
137         Reviewed by Tim Horton.
138
139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
140         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
141         (putPDFBytesCallback):
142         (emptyReleaseInfoCallback):
143         (createPDFWithLinkToURL):
144         (TEST):
145
146 2019-04-17  Tim Horton  <timothy_horton@apple.com>
147
148         UI↔Web deadlock when printing with a JavaScript alert visible
149         https://bugs.webkit.org/show_bug.cgi?id=196839
150         <rdar://problem/49157642>
151
152         Reviewed by Andy Estes.
153
154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
155         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
156         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
157         (TEST):
158
159 2019-04-17  Alex Christensen  <achristensen@webkit.org>
160
161         WKRetainPtr's adoption constructor should be private
162         https://bugs.webkit.org/show_bug.cgi?id=197019
163
164         Reviewed by Tim Horton.
165
166         * DumpRenderTree/mac/DumpRenderTree.mm:
167         (dumpFramesAsText):
168         * TestWebKitAPI/InjectedBundleController.cpp:
169         (TestWebKitAPI::InjectedBundleController::initialize):
170         * TestWebKitAPI/PlatformUtilities.cpp:
171         (TestWebKitAPI::Util::createContextWithInjectedBundle):
172         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
173         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
174         (TestWebKitAPI::Util::toWK):
175         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
178         (TestWebKitAPI::TEST):
179         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
184         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
185         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
186         (TestWebKitAPI::TEST):
187         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
188         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
189         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
192         (TestWebKitAPI::TEST):
193         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
194         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
195         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
196         (TestWebKitAPI::TEST):
197         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
198         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
199         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
202         (TestWebKitAPI::TEST):
203         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
206         (TestWebKitAPI::TEST):
207         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit/Find.cpp:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
212         (TestWebKitAPI::TEST):
213         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
216         (TestWebKitAPI::TEST):
217         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
222         (TestWebKitAPI::TEST):
223         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
230         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
231         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
232         (TestWebKitAPI::TEST):
233         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
234         (TestWebKitAPI::TEST):
235         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
236         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
237         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
238         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
239         (TestWebKitAPI::TEST):
240         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
241         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
242         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
247         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
248         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
251         (TestWebKitAPI::loadAlternateHTMLString):
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
256         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
257         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
258         (TestWebKitAPI::buildAndPerformTest):
259         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
262         (TestWebKitAPI::TEST):
263         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
266         (TestWebKitAPI::TEST):
267         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
268         (TestWebKitAPI::TEST):
269         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
270         (TestWebKitAPI::TEST):
271         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
274         (TestWebKitAPI::TEST):
275         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
276         (TestWebKitAPI::TEST):
277         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
278         (TestWebKitAPI::TEST):
279         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
280         (TestWebKitAPI::TEST):
281         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
284         (TestWebKitAPI::TEST):
285         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
288         (TestWebKitAPI::TEST):
289         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
294         (TestWebKitAPI::TEST):
295         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
298         (TestWebKitAPI::TEST):
299         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
318         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
319         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
324         (TestWebKitAPI::TEST):
325         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
326         (TestWebKitAPI::TEST):
327         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
332         (TestWebKitAPI::TEST):
333         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
334         (TestWebKitAPI::TEST):
335         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
341         (TEST):
342         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
343         (TEST):
344         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
345         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
346         (TEST):
347         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
350         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
351         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
352         (WTR::getMenuItemTitleCallback):
353         (WTR::createMouseMessageBody):
354         (WTR::EventSendingController::mouseDown):
355         (WTR::EventSendingController::mouseUp):
356         (WTR::EventSendingController::mouseMoveTo):
357         (WTR::EventSendingController::mouseForceClick):
358         (WTR::EventSendingController::startAndCancelMouseForceClick):
359         (WTR::EventSendingController::mouseForceDown):
360         (WTR::EventSendingController::mouseForceUp):
361         (WTR::EventSendingController::mouseForceChanged):
362         (WTR::EventSendingController::leapForward):
363         (WTR::EventSendingController::scheduleAsynchronousClick):
364         (WTR::createKeyDownMessageBody):
365         (WTR::EventSendingController::keyDown):
366         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
367         (WTR::EventSendingController::mouseScrollBy):
368         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
369         (WTR::EventSendingController::continuousMouseScrollBy):
370         (WTR::EventSendingController::addTouchPoint):
371         (WTR::EventSendingController::updateTouchPoint):
372         (WTR::EventSendingController::setTouchModifier):
373         (WTR::EventSendingController::setTouchPointRadius):
374         (WTR::EventSendingController::touchStart):
375         (WTR::EventSendingController::touchMove):
376         (WTR::EventSendingController::touchEnd):
377         (WTR::EventSendingController::touchCancel):
378         (WTR::EventSendingController::clearTouchPoints):
379         (WTR::EventSendingController::releaseTouchPoint):
380         (WTR::EventSendingController::cancelTouchPoint):
381         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
382         (WTR::InjectedBundle::didCreatePage):
383         (WTR::InjectedBundle::didReceiveMessage):
384         (WTR::InjectedBundle::didReceiveMessageToPage):
385         (WTR::InjectedBundle::booleanForKey):
386         (WTR::InjectedBundle::done):
387         (WTR::InjectedBundle::dumpToStdErr):
388         (WTR::InjectedBundle::outputText):
389         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
390         (WTR::InjectedBundle::postAddChromeInputField):
391         (WTR::InjectedBundle::postRemoveChromeInputField):
392         (WTR::InjectedBundle::postFocusWebView):
393         (WTR::InjectedBundle::postSetBackingScaleFactor):
394         (WTR::InjectedBundle::postSetWindowIsKey):
395         (WTR::InjectedBundle::postSetViewSize):
396         (WTR::InjectedBundle::postSimulateWebNotificationClick):
397         (WTR::InjectedBundle::postSetAddsVisitedLinks):
398         (WTR::InjectedBundle::setGeolocationPermission):
399         (WTR::InjectedBundle::setMockGeolocationPosition):
400         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
401         (WTR::InjectedBundle::isGeolocationProviderActive const):
402         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
403         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
404         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
405         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
406         (WTR::InjectedBundle::setCustomPolicyDelegate):
407         (WTR::InjectedBundle::setHidden):
408         (WTR::InjectedBundle::setCacheModel):
409         (WTR::InjectedBundle::shouldProcessWorkQueue const):
410         (WTR::InjectedBundle::processWorkQueue):
411         (WTR::InjectedBundle::queueBackNavigation):
412         (WTR::InjectedBundle::queueForwardNavigation):
413         (WTR::InjectedBundle::queueLoad):
414         (WTR::InjectedBundle::queueLoadHTMLString):
415         (WTR::InjectedBundle::queueReload):
416         (WTR::InjectedBundle::queueLoadingScript):
417         (WTR::InjectedBundle::queueNonLoadingScript):
418         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
419         (WTR::frameToStr):
420         (WTR::InjectedBundlePage::InjectedBundlePage):
421         (WTR::dumpFrameDescriptionSuitableForTestResult):
422         (WTR::dumpFrameScrollPosition):
423         (WTR::dumpDescendantFrameScrollPositions):
424         (WTR::dumpFrameText):
425         (WTR::dumpDescendantFramesText):
426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
427         (WTR::TestRunner::shouldDumpPixels const):
428         (WTR::TestRunner::setDumpPixels):
429         (WTR::TestRunner::whatToDump const):
430         (WTR::TestRunner::setWhatToDump):
431         (WTR::TestRunner::setWaitUntilDone):
432         (WTR::TestRunner::shouldWaitUntilDone const):
433         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
434         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
435         (WTR::TestRunner::clearAllDatabases):
436         (WTR::TestRunner::setIDBPerOriginQuota):
437         (WTR::TestRunner::originsWithApplicationCache):
438         (WTR::TestRunner::setCanOpenWindows):
439         (WTR::TestRunner::setXSSAuditorEnabled):
440         (WTR::TestRunner::setMediaDevicesEnabled):
441         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
442         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
443         (WTR::TestRunner::setCustomUserAgent):
444         (WTR::TestRunner::setWebAPIStatisticsEnabled):
445         (WTR::TestRunner::setModernMediaControlsEnabled):
446         (WTR::TestRunner::setWebGL2Enabled):
447         (WTR::TestRunner::setWritableStreamAPIEnabled):
448         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
449         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
450         (WTR::TestRunner::setAllowsAnySSLCertificate):
451         (WTR::TestRunner::setPluginsEnabled):
452         (WTR::TestRunner::setValueForUser):
453         (WTR::TestRunner::setAudioResult):
454         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
455         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
456         (WTR::TestRunner::setAlwaysAcceptCookies):
457         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
458         (WTR::TestRunner::isDoingMediaCapture const):
459         (WTR::TestRunner::queueLoad):
460         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
461         (WTR::TestRunner::setHandlesAuthenticationChallenges):
462         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
463         (WTR::TestRunner::setShouldLogDownloadCallbacks):
464         (WTR::TestRunner::setAuthenticationUsername):
465         (WTR::TestRunner::setAuthenticationPassword):
466         (WTR::TestRunner::secureEventInputIsEnabled const):
467         (WTR::TestRunner::setBlockAllPlugins):
468         (WTR::TestRunner::setPluginSupportedMode):
469         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
470         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
471         (WTR::TestRunner::setNavigationGesturesEnabled):
472         (WTR::TestRunner::setIgnoresViewportScaleLimits):
473         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
474         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
475         (WTR::TestRunner::terminateNetworkProcess):
476         (WTR::TestRunner::terminateServiceWorkerProcess):
477         (WTR::TestRunner::runUIScript):
478         (WTR::TestRunner::setStatisticsDebugMode):
479         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
480         (WTR::TestRunner::setStatisticsLastSeen):
481         (WTR::TestRunner::setStatisticsPrevalentResource):
482         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
483         (WTR::TestRunner::dumpResourceLoadStatistics):
484         (WTR::TestRunner::isStatisticsPrevalentResource):
485         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
486         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
487         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
488         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
489         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
490         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
491         (WTR::TestRunner::setStatisticsGrandfathered):
492         (WTR::TestRunner::isStatisticsGrandfathered):
493         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
494         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
495         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
496         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
497         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
498         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
499         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
500         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
501         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
502         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
503         (WTR::TestRunner::statisticsUpdateCookieBlocking):
504         (WTR::TestRunner::statisticsSubmitTelemetry):
505         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
506         (WTR::TestRunner::setStatisticsIsRunningTest):
507         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
508         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
509         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
510         (WTR::TestRunner::setStatisticsGrandfatheringTime):
511         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
512         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
513         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
514         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
515         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
516         (WTR::TestRunner::statisticsDeleteCookiesForHost):
517         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
518         (WTR::TestRunner::statisticsResetToConsistentState):
519         (WTR::TestRunner::setStorageAccessAPIEnabled):
520         (WTR::TestRunner::getAllStorageAccessEntries):
521         (WTR::TestRunner::addMockMediaDevice):
522         (WTR::TestRunner::clearMockMediaDevices):
523         (WTR::TestRunner::removeMockMediaDevice):
524         (WTR::TestRunner::resetMockMediaDevices):
525         (WTR::TestRunner::connectMockGamepad):
526         (WTR::TestRunner::disconnectMockGamepad):
527         (WTR::TestRunner::setMockGamepadDetails):
528         (WTR::TestRunner::setMockGamepadAxisValue):
529         (WTR::TestRunner::setMockGamepadButtonValue):
530         (WTR::TestRunner::removeAllSessionCredentials):
531         (WTR::TestRunner::clearDOMCache):
532         (WTR::TestRunner::clearDOMCaches):
533         (WTR::TestRunner::hasDOMCache):
534         (WTR::TestRunner::domCacheSize):
535         (WTR::TestRunner::setAllowStorageQuotaIncrease):
536         (WTR::TestRunner::getApplicationManifestThen):
537         (WTR::TestRunner::injectUserScript):
538         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
539         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
540         (WTR::TestRunner::addTestKeyToKeychain):
541         (WTR::TestRunner::cleanUpKeychain):
542         (WTR::TestRunner::keyExistsInKeychain):
543         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
544         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
545         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
546         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
547         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
548         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
549         * WebKitTestRunner/TestController.cpp:
550         (WTR::TestController::initialize):
551         (WTR::parseStringTestHeaderValueAsRelativePath):
552         (WTR::updateTestOptionsFromTestHeader):
553         (WTR::TestController::runTest):
554         (WTR::TestController::didReceiveLiveDocumentsList):
555         (WTR::TestController::didReceiveMessageFromInjectedBundle):
556         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
557         (WTR::TestController::didFinishNavigation):
558         (WTR::TestController::didReceiveAuthenticationChallenge):
559         * WebKitTestRunner/TestInvocation.cpp:
560         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
561         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
562         (WTR::TestInvocation::uiScriptDidComplete):
563         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
564         * WebKitTestRunner/WebNotificationProvider.cpp:
565         (WTR::WebNotificationProvider::closeWebNotification):
566         * WebKitTestRunner/WorkQueueManager.cpp:
567         (WTR::ScriptItem::ScriptItem):
568         (WTR::WorkQueueManager::queueLoad):
569         (WTR::WorkQueueManager::queueLoadHTMLString):
570
571 2019-04-17  Alex Christensen  <achristensen@webkit.org>
572
573         Add a comment to make my test from r244139 less mysterious.
574         https://bugs.webkit.org/show_bug.cgi?id=196744
575
576         As suggested by Darin Adler.
577
578         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
579         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
580
581 2019-04-17  Chris Dumez  <cdumez@apple.com>
582
583         Remember device orientation permission for the duration of the browsing session
584         https://bugs.webkit.org/show_bug.cgi?id=196992
585         <rdar://problem/49946067>
586
587         Reviewed by Alex Christensen.
588
589         Add API test coverage.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
592         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
593         (TEST):
594
595 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
596
597         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
598         https://bugs.webkit.org/show_bug.cgi?id=196675
599
600         Reviewed by Lucas Forschler.
601
602         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
603         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
604
605 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
606
607         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
608         https://bugs.webkit.org/show_bug.cgi?id=196919
609         <rdar://problem/41630459>
610
611         Reviewed by Tim Horton.
612
613         Add iOS support for several new testing hooks. See below for more detail.
614
615         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
616         (WTR::UIScriptController::isDismissingMenu const):
617
618         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
619         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
620         by UIKit when dismissing the callout bar (i.e. UIMenuController).
621
622         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
623         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
624         (WTR::UIScriptController::isDismissingMenu const):
625         * TestRunnerShared/UIScriptContext/UIScriptController.h:
626         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
627         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
628         (WTR::InjectedBundle::didReceiveMessageToPage):
629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
630         (WTR::TestRunner::setAllowedMenuActions):
631
632         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
633         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
634         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
635         against the name of the custom action.
636
637         (WTR::TestRunner::installCustomMenuAction):
638
639         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
640         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
641         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
642         triggered.
643
644         (WTR::TestRunner::performCustomMenuAction):
645
646         Invoked when the custom menu action is triggered.
647
648         * WebKitTestRunner/InjectedBundle/TestRunner.h:
649         * WebKitTestRunner/TestController.cpp:
650         (WTR::TestController::installCustomMenuAction):
651         (WTR::TestController::setAllowedMenuActions):
652         * WebKitTestRunner/TestController.h:
653         * WebKitTestRunner/TestInvocation.cpp:
654         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
655         (WTR::TestInvocation::performCustomMenuAction):
656
657         Add plumbing to call back into the injected bundle when performing the custom action.
658
659         * WebKitTestRunner/TestInvocation.h:
660         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
661         (WTR::TestController::installCustomMenuAction):
662         (WTR::TestController::setAllowedMenuActions):
663         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
664         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
665         (-[TestRunnerWKWebView initWithFrame:configuration:]):
666         (-[TestRunnerWKWebView becomeFirstResponder]):
667         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
668
669         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
670         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
671         in the Mail app on iOS.
672
673         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
674         (-[TestRunnerWKWebView setAllowedMenuActions:]):
675         (-[TestRunnerWKWebView resetCustomMenuAction]):
676         (-[TestRunnerWKWebView performCustomAction:]):
677         (-[TestRunnerWKWebView canPerformAction:withSender:]):
678         (-[TestRunnerWKWebView _willHideMenu]):
679         (-[TestRunnerWKWebView _didHideMenu]):
680         * WebKitTestRunner/ios/TestControllerIOS.mm:
681         (WTR::TestController::platformResetStateToConsistentValues):
682
683         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
684         if specified.
685
686         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
687         (WTR::UIScriptController::isDismissingMenu const):
688
689 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
690
691         Allow sharing from imageSheet on an image document
692         https://bugs.webkit.org/show_bug.cgi?id=196891
693         <rdar://problem/25377386>
694
695         Reviewed by Tim Horton.
696
697         Test to make sure that the correct imageURL is extracted from an image element.
698
699         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
700         (TestWebKitAPI::TEST):
701
702 2019-04-16  Alex Christensen  <achristensen@webkit.org>
703
704         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
705         https://bugs.webkit.org/show_bug.cgi?id=196995
706
707         Reviewed by Brady Eidson.
708
709         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
710         (TEST):
711
712 2019-04-16  Chris Dumez  <cdumez@apple.com>
713
714         URL set by document.open() is not communicated to the UIProcess
715         https://bugs.webkit.org/show_bug.cgi?id=196941
716         <rdar://problem/49237544>
717
718         Reviewed by Geoff Garen.
719
720         Add API test coverage.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
724         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
725         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
726         (TEST):
727
728 2019-04-16  Commit Queue  <commit-queue@webkit.org>
729
730         Unreviewed, rolling out r244321.
731         https://bugs.webkit.org/show_bug.cgi?id=196968
732
733         Causing all WK2 Debug builds to exit early after Assertion
734         failures. (Requested by ShawnRoberts on #webkit).
735
736         Reverted changeset:
737
738         "URL set by document.open() is not communicated to the
739         UIProcess"
740         https://bugs.webkit.org/show_bug.cgi?id=196941
741         https://trac.webkit.org/changeset/244321
742
743 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
744
745         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
746         https://bugs.webkit.org/show_bug.cgi?id=196948
747
748         Reviewed by Zalan Bujtas.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
751         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
752
753 2019-04-15  Chris Dumez  <cdumez@apple.com>
754
755         URL set by document.open() is not communicated to the UIProcess
756         https://bugs.webkit.org/show_bug.cgi?id=196941
757         <rdar://problem/49237544>
758
759         Reviewed by Geoffrey Garen.
760
761         Add API test coverage.
762
763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
764         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
765         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
766         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
767         (TEST):
768
769 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
770
771         Using Tools/Scripts/clean-webkit should not install requests
772         https://bugs.webkit.org/show_bug.cgi?id=196940
773
774         Reviewed by Lucas Forschler.
775
776         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
777         existing, depending on the path autoinstalled is run through.
778         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
779         needed.
780         (Port.configuration_for_upload):
781         (Port.commits_for_upload):
782
783 2019-04-15  Alex Christensen  <achristensen@webkit.org>
784
785         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
786         https://bugs.webkit.org/show_bug.cgi?id=196773
787
788         Reviewed by Jer Noble.
789
790         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
791         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
792         (TEST):
793
794 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
795
796         ews-build should clearly indicate flaky test failures
797         https://bugs.webkit.org/show_bug.cgi?id=196947
798
799         Reviewed by Lucas Forschler.
800
801         * BuildSlaveSupport/ews-build/steps.py:
802         (AnalyzeAPITestsResults.analyzeResults):
803
804 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
805
806         InjectedBundle parameters often need initialization function called before unarchiving
807         https://bugs.webkit.org/show_bug.cgi?id=189709
808         <rdar://problem/44573653>
809
810         Reviewed by Ryosuke Niwa.
811
812         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
813         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
814
815 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
816
817         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
818         https://bugs.webkit.org/show_bug.cgi?id=196681
819
820         Reviewed by Darin Adler.
821
822         Added tests.
823
824         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
825         (WTF_HashSet.RemoveIf):
826         (WTF_HashSet.RemoveIfShrinkToBestSize):
827
828 2019-04-15  John Wilander  <wilander@apple.com>
829
830         Send delayed Ad Click Attribution conversion requests to the click source
831         https://bugs.webkit.org/show_bug.cgi?id=196838
832         <rdar://problem/47650157>
833
834         Reviewed by Chris Dumez and Youenn Fablet.
835
836         This patch adds test infrastructure to override the default behavior in
837         WebKit::NetworkAdClickAttribution.
838
839         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
840         (TestWebKitAPI::TEST):
841         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
842         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
843         (WTR::TestRunner::dumpAdClickAttribution):
844         (WTR::TestRunner::clearAdClickAttribution):
845         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
846         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
847         * WebKitTestRunner/InjectedBundle/TestRunner.h:
848         * WebKitTestRunner/TestController.cpp:
849         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
850         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
851         * WebKitTestRunner/TestController.h:
852         * WebKitTestRunner/TestInvocation.cpp:
853         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
854
855 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
856
857         [ews-app] status-bubble should display position in queue
858         https://bugs.webkit.org/show_bug.cgi?id=196607
859
860         Reviewed by Lucas Forschler.
861
862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
863         (StatusBubble._build_bubble):
864         (StatusBubble._queue_position): Method to calculate patch's position in queue.
865
866 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
867
868         [ews-build] Do not run clean build by default on EWS builders
869         https://bugs.webkit.org/show_bug.cgi?id=196897
870
871         Reviewed by Lucas Forschler.
872
873         * BuildSlaveSupport/ews-build/steps.py:
874         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
875         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
876         untracked directories like WebKitBuild).
877         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
878         untracked files/directories (like WebKitBuild).
879
880 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
881
882         TestRunner::notifyDone() should be safely reentrant
883         https://bugs.webkit.org/show_bug.cgi?id=196898
884
885         Reviewed by Darin Adler.
886
887         It is currently possible that TestRunner::notifyDone() will call itself, since
888         notifyDone() will force a repaint, which can start executing JavaScript, which
889         may call notifyDone() again. This can lead to test failures and flakiness.
890         Fix this by setting the m_waitToDump flag before calling the dump() method.
891
892         * DumpRenderTree/mac/TestRunnerMac.mm:
893         (TestRunner::notifyDone):
894         (TestRunner::forceImmediateCompletion):
895         * DumpRenderTree/win/TestRunnerWin.cpp:
896         (TestRunner::notifyDone):
897         (TestRunner::forceImmediateCompletion):
898
899 2019-04-15  Philippe Normand  <pnormand@igalia.com>
900
901         [GTK][WPE] Add enable-media websetting
902         https://bugs.webkit.org/show_bug.cgi?id=196863
903
904         Reviewed by Michael Catanzaro.
905
906         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
907         (testWebKitSettings): Add test for the enable-media web-setting.
908
909 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
912         https://bugs.webkit.org/show_bug.cgi?id=196905
913         <rdar://problem/49886096>
914
915         Reviewed by Tim Horton.
916
917         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
918         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
919         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
920         delay timer, we end up with this sequence of events in the problematic (failure) case:
921
922         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
923             ...IPC from UI to web process...
924         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
925             ...IPC from web to UI process...
926         (c) [UI]    Invoke completion handler for script #1
927         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
928             ...IPC from UI to web process...
929         (e) [Web]   Evaluate script #2 in the web process
930         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
931
932         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
933         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
934         #2 is run in step (e).
935
936         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
937         the UI process by waiting on a script message posted by the web process, after attachment updates are
938         dispatched.
939
940         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
941         (TestWebKitAPI::TEST):
942
943 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
944
945         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
946         https://bugs.webkit.org/show_bug.cgi?id=196909
947
948         Reviewed by Wenson Hsieh.
949
950         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
951         (TestWebKitAPI::TEST):
952
953 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
954
955         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
956         https://bugs.webkit.org/show_bug.cgi?id=196880
957
958         Reviewed by Yusuke Suzuki.
959
960         Add a new function for bytecode cache tests that does not forceDiskCache
961         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
962         test added in this patch, since the code is invalid and therefore won't be
963         cached. It should also be useful for tests that evaluate dynamically
964         generated code.
965
966         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
967         * Scripts/run-jsc-stress-tests:
968
969 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
970
971         Update AudioSession route sharing policy
972         https://bugs.webkit.org/show_bug.cgi?id=196776
973         <rdar://problem/46501611>
974
975         Reviewed by Jer Noble.
976
977         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
978         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
979         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
980         (TestWebKitAPI::TEST):
981
982 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
983
984         [iOS] Software keyboard is shown too frequently on some websites
985         https://bugs.webkit.org/show_bug.cgi?id=195856
986         <rdar://problem/49191395>
987
988         Reviewed by Darin Adler.
989
990         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
991
992         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
993         (WTR::UIScriptController::setHardwareKeyboardAttached):
994         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
995         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
996         (WTR::UIScriptController::setHardwareKeyboardAttached):
997         * TestRunnerShared/UIScriptContext/UIScriptController.h:
998         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
999
1000         Additionally link against GraphicsServices in WebKitTestRunner.
1001
1002         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1003         (WTR::TestController::platformResetStateToConsistentValues):
1004         (WTR::UIScriptController::setHardwareKeyboardAttached):
1005
1006 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1007
1008         [GTK][WPE] Fix pacman install-dependencies packages
1009         https://bugs.webkit.org/show_bug.cgi?id=196817
1010
1011         Reviewed by Žan Doberšek.
1012         
1013         python3-setuptools is called python-setuptools
1014         ruby-highline is only available on AUR
1015         libv4l-devel is incorporated in v4l-utils
1016
1017         * gtk/install-dependencies:
1018         * wpe/install-dependencies:
1019
1020 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1021
1022         [GTK] REGRESSION(r243860): Many tests failing
1023         https://bugs.webkit.org/show_bug.cgi?id=196791
1024
1025         Reviewed by Joanmarie Diggs.
1026
1027         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1028         multiple documents and check that accessibility hierarchy is updated after a navigation.
1029
1030         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1031         (loadChangedCallback):
1032         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1033         (AccessibilityTest::AccessibilityTest):
1034         (AccessibilityTest::~AccessibilityTest):
1035         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1036         (AccessibilityTest::findTestServerApplication):
1037         (AccessibilityTest::findDocumentWeb):
1038         (AccessibilityTest::findRootObject):
1039         (AccessibilityTest::waitUntilChildrenRemoved):
1040         (AccessibilityTest::ensureProxy):
1041         (testAtspiBasicHierarchy):
1042         (beforeAll):
1043         (afterAll):
1044
1045 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1046
1047         [ews-build] Handle bug titles with unicode characters
1048         https://bugs.webkit.org/show_bug.cgi?id=196802
1049
1050         Reviewed by Dewei Zhu.
1051
1052         * BuildSlaveSupport/ews-build/steps.py:
1053         (ValidatePatch._is_bug_closed):
1054
1055 2019-04-11  Michael Saboff  <msaboff@apple.com>
1056
1057         Improve the Inline Cache Stats code
1058         https://bugs.webkit.org/show_bug.cgi?id=196836
1059
1060         Reviewed by Saam Barati.
1061
1062         Added a new script to consolidate and arrange the output of --useICStats option.
1063
1064         This script merges the output from every group into one large table and sorts it from most common to
1065         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1066         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1067         Put together, this is useful to see what property accesses are not getting cached.
1068
1069         * Scripts/ic-stats.py: Added.
1070         (ICStats):
1071         (ICStats.__init__):
1072         (ICStats.parse):
1073         (ICStats.dumpStats):
1074         (usage):
1075
1076 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1077
1078         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1079         https://bugs.webkit.org/show_bug.cgi?id=196809
1080         <rdar://49800762>
1081
1082         Reviewed by Brady Eidson.
1083
1084         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1085         (TEST):
1086
1087 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1088
1089         requestAnimationFrame should execute before the next frame
1090         https://bugs.webkit.org/show_bug.cgi?id=177484
1091
1092         Reviewed by Simon Fraser.
1093
1094         Add trace points for the page RenderingUpdate.
1095
1096         * Tracing/SystemTracePoints.plist:
1097
1098 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1099
1100         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1101         https://bugs.webkit.org/show_bug.cgi?id=196760
1102
1103         Reviewed by Don Olmstead.
1104
1105         vswhere.exe has been bundled since Visual Studio 2017 version
1106         15.2. We shouldn't download vswhere.exe.
1107
1108         * Scripts/build-jsc: Do not call update-vswhere.py.
1109         * Scripts/build-webkit: Ditto.
1110         * Scripts/update-vswhere.py: Removed.
1111         * Scripts/webkitdirs.pm:
1112         (requireModulesForVSWhere): Deleted.
1113         (pickCurrentVisualStudioInstallation): Deleted.
1114         (visualStudioInstallDirVSWhere): Return the latest installed VS
1115         installation path by using the bundled vswhere.exe.
1116         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1117         (visualStudioInstallDirFallback): Removed.
1118
1119 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1120
1121         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1122         https://bugs.webkit.org/show_bug.cgi?id=196780
1123
1124         Reviewed by Alexey Proskuryakov.
1125
1126         * BuildSlaveSupport/ews-build/steps.py:
1127         * BuildSlaveSupport/ews-build/steps_unittest.py:
1128
1129 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1130
1131         Add SPI WKNavigationResponse._downloadAttribute
1132         https://bugs.webkit.org/show_bug.cgi?id=196755
1133         <rdar://49587365>
1134
1135         Reviewed by Brady Eidson.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1138         (-[NavigationResponseTestDelegate navigationResponse]):
1139         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1140         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1141         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1142         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1143         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1144         (readRequest):
1145         (writeResponse):
1146         (TEST):
1147
1148 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1149
1150         Add modern API for overriding the page's specified viewport configuration
1151         https://bugs.webkit.org/show_bug.cgi?id=167734
1152         <rdar://problem/30331795>
1153
1154         Reviewed by Simon Fraser.
1155
1156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1157         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1158
1159 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1160
1161         Add support for incremental bytecode cache updates
1162         https://bugs.webkit.org/show_bug.cgi?id=195000
1163
1164         Reviewed by Filip Pizlo.
1165
1166         Exit when the initial run to generate bytecode fails.
1167
1168         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1169
1170 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1171
1172         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1173         https://bugs.webkit.org/show_bug.cgi?id=196744
1174         <rdar://49415309>
1175
1176         Reviewed by Chris Dumez.
1177
1178         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1179         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1180
1181 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1182
1183         Add a way to opt into modern compatibility mode in layout tests
1184         https://bugs.webkit.org/show_bug.cgi?id=196770
1185         <rdar://problem/49777550>
1186
1187         Reviewed by Antoine Quint.
1188
1189         Add a new test option to enable modern compatibility mode in layout tests.
1190
1191         * WebKitTestRunner/TestController.cpp:
1192         (WTR::updateTestOptionsFromTestHeader):
1193         * WebKitTestRunner/TestController.h:
1194         * WebKitTestRunner/TestOptions.h:
1195         (WTR::TestOptions::hasSameInitializationOptions const):
1196         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1197         (WTR::TestController::platformCreateWebView):
1198         (WTR::TestController::enableModernCompatibilityMode):
1199
1200 2019-04-10  Andy Estes  <aestes@apple.com>
1201
1202         Try to fix the 32-bit watchOS build.
1203
1204         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1205         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1206
1207 2019-04-10  Antoine Quint  <graouts@apple.com>
1208
1209         Enable Pointer Events on watchOS
1210         https://bugs.webkit.org/show_bug.cgi?id=196771
1211         <rdar://problem/49040909>
1212
1213         Reviewed by Dean Jackson.
1214
1215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1216
1217 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1218
1219         Unreviewed. Fix WPE accessibility tests after r244059.
1220
1221         We are failing to load the injected bundle due to undefined symbol
1222         AccessibilityUIElement::replaceTextInRange().
1223
1224         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1225         (WTR::AccessibilityUIElement::replaceTextInRange):
1226
1227 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1228
1229         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1230         https://bugs.webkit.org/show_bug.cgi?id=196727
1231
1232         Reviewed by Fujii Hironori.
1233
1234         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1235         (WebKitBrowserWindow::create):
1236
1237 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-build] Add unit tests for PrintConfiguration
1240         https://bugs.webkit.org/show_bug.cgi?id=196752
1241
1242         Reviewed by Dewei Zhu.
1243
1244         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1245
1246 2019-04-09  Keith Rollin  <krollin@apple.com>
1247
1248         Unreviewed build maintenance -- update .xcfilelists.
1249
1250         * DumpRenderTree/DerivedSources-input.xcfilelist:
1251         * DumpRenderTree/DerivedSources-output.xcfilelist:
1252
1253 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1254
1255         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1256         https://bugs.webkit.org/show_bug.cgi?id=196743
1257         <rdar://problem/43897551>
1258
1259         Reviewed by Tim Horton.
1260
1261         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1262         (TEST):
1263
1264 2019-04-09  Youenn Fablet  <youenn@apple.com>
1265
1266         Close service worker database on network process suspension
1267         https://bugs.webkit.org/show_bug.cgi?id=196623
1268         <rdar://problem/48930869>
1269
1270         Reviewed by Alex Christensen.
1271
1272         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1273
1274 2019-04-09  Daniel Bates  <dabates@apple.com>
1275
1276         [iPad] Should open popover when the spacebar is pressed
1277         https://bugs.webkit.org/show_bug.cgi?id=196360
1278         <rdar://problem/49389129>
1279
1280         Reviewed by Brent Fulgham.
1281
1282         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1283
1284         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1285         (WTR::UIScriptController::isShowingPopover const): Added.
1286         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1287         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1288         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1289         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1290         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1291         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1292         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1293         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1294         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1295         (WTR::UIScriptController::isShowingPopover const): Added.
1296         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1297         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1298         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1299         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1300         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1301         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1302         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1303         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1304         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1305         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1306         (WTR::UIScriptController::isShowingPopover const): Added.
1307         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1308         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1309
1310 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1311
1312         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1313         https://bugs.webkit.org/show_bug.cgi?id=196665
1314         <rdar://45115669>
1315
1316         Reviewed by Geoff Garen.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1319         (goBack):
1320         (+[SimpleLookupContext sharedLookupContext]):
1321         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1322         (TEST):
1323         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1324         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1325
1326 2019-04-09  John Wilander  <wilander@apple.com>
1327
1328         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1329         https://bugs.webkit.org/show_bug.cgi?id=196558
1330         <rdar://problem/47650245>
1331
1332         Reviewed by Youenn Fablet.
1333
1334         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1335         (TestWebKitAPI::TEST):
1336             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1337
1338 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1339
1340         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1341         https://bugs.webkit.org/show_bug.cgi?id=196720
1342
1343         Reviewed by Konstantin Tokarev.
1344
1345         * TestWebKitAPI/PlatformMac.cmake:
1346
1347 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1348
1349         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1350         https://bugs.webkit.org/show_bug.cgi?id=196694
1351         <rdar://problem/48388734>
1352
1353         Rubber-stamped by Aakash Jain.
1354
1355         * Scripts/webkitpy/port/image_diff.py:
1356         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1357         * Scripts/webkitpy/port/server_process.py:
1358         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1359         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1360         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1361         * Scripts/webkitpy/port/server_process_mock.py:
1362         (MockServerProcess.has_available_stdout):
1363         * Scripts/webkitpy/port/server_process_unittest.py:
1364         (TestServerProcess.serial_test_basic):
1365
1366 2019-04-09  Jer Noble  <jer.noble@apple.com>
1367
1368         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1369         https://bugs.webkit.org/show_bug.cgi?id=196097
1370
1371         Reviewed by Eric Carlson.
1372
1373         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1374
1375         * DumpRenderTree/mac/DumpRenderTree.mm:
1376         (resetWebPreferencesToConsistentValues):
1377         * WebKitTestRunner/TestController.cpp:
1378         (WTR::TestController::resetPreferencesToConsistentValues):
1379
1380 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1381
1382         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1383         https://bugs.webkit.org/show_bug.cgi?id=196690
1384
1385         Reviewed by Michael Catanzaro.
1386
1387         * QueueStatusServer/config/queues.py:
1388         * Scripts/webkitpy/common/config/ews.json:
1389         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1390         (test_ews_name):
1391
1392 2019-04-09  Chris Dumez  <cdumez@apple.com>
1393
1394         Loads using loadHTMLString() cause flashing when process-swapping
1395         https://bugs.webkit.org/show_bug.cgi?id=196714
1396         <rdar://problem/49637354>
1397
1398         Reviewed by Antti Koivisto.
1399
1400         Add API test coverage.
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1403
1404 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1405
1406         Unreviewed. Fix ATK accessibility tests after r244059.
1407
1408         We are failing to load the injected bundle due to undefined symbol
1409         AccessibilityUIElement::replaceTextInRange().
1410
1411         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1412         (WTR::AccessibilityUIElement::replaceTextInRange):
1413
1414 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1415
1416         AX: Support API: accessibilityReplaceRange:withText
1417         https://bugs.webkit.org/show_bug.cgi?id=196636
1418
1419         Unreviewed build fix for Windows port.
1420
1421         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1422         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1423
1424 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1425
1426         [CMake][WinCairo] Separate copied headers into different directories
1427         https://bugs.webkit.org/show_bug.cgi?id=196655
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         * DumpRenderTree/CMakeLists.txt:
1432         * MiniBrowser/win/CMakeLists.txt:
1433         * TestWebKitAPI/CMakeLists.txt:
1434         * TestWebKitAPI/PlatformWin.cmake:
1435
1436 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1437
1438         Log stack-trace for run-webkit-tests when interrupted
1439         https://bugs.webkit.org/show_bug.cgi?id=176393
1440         <rdar://problem/34262310>
1441
1442         Reviewed by Lucas Forschler.
1443
1444         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1445         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1446         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1447         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1448         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1450         (main): Set handlers to log stack trace on interruption.
1451
1452 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1453
1454         AX: Support API: accessibilityReplaceRange:withText
1455         https://bugs.webkit.org/show_bug.cgi?id=196636
1456
1457         Unreviewed build fix for Windows port.
1458
1459         * DumpRenderTree/AccessibilityUIElement.cpp:
1460         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1461
1462 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1463
1464         [ews-build] Scripts using Buildbot API have CORS error
1465         https://bugs.webkit.org/show_bug.cgi?id=196709
1466
1467         Reviewed by Alexey Proskuryakov.
1468
1469         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1470
1471 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1472
1473         AX: Support API: accessibilityReplaceRange:withText
1474         https://bugs.webkit.org/show_bug.cgi?id=196636
1475
1476         Reviewed by Daniel Bates.
1477
1478         * DumpRenderTree/AccessibilityUIElement.cpp:
1479         (replaceTextInRangeCallback):
1480         (AccessibilityUIElement::replaceTextInRange):
1481         (AccessibilityUIElement::getJSClass):
1482         * DumpRenderTree/AccessibilityUIElement.h:
1483         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1484         (AccessibilityUIElement::replaceTextInRange):
1485         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1486         (AccessibilityUIElement::replaceTextInRange):
1487         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1488         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1489         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1490         (WTR::AccessibilityUIElement::replaceTextInRange):
1491         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1492         (WTR::AccessibilityUIElement::replaceTextInRange):
1493
1494 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1495
1496         [iOS] Do not allow starting selection drags when selection views are not visible
1497         https://bugs.webkit.org/show_bug.cgi?id=196686
1498         <rdar://problem/49399192>
1499
1500         Reviewed by Tim Horton.
1501
1502         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1503         also add some new API tests to cover scenarios where the web view is not first responder.
1504
1505         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1506         (TestWebKitAPI::TEST):
1507         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1508
1509         Add a switch to optionally make the web view first responder when starting the simulated drag.
1510
1511         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1512         (-[DragAndDropSimulator initWithWebView:]):
1513         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1514
1515 2019-04-08  Justin Fan  <justin_fan@apple.com>
1516
1517         [Web GPU] Fix Web GPU experimental feature on iOS
1518         https://bugs.webkit.org/show_bug.cgi?id=196632
1519
1520         Reviewed by Myles C. Maxfield.
1521
1522         Properly make Web GPU available on iOS 11+.
1523
1524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1525
1526 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1527
1528         [ews-build] Do not upload archive when Compile Fails
1529         https://bugs.webkit.org/show_bug.cgi?id=196674
1530
1531         Reviewed by Alexey Proskuryakov.
1532
1533         * BuildSlaveSupport/ews-build/factories.py:
1534         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1535         * BuildSlaveSupport/ews-build/steps.py:
1536         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1537         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1538         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1539
1540 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1541
1542         Enable DFG on MIPS
1543         https://bugs.webkit.org/show_bug.cgi?id=196689
1544
1545         Reviewed by Žan Doberšek.
1546
1547         Since the bytecode change, we enabled the baseline JIT on mips in
1548         r240432, but DFG is still missing. With this change, all tests are
1549         passing on a ci20 board.
1550
1551         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1552
1553 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1554
1555         [Flatpak] Second run update-webkitwpe-flatpak fails
1556         https://bugs.webkit.org/show_bug.cgi?id=192702
1557
1558         Reviewed by Carlos Garcia Campos.
1559
1560         * flatpak/flatpakutils.py:
1561         (FlatpakObject.flatpak): Fix typo.
1562         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1563         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1564
1565 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1566
1567         [GTK][WPE] outlook.live.com displays old-fashioned UI
1568         https://bugs.webkit.org/show_bug.cgi?id=196642
1569
1570         Reviewed by Carlos Garcia Campos.
1571
1572         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1573         (TestWebKitAPI::TEST): New Mac platform quirk test.
1574
1575 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1576
1577         Unreviewed, rolling out r243956.
1578         https://bugs.webkit.org/show_bug.cgi?id=196688
1579
1580         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1581         by aakashjain on #webkit).
1582
1583         Reverted changeset:
1584
1585         "Clicking "Go Back" from a safe browsing warning from an
1586         iframe should navigate the WKWebView back to the previous
1587         page"
1588         https://bugs.webkit.org/show_bug.cgi?id=196665
1589         https://trac.webkit.org/changeset/243956
1590
1591 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1592
1593         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1594         https://bugs.webkit.org/show_bug.cgi?id=196669
1595
1596         Reviewed by Geoffrey Garen.
1597
1598         Added three new unit tests for WeakHashSet.
1599
1600         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1601         (WTF_WeakPtr.WeakHashSetConstObjects):
1602         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1603         (WTF_WeakPtr.WeakHashSetComputeSize):
1604
1605 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1606
1607         Hide next and previous form control buttons when WKWebView is editable
1608         https://bugs.webkit.org/show_bug.cgi?id=196672
1609         <rdar://problem/35625321>
1610
1611         Reviewed by Tim Horton.
1612
1613         Add a new API test.
1614
1615         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1616         (-[TestWKWebView lastTrailingBarButtonGroup]):
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/ios/UIKitSPI.h:
1619
1620 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1621
1622         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1623         https://bugs.webkit.org/show_bug.cgi?id=196077
1624         <rdar://problem/49108202>
1625
1626         Reviewed by Chris Dumez.
1627
1628         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1629         on new web view.
1630
1631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1632
1633 2019-04-05  Saam Barati  <sbarati@apple.com>
1634
1635         Make compare-results understand MotionMark
1636         https://bugs.webkit.org/show_bug.cgi?id=196666
1637
1638         Reviewed by Yusuke Suzuki.
1639
1640         * Scripts/compare-results:
1641         (PLT5Results):
1642         (detectMotionMark):
1643         (detectMotionMark1_1):
1644         (motionMarkResults):
1645         (motionMark1_1Results):
1646         (detectBenchmark):
1647         (biggerIsBetter):
1648         (main):
1649
1650 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1651
1652         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1653         https://bugs.webkit.org/show_bug.cgi?id=196665
1654         <rdar://45115669>
1655
1656         Reviewed by Geoff Garen.
1657
1658         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1659         (goBack):
1660         (+[SimpleLookupContext sharedLookupContext]):
1661         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1662         (TEST):
1663         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1664         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1665
1666 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1667
1668         [ews-build] Add configuration and architecture for windows builders
1669         https://bugs.webkit.org/show_bug.cgi?id=196660
1670
1671         Reviewed by Lucas Forschler.
1672
1673         * BuildSlaveSupport/ews-build/config.json:
1674
1675 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1676
1677         webkitpy: Don't run subsequent rounds if interrupted
1678         https://bugs.webkit.org/show_bug.cgi?id=196646
1679
1680         Reviewed by Aakash Jain.
1681
1682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1683         (Manager.run): Bail out if interrupted.
1684
1685 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1686
1687         Test sessionStorage in PSON private browsing mode
1688         https://bugs.webkit.org/show_bug.cgi?id=196561
1689
1690         Reviewed by Alex Christensen.
1691
1692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1693
1694 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1695
1696         Unreviewed, rolling out r243833.
1697         https://bugs.webkit.org/show_bug.cgi?id=196645
1698
1699         This change breaks build of WPE and GTK ports (Requested by
1700         annulen on #webkit).
1701
1702         Reverted changeset:
1703
1704         "[CMake][WTF] Mirror XCode header directories"
1705         https://bugs.webkit.org/show_bug.cgi?id=191662
1706         https://trac.webkit.org/changeset/243833
1707
1708 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1709
1710         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1711         https://bugs.webkit.org/show_bug.cgi?id=196635
1712
1713         Reviewed by Antti Koivisto.
1714         
1715         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1716         for a test to enable async frame scrolling via:
1717             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1718         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1719         
1720         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1721
1722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1723         (WTR::InjectedBundle::beginTesting):
1724         * WebKitTestRunner/TestController.cpp:
1725         (WTR::TestController::resetPreferencesToConsistentValues):
1726
1727 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1728
1729         Use a correct LC_RPATH when building with ASan
1730         https://bugs.webkit.org/show_bug.cgi?id=196576
1731
1732         Reviewed by David Kilzer.
1733
1734         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1735         so that ../Frameworks is checked. This is simpler and more reliable than updating
1736         each SPC service xcconfig.
1737
1738 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1739
1740         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1741         https://bugs.webkit.org/show_bug.cgi?id=196629
1742
1743         Reviewed by Lucas Forschler.
1744
1745         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1746
1747 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1750         https://bugs.webkit.org/show_bug.cgi?id=196618
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1755         (StatusBubble): Added QUEUE_TRIGGERS.
1756         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1757         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1758         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1759         its parent(builder).
1760
1761 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1762
1763         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1764         https://bugs.webkit.org/show_bug.cgi?id=196625
1765
1766         Reviewed by Lucas Forschler.
1767
1768         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1769         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1770
1771 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1772
1773         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1774         https://bugs.webkit.org/show_bug.cgi?id=196630
1775
1776         Reviewed by Wenson Hsieh.
1777
1778         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1779
1780 2019-04-04  Youenn Fablet  <youenn@apple.com>
1781
1782         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1783         https://bugs.webkit.org/show_bug.cgi?id=196543
1784
1785         Reviewed by Alex Christensen.
1786
1787         * WebKitTestRunner/TestController.cpp:
1788         (WTR::TestController::generatePageConfiguration):
1789
1790 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1791
1792         [ews-app] Status bubble should not display skipped buildbot steps
1793         https://bugs.webkit.org/show_bug.cgi?id=196584
1794
1795         Reviewed by Lucas Forschler.
1796
1797         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1798
1799 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1802         https://bugs.webkit.org/show_bug.cgi?id=196620
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-app/ews/config.py:
1807
1808 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1809
1810         [Win] DumpRenderTreeWatchDog.py is not checked into source
1811         https://bugs.webkit.org/show_bug.cgi?id=196567
1812         <rdar://problem/49525901>
1813
1814         Reviewed by Lucas Forschler.
1815
1816         This script is used on Win EWS bots to terminate hanging DRT processes.
1817
1818         * EWSTools/dumprendertreewatchdog.py: Added.
1819
1820 2019-04-04  Chris Dumez  <cdumez@apple.com>
1821
1822         Unreviewed, roll out r243858 which made tests time out.
1823
1824         Disable new API tests on Windows instead.
1825
1826         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1827         (TestWebKitAPI::TEST):
1828
1829 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         [ATK] Cleanup WebPageAccessibilityObjectAtk
1832         https://bugs.webkit.org/show_bug.cgi?id=196537
1833
1834         Reviewed by Michael Catanzaro.
1835
1836         Also consider files under atk directories as exceptions for GObject conventions.
1837
1838         * Scripts/webkitpy/style/checkers/cpp.py:
1839         (check_identifier_name_in_declaration):
1840
1841 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1842
1843         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1844         https://bugs.webkit.org/show_bug.cgi?id=196588
1845         <rdar://problem/49365787>
1846
1847         Unreviewed build fix for Windows port.
1848
1849         error C3861: 'kill': identifier not found
1850
1851         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1852         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1853
1854 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1855
1856         [ews-build] Cancel build and similar operations should have authentication
1857         https://bugs.webkit.org/show_bug.cgi?id=196520
1858
1859         Reviewed by Dewei Zhu.
1860
1861         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1862         environment variables.
1863
1864 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1865
1866         [ews-build] Do not trigger queues which are not in production yet
1867         https://bugs.webkit.org/show_bug.cgi?id=196581
1868
1869         Reviewed by Dewei Zhu.
1870
1871         * BuildSlaveSupport/ews-build/config.json:
1872
1873 2019-04-03  Chris Dumez  <cdumez@apple.com>
1874
1875         Unreviewed, fix typo in the name of API test added in r243848.
1876
1877         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1878         (TestWebKitAPI::TEST):
1879
1880 2019-04-03  Chris Dumez  <cdumez@apple.com>
1881
1882         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1883         https://bugs.webkit.org/show_bug.cgi?id=196588
1884         <rdar://problem/49365787>
1885
1886         Reviewed by Ryosuke Niwa.
1887
1888         Add API test coverage.
1889
1890         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1891         (TestWebKitAPI::nullJavaScriptCallback):
1892         (TestWebKitAPI::didCrashCheckFrames):
1893         (TestWebKitAPI::TEST):
1894
1895 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1896
1897         run-webkit-tests: Upload test results (new results database)
1898         https://bugs.webkit.org/show_bug.cgi?id=196577
1899         <rdar://problem/34841155>
1900
1901         Reviewed by Lucas Forschler.
1902
1903         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1904         (Manager.run): Upload results after each device shard, since the configuration will be
1905         different for each device.
1906         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1907         uploaded to a results database.
1908         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1909         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1910
1911 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1912
1913         -apple-trailing-word is needed for browser detection
1914         https://bugs.webkit.org/show_bug.cgi?id=196575
1915
1916         Unreviewed.
1917
1918         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1919
1920 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1921
1922         [CMake][WTF] Mirror XCode header directories
1923         https://bugs.webkit.org/show_bug.cgi?id=191662
1924
1925         Reviewed by Konstantin Tokarev.
1926
1927         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1928         builds.
1929
1930         * CMakeLists.txt:
1931         * DumpRenderTree/CMakeLists.txt:
1932         * DumpRenderTree/PlatformWin.cmake:
1933         * MiniBrowser/win/CMakeLists.txt:
1934         * TestWebKitAPI/CMakeLists.txt:
1935         * TestWebKitAPI/PlatformWin.cmake:
1936         * WebKitTestRunner/PlatformGTK.cmake:
1937         * WebKitTestRunner/PlatformWin.cmake:
1938
1939 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1940
1941         [ews-app] Status bubble should not display certain infrastructure status messages
1942         https://bugs.webkit.org/show_bug.cgi?id=196550
1943
1944         Reviewed by Lucas Forschler.
1945
1946         Do not display the steps which are un-needed for end-user. This information is still avaiable
1947         if the user click on the bubble and look at the Buildbot build.
1948         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1949         (StatusBubble._steps_messages):
1950         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1951
1952 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [ews-build] Use https for sending data to ews-app
1955         https://bugs.webkit.org/show_bug.cgi?id=196492
1956
1957         Reviewed by Lucas Forschler.
1958
1959         * BuildSlaveSupport/ews-build/events.py:
1960
1961 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1962
1963         Remove support for -apple-trailing-word
1964         https://bugs.webkit.org/show_bug.cgi?id=196525
1965
1966         Reviewed by Zalan Bujtas.
1967
1968         This CSS property is nonstandard and not used.
1969
1970         * Scripts/webkitperl/FeatureList.pm:
1971         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1972
1973 2019-04-03  Youenn Fablet  <youenn@apple.com>
1974
1975         Add a test for DOMCache on multiple browsing in case of private browsing
1976         https://bugs.webkit.org/show_bug.cgi?id=196524
1977
1978         Reviewed by Alex Christensen.
1979
1980         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1981         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1982
1983 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1984
1985         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1986         https://bugs.webkit.org/show_bug.cgi?id=196540
1987
1988         Reviewed by Aakash Jain.
1989
1990         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1991
1992 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1993
1994         Add plumbing for a compatibility mode preference in WebKit
1995         https://bugs.webkit.org/show_bug.cgi?id=196005
1996
1997         Reviewed by Tim Horton.
1998
1999         Add new API tests.
2000
2001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2002         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2003
2004 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2005
2006         [WPE][GTK] Update libsrtp dependency package for Debian
2007         https://bugs.webkit.org/show_bug.cgi?id=196528
2008
2009         Reviewed by Frédéric Wang.
2010
2011         * gtk/install-dependencies:
2012         * wpe/install-dependencies:
2013
2014 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2015
2016         [WK2] Add support for Window's beforeprint / afterprint events
2017         https://bugs.webkit.org/show_bug.cgi?id=196478
2018         <rdar://problem/49535124>
2019
2020         Unreviewed build fix for MSVC.
2021
2022         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2023
2024         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2025
2026         * WebKitTestRunner/TestController.cpp:
2027         (WTR::printFrame): Use int and float literals.
2028
2029 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews-build] Reassign bots to queues
2032
2033         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2034
2035 2019-04-02  Chris Dumez  <cdumez@apple.com>
2036
2037         [WK2] Add support for Window's beforeprint / afterprint events
2038         https://bugs.webkit.org/show_bug.cgi?id=196478
2039
2040         Reviewed by Alex Christensen.
2041
2042         Add minimal implementation for printFrame in WebKitTestRunner.
2043
2044         * WebKitTestRunner/TestController.cpp:
2045         (WTR::printFrame):
2046         (WTR::TestController::createOtherPage):
2047         (WTR::TestController::createWebViewWithOptions):
2048
2049 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2050
2051         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2052         https://bugs.webkit.org/show_bug.cgi?id=196491
2053
2054         Reviewed by Lucas Forschler.
2055
2056         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2057
2058 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2059
2060         [ews-build] Configure buildbot try credentials in environment variables
2061         https://bugs.webkit.org/show_bug.cgi?id=196501
2062
2063         Reviewed by Lucas Forschler.
2064
2065         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2066         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2067         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2068
2069 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2070
2071         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2072         https://bugs.webkit.org/show_bug.cgi?id=196496
2073         <rdar://problem/49521634>
2074
2075         Reviewed by Chris Dumez.
2076
2077         Add new API tests (see WebKit ChangeLog for more detail).
2078
2079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2080         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2081         (TEST):
2082
2083 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2084
2085         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2086         <https://webkit.org/b/196499>
2087
2088         Reviewed by Alexey Proskuryakov.
2089
2090         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2091         ENABLE_ADDRESS_SANITIZER.
2092
2093 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2094
2095         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2096         https://bugs.webkit.org/show_bug.cgi?id=182757
2097
2098         Reviewed by Don Olmstead.
2099
2100         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2101         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2102
2103 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2104
2105         run-api-tests: Upload test results
2106         https://bugs.webkit.org/show_bug.cgi?id=196323
2107         <rdar://problem/49356714>
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * Scripts/webkitpy/api_tests/manager.py:
2112         (Manager):
2113         (Manager.run): Upload results to a results database.
2114         * Scripts/webkitpy/api_tests/run_api_tests.py:
2115         (parse_args): Add upload arguments.
2116         * Scripts/webkitpy/port/base.py:
2117         (Port):
2118         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2119         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2120         with commits from any other associated repositories.
2121         * Scripts/webkitpy/port/device.py:
2122         (Device):
2123         (Device.build_version): Access build_versoin of underlying platform device.
2124         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2125         (IOSSimulatorTest):
2126         (IOSSimulatorTest.test_configuration_for_upload):
2127         * Scripts/webkitpy/port/device_port.py:
2128         (DevicePort):
2129         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2130         the same as the machine uploading results.
2131         * Scripts/webkitpy/port/mac.py:
2132         (MacPort):
2133         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2134         * Scripts/webkitpy/port/mac_unittest.py:
2135         (MacTest):
2136         (MacTest.test_configuration_for_upload):
2137         * Scripts/webkitpy/xcode/simulated_device.py:
2138         (SimulatedDeviceManager._create_device_with_runtime):
2139         (SimulatedDevice.__init__): Create simulated device with a build_version.
2140         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2141         (test_existing_simulator):
2142
2143 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2144
2145         Remove extra newline characters (Follow-up fix to r243707)
2146
2147         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2148
2149 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2150
2151         [ews-app] Use API_KEY to accept results data
2152         https://bugs.webkit.org/show_bug.cgi?id=196461
2153
2154         Reviewed by Dewei Zhu.
2155
2156         * BuildSlaveSupport/ews-app/ews/views/results.py:
2157         (Results.post): Validate EWS_API_KEY before accepting any data.
2158         * BuildSlaveSupport/ews-build/events.py:
2159         (Events.sendData): Send EWS_API_KEY if available along with event data.
2160
2161 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2162
2163         Unable to copy and paste a PDF from Notes into Mail compose body
2164         https://bugs.webkit.org/show_bug.cgi?id=196442
2165         <rdar://problem/48573098>
2166
2167         Reviewed by Tim Horton.
2168
2169         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2170         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2171         to be specified on the item providers.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2174         (TestWebKitAPI::mapItemForTesting):
2175         (TestWebKitAPI::contactItemForTesting):
2176
2177 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2178
2179         Make UIWKDocumentContext rects per-character instead of per-word
2180         https://bugs.webkit.org/show_bug.cgi?id=196459
2181
2182         Reviewed by Wenson Hsieh.
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2185         (TEST):
2186         Adjust test results due to switching to per-character rects.
2187
2188 2019-04-01  Chris Dumez  <cdumez@apple.com>
2189
2190         UIProcess crash when a prewarmed process is terminated
2191         https://bugs.webkit.org/show_bug.cgi?id=196451
2192         <rdar://problem/49245471>
2193
2194         Reviewed by Geoffrey Garen.
2195
2196         Add API test coverage.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2199         (TEST):
2200
2201 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2202
2203         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2204         https://bugs.webkit.org/show_bug.cgi?id=196449
2205
2206         Reviewed by Lucas Forschler.
2207
2208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2209         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2210         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2211         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2212
2213 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2214
2215         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2216         https://bugs.webkit.org/show_bug.cgi?id=196444
2217
2218         Reviewed by Lucas Forschler.
2219
2220         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2221
2222 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2223
2224         Add SPI to canonicalize NSURLs with WTF::URL
2225         https://bugs.webkit.org/show_bug.cgi?id=196415
2226         <rdar://problem/44980271>
2227
2228         Reviewed by Darin Adler.
2229
2230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2231         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2232         (TestWebKitAPI::TEST):
2233
2234 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2235
2236         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2237         https://bugs.webkit.org/show_bug.cgi?id=196441
2238
2239         Reviewed by Carlos Garcia Campos.
2240
2241         Don't cache the wpe_view_backend object that might not exist yet at the
2242         time of EventSenderProxy constructor invocation, but instead retrieve
2243         that object whenever it's required for event dispatching. This should
2244         avoid crashes in this constructor now that it's invoked before any
2245         PlatformWindow has been set up (as changed in r243496).
2246
2247         * WebKitTestRunner/EventSenderProxy.h:
2248         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2249         (WTR::viewBackend):
2250         (WTR::EventSenderProxy::EventSenderProxy):
2251         (WTR::EventSenderProxy::mouseDown):
2252         (WTR::EventSenderProxy::mouseUp):
2253         (WTR::EventSenderProxy::mouseMoveTo):
2254         (WTR::EventSenderProxy::mouseScrollBy):
2255         (WTR::EventSenderProxy::keyDown):
2256         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2257
2258 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2259
2260         [Win][WebKit] MiniBrowser should support high DPI display
2261         https://bugs.webkit.org/show_bug.cgi?id=196391
2262
2263         Reviewed by Alex Christensen.
2264
2265         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2266         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2267         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2268         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2269
2270 2019-03-31  Sam Weinig  <weinig@apple.com>
2271
2272         Remove more i386 specific configurations
2273         https://bugs.webkit.org/show_bug.cgi?id=196430
2274
2275         Reviewed by Alexey Proskuryakov.
2276
2277         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2278         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2279
2280 2019-03-31  Andy Estes  <aestes@apple.com>
2281
2282         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2283         https://bugs.webkit.org/show_bug.cgi?id=196433
2284         <rdar://problem/49293305>
2285
2286         Reviewed by Tim Horton.
2287
2288         Enhanced API test coverage to include all navigation response policy decisions in both
2289         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2290
2291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2292         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2293         (TestWebKitAPI::TEST):
2294         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2295         (readFile):
2296         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2297         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2298         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2299         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2300         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2301         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2302         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2303         (-[QuickLookDelegate _downloadDidStart:]):
2304         (-[QuickLookDelegate _download:didReceiveResponse:]):
2305         (-[QuickLookDelegate _download:didReceiveData:]):
2306         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2307         (-[QuickLookDelegate _downloadDidFinish:]):
2308         (-[QuickLookDelegate _download:didFailWithError:]):
2309         (-[QuickLookDelegate _downloadDidCancel:]):
2310         (-[QuickLookDelegate verifyDownload]):
2311         (runTest):
2312         (runTestDecideBeforeLoading):
2313         (runTestDecideAfterLoading):
2314         (TEST):
2315         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2316         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2317         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2318         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2319         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2320         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2321         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2322         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2323         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2324         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2325         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2326         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2327         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2328         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2329
2330 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2331
2332         [CMake] add testdfg as target with build-jsc
2333         https://bugs.webkit.org/show_bug.cgi?id=196393
2334
2335         Reviewed by Saam Barati.
2336
2337         Added testdfg as one of the targets to build when
2338         using CMake.
2339
2340         * Scripts/build-jsc:
2341
2342 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2343
2344         Delete WebMetal implementation in favor of WebGPU
2345         https://bugs.webkit.org/show_bug.cgi?id=195418
2346
2347         Reviewed by Dean Jackson.
2348
2349         * DumpRenderTree/mac/DumpRenderTree.mm:
2350         (enableExperimentalFeatures):
2351         (resetWebPreferencesToConsistentValues):
2352         * Scripts/webkitperl/FeatureList.pm:
2353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2355         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2356         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2357         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2358         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2359         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2360         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2361         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2362         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2363         (WTR::InjectedBundle::beginTesting):
2364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2365         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2367
2368 2019-03-29  Chris Dumez  <cdumez@apple.com>
2369
2370         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2371         https://bugs.webkit.org/show_bug.cgi?id=196405
2372         <rdar://problem/49428130>
2373
2374         Reviewed by Wenson Hsieh.
2375
2376         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2377         the popover presentation methods to be no-ops. Use this in the new test added in
2378         r243523 so that we do not swizzle those methods for all tests. This is needed because
2379         those WatchOS tests rely on the popover getting presented and interactive.
2380
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::updateTestOptionsFromTestHeader):
2383         * WebKitTestRunner/TestController.h:
2384         * WebKitTestRunner/TestOptions.h:
2385         (WTR::TestOptions::hasSameInitializationOptions const):
2386         * WebKitTestRunner/ios/TestControllerIOS.mm:
2387         (WTR::TestController::platformInitialize):
2388         (WTR::TestController::platformResetStateToConsistentValues):
2389
2390 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2391
2392         [Curl] Add Server Trust Evaluation Support.
2393         https://bugs.webkit.org/show_bug.cgi?id=191646
2394
2395         Reviewed by Fujii Hironori.
2396
2397         Implemented MiniBrowser UI for asking if user trusts the server.
2398
2399         * MiniBrowser/win/Common.cpp:
2400         (askServerTrustEvaluation):
2401         (replaceString):
2402         * MiniBrowser/win/Common.h:
2403         * MiniBrowser/win/MiniBrowserLib.rc:
2404         * MiniBrowser/win/MiniBrowserLibResource.h:
2405         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2406         (createPEMString):
2407         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2408         (WebKitBrowserWindow::canTrustServerCertificate):
2409         * MiniBrowser/win/WebKitBrowserWindow.h:
2410
2411 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2412
2413         Implement ResizeObserver.
2414         https://bugs.webkit.org/show_bug.cgi?id=157743
2415
2416         Reviewed by Simon Fraser.
2417
2418         Support resizeObserverEnabled webPreferences.
2419
2420         * DumpRenderTree/TestOptions.cpp:
2421         (TestOptions::TestOptions):
2422         * DumpRenderTree/TestOptions.h:
2423         * DumpRenderTree/mac/DumpRenderTree.mm:
2424         (setWebPreferencesForTestOptions):
2425         * DumpRenderTree/win/DumpRenderTree.cpp:
2426         (enableExperimentalFeatures):
2427         * Scripts/webkitperl/FeatureList.pm:
2428         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2429
2430 2019-03-28  John Wilander  <wilander@apple.com>
2431
2432         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2433         https://bugs.webkit.org/show_bug.cgi?id=196281
2434         <rdar://problem/48938748>
2435
2436         Reviewed by Alex Christensen.
2437
2438         This patch adds the function isStatisticsHasLocalStorage() to the
2439         TestRunner. With it, the page can query the WebsiteDataStore in the
2440         UI process to make sure that it sees LocalStorage.
2441
2442         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2444         (WTR::TestRunner::isStatisticsHasLocalStorage):
2445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2446         * WebKitTestRunner/TestController.cpp:
2447         (WTR::TestController::isStatisticsHasLocalStorage):
2448         * WebKitTestRunner/TestController.h:
2449         * WebKitTestRunner/TestInvocation.cpp:
2450         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2451
2452 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2453
2454         API::Data::createWithoutCopying should do a null check before calling CFRelease
2455         https://bugs.webkit.org/show_bug.cgi?id=196276
2456         <rdar://problem/48059859>
2457
2458         Reviewed by Alex Christensen.
2459
2460         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2461
2462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2463         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2464         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2465         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2466         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2467         (TestWebKitAPI::TEST):
2468
2469 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2470
2471         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2472         https://bugs.webkit.org/show_bug.cgi?id=186276
2473
2474         Reviewed by Carlos Garcia Campos.
2475
2476         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2477         (webViewLoadChanged):
2478         (testWebResourceGetDataError):
2479         (testWebResourceGetDataEmpty):
2480         (beforeAll):
2481         (webViewloadChanged): Deleted.
2482
2483 2019-03-27  Andy Estes  <aestes@apple.com>
2484
2485         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2486         https://bugs.webkit.org/show_bug.cgi?id=196317
2487
2488         Reviewed by Dan Bernstein.
2489
2490         package-root copies built products into a staging directory using ditto(1), which does not
2491         follow symbolic links as it traverses a directory. Now that the files in
2492         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2493         itself, these become broken links when ditto'd into the staging directory.
2494
2495         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2496
2497         * Scripts/package-root:
2498
2499 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2500
2501         [ews-app] Update display text of Submit for ews analysis
2502         https://bugs.webkit.org/show_bug.cgi?id=196309
2503
2504         Reviewed by Dewei Zhu.
2505
2506         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2507
2508 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2509
2510         run-webkit-tests should check for leaks in WebKit processes
2511         <https://webkit.org/b/193772>
2512         <rdar://problem/46526680>
2513
2514         Reviewed by Ryosuke Niwa.
2515
2516         This works by doing the following:
2517         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2518           The list of child processes are returned one per line:
2519           process.name: pid
2520         - Run the "#LIST CHILD PROCESSES" command just before the
2521           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2522           processes on the ServerProcess object.
2523         - When the `--leaks` switch is handled, run check_for_leaks() on
2524           each child process after the main test harness.
2525
2526         * DumpRenderTree/mac/DumpRenderTree.mm:
2527         (handleControlCommand):
2528         - Use strncmp() instead of strcmp().
2529         - Add support for handling "#LIST CHILD PROCESSES" command.
2530
2531         * Scripts/webkitpy/port/base.py:
2532         (Port.check_for_leaks):
2533         * Scripts/webkitpy/port/darwin.py:
2534         (DarwinPort.check_for_leaks):
2535         - Rename redundant 'process_pid' argument to 'process_id'.
2536
2537         * Scripts/webkitpy/port/driver.py:
2538         (Driver.do_post_tests_work):
2539         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2540           longer the only command this sends to WebKitTestRunner.
2541         - If the `--leaks` switch is present, send the
2542           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2543           result using Port.set_webkit_processes().
2544         (Driver._parse_child_processes_output):
2545         - Add helper method to parse list of child process names and
2546           process IDs returned from WebKitTestRunner.
2547
2548         * Scripts/webkitpy/port/ios_device.py:
2549         (IOSDevicePort.check_for_leaks):
2550         - Rename redundant 'process_pid' argument to 'process_id'.
2551
2552         * Scripts/webkitpy/port/leakdetector.py:
2553         (LeakDetector._parse_leaks_output):
2554         - Return early if there is no leaks_output.
2555         (LeakDetector.check_for_leaks):
2556         - Rename redundant 'process_pid' argument to 'process_id'.
2557
2558         * Scripts/webkitpy/port/server_process.py:
2559         (ServerProcess.__init__):
2560         (ServerProcess.child_processes):
2561         (ServerProcess.set_child_processes):
2562         - Add instance variable to Port to store list of child process
2563           names and process IDs returned from WebKitTestRunner.
2564         (ServerProcess._start):
2565         - Clear self._child_processes.
2566         (ServerProcess.stop):
2567         - If self._child_processes is set, call
2568           self._port.check_for_leaks() for each child process.
2569
2570         * Scripts/webkitpy/port/server_process_unittest.py:
2571         (TrivialMockPort.check_for_leaks):
2572         - Rename redundant 'process_pid' argument to 'process_id'.
2573
2574         * Scripts/webkitpy/port/simulator_process.py:
2575         (SimulatorProcess.stop):
2576         - If self._child_processes is set, call
2577           self._port.check_for_leaks() for each child process.
2578
2579         * Scripts/webkitpy/port/watch_device.py:
2580         (WatchDevicePort.check_for_leaks):
2581         - Rename redundant 'process_pid' argument to 'process_id'.
2582
2583         * WebKitTestRunner/TestController.cpp:
2584         (WTR::TestController::dumpResponse):
2585         - Extract method from findAndDumpWorldLeaks() so that it may be
2586           reused by findAndDumpWebKitProcessIdentifiers().
2587         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2588         - Add method to output process name and process ID of both the
2589           WebContent and Networking processes.
2590         (WTR::TestController::findAndDumpWorldLeaks):
2591         - Fix missing newline in output when there were no abandoned
2592           documents.
2593         - Call dumpResponse() for extracted code.
2594         (WTR::TestController::handleControlCommand):
2595         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2596         - Use strncmp() instead of strcmp().
2597         - Call findAndDumpWebKitProcessIdentifiers() when
2598           "#LIST CHILD PROCESSES" command is sent.
2599         * WebKitTestRunner/TestController.h:
2600         (WTR::TestController::dumpResponse):
2601         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2602         - Declare methods.
2603
2604 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2605
2606         Unreviewed. Add GLib API test cases after r243434.
2607
2608         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2609         (testWebViewActiveURI):
2610         (serverCallback):
2611         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2612         (sendRequestCallback):
2613
2614 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2615
2616         Geolocation request not complete when watch request was started in a different web process
2617         https://bugs.webkit.org/show_bug.cgi?id=195996
2618
2619         Reviewed by Alex Christensen.
2620
2621         Add a test case.
2622
2623         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2624         (TestWebKitAPI::runJavaScriptAlert):
2625         (TestWebKitAPI::TEST):
2626
2627 2019-03-26  Keith Rollin  <krollin@apple.com>
2628
2629         Update the way generate-xcfilelists returns strings from functions
2630         https://bugs.webkit.org/show_bug.cgi?id=195975
2631         <rdar://problem/49040807>
2632
2633         Reviewed by Dean Jackson.
2634
2635         There are places where generate-xcfilelists executes assignments with
2636         statements like:
2637
2638             FOO=$(some_function)
2639
2640         where "some_function" return a string by echoing it. E.g.
2641
2642             some_function()
2643             {
2644                 echo "Hello, World"
2645             }
2646
2647         This is a common idiom, but it has a problem if "some_function" needs
2648         to call "exit" in an attempt to halt the entire script right then and
2649         there. Since "some_function" is called inside of $(), it's being
2650         executed in a sub-shell. Calling exit in that sub-shell simply exits
2651         that shell; it doesn't not exit the outer shell in which the main part
2652         of the script is still running. As such, the main script keeps
2653         executing when the intent was for the script to halt.
2654
2655         The solution to this is to use a different idiom for returning
2656         strings. The one we now is to pass in the name of the variable to
2657         receive the string result:
2658
2659             some_function()
2660             {
2661                 variable_name=$1
2662                 eval $variable_name ="Hello, World"
2663             }
2664
2665         The call site now looks like
2666
2667             some_function FOO
2668
2669         Because there's no invocation of a sub-shell, some_function can now
2670         call "exit" if it wants to, and the entire script will exit at that
2671         point.
2672
2673         * Scripts/generate-xcfilelists:
2674
2675 2019-03-26  Chris Dumez  <cdumez@apple.com>
2676
2677         Add basic layout test coverage for File Picker on iOS
2678         https://bugs.webkit.org/show_bug.cgi?id=196265
2679
2680         Reviewed by Wenson Hsieh.
2681
2682         Add layout test infrastructure to test the file picker on iOS.
2683
2684         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2685         (WTR::UIScriptController::dismissFilePicker):
2686         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2687         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2688         (WTR::UIScriptController::dismissFilePicker):
2689         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2690         * WebKitTestRunner/TestController.cpp:
2691         (WTR::TestController::createWebViewWithOptions):
2692         (WTR::updateTestOptionsFromTestHeader):
2693         * WebKitTestRunner/TestOptions.h:
2694         (WTR::TestOptions::hasSameInitializationOptions const):
2695         * WebKitTestRunner/ios/TestControllerIOS.mm:
2696         (overridePresentViewController):
2697         (WTR::TestController::platformInitialize):
2698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2699         (WTR::UIScriptController::dismissFilePicker):
2700
2701 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2702
2703         Implement async paste method on UIWKInteractionViewProtocol
2704         https://bugs.webkit.org/show_bug.cgi?id=196267
2705         <rdar://problem/49236346>
2706
2707         Reviewed by Tim Horton.
2708
2709         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2710         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2711         are now a part of all iOS 12 internal SDKs.
2712
2713         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2714
2715         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2716         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2717
2718         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2719         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2720         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2721         * TestWebKitAPI/ios/UIKitSPI.h:
2722
2723 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2724
2725         [ews-build] Use PostgreSQL for ews.webkit.org database
2726         https://bugs.webkit.org/show_bug.cgi?id=196270
2727
2728         Reviewed by Lucas Forschler.
2729
2730         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2731
2732 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2733
2734         [ews] Reset simctl states on reboot
2735         https://bugs.webkit.org/show_bug.cgi?id=196260
2736
2737         Rubber-stamped by Aakash Jain.
2738
2739         * EWSTools/start-queue-mac.sh:
2740
2741 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2742
2743         [ews-build] Use PostgreSQL for ews-build database
2744         https://bugs.webkit.org/show_bug.cgi?id=196229
2745
2746         Reviewed by Lucas Forschler.
2747
2748         * BuildSlaveSupport/ews-build/master.cfg:
2749
2750 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2751
2752         [ews-build] Get master_hostname dynamically in master.cfg
2753         https://bugs.webkit.org/show_bug.cgi?id=196255
2754
2755         Reviewed by Lucas Forschler.
2756
2757         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2758         send events data in test mode.
2759
2760 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2761
2762         [ews-app] Set db_constraint to False for Foreign Keys
2763         https://bugs.webkit.org/show_bug.cgi?id=196252
2764
2765         Reviewed by Lucas Forschler.
2766
2767         * BuildSlaveSupport/ews-app/ews/models/build.py:
2768         * BuildSlaveSupport/ews-app/ews/models/step.py:
2769
2770 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2771
2772         [ews-build] is_test_mode_enabled should default to True
2773         https://bugs.webkit.org/show_bug.cgi?id=196248
2774
2775         Reviewed by Lucas Forschler.
2776
2777         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2778
2779 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2780
2781         [ews-app] Add webkitperl to ENABLED_QUEUES
2782         https://bugs.webkit.org/show_bug.cgi?id=196253
2783
2784         Reviewed by Lucas Forschler.
2785
2786         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2787
2788 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2789
2790         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2791         https://bugs.webkit.org/show_bug.cgi?id=196211
2792         rdar://problem/49110552
2793
2794         Reviewed by Tim Horton.
2795
2796         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2797         Make sure that EventSenderProxy always exists when running tests. We used to create
2798         it when resetting before the first test, which is a bit too late.
2799
2800         * WebKitTestRunner/TestController.h:
2801         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2802         (WTR::TestController::platformCreateWebView):
2803         (WTR::TestController::platformCreateOtherPage):
2804         (WTR::TestController::finishCreatingPlatformWebView):
2805         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2806         (WTR::PlatformWebView::PlatformWebView):
2807         Moved some code that made NSWindow use NSEvent during web view creation. We may
2808         need to move more if some other case us found, but this is enough for now.
2809
2810 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2811
2812         Unreviewed. Fix typo in GLib geolocation API after r243285.
2813
2814         gelocation -> geolocation.
2815
2816         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2817         (testGeolocationManagerWatchPosition):
2818
2819 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2820
2821         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2822         https://bugs.webkit.org/show_bug.cgi?id=196213
2823
2824         Reviewed by Geoff Garen.
2825
2826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2827         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2828         (credentialWithIdentityAndKeychainPath):
2829         (-[ChallengeDelegate webView:didFinishNavigation:]):
2830         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2831         (TestWebKitAPI::TEST):
2832
2833 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2834
2835         Expected shouldn't assume its contained types are copyable
2836         https://bugs.webkit.org/show_bug.cgi?id=195986
2837
2838         Reviewed by JF Bastien.
2839
2840         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2841         (TestWebKitAPI::NonCopyable::operator== const):
2842         (TestWebKitAPI::NonCopyable::operator!= const):
2843         (TestWebKitAPI::TEST):
2844
2845 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2846
2847         Remove some now-unnecessary dynamic class lookup
2848         https://bugs.webkit.org/show_bug.cgi?id=196237
2849
2850         Reviewed by Simon Fraser.
2851
2852         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2853         (makeRequest):
2854         (TEST):
2855
2856 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2857
2858         Unreviewed, rolling out r243450.
2859
2860         AppleWin and WinCairo port builds get broken.
2861
2862         Reverted changeset:
2863
2864         "Add test for fix of #196095"
2865         https://bugs.webkit.org/show_bug.cgi?id=196097
2866         https://trac.webkit.org/changeset/243450
2867
2868 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2869
2870         Unreviewed, rolling out r243465.
2871         https://bugs.webkit.org/show_bug.cgi?id=196226
2872
2873         the test doesn't build (Requested by thorton on #webkit).
2874
2875         Reverted changeset:
2876
2877         "Do not terminate the NetworkProcess if a third party
2878         application sends a NSCredential with a SecIdentityRef"
2879         https://bugs.webkit.org/show_bug.cgi?id=196213
2880         https://trac.webkit.org/changeset/243465
2881
2882 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2883
2884         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2885         https://bugs.webkit.org/show_bug.cgi?id=196213
2886
2887         Reviewed by Geoff Garen.
2888
2889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2890         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2891         (credentialWithIdentityAndKeychainPath):
2892         (-[ChallengeDelegate webView:didFinishNavigation:]):
2893         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2894         (TestWebKitAPI::TEST):
2895
2896 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2897
2898         [ews-build] Gracefully handle missing patch_id in events
2899         https://bugs.webkit.org/show_bug.cgi?id=196216
2900
2901         Reviewed by Lucas Forschler.
2902
2903         * BuildSlaveSupport/ews-build/events.py:
2904
2905 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2906
2907         [ews-build] use lz4 compression for improving buildbot performance
2908         https://bugs.webkit.org/show_bug.cgi?id=196155
2909
2910         Reviewed by Lucas Forschler.
2911
2912         * BuildSlaveSupport/ews-build/master.cfg:
2913
2914 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2915
2916         Pull some API testing helper methods out of TestWKWebView
2917         https://bugs.webkit.org/show_bug.cgi?id=196212
2918
2919         Reviewed by Tim Horton.
2920
2921         Refactor some more API testing utility methods, so that they can be used in
2922         tests that do not use TestWKWebView.
2923
2924         * TestWebKitAPI/cocoa/TestWKWebView.h:
2925         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2926         (-[WKWebView loadTestPageNamed:]):
2927         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2928         (-[WKWebView synchronouslyLoadHTMLString:]):
2929         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2930         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2931         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2932         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2933         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2934
2935 2019-03-25  Jer Noble  <jer.noble@apple.com>
2936
2937         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2938         https://bugs.webkit.org/show_bug.cgi?id=196097
2939
2940         Reviewed by Eric Carlson.
2941
2942         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2943
2944         * DumpRenderTree/mac/DumpRenderTree.mm:
2945         (resetWebPreferencesToConsistentValues):
2946         * WebKitTestRunner/TestController.cpp:
2947         (WTR::TestController::resetPreferencesToConsistentValues):
2948
2949 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2950
2951         Pull IPadUserInterfaceSwizzler out into a separate header file
2952         https://bugs.webkit.org/show_bug.cgi?id=196193
2953
2954         Reviewed by Anders Carlsson.
2955
2956         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2957         be used in other API tests.
2958
2959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2960         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2961         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2962         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2963         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2964         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2965         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2966
2967 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2968
2969         Remove NavigatorContentUtils in WebCore/Modules
2970         https://bugs.webkit.org/show_bug.cgi?id=196070
2971
2972         Reviewed by Alex Christensen.
2973
2974         NavigatorContentUtils was to support the custom scheme spec [1].
2975         However, in WebKit side, no port has supported the feature in
2976         WebKit layer after EFL port was removed. So there has been the
2977         only IDL implementation of the NavigatorContentUtils in WebCore.
2978         So we don't need to keep the implementation in WebCore anymore.
2979
2980         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2981
2982         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2983
2984 2019-03-24  Andy Estes  <aestes@apple.com>
2985
2986         [watchOS] Remove unused Proximity Networking code
2987         https://bugs.webkit.org/show_bug.cgi?id=196188
2988
2989         Reviewed by Tim Horton.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2992         (TEST):
2993
2994 2019-03-23  Keith Miller  <keith_miller@apple.com>
2995
2996         Refactor clz/ctz and fix getLSBSet.
2997         https://bugs.webkit.org/show_bug.cgi?id=196162
2998
2999         Reviewed by Saam Barati.
3000
3001         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3002
3003         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3004         (TestWebKitAPI::TEST):
3005
3006 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3007
3008         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3009         https://bugs.webkit.org/show_bug.cgi?id=196143
3010
3011         Reviewed by Michael Catanzaro.
3012
3013         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3014         directories.
3015
3016         * Scripts/webkitpy/style/checkers/cpp.py:
3017         (check_identifier_name_in_declaration):
3018         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3019         (WebKitStyleTest.test_names):
3020
3021 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3022
3023         [Flatpak] Manifest expanding fails for qt WPE extension
3024         https://bugs.webkit.org/show_bug.cgi?id=196148
3025
3026         Reviewed by Alex Christensen.
3027
3028         * flatpak/flatpakutils.py:
3029         (expand_submodules_recurse): The last recurse manifest expand
3030         iteration might lead to a single module so take it into account
3031         and don't try to recurse further.
3032
3033 2019-03-22  Chris Dumez  <cdumez@apple.com>
3034
3035         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3036         https://bugs.webkit.org/show_bug.cgi?id=195348
3037         <rdar://problem/48622090>
3038
3039         Reviewed by Alex Christensen.
3040
3041         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3042         to NO when test.options().shouldIgnoreMetaViewport is false.
3043
3044         * WebKitTestRunner/ios/TestControllerIOS.mm:
3045         (WTR::TestController::platformConfigureViewForTest):
3046
3047 2019-03-22  Chris Dumez  <cdumez@apple.com>
3048
3049         Prewarmed processes should be usable with any website data store
3050         https://bugs.webkit.org/show_bug.cgi?id=196104
3051
3052         Reviewed by Alex Christensen.
3053
3054         Add API test coverage.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3057         (runInitialWarmedProcessUsedTest):
3058         (TEST):
3059
3060 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3061
3062         Back out local changes to Alex's Subversion working directory
3063
3064         They were accidentally committed.
3065
3066         * Scripts/webkitpy/common/system/abstractexecutive.py:
3067         (AbstractExecutive.wait_newest):
3068         * Scripts/webkitpy/common/system/executive.py:
3069         (Executive.running_pids):
3070         * Scripts/webkitpy/common/system/executive_mock.py:
3071         (MockExecutive.running_pids):
3072         * Scripts/webkitpy/common/system/executive_unittest.py:
3073         (ExecutiveTest.serial_test_running_pids):
3074         * Scripts/webkitpy/port/darwin.py:
3075         (DarwinPort.check_for_leaks):
3076         * Scripts/webkitpy/port/leakdetector.py:
3077         (LeakDetector.check_for_leaks):
3078         - This was the hack attached to Bug 193772.
3079
3080         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3081         (+[WebKitTestRunnerEvent mouseLocation]):
3082         - This works around a crash on an internal build.
3083
3084 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3085
3086         Fix the build after r243354
3087         https://bugs.webkit.org/show_bug.cgi?id=196138
3088         <rdar://problem/49145951>
3089
3090         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3091         (TEST):
3092         * TestWebKitAPI/ios/UIKitSPI.h:
3093
3094 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3095
3096         Adopt UIWKDocumentContext
3097         https://bugs.webkit.org/show_bug.cgi?id=196040
3098         <rdar://problem/48642440>
3099
3100         Reviewed by Ryosuke Niwa.
3101
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3104         (makeRequest):
3105         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3106         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3107         (applyStyle):
3108         (TEST):
3109         Add tests for UIWKDocumentContext.
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3112         (TEST):
3113         (recursiveFindWKContentView): Deleted.
3114         * TestWebKitAPI/cocoa/TestWKWebView.h:
3115         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3116         (recursiveFindWKContentView):
3117         (-[TestWKWebView wkContentView]):
3118         * TestWebKitAPI/ios/UIKitSPI.h:
3119         Share the WKContentView finding code between tests.
3120
3121 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3122
3123         [iOS WK2] Turn on async overflow scrolling by default
3124         https://bugs.webkit.org/show_bug.cgi?id=196011
3125         rdar://problem/48453859
3126
3127         Reviewed by Antti Koivisto.
3128         
3129         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3130         since so many basic layout tests have different results when compositing is triggered for
3131         overflow.
3132         
3133         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3134
3135         * WebKitTestRunner/TestController.cpp:
3136         (WTR::TestController::resetPreferencesToConsistentValues):
3137
3138 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [ews-build] Retry API test in case of failures
3141         https://bugs.webkit.org/show_bug.cgi?id=196004
3142
3143         Reviewed by Lucas Forschler.
3144
3145         * BuildSlaveSupport/ews-build/steps.py:
3146         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3147         (CompileWebKitToT.doStepIf): Ditto.
3148         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3149         (ReRunAPITests): Re-run API tests.
3150         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3151         (RunAPITestsWithoutPatch): Run API tests without patch.
3152         (RunAPITestsWithoutPatch.doStepIf):
3153         (RunAPITestsWithoutPatch.hideStepIf):
3154         (RunAPITestsWithoutPatch.evaluateCommand):
3155         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3156         (AnalyzeAPITestsResults.start):
3157         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3158         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3159         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3160         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3161
3162 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3163
3164         [ews-build] Update queues configurations
3165         https://bugs.webkit.org/show_bug.cgi?id=196074
3166
3167         Reviewed by Dewei Zhu.
3168
3169         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3170         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3171
3172 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3173
3174         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3175         https://bugs.webkit.org/show_bug.cgi?id=195680
3176         <rdar://problem/48903534>
3177
3178         Unreviewed infrastructure fix.
3179
3180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3181         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3182
3183 2019-03-21  Andy Estes  <aestes@apple.com>
3184
3185         [iOS] Apple Pay should be available in documents with no user agent scripts
3186         https://bugs.webkit.org/show_bug.cgi?id=196061
3187         <rdar://problem/48649391>
3188
3189         Reviewed by Brady Eidson.
3190
3191         Added API tests and related infrastructure.
3192
3193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3194         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3195         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3196         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3197         (TestWebKitAPI::TEST):
3198         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3199         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3200         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3201         * TestWebKitAPI/cocoa/TestProtocol.mm:
3202         (-[TestProtocol startLoading]):
3203         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3204         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3205         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3206         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3207
3208 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3209
3210         REGRESSSION (r243297): webkitpy tests broken
3211         https://bugs.webkit.org/show_bug.cgi?id=196108
3212
3213         Reviewed by Aakash Jain.
3214
3215         r243297 updated contributors.json, which broke a few unit tests.
3216
3217         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3218         (IRCCommandTest.test_whois):
3219         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3220
3221 2019-03-21  Chris Dumez  <cdumez@apple.com>
3222
3223         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3224         https://bugs.webkit.org/show_bug.cgi?id=196041
3225         <rdar://problem/49083230>
3226
3227         Reviewed by Alex Christensen.
3228
3229         Add API test coverage.
3230
3231         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3232         (TEST):
3233
3234 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3235
3236         Add SPI to inform applications of WKContentRuleList actions
3237         https://bugs.webkit.org/show_bug.cgi?id=195965
3238         <rdar://problem/42664365>
3239
3240         Reviewed by Geoff Garen.
3241
3242         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3243         (TestWebKitAPI::allActionsForResourceLoad):
3244         (TestWebKitAPI::testRequest):
3245         (TestWebKitAPI::TEST_F):
3246         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3247         (Notification::description):
3248         (Notification::operator== const):
3249         (toVector):
3250         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3251         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3252         (makeContentRuleList):
3253         (TEST):
3254         (makeWarnContentRuleList): Deleted.
3255
3256 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3257
3258         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3259         https://bugs.webkit.org/show_bug.cgi?id=196088
3260
3261         Reviewed by Brian Burg.
3262
3263         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3264         Support checks when only one platform is specified. Also deprecate macosx() and
3265         force the use of macos() instead.
3266
3267         * Scripts/webkitpy/style/checkers/cpp.py:
3268         (check_min_versions_of_wk_api_available):
3269         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3270         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3271
3272 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3273
3274         Update status inactive committers' status to 'contributor'.
3275
3276         * Scripts/webkitpy/common/config/contributors.json:
3277
3278 2019-03-21  Xan Lopez  <xan@igalia.com>
3279
3280         [JSC][x86] Drop support for x87 floating point
3281         https://bugs.webkit.org/show_bug.cgi?id=194853
3282
3283         Reviewed by Don Olmstead.
3284
3285         Force SSE2 on x86/32bit builds.
3286
3287         * Scripts/webkitdirs.pm:
3288         (generateBuildSystemFromCMakeProject):
3289
3290 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3291
3292         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3293         https://bugs.webkit.org/show_bug.cgi?id=196073
3294
3295         Reviewed by Michael Catanzaro.
3296
3297         Add test cases to check functions and constructors with no arguments but receiving user data.
3298
3299         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3300         (checkUserData):
3301         (testJSCFunction):
3302         (fooCreateWithUserData):
3303         (testJSCClass):
3304
3305 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3306
3307         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3308
3309         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3310
3311         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3312
3313 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3314
3315         [GTK][WPE] Add API to provide geolocation information
3316         https://bugs.webkit.org/show_bug.cgi?id=195940
3317
3318         Reviewed by Michael Catanzaro.
3319
3320         Add a new test to check the new API.
3321
3322         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3323         (testGeolocationManagerCurrentPosition):
3324         (testGeolocationManagerWatchPosition):
3325         (beforeAll):
3326         (afterAll):
3327         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3328         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3329         (beforeAll): Ditto.
3330         * TestWebKitAPI/glib/CMakeLists.txt:
3331
3332 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3333
3334         [GLib] Returning G_TYPE_OBJECT from a method does not work
3335         https://bugs.webkit.org/show_bug.cgi?id=195574
3336
3337         Reviewed by Michael Catanzaro.
3338
3339         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3340
3341         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3342         (getGFile):
3343         (getParent):
3344         (createGString):
3345         (getGString):
3346         (getGStringCopyWillRaise):
3347         (getGStringCopy):
3348         (getGStringStr):
3349         (getGStringLen):
3350         (freeGString):
3351         (testJSCClass):
3352
3353 2019-03-20  Saam Barati  <sbarati@apple.com>
3354
3355         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3356         https://bugs.webkit.org/show_bug.cgi?id=195721
3357
3358         Reviewed by Filip Pizlo.
3359
3360         * Scripts/run-javascriptcore-tests:
3361
3362 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3363
3364         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3365         https://bugs.webkit.org/show_bug.cgi?id=196049
3366
3367         Reviewed by Tim Horton.
3368
3369         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3370         overflow scrolling in general, so rename it.
3371
3372         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3373
3374 2019-03-20  Daniel Bates  <dabates@apple.com>
3375
3376         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3377         https://bugs.webkit.org/show_bug.cgi?id=196031
3378         <rdar://problem/49078172>
3379
3380         Reviewed by Tim Horton.
3381
3382         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3383         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3384         same code path used when the Done button is pressed to dismiss the <select> picker.
3385
3386         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3387         (TestWebKitAPI::TEST):
3388
3389 2019-03-20  Chris Dumez  <cdumez@apple.com>
3390
3391         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3392         https://bugs.webkit.org/show_bug.cgi?id=196029
3393         <rdar://problem/48954651>
3394
3395         Reviewed by Tim Horton.
3396
3397         Add API test coverage.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3400
3401 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3402
3403         [ews-build] Improve failure summary string for ApplyPatch step
3404         https://bugs.webkit.org/show_bug.cgi?id=195995
3405
3406         Reviewed by Alexey Proskuryakov.
3407
3408         * BuildSlaveSupport/ews-build/steps.py:
3409         (ApplyPatch.getResultSummary): Override getResultSummary.
3410
3411 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3412
3413         AX: Implement support for new meter ARIA role
3414         https://bugs.webkit.org/show_bug.cgi?id=195966
3415
3416         Reviewed by Chris Fleizach.
3417
3418         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3419         to AXLevelIndicator.
3420
3421         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3422
3423 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3424
3425         [WebAuthN] Implement FIDO AppID extension
3426         https://bugs.webkit.org/show_bug.cgi?id=143491
3427         <rdar://problem/48298273>
3428
3429         Reviewed by Brent Fulgham.
3430
3431         Add a test that covers the new flag of convertToU2fSignCommand.
3432
3433         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3434         (TestWebKitAPI::TEST):
3435         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3436         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3437         (TestWebKitAPI::TEST):
3438
3439 2019-03-19  Keith Rollin  <krollin@apple.com>
3440
3441         Add support for more platforms to generate-xcfilelists
3442         https://bugs.webkit.org/show_bug.cgi?id=195977
3443
3444         Reviewed by Alexey Proskuryakov.
3445
3446         generate-xcfilelists incorrectly complains when involved with building
3447         WebKit for iphonesimulator:
3448
3449             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3450             …
3451             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3452
3453         Address this by teaching generate-xcfilelists about more platforms.
3454
3455         * Scripts/generate-xcfilelists:
3456
3457 2019-03-19  John Wilander  <wilander@apple.com>
3458
3459         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3460         https://bugs.webkit.org/show_bug.cgi?id=195923
3461         <rdar://problem/49001272>
3462
3463         Reviewed by Alex Christensen.
3464
3465         This patch does the following to the TestRunner:
3466         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3467         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3468         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3469
3470         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3471         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3472         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3474         * WebKitTestRunner/TestController.cpp:
3475         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3476         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3477         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3478         * WebKitTestRunner/TestController.h:
3479         * WebKitTestRunner/TestInvocation.cpp:
3480         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3481
3482 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3483
3484         [CMake] Support more clang and gcc sanitizers
3485         https://bugs.webkit.org/show_bug.cgi?id=195956
3486
3487         Reviewed by Michael Catanzaro.
3488
3489         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3490
3491 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3492
3493         [ews-build] Improve summary for PrintConfiguration step
3494         https://bugs.webkit.org/show_bug.cgi?id=195945
3495
3496         Reviewed by Lucas Forschler.
3497
3498         * BuildSlaveSupport/ews-build/steps.py:
3499         (PrintConfiguration.getResultSummary): Override getResultSummary.
3500
3501 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Improve summary for CheckOutSource step
3504         https://bugs.webkit.org/show_bug.cgi?id=195963
3505
3506         Reviewed by Lucas Forschler.
3507
3508         * BuildSlaveSupport/ews-build/steps.py:
3509         (CheckOutSource.getResultSummary):
3510
3511 2019-03-19  Daniel Bates  <dabates@apple.com>
3512
3513         [iOS] Focus not preserved when switching between tabs
3514         https://bugs.webkit.org/show_bug.cgi?id=195820
3515         <rdar://problem/43614450>
3516
3517         Reviewed by Brent Fulgham.
3518
3519         Add tests to ensure that we restore focus when resigning and becoming first responder.
3520
3521         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3522         (TestWebKitAPI::TEST):
3523
3524 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3525
3526         Make WTFLogChannelState and WTFLogLevel enum classes
3527         https://bugs.webkit.org/show_bug.cgi?id=195904
3528
3529         Reviewed by Eric Carlson.
3530
3531         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3532         (TestWebKitAPI::TEST_F):
3533
3534 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3535
3536         [GStreamer][EME] Backported mssdemux protection data crash fix
3537         https://bugs.webkit.org/show_bug.cgi?id=195918
3538
3539         Reviewed by Philippe Normand.
3540
3541         * gstreamer/jhbuild.modules:
3542         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3543
3544 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3545
3546         Unreviewed, rolling out r243132.
3547
3548         Broke GTK build
3549
3550         Reverted changeset:
3551
3552         "Make WTFLogChannelState and WTFLogLevel enum classes"
3553         https://bugs.webkit.org/show_bug.cgi?id=195904
3554         https://trac.webkit.org/changeset/243132
3555
3556 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3557
3558         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3559
3560         * Scripts/webkitdirs.pm:
3561         (builtDylibPathForName): Adjust the shared library name that's changed
3562         with the API version bump in r243073.
3563
3564 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3565
3566         Make WTFLogChannelState and WTFLogLevel enum classes
3567         https://bugs.webkit.org/show_bug.cgi?id=195904
3568
3569         Reviewed by Eric Carlson.
3570
3571         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3572         (TestWebKitAPI::TEST_F):
3573
3574 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3575
3576         Disable flaky test added in r2431100
3577         https://webkit.org/b/195785
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3580         (TestWebKitAPI::TEST):
3581         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3582
3583 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3584
3585         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3586         https://bugs.webkit.org/show_bug.cgi?id=195916
3587
3588         Reviewed by Tim Horton.
3589
3590         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3591         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3592
3593 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3594
3595         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3600
3601         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3602         https://bugs.webkit.org/show_bug.cgi?id=195785
3603
3604         Reviewed by Geoffrey Garen.
3605
3606         * TestWebKitAPI/TCPServer.cpp: Added.
3607         (TestWebKitAPI::TCPServer::TCPServer):
3608         (TestWebKitAPI::TCPServer::~TCPServer):
3609         (TestWebKitAPI::TCPServer::socketBindListen):
3610         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3611         * TestWebKitAPI/TCPServer.h: Added.
3612         (TestWebKitAPI::TCPServer::port const):
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3615         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3616         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3617         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3618         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3619         (TestWebKitAPI::respondSlowly):
3620         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3621         (TestWebKitAPI::downloadAtRate):
3622         (TestWebKitAPI::TEST):
3623
3624 2019-03-18  Saam Barati  <sbarati@apple.com>
3625
3626         Add a plan file for JetStream 2
3627         https://bugs.webkit.org/show_bug.cgi?id=190734
3628
3629         Reviewed by Mark Lam.
3630
3631         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3632
3633 2019-03-18  Chris Dumez  <cdumez@apple.com>
3634
3635         Delay WebProcess launch until a load is triggered in a Web view
3636         https://bugs.webkit.org/show_bug.cgi?id=195758
3637         <rdar://problem/48126013>
3638
3639         Reviewed by Geoff Garen.
3640
3641         Add API test coverage. Also update some existing API tests to not expect
3642         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3643
3644         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3645         (TestWebKitAPI::TEST):
3646         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3647         (TestWebKitAPI::TEST):
3648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3649         (TEST):
3650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3651         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3652         (TEST):
3653         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3654         (TEST):
3655         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3656
3657 2019-03-18  Xan Lopez  <xan@igalia.com>
3658
3659         [CMake] Prevent potential warning when determining $architecture
3660         https://bugs.webkit.org/show_bug.cgi?id=195891
3661
3662         Reviewed by Michael Catanzaro.
3663
3664         It's possible for generateBuildSystemForCMakeProject to be called
3665         before determineArchitecture() is ever called. This will make the
3666         first eq check with $architecture to be bogus (and print a
3667         warning). Change that to an eq check with architecture(), which
3668         implicitly calls determineArchitecture() if needed, and change all
3669         the other similar cases in the method in the same way to prevent
3670         future bugs like this one.
3671
3672         * Scripts/webkitdirs.pm:
3673         (generateBuildSystemFromCMakeProject):
3674
3675 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3676
3677         [WPE] Tarballs generated with “make dist” cannot build documentation
3678         https://bugs.webkit.org/show_bug.cgi?id=195885
3679
3680         Reviewed by Carlos Garcia Campos.
3681
3682         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3683
3684 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3685
3686         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3687         https://bugs.webkit.org/show_bug.cgi?id=195883
3688
3689         Reviewed by Carlos Garcia Campos.
3690
3691         * gtkdoc/gtkdoc.py:
3692         (GTKDoc._run_command): When commands fail to run, include the full command line for
3693         the program invocation and the output it has generated on the standard error stream.
3694
3695 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3696
3697         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3698         https://bugs.webkit.org/show_bug.cgi?id=195786
3699
3700         Reviewed by Philippe Normand.
3701
3702         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3703         * wpe/jhbuild.modules: Ditto.
3704
3705 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3706
3707         [ews-build] Don't run clean builds on EWS builders
3708         https://bugs.webkit.org/show_bug.cgi?id=195851
3709
3710         Reviewed by Geoffrey Garen.
3711
3712         * BuildSlaveSupport/ews-build/factories.py:
3713
3714 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3715
3716         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3717         https://bugs.webkit.org/show_bug.cgi?id=195849
3718
3719         Reviewed by Chris Dumez.
3720
3721         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3722
3723         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3724         (runWebsiteDataStoreCustomPaths):
3725
3726 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3727
3728         webkitpy: Upload test results
3729         https://bugs.webkit.org/show_bug.cgi?id=195755
3730         <rdar://problem/48896182>
3731
3732         Reviewed by Aakash Jain.
3733
3734         Establish a new format for uploading results that is not tied to layout tests, apply
3735         that format to webkitpy tests.
3736
3737         * Scripts/webkitpy/common/checkout/scm/git.py:
3738         (Git.native_branch): Return what branch the current checkout is on.
3739         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3740         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3741         * Scripts/webkitpy/common/checkout/scm/svn.py:
3742         (SVN.native_branch): Ditto.
3743         * Scripts/webkitpy/common/system/platforminfo.py:
3744         (PlatformInfo.build_version): Return a build version for Mac.
3745         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3746         (MockPlatformInfo.__init__):
3747         (MockPlatformInfo.build_version):
3748         * Scripts/webkitpy/results: Added.
3749         * Scripts/webkitpy/results/__init__.py: Added.
3750         * Scripts/webkitpy/results/options.py: Added.
3751         (upload_options): OptParse list for upload options.
3752         * Scripts/webkitpy/results/upload.py: Added.
3753         (Upload): Class which enforces the upload format expected by the results server.
3754         (Upload.Expectations):
3755         (Upload.create_configuration):
3756         (Upload.create_commit):
3757         (Upload.create_details):
3758         (Upload.create_run_stats):
3759         (Upload.create_test_result):
3760         (Upload.__init__):
3761         (Upload.Encoder): Encode Upload object as json.
3762         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3763         * Scripts/webkitpy/results/upload_unittest.py: Added.
3764         * Scripts/webkitpy/test/main.py:
3765         (Tester._parse_args): Add upload arguments.
3766         (Tester._run_tests): Allow results to be uploaded.
3767         * Scripts/webkitpy/test/runner.py:
3768         (Runner.__init__): Record which tests were run, rather than just counting them.
3769         (Runner.handle):
3770         * Scripts/webkitpy/test/runner_unittest.py:
3771         (RunnerTest.test_run):
3772         * Scripts/webkitpy/thirdparty/__init__.py:
3773         (AutoinstallImportHook.find_module): Add requests auto-install.
3774         (AutoinstallImportHook._install_requests):
3775         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3776         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3777
3778 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3779
3780         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3781         https://bugs.webkit.org/show_bug.cgi?id=195810
3782
3783         Reviewed by Tim Horton.
3784
3785         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3786         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3787         ending certain layout tests.
3788
3789         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3790         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3791         (-[TestRunnerWKWebView dealloc]):
3792         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3793
3794         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3795         helper method when destroying the web view, and when resetting state between tests.
3796
3797         * WebKitTestRunner/ios/TestControllerIOS.mm:
3798         (WTR::TestController::platformResetStateToConsistentValues):
3799
3800         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3801
3802 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3803
3804         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3805         https://bugs.webkit.org/show_bug.cgi?id=190350
3806         <rdar://problem/45089503>
3807
3808         Reviewed by Geoffrey Garen.
3809
3810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3811         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3812         (TEST):
3813         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3814         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3815         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3816         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3817         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3818         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3819         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3820         (runTest):
3821         (createDirectories):
3822         (TEST):
3823         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3824         (TEST):
3825         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3826         (TEST):
3827
3828 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3829
3830         Add support to WebPage for getting the contents as an attributed string.
3831         https://bugs.webkit.org/show_bug.cgi?id=195636
3832         rdar://problem/45055697
3833
3834         Reviewed by Tim Horton.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3837         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3838
3839 2019-03-15  Chris Dumez  <cdumez@apple.com>
3840
3841         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3842         https://bugs.webkit.org/show_bug.cgi?id=195747
3843
3844         Reviewed by Geoff Garen.
3845
3846         Add API test coverage.
3847
3848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3849
3850 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3851
3852         Unreviewed, rolling out r242952.
3853
3854         Causing API failures on iOS Simulator
3855
3856         Reverted changeset:
3857
3858         "[PSON] Make sure the WebProcessCache is leverage when
3859         relaunching a process after termination"
3860         https://bugs.webkit.org/show_bug.cgi?id=195747
3861         https://trac.webkit.org/changeset/242952
3862
3863 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3864
3865         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3866         https://bugs.webkit.org/show_bug.cgi?id=195740
3867
3868         Reviewed by Ross Kirsling.
3869
3870         window.open doesn't work for WebKitBrowserWindow because it is not
3871         implemented yet.
3872
3873         1. Implemented createNewPage callback of WKPageUIClient.
3874         2. Changed MainWindow to take a BrowserWindow factory function
3875           instead of BrowserWindowType to be flexible to create
3876           BrowserWindow with extra settings.
3877         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3878           because it is not relevant with MainWindow anymore.
3879
3880         * MiniBrowser/win/Common.cpp:
3881         (parseCommandLine):
3882         * MiniBrowser/win/Common.h:
3883         (CommandLineOptions::CommandLineOptions):
3884         * MiniBrowser/win/MainWindow.cpp:
3885         (MainWindow::MainWindow):
3886         (MainWindow::create):
3887         (MainWindow::init):
3888         (MainWindow::WndProc):
3889         * MiniBrowser/win/MainWindow.h:
3890         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3891         (PrintWebUIDelegate::createWebViewWithRequest):
3892         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3893         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3894         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3895         (WebKitBrowserWindow::updateProxySettings):
3896         (WebKitBrowserWindow::createNewPage):
3897         * MiniBrowser/win/WebKitBrowserWindow.h:
3898         * MiniBrowser/win/WinMain.cpp:
3899         (wWinMain):
3900
3901 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3902
3903         Make it possible to test scrolling tree layer manipulation more easily
3904         https://bugs.webkit.org/show_bug.cgi?id=195780
3905
3906         Reviewed by Tim Horton.
3907         
3908         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3909         cuts off communication of scrolling tree scrolls back to the web process
3910         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3911         allows tests to trigger scrolls which run the scrolling tree layer positioning
3912         logic, but never get another commit from the web process that might mask
3913         scrolling tree bugs.
3914         
3915         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3916         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3917         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3918
3919         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3920         (WTR::UIScriptController::scrollUpdatesDisabled const):
3921         (WTR::UIScriptController::setScrollUpdatesDisabled):
3922         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3923         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3924         (WTR::UIScriptController::scrollUpdatesDisabled const):
3925         (WTR::UIScriptController::setScrollUpdatesDisabled):
3926         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3927         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3928         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3929         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3930         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3931         * WebKitTestRunner/ios/TestControllerIOS.mm:
3932         (WTR::TestController::platformResetStateToConsistentValues):
3933         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3934         (WTR::UIScriptController::scrollUpdatesDisabled const):
3935         (WTR::UIScriptController::setScrollUpdatesDisabled):
3936
3937 2019-03-14  Youenn Fablet  <youenn@apple.com>
3938
3939         Move IDB storage in private browsing mode to NetworkProcess
3940         https://bugs.webkit.org/show_bug.cgi?id=195602
3941
3942         Reviewed by Brady Eidson.
3943
3944         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3945         (TEST):
3946
3947 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3948
3949         [ews-build] Make descriptionDone messages more readable
3950         https://bugs.webkit.org/show_bug.cgi?id=195760
3951
3952         Reviewed by Lucas Forschler.
3953
3954         * BuildSlaveSupport/ews-build/steps.py:
3955         * BuildSlaveSupport/ews-build/steps_unittest.py:
3956
3957 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3958
3959         [ews-build] Generate status-bubble hover-over messages
3960         https://bugs.webkit.org/show_bug.cgi?id=195680
3961
3962         Reviewed by Lucas Forschler.
3963
3964         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3965         (StatusBubble):
3966         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3967         on hover-over.
3968         (StatusBubble._iso_time):
3969         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3970         hover-over message.
3971         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3972
3973 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3974
3975         [ews-app] Gracefully handle the case when state_string is None
3976         https://bugs.webkit.org/show_bug.cgi?id=195753
3977
3978         Reviewed by Lucas Forschler.
3979
3980         * BuildSlaveSupport/ews-app/ews/models/build.py:
3981         * BuildSlaveSupport/ews-app/ews/models/step.py:
3982
3983 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3984
3985         [ews-app] Status bubble display pending for currently running build step
3986         https://bugs.webkit.org/show_bug.cgi?id=195744
3987
3988         Reviewed by Lucas Forschler.
3989
3990         * BuildSlaveSupport/ews-build/events.py:
3991         (Events.stepStarted): If state_string is pending, replace it with step name.
3992
3993 2019-03-14  Chris Dumez  <cdumez@apple.com>
3994
3995         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3996         https://bugs.webkit.org/show_bug.cgi?id=195750
3997
3998         Reviewed by Geoffrey Garen.
3999
4000         Add API test coverage.
4001
4002         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4003         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4004         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4005         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4006
4007 2019-03-14  Chris Dumez  <cdumez@apple.com>
4008
4009         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4010         https://bugs.webkit.org/show_bug.cgi?id=195747
4011
4012         Reviewed by Geoff Garen.
4013
4014         Add API test coverage.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4017
4018 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4019
4020         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4021         https://bugs.webkit.org/show_bug.cgi?id=195725
4022         <rdar://problem/48545062>
4023
4024         Reviewed by Tim Horton.
4025
4026         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4027         handler is nil.
4028
4029         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4030         (TestWebKitAPI::TEST):
4031
4032 2019-03-13  Sam Weinig  <sam@webkit.org>
4033
4034         Add utility function to allow easy reverse range-based iteration of a container
4035         https://bugs.webkit.org/show_bug.cgi?id=195542
4036
4037         Reviewed by Antti Koivisto.
4038
4039         * TestWebKitAPI/CMakeLists.txt:
4040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4041         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4042         (TestWebKitAPI::TEST):
4043         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4044
4045 2019-03-13  Chris Dumez  <cdumez@apple.com>
4046
4047         Use a ServiceWorker process per registrable domain
4048         https://bugs.webkit.org/show_bug.cgi?id=195649
4049
4050         Reviewed by Youenn Fablet.
4051
4052         Update API test coverage.
4053
4054         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4055
4056 2019-03-13  Chris Dumez  <cdumez@apple.com>
4057
4058         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4059         https://bugs.webkit.org/show_bug.cgi?id=195684
4060         <rdar://problem/48294714>
4061
4062         Reviewed by Antti Koivisto.
4063
4064         Add API test coverage.
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4067
4068 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4069
4070         [ews-app] Remove unused patch view
4071         https://bugs.webkit.org/show_bug.cgi?id=195669
4072
4073         Reviewed by Lucas Forschler.
4074
4075         * BuildSlaveSupport/ews-app/ews/urls.py:
4076         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4077
4078 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4079
4080         [ews-app] Use Buildbot result code variables
4081         https://bugs.webkit.org/show_bug.cgi?id=195668
4082
4083         Reviewed by Alexey Proskuryakov.
4084
4085         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4086         (Buildbot): Added Buildbot result code variables.
4087         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4088         (StatusBubble._build_bubble): Used Buildbot result code variables.
4089
4090 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4091
4092         [Flatpak] Expand submodule recursively
4093         https://bugs.webkit.org/show_bug.cgi?id=195672
4094
4095         Building WPE with flatpak was impossible without that as it was raising an exception.
4096         Also update wpebackend-fdo to match what is built in jhbuild
4097
4098         Reviewed by Philippe Normand.
4099
4100         * flatpak/flatpakutils.py:
4101         (expand_submodules_recurse):
4102         (expand_manifest):
4103         * flatpak/org.webkit.WPEModules.yaml:
4104
4105 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4106
4107         [ews-app] status bubble should be hidden for certain builds
4108         https://bugs.webkit.org/show_bug.cgi?id=194597
4109
4110         Reviewed by Dewei Zhu.
4111
4112         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4113         (StatusBubble._build_bubble):
4114         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4115         because the patch didn't have relevant changes.
4116         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4117         in production yet.
4118
4119 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4120
4121         [Win] Fix a slew of simple clang-cl warnings.
4122         https://bugs.webkit.org/show_bug.cgi?id=195652
4123
4124         Reviewed by Don Olmstead.
4125
4126         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4127         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4128
4129 2019-03-12  Justin Fan  <justin_fan@apple.com>
4130
4131         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4132         https://bugs.webkit.org/show_bug.cgi?id=195518
4133         <rdar://problem/46322356>
4134
4135         Reviewed by Myles C. Maxfield.
4136
4137         * DumpRenderTree/DerivedSources-input.xcfilelist:
4138         * DumpRenderTree/DerivedSources-output.xcfilelist:
4139
4140 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4141
4142         Unreviewed, rolling out r242825.
4143         https://bugs.webkit.org/show_bug.cgi?id=195648
4144
4145         "Broke webkitpy tests with my change to
4146         lldb_dump_class_layout.py" (Requested by rmorisset on
4147         #webkit).
4148
4149         Reverted changeset:
4150
4151         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4152         classes with suspicious padding"
4153         https://bugs.webkit.org/show_bug.cgi?id=195573
4154         https://trac.webkit.org/changeset/242825
4155
4156 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4157
4158         [ews-build] Show status bubbles while the patch is waiting in queue
4159         https://bugs.webkit.org/show_bug.cgi?id=195618
4160
4161         Reviewed by Lucas Forschler.
4162
4163         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4164         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4165         enabled in initial deployment.
4166         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4167         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4168         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4169         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4170         (StatusBubble._build_bubbles_for_patch):
4171
4172 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4173
4174         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4175         https://bugs.webkit.org/show_bug.cgi?id=195573
4176
4177         Reviewed by Simon Fraser.
4178
4179         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4180
4181         * Scripts/dump-class-layout:
4182         (main):
4183         * lldb/lldb_dump_class_layout.py:
4184         (ClassLayout.__init__):
4185         (ClassLayout._compute_padding_recursive):
4186         (LLDBDebuggerInstance.dump_layout_for_classname):
4187         (LLDBDebuggerInstance):
4188         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4189         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4190
4191 2019-03-12  Chris Dumez  <cdumez@apple.com>
4192
4193         Device Orientation access permission should be denied unless explicitly granted by the client
4194         https://bugs.webkit.org/show_bug.cgi?id=195625
4195
4196         Reviewed by Youenn Fablet.
4197
4198         add API test coverage.
4199
4200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4201         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4202         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4203         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4204         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4205         (runDeviceOrientationTest):
4206         (TEST):
4207         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4208         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4209
4210 2019-03-12  Jer Noble  <jer.noble@apple.com>
4211
4212         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4213         https://bugs.webkit.org/show_bug.cgi?id=195137
4214         <rdar://problem/48810307>
4215
4216         Reviewed by Eric Carlson.
4217
4218         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4219         (TestWebKitAPI::TEST):
4220
4221 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4222
4223         [ews-build] Change urls from uat to production
4224         https://bugs.webkit.org/show_bug.cgi?id=195566
4225
4226         Reviewed by Lucas Forschler.
4227
4228         * BuildSlaveSupport/ews-app/ews/config.py:
4229         * BuildSlaveSupport/ews-build/events.py:
4230         * BuildSlaveSupport/ews-build/steps.py:
4231
4232 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4233
4234         [ews-build] change max_builds for local-worker to 1
4235         https://bugs.webkit.org/show_bug.cgi?id=195568
4236
4237         Reviewed by Lucas Forschler.
4238
4239         * BuildSlaveSupport/ews-build/loadConfig.py:
4240
4241 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4242
4243         Fix the build
4244
4245         * TestRunnerShared/spi/PencilKitTestSPI.h:
4246         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4247
4248 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4249
4250         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4251         https://bugs.webkit.org/show_bug.cgi?id=194131
4252
4253         Reviewed by Michael Catanzaro.
4254
4255         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4256         (uriChanged):
4257         (testUnfinishedSubresourceLoad):
4258         (serverCallback):
4259         (beforeAll):
4260
4261 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4262
4263         WTF::Expected should use std::addressof instead of operator&
4264         https://bugs.webkit.org/show_bug.cgi?id=195604
4265
4266         Reviewed by Myles Maxfield.
4267
4268         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4269         (TestWebKitAPI::Unique::Unique):
4270         (TestWebKitAPI::Unique::operator&):
4271         (TestWebKitAPI::TEST):
4272
4273 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4274
4275         Add Optional to Forward.h.
4276         https://bugs.webkit.org/show_bug.cgi?id=195586
4277
4278         Reviewed by Darin Adler.
4279
4280         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4281         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4282         Remove unnecessary includes from headers.
4283
4284 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4285
4286         Add testing API to hit-test and scroll overflow scrollers
4287         https://bugs.webkit.org/show_bug.cgi?id=195278
4288
4289         Reviewed by Antti Koivisto.
4290         
4291         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4292         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4293         
4294         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4295
4296         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4297         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4298         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4299         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4300         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4301         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4302         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4303         (WTR::enclosingScrollViewIncludingSelf):
4304         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4305
4306 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4307
4308         API test WebKit.RequestTextInputContext fails on iOS
4309         https://bugs.webkit.org/show_bug.cgi?id=195585
4310
4311         Reviewed by Wenson Hsieh and Simon Fraser.
4312
4313         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4314         (applyStyle):
4315         (TEST):
4316         Add a viewport, so that the coordinates match up on iOS.
4317         Scroll by moving the UIScrollView's contentOffset.
4318
4319 2019-03-11  Chris Dumez  <cdumez@apple.com>
4320
4321         Assert in WebPageProxy::suspendCurrentPageIfPos