[build.webkit.org] Unit-test failure after r237113
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2
3         [build.webkit.org] Unit-test failure after r237113
4         https://bugs.webkit.org/show_bug.cgi?id=193669
5
6         Reviewed by Michael Catanzaro.
7
8         * BuildSlaveSupport/build.webkit.org-config/factories.py:
9         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
10         multiple or zero flags.
11
12 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
13
14         Cache bytecode to disk
15         https://bugs.webkit.org/show_bug.cgi?id=192782
16         <rdar://problem/46084932>
17
18         Reviewed by Keith Miller.
19
20         Add test helper to execute bytecode-cache tests: it executes each test
21         twice, the first with JSC_diskCachePath set to a temporary directory
22         and second with JSC_forceDiskCache=true (in addition to the cache path)
23         to guarantee that only the disk cache is being used and no new
24         UnlinkedCodeBlocks are being created.
25
26         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
27         * Scripts/run-jsc-stress-tests:
28
29 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
30
31         [css-logical] Implement flow-relative margin, padding and border shorthands
32         https://bugs.webkit.org/show_bug.cgi?id=188697
33
34         Reviewed by Simon Fraser and Antti Koivisto.
35
36         * DumpRenderTree/TestOptions.cpp:
37         (TestOptions::TestOptions):
38         * DumpRenderTree/TestOptions.h:
39         * DumpRenderTree/mac/DumpRenderTree.mm:
40         (setWebPreferencesForTestOptions):
41         Allow tests to enable the CSSLogicalEnabled flag in WK1.
42
43         * Scripts/webkitpy/style/checkers/jsonchecker.py:
44         (JSONCSSPropertiesChecker.check_codegen_properties):
45         Allow CSS property definitions to have a 'runtime-flag' parameter which
46         disables the property when the specified runtime flag is disabled.
47
48 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
49
50         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
51         https://bugs.webkit.org/show_bug.cgi?id=193643
52
53         Reviewed by Michael Catanzaro.
54
55         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
56         * wpe/jhbuild.modules: Ditto.
57
58 2019-01-21  Zalan Bujtas  <zalan@apple.com>
59
60         [LFC][Floats] Take float top position into account when computing containing block height.
61         https://bugs.webkit.org/show_bug.cgi?id=193655
62
63         Reviewed by Antti Koivisto.
64
65         * LayoutReloaded/misc/LFC-passing-tests.txt:
66
67 2019-01-21  David Kilzer  <ddkilzer@apple.com>
68
69         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
70         <https://webkit.org/b/193645>
71         <rdar://problem/47421574>
72
73         Reviewed by Alex Christensen.
74
75         - Now checks for local soft-linking of all frameworks that have
76           their own *SoftLinking.{cpp,h,mm} files.
77         - Changes softlink/uikit warning to softlink/framework.
78
79         * Scripts/webkitpy/style/checkers/cpp.py:
80         (check_language):
81         (CppChecker):
82         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
83         (CppStyleTest):
84
85 2019-01-20  Saam Barati  <sbarati@apple.com>
86
87         Rollout r240210: It broke tests on iOS
88         https://bugs.webkit.org/show_bug.cgi?id=193640
89
90         Unreviewed.
91
92         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
93         * Scripts/run-jsc-stress-tests:
94
95 2019-01-20  chris fleizach  <cfleizach@apple.com>
96
97         AX: Support returning relative frames for accessibility
98         https://bugs.webkit.org/show_bug.cgi?id=193414
99         <rdar://problem/47268501>
100
101         Reviewed by Zalan Bujtas.
102
103         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
104         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
105         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
106         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
107         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
108         (WTR::attributesOfElement):
109         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
110
111 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
112
113         Unreviewed, add my new email address
114
115         * Scripts/webkitpy/common/config/contributors.json:
116
117 2019-01-19  Zalan Bujtas  <zalan@apple.com>
118
119         [LFC][BFC] <body>'s overflow property value is propagated to viewport
120         https://bugs.webkit.org/show_bug.cgi?id=193617
121
122         Reviewed by Antti Koivisto.
123
124         * LayoutReloaded/misc/LFC-passing-tests.txt:
125
126 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
127
128         Unreviewed, rolling out r240209.
129
130         Broke GTK/WPE injected bundle
131
132         Reverted changeset:
133
134         "AX: Support returning relative frames for accessibility"
135         https://bugs.webkit.org/show_bug.cgi?id=193414
136         https://trac.webkit.org/changeset/240209
137
138 2019-01-12  Dan Bernstein  <mitz@apple.com>
139
140         [Cocoa] Avoid importing directly from subumbrella frameworks
141         https://bugs.webkit.org/show_bug.cgi?id=186016
142         <rdar://problem/40591038>
143
144         Reviewed by Sam Weinig.
145
146         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
147           LaunchServices header.
148         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
149           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
150         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
151           when using SDKs earlier than 10.13.
152         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
153           and OTHER_CPLUSPLUSFLAGS.
154         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
155           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
156         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
157           LaunchServices header.
158
159 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
160
161         Cache bytecode to disk
162         https://bugs.webkit.org/show_bug.cgi?id=192782
163         <rdar://problem/46084932>
164
165         Reviewed by Keith Miller.
166
167         Add test helper to execute bytecode-cache tests: it executes each test
168         twice, the first with JSC_diskCachePath set to a temporary directory
169         and second with JSC_forceDiskCache=true (in addition to the cache path)
170         to guarantee that only the disk cache is being used and no new
171         UnlinkedCodeBlocks are being created.
172
173         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
174         * Scripts/run-jsc-stress-tests:
175
176 2019-01-20  chris fleizach  <cfleizach@apple.com>
177
178         AX: Support returning relative frames for accessibility
179         https://bugs.webkit.org/show_bug.cgi?id=193414
180         <rdar://problem/47268501>
181
182         Reviewed by Zalan Bujtas.
183
184         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
185         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
186         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
187         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
188         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
189         (WTR::attributesOfElement):
190         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
191
192 2019-01-20  Antoine Quint  <graouts@apple.com>
193
194         Add a POINTER_EVENTS feature flag
195         https://bugs.webkit.org/show_bug.cgi?id=193577
196         <rdar://problem/47408511>
197
198         Unreviewed. Also enable Pointer Events for iosmac.
199
200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
201
202 2019-01-19  Zalan Bujtas  <zalan@apple.com>
203
204         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
205         https://bugs.webkit.org/show_bug.cgi?id=193613
206
207         Reviewed by Antti Koivisto.
208
209         * LayoutReloaded/misc/LFC-passing-tests.txt:
210
211 2019-01-19  Antoine Quint  <graouts@apple.com>
212
213         Add a POINTER_EVENTS feature flag
214         https://bugs.webkit.org/show_bug.cgi?id=193577
215
216         Reviewed by Dean Jackson.
217
218         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
219
220 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
221
222         Disable the run-jsc-stress-test remote host key check [second round].
223         https://bugs.webkit.org/show_bug.cgi?id=192988
224
225         Reviewed by Dewei Zhu.
226
227         * Scripts/run-jsc-stress-tests:
228
229 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
230
231         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
232         https://bugs.webkit.org/show_bug.cgi?id=193597
233
234         Reviewed by Lucas Forschler.
235
236         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
237
238 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
239
240         [build.webkit.org] api tests failures are incorrectly named as unit test failures
241         https://bugs.webkit.org/show_bug.cgi?id=193595
242
243         Reviewed by Lucas Forschler.
244
245         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
246         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
247         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
248
249 2019-01-18  Chris Dumez  <cdumez@apple.com>
250
251         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
252         https://bugs.webkit.org/show_bug.cgi?id=193588
253         <rdar://problem/47131566>
254
255         Reviewed by Alex Christensen.
256
257         Add layout test coverage.
258
259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
260
261 2019-01-18  Jer Noble  <jer.noble@apple.com>
262
263         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
264         https://bugs.webkit.org/show_bug.cgi?id=189553
265
266         Reviewed by Tim Horton.
267
268         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
269
270         * ContentExtensionTester/Configurations/Base.xcconfig:
271         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
272         * DumpRenderTree/mac/Configurations/Base.xcconfig:
273         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
274         * ImageDiff/cg/Configurations/Base.xcconfig:
275         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
276         * MiniBrowser/Configurations/Base.xcconfig:
277         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
278         * MobileMiniBrowser/Configurations/Base.xcconfig:
279         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
280         * Scripts/webkitpy/style/checker.py:
281         (_all_categories):
282         (FileType):
283         (CheckerDispatcher._file_type):
284         (CheckerDispatcher._create_checker):
285         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
286         (SDKVariantChecker):
287         (SDKVariantChecker.__init__):
288         (SDKVariantChecker.check):
289         * TestWebKitAPI/Configurations/Base.xcconfig:
290         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
291         * WebEditingTester/Configurations/Base.xcconfig:
292         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
293         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
294         * WebKitTestRunner/Configurations/Base.xcconfig:
295         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
296         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
297         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
298
299 2019-01-18  David Kilzer  <ddkilzer@apple.com>
300
301         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
302         <https://webkit.org/b/193568>
303         <rdar://problem/47381130>
304
305         Reviewed by Alex Christensen.
306
307         Make sure no one re-introduces UIKit soft-linking by adding a
308         style rule.
309
310         * Scripts/webkitpy/style/checkers/cpp.py:
311         (check_language): Add softlink/uikit check.
312         (CppChecker): Enable softlink/uikit check.
313         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
314         (CppStyleTest): Add test for softlink/uikit.
315
316 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
317
318         [GTK] install-dependencies tool looks for libunistring-dev for dnf
319         https://bugs.webkit.org/show_bug.cgi?id=193584
320
321         Change "-dev" to "-devel".
322
323         Reviewed by Michael Catanzaro.
324
325         * gtk/install-dependencies:
326
327 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
328
329         webkitpy: Add iPhone and iPad ports
330         https://bugs.webkit.org/show_bug.cgi?id=193537
331         <rdar://problem/47353390>
332
333         Reviewed by Lucas Forschler.
334
335         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
336         ports. Note that this separation is optional, the --ios-simulator command remains.
337
338         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
339         (RunTest.test_device_type_test_division): Drive-by fix.
340         (RunTest.test_device_type_specific_listing): Ditto.
341         (RunTest.test_ipad_test_division):
342         (RunTest):
343         (RunTest.test_ipad_listing):
344         * Scripts/webkitpy/port/factory.py:
345         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
346         (PortFactory):
347         * Scripts/webkitpy/port/ios_simulator.py:
348         (IPhoneSimulatorPort):
349         (IPadSimulatorPort):
350
351 2019-01-18  Chris Dumez  <cdumez@apple.com>
352
353         Regression(PSON) Scroll position is not always restored properly when navigating back
354         https://bugs.webkit.org/show_bug.cgi?id=193578
355         <rdar://problem/47386331>
356
357         Reviewed by Tim Horton.
358
359         Add API test coverage.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
362
363 2019-01-18  Youenn Fablet  <youenn@apple.com>
364
365         Add a new SPI to request for cache storage quota increase
366         https://bugs.webkit.org/show_bug.cgi?id=193323
367
368         Reviewed by Alex Christensen.
369
370         Implement WebsiteDataStore quota delegate to handle quota requests.
371         By default, do not update quota.
372         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
373
374         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
375         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
376         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
377         * WebKitTestRunner/InjectedBundle/TestRunner.h:
378         * WebKitTestRunner/TestController.cpp:
379         (WTR::TestController::allowCacheStorageQuotaIncrease):
380         * WebKitTestRunner/TestController.h:
381         * WebKitTestRunner/TestInvocation.cpp:
382         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
383         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
384         (-[CacheStorageQuotaManager init]):
385         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
386         (WTR::initializeWebViewConfiguration):
387         (WTR::TestController::cocoaResetStateToConsistentValues):
388         (WTR::TestController::allowCacheStorageQuotaIncrease):
389
390 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
391
392         [ews-build] Pass owner to the triggered builds
393         https://bugs.webkit.org/show_bug.cgi?id=193574
394
395         Reviewed by Lucas Forschler.
396
397         * BuildSlaveSupport/ews-build/factories.py:
398         (BuildFactory.propertiesToPassToTriggers):
399
400 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
401
402         [ews-app] Send patch author as a build property
403         https://bugs.webkit.org/show_bug.cgi?id=193560
404
405         Reviewed by Lucas Forschler.
406
407         * BuildSlaveSupport/ews-app/ews/fetcher.py:
408         (BugzillaPatchFetcher.fetch):
409
410 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
411
412         webkitpy: Implement device type specific expected results (Follow-up fix)
413         https://bugs.webkit.org/show_bug.cgi?id=192162
414         <rdar://problem/46345449>
415
416         Unreviewed infrastructure fix.
417
418         * Scripts/webkitpy/layout_tests/controllers/manager.py:
419         (Manager.run): Don't boot a device if no tests are available to run on it.
420
421 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
422
423         webkitpy: Implement device type specific expected results (Follow-up fix)
424         https://bugs.webkit.org/show_bug.cgi?id=192162
425         <rdar://problem/46345449>
426
427         Unreviewed infrastructure fix.
428
429         * Scripts/webkitpy/api_tests/manager.py:
430         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
431
432 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
433
434         webkitpy: Implement device type specific expected results (Part 2)
435         https://bugs.webkit.org/show_bug.cgi?id=192162
436         <rdar://problem/46345449>
437
438         Rubber-stamped by Aakash Jain.
439
440         This change uses device_type to select a different set of TestExpectation files based on the type of device running
441         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
442         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
443
444         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
445         (LayoutTestFinder.find_tests): Pass device_type through.
446         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
447         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
448         * Scripts/webkitpy/layout_tests/controllers/manager.py:
449         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
450         (Manager._collect_tests): Pass device type to test finder.
451         (Manager._needs_web_platform_test):
452         (Manager._prepare_lists): Index _expectations by device type.
453         (Manager._test_input_for_file):
454         (Manager._test_is_slow): Ditto.
455         (Manager._test_should_dump_jsconsolelog_in_stderr):
456         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
457         (Manager._get_test_inputs):
458         (Manager._update_worker_count):
459         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
460         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
461         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
462         the one which runs the test.
463         (Manager._run_test_subset):
464         (Manager._run_tests): Index _expectations by current_device_type.
465         (Manager._print_expectation_line_for_test): Ditto.
466         (Manager._print_expectations_for_subset): Ditto.
467         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
468         Unlike run, this function will behave the same regardless of what devices are available.
469         (Manager._custom_device_for_test): Deleted.
470         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
471         (ManagerTest.test_uses_custom_device): Deleted.
472         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
473         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
474         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
475         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
476         all of the expectations.
477         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
478         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
479         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
480         (TestExpectations.__init__): Allow device_type to be passed through.
481         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
482         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
483         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
484         (summarize_results):
485         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
486         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
487         a test ran with, one must check all expectations to find the first non-skip expectation.
488         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
489         (RunTest.test_device_type_test_division):
490         (RunTest):
491         (RunTest.test_device_type_specific_listing):
492         * Scripts/webkitpy/port/base.py:
493         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
494         (Port.supported_device_types): The result of this function will change based on what devices are available.
495         * Scripts/webkitpy/port/device_port.py:
496         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
497         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
498         can be used.
499         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
500         any, or the DEFAULT_DEVICE_TYPES of the port.
501         * Scripts/webkitpy/port/ios.py:
502         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
503         * Scripts/webkitpy/port/ios_simulator.py:
504         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
505         * Scripts/webkitpy/port/watch.py:
506         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
507         * Scripts/webkitpy/port/watch_simulator.py:
508         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
509         * Scripts/webkitpy/xcode/device_type.py:
510         (DeviceType):
511         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
512
513 2019-01-18  Philippe Normand  <pnormand@igalia.com>
514
515         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
516         https://bugs.webkit.org/show_bug.cgi?id=193575
517
518         Reviewed by Michael Catanzaro.
519
520         Allow the script to run without explicit port argument because
521         it's specific to the WPE port anyway.
522
523         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
524         and simplify the rest of the code accordingly.
525
526 2019-01-18  Charlie Turner  <cturner@igalia.com>
527
528         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
529         https://bugs.webkit.org/show_bug.cgi?id=192229
530
531         Reviewed by Xabier Rodriguez-Calvar.
532
533         * MiniBrowser/wpe/main.cpp:
534         (main): Enable encrypted-media by default.
535
536 2019-01-18  Philippe Normand  <pnormand@igalia.com>
537
538         [Flatpak] Missing KeyboardInterrupt exception handler
539         https://bugs.webkit.org/show_bug.cgi?id=193570
540
541         Reviewed by Michael Catanzaro.
542
543         * flatpak/flatpakutils.py:
544         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
545
546 2019-01-18  Zalan Bujtas  <zalan@apple.com>
547
548         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
549         https://bugs.webkit.org/show_bug.cgi?id=193564
550
551         Reviewed by Antti Koivisto.
552
553         * LayoutReloaded/misc/LFC-passing-tests.txt:
554
555 2019-01-18  Zalan Bujtas  <zalan@apple.com>
556
557         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
558         https://bugs.webkit.org/show_bug.cgi?id=193562
559
560         Reviewed by Antti Koivisto.
561
562         * LayoutReloaded/misc/LFC-passing-tests.txt:
563
564 2019-01-18  Zalan Bujtas  <zalan@apple.com>
565
566         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
567         https://bugs.webkit.org/show_bug.cgi?id=193555
568
569         Reviewed by Antti Koivisto.
570
571         * LayoutReloaded/misc/LFC-passing-tests.txt:
572
573 2019-01-18  Philippe Normand  <pnormand@igalia.com>
574
575         [WPE] Add Qt extension
576         https://bugs.webkit.org/show_bug.cgi?id=191464
577
578         Reviewed by Carlos Garcia Campos.
579
580         MiniBrowser and API tests for the WPE Qt API. To run the
581         MiniBrowser a new script is introduced. Example invocation:
582
583         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
584
585         Also note-worthy is the introduction of the python2-subprocess32
586         dependency to run the GLib API tests.
587
588         * MiniBrowser/wpe/CMakeLists.txt:
589         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
590         * MiniBrowser/wpe/qt/main.cpp: Added.
591         (main):
592         * MiniBrowser/wpe/qt/main.qml: Added.
593         * MiniBrowser/wpe/qt/qml.qrc: Added.
594         * Scripts/run-gtk-tests:
595         (GtkTestRunner.is_google_test):
596         (GtkTestRunner):
597         (GtkTestRunner.is_qt_test):
598         * Scripts/run-qt-wpe-minibrowser: Added.
599         * Scripts/run-wpe-tests:
600         (WPETestRunner):
601         (WPETestRunner.is_google_test):
602         (WPETestRunner.is_qt_test):
603         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
604         (TestLoad::main):
605         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
606         (TestLoadHtml::main):
607         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
608         (TestLoadRequest::main):
609         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
610         (TestRunJavaScript::main):
611         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
612         (waitForSignal):
613         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
614         (LoadSpy::LoadSpy):
615         (LoadSpy::~LoadSpy):
616         (LoadSpy::onLoadingChanged):
617         (LoadStartedCatcher::LoadStartedCatcher):
618         (LoadStartedCatcher::~LoadStartedCatcher):
619         (LoadStartedCatcher::onLoadingChanged):
620         (waitForLoadSucceeded):
621         (waitForLoadFailed):
622         * TestWebKitAPI/glib/CMakeLists.txt:
623         * flatpak/flatpakutils.py:
624         (WebkitFlatpak.load_from_args):
625         (WebkitFlatpak.__init__):
626         (WebkitFlatpak.clean_args):
627         (WebkitFlatpak.run_in_sandbox):
628         * flatpak/org.webkit.CommonModules.yaml:
629         * flatpak/org.webkit.WPE.yaml:
630         * flatpak/org.webkit.WPEModules.yaml:
631         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
632         * flatpak/org.webkit.WebKit.yaml:
633         * glib/api_test_runner.py:
634         (TestRunner._run_test_qt):
635         (TestRunner.is_qt_test):
636         (TestRunner._run_test):
637
638 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
639
640         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
641         https://bugs.webkit.org/show_bug.cgi?id=193494
642         <rdar://problem/46859627>
643
644         Reviewed by Simon Fraser and Tim Horton.
645
646         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
647         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
648
649         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
650         (WTR::UIScriptController::contentOffsetX const):
651         (WTR::UIScriptController::contentOffsetY const):
652         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
653         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
654         (WTR::UIScriptController::contentOffsetX const):
655         (WTR::UIScriptController::contentOffsetY const):
656         * TestRunnerShared/UIScriptContext/UIScriptController.h:
657
658         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
659
660         * WebKitTestRunner/TestController.cpp:
661         (WTR::updateTestOptionsFromTestHeader):
662         * WebKitTestRunner/TestOptions.h:
663         (WTR::TestOptions::hasSameInitializationOptions const):
664         * WebKitTestRunner/ios/TestControllerIOS.mm:
665         (WTR::TestController::platformResetStateToConsistentValues):
666         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
667         (WTR::UIScriptController::contentOffsetX const):
668         (WTR::UIScriptController::contentOffsetY const):
669
670 2019-01-17  Truitt Savell  <tsavell@apple.com>
671
672         Unreviewed, rolling out r240124.
673
674         This commit broke an internal build.
675
676         Reverted changeset:
677
678         "SDK_VARIANT build destinations should be separate from non-
679         SDK_VARIANT builds"
680         https://bugs.webkit.org/show_bug.cgi?id=189553
681         https://trac.webkit.org/changeset/240124
682
683 2019-01-17  Alex Christensen  <achristensen@webkit.org>
684
685         Fix string concatenation API test after r239920
686         https://bugs.webkit.org/show_bug.cgi?id=193551
687         <rdar://problem/47359304>
688
689         Reviewed by Youenn Fablet.
690
691         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
692         (TestWebKitAPI::TEST):
693         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
694         in WebKit's build configuration like it apparently is on Linux.
695
696 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
697
698         [ews-build] validate-patch should handle the case when bug_id is None
699         https://bugs.webkit.org/show_bug.cgi?id=193547
700
701         Reviewed by Lucas Forschler.
702
703         * BuildSlaveSupport/ews-build/steps.py:
704         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
705         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
706
707 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
708
709         [ews-build] Add patch author information in build
710         https://bugs.webkit.org/show_bug.cgi?id=193465
711
712         Reviewed by Lucas Forschler.
713
714         * BuildSlaveSupport/ews-build/steps.py:
715         (ValidatePatch._is_patch_obsolete):
716
717 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
718
719         [ews-build] Pass bug_id to the triggered builds
720         https://bugs.webkit.org/show_bug.cgi?id=193548
721
722         Reviewed by Lucas Forschler.
723
724         * BuildSlaveSupport/ews-build/factories.py:
725         (BuildFactory.propertiesToPassToTriggers):
726
727 2019-01-17  Jer Noble  <jer.noble@apple.com>
728
729         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
730         https://bugs.webkit.org/show_bug.cgi?id=189553
731
732         Reviewed by Tim Horton.
733
734         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
735
736         * ContentExtensionTester/Configurations/Base.xcconfig:
737         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
738         * DumpRenderTree/mac/Configurations/Base.xcconfig:
739         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
740         * ImageDiff/cg/Configurations/Base.xcconfig:
741         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
742         * MiniBrowser/Configurations/Base.xcconfig:
743         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
744         * MobileMiniBrowser/Configurations/Base.xcconfig:
745         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
746         * Scripts/webkitpy/style/checker.py:
747         (_all_categories):
748         (FileType):
749         (CheckerDispatcher._file_type):
750         (CheckerDispatcher._create_checker):
751         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
752         (SDKVariantChecker):
753         (SDKVariantChecker.__init__):
754         (SDKVariantChecker.check):
755         * TestWebKitAPI/Configurations/Base.xcconfig:
756         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
757         * WebEditingTester/Configurations/Base.xcconfig:
758         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
759         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
760         * WebKitTestRunner/Configurations/Base.xcconfig:
761         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
762         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
763         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
764
765 2019-01-17  Zalan Bujtas  <zalan@apple.com>
766
767         [LFC][BFC] An element with transform is a containing block for positioned descendants.
768         https://bugs.webkit.org/show_bug.cgi?id=193534
769
770         Reviewed by Antti Koivisto.
771
772         * LayoutReloaded/misc/LFC-passing-tests.txt:
773
774 2019-01-17  Zalan Bujtas  <zalan@apple.com>
775
776         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
777         https://bugs.webkit.org/show_bug.cgi?id=193528
778
779         Reviewed by Antti Koivisto.
780
781         * LayoutReloaded/misc/LFC-passing-tests.txt:
782
783 2019-01-17  Zalan Bujtas  <zalan@apple.com>
784
785         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
786         https://bugs.webkit.org/show_bug.cgi?id=193520
787
788         Reviewed by Antti Koivisto.
789
790         * LayoutReloaded/misc/LFC-passing-tests.txt:
791
792 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
793
794         [ews-build] unapply-patch step should not update source
795         https://bugs.webkit.org/show_bug.cgi?id=193234
796
797         Reviewed by Lucas Forschler.
798
799         * BuildSlaveSupport/ews-build/steps.py:
800         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
801         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
802
803 2019-01-16  Youenn Fablet  <youenn@apple.com>
804
805         Add a new SPI for controlling getUserMedia
806         https://bugs.webkit.org/show_bug.cgi?id=192793
807
808         Reviewed by Eric Carlson.
809
810         * MiniBrowser/mac/WK2BrowserWindowController.m:
811         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
812         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
813         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
814         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
815         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
816         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
817         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
818         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
819         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
820         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
821         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
822         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
823         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
824         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
825
826 2019-01-16  Zalan Bujtas  <zalan@apple.com>
827
828         [LFC][BFC] Inflow non-replaced used width should not be negative.
829         https://bugs.webkit.org/show_bug.cgi?id=193495
830
831         Reviewed by Antti Koivisto.
832
833         * LayoutReloaded/misc/LFC-passing-tests.txt:
834
835 2019-01-16  Chris Dumez  <cdumez@apple.com>
836
837         Regression(PSON) View becomes blank after click a cross-site download link
838         https://bugs.webkit.org/show_bug.cgi?id=193361
839         <rdar://problem/47099573>
840
841         Reviewed by Geoffrey Garen.
842
843         Add API test coverage.
844
845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
846         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
847
848 2019-01-16  Zalan Bujtas  <zalan@apple.com>
849
850         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
851         https://bugs.webkit.org/show_bug.cgi?id=193470
852
853         Reviewed by Antti Koivisto.
854
855         * LayoutReloaded/misc/LFC-passing-tests.txt:
856
857 2019-01-16  Zalan Bujtas  <zalan@apple.com>
858
859         [LFC] Adjust margin box verification.
860         https://bugs.webkit.org/show_bug.cgi?id=193482
861
862         Reviewed by Antti Koivisto.
863
864         * LayoutReloaded/misc/LFC-passing-tests.txt:
865
866 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
867
868         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
869         https://bugs.webkit.org/show_bug.cgi?id=193451
870
871         Reviewed by Geoffrey Garen.
872
873         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
874         (TEST):
875         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
876         (runWebsiteDataStoreCustomPaths):
877
878 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
879
880         webkitpy: Support boolean simctl isAvailable
881         https://bugs.webkit.org/show_bug.cgi?id=193472
882         <rdar://problem/47296150>
883
884         Reviewed by Ryosuke Niwa.
885
886         * Scripts/webkitpy/xcode/simulated_device.py:
887         (SimulatedDeviceManager._create_runtimes):
888         (SimulatedDeviceManager._create_device_with_runtime):
889
890 2019-01-15  Chris Dumez  <cdumez@apple.com>
891
892         Unreviewed, rolling out r239993, r239995, r239997, and
893         r239999.
894
895         Caused assertions under
896         ViewGestureController::disconnectFromProcess()
897
898         Reverted changesets:
899
900         "Regression(PSON) View becomes blank after click a cross-site
901         download link"
902         https://bugs.webkit.org/show_bug.cgi?id=193361
903         https://trac.webkit.org/changeset/239993
904
905         "Unreviewed iOS build fix after r239993."
906         https://trac.webkit.org/changeset/239995
907
908         "Fix iOS build after r239993"
909         https://bugs.webkit.org/show_bug.cgi?id=193361
910         https://trac.webkit.org/changeset/239997
911
912         "Unreviewed, revert part of r239997 as it is not needed to fix
913         the build."
914         https://trac.webkit.org/changeset/239999
915
916 2019-01-15  Tim Horton  <timothy_horton@apple.com>
917
918         Cannot tab out of WKWebView on macOS
919         https://bugs.webkit.org/show_bug.cgi?id=161448
920         <rdar://problem/28100085>
921
922         Reviewed by Dean Jackson.
923
924         Add a test that tabbing into and out of WKWebView works correctly.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
928         (WebKit2_CommandBackForwardTest::SetUp):
929         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
930         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
931         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
932         (-[FocusableView canBecomeKeyView]):
933         (TEST):
934         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
935         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
936         (-[OffscreenWindow initWithSize:]):
937         (-[OffscreenWindow isKeyWindow]):
938         (-[OffscreenWindow isVisible]):
939         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
940         (TestWebKitAPI::PlatformWebView::initialize):
941         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
942         (-[ActiveOffscreenWindow isVisible]): Deleted.
943         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
944
945 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
946
947         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
948         https://bugs.webkit.org/show_bug.cgi?id=193459
949
950         Reviewed by Mark Lam.
951
952         * BuildSlaveSupport/build.webkit.org-config/steps.py:
953         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
954
955 2019-01-15  Chris Dumez  <cdumez@apple.com>
956
957         Regression(PSON) View becomes blank after click a cross-site download link
958         https://bugs.webkit.org/show_bug.cgi?id=193361
959         <rdar://problem/47099573>
960
961         Reviewed by Geoff Garen.
962
963         Add API test coverage.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
966         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
967
968 2019-01-15  Zalan Bujtas  <zalan@apple.com>
969
970         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
971         https://bugs.webkit.org/show_bug.cgi?id=193448
972
973         Reviewed by Antti Koivisto.
974
975         * LayoutReloaded/misc/LFC-passing-tests.txt:
976
977 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
978
979         webkitpy: Implement device type specific expected results (Part 1)
980         https://bugs.webkit.org/show_bug.cgi?id=192162
981
982         Reviewed by Lucas Forschler.
983
984         Device type specific expected results covers two related ideas. The first (covered by this change)
985         is where to search for -expected.* files. The second is which tests to run based on the
986         TestExpectations.txt file.
987
988         After this change, the baseline search path will be determined by the type of device running a
989         test. Device type will be passed into any function which picks a file based on the baseline search
990         path.
991
992         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
993         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
994         * Scripts/webkitpy/layout_tests/controllers/manager.py:
995         (Manager.run): Print baseline search path for each round of devices.
996         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
997         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
998         (SingleTestRunner._expected_driver_output): Ditto.
999         (SingleTestRunner._driver_input): Ditto.
1000         * Scripts/webkitpy/layout_tests/views/printing.py:
1001         (Printer.print_config): Move printing of baseline search path to a separate function.
1002         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1003         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1004         (Testprinter.test_print_config):
1005         (Testprinter.test_print_baseline_search_path):
1006         * Scripts/webkitpy/port/base.py:
1007         (Port.baseline_search_path): Pass device_type through.
1008         (Port._expected_baselines_for_suffixes): Ditto.
1009         (Port.expected_baselines): Ditto.
1010         (Port.expected_filename): Ditto.
1011         (Port.expected_checksum): Ditto.
1012         (Port.expected_image): Ditto.
1013         (Port.expected_audio): Ditto.
1014         (Port.expected_text): Ditto.
1015         (Port.reference_files): Ditto.
1016         (Port.tests): Ditto.
1017         (Port._expanded_paths): Ditto.
1018         (Port.skipped_layout_tests): Ditto.
1019         (Port.expectations_dict): Ditto.
1020         (Port._port_specific_expectations_files): Ditto.
1021         (Port.expectations_files): Ditto.
1022         (Port.test_search_path): Ditto.
1023         (Port._tests_for_other_platforms): Ditto.
1024         * Scripts/webkitpy/port/base_unittest.py:
1025         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1026         (PortTest.test_nonexistant_expectations): Ditto.
1027         (test_ref_tests_platform_directory): Ditto.
1028         * Scripts/webkitpy/port/darwin.py:
1029         (DarwinPort._port_specific_expectations_files): Accept device_type.
1030         * Scripts/webkitpy/port/driver.py:
1031         (DriverProxy):
1032         (DriverProxy.host): Expose _target_host for device_type information.
1033         * Scripts/webkitpy/port/gtk.py:
1034         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1035         * Scripts/webkitpy/port/ios.py:
1036         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1037         * Scripts/webkitpy/port/mac.py:
1038         (MacPort. default_baseline_search_path): Ditto.
1039         * Scripts/webkitpy/port/port_testcase.py:
1040         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1041         * Scripts/webkitpy/port/test.py:
1042         * Scripts/webkitpy/port/watch.py:
1043         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1044         * Scripts/webkitpy/port/win.py:
1045         (WinPort.test_search_path): Accept, but do not use, device_type.
1046         * Scripts/webkitpy/port/wpe.py:
1047         (WPEPort._port_specific_expectations_files): Ditto.
1048         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1049         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1050
1051 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1052
1053         [LFC] Use the containing block's padding box to position out-of-flow elements.
1054         https://bugs.webkit.org/show_bug.cgi?id=193431
1055
1056         Reviewed by Antti Koivisto.
1057
1058         * LayoutReloaded/misc/LFC-passing-tests.txt:
1059
1060 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1061
1062         Move a test implementation file that got misplaced in the Xcode project
1063
1064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1065
1066 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1067
1068         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1069         r239913, and r239914.
1070         https://bugs.webkit.org/show_bug.cgi?id=193407
1071
1072         These revisions caused an internal failure (Requested by
1073         Truitt on #webkit).
1074
1075         Reverted changesets:
1076
1077         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1078         https://bugs.webkit.org/show_bug.cgi?id=186016
1079         https://trac.webkit.org/changeset/239901
1080
1081         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1082         https://trac.webkit.org/changeset/239909
1083
1084         "Tried to fix the build."
1085         https://trac.webkit.org/changeset/239910
1086
1087         "Fixed iOS builds after r239910."
1088         https://trac.webkit.org/changeset/239912
1089
1090         "More build fixing."
1091         https://trac.webkit.org/changeset/239913
1092
1093         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1094         https://trac.webkit.org/changeset/239914
1095
1096 2019-01-14  Mark Lam  <mark.lam@apple.com>
1097
1098         Re-enable ability to build --cloop builds.
1099         https://bugs.webkit.org/show_bug.cgi?id=192955
1100         <rdar://problem/46882363>
1101
1102         Reviewed by Saam barati and Keith Miller.
1103
1104         The --cloop build option was being ignored this whole time since r236381.
1105         This patch makes it possible to build CLoop builds again.
1106
1107         * Scripts/build-jsc:
1108         * Scripts/webkitperl/FeatureList.pm:
1109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1110
1111 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1112
1113         webkitpy: Expose device_type from host-like objects
1114         https://bugs.webkit.org/show_bug.cgi?id=193406
1115         <rdar://problem/47262305>
1116
1117         Reviewed by Lucas Forschler.
1118
1119         Devices should expose device_type. As a result, all host objects should
1120         provide a device_type property, even if they do not yet define a device_type.
1121
1122         * Scripts/webkitpy/common/system/systemhost.py:
1123         (SystemHost):
1124         (SystemHost.device_type):
1125         * Scripts/webkitpy/common/system/systemhost_mock.py:
1126         (MockSystemHost):
1127         (MockSystemHost.device_type):
1128         * Scripts/webkitpy/port/device.py:
1129         (Device):
1130         (Device.device_type):
1131         * Scripts/webkitpy/xcode/simulated_device.py:
1132         (SimulatedDeviceManager._find_exisiting_device_for_request):
1133         (SimulatedDeviceManager._disambiguate_device_type):
1134         (SimulatedDeviceManager._does_fulfill_request):
1135         (SimulatedDeviceManager.device_count_for_type):
1136         (SimulatedDeviceManager.initialize_devices):
1137         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1138         (test_available_devices):
1139         (test_swapping_devices):
1140
1141 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1142
1143         webkitpy: Support alternate simctl device list output (Follow-up fix)
1144         https://bugs.webkit.org/show_bug.cgi?id=193362
1145         <rdar://problem/47122965>
1146
1147         Rubber-stamped by Lucas Forschler.
1148
1149         * Scripts/webkitpy/xcode/simulated_device.py:
1150         (SimulatedDeviceManager.populate_available_devices):
1151
1152 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1153
1154         [iOS] Expose SPI to access the current sentence boundary and selection state
1155         https://bugs.webkit.org/show_bug.cgi?id=193398
1156         <rdar://problem/45893108>
1157
1158         Reviewed by Dean Jackson.
1159
1160         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1161         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1162         expected.
1163
1164         * TestWebKitAPI/EditingTestHarness.h:
1165         * TestWebKitAPI/EditingTestHarness.mm:
1166         (-[EditingTestHarness moveBackward]):
1167         (-[EditingTestHarness moveForward]):
1168         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1169
1170         Add a couple of new helper methods on EditingTestHarness.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1173         (-[SelectionChangeObserver initWithWebView:]):
1174         (-[SelectionChangeObserver webView]):
1175         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1176         (-[SelectionChangeObserver currentSelectionAttributes]):
1177
1178 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1179
1180         [LFC][BFC] Add basic box-sizing support.
1181         https://bugs.webkit.org/show_bug.cgi?id=193392
1182
1183         Reviewed by Antti Koivisto.
1184
1185         * LayoutReloaded/misc/LFC-passing-tests.txt:
1186
1187 2019-01-14  Charlie Turner  <cturner@igalia.com>
1188
1189         [WPE] API test gardening
1190         https://bugs.webkit.org/show_bug.cgi?id=193319
1191
1192         Reviewed by Michael Catanzaro.
1193
1194         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1195         passing tests.
1196
1197 2019-01-14  Charlie Turner  <cturner@igalia.com>
1198
1199         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1200         https://bugs.webkit.org/show_bug.cgi?id=192977
1201
1202         Reviewed by Carlos Garcia Campos.
1203
1204         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1205         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1206         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1207         (TestWebKitAPI::GStreamerTest::SetUp):
1208         (TestWebKitAPI::GStreamerTest::TearDown):
1209         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1210         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1211         (TestWebKitAPI::TEST_F):
1212
1213 2019-01-14  Charlie Turner  <cturner@igalia.com>
1214
1215         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1216         https://bugs.webkit.org/show_bug.cgi?id=193332
1217
1218         Reviewed by Michael Catanzaro.
1219
1220         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1221         defined as a char16_t, which changed in ICU 59, the
1222         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1223         unsigned short. This test is relying on the behaviour that
1224         UChar=unsigned short, which doesn't hold across platforms and ICU
1225         library versions. The full fix would be a special syntax for
1226         literal characters so that these ambiguities do not arise. That
1227         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1228         (TestWebKitAPI::TEST):
1229
1230 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1231
1232         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1233
1234         * Scripts/make-dist:
1235         (Distcheck.configure):
1236
1237 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-build] Update macOS queue configurations
1240         https://bugs.webkit.org/show_bug.cgi?id=193365
1241         <rdar://problem/47221073>
1242
1243         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1244
1245         * BuildSlaveSupport/ews-build/config.json:
1246
1247 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1248
1249         [LFC] Adjust assert for statically positioned fixed elements
1250         https://bugs.webkit.org/show_bug.cgi?id=193385
1251
1252         Reviewed by Antti Koivisto.
1253
1254         * LayoutReloaded/misc/LFC-passing-tests.txt:
1255
1256 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1257
1258         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1259         https://bugs.webkit.org/show_bug.cgi?id=193387
1260
1261         Reviewed by Carlos Garcia Campos.
1262
1263         * MiniBrowser/wpe/main.cpp:
1264         (main):
1265
1266 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1267
1268         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1269         https://bugs.webkit.org/show_bug.cgi?id=191655
1270         rdar://problem/46074680
1271
1272         Reviewed by Megan Gardner.
1273
1274         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1275         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1276
1277 2019-01-12  Dan Bernstein  <mitz@apple.com>
1278
1279         [Cocoa] Avoid importing directly from subumbrella frameworks
1280         https://bugs.webkit.org/show_bug.cgi?id=186016
1281         <rdar://problem/40591038>
1282
1283         Reviewed by Sam Weinig.
1284
1285         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1286           LaunchServices header.
1287         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1288           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1289         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1290           when using SDKs earlier than 10.13.
1291         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1292           and OTHER_CPLUSPLUSFLAGS.
1293         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1294           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1295         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1296           LaunchServices header.
1297
1298 2019-01-11  John Wilander  <wilander@apple.com>
1299
1300         Compile out Web API Statistics Collection
1301         https://bugs.webkit.org/show_bug.cgi?id=193370
1302         <rdar://problem/45388584>
1303
1304         Reviewed by Brent Fulgham.
1305
1306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1307             Defined ENABLE_WEB_API_STATISTICS, off by default.
1308
1309 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1310
1311         [WPE] Add gtk-doc
1312         https://bugs.webkit.org/show_bug.cgi?id=178900
1313
1314         Reviewed by Michael Catanzaro.
1315
1316         Add Tools/gtkdoc to manifest.txt.in files.
1317         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1318
1319         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1320         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1321
1322 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1323
1324         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1325         https://bugs.webkit.org/show_bug.cgi?id=193364
1326         <rdar://problem/47214117>
1327
1328         Reviewed by Tim Horton.
1329
1330         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1331         precise, whereas dragging near the middle of the textarea does.
1332
1333         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1334         (TestWebKitAPI::TEST):
1335
1336 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1337
1338         webkitpy: Support alternate simctl device list output
1339         https://bugs.webkit.org/show_bug.cgi?id=193362
1340         <rdar://problem/47122965>
1341
1342         Reviewed by Lucas Forschler.
1343
1344         * Scripts/webkitpy/xcode/simulated_device.py:
1345         (SimulatedDeviceManager.populate_available_devices):
1346
1347 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-build] Update macOS queue configurations
1350         https://bugs.webkit.org/show_bug.cgi?id=193365
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-build/config.json:
1355
1356 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1357
1358         webkitpy: Incorporate device type into baseline search path
1359         https://bugs.webkit.org/show_bug.cgi?id=193356
1360         <rdar://problem/47215515>
1361
1362         Reviewed by Lucas Forschler.
1363
1364         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1365
1366         * Scripts/webkitpy/port/base.py:
1367         (Port.default_baseline_search_path): Allow device type to be passed in.
1368         * Scripts/webkitpy/port/gtk.py:
1369         (GtkPort.default_baseline_search_path): Ignore device type.
1370         * Scripts/webkitpy/port/ios.py:
1371         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1372         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1373         * Scripts/webkitpy/port/ios_device_unittest.py:
1374         (IOSDeviceTest):
1375         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1376         (IOSSimulatorTest):
1377         * Scripts/webkitpy/port/mac.py:
1378         (MacPort.default_baseline_search_path): Ignore device type.
1379         * Scripts/webkitpy/port/watch.py:
1380         (WatchPort.default_baseline_search_path): Ditto.
1381         * Scripts/webkitpy/port/win.py:
1382         (WinPort.default_baseline_search_path): Ditto.
1383         (WinCairoPort.default_baseline_search_path): Ditto.
1384         * Scripts/webkitpy/port/wpe.py:
1385         (WPEPort.default_baseline_search_path): Ditto.
1386
1387 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1388
1389         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1390         https://bugs.webkit.org/show_bug.cgi?id=193352
1391         <rdar://problem/47210736>
1392
1393         Reviewed by Lucas Forschler.
1394
1395         * Scripts/webkitpy/layout_tests/views/printing.py:
1396         (Printer.print_config): Print list on only baseline search paths which exist. 
1397         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1398         (Testprinter.test_print_config):
1399
1400 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1401
1402         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1403         https://bugs.webkit.org/show_bug.cgi?id=193340
1404
1405         Reviewed by David Kilzer.
1406
1407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1408         (WTR::InjectedBundle::didReceiveMessageToPage):
1409         Pull the strings out into a WKRetainPtr.
1410
1411         * WebKitTestRunner/WebNotificationProvider.cpp:
1412         (WTR::WebNotificationProvider::closeWebNotification):
1413         Adopt the created value into the WKRetainPtr.
1414
1415         * WebKitTestRunner/mac/TestControllerMac.mm:
1416         (WTR::generateWhitelist):
1417         Immediately adopt a created value to avoid potential mistakes.
1418
1419 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1420
1421         Enable DFG on ARM/Linux again
1422         https://bugs.webkit.org/show_bug.cgi?id=192496
1423
1424         Reviewed by Yusuke Suzuki.
1425
1426         After changing the bytecode format DFG was disabled on all 32-bit
1427         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1428         on ARM by default.
1429
1430         * Scripts/run-jsc-stress-tests:
1431
1432 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1433
1434         Unreviewed, fix #ifdef in API test added in r239851.
1435         https://bugs.webkit.org/show_bug.cgi?id=193327
1436         rdar://problem/47093222
1437
1438         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1439
1440 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1441
1442         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1443         https://bugs.webkit.org/show_bug.cgi?id=193109
1444         <rdar://problem/44807048>
1445
1446         Reviewed by Ryosuke Niwa.
1447
1448         Introduce and respect a test option to enable the UndoManager API.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::updateTestOptionsFromTestHeader):
1452         * WebKitTestRunner/TestOptions.h:
1453         (WTR::TestOptions::hasSameInitializationOptions const):
1454         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1455         (WTR::TestController::platformCreateWebView):
1456
1457 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1458
1459         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1460         https://bugs.webkit.org/show_bug.cgi?id=193346
1461
1462         Reviewed by Antti Koivisto.
1463
1464         * LayoutReloaded/misc/LFC-passing-tests.txt:
1465
1466 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1467
1468         Unreviewed, fix typo that breaks dashboard link.
1469
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1471         (WebKitBuildbot):
1472
1473 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1474
1475         Update macOS queue configurations
1476         https://bugs.webkit.org/show_bug.cgi?id=193329
1477
1478         Reviewed by Alexey Proskuryakov.
1479
1480         * BuildSlaveSupport/build.webkit.org-config/config.json:
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1482         (BubbleQueueServer):
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1485         (WebKitBuildbot):
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1487         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1488         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1489
1490 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1491
1492         MiniBrowser should be able to navigate to about:blank
1493         https://bugs.webkit.org/show_bug.cgi?id=193345
1494
1495         Reviewed by Simon Fraser.
1496
1497         * MiniBrowser/mac/BrowserWindowController.m:
1498         (-[BrowserWindowController addProtocolIfNecessary:]):
1499         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1500
1501         * MiniBrowser/mac/WK1BrowserWindowController.m:
1502         (-[WK1BrowserWindowController fetch:]):
1503         * MiniBrowser/mac/WK2BrowserWindowController.m:
1504         (-[WK2BrowserWindowController fetch:]):
1505         Clean up the code that uses this to match style.
1506
1507 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1508
1509         Remove MiniBrowser custom "Process Swap" menu item which does not work
1510         https://bugs.webkit.org/show_bug.cgi?id=193344
1511
1512         Reviewed by Simon Fraser.
1513
1514         There is a menu item under the Experimental menu that does work.
1515
1516         * MiniBrowser/mac/AppDelegate.m:
1517         (defaultConfiguration):
1518         * MiniBrowser/mac/SettingsController.h:
1519         * MiniBrowser/mac/SettingsController.m:
1520         (-[SettingsController _populateMenu]):
1521         (-[SettingsController validateMenuItem:]):
1522         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1523         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1524
1525 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1526
1527         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1528         https://bugs.webkit.org/show_bug.cgi?id=193327
1529         rdar://problem/47093222
1530
1531         Reviewed by Tim Horton.
1532
1533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1534         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1535         (TestWebKitAPI::didFinishNavigation):
1536         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1537         (TestWebKitAPI::TEST):
1538         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1539         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1540         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1541         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1542         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1543
1544 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1545
1546         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1547         https://bugs.webkit.org/show_bug.cgi?id=193338
1548         <rdar://problem/46664774>
1549
1550         Reviewed by David Kilzer.
1551
1552         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1553         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1554
1555 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1556
1557         Unreviewed, rolling out r239825.
1558         https://bugs.webkit.org/show_bug.cgi?id=193330
1559
1560         Broke tests on armv7/linux bots (Requested by guijemont on
1561         #webkit).
1562
1563         Reverted changeset:
1564
1565         "Enable DFG on ARM/Linux again"
1566         https://bugs.webkit.org/show_bug.cgi?id=192496
1567         https://trac.webkit.org/changeset/239825
1568
1569 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1570
1571         Disable the run-jsc-stress-test remote host key check.
1572         https://bugs.webkit.org/show_bug.cgi?id=192988
1573
1574         Reviewed by Alexey Proskuryakov.
1575
1576         * Scripts/run-jsc-stress-tests:
1577
1578 2019-01-10  John Wilander  <wilander@apple.com>
1579
1580         Override the session configuration for cookieAcceptPolicy
1581         https://bugs.webkit.org/show_bug.cgi?id=190925
1582         <rdar://problem/45497382>
1583
1584         Reviewed by Alexey Proskuryakov and Alex Christensen.
1585
1586         Test infrastructure for setting a first-party-only cookie policy.
1587
1588         * DumpRenderTree/TestRunner.cpp:
1589         (setOnlyAcceptFirstPartyCookiesCallback):
1590         (TestRunner::staticFunctions):
1591         * DumpRenderTree/TestRunner.h:
1592         * DumpRenderTree/mac/TestRunnerMac.mm:
1593         (TestRunner::setOnlyAcceptFirstPartyCookies):
1594         * DumpRenderTree/win/TestRunnerWin.cpp:
1595         (TestRunner::setOnlyAcceptFirstPartyCookies):
1596         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1597         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1598         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1599         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1600         * WebKitTestRunner/TestInvocation.cpp:
1601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1602
1603 2019-01-09  Matt Rajca  <mrajca@apple.com>
1604
1605         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1606         https://bugs.webkit.org/show_bug.cgi?id=193301
1607
1608         Reviewed by Jer Noble.
1609         
1610         Added API tests.
1611
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1614         (TEST):
1615         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1616
1617 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1618
1619         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1620         https://bugs.webkit.org/show_bug.cgi?id=193310
1621
1622         Reviewed by Antti Koivisto.
1623
1624         * LayoutReloaded/misc/LFC-passing-tests.txt:
1625
1626 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1627
1628         Enable DFG on ARM/Linux again
1629         https://bugs.webkit.org/show_bug.cgi?id=192496
1630
1631         Reviewed by Yusuke Suzuki.
1632
1633         After changing the bytecode format DFG was disabled on all 32-bit
1634         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1635         on ARM by default.
1636
1637         * Scripts/run-jsc-stress-tests:
1638
1639 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1640
1641         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1642         https://bugs.webkit.org/show_bug.cgi?id=193271
1643
1644         Reviewed by Brent Fulgham.
1645
1646         BSTR is a special data structure created by SysAllocString, not a
1647         wchar_t null-terminated string.
1648
1649         * DumpRenderTree/win/TestRunnerWin.cpp:
1650         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1651         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1652         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1653         BSTR from wide string literals.
1654
1655 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1656
1657         Tweak wording for build/version_check style checker error
1658         https://bugs.webkit.org/show_bug.cgi?id=193256
1659
1660         Reviewed by Tim Horton.
1661
1662         * Scripts/webkitpy/style/checkers/cpp.py:
1663         (check_os_version_checks):
1664         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1665         (WebKitStyleTest.test_os_version_checks):
1666
1667 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1668
1669         [ews-build] Add link to bug along with bug title
1670         https://bugs.webkit.org/show_bug.cgi?id=193293
1671
1672         Reviewed by Lucas Forschler.
1673
1674         * BuildSlaveSupport/ews-build/steps.py:
1675         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1676         (ConfigureBuild.add_bug_id_url): Deleted.
1677         (ConfigureBuild.getBugURL): Deleted.
1678
1679 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1680
1681         [ews-build] Use https for ews-build server
1682         https://bugs.webkit.org/show_bug.cgi?id=193193
1683
1684         Reviewed by Lucas Forschler.
1685
1686         * BuildSlaveSupport/ews-build/steps.py:
1687
1688 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1689
1690         [ews-build] Parse and display number of style failures
1691         https://bugs.webkit.org/show_bug.cgi?id=193280
1692
1693         Reviewed by Lucas Forschler.
1694
1695         * BuildSlaveSupport/ews-build/steps.py:
1696         (CheckStyle): Use TestWithFailureCount as base class.
1697         (CheckStyle.countFailures): Count the number of style failures.
1698
1699 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1700
1701         [ews-build] use patch_id instead of ewspatchid
1702         https://bugs.webkit.org/show_bug.cgi?id=193235
1703
1704         Reviewed by Lucas Forschler.
1705
1706         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1707         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1708         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1709
1710 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1711
1712         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1713         https://bugs.webkit.org/show_bug.cgi?id=192625
1714
1715         Reviewed by Antti Koivisto.
1716
1717         * LayoutReloaded/misc/LFC-passing-tests.txt:
1718
1719 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1720
1721         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1722         https://bugs.webkit.org/show_bug.cgi?id=192841
1723
1724         Reviewed by Carlos Garcia Campos.
1725
1726         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1727         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1728         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1729
1730         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1731
1732         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1733         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1734         (WebKitWebEditorTest::testSelectionChanged):
1735         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1736         (WebKitFrameTest::testMainFrame):
1737         (WebKitFrameTest::testURI):
1738         (WebKitFrameTest::testJavaScriptContext):
1739         (WebKitFrameTest::testJavaScriptValues):
1740         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1741         (testWebViewAuthenticationRequest):
1742         (testWebViewAuthenticationLoadCancelled):
1743         (testWebViewAuthenticationFailure):
1744         (testWebViewAuthenticationStorage):
1745         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1746         (testWebViewAuthenticationProxy):
1747         (testWebViewAuthenticationProxyHTTPS):
1748         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1749         (testAutomationSessionRequestSession):
1750         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1751         (testBackForwardListNavigation):
1752         (testWebKitWebViewSessionState):
1753         (testWebKitWebViewSessionStateWithFormData):
1754         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1755         (ConsoleMessageTest::consoleMessageReceivedCallback):
1756         (testWebKitConsoleMessageConsoleAPI):
1757         (testWebKitConsoleMessageJavaScriptException):
1758         (testWebKitConsoleMessageNetworkError):
1759         (testWebKitConsoleMessageSecurityError):
1760         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1761         (testCookieManagerAcceptPolicy):
1762         (testCookieManagerCookiesChanged):
1763         (testCookieManagerPersistentStorage):
1764         (testCookieManagerPersistentStorageDeleteAll):
1765         (testCookieManagerEphemeral):
1766         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1767         (testWebKitDOMElementAutoFill):
1768         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1769         (downloadLocalFileSuccessfully):
1770         (createFileAtDestination):
1771         (testDownloadOverwriteDestinationDisallowed):
1772         (testDownloadLocalFileError):
1773         (testDownloadRemoteFile):
1774         (testDownloadRemoteFileError):
1775         (testWebViewDownloadURI):
1776         (testPolicyResponseDownload):
1777         (testPolicyResponseDownloadCancel):
1778         (testDownloadMIMEType):
1779         (contextMenuCallback):
1780         (testContextMenuDownloadActions):
1781         (testBlobDownload):
1782         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1783         (testWebKitWebEditorSelectionChanged):
1784         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1785         (testWebKitFrameMainFrame):
1786         (testWebKitFrameURI):
1787         (testWebKitFrameJavaScriptContext):
1788         (testWebKitFrameJavaScriptValues):
1789         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1790         (LoadStopTrackingTest::loadFailed):
1791         (testWebViewTitle):
1792         (testURIRequestHTTPHeaders):
1793         (testURIRequestHTTPMethod):
1794         (testURIResponseHTTPHeaders):
1795         (testRedirectToDataURI):
1796         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1797         (testProcessPerWebView):
1798         (testWebProcessLimit):
1799         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1800         (testWebViewResources):
1801         (testWebResourceLoading):
1802         (testWebResourceSuggestedFilename):
1803         (testWebResourceGetData):
1804         (testWebResourceGetDataError):
1805         (testWebViewResourcesHistoryCache):
1806         (testWebResourceSendRequest):
1807         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1808         (testSSL):
1809         (testInsecureContent):
1810         (testTLSErrorsPolicy):
1811         (testTLSErrorsRedirect):
1812         (testTLSErrorsHTTPAuth):
1813         (testLoadFailedWithTLSErrors):
1814         (testSubresourceLoadFailedWithTLSErrors):
1815         (httpsServerCallback):
1816         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1817         (testWebViewCreateNavigationData):
1818         (testWebViewJavaScriptDialogs):
1819         (testWebViewWindowProperties):
1820         (testWebViewMouseTarget):
1821         (testWebViewFileChooserRequest):
1822         (testWebViewColorChooserRequest):
1823         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1824         (testWebExtensionGetTitle):
1825         (testDocumentLoadedSignal):
1826         (testWebKitWebViewProcessCrashed):
1827         (testWebExtensionWindowObjectCleared):
1828         (testWebExtensionIsolatedWorld):
1829         (permissionRequestCallback):
1830         (didAssociateFormControlsCallback):
1831         (testWebExtensionFormControlsAssociated):
1832         (FormSubmissionTest::FormSubmissionTest):
1833         (FormSubmissionTest::testFormSubmissionResult):
1834         (testWebExtensionFormSubmissionSteps):
1835         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1836         (testNotInitialized):
1837         (testClearDatabase):
1838         (testPrivateBrowsing):
1839         (testGetFavicon):
1840         (testWebViewFavicon):
1841         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1842         (testFindControllerTextFound):
1843         (testFindControllerTextNotFound):
1844         (testFindControllerMatchCount):
1845         (testFindControllerMaxMatchCount):
1846         (testFindControllerNext):
1847         (testFindControllerPrevious):
1848         (testFindControllerCountedMatches):
1849         (testFindControllerOptions):
1850         (testFindControllerHide):
1851         (testFindControllerInstance):
1852         (testFindControllerGetters):
1853         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1854         (testNavigationPolicy):
1855         (testResponsePolicy):
1856         (testNewWindowPolicy):
1857         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1858         (testSecurityOriginBasicConstructor):
1859         (testSecurityOriginURIConstructor):
1860         (testSecurityOriginDefaultPort):
1861         (testSecurityOriginFileURI):
1862         (testOpaqueSecurityOrigin):
1863         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1864         (testWebKitSettings):
1865         (testWebKitSettingsNewWithSettings):
1866         (testWebKitSettingsUserAgent):
1867         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1868         (testWebViewNewWithUserContentManager):
1869         (isStyleSheetInjectedForURLAtPath):
1870         (isScriptInjectedForURLAtPath):
1871         (testUserContentManagerInjectedStyleSheet):
1872         (testUserContentManagerInjectedScript):
1873         (UserScriptMessageTest::scriptMessageReceived):
1874         (UserScriptMessageTest::waitUntilMessageReceived):
1875         (UserScriptMessageTest::runJavaScriptFinished):
1876         (testUserContentManagerScriptMessageReceived):
1877         (testUserContentManagerScriptMessageInWorldReceived):
1878         (testUserContentManagerScriptMessageFromDOMBindings):
1879         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1880         (testWebContextDefault):
1881         (testWebContextEphemeral):
1882         (testWebContextGetPlugins):
1883         (testWebContextURIScheme):
1884         (testWebContextSpellChecker):
1885         (testWebContextLanguages):
1886         (consoleMessageReceivedCallback):
1887         (testWebContextSecurityFileXHR):
1888         (ProxyTest::ProxyTest):
1889         (testWebContextProxySettings):
1890         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1891         (testWebViewWebContext):
1892         (testWebViewWebBackend):
1893         (testWebViewEphemeral):
1894         (testWebViewCustomCharset):
1895         (testWebViewSettings):
1896         (testWebViewRunJavaScript):
1897         (testWebViewCanShowMIMEType):
1898         (testWebViewSubmitForm):
1899         (testWebViewSave):
1900         (testWebViewPageVisibility):
1901         (testWebViewSnapshot):
1902         (testWebViewNotification):
1903         (testWebViewNotificationInitialPermissionAllowed):
1904         (testWebViewNotificationInitialPermissionDisallowed):
1905         (testWebViewIsPlayingAudio):
1906         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1907         (WebsiteDataTest::WebsiteDataTest):
1908         (WebsiteDataTest::remove):
1909         (WebsiteDataTest::clear):
1910         (testWebsiteDataConfiguration):
1911         (testWebsiteDataEphemeral):
1912         (testWebsiteDataCache):
1913         (testWebsiteDataStorage):
1914         (testWebsiteDataDatabases):
1915         (testWebsiteDataAppcache):
1916         (testWebsiteDataCookies):
1917         (testWebsiteDataDeviceIdHashSalt):
1918         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1919         (emitDocumentLoaded):
1920         (emitURIChanged):
1921         (sendRequestCallback):
1922         (contextMenuCallback):
1923         (consoleMessageSentCallback):
1924         (emitFormControlsAssociated):
1925         (formControlsAssociatedCallback):
1926         (emitFormSubmissionEvent):
1927         (willSubmitFormCallback):
1928         (windowObjectCleared):
1929         (methodCallCallback):
1930         (registerGResource):
1931         (webkit_web_extension_initialize_with_user_data):
1932         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1933         (checkLeaks):
1934         (WebProcessTest::create):
1935         (runTest):
1936         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1937         (AutocleanupsTest::testWebProcessAutocleanups):
1938         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1939         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1940         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1941         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1942         (WebKitDOMDOMWindowTest::testSignals):
1943         (WebKitDOMDOMWindowTest::testDispatchEvent):
1944         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1945         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1946         (WebKitDOMNodeFilterTest::testTreeWalker):
1947         (WebKitDOMNodeFilterTest::testNodeIterator):
1948         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1949         (WebKitDOMNodeTest::testHierarchyNavigation):
1950         (WebKitDOMNodeTest::testInsertion):
1951         (WebKitDOMNodeTest::testTagNamesNodeList):
1952         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1953         (WebKitDOMNodeTest::testDOMCache):
1954         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1955         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1956         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1957         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1958         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1959         (testUIProcessAutocleanups):
1960         (testWebProcessAutocleanups):
1961         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1962         (testContextMenuPopulateMenu):
1963         (testContextMenuDismissed):
1964         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1965         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1966         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1967         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1968         (testWebKitDOMDOMWindowSignals):
1969         (testWebKitDOMDOMWindowDispatchEvent):
1970         (testWebKitDOMDOMWindowGetComputedStyle):
1971         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1972         (testWebKitDOMNodeHierarchyNavigation):
1973         (testWebKitDOMNodeInsertion):
1974         (testWebKitDOMNodeTagNamesNodeList):
1975         (testWebKitDOMNodeTagNamesHTMLCollection):
1976         (testWebKitDOMObjectCache):
1977         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1978         (testWebKitDOMNodeFilterTreeWalker):
1979         (testWebKitDOMNodeFilterNodeIterator):
1980         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1981         (testWebKitDOMXPathNSResolverNative):
1982         (testWebKitDOMXPathNSResolverCustom):
1983         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1984         (testInspectorDefault):
1985         (testInspectorManualAttachDetach):
1986         (testInspectorCustomContainerDestroyed):
1987         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1988         (startTestServer):
1989         (testInspectorServerPageList):
1990         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1991         (OptionMenuTest::showOptionMenuCallback):
1992         (OptionMenuTest::menuCloseCallback):
1993         (OptionMenuTest::close):
1994         (OptionMenuTest::activateItem):
1995         (OptionMenuTest::selectItem):
1996         (testOptionMenuSimple):
1997         (testOptionMenuGroups):
1998         (testOptionMenuActivate):
1999         (testOptionMenuSelect):
2000         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2001         (testPrintOperationPrintSettings):
2002         (webViewPrintCallback):
2003         (testPrintOperationPrint):
2004         (testPrintCustomWidget):
2005         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2006         (checkAtspiAccessible):
2007         (testAtspiBasicHierarchy):
2008         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2009         (testWebKitCheckVersion):
2010         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2011         (testWebViewEditorCutCopyPasteNonEditable):
2012         (testWebViewEditorCutCopyPasteEditable):
2013         (testWebViewEditorSelectAllNonEditable):
2014         (testWebViewEditorSelectAllEditable):
2015         (loadContentsAndTryToCutSelection):
2016         (testWebViewEditorNonEditable):
2017         (testWebViewEditorEditable):
2018         (testWebViewEditorEditorStateTypingAttributes):
2019         (testWebViewEditorInsertImage):
2020         (testWebViewEditorCreateLink):
2021         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2022         (loadChangedCallback):
2023         (loadFailedCallback):
2024         (loadFailedWithTLSErrorsCallback):
2025         (LoadTrackingTest::LoadTrackingTest):
2026         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2027         (registerGResource):
2028         (removeNonEmptyDirectory):
2029         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2030         (Test::adoptView):
2031         (Test::~Test):
2032         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2033         (WebKitTestBus::getOrCreateConnection):
2034         (WebKitTestBus::createProxy):
2035         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2036         (WebKitTestServer::getWebSocketURIForPath const):
2037         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2038         (WebViewTest::initializeWebView):
2039         (WebViewTest::loadURI):
2040         (WebViewTest::loadHtml):
2041         (WebViewTest::loadPlainText):
2042         (WebViewTest::loadBytes):
2043         (WebViewTest::loadRequest):
2044         (WebViewTest::loadAlternateHTML):
2045         (WebViewTest::goBack):
2046         (WebViewTest::goForward):
2047         (WebViewTest::goToBackForwardListItem):
2048         (resourceGetDataCallback):
2049         (WebViewTest::mainResourceData):
2050         (WebViewTest::javascriptResultToCString):
2051         (WebViewTest::javascriptResultToNumber):
2052         (WebViewTest::javascriptResultToBoolean):
2053         (WebViewTest::javascriptResultIsNull):
2054         (WebViewTest::javascriptResultIsUndefined):
2055         (onSnapshotReady):
2056         (WebViewTest::runWebProcessTest):
2057         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2058         (WebViewTest::platformInitializeWebView):
2059         (WebViewTest::showInWindow):
2060         (WebViewTest::showInWindowAndWaitUntilMapped):
2061         (WebViewTest::mouseMoveTo):
2062         (WebViewTest::emitPopupMenuSignal):
2063         (WebViewTest::keyStroke):
2064         (WebViewTest::doMouseButtonEvent):
2065
2066 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2067
2068         [WPE] API tests can't run in flatpak environment
2069         https://bugs.webkit.org/show_bug.cgi?id=193242
2070
2071         Reviewed by Michael Catanzaro.
2072
2073         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2074         flatpakutils so that it knows which port it's dealing with.
2075         * glib/common.py: Remove build_dir globals so that subsequent
2076         calls actually take args into account.
2077         (library_build_path):
2078         (binary_build_path):
2079
2080 2019-01-08  Dean Jackson  <dino@apple.com>
2081
2082         Blob references for System Previews don't get a correct file extension
2083         https://bugs.webkit.org/show_bug.cgi?id=193268
2084         <rdar://problem/47133037>
2085
2086         Reviewed by Tim Horton.
2087
2088         New test that a Blob download of a USDZ file gets named correctly.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2092         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2093         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2094         (TEST):
2095         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2096
2097 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2098
2099         [WebAuthN] Support U2F HID Authenticators on macOS
2100         https://bugs.webkit.org/show_bug.cgi?id=191535
2101         <rdar://problem/47102027>
2102
2103         Reviewed by Brent Fulgham.
2104
2105         This patch:
2106         1) adds support for U2F mocking mechanism;
2107         2) updates tests to reflect U2fCommandConstructor changes.
2108
2109         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2113         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2114
2115 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2116
2117         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2118         https://bugs.webkit.org/show_bug.cgi?id=193229
2119         <rdar://problem/46717097>
2120
2121         Reviewed by Tim Horton.
2122
2123         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2124         prevents a drag from starting.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2127         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2128
2129         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2130
2131 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2132   
2133         Layout test will generate a perf metric file to results dir.
2134         https://bugs.webkit.org/show_bug.cgi?id=192030
2135         <rdar://problem/32779516>
2136
2137         Reviewed by Aakash Jain.
2138
2139         Layout test running time will be collected to a perf metric file.
2140         For now, instead of outputing running time of all tests (which is huge),
2141         we aggregate them by test directories which are at most two level deep. 
2142
2143         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2144         (Manager._end_test_run):
2145         (Manager._output_perf_metrics):
2146         (Manager._print_expectation_line_for_test):
2147         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2148         (add_test_perf_metric):
2149         (test_perf_metrics):
2150         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2151         (JSONGeneratorTest.test_test_timings_trie):
2152         (JSONGeneratorTest):
2153         (JSONGeneratorTest.test_test_perf_metrics):
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2155         (RebaselineTest.test_reset_results):
2156         (RebaselineTest.test_missing_results):
2157         (RebaselineTest.test_new_baseline):
2158
2159 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2160
2161         [WPE][GTK] Add php-json to install-dependencies
2162         https://bugs.webkit.org/show_bug.cgi?id=193233
2163
2164         Reviewed by Michael Catanzaro.
2165
2166         * gtk/install-dependencies:
2167         * wpe/install-dependencies:
2168
2169 2019-01-08  Chris Dumez  <cdumez@apple.com>
2170
2171         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2172         https://bugs.webkit.org/show_bug.cgi?id=193224
2173         <rdar://problem/47097726>
2174
2175         Reviewed by Alex Christensen.
2176
2177         Add API test coverage.
2178
2179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2180
2181 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2182
2183         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2184         <https://webkit.org/b/193222>
2185         <rdar://problem/46862309>
2186
2187         Reviewed by Joseph Pecoraro.
2188
2189         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2190         (WTR::executeCallback): Fix camel case of variable name.
2191         (WTR::EventSendingController::callAfterScrollingCompletes): If
2192         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2193         false, make sure to release the ScrollCompletionCallbackData
2194         object.  This fixes the leak.
2195
2196 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2197
2198         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2199         https://bugs.webkit.org/show_bug.cgi?id=193044
2200
2201         Reviewed by Daniel Bates.
2202
2203         WinCairo EWS bots are using Windows Perl. Binary files should be
2204         opened as binary mode.
2205
2206         * Scripts/svn-apply:
2207         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2208
2209 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2210
2211         [CMake] Add ENABLE_CSS_TYPED_OM option
2212         https://bugs.webkit.org/show_bug.cgi?id=193216
2213
2214         Reviewed by Michael Catanzaro.
2215
2216         * Scripts/webkitperl/FeatureList.pm:
2217
2218 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2219
2220         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2221         <https://webkit.org/b/193056>
2222
2223         Reviewed by Alex Christensen.
2224
2225         * Scripts/webkitpy/style/checker.py:
2226         - Ignore use of new runtime/retainptr check in
2227           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2228           contains tests to ensure RetainPtr<NSObject *> is compatible
2229           with RetainPtr<NSObject>.
2230
2231         * Scripts/webkitpy/style/checkers/cpp.py:
2232         (check_language):
2233         (CppChecker):
2234         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2235           was used instead of a single regex so that angle brackets
2236           could be matched up when checking the type contained within
2237           the RetainPtr<> type.
2238
2239         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2240         (CppStyleTest):
2241         - Add unit test for new runtime/retainptr check.
2242
2243         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2244         * TestWebKitAPI/EditingTestHarness.h:
2245         - Remove '*' from RetainPtr<> type.
2246
2247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2248         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2249           regressed in r201938.
2250
2251         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2252         (TestWebKitAPI::TEST):
2253         - Update tests to match RetainPtr.mm tests (except for the
2254           `*SimilarNSType` tests since there is no CF equivalent of
2255           RetainPtr<NSString> and RetainPtr<NSString *>).
2256
2257         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2258         (TestWebKitAPI::TEST):
2259         - Update tests to:
2260           - Not conflict by name with equivalent CF tests in
2261             RetainPtr.cpp.
2262           - Add test cases for RetainPtr<NSObject>,
2263             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2264           - Add `*SimilarNSType` tests for converting between
2265             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2266           - Change `0` to `nil` as appropriate.
2267           - Re-alphabetize the tests by name.
2268           - Add Optional<RetainPtr<>> tests.
2269           - Add retainPtr() tests.
2270
2271         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2272         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2273         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2274         (TEST):
2275         - Remove '*' from RetainPtr<> type.
2276
2277         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2278         (TEST(WebKit, JITEnabled)):
2279         - Add missing WTFMove().  Apparently a temporary was being
2280           created before in the argument list due to mismatched
2281           RetainPtr<> types.
2282
2283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2284         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2285         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2286         (TestWebKitAPI::TEST):
2287         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2288         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2289         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2290         (WTR::resourcesDirectoryURL):
2291         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2292         (WTR::InjectedBundle::platformInitialize):
2293         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2294         - Remove '*' from RetainPtr<> type.
2295
2296 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2297
2298         A MediaTime timescale must never be zero
2299         https://bugs.webkit.org/show_bug.cgi?id=193156
2300         <rdar://problem/32504501>
2301
2302         Reviewed by Jer Noble.
2303
2304         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2305         (TestWebKitAPI::TEST): Add tests for zero timescale.
2306
2307 2019-01-07  Youenn Fablet  <youenn@apple.com>
2308
2309         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2310         https://bugs.webkit.org/show_bug.cgi?id=193175
2311
2312         Reviewed by Chris Dumez.
2313
2314         Updated API test as we bumped the SW schema to version 4.
2315
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2318         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2319         (TEST):
2320
2321 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2322
2323         [Win][Clang] Fix compilation warnings of MiniBrowser
2324         https://bugs.webkit.org/show_bug.cgi?id=193029
2325
2326         Reviewed by Ross Kirsling.
2327
2328         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2329         and m_URLBarFont. Reorder member variables to fix -Wreorder
2330         warning.
2331         * MiniBrowser/win/PageLoadTestClient.cpp:
2332         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2333         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2334         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2335         m_currentURLIndex.
2336         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2337         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2338         navigationClient with '{ }' to fix the missing field warning.
2339         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2340         (initDocStruct): Changed the argument type docname to const.
2341
2342 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2343
2344         [WebAuthN] Import U2F command/response converters from Chromium
2345         https://bugs.webkit.org/show_bug.cgi?id=193150
2346         <rdar://problem/47054028>
2347
2348         Reviewed by Brent Fulgham.
2349
2350         Adds API tests.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2354         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2355         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2356         (TestWebKitAPI::getTestAttestationObjectBytes):
2357         (TestWebKitAPI::getTestSignResponse):
2358         (TestWebKitAPI::getTestU2fRegisterResponse):
2359         (TestWebKitAPI::TEST):
2360         (TestWebKitAPI::convertToVector): Deleted.
2361         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2362         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2363         (TestWebKitAPI::constructMakeCredentialRequest):
2364         (TestWebKitAPI::constructGetAssertionRequest):
2365         (TestWebKitAPI::TEST):
2366
2367 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2368
2369         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2370         https://bugs.webkit.org/show_bug.cgi?id=193136
2371
2372         Reviewed by Michael Catanzaro.
2373
2374         * gtk/install-dependencies:
2375         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2376         they are needed by update-webkitgtk-libs.
2377
2378 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2379
2380         Unreviewed follow-up fix to r239650
2381         https://bugs.webkit.org/show_bug.cgi?id=193140
2382         <rdar://problem/47063037>
2383
2384         Typecast patch_id to string.
2385
2386         * BuildSlaveSupport/ews-build/steps.py:
2387         (ValidatePatch._is_patch_obsolete):
2388
2389 2019-01-04  Daniel Bates  <dabates@apple.com>
2390
2391         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2392         https://bugs.webkit.org/show_bug.cgi?id=193024
2393
2394         Reviewed by Jer Noble.
2395
2396         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2397         for the bitmask type WebEventFlags as an example.
2398
2399         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2400         that can be used to register summary and synthetic child formatters for a bitmask type.
2401         For example, consider the following enum and bitmask typedefs:
2402
2403         typedef enum {
2404             A = 1 << 0,
2405             B = 1 << 1,
2406             C = 1 << 2,
2407         } SpecialFlagValues;
2408         typedef unsigned SpecialFlags;
2409
2410         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2411         __lldb_init_module():
2412
2413             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2414                     1 << 0: "A",
2415                     1 << 1: "B",
2416                     1 << 2: "C",
2417             })
2418
2419         * lldb/lldb_webkit.py:
2420         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2421         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2422         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2423         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2424         A convenience function to dynamically creaste a synthetic formatter class and summary
2425         string function for the specified bitmask type and enumerator value to name map. This
2426         function register the dynamically created class and function with LLDB.
2427
2428         (__lldb_init_module):
2429         (FlagEnumerationProvider):
2430         (FlagEnumerationProvider._enumerator_value_to_name_map):
2431         (FlagEnumerationProvider._bitmask):
2432         (FlagEnumerationProvider._update):
2433         (FlagEnumerationProvider.has_children):
2434         (FlagEnumerationProvider.num_children):
2435         (FlagEnumerationProvider.get_child_index):
2436         (FlagEnumerationProvider.get_child_at_index):
2437         (FlagEnumerationProvider.update):
2438         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2439
2440         (WTFOptionSetProvider):
2441         (WTFOptionSetProvider._enumerator_value_to_name_map):
2442         (WTFOptionSetProvider._bitmask):
2443         (WTFOptionSetProvider._update):
2444         Write in terms of the base class.
2445
2446         (RawBitmaskProviderBase):
2447         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2448         (RawBitmaskProviderBase._bitmask):
2449         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2450         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2451         {
2452             1 << 0: "A",
2453             1 << 1: "B",
2454             1 << 2: "C",
2455         }
2456         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2457         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2458
2459         (WTFOptionSetProvider.has_children): Deleted.
2460         (WTFOptionSetProvider.num_children): Deleted.
2461         (WTFOptionSetProvider.get_child_index): Deleted.
2462         (WTFOptionSetProvider.get_child_at_index): Deleted.
2463         (WTFOptionSetProvider.update): Deleted.
2464
2465 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2466
2467         [ews-build] Add build step to validate the patch before processing it
2468         https://bugs.webkit.org/show_bug.cgi?id=193140
2469
2470         Reviewed by Lucas Forschler.
2471
2472         * BuildSlaveSupport/ews-build/factories.py:
2473         (Factory.__init__): Added ValidatePatch step.
2474         * BuildSlaveSupport/ews-build/steps.py:
2475         (ValidatePatch):
2476         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2477         (ValidatePatch.get_patch_json): Get patch json data.
2478         (ValidatePatch.get_bug_json): Get bug json data.
2479         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2480         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2481         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2482         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2483         (ValidatePatch.skip_build): Skip the build.
2484         (ValidatePatch.start):
2485
2486 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2487
2488         Progress towards fixing Mac CMake build
2489         https://bugs.webkit.org/show_bug.cgi?id=193105
2490
2491         Reviewed by Don Olmstead.
2492
2493         * TestWebKitAPI/PlatformMac.cmake:
2494
2495 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2496
2497         Fix API test after r239631
2498         https://bugs.webkit.org/show_bug.cgi?id=193118
2499
2500         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2501         (TestWebKitAPI::TEST):
2502         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2503         Do the same thing via the API to fix the test.
2504
2505 2019-01-04  Jer Noble  <jer.noble@apple.com>
2506
2507         [WebKitLegacy] Media playback pauses on scroll
2508         https://bugs.webkit.org/show_bug.cgi?id=192829
2509
2510         Reviewed by Eric Carlson.
2511
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2514         (TestWebKitAPI::TEST):
2515         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2516         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2517         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2518         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2519         (TestWebKitAPI::TEST):
2520
2521 2019-01-04  Chris Dumez  <cdumez@apple.com>
2522
2523         Add support for toggling device orientation API support per site
2524         https://bugs.webkit.org/show_bug.cgi?id=193143
2525         <rdar://problem/46605724>
2526
2527         Reviewed by Alex Christensen.
2528
2529         Add API test coverage.
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2532         (-[DataMappingSchemeHandler setTaskHandler:]):
2533         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2534         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2535         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2536         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2537
2538 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2539
2540         [ews-build] use svn-apply script to apply the patches
2541         https://bugs.webkit.org/show_bug.cgi?id=193138
2542
2543         Reviewed by Lucas Forschler.
2544
2545         * BuildSlaveSupport/ews-build/factories.py:
2546         (Factory.__init__): Add the ApplyPatch step.
2547         * BuildSlaveSupport/ews-build/steps.py:
2548         (CheckOutSource): Added step name.
2549         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2550         (ApplyPatch): Build step to apply patch using svn-apply script.
2551         (UnApplyPatchIfRequired):
2552         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2553
2554 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2555
2556         Deprecate WKContextCreate
2557         https://bugs.webkit.org/show_bug.cgi?id=193118
2558
2559         Reviewed by Brady Eidson.
2560
2561         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2562         (WebKitBrowserWindow::WebKitBrowserWindow):
2563         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2564         (TestWebKitAPI::TEST):
2565         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2566         (TestWebKitAPI::TEST):
2567         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2568         (TestWebKitAPI::TEST):
2569         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2570         (TestWebKitAPI::TEST):
2571         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2574         (TestWebKitAPI::TEST):
2575         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2576         (TestWebKitAPI::TEST):
2577         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2578         (TestWebKitAPI::TEST):
2579         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2580         (TestWebKitAPI::TEST):
2581         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2582         (TestWebKitAPI::TEST):
2583         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2584         (TestWebKitAPI::TEST):
2585         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2586         (TestWebKitAPI::TEST):
2587         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2588         (TestWebKitAPI::TEST):
2589         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2590         (TestWebKitAPI::TEST):
2591         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2594         (TestWebKitAPI::TEST):
2595         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2596         (TestWebKitAPI::TEST):
2597         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2598         (TestWebKitAPI::TEST):
2599         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2600         (TestWebKitAPI::loadAlternateHTMLString):
2601         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2602         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2603         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2604         (TestWebKitAPI::buildAndPerformTest):
2605         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2606         (TestWebKitAPI::TEST):
2607         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2608         (TestWebKitAPI::TEST):
2609         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2610         (TestWebKitAPI::TEST):
2611         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2612         (TestWebKitAPI::TEST):
2613         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2614         (TestWebKitAPI::TEST):
2615         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2616         (TestWebKitAPI::TEST):
2617         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2618         (TestWebKitAPI::TEST):
2619         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2620         (TestWebKitAPI::TEST):
2621         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2622         (TestWebKitAPI::TEST):
2623         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2624         (TestWebKitAPI::TEST):
2625         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2626         (TestWebKitAPI::TEST):
2627         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2628         (TestWebKitAPI::TEST):
2629         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2630         (TestWebKitAPI::TEST):
2631         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2632         (TestWebKitAPI::TEST):
2633         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2634         (TestWebKitAPI::TEST):
2635         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2636         (TestWebKitAPI::TEST):
2637         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2638         (TestWebKitAPI::TEST):
2639         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2640         (TestWebKitAPI::TEST):
2641         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2642         (TestWebKitAPI::TEST):
2643         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2644         (TestWebKitAPI::TEST):
2645         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2646         (TestWebKitAPI::TEST):
2647         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2648         (TestWebKitAPI::TEST):
2649         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2650         (TestWebKitAPI::TEST):
2651         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2652         (TestWebKitAPI::TEST):
2653         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2654         (TestWebKitAPI::TEST):
2655         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2656         (TestWebKitAPI::TEST):
2657         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2658         (WebKit2_CommandBackForwardTestWKView::SetUp):
2659         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2660         (TestWebKitAPI::TEST):
2661         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2662         (TestWebKitAPI::TEST):
2663         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2666         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2667
2668 2019-01-03  Matt Rajca  <mrajca@apple.com>
2669
2670         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2671         https://bugs.webkit.org/show_bug.cgi?id=193128
2672         rdar://34554231
2673
2674         Reviewed by Jer Noble.
2675
2676         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2677         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2678         event along with a flag that indicates whether or not autoplay was actually prevented.
2679
2680         Tests: existing API tests were updated to reflect the new names. New API tests
2681         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2682
2683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2685         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2686         (TEST):
2687         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2688         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2689
2690 2019-01-04  Chris Dumez  <cdumez@apple.com>
2691
2692         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2693         https://bugs.webkit.org/show_bug.cgi?id=193120
2694
2695         Reviewed by Alex Christensen.
2696
2697         Add API test coverage.
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2700
2701 2019-01-04  Chris Dumez  <cdumez@apple.com>
2702
2703         Crash under WebProcessPool::addSuspendedPage()
2704         https://bugs.webkit.org/show_bug.cgi?id=193110
2705
2706         Reviewed by Youenn Fablet.
2707
2708         Add API test coverage.
2709
2710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2711
2712 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2713
2714         [ews-build] Check patch relevance before applying the patch
2715         https://bugs.webkit.org/show_bug.cgi?id=193102
2716
2717         Reviewed by Lucas Forschler.
2718
2719         * BuildSlaveSupport/ews-build/factories.py:
2720         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2721
2722 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2723
2724         [ews-build] Check patch relevance step should print patch id
2725         https://bugs.webkit.org/show_bug.cgi?id=193137
2726
2727         Reviewed by Lucas Forschler.
2728
2729         * BuildSlaveSupport/ews-build/steps.py:
2730         (CheckPatchRelevance.start): Update the status to include patch id.
2731
2732 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2733
2734         webkitpy: Increase simulator teardown timeout
2735         https://bugs.webkit.org/show_bug.cgi?id=193141
2736         <rdar://problem/46174217>
2737
2738         Rubber-stamped by Aakash Jain.
2739
2740         * Scripts/webkitpy/xcode/simulated_device.py:
2741         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2742
2743 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2744
2745         test262-runner misbehaves when test file YAML has a trailing space
2746         https://bugs.webkit.org/show_bug.cgi?id=193053
2747
2748         Reviewed by Yusuke Suzuki.
2749
2750         * Scripts/test262/Runner.pm:
2751         (parseData):
2752         Accept trailing space when parsing a test file's YAML block.
2753
2754 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2755
2756         UserMedia test should use WKPageNavigationClient
2757         https://bugs.webkit.org/show_bug.cgi?id=192913
2758
2759         Reviewed by Youenn Fablet.
2760
2761         The test currently uses the deprecated WKPageLoaderClient. It should use
2762         WKPageNavigationClient instead, which provides the same callback under a similar name.
2763
2764         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2765         (TestWebKitAPI::TEST):
2766
2767 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2768
2769         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2770         https://bugs.webkit.org/show_bug.cgi?id=192944
2771
2772         Reviewed by Tim Horton.
2773
2774         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2775         (TestWebKitAPI::TEST):
2776
2777 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2778
2779         Add support for using the current text selection as the find string on iOS
2780         https://bugs.webkit.org/show_bug.cgi?id=193034
2781         <rdar://problem/45138739>
2782
2783         Reviewed by Tim Horton.
2784
2785         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2786         _setStringForFind) works as expected.
2787
2788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2789         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2790
2791 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2792
2793         [ews-build] Use git on OpenSource EWS bots
2794         https://bugs.webkit.org/show_bug.cgi?id=193092
2795
2796         Reviewed by Lucas Forschler.
2797
2798         * BuildSlaveSupport/ews-build/steps.py:
2799         (CheckOutSource): Use git instead of svn.
2800         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2801
2802 2019-01-02  Daniel Bates  <dabates@apple.com>
2803
2804         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2805         https://bugs.webkit.org/show_bug.cgi?id=193023
2806
2807         Reviewed by Simon Fraser.
2808
2809         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2810         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2811         enumerator values. We should just remove this code.
2812
2813         * lldb/lldb_webkit.py:
2814         (WTFOptionSetProvider.has_children):
2815         (WTFOptionSetProvider.num_children):
2816         (WTFOptionSetProvider.get_child_index):
2817         (WTFOptionSetProvider.get_child_at_index):
2818
2819 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2820
2821         .ycm_extra_conf.py should handle XXXInlines.h
2822         https://bugs.webkit.org/show_bug.cgi?id=193055
2823
2824         Reviewed by Carlos Garcia Campos.
2825
2826         compile_commands.json database only records flags and options for cpp source files.
2827         So, when we open headers, this database does not have any information for that.
2828         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2829         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2830         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2831         we attempt to find XXX.cpp and use the configuration if it exists.
2832
2833         * gtk/ycm_extra_conf.py:
2834         (getImplementationFilename):
2835         (FlagsForFile):
2836
2837 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2838
2839         Unreviewed. Support PHP 7.3 in Debian.
2840
2841         Add 7.3 to the list of php versions supported in Debian.
2842
2843         * Scripts/webkitpy/port/base.py:
2844         (Port._debian_php_version):
2845
2846 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2847
2848         Resurrect Mac CMake build
2849         https://bugs.webkit.org/show_bug.cgi?id=192658
2850
2851         Reviewed by Yusuke Suzuki.
2852
2853         * DumpRenderTree/PlatformMac.cmake:
2854         * MiniBrowser/mac/CMakeLists.txt:
2855         * TestWebKitAPI/PlatformMac.cmake:
2856
2857 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2858
2859         [Tools] Remove references to Bison and Flex
2860         https://bugs.webkit.org/show_bug.cgi?id=193033
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         The Bison and Flex tools are not needed anymore since r209883.
2865
2866         * CygwinDownloader/cygwin-downloader.py:
2867         * EWSTools/ubuntu-ews-packages:
2868         * Scripts/filter-build-webkit:
2869         (shouldIgnoreLine):
2870         * gtk/install-dependencies:
2871         * wpe/install-dependencies:
2872
2873 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2874
2875         WebDriver: warn about non existing tests when parsing expectations
2876         https://bugs.webkit.org/show_bug.cgi?id=192979
2877
2878         Reviewed by Michael Catanzaro.
2879
2880         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2881         renamed.
2882
2883         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2884         (WebDriverTestRunner.__init__):
2885
2886 2018-12-21  Chris Dumez  <cdumez@apple.com>
2887
2888         navigator.userAgent in service workers does not reflect customUserAgent set by client
2889         https://bugs.webkit.org/show_bug.cgi?id=192951
2890
2891         Reviewed by Youenn Fablet.
2892
2893         Extend API test coverage.
2894
2895         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2896         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2897         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2898         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2899         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2900
2901 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2902
2903         [WebAuthN] userPresence should always be true
2904         https://bugs.webkit.org/show_bug.cgi?id=192835
2905         <rdar://problem/46538788>
2906
2907         Reviewed by Brent Fulgham.
2908
2909         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2910         (TestWebKitAPI::TEST):
2911
2912 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2913
2914         Add support to run-benchmark to use non-default copies of the browser apps
2915         https://bugs.webkit.org/show_bug.cgi?id=192905
2916         rdar://problem/46845840
2917
2918         Reviewed by Dewei Zhu.
2919         
2920         Add support for a --browser-path argument to run-benchmark, which allows you to use
2921         a custom app bundle for a given browser (only implemented for Safari at present).
2922
2923         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2924         (BenchmarkRunner.__init__):
2925         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2926         (BrowserDriver.__init__):
2927         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2928         (BrowserDriverFactory.create):
2929         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2930         (OSXBrowserDriver._launch_process):
2931         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2932         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2933         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2934         (OSXChromeCanaryDriver.launch_url):
2935         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2936         (OSXFirefoxNightlyDriver.launch_url):
2937         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2938         (OSXSafariDriver.__init__):
2939         (OSXSafariDriver.launch_url):
2940         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2941         (parse_args):
2942         (run_benchmark_plan):
2943         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2944         (WebServerBenchmarkRunner.__init__):
2945         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2946         (FakeBenchmarkRunner.__init__):
2947
2948 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2949
2950         [WebAuthN] Import an APDU coder from Chromium
2951         https://bugs.webkit.org/show_bug.cgi?id=192949
2952         <rdar://problem/46879933>
2953
2954         Reviewed by Brent Fulgham.
2955
2956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2957         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2958         (TestWebKitAPI::TEST):
2959
2960 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2961
2962         Setting the file wrapper and content type of an attachment to a PDF should update its image
2963         https://bugs.webkit.org/show_bug.cgi?id=192984
2964         <rdar://problem/46798028>
2965
2966         Reviewed by Tim Horton.
2967
2968         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2969         PDF data correctly updates the image element.
2970
2971         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2972
2973 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2974
2975         Add JSCOnly to bot dashboard
2976         https://bugs.webkit.org/show_bug.cgi?id=192964
2977
2978         Reviewed by Alexey Proskuryakov.
2979
2980         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2981         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2982         useful if they were not so secret, so add them.
2983
2984         There appear to be no build-only bots, so the first column is blank. And of course there are
2985         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2986         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2987         and there's plenty of room in the final column for all the bots.
2988
2989         I had a hard time picking a logo to use, because the JavaScript language does not have an
2990         official logo. But I believe I've found one that will be satisfactory.
2991
2992         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2997         (BubbleQueueServer):
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3000         (WebKitBuildbot):
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3002         (table.queue-grid tr.platform.linux-jsconly img.logo):
3003
3004 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3005
3006         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3007         https://bugs.webkit.org/show_bug.cgi?id=192821
3008
3009         Reviewed by Chris Dumez.
3010
3011         * DumpRenderTree/mac/DumpRenderTree.mm:
3012         (createWebViewAndOffscreenWindow):
3013         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3014
3015 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3016
3017         [Win][Clang] Fix compilation warnings of DumpRenderTree
3018         https://bugs.webkit.org/show_bug.cgi?id=192924
3019
3020         Reviewed by Alex Christensen.
3021
3022         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3023         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3024         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3025         * DumpRenderTree/win/DumpRenderTree.cpp:
3026         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3027         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3028         object to the argument of setDefaultTextEncodingName instead of a
3029         const string literal.
3030         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3031         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3032         (setCacheFolder): Deleted.
3033         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3034         * DumpRenderTree/win/EditingDelegate.cpp:
3035         (dump): Use %d for int.
3036         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3037         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3038         (BSTRFromString): Deleted unused function.
3039         * DumpRenderTree/win/TestRunnerWin.cpp:
3040         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3041         the arguemnt of setQuota instead of const string literal.
3042         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3043         (jsStringRefToWString): Deleted unused function.
3044
3045 2018-12-20  Chris Dumez  <cdumez@apple.com>
3046
3047         Add API test coverage for customUserAgent client setting and service workers
3048         https://bugs.webkit.org/show_bug.cgi?id=192952
3049
3050         Reviewed by Alex Christensen.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3053         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3054         (-[SWSchemes webView:startURLSchemeTask:]):
3055         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3056         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3057
3058 2018-12-20  Chris Dumez  <cdumez@apple.com>
3059
3060         Use Optional::hasValue() instead of Optional::has_value()
3061         https://bugs.webkit.org/show_bug.cgi?id=192948
3062
3063         Reviewed by Tim Horton.
3064
3065         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3066         (TestWebKitAPI::TEST):
3067         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3068         (TestWebKitAPI::TEST):
3069         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3070         (TestWebKitAPI::TEST_F):
3071
3072 2018-12-20  Chris Dumez  <cdumez@apple.com>
3073
3074         Add style script rule to check for uses of std::optional<>
3075         https://bugs.webkit.org/show_bug.cgi?id=192931
3076
3077         Reviewed by Tim Horton.
3078
3079         * Scripts/webkitpy/style/checkers/cpp.py:
3080         (check_wtf_optional):
3081         (check_style):
3082
3083 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3084
3085         [WebAuthN] Add a runtime flag for local authenticator
3086         https://bugs.webkit.org/show_bug.cgi?id=192792
3087         <rdar://problem/46798738>
3088
3089         Reviewed by Brent Fulgham.
3090
3091         * DumpRenderTree/TestOptions.cpp:
3092         (TestOptions::TestOptions):
3093         * DumpRenderTree/TestOptions.h:
3094         * DumpRenderTree/mac/DumpRenderTree.mm:
3095         (enableExperimentalFeatures):
3096         (setWebPreferencesForTestOptions):
3097         * WebKitTestRunner/TestController.cpp:
3098         (WTR::TestController::resetPreferencesToConsistentValues):
3099         (WTR::updateTestOptionsFromTestHeader):
3100         * WebKitTestRunner/TestOptions.h:
3101         (WTR::TestOptions::hasSameInitializationOptions const):
3102
3103 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3104
3105         webkitpy: Autoinstall package URLs have changed
3106         https://bugs.webkit.org/show_bug.cgi?id=192909
3107         <rdar://problem/46860359>
3108
3109         Rubber-stamped by Alexey Proskuryakov.
3110
3111         PyPi urls have been moved around, we need to update our auto-installed packages.
3112
3113         We should check for Selenium before asking PyPi for the latest version.
3114
3115         * Scripts/webkitpy/thirdparty/__init__.py:
3116         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3117         (AutoinstallImportHook._install_keyring): Ditto.
3118         (AutoinstallImportHook._install_pep8): Ditto.
3119         (AutoinstallImportHook._install_mozlog): Ditto.
3120         (AutoinstallImportHook._install_mozprocess): Ditto.
3121         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3122         (AutoinstallImportHook._install_pytest): Ditto.
3123         (AutoinstallImportHook._install_pylint): Ditto.
3124         (AutoinstallImportHook._install_buildbot): Ditto.
3125         (AutoinstallImportHook._install_coverage): Ditto.
3126         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3127         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3128         for new Selenium if the installed version isn't sufficient.
3129         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3130
3131 2018-12-20  Chris Dumez  <cdumez@apple.com>
3132
3133         Use Optional::valueOr() instead of Optional::value_or()
3134         https://bugs.webkit.org/show_bug.cgi?id=192933
3135
3136         Reviewed by Geoffrey Garen.
3137
3138         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3139         (TestWebKitAPI::checkURL):
3140         (TestWebKitAPI::checkRelativeURL):
3141         (TestWebKitAPI::checkURLDifferences):
3142         (TestWebKitAPI::checkRelativeURLDifferences):
3143         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3144         (TestWebKitAPI::checkURL):
3145
3146 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3147
3148         Unreviewed, rolling out r239417.
3149
3150         Introduced two API test failures on macOS.
3151
3152         Reverted changeset:
3153
3154         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3155         occlusion changes"
3156         https://bugs.webkit.org/show_bug.cgi?id=192821
3157         https://trac.webkit.org/changeset/239417
3158
3159 2018-12-20  Devin Rousso  <drousso@apple.com>
3160
3161         Web Inspector: UIString should take an optional key and description to aid localization
3162         https://bugs.webkit.org/show_bug.cgi?id=153962
3163         <rdar://problem/24542505>
3164
3165         Reviewed by Brian Burg.
3166
3167         * Scripts/extract-localizable-js-strings:
3168
3169 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3170
3171         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3172         https://bugs.webkit.org/show_bug.cgi?id=192923
3173         <rdar://problem/46859068>
3174
3175         Reviewed by Wenson Hsieh.
3176
3177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3178         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3179         Add a test ensuring that both parented and unparented WKWebViews can
3180         retrieve main resource data when loading a PDF.
3181
3182 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3183
3184         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3185         https://bugs.webkit.org/show_bug.cgi?id=192852
3186
3187         Reviewed by Michael Catanzaro.
3188
3189         EmojiOne font was replaced by Noto Color Emoji.
3190
3191         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3192         * gtk/jhbuild.modules:
3193         * wpe/jhbuild.modules:
3194
3195 2018-12-19  Chris Dumez  <cdumez@apple.com>
3196
3197         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3198         https://bugs.webkit.org/show_bug.cgi?id=192728
3199         <rdar://problem/46746779>
3200
3201         Reviewed by Geoff Garen.
3202
3203         * DumpRenderTree/*:
3204         * MiniBrowser/*:
3205         * TestRunnerShared/*:
3206         * TestWebKitAPI/*:
3207         * WebGPUAPIStructure/*:
3208         * WebKitTestRunner/*:
3209
3210 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3211
3212         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3213         https://bugs.webkit.org/show_bug.cgi?id=192821
3214
3215         Reviewed by Chris Dumez.
3216
3217         * DumpRenderTree/mac/DumpRenderTree.mm:
3218         (createWebViewAndOffscreenWindow):
3219
3220 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3221
3222         Navigations away from the SafeBrowsing interstitial show a flash of old content
3223         https://bugs.webkit.org/show_bug.cgi?id=192676
3224
3225         Reviewed by Chris Dumez.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3228         (safeBrowsingView):
3229         (TEST):
3230         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3231
3232 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3233
3234         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3235         https://bugs.webkit.org/show_bug.cgi?id=192855
3236
3237         Reviewed by Michael Catanzaro.
3238
3239         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3240         (WTR::TestController::notifyDone): Use the WPE implementation.
3241         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3242         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3243         (WTR::TestController::platformRunUntil): Honor the condition flag.
3244
3245 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3246
3247         Allow clients to set the navigator platform
3248         https://bugs.webkit.org/show_bug.cgi?id=192735
3249
3250         Reviewed by Tim Horton.
3251
3252         Add a test for setting a custom navigator platform.
3253
3254         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3255         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3256         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3257
3258 2018-12-19  Truitt Savell  <tsavell@apple.com>
3259
3260         Unreviewed, rolling out r239358.
3261
3262         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3263         crash on Debug bots
3264
3265         Reverted changeset:
3266
3267         "Clean up IndexedDB files between tests"
3268         https://bugs.webkit.org/show_bug.cgi?id=192796
3269         https://trac.webkit.org/changeset/239358
3270
3271 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3272
3273         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3274         https://bugs.webkit.org/show_bug.cgi?id=192842
3275         <rdar://problem/46823586>
3276
3277         Reviewed by Tim Horton.
3278
3279         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3280         item provider when dragging a rich text selection.
3281
3282         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3283
3284 2018-12-18  David Quesada  <david_quesada@apple.com>
3285
3286         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3287         https://bugs.webkit.org/show_bug.cgi?id=192810
3288         <rdar://problem/46812536>
3289
3290         Reviewed by Alex Christensen.
3291
3292         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3293         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3294             After releasing our reference to the web view, wait until the next turn of the runloop
3295             before checking that the originatingWebView has been zeroed, since the web view might
3296             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3297             testing general memory management of WKWebViews, only that _WKDownload does not retain
3298             its web view via the 'originatingWebView' property.
3299
3300 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3301
3302         Clean up IndexedDB files between tests
3303         https://bugs.webkit.org/show_bug.cgi?id=192796
3304
3305         Reviewed by Geoffrey Garen.
3306
3307         * DumpRenderTree/mac/DumpRenderTree.mm:
3308         (runTest):
3309         * WebKitTestRunner/TestController.cpp:
3310         (WTR::TestController::resetStateToConsistentValues):
3311         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3312         (WTR::RemoveAllIndexedDatabasesCallback):
3313         (WTR::TestController::ClearIndexedDatabases):
3314         * WebKitTestRunner/TestController.h:
3315
3316 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3317
3318         Fix API test introduced in r239339 on iOS.
3319         https://bugs.webkit.org/show_bug.cgi?id=192675
3320
3321         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3322         (TEST):
3323         The iOS implementation of the safe browsing warning is a little different.
3324         It does some element creation when it is added to the window so it knows how big it is.
3325         To test these elements, we need to simulate adding it to the window.
3326         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3327
3328 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3329
3330         webkitpy: Ignore device type for test when using --force
3331         https://bugs.webkit.org/show_bug.cgi?id=192786
3332         <rdar://problem/46794894>
3333
3334         Reviewed by Daniel Bates.
3335
3336         It is sometimes the case that a contributor will wish to run a test on a specific device,
3337         despite expectations which indicate a test should not be run on that device.
3338
3339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3340         (parse_args):
3341         * Scripts/webkitpy/port/device_port.py:
3342         (DevicePort.default_child_processes): Strip device type information when using --force.
3343         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3344
3345 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3346
3347         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3348         https://bugs.webkit.org/show_bug.cgi?id=192675
3349
3350         Reviewed by Geoffrey Garen.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3353         (goBack):
3354         (TEST):
3355         (visitUnsafeSite):
3356         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3357         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3358
3359 2018-12-18  Chris Dumez  <cdumez@apple.com>
3360
3361         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3362         https://bugs.webkit.org/show_bug.cgi?id=192772
3363
3364         Reviewed by Antti Koivisto.
3365
3366         Add API test coverage.
3367
3368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3369
3370 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3371
3372         Unreviewed, JHBuild GTK build fix attempt
3373
3374         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3375         There's no ninja module either, it should be provided by the
3376         host system.
3377
3378 2018-12-17  Chris Dumez  <cdumez@apple.com>
3379
3380         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3381         https://bugs.webkit.org/show_bug.cgi?id=192789
3382         <rdar://problem/46755277>
3383
3384         Reviewed by Alex Christensen.
3385
3386         Add API test coverage.
3387
3388         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3389         (TEST):
3390
3391 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3392
3393         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3394         https://bugs.webkit.org/show_bug.cgi?id=192780
3395         rdar://problem/43394387
3396
3397         Reviewed by Tim Horton.
3398
3399         No need to set "AppleFontSmoothing" defaults for WK2.
3400
3401         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3402         (WTR::InjectedBundle::platformInitialize):
3403
3404 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3405
3406         webkitpy: Handle case where stdout and stderr don't accept unicode
3407         https://bugs.webkit.org/show_bug.cgi?id=192775
3408         <rdar://problem/46497303>
3409
3410         Reviewed by Stephanie Lewis.
3411
3412         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3413         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3414         characters with '?'.
3415         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3416         (RegularTest.test_stream_with_encoding):
3417
3418 2018-12-17  Daniel Bates  <dabates@apple.com>
3419
3420         Support concatenating StringView with other string types
3421         https://bugs.webkit.org/show_bug.cgi?id=177566
3422
3423         Reviewed by Darin Adler.
3424
3425         Add some tests to ensure we do not regress the number of allocations needed when performing
3426         string concatenation with string views.
3427
3428         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3429         (TestWebKitAPI::TEST):
3430
3431 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3432
3433         Unreviewed, rolling out r239265 and r239274.
3434         https://bugs.webkit.org/show_bug.cgi?id=192765
3435
3436         unorm_normalize is deprecated, and broke an internal build
3437         (Requested by Truitt on #webkit).
3438
3439         Reverted changesets:
3440
3441         "[GTK][WPE] Need a function to convert internal URI to display
3442         ("pretty") URI"
3443         https://bugs.webkit.org/show_bug.cgi?id=174816
3444         https://trac.webkit.org/changeset/239265
3445
3446         "Fix the Apple Internal Mac build with a newer SDK"
3447         https://trac.webkit.org/changeset/239274
3448
3449 2018-12-17  Daniel Bates  <dabates@apple.com>
3450
3451         Implement UIScriptController::toggleCapsLock() for iOS
3452         https://bugs.webkit.org/show_bug.cgi?id=191815
3453
3454         Reviewed by Andy Estes.
3455
3456         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3457
3458         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3459         * WebKitTestRunner/TestController.cpp:
3460         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3461         before running a test. This ensures that the caps lock state does not persist between
3462         tests should a test enable caps lock and not disable it.
3463         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3464         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3465         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3466         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3467         create the event. Also substituted NSString* for const String& as the data type for the first
3468         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3469         below.
3470         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3471         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3472
3473 2018-12-17  Daniel Bates  <dabates@apple.com>
3474
3475         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3476         https://bugs.webkit.org/show_bug.cgi?id=192633
3477
3478         Reviewed by Wenson Hsieh.
3479
3480         Update code to use the modern initializer.
3481
3482         * DumpRenderTree/mac/EventSendingController.mm:
3483         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3484
3485 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3486
3487         Unreviewed, rolling out r239254.
3488
3489         This broke the Windows 10 Debug build
3490
3491         Reverted changeset:
3492
3493         "Replace many uses of String::format with more type-safe
3494         alternatives"
3495         https://bugs.webkit.org/show_bug.cgi?id=192742
3496         https://trac.webkit.org/changeset/239254
3497
3498 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3499
3500         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3501         <https://webkit.org/b/192751>
3502         <rdar://problem/46771623>
3503
3504         Reviewed by Daniel Bates.
3505
3506         Change loop variables to const references to avoid unnecessary
3507         copies.
3508
3509         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3510         (-[LocalPasteboard pasteboardItems]):
3511
3512 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3513
3514         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3515         https://bugs.webkit.org/show_bug.cgi?id=174816
3516
3517         Reviewed by Michael Catanzaro.
3518
3519         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3520
3521         * TestWebKitAPI/CMakeLists.txt:
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3524         (TestWebKitAPI::TEST):
3525         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3526         (testURIForDisplayUnaffected):
3527         (testURIForDisplayAffected):
3528         (beforeAll):
3529         (afterAll):
3530         * TestWebKitAPI/glib/CMakeLists.txt:
3531
3532 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         [WPE] Add API to notify about frame displayed view backend callback
3535         https://bugs.webkit.org/show_bug.cgi?id=192224
3536
3537         Reviewed by Michael Catanzaro.
3538
3539         Add a test case to check the new API.
3540
3541         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3542         (testWebViewFrameDisplayed):
3543         (beforeAll):
3544         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3545
3546 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3547
3548         Unreviewed build fix after r239253
3549
3550         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3551
3552 2018-12-15  Darin Adler  <darin@apple.com>
3553
3554         Use warning-ignoring macros more consistently and simply
3555         https://bugs.webkit.org/show_bug.cgi?id=192743
3556
3557         Reviewed by Mark Lam.
3558
3559         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3560         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3561         * DumpRenderTree/mac/TextInputControllerMac.m:
3562         (-[TextInputController interpretKeyEvents:withSender:]): Use
3563         IGNORE_WARNINGS_BEGIN/END.
3564         * WebKitTestRunner/mac/EventSenderProxy.mm:
3565         (WTR::EventSenderProxy::mouseForceClick): Use
3566         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3567         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3568         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3569         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3570         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3571
3572 2018-12-15  Darin Adler  <darin@apple.com>
3573
3574         Replace many uses of String::format with more type-safe alternatives
3575         https://bugs.webkit.org/show_bug.cgi?id=192742
3576
3577         Reviewed by Mark Lam.
3578
3579         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3580         (WTR::cacheTestRunnerCallback): Use makeString.
3581         * WebKitTestRunner/TestController.cpp:
3582         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3583         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3584
3585 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3586
3587         [WPE][GTK] Add libpsl to JHBuild module sets
3588         https://bugs.webkit.org/show_bug.cgi?id=192740
3589
3590         Reviewed by Michael Catanzaro.
3591
3592         * gtk/jhbuild.modules: Add libpsl module.
3593         * wpe/jhbuild.modules: Ditto.
3594
3595 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3596
3597         Add a style checker rule for Xcode version macros use
3598         https://bugs.webkit.org/show_bug.cgi?id=192703
3599
3600         Reviewed by Alex Christensen.
3601
3602         * Scripts/webkitpy/style/checkers/cpp.py:
3603         (check_os_version_checks):
3604         (process_line):
3605         (CppChecker):
3606         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3607         (WebKitStyleTest.test_os_version_checks):
3608
3609 2018-12-14  Chris Dumez  <cdumez@apple.com>
3610
3611         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3612         https://bugs.webkit.org/show_bug.cgi?id=192704
3613
3614         Reviewed by Geoffrey Garen.
3615
3616         Extend existing API test to reproduce the problem.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3619
3620 2018-12-14  Chris Dumez  <cdumez@apple.com>
3621
3622         [PSON] WebsitePolicies are lost on process-swap
3623         https://bugs.webkit.org/show_bug.cgi?id=192694
3624         <rdar://problem/46715748>
3625
3626         Reviewed by Brady Eidson.
3627
3628         Extend existing API test to reproduce the issue.
3629
3630         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3631
3632 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3633
3634         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3635         https://bugs.webkit.org/show_bug.cgi?id=192678
3636
3637         Reviewed by Carlos Garcia Campos.
3638
3639         Update our ancient versions of libsoup and glib-networking.
3640
3641         * gtk/install-dependencies:
3642         * gtk/jhbuild.modules:
3643         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3644         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3645         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3646         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3647         * wpe/install-dependencies:
3648         * wpe/jhbuild.modules:
3649         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3650
3651 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         [WPE] Use new view state API from libwpe
3654         https://bugs.webkit.org/show_bug.cgi?id=191906
3655
3656         Reviewed by Žan Doberšek.
3657
3658         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3659         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3660         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3661         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3662         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3663         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3664         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3665         wpe_view_activity_state_focused state flags.
3666         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3667         * wpe/backends/HeadlessViewBackend.cpp:
3668         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3669         * wpe/backends/WindowViewBackend.cpp:
3670         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3671         received in configure callback.
3672         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3673
3674 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3675
3676         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3677         https://bugs.webkit.org/show_bug.cgi?id=192688
3678
3679         Reviewed by Ross Kirsling.
3680
3681         * win/DLLLauncher/DLLLauncherMain.cpp:
3682         (copyEnvironmentVariable): Moved.
3683         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3684         (applePathFromRegistry): Ditto.
3685         (appleApplicationSupportDirectory): Ditto.
3686         (prependPath): Ditto.
3687
3688 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3689
3690         Unreviewed. Changed my status to a reviewer.
3691
3692         * Scripts/webkitpy/common/config/contributors.json:
3693
3694 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3695
3696         [iOS] Support dropping contact card data (public.vcard) in editable content
3697         https://bugs.webkit.org/show_bug.cgi?id=192570
3698         <rdar://problem/35626913>
3699
3700         Reviewed by Tim Horton.
3701
3702         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3703
3704         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3705         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3706         additionally inserts a link).
3707
3708         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3709         (TestWebKitAPI::createMapItemForTesting):
3710         (TestWebKitAPI::createContactItemForTesting):
3711
3712         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3713         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3714         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3715         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3716         files.
3717
3718 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3719
3720         Unreviewed -- update my status to "reviewer".
3721
3722         * Scripts/webkitpy/common/config/contributors.json:
3723
3724 2018-12-13  Youenn Fablet  <youenn@apple.com>
3725
3726         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3727         https://bugs.webkit.org/show_bug.cgi?id=192657
3728
3729         Reviewed by Eric Carlson.
3730
3731         Add a test that loads a page registering ondevicechange,
3732         load another page in the same process, closes the first page.
3733         Ensure that the process does not crash in that case.
3734
3735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3736         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3737         (TestWebKitAPI::TEST):
3738         (TestWebKitAPI::didCrashCallback):
3739         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3740
3741 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3742
3743         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3744         https://bugs.webkit.org/show_bug.cgi?id=192643
3745
3746         Reviewed by Philippe Normand.
3747
3748         This problem happens with Arch Linux users which have libfdk-2.0.0
3749         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3750
3751         The problem has already been solved upstream at
3752         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3753
3754         Adding patches while this problem is not in a release yet.
3755
3756         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3757         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3758         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3759
3760 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3761
3762         [FreeType] Add initial implementation of variation fonts
3763         https://bugs.webkit.org/show_bug.cgi?id=192151
3764
3765         Reviewed by Michael Catanzaro.
3766
3767         Add cairo patch to avoid crashes.
3768
3769         * gtk/jhbuild.modules:
3770         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3771
3772 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3773
3774         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3775         https://bugs.webkit.org/show_bug.cgi?id=192618
3776
3777         Reviewed by Alex Christensen.
3778
3779         * DumpRenderTree/win/DRTDataObject.cpp:
3780         * DumpRenderTree/win/DRTDataObject.h:
3781         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3782         * DumpRenderTree/win/DRTDropSource.h:
3783         * DumpRenderTree/win/EditingDelegate.h:
3784         * DumpRenderTree/win/PolicyDelegate.h:
3785         * DumpRenderTree/win/UIDelegate.h:
3786
3787 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3788
3789         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3790         https://bugs.webkit.org/show_bug.cgi?id=192653
3791
3792         Reviewed by Wenson Hsieh.
3793
3794         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3795         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3796         shadow boundaries.
3797
3798         * DumpRenderTree/mac/TextInputControllerMac.m:
3799         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3800         (+[TextInputController webScriptNameForSelector:]): Ditto.
3801         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3802         start node and offset then end node and offset pairs.
3803
3804 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3805
3806         Implement safe browsing in WebKit on WatchOS
3807         https://bugs.webkit.org/show_bug.cgi?id=192641
3808         <rdar://problem/46376188>
3809
3810         Reviewed by Geoff Garen.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3813         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3814         (safeBrowsingView):
3815         Add a test that the new delegate callback is called.
3816
3817 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3818
3819         Unreviewed manual rollout of r239100-r239102 and r239116
3820         https://bugs.webkit.org/show_bug.cgi?id=192151
3821         <rdar://problem/46655586>
3822
3823         * gtk/jhbuild.modules:
3824         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3825
3826 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3827
3828         Unreviewed, rolling out r239103.
3829         https://bugs.webkit.org/show_bug.cgi?id=192627
3830
3831         It broke the built because it depends on another patch that
3832         didn't land yet (Requested by KaL on #webkit).
3833
3834         Reverted changeset:
3835
3836         "[WPE] Add API to notify about frame displayed view backend
3837         callback"
3838         https://bugs.webkit.org/show_bug.cgi?id=192224
3839         https://trac.webkit.org/changeset/239103
3840
3841 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3842
3843         [WPE] Add API to notify about frame displayed view backend callback
3844         https://bugs.webkit.org/show_bug.cgi?id=192224
3845
3846         Reviewed by Michael Catanzaro.
3847
3848         Add a test case to check the new API.
3849
3850         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3851         (testWebViewFrameDisplayed):
3852         (beforeAll):
3853
3854 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3855
3856         [FreeType] Add initial implementation of variation fonts
3857         https://bugs.webkit.org/show_bug.cgi?id=192151
3858
3859         Reviewed by Michael Catanzaro.
3860
3861         Add cairo patch to avoid crashes.
3862
3863         * gtk/jhbuild.modules:
3864         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3865
3866 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3867
3868         Implement feature flag for CSS Typed OM
3869         https://bugs.webkit.org/show_bug.cgi?id=192610
3870
3871         Reviewed by Ryosuke Niwa.
3872
3873         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3874
3875 2018-12-11  Chris Dumez  <cdumez@apple.com>
3876
3877         Unreviewed, fix bad check in API test added in r239080.
3878
3879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3880
3881 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3882
3883         [Win][Clang] Fix warning -Wmissing-field-initializers
3884         https://bugs.webkit.org/show_bug.cgi?id=192584
3885
3886         Reviewed by Yusuke Suzuki.
3887
3888         Initialize a struct with '{ }' instead of '= {0}'.
3889
3890         * DumpRenderTree/win/DumpRenderTree.cpp:
3891         (runTest):
3892         * DumpRenderTree/win/EventSender.cpp:
3893         (makeMsg):
3894         (replaySavedEvents):
3895         (beginDragWithFilesCallback):
3896         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3897         (createBitmapContextFromWebView):
3898         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3899         (updateMenuItemForHistoryItem):
3900         * MiniBrowser/win/WinMain.cpp:
3901         (wWinMain):
3902         * TestWebKitAPI/win/HostWindow.cpp:
3903         (TestWebKitAPI::HostWindow::clientRect const):
3904         (TestWebKitAPI::HostWindow::registerWindowClass):
3905         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3906         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3907         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3908         (WTR::registerWindowClass):
3909         (WTR::PlatformWebView::windowFrame):
3910         (WTR::PlatformWebView::windowSnapshotImage):
3911
3912 2018-12-11  Chris Dumez  <cdumez@apple.com>
3913
3914         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3915         https://bugs.webkit.org/show_bug.cgi?id=192482
3916         <rdar://problem/46470145>
3917
3918         Reviewed by Antti Koivisto.
3919
3920         Add API test coverage.
3921
3922         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3923
3924 2018-12-11  Andy Estes  <aestes@apple.com>
3925
3926         Introduce makeBlockPtr for lambdas
3927         https://bugs.webkit.org/show_bug.cgi?id=192594
3928
3929         Reviewed by Alex Christensen.
3930
3931         Adopted makeBlockPtr and added API tests.
3932
3933         * DumpRenderTree/TestRunner.cpp:
3934         (TestRunner::callUIScriptCallback):
3935         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3936         (TestWebKitAPI::TEST):
3937         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3938         (-[DownloadProgressTestRunner init]):
3939         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3940
3941 2018-12-11  Chris Dumez  <cdumez@apple.com>
3942
3943         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3944         https://bugs.webkit.org/show_bug.cgi?id=192361
3945         <rdar://problem/46524903>
3946
3947         Reviewed by Alex Christensen.
3948
3949         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3950         fixes the failures for me locally.
3951
3952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3953
3954 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3955
3956         Unreviewed, WPE build fix after r239028
3957
3958         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3959
3960         Traceback (most recent call last):
3961         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3962           sys.exit(WebkitFlatpak.load_from_args().run())
3963         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3964           if not self.clean_args():
3965         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3966           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3967         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3968           raise KeyError(key)
3969         KeyError: 'FLATPAK_USER_DIR'
3970
3971         * flatpak/flatpakutils.py:
3972         (WebkitFlatpak.clean_args):
3973
3974 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3975
3976         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3977         https://bugs.webkit.org/show_bug.cgi?id=192573
3978
3979         Reviewed by Simon Fraser.
3980
3981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3982
3983 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3984
3985         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3986         https://bugs.webkit.org/show_bug.cgi?id=192574
3987
3988         Reviewed by Michael Catanzaro.
3989
3990         * Scripts/webkitperl/FeatureList.pm:
3991
3992 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3993
3994         Sync FeatureList.pm
3995         https://bugs.webkit.org/show_bug.cgi?id=192565
3996
3997         Reviewed by Michael Catanzaro.
3998
3999         * Scripts/webkitperl/FeatureList.pm:
4000
4001 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
4002
4003         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
4004         https://bugs.webkit.org/show_bug.cgi?id=192555
4005         <rdar://problem/35204990>
4006
4007         Reviewed by Tim Horton.
4008
4009         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
4010         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
4011         only support uploading "public.content", so files such as these would not be accepted when dropping into file
4012         inputs, or be exposed as files on DataTransfer.
4013
4014         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4015         (TestWebKitAPI::TEST):
4016
4017 2018-12-10  David Kilzer  <ddkilzer@apple.com>
4018
4019         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
4020         <https://webkit.org/b/192481>
4021         <rdar://problem/46539059>
4022
4023         Follow-up to address Darin's feedback.
4024
4025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4026         (WTR::TestRunner::shouldDumpPixels const):
4027         (WTR::TestRunner::whatToDump const):
4028         (WTR::TestRunner::shouldWaitUntilDone const):
4029         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
4030         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
4031         (WTR::TestRunner::secureEventInputIsEnabled const):
4032         (WTR::TestRunner::isStatisticsPrevalentResource):
4033         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
4034         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
4035         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
4036         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
4037         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
4038         (WTR::TestRunner::isStatisticsGrandfathered):
4039         (WTR::TestRunner::hasDOMCache):
4040         (WTR::TestRunner::keyExistsInKeychain):
4041
4042 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
4043
4044         webkitpy: Ref tests don't respect platform specific expectations
4045         https://bugs.webkit.org/show_bug.cgi?id=192515
4046         <rdar://problem/46564839>
4047
4048         Reviewed by Lucas Forschler.
4049
4050         * Scripts/webkitpy/port/base.py:
4051         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
4052         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
4053         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
4054         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
4055         search all platform expectations as well.
4056         * Scripts/webkitpy/port/base_unittest.py:
4057         (test_ref_tests_platform_directory):
4058
4059 2018-12-10  Chris Dumez  <cdumez@apple.com>
4060
4061         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
4062         https://bugs.webkit.org/show_bug.cgi?id=192509
4063         <rdar://problem/46500832>
4064
4065         Reviewed by Alex Christensen.
4066
4067         Add API test coverage.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4070         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
4071         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
4072         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
4073         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4074         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
4075
4076 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
4077
4078         [iOS] Caret is obscured by finger when dragging over an editable element
4079         https://bugs.webkit.org/show_bug.cgi?id=192499
4080         <rdar://problem/46570101>
4081
4082         Reviewed by Tim Horton.
4083
4084         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
4085
4086         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4087         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4088         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4089         (-[DragAndDropSimulator _resetSimulatedState]):
4090         (-[DragAndDropSimulator lastKnownDropProposal]):
4091
4092         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
4093
4094         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
4095         (-[DragAndDropSimulator _advanceProgress]):
4096         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
4097         (-[DragAndDropSimulator showCustomActionSheetBlock]):
4098         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
4099         (-[DragAndDropSimulator convertItemProvidersBlock]):
4100         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
4101         (-[DragAndDropSimulator overridePerformDropBlock]):
4102         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
4103         (-[DragAndDropSimulator overrideDragUpdateBlock]):
4104         (-[DragAndDropSimulator setDropCompletionBlock:]):
4105         (-[DragAndDropSimulator dropCompletionBlock]):
4106
4107         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
4108         `BlockPtr` instance variables to manage the lifetimes of these blocks.
4109
4110         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
4111         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
4112
4113         Update this to use the new WebKit delegate hook for overriding the drop proposal.
4114
4115 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4116
4117         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
4118         https://bugs.webkit.org/show_bug.cgi?id=190241
4119
4120         Reviewed by Carlos Garcia Campos.
4121
4122         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
4123         Currently this actually creates the directories needed for the flatpak environment. Fix it.
4124
4125         * flatpak/flatpakutils.py:
4126         (WebkitFlatpak.clean_args):
4127         (WebkitFlatpak.run):
4128
4129 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4130
4131         [GTK] Don't use the slice allocator
4132         https://bugs.webkit.org/show_bug.cgi?id=192360
4133
4134         Reviewed by Carlos Garcia Campos.
4135
4136         * MiniBrowser/gtk/main.c:
4137         (aboutDataRequestFree):
4138         (aboutDataRequestNew):
4139
4140 2018-12-10  Tim Horton  <timothy_horton@apple.com>
4141
4142         WKWebView should support custom tintColor
4143         https://bugs.webkit.org/show_bug.cgi?id=192518
4144         <rdar://problem/37243261>
4145
4146         Reviewed by Wenson Hsieh.
4147
4148         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
4149         (TestWebKitAPI::TEST):
4150         Add a test that tintColor affects UITextInputTraits' interaction colors.
4151
4152 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4153
4154         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
4155         https://bugs.webkit.org/show_bug.cgi?id=192524
4156
4157         Reviewed by Ryosuke Niwa.
4158
4159         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
4160         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
4161         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
4162         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
4163         wide selection rect and increases the width of the document; revealing this selection causes the web view to
4164         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
4165         these window coordinates no longer correspond to the drop destination element in the document.
4166
4167         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
4168         scroll horizontally after the first drop.
4169
4170         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
4171
4172 2018-12-08  Daniel Bates  <dabates@apple.com>
4173
4174         Fix lldb_webkit.py following r238771
4175         (https://bugs.webkit.org/show_bug.cgi?id=190234)
4176
4177         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
4178         missed in r238771.
4179
4180         * lldb/lldb_webkit.py:
4181         (WebCoreDocumentProvider.url):
4182
4183 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4184
4185         [ews-build] check-patch-relevance failure should not mark the overall build as failure
4186         https://bugs.webkit.org/show_bug.cgi?id=192510
4187
4188         Reviewed by Lucas Forschler.
4189
4190         * BuildSlaveSupport/ews-build/steps.py:
4191         (CheckPatchRelevance.start):
4192
4193 2018-12-07  Chris Dumez  <cdumez@apple.com>
4194
4195         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
4196         https://bugs.webkit.org/show_bug.cgi?id=192362
4197         <rdar://problem/46460360>
4198
4199         Reviewed by Ryosuke Niwa.
4200
4201         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
4202         *after* we know for sure we have a network process to communicate the policy to.
4203         This should address the failures on iOS.
4204
4205         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4206
4207 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
4208
4209         Add keychain access entitlement to WebKitTestRunnerApp
4210         https://bugs.webkit.org/show_bug.cgi?id=192489
4211         <rdar://problem/45057952>
4212
4213         Reviewed by Alexey Proskuryakov.
4214
4215         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
4216
4217 2018-12-07  Saam Barati  <sbarati@apple.com>
4218
4219         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
4220         https://bugs.webkit.org/show_bug.cgi?id=192473
4221
4222         Reviewed by Andy Estes.
4223
4224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4225         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
4226         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
4227         (TEST):
4228         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
4229         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4230         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
4231         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
4232         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
4233
4234 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
4235
4236         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
4237         https://bugs.webkit.org/show_bug.cgi?id=192470
4238         <rdar://problem/46532001>
4239
4240         Unreviewed infrastructure fix.
4241
4242         * Scripts/webkitpy/port/device_port.py:
4243         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
4244         number of child processes.
4245
4246 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4247
4248         [ews-app] Send bug id as a build property
4249         https://bugs.webkit.org/show_bug.cgi?id=192494
4250
4251         Reviewed by Lucas Forschler.
4252
4253         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4254         (BugzillaPatchFetcher.fetch):
4255
4256 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4257
4258         [ews-build] Builds should have a link to patch and bug
4259         https://bugs.webkit.org/show_bug.cgi?id=192492
4260
4261         Reviewed by Lucas Forschler.
4262
4263         * BuildSlaveSupport/ews-build/steps.py:
4264         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
4265         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
4266         (ConfigureBuild.getPatchURL): Method to get Patch URL.
4267         (ConfigureBuild.getBugURL): Method to get Bug URL.
4268
4269 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4270
4271         [ews-app] Configure logfile for ews-app logs
4272         https://bugs.webkit.org/show_bug.cgi?id=192493
4273
4274         Reviewed by Lucas Forschler.
4275
4276         * BuildSlaveSupport/ews-app/ews/__init__.py:
4277
4278 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4279
4280         Style queue exception on some security bugs
4281         https://bugs.webkit.org/show_bug.cgi?id=190793
4282
4283         Reviewed by Lucas Forschler.
4284
4285         * Scripts/webkitpy/tool/steps/applywatchlist.py:
4286         (ApplyWatchList.run):
4287
4288 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4289
4290         [Attachment Support] Cloned attachment elements lose their unique identifiers
4291         https://bugs.webkit.org/show_bug.cgi?id=192483
4292
4293         Reviewed by Tim Horton.
4294
4295         Introduce a new API test.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4298         (TestWebKitAPI::TEST):
4299
4300 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4301
4302         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
4303         https://bugs.webkit.org/show_bug.cgi?id=192486
4304
4305         Unreviewed&