Add WTF::ScopeExit
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-16  Anders Carlsson  <andersca@apple.com>
2
3         Add WTF::ScopeExit
4         https://bugs.webkit.org/show_bug.cgi?id=160908
5
6         Reviewed by Geoffrey Garen.
7
8         * TestWebKitAPI/CMakeLists.txt:
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
11         (TestWebKitAPI::TEST):
12
13 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
14
15         EWS logs file are rotated too quickly
16         https://bugs.webkit.org/show_bug.cgi?id=160724
17
18         Reviewed by Daniel Bates.
19
20         Currently we are rotating the log file after 10 iterations of queue. If the queue
21         doesn't have any pending patches, these iterations result in very small amount of 
22         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
23         This results in a lot of log files in a day. This patch ensures that we rotate the
24         log file when its file size is greater than or equal to 100 KB.
25
26         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
27
28 2016-08-16  Daniel Bates  <dabates@apple.com>
29
30         WKSI static library should be named by major iOS revision, not individual updates
31         https://bugs.webkit.org/show_bug.cgi?id=160727
32         <rdar://problem/22274848>
33
34         Reviewed by Alexey Proskuryakov.
35
36         * DumpRenderTree/mac/Configurations/Base.xcconfig:
37         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
38         * Scripts/copy-webkitlibraries-to-product-directory:
39         * WebKitTestRunner/Configurations/Base.xcconfig:
40         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
41
42 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
43
44         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
45         https://bugs.webkit.org/show_bug.cgi?id=160909
46
47         Reviewed by Enrica Casucci.
48         
49         Add functions to UIScriptController to dismiss the form accessory view for iOS,
50         and to programmatically pick a row from a <select> picker.
51
52         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
53         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::dismissFormAccessoryView):
55         (WTR::UIScriptController::selectFormAccessoryPickerRow):
56         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
57         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
58         (WTR::UIScriptController::dismissFormAccessoryView):
59         (WTR::UIScriptController::selectFormAccessoryPickerRow):
60
61 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
62
63         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
64         https://bugs.webkit.org/show_bug.cgi?id=160878
65
66         Reviewed by Tim Horton.
67         
68         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
69         now that we have the ability to run tests in the iPad simulator.
70
71         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
72         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
73         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
74         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
75         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
76         * WebKitTestRunner/ios/TestControllerIOS.mm:
77         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
78         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
79         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
80         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
81
82 2016-08-15  Anders Carlsson  <andersca@apple.com>
83
84         Add an address-of operator to RetainPtr
85         https://bugs.webkit.org/show_bug.cgi?id=160879
86
87         Reviewed by Tim Horton.
88
89         Test HashMap and HashSet with an object whose operator& is deleted.
90
91         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
92         Sort the Xcode project.
93
94         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
95         (DeletedAddressOfOperator::DeletedAddressOfOperator):
96         (DeletedAddressOfOperator::value):
97         (DeletedAddressOfOperator::operator==):
98         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
99         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
100         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
101         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
102         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
105         (TestWebKitAPI::TEST):
106
107 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
108
109         False crashes in fast/text/emoji-gender-* tests
110         https://bugs.webkit.org/show_bug.cgi?id=160779
111
112         Reviewed by Alexey Proskuryakov.
113
114         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
115
116         * Scripts/webkitpy/port/driver.py:
117         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
118         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
119         * Scripts/webkitpy/port/server_process.py:
120         (ServerProcess.write): Allow caller to disable crash flag on exception.
121
122 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
123
124         webkitpy error in TestRunResults.merge()
125         https://bugs.webkit.org/show_bug.cgi?id=160882
126
127         Reviewed by Daniel Bates.
128         
129         The argument to TestRunResults.merge() can be None if there are no device-specifc
130         initial results or retry results in Manager.run(), so just return early in that case.
131
132         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
133         (TestRunResults.merge):
134
135 2016-08-15  Sam Weinig  <sam@webkit.org>
136
137         Speed up compile times by not including wtf/Variant.h so much
138         https://bugs.webkit.org/show_bug.cgi?id=160847
139
140         Reviewed by Alex Christensen and Saam Barati.
141
142         * TestWebKitAPI/Tests/WTF/Variant.cpp:
143         (TestWebKitAPI::TEST):
144         Explicitly use std::experimental::variant.
145
146 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
147
148         Allow a port to run tests with a custom device setup
149         https://bugs.webkit.org/show_bug.cgi?id=160833
150
151         Reviewed by Daniel Bates.
152
153         These changes allow the IOSSimulator port to run tests in iPad mode.
154
155         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
156         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
157         a custom device will be collected into a set, and run in that device's environment after
158         the other tests have run.
159
160         * Scripts/webkitpy/layout_tests/controllers/manager.py:
161         (Manager._custom_device_for_test): If the test contains a directory matching a
162         custom device suffix, return that custom device.
163         (Manager._set_up_run): Push the custom device class, if any, into options so
164         that the Worker can get to it.
165         (Manager.run): Go through the list of tests, and break it down into device-generic
166         tests, and tests for each device class. _run_test_subset is then called for
167         each collection of tests, and the results merged.
168         (Manager._run_test_subset): Some lines unwrapped.
169         (Manager._end_test_run):
170         (Manager._run_tests):
171         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
172         (SingleTestRunner.__init__): Unwrapped a line.
173         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
174         (TestRunResults.merge): Add this function to merge TestRunResults
175         * Scripts/webkitpy/layout_tests/views/printing.py:
176         (Printer.print_workers_and_shards): Print the custom device, if any.
177         * Scripts/webkitpy/port/base.py:
178         (Port): Base port has empty array of custom devices.
179         (Port.setup_test_run): Add device_class argument.
180         * Scripts/webkitpy/port/driver.py:
181         (DriverInput.__repr__):
182         (Driver.check_driver.implementation):
183         * Scripts/webkitpy/port/efl.py:
184         (EflPort.setup_test_run):
185         * Scripts/webkitpy/port/gtk.py:
186         (GtkPort.setup_test_run):
187         * Scripts/webkitpy/port/ios.py:
188         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
189         (IOSSimulatorPort.__init__):
190         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
191         based on the custom device class.
192         (IOSSimulatorPort._set_device_class):
193         (IOSSimulatorPort._create_simulators): Factor some code into this function.
194         (IOSSimulatorPort.setup_test_run):
195         (IOSSimulatorPort.testing_device):
196         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
197         seemed wrong for this function. That was moved to setup_test_run().
198         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
199         but this happened too early, before we knew which kind of devices to create. Devices
200         are now created in setup_test_run().
201         * Scripts/webkitpy/port/win.py:
202         (WinPort.setup_test_run):
203
204 2016-08-15  Daniel Bates  <dabates@apple.com>
205
206         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
207         private frameworks and libraries
208         https://bugs.webkit.org/show_bug.cgi?id=155931
209         <rdar://problem/25807989>
210
211         Reviewed by Dan Bernstein.
212
213         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
214         where X is the major version of the active iOS SDK.
215
216         * DumpRenderTree/mac/Configurations/Base.xcconfig:
217         * WebKitTestRunner/Configurations/Base.xcconfig:
218
219 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
220
221         Add a setting and preferences to enable visual viewport mode
222         https://bugs.webkit.org/show_bug.cgi?id=160843
223
224         Reviewed by Sam Weinig.
225         
226         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
227
228         * MiniBrowser/mac/SettingsController.h:
229         * MiniBrowser/mac/SettingsController.m:
230         (-[SettingsController _populateMenu]):
231         (-[SettingsController validateMenuItem:]):
232         (-[SettingsController visualViewportEnabled]):
233         (-[SettingsController toggleVisualViewportEnabled:]):
234         * MiniBrowser/mac/WK1BrowserWindowController.m:
235         (-[WK1BrowserWindowController didChangeSettings]):
236         * MiniBrowser/mac/WK2BrowserWindowController.m:
237         (-[WK2BrowserWindowController didChangeSettings]):
238
239 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
240
241         Allow using make-dist with non-GTK ports
242         https://bugs.webkit.org/show_bug.cgi?id=160842
243
244         Reviewed by Michael Catanzaro.
245
246         This patch adds support for setting base name of tarball and argument
247         passed to cmake's -DPORT= via command line arguments.
248
249         * gtk/make-dist.py:
250         (Distcheck.configure):
251         (Distcheck.check):
252         (get_tarball_root_and_output_filename_from_arguments):
253
254 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
255
256         [GTK] Install script lacks gstreamer related dependencies
257         https://bugs.webkit.org/show_bug.cgi?id=160814
258
259         Reviewed by Carlos Garcia Campos.
260
261         * gtk/install-dependencies: Fedora case had already listed this dependencies,
262         but both Arch and Debian/Ubuntu were missing them.
263
264 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
265
266         make-dist.py should not allow unknown rules in manifest
267         https://bugs.webkit.org/show_bug.cgi?id=160841
268
269         Reviewed by Carlos Garcia Campos.
270
271         * gtk/make-dist.py:
272         (Manifest.process_line):
273
274 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
275
276         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
277         https://bugs.webkit.org/show_bug.cgi?id=160809
278
279         Reviewed by Carlos Garcia Campos.
280
281         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
282         case, and use it also for the new package names of libpng and libgeoclue.
283         * gtk/install-dependencies: Ditto.
284
285 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
286
287         Skip to check directories existence in build-webkit
288         https://bugs.webkit.org/show_bug.cgi?id=160691
289
290         Reviewed by Alex Christensen.
291
292         CMake checks if directories are there itself. So CMake ports
293         don't need to check it in the build-webkit script.
294
295         * Scripts/build-webkit:
296         * Scripts/webkitdirs.pm:
297         (determineSourceDir):
298         (isCMakeBuild):
299
300 2016-08-12  Alex Christensen  <achristensen@webkit.org>
301
302         Make URLParser work with URLs missing URL parts
303         https://bugs.webkit.org/show_bug.cgi?id=160824
304
305         Reviewed by Brady Eidson.
306
307         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
308         (TestWebKitAPI::s):
309         (TestWebKitAPI::checkURL):
310         (TestWebKitAPI::TEST_F):
311         (TestWebKitAPI::eq): Deleted.
312
313 2016-08-12  John Wilander  <wilander@apple.com>
314
315         Add HashCountedSet API tests to TestWTFLibrary target
316         https://bugs.webkit.org/show_bug.cgi?id=160815
317
318         Reviewed by Alex Christensen.
319
320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
321             Added HashCountedSet.cpp and sorted the file reference section
322             according to UNIX sort.
323
324 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
325
326         run-benchmark should run JetStream 1.1 instead of 1.0.1
327         https://bugs.webkit.org/show_bug.cgi?id=160816
328
329         Reviewed by Filip Pizlo.
330
331         Use the latest JetStream 1.1 in run-benchmark.
332
333         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
334         (BenchmarkBuilder.__exit__):
335         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
336         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
337         change to JetStream directory.
338
339 2016-08-12  Alex Christensen  <achristensen@webkit.org>
340
341         Initial URLParser implementation
342         https://bugs.webkit.org/show_bug.cgi?id=160811
343
344         Reviewed by Brady Eidson.
345
346         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
347         (TestWebKitAPI::eq):
348         (TestWebKitAPI::checkURL):
349         (TestWebKitAPI::TEST_F):
350
351 2016-08-12  Brady Eidson  <beidson@apple.com>
352
353         Fix the 32-bit Mac build after:
354         Add WK2 ExperimentalFeature support to MiniBrowser
355         https://bugs.webkit.org/show_bug.cgi?id=160788
356
357         Unreviewed.
358
359         Sprinkle "#if WK_API_ENABLED"s liberally.
360         
361         * MiniBrowser/mac/AppDelegate.m:
362         (defaultConfiguration):
363         * MiniBrowser/mac/SettingsController.m:
364         (-[SettingsController _populateMenu]):
365         (-[SettingsController validateMenuItem:]):
366
367 2016-08-12  Philippe Normand  <pnormand@igalia.com>
368
369         [GStreamer][OWR] Video rendering fixes
370         https://bugs.webkit.org/show_bug.cgi?id=160764
371
372         Reviewed by Xabier Rodriguez-Calvar.
373
374         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
375
376 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
377
378         Add missing return statement in convertFast function added in r204376.
379
380         Unreviewed.
381
382         * Scripts/webkitpy/common/system/path.py:
383         (_CygPath.convertFast):
384
385 2016-08-11  Brady Eidson  <beidson@apple.com>
386
387         Add WK2 ExperimentalFeature support to MiniBrowser.
388         https://bugs.webkit.org/show_bug.cgi?id=160788
389
390         Reviewed by Alex Christensen.
391
392         * MiniBrowser/mac/AppDelegate.h:
393         * MiniBrowser/mac/AppDelegate.m:
394         (defaultConfiguration):
395         (defaultPreferences):
396         
397         * MiniBrowser/mac/SettingsController.m:
398         (-[SettingsController _populateMenu]):
399         (-[SettingsController validateMenuItem:]):
400         (-[SettingsController toggleExperimentalFeature:]):
401
402 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
403
404         Keep EWS logs for longer
405         https://bugs.webkit.org/show_bug.cgi?id=160776
406
407         Reviewed by Daniel Bates.
408
409         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
410
411 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
412
413         iOS DRT/WTR project cleanup
414         https://bugs.webkit.org/show_bug.cgi?id=160778
415
416         Reviewed by Tim Horton.
417
418         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
419
420         Remove AppDelegate.* which were unused.
421
422         Exclude ios/Launch.storyboard on more platforms.
423
424         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
425         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
426         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
427         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
428         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
429         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
430         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
431
432 2016-08-11  Alex Christensen  <achristensen@webkit.org>
433
434         Fix Yosemite bots' cookie accept policies after r204365.
435         https://bugs.webkit.org/show_bug.cgi?id=160758
436
437         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
438         (TEST):
439         This makes the test fully clean up after itself.
440
441 2016-08-11  Alex Christensen  <achristensen@webkit.org>
442
443         Fix Yosemite bots' cookie accept policies after r204365.
444         https://bugs.webkit.org/show_bug.cgi?id=160758
445
446         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
447         (TEST):
448         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
449         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
450         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
451         causing any problems because there are no other API tests that do anything with cookies.
452         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
453         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
454         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
455
456 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
457
458         EWS should check if the patch is still valid before executing every major step
459         https://bugs.webkit.org/show_bug.cgi?id=160739
460         rdar://problem/27768813
461
462         Reviewed by Alexey Proskuryakov.
463
464         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
465         (CommitQueueTask.run): validate method is now executed in base class.
466         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
467         (EarlyWarningSystemTask.run): validate method is now executed in base class.
468         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
469         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
470         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
471         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
472         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
473         * Scripts/webkitpy/tool/commands/perfalizer.py:
474         (PerfalizerTask.validate): Added.
475         * Scripts/webkitpy/tool/commands/queues_unittest.py:
476         (test_manual_reject_during_processing): Updated test case.
477
478 2016-08-11  Alex Christensen  <achristensen@webkit.org>
479
480         Add URLParser stub
481         https://bugs.webkit.org/show_bug.cgi?id=160770
482
483         Reviewed by Sam Weinig.
484
485         * TestWebKitAPI/PlatformGTK.cmake:
486         * TestWebKitAPI/PlatformWin.cmake:
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
489         (TestWebKitAPI::TEST_F):
490
491 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
492
493         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
494         https://bugs.webkit.org/show_bug.cgi?id=160761
495
496         Reviewed by Tim Horton.
497
498         Give iOS DRT a Launch storyboard.
499
500         Have it use a UIViewController so future forms testing works correctly.
501
502         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
503         can run in iPad mode.
504
505         Remove empty InfoPlist.strings files.
506
507         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
508         * DumpRenderTree/ios/Info.plist:
509         * DumpRenderTree/ios/Launch.storyboard: Added.
510         * DumpRenderTree/mac/DumpRenderTree.mm:
511         (createWebViewAndOffscreenWindow):
512         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
513         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
514         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
515         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
516
517 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
518
519         [Win] Unable to reliably run tests in parallel
520         https://bugs.webkit.org/show_bug.cgi?id=140914
521
522         Reviewed by Brent Fulgham.
523
524         The cygpath utility function can fail badly when running with multiple DumpRenderTree
525         processes. We can use string replacement to convert the Cygwin path to a Windows path
526         instead.
527
528         * Scripts/webkitpy/common/system/path.py:
529         (cygpathFast):
530         * Scripts/webkitpy/port/driver.py:
531         (Driver._command_from_driver_input):
532
533 2016-08-10  Alex Christensen  <achristensen@webkit.org>
534
535         Fix crash when changing cookie accept policy after r204327
536         https://bugs.webkit.org/show_bug.cgi?id=160758
537
538         Reviewed by Simon Fraser.
539
540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
541         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
542         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
543         (TEST):
544         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
545
546 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
547
548         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
549         https://bugs.webkit.org/show_bug.cgi?id=160757
550
551         Reviewed by Tim Horton.
552
553         When programmatically creating the test UIWindow, make a root UIViewController and parent
554         the WKWebView in its view. This makes the app more like a normal UIKit application.
555         
556         Move the WKWebView down 20px to avoid the status bar.
557         
558         Give the UIWindow a gray background so it's obvious where the window and view positioned.
559
560         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
561         
562         Remove duplicate references to Launch.storyboard.
563
564         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
565         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
566         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
567         (-[AppDelegate applicationWillResignActive:]): Deleted.
568         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
569         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
570         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
571         (-[AppDelegate applicationWillTerminate:]): Deleted.
572         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
573         (WTR::viewRectForWindowRect):
574         (WTR::PlatformWebView::PlatformWebView):
575         (WTR::PlatformWebView::setWindowFrame):
576
577 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
578
579         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
580         https://bugs.webkit.org/show_bug.cgi?id=160748
581
582         Reviewed by Tim Horton.
583         
584         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
585         opens the door for tests using other device sizes.
586
587         * WebKitTestRunner/ios/TestControllerIOS.mm:
588         (WTR::TestController::platformConfigureViewForTest):
589
590 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
591
592         Sort the feature flags in the FEATURE_DEFINES lines
593         https://bugs.webkit.org/show_bug.cgi?id=160742
594
595         Reviewed by Anders Carlsson.
596         
597         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
598
599 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
600
601         Logging and other minor improvements to iOS webkitpy
602         https://bugs.webkit.org/show_bug.cgi?id=160722
603
604         Reviewed by Dan Bates.
605
606         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
607         to make it easier to debug launching issues.
608
609         Have reset_preferences() reset the device, rather than just nuking the data
610         directory (which broke some versions of the simulator).
611
612         Make the Simulator.app launch in the background with open -g.
613
614         Wait for the simulator device to be in a known state in some more places.
615
616         * Scripts/webkitpy/port/ios.py:
617         (IOSSimulatorPort.setup_test_run):
618         (IOSSimulatorPort._quit_ios_simulator):
619         (IOSSimulatorPort.clean_up_test_run):
620         (IOSSimulatorPort.setup_environ_for_server):
621         (IOSSimulatorPort.reset_preferences):
622         * Scripts/webkitpy/xcode/simulator.py:
623         (Device.create):
624         (Device.delete):
625         (Device):
626         (Device.reset):
627         (Simulator.wait_until_device_is_booted):
628         (Simulator.wait_until_device_is_in_state):
629         (Simulator):
630         (Simulator.delete_device):
631         (Simulator.reset_device):
632         (Simulator.lookup_or_create_device):
633
634 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
635
636         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
637         https://bugs.webkit.org/show_bug.cgi?id=160697
638
639         Reviewed by Antonio Gomes.
640
641         * Scripts/webkitpy/port/base.py:
642         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
643         list of environment variables to copy.
644
645 2016-08-09  George Ruan  <gruan@apple.com>
646
647         Implement functionality of media capture on iOS
648         https://bugs.webkit.org/show_bug.cgi?id=158945
649         <rdar://problem/26893343>
650
651         Reviewed by Tim Horton.
652
653         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
654         Capture feature on iOS.
655
656 2016-08-09  Saam Barati  <sbarati@apple.com>
657
658         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
659         https://bugs.webkit.org/show_bug.cgi?id=160671
660         <rdar://problem/27756112>
661
662         Reviewed by Mark Lam.
663
664         * Scripts/run-jsc-stress-tests:
665
666 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
667
668         Make directory reading code in iOSSimulatorDevices() more strict
669         https://bugs.webkit.org/show_bug.cgi?id=160702
670
671         Reviewed by Tim Horton.
672
673         * Scripts/webkitdirs.pm:
674         (iOSSimulatorDevices):
675
676 2016-08-06  Sam Weinig  <sam@webkit.org>
677
678         Replace NodeOrString with std::variant<RefPtr<Node>, String>
679         https://bugs.webkit.org/show_bug.cgi?id=160638
680
681         Reviewed by Anders Carlsson.
682
683         * TestWebKitAPI/CMakeLists.txt:
684         * TestWebKitAPI/Tests/WTF/Variant.cpp:
685         Add additional tests for the initial state of std::variant and using
686         makeVisitor for visiting.
687
688 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
689
690         EWS logging should ensure the logging to file is stopped on queue termination
691         https://bugs.webkit.org/show_bug.cgi?id=160698
692         rdar://problem/24464570
693
694         Reviewed by Daniel Bates.
695
696         * Scripts/webkitpy/tool/bot/queueengine.py:
697         (QueueEngine._stopping): Stop logging to file on queue termination.
698         (QueueEngine._begin_logging): Configure the Python logger to log to file.
699         * Scripts/webkitpy/common/system/logutils.py:
700         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
701         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
702         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
703         * Scripts/webkitpy/tool/commands/queues.py:
704         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
705         (AbstractQueue.queue_log_path): Same.
706         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
707         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
708         which moved to QueueEngine now.
709         (PatchProcessingQueue.__init__): Same.
710         (CommitQueue.__init__): Same.
711         (AbstractReviewQueue.__init__): Same.
712         (StyleQueue.__init__): Same.
713         * Scripts/webkitpy/tool/commands/queues_unittest.py:
714         (TestCommitQueue): Removed host parameter.
715         (TestCommitQueue.__init__): Same.
716         (AbstractPatchQueueTest.test_next_patch): Same.
717         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
718         (test_commit_queue_failure): Same.
719         (mock_run_webkit_patch):
720         (MockCommitQueueTask.results_from_patch_test_run): Same.
721         (test_rollout_lands): Same.
722         (test_non_valid_patch): Same.
723         (test_auto_retry): Same.
724         (test_style_queue_with_watch_list_exception): Same.
725         (TestQueue.__init__): Deleted.
726         (TestReviewQueue.__init__): Deleted.
727         (TestFeederQueue.__init__): Deleted.
728
729 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
730
731         webkit-gtk tarball fails to build due to missing files
732         https://bugs.webkit.org/show_bug.cgi?id=160684
733
734         Reviewed by Alex Christensen.
735
736         * gtk/manifest.txt.in: Added back spi directories.
737
738 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
739
740         [GTK] Build the jhbuild with -O2 optimization level by default
741         https://bugs.webkit.org/show_bug.cgi?id=160544
742
743         Reviewed by Michael Catanzaro.
744
745         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
746         which don't increases the required disk space significatively and
747         provides better debug information than no passing it.
748
749 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
750
751         Allow more --cmakeargs option in build-jsc and build-webkit
752         https://bugs.webkit.org/show_bug.cgi?id=160340
753
754         Reviewed by Michael Catanzaro.
755
756         * Scripts/build-jsc:
757         * Scripts/build-webkit:
758
759 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
760
761         Do not check if WebKitLibraries folder exists on EFL and GTK
762         https://bugs.webkit.org/show_bug.cgi?id=160659
763
764         Reviewed by Csaba Osztrogonác.
765
766         Though WebKitLibraries is only needed by mac and win ports,
767         EFL and GTK ports have checked whether it exists.
768
769         * Scripts/build-webkit:
770
771 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
772
773         Some EWS console logs doesn't go to log file
774         https://bugs.webkit.org/show_bug.cgi?id=160585
775         rdar://problem/24464570
776
777         Reviewed by Daniel Bates.
778
779         * Scripts/webkitpy/common/system/logutils.py:
780         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
781         any possible overwriting.
782         * Scripts/webkitpy/common/system/filesystem.py:
783         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
784         * Scripts/webkitpy/common/system/filesystem_mock.py:
785         (MockFileSystem.open_text_file_for_writing): Same.
786         * Scripts/webkitpy/common/system/filesystem_unittest.py:
787         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
788         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
789         * Scripts/webkitpy/tool/commands/queues.py:
790         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
791         This will ensure that all the sub-modules inside webkitpy will log to file.
792
793 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
794
795         Have the iOS platform interit from the Apple platform in webkitpy
796         https://bugs.webkit.org/show_bug.cgi?id=160672
797
798         Reviewed by Dan Bates.
799         
800         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
801         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
802         ApplePort.
803         
804         Since WinPort also inherits from ApplePort, it needs to stub out some things
805         that are unavailable on Windows (leaks, sampling).
806         
807         Some SnowLeopard-related code and the associated test were removed.
808
809         * Scripts/webkitpy/port/apple.py:
810         (ApplePort.__init__):
811         (ApplePort):
812         (ApplePort._make_leak_detector):
813         (ApplePort.default_timeout_ms):
814         (ApplePort.supports_per_test_timeout):
815         (ApplePort.should_retry_crashes):
816         (ApplePort._generate_all_test_configurations):
817         (ApplePort.check_for_leaks):
818         (ApplePort.print_leaks_summary):
819         (ApplePort._path_to_webcore_library):
820         (ApplePort.show_results_html_file):
821         (ApplePort._merge_crash_logs):
822         (ApplePort._look_for_all_crash_logs_in_log_dir):
823         (ApplePort._get_crash_log):
824         (ApplePort.look_for_new_crash_logs):
825         (ApplePort.sample_process):
826         (ApplePort.sample_file_path):
827         (ApplePort.look_for_new_samples):
828         (ApplePort._path_to_helper):
829         (ApplePort.determine_full_port_name): Deleted.
830         * Scripts/webkitpy/port/ios.py:
831         (IOSSimulatorPort):
832         (IOSSimulatorPort.__init__):
833         (IOSSimulatorPort.default_timeout_ms): Deleted.
834         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
835         (IOSSimulatorPort.should_retry_crashes): Deleted.
836         (IOSSimulatorPort.check_for_leaks): Deleted.
837         (IOSSimulatorPort.print_leaks_summary): Deleted.
838         (IOSSimulatorPort._path_to_webcore_library): Deleted.
839         (IOSSimulatorPort.show_results_html_file): Deleted.
840         (IOSSimulatorPort.sample_file_path): Deleted.
841         (IOSSimulatorPort._merge_crash_logs): Deleted.
842         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
843         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
844         (IOSSimulatorPort.look_for_new_samples): Deleted.
845         (IOSSimulatorPort.sample_process): Deleted.
846         (IOSSimulatorPort._path_to_helper): Deleted.
847         (IOSSimulatorPort.make_command): Deleted.
848         * Scripts/webkitpy/port/mac.py:
849         (MacPort.__init__):
850         (MacPort.make_command):
851         (MacPort._build_java_test_support):
852         (MacPort): Deleted.
853         (MacPort.default_timeout_ms): Deleted.
854         (MacPort.supports_per_test_timeout): Deleted.
855         (MacPort.should_retry_crashes): Deleted.
856         (MacPort.default_child_processes): Deleted.
857         (MacPort.check_for_leaks): Deleted.
858         (MacPort.print_leaks_summary): Deleted.
859         (MacPort._path_to_webcore_library): Deleted.
860         (MacPort.show_results_html_file): Deleted.
861         (MacPort.sample_file_path): Deleted.
862         (MacPort._merge_crash_logs): Deleted.
863         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
864         (MacPort.look_for_new_crash_logs): Deleted.
865         (MacPort.look_for_new_samples): Deleted.
866         (MacPort.sample_process): Deleted.
867         (MacPort._path_to_helper): Deleted.
868         * Scripts/webkitpy/port/mac_unittest.py:
869         (MacTest.test_default_child_processes): Deleted.
870         * Scripts/webkitpy/port/win.py:
871         (WinPort.look_for_new_samples):
872         (WinPort):
873         (WinPort.sample_process):
874         (WinPort._make_leak_detector):
875         (WinPort.check_for_leaks):
876         (WinPort.print_leaks_summary):
877         (WinPort._path_to_webcore_library):
878
879 2016-08-08  Matt Baker  <mattbaker@apple.com>
880
881         Unreviewed: moved myself to the reviewers list.
882
883         * Scripts/webkitpy/common/config/contributors.json:
884
885 2016-08-08  Chris Dumez  <cdumez@apple.com>
886
887         Update API tests in mac/SetDocumentURI.mm after r204247
888         https://bugs.webkit.org/show_bug.cgi?id=160660
889
890         Reviewed by Alex Christensen.
891
892         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
893         (TestWebKitAPI::TEST):
894
895 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
896
897         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
898         https://bugs.webkit.org/show_bug.cgi?id=159827
899
900         Reviewed by Daniel Bates.
901
902         This change was spurred by a process hang which occurred between tests and did
903         not produce a meaningful crashlog.
904
905         * Scripts/webkitpy/port/driver.py:
906         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
907
908          * Scripts/webkitpy/port/ios.py:
909         (IOSSimulatorPort):
910         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
911         * Scripts/webkitpy/port/mac.py:
912         (MacPort):
913         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
914
915         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
916         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
917
918         * WebKitTestRunner/TestController.h:
919         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
920         * WebKitTestRunner/TestInvocation.cpp:
921         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
922
923 2016-08-07  Dan Bernstein  <mitz@apple.com>
924
925         [Cocoa] Reply block leaks if the remote object doesn’t call it
926         https://bugs.webkit.org/show_bug.cgi?id=160642
927
928         Reviewed by Sam Weinig.
929
930         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
931         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
932         (TEST): Added a test case that checks that the reply block is released even when it’s not
933           called.
934         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
935         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
936           calling the completion handler.
937
938 2016-08-07  Chris Dumez  <cdumez@apple.com>
939
940         Write API test to cover crash fix in r204135
941         https://bugs.webkit.org/show_bug.cgi?id=160587
942
943         Reviewed by Darin Adler.
944
945         Add API test to cover crash fix in r204135. This reproduces the crash
946         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
947         callback.
948
949         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
950         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
951         (TEST):
952
953 2016-08-06  Chris Dumez  <cdumez@apple.com>
954
955         Unreviewed, rolling out r204226.
956
957         Broke some API tests
958
959         Reverted changeset:
960
961         "Write API test to cover crash fix in r204135"
962         https://bugs.webkit.org/show_bug.cgi?id=160587
963         http://trac.webkit.org/changeset/204226
964
965 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
966
967         EWS Style Queue fails to process patches which fails validation
968         https://bugs.webkit.org/show_bug.cgi?id=160632
969
970         Reviewed by Alexey Proskuryakov.
971
972         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
973         (StyleQueueTask.validate): Add more information about validation failure.
974         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
975         * Scripts/webkitpy/tool/commands/queues_unittest.py:
976         (test_non_valid_patch): Add a unit test to test the above code path.
977
978 2016-08-06  Sam Weinig  <sam@webkit.org>
979
980         WTF needs a variant implementation
981         https://bugs.webkit.org/show_bug.cgi?id=160618
982
983         Reviewed by Darin Adler.
984
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
987         Add tests for the variant implementation.
988
989 2016-08-06  Chris Dumez  <cdumez@apple.com>
990
991         Write API test to cover crash fix in r204135
992         https://bugs.webkit.org/show_bug.cgi?id=160587
993
994         Reviewed by Darin Adler.
995
996         Add API test to cover crash fix in r204135. This reproduces the crash
997         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
998         callback.
999
1000         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1001         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1002         (TEST):
1003
1004 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1005
1006         run-api-tests should use a headed simulator
1007         https://bugs.webkit.org/show_bug.cgi?id=160611
1008
1009         Reviewed by Sam Weinig.
1010
1011         CADisplayLink doesn't work in a headless simulator, but is
1012         vital for the proper functioning of WebKit2 painting on iOS.
1013         So, we should not use a headless simulator.
1014
1015         * Scripts/run-api-tests:
1016         Launch a simulator app, don't just boot the simulator.
1017
1018         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1019         Re-enable a test that works now.
1020
1021 2016-08-05  Dan Bernstein  <mitz@apple.com>
1022
1023         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1024         https://bugs.webkit.org/show_bug.cgi?id=160589
1025
1026         Reviewed by Tim Horton.
1027
1028         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1029         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1030           blocks, which wasn’t caught because the test wasn’t run correctly.
1031         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1032         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1033           added a test that sends over an NSRange.
1034         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1035         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1036           handler with the range‘s location and length.
1037
1038 2016-08-05  Enrica Casucci  <enrica@apple.com>
1039
1040         Fixing tests failing after r204175.
1041
1042         Unreviewed.
1043
1044         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1045
1046 2016-08-05  Enrica Casucci  <enrica@apple.com>
1047
1048         Build fix after 204053.
1049
1050         Unreviewed.
1051
1052         * TestWebKitAPI/Configurations/Base.xcconfig:
1053         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1054         (-[MockContentFilterEnabler initWithCoder:]):
1055         (-[MockContentFilterEnabler dealloc]):
1056
1057 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1058
1059         Print test name in "Last character read from DRT..." error message.
1060         https://bugs.webkit.org/show_bug.cgi?id=160559
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         * Scripts/webkitpy/port/driver.py:
1065         (Driver.run_test):
1066         (Driver._read_first_block):
1067         (Driver._read_optional_image_block):
1068         (Driver._read_block):
1069         * Scripts/webkitpy/port/driver_unittest.py:
1070         (DriverTest.test_read_block):
1071         (DriverTest.test_read_binary_block):
1072         (DriverTest.test_read_base64_block):
1073
1074 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1075
1076         Unreviewed, rolling out r204123.
1077         https://bugs.webkit.org/show_bug.cgi?id=160597
1078
1079         Caused layout test timeouts on Windows. (Requested by perarne
1080         on #webkit).
1081
1082         Reverted changeset:
1083
1084         "[Win] Unable to reliably run tests in parallel"
1085         https://bugs.webkit.org/show_bug.cgi?id=140914
1086         http://trac.webkit.org/changeset/204123
1087
1088 2016-08-04  Saam Barati  <sbarati@apple.com>
1089
1090         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1091         https://bugs.webkit.org/show_bug.cgi?id=151241
1092
1093         Reviewed by Benjamin Poulain.
1094
1095         * Scripts/run-jsc-stress-tests:
1096
1097 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1098
1099         UI improvements to Flakiness Dashboard.
1100         https://bugs.webkit.org/show_bug.cgi?id=153295
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1105         (td.options-container): Center text in most fields.
1106         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1107         (createBugHTML): Text/Grammar updates.
1108         (tableHeaders): Ditto.
1109         (htmlForSingleTestRow): Ditto.
1110         (headerForTestTableHtml): Ditto.
1111         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1112         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1113
1114 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1115
1116         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1117         https://bugs.webkit.org/show_bug.cgi?id=160518
1118
1119         Reviewed by Michael Catanzaro.
1120
1121         * Scripts/webkitpy/thirdparty/__init__.py:
1122         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1123         * gtk/install-dependencies:
1124
1125 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1126
1127         Optimize bot watcher's dashboard a little
1128         https://bugs.webkit.org/show_bug.cgi?id=160515
1129         rdar://problem/26096900
1130
1131         Reviewed by Lucas Forschler.
1132
1133         Made re-sorting after loading an iteration more efficient.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1136         (BuildbotIteration.prototype._updateWithData):
1137         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1138         (BuildbotQueue.prototype.updateIterationPosition):
1139
1140 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1141
1142         [Win] Unable to reliably run tests in parallel
1143         https://bugs.webkit.org/show_bug.cgi?id=140914
1144
1145         Reviewed by Brent Fulgham.
1146
1147         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1148         processes. We can use string replacement to convert the Cygwin path to a Windows path
1149         instead.
1150  
1151         * Scripts/webkitpy/common/system/path.py:
1152         (cygpathFast):
1153         * Scripts/webkitpy/port/driver.py:
1154         (Driver._command_from_driver_input):
1155
1156 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1157
1158         Document instructions for increasing process and file limits
1159         https://bugs.webkit.org/show_bug.cgi?id=160528
1160         rdar://problem/24777576
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * Scripts/webkitpy/port/ios.py:
1165         (IOSSimulatorPort.default_child_processes):
1166
1167 2016-08-03  Anders Carlsson  <andersca@apple.com>
1168
1169         Remove the Objective-C bindings generator
1170         https://bugs.webkit.org/show_bug.cgi?id=160526
1171
1172         Reviewed by Sam Weinig.
1173
1174         * Scripts/run-bindings-tests:
1175         Update test.
1176
1177 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1178
1179         Revise a TestWebKitAPI comment to mention the actual underlying problem
1180
1181         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1182         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1183
1184 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1185
1186         Benchmark test content-animation timeouts always
1187         https://bugs.webkit.org/show_bug.cgi?id=160057
1188
1189         Reviewed by Simon Fraser.
1190
1191         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1192         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1193         (start):
1194
1195 2016-08-02  Nan Wang  <n_wang@apple.com>
1196
1197         AX: Simulated touch events are not working on iOS
1198         https://bugs.webkit.org/show_bug.cgi?id=160395
1199         <rdar://problem/27633597>
1200
1201         Reviewed by Chris Fleizach.
1202
1203         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1204         (WTR::AccessibilityUIElement::press):
1205         (WTR::AccessibilityUIElement::setSelectedChild):
1206
1207 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1208
1209         run-javascriptcore-tests should accept multiple --extra-tests
1210         https://bugs.webkit.org/show_bug.cgi?id=160486
1211
1212         Reviewed by Saam Barati.
1213         
1214         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1215         test suites. This does it by using GetOpt::Long's array support.
1216
1217         * Scripts/run-javascriptcore-tests:
1218         (runJSCStressTests):
1219
1220 2016-08-02  Enrica Casucci  <enrica@apple.com>
1221
1222         Allow building with content filtering disabled.
1223         https://bugs.webkit.org/show_bug.cgi?id=160454
1224
1225         Reviewed by Simon Fraser.
1226
1227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1228
1229 2016-08-02  Brady Eidson  <beidson@apple.com>
1230
1231         Removing IndexedDB WebsiteData can fail for some users.
1232         https://bugs.webkit.org/show_bug.cgi?id=160463
1233
1234         Reviewed by Alex Christensen.
1235
1236         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1237
1238 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1239
1240         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1241         https://bugs.webkit.org/show_bug.cgi?id=160437
1242         <rdar://problem/27578272>
1243
1244         Reviewed by Brady Eidson.
1245
1246         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1247         (-[DownloadDelegate _download:didReceiveResponse:]):
1248         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1249         (runTest):
1250         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1251
1252 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1253
1254         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1255         https://bugs.webkit.org/show_bug.cgi?id=160414
1256
1257         Reviewed by Michael Catanzaro.
1258
1259         * Scripts/webkitpy/port/linux_get_crash_log.py:
1260         (GDBCrashLogGenerator._wait_for_corefile):
1261
1262 2016-08-01  Youenn Fablet  <youenn@apple.com>
1263
1264         Make wpt server generate its certificates in layout test results folder
1265         https://bugs.webkit.org/show_bug.cgi?id=160422
1266
1267         Reviewed by Chris Dumez.
1268
1269         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1270         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1271
1272 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1273
1274         Function Call on NULL Object
1275         https://bugs.webkit.org/show_bug.cgi?id=160325
1276
1277         Reviewed by Darin Adler.
1278
1279         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1280         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1281         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1282
1283 2016-08-01  Keith Miller  <keith_miller@apple.com>
1284
1285         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1286         https://bugs.webkit.org/show_bug.cgi?id=160372
1287
1288         Rubber stamped by Geoffrey Garen.
1289
1290         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1291         a new top level directory, JSTests. Having the tests in the Source directory
1292         was both confusing an inconvenient for people that just want to checkout the
1293         source code of WebKit. Since there is no other obvious place to put all the
1294         JavaScript tests a new top level directory seemed the most sensible.
1295
1296         * Scripts/import-test262-tests:
1297         * Scripts/run-javascriptcore-tests:
1298         * Scripts/update-javascriptcore-test-res:
1299
1300 2016-07-31  Nan Wang  <n_wang@apple.com>
1301
1302         AX: Add a check for touch event listener on iOS accessibility object
1303         https://bugs.webkit.org/show_bug.cgi?id=160388
1304
1305         Reviewed by Chris Fleizach.
1306
1307         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1308         (AccessibilityUIElement::boolAttributeValue):
1309         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1310         (WTR::AccessibilityUIElement::boolAttributeValue):
1311
1312 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1313
1314         Unreviewed: add myself to the reviewers list.
1315
1316         * Scripts/webkitpy/common/config/contributors.json:
1317
1318 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1319
1320         Undo r203939, and copy over a rule that clips the logos.
1321
1322         Sierra wasn't the only logo without transparency.
1323
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1327
1328 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1329
1330         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1331         https://bugs.webkit.org/show_bug.cgi?id=160377
1332
1333         Reviewed by Brian Weinstein.
1334
1335         Update assets to remove the white background and use a transparent background instead.
1336
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1339
1340 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1341
1342         Ignore most check-webkit-style checks for ANGLE project
1343         <https://webkit.org/b/160333>
1344
1345         Reviewed by Daniel Bates.
1346
1347         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1348         - No tabs.
1349         - No spaces at the end of lines.
1350         - No carriage returns (DOS line endings).
1351
1352 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1353
1354         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1355         https://bugs.webkit.org/show_bug.cgi?id=160360
1356         <rdar://problem/27179484>
1357
1358         Reviewed by Myles C. Maxfield.
1359
1360         Adds two tests verifying that videos may be considered main content as long as they
1361         are large enough and cover a majority of the mainframe's viewport.
1362
1363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1364         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1365         (TestWebKitAPI::TEST):
1366         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1367         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1368
1369 2016-07-29  Mark Lam  <mark.lam@apple.com>
1370
1371         Gardening: removed unused variable.
1372
1373         Not reviewed.
1374
1375         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1376         (TestWebKitAPI::TEST):
1377
1378 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         Add TestWebKitAPI support for interacting with media controls
1381         https://bugs.webkit.org/show_bug.cgi?id=160342
1382         <rdar://problem/27610246>
1383
1384         Reviewed by Beth Dakin.
1385
1386         Adds support for testing interaction with some media controls, as well as a basic test
1387         verifying that media control teardown after interaction does not result in a crash.
1388
1389         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1390         (-[WKWebView mouseDownAtPoint:]):
1391         (-[WKWebView performAfterLoading:]):
1392         (TestWebKitAPI::TEST):
1393
1394 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1395
1396         Crash Log Clobbering on Unbound Crashes
1397         https://bugs.webkit.org/show_bug.cgi?id=160198
1398         <rdar://problem/27472618>
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * Scripts/webkitpy/common/system/crashlogs.py:
1403         (CrashLogs): Fix header order.
1404         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1405         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1406
1407 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1408
1409         Update for contributors.json
1410         https://bugs.webkit.org/show_bug.cgi?id=160294
1411
1412         * Scripts/webkitpy/common/config/contributors.json:
1413
1414 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1415
1416         Remove deprecated SPI for video inline / fullscreen controls
1417         https://bugs.webkit.org/show_bug.cgi?id=160318
1418
1419         Reviewed by Tim Horton.
1420
1421         * DumpRenderTree/mac/DumpRenderTree.mm:
1422         (setDefaultsToConsistentValuesForTesting): Deleted.
1423         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1424         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1425         * WebKitTestRunner/TestController.cpp:
1426         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1427         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1428         (WTR::initializeWebViewConfiguration): Deleted.
1429
1430 2016-07-28  Daniel Bates  <dabates@apple.com>
1431
1432         [iOS] TestWebKitAPI bundle targets are not code signed
1433         https://bugs.webkit.org/show_bug.cgi?id=160328
1434         <rdar://problem/27409246>
1435
1436         Reviewed by Andy Estes.
1437
1438         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1439         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1440         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1441
1442         * TestWebKitAPI/Configurations/Base.xcconfig:
1443
1444 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1445
1446         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1447
1448         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1449         (animatedResizeWebView):
1450         (TEST):
1451         This test times out only when run in the WebKit Testing simulator environment,
1452         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1453
1454 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1455
1456         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1457         https://bugs.webkit.org/show_bug.cgi?id=160289
1458         <rdar://problem/27553464>
1459
1460         Reviewed by Simon Fraser.
1461
1462         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1465         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1466         (-[AnimatedResizeWebView _endAnimatedResize]):
1467         (animatedResizeWebView):
1468         (TEST):
1469         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1470         Add two tests that ensure that hidden-content and animated resizes
1471         don't cause unnecessary synchronous waits. Only the hidden-content
1472         one fails before my patch, but it seemed reasonable to add both anyway.
1473
1474 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1475
1476         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1477         <https://webkit.org/b/83342>
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         * Scripts/webkitpy/common/checkout/scm/git.py:
1482         (Git.revisions_changing_file): Remove code to raise an exception
1483         when the file doesn't exist.  If a file was moved or renamed,
1484         then this caused the script to terminate, which was very
1485         frustrating when you wanted a list of reviewers.
1486         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1487         (SCMTest._shared_test_revisions_changing_file): Update test
1488         expectation to return an empty list of revisions.
1489         (test_create_patch_is_full_patch): Drive-by fix when running all
1490         webkitpy tests (including scm tests).
1491         * Scripts/webkitpy/common/checkout/scm/svn.py:
1492         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1493         return an empty array of revisions if this occurs.
1494
1495 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1496
1497         EWS error message "Error: * did not process patch" should include explanation
1498         https://bugs.webkit.org/show_bug.cgi?id=159903
1499         <rdar://problem/27410788>
1500
1501         Reviewed by Alexey Proskuryakov.
1502
1503         * QueueStatusServer/handlers/statusbubble.py:
1504         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1505         is not processed.
1506         * QueueStatusServer/handlers/processingtimesjson.py:
1507         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1508         of the code.
1509         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1510         (CommitQueueTask.validate): Add more information about validation failure.
1511         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1512         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1513         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1514         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1515         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1516         (PatchIsNotValid.__init__): Add the failure_message argument.
1517         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1518         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1519         failure details.
1520         * Scripts/webkitpy/tool/commands/queues.py:
1521         (CommitQueue.process_work_item): Same.
1522         (StyleQueue.review_patch): Same.
1523         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1524         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1525
1526 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1527
1528         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1529         https://bugs.webkit.org/show_bug.cgi?id=160262
1530
1531         Reviewed by Daniel Bates.
1532
1533         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1534         (-[LTRelayController installApp]):
1535
1536 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1537
1538         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1539         https://bugs.webkit.org/show_bug.cgi?id=160225
1540
1541         Reviewed by Alexey Proskuryakov.
1542
1543         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1544
1545 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1546
1547         [GTK] Fix some video/canvas tests that should be passing
1548         https://bugs.webkit.org/show_bug.cgi?id=160023
1549
1550         Reviewed by Carlos Garcia Campos.
1551
1552         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1553         EFL or GTK platforms.
1554
1555         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1556         (WTR::TestController::platformConfigureViewForTest):
1557         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1558         (WTR::TestController::platformConfigureViewForTest):
1559
1560 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1561
1562         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1563         https://bugs.webkit.org/show_bug.cgi?id=160247
1564
1565         Reviewed by Michael Catanzaro.
1566
1567         * BuildSlaveSupport/built-product-archive:
1568         (createZip):
1569         (dirContainsdwo):
1570         (archiveBuiltProduct):
1571
1572 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1573
1574         Fix tests after r203743.
1575         https://bugs.webkit.org/show_bug.cgi?id=156947
1576
1577         * WebKitTestRunner/TestController.cpp:
1578         (WTR::TestController::resetStateToConsistentValues):
1579         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1580
1581 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1582
1583         [iPhone] Playing a video on tudou.com plays only sound, no video
1584         https://bugs.webkit.org/show_bug.cgi?id=160178
1585         <rdar://problem/27535468>
1586
1587         Reviewed by Dan Bernstein.
1588
1589         * DumpRenderTree/mac/DumpRenderTree.mm:
1590         (setDefaultsToConsistentValuesForTesting):
1591         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1592         (RequiresUserActionForPlaybackTest::SetUp):
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::resetPreferencesToConsistentValues):
1595         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1596         (WTR::initializeWebViewConfiguration):
1597
1598 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1599
1600         Allow LOG macros to be used outside the namespace, and other logging cleanup
1601         https://bugs.webkit.org/show_bug.cgi?id=160216
1602
1603         Reviewed by Anders Carlsson.
1604         
1605         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1606
1607         * DumpRenderTree/TestRunner.cpp:
1608         * DumpRenderTree/mac/DumpRenderTree.mm:
1609         (resetWebViewToConsistentStateBeforeTesting):
1610
1611 2016-07-26  David Kilzer <ddkilzer@apple.com>
1612
1613         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1614         https://bugs.webkit.org/show_bug.cgi?id=156947
1615         <rdar://problem/23325160>
1616
1617         Reviewed by Alex Christensen.
1618
1619         * DumpRenderTree/TestRunner.cpp:
1620         (TestRunner::TestRunner):
1621         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1622         * DumpRenderTree/TestRunner.h:
1623         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1624         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1625         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1626         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1627         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1629         (WTR::TestRunner::queueNonLoadingScript):
1630         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1632         * WebKitTestRunner/TestController.cpp:
1633         (WTR::TestController::didReceiveAuthenticationChallenge):
1634         * WebKitTestRunner/TestController.h:
1635         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1636         * WebKitTestRunner/TestInvocation.cpp:
1637         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1638         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1639
1640 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1641
1642         check-for-exit-time-destructors should be usable outside Xcode
1643         <https://webkit.org/b/160195>
1644
1645         Reviewed by Darin Adler.
1646
1647         * Scripts/check-for-exit-time-destructors: Update to parse
1648         -h|--help switch, or to take one argument to a binary to check
1649         for exit time destructors on the command-line.  The clang
1650         compiler will find these at compile-time with the
1651         -Wexit-time-destructors switch, but this script will check for
1652         them after-the-fact.
1653
1654 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1655
1656         Test svn.webkit.org functionality after maintenance.
1657
1658 2016-07-25  Brady Eidson  <beidson@apple.com>
1659
1660         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1661         https://bugs.webkit.org/show_bug.cgi?id=153783
1662
1663         Reviewed by Alex Christensen.
1664
1665         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1666         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1667         
1668         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1669         
1670         Change the relevant API tests to make sure this continues to be no longer required.
1671
1672         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1673         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1674         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1676         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1677         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1678
1679 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1680
1681         Media controls should not be displayed for a video until it starts playing
1682         https://bugs.webkit.org/show_bug.cgi?id=160092
1683         <rdar://problem/26986673>
1684
1685         Reviewed by Beth Dakin.
1686
1687         Verify that multiple videos do or don't show the media controller depending on whether videos
1688         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1689         passing because we were always showing media controls for large videos with audio, even if they
1690         had not played back yet. This change ensures that large videos with audio show media controls
1691         only after they begin to play back, and not by virtue of being large enough for main content.
1692
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1695         (TestWebKitAPI::TEST):
1696         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1697         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1698         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1699
1700 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1701
1702         Media controls on apple.com don't disappear when movie finishes playing
1703         https://bugs.webkit.org/show_bug.cgi?id=160068
1704         <rdar://problem/26668526>
1705
1706         Reviewed by Darin Adler.
1707
1708         Adds new API tests. Please see WebCore ChangeLog for more details.
1709
1710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1712         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1713         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1714         (TestWebKitAPI::TEST):
1715         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1716         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1717         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1718         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1719         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1720
1721 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1722
1723         Unreviewed, fix test-webkitpy after r203674.
1724
1725         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1726         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1727
1728 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1729
1730         Unreviewed, forgot to commit this file in r203674.
1731
1732         * Scripts/process-linux-coredump: Added.
1733         (main):
1734
1735 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1736
1737         Improve GDB backtrace generation for GTK/EFL
1738         https://bugs.webkit.org/show_bug.cgi?id=128928
1739
1740         Reviewed by Carlos Garcia Campos.
1741
1742         The PID of the crashed process is now correctly supplied to the
1743         crash log reporter. The kernel core_pattern needs to be updated
1744         after this change to something like:
1745
1746         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1747
1748         * Scripts/process-linux-coredump: Added.
1749         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1750         * Scripts/webkitpy/port/efl.py:
1751         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1752         * Scripts/webkitpy/port/gtk.py:
1753         (GtkPort._get_crash_log): Ditto.
1754         * Scripts/webkitpy/port/linux_get_crash_log.py:
1755         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1756         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1757         (GDBCrashLogGenerator): Deleted.
1758         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1759         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1760         * WebKitTestRunner/TestController.cpp:
1761         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1762         (WTR::TestController::databaseProcessDidCrash): Ditto.
1763         (WTR::TestController::processDidCrash): Ditto.
1764
1765 2016-07-23  Youenn Fablet  <youenn@apple.com>
1766
1767         WPT stash server should be kept running when launching wpt server
1768         https://bugs.webkit.org/show_bug.cgi?id=160052
1769
1770         Reviewed by Sam Weinig.
1771
1772         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1773         (main): waiting to read stdin while stash server is started.
1774
1775 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1776
1777         Media controls should be displayed for media in media documents
1778         https://bugs.webkit.org/show_bug.cgi?id=160104
1779         <rdar://problem/27438936>
1780
1781         Reviewed by Myles C. Maxfield.
1782
1783         Verifies that even a small video with audio in a media document gets media controls.
1784
1785         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1786         (TestWebKitAPI::TEST):
1787
1788 2016-07-22  Michael Saboff  <msaboff@apple.com>
1789
1790         REGRESSION(203616): no FTL testing was inadvertently removed
1791         https://bugs.webkit.org/show_bug.cgi?id=160100
1792
1793         Rubber-stamped by Filip Pizlo.
1794
1795         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1796         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1797         logic for the runLayout and runNoisy variants to match the run test logic,
1798         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1799         enabled platforms.
1800
1801         * Scripts/run-jsc-stress-tests:
1802
1803 2016-07-22  Brady Eidson  <beidson@apple.com>
1804
1805         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1806         https://bugs.webkit.org/show_bug.cgi?id=160089
1807
1808         Reviewed by Darin Adler.
1809
1810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1811         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1812         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1813
1814 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1815
1816         [GTK] Improved exclusion patterns in make-dist.py manifest.
1817         https://bugs.webkit.org/show_bug.cgi?id=160094
1818
1819         Reviewed by Michael Catanzaro.
1820
1821         * gtk/manifest.txt.in:
1822         Exclude Platform*.cmake files for more ports.
1823         Removed obsolete .gyp and .pro.user patterns.
1824         Exclude 'Configurations' and 'spi' directories.
1825         Exclude CMakeLists.txt.user (Qt Creator IDE).
1826
1827 2016-07-22  Michael Saboff  <msaboff@apple.com>
1828
1829         Don't run FTL related JSC stress tests on non-FTL platforms
1830         https://bugs.webkit.org/show_bug.cgi?id=160033
1831
1832         Reviewed by Mark Lam.
1833
1834         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1835         Refactored several of the runXXX test methods to always runXXXDefault and made those
1836         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1837         doesn't cause a problem.
1838
1839         * Scripts/run-jsc-stress-tests:
1840
1841 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1842
1843         IWebView::mainFrame crashes if called after IWebView::close
1844         https://bugs.webkit.org/show_bug.cgi?id=32868
1845
1846         Reviewed by Brent Fulgham.
1847
1848         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1849         (TestWebKitAPI::TEST_F): Added test.
1850
1851 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1852
1853         [GTK] Enable threaded compositor by default
1854         https://bugs.webkit.org/show_bug.cgi?id=160079
1855
1856         Reviewed by Žan Doberšek.
1857
1858         * Scripts/webkitperl/FeatureList.pm:
1859
1860 2016-07-22  Youenn Fablet  <youenn@apple.com>
1861
1862         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1863         https://bugs.webkit.org/show_bug.cgi?id=159921
1864
1865         Reviewed by Brian Burg.
1866
1867         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1868
1869         * Scripts/webkitpy/codegen/main.py:
1870         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1871         (BuiltinsGeneratorTests):
1872         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1873         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1874         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1875         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1876
1877 2016-07-21  Dan Bernstein  <mitz@apple.com>
1878
1879         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1880         https://bugs.webkit.org/show_bug.cgi?id=160072
1881
1882         Reviewed by Andy Estes.
1883
1884         * Scripts/webkitdirs.pm:
1885         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1886           for old Xcode versions.
1887         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1888           to readXcodeUserDefault.
1889         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1890           debugger.
1891         (determineDebugger): Ditto.
1892         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1893           7.0.
1894         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1895           switches.
1896         (execMacWebKitAppForDebugging): Removed support for GDB.
1897
1898 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1899
1900         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1901         https://bugs.webkit.org/show_bug.cgi?id=160066
1902
1903         Reviewed by Dean Jackson.
1904
1905         * DumpRenderTree/mac/DumpRenderTree.mm:
1906         (setDefaultsToConsistentValuesForTesting): Deleted.
1907         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1908         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1909         * WebKitTestRunner/TestController.cpp:
1910         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1911         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1912         (WTR::initializeWebViewConfiguration): Deleted.
1913
1914 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1915
1916         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1917         https://bugs.webkit.org/show_bug.cgi?id=159980
1918         rdar://problem/27450825
1919
1920         Reviewed by Dan Bernstein.
1921
1922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1923         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1924         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1925         when our delegate has hit -dealloc.
1926         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1927         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1928         will not be messaged.
1929
1930 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1931
1932         Follow-up patch to r203520
1933         https://bugs.webkit.org/show_bug.cgi?id=159967
1934         <rdar://problem/26964090>
1935
1936         Unreviewed.
1937
1938         * DumpRenderTree/mac/DumpRenderTree.mm:
1939         (setDefaultsToConsistentValuesForTesting):
1940         * WebKitTestRunner/TestController.cpp:
1941         (WTR::TestController::resetPreferencesToConsistentValues):
1942
1943 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1944
1945         [iPhone] Playing a video on tudou.com plays only sound, no video
1946         https://bugs.webkit.org/show_bug.cgi?id=159967
1947         <rdar://problem/26964090>
1948
1949         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1950
1951         Migrate tests to use new SPI.
1952
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1954         (RequiresUserActionForPlaybackTest::SetUp):
1955         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1956         (WTR::initializeWebViewConfiguration):
1957
1958 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1959
1960         Clarify testing mode names in run-jsc-stress-tests
1961         https://bugs.webkit.org/show_bug.cgi?id=160021
1962
1963         Reviewed by Mark Lam.
1964
1965         Default should mean really default, not default with disabled FTL, renamed
1966         - runMozillaTestDefault to runMozillaTestNoFTL
1967         - runMozillaTestDefaultFTL to runMozillaTestDefault
1968         - runDefault to runNoFTL
1969         - runDefaultFTL to runDefault
1970         - runLayoutTestDefault to runLayoutTestNoFTL
1971         - runLayoutTestDefaultFTL to runLayoutTestDefault
1972         - runNoisyTestDefault to runNoisyTestNoFTL
1973         - runNoisyTestDefaultFTL to runNoisyTestDefault
1974
1975         * Scripts/run-jsc-stress-tests:
1976
1977 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1978
1979         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1980         https://bugs.webkit.org/show_bug.cgi?id=159986
1981
1982         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1983         to 0.
1984
1985         Reviewed by Dan Bernstein.
1986
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1989         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1990         (TEST):
1991
1992 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1993
1994         [GTK] Web view background colors don't work in accelerated compositing mode
1995         https://bugs.webkit.org/show_bug.cgi?id=159455
1996
1997         Reviewed by Michael Catanzaro.
1998
1999         Set always RGBA visual to the view widget when setting a background color.
2000
2001         * MiniBrowser/gtk/BrowserWindow.c:
2002         (browser_window_set_background_color):
2003
2004 2016-07-20  Youenn Fablet  <youenn@apple.com>
2005
2006         Bots should run built-ins generator tests
2007         https://bugs.webkit.org/show_bug.cgi?id=159971
2008
2009         Reviewed by Alexey Proskuryakov.
2010
2011         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2012         (RunBuiltinsTests): New step to run built-in generator tests.
2013         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2014         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2016
2017 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2018
2019         Revert temporary fix r203417
2020         https://bugs.webkit.org/show_bug.cgi?id=160001
2021
2022         Reviewed by Alexey Proskuryakov.
2023
2024         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2025
2026 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2027
2028         REGRESSION(r148588): ews classes might get garbage collected
2029         https://bugs.webkit.org/show_bug.cgi?id=159990
2030
2031         Reviewed by Ryosuke Niwa.
2032
2033         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2034         in a variable so that they do not get garbage collected.
2035
2036 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2037
2038         Add API test for layout constraints after exit fullscreen
2039         https://bugs.webkit.org/show_bug.cgi?id=159900
2040
2041         Reviewed by Jon Lee.
2042
2043         Added Fullscreen.LaytoutConstraints API test. 
2044         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2045
2046         This test compares layout constraints on the web view before and after fullscreen to make sure 
2047         they are preserved.
2048
2049         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2050         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2051         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2052         (TestWebKitAPI::TEST):
2053
2054 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2055
2056         Disable two failing API tests.
2057
2058         Unreviewed test gardening.
2059
2060         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2061         (TestWebKitAPI::TEST):
2062
2063 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2064
2065         Unreviewed iOS build fix.
2066
2067         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2068
2069 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2070
2071         Media controls don't appear when pausing a small autoplaying video
2072         https://bugs.webkit.org/show_bug.cgi?id=159972
2073         <rdar://problem/27180657>
2074
2075         Reviewed by Beth Dakin.
2076
2077         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2078         for simulating basic user interaction in VideoControlsManager.
2079
2080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2081         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2082         (-[WKWebView mouseDownAtPoint:]):
2083         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2084         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2085         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2086         (TestWebKitAPI::TEST):
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2088
2089 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2090
2091         [Win] MathML fonts are not found.
2092         https://bugs.webkit.org/show_bug.cgi?id=159920
2093
2094         Reviewed by Alex Christensen.
2095
2096         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2097         for a specific registry key value.
2098
2099         * Scripts/webkitdirs.pm:
2100         (fontExists):
2101
2102 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2103
2104         Improve prepare-ChangeLog for @media blocks
2105         https://bugs.webkit.org/show_bug.cgi?id=159907
2106
2107         Reviewed by Timothy Hatcher.
2108
2109         * Scripts/prepare-ChangeLog:
2110         (get_selector_line_ranges_for_css):
2111         Get a range for @media blocks just like a selector.
2112             Start Line = line with '{'
2113             End line = line with '}'
2114             Name = "@media ..."
2115
2116         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2117         Improved error messages for unbalanced portions.
2118
2119         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2120         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2121         (.media-query::before):
2122         (@media only screen and (max-width: 980px)):
2123         (.media-query a):
2124         (@media (-webkit-min-device-pixel-ratio: 2)):
2125         (.both a):
2126         (.both b):
2127         (.media-query b):
2128         (.media-query::after):
2129
2130 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2131
2132         Fix expectedFailErrorHandler in run-jsc-stress-tests
2133         https://bugs.webkit.org/show_bug.cgi?id=159811
2134
2135         Reviewed by Yusuke Suzuki.
2136
2137         * Scripts/run-jsc-stress-tests:
2138
2139 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2140
2141         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2142
2143         * TestWebKitAPI/PlatformMac.cmake:
2144
2145 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2146
2147         The default testing mode should not involve disabling the FTL JIT
2148         https://bugs.webkit.org/show_bug.cgi?id=159929
2149
2150         Rubber stamped by Mark Lam and Saam Barati.
2151         
2152         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2153         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2154         FTL was not the default. You had to enable it with an option.
2155         
2156         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2157         all of the major ports. This has become a serious pain. For example, it's useful to be able
2158         to say that a test should only run in the default config that is representative of what a
2159         normal user would see if they ran JSC. Clearly, this would be a config that does not
2160         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2161         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2162         
2163         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2164         try to fix it, because:
2165         
2166         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2167           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2168           doesn't do anything. The code is not really structured to allow this.
2169         
2170         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2171           disabled in testing. On the other hand there are already build bots that do FTL tests
2172           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2173           preserving this broken feature, we should create something that (a) acknowledges the fact
2174           that the FTL is the default on those platforms that support it and (b) avoids running
2175           no-ftl tests on precisely those platforms that don't have FTL.
2176         
2177         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2178           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2179           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2180           pretending that the FTL JIT is not the default just because some bots used that as an
2181           optimization.
2182         
2183         This change allows me to speed up some debug tests and paint some bots green.
2184
2185         * Scripts/run-javascriptcore-tests:
2186         (runJSCStressTests):
2187         * Scripts/run-jsc-stress-tests:
2188
2189 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2190
2191         Fix API test after r203426.
2192         https://bugs.webkit.org/show_bug.cgi?id=159949
2193
2194         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2195         (TEST):
2196         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2197         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2198
2199 2016-07-19  Andy Estes  <aestes@apple.com>
2200
2201         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2202         https://bugs.webkit.org/show_bug.cgi?id=159956
2203
2204         Reviewed by Dan Bernstein.
2205
2206         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2207         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2208         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2209         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2210
2211 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2212
2213         Add regression test for r203392
2214         https://bugs.webkit.org/show_bug.cgi?id=159949
2215
2216         Reviewed by Brady Eidson.
2217
2218         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2219         (fileSize):
2220         (swizzledBundleIdentifierWebBookmarksD):
2221         (defaultApplicationCacheDirectory):
2222         (TEST):
2223         (swizzledBundleIdentifierMobileSafari): Deleted.
2224         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2225         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2226         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2227
2228 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2229
2230         Add regression test for r203392
2231         https://bugs.webkit.org/show_bug.cgi?id=159949
2232
2233         Reviewed by Brady Eidson.
2234
2235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2236         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2238         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2239         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2240         (TEST):
2241         (fileSize):
2242         (swizzledBundleIdentifierMobileSafari):
2243         (swizzledBundleIdentifierWebBookmarksD):
2244         (defaultApplicationCacheDirectory):
2245         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2246         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2247         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2248         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2249
2250 2016-07-19  Keith Miller  <keith_miller@apple.com>
2251
2252         Test262 should have a file with the revision and url
2253         https://bugs.webkit.org/show_bug.cgi?id=159937
2254
2255         Reviewed by Mark Lam.
2256
2257         The import script should update the information from
2258         the path to the test262 repository it gets.
2259
2260         * Scripts/import-test262-tests:
2261
2262 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2263
2264         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2265         To be deleted once the root cause is found and addressed.
2266
2267         * EWSTools/start-queue-mac.sh:
2268
2269 2016-07-19  Frederic Wang  <fwang@igalia.com>
2270
2271         [win] Fixup the register name for STIX Math and Latin Modern Math
2272
2273         Unreviewed follow-up of r203406
2274
2275         * Scripts/webkitdirs.pm:
2276         (checkInstalledTools):
2277
2278 2016-07-19  Frederic Wang  <fwang@igalia.com>
2279
2280         [win] Update the list of MathML fonts
2281         https://bugs.webkit.org/show_bug.cgi?id=156838
2282
2283         The set of recommended math fonts is now described at
2284         https://trac.webkit.org/wiki/MathML/Fonts
2285         We update the Perl script to use the latest list of fonts.
2286
2287         Reviewed by Brent Fulgham.
2288
2289         * Scripts/webkitdirs.pm:
2290         (checkInstalledTools):
2291
2292 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2293
2294         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2295         https://bugs.webkit.org/show_bug.cgi?id=159342
2296
2297         Reviewed by Darin Adler.
2298
2299         Implement required functions in event sender.
2300
2301         * DumpRenderTree/PlatformWin.cmake:
2302         * DumpRenderTree/win/EventSender.cpp:
2303         (monitorWheelEvents): Added.
2304         (callAfterScrollingCompletes): Added.
2305
2306 2016-07-19  Youenn Fablet  <youenn@apple.com>
2307
2308         Add new aliases to http test server
2309         https://bugs.webkit.org/show_bug.cgi?id=159878
2310
2311         Reviewed by Darin Adler.
2312
2313         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2314         Adding explicitly these links to perl script.
2315         Extracting default alias in an aliases.json file.
2316         Reading that file from python scripts to initialize aliases from that file.
2317
2318         Python script changes covered by unit tests and changed layout test.
2319
2320         * Scripts/webkitperl/httpd.pm:
2321         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2322         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2323         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2324         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2325         Adding -c directives for each alias.
2326         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2327         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2328         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2329         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2330         Adding alias directive for each alias.
2331         (Lighttpd._prepare_config):
2332         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2333         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2334         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2335         layout tests directory.
2336         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2337         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2338         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2339
2340 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2341
2342         EWS console logs doesn't go to log file
2343         https://bugs.webkit.org/show_bug.cgi?id=159539
2344         <rdar://problem/24464570>
2345
2346         Reviewed by David Kilzer.
2347
2348         * Scripts/webkitpy/common/system/logutils.py:
2349         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2350         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2351         to filesystem. It also supports passing MockFilesystem.
2352         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2353         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2354         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2355         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2356         (_test_ews): Same.
2357         * Scripts/webkitpy/tool/commands/queues.py:
2358         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2359         (AbstractQueue._log_directory): Using filesystem object instead of os.
2360         (AbstractQueue.queue_log_path): Same.
2361         (AbstractQueue.__init__): Passed host parameter.
2362         (PatchProcessingQueue.__init__): Same.
2363         (CommitQueue.__init__): Same.
2364         (AbstractReviewQueue.__init__): Same.
2365         (StyleQueue.__init__): Same.
2366         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2367         (TestCommitQueue): Passed MockHost() as host.
2368         (TestCommitQueue.__init__): Same.
2369         (TestQueue.__init__): Same.
2370         (TestReviewQueue.__init__): Same.
2371         (TestFeederQueue.__init__): Same.
2372         (AbstractPatchQueueTest.test_next_patch): Same.
2373         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2374         (test_commit_queue_failure): Same.
2375         (MockCommitQueueTask.results_from_patch_test_run): Same.
2376         (test_rollout_lands): Same.
2377         (test_non_valid_patch): Same.
2378         (test_auto_retry): Same.
2379         (test_style_queue_with_watch_list_exception): Same.
2380
2381 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2382
2383         WTF::Lock should be fair eventually
2384         https://bugs.webkit.org/show_bug.cgi?id=159384
2385
2386         Reviewed by Geoffrey Garen.
2387
2388         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2389
2390 2016-07-17  Sam Weinig  <sam@webkit.org>
2391
2392         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2393         <rdar://problem/26554137>
2394         https://bugs.webkit.org/show_bug.cgi?id=159856
2395
2396         Reviewed by Dan Bernstein.
2397
2398         * MiniBrowser/mac/WK2BrowserWindowController.m:
2399         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2400         Add basic window.open implementation.
2401
2402         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2403         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2404         to open a single non-web URL, all others are dropped.
2405
2406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2407         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2408         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2409         Add API for the new SPI.
2410
2411 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2412
2413         [JSC] Enable test262 module tests
2414         https://bugs.webkit.org/show_bug.cgi?id=159854
2415
2416         Reviewed by Saam Barati.
2417
2418         Use --module-file instead.
2419
2420         * Scripts/run-jsc-stress-tests:
2421
2422 2016-07-16  Chris Dumez  <cdumez@apple.com>
2423
2424         Unreviewed, rolling out r203318.
2425
2426         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2427         SunSpider)
2428
2429         Reverted changeset:
2430
2431         "[JSC] Change some parameters based on a random search"
2432         https://bugs.webkit.org/show_bug.cgi?id=158514
2433         http://trac.webkit.org/changeset/203318
2434
2435 2016-07-16  Chris Dumez  <cdumez@apple.com>
2436
2437         Add move constructor / assignment operator to ListHashSet
2438         https://bugs.webkit.org/show_bug.cgi?id=159837
2439
2440         Reviewed by Darin Adler.
2441
2442         Add API tests.
2443
2444         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2445         (TestWebKitAPI::TEST):
2446
2447 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2448
2449         [JSC] Change some parameters based on a random search
2450         https://bugs.webkit.org/show_bug.cgi?id=158514
2451
2452         Reviewed by Saam Barati.
2453
2454         * Scripts/run-jsc-stress-tests:
2455
2456 2016-07-15  Jon Davis  <jond@apple.com>
2457
2458         Changed the start page URL for WebKit Nightly builds.
2459         https://bugs.webkit.org/show_bug.cgi?id=159816
2460
2461         Reviewed by Timothy Hatcher.
2462
2463         * WebKitLauncher/start.html:
2464
2465 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2466
2467         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2468         https://bugs.webkit.org/show_bug.cgi?id=159414
2469
2470         Reviewed by Brent Fulgham.
2471
2472         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2473         when the HDC parameter is invalid.
2474
2475         * TestWebKitAPI/PlatformWin.cmake:
2476         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2477         (TestWebKitAPI::TEST):
2478
2479 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         [GTK] Add basic tabs support to MiniBrowser
2482         https://bugs.webkit.org/show_bug.cgi?id=159803
2483
2484         Reviewed by Sergio Villar Senin.
2485
2486         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2487         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2488
2489         * MiniBrowser/gtk/BrowserTab.c: Added.
2490         (titleChanged):
2491         (isLoadingChanged):
2492         (decidePolicy):
2493         (removeChildIfInfoBar):
2494         (loadChanged):
2495         (createInfoBarQuestionMessage):
2496         (tlsErrorsDialogResponse):
2497         (loadFailedWithTLSerrors):
2498         (permissionRequestDialogResponse):
2499         (decidePermissionRequest):
2500         (colorChooserRGBAChanged):
2501         (popoverColorClosed):
2502         (colorChooserRequestFinished):
2503         (runColorChooserCallback):
2504         (inspectorOpenedInWindow):
2505         (inspectorClosed):
2506         (browserTabSetProperty):
2507         (browserTabFinalize):
2508         (browser_tab_init):
2509         (browserTabConstructed):
2510         (browser_tab_class_init):
2511         (getInternalURI):
2512         (browser_tab_new):
2513         (browser_tab_get_web_view):
2514         (browser_tab_load_uri):
2515         (browser_tab_get_title_widget):
2516         (browser_tab_set_status_text):
2517         (browser_tab_toggle_inspector):
2518         (browser_tab_start_search):
2519         (browser_tab_stop_search):
2520         (browser_tab_add_accelerators):
2521         (fullScreenMessageTimeoutCallback):
2522         (browser_tab_enter_fullscreen):
2523         (browser_tab_leave_fullscreen):
2524         * MiniBrowser/gtk/BrowserTab.h: Added.
2525         * MiniBrowser/gtk/BrowserWindow.c:
2526         (getExternalURI):
2527         (browserWindowSetStatusText):
2528         (reloadOrStopCallback):
2529         (goBackCallback):
2530         (goForwardCallback):
2531         (settingsCallback):
2532         (webViewURIChanged):
2533         (browserWindowHistoryItemActivated):
2534         (browserWindowUpdateNavigationActions):
2535         (webViewCreate):
2536         (webViewEnterFullScreen):
2537         (webViewLeaveFullScreen):
2538         (webViewDecidePolicy):
2539         (browserWindowCanZoomIn):
2540         (browserWindowCanZoomOut):
2541         (browserWindowZoomIn):
2542         (browserWindowZoomOut):
2543         (scrollEventCallback):
2544         (faviconChanged):
2545         (webViewIsLoadingChanged):
2546         (defaultZoomCallback):
2547         (searchCallback):
2548         (newTabCallback):
2549         (toggleWebInspector):
2550         (reloadPage):
2551         (reloadPageIgnoringCache):
2552         (stopPageLoad):
2553         (loadHomePage):
2554         (editingCommandCallback):
2555         (insertImageCommandCallback):
2556         (insertLinkCommandCallback):
2557         (browserWindowSetupEditorToolbar):
2558         (browserWindowSwitchTab):
2559         (browserWindowTabAddedOrRemoved):
2560         (browser_window_init):
2561         (browserWindowConstructed):
2562         (browserWindowSaveSession):
2563         (browserWindowDeleteEvent):
2564         (browser_window_new):
2565         (browser_window_append_view):
2566         (browser_window_load_uri):
2567         (browser_window_load_session):
2568         (browser_window_set_background_color):
2569         (resetStatusText): Deleted.
2570         (activateUriEntryCallback): Deleted.
2571         (webViewTitleChanged): Deleted.
2572         (resetEntryProgress): Deleted.
2573         (browserWindowCreateBackForwardMenu): Deleted.
2574         (webViewReadyToShow): Deleted.
2575         (webViewLoadFailed): Deleted.
2576         (webViewMouseTargetChanged): Deleted.
2577         (browserWindowUpdateZoomActions): Deleted.
2578         (webViewZoomLevelChanged): Deleted.
2579         (updateUriEntryIcon): Deleted.
2580         (zoomInCallback): Deleted.
2581         (zoomOutCallback): Deleted.
2582         (toggleFullScreen): Deleted.
2583         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2584         (browserWindowFinalize): Deleted.
2585         (browser_window_class_init): Deleted.
2586         * MiniBrowser/gtk/BrowserWindow.h:
2587         * MiniBrowser/gtk/CMakeLists.txt:
2588         * MiniBrowser/gtk/main.c:
2589         (createBrowserTab):
2590         (aboutURISchemeRequestCallback):
2591         (main):
2592         (parseBackgroundColor): Deleted.
2593
2594 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2595
2596         Allow RefPtrs of const RefCounted types
2597         https://bugs.webkit.org/show_bug.cgi?id=158269
2598
2599         Reviewed by Anders Carlsson.
2600
2601         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2602         (TestWebKitAPI::TEST):
2603         (TestWebKitAPI::ConstRefCounted::create):
2604         (TestWebKitAPI::returnConstRefCountedRef):
2605         (TestWebKitAPI::returnRefCountedRef):
2606
2607 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         Test WTF.StringViewIterators is crashing since r203119
2610         https://bugs.webkit.org/show_bug.cgi?id=159710
2611
2612         Reviewed by Darin Adler.
2613
2614         There are two problems in the test case added in r203119. First is that it's testing
2615         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2616         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2617         const reference to the string view member of the deleted CodePoints object.
2618
2619         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2620         (TestWebKitAPI::TEST):
2621
2622 2016-07-13  Daniel Bates  <dabates@apple.com>
2623
2624         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2625         https://bugs.webkit.org/show_bug.cgi?id=159738
2626         <rdar://problem/27304649>
2627
2628         Reviewed by Dan Bernstein.
2629
2630         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2631         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2632         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2633         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2634
2635         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2636         * WebKitTestRunner/ios/TestControllerIOS.mm:
2637         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2638         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2639
2640 2016-07-13  Beth Dakin  <bdakin@apple.com>
2641
2642         Attempted build fix.
2643
2644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2645
2646 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2647
2648         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2649         https://bugs.webkit.org/show_bug.cgi?id=159686
2650
2651         Reviewed by Chris Dumez.
2652
2653         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2654
2655         * WebKitTestRunner/TestController.cpp:
2656         (WTR::runOpenPanel):
2657         (WTR::TestController::createOtherPage):
2658         (WTR::TestController::createWebViewWithOptions):
2659
2660 2016-07-13  Beth Dakin  <bdakin@apple.com>
2661
2662         Add more candidate tests
2663         https://bugs.webkit.org/show_bug.cgi?id=159730
2664
2665         Reviewed by Tim Horton.
2666
2667         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2668         two new tests to that file.
2669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2670         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2671         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2672         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2673         (TestWebKitAPI::TEST):
2674         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2675
2676 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2677
2678         AX: [ATK] spinbutton-crash.html fails
2679         https://bugs.webkit.org/show_bug.cgi?id=159723
2680
2681         Reviewed by Chris Fleizach.
2682
2683         Implement support for AXDecrementButton and AXIncrementButton in
2684         ATK's AccessibilityUIElement::uiElementAttributeValue().
2685
2686         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2687         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2688
2689 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2690
2691         [EFL] [GTK] Enable back crypto subtle on development builds.
2692         https://bugs.webkit.org/show_bug.cgi?id=159260
2693
2694         Reviewed by Carlos Garcia Campos.
2695
2696         * Scripts/webkitperl/FeatureList.pm:
2697
2698 2016-07-12  Mark Lam  <mark.lam@apple.com>
2699
2700         We should use different stack limits for stack checks from JS and host code.
2701         https://bugs.webkit.org/show_bug.cgi?id=159442
2702         <rdar://problem/26889188>
2703
2704         Reviewed by Geoffrey Garen.
2705
2706         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2707         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2708         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2709         order to keep the js/regress-139548.html test happy with this patch.
2710
2711         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2712         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2713
2714         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2715         (-[LTRelayController _environmentVariables]):
2716         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2717         (main):
2718
2719 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2720
2721         platformUserPreferredLanguages on Mac should not try to put the region into the language
2722         https://bugs.webkit.org/show_bug.cgi?id=159693
2723
2724         Rubber stamped by Alexey Proskuryakov.
2725         
2726         Revert the test change in r200105.
2727
2728         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2729         (TestWebKitAPI::languageForSystemLanguage):
2730
2731 2016-07-12  Chris Dumez  <cdumez@apple.com>
2732
2733         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2734         https://bugs.webkit.org/show_bug.cgi?id=159663
2735         <rdar://problem/18995873>
2736
2737         Reviewed by Benjamin Poulain.
2738
2739         Add API test coverage.
2740
2741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2743         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2744         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2745         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2746         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2747         (TEST):
2748
2749 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2750
2751         Relax ordering requirements on StringView::CodePoints iterator
2752         https://bugs.webkit.org/show_bug.cgi?id=159609
2753
2754         Reviewed by Darin Adler.
2755
2756         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2757         (TestWebKitAPI::TEST):
2758
2759 2016-07-12  Youenn Fablet  <youenn@apple.com>
2760
2761         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2762         https://bugs.webkit.org/show_bug.cgi?id=159564
2763
2764         Reviewed by Brian Burg.
2765
2766         * Scripts/webkitpy/codegen/main.py:
2767         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2768
2769 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2770
2771         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2772         https://bugs.webkit.org/show_bug.cgi?id=159671
2773
2774         Reviewed by Csaba Osztrogonác.
2775
2776         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2777         https://bugs.webkit.org/show_bug.cgi?id=89235
2778
2779         So this guard can be removed in build scripts.
2780
2781         * Scripts/webkitperl/FeatureList.pm:
2782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2783
2784 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2785
2786         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2787         https://bugs.webkit.org/show_bug.cgi?id=159652
2788
2789         Reviewed by Daniel Bates.
2790
2791         * Scripts/webkitpy/common/checkout/scm/svn.py:
2792         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2793
2794 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2795
2796         Implement grapheme cluster iterator on StringView
2797         https://bugs.webkit.org/show_bug.cgi?id=159598
2798
2799         Reviewed by Anders Carlsson.
2800
2801         This is in preparation for honoring the second argument to FontFaceSet.load().
2802
2803         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2804         (TestWebKitAPI::compareLoopIterations):
2805         (TestWebKitAPI::TEST):
2806
2807 2016-07-11  Nan Wang  <n_wang@apple.com>
2808
2809         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2810         https://bugs.webkit.org/show_bug.cgi?id=158364
2811
2812         Reviewed by Anders Carlsson.
2813
2814         Added a function in TestRunner so that we can toggle the ignoring viewport
2815         scale limits setting. Also added a test option for that in order to change the 
2816         configuration of the webview in test.
2817
2818         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2819         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2820         (WTR::TestRunner::setNavigationGesturesEnabled):
2821         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2822         (WTR::nextUIScriptCallbackID):
2823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2824         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2825         * WebKitTestRunner/TestController.cpp:
2826         (WTR::TestController::resetStateToConsistentValues):
2827         (WTR::updateTestOptionsFromTestHeader):
2828         (WTR::TestController::setNavigationGesturesEnabled):
2829         (WTR::TestController::setIgnoresViewportScaleLimits):
2830         (WTR::TestController::platformWillRunTest):
2831         * WebKitTestRunner/TestController.h:
2832         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2833         * WebKitTestRunner/TestInvocation.cpp:
2834         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2835         * WebKitTestRunner/TestOptions.h:
2836         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2837         (WTR::TestController::platformCreateWebView):
2838
2839 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2840
2841         [GTK] install-dependencies should not install packages built by jhbuild.
2842         https://bugs.webkit.org/show_bug.cgi?id=159628
2843
2844         Reviewed by Michael Catanzaro.
2845
2846         * gtk/install-dependencies:
2847         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2848
2849 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2850
2851         System proxy settings not used when building deps with jhbuild
2852         https://bugs.webkit.org/show_bug.cgi?id=159567
2853
2854         Reviewed by Michael Catanzaro.
2855
2856         This adds the gsettings-desktop-schemas-devel build dep to enable
2857         the libgiognomeproxy.so gio module in glib-networking, which uses
2858         GSettings on org.gnome.system.proxy.
2859         This is needed to query system proxy settings for Gnome desktops.
2860
2861         dconf can be manually added to jhbuild to build the
2862         libdconfsettings.so gio module for GSettings, so that
2863         libgiognomeproxy.so can access system settings.
2864           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2865
2866         As an alternative to dconf settings, this commit also adds the
2867         libproxy-devel build dep to enable the libgiolibproxy.so module in
2868         glib-networking (suggested by Fujii Hironori).
2869
2870         It is useful to read proxy settings from environment variables.
2871         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2872         environment variable to force using the envvar module in libproxy.
2873
2874         * gtk/install-dependencies:
2875
2876 2016-07-11  Mark Lam  <mark.lam@apple.com>
2877
2878         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2879         https://bugs.webkit.org/show_bug.cgi?id=159524
2880
2881         Reviewed by Michael Saboff.
2882
2883         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2884         Also fixed up some tests to behave better to work with this new limit.  This
2885         should make stack overflow tests complete sooner.
2886
2887         * Scripts/run-jsc-stress-tests:
2888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2889         (main):
2890
2891 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2892
2893         [GTK] Whitespace fixes in install-dependencies script
2894
2895         Unreviewed.
2896
2897         * gtk/install-dependencies:
2898
2899 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2900
2901         [GTK] Install missing Fedora dependencies
2902
2903         Unreviewed.
2904
2905         * gtk/install-dependencies:
2906
2907 2016-07-09  Dan Bernstein  <mitz@apple.com>
2908
2909         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2910         https://bugs.webkit.org/show_bug.cgi?id=159600
2911
2912         Reviewed by Daniel Bates.
2913
2914         * Scripts/git-add-reviewer:
2915         Added the -s|--rubber-stamp option.
2916         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2917           new option.
2918
2919 2016-07-08  Andy Estes  <aestes@apple.com>
2920
2921         [Content Filtering] Load blocked pages more like other error pages are loaded
2922         https://bugs.webkit.org/show_bug.cgi?id=159485
2923         <rdar://problem/26014076>
2924
2925         Reviewed by Brady Eidson.
2926
2927         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2928         to a content filtering provisional navigation failure is ignored in preference of
2929         ContentFilter's own error page.
2930
2931         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2933         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2934         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2935         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2936         (loadAlternateTest):
2937         (TEST):
2938         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2939         (-[MockContentFilterEnabler initWithCoder:]):
2940         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2941         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2942         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2943         (TestWebKitAPI::loadAlternateTest):
2944         (TestWebKitAPI::TEST):
2945
2946 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2947
2948         Unreviewed, rolling out r202944.
2949         https://bugs.webkit.org/show_bug.cgi?id=159570
2950
2951         caused some tests to crash under GuardMalloc (Requested by
2952         estes on #webkit).
2953
2954         Reverted changeset:
2955
2956         "[Content Filtering] Load blocked pages more like other error
2957         pages are loaded"
2958         https://bugs.webkit.org/show_bug.cgi?id=159485
2959         http://trac.webkit.org/changeset/202944
2960
2961 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2962
2963         Remove mrobinson from the MathML watchlist
2964         https://bugs.webkit.org/show_bug.cgi?id=159559
2965
2966         Reviewed by Philippe Normand.
2967
2968         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2969
2970 2016-07-08  Brady Eidson  <beidson@apple.com>
2971
2972         Clearing LocalStorage doesn't also delete -wal and -shm files.
2973         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2974
2975         Reviewed by Brent Fulgham.
2976         Also helpfully picked over by Andy "Never Forgets" Estes.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2980         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2981
2982 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2983
2984         Removed Qt leftovers from Tools.
2985         https://bugs.webkit.org/show_bug.cgi?id=159557
2986
2987         Reviewed by Csaba Osztrogonác.
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2990         Removed 'qt' platform config.
2991         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2992         Deleted non-functional e-mail address.
2993
2994 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2995
2996         Unreviewed, rolling out r202967.
2997         https://bugs.webkit.org/show_bug.cgi?id=159556
2998
2999         This patch caused crashes in https tests on Windows (Requested
3000         by perarne on #webkit).
3001
3002         Reverted changeset:
3003
3004         "[Win] The test http/tests/security/contentSecurityPolicy
3005         /upgrade-insecure-requests/basic-upgrade.https.html is
3006         failing."
3007         https://bugs.webkit.org/show_bug.cgi?id=159510
3008         http://trac.webkit.org/changeset/202967
3009
3010 2016-07-08  Youenn Fablet  <youenn@apple.com>
3011
3012         Generate WebCore builtin wrapper files
3013         https://bugs.webkit.org/show_bug.cgi?id=159461
3014
3015         Reviewed by Brian Burg.
3016
3017         * Scripts/webkitpy/codegen/main.py:
3018         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3019         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3020
3021 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3022
3023         [EFL] Fix build when media-stream is enabled.
3024         https://bugs.webkit.org/show_bug.cgi?id=159206
3025
3026         Bump up the openwebrtc to find the correct package.
3027
3028         Reviewed by Gyuyoung Kim.
3029
3030         * efl/jhbuild.modules:
3031         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3032
3033 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3034
3035         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3036         https://bugs.webkit.org/show_bug.cgi?id=159510
3037
3038         Reviewed by Brent Fulgham.
3039
3040         Allow any https certificate when running tests.
3041
3042         * DumpRenderTree/win/DumpRenderTree.cpp:
3043         (runTest):
3044
3045 2016-07-07  Beth Dakin  <bdakin@apple.com>
3046
3047         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3048         https://bugs.webkit.org/show_bug.cgi?id=159532
3049         -and corresponding-
3050         rdar://problem/27177179
3051
3052         Reviewed by Tim Horton.
3053
3054         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3055         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3056
3057 2016-07-07  Andy Estes  <aestes@apple.com>
3058
3059         [Content Filtering] Load blocked pages more like other error pages are loaded
3060         https://bugs.webkit.org/show_bug.cgi?id=159485
3061         <rdar://problem/26014076>
3062
3063         Reviewed by Brady Eidson.
3064
3065         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3066         to a content filtering provisional navigation failure is ignored in preference of
3067         ContentFilter's own error page.
3068
3069         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3072         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3073         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3074         (loadAlternateTest):
3075         (TEST):
3076         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3077         (-[MockContentFilterEnabler initWithCoder:]):
3078         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3079         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3080         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3081         (TestWebKitAPI::loadAlternateTest):
3082         (TestWebKitAPI::TEST):
3083
3084 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3085
3086         Unreviewed: add myself to the reviewers list.
3087
3088         * Scripts/webkitpy/common/config/contributors.json:
3089
3090 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3091
3092         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3093         https://bugs.webkit.org/show_bug.cgi?id=159509
3094
3095         Reviewed by Alex Christensen.
3096
3097         We should always insert the url in the url map when identifierForInitialRequest
3098         is called. Otherwise we can end up with identifiers not having an entry in the
3099         url map when urls are written to the test output file. 
3100
3101         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3102         (ResourceLoadDelegate::identifierForInitialRequest):
3103
3104 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3105
3106         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3107         https://bugs.webkit.org/show_bug.cgi?id=159498
3108         <rdar://problem/26719903>
3109
3110         Reviewed by Sam Weinig.
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3114         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3115         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3116         (expectLinkCount):
3117         (TEST):
3118         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3119         when deciding what to linkify.
3120
3121 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3122
3123         Build fix - work around rdar://problem/27196668.
3124
3125         * LayoutTestRelay/Configurations/Base.xcconfig:
3126
3127 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3128
3129         Enhance Windows DRT implementation to support platform scroll wheel events.
3130         https://bugs.webkit.org/show_bug.cgi?id=36002
3131
3132         Reviewed by Brent Fulgham.
3133
3134         Implement function continuousMouseScrollBy in Windows event sender.
3135
3136         * DumpRenderTree/win/EventSender.cpp:
3137         (mouseScrollBy):
3138         (continuousMouseScrollBy):
3139
3140 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3141
3142         [Sierra] Rebaseline tests to use un-mocked system font metrics
3143         https://bugs.webkit.org/show_bug.cgi?id=159311
3144         <rdar://problem/24138411>
3145
3146         Reviewed in person by Alexey Proskuryakov.
3147
3148         Stop mocking the system font on Sierra.
3149
3150         * DumpRenderTree/mac/DumpRenderTree.mm:
3151         (setDefaultsToConsistentValuesForTesting):
3152         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3153         (WTR::InjectedBundle::platformInitialize):
3154
3155 2016-07-05  Brady Eidson  <beidson@apple.com>
3156
3157         Database process crashes deleting a corrupt SQLite database file (null deref).
3158         https://bugs.webkit.org/show_bug.cgi?id=155506.
3159
3160         Reviewed by Alex Christensen.
3161
3162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3164         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3165         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3166         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3167         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3168
3169 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3170
3171         run-webkit-tests should print more complete baseline search paths
3172         https://bugs.webkit.org/show_bug.cgi?id=159354
3173
3174         Reviewed by Daniel Bates.
3175
3176         run-webkit-tests used to only print directory names in baseline search paths.
3177         This was ok in basic usage, but quickly got confusing when using
3178         --additional-platform-directory flags.
3179
3180         * Scripts/webkitpy/layout_tests/views/printing.py:
3181         (Printer.print_config):
3182         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3183         (Testprinter.test_print_config):
3184         (Testprinter.test_print_one_line_summary):
3185
3186 2016-07-04  Brady Eidson  <beidson@apple.com>
3187
3188         WebProcesses don't handle DatabaseProcess going away uncleanly..
3189         https://bugs.webkit.org/show_bug.cgi?id=159371
3190
3191         Reviewed by Alex Christensen.
3192
3193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3194         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3195         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3196         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3197         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3198
3199 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3200
3201         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3202         https://bugs.webkit.org/show_bug.cgi?id=158141
3203
3204         Rubber-stamped by Michael Catanzaro.
3205
3206         Instead of checking for an specific Ubuntu version, query the apt
3207         database to see which version of PHP is available.
3208
3209         * efl/install-dependencies:
3210         * gtk/install-dependencies:
3211
3212 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3213
3214         webkit-patch failure-reason always raises TypeError
3215         https://bugs.webkit.org/show_bug.cgi?id=159394
3216
3217         Reviewed by Benjamin Poulain.
3218
3219         In r170637 (Bug 133067), the first and second arguments of
3220         pluralize were swapped.
3221
3222         * Scripts/webkitpy/tool/commands/queries.py:
3223         (FailureReason._builder_to_explain): Swap the first and second
3224         arguments of pluralize.
3225
3226 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3227
3228         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3229         https://bugs.webkit.org/show_bug.cgi?id=152486
3230
3231         Reviewed by Daniel Bates.
3232
3233         Add launch of web-platform-tests server by run-webkit-httpd.
3234         Add two options to disable starting httpd and web-platform-tests servers.
3235
3236         * Scripts/run-webkit-httpd:
3237         (parse_args):
3238         (main):
3239
3240 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3241
3242         REGRESSION(r189668): Notification tests are flakey
3243         https://bugs.webkit.org/show_bug.cgi?id=159375
3244         <rdar://problem/22760990>
3245
3246         Reviewed by Alexey Proskuryakov.
3247
3248         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3249         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3250         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3251         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3252
3253         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3254         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3255         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3256         global notification ID mapping, causing the wrong notification to be investigated.
3257
3258         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3259         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3260         notification is created or destroyed. However, because this object is implemented outside WebKit,
3261         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3262         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3263         WebNotificationProvider can properly map between the different IDs.
3264
3265         * WebKitTestRunner/TestController.cpp:
3266         (WTR::TestController::runTestingServerLoop):
3267         (WTR::TestController::simulateWebNotificationClick):
3268         * WebKitTestRunner/WebNotificationProvider.cpp:
3269         (WTR::WebNotificationProvider::showWebNotification):
3270         (WTR::removeGlobalIDFromIDMap):
3271         (WTR::WebNotificationProvider::closeWebNotification):
3272         (WTR::WebNotificationProvider::removeNotificationManager):
3273         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3274         (WTR::WebNotificationProvider::reset):
3275         * WebKitTestRunner/WebNotificationProvider.h:
3276
3277 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3278
3279         Simplify LayoutTestRelay
3280         https://bugs.webkit.org/show_bug.cgi?id=159353
3281
3282         Reviewed by Daniel Bates.
3283
3284         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3285         by name and runtime makes no sense.
3286         2. Removed code to create devices, webkitpy always does this in advance.
3287         3. Don't create copies of testing apps - we can install the same one into
3288         each simulator, now that we don't run multiple tester processes in a single simulator.
3289         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3290         5. Removed code that kept testing apps alive in the background.
3291         6. Slightly updated coding style in functions that I touched.
3292
3293         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3294         Updated for what we acually use at this point.
3295
3296         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3297         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3298         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3299         (-[LTRelayController ipcIdentifier]):
3300         (-[LTRelayController processName]):
3301         (-[LTRelayController didReceiveStdoutData:]):
3302         (-[LTRelayController didCrashWithMessage:]):
3303         (-[LTRelayController installApp]):
3304         (-[LTRelayController _environmentVariables]):
3305         (-[LTRelayController launchApp]):
3306         (-[LTRelayController start]):
3307         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3308         (-[LTRelayController uniqueAppPath]): Deleted.
3309         (-[LTRelayController uniqueAppURL]): Deleted.
3310         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3311         (-[LTRelayController createUniqueApp]): Deleted.
3312         * LayoutTestRelay/LayoutTestRelay/main.m:
3313         (usage):
3314         (getRequiredStringArgument):
3315         (main):
3316         (getTestingSimDevice): Deleted.
3317         * Scripts/webkitpy/port/driver.py:
3318         (IOSSimulatorDriver.cmd_line):
3319         * WebKitTestRunner/ios/TestControllerIOS.mm:
3320         (WTR::TestController::platformInitialize):
3321         * WebKitTestRunner/ios/mainIOS.mm:
3322         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3323         * DumpRenderTree/mac/DumpRenderTree.mm:
3324         (dumpRenderTree):
3325         (-[DumpRenderTree applicationDidEnterBackground:]):
3326
3327 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3328
3329         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3330         https://bugs.webkit.org/show_bug.cgi?id=159344
3331
3332         Reviewed by Alex Christensen.
3333
3334         * DumpRenderTree/CMakeLists.txt:
3335
3336 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3337
3338         Add a runtime flag for DOM iterators
3339         https://bugs.webkit.org/show_bug.cgi?id=159300
3340
3341         Reviewed by Alex Christensen.
3342
3343         * DumpRenderTree/mac/DumpRenderTree.mm:
3344         (resetWebPreferencesToConsistentValues):
3345         * DumpRenderTree/win/DumpRenderTree.cpp:
3346         (resetWebPreferencesToConsistentValues):
3347         * Scripts/webkitperl/FeatureList.pm:
3348         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3349         (WTR::InjectedBundle::beginTesting):
3350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3351         (WTR::TestRunner::setDOMIteratorEnabled):
3352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3353
3354 2016-06-30  Tina Liu  <iting_liu@apple.com>
3355
3356         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3357         https://bugs.webkit.org/show_bug.cgi?id=159326
3358
3359         Reviewed by Brady Eidson.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3363         (TestWebKitAPI::didFinishLoadForFrame):
3364         (TestWebKitAPI::didChangeBackForwardListForPage):
3365         (TestWebKitAPI::setPageLoaderClient):
3366         Set the page loader client and register for didFinishLoadForFrame and
3367         didChangeBackForwardList callbacks.
3368         (TestWebKitAPI::createSessionStateData):
3369         Load a webpage ("simple.html") and return the session state for this page.
3370         (TestWebKitAPI::TEST):
3371         Restore the page session state with that of "simple.html" without navigation.
3372         Verify that the committed URL is NULL since there's no navigation involved.
3373         Verify that the current item in the back forward list, which should be what
3374         we restored from the session state, has the expected URL.
3375
3376 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3377
3378         Generators violate bytecode liveness validation
3379         https://bugs.webkit.org/show_bug.cgi?id=159279
3380
3381         Reviewed by Yusuke Suzuki.
3382         
3383         Add Basic to our test harness.
3384
3385         * Scripts/run-javascriptcore-tests:
3386         (runJSCStressTests):
3387
3388 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3389
3390         [Win][Debug] Assertion fails in TestWTF.
3391         https://bugs.webkit.org/show_bug.cgi?id=159299
3392
3393         Reviewed by Alex Christensen.
3394
3395         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3396         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3397         the assertion failure. Since the variable is actually used, there is no need to use the
3398         UNUSED_PARAM macro.
3399
3400         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3401         (TestWebKitAPI::TEST):
3402
3403 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3404
3405         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3406         https://bugs.webkit.org/show_bug.cgi?id=159166
3407         <rdar://problem/27051759>
3408
3409         Reviewed by Alexey Proskuryakov.
3410
3411         Setting the certificate directory to the copied config.json.
3412
3413         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3414         (WebPlatformTestServer._copy_webkit_test_files):
3415
3416 2016-06-29  Mark Lam  <mark.lam@apple.com>
3417
3418         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3419         https://bugs.webkit.org/show_bug.cgi?id=159274
3420
3421         Reviewed by Keith Miller.
3422
3423         * DumpRenderTree/mac/DumpRenderTree.mm:
3424         (DumpRenderTreeMain):
3425
3426 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3427
3428         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3429         https://bugs.webkit.org/show_bug.cgi?id=159176
3430
3431         Reviewed by Sam Weinig.
3432
3433         * MiniBrowser/mac/WK2BrowserWindowController.m:
3434         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3435         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3436         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3437
3438 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3439
3440         [GTK] Add missing install dependency after r202619
3441         https://bugs.webkit.org/show_bug.cgi?id=156716
3442
3443         Unreviewed.
3444
3445         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3446
3447 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3448
3449         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3450         https://bugs.webkit.org/show_bug.cgi?id=156716
3451
3452         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3453
3454         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3455         (parse_args):
3456         * Scripts/webkitpy/port/gtk.py:
3457         (GtkPort.__init__):
3458         (GtkPort._driver_class):
3459         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3460         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3461         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3462         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3463         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3464         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3465         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3466         (WestonDriver.check_driver):
3467         (WestonDriver.__init__):
3468         (WestonDriver._start):
3469         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3470         (WestonXvfbDriverDisplayTest):
3471         (WestonXvfbDriverDisplayTest.__init__):
3472         (WestonXvfbDriverDisplayTest._xvfb_run):
3473         (WestonDriverTest.make_driver):
3474         (WestonDriverTest.test_start):
3475         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3476         or to satisfy the pkg-config check of the new added modules in JHBuild.
3477         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3478         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3479         provided by the system are already new enough.
3480         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3481         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3482         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3483         feature to avoid building libdrm when the one provided by the system is new enough.
3484         * gtk/jhbuildrc:
3485         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3486         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3487         This patch implements support for that reusing the same variable that we use with Mesa to set the
3488         custom path for the DRI drivers path.
3489
3490 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3491
3492         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3493         https://bugs.webkit.org/show_bug.cgi?id=159256
3494
3495         Reviewed by Philippe Normand.
3496
3497         We need the last fixes in the repository to make the scream queue
3498         work with apprtc.
3499
3500         * gtk/jhbuild.modules:
3501
3502 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3503
3504         Unreviewed, rolling out r202580.
3505         https://bugs.webkit.org/show_bug.cgi?id=159245
3506
3507         Caused all WKTR tests to fail on GuardMalloc and Production
3508         only for unknown reasons, investigating offline. (Requested by
3509         brrian on #webkit).
3510
3511         Reverted changeset:
3512
3513         "RunLoop::Timer should use constructor templates instead of
3514         class templates"
3515         https://bugs.webkit.org/show_bug.cgi?id=159153
3516         http://trac.webkit.org/changeset/202580
3517
3518 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3519
3520         Use a regex to check if a test step is for JavaScriptCore
3521         https://bugs.webkit.org/show_bug.cgi?id=159224
3522
3523         Reviewed by Geoffrey Garen.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3526         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3528         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3530         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3531
3532 2016-06-28  Michael Saboff  <msaboff@apple.com>
3533
3534         btjs no longer accepts optional frame count argument
3535         https://bugs.webkit.org/show_bug.cgi?id=159235
3536
3537         Reviewed by Saam Barati.
3538
3539         Fix the detection of optional backtrace-depth parameter to use the length
3540         of the command.
3541
3542         * lldb/lldb_webkit.py:
3543         (btjs):
3544
3545 2016-06-28  Jon Lee  <jonlee@apple.com>
3546
3547         Update animometer.plan
3548
3549         Rubber-stamped by Said Abou-Hallawa.
3550
3551         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3552
3553 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3554
3555         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3556
3557         * Scripts/run-javascriptcore-tests:
3558         (runJSCStressTests):
3559
3560 2016-06-28  Brian Burg  <bburg@apple.com>
3561
3562         RunLoop::Timer should use constructor templates instead of class templates
3563         https://bugs.webkit.org/show_bug.cgi?id=159153
3564
3565         Reviewed by Alex Christensen.
3566
3567         Remove the RunLoop::Timer class template argument, and pass its constructor
3568         a reference to `this` instead of a pointer to `this`.
3569
3570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3571         (WTR::TestRunner::TestRunner):
3572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3573         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3574         (TestWebKitAPI::TEST):
3575
3576 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3577
3578         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3579         https://bugs.webkit.org/show_bug.cgi?id=159199
3580
3581         Reviewed by Alexey Proskuryakov.
3582
3583         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3584
3585         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3586         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3587         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3588         an input element getting automatically focused on Mac.
3589
3590 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3591
3592         [Win] Custom elements tests are failing.
3593         https://bugs.webkit.org/show_bug.cgi?id=159139
3594
3595         Reviewed by Alex Christensen.
3596
3597         Enable custom element API when running tests.
3598
3599         * DumpRenderTree/win/DumpRenderTree.cpp:
3600         (resetWebPreferencesToConsistentValues):
3601
3602 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3603
3604         Test commit. Please ignore.
3605         
3606 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3607
3608         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3609         https://bugs.webkit.org/show_bug.cgi?id=155073
3610
3611         Reviewed by Daniel Bates.
3612
3613         * Scripts/webkitperl/FeatureList.pm:
3614
3615 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3616
3617         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3618         https://bugs.webkit.org/show_bug.cgi?id=159077
3619
3620         Reviewed by Tim Horton.
3621
3622         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3623
3624         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3625         which is necessary for UI-side compositing.
3626
3627         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3628         seems to happen for some tests that call window.resizeTo().
3629
3630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3631         (WTR::InjectedBundlePage::dump): Deleted.
3632         * WebKitTestRunner/TestInvocation.cpp:
3633         (WTR::TestInvocation::dumpResults):
3634         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3635         (WTR::createCGContextFromImage):
3636         (WTR::computeMD5HashStringForContext):
3637         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3638         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3639         (WTR::PlatformWebView::windowSnapshotImage):
3640
3641 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3642
3643         [EFL] Support to build on Debian linux
3644         https://bugs.webkit.org/show_bug.cgi?id=159123
3645
3646         Reviewed by Antonio Gomes.
3647
3648         * efl/install-dependencies: Install libgnutls28-dev.
3649
3650 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3651
3652         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3653         https://bugs.webkit.org/show_bug.cgi?id=159071
3654
3655         Reviewed by Brady Eidson.
3656
3657         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3658         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3659         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3660         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3661         (WTR::TestRunner::setAuthenticationUsername):
3662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3663         * WebKitTestRunner/TestController.cpp:
3664         (WTR::TestController::TestController):
3665         (WTR::TestController::resetStateToConsistentValues):
3666         (WTR::TestController::didFinishNavigation):
3667         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3668         (WTR::TestController::didReceiveAuthenticationChallenge):
3669         (WTR::TestController::didCommitNavigation):
3670         * WebKitTestRunner/TestController.h:
3671         (WTR::TestController::setBlockAllPlugins):
3672         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3673         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3674         (WTR::TestController::isCurrentInvocation):
3675         * WebKitTestRunner/TestInvocation.cpp:
3676         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3677         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3678
3679 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3680
3681         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3682         https://bugs.webkit.org/show_bug.cgi?id=159129
3683
3684         Reviewed by Alex Christensen.
3685
3686         Implement the function mouseScrollBy in the Windows event sender.
3687
3688         * DumpRenderTree/win/EventSender.cpp:
3689         (mouseScrollBy):
3690         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3691
3692 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3693
3694         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3695         https://bugs.webkit.org/show_bug.cgi?id=159104
3696
3697         Reviewed by Dan Bernstein.
3698         
3699         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3700         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3701
3702         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3703         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3705
3706 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3707
3708         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3709         https://bugs.webkit.org/show_bug.cgi?id=159086
3710
3711         Reviewed by Alex Christensen.
3712
3713         Implement required wheel event function in event sender.
3714  
3715         * DumpRenderTree/win/EventSender.cpp:
3716         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3717
3718 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3719
3720         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3721         https://bugs.webkit.org/show_bug.cgi?id=159104
3722
3723         Reviewed by Mark Lam.
3724         
3725         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3726         WK.
3727
3728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3729
3730 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3731
3732         parser_unittests.pl should not hardcode list of tests
3733         <https://webkit.org/b/159074>
3734
3735         Reviewed by Daniel Bates.
3736
3737         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3738         Update to read the list of tests from the 'resources' directory,
3739         and instead map file extensions to subroutine names.  Switch to
3740         use File::Basename::fileparse() to get basename and file
3741         extension for each test.
3742         (readTestFiles): Added.  Reads files from the directory passed
3743         in and ignores: hidden files, anything that isn't a plain file,
3744         and expected test results files.
3745
3746 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3747
3748         Fix Windows build.
3749
3750         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3751         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3752
3753 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3754
3755         [EFL] Change download path of libxslt
3756
3757         Unreviewed EFL build fix.
3758
3759         In Korea current download path can't be accessed. Change it.
3760
3761         * efl/jhbuild.modules:
3762
3763 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3764
3765         https://bugs.webkit.org/show_bug.cgi?id=159077
3766
3767         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3768         snapshot the final state of the test in release builds. 
3769
3770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3771         (WTR::InjectedBundlePage::dump):
3772
3773 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3774
3775         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3776
3777         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3778         (createBitmapContextFromWebView):
3779         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3780         (WTR::PlatformWebView::windowSnapshotImage):
3781
3782 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3783
3784         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3785         https://bugs.webkit.org/show_bug.cgi?id=159077
3786
3787         Reviewed by Tim Horton.
3788
3789         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3790         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3791         thus enabling testing of more things.
3792
3793         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3794         (createBitmapContext): Moved to this file to share it.
3795         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3796         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3797         (createBitmapContextFromWebView):
3798         (BitmapContext::createFromUIImage): Deleted.
3799         (BitmapContext::pixelData): Deleted.
3800         (BitmapContext::BitmapContext): Deleted.
3801         (computeMD5HashStringForBitmapContext): Deleted.
3802         (dumpBitmap): Deleted.
3803         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3804         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3805         (createPagedBitmapContext):
3806         (createBitmapContext): Deleted.
3807         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3809         (WTR::InjectedBundlePage::dump): Deleted.
3810         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3811         (WTR::PlatformWebView::windowSnapshotImage):
3812
3813 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3814
3815         [jhbuild] Added libxslt module.
3816         https://bugs.webkit.org/show_bug.cgi?id=159034
3817
3818         Unreviewed, followup for r202373.
3819
3820         * efl/install-dependencies: Removed libxslt 
3821         * gtk/install-dependencies: Ditto.
3822
3823 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3824
3825         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3826         https://bugs.webkit.org/show_bug.cgi?id=159050
3827
3828         Reviewed by Antonio Gomes.
3829
3830         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3831
3832         * efl/jhbuild.modules:
3833         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3834         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3835
3836 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3837
3838         [jhbuild] Added libxslt module.
3839         https://bugs.webkit.org/show_bug.cgi?id=159034
3840
3841         Reviewed by Michael Catanzaro.
3842
3843         * efl/jhbuild.modules:
3844         * gtk/jhbuild.modules:
3845
3846 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3847
3848         [Win] Use Windows api function to find top level parent.
3849         https://bugs.webkit.org/show_bug.cgi?id=159021
3850
3851         Reviewed by Brent Fulgham.
3852
3853         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3854  
3855         * DumpRenderTree/win/UIDelegate.cpp:
3856         (UIDelegate::runModal):
3857         (findTopLevelParent): Deleted.
3858         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3859         (PrintWebUIDelegate::runModal):
3860         (findTopLevelParent): Deleted.
3861
3862 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3863
3864         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3865         https://bugs.webkit.org/show_bug.cgi?id=158934
3866
3867         Reviewed by Brent Fulgham.
3868
3869         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3870
3871         * DumpRenderTree/win/TestRunnerWin.cpp:
3872         (TestRunner::clearAllDatabases):
3873
3874 2016-06-22  Saam Barati  <sbarati@apple.com>
3875
3876         run-javascriptcore-tests should have some environment variables for commonly used settings
3877         https://bugs.webkit.org/show_bug.cgi?id=159047
3878
3879         Reviewed by Keith Miller.
3880
3881         This patch adds three environment variables that run-javascriptcore-tests
3882         consults:
3883         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3884           determines if we should run the api tests or not.
3885         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3886           determines if we will perform a build or not before running the tests.
3887           to set the default should-build setting.
3888         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3889           a yaml file. If set, we will run the extra tests it refers to.
3890
3891         All the values in these environment variables will be overridden if an
3892         option is explicitly passed in. For example, the following will run
3893         the api tests:
3894         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3895
3896         * Scripts/run-javascriptcore-tests:
3897
3898 2016-06-22  Saam barati  <sbarati@apple.com>
3899
3900         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3901         https://bugs.webkit.org/show_bug.cgi?id=159037
3902         <rdar://problem/26935349>
3903
3904         Reviewed by Benjamin Poulain.
3905
3906         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3907
3908         * Scripts/run-jsc-stress-tests:
3909
3910 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3911
3912         Fix style issues in webkitpy
3913         https://bugs.webkit.org/show_bug.cgi?id=159019
3914
3915         Reviewed by Daniel Bates.
3916
3917         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3918         There is no functionality change.
3919         Only affected file names retained below for brevity.
3920
3921         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3922         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3923         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3924         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3925         * Scripts/webkitpy/benchmark_runner/utils.py:
3926         * Scripts/webkitpy/common/checkout/changelog.py:
3927         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3928         * Scripts/webkitpy/common/checkout/checkout.py:
3929         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3930         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3931         * Scripts/webkitpy/common/checkout/commitinfo.py:
3932         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3933         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3934         * Scripts/webkitpy/common/checkout/scm/scm.py:
3935         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3936         * Scripts/webkitpy/common/config/committers_unittest.py:
3937         * Scripts/webkitpy/common/config/irc.py:
3938         * Scripts/webkitpy/common/config/ports.py:
3939         * Scripts/webkitpy/common/config/ports_unittest.py:
3940         * Scripts/webkitpy/common/config/urls.py:
3941         * Scripts/webkitpy/common/host_mock.py:
3942         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3943         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3944         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3945         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3946         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3947         * Scripts/webkitpy/common/net/credentials_unittest.py:
3948         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3949         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3950         * Scripts/webkitpy/common/net/statusserver.py:
3951         * Scripts/webkitpy/common/system/autoinstall.py:
3952         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3953         * Scripts/webkitpy/common/system/executive.py:
3954         * Scripts/webkitpy/common/system/executive_mock.py:
3955         * Scripts/webkitpy/common/system/executive_unittest.py:
3956         * Scripts/webkitpy/common/system/filesystem_mock.py:
3957         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3958         * Scripts/webkitpy/common/system/logutils_unittest.py:
3959         * Scripts/webkitpy/common/system/path.py:
3960         * Scripts/webkitpy/common/system/path_unittest.py:
3961         * Scripts/webkitpy/common/system/platforminfo.py:
3962         * Scripts/webkitpy/common/system/user.py:
3963         * Scripts/webkitpy/common/system/user_unittest.py:
3964         * Scripts/webkitpy/common/system/workspace_unittest.py:
3965         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3966         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3967         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3968         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3969         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3971         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3972         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3973         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3974         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3975         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3976         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3977         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3978         * Scripts/webkitpy/layout_tests/views/printing.py:
3979         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3980         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3981         * Scripts/webkitpy/port/base_unittest.py:
3982         * Scripts/webkitpy/port/driver.py:
3983         * Scripts/webkitpy/port/driver_unittest.py:
3984         * Scripts/webkitpy/port/factory.py:
3985         * Scripts/webkitpy/port/gtk.py:
3986         * Scripts/webkitpy/port/server_process_unittest.py:
3987         * Scripts/webkitpy/port/test.py:
3988         * Scripts/webkitpy/port/win.py:
3989         * Scripts/webkitpy/style/checker.py:
3990         * Scripts/webkitpy/style/checkers/common_unittest.py:
3991         * Scripts/webkitpy/style/checkers/cpp.py:
3992         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3993         * Scripts/webkitpy/style/checkers/js.py:
3994         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3995         * Scripts/webkitpy/style/checkers/png.py:
3996         * Scripts/webkitpy/style/checkers/text.py:
3997         * Scripts/webkitpy/style/checkers/text_unittest.py:
3998         * Scripts/webkitpy/style/error_handlers.py:
3999         * Scripts/webkitpy/style/filter.py:
4000         * Scripts/webkitpy/style/filter_unittest.py:
4001         * Scripts/webkitpy/style/optparser.py:
4002         * Scripts/webkitpy/style/optparser_unittest.py:
4003         * Scripts/webkitpy/test/main.py:
4004         * Scripts/webkitpy/w3c/test_converter.py:
4005         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4006         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4007         * Scripts/webkitpy/xcode/simulator.py:
4008
4009 2016-06-22  Brady Eidson  <beidson@apple.com>
4010
4011         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
4012         https://bugs.webkit.org/show_bug.cgi?id=158894
4013
4014         Reviewed by Alex Christensen.
4015
4016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4017         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
4018         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
4019         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4020
4021 2016-06-22  Jon Lee  <jonlee@apple.com>
4022
4023         Update animometer.plan
4024         https://bugs.webkit.org/show_bug.cgi?id=159012
4025
4026         Reviewed by Ryosuke Niwa.
4027
4028         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
4029
4030 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4031
4032         W3C test importer should generate files to ignore by WebKit SCM
4033         https://bugs.webkit.org/show_bug.cgi?id=142743
4034
4035         Reviewed by Darin Adler.
4036
4037         TestDownloader generates the .gitignore file according submodules git repository information.
4038         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
4039
4040         * Scripts/webkitpy/w3c/test_downloader.py:
4041         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
4042         * Scripts/webkitpy/w3c/test_importer.py:
4043         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
4044         (TestImporter):
4045         (TestImporter.write_init_py): Writing not empty __init__.py files.
4046         (TestImporter.import_tests): Using  of write_init_py. 
4047         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4048         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
4049         (TestImporterTest):
4050         (TestImporterTest.test_initpy_generation): Added __init__.py test.
4051
4052 2016-06-21  Sam Weinig  <sam@webkit.org>
4053
4054         WKWebView with no WKNavigationDelegate does not follow universal links
4055         <rdar://problem/24374110>
4056         https://bugs.webkit.org/show_bug.cgi?id=158997
4057
4058         Reviewed by Dan Bernstein.
4059
4060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4061         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4062         Add a new test that shows that we have a default navigation delegate by swizzling
4063         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4064
4065 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4066
4067         [Win] Implement modal dialog support in MiniBrowser.
4068         https://bugs.webkit.org/show_bug.cgi?id=158976
4069
4070         Reviewed by Brent Fulgham.
4071
4072         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4073         (PrintWebUIDelegate::createWebViewWithRequest):
4074         (getHandleFromWebView):
4075         (PrintWebUIDelegate::webViewClose):
4076         (PrintWebUIDelegate::setFrame):
4077         (PrintWebUIDelegate::webViewFrame):
4078         (PrintWebUIDelegate::canRunModal):
4079         (findTopLevelParent):
4080         (PrintWebUIDelegate::runModal):
4081         (PrintWebUIDelegate::createModalDialog):
4082         * MiniBrowser/win/PrintWebUIDelegate.h:
4083         (PrintWebUIDelegate::webViewClose):
4084         (PrintWebUIDelegate::setFrame):
4085         (PrintWebUIDelegate::webViewFrame):
4086         (PrintWebUIDelegate::canRunModal):
4087         (PrintWebUIDelegate::runModal):
4088
4089 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4090
4091         window.showModalDialog doesn't work in DumpRenderTree on Windows
4092         https://bugs.webkit.org/show_bug.cgi?id=53675
4093
4094         Reviewed by Brent Fulgham.
4095
4096         Implement modal dialog support in DumpRenderTree.
4097
4098         * DumpRenderTree/win/UIDelegate.cpp:
4099         (UIDelegate::canRunModal):
4100         (getHandleFromWebView):
4101         (UIDelegate::createModalDialog):
4102         (findTopLevelParent):
4103         (UIDelegate::runModal):
4104         (UIDelegate::webViewClose):
4105         * DumpRenderTree/win/UIDelegate.h:
4106
4107 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4108
4109         Fix formatting issues reported by check-webkit-style
4110         https://bugs.webkit.org/show_bug.cgi?id=159008
4111
4112         Reviewed by Alexey Proskuryakov.
4113
4114         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4115         There is no functionality change.
4116
4117         * Scripts/webkitpy/tool/bot/irc_command.py:
4118         (Restart.execute):
4119         (Rollout):
4120         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4121         (IRCBotTest.test_exception_during_command):
4122         (IRCBotTest.test_exception_during_command.CommandWithException):
4123         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4124         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4125         (test_missing_unit_test_results_path):
4126         (test_layout_test_results):
4127         * Scripts/webkitpy/tool/bot/queueengine.py:
4128         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4129         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4130         (AbstractSequencedCommand):
4131         (AbstractSequencedCommand.__init__):
4132         * Scripts/webkitpy/tool/commands/download.py:
4133         (Land):
4134         * Scripts/webkitpy/tool/commands/openbugs.py:
4135         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4136         (OpenBugsTest):
4137         * Scripts/webkitpy/tool/commands/queries.py:
4138         (PatchesToCommitQueue):
4139         (PatchesToCommitQueue.__init__):
4140         (PatchesToCommitQueue._needs_commit_queue):
4141         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4142         (PrintExpectationsTest.test_platform):
4143         (PrintBaselinesTest):
4144         (PrintBaselinesTest.setUp):
4145         * Scripts/webkitpy/tool/commands/queues.py:
4146         (AbstractQueue):
4147         (AbstractQueue.__init__):
4148         (AbstractQueue.execute):
4149         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4150         (test_auto_retry):
4151         * Scripts/webkitpy/tool/commands/rebaseline.py:
4152         (AbstractParallelRebaselineCommand._files_to_add):
4153         (AbstractParallelRebaselineCommand):
4154         (AbstractParallelRebaselineCommand._rebaseline):
4155         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4156         (SetupGitClone):
4157         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4158         * Scripts/webkitpy/tool/commands/stepsequence.py:
4159         * Scripts/webkitpy/tool/commands/upload.py:
4160         (PostCommits._comment_text_for_commit):
4161         (PostCommits):
4162         (PostCommits.execute):
4163         (MarkBugFixed):
4164         (MarkBugFixed.__init__):
4165         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4166         (UploadCommandsTest):
4167         (UploadCommandsTest.test_commit_message_for_current_diff):
4168         * Scripts/webkitpy/tool/grammar_unittest.py:
4169         (GrammarTest):
4170         (GrammarTest.test_join_with_separators):
4171         * Scripts/webkitpy/tool/multicommandtool.py:
4172         (HelpCommand.__init__):
4173         (HelpCommand):
4174         (HelpCommand._help_epilog):
4175         (HelpCommand._remove_help_options):
4176         (MultiCommandTool):
4177         (MultiCommandTool.__init__):
4178         (MultiCommandTool.main):
4179         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4180         (TrivialCommand):
4181         (TrivialCommand.__init__):
4182         (MultiCommandToolTest):
4183         (MultiCommandToolTest._assert_tool_main_outputs):
4184         (MultiCommandToolTest.test_retry):
4185         (test_command_help):
4186         * Scripts/webkitpy/tool/steps/__init__.py:
4187         * Scripts/webkitpy/tool/steps/abstractstep.py:
4188         * Scripts/webkitpy/tool/steps/applypatch.py:
4189         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4190         (ApplyPatchWithLocalCommit):
4191         (ApplyPatchWithLocalCommit.options):
4192         * Scripts/webkitpy/tool/steps/build.py:
4193         * Scripts/webkitpy/tool/steps/checkstyle.py:
4194         (CheckStyle):
4195         (CheckStyle.options):
4196         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4197         * Scripts/webkitpy/tool/steps/closebug.py:
4198         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4199         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4200         (CloseBugForLandDiffTest):
4201         (CloseBugForLandDiffTest.test_empty_state):
4202         * Scripts/webkitpy/tool/steps/closepatch.py:
4203         * Scripts/webkitpy/tool/steps/commit.py:
4204         (Commit.run):
4205         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4206         * Scripts/webkitpy/tool/steps/editchangelog.py:
4207         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4208         * Scripts/webkitpy/tool/steps/metastep.py:
4209         (MetaStep):
4210         (MetaStep.__init__):
4211         (MetaStep.run):
4212         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4213         * Scripts/webkitpy/tool/steps/options.py:
4214         (Options):
4215         * Scripts/webkitpy/tool/steps/postdiff.py:
4216         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4217         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
4218         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4219         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4220         (PrepareChangeLogTest):
4221         (PrepareChangeLogTest.test_resolve_existing_entry):
4222         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4223         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
4224         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4225         * Scripts/webkitpy/tool/steps/revertrevision.py:
4226         * Scripts/webkitpy/tool/steps/runtests.py:
4227         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4228         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4229         (StepsTest):
4230         (StepsTest._step_options):
4231         * Scripts/webkitpy/tool/steps/update.py:
4232         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4233         (UpdateChangeLogsWithReviewerTest):
4234         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4235         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4236         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4237
4238 2016-06-21  Chris Dumez  <cdumez@apple.com>
4239
4240         Unreviewed, rolling out r202296.
4241
4242         Broke basic browsing in Safari
4243
4244         Reverted changeset:
4245
4246         "WKWebView with no WKNavigationDelegate does not follow
4247         universal links"
4248         https://bugs.webkit.org/show_bug.cgi?id=158997
4249         http://trac.webkit.org/changeset/202296
4250
4251 2016-06-21  Anders Carlsson  <andersca@apple.com>
4252
4253         Fix build.
4254
4255         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4256
4257 2016-06-21  Anders Carlsson  <andersca@apple.com>
4258
4259         Begin moving the Apple Pay code to the open source repository
4260         https://bugs.webkit.org/show_bug.cgi?id=158998
4261
4262         Reviewed by Tim Horton.
4263
4264         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4265         Add ENABLE_APPLE_PAY.
4266
4267 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
4268
4269         Add system tracing points for requestAnimationFrame() workflow
4270         https://bugs.webkit.org/show_bug.cgi?id=158723
4271
4272         Reviewed by Simon Fraser.
4273
4274         Add new plist entries to be used by kdebug_trace() viewing too