Leaks builder should not be triggered upon new commits
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Leaks builder should not be triggered upon new commits
4         https://bugs.webkit.org/show_bug.cgi?id=114475
5
6         Reviewed by Jessie Berlin.
7
8         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
9         the leak builder when builds are done.
10
11         * BuildSlaveSupport/build.webkit.org-config/config.json:
12
13 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
14
15         [GTK] Windows build failure after r136056
16         https://bugs.webkit.org/show_bug.cgi?id=114121
17
18         Reviewed by Martin Robinson.
19
20         * TestWebKitAPI/config.h: Make sure defines are correct for other
21         Windows ports than apple-win.
22
23 2013-04-11  Ojan Vafai  <ojan@chromium.org>
24
25         Remove myself from watchlists.
26         * Scripts/webkitpy/common/config/watchlist:
27
28 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
29
30         Build fix. Don't hard-code queues.webkit.org at least during the transition.
31
32         * QueueStatusServer/templates/statusbubble.html:
33
34 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
35
36         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
37         https://bugs.webkit.org/show_bug.cgi?id=114397
38
39         Reviewed by Benjamin Poulain.
40
41         Reland the patch since Alan appears to have finished the migration.
42
43         * Scripts/webkitpy/common/net/statusserver.py:
44         (StatusServer):
45
46 2013-04-11  Brian Holt  <brian.holt@samsung.com>
47
48         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
49         https://bugs.webkit.org/show_bug.cgi?id=76796
50
51         Reviewed by Chris Fleizach.
52
53         Make the Gtk window for the DRT a toplevel so that it gets the
54         focus from the window manager when the test starts.
55
56         * DumpRenderTree/gtk/DumpRenderTree.cpp:
57         (main):
58
59 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
60
61         Use CSS4 image-rendering to determing image scaling quality
62         https://bugs.webkit.org/show_bug.cgi?id=113405
63
64         Reviewed by Simon Fraser.
65
66         Introduce new flag to enable experimental support for CSS4 Images.
67
68         * Scripts/webkitperl/FeatureList.pm:
69
70 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
71
72         Remove code for Chromium from wkbuild.py
73         https://bugs.webkit.org/show_bug.cgi?id=114423
74
75         Reviewed by Benjamin Poulain.
76
77         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
78         (_should_file_trigger_build):
79         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
80         (ShouldBuildTest):
81
82 2013-04-11  Philippe Normand  <pnormand@igalia.com>
83
84         Unreviewed, update my IRC nickname.
85
86         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
87
88 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
89
90         Remove the rest of Chromium code from webkitpy
91         https://bugs.webkit.org/show_bug.cgi?id=114420
92
93         Reviewed by Benjamin Poulain.
94
95         * Scripts/webkitpy/common/config/urls.py:
96         (view_revision_url):
97         * Scripts/webkitpy/common/host.py:
98         (Host._engage_awesome_locale_hacks):
99         (Host.initialize_scm):
100         (Host):
101         * Scripts/webkitpy/common/host_mock.py:
102         (MockHost.__init__):
103         (MockHost.checkout):
104         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
105         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
106         (JSONResultsGeneratorBase._insert_generic_metadata):
107         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
108         (TestExpectationParser._tokenize_line):
109         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
110         (ExpectationSyntaxTests.test_bare_name_and_bugs):
111         (ExpectationSyntaxTests.test_warnings):
112         * Scripts/webkitpy/layout_tests/port/base.py:
113         (Port.skips_perf_test):
114         (Port.path_to_test_expectations_file):
115         (Port._port_flag_for_scripts):
116         * Scripts/webkitpy/style/checkers/cpp.py:
117         (check_function_definition):
118         (check_include_line):
119         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
120         (OrderOfIncludesTest.test_check_wtf_includes):
121         (WebKitStyleTest.test_webkit_export_check):
122         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
123         (TestExpectationsTestCase.test_valid_expectations):
124         * Scripts/webkitpy/tool/bot/irc_command.py:
125         (Rollout.execute):
126         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
127         (IRCCommandTest.test_whois):
128         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
129         (IRCBotTest.test_help):
130         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
131         (SheriffBotTest.test_command_aliases):
132
133 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
134
135         roll-chromium-deps doesn't roll DEPS
136         https://bugs.webkit.org/show_bug.cgi?id=114421
137
138         Reviewed by Antti Koivisto.
139
140         Roll DEPS. Rolling DEPS. Rolled DEPS.
141
142         * Scripts/webkitpy/tool/bot/irc_command.py:
143         (RollChromiumDEPS.execute):
144
145 2013-04-11  Glenn Adams  <glenn@skynav.com>
146
147         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
148         https://bugs.webkit.org/show_bug.cgi?id=114418
149
150         Reviewed by Ryosuke Niwa.
151
152         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
153         (MockSCM.add): Remove optional remove_exit_code argument.
154         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
155         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
156         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
157         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
158
159 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
160
161         Fix roll-chromium-deps and hi.
162
163         * Scripts/webkitpy/tool/bot/irc_command.py:
164         (Hi.execute):
165         (RollChromiumDEPS.execute):
166
167 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
168
169         Remove webkitpy code to roll Chromium DEPS
170         https://bugs.webkit.org/show_bug.cgi?id=114415
171
172         Reviewed by Benjamin Poulain.
173
174         Removed the code to roll Chromium DEPS in WebKit.
175
176         * Scripts/webkitpy/common/checkout/checkout.py:
177         (Checkout.bug_id_for_this_commit):
178         * Scripts/webkitpy/common/checkout/checkout_mock.py:
179         (MockCheckout.commit_message_for_this_commit):
180         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
181         (CheckoutTest.test_suggested_reviewers):
182         * Scripts/webkitpy/common/checkout/deps.py: Removed.
183         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
184         * Scripts/webkitpy/tool/bot/irc_command.py:
185         (RollChromiumDEPS): Teach webkitbot a sense of humor.
186         (RollChromiumDEPS.execute):
187         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
188         (IRCCommandTest.test_create_bug):
189         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
190         (IRCBotTest.test_revert):
191         * Scripts/webkitpy/tool/bot/sheriff.py:
192         (Sheriff.post_rollout_patch):
193         * Scripts/webkitpy/tool/commands/__init__.py:
194         * Scripts/webkitpy/tool/commands/roll.py: Removed.
195         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
196         * Scripts/webkitpy/tool/steps/__init__.py:
197         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
198         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
199         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
200
201 2013-04-11  Glenn Adams  <glenn@skynav.com>
202
203         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
204         https://bugs.webkit.org/show_bug.cgi?id=114386
205
206         Reviewed by Benjamin Poulain.
207
208         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
209         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
210         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
211         by default and to return exit code 1 if a file/dir had already been added.
212
213         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
214         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
215         * Scripts/webkitpy/common/checkout/scm/svn.py:
216         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
217
218 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
219
220         Unreviewed.
221
222         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
223
224 2013-04-10  Glenn Adams  <glenn@skynav.com>
225
226         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
227         https://bugs.webkit.org/show_bug.cgi?id=114410
228
229         Reviewed by Ryosuke Niwa.
230
231         * Scripts/webkitpy/common/checkout/scm/git.py:
232         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
233         * Scripts/webkitpy/common/checkout/scm/scm.py:
234         (SCM.add): Remove optional return_exit_code argument.
235         (SCM.add_list): Remove optional return_exit_code argument.
236         * Scripts/webkitpy/common/checkout/scm/svn.py:
237         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
238
239 2013-04-10  Eric Seidel  <eric@webkit.org>
240
241         Remove myself from the watchlists, I'm getting too much bug mail. :)
242
243         * Scripts/webkitpy/common/config/watchlist:
244
245 2013-04-10  Commit Queue  <rniwa@webkit.org>
246
247         Unreviewed, rolling out r148158.
248         http://trac.webkit.org/changeset/148158
249         https://bugs.webkit.org/show_bug.cgi?id=114405
250
251         We need to migrate status data (Requested by rniwa on
252         #webkit).
253
254         * Scripts/webkitpy/common/net/statusserver.py:
255         (StatusServer):
256
257 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
258
259         Mass remove all the empty directories
260
261         Rubberstamped by Ryosuke Niwa.
262
263         * BuildSlaveSupport/gtk/crashmon/log: Removed.
264         * BuildSlaveSupport/gtk/xvfb/log: Removed.
265         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
266         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
267         * MiniBrowser/gtk/WebBundle: Removed.
268         * MiniBrowser/win: Removed.
269         * QtTestPlatformPlugin/mac: Removed.
270         * Scripts/webkitpy/tool/bot/testdata: Removed.
271         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
272         * efl/ImageDiff: Removed.
273         * iExploder/htdocs: Removed.
274         * iExploder/iexploder-1.7.2/output: Removed.
275         * iExploder/tools: Removed.
276         * qmake/config.tests/libexecdir: Removed.
277         * qmake/config.tests/libjpeg: Removed.
278         * qmake/config.tests/libpng: Removed.
279
280 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
281
282         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
283         https://bugs.webkit.org/show_bug.cgi?id=114397
284
285         Reviewed by Benjamin Poulain.
286
287         * Scripts/webkitpy/common/net/statusserver.py:
288         (StatusServer):
289
290 2013-04-10  Adam Barth  <abarth@webkit.org>
291
292         Remove abarth from watchlists
293         https://bugs.webkit.org/show_bug.cgi?id=114390
294
295         Reviewed by Ryosuke Niwa.
296
297         I'm trying to cut down on the amount of bugmail I get so that I'll have
298         more of a chance to notice a piece of bugmail directed at me.
299
300         * Scripts/webkitpy/common/config/watchlist:
301
302 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
303
304         webkit-test-results.appspot.com loads the dashboard for Chromium by default
305         https://bugs.webkit.org/show_bug.cgi?id=114381
306
307         Reviewed by Benjamin Poulain.
308
309         Changed the defaults.
310
311         * TestResultServer/static-dashboards/builders.js:
312         * TestResultServer/static-dashboards/dashboard_base.js:
313         (currentBuilderGroupCategory):
314
315 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
316
317         Remove Chromium EWS bots from the queue status server
318         https://bugs.webkit.org/show_bug.cgi?id=113988
319
320         Reviewed by Benjamin Poulain.
321
322         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
323
324         * QueueStatusServer/app.yaml:
325         * QueueStatusServer/config/queues.py:
326         * QueueStatusServer/model/queues.py:
327         (Queue.short_name):
328         (Queue.display_name):
329         * QueueStatusServer/model/queues_unittest.py:
330         (QueueTest.test_short_name):
331         (QueueTest.test_display_name):
332         (QueueTest.test_name_with_underscores):
333         * QueueStatusServer/templates/activebots.html:
334
335 2013-04-10  Ojan Vafai  <ojan@chromium.org>
336
337         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
338         https://bugs.webkit.org/show_bug.cgi?id=114370
339
340         Reviewed by Ryosuke Niwa.
341
342         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
343         Unfortunately, there's no way to test this until this is committed and there is
344         a master restart.
345
346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
352         * TestResultServer/generate_builders_json.py:
353         * TestResultServer/static-dashboards/dashboard_base.js:
354         * TestResultServer/static-dashboards/loader.js:
355
356 2013-04-10  Glenn Adams  <glenn@skynav.com>
357
358         [Qt] Fix regression to test-webkitpy.
359         https://bugs.webkit.org/show_bug.cgi?id=114368
360
361         Reviewed by Ryosuke Niwa.
362
363         * Scripts/webkitpy/layout_tests/port/factory.py:
364         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
365         (PortFactory.get): Remove obsolete chromium port related code.
366         * Scripts/webkitpy/layout_tests/port/mac.py:
367         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
368
369 2013-04-10  Anders Carlsson  <andersca@apple.com>
370
371         Remove unneeded headers from FrameLoader.h
372         https://bugs.webkit.org/show_bug.cgi?id=114223
373
374         Reviewed by Geoffrey Garen.
375
376         Add back headers implicitly included by other headers.
377
378         * WebKitTestRunner/WorkQueueManager.cpp:
379
380 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
381
382         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
383         https://bugs.webkit.org/show_bug.cgi?id=114365
384
385         Reviewed by Martin Robinson.
386
387         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
388         The patch addresses crashes in the tally_event_reply method. It is already committed into the
389         at-spi2-atk source tree and will be available with the next stable release, after which the
390         patch should be removed and the dependency version bumped.
391
392         * gtk/jhbuild.modules:
393         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
394
395 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
396
397         [WinCairo] Unreviewed build fix. Correct DropBox download link.
398
399         * Scripts/update-webkit-wincairo-libs: Revise download URL to
400         match change in DropBox server behavior.
401
402 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
403
404         Removed an annoying message from svn-create-patch
405         https://bugs.webkit.org/show_bug.cgi?id=114332
406
407         Reviewed by Alexey Proskuryakov.
408
409         I see this message basically every time I write a patch, so it must not
410         be true.
411
412         * Scripts/svn-create-patch:
413         (generateDiff):
414
415 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
416
417         [GTK] Add support for Page Visibility
418         https://bugs.webkit.org/show_bug.cgi?id=97324
419
420         Reviewed by Sam Weinig.
421
422         Implemented test runner API for page visibility layout tests.
423
424         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
425         (TestRunner::resetPageVisibility):
426         (TestRunner::setPageVisibility):
427         * Scripts/webkitperl/FeatureList.pm:
428
429 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
430
431         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
432         https://bugs.webkit.org/show_bug.cgi?id=114342
433
434         Reviewed by Gyuyoung Kim.
435
436         Commit 148033 only added an implementation for the Mac port, which made
437         other ports fail most tests since loading the injected bundle failed
438         with a missing symbol.
439
440         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
441         (WTR::AccessibilityUIElement::pathDescription):
442
443 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
444
445         [EFL] Add spell checking option to MiniBrowser
446         https://bugs.webkit.org/show_bug.cgi?id=114282
447
448         Reviewed by Ryosuke Niwa.
449
450         Spell checking is enabled by adding a flag (t/text-checking)
451         with launching MiniBrowser.
452
453         * MiniBrowser/efl/main.c:
454         (window_create):
455         (elm_main):
456
457 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
458
459         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
460         https://bugs.webkit.org/show_bug.cgi?id=113281
461
462         Reviewed by Darin Adler.
463
464         * Scripts/run-gtk-tests:
465         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
466
467 2013-04-09  Glenn Adams  <glenn@skynav.com>
468
469         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
470
471         Unreviewed.
472
473         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
474         (RunTest.test_build_check):
475
476 2013-04-09  Glenn Adams  <glenn@skynav.com>
477
478         [webkitpy] Remove chromium ports.
479         https://bugs.webkit.org/show_bug.cgi?id=114326
480
481         Reviewed by Dirk Pranke.
482
483         As a side effect, also:
484
485         - remove chromium builders from webkitpy.layout_tests.port.builders
486         - remove chromium builders from rebaseline
487         - rewrite chromium dependent tests in rebaseline_unittest
488         - remove chromium platform from garden-o-matic
489         - select apple platform as default platform in garden-o-matic
490         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
491
492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
494         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
495         (BaselineOptimizerTest.test_move_baselines):
496         (BaselineOptimizerTest.test_efl):
497         (BaselineOptimizerTest.test_no_add_mac_future):
498         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
499         (BaselineOptimizerTest.test_common_directory_includes_root):
500         (BaselineOptimizerTest.test_complex_shadowing):
501         (BaselineOptimizerTest.test_virtual_ports_filtered):
502         * Scripts/webkitpy/layout_tests/port/builders.py:
503         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
504         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
505         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
506         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
507         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
508         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
509         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
510         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
511         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
512         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
513         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
514         * Scripts/webkitpy/layout_tests/port/factory.py:
515         (platform_options):
516         (PortFactory):
517         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
518         (FactoryTest.test_qt):
519         (FactoryTest.test_get_from_builder_name):
520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
521         (RunTest.test_build_check):
522         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
523         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
524         * Scripts/webkitpy/tool/commands/rebaseline.py:
525         (Rebaseline._builders_to_pull_from):
526         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
527         (_BaseTestCase):
528         (_BaseTestCase.setUp):
529         (TestRebaselineTest.setUp):
530         (TestRebaselineTest.test_baseline_directory):
531         (test_rebaseline_updates_expectations_file):
532         (test_rebaseline_does_not_include_overrides):
533         (test_rebaseline_test):
534         (test_rebaseline_test_and_print_scm_changes):
535         (test_rebaseline_and_copy_test):
536         (test_rebaseline_and_copy_test_no_existing_result):
537         (test_rebaseline_and_copy_test_with_lion_result):
538         (test_rebaseline_and_copy_no_overwrite_test):
539         (TestRebaselineExpectations.test_rebaseline_expectations):
540
541 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
542
543         newcommitbot (WKR) requires a subversion checkout
544         https://bugs.webkit.org/show_bug.cgi?id=114309
545
546         Reviewed by Benjamin Poulain.
547
548         Directly talk to the subversion server instead of relying on a local checkout.
549         This allows us to run WKR off of a git clone.
550
551         * Scripts/webkitpy/tool/commands/newcommitbot.py:
552         (NewCommitBot.next_work_item):
553         (NewCommitBot.process_work_item):
554
555 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
556
557         webkitbot refers to sheriffbot in help
558         https://bugs.webkit.org/show_bug.cgi?id=114307
559
560         Reviewed by Benjamin Poulain.
561
562         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
563
564         * Scripts/webkitpy/tool/bot/irc_command.py:
565         (Help):
566         (Help.execute):
567         (RollChromiumDEPS.execute):
568         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
569         (IRCBotTest.test_help):
570         * Scripts/webkitpy/tool/bot/sheriff.py:
571         (Sheriff.name):
572
573 2013-04-06  Roger Fong  <roger_fong@apple.com>
574
575         Kill old processes between runs on WinEWS bots.
576         Temporarily disable tests to let bots catch up again.
577
578         * EWSTools/start-queue-win.sh:
579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
580         (WinEWS):
581
582 2013-04-09  Glenn Adams  <glenn@skynav.com>
583
584         [webkitpy] Remove chromium deprecated port support.
585         https://bugs.webkit.org/show_bug.cgi?id=114228
586
587         Reviewed by Ryosuke Niwa.
588
589         * Scripts/webkitpy/common/config/ports.py:
590         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
591         (ChromiumPort): Removed.
592         (ChromiumAndroidPort): Removed.
593         (ChromiumXVFBPort): Removed.
594         * Scripts/webkitpy/common/config/ports_unittest.py:
595         (DeprecatedPortTest.test_chromium_port): Removed.
596         (DeprecatedPortTest.test_chromium_android_port): Removed.
597         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
598         * Scripts/webkitpy/tool/steps/update_unittest.py:
599         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
600         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
601
602 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
603
604         AX: The bounding paths should be made available through accessibility
605         https://bugs.webkit.org/show_bug.cgi?id=113817
606
607         Reviewed by David Kilzer.
608
609         Add a pathDescription property for testing so that it's possible
610         to verify that a path is being returned correctly.
611
612         * DumpRenderTree/AccessibilityUIElement.cpp:
613         (getPathDescriptionCallback):
614         (AccessibilityUIElement::pathDescription):
615         (AccessibilityUIElement::getJSClass):
616         * DumpRenderTree/AccessibilityUIElement.h:
617         (AccessibilityUIElement):
618         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
619         (_CGPathEnumerationIteration):
620         (AccessibilityUIElement::pathDescription):
621         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
622         (AccessibilityUIElement::pathDescription):
623         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
624         (WTR::AccessibilityUIElement::pathDescription):
625         (WTR):
626         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
627         (AccessibilityUIElement):
628         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
629         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
630         (WTR::AccessibilityUIElement::pathDescription):
631         (WTR):
632
633 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
634
635         [EFL] Declare TEST_THEME_DIR in a single place.
636         https://bugs.webkit.org/show_bug.cgi?id=114285
637
638         Reviewed by Anders Carlsson.
639
640         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
641
642         * DumpRenderTree/efl/CMakeLists.txt:
643         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
644         (DumpRenderTreeChrome::createView):
645         (DumpRenderTreeChrome::createInspectorView):
646         (DumpRenderTreeChrome::initialize):
647         (DumpRenderTreeChrome::onDownloadRequest):
648         * EWebLauncher/CMakeLists.txt:
649         * EWebLauncher/main.c:
650         (findThemePath):
651         * EWebLauncher/url_bar.c:
652         (url_bar_add):
653         * MiniBrowser/efl/CMakeLists.txt:
654         * MiniBrowser/efl/main.c:
655         (window_create):
656         * TestWebKitAPI/PlatformEfl.cmake:
657         * TestWebKitAPI/efl/PlatformWebView.cpp:
658         (TestWebKitAPI::PlatformWebView::PlatformWebView):
659         * WebKitTestRunner/PlatformEfl.cmake:
660         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
661         (WTR::PlatformWebView::PlatformWebView):
662
663 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
664
665         [GTK][AC] upversion of clutter and its dependecy
666         https://bugs.webkit.org/show_bug.cgi?id=114016
667
668         Reviewed by Gustavo Noronha Silva.
669
670         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
671
672         * gtk/jhbuild-optional.modules:
673
674 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
675
676         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
677         https://bugs.webkit.org/show_bug.cgi?id=89875
678
679         Reviewed by Maciej Stachowiak.
680
681         Add unit tests to verify if the handling of the open, openat, creat syscall
682         is being done right. We check if the Read/Write/ReadAndWrite permissions
683         are respected, if the canonical path is being resolved and if
684         the permissions are falling back to the topmost parent directory with a
685         policy set when the directory being opened has no policy.
686
687         We also test if any attempt of blocking SIGSYS is silently ignored.
688         SIGSYS cannot be blocked because in it's handler is where we hook
689         syscalls to the broker process.
690
691         Also added libseccomp to EFL's jhbuild to make the life of developers
692         willing to help easier.
693
694         * Scripts/webkitperl/FeatureList.pm:
695         * TestWebKitAPI/PlatformEfl.cmake:
696         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
697         (TestWebKitAPI):
698         (SeccompEnvironment):
699         (TestWebKitAPI::SeccompEnvironment::SetUp):
700         (TestWebKitAPI::SeccompEnvironment::TearDown):
701         (TestWebKitAPI::dummyHandler):
702         (TestWebKitAPI::TEST):
703         (TestWebKitAPI::stressTest):
704         * efl/jhbuild.modules:
705         * qmake/mkspecs/features/features.pri:
706
707 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
708
709         REGRESSION: Autocorrection doesn't work in DumpRenderTree
710         https://bugs.webkit.org/show_bug.cgi?id=113846
711
712         Reviewed by Alexey Proskuryakov.
713
714         The problem was that we were replacing NSSpellCheck's dictionary with our own
715         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
716
717         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
718         and "would" respectively in DumpRenderTree.
719
720         * DumpRenderTree/mac/DumpRenderTree.mm:
721         (resetDefaultsToConsistentValues):
722
723 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
724
725         Remove the gyp files for Tools
726         https://bugs.webkit.org/show_bug.cgi?id=114248
727
728         Reviewed by Ryosuke Niwa.
729
730         * DumpRenderTree/DumpRenderTree.gyp: Removed.
731         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
732         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
733         * DumpRenderTree/DumpRenderTree.gypi: Removed.
734         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
735         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
736         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
737         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
738
739 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
740
741         WKR (new-commit-bot) is too slow
742         https://bugs.webkit.org/show_bug.cgi?id=110087
743
744         Reviewed by Geoffrey Garen.
745
746         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
747         Just run "svn log -r <revision>" instead to cut down the delay.
748
749         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
750
751         * Scripts/webkitpy/tool/commands/newcommitbot.py:
752         (NewCommitBot):
753         (NewCommitBot.next_work_item):
754         (NewCommitBot._is_empty_log):
755         (NewCommitBot._update_checkout):
756
757 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
758
759         Build fix. Can't remove appendCustomBuildFlags.
760
761         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
762         (appendCustomBuildFlags):
763
764 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
765
766         Remove Chromium builders from build.webkit.org
767         https://bugs.webkit.org/show_bug.cgi?id=113990
768
769         Reviewed by Benjamin Poulain.
770
771         Removed.
772
773         * BuildSlaveSupport/build.webkit.org-config/config.json:
774         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
775         (InstallGtkDependencies):
776         (RunUnitTests.start):
777         (RunWebKit2Tests.start):
778         (Factory.__init__):
779         (unitTestsSupported):
780         (TestFactory.__init__):
781         (BuildAndTestFactory.__init__):
782         (BuildAndPerfTestFactory.__init__):
783         (BuildAndPerfTestWebKit2Factory.__init__):
784         (DownloadAndPerfTestFactory.__init__):
785         (loadBuilderConfig):
786         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
787
788 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
789
790         Remove HTML Notification
791         https://bugs.webkit.org/show_bug.cgi?id=114231
792
793         Reviewed by Ryosuke Niwa.
794
795         * qmake/mkspecs/features/features.pri:
796
797 2013-04-08  Glenn Adams  <glenn@skynav.com>
798
799         Remove chromium EWS support, and fix broken test.
800         https://bugs.webkit.org/show_bug.cgi?id=114221
801
802         Reviewed by Ryosuke Niwa.
803
804         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
805         (AbstractChromiumEWS): Removed.
806         (ChromiumLinuxEWS): Removed.
807         (ChromiumLinuxDebugEWS): Removed.
808         (ChromiumWindowsEWS): Removed.
809         (ChromiumAndroidEWS): Removed.
810         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
811         (EarlyWarningSystemTest): Fix misspelled class name.
812         (test_ewses): Fix entry point name to ensure test is run.
813
814 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
815
816         [WIN] Remove WebKit2 source code
817         https://bugs.webkit.org/show_bug.cgi?id=114096
818
819         Reviewed by Anders Carlsson.
820
821         Remove the windows specific parts of the MiniBrowser.
822
823         * MiniBrowser/MiniBrowser.vcproj: Removed.
824         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
825         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
826         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
827         * MiniBrowser/win/BrowserView.cpp: Removed.
828         * MiniBrowser/win/BrowserView.h: Removed.
829         * MiniBrowser/win/BrowserWindow.cpp: Removed.
830         * MiniBrowser/win/BrowserWindow.h: Removed.
831         * MiniBrowser/win/MiniBrowser.cpp: Removed.
832         * MiniBrowser/win/MiniBrowser.h: Removed.
833         * MiniBrowser/win/MiniBrowser.rc: Removed.
834         * MiniBrowser/win/main.cpp: Removed.
835         * MiniBrowser/win/resource.h: Removed.
836         * MiniBrowser/win/stdafx.cpp: Removed.
837         * MiniBrowser/win/stdafx.h: Removed.
838
839 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
840
841         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
842
843         * Scripts/webkitpy/common/config/irc.py:
844
845 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
846
847         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
848         https://bugs.webkit.org/show_bug.cgi?id=113139
849
850         Reviewed by Anders Carlsson.
851
852         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
853         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
854         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
855         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
856         (ToStringAndValueOfObject):
857         (ToStringAndValueOfObject::ToStringAndValueOfObject):
858         (ScriptableObject):
859         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
860         (ToStringAndValueOfObject::ScriptableObject::invoke):
861         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
862         (ToStringAndValueOfObject::NPP_GetValue):
863         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
864         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
865         * GNUmakefile.am:
866
867 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
868
869         [GTK] Bump gnome-themes-standard to 3.6.0
870         https://bugs.webkit.org/show_bug.cgi?id=114155
871
872         Reviewed by Martin Robinson.
873
874         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
875         dependency of gnome-themes-standard accordingly.
876
877 2013-04-08  David Levin  <levin@chromium.org>
878
879         Remove my watchlist entries.
880         https://bugs.webkit.org/show_bug.cgi?id=114180
881
882         Reviewed by Adam Barth.
883
884         * Scripts/webkitpy/common/config/committers.py:
885         * Scripts/webkitpy/common/config/watchlist:
886
887 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
888
889         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
890         https://bugs.webkit.org/show_bug.cgi?id=114161
891
892         Reviewed by Gyuyoung Kim.
893
894         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
895         as it is crashing due to Bug 111074.
896
897         * TestWebKitAPI/PlatformEfl.cmake:
898
899 2013-04-07  David Kilzer  <ddkilzer@apple.com>
900
901         Remove the rest of SVG_DOM_OBJC_BINDINGS
902         <http://webkit.org/b/114112>
903
904         Reviewed by Geoffrey Garen.
905
906         * Scripts/webkitperl/FeatureList.pm:
907         - Remove --svg-dom-objc-bindings switch.
908         * qmake/mkspecs/features/features.pri:
909         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
910
911 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
912
913         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
914         https://bugs.webkit.org/show_bug.cgi?id=114089
915
916         Reviewed by Chris Fleizach.
917
918         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
919         * DumpRenderTree/AccessibilityController.cpp:
920         * DumpRenderTree/AccessibilityUIElement.cpp:
921         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
922         (DumpRenderTreeChrome::DumpRenderTreeChrome):
923         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
924         (DumpRenderTreeChrome):
925
926 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
927
928         Build fix after r147857, remove remaining USE(JSC) guards.
929
930         Unreviewed.
931
932         * DumpRenderTree/config.h:
933         * TestWebKitAPI/config.h:
934         * WebKitTestRunner/config.h:
935
936 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
937
938         Rename sheriffbot to webkitbot
939         https://bugs.webkit.org/show_bug.cgi?id=114109
940
941         Reviewed by Benjamin Poulain.
942
943         Renamed since sheriffbot will be used in Blink.
944
945         * Scripts/webkitpy/tool/commands/sheriffbot.py:
946         (SheriffBot):
947         (SheriffBot.begin_work_queue):
948
949 2013-04-06  Oliver Hunt  <oliver@apple.com>
950
951         Unify the many and varied stack trace mechanisms, and make the result sane.
952         https://bugs.webkit.org/show_bug.cgi?id=114072
953
954         Reviewed by Filip Pizlo.
955
956         The commandline jsc executable no longer requires arguments, so
957         I've made run-jsc work without them.
958
959         * Scripts/run-jsc:
960
961 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
962
963         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
964         https://bugs.webkit.org/show_bug.cgi?id=114086
965
966         Reviewed by Tim Horton.
967
968         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
969
970 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
971
972         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
973         https://bugs.webkit.org/show_bug.cgi?id=114083
974
975         Reviewed by Ryosuke Niwa.
976
977         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
978         in TestWebKitAPI and WebKitTestRunner.
979
980         * TestWebKitAPI/config.h:
981         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
982         (TestWebKitAPI::InjectedBundleController::platformInitialize):
983         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
984         (WTR::InjectedBundle::platformInitialize):
985
986 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
987
988         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
989         https://bugs.webkit.org/show_bug.cgi?id=114094
990
991         Reviewed by Anders Carlsson.
992
993         * Scripts/run-jsc:
994
995 2013-04-05  Ojan Vafai  <ojan@chromium.org>
996
997         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
998         https://bugs.webkit.org/show_bug.cgi?id=114080
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         This way, the WebKit and Blink dashboard code can change as appropriate without
1003         needing to consider the other project's needs. This still doesn't update the
1004         buildbots to upload to the new location, or the dashboard code to pull the
1005         results.json files from the new location, but it at least allows for changing the
1006         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1007
1008         * TestResultServer/app.yaml:
1009
1010 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Re-enable testing on the commit queue
1013         https://bugs.webkit.org/show_bug.cgi?id=114078
1014
1015         Reviewed by Darin Adler.
1016
1017         Re-enabled the feature and the associated tests.
1018
1019         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1020         (CommitQueueTask.run):
1021         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1022         (CommitQueueTaskTest._run_through_task):
1023         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1024         (CommitQueueTest._mock_test_result):
1025
1026 2013-04-05  Oliver Hunt  <oliver@apple.com>
1027
1028         Unify the many and varied stack trace mechanisms, and make the result sane.
1029         https://bugs.webkit.org/show_bug.cgi?id=114072
1030
1031         Reviewed by Filip Pizlo.
1032
1033         The commandline jsc executable no longer requires arguments, so
1034         I've made run-jsc work without them.
1035
1036         * Scripts/run-jsc:
1037
1038 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1039
1040         AX: Make SVG Group containers accessible elements
1041         https://bugs.webkit.org/show_bug.cgi?id=113939
1042
1043         Reviewed by Simon Fraser.
1044
1045         Implement axController.elementAtPoint for iOS.
1046         Implement a correct version of clickPoint for iOS.
1047
1048         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1049         (AccessibilityController::elementAtPoint):
1050         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1051         (AccessibilityUIElement::clickPointX):
1052         (AccessibilityUIElement::clickPointY):
1053
1054 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1055
1056         Unreviewed, rolling out r147773 and r147774.
1057         http://trac.webkit.org/changeset/147773
1058         http://trac.webkit.org/changeset/147774
1059         https://bugs.webkit.org/show_bug.cgi?id=114056
1060
1061         Causing some exceptions on AppEngine I don't understand
1062         (Requested by rniwa on #webkit).
1063
1064         * QueueStatusServer/config/queues.py:
1065         * QueueStatusServer/model/queues.py:
1066         (Queue.short_name):
1067         (Queue.display_name):
1068         * QueueStatusServer/model/queues_unittest.py:
1069         (QueueTest.test_short_name):
1070         (QueueTest.test_display_name):
1071         (QueueTest.test_name_with_underscores):
1072
1073 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1074
1075         Fixed run-bindings-tests by removing V8
1076         https://bugs.webkit.org/show_bug.cgi?id=114053
1077
1078         Reviewed by Benjamin Poulain.
1079
1080         * Scripts/run-bindings-tests:
1081         (main):
1082
1083 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1084
1085         Build fix.
1086
1087         * QueueStatusServer/model/queues.py:
1088         (Queue.short_name):
1089         (Queue.display_name):
1090
1091 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1092
1093         Remove Chromium EWS bots from the queue status server
1094         https://bugs.webkit.org/show_bug.cgi?id=113988
1095
1096         Reviewed by Benjamin Poulain.
1097
1098         Removed Chromium EWS bots.
1099
1100         * QueueStatusServer/config/queues.py:
1101         * QueueStatusServer/model/queues.py:
1102         (Queue.short_name):
1103         (Queue.display_name):
1104         * QueueStatusServer/model/queues_unittest.py:
1105         (QueueTest.test_short_name):
1106         (QueueTest.test_display_name):
1107         (QueueTest.test_name_with_underscores):
1108
1109 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1110
1111         [EFL] Enable indexed database
1112         https://bugs.webkit.org/show_bug.cgi?id=107248
1113
1114         Reviewed by Alexis Menard.
1115
1116         * Scripts/webkitperl/FeatureList.pm:
1117
1118 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1119
1120         Remove vestiges of Chromium bits from watchlists.
1121         https://bugs.webkit.org/show_bug.cgi?id=114047
1122
1123         Reviewed by Ryosuke Niwa.
1124
1125         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1126
1127 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1128
1129         Add James Craig to the contributors list.
1130
1131         * Scripts/webkitpy/common/config/committers.py:
1132
1133 2013-04-04  Kent Tamura  <tkent@chromium.org>
1134
1135         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1136
1137         * Scripts/webkitpy/common/config/watchlist:
1138
1139 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1140
1141         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1142         https://bugs.webkit.org/show_bug.cgi?id=113997
1143
1144         Reviewed by Ryosuke Niwa.
1145
1146         Disable the tests until Ryosuke gets the time and hardware to have
1147         a testing commit-queue.
1148
1149         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1150         (CommitQueueTaskTest):
1151         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1152         (CommitQueueTest):
1153
1154 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1155
1156         Remove Chromium builders from build.webkit.org
1157         https://bugs.webkit.org/show_bug.cgi?id=113990
1158
1159         Reviewed by Benjamin Poulain.
1160
1161         Land the part to disable triggering of Chromium builders first so that we may start
1162         deleting more Chromium code that breaks the update step.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/config.json:
1165
1166 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1167
1168         Remove Chromium's DumpRenderTree
1169         https://bugs.webkit.org/show_bug.cgi?id=113989
1170
1171         Reviewed by Kent Tamura.
1172
1173         On second thought, let's not go to Camelot. It is a silly place.
1174
1175         * DumpRenderTree/mac/DumpRenderTree.mm:
1176         (resetDefaultsToConsistentValues):
1177
1178 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1179
1180         Nixed the defunct chromium folder from DumpRenderTree
1181         https://bugs.webkit.org/show_bug.cgi?id=113993
1182
1183         Reviewed by Ryosuke Niwa.
1184
1185         * DumpRenderTree/chromium: Removed.
1186         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1187         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1188         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1189         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1190         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1191         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1192         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1193         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1194         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1195         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1196         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1197         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1198         * DumpRenderTree/chromium/Task.cpp: Removed.
1199         * DumpRenderTree/chromium/Task.h: Removed.
1200         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1201         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1202         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1203         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1204         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1205         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1206         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1207         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1208         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1209         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1210         * DumpRenderTree/chromium/TestRunner: Removed.
1211         * DumpRenderTree/chromium/TestRunner/public: Removed.
1212         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1213         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1214         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1215         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1216         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1217         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1218         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1219         * DumpRenderTree/chromium/TestRunner/src: Removed.
1220         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1221         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1222         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1223         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1224         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1225         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1226         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1227         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1228         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1229         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1230         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1231         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1232         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1233         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1234         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1235         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1236         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1237         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1238         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1239         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1240         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1241         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1242         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1243         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1244         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1245         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1246         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1247         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1248         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1249         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1250         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1251         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1252         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1253         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1254         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1255         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1256         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1257         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1258         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1259         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1260         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1261         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1262         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1263         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1264         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1265         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1266         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1267         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1268         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1269         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1270         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1271         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1272         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1273         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1274         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1275         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1276         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1277         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1278         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1279         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1280         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1281         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1282         * DumpRenderTree/chromium/TestShell.h: Removed.
1283         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1284         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1285         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1286         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1287         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1288         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1289         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1290         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1291         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1292         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1293         * DumpRenderTree/chromium/config.h: Removed.
1294         * DumpRenderTree/chromium/fonts.conf: Removed.
1295
1296 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1297
1298         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1299
1300         Rubber stamped by Benjamin Poulain.
1301
1302         * RebaselineQueueServer: Removed.
1303         * RebaselineQueueServer/app.yaml: Removed.
1304         * RebaselineQueueServer/handlers: Removed.
1305         * RebaselineQueueServer/handlers/__init__.py: Removed.
1306         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1307         * RebaselineQueueServer/handlers/pages.py: Removed.
1308         * RebaselineQueueServer/index.yaml: Removed.
1309         * RebaselineQueueServer/main.py: Removed.
1310         * RebaselineQueueServer/model: Removed.
1311         * RebaselineQueueServer/model/__init__.py: Removed.
1312         * RebaselineQueueServer/model/queueentry.py: Removed.
1313         * RebaselineQueueServer/static: Removed.
1314         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1315         * RebaselineQueueServer/static/styles.css: Removed.
1316         * RebaselineQueueServer/templates: Removed.
1317         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1318         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1319         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1320         * RebaselineQueueServer/templates/home.html: Removed.
1321
1322 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1323
1324         Fix setup-commit-queue and temporarily disable testing on commit-queue
1325         https://bugs.webkit.org/show_bug.cgi?id=113979
1326
1327         Reviewed by Benjamin Poulain.
1328
1329         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1330         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1331
1332         * EWSTools/setup-commit-queue.sh:
1333         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1334         (CommitQueueTask.run):
1335
1336 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1337
1338         temporarily make flakiness dashboard work again webkit.org bots
1339         https://bugs.webkit.org/show_bug.cgi?id=113972
1340
1341         Reviewed by Ojan Vafai.
1342
1343         This patch disables the chromium.org layout test bots TestExpectations
1344         parsing temporarily until we can work out the right way to split into
1345         two instances for webkit.org and chromium.org and figure out which
1346         code to delete where :).
1347
1348         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1349
1350 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1351
1352         Fix webkitpy tests after r147678.
1353
1354         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1355         (CommitQueueTest.test_commit_queue):
1356         (test_manual_reject_during_processing):
1357
1358 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         The commit queue should use Mac MountainLion port
1361         https://bugs.webkit.org/show_bug.cgi?id=113971
1362
1363         Reviewed by Lucas Forschler.
1364
1365         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1366         * Scripts/webkitpy/tool/commands/queues.py:
1367         (CommitQueue):
1368
1369 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1370
1371         turn off running tests on chromium linux EWS bots
1372         https://bugs.webkit.org/show_bug.cgi?id=113959
1373
1374         Reviewed by Geoffrey Garen.
1375
1376         Now that the Chromium port is no longer being maintained
1377         there's little point in running the tests. Soon we should
1378         just shut this bot off altogether.
1379
1380         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1381         (ChromiumLinuxEWS):
1382
1383 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1384
1385         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1386
1387         * Scripts/webkitpy/common/config/watchlist:
1388
1389 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1390
1391         Indentation fix to get webkit-patch working again after r147625
1392
1393         Unreviewed.
1394
1395         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1396         (MacEWS):
1397         (MacWK2EWS):
1398
1399 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1400
1401         Turn tests back on for Mac WK1/WK2 EWS.
1402         
1403         Unreviewed.
1404         
1405         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1406         (MacEWS):
1407         (MacWK2EWS):
1408
1409 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1410
1411         [GTK][WK2] MiniBrowser custom URI scheme support
1412         https://bugs.webkit.org/show_bug.cgi?id=112419
1413
1414         Reviewed by Carlos Garcia Campos.
1415
1416         Add support for about URIs in MiniBrowser. An example about page is show
1417         with URI "about:minibrowser", the rest of the cases it will show a
1418         proper message explaining that the about page didn't exist.
1419
1420         Internally it uses "minibrowser-about" prefix instead of "about", but
1421         from the user point of view it works with "about" prefix.
1422
1423         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1424         (getInternalURI): Method to convert URIs from "about" prefix to
1425         "minibrowser-about".
1426         (getExternalURI): Opposite method.
1427         (webViewURIChanged): Use "about" prefix to show the URI to users.
1428         (webViewEnterFullScreen): Ditto.
1429         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1430         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1431         (aboutURISchemeRequestCallback): Callback to manage about calls.
1432         (main): Register the URI scheme to manage about URIs.
1433
1434 2013-04-03  Roger Fong  <roger_fong@apple.com>
1435
1436         Re-enable WinEWS tests.
1437
1438         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1439         (WinEWS):
1440
1441 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1442
1443         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1444         https://bugs.webkit.org/show_bug.cgi?id=113883
1445
1446         Reviewed by Martin Robinson.
1447
1448         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1449         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1450         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1451
1452 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1453
1454         [GTK] Include Pango in jhbuild-optional.modules
1455         https://bugs.webkit.org/show_bug.cgi?id=113878
1456
1457         Reviewed by Martin Robinson.
1458
1459         Since r147547 Pango 1.32.0 is required. Including the module in the
1460         JHBuild optional moduleset.
1461
1462         * gtk/jhbuild-optional.modules: Add Pango module.
1463
1464 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1465
1466         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1467         https://bugs.webkit.org/show_bug.cgi?id=113864
1468
1469         Moving setDefersLoading from TestRunnerQt to TestRunner
1470         requires access to the non-Qt TestRunner.
1471         As long as we instantiate both TestRunner and TestRunnerQt,
1472         we need a separate getter for the non-Qt TestRunner instance.
1473
1474         Reviewed by Simon Hausmann.
1475
1476         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1477         (WebPage::resetSettings):
1478         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1479         (DumpRenderTree::jscTestRunner):
1480         * DumpRenderTree/qt/TestRunnerQt.cpp:
1481         (TestRunner::setDefersLoading):
1482             Moving setDefersLoading from TestRunnerQt
1483             to TestRunner.
1484         * DumpRenderTree/qt/TestRunnerQt.h:
1485         (TestRunnerQt):
1486
1487 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1488
1489         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1490         https://bugs.webkit.org/show_bug.cgi?id=104779
1491
1492         Reviewed by Carlos Garcia Campos.
1493
1494         * Scripts/run-gtk-tests:
1495         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1496         passing in current trunk.
1497
1498 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1499
1500         Fix HAVE(QTTESTSUPPORT) logic
1501
1502         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1503         resulting in HAVE(QTTESTSUPPORT) never being true.
1504         Move that logic down in sanitizeFeatures.
1505
1506         Rubber-stamped by Tor Arne Vestbø.
1507
1508         * qmake/mkspecs/features/features.prf:
1509
1510 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1511
1512         [GTK] Bump required versions of some dependencies
1513         https://bugs.webkit.org/show_bug.cgi?id=113282
1514
1515         Reviewed by Martin Robinson.
1516
1517         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1518
1519 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1520
1521         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1522         https://bugs.webkit.org/show_bug.cgi?id=113809
1523
1524         Reviewed by Philippe Normand.
1525
1526         Newer Linux kernels have removed some deprecated macros from v4l2
1527         headers, causing gst-plugins-good's build to break. We don't need it
1528         right now, so just disable it.
1529
1530         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1531
1532 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1533
1534         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1535         https://bugs.webkit.org/show_bug.cgi?id=113535
1536
1537         Reviewed by Simon Hausmann.
1538
1539         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1540
1541         * qmake/mkspecs/features/features.prf:
1542
1543 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1544
1545         [Qt] Move logic of simple forwarding functions to TestRunner.
1546         https://bugs.webkit.org/show_bug.cgi?id=113863
1547
1548         Reviewed by Simon Hausmann.
1549
1550         * DumpRenderTree/qt/TestRunnerQt.cpp:
1551         (TestRunner::setTextDirection):
1552         (TestRunner::goBack):
1553         (TestRunner::evaluateScriptInIsolatedWorld):
1554         (TestRunner::addUserStyleSheet):
1555         * DumpRenderTree/qt/TestRunnerQt.h:
1556         (TestRunnerQt):
1557
1558 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1559
1560         [Qt] Disable media support using QuickTime if deployment target != SDK
1561
1562         We link to a single libWebKitSystemInterface static lib, so unless the
1563         deployment target matches the SDK let's not pretend like we'll be able
1564         to run on anything lower than the SDK version.
1565
1566         Reviewed by Simon Hausmann.
1567
1568         * qmake/mkspecs/features/features.prf:
1569
1570 2013-04-02  James Craig  <james@cookiecrook.com>
1571
1572         AXRoleDescripton for DL is "list"; should be "description list"
1573         https://bugs.webkit.org/show_bug.cgi?id=111665
1574
1575         Reviewed by Chris Fleizach.
1576
1577         Defining the role and description strings.
1578
1579         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1580
1581 2013-04-02  Roger Fong  <roger_fong@apple.com>
1582
1583         Unreviewed. Disable running tests on Win EWS queue.
1584
1585         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1586         (WinEWS):
1587
1588 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1589
1590         Disable running tests on the MAC WK2 EWS queue.
1591         
1592         Unreviewed.
1593         
1594         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1595         (MacWK2EWS):
1596
1597 2013-04-02  Julie Parent  <jparent@chromium.org>
1598
1599         Dashboard refactor: Move dashboard specific history related features to History.
1600         https://bugs.webkit.org/show_bug.cgi?id=113717
1601
1602         Reviewed by Ojan Vafai.
1603         
1604         Each dashboard now creates its own History object, with a custom
1605         configuration. This changes from just overriding global functions
1606         to passing in callbacks for generatePage, handleValidHashParameter,
1607         and handleQueryParameterChange. Same with passing in defaultStateValues
1608         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1609         variables.
1610         
1611         All functions related to these features are now (mostly) private
1612         function on History. 
1613         
1614         Loader no longer needs a loadingComplete callback, since it can just
1615         initialize the history object itself.
1616
1617         * TestResultServer/static-dashboards/aggregate_results.js:
1618         (handleValidHashParameter):
1619         * TestResultServer/static-dashboards/dashboard_base.js:
1620         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1621         (generatePage):
1622         (.switch.return):
1623         (handleQueryParameterChange):
1624         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1625         (resetGlobals):
1626         * TestResultServer/static-dashboards/history.js:
1627         (.):
1628         * TestResultServer/static-dashboards/loader.js:
1629         (.):
1630         * TestResultServer/static-dashboards/loader_unittests.js:
1631         * TestResultServer/static-dashboards/timeline_explorer.js:
1632         (generatePage):
1633         (initCurrentBuilderTestResults):
1634         * TestResultServer/static-dashboards/treemap.js:
1635         (generatePage):
1636         (.switch.return):
1637         (handleQueryParameterChange):
1638
1639 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1640
1641         Unreviewed, rolling out r147401.
1642         http://trac.webkit.org/changeset/147401
1643         https://bugs.webkit.org/show_bug.cgi?id=113767
1644
1645         The patch makes it extremely hard to set up the dependencies
1646         properly on the GTK builders (Requested by zdobersek on
1647         #webkit).
1648
1649         * gtk/jhbuild.modules:
1650
1651 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1652
1653         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1654         https://bugs.webkit.org/show_bug.cgi?id=113382
1655
1656         Reviewed by Gyuyoung Kim.
1657
1658         Do not show the empty tooltip box if the text is null.
1659
1660         * MiniBrowser/efl/main.c:
1661         (popup_menu_populate):
1662
1663 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         [GTK] Bump required versions of some dependencies
1666         https://bugs.webkit.org/show_bug.cgi?id=113282
1667
1668         Reviewed by Martin Robinson.
1669
1670         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1671
1672 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1673
1674         Unreviewed, rolling out r147319.
1675         http://trac.webkit.org/changeset/147319
1676         https://bugs.webkit.org/show_bug.cgi?id=113707
1677
1678         The unit test is still failing on the buildbot (Requested by
1679         zdobersek on #webkit).
1680
1681         * Scripts/run-gtk-tests:
1682         (TestRunner):
1683
1684 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1685
1686         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1687         https://bugs.webkit.org/show_bug.cgi?id=104779
1688
1689         Reviewed by Carlos Garcia Campos.
1690
1691         * Scripts/run-gtk-tests:
1692         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1693         passing in current trunk.
1694
1695 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1696
1697         Unreviewed, rolling out r147289.
1698         http://trac.webkit.org/changeset/147289
1699         https://bugs.webkit.org/show_bug.cgi?id=113678
1700
1701         broke Win7 (dbg) build (Requested by shinyak|gardener on
1702         #webkit).
1703
1704         * DumpRenderTree/DumpRenderTree.gypi:
1705         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1706         (WebTestRunner):
1707         (WebUserMediaClientMock):
1708         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1709         (WebTestRunner::WebUserMediaClientMock::taskList):
1710         * Scripts/webkitpy/style/checkers/cpp.py:
1711         (check_function_definition):
1712
1713 2013-03-31  Adam Barth  <abarth@webkit.org>
1714
1715         configure-svn-config.sh fails
1716         https://codereview.chromium.org/13392007/
1717
1718         Reviewed by Eric Seidel.
1719
1720         This script was trying to use "svn checkout" to dowload a file from
1721         svn.webkit.org, but "svn checkout" only works with directories.
1722         Instead, we should use "svn export".
1723
1724         * EWSTools/configure-svn-config.sh:
1725
1726 2013-03-31  Wei Jia  <wjia@chromium.org>
1727
1728         Allow WebUserMediaClientMock to be used by client
1729         https://bugs.webkit.org/show_bug.cgi?id=113633
1730
1731         Reviewed by Adam Barth.
1732
1733         Export WebUserMediaClientMock.
1734         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1735
1736         * DumpRenderTree/DumpRenderTree.gypi:
1737         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1738         (WebUserMediaClientMock):
1739         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1740         * Scripts/webkitpy/style/checkers/cpp.py:
1741         (check_function_definition):
1742
1743 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1744
1745         Expose FeatureObserver data to WebKit clients
1746         https://bugs.webkit.org/show_bug.cgi?id=113613
1747
1748         Reviewed by Sam Weinig.
1749
1750         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1751         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1752
1753 2013-03-29  Greg Hughes  <ghughes@apple.com>
1754
1755         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1756         https://bugs.webkit.org/show_bug.cgi?id=112276
1757
1758         Reviewed by Chris Fleizach.
1759
1760         Added support to test accessibility search predicates with multiple keys.  
1761
1762         * DumpRenderTree/AccessibilityUIElement.cpp:
1763         (uiElementForSearchPredicateCallback):
1764         * DumpRenderTree/AccessibilityUIElement.h:
1765         (AccessibilityUIElement):
1766         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1767         (AccessibilityUIElement::uiElementForSearchPredicate):
1768         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1769         (AccessibilityUIElement::uiElementForSearchPredicate):
1770         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1771         (AccessibilityUIElement::uiElementForSearchPredicate):
1772         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1773         (AccessibilityUIElement::uiElementForSearchPredicate):
1774         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1775         (AccessibilityUIElement::uiElementForSearchPredicate):
1776         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1777         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1778         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1779         (AccessibilityUIElement):
1780         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1781         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1782         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1784         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1785
1786 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         Fix a typo in r147147 to fix Mac EWS.
1789
1790         * Scripts/webkitpy/tool/commands/queues.py:
1791         (PatchProcessingQueue._new_port_name_from_old):
1792
1793 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1794
1795         [EFL] Build break with latest EFL libraries after r146265
1796         https://bugs.webkit.org/show_bug.cgi?id=113558
1797
1798         Unreviewed build fix.
1799
1800         * TestWebKitAPI/PlatformWebView.h:
1801         * WebKitTestRunner/PlatformWebView.h:
1802
1803 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1804
1805         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1806
1807         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1808         in libgcrypt build.
1809
1810 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1811
1812         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1813
1814         Unreviewed.
1815
1816         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1817         (MacEWS):
1818
1819 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1820
1821         Use the right OS name on Mac EWS instead of mac-future.
1822
1823         Rubber-stamped by Dirk Pranke.
1824
1825         * Scripts/webkitpy/tool/commands/queues.py:
1826         (PatchProcessingQueue._new_port_name_from_old):
1827         (PatchProcessingQueue.begin_work_queue):
1828         (PatchProcessingQueue._upload_results_archive_for_patch):
1829
1830 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1831
1832         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1833         https://bugs.webkit.org/show_bug.cgi?id=112546
1834
1835         Reviewed by Martin Robinson.
1836
1837         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1838         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1839
1840 2013-03-28  Ming Xie  <mxie@blackberry.com>
1841
1842         [BlackBerry] Committer Email Updates
1843         https://bugs.webkit.org/show_bug.cgi?id=113435
1844
1845         Reviewed by Rob Buis.
1846
1847         Add the @blackberry.com email address for all our BlackBerry
1848         WebKit committers. This is the first step for our email address
1849         migration.
1850
1851         * Scripts/webkitpy/common/config/committers.py:
1852
1853 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1854
1855         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1856         https://bugs.webkit.org/show_bug.cgi?id=113508
1857
1858         Reviewed by Martin Robinson.
1859
1860         Prevent the GStreamer plugin scanner to load system-wide
1861         plugins. Only the ones built in JHBuild should be loaded and used
1862         at runtime.
1863
1864         * efl/jhbuildrc:
1865         * gtk/jhbuildrc:
1866
1867 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1868
1869         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1870         https://bugs.webkit.org/show_bug.cgi?id=113386
1871
1872         Reviewed by Carlos Garcia Campos.
1873
1874         * Scripts/webkitdirs.pm:
1875         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1876         version to 3.0. Reflect this change so the builtDylibPathForName
1877         function doesn't fail to report the library as found.
1878
1879 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1880
1881         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1882         https://bugs.webkit.org/show_bug.cgi?id=113484
1883
1884         Unreviewed build fix.
1885
1886         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1887
1888         * TestWebKitAPI/CMakeLists.txt:
1889         * WebKitTestRunner/CMakeLists.txt:
1890
1891 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1892
1893         Revision for the internal jhbuild is too old
1894         https://bugs.webkit.org/show_bug.cgi?id=113324
1895
1896         Reviewed by Martin Robinson.
1897
1898         Update the minimum required version to a point where jhbuild won't
1899         fail installing packages when trying to remove a symlink to a directory.
1900
1901         * jhbuild/jhbuild-wrapper: Updated revision.
1902
1903 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1904
1905         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1906         https://bugs.webkit.org/show_bug.cgi?id=113203
1907
1908         Reviewed by Philippe Normand.
1909
1910         We build our libsoup without GNOME support. gst-plugins-good does separate
1911         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1912         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1913         build failures as the headers of those diverge. We do not use souphttpsrc, so
1914         disable it when building gst-plugins-good.
1915
1916         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1917
1918 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1919
1920         Build fix after r146852. Please another reference to the Lion leaks builder.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/config.json:
1923
1924 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1925
1926         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1927         https://bugs.webkit.org/show_bug.cgi?id=113421
1928
1929         Reviewed by Dirk Pranke.
1930
1931         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1932         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1933         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1934         in the GTK-specific TestExpectations files.
1935
1936         To avoid this only enable the warnings only when not using WKTR.
1937
1938         * Scripts/webkitpy/layout_tests/port/gtk.py:
1939         (GtkPort.warn_if_bug_missing_in_test_expectations):
1940
1941 2013-03-27  Antti Koivisto  <antti@apple.com>
1942
1943         Fix Zalan's email.
1944
1945         * Scripts/webkitpy/common/config/committers.py:
1946
1947 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1948
1949         master.cfg cleanup
1950         https://bugs.webkit.org/show_bug.cgi?id=113195
1951
1952         Reviewed by Ryosuke Niwa.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/config.json:
1955         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1956
1957 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1958
1959         master.cfg fine-tuning for Qt Mountain Lion Release bot
1960         https://bugs.webkit.org/show_bug.cgi?id=113191
1961
1962         Reviewed by Ryosuke Niwa.
1963
1964         * BuildSlaveSupport/build.webkit.org-config/config.json:
1965           - Rename the slave due to its location change.
1966           - Update the platform of the slave.
1967         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1968         (RunQtAPITests): Enable running WK2 API tests on Qt.
1969         (RunQtAPITests.start):
1970         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1971         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1972
1973 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1974
1975         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1976         https://bugs.webkit.org/show_bug.cgi?id=113403
1977
1978         Reviewed by Kenneth Rohde Christiansen.
1979
1980         As of Evas 1.7.5, when Wayland is detected on the system, support for
1981         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1982         The code, however, seems to depend on a few other flags which must be
1983         explicitly enabled.
1984
1985         If those additional GL-related options are passed, we end up
1986         having issues on the WebKit side, so disable Wayland support for
1987         now.
1988
1989         * efl/jhbuild.modules:
1990
1991 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1992
1993         Unreviewed, rolling out r146864.
1994         http://trac.webkit.org/changeset/146864
1995         https://bugs.webkit.org/show_bug.cgi?id=113391
1996
1997         causes crashes on Wk2 EFL release bot (Requested by drott on
1998         #webkit).
1999
2000         * Scripts/webkitperl/FeatureList.pm:
2001
2002 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2003
2004         [jhbuild] Correctly specify an alternate number of make jobs.
2005         https://bugs.webkit.org/show_bug.cgi?id=113396
2006
2007         Reviewed by Philippe Normand.
2008
2009         So far, we were using the `MAKEFLAGS' environment variable to pass the
2010         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2011         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2012
2013         We now behave more closely to the rest of the WebKit tools by first
2014         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2015         not set, just letting jhbuild itself figure out how many jobs to use.
2016
2017         * efl/jhbuildrc:
2018         * gtk/jhbuildrc:
2019
2020 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2021
2022         [Qt] Remove Qt specific WorkQueueItem definitions.
2023         https://bugs.webkit.org/show_bug.cgi?id=112891
2024
2025         This patch is preparation work for removing
2026         WorkQueue related code from TestRunnerQt and
2027         replacing it with generic TestRunner code.
2028
2029         Reviewed by Benjamin Poulain.
2030
2031         * DumpRenderTree/qt/TestRunnerQt.cpp:
2032         (TestRunnerQt::queueBackNavigation):
2033         (TestRunnerQt::queueForwardNavigation):
2034         (TestRunnerQt::queueLoadHTMLString):
2035         (TestRunnerQt::queueReload):
2036         (TestRunnerQt::queueLoadingScript):
2037         (TestRunnerQt::queueNonLoadingScript):
2038         (TestRunner::queueLoad):
2039         * DumpRenderTree/qt/TestRunnerQt.h:
2040         (TestRunnerQt):
2041         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2042         (LoadItem::invoke):
2043         (LoadHTMLStringItem::invoke):
2044         (LoadAlternateHTMLStringItem::invoke):
2045         (ReloadItem::invoke):
2046         (ScriptItem::invoke):
2047         (BackForwardItem::invoke):
2048         * DumpRenderTree/qt/WorkQueueItemQt.h:
2049         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2050         (LoadAlternateHTMLStringItem):
2051
2052 2013-03-26  Julie Parent  <jparent@chromium.org>
2053
2054         Flakiness dashboard: simplify logic around which tests to show.
2055         https://bugs.webkit.org/show_bug.cgi?id=113250
2056
2057         Reviewed by Ojan Vafai.
2058         
2059         The different filters for showing results are only used for layout
2060         tests, otherwise, we show everything.
2061         
2062         Change the defaults to false (what layout tests used), and only
2063         look at the values when viewing layout tests.
2064
2065         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2066         (htmlForTestsWithExpectationsButNoFailures):
2067         (shouldHideTest):
2068
2069 2013-03-26  Isaac Levy  <ilevy@google.com>
2070
2071         Update bots on test-results.appspot
2072         https://bugs.webkit.org/show_bug.cgi?id=113333
2073
2074         Reviewed by Ojan Vafai.
2075
2076         * TestResultServer/static-dashboards/builders.jsonp:
2077
2078 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2079
2080         Unreviewed GTK gardening.
2081
2082         * Scripts/run-gtk-tests:
2083         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2084
2085 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2086
2087         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2088         https://bugs.webkit.org/show_bug.cgi?id=113287
2089
2090         Reviewed by Jocelyn Turcotte.
2091
2092         * Scripts/run-qtwebkit-tests:
2093         (Options.__init__):
2094
2095 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2096
2097         [EFL] Enable IndexedDB by default
2098         https://bugs.webkit.org/show_bug.cgi?id=107248
2099
2100         Reviewed by Laszlo Gombos.
2101
2102         * Scripts/webkitperl/FeatureList.pm:
2103         Enable IndexedDB by default on EFL.
2104
2105 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2106
2107         Sheriffbot should explain rollout failures in a human readable form.
2108         https://bugs.webkit.org/show_bug.cgi?id=107092
2109
2110         Reviewed by Ryosuke Niwa.
2111
2112         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2113
2114         * Scripts/webkitpy/tool/bot/irc_command.py:
2115         (Rollout._check_diff_failure):
2116         (Rollout.execute):
2117         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2118         (IRCCommandTest.test_rollout):
2119
2120 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2121
2122         Unreviewed GTK gardening.
2123
2124         * Scripts/run-gtk-tests:
2125         (TestRunner): Skipping a failing unit test after r146518.
2126
2127 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2128
2129         Remove Lion leaks builder
2130         https://bugs.webkit.org/show_bug.cgi?id=113252
2131
2132         Reviewed by Andreas Kling.
2133
2134         Removed.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/config.json:
2137
2138 2013-03-25  Kent Tamura  <tkent@chromium.org>
2139
2140         Rename ENABLE_INPUT_TYPE_DATETIME
2141         https://bugs.webkit.org/show_bug.cgi?id=113254
2142
2143         Reviewed by Kentaro Hara.
2144
2145         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2146         Actually I'd like to remove the code, but we shouldn't remove it yet
2147         because we shipped products with it on some platforms.
2148
2149         * Scripts/webkitperl/FeatureList.pm:
2150         * qmake/mkspecs/features/features.pri:
2151
2152 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2153
2154         Remove one more line that was intended to be removed in r146657.
2155
2156         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2157         (summarize_results):
2158
2159 2013-03-25  Roger Fong  <roger_fong@apple.com>
2160
2161         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2162         Re-enable WinEWS tests.
2163
2164         * Scripts/webkitpy/common/config/ports.py:
2165         (WinPort.run_bindings_tests_command):
2166         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2167         (WinEWS):
2168
2169 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2170
2171         Unreviewed, rolling out r146793.
2172         http://trac.webkit.org/changeset/146793
2173         https://bugs.webkit.org/show_bug.cgi?id=113248
2174
2175         Fix did not work (Requested by rfong on #webkit).
2176
2177         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2178         (WinEWS):
2179
2180 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2181
2182         REGRESSION(r146657): Test failures reported incorrectly
2183         https://bugs.webkit.org/show_bug.cgi?id=113223
2184
2185         Reviewed by Dirk Pranke.
2186
2187         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2188
2189         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2190         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2191
2192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2193         (Manager.run):
2194
2195         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2196         (RunDetails.__init__):
2197         (summarize_results): Remove the line I intended to remove in r146657.
2198
2199         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2200         (logging_run): Return details instead of the exit code.
2201         (run_and_capture): Ditto.
2202
2203         (RunTest.test_full_results_html):
2204         (RunTest.test_hung_thread):
2205         (RunTest.test_no_tests_found):
2206         (RunTest.test_no_tests_found_2):
2207         (RunTest.test_repeat_each_iterations_num_tests):
2208         (RunTest.test_run_singly_actually_runs_tests):
2209         (RunTest.test_test_list):
2210         (RunTest.test_missing_and_unexpected_results):
2211         (RunTest.test_pixel_test_directories):
2212         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2213         (RunTest.test_crash_with_stderr):
2214         (RunTest.test_no_image_failure_with_image_diff):
2215         (RunTest.test_crash_log):
2216         (RunTest.test_exit_after_n_failures_upload):
2217         (RunTest.test_results_directory_absolute):
2218         (RunTest.test_results_directory_relative):
2219         (RunTest.test_retrying_and_flaky_tests):
2220         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2221         (RunTest.test_retrying_uses_retries_directory):
2222         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2223         (RunTest.test_output_diffs):
2224         (EndToEndTest.test_reftest_with_two_notrefs):
2225         (RebaselineTest.test_reset_results):
2226         (RebaselineTest.test_missing_results):
2227         (RebaselineTest.test_new_baseline):
2228
2229         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2230         (BuildBotPrinter.print_results):
2231         (BuildBotPrinter.print_unexpected_results):
2232         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2233         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2234
2235 2013-03-25  Julie Parent  <jparent@chromium.org>
2236
2237         Dashboard refactor: Move cross dashboard history related code into history.js.
2238         https://bugs.webkit.org/show_bug.cgi?id=113104
2239
2240         Reviewed by Ojan Vafai.
2241
2242         All functions relating to cross dashboard behavior move from being
2243         globals to methods on the history.History object. Names stay the same,
2244         except many are made private, ones that should have been constants now
2245         are, and the long standing TODO to change "currentState" to 
2246         dashboardSpecificState is done.
2247         
2248         We now create a global history object in dashboard_base, as an 
2249         intermediate measure.  Once the dashboard specific code is
2250         added to history, each DB will need to create its own, and this
2251         global will be eliminated.
2252         
2253         * TestResultServer/static-dashboards/aggregate_results.js:
2254         (handleValidHashParameter):
2255         (htmlForBuilder):
2256         (rawValuesHTML):
2257         * TestResultServer/static-dashboards/dashboard_base.js:
2258         (parseDashboardSpecificParameters):
2259         (defaultValue):
2260         (currentBuilderGroupCategory):
2261         (currentBuilderGroupName):
2262         (handleLocationChange):
2263         (expectationsMap):
2264         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2265         (generatePage):
2266         (.switch.return):
2267         (platformAndBuildType):
2268         (individualTests):
2269         (substringList):
2270         (processMissingAndExtraExpectations):
2271         (pathToFailureLog):
2272         (showPopupForBuild):
2273         (htmlForTestsWithExpectationsButNoFailures):
2274         (shouldHideTest):
2275         (isCrossBuilderView):
2276         (tableHeaders):
2277         (htmlForSingleTestRow):
2278         (htmlForTableColumnHeader):
2279         (generatePageForExpectationsUpdate):
2280         (handleUpdate):
2281         (nextUpdate):
2282         (setUpdateIndex):
2283         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2284         (.appendExpectationsItem):
2285         (loadExpectations):
2286         (.dummyNode.onload):
2287         (loadExpectationsLayoutTests):
2288         (appendExpectations):
2289         (htmlForNavBar):
2290         (checkBoxToToggleState):
2291         (linkHTMLToToggleState):
2292         (generatePageForBuilder):
2293         (isInvalidKeyForCrossBuilderView):
2294         (handleQueryParameterChange):
2295         (showLegend):
2296         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2297         (resetGlobals):
2298         (test):
2299         * TestResultServer/static-dashboards/history.js:
2300         (.):
2301         * TestResultServer/static-dashboards/history_unittests.js:
2302         * TestResultServer/static-dashboards/loader.js:
2303         (.):
2304         * TestResultServer/static-dashboards/loader_unittests.js:
2305         * TestResultServer/static-dashboards/timeline_explorer.js:
2306         (generatePage):
2307         (initCurrentBuilderTestResults):
2308         (selectBuild):
2309         (showResultsDelta):
2310         * TestResultServer/static-dashboards/treemap.js:
2311         (generatePage):
2312         (.switch.return):
2313         (handleFocus):
2314         * TestResultServer/static-dashboards/ui.js:
2315
2316 2013-03-25  Roger Fong  <roger_fong@apple.com>
2317
2318         Unreviewed. Enable WinEWS tests again.
2319
2320         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2321         (WinEWS):
2322
2323 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2324
2325         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2326         https://bugs.webkit.org/show_bug.cgi?id=112166
2327
2328         HarfBuzz 0.9.14 merged my patch for icu detection without
2329         pkg-config files, as needed by for example Ubuntu 12.04.
2330         This obsoletes our local workaround. Removed it for GTK and EFL.
2331
2332         Reviewed by Martin Robinson.
2333
2334         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2335         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2336         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2337         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2338
2339 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2340
2341         Unreviewed.  Move self from contributor to committer list.
2342
2343         * Scripts/webkitpy/common/config/committers.py:
2344
2345 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2346
2347         EWS should use a human readable port name when uploading layout test archives
2348         https://bugs.webkit.org/show_bug.cgi?id=113099
2349
2350         Reviewed by Dirk Pranke.
2351
2352         Use new port's object's name() method to report human readable port names.
2353         This will also help us resolving the bug to apply layout test results posted by EWS.
2354
2355         * Scripts/webkitpy/tool/bot/botinfo.py:
2356         (BotInfo.__init__): Take port's name.
2357         (BotInfo.summary_text):
2358
2359         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2360         (BotInfoTest.test_summary_text):
2361
2362         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2363         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2364
2365         * Scripts/webkitpy/tool/commands/queues.py:
2366         (PatchProcessingQueue.__init__): Initialize self._port.
2367         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2368         and use that for the attachment filename and the comment posted.
2369
2370         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2371         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2372         "mac-snowleopard" as expected for TestPort.
2373
2374 2013-03-22  Roger Fong  <roger_fong@apple.com>
2375
2376         Unreviewed. Turn off EWS test on Win again.
2377         The battle continues.
2378
2379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2380         (WinEWS):
2381
2382 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         NRWT: Enable pixel tests when retrying tests
2385         https://bugs.webkit.org/show_bug.cgi?id=112898
2386
2387         Reviewed by Dirk Pranke.
2388
2389         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2390         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2391         if we've forced pixel tests in the retry.
2392         (Manager._run_tests):
2393         (Manager._clean_up_run): Fixed the capitalizations.
2394         (Manager._force_pixel_tests_if_needed): Added.
2395
2396         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2397         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2398         'image_diff_percent' if it doesn't already exist.
2399
2400         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2401         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2402         treat this as a regular regression instead of a flakiness.
2403
2404         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2405         run had image diffs.
2406
2407         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2408         (summarized_results):
2409
2410         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2411         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2412         Also removed some dead code.
2413
2414         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2415         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2416         is set and pixel_tests_enabled is set to false.
2417         (EndToEndTest.test_reftest_with_two_notrefs):
2418
2419 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2420
2421         Make it possible to run layout tests on Retina MBP
2422         https://bugs.webkit.org/show_bug.cgi?id=93673
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2427         windows on 2x machines still run at 1x.
2428
2429         * DumpRenderTree/mac/DumpRenderTree.mm:
2430         (createWebViewAndOffscreenWindow):
2431         Reset the window resolution to 1x on creation.
2432         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2433         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2434         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2435         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2436         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2437         (WTR::PlatformWebView::PlatformWebView):
2438         Add NSWindow details, reset the window resolution to 1x on creation.
2439
2440 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Leak bots shouldn't build
2443         https://bugs.webkit.org/show_bug.cgi?id=112774
2444
2445         Reviewed by Simon Fraser.
2446
2447         Since leak bots use regular debug builds, there is no need to build on these bots.
2448         Simply downloading builds will dramatically improve the cycle time of these bots.
2449
2450         * BuildSlaveSupport/build.webkit.org-config/config.json:
2451         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2452         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2453         TestFactory instead of BuildAndTestFactory.
2454
2455 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2456
2457         [Qt] Fix the TestWebKitAPI build
2458         https://bugs.webkit.org/show_bug.cgi?id=113044
2459
2460         Reviewed by Tor Arne Vestbø.
2461
2462         The generate-forwarding-headers script would only be run
2463         after the targets in InjectedBundle.pri since the second
2464         addStrictSubdirOrderBetween call in
2465         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2466         the derived_sources -> injected_bundle order in SUBDIRS.
2467
2468         Fix it by only moving the dependent target at the end of
2469         SUBDIRS, don't touch its dependency.
2470
2471         * qmake/mkspecs/features/functions.prf:
2472
2473 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2474
2475         [EFL][WK2] View is not focused when fullscreen mode toggled
2476         https://bugs.webkit.org/show_bug.cgi?id=113009
2477
2478         Reviewed by Laszlo Gombos.
2479
2480         Set focus on view when fullscreen mode enabled/disabled
2481         by FullScreen API.
2482
2483         * MiniBrowser/efl/main.c:
2484         (on_fullscreen_accept):
2485         (on_fullscreen_deny):
2486
2487 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2488
2489         nrwt is no longer saving retry results in the retries/ subdirectory
2490         https://bugs.webkit.org/show_bug.cgi?id=112995
2491
2492         Reviewed by Ojan Vafai.
2493
2494         I think this has been broken a long time, unfortunately. This
2495         patch should fix that.
2496
2497         In order to do so, I had to pass the directory to use from
2498         the Worker object through the SingleTestWriter to the
2499         TestResultWriter. While I was plumbing that through, I rationalized
2500         the order of the parameter arguments a bit ...
2501
2502         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2503         (Worker._run_single_test):
2504         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2505         (run_single_test):
2506         (SingleTestRunner.__init__):
2507         (SingleTestRunner._run_compare_test):
2508         (SingleTestRunner._run_rebaseline):
2509         (SingleTestRunner._run_reftest):
2510         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2511         (write_test_result):
2512         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2513         (TestResultWriterTest.test_reftest_diff_image):
2514         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2515         (RunTest.test_retrying_uses_retries_directory):
2516
2517 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2518
2519         JSC profiler should have an at-a-glance report of the success of DFG optimization
2520         https://bugs.webkit.org/show_bug.cgi?id=112988
2521
2522         Reviewed by Geoffrey Garen.
2523
2524         * Scripts/display-profiler-output:
2525
2526 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2527
2528         [chromium] Linux ASAN WebKit canary is running out of memory
2529         https://bugs.webkit.org/show_bug.cgi?id=112978
2530
2531         Reviewed by Tony Chang.
2532
2533         Running the AddressSanitizer on a crash takes a lot of
2534         memory, so we should serialize access to it to avoid running
2535         out of memory on a machine.
2536
2537         * Scripts/webkitpy/layout_tests/port/chromium.py:
2538         (ChromiumPort._get_crash_log):
2539         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2540         (HttpLock.__init__):
2541         (HttpLock.wait_for_httpd_lock):
2542
2543 2013-03-21  Min Qin  <qinmin@chromium.org>
2544
2545         Cleanup android media layout test code
2546         https://bugs.webkit.org/show_bug.cgi?id=112944
2547
2548         Reviewed by Adam Barth.
2549
2550         Chromium change: https://codereview.chromium.org/12892010/
2551         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2552         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2553         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2554         Instead, we should switch to use content shell for layout tests.
2555
2556         * DumpRenderTree/chromium/TestShell.cpp:
2557         (TestShell::resetTestController):
2558
2559 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2560
2561         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2562         https://bugs.webkit.org/show_bug.cgi?id=112953
2563
2564         Reviewed by Tony Chang.
2565
2566         When I created the DumpRenderTree_resources target in r144863 I
2567         forgot to declare the needed dependencies on the other resource
2568         targets. Due to a quirk of ordering, this appears to have been fine
2569         w/ ninja but not w/ Xcode (which is still being used on the chromium
2570         mac valgrind bots). Declaring the dependencies fixes the build
2571         failures.
2572
2573         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2574
2575 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2576
2577         [WinCairo] Correct assert in Empty BitmapImage Test.
2578         https://bugs.webkit.org/show_bug.cgi?id=112934
2579
2580         Reviewed by Tim Horton.
2581
2582         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2583         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2584         to avoid ref counting assertion when leaving test scope.
2585
2586 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2587
2588         [GTK] generate-feature-defines-files is incompatible with Python3
2589         https://bugs.webkit.org/show_bug.cgi?id=112956
2590
2591         Reviewed by Martin Robinson.
2592
2593         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2594         method on the dictionary objects when iterating through said dictionaries.
2595
2596         * gtk/generate-feature-defines-files:
2597         (write_feature_defines_header):
2598         (write_flattened_feature_defines_file):
2599
2600 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2601
2602         kill-old-processes spits out error messages on Mac
2603         https://bugs.webkit.org/show_bug.cgi?id=112878
2604
2605         Reviewed by Jessie Berlin.
2606
2607         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2608         included in the list of options grep --help shows.
2609
2610         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2611
2612         * BuildSlaveSupport/kill-old-processes:
2613         (main):
2614
2615 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2616
2617         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2618         https://bugs.webkit.org/show_bug.cgi?id=112597
2619
2620         Reviewed by Xan Lopez.
2621
2622         These were introduced for the Chromium port in r105295. We need
2623         dummy implementations in order to compile the BlackBerry port.
2624
2625         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2626         (AccessibilityUIElement::scrollToMakeVisible):
2627         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2628         (AccessibilityUIElement::scrollToGlobalPoint):
2629
2630 2013-03-21  Roger Fong  <roger_fong@apple.com>
2631
2632         Re-enable WinEWS tests following r146376.
2633
2634         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2635         (WinEWS):
2636
2637 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2638
2639         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2640
2641         * Scripts/webkitpy/common/config/committers.py:
2642
2643 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2644
2645         [GTK] Missing atk in install-dependencies script
2646         https://bugs.webkit.org/show_bug.cgi?id=112272
2647
2648         Reviewed by Gustavo Noronha Silva.
2649
2650         * gtk/install-dependencies: Add missing atk dependency.
2651
2652 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2653
2654         [GTK] Missing backslash in install-dependencies script
2655         https://bugs.webkit.org/show_bug.cgi?id=112907
2656
2657         Reviewed by Philippe Normand.
2658
2659         * gtk/install-dependencies: Add missing backslash to dependencies
2660         list.
2661
2662 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2663
2664         EWS bots have stopped uploading results to bugzilla
2665         https://bugs.webkit.org/show_bug.cgi?id=101091
2666
2667         Reviewed by Adam Barth.
2668
2669         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2670         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2671         this relative file path resoled to a file inside a non-existent directory for "zip".
2672
2673         Fixed the bug by resolving both test results directory and zip archive paths in
2674         LayoutTestResultsReader.archive.
2675
2676         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2677         in the future.
2678
2679         * Scripts/webkitpy/common/system/filesystem_mock.py:
2680         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2681
2682         * Scripts/webkitpy/common/system/workspace.py:
2683         (Workspace.create_zip): Log the source path when "zip" failed.
2684
2685         * Scripts/webkitpy/common/system/workspace_mock.py:
2686         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2687
2688         * Scripts/webkitpy/common/system/workspace_unittest.py:
2689         (WorkspaceTest.test_create_zip_exception): Test that.
2690
2691         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2692         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2693         This is the actual bug fix.
2694
2695         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2696         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2697
2698 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2699
2700         [chromium] move WebThemeEngine implementations to TestRunner library
2701         https://bugs.webkit.org/show_bug.cgi?id=112751
2702
2703         Reviewed by Adam Barth.
2704
2705         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2706         * DumpRenderTree/DumpRenderTree.gypi:
2707         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2708         (WebKit):
2709         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2710         (WebTestRunner::TestInterfaces::themeEngine):
2711         (WebTestRunner):
2712         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2713         (WebKit):
2714         (TestInterfaces):
2715         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2716         (WebTestRunner::WebTestInterfaces::themeEngine):
2717         (WebTestRunner):
2718         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2719         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2720         (WebTestRunner):
2721         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2722         (WebTestRunner::WebTestThemeControlWin::box):
2723         (WebTestRunner::WebTestThemeControlWin::line):
2724         (WebTestRunner::WebTestThemeControlWin::triangle):
2725         (WebTestRunner::WebTestThemeControlWin::roundRect):
2726         (WebTestRunner::WebTestThemeControlWin::oval):
2727         (WebTestRunner::WebTestThemeControlWin::circle):
2728         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2729         (WebTestRunner::WebTestThemeControlWin::markState):
2730         (WebTestRunner::WebTestThemeControlWin::draw):
2731         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2732         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2733         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2734         (WebTestRunner):
2735         (WebTestThemeControlWin):
2736         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2737         (WebTestRunner):
2738         (WebTestThemeEngineMac):
2739         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2740         (+[FakeActiveWindow alwaysActiveWindow]):
2741         (+[FakeActiveWindow alwaysInactiveWindow]):
2742         (-[FakeActiveWindow initWithActiveControls:]):
2743         (-[FakeActiveWindow _hasActiveControls]):
2744         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2745         (WebTestRunner):
2746         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2747         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2748         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2749         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2750         (WebTestRunner):
2751         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2752         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2753         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2754         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2755         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2756         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2757         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2758         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2759         (WebTestRunner::WebTestThemeEngineWin::getSize):
2760         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2761         (WebTestRunner):
2762         (WebTestThemeEngineWin):
2763         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2764         * DumpRenderTree/chromium/TestShell.cpp:
2765         (TestShell::initialize):
2766         * DumpRenderTree/chromium/TestShell.h:
2767         (WebKit):
2768         * DumpRenderTree/chromium/TestShellMac.mm:
2769         (platformInit):
2770         * DumpRenderTree/chromium/TestShellWin.cpp:
2771         (platformInit):
2772         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2773
2774 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2775
2776         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2777
2778         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2779         New property sheet that does not link against CoreFoundation and
2780         CFNetwork.
2781         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2782         Use new TestWebKitAPICommonWinCairo property sheet.
2783         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2784         Ditto.
2785
2786 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2787
2788         [WinCairo] Unreviewed build fix for VS2010.
2789
2790         Had to add WinCairo-specific property sheets to deal with some
2791         library and path differences with the main Apple port.
2792
2793         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2794         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2795         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2796         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2797         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2798         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2799
2800 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2801
2802         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2803         https://bugs.webkit.org/show_bug.cgi?id=112849
2804
2805         Reviewed by Sam Weinig.
2806
2807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2810
2811 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2812
2813         [WinCairo] Build WebKit Tools under VS2010
2814         https://bugs.webkit.org/show_bug.cgi?id=112821
2815
2816         Reviewed by Tim Horton.
2817
2818         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2819         Add WinCairo-specific build target.
2820         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2821         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2822         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2823         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2824         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2825         Add WinCairo-specific build target.
2826         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2827         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2828         Add WinCairo-specific build target.
2829         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2830         WinCairo-specific build target.
2831         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2832         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2833         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2834         specific build target.
2835         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2836         WinCairo-specific build target.
2837         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2838         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2839         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2840
2841 2013-03-20  Roger Fong  <roger_fong@apple.com>
2842
2843         API test gardening AppleWin port.
2844
2845         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2846
2847         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2848         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2849
2850 2013-03-20  Roger Fong  <roger_fong@apple.com>
2851
2852         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2853
2854         * EWSTools/start-queue-win.sh:
2855
2856 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2857
2858         Unreviewed, add myself to committers.py.
2859
2860 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2861
2862         Unreviewed. Adding another email for me.
2863
2864         * Scripts/webkitpy/common/config/committers.py:
2865
2866 2013-03-20  Justin Novosad  <junov@google.com>
2867
2868         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2869         https://bugs.webkit.org/show_bug.cgi?id=112605
2870
2871         Reviewed by James Robinson.
2872
2873         Deleting all the code that was used for propagating and supporting
2874         the Chromium setting for disabling deferred 2d canvas rendering.
2875
2876         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2877         (main):
2878         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2879         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2880         (WebTestRunner::WebPreferences::reset):
2881         (WebTestRunner::WebPreferences::applyTo):
2882         * DumpRenderTree/chromium/TestShell.cpp:
2883         (TestShell::TestShell):
2884         (TestShell::resetWebSettings):
2885         (TestShell::runFileTest):
2886         * DumpRenderTree/chromium/TestShell.h:
2887         (TestShell):
2888
2889 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2890
2891         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2892         https://bugs.webkit.org/show_bug.cgi?id=112699.
2893
2894         Reviewed by Adam Barth.
2895
2896         * Scripts/webkitpy/layout_tests/port/qt.py:
2897         (QtPort._search_paths):
2898         (QtPort._port_specific_expectations_files):
2899         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2900         (QtPortTest):
2901         (QtPortTest._assert_search_path):
2902         (QtPortTest._assert_expectations_files):
2903
2904 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2905
2906         [Qt] Enable kerning by default
2907         https://bugs.webkit.org/show_bug.cgi?id=112704
2908
2909         Reviewed by Jocelyn Turcotte.
2910
2911         Disable kerning by default, since some reference test expectations
2912         expect kerning to be default off.
2913
2914         * DumpRenderTree/qt/TestRunnerQt.cpp:
2915         (TestRunnerQt::reset):
2916         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2917         (WTR::activateFonts):
2918
2919 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2920
2921         [Qt] Remove empty function stubs from TestRunnerQt.
2922         https://bugs.webkit.org/show_bug.cgi?id=112799
2923
2924         We are reducing the code in TestRunnerQt step by step,
2925         in order to finally replace all of it with the generic
2926         TestRunner implementation.
2927         This patch removes several simple function stubs that
2928         currently do not implement any actual functionality.
2929
2930         Reviewed by Kenneth Rohde Christiansen.
2931
2932         * DumpRenderTree/qt/TestRunnerQt.cpp:
2933         * DumpRenderTree/qt/TestRunnerQt.h:
2934         (TestRunnerQt):
2935
2936 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2937
2938         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2939         https://bugs.webkit.org/show_bug.cgi?id=112687
2940
2941         Reviewed by Kenneth Rohde Christiansen.
2942
2943         Hide the SearchBar by default on window creation.
2944
2945         * MiniBrowser/efl/main.c:
2946         (window_create):
2947
2948 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2949
2950         Unreviewed, rolling out r146304.
2951         http://trac.webkit.org/changeset/146304
2952         https://bugs.webkit.org/show_bug.cgi?id=112788
2953
2954         to many expectations to update (Requested by antonm on
2955         #webkit).
2956
2957         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2958         * DumpRenderTree/DumpRenderTree.gypi:
2959         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2960         (WebKit):
2961         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2962         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2963         (TestInterfaces):
2964         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2965         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2966         * DumpRenderTree/chromium/TestShell.cpp:
2967         (TestShell::initialize):
2968         * DumpRenderTree/chromium/TestShell.h:
2969         (WebKit):
2970         * DumpRenderTree/chromium/TestShellMac.mm:
2971         (platformInit):
2972         * DumpRenderTree/chromium/TestShellWin.cpp:
2973         (platformInit):
2974         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2975         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2976         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2977         (WebThemeControlDRTWin::box):
2978         (WebThemeControlDRTWin::line):
2979         (WebThemeControlDRTWin::triangle):
2980         (WebThemeControlDRTWin::roundRect):
2981         (WebThemeControlDRTWin::oval):
2982         (WebThemeControlDRTWin::circle):
2983         (WebThemeControlDRTWin::nestedBoxes):
2984         (WebThemeControlDRTWin::markState):
2985         (WebThemeControlDRTWin::draw):
2986         (WebThemeControlDRTWin::drawTextField):
2987         (WebThemeControlDRTWin::drawProgressBar):
2988         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2989         (WebThemeControlDRTWin):
2990         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2991         (WebThemeEngineDRTMac):
2992         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2993         (+[FakeActiveWindow alwaysActiveWindow]):
2994         (+[FakeActiveWindow alwaysInactiveWindow]):
2995         (-[FakeActiveWindow initWithActiveControls:]):
2996         (-[FakeActiveWindow _hasActiveControls]):
2997         (WebThemeEngineDRTMac::paintScrollbarThumb):
2998         (stateToHIEnableState):
2999         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3000         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3001         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3002         (webRectToSkIRect):
3003         (drawControl):
3004         (drawTextField):
3005         (drawProgressBar):
3006         (WebThemeEngineDRTWin::paintButton):
3007         (WebThemeEngineDRTWin::paintMenuList):
3008         (WebThemeEngineDRTWin::paintScrollbarArrow):
3009         (WebThemeEngineDRTWin::paintScrollbarThumb):
3010         (WebThemeEngineDRTWin::paintScrollbarTrack):
3011         (WebThemeEngineDRTWin::paintSpinButton):
3012         (WebThemeEngineDRTWin::paintTextField):
3013         (WebThemeEngineDRTWin::paintTrackbar):
3014         (WebThemeEngineDRTWin::paintProgressBar):
3015         (WebThemeEngineDRTWin::getSize):
3016         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3017         (WebThemeEngineDRTWin):
3018         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3019
3020 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3021
3022         [Qt] Support -webkit-font-smoothing
3023         https://bugs.webkit.org/show_bug.cgi?id=106009
3024
3025         Reviewed by Jocelyn Turcotte.
3026
3027         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3028
3029         * DumpRenderTree/qt/TestRunnerQt.cpp:
3030         (TestRunnerQt::reset):
3031
3032 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3033
3034         [GTK] accessibility/aria-scrollbar-role.html is failing
3035         https://bugs.webkit.org/show_bug.cgi?id=98358
3036
3037         Reviewed by Martin Robinson.
3038
3039         Adds support for checking accessibility object's orientation.
3040         Orientation is checked by retrieving proper state of accessibility object.
3041
3042         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3043         (checkElementState):
3044         (AccessibilityUIElement::orientation):
3045         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3046         (WTR::AccessibilityUIElement::orientation):
3047
3048 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3049
3050         [chromium] move WebThemeEngine implementations to TestRunner library
3051         https://bugs.webkit.org/show_bug.cgi?id=112751
3052
3053         Reviewed by Adam Barth.
3054
3055         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3056         * DumpRenderTree/DumpRenderTree.gypi:
3057         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3058         (WebKit):
3059         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3060         (WebTestRunner::TestInterfaces::themeEngine):
3061         (WebTestRunner):
3062         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3063         (WebKit):
3064         (TestInterfaces):
3065         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3066         (WebTestRunner::WebTestInterfaces::themeEngine):
3067         (WebTestRunner):
3068         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3069         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3070         (WebTestRunner):
3071         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3072         (WebTestRunner::WebTestThemeControlWin::box):
3073         (WebTestRunner::WebTestThemeControlWin::line):
3074         (WebTestRunner::WebTestThemeControlWin::triangle):
3075         (WebTestRunner::WebTestThemeControlWin::roundRect):
3076         (WebTestRunner::WebTestThemeControlWin::oval):
3077         (WebTestRunner::WebTestThemeControlWin::circle):
3078         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3079         (WebTestRunner::WebTestThemeControlWin::markState):
3080         (WebTestRunner::WebTestThemeControlWin::draw):
3081         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3082         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3083         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3084         (WebTestRunner):
3085         (WebTestThemeControlWin):
3086         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3087         (WebTestRunner):
3088         (WebTestThemeEngineMac):
3089         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3090         (+[FakeActiveWindow alwaysActiveWindow]):
3091         (+[FakeActiveWindow alwaysInactiveWindow]):
3092         (-[FakeActiveWindow initWithActiveControls:]):
3093         (-[FakeActiveWindow _hasActiveControls]):
3094         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3095         (WebTestRunner):
3096         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3097         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3098         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3099         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3100         (WebTestRunner):
3101         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3102         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3103         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3104         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3105         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3106         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3107         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3108         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3109         (WebTestRunner::WebTestThemeEngineWin::getSize):
3110         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3111         (WebTestRunner):
3112         (WebTestThemeEngineWin):
3113         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3114         * DumpRenderTree/chromium/TestShell.cpp:
3115         (TestShell::initialize):
3116         * DumpRenderTree/chromium/TestShell.h:
3117         (WebKit):
3118         * DumpRenderTree/chromium/TestShellMac.mm:
3119         (platformInit):
3120         * DumpRenderTree/chromium/TestShellWin.cpp:
3121         (platformInit):
3122         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3123
3124 2013-03-19  Tony Chang  <tony@chromium.org>
3125
3126         Move testRunner.setTouchDragDropEnabled to internals.settings
3127         https://bugs.webkit.org/show_bug.cgi?id=112739
3128
3129         Reviewed by Adam Barth.
3130
3131         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3132         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3133         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3134         (TestRunner): Remove unnecessary code.
3135         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3136         (WebTestRunner::WebPreferences::reset):
3137         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3138
3139 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3140
3141         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3142         https://bugs.webkit.org/show_bug.cgi?id=112754
3143
3144         Reviewed by Darin Fisher.
3145
3146         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3147         now that it's always defined.
3148
3149         * DumpRenderTree/chromium/WebViewHost.cpp:
3150         * DumpRenderTree/chromium/WebViewHost.h:
3151         (WebViewHost):
3152
3153 2013-03-19  Kenneth Russell  <kbr@google.com>
3154
3155         Unreviewed, rolling out r146290.
3156         http://trac.webkit.org/changeset/146290
3157         https://bugs.webkit.org/show_bug.cgi?id=112751
3158
3159         Broke Chromium Mac build.
3160
3161         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3162         * DumpRenderTree/DumpRenderTree.gypi:
3163         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3164         (WebKit):
3165         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3166         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3167         (TestInterfaces):
3168         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3169         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3170         * DumpRenderTree/chromium/TestShell.cpp:
3171         (TestShell::initialize):
3172         * DumpRenderTree/chromium/TestShell.h:
3173         (WebKit):
3174         * DumpRenderTree/chromium/TestShellMac.mm:
3175         (platformInit):
3176         * DumpRenderTree/chromium/TestShellWin.cpp:
3177         (platformInit):
3178         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3179         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3180         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3181         (WebThemeControlDRTWin::box):
3182         (WebThemeControlDRTWin::line):
3183         (WebThemeControlDRTWin::triangle):
3184         (WebThemeControlDRTWin::roundRect):
3185         (WebThemeControlDRTWin::oval):
3186         (WebThemeControlDRTWin::circle):
3187         (WebThemeControlDRTWin::nestedBoxes):
3188         (WebThemeControlDRTWin::markState):
3189         (WebThemeControlDRTWin::draw):
3190         (WebThemeControlDRTWin::drawTextField):
3191         (WebThemeControlDRTWin::drawProgressBar):
3192         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3193         (WebThemeControlDRTWin):
3194         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3195         (WebThemeEngineDRTMac):
3196         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3197         (+[FakeActiveWindow alwaysActiveWindow]):
3198         (+[FakeActiveWindow alwaysInactiveWindow]):
3199         (-[FakeActiveWindow initWithActiveControls:]):
3200         (-[FakeActiveWindow _hasActiveControls]):
3201         (WebThemeEngineDRTMac::paintScrollbarThumb):
3202         (stateToHIEnableState):
3203         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3204         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3205         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3206         (webRectToSkIRect):
3207         (drawControl):
3208         (drawTextField):
3209         (drawProgressBar):
3210         (WebThemeEngineDRTWin::paintButton):
3211         (WebThemeEngineDRTWin::paintMenuList):
3212         (WebThemeEngineDRTWin::paintScrollbarArrow):
3213         (WebThemeEngineDRTWin::paintScrollbarThumb):
3214         (WebThemeEngineDRTWin::paintScrollbarTrack):
3215         (WebThemeEngineDRTWin::paintSpinButton):
3216         (WebThemeEngineDRTWin::paintTextField):
3217         (WebThemeEngineDRTWin::paintTrackbar):
3218         (WebThemeEngineDRTWin::paintProgressBar):
3219         (WebThemeEngineDRTWin::getSize):
3220         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3221         (WebThemeEngineDRTWin):
3222         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3223
3224 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3225
3226         [EFL] canvas-fallback-content.html is failing
3227         https://bugs.webkit.org/show_bug.cgi?id=111998
3228
3229         Reviewed by Chris Fleizach.
3230
3231         Adds support for getting platform name.
3232
3233         * DumpRenderTree/TestRunner.cpp:
3234         (TestRunner::staticValues):
3235         * DumpRenderTree/TestRunner.h:
3236         (TestRunner):
3237         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3238         (TestRunner::platformName):
3239
3240 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3241
3242         [chromium] move WebThemeEngine implementations to TestRunner library
3243         https://bugs.webkit.org/show_bug.cgi?id=112751
3244
3245         Reviewed by Adam Barth.
3246
3247         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3248         * DumpRenderTree/DumpRenderTree.gypi:
3249         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3250         (WebKit):
3251         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3252         (WebTestRunner::TestInterfaces::themeEngine):
3253         (WebTestRunner):
3254         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3255         (WebKit):
3256         (TestInterfaces):
3257         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3258         (WebTestRunner::WebTestInterfaces::themeEngine):
3259         (WebTestRunner):
3260         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3261         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3262         (WebTestRunner):
3263         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3264         (WebTestRunner::WebTestThemeControlWin::box):
3265         (WebTestRunner::WebTestThemeControlWin::line):
3266         (WebTestRunner::WebTestThemeControlWin::triangle):
3267         (WebTestRunner::WebTestThemeControlWin::roundRect):
3268         (WebTestRunner::WebTestThemeControlWin::oval):
3269         (WebTestRunner::WebTestThemeControlWin::circle):
3270         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3271         (WebTestRunner::WebTestThemeControlWin::markState):
3272         (WebTestRunner::WebTestThemeControlWin::draw):
3273         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3274         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3275         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3276         (WebTestRunner):
3277         (WebTestThemeControlWin):
3278         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3279         (WebTestRunner):
3280         (WebTestThemeEngineMac):
3281         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3282         (+[FakeActiveWindow alwaysActiveWindow]):
3283         (+[FakeActiveWindow alwaysInactiveWindow]):
3284         (-[FakeActiveWindow initWithActiveControls:]):
3285         (-[FakeActiveWindow _hasActiveControls]):
3286         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3287         (WebTestRunner):
3288         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3289         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3290         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3291         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3292         (WebTestRunner):
3293         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3294         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3295         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3296         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3297         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3298         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3299         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3300         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3301         (WebTestRunner::WebTestThemeEngineWin::getSize):
3302         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3303         (WebTestRunner):
3304         (WebTestThemeEngineWin):
3305         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3306         * DumpRenderTree/chromium/TestShell.cpp:
3307         (TestShell::initialize):
3308         * DumpRenderTree/chromium/TestShell.h:
3309         (WebKit):
3310         * DumpRenderTree/chromium/TestShellMac.mm:
3311         (platformInit):
3312         * DumpRenderTree/chromium/TestShellWin.cpp:
3313         (platformInit):
3314         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3315
3316 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3317
3318         [EFL][WK2] Separate WebView further from EwkView
3319         https://bugs.webkit.org/show_bug.cgi?id=111591
3320
3321         Reviewed by Caio Marcelo de Oliveira Filho.
3322
3323         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3324         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3325         since we can afford it having EWKViewGetWKView() private API to access WKView.
3326
3327         * TestWebKitAPI/PlatformWebView.h:
3328         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3329         (TestWebKitAPI::TEST):
3330         * TestWebKitAPI/efl/PlatformWebView.cpp:
3331         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3332         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3333         (TestWebKitAPI::PlatformWebView::resizeTo):
3334         (TestWebKitAPI::PlatformWebView::page):
3335         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3336         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3337         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3338         * WebKitTestRunner/PlatformWebView.h:
3339         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3340         (WTR::EventSenderProxy::dispatchEvent):
3341         (WTR::EventSenderProxy::keyDown):
3342         (WTR::EventSenderProxy::sendTouchEvent):
3343         (WTR::EventSenderProxy::setTouchModifier):
3344         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3345         (WTR::PlatformWebView::PlatformWebView):
3346         (WTR::PlatformWebView::~PlatformWebView):
3347         (WTR::PlatformWebView::resizeTo):
3348         (WTR::PlatformWebView::page):
3349         (WTR::PlatformWebView::focus):
3350         (WTR::PlatformWebView::windowSnapshotImage):
3351
3352 2013-03-19  Roger Fong  <roger_fong@apple.com>
3353
3354         Changes to VS2010 project files should only trigger builds on Windows bots.
3355         https://bugs.webkit.org/show_bug.cgi?id=112731
3356
3357         Reviewed by Timothy Horton.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3360         (_should_file_trigger_build):
3361
3362 2013-03-19  Roger Fong  <roger_fong@apple.com>
3363
3364         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3365
3366         * Scripts/webkitpy/tool/steps/runtests.py:
3367         (RunTests.run):
3368         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3369         (RunTestsTest.test_webkit_run_unit_tests):
3370
3371 2013-03-19  Julie Parent  <jparent@chromium.org>
3372
3373         Dashboards: Introduce history namespace and unit tests.
3374         https://bugs.webkit.org/show_bug.cgi?id=112645
3375
3376         Reviewed by Ojan Vafai.
3377         
3378         Laying the framework for introducing the new history object and
3379         namespace.  This moves only static functions into the history
3380         namespace, and moves corresponding unit tests into seperate
3381         unit test file.
3382
3383         * TestResultServer/static-dashboards/aggregate_results.html:
3384         * TestResultServer/static-dashboards/dashboard_base.js:
3385         (parseCrossDashboardParameters):
3386         (parseDashboardSpecificParameters):
3387         (parseParameters):
3388         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3389         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3390         (.switch.return):
3391         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3392         * TestResultServer/static-dashboards/history.js: Added.
3393         * TestResultServer/static-dashboards/history_unittests.js: Added.
3394         * TestResultServer/static-dashboards/loader.js:
3395         (.):
3396         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3397         * TestResultServer/static-dashboards/run-unittests.html:
3398         * TestResultServer/static-dashboards/timeline_explorer.html:
3399         * TestResultServer/static-dashboards/timeline_explorer.js:
3400         * TestResultServer/static-dashboards/treemap.html:
3401         * TestResultServer/static-dashboards/treemap.js:
3402         (.switch.return):
3403         * TestResultServer/static-dashboards/ui.js:
3404
3405 2013-03-19  Daniel Bates  <dbates@webkit.org>
3406
3407         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3408         https://bugs.webkit.org/show_bug.cgi?id=112732
3409
3410         Reviewed by Eric Seidel.
3411
3412         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3413         of an existing file cannot be applied.
3414
3415         In particular, svn-{apply, unapply} compensate for differences in line endings
3416         by converting the line endings in a diff to match the line endings in the target
3417         file. The diff(1) command precedes the last line of a diff that adds a newline
3418         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3419         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3420         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3421         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3422         the newline characters in this special character sequence to match the line endings
3423         in the target file.
3424
3425         * Scripts/VCSUtils.pm:
3426         (parseDiff):
3427         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3428         Added tests:
3429             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3430             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3431             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3432             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3433         (escapeNewLineCharacters): Added.
3434         (toMacLineEndings): Added.
3435
3436 2013-03-19  James Robinson  <jamesr@chromium.org>
3437
3438         [chromium] Remove compositor settings that don't go through WebKit
3439         https://bugs.webkit.org/show_bug.cgi?id=112718
3440
3441         Reviewed by Adam Barth.
3442
3443         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3444         (main):
3445         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3446         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3447         (WebTestRunner::WebPreferences::reset):
3448         (WebTestRunner::WebPreferences::applyTo):
3449         * DumpRenderTree/chromium/TestShell.cpp:
3450         (TestShell::TestShell):
3451         (TestShell::resetWebSettings):
3452         * DumpRenderTree/chromium/TestShell.h:
3453         (TestShell):
3454
3455 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3456
3457         Unreviewed, rolling out r146101.
3458         https://bugs.webkit.org/show_bug.cgi?id=111884
3459
3460         re-enable custom freetype on asan; this needs to be on
3461         now that the bot is running lucid.
3462
3463         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3464
3465 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3466
3467         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3468         https://bugs.webkit.org/show_bug.cgi?id=112365
3469
3470         Reviewed by Benjamin Poulain.
3471
3472         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3473         harcoding it in wtf/Platform.h
3474
3475         * Scripts/webkitperl/FeatureList.pm:
3476
3477 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3478
3479         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3480         https://bugs.webkit.org/show_bug.cgi?id=94782
3481
3482         Based on patch by Csaba Osztrogonác.
3483         Reviewed by Jocelyn Turcotte.
3484
3485         The diff image is generated with bright red indicating errors, but letting the base image
3486         shine through so the context of the error-pixel can be identified.
3487
3488         * DumpRenderTree/qt/ImageDiff.cpp:
3489         (main):
3490
3491 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3492
3493         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3494
3495         Rubber-stamped by Csaba Osztrogonác.
3496
3497         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3498         since the latter might not cover the former.
3499
3500         * QtTestBrowser/launcherwindow.cpp:
3501         (LauncherWindow::print):
3502
3503 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3504
3505         Style tweeks to default.css.
3506         
3507         Rubber-stamped by David Kilzer.
3508         
3509         Give visited links a different color to other links, so you can
3510         see which builds you've viewed.
3511         
3512         Make the <small> text less tiny.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3515         (small):
3516         (a:link,a:visited,a:active):
3517         (a:visited):
3518
3519 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3520
3521         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3522         https://bugs.webkit.org/show_bug.cgi?id=112494
3523
3524         Reviewed by Dirk Pranke.
3525
3526         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3527         Also merged two pairs of methods to cleanup the code.
3528
3529         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3530         (PerfTestsRunner.run): Merged _upload_and_show_results.
3531         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3532
3533 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3534
3535         [chromium] build xdisplaycheck when building DRT
3536         https://bugs.webkit.org/show_bug.cgi?id=112636
3537
3538         Reviewed by Tony Chang.
3539
3540         It appears that we need xdisplaycheck to be built in order for
3541         Xvfb to be started correctly on the bots, and DRT was missing
3542         a dependency on it. This may be the cause of the ASAN bot not
3543         starting up properly (it only builds DRT).
3544
3545         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3546
3547 2013-03-18  David Levin  <levin@chromium.org>
3548
3549         Implement icon change notification dump for Chromium's test shell.
3550         https://bugs.webkit.org/show_bug.cgi?id=112614
3551
3552         This was previously implemented for some other platforms in r58111
3553         and r116547.
3554
3555         In r122806, fast/dom/icon-url-property.html stopped using it, but
3556         it is useful for tests, so I plan to re-add it to that test again.
3557
3558         Reviewed by Jochen Eisinger.
3559
3560         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3561         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3562          icon change notifications from WebKit may be logged in test output.
3563         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3564         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3565         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3566         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3567         (WebTestRunner):
3568         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3569         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3570         (TestRunner):
3571         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3572         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3573         (WebTestRunner):
3574         * DumpRenderTree/chromium/WebViewHost.cpp:
3575         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3576         * DumpRenderTree/chromium/WebViewHost.h:
3577         (WebViewHost):
3578
3579 2013-03-18  Julie Parent  <jparent@chromium.org>
3580
3581         Cleanup: Move js for treemap and aggregate_results into own js files.
3582         https://bugs.webkit.org/show_bug.cgi?id=112618
3583
3584         Reviewed by Dirk Pranke.
3585         
3586         No functional changes, just moving the code into separate js file
3587         rather than inlined in the html, so we can test it, make it more
3588         modular, etc.  Other dashboard types are already done this way.
3589
3590         * TestResultServer/static-dashboards/aggregate_results.html:
3591         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3592         (generatePage):
3593         (handleValidHashParameter):
3594         (htmlForBuilder):
3595         (rawValuesHTML):
3596         (chartHTML):
3597         (filteredValues):
3598         (chart):
3599         (htmlForRevisionRows):
3600         (wrapHTMLInTable):
3601         (htmlForSummaryTable):
3602         (valuesPerExpectation):
3603         (htmlForTestType):
3604         (htmlForTableRow):
3605         (extendedEncode):
3606         * TestResultServer/static-dashboards/treemap.html:
3607         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3608         (humanReadableTime):
3609         (convertToWebTreemapFormat):
3610         (reverseSortByAverage):
3611         (generatePage):
3612         (focusPath):
3613         (.switch.return):
3614         (handleQueryParameterChange):
3615         (extractName):
3616         (fullName):
3617         (handleFocus.):
3618         (handleFocus):
3619
3620 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3621
3622         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3623         https://bugs.webkit.org/show_bug.cgi?id=112622
3624
3625         Reviewed by Dirk Pranke.
3626
3627         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3628         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3629
3630 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3631
3632         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3633         https://bugs.webkit.org/show_bug.cgi?id=112619
3634
3635         Reviewed by Dirk Pranke.
3636
3637         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3638         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3639
3640         * Scripts/webkitpy/layout_tests/port/gtk.py:
3641         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3642         Port._webkit_baseline_path method.
3643         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3644         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3645         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3646         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3647         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3648         that are expected based on the builder name.
3649
3650 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3651
3652         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3653         https://bugs.webkit.org/show_bug.cgi?id=112571
3654
3655         Reviewed by Adam Barth.
3656
3657         Update function declarations for new WebFileSystemType enum. (All
3658         changes are behind an #ifdef so we can sync required changes in embedders.)
3659
3660         * DumpRenderTree/chromium/WebViewHost.cpp:
3661         (WebViewHost::openFileSystem):
3662         (WebViewHost::deleteFileSystem):
3663         * DumpRenderTree/chromium/WebViewHost.h:
3664         (WebViewHost):
3665
3666 2013-03-18  Julie Parent  <jparent@chromium.org>
3667
3668         Cleanup: Move timeline_exporer js out of html file into js.
3669         https://bugs.webkit.org/show_bug.cgi?id=112188
3670
3671         Reviewed by Dirk Pranke.
3672         
3673         Moves the javascript out of the html file and into a new js file.
3674         This follows the format of flakiness_dashboard.{html|js}.
3675         
3676         Also moves code from dashboard_base that is used only by this one
3677         dashboard, and makes it private to the dashboard.
3678
3679         * TestResultServer/static-dashboards/dashboard_base.js:
3680         * TestResultServer/static-dashboards/timeline_explorer.html:
3681         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3682         (generatePage):
3683         (initCurrentBuilderTestResults):
3684         (shouldShowWebKitRevisionsOnly):
3685         (updateTimelineForBuilder.):
3686         (updateTimelineForBuilder):
3687         (selectBuild):
3688         (updateBuildIndicator):
3689         (.addRow):
3690         (.addNumberRow):
3691         (.inspectorNode.getElementsByTagName.0.onclick):
3692         (.inspectorNode.getElementsByTagName.1.onclick):
3693         (.inspectorNode.getElementsByTagName.2.onclick):
3694         (updateBuildInspector):
3695         (showResultsDelta):
3696         (decompressResults.addFlakyDelta):
3697         (decompressResults):
3698
3699 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3700
3701         Unreviewed, rolling out r145272.
3702         http://trac.webkit.org/changeset/145272
3703         https://bugs.webkit.org/show_bug.cgi?id=111884
3704
3705         Turns out the ASAN build is still broken; possibly there's
3706         something still setting LD_LIBRARY_PATH, or possibly there's
3707         something else wrong. In the meantime, we need it to work again.
3708
3709         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3710
3711 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3712
3713         delete-stale-build-files is too aggressive
3714         https://bugs.webkit.org/show_bug.cgi?id=112595
3715
3716         Reviewed by Tim Horton.
3717
3718         It appears that whitelisting file extensions to keep is not a good idea.
3719         Blacklist files to delete instead, and only delete .o files for now.
3720         We can add more file extensions as needed.
3721
3722         * BuildSlaveSupport/delete-stale-build-files:
3723
3724 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3725
3726         Disable accessibility notifications after each test
3727         https://bugs.webkit.org/show_bug.cgi?id=112579
3728
3729         Reviewed by Tim Horton.
3730         
3731         In WebKitTestRunner, if any tests triggered accessibility notifications,
3732         the global notification handler would thereafter be active, and fire
3733         notifications for all subsequent tests.
3734         
3735         Fix by implementing AccessibilityController::resetToConsistentState() for
3736         Mac, and using it to clear the global notification handler.
3737
3738         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3739         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3740         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3741         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3742         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3743         (e.g. because of -autorelease).
3744         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3745         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3746         if there is one.
3747         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3748         Add -stopObserving
3749         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3750         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3751         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3752         center.
3753
3754 2013-03-18  Dana Jansens  <danakj@chromium.org>
3755
3756         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3757         https://bugs.webkit.org/show_bug.cgi?id=112392
3758
3759         Reviewed by James Robinson.
3760
3761         Removes the command line flag option from DRT.
3762
3763         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3764         (main):
3765
3766 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3767
3768         [GTK] plugins/plugin-clip-subframe.html is failing
3769         https://bugs.webkit.org/show_bug.cgi?id=112570
3770
3771         Reviewed by Martin Robinson.
3772
3773         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3774
3775 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3776
3777         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3778         https://bugs.webkit.org/show_bug.cgi?id=112442
3779
3780         Reviewed by Gustavo Noronha Silva.
3781
3782         * GtkLauncher/main.c:
3783         (reloadCb):
3784         (createToolbar):
3785         (createWindow):
3786
3787 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3788
3789         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3790         https://bugs.webkit.org/show_bug.cgi?id=112205
3791
3792         Disable this API test until Geoff can fix it.
3793
3794         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3795         (TestWebKitAPI::TEST):
3796
3797 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3798
3799         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3800         https://bugs.webkit.org/show_bug.cgi?id=112478
3801
3802         Reviewed by Tony Chang.
3803
3804         There is nothing that ensures that the log messages from the plugin
3805         come in before the layout test finished loading.
3806
3807         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3808         (PassDifferentNPPStruct::NPP_SetWindow):
3809         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3810         (NPP_SetWindow):
3811
3812 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3813
3814         Have the mac port support per_test_timeout in webkitpy
3815         https://bugs.webkit.org/show_bug.cgi?id=112466
3816
3817         Reviewed by Dirk Pranke.
3818         
3819         Both WTR and DRT handle --timeout arguments, so we can
3820         have the scripts pass the timeout values down to the tools.
3821
3822         * Scripts/webkitpy/layout_tests/port/mac.py:
3823         (MacPort.supports_per_test_timeout):
3824
3825 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3826
3827         Remove setAsynchronousSpellCheckingEnabled from test runners
3828         https://bugs.webkit.org/show_bug.cgi?id=112362
3829
3830         Reviewed by Tony Chang.
3831
3832         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3833         in internals.settings, so all ports can share it.
3834
3835         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3836         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3837         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3838         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3839         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3840         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3841         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3842         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3843         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3844         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3845         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3846         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3847
3848 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3849
3850         Fix the stupid unit tests.
3851
3852         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3853         (test_sample_process):
3854
3855 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3856
3857         Collect samples for unresponsive web processes
3858         https://bugs.webkit.org/show_bug.cgi?id=112409
3859
3860         Reviewed by Tim Horton.
3861         
3862         When we detect that a subprocess was unresponsive, run the 'sample'
3863         tool on that process, for the Mac port.
3864         
3865         The sample will be linked to from the results.html page, next
3866         to the crash log link.
3867
3868         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3869         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3870         look for samples on disk.
3871         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3872         (TestResultWriter):
3873         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3874         -sample.txt files, and have it copy their contents to a new file
3875         next to the test that spawned them (as we do for crash logs).
3876         * Scripts/webkitpy/layout_tests/port/base.py:
3877         (Port.look_for_new_samples): Base class does nothing for sampling.
3878         * Scripts/webkitpy/layout_tests/port/driver.py:
3879         (Driver._check_for_driver_crash): Kick off a sample if we detected
3880         that the subprocess was unresponsive.
3881         * Scripts/webkitpy/layout_tests/port/mac.py:
3882         (MacPort.sample_file_path): Utility to generate the file path
3883         to the generated sample files at the top level of layout-test-results.
3884         (MacPort.look_for_new_crash_logs): Fix typo
3885         (MacPort.look_for_new_samples): New function to find sample files.
3886         (MacPort.sample_process): Use the utility function to get the file path.
3887
3888 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3889
3890         [Qt] Remove simple getters and setters from TestRunnerQt
3891         https://bugs.webkit.org/show_bug.cgi?id=112343
3892
3893         Reviewed by Benjamin Poulain.
3894
3895         The removed functions and boolean members
3896         are being replaced by the implementations in the
3897         generic TestRunner.h.
3898
3899         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3900         (DumpRenderTree::dumpFrameScrollPosition):
3901         (DumpRenderTree::dumpFramesAsText):
3902         (DumpRenderTree::dump):
3903         (DumpRenderTree::titleChanged):
3904         (DumpRenderTree::dumpDatabaseQuota):
3905         (DumpRenderTree::dumpApplicationCacheQuota):
3906         (DumpRenderTree::statusBarMessage):
3907         (DumpRenderTree::createWindow):
3908         * DumpRenderTree/qt/TestRunnerQt.cpp:
3909         (TestRunnerQt::reset):
3910         * DumpRenderTree/qt/TestRunnerQt.h:
3911         (TestRunnerQt):
3912
3913 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3914
3915         Update the link on build.webkit.org to refer to perf.webkit.org
3916         https://bugs.webkit.org/show_bug.cgi?id=112416
3917
3918         Reviewed by Philip Rogers.
3919
3920         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3921
3922         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3923
3924 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3925
3926         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3927         https://bugs.webkit.org/show_bug.cgi?id=112394
3928
3929         Reviewed by Philippe Normand.
3930
3931         * GtkLauncher/main.c:
3932         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3933
3934 2013-03-14  Andreas Kling  <akling@apple.com>
3935
3936         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3937         <http://webkit.org/b/111815>
3938         <rdar://problem/13380145>
3939
3940         Reviewed by Anders Carlsson.
3941
3942         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3943         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3944         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3945
3946         * WebKitTestRunner/PlatformWebView.h:
3947         (PlatformWebView):
3948         * WebKitTestRunner/TestController.cpp:
3949         (WTR::TestController::createOtherPage):
3950         (WTR::TestController::createWebViewWithOptions):
3951         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3952         (WTR::PlatformWebView::didInitializeClients):
3953
3954 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3955
3956         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3957         https://bugs.webkit.org/show_bug.cgi?id=112122
3958
3959         Reviewed by Kenneth Rohde Christiansen.
3960
3961         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3962
3963         * MiniBrowser/efl/main.c:
3964         (_Browser_Window):
3965         (search_box_show):
3966         (search_box_hide):
3967         (on_key_down):
3968         (on_url_changed):
3969         (on_search_field_aborted):
3970         (on_search_field_activated):
3971         (on_search_field_clicked):
3972         (on_search_backward_button_clicked):
3973         (on_search_forward_button_clicked):
3974         (window_create):
3975
3976 2013-03-14  Julie Parent  <jparent@chromium.org>
3977
3978         Cleanup: Remove g_resourceLoader.
3979         https://bugs.webkit.org/show_bug.cgi?id=112305
3980
3981         Reviewed by Dirk Pranke.
3982         
3983         Removing another global.
3984         
3985         Now, each dashboard creates its own loader, rather than having
3986         a general global one.
3987         
3988         Remove usage of g_resourceLoader.isLoadingComplete from 
3989         handleLocationChange by ensuring that handleLocationChange is
3990         never called before the loader is done.  It was called in two
3991         places before: 1 was from the callback when the loader is done,
3992         so that was obviously true, and the other was from onhashchange,
3993         where it would just return rather than running.  Instead, lets
3994         only register the onhashchange handler once the loader is
3995         setup, so the check is no longer necessary.
3996         
3997         Remove isLoadingComplete since it is now unused.
3998         
3999         Callback for loader is now initializeHistory, rather than just
4000         handleLocationChange which will set up the hashchange handler now.
4001         This will all eventually be moving to a new History object.
4002
4003         * TestResultServer/static-dashboards/aggregate_results.html:
4004         * TestResultServer/static-dashboards/dashboard_base.js:
4005         (handleLocationChange):
4006         (intializeHistory):
4007         (decompressResults):
4008         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4009         (generatePage):
4010         * TestResultServer/static-dashboards/loader.js:
4011         (.):
4012         * TestResultServer/static-dashboards/loader_unittests.js:
4013         * TestResultServer/static-dashboards/timeline_explorer.html:
4014         * TestResultServer/static-dashboards/treemap.html:
4015
4016 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
4017
4018         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
4019         https://bugs.webkit.org/show_bug.cgi?id=109404
4020
4021         Reviewed by Tony Chang.
4022
4023         Removes all the code related to smartInsertDeleteEnabled and
4024         selectTrailingWhitespaceEnabled settings as they will be managed from
4025         internals from now on.
4026
4027         * DumpRenderTree/TestRunner.cpp:
4028         (TestRunner::staticFunctions):
4029         * DumpRenderTree/TestRunner.h:
4030         (TestRunner):
4031         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4032         (WebKit):
4033         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4034         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4035         (DumpRenderTree):
4036         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4037         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4038         (WebTestRunner::WebTestProxy::didStopLoading):
4039         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4040         (WebTestRunner::TestRunner::TestRunner):
4041         (WebTestRunner::TestRunner::reset):
4042         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4043         (TestRunner):
4044         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4045         (WebTestRunner::WebPreferences::applyTo): Set default values for
4046         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4047         Chromium DRT default values are different from Chromium browser.
4048         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4049         * DumpRenderTree/chromium/WebViewHost.cpp:
4050         * DumpRenderTree/chromium/WebViewHost.h:
4051         (WebViewHost):
4052         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4053         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4054         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4055         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4056         (resetDefaultsToConsistentValues):
4057         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4058         * DumpRenderTree/mac/DumpRenderTree.mm:
4059         (resetWebViewToConsistentStateBeforeTesting):
4060         * DumpRenderTree/mac/TestRunnerMac.mm:
4061         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4062         (WebCore::WebPage::resetSettings):
4063         * DumpRenderTree/qt/TestRunnerQt.cpp:
4064         * DumpRenderTree/qt/TestRunnerQt.h:
4065         (TestRunnerQt):
4066         * DumpRenderTree/win/DumpRenderTree.cpp:
4067         (resetWebViewToConsistentStateBeforeTesting):
4068         * DumpRenderTree/win/TestRunnerWin.cpp:
4069         * DumpRenderTree/wx/TestRunnerWx.cpp:
4070
4071 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4072
4073         [Qt] Disable DRT on Windows
4074
4075         Reviewed by Jocelyn Turcotte.
4076
4077         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4078
4079         * qmake/mkspecs/features/configure.prf:
4080
4081 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4082
4083         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4084         https://bugs.webkit.org/show_bug.cgi?id=110728
4085
4086         Reviewed by Gyuyoung Kim.
4087
4088         Use the page group to create the view object.
4089
4090         * MiniBrowser/efl/main.c:
4091         (window_create):
4092
4093 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4094
4095         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4096
4097         Reviewed by Tor Arne Vestbø.
4098
4099         The mock versions of these web facing features should be instantiated when
4100         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4101         such as QtLocation are actually needed.
4102
4103         This patch decouples enabling device orientation/motion and geolocation from
4104         the underlying Qt modules and makes them available in developer builds
4105         (!production_build) and backed by mock backends when running in drt.
4106
4107         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4108         developers the web facing features are always enabled (although requests will
4109         time out) and the mock backends are enabled inside DRT, allowing for the layout
4110         tests to run with less dependencies.
4111
4112         In addition this also enables the mock device motion client, which was
4113         previously never instantiated.
4114
4115         * qmake/mkspecs/features/features.prf:
4116
4117 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4118
4119         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4120         https://bugs.webkit.org/show_bug.cgi?id=112340
4121
4122         Reviewed by Simon Hausmann.
4123
4124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4125         (DumpRenderTree::dump):
4126             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4127         (DumpRenderTree::dumpApplicationCacheQuota):
4128         * DumpRenderTree/qt/TestRunnerQt.cpp:
4129         (TestRunnerQt::reset):
4130         * DumpRenderTree/qt/TestRunnerQt.h:
4131         (TestRunnerQt):
4132
4133 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4134
4135         [Qt] Port DRT to use TestRunner::dumpAsText()
4136         https://bugs.webkit.org/show_bug.cgi?id=112260
4137
4138         Reviewed by Benjamin Poulain.
4139
4140         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4141         (WebCore::DumpRenderTree::open):
4142         (WebCore::methodNameStringForFailedTest):
4143             Change parameter from type TestRunnerQt* to TestRunner*.
4144         (WebCore::DumpRenderTree::dump):
4145             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4146             Instead we should rely on TestRunner::generatePixelResults().
4147         * DumpRenderTree/qt/TestRunnerQt.cpp:
4148         (TestRunnerQt::reset):
4149         * DumpRenderTree/qt/TestRunnerQt.h:
4150         (TestRunnerQt):
4151
4152 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4153
4154         Implement FontLoader interface
4155         https://bugs.webkit.org/show_bug.cgi?id=98395
4156
4157         Reviewed by Eric Seidel.
4158
4159         Enable FontLoadEvents runtime flag for TestShell.
4160
4161         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4162         (WebTestRunner::TestInterfaces::TestInterfaces):
4163
4164 2013-03-13  Julie Parent  <jparent@chromium.org>
4165
4166         CLeanup: remove unnecessary call to parseParameters.
4167         https://bugs.webkit.org/show_bug.cgi?id=112309
4168
4169         Reviewed by Ojan Vafai.
4170         
4171         We call parseCrossDashboardParameters when the dashboard initially
4172         loads to set the state required for loadBuildersList, and then we
4173         call it again once we are fully done with loading, so there is no
4174         reason to call it in the middle of the loading process here.
4175
4176         * TestResultServer/static-dashboards/loader.js:
4177         (.):
4178
4179 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4180
4181         Unreviewed. Now I'm a reviewer :)
4182
4183         * Scripts/webkitpy/common/config/committers.py:
4184
4185 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4186
4187         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4188         https://bugs.webkit.org/show_bug.cgi?id=112277
4189
4190         Reviewed by Adam Barth.
4191
4192         * Scripts/webkitperl/FeatureList.pm:
4193         * qmake/mkspecs/features/features.pri:
4194
4195 2013-03-13  Adam Barth  <abarth@webkit.org>
4196
4197         run-perf-tests should support content_shell
4198         https://bugs.webkit.org/show_bug.cgi?id=112291
4199
4200         Reviewed by Eric Seidel.
4201
4202         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4203         (PerfTestsRunner._parse_args):
4204
4205 2013-03-13  Oliver Hunt  <oliver@apple.com>
4206
4207         Simplify Checked<> multiplication
4208         https://bugs.webkit.org/show_bug.cgi?id=112286
4209
4210         Reviewed by James Robinson.
4211
4212         Add tests for multiplication by zero and max to ensure we don't
4213         mess them up should we ever make changes to Checked<> in future.
4214
4215         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4216         (TestWebKitAPI):
4217
4218 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4219
4220         [Qt] Unreviewed prospective Windows build fix
4221
4222         Do the usual thing, include the moc generated code in the .cpp file instead
4223         of compiling it standalone, to ensure that config.h is included, too, and
4224         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4225
4226         * DumpRenderTree/qt/EventSenderQt.cpp:
4227
4228 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4229
4230         [Qt] Port TestRunner::findString to shared interface
4231         https://bugs.webkit.org/show_bug.cgi?id=112147
4232
4233         Reviewed by Jocelyn Turcotte.
4234
4235         This patch also removes DumpRenderTree and some other helper classes from
4236         the WebCore namespace, to which they do not really belong.
4237
4238         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4239         (main):
4240         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4241         (DumpRenderTree::DumpRenderTree):
4242         (DumpRenderTree::~DumpRenderTree):
4243         (DumpRenderTree::instance):
4244         (DumpRenderTree::setShouldTimeout):
4245         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4246         (DumpRenderTree):
4247         * DumpRenderTree/qt/EventSenderQt.cpp:
4248         (EventSender::contextClick):
4249         (EventSender::sendEvent):
4250         (EventSender::postEvent):
4251         * DumpRenderTree/qt/EventSenderQt.h:
4252         (EventSender::isGraphicsBased):
4253         * DumpRenderTree/qt/TestRunnerQt.cpp:
4254         (TestRunnerQt::TestRunnerQt):
4255         (TestRunner::findString):
4256         (TestRunnerQt::setMockDeviceOrientation):
4257         (TestRunnerQt::setGeolocationPermission):
4258         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4259         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4260         (TestRunnerQt::setMockGeolocationPosition):
4261         * DumpRenderTree/qt/TestRunnerQt.h:
4262         (TestRunnerQt):
4263
4264 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4265
4266         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4267         https://bugs.webkit.org/show_bug.cgi?id=112129
4268
4269         Reviewed by Adam Barth.
4270
4271         Following Chromium
4272         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4273         this is being renamed to better explain what it does.
4274
4275         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4276
4277 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4278
4279         [Qt] Unreviewed trivial typo fix
4280
4281         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4282         TextRunner.h. Thanks Zeno :)
4283
4284 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4285
4286         [Qt] Prepare DRT for transition to shared TestRunner interface
4287         https://bugs.webkit.org/show_bug.cgi?id=112144
4288
4289         Reviewed by Benjamin Poulain.
4290
4291         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4292         the JSC C API based one.
4293
4294         This is impplemented by instantiating the QObject based testRunner in
4295         the global object, then instantiating the JSC C based TestRunner
4296         separately and placing it "behind"